Spelling fixes and tidy up a comment.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
83fc0554
DA
12013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
2
3 Do not populate pure Xism x_sync to other ports.
4 * frame.h (x_sync): Move under HAVE_X_WINDOWS.
5 * frame.c (other_visible_frames) [HAVE_X_WINDOWS]: Use as such.
6 * nsfns.m, w32xfns.c (x_sync): Remove no-op.
7 * w32term.h (x_sync): Remove prototype.
8
fd462129
DA
92013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
10
11 Cleanup frame flushing.
12 * dispextern.h (struct redisplay_interface): Drop
13 flush_display_optional because flush_display is enough
14 for X and flushing via RIF is just a no-op for others.
15 * frame.h (flush_frame): New function.
16 * dispnew.c (update_frame):
17 * minibuf.c (read_minibuf):
18 * xdisp.c (echo_area_display, redisplay_preserve_echo_area):
19 Use it.
20 * keyboard.c (detect_input_pending_run_timers): Do not flush
21 all frames but selected one in redisplay_preserve_echo_area.
22 * nsterm.m (ns_flush): Remove no-op.
23 (ns_redisplay_interface): Adjust user.
24 * w32term.h (x_flush): Remove no-op.
25 (w32_redisplay_interface): Adjust user.
26 * xterm.c (x_flush): Simplify because we do not flush all
27 frames at once any more. Adjust comment.
28 (x_redisplay_interface): Adjust user.
29
4b73fc73
PE
302013-09-07 Paul Eggert <eggert@cs.ucla.edu>
31
32 Port --without-x --enable-gcc-warnings to Fedora 19.
33 * gfilenotify.c (globals_of_gfilenotify):
34 Call g_type_init only if using an older glib version that needs it.
35
77394d40
DA
362013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
37
38 * lisp.h (last_glyphless_glyph_frame, last_glyphless_glyph_face_id)
39 (last_glyphless_glyph_merged_face_id): Remove declarations.
40 * dispextern.h (merge_glyphless_glyph_face): Add prototype.
41 * xdisp.c (last_glyphless_glyph_frame, last_glyphless_glyph_face_id)
42 (last_glyphless_glyph_merged_face_id): Now static.
43 (merge_escape_glyph_face): New function, refactored from...
44 (get_next_display_element): ...here.
45 (merge_glyphless_glyph_face): New function, refactored from...
46 (produce_glyphless_glyph): ...here...
47 * term.c (produce_glyphless_glyph): ...and here.
48
306d67bd
SM
492013-09-06 Stefan Monnier <monnier@iro.umontreal.ca>
50
51 * eval.c (eval_sub): Only call Ffunction if necessary.
52
7f6c6450
DA
532013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
54
55 Attempt to make redisplay more selective when changing cursor type.
56 * frame.h (struct frame): New bitfield cursor_type_changed.
57 * xdisp.c (cursor_type_changed): Remove.
58 (try_cursor_movement, redisplay_window, try_window_id)
59 (set_frame_cursor_types, try_window_reusing_current_matrix):
60 Adjust to use per-frame bitfield.
61 (redisplay_internal): Look for cursor type change on each visible
62 frame and consider all frames if cursor type has been changed on
63 the frame other than selected. If cursor type has been changed on
64 selected frame only, do not use fast update.
65
bd0443bb
DA
662013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
67
68 Attempt to make redisplay more selective when changing fonts.
69 * frame.h (struct frame): New bitfield fonts_changed.
70 * dispextern.h (fonts_changed_p, adjust_glyphs): Remove declaration.
71 (adjust_frame_glyphs): Add prototype.
72 * dispnew.c (fonts_changed_p): Remove.
8bda01d3 73 (adjust_glyphs): Remove because we do not
bd0443bb
DA
74 adjust matrices on all frames at once any more.
75 (adjust_frame_glyphs): Block and unblock input here.
76 (adjust_glyph_matrix): Use fonts_changed.
77 (change_frame_size_1): Use adjust_frame_glyphs.
78 * font.c (font_open_entity): Use fonts_changed.
79 * frame.c (set_menu_bar_lines, Fmake_terminal_frame):
80 * w32fns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_show_tip):
81 * window.c (Fdelete_other_windows_internal, Fwindow_resize_apply)
82 (Fsplit_window_internal, Fdelete_window_internal, grow_mini_window)
83 (shrink_mini_window, Fresize_mini_window_internal)
84 (window_scroll_pixel_based, Fset_window_configuration)
85 (apply_window_adjustment, Fset_window_vscroll):
86 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_show_tip):
87 Use adjust_frame_glyphs.
88 * xdisp.c (redisplay_tool_bar, redisplay_window, try_window)
89 (try_window_reusing_current_matrix, try_window_id, display_line)
90 (IT_EXPAND_MATRIX_WIDTH): Use fonts_changed.
91 (redisplay_internal): Consider fonts_changed and adjust frame
92 matrices for each frame only if the frame is visible. If font
93 has been changed on some frame during full redisplay, retry
94 only visible frames where the font has been actually changed.
95
b9695828
DA
962013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
97
98 Cache current header and mode line height for each window.
99 * window.h (struct window): New fields mode_line_height
100 and header_line_height.
101 * window.c (make_window): Initialize them.
102 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
103 (CURRENT_HEADER_LINE_HEIGHT): Use them. Adjust comment.
104 (current_mode_line_height, current_header_line_height):
105 Remove declaration.
106 * xdisp.c (current_mode_line_height, current_header_line_height):
107 Remove.
108 (pos_visible_p, init_xdisp): Adjust user.
109 (redisplay_window): Invalidate mode_line_height and
110 header_line_height if current and desired matrices do not agree.
111
66738305
DA
1122013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
113
114 * fontset.c, window.c, xdisp.c (toplevel): Use TERM_HEADER.
115 * xfaces.c (toplevel) [HAVE_X_WINDOWS]: Do not include xterm.h twice.
116
257b3b03
DA
1172013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
118
119 Make --without-x compatible with --enable-gcc-warnings.
120 * font.c (register_font_driver): Move check under HAVE_WINDOW_SYSTEM.
121 * font.h (struct font_driver): Move draw, get_bitmap and free_bitmap
122 members under HAVE_WINDOW_SYSTEM.
123 * keyboard.c (make_lispy_focus_out): Likewise.
124 (record_menu_key): Move under HAVE_MENUS.
125 * xdisp.c (toplevel): Move hourglass_shown_p, hourglass_atimer and
126 THIN_SPACE_WIDTH under HAVE_WINDOW_SYSTEM.
127 (syms_of_xdisp): Adjust user.
128 (window_box_edges): Define only if HAVE_WINDOW_SYSTEM.
129 (start_hourglass, cancel_hourglass):
130 * xfaces.c (toplevel): Likewise with PT_PER_INCH,
131 clear_font_table_count, CLEAR_FONT_TABLE_COUNT
132 and CLEAR_FONT_TABLE_NFONTS.
133 (set_font_frame_param, clear_face_gcs, realize_non_ascii_face):
134 Declare only if HAVE_WINDOW_SYSTEM.
135 (lface_same_font_attributes_p, clear_face_gcs): Define only
136 if HAVE_WINDOW_SYSTEM.
137
98b7f4bd
DA
1382013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
139
140 * frame.c (check_minibuf_window): Update 'frame' with frame pointer.
141 * xterm.c (x_scroll_bar_handle_click) [!USE_TOOLKIT_SCROLL_BARS]:
142 Don't pass C integer to XINT (tiny fix for 2013-09-03 change).
143
a7e43722
SM
1442013-09-05 Stefan Monnier <monnier@iro.umontreal.ca>
145
146 * cmds.c (Fself_insert_command): Don't pass a non-integer to XINT.
147
0c90b9ee
PE
1482013-09-04 Paul Eggert <eggert@cs.ucla.edu>
149
150 * alloc.c (make_event_array): First arg is now ptrdiff_t, not int.
151 This fixes a type error on hosts where ptrdiff_t is wider than int.
152
d99760fa
SM
1532013-09-04 Stefan Monnier <monnier@iro.umontreal.ca>
154
6629638e
SM
155 * keyboard.c (read_key_sequence_vs): New function.
156 (Fread_key_sequence_vector, Fread_key_sequence): Use it to factor out
157 common code.
158
d99760fa
SM
159 * callint.c (Fcall_interactively): Always return a vector for 'K'.
160
224e313d
PE
1612013-09-04 Paul Eggert <eggert@cs.ucla.edu>
162
163 Makefile improvements.
164 * Makefile.in (config.status): Don't use double-colon rules, as
165 they are not portable according to POSIX. Fix shell typo with `;
166 I guess this rule has never been tested?
167 (VCSWITNESS): New macro, to override any environment var.
168
6d6ed1af
DA
1692013-09-04 Dmitry Antipov <dmantipov@yandex.ru>
170
171 * xterm.h (struct x_display_info): Do not track X connection
172 fd separately because it is always available from Display.
173 * xterm.c (x_term_init, x_delete_terminal, x_delete_display):
174 Adjust users.
175
bc923770
DA
1762013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
177
178 * buffer.c (drop_overlay):
179 * fileio.c (restore_point_unwind): Prefer unchain_marker to
180 Fset_marker (X, Qnil, ...) (which is the same but a bit slower).
181
b1cf96de
DA
1822013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
183
184 * buffer.c (Fmake_overlay, Fmove_overlay):
185 * intervals.c (set_point_from_marker):
186 * print.c (PRINTPREPARE): Prefer signal_error
187 to plain error and report unsuitable marker too.
188
d1fc6c21
DA
1892013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
190
191 * xterm.h (struct scroll_bar): Prefer int to Lisp_Object
192 for 'dragging' member.
d1ae6a0b
DA
193 (struct x_output): Remove set-but-unused leftovers
194 'left_before_move' and 'top_before_move'.
d1fc6c21
DA
195 * gtkutil.c (xg_set_toolkit_scroll_bar_thumb):
196 * xterm.c (xt_action_hook, xm_scroll_callback, xg_scroll_callback)
197 (xg_end_scroll_callback, xaw_jump_callback, xaw_scroll_callback)
198 (x_set_toolkit_scroll_bar_thumb, x_scroll_bar_create)
199 (x_scroll_bar_set_handle, XTset_vertical_scroll_bar)
200 (x_scroll_bar_handle_click, x_scroll_bar_note_movement)
d1ae6a0b 201 (x_scroll_bar_report_motion, x_set_offset): Related users changed.
ec5e7504 202 * xfns.c, image.c (XLIB_ILLEGAL_ACCESS): No longer needed.
d1fc6c21 203
0ce9f6de
JD
2042013-09-03 Jan Djärv <jan.h.d@swipnet.se>
205
206 * nsfont.m (INVALID_GLYPH): New define.
207 (nsfont_encode_char): Use INVALID_GLYPH.
208 (ns_uni_to_glyphs): Ditto, check for NSNullGlyph (Bug#15138).
209
b594a96c
DA
2102013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
211
212 * xterm.c (x_last_mouse_movement_time): Revert last change.
213 This code should use XDisplayMotionBufferSize to check display's
214 motion history first, and there are few other issues as well.
215 (x_scroll_bar_note_movement): Pass XMotionEvent rather than XEvent.
216 (handle_one_xevent): Adjust user.
217
8b098236
MR
2182013-09-02 Martin Rudalics <rudalics@gmx.at>
219
9718b207
MR
220 * dispnew.c (Flast_nonminibuf_frame): Move from here ...
221 * frame.c (Flast_nonminibuf_frame): ... to here.
222 (check_minibuf_window): Don't abort if no window was found
223 (Bug#15247).
8b098236 224
84e70bba
DA
2252013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
226
227 Use XGetMotionEvents to ask the last mouse motion time from X server.
228 * xterm.c (X_MOTION_HISTORY): Default to 1.
229 (x_last_mouse_movement_time) [X_MOTION_HISTORY]: New function.
230 (x_last_mouse_movement_time) [!X_MOTION_HISTORY]: Legacy version.
231 (note_mouse_movement, x_scroll_bar_note_movement) [!X_MOTION_HISTORY]:
232 Ifdef away legacy code.
233 (XTmouse_position, x_scroll_bar_report_motion):
234 Use x_last_mouse_movement_time.
fc85e20b
DA
235 (handle_one_xevent): Use event.xunmap and not event.xmap when handling
236 UnmapNotify event.
84e70bba 237
1fccc530
DA
2382013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
239
240 * msdos.c (last_mouse_window): Move to...
241 (dos_rawgetc): ...this function and adjust comment.
242 * nsterm.m (last_window): Rename to last_mouse_window, move to...
243 (mouseMoved): ...this function and adjust comment.
244 * w32term.c (last_window): Likewise with...
245 (w32_read_socket): ...this function.
246 * xterm.c (last_window): Likewise with...
247 (handle_one_xevent): ...this function.
248
0ab10992
DA
2492013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
250
b7da754d 251 * window.h (Vmouse_window, Vmouse_event): Remove the leftovers.
0ab10992
DA
252 * xterm.c (toplevel): Drop obsolete comment and move compose_status...
253 (handle_one_xevent): ...to here.
254 (STORE_KEYSYM_FOR_DEBUG): Move under ENABLE_CHECKING and make no-op
255 otherwise.
256
0c7f856e
DA
2572013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
258
259 * msdos.c (IT_set_terminal_window): Remove no-op.
260 (initialize_msdos_display): Adjust terminal setup.
261 * w32console.c (w32con_set_terminal_window): Remove no-op.
262 (initialize_w32_display): Adjust terminal setup.
263 * w32term.c (w32_set_terminal_window): Remove no-op.
264 (w32_create_terminal): Adjust terminal setup.
265 * xterm.c (XTset_terminal_window): Remove no-op.
266 (x_create_terminal): Adjust terminal setup.
267
a892a94c
DA
2682013-09-01 Dmitry Antipov <dmantipov@yandex.ru>
269
270 * nsterm.m (ns_set_terminal_modes, ns_reset_terminal_modes):
271 Remove no-ops.
272 (ns_create_terminal): Adjust terminal setup.
273 * w32term.c (w32_set_terminal_modes, w32_reset_terminal_modes):
274 Remove no-ops.
275 (w32_create_terminal): Adjust terminal setup.
276 * xterm.c (XTset_terminal_modes, XTreset_terminal_modes):
277 Remove no-ops.
278 (x_create_terminal): Adjust terminal setup.
279
cf91889a
DA
2802013-09-01 Dmitry Antipov <dmantipov@yandex.ru>
281
282 * dispextern.h (SET_TEXT_POS_FROM_MARKER): Indent.
283 (CLIP_TEXT_POS_FROM_MARKER): New macro.
284 * dispnew.c (buffer_posn_from_coords):
285 * window.c (Fwindow_end, displayed_window_lines):
286 * xdisp.c (redisplay_mode_lines): Use it.
287
5b0891df
JD
2882013-09-01 Jan Djärv <jan.h.d@swipnet.se>
289
290 * fontset.c (face_for_char): Check char in the current face font first
291 if HAVE_NS (Bug#15138).
292
0a357e98
MR
2932013-08-31 Martin Rudalics <rudalics@gmx.at>
294
295 * window.c (temp_output_buffer_show): Make sure window returned
296 by display_buffer is live (Bug#15213).
297
9d7693d7
DA
2982013-08-30 Dmitry Antipov <dmantipov@yandex.ru>
299
300 Minor cleanup to avoid forward declarations.
301 * coding.h (struct ccl_spec): Remove forward declaration.
302 * composite.h (toplevel): Include font.h.
303 (struct composition_it, struct face, struct font_metrics):
304 Remove forward declaration.
305 * dispextern.h (struct image, struct atimer): Likewise.
306 * emacsgtkfixed.h (struct frame): Likewise.
307 * emacsgtkfixed.c (toplevel): Reorder headers and drop stdio.h.
308 * font.h (struct font_driver, struct font, struct glyph_string)
309 (struct face): Remove forward declaration.
310 * fontset.h (struct face, struct font): Likewise.
311 * frame.h (toplevel): Style cleanup.
312 (enum output_method): Move to...
313 * termhooks.h (enum output_method): ...here.
314 (struct glyph, struct frame, struct ns_display_info)
315 (struct x_display_info, struct w32_display_info):
316 Remove forward declaration.
317 * xterm.h (toplevel): Include termhooks.h.
318 (struct font, struct window, struct glyph_matrix, struct frame)
319 (struct input_event, struct face, struct image): Remove forward
320 declaration.
321 * gtkutil.h (struct _widget_value): Likewise.
322 * keyboard.h (toplevel): Include termhooks.h.
323 (struct input_event): Remove forward declaration.
324
032f7451
DA
3252013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
326
327 * intervals.c (set_point_from_marker): New function.
328 * editfns.c (Fgoto_char):
329 * process.c (Finternal_default_process_filter):
330 * window.c (select_window_1): Use it.
331 * buffer.h (set_point_from_marker): Add prototype.
332
3f940c5a
EZ
3332013-08-29 Eli Zaretskii <eliz@gnu.org>
334
335 * w32.c (term_winsock): Call release_listen_threads before calling
336 WSACleanup.
337 (_sys_wait_accept): Wait for accept event in a loop with a finite
338 timeout, instead of waiting indefinitely. Will hopefully avoid
339 hanging during exit because WSACleanup deadlocks waiting for the
340 event object to be released. (Bug#14333)
341
342 * w32proc.c (release_listen_threads): New function, signals all
343 the reader threads that listen for connections to stop waiting.
344
345 * w32.h (release_listen_threads): Add prototype.
346
101ed2bb
DA
3472013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
348
349 * alloc.c (Fmake_marker, build_marker): Zero need_adjustment
350 field of new marker (for sanity and safety).
20de2834
DA
351 * lisp.h (XSETMARKER): Remove unused macro (it doesn't work
352 anyway because XMISCTYPE is a function and can't be an lvalue).
101ed2bb 353
1f5cf200
DA
3542013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
355
356 * xterm.c (x_clear_area): Lost 7th arg because it is always False.
357 (x_after_update_window_line, x_scroll_bar_create):
358 (x_scroll_bar_set_handle, XTset_vertical_scroll_bar):
359 (handle_one_xevent, x_clear_frame_area):
360 * gtkutil.c (xg_clear_under_internal_border, xg_update_scrollbar_pos):
361 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Adjust users.
362 * xterm.h (x_clear_area): Adjust prototype.
363
d2b36813
DA
3642013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
365
366 Hook scanning and indentation functions to find_newline. This helps
367 to avoid duplicated code and renders more respect to newline cache.
368 * lisp.h (scan_newline): Prefer ptrdiff_t to EMACS_INT.
369 * cmds.c (Fforward_line):
370 * indent.c (scan_for_column, Fcurrent_indentation, indented_beyond_p):
371 Use find_newline and avoid unnecessary point movements.
372 * search.c (scan_newline): Implement on top of find_newline.
373
3ec7babc
SM
3742013-08-28 Stefan Monnier <monnier@iro.umontreal.ca>
375
376 * eval.c (Ffuncall): Fix handling of ((lambda ..) ..) in lexically
377 scoped code (bug#11258).
378
5ab473cd
JD
3792013-08-28 Davor Cubranic <cubranic@stat.ubc.ca> (tiny change)
380
381 * nsterm.m (last_window): New variable.
382 (EV_TRAILER2): New macro.
383 (EV_TRAILER): Call EV_TRAILER2.
384 (mouseMoved:): Add support for mouse-autoselect-window
385 on nextstep (Bug#6888).
386
78779650
AS
3872013-08-28 Andreas Schwab <schwab@suse.de>
388
389 * regex.c (CHAR_CHARSET, CHARSET_LEADING_CODE_BASE, CHAR_HEAD_P)
390 (SINGLE_BYTE_CHAR_P, SAME_CHARSET_P, MAKE_CHAR, BYTE8_TO_CHAR):
391 Remove unused macro definitions.
392 (CHARSET_RANGE_TABLE_BITS, EXTEND_RANGE_TABLE)
3ec7babc
SM
393 (SET_RANGE_TABLE_WORK_AREA_BIT, SET_RANGE_TABLE_WORK_AREA):
394 Only define if emacs.
78779650 395
c3c4768d
DA
3962013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
397
398 Prefer enum glyph_row_area to int where appropriate.
399 * dispextern.h (enum glyph_row_area): Add ANY_AREA member.
400 Fix comment.
401 (window_box, window_box_width, window_box_left, window_box_left_offset)
402 (window_box_right, window_box_right_offset): Adjust prototypes.
403 * xdisp.c (window_box, window_box_width, window_box_left)
404 (window_box_left_offset, window_box_right, window_box_right_offset):
405 Use enum glyph_row_area. Adjust users and tweak comment where needed.
406 (window_box_edges): Likewise. Lost 2nd arg since it is always ANY_AREA.
407 * nsterm.m (ns_clip_to_row):
408 * w32term.c (w32_clip_to_row):
409 * xterm.c (x_clip_to_row): Likewise.
410
6bdcbfe1
DA
4112013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
412
413 * buffer.c (Foverlays_at, Foverlays_in, Fnext_overlay_change)
414 (Fprevious_overlay_change): Fast path for buffer with no overlays.
415
50b13cde
PE
4162013-08-28 Paul Eggert <eggert@cs.ucla.edu>
417
418 * Makefile.in (SHELL): Now @SHELL@, not /bin/sh,
419 for portability to hosts where /bin/sh has problems.
420
f60e429a
DA
4212013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
422
423 Redesign redisplay interface to drop global output_cursor.
424 * dispextern.h (struct redisplay_interface): Remove cursor_to member.
425 (toplevel): Remove declaration of output_cursor.
426 (set_output_cursor, x_cursor_to): Remove prototype.
427 * window.h (struct window): New member output_cursor.
428 (output_cursor_to): New function to replace RIF member.
429 * dispnew.c (redraw_overlapped_rows, update_marginal_area)
430 (update_text_area, set_window_cursor_after_update): Use it.
431 * xdisp.c (output_cursor, set_output_cursor, x_cursor_to): Remove.
432 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
433 * nsterm.m (ns_update_window_begin, ns_update_window_end):
434 * w32term.c (x_update_window_begin, x_update_window_end):
435 * xterm.c (x_update_window_begin, x_update_window_end):
436 Adjust to use per-window output cursor.
437
43aac990
PE
4382013-08-27 Paul Eggert <eggert@cs.ucla.edu>
439
d486344e
PE
440 Simplify SELECT_TYPE-related code.
441 Like EMACS_TIME, this portability layer is no longer needed, since
442 Emacs has been using fd_set as a portability layer for some time.
443 * sysselect.h (FD_SETSIZE): Rename from MAXDESC. All uses changed.
444 (SELECT_TYPE): Remove. All uses changed to fd_set.
445 (fd_set) [!FD_SET]: New typedef.
446
43aac990
PE
447 Simplify EMACS_TIME-related code.
448 This portability layer is no longer needed, since Emacs has been
449 using struct timespec as a portability layer for some time.
450 * atimer.h, buffer.h, dispextern.h, xgselect.h:
451 Include <time.h> rather than "systime.h"; that's all that's needed now.
452 * dispnew.c: Include <timespec.h> rather than "systime.h";
453 that's all that's needed now.
454 * systime.h (EMACS_TIME): Remove. All uses changed to struct timespec.
455 (EMACS_TIME_RESOLUTION): Remove. All uses changed to
456 TIMESPEC_RESOLUTION.
457 (LOG10_EMACS_TIME_RESOLUTION): Remove. All uses changed to
458 LOG10_TIMESPEC_RESOLUTION.
459 (EMACS_SECS, emacs_secs_addr): Remove. All uses changed to tv_sec.
460 (EMACS_NSECS): Remove. All uses changed to tv_nsec.
461 (make_emacs_time): Remove. All used changed to make_timespec.
462 (invalid_timespec): Rename from invalid_emacs_time. All uses changed.
463 (current_timespec): Rename from current_emacs_time. All uses changed.
464 (add_emacs_time): Remove. All uses changed to timespec_add.
465 (sub_emacs_time): Remove. All uses change dot timespec_sub.
466 (EMACS_TIME_SIGN): Remove. All uses changed to timespec_sign.
467 (timespec_valid_p): Rename from EMACS_TIME_VALID_P. All uses changed.
468 (EMACS_TIME_FROM_DOUBLE): Remove. All uses changed to dtotimespec.
469 (EMACS_TIME_TO_DOUBLE): Remove. All uses changed to timespectod.
470 (current_timespec): Rename from current_emacs_time. All uses changed.
471 (EMACS_TIME_EQ, EMACS_TIME_LT, EMACS_TIME_LE): Remove. All uses
472 changed to timespec_cmp.
473 * xgselect.c: Include <timespec.h>, since our .h files don't.
474
d350e350
DA
4752013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
476
477 * xterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE:)
478 * nsterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE):
479 Remove the leftovers.
480 * gtkutil.c (toplevel): Do not declare Qxft but include
481 font.h to do so.
482 * image.c (toplevel): Do not declare Vlibrary_cache because
483 it's already done in lisp.h.
484
9fed9729
DA
4852013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
486
487 * lisp.h (Mouse_HLInfo): Move from here...
488 * dispextern.h (Mouse_HLInfo): ...to here and offload lisp.h.
489 (reset_mouse_highlight): New function.
490 * msdos.c (dos_set_window_size, IT_update_begin)
491 (internal_terminal_init):
492 * nsterm.m (ns_update_window_end, x_free_frame_resources)
493 (ns_initialize_display_info):
494 * w32console.c (initialize_w32_display):
495 * w32term.c (x_update_window_end, x_free_frame_resources)
496 (w32_initialize_display_info):
497 * xterm.c (x_update_window_end, x_free_frame_resources, x_term_init):
498 * window.c (Fdelete_other_windows_internal):
499 * xdisp.c (clear_mouse_face, cancel_mouse_face): Use it.
500 * termchar.h (toplevel):
501 * xterm.h (toplevel): Include dispextern.h.
502
f462f075
PE
5032013-08-26 Paul Eggert <eggert@cs.ucla.edu>
504
505 Fix minor problems found by static checking.
506 * image.c (XGetPixel, XPutPixel) [HAVE_NS]: Now static.
507 (expect): Avoid nested-if warning.
508 (x_build_heuristic_mask) [HAVE_NS]: Avoid unused-var warning.
509 * nsmenu.m (fillWithWidgetValue:): Avoid type warning.
510 * nsterm.h, nsterm.m (ns_select):
511 * xgselect.c, xgselect.h (xg_select):
512 Adjust signature to better match pselect's.
513 * nsterm.m (ns_select):
514 Don't set *TIMEOUT, since pselect doesn't.
515 * regex.c (whitespace_regexp): Now const_re_char *, to avoid
516 diagnostic about assigning const char * to it.
517 * xfaces.c (x_display_info) [HAVE_NS]: Remove; unused.
518
068f9124
SM
5192013-08-26 Stefan Monnier <monnier@iro.umontreal.ca>
520
521 * lread.c (substitute_object_recurse): Handle hash-tables as well
522 (bug#15190).
523
f5adc984
PE
5242013-08-26 Paul Eggert <eggert@cs.ucla.edu>
525
1fc8eb33
PE
526 Fix unlikely core dump in init_tty, and simplify terminfo case.
527 * term.c (init_tty) [TERMINFO]: Fix check for buffer overrun.
528 The old version incorrectly dumped core if malloc returned a
529 buffer containing only non-NUL bytes.
530 (init_tty): Do not allocate or free termcap buffers; the
531 struct does that for us now.
532 * termchar.h (TERMCAP_BUFFER_SIZE) [!TERMINFO]: New constant.
533 (struct tty_display_info): Define members termcap_term_buffer and
534 termcap_strings_buffer only if !TERMINFO, since terminfo doesn't
535 use them. Allocate them directly in struct rather than indirectly
536 via a pointer, to simplify init_tty.
537
f5adc984
PE
538 * frame.c (check_minibuf_window): Initialize 'window' properly,
539 so that Emacs reliably aborts later if 'window' is not initialized.
540
efec3894
JD
5412013-08-26 Jan Djärv <jan.h.d@swipnet.se>
542
543 * gtkutil.c (xg_initialize): Set gtk-menu-bar-accel to "" instead
544 of VoidSymbol (Bug#15154).
545
e1d0341e
DA
5462013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
547
548 * lisp.h (Mouse_HLInfo): Drop set-but-unused members
549 mouse_face_beg_y and mouse_face_end_y.
550 * xdisp.c (note_tool_bar_highlight, mouse_face_from_buffer_pos)
551 (mouse_face_from_string_pos, note_mode_line_or_margin_highlight):
552 Adjust users and update comment where appropriate.
553
bfff6445
MR
5542013-08-26 Martin Rudalics <rudalics@gmx.at>
555
556 * frame.c (check_minibuf_window): New function.
068f9124
SM
557 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
558 Call check_minibuf_window (Bug#15183).
bfff6445 559
c80016b3
DA
5602013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
561
562 * window.h (struct window): Replace last_cursor with last_cursor_vpos
563 because this is the only last cursor data we need to keep and consult.
564 * window.c (replace_window, set_window_buffer, Fsplit_window_internal):
565 * xdisp.c (mark_window_display_accurate_1, try_cursor_movement):
566 Adjust users.
567
de396731
DA
5682013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
569
068f9124
SM
570 Fix recovering from possible decompression error.
571 Since insert_from_gap doesn't always move point, we can't use PT as
de396731 572 the position where the partially decompressed data ends, and
447218dd 573 should count how many bytes was produced so far.
de396731
DA
574 * decompress.c (struct decompress_unwind_data): Add nbytes member.
575 (unwind_decompress): Really delete partially uncompressed data.
576 (Fzlib_decompress_region): Take decompressed data size into account.
577
c76826d9
DA
5782013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
579
580 * syntax.c (init_syntax_once): Adjust comment and do an early
581 initialization of Qchar_table_extra_slots just once...
582 * casetab.c (init_casetab_once):
583 * category.c (init_category_once):
584 * character.c (syms_of_character):
585 * coding.c (syms_of_coding):
586 * xdisp.c (syms_of_xdisp): ...and omit it here.
587
b34454d0
EZ
5882013-08-24 Eli Zaretskii <eliz@gnu.org>
589
11f20add
EZ
590 * xdisp.c (get_next_display_element): Don't apply to characters
591 from a display vector the logic of setting it->end_of_box_run_p
592 suitable for characters from a buffer. (Bug#15175)
593
b34454d0
EZ
594 * w32.c (fdutimens): Call 'utime', which is implemented on w32.c
595 to handle directories, rather than '_utime' which doesn't.
596 (Bug#15176)
597
6e1b469e
JD
5982013-08-24 Jan Djärv <jan.h.d@swipnet.se>
599
600 * gtkutil.c (x_wm_set_size_hint): Don't set hints when maximized
601 or fullscreen (Bug#14627).
602
9c05bccf
PE
6032013-08-24 Paul Eggert <eggert@cs.ucla.edu>
604
605 System-dependent integer overflow fixes.
606 * process.c (Fset_process_window_size): Signal an error if
607 the window size is outside the range supported by the lower level.
608 * sysdep.c (set_window_size): Return negative on error,
609 nonnegative on success, rather than -1, 0, 1 on not in system,
610 failure, success. This is simpler. Caller changed.
611 (serial_configure): Remove unnecessary initialization of local.
612 (procfs_get_total_memory) [GNU_LINUX]: Don't assume system memory
613 size fits in unsigned long; this isn't true on some 32-bit hosts.
614 Avoid buffer overrun if some future version of /proc/meminfo has a
615 variable name longer than 20 bytes.
616 (system_process_attributes) [__FreeBSD__]:
617 Don't assume hw.availpages fits in 'int'.
618
c365c355
PE
6192013-08-23 Paul Eggert <eggert@cs.ucla.edu>
620
621 Don't let very long directory names overrun the stack.
622 Fix some related minor problems involving "//", vfork.
623 * callproc.c (encode_current_directory): New function.
624 (call_process): Don't append "/"; not needed.
625 * fileio.c (file_name_as_directory_slop): New constant.
626 (file_name_as_directory): Allow SRC to be longer than SRCLEN;
627 this can save the caller having to alloca.
628 (Ffile_name_as_directory, Fdirectory_file_name, Fexpand_file_name):
629 Use SAFE_ALLOCA, not alloca.
630 (directory_file_name, Fexpand_file_name): Leave leading "//"
631 alone, since it can be special even on POSIX platforms.
632 * callproc.c (call_process):
633 * process.c (Fformat_network_address):
634 * sysdep.c (sys_subshell):
635 Use encode_current_directory rather than rolling our own.
636 (create_process): No need to encode directory; caller does that now.
637 * process.h (encode_current_directory): New decl.
638 * sysdep.c (sys_subshell): Work even if vfork trashes saved_handlers.
639 Rework to avoid 'goto xyzzy;'.
640
6c6014d4
EZ
6412013-08-23 Eli Zaretskii <eliz@gnu.org>
642
643 * xdisp.c (handle_face_prop): If the default face was remapped use
644 the remapped face for strings from prefix properties. (Bug#15155)
645
9997ec56
DA
6462013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
647
648 Minor cleanup for redisplay interface and few related functions.
649 * frame.h (enum text_cursor_kinds): Move from here...
650 * dispextern.h (enum text_cursor_kinds): ...to here.
651 (toplevel): Drop unnecessary declarations.
652 (struct redisplay_interface): Use bool and enum text_cursor_kinds
653 in update_window_end_hook and draw_window_cursor functions.
654 (display_and_set_cursor, x_update_cursor): Adjust prototypes.
655 * nsterm.m (ns_update_window_end, ns_draw_window_cursor):
656 * w32term.c (x_update_window_end,w32_draw_window_cursor):
657 * xterm.c (x_update_window_end, x_draw_window_cursor):
658 * xdisp.c (display_and_set_cursor, update_window_cursor)
659 (update_cursor_in_window_tree, x_update_cursor): Use bool and
660 enum text_cursor_kinds where appropriate.
661
7f780da6
DA
6622013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
663
664 Redesign redisplay interface to drop updated_row and updated_area.
665 * dispextern.h (updated_row, updated_area): Remove declaration.
666 (struct redisplay_interface): Pass glyph row and row area parameters
667 to write_glyphs, insert_glyphs and clear_end_of_line functions.
668 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
669 Adjust prototypes.
670 * dispnew.c (updated_row, updated_area): Remove.
671 (redraw_overlapped_rows, update_window_line): Adjust user.
672 (update_marginal_area, update_text_area): Likewise. Pass updated row
673 as a parameter. Prefer enum glyph_row_area to int where appropriate.
674 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
675 Adjust users.
676
26495794
PE
6772013-08-22 Paul Eggert <eggert@cs.ucla.edu>
678
679 * process.c (flush_pending_output): Remove stub.
680 All uses removed.
681
4a88129a
PE
6822013-08-21 Paul Eggert <eggert@cs.ucla.edu>
683
684 * callproc.c: Fix race that killed background processes (Bug#15144).
685 (call_process): New arg TEMPFILE_INDEX. Callers changed.
686 Record deleted process-id in critical section, not afterwards.
687 Don't mistakenly kill process created by a call-process invocation
688 that discards output and does not wait.
689
0c5307b0
DA
6902013-08-21 Dmitry Antipov <dmantipov@yandex.ru>
691
692 Fix compilation with GC_MARK_STACK == GC_USE_GCPROS_AS_BEFORE
693 and GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES.
694 * alloc.c (toplevel): Remove unnecessary nested #if...#endif.
695 (mark_maybe_object) [!GC_MARK_STACK]: Define to emacs_abort
696 to shut up compiler in mark_object.
697 (dump_zombies): Convert to global and add EXTERNALLY_VISIBLE.
698
0d7c1e66
PE
6992013-08-21 Paul Eggert <eggert@cs.ucla.edu>
700
701 * process.c (allocate_pty) [PTY_OPEN]: Set fd's FD_CLOEXEC flag.
702 We can't portably rely on PTY_OPEN doing that, even if
703 it calls posix_openpt with O_CLOEXEC.
704
3f246b65
KH
7052013-08-20 Kenichi Handa <handa@gnu.org>
706
707 * character.c (string_char): Improve commentary.
708
8c2f38aa
PE
7092013-08-20 Paul Eggert <eggert@cs.ucla.edu>
710
711 * image.c (SIGNATURE_DIGESTSIZE): Remove.
712 (struct animation_cache): Make signature a flexible array member.
713 All uses changed. This is a tad slower but may insulate us better
714 from future changes to ImageMagick.
715
bb566cea
PE
7162013-08-19 Paul Eggert <eggert@cs.ucla.edu>
717
718 * image.c: Shrink memory needed for animation cache.
719 (SIGNATURE_DIGESTSIZE): New constant.
720 (struct animation_cache): Make 'signature' a fixed size array of bytes.
721 (imagemagick_create_cache): Copy the signature. This saves
722 several KB of memory that ImageMagick wastes per signature.
723 Don't bother updating the update_time, as the caller does that now.
724 (imagemagick_prune_animation_cache): Don't destroy the signature, as
725 it's a fixed size struct member now.
726 (imagemagick_get_animation_cache): Always destroy the signature,
727 as it's now imagemagick_create_cache's responsibility to copy it.
728 Avoid duplicate calls to strcmp and to imagemagick_create_cache,
729 and use memcmp rather than strcmp.
730 eassert that ImageMagick returns a signature of the specified length.
731
6da26928
LMI
7322013-08-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
733
734 * image.c (imagemagick_get_animation_cache): Don't segfault on
735 each invocation.
453f4022
LMI
736 (imagemagick_get_animation_cache): Revert to previous definition
737 so that it actually works. But keep the memory leak fix.
738 (imagemagick_get_animation_cache): Fix memory leak.
6da26928 739
22490125
PE
7402013-08-19 Paul Eggert <eggert@cs.ucla.edu>
741
d0139df5
PE
742 * image.c: Fix animation cache signature memory leak.
743 Fix some other minor performance problems while we're at it.
744 (imagemagick_create_cache): Clear just the members that
745 need clearing. Don't set update_time, as caller does that now.
746 (imagemagick_prune_animation_cache, imagemagick_get_animation_cache):
747 Simplify by using pointer-to-pointer instead of a prev pointer.
748 (imagemagick_prune_animation_cache): Use make_emacs_time rather
749 than EMACS_TIME_FROM_DOUBLE, and DestroyString rather than free.
750 (imagemagick_get_animation_cache): Don't xstrdup the image signature;
751 it's already a copy. Free the signature probe unless it's cached.
752
22490125
PE
753 * process.c (handle_child_signal): Fix crash; deleted pid (Bug#15106).
754 This was introduced by my 2013-08-12 fix for Bug#15035.
755
deb31e75
DA
7562013-08-19 Dmitry Antipov <dmantipov@yandex.ru>
757
758 * image.c (imagemagick_create_cache, imagemagick_get_animation_cache)
759 (imagemagick_prune_animation_cache): Now static.
760
319a4d03
LMI
7612013-08-18 Lars Magne Ingebrigtsen <larsi@gnus.org>
762
763 * image.c (imagemagick_get_animation_cache): Don't segfault when
764 pruning all entries.
765
f747d82e
KB
7662013-08-18 Ken Brown <kbrown@cornell.edu>
767
768 * sheap.c (STATIC_HEAP_SIZE): Adjust to current needs; use bigger
769 static heap if ENABLE_CHECKING is defined.
770 (max_bss_sbrk_ptr): New variable.
771 (bss_sbrk): Use it.
772 (report_sheap_usage): Report maximum static heap usage instead of
773 ending static heap usage.
774
d2c28fab
EZ
7752013-08-17 Eli Zaretskii <eliz@gnu.org>
776
777 * decompress.c (Fzlib_available_p) [WINDOWSNT]: Update the value
778 of zlib_initialized according to the results of calling
779 init_zlib_functions.
780
274ff63f
LMI
7812013-08-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
782
783 * image.c: Implement an ImageMagick per-image cache.
8a6f875f 784 (imagemagick_get_animation_cache): Fix a double-free error.
49ceb676
LMI
785 (imagemagick_load_image): Remove the ping_wand code, which only
786 apparently saved time on invalid animated images, and slowed down
787 everything else. Optimise for the common case.
274ff63f 788
2bede2ed
XF
7892013-08-16 Xue Fuqiao <xfq.free@gmail.com>
790
70ff8240
XF
791 * buffer.c (syms_of_buffer) <buffer-undo-list>: Doc fix.
792
de179a3e
XF
793 * editfns.c (insert_before_markers): Mention overlay in the doc string.
794
2bede2ed
XF
795 * marker.c (set_marker): Remove documentation of undefined behavior.
796
703dbeba
LMI
7972013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
798
799 * image.c (imagemagick_compute_animated_image): Animate correctly
800 when sub-images are smaller than the main image.
1d18b1e6
LMI
801 (imagemagick_compute_animated_image): Setting the iterator row to
802 zero is apparently not allowed.
79670014
LMI
803 (imagemagick_compute_animated_image): Allow images that say they
804 have sub-images that are bigger than the main image, but just crop
805 them.
703dbeba 806
63216c5e
JD
8072013-08-15 Jan Djärv <jan.h.d@swipnet.se>
808
809 * nsmenu.m (menuWillOpen:): Fix preprocessor test (Bug#15001).
810
a5b5f73f
LMI
8112013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
812
813 * image.c (imagemagick_compute_animated_image): Respect the GIF
814 disposal methods.
815
0fe73012
KB
8162013-08-15 Ken Brown <kbrown@cornell.edu>
817
818 * emacs.c (main): Update comment about G_SLICE_ALWAYS_MALLOC.
819 * gmalloc.c (memalign) [CYGWIN]: Revert last change; it's not
820 needed.
821
691a357f
PE
8222013-08-15 Paul Eggert <eggert@cs.ucla.edu>
823
824 Fix minor problems found by static checking.
825 * frame.c (delete_frame):
826 * xdisp.c (next_element_from_display_vector):
827 Avoid uninitialized local.
828 * image.c (imagemagick_compute_animated_image): Port to C89.
829 Prefer usual GNU indentation style for loops.
830 Be more careful about bizarrely large sizes, by using ptrdiff_t
831 instead of int.
832
42fe2e88
DA
8332013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
834
835 Fix infinite frame selection loop (Bug#15025).
836 * frame.c (delete_frame): Prefer fast ad-hoc loop to next_frame.
837
d39a3da6
EZ
8382013-08-15 Eli Zaretskii <eliz@gnu.org>
839
068f9124
SM
840 * xdisp.c (compute_window_start_on_continuation_line):
841 When WORD_WRAP is in effect, use move_it_to instead of move_it_by_lines
d39a3da6
EZ
842 to make sure we end up setting the window start at the leftmost
843 visible character of the display line. This avoids funky
844 horizontal shifting because the window start is not kept on the
845 same position. (Bug#15090)
05426239
EZ
846 (next_element_from_display_vector): Support 'box' face attribute
847 in the face definitions of a display vector. (Bug#15099)
d39a3da6 848
6e856b69
LMI
8492013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
850
851 * image.c (imagemagick_compute_animated_image): Implement animated
852 images (bug#14700).
995be755
LMI
853 (imagemagick_compute_animated_image): Fix some compilation
854 warnings. Implement a very simple cache to make the animation
855 usable at all, but it should be replaced with a per-image cache.
6e856b69 856
d5a1acfa
DA
8572013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
858
859 * lisp.h (FOR_EACH_ALIST_VALUE): New macro
860 to do `for' loops over alist values.
861 * buffer.h (FOR_EACH_BUFFER):
862 * process.c (FOR_EACH_PROCESS): Use it.
863 (handle_child_signal, status_notify, Fget_buffer_process)
864 (kill_buffer_processes): Use FOR_EACH_PROCESS.
865
9c253307
DA
8662013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
867
868 * term.c (get_named_tty, create_tty_output, tty_free_frame_resources)
869 (tty_free_frame_resources, delete_tty): Prefer eassert to emacs_abort.
870 * image.c (make_image_cache): For struct image_cache, prefer xmalloc
871 to xzalloc and so avoid redundant call to memset.
872 * xterm.c (x_term_init): Avoid unnecessary initializations of dpyinfo
873 members because it is allocated with xzalloc and so already zeroed.
874
05e64f9f
KB
8752013-08-14 Ken Brown <kbrown@cornell.edu>
876
877 * gmalloc.c (memalign) [CYGWIN]: Rename to emacs_memalign
878 (Bug#15094).
879
5b71542d
DA
8802013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
881
882 Utility function and macro to copy Lisp string to C string.
883 * lisp.h (xlispstrdupa): New macro.
884 (xlispstrdup): New prototype.
885 * alloc.c (xlispstrdup): New function.
886 * callint.c (Fcall_interactively):
887 * fileio.c (Ffile_name_directory, Fexpand_file_name)
888 (Fsubstitute_in_file_name):
889 * frame.c (Fmake_terminal_frame): Use xlispstrdupa.
890 * image.c (x_create_bitmap_from_file):
891 * w32term.c (w32_term_init):
892 * xterm.c (x_term_init): Use xlispstrdup.
893
71530c97
LMI
8942013-08-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
895
4ce82fb8
LMI
896 * image.c (imagemagick_load_image): Make animated pictures work.
897 There's still some problems with background color settings, though
898 (bug#14700).
899
71530c97
LMI
900 * decompress.c (unwind_decompress): Always restore point.
901
7510a061
XF
9022013-08-14 Xue Fuqiao <xfq.free@gmail.com>
903
904 * marker.c (set_marker): Reformat documentation.
905
01c3051f
PE
9062013-08-14 Paul Eggert <eggert@cs.ucla.edu>
907
aab1fcdf
PE
908 * xdisp.c (cursor_type_changed): Now static.
909
01c3051f
PE
910 * image.c (imagemagick_filename_hint): New arg HINT_BUFFER.
911 Use changed. This avoids the need to call xmalloc and for the
912 caller to call xfree, and avoids memory leaks in some situations.
913
2084152a
DA
9142013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
915
916 * xdisp.c (adjust_window_ends): Move duplicated code to new function.
917 (try_window, try_window_reusing_current_matrix, try_window_id): Use it.
94a4e898
DA
918 (redisplay_window): If window_end_valid is cleared due to non-zero
919 windows_or_buffers_changed, clear current_matrix_up_to_date_p and
920 so do not call to try_cursor_movement for that window.
2084152a 921
02455cb6
DA
9222013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
923
924 * window.h (struct window): Convert window_end_pos and
925 window_end_vpos from Lisp_Object to ptrdiff_t and int, respectively.
926 (wset_window_end_pos, wset_window_end_vpos): Remove.
927 * dispnew.c (adjust_glyph_matrix):
928 * window.c (Fwindow_end, replace_window, set_window_buffer)
929 (make_window):
930 * xdisp.c (check_window_end, move_it_to, redisplay_internal)
931 (set_vertical_scroll_bar, redisplay_window, try_window)
932 (try_window_reusing_current_matrix, find_first_unchanged_at_end_row)
933 (try_window_id, decode_mode_spec, mouse_face_from_buffer_pos)
934 (note_mouse_highlight): Adjust users.
935 (try_cursor_movement): Likewise. Convert old precondition to eassert.
936 Add comment.
937
da5707e8
DA
9382013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
939
940 Fix --enable-gcc-warnings errors introduced in 2013-08-13 commit.
941 * image.c (imagemagick_filename_hint): Use `const char *' and
942 prefer SSDATA to SDATA to avoid warnings.
943
25554267
DA
9442013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
945
946 Cleanup window fringes, margins and scroll bars adjustments.
947 * window.c (set_window_fringes, set_window_margins)
948 (set_window_scroll_bars, apply_window_adjustment): New functions.
949 (set_window_buffer, Fset_window_margins, Fset_window_fringes)
950 (Fset_window_scroll_bars): Use them.
951
38a2c910
DA
9522013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
953
954 * window.h (struct window): Convert scroll_bar_width
955 from Lisp_Object to integer. Adjust comment.
956 (WINDOW_CONFIG_SCROLL_BAR_WIDTH, WINDOW_CONFIG_SCROLL_BAR_COLS):
957 Adjust users.
958 * window.c (wset_scroll_bar_width): Remove.
959 (make_window): Initialize scroll_bar_width.
960 (Fsplit_window_internal): Use direct assignment.
961 (Fset_window_configuration, save_window_save):
962 Convert Lisp_Object to integer and back where appropriate.
963 (Fset_window_scroll_bars): Adjust user. Return t if any scroll
964 bar was actually changed, and mention this in docstring.
965
2d065031
PE
9662013-08-13 Paul Eggert <eggert@cs.ucla.edu>
967
968 * decompress.c: Minor simplifications.
969 (Fzlib_decompress_region): Don't bother verifying
970 that avail_out <= UINT_MAX, as that was confusing.
971 Mention the restriction in a comment instead.
972 Prefer 'int' to 'ptrdiff_t' when 'int' is wide enough.
973
a5bd5abb
JD
9742013-08-13 Jan Djärv <jan.h.d@swipnet.se>
975
976 * nsmenu.m (x_activate_menubar): Check for OSX >= 10.5
977 (trackingNotification:): Call ns_check_menu_open only for OSX >= 10.5.
978
66e7901a
LMI
9792013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
980
981 * image.c (imagemagick_filename_hint): Check for errors in the
982 alist structure.
983
2fa611b7
EZ
9842013-08-13 Eli Zaretskii <eliz@gnu.org>
985
986 * window.c (Fwindow_margins): Return nil when there's no marginal
987 area, as per the documented API.
988
989 * w32term.c (x_scroll_bar_create): Use ALLOCATE_PSEUDOVECTOR, not
990 Fmake_vector, as scroll bar's struct members are not all Lisp
991 objects now. This avoids crashes in GC.
992
993 * w32term.h (struct scroll_bar): Convert fringe_extended_p to a
994 bool, so its address could be taken.
995
8259030d
LMI
9962013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
997
998 * image.c (imagemagick_filename_hint): New function to possibly
999 apply `image-content-type-suffixes'.
1000 (imagemagick_load_image): Use it.
1001
866c710e
EZ
10022013-08-13 Eli Zaretskii <eliz@gnu.org>
1003
1004 * decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil
1005 if loading zlib failed.
1006
f10490f0
JD
10072013-08-13 Jan Djärv <jan.h.d@swipnet.se>
1008
96311be7
JD
1009 * nsterm.m (ns_set_vertical_scroll_bar): Fix breakage intruduced by
1010 2013-08-13 checkin below. Change bool to BOOL, rule is:
1011 All Obj-C code uses BOOL, except for interfaces callable from C.
1012
f10490f0
JD
1013 * nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).
1014
c8ae93b0
DA
10152013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1016
1017 * window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
1018 * nsterm.m (ns_set_vertical_scroll_bar): Use it. Use convenient
1019 bool instead of BOOL.
1020 * w32term.h (struct scroll_bar): Convert fringe_extended_p
1021 from Lisp_Object to bitfield. Adjust comment.
1022 * w32term.c (x_scroll_bar_create): Adjust user.
1023 Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
1024 * xterm.c (XTset_vertical_scroll_bar): Likewise.
1025 Use bool for boolean.
1026 * xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
1027 to `unsigned int' when defining a bitfield.
1028
53b64418
PE
10292013-08-13 Paul Eggert <eggert@cs.ucla.edu>
1030
1031 * decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
1032
eeaf9bf3
DA
10332013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1034
1035 * window.h (struct window): Convert left_margin_cols and
1036 right_margin_cols from Lisp_Objects to integers. Adjust comment.
1037 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
1038 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
1039 Adjust users.
1040 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
1041 Adjust comment.
1042 (showing_window_margins_p, update_window_line, update_frame_1):
1043 * fringe.c (draw_fringe_bitmap_1):
1044 * xdisp.c (window_box_width): Adjust users.
1045 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
1046 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
1047 Use direct assignment.
1048 (Fset_window_configuration, save_window_save, Fwindow_margins):
1049 Convert Lisp_Object to integer and back where appropriate.
1050 (Fset_window_margins): Adjust user. Return t if any margin
1051 was actually changed, and mention this in docstring.
1052
956720af
XF
10532013-08-13 Xue Fuqiao <xfq.free@gmail.com>
1054
f73f4ce6 1055 * syntax.c (forward_word):
956720af
XF
1056 * cmds.c (forward_char, backward_char): Mention the optional argument.
1057
9e37ee3b
DA
10582013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1059
1060 * window.h (struct window): Convert left_fringe_width
1061 and right_fringe_width from Lisp_Objects to integers.
1062 Adjust comment.
1063 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
1064 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
1065 * window.c (wset_left_fringe_width, wset_right_fringe_width):
1066 Remove.
1067 (make_window): Initialize new integer fields to -1.
1068 (Fsplit_window_internal): Use direct assignment.
068f9124
SM
1069 (Fset_window_configuration, save_window_save):
1070 Convert Lisp_Object to integer and back where appropriate.
9e37ee3b
DA
1071 (Fset_window_fringes): Adjust user. Return t if any fringe
1072 was actually changed, and mention this in docstring.
1073
e4375ca7
DA
10742013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1075
1076 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
9cda66e4
DA
1077 * nsfns.m (x_set_cursor_type):
1078 * w32fns.c (x_set_cursor_type):
1079 * xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
1080 * xdisp.c (set_frame_cursor_types): ...but in common code.
e4375ca7 1081
a45543bc
DA
10822013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1083
1084 * font.c (clear_font_cache): New function, stripped from...
1085 (Fclear_font_cache): ...here, which now uses the function
1086 above. Adjust comment.
1087 * font.h (clear_font_cache): Add prototype.
1088 * xfaces.c (clear_face_cache): Use clear_font_cache.
1089
ae966a86
DA
10902013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1091
1092 * window.c (Fset_window_start): Compare `w', not `window' because
1093 `w' might not be equal to `window' after call to decode_live_window.
1094
297a545b
PE
10952013-08-12 Paul Eggert <eggert@cs.ucla.edu>
1096
1097 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
1098 This fixes a problem introduced by the Bug#15035 patch
1099 when using GPG. Reported by Herbert J. Skuhra.
1100
aa942e2b
EZ
11012013-08-12 Eli Zaretskii <eliz@gnu.org>
1102
1103 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
1104 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
1105 not yet initialized.
1106
7699d09e
LMI
11072013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1108
1109 * decompress.c (Fzlib_decompress_region): Support zlib
1110 decompression, too, and rename.
1111
1d238bc7
PE
11122013-08-12 Paul Eggert <eggert@cs.ucla.edu>
1113
1114 Minor zlib configuration tweaks.
1115 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
1116 Don't assume presence of fn_inflateInit2_ zlib internal function.
1117
8a44a184
LMI
11182013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1119
1120 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
1121 include the zlib prefix.
1122
594a4307
EZ
11232013-08-12 Eli Zaretskii <eliz@gnu.org>
1124
1125 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
1126 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
1127 define static variables that are pointers to zlib functions to be
1128 dynamically loaded.
1129 (init_zlib_functions) [WINDOWSNT]: New function.
1130 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
1131 New macros.
1132 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
1133 macros instead of invoking the zlib functions directly.
068f9124
SM
1134 (syms_of_decompress): DEFSYM Qzlib_dll.
1135 Staticpro Szlib_available_p.
594a4307 1136
d2e113bc
DA
11372013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
1138
1139 Avoid looping over all frame windows to freeze and unfreeze.
1140 * window.h (struct window): Drop frozen_window_start_p.
1141 (freeze_window_starts): Drop prototype.
1142 * frame.h (struct frame): New frozen_window_starts flag.
1143 (FRAME_WINDOWS_FROZEN): New macro.
1144 * window.c (freeze_window_start, freeze_window_starts):
1145 Remove.
1146 (select_window, replace_window): Adjust users.
1147 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
1148 (window_frozen_p): New function.
1149 (redisplay_window): Use it.
1150
94fcd171
PE
11512013-08-12 Paul Eggert <eggert@cs.ucla.edu>
1152
1153 Fix some fd issues when running subprocesses (Bug#15035).
1154 Fix bugs that can leak files or file descriptors on errors.
1155 Don't unlink open temp files, as that's hard for users to diagnose
1156 when things go awry (e.g., temp disk exhausted).
1157 Don't bother to lock temp files. Check for invalid recursion.
1158 * callproc.c (synch_process_fd): Remove. All uses removed.
1159 (synch_process_tempfile): New var or macro.
1160 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
1161 New constants.
1162 (record_kill_process): New arg, the temp name. All callers changed.
1163 (delete_temp_file): Now just a simple wrapper around unlink.
1164 (call_process_kill): New arg, the call_process_fd array.
1165 Close them all. Clear synch_process_pid. Remove the temp file,
1166 or arrange for it to be removed.
1167 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
1168 that's been moved to synch_process_tempfile. Caller changed.
1169 Do not remove the tempfile; that's now call_process_kill's
1170 responsibility.
1171 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
1172 call_process_kill; the caller now does that.
1173 (call_process_cleanup): Do not close the process fd; that's now
1174 call_process_kill's responsibility.
1175 (Fcall_process): Implement via new function call_process, which
1176 has most of the old body of Fcall_process, but with a different API.
1177 (call_process): New function that does not open or close filefd if
1178 it is nonnegative. Record which fds need to be closed, and let
1179 call_process_kill close (and remove the tempfile, on MSDOS) on error.
1180 Signal an error if invoked recursively (could be done via a hook).
1181 Simplify creation of the tempfile in the MSDOS case.
1182 Don't create the output file until after checking for the executable.
1183 Report any failure to open /dev/null.
1184 Don't open /dev/null for writing twice; once is enough.
1185 Don't create pipe if all output is being discarded or sent to file.
1186 Don't worry about setting up the coding system or reading from the
1187 pipe if all output is being discarded.
1188 Hoist fd_error local into top level, to lessen block nesting.
1189 Don't record deleted pid here; now done by Fcall_process_region.
1190 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
1191 and note its success in synch_process_tempfile.
1192 Do not leak resources when child_setup fails.
1193 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
1194 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
1195 (create_temp_file): Now returns open fd, with an additional
1196 Lisp_Object * argument to return the name. All callers changed.
1197 Do not close the file; rewind it instead, and leave it open for
1198 the caller. Do not lock the temp file. Unwind-protect the file
1199 and the file-descriptor.
1200 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
1201 If an asynchrounous process, record it here, not in call_process.
1202 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
1203 * eval.c (set_unwind_protect): New function.
1204 * fileio.c (write_region): New function, generalized from the
1205 old Fwrite_region. Do not lock temp files.
1206 (Fwrite_region): Use it.
1207 * lisp.h (set_unwind_protect, write_region): New decls.
1208 * process.c: Include <verify.h>.
1209 (make_process): Mark fds as initially closed.
1210 (deleted_pid_list): Now a list of pid-filename pairs.
1211 All uses changed.
1212 (close_process_fd): New function.
1213 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
1214 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
1215 New constants. Verify that their number matches PROCESS_OPEN_FDS.
1216 (create_process, create_pty, Fmake_serial_process)
1217 (server_accept_connection): Record which fds need to be closed,
1218 and let deactivate_process close them.
1219 (Fmake_network_process): Do not discard the unwind-protect
1220 until it's safe to do so.
1221 (deactivate_process): Close the fds opened by create_process etc.
1222 (Fprocess_send_eof): Adjust to new way of recording open fds.
1223 Report an error if /dev/null can't be opened, instead of aborting.
1224 * process.h (PROCESS_OPEN_FDS): New constant.
1225 (struct Lisp_Process): New member open_fds.
1226 (record_kill_process, record_deleted_pid): Adjust signatures.
1227 (record_deleted_pid): Move decl here ...
1228 * syswait.h (record_deleted_pid): ... from here.
1229
d0e615c3
PE
12302013-08-11 Paul Eggert <eggert@cs.ucla.edu>
1231
1232 * decompress.c: Fix bugs with large buffers and weird inputs.
1233 Tune a bit. Reindent as per usual Emacs style.
1234 (BUFFER_SIZE): Remove.
1235 (Fdecompress_gzipped_region): Do not mishandle input buffers with
1236 more than UINT_MAX bytes. Decompress into the gap instead of into
1237 an auto buffer, as this should avoid copying. Return nil if
1238 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
1239 set immediate_quit; we shouldn't trust zlib code that much.
1240
313546eb
LMI
12412013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1242
99a32242
LMI
1243 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
1244 errors, and really move the gap to where we want it.
1245
313546eb
LMI
1246 * lisp.h: Include decompress.c support.
1247
1248 * emacs.c (main): Include decompress.c support.
1249
1250 * Makefile.in: Include -lz if present.
1251
d2d699ac
JD
12522013-08-11 Jan Djärv <jan.h.d@swipnet.se>
1253
f90e3ebd
JD
1254 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
1255 (initWithTitle:): Initialize frame to 0.
1256 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
068f9124 1257 (fillWithWidgetValue:frame:): Rename from
f90e3ebd
JD
1258 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
1259
1260 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
1261 fillWithWidgetValue:frame:
1262
423d3b3f
JD
1263 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
1264 remove memory leak warnings.
1265
d2d699ac
JD
1266 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
1267 (ns_check_menu_open): Handle menu == nil. Remove assignment to
1268 menu_pending_title.
1269
1270 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
1271 (x_activate_menubar): Update the whole menu.
1272 (trackingNotification:): Call ns_check_menu_open if tracking ends.
1273 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
1274 current event is not NSSystemDefined (Bug#15001).
1275 Call ns_check_menu_open only if trackingMenu is 2.
1276 (menuDidClose:): New method, decrease trackingMenu.
1277 (fillWithWidgetValue:setDelegate:): New method.
1278 (fillWithWidgetValue:): Call the above.
1279
1280 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
1281
7d652d97
PE
12822013-08-11 Paul Eggert <eggert@cs.ucla.edu>
1283
1284 Omit some unnecessary casts.
1285 Many of these go back to the old pre-C89 days, when they may have
1286 been needed, but we've been assuming C89 or later for a while now.
1287 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
1288 (live_float_p, live_misc_p, live_vector_p):
1289 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
1290 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
1291 (defvar_per_buffer):
1292 * callint.c (Fcall_interactively):
1293 * doc.c (Fsubstitute_command_keys):
1294 * filelock.c (get_boot_time):
1295 * frame.c (xrdb_get_resource):
1296 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
1297 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
1298 (xg_get_file_name_from_selector, menuitem_destroy_callback)
1299 (menuitem_highlight_callback, menu_destroy_callback)
1300 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
1301 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
1302 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
1303 (xg_tool_bar_help_callback, tb_size_cb):
1304 * image.c (xpm_alloc_color, png_read_from_memory)
1305 (png_read_from_file, png_load_body, our_memory_skip_input_data)
1306 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
1307 (syms_of_image):
1308 * keymap.c (describe_map):
1309 * nsfns.m (Fns_display_monitor_attributes_list):
1310 * nsmenu.m (process_dialog:):
1311 * nsterm.m (hold_event):
1312 * process.c (wait_reading_process_output):
1313 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
1314 * scroll.c (do_direct_scrolling, scrolling_1):
1315 * termcap.c (tgetent):
1316 * window.c (check_window_containing, add_window_to_list)
1317 (freeze_window_starts):
1318 * xdisp.c (compare_overlay_entries, vmessage):
1319 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
1320 (x_get_monitor_attributes_xrandr)
1321 (Fx_display_monitor_attributes_list, x_display_info_for_name)
1322 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
1323 * xfont.c (xfont_match, xfont_open):
1324 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
1325 (menubar_selection_callback, menu_position_func)
1326 (popup_selection_callback, create_and_show_popup_menu)
1327 (dialog_selection_callback, create_and_show_dialog):
1328 * xrdb.c (x_get_string_resource):
1329 (main) [TESTRM]:
1330 * xsmfns.c (x_session_check_input):
1331 * xterm.c (x_draw_glyphless_glyph_string_foreground)
1332 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
1333 (xaw_jump_callback, xaw_scroll_callback):
1334 Omit unnecessary casts.
1335
9acc1074
PE
13362013-08-10 Paul Eggert <eggert@cs.ucla.edu>
1337
1338 Minor string-length refactoring.
1339 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
1340 * frame.c (make_monitor_attribute_list):
1341 Prefer build_string to strlen + make_string.
1342
361c0eb8
JD
13432013-08-10 Jan Djärv <jan.h.d@swipnet.se>
1344
1345 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
1346 don't check minor_code (Bug#14417).
1347
14ba0822
EZ
13482013-08-09 Eli Zaretskii <eliz@gnu.org>
1349
1350 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
1351 vertical positions instead. This avoids calling MATRIX_ROW with
1352 row numbers that are possibly beyond valid limits. (Bug#15064)
1353
309f24d1
DA
13542013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
1355
1356 Use xstrdup and build_unibyte_string where applicable.
1357 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
1358 * xfns.c (x_window):
1359 * xrdb.c (x_get_customization_string):
1360 * xterm.c (xim_initialize):
1361 * w32fns.c (w32_window): Use xstrdup.
1362 (w32_display_monitor_attributes_list):
1363 * emacs.c (init_cmdargs):
1364 * keyboard.c (PUSH_C_STR):
1365 * nsfont.m (nsfont_open):
1366 * sysdep.c (system_process_attributes):
1367 * w32.c (system_process_attributes):
1368 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
1369
55902276
EZ
13702013-08-09 Eli Zaretskii <eliz@gnu.org>
1371
1372 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
1373 variables of these types so that GDB would know about them, as aid
1374 for debugging fatal exceptions. (Bug#15024) See also
1375 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
1376 discussions.
1377
10bf7f5a
JD
13782013-08-08 Jan Djärv <jan.h.d@swipnet.se>
1379
1380 * nsterm.m (ns_update_begin): Don't change clip path if it would be
1381 larger than the NSWindow (Bug#14934).
1382
65620264
DA
13832013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1384
1385 Redesign redisplay interface to drop global variable updated_window.
1386 Always pass currently updated window as a parameter to update routines.
1387 * dispextern.h (updated_window): Remove declaration.
1388 (struct redisplay_interface): Pass window parameter to
1389 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
1390 and after_update_window_hook.
1391 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
1392 Adjust prototypes.
1393 * dispnew.c (updated_window): Remove.
1394 (redraw_overlapped_rows, update_marginal_area, update_text_area)
1395 (update_window_line): Adjust to match redisplay interface changes.
1396 * nsterm.m (ns_update_window_begin, ns_update_window_end)
1397 (ns_scroll_run, ns_after_update_window_line):
1398 * w32term.c (x_update_window_begin, x_update_window_end)
1399 (x_after_update_window_line, x_scroll_run):
1400 * xterm.c (x_update_window_begin, x_update_window_end)
1401 (x_after_update_window_line, x_scroll_run):
1402 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1403 Likewise. Adjust comments where appropriate.
1404 (x_cursor_to): Simplify because this is always called during window
1405 update (but install debugging check anyway).
1406 (expose_window): Check must_be_updated_p flag to see whether this
1407 function is called during window update.
1408
628fdc56
DA
14092013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1410
1411 Do not reset window modification event counters excessively.
1412 These leftovers and poor man's tricky methods to catch extra
1413 redisplay's attention are no longer needed.
1414 * frame.c (set_menu_bar_lines_1):
1415 * minibuf.c (read_minibuf_unwind):
1416 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
1417 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
1418 (window_scroll_line_based, Fset_window_configuration):
1419 * xdisp.c (redisplay_window): Do not reset last_modified and
1420 last_overlay_modified counters.
1421
8fd9c92e
JD
14222013-08-07 Jan Djärv <jan.h.d@swipnet.se>
1423
1424 * xselect.c (x_send_client_event): Set send_event and serial, memset
1425 data.l as it might be bigger than data.b. Use 24 bit mask to
1426 XSendEvent (Bug#15034).
1427
0ee18172
EZ
14282013-08-07 Eli Zaretskii <eliz@gnu.org>
1429
1430 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
1431 for TTY frames that are not the top frame on their console.
1432 (Bug#14616)
1433
16ddd1a6
MR
14342013-08-07 Martin Rudalics <rudalics@gmx.at>
1435
1436 * w32term.c (w32fullscreen_hook): Really maximize frame when
1437 asked for (Bug#14841).
1438
d2a95ffb
DA
14392013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1440
1441 Prefer selected_window to Fselected_window, likewise for frames.
1442 * buffer.c (Fbuffer_swap_text):
1443 * data.c (Fvariable_binding_locus):
1444 * window.c (run_window_configuration_change_hook): Adjust users.
1445 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
1446 Use decode_live_frame.
1447
170da1ec
DA
14482013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1449
1450 Be more careful if selected window shows the buffer other than current,
1451 use window_outdated only if this is not so. This change should also
1452 address some weird issues discussed in Bug#13012.
1453 * window.h (window_outdated): New prototype.
1454 * window.c (window_outdated): Now here. Convert from static and
1455 always assume window's buffer.
1456 (Fwindow_end, Fwindow_line_height): Use it.
1457 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
1458 and always assume window's buffer.
1459 (redisplay_window): Adjust user.
e5eefe9b 1460 (redisplay_internal): Call to reconsider_clip_changes once and
170da1ec
DA
1461 check whether mode line should be updated only if selected window
1462 shows current buffer.
1463 (run_window_scroll_functions): Use eassert for debugging check.
1464 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
1465
56b5d5b1
DA
14662013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1467
1468 * window.c (window_scroll, window_scroll_pixel_based)
1469 (window_scroll_line_based): Use bool for booleans.
1470
2878ba7e
PE
14712013-08-06 Paul Eggert <eggert@cs.ucla.edu>
1472
1473 * process.c: Fix minor off-by-one issues in descriptor counts.
1474 This shouldn't fix any real bugs, but it cleans up the code a bit.
1475 (max_process_desc, max_input_desc): -1, not 0, means none.
1476 All uses changed.
1477 (delete_input_desc): New function.
1478 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
1479 (deactivate_process): Scan backwards when recomuting max_process_desc;
1480 that should be faster.
1481 (init_process_emacs): Initialize max_input_desc.
1482
e30b79c1
DA
14832013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1484
1485 Use region cache to speedup bidi_find_paragraph_start.
1486 * buffer.h (struct buffer): New member bidi_paragraph_cache.
1487 Rename cache_long_line_scans to cache_long_scans.
1488 * buffer.c (bset_cache_long_line_scans): Rename to
1489 bset_cache_long_scans.
1490 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
1491 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
1492 into account.
1493 (syms_of_buffer): Rename cache-long-line-scans to
1494 cache-long-scans. Adjust docstring.
1495 * search.c (newline_cache_on_off):
1496 * indent.c (width_run_cache_on_off): Adjust users.
1497 * bidi.c (bidi_paragraph_cache_on_off): New function.
1498 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
068f9124
SM
1499 * insdel.c (prepare_to_modify_buffer):
1500 Invalidate bidi_paragraph_cache if enabled.
e30b79c1 1501
00012b86
DA
15022013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1503
1504 Invalidate region caches only if buffer text is going to be changed.
1505 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
1506 (modify_text): ...new prototype.
1507 (prepare_to_modify_buffer_1): New prototype.
1508 * textprop.c (modify_region): Rename to...
1509 (modify_text_properties): ...new function.
1510 (add_text_properties_1, set_text_properties, Fremove_text_properties)
1511 (Fremove_list_of_text_properties): Adjust users.
1512 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
1513 (modify_text): ...new function.
1514 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
1515 (prepare_to_modify_buffer_1): ...new function.
1516 * casefiddle.c (casify_region):
1517 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
1518 (Ftranspose_regions): Use modify_text.
1519
dc6c0eda
SM
15202013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
1521
1522 * lisp.mk (lisp): Add nadvice.elc.
1523
8f3a2c26
DA
15242013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
1525
1526 New macro to iterate over live buffers similar to frames.
1527 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
1528 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
1529 Declare buffer-related variables here to offload lisp.h.
1530 * buffer.c (Vbuffer_alist): Adjust comment.
1531 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
1532 (other_buffer_safely):
1533 * data.c (store_symval_forwarding):
1534 * dispnew.c (Fframe_or_buffer_changed_p):
1535 * fileio.c (Fdo_auto_save):
1536 * filelock.c (unlock_all_files):
1537 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
1538
e0fdb694
PE
15392013-08-04 Paul Eggert <eggert@cs.ucla.edu>
1540
1541 Fix some minor races in hosts lacking mkostemp (Bug#15015).
1542 * callproc.c (create_temp_file):
1543 * filelock.c (create_lock_file):
1544 Assume mkostemp, since it's now provided by Gnulib.
1545
63f5c6c2
EZ
15462013-08-04 Eli Zaretskii <eliz@gnu.org>
1547
1548 * w32.c (mkostemp): New function.
1549 (mktemp): Remove, no longer used. Most of the code reused in
1550 mkostemp. (Bug#15015)
484ab239 1551 (mktemp): Don't undef.
63f5c6c2 1552
f0b79313
DA
15532013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
1554
1555 * dispnew.c (glyph_matrix_count, glyph_pool_count):
1556 Move under GLYPH_DEBUG and ENABLE_CHECKING.
1557 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
1558 (free_glyph_pool, check_glyph_memory): Likewise for
1559 all users. Adjust comments where appropriate.
1560
98f638d6
PE
15612013-08-03 Paul Eggert <eggert@cs.ucla.edu>
1562
1563 * composite.h: Minor fixups.
1564 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
1565 to fix a misspelling, and change it to an inline function while
1566 we're at it (it need not be a macro). All uses changed.
1567 (composition_method, composition_valid_p):
1568 Rewrite to avoid assignments in if-conditions.
1569
75c59fb3
DA
15702013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
1571
1572 Do not use global Lisp_Object in composition macros.
1573 * composite.h (composition_temp): Remove declaration.
1574 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
1575 (composition_method, composition_valid_p): ...inline functions.
416a3e01 1576 (compose_region): Remove the leftover.
75c59fb3
DA
1577 * composite.c (composition_temp): Remove.
1578 (run_composition_function, update_compositions)
1579 (composition_compute_stop_pos, composition_adjust_point)
1580 (Ffind_composition_internal):
1581 * coding.c (handle_composition_annotation):
1582 * xdisp.c (handle_composition_prop, check_point_in_composition):
1583 Related users changed.
1584
a10c8269
DA
15852013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
1586
1587 Drop FRAME_PTR typedef.
1588 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
1589 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
1590 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
1591 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
1592 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
1593 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
1594 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
1595 All related users changed.
1596
a104f656
SM
15972013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1598
1599 * eval.c (default_toplevel_binding): New function.
1600 (Fdefvar): Use it.
1601 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
1602 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
1603 (syms_of_eval): Export them.
1604 * data.c (Fdefault_value): Micro cleanup.
1605 * term.c (init_tty): Use "false".
1606
4b5c9326
DA
16072013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1608
1609 Fix X GC leak in GTK and raw (no toolkit) X ports.
1610 * xterm.c (x_free_frame_resources): If white and black relief
1611 GCs are allocated, always free them here.
1612 * xfns.c (x_make_gc): Omit redundant initialization.
1613 * widget.c (create_frame_gcs): Remove the leftover.
1614 (EmacsFrameDestroy): Do nothing because all GCs are now freed
1615 in x_free_frame_resources.
1616
b19aa636
JD
16172013-08-02 Jan Djärv <jan.h.d@swipnet.se>
1618
1619 * nsterm.m (windowWillResize:toSize:): Only change title if
1620 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
1621 modifying it.
1622 (viewDidEndLiveResize): New method.
1623
1624 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
1625 inside NS_IMPL_COCOA.
1626
af1f7e06
DA
16272013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1628
1629 * insdel.c (adjust_after_replace, replace_range, del_range_2):
1630 Do not check whether undo is enabled because record_insert and
1631 record_delete does that themselves.
1632
65b02bb9
DA
16332013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1634
1635 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
1636 member which is not really used any more.
1637 (FRAME_XIC_BASE_FONTNAME): Remove.
1638 * xfns.c (xic_free_fontset): Adjust user.
1639 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
1640 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
1641 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
1642 (xdialog_show): Use eassert for debugging check.
7ee0f047 1643 * w32term.c (x_unfocus_frame): Remove unused dummy function.
65b02bb9 1644
6318cde0
PE
16452013-08-01 Paul Eggert <eggert@cs.ucla.edu>
1646
1647 * fileio.c, fns.c (merge): Move extern decl from here ...
1648 * lisp.h (merge): ... to here.
1649
6c1a09ba
DA
16502013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1651
1652 Fix last font-related change.
1653 * w32font.h (w32font_list_internal, w32font_match_internal):
1654 Fix prototype.
1655 * w32uniscribe.c (uniscribe_list, uniscribe_match):
1656 (uniscribe_list_family): Adjust to match font API change.
1657 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
1658 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
1659
f8c20208
DA
16602013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1661
1662 * frame.h (FRAME_MOUSE_UPDATE):
1663 * nsterm.m (ns_frame_up_to_date): Omit redundant check
1664 whether hlinfo->mouse_face_mouse_frame is non-NULL.
1665
fdb396e2
DA
16662013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1667
1668 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
1669 * font.h (struct font_driver): Change list, match, and list_family
1670 functions to accept struct frame * as first arg.
068f9124
SM
1671 * font.c (font_score, font_compare, font_sort_entities):
1672 Remove prototypes.
fdb396e2
DA
1673 (font_sort_entities, font_list_entities, font_select_entity):
1674 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
1675 match font API change.
1676 * xfont.c (xfont_list, xfont_match, xfont_list_family):
1677 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
1678 * ftxfont.c (ftxfont_list, ftxfont_match):
1679 * xftfont.c (xftfont_list, xftfont_match):
1680 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
1681 * w32font.c (w32font_list, w32font_match, w32font_list):
1682 (w32font_list_internal, w32_font_match_internal): Likewise.
1683 * xfaces.c (Fx_family_fonts): Adjust user.
1684
52b8a085
DA
16852013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1686
1687 Do not use pure Xism x_wm_set_icon_position in non-X ports.
1688 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
1689 only if HAVE_X_WINDOWS is in use.
1690 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
1691 * nsterm.m (x_wm_set_icon_position): Remove no-op.
1692 * w32term.c (x_wm_set_icon_position): Likewise.
1693 * w32fns.c (x_icon): Adjust user.
1694
c791c18e
DA
16952013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1696
1697 * xterm.c (last_mouse_press_frame): Remove the
1698 leftover which is not really used any more.
1699 (handle_one_xevent, syms_of_xterm): Adjust users.
1ca6cc28
DA
1700 (x_flush): Call XFlush once per each X display, not frame.
1701 This is better because this code always unconditionally skips
1702 non-X frames in Vframe_list and issues the only XFlush if we
1703 have more than one X frame on the same X display.
2f935d86
DA
1704 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
1705 Use bool for booleans.
1706 (x_draw_glyph_string_background, cvt_string_to_pixel):
1707 (cvt_pixel_dtor): Drop unnecessary prototypes.
1708 * xterm.h (x_display_ok): Adjust prototype.
c791c18e 1709
f435830e
DA
17102013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1711
1712 Drop unnecessary functions that deals with frame pixel size.
1713 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
1714 (x_pixel_height): Drop prototypes.
1715 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
1716 (x_pixel_height): Drop implementations.
1717 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
1718 which should be always valid for window frame.
1719 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
1720 * w32menu.c (Fx_popup_dialog):
1721 * xmenu.c (Fx_popup_dialog): Likewise for both.
1722
84231434
DA
17232013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1724
1725 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
1726 frame parameters and call to Fmodify_frame_parameters just once.
4c131798
DA
1727 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
1728 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
1729 and mention nil frame in docstring.
84231434 1730
959067a1
DA
17312013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1732
1733 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
1734 (x_figure_window_size): Likewise. Adjust to return long.
1735 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
1736 (toplevel): Move Qterminal_live_p to...
1737 * terminal.c (toplevel): ...here, make it static, and...
1738 (syms_of_terminal): ...DEFSYM here.
1739 * frame.h (Qterminal_live_p): Remove declaration.
1740 (make_frame, x_figure_window_size): Adjust prototype.
1741 * nsfns.m (Fx_create_frame): Use long for window flags.
1742
f4b169ce
PE
17432013-07-30 Paul Eggert <eggert@cs.ucla.edu>
1744
1745 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
1746 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
1747 Do not assume that emacs_close (INT_MAX) is a no-op.
1748
bee6a2c7
DA
17492013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1750
1751 * xfaces.c (make_face_cache): For struct face_cache, prefer
1752 xmalloc to xzalloc and so avoid redundant call to memset.
1753 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
1754
d7e6881a
DA
17552013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1756
1757 * fringe.c (draw_window_fringes, update_window_fringes)
1758 (compute_fringe_widths):
1759 * w32term.c (x_draw_glyph_string):
1760 * window.c (candidate_window_p, Frecenter):
1761 * xfaces.c (realize_basic_faces, realize_default_face)
1762 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
1763 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
1764 * xfns.c (x_set_cursor_color, xic_free_xfontset):
1765 * xmenu.c (Fx_menu_bar_open_internal):
1766 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
1767 * xsettings.c (xft_settings_event):
1768 * xterm.c (x_draw_glyph_string, x_had_errors_p):
1769 Use bool for booleans. Adjust style and comments where
1770 appropriate.
1771 * dispextern.h (draw_window_fringes, update_window_fringes)
1772 (compute_fringe_widths):
1773 * xterm.h (x_had_errors_p): Adjust prototype.
1774
ec3058af
DA
17752013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1776
1777 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
1778 CHECK_LIST. Rewrite the loop to avoid useless local variable.
1779
218e0637
DA
17802013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
1781
1782 * fns.c (toplevel): Remove comment before Fsafe_length because
1783 it checks for QUIT.
1784
e560aba9
PE
17852013-07-28 Paul Eggert <eggert@cs.ucla.edu>
1786
1787 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
1788
2e5ce5de
EZ
17892013-07-28 Eli Zaretskii <eliz@gnu.org>
1790
1791 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
1792 frame which got the message is still alive, before dereferencing
1793 its pointer. (Bug#14970)
1794
1795 * frame.c (delete_frame): Test "this" frame's minibuffer window to
1796 be a live window, before using it as such. (Bug#14970)
1797
e95da6d3
EZ
17982013-07-27 Eli Zaretskii <eliz@gnu.org>
1799
1800 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
1801 w32_detect_focus_change instead of doing part of its job by hand.
1802 This fixes the problem whereby FOCUS_OUT events were not sent to
1803 the event queue.
1804
a8f93651
EZ
18052013-07-26 Eli Zaretskii <eliz@gnu.org>
1806
fec92060
EZ
1807 * process.c (Fprocess_list): Doc fix.
1808
a8f93651
EZ
1809 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
1810 being re-exposed only if it didn't ask to become visible.
1811 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
1812 was previously iconified. (Bug#14841)
1813 (x_iconify_frame): Mark the frame iconified.
1814
d5a7a9d9
PE
18152013-07-26 Paul Eggert <eggert@cs.ucla.edu>
1816
1817 Fix minor problems found by static checking.
1818 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
1819 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
1820
56ea7291
SM
18212013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
1822
1823 * eval.c (set_specpdl_old_value): New function.
1824 (unbind_to): Minor simplification.
1825 (get_backtrace_frame): New function.
1826 (Fbacktrace_frame): Use it. Add `base' argument.
1827 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
1828 (syms_of_eval): Export backtrace-eval.
1829 * xterm.c (x_focus_changed): Simplify.
1830
9d611ffe
PE
18312013-07-25 Paul Eggert <eggert@cs.ucla.edu>
1832
1833 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
1834
999c74e3
EZ
18352013-07-24 Eli Zaretskii <eliz@gnu.org>
1836
1837 * xdisp.c (redisplay_window): Instead of moving point out of
1838 scroll margin, reject the force_start method, and try scrolling
1839 instead. (Bug#14780)
1840
198fa217
KB
18412013-07-24 Ken Brown <kbrown@cornell.edu>
1842
1843 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
1844 (Bug#14944).
1845
53840e55
PE
18462013-07-24 Paul Eggert <eggert@cs.ucla.edu>
1847
1848 * eval.c (Fprogn): Do not check that BODY is a proper list.
1849 This undoes the previous change. The check slows down the
1850 interpreter, and is not needed to prevent a crash. See
1851 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
1852
60967f56
GM
18532013-07-23 Glenn Morris <rgm@gnu.org>
1854
1855 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
1856
9ca960e2
PE
18572013-07-23 Paul Eggert <eggert@cs.ucla.edu>
1858
a29c3e6d
PE
1859 Port to GNU/Linux systems with tinfo but not ncurses.
1860 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
1861 to decide whether ncurses is being used. Without this change,
1862 GCC complains about tgetent not being declared, on a system
1863 that has tinfo installed but ncurses not installed.
1864
f274311c
PE
1865 * eval.c (Fprogn): Check that BODY is a proper list.
1866
16b0520a
PE
1867 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
1868 * data.c (Fsetq_default):
1869 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
1870 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
1871 (Fcondition_case):
1872 Tune by taking advantage of the fact that ARGS is always a list
1873 when a function is declared to have UNEVALLED args.
1874
9ca960e2
PE
1875 * emacsgtkfixed.c: Port to GCC 4.6.
1876 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
1877
afacaa1b
JB
18782013-07-23 Juanma Barranquero <lekktu@gmail.com>
1879
1880 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
1881 here to silence compiler warnings.
1882
368a85a4
PE
18832013-07-22 Paul Eggert <eggert@cs.ucla.edu>
1884
1885 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
1886 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
1887 from messing up Emacs's 'struct frame' (Bug#14923).
1888
f4e891b5
PE
18892013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1890
1891 * alloc.c (make_save_ptr_ptr): Define this function.
1892 It was inadvertently omitted. It's needed only if
1893 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
1894
96c8b65e
JD
18952013-07-21 Jan Djärv <jan.h.d@swipnet.se>
1896
1897 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
1898 frame have focus (Bug#14895).
1899
ee010797
PE
19002013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1901
1902 Avoid vfork-related deadlock more cleanly.
1903 * callproc.c (child_setup): When the child's exec fails, output
1904 the program name, as that's more useful. Use O_NONBLOCK to avoid
1905 deadlock.
1906 * process.c (create_process_1): Remove; no longer needed.
1907 (create_process): Remove timer hack; no longer needed, now that
1908 the child avoids deadlock.
1909
f0398ec1 19102013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
1911
1912 * image.c (Fimage_flush): Fix doc typo.
1913
b2a069c2
PE
19142013-07-20 Paul Eggert <eggert@cs.ucla.edu>
1915
6496aec9
PE
1916 Fix array bounds violation when pty allocation fails.
1917 * process.c (PTY_NAME_SIZE): New constant.
1918 (pty_name): Remove static variable; it's now auto.
1919 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
1920 Take pty_name as an arg rather than using a static variable.
1921 All callers changed.
1922 (create_process): Recover pty_flag from process, not from volatile local.
1923 (create_pty): Stay inside array even when pty allocation fails.
1924 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
1925
b2a069c2
PE
1926 * lread.c (Fload): Avoid initialization only when lint checking.
1927 Mention that it's needed only for older GCCs.
1928
99107004
KH
19292013-07-20 Kenichi Handa <handa@gnu.org>
1930
1931 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
1932 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
1933
6b1b199d
AS
19342013-07-20 Andreas Schwab <schwab@linux-m68k.org>
1935
1936 * lread.c (Fload): Avoid uninitialized warning.
1937
4195afc3
PE
19382013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1939
3f5bef16
PE
1940 Fix some minor file descriptor leaks and related glitches.
1941 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
1942 (create_lock_file): Use write, not emacs_write.
1943 * image.c (slurp_file, png_load_body):
1944 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
1945 (server_accept_connection):
1946 Don't leak an fd on memory allocation failure.
1947 * image.c (slurp_file): Add a cheap heuristic for growing files.
1948 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
1949 as that's what the other routines do. Maybe input need not be
1950 blocked at all, but it's better to be consistent.
1951 Avoid undefined behavior when strlen is zero.
1952
4195afc3
PE
1953 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
1954 (NSTATICS): Now a constant; doesn't need to be a macro.
1955
a1aeeffe
RS
19562013-07-19 Richard Stallman <rms@gnu.org>
1957
1958 * coding.c (decode_coding_utf_8): Add simple loop for fast
1959 processing of ASCII characters.
1960
63b34baa
PE
19612013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1962
1963 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
1964
621dd9ac
EZ
19652013-07-19 Eli Zaretskii <eliz@gnu.org>
1966
1967 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
1968 unportable 'struct x_display_info'.
1969 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
1970 is a portable type.
1971
1396ac86
PE
19722013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1973
ab9980cd
PE
1974 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
1975 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
1976 or fscanf fails.
1977 (system_process_attributes): Prefer plain char to unsigned char
1978 when either will do. Clean up properly if interrupted or if
068f9124
SM
1979 memory allocations fail. Don't assume sscanf succeeds.
1980 Remove no-longer-needed workaround to stop GCC from whining.
1981 Read command-line once, instead of multiple times. Check read status a
ab9980cd
PE
1982 bit more carefully.
1983
1396ac86
PE
1984 Fix obscure porting bug with varargs functions.
1985 The code assumed that int is treated like ptrdiff_t in a vararg
1986 function, which is not a portable assumption. There was a similar
1987 -- though these days less likely -- porting problem with various
1988 assumptions that pointers of different types all smell the same as
1989 far as vararg functions is conserved. To make this problem less
1990 likely in the future, redo the API to use varargs functions.
1991 * alloc.c (make_save_value): Remove this vararg function.
1992 All uses changed to ...
1993 (make_save_int_int_int, make_save_obj_obj_obj_obj)
1994 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
1995 New functions.
1996 (make_save_ptr): Rename from make_save_pointer, for consistency with
1997 the above. Define only on platforms that need it. All uses changed.
1998
4d19d194
PE
19992013-07-18 Paul Eggert <eggert@cs.ucla.edu>
2000
2001 * keyboard.c: Try to fix typos in previous change.
2002 (DISPLAY_LIST_INFO): New macro.
2003 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 2004 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 2005
945c5bb1
JB
20062013-07-18 Juanma Barranquero <lekktu@gmail.com>
2007
2008 * keyboard.c (kbd_buffer_get_event):
2009 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
2010 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
2011
f4b1eb36
PE
20122013-07-18 Paul Eggert <eggert@cs.ucla.edu>
2013
5e679a2c
PE
2014 * filelock.c: Fix unlikely file descriptor leaks.
2015 (get_boot_time_1): Rework to avoid using emacs_open.
2016 This doesn't actually fix a leak, but is better anyway.
2017 (read_lock_data): Use read, not emacs_read.
2018
a8cd4836
PE
2019 * doc.c: Fix minor memory and file descriptor leaks.
2020 * doc.c (get_doc_string): Fix memory leak when doc file absent.
2021 (get_doc_string, Fsnarf_documentation):
2022 Fix file descriptor leak on error.
2023
ef30e638
PE
2024 * term.c: Fix minor fdopen-related file descriptor leaks.
2025 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
2026 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
2027
f4b1eb36
PE
2028 * charset.c: Fix file descriptor leaks and errno issues.
2029 Include <errno.h>.
2030 (load_charset_map_from_file): Don't leak file descriptor on error.
2031 Use plain record_xmalloc since the allocation is larger than
2032 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
2033 of entries.
2034 * eval.c (record_unwind_protect_nothing):
2035 * fileio.c (fclose_unwind):
2036 New functions.
2037 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
2038 The replacement doesn't block input, but that no longer seems
2039 necessary.
2040
b648c163
PE
20412013-07-17 Paul Eggert <eggert@cs.ucla.edu>
2042
a0931322
PE
2043 * lread.c: Fix file descriptor leaks and errno issues.
2044 (Fload): Close some races that leaked fds or streams when 'load'
2045 was interrupted.
2046 (Fload, openp): Report error number of last nontrivial failure to open.
2047 ENOENT counts as trivial.
2048 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
2049 New functions.
2050 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
2051 now that the function is always called with a nonnegative arg.
2052 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
2053 All uses replaced with ...
2054 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
2055
b648c163
PE
2056 A few more minor file errno-reporting bugs.
2057 * callproc.c (Fcall_process):
2058 * doc.c (Fsnarf_documentation):
2059 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
2060 * process.c (set_socket_option):
2061 Don't let a constructor trash errno.
2062 * doc.c: Include <errno.h>.
2063
b1dc4084
JB
20642013-07-16 Juanma Barranquero <lekktu@gmail.com>
2065
2066 * w32fns.c (unwind_create_tip_frame): Fix declaration.
2067
c43843aa
PE
20682013-07-16 Paul Eggert <eggert@cs.ucla.edu>
2069
50a30cce
PE
2070 Fix w32 bug with call-process-region (Bug#14885).
2071 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
2072 to Fcall_process when the input is empty. This simplifies the
2073 code a bit. It makes no difference on POSIXish platforms but
2074 apparently it fixes a bug on w32.
2075
44e18199 2076 Fix bug where insert-file-contents closes a file twice (Bug#14839).
41d48a42
PE
2077 * fileio.c (close_file_unwind): Don't close if FD is negative;
2078 this can happen when unwinding a zapped file descriptor.
2079 (Finsert_file_contents): Unwind-protect the fd before the point marker,
2080 in case Emacs runs out of memory between the two unwind-protects.
2081 Don't trash errno when closing FD.
2082 Zap the FD in the specpdl when closing it, instead of deferring
2083 the removal of the unwind-protect; this fixes a bug where a child
2084 function unwinds the stack past us.
2085
27e498e6
PE
2086 New unwind-protect flavors to better type-check C callbacks.
2087 This also lessens the need to write wrappers for callbacks,
2088 and the need for make_save_pointer.
2089 * alloca.c (free_save_value):
2090 * atimer.c (run_all_atimers):
2091 Now extern.
2092 * alloc.c (safe_alloca_unwind):
2093 * atimer.c (unwind_stop_other_atimers):
2094 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
2095 * menu.c (cleanup_popup_menu) [HAVE_NS]:
2096 * minibuf.c (choose_minibuf_frame_1):
2097 * process.c (make_serial_process_unwind):
2098 * xdisp.h (pop_message_unwind):
2099 * xselect.c (queue_selection_requests_unwind):
2100 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
2101 * alloca.c (record_xmalloc):
2102 Prefer record_unwind_protect_ptr to record_unwind_protect with
2103 make_save_pointer.
2104 * alloca.c (Fgarbage_collect):
2105 Prefer record_unwind_protect_void to passing a dummy.
2106 * buffer.c (restore_buffer):
2107 * window.c (restore_window_configuration):
2108 * xfns.c, w32fns.c (do_unwind_create_frame)
2109 New wrapper. All record-unwind uses of wrappee changed.
2110 * buffer.c (set_buffer_if_live):
2111 * callproc.c (call_process_cleanup, delete_temp_file):
2112 * coding.c (code_conversion_restore):
2113 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
2114 * editfns.c (save_excursion_restore)
2115 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
2116 (save_restriction_restore):
2117 * eval.c (restore_stack_limits, un_autoload):
2118 * fns.c (require_unwind):
2119 * keyboard.c (recursive_edit_unwind, tracking_off):
2120 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
2121 * macros.c (pop_kbd_macro, restore_menu_items):
2122 * nsfns.m (unwind_create_frame):
2123 * print.c (print_unwind):
2124 * process.c (start_process_unwind):
2125 * search.c (unwind_set_match_data):
2126 * window.c (select_window_norecord, select_frame_norecord):
2127 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
2128 (fast_set_selected_frame):
2129 * xfns.c, w32fns.c (unwind_create_tip_frame):
2130 Return void, not a dummy Lisp_Object. All uses changed.
2131 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
2132 * callproc.c (call_process_kill):
2133 * fileio.c (restore_point_unwind, decide_coding_unwind)
2134 (build_annotations_unwind):
2135 * insdel.c (Fcombine_after_change_execute_1):
2136 * keyboard.c (read_char_help_form_unwind):
2137 * menu.c (unuse_menu_items):
2138 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
2139 * sound.c (sound_cleanup):
2140 * xdisp.c (unwind_redisplay):
2141 * xfns.c (clean_up_dialog):
2142 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
2143 Accept no args and return void, instead of accepting and returning
2144 a dummy Lisp_Object. All uses changed.
2145 * cygw32.c (fchdir_unwind):
2146 * fileio.c (close_file_unwind):
2147 * keyboard.c (restore_kboard_configuration):
2148 * lread.c (readevalllop_1):
2149 * process.c (wait_reading_process_output_unwind):
2150 Accept int and return void, rather than accepting an Emacs integer
2151 and returning a dummy object. In some cases this fixes an
2152 unlikely bug when the corresponding int is outside Emacs integer
2153 range. All uses changed.
2154 * dired.c (directory_files_internal_unwind):
2155 * fileio.c (do_auto_save_unwind):
2156 * gtkutil.c (pop_down_dialog):
2157 * insdel.c (reset_var_on_error):
2158 * lread.c (load_unwind):
2159 * xfns.c (clean_up_file_dialog):
2160 * xmenu.c, nsmenu.m (pop_down_menu):
2161 * xmenu.c (cleanup_widget_value_tree):
2162 * xselect.c (wait_for_property_change_unwind):
2163 Accept pointer and return void, rather than accepting an Emacs
2164 save value encapsulating the pointer and returning a dummy object.
2165 All uses changed.
2166 * editfns.c (Fformat): Update the saved pointer directly via
2167 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
2168 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
2169 (unwind_body): New function.
2170 (record_unwind_protect): First arg is now a function returning void,
2171 not a dummy Lisp_Object.
2172 (record_unwind_protect_ptr, record_unwind_protect_int)
2173 (record_unwind_protect_void): New functions.
2174 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
2175 * fileio.c (struct auto_save_unwind): New type.
2176 (do_auto_save_unwind): Use it.
2177 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
2178 * insdel.c (struct rvoe_arg): New type.
2179 (reset_var_on_error): Use it.
2180 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
2181 New constants.
2182 (specbinding_func): Remove; there are now several such functions.
2183 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
2184 (set_unwind_protect_ptr): New function.
2185 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
2186
4e604a5d
PE
2187 Be simpler and more consistent about reporting I/O errors.
2188 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
2189 Say "Read error" and "Write error", rather than "I/O error", or
2190 "IO error reading", or "IO error writing", when a read or write
2191 error occurs.
2192 * process.c (Fmake_network_process, wait_reading_process_output)
2193 (send_process, Fprocess_send_eof, wait_reading_process_output):
2194 Capitalize diagnostics consistently. Put "failed foo" at the
2195 start of the diagnostic, so that we don't capitalize the
2196 function name "foo". Consistently say "failed" for such
2197 diagnostics.
2198 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
2199 All callers changed. This is so it can use report_file_error.
2200 * sysdep.c (serial_open, serial_configure): Capitalize I/O
2201 diagnostics consistently as above.
2202
a9757f6a
PE
2203 * fileio.c (report_file_errno): Fix errno reporting bug.
2204 If the file name is neither null nor a pair, package it up as a
2205 singleton list. All callers changed, both to this function and to
2206 report_file_error. This fixes a bug where the memory allocator
2207 invoked by list1 set errno so that the immediately following
2208 report_file_error reported the wrong errno value.
2209
c43843aa
PE
2210 Fix minor problems found by --enable-gcc-warnings.
2211 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
2212 * keyboard.c (kbd_buffer_get_event): Remove unused local.
2213
18c26d81
JD
22142013-07-16 Jan Djärv <jan.h.d@swipnet.se>
2215
2216 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
2217 Set event->arg to Qt if switch-event shall be generated.
2218 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
2219
2220 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
2221
2222 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
2223 FOCUS_OUT_EVENT.
2224
2225 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
2226 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
2227 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
2228 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
44e18199 2229 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
18c26d81
JD
2230 and there is a focused frame.
2231 (head_table): Add focus-in and focus-out.
2232 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
2233 bind to handle-focus-in/out.
2234
2235 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
2236 (Fhandle_switch_frame): Call Fhandle_focus_in.
2237 (syms_of_frame): defsubr handle-focus-in/out.
2238
6c6f1994
PE
22392013-07-16 Paul Eggert <eggert@cs.ucla.edu>
2240
c7ddc792
PE
2241 Fix porting bug to older POSIXish platforms (Bug#14862).
2242 * sysdep.c (emacs_pipe): New function, that implements
2243 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
2244 This should port better to CentOS 5 and to Mac OS X 10.6.
2245 All calls to pipe2 changed.
2246
6c6f1994
PE
2247 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
2248 This makes the code easier to read and the executable a bit smaller.
2249 Do not replace all calls to Fcons that happen to create lists,
2250 just calls that are intended to create lists. For example, when
2251 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
2252 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
2253 Similarly for list2 through list5.
2254 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2255 * bytecode.c (exec_byte_code):
2256 * callint.c (quotify_arg, Fcall_interactively):
2257 * callproc.c (Fcall_process, create_temp_file):
2258 * charset.c (load_charset_map_from_file)
2259 (Fdefine_charset_internal, init_charset):
2260 * coding.c (get_translation_table, detect_coding_system)
2261 (Fcheck_coding_systems_region)
2262 (Fset_terminal_coding_system_internal)
2263 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
2264 * composite.c (update_compositions, Ffind_composition_internal):
2265 * dired.c (directory_files_internal, file_name_completion)
2266 (Fsystem_users):
2267 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
2268 * doc.c (Fsnarf_documentation):
2269 * editfns.c (Fmessage_box):
2270 * emacs.c (main):
2271 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
2272 (Feval, eval_sub, Ffuncall, apply_lambda):
2273 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
2274 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
2275 (Fset_file_times, Finsert_file_contents)
2276 (Fchoose_write_coding_system, Fwrite_region):
2277 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
2278 * font.c (font_registry_charsets, font_parse_fcname)
2279 (font_prepare_cache, font_update_drivers, Flist_fonts):
2280 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
2281 * frame.c (make_frame, Fmake_terminal_frame)
2282 (x_set_frame_parameters, x_report_frame_params)
2283 (x_default_parameter, Fx_parse_geometry):
2284 * ftfont.c (syms_of_ftfont):
2285 * image.c (gif_load):
2286 * keyboard.c (command_loop_1):
2287 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
2288 (Fcopy_keymap, append_key, Fcurrent_active_maps)
2289 (Fminor_mode_key_binding, accessible_keymaps_1)
2290 (Faccessible_keymaps, Fwhere_is_internal):
2291 * lread.c (read_emacs_mule_char):
2292 * menu.c (find_and_return_menu_selection):
2293 * minibuf.c (get_minibuffer):
2294 * nsfns.m (Fns_perform_service):
2295 * nsfont.m (ns_script_to_charset):
2296 * nsmenu.m (ns_popup_dialog):
2297 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
2298 (Fx_own_selection_internal):
2299 * nsterm.m (append2):
2300 * print.c (Fredirect_debugging_output)
2301 (print_prune_string_charset):
2302 * process.c (Fdelete_process, Fprocess_contact)
2303 (Fformat_network_address, set_socket_option)
2304 (read_and_dispose_of_process_output, write_queue_push)
2305 (send_process, exec_sentinel):
2306 * sound.c (Fplay_sound_internal):
2307 * textprop.c (validate_plist, add_properties)
2308 (Fput_text_property, Fadd_face_text_property)
2309 (copy_text_properties, text_property_list, syms_of_textprop):
2310 * unexaix.c (report_error):
2311 * unexcoff.c (report_error):
2312 * unexsol.c (unexec):
2313 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
2314 (Fformat_mode_line, syms_of_xdisp):
2315 * xfaces.c (set_font_frame_param)
2316 (Finternal_lisp_face_attribute_values)
2317 (Finternal_merge_in_global_face, syms_of_xfaces):
2318 * xfns.c (x_default_scroll_bar_color_parameter)
2319 (x_default_font_parameter, x_create_tip_frame):
2320 * xfont.c (xfont_supported_scripts):
2321 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
2322 (menu_help_callback, xmenu_show):
2323 * xml.c (make_dom):
2324 * xterm.c (set_wm_state):
2325 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
2326 and similarly for list2 through list5.
2327
bafe80ce
PE
23282013-07-15 Paul Eggert <eggert@cs.ucla.edu>
2329
2330 * callproc.c (Fcall_process_region): Fix minor race and tune.
2331 (create_temp_file): New function, with the temp-file-creation part
2332 of the old Fcall_process_region. Use Fcopy_sequence to create the
2333 temp file name, rather than alloca + build_string, for simplicity.
2334 Don't bother to block input around the temp file creation;
068f9124
SM
2335 shouldn't be needed. Simplify use of mktemp.
2336 Use record_unwind_protect immediately after creating the temp file;
bafe80ce
PE
2337 this closes an unlikely race where the temp file was not removed.
2338 Use memcpy rather than an open-coded loop.
2339 (Fcall_process_region): Use the new function. If the input is
2340 empty, redirect from /dev/null rather than from a newly created
2341 empty temp file; this avoids unnecessary file system traffic.
2342
4700b5a5
PE
23432013-07-14 Paul Eggert <eggert@cs.ucla.edu>
2344
5c97beae
PE
2345 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
2346 Simplify by making this case like the other two. This is a bit
2347 slower on obsolete hosts, but the extra complexity isn't worth it.
2348
4700b5a5
PE
2349 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
2350 * process.c (create_process) [!DOS_NT]:
2351 Remove now-unnecessary calls to emacs_close.
2352
f9a74c4c
EZ
23532013-07-13 Eli Zaretskii <eliz@gnu.org>
2354
922ae7ee
EZ
2355 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
2356 returning early. (Bug#14850)
2357
f9a74c4c
EZ
2358 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
2359 and inhibit-iso-escape-detection attributes of 'undecided'.
2360 (Bug#14822)
2361
5e301d76
PE
23622013-07-13 Paul Eggert <eggert@cs.ucla.edu>
2363
69e0e5ee
PE
2364 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
2365 Reported by Herbert J. Skuhra in
2366 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
2367
5e301d76
PE
2368 Don't lose top specpdl entry when memory is exhausted.
2369 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
2370 specpdl overflow here, to simplify callers; all callers changed.
2371 Always reserve an unused entry at the stack top; this avoids
2372 losing the top entry's information when memory is exhausted.
2373
7e649856
PE
23742013-07-12 Paul Eggert <eggert@cs.ucla.edu>
2375
a773ed9a
PE
2376 Clean up errno reporting and fix some errno-reporting bugs.
2377 * callproc.c (Fcall_process):
2378 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
2379 * process.c (create_process, Fmake_network_process):
2380 * unexaix.c (report_error):
2381 * unexcoff.c (report_error):
2382 Be more careful about reporting the errno of failed operations.
2383 The code previously reported the wrong errno sometimes.
2384 Also, prefer report_file_errno to setting errno + report_file_error.
2385 (Fcall_process): Look at openp return value rather than at path,
2386 as that's a bit faster and clearer when there's a numeric predicate.
2387 * fileio.c (report_file_errno): New function, with most of the
2388 old contents of report_file_error.
2389 (report_file_error): Use it.
2390 (Ffile_exists_p, Ffile_accessible_directory_p):
2391 Set errno to 0 when it is junk.
2392 * fileio.c (Faccess_file):
2393 * image.c (x_create_bitmap_from_file):
2394 Use faccessat rather than opening the file, to avoid the hassle of
2395 having a file descriptor open.
2396 * lisp.h (report_file_errno): New decl.
2397 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
2398
7e649856
PE
2399 Minor EBADF fixes.
2400 * process.c (create_process, wait_reading_process_output) [AIX]:
2401 Remove obsolete SIGHUP-related code, as Emacs no longer disables
2402 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
2403 a multithreaded environment anyway).
2404 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
2405
f6774c1a
AS
24062013-07-12 Andreas Schwab <schwab@linux-m68k.org>
2407
2408 * image.c (x_find_image_file): Don't close a remote file handle.
2409
bacba3c2
PE
24102013-07-12 Paul Eggert <eggert@cs.ucla.edu>
2411
2412 Fix races with threads and file descriptors.
2413 * callproc.c (Fcall_process_region):
2414 * dired.c (open_directory):
2415 * emacs.c (main, Fdaemon_initialized):
2416 * image.c (x_find_image_file):
2417 * inotify.c (Finotify_rm_watch):
2418 * lread.c (Flocate_file_internal):
2419 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
2420 * term.c (term_mouse_moveto, init_tty):
2421 * termcap.c (tgetent):
2422 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
2423 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
2424 * unexhp9k800.c, unexmacosx.c (unexec):
2425 * callproc.c (Fcall_process_region):
2426 Use emacs_close, not close.
2427 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
2428 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
2429 and posix_close function on current platforms (which all lack them).
2430 (emacs_close): Use it. This should fix the races on GNU/Linux and
2431 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
2432 and it should avoid closing random victim file descriptors on
2433 other platforms.
2434
653d4f43
PE
24352013-07-11 Paul Eggert <eggert@cs.ucla.edu>
2436
c8536ec4
PE
2437 * inotify.c (uninitialized): Remove. All uses replaced by -1.
2438 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
2439 Touch up doc a bit.
2440
9c203066
PE
2441 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
2442 This is for .gdbinit xbacktrace.
2443
653d4f43
PE
2444 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
2445 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
2446 (emacs_set_tty): Now static.
2447 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
2448 * term.c (tty_capable_p, tty_default_color_capabilities)
2449 (get_tty_terminal, term_mouse_movement)
2450 (handle_one_term_event, init_tty, maybe_fatal):
2451 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
2452 (tgetent, scan_file, name_match, compare_contin):
2453 * terminal.c (get_terminal):
2454 Use bool for boolean.
2455 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
2456 Prefer char to unsigned char if either will do.
2457 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
2458 (tty_write_glyphs): Prefer int to unsigned.
2459 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
2460 All callers changed.
2461 * termcap.c (tprint, main) [TEST]: Remove non-working test.
2462
45b683a1
PE
24632013-07-10 Paul Eggert <eggert@cs.ucla.edu>
2464
29abe551
PE
2465 Port to C89.
2466 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
2467 (B__dummy__): New dummy symbol, to pacify C89.
2468 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
2469 they can't grok varargs macros.
2470 * dispnew.c (add_window_display_history)
2471 (add_frame_display_history):
2472 * print.c (print_object):
2473 * xdisp.c (debug_method_add):
2474 Use %p printf format only for void pointers.
2475 * emacs.c (usage_message): New constant, replacing ...
2476 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
2477 (main): Adjust to usage reorg.
2478 * fns.c (syms_of_fns):
2479 * profiler.c (syms_of_profiler):
2480 Don't use non-constant struct initializers.
2481 * gnutls.h (gnutls_initstage_t):
2482 * lisp.h (enum Lisp_Fwd_Type):
2483 * lread.c (lisp_file_lexically_bound_p):
2484 * xsettings.c (anonymous enum):
2485 Remove trailing comma.
2486 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
2487 * lisp.h (ENUM_BF): Use unsigned if pedantic.
2488 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
2489 (DEFUN): Use it.
2490 * regex.c (const_re_char): New type, to pacify strict C89.
2491 All uses of 'const re_char' replaced to use it.
2492 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
2493 with glibc when strict C89. This change is imported from gnulib.
2494 All uses changed.
2495 (_Restrict_arr_): Rename from __restrict_arr, similarly.
2496 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
2497 Omit GNU_LINUX implementation, since it requires long long.
2498 * xterm.c (x_draw_underwave):
2499 Do not assume the traditional order of struct's members.
2500 (x_term_init): Rewrite to avoid the need for non-constant structure
2501 initializers.
2502
45b683a1 2503 Syntax cleanup, mostly replacing macros with functions.
763a086d 2504 This removes the need for the syntax_temp hack.
45b683a1
PE
2505 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
2506 * syntax.c (SYNTAX_INLINE): New macro.
2507 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
2508 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
2509 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
2510 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
2511 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
2512 (SYNTAX_COMEND_FIRST): Now functions, not macros.
2513 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
2514 Now constants, not macros.
2515 (syntax_temp) [!__GNUC__]: Remove.
2516 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
2517 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
2518 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
2519 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
2520 Move here from syntax.h; now functions, not macros. Except for the
2521 last function, these are static since only syntax.c uses them.
2522 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
2523 All uses changed. Now a function, not a macro; use this fact
2524 to simplify the code.
2525 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
2526 compiler bugs; no longer relevant.
2527 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2528 (SYNTAX_INLINE): New macro.
2529 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
2530 for the new functions. Use bool for boolean member.
2531 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
2532 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
2533 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
2534 (SETUP_BUFFER_SYNTAX_TABLE):
2535 Now extern inline functions, not macros.
2536 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
2537 Remove; all uses replaced by implementation.
2538 (syntax_temp) [!__GNUC__]: Remove decl.
2539 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
2540
29be4a50
JD
25412013-07-10 Jan Djärv <jan.h.d@swipnet.se>
2542
2543 * emacs.c (main): Fix syntax error.
2544
954b166e
PE
25452013-07-10 Paul Eggert <eggert@cs.ucla.edu>
2546
2547 Timestamp fixes for undo (Bug#14824).
2548 * atimer.c (schedule_atimer):
2549 * fileio.c (Ffile_newer_than_file_p):
2550 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
2551 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
2552 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
2553 (syms_of_fileio): Remove Sclear_visited_file_name.
2554 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
2555 file doesn't exist; this avoids an ambiguity with negative timestamps.
2556 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
2557 * systime.h (make_emacs_time, invalid_emacs_time):
2558 Don't assume struct timespec layout; POSIX doesn't guarantee it.
2559 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
2560 * undo.c (record_first_change): Push (visited-file-modtime) onto
2561 undo list rather than reimplementing it by hand, incorrectly.
2562
d74647c3
KB
25632013-07-09 Ken Brown <kbrown@cornell.edu>
2564
2565 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
2566
3c51b96b
JB
25672013-07-09 Juanma Barranquero <lekktu@gmail.com>
2568
2569 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
2570
4ebbdd67
PE
25712013-07-09 Paul Eggert <eggert@cs.ucla.edu>
2572
2573 Handle errno and exit status a bit more carefully.
2574 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
2575 number into an exit status. Instead, use EXIT_CANCELED.
2576 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
2577 * callproc.c (relocate_fd):
2578 * emacs.c (close_output_streams, main):
2579 * process.c (create_process):
2580 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
2581 Use emacs_perror for simplicity.
2582 * callproc.c (relocate_fd, main):
2583 * sysdep.c (sys_subshell):
2584 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
2585 (shut_down_emacs): Use emacs_write, not write.
2586 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
2587 * fileio.c (Fcopy_file, e_write):
2588 * nsterm.m (ns_select):
2589 * process.c (send_process):
2590 * sound.c (vox_write):
2591 Use emacs_write_sig, not emacs_write.
2592 * lisp.h (emacs_write_sig, emacs_perror): New decls.
2593 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
2594 New constants.
2595 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
2596 of write.
2597 (emacs_full_write): New function.
2598 (emacs_write): Rewrite to use it.
2599 (emacswrite_sig, emacs_perror): New functions.
2600 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
2601
44e18199 26022013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
e4b1e5af
JD
2603
2604 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
2605 on NS even if it is present. Pixmap on NS is a void*.
2606
9caab067
PE
26072013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2608
2609 Port to Ubuntu 10 (Bug#14803).
2610 Problem reported by T.V. Raman.
2611 * process.c (close_on_exec, accept4, process_socket):
2612 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
2613
1d442672
EZ
26142013-07-07 Eli Zaretskii <eliz@gnu.org>
2615
2616 * w32.c (sys_dup): Declare prototype.
2617
2618 * filelock.c:
2619 * emacs.c:
2620 * callproc.c [WINDOWSNT]: Include sys/socket.h.
2621
067428c1
PE
26222013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2623
2624 Make file descriptors close-on-exec when possible (Bug#14803).
2625 This simplifies Emacs a bit, since it no longer needs to worry
2626 about closing file descriptors by hand in some cases.
2627 It also fixes some unlikely races. Not all such races, as
2628 libraries often open files internally without setting
2629 close-on-exec, but it's an improvement.
2630 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
2631 * callproc.c (Fcall_process) [!MSDOS]:
2632 * emacs.c (main) [!DOS_NT]:
2633 * nsterm.m (ns_term_init):
2634 * process.c (create_process):
2635 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
2636 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
2637 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
2638 Prefer mkostemp with O_CLOEXEC to mkstemp.
2639 * callproc.c (relocate_fd) [!WINDOWSNT]:
2640 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
2641 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
2642 now using pipe2.
2643 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
2644 Make the resulting file descriptor close-on-exec.
2645 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
2646 * lread.c (load_descriptor_list, load_descriptor_unwind):
2647 Remove; no longer needed. All uses removed.
2648 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
2649 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
2650 New functions.
2651 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
2652 (Fmake_network_process, Fnetwork_interface_list):
2653 (Fnetwork_interface_info, server_accept_connection):
2654 Make newly-created socket close-on-exec.
2655 * sysdep.c (emacs_open, emacs_fopen):
2656 Make new-created descriptor close-on-exec.
2657 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
2658 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
2659
0da857dd
JD
26602013-07-07 Jan Djärv <jan.h.d@swipnet.se>
2661
2662 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
2663 for NS_IMPL_GNUSTEP.
2664
5f86adcd
PE
26652013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2666
2667 Fix openp errno handling.
2668 * callproc.c (Fcall_process): Preserve openp errno around close.
2669 * lread.c (openp): Set errno when returning -1, as some callers
2670 expect this.
2671
1afb1d07
JD
26722013-07-06 Jan Djärv <jan.h.d@swipnet.se>
2673
2674 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
2675
2676 * nsterm.h (NSSavePanel): Update comment.
2677 (NSAPP_DATA2_RUNFILEDIALOG): Define.
2678 (ns_run_file_dialog): Declare.
2679
2680 * nsfns.m: Remove panelOK.
2681 (ns_fd_data): New.
2682 (ns_run_file_dialog): New function.
2683 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
2684 event loop, so file dialog is popped up by ns_run_file_dialog, called
2685 by sendEvent (Bug#14578).
2686 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
2687
3323c263
EZ
26882013-07-06 Eli Zaretskii <eliz@gnu.org>
2689
fdda0220
EZ
2690 * xdisp.c (default_line_pixel_height): New function.
2691 (pos_visible_p, move_it_vertically_backward, try_scrolling)
2692 (try_cursor_movement, redisplay_window, try_window)
2693 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
2694
068f9124
SM
2695 * window.c (window_scroll_pixel_based):
2696 use default_line_pixel_height.
fdda0220
EZ
2697
2698 * dispextern.h (default_line_pixel_height): Add prototype.
2699
2700 * frame.c (x_set_line_spacing): Accept a float value for
2701 line-spacing parameter, per the documentation.
2702
3323c263
EZ
2703 * data.c (Fmultibyte_string_p): Doc fix.
2704
47ba6d43
PE
27052013-07-05 Paul Eggert <eggert@cs.ucla.edu>
2706
406af475
PE
2707 Use emacs_open more consistently when opening files.
2708 This handles EINTR more consistently now, and makes it easier
2709 to introduce other uniform changes to file descriptor handling.
2710 * src/systdio.h: New file.
2711 * src/buffer.c (mmap_init):
2712 * cygw32.c (chdir_to_default_directory):
2713 * dispnew.c (Fopen_termscript):
2714 * emacs.c (Fdaemon_initialized):
2715 * fileio.c (Fdo_auto_save):
2716 * image.c (slurp_file, png_load_body, jpeg_load_body):
2717 * keyboard.c (Fopen_dribble_file):
2718 * lread.c (Fload):
2719 * print.c (Fredirect_debugging_output):
2720 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
2721 * termcap.c (tgetent):
2722 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
2723 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
2724 * w32term.c (w32_initialize) [CYGWIN]:
2725 * xfaces.c (Fx_load_color_file):
2726 Use emacs_open instead of plain open, and emacs_fopen instead of
2727 plain fopen.
2728 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
2729 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
2730 * callproc.c (default_output_mode): New constant.
2731 (Fcall_process): Use it to call emacs_open instead of plain creat.
2732 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
2733 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
2734 (emacs_fopen): New function.
2735 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
2736 Include <lisp.h>, for emacs_open.
2737 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
2738
47ba6d43
PE
2739 Remove duplicate #include directives.
2740 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
2741 * xfaces.c:
2742 Don't include stdio.h twice.
2743 * buffer.c [USE_MMAP_FOR_BUFFERS]:
2744 Don't include sys/types.h or stdio.h twice.
2745 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
2746 * lread.c: Don't include coding.h twice.
2747 * nsfont.m: Don't include frame.h twice.
2748 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
2749 * ralloc.c: Don't include <unistd.h> twice.
2750 * xdisp.c: Don't include font.h twice.
2751 * xterm.c: Don't include fontset.h twice.
2752 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
2753
b9ed53d5
PE
27542013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2755
2756 Scale ImageMagick images more carefully.
2757 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
2758 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
2759 Be more careful about avoiding undefined behavior after
2760 integer overflow and division by zero.
2761
cf13177e
YM
27622013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2763
2764 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
2765 (syms_of_w32fns): DEFSYM them.
2766 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
2767 (CCHDEVICENAME): Define macros if not defined.
2768 (struct MONITOR_INFO_EX): New struct.
2769 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
2770 (enum_display_monitors_fn): New variable.
2771 (globals_of_w32fns): Initialize it.
2772 (Fx_display_pixel_width, Fx_display_pixel_height)
2773 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
2774 multi-monitor setups in docstrings.
2775 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
2776 screen size by primary monitor's millimeter per pixel.
2777 (w32_monitor_enum, w32_display_monitor_attributes_list)
2778 (w32_display_monitor_attributes_list_fallback)
2779 (Fw32_display_monitor_attributes_list): New functions.
2780 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
2781
2782 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
2783 if not defined.
2784 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
2785
86dfb7a8
MA
27862013-07-04 Michael Albinus <michael.albinus@gmx.de>
2787
2788 * fileio.c (Qfile_notify_error): New error symbol.
2789
2790 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
2791 * inotify.c (inotify_callback, symbol_to_inotifymask)
2792 (Finotify_add_watch, Finotify_rm_watch): Use it.
2793 (inotifyevent_to_event): Exchange order of cookie and file name.
2794 (Finotify_add_watch): Adapt docstring.
2795
2796 * lisp.h (Qfile_notify_error): Declare.
2797
2c1c974b
PE
27982013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2799
2800 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
2801 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2802 Do not clear _malloc_thread_enabled_p, undoing the previous change,
2803 which did not work (see <http://bugs.gnu.org/14569#307>).
2804 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
2805 && (!noninteractive || initialized)). This attempts to thread
2806 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
2807
7a35b20f
JB
28082013-07-04 Juanma Barranquero <lekktu@gmail.com>
2809
2810 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
2811 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
2812
1ce5cd04
PE
28132013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2814
2815 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
2816 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2817 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
2818 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
2819
57f8c490
PE
28202013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2821
2822 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
2823 Define to __sys_siglist.
2824
bcffb5ca
EZ
28252013-07-02 Eli Zaretskii <eliz@gnu.org>
2826
2827 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
2828 word-wrap, so that overflow-newline-into-fringe would work in
2829 visual-line-mode. (Bug#2749)
2830 (move_it_in_display_line_to): When the last scanned display
2831 element fits exactly on the display line, and
2832 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
2833 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
2834 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
2835 finding buffer position that corresponds to pixel coordinates,
2836 e.g. in buffer_posn_from_coords.
2837
2c41e781
JD
28382013-07-02 Jan Djärv <jan.h.d@swipnet.se>
2839
2840 * process.c (handle_child_signal): Call catch_child_signal if
2841 NS_IMPL_GNUSTEP.
2842
c2418359
PE
28432013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2844
52a9bcae
PE
2845 Don't convert function pointers to void * and back.
2846 It isn't portable C, and it's easy enough to avoid.
2847 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
2848 (make_save_value): Add support for SAVE_FUNCPOINTER.
2849 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
2850 * print.c (print_object):
2851 Distinguish function from object pointers.
2852 * lisp.h (SAVE_FUNCPOINTER): New constant.
2853 (SAVE_SLOT_BITS): Adjust to it.
2854 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
2855 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
2856 (voidfuncptr): New typedef.
2857 (struct Lisp_Save_Value): New member data[0].funcpointer.
2858 (XSAVE_FUNCPOINTER): New function.
2859
c2418359
PE
2860 Simplify buildobj processing.
2861 * Makefile.in (buildobj.h): Make it a sequence of strings each
2862 followed by comma, rather than a single string. Put it into a
2863 .tmp file in case there's an error while generating it.
2864 (gl-stamp): Use .tmp for temp files.
2865 (mostlyclean): Clean .tmp files.
2866 * doc.c (buildobj): Move to just the routine that needs it.
2867 It's now an array of strings, so processing is simpler.
2868
8f43ce49
PE
28692013-07-01 Paul Eggert <eggert@cs.ucla.edu>
2870
2871 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
2872 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
2873 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2874 Invoke malloc_enable_thread even when not interactive.
2875 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
2876 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
2877 in this case, since the underlying bug has now been fixed.
2878
24827db9
JB
28792013-07-01 Juanma Barranquero <lekktu@gmail.com>
2880
2881 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
2882 unlinking it (bug#14691).
2883
ef099a94
MN
28842013-06-30 Michal Nazarewicz <mina86@mina86.com>
2885
2886 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
2887 before checking whether buffer is modified. This lets
2888 `kill-buffer-query-functions' cancel killing of the buffer or save
2889 its content before `kill-buffer' asks user the "Buffer %s
2890 modified; kill anyway?" question.
2891
9d3f2fc2
JD
28922013-06-30 Jan Djärv <jan.h.d@swipnet.se>
2893
2894 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
2895 Let the super performKeyEquivalent deal with them (Bug#14747).
2896
e6c6c8c7
PE
28972013-06-30 Paul Eggert <eggert@cs.ucla.edu>
2898
1d71c1d9
PE
2899 * widget.c (resize_cb): Remove unused local.
2900
8f5f35cc
PE
2901 Do not use GTK 3 if it exists but cannot be compiled.
2902 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
2903 * xterm.c (x_error_handler) [!USE_GTK]:
2904 Do not use GTK 3.
2905
e6c6c8c7
PE
2906 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
2907
0ba54312
EZ
29082013-06-30 Eli Zaretskii <eliz@gnu.org>
2909
5d1c3286
EZ
2910 * intervals.c (get_local_map): Instead of aborting, clip POSITION
2911 to the valid range of values. (Bug#14753)
2912
0ba54312
EZ
2913 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
2914 when moving point by using the current glyph matrix. This avoids
2915 the need to force redisplay when this function is called in a
2916 loop.
2917
9c90cc06
PE
29182013-06-29 Paul Eggert <eggert@cs.ucla.edu>
2919
2920 Fix minor problems found by static checking.
2921 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
2922 Redo the latter's body to sidestep GCC parenthesization warnings.
2923 (setup_coding_system, detect_coding, detect_coding_system): Use them.
2924 * coding.c (detect_coding, detect_coding_system):
2925 * coding.h (struct undecided_spec):
2926 Use bool for boolean.
2927 * image.c (QCmax_width, QCmax_height): Now static.
2928 * xdisp.c (Fmove_point_visually): Remove unused local.
2929
4c672a0f
EZ
29302013-06-29 Eli Zaretskii <eliz@gnu.org>
2931
2932 * xdisp.c (Fmove_point_visually): New function.
2933
c1ea3abf
JB
29342013-06-28 Kenichi Handa <handa@gnu.org>
2935
2936 * coding.h (define_coding_undecided_arg_index): New enum.
2937 (coding_attr_index): New members
2938 coding_attr_undecided_inhibit_null_byte_detection,
2939 coding_attr_undecided_inhibit_iso_escape_detection,
2940 coding_attr_undecided_prefer_utf_8.
2941 (undecided_spec): New struct.
2942 (struct coding_system): New member `undecided' of the member
2943 `spec'.
2944
2945 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
2946 (detect_coding): Likewise.
2947 (detect_coding_system): Likewise.
2948 (Fdefine_coding_system_internal): New coding system properties
2949 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
2950 :prefer-utf-8.
2951 (syms_of_coding): Adjust for coding_arg_undecided_max.
2952
ba3de9e6
PE
29532013-06-28 Paul Eggert <eggert@cs.ucla.edu>
2954
2955 * image.c (x_from_xcolors): Remove unused local.
2956
547c9269
YM
29572013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2958
2959 Defer image data transfer between X client and server until actual
2960 display happens.
2961
2962 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
2963 and `mask_img'.
2964
2965 * image.c (Destroy_Image): Remove.
2966 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
2967 `mask_p', and `colors_p'. All uses changed.
2968 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
2969 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
2970 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
2971 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
2972 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 2973 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
2974 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
2975 (image_get_x_image, image_unget_x_image): New functions or macros.
2976 (image_background, image_background_transparent, x_to_xcolors)
2977 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
2978 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
2979 instead of Destroy_Image.
2980 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
2981 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
2982 (png_load_body, jpeg_load_body, tiff_load, gif_load)
2983 (imagemagick_load_image, svg_load_image): Use them instead of
2984 x_create_x_image_and_pixmap, and x_put_x_image followed by
2985 x_destroy_x_image, respectively.
2986 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
2987 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
2988 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
2989 background_transparent fields.
2990 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
2991 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
2992
dae2f5ef
PE
29932013-06-27 Paul Eggert <eggert@cs.ucla.edu>
2994
2995 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
2996 This mostly consists of undoing recent changes.
2997 * callproc.c (Fcall_process):
2998 * process.c (create_process):
2999 Do not worry about catching SIGCHLD here, undoing previous change.
3000 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
3001 * process.c, process.h (catch_child_signal):
3002 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
3003 * process.c (catch_child_handler): Don't worry about being called
3004 lazily and do not assume caller has blocked SIGCHLD, undoing
3005 previous change. Move first-time stuff back to
3006 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
3007 tickle glib, as that causes Cygwin bootstrap to fail. Do not
3008 set lib_child_handler if it's already initialized, which may
3009 help avoid problems on GNUStep.
3010
fa55d2aa
PE
30112013-06-23 Paul Eggert <eggert@cs.ucla.edu>
3012
3013 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
3014 * callproc.c (Fcall_process):
3015 * process.c (create_process):
3016 Make sure SIGCHLD is caught before we fork,
3017 since Emacs startup no arranges to catch SIGCHLD.
3018 * process.c (lib_child_handler): Initialize to null, not to
3019 dummy_handler.
3020 (catch_child_signal): Allow self to be called lazily.
3021 Do nothing if it's already been called.
3022 Assume caller has blocked SIGCHLD (all callers do now).
3023 * emacs.c (main): Do not catch SIGCHLD here; defer it until
3024 just before it's really needed.
3025 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
3026 since it hasn't been caught yet.
3027
f3f9606c
LMI
30282013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
3029
3030 * image.c (compute_image_size): New function to implement
3031 :max-width and :max-height.
3032 (imagemagick_load_image): Use it.
3033
c7041908
PE
30342013-06-23 Paul Eggert <eggert@cs.ucla.edu>
3035
3036 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
3037 * callproc.c, process.h (block_child_signal, unblock_child_signal):
3038 Now extern.
3039 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
3040 * process.c (catch_child_signal): Block SIGCHLD while futzing with
3041 the SIGCHLD handler, since the code is not atomic and (due to glib)
3042 signals may be arriving now.
3043 * sysdep.c (init_signals): Do not catch child signals here;
3044 'main' now does that later, at a safer time.
3045
f86852b4
PE
30462013-06-22 Paul Eggert <eggert@cs.ucla.edu>
3047
0dfeed58
PE
3048 Clean up SIGCHLD handling a bit (Bug#14569).
3049 * process.c, process.h (catch_child_signal):
3050 Now always extern, even if !NS_IMPL_GNUSTEP.
3051 * process.c (catch_child_signal): Move glib tickler here from
3052 init_process_emacs, so that it's done earlier in Emacs
3053 initialization. Also move the noninteractive && !initialized
3054 check here from init_process_emacs. This is all a bit cleaner for
3055 GNUish platforms, and I hope it works around the Cygwin bug.
3056 * sysdep.c (init_signals): Invoke catch_child_signal here, so
3057 that glib signal handling is tickled before glib creates threads.
3058
f86852b4
PE
3059 * process.c (wait_reading_process_output): Avoid int overflow
3060 when reading more than 2 GiB total from a process.
3061
cbd6509c
PE
30622013-06-21 Paul Eggert <eggert@cs.ucla.edu>
3063
3064 * process.c (create_process): Handle a couple more cases,
3065 i.e., work even if new_argv and wait_child_setup[i] are cached.
3066 Use Fcall_process's style for volatile vars.
3067
9de1114a
AS
30682013-06-21 Andreas Schwab <schwab@linux-m68k.org>
3069
3070 * process.c (create_process): Mark PROCESS volatile.
3071
fbe9e0b9
PE
30722013-06-21 Paul Eggert <eggert@cs.ucla.edu>
3073
3074 Use C99-style flexible array members if available.
3075 This avoids some subtle aliasing issues, which typically
3076 aren't a problem with GCC but may be a problem elsewhere.
3077 * alloc.c (sdata): New typedef, replacing the old struct sdata.
3078 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
3079 In either case, it uses a flexible array member rather than
3080 the old struct hack. All uses changed.
3081 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
3082 Adjust to sdata reorganization.
3083 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
3084 Use offsetof (struct, flex_array_member), not sizeof (struct), as
3085 that ports better to pre-C99 non-GCC.
3086 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
3087 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
3088 as the latter has changed.
3089 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
3090 and port better to pre-C99 GCC.
3091 * image.c (struct xpm_cached_color):
3092 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
3093 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
3094 Use FLEXIBLE_ARRAY_MEMBER.
3095 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
3096 Move decl to top level so it gets checked against implementation.
3097 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
3098 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
3099
1fc71008
PE
31002013-06-20 Paul Eggert <eggert@cs.ucla.edu>
3101
3102 * syntax.c: Integer cleanups.
3103 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
3104 All uses that need 0-or-2 changed to:
3105 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
3106 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
3107 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
3108 (char_quoted, prev_char_comend_first, back_comment)
3109 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
3110 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
3111 Use bool for boolean.
3112 (update_syntax_table, skip_chars, skip_syntaxes):
3113 Prefer int to unsigned when either will do.
3114 (back_comment): Return boolean success flag, like forw_comment,
3115 instead of positive-or-minus-1 (which might have overflowed int anyway).
3116 Don't stuff ptrdiff_t into int.
3117 (syntax_spec_code, syntax_code_spec): Now const.
3118 (Fmatching_paren, scan_lists, scan_sexps_forward):
3119 Use enum syntaxcode for syntax code.
3120 (Fmatching_paren): Check that arg is a character, not just an integer.
3121 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
3122 (Finternal_describe_syntax_value): Omit no-longer-needed
3123 comparison to 0.
3124 (skip_chars): Use char, not unsigned char, when the distinction
3125 doesn't matter.
3126 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
3127 * bytecode.c (exec_byte_code):
3128 * syntax.c (syntax_spec_code, Fchar_syntax)
3129 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
3130 (init_syntax_once):
3131 * syntax.h (SYNTAX_WITH_FLAGS):
3132 Omit unnecessary casts.
3133
b932cad7
EZ
31342013-06-20 Eli Zaretskii <eliz@gnu.org>
3135
3136 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
3137 line dimensions here, to avoid race conditions with the main
3138 thread. (Bug#14062, bug#14630, bug#14669)
3139
3140 * w32term.c (w32_draw_window_cursor): Compute the header line and
3141 mode line dimensions here.
3142 <w32_system_caret_window, w32_system_caret_hdr_height>:
3143 <w32_system_caret_mode_height>: New variables.
3144
3145 * w32term.h: Declare them.
3146
89561f72
PE
31472013-06-20 Paul Eggert <eggert@cs.ucla.edu>
3148
5013fc08
PE
3149 * alloc.c (die): Move "assertion failed" string here ...
3150 * lisp.h (eassert): ... from here. Also, suppress evaluation of
3151 COND when SUPPRESS_CHECKING. This shrinks the executable text
3152 size by 0.8% to 2.2% when configured with --enable-checking,
3153 depending on optimization flags (GCC 4.8.1 x86-64).
3154
89561f72
PE
3155 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
3156
763a086d 31572013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
3158
3159 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
3160 base is 2; this is more accurate.
3161
983aeb9a
JB
31622013-06-19 Juanma Barranquero <lekktu@gmail.com>
3163
3164 * sound.c (string_default): Move to !WINDOWSNT section.
3165 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
3166
178ba3e6
PE
31672013-06-19 Paul Eggert <eggert@cs.ucla.edu>
3168
bbc51b15
PE
3169 * sound.c: Integer cleanups.
3170 Remove unnecessary forward decls.
3171 (struct sound_device): The 'file' member is now a Lisp_Object, not
3172 a char *, so that we needn't invoke alloca on a huge size.
3173 (Fplay_sound_internal): Adjust to this.
3174 (string_default): New function.
3175 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
3176 Use it to adjust to the struct sound_device change.
3177 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
3178 (be2hs) [0]: Remove.
3179
178ba3e6
PE
3180 * syntax.c (skip_chars): Don't use uninitialized storage
3181 when searching a multibyte buffer for characters that are not in a
3182 unibyte string that contains non-ASCII characters.
3183
69f60cdc
JD
31842013-06-18 Jan Djärv <jan.h.d@swipnet.se>
3185
3186 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
3187 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
3188
0d6224d4
PE
31892013-06-18 Paul Eggert <eggert@cs.ucla.edu>
3190
3191 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
3192
3c542890
KH
31932013-06-18 Kenichi Handa <handa@gnu.org>
3194
f7e3f7cd
KH
3195 * font.c (Ffont_spec): Signal an error for an invalid font name
3196 (Bug#14648).
3c542890 3197
9349e5f7
PE
31982013-06-18 Paul Eggert <eggert@cs.ucla.edu>
3199
3200 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
3201 In particular this ports to 32-bit sparc Sun cc.
3202 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
3203 array with a dummy element at specpdl[-1], so that its address can
3204 be taken portably.
3205 (unbind_to): Do not copy the binding; not needed, now that we
3206 copy old_value in the one place where the copy is needed.
3207 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
3208 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
3209 (union specbinding): Rename from struct specbinding. Redo layout
3210 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
3211 which is not portable. With Sun C 5.12 32-bit sparc, the
3212 declaration causes nargs to be an unsigned bitfield, a behavior
3213 that the C standard allows; but Emacs wants nargs to be signed.
3214 The overall type is now a union of structures rather than a
3215 structure of union of structures, and the 'kind' member is now a
3216 bitfield, so that the overall type doesn't grow. All uses changed.
3217 * process.c (Fmake_serial_process): Remove unnecessary initialization.
3218
0a4df6a5
PE
32192013-06-17 Paul Eggert <eggert@cs.ucla.edu>
3220
ec6ecaad
PE
3221 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
3222 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
3223
0a4df6a5
PE
3224 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
3225
7bfe8dbc
EZ
32262013-06-17 Eli Zaretskii <eliz@gnu.org>
3227
3228 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
3229 unless we know that the window w's frame is a frame object.
3230 Another attempt at solving bug#14062 and bug#14630.
3231
708e05f6
LMI
32322013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
3233
3234 * textprop.c (property_set_type): New enum.
3235 (add_properties): Allow appending/prepending text properties.
3236 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 3237 (Fadd_text_properties): Move all the code into
708e05f6
LMI
3238 add_text_properties_1.
3239 (Fadd_face_text_property): New function that calls
3240 add_text_properties_1.
3241
84575e67
PE
32422013-06-17 Paul Eggert <eggert@cs.ucla.edu>
3243
3244 Move functions from lisp.h to individual modules when possible.
3245 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
3246 * alloc.c (XFLOAT_INIT, set_symbol_name):
3247 * buffer.c (CHECK_OVERLAY):
3248 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
3249 (set_char_table_parent):
3250 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
3251 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
3252 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
3253 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
3254 (set_blv_valcell):
3255 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
3256 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
3257 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
3258 (backtrace_args, backtrace_debug_on_exit):
3259 * floatfns.c (CHECK_FLOAT):
3260 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
3261 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
3262 (set_hash_hash, set_hash_hash_slot, set_hash_index)
3263 (set_hash_index_slot):
3264 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
3265 * marker.c (CHECK_MARKER):
3266 * textprop.c (CHECK_STRING_OR_BUFFER):
3267 * window.c (CHECK_WINDOW_CONFIGURATION):
3268 Move here from lisp.h, and make these functions static rather than
3269 extern inline.
3270 * buffer.c (Qoverlayp):
3271 * data.c (Qsubrp):
3272 * fns.c (Qhash_table_p):
3273 * window.c (Qwindow_configuration_p):
3274 Now static.
3275 * lisp.h: Remove the abovementioned defns and decls.
3276
44e18199 3277 Use functions, not macros, for XINT etc (Bug#11935).
84575e67
PE
3278 In lisp.h, prefer functions to function-like macros, and
3279 constants to object-like macros, when either will do. This:
3280 . simplifies use, as there's no more need to worry about
3281 arguments' side effects being evaluated multiple times.
3282 . makes the code easier to debug on some platforms.
3283 However, when using gcc -O0, keep using function-like macros
3284 for a few critical operations, for performance reasons.
3285 This sort of thing isn't needed with gcc -Og, but -Og
3286 is a GCC 4.8 feature and isn't widely-enough available yet.
3287 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
3288 Remove enum lsb_bits; no longer needed.
3289 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
3290 * buffer.c (Qoverlap):
3291 * data.c (Qsubrp):
3292 * fns.c (Qhash_table_p):
3293 Now extern, so lisp.h can use these symbols.
3294 * dispextern.h: Include character.h, for MAX_CHAR etc.
3295 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
3296 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
3297 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
3298 (GLYPH_CODE_P): Move here from lisp.h.
3299 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
3300 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
3301 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
3302 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
3303 XUNTAG now returns void *.
3304 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
3305 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
3306 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
3307 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
3308 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
3309 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
3310 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
3311 (lisp_h_XPNTR, lisp_h_XSYMBOL):
3312 New macros, renamed from their sans-lisp_h_ counterparts.
3313 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
3314 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
3315 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
3316 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
3317 If compiling via GCC without optimization, define these as macros
3318 in addition to inline functions.
3319 To disable this, compile with -DINLINING=0.
3320 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
3321 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
3322 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
3323 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
3324 (INTMASK, VALMASK): Now macros, since static values cannot be
3325 accessed from extern inline functions.
3326 (VALMASK): Also a constant, for benefit of old GDB.
3327 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
3328 is INTEGERP, which can fold it in.
5165d44a 3329 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
3330 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
3331 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
3332 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
3333 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
3334 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
3335 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
3336 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
3337 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
3338 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
3339 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
3340 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
3341 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
3342 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
3343 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
3344 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
3345 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
3346 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
3347 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
3348 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
3349 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
3350 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
3351 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
3352 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
3353 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
3354 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
3355 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
3356 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
3357 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
3358 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
3359 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
3360 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
3361 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
3362 Now functions.
3363 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
3364 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
3365 (VALMASK): Define in one place rather than in two, merging the
3366 USE_LSB_TAG parts; this is simpler.
3367 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
3368 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
3369 Move up, to avoid use before definition.
3370 Also include "globals.h" earlier, for the same reason.
3371 (make_natnum): New function.
3372 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
3373 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
3374 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
3375 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
3376 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
3377 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
3378 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
3379 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
3380 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
3381 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
3382 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
3383 (Qwindow_configuration_p, Qimage): New forward declarations.
3384 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
3385 (STRING_COPYIN): Remove; unused.
3386 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
3387 (xcar_addr, xcdr_addr): New functions. All uses changed.
3388 (IEEE_FLOATING_POINT): Now a constant, not a macro.
3389 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
3390 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
3391 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
3392 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
3393 (TYPE_RANGED_INTEGERP): Simplify.
3394 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
3395 (setlocale, fixup_locale, synchronize_system_messages_locale)
3396 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
3397 Now empty functions, not macros.
3398 (functionp): Return bool, not int.
3399 * window.c (Qwindow_configuration_p): Now extern,
3400 so window.h can use it.
3401 * window.h (Qwindowp): Move decl back to lisp.h.
3402
9583ec36
EZ
34032013-06-15 Eli Zaretskii <eliz@gnu.org>
3404
3405 * xdisp.c (Fline_pixel_height): New function, required for solving
3406 bug #14567.
3407
210272ce
PE
34082013-06-15 Paul Eggert <eggert@cs.ucla.edu>
3409
3410 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
3411
de0503df
SM
34122013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
3413
3414 * lread.c (syms_of_lread):
3415 * fns.c (Fprovide): Adjust to new format of after-load-alist.
3416
afbfe143
KD
34172013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
3418
3419 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
3420
d177e213
XF
34212013-06-12 Xue Fuqiao <xfq.free@gmail.com>
3422
3423 * fileio.c (expand_file_name): Doc fix.
3424
05e3e412
PE
34252013-06-11 Paul Eggert <eggert@cs.ucla.edu>
3426
f7394b12
PE
3427 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
3428 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
3429 Wait for self, not for 0. This can't hurt on GNU or similar
3430 system, and may help with Cygwin.
3431
05e3e412
PE
3432 * keyboard.c: Don't use PROP (...) as an lvalue.
3433 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
3434 Use set_prop (A, B), not PROP (A) = B.
3435
17dd3097
EZ
34362013-06-10 Eli Zaretskii <eliz@gnu.org>
3437
3438 * xdisp.c (get_it_property): Use it->window instead of generating
3439 a Lisp object from it->w.
3440
52fab9c9
EZ
34412013-06-09 Eli Zaretskii <eliz@gnu.org>
3442
3443 * xdisp.c (get_it_property): If it->object is a buffer, pass to
3444 get-char-property the window that is being rendered, instead of
3445 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
3446 (compute_display_string_pos): When W is NULL, use the current
3447 buffer as the object to pass to get-char-property.
3448 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
3449 pointer member of the bidi iterator, since no window is pertinent
3450 to this function.
52fab9c9 3451
5bf97bfc
EZ
34522013-06-08 Eli Zaretskii <eliz@gnu.org>
3453
3454 * bidi.c (bidi_fetch_char): Accept additional argument, the window
3455 being displayed, and pass it to compute_display_string_pos.
3456 (bidi_level_of_next_char, bidi_resolve_explicit_1)
3457 (bidi_paragraph_init): All callers changed.
3458
3459 * xdisp.c (init_from_display_pos, init_iterator)
3460 (handle_single_display_spec, next_overlay_string)
3461 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
3462 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
3463 Set bidi_it.w member from it->w.
5bf97bfc
EZ
3464 (compute_display_string_pos): Accept additional argument, the
3465 window being displayed, and pass it to Fget_char_property.
3466 (Bug#14575)
3467
3468 * dispextern.h (struct bidi_it): New member w, the window being
3469 displayed.
3470 (compute_display_string_pos): Adjust prototype.
3471
5de0e011
JD
34722013-06-08 Jan Djärv <jan.h.d@swipnet.se>
3473
e7b41c4c 3474 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
3475
3476 * process.c (wait_reading_process_output): Check for NS before GLIB.
3477 GLIB may be linked in due to rsvg, but ns_select must be called.
3478
5de0e011
JD
3479 * xgselect.c (xg_select): Remove call to window_system_available
3480 and g_main_context_pending at the top, so Gdk events (i.e. file
3481 notify) are processed when Emacs is started with -nw.
3482
a822acff
EZ
34832013-06-07 Eli Zaretskii <eliz@gnu.org>
3484
3485 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
3486 (ctagsfiles3): New variable, includes only *.m files.
3487 (TAGS): Use an explicit language name in the regular expressions,
3488 to avoid transformation of '/SOMETHING' by MSYS to
3489 'c:\MSYS\SOMETHING'.
3490
6c0a9ed1
RC
34912013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
3492
3493 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
3494
9ef6111b
EZ
34952013-06-06 Eli Zaretskii <eliz@gnu.org>
3496
3497 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
3498 still need to set the mouse pointer shape and activate help-echo.
3499 (Bug#14558)
3500
7d300d64
PE
35012013-06-06 Paul Eggert <eggert@cs.ucla.edu>
3502
3503 A few porting etc. fixes for the new file monitor code.
3504 See the thread containing
3505 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
3506 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
3507 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
3508 (dir_monitor_callback, Fgfile_rm_watch):
3509 Use assq_no_quit instead of Fassoc, for speed.
3510 (dir_monitor_callback, Fgfile_rm_watch):
3511 eassert that the monitor is a fixnum.
3512 (dir_monitor_callback): No need for CDR_SAFE.
3513 Simplify building of lisp with alternative tails.
3514 (Fgfile_add_watch, Fgfile_rm_watch):
3515 Do not assume glib functions set errno reliably on failure.
3516 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
3517 and signal an error otherwise.
3518 (Fgfile_rm_watch): Prefer CONSP to !NILP.
3519 Use Fdelq instead of Fdelete, for speed.
3520
817ebfcf
EZ
35212013-06-05 Eli Zaretskii <eliz@gnu.org>
3522
3523 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
3524 don't insist on being invoked on a highlighted tool-bar button.
3525 Avoids losing tool-bar functionality when mouse-highlight is nil.
3526 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
3527 Don't highlight when mouse-highlight is nil.
3528 (note_mouse_highlight): When mouse-highlight is nil, don't return
3529 right away; instead, run tool-bar and mode-line highlight
3530 subroutine, clear any existing highlight, and revert the mouse
3531 pointer to its default shape. (Bug#14558)
3532
55577e7c
SM
35332013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
3534
3535 * lisp.mk (lisp): Add prog-mode.el.
3536
f019a684
PE
35372013-06-05 Paul Eggert <eggert@cs.ucla.edu>
3538
3539 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
3540 * process.c (dummy_handler): New function.
3541 (lib_child_handler): New static var.
3542 (handle_child_signal): Invoke it.
3543 (catch_child_signal): If a library has set up a signal handler,
3544 save it into lib_child_handler.
3545 (init_process_emacs): If using glib and not on Windows, tickle glib's
3546 child-handling code so that it initializes its private SIGCHLD handler.
3547 * syssignal.h (SA_SIGINFO): Default to 0.
3548 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
3549 31; it should no longer be needed now.
3550
90db8702
MA
35512013-06-05 Michael Albinus <michael.albinus@gmx.de>
3552
3553 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
3554
3555 * gfilenotify.c (globals_of_gfilenotify): New function.
3556 (syms_of_gfilenotify): Move global initialization there.
3557
3558 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
3559
bfa3acd6
SM
35602013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
3561
3562 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
3563 * keyboard.c (menu_bar_items, tool_bar_items):
3564 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
3565 not override local keymaps any more.
3566
ba59bd80
EZ
35672013-06-04 Eli Zaretskii <eliz@gnu.org>
3568
3569 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
3570
7f203aa1
EZ
35712013-06-03 Eli Zaretskii <eliz@gnu.org>
3572
9337e206
EZ
3573 * w32console.c (initialize_w32_display): Return the dimensions of
3574 the console window via 2 additional arguments, not via the current
3575 frame. This avoids crashes due to overrunning the bounds of
3576 frame's decode_mode_spec_buffer, which is not resized following
3577 the change of the frame dimensions from the initial 10x10.
3578
3579 * w32term.h (w32_initialize_display_info): Adjust prototype.
3580
3581 * term.c (init_tty): Take dimensions of the frame from the values
3582 returned by initialize_w32_display.
3583
7f203aa1
EZ
3584 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
3585 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
3586 (LIBES): Add $(GFILENOTIFY_LIBS).
3587
3588 * w32inevt.c (handle_file_notifications): Add dummy implementation
3589 for !HAVE_W32NOTIFY.
3590
3591 * w32term.c: Wrap code with HAVE_W32NOTIFY.
3592
55a87246
JD
35932013-06-03 Jan Djärv <jan.h.d@swipnet.se>
3594
3595 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
3596
3597 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
3598
3599 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
3600
3d5ee10a
PE
36012013-06-03 Paul Eggert <eggert@cs.ucla.edu>
3602
3603 Fix minor problems found by static checking.
3604 * data.c (pure_write_error):
3605 Use xsignal2, not Fsignal, as Fsignal might return.
3606 * eval.c (set_backtrace_debug_on_exit): Now static.
3607 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
3608 No longer inline. EXTERN_INLINE is needed only for functions
3609 defined in .h files. Reindent function header as per GNU style.
3610 (backtrace_p, backtrace_top, backtrace_next):
3611 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
3612 compiler or linker. Add extern decls to pacify gcc -Wall.
3613 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
3614 Now static.
3615 * frame.c (free_monitors): Define only on platforms that need it.
3616 * nsterm.m (ns_term_init):
3617 * process.c (catch_child_signal):
3618 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
3619 defined on all porting targets these days.
3620 * process.c, process.h (catch_child_signal):
3621 Make it extern only if NS_IMPL_GNUSTEP is defined.
3622
e2d8a6f0
EZ
36232013-06-03 Eli Zaretskii <eliz@gnu.org>
3624
3625 * w32.c (gettimeofday): Make the signature identical to prototype
3626 in nt/inc/sys/time.h.
3627
a8a7c5f6
SM
36282013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
3629
3630 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
3631 .gdbinit.
3632
3633 * keyboard.c (safe_run_hooks_error): Improve error message.
3634
3635 * data.c (pure_write_error): Add `object' argument.
3636 * puresize.h (CHECK_IMPURE): Use it.
3637
c9628c79
MA
36382013-06-03 Michael Albinus <michael.albinus@gmx.de>
3639
3640 * Makefile.in (NOTIFY_OBJ): New variable.
3641 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
3642
3643 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
3644 Call syms_of_gfilenotify.
3645
3646 * gfilenotify.c: New file.
3647
3648 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
3649 and Qfile_w32notify.
3650 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
3651 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
3652
3653 * lisp.h: Declare syms_of_gfilenotify.
3654
3655 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
3656
2f592f95
SM
36572013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
3658
3659 Merge the specpdl and backtrace stacks. Make the structure of the
3660 specpdl entries more obvious via a tagged union of structs.
3661 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
3662 (enum specbind_tag): New enum.
3663 (struct specbinding): Make it a tagged union of structs.
3664 Add a case for backtrace records.
3665 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
3666 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
3667 (backtrace_debug_on_exit): New accessors.
3668 (struct backtrace): Remove.
3669 (struct catchtag): Remove backlist field.
3670 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3671 Move to eval.c.
3672 (Flocal_variable_p): Speed up the common case where the binding is
3673 already loaded.
3674 * eval.c (backtrace_list): Remove.
3675 (set_specpdl_symbol, set_specpdl_old_value): Remove.
3676 (set_backtrace_args, set_backtrace_nargs)
3677 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
3678 (backtrace_next): New functions.
3679 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
3680 (unwind_to_catch, internal_lisp_condition_case)
3681 (internal_condition_case, internal_condition_case_1)
3682 (internal_condition_case_2, internal_condition_case_n): Don't bother
3683 with backtrace_list any more.
3684 (Fsignal): Adjust to new backtrace format.
3685 (grow_specpdl): Move up.
3686 (record_in_backtrace): New function.
3687 (eval_sub, Ffuncall): Use it.
3688 (apply_lambda): Adjust to new backtrace format.
3689 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
3690 data.c.
3691 (specbind): Adjust to new specpdl format. Simplify.
3692 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
3693 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
3694 backtrace format.
3695 (mark_backtrace): Remove.
3696 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
3697 * xdisp.c (redisplay_internal): Use record_in_backtrace.
3698 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
3699 Use mark_specpdl.
3700 * profiler.c (record_backtrace): Use get_backtrace.
3701 (handle_profiler_signal): Use backtrace_top_function.
3702 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
3703 accessor functions.
3704
c0342369
JD
37052013-06-02 Jan Djärv <jan.h.d@swipnet.se>
3706
3707 * process.h (catch_child_signal): Declare.
3708
3709 * process.c (catch_child_signal): New function.
3710 (init_process_emacs): Call it.
3711
3712 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
3713 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
3714 NS_IMPL_COCOA.
3715 (x_set_cursor_type): Remove declaration.
3716 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
3717 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
3718 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
3719 (ns_get_color): Use F suffix on float.
3720 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
3721 (ns_get_rgb_color): Remove.
3722 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
3723 (note_mouse_movement): x and y are CGFloat.
3724 (ns_draw_fringe_bitmap): Remove unused rowY.
3725 Change #if to COCOA && >= 10_6.
3726 (ns_draw_window_cursor): Remove unused overspill.
3727 (ns_draw_underwave): width and x are EamcsCGFloat.
3728 (ns_draw_box): thickness is CGFloat.
3729 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
3730 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
3731 if not in main thread.
3732 (ns_get_pending_menu_title, ns_check_menu_open)
3733 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
3734 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
3735 (sendFromMainThread:): New method.
3736 (changeFont:): size is CGFloat.
3737 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
3738 Disable warning about permanent text.
3739 (characterIndexForPoint:): Adjust return type depending on GNUStep
3740 version.
3741 (mouseDown:): delta is CGFloat.
3742 (updateFrameSize): Remove unised variable f.
3743 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
3744 Cast float to EmacsCGFloat.
3745 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
3746 also to -1 when restoring.
3747 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
3748 inside NS_IMPL_COCOA.
3749 (toggleFullScreen:): Put call to toggleFullScreen inside
3750 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
3751 (setPosition:portion:whole:): por is CGFloat.
3752 (getMouseMotionPart:window:x:y:): Add F suffix to float.
3753 (mouseDown:): Use CGFloat.
3754 (mouseDragged:): Remove unised variable edge.
3755 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
3756
3757 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
3758 of CGFloat differs.
3759 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
3760 when NS_IMPL_GNUSTEP.
3761 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
3762 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
3763 (EmacsToolbar): Add clearAll. Add tag argument to
3764 addDisplayItemWithImage.
3765 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
3766
3767 * nsselect.m (ns_get_local_selection): Remove unused variable type.
3768
3769 * nsmenu.m (ns_update_menubar): Make static.
3770 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
3771 (fillWithWidgetValue:): Add cast to SEL for setAction.
3772 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
3773 (update_frame_tool_bar): Update code for GNUStep.
3774 (clearAll): New method.
3775 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 3776 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 3777 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
3778 call to insertItemWithItemIdentifier.
3779 (validateVisibleItems): Fix indentation.
3780 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
3781 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
3782 UtilityWindow to aStyle, remove call to setStyleMask.
3783
3784 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
3785
3786 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
3787 (ns_charset_covers, ns_get_covering_families, nsfont_open):
3788 Use F suffix on floats.
3789 (ns_char_width): Returns CGFloat.
3790 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 3791 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
3792 DPSxshow.
3793 (ns_glyph_metrics): CGFloat instead of float.
3794
a0eb10b3
JB
3795 * nsfns.m (x_set_foreground_color, x_set_background_color):
3796 Use EmacsCGFloat.
3797 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
3798 remove unused variables.
3799 (Fns_read_file_name): Keep track if panel is for save.
3800 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 3801 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
3802 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
3803 Just return the input if GNUStep.
c0342369
JD
3804 (x_screen_planes): Remove.
3805 (Fxw_color_values): Use EmacsCGFloat
3806 (Fns_display_monitor_attributes_list): Only get screen number for
3807 Cocoa.
ef099a94 3808 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
3809 EmacsSavePanel.
3810 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
3811 ns_directory_from_panel.
3812
da9aff11
PE
38132013-06-01 Paul Eggert <eggert@cs.ucla.edu>
3814
3815 * process.c (handle_child_signal): Also use WCONTINUED.
3816 This is so that list-processes doesn't mistakenly list the process
3817 as stopped, when the process has actually been continued and is
3818 now running.
3819
0e64479a
PE
38202013-05-31 Paul Eggert <eggert@cs.ucla.edu>
3821
fc186a96
PE
3822 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
3823 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
3824 not already configured.
3825
0e64479a
PE
3826 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
3827
38b787fa
EZ
38282013-05-29 Eli Zaretskii <eliz@gnu.org>
3829
3830 * Makefile.in (mostlyclean): Remove *.res files.
3831
22513e52
SM
38322013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
3833
3834 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
3835 a buffer (bug#8447).
3836
6ef3db10
EZ
38372013-05-27 Eli Zaretskii <eliz@gnu.org>
3838
3839 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
3840 display vector, and we backtrack, handle the case that the
3841 previous character position is also displayed from a display
3842 vector or covered by a display string or image. (Bug#14476)
3843
6799bb26
JD
38442013-05-25 Jan Djärv <jan.h.d@swipnet.se>
3845
3846 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3847 (struct MonitorInfo, free_monitors): Remove.
3848 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
3849 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
3850 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3851 Qframes, Qsource.
3852
3853 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3854 (struct MonitorInfo, free_monitors): Remove.
3855 (ns_screen_name): Make static.
3856 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
3857 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3858 Qframes, Qsource.
3859
3860 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3861 (struct MonitorInfo): New struct.
3862 (free_monitors, make_monitor_attribute_list): Declare.
3863
22513e52
SM
3864 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
3865 New Lisp_Object:s.
6799bb26
JD
3866 (free_monitors, make_monitor_attribute_list): New functions.
3867 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
3868 Qsource.
3869
38cd43eb
XF
38702013-05-25 Xue Fuqiao <xfq.free@gmail.com>
3871
3872 * callproc.c (call_process): Refine the doc string. (Bug#14045)
3873
2af0948d
SM
38742013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
3875
a7eb9b0f
SM
3876 * keyboard.c: Apply keyboard decoding only to events that come directly
3877 from the tty, not from unread-command-events (bug#14368).
3878 (read_event_from_main_queue): New function, extracted from read_char).
3879 (read_decoded_char): Remove.
3880 (read_decoded_event_from_main_queue): New function to replace it.
3881 (read_char): Use it.
3882 (read_key_sequence): Use read_char rather than read_decoded_char.
3883
2af0948d
SM
3884 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
3885
1413e9a5
BR
38862013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
3887
3888 * casetab.c (init_casetab_once): Fix last change (bug#14424).
3889
e6d2f155
KH
38902013-05-22 Kenichi Handa <handa@gnu.org>
3891
3892 The following changes are to fix the setting of
3893 buffer-file-coding-system on, for instance, C-x RET c unix RET
3894 _FILE_OF_DOS_EOL_TYPE_ RET.
3895
3896 * coding.h (struct coding_system): New member detected_utf8_chars.
3897
3898 * coding.c (detect_coding_utf_8): Count characters and check EOL
3899 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
3900 BOM is there.
3901 (setup_coding_system): Do not initialize coding->head_ascii.
3902 (check_ascii): Do not set coding->eol_seen but update it. Do not
3903 call adjust_coding_eol_type here.
1413e9a5
BR
3904 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
3905 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
3906 of the found coding-system.
3907 (decode_coding_gap): Cancel previous change. Utilize the
3908 character numbers counted by detect_coding_utf_8. Fix detection
3909 of BOM for utf-8.
3910
ab56a6f4 39112013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
3912
3913 * search.c (looking_at_1): Only set last_thing_searched if the match
3914 changed the match-data (bug#14281).
3915
ecc3c6ed
DA
39162013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
3917
3918 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 3919 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
3920 (move_it_vertically_backward): Likewise.
3921
5ba8bf35
YM
39222013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3923
3924 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 3925 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
3926 (Fx_display_mm_width, Fx_display_mm_height):
3927 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 3928
91e8418b 3929 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 3930 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
3931 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
3932 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
3933 (Fx_display_backing_store, Fx_display_visual_class)
3934 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
3935 (Fx_display_grayscale_p, Fx_display_pixel_width)
3936 (Fx_display_pixel_height, Fx_display_planes)
3937 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
3938 (Fx_display_screens): Don't confuse X11 screens with NS screens.
3939 (Fx_display_mm_width, Fx_display_mm_height)
3940 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
3941 height for all physical monitors as in X11.
3942
fc30d803
SM
3943 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
3944 Return pixel width or height for all physical monitors as in X11.
91e8418b 3945
31ff141c
PE
39462013-05-18 Paul Eggert <eggert@cs.ucla.edu>
3947
3948 Port --enable-gcc-warnings to clang.
3949 * bytecode.c (exec_byte_code):
3950 * regex.c:
3951 Redo diagnostic pragmas to pacify clang, too.
3952 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
3953 * editfns.c (Fencode_time):
3954 * fileio.c (file_accessible_directory_p):
3955 * font.c (font_unparse_xlfd):
3956 Use '&"string"[index]' instead of '"string" + (index)'.
3957 * undo.c (user_error): Remove; unused.
3958
df065a0b
EZ
39592013-05-16 Eli Zaretskii <eliz@gnu.org>
3960
04d360e7
EZ
3961 * insdel.c (insert_1_both): Document the arguments, instead of
3962 referring to insert_1, which no longer exists.
3963
5bb98290
EZ
3964 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
3965 some window, increment windows_or_buffers_changed, so that
3966 *Messages* display in that window is updated. (Bug#14408)
3967
df065a0b
EZ
3968 * w32.c: Include epaths.h.
3969 (init_environment): Use cmdproxy.exe without leading directories.
3970 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
3971 case.
3972 (gettimeofday): Adjust signature and return value to Posix
3973 expectations.
3974
3975 * unexw32.c (open_output_file): Delete the existing emacs.exe
3976 before creating it, to break the hard link to the versioned
3977 executable.
3978
3979 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
3980 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
3981 (FIRSTFILE_OBJ): New variables.
3982 (W32_RES): Rename to EMACSRES. All users changed.
3983 (base_obj): Use $(CM_OBJ).
3984 (ALLOBJS): Use $(FIRSTFILE_OBJ).
3985 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
3986 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
3987 $(W32_RES_LINK) before $(LIBES).
3988 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
3989
1aa8d505
SM
39902013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3991
6e911150
SM
3992 * makefile.w32-in (DOC): Use just "DOC".
3993
3994 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
3995
1aa8d505
SM
3996 * process.c: Export default filters and sentinels to Elisp.
3997 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
3998 New constants.
3999 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
4000 (Fset_process_sentinel, Fformat_network_address):
4001 Default to them instead of nil.
4002 (server_accept_connection): Sentinels can't be nil any more.
4003 (read_and_dispose_of_process_output): New function, extracted from
4004 read_process_output.
4005 (read_process_output): Use it; filters can't be nil.
4006 (Finternal_default_process_filter): New function, extracted from
4007 read_process_output.
4008 (exec_sentinel_unwind): Remove function.
4009 (exec_sentinel): Don't zilch sentinel while running.
4010 (status_notify): Sentinels can't be nil.
4011 (Finternal_default_process_sentinel): New function extracted from
4012 status_notify.
4013 (setup_process_coding_systems): Default filter is not nil any more.
4014 (syms_of_process): Export new Elisp functions and initialize
4015 new constants.
4016 * lisp.h (make_lisp_proc): New function.
4017
5ac2eb34
SM
40182013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4019
4020 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
4021
eda9c7d7
EZ
40222013-05-14 Eli Zaretskii <eliz@gnu.org>
4023
4024 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
4025 unless we know that the window w is a leaf window.
4026 Another attempt at solving bug#14062.
eda9c7d7 4027
8fdeaad5
JD
40282013-05-14 Jan Djärv <jan.h.d@swipnet.se>
4029
4030 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
4031 fdesc (Bug#14375).
4032
44aa9ee6
PE
40332013-05-12 Paul Eggert <eggert@cs.ucla.edu>
4034
4035 * image.c (gif_load): Check that subimages fit (Bug#14345).
4036
759fd763
SM
40372013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
4038
4039 * lread.c (skip_dyn_eof): New function.
4040 (read1): Use it to skip the end of a file in response to #@00.
4041
4042 * doc.c (get_doc_string): Slightly relax the sanity checking.
4043
4465bfb4
JD
40442013-05-09 Jan Djärv <jan.h.d@swipnet.se>
4045
4046 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
4047 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
4048 (MonitorInfo): New struct.
4049 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
4050 (Fns_display_monitor_attributes_list): New functions.
4051 (display-usable-bounds): Remove.
4052 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
4053 Qsource.
4054
7583e2a0
PE
40552013-05-09 Paul Eggert <eggert@cs.ucla.edu>
4056
4057 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
4058 (GTK_CHECK_VERSION): New macro, if not already defined.
4059 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
4060 replaced by GTK_CHECK_VERSION.
4061
ad75d77e
PE
40622013-05-08 Paul Eggert <eggert@cs.ucla.edu>
4063
4064 * xterm.h (GTK_PREREQ): New macro.
4065 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
4066 to use this macro instead, for consistency and clarity.
4067
07525f77
EZ
40682013-05-08 Eli Zaretskii <eliz@gnu.org>
4069
4070 * xdisp.c (row_for_charpos_p): New function, with code of
4071 cursor_row_p, but accepts an additional argument CHARPOS instead
4072 of using a hardcoded PT.
4073 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
4074 (row_containing_pos): Call row_for_charpos_p instead of partially
4075 doing the same. Fixes cursor positioning under longlines-mode
4076 when longlines-show-effect includes more than one newline, when
4077 moving the cursor vertically up.
4078
d901fc8d
JB
40792013-05-08 Juanma Barranquero <lekktu@gmail.com>
4080
4081 * makefile.w32-in (ACL_H): New macro.
4082 ($(BLD)/fileio.$(O)): Update dependencies.
4083
f269bc61
PE
40842013-05-07 Paul Eggert <eggert@cs.ucla.edu>
4085
e7b41c4c 4086 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
4087 * Makefile.in (LIB_ACL): New macro.
4088 (LIBACL_LIBS): Remove.
4089 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
4090 * fileio.c: Include <acl.h>.
4091 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
4092 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
4093 !acl_errno_valid.
4094 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
4095 it ourselves.
4096
f269bc61
PE
4097 * unexelf.c: Don't assume ElfW (Half) fits in int.
4098 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
4099 when dealing with ElfW (Half) values, since they can exceed 2**31
4100 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
4101 (entry_address): Omit unused NUM arg. All uses changed.
4102
a261c53e
JL
41032013-05-07 Juri Linkov <juri@jurta.org>
4104
4105 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
4106 to the string converted from number with `Fnumber_to_string'.
4107 (Bug#14254)
4108
2b66427d
PE
41092013-05-07 Paul Eggert <eggert@cs.ucla.edu>
4110
4111 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
4112 This fixes a problem introduced by my previous change.
4113
15acfe41
GM
41142013-05-07 Glenn Morris <rgm@gnu.org>
4115
4116 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
4117
5ea03bf5
JD
41182013-05-07 Jan Djärv <jan.h.d@swipnet.se>
4119
4120 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
4121
e0c9d565
PE
41222013-05-07 Paul Eggert <eggert@cs.ucla.edu>
4123
4124 Static checking by GCC 4.8.0.
4125 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
4126 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
4127 (x_get_monitor_attributes_fallback)
4128 (x_get_monitor_attributes_xinerama)
4129 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
4130 Define only if USE_GTK.
4131 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
4132 (x_get_monitor_attributes_fallback): Omit unused locals.
4133 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
4134 Use double, not float, to avoid mixed-mode floating point arithmetic.
4135
4e3f9230
YM
41362013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4137 Jan Djärv <jan.h.d@swipnet.se>
4138
4139 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
4140 (XINERAMA_CFLAGS): New macros.
4141 (ALL_CFLAGS, LIBES): Use them.
4142
4143 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
4144 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
4145 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
4146 (syms_of_xfns): DEFSYM them.
4147 (struct MonitorInfo): New struct.
4148 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
4149 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
4150 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
4151 (x_get_monitor_attributes_xinerama): New functions.
4152 (Fx_display_monitor_attributes_list): New primitive.
4153 (syms_of_xfns): Defsubr it.
4154
4155 * xterm.h (x_display_info): Add Xatom_net_workarea and
4156 Xatom_net_current_desktop.
4157
4158 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
4159 and dpyinfo->Xatom_net_current_desktop.
4160
05839b6a
EZ
41612013-05-06 Eli Zaretskii <eliz@gnu.org>
4162
4163 * xdisp.c (pos_visible_p): Use the special code for finding the
4164 beginning of a display property or overlay for any "replacing"
4165 display property, not just for display strings. This solves
4166 incorrect reporting of position by posn-at-point. (Bug#14241)
4167
dc4a2ee0
PE
41682013-05-06 Paul Eggert <eggert@cs.ucla.edu>
4169
5ee94506
PE
4170 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
4171 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
4172 Verify that ElfW (Half) fits in int.
4173 (fatal): Use same signature as lisp.h.
4174 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
4175 configure and build with -DUNEXELF_DEBUG without worrying about
4176 other modules that use DEBUG.
4177 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
4178 possibly-wide integers now uses it instead of plain fprintf.
4179 (entry_address): New function, which avoids problems with 32-bit
4180 overflow on 64-bit hosts.
4181 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
4182 (round_up): Don't assume the remainder fits in int.
4183 (find_section): Use bool for boolean. Simplify debug code.
4184 (unexec): Don't assume file sizes fit in int or size_t.
4185 Omit unnecessary trailing newline in 'fatal' format.
4186 Use strerror rather than outputting decimal error number.
4187 Remove unused code when emacs is not defined;
4188 this file relies on Emacs now.
4189 Don't assume e_phnum and e_shnum are positive.
4190
dc4a2ee0
PE
4191 * regex.c: Fix problems when DEBUG is defined.
4192 (extract_number, extract_number_and_incr): Define regardless of
4193 whether DEBUG is defined; that's simpler and makes the code less
4194 likely to go stale in the normal case when DEBUG is not defined.
4195 Return int rather than taking an int * arg. All callers changed.
4196 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
4197 Remove, replacing with ...
4198 (DEBUG_PRINT): New macro. All callers changed.
4199 (DEBUG_COMPILES_ARGUMENTS): New macro.
4200 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
4201 (print_compiled_pattern, print_double_string) [DEBUG]:
4202 Use prototype rather than old-style definition.
4203 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
4204 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
4205 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
4206 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
4207 Don't assume ptrdiff_t, size_t, and long are the same width as int.
4208 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
4209 This matters only when DEBUG is defined.
4210
14c7ed05
EZ
42112013-05-05 Eli Zaretskii <eliz@gnu.org>
4212
4213 * xdisp.c (set_iterator_to_next): Set the
4214 ignore_overlay_strings_at_pos_p flag only if we are _really_
4215 iterating over an overlay string, as indicated by the
4216 current.overlay_string_index member. (Bug#14306)
4217
e6076b1b
JD
42182013-05-05 Jan Djärv <jan.h.d@swipnet.se>
4219
4220 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
4221 to where it is used, to avoid autorelease issues (Bug#14050).
4222
cbee2131
PE
42232013-05-05 Paul Eggert <eggert@cs.ucla.edu>
4224
4225 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
4226 * fileio.c (syms_of_fileio): Implement this.
4227 * filelock.c (create_lock_file): If symbolic links don't work, so
4228 we use a regular file as a lock file, do not fsync the lock file;
4229 it's not needed.
4230
30c7e542
SM
42312013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4232
4233 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
4234 (syms_of_minibuf): Adjust accodingly.
4235 * lread.c (Fread):
4236 * callint.c (Fcall_interactively): Adjust calls accordingly.
4237
5bebd186
EZ
42382013-05-04 Eli Zaretskii <eliz@gnu.org>
4239
4240 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
4241 w->contents is a buffer before computing everything else.
4242 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
4243
4244 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
4245 assertion violations. (Bug#14062)
4246
0fb0a4f3
DR
42472013-05-01 David Reitter <david.reitter@gmail.com>
4248
4249 * nsfns.m (ns_tooltip): Initialize.
4250
9e63b4a5
EZ
42512013-04-28 Eli Zaretskii <eliz@gnu.org>
4252
4253 * coding.c (decode_coding_gap): Don't remove the character before
4254 a newline unless it's a CR character. (Bug#14287)
4255
ad60824e
DN
42562013-04-28 Dan Nicolaescu <dann@gnu.org>
4257
4258 * dispextern.h (struct face): Move enum face_underline_type
4259 earlier so that bitfields can be in the same word.
4260
edbdcec0
JD
42612013-04-28 Jan Djärv <jan.h.d@swipnet.se>
4262
4263 * nsfns.m (handlePanelKeys): New function.
4264 (EmacsOpenPanel:performKeyEquivalent:)
4265 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
4266 arrows/function/control and copy/paste keys (Bug#14296).
4267
0208ede7
JL
42682013-04-27 Juri Linkov <juri@jurta.org>
4269
4270 * callint.c (Fcall_interactively): Call `Qread_number' for
4271 interactive code letter `n' instead of using duplicate code.
4272 (Bug#14254)
4273
b8dd59f7
PE
42742013-04-27 Paul Eggert <eggert@cs.ucla.edu>
4275
4276 * systime.h (make_timeval): Declare as 'const'.
4277
8bd722db
KH
42782013-04-27 Kenichi Handa <handa@gnu.org>
4279
4280 * font.c (font_open_entity): Always open a font of manageable
4281 size.
4282
13d0e56f 42832013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 4284
f780d632
PE
4285 Port better to AIX (Bug#14258).
4286 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
4287 to pacify AIX xlc.
4288
ec509856
KH
42892013-04-24 Kenichi Handa <handa@gnu.org>
4290
4291 * coding.c (decode_coding_iso_2022): When an invalid escape
4292 sequence is encountered, reset the invocation and designation
4293 status to the safest one.
4294
84fc48e5
PE
42952013-04-22 Paul Eggert <eggert@cs.ucla.edu>
4296
4297 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
4298 Without this fix, "make distclean" leaves stamp-h1 behind.
4299
806bda47
EC
43002013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
4301
4302 * w32fns.c (w32_fullscreen_rect): New function to compute the
4303 window rectangle for the given fullscreen mode.
4304 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
4305 longer tunes the window size. This keeps the window's edges flush
4306 with the screen and allows the taskbar to hide itself in fullboth.
4307
4308 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
4309 window decorations and uses the entire screen.
4310
4311 * w32term.h (w32_fullscreen_rect) Add prototype.
4312 (struct w32_output): Replace normal_width, normal_height,
4313 normal_top, and normal_left members with a single normal_placement
4314 struct.
4315 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
4316 Remove macros.
4317 (FRAME_NORMAL_PLACEMENT): New macro.
4318
9cc2810b
JB
43192013-04-16 Juanma Barranquero <lekktu@gmail.com>
4320
4321 * minibuf.c (Ftest_completion): Silence compiler warning.
4322
fd16b54c
EZ
43232013-04-15 Eli Zaretskii <eliz@gnu.org>
4324
4325 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 4326 bug#14062.
fd16b54c
EZ
4327
4328 * frame.h (WINDOW_FRAME): Protect macro and its argument with
4329 parentheses.
4330
4331 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
4332 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
4333 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
4334 parentheses where appropriate.
4335
9e3379a0
PE
43362013-04-14 Paul Eggert <eggert@cs.ucla.edu>
4337
4338 * keyboard.c (timer_start_idle): Remove no-longer-used local.
4339
ddd6b685
EZ
43402013-04-14 Eli Zaretskii <eliz@gnu.org>
4341
4342 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
4343 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
4344 Mention in the doc string that setting these variables takes
4345 effect only after a call to set-window-buffer. (Bug#14200)
4346
29b79ba1
EZ
43472013-04-13 Eli Zaretskii <eliz@gnu.org>
4348
4349 * indent.c (Fvertical_motion): Don't consider display strings on
4350 overlay strings as display strings on the buffer position we
4351 started from. This prevents vertical cursor motion from jumping
4352 more than one line when there's an overlay string with a display
4353 property at end of line.
4354 Reported by Karl Chen <Karl.Chen@quarl.org> in
4355 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
4356
562c6ee9
SM
43572013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
4358
4359 * window.c (select_window): `record_buffer' even if window is
4360 already selected (bug#14191).
4361
fcc1fe85
EZ
43622013-04-11 Eli Zaretskii <eliz@gnu.org>
4363
4364 * window.c (Fwindow_end): Test more flags, including the buffer's
4365 last_overlay_modified flag, to determine whether the window's
4366 display is really up-to-date. Prevents the function from
4367 returning a stale value. (Bug#14170)
4368 (Fwindow_line_height): Fix the test for up-to-date-ness of the
4369 current matrix.
4370
f009190a
EZ
43712013-04-10 Eli Zaretskii <eliz@gnu.org>
4372
4373 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
4374 garbaged only if it is not already the top frame on its TTY.
4375 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
4376 there are GUI frames open in the same session. (Bug#13864)
4377
78ce603d
SM
43782013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
4379
4380 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
4381 of marking the idle timers directly.
4382
a8036e40
SM
43832013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
4384
4385 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
4386 tables (bug#14054).
4387
7ffe7ef6
SM
43882013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
4389
4390 * window.c (select_window): Don't record_buffer while the invariant is
4391 temporarily broken (bug#14161).
4392
4393 * fns.c (Fdelq): Don't assume !NILP => CONSP.
4394
7d9f6883
EZ
43952013-04-07 Eli Zaretskii <eliz@gnu.org>
4396
4397 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
4398
5406cfd9
RF
43992013-04-07 Romain Francoise <romain@orebokech.com>
4400
4401 Ignore additional platform-specific ACL errors (Bug#13702).
4402 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
4403 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
4404
95c0e83b
JD
44052013-03-31 Jan Djärv <jan.h.d@swipnet.se>
4406
4407 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
4408 f->output_data.ns.
4409
876da980
PE
44102013-04-07 Paul Eggert <eggert@cs.ucla.edu>
4411
4412 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
4413 This bug was introduced by my 2013-02-25 change that simplified
4414 data_start configuration. Without this change, on GNU/Linux
4415 an Emacs configured with --enable-profiling fails immediately
4416 due to a profiler signal.
4417 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
4418 with these flags. On platforms where special flags are needed
4419 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
4420 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
4421 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
4422
7452b7bd
DA
44232013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
4424
4425 Get rid of some platform-specific functions examining window
4426 system and its capabilities. This is a partial rework of the
4427 2013-04-05 change.
4428 * lisp.h (have_menus_p): Remove prototype. This function is
4429 replaced with platform-independent window_system_available.
4430 (check_window_system): Move to...
4431 * frame.h (decode_window_system_frame, window_system_available):
4432 ...here, add new prototypes.
4433 * frame.c (window_system_available, decode_window_system_frame):
4434 New functions.
4435 (check_window_system): Platform-independent now.
4436 * xterm.h (x_in_use): Remove declaration.
4437 (check_x_frame):
4438 * w32term.h (check_x_frame):
4439 * nsterm.h (check_x_frame): Remove prototypes. This function
4440 is replaced with platform-independent decode_window_system_frame.
4441 * msdos.c (have_menus_p): Remove.
4442 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
4443 Remove platform-specific functions. Use check_window_system,
4444 decode_window_system_frame and check_ns_display_info where
4445 appropriate. Minor style and comment tweaks.
4446 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
4447 (check_x_frame): Likewise.
4448 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
4449 Likewise.
4450 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
4451 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
4452 * xmenu.c, xselect.c: All related users changed.
4453
251e9147
KH
44542013-04-03 Kenichi Handa <handa@gnu.org>
4455
4456 The following changes is to optimize the code for reading UTF-8
4457 files.
4458
562c6ee9 4459 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
4460 changed. Check EOL format. Do not call adjust_coding_eol_type
4461 here.
4462 (check_utf_8): New function.
4463 (adjust_coding_eol_type): Do nothing if already adjusted.
4464 (detect_coding): Compare the return value of check_ascii with
4465 coding->src_bytes. Call adjust_coding_eol_type if necessary.
4466 (decode_coding_gap): Optimize for valid UTF-8.
4467
8bc369d4
KH
44682013-03-21 Kenichi Handa <handa@gnu.org>
4469
4470 * coding.c (syms_of_coding): Cancel previous change.
4471
4472 * insdel.c (insert_from_gap): Fix previous change.
4473
73931ad1
DA
44742013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
4475
4476 Consistently use platform-specific function to detect window system.
4477 * lisp.h (check_window_system): New prototype. This function is
4478 going to replace check_x, check_w32 and check_ns.
4479 (have_menus_p): Mention msdos.c in comment.
4480 * fontset.c (check_window_system_func): Remove. Adjust all users.
4481 * fontset.h (check_window_system_func): Remove prototype.
4482 * nsterm.h (check_ns):
4483 * xterm.h (check_x):
4484 * w32term.h (check_w32): Likewise.
4485 * menu.c (Fx_popup_menu): Use check_window_system.
4486 * msdos.c (check_window_system): Define for MS-DOS.
4487 * nsfns.m (check_window_system): Define for NS. Adjust all users.
4488 * w32fns.c (check_window_system): Likewise for MS-Windows.
4489 * xfns.c (check_window_system): Likewise for X.
4490 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
4491 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
4492
7216e43b
PE
44932013-04-02 Paul Eggert <eggert@cs.ucla.edu>
4494
4495 Prefer < to > in range checks such as 0 <= i && i < N.
4496 This makes it easier to visualize quantities on a number line.
4497 This patch doesn't apply to all such range checks,
4498 only to the range checks affected by the 2013-03-24 change.
4499 This patch reverts most of the 2013-03-24 change.
4500 * alloc.c (xpalloc, Fgarbage_collect):
4501 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
4502 * character.c (string_escape_byte8):
4503 * charset.c (read_hex):
4504 * data.c (cons_to_unsigned):
4505 * dispnew.c (update_frame_1):
4506 * doc.c (Fsubstitute_command_keys):
4507 * doprnt.c (doprnt):
4508 * editfns.c (hi_time, decode_time_components):
4509 * fileio.c (file_offset):
4510 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
4511 * font.c (font_intern_prop):
4512 * frame.c (x_set_alpha):
4513 * gtkutil.c (get_utf8_string):
4514 * indent.c (check_display_width):
4515 * keymap.c (Fkey_description):
4516 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
4517 * lread.c (read1):
4518 * minibuf.c (read_minibuf_noninteractive):
4519 * process.c (wait_reading_process_output):
4520 * search.c (Freplace_match):
4521 * window.c (get_phys_cursor_glyph):
4522 * xdisp.c (redisplay_internal):
4523 * xsmfns.c (smc_save_yourself_CB):
4524 Prefer < to > for range checks.
4525 * dispnew.c (sit_for): Don't mishandle NaNs.
4526 This fixes a bug introduced in the 2013-03-24 change.
4527 * editfns.c (decode_time_components): Don't hoist comparison.
4528 This fixes another bug introduced in the 2013-03-24 change.
4529
92759988
DA
45302013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
4531
4532 * frame.h (struct frame): Drop scroll_bottom_vpos
4533 member becaue all real users are dead long ago.
4534 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
4535 * xdisp.c (redisplay_internal): Adjust user.
4536
9a1971bb
GM
45372013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
4538
f38ab167
JD
4539 * nsmenu.m (showAtX:Y:for:): setLevel to
4540 NSPopUpMenuWindowLevel (Bug#13998).
4541
6d01f1fe
JD
45422013-03-30 Jan Djärv <jan.h.d@swipnet.se>
4543
4544 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
4545 (ns_check_pending_open_menu): Declare.
4546
4547 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
4548 (x_activate_menubar): Update the menu with title that matches
4549 ns_get_pending_menu_title, and call
4550 ns_check_pending_openmenu (Bug#12698).
4551 (menuWillOpen:): New method.
4552 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
4553
4554 * nsterm.m (menu_will_open_state, menu_mouse_point)
4555 (menu_pending_title): New varaibles.
4556 (ns_get_pending_menu_title, ns_check_menu_open)
4557 (ns_check_pending_open_menu): New functions.
4558
781f4782
DA
45592013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
4560
4561 * indent.c (current_column_bol_cache): Remove leftover which is not
4562 used in Fmove_to_column any more.
4563 (current_column, scan_for_column): Adjust users.
4564 * keyboard.c (last_point_position_buffer, last_point_position_window):
4565 Remove leftovers which are not used for recording undo any more.
4566 (command_loop_1, syms_of_keyboard): Adjust users.
4567 * xdisp.c (last_max_ascent): Remove leftover which is not used in
4568 redisplay_window any more.
4569 (move_it_to): Adjust user.
4570
1921c31b
JB
45712013-03-29 Juanma Barranquero <lekktu@gmail.com>
4572
4573 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
4574 Update dependencies.
4575
717b8bcd
SM
45762013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4577
4578 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
4579 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
4580 forward references.
4581
e74aeda8
DA
45822013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
4583
4584 * window.h (struct window): Replace hchild, vchild and buffer slots
4585 with the only contents slot. This is possible because each valid
4586 window may have either the child window (in vertical or horizontal
4587 combination) or buffer to display (for the leaf window). Using that,
4588 a lof of operations to traverse and/or change window hierarchies may
4589 be simplified. New member horizontal is used to distinguish between
4590 horizontal and vertical combinations of internal windows.
4591 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
4592 (WINDOW_VERTICAL_COMBINATION_P): New macros.
4593 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
4594 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
4595 Use contents slot, not buffer, where appropriate.
4596 (wset_combination): New function.
4597 (wset_buffer): Add eassert.
4598 (Fframe_first_window): Simplify the loop reaching first window.
4599 (Fwindow_buffer): Use WINDOW_LEAF_P.
4600 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
4601 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
4602 (unshow_buffer): Convert initial debugging check to eassert.
4603 (replace_window, recombine_windows, Fdelete_other_windows_internal)
4604 (make_parent_window, window_resize_check, window_resize_apply)
4605 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
4606 (Fset_window_configuration, delete_all_child_windows, save_window_save):
4607 Adjust to match struct window changes.
4608 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
4609 (mark_window_cursors_off, count_windows, get_leaf_windows)
4610 (foreach_window_1): Simplify the loop.
4611 * alloc.c (mark_object): Do not check for the leaf window because
4612 internal windows has no glyph matrices anyway.
4613 * dispnew.c (clear_window_matrices, showing_window_margins_p)
4614 (allocate_matrices_for_window_redisplay, fake_current_matrices)
4615 (allocate_matrices_for_frame_redisplay, free_window_matrices)
4616 (build_frame_matrix_from_window_tree, mirror_make_current)
4617 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
4618 (update_window_tree, set_window_update_flags): Simplify the loop.
4619 (sync_window_with_frame_matrix_rows): Enforce live window.
4620 Use contents slot, not buffer, where appropriate.
4621 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
4622 and WINDOW_HORIZONTAL_COMBINATION_P.
4623 (make_frame_visible_1): Simplify the loop.
4624 Use contents slot, not buffer, where appropriate.
4625 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
4626 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
4627 (expose_window_tree): Likewise.
4628 Use contents slot, not buffer, where appropriate.
4629 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
4630 to avoid deleted windows. Use contents slot instead of buffer.
4631 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
4632 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
4633 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
4634 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
4635
121ab1cd
EZ
46362013-03-28 Eli Zaretskii <eliz@gnu.org>
4637
ef454cf7
EZ
4638 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
4639 identify the reasons for assertion violations in bug#14062 and
4640 similar ones.
21e930f8
EZ
4641 (Fx_show_tip): Fix compilation error under
4642 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 4643
121ab1cd
EZ
4644 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
4645 Reported by <rzl24ozi@gmail.com>.
4646
5c89ca24
DA
46472013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
4648
4649 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
4650 start marker...
562c6ee9
SM
4651 (unwind_with_echo_area_buffer): ...to restore it here.
4652 This is needed to ensure that...
5c89ca24
DA
4653 (redisplay_window): ...both window markers are valid here,
4654 which is verified by eassert.
4655 * editfns.c (save_excursion_save): Do not assume that
4656 selected_window always displays the buffer.
c7f53895
DA
4657 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
4658 Fix comment.
5c89ca24 4659
f557c1b1
SM
46602013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
4661
4662 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
4663 the upcase table.
4664
40693bba 46652013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
4666
4667 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
4668
c86f791f
EZ
46692013-03-27 Eli Zaretskii <eliz@gnu.org>
4670
4671 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
4672 since MinGW's w32api headers do. This avoids compiler warnings.
4673
4674 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
4675 if already defined.
4676
c6e72e17
EZ
46772013-03-26 Eli Zaretskii <eliz@gnu.org>
4678
4679 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
4680
54e95010
JD
46812013-03-26 Jan Djärv <jan.h.d@swipnet.se>
4682
4683 * gtkutil.c (style_changed_cb): Check if frame is live and an
4684 X frame (Bug#14038).
4685
b88b62de
EZ
46862013-03-26 Eli Zaretskii <eliz@gnu.org>
4687
a18d7de6
EZ
4688 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
4689 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
4690 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
4691 MinGW64.
8f5e14c8
EZ
4692 Move inclusion of time.h before sys/time.h, so that MinGW64 could
4693 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 4694
b88b62de
EZ
4695 Fix incompatibilities between MinGW.org and MinGW64 headers.
4696 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
4697
4698 * w32.c (REPARSE_DATA_BUFFER): Guard with
4699 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
4700
c074e458
JD
47012013-03-25 Jan Djärv <jan.h.d@swipnet.se>
4702
4703 * xterm.c: Include X11/XKBlib.h
4704 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
4705
908589fd
AS
47062013-03-24 Andreas Schwab <schwab@linux-m68k.org>
4707
4708 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
4709 written backwards.
4710 * blockinput.h (input_blocked_p): Likewise.
4711 * bytecode.c (exec_byte_code): Likewise.
4712 * callproc.c (call_process_kill, call_process_cleanup)
4713 (Fcall_process): Likewise.
4714 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
4715 (Fccl_execute_on_string): Likewise.
4716 * character.c (string_escape_byte8): Likewise.
4717 * charset.c (read_hex): Likewise.
4718 * cm.c (calccost): Likewise.
4719 * data.c (cons_to_unsigned): Likewise.
4720 * dired.c (directory_files_internal, file_name_completion):
4721 Likewise.
4722 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
4723 (sit_for): Likewise.
4724 * doc.c (Fsubstitute_command_keys): Likewise.
4725 * doprnt.c (doprnt): Likewise.
4726 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
4727 * emacsgtkfixed.c: Likewise.
4728 * fileio.c (file_offset, Fwrite_region): Likewise.
4729 * floatfns.c (Fexpt, fmod_float): Likewise.
4730 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
4731 Likewise.
4732 * font.c (font_intern_prop): Likewise.
4733 * frame.c (x_set_alpha): Likewise.
4734 * gtkutil.c (get_utf8_string): Likewise.
4735 * indent.c (check_display_width): Likewise.
4736 * intervals.c (create_root_interval, rotate_right, rotate_left)
4737 (split_interval_right, split_interval_left)
4738 (adjust_intervals_for_insertion, delete_node)
4739 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4740 (merge_interval_right, merge_interval_left, copy_intervals)
4741 (set_intervals_multibyte_1): Likewise.
4742 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
4743 * keymap.c (Fkey_description): Likewise.
4744 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
4745 * lread.c (openp, read_integer, read1, string_to_number):
4746 Likewise.
4747 * menu.c (ensure_menu_items): Likewise.
4748 * minibuf.c (read_minibuf_noninteractive): Likewise.
4749 * print.c (printchar, strout): Likewise.
4750 * process.c (create_process, Faccept_process_output)
4751 (wait_reading_process_output, read_process_output, send_process)
4752 (wait_reading_process_output): Likewise.
4753 * profiler.c (make_log, handle_profiler_signal): Likewise.
4754 * regex.c (re_exec): Likewise.
4755 * regex.h: Likewise.
4756 * search.c (looking_at_1, Freplace_match): Likewise.
4757 * sysdep.c (get_child_status, procfs_ttyname)
4758 (procfs_get_total_memory): Likewise.
4759 * systime.h (EMACS_TIME_VALID_P): Likewise.
4760 * term.c (dissociate_if_controlling_tty): Likewise.
4761 * window.c (get_phys_cursor_glyph): Likewise.
4762 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
4763 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
4764 Likewise.
4765 * xfns.c (Fx_window_property): Likewise.
4766 * xmenu.c (set_frame_menubar): Likewise.
4767 * xselect.c (x_get_window_property, x_handle_dnd_message):
4768 Likewise.
4769 * xsmfns.c (smc_save_yourself_CB): Likewise.
4770 * xterm.c (x_scroll_bar_set_handle): Likewise.
4771
2bf7d27a
DA
47722013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
4773
4774 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
4775 to be optional or nil. Adjust comment and convert it to docstring.
4776 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
4777 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
4778
a9ebfa0b
PE
47792013-03-24 Paul Eggert <eggert@cs.ucla.edu>
4780
4781 Static checking by GCC 4.8-20130319.
4782 * image.c (gif_load): Assume pass < 3 to pacify GCC.
4783 * process.c (Fset_process_datagram_address)
4784 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
4785 * xdisp.c (get_char_face_and_encoding):
4786 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
4787 (get_glyph_face_and_encoding): Prepare face before possibly using it.
4788 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
4789
4f3576ee
KB
47902013-03-24 Ken Brown <kbrown@cornell.edu>
4791
789b5e9a
KB
4792 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
4793 fix compilation on 64-bit Cygwin, where underscores are not
4794 automatically prepended.
4795
4f3576ee
KB
4796 * w32term.c (w32_initialize): Silence compiler warning.
4797
b5b7745f
EZ
47982013-03-23 Eli Zaretskii <eliz@gnu.org>
4799
cdc0d0bd
EZ
4800 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
4801 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
4802 variables, to save and restore frame dimensions.
4803 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
4804 after returning from a 'fullscreen' configuration.
4805 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
4806 to avoid races between the main thread and the input thread.
4807
4808 * w32term.h (struct w32_output): New members normal_width,
4809 normal_height, normal_top, normal_left, and prev_fsmode.
4810 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
4811 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
4812 members of a frame.
4813
b5b7745f
EZ
4814 * w32term.c (w32fullscreen_hook): Record last value of the frame's
4815 'fullscreen' parameter. Always record previous width and height
4816 of the frame, except when switching out of maximized modes, so
4817 that they could be restored correctly, instead of resetting to the
4818 default frame dimensions. Send SC_RESTORE command to the frame,
4819 unless we are going to send SC_MAXIMIZE, to restore the frame
4820 resize hints in the mouse pointer shown by the window manager.
4821 (Bug#14032)
4822
4823 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
4824
4825 * lisp.h (get_frame_param): Adjust conditions for prototype
4826 declaration.
4827
a3454eed
KB
48282013-03-22 Ken Brown <kbrown@cornell.edu>
4829
4830 * unexcw.c: Drop unneeded inclusion of w32common.h.
4831 (report_sheap_usage): Declare.
4832 (read_exe_header): Add magic numbers for x86_64.
4833 (fixup_executable): Fix printf format specifier for unsigned long
4834 argument.
4835
5a49b79c
DA
48362013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
4837
4838 * frame.h (struct frame): Put menu_bar_window under #ifdef
4839 because this member is not needed when X toolkit is in use.
4840 (fset_menu_bar_window):
4841 * dispnew.c (clear_current_matrices, clear_desired_matrices)
4842 (free_glyphs, update_frame):
4843 * xdisp.c (expose_frame): Likewise.
4844 (display_menu_bar): Likewise. Remove redundant eassert.
4845 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
4846 toolkit is in use.
4847
d6723bf7
PE
48482013-03-21 Paul Eggert <eggert@cs.ucla.edu>
4849
7b1123d8
PE
4850 Use functions and constants to manipulate Lisp_Save_Value objects.
4851 This replaces code that used macros and strings and token-pasting.
4852 The change makes the C source a bit easier to follow,
4853 and shrinks the Emacs executable a bit.
4854 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
4855 (make_save_value): Change 1st arg from string to enum. All callers
4856 changed.
4857 (INTX): Remove.
4858 (mark_object): Use if, not #if, for GC_MARK_STACK.
4859 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
4860 (XSAVE_OBJECT): Now functions, not macros.
4861 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
4862 the constant was never used.
4863 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
4864 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
4865 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
4866 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
4867 New constants.
4868 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
4869 type3 with a single member save_type. All uses changed.
4870 (save_type, set_save_pointer, set_save_integer): New functions.
4871 * print.c (PRINTX): Remove.
4872
d6723bf7
PE
4873 * alloc.c: Remove redundant static declarations.
4874
5f24fa51
DA
48752013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4876
4877 * window.h (struct window): Convert left_col, top_line, total_lines
4878 and total_cols from Lisp_Objects to integers. Adjust comments.
4879 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
4880 Remove.
4881 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
4882 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
4883 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
4884 Adjust users where appropriate.
4885
42143acd
DA
48862013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4887
4888 * frame.h (struct frame): Drop resx and resy because the same data is
4889 available from window system-specific output context. Adjust users.
562c6ee9
SM
4890 (default_pixels_per_inch_x, default_pixels_per_inch_y):
4891 New functions to provide defaults when no window system available.
42143acd 4892 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 4893 (NUMVAL): Move from xdisp.c.
42143acd
DA
4894 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
4895 (Ffont_face_attributes, Fopen_font):
4896 * image.c (gs_load):
4897 * w32font.c (fill_in_logfont):
4898 * xdisp.c (calc_pixel_width_or_height):
4899 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
4900 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
4901
c0a17406
KH
49022013-03-20 Kenichi Handa <handa@gnu.org>
4903
4904 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
4905 to 1 (temporary workaround until a bug related to ASCII
4906 optimization is fixed).
4907
095d384d
DA
49082013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
4909
4910 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
4911 Signal error if window is not internal. Adjust docstring.
4912 (delete_all_child_windows): Use combination_limit to save the buffer.
4913 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
4914 * print.c (syms_of_print): Initialize debugging output not here...
4915 (init_print_once): ...but in a new function here.
4916 * lisp.h (init_print_once): Add prototype.
4917 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 4918
748fa866
DA
49192013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
4920
4921 * window.c (window_resize_check, window_resize_apply)
4922 (window_from_coordinates, recombine_windows, set_window_buffer)
4923 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
4924 (Fsplit_window_internal, Fdelete_window_internal)
4925 (freeze_window_starts): Use bool for booleans.
4926 * window.h (window_frame_coordinates, resize_frame_windows)
4927 (freeze_window_starts, set_window_buffer): Adjust prototypes.
4928
81519fd2
SM
49292013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
4930
4931 * dispnew.c (bitch_at_user): Use `user-error'.
4932
6db423a9
KB
49332013-03-17 Ken Brown <kbrown@cornell.edu>
4934
4935 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
4936 as return type of image_background. (Bug#13981)
4937 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
4938
8f2906f5
JD
49392013-03-16 Jan Djärv <jan.h.d@swipnet.se>
4940
960ce480 4941 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 4942 (ns_select): Don't return with result uninitialized.
960ce480 4943
8f2906f5
JD
4944 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
4945 and getDirectory.
4946
81519fd2
SM
4947 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
4948 New functions.
8f2906f5
JD
4949 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
4950 directories. If filename is nil, get directory name (Bug#13932).
4951 Use getFilename and getDirectory.
4952 (getFilename, getDirectory): New methods for EmacsSavePanel and
4953 EmacsOpenPanel.
4954 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
4955
cded56c1
PE
49562013-03-15 Paul Eggert <eggert@cs.ucla.edu>
4957
4958 * coding.c (decode_coding_gap): Fix typo caught by static checking.
4959
251e9147 49602013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
4961
4962 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
4963 (adjust_after_replace): Make it back to static. Delete the third
4964 arg text_at_gap_tail. Cancel the code for handling it.
4965
4966 * coding.h (struct coding_system): New member eol_seen.
4967
4968 * coding.c (detect_ascii): New function.
4969 (detect_coding): Set coding->head_ascii and coding->eol_seen only
4970 when the source bytes are actually scanned. On detecting for
4971 coding_category_utf_8_auto, call detect_ascii instead of scanning
4972 source bytes directly.
4973 (produce_chars): Call insert_from_gap with the new arg 0.
4974 (encode_coding): Likewise.
4975 (decode_coding_gap): Control ASCII optimization by the variable
4976 disable_ascii_optimization instead of #ifndef .. #endif.
4977 Deccode EOL format according to coding->eol_seen.
4978 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
4979 variable.
4980
8a44e6d1
KH
4981 * lisp.h (adjust_after_replace): Cancel externing it.
4982 (insert_from_gap): Adjust prototype.
4983
5f795e34
EZ
49842013-03-15 Eli Zaretskii <eliz@gnu.org>
4985
4986 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
4987 FULLSCREEN_MAXIMIZED. (Bug#13935)
4988
f258b4be
DA
49892013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
4990
4991 * region-cache.c (find_cache_boundary, move_cache_gap)
4992 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
4993 Simplify debugging check and convert to eassert. Adjust comment.
4994 (pp_cache): Put under ENABLE_CHECKING.
4995
a5cc4dde
EZ
49962013-03-14 Eli Zaretskii <eliz@gnu.org>
4997
4998 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
4999 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
5000 and WM_ACTIVATEAPP.
5001 (w32fullscreen_hook): If the frame is visible, reset
5002 f->want_fullscreen flag after changing the frame size. If the
5003 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
5004 (Bug#13953)
5005
3fc5e44a
DC
50062013-03-13 Daniel Colascione <dancol@dancol.org>
5007
5008 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
5009 too so that these builds can use Cygwin's file conversion
5010 functions. (We've been building and linking cygw32.o all along
5011 and just not using it.)
5012
47d7532e
PE
50132013-03-13 Paul Eggert <eggert@cs.ucla.edu>
5014
5015 File synchronization fixes (Bug#13944).
5016 * Makefile.in (LIB_FDATASYNC): New macro.
5017 (LIBES): Use it.
5018 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
5019 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
5020 Don't worry about HAVE_FSYNC, since a substitute fsync is
5021 available if the system lacks one.
5022 (Fwrite_regin): Retry fsync if interrupted.
5023
c7ffccaf
EZ
50242013-03-13 Eli Zaretskii <eliz@gnu.org>
5025
4e2df81d 5026 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
5027 activated, call w32fullscreen_hook, to make sure the new frame
5028 dimensions are in effect. (Bug#13937)
5029
8a7debc1
DA
50302013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
5031
5032 * xdisp.c (init_iterator): Simplify because both character and byte
5033 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
5034 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
5035 character and byte positions can be obtained from marker.
8a7debc1 5036
7fd8c501
PE
50372013-03-13 Paul Eggert <eggert@cs.ucla.edu>
5038
d9df6f40
PE
5039 Static checking by Sun C 5.12.
5040 * alloc.c (buffer_memory_full) [REL_ALLOC]:
5041 * bytecode.c (exec_byte_code):
5042 * dispnew.c (init_display):
5043 * eval.c (error):
5044 * fileio.c (Fsubstitute_in_file_name):
5045 * keyboard.c (Fevent_convert_list):
5046 * keymap.c (Fsingle_key_description):
5047 * term.c (maybe_fatal, fatal):
5048 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
5049 * xsmfns.c (Fhandle_save_session):
5050 Omit unreachable code.
5051 * keymap.c (map_keymap_char_table_item): Cast void * to
5052 a function pointer type; the C Standard requires this.
5053
7fd8c501
PE
5054 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
5055 Include <sys/param.h> unconditionally, as that works elsewhere and
5056 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
5057 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
5058 and FreeBSD now.
5059
a020afb9 5060See ChangeLog.12 for earlier changes.
aac0c6e3
MR
5061
5062;; Local Variables:
5063;; coding: utf-8
aac0c6e3
MR
5064;; End:
5065
ab422c4d 5066 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
5067
5068 This file is part of GNU Emacs.
5069
5070 GNU Emacs is free software: you can redistribute it and/or modify
5071 it under the terms of the GNU General Public License as published by
5072 the Free Software Foundation, either version 3 of the License, or
5073 (at your option) any later version.
5074
5075 GNU Emacs is distributed in the hope that it will be useful,
5076 but WITHOUT ANY WARRANTY; without even the implied warranty of
5077 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5078 GNU General Public License for more details.
5079
5080 You should have received a copy of the GNU General Public License
5081 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.