* src/callint.c (Fcall_interactively): Always return a vector for 'K'.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
d99760fa
SM
12013-09-04 Stefan Monnier <monnier@iro.umontreal.ca>
2
3 * callint.c (Fcall_interactively): Always return a vector for 'K'.
4
224e313d
PE
52013-09-04 Paul Eggert <eggert@cs.ucla.edu>
6
7 Makefile improvements.
8 * Makefile.in (config.status): Don't use double-colon rules, as
9 they are not portable according to POSIX. Fix shell typo with `;
10 I guess this rule has never been tested?
11 (VCSWITNESS): New macro, to override any environment var.
12
6d6ed1af
DA
132013-09-04 Dmitry Antipov <dmantipov@yandex.ru>
14
15 * xterm.h (struct x_display_info): Do not track X connection
16 fd separately because it is always available from Display.
17 * xterm.c (x_term_init, x_delete_terminal, x_delete_display):
18 Adjust users.
19
bc923770
DA
202013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
21
22 * buffer.c (drop_overlay):
23 * fileio.c (restore_point_unwind): Prefer unchain_marker to
24 Fset_marker (X, Qnil, ...) (which is the same but a bit slower).
25
b1cf96de
DA
262013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
27
28 * buffer.c (Fmake_overlay, Fmove_overlay):
29 * intervals.c (set_point_from_marker):
30 * print.c (PRINTPREPARE): Prefer signal_error
31 to plain error and report unsuitable marker too.
32
d1fc6c21
DA
332013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
34
35 * xterm.h (struct scroll_bar): Prefer int to Lisp_Object
36 for 'dragging' member.
d1ae6a0b
DA
37 (struct x_output): Remove set-but-unused leftovers
38 'left_before_move' and 'top_before_move'.
d1fc6c21
DA
39 * gtkutil.c (xg_set_toolkit_scroll_bar_thumb):
40 * xterm.c (xt_action_hook, xm_scroll_callback, xg_scroll_callback)
41 (xg_end_scroll_callback, xaw_jump_callback, xaw_scroll_callback)
42 (x_set_toolkit_scroll_bar_thumb, x_scroll_bar_create)
43 (x_scroll_bar_set_handle, XTset_vertical_scroll_bar)
44 (x_scroll_bar_handle_click, x_scroll_bar_note_movement)
d1ae6a0b 45 (x_scroll_bar_report_motion, x_set_offset): Related users changed.
ec5e7504 46 * xfns.c, image.c (XLIB_ILLEGAL_ACCESS): No longer needed.
d1fc6c21 47
0ce9f6de
JD
482013-09-03 Jan Djärv <jan.h.d@swipnet.se>
49
50 * nsfont.m (INVALID_GLYPH): New define.
51 (nsfont_encode_char): Use INVALID_GLYPH.
52 (ns_uni_to_glyphs): Ditto, check for NSNullGlyph (Bug#15138).
53
b594a96c
DA
542013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
55
56 * xterm.c (x_last_mouse_movement_time): Revert last change.
57 This code should use XDisplayMotionBufferSize to check display's
58 motion history first, and there are few other issues as well.
59 (x_scroll_bar_note_movement): Pass XMotionEvent rather than XEvent.
60 (handle_one_xevent): Adjust user.
61
8b098236
MR
622013-09-02 Martin Rudalics <rudalics@gmx.at>
63
9718b207
MR
64 * dispnew.c (Flast_nonminibuf_frame): Move from here ...
65 * frame.c (Flast_nonminibuf_frame): ... to here.
66 (check_minibuf_window): Don't abort if no window was found
67 (Bug#15247).
8b098236 68
84e70bba
DA
692013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
70
71 Use XGetMotionEvents to ask the last mouse motion time from X server.
72 * xterm.c (X_MOTION_HISTORY): Default to 1.
73 (x_last_mouse_movement_time) [X_MOTION_HISTORY]: New function.
74 (x_last_mouse_movement_time) [!X_MOTION_HISTORY]: Legacy version.
75 (note_mouse_movement, x_scroll_bar_note_movement) [!X_MOTION_HISTORY]:
76 Ifdef away legacy code.
77 (XTmouse_position, x_scroll_bar_report_motion):
78 Use x_last_mouse_movement_time.
fc85e20b
DA
79 (handle_one_xevent): Use event.xunmap and not event.xmap when handling
80 UnmapNotify event.
84e70bba 81
1fccc530
DA
822013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
83
84 * msdos.c (last_mouse_window): Move to...
85 (dos_rawgetc): ...this function and adjust comment.
86 * nsterm.m (last_window): Rename to last_mouse_window, move to...
87 (mouseMoved): ...this function and adjust comment.
88 * w32term.c (last_window): Likewise with...
89 (w32_read_socket): ...this function.
90 * xterm.c (last_window): Likewise with...
91 (handle_one_xevent): ...this function.
92
0ab10992
DA
932013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
94
b7da754d 95 * window.h (Vmouse_window, Vmouse_event): Remove the leftovers.
0ab10992
DA
96 * xterm.c (toplevel): Drop obsolete comment and move compose_status...
97 (handle_one_xevent): ...to here.
98 (STORE_KEYSYM_FOR_DEBUG): Move under ENABLE_CHECKING and make no-op
99 otherwise.
100
0c7f856e
DA
1012013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
102
103 * msdos.c (IT_set_terminal_window): Remove no-op.
104 (initialize_msdos_display): Adjust terminal setup.
105 * w32console.c (w32con_set_terminal_window): Remove no-op.
106 (initialize_w32_display): Adjust terminal setup.
107 * w32term.c (w32_set_terminal_window): Remove no-op.
108 (w32_create_terminal): Adjust terminal setup.
109 * xterm.c (XTset_terminal_window): Remove no-op.
110 (x_create_terminal): Adjust terminal setup.
111
a892a94c
DA
1122013-09-01 Dmitry Antipov <dmantipov@yandex.ru>
113
114 * nsterm.m (ns_set_terminal_modes, ns_reset_terminal_modes):
115 Remove no-ops.
116 (ns_create_terminal): Adjust terminal setup.
117 * w32term.c (w32_set_terminal_modes, w32_reset_terminal_modes):
118 Remove no-ops.
119 (w32_create_terminal): Adjust terminal setup.
120 * xterm.c (XTset_terminal_modes, XTreset_terminal_modes):
121 Remove no-ops.
122 (x_create_terminal): Adjust terminal setup.
123
cf91889a
DA
1242013-09-01 Dmitry Antipov <dmantipov@yandex.ru>
125
126 * dispextern.h (SET_TEXT_POS_FROM_MARKER): Indent.
127 (CLIP_TEXT_POS_FROM_MARKER): New macro.
128 * dispnew.c (buffer_posn_from_coords):
129 * window.c (Fwindow_end, displayed_window_lines):
130 * xdisp.c (redisplay_mode_lines): Use it.
131
5b0891df
JD
1322013-09-01 Jan Djärv <jan.h.d@swipnet.se>
133
134 * fontset.c (face_for_char): Check char in the current face font first
135 if HAVE_NS (Bug#15138).
136
0a357e98
MR
1372013-08-31 Martin Rudalics <rudalics@gmx.at>
138
139 * window.c (temp_output_buffer_show): Make sure window returned
140 by display_buffer is live (Bug#15213).
141
9d7693d7
DA
1422013-08-30 Dmitry Antipov <dmantipov@yandex.ru>
143
144 Minor cleanup to avoid forward declarations.
145 * coding.h (struct ccl_spec): Remove forward declaration.
146 * composite.h (toplevel): Include font.h.
147 (struct composition_it, struct face, struct font_metrics):
148 Remove forward declaration.
149 * dispextern.h (struct image, struct atimer): Likewise.
150 * emacsgtkfixed.h (struct frame): Likewise.
151 * emacsgtkfixed.c (toplevel): Reorder headers and drop stdio.h.
152 * font.h (struct font_driver, struct font, struct glyph_string)
153 (struct face): Remove forward declaration.
154 * fontset.h (struct face, struct font): Likewise.
155 * frame.h (toplevel): Style cleanup.
156 (enum output_method): Move to...
157 * termhooks.h (enum output_method): ...here.
158 (struct glyph, struct frame, struct ns_display_info)
159 (struct x_display_info, struct w32_display_info):
160 Remove forward declaration.
161 * xterm.h (toplevel): Include termhooks.h.
162 (struct font, struct window, struct glyph_matrix, struct frame)
163 (struct input_event, struct face, struct image): Remove forward
164 declaration.
165 * gtkutil.h (struct _widget_value): Likewise.
166 * keyboard.h (toplevel): Include termhooks.h.
167 (struct input_event): Remove forward declaration.
168
032f7451
DA
1692013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
170
171 * intervals.c (set_point_from_marker): New function.
172 * editfns.c (Fgoto_char):
173 * process.c (Finternal_default_process_filter):
174 * window.c (select_window_1): Use it.
175 * buffer.h (set_point_from_marker): Add prototype.
176
3f940c5a
EZ
1772013-08-29 Eli Zaretskii <eliz@gnu.org>
178
179 * w32.c (term_winsock): Call release_listen_threads before calling
180 WSACleanup.
181 (_sys_wait_accept): Wait for accept event in a loop with a finite
182 timeout, instead of waiting indefinitely. Will hopefully avoid
183 hanging during exit because WSACleanup deadlocks waiting for the
184 event object to be released. (Bug#14333)
185
186 * w32proc.c (release_listen_threads): New function, signals all
187 the reader threads that listen for connections to stop waiting.
188
189 * w32.h (release_listen_threads): Add prototype.
190
101ed2bb
DA
1912013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
192
193 * alloc.c (Fmake_marker, build_marker): Zero need_adjustment
194 field of new marker (for sanity and safety).
20de2834
DA
195 * lisp.h (XSETMARKER): Remove unused macro (it doesn't work
196 anyway because XMISCTYPE is a function and can't be an lvalue).
101ed2bb 197
1f5cf200
DA
1982013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
199
200 * xterm.c (x_clear_area): Lost 7th arg because it is always False.
201 (x_after_update_window_line, x_scroll_bar_create):
202 (x_scroll_bar_set_handle, XTset_vertical_scroll_bar):
203 (handle_one_xevent, x_clear_frame_area):
204 * gtkutil.c (xg_clear_under_internal_border, xg_update_scrollbar_pos):
205 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Adjust users.
206 * xterm.h (x_clear_area): Adjust prototype.
207
d2b36813
DA
2082013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
209
210 Hook scanning and indentation functions to find_newline. This helps
211 to avoid duplicated code and renders more respect to newline cache.
212 * lisp.h (scan_newline): Prefer ptrdiff_t to EMACS_INT.
213 * cmds.c (Fforward_line):
214 * indent.c (scan_for_column, Fcurrent_indentation, indented_beyond_p):
215 Use find_newline and avoid unnecessary point movements.
216 * search.c (scan_newline): Implement on top of find_newline.
217
3ec7babc
SM
2182013-08-28 Stefan Monnier <monnier@iro.umontreal.ca>
219
220 * eval.c (Ffuncall): Fix handling of ((lambda ..) ..) in lexically
221 scoped code (bug#11258).
222
5ab473cd
JD
2232013-08-28 Davor Cubranic <cubranic@stat.ubc.ca> (tiny change)
224
225 * nsterm.m (last_window): New variable.
226 (EV_TRAILER2): New macro.
227 (EV_TRAILER): Call EV_TRAILER2.
228 (mouseMoved:): Add support for mouse-autoselect-window
229 on nextstep (Bug#6888).
230
78779650
AS
2312013-08-28 Andreas Schwab <schwab@suse.de>
232
233 * regex.c (CHAR_CHARSET, CHARSET_LEADING_CODE_BASE, CHAR_HEAD_P)
234 (SINGLE_BYTE_CHAR_P, SAME_CHARSET_P, MAKE_CHAR, BYTE8_TO_CHAR):
235 Remove unused macro definitions.
236 (CHARSET_RANGE_TABLE_BITS, EXTEND_RANGE_TABLE)
3ec7babc
SM
237 (SET_RANGE_TABLE_WORK_AREA_BIT, SET_RANGE_TABLE_WORK_AREA):
238 Only define if emacs.
78779650 239
c3c4768d
DA
2402013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
241
242 Prefer enum glyph_row_area to int where appropriate.
243 * dispextern.h (enum glyph_row_area): Add ANY_AREA member.
244 Fix comment.
245 (window_box, window_box_width, window_box_left, window_box_left_offset)
246 (window_box_right, window_box_right_offset): Adjust prototypes.
247 * xdisp.c (window_box, window_box_width, window_box_left)
248 (window_box_left_offset, window_box_right, window_box_right_offset):
249 Use enum glyph_row_area. Adjust users and tweak comment where needed.
250 (window_box_edges): Likewise. Lost 2nd arg since it is always ANY_AREA.
251 * nsterm.m (ns_clip_to_row):
252 * w32term.c (w32_clip_to_row):
253 * xterm.c (x_clip_to_row): Likewise.
254
6bdcbfe1
DA
2552013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
256
257 * buffer.c (Foverlays_at, Foverlays_in, Fnext_overlay_change)
258 (Fprevious_overlay_change): Fast path for buffer with no overlays.
259
50b13cde
PE
2602013-08-28 Paul Eggert <eggert@cs.ucla.edu>
261
262 * Makefile.in (SHELL): Now @SHELL@, not /bin/sh,
263 for portability to hosts where /bin/sh has problems.
264
f60e429a
DA
2652013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
266
267 Redesign redisplay interface to drop global output_cursor.
268 * dispextern.h (struct redisplay_interface): Remove cursor_to member.
269 (toplevel): Remove declaration of output_cursor.
270 (set_output_cursor, x_cursor_to): Remove prototype.
271 * window.h (struct window): New member output_cursor.
272 (output_cursor_to): New function to replace RIF member.
273 * dispnew.c (redraw_overlapped_rows, update_marginal_area)
274 (update_text_area, set_window_cursor_after_update): Use it.
275 * xdisp.c (output_cursor, set_output_cursor, x_cursor_to): Remove.
276 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
277 * nsterm.m (ns_update_window_begin, ns_update_window_end):
278 * w32term.c (x_update_window_begin, x_update_window_end):
279 * xterm.c (x_update_window_begin, x_update_window_end):
280 Adjust to use per-window output cursor.
281
43aac990
PE
2822013-08-27 Paul Eggert <eggert@cs.ucla.edu>
283
d486344e
PE
284 Simplify SELECT_TYPE-related code.
285 Like EMACS_TIME, this portability layer is no longer needed, since
286 Emacs has been using fd_set as a portability layer for some time.
287 * sysselect.h (FD_SETSIZE): Rename from MAXDESC. All uses changed.
288 (SELECT_TYPE): Remove. All uses changed to fd_set.
289 (fd_set) [!FD_SET]: New typedef.
290
43aac990
PE
291 Simplify EMACS_TIME-related code.
292 This portability layer is no longer needed, since Emacs has been
293 using struct timespec as a portability layer for some time.
294 * atimer.h, buffer.h, dispextern.h, xgselect.h:
295 Include <time.h> rather than "systime.h"; that's all that's needed now.
296 * dispnew.c: Include <timespec.h> rather than "systime.h";
297 that's all that's needed now.
298 * systime.h (EMACS_TIME): Remove. All uses changed to struct timespec.
299 (EMACS_TIME_RESOLUTION): Remove. All uses changed to
300 TIMESPEC_RESOLUTION.
301 (LOG10_EMACS_TIME_RESOLUTION): Remove. All uses changed to
302 LOG10_TIMESPEC_RESOLUTION.
303 (EMACS_SECS, emacs_secs_addr): Remove. All uses changed to tv_sec.
304 (EMACS_NSECS): Remove. All uses changed to tv_nsec.
305 (make_emacs_time): Remove. All used changed to make_timespec.
306 (invalid_timespec): Rename from invalid_emacs_time. All uses changed.
307 (current_timespec): Rename from current_emacs_time. All uses changed.
308 (add_emacs_time): Remove. All uses changed to timespec_add.
309 (sub_emacs_time): Remove. All uses change dot timespec_sub.
310 (EMACS_TIME_SIGN): Remove. All uses changed to timespec_sign.
311 (timespec_valid_p): Rename from EMACS_TIME_VALID_P. All uses changed.
312 (EMACS_TIME_FROM_DOUBLE): Remove. All uses changed to dtotimespec.
313 (EMACS_TIME_TO_DOUBLE): Remove. All uses changed to timespectod.
314 (current_timespec): Rename from current_emacs_time. All uses changed.
315 (EMACS_TIME_EQ, EMACS_TIME_LT, EMACS_TIME_LE): Remove. All uses
316 changed to timespec_cmp.
317 * xgselect.c: Include <timespec.h>, since our .h files don't.
318
d350e350
DA
3192013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
320
321 * xterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE:)
322 * nsterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE):
323 Remove the leftovers.
324 * gtkutil.c (toplevel): Do not declare Qxft but include
325 font.h to do so.
326 * image.c (toplevel): Do not declare Vlibrary_cache because
327 it's already done in lisp.h.
328
9fed9729
DA
3292013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
330
331 * lisp.h (Mouse_HLInfo): Move from here...
332 * dispextern.h (Mouse_HLInfo): ...to here and offload lisp.h.
333 (reset_mouse_highlight): New function.
334 * msdos.c (dos_set_window_size, IT_update_begin)
335 (internal_terminal_init):
336 * nsterm.m (ns_update_window_end, x_free_frame_resources)
337 (ns_initialize_display_info):
338 * w32console.c (initialize_w32_display):
339 * w32term.c (x_update_window_end, x_free_frame_resources)
340 (w32_initialize_display_info):
341 * xterm.c (x_update_window_end, x_free_frame_resources, x_term_init):
342 * window.c (Fdelete_other_windows_internal):
343 * xdisp.c (clear_mouse_face, cancel_mouse_face): Use it.
344 * termchar.h (toplevel):
345 * xterm.h (toplevel): Include dispextern.h.
346
f462f075
PE
3472013-08-26 Paul Eggert <eggert@cs.ucla.edu>
348
349 Fix minor problems found by static checking.
350 * image.c (XGetPixel, XPutPixel) [HAVE_NS]: Now static.
351 (expect): Avoid nested-if warning.
352 (x_build_heuristic_mask) [HAVE_NS]: Avoid unused-var warning.
353 * nsmenu.m (fillWithWidgetValue:): Avoid type warning.
354 * nsterm.h, nsterm.m (ns_select):
355 * xgselect.c, xgselect.h (xg_select):
356 Adjust signature to better match pselect's.
357 * nsterm.m (ns_select):
358 Don't set *TIMEOUT, since pselect doesn't.
359 * regex.c (whitespace_regexp): Now const_re_char *, to avoid
360 diagnostic about assigning const char * to it.
361 * xfaces.c (x_display_info) [HAVE_NS]: Remove; unused.
362
068f9124
SM
3632013-08-26 Stefan Monnier <monnier@iro.umontreal.ca>
364
365 * lread.c (substitute_object_recurse): Handle hash-tables as well
366 (bug#15190).
367
f5adc984
PE
3682013-08-26 Paul Eggert <eggert@cs.ucla.edu>
369
1fc8eb33
PE
370 Fix unlikely core dump in init_tty, and simplify terminfo case.
371 * term.c (init_tty) [TERMINFO]: Fix check for buffer overrun.
372 The old version incorrectly dumped core if malloc returned a
373 buffer containing only non-NUL bytes.
374 (init_tty): Do not allocate or free termcap buffers; the
375 struct does that for us now.
376 * termchar.h (TERMCAP_BUFFER_SIZE) [!TERMINFO]: New constant.
377 (struct tty_display_info): Define members termcap_term_buffer and
378 termcap_strings_buffer only if !TERMINFO, since terminfo doesn't
379 use them. Allocate them directly in struct rather than indirectly
380 via a pointer, to simplify init_tty.
381
f5adc984
PE
382 * frame.c (check_minibuf_window): Initialize 'window' properly,
383 so that Emacs reliably aborts later if 'window' is not initialized.
384
efec3894
JD
3852013-08-26 Jan Djärv <jan.h.d@swipnet.se>
386
387 * gtkutil.c (xg_initialize): Set gtk-menu-bar-accel to "" instead
388 of VoidSymbol (Bug#15154).
389
e1d0341e
DA
3902013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
391
392 * lisp.h (Mouse_HLInfo): Drop set-but-unused members
393 mouse_face_beg_y and mouse_face_end_y.
394 * xdisp.c (note_tool_bar_highlight, mouse_face_from_buffer_pos)
395 (mouse_face_from_string_pos, note_mode_line_or_margin_highlight):
396 Adjust users and update comment where appropriate.
397
bfff6445
MR
3982013-08-26 Martin Rudalics <rudalics@gmx.at>
399
400 * frame.c (check_minibuf_window): New function.
068f9124
SM
401 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
402 Call check_minibuf_window (Bug#15183).
bfff6445 403
c80016b3
DA
4042013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
405
406 * window.h (struct window): Replace last_cursor with last_cursor_vpos
407 because this is the only last cursor data we need to keep and consult.
408 * window.c (replace_window, set_window_buffer, Fsplit_window_internal):
409 * xdisp.c (mark_window_display_accurate_1, try_cursor_movement):
410 Adjust users.
411
de396731
DA
4122013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
413
068f9124
SM
414 Fix recovering from possible decompression error.
415 Since insert_from_gap doesn't always move point, we can't use PT as
de396731 416 the position where the partially decompressed data ends, and
447218dd 417 should count how many bytes was produced so far.
de396731
DA
418 * decompress.c (struct decompress_unwind_data): Add nbytes member.
419 (unwind_decompress): Really delete partially uncompressed data.
420 (Fzlib_decompress_region): Take decompressed data size into account.
421
c76826d9
DA
4222013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
423
424 * syntax.c (init_syntax_once): Adjust comment and do an early
425 initialization of Qchar_table_extra_slots just once...
426 * casetab.c (init_casetab_once):
427 * category.c (init_category_once):
428 * character.c (syms_of_character):
429 * coding.c (syms_of_coding):
430 * xdisp.c (syms_of_xdisp): ...and omit it here.
431
b34454d0
EZ
4322013-08-24 Eli Zaretskii <eliz@gnu.org>
433
11f20add
EZ
434 * xdisp.c (get_next_display_element): Don't apply to characters
435 from a display vector the logic of setting it->end_of_box_run_p
436 suitable for characters from a buffer. (Bug#15175)
437
b34454d0
EZ
438 * w32.c (fdutimens): Call 'utime', which is implemented on w32.c
439 to handle directories, rather than '_utime' which doesn't.
440 (Bug#15176)
441
6e1b469e
JD
4422013-08-24 Jan Djärv <jan.h.d@swipnet.se>
443
444 * gtkutil.c (x_wm_set_size_hint): Don't set hints when maximized
445 or fullscreen (Bug#14627).
446
9c05bccf
PE
4472013-08-24 Paul Eggert <eggert@cs.ucla.edu>
448
449 System-dependent integer overflow fixes.
450 * process.c (Fset_process_window_size): Signal an error if
451 the window size is outside the range supported by the lower level.
452 * sysdep.c (set_window_size): Return negative on error,
453 nonnegative on success, rather than -1, 0, 1 on not in system,
454 failure, success. This is simpler. Caller changed.
455 (serial_configure): Remove unnecessary initialization of local.
456 (procfs_get_total_memory) [GNU_LINUX]: Don't assume system memory
457 size fits in unsigned long; this isn't true on some 32-bit hosts.
458 Avoid buffer overrun if some future version of /proc/meminfo has a
459 variable name longer than 20 bytes.
460 (system_process_attributes) [__FreeBSD__]:
461 Don't assume hw.availpages fits in 'int'.
462
c365c355
PE
4632013-08-23 Paul Eggert <eggert@cs.ucla.edu>
464
465 Don't let very long directory names overrun the stack.
466 Fix some related minor problems involving "//", vfork.
467 * callproc.c (encode_current_directory): New function.
468 (call_process): Don't append "/"; not needed.
469 * fileio.c (file_name_as_directory_slop): New constant.
470 (file_name_as_directory): Allow SRC to be longer than SRCLEN;
471 this can save the caller having to alloca.
472 (Ffile_name_as_directory, Fdirectory_file_name, Fexpand_file_name):
473 Use SAFE_ALLOCA, not alloca.
474 (directory_file_name, Fexpand_file_name): Leave leading "//"
475 alone, since it can be special even on POSIX platforms.
476 * callproc.c (call_process):
477 * process.c (Fformat_network_address):
478 * sysdep.c (sys_subshell):
479 Use encode_current_directory rather than rolling our own.
480 (create_process): No need to encode directory; caller does that now.
481 * process.h (encode_current_directory): New decl.
482 * sysdep.c (sys_subshell): Work even if vfork trashes saved_handlers.
483 Rework to avoid 'goto xyzzy;'.
484
6c6014d4
EZ
4852013-08-23 Eli Zaretskii <eliz@gnu.org>
486
487 * xdisp.c (handle_face_prop): If the default face was remapped use
488 the remapped face for strings from prefix properties. (Bug#15155)
489
9997ec56
DA
4902013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
491
492 Minor cleanup for redisplay interface and few related functions.
493 * frame.h (enum text_cursor_kinds): Move from here...
494 * dispextern.h (enum text_cursor_kinds): ...to here.
495 (toplevel): Drop unnecessary declarations.
496 (struct redisplay_interface): Use bool and enum text_cursor_kinds
497 in update_window_end_hook and draw_window_cursor functions.
498 (display_and_set_cursor, x_update_cursor): Adjust prototypes.
499 * nsterm.m (ns_update_window_end, ns_draw_window_cursor):
500 * w32term.c (x_update_window_end,w32_draw_window_cursor):
501 * xterm.c (x_update_window_end, x_draw_window_cursor):
502 * xdisp.c (display_and_set_cursor, update_window_cursor)
503 (update_cursor_in_window_tree, x_update_cursor): Use bool and
504 enum text_cursor_kinds where appropriate.
505
7f780da6
DA
5062013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
507
508 Redesign redisplay interface to drop updated_row and updated_area.
509 * dispextern.h (updated_row, updated_area): Remove declaration.
510 (struct redisplay_interface): Pass glyph row and row area parameters
511 to write_glyphs, insert_glyphs and clear_end_of_line functions.
512 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
513 Adjust prototypes.
514 * dispnew.c (updated_row, updated_area): Remove.
515 (redraw_overlapped_rows, update_window_line): Adjust user.
516 (update_marginal_area, update_text_area): Likewise. Pass updated row
517 as a parameter. Prefer enum glyph_row_area to int where appropriate.
518 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
519 Adjust users.
520
26495794
PE
5212013-08-22 Paul Eggert <eggert@cs.ucla.edu>
522
523 * process.c (flush_pending_output): Remove stub.
524 All uses removed.
525
4a88129a
PE
5262013-08-21 Paul Eggert <eggert@cs.ucla.edu>
527
528 * callproc.c: Fix race that killed background processes (Bug#15144).
529 (call_process): New arg TEMPFILE_INDEX. Callers changed.
530 Record deleted process-id in critical section, not afterwards.
531 Don't mistakenly kill process created by a call-process invocation
532 that discards output and does not wait.
533
0c5307b0
DA
5342013-08-21 Dmitry Antipov <dmantipov@yandex.ru>
535
536 Fix compilation with GC_MARK_STACK == GC_USE_GCPROS_AS_BEFORE
537 and GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES.
538 * alloc.c (toplevel): Remove unnecessary nested #if...#endif.
539 (mark_maybe_object) [!GC_MARK_STACK]: Define to emacs_abort
540 to shut up compiler in mark_object.
541 (dump_zombies): Convert to global and add EXTERNALLY_VISIBLE.
542
0d7c1e66
PE
5432013-08-21 Paul Eggert <eggert@cs.ucla.edu>
544
545 * process.c (allocate_pty) [PTY_OPEN]: Set fd's FD_CLOEXEC flag.
546 We can't portably rely on PTY_OPEN doing that, even if
547 it calls posix_openpt with O_CLOEXEC.
548
3f246b65
KH
5492013-08-20 Kenichi Handa <handa@gnu.org>
550
551 * character.c (string_char): Improve commentary.
552
8c2f38aa
PE
5532013-08-20 Paul Eggert <eggert@cs.ucla.edu>
554
555 * image.c (SIGNATURE_DIGESTSIZE): Remove.
556 (struct animation_cache): Make signature a flexible array member.
557 All uses changed. This is a tad slower but may insulate us better
558 from future changes to ImageMagick.
559
bb566cea
PE
5602013-08-19 Paul Eggert <eggert@cs.ucla.edu>
561
562 * image.c: Shrink memory needed for animation cache.
563 (SIGNATURE_DIGESTSIZE): New constant.
564 (struct animation_cache): Make 'signature' a fixed size array of bytes.
565 (imagemagick_create_cache): Copy the signature. This saves
566 several KB of memory that ImageMagick wastes per signature.
567 Don't bother updating the update_time, as the caller does that now.
568 (imagemagick_prune_animation_cache): Don't destroy the signature, as
569 it's a fixed size struct member now.
570 (imagemagick_get_animation_cache): Always destroy the signature,
571 as it's now imagemagick_create_cache's responsibility to copy it.
572 Avoid duplicate calls to strcmp and to imagemagick_create_cache,
573 and use memcmp rather than strcmp.
574 eassert that ImageMagick returns a signature of the specified length.
575
6da26928
LMI
5762013-08-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
577
578 * image.c (imagemagick_get_animation_cache): Don't segfault on
579 each invocation.
453f4022
LMI
580 (imagemagick_get_animation_cache): Revert to previous definition
581 so that it actually works. But keep the memory leak fix.
582 (imagemagick_get_animation_cache): Fix memory leak.
6da26928 583
22490125
PE
5842013-08-19 Paul Eggert <eggert@cs.ucla.edu>
585
d0139df5
PE
586 * image.c: Fix animation cache signature memory leak.
587 Fix some other minor performance problems while we're at it.
588 (imagemagick_create_cache): Clear just the members that
589 need clearing. Don't set update_time, as caller does that now.
590 (imagemagick_prune_animation_cache, imagemagick_get_animation_cache):
591 Simplify by using pointer-to-pointer instead of a prev pointer.
592 (imagemagick_prune_animation_cache): Use make_emacs_time rather
593 than EMACS_TIME_FROM_DOUBLE, and DestroyString rather than free.
594 (imagemagick_get_animation_cache): Don't xstrdup the image signature;
595 it's already a copy. Free the signature probe unless it's cached.
596
22490125
PE
597 * process.c (handle_child_signal): Fix crash; deleted pid (Bug#15106).
598 This was introduced by my 2013-08-12 fix for Bug#15035.
599
deb31e75
DA
6002013-08-19 Dmitry Antipov <dmantipov@yandex.ru>
601
602 * image.c (imagemagick_create_cache, imagemagick_get_animation_cache)
603 (imagemagick_prune_animation_cache): Now static.
604
319a4d03
LMI
6052013-08-18 Lars Magne Ingebrigtsen <larsi@gnus.org>
606
607 * image.c (imagemagick_get_animation_cache): Don't segfault when
608 pruning all entries.
609
f747d82e
KB
6102013-08-18 Ken Brown <kbrown@cornell.edu>
611
612 * sheap.c (STATIC_HEAP_SIZE): Adjust to current needs; use bigger
613 static heap if ENABLE_CHECKING is defined.
614 (max_bss_sbrk_ptr): New variable.
615 (bss_sbrk): Use it.
616 (report_sheap_usage): Report maximum static heap usage instead of
617 ending static heap usage.
618
d2c28fab
EZ
6192013-08-17 Eli Zaretskii <eliz@gnu.org>
620
621 * decompress.c (Fzlib_available_p) [WINDOWSNT]: Update the value
622 of zlib_initialized according to the results of calling
623 init_zlib_functions.
624
274ff63f
LMI
6252013-08-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
626
627 * image.c: Implement an ImageMagick per-image cache.
8a6f875f 628 (imagemagick_get_animation_cache): Fix a double-free error.
49ceb676
LMI
629 (imagemagick_load_image): Remove the ping_wand code, which only
630 apparently saved time on invalid animated images, and slowed down
631 everything else. Optimise for the common case.
274ff63f 632
2bede2ed
XF
6332013-08-16 Xue Fuqiao <xfq.free@gmail.com>
634
70ff8240
XF
635 * buffer.c (syms_of_buffer) <buffer-undo-list>: Doc fix.
636
de179a3e
XF
637 * editfns.c (insert_before_markers): Mention overlay in the doc string.
638
2bede2ed
XF
639 * marker.c (set_marker): Remove documentation of undefined behavior.
640
703dbeba
LMI
6412013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
642
643 * image.c (imagemagick_compute_animated_image): Animate correctly
644 when sub-images are smaller than the main image.
1d18b1e6
LMI
645 (imagemagick_compute_animated_image): Setting the iterator row to
646 zero is apparently not allowed.
79670014
LMI
647 (imagemagick_compute_animated_image): Allow images that say they
648 have sub-images that are bigger than the main image, but just crop
649 them.
703dbeba 650
63216c5e
JD
6512013-08-15 Jan Djärv <jan.h.d@swipnet.se>
652
653 * nsmenu.m (menuWillOpen:): Fix preprocessor test (Bug#15001).
654
a5b5f73f
LMI
6552013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
656
657 * image.c (imagemagick_compute_animated_image): Respect the GIF
658 disposal methods.
659
0fe73012
KB
6602013-08-15 Ken Brown <kbrown@cornell.edu>
661
662 * emacs.c (main): Update comment about G_SLICE_ALWAYS_MALLOC.
663 * gmalloc.c (memalign) [CYGWIN]: Revert last change; it's not
664 needed.
665
691a357f
PE
6662013-08-15 Paul Eggert <eggert@cs.ucla.edu>
667
668 Fix minor problems found by static checking.
669 * frame.c (delete_frame):
670 * xdisp.c (next_element_from_display_vector):
671 Avoid uninitialized local.
672 * image.c (imagemagick_compute_animated_image): Port to C89.
673 Prefer usual GNU indentation style for loops.
674 Be more careful about bizarrely large sizes, by using ptrdiff_t
675 instead of int.
676
42fe2e88
DA
6772013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
678
679 Fix infinite frame selection loop (Bug#15025).
680 * frame.c (delete_frame): Prefer fast ad-hoc loop to next_frame.
681
d39a3da6
EZ
6822013-08-15 Eli Zaretskii <eliz@gnu.org>
683
068f9124
SM
684 * xdisp.c (compute_window_start_on_continuation_line):
685 When WORD_WRAP is in effect, use move_it_to instead of move_it_by_lines
d39a3da6
EZ
686 to make sure we end up setting the window start at the leftmost
687 visible character of the display line. This avoids funky
688 horizontal shifting because the window start is not kept on the
689 same position. (Bug#15090)
05426239
EZ
690 (next_element_from_display_vector): Support 'box' face attribute
691 in the face definitions of a display vector. (Bug#15099)
d39a3da6 692
6e856b69
LMI
6932013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
694
695 * image.c (imagemagick_compute_animated_image): Implement animated
696 images (bug#14700).
995be755
LMI
697 (imagemagick_compute_animated_image): Fix some compilation
698 warnings. Implement a very simple cache to make the animation
699 usable at all, but it should be replaced with a per-image cache.
6e856b69 700
d5a1acfa
DA
7012013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
702
703 * lisp.h (FOR_EACH_ALIST_VALUE): New macro
704 to do `for' loops over alist values.
705 * buffer.h (FOR_EACH_BUFFER):
706 * process.c (FOR_EACH_PROCESS): Use it.
707 (handle_child_signal, status_notify, Fget_buffer_process)
708 (kill_buffer_processes): Use FOR_EACH_PROCESS.
709
9c253307
DA
7102013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
711
712 * term.c (get_named_tty, create_tty_output, tty_free_frame_resources)
713 (tty_free_frame_resources, delete_tty): Prefer eassert to emacs_abort.
714 * image.c (make_image_cache): For struct image_cache, prefer xmalloc
715 to xzalloc and so avoid redundant call to memset.
716 * xterm.c (x_term_init): Avoid unnecessary initializations of dpyinfo
717 members because it is allocated with xzalloc and so already zeroed.
718
05e64f9f
KB
7192013-08-14 Ken Brown <kbrown@cornell.edu>
720
721 * gmalloc.c (memalign) [CYGWIN]: Rename to emacs_memalign
722 (Bug#15094).
723
5b71542d
DA
7242013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
725
726 Utility function and macro to copy Lisp string to C string.
727 * lisp.h (xlispstrdupa): New macro.
728 (xlispstrdup): New prototype.
729 * alloc.c (xlispstrdup): New function.
730 * callint.c (Fcall_interactively):
731 * fileio.c (Ffile_name_directory, Fexpand_file_name)
732 (Fsubstitute_in_file_name):
733 * frame.c (Fmake_terminal_frame): Use xlispstrdupa.
734 * image.c (x_create_bitmap_from_file):
735 * w32term.c (w32_term_init):
736 * xterm.c (x_term_init): Use xlispstrdup.
737
71530c97
LMI
7382013-08-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
739
4ce82fb8
LMI
740 * image.c (imagemagick_load_image): Make animated pictures work.
741 There's still some problems with background color settings, though
742 (bug#14700).
743
71530c97
LMI
744 * decompress.c (unwind_decompress): Always restore point.
745
7510a061
XF
7462013-08-14 Xue Fuqiao <xfq.free@gmail.com>
747
748 * marker.c (set_marker): Reformat documentation.
749
01c3051f
PE
7502013-08-14 Paul Eggert <eggert@cs.ucla.edu>
751
aab1fcdf
PE
752 * xdisp.c (cursor_type_changed): Now static.
753
01c3051f
PE
754 * image.c (imagemagick_filename_hint): New arg HINT_BUFFER.
755 Use changed. This avoids the need to call xmalloc and for the
756 caller to call xfree, and avoids memory leaks in some situations.
757
2084152a
DA
7582013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
759
760 * xdisp.c (adjust_window_ends): Move duplicated code to new function.
761 (try_window, try_window_reusing_current_matrix, try_window_id): Use it.
94a4e898
DA
762 (redisplay_window): If window_end_valid is cleared due to non-zero
763 windows_or_buffers_changed, clear current_matrix_up_to_date_p and
764 so do not call to try_cursor_movement for that window.
2084152a 765
02455cb6
DA
7662013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
767
768 * window.h (struct window): Convert window_end_pos and
769 window_end_vpos from Lisp_Object to ptrdiff_t and int, respectively.
770 (wset_window_end_pos, wset_window_end_vpos): Remove.
771 * dispnew.c (adjust_glyph_matrix):
772 * window.c (Fwindow_end, replace_window, set_window_buffer)
773 (make_window):
774 * xdisp.c (check_window_end, move_it_to, redisplay_internal)
775 (set_vertical_scroll_bar, redisplay_window, try_window)
776 (try_window_reusing_current_matrix, find_first_unchanged_at_end_row)
777 (try_window_id, decode_mode_spec, mouse_face_from_buffer_pos)
778 (note_mouse_highlight): Adjust users.
779 (try_cursor_movement): Likewise. Convert old precondition to eassert.
780 Add comment.
781
da5707e8
DA
7822013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
783
784 Fix --enable-gcc-warnings errors introduced in 2013-08-13 commit.
785 * image.c (imagemagick_filename_hint): Use `const char *' and
786 prefer SSDATA to SDATA to avoid warnings.
787
25554267
DA
7882013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
789
790 Cleanup window fringes, margins and scroll bars adjustments.
791 * window.c (set_window_fringes, set_window_margins)
792 (set_window_scroll_bars, apply_window_adjustment): New functions.
793 (set_window_buffer, Fset_window_margins, Fset_window_fringes)
794 (Fset_window_scroll_bars): Use them.
795
38a2c910
DA
7962013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
797
798 * window.h (struct window): Convert scroll_bar_width
799 from Lisp_Object to integer. Adjust comment.
800 (WINDOW_CONFIG_SCROLL_BAR_WIDTH, WINDOW_CONFIG_SCROLL_BAR_COLS):
801 Adjust users.
802 * window.c (wset_scroll_bar_width): Remove.
803 (make_window): Initialize scroll_bar_width.
804 (Fsplit_window_internal): Use direct assignment.
805 (Fset_window_configuration, save_window_save):
806 Convert Lisp_Object to integer and back where appropriate.
807 (Fset_window_scroll_bars): Adjust user. Return t if any scroll
808 bar was actually changed, and mention this in docstring.
809
2d065031
PE
8102013-08-13 Paul Eggert <eggert@cs.ucla.edu>
811
812 * decompress.c: Minor simplifications.
813 (Fzlib_decompress_region): Don't bother verifying
814 that avail_out <= UINT_MAX, as that was confusing.
815 Mention the restriction in a comment instead.
816 Prefer 'int' to 'ptrdiff_t' when 'int' is wide enough.
817
a5bd5abb
JD
8182013-08-13 Jan Djärv <jan.h.d@swipnet.se>
819
820 * nsmenu.m (x_activate_menubar): Check for OSX >= 10.5
821 (trackingNotification:): Call ns_check_menu_open only for OSX >= 10.5.
822
66e7901a
LMI
8232013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
824
825 * image.c (imagemagick_filename_hint): Check for errors in the
826 alist structure.
827
2fa611b7
EZ
8282013-08-13 Eli Zaretskii <eliz@gnu.org>
829
830 * window.c (Fwindow_margins): Return nil when there's no marginal
831 area, as per the documented API.
832
833 * w32term.c (x_scroll_bar_create): Use ALLOCATE_PSEUDOVECTOR, not
834 Fmake_vector, as scroll bar's struct members are not all Lisp
835 objects now. This avoids crashes in GC.
836
837 * w32term.h (struct scroll_bar): Convert fringe_extended_p to a
838 bool, so its address could be taken.
839
8259030d
LMI
8402013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
841
842 * image.c (imagemagick_filename_hint): New function to possibly
843 apply `image-content-type-suffixes'.
844 (imagemagick_load_image): Use it.
845
866c710e
EZ
8462013-08-13 Eli Zaretskii <eliz@gnu.org>
847
848 * decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil
849 if loading zlib failed.
850
f10490f0
JD
8512013-08-13 Jan Djärv <jan.h.d@swipnet.se>
852
96311be7
JD
853 * nsterm.m (ns_set_vertical_scroll_bar): Fix breakage intruduced by
854 2013-08-13 checkin below. Change bool to BOOL, rule is:
855 All Obj-C code uses BOOL, except for interfaces callable from C.
856
f10490f0
JD
857 * nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).
858
c8ae93b0
DA
8592013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
860
861 * window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
862 * nsterm.m (ns_set_vertical_scroll_bar): Use it. Use convenient
863 bool instead of BOOL.
864 * w32term.h (struct scroll_bar): Convert fringe_extended_p
865 from Lisp_Object to bitfield. Adjust comment.
866 * w32term.c (x_scroll_bar_create): Adjust user.
867 Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
868 * xterm.c (XTset_vertical_scroll_bar): Likewise.
869 Use bool for boolean.
870 * xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
871 to `unsigned int' when defining a bitfield.
872
53b64418
PE
8732013-08-13 Paul Eggert <eggert@cs.ucla.edu>
874
875 * decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
876
eeaf9bf3
DA
8772013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
878
879 * window.h (struct window): Convert left_margin_cols and
880 right_margin_cols from Lisp_Objects to integers. Adjust comment.
881 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
882 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
883 Adjust users.
884 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
885 Adjust comment.
886 (showing_window_margins_p, update_window_line, update_frame_1):
887 * fringe.c (draw_fringe_bitmap_1):
888 * xdisp.c (window_box_width): Adjust users.
889 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
890 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
891 Use direct assignment.
892 (Fset_window_configuration, save_window_save, Fwindow_margins):
893 Convert Lisp_Object to integer and back where appropriate.
894 (Fset_window_margins): Adjust user. Return t if any margin
895 was actually changed, and mention this in docstring.
896
956720af
XF
8972013-08-13 Xue Fuqiao <xfq.free@gmail.com>
898
f73f4ce6 899 * syntax.c (forward_word):
956720af
XF
900 * cmds.c (forward_char, backward_char): Mention the optional argument.
901
9e37ee3b
DA
9022013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
903
904 * window.h (struct window): Convert left_fringe_width
905 and right_fringe_width from Lisp_Objects to integers.
906 Adjust comment.
907 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
908 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
909 * window.c (wset_left_fringe_width, wset_right_fringe_width):
910 Remove.
911 (make_window): Initialize new integer fields to -1.
912 (Fsplit_window_internal): Use direct assignment.
068f9124
SM
913 (Fset_window_configuration, save_window_save):
914 Convert Lisp_Object to integer and back where appropriate.
9e37ee3b
DA
915 (Fset_window_fringes): Adjust user. Return t if any fringe
916 was actually changed, and mention this in docstring.
917
e4375ca7
DA
9182013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
919
920 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
9cda66e4
DA
921 * nsfns.m (x_set_cursor_type):
922 * w32fns.c (x_set_cursor_type):
923 * xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
924 * xdisp.c (set_frame_cursor_types): ...but in common code.
e4375ca7 925
a45543bc
DA
9262013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
927
928 * font.c (clear_font_cache): New function, stripped from...
929 (Fclear_font_cache): ...here, which now uses the function
930 above. Adjust comment.
931 * font.h (clear_font_cache): Add prototype.
932 * xfaces.c (clear_face_cache): Use clear_font_cache.
933
ae966a86
DA
9342013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
935
936 * window.c (Fset_window_start): Compare `w', not `window' because
937 `w' might not be equal to `window' after call to decode_live_window.
938
297a545b
PE
9392013-08-12 Paul Eggert <eggert@cs.ucla.edu>
940
941 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
942 This fixes a problem introduced by the Bug#15035 patch
943 when using GPG. Reported by Herbert J. Skuhra.
944
aa942e2b
EZ
9452013-08-12 Eli Zaretskii <eliz@gnu.org>
946
947 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
948 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
949 not yet initialized.
950
7699d09e
LMI
9512013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
952
953 * decompress.c (Fzlib_decompress_region): Support zlib
954 decompression, too, and rename.
955
1d238bc7
PE
9562013-08-12 Paul Eggert <eggert@cs.ucla.edu>
957
958 Minor zlib configuration tweaks.
959 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
960 Don't assume presence of fn_inflateInit2_ zlib internal function.
961
8a44a184
LMI
9622013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
963
964 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
965 include the zlib prefix.
966
594a4307
EZ
9672013-08-12 Eli Zaretskii <eliz@gnu.org>
968
969 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
970 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
971 define static variables that are pointers to zlib functions to be
972 dynamically loaded.
973 (init_zlib_functions) [WINDOWSNT]: New function.
974 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
975 New macros.
976 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
977 macros instead of invoking the zlib functions directly.
068f9124
SM
978 (syms_of_decompress): DEFSYM Qzlib_dll.
979 Staticpro Szlib_available_p.
594a4307 980
d2e113bc
DA
9812013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
982
983 Avoid looping over all frame windows to freeze and unfreeze.
984 * window.h (struct window): Drop frozen_window_start_p.
985 (freeze_window_starts): Drop prototype.
986 * frame.h (struct frame): New frozen_window_starts flag.
987 (FRAME_WINDOWS_FROZEN): New macro.
988 * window.c (freeze_window_start, freeze_window_starts):
989 Remove.
990 (select_window, replace_window): Adjust users.
991 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
992 (window_frozen_p): New function.
993 (redisplay_window): Use it.
994
94fcd171
PE
9952013-08-12 Paul Eggert <eggert@cs.ucla.edu>
996
997 Fix some fd issues when running subprocesses (Bug#15035).
998 Fix bugs that can leak files or file descriptors on errors.
999 Don't unlink open temp files, as that's hard for users to diagnose
1000 when things go awry (e.g., temp disk exhausted).
1001 Don't bother to lock temp files. Check for invalid recursion.
1002 * callproc.c (synch_process_fd): Remove. All uses removed.
1003 (synch_process_tempfile): New var or macro.
1004 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
1005 New constants.
1006 (record_kill_process): New arg, the temp name. All callers changed.
1007 (delete_temp_file): Now just a simple wrapper around unlink.
1008 (call_process_kill): New arg, the call_process_fd array.
1009 Close them all. Clear synch_process_pid. Remove the temp file,
1010 or arrange for it to be removed.
1011 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
1012 that's been moved to synch_process_tempfile. Caller changed.
1013 Do not remove the tempfile; that's now call_process_kill's
1014 responsibility.
1015 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
1016 call_process_kill; the caller now does that.
1017 (call_process_cleanup): Do not close the process fd; that's now
1018 call_process_kill's responsibility.
1019 (Fcall_process): Implement via new function call_process, which
1020 has most of the old body of Fcall_process, but with a different API.
1021 (call_process): New function that does not open or close filefd if
1022 it is nonnegative. Record which fds need to be closed, and let
1023 call_process_kill close (and remove the tempfile, on MSDOS) on error.
1024 Signal an error if invoked recursively (could be done via a hook).
1025 Simplify creation of the tempfile in the MSDOS case.
1026 Don't create the output file until after checking for the executable.
1027 Report any failure to open /dev/null.
1028 Don't open /dev/null for writing twice; once is enough.
1029 Don't create pipe if all output is being discarded or sent to file.
1030 Don't worry about setting up the coding system or reading from the
1031 pipe if all output is being discarded.
1032 Hoist fd_error local into top level, to lessen block nesting.
1033 Don't record deleted pid here; now done by Fcall_process_region.
1034 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
1035 and note its success in synch_process_tempfile.
1036 Do not leak resources when child_setup fails.
1037 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
1038 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
1039 (create_temp_file): Now returns open fd, with an additional
1040 Lisp_Object * argument to return the name. All callers changed.
1041 Do not close the file; rewind it instead, and leave it open for
1042 the caller. Do not lock the temp file. Unwind-protect the file
1043 and the file-descriptor.
1044 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
1045 If an asynchrounous process, record it here, not in call_process.
1046 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
1047 * eval.c (set_unwind_protect): New function.
1048 * fileio.c (write_region): New function, generalized from the
1049 old Fwrite_region. Do not lock temp files.
1050 (Fwrite_region): Use it.
1051 * lisp.h (set_unwind_protect, write_region): New decls.
1052 * process.c: Include <verify.h>.
1053 (make_process): Mark fds as initially closed.
1054 (deleted_pid_list): Now a list of pid-filename pairs.
1055 All uses changed.
1056 (close_process_fd): New function.
1057 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
1058 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
1059 New constants. Verify that their number matches PROCESS_OPEN_FDS.
1060 (create_process, create_pty, Fmake_serial_process)
1061 (server_accept_connection): Record which fds need to be closed,
1062 and let deactivate_process close them.
1063 (Fmake_network_process): Do not discard the unwind-protect
1064 until it's safe to do so.
1065 (deactivate_process): Close the fds opened by create_process etc.
1066 (Fprocess_send_eof): Adjust to new way of recording open fds.
1067 Report an error if /dev/null can't be opened, instead of aborting.
1068 * process.h (PROCESS_OPEN_FDS): New constant.
1069 (struct Lisp_Process): New member open_fds.
1070 (record_kill_process, record_deleted_pid): Adjust signatures.
1071 (record_deleted_pid): Move decl here ...
1072 * syswait.h (record_deleted_pid): ... from here.
1073
d0e615c3
PE
10742013-08-11 Paul Eggert <eggert@cs.ucla.edu>
1075
1076 * decompress.c: Fix bugs with large buffers and weird inputs.
1077 Tune a bit. Reindent as per usual Emacs style.
1078 (BUFFER_SIZE): Remove.
1079 (Fdecompress_gzipped_region): Do not mishandle input buffers with
1080 more than UINT_MAX bytes. Decompress into the gap instead of into
1081 an auto buffer, as this should avoid copying. Return nil if
1082 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
1083 set immediate_quit; we shouldn't trust zlib code that much.
1084
313546eb
LMI
10852013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1086
99a32242
LMI
1087 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
1088 errors, and really move the gap to where we want it.
1089
313546eb
LMI
1090 * lisp.h: Include decompress.c support.
1091
1092 * emacs.c (main): Include decompress.c support.
1093
1094 * Makefile.in: Include -lz if present.
1095
d2d699ac
JD
10962013-08-11 Jan Djärv <jan.h.d@swipnet.se>
1097
f90e3ebd
JD
1098 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
1099 (initWithTitle:): Initialize frame to 0.
1100 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
068f9124 1101 (fillWithWidgetValue:frame:): Rename from
f90e3ebd
JD
1102 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
1103
1104 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
1105 fillWithWidgetValue:frame:
1106
423d3b3f
JD
1107 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
1108 remove memory leak warnings.
1109
d2d699ac
JD
1110 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
1111 (ns_check_menu_open): Handle menu == nil. Remove assignment to
1112 menu_pending_title.
1113
1114 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
1115 (x_activate_menubar): Update the whole menu.
1116 (trackingNotification:): Call ns_check_menu_open if tracking ends.
1117 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
1118 current event is not NSSystemDefined (Bug#15001).
1119 Call ns_check_menu_open only if trackingMenu is 2.
1120 (menuDidClose:): New method, decrease trackingMenu.
1121 (fillWithWidgetValue:setDelegate:): New method.
1122 (fillWithWidgetValue:): Call the above.
1123
1124 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
1125
7d652d97
PE
11262013-08-11 Paul Eggert <eggert@cs.ucla.edu>
1127
1128 Omit some unnecessary casts.
1129 Many of these go back to the old pre-C89 days, when they may have
1130 been needed, but we've been assuming C89 or later for a while now.
1131 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
1132 (live_float_p, live_misc_p, live_vector_p):
1133 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
1134 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
1135 (defvar_per_buffer):
1136 * callint.c (Fcall_interactively):
1137 * doc.c (Fsubstitute_command_keys):
1138 * filelock.c (get_boot_time):
1139 * frame.c (xrdb_get_resource):
1140 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
1141 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
1142 (xg_get_file_name_from_selector, menuitem_destroy_callback)
1143 (menuitem_highlight_callback, menu_destroy_callback)
1144 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
1145 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
1146 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
1147 (xg_tool_bar_help_callback, tb_size_cb):
1148 * image.c (xpm_alloc_color, png_read_from_memory)
1149 (png_read_from_file, png_load_body, our_memory_skip_input_data)
1150 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
1151 (syms_of_image):
1152 * keymap.c (describe_map):
1153 * nsfns.m (Fns_display_monitor_attributes_list):
1154 * nsmenu.m (process_dialog:):
1155 * nsterm.m (hold_event):
1156 * process.c (wait_reading_process_output):
1157 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
1158 * scroll.c (do_direct_scrolling, scrolling_1):
1159 * termcap.c (tgetent):
1160 * window.c (check_window_containing, add_window_to_list)
1161 (freeze_window_starts):
1162 * xdisp.c (compare_overlay_entries, vmessage):
1163 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
1164 (x_get_monitor_attributes_xrandr)
1165 (Fx_display_monitor_attributes_list, x_display_info_for_name)
1166 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
1167 * xfont.c (xfont_match, xfont_open):
1168 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
1169 (menubar_selection_callback, menu_position_func)
1170 (popup_selection_callback, create_and_show_popup_menu)
1171 (dialog_selection_callback, create_and_show_dialog):
1172 * xrdb.c (x_get_string_resource):
1173 (main) [TESTRM]:
1174 * xsmfns.c (x_session_check_input):
1175 * xterm.c (x_draw_glyphless_glyph_string_foreground)
1176 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
1177 (xaw_jump_callback, xaw_scroll_callback):
1178 Omit unnecessary casts.
1179
9acc1074
PE
11802013-08-10 Paul Eggert <eggert@cs.ucla.edu>
1181
1182 Minor string-length refactoring.
1183 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
1184 * frame.c (make_monitor_attribute_list):
1185 Prefer build_string to strlen + make_string.
1186
361c0eb8
JD
11872013-08-10 Jan Djärv <jan.h.d@swipnet.se>
1188
1189 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
1190 don't check minor_code (Bug#14417).
1191
14ba0822
EZ
11922013-08-09 Eli Zaretskii <eliz@gnu.org>
1193
1194 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
1195 vertical positions instead. This avoids calling MATRIX_ROW with
1196 row numbers that are possibly beyond valid limits. (Bug#15064)
1197
309f24d1
DA
11982013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
1199
1200 Use xstrdup and build_unibyte_string where applicable.
1201 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
1202 * xfns.c (x_window):
1203 * xrdb.c (x_get_customization_string):
1204 * xterm.c (xim_initialize):
1205 * w32fns.c (w32_window): Use xstrdup.
1206 (w32_display_monitor_attributes_list):
1207 * emacs.c (init_cmdargs):
1208 * keyboard.c (PUSH_C_STR):
1209 * nsfont.m (nsfont_open):
1210 * sysdep.c (system_process_attributes):
1211 * w32.c (system_process_attributes):
1212 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
1213
55902276
EZ
12142013-08-09 Eli Zaretskii <eliz@gnu.org>
1215
1216 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
1217 variables of these types so that GDB would know about them, as aid
1218 for debugging fatal exceptions. (Bug#15024) See also
1219 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
1220 discussions.
1221
10bf7f5a
JD
12222013-08-08 Jan Djärv <jan.h.d@swipnet.se>
1223
1224 * nsterm.m (ns_update_begin): Don't change clip path if it would be
1225 larger than the NSWindow (Bug#14934).
1226
65620264
DA
12272013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1228
1229 Redesign redisplay interface to drop global variable updated_window.
1230 Always pass currently updated window as a parameter to update routines.
1231 * dispextern.h (updated_window): Remove declaration.
1232 (struct redisplay_interface): Pass window parameter to
1233 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
1234 and after_update_window_hook.
1235 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
1236 Adjust prototypes.
1237 * dispnew.c (updated_window): Remove.
1238 (redraw_overlapped_rows, update_marginal_area, update_text_area)
1239 (update_window_line): Adjust to match redisplay interface changes.
1240 * nsterm.m (ns_update_window_begin, ns_update_window_end)
1241 (ns_scroll_run, ns_after_update_window_line):
1242 * w32term.c (x_update_window_begin, x_update_window_end)
1243 (x_after_update_window_line, x_scroll_run):
1244 * xterm.c (x_update_window_begin, x_update_window_end)
1245 (x_after_update_window_line, x_scroll_run):
1246 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1247 Likewise. Adjust comments where appropriate.
1248 (x_cursor_to): Simplify because this is always called during window
1249 update (but install debugging check anyway).
1250 (expose_window): Check must_be_updated_p flag to see whether this
1251 function is called during window update.
1252
628fdc56
DA
12532013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1254
1255 Do not reset window modification event counters excessively.
1256 These leftovers and poor man's tricky methods to catch extra
1257 redisplay's attention are no longer needed.
1258 * frame.c (set_menu_bar_lines_1):
1259 * minibuf.c (read_minibuf_unwind):
1260 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
1261 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
1262 (window_scroll_line_based, Fset_window_configuration):
1263 * xdisp.c (redisplay_window): Do not reset last_modified and
1264 last_overlay_modified counters.
1265
8fd9c92e
JD
12662013-08-07 Jan Djärv <jan.h.d@swipnet.se>
1267
1268 * xselect.c (x_send_client_event): Set send_event and serial, memset
1269 data.l as it might be bigger than data.b. Use 24 bit mask to
1270 XSendEvent (Bug#15034).
1271
0ee18172
EZ
12722013-08-07 Eli Zaretskii <eliz@gnu.org>
1273
1274 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
1275 for TTY frames that are not the top frame on their console.
1276 (Bug#14616)
1277
16ddd1a6
MR
12782013-08-07 Martin Rudalics <rudalics@gmx.at>
1279
1280 * w32term.c (w32fullscreen_hook): Really maximize frame when
1281 asked for (Bug#14841).
1282
d2a95ffb
DA
12832013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1284
1285 Prefer selected_window to Fselected_window, likewise for frames.
1286 * buffer.c (Fbuffer_swap_text):
1287 * data.c (Fvariable_binding_locus):
1288 * window.c (run_window_configuration_change_hook): Adjust users.
1289 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
1290 Use decode_live_frame.
1291
170da1ec
DA
12922013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1293
1294 Be more careful if selected window shows the buffer other than current,
1295 use window_outdated only if this is not so. This change should also
1296 address some weird issues discussed in Bug#13012.
1297 * window.h (window_outdated): New prototype.
1298 * window.c (window_outdated): Now here. Convert from static and
1299 always assume window's buffer.
1300 (Fwindow_end, Fwindow_line_height): Use it.
1301 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
1302 and always assume window's buffer.
1303 (redisplay_window): Adjust user.
e5eefe9b 1304 (redisplay_internal): Call to reconsider_clip_changes once and
170da1ec
DA
1305 check whether mode line should be updated only if selected window
1306 shows current buffer.
1307 (run_window_scroll_functions): Use eassert for debugging check.
1308 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
1309
56b5d5b1
DA
13102013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1311
1312 * window.c (window_scroll, window_scroll_pixel_based)
1313 (window_scroll_line_based): Use bool for booleans.
1314
2878ba7e
PE
13152013-08-06 Paul Eggert <eggert@cs.ucla.edu>
1316
1317 * process.c: Fix minor off-by-one issues in descriptor counts.
1318 This shouldn't fix any real bugs, but it cleans up the code a bit.
1319 (max_process_desc, max_input_desc): -1, not 0, means none.
1320 All uses changed.
1321 (delete_input_desc): New function.
1322 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
1323 (deactivate_process): Scan backwards when recomuting max_process_desc;
1324 that should be faster.
1325 (init_process_emacs): Initialize max_input_desc.
1326
e30b79c1
DA
13272013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1328
1329 Use region cache to speedup bidi_find_paragraph_start.
1330 * buffer.h (struct buffer): New member bidi_paragraph_cache.
1331 Rename cache_long_line_scans to cache_long_scans.
1332 * buffer.c (bset_cache_long_line_scans): Rename to
1333 bset_cache_long_scans.
1334 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
1335 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
1336 into account.
1337 (syms_of_buffer): Rename cache-long-line-scans to
1338 cache-long-scans. Adjust docstring.
1339 * search.c (newline_cache_on_off):
1340 * indent.c (width_run_cache_on_off): Adjust users.
1341 * bidi.c (bidi_paragraph_cache_on_off): New function.
1342 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
068f9124
SM
1343 * insdel.c (prepare_to_modify_buffer):
1344 Invalidate bidi_paragraph_cache if enabled.
e30b79c1 1345
00012b86
DA
13462013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1347
1348 Invalidate region caches only if buffer text is going to be changed.
1349 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
1350 (modify_text): ...new prototype.
1351 (prepare_to_modify_buffer_1): New prototype.
1352 * textprop.c (modify_region): Rename to...
1353 (modify_text_properties): ...new function.
1354 (add_text_properties_1, set_text_properties, Fremove_text_properties)
1355 (Fremove_list_of_text_properties): Adjust users.
1356 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
1357 (modify_text): ...new function.
1358 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
1359 (prepare_to_modify_buffer_1): ...new function.
1360 * casefiddle.c (casify_region):
1361 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
1362 (Ftranspose_regions): Use modify_text.
1363
dc6c0eda
SM
13642013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
1365
1366 * lisp.mk (lisp): Add nadvice.elc.
1367
8f3a2c26
DA
13682013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
1369
1370 New macro to iterate over live buffers similar to frames.
1371 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
1372 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
1373 Declare buffer-related variables here to offload lisp.h.
1374 * buffer.c (Vbuffer_alist): Adjust comment.
1375 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
1376 (other_buffer_safely):
1377 * data.c (store_symval_forwarding):
1378 * dispnew.c (Fframe_or_buffer_changed_p):
1379 * fileio.c (Fdo_auto_save):
1380 * filelock.c (unlock_all_files):
1381 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
1382
e0fdb694
PE
13832013-08-04 Paul Eggert <eggert@cs.ucla.edu>
1384
1385 Fix some minor races in hosts lacking mkostemp (Bug#15015).
1386 * callproc.c (create_temp_file):
1387 * filelock.c (create_lock_file):
1388 Assume mkostemp, since it's now provided by Gnulib.
1389
63f5c6c2
EZ
13902013-08-04 Eli Zaretskii <eliz@gnu.org>
1391
1392 * w32.c (mkostemp): New function.
1393 (mktemp): Remove, no longer used. Most of the code reused in
1394 mkostemp. (Bug#15015)
484ab239 1395 (mktemp): Don't undef.
63f5c6c2 1396
f0b79313
DA
13972013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
1398
1399 * dispnew.c (glyph_matrix_count, glyph_pool_count):
1400 Move under GLYPH_DEBUG and ENABLE_CHECKING.
1401 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
1402 (free_glyph_pool, check_glyph_memory): Likewise for
1403 all users. Adjust comments where appropriate.
1404
98f638d6
PE
14052013-08-03 Paul Eggert <eggert@cs.ucla.edu>
1406
1407 * composite.h: Minor fixups.
1408 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
1409 to fix a misspelling, and change it to an inline function while
1410 we're at it (it need not be a macro). All uses changed.
1411 (composition_method, composition_valid_p):
1412 Rewrite to avoid assignments in if-conditions.
1413
75c59fb3
DA
14142013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
1415
1416 Do not use global Lisp_Object in composition macros.
1417 * composite.h (composition_temp): Remove declaration.
1418 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
1419 (composition_method, composition_valid_p): ...inline functions.
416a3e01 1420 (compose_region): Remove the leftover.
75c59fb3
DA
1421 * composite.c (composition_temp): Remove.
1422 (run_composition_function, update_compositions)
1423 (composition_compute_stop_pos, composition_adjust_point)
1424 (Ffind_composition_internal):
1425 * coding.c (handle_composition_annotation):
1426 * xdisp.c (handle_composition_prop, check_point_in_composition):
1427 Related users changed.
1428
a10c8269
DA
14292013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
1430
1431 Drop FRAME_PTR typedef.
1432 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
1433 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
1434 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
1435 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
1436 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
1437 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
1438 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
1439 All related users changed.
1440
a104f656
SM
14412013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1442
1443 * eval.c (default_toplevel_binding): New function.
1444 (Fdefvar): Use it.
1445 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
1446 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
1447 (syms_of_eval): Export them.
1448 * data.c (Fdefault_value): Micro cleanup.
1449 * term.c (init_tty): Use "false".
1450
4b5c9326
DA
14512013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1452
1453 Fix X GC leak in GTK and raw (no toolkit) X ports.
1454 * xterm.c (x_free_frame_resources): If white and black relief
1455 GCs are allocated, always free them here.
1456 * xfns.c (x_make_gc): Omit redundant initialization.
1457 * widget.c (create_frame_gcs): Remove the leftover.
1458 (EmacsFrameDestroy): Do nothing because all GCs are now freed
1459 in x_free_frame_resources.
1460
b19aa636
JD
14612013-08-02 Jan Djärv <jan.h.d@swipnet.se>
1462
1463 * nsterm.m (windowWillResize:toSize:): Only change title if
1464 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
1465 modifying it.
1466 (viewDidEndLiveResize): New method.
1467
1468 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
1469 inside NS_IMPL_COCOA.
1470
af1f7e06
DA
14712013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1472
1473 * insdel.c (adjust_after_replace, replace_range, del_range_2):
1474 Do not check whether undo is enabled because record_insert and
1475 record_delete does that themselves.
1476
65b02bb9
DA
14772013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1478
1479 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
1480 member which is not really used any more.
1481 (FRAME_XIC_BASE_FONTNAME): Remove.
1482 * xfns.c (xic_free_fontset): Adjust user.
1483 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
1484 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
1485 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
1486 (xdialog_show): Use eassert for debugging check.
7ee0f047 1487 * w32term.c (x_unfocus_frame): Remove unused dummy function.
65b02bb9 1488
6318cde0
PE
14892013-08-01 Paul Eggert <eggert@cs.ucla.edu>
1490
1491 * fileio.c, fns.c (merge): Move extern decl from here ...
1492 * lisp.h (merge): ... to here.
1493
6c1a09ba
DA
14942013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1495
1496 Fix last font-related change.
1497 * w32font.h (w32font_list_internal, w32font_match_internal):
1498 Fix prototype.
1499 * w32uniscribe.c (uniscribe_list, uniscribe_match):
1500 (uniscribe_list_family): Adjust to match font API change.
1501 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
1502 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
1503
f8c20208
DA
15042013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1505
1506 * frame.h (FRAME_MOUSE_UPDATE):
1507 * nsterm.m (ns_frame_up_to_date): Omit redundant check
1508 whether hlinfo->mouse_face_mouse_frame is non-NULL.
1509
fdb396e2
DA
15102013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1511
1512 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
1513 * font.h (struct font_driver): Change list, match, and list_family
1514 functions to accept struct frame * as first arg.
068f9124
SM
1515 * font.c (font_score, font_compare, font_sort_entities):
1516 Remove prototypes.
fdb396e2
DA
1517 (font_sort_entities, font_list_entities, font_select_entity):
1518 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
1519 match font API change.
1520 * xfont.c (xfont_list, xfont_match, xfont_list_family):
1521 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
1522 * ftxfont.c (ftxfont_list, ftxfont_match):
1523 * xftfont.c (xftfont_list, xftfont_match):
1524 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
1525 * w32font.c (w32font_list, w32font_match, w32font_list):
1526 (w32font_list_internal, w32_font_match_internal): Likewise.
1527 * xfaces.c (Fx_family_fonts): Adjust user.
1528
52b8a085
DA
15292013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1530
1531 Do not use pure Xism x_wm_set_icon_position in non-X ports.
1532 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
1533 only if HAVE_X_WINDOWS is in use.
1534 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
1535 * nsterm.m (x_wm_set_icon_position): Remove no-op.
1536 * w32term.c (x_wm_set_icon_position): Likewise.
1537 * w32fns.c (x_icon): Adjust user.
1538
c791c18e
DA
15392013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1540
1541 * xterm.c (last_mouse_press_frame): Remove the
1542 leftover which is not really used any more.
1543 (handle_one_xevent, syms_of_xterm): Adjust users.
1ca6cc28
DA
1544 (x_flush): Call XFlush once per each X display, not frame.
1545 This is better because this code always unconditionally skips
1546 non-X frames in Vframe_list and issues the only XFlush if we
1547 have more than one X frame on the same X display.
2f935d86
DA
1548 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
1549 Use bool for booleans.
1550 (x_draw_glyph_string_background, cvt_string_to_pixel):
1551 (cvt_pixel_dtor): Drop unnecessary prototypes.
1552 * xterm.h (x_display_ok): Adjust prototype.
c791c18e 1553
f435830e
DA
15542013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1555
1556 Drop unnecessary functions that deals with frame pixel size.
1557 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
1558 (x_pixel_height): Drop prototypes.
1559 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
1560 (x_pixel_height): Drop implementations.
1561 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
1562 which should be always valid for window frame.
1563 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
1564 * w32menu.c (Fx_popup_dialog):
1565 * xmenu.c (Fx_popup_dialog): Likewise for both.
1566
84231434
DA
15672013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1568
1569 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
1570 frame parameters and call to Fmodify_frame_parameters just once.
4c131798
DA
1571 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
1572 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
1573 and mention nil frame in docstring.
84231434 1574
959067a1
DA
15752013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1576
1577 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
1578 (x_figure_window_size): Likewise. Adjust to return long.
1579 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
1580 (toplevel): Move Qterminal_live_p to...
1581 * terminal.c (toplevel): ...here, make it static, and...
1582 (syms_of_terminal): ...DEFSYM here.
1583 * frame.h (Qterminal_live_p): Remove declaration.
1584 (make_frame, x_figure_window_size): Adjust prototype.
1585 * nsfns.m (Fx_create_frame): Use long for window flags.
1586
f4b169ce
PE
15872013-07-30 Paul Eggert <eggert@cs.ucla.edu>
1588
1589 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
1590 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
1591 Do not assume that emacs_close (INT_MAX) is a no-op.
1592
bee6a2c7
DA
15932013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1594
1595 * xfaces.c (make_face_cache): For struct face_cache, prefer
1596 xmalloc to xzalloc and so avoid redundant call to memset.
1597 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
1598
d7e6881a
DA
15992013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1600
1601 * fringe.c (draw_window_fringes, update_window_fringes)
1602 (compute_fringe_widths):
1603 * w32term.c (x_draw_glyph_string):
1604 * window.c (candidate_window_p, Frecenter):
1605 * xfaces.c (realize_basic_faces, realize_default_face)
1606 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
1607 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
1608 * xfns.c (x_set_cursor_color, xic_free_xfontset):
1609 * xmenu.c (Fx_menu_bar_open_internal):
1610 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
1611 * xsettings.c (xft_settings_event):
1612 * xterm.c (x_draw_glyph_string, x_had_errors_p):
1613 Use bool for booleans. Adjust style and comments where
1614 appropriate.
1615 * dispextern.h (draw_window_fringes, update_window_fringes)
1616 (compute_fringe_widths):
1617 * xterm.h (x_had_errors_p): Adjust prototype.
1618
ec3058af
DA
16192013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1620
1621 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
1622 CHECK_LIST. Rewrite the loop to avoid useless local variable.
1623
218e0637
DA
16242013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
1625
1626 * fns.c (toplevel): Remove comment before Fsafe_length because
1627 it checks for QUIT.
1628
e560aba9
PE
16292013-07-28 Paul Eggert <eggert@cs.ucla.edu>
1630
1631 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
1632
2e5ce5de
EZ
16332013-07-28 Eli Zaretskii <eliz@gnu.org>
1634
1635 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
1636 frame which got the message is still alive, before dereferencing
1637 its pointer. (Bug#14970)
1638
1639 * frame.c (delete_frame): Test "this" frame's minibuffer window to
1640 be a live window, before using it as such. (Bug#14970)
1641
e95da6d3
EZ
16422013-07-27 Eli Zaretskii <eliz@gnu.org>
1643
1644 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
1645 w32_detect_focus_change instead of doing part of its job by hand.
1646 This fixes the problem whereby FOCUS_OUT events were not sent to
1647 the event queue.
1648
a8f93651
EZ
16492013-07-26 Eli Zaretskii <eliz@gnu.org>
1650
fec92060
EZ
1651 * process.c (Fprocess_list): Doc fix.
1652
a8f93651
EZ
1653 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
1654 being re-exposed only if it didn't ask to become visible.
1655 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
1656 was previously iconified. (Bug#14841)
1657 (x_iconify_frame): Mark the frame iconified.
1658
d5a7a9d9
PE
16592013-07-26 Paul Eggert <eggert@cs.ucla.edu>
1660
1661 Fix minor problems found by static checking.
1662 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
1663 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
1664
56ea7291
SM
16652013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
1666
1667 * eval.c (set_specpdl_old_value): New function.
1668 (unbind_to): Minor simplification.
1669 (get_backtrace_frame): New function.
1670 (Fbacktrace_frame): Use it. Add `base' argument.
1671 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
1672 (syms_of_eval): Export backtrace-eval.
1673 * xterm.c (x_focus_changed): Simplify.
1674
9d611ffe
PE
16752013-07-25 Paul Eggert <eggert@cs.ucla.edu>
1676
1677 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
1678
999c74e3
EZ
16792013-07-24 Eli Zaretskii <eliz@gnu.org>
1680
1681 * xdisp.c (redisplay_window): Instead of moving point out of
1682 scroll margin, reject the force_start method, and try scrolling
1683 instead. (Bug#14780)
1684
198fa217
KB
16852013-07-24 Ken Brown <kbrown@cornell.edu>
1686
1687 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
1688 (Bug#14944).
1689
53840e55
PE
16902013-07-24 Paul Eggert <eggert@cs.ucla.edu>
1691
1692 * eval.c (Fprogn): Do not check that BODY is a proper list.
1693 This undoes the previous change. The check slows down the
1694 interpreter, and is not needed to prevent a crash. See
1695 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
1696
60967f56
GM
16972013-07-23 Glenn Morris <rgm@gnu.org>
1698
1699 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
1700
9ca960e2
PE
17012013-07-23 Paul Eggert <eggert@cs.ucla.edu>
1702
a29c3e6d
PE
1703 Port to GNU/Linux systems with tinfo but not ncurses.
1704 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
1705 to decide whether ncurses is being used. Without this change,
1706 GCC complains about tgetent not being declared, on a system
1707 that has tinfo installed but ncurses not installed.
1708
f274311c
PE
1709 * eval.c (Fprogn): Check that BODY is a proper list.
1710
16b0520a
PE
1711 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
1712 * data.c (Fsetq_default):
1713 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
1714 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
1715 (Fcondition_case):
1716 Tune by taking advantage of the fact that ARGS is always a list
1717 when a function is declared to have UNEVALLED args.
1718
9ca960e2
PE
1719 * emacsgtkfixed.c: Port to GCC 4.6.
1720 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
1721
afacaa1b
JB
17222013-07-23 Juanma Barranquero <lekktu@gmail.com>
1723
1724 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
1725 here to silence compiler warnings.
1726
368a85a4
PE
17272013-07-22 Paul Eggert <eggert@cs.ucla.edu>
1728
1729 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
1730 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
1731 from messing up Emacs's 'struct frame' (Bug#14923).
1732
f4e891b5
PE
17332013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1734
1735 * alloc.c (make_save_ptr_ptr): Define this function.
1736 It was inadvertently omitted. It's needed only if
1737 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
1738
96c8b65e
JD
17392013-07-21 Jan Djärv <jan.h.d@swipnet.se>
1740
1741 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
1742 frame have focus (Bug#14895).
1743
ee010797
PE
17442013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1745
1746 Avoid vfork-related deadlock more cleanly.
1747 * callproc.c (child_setup): When the child's exec fails, output
1748 the program name, as that's more useful. Use O_NONBLOCK to avoid
1749 deadlock.
1750 * process.c (create_process_1): Remove; no longer needed.
1751 (create_process): Remove timer hack; no longer needed, now that
1752 the child avoids deadlock.
1753
f0398ec1 17542013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
1755
1756 * image.c (Fimage_flush): Fix doc typo.
1757
b2a069c2
PE
17582013-07-20 Paul Eggert <eggert@cs.ucla.edu>
1759
6496aec9
PE
1760 Fix array bounds violation when pty allocation fails.
1761 * process.c (PTY_NAME_SIZE): New constant.
1762 (pty_name): Remove static variable; it's now auto.
1763 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
1764 Take pty_name as an arg rather than using a static variable.
1765 All callers changed.
1766 (create_process): Recover pty_flag from process, not from volatile local.
1767 (create_pty): Stay inside array even when pty allocation fails.
1768 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
1769
b2a069c2
PE
1770 * lread.c (Fload): Avoid initialization only when lint checking.
1771 Mention that it's needed only for older GCCs.
1772
99107004
KH
17732013-07-20 Kenichi Handa <handa@gnu.org>
1774
1775 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
1776 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
1777
6b1b199d
AS
17782013-07-20 Andreas Schwab <schwab@linux-m68k.org>
1779
1780 * lread.c (Fload): Avoid uninitialized warning.
1781
4195afc3
PE
17822013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1783
3f5bef16
PE
1784 Fix some minor file descriptor leaks and related glitches.
1785 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
1786 (create_lock_file): Use write, not emacs_write.
1787 * image.c (slurp_file, png_load_body):
1788 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
1789 (server_accept_connection):
1790 Don't leak an fd on memory allocation failure.
1791 * image.c (slurp_file): Add a cheap heuristic for growing files.
1792 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
1793 as that's what the other routines do. Maybe input need not be
1794 blocked at all, but it's better to be consistent.
1795 Avoid undefined behavior when strlen is zero.
1796
4195afc3
PE
1797 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
1798 (NSTATICS): Now a constant; doesn't need to be a macro.
1799
a1aeeffe
RS
18002013-07-19 Richard Stallman <rms@gnu.org>
1801
1802 * coding.c (decode_coding_utf_8): Add simple loop for fast
1803 processing of ASCII characters.
1804
63b34baa
PE
18052013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1806
1807 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
1808
621dd9ac
EZ
18092013-07-19 Eli Zaretskii <eliz@gnu.org>
1810
1811 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
1812 unportable 'struct x_display_info'.
1813 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
1814 is a portable type.
1815
1396ac86
PE
18162013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1817
ab9980cd
PE
1818 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
1819 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
1820 or fscanf fails.
1821 (system_process_attributes): Prefer plain char to unsigned char
1822 when either will do. Clean up properly if interrupted or if
068f9124
SM
1823 memory allocations fail. Don't assume sscanf succeeds.
1824 Remove no-longer-needed workaround to stop GCC from whining.
1825 Read command-line once, instead of multiple times. Check read status a
ab9980cd
PE
1826 bit more carefully.
1827
1396ac86
PE
1828 Fix obscure porting bug with varargs functions.
1829 The code assumed that int is treated like ptrdiff_t in a vararg
1830 function, which is not a portable assumption. There was a similar
1831 -- though these days less likely -- porting problem with various
1832 assumptions that pointers of different types all smell the same as
1833 far as vararg functions is conserved. To make this problem less
1834 likely in the future, redo the API to use varargs functions.
1835 * alloc.c (make_save_value): Remove this vararg function.
1836 All uses changed to ...
1837 (make_save_int_int_int, make_save_obj_obj_obj_obj)
1838 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
1839 New functions.
1840 (make_save_ptr): Rename from make_save_pointer, for consistency with
1841 the above. Define only on platforms that need it. All uses changed.
1842
4d19d194
PE
18432013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1844
1845 * keyboard.c: Try to fix typos in previous change.
1846 (DISPLAY_LIST_INFO): New macro.
1847 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 1848 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 1849
945c5bb1
JB
18502013-07-18 Juanma Barranquero <lekktu@gmail.com>
1851
1852 * keyboard.c (kbd_buffer_get_event):
1853 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
1854 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
1855
f4b1eb36
PE
18562013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1857
5e679a2c
PE
1858 * filelock.c: Fix unlikely file descriptor leaks.
1859 (get_boot_time_1): Rework to avoid using emacs_open.
1860 This doesn't actually fix a leak, but is better anyway.
1861 (read_lock_data): Use read, not emacs_read.
1862
a8cd4836
PE
1863 * doc.c: Fix minor memory and file descriptor leaks.
1864 * doc.c (get_doc_string): Fix memory leak when doc file absent.
1865 (get_doc_string, Fsnarf_documentation):
1866 Fix file descriptor leak on error.
1867
ef30e638
PE
1868 * term.c: Fix minor fdopen-related file descriptor leaks.
1869 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
1870 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
1871
f4b1eb36
PE
1872 * charset.c: Fix file descriptor leaks and errno issues.
1873 Include <errno.h>.
1874 (load_charset_map_from_file): Don't leak file descriptor on error.
1875 Use plain record_xmalloc since the allocation is larger than
1876 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
1877 of entries.
1878 * eval.c (record_unwind_protect_nothing):
1879 * fileio.c (fclose_unwind):
1880 New functions.
1881 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
1882 The replacement doesn't block input, but that no longer seems
1883 necessary.
1884
b648c163
PE
18852013-07-17 Paul Eggert <eggert@cs.ucla.edu>
1886
a0931322
PE
1887 * lread.c: Fix file descriptor leaks and errno issues.
1888 (Fload): Close some races that leaked fds or streams when 'load'
1889 was interrupted.
1890 (Fload, openp): Report error number of last nontrivial failure to open.
1891 ENOENT counts as trivial.
1892 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
1893 New functions.
1894 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
1895 now that the function is always called with a nonnegative arg.
1896 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
1897 All uses replaced with ...
1898 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
1899
b648c163
PE
1900 A few more minor file errno-reporting bugs.
1901 * callproc.c (Fcall_process):
1902 * doc.c (Fsnarf_documentation):
1903 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
1904 * process.c (set_socket_option):
1905 Don't let a constructor trash errno.
1906 * doc.c: Include <errno.h>.
1907
b1dc4084
JB
19082013-07-16 Juanma Barranquero <lekktu@gmail.com>
1909
1910 * w32fns.c (unwind_create_tip_frame): Fix declaration.
1911
c43843aa
PE
19122013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1913
50a30cce
PE
1914 Fix w32 bug with call-process-region (Bug#14885).
1915 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
1916 to Fcall_process when the input is empty. This simplifies the
1917 code a bit. It makes no difference on POSIXish platforms but
1918 apparently it fixes a bug on w32.
1919
44e18199 1920 Fix bug where insert-file-contents closes a file twice (Bug#14839).
41d48a42
PE
1921 * fileio.c (close_file_unwind): Don't close if FD is negative;
1922 this can happen when unwinding a zapped file descriptor.
1923 (Finsert_file_contents): Unwind-protect the fd before the point marker,
1924 in case Emacs runs out of memory between the two unwind-protects.
1925 Don't trash errno when closing FD.
1926 Zap the FD in the specpdl when closing it, instead of deferring
1927 the removal of the unwind-protect; this fixes a bug where a child
1928 function unwinds the stack past us.
1929
27e498e6
PE
1930 New unwind-protect flavors to better type-check C callbacks.
1931 This also lessens the need to write wrappers for callbacks,
1932 and the need for make_save_pointer.
1933 * alloca.c (free_save_value):
1934 * atimer.c (run_all_atimers):
1935 Now extern.
1936 * alloc.c (safe_alloca_unwind):
1937 * atimer.c (unwind_stop_other_atimers):
1938 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
1939 * menu.c (cleanup_popup_menu) [HAVE_NS]:
1940 * minibuf.c (choose_minibuf_frame_1):
1941 * process.c (make_serial_process_unwind):
1942 * xdisp.h (pop_message_unwind):
1943 * xselect.c (queue_selection_requests_unwind):
1944 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
1945 * alloca.c (record_xmalloc):
1946 Prefer record_unwind_protect_ptr to record_unwind_protect with
1947 make_save_pointer.
1948 * alloca.c (Fgarbage_collect):
1949 Prefer record_unwind_protect_void to passing a dummy.
1950 * buffer.c (restore_buffer):
1951 * window.c (restore_window_configuration):
1952 * xfns.c, w32fns.c (do_unwind_create_frame)
1953 New wrapper. All record-unwind uses of wrappee changed.
1954 * buffer.c (set_buffer_if_live):
1955 * callproc.c (call_process_cleanup, delete_temp_file):
1956 * coding.c (code_conversion_restore):
1957 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
1958 * editfns.c (save_excursion_restore)
1959 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
1960 (save_restriction_restore):
1961 * eval.c (restore_stack_limits, un_autoload):
1962 * fns.c (require_unwind):
1963 * keyboard.c (recursive_edit_unwind, tracking_off):
1964 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
1965 * macros.c (pop_kbd_macro, restore_menu_items):
1966 * nsfns.m (unwind_create_frame):
1967 * print.c (print_unwind):
1968 * process.c (start_process_unwind):
1969 * search.c (unwind_set_match_data):
1970 * window.c (select_window_norecord, select_frame_norecord):
1971 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
1972 (fast_set_selected_frame):
1973 * xfns.c, w32fns.c (unwind_create_tip_frame):
1974 Return void, not a dummy Lisp_Object. All uses changed.
1975 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
1976 * callproc.c (call_process_kill):
1977 * fileio.c (restore_point_unwind, decide_coding_unwind)
1978 (build_annotations_unwind):
1979 * insdel.c (Fcombine_after_change_execute_1):
1980 * keyboard.c (read_char_help_form_unwind):
1981 * menu.c (unuse_menu_items):
1982 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
1983 * sound.c (sound_cleanup):
1984 * xdisp.c (unwind_redisplay):
1985 * xfns.c (clean_up_dialog):
1986 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
1987 Accept no args and return void, instead of accepting and returning
1988 a dummy Lisp_Object. All uses changed.
1989 * cygw32.c (fchdir_unwind):
1990 * fileio.c (close_file_unwind):
1991 * keyboard.c (restore_kboard_configuration):
1992 * lread.c (readevalllop_1):
1993 * process.c (wait_reading_process_output_unwind):
1994 Accept int and return void, rather than accepting an Emacs integer
1995 and returning a dummy object. In some cases this fixes an
1996 unlikely bug when the corresponding int is outside Emacs integer
1997 range. All uses changed.
1998 * dired.c (directory_files_internal_unwind):
1999 * fileio.c (do_auto_save_unwind):
2000 * gtkutil.c (pop_down_dialog):
2001 * insdel.c (reset_var_on_error):
2002 * lread.c (load_unwind):
2003 * xfns.c (clean_up_file_dialog):
2004 * xmenu.c, nsmenu.m (pop_down_menu):
2005 * xmenu.c (cleanup_widget_value_tree):
2006 * xselect.c (wait_for_property_change_unwind):
2007 Accept pointer and return void, rather than accepting an Emacs
2008 save value encapsulating the pointer and returning a dummy object.
2009 All uses changed.
2010 * editfns.c (Fformat): Update the saved pointer directly via
2011 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
2012 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
2013 (unwind_body): New function.
2014 (record_unwind_protect): First arg is now a function returning void,
2015 not a dummy Lisp_Object.
2016 (record_unwind_protect_ptr, record_unwind_protect_int)
2017 (record_unwind_protect_void): New functions.
2018 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
2019 * fileio.c (struct auto_save_unwind): New type.
2020 (do_auto_save_unwind): Use it.
2021 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
2022 * insdel.c (struct rvoe_arg): New type.
2023 (reset_var_on_error): Use it.
2024 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
2025 New constants.
2026 (specbinding_func): Remove; there are now several such functions.
2027 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
2028 (set_unwind_protect_ptr): New function.
2029 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
2030
4e604a5d
PE
2031 Be simpler and more consistent about reporting I/O errors.
2032 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
2033 Say "Read error" and "Write error", rather than "I/O error", or
2034 "IO error reading", or "IO error writing", when a read or write
2035 error occurs.
2036 * process.c (Fmake_network_process, wait_reading_process_output)
2037 (send_process, Fprocess_send_eof, wait_reading_process_output):
2038 Capitalize diagnostics consistently. Put "failed foo" at the
2039 start of the diagnostic, so that we don't capitalize the
2040 function name "foo". Consistently say "failed" for such
2041 diagnostics.
2042 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
2043 All callers changed. This is so it can use report_file_error.
2044 * sysdep.c (serial_open, serial_configure): Capitalize I/O
2045 diagnostics consistently as above.
2046
a9757f6a
PE
2047 * fileio.c (report_file_errno): Fix errno reporting bug.
2048 If the file name is neither null nor a pair, package it up as a
2049 singleton list. All callers changed, both to this function and to
2050 report_file_error. This fixes a bug where the memory allocator
2051 invoked by list1 set errno so that the immediately following
2052 report_file_error reported the wrong errno value.
2053
c43843aa
PE
2054 Fix minor problems found by --enable-gcc-warnings.
2055 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
2056 * keyboard.c (kbd_buffer_get_event): Remove unused local.
2057
18c26d81
JD
20582013-07-16 Jan Djärv <jan.h.d@swipnet.se>
2059
2060 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
2061 Set event->arg to Qt if switch-event shall be generated.
2062 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
2063
2064 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
2065
2066 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
2067 FOCUS_OUT_EVENT.
2068
2069 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
2070 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
2071 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
2072 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
44e18199 2073 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
18c26d81
JD
2074 and there is a focused frame.
2075 (head_table): Add focus-in and focus-out.
2076 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
2077 bind to handle-focus-in/out.
2078
2079 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
2080 (Fhandle_switch_frame): Call Fhandle_focus_in.
2081 (syms_of_frame): defsubr handle-focus-in/out.
2082
6c6f1994
PE
20832013-07-16 Paul Eggert <eggert@cs.ucla.edu>
2084
c7ddc792
PE
2085 Fix porting bug to older POSIXish platforms (Bug#14862).
2086 * sysdep.c (emacs_pipe): New function, that implements
2087 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
2088 This should port better to CentOS 5 and to Mac OS X 10.6.
2089 All calls to pipe2 changed.
2090
6c6f1994
PE
2091 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
2092 This makes the code easier to read and the executable a bit smaller.
2093 Do not replace all calls to Fcons that happen to create lists,
2094 just calls that are intended to create lists. For example, when
2095 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
2096 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
2097 Similarly for list2 through list5.
2098 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2099 * bytecode.c (exec_byte_code):
2100 * callint.c (quotify_arg, Fcall_interactively):
2101 * callproc.c (Fcall_process, create_temp_file):
2102 * charset.c (load_charset_map_from_file)
2103 (Fdefine_charset_internal, init_charset):
2104 * coding.c (get_translation_table, detect_coding_system)
2105 (Fcheck_coding_systems_region)
2106 (Fset_terminal_coding_system_internal)
2107 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
2108 * composite.c (update_compositions, Ffind_composition_internal):
2109 * dired.c (directory_files_internal, file_name_completion)
2110 (Fsystem_users):
2111 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
2112 * doc.c (Fsnarf_documentation):
2113 * editfns.c (Fmessage_box):
2114 * emacs.c (main):
2115 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
2116 (Feval, eval_sub, Ffuncall, apply_lambda):
2117 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
2118 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
2119 (Fset_file_times, Finsert_file_contents)
2120 (Fchoose_write_coding_system, Fwrite_region):
2121 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
2122 * font.c (font_registry_charsets, font_parse_fcname)
2123 (font_prepare_cache, font_update_drivers, Flist_fonts):
2124 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
2125 * frame.c (make_frame, Fmake_terminal_frame)
2126 (x_set_frame_parameters, x_report_frame_params)
2127 (x_default_parameter, Fx_parse_geometry):
2128 * ftfont.c (syms_of_ftfont):
2129 * image.c (gif_load):
2130 * keyboard.c (command_loop_1):
2131 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
2132 (Fcopy_keymap, append_key, Fcurrent_active_maps)
2133 (Fminor_mode_key_binding, accessible_keymaps_1)
2134 (Faccessible_keymaps, Fwhere_is_internal):
2135 * lread.c (read_emacs_mule_char):
2136 * menu.c (find_and_return_menu_selection):
2137 * minibuf.c (get_minibuffer):
2138 * nsfns.m (Fns_perform_service):
2139 * nsfont.m (ns_script_to_charset):
2140 * nsmenu.m (ns_popup_dialog):
2141 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
2142 (Fx_own_selection_internal):
2143 * nsterm.m (append2):
2144 * print.c (Fredirect_debugging_output)
2145 (print_prune_string_charset):
2146 * process.c (Fdelete_process, Fprocess_contact)
2147 (Fformat_network_address, set_socket_option)
2148 (read_and_dispose_of_process_output, write_queue_push)
2149 (send_process, exec_sentinel):
2150 * sound.c (Fplay_sound_internal):
2151 * textprop.c (validate_plist, add_properties)
2152 (Fput_text_property, Fadd_face_text_property)
2153 (copy_text_properties, text_property_list, syms_of_textprop):
2154 * unexaix.c (report_error):
2155 * unexcoff.c (report_error):
2156 * unexsol.c (unexec):
2157 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
2158 (Fformat_mode_line, syms_of_xdisp):
2159 * xfaces.c (set_font_frame_param)
2160 (Finternal_lisp_face_attribute_values)
2161 (Finternal_merge_in_global_face, syms_of_xfaces):
2162 * xfns.c (x_default_scroll_bar_color_parameter)
2163 (x_default_font_parameter, x_create_tip_frame):
2164 * xfont.c (xfont_supported_scripts):
2165 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
2166 (menu_help_callback, xmenu_show):
2167 * xml.c (make_dom):
2168 * xterm.c (set_wm_state):
2169 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
2170 and similarly for list2 through list5.
2171
bafe80ce
PE
21722013-07-15 Paul Eggert <eggert@cs.ucla.edu>
2173
2174 * callproc.c (Fcall_process_region): Fix minor race and tune.
2175 (create_temp_file): New function, with the temp-file-creation part
2176 of the old Fcall_process_region. Use Fcopy_sequence to create the
2177 temp file name, rather than alloca + build_string, for simplicity.
2178 Don't bother to block input around the temp file creation;
068f9124
SM
2179 shouldn't be needed. Simplify use of mktemp.
2180 Use record_unwind_protect immediately after creating the temp file;
bafe80ce
PE
2181 this closes an unlikely race where the temp file was not removed.
2182 Use memcpy rather than an open-coded loop.
2183 (Fcall_process_region): Use the new function. If the input is
2184 empty, redirect from /dev/null rather than from a newly created
2185 empty temp file; this avoids unnecessary file system traffic.
2186
4700b5a5
PE
21872013-07-14 Paul Eggert <eggert@cs.ucla.edu>
2188
5c97beae
PE
2189 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
2190 Simplify by making this case like the other two. This is a bit
2191 slower on obsolete hosts, but the extra complexity isn't worth it.
2192
4700b5a5
PE
2193 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
2194 * process.c (create_process) [!DOS_NT]:
2195 Remove now-unnecessary calls to emacs_close.
2196
f9a74c4c
EZ
21972013-07-13 Eli Zaretskii <eliz@gnu.org>
2198
922ae7ee
EZ
2199 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
2200 returning early. (Bug#14850)
2201
f9a74c4c
EZ
2202 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
2203 and inhibit-iso-escape-detection attributes of 'undecided'.
2204 (Bug#14822)
2205
5e301d76
PE
22062013-07-13 Paul Eggert <eggert@cs.ucla.edu>
2207
69e0e5ee
PE
2208 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
2209 Reported by Herbert J. Skuhra in
2210 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
2211
5e301d76
PE
2212 Don't lose top specpdl entry when memory is exhausted.
2213 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
2214 specpdl overflow here, to simplify callers; all callers changed.
2215 Always reserve an unused entry at the stack top; this avoids
2216 losing the top entry's information when memory is exhausted.
2217
7e649856
PE
22182013-07-12 Paul Eggert <eggert@cs.ucla.edu>
2219
a773ed9a
PE
2220 Clean up errno reporting and fix some errno-reporting bugs.
2221 * callproc.c (Fcall_process):
2222 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
2223 * process.c (create_process, Fmake_network_process):
2224 * unexaix.c (report_error):
2225 * unexcoff.c (report_error):
2226 Be more careful about reporting the errno of failed operations.
2227 The code previously reported the wrong errno sometimes.
2228 Also, prefer report_file_errno to setting errno + report_file_error.
2229 (Fcall_process): Look at openp return value rather than at path,
2230 as that's a bit faster and clearer when there's a numeric predicate.
2231 * fileio.c (report_file_errno): New function, with most of the
2232 old contents of report_file_error.
2233 (report_file_error): Use it.
2234 (Ffile_exists_p, Ffile_accessible_directory_p):
2235 Set errno to 0 when it is junk.
2236 * fileio.c (Faccess_file):
2237 * image.c (x_create_bitmap_from_file):
2238 Use faccessat rather than opening the file, to avoid the hassle of
2239 having a file descriptor open.
2240 * lisp.h (report_file_errno): New decl.
2241 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
2242
7e649856
PE
2243 Minor EBADF fixes.
2244 * process.c (create_process, wait_reading_process_output) [AIX]:
2245 Remove obsolete SIGHUP-related code, as Emacs no longer disables
2246 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
2247 a multithreaded environment anyway).
2248 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
2249
f6774c1a
AS
22502013-07-12 Andreas Schwab <schwab@linux-m68k.org>
2251
2252 * image.c (x_find_image_file): Don't close a remote file handle.
2253
bacba3c2
PE
22542013-07-12 Paul Eggert <eggert@cs.ucla.edu>
2255
2256 Fix races with threads and file descriptors.
2257 * callproc.c (Fcall_process_region):
2258 * dired.c (open_directory):
2259 * emacs.c (main, Fdaemon_initialized):
2260 * image.c (x_find_image_file):
2261 * inotify.c (Finotify_rm_watch):
2262 * lread.c (Flocate_file_internal):
2263 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
2264 * term.c (term_mouse_moveto, init_tty):
2265 * termcap.c (tgetent):
2266 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
2267 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
2268 * unexhp9k800.c, unexmacosx.c (unexec):
2269 * callproc.c (Fcall_process_region):
2270 Use emacs_close, not close.
2271 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
2272 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
2273 and posix_close function on current platforms (which all lack them).
2274 (emacs_close): Use it. This should fix the races on GNU/Linux and
2275 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
2276 and it should avoid closing random victim file descriptors on
2277 other platforms.
2278
653d4f43
PE
22792013-07-11 Paul Eggert <eggert@cs.ucla.edu>
2280
c8536ec4
PE
2281 * inotify.c (uninitialized): Remove. All uses replaced by -1.
2282 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
2283 Touch up doc a bit.
2284
9c203066
PE
2285 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
2286 This is for .gdbinit xbacktrace.
2287
653d4f43
PE
2288 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
2289 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
2290 (emacs_set_tty): Now static.
2291 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
2292 * term.c (tty_capable_p, tty_default_color_capabilities)
2293 (get_tty_terminal, term_mouse_movement)
2294 (handle_one_term_event, init_tty, maybe_fatal):
2295 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
2296 (tgetent, scan_file, name_match, compare_contin):
2297 * terminal.c (get_terminal):
2298 Use bool for boolean.
2299 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
2300 Prefer char to unsigned char if either will do.
2301 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
2302 (tty_write_glyphs): Prefer int to unsigned.
2303 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
2304 All callers changed.
2305 * termcap.c (tprint, main) [TEST]: Remove non-working test.
2306
45b683a1
PE
23072013-07-10 Paul Eggert <eggert@cs.ucla.edu>
2308
29abe551
PE
2309 Port to C89.
2310 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
2311 (B__dummy__): New dummy symbol, to pacify C89.
2312 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
2313 they can't grok varargs macros.
2314 * dispnew.c (add_window_display_history)
2315 (add_frame_display_history):
2316 * print.c (print_object):
2317 * xdisp.c (debug_method_add):
2318 Use %p printf format only for void pointers.
2319 * emacs.c (usage_message): New constant, replacing ...
2320 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
2321 (main): Adjust to usage reorg.
2322 * fns.c (syms_of_fns):
2323 * profiler.c (syms_of_profiler):
2324 Don't use non-constant struct initializers.
2325 * gnutls.h (gnutls_initstage_t):
2326 * lisp.h (enum Lisp_Fwd_Type):
2327 * lread.c (lisp_file_lexically_bound_p):
2328 * xsettings.c (anonymous enum):
2329 Remove trailing comma.
2330 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
2331 * lisp.h (ENUM_BF): Use unsigned if pedantic.
2332 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
2333 (DEFUN): Use it.
2334 * regex.c (const_re_char): New type, to pacify strict C89.
2335 All uses of 'const re_char' replaced to use it.
2336 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
2337 with glibc when strict C89. This change is imported from gnulib.
2338 All uses changed.
2339 (_Restrict_arr_): Rename from __restrict_arr, similarly.
2340 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
2341 Omit GNU_LINUX implementation, since it requires long long.
2342 * xterm.c (x_draw_underwave):
2343 Do not assume the traditional order of struct's members.
2344 (x_term_init): Rewrite to avoid the need for non-constant structure
2345 initializers.
2346
45b683a1 2347 Syntax cleanup, mostly replacing macros with functions.
763a086d 2348 This removes the need for the syntax_temp hack.
45b683a1
PE
2349 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
2350 * syntax.c (SYNTAX_INLINE): New macro.
2351 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
2352 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
2353 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
2354 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
2355 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
2356 (SYNTAX_COMEND_FIRST): Now functions, not macros.
2357 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
2358 Now constants, not macros.
2359 (syntax_temp) [!__GNUC__]: Remove.
2360 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
2361 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
2362 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
2363 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
2364 Move here from syntax.h; now functions, not macros. Except for the
2365 last function, these are static since only syntax.c uses them.
2366 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
2367 All uses changed. Now a function, not a macro; use this fact
2368 to simplify the code.
2369 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
2370 compiler bugs; no longer relevant.
2371 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2372 (SYNTAX_INLINE): New macro.
2373 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
2374 for the new functions. Use bool for boolean member.
2375 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
2376 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
2377 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
2378 (SETUP_BUFFER_SYNTAX_TABLE):
2379 Now extern inline functions, not macros.
2380 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
2381 Remove; all uses replaced by implementation.
2382 (syntax_temp) [!__GNUC__]: Remove decl.
2383 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
2384
29be4a50
JD
23852013-07-10 Jan Djärv <jan.h.d@swipnet.se>
2386
2387 * emacs.c (main): Fix syntax error.
2388
954b166e
PE
23892013-07-10 Paul Eggert <eggert@cs.ucla.edu>
2390
2391 Timestamp fixes for undo (Bug#14824).
2392 * atimer.c (schedule_atimer):
2393 * fileio.c (Ffile_newer_than_file_p):
2394 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
2395 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
2396 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
2397 (syms_of_fileio): Remove Sclear_visited_file_name.
2398 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
2399 file doesn't exist; this avoids an ambiguity with negative timestamps.
2400 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
2401 * systime.h (make_emacs_time, invalid_emacs_time):
2402 Don't assume struct timespec layout; POSIX doesn't guarantee it.
2403 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
2404 * undo.c (record_first_change): Push (visited-file-modtime) onto
2405 undo list rather than reimplementing it by hand, incorrectly.
2406
d74647c3
KB
24072013-07-09 Ken Brown <kbrown@cornell.edu>
2408
2409 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
2410
3c51b96b
JB
24112013-07-09 Juanma Barranquero <lekktu@gmail.com>
2412
2413 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
2414
4ebbdd67
PE
24152013-07-09 Paul Eggert <eggert@cs.ucla.edu>
2416
2417 Handle errno and exit status a bit more carefully.
2418 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
2419 number into an exit status. Instead, use EXIT_CANCELED.
2420 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
2421 * callproc.c (relocate_fd):
2422 * emacs.c (close_output_streams, main):
2423 * process.c (create_process):
2424 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
2425 Use emacs_perror for simplicity.
2426 * callproc.c (relocate_fd, main):
2427 * sysdep.c (sys_subshell):
2428 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
2429 (shut_down_emacs): Use emacs_write, not write.
2430 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
2431 * fileio.c (Fcopy_file, e_write):
2432 * nsterm.m (ns_select):
2433 * process.c (send_process):
2434 * sound.c (vox_write):
2435 Use emacs_write_sig, not emacs_write.
2436 * lisp.h (emacs_write_sig, emacs_perror): New decls.
2437 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
2438 New constants.
2439 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
2440 of write.
2441 (emacs_full_write): New function.
2442 (emacs_write): Rewrite to use it.
2443 (emacswrite_sig, emacs_perror): New functions.
2444 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
2445
44e18199 24462013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
e4b1e5af
JD
2447
2448 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
2449 on NS even if it is present. Pixmap on NS is a void*.
2450
9caab067
PE
24512013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2452
2453 Port to Ubuntu 10 (Bug#14803).
2454 Problem reported by T.V. Raman.
2455 * process.c (close_on_exec, accept4, process_socket):
2456 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
2457
1d442672
EZ
24582013-07-07 Eli Zaretskii <eliz@gnu.org>
2459
2460 * w32.c (sys_dup): Declare prototype.
2461
2462 * filelock.c:
2463 * emacs.c:
2464 * callproc.c [WINDOWSNT]: Include sys/socket.h.
2465
067428c1
PE
24662013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2467
2468 Make file descriptors close-on-exec when possible (Bug#14803).
2469 This simplifies Emacs a bit, since it no longer needs to worry
2470 about closing file descriptors by hand in some cases.
2471 It also fixes some unlikely races. Not all such races, as
2472 libraries often open files internally without setting
2473 close-on-exec, but it's an improvement.
2474 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
2475 * callproc.c (Fcall_process) [!MSDOS]:
2476 * emacs.c (main) [!DOS_NT]:
2477 * nsterm.m (ns_term_init):
2478 * process.c (create_process):
2479 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
2480 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
2481 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
2482 Prefer mkostemp with O_CLOEXEC to mkstemp.
2483 * callproc.c (relocate_fd) [!WINDOWSNT]:
2484 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
2485 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
2486 now using pipe2.
2487 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
2488 Make the resulting file descriptor close-on-exec.
2489 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
2490 * lread.c (load_descriptor_list, load_descriptor_unwind):
2491 Remove; no longer needed. All uses removed.
2492 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
2493 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
2494 New functions.
2495 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
2496 (Fmake_network_process, Fnetwork_interface_list):
2497 (Fnetwork_interface_info, server_accept_connection):
2498 Make newly-created socket close-on-exec.
2499 * sysdep.c (emacs_open, emacs_fopen):
2500 Make new-created descriptor close-on-exec.
2501 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
2502 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
2503
0da857dd
JD
25042013-07-07 Jan Djärv <jan.h.d@swipnet.se>
2505
2506 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
2507 for NS_IMPL_GNUSTEP.
2508
5f86adcd
PE
25092013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2510
2511 Fix openp errno handling.
2512 * callproc.c (Fcall_process): Preserve openp errno around close.
2513 * lread.c (openp): Set errno when returning -1, as some callers
2514 expect this.
2515
1afb1d07
JD
25162013-07-06 Jan Djärv <jan.h.d@swipnet.se>
2517
2518 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
2519
2520 * nsterm.h (NSSavePanel): Update comment.
2521 (NSAPP_DATA2_RUNFILEDIALOG): Define.
2522 (ns_run_file_dialog): Declare.
2523
2524 * nsfns.m: Remove panelOK.
2525 (ns_fd_data): New.
2526 (ns_run_file_dialog): New function.
2527 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
2528 event loop, so file dialog is popped up by ns_run_file_dialog, called
2529 by sendEvent (Bug#14578).
2530 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
2531
3323c263
EZ
25322013-07-06 Eli Zaretskii <eliz@gnu.org>
2533
fdda0220
EZ
2534 * xdisp.c (default_line_pixel_height): New function.
2535 (pos_visible_p, move_it_vertically_backward, try_scrolling)
2536 (try_cursor_movement, redisplay_window, try_window)
2537 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
2538
068f9124
SM
2539 * window.c (window_scroll_pixel_based):
2540 use default_line_pixel_height.
fdda0220
EZ
2541
2542 * dispextern.h (default_line_pixel_height): Add prototype.
2543
2544 * frame.c (x_set_line_spacing): Accept a float value for
2545 line-spacing parameter, per the documentation.
2546
3323c263
EZ
2547 * data.c (Fmultibyte_string_p): Doc fix.
2548
47ba6d43
PE
25492013-07-05 Paul Eggert <eggert@cs.ucla.edu>
2550
406af475
PE
2551 Use emacs_open more consistently when opening files.
2552 This handles EINTR more consistently now, and makes it easier
2553 to introduce other uniform changes to file descriptor handling.
2554 * src/systdio.h: New file.
2555 * src/buffer.c (mmap_init):
2556 * cygw32.c (chdir_to_default_directory):
2557 * dispnew.c (Fopen_termscript):
2558 * emacs.c (Fdaemon_initialized):
2559 * fileio.c (Fdo_auto_save):
2560 * image.c (slurp_file, png_load_body, jpeg_load_body):
2561 * keyboard.c (Fopen_dribble_file):
2562 * lread.c (Fload):
2563 * print.c (Fredirect_debugging_output):
2564 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
2565 * termcap.c (tgetent):
2566 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
2567 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
2568 * w32term.c (w32_initialize) [CYGWIN]:
2569 * xfaces.c (Fx_load_color_file):
2570 Use emacs_open instead of plain open, and emacs_fopen instead of
2571 plain fopen.
2572 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
2573 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
2574 * callproc.c (default_output_mode): New constant.
2575 (Fcall_process): Use it to call emacs_open instead of plain creat.
2576 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
2577 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
2578 (emacs_fopen): New function.
2579 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
2580 Include <lisp.h>, for emacs_open.
2581 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
2582
47ba6d43
PE
2583 Remove duplicate #include directives.
2584 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
2585 * xfaces.c:
2586 Don't include stdio.h twice.
2587 * buffer.c [USE_MMAP_FOR_BUFFERS]:
2588 Don't include sys/types.h or stdio.h twice.
2589 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
2590 * lread.c: Don't include coding.h twice.
2591 * nsfont.m: Don't include frame.h twice.
2592 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
2593 * ralloc.c: Don't include <unistd.h> twice.
2594 * xdisp.c: Don't include font.h twice.
2595 * xterm.c: Don't include fontset.h twice.
2596 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
2597
b9ed53d5
PE
25982013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2599
2600 Scale ImageMagick images more carefully.
2601 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
2602 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
2603 Be more careful about avoiding undefined behavior after
2604 integer overflow and division by zero.
2605
cf13177e
YM
26062013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2607
2608 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
2609 (syms_of_w32fns): DEFSYM them.
2610 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
2611 (CCHDEVICENAME): Define macros if not defined.
2612 (struct MONITOR_INFO_EX): New struct.
2613 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
2614 (enum_display_monitors_fn): New variable.
2615 (globals_of_w32fns): Initialize it.
2616 (Fx_display_pixel_width, Fx_display_pixel_height)
2617 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
2618 multi-monitor setups in docstrings.
2619 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
2620 screen size by primary monitor's millimeter per pixel.
2621 (w32_monitor_enum, w32_display_monitor_attributes_list)
2622 (w32_display_monitor_attributes_list_fallback)
2623 (Fw32_display_monitor_attributes_list): New functions.
2624 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
2625
2626 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
2627 if not defined.
2628 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
2629
86dfb7a8
MA
26302013-07-04 Michael Albinus <michael.albinus@gmx.de>
2631
2632 * fileio.c (Qfile_notify_error): New error symbol.
2633
2634 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
2635 * inotify.c (inotify_callback, symbol_to_inotifymask)
2636 (Finotify_add_watch, Finotify_rm_watch): Use it.
2637 (inotifyevent_to_event): Exchange order of cookie and file name.
2638 (Finotify_add_watch): Adapt docstring.
2639
2640 * lisp.h (Qfile_notify_error): Declare.
2641
2c1c974b
PE
26422013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2643
2644 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
2645 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2646 Do not clear _malloc_thread_enabled_p, undoing the previous change,
2647 which did not work (see <http://bugs.gnu.org/14569#307>).
2648 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
2649 && (!noninteractive || initialized)). This attempts to thread
2650 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
2651
7a35b20f
JB
26522013-07-04 Juanma Barranquero <lekktu@gmail.com>
2653
2654 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
2655 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
2656
1ce5cd04
PE
26572013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2658
2659 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
2660 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2661 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
2662 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
2663
57f8c490
PE
26642013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2665
2666 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
2667 Define to __sys_siglist.
2668
bcffb5ca
EZ
26692013-07-02 Eli Zaretskii <eliz@gnu.org>
2670
2671 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
2672 word-wrap, so that overflow-newline-into-fringe would work in
2673 visual-line-mode. (Bug#2749)
2674 (move_it_in_display_line_to): When the last scanned display
2675 element fits exactly on the display line, and
2676 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
2677 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
2678 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
2679 finding buffer position that corresponds to pixel coordinates,
2680 e.g. in buffer_posn_from_coords.
2681
2c41e781
JD
26822013-07-02 Jan Djärv <jan.h.d@swipnet.se>
2683
2684 * process.c (handle_child_signal): Call catch_child_signal if
2685 NS_IMPL_GNUSTEP.
2686
c2418359
PE
26872013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2688
52a9bcae
PE
2689 Don't convert function pointers to void * and back.
2690 It isn't portable C, and it's easy enough to avoid.
2691 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
2692 (make_save_value): Add support for SAVE_FUNCPOINTER.
2693 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
2694 * print.c (print_object):
2695 Distinguish function from object pointers.
2696 * lisp.h (SAVE_FUNCPOINTER): New constant.
2697 (SAVE_SLOT_BITS): Adjust to it.
2698 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
2699 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
2700 (voidfuncptr): New typedef.
2701 (struct Lisp_Save_Value): New member data[0].funcpointer.
2702 (XSAVE_FUNCPOINTER): New function.
2703
c2418359
PE
2704 Simplify buildobj processing.
2705 * Makefile.in (buildobj.h): Make it a sequence of strings each
2706 followed by comma, rather than a single string. Put it into a
2707 .tmp file in case there's an error while generating it.
2708 (gl-stamp): Use .tmp for temp files.
2709 (mostlyclean): Clean .tmp files.
2710 * doc.c (buildobj): Move to just the routine that needs it.
2711 It's now an array of strings, so processing is simpler.
2712
8f43ce49
PE
27132013-07-01 Paul Eggert <eggert@cs.ucla.edu>
2714
2715 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
2716 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
2717 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2718 Invoke malloc_enable_thread even when not interactive.
2719 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
2720 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
2721 in this case, since the underlying bug has now been fixed.
2722
24827db9
JB
27232013-07-01 Juanma Barranquero <lekktu@gmail.com>
2724
2725 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
2726 unlinking it (bug#14691).
2727
ef099a94
MN
27282013-06-30 Michal Nazarewicz <mina86@mina86.com>
2729
2730 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
2731 before checking whether buffer is modified. This lets
2732 `kill-buffer-query-functions' cancel killing of the buffer or save
2733 its content before `kill-buffer' asks user the "Buffer %s
2734 modified; kill anyway?" question.
2735
9d3f2fc2
JD
27362013-06-30 Jan Djärv <jan.h.d@swipnet.se>
2737
2738 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
2739 Let the super performKeyEquivalent deal with them (Bug#14747).
2740
e6c6c8c7
PE
27412013-06-30 Paul Eggert <eggert@cs.ucla.edu>
2742
1d71c1d9
PE
2743 * widget.c (resize_cb): Remove unused local.
2744
8f5f35cc
PE
2745 Do not use GTK 3 if it exists but cannot be compiled.
2746 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
2747 * xterm.c (x_error_handler) [!USE_GTK]:
2748 Do not use GTK 3.
2749
e6c6c8c7
PE
2750 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
2751
0ba54312
EZ
27522013-06-30 Eli Zaretskii <eliz@gnu.org>
2753
5d1c3286
EZ
2754 * intervals.c (get_local_map): Instead of aborting, clip POSITION
2755 to the valid range of values. (Bug#14753)
2756
0ba54312
EZ
2757 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
2758 when moving point by using the current glyph matrix. This avoids
2759 the need to force redisplay when this function is called in a
2760 loop.
2761
9c90cc06
PE
27622013-06-29 Paul Eggert <eggert@cs.ucla.edu>
2763
2764 Fix minor problems found by static checking.
2765 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
2766 Redo the latter's body to sidestep GCC parenthesization warnings.
2767 (setup_coding_system, detect_coding, detect_coding_system): Use them.
2768 * coding.c (detect_coding, detect_coding_system):
2769 * coding.h (struct undecided_spec):
2770 Use bool for boolean.
2771 * image.c (QCmax_width, QCmax_height): Now static.
2772 * xdisp.c (Fmove_point_visually): Remove unused local.
2773
4c672a0f
EZ
27742013-06-29 Eli Zaretskii <eliz@gnu.org>
2775
2776 * xdisp.c (Fmove_point_visually): New function.
2777
c1ea3abf
JB
27782013-06-28 Kenichi Handa <handa@gnu.org>
2779
2780 * coding.h (define_coding_undecided_arg_index): New enum.
2781 (coding_attr_index): New members
2782 coding_attr_undecided_inhibit_null_byte_detection,
2783 coding_attr_undecided_inhibit_iso_escape_detection,
2784 coding_attr_undecided_prefer_utf_8.
2785 (undecided_spec): New struct.
2786 (struct coding_system): New member `undecided' of the member
2787 `spec'.
2788
2789 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
2790 (detect_coding): Likewise.
2791 (detect_coding_system): Likewise.
2792 (Fdefine_coding_system_internal): New coding system properties
2793 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
2794 :prefer-utf-8.
2795 (syms_of_coding): Adjust for coding_arg_undecided_max.
2796
ba3de9e6
PE
27972013-06-28 Paul Eggert <eggert@cs.ucla.edu>
2798
2799 * image.c (x_from_xcolors): Remove unused local.
2800
547c9269
YM
28012013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2802
2803 Defer image data transfer between X client and server until actual
2804 display happens.
2805
2806 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
2807 and `mask_img'.
2808
2809 * image.c (Destroy_Image): Remove.
2810 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
2811 `mask_p', and `colors_p'. All uses changed.
2812 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
2813 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
2814 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
2815 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
2816 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 2817 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
2818 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
2819 (image_get_x_image, image_unget_x_image): New functions or macros.
2820 (image_background, image_background_transparent, x_to_xcolors)
2821 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
2822 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
2823 instead of Destroy_Image.
2824 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
2825 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
2826 (png_load_body, jpeg_load_body, tiff_load, gif_load)
2827 (imagemagick_load_image, svg_load_image): Use them instead of
2828 x_create_x_image_and_pixmap, and x_put_x_image followed by
2829 x_destroy_x_image, respectively.
2830 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
2831 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
2832 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
2833 background_transparent fields.
2834 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
2835 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
2836
dae2f5ef
PE
28372013-06-27 Paul Eggert <eggert@cs.ucla.edu>
2838
2839 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
2840 This mostly consists of undoing recent changes.
2841 * callproc.c (Fcall_process):
2842 * process.c (create_process):
2843 Do not worry about catching SIGCHLD here, undoing previous change.
2844 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
2845 * process.c, process.h (catch_child_signal):
2846 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
2847 * process.c (catch_child_handler): Don't worry about being called
2848 lazily and do not assume caller has blocked SIGCHLD, undoing
2849 previous change. Move first-time stuff back to
2850 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
2851 tickle glib, as that causes Cygwin bootstrap to fail. Do not
2852 set lib_child_handler if it's already initialized, which may
2853 help avoid problems on GNUStep.
2854
fa55d2aa
PE
28552013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2856
2857 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
2858 * callproc.c (Fcall_process):
2859 * process.c (create_process):
2860 Make sure SIGCHLD is caught before we fork,
2861 since Emacs startup no arranges to catch SIGCHLD.
2862 * process.c (lib_child_handler): Initialize to null, not to
2863 dummy_handler.
2864 (catch_child_signal): Allow self to be called lazily.
2865 Do nothing if it's already been called.
2866 Assume caller has blocked SIGCHLD (all callers do now).
2867 * emacs.c (main): Do not catch SIGCHLD here; defer it until
2868 just before it's really needed.
2869 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
2870 since it hasn't been caught yet.
2871
f3f9606c
LMI
28722013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
2873
2874 * image.c (compute_image_size): New function to implement
2875 :max-width and :max-height.
2876 (imagemagick_load_image): Use it.
2877
c7041908
PE
28782013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2879
2880 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
2881 * callproc.c, process.h (block_child_signal, unblock_child_signal):
2882 Now extern.
2883 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
2884 * process.c (catch_child_signal): Block SIGCHLD while futzing with
2885 the SIGCHLD handler, since the code is not atomic and (due to glib)
2886 signals may be arriving now.
2887 * sysdep.c (init_signals): Do not catch child signals here;
2888 'main' now does that later, at a safer time.
2889
f86852b4
PE
28902013-06-22 Paul Eggert <eggert@cs.ucla.edu>
2891
0dfeed58
PE
2892 Clean up SIGCHLD handling a bit (Bug#14569).
2893 * process.c, process.h (catch_child_signal):
2894 Now always extern, even if !NS_IMPL_GNUSTEP.
2895 * process.c (catch_child_signal): Move glib tickler here from
2896 init_process_emacs, so that it's done earlier in Emacs
2897 initialization. Also move the noninteractive && !initialized
2898 check here from init_process_emacs. This is all a bit cleaner for
2899 GNUish platforms, and I hope it works around the Cygwin bug.
2900 * sysdep.c (init_signals): Invoke catch_child_signal here, so
2901 that glib signal handling is tickled before glib creates threads.
2902
f86852b4
PE
2903 * process.c (wait_reading_process_output): Avoid int overflow
2904 when reading more than 2 GiB total from a process.
2905
cbd6509c
PE
29062013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2907
2908 * process.c (create_process): Handle a couple more cases,
2909 i.e., work even if new_argv and wait_child_setup[i] are cached.
2910 Use Fcall_process's style for volatile vars.
2911
9de1114a
AS
29122013-06-21 Andreas Schwab <schwab@linux-m68k.org>
2913
2914 * process.c (create_process): Mark PROCESS volatile.
2915
fbe9e0b9
PE
29162013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2917
2918 Use C99-style flexible array members if available.
2919 This avoids some subtle aliasing issues, which typically
2920 aren't a problem with GCC but may be a problem elsewhere.
2921 * alloc.c (sdata): New typedef, replacing the old struct sdata.
2922 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
2923 In either case, it uses a flexible array member rather than
2924 the old struct hack. All uses changed.
2925 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
2926 Adjust to sdata reorganization.
2927 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
2928 Use offsetof (struct, flex_array_member), not sizeof (struct), as
2929 that ports better to pre-C99 non-GCC.
2930 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
2931 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
2932 as the latter has changed.
2933 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
2934 and port better to pre-C99 GCC.
2935 * image.c (struct xpm_cached_color):
2936 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
2937 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
2938 Use FLEXIBLE_ARRAY_MEMBER.
2939 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
2940 Move decl to top level so it gets checked against implementation.
2941 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
2942 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
2943
1fc71008
PE
29442013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2945
2946 * syntax.c: Integer cleanups.
2947 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
2948 All uses that need 0-or-2 changed to:
2949 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
2950 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
2951 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
2952 (char_quoted, prev_char_comend_first, back_comment)
2953 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2954 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
2955 Use bool for boolean.
2956 (update_syntax_table, skip_chars, skip_syntaxes):
2957 Prefer int to unsigned when either will do.
2958 (back_comment): Return boolean success flag, like forw_comment,
2959 instead of positive-or-minus-1 (which might have overflowed int anyway).
2960 Don't stuff ptrdiff_t into int.
2961 (syntax_spec_code, syntax_code_spec): Now const.
2962 (Fmatching_paren, scan_lists, scan_sexps_forward):
2963 Use enum syntaxcode for syntax code.
2964 (Fmatching_paren): Check that arg is a character, not just an integer.
2965 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
2966 (Finternal_describe_syntax_value): Omit no-longer-needed
2967 comparison to 0.
2968 (skip_chars): Use char, not unsigned char, when the distinction
2969 doesn't matter.
2970 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
2971 * bytecode.c (exec_byte_code):
2972 * syntax.c (syntax_spec_code, Fchar_syntax)
2973 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2974 (init_syntax_once):
2975 * syntax.h (SYNTAX_WITH_FLAGS):
2976 Omit unnecessary casts.
2977
b932cad7
EZ
29782013-06-20 Eli Zaretskii <eliz@gnu.org>
2979
2980 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
2981 line dimensions here, to avoid race conditions with the main
2982 thread. (Bug#14062, bug#14630, bug#14669)
2983
2984 * w32term.c (w32_draw_window_cursor): Compute the header line and
2985 mode line dimensions here.
2986 <w32_system_caret_window, w32_system_caret_hdr_height>:
2987 <w32_system_caret_mode_height>: New variables.
2988
2989 * w32term.h: Declare them.
2990
89561f72
PE
29912013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2992
5013fc08
PE
2993 * alloc.c (die): Move "assertion failed" string here ...
2994 * lisp.h (eassert): ... from here. Also, suppress evaluation of
2995 COND when SUPPRESS_CHECKING. This shrinks the executable text
2996 size by 0.8% to 2.2% when configured with --enable-checking,
2997 depending on optimization flags (GCC 4.8.1 x86-64).
2998
89561f72
PE
2999 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
3000
763a086d 30012013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
3002
3003 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
3004 base is 2; this is more accurate.
3005
983aeb9a
JB
30062013-06-19 Juanma Barranquero <lekktu@gmail.com>
3007
3008 * sound.c (string_default): Move to !WINDOWSNT section.
3009 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
3010
178ba3e6
PE
30112013-06-19 Paul Eggert <eggert@cs.ucla.edu>
3012
bbc51b15
PE
3013 * sound.c: Integer cleanups.
3014 Remove unnecessary forward decls.
3015 (struct sound_device): The 'file' member is now a Lisp_Object, not
3016 a char *, so that we needn't invoke alloca on a huge size.
3017 (Fplay_sound_internal): Adjust to this.
3018 (string_default): New function.
3019 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
3020 Use it to adjust to the struct sound_device change.
3021 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
3022 (be2hs) [0]: Remove.
3023
178ba3e6
PE
3024 * syntax.c (skip_chars): Don't use uninitialized storage
3025 when searching a multibyte buffer for characters that are not in a
3026 unibyte string that contains non-ASCII characters.
3027
69f60cdc
JD
30282013-06-18 Jan Djärv <jan.h.d@swipnet.se>
3029
3030 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
3031 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
3032
0d6224d4
PE
30332013-06-18 Paul Eggert <eggert@cs.ucla.edu>
3034
3035 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
3036
3c542890
KH
30372013-06-18 Kenichi Handa <handa@gnu.org>
3038
f7e3f7cd
KH
3039 * font.c (Ffont_spec): Signal an error for an invalid font name
3040 (Bug#14648).
3c542890 3041
9349e5f7
PE
30422013-06-18 Paul Eggert <eggert@cs.ucla.edu>
3043
3044 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
3045 In particular this ports to 32-bit sparc Sun cc.
3046 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
3047 array with a dummy element at specpdl[-1], so that its address can
3048 be taken portably.
3049 (unbind_to): Do not copy the binding; not needed, now that we
3050 copy old_value in the one place where the copy is needed.
3051 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
3052 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
3053 (union specbinding): Rename from struct specbinding. Redo layout
3054 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
3055 which is not portable. With Sun C 5.12 32-bit sparc, the
3056 declaration causes nargs to be an unsigned bitfield, a behavior
3057 that the C standard allows; but Emacs wants nargs to be signed.
3058 The overall type is now a union of structures rather than a
3059 structure of union of structures, and the 'kind' member is now a
3060 bitfield, so that the overall type doesn't grow. All uses changed.
3061 * process.c (Fmake_serial_process): Remove unnecessary initialization.
3062
0a4df6a5
PE
30632013-06-17 Paul Eggert <eggert@cs.ucla.edu>
3064
ec6ecaad
PE
3065 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
3066 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
3067
0a4df6a5
PE
3068 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
3069
7bfe8dbc
EZ
30702013-06-17 Eli Zaretskii <eliz@gnu.org>
3071
3072 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
3073 unless we know that the window w's frame is a frame object.
3074 Another attempt at solving bug#14062 and bug#14630.
3075
708e05f6
LMI
30762013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
3077
3078 * textprop.c (property_set_type): New enum.
3079 (add_properties): Allow appending/prepending text properties.
3080 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 3081 (Fadd_text_properties): Move all the code into
708e05f6
LMI
3082 add_text_properties_1.
3083 (Fadd_face_text_property): New function that calls
3084 add_text_properties_1.
3085
84575e67
PE
30862013-06-17 Paul Eggert <eggert@cs.ucla.edu>
3087
3088 Move functions from lisp.h to individual modules when possible.
3089 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
3090 * alloc.c (XFLOAT_INIT, set_symbol_name):
3091 * buffer.c (CHECK_OVERLAY):
3092 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
3093 (set_char_table_parent):
3094 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
3095 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
3096 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
3097 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
3098 (set_blv_valcell):
3099 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
3100 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
3101 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
3102 (backtrace_args, backtrace_debug_on_exit):
3103 * floatfns.c (CHECK_FLOAT):
3104 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
3105 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
3106 (set_hash_hash, set_hash_hash_slot, set_hash_index)
3107 (set_hash_index_slot):
3108 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
3109 * marker.c (CHECK_MARKER):
3110 * textprop.c (CHECK_STRING_OR_BUFFER):
3111 * window.c (CHECK_WINDOW_CONFIGURATION):
3112 Move here from lisp.h, and make these functions static rather than
3113 extern inline.
3114 * buffer.c (Qoverlayp):
3115 * data.c (Qsubrp):
3116 * fns.c (Qhash_table_p):
3117 * window.c (Qwindow_configuration_p):
3118 Now static.
3119 * lisp.h: Remove the abovementioned defns and decls.
3120
44e18199 3121 Use functions, not macros, for XINT etc (Bug#11935).
84575e67
PE
3122 In lisp.h, prefer functions to function-like macros, and
3123 constants to object-like macros, when either will do. This:
3124 . simplifies use, as there's no more need to worry about
3125 arguments' side effects being evaluated multiple times.
3126 . makes the code easier to debug on some platforms.
3127 However, when using gcc -O0, keep using function-like macros
3128 for a few critical operations, for performance reasons.
3129 This sort of thing isn't needed with gcc -Og, but -Og
3130 is a GCC 4.8 feature and isn't widely-enough available yet.
3131 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
3132 Remove enum lsb_bits; no longer needed.
3133 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
3134 * buffer.c (Qoverlap):
3135 * data.c (Qsubrp):
3136 * fns.c (Qhash_table_p):
3137 Now extern, so lisp.h can use these symbols.
3138 * dispextern.h: Include character.h, for MAX_CHAR etc.
3139 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
3140 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
3141 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
3142 (GLYPH_CODE_P): Move here from lisp.h.
3143 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
3144 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
3145 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
3146 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
3147 XUNTAG now returns void *.
3148 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
3149 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
3150 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
3151 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
3152 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
3153 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
3154 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
3155 (lisp_h_XPNTR, lisp_h_XSYMBOL):
3156 New macros, renamed from their sans-lisp_h_ counterparts.
3157 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
3158 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
3159 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
3160 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
3161 If compiling via GCC without optimization, define these as macros
3162 in addition to inline functions.
3163 To disable this, compile with -DINLINING=0.
3164 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
3165 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
3166 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
3167 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
3168 (INTMASK, VALMASK): Now macros, since static values cannot be
3169 accessed from extern inline functions.
3170 (VALMASK): Also a constant, for benefit of old GDB.
3171 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
3172 is INTEGERP, which can fold it in.
5165d44a 3173 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
3174 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
3175 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
3176 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
3177 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
3178 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
3179 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
3180 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
3181 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
3182 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
3183 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
3184 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
3185 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
3186 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
3187 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
3188 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
3189 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
3190 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
3191 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
3192 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
3193 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
3194 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
3195 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
3196 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
3197 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
3198 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
3199 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
3200 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
3201 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
3202 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
3203 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
3204 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
3205 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
3206 Now functions.
3207 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
3208 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
3209 (VALMASK): Define in one place rather than in two, merging the
3210 USE_LSB_TAG parts; this is simpler.
3211 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
3212 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
3213 Move up, to avoid use before definition.
3214 Also include "globals.h" earlier, for the same reason.
3215 (make_natnum): New function.
3216 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
3217 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
3218 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
3219 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
3220 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
3221 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
3222 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
3223 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
3224 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
3225 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
3226 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
3227 (Qwindow_configuration_p, Qimage): New forward declarations.
3228 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
3229 (STRING_COPYIN): Remove; unused.
3230 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
3231 (xcar_addr, xcdr_addr): New functions. All uses changed.
3232 (IEEE_FLOATING_POINT): Now a constant, not a macro.
3233 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
3234 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
3235 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
3236 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
3237 (TYPE_RANGED_INTEGERP): Simplify.
3238 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
3239 (setlocale, fixup_locale, synchronize_system_messages_locale)
3240 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
3241 Now empty functions, not macros.
3242 (functionp): Return bool, not int.
3243 * window.c (Qwindow_configuration_p): Now extern,
3244 so window.h can use it.
3245 * window.h (Qwindowp): Move decl back to lisp.h.
3246
9583ec36
EZ
32472013-06-15 Eli Zaretskii <eliz@gnu.org>
3248
3249 * xdisp.c (Fline_pixel_height): New function, required for solving
3250 bug #14567.
3251
210272ce
PE
32522013-06-15 Paul Eggert <eggert@cs.ucla.edu>
3253
3254 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
3255
de0503df
SM
32562013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
3257
3258 * lread.c (syms_of_lread):
3259 * fns.c (Fprovide): Adjust to new format of after-load-alist.
3260
afbfe143
KD
32612013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
3262
3263 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
3264
d177e213
XF
32652013-06-12 Xue Fuqiao <xfq.free@gmail.com>
3266
3267 * fileio.c (expand_file_name): Doc fix.
3268
05e3e412
PE
32692013-06-11 Paul Eggert <eggert@cs.ucla.edu>
3270
f7394b12
PE
3271 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
3272 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
3273 Wait for self, not for 0. This can't hurt on GNU or similar
3274 system, and may help with Cygwin.
3275
05e3e412
PE
3276 * keyboard.c: Don't use PROP (...) as an lvalue.
3277 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
3278 Use set_prop (A, B), not PROP (A) = B.
3279
17dd3097
EZ
32802013-06-10 Eli Zaretskii <eliz@gnu.org>
3281
3282 * xdisp.c (get_it_property): Use it->window instead of generating
3283 a Lisp object from it->w.
3284
52fab9c9
EZ
32852013-06-09 Eli Zaretskii <eliz@gnu.org>
3286
3287 * xdisp.c (get_it_property): If it->object is a buffer, pass to
3288 get-char-property the window that is being rendered, instead of
3289 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
3290 (compute_display_string_pos): When W is NULL, use the current
3291 buffer as the object to pass to get-char-property.
3292 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
3293 pointer member of the bidi iterator, since no window is pertinent
3294 to this function.
52fab9c9 3295
5bf97bfc
EZ
32962013-06-08 Eli Zaretskii <eliz@gnu.org>
3297
3298 * bidi.c (bidi_fetch_char): Accept additional argument, the window
3299 being displayed, and pass it to compute_display_string_pos.
3300 (bidi_level_of_next_char, bidi_resolve_explicit_1)
3301 (bidi_paragraph_init): All callers changed.
3302
3303 * xdisp.c (init_from_display_pos, init_iterator)
3304 (handle_single_display_spec, next_overlay_string)
3305 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
3306 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
3307 Set bidi_it.w member from it->w.
5bf97bfc
EZ
3308 (compute_display_string_pos): Accept additional argument, the
3309 window being displayed, and pass it to Fget_char_property.
3310 (Bug#14575)
3311
3312 * dispextern.h (struct bidi_it): New member w, the window being
3313 displayed.
3314 (compute_display_string_pos): Adjust prototype.
3315
5de0e011
JD
33162013-06-08 Jan Djärv <jan.h.d@swipnet.se>
3317
e7b41c4c 3318 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
3319
3320 * process.c (wait_reading_process_output): Check for NS before GLIB.
3321 GLIB may be linked in due to rsvg, but ns_select must be called.
3322
5de0e011
JD
3323 * xgselect.c (xg_select): Remove call to window_system_available
3324 and g_main_context_pending at the top, so Gdk events (i.e. file
3325 notify) are processed when Emacs is started with -nw.
3326
a822acff
EZ
33272013-06-07 Eli Zaretskii <eliz@gnu.org>
3328
3329 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
3330 (ctagsfiles3): New variable, includes only *.m files.
3331 (TAGS): Use an explicit language name in the regular expressions,
3332 to avoid transformation of '/SOMETHING' by MSYS to
3333 'c:\MSYS\SOMETHING'.
3334
6c0a9ed1
RC
33352013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
3336
3337 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
3338
9ef6111b
EZ
33392013-06-06 Eli Zaretskii <eliz@gnu.org>
3340
3341 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
3342 still need to set the mouse pointer shape and activate help-echo.
3343 (Bug#14558)
3344
7d300d64
PE
33452013-06-06 Paul Eggert <eggert@cs.ucla.edu>
3346
3347 A few porting etc. fixes for the new file monitor code.
3348 See the thread containing
3349 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
3350 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
3351 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
3352 (dir_monitor_callback, Fgfile_rm_watch):
3353 Use assq_no_quit instead of Fassoc, for speed.
3354 (dir_monitor_callback, Fgfile_rm_watch):
3355 eassert that the monitor is a fixnum.
3356 (dir_monitor_callback): No need for CDR_SAFE.
3357 Simplify building of lisp with alternative tails.
3358 (Fgfile_add_watch, Fgfile_rm_watch):
3359 Do not assume glib functions set errno reliably on failure.
3360 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
3361 and signal an error otherwise.
3362 (Fgfile_rm_watch): Prefer CONSP to !NILP.
3363 Use Fdelq instead of Fdelete, for speed.
3364
817ebfcf
EZ
33652013-06-05 Eli Zaretskii <eliz@gnu.org>
3366
3367 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
3368 don't insist on being invoked on a highlighted tool-bar button.
3369 Avoids losing tool-bar functionality when mouse-highlight is nil.
3370 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
3371 Don't highlight when mouse-highlight is nil.
3372 (note_mouse_highlight): When mouse-highlight is nil, don't return
3373 right away; instead, run tool-bar and mode-line highlight
3374 subroutine, clear any existing highlight, and revert the mouse
3375 pointer to its default shape. (Bug#14558)
3376
55577e7c
SM
33772013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
3378
3379 * lisp.mk (lisp): Add prog-mode.el.
3380
f019a684
PE
33812013-06-05 Paul Eggert <eggert@cs.ucla.edu>
3382
3383 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
3384 * process.c (dummy_handler): New function.
3385 (lib_child_handler): New static var.
3386 (handle_child_signal): Invoke it.
3387 (catch_child_signal): If a library has set up a signal handler,
3388 save it into lib_child_handler.
3389 (init_process_emacs): If using glib and not on Windows, tickle glib's
3390 child-handling code so that it initializes its private SIGCHLD handler.
3391 * syssignal.h (SA_SIGINFO): Default to 0.
3392 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
3393 31; it should no longer be needed now.
3394
90db8702
MA
33952013-06-05 Michael Albinus <michael.albinus@gmx.de>
3396
3397 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
3398
3399 * gfilenotify.c (globals_of_gfilenotify): New function.
3400 (syms_of_gfilenotify): Move global initialization there.
3401
3402 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
3403
bfa3acd6
SM
34042013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
3405
3406 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
3407 * keyboard.c (menu_bar_items, tool_bar_items):
3408 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
3409 not override local keymaps any more.
3410
ba59bd80
EZ
34112013-06-04 Eli Zaretskii <eliz@gnu.org>
3412
3413 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
3414
7f203aa1
EZ
34152013-06-03 Eli Zaretskii <eliz@gnu.org>
3416
9337e206
EZ
3417 * w32console.c (initialize_w32_display): Return the dimensions of
3418 the console window via 2 additional arguments, not via the current
3419 frame. This avoids crashes due to overrunning the bounds of
3420 frame's decode_mode_spec_buffer, which is not resized following
3421 the change of the frame dimensions from the initial 10x10.
3422
3423 * w32term.h (w32_initialize_display_info): Adjust prototype.
3424
3425 * term.c (init_tty): Take dimensions of the frame from the values
3426 returned by initialize_w32_display.
3427
7f203aa1
EZ
3428 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
3429 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
3430 (LIBES): Add $(GFILENOTIFY_LIBS).
3431
3432 * w32inevt.c (handle_file_notifications): Add dummy implementation
3433 for !HAVE_W32NOTIFY.
3434
3435 * w32term.c: Wrap code with HAVE_W32NOTIFY.
3436
55a87246
JD
34372013-06-03 Jan Djärv <jan.h.d@swipnet.se>
3438
3439 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
3440
3441 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
3442
3443 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
3444
3d5ee10a
PE
34452013-06-03 Paul Eggert <eggert@cs.ucla.edu>
3446
3447 Fix minor problems found by static checking.
3448 * data.c (pure_write_error):
3449 Use xsignal2, not Fsignal, as Fsignal might return.
3450 * eval.c (set_backtrace_debug_on_exit): Now static.
3451 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
3452 No longer inline. EXTERN_INLINE is needed only for functions
3453 defined in .h files. Reindent function header as per GNU style.
3454 (backtrace_p, backtrace_top, backtrace_next):
3455 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
3456 compiler or linker. Add extern decls to pacify gcc -Wall.
3457 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
3458 Now static.
3459 * frame.c (free_monitors): Define only on platforms that need it.
3460 * nsterm.m (ns_term_init):
3461 * process.c (catch_child_signal):
3462 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
3463 defined on all porting targets these days.
3464 * process.c, process.h (catch_child_signal):
3465 Make it extern only if NS_IMPL_GNUSTEP is defined.
3466
e2d8a6f0
EZ
34672013-06-03 Eli Zaretskii <eliz@gnu.org>
3468
3469 * w32.c (gettimeofday): Make the signature identical to prototype
3470 in nt/inc/sys/time.h.
3471
a8a7c5f6
SM
34722013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
3473
3474 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
3475 .gdbinit.
3476
3477 * keyboard.c (safe_run_hooks_error): Improve error message.
3478
3479 * data.c (pure_write_error): Add `object' argument.
3480 * puresize.h (CHECK_IMPURE): Use it.
3481
c9628c79
MA
34822013-06-03 Michael Albinus <michael.albinus@gmx.de>
3483
3484 * Makefile.in (NOTIFY_OBJ): New variable.
3485 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
3486
3487 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
3488 Call syms_of_gfilenotify.
3489
3490 * gfilenotify.c: New file.
3491
3492 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
3493 and Qfile_w32notify.
3494 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
3495 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
3496
3497 * lisp.h: Declare syms_of_gfilenotify.
3498
3499 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
3500
2f592f95
SM
35012013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
3502
3503 Merge the specpdl and backtrace stacks. Make the structure of the
3504 specpdl entries more obvious via a tagged union of structs.
3505 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
3506 (enum specbind_tag): New enum.
3507 (struct specbinding): Make it a tagged union of structs.
3508 Add a case for backtrace records.
3509 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
3510 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
3511 (backtrace_debug_on_exit): New accessors.
3512 (struct backtrace): Remove.
3513 (struct catchtag): Remove backlist field.
3514 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3515 Move to eval.c.
3516 (Flocal_variable_p): Speed up the common case where the binding is
3517 already loaded.
3518 * eval.c (backtrace_list): Remove.
3519 (set_specpdl_symbol, set_specpdl_old_value): Remove.
3520 (set_backtrace_args, set_backtrace_nargs)
3521 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
3522 (backtrace_next): New functions.
3523 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
3524 (unwind_to_catch, internal_lisp_condition_case)
3525 (internal_condition_case, internal_condition_case_1)
3526 (internal_condition_case_2, internal_condition_case_n): Don't bother
3527 with backtrace_list any more.
3528 (Fsignal): Adjust to new backtrace format.
3529 (grow_specpdl): Move up.
3530 (record_in_backtrace): New function.
3531 (eval_sub, Ffuncall): Use it.
3532 (apply_lambda): Adjust to new backtrace format.
3533 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
3534 data.c.
3535 (specbind): Adjust to new specpdl format. Simplify.
3536 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
3537 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
3538 backtrace format.
3539 (mark_backtrace): Remove.
3540 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
3541 * xdisp.c (redisplay_internal): Use record_in_backtrace.
3542 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
3543 Use mark_specpdl.
3544 * profiler.c (record_backtrace): Use get_backtrace.
3545 (handle_profiler_signal): Use backtrace_top_function.
3546 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
3547 accessor functions.
3548
c0342369
JD
35492013-06-02 Jan Djärv <jan.h.d@swipnet.se>
3550
3551 * process.h (catch_child_signal): Declare.
3552
3553 * process.c (catch_child_signal): New function.
3554 (init_process_emacs): Call it.
3555
3556 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
3557 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
3558 NS_IMPL_COCOA.
3559 (x_set_cursor_type): Remove declaration.
3560 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
3561 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
3562 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
3563 (ns_get_color): Use F suffix on float.
3564 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
3565 (ns_get_rgb_color): Remove.
3566 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
3567 (note_mouse_movement): x and y are CGFloat.
3568 (ns_draw_fringe_bitmap): Remove unused rowY.
3569 Change #if to COCOA && >= 10_6.
3570 (ns_draw_window_cursor): Remove unused overspill.
3571 (ns_draw_underwave): width and x are EamcsCGFloat.
3572 (ns_draw_box): thickness is CGFloat.
3573 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
3574 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
3575 if not in main thread.
3576 (ns_get_pending_menu_title, ns_check_menu_open)
3577 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
3578 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
3579 (sendFromMainThread:): New method.
3580 (changeFont:): size is CGFloat.
3581 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
3582 Disable warning about permanent text.
3583 (characterIndexForPoint:): Adjust return type depending on GNUStep
3584 version.
3585 (mouseDown:): delta is CGFloat.
3586 (updateFrameSize): Remove unised variable f.
3587 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
3588 Cast float to EmacsCGFloat.
3589 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
3590 also to -1 when restoring.
3591 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
3592 inside NS_IMPL_COCOA.
3593 (toggleFullScreen:): Put call to toggleFullScreen inside
3594 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
3595 (setPosition:portion:whole:): por is CGFloat.
3596 (getMouseMotionPart:window:x:y:): Add F suffix to float.
3597 (mouseDown:): Use CGFloat.
3598 (mouseDragged:): Remove unised variable edge.
3599 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
3600
3601 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
3602 of CGFloat differs.
3603 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
3604 when NS_IMPL_GNUSTEP.
3605 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
3606 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
3607 (EmacsToolbar): Add clearAll. Add tag argument to
3608 addDisplayItemWithImage.
3609 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
3610
3611 * nsselect.m (ns_get_local_selection): Remove unused variable type.
3612
3613 * nsmenu.m (ns_update_menubar): Make static.
3614 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
3615 (fillWithWidgetValue:): Add cast to SEL for setAction.
3616 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
3617 (update_frame_tool_bar): Update code for GNUStep.
3618 (clearAll): New method.
3619 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 3620 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 3621 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
3622 call to insertItemWithItemIdentifier.
3623 (validateVisibleItems): Fix indentation.
3624 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
3625 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
3626 UtilityWindow to aStyle, remove call to setStyleMask.
3627
3628 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
3629
3630 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
3631 (ns_charset_covers, ns_get_covering_families, nsfont_open):
3632 Use F suffix on floats.
3633 (ns_char_width): Returns CGFloat.
3634 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 3635 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
3636 DPSxshow.
3637 (ns_glyph_metrics): CGFloat instead of float.
3638
a0eb10b3
JB
3639 * nsfns.m (x_set_foreground_color, x_set_background_color):
3640 Use EmacsCGFloat.
3641 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
3642 remove unused variables.
3643 (Fns_read_file_name): Keep track if panel is for save.
3644 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 3645 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
3646 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
3647 Just return the input if GNUStep.
c0342369
JD
3648 (x_screen_planes): Remove.
3649 (Fxw_color_values): Use EmacsCGFloat
3650 (Fns_display_monitor_attributes_list): Only get screen number for
3651 Cocoa.
ef099a94 3652 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
3653 EmacsSavePanel.
3654 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
3655 ns_directory_from_panel.
3656
da9aff11
PE
36572013-06-01 Paul Eggert <eggert@cs.ucla.edu>
3658
3659 * process.c (handle_child_signal): Also use WCONTINUED.
3660 This is so that list-processes doesn't mistakenly list the process
3661 as stopped, when the process has actually been continued and is
3662 now running.
3663
0e64479a
PE
36642013-05-31 Paul Eggert <eggert@cs.ucla.edu>
3665
fc186a96
PE
3666 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
3667 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
3668 not already configured.
3669
0e64479a
PE
3670 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
3671
38b787fa
EZ
36722013-05-29 Eli Zaretskii <eliz@gnu.org>
3673
3674 * Makefile.in (mostlyclean): Remove *.res files.
3675
22513e52
SM
36762013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
3677
3678 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
3679 a buffer (bug#8447).
3680
6ef3db10
EZ
36812013-05-27 Eli Zaretskii <eliz@gnu.org>
3682
3683 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
3684 display vector, and we backtrack, handle the case that the
3685 previous character position is also displayed from a display
3686 vector or covered by a display string or image. (Bug#14476)
3687
6799bb26
JD
36882013-05-25 Jan Djärv <jan.h.d@swipnet.se>
3689
3690 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3691 (struct MonitorInfo, free_monitors): Remove.
3692 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
3693 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
3694 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3695 Qframes, Qsource.
3696
3697 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3698 (struct MonitorInfo, free_monitors): Remove.
3699 (ns_screen_name): Make static.
3700 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
3701 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3702 Qframes, Qsource.
3703
3704 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3705 (struct MonitorInfo): New struct.
3706 (free_monitors, make_monitor_attribute_list): Declare.
3707
22513e52
SM
3708 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
3709 New Lisp_Object:s.
6799bb26
JD
3710 (free_monitors, make_monitor_attribute_list): New functions.
3711 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
3712 Qsource.
3713
38cd43eb
XF
37142013-05-25 Xue Fuqiao <xfq.free@gmail.com>
3715
3716 * callproc.c (call_process): Refine the doc string. (Bug#14045)
3717
2af0948d
SM
37182013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
3719
a7eb9b0f
SM
3720 * keyboard.c: Apply keyboard decoding only to events that come directly
3721 from the tty, not from unread-command-events (bug#14368).
3722 (read_event_from_main_queue): New function, extracted from read_char).
3723 (read_decoded_char): Remove.
3724 (read_decoded_event_from_main_queue): New function to replace it.
3725 (read_char): Use it.
3726 (read_key_sequence): Use read_char rather than read_decoded_char.
3727
2af0948d
SM
3728 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
3729
1413e9a5
BR
37302013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
3731
3732 * casetab.c (init_casetab_once): Fix last change (bug#14424).
3733
e6d2f155
KH
37342013-05-22 Kenichi Handa <handa@gnu.org>
3735
3736 The following changes are to fix the setting of
3737 buffer-file-coding-system on, for instance, C-x RET c unix RET
3738 _FILE_OF_DOS_EOL_TYPE_ RET.
3739
3740 * coding.h (struct coding_system): New member detected_utf8_chars.
3741
3742 * coding.c (detect_coding_utf_8): Count characters and check EOL
3743 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
3744 BOM is there.
3745 (setup_coding_system): Do not initialize coding->head_ascii.
3746 (check_ascii): Do not set coding->eol_seen but update it. Do not
3747 call adjust_coding_eol_type here.
1413e9a5
BR
3748 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
3749 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
3750 of the found coding-system.
3751 (decode_coding_gap): Cancel previous change. Utilize the
3752 character numbers counted by detect_coding_utf_8. Fix detection
3753 of BOM for utf-8.
3754
ab56a6f4 37552013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
3756
3757 * search.c (looking_at_1): Only set last_thing_searched if the match
3758 changed the match-data (bug#14281).
3759
ecc3c6ed
DA
37602013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
3761
3762 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 3763 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
3764 (move_it_vertically_backward): Likewise.
3765
5ba8bf35
YM
37662013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3767
3768 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 3769 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
3770 (Fx_display_mm_width, Fx_display_mm_height):
3771 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 3772
91e8418b 3773 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 3774 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
3775 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
3776 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
3777 (Fx_display_backing_store, Fx_display_visual_class)
3778 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
3779 (Fx_display_grayscale_p, Fx_display_pixel_width)
3780 (Fx_display_pixel_height, Fx_display_planes)
3781 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
3782 (Fx_display_screens): Don't confuse X11 screens with NS screens.
3783 (Fx_display_mm_width, Fx_display_mm_height)
3784 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
3785 height for all physical monitors as in X11.
3786
fc30d803
SM
3787 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
3788 Return pixel width or height for all physical monitors as in X11.
91e8418b 3789
31ff141c
PE
37902013-05-18 Paul Eggert <eggert@cs.ucla.edu>
3791
3792 Port --enable-gcc-warnings to clang.
3793 * bytecode.c (exec_byte_code):
3794 * regex.c:
3795 Redo diagnostic pragmas to pacify clang, too.
3796 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
3797 * editfns.c (Fencode_time):
3798 * fileio.c (file_accessible_directory_p):
3799 * font.c (font_unparse_xlfd):
3800 Use '&"string"[index]' instead of '"string" + (index)'.
3801 * undo.c (user_error): Remove; unused.
3802
df065a0b
EZ
38032013-05-16 Eli Zaretskii <eliz@gnu.org>
3804
04d360e7
EZ
3805 * insdel.c (insert_1_both): Document the arguments, instead of
3806 referring to insert_1, which no longer exists.
3807
5bb98290
EZ
3808 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
3809 some window, increment windows_or_buffers_changed, so that
3810 *Messages* display in that window is updated. (Bug#14408)
3811
df065a0b
EZ
3812 * w32.c: Include epaths.h.
3813 (init_environment): Use cmdproxy.exe without leading directories.
3814 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
3815 case.
3816 (gettimeofday): Adjust signature and return value to Posix
3817 expectations.
3818
3819 * unexw32.c (open_output_file): Delete the existing emacs.exe
3820 before creating it, to break the hard link to the versioned
3821 executable.
3822
3823 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
3824 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
3825 (FIRSTFILE_OBJ): New variables.
3826 (W32_RES): Rename to EMACSRES. All users changed.
3827 (base_obj): Use $(CM_OBJ).
3828 (ALLOBJS): Use $(FIRSTFILE_OBJ).
3829 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
3830 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
3831 $(W32_RES_LINK) before $(LIBES).
3832 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
3833
1aa8d505
SM
38342013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3835
6e911150
SM
3836 * makefile.w32-in (DOC): Use just "DOC".
3837
3838 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
3839
1aa8d505
SM
3840 * process.c: Export default filters and sentinels to Elisp.
3841 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
3842 New constants.
3843 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
3844 (Fset_process_sentinel, Fformat_network_address):
3845 Default to them instead of nil.
3846 (server_accept_connection): Sentinels can't be nil any more.
3847 (read_and_dispose_of_process_output): New function, extracted from
3848 read_process_output.
3849 (read_process_output): Use it; filters can't be nil.
3850 (Finternal_default_process_filter): New function, extracted from
3851 read_process_output.
3852 (exec_sentinel_unwind): Remove function.
3853 (exec_sentinel): Don't zilch sentinel while running.
3854 (status_notify): Sentinels can't be nil.
3855 (Finternal_default_process_sentinel): New function extracted from
3856 status_notify.
3857 (setup_process_coding_systems): Default filter is not nil any more.
3858 (syms_of_process): Export new Elisp functions and initialize
3859 new constants.
3860 * lisp.h (make_lisp_proc): New function.
3861
5ac2eb34
SM
38622013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3863
3864 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
3865
eda9c7d7
EZ
38662013-05-14 Eli Zaretskii <eliz@gnu.org>
3867
3868 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
3869 unless we know that the window w is a leaf window.
3870 Another attempt at solving bug#14062.
eda9c7d7 3871
8fdeaad5
JD
38722013-05-14 Jan Djärv <jan.h.d@swipnet.se>
3873
3874 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
3875 fdesc (Bug#14375).
3876
44aa9ee6
PE
38772013-05-12 Paul Eggert <eggert@cs.ucla.edu>
3878
3879 * image.c (gif_load): Check that subimages fit (Bug#14345).
3880
759fd763
SM
38812013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
3882
3883 * lread.c (skip_dyn_eof): New function.
3884 (read1): Use it to skip the end of a file in response to #@00.
3885
3886 * doc.c (get_doc_string): Slightly relax the sanity checking.
3887
4465bfb4
JD
38882013-05-09 Jan Djärv <jan.h.d@swipnet.se>
3889
3890 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
3891 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3892 (MonitorInfo): New struct.
3893 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
3894 (Fns_display_monitor_attributes_list): New functions.
3895 (display-usable-bounds): Remove.
3896 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
3897 Qsource.
3898
7583e2a0
PE
38992013-05-09 Paul Eggert <eggert@cs.ucla.edu>
3900
3901 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
3902 (GTK_CHECK_VERSION): New macro, if not already defined.
3903 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
3904 replaced by GTK_CHECK_VERSION.
3905
ad75d77e
PE
39062013-05-08 Paul Eggert <eggert@cs.ucla.edu>
3907
3908 * xterm.h (GTK_PREREQ): New macro.
3909 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
3910 to use this macro instead, for consistency and clarity.
3911
07525f77
EZ
39122013-05-08 Eli Zaretskii <eliz@gnu.org>
3913
3914 * xdisp.c (row_for_charpos_p): New function, with code of
3915 cursor_row_p, but accepts an additional argument CHARPOS instead
3916 of using a hardcoded PT.
3917 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
3918 (row_containing_pos): Call row_for_charpos_p instead of partially
3919 doing the same. Fixes cursor positioning under longlines-mode
3920 when longlines-show-effect includes more than one newline, when
3921 moving the cursor vertically up.
3922
d901fc8d
JB
39232013-05-08 Juanma Barranquero <lekktu@gmail.com>
3924
3925 * makefile.w32-in (ACL_H): New macro.
3926 ($(BLD)/fileio.$(O)): Update dependencies.
3927
f269bc61
PE
39282013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3929
e7b41c4c 3930 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
3931 * Makefile.in (LIB_ACL): New macro.
3932 (LIBACL_LIBS): Remove.
3933 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
3934 * fileio.c: Include <acl.h>.
3935 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
3936 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
3937 !acl_errno_valid.
3938 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
3939 it ourselves.
3940
f269bc61
PE
3941 * unexelf.c: Don't assume ElfW (Half) fits in int.
3942 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
3943 when dealing with ElfW (Half) values, since they can exceed 2**31
3944 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
3945 (entry_address): Omit unused NUM arg. All uses changed.
3946
a261c53e
JL
39472013-05-07 Juri Linkov <juri@jurta.org>
3948
3949 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
3950 to the string converted from number with `Fnumber_to_string'.
3951 (Bug#14254)
3952
2b66427d
PE
39532013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3954
3955 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
3956 This fixes a problem introduced by my previous change.
3957
15acfe41
GM
39582013-05-07 Glenn Morris <rgm@gnu.org>
3959
3960 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
3961
5ea03bf5
JD
39622013-05-07 Jan Djärv <jan.h.d@swipnet.se>
3963
3964 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
3965
e0c9d565
PE
39662013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3967
3968 Static checking by GCC 4.8.0.
3969 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
3970 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
3971 (x_get_monitor_attributes_fallback)
3972 (x_get_monitor_attributes_xinerama)
3973 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
3974 Define only if USE_GTK.
3975 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
3976 (x_get_monitor_attributes_fallback): Omit unused locals.
3977 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
3978 Use double, not float, to avoid mixed-mode floating point arithmetic.
3979
4e3f9230
YM
39802013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3981 Jan Djärv <jan.h.d@swipnet.se>
3982
3983 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
3984 (XINERAMA_CFLAGS): New macros.
3985 (ALL_CFLAGS, LIBES): Use them.
3986
3987 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
3988 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
3989 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
3990 (syms_of_xfns): DEFSYM them.
3991 (struct MonitorInfo): New struct.
3992 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
3993 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
3994 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
3995 (x_get_monitor_attributes_xinerama): New functions.
3996 (Fx_display_monitor_attributes_list): New primitive.
3997 (syms_of_xfns): Defsubr it.
3998
3999 * xterm.h (x_display_info): Add Xatom_net_workarea and
4000 Xatom_net_current_desktop.
4001
4002 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
4003 and dpyinfo->Xatom_net_current_desktop.
4004
05839b6a
EZ
40052013-05-06 Eli Zaretskii <eliz@gnu.org>
4006
4007 * xdisp.c (pos_visible_p): Use the special code for finding the
4008 beginning of a display property or overlay for any "replacing"
4009 display property, not just for display strings. This solves
4010 incorrect reporting of position by posn-at-point. (Bug#14241)
4011
dc4a2ee0
PE
40122013-05-06 Paul Eggert <eggert@cs.ucla.edu>
4013
5ee94506
PE
4014 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
4015 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
4016 Verify that ElfW (Half) fits in int.
4017 (fatal): Use same signature as lisp.h.
4018 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
4019 configure and build with -DUNEXELF_DEBUG without worrying about
4020 other modules that use DEBUG.
4021 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
4022 possibly-wide integers now uses it instead of plain fprintf.
4023 (entry_address): New function, which avoids problems with 32-bit
4024 overflow on 64-bit hosts.
4025 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
4026 (round_up): Don't assume the remainder fits in int.
4027 (find_section): Use bool for boolean. Simplify debug code.
4028 (unexec): Don't assume file sizes fit in int or size_t.
4029 Omit unnecessary trailing newline in 'fatal' format.
4030 Use strerror rather than outputting decimal error number.
4031 Remove unused code when emacs is not defined;
4032 this file relies on Emacs now.
4033 Don't assume e_phnum and e_shnum are positive.
4034
dc4a2ee0
PE
4035 * regex.c: Fix problems when DEBUG is defined.
4036 (extract_number, extract_number_and_incr): Define regardless of
4037 whether DEBUG is defined; that's simpler and makes the code less
4038 likely to go stale in the normal case when DEBUG is not defined.
4039 Return int rather than taking an int * arg. All callers changed.
4040 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
4041 Remove, replacing with ...
4042 (DEBUG_PRINT): New macro. All callers changed.
4043 (DEBUG_COMPILES_ARGUMENTS): New macro.
4044 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
4045 (print_compiled_pattern, print_double_string) [DEBUG]:
4046 Use prototype rather than old-style definition.
4047 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
4048 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
4049 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
4050 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
4051 Don't assume ptrdiff_t, size_t, and long are the same width as int.
4052 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
4053 This matters only when DEBUG is defined.
4054
14c7ed05
EZ
40552013-05-05 Eli Zaretskii <eliz@gnu.org>
4056
4057 * xdisp.c (set_iterator_to_next): Set the
4058 ignore_overlay_strings_at_pos_p flag only if we are _really_
4059 iterating over an overlay string, as indicated by the
4060 current.overlay_string_index member. (Bug#14306)
4061
e6076b1b
JD
40622013-05-05 Jan Djärv <jan.h.d@swipnet.se>
4063
4064 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
4065 to where it is used, to avoid autorelease issues (Bug#14050).
4066
cbee2131
PE
40672013-05-05 Paul Eggert <eggert@cs.ucla.edu>
4068
4069 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
4070 * fileio.c (syms_of_fileio): Implement this.
4071 * filelock.c (create_lock_file): If symbolic links don't work, so
4072 we use a regular file as a lock file, do not fsync the lock file;
4073 it's not needed.
4074
30c7e542
SM
40752013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4076
4077 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
4078 (syms_of_minibuf): Adjust accodingly.
4079 * lread.c (Fread):
4080 * callint.c (Fcall_interactively): Adjust calls accordingly.
4081
5bebd186
EZ
40822013-05-04 Eli Zaretskii <eliz@gnu.org>
4083
4084 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
4085 w->contents is a buffer before computing everything else.
4086 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
4087
4088 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
4089 assertion violations. (Bug#14062)
4090
0fb0a4f3
DR
40912013-05-01 David Reitter <david.reitter@gmail.com>
4092
4093 * nsfns.m (ns_tooltip): Initialize.
4094
9e63b4a5
EZ
40952013-04-28 Eli Zaretskii <eliz@gnu.org>
4096
4097 * coding.c (decode_coding_gap): Don't remove the character before
4098 a newline unless it's a CR character. (Bug#14287)
4099
ad60824e
DN
41002013-04-28 Dan Nicolaescu <dann@gnu.org>
4101
4102 * dispextern.h (struct face): Move enum face_underline_type
4103 earlier so that bitfields can be in the same word.
4104
edbdcec0
JD
41052013-04-28 Jan Djärv <jan.h.d@swipnet.se>
4106
4107 * nsfns.m (handlePanelKeys): New function.
4108 (EmacsOpenPanel:performKeyEquivalent:)
4109 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
4110 arrows/function/control and copy/paste keys (Bug#14296).
4111
0208ede7
JL
41122013-04-27 Juri Linkov <juri@jurta.org>
4113
4114 * callint.c (Fcall_interactively): Call `Qread_number' for
4115 interactive code letter `n' instead of using duplicate code.
4116 (Bug#14254)
4117
b8dd59f7
PE
41182013-04-27 Paul Eggert <eggert@cs.ucla.edu>
4119
4120 * systime.h (make_timeval): Declare as 'const'.
4121
8bd722db
KH
41222013-04-27 Kenichi Handa <handa@gnu.org>
4123
4124 * font.c (font_open_entity): Always open a font of manageable
4125 size.
4126
13d0e56f 41272013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 4128
f780d632
PE
4129 Port better to AIX (Bug#14258).
4130 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
4131 to pacify AIX xlc.
4132
ec509856
KH
41332013-04-24 Kenichi Handa <handa@gnu.org>
4134
4135 * coding.c (decode_coding_iso_2022): When an invalid escape
4136 sequence is encountered, reset the invocation and designation
4137 status to the safest one.
4138
84fc48e5
PE
41392013-04-22 Paul Eggert <eggert@cs.ucla.edu>
4140
4141 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
4142 Without this fix, "make distclean" leaves stamp-h1 behind.
4143
806bda47
EC
41442013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
4145
4146 * w32fns.c (w32_fullscreen_rect): New function to compute the
4147 window rectangle for the given fullscreen mode.
4148 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
4149 longer tunes the window size. This keeps the window's edges flush
4150 with the screen and allows the taskbar to hide itself in fullboth.
4151
4152 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
4153 window decorations and uses the entire screen.
4154
4155 * w32term.h (w32_fullscreen_rect) Add prototype.
4156 (struct w32_output): Replace normal_width, normal_height,
4157 normal_top, and normal_left members with a single normal_placement
4158 struct.
4159 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
4160 Remove macros.
4161 (FRAME_NORMAL_PLACEMENT): New macro.
4162
9cc2810b
JB
41632013-04-16 Juanma Barranquero <lekktu@gmail.com>
4164
4165 * minibuf.c (Ftest_completion): Silence compiler warning.
4166
fd16b54c
EZ
41672013-04-15 Eli Zaretskii <eliz@gnu.org>
4168
4169 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 4170 bug#14062.
fd16b54c
EZ
4171
4172 * frame.h (WINDOW_FRAME): Protect macro and its argument with
4173 parentheses.
4174
4175 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
4176 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
4177 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
4178 parentheses where appropriate.
4179
9e3379a0
PE
41802013-04-14 Paul Eggert <eggert@cs.ucla.edu>
4181
4182 * keyboard.c (timer_start_idle): Remove no-longer-used local.
4183
ddd6b685
EZ
41842013-04-14 Eli Zaretskii <eliz@gnu.org>
4185
4186 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
4187 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
4188 Mention in the doc string that setting these variables takes
4189 effect only after a call to set-window-buffer. (Bug#14200)
4190
29b79ba1
EZ
41912013-04-13 Eli Zaretskii <eliz@gnu.org>
4192
4193 * indent.c (Fvertical_motion): Don't consider display strings on
4194 overlay strings as display strings on the buffer position we
4195 started from. This prevents vertical cursor motion from jumping
4196 more than one line when there's an overlay string with a display
4197 property at end of line.
4198 Reported by Karl Chen <Karl.Chen@quarl.org> in
4199 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
4200
562c6ee9
SM
42012013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
4202
4203 * window.c (select_window): `record_buffer' even if window is
4204 already selected (bug#14191).
4205
fcc1fe85
EZ
42062013-04-11 Eli Zaretskii <eliz@gnu.org>
4207
4208 * window.c (Fwindow_end): Test more flags, including the buffer's
4209 last_overlay_modified flag, to determine whether the window's
4210 display is really up-to-date. Prevents the function from
4211 returning a stale value. (Bug#14170)
4212 (Fwindow_line_height): Fix the test for up-to-date-ness of the
4213 current matrix.
4214
f009190a
EZ
42152013-04-10 Eli Zaretskii <eliz@gnu.org>
4216
4217 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
4218 garbaged only if it is not already the top frame on its TTY.
4219 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
4220 there are GUI frames open in the same session. (Bug#13864)
4221
78ce603d
SM
42222013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
4223
4224 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
4225 of marking the idle timers directly.
4226
a8036e40
SM
42272013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
4228
4229 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
4230 tables (bug#14054).
4231
7ffe7ef6
SM
42322013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
4233
4234 * window.c (select_window): Don't record_buffer while the invariant is
4235 temporarily broken (bug#14161).
4236
4237 * fns.c (Fdelq): Don't assume !NILP => CONSP.
4238
7d9f6883
EZ
42392013-04-07 Eli Zaretskii <eliz@gnu.org>
4240
4241 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
4242
5406cfd9
RF
42432013-04-07 Romain Francoise <romain@orebokech.com>
4244
4245 Ignore additional platform-specific ACL errors (Bug#13702).
4246 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
4247 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
4248
95c0e83b
JD
42492013-03-31 Jan Djärv <jan.h.d@swipnet.se>
4250
4251 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
4252 f->output_data.ns.
4253
876da980
PE
42542013-04-07 Paul Eggert <eggert@cs.ucla.edu>
4255
4256 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
4257 This bug was introduced by my 2013-02-25 change that simplified
4258 data_start configuration. Without this change, on GNU/Linux
4259 an Emacs configured with --enable-profiling fails immediately
4260 due to a profiler signal.
4261 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
4262 with these flags. On platforms where special flags are needed
4263 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
4264 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
4265 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
4266
7452b7bd
DA
42672013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
4268
4269 Get rid of some platform-specific functions examining window
4270 system and its capabilities. This is a partial rework of the
4271 2013-04-05 change.
4272 * lisp.h (have_menus_p): Remove prototype. This function is
4273 replaced with platform-independent window_system_available.
4274 (check_window_system): Move to...
4275 * frame.h (decode_window_system_frame, window_system_available):
4276 ...here, add new prototypes.
4277 * frame.c (window_system_available, decode_window_system_frame):
4278 New functions.
4279 (check_window_system): Platform-independent now.
4280 * xterm.h (x_in_use): Remove declaration.
4281 (check_x_frame):
4282 * w32term.h (check_x_frame):
4283 * nsterm.h (check_x_frame): Remove prototypes. This function
4284 is replaced with platform-independent decode_window_system_frame.
4285 * msdos.c (have_menus_p): Remove.
4286 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
4287 Remove platform-specific functions. Use check_window_system,
4288 decode_window_system_frame and check_ns_display_info where
4289 appropriate. Minor style and comment tweaks.
4290 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
4291 (check_x_frame): Likewise.
4292 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
4293 Likewise.
4294 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
4295 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
4296 * xmenu.c, xselect.c: All related users changed.
4297
251e9147
KH
42982013-04-03 Kenichi Handa <handa@gnu.org>
4299
4300 The following changes is to optimize the code for reading UTF-8
4301 files.
4302
562c6ee9 4303 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
4304 changed. Check EOL format. Do not call adjust_coding_eol_type
4305 here.
4306 (check_utf_8): New function.
4307 (adjust_coding_eol_type): Do nothing if already adjusted.
4308 (detect_coding): Compare the return value of check_ascii with
4309 coding->src_bytes. Call adjust_coding_eol_type if necessary.
4310 (decode_coding_gap): Optimize for valid UTF-8.
4311
8bc369d4
KH
43122013-03-21 Kenichi Handa <handa@gnu.org>
4313
4314 * coding.c (syms_of_coding): Cancel previous change.
4315
4316 * insdel.c (insert_from_gap): Fix previous change.
4317
73931ad1
DA
43182013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
4319
4320 Consistently use platform-specific function to detect window system.
4321 * lisp.h (check_window_system): New prototype. This function is
4322 going to replace check_x, check_w32 and check_ns.
4323 (have_menus_p): Mention msdos.c in comment.
4324 * fontset.c (check_window_system_func): Remove. Adjust all users.
4325 * fontset.h (check_window_system_func): Remove prototype.
4326 * nsterm.h (check_ns):
4327 * xterm.h (check_x):
4328 * w32term.h (check_w32): Likewise.
4329 * menu.c (Fx_popup_menu): Use check_window_system.
4330 * msdos.c (check_window_system): Define for MS-DOS.
4331 * nsfns.m (check_window_system): Define for NS. Adjust all users.
4332 * w32fns.c (check_window_system): Likewise for MS-Windows.
4333 * xfns.c (check_window_system): Likewise for X.
4334 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
4335 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
4336
7216e43b
PE
43372013-04-02 Paul Eggert <eggert@cs.ucla.edu>
4338
4339 Prefer < to > in range checks such as 0 <= i && i < N.
4340 This makes it easier to visualize quantities on a number line.
4341 This patch doesn't apply to all such range checks,
4342 only to the range checks affected by the 2013-03-24 change.
4343 This patch reverts most of the 2013-03-24 change.
4344 * alloc.c (xpalloc, Fgarbage_collect):
4345 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
4346 * character.c (string_escape_byte8):
4347 * charset.c (read_hex):
4348 * data.c (cons_to_unsigned):
4349 * dispnew.c (update_frame_1):
4350 * doc.c (Fsubstitute_command_keys):
4351 * doprnt.c (doprnt):
4352 * editfns.c (hi_time, decode_time_components):
4353 * fileio.c (file_offset):
4354 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
4355 * font.c (font_intern_prop):
4356 * frame.c (x_set_alpha):
4357 * gtkutil.c (get_utf8_string):
4358 * indent.c (check_display_width):
4359 * keymap.c (Fkey_description):
4360 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
4361 * lread.c (read1):
4362 * minibuf.c (read_minibuf_noninteractive):
4363 * process.c (wait_reading_process_output):
4364 * search.c (Freplace_match):
4365 * window.c (get_phys_cursor_glyph):
4366 * xdisp.c (redisplay_internal):
4367 * xsmfns.c (smc_save_yourself_CB):
4368 Prefer < to > for range checks.
4369 * dispnew.c (sit_for): Don't mishandle NaNs.
4370 This fixes a bug introduced in the 2013-03-24 change.
4371 * editfns.c (decode_time_components): Don't hoist comparison.
4372 This fixes another bug introduced in the 2013-03-24 change.
4373
92759988
DA
43742013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
4375
4376 * frame.h (struct frame): Drop scroll_bottom_vpos
4377 member becaue all real users are dead long ago.
4378 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
4379 * xdisp.c (redisplay_internal): Adjust user.
4380
9a1971bb
GM
43812013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
4382
f38ab167
JD
4383 * nsmenu.m (showAtX:Y:for:): setLevel to
4384 NSPopUpMenuWindowLevel (Bug#13998).
4385
6d01f1fe
JD
43862013-03-30 Jan Djärv <jan.h.d@swipnet.se>
4387
4388 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
4389 (ns_check_pending_open_menu): Declare.
4390
4391 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
4392 (x_activate_menubar): Update the menu with title that matches
4393 ns_get_pending_menu_title, and call
4394 ns_check_pending_openmenu (Bug#12698).
4395 (menuWillOpen:): New method.
4396 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
4397
4398 * nsterm.m (menu_will_open_state, menu_mouse_point)
4399 (menu_pending_title): New varaibles.
4400 (ns_get_pending_menu_title, ns_check_menu_open)
4401 (ns_check_pending_open_menu): New functions.
4402
781f4782
DA
44032013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
4404
4405 * indent.c (current_column_bol_cache): Remove leftover which is not
4406 used in Fmove_to_column any more.
4407 (current_column, scan_for_column): Adjust users.
4408 * keyboard.c (last_point_position_buffer, last_point_position_window):
4409 Remove leftovers which are not used for recording undo any more.
4410 (command_loop_1, syms_of_keyboard): Adjust users.
4411 * xdisp.c (last_max_ascent): Remove leftover which is not used in
4412 redisplay_window any more.
4413 (move_it_to): Adjust user.
4414
1921c31b
JB
44152013-03-29 Juanma Barranquero <lekktu@gmail.com>
4416
4417 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
4418 Update dependencies.
4419
717b8bcd
SM
44202013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4421
4422 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
4423 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
4424 forward references.
4425
e74aeda8
DA
44262013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
4427
4428 * window.h (struct window): Replace hchild, vchild and buffer slots
4429 with the only contents slot. This is possible because each valid
4430 window may have either the child window (in vertical or horizontal
4431 combination) or buffer to display (for the leaf window). Using that,
4432 a lof of operations to traverse and/or change window hierarchies may
4433 be simplified. New member horizontal is used to distinguish between
4434 horizontal and vertical combinations of internal windows.
4435 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
4436 (WINDOW_VERTICAL_COMBINATION_P): New macros.
4437 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
4438 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
4439 Use contents slot, not buffer, where appropriate.
4440 (wset_combination): New function.
4441 (wset_buffer): Add eassert.
4442 (Fframe_first_window): Simplify the loop reaching first window.
4443 (Fwindow_buffer): Use WINDOW_LEAF_P.
4444 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
4445 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
4446 (unshow_buffer): Convert initial debugging check to eassert.
4447 (replace_window, recombine_windows, Fdelete_other_windows_internal)
4448 (make_parent_window, window_resize_check, window_resize_apply)
4449 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
4450 (Fset_window_configuration, delete_all_child_windows, save_window_save):
4451 Adjust to match struct window changes.
4452 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
4453 (mark_window_cursors_off, count_windows, get_leaf_windows)
4454 (foreach_window_1): Simplify the loop.
4455 * alloc.c (mark_object): Do not check for the leaf window because
4456 internal windows has no glyph matrices anyway.
4457 * dispnew.c (clear_window_matrices, showing_window_margins_p)
4458 (allocate_matrices_for_window_redisplay, fake_current_matrices)
4459 (allocate_matrices_for_frame_redisplay, free_window_matrices)
4460 (build_frame_matrix_from_window_tree, mirror_make_current)
4461 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
4462 (update_window_tree, set_window_update_flags): Simplify the loop.
4463 (sync_window_with_frame_matrix_rows): Enforce live window.
4464 Use contents slot, not buffer, where appropriate.
4465 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
4466 and WINDOW_HORIZONTAL_COMBINATION_P.
4467 (make_frame_visible_1): Simplify the loop.
4468 Use contents slot, not buffer, where appropriate.
4469 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
4470 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
4471 (expose_window_tree): Likewise.
4472 Use contents slot, not buffer, where appropriate.
4473 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
4474 to avoid deleted windows. Use contents slot instead of buffer.
4475 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
4476 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
4477 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
4478 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
4479
121ab1cd
EZ
44802013-03-28 Eli Zaretskii <eliz@gnu.org>
4481
ef454cf7
EZ
4482 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
4483 identify the reasons for assertion violations in bug#14062 and
4484 similar ones.
21e930f8
EZ
4485 (Fx_show_tip): Fix compilation error under
4486 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 4487
121ab1cd
EZ
4488 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
4489 Reported by <rzl24ozi@gmail.com>.
4490
5c89ca24
DA
44912013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
4492
4493 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
4494 start marker...
562c6ee9
SM
4495 (unwind_with_echo_area_buffer): ...to restore it here.
4496 This is needed to ensure that...
5c89ca24
DA
4497 (redisplay_window): ...both window markers are valid here,
4498 which is verified by eassert.
4499 * editfns.c (save_excursion_save): Do not assume that
4500 selected_window always displays the buffer.
c7f53895
DA
4501 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
4502 Fix comment.
5c89ca24 4503
f557c1b1
SM
45042013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
4505
4506 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
4507 the upcase table.
4508
40693bba 45092013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
4510
4511 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
4512
c86f791f
EZ
45132013-03-27 Eli Zaretskii <eliz@gnu.org>
4514
4515 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
4516 since MinGW's w32api headers do. This avoids compiler warnings.
4517
4518 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
4519 if already defined.
4520
c6e72e17
EZ
45212013-03-26 Eli Zaretskii <eliz@gnu.org>
4522
4523 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
4524
54e95010
JD
45252013-03-26 Jan Djärv <jan.h.d@swipnet.se>
4526
4527 * gtkutil.c (style_changed_cb): Check if frame is live and an
4528 X frame (Bug#14038).
4529
b88b62de
EZ
45302013-03-26 Eli Zaretskii <eliz@gnu.org>
4531
a18d7de6
EZ
4532 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
4533 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
4534 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
4535 MinGW64.
8f5e14c8
EZ
4536 Move inclusion of time.h before sys/time.h, so that MinGW64 could
4537 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 4538
b88b62de
EZ
4539 Fix incompatibilities between MinGW.org and MinGW64 headers.
4540 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
4541
4542 * w32.c (REPARSE_DATA_BUFFER): Guard with
4543 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
4544
c074e458
JD
45452013-03-25 Jan Djärv <jan.h.d@swipnet.se>
4546
4547 * xterm.c: Include X11/XKBlib.h
4548 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
4549
908589fd
AS
45502013-03-24 Andreas Schwab <schwab@linux-m68k.org>
4551
4552 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
4553 written backwards.
4554 * blockinput.h (input_blocked_p): Likewise.
4555 * bytecode.c (exec_byte_code): Likewise.
4556 * callproc.c (call_process_kill, call_process_cleanup)
4557 (Fcall_process): Likewise.
4558 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
4559 (Fccl_execute_on_string): Likewise.
4560 * character.c (string_escape_byte8): Likewise.
4561 * charset.c (read_hex): Likewise.
4562 * cm.c (calccost): Likewise.
4563 * data.c (cons_to_unsigned): Likewise.
4564 * dired.c (directory_files_internal, file_name_completion):
4565 Likewise.
4566 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
4567 (sit_for): Likewise.
4568 * doc.c (Fsubstitute_command_keys): Likewise.
4569 * doprnt.c (doprnt): Likewise.
4570 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
4571 * emacsgtkfixed.c: Likewise.
4572 * fileio.c (file_offset, Fwrite_region): Likewise.
4573 * floatfns.c (Fexpt, fmod_float): Likewise.
4574 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
4575 Likewise.
4576 * font.c (font_intern_prop): Likewise.
4577 * frame.c (x_set_alpha): Likewise.
4578 * gtkutil.c (get_utf8_string): Likewise.
4579 * indent.c (check_display_width): Likewise.
4580 * intervals.c (create_root_interval, rotate_right, rotate_left)
4581 (split_interval_right, split_interval_left)
4582 (adjust_intervals_for_insertion, delete_node)
4583 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4584 (merge_interval_right, merge_interval_left, copy_intervals)
4585 (set_intervals_multibyte_1): Likewise.
4586 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
4587 * keymap.c (Fkey_description): Likewise.
4588 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
4589 * lread.c (openp, read_integer, read1, string_to_number):
4590 Likewise.
4591 * menu.c (ensure_menu_items): Likewise.
4592 * minibuf.c (read_minibuf_noninteractive): Likewise.
4593 * print.c (printchar, strout): Likewise.
4594 * process.c (create_process, Faccept_process_output)
4595 (wait_reading_process_output, read_process_output, send_process)
4596 (wait_reading_process_output): Likewise.
4597 * profiler.c (make_log, handle_profiler_signal): Likewise.
4598 * regex.c (re_exec): Likewise.
4599 * regex.h: Likewise.
4600 * search.c (looking_at_1, Freplace_match): Likewise.
4601 * sysdep.c (get_child_status, procfs_ttyname)
4602 (procfs_get_total_memory): Likewise.
4603 * systime.h (EMACS_TIME_VALID_P): Likewise.
4604 * term.c (dissociate_if_controlling_tty): Likewise.
4605 * window.c (get_phys_cursor_glyph): Likewise.
4606 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
4607 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
4608 Likewise.
4609 * xfns.c (Fx_window_property): Likewise.
4610 * xmenu.c (set_frame_menubar): Likewise.
4611 * xselect.c (x_get_window_property, x_handle_dnd_message):
4612 Likewise.
4613 * xsmfns.c (smc_save_yourself_CB): Likewise.
4614 * xterm.c (x_scroll_bar_set_handle): Likewise.
4615
2bf7d27a
DA
46162013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
4617
4618 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
4619 to be optional or nil. Adjust comment and convert it to docstring.
4620 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
4621 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
4622
a9ebfa0b
PE
46232013-03-24 Paul Eggert <eggert@cs.ucla.edu>
4624
4625 Static checking by GCC 4.8-20130319.
4626 * image.c (gif_load): Assume pass < 3 to pacify GCC.
4627 * process.c (Fset_process_datagram_address)
4628 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
4629 * xdisp.c (get_char_face_and_encoding):
4630 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
4631 (get_glyph_face_and_encoding): Prepare face before possibly using it.
4632 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
4633
4f3576ee
KB
46342013-03-24 Ken Brown <kbrown@cornell.edu>
4635
789b5e9a
KB
4636 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
4637 fix compilation on 64-bit Cygwin, where underscores are not
4638 automatically prepended.
4639
4f3576ee
KB
4640 * w32term.c (w32_initialize): Silence compiler warning.
4641
b5b7745f
EZ
46422013-03-23 Eli Zaretskii <eliz@gnu.org>
4643
cdc0d0bd
EZ
4644 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
4645 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
4646 variables, to save and restore frame dimensions.
4647 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
4648 after returning from a 'fullscreen' configuration.
4649 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
4650 to avoid races between the main thread and the input thread.
4651
4652 * w32term.h (struct w32_output): New members normal_width,
4653 normal_height, normal_top, normal_left, and prev_fsmode.
4654 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
4655 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
4656 members of a frame.
4657
b5b7745f
EZ
4658 * w32term.c (w32fullscreen_hook): Record last value of the frame's
4659 'fullscreen' parameter. Always record previous width and height
4660 of the frame, except when switching out of maximized modes, so
4661 that they could be restored correctly, instead of resetting to the
4662 default frame dimensions. Send SC_RESTORE command to the frame,
4663 unless we are going to send SC_MAXIMIZE, to restore the frame
4664 resize hints in the mouse pointer shown by the window manager.
4665 (Bug#14032)
4666
4667 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
4668
4669 * lisp.h (get_frame_param): Adjust conditions for prototype
4670 declaration.
4671
a3454eed
KB
46722013-03-22 Ken Brown <kbrown@cornell.edu>
4673
4674 * unexcw.c: Drop unneeded inclusion of w32common.h.
4675 (report_sheap_usage): Declare.
4676 (read_exe_header): Add magic numbers for x86_64.
4677 (fixup_executable): Fix printf format specifier for unsigned long
4678 argument.
4679
5a49b79c
DA
46802013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
4681
4682 * frame.h (struct frame): Put menu_bar_window under #ifdef
4683 because this member is not needed when X toolkit is in use.
4684 (fset_menu_bar_window):
4685 * dispnew.c (clear_current_matrices, clear_desired_matrices)
4686 (free_glyphs, update_frame):
4687 * xdisp.c (expose_frame): Likewise.
4688 (display_menu_bar): Likewise. Remove redundant eassert.
4689 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
4690 toolkit is in use.
4691
d6723bf7
PE
46922013-03-21 Paul Eggert <eggert@cs.ucla.edu>
4693
7b1123d8
PE
4694 Use functions and constants to manipulate Lisp_Save_Value objects.
4695 This replaces code that used macros and strings and token-pasting.
4696 The change makes the C source a bit easier to follow,
4697 and shrinks the Emacs executable a bit.
4698 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
4699 (make_save_value): Change 1st arg from string to enum. All callers
4700 changed.
4701 (INTX): Remove.
4702 (mark_object): Use if, not #if, for GC_MARK_STACK.
4703 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
4704 (XSAVE_OBJECT): Now functions, not macros.
4705 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
4706 the constant was never used.
4707 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
4708 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
4709 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
4710 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
4711 New constants.
4712 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
4713 type3 with a single member save_type. All uses changed.
4714 (save_type, set_save_pointer, set_save_integer): New functions.
4715 * print.c (PRINTX): Remove.
4716
d6723bf7
PE
4717 * alloc.c: Remove redundant static declarations.
4718
5f24fa51
DA
47192013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4720
4721 * window.h (struct window): Convert left_col, top_line, total_lines
4722 and total_cols from Lisp_Objects to integers. Adjust comments.
4723 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
4724 Remove.
4725 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
4726 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
4727 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
4728 Adjust users where appropriate.
4729
42143acd
DA
47302013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4731
4732 * frame.h (struct frame): Drop resx and resy because the same data is
4733 available from window system-specific output context. Adjust users.
562c6ee9
SM
4734 (default_pixels_per_inch_x, default_pixels_per_inch_y):
4735 New functions to provide defaults when no window system available.
42143acd 4736 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 4737 (NUMVAL): Move from xdisp.c.
42143acd
DA
4738 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
4739 (Ffont_face_attributes, Fopen_font):
4740 * image.c (gs_load):
4741 * w32font.c (fill_in_logfont):
4742 * xdisp.c (calc_pixel_width_or_height):
4743 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
4744 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
4745
c0a17406
KH
47462013-03-20 Kenichi Handa <handa@gnu.org>
4747
4748 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
4749 to 1 (temporary workaround until a bug related to ASCII
4750 optimization is fixed).
4751
095d384d
DA
47522013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
4753
4754 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
4755 Signal error if window is not internal. Adjust docstring.
4756 (delete_all_child_windows): Use combination_limit to save the buffer.
4757 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
4758 * print.c (syms_of_print): Initialize debugging output not here...
4759 (init_print_once): ...but in a new function here.
4760 * lisp.h (init_print_once): Add prototype.
4761 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 4762
748fa866
DA
47632013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
4764
4765 * window.c (window_resize_check, window_resize_apply)
4766 (window_from_coordinates, recombine_windows, set_window_buffer)
4767 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
4768 (Fsplit_window_internal, Fdelete_window_internal)
4769 (freeze_window_starts): Use bool for booleans.
4770 * window.h (window_frame_coordinates, resize_frame_windows)
4771 (freeze_window_starts, set_window_buffer): Adjust prototypes.
4772
81519fd2
SM
47732013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
4774
4775 * dispnew.c (bitch_at_user): Use `user-error'.
4776
6db423a9
KB
47772013-03-17 Ken Brown <kbrown@cornell.edu>
4778
4779 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
4780 as return type of image_background. (Bug#13981)
4781 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
4782
8f2906f5
JD
47832013-03-16 Jan Djärv <jan.h.d@swipnet.se>
4784
960ce480 4785 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 4786 (ns_select): Don't return with result uninitialized.
960ce480 4787
8f2906f5
JD
4788 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
4789 and getDirectory.
4790
81519fd2
SM
4791 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
4792 New functions.
8f2906f5
JD
4793 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
4794 directories. If filename is nil, get directory name (Bug#13932).
4795 Use getFilename and getDirectory.
4796 (getFilename, getDirectory): New methods for EmacsSavePanel and
4797 EmacsOpenPanel.
4798 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
4799
cded56c1
PE
48002013-03-15 Paul Eggert <eggert@cs.ucla.edu>
4801
4802 * coding.c (decode_coding_gap): Fix typo caught by static checking.
4803
251e9147 48042013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
4805
4806 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
4807 (adjust_after_replace): Make it back to static. Delete the third
4808 arg text_at_gap_tail. Cancel the code for handling it.
4809
4810 * coding.h (struct coding_system): New member eol_seen.
4811
4812 * coding.c (detect_ascii): New function.
4813 (detect_coding): Set coding->head_ascii and coding->eol_seen only
4814 when the source bytes are actually scanned. On detecting for
4815 coding_category_utf_8_auto, call detect_ascii instead of scanning
4816 source bytes directly.
4817 (produce_chars): Call insert_from_gap with the new arg 0.
4818 (encode_coding): Likewise.
4819 (decode_coding_gap): Control ASCII optimization by the variable
4820 disable_ascii_optimization instead of #ifndef .. #endif.
4821 Deccode EOL format according to coding->eol_seen.
4822 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
4823 variable.
4824
8a44e6d1
KH
4825 * lisp.h (adjust_after_replace): Cancel externing it.
4826 (insert_from_gap): Adjust prototype.
4827
5f795e34
EZ
48282013-03-15 Eli Zaretskii <eliz@gnu.org>
4829
4830 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
4831 FULLSCREEN_MAXIMIZED. (Bug#13935)
4832
f258b4be
DA
48332013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
4834
4835 * region-cache.c (find_cache_boundary, move_cache_gap)
4836 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
4837 Simplify debugging check and convert to eassert. Adjust comment.
4838 (pp_cache): Put under ENABLE_CHECKING.
4839
a5cc4dde
EZ
48402013-03-14 Eli Zaretskii <eliz@gnu.org>
4841
4842 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
4843 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
4844 and WM_ACTIVATEAPP.
4845 (w32fullscreen_hook): If the frame is visible, reset
4846 f->want_fullscreen flag after changing the frame size. If the
4847 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
4848 (Bug#13953)
4849
3fc5e44a
DC
48502013-03-13 Daniel Colascione <dancol@dancol.org>
4851
4852 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
4853 too so that these builds can use Cygwin's file conversion
4854 functions. (We've been building and linking cygw32.o all along
4855 and just not using it.)
4856
47d7532e
PE
48572013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4858
4859 File synchronization fixes (Bug#13944).
4860 * Makefile.in (LIB_FDATASYNC): New macro.
4861 (LIBES): Use it.
4862 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
4863 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
4864 Don't worry about HAVE_FSYNC, since a substitute fsync is
4865 available if the system lacks one.
4866 (Fwrite_regin): Retry fsync if interrupted.
4867
c7ffccaf
EZ
48682013-03-13 Eli Zaretskii <eliz@gnu.org>
4869
4e2df81d 4870 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
4871 activated, call w32fullscreen_hook, to make sure the new frame
4872 dimensions are in effect. (Bug#13937)
4873
8a7debc1
DA
48742013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
4875
4876 * xdisp.c (init_iterator): Simplify because both character and byte
4877 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
4878 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
4879 character and byte positions can be obtained from marker.
8a7debc1 4880
7fd8c501
PE
48812013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4882
d9df6f40
PE
4883 Static checking by Sun C 5.12.
4884 * alloc.c (buffer_memory_full) [REL_ALLOC]:
4885 * bytecode.c (exec_byte_code):
4886 * dispnew.c (init_display):
4887 * eval.c (error):
4888 * fileio.c (Fsubstitute_in_file_name):
4889 * keyboard.c (Fevent_convert_list):
4890 * keymap.c (Fsingle_key_description):
4891 * term.c (maybe_fatal, fatal):
4892 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
4893 * xsmfns.c (Fhandle_save_session):
4894 Omit unreachable code.
4895 * keymap.c (map_keymap_char_table_item): Cast void * to
4896 a function pointer type; the C Standard requires this.
4897
7fd8c501
PE
4898 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
4899 Include <sys/param.h> unconditionally, as that works elsewhere and
4900 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
4901 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
4902 and FreeBSD now.
4903
a020afb9 4904See ChangeLog.12 for earlier changes.
aac0c6e3
MR
4905
4906;; Local Variables:
4907;; coding: utf-8
aac0c6e3
MR
4908;; End:
4909
ab422c4d 4910 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
4911
4912 This file is part of GNU Emacs.
4913
4914 GNU Emacs is free software: you can redistribute it and/or modify
4915 it under the terms of the GNU General Public License as published by
4916 the Free Software Foundation, either version 3 of the License, or
4917 (at your option) any later version.
4918
4919 GNU Emacs is distributed in the hope that it will be useful,
4920 but WITHOUT ANY WARRANTY; without even the implied warranty of
4921 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4922 GNU General Public License for more details.
4923
4924 You should have received a copy of the GNU General Public License
4925 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.