Remove byte compiler warnings, visible when compiling with
[bpt/emacs.git] / src / ChangeLog
CommitLineData
9c253307
DA
12013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
2
3 * term.c (get_named_tty, create_tty_output, tty_free_frame_resources)
4 (tty_free_frame_resources, delete_tty): Prefer eassert to emacs_abort.
5 * image.c (make_image_cache): For struct image_cache, prefer xmalloc
6 to xzalloc and so avoid redundant call to memset.
7 * xterm.c (x_term_init): Avoid unnecessary initializations of dpyinfo
8 members because it is allocated with xzalloc and so already zeroed.
9
05e64f9f
KB
102013-08-14 Ken Brown <kbrown@cornell.edu>
11
12 * gmalloc.c (memalign) [CYGWIN]: Rename to emacs_memalign
13 (Bug#15094).
14
5b71542d
DA
152013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
16
17 Utility function and macro to copy Lisp string to C string.
18 * lisp.h (xlispstrdupa): New macro.
19 (xlispstrdup): New prototype.
20 * alloc.c (xlispstrdup): New function.
21 * callint.c (Fcall_interactively):
22 * fileio.c (Ffile_name_directory, Fexpand_file_name)
23 (Fsubstitute_in_file_name):
24 * frame.c (Fmake_terminal_frame): Use xlispstrdupa.
25 * image.c (x_create_bitmap_from_file):
26 * w32term.c (w32_term_init):
27 * xterm.c (x_term_init): Use xlispstrdup.
28
71530c97
LMI
292013-08-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
30
4ce82fb8
LMI
31 * image.c (imagemagick_load_image): Make animated pictures work.
32 There's still some problems with background color settings, though
33 (bug#14700).
34
71530c97
LMI
35 * decompress.c (unwind_decompress): Always restore point.
36
7510a061
XF
372013-08-14 Xue Fuqiao <xfq.free@gmail.com>
38
39 * marker.c (set_marker): Reformat documentation.
40
01c3051f
PE
412013-08-14 Paul Eggert <eggert@cs.ucla.edu>
42
aab1fcdf
PE
43 * xdisp.c (cursor_type_changed): Now static.
44
01c3051f
PE
45 * image.c (imagemagick_filename_hint): New arg HINT_BUFFER.
46 Use changed. This avoids the need to call xmalloc and for the
47 caller to call xfree, and avoids memory leaks in some situations.
48
2084152a
DA
492013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
50
51 * xdisp.c (adjust_window_ends): Move duplicated code to new function.
52 (try_window, try_window_reusing_current_matrix, try_window_id): Use it.
94a4e898
DA
53 (redisplay_window): If window_end_valid is cleared due to non-zero
54 windows_or_buffers_changed, clear current_matrix_up_to_date_p and
55 so do not call to try_cursor_movement for that window.
2084152a 56
02455cb6
DA
572013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
58
59 * window.h (struct window): Convert window_end_pos and
60 window_end_vpos from Lisp_Object to ptrdiff_t and int, respectively.
61 (wset_window_end_pos, wset_window_end_vpos): Remove.
62 * dispnew.c (adjust_glyph_matrix):
63 * window.c (Fwindow_end, replace_window, set_window_buffer)
64 (make_window):
65 * xdisp.c (check_window_end, move_it_to, redisplay_internal)
66 (set_vertical_scroll_bar, redisplay_window, try_window)
67 (try_window_reusing_current_matrix, find_first_unchanged_at_end_row)
68 (try_window_id, decode_mode_spec, mouse_face_from_buffer_pos)
69 (note_mouse_highlight): Adjust users.
70 (try_cursor_movement): Likewise. Convert old precondition to eassert.
71 Add comment.
72
da5707e8
DA
732013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
74
75 Fix --enable-gcc-warnings errors introduced in 2013-08-13 commit.
76 * image.c (imagemagick_filename_hint): Use `const char *' and
77 prefer SSDATA to SDATA to avoid warnings.
78
25554267
DA
792013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
80
81 Cleanup window fringes, margins and scroll bars adjustments.
82 * window.c (set_window_fringes, set_window_margins)
83 (set_window_scroll_bars, apply_window_adjustment): New functions.
84 (set_window_buffer, Fset_window_margins, Fset_window_fringes)
85 (Fset_window_scroll_bars): Use them.
86
38a2c910
DA
872013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
88
89 * window.h (struct window): Convert scroll_bar_width
90 from Lisp_Object to integer. Adjust comment.
91 (WINDOW_CONFIG_SCROLL_BAR_WIDTH, WINDOW_CONFIG_SCROLL_BAR_COLS):
92 Adjust users.
93 * window.c (wset_scroll_bar_width): Remove.
94 (make_window): Initialize scroll_bar_width.
95 (Fsplit_window_internal): Use direct assignment.
96 (Fset_window_configuration, save_window_save):
97 Convert Lisp_Object to integer and back where appropriate.
98 (Fset_window_scroll_bars): Adjust user. Return t if any scroll
99 bar was actually changed, and mention this in docstring.
100
2d065031
PE
1012013-08-13 Paul Eggert <eggert@cs.ucla.edu>
102
103 * decompress.c: Minor simplifications.
104 (Fzlib_decompress_region): Don't bother verifying
105 that avail_out <= UINT_MAX, as that was confusing.
106 Mention the restriction in a comment instead.
107 Prefer 'int' to 'ptrdiff_t' when 'int' is wide enough.
108
a5bd5abb
JD
1092013-08-13 Jan Djärv <jan.h.d@swipnet.se>
110
111 * nsmenu.m (x_activate_menubar): Check for OSX >= 10.5
112 (trackingNotification:): Call ns_check_menu_open only for OSX >= 10.5.
113
66e7901a
LMI
1142013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
115
116 * image.c (imagemagick_filename_hint): Check for errors in the
117 alist structure.
118
2fa611b7
EZ
1192013-08-13 Eli Zaretskii <eliz@gnu.org>
120
121 * window.c (Fwindow_margins): Return nil when there's no marginal
122 area, as per the documented API.
123
124 * w32term.c (x_scroll_bar_create): Use ALLOCATE_PSEUDOVECTOR, not
125 Fmake_vector, as scroll bar's struct members are not all Lisp
126 objects now. This avoids crashes in GC.
127
128 * w32term.h (struct scroll_bar): Convert fringe_extended_p to a
129 bool, so its address could be taken.
130
8259030d
LMI
1312013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
132
133 * image.c (imagemagick_filename_hint): New function to possibly
134 apply `image-content-type-suffixes'.
135 (imagemagick_load_image): Use it.
136
866c710e
EZ
1372013-08-13 Eli Zaretskii <eliz@gnu.org>
138
139 * decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil
140 if loading zlib failed.
141
f10490f0
JD
1422013-08-13 Jan Djärv <jan.h.d@swipnet.se>
143
96311be7
JD
144 * nsterm.m (ns_set_vertical_scroll_bar): Fix breakage intruduced by
145 2013-08-13 checkin below. Change bool to BOOL, rule is:
146 All Obj-C code uses BOOL, except for interfaces callable from C.
147
f10490f0
JD
148 * nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).
149
c8ae93b0
DA
1502013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
151
152 * window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
153 * nsterm.m (ns_set_vertical_scroll_bar): Use it. Use convenient
154 bool instead of BOOL.
155 * w32term.h (struct scroll_bar): Convert fringe_extended_p
156 from Lisp_Object to bitfield. Adjust comment.
157 * w32term.c (x_scroll_bar_create): Adjust user.
158 Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
159 * xterm.c (XTset_vertical_scroll_bar): Likewise.
160 Use bool for boolean.
161 * xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
162 to `unsigned int' when defining a bitfield.
163
53b64418
PE
1642013-08-13 Paul Eggert <eggert@cs.ucla.edu>
165
166 * decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
167
eeaf9bf3
DA
1682013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
169
170 * window.h (struct window): Convert left_margin_cols and
171 right_margin_cols from Lisp_Objects to integers. Adjust comment.
172 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
173 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
174 Adjust users.
175 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
176 Adjust comment.
177 (showing_window_margins_p, update_window_line, update_frame_1):
178 * fringe.c (draw_fringe_bitmap_1):
179 * xdisp.c (window_box_width): Adjust users.
180 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
181 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
182 Use direct assignment.
183 (Fset_window_configuration, save_window_save, Fwindow_margins):
184 Convert Lisp_Object to integer and back where appropriate.
185 (Fset_window_margins): Adjust user. Return t if any margin
186 was actually changed, and mention this in docstring.
187
956720af
XF
1882013-08-13 Xue Fuqiao <xfq.free@gmail.com>
189
f73f4ce6 190 * syntax.c (forward_word):
956720af
XF
191 * cmds.c (forward_char, backward_char): Mention the optional argument.
192
9e37ee3b
DA
1932013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
194
195 * window.h (struct window): Convert left_fringe_width
196 and right_fringe_width from Lisp_Objects to integers.
197 Adjust comment.
198 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
199 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
200 * window.c (wset_left_fringe_width, wset_right_fringe_width):
201 Remove.
202 (make_window): Initialize new integer fields to -1.
203 (Fsplit_window_internal): Use direct assignment.
204 (Fset_window_configuration, save_window_save): Convert
205 Lisp_Object to integer and back where appropriate.
206 (Fset_window_fringes): Adjust user. Return t if any fringe
207 was actually changed, and mention this in docstring.
208
e4375ca7
DA
2092013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
210
211 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
9cda66e4
DA
212 * nsfns.m (x_set_cursor_type):
213 * w32fns.c (x_set_cursor_type):
214 * xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
215 * xdisp.c (set_frame_cursor_types): ...but in common code.
e4375ca7 216
a45543bc
DA
2172013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
218
219 * font.c (clear_font_cache): New function, stripped from...
220 (Fclear_font_cache): ...here, which now uses the function
221 above. Adjust comment.
222 * font.h (clear_font_cache): Add prototype.
223 * xfaces.c (clear_face_cache): Use clear_font_cache.
224
ae966a86
DA
2252013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
226
227 * window.c (Fset_window_start): Compare `w', not `window' because
228 `w' might not be equal to `window' after call to decode_live_window.
229
297a545b
PE
2302013-08-12 Paul Eggert <eggert@cs.ucla.edu>
231
232 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
233 This fixes a problem introduced by the Bug#15035 patch
234 when using GPG. Reported by Herbert J. Skuhra.
235
aa942e2b
EZ
2362013-08-12 Eli Zaretskii <eliz@gnu.org>
237
238 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
239 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
240 not yet initialized.
241
7699d09e
LMI
2422013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
243
244 * decompress.c (Fzlib_decompress_region): Support zlib
245 decompression, too, and rename.
246
1d238bc7
PE
2472013-08-12 Paul Eggert <eggert@cs.ucla.edu>
248
249 Minor zlib configuration tweaks.
250 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
251 Don't assume presence of fn_inflateInit2_ zlib internal function.
252
8a44a184
LMI
2532013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
254
255 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
256 include the zlib prefix.
257
594a4307
EZ
2582013-08-12 Eli Zaretskii <eliz@gnu.org>
259
260 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
261 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
262 define static variables that are pointers to zlib functions to be
263 dynamically loaded.
264 (init_zlib_functions) [WINDOWSNT]: New function.
265 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
266 New macros.
267 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
268 macros instead of invoking the zlib functions directly.
269 (syms_of_decompress): DEFSYM Qzlib_dll. Staticpro
270 Szlib_available_p.
271
d2e113bc
DA
2722013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
273
274 Avoid looping over all frame windows to freeze and unfreeze.
275 * window.h (struct window): Drop frozen_window_start_p.
276 (freeze_window_starts): Drop prototype.
277 * frame.h (struct frame): New frozen_window_starts flag.
278 (FRAME_WINDOWS_FROZEN): New macro.
279 * window.c (freeze_window_start, freeze_window_starts):
280 Remove.
281 (select_window, replace_window): Adjust users.
282 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
283 (window_frozen_p): New function.
284 (redisplay_window): Use it.
285
94fcd171
PE
2862013-08-12 Paul Eggert <eggert@cs.ucla.edu>
287
288 Fix some fd issues when running subprocesses (Bug#15035).
289 Fix bugs that can leak files or file descriptors on errors.
290 Don't unlink open temp files, as that's hard for users to diagnose
291 when things go awry (e.g., temp disk exhausted).
292 Don't bother to lock temp files. Check for invalid recursion.
293 * callproc.c (synch_process_fd): Remove. All uses removed.
294 (synch_process_tempfile): New var or macro.
295 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
296 New constants.
297 (record_kill_process): New arg, the temp name. All callers changed.
298 (delete_temp_file): Now just a simple wrapper around unlink.
299 (call_process_kill): New arg, the call_process_fd array.
300 Close them all. Clear synch_process_pid. Remove the temp file,
301 or arrange for it to be removed.
302 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
303 that's been moved to synch_process_tempfile. Caller changed.
304 Do not remove the tempfile; that's now call_process_kill's
305 responsibility.
306 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
307 call_process_kill; the caller now does that.
308 (call_process_cleanup): Do not close the process fd; that's now
309 call_process_kill's responsibility.
310 (Fcall_process): Implement via new function call_process, which
311 has most of the old body of Fcall_process, but with a different API.
312 (call_process): New function that does not open or close filefd if
313 it is nonnegative. Record which fds need to be closed, and let
314 call_process_kill close (and remove the tempfile, on MSDOS) on error.
315 Signal an error if invoked recursively (could be done via a hook).
316 Simplify creation of the tempfile in the MSDOS case.
317 Don't create the output file until after checking for the executable.
318 Report any failure to open /dev/null.
319 Don't open /dev/null for writing twice; once is enough.
320 Don't create pipe if all output is being discarded or sent to file.
321 Don't worry about setting up the coding system or reading from the
322 pipe if all output is being discarded.
323 Hoist fd_error local into top level, to lessen block nesting.
324 Don't record deleted pid here; now done by Fcall_process_region.
325 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
326 and note its success in synch_process_tempfile.
327 Do not leak resources when child_setup fails.
328 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
329 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
330 (create_temp_file): Now returns open fd, with an additional
331 Lisp_Object * argument to return the name. All callers changed.
332 Do not close the file; rewind it instead, and leave it open for
333 the caller. Do not lock the temp file. Unwind-protect the file
334 and the file-descriptor.
335 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
336 If an asynchrounous process, record it here, not in call_process.
337 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
338 * eval.c (set_unwind_protect): New function.
339 * fileio.c (write_region): New function, generalized from the
340 old Fwrite_region. Do not lock temp files.
341 (Fwrite_region): Use it.
342 * lisp.h (set_unwind_protect, write_region): New decls.
343 * process.c: Include <verify.h>.
344 (make_process): Mark fds as initially closed.
345 (deleted_pid_list): Now a list of pid-filename pairs.
346 All uses changed.
347 (close_process_fd): New function.
348 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
349 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
350 New constants. Verify that their number matches PROCESS_OPEN_FDS.
351 (create_process, create_pty, Fmake_serial_process)
352 (server_accept_connection): Record which fds need to be closed,
353 and let deactivate_process close them.
354 (Fmake_network_process): Do not discard the unwind-protect
355 until it's safe to do so.
356 (deactivate_process): Close the fds opened by create_process etc.
357 (Fprocess_send_eof): Adjust to new way of recording open fds.
358 Report an error if /dev/null can't be opened, instead of aborting.
359 * process.h (PROCESS_OPEN_FDS): New constant.
360 (struct Lisp_Process): New member open_fds.
361 (record_kill_process, record_deleted_pid): Adjust signatures.
362 (record_deleted_pid): Move decl here ...
363 * syswait.h (record_deleted_pid): ... from here.
364
d0e615c3
PE
3652013-08-11 Paul Eggert <eggert@cs.ucla.edu>
366
367 * decompress.c: Fix bugs with large buffers and weird inputs.
368 Tune a bit. Reindent as per usual Emacs style.
369 (BUFFER_SIZE): Remove.
370 (Fdecompress_gzipped_region): Do not mishandle input buffers with
371 more than UINT_MAX bytes. Decompress into the gap instead of into
372 an auto buffer, as this should avoid copying. Return nil if
373 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
374 set immediate_quit; we shouldn't trust zlib code that much.
375
313546eb
LMI
3762013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
377
99a32242
LMI
378 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
379 errors, and really move the gap to where we want it.
380
313546eb
LMI
381 * lisp.h: Include decompress.c support.
382
383 * emacs.c (main): Include decompress.c support.
384
385 * Makefile.in: Include -lz if present.
386
d2d699ac
JD
3872013-08-11 Jan Djärv <jan.h.d@swipnet.se>
388
f90e3ebd
JD
389 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
390 (initWithTitle:): Initialize frame to 0.
391 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
392 (fillWithWidgetValue:frame:): Renamed from
393 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
394
395 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
396 fillWithWidgetValue:frame:
397
423d3b3f
JD
398 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
399 remove memory leak warnings.
400
d2d699ac
JD
401 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
402 (ns_check_menu_open): Handle menu == nil. Remove assignment to
403 menu_pending_title.
404
405 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
406 (x_activate_menubar): Update the whole menu.
407 (trackingNotification:): Call ns_check_menu_open if tracking ends.
408 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
409 current event is not NSSystemDefined (Bug#15001).
410 Call ns_check_menu_open only if trackingMenu is 2.
411 (menuDidClose:): New method, decrease trackingMenu.
412 (fillWithWidgetValue:setDelegate:): New method.
413 (fillWithWidgetValue:): Call the above.
414
415 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
416
7d652d97
PE
4172013-08-11 Paul Eggert <eggert@cs.ucla.edu>
418
419 Omit some unnecessary casts.
420 Many of these go back to the old pre-C89 days, when they may have
421 been needed, but we've been assuming C89 or later for a while now.
422 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
423 (live_float_p, live_misc_p, live_vector_p):
424 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
425 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
426 (defvar_per_buffer):
427 * callint.c (Fcall_interactively):
428 * doc.c (Fsubstitute_command_keys):
429 * filelock.c (get_boot_time):
430 * frame.c (xrdb_get_resource):
431 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
432 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
433 (xg_get_file_name_from_selector, menuitem_destroy_callback)
434 (menuitem_highlight_callback, menu_destroy_callback)
435 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
436 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
437 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
438 (xg_tool_bar_help_callback, tb_size_cb):
439 * image.c (xpm_alloc_color, png_read_from_memory)
440 (png_read_from_file, png_load_body, our_memory_skip_input_data)
441 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
442 (syms_of_image):
443 * keymap.c (describe_map):
444 * nsfns.m (Fns_display_monitor_attributes_list):
445 * nsmenu.m (process_dialog:):
446 * nsterm.m (hold_event):
447 * process.c (wait_reading_process_output):
448 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
449 * scroll.c (do_direct_scrolling, scrolling_1):
450 * termcap.c (tgetent):
451 * window.c (check_window_containing, add_window_to_list)
452 (freeze_window_starts):
453 * xdisp.c (compare_overlay_entries, vmessage):
454 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
455 (x_get_monitor_attributes_xrandr)
456 (Fx_display_monitor_attributes_list, x_display_info_for_name)
457 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
458 * xfont.c (xfont_match, xfont_open):
459 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
460 (menubar_selection_callback, menu_position_func)
461 (popup_selection_callback, create_and_show_popup_menu)
462 (dialog_selection_callback, create_and_show_dialog):
463 * xrdb.c (x_get_string_resource):
464 (main) [TESTRM]:
465 * xsmfns.c (x_session_check_input):
466 * xterm.c (x_draw_glyphless_glyph_string_foreground)
467 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
468 (xaw_jump_callback, xaw_scroll_callback):
469 Omit unnecessary casts.
470
9acc1074
PE
4712013-08-10 Paul Eggert <eggert@cs.ucla.edu>
472
473 Minor string-length refactoring.
474 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
475 * frame.c (make_monitor_attribute_list):
476 Prefer build_string to strlen + make_string.
477
361c0eb8
JD
4782013-08-10 Jan Djärv <jan.h.d@swipnet.se>
479
480 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
481 don't check minor_code (Bug#14417).
482
14ba0822
EZ
4832013-08-09 Eli Zaretskii <eliz@gnu.org>
484
485 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
486 vertical positions instead. This avoids calling MATRIX_ROW with
487 row numbers that are possibly beyond valid limits. (Bug#15064)
488
309f24d1
DA
4892013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
490
491 Use xstrdup and build_unibyte_string where applicable.
492 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
493 * xfns.c (x_window):
494 * xrdb.c (x_get_customization_string):
495 * xterm.c (xim_initialize):
496 * w32fns.c (w32_window): Use xstrdup.
497 (w32_display_monitor_attributes_list):
498 * emacs.c (init_cmdargs):
499 * keyboard.c (PUSH_C_STR):
500 * nsfont.m (nsfont_open):
501 * sysdep.c (system_process_attributes):
502 * w32.c (system_process_attributes):
503 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
504
55902276
EZ
5052013-08-09 Eli Zaretskii <eliz@gnu.org>
506
507 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
508 variables of these types so that GDB would know about them, as aid
509 for debugging fatal exceptions. (Bug#15024) See also
510 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
511 discussions.
512
10bf7f5a
JD
5132013-08-08 Jan Djärv <jan.h.d@swipnet.se>
514
515 * nsterm.m (ns_update_begin): Don't change clip path if it would be
516 larger than the NSWindow (Bug#14934).
517
65620264
DA
5182013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
519
520 Redesign redisplay interface to drop global variable updated_window.
521 Always pass currently updated window as a parameter to update routines.
522 * dispextern.h (updated_window): Remove declaration.
523 (struct redisplay_interface): Pass window parameter to
524 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
525 and after_update_window_hook.
526 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
527 Adjust prototypes.
528 * dispnew.c (updated_window): Remove.
529 (redraw_overlapped_rows, update_marginal_area, update_text_area)
530 (update_window_line): Adjust to match redisplay interface changes.
531 * nsterm.m (ns_update_window_begin, ns_update_window_end)
532 (ns_scroll_run, ns_after_update_window_line):
533 * w32term.c (x_update_window_begin, x_update_window_end)
534 (x_after_update_window_line, x_scroll_run):
535 * xterm.c (x_update_window_begin, x_update_window_end)
536 (x_after_update_window_line, x_scroll_run):
537 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
538 Likewise. Adjust comments where appropriate.
539 (x_cursor_to): Simplify because this is always called during window
540 update (but install debugging check anyway).
541 (expose_window): Check must_be_updated_p flag to see whether this
542 function is called during window update.
543
628fdc56
DA
5442013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
545
546 Do not reset window modification event counters excessively.
547 These leftovers and poor man's tricky methods to catch extra
548 redisplay's attention are no longer needed.
549 * frame.c (set_menu_bar_lines_1):
550 * minibuf.c (read_minibuf_unwind):
551 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
552 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
553 (window_scroll_line_based, Fset_window_configuration):
554 * xdisp.c (redisplay_window): Do not reset last_modified and
555 last_overlay_modified counters.
556
8fd9c92e
JD
5572013-08-07 Jan Djärv <jan.h.d@swipnet.se>
558
559 * xselect.c (x_send_client_event): Set send_event and serial, memset
560 data.l as it might be bigger than data.b. Use 24 bit mask to
561 XSendEvent (Bug#15034).
562
0ee18172
EZ
5632013-08-07 Eli Zaretskii <eliz@gnu.org>
564
565 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
566 for TTY frames that are not the top frame on their console.
567 (Bug#14616)
568
16ddd1a6
MR
5692013-08-07 Martin Rudalics <rudalics@gmx.at>
570
571 * w32term.c (w32fullscreen_hook): Really maximize frame when
572 asked for (Bug#14841).
573
d2a95ffb
DA
5742013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
575
576 Prefer selected_window to Fselected_window, likewise for frames.
577 * buffer.c (Fbuffer_swap_text):
578 * data.c (Fvariable_binding_locus):
579 * window.c (run_window_configuration_change_hook): Adjust users.
580 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
581 Use decode_live_frame.
582
170da1ec
DA
5832013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
584
585 Be more careful if selected window shows the buffer other than current,
586 use window_outdated only if this is not so. This change should also
587 address some weird issues discussed in Bug#13012.
588 * window.h (window_outdated): New prototype.
589 * window.c (window_outdated): Now here. Convert from static and
590 always assume window's buffer.
591 (Fwindow_end, Fwindow_line_height): Use it.
592 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
593 and always assume window's buffer.
594 (redisplay_window): Adjust user.
e5eefe9b 595 (redisplay_internal): Call to reconsider_clip_changes once and
170da1ec
DA
596 check whether mode line should be updated only if selected window
597 shows current buffer.
598 (run_window_scroll_functions): Use eassert for debugging check.
599 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
600
56b5d5b1
DA
6012013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
602
603 * window.c (window_scroll, window_scroll_pixel_based)
604 (window_scroll_line_based): Use bool for booleans.
605
2878ba7e
PE
6062013-08-06 Paul Eggert <eggert@cs.ucla.edu>
607
608 * process.c: Fix minor off-by-one issues in descriptor counts.
609 This shouldn't fix any real bugs, but it cleans up the code a bit.
610 (max_process_desc, max_input_desc): -1, not 0, means none.
611 All uses changed.
612 (delete_input_desc): New function.
613 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
614 (deactivate_process): Scan backwards when recomuting max_process_desc;
615 that should be faster.
616 (init_process_emacs): Initialize max_input_desc.
617
e30b79c1
DA
6182013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
619
620 Use region cache to speedup bidi_find_paragraph_start.
621 * buffer.h (struct buffer): New member bidi_paragraph_cache.
622 Rename cache_long_line_scans to cache_long_scans.
623 * buffer.c (bset_cache_long_line_scans): Rename to
624 bset_cache_long_scans.
625 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
626 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
627 into account.
628 (syms_of_buffer): Rename cache-long-line-scans to
629 cache-long-scans. Adjust docstring.
630 * search.c (newline_cache_on_off):
631 * indent.c (width_run_cache_on_off): Adjust users.
632 * bidi.c (bidi_paragraph_cache_on_off): New function.
633 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
634 * insdel.c (prepare_to_modify_buffer): Invalidate
635 bidi_paragraph_cache if enabled.
636
00012b86
DA
6372013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
638
639 Invalidate region caches only if buffer text is going to be changed.
640 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
641 (modify_text): ...new prototype.
642 (prepare_to_modify_buffer_1): New prototype.
643 * textprop.c (modify_region): Rename to...
644 (modify_text_properties): ...new function.
645 (add_text_properties_1, set_text_properties, Fremove_text_properties)
646 (Fremove_list_of_text_properties): Adjust users.
647 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
648 (modify_text): ...new function.
649 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
650 (prepare_to_modify_buffer_1): ...new function.
651 * casefiddle.c (casify_region):
652 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
653 (Ftranspose_regions): Use modify_text.
654
dc6c0eda
SM
6552013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
656
657 * lisp.mk (lisp): Add nadvice.elc.
658
8f3a2c26
DA
6592013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
660
661 New macro to iterate over live buffers similar to frames.
662 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
663 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
664 Declare buffer-related variables here to offload lisp.h.
665 * buffer.c (Vbuffer_alist): Adjust comment.
666 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
667 (other_buffer_safely):
668 * data.c (store_symval_forwarding):
669 * dispnew.c (Fframe_or_buffer_changed_p):
670 * fileio.c (Fdo_auto_save):
671 * filelock.c (unlock_all_files):
672 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
673
e0fdb694
PE
6742013-08-04 Paul Eggert <eggert@cs.ucla.edu>
675
676 Fix some minor races in hosts lacking mkostemp (Bug#15015).
677 * callproc.c (create_temp_file):
678 * filelock.c (create_lock_file):
679 Assume mkostemp, since it's now provided by Gnulib.
680
63f5c6c2
EZ
6812013-08-04 Eli Zaretskii <eliz@gnu.org>
682
683 * w32.c (mkostemp): New function.
684 (mktemp): Remove, no longer used. Most of the code reused in
685 mkostemp. (Bug#15015)
484ab239 686 (mktemp): Don't undef.
63f5c6c2 687
f0b79313
DA
6882013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
689
690 * dispnew.c (glyph_matrix_count, glyph_pool_count):
691 Move under GLYPH_DEBUG and ENABLE_CHECKING.
692 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
693 (free_glyph_pool, check_glyph_memory): Likewise for
694 all users. Adjust comments where appropriate.
695
98f638d6
PE
6962013-08-03 Paul Eggert <eggert@cs.ucla.edu>
697
698 * composite.h: Minor fixups.
699 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
700 to fix a misspelling, and change it to an inline function while
701 we're at it (it need not be a macro). All uses changed.
702 (composition_method, composition_valid_p):
703 Rewrite to avoid assignments in if-conditions.
704
75c59fb3
DA
7052013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
706
707 Do not use global Lisp_Object in composition macros.
708 * composite.h (composition_temp): Remove declaration.
709 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
710 (composition_method, composition_valid_p): ...inline functions.
416a3e01 711 (compose_region): Remove the leftover.
75c59fb3
DA
712 * composite.c (composition_temp): Remove.
713 (run_composition_function, update_compositions)
714 (composition_compute_stop_pos, composition_adjust_point)
715 (Ffind_composition_internal):
716 * coding.c (handle_composition_annotation):
717 * xdisp.c (handle_composition_prop, check_point_in_composition):
718 Related users changed.
719
a10c8269
DA
7202013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
721
722 Drop FRAME_PTR typedef.
723 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
724 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
725 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
726 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
727 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
728 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
729 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
730 All related users changed.
731
a104f656
SM
7322013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
733
734 * eval.c (default_toplevel_binding): New function.
735 (Fdefvar): Use it.
736 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
737 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
738 (syms_of_eval): Export them.
739 * data.c (Fdefault_value): Micro cleanup.
740 * term.c (init_tty): Use "false".
741
4b5c9326
DA
7422013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
743
744 Fix X GC leak in GTK and raw (no toolkit) X ports.
745 * xterm.c (x_free_frame_resources): If white and black relief
746 GCs are allocated, always free them here.
747 * xfns.c (x_make_gc): Omit redundant initialization.
748 * widget.c (create_frame_gcs): Remove the leftover.
749 (EmacsFrameDestroy): Do nothing because all GCs are now freed
750 in x_free_frame_resources.
751
b19aa636
JD
7522013-08-02 Jan Djärv <jan.h.d@swipnet.se>
753
754 * nsterm.m (windowWillResize:toSize:): Only change title if
755 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
756 modifying it.
757 (viewDidEndLiveResize): New method.
758
759 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
760 inside NS_IMPL_COCOA.
761
af1f7e06
DA
7622013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
763
764 * insdel.c (adjust_after_replace, replace_range, del_range_2):
765 Do not check whether undo is enabled because record_insert and
766 record_delete does that themselves.
767
65b02bb9
DA
7682013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
769
770 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
771 member which is not really used any more.
772 (FRAME_XIC_BASE_FONTNAME): Remove.
773 * xfns.c (xic_free_fontset): Adjust user.
774 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
775 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
776 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
777 (xdialog_show): Use eassert for debugging check.
7ee0f047 778 * w32term.c (x_unfocus_frame): Remove unused dummy function.
65b02bb9 779
6318cde0
PE
7802013-08-01 Paul Eggert <eggert@cs.ucla.edu>
781
782 * fileio.c, fns.c (merge): Move extern decl from here ...
783 * lisp.h (merge): ... to here.
784
6c1a09ba
DA
7852013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
786
787 Fix last font-related change.
788 * w32font.h (w32font_list_internal, w32font_match_internal):
789 Fix prototype.
790 * w32uniscribe.c (uniscribe_list, uniscribe_match):
791 (uniscribe_list_family): Adjust to match font API change.
792 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
793 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
794
f8c20208
DA
7952013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
796
797 * frame.h (FRAME_MOUSE_UPDATE):
798 * nsterm.m (ns_frame_up_to_date): Omit redundant check
799 whether hlinfo->mouse_face_mouse_frame is non-NULL.
800
fdb396e2
DA
8012013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
802
803 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
804 * font.h (struct font_driver): Change list, match, and list_family
805 functions to accept struct frame * as first arg.
806 * font.c (font_score, font_compare, font_sort_entities): Remove
807 prototypes.
808 (font_sort_entities, font_list_entities, font_select_entity):
809 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
810 match font API change.
811 * xfont.c (xfont_list, xfont_match, xfont_list_family):
812 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
813 * ftxfont.c (ftxfont_list, ftxfont_match):
814 * xftfont.c (xftfont_list, xftfont_match):
815 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
816 * w32font.c (w32font_list, w32font_match, w32font_list):
817 (w32font_list_internal, w32_font_match_internal): Likewise.
818 * xfaces.c (Fx_family_fonts): Adjust user.
819
52b8a085
DA
8202013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
821
822 Do not use pure Xism x_wm_set_icon_position in non-X ports.
823 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
824 only if HAVE_X_WINDOWS is in use.
825 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
826 * nsterm.m (x_wm_set_icon_position): Remove no-op.
827 * w32term.c (x_wm_set_icon_position): Likewise.
828 * w32fns.c (x_icon): Adjust user.
829
c791c18e
DA
8302013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
831
832 * xterm.c (last_mouse_press_frame): Remove the
833 leftover which is not really used any more.
834 (handle_one_xevent, syms_of_xterm): Adjust users.
1ca6cc28
DA
835 (x_flush): Call XFlush once per each X display, not frame.
836 This is better because this code always unconditionally skips
837 non-X frames in Vframe_list and issues the only XFlush if we
838 have more than one X frame on the same X display.
2f935d86
DA
839 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
840 Use bool for booleans.
841 (x_draw_glyph_string_background, cvt_string_to_pixel):
842 (cvt_pixel_dtor): Drop unnecessary prototypes.
843 * xterm.h (x_display_ok): Adjust prototype.
c791c18e 844
f435830e
DA
8452013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
846
847 Drop unnecessary functions that deals with frame pixel size.
848 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
849 (x_pixel_height): Drop prototypes.
850 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
851 (x_pixel_height): Drop implementations.
852 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
853 which should be always valid for window frame.
854 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
855 * w32menu.c (Fx_popup_dialog):
856 * xmenu.c (Fx_popup_dialog): Likewise for both.
857
84231434
DA
8582013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
859
860 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
861 frame parameters and call to Fmodify_frame_parameters just once.
4c131798
DA
862 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
863 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
864 and mention nil frame in docstring.
84231434 865
959067a1
DA
8662013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
867
868 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
869 (x_figure_window_size): Likewise. Adjust to return long.
870 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
871 (toplevel): Move Qterminal_live_p to...
872 * terminal.c (toplevel): ...here, make it static, and...
873 (syms_of_terminal): ...DEFSYM here.
874 * frame.h (Qterminal_live_p): Remove declaration.
875 (make_frame, x_figure_window_size): Adjust prototype.
876 * nsfns.m (Fx_create_frame): Use long for window flags.
877
f4b169ce
PE
8782013-07-30 Paul Eggert <eggert@cs.ucla.edu>
879
880 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
881 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
882 Do not assume that emacs_close (INT_MAX) is a no-op.
883
bee6a2c7
DA
8842013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
885
886 * xfaces.c (make_face_cache): For struct face_cache, prefer
887 xmalloc to xzalloc and so avoid redundant call to memset.
888 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
889
d7e6881a
DA
8902013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
891
892 * fringe.c (draw_window_fringes, update_window_fringes)
893 (compute_fringe_widths):
894 * w32term.c (x_draw_glyph_string):
895 * window.c (candidate_window_p, Frecenter):
896 * xfaces.c (realize_basic_faces, realize_default_face)
897 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
898 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
899 * xfns.c (x_set_cursor_color, xic_free_xfontset):
900 * xmenu.c (Fx_menu_bar_open_internal):
901 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
902 * xsettings.c (xft_settings_event):
903 * xterm.c (x_draw_glyph_string, x_had_errors_p):
904 Use bool for booleans. Adjust style and comments where
905 appropriate.
906 * dispextern.h (draw_window_fringes, update_window_fringes)
907 (compute_fringe_widths):
908 * xterm.h (x_had_errors_p): Adjust prototype.
909
ec3058af
DA
9102013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
911
912 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
913 CHECK_LIST. Rewrite the loop to avoid useless local variable.
914
218e0637
DA
9152013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
916
917 * fns.c (toplevel): Remove comment before Fsafe_length because
918 it checks for QUIT.
919
e560aba9
PE
9202013-07-28 Paul Eggert <eggert@cs.ucla.edu>
921
922 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
923
2e5ce5de
EZ
9242013-07-28 Eli Zaretskii <eliz@gnu.org>
925
926 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
927 frame which got the message is still alive, before dereferencing
928 its pointer. (Bug#14970)
929
930 * frame.c (delete_frame): Test "this" frame's minibuffer window to
931 be a live window, before using it as such. (Bug#14970)
932
e95da6d3
EZ
9332013-07-27 Eli Zaretskii <eliz@gnu.org>
934
935 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
936 w32_detect_focus_change instead of doing part of its job by hand.
937 This fixes the problem whereby FOCUS_OUT events were not sent to
938 the event queue.
939
a8f93651
EZ
9402013-07-26 Eli Zaretskii <eliz@gnu.org>
941
fec92060
EZ
942 * process.c (Fprocess_list): Doc fix.
943
a8f93651
EZ
944 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
945 being re-exposed only if it didn't ask to become visible.
946 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
947 was previously iconified. (Bug#14841)
948 (x_iconify_frame): Mark the frame iconified.
949
d5a7a9d9
PE
9502013-07-26 Paul Eggert <eggert@cs.ucla.edu>
951
952 Fix minor problems found by static checking.
953 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
954 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
955
56ea7291
SM
9562013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
957
958 * eval.c (set_specpdl_old_value): New function.
959 (unbind_to): Minor simplification.
960 (get_backtrace_frame): New function.
961 (Fbacktrace_frame): Use it. Add `base' argument.
962 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
963 (syms_of_eval): Export backtrace-eval.
964 * xterm.c (x_focus_changed): Simplify.
965
9d611ffe
PE
9662013-07-25 Paul Eggert <eggert@cs.ucla.edu>
967
968 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
969
999c74e3
EZ
9702013-07-24 Eli Zaretskii <eliz@gnu.org>
971
972 * xdisp.c (redisplay_window): Instead of moving point out of
973 scroll margin, reject the force_start method, and try scrolling
974 instead. (Bug#14780)
975
198fa217
KB
9762013-07-24 Ken Brown <kbrown@cornell.edu>
977
978 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
979 (Bug#14944).
980
53840e55
PE
9812013-07-24 Paul Eggert <eggert@cs.ucla.edu>
982
983 * eval.c (Fprogn): Do not check that BODY is a proper list.
984 This undoes the previous change. The check slows down the
985 interpreter, and is not needed to prevent a crash. See
986 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
987
60967f56
GM
9882013-07-23 Glenn Morris <rgm@gnu.org>
989
990 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
991
9ca960e2
PE
9922013-07-23 Paul Eggert <eggert@cs.ucla.edu>
993
a29c3e6d
PE
994 Port to GNU/Linux systems with tinfo but not ncurses.
995 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
996 to decide whether ncurses is being used. Without this change,
997 GCC complains about tgetent not being declared, on a system
998 that has tinfo installed but ncurses not installed.
999
f274311c
PE
1000 * eval.c (Fprogn): Check that BODY is a proper list.
1001
16b0520a
PE
1002 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
1003 * data.c (Fsetq_default):
1004 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
1005 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
1006 (Fcondition_case):
1007 Tune by taking advantage of the fact that ARGS is always a list
1008 when a function is declared to have UNEVALLED args.
1009
9ca960e2
PE
1010 * emacsgtkfixed.c: Port to GCC 4.6.
1011 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
1012
afacaa1b
JB
10132013-07-23 Juanma Barranquero <lekktu@gmail.com>
1014
1015 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
1016 here to silence compiler warnings.
1017
368a85a4
PE
10182013-07-22 Paul Eggert <eggert@cs.ucla.edu>
1019
1020 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
1021 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
1022 from messing up Emacs's 'struct frame' (Bug#14923).
1023
f4e891b5
PE
10242013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1025
1026 * alloc.c (make_save_ptr_ptr): Define this function.
1027 It was inadvertently omitted. It's needed only if
1028 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
1029
96c8b65e
JD
10302013-07-21 Jan Djärv <jan.h.d@swipnet.se>
1031
1032 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
1033 frame have focus (Bug#14895).
1034
ee010797
PE
10352013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1036
1037 Avoid vfork-related deadlock more cleanly.
1038 * callproc.c (child_setup): When the child's exec fails, output
1039 the program name, as that's more useful. Use O_NONBLOCK to avoid
1040 deadlock.
1041 * process.c (create_process_1): Remove; no longer needed.
1042 (create_process): Remove timer hack; no longer needed, now that
1043 the child avoids deadlock.
1044
f0398ec1 10452013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
1046
1047 * image.c (Fimage_flush): Fix doc typo.
1048
b2a069c2
PE
10492013-07-20 Paul Eggert <eggert@cs.ucla.edu>
1050
6496aec9
PE
1051 Fix array bounds violation when pty allocation fails.
1052 * process.c (PTY_NAME_SIZE): New constant.
1053 (pty_name): Remove static variable; it's now auto.
1054 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
1055 Take pty_name as an arg rather than using a static variable.
1056 All callers changed.
1057 (create_process): Recover pty_flag from process, not from volatile local.
1058 (create_pty): Stay inside array even when pty allocation fails.
1059 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
1060
b2a069c2
PE
1061 * lread.c (Fload): Avoid initialization only when lint checking.
1062 Mention that it's needed only for older GCCs.
1063
99107004
KH
10642013-07-20 Kenichi Handa <handa@gnu.org>
1065
1066 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
1067 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
1068
6b1b199d
AS
10692013-07-20 Andreas Schwab <schwab@linux-m68k.org>
1070
1071 * lread.c (Fload): Avoid uninitialized warning.
1072
4195afc3
PE
10732013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1074
3f5bef16
PE
1075 Fix some minor file descriptor leaks and related glitches.
1076 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
1077 (create_lock_file): Use write, not emacs_write.
1078 * image.c (slurp_file, png_load_body):
1079 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
1080 (server_accept_connection):
1081 Don't leak an fd on memory allocation failure.
1082 * image.c (slurp_file): Add a cheap heuristic for growing files.
1083 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
1084 as that's what the other routines do. Maybe input need not be
1085 blocked at all, but it's better to be consistent.
1086 Avoid undefined behavior when strlen is zero.
1087
4195afc3
PE
1088 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
1089 (NSTATICS): Now a constant; doesn't need to be a macro.
1090
a1aeeffe
RS
10912013-07-19 Richard Stallman <rms@gnu.org>
1092
1093 * coding.c (decode_coding_utf_8): Add simple loop for fast
1094 processing of ASCII characters.
1095
63b34baa
PE
10962013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1097
1098 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
1099
621dd9ac
EZ
11002013-07-19 Eli Zaretskii <eliz@gnu.org>
1101
1102 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
1103 unportable 'struct x_display_info'.
1104 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
1105 is a portable type.
1106
1396ac86
PE
11072013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1108
ab9980cd
PE
1109 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
1110 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
1111 or fscanf fails.
1112 (system_process_attributes): Prefer plain char to unsigned char
1113 when either will do. Clean up properly if interrupted or if
1114 memory allocations fail. Don't assume sscanf succeeds. Remove
1115 no-longer-needed workaround to stop GCC from whining. Read
1116 command-line once, instead of multiple times. Check read status a
1117 bit more carefully.
1118
1396ac86
PE
1119 Fix obscure porting bug with varargs functions.
1120 The code assumed that int is treated like ptrdiff_t in a vararg
1121 function, which is not a portable assumption. There was a similar
1122 -- though these days less likely -- porting problem with various
1123 assumptions that pointers of different types all smell the same as
1124 far as vararg functions is conserved. To make this problem less
1125 likely in the future, redo the API to use varargs functions.
1126 * alloc.c (make_save_value): Remove this vararg function.
1127 All uses changed to ...
1128 (make_save_int_int_int, make_save_obj_obj_obj_obj)
1129 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
1130 New functions.
1131 (make_save_ptr): Rename from make_save_pointer, for consistency with
1132 the above. Define only on platforms that need it. All uses changed.
1133
4d19d194
PE
11342013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1135
1136 * keyboard.c: Try to fix typos in previous change.
1137 (DISPLAY_LIST_INFO): New macro.
1138 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 1139 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 1140
945c5bb1
JB
11412013-07-18 Juanma Barranquero <lekktu@gmail.com>
1142
1143 * keyboard.c (kbd_buffer_get_event):
1144 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
1145 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
1146
f4b1eb36
PE
11472013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1148
5e679a2c
PE
1149 * filelock.c: Fix unlikely file descriptor leaks.
1150 (get_boot_time_1): Rework to avoid using emacs_open.
1151 This doesn't actually fix a leak, but is better anyway.
1152 (read_lock_data): Use read, not emacs_read.
1153
a8cd4836
PE
1154 * doc.c: Fix minor memory and file descriptor leaks.
1155 * doc.c (get_doc_string): Fix memory leak when doc file absent.
1156 (get_doc_string, Fsnarf_documentation):
1157 Fix file descriptor leak on error.
1158
ef30e638
PE
1159 * term.c: Fix minor fdopen-related file descriptor leaks.
1160 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
1161 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
1162
f4b1eb36
PE
1163 * charset.c: Fix file descriptor leaks and errno issues.
1164 Include <errno.h>.
1165 (load_charset_map_from_file): Don't leak file descriptor on error.
1166 Use plain record_xmalloc since the allocation is larger than
1167 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
1168 of entries.
1169 * eval.c (record_unwind_protect_nothing):
1170 * fileio.c (fclose_unwind):
1171 New functions.
1172 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
1173 The replacement doesn't block input, but that no longer seems
1174 necessary.
1175
b648c163
PE
11762013-07-17 Paul Eggert <eggert@cs.ucla.edu>
1177
a0931322
PE
1178 * lread.c: Fix file descriptor leaks and errno issues.
1179 (Fload): Close some races that leaked fds or streams when 'load'
1180 was interrupted.
1181 (Fload, openp): Report error number of last nontrivial failure to open.
1182 ENOENT counts as trivial.
1183 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
1184 New functions.
1185 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
1186 now that the function is always called with a nonnegative arg.
1187 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
1188 All uses replaced with ...
1189 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
1190
b648c163
PE
1191 A few more minor file errno-reporting bugs.
1192 * callproc.c (Fcall_process):
1193 * doc.c (Fsnarf_documentation):
1194 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
1195 * process.c (set_socket_option):
1196 Don't let a constructor trash errno.
1197 * doc.c: Include <errno.h>.
1198
b1dc4084
JB
11992013-07-16 Juanma Barranquero <lekktu@gmail.com>
1200
1201 * w32fns.c (unwind_create_tip_frame): Fix declaration.
1202
c43843aa
PE
12032013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1204
50a30cce
PE
1205 Fix w32 bug with call-process-region (Bug#14885).
1206 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
1207 to Fcall_process when the input is empty. This simplifies the
1208 code a bit. It makes no difference on POSIXish platforms but
1209 apparently it fixes a bug on w32.
1210
44e18199 1211 Fix bug where insert-file-contents closes a file twice (Bug#14839).
41d48a42
PE
1212 * fileio.c (close_file_unwind): Don't close if FD is negative;
1213 this can happen when unwinding a zapped file descriptor.
1214 (Finsert_file_contents): Unwind-protect the fd before the point marker,
1215 in case Emacs runs out of memory between the two unwind-protects.
1216 Don't trash errno when closing FD.
1217 Zap the FD in the specpdl when closing it, instead of deferring
1218 the removal of the unwind-protect; this fixes a bug where a child
1219 function unwinds the stack past us.
1220
27e498e6
PE
1221 New unwind-protect flavors to better type-check C callbacks.
1222 This also lessens the need to write wrappers for callbacks,
1223 and the need for make_save_pointer.
1224 * alloca.c (free_save_value):
1225 * atimer.c (run_all_atimers):
1226 Now extern.
1227 * alloc.c (safe_alloca_unwind):
1228 * atimer.c (unwind_stop_other_atimers):
1229 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
1230 * menu.c (cleanup_popup_menu) [HAVE_NS]:
1231 * minibuf.c (choose_minibuf_frame_1):
1232 * process.c (make_serial_process_unwind):
1233 * xdisp.h (pop_message_unwind):
1234 * xselect.c (queue_selection_requests_unwind):
1235 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
1236 * alloca.c (record_xmalloc):
1237 Prefer record_unwind_protect_ptr to record_unwind_protect with
1238 make_save_pointer.
1239 * alloca.c (Fgarbage_collect):
1240 Prefer record_unwind_protect_void to passing a dummy.
1241 * buffer.c (restore_buffer):
1242 * window.c (restore_window_configuration):
1243 * xfns.c, w32fns.c (do_unwind_create_frame)
1244 New wrapper. All record-unwind uses of wrappee changed.
1245 * buffer.c (set_buffer_if_live):
1246 * callproc.c (call_process_cleanup, delete_temp_file):
1247 * coding.c (code_conversion_restore):
1248 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
1249 * editfns.c (save_excursion_restore)
1250 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
1251 (save_restriction_restore):
1252 * eval.c (restore_stack_limits, un_autoload):
1253 * fns.c (require_unwind):
1254 * keyboard.c (recursive_edit_unwind, tracking_off):
1255 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
1256 * macros.c (pop_kbd_macro, restore_menu_items):
1257 * nsfns.m (unwind_create_frame):
1258 * print.c (print_unwind):
1259 * process.c (start_process_unwind):
1260 * search.c (unwind_set_match_data):
1261 * window.c (select_window_norecord, select_frame_norecord):
1262 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
1263 (fast_set_selected_frame):
1264 * xfns.c, w32fns.c (unwind_create_tip_frame):
1265 Return void, not a dummy Lisp_Object. All uses changed.
1266 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
1267 * callproc.c (call_process_kill):
1268 * fileio.c (restore_point_unwind, decide_coding_unwind)
1269 (build_annotations_unwind):
1270 * insdel.c (Fcombine_after_change_execute_1):
1271 * keyboard.c (read_char_help_form_unwind):
1272 * menu.c (unuse_menu_items):
1273 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
1274 * sound.c (sound_cleanup):
1275 * xdisp.c (unwind_redisplay):
1276 * xfns.c (clean_up_dialog):
1277 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
1278 Accept no args and return void, instead of accepting and returning
1279 a dummy Lisp_Object. All uses changed.
1280 * cygw32.c (fchdir_unwind):
1281 * fileio.c (close_file_unwind):
1282 * keyboard.c (restore_kboard_configuration):
1283 * lread.c (readevalllop_1):
1284 * process.c (wait_reading_process_output_unwind):
1285 Accept int and return void, rather than accepting an Emacs integer
1286 and returning a dummy object. In some cases this fixes an
1287 unlikely bug when the corresponding int is outside Emacs integer
1288 range. All uses changed.
1289 * dired.c (directory_files_internal_unwind):
1290 * fileio.c (do_auto_save_unwind):
1291 * gtkutil.c (pop_down_dialog):
1292 * insdel.c (reset_var_on_error):
1293 * lread.c (load_unwind):
1294 * xfns.c (clean_up_file_dialog):
1295 * xmenu.c, nsmenu.m (pop_down_menu):
1296 * xmenu.c (cleanup_widget_value_tree):
1297 * xselect.c (wait_for_property_change_unwind):
1298 Accept pointer and return void, rather than accepting an Emacs
1299 save value encapsulating the pointer and returning a dummy object.
1300 All uses changed.
1301 * editfns.c (Fformat): Update the saved pointer directly via
1302 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
1303 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
1304 (unwind_body): New function.
1305 (record_unwind_protect): First arg is now a function returning void,
1306 not a dummy Lisp_Object.
1307 (record_unwind_protect_ptr, record_unwind_protect_int)
1308 (record_unwind_protect_void): New functions.
1309 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
1310 * fileio.c (struct auto_save_unwind): New type.
1311 (do_auto_save_unwind): Use it.
1312 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
1313 * insdel.c (struct rvoe_arg): New type.
1314 (reset_var_on_error): Use it.
1315 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
1316 New constants.
1317 (specbinding_func): Remove; there are now several such functions.
1318 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
1319 (set_unwind_protect_ptr): New function.
1320 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
1321
4e604a5d
PE
1322 Be simpler and more consistent about reporting I/O errors.
1323 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1324 Say "Read error" and "Write error", rather than "I/O error", or
1325 "IO error reading", or "IO error writing", when a read or write
1326 error occurs.
1327 * process.c (Fmake_network_process, wait_reading_process_output)
1328 (send_process, Fprocess_send_eof, wait_reading_process_output):
1329 Capitalize diagnostics consistently. Put "failed foo" at the
1330 start of the diagnostic, so that we don't capitalize the
1331 function name "foo". Consistently say "failed" for such
1332 diagnostics.
1333 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
1334 All callers changed. This is so it can use report_file_error.
1335 * sysdep.c (serial_open, serial_configure): Capitalize I/O
1336 diagnostics consistently as above.
1337
a9757f6a
PE
1338 * fileio.c (report_file_errno): Fix errno reporting bug.
1339 If the file name is neither null nor a pair, package it up as a
1340 singleton list. All callers changed, both to this function and to
1341 report_file_error. This fixes a bug where the memory allocator
1342 invoked by list1 set errno so that the immediately following
1343 report_file_error reported the wrong errno value.
1344
c43843aa
PE
1345 Fix minor problems found by --enable-gcc-warnings.
1346 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
1347 * keyboard.c (kbd_buffer_get_event): Remove unused local.
1348
18c26d81
JD
13492013-07-16 Jan Djärv <jan.h.d@swipnet.se>
1350
1351 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
1352 Set event->arg to Qt if switch-event shall be generated.
1353 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
1354
1355 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
1356
1357 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
1358 FOCUS_OUT_EVENT.
1359
1360 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
1361 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
1362 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
1363 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
44e18199 1364 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
18c26d81
JD
1365 and there is a focused frame.
1366 (head_table): Add focus-in and focus-out.
1367 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
1368 bind to handle-focus-in/out.
1369
1370 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
1371 (Fhandle_switch_frame): Call Fhandle_focus_in.
1372 (syms_of_frame): defsubr handle-focus-in/out.
1373
6c6f1994
PE
13742013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1375
c7ddc792
PE
1376 Fix porting bug to older POSIXish platforms (Bug#14862).
1377 * sysdep.c (emacs_pipe): New function, that implements
1378 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
1379 This should port better to CentOS 5 and to Mac OS X 10.6.
1380 All calls to pipe2 changed.
1381
6c6f1994
PE
1382 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
1383 This makes the code easier to read and the executable a bit smaller.
1384 Do not replace all calls to Fcons that happen to create lists,
1385 just calls that are intended to create lists. For example, when
1386 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
1387 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
1388 Similarly for list2 through list5.
1389 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1390 * bytecode.c (exec_byte_code):
1391 * callint.c (quotify_arg, Fcall_interactively):
1392 * callproc.c (Fcall_process, create_temp_file):
1393 * charset.c (load_charset_map_from_file)
1394 (Fdefine_charset_internal, init_charset):
1395 * coding.c (get_translation_table, detect_coding_system)
1396 (Fcheck_coding_systems_region)
1397 (Fset_terminal_coding_system_internal)
1398 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
1399 * composite.c (update_compositions, Ffind_composition_internal):
1400 * dired.c (directory_files_internal, file_name_completion)
1401 (Fsystem_users):
1402 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
1403 * doc.c (Fsnarf_documentation):
1404 * editfns.c (Fmessage_box):
1405 * emacs.c (main):
1406 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
1407 (Feval, eval_sub, Ffuncall, apply_lambda):
1408 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
1409 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
1410 (Fset_file_times, Finsert_file_contents)
1411 (Fchoose_write_coding_system, Fwrite_region):
1412 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
1413 * font.c (font_registry_charsets, font_parse_fcname)
1414 (font_prepare_cache, font_update_drivers, Flist_fonts):
1415 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
1416 * frame.c (make_frame, Fmake_terminal_frame)
1417 (x_set_frame_parameters, x_report_frame_params)
1418 (x_default_parameter, Fx_parse_geometry):
1419 * ftfont.c (syms_of_ftfont):
1420 * image.c (gif_load):
1421 * keyboard.c (command_loop_1):
1422 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
1423 (Fcopy_keymap, append_key, Fcurrent_active_maps)
1424 (Fminor_mode_key_binding, accessible_keymaps_1)
1425 (Faccessible_keymaps, Fwhere_is_internal):
1426 * lread.c (read_emacs_mule_char):
1427 * menu.c (find_and_return_menu_selection):
1428 * minibuf.c (get_minibuffer):
1429 * nsfns.m (Fns_perform_service):
1430 * nsfont.m (ns_script_to_charset):
1431 * nsmenu.m (ns_popup_dialog):
1432 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
1433 (Fx_own_selection_internal):
1434 * nsterm.m (append2):
1435 * print.c (Fredirect_debugging_output)
1436 (print_prune_string_charset):
1437 * process.c (Fdelete_process, Fprocess_contact)
1438 (Fformat_network_address, set_socket_option)
1439 (read_and_dispose_of_process_output, write_queue_push)
1440 (send_process, exec_sentinel):
1441 * sound.c (Fplay_sound_internal):
1442 * textprop.c (validate_plist, add_properties)
1443 (Fput_text_property, Fadd_face_text_property)
1444 (copy_text_properties, text_property_list, syms_of_textprop):
1445 * unexaix.c (report_error):
1446 * unexcoff.c (report_error):
1447 * unexsol.c (unexec):
1448 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
1449 (Fformat_mode_line, syms_of_xdisp):
1450 * xfaces.c (set_font_frame_param)
1451 (Finternal_lisp_face_attribute_values)
1452 (Finternal_merge_in_global_face, syms_of_xfaces):
1453 * xfns.c (x_default_scroll_bar_color_parameter)
1454 (x_default_font_parameter, x_create_tip_frame):
1455 * xfont.c (xfont_supported_scripts):
1456 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
1457 (menu_help_callback, xmenu_show):
1458 * xml.c (make_dom):
1459 * xterm.c (set_wm_state):
1460 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
1461 and similarly for list2 through list5.
1462
bafe80ce
PE
14632013-07-15 Paul Eggert <eggert@cs.ucla.edu>
1464
1465 * callproc.c (Fcall_process_region): Fix minor race and tune.
1466 (create_temp_file): New function, with the temp-file-creation part
1467 of the old Fcall_process_region. Use Fcopy_sequence to create the
1468 temp file name, rather than alloca + build_string, for simplicity.
1469 Don't bother to block input around the temp file creation;
1470 shouldn't be needed. Simplify use of mktemp. Use
1471 record_unwind_protect immediately after creating the temp file;
1472 this closes an unlikely race where the temp file was not removed.
1473 Use memcpy rather than an open-coded loop.
1474 (Fcall_process_region): Use the new function. If the input is
1475 empty, redirect from /dev/null rather than from a newly created
1476 empty temp file; this avoids unnecessary file system traffic.
1477
4700b5a5
PE
14782013-07-14 Paul Eggert <eggert@cs.ucla.edu>
1479
5c97beae
PE
1480 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
1481 Simplify by making this case like the other two. This is a bit
1482 slower on obsolete hosts, but the extra complexity isn't worth it.
1483
4700b5a5
PE
1484 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
1485 * process.c (create_process) [!DOS_NT]:
1486 Remove now-unnecessary calls to emacs_close.
1487
f9a74c4c
EZ
14882013-07-13 Eli Zaretskii <eliz@gnu.org>
1489
922ae7ee
EZ
1490 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
1491 returning early. (Bug#14850)
1492
f9a74c4c
EZ
1493 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
1494 and inhibit-iso-escape-detection attributes of 'undecided'.
1495 (Bug#14822)
1496
5e301d76
PE
14972013-07-13 Paul Eggert <eggert@cs.ucla.edu>
1498
69e0e5ee
PE
1499 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
1500 Reported by Herbert J. Skuhra in
1501 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
1502
5e301d76
PE
1503 Don't lose top specpdl entry when memory is exhausted.
1504 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
1505 specpdl overflow here, to simplify callers; all callers changed.
1506 Always reserve an unused entry at the stack top; this avoids
1507 losing the top entry's information when memory is exhausted.
1508
7e649856
PE
15092013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1510
a773ed9a
PE
1511 Clean up errno reporting and fix some errno-reporting bugs.
1512 * callproc.c (Fcall_process):
1513 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1514 * process.c (create_process, Fmake_network_process):
1515 * unexaix.c (report_error):
1516 * unexcoff.c (report_error):
1517 Be more careful about reporting the errno of failed operations.
1518 The code previously reported the wrong errno sometimes.
1519 Also, prefer report_file_errno to setting errno + report_file_error.
1520 (Fcall_process): Look at openp return value rather than at path,
1521 as that's a bit faster and clearer when there's a numeric predicate.
1522 * fileio.c (report_file_errno): New function, with most of the
1523 old contents of report_file_error.
1524 (report_file_error): Use it.
1525 (Ffile_exists_p, Ffile_accessible_directory_p):
1526 Set errno to 0 when it is junk.
1527 * fileio.c (Faccess_file):
1528 * image.c (x_create_bitmap_from_file):
1529 Use faccessat rather than opening the file, to avoid the hassle of
1530 having a file descriptor open.
1531 * lisp.h (report_file_errno): New decl.
1532 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
1533
7e649856
PE
1534 Minor EBADF fixes.
1535 * process.c (create_process, wait_reading_process_output) [AIX]:
1536 Remove obsolete SIGHUP-related code, as Emacs no longer disables
1537 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
1538 a multithreaded environment anyway).
1539 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
1540
f6774c1a
AS
15412013-07-12 Andreas Schwab <schwab@linux-m68k.org>
1542
1543 * image.c (x_find_image_file): Don't close a remote file handle.
1544
bacba3c2
PE
15452013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1546
1547 Fix races with threads and file descriptors.
1548 * callproc.c (Fcall_process_region):
1549 * dired.c (open_directory):
1550 * emacs.c (main, Fdaemon_initialized):
1551 * image.c (x_find_image_file):
1552 * inotify.c (Finotify_rm_watch):
1553 * lread.c (Flocate_file_internal):
1554 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
1555 * term.c (term_mouse_moveto, init_tty):
1556 * termcap.c (tgetent):
1557 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
1558 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
1559 * unexhp9k800.c, unexmacosx.c (unexec):
1560 * callproc.c (Fcall_process_region):
1561 Use emacs_close, not close.
1562 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
1563 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
1564 and posix_close function on current platforms (which all lack them).
1565 (emacs_close): Use it. This should fix the races on GNU/Linux and
1566 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
1567 and it should avoid closing random victim file descriptors on
1568 other platforms.
1569
653d4f43
PE
15702013-07-11 Paul Eggert <eggert@cs.ucla.edu>
1571
c8536ec4
PE
1572 * inotify.c (uninitialized): Remove. All uses replaced by -1.
1573 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
1574 Touch up doc a bit.
1575
9c203066
PE
1576 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
1577 This is for .gdbinit xbacktrace.
1578
653d4f43
PE
1579 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
1580 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
1581 (emacs_set_tty): Now static.
1582 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
1583 * term.c (tty_capable_p, tty_default_color_capabilities)
1584 (get_tty_terminal, term_mouse_movement)
1585 (handle_one_term_event, init_tty, maybe_fatal):
1586 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
1587 (tgetent, scan_file, name_match, compare_contin):
1588 * terminal.c (get_terminal):
1589 Use bool for boolean.
1590 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
1591 Prefer char to unsigned char if either will do.
1592 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
1593 (tty_write_glyphs): Prefer int to unsigned.
1594 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
1595 All callers changed.
1596 * termcap.c (tprint, main) [TEST]: Remove non-working test.
1597
45b683a1
PE
15982013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1599
29abe551
PE
1600 Port to C89.
1601 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
1602 (B__dummy__): New dummy symbol, to pacify C89.
1603 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
1604 they can't grok varargs macros.
1605 * dispnew.c (add_window_display_history)
1606 (add_frame_display_history):
1607 * print.c (print_object):
1608 * xdisp.c (debug_method_add):
1609 Use %p printf format only for void pointers.
1610 * emacs.c (usage_message): New constant, replacing ...
1611 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
1612 (main): Adjust to usage reorg.
1613 * fns.c (syms_of_fns):
1614 * profiler.c (syms_of_profiler):
1615 Don't use non-constant struct initializers.
1616 * gnutls.h (gnutls_initstage_t):
1617 * lisp.h (enum Lisp_Fwd_Type):
1618 * lread.c (lisp_file_lexically_bound_p):
1619 * xsettings.c (anonymous enum):
1620 Remove trailing comma.
1621 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
1622 * lisp.h (ENUM_BF): Use unsigned if pedantic.
1623 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
1624 (DEFUN): Use it.
1625 * regex.c (const_re_char): New type, to pacify strict C89.
1626 All uses of 'const re_char' replaced to use it.
1627 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
1628 with glibc when strict C89. This change is imported from gnulib.
1629 All uses changed.
1630 (_Restrict_arr_): Rename from __restrict_arr, similarly.
1631 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
1632 Omit GNU_LINUX implementation, since it requires long long.
1633 * xterm.c (x_draw_underwave):
1634 Do not assume the traditional order of struct's members.
1635 (x_term_init): Rewrite to avoid the need for non-constant structure
1636 initializers.
1637
45b683a1 1638 Syntax cleanup, mostly replacing macros with functions.
763a086d 1639 This removes the need for the syntax_temp hack.
45b683a1
PE
1640 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
1641 * syntax.c (SYNTAX_INLINE): New macro.
1642 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
1643 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
1644 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
1645 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
1646 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
1647 (SYNTAX_COMEND_FIRST): Now functions, not macros.
1648 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
1649 Now constants, not macros.
1650 (syntax_temp) [!__GNUC__]: Remove.
1651 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
1652 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
1653 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
1654 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
1655 Move here from syntax.h; now functions, not macros. Except for the
1656 last function, these are static since only syntax.c uses them.
1657 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
1658 All uses changed. Now a function, not a macro; use this fact
1659 to simplify the code.
1660 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
1661 compiler bugs; no longer relevant.
1662 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1663 (SYNTAX_INLINE): New macro.
1664 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
1665 for the new functions. Use bool for boolean member.
1666 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
1667 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
1668 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
1669 (SETUP_BUFFER_SYNTAX_TABLE):
1670 Now extern inline functions, not macros.
1671 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
1672 Remove; all uses replaced by implementation.
1673 (syntax_temp) [!__GNUC__]: Remove decl.
1674 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
1675
29be4a50
JD
16762013-07-10 Jan Djärv <jan.h.d@swipnet.se>
1677
1678 * emacs.c (main): Fix syntax error.
1679
954b166e
PE
16802013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1681
1682 Timestamp fixes for undo (Bug#14824).
1683 * atimer.c (schedule_atimer):
1684 * fileio.c (Ffile_newer_than_file_p):
1685 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
1686 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
1687 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
1688 (syms_of_fileio): Remove Sclear_visited_file_name.
1689 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
1690 file doesn't exist; this avoids an ambiguity with negative timestamps.
1691 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
1692 * systime.h (make_emacs_time, invalid_emacs_time):
1693 Don't assume struct timespec layout; POSIX doesn't guarantee it.
1694 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
1695 * undo.c (record_first_change): Push (visited-file-modtime) onto
1696 undo list rather than reimplementing it by hand, incorrectly.
1697
d74647c3
KB
16982013-07-09 Ken Brown <kbrown@cornell.edu>
1699
1700 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
1701
3c51b96b
JB
17022013-07-09 Juanma Barranquero <lekktu@gmail.com>
1703
1704 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
1705
4ebbdd67
PE
17062013-07-09 Paul Eggert <eggert@cs.ucla.edu>
1707
1708 Handle errno and exit status a bit more carefully.
1709 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
1710 number into an exit status. Instead, use EXIT_CANCELED.
1711 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
1712 * callproc.c (relocate_fd):
1713 * emacs.c (close_output_streams, main):
1714 * process.c (create_process):
1715 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
1716 Use emacs_perror for simplicity.
1717 * callproc.c (relocate_fd, main):
1718 * sysdep.c (sys_subshell):
1719 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
1720 (shut_down_emacs): Use emacs_write, not write.
1721 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
1722 * fileio.c (Fcopy_file, e_write):
1723 * nsterm.m (ns_select):
1724 * process.c (send_process):
1725 * sound.c (vox_write):
1726 Use emacs_write_sig, not emacs_write.
1727 * lisp.h (emacs_write_sig, emacs_perror): New decls.
1728 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
1729 New constants.
1730 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
1731 of write.
1732 (emacs_full_write): New function.
1733 (emacs_write): Rewrite to use it.
1734 (emacswrite_sig, emacs_perror): New functions.
1735 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
1736
44e18199 17372013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
e4b1e5af
JD
1738
1739 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
1740 on NS even if it is present. Pixmap on NS is a void*.
1741
9caab067
PE
17422013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1743
1744 Port to Ubuntu 10 (Bug#14803).
1745 Problem reported by T.V. Raman.
1746 * process.c (close_on_exec, accept4, process_socket):
1747 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
1748
1d442672
EZ
17492013-07-07 Eli Zaretskii <eliz@gnu.org>
1750
1751 * w32.c (sys_dup): Declare prototype.
1752
1753 * filelock.c:
1754 * emacs.c:
1755 * callproc.c [WINDOWSNT]: Include sys/socket.h.
1756
067428c1
PE
17572013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1758
1759 Make file descriptors close-on-exec when possible (Bug#14803).
1760 This simplifies Emacs a bit, since it no longer needs to worry
1761 about closing file descriptors by hand in some cases.
1762 It also fixes some unlikely races. Not all such races, as
1763 libraries often open files internally without setting
1764 close-on-exec, but it's an improvement.
1765 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
1766 * callproc.c (Fcall_process) [!MSDOS]:
1767 * emacs.c (main) [!DOS_NT]:
1768 * nsterm.m (ns_term_init):
1769 * process.c (create_process):
1770 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
1771 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
1772 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
1773 Prefer mkostemp with O_CLOEXEC to mkstemp.
1774 * callproc.c (relocate_fd) [!WINDOWSNT]:
1775 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
1776 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
1777 now using pipe2.
1778 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
1779 Make the resulting file descriptor close-on-exec.
1780 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
1781 * lread.c (load_descriptor_list, load_descriptor_unwind):
1782 Remove; no longer needed. All uses removed.
1783 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
1784 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
1785 New functions.
1786 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
1787 (Fmake_network_process, Fnetwork_interface_list):
1788 (Fnetwork_interface_info, server_accept_connection):
1789 Make newly-created socket close-on-exec.
1790 * sysdep.c (emacs_open, emacs_fopen):
1791 Make new-created descriptor close-on-exec.
1792 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
1793 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
1794
0da857dd
JD
17952013-07-07 Jan Djärv <jan.h.d@swipnet.se>
1796
1797 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
1798 for NS_IMPL_GNUSTEP.
1799
5f86adcd
PE
18002013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1801
1802 Fix openp errno handling.
1803 * callproc.c (Fcall_process): Preserve openp errno around close.
1804 * lread.c (openp): Set errno when returning -1, as some callers
1805 expect this.
1806
1afb1d07
JD
18072013-07-06 Jan Djärv <jan.h.d@swipnet.se>
1808
1809 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
1810
1811 * nsterm.h (NSSavePanel): Update comment.
1812 (NSAPP_DATA2_RUNFILEDIALOG): Define.
1813 (ns_run_file_dialog): Declare.
1814
1815 * nsfns.m: Remove panelOK.
1816 (ns_fd_data): New.
1817 (ns_run_file_dialog): New function.
1818 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
1819 event loop, so file dialog is popped up by ns_run_file_dialog, called
1820 by sendEvent (Bug#14578).
1821 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
1822
3323c263
EZ
18232013-07-06 Eli Zaretskii <eliz@gnu.org>
1824
fdda0220
EZ
1825 * xdisp.c (default_line_pixel_height): New function.
1826 (pos_visible_p, move_it_vertically_backward, try_scrolling)
1827 (try_cursor_movement, redisplay_window, try_window)
1828 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
1829
1830 * window.c (window_scroll_pixel_based): use
1831 default_line_pixel_height.
1832
1833 * dispextern.h (default_line_pixel_height): Add prototype.
1834
1835 * frame.c (x_set_line_spacing): Accept a float value for
1836 line-spacing parameter, per the documentation.
1837
3323c263
EZ
1838 * data.c (Fmultibyte_string_p): Doc fix.
1839
47ba6d43
PE
18402013-07-05 Paul Eggert <eggert@cs.ucla.edu>
1841
406af475
PE
1842 Use emacs_open more consistently when opening files.
1843 This handles EINTR more consistently now, and makes it easier
1844 to introduce other uniform changes to file descriptor handling.
1845 * src/systdio.h: New file.
1846 * src/buffer.c (mmap_init):
1847 * cygw32.c (chdir_to_default_directory):
1848 * dispnew.c (Fopen_termscript):
1849 * emacs.c (Fdaemon_initialized):
1850 * fileio.c (Fdo_auto_save):
1851 * image.c (slurp_file, png_load_body, jpeg_load_body):
1852 * keyboard.c (Fopen_dribble_file):
1853 * lread.c (Fload):
1854 * print.c (Fredirect_debugging_output):
1855 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
1856 * termcap.c (tgetent):
1857 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
1858 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
1859 * w32term.c (w32_initialize) [CYGWIN]:
1860 * xfaces.c (Fx_load_color_file):
1861 Use emacs_open instead of plain open, and emacs_fopen instead of
1862 plain fopen.
1863 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
1864 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
1865 * callproc.c (default_output_mode): New constant.
1866 (Fcall_process): Use it to call emacs_open instead of plain creat.
1867 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
1868 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
1869 (emacs_fopen): New function.
1870 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
1871 Include <lisp.h>, for emacs_open.
1872 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
1873
47ba6d43
PE
1874 Remove duplicate #include directives.
1875 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
1876 * xfaces.c:
1877 Don't include stdio.h twice.
1878 * buffer.c [USE_MMAP_FOR_BUFFERS]:
1879 Don't include sys/types.h or stdio.h twice.
1880 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
1881 * lread.c: Don't include coding.h twice.
1882 * nsfont.m: Don't include frame.h twice.
1883 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
1884 * ralloc.c: Don't include <unistd.h> twice.
1885 * xdisp.c: Don't include font.h twice.
1886 * xterm.c: Don't include fontset.h twice.
1887 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
1888
b9ed53d5
PE
18892013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1890
1891 Scale ImageMagick images more carefully.
1892 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
1893 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
1894 Be more careful about avoiding undefined behavior after
1895 integer overflow and division by zero.
1896
cf13177e
YM
18972013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1898
1899 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
1900 (syms_of_w32fns): DEFSYM them.
1901 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
1902 (CCHDEVICENAME): Define macros if not defined.
1903 (struct MONITOR_INFO_EX): New struct.
1904 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
1905 (enum_display_monitors_fn): New variable.
1906 (globals_of_w32fns): Initialize it.
1907 (Fx_display_pixel_width, Fx_display_pixel_height)
1908 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
1909 multi-monitor setups in docstrings.
1910 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
1911 screen size by primary monitor's millimeter per pixel.
1912 (w32_monitor_enum, w32_display_monitor_attributes_list)
1913 (w32_display_monitor_attributes_list_fallback)
1914 (Fw32_display_monitor_attributes_list): New functions.
1915 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
1916
1917 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
1918 if not defined.
1919 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
1920
86dfb7a8
MA
19212013-07-04 Michael Albinus <michael.albinus@gmx.de>
1922
1923 * fileio.c (Qfile_notify_error): New error symbol.
1924
1925 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
1926 * inotify.c (inotify_callback, symbol_to_inotifymask)
1927 (Finotify_add_watch, Finotify_rm_watch): Use it.
1928 (inotifyevent_to_event): Exchange order of cookie and file name.
1929 (Finotify_add_watch): Adapt docstring.
1930
1931 * lisp.h (Qfile_notify_error): Declare.
1932
2c1c974b
PE
19332013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1934
1935 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
1936 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1937 Do not clear _malloc_thread_enabled_p, undoing the previous change,
1938 which did not work (see <http://bugs.gnu.org/14569#307>).
1939 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
1940 && (!noninteractive || initialized)). This attempts to thread
1941 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
1942
7a35b20f
JB
19432013-07-04 Juanma Barranquero <lekktu@gmail.com>
1944
1945 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
1946 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
1947
1ce5cd04
PE
19482013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1949
1950 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
1951 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1952 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
1953 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
1954
57f8c490
PE
19552013-07-02 Paul Eggert <eggert@cs.ucla.edu>
1956
1957 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
1958 Define to __sys_siglist.
1959
bcffb5ca
EZ
19602013-07-02 Eli Zaretskii <eliz@gnu.org>
1961
1962 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
1963 word-wrap, so that overflow-newline-into-fringe would work in
1964 visual-line-mode. (Bug#2749)
1965 (move_it_in_display_line_to): When the last scanned display
1966 element fits exactly on the display line, and
1967 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
1968 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
1969 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
1970 finding buffer position that corresponds to pixel coordinates,
1971 e.g. in buffer_posn_from_coords.
1972
2c41e781
JD
19732013-07-02 Jan Djärv <jan.h.d@swipnet.se>
1974
1975 * process.c (handle_child_signal): Call catch_child_signal if
1976 NS_IMPL_GNUSTEP.
1977
c2418359
PE
19782013-07-02 Paul Eggert <eggert@cs.ucla.edu>
1979
52a9bcae
PE
1980 Don't convert function pointers to void * and back.
1981 It isn't portable C, and it's easy enough to avoid.
1982 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
1983 (make_save_value): Add support for SAVE_FUNCPOINTER.
1984 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
1985 * print.c (print_object):
1986 Distinguish function from object pointers.
1987 * lisp.h (SAVE_FUNCPOINTER): New constant.
1988 (SAVE_SLOT_BITS): Adjust to it.
1989 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
1990 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
1991 (voidfuncptr): New typedef.
1992 (struct Lisp_Save_Value): New member data[0].funcpointer.
1993 (XSAVE_FUNCPOINTER): New function.
1994
c2418359
PE
1995 Simplify buildobj processing.
1996 * Makefile.in (buildobj.h): Make it a sequence of strings each
1997 followed by comma, rather than a single string. Put it into a
1998 .tmp file in case there's an error while generating it.
1999 (gl-stamp): Use .tmp for temp files.
2000 (mostlyclean): Clean .tmp files.
2001 * doc.c (buildobj): Move to just the routine that needs it.
2002 It's now an array of strings, so processing is simpler.
2003
8f43ce49
PE
20042013-07-01 Paul Eggert <eggert@cs.ucla.edu>
2005
2006 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
2007 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
2008 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2009 Invoke malloc_enable_thread even when not interactive.
2010 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
2011 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
2012 in this case, since the underlying bug has now been fixed.
2013
24827db9
JB
20142013-07-01 Juanma Barranquero <lekktu@gmail.com>
2015
2016 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
2017 unlinking it (bug#14691).
2018
ef099a94
MN
20192013-06-30 Michal Nazarewicz <mina86@mina86.com>
2020
2021 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
2022 before checking whether buffer is modified. This lets
2023 `kill-buffer-query-functions' cancel killing of the buffer or save
2024 its content before `kill-buffer' asks user the "Buffer %s
2025 modified; kill anyway?" question.
2026
9d3f2fc2
JD
20272013-06-30 Jan Djärv <jan.h.d@swipnet.se>
2028
2029 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
2030 Let the super performKeyEquivalent deal with them (Bug#14747).
2031
e6c6c8c7
PE
20322013-06-30 Paul Eggert <eggert@cs.ucla.edu>
2033
1d71c1d9
PE
2034 * widget.c (resize_cb): Remove unused local.
2035
8f5f35cc
PE
2036 Do not use GTK 3 if it exists but cannot be compiled.
2037 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
2038 * xterm.c (x_error_handler) [!USE_GTK]:
2039 Do not use GTK 3.
2040
e6c6c8c7
PE
2041 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
2042
0ba54312
EZ
20432013-06-30 Eli Zaretskii <eliz@gnu.org>
2044
5d1c3286
EZ
2045 * intervals.c (get_local_map): Instead of aborting, clip POSITION
2046 to the valid range of values. (Bug#14753)
2047
0ba54312
EZ
2048 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
2049 when moving point by using the current glyph matrix. This avoids
2050 the need to force redisplay when this function is called in a
2051 loop.
2052
9c90cc06
PE
20532013-06-29 Paul Eggert <eggert@cs.ucla.edu>
2054
2055 Fix minor problems found by static checking.
2056 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
2057 Redo the latter's body to sidestep GCC parenthesization warnings.
2058 (setup_coding_system, detect_coding, detect_coding_system): Use them.
2059 * coding.c (detect_coding, detect_coding_system):
2060 * coding.h (struct undecided_spec):
2061 Use bool for boolean.
2062 * image.c (QCmax_width, QCmax_height): Now static.
2063 * xdisp.c (Fmove_point_visually): Remove unused local.
2064
4c672a0f
EZ
20652013-06-29 Eli Zaretskii <eliz@gnu.org>
2066
2067 * xdisp.c (Fmove_point_visually): New function.
2068
c1ea3abf
JB
20692013-06-28 Kenichi Handa <handa@gnu.org>
2070
2071 * coding.h (define_coding_undecided_arg_index): New enum.
2072 (coding_attr_index): New members
2073 coding_attr_undecided_inhibit_null_byte_detection,
2074 coding_attr_undecided_inhibit_iso_escape_detection,
2075 coding_attr_undecided_prefer_utf_8.
2076 (undecided_spec): New struct.
2077 (struct coding_system): New member `undecided' of the member
2078 `spec'.
2079
2080 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
2081 (detect_coding): Likewise.
2082 (detect_coding_system): Likewise.
2083 (Fdefine_coding_system_internal): New coding system properties
2084 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
2085 :prefer-utf-8.
2086 (syms_of_coding): Adjust for coding_arg_undecided_max.
2087
ba3de9e6
PE
20882013-06-28 Paul Eggert <eggert@cs.ucla.edu>
2089
2090 * image.c (x_from_xcolors): Remove unused local.
2091
547c9269
YM
20922013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2093
2094 Defer image data transfer between X client and server until actual
2095 display happens.
2096
2097 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
2098 and `mask_img'.
2099
2100 * image.c (Destroy_Image): Remove.
2101 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
2102 `mask_p', and `colors_p'. All uses changed.
2103 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
2104 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
2105 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
2106 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
2107 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 2108 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
2109 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
2110 (image_get_x_image, image_unget_x_image): New functions or macros.
2111 (image_background, image_background_transparent, x_to_xcolors)
2112 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
2113 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
2114 instead of Destroy_Image.
2115 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
2116 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
2117 (png_load_body, jpeg_load_body, tiff_load, gif_load)
2118 (imagemagick_load_image, svg_load_image): Use them instead of
2119 x_create_x_image_and_pixmap, and x_put_x_image followed by
2120 x_destroy_x_image, respectively.
2121 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
2122 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
2123 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
2124 background_transparent fields.
2125 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
2126 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
2127
dae2f5ef
PE
21282013-06-27 Paul Eggert <eggert@cs.ucla.edu>
2129
2130 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
2131 This mostly consists of undoing recent changes.
2132 * callproc.c (Fcall_process):
2133 * process.c (create_process):
2134 Do not worry about catching SIGCHLD here, undoing previous change.
2135 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
2136 * process.c, process.h (catch_child_signal):
2137 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
2138 * process.c (catch_child_handler): Don't worry about being called
2139 lazily and do not assume caller has blocked SIGCHLD, undoing
2140 previous change. Move first-time stuff back to
2141 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
2142 tickle glib, as that causes Cygwin bootstrap to fail. Do not
2143 set lib_child_handler if it's already initialized, which may
2144 help avoid problems on GNUStep.
2145
fa55d2aa
PE
21462013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2147
2148 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
2149 * callproc.c (Fcall_process):
2150 * process.c (create_process):
2151 Make sure SIGCHLD is caught before we fork,
2152 since Emacs startup no arranges to catch SIGCHLD.
2153 * process.c (lib_child_handler): Initialize to null, not to
2154 dummy_handler.
2155 (catch_child_signal): Allow self to be called lazily.
2156 Do nothing if it's already been called.
2157 Assume caller has blocked SIGCHLD (all callers do now).
2158 * emacs.c (main): Do not catch SIGCHLD here; defer it until
2159 just before it's really needed.
2160 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
2161 since it hasn't been caught yet.
2162
f3f9606c
LMI
21632013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
2164
2165 * image.c (compute_image_size): New function to implement
2166 :max-width and :max-height.
2167 (imagemagick_load_image): Use it.
2168
c7041908
PE
21692013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2170
2171 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
2172 * callproc.c, process.h (block_child_signal, unblock_child_signal):
2173 Now extern.
2174 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
2175 * process.c (catch_child_signal): Block SIGCHLD while futzing with
2176 the SIGCHLD handler, since the code is not atomic and (due to glib)
2177 signals may be arriving now.
2178 * sysdep.c (init_signals): Do not catch child signals here;
2179 'main' now does that later, at a safer time.
2180
f86852b4
PE
21812013-06-22 Paul Eggert <eggert@cs.ucla.edu>
2182
0dfeed58
PE
2183 Clean up SIGCHLD handling a bit (Bug#14569).
2184 * process.c, process.h (catch_child_signal):
2185 Now always extern, even if !NS_IMPL_GNUSTEP.
2186 * process.c (catch_child_signal): Move glib tickler here from
2187 init_process_emacs, so that it's done earlier in Emacs
2188 initialization. Also move the noninteractive && !initialized
2189 check here from init_process_emacs. This is all a bit cleaner for
2190 GNUish platforms, and I hope it works around the Cygwin bug.
2191 * sysdep.c (init_signals): Invoke catch_child_signal here, so
2192 that glib signal handling is tickled before glib creates threads.
2193
f86852b4
PE
2194 * process.c (wait_reading_process_output): Avoid int overflow
2195 when reading more than 2 GiB total from a process.
2196
cbd6509c
PE
21972013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2198
2199 * process.c (create_process): Handle a couple more cases,
2200 i.e., work even if new_argv and wait_child_setup[i] are cached.
2201 Use Fcall_process's style for volatile vars.
2202
9de1114a
AS
22032013-06-21 Andreas Schwab <schwab@linux-m68k.org>
2204
2205 * process.c (create_process): Mark PROCESS volatile.
2206
fbe9e0b9
PE
22072013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2208
2209 Use C99-style flexible array members if available.
2210 This avoids some subtle aliasing issues, which typically
2211 aren't a problem with GCC but may be a problem elsewhere.
2212 * alloc.c (sdata): New typedef, replacing the old struct sdata.
2213 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
2214 In either case, it uses a flexible array member rather than
2215 the old struct hack. All uses changed.
2216 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
2217 Adjust to sdata reorganization.
2218 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
2219 Use offsetof (struct, flex_array_member), not sizeof (struct), as
2220 that ports better to pre-C99 non-GCC.
2221 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
2222 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
2223 as the latter has changed.
2224 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
2225 and port better to pre-C99 GCC.
2226 * image.c (struct xpm_cached_color):
2227 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
2228 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
2229 Use FLEXIBLE_ARRAY_MEMBER.
2230 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
2231 Move decl to top level so it gets checked against implementation.
2232 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
2233 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
2234
1fc71008
PE
22352013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2236
2237 * syntax.c: Integer cleanups.
2238 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
2239 All uses that need 0-or-2 changed to:
2240 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
2241 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
2242 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
2243 (char_quoted, prev_char_comend_first, back_comment)
2244 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2245 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
2246 Use bool for boolean.
2247 (update_syntax_table, skip_chars, skip_syntaxes):
2248 Prefer int to unsigned when either will do.
2249 (back_comment): Return boolean success flag, like forw_comment,
2250 instead of positive-or-minus-1 (which might have overflowed int anyway).
2251 Don't stuff ptrdiff_t into int.
2252 (syntax_spec_code, syntax_code_spec): Now const.
2253 (Fmatching_paren, scan_lists, scan_sexps_forward):
2254 Use enum syntaxcode for syntax code.
2255 (Fmatching_paren): Check that arg is a character, not just an integer.
2256 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
2257 (Finternal_describe_syntax_value): Omit no-longer-needed
2258 comparison to 0.
2259 (skip_chars): Use char, not unsigned char, when the distinction
2260 doesn't matter.
2261 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
2262 * bytecode.c (exec_byte_code):
2263 * syntax.c (syntax_spec_code, Fchar_syntax)
2264 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2265 (init_syntax_once):
2266 * syntax.h (SYNTAX_WITH_FLAGS):
2267 Omit unnecessary casts.
2268
b932cad7
EZ
22692013-06-20 Eli Zaretskii <eliz@gnu.org>
2270
2271 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
2272 line dimensions here, to avoid race conditions with the main
2273 thread. (Bug#14062, bug#14630, bug#14669)
2274
2275 * w32term.c (w32_draw_window_cursor): Compute the header line and
2276 mode line dimensions here.
2277 <w32_system_caret_window, w32_system_caret_hdr_height>:
2278 <w32_system_caret_mode_height>: New variables.
2279
2280 * w32term.h: Declare them.
2281
89561f72
PE
22822013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2283
5013fc08
PE
2284 * alloc.c (die): Move "assertion failed" string here ...
2285 * lisp.h (eassert): ... from here. Also, suppress evaluation of
2286 COND when SUPPRESS_CHECKING. This shrinks the executable text
2287 size by 0.8% to 2.2% when configured with --enable-checking,
2288 depending on optimization flags (GCC 4.8.1 x86-64).
2289
89561f72
PE
2290 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
2291
763a086d 22922013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
2293
2294 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
2295 base is 2; this is more accurate.
2296
983aeb9a
JB
22972013-06-19 Juanma Barranquero <lekktu@gmail.com>
2298
2299 * sound.c (string_default): Move to !WINDOWSNT section.
2300 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
2301
178ba3e6
PE
23022013-06-19 Paul Eggert <eggert@cs.ucla.edu>
2303
bbc51b15
PE
2304 * sound.c: Integer cleanups.
2305 Remove unnecessary forward decls.
2306 (struct sound_device): The 'file' member is now a Lisp_Object, not
2307 a char *, so that we needn't invoke alloca on a huge size.
2308 (Fplay_sound_internal): Adjust to this.
2309 (string_default): New function.
2310 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
2311 Use it to adjust to the struct sound_device change.
2312 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
2313 (be2hs) [0]: Remove.
2314
178ba3e6
PE
2315 * syntax.c (skip_chars): Don't use uninitialized storage
2316 when searching a multibyte buffer for characters that are not in a
2317 unibyte string that contains non-ASCII characters.
2318
69f60cdc
JD
23192013-06-18 Jan Djärv <jan.h.d@swipnet.se>
2320
2321 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
2322 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
2323
0d6224d4
PE
23242013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2325
2326 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
2327
3c542890
KH
23282013-06-18 Kenichi Handa <handa@gnu.org>
2329
f7e3f7cd
KH
2330 * font.c (Ffont_spec): Signal an error for an invalid font name
2331 (Bug#14648).
3c542890 2332
9349e5f7
PE
23332013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2334
2335 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
2336 In particular this ports to 32-bit sparc Sun cc.
2337 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
2338 array with a dummy element at specpdl[-1], so that its address can
2339 be taken portably.
2340 (unbind_to): Do not copy the binding; not needed, now that we
2341 copy old_value in the one place where the copy is needed.
2342 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
2343 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
2344 (union specbinding): Rename from struct specbinding. Redo layout
2345 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
2346 which is not portable. With Sun C 5.12 32-bit sparc, the
2347 declaration causes nargs to be an unsigned bitfield, a behavior
2348 that the C standard allows; but Emacs wants nargs to be signed.
2349 The overall type is now a union of structures rather than a
2350 structure of union of structures, and the 'kind' member is now a
2351 bitfield, so that the overall type doesn't grow. All uses changed.
2352 * process.c (Fmake_serial_process): Remove unnecessary initialization.
2353
0a4df6a5
PE
23542013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2355
ec6ecaad
PE
2356 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
2357 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
2358
0a4df6a5
PE
2359 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
2360
7bfe8dbc
EZ
23612013-06-17 Eli Zaretskii <eliz@gnu.org>
2362
2363 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
2364 unless we know that the window w's frame is a frame object.
2365 Another attempt at solving bug#14062 and bug#14630.
2366
708e05f6
LMI
23672013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
2368
2369 * textprop.c (property_set_type): New enum.
2370 (add_properties): Allow appending/prepending text properties.
2371 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 2372 (Fadd_text_properties): Move all the code into
708e05f6
LMI
2373 add_text_properties_1.
2374 (Fadd_face_text_property): New function that calls
2375 add_text_properties_1.
2376
84575e67
PE
23772013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2378
2379 Move functions from lisp.h to individual modules when possible.
2380 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
2381 * alloc.c (XFLOAT_INIT, set_symbol_name):
2382 * buffer.c (CHECK_OVERLAY):
2383 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
2384 (set_char_table_parent):
2385 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
2386 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
2387 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
2388 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
2389 (set_blv_valcell):
2390 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
2391 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
2392 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
2393 (backtrace_args, backtrace_debug_on_exit):
2394 * floatfns.c (CHECK_FLOAT):
2395 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
2396 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
2397 (set_hash_hash, set_hash_hash_slot, set_hash_index)
2398 (set_hash_index_slot):
2399 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
2400 * marker.c (CHECK_MARKER):
2401 * textprop.c (CHECK_STRING_OR_BUFFER):
2402 * window.c (CHECK_WINDOW_CONFIGURATION):
2403 Move here from lisp.h, and make these functions static rather than
2404 extern inline.
2405 * buffer.c (Qoverlayp):
2406 * data.c (Qsubrp):
2407 * fns.c (Qhash_table_p):
2408 * window.c (Qwindow_configuration_p):
2409 Now static.
2410 * lisp.h: Remove the abovementioned defns and decls.
2411
44e18199 2412 Use functions, not macros, for XINT etc (Bug#11935).
84575e67
PE
2413 In lisp.h, prefer functions to function-like macros, and
2414 constants to object-like macros, when either will do. This:
2415 . simplifies use, as there's no more need to worry about
2416 arguments' side effects being evaluated multiple times.
2417 . makes the code easier to debug on some platforms.
2418 However, when using gcc -O0, keep using function-like macros
2419 for a few critical operations, for performance reasons.
2420 This sort of thing isn't needed with gcc -Og, but -Og
2421 is a GCC 4.8 feature and isn't widely-enough available yet.
2422 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
2423 Remove enum lsb_bits; no longer needed.
2424 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
2425 * buffer.c (Qoverlap):
2426 * data.c (Qsubrp):
2427 * fns.c (Qhash_table_p):
2428 Now extern, so lisp.h can use these symbols.
2429 * dispextern.h: Include character.h, for MAX_CHAR etc.
2430 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2431 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2432 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2433 (GLYPH_CODE_P): Move here from lisp.h.
2434 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2435 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
2436 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
2437 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
2438 XUNTAG now returns void *.
2439 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
2440 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
2441 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
2442 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
2443 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
2444 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
2445 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
2446 (lisp_h_XPNTR, lisp_h_XSYMBOL):
2447 New macros, renamed from their sans-lisp_h_ counterparts.
2448 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
2449 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
2450 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
2451 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
2452 If compiling via GCC without optimization, define these as macros
2453 in addition to inline functions.
2454 To disable this, compile with -DINLINING=0.
2455 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
2456 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
2457 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
2458 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
2459 (INTMASK, VALMASK): Now macros, since static values cannot be
2460 accessed from extern inline functions.
2461 (VALMASK): Also a constant, for benefit of old GDB.
2462 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
2463 is INTEGERP, which can fold it in.
5165d44a 2464 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
2465 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
2466 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
2467 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
2468 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
2469 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
2470 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
2471 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
2472 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
2473 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
2474 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
2475 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
2476 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
2477 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
2478 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
2479 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
2480 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
2481 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
2482 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
2483 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
2484 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
2485 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
2486 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
2487 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
2488 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
2489 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
2490 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
2491 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
2492 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
2493 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
2494 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
2495 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
2496 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
2497 Now functions.
2498 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
2499 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
2500 (VALMASK): Define in one place rather than in two, merging the
2501 USE_LSB_TAG parts; this is simpler.
2502 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
2503 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
2504 Move up, to avoid use before definition.
2505 Also include "globals.h" earlier, for the same reason.
2506 (make_natnum): New function.
2507 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
2508 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
2509 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
2510 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
2511 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
2512 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
2513 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
2514 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
2515 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
2516 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
2517 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
2518 (Qwindow_configuration_p, Qimage): New forward declarations.
2519 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
2520 (STRING_COPYIN): Remove; unused.
2521 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
2522 (xcar_addr, xcdr_addr): New functions. All uses changed.
2523 (IEEE_FLOATING_POINT): Now a constant, not a macro.
2524 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2525 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2526 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2527 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
2528 (TYPE_RANGED_INTEGERP): Simplify.
2529 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
2530 (setlocale, fixup_locale, synchronize_system_messages_locale)
2531 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
2532 Now empty functions, not macros.
2533 (functionp): Return bool, not int.
2534 * window.c (Qwindow_configuration_p): Now extern,
2535 so window.h can use it.
2536 * window.h (Qwindowp): Move decl back to lisp.h.
2537
9583ec36
EZ
25382013-06-15 Eli Zaretskii <eliz@gnu.org>
2539
2540 * xdisp.c (Fline_pixel_height): New function, required for solving
2541 bug #14567.
2542
210272ce
PE
25432013-06-15 Paul Eggert <eggert@cs.ucla.edu>
2544
2545 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
2546
de0503df
SM
25472013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
2548
2549 * lread.c (syms_of_lread):
2550 * fns.c (Fprovide): Adjust to new format of after-load-alist.
2551
afbfe143
KD
25522013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
2553
2554 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
2555
d177e213
XF
25562013-06-12 Xue Fuqiao <xfq.free@gmail.com>
2557
2558 * fileio.c (expand_file_name): Doc fix.
2559
05e3e412
PE
25602013-06-11 Paul Eggert <eggert@cs.ucla.edu>
2561
f7394b12
PE
2562 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
2563 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
2564 Wait for self, not for 0. This can't hurt on GNU or similar
2565 system, and may help with Cygwin.
2566
05e3e412
PE
2567 * keyboard.c: Don't use PROP (...) as an lvalue.
2568 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
2569 Use set_prop (A, B), not PROP (A) = B.
2570
17dd3097
EZ
25712013-06-10 Eli Zaretskii <eliz@gnu.org>
2572
2573 * xdisp.c (get_it_property): Use it->window instead of generating
2574 a Lisp object from it->w.
2575
52fab9c9
EZ
25762013-06-09 Eli Zaretskii <eliz@gnu.org>
2577
2578 * xdisp.c (get_it_property): If it->object is a buffer, pass to
2579 get-char-property the window that is being rendered, instead of
2580 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
2581 (compute_display_string_pos): When W is NULL, use the current
2582 buffer as the object to pass to get-char-property.
2583 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
2584 pointer member of the bidi iterator, since no window is pertinent
2585 to this function.
52fab9c9 2586
5bf97bfc
EZ
25872013-06-08 Eli Zaretskii <eliz@gnu.org>
2588
2589 * bidi.c (bidi_fetch_char): Accept additional argument, the window
2590 being displayed, and pass it to compute_display_string_pos.
2591 (bidi_level_of_next_char, bidi_resolve_explicit_1)
2592 (bidi_paragraph_init): All callers changed.
2593
2594 * xdisp.c (init_from_display_pos, init_iterator)
2595 (handle_single_display_spec, next_overlay_string)
2596 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
2597 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
2598 Set bidi_it.w member from it->w.
5bf97bfc
EZ
2599 (compute_display_string_pos): Accept additional argument, the
2600 window being displayed, and pass it to Fget_char_property.
2601 (Bug#14575)
2602
2603 * dispextern.h (struct bidi_it): New member w, the window being
2604 displayed.
2605 (compute_display_string_pos): Adjust prototype.
2606
5de0e011
JD
26072013-06-08 Jan Djärv <jan.h.d@swipnet.se>
2608
e7b41c4c 2609 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
2610
2611 * process.c (wait_reading_process_output): Check for NS before GLIB.
2612 GLIB may be linked in due to rsvg, but ns_select must be called.
2613
5de0e011
JD
2614 * xgselect.c (xg_select): Remove call to window_system_available
2615 and g_main_context_pending at the top, so Gdk events (i.e. file
2616 notify) are processed when Emacs is started with -nw.
2617
a822acff
EZ
26182013-06-07 Eli Zaretskii <eliz@gnu.org>
2619
2620 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
2621 (ctagsfiles3): New variable, includes only *.m files.
2622 (TAGS): Use an explicit language name in the regular expressions,
2623 to avoid transformation of '/SOMETHING' by MSYS to
2624 'c:\MSYS\SOMETHING'.
2625
6c0a9ed1
RC
26262013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
2627
2628 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
2629
9ef6111b
EZ
26302013-06-06 Eli Zaretskii <eliz@gnu.org>
2631
2632 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
2633 still need to set the mouse pointer shape and activate help-echo.
2634 (Bug#14558)
2635
7d300d64
PE
26362013-06-06 Paul Eggert <eggert@cs.ucla.edu>
2637
2638 A few porting etc. fixes for the new file monitor code.
2639 See the thread containing
2640 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
2641 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
2642 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
2643 (dir_monitor_callback, Fgfile_rm_watch):
2644 Use assq_no_quit instead of Fassoc, for speed.
2645 (dir_monitor_callback, Fgfile_rm_watch):
2646 eassert that the monitor is a fixnum.
2647 (dir_monitor_callback): No need for CDR_SAFE.
2648 Simplify building of lisp with alternative tails.
2649 (Fgfile_add_watch, Fgfile_rm_watch):
2650 Do not assume glib functions set errno reliably on failure.
2651 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
2652 and signal an error otherwise.
2653 (Fgfile_rm_watch): Prefer CONSP to !NILP.
2654 Use Fdelq instead of Fdelete, for speed.
2655
817ebfcf
EZ
26562013-06-05 Eli Zaretskii <eliz@gnu.org>
2657
2658 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
2659 don't insist on being invoked on a highlighted tool-bar button.
2660 Avoids losing tool-bar functionality when mouse-highlight is nil.
2661 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
2662 Don't highlight when mouse-highlight is nil.
2663 (note_mouse_highlight): When mouse-highlight is nil, don't return
2664 right away; instead, run tool-bar and mode-line highlight
2665 subroutine, clear any existing highlight, and revert the mouse
2666 pointer to its default shape. (Bug#14558)
2667
55577e7c
SM
26682013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2669
2670 * lisp.mk (lisp): Add prog-mode.el.
2671
f019a684
PE
26722013-06-05 Paul Eggert <eggert@cs.ucla.edu>
2673
2674 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
2675 * process.c (dummy_handler): New function.
2676 (lib_child_handler): New static var.
2677 (handle_child_signal): Invoke it.
2678 (catch_child_signal): If a library has set up a signal handler,
2679 save it into lib_child_handler.
2680 (init_process_emacs): If using glib and not on Windows, tickle glib's
2681 child-handling code so that it initializes its private SIGCHLD handler.
2682 * syssignal.h (SA_SIGINFO): Default to 0.
2683 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
2684 31; it should no longer be needed now.
2685
90db8702
MA
26862013-06-05 Michael Albinus <michael.albinus@gmx.de>
2687
2688 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
2689
2690 * gfilenotify.c (globals_of_gfilenotify): New function.
2691 (syms_of_gfilenotify): Move global initialization there.
2692
2693 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
2694
bfa3acd6
SM
26952013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2696
2697 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
2698 * keyboard.c (menu_bar_items, tool_bar_items):
2699 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
2700 not override local keymaps any more.
2701
ba59bd80
EZ
27022013-06-04 Eli Zaretskii <eliz@gnu.org>
2703
2704 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
2705
7f203aa1
EZ
27062013-06-03 Eli Zaretskii <eliz@gnu.org>
2707
9337e206
EZ
2708 * w32console.c (initialize_w32_display): Return the dimensions of
2709 the console window via 2 additional arguments, not via the current
2710 frame. This avoids crashes due to overrunning the bounds of
2711 frame's decode_mode_spec_buffer, which is not resized following
2712 the change of the frame dimensions from the initial 10x10.
2713
2714 * w32term.h (w32_initialize_display_info): Adjust prototype.
2715
2716 * term.c (init_tty): Take dimensions of the frame from the values
2717 returned by initialize_w32_display.
2718
7f203aa1
EZ
2719 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
2720 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
2721 (LIBES): Add $(GFILENOTIFY_LIBS).
2722
2723 * w32inevt.c (handle_file_notifications): Add dummy implementation
2724 for !HAVE_W32NOTIFY.
2725
2726 * w32term.c: Wrap code with HAVE_W32NOTIFY.
2727
55a87246
JD
27282013-06-03 Jan Djärv <jan.h.d@swipnet.se>
2729
2730 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
2731
2732 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
2733
2734 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
2735
3d5ee10a
PE
27362013-06-03 Paul Eggert <eggert@cs.ucla.edu>
2737
2738 Fix minor problems found by static checking.
2739 * data.c (pure_write_error):
2740 Use xsignal2, not Fsignal, as Fsignal might return.
2741 * eval.c (set_backtrace_debug_on_exit): Now static.
2742 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
2743 No longer inline. EXTERN_INLINE is needed only for functions
2744 defined in .h files. Reindent function header as per GNU style.
2745 (backtrace_p, backtrace_top, backtrace_next):
2746 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
2747 compiler or linker. Add extern decls to pacify gcc -Wall.
2748 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
2749 Now static.
2750 * frame.c (free_monitors): Define only on platforms that need it.
2751 * nsterm.m (ns_term_init):
2752 * process.c (catch_child_signal):
2753 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
2754 defined on all porting targets these days.
2755 * process.c, process.h (catch_child_signal):
2756 Make it extern only if NS_IMPL_GNUSTEP is defined.
2757
e2d8a6f0
EZ
27582013-06-03 Eli Zaretskii <eliz@gnu.org>
2759
2760 * w32.c (gettimeofday): Make the signature identical to prototype
2761 in nt/inc/sys/time.h.
2762
a8a7c5f6
SM
27632013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
2764
2765 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
2766 .gdbinit.
2767
2768 * keyboard.c (safe_run_hooks_error): Improve error message.
2769
2770 * data.c (pure_write_error): Add `object' argument.
2771 * puresize.h (CHECK_IMPURE): Use it.
2772
c9628c79
MA
27732013-06-03 Michael Albinus <michael.albinus@gmx.de>
2774
2775 * Makefile.in (NOTIFY_OBJ): New variable.
2776 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
2777
2778 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
2779 Call syms_of_gfilenotify.
2780
2781 * gfilenotify.c: New file.
2782
2783 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
2784 and Qfile_w32notify.
2785 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
2786 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
2787
2788 * lisp.h: Declare syms_of_gfilenotify.
2789
2790 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
2791
2f592f95
SM
27922013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
2793
2794 Merge the specpdl and backtrace stacks. Make the structure of the
2795 specpdl entries more obvious via a tagged union of structs.
2796 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
2797 (enum specbind_tag): New enum.
2798 (struct specbinding): Make it a tagged union of structs.
2799 Add a case for backtrace records.
2800 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
2801 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
2802 (backtrace_debug_on_exit): New accessors.
2803 (struct backtrace): Remove.
2804 (struct catchtag): Remove backlist field.
2805 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2806 Move to eval.c.
2807 (Flocal_variable_p): Speed up the common case where the binding is
2808 already loaded.
2809 * eval.c (backtrace_list): Remove.
2810 (set_specpdl_symbol, set_specpdl_old_value): Remove.
2811 (set_backtrace_args, set_backtrace_nargs)
2812 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
2813 (backtrace_next): New functions.
2814 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
2815 (unwind_to_catch, internal_lisp_condition_case)
2816 (internal_condition_case, internal_condition_case_1)
2817 (internal_condition_case_2, internal_condition_case_n): Don't bother
2818 with backtrace_list any more.
2819 (Fsignal): Adjust to new backtrace format.
2820 (grow_specpdl): Move up.
2821 (record_in_backtrace): New function.
2822 (eval_sub, Ffuncall): Use it.
2823 (apply_lambda): Adjust to new backtrace format.
2824 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
2825 data.c.
2826 (specbind): Adjust to new specpdl format. Simplify.
2827 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
2828 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
2829 backtrace format.
2830 (mark_backtrace): Remove.
2831 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
2832 * xdisp.c (redisplay_internal): Use record_in_backtrace.
2833 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
2834 Use mark_specpdl.
2835 * profiler.c (record_backtrace): Use get_backtrace.
2836 (handle_profiler_signal): Use backtrace_top_function.
2837 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
2838 accessor functions.
2839
c0342369
JD
28402013-06-02 Jan Djärv <jan.h.d@swipnet.se>
2841
2842 * process.h (catch_child_signal): Declare.
2843
2844 * process.c (catch_child_signal): New function.
2845 (init_process_emacs): Call it.
2846
2847 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
2848 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
2849 NS_IMPL_COCOA.
2850 (x_set_cursor_type): Remove declaration.
2851 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
2852 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
2853 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
2854 (ns_get_color): Use F suffix on float.
2855 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
2856 (ns_get_rgb_color): Remove.
2857 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
2858 (note_mouse_movement): x and y are CGFloat.
2859 (ns_draw_fringe_bitmap): Remove unused rowY.
2860 Change #if to COCOA && >= 10_6.
2861 (ns_draw_window_cursor): Remove unused overspill.
2862 (ns_draw_underwave): width and x are EamcsCGFloat.
2863 (ns_draw_box): thickness is CGFloat.
2864 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
2865 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
2866 if not in main thread.
2867 (ns_get_pending_menu_title, ns_check_menu_open)
2868 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
2869 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
2870 (sendFromMainThread:): New method.
2871 (changeFont:): size is CGFloat.
2872 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
2873 Disable warning about permanent text.
2874 (characterIndexForPoint:): Adjust return type depending on GNUStep
2875 version.
2876 (mouseDown:): delta is CGFloat.
2877 (updateFrameSize): Remove unised variable f.
2878 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
2879 Cast float to EmacsCGFloat.
2880 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
2881 also to -1 when restoring.
2882 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
2883 inside NS_IMPL_COCOA.
2884 (toggleFullScreen:): Put call to toggleFullScreen inside
2885 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
2886 (setPosition:portion:whole:): por is CGFloat.
2887 (getMouseMotionPart:window:x:y:): Add F suffix to float.
2888 (mouseDown:): Use CGFloat.
2889 (mouseDragged:): Remove unised variable edge.
2890 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
2891
2892 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
2893 of CGFloat differs.
2894 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
2895 when NS_IMPL_GNUSTEP.
2896 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
2897 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
2898 (EmacsToolbar): Add clearAll. Add tag argument to
2899 addDisplayItemWithImage.
2900 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
2901
2902 * nsselect.m (ns_get_local_selection): Remove unused variable type.
2903
2904 * nsmenu.m (ns_update_menubar): Make static.
2905 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
2906 (fillWithWidgetValue:): Add cast to SEL for setAction.
2907 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
2908 (update_frame_tool_bar): Update code for GNUStep.
2909 (clearAll): New method.
2910 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 2911 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 2912 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
2913 call to insertItemWithItemIdentifier.
2914 (validateVisibleItems): Fix indentation.
2915 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
2916 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
2917 UtilityWindow to aStyle, remove call to setStyleMask.
2918
2919 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
2920
2921 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
2922 (ns_charset_covers, ns_get_covering_families, nsfont_open):
2923 Use F suffix on floats.
2924 (ns_char_width): Returns CGFloat.
2925 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 2926 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
2927 DPSxshow.
2928 (ns_glyph_metrics): CGFloat instead of float.
2929
a0eb10b3
JB
2930 * nsfns.m (x_set_foreground_color, x_set_background_color):
2931 Use EmacsCGFloat.
2932 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
2933 remove unused variables.
2934 (Fns_read_file_name): Keep track if panel is for save.
2935 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 2936 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
2937 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
2938 Just return the input if GNUStep.
c0342369
JD
2939 (x_screen_planes): Remove.
2940 (Fxw_color_values): Use EmacsCGFloat
2941 (Fns_display_monitor_attributes_list): Only get screen number for
2942 Cocoa.
ef099a94 2943 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
2944 EmacsSavePanel.
2945 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
2946 ns_directory_from_panel.
2947
da9aff11
PE
29482013-06-01 Paul Eggert <eggert@cs.ucla.edu>
2949
2950 * process.c (handle_child_signal): Also use WCONTINUED.
2951 This is so that list-processes doesn't mistakenly list the process
2952 as stopped, when the process has actually been continued and is
2953 now running.
2954
0e64479a
PE
29552013-05-31 Paul Eggert <eggert@cs.ucla.edu>
2956
fc186a96
PE
2957 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
2958 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
2959 not already configured.
2960
0e64479a
PE
2961 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
2962
38b787fa
EZ
29632013-05-29 Eli Zaretskii <eliz@gnu.org>
2964
2965 * Makefile.in (mostlyclean): Remove *.res files.
2966
22513e52
SM
29672013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
2968
2969 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
2970 a buffer (bug#8447).
2971
6ef3db10
EZ
29722013-05-27 Eli Zaretskii <eliz@gnu.org>
2973
2974 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
2975 display vector, and we backtrack, handle the case that the
2976 previous character position is also displayed from a display
2977 vector or covered by a display string or image. (Bug#14476)
2978
6799bb26
JD
29792013-05-25 Jan Djärv <jan.h.d@swipnet.se>
2980
2981 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
2982 (struct MonitorInfo, free_monitors): Remove.
2983 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
2984 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
2985 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
2986 Qframes, Qsource.
2987
2988 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
2989 (struct MonitorInfo, free_monitors): Remove.
2990 (ns_screen_name): Make static.
2991 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
2992 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
2993 Qframes, Qsource.
2994
2995 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
2996 (struct MonitorInfo): New struct.
2997 (free_monitors, make_monitor_attribute_list): Declare.
2998
22513e52
SM
2999 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
3000 New Lisp_Object:s.
6799bb26
JD
3001 (free_monitors, make_monitor_attribute_list): New functions.
3002 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
3003 Qsource.
3004
38cd43eb
XF
30052013-05-25 Xue Fuqiao <xfq.free@gmail.com>
3006
3007 * callproc.c (call_process): Refine the doc string. (Bug#14045)
3008
2af0948d
SM
30092013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
3010
a7eb9b0f
SM
3011 * keyboard.c: Apply keyboard decoding only to events that come directly
3012 from the tty, not from unread-command-events (bug#14368).
3013 (read_event_from_main_queue): New function, extracted from read_char).
3014 (read_decoded_char): Remove.
3015 (read_decoded_event_from_main_queue): New function to replace it.
3016 (read_char): Use it.
3017 (read_key_sequence): Use read_char rather than read_decoded_char.
3018
2af0948d
SM
3019 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
3020
1413e9a5
BR
30212013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
3022
3023 * casetab.c (init_casetab_once): Fix last change (bug#14424).
3024
e6d2f155
KH
30252013-05-22 Kenichi Handa <handa@gnu.org>
3026
3027 The following changes are to fix the setting of
3028 buffer-file-coding-system on, for instance, C-x RET c unix RET
3029 _FILE_OF_DOS_EOL_TYPE_ RET.
3030
3031 * coding.h (struct coding_system): New member detected_utf8_chars.
3032
3033 * coding.c (detect_coding_utf_8): Count characters and check EOL
3034 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
3035 BOM is there.
3036 (setup_coding_system): Do not initialize coding->head_ascii.
3037 (check_ascii): Do not set coding->eol_seen but update it. Do not
3038 call adjust_coding_eol_type here.
1413e9a5
BR
3039 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
3040 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
3041 of the found coding-system.
3042 (decode_coding_gap): Cancel previous change. Utilize the
3043 character numbers counted by detect_coding_utf_8. Fix detection
3044 of BOM for utf-8.
3045
ab56a6f4 30462013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
3047
3048 * search.c (looking_at_1): Only set last_thing_searched if the match
3049 changed the match-data (bug#14281).
3050
ecc3c6ed
DA
30512013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
3052
3053 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 3054 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
3055 (move_it_vertically_backward): Likewise.
3056
5ba8bf35
YM
30572013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3058
3059 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 3060 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
3061 (Fx_display_mm_width, Fx_display_mm_height):
3062 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 3063
91e8418b 3064 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 3065 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
3066 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
3067 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
3068 (Fx_display_backing_store, Fx_display_visual_class)
3069 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
3070 (Fx_display_grayscale_p, Fx_display_pixel_width)
3071 (Fx_display_pixel_height, Fx_display_planes)
3072 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
3073 (Fx_display_screens): Don't confuse X11 screens with NS screens.
3074 (Fx_display_mm_width, Fx_display_mm_height)
3075 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
3076 height for all physical monitors as in X11.
3077
fc30d803
SM
3078 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
3079 Return pixel width or height for all physical monitors as in X11.
91e8418b 3080
31ff141c
PE
30812013-05-18 Paul Eggert <eggert@cs.ucla.edu>
3082
3083 Port --enable-gcc-warnings to clang.
3084 * bytecode.c (exec_byte_code):
3085 * regex.c:
3086 Redo diagnostic pragmas to pacify clang, too.
3087 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
3088 * editfns.c (Fencode_time):
3089 * fileio.c (file_accessible_directory_p):
3090 * font.c (font_unparse_xlfd):
3091 Use '&"string"[index]' instead of '"string" + (index)'.
3092 * undo.c (user_error): Remove; unused.
3093
df065a0b
EZ
30942013-05-16 Eli Zaretskii <eliz@gnu.org>
3095
04d360e7
EZ
3096 * insdel.c (insert_1_both): Document the arguments, instead of
3097 referring to insert_1, which no longer exists.
3098
5bb98290
EZ
3099 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
3100 some window, increment windows_or_buffers_changed, so that
3101 *Messages* display in that window is updated. (Bug#14408)
3102
df065a0b
EZ
3103 * w32.c: Include epaths.h.
3104 (init_environment): Use cmdproxy.exe without leading directories.
3105 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
3106 case.
3107 (gettimeofday): Adjust signature and return value to Posix
3108 expectations.
3109
3110 * unexw32.c (open_output_file): Delete the existing emacs.exe
3111 before creating it, to break the hard link to the versioned
3112 executable.
3113
3114 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
3115 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
3116 (FIRSTFILE_OBJ): New variables.
3117 (W32_RES): Rename to EMACSRES. All users changed.
3118 (base_obj): Use $(CM_OBJ).
3119 (ALLOBJS): Use $(FIRSTFILE_OBJ).
3120 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
3121 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
3122 $(W32_RES_LINK) before $(LIBES).
3123 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
3124
1aa8d505
SM
31252013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3126
6e911150
SM
3127 * makefile.w32-in (DOC): Use just "DOC".
3128
3129 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
3130
1aa8d505
SM
3131 * process.c: Export default filters and sentinels to Elisp.
3132 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
3133 New constants.
3134 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
3135 (Fset_process_sentinel, Fformat_network_address):
3136 Default to them instead of nil.
3137 (server_accept_connection): Sentinels can't be nil any more.
3138 (read_and_dispose_of_process_output): New function, extracted from
3139 read_process_output.
3140 (read_process_output): Use it; filters can't be nil.
3141 (Finternal_default_process_filter): New function, extracted from
3142 read_process_output.
3143 (exec_sentinel_unwind): Remove function.
3144 (exec_sentinel): Don't zilch sentinel while running.
3145 (status_notify): Sentinels can't be nil.
3146 (Finternal_default_process_sentinel): New function extracted from
3147 status_notify.
3148 (setup_process_coding_systems): Default filter is not nil any more.
3149 (syms_of_process): Export new Elisp functions and initialize
3150 new constants.
3151 * lisp.h (make_lisp_proc): New function.
3152
5ac2eb34
SM
31532013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3154
3155 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
3156
eda9c7d7
EZ
31572013-05-14 Eli Zaretskii <eliz@gnu.org>
3158
3159 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
3160 unless we know that the window w is a leaf window.
3161 Another attempt at solving bug#14062.
eda9c7d7 3162
8fdeaad5
JD
31632013-05-14 Jan Djärv <jan.h.d@swipnet.se>
3164
3165 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
3166 fdesc (Bug#14375).
3167
44aa9ee6
PE
31682013-05-12 Paul Eggert <eggert@cs.ucla.edu>
3169
3170 * image.c (gif_load): Check that subimages fit (Bug#14345).
3171
759fd763
SM
31722013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
3173
3174 * lread.c (skip_dyn_eof): New function.
3175 (read1): Use it to skip the end of a file in response to #@00.
3176
3177 * doc.c (get_doc_string): Slightly relax the sanity checking.
3178
4465bfb4
JD
31792013-05-09 Jan Djärv <jan.h.d@swipnet.se>
3180
3181 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
3182 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3183 (MonitorInfo): New struct.
3184 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
3185 (Fns_display_monitor_attributes_list): New functions.
3186 (display-usable-bounds): Remove.
3187 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
3188 Qsource.
3189
7583e2a0
PE
31902013-05-09 Paul Eggert <eggert@cs.ucla.edu>
3191
3192 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
3193 (GTK_CHECK_VERSION): New macro, if not already defined.
3194 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
3195 replaced by GTK_CHECK_VERSION.
3196
ad75d77e
PE
31972013-05-08 Paul Eggert <eggert@cs.ucla.edu>
3198
3199 * xterm.h (GTK_PREREQ): New macro.
3200 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
3201 to use this macro instead, for consistency and clarity.
3202
07525f77
EZ
32032013-05-08 Eli Zaretskii <eliz@gnu.org>
3204
3205 * xdisp.c (row_for_charpos_p): New function, with code of
3206 cursor_row_p, but accepts an additional argument CHARPOS instead
3207 of using a hardcoded PT.
3208 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
3209 (row_containing_pos): Call row_for_charpos_p instead of partially
3210 doing the same. Fixes cursor positioning under longlines-mode
3211 when longlines-show-effect includes more than one newline, when
3212 moving the cursor vertically up.
3213
d901fc8d
JB
32142013-05-08 Juanma Barranquero <lekktu@gmail.com>
3215
3216 * makefile.w32-in (ACL_H): New macro.
3217 ($(BLD)/fileio.$(O)): Update dependencies.
3218
f269bc61
PE
32192013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3220
e7b41c4c 3221 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
3222 * Makefile.in (LIB_ACL): New macro.
3223 (LIBACL_LIBS): Remove.
3224 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
3225 * fileio.c: Include <acl.h>.
3226 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
3227 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
3228 !acl_errno_valid.
3229 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
3230 it ourselves.
3231
f269bc61
PE
3232 * unexelf.c: Don't assume ElfW (Half) fits in int.
3233 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
3234 when dealing with ElfW (Half) values, since they can exceed 2**31
3235 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
3236 (entry_address): Omit unused NUM arg. All uses changed.
3237
a261c53e
JL
32382013-05-07 Juri Linkov <juri@jurta.org>
3239
3240 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
3241 to the string converted from number with `Fnumber_to_string'.
3242 (Bug#14254)
3243
2b66427d
PE
32442013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3245
3246 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
3247 This fixes a problem introduced by my previous change.
3248
15acfe41
GM
32492013-05-07 Glenn Morris <rgm@gnu.org>
3250
3251 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
3252
5ea03bf5
JD
32532013-05-07 Jan Djärv <jan.h.d@swipnet.se>
3254
3255 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
3256
e0c9d565
PE
32572013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3258
3259 Static checking by GCC 4.8.0.
3260 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
3261 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
3262 (x_get_monitor_attributes_fallback)
3263 (x_get_monitor_attributes_xinerama)
3264 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
3265 Define only if USE_GTK.
3266 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
3267 (x_get_monitor_attributes_fallback): Omit unused locals.
3268 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
3269 Use double, not float, to avoid mixed-mode floating point arithmetic.
3270
4e3f9230
YM
32712013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3272 Jan Djärv <jan.h.d@swipnet.se>
3273
3274 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
3275 (XINERAMA_CFLAGS): New macros.
3276 (ALL_CFLAGS, LIBES): Use them.
3277
3278 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
3279 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
3280 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
3281 (syms_of_xfns): DEFSYM them.
3282 (struct MonitorInfo): New struct.
3283 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
3284 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
3285 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
3286 (x_get_monitor_attributes_xinerama): New functions.
3287 (Fx_display_monitor_attributes_list): New primitive.
3288 (syms_of_xfns): Defsubr it.
3289
3290 * xterm.h (x_display_info): Add Xatom_net_workarea and
3291 Xatom_net_current_desktop.
3292
3293 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
3294 and dpyinfo->Xatom_net_current_desktop.
3295
05839b6a
EZ
32962013-05-06 Eli Zaretskii <eliz@gnu.org>
3297
3298 * xdisp.c (pos_visible_p): Use the special code for finding the
3299 beginning of a display property or overlay for any "replacing"
3300 display property, not just for display strings. This solves
3301 incorrect reporting of position by posn-at-point. (Bug#14241)
3302
dc4a2ee0
PE
33032013-05-06 Paul Eggert <eggert@cs.ucla.edu>
3304
5ee94506
PE
3305 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
3306 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
3307 Verify that ElfW (Half) fits in int.
3308 (fatal): Use same signature as lisp.h.
3309 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
3310 configure and build with -DUNEXELF_DEBUG without worrying about
3311 other modules that use DEBUG.
3312 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
3313 possibly-wide integers now uses it instead of plain fprintf.
3314 (entry_address): New function, which avoids problems with 32-bit
3315 overflow on 64-bit hosts.
3316 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
3317 (round_up): Don't assume the remainder fits in int.
3318 (find_section): Use bool for boolean. Simplify debug code.
3319 (unexec): Don't assume file sizes fit in int or size_t.
3320 Omit unnecessary trailing newline in 'fatal' format.
3321 Use strerror rather than outputting decimal error number.
3322 Remove unused code when emacs is not defined;
3323 this file relies on Emacs now.
3324 Don't assume e_phnum and e_shnum are positive.
3325
dc4a2ee0
PE
3326 * regex.c: Fix problems when DEBUG is defined.
3327 (extract_number, extract_number_and_incr): Define regardless of
3328 whether DEBUG is defined; that's simpler and makes the code less
3329 likely to go stale in the normal case when DEBUG is not defined.
3330 Return int rather than taking an int * arg. All callers changed.
3331 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
3332 Remove, replacing with ...
3333 (DEBUG_PRINT): New macro. All callers changed.
3334 (DEBUG_COMPILES_ARGUMENTS): New macro.
3335 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
3336 (print_compiled_pattern, print_double_string) [DEBUG]:
3337 Use prototype rather than old-style definition.
3338 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
3339 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
3340 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
3341 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
3342 Don't assume ptrdiff_t, size_t, and long are the same width as int.
3343 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
3344 This matters only when DEBUG is defined.
3345
14c7ed05
EZ
33462013-05-05 Eli Zaretskii <eliz@gnu.org>
3347
3348 * xdisp.c (set_iterator_to_next): Set the
3349 ignore_overlay_strings_at_pos_p flag only if we are _really_
3350 iterating over an overlay string, as indicated by the
3351 current.overlay_string_index member. (Bug#14306)
3352
e6076b1b
JD
33532013-05-05 Jan Djärv <jan.h.d@swipnet.se>
3354
3355 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
3356 to where it is used, to avoid autorelease issues (Bug#14050).
3357
cbee2131
PE
33582013-05-05 Paul Eggert <eggert@cs.ucla.edu>
3359
3360 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
3361 * fileio.c (syms_of_fileio): Implement this.
3362 * filelock.c (create_lock_file): If symbolic links don't work, so
3363 we use a regular file as a lock file, do not fsync the lock file;
3364 it's not needed.
3365
30c7e542
SM
33662013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3367
3368 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
3369 (syms_of_minibuf): Adjust accodingly.
3370 * lread.c (Fread):
3371 * callint.c (Fcall_interactively): Adjust calls accordingly.
3372
5bebd186
EZ
33732013-05-04 Eli Zaretskii <eliz@gnu.org>
3374
3375 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
3376 w->contents is a buffer before computing everything else.
3377 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
3378
3379 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
3380 assertion violations. (Bug#14062)
3381
0fb0a4f3
DR
33822013-05-01 David Reitter <david.reitter@gmail.com>
3383
3384 * nsfns.m (ns_tooltip): Initialize.
3385
9e63b4a5
EZ
33862013-04-28 Eli Zaretskii <eliz@gnu.org>
3387
3388 * coding.c (decode_coding_gap): Don't remove the character before
3389 a newline unless it's a CR character. (Bug#14287)
3390
ad60824e
DN
33912013-04-28 Dan Nicolaescu <dann@gnu.org>
3392
3393 * dispextern.h (struct face): Move enum face_underline_type
3394 earlier so that bitfields can be in the same word.
3395
edbdcec0
JD
33962013-04-28 Jan Djärv <jan.h.d@swipnet.se>
3397
3398 * nsfns.m (handlePanelKeys): New function.
3399 (EmacsOpenPanel:performKeyEquivalent:)
3400 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
3401 arrows/function/control and copy/paste keys (Bug#14296).
3402
0208ede7
JL
34032013-04-27 Juri Linkov <juri@jurta.org>
3404
3405 * callint.c (Fcall_interactively): Call `Qread_number' for
3406 interactive code letter `n' instead of using duplicate code.
3407 (Bug#14254)
3408
b8dd59f7
PE
34092013-04-27 Paul Eggert <eggert@cs.ucla.edu>
3410
3411 * systime.h (make_timeval): Declare as 'const'.
3412
8bd722db
KH
34132013-04-27 Kenichi Handa <handa@gnu.org>
3414
3415 * font.c (font_open_entity): Always open a font of manageable
3416 size.
3417
13d0e56f 34182013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 3419
f780d632
PE
3420 Port better to AIX (Bug#14258).
3421 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
3422 to pacify AIX xlc.
3423
ec509856
KH
34242013-04-24 Kenichi Handa <handa@gnu.org>
3425
3426 * coding.c (decode_coding_iso_2022): When an invalid escape
3427 sequence is encountered, reset the invocation and designation
3428 status to the safest one.
3429
84fc48e5
PE
34302013-04-22 Paul Eggert <eggert@cs.ucla.edu>
3431
3432 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
3433 Without this fix, "make distclean" leaves stamp-h1 behind.
3434
806bda47
EC
34352013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
3436
3437 * w32fns.c (w32_fullscreen_rect): New function to compute the
3438 window rectangle for the given fullscreen mode.
3439 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
3440 longer tunes the window size. This keeps the window's edges flush
3441 with the screen and allows the taskbar to hide itself in fullboth.
3442
3443 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
3444 window decorations and uses the entire screen.
3445
3446 * w32term.h (w32_fullscreen_rect) Add prototype.
3447 (struct w32_output): Replace normal_width, normal_height,
3448 normal_top, and normal_left members with a single normal_placement
3449 struct.
3450 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
3451 Remove macros.
3452 (FRAME_NORMAL_PLACEMENT): New macro.
3453
9cc2810b
JB
34542013-04-16 Juanma Barranquero <lekktu@gmail.com>
3455
3456 * minibuf.c (Ftest_completion): Silence compiler warning.
3457
fd16b54c
EZ
34582013-04-15 Eli Zaretskii <eliz@gnu.org>
3459
3460 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 3461 bug#14062.
fd16b54c
EZ
3462
3463 * frame.h (WINDOW_FRAME): Protect macro and its argument with
3464 parentheses.
3465
3466 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
3467 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
3468 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
3469 parentheses where appropriate.
3470
9e3379a0
PE
34712013-04-14 Paul Eggert <eggert@cs.ucla.edu>
3472
3473 * keyboard.c (timer_start_idle): Remove no-longer-used local.
3474
ddd6b685
EZ
34752013-04-14 Eli Zaretskii <eliz@gnu.org>
3476
3477 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
3478 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
3479 Mention in the doc string that setting these variables takes
3480 effect only after a call to set-window-buffer. (Bug#14200)
3481
29b79ba1
EZ
34822013-04-13 Eli Zaretskii <eliz@gnu.org>
3483
3484 * indent.c (Fvertical_motion): Don't consider display strings on
3485 overlay strings as display strings on the buffer position we
3486 started from. This prevents vertical cursor motion from jumping
3487 more than one line when there's an overlay string with a display
3488 property at end of line.
3489 Reported by Karl Chen <Karl.Chen@quarl.org> in
3490 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
3491
562c6ee9
SM
34922013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
3493
3494 * window.c (select_window): `record_buffer' even if window is
3495 already selected (bug#14191).
3496
fcc1fe85
EZ
34972013-04-11 Eli Zaretskii <eliz@gnu.org>
3498
3499 * window.c (Fwindow_end): Test more flags, including the buffer's
3500 last_overlay_modified flag, to determine whether the window's
3501 display is really up-to-date. Prevents the function from
3502 returning a stale value. (Bug#14170)
3503 (Fwindow_line_height): Fix the test for up-to-date-ness of the
3504 current matrix.
3505
f009190a
EZ
35062013-04-10 Eli Zaretskii <eliz@gnu.org>
3507
3508 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
3509 garbaged only if it is not already the top frame on its TTY.
3510 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
3511 there are GUI frames open in the same session. (Bug#13864)
3512
78ce603d
SM
35132013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
3514
3515 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
3516 of marking the idle timers directly.
3517
a8036e40
SM
35182013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
3519
3520 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
3521 tables (bug#14054).
3522
7ffe7ef6
SM
35232013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
3524
3525 * window.c (select_window): Don't record_buffer while the invariant is
3526 temporarily broken (bug#14161).
3527
3528 * fns.c (Fdelq): Don't assume !NILP => CONSP.
3529
7d9f6883
EZ
35302013-04-07 Eli Zaretskii <eliz@gnu.org>
3531
3532 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
3533
5406cfd9
RF
35342013-04-07 Romain Francoise <romain@orebokech.com>
3535
3536 Ignore additional platform-specific ACL errors (Bug#13702).
3537 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
3538 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
3539
95c0e83b
JD
35402013-03-31 Jan Djärv <jan.h.d@swipnet.se>
3541
3542 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
3543 f->output_data.ns.
3544
876da980
PE
35452013-04-07 Paul Eggert <eggert@cs.ucla.edu>
3546
3547 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
3548 This bug was introduced by my 2013-02-25 change that simplified
3549 data_start configuration. Without this change, on GNU/Linux
3550 an Emacs configured with --enable-profiling fails immediately
3551 due to a profiler signal.
3552 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
3553 with these flags. On platforms where special flags are needed
3554 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
3555 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
3556 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
3557
7452b7bd
DA
35582013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
3559
3560 Get rid of some platform-specific functions examining window
3561 system and its capabilities. This is a partial rework of the
3562 2013-04-05 change.
3563 * lisp.h (have_menus_p): Remove prototype. This function is
3564 replaced with platform-independent window_system_available.
3565 (check_window_system): Move to...
3566 * frame.h (decode_window_system_frame, window_system_available):
3567 ...here, add new prototypes.
3568 * frame.c (window_system_available, decode_window_system_frame):
3569 New functions.
3570 (check_window_system): Platform-independent now.
3571 * xterm.h (x_in_use): Remove declaration.
3572 (check_x_frame):
3573 * w32term.h (check_x_frame):
3574 * nsterm.h (check_x_frame): Remove prototypes. This function
3575 is replaced with platform-independent decode_window_system_frame.
3576 * msdos.c (have_menus_p): Remove.
3577 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
3578 Remove platform-specific functions. Use check_window_system,
3579 decode_window_system_frame and check_ns_display_info where
3580 appropriate. Minor style and comment tweaks.
3581 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
3582 (check_x_frame): Likewise.
3583 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
3584 Likewise.
3585 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
3586 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
3587 * xmenu.c, xselect.c: All related users changed.
3588
251e9147
KH
35892013-04-03 Kenichi Handa <handa@gnu.org>
3590
3591 The following changes is to optimize the code for reading UTF-8
3592 files.
3593
562c6ee9 3594 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
3595 changed. Check EOL format. Do not call adjust_coding_eol_type
3596 here.
3597 (check_utf_8): New function.
3598 (adjust_coding_eol_type): Do nothing if already adjusted.
3599 (detect_coding): Compare the return value of check_ascii with
3600 coding->src_bytes. Call adjust_coding_eol_type if necessary.
3601 (decode_coding_gap): Optimize for valid UTF-8.
3602
8bc369d4
KH
36032013-03-21 Kenichi Handa <handa@gnu.org>
3604
3605 * coding.c (syms_of_coding): Cancel previous change.
3606
3607 * insdel.c (insert_from_gap): Fix previous change.
3608
73931ad1
DA
36092013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
3610
3611 Consistently use platform-specific function to detect window system.
3612 * lisp.h (check_window_system): New prototype. This function is
3613 going to replace check_x, check_w32 and check_ns.
3614 (have_menus_p): Mention msdos.c in comment.
3615 * fontset.c (check_window_system_func): Remove. Adjust all users.
3616 * fontset.h (check_window_system_func): Remove prototype.
3617 * nsterm.h (check_ns):
3618 * xterm.h (check_x):
3619 * w32term.h (check_w32): Likewise.
3620 * menu.c (Fx_popup_menu): Use check_window_system.
3621 * msdos.c (check_window_system): Define for MS-DOS.
3622 * nsfns.m (check_window_system): Define for NS. Adjust all users.
3623 * w32fns.c (check_window_system): Likewise for MS-Windows.
3624 * xfns.c (check_window_system): Likewise for X.
3625 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
3626 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
3627
7216e43b
PE
36282013-04-02 Paul Eggert <eggert@cs.ucla.edu>
3629
3630 Prefer < to > in range checks such as 0 <= i && i < N.
3631 This makes it easier to visualize quantities on a number line.
3632 This patch doesn't apply to all such range checks,
3633 only to the range checks affected by the 2013-03-24 change.
3634 This patch reverts most of the 2013-03-24 change.
3635 * alloc.c (xpalloc, Fgarbage_collect):
3636 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
3637 * character.c (string_escape_byte8):
3638 * charset.c (read_hex):
3639 * data.c (cons_to_unsigned):
3640 * dispnew.c (update_frame_1):
3641 * doc.c (Fsubstitute_command_keys):
3642 * doprnt.c (doprnt):
3643 * editfns.c (hi_time, decode_time_components):
3644 * fileio.c (file_offset):
3645 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
3646 * font.c (font_intern_prop):
3647 * frame.c (x_set_alpha):
3648 * gtkutil.c (get_utf8_string):
3649 * indent.c (check_display_width):
3650 * keymap.c (Fkey_description):
3651 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
3652 * lread.c (read1):
3653 * minibuf.c (read_minibuf_noninteractive):
3654 * process.c (wait_reading_process_output):
3655 * search.c (Freplace_match):
3656 * window.c (get_phys_cursor_glyph):
3657 * xdisp.c (redisplay_internal):
3658 * xsmfns.c (smc_save_yourself_CB):
3659 Prefer < to > for range checks.
3660 * dispnew.c (sit_for): Don't mishandle NaNs.
3661 This fixes a bug introduced in the 2013-03-24 change.
3662 * editfns.c (decode_time_components): Don't hoist comparison.
3663 This fixes another bug introduced in the 2013-03-24 change.
3664
92759988
DA
36652013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
3666
3667 * frame.h (struct frame): Drop scroll_bottom_vpos
3668 member becaue all real users are dead long ago.
3669 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
3670 * xdisp.c (redisplay_internal): Adjust user.
3671
9a1971bb
GM
36722013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
3673
f38ab167
JD
3674 * nsmenu.m (showAtX:Y:for:): setLevel to
3675 NSPopUpMenuWindowLevel (Bug#13998).
3676
6d01f1fe
JD
36772013-03-30 Jan Djärv <jan.h.d@swipnet.se>
3678
3679 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
3680 (ns_check_pending_open_menu): Declare.
3681
3682 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
3683 (x_activate_menubar): Update the menu with title that matches
3684 ns_get_pending_menu_title, and call
3685 ns_check_pending_openmenu (Bug#12698).
3686 (menuWillOpen:): New method.
3687 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
3688
3689 * nsterm.m (menu_will_open_state, menu_mouse_point)
3690 (menu_pending_title): New varaibles.
3691 (ns_get_pending_menu_title, ns_check_menu_open)
3692 (ns_check_pending_open_menu): New functions.
3693
781f4782
DA
36942013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
3695
3696 * indent.c (current_column_bol_cache): Remove leftover which is not
3697 used in Fmove_to_column any more.
3698 (current_column, scan_for_column): Adjust users.
3699 * keyboard.c (last_point_position_buffer, last_point_position_window):
3700 Remove leftovers which are not used for recording undo any more.
3701 (command_loop_1, syms_of_keyboard): Adjust users.
3702 * xdisp.c (last_max_ascent): Remove leftover which is not used in
3703 redisplay_window any more.
3704 (move_it_to): Adjust user.
3705
1921c31b
JB
37062013-03-29 Juanma Barranquero <lekktu@gmail.com>
3707
3708 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
3709 Update dependencies.
3710
717b8bcd
SM
37112013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3712
3713 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
3714 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
3715 forward references.
3716
e74aeda8
DA
37172013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
3718
3719 * window.h (struct window): Replace hchild, vchild and buffer slots
3720 with the only contents slot. This is possible because each valid
3721 window may have either the child window (in vertical or horizontal
3722 combination) or buffer to display (for the leaf window). Using that,
3723 a lof of operations to traverse and/or change window hierarchies may
3724 be simplified. New member horizontal is used to distinguish between
3725 horizontal and vertical combinations of internal windows.
3726 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
3727 (WINDOW_VERTICAL_COMBINATION_P): New macros.
3728 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
3729 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
3730 Use contents slot, not buffer, where appropriate.
3731 (wset_combination): New function.
3732 (wset_buffer): Add eassert.
3733 (Fframe_first_window): Simplify the loop reaching first window.
3734 (Fwindow_buffer): Use WINDOW_LEAF_P.
3735 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
3736 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
3737 (unshow_buffer): Convert initial debugging check to eassert.
3738 (replace_window, recombine_windows, Fdelete_other_windows_internal)
3739 (make_parent_window, window_resize_check, window_resize_apply)
3740 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
3741 (Fset_window_configuration, delete_all_child_windows, save_window_save):
3742 Adjust to match struct window changes.
3743 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
3744 (mark_window_cursors_off, count_windows, get_leaf_windows)
3745 (foreach_window_1): Simplify the loop.
3746 * alloc.c (mark_object): Do not check for the leaf window because
3747 internal windows has no glyph matrices anyway.
3748 * dispnew.c (clear_window_matrices, showing_window_margins_p)
3749 (allocate_matrices_for_window_redisplay, fake_current_matrices)
3750 (allocate_matrices_for_frame_redisplay, free_window_matrices)
3751 (build_frame_matrix_from_window_tree, mirror_make_current)
3752 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
3753 (update_window_tree, set_window_update_flags): Simplify the loop.
3754 (sync_window_with_frame_matrix_rows): Enforce live window.
3755 Use contents slot, not buffer, where appropriate.
3756 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
3757 and WINDOW_HORIZONTAL_COMBINATION_P.
3758 (make_frame_visible_1): Simplify the loop.
3759 Use contents slot, not buffer, where appropriate.
3760 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
3761 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
3762 (expose_window_tree): Likewise.
3763 Use contents slot, not buffer, where appropriate.
3764 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
3765 to avoid deleted windows. Use contents slot instead of buffer.
3766 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
3767 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
3768 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
3769 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
3770
121ab1cd
EZ
37712013-03-28 Eli Zaretskii <eliz@gnu.org>
3772
ef454cf7
EZ
3773 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
3774 identify the reasons for assertion violations in bug#14062 and
3775 similar ones.
21e930f8
EZ
3776 (Fx_show_tip): Fix compilation error under
3777 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 3778
121ab1cd
EZ
3779 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
3780 Reported by <rzl24ozi@gmail.com>.
3781
5c89ca24
DA
37822013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
3783
3784 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
3785 start marker...
562c6ee9
SM
3786 (unwind_with_echo_area_buffer): ...to restore it here.
3787 This is needed to ensure that...
5c89ca24
DA
3788 (redisplay_window): ...both window markers are valid here,
3789 which is verified by eassert.
3790 * editfns.c (save_excursion_save): Do not assume that
3791 selected_window always displays the buffer.
c7f53895
DA
3792 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
3793 Fix comment.
5c89ca24 3794
f557c1b1
SM
37952013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
3796
3797 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
3798 the upcase table.
3799
40693bba 38002013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
3801
3802 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
3803
c86f791f
EZ
38042013-03-27 Eli Zaretskii <eliz@gnu.org>
3805
3806 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
3807 since MinGW's w32api headers do. This avoids compiler warnings.
3808
3809 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
3810 if already defined.
3811
c6e72e17
EZ
38122013-03-26 Eli Zaretskii <eliz@gnu.org>
3813
3814 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
3815
54e95010
JD
38162013-03-26 Jan Djärv <jan.h.d@swipnet.se>
3817
3818 * gtkutil.c (style_changed_cb): Check if frame is live and an
3819 X frame (Bug#14038).
3820
b88b62de
EZ
38212013-03-26 Eli Zaretskii <eliz@gnu.org>
3822
a18d7de6
EZ
3823 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
3824 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
3825 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
3826 MinGW64.
8f5e14c8
EZ
3827 Move inclusion of time.h before sys/time.h, so that MinGW64 could
3828 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 3829
b88b62de
EZ
3830 Fix incompatibilities between MinGW.org and MinGW64 headers.
3831 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
3832
3833 * w32.c (REPARSE_DATA_BUFFER): Guard with
3834 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
3835
c074e458
JD
38362013-03-25 Jan Djärv <jan.h.d@swipnet.se>
3837
3838 * xterm.c: Include X11/XKBlib.h
3839 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
3840
908589fd
AS
38412013-03-24 Andreas Schwab <schwab@linux-m68k.org>
3842
3843 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
3844 written backwards.
3845 * blockinput.h (input_blocked_p): Likewise.
3846 * bytecode.c (exec_byte_code): Likewise.
3847 * callproc.c (call_process_kill, call_process_cleanup)
3848 (Fcall_process): Likewise.
3849 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
3850 (Fccl_execute_on_string): Likewise.
3851 * character.c (string_escape_byte8): Likewise.
3852 * charset.c (read_hex): Likewise.
3853 * cm.c (calccost): Likewise.
3854 * data.c (cons_to_unsigned): Likewise.
3855 * dired.c (directory_files_internal, file_name_completion):
3856 Likewise.
3857 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
3858 (sit_for): Likewise.
3859 * doc.c (Fsubstitute_command_keys): Likewise.
3860 * doprnt.c (doprnt): Likewise.
3861 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
3862 * emacsgtkfixed.c: Likewise.
3863 * fileio.c (file_offset, Fwrite_region): Likewise.
3864 * floatfns.c (Fexpt, fmod_float): Likewise.
3865 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
3866 Likewise.
3867 * font.c (font_intern_prop): Likewise.
3868 * frame.c (x_set_alpha): Likewise.
3869 * gtkutil.c (get_utf8_string): Likewise.
3870 * indent.c (check_display_width): Likewise.
3871 * intervals.c (create_root_interval, rotate_right, rotate_left)
3872 (split_interval_right, split_interval_left)
3873 (adjust_intervals_for_insertion, delete_node)
3874 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3875 (merge_interval_right, merge_interval_left, copy_intervals)
3876 (set_intervals_multibyte_1): Likewise.
3877 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
3878 * keymap.c (Fkey_description): Likewise.
3879 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
3880 * lread.c (openp, read_integer, read1, string_to_number):
3881 Likewise.
3882 * menu.c (ensure_menu_items): Likewise.
3883 * minibuf.c (read_minibuf_noninteractive): Likewise.
3884 * print.c (printchar, strout): Likewise.
3885 * process.c (create_process, Faccept_process_output)
3886 (wait_reading_process_output, read_process_output, send_process)
3887 (wait_reading_process_output): Likewise.
3888 * profiler.c (make_log, handle_profiler_signal): Likewise.
3889 * regex.c (re_exec): Likewise.
3890 * regex.h: Likewise.
3891 * search.c (looking_at_1, Freplace_match): Likewise.
3892 * sysdep.c (get_child_status, procfs_ttyname)
3893 (procfs_get_total_memory): Likewise.
3894 * systime.h (EMACS_TIME_VALID_P): Likewise.
3895 * term.c (dissociate_if_controlling_tty): Likewise.
3896 * window.c (get_phys_cursor_glyph): Likewise.
3897 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
3898 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
3899 Likewise.
3900 * xfns.c (Fx_window_property): Likewise.
3901 * xmenu.c (set_frame_menubar): Likewise.
3902 * xselect.c (x_get_window_property, x_handle_dnd_message):
3903 Likewise.
3904 * xsmfns.c (smc_save_yourself_CB): Likewise.
3905 * xterm.c (x_scroll_bar_set_handle): Likewise.
3906
2bf7d27a
DA
39072013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
3908
3909 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
3910 to be optional or nil. Adjust comment and convert it to docstring.
3911 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
3912 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
3913
a9ebfa0b
PE
39142013-03-24 Paul Eggert <eggert@cs.ucla.edu>
3915
3916 Static checking by GCC 4.8-20130319.
3917 * image.c (gif_load): Assume pass < 3 to pacify GCC.
3918 * process.c (Fset_process_datagram_address)
3919 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
3920 * xdisp.c (get_char_face_and_encoding):
3921 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
3922 (get_glyph_face_and_encoding): Prepare face before possibly using it.
3923 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
3924
4f3576ee
KB
39252013-03-24 Ken Brown <kbrown@cornell.edu>
3926
789b5e9a
KB
3927 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
3928 fix compilation on 64-bit Cygwin, where underscores are not
3929 automatically prepended.
3930
4f3576ee
KB
3931 * w32term.c (w32_initialize): Silence compiler warning.
3932
b5b7745f
EZ
39332013-03-23 Eli Zaretskii <eliz@gnu.org>
3934
cdc0d0bd
EZ
3935 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
3936 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
3937 variables, to save and restore frame dimensions.
3938 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
3939 after returning from a 'fullscreen' configuration.
3940 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
3941 to avoid races between the main thread and the input thread.
3942
3943 * w32term.h (struct w32_output): New members normal_width,
3944 normal_height, normal_top, normal_left, and prev_fsmode.
3945 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
3946 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
3947 members of a frame.
3948
b5b7745f
EZ
3949 * w32term.c (w32fullscreen_hook): Record last value of the frame's
3950 'fullscreen' parameter. Always record previous width and height
3951 of the frame, except when switching out of maximized modes, so
3952 that they could be restored correctly, instead of resetting to the
3953 default frame dimensions. Send SC_RESTORE command to the frame,
3954 unless we are going to send SC_MAXIMIZE, to restore the frame
3955 resize hints in the mouse pointer shown by the window manager.
3956 (Bug#14032)
3957
3958 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
3959
3960 * lisp.h (get_frame_param): Adjust conditions for prototype
3961 declaration.
3962
a3454eed
KB
39632013-03-22 Ken Brown <kbrown@cornell.edu>
3964
3965 * unexcw.c: Drop unneeded inclusion of w32common.h.
3966 (report_sheap_usage): Declare.
3967 (read_exe_header): Add magic numbers for x86_64.
3968 (fixup_executable): Fix printf format specifier for unsigned long
3969 argument.
3970
5a49b79c
DA
39712013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
3972
3973 * frame.h (struct frame): Put menu_bar_window under #ifdef
3974 because this member is not needed when X toolkit is in use.
3975 (fset_menu_bar_window):
3976 * dispnew.c (clear_current_matrices, clear_desired_matrices)
3977 (free_glyphs, update_frame):
3978 * xdisp.c (expose_frame): Likewise.
3979 (display_menu_bar): Likewise. Remove redundant eassert.
3980 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
3981 toolkit is in use.
3982
d6723bf7
PE
39832013-03-21 Paul Eggert <eggert@cs.ucla.edu>
3984
7b1123d8
PE
3985 Use functions and constants to manipulate Lisp_Save_Value objects.
3986 This replaces code that used macros and strings and token-pasting.
3987 The change makes the C source a bit easier to follow,
3988 and shrinks the Emacs executable a bit.
3989 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
3990 (make_save_value): Change 1st arg from string to enum. All callers
3991 changed.
3992 (INTX): Remove.
3993 (mark_object): Use if, not #if, for GC_MARK_STACK.
3994 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
3995 (XSAVE_OBJECT): Now functions, not macros.
3996 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
3997 the constant was never used.
3998 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
3999 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
4000 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
4001 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
4002 New constants.
4003 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
4004 type3 with a single member save_type. All uses changed.
4005 (save_type, set_save_pointer, set_save_integer): New functions.
4006 * print.c (PRINTX): Remove.
4007
d6723bf7
PE
4008 * alloc.c: Remove redundant static declarations.
4009
5f24fa51
DA
40102013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4011
4012 * window.h (struct window): Convert left_col, top_line, total_lines
4013 and total_cols from Lisp_Objects to integers. Adjust comments.
4014 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
4015 Remove.
4016 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
4017 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
4018 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
4019 Adjust users where appropriate.
4020
42143acd
DA
40212013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4022
4023 * frame.h (struct frame): Drop resx and resy because the same data is
4024 available from window system-specific output context. Adjust users.
562c6ee9
SM
4025 (default_pixels_per_inch_x, default_pixels_per_inch_y):
4026 New functions to provide defaults when no window system available.
42143acd 4027 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 4028 (NUMVAL): Move from xdisp.c.
42143acd
DA
4029 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
4030 (Ffont_face_attributes, Fopen_font):
4031 * image.c (gs_load):
4032 * w32font.c (fill_in_logfont):
4033 * xdisp.c (calc_pixel_width_or_height):
4034 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
4035 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
4036
c0a17406
KH
40372013-03-20 Kenichi Handa <handa@gnu.org>
4038
4039 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
4040 to 1 (temporary workaround until a bug related to ASCII
4041 optimization is fixed).
4042
095d384d
DA
40432013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
4044
4045 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
4046 Signal error if window is not internal. Adjust docstring.
4047 (delete_all_child_windows): Use combination_limit to save the buffer.
4048 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
4049 * print.c (syms_of_print): Initialize debugging output not here...
4050 (init_print_once): ...but in a new function here.
4051 * lisp.h (init_print_once): Add prototype.
4052 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 4053
748fa866
DA
40542013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
4055
4056 * window.c (window_resize_check, window_resize_apply)
4057 (window_from_coordinates, recombine_windows, set_window_buffer)
4058 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
4059 (Fsplit_window_internal, Fdelete_window_internal)
4060 (freeze_window_starts): Use bool for booleans.
4061 * window.h (window_frame_coordinates, resize_frame_windows)
4062 (freeze_window_starts, set_window_buffer): Adjust prototypes.
4063
81519fd2
SM
40642013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
4065
4066 * dispnew.c (bitch_at_user): Use `user-error'.
4067
6db423a9
KB
40682013-03-17 Ken Brown <kbrown@cornell.edu>
4069
4070 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
4071 as return type of image_background. (Bug#13981)
4072 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
4073
8f2906f5
JD
40742013-03-16 Jan Djärv <jan.h.d@swipnet.se>
4075
960ce480 4076 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 4077 (ns_select): Don't return with result uninitialized.
960ce480 4078
8f2906f5
JD
4079 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
4080 and getDirectory.
4081
81519fd2
SM
4082 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
4083 New functions.
8f2906f5
JD
4084 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
4085 directories. If filename is nil, get directory name (Bug#13932).
4086 Use getFilename and getDirectory.
4087 (getFilename, getDirectory): New methods for EmacsSavePanel and
4088 EmacsOpenPanel.
4089 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
4090
cded56c1
PE
40912013-03-15 Paul Eggert <eggert@cs.ucla.edu>
4092
4093 * coding.c (decode_coding_gap): Fix typo caught by static checking.
4094
251e9147 40952013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
4096
4097 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
4098 (adjust_after_replace): Make it back to static. Delete the third
4099 arg text_at_gap_tail. Cancel the code for handling it.
4100
4101 * coding.h (struct coding_system): New member eol_seen.
4102
4103 * coding.c (detect_ascii): New function.
4104 (detect_coding): Set coding->head_ascii and coding->eol_seen only
4105 when the source bytes are actually scanned. On detecting for
4106 coding_category_utf_8_auto, call detect_ascii instead of scanning
4107 source bytes directly.
4108 (produce_chars): Call insert_from_gap with the new arg 0.
4109 (encode_coding): Likewise.
4110 (decode_coding_gap): Control ASCII optimization by the variable
4111 disable_ascii_optimization instead of #ifndef .. #endif.
4112 Deccode EOL format according to coding->eol_seen.
4113 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
4114 variable.
4115
8a44e6d1
KH
4116 * lisp.h (adjust_after_replace): Cancel externing it.
4117 (insert_from_gap): Adjust prototype.
4118
5f795e34
EZ
41192013-03-15 Eli Zaretskii <eliz@gnu.org>
4120
4121 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
4122 FULLSCREEN_MAXIMIZED. (Bug#13935)
4123
f258b4be
DA
41242013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
4125
4126 * region-cache.c (find_cache_boundary, move_cache_gap)
4127 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
4128 Simplify debugging check and convert to eassert. Adjust comment.
4129 (pp_cache): Put under ENABLE_CHECKING.
4130
a5cc4dde
EZ
41312013-03-14 Eli Zaretskii <eliz@gnu.org>
4132
4133 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
4134 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
4135 and WM_ACTIVATEAPP.
4136 (w32fullscreen_hook): If the frame is visible, reset
4137 f->want_fullscreen flag after changing the frame size. If the
4138 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
4139 (Bug#13953)
4140
3fc5e44a
DC
41412013-03-13 Daniel Colascione <dancol@dancol.org>
4142
4143 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
4144 too so that these builds can use Cygwin's file conversion
4145 functions. (We've been building and linking cygw32.o all along
4146 and just not using it.)
4147
47d7532e
PE
41482013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4149
4150 File synchronization fixes (Bug#13944).
4151 * Makefile.in (LIB_FDATASYNC): New macro.
4152 (LIBES): Use it.
4153 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
4154 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
4155 Don't worry about HAVE_FSYNC, since a substitute fsync is
4156 available if the system lacks one.
4157 (Fwrite_regin): Retry fsync if interrupted.
4158
c7ffccaf
EZ
41592013-03-13 Eli Zaretskii <eliz@gnu.org>
4160
4e2df81d 4161 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
4162 activated, call w32fullscreen_hook, to make sure the new frame
4163 dimensions are in effect. (Bug#13937)
4164
8a7debc1
DA
41652013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
4166
4167 * xdisp.c (init_iterator): Simplify because both character and byte
4168 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
4169 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
4170 character and byte positions can be obtained from marker.
8a7debc1 4171
7fd8c501
PE
41722013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4173
d9df6f40
PE
4174 Static checking by Sun C 5.12.
4175 * alloc.c (buffer_memory_full) [REL_ALLOC]:
4176 * bytecode.c (exec_byte_code):
4177 * dispnew.c (init_display):
4178 * eval.c (error):
4179 * fileio.c (Fsubstitute_in_file_name):
4180 * keyboard.c (Fevent_convert_list):
4181 * keymap.c (Fsingle_key_description):
4182 * term.c (maybe_fatal, fatal):
4183 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
4184 * xsmfns.c (Fhandle_save_session):
4185 Omit unreachable code.
4186 * keymap.c (map_keymap_char_table_item): Cast void * to
4187 a function pointer type; the C Standard requires this.
4188
7fd8c501
PE
4189 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
4190 Include <sys/param.h> unconditionally, as that works elsewhere and
4191 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
4192 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
4193 and FreeBSD now.
4194
a020afb9 4195See ChangeLog.12 for earlier changes.
aac0c6e3
MR
4196
4197;; Local Variables:
4198;; coding: utf-8
aac0c6e3
MR
4199;; End:
4200
ab422c4d 4201 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
4202
4203 This file is part of GNU Emacs.
4204
4205 GNU Emacs is free software: you can redistribute it and/or modify
4206 it under the terms of the GNU General Public License as published by
4207 the Free Software Foundation, either version 3 of the License, or
4208 (at your option) any later version.
4209
4210 GNU Emacs is distributed in the hope that it will be useful,
4211 but WITHOUT ANY WARRANTY; without even the implied warranty of
4212 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4213 GNU General Public License for more details.
4214
4215 You should have received a copy of the GNU General Public License
4216 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.