* minibuffer.el: Revert change from 2013-08-20.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
bfff6445
MR
12013-08-26 Martin Rudalics <rudalics@gmx.at>
2
3 * frame.c (check_minibuf_window): New function.
4 (delete_frame, Fmake_frame_invisible, Ficonify_frame): Call
5 check_minibuf_window (Bug#15183).
6
c80016b3
DA
72013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
8
9 * window.h (struct window): Replace last_cursor with last_cursor_vpos
10 because this is the only last cursor data we need to keep and consult.
11 * window.c (replace_window, set_window_buffer, Fsplit_window_internal):
12 * xdisp.c (mark_window_display_accurate_1, try_cursor_movement):
13 Adjust users.
14
de396731
DA
152013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
16
17 Fix recovering from possible decompression error. Since
18 insert_from_gap doesn't always move point, we can't use PT as
19 the position where the partially decompressed data ends, and
20 should count how may bytes was produced so far.
21 * decompress.c (struct decompress_unwind_data): Add nbytes member.
22 (unwind_decompress): Really delete partially uncompressed data.
23 (Fzlib_decompress_region): Take decompressed data size into account.
24
c76826d9
DA
252013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
26
27 * syntax.c (init_syntax_once): Adjust comment and do an early
28 initialization of Qchar_table_extra_slots just once...
29 * casetab.c (init_casetab_once):
30 * category.c (init_category_once):
31 * character.c (syms_of_character):
32 * coding.c (syms_of_coding):
33 * xdisp.c (syms_of_xdisp): ...and omit it here.
34
b34454d0
EZ
352013-08-24 Eli Zaretskii <eliz@gnu.org>
36
11f20add
EZ
37 * xdisp.c (get_next_display_element): Don't apply to characters
38 from a display vector the logic of setting it->end_of_box_run_p
39 suitable for characters from a buffer. (Bug#15175)
40
b34454d0
EZ
41 * w32.c (fdutimens): Call 'utime', which is implemented on w32.c
42 to handle directories, rather than '_utime' which doesn't.
43 (Bug#15176)
44
6e1b469e
JD
452013-08-24 Jan Djärv <jan.h.d@swipnet.se>
46
47 * gtkutil.c (x_wm_set_size_hint): Don't set hints when maximized
48 or fullscreen (Bug#14627).
49
9c05bccf
PE
502013-08-24 Paul Eggert <eggert@cs.ucla.edu>
51
52 System-dependent integer overflow fixes.
53 * process.c (Fset_process_window_size): Signal an error if
54 the window size is outside the range supported by the lower level.
55 * sysdep.c (set_window_size): Return negative on error,
56 nonnegative on success, rather than -1, 0, 1 on not in system,
57 failure, success. This is simpler. Caller changed.
58 (serial_configure): Remove unnecessary initialization of local.
59 (procfs_get_total_memory) [GNU_LINUX]: Don't assume system memory
60 size fits in unsigned long; this isn't true on some 32-bit hosts.
61 Avoid buffer overrun if some future version of /proc/meminfo has a
62 variable name longer than 20 bytes.
63 (system_process_attributes) [__FreeBSD__]:
64 Don't assume hw.availpages fits in 'int'.
65
c365c355
PE
662013-08-23 Paul Eggert <eggert@cs.ucla.edu>
67
68 Don't let very long directory names overrun the stack.
69 Fix some related minor problems involving "//", vfork.
70 * callproc.c (encode_current_directory): New function.
71 (call_process): Don't append "/"; not needed.
72 * fileio.c (file_name_as_directory_slop): New constant.
73 (file_name_as_directory): Allow SRC to be longer than SRCLEN;
74 this can save the caller having to alloca.
75 (Ffile_name_as_directory, Fdirectory_file_name, Fexpand_file_name):
76 Use SAFE_ALLOCA, not alloca.
77 (directory_file_name, Fexpand_file_name): Leave leading "//"
78 alone, since it can be special even on POSIX platforms.
79 * callproc.c (call_process):
80 * process.c (Fformat_network_address):
81 * sysdep.c (sys_subshell):
82 Use encode_current_directory rather than rolling our own.
83 (create_process): No need to encode directory; caller does that now.
84 * process.h (encode_current_directory): New decl.
85 * sysdep.c (sys_subshell): Work even if vfork trashes saved_handlers.
86 Rework to avoid 'goto xyzzy;'.
87
6c6014d4
EZ
882013-08-23 Eli Zaretskii <eliz@gnu.org>
89
90 * xdisp.c (handle_face_prop): If the default face was remapped use
91 the remapped face for strings from prefix properties. (Bug#15155)
92
9997ec56
DA
932013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
94
95 Minor cleanup for redisplay interface and few related functions.
96 * frame.h (enum text_cursor_kinds): Move from here...
97 * dispextern.h (enum text_cursor_kinds): ...to here.
98 (toplevel): Drop unnecessary declarations.
99 (struct redisplay_interface): Use bool and enum text_cursor_kinds
100 in update_window_end_hook and draw_window_cursor functions.
101 (display_and_set_cursor, x_update_cursor): Adjust prototypes.
102 * nsterm.m (ns_update_window_end, ns_draw_window_cursor):
103 * w32term.c (x_update_window_end,w32_draw_window_cursor):
104 * xterm.c (x_update_window_end, x_draw_window_cursor):
105 * xdisp.c (display_and_set_cursor, update_window_cursor)
106 (update_cursor_in_window_tree, x_update_cursor): Use bool and
107 enum text_cursor_kinds where appropriate.
108
7f780da6
DA
1092013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
110
111 Redesign redisplay interface to drop updated_row and updated_area.
112 * dispextern.h (updated_row, updated_area): Remove declaration.
113 (struct redisplay_interface): Pass glyph row and row area parameters
114 to write_glyphs, insert_glyphs and clear_end_of_line functions.
115 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
116 Adjust prototypes.
117 * dispnew.c (updated_row, updated_area): Remove.
118 (redraw_overlapped_rows, update_window_line): Adjust user.
119 (update_marginal_area, update_text_area): Likewise. Pass updated row
120 as a parameter. Prefer enum glyph_row_area to int where appropriate.
121 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
122 Adjust users.
123
26495794
PE
1242013-08-22 Paul Eggert <eggert@cs.ucla.edu>
125
126 * process.c (flush_pending_output): Remove stub.
127 All uses removed.
128
4a88129a
PE
1292013-08-21 Paul Eggert <eggert@cs.ucla.edu>
130
131 * callproc.c: Fix race that killed background processes (Bug#15144).
132 (call_process): New arg TEMPFILE_INDEX. Callers changed.
133 Record deleted process-id in critical section, not afterwards.
134 Don't mistakenly kill process created by a call-process invocation
135 that discards output and does not wait.
136
0c5307b0
DA
1372013-08-21 Dmitry Antipov <dmantipov@yandex.ru>
138
139 Fix compilation with GC_MARK_STACK == GC_USE_GCPROS_AS_BEFORE
140 and GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES.
141 * alloc.c (toplevel): Remove unnecessary nested #if...#endif.
142 (mark_maybe_object) [!GC_MARK_STACK]: Define to emacs_abort
143 to shut up compiler in mark_object.
144 (dump_zombies): Convert to global and add EXTERNALLY_VISIBLE.
145
0d7c1e66
PE
1462013-08-21 Paul Eggert <eggert@cs.ucla.edu>
147
148 * process.c (allocate_pty) [PTY_OPEN]: Set fd's FD_CLOEXEC flag.
149 We can't portably rely on PTY_OPEN doing that, even if
150 it calls posix_openpt with O_CLOEXEC.
151
3f246b65
KH
1522013-08-20 Kenichi Handa <handa@gnu.org>
153
154 * character.c (string_char): Improve commentary.
155
8c2f38aa
PE
1562013-08-20 Paul Eggert <eggert@cs.ucla.edu>
157
158 * image.c (SIGNATURE_DIGESTSIZE): Remove.
159 (struct animation_cache): Make signature a flexible array member.
160 All uses changed. This is a tad slower but may insulate us better
161 from future changes to ImageMagick.
162
bb566cea
PE
1632013-08-19 Paul Eggert <eggert@cs.ucla.edu>
164
165 * image.c: Shrink memory needed for animation cache.
166 (SIGNATURE_DIGESTSIZE): New constant.
167 (struct animation_cache): Make 'signature' a fixed size array of bytes.
168 (imagemagick_create_cache): Copy the signature. This saves
169 several KB of memory that ImageMagick wastes per signature.
170 Don't bother updating the update_time, as the caller does that now.
171 (imagemagick_prune_animation_cache): Don't destroy the signature, as
172 it's a fixed size struct member now.
173 (imagemagick_get_animation_cache): Always destroy the signature,
174 as it's now imagemagick_create_cache's responsibility to copy it.
175 Avoid duplicate calls to strcmp and to imagemagick_create_cache,
176 and use memcmp rather than strcmp.
177 eassert that ImageMagick returns a signature of the specified length.
178
6da26928
LMI
1792013-08-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
180
181 * image.c (imagemagick_get_animation_cache): Don't segfault on
182 each invocation.
453f4022
LMI
183 (imagemagick_get_animation_cache): Revert to previous definition
184 so that it actually works. But keep the memory leak fix.
185 (imagemagick_get_animation_cache): Fix memory leak.
6da26928 186
22490125
PE
1872013-08-19 Paul Eggert <eggert@cs.ucla.edu>
188
d0139df5
PE
189 * image.c: Fix animation cache signature memory leak.
190 Fix some other minor performance problems while we're at it.
191 (imagemagick_create_cache): Clear just the members that
192 need clearing. Don't set update_time, as caller does that now.
193 (imagemagick_prune_animation_cache, imagemagick_get_animation_cache):
194 Simplify by using pointer-to-pointer instead of a prev pointer.
195 (imagemagick_prune_animation_cache): Use make_emacs_time rather
196 than EMACS_TIME_FROM_DOUBLE, and DestroyString rather than free.
197 (imagemagick_get_animation_cache): Don't xstrdup the image signature;
198 it's already a copy. Free the signature probe unless it's cached.
199
22490125
PE
200 * process.c (handle_child_signal): Fix crash; deleted pid (Bug#15106).
201 This was introduced by my 2013-08-12 fix for Bug#15035.
202
deb31e75
DA
2032013-08-19 Dmitry Antipov <dmantipov@yandex.ru>
204
205 * image.c (imagemagick_create_cache, imagemagick_get_animation_cache)
206 (imagemagick_prune_animation_cache): Now static.
207
319a4d03
LMI
2082013-08-18 Lars Magne Ingebrigtsen <larsi@gnus.org>
209
210 * image.c (imagemagick_get_animation_cache): Don't segfault when
211 pruning all entries.
212
f747d82e
KB
2132013-08-18 Ken Brown <kbrown@cornell.edu>
214
215 * sheap.c (STATIC_HEAP_SIZE): Adjust to current needs; use bigger
216 static heap if ENABLE_CHECKING is defined.
217 (max_bss_sbrk_ptr): New variable.
218 (bss_sbrk): Use it.
219 (report_sheap_usage): Report maximum static heap usage instead of
220 ending static heap usage.
221
d2c28fab
EZ
2222013-08-17 Eli Zaretskii <eliz@gnu.org>
223
224 * decompress.c (Fzlib_available_p) [WINDOWSNT]: Update the value
225 of zlib_initialized according to the results of calling
226 init_zlib_functions.
227
274ff63f
LMI
2282013-08-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
229
230 * image.c: Implement an ImageMagick per-image cache.
8a6f875f 231 (imagemagick_get_animation_cache): Fix a double-free error.
49ceb676
LMI
232 (imagemagick_load_image): Remove the ping_wand code, which only
233 apparently saved time on invalid animated images, and slowed down
234 everything else. Optimise for the common case.
274ff63f 235
2bede2ed
XF
2362013-08-16 Xue Fuqiao <xfq.free@gmail.com>
237
70ff8240
XF
238 * buffer.c (syms_of_buffer) <buffer-undo-list>: Doc fix.
239
de179a3e
XF
240 * editfns.c (insert_before_markers): Mention overlay in the doc string.
241
2bede2ed
XF
242 * marker.c (set_marker): Remove documentation of undefined behavior.
243
703dbeba
LMI
2442013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
245
246 * image.c (imagemagick_compute_animated_image): Animate correctly
247 when sub-images are smaller than the main image.
1d18b1e6
LMI
248 (imagemagick_compute_animated_image): Setting the iterator row to
249 zero is apparently not allowed.
79670014
LMI
250 (imagemagick_compute_animated_image): Allow images that say they
251 have sub-images that are bigger than the main image, but just crop
252 them.
703dbeba 253
63216c5e
JD
2542013-08-15 Jan Djärv <jan.h.d@swipnet.se>
255
256 * nsmenu.m (menuWillOpen:): Fix preprocessor test (Bug#15001).
257
a5b5f73f
LMI
2582013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
259
260 * image.c (imagemagick_compute_animated_image): Respect the GIF
261 disposal methods.
262
0fe73012
KB
2632013-08-15 Ken Brown <kbrown@cornell.edu>
264
265 * emacs.c (main): Update comment about G_SLICE_ALWAYS_MALLOC.
266 * gmalloc.c (memalign) [CYGWIN]: Revert last change; it's not
267 needed.
268
691a357f
PE
2692013-08-15 Paul Eggert <eggert@cs.ucla.edu>
270
271 Fix minor problems found by static checking.
272 * frame.c (delete_frame):
273 * xdisp.c (next_element_from_display_vector):
274 Avoid uninitialized local.
275 * image.c (imagemagick_compute_animated_image): Port to C89.
276 Prefer usual GNU indentation style for loops.
277 Be more careful about bizarrely large sizes, by using ptrdiff_t
278 instead of int.
279
42fe2e88
DA
2802013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
281
282 Fix infinite frame selection loop (Bug#15025).
283 * frame.c (delete_frame): Prefer fast ad-hoc loop to next_frame.
284
d39a3da6
EZ
2852013-08-15 Eli Zaretskii <eliz@gnu.org>
286
287 * xdisp.c (compute_window_start_on_continuation_line): When
288 WORD_WRAP is in effect, use move_it_to instead of move_it_by_lines
289 to make sure we end up setting the window start at the leftmost
290 visible character of the display line. This avoids funky
291 horizontal shifting because the window start is not kept on the
292 same position. (Bug#15090)
05426239
EZ
293 (next_element_from_display_vector): Support 'box' face attribute
294 in the face definitions of a display vector. (Bug#15099)
d39a3da6 295
6e856b69
LMI
2962013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
297
298 * image.c (imagemagick_compute_animated_image): Implement animated
299 images (bug#14700).
995be755
LMI
300 (imagemagick_compute_animated_image): Fix some compilation
301 warnings. Implement a very simple cache to make the animation
302 usable at all, but it should be replaced with a per-image cache.
6e856b69 303
d5a1acfa
DA
3042013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
305
306 * lisp.h (FOR_EACH_ALIST_VALUE): New macro
307 to do `for' loops over alist values.
308 * buffer.h (FOR_EACH_BUFFER):
309 * process.c (FOR_EACH_PROCESS): Use it.
310 (handle_child_signal, status_notify, Fget_buffer_process)
311 (kill_buffer_processes): Use FOR_EACH_PROCESS.
312
9c253307
DA
3132013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
314
315 * term.c (get_named_tty, create_tty_output, tty_free_frame_resources)
316 (tty_free_frame_resources, delete_tty): Prefer eassert to emacs_abort.
317 * image.c (make_image_cache): For struct image_cache, prefer xmalloc
318 to xzalloc and so avoid redundant call to memset.
319 * xterm.c (x_term_init): Avoid unnecessary initializations of dpyinfo
320 members because it is allocated with xzalloc and so already zeroed.
321
05e64f9f
KB
3222013-08-14 Ken Brown <kbrown@cornell.edu>
323
324 * gmalloc.c (memalign) [CYGWIN]: Rename to emacs_memalign
325 (Bug#15094).
326
5b71542d
DA
3272013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
328
329 Utility function and macro to copy Lisp string to C string.
330 * lisp.h (xlispstrdupa): New macro.
331 (xlispstrdup): New prototype.
332 * alloc.c (xlispstrdup): New function.
333 * callint.c (Fcall_interactively):
334 * fileio.c (Ffile_name_directory, Fexpand_file_name)
335 (Fsubstitute_in_file_name):
336 * frame.c (Fmake_terminal_frame): Use xlispstrdupa.
337 * image.c (x_create_bitmap_from_file):
338 * w32term.c (w32_term_init):
339 * xterm.c (x_term_init): Use xlispstrdup.
340
71530c97
LMI
3412013-08-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
342
4ce82fb8
LMI
343 * image.c (imagemagick_load_image): Make animated pictures work.
344 There's still some problems with background color settings, though
345 (bug#14700).
346
71530c97
LMI
347 * decompress.c (unwind_decompress): Always restore point.
348
7510a061
XF
3492013-08-14 Xue Fuqiao <xfq.free@gmail.com>
350
351 * marker.c (set_marker): Reformat documentation.
352
01c3051f
PE
3532013-08-14 Paul Eggert <eggert@cs.ucla.edu>
354
aab1fcdf
PE
355 * xdisp.c (cursor_type_changed): Now static.
356
01c3051f
PE
357 * image.c (imagemagick_filename_hint): New arg HINT_BUFFER.
358 Use changed. This avoids the need to call xmalloc and for the
359 caller to call xfree, and avoids memory leaks in some situations.
360
2084152a
DA
3612013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
362
363 * xdisp.c (adjust_window_ends): Move duplicated code to new function.
364 (try_window, try_window_reusing_current_matrix, try_window_id): Use it.
94a4e898
DA
365 (redisplay_window): If window_end_valid is cleared due to non-zero
366 windows_or_buffers_changed, clear current_matrix_up_to_date_p and
367 so do not call to try_cursor_movement for that window.
2084152a 368
02455cb6
DA
3692013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
370
371 * window.h (struct window): Convert window_end_pos and
372 window_end_vpos from Lisp_Object to ptrdiff_t and int, respectively.
373 (wset_window_end_pos, wset_window_end_vpos): Remove.
374 * dispnew.c (adjust_glyph_matrix):
375 * window.c (Fwindow_end, replace_window, set_window_buffer)
376 (make_window):
377 * xdisp.c (check_window_end, move_it_to, redisplay_internal)
378 (set_vertical_scroll_bar, redisplay_window, try_window)
379 (try_window_reusing_current_matrix, find_first_unchanged_at_end_row)
380 (try_window_id, decode_mode_spec, mouse_face_from_buffer_pos)
381 (note_mouse_highlight): Adjust users.
382 (try_cursor_movement): Likewise. Convert old precondition to eassert.
383 Add comment.
384
da5707e8
DA
3852013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
386
387 Fix --enable-gcc-warnings errors introduced in 2013-08-13 commit.
388 * image.c (imagemagick_filename_hint): Use `const char *' and
389 prefer SSDATA to SDATA to avoid warnings.
390
25554267
DA
3912013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
392
393 Cleanup window fringes, margins and scroll bars adjustments.
394 * window.c (set_window_fringes, set_window_margins)
395 (set_window_scroll_bars, apply_window_adjustment): New functions.
396 (set_window_buffer, Fset_window_margins, Fset_window_fringes)
397 (Fset_window_scroll_bars): Use them.
398
38a2c910
DA
3992013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
400
401 * window.h (struct window): Convert scroll_bar_width
402 from Lisp_Object to integer. Adjust comment.
403 (WINDOW_CONFIG_SCROLL_BAR_WIDTH, WINDOW_CONFIG_SCROLL_BAR_COLS):
404 Adjust users.
405 * window.c (wset_scroll_bar_width): Remove.
406 (make_window): Initialize scroll_bar_width.
407 (Fsplit_window_internal): Use direct assignment.
408 (Fset_window_configuration, save_window_save):
409 Convert Lisp_Object to integer and back where appropriate.
410 (Fset_window_scroll_bars): Adjust user. Return t if any scroll
411 bar was actually changed, and mention this in docstring.
412
2d065031
PE
4132013-08-13 Paul Eggert <eggert@cs.ucla.edu>
414
415 * decompress.c: Minor simplifications.
416 (Fzlib_decompress_region): Don't bother verifying
417 that avail_out <= UINT_MAX, as that was confusing.
418 Mention the restriction in a comment instead.
419 Prefer 'int' to 'ptrdiff_t' when 'int' is wide enough.
420
a5bd5abb
JD
4212013-08-13 Jan Djärv <jan.h.d@swipnet.se>
422
423 * nsmenu.m (x_activate_menubar): Check for OSX >= 10.5
424 (trackingNotification:): Call ns_check_menu_open only for OSX >= 10.5.
425
66e7901a
LMI
4262013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
427
428 * image.c (imagemagick_filename_hint): Check for errors in the
429 alist structure.
430
2fa611b7
EZ
4312013-08-13 Eli Zaretskii <eliz@gnu.org>
432
433 * window.c (Fwindow_margins): Return nil when there's no marginal
434 area, as per the documented API.
435
436 * w32term.c (x_scroll_bar_create): Use ALLOCATE_PSEUDOVECTOR, not
437 Fmake_vector, as scroll bar's struct members are not all Lisp
438 objects now. This avoids crashes in GC.
439
440 * w32term.h (struct scroll_bar): Convert fringe_extended_p to a
441 bool, so its address could be taken.
442
8259030d
LMI
4432013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
444
445 * image.c (imagemagick_filename_hint): New function to possibly
446 apply `image-content-type-suffixes'.
447 (imagemagick_load_image): Use it.
448
866c710e
EZ
4492013-08-13 Eli Zaretskii <eliz@gnu.org>
450
451 * decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil
452 if loading zlib failed.
453
f10490f0
JD
4542013-08-13 Jan Djärv <jan.h.d@swipnet.se>
455
96311be7
JD
456 * nsterm.m (ns_set_vertical_scroll_bar): Fix breakage intruduced by
457 2013-08-13 checkin below. Change bool to BOOL, rule is:
458 All Obj-C code uses BOOL, except for interfaces callable from C.
459
f10490f0
JD
460 * nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).
461
c8ae93b0
DA
4622013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
463
464 * window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
465 * nsterm.m (ns_set_vertical_scroll_bar): Use it. Use convenient
466 bool instead of BOOL.
467 * w32term.h (struct scroll_bar): Convert fringe_extended_p
468 from Lisp_Object to bitfield. Adjust comment.
469 * w32term.c (x_scroll_bar_create): Adjust user.
470 Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
471 * xterm.c (XTset_vertical_scroll_bar): Likewise.
472 Use bool for boolean.
473 * xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
474 to `unsigned int' when defining a bitfield.
475
53b64418
PE
4762013-08-13 Paul Eggert <eggert@cs.ucla.edu>
477
478 * decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
479
eeaf9bf3
DA
4802013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
481
482 * window.h (struct window): Convert left_margin_cols and
483 right_margin_cols from Lisp_Objects to integers. Adjust comment.
484 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
485 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
486 Adjust users.
487 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
488 Adjust comment.
489 (showing_window_margins_p, update_window_line, update_frame_1):
490 * fringe.c (draw_fringe_bitmap_1):
491 * xdisp.c (window_box_width): Adjust users.
492 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
493 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
494 Use direct assignment.
495 (Fset_window_configuration, save_window_save, Fwindow_margins):
496 Convert Lisp_Object to integer and back where appropriate.
497 (Fset_window_margins): Adjust user. Return t if any margin
498 was actually changed, and mention this in docstring.
499
956720af
XF
5002013-08-13 Xue Fuqiao <xfq.free@gmail.com>
501
f73f4ce6 502 * syntax.c (forward_word):
956720af
XF
503 * cmds.c (forward_char, backward_char): Mention the optional argument.
504
9e37ee3b
DA
5052013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
506
507 * window.h (struct window): Convert left_fringe_width
508 and right_fringe_width from Lisp_Objects to integers.
509 Adjust comment.
510 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
511 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
512 * window.c (wset_left_fringe_width, wset_right_fringe_width):
513 Remove.
514 (make_window): Initialize new integer fields to -1.
515 (Fsplit_window_internal): Use direct assignment.
516 (Fset_window_configuration, save_window_save): Convert
517 Lisp_Object to integer and back where appropriate.
518 (Fset_window_fringes): Adjust user. Return t if any fringe
519 was actually changed, and mention this in docstring.
520
e4375ca7
DA
5212013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
522
523 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
9cda66e4
DA
524 * nsfns.m (x_set_cursor_type):
525 * w32fns.c (x_set_cursor_type):
526 * xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
527 * xdisp.c (set_frame_cursor_types): ...but in common code.
e4375ca7 528
a45543bc
DA
5292013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
530
531 * font.c (clear_font_cache): New function, stripped from...
532 (Fclear_font_cache): ...here, which now uses the function
533 above. Adjust comment.
534 * font.h (clear_font_cache): Add prototype.
535 * xfaces.c (clear_face_cache): Use clear_font_cache.
536
ae966a86
DA
5372013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
538
539 * window.c (Fset_window_start): Compare `w', not `window' because
540 `w' might not be equal to `window' after call to decode_live_window.
541
297a545b
PE
5422013-08-12 Paul Eggert <eggert@cs.ucla.edu>
543
544 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
545 This fixes a problem introduced by the Bug#15035 patch
546 when using GPG. Reported by Herbert J. Skuhra.
547
aa942e2b
EZ
5482013-08-12 Eli Zaretskii <eliz@gnu.org>
549
550 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
551 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
552 not yet initialized.
553
7699d09e
LMI
5542013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
555
556 * decompress.c (Fzlib_decompress_region): Support zlib
557 decompression, too, and rename.
558
1d238bc7
PE
5592013-08-12 Paul Eggert <eggert@cs.ucla.edu>
560
561 Minor zlib configuration tweaks.
562 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
563 Don't assume presence of fn_inflateInit2_ zlib internal function.
564
8a44a184
LMI
5652013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
566
567 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
568 include the zlib prefix.
569
594a4307
EZ
5702013-08-12 Eli Zaretskii <eliz@gnu.org>
571
572 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
573 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
574 define static variables that are pointers to zlib functions to be
575 dynamically loaded.
576 (init_zlib_functions) [WINDOWSNT]: New function.
577 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
578 New macros.
579 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
580 macros instead of invoking the zlib functions directly.
581 (syms_of_decompress): DEFSYM Qzlib_dll. Staticpro
582 Szlib_available_p.
583
d2e113bc
DA
5842013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
585
586 Avoid looping over all frame windows to freeze and unfreeze.
587 * window.h (struct window): Drop frozen_window_start_p.
588 (freeze_window_starts): Drop prototype.
589 * frame.h (struct frame): New frozen_window_starts flag.
590 (FRAME_WINDOWS_FROZEN): New macro.
591 * window.c (freeze_window_start, freeze_window_starts):
592 Remove.
593 (select_window, replace_window): Adjust users.
594 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
595 (window_frozen_p): New function.
596 (redisplay_window): Use it.
597
94fcd171
PE
5982013-08-12 Paul Eggert <eggert@cs.ucla.edu>
599
600 Fix some fd issues when running subprocesses (Bug#15035).
601 Fix bugs that can leak files or file descriptors on errors.
602 Don't unlink open temp files, as that's hard for users to diagnose
603 when things go awry (e.g., temp disk exhausted).
604 Don't bother to lock temp files. Check for invalid recursion.
605 * callproc.c (synch_process_fd): Remove. All uses removed.
606 (synch_process_tempfile): New var or macro.
607 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
608 New constants.
609 (record_kill_process): New arg, the temp name. All callers changed.
610 (delete_temp_file): Now just a simple wrapper around unlink.
611 (call_process_kill): New arg, the call_process_fd array.
612 Close them all. Clear synch_process_pid. Remove the temp file,
613 or arrange for it to be removed.
614 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
615 that's been moved to synch_process_tempfile. Caller changed.
616 Do not remove the tempfile; that's now call_process_kill's
617 responsibility.
618 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
619 call_process_kill; the caller now does that.
620 (call_process_cleanup): Do not close the process fd; that's now
621 call_process_kill's responsibility.
622 (Fcall_process): Implement via new function call_process, which
623 has most of the old body of Fcall_process, but with a different API.
624 (call_process): New function that does not open or close filefd if
625 it is nonnegative. Record which fds need to be closed, and let
626 call_process_kill close (and remove the tempfile, on MSDOS) on error.
627 Signal an error if invoked recursively (could be done via a hook).
628 Simplify creation of the tempfile in the MSDOS case.
629 Don't create the output file until after checking for the executable.
630 Report any failure to open /dev/null.
631 Don't open /dev/null for writing twice; once is enough.
632 Don't create pipe if all output is being discarded or sent to file.
633 Don't worry about setting up the coding system or reading from the
634 pipe if all output is being discarded.
635 Hoist fd_error local into top level, to lessen block nesting.
636 Don't record deleted pid here; now done by Fcall_process_region.
637 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
638 and note its success in synch_process_tempfile.
639 Do not leak resources when child_setup fails.
640 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
641 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
642 (create_temp_file): Now returns open fd, with an additional
643 Lisp_Object * argument to return the name. All callers changed.
644 Do not close the file; rewind it instead, and leave it open for
645 the caller. Do not lock the temp file. Unwind-protect the file
646 and the file-descriptor.
647 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
648 If an asynchrounous process, record it here, not in call_process.
649 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
650 * eval.c (set_unwind_protect): New function.
651 * fileio.c (write_region): New function, generalized from the
652 old Fwrite_region. Do not lock temp files.
653 (Fwrite_region): Use it.
654 * lisp.h (set_unwind_protect, write_region): New decls.
655 * process.c: Include <verify.h>.
656 (make_process): Mark fds as initially closed.
657 (deleted_pid_list): Now a list of pid-filename pairs.
658 All uses changed.
659 (close_process_fd): New function.
660 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
661 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
662 New constants. Verify that their number matches PROCESS_OPEN_FDS.
663 (create_process, create_pty, Fmake_serial_process)
664 (server_accept_connection): Record which fds need to be closed,
665 and let deactivate_process close them.
666 (Fmake_network_process): Do not discard the unwind-protect
667 until it's safe to do so.
668 (deactivate_process): Close the fds opened by create_process etc.
669 (Fprocess_send_eof): Adjust to new way of recording open fds.
670 Report an error if /dev/null can't be opened, instead of aborting.
671 * process.h (PROCESS_OPEN_FDS): New constant.
672 (struct Lisp_Process): New member open_fds.
673 (record_kill_process, record_deleted_pid): Adjust signatures.
674 (record_deleted_pid): Move decl here ...
675 * syswait.h (record_deleted_pid): ... from here.
676
d0e615c3
PE
6772013-08-11 Paul Eggert <eggert@cs.ucla.edu>
678
679 * decompress.c: Fix bugs with large buffers and weird inputs.
680 Tune a bit. Reindent as per usual Emacs style.
681 (BUFFER_SIZE): Remove.
682 (Fdecompress_gzipped_region): Do not mishandle input buffers with
683 more than UINT_MAX bytes. Decompress into the gap instead of into
684 an auto buffer, as this should avoid copying. Return nil if
685 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
686 set immediate_quit; we shouldn't trust zlib code that much.
687
313546eb
LMI
6882013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
689
99a32242
LMI
690 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
691 errors, and really move the gap to where we want it.
692
313546eb
LMI
693 * lisp.h: Include decompress.c support.
694
695 * emacs.c (main): Include decompress.c support.
696
697 * Makefile.in: Include -lz if present.
698
d2d699ac
JD
6992013-08-11 Jan Djärv <jan.h.d@swipnet.se>
700
f90e3ebd
JD
701 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
702 (initWithTitle:): Initialize frame to 0.
703 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
704 (fillWithWidgetValue:frame:): Renamed from
705 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
706
707 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
708 fillWithWidgetValue:frame:
709
423d3b3f
JD
710 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
711 remove memory leak warnings.
712
d2d699ac
JD
713 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
714 (ns_check_menu_open): Handle menu == nil. Remove assignment to
715 menu_pending_title.
716
717 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
718 (x_activate_menubar): Update the whole menu.
719 (trackingNotification:): Call ns_check_menu_open if tracking ends.
720 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
721 current event is not NSSystemDefined (Bug#15001).
722 Call ns_check_menu_open only if trackingMenu is 2.
723 (menuDidClose:): New method, decrease trackingMenu.
724 (fillWithWidgetValue:setDelegate:): New method.
725 (fillWithWidgetValue:): Call the above.
726
727 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
728
7d652d97
PE
7292013-08-11 Paul Eggert <eggert@cs.ucla.edu>
730
731 Omit some unnecessary casts.
732 Many of these go back to the old pre-C89 days, when they may have
733 been needed, but we've been assuming C89 or later for a while now.
734 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
735 (live_float_p, live_misc_p, live_vector_p):
736 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
737 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
738 (defvar_per_buffer):
739 * callint.c (Fcall_interactively):
740 * doc.c (Fsubstitute_command_keys):
741 * filelock.c (get_boot_time):
742 * frame.c (xrdb_get_resource):
743 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
744 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
745 (xg_get_file_name_from_selector, menuitem_destroy_callback)
746 (menuitem_highlight_callback, menu_destroy_callback)
747 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
748 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
749 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
750 (xg_tool_bar_help_callback, tb_size_cb):
751 * image.c (xpm_alloc_color, png_read_from_memory)
752 (png_read_from_file, png_load_body, our_memory_skip_input_data)
753 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
754 (syms_of_image):
755 * keymap.c (describe_map):
756 * nsfns.m (Fns_display_monitor_attributes_list):
757 * nsmenu.m (process_dialog:):
758 * nsterm.m (hold_event):
759 * process.c (wait_reading_process_output):
760 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
761 * scroll.c (do_direct_scrolling, scrolling_1):
762 * termcap.c (tgetent):
763 * window.c (check_window_containing, add_window_to_list)
764 (freeze_window_starts):
765 * xdisp.c (compare_overlay_entries, vmessage):
766 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
767 (x_get_monitor_attributes_xrandr)
768 (Fx_display_monitor_attributes_list, x_display_info_for_name)
769 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
770 * xfont.c (xfont_match, xfont_open):
771 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
772 (menubar_selection_callback, menu_position_func)
773 (popup_selection_callback, create_and_show_popup_menu)
774 (dialog_selection_callback, create_and_show_dialog):
775 * xrdb.c (x_get_string_resource):
776 (main) [TESTRM]:
777 * xsmfns.c (x_session_check_input):
778 * xterm.c (x_draw_glyphless_glyph_string_foreground)
779 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
780 (xaw_jump_callback, xaw_scroll_callback):
781 Omit unnecessary casts.
782
9acc1074
PE
7832013-08-10 Paul Eggert <eggert@cs.ucla.edu>
784
785 Minor string-length refactoring.
786 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
787 * frame.c (make_monitor_attribute_list):
788 Prefer build_string to strlen + make_string.
789
361c0eb8
JD
7902013-08-10 Jan Djärv <jan.h.d@swipnet.se>
791
792 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
793 don't check minor_code (Bug#14417).
794
14ba0822
EZ
7952013-08-09 Eli Zaretskii <eliz@gnu.org>
796
797 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
798 vertical positions instead. This avoids calling MATRIX_ROW with
799 row numbers that are possibly beyond valid limits. (Bug#15064)
800
309f24d1
DA
8012013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
802
803 Use xstrdup and build_unibyte_string where applicable.
804 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
805 * xfns.c (x_window):
806 * xrdb.c (x_get_customization_string):
807 * xterm.c (xim_initialize):
808 * w32fns.c (w32_window): Use xstrdup.
809 (w32_display_monitor_attributes_list):
810 * emacs.c (init_cmdargs):
811 * keyboard.c (PUSH_C_STR):
812 * nsfont.m (nsfont_open):
813 * sysdep.c (system_process_attributes):
814 * w32.c (system_process_attributes):
815 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
816
55902276
EZ
8172013-08-09 Eli Zaretskii <eliz@gnu.org>
818
819 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
820 variables of these types so that GDB would know about them, as aid
821 for debugging fatal exceptions. (Bug#15024) See also
822 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
823 discussions.
824
10bf7f5a
JD
8252013-08-08 Jan Djärv <jan.h.d@swipnet.se>
826
827 * nsterm.m (ns_update_begin): Don't change clip path if it would be
828 larger than the NSWindow (Bug#14934).
829
65620264
DA
8302013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
831
832 Redesign redisplay interface to drop global variable updated_window.
833 Always pass currently updated window as a parameter to update routines.
834 * dispextern.h (updated_window): Remove declaration.
835 (struct redisplay_interface): Pass window parameter to
836 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
837 and after_update_window_hook.
838 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
839 Adjust prototypes.
840 * dispnew.c (updated_window): Remove.
841 (redraw_overlapped_rows, update_marginal_area, update_text_area)
842 (update_window_line): Adjust to match redisplay interface changes.
843 * nsterm.m (ns_update_window_begin, ns_update_window_end)
844 (ns_scroll_run, ns_after_update_window_line):
845 * w32term.c (x_update_window_begin, x_update_window_end)
846 (x_after_update_window_line, x_scroll_run):
847 * xterm.c (x_update_window_begin, x_update_window_end)
848 (x_after_update_window_line, x_scroll_run):
849 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
850 Likewise. Adjust comments where appropriate.
851 (x_cursor_to): Simplify because this is always called during window
852 update (but install debugging check anyway).
853 (expose_window): Check must_be_updated_p flag to see whether this
854 function is called during window update.
855
628fdc56
DA
8562013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
857
858 Do not reset window modification event counters excessively.
859 These leftovers and poor man's tricky methods to catch extra
860 redisplay's attention are no longer needed.
861 * frame.c (set_menu_bar_lines_1):
862 * minibuf.c (read_minibuf_unwind):
863 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
864 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
865 (window_scroll_line_based, Fset_window_configuration):
866 * xdisp.c (redisplay_window): Do not reset last_modified and
867 last_overlay_modified counters.
868
8fd9c92e
JD
8692013-08-07 Jan Djärv <jan.h.d@swipnet.se>
870
871 * xselect.c (x_send_client_event): Set send_event and serial, memset
872 data.l as it might be bigger than data.b. Use 24 bit mask to
873 XSendEvent (Bug#15034).
874
0ee18172
EZ
8752013-08-07 Eli Zaretskii <eliz@gnu.org>
876
877 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
878 for TTY frames that are not the top frame on their console.
879 (Bug#14616)
880
16ddd1a6
MR
8812013-08-07 Martin Rudalics <rudalics@gmx.at>
882
883 * w32term.c (w32fullscreen_hook): Really maximize frame when
884 asked for (Bug#14841).
885
d2a95ffb
DA
8862013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
887
888 Prefer selected_window to Fselected_window, likewise for frames.
889 * buffer.c (Fbuffer_swap_text):
890 * data.c (Fvariable_binding_locus):
891 * window.c (run_window_configuration_change_hook): Adjust users.
892 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
893 Use decode_live_frame.
894
170da1ec
DA
8952013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
896
897 Be more careful if selected window shows the buffer other than current,
898 use window_outdated only if this is not so. This change should also
899 address some weird issues discussed in Bug#13012.
900 * window.h (window_outdated): New prototype.
901 * window.c (window_outdated): Now here. Convert from static and
902 always assume window's buffer.
903 (Fwindow_end, Fwindow_line_height): Use it.
904 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
905 and always assume window's buffer.
906 (redisplay_window): Adjust user.
e5eefe9b 907 (redisplay_internal): Call to reconsider_clip_changes once and
170da1ec
DA
908 check whether mode line should be updated only if selected window
909 shows current buffer.
910 (run_window_scroll_functions): Use eassert for debugging check.
911 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
912
56b5d5b1
DA
9132013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
914
915 * window.c (window_scroll, window_scroll_pixel_based)
916 (window_scroll_line_based): Use bool for booleans.
917
2878ba7e
PE
9182013-08-06 Paul Eggert <eggert@cs.ucla.edu>
919
920 * process.c: Fix minor off-by-one issues in descriptor counts.
921 This shouldn't fix any real bugs, but it cleans up the code a bit.
922 (max_process_desc, max_input_desc): -1, not 0, means none.
923 All uses changed.
924 (delete_input_desc): New function.
925 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
926 (deactivate_process): Scan backwards when recomuting max_process_desc;
927 that should be faster.
928 (init_process_emacs): Initialize max_input_desc.
929
e30b79c1
DA
9302013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
931
932 Use region cache to speedup bidi_find_paragraph_start.
933 * buffer.h (struct buffer): New member bidi_paragraph_cache.
934 Rename cache_long_line_scans to cache_long_scans.
935 * buffer.c (bset_cache_long_line_scans): Rename to
936 bset_cache_long_scans.
937 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
938 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
939 into account.
940 (syms_of_buffer): Rename cache-long-line-scans to
941 cache-long-scans. Adjust docstring.
942 * search.c (newline_cache_on_off):
943 * indent.c (width_run_cache_on_off): Adjust users.
944 * bidi.c (bidi_paragraph_cache_on_off): New function.
945 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
946 * insdel.c (prepare_to_modify_buffer): Invalidate
947 bidi_paragraph_cache if enabled.
948
00012b86
DA
9492013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
950
951 Invalidate region caches only if buffer text is going to be changed.
952 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
953 (modify_text): ...new prototype.
954 (prepare_to_modify_buffer_1): New prototype.
955 * textprop.c (modify_region): Rename to...
956 (modify_text_properties): ...new function.
957 (add_text_properties_1, set_text_properties, Fremove_text_properties)
958 (Fremove_list_of_text_properties): Adjust users.
959 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
960 (modify_text): ...new function.
961 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
962 (prepare_to_modify_buffer_1): ...new function.
963 * casefiddle.c (casify_region):
964 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
965 (Ftranspose_regions): Use modify_text.
966
dc6c0eda
SM
9672013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
968
969 * lisp.mk (lisp): Add nadvice.elc.
970
8f3a2c26
DA
9712013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
972
973 New macro to iterate over live buffers similar to frames.
974 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
975 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
976 Declare buffer-related variables here to offload lisp.h.
977 * buffer.c (Vbuffer_alist): Adjust comment.
978 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
979 (other_buffer_safely):
980 * data.c (store_symval_forwarding):
981 * dispnew.c (Fframe_or_buffer_changed_p):
982 * fileio.c (Fdo_auto_save):
983 * filelock.c (unlock_all_files):
984 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
985
e0fdb694
PE
9862013-08-04 Paul Eggert <eggert@cs.ucla.edu>
987
988 Fix some minor races in hosts lacking mkostemp (Bug#15015).
989 * callproc.c (create_temp_file):
990 * filelock.c (create_lock_file):
991 Assume mkostemp, since it's now provided by Gnulib.
992
63f5c6c2
EZ
9932013-08-04 Eli Zaretskii <eliz@gnu.org>
994
995 * w32.c (mkostemp): New function.
996 (mktemp): Remove, no longer used. Most of the code reused in
997 mkostemp. (Bug#15015)
484ab239 998 (mktemp): Don't undef.
63f5c6c2 999
f0b79313
DA
10002013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
1001
1002 * dispnew.c (glyph_matrix_count, glyph_pool_count):
1003 Move under GLYPH_DEBUG and ENABLE_CHECKING.
1004 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
1005 (free_glyph_pool, check_glyph_memory): Likewise for
1006 all users. Adjust comments where appropriate.
1007
98f638d6
PE
10082013-08-03 Paul Eggert <eggert@cs.ucla.edu>
1009
1010 * composite.h: Minor fixups.
1011 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
1012 to fix a misspelling, and change it to an inline function while
1013 we're at it (it need not be a macro). All uses changed.
1014 (composition_method, composition_valid_p):
1015 Rewrite to avoid assignments in if-conditions.
1016
75c59fb3
DA
10172013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
1018
1019 Do not use global Lisp_Object in composition macros.
1020 * composite.h (composition_temp): Remove declaration.
1021 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
1022 (composition_method, composition_valid_p): ...inline functions.
416a3e01 1023 (compose_region): Remove the leftover.
75c59fb3
DA
1024 * composite.c (composition_temp): Remove.
1025 (run_composition_function, update_compositions)
1026 (composition_compute_stop_pos, composition_adjust_point)
1027 (Ffind_composition_internal):
1028 * coding.c (handle_composition_annotation):
1029 * xdisp.c (handle_composition_prop, check_point_in_composition):
1030 Related users changed.
1031
a10c8269
DA
10322013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
1033
1034 Drop FRAME_PTR typedef.
1035 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
1036 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
1037 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
1038 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
1039 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
1040 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
1041 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
1042 All related users changed.
1043
a104f656
SM
10442013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1045
1046 * eval.c (default_toplevel_binding): New function.
1047 (Fdefvar): Use it.
1048 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
1049 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
1050 (syms_of_eval): Export them.
1051 * data.c (Fdefault_value): Micro cleanup.
1052 * term.c (init_tty): Use "false".
1053
4b5c9326
DA
10542013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1055
1056 Fix X GC leak in GTK and raw (no toolkit) X ports.
1057 * xterm.c (x_free_frame_resources): If white and black relief
1058 GCs are allocated, always free them here.
1059 * xfns.c (x_make_gc): Omit redundant initialization.
1060 * widget.c (create_frame_gcs): Remove the leftover.
1061 (EmacsFrameDestroy): Do nothing because all GCs are now freed
1062 in x_free_frame_resources.
1063
b19aa636
JD
10642013-08-02 Jan Djärv <jan.h.d@swipnet.se>
1065
1066 * nsterm.m (windowWillResize:toSize:): Only change title if
1067 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
1068 modifying it.
1069 (viewDidEndLiveResize): New method.
1070
1071 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
1072 inside NS_IMPL_COCOA.
1073
af1f7e06
DA
10742013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1075
1076 * insdel.c (adjust_after_replace, replace_range, del_range_2):
1077 Do not check whether undo is enabled because record_insert and
1078 record_delete does that themselves.
1079
65b02bb9
DA
10802013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1081
1082 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
1083 member which is not really used any more.
1084 (FRAME_XIC_BASE_FONTNAME): Remove.
1085 * xfns.c (xic_free_fontset): Adjust user.
1086 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
1087 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
1088 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
1089 (xdialog_show): Use eassert for debugging check.
7ee0f047 1090 * w32term.c (x_unfocus_frame): Remove unused dummy function.
65b02bb9 1091
6318cde0
PE
10922013-08-01 Paul Eggert <eggert@cs.ucla.edu>
1093
1094 * fileio.c, fns.c (merge): Move extern decl from here ...
1095 * lisp.h (merge): ... to here.
1096
6c1a09ba
DA
10972013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1098
1099 Fix last font-related change.
1100 * w32font.h (w32font_list_internal, w32font_match_internal):
1101 Fix prototype.
1102 * w32uniscribe.c (uniscribe_list, uniscribe_match):
1103 (uniscribe_list_family): Adjust to match font API change.
1104 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
1105 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
1106
f8c20208
DA
11072013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1108
1109 * frame.h (FRAME_MOUSE_UPDATE):
1110 * nsterm.m (ns_frame_up_to_date): Omit redundant check
1111 whether hlinfo->mouse_face_mouse_frame is non-NULL.
1112
fdb396e2
DA
11132013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1114
1115 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
1116 * font.h (struct font_driver): Change list, match, and list_family
1117 functions to accept struct frame * as first arg.
1118 * font.c (font_score, font_compare, font_sort_entities): Remove
1119 prototypes.
1120 (font_sort_entities, font_list_entities, font_select_entity):
1121 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
1122 match font API change.
1123 * xfont.c (xfont_list, xfont_match, xfont_list_family):
1124 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
1125 * ftxfont.c (ftxfont_list, ftxfont_match):
1126 * xftfont.c (xftfont_list, xftfont_match):
1127 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
1128 * w32font.c (w32font_list, w32font_match, w32font_list):
1129 (w32font_list_internal, w32_font_match_internal): Likewise.
1130 * xfaces.c (Fx_family_fonts): Adjust user.
1131
52b8a085
DA
11322013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1133
1134 Do not use pure Xism x_wm_set_icon_position in non-X ports.
1135 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
1136 only if HAVE_X_WINDOWS is in use.
1137 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
1138 * nsterm.m (x_wm_set_icon_position): Remove no-op.
1139 * w32term.c (x_wm_set_icon_position): Likewise.
1140 * w32fns.c (x_icon): Adjust user.
1141
c791c18e
DA
11422013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1143
1144 * xterm.c (last_mouse_press_frame): Remove the
1145 leftover which is not really used any more.
1146 (handle_one_xevent, syms_of_xterm): Adjust users.
1ca6cc28
DA
1147 (x_flush): Call XFlush once per each X display, not frame.
1148 This is better because this code always unconditionally skips
1149 non-X frames in Vframe_list and issues the only XFlush if we
1150 have more than one X frame on the same X display.
2f935d86
DA
1151 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
1152 Use bool for booleans.
1153 (x_draw_glyph_string_background, cvt_string_to_pixel):
1154 (cvt_pixel_dtor): Drop unnecessary prototypes.
1155 * xterm.h (x_display_ok): Adjust prototype.
c791c18e 1156
f435830e
DA
11572013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1158
1159 Drop unnecessary functions that deals with frame pixel size.
1160 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
1161 (x_pixel_height): Drop prototypes.
1162 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
1163 (x_pixel_height): Drop implementations.
1164 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
1165 which should be always valid for window frame.
1166 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
1167 * w32menu.c (Fx_popup_dialog):
1168 * xmenu.c (Fx_popup_dialog): Likewise for both.
1169
84231434
DA
11702013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1171
1172 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
1173 frame parameters and call to Fmodify_frame_parameters just once.
4c131798
DA
1174 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
1175 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
1176 and mention nil frame in docstring.
84231434 1177
959067a1
DA
11782013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1179
1180 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
1181 (x_figure_window_size): Likewise. Adjust to return long.
1182 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
1183 (toplevel): Move Qterminal_live_p to...
1184 * terminal.c (toplevel): ...here, make it static, and...
1185 (syms_of_terminal): ...DEFSYM here.
1186 * frame.h (Qterminal_live_p): Remove declaration.
1187 (make_frame, x_figure_window_size): Adjust prototype.
1188 * nsfns.m (Fx_create_frame): Use long for window flags.
1189
f4b169ce
PE
11902013-07-30 Paul Eggert <eggert@cs.ucla.edu>
1191
1192 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
1193 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
1194 Do not assume that emacs_close (INT_MAX) is a no-op.
1195
bee6a2c7
DA
11962013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1197
1198 * xfaces.c (make_face_cache): For struct face_cache, prefer
1199 xmalloc to xzalloc and so avoid redundant call to memset.
1200 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
1201
d7e6881a
DA
12022013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1203
1204 * fringe.c (draw_window_fringes, update_window_fringes)
1205 (compute_fringe_widths):
1206 * w32term.c (x_draw_glyph_string):
1207 * window.c (candidate_window_p, Frecenter):
1208 * xfaces.c (realize_basic_faces, realize_default_face)
1209 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
1210 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
1211 * xfns.c (x_set_cursor_color, xic_free_xfontset):
1212 * xmenu.c (Fx_menu_bar_open_internal):
1213 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
1214 * xsettings.c (xft_settings_event):
1215 * xterm.c (x_draw_glyph_string, x_had_errors_p):
1216 Use bool for booleans. Adjust style and comments where
1217 appropriate.
1218 * dispextern.h (draw_window_fringes, update_window_fringes)
1219 (compute_fringe_widths):
1220 * xterm.h (x_had_errors_p): Adjust prototype.
1221
ec3058af
DA
12222013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1223
1224 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
1225 CHECK_LIST. Rewrite the loop to avoid useless local variable.
1226
218e0637
DA
12272013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
1228
1229 * fns.c (toplevel): Remove comment before Fsafe_length because
1230 it checks for QUIT.
1231
e560aba9
PE
12322013-07-28 Paul Eggert <eggert@cs.ucla.edu>
1233
1234 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
1235
2e5ce5de
EZ
12362013-07-28 Eli Zaretskii <eliz@gnu.org>
1237
1238 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
1239 frame which got the message is still alive, before dereferencing
1240 its pointer. (Bug#14970)
1241
1242 * frame.c (delete_frame): Test "this" frame's minibuffer window to
1243 be a live window, before using it as such. (Bug#14970)
1244
e95da6d3
EZ
12452013-07-27 Eli Zaretskii <eliz@gnu.org>
1246
1247 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
1248 w32_detect_focus_change instead of doing part of its job by hand.
1249 This fixes the problem whereby FOCUS_OUT events were not sent to
1250 the event queue.
1251
a8f93651
EZ
12522013-07-26 Eli Zaretskii <eliz@gnu.org>
1253
fec92060
EZ
1254 * process.c (Fprocess_list): Doc fix.
1255
a8f93651
EZ
1256 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
1257 being re-exposed only if it didn't ask to become visible.
1258 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
1259 was previously iconified. (Bug#14841)
1260 (x_iconify_frame): Mark the frame iconified.
1261
d5a7a9d9
PE
12622013-07-26 Paul Eggert <eggert@cs.ucla.edu>
1263
1264 Fix minor problems found by static checking.
1265 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
1266 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
1267
56ea7291
SM
12682013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
1269
1270 * eval.c (set_specpdl_old_value): New function.
1271 (unbind_to): Minor simplification.
1272 (get_backtrace_frame): New function.
1273 (Fbacktrace_frame): Use it. Add `base' argument.
1274 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
1275 (syms_of_eval): Export backtrace-eval.
1276 * xterm.c (x_focus_changed): Simplify.
1277
9d611ffe
PE
12782013-07-25 Paul Eggert <eggert@cs.ucla.edu>
1279
1280 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
1281
999c74e3
EZ
12822013-07-24 Eli Zaretskii <eliz@gnu.org>
1283
1284 * xdisp.c (redisplay_window): Instead of moving point out of
1285 scroll margin, reject the force_start method, and try scrolling
1286 instead. (Bug#14780)
1287
198fa217
KB
12882013-07-24 Ken Brown <kbrown@cornell.edu>
1289
1290 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
1291 (Bug#14944).
1292
53840e55
PE
12932013-07-24 Paul Eggert <eggert@cs.ucla.edu>
1294
1295 * eval.c (Fprogn): Do not check that BODY is a proper list.
1296 This undoes the previous change. The check slows down the
1297 interpreter, and is not needed to prevent a crash. See
1298 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
1299
60967f56
GM
13002013-07-23 Glenn Morris <rgm@gnu.org>
1301
1302 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
1303
9ca960e2
PE
13042013-07-23 Paul Eggert <eggert@cs.ucla.edu>
1305
a29c3e6d
PE
1306 Port to GNU/Linux systems with tinfo but not ncurses.
1307 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
1308 to decide whether ncurses is being used. Without this change,
1309 GCC complains about tgetent not being declared, on a system
1310 that has tinfo installed but ncurses not installed.
1311
f274311c
PE
1312 * eval.c (Fprogn): Check that BODY is a proper list.
1313
16b0520a
PE
1314 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
1315 * data.c (Fsetq_default):
1316 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
1317 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
1318 (Fcondition_case):
1319 Tune by taking advantage of the fact that ARGS is always a list
1320 when a function is declared to have UNEVALLED args.
1321
9ca960e2
PE
1322 * emacsgtkfixed.c: Port to GCC 4.6.
1323 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
1324
afacaa1b
JB
13252013-07-23 Juanma Barranquero <lekktu@gmail.com>
1326
1327 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
1328 here to silence compiler warnings.
1329
368a85a4
PE
13302013-07-22 Paul Eggert <eggert@cs.ucla.edu>
1331
1332 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
1333 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
1334 from messing up Emacs's 'struct frame' (Bug#14923).
1335
f4e891b5
PE
13362013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1337
1338 * alloc.c (make_save_ptr_ptr): Define this function.
1339 It was inadvertently omitted. It's needed only if
1340 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
1341
96c8b65e
JD
13422013-07-21 Jan Djärv <jan.h.d@swipnet.se>
1343
1344 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
1345 frame have focus (Bug#14895).
1346
ee010797
PE
13472013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1348
1349 Avoid vfork-related deadlock more cleanly.
1350 * callproc.c (child_setup): When the child's exec fails, output
1351 the program name, as that's more useful. Use O_NONBLOCK to avoid
1352 deadlock.
1353 * process.c (create_process_1): Remove; no longer needed.
1354 (create_process): Remove timer hack; no longer needed, now that
1355 the child avoids deadlock.
1356
f0398ec1 13572013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
1358
1359 * image.c (Fimage_flush): Fix doc typo.
1360
b2a069c2
PE
13612013-07-20 Paul Eggert <eggert@cs.ucla.edu>
1362
6496aec9
PE
1363 Fix array bounds violation when pty allocation fails.
1364 * process.c (PTY_NAME_SIZE): New constant.
1365 (pty_name): Remove static variable; it's now auto.
1366 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
1367 Take pty_name as an arg rather than using a static variable.
1368 All callers changed.
1369 (create_process): Recover pty_flag from process, not from volatile local.
1370 (create_pty): Stay inside array even when pty allocation fails.
1371 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
1372
b2a069c2
PE
1373 * lread.c (Fload): Avoid initialization only when lint checking.
1374 Mention that it's needed only for older GCCs.
1375
99107004
KH
13762013-07-20 Kenichi Handa <handa@gnu.org>
1377
1378 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
1379 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
1380
6b1b199d
AS
13812013-07-20 Andreas Schwab <schwab@linux-m68k.org>
1382
1383 * lread.c (Fload): Avoid uninitialized warning.
1384
4195afc3
PE
13852013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1386
3f5bef16
PE
1387 Fix some minor file descriptor leaks and related glitches.
1388 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
1389 (create_lock_file): Use write, not emacs_write.
1390 * image.c (slurp_file, png_load_body):
1391 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
1392 (server_accept_connection):
1393 Don't leak an fd on memory allocation failure.
1394 * image.c (slurp_file): Add a cheap heuristic for growing files.
1395 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
1396 as that's what the other routines do. Maybe input need not be
1397 blocked at all, but it's better to be consistent.
1398 Avoid undefined behavior when strlen is zero.
1399
4195afc3
PE
1400 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
1401 (NSTATICS): Now a constant; doesn't need to be a macro.
1402
a1aeeffe
RS
14032013-07-19 Richard Stallman <rms@gnu.org>
1404
1405 * coding.c (decode_coding_utf_8): Add simple loop for fast
1406 processing of ASCII characters.
1407
63b34baa
PE
14082013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1409
1410 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
1411
621dd9ac
EZ
14122013-07-19 Eli Zaretskii <eliz@gnu.org>
1413
1414 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
1415 unportable 'struct x_display_info'.
1416 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
1417 is a portable type.
1418
1396ac86
PE
14192013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1420
ab9980cd
PE
1421 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
1422 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
1423 or fscanf fails.
1424 (system_process_attributes): Prefer plain char to unsigned char
1425 when either will do. Clean up properly if interrupted or if
1426 memory allocations fail. Don't assume sscanf succeeds. Remove
1427 no-longer-needed workaround to stop GCC from whining. Read
1428 command-line once, instead of multiple times. Check read status a
1429 bit more carefully.
1430
1396ac86
PE
1431 Fix obscure porting bug with varargs functions.
1432 The code assumed that int is treated like ptrdiff_t in a vararg
1433 function, which is not a portable assumption. There was a similar
1434 -- though these days less likely -- porting problem with various
1435 assumptions that pointers of different types all smell the same as
1436 far as vararg functions is conserved. To make this problem less
1437 likely in the future, redo the API to use varargs functions.
1438 * alloc.c (make_save_value): Remove this vararg function.
1439 All uses changed to ...
1440 (make_save_int_int_int, make_save_obj_obj_obj_obj)
1441 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
1442 New functions.
1443 (make_save_ptr): Rename from make_save_pointer, for consistency with
1444 the above. Define only on platforms that need it. All uses changed.
1445
4d19d194
PE
14462013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1447
1448 * keyboard.c: Try to fix typos in previous change.
1449 (DISPLAY_LIST_INFO): New macro.
1450 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 1451 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 1452
945c5bb1
JB
14532013-07-18 Juanma Barranquero <lekktu@gmail.com>
1454
1455 * keyboard.c (kbd_buffer_get_event):
1456 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
1457 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
1458
f4b1eb36
PE
14592013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1460
5e679a2c
PE
1461 * filelock.c: Fix unlikely file descriptor leaks.
1462 (get_boot_time_1): Rework to avoid using emacs_open.
1463 This doesn't actually fix a leak, but is better anyway.
1464 (read_lock_data): Use read, not emacs_read.
1465
a8cd4836
PE
1466 * doc.c: Fix minor memory and file descriptor leaks.
1467 * doc.c (get_doc_string): Fix memory leak when doc file absent.
1468 (get_doc_string, Fsnarf_documentation):
1469 Fix file descriptor leak on error.
1470
ef30e638
PE
1471 * term.c: Fix minor fdopen-related file descriptor leaks.
1472 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
1473 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
1474
f4b1eb36
PE
1475 * charset.c: Fix file descriptor leaks and errno issues.
1476 Include <errno.h>.
1477 (load_charset_map_from_file): Don't leak file descriptor on error.
1478 Use plain record_xmalloc since the allocation is larger than
1479 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
1480 of entries.
1481 * eval.c (record_unwind_protect_nothing):
1482 * fileio.c (fclose_unwind):
1483 New functions.
1484 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
1485 The replacement doesn't block input, but that no longer seems
1486 necessary.
1487
b648c163
PE
14882013-07-17 Paul Eggert <eggert@cs.ucla.edu>
1489
a0931322
PE
1490 * lread.c: Fix file descriptor leaks and errno issues.
1491 (Fload): Close some races that leaked fds or streams when 'load'
1492 was interrupted.
1493 (Fload, openp): Report error number of last nontrivial failure to open.
1494 ENOENT counts as trivial.
1495 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
1496 New functions.
1497 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
1498 now that the function is always called with a nonnegative arg.
1499 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
1500 All uses replaced with ...
1501 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
1502
b648c163
PE
1503 A few more minor file errno-reporting bugs.
1504 * callproc.c (Fcall_process):
1505 * doc.c (Fsnarf_documentation):
1506 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
1507 * process.c (set_socket_option):
1508 Don't let a constructor trash errno.
1509 * doc.c: Include <errno.h>.
1510
b1dc4084
JB
15112013-07-16 Juanma Barranquero <lekktu@gmail.com>
1512
1513 * w32fns.c (unwind_create_tip_frame): Fix declaration.
1514
c43843aa
PE
15152013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1516
50a30cce
PE
1517 Fix w32 bug with call-process-region (Bug#14885).
1518 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
1519 to Fcall_process when the input is empty. This simplifies the
1520 code a bit. It makes no difference on POSIXish platforms but
1521 apparently it fixes a bug on w32.
1522
44e18199 1523 Fix bug where insert-file-contents closes a file twice (Bug#14839).
41d48a42
PE
1524 * fileio.c (close_file_unwind): Don't close if FD is negative;
1525 this can happen when unwinding a zapped file descriptor.
1526 (Finsert_file_contents): Unwind-protect the fd before the point marker,
1527 in case Emacs runs out of memory between the two unwind-protects.
1528 Don't trash errno when closing FD.
1529 Zap the FD in the specpdl when closing it, instead of deferring
1530 the removal of the unwind-protect; this fixes a bug where a child
1531 function unwinds the stack past us.
1532
27e498e6
PE
1533 New unwind-protect flavors to better type-check C callbacks.
1534 This also lessens the need to write wrappers for callbacks,
1535 and the need for make_save_pointer.
1536 * alloca.c (free_save_value):
1537 * atimer.c (run_all_atimers):
1538 Now extern.
1539 * alloc.c (safe_alloca_unwind):
1540 * atimer.c (unwind_stop_other_atimers):
1541 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
1542 * menu.c (cleanup_popup_menu) [HAVE_NS]:
1543 * minibuf.c (choose_minibuf_frame_1):
1544 * process.c (make_serial_process_unwind):
1545 * xdisp.h (pop_message_unwind):
1546 * xselect.c (queue_selection_requests_unwind):
1547 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
1548 * alloca.c (record_xmalloc):
1549 Prefer record_unwind_protect_ptr to record_unwind_protect with
1550 make_save_pointer.
1551 * alloca.c (Fgarbage_collect):
1552 Prefer record_unwind_protect_void to passing a dummy.
1553 * buffer.c (restore_buffer):
1554 * window.c (restore_window_configuration):
1555 * xfns.c, w32fns.c (do_unwind_create_frame)
1556 New wrapper. All record-unwind uses of wrappee changed.
1557 * buffer.c (set_buffer_if_live):
1558 * callproc.c (call_process_cleanup, delete_temp_file):
1559 * coding.c (code_conversion_restore):
1560 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
1561 * editfns.c (save_excursion_restore)
1562 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
1563 (save_restriction_restore):
1564 * eval.c (restore_stack_limits, un_autoload):
1565 * fns.c (require_unwind):
1566 * keyboard.c (recursive_edit_unwind, tracking_off):
1567 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
1568 * macros.c (pop_kbd_macro, restore_menu_items):
1569 * nsfns.m (unwind_create_frame):
1570 * print.c (print_unwind):
1571 * process.c (start_process_unwind):
1572 * search.c (unwind_set_match_data):
1573 * window.c (select_window_norecord, select_frame_norecord):
1574 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
1575 (fast_set_selected_frame):
1576 * xfns.c, w32fns.c (unwind_create_tip_frame):
1577 Return void, not a dummy Lisp_Object. All uses changed.
1578 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
1579 * callproc.c (call_process_kill):
1580 * fileio.c (restore_point_unwind, decide_coding_unwind)
1581 (build_annotations_unwind):
1582 * insdel.c (Fcombine_after_change_execute_1):
1583 * keyboard.c (read_char_help_form_unwind):
1584 * menu.c (unuse_menu_items):
1585 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
1586 * sound.c (sound_cleanup):
1587 * xdisp.c (unwind_redisplay):
1588 * xfns.c (clean_up_dialog):
1589 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
1590 Accept no args and return void, instead of accepting and returning
1591 a dummy Lisp_Object. All uses changed.
1592 * cygw32.c (fchdir_unwind):
1593 * fileio.c (close_file_unwind):
1594 * keyboard.c (restore_kboard_configuration):
1595 * lread.c (readevalllop_1):
1596 * process.c (wait_reading_process_output_unwind):
1597 Accept int and return void, rather than accepting an Emacs integer
1598 and returning a dummy object. In some cases this fixes an
1599 unlikely bug when the corresponding int is outside Emacs integer
1600 range. All uses changed.
1601 * dired.c (directory_files_internal_unwind):
1602 * fileio.c (do_auto_save_unwind):
1603 * gtkutil.c (pop_down_dialog):
1604 * insdel.c (reset_var_on_error):
1605 * lread.c (load_unwind):
1606 * xfns.c (clean_up_file_dialog):
1607 * xmenu.c, nsmenu.m (pop_down_menu):
1608 * xmenu.c (cleanup_widget_value_tree):
1609 * xselect.c (wait_for_property_change_unwind):
1610 Accept pointer and return void, rather than accepting an Emacs
1611 save value encapsulating the pointer and returning a dummy object.
1612 All uses changed.
1613 * editfns.c (Fformat): Update the saved pointer directly via
1614 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
1615 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
1616 (unwind_body): New function.
1617 (record_unwind_protect): First arg is now a function returning void,
1618 not a dummy Lisp_Object.
1619 (record_unwind_protect_ptr, record_unwind_protect_int)
1620 (record_unwind_protect_void): New functions.
1621 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
1622 * fileio.c (struct auto_save_unwind): New type.
1623 (do_auto_save_unwind): Use it.
1624 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
1625 * insdel.c (struct rvoe_arg): New type.
1626 (reset_var_on_error): Use it.
1627 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
1628 New constants.
1629 (specbinding_func): Remove; there are now several such functions.
1630 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
1631 (set_unwind_protect_ptr): New function.
1632 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
1633
4e604a5d
PE
1634 Be simpler and more consistent about reporting I/O errors.
1635 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1636 Say "Read error" and "Write error", rather than "I/O error", or
1637 "IO error reading", or "IO error writing", when a read or write
1638 error occurs.
1639 * process.c (Fmake_network_process, wait_reading_process_output)
1640 (send_process, Fprocess_send_eof, wait_reading_process_output):
1641 Capitalize diagnostics consistently. Put "failed foo" at the
1642 start of the diagnostic, so that we don't capitalize the
1643 function name "foo". Consistently say "failed" for such
1644 diagnostics.
1645 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
1646 All callers changed. This is so it can use report_file_error.
1647 * sysdep.c (serial_open, serial_configure): Capitalize I/O
1648 diagnostics consistently as above.
1649
a9757f6a
PE
1650 * fileio.c (report_file_errno): Fix errno reporting bug.
1651 If the file name is neither null nor a pair, package it up as a
1652 singleton list. All callers changed, both to this function and to
1653 report_file_error. This fixes a bug where the memory allocator
1654 invoked by list1 set errno so that the immediately following
1655 report_file_error reported the wrong errno value.
1656
c43843aa
PE
1657 Fix minor problems found by --enable-gcc-warnings.
1658 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
1659 * keyboard.c (kbd_buffer_get_event): Remove unused local.
1660
18c26d81
JD
16612013-07-16 Jan Djärv <jan.h.d@swipnet.se>
1662
1663 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
1664 Set event->arg to Qt if switch-event shall be generated.
1665 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
1666
1667 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
1668
1669 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
1670 FOCUS_OUT_EVENT.
1671
1672 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
1673 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
1674 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
1675 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
44e18199 1676 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
18c26d81
JD
1677 and there is a focused frame.
1678 (head_table): Add focus-in and focus-out.
1679 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
1680 bind to handle-focus-in/out.
1681
1682 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
1683 (Fhandle_switch_frame): Call Fhandle_focus_in.
1684 (syms_of_frame): defsubr handle-focus-in/out.
1685
6c6f1994
PE
16862013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1687
c7ddc792
PE
1688 Fix porting bug to older POSIXish platforms (Bug#14862).
1689 * sysdep.c (emacs_pipe): New function, that implements
1690 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
1691 This should port better to CentOS 5 and to Mac OS X 10.6.
1692 All calls to pipe2 changed.
1693
6c6f1994
PE
1694 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
1695 This makes the code easier to read and the executable a bit smaller.
1696 Do not replace all calls to Fcons that happen to create lists,
1697 just calls that are intended to create lists. For example, when
1698 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
1699 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
1700 Similarly for list2 through list5.
1701 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1702 * bytecode.c (exec_byte_code):
1703 * callint.c (quotify_arg, Fcall_interactively):
1704 * callproc.c (Fcall_process, create_temp_file):
1705 * charset.c (load_charset_map_from_file)
1706 (Fdefine_charset_internal, init_charset):
1707 * coding.c (get_translation_table, detect_coding_system)
1708 (Fcheck_coding_systems_region)
1709 (Fset_terminal_coding_system_internal)
1710 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
1711 * composite.c (update_compositions, Ffind_composition_internal):
1712 * dired.c (directory_files_internal, file_name_completion)
1713 (Fsystem_users):
1714 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
1715 * doc.c (Fsnarf_documentation):
1716 * editfns.c (Fmessage_box):
1717 * emacs.c (main):
1718 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
1719 (Feval, eval_sub, Ffuncall, apply_lambda):
1720 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
1721 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
1722 (Fset_file_times, Finsert_file_contents)
1723 (Fchoose_write_coding_system, Fwrite_region):
1724 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
1725 * font.c (font_registry_charsets, font_parse_fcname)
1726 (font_prepare_cache, font_update_drivers, Flist_fonts):
1727 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
1728 * frame.c (make_frame, Fmake_terminal_frame)
1729 (x_set_frame_parameters, x_report_frame_params)
1730 (x_default_parameter, Fx_parse_geometry):
1731 * ftfont.c (syms_of_ftfont):
1732 * image.c (gif_load):
1733 * keyboard.c (command_loop_1):
1734 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
1735 (Fcopy_keymap, append_key, Fcurrent_active_maps)
1736 (Fminor_mode_key_binding, accessible_keymaps_1)
1737 (Faccessible_keymaps, Fwhere_is_internal):
1738 * lread.c (read_emacs_mule_char):
1739 * menu.c (find_and_return_menu_selection):
1740 * minibuf.c (get_minibuffer):
1741 * nsfns.m (Fns_perform_service):
1742 * nsfont.m (ns_script_to_charset):
1743 * nsmenu.m (ns_popup_dialog):
1744 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
1745 (Fx_own_selection_internal):
1746 * nsterm.m (append2):
1747 * print.c (Fredirect_debugging_output)
1748 (print_prune_string_charset):
1749 * process.c (Fdelete_process, Fprocess_contact)
1750 (Fformat_network_address, set_socket_option)
1751 (read_and_dispose_of_process_output, write_queue_push)
1752 (send_process, exec_sentinel):
1753 * sound.c (Fplay_sound_internal):
1754 * textprop.c (validate_plist, add_properties)
1755 (Fput_text_property, Fadd_face_text_property)
1756 (copy_text_properties, text_property_list, syms_of_textprop):
1757 * unexaix.c (report_error):
1758 * unexcoff.c (report_error):
1759 * unexsol.c (unexec):
1760 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
1761 (Fformat_mode_line, syms_of_xdisp):
1762 * xfaces.c (set_font_frame_param)
1763 (Finternal_lisp_face_attribute_values)
1764 (Finternal_merge_in_global_face, syms_of_xfaces):
1765 * xfns.c (x_default_scroll_bar_color_parameter)
1766 (x_default_font_parameter, x_create_tip_frame):
1767 * xfont.c (xfont_supported_scripts):
1768 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
1769 (menu_help_callback, xmenu_show):
1770 * xml.c (make_dom):
1771 * xterm.c (set_wm_state):
1772 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
1773 and similarly for list2 through list5.
1774
bafe80ce
PE
17752013-07-15 Paul Eggert <eggert@cs.ucla.edu>
1776
1777 * callproc.c (Fcall_process_region): Fix minor race and tune.
1778 (create_temp_file): New function, with the temp-file-creation part
1779 of the old Fcall_process_region. Use Fcopy_sequence to create the
1780 temp file name, rather than alloca + build_string, for simplicity.
1781 Don't bother to block input around the temp file creation;
1782 shouldn't be needed. Simplify use of mktemp. Use
1783 record_unwind_protect immediately after creating the temp file;
1784 this closes an unlikely race where the temp file was not removed.
1785 Use memcpy rather than an open-coded loop.
1786 (Fcall_process_region): Use the new function. If the input is
1787 empty, redirect from /dev/null rather than from a newly created
1788 empty temp file; this avoids unnecessary file system traffic.
1789
4700b5a5
PE
17902013-07-14 Paul Eggert <eggert@cs.ucla.edu>
1791
5c97beae
PE
1792 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
1793 Simplify by making this case like the other two. This is a bit
1794 slower on obsolete hosts, but the extra complexity isn't worth it.
1795
4700b5a5
PE
1796 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
1797 * process.c (create_process) [!DOS_NT]:
1798 Remove now-unnecessary calls to emacs_close.
1799
f9a74c4c
EZ
18002013-07-13 Eli Zaretskii <eliz@gnu.org>
1801
922ae7ee
EZ
1802 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
1803 returning early. (Bug#14850)
1804
f9a74c4c
EZ
1805 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
1806 and inhibit-iso-escape-detection attributes of 'undecided'.
1807 (Bug#14822)
1808
5e301d76
PE
18092013-07-13 Paul Eggert <eggert@cs.ucla.edu>
1810
69e0e5ee
PE
1811 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
1812 Reported by Herbert J. Skuhra in
1813 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
1814
5e301d76
PE
1815 Don't lose top specpdl entry when memory is exhausted.
1816 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
1817 specpdl overflow here, to simplify callers; all callers changed.
1818 Always reserve an unused entry at the stack top; this avoids
1819 losing the top entry's information when memory is exhausted.
1820
7e649856
PE
18212013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1822
a773ed9a
PE
1823 Clean up errno reporting and fix some errno-reporting bugs.
1824 * callproc.c (Fcall_process):
1825 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1826 * process.c (create_process, Fmake_network_process):
1827 * unexaix.c (report_error):
1828 * unexcoff.c (report_error):
1829 Be more careful about reporting the errno of failed operations.
1830 The code previously reported the wrong errno sometimes.
1831 Also, prefer report_file_errno to setting errno + report_file_error.
1832 (Fcall_process): Look at openp return value rather than at path,
1833 as that's a bit faster and clearer when there's a numeric predicate.
1834 * fileio.c (report_file_errno): New function, with most of the
1835 old contents of report_file_error.
1836 (report_file_error): Use it.
1837 (Ffile_exists_p, Ffile_accessible_directory_p):
1838 Set errno to 0 when it is junk.
1839 * fileio.c (Faccess_file):
1840 * image.c (x_create_bitmap_from_file):
1841 Use faccessat rather than opening the file, to avoid the hassle of
1842 having a file descriptor open.
1843 * lisp.h (report_file_errno): New decl.
1844 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
1845
7e649856
PE
1846 Minor EBADF fixes.
1847 * process.c (create_process, wait_reading_process_output) [AIX]:
1848 Remove obsolete SIGHUP-related code, as Emacs no longer disables
1849 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
1850 a multithreaded environment anyway).
1851 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
1852
f6774c1a
AS
18532013-07-12 Andreas Schwab <schwab@linux-m68k.org>
1854
1855 * image.c (x_find_image_file): Don't close a remote file handle.
1856
bacba3c2
PE
18572013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1858
1859 Fix races with threads and file descriptors.
1860 * callproc.c (Fcall_process_region):
1861 * dired.c (open_directory):
1862 * emacs.c (main, Fdaemon_initialized):
1863 * image.c (x_find_image_file):
1864 * inotify.c (Finotify_rm_watch):
1865 * lread.c (Flocate_file_internal):
1866 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
1867 * term.c (term_mouse_moveto, init_tty):
1868 * termcap.c (tgetent):
1869 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
1870 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
1871 * unexhp9k800.c, unexmacosx.c (unexec):
1872 * callproc.c (Fcall_process_region):
1873 Use emacs_close, not close.
1874 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
1875 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
1876 and posix_close function on current platforms (which all lack them).
1877 (emacs_close): Use it. This should fix the races on GNU/Linux and
1878 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
1879 and it should avoid closing random victim file descriptors on
1880 other platforms.
1881
653d4f43
PE
18822013-07-11 Paul Eggert <eggert@cs.ucla.edu>
1883
c8536ec4
PE
1884 * inotify.c (uninitialized): Remove. All uses replaced by -1.
1885 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
1886 Touch up doc a bit.
1887
9c203066
PE
1888 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
1889 This is for .gdbinit xbacktrace.
1890
653d4f43
PE
1891 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
1892 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
1893 (emacs_set_tty): Now static.
1894 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
1895 * term.c (tty_capable_p, tty_default_color_capabilities)
1896 (get_tty_terminal, term_mouse_movement)
1897 (handle_one_term_event, init_tty, maybe_fatal):
1898 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
1899 (tgetent, scan_file, name_match, compare_contin):
1900 * terminal.c (get_terminal):
1901 Use bool for boolean.
1902 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
1903 Prefer char to unsigned char if either will do.
1904 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
1905 (tty_write_glyphs): Prefer int to unsigned.
1906 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
1907 All callers changed.
1908 * termcap.c (tprint, main) [TEST]: Remove non-working test.
1909
45b683a1
PE
19102013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1911
29abe551
PE
1912 Port to C89.
1913 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
1914 (B__dummy__): New dummy symbol, to pacify C89.
1915 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
1916 they can't grok varargs macros.
1917 * dispnew.c (add_window_display_history)
1918 (add_frame_display_history):
1919 * print.c (print_object):
1920 * xdisp.c (debug_method_add):
1921 Use %p printf format only for void pointers.
1922 * emacs.c (usage_message): New constant, replacing ...
1923 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
1924 (main): Adjust to usage reorg.
1925 * fns.c (syms_of_fns):
1926 * profiler.c (syms_of_profiler):
1927 Don't use non-constant struct initializers.
1928 * gnutls.h (gnutls_initstage_t):
1929 * lisp.h (enum Lisp_Fwd_Type):
1930 * lread.c (lisp_file_lexically_bound_p):
1931 * xsettings.c (anonymous enum):
1932 Remove trailing comma.
1933 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
1934 * lisp.h (ENUM_BF): Use unsigned if pedantic.
1935 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
1936 (DEFUN): Use it.
1937 * regex.c (const_re_char): New type, to pacify strict C89.
1938 All uses of 'const re_char' replaced to use it.
1939 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
1940 with glibc when strict C89. This change is imported from gnulib.
1941 All uses changed.
1942 (_Restrict_arr_): Rename from __restrict_arr, similarly.
1943 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
1944 Omit GNU_LINUX implementation, since it requires long long.
1945 * xterm.c (x_draw_underwave):
1946 Do not assume the traditional order of struct's members.
1947 (x_term_init): Rewrite to avoid the need for non-constant structure
1948 initializers.
1949
45b683a1 1950 Syntax cleanup, mostly replacing macros with functions.
763a086d 1951 This removes the need for the syntax_temp hack.
45b683a1
PE
1952 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
1953 * syntax.c (SYNTAX_INLINE): New macro.
1954 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
1955 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
1956 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
1957 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
1958 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
1959 (SYNTAX_COMEND_FIRST): Now functions, not macros.
1960 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
1961 Now constants, not macros.
1962 (syntax_temp) [!__GNUC__]: Remove.
1963 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
1964 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
1965 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
1966 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
1967 Move here from syntax.h; now functions, not macros. Except for the
1968 last function, these are static since only syntax.c uses them.
1969 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
1970 All uses changed. Now a function, not a macro; use this fact
1971 to simplify the code.
1972 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
1973 compiler bugs; no longer relevant.
1974 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1975 (SYNTAX_INLINE): New macro.
1976 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
1977 for the new functions. Use bool for boolean member.
1978 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
1979 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
1980 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
1981 (SETUP_BUFFER_SYNTAX_TABLE):
1982 Now extern inline functions, not macros.
1983 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
1984 Remove; all uses replaced by implementation.
1985 (syntax_temp) [!__GNUC__]: Remove decl.
1986 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
1987
29be4a50
JD
19882013-07-10 Jan Djärv <jan.h.d@swipnet.se>
1989
1990 * emacs.c (main): Fix syntax error.
1991
954b166e
PE
19922013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1993
1994 Timestamp fixes for undo (Bug#14824).
1995 * atimer.c (schedule_atimer):
1996 * fileio.c (Ffile_newer_than_file_p):
1997 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
1998 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
1999 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
2000 (syms_of_fileio): Remove Sclear_visited_file_name.
2001 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
2002 file doesn't exist; this avoids an ambiguity with negative timestamps.
2003 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
2004 * systime.h (make_emacs_time, invalid_emacs_time):
2005 Don't assume struct timespec layout; POSIX doesn't guarantee it.
2006 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
2007 * undo.c (record_first_change): Push (visited-file-modtime) onto
2008 undo list rather than reimplementing it by hand, incorrectly.
2009
d74647c3
KB
20102013-07-09 Ken Brown <kbrown@cornell.edu>
2011
2012 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
2013
3c51b96b
JB
20142013-07-09 Juanma Barranquero <lekktu@gmail.com>
2015
2016 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
2017
4ebbdd67
PE
20182013-07-09 Paul Eggert <eggert@cs.ucla.edu>
2019
2020 Handle errno and exit status a bit more carefully.
2021 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
2022 number into an exit status. Instead, use EXIT_CANCELED.
2023 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
2024 * callproc.c (relocate_fd):
2025 * emacs.c (close_output_streams, main):
2026 * process.c (create_process):
2027 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
2028 Use emacs_perror for simplicity.
2029 * callproc.c (relocate_fd, main):
2030 * sysdep.c (sys_subshell):
2031 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
2032 (shut_down_emacs): Use emacs_write, not write.
2033 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
2034 * fileio.c (Fcopy_file, e_write):
2035 * nsterm.m (ns_select):
2036 * process.c (send_process):
2037 * sound.c (vox_write):
2038 Use emacs_write_sig, not emacs_write.
2039 * lisp.h (emacs_write_sig, emacs_perror): New decls.
2040 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
2041 New constants.
2042 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
2043 of write.
2044 (emacs_full_write): New function.
2045 (emacs_write): Rewrite to use it.
2046 (emacswrite_sig, emacs_perror): New functions.
2047 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
2048
44e18199 20492013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
e4b1e5af
JD
2050
2051 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
2052 on NS even if it is present. Pixmap on NS is a void*.
2053
9caab067
PE
20542013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2055
2056 Port to Ubuntu 10 (Bug#14803).
2057 Problem reported by T.V. Raman.
2058 * process.c (close_on_exec, accept4, process_socket):
2059 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
2060
1d442672
EZ
20612013-07-07 Eli Zaretskii <eliz@gnu.org>
2062
2063 * w32.c (sys_dup): Declare prototype.
2064
2065 * filelock.c:
2066 * emacs.c:
2067 * callproc.c [WINDOWSNT]: Include sys/socket.h.
2068
067428c1
PE
20692013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2070
2071 Make file descriptors close-on-exec when possible (Bug#14803).
2072 This simplifies Emacs a bit, since it no longer needs to worry
2073 about closing file descriptors by hand in some cases.
2074 It also fixes some unlikely races. Not all such races, as
2075 libraries often open files internally without setting
2076 close-on-exec, but it's an improvement.
2077 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
2078 * callproc.c (Fcall_process) [!MSDOS]:
2079 * emacs.c (main) [!DOS_NT]:
2080 * nsterm.m (ns_term_init):
2081 * process.c (create_process):
2082 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
2083 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
2084 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
2085 Prefer mkostemp with O_CLOEXEC to mkstemp.
2086 * callproc.c (relocate_fd) [!WINDOWSNT]:
2087 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
2088 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
2089 now using pipe2.
2090 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
2091 Make the resulting file descriptor close-on-exec.
2092 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
2093 * lread.c (load_descriptor_list, load_descriptor_unwind):
2094 Remove; no longer needed. All uses removed.
2095 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
2096 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
2097 New functions.
2098 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
2099 (Fmake_network_process, Fnetwork_interface_list):
2100 (Fnetwork_interface_info, server_accept_connection):
2101 Make newly-created socket close-on-exec.
2102 * sysdep.c (emacs_open, emacs_fopen):
2103 Make new-created descriptor close-on-exec.
2104 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
2105 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
2106
0da857dd
JD
21072013-07-07 Jan Djärv <jan.h.d@swipnet.se>
2108
2109 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
2110 for NS_IMPL_GNUSTEP.
2111
5f86adcd
PE
21122013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2113
2114 Fix openp errno handling.
2115 * callproc.c (Fcall_process): Preserve openp errno around close.
2116 * lread.c (openp): Set errno when returning -1, as some callers
2117 expect this.
2118
1afb1d07
JD
21192013-07-06 Jan Djärv <jan.h.d@swipnet.se>
2120
2121 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
2122
2123 * nsterm.h (NSSavePanel): Update comment.
2124 (NSAPP_DATA2_RUNFILEDIALOG): Define.
2125 (ns_run_file_dialog): Declare.
2126
2127 * nsfns.m: Remove panelOK.
2128 (ns_fd_data): New.
2129 (ns_run_file_dialog): New function.
2130 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
2131 event loop, so file dialog is popped up by ns_run_file_dialog, called
2132 by sendEvent (Bug#14578).
2133 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
2134
3323c263
EZ
21352013-07-06 Eli Zaretskii <eliz@gnu.org>
2136
fdda0220
EZ
2137 * xdisp.c (default_line_pixel_height): New function.
2138 (pos_visible_p, move_it_vertically_backward, try_scrolling)
2139 (try_cursor_movement, redisplay_window, try_window)
2140 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
2141
2142 * window.c (window_scroll_pixel_based): use
2143 default_line_pixel_height.
2144
2145 * dispextern.h (default_line_pixel_height): Add prototype.
2146
2147 * frame.c (x_set_line_spacing): Accept a float value for
2148 line-spacing parameter, per the documentation.
2149
3323c263
EZ
2150 * data.c (Fmultibyte_string_p): Doc fix.
2151
47ba6d43
PE
21522013-07-05 Paul Eggert <eggert@cs.ucla.edu>
2153
406af475
PE
2154 Use emacs_open more consistently when opening files.
2155 This handles EINTR more consistently now, and makes it easier
2156 to introduce other uniform changes to file descriptor handling.
2157 * src/systdio.h: New file.
2158 * src/buffer.c (mmap_init):
2159 * cygw32.c (chdir_to_default_directory):
2160 * dispnew.c (Fopen_termscript):
2161 * emacs.c (Fdaemon_initialized):
2162 * fileio.c (Fdo_auto_save):
2163 * image.c (slurp_file, png_load_body, jpeg_load_body):
2164 * keyboard.c (Fopen_dribble_file):
2165 * lread.c (Fload):
2166 * print.c (Fredirect_debugging_output):
2167 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
2168 * termcap.c (tgetent):
2169 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
2170 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
2171 * w32term.c (w32_initialize) [CYGWIN]:
2172 * xfaces.c (Fx_load_color_file):
2173 Use emacs_open instead of plain open, and emacs_fopen instead of
2174 plain fopen.
2175 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
2176 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
2177 * callproc.c (default_output_mode): New constant.
2178 (Fcall_process): Use it to call emacs_open instead of plain creat.
2179 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
2180 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
2181 (emacs_fopen): New function.
2182 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
2183 Include <lisp.h>, for emacs_open.
2184 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
2185
47ba6d43
PE
2186 Remove duplicate #include directives.
2187 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
2188 * xfaces.c:
2189 Don't include stdio.h twice.
2190 * buffer.c [USE_MMAP_FOR_BUFFERS]:
2191 Don't include sys/types.h or stdio.h twice.
2192 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
2193 * lread.c: Don't include coding.h twice.
2194 * nsfont.m: Don't include frame.h twice.
2195 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
2196 * ralloc.c: Don't include <unistd.h> twice.
2197 * xdisp.c: Don't include font.h twice.
2198 * xterm.c: Don't include fontset.h twice.
2199 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
2200
b9ed53d5
PE
22012013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2202
2203 Scale ImageMagick images more carefully.
2204 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
2205 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
2206 Be more careful about avoiding undefined behavior after
2207 integer overflow and division by zero.
2208
cf13177e
YM
22092013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2210
2211 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
2212 (syms_of_w32fns): DEFSYM them.
2213 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
2214 (CCHDEVICENAME): Define macros if not defined.
2215 (struct MONITOR_INFO_EX): New struct.
2216 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
2217 (enum_display_monitors_fn): New variable.
2218 (globals_of_w32fns): Initialize it.
2219 (Fx_display_pixel_width, Fx_display_pixel_height)
2220 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
2221 multi-monitor setups in docstrings.
2222 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
2223 screen size by primary monitor's millimeter per pixel.
2224 (w32_monitor_enum, w32_display_monitor_attributes_list)
2225 (w32_display_monitor_attributes_list_fallback)
2226 (Fw32_display_monitor_attributes_list): New functions.
2227 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
2228
2229 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
2230 if not defined.
2231 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
2232
86dfb7a8
MA
22332013-07-04 Michael Albinus <michael.albinus@gmx.de>
2234
2235 * fileio.c (Qfile_notify_error): New error symbol.
2236
2237 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
2238 * inotify.c (inotify_callback, symbol_to_inotifymask)
2239 (Finotify_add_watch, Finotify_rm_watch): Use it.
2240 (inotifyevent_to_event): Exchange order of cookie and file name.
2241 (Finotify_add_watch): Adapt docstring.
2242
2243 * lisp.h (Qfile_notify_error): Declare.
2244
2c1c974b
PE
22452013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2246
2247 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
2248 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2249 Do not clear _malloc_thread_enabled_p, undoing the previous change,
2250 which did not work (see <http://bugs.gnu.org/14569#307>).
2251 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
2252 && (!noninteractive || initialized)). This attempts to thread
2253 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
2254
7a35b20f
JB
22552013-07-04 Juanma Barranquero <lekktu@gmail.com>
2256
2257 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
2258 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
2259
1ce5cd04
PE
22602013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2261
2262 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
2263 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2264 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
2265 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
2266
57f8c490
PE
22672013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2268
2269 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
2270 Define to __sys_siglist.
2271
bcffb5ca
EZ
22722013-07-02 Eli Zaretskii <eliz@gnu.org>
2273
2274 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
2275 word-wrap, so that overflow-newline-into-fringe would work in
2276 visual-line-mode. (Bug#2749)
2277 (move_it_in_display_line_to): When the last scanned display
2278 element fits exactly on the display line, and
2279 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
2280 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
2281 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
2282 finding buffer position that corresponds to pixel coordinates,
2283 e.g. in buffer_posn_from_coords.
2284
2c41e781
JD
22852013-07-02 Jan Djärv <jan.h.d@swipnet.se>
2286
2287 * process.c (handle_child_signal): Call catch_child_signal if
2288 NS_IMPL_GNUSTEP.
2289
c2418359
PE
22902013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2291
52a9bcae
PE
2292 Don't convert function pointers to void * and back.
2293 It isn't portable C, and it's easy enough to avoid.
2294 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
2295 (make_save_value): Add support for SAVE_FUNCPOINTER.
2296 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
2297 * print.c (print_object):
2298 Distinguish function from object pointers.
2299 * lisp.h (SAVE_FUNCPOINTER): New constant.
2300 (SAVE_SLOT_BITS): Adjust to it.
2301 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
2302 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
2303 (voidfuncptr): New typedef.
2304 (struct Lisp_Save_Value): New member data[0].funcpointer.
2305 (XSAVE_FUNCPOINTER): New function.
2306
c2418359
PE
2307 Simplify buildobj processing.
2308 * Makefile.in (buildobj.h): Make it a sequence of strings each
2309 followed by comma, rather than a single string. Put it into a
2310 .tmp file in case there's an error while generating it.
2311 (gl-stamp): Use .tmp for temp files.
2312 (mostlyclean): Clean .tmp files.
2313 * doc.c (buildobj): Move to just the routine that needs it.
2314 It's now an array of strings, so processing is simpler.
2315
8f43ce49
PE
23162013-07-01 Paul Eggert <eggert@cs.ucla.edu>
2317
2318 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
2319 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
2320 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2321 Invoke malloc_enable_thread even when not interactive.
2322 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
2323 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
2324 in this case, since the underlying bug has now been fixed.
2325
24827db9
JB
23262013-07-01 Juanma Barranquero <lekktu@gmail.com>
2327
2328 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
2329 unlinking it (bug#14691).
2330
ef099a94
MN
23312013-06-30 Michal Nazarewicz <mina86@mina86.com>
2332
2333 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
2334 before checking whether buffer is modified. This lets
2335 `kill-buffer-query-functions' cancel killing of the buffer or save
2336 its content before `kill-buffer' asks user the "Buffer %s
2337 modified; kill anyway?" question.
2338
9d3f2fc2
JD
23392013-06-30 Jan Djärv <jan.h.d@swipnet.se>
2340
2341 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
2342 Let the super performKeyEquivalent deal with them (Bug#14747).
2343
e6c6c8c7
PE
23442013-06-30 Paul Eggert <eggert@cs.ucla.edu>
2345
1d71c1d9
PE
2346 * widget.c (resize_cb): Remove unused local.
2347
8f5f35cc
PE
2348 Do not use GTK 3 if it exists but cannot be compiled.
2349 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
2350 * xterm.c (x_error_handler) [!USE_GTK]:
2351 Do not use GTK 3.
2352
e6c6c8c7
PE
2353 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
2354
0ba54312
EZ
23552013-06-30 Eli Zaretskii <eliz@gnu.org>
2356
5d1c3286
EZ
2357 * intervals.c (get_local_map): Instead of aborting, clip POSITION
2358 to the valid range of values. (Bug#14753)
2359
0ba54312
EZ
2360 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
2361 when moving point by using the current glyph matrix. This avoids
2362 the need to force redisplay when this function is called in a
2363 loop.
2364
9c90cc06
PE
23652013-06-29 Paul Eggert <eggert@cs.ucla.edu>
2366
2367 Fix minor problems found by static checking.
2368 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
2369 Redo the latter's body to sidestep GCC parenthesization warnings.
2370 (setup_coding_system, detect_coding, detect_coding_system): Use them.
2371 * coding.c (detect_coding, detect_coding_system):
2372 * coding.h (struct undecided_spec):
2373 Use bool for boolean.
2374 * image.c (QCmax_width, QCmax_height): Now static.
2375 * xdisp.c (Fmove_point_visually): Remove unused local.
2376
4c672a0f
EZ
23772013-06-29 Eli Zaretskii <eliz@gnu.org>
2378
2379 * xdisp.c (Fmove_point_visually): New function.
2380
c1ea3abf
JB
23812013-06-28 Kenichi Handa <handa@gnu.org>
2382
2383 * coding.h (define_coding_undecided_arg_index): New enum.
2384 (coding_attr_index): New members
2385 coding_attr_undecided_inhibit_null_byte_detection,
2386 coding_attr_undecided_inhibit_iso_escape_detection,
2387 coding_attr_undecided_prefer_utf_8.
2388 (undecided_spec): New struct.
2389 (struct coding_system): New member `undecided' of the member
2390 `spec'.
2391
2392 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
2393 (detect_coding): Likewise.
2394 (detect_coding_system): Likewise.
2395 (Fdefine_coding_system_internal): New coding system properties
2396 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
2397 :prefer-utf-8.
2398 (syms_of_coding): Adjust for coding_arg_undecided_max.
2399
ba3de9e6
PE
24002013-06-28 Paul Eggert <eggert@cs.ucla.edu>
2401
2402 * image.c (x_from_xcolors): Remove unused local.
2403
547c9269
YM
24042013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2405
2406 Defer image data transfer between X client and server until actual
2407 display happens.
2408
2409 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
2410 and `mask_img'.
2411
2412 * image.c (Destroy_Image): Remove.
2413 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
2414 `mask_p', and `colors_p'. All uses changed.
2415 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
2416 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
2417 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
2418 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
2419 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 2420 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
2421 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
2422 (image_get_x_image, image_unget_x_image): New functions or macros.
2423 (image_background, image_background_transparent, x_to_xcolors)
2424 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
2425 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
2426 instead of Destroy_Image.
2427 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
2428 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
2429 (png_load_body, jpeg_load_body, tiff_load, gif_load)
2430 (imagemagick_load_image, svg_load_image): Use them instead of
2431 x_create_x_image_and_pixmap, and x_put_x_image followed by
2432 x_destroy_x_image, respectively.
2433 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
2434 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
2435 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
2436 background_transparent fields.
2437 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
2438 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
2439
dae2f5ef
PE
24402013-06-27 Paul Eggert <eggert@cs.ucla.edu>
2441
2442 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
2443 This mostly consists of undoing recent changes.
2444 * callproc.c (Fcall_process):
2445 * process.c (create_process):
2446 Do not worry about catching SIGCHLD here, undoing previous change.
2447 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
2448 * process.c, process.h (catch_child_signal):
2449 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
2450 * process.c (catch_child_handler): Don't worry about being called
2451 lazily and do not assume caller has blocked SIGCHLD, undoing
2452 previous change. Move first-time stuff back to
2453 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
2454 tickle glib, as that causes Cygwin bootstrap to fail. Do not
2455 set lib_child_handler if it's already initialized, which may
2456 help avoid problems on GNUStep.
2457
fa55d2aa
PE
24582013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2459
2460 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
2461 * callproc.c (Fcall_process):
2462 * process.c (create_process):
2463 Make sure SIGCHLD is caught before we fork,
2464 since Emacs startup no arranges to catch SIGCHLD.
2465 * process.c (lib_child_handler): Initialize to null, not to
2466 dummy_handler.
2467 (catch_child_signal): Allow self to be called lazily.
2468 Do nothing if it's already been called.
2469 Assume caller has blocked SIGCHLD (all callers do now).
2470 * emacs.c (main): Do not catch SIGCHLD here; defer it until
2471 just before it's really needed.
2472 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
2473 since it hasn't been caught yet.
2474
f3f9606c
LMI
24752013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
2476
2477 * image.c (compute_image_size): New function to implement
2478 :max-width and :max-height.
2479 (imagemagick_load_image): Use it.
2480
c7041908
PE
24812013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2482
2483 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
2484 * callproc.c, process.h (block_child_signal, unblock_child_signal):
2485 Now extern.
2486 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
2487 * process.c (catch_child_signal): Block SIGCHLD while futzing with
2488 the SIGCHLD handler, since the code is not atomic and (due to glib)
2489 signals may be arriving now.
2490 * sysdep.c (init_signals): Do not catch child signals here;
2491 'main' now does that later, at a safer time.
2492
f86852b4
PE
24932013-06-22 Paul Eggert <eggert@cs.ucla.edu>
2494
0dfeed58
PE
2495 Clean up SIGCHLD handling a bit (Bug#14569).
2496 * process.c, process.h (catch_child_signal):
2497 Now always extern, even if !NS_IMPL_GNUSTEP.
2498 * process.c (catch_child_signal): Move glib tickler here from
2499 init_process_emacs, so that it's done earlier in Emacs
2500 initialization. Also move the noninteractive && !initialized
2501 check here from init_process_emacs. This is all a bit cleaner for
2502 GNUish platforms, and I hope it works around the Cygwin bug.
2503 * sysdep.c (init_signals): Invoke catch_child_signal here, so
2504 that glib signal handling is tickled before glib creates threads.
2505
f86852b4
PE
2506 * process.c (wait_reading_process_output): Avoid int overflow
2507 when reading more than 2 GiB total from a process.
2508
cbd6509c
PE
25092013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2510
2511 * process.c (create_process): Handle a couple more cases,
2512 i.e., work even if new_argv and wait_child_setup[i] are cached.
2513 Use Fcall_process's style for volatile vars.
2514
9de1114a
AS
25152013-06-21 Andreas Schwab <schwab@linux-m68k.org>
2516
2517 * process.c (create_process): Mark PROCESS volatile.
2518
fbe9e0b9
PE
25192013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2520
2521 Use C99-style flexible array members if available.
2522 This avoids some subtle aliasing issues, which typically
2523 aren't a problem with GCC but may be a problem elsewhere.
2524 * alloc.c (sdata): New typedef, replacing the old struct sdata.
2525 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
2526 In either case, it uses a flexible array member rather than
2527 the old struct hack. All uses changed.
2528 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
2529 Adjust to sdata reorganization.
2530 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
2531 Use offsetof (struct, flex_array_member), not sizeof (struct), as
2532 that ports better to pre-C99 non-GCC.
2533 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
2534 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
2535 as the latter has changed.
2536 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
2537 and port better to pre-C99 GCC.
2538 * image.c (struct xpm_cached_color):
2539 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
2540 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
2541 Use FLEXIBLE_ARRAY_MEMBER.
2542 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
2543 Move decl to top level so it gets checked against implementation.
2544 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
2545 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
2546
1fc71008
PE
25472013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2548
2549 * syntax.c: Integer cleanups.
2550 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
2551 All uses that need 0-or-2 changed to:
2552 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
2553 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
2554 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
2555 (char_quoted, prev_char_comend_first, back_comment)
2556 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2557 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
2558 Use bool for boolean.
2559 (update_syntax_table, skip_chars, skip_syntaxes):
2560 Prefer int to unsigned when either will do.
2561 (back_comment): Return boolean success flag, like forw_comment,
2562 instead of positive-or-minus-1 (which might have overflowed int anyway).
2563 Don't stuff ptrdiff_t into int.
2564 (syntax_spec_code, syntax_code_spec): Now const.
2565 (Fmatching_paren, scan_lists, scan_sexps_forward):
2566 Use enum syntaxcode for syntax code.
2567 (Fmatching_paren): Check that arg is a character, not just an integer.
2568 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
2569 (Finternal_describe_syntax_value): Omit no-longer-needed
2570 comparison to 0.
2571 (skip_chars): Use char, not unsigned char, when the distinction
2572 doesn't matter.
2573 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
2574 * bytecode.c (exec_byte_code):
2575 * syntax.c (syntax_spec_code, Fchar_syntax)
2576 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2577 (init_syntax_once):
2578 * syntax.h (SYNTAX_WITH_FLAGS):
2579 Omit unnecessary casts.
2580
b932cad7
EZ
25812013-06-20 Eli Zaretskii <eliz@gnu.org>
2582
2583 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
2584 line dimensions here, to avoid race conditions with the main
2585 thread. (Bug#14062, bug#14630, bug#14669)
2586
2587 * w32term.c (w32_draw_window_cursor): Compute the header line and
2588 mode line dimensions here.
2589 <w32_system_caret_window, w32_system_caret_hdr_height>:
2590 <w32_system_caret_mode_height>: New variables.
2591
2592 * w32term.h: Declare them.
2593
89561f72
PE
25942013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2595
5013fc08
PE
2596 * alloc.c (die): Move "assertion failed" string here ...
2597 * lisp.h (eassert): ... from here. Also, suppress evaluation of
2598 COND when SUPPRESS_CHECKING. This shrinks the executable text
2599 size by 0.8% to 2.2% when configured with --enable-checking,
2600 depending on optimization flags (GCC 4.8.1 x86-64).
2601
89561f72
PE
2602 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
2603
763a086d 26042013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
2605
2606 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
2607 base is 2; this is more accurate.
2608
983aeb9a
JB
26092013-06-19 Juanma Barranquero <lekktu@gmail.com>
2610
2611 * sound.c (string_default): Move to !WINDOWSNT section.
2612 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
2613
178ba3e6
PE
26142013-06-19 Paul Eggert <eggert@cs.ucla.edu>
2615
bbc51b15
PE
2616 * sound.c: Integer cleanups.
2617 Remove unnecessary forward decls.
2618 (struct sound_device): The 'file' member is now a Lisp_Object, not
2619 a char *, so that we needn't invoke alloca on a huge size.
2620 (Fplay_sound_internal): Adjust to this.
2621 (string_default): New function.
2622 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
2623 Use it to adjust to the struct sound_device change.
2624 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
2625 (be2hs) [0]: Remove.
2626
178ba3e6
PE
2627 * syntax.c (skip_chars): Don't use uninitialized storage
2628 when searching a multibyte buffer for characters that are not in a
2629 unibyte string that contains non-ASCII characters.
2630
69f60cdc
JD
26312013-06-18 Jan Djärv <jan.h.d@swipnet.se>
2632
2633 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
2634 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
2635
0d6224d4
PE
26362013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2637
2638 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
2639
3c542890
KH
26402013-06-18 Kenichi Handa <handa@gnu.org>
2641
f7e3f7cd
KH
2642 * font.c (Ffont_spec): Signal an error for an invalid font name
2643 (Bug#14648).
3c542890 2644
9349e5f7
PE
26452013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2646
2647 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
2648 In particular this ports to 32-bit sparc Sun cc.
2649 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
2650 array with a dummy element at specpdl[-1], so that its address can
2651 be taken portably.
2652 (unbind_to): Do not copy the binding; not needed, now that we
2653 copy old_value in the one place where the copy is needed.
2654 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
2655 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
2656 (union specbinding): Rename from struct specbinding. Redo layout
2657 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
2658 which is not portable. With Sun C 5.12 32-bit sparc, the
2659 declaration causes nargs to be an unsigned bitfield, a behavior
2660 that the C standard allows; but Emacs wants nargs to be signed.
2661 The overall type is now a union of structures rather than a
2662 structure of union of structures, and the 'kind' member is now a
2663 bitfield, so that the overall type doesn't grow. All uses changed.
2664 * process.c (Fmake_serial_process): Remove unnecessary initialization.
2665
0a4df6a5
PE
26662013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2667
ec6ecaad
PE
2668 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
2669 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
2670
0a4df6a5
PE
2671 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
2672
7bfe8dbc
EZ
26732013-06-17 Eli Zaretskii <eliz@gnu.org>
2674
2675 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
2676 unless we know that the window w's frame is a frame object.
2677 Another attempt at solving bug#14062 and bug#14630.
2678
708e05f6
LMI
26792013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
2680
2681 * textprop.c (property_set_type): New enum.
2682 (add_properties): Allow appending/prepending text properties.
2683 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 2684 (Fadd_text_properties): Move all the code into
708e05f6
LMI
2685 add_text_properties_1.
2686 (Fadd_face_text_property): New function that calls
2687 add_text_properties_1.
2688
84575e67
PE
26892013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2690
2691 Move functions from lisp.h to individual modules when possible.
2692 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
2693 * alloc.c (XFLOAT_INIT, set_symbol_name):
2694 * buffer.c (CHECK_OVERLAY):
2695 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
2696 (set_char_table_parent):
2697 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
2698 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
2699 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
2700 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
2701 (set_blv_valcell):
2702 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
2703 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
2704 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
2705 (backtrace_args, backtrace_debug_on_exit):
2706 * floatfns.c (CHECK_FLOAT):
2707 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
2708 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
2709 (set_hash_hash, set_hash_hash_slot, set_hash_index)
2710 (set_hash_index_slot):
2711 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
2712 * marker.c (CHECK_MARKER):
2713 * textprop.c (CHECK_STRING_OR_BUFFER):
2714 * window.c (CHECK_WINDOW_CONFIGURATION):
2715 Move here from lisp.h, and make these functions static rather than
2716 extern inline.
2717 * buffer.c (Qoverlayp):
2718 * data.c (Qsubrp):
2719 * fns.c (Qhash_table_p):
2720 * window.c (Qwindow_configuration_p):
2721 Now static.
2722 * lisp.h: Remove the abovementioned defns and decls.
2723
44e18199 2724 Use functions, not macros, for XINT etc (Bug#11935).
84575e67
PE
2725 In lisp.h, prefer functions to function-like macros, and
2726 constants to object-like macros, when either will do. This:
2727 . simplifies use, as there's no more need to worry about
2728 arguments' side effects being evaluated multiple times.
2729 . makes the code easier to debug on some platforms.
2730 However, when using gcc -O0, keep using function-like macros
2731 for a few critical operations, for performance reasons.
2732 This sort of thing isn't needed with gcc -Og, but -Og
2733 is a GCC 4.8 feature and isn't widely-enough available yet.
2734 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
2735 Remove enum lsb_bits; no longer needed.
2736 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
2737 * buffer.c (Qoverlap):
2738 * data.c (Qsubrp):
2739 * fns.c (Qhash_table_p):
2740 Now extern, so lisp.h can use these symbols.
2741 * dispextern.h: Include character.h, for MAX_CHAR etc.
2742 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2743 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2744 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2745 (GLYPH_CODE_P): Move here from lisp.h.
2746 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2747 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
2748 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
2749 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
2750 XUNTAG now returns void *.
2751 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
2752 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
2753 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
2754 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
2755 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
2756 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
2757 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
2758 (lisp_h_XPNTR, lisp_h_XSYMBOL):
2759 New macros, renamed from their sans-lisp_h_ counterparts.
2760 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
2761 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
2762 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
2763 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
2764 If compiling via GCC without optimization, define these as macros
2765 in addition to inline functions.
2766 To disable this, compile with -DINLINING=0.
2767 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
2768 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
2769 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
2770 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
2771 (INTMASK, VALMASK): Now macros, since static values cannot be
2772 accessed from extern inline functions.
2773 (VALMASK): Also a constant, for benefit of old GDB.
2774 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
2775 is INTEGERP, which can fold it in.
5165d44a 2776 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
2777 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
2778 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
2779 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
2780 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
2781 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
2782 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
2783 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
2784 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
2785 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
2786 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
2787 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
2788 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
2789 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
2790 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
2791 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
2792 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
2793 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
2794 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
2795 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
2796 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
2797 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
2798 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
2799 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
2800 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
2801 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
2802 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
2803 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
2804 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
2805 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
2806 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
2807 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
2808 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
2809 Now functions.
2810 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
2811 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
2812 (VALMASK): Define in one place rather than in two, merging the
2813 USE_LSB_TAG parts; this is simpler.
2814 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
2815 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
2816 Move up, to avoid use before definition.
2817 Also include "globals.h" earlier, for the same reason.
2818 (make_natnum): New function.
2819 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
2820 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
2821 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
2822 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
2823 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
2824 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
2825 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
2826 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
2827 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
2828 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
2829 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
2830 (Qwindow_configuration_p, Qimage): New forward declarations.
2831 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
2832 (STRING_COPYIN): Remove; unused.
2833 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
2834 (xcar_addr, xcdr_addr): New functions. All uses changed.
2835 (IEEE_FLOATING_POINT): Now a constant, not a macro.
2836 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2837 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2838 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2839 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
2840 (TYPE_RANGED_INTEGERP): Simplify.
2841 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
2842 (setlocale, fixup_locale, synchronize_system_messages_locale)
2843 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
2844 Now empty functions, not macros.
2845 (functionp): Return bool, not int.
2846 * window.c (Qwindow_configuration_p): Now extern,
2847 so window.h can use it.
2848 * window.h (Qwindowp): Move decl back to lisp.h.
2849
9583ec36
EZ
28502013-06-15 Eli Zaretskii <eliz@gnu.org>
2851
2852 * xdisp.c (Fline_pixel_height): New function, required for solving
2853 bug #14567.
2854
210272ce
PE
28552013-06-15 Paul Eggert <eggert@cs.ucla.edu>
2856
2857 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
2858
de0503df
SM
28592013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
2860
2861 * lread.c (syms_of_lread):
2862 * fns.c (Fprovide): Adjust to new format of after-load-alist.
2863
afbfe143
KD
28642013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
2865
2866 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
2867
d177e213
XF
28682013-06-12 Xue Fuqiao <xfq.free@gmail.com>
2869
2870 * fileio.c (expand_file_name): Doc fix.
2871
05e3e412
PE
28722013-06-11 Paul Eggert <eggert@cs.ucla.edu>
2873
f7394b12
PE
2874 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
2875 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
2876 Wait for self, not for 0. This can't hurt on GNU or similar
2877 system, and may help with Cygwin.
2878
05e3e412
PE
2879 * keyboard.c: Don't use PROP (...) as an lvalue.
2880 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
2881 Use set_prop (A, B), not PROP (A) = B.
2882
17dd3097
EZ
28832013-06-10 Eli Zaretskii <eliz@gnu.org>
2884
2885 * xdisp.c (get_it_property): Use it->window instead of generating
2886 a Lisp object from it->w.
2887
52fab9c9
EZ
28882013-06-09 Eli Zaretskii <eliz@gnu.org>
2889
2890 * xdisp.c (get_it_property): If it->object is a buffer, pass to
2891 get-char-property the window that is being rendered, instead of
2892 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
2893 (compute_display_string_pos): When W is NULL, use the current
2894 buffer as the object to pass to get-char-property.
2895 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
2896 pointer member of the bidi iterator, since no window is pertinent
2897 to this function.
52fab9c9 2898
5bf97bfc
EZ
28992013-06-08 Eli Zaretskii <eliz@gnu.org>
2900
2901 * bidi.c (bidi_fetch_char): Accept additional argument, the window
2902 being displayed, and pass it to compute_display_string_pos.
2903 (bidi_level_of_next_char, bidi_resolve_explicit_1)
2904 (bidi_paragraph_init): All callers changed.
2905
2906 * xdisp.c (init_from_display_pos, init_iterator)
2907 (handle_single_display_spec, next_overlay_string)
2908 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
2909 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
2910 Set bidi_it.w member from it->w.
5bf97bfc
EZ
2911 (compute_display_string_pos): Accept additional argument, the
2912 window being displayed, and pass it to Fget_char_property.
2913 (Bug#14575)
2914
2915 * dispextern.h (struct bidi_it): New member w, the window being
2916 displayed.
2917 (compute_display_string_pos): Adjust prototype.
2918
5de0e011
JD
29192013-06-08 Jan Djärv <jan.h.d@swipnet.se>
2920
e7b41c4c 2921 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
2922
2923 * process.c (wait_reading_process_output): Check for NS before GLIB.
2924 GLIB may be linked in due to rsvg, but ns_select must be called.
2925
5de0e011
JD
2926 * xgselect.c (xg_select): Remove call to window_system_available
2927 and g_main_context_pending at the top, so Gdk events (i.e. file
2928 notify) are processed when Emacs is started with -nw.
2929
a822acff
EZ
29302013-06-07 Eli Zaretskii <eliz@gnu.org>
2931
2932 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
2933 (ctagsfiles3): New variable, includes only *.m files.
2934 (TAGS): Use an explicit language name in the regular expressions,
2935 to avoid transformation of '/SOMETHING' by MSYS to
2936 'c:\MSYS\SOMETHING'.
2937
6c0a9ed1
RC
29382013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
2939
2940 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
2941
9ef6111b
EZ
29422013-06-06 Eli Zaretskii <eliz@gnu.org>
2943
2944 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
2945 still need to set the mouse pointer shape and activate help-echo.
2946 (Bug#14558)
2947
7d300d64
PE
29482013-06-06 Paul Eggert <eggert@cs.ucla.edu>
2949
2950 A few porting etc. fixes for the new file monitor code.
2951 See the thread containing
2952 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
2953 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
2954 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
2955 (dir_monitor_callback, Fgfile_rm_watch):
2956 Use assq_no_quit instead of Fassoc, for speed.
2957 (dir_monitor_callback, Fgfile_rm_watch):
2958 eassert that the monitor is a fixnum.
2959 (dir_monitor_callback): No need for CDR_SAFE.
2960 Simplify building of lisp with alternative tails.
2961 (Fgfile_add_watch, Fgfile_rm_watch):
2962 Do not assume glib functions set errno reliably on failure.
2963 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
2964 and signal an error otherwise.
2965 (Fgfile_rm_watch): Prefer CONSP to !NILP.
2966 Use Fdelq instead of Fdelete, for speed.
2967
817ebfcf
EZ
29682013-06-05 Eli Zaretskii <eliz@gnu.org>
2969
2970 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
2971 don't insist on being invoked on a highlighted tool-bar button.
2972 Avoids losing tool-bar functionality when mouse-highlight is nil.
2973 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
2974 Don't highlight when mouse-highlight is nil.
2975 (note_mouse_highlight): When mouse-highlight is nil, don't return
2976 right away; instead, run tool-bar and mode-line highlight
2977 subroutine, clear any existing highlight, and revert the mouse
2978 pointer to its default shape. (Bug#14558)
2979
55577e7c
SM
29802013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2981
2982 * lisp.mk (lisp): Add prog-mode.el.
2983
f019a684
PE
29842013-06-05 Paul Eggert <eggert@cs.ucla.edu>
2985
2986 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
2987 * process.c (dummy_handler): New function.
2988 (lib_child_handler): New static var.
2989 (handle_child_signal): Invoke it.
2990 (catch_child_signal): If a library has set up a signal handler,
2991 save it into lib_child_handler.
2992 (init_process_emacs): If using glib and not on Windows, tickle glib's
2993 child-handling code so that it initializes its private SIGCHLD handler.
2994 * syssignal.h (SA_SIGINFO): Default to 0.
2995 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
2996 31; it should no longer be needed now.
2997
90db8702
MA
29982013-06-05 Michael Albinus <michael.albinus@gmx.de>
2999
3000 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
3001
3002 * gfilenotify.c (globals_of_gfilenotify): New function.
3003 (syms_of_gfilenotify): Move global initialization there.
3004
3005 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
3006
bfa3acd6
SM
30072013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
3008
3009 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
3010 * keyboard.c (menu_bar_items, tool_bar_items):
3011 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
3012 not override local keymaps any more.
3013
ba59bd80
EZ
30142013-06-04 Eli Zaretskii <eliz@gnu.org>
3015
3016 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
3017
7f203aa1
EZ
30182013-06-03 Eli Zaretskii <eliz@gnu.org>
3019
9337e206
EZ
3020 * w32console.c (initialize_w32_display): Return the dimensions of
3021 the console window via 2 additional arguments, not via the current
3022 frame. This avoids crashes due to overrunning the bounds of
3023 frame's decode_mode_spec_buffer, which is not resized following
3024 the change of the frame dimensions from the initial 10x10.
3025
3026 * w32term.h (w32_initialize_display_info): Adjust prototype.
3027
3028 * term.c (init_tty): Take dimensions of the frame from the values
3029 returned by initialize_w32_display.
3030
7f203aa1
EZ
3031 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
3032 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
3033 (LIBES): Add $(GFILENOTIFY_LIBS).
3034
3035 * w32inevt.c (handle_file_notifications): Add dummy implementation
3036 for !HAVE_W32NOTIFY.
3037
3038 * w32term.c: Wrap code with HAVE_W32NOTIFY.
3039
55a87246
JD
30402013-06-03 Jan Djärv <jan.h.d@swipnet.se>
3041
3042 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
3043
3044 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
3045
3046 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
3047
3d5ee10a
PE
30482013-06-03 Paul Eggert <eggert@cs.ucla.edu>
3049
3050 Fix minor problems found by static checking.
3051 * data.c (pure_write_error):
3052 Use xsignal2, not Fsignal, as Fsignal might return.
3053 * eval.c (set_backtrace_debug_on_exit): Now static.
3054 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
3055 No longer inline. EXTERN_INLINE is needed only for functions
3056 defined in .h files. Reindent function header as per GNU style.
3057 (backtrace_p, backtrace_top, backtrace_next):
3058 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
3059 compiler or linker. Add extern decls to pacify gcc -Wall.
3060 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
3061 Now static.
3062 * frame.c (free_monitors): Define only on platforms that need it.
3063 * nsterm.m (ns_term_init):
3064 * process.c (catch_child_signal):
3065 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
3066 defined on all porting targets these days.
3067 * process.c, process.h (catch_child_signal):
3068 Make it extern only if NS_IMPL_GNUSTEP is defined.
3069
e2d8a6f0
EZ
30702013-06-03 Eli Zaretskii <eliz@gnu.org>
3071
3072 * w32.c (gettimeofday): Make the signature identical to prototype
3073 in nt/inc/sys/time.h.
3074
a8a7c5f6
SM
30752013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
3076
3077 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
3078 .gdbinit.
3079
3080 * keyboard.c (safe_run_hooks_error): Improve error message.
3081
3082 * data.c (pure_write_error): Add `object' argument.
3083 * puresize.h (CHECK_IMPURE): Use it.
3084
c9628c79
MA
30852013-06-03 Michael Albinus <michael.albinus@gmx.de>
3086
3087 * Makefile.in (NOTIFY_OBJ): New variable.
3088 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
3089
3090 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
3091 Call syms_of_gfilenotify.
3092
3093 * gfilenotify.c: New file.
3094
3095 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
3096 and Qfile_w32notify.
3097 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
3098 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
3099
3100 * lisp.h: Declare syms_of_gfilenotify.
3101
3102 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
3103
2f592f95
SM
31042013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
3105
3106 Merge the specpdl and backtrace stacks. Make the structure of the
3107 specpdl entries more obvious via a tagged union of structs.
3108 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
3109 (enum specbind_tag): New enum.
3110 (struct specbinding): Make it a tagged union of structs.
3111 Add a case for backtrace records.
3112 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
3113 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
3114 (backtrace_debug_on_exit): New accessors.
3115 (struct backtrace): Remove.
3116 (struct catchtag): Remove backlist field.
3117 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3118 Move to eval.c.
3119 (Flocal_variable_p): Speed up the common case where the binding is
3120 already loaded.
3121 * eval.c (backtrace_list): Remove.
3122 (set_specpdl_symbol, set_specpdl_old_value): Remove.
3123 (set_backtrace_args, set_backtrace_nargs)
3124 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
3125 (backtrace_next): New functions.
3126 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
3127 (unwind_to_catch, internal_lisp_condition_case)
3128 (internal_condition_case, internal_condition_case_1)
3129 (internal_condition_case_2, internal_condition_case_n): Don't bother
3130 with backtrace_list any more.
3131 (Fsignal): Adjust to new backtrace format.
3132 (grow_specpdl): Move up.
3133 (record_in_backtrace): New function.
3134 (eval_sub, Ffuncall): Use it.
3135 (apply_lambda): Adjust to new backtrace format.
3136 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
3137 data.c.
3138 (specbind): Adjust to new specpdl format. Simplify.
3139 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
3140 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
3141 backtrace format.
3142 (mark_backtrace): Remove.
3143 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
3144 * xdisp.c (redisplay_internal): Use record_in_backtrace.
3145 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
3146 Use mark_specpdl.
3147 * profiler.c (record_backtrace): Use get_backtrace.
3148 (handle_profiler_signal): Use backtrace_top_function.
3149 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
3150 accessor functions.
3151
c0342369
JD
31522013-06-02 Jan Djärv <jan.h.d@swipnet.se>
3153
3154 * process.h (catch_child_signal): Declare.
3155
3156 * process.c (catch_child_signal): New function.
3157 (init_process_emacs): Call it.
3158
3159 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
3160 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
3161 NS_IMPL_COCOA.
3162 (x_set_cursor_type): Remove declaration.
3163 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
3164 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
3165 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
3166 (ns_get_color): Use F suffix on float.
3167 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
3168 (ns_get_rgb_color): Remove.
3169 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
3170 (note_mouse_movement): x and y are CGFloat.
3171 (ns_draw_fringe_bitmap): Remove unused rowY.
3172 Change #if to COCOA && >= 10_6.
3173 (ns_draw_window_cursor): Remove unused overspill.
3174 (ns_draw_underwave): width and x are EamcsCGFloat.
3175 (ns_draw_box): thickness is CGFloat.
3176 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
3177 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
3178 if not in main thread.
3179 (ns_get_pending_menu_title, ns_check_menu_open)
3180 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
3181 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
3182 (sendFromMainThread:): New method.
3183 (changeFont:): size is CGFloat.
3184 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
3185 Disable warning about permanent text.
3186 (characterIndexForPoint:): Adjust return type depending on GNUStep
3187 version.
3188 (mouseDown:): delta is CGFloat.
3189 (updateFrameSize): Remove unised variable f.
3190 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
3191 Cast float to EmacsCGFloat.
3192 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
3193 also to -1 when restoring.
3194 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
3195 inside NS_IMPL_COCOA.
3196 (toggleFullScreen:): Put call to toggleFullScreen inside
3197 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
3198 (setPosition:portion:whole:): por is CGFloat.
3199 (getMouseMotionPart:window:x:y:): Add F suffix to float.
3200 (mouseDown:): Use CGFloat.
3201 (mouseDragged:): Remove unised variable edge.
3202 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
3203
3204 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
3205 of CGFloat differs.
3206 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
3207 when NS_IMPL_GNUSTEP.
3208 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
3209 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
3210 (EmacsToolbar): Add clearAll. Add tag argument to
3211 addDisplayItemWithImage.
3212 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
3213
3214 * nsselect.m (ns_get_local_selection): Remove unused variable type.
3215
3216 * nsmenu.m (ns_update_menubar): Make static.
3217 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
3218 (fillWithWidgetValue:): Add cast to SEL for setAction.
3219 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
3220 (update_frame_tool_bar): Update code for GNUStep.
3221 (clearAll): New method.
3222 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 3223 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 3224 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
3225 call to insertItemWithItemIdentifier.
3226 (validateVisibleItems): Fix indentation.
3227 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
3228 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
3229 UtilityWindow to aStyle, remove call to setStyleMask.
3230
3231 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
3232
3233 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
3234 (ns_charset_covers, ns_get_covering_families, nsfont_open):
3235 Use F suffix on floats.
3236 (ns_char_width): Returns CGFloat.
3237 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 3238 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
3239 DPSxshow.
3240 (ns_glyph_metrics): CGFloat instead of float.
3241
a0eb10b3
JB
3242 * nsfns.m (x_set_foreground_color, x_set_background_color):
3243 Use EmacsCGFloat.
3244 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
3245 remove unused variables.
3246 (Fns_read_file_name): Keep track if panel is for save.
3247 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 3248 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
3249 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
3250 Just return the input if GNUStep.
c0342369
JD
3251 (x_screen_planes): Remove.
3252 (Fxw_color_values): Use EmacsCGFloat
3253 (Fns_display_monitor_attributes_list): Only get screen number for
3254 Cocoa.
ef099a94 3255 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
3256 EmacsSavePanel.
3257 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
3258 ns_directory_from_panel.
3259
da9aff11
PE
32602013-06-01 Paul Eggert <eggert@cs.ucla.edu>
3261
3262 * process.c (handle_child_signal): Also use WCONTINUED.
3263 This is so that list-processes doesn't mistakenly list the process
3264 as stopped, when the process has actually been continued and is
3265 now running.
3266
0e64479a
PE
32672013-05-31 Paul Eggert <eggert@cs.ucla.edu>
3268
fc186a96
PE
3269 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
3270 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
3271 not already configured.
3272
0e64479a
PE
3273 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
3274
38b787fa
EZ
32752013-05-29 Eli Zaretskii <eliz@gnu.org>
3276
3277 * Makefile.in (mostlyclean): Remove *.res files.
3278
22513e52
SM
32792013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
3280
3281 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
3282 a buffer (bug#8447).
3283
6ef3db10
EZ
32842013-05-27 Eli Zaretskii <eliz@gnu.org>
3285
3286 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
3287 display vector, and we backtrack, handle the case that the
3288 previous character position is also displayed from a display
3289 vector or covered by a display string or image. (Bug#14476)
3290
6799bb26
JD
32912013-05-25 Jan Djärv <jan.h.d@swipnet.se>
3292
3293 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3294 (struct MonitorInfo, free_monitors): Remove.
3295 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
3296 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
3297 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3298 Qframes, Qsource.
3299
3300 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3301 (struct MonitorInfo, free_monitors): Remove.
3302 (ns_screen_name): Make static.
3303 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
3304 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3305 Qframes, Qsource.
3306
3307 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3308 (struct MonitorInfo): New struct.
3309 (free_monitors, make_monitor_attribute_list): Declare.
3310
22513e52
SM
3311 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
3312 New Lisp_Object:s.
6799bb26
JD
3313 (free_monitors, make_monitor_attribute_list): New functions.
3314 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
3315 Qsource.
3316
38cd43eb
XF
33172013-05-25 Xue Fuqiao <xfq.free@gmail.com>
3318
3319 * callproc.c (call_process): Refine the doc string. (Bug#14045)
3320
2af0948d
SM
33212013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
3322
a7eb9b0f
SM
3323 * keyboard.c: Apply keyboard decoding only to events that come directly
3324 from the tty, not from unread-command-events (bug#14368).
3325 (read_event_from_main_queue): New function, extracted from read_char).
3326 (read_decoded_char): Remove.
3327 (read_decoded_event_from_main_queue): New function to replace it.
3328 (read_char): Use it.
3329 (read_key_sequence): Use read_char rather than read_decoded_char.
3330
2af0948d
SM
3331 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
3332
1413e9a5
BR
33332013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
3334
3335 * casetab.c (init_casetab_once): Fix last change (bug#14424).
3336
e6d2f155
KH
33372013-05-22 Kenichi Handa <handa@gnu.org>
3338
3339 The following changes are to fix the setting of
3340 buffer-file-coding-system on, for instance, C-x RET c unix RET
3341 _FILE_OF_DOS_EOL_TYPE_ RET.
3342
3343 * coding.h (struct coding_system): New member detected_utf8_chars.
3344
3345 * coding.c (detect_coding_utf_8): Count characters and check EOL
3346 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
3347 BOM is there.
3348 (setup_coding_system): Do not initialize coding->head_ascii.
3349 (check_ascii): Do not set coding->eol_seen but update it. Do not
3350 call adjust_coding_eol_type here.
1413e9a5
BR
3351 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
3352 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
3353 of the found coding-system.
3354 (decode_coding_gap): Cancel previous change. Utilize the
3355 character numbers counted by detect_coding_utf_8. Fix detection
3356 of BOM for utf-8.
3357
ab56a6f4 33582013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
3359
3360 * search.c (looking_at_1): Only set last_thing_searched if the match
3361 changed the match-data (bug#14281).
3362
ecc3c6ed
DA
33632013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
3364
3365 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 3366 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
3367 (move_it_vertically_backward): Likewise.
3368
5ba8bf35
YM
33692013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3370
3371 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 3372 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
3373 (Fx_display_mm_width, Fx_display_mm_height):
3374 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 3375
91e8418b 3376 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 3377 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
3378 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
3379 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
3380 (Fx_display_backing_store, Fx_display_visual_class)
3381 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
3382 (Fx_display_grayscale_p, Fx_display_pixel_width)
3383 (Fx_display_pixel_height, Fx_display_planes)
3384 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
3385 (Fx_display_screens): Don't confuse X11 screens with NS screens.
3386 (Fx_display_mm_width, Fx_display_mm_height)
3387 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
3388 height for all physical monitors as in X11.
3389
fc30d803
SM
3390 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
3391 Return pixel width or height for all physical monitors as in X11.
91e8418b 3392
31ff141c
PE
33932013-05-18 Paul Eggert <eggert@cs.ucla.edu>
3394
3395 Port --enable-gcc-warnings to clang.
3396 * bytecode.c (exec_byte_code):
3397 * regex.c:
3398 Redo diagnostic pragmas to pacify clang, too.
3399 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
3400 * editfns.c (Fencode_time):
3401 * fileio.c (file_accessible_directory_p):
3402 * font.c (font_unparse_xlfd):
3403 Use '&"string"[index]' instead of '"string" + (index)'.
3404 * undo.c (user_error): Remove; unused.
3405
df065a0b
EZ
34062013-05-16 Eli Zaretskii <eliz@gnu.org>
3407
04d360e7
EZ
3408 * insdel.c (insert_1_both): Document the arguments, instead of
3409 referring to insert_1, which no longer exists.
3410
5bb98290
EZ
3411 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
3412 some window, increment windows_or_buffers_changed, so that
3413 *Messages* display in that window is updated. (Bug#14408)
3414
df065a0b
EZ
3415 * w32.c: Include epaths.h.
3416 (init_environment): Use cmdproxy.exe without leading directories.
3417 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
3418 case.
3419 (gettimeofday): Adjust signature and return value to Posix
3420 expectations.
3421
3422 * unexw32.c (open_output_file): Delete the existing emacs.exe
3423 before creating it, to break the hard link to the versioned
3424 executable.
3425
3426 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
3427 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
3428 (FIRSTFILE_OBJ): New variables.
3429 (W32_RES): Rename to EMACSRES. All users changed.
3430 (base_obj): Use $(CM_OBJ).
3431 (ALLOBJS): Use $(FIRSTFILE_OBJ).
3432 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
3433 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
3434 $(W32_RES_LINK) before $(LIBES).
3435 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
3436
1aa8d505
SM
34372013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3438
6e911150
SM
3439 * makefile.w32-in (DOC): Use just "DOC".
3440
3441 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
3442
1aa8d505
SM
3443 * process.c: Export default filters and sentinels to Elisp.
3444 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
3445 New constants.
3446 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
3447 (Fset_process_sentinel, Fformat_network_address):
3448 Default to them instead of nil.
3449 (server_accept_connection): Sentinels can't be nil any more.
3450 (read_and_dispose_of_process_output): New function, extracted from
3451 read_process_output.
3452 (read_process_output): Use it; filters can't be nil.
3453 (Finternal_default_process_filter): New function, extracted from
3454 read_process_output.
3455 (exec_sentinel_unwind): Remove function.
3456 (exec_sentinel): Don't zilch sentinel while running.
3457 (status_notify): Sentinels can't be nil.
3458 (Finternal_default_process_sentinel): New function extracted from
3459 status_notify.
3460 (setup_process_coding_systems): Default filter is not nil any more.
3461 (syms_of_process): Export new Elisp functions and initialize
3462 new constants.
3463 * lisp.h (make_lisp_proc): New function.
3464
5ac2eb34
SM
34652013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3466
3467 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
3468
eda9c7d7
EZ
34692013-05-14 Eli Zaretskii <eliz@gnu.org>
3470
3471 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
3472 unless we know that the window w is a leaf window.
3473 Another attempt at solving bug#14062.
eda9c7d7 3474
8fdeaad5
JD
34752013-05-14 Jan Djärv <jan.h.d@swipnet.se>
3476
3477 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
3478 fdesc (Bug#14375).
3479
44aa9ee6
PE
34802013-05-12 Paul Eggert <eggert@cs.ucla.edu>
3481
3482 * image.c (gif_load): Check that subimages fit (Bug#14345).
3483
759fd763
SM
34842013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
3485
3486 * lread.c (skip_dyn_eof): New function.
3487 (read1): Use it to skip the end of a file in response to #@00.
3488
3489 * doc.c (get_doc_string): Slightly relax the sanity checking.
3490
4465bfb4
JD
34912013-05-09 Jan Djärv <jan.h.d@swipnet.se>
3492
3493 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
3494 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3495 (MonitorInfo): New struct.
3496 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
3497 (Fns_display_monitor_attributes_list): New functions.
3498 (display-usable-bounds): Remove.
3499 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
3500 Qsource.
3501
7583e2a0
PE
35022013-05-09 Paul Eggert <eggert@cs.ucla.edu>
3503
3504 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
3505 (GTK_CHECK_VERSION): New macro, if not already defined.
3506 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
3507 replaced by GTK_CHECK_VERSION.
3508
ad75d77e
PE
35092013-05-08 Paul Eggert <eggert@cs.ucla.edu>
3510
3511 * xterm.h (GTK_PREREQ): New macro.
3512 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
3513 to use this macro instead, for consistency and clarity.
3514
07525f77
EZ
35152013-05-08 Eli Zaretskii <eliz@gnu.org>
3516
3517 * xdisp.c (row_for_charpos_p): New function, with code of
3518 cursor_row_p, but accepts an additional argument CHARPOS instead
3519 of using a hardcoded PT.
3520 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
3521 (row_containing_pos): Call row_for_charpos_p instead of partially
3522 doing the same. Fixes cursor positioning under longlines-mode
3523 when longlines-show-effect includes more than one newline, when
3524 moving the cursor vertically up.
3525
d901fc8d
JB
35262013-05-08 Juanma Barranquero <lekktu@gmail.com>
3527
3528 * makefile.w32-in (ACL_H): New macro.
3529 ($(BLD)/fileio.$(O)): Update dependencies.
3530
f269bc61
PE
35312013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3532
e7b41c4c 3533 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
3534 * Makefile.in (LIB_ACL): New macro.
3535 (LIBACL_LIBS): Remove.
3536 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
3537 * fileio.c: Include <acl.h>.
3538 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
3539 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
3540 !acl_errno_valid.
3541 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
3542 it ourselves.
3543
f269bc61
PE
3544 * unexelf.c: Don't assume ElfW (Half) fits in int.
3545 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
3546 when dealing with ElfW (Half) values, since they can exceed 2**31
3547 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
3548 (entry_address): Omit unused NUM arg. All uses changed.
3549
a261c53e
JL
35502013-05-07 Juri Linkov <juri@jurta.org>
3551
3552 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
3553 to the string converted from number with `Fnumber_to_string'.
3554 (Bug#14254)
3555
2b66427d
PE
35562013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3557
3558 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
3559 This fixes a problem introduced by my previous change.
3560
15acfe41
GM
35612013-05-07 Glenn Morris <rgm@gnu.org>
3562
3563 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
3564
5ea03bf5
JD
35652013-05-07 Jan Djärv <jan.h.d@swipnet.se>
3566
3567 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
3568
e0c9d565
PE
35692013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3570
3571 Static checking by GCC 4.8.0.
3572 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
3573 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
3574 (x_get_monitor_attributes_fallback)
3575 (x_get_monitor_attributes_xinerama)
3576 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
3577 Define only if USE_GTK.
3578 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
3579 (x_get_monitor_attributes_fallback): Omit unused locals.
3580 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
3581 Use double, not float, to avoid mixed-mode floating point arithmetic.
3582
4e3f9230
YM
35832013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3584 Jan Djärv <jan.h.d@swipnet.se>
3585
3586 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
3587 (XINERAMA_CFLAGS): New macros.
3588 (ALL_CFLAGS, LIBES): Use them.
3589
3590 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
3591 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
3592 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
3593 (syms_of_xfns): DEFSYM them.
3594 (struct MonitorInfo): New struct.
3595 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
3596 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
3597 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
3598 (x_get_monitor_attributes_xinerama): New functions.
3599 (Fx_display_monitor_attributes_list): New primitive.
3600 (syms_of_xfns): Defsubr it.
3601
3602 * xterm.h (x_display_info): Add Xatom_net_workarea and
3603 Xatom_net_current_desktop.
3604
3605 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
3606 and dpyinfo->Xatom_net_current_desktop.
3607
05839b6a
EZ
36082013-05-06 Eli Zaretskii <eliz@gnu.org>
3609
3610 * xdisp.c (pos_visible_p): Use the special code for finding the
3611 beginning of a display property or overlay for any "replacing"
3612 display property, not just for display strings. This solves
3613 incorrect reporting of position by posn-at-point. (Bug#14241)
3614
dc4a2ee0
PE
36152013-05-06 Paul Eggert <eggert@cs.ucla.edu>
3616
5ee94506
PE
3617 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
3618 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
3619 Verify that ElfW (Half) fits in int.
3620 (fatal): Use same signature as lisp.h.
3621 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
3622 configure and build with -DUNEXELF_DEBUG without worrying about
3623 other modules that use DEBUG.
3624 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
3625 possibly-wide integers now uses it instead of plain fprintf.
3626 (entry_address): New function, which avoids problems with 32-bit
3627 overflow on 64-bit hosts.
3628 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
3629 (round_up): Don't assume the remainder fits in int.
3630 (find_section): Use bool for boolean. Simplify debug code.
3631 (unexec): Don't assume file sizes fit in int or size_t.
3632 Omit unnecessary trailing newline in 'fatal' format.
3633 Use strerror rather than outputting decimal error number.
3634 Remove unused code when emacs is not defined;
3635 this file relies on Emacs now.
3636 Don't assume e_phnum and e_shnum are positive.
3637
dc4a2ee0
PE
3638 * regex.c: Fix problems when DEBUG is defined.
3639 (extract_number, extract_number_and_incr): Define regardless of
3640 whether DEBUG is defined; that's simpler and makes the code less
3641 likely to go stale in the normal case when DEBUG is not defined.
3642 Return int rather than taking an int * arg. All callers changed.
3643 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
3644 Remove, replacing with ...
3645 (DEBUG_PRINT): New macro. All callers changed.
3646 (DEBUG_COMPILES_ARGUMENTS): New macro.
3647 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
3648 (print_compiled_pattern, print_double_string) [DEBUG]:
3649 Use prototype rather than old-style definition.
3650 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
3651 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
3652 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
3653 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
3654 Don't assume ptrdiff_t, size_t, and long are the same width as int.
3655 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
3656 This matters only when DEBUG is defined.
3657
14c7ed05
EZ
36582013-05-05 Eli Zaretskii <eliz@gnu.org>
3659
3660 * xdisp.c (set_iterator_to_next): Set the
3661 ignore_overlay_strings_at_pos_p flag only if we are _really_
3662 iterating over an overlay string, as indicated by the
3663 current.overlay_string_index member. (Bug#14306)
3664
e6076b1b
JD
36652013-05-05 Jan Djärv <jan.h.d@swipnet.se>
3666
3667 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
3668 to where it is used, to avoid autorelease issues (Bug#14050).
3669
cbee2131
PE
36702013-05-05 Paul Eggert <eggert@cs.ucla.edu>
3671
3672 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
3673 * fileio.c (syms_of_fileio): Implement this.
3674 * filelock.c (create_lock_file): If symbolic links don't work, so
3675 we use a regular file as a lock file, do not fsync the lock file;
3676 it's not needed.
3677
30c7e542
SM
36782013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3679
3680 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
3681 (syms_of_minibuf): Adjust accodingly.
3682 * lread.c (Fread):
3683 * callint.c (Fcall_interactively): Adjust calls accordingly.
3684
5bebd186
EZ
36852013-05-04 Eli Zaretskii <eliz@gnu.org>
3686
3687 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
3688 w->contents is a buffer before computing everything else.
3689 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
3690
3691 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
3692 assertion violations. (Bug#14062)
3693
0fb0a4f3
DR
36942013-05-01 David Reitter <david.reitter@gmail.com>
3695
3696 * nsfns.m (ns_tooltip): Initialize.
3697
9e63b4a5
EZ
36982013-04-28 Eli Zaretskii <eliz@gnu.org>
3699
3700 * coding.c (decode_coding_gap): Don't remove the character before
3701 a newline unless it's a CR character. (Bug#14287)
3702
ad60824e
DN
37032013-04-28 Dan Nicolaescu <dann@gnu.org>
3704
3705 * dispextern.h (struct face): Move enum face_underline_type
3706 earlier so that bitfields can be in the same word.
3707
edbdcec0
JD
37082013-04-28 Jan Djärv <jan.h.d@swipnet.se>
3709
3710 * nsfns.m (handlePanelKeys): New function.
3711 (EmacsOpenPanel:performKeyEquivalent:)
3712 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
3713 arrows/function/control and copy/paste keys (Bug#14296).
3714
0208ede7
JL
37152013-04-27 Juri Linkov <juri@jurta.org>
3716
3717 * callint.c (Fcall_interactively): Call `Qread_number' for
3718 interactive code letter `n' instead of using duplicate code.
3719 (Bug#14254)
3720
b8dd59f7
PE
37212013-04-27 Paul Eggert <eggert@cs.ucla.edu>
3722
3723 * systime.h (make_timeval): Declare as 'const'.
3724
8bd722db
KH
37252013-04-27 Kenichi Handa <handa@gnu.org>
3726
3727 * font.c (font_open_entity): Always open a font of manageable
3728 size.
3729
13d0e56f 37302013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 3731
f780d632
PE
3732 Port better to AIX (Bug#14258).
3733 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
3734 to pacify AIX xlc.
3735
ec509856
KH
37362013-04-24 Kenichi Handa <handa@gnu.org>
3737
3738 * coding.c (decode_coding_iso_2022): When an invalid escape
3739 sequence is encountered, reset the invocation and designation
3740 status to the safest one.
3741
84fc48e5
PE
37422013-04-22 Paul Eggert <eggert@cs.ucla.edu>
3743
3744 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
3745 Without this fix, "make distclean" leaves stamp-h1 behind.
3746
806bda47
EC
37472013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
3748
3749 * w32fns.c (w32_fullscreen_rect): New function to compute the
3750 window rectangle for the given fullscreen mode.
3751 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
3752 longer tunes the window size. This keeps the window's edges flush
3753 with the screen and allows the taskbar to hide itself in fullboth.
3754
3755 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
3756 window decorations and uses the entire screen.
3757
3758 * w32term.h (w32_fullscreen_rect) Add prototype.
3759 (struct w32_output): Replace normal_width, normal_height,
3760 normal_top, and normal_left members with a single normal_placement
3761 struct.
3762 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
3763 Remove macros.
3764 (FRAME_NORMAL_PLACEMENT): New macro.
3765
9cc2810b
JB
37662013-04-16 Juanma Barranquero <lekktu@gmail.com>
3767
3768 * minibuf.c (Ftest_completion): Silence compiler warning.
3769
fd16b54c
EZ
37702013-04-15 Eli Zaretskii <eliz@gnu.org>
3771
3772 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 3773 bug#14062.
fd16b54c
EZ
3774
3775 * frame.h (WINDOW_FRAME): Protect macro and its argument with
3776 parentheses.
3777
3778 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
3779 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
3780 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
3781 parentheses where appropriate.
3782
9e3379a0
PE
37832013-04-14 Paul Eggert <eggert@cs.ucla.edu>
3784
3785 * keyboard.c (timer_start_idle): Remove no-longer-used local.
3786
ddd6b685
EZ
37872013-04-14 Eli Zaretskii <eliz@gnu.org>
3788
3789 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
3790 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
3791 Mention in the doc string that setting these variables takes
3792 effect only after a call to set-window-buffer. (Bug#14200)
3793
29b79ba1
EZ
37942013-04-13 Eli Zaretskii <eliz@gnu.org>
3795
3796 * indent.c (Fvertical_motion): Don't consider display strings on
3797 overlay strings as display strings on the buffer position we
3798 started from. This prevents vertical cursor motion from jumping
3799 more than one line when there's an overlay string with a display
3800 property at end of line.
3801 Reported by Karl Chen <Karl.Chen@quarl.org> in
3802 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
3803
562c6ee9
SM
38042013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
3805
3806 * window.c (select_window): `record_buffer' even if window is
3807 already selected (bug#14191).
3808
fcc1fe85
EZ
38092013-04-11 Eli Zaretskii <eliz@gnu.org>
3810
3811 * window.c (Fwindow_end): Test more flags, including the buffer's
3812 last_overlay_modified flag, to determine whether the window's
3813 display is really up-to-date. Prevents the function from
3814 returning a stale value. (Bug#14170)
3815 (Fwindow_line_height): Fix the test for up-to-date-ness of the
3816 current matrix.
3817
f009190a
EZ
38182013-04-10 Eli Zaretskii <eliz@gnu.org>
3819
3820 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
3821 garbaged only if it is not already the top frame on its TTY.
3822 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
3823 there are GUI frames open in the same session. (Bug#13864)
3824
78ce603d
SM
38252013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
3826
3827 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
3828 of marking the idle timers directly.
3829
a8036e40
SM
38302013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
3831
3832 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
3833 tables (bug#14054).
3834
7ffe7ef6
SM
38352013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
3836
3837 * window.c (select_window): Don't record_buffer while the invariant is
3838 temporarily broken (bug#14161).
3839
3840 * fns.c (Fdelq): Don't assume !NILP => CONSP.
3841
7d9f6883
EZ
38422013-04-07 Eli Zaretskii <eliz@gnu.org>
3843
3844 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
3845
5406cfd9
RF
38462013-04-07 Romain Francoise <romain@orebokech.com>
3847
3848 Ignore additional platform-specific ACL errors (Bug#13702).
3849 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
3850 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
3851
95c0e83b
JD
38522013-03-31 Jan Djärv <jan.h.d@swipnet.se>
3853
3854 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
3855 f->output_data.ns.
3856
876da980
PE
38572013-04-07 Paul Eggert <eggert@cs.ucla.edu>
3858
3859 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
3860 This bug was introduced by my 2013-02-25 change that simplified
3861 data_start configuration. Without this change, on GNU/Linux
3862 an Emacs configured with --enable-profiling fails immediately
3863 due to a profiler signal.
3864 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
3865 with these flags. On platforms where special flags are needed
3866 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
3867 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
3868 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
3869
7452b7bd
DA
38702013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
3871
3872 Get rid of some platform-specific functions examining window
3873 system and its capabilities. This is a partial rework of the
3874 2013-04-05 change.
3875 * lisp.h (have_menus_p): Remove prototype. This function is
3876 replaced with platform-independent window_system_available.
3877 (check_window_system): Move to...
3878 * frame.h (decode_window_system_frame, window_system_available):
3879 ...here, add new prototypes.
3880 * frame.c (window_system_available, decode_window_system_frame):
3881 New functions.
3882 (check_window_system): Platform-independent now.
3883 * xterm.h (x_in_use): Remove declaration.
3884 (check_x_frame):
3885 * w32term.h (check_x_frame):
3886 * nsterm.h (check_x_frame): Remove prototypes. This function
3887 is replaced with platform-independent decode_window_system_frame.
3888 * msdos.c (have_menus_p): Remove.
3889 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
3890 Remove platform-specific functions. Use check_window_system,
3891 decode_window_system_frame and check_ns_display_info where
3892 appropriate. Minor style and comment tweaks.
3893 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
3894 (check_x_frame): Likewise.
3895 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
3896 Likewise.
3897 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
3898 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
3899 * xmenu.c, xselect.c: All related users changed.
3900
251e9147
KH
39012013-04-03 Kenichi Handa <handa@gnu.org>
3902
3903 The following changes is to optimize the code for reading UTF-8
3904 files.
3905
562c6ee9 3906 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
3907 changed. Check EOL format. Do not call adjust_coding_eol_type
3908 here.
3909 (check_utf_8): New function.
3910 (adjust_coding_eol_type): Do nothing if already adjusted.
3911 (detect_coding): Compare the return value of check_ascii with
3912 coding->src_bytes. Call adjust_coding_eol_type if necessary.
3913 (decode_coding_gap): Optimize for valid UTF-8.
3914
8bc369d4
KH
39152013-03-21 Kenichi Handa <handa@gnu.org>
3916
3917 * coding.c (syms_of_coding): Cancel previous change.
3918
3919 * insdel.c (insert_from_gap): Fix previous change.
3920
73931ad1
DA
39212013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
3922
3923 Consistently use platform-specific function to detect window system.
3924 * lisp.h (check_window_system): New prototype. This function is
3925 going to replace check_x, check_w32 and check_ns.
3926 (have_menus_p): Mention msdos.c in comment.
3927 * fontset.c (check_window_system_func): Remove. Adjust all users.
3928 * fontset.h (check_window_system_func): Remove prototype.
3929 * nsterm.h (check_ns):
3930 * xterm.h (check_x):
3931 * w32term.h (check_w32): Likewise.
3932 * menu.c (Fx_popup_menu): Use check_window_system.
3933 * msdos.c (check_window_system): Define for MS-DOS.
3934 * nsfns.m (check_window_system): Define for NS. Adjust all users.
3935 * w32fns.c (check_window_system): Likewise for MS-Windows.
3936 * xfns.c (check_window_system): Likewise for X.
3937 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
3938 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
3939
7216e43b
PE
39402013-04-02 Paul Eggert <eggert@cs.ucla.edu>
3941
3942 Prefer < to > in range checks such as 0 <= i && i < N.
3943 This makes it easier to visualize quantities on a number line.
3944 This patch doesn't apply to all such range checks,
3945 only to the range checks affected by the 2013-03-24 change.
3946 This patch reverts most of the 2013-03-24 change.
3947 * alloc.c (xpalloc, Fgarbage_collect):
3948 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
3949 * character.c (string_escape_byte8):
3950 * charset.c (read_hex):
3951 * data.c (cons_to_unsigned):
3952 * dispnew.c (update_frame_1):
3953 * doc.c (Fsubstitute_command_keys):
3954 * doprnt.c (doprnt):
3955 * editfns.c (hi_time, decode_time_components):
3956 * fileio.c (file_offset):
3957 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
3958 * font.c (font_intern_prop):
3959 * frame.c (x_set_alpha):
3960 * gtkutil.c (get_utf8_string):
3961 * indent.c (check_display_width):
3962 * keymap.c (Fkey_description):
3963 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
3964 * lread.c (read1):
3965 * minibuf.c (read_minibuf_noninteractive):
3966 * process.c (wait_reading_process_output):
3967 * search.c (Freplace_match):
3968 * window.c (get_phys_cursor_glyph):
3969 * xdisp.c (redisplay_internal):
3970 * xsmfns.c (smc_save_yourself_CB):
3971 Prefer < to > for range checks.
3972 * dispnew.c (sit_for): Don't mishandle NaNs.
3973 This fixes a bug introduced in the 2013-03-24 change.
3974 * editfns.c (decode_time_components): Don't hoist comparison.
3975 This fixes another bug introduced in the 2013-03-24 change.
3976
92759988
DA
39772013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
3978
3979 * frame.h (struct frame): Drop scroll_bottom_vpos
3980 member becaue all real users are dead long ago.
3981 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
3982 * xdisp.c (redisplay_internal): Adjust user.
3983
9a1971bb
GM
39842013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
3985
f38ab167
JD
3986 * nsmenu.m (showAtX:Y:for:): setLevel to
3987 NSPopUpMenuWindowLevel (Bug#13998).
3988
6d01f1fe
JD
39892013-03-30 Jan Djärv <jan.h.d@swipnet.se>
3990
3991 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
3992 (ns_check_pending_open_menu): Declare.
3993
3994 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
3995 (x_activate_menubar): Update the menu with title that matches
3996 ns_get_pending_menu_title, and call
3997 ns_check_pending_openmenu (Bug#12698).
3998 (menuWillOpen:): New method.
3999 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
4000
4001 * nsterm.m (menu_will_open_state, menu_mouse_point)
4002 (menu_pending_title): New varaibles.
4003 (ns_get_pending_menu_title, ns_check_menu_open)
4004 (ns_check_pending_open_menu): New functions.
4005
781f4782
DA
40062013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
4007
4008 * indent.c (current_column_bol_cache): Remove leftover which is not
4009 used in Fmove_to_column any more.
4010 (current_column, scan_for_column): Adjust users.
4011 * keyboard.c (last_point_position_buffer, last_point_position_window):
4012 Remove leftovers which are not used for recording undo any more.
4013 (command_loop_1, syms_of_keyboard): Adjust users.
4014 * xdisp.c (last_max_ascent): Remove leftover which is not used in
4015 redisplay_window any more.
4016 (move_it_to): Adjust user.
4017
1921c31b
JB
40182013-03-29 Juanma Barranquero <lekktu@gmail.com>
4019
4020 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
4021 Update dependencies.
4022
717b8bcd
SM
40232013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4024
4025 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
4026 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
4027 forward references.
4028
e74aeda8
DA
40292013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
4030
4031 * window.h (struct window): Replace hchild, vchild and buffer slots
4032 with the only contents slot. This is possible because each valid
4033 window may have either the child window (in vertical or horizontal
4034 combination) or buffer to display (for the leaf window). Using that,
4035 a lof of operations to traverse and/or change window hierarchies may
4036 be simplified. New member horizontal is used to distinguish between
4037 horizontal and vertical combinations of internal windows.
4038 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
4039 (WINDOW_VERTICAL_COMBINATION_P): New macros.
4040 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
4041 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
4042 Use contents slot, not buffer, where appropriate.
4043 (wset_combination): New function.
4044 (wset_buffer): Add eassert.
4045 (Fframe_first_window): Simplify the loop reaching first window.
4046 (Fwindow_buffer): Use WINDOW_LEAF_P.
4047 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
4048 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
4049 (unshow_buffer): Convert initial debugging check to eassert.
4050 (replace_window, recombine_windows, Fdelete_other_windows_internal)
4051 (make_parent_window, window_resize_check, window_resize_apply)
4052 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
4053 (Fset_window_configuration, delete_all_child_windows, save_window_save):
4054 Adjust to match struct window changes.
4055 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
4056 (mark_window_cursors_off, count_windows, get_leaf_windows)
4057 (foreach_window_1): Simplify the loop.
4058 * alloc.c (mark_object): Do not check for the leaf window because
4059 internal windows has no glyph matrices anyway.
4060 * dispnew.c (clear_window_matrices, showing_window_margins_p)
4061 (allocate_matrices_for_window_redisplay, fake_current_matrices)
4062 (allocate_matrices_for_frame_redisplay, free_window_matrices)
4063 (build_frame_matrix_from_window_tree, mirror_make_current)
4064 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
4065 (update_window_tree, set_window_update_flags): Simplify the loop.
4066 (sync_window_with_frame_matrix_rows): Enforce live window.
4067 Use contents slot, not buffer, where appropriate.
4068 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
4069 and WINDOW_HORIZONTAL_COMBINATION_P.
4070 (make_frame_visible_1): Simplify the loop.
4071 Use contents slot, not buffer, where appropriate.
4072 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
4073 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
4074 (expose_window_tree): Likewise.
4075 Use contents slot, not buffer, where appropriate.
4076 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
4077 to avoid deleted windows. Use contents slot instead of buffer.
4078 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
4079 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
4080 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
4081 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
4082
121ab1cd
EZ
40832013-03-28 Eli Zaretskii <eliz@gnu.org>
4084
ef454cf7
EZ
4085 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
4086 identify the reasons for assertion violations in bug#14062 and
4087 similar ones.
21e930f8
EZ
4088 (Fx_show_tip): Fix compilation error under
4089 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 4090
121ab1cd
EZ
4091 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
4092 Reported by <rzl24ozi@gmail.com>.
4093
5c89ca24
DA
40942013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
4095
4096 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
4097 start marker...
562c6ee9
SM
4098 (unwind_with_echo_area_buffer): ...to restore it here.
4099 This is needed to ensure that...
5c89ca24
DA
4100 (redisplay_window): ...both window markers are valid here,
4101 which is verified by eassert.
4102 * editfns.c (save_excursion_save): Do not assume that
4103 selected_window always displays the buffer.
c7f53895
DA
4104 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
4105 Fix comment.
5c89ca24 4106
f557c1b1
SM
41072013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
4108
4109 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
4110 the upcase table.
4111
40693bba 41122013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
4113
4114 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
4115
c86f791f
EZ
41162013-03-27 Eli Zaretskii <eliz@gnu.org>
4117
4118 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
4119 since MinGW's w32api headers do. This avoids compiler warnings.
4120
4121 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
4122 if already defined.
4123
c6e72e17
EZ
41242013-03-26 Eli Zaretskii <eliz@gnu.org>
4125
4126 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
4127
54e95010
JD
41282013-03-26 Jan Djärv <jan.h.d@swipnet.se>
4129
4130 * gtkutil.c (style_changed_cb): Check if frame is live and an
4131 X frame (Bug#14038).
4132
b88b62de
EZ
41332013-03-26 Eli Zaretskii <eliz@gnu.org>
4134
a18d7de6
EZ
4135 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
4136 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
4137 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
4138 MinGW64.
8f5e14c8
EZ
4139 Move inclusion of time.h before sys/time.h, so that MinGW64 could
4140 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 4141
b88b62de
EZ
4142 Fix incompatibilities between MinGW.org and MinGW64 headers.
4143 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
4144
4145 * w32.c (REPARSE_DATA_BUFFER): Guard with
4146 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
4147
c074e458
JD
41482013-03-25 Jan Djärv <jan.h.d@swipnet.se>
4149
4150 * xterm.c: Include X11/XKBlib.h
4151 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
4152
908589fd
AS
41532013-03-24 Andreas Schwab <schwab@linux-m68k.org>
4154
4155 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
4156 written backwards.
4157 * blockinput.h (input_blocked_p): Likewise.
4158 * bytecode.c (exec_byte_code): Likewise.
4159 * callproc.c (call_process_kill, call_process_cleanup)
4160 (Fcall_process): Likewise.
4161 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
4162 (Fccl_execute_on_string): Likewise.
4163 * character.c (string_escape_byte8): Likewise.
4164 * charset.c (read_hex): Likewise.
4165 * cm.c (calccost): Likewise.
4166 * data.c (cons_to_unsigned): Likewise.
4167 * dired.c (directory_files_internal, file_name_completion):
4168 Likewise.
4169 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
4170 (sit_for): Likewise.
4171 * doc.c (Fsubstitute_command_keys): Likewise.
4172 * doprnt.c (doprnt): Likewise.
4173 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
4174 * emacsgtkfixed.c: Likewise.
4175 * fileio.c (file_offset, Fwrite_region): Likewise.
4176 * floatfns.c (Fexpt, fmod_float): Likewise.
4177 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
4178 Likewise.
4179 * font.c (font_intern_prop): Likewise.
4180 * frame.c (x_set_alpha): Likewise.
4181 * gtkutil.c (get_utf8_string): Likewise.
4182 * indent.c (check_display_width): Likewise.
4183 * intervals.c (create_root_interval, rotate_right, rotate_left)
4184 (split_interval_right, split_interval_left)
4185 (adjust_intervals_for_insertion, delete_node)
4186 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4187 (merge_interval_right, merge_interval_left, copy_intervals)
4188 (set_intervals_multibyte_1): Likewise.
4189 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
4190 * keymap.c (Fkey_description): Likewise.
4191 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
4192 * lread.c (openp, read_integer, read1, string_to_number):
4193 Likewise.
4194 * menu.c (ensure_menu_items): Likewise.
4195 * minibuf.c (read_minibuf_noninteractive): Likewise.
4196 * print.c (printchar, strout): Likewise.
4197 * process.c (create_process, Faccept_process_output)
4198 (wait_reading_process_output, read_process_output, send_process)
4199 (wait_reading_process_output): Likewise.
4200 * profiler.c (make_log, handle_profiler_signal): Likewise.
4201 * regex.c (re_exec): Likewise.
4202 * regex.h: Likewise.
4203 * search.c (looking_at_1, Freplace_match): Likewise.
4204 * sysdep.c (get_child_status, procfs_ttyname)
4205 (procfs_get_total_memory): Likewise.
4206 * systime.h (EMACS_TIME_VALID_P): Likewise.
4207 * term.c (dissociate_if_controlling_tty): Likewise.
4208 * window.c (get_phys_cursor_glyph): Likewise.
4209 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
4210 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
4211 Likewise.
4212 * xfns.c (Fx_window_property): Likewise.
4213 * xmenu.c (set_frame_menubar): Likewise.
4214 * xselect.c (x_get_window_property, x_handle_dnd_message):
4215 Likewise.
4216 * xsmfns.c (smc_save_yourself_CB): Likewise.
4217 * xterm.c (x_scroll_bar_set_handle): Likewise.
4218
2bf7d27a
DA
42192013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
4220
4221 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
4222 to be optional or nil. Adjust comment and convert it to docstring.
4223 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
4224 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
4225
a9ebfa0b
PE
42262013-03-24 Paul Eggert <eggert@cs.ucla.edu>
4227
4228 Static checking by GCC 4.8-20130319.
4229 * image.c (gif_load): Assume pass < 3 to pacify GCC.
4230 * process.c (Fset_process_datagram_address)
4231 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
4232 * xdisp.c (get_char_face_and_encoding):
4233 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
4234 (get_glyph_face_and_encoding): Prepare face before possibly using it.
4235 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
4236
4f3576ee
KB
42372013-03-24 Ken Brown <kbrown@cornell.edu>
4238
789b5e9a
KB
4239 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
4240 fix compilation on 64-bit Cygwin, where underscores are not
4241 automatically prepended.
4242
4f3576ee
KB
4243 * w32term.c (w32_initialize): Silence compiler warning.
4244
b5b7745f
EZ
42452013-03-23 Eli Zaretskii <eliz@gnu.org>
4246
cdc0d0bd
EZ
4247 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
4248 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
4249 variables, to save and restore frame dimensions.
4250 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
4251 after returning from a 'fullscreen' configuration.
4252 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
4253 to avoid races between the main thread and the input thread.
4254
4255 * w32term.h (struct w32_output): New members normal_width,
4256 normal_height, normal_top, normal_left, and prev_fsmode.
4257 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
4258 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
4259 members of a frame.
4260
b5b7745f
EZ
4261 * w32term.c (w32fullscreen_hook): Record last value of the frame's
4262 'fullscreen' parameter. Always record previous width and height
4263 of the frame, except when switching out of maximized modes, so
4264 that they could be restored correctly, instead of resetting to the
4265 default frame dimensions. Send SC_RESTORE command to the frame,
4266 unless we are going to send SC_MAXIMIZE, to restore the frame
4267 resize hints in the mouse pointer shown by the window manager.
4268 (Bug#14032)
4269
4270 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
4271
4272 * lisp.h (get_frame_param): Adjust conditions for prototype
4273 declaration.
4274
a3454eed
KB
42752013-03-22 Ken Brown <kbrown@cornell.edu>
4276
4277 * unexcw.c: Drop unneeded inclusion of w32common.h.
4278 (report_sheap_usage): Declare.
4279 (read_exe_header): Add magic numbers for x86_64.
4280 (fixup_executable): Fix printf format specifier for unsigned long
4281 argument.
4282
5a49b79c
DA
42832013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
4284
4285 * frame.h (struct frame): Put menu_bar_window under #ifdef
4286 because this member is not needed when X toolkit is in use.
4287 (fset_menu_bar_window):
4288 * dispnew.c (clear_current_matrices, clear_desired_matrices)
4289 (free_glyphs, update_frame):
4290 * xdisp.c (expose_frame): Likewise.
4291 (display_menu_bar): Likewise. Remove redundant eassert.
4292 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
4293 toolkit is in use.
4294
d6723bf7
PE
42952013-03-21 Paul Eggert <eggert@cs.ucla.edu>
4296
7b1123d8
PE
4297 Use functions and constants to manipulate Lisp_Save_Value objects.
4298 This replaces code that used macros and strings and token-pasting.
4299 The change makes the C source a bit easier to follow,
4300 and shrinks the Emacs executable a bit.
4301 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
4302 (make_save_value): Change 1st arg from string to enum. All callers
4303 changed.
4304 (INTX): Remove.
4305 (mark_object): Use if, not #if, for GC_MARK_STACK.
4306 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
4307 (XSAVE_OBJECT): Now functions, not macros.
4308 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
4309 the constant was never used.
4310 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
4311 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
4312 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
4313 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
4314 New constants.
4315 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
4316 type3 with a single member save_type. All uses changed.
4317 (save_type, set_save_pointer, set_save_integer): New functions.
4318 * print.c (PRINTX): Remove.
4319
d6723bf7
PE
4320 * alloc.c: Remove redundant static declarations.
4321
5f24fa51
DA
43222013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4323
4324 * window.h (struct window): Convert left_col, top_line, total_lines
4325 and total_cols from Lisp_Objects to integers. Adjust comments.
4326 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
4327 Remove.
4328 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
4329 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
4330 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
4331 Adjust users where appropriate.
4332
42143acd
DA
43332013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4334
4335 * frame.h (struct frame): Drop resx and resy because the same data is
4336 available from window system-specific output context. Adjust users.
562c6ee9
SM
4337 (default_pixels_per_inch_x, default_pixels_per_inch_y):
4338 New functions to provide defaults when no window system available.
42143acd 4339 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 4340 (NUMVAL): Move from xdisp.c.
42143acd
DA
4341 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
4342 (Ffont_face_attributes, Fopen_font):
4343 * image.c (gs_load):
4344 * w32font.c (fill_in_logfont):
4345 * xdisp.c (calc_pixel_width_or_height):
4346 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
4347 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
4348
c0a17406
KH
43492013-03-20 Kenichi Handa <handa@gnu.org>
4350
4351 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
4352 to 1 (temporary workaround until a bug related to ASCII
4353 optimization is fixed).
4354
095d384d
DA
43552013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
4356
4357 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
4358 Signal error if window is not internal. Adjust docstring.
4359 (delete_all_child_windows): Use combination_limit to save the buffer.
4360 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
4361 * print.c (syms_of_print): Initialize debugging output not here...
4362 (init_print_once): ...but in a new function here.
4363 * lisp.h (init_print_once): Add prototype.
4364 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 4365
748fa866
DA
43662013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
4367
4368 * window.c (window_resize_check, window_resize_apply)
4369 (window_from_coordinates, recombine_windows, set_window_buffer)
4370 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
4371 (Fsplit_window_internal, Fdelete_window_internal)
4372 (freeze_window_starts): Use bool for booleans.
4373 * window.h (window_frame_coordinates, resize_frame_windows)
4374 (freeze_window_starts, set_window_buffer): Adjust prototypes.
4375
81519fd2
SM
43762013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
4377
4378 * dispnew.c (bitch_at_user): Use `user-error'.
4379
6db423a9
KB
43802013-03-17 Ken Brown <kbrown@cornell.edu>
4381
4382 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
4383 as return type of image_background. (Bug#13981)
4384 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
4385
8f2906f5
JD
43862013-03-16 Jan Djärv <jan.h.d@swipnet.se>
4387
960ce480 4388 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 4389 (ns_select): Don't return with result uninitialized.
960ce480 4390
8f2906f5
JD
4391 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
4392 and getDirectory.
4393
81519fd2
SM
4394 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
4395 New functions.
8f2906f5
JD
4396 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
4397 directories. If filename is nil, get directory name (Bug#13932).
4398 Use getFilename and getDirectory.
4399 (getFilename, getDirectory): New methods for EmacsSavePanel and
4400 EmacsOpenPanel.
4401 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
4402
cded56c1
PE
44032013-03-15 Paul Eggert <eggert@cs.ucla.edu>
4404
4405 * coding.c (decode_coding_gap): Fix typo caught by static checking.
4406
251e9147 44072013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
4408
4409 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
4410 (adjust_after_replace): Make it back to static. Delete the third
4411 arg text_at_gap_tail. Cancel the code for handling it.
4412
4413 * coding.h (struct coding_system): New member eol_seen.
4414
4415 * coding.c (detect_ascii): New function.
4416 (detect_coding): Set coding->head_ascii and coding->eol_seen only
4417 when the source bytes are actually scanned. On detecting for
4418 coding_category_utf_8_auto, call detect_ascii instead of scanning
4419 source bytes directly.
4420 (produce_chars): Call insert_from_gap with the new arg 0.
4421 (encode_coding): Likewise.
4422 (decode_coding_gap): Control ASCII optimization by the variable
4423 disable_ascii_optimization instead of #ifndef .. #endif.
4424 Deccode EOL format according to coding->eol_seen.
4425 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
4426 variable.
4427
8a44e6d1
KH
4428 * lisp.h (adjust_after_replace): Cancel externing it.
4429 (insert_from_gap): Adjust prototype.
4430
5f795e34
EZ
44312013-03-15 Eli Zaretskii <eliz@gnu.org>
4432
4433 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
4434 FULLSCREEN_MAXIMIZED. (Bug#13935)
4435
f258b4be
DA
44362013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
4437
4438 * region-cache.c (find_cache_boundary, move_cache_gap)
4439 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
4440 Simplify debugging check and convert to eassert. Adjust comment.
4441 (pp_cache): Put under ENABLE_CHECKING.
4442
a5cc4dde
EZ
44432013-03-14 Eli Zaretskii <eliz@gnu.org>
4444
4445 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
4446 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
4447 and WM_ACTIVATEAPP.
4448 (w32fullscreen_hook): If the frame is visible, reset
4449 f->want_fullscreen flag after changing the frame size. If the
4450 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
4451 (Bug#13953)
4452
3fc5e44a
DC
44532013-03-13 Daniel Colascione <dancol@dancol.org>
4454
4455 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
4456 too so that these builds can use Cygwin's file conversion
4457 functions. (We've been building and linking cygw32.o all along
4458 and just not using it.)
4459
47d7532e
PE
44602013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4461
4462 File synchronization fixes (Bug#13944).
4463 * Makefile.in (LIB_FDATASYNC): New macro.
4464 (LIBES): Use it.
4465 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
4466 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
4467 Don't worry about HAVE_FSYNC, since a substitute fsync is
4468 available if the system lacks one.
4469 (Fwrite_regin): Retry fsync if interrupted.
4470
c7ffccaf
EZ
44712013-03-13 Eli Zaretskii <eliz@gnu.org>
4472
4e2df81d 4473 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
4474 activated, call w32fullscreen_hook, to make sure the new frame
4475 dimensions are in effect. (Bug#13937)
4476
8a7debc1
DA
44772013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
4478
4479 * xdisp.c (init_iterator): Simplify because both character and byte
4480 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
4481 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
4482 character and byte positions can be obtained from marker.
8a7debc1 4483
7fd8c501
PE
44842013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4485
d9df6f40
PE
4486 Static checking by Sun C 5.12.
4487 * alloc.c (buffer_memory_full) [REL_ALLOC]:
4488 * bytecode.c (exec_byte_code):
4489 * dispnew.c (init_display):
4490 * eval.c (error):
4491 * fileio.c (Fsubstitute_in_file_name):
4492 * keyboard.c (Fevent_convert_list):
4493 * keymap.c (Fsingle_key_description):
4494 * term.c (maybe_fatal, fatal):
4495 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
4496 * xsmfns.c (Fhandle_save_session):
4497 Omit unreachable code.
4498 * keymap.c (map_keymap_char_table_item): Cast void * to
4499 a function pointer type; the C Standard requires this.
4500
7fd8c501
PE
4501 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
4502 Include <sys/param.h> unconditionally, as that works elsewhere and
4503 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
4504 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
4505 and FreeBSD now.
4506
a020afb9 4507See ChangeLog.12 for earlier changes.
aac0c6e3
MR
4508
4509;; Local Variables:
4510;; coding: utf-8
aac0c6e3
MR
4511;; End:
4512
ab422c4d 4513 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
4514
4515 This file is part of GNU Emacs.
4516
4517 GNU Emacs is free software: you can redistribute it and/or modify
4518 it under the terms of the GNU General Public License as published by
4519 the Free Software Foundation, either version 3 of the License, or
4520 (at your option) any later version.
4521
4522 GNU Emacs is distributed in the hope that it will be useful,
4523 but WITHOUT ANY WARRANTY; without even the implied warranty of
4524 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4525 GNU General Public License for more details.
4526
4527 You should have received a copy of the GNU General Public License
4528 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.