* xterm.h (struct scroll_bar): Prefer int to Lisp_Object
[bpt/emacs.git] / src / ChangeLog
CommitLineData
d1fc6c21
DA
12013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
2
3 * xterm.h (struct scroll_bar): Prefer int to Lisp_Object
4 for 'dragging' member.
5 * gtkutil.c (xg_set_toolkit_scroll_bar_thumb):
6 * xterm.c (xt_action_hook, xm_scroll_callback, xg_scroll_callback)
7 (xg_end_scroll_callback, xaw_jump_callback, xaw_scroll_callback)
8 (x_set_toolkit_scroll_bar_thumb, x_scroll_bar_create)
9 (x_scroll_bar_set_handle, XTset_vertical_scroll_bar)
10 (x_scroll_bar_handle_click, x_scroll_bar_note_movement)
11 (x_scroll_bar_report_motion): Related users changed.
12
0ce9f6de
JD
132013-09-03 Jan Djärv <jan.h.d@swipnet.se>
14
15 * nsfont.m (INVALID_GLYPH): New define.
16 (nsfont_encode_char): Use INVALID_GLYPH.
17 (ns_uni_to_glyphs): Ditto, check for NSNullGlyph (Bug#15138).
18
b594a96c
DA
192013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
20
21 * xterm.c (x_last_mouse_movement_time): Revert last change.
22 This code should use XDisplayMotionBufferSize to check display's
23 motion history first, and there are few other issues as well.
24 (x_scroll_bar_note_movement): Pass XMotionEvent rather than XEvent.
25 (handle_one_xevent): Adjust user.
26
8b098236
MR
272013-09-02 Martin Rudalics <rudalics@gmx.at>
28
9718b207
MR
29 * dispnew.c (Flast_nonminibuf_frame): Move from here ...
30 * frame.c (Flast_nonminibuf_frame): ... to here.
31 (check_minibuf_window): Don't abort if no window was found
32 (Bug#15247).
8b098236 33
84e70bba
DA
342013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
35
36 Use XGetMotionEvents to ask the last mouse motion time from X server.
37 * xterm.c (X_MOTION_HISTORY): Default to 1.
38 (x_last_mouse_movement_time) [X_MOTION_HISTORY]: New function.
39 (x_last_mouse_movement_time) [!X_MOTION_HISTORY]: Legacy version.
40 (note_mouse_movement, x_scroll_bar_note_movement) [!X_MOTION_HISTORY]:
41 Ifdef away legacy code.
42 (XTmouse_position, x_scroll_bar_report_motion):
43 Use x_last_mouse_movement_time.
fc85e20b
DA
44 (handle_one_xevent): Use event.xunmap and not event.xmap when handling
45 UnmapNotify event.
84e70bba 46
1fccc530
DA
472013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
48
49 * msdos.c (last_mouse_window): Move to...
50 (dos_rawgetc): ...this function and adjust comment.
51 * nsterm.m (last_window): Rename to last_mouse_window, move to...
52 (mouseMoved): ...this function and adjust comment.
53 * w32term.c (last_window): Likewise with...
54 (w32_read_socket): ...this function.
55 * xterm.c (last_window): Likewise with...
56 (handle_one_xevent): ...this function.
57
0ab10992
DA
582013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
59
b7da754d 60 * window.h (Vmouse_window, Vmouse_event): Remove the leftovers.
0ab10992
DA
61 * xterm.c (toplevel): Drop obsolete comment and move compose_status...
62 (handle_one_xevent): ...to here.
63 (STORE_KEYSYM_FOR_DEBUG): Move under ENABLE_CHECKING and make no-op
64 otherwise.
65
0c7f856e
DA
662013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
67
68 * msdos.c (IT_set_terminal_window): Remove no-op.
69 (initialize_msdos_display): Adjust terminal setup.
70 * w32console.c (w32con_set_terminal_window): Remove no-op.
71 (initialize_w32_display): Adjust terminal setup.
72 * w32term.c (w32_set_terminal_window): Remove no-op.
73 (w32_create_terminal): Adjust terminal setup.
74 * xterm.c (XTset_terminal_window): Remove no-op.
75 (x_create_terminal): Adjust terminal setup.
76
a892a94c
DA
772013-09-01 Dmitry Antipov <dmantipov@yandex.ru>
78
79 * nsterm.m (ns_set_terminal_modes, ns_reset_terminal_modes):
80 Remove no-ops.
81 (ns_create_terminal): Adjust terminal setup.
82 * w32term.c (w32_set_terminal_modes, w32_reset_terminal_modes):
83 Remove no-ops.
84 (w32_create_terminal): Adjust terminal setup.
85 * xterm.c (XTset_terminal_modes, XTreset_terminal_modes):
86 Remove no-ops.
87 (x_create_terminal): Adjust terminal setup.
88
cf91889a
DA
892013-09-01 Dmitry Antipov <dmantipov@yandex.ru>
90
91 * dispextern.h (SET_TEXT_POS_FROM_MARKER): Indent.
92 (CLIP_TEXT_POS_FROM_MARKER): New macro.
93 * dispnew.c (buffer_posn_from_coords):
94 * window.c (Fwindow_end, displayed_window_lines):
95 * xdisp.c (redisplay_mode_lines): Use it.
96
5b0891df
JD
972013-09-01 Jan Djärv <jan.h.d@swipnet.se>
98
99 * fontset.c (face_for_char): Check char in the current face font first
100 if HAVE_NS (Bug#15138).
101
0a357e98
MR
1022013-08-31 Martin Rudalics <rudalics@gmx.at>
103
104 * window.c (temp_output_buffer_show): Make sure window returned
105 by display_buffer is live (Bug#15213).
106
9d7693d7
DA
1072013-08-30 Dmitry Antipov <dmantipov@yandex.ru>
108
109 Minor cleanup to avoid forward declarations.
110 * coding.h (struct ccl_spec): Remove forward declaration.
111 * composite.h (toplevel): Include font.h.
112 (struct composition_it, struct face, struct font_metrics):
113 Remove forward declaration.
114 * dispextern.h (struct image, struct atimer): Likewise.
115 * emacsgtkfixed.h (struct frame): Likewise.
116 * emacsgtkfixed.c (toplevel): Reorder headers and drop stdio.h.
117 * font.h (struct font_driver, struct font, struct glyph_string)
118 (struct face): Remove forward declaration.
119 * fontset.h (struct face, struct font): Likewise.
120 * frame.h (toplevel): Style cleanup.
121 (enum output_method): Move to...
122 * termhooks.h (enum output_method): ...here.
123 (struct glyph, struct frame, struct ns_display_info)
124 (struct x_display_info, struct w32_display_info):
125 Remove forward declaration.
126 * xterm.h (toplevel): Include termhooks.h.
127 (struct font, struct window, struct glyph_matrix, struct frame)
128 (struct input_event, struct face, struct image): Remove forward
129 declaration.
130 * gtkutil.h (struct _widget_value): Likewise.
131 * keyboard.h (toplevel): Include termhooks.h.
132 (struct input_event): Remove forward declaration.
133
032f7451
DA
1342013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
135
136 * intervals.c (set_point_from_marker): New function.
137 * editfns.c (Fgoto_char):
138 * process.c (Finternal_default_process_filter):
139 * window.c (select_window_1): Use it.
140 * buffer.h (set_point_from_marker): Add prototype.
141
3f940c5a
EZ
1422013-08-29 Eli Zaretskii <eliz@gnu.org>
143
144 * w32.c (term_winsock): Call release_listen_threads before calling
145 WSACleanup.
146 (_sys_wait_accept): Wait for accept event in a loop with a finite
147 timeout, instead of waiting indefinitely. Will hopefully avoid
148 hanging during exit because WSACleanup deadlocks waiting for the
149 event object to be released. (Bug#14333)
150
151 * w32proc.c (release_listen_threads): New function, signals all
152 the reader threads that listen for connections to stop waiting.
153
154 * w32.h (release_listen_threads): Add prototype.
155
101ed2bb
DA
1562013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
157
158 * alloc.c (Fmake_marker, build_marker): Zero need_adjustment
159 field of new marker (for sanity and safety).
20de2834
DA
160 * lisp.h (XSETMARKER): Remove unused macro (it doesn't work
161 anyway because XMISCTYPE is a function and can't be an lvalue).
101ed2bb 162
1f5cf200
DA
1632013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
164
165 * xterm.c (x_clear_area): Lost 7th arg because it is always False.
166 (x_after_update_window_line, x_scroll_bar_create):
167 (x_scroll_bar_set_handle, XTset_vertical_scroll_bar):
168 (handle_one_xevent, x_clear_frame_area):
169 * gtkutil.c (xg_clear_under_internal_border, xg_update_scrollbar_pos):
170 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Adjust users.
171 * xterm.h (x_clear_area): Adjust prototype.
172
d2b36813
DA
1732013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
174
175 Hook scanning and indentation functions to find_newline. This helps
176 to avoid duplicated code and renders more respect to newline cache.
177 * lisp.h (scan_newline): Prefer ptrdiff_t to EMACS_INT.
178 * cmds.c (Fforward_line):
179 * indent.c (scan_for_column, Fcurrent_indentation, indented_beyond_p):
180 Use find_newline and avoid unnecessary point movements.
181 * search.c (scan_newline): Implement on top of find_newline.
182
3ec7babc
SM
1832013-08-28 Stefan Monnier <monnier@iro.umontreal.ca>
184
185 * eval.c (Ffuncall): Fix handling of ((lambda ..) ..) in lexically
186 scoped code (bug#11258).
187
5ab473cd
JD
1882013-08-28 Davor Cubranic <cubranic@stat.ubc.ca> (tiny change)
189
190 * nsterm.m (last_window): New variable.
191 (EV_TRAILER2): New macro.
192 (EV_TRAILER): Call EV_TRAILER2.
193 (mouseMoved:): Add support for mouse-autoselect-window
194 on nextstep (Bug#6888).
195
78779650
AS
1962013-08-28 Andreas Schwab <schwab@suse.de>
197
198 * regex.c (CHAR_CHARSET, CHARSET_LEADING_CODE_BASE, CHAR_HEAD_P)
199 (SINGLE_BYTE_CHAR_P, SAME_CHARSET_P, MAKE_CHAR, BYTE8_TO_CHAR):
200 Remove unused macro definitions.
201 (CHARSET_RANGE_TABLE_BITS, EXTEND_RANGE_TABLE)
3ec7babc
SM
202 (SET_RANGE_TABLE_WORK_AREA_BIT, SET_RANGE_TABLE_WORK_AREA):
203 Only define if emacs.
78779650 204
c3c4768d
DA
2052013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
206
207 Prefer enum glyph_row_area to int where appropriate.
208 * dispextern.h (enum glyph_row_area): Add ANY_AREA member.
209 Fix comment.
210 (window_box, window_box_width, window_box_left, window_box_left_offset)
211 (window_box_right, window_box_right_offset): Adjust prototypes.
212 * xdisp.c (window_box, window_box_width, window_box_left)
213 (window_box_left_offset, window_box_right, window_box_right_offset):
214 Use enum glyph_row_area. Adjust users and tweak comment where needed.
215 (window_box_edges): Likewise. Lost 2nd arg since it is always ANY_AREA.
216 * nsterm.m (ns_clip_to_row):
217 * w32term.c (w32_clip_to_row):
218 * xterm.c (x_clip_to_row): Likewise.
219
6bdcbfe1
DA
2202013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
221
222 * buffer.c (Foverlays_at, Foverlays_in, Fnext_overlay_change)
223 (Fprevious_overlay_change): Fast path for buffer with no overlays.
224
50b13cde
PE
2252013-08-28 Paul Eggert <eggert@cs.ucla.edu>
226
227 * Makefile.in (SHELL): Now @SHELL@, not /bin/sh,
228 for portability to hosts where /bin/sh has problems.
229
f60e429a
DA
2302013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
231
232 Redesign redisplay interface to drop global output_cursor.
233 * dispextern.h (struct redisplay_interface): Remove cursor_to member.
234 (toplevel): Remove declaration of output_cursor.
235 (set_output_cursor, x_cursor_to): Remove prototype.
236 * window.h (struct window): New member output_cursor.
237 (output_cursor_to): New function to replace RIF member.
238 * dispnew.c (redraw_overlapped_rows, update_marginal_area)
239 (update_text_area, set_window_cursor_after_update): Use it.
240 * xdisp.c (output_cursor, set_output_cursor, x_cursor_to): Remove.
241 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
242 * nsterm.m (ns_update_window_begin, ns_update_window_end):
243 * w32term.c (x_update_window_begin, x_update_window_end):
244 * xterm.c (x_update_window_begin, x_update_window_end):
245 Adjust to use per-window output cursor.
246
43aac990
PE
2472013-08-27 Paul Eggert <eggert@cs.ucla.edu>
248
d486344e
PE
249 Simplify SELECT_TYPE-related code.
250 Like EMACS_TIME, this portability layer is no longer needed, since
251 Emacs has been using fd_set as a portability layer for some time.
252 * sysselect.h (FD_SETSIZE): Rename from MAXDESC. All uses changed.
253 (SELECT_TYPE): Remove. All uses changed to fd_set.
254 (fd_set) [!FD_SET]: New typedef.
255
43aac990
PE
256 Simplify EMACS_TIME-related code.
257 This portability layer is no longer needed, since Emacs has been
258 using struct timespec as a portability layer for some time.
259 * atimer.h, buffer.h, dispextern.h, xgselect.h:
260 Include <time.h> rather than "systime.h"; that's all that's needed now.
261 * dispnew.c: Include <timespec.h> rather than "systime.h";
262 that's all that's needed now.
263 * systime.h (EMACS_TIME): Remove. All uses changed to struct timespec.
264 (EMACS_TIME_RESOLUTION): Remove. All uses changed to
265 TIMESPEC_RESOLUTION.
266 (LOG10_EMACS_TIME_RESOLUTION): Remove. All uses changed to
267 LOG10_TIMESPEC_RESOLUTION.
268 (EMACS_SECS, emacs_secs_addr): Remove. All uses changed to tv_sec.
269 (EMACS_NSECS): Remove. All uses changed to tv_nsec.
270 (make_emacs_time): Remove. All used changed to make_timespec.
271 (invalid_timespec): Rename from invalid_emacs_time. All uses changed.
272 (current_timespec): Rename from current_emacs_time. All uses changed.
273 (add_emacs_time): Remove. All uses changed to timespec_add.
274 (sub_emacs_time): Remove. All uses change dot timespec_sub.
275 (EMACS_TIME_SIGN): Remove. All uses changed to timespec_sign.
276 (timespec_valid_p): Rename from EMACS_TIME_VALID_P. All uses changed.
277 (EMACS_TIME_FROM_DOUBLE): Remove. All uses changed to dtotimespec.
278 (EMACS_TIME_TO_DOUBLE): Remove. All uses changed to timespectod.
279 (current_timespec): Rename from current_emacs_time. All uses changed.
280 (EMACS_TIME_EQ, EMACS_TIME_LT, EMACS_TIME_LE): Remove. All uses
281 changed to timespec_cmp.
282 * xgselect.c: Include <timespec.h>, since our .h files don't.
283
d350e350
DA
2842013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
285
286 * xterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE:)
287 * nsterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE):
288 Remove the leftovers.
289 * gtkutil.c (toplevel): Do not declare Qxft but include
290 font.h to do so.
291 * image.c (toplevel): Do not declare Vlibrary_cache because
292 it's already done in lisp.h.
293
9fed9729
DA
2942013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
295
296 * lisp.h (Mouse_HLInfo): Move from here...
297 * dispextern.h (Mouse_HLInfo): ...to here and offload lisp.h.
298 (reset_mouse_highlight): New function.
299 * msdos.c (dos_set_window_size, IT_update_begin)
300 (internal_terminal_init):
301 * nsterm.m (ns_update_window_end, x_free_frame_resources)
302 (ns_initialize_display_info):
303 * w32console.c (initialize_w32_display):
304 * w32term.c (x_update_window_end, x_free_frame_resources)
305 (w32_initialize_display_info):
306 * xterm.c (x_update_window_end, x_free_frame_resources, x_term_init):
307 * window.c (Fdelete_other_windows_internal):
308 * xdisp.c (clear_mouse_face, cancel_mouse_face): Use it.
309 * termchar.h (toplevel):
310 * xterm.h (toplevel): Include dispextern.h.
311
f462f075
PE
3122013-08-26 Paul Eggert <eggert@cs.ucla.edu>
313
314 Fix minor problems found by static checking.
315 * image.c (XGetPixel, XPutPixel) [HAVE_NS]: Now static.
316 (expect): Avoid nested-if warning.
317 (x_build_heuristic_mask) [HAVE_NS]: Avoid unused-var warning.
318 * nsmenu.m (fillWithWidgetValue:): Avoid type warning.
319 * nsterm.h, nsterm.m (ns_select):
320 * xgselect.c, xgselect.h (xg_select):
321 Adjust signature to better match pselect's.
322 * nsterm.m (ns_select):
323 Don't set *TIMEOUT, since pselect doesn't.
324 * regex.c (whitespace_regexp): Now const_re_char *, to avoid
325 diagnostic about assigning const char * to it.
326 * xfaces.c (x_display_info) [HAVE_NS]: Remove; unused.
327
068f9124
SM
3282013-08-26 Stefan Monnier <monnier@iro.umontreal.ca>
329
330 * lread.c (substitute_object_recurse): Handle hash-tables as well
331 (bug#15190).
332
f5adc984
PE
3332013-08-26 Paul Eggert <eggert@cs.ucla.edu>
334
1fc8eb33
PE
335 Fix unlikely core dump in init_tty, and simplify terminfo case.
336 * term.c (init_tty) [TERMINFO]: Fix check for buffer overrun.
337 The old version incorrectly dumped core if malloc returned a
338 buffer containing only non-NUL bytes.
339 (init_tty): Do not allocate or free termcap buffers; the
340 struct does that for us now.
341 * termchar.h (TERMCAP_BUFFER_SIZE) [!TERMINFO]: New constant.
342 (struct tty_display_info): Define members termcap_term_buffer and
343 termcap_strings_buffer only if !TERMINFO, since terminfo doesn't
344 use them. Allocate them directly in struct rather than indirectly
345 via a pointer, to simplify init_tty.
346
f5adc984
PE
347 * frame.c (check_minibuf_window): Initialize 'window' properly,
348 so that Emacs reliably aborts later if 'window' is not initialized.
349
efec3894
JD
3502013-08-26 Jan Djärv <jan.h.d@swipnet.se>
351
352 * gtkutil.c (xg_initialize): Set gtk-menu-bar-accel to "" instead
353 of VoidSymbol (Bug#15154).
354
e1d0341e
DA
3552013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
356
357 * lisp.h (Mouse_HLInfo): Drop set-but-unused members
358 mouse_face_beg_y and mouse_face_end_y.
359 * xdisp.c (note_tool_bar_highlight, mouse_face_from_buffer_pos)
360 (mouse_face_from_string_pos, note_mode_line_or_margin_highlight):
361 Adjust users and update comment where appropriate.
362
bfff6445
MR
3632013-08-26 Martin Rudalics <rudalics@gmx.at>
364
365 * frame.c (check_minibuf_window): New function.
068f9124
SM
366 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
367 Call check_minibuf_window (Bug#15183).
bfff6445 368
c80016b3
DA
3692013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
370
371 * window.h (struct window): Replace last_cursor with last_cursor_vpos
372 because this is the only last cursor data we need to keep and consult.
373 * window.c (replace_window, set_window_buffer, Fsplit_window_internal):
374 * xdisp.c (mark_window_display_accurate_1, try_cursor_movement):
375 Adjust users.
376
de396731
DA
3772013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
378
068f9124
SM
379 Fix recovering from possible decompression error.
380 Since insert_from_gap doesn't always move point, we can't use PT as
de396731 381 the position where the partially decompressed data ends, and
447218dd 382 should count how many bytes was produced so far.
de396731
DA
383 * decompress.c (struct decompress_unwind_data): Add nbytes member.
384 (unwind_decompress): Really delete partially uncompressed data.
385 (Fzlib_decompress_region): Take decompressed data size into account.
386
c76826d9
DA
3872013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
388
389 * syntax.c (init_syntax_once): Adjust comment and do an early
390 initialization of Qchar_table_extra_slots just once...
391 * casetab.c (init_casetab_once):
392 * category.c (init_category_once):
393 * character.c (syms_of_character):
394 * coding.c (syms_of_coding):
395 * xdisp.c (syms_of_xdisp): ...and omit it here.
396
b34454d0
EZ
3972013-08-24 Eli Zaretskii <eliz@gnu.org>
398
11f20add
EZ
399 * xdisp.c (get_next_display_element): Don't apply to characters
400 from a display vector the logic of setting it->end_of_box_run_p
401 suitable for characters from a buffer. (Bug#15175)
402
b34454d0
EZ
403 * w32.c (fdutimens): Call 'utime', which is implemented on w32.c
404 to handle directories, rather than '_utime' which doesn't.
405 (Bug#15176)
406
6e1b469e
JD
4072013-08-24 Jan Djärv <jan.h.d@swipnet.se>
408
409 * gtkutil.c (x_wm_set_size_hint): Don't set hints when maximized
410 or fullscreen (Bug#14627).
411
9c05bccf
PE
4122013-08-24 Paul Eggert <eggert@cs.ucla.edu>
413
414 System-dependent integer overflow fixes.
415 * process.c (Fset_process_window_size): Signal an error if
416 the window size is outside the range supported by the lower level.
417 * sysdep.c (set_window_size): Return negative on error,
418 nonnegative on success, rather than -1, 0, 1 on not in system,
419 failure, success. This is simpler. Caller changed.
420 (serial_configure): Remove unnecessary initialization of local.
421 (procfs_get_total_memory) [GNU_LINUX]: Don't assume system memory
422 size fits in unsigned long; this isn't true on some 32-bit hosts.
423 Avoid buffer overrun if some future version of /proc/meminfo has a
424 variable name longer than 20 bytes.
425 (system_process_attributes) [__FreeBSD__]:
426 Don't assume hw.availpages fits in 'int'.
427
c365c355
PE
4282013-08-23 Paul Eggert <eggert@cs.ucla.edu>
429
430 Don't let very long directory names overrun the stack.
431 Fix some related minor problems involving "//", vfork.
432 * callproc.c (encode_current_directory): New function.
433 (call_process): Don't append "/"; not needed.
434 * fileio.c (file_name_as_directory_slop): New constant.
435 (file_name_as_directory): Allow SRC to be longer than SRCLEN;
436 this can save the caller having to alloca.
437 (Ffile_name_as_directory, Fdirectory_file_name, Fexpand_file_name):
438 Use SAFE_ALLOCA, not alloca.
439 (directory_file_name, Fexpand_file_name): Leave leading "//"
440 alone, since it can be special even on POSIX platforms.
441 * callproc.c (call_process):
442 * process.c (Fformat_network_address):
443 * sysdep.c (sys_subshell):
444 Use encode_current_directory rather than rolling our own.
445 (create_process): No need to encode directory; caller does that now.
446 * process.h (encode_current_directory): New decl.
447 * sysdep.c (sys_subshell): Work even if vfork trashes saved_handlers.
448 Rework to avoid 'goto xyzzy;'.
449
6c6014d4
EZ
4502013-08-23 Eli Zaretskii <eliz@gnu.org>
451
452 * xdisp.c (handle_face_prop): If the default face was remapped use
453 the remapped face for strings from prefix properties. (Bug#15155)
454
9997ec56
DA
4552013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
456
457 Minor cleanup for redisplay interface and few related functions.
458 * frame.h (enum text_cursor_kinds): Move from here...
459 * dispextern.h (enum text_cursor_kinds): ...to here.
460 (toplevel): Drop unnecessary declarations.
461 (struct redisplay_interface): Use bool and enum text_cursor_kinds
462 in update_window_end_hook and draw_window_cursor functions.
463 (display_and_set_cursor, x_update_cursor): Adjust prototypes.
464 * nsterm.m (ns_update_window_end, ns_draw_window_cursor):
465 * w32term.c (x_update_window_end,w32_draw_window_cursor):
466 * xterm.c (x_update_window_end, x_draw_window_cursor):
467 * xdisp.c (display_and_set_cursor, update_window_cursor)
468 (update_cursor_in_window_tree, x_update_cursor): Use bool and
469 enum text_cursor_kinds where appropriate.
470
7f780da6
DA
4712013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
472
473 Redesign redisplay interface to drop updated_row and updated_area.
474 * dispextern.h (updated_row, updated_area): Remove declaration.
475 (struct redisplay_interface): Pass glyph row and row area parameters
476 to write_glyphs, insert_glyphs and clear_end_of_line functions.
477 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
478 Adjust prototypes.
479 * dispnew.c (updated_row, updated_area): Remove.
480 (redraw_overlapped_rows, update_window_line): Adjust user.
481 (update_marginal_area, update_text_area): Likewise. Pass updated row
482 as a parameter. Prefer enum glyph_row_area to int where appropriate.
483 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
484 Adjust users.
485
26495794
PE
4862013-08-22 Paul Eggert <eggert@cs.ucla.edu>
487
488 * process.c (flush_pending_output): Remove stub.
489 All uses removed.
490
4a88129a
PE
4912013-08-21 Paul Eggert <eggert@cs.ucla.edu>
492
493 * callproc.c: Fix race that killed background processes (Bug#15144).
494 (call_process): New arg TEMPFILE_INDEX. Callers changed.
495 Record deleted process-id in critical section, not afterwards.
496 Don't mistakenly kill process created by a call-process invocation
497 that discards output and does not wait.
498
0c5307b0
DA
4992013-08-21 Dmitry Antipov <dmantipov@yandex.ru>
500
501 Fix compilation with GC_MARK_STACK == GC_USE_GCPROS_AS_BEFORE
502 and GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES.
503 * alloc.c (toplevel): Remove unnecessary nested #if...#endif.
504 (mark_maybe_object) [!GC_MARK_STACK]: Define to emacs_abort
505 to shut up compiler in mark_object.
506 (dump_zombies): Convert to global and add EXTERNALLY_VISIBLE.
507
0d7c1e66
PE
5082013-08-21 Paul Eggert <eggert@cs.ucla.edu>
509
510 * process.c (allocate_pty) [PTY_OPEN]: Set fd's FD_CLOEXEC flag.
511 We can't portably rely on PTY_OPEN doing that, even if
512 it calls posix_openpt with O_CLOEXEC.
513
3f246b65
KH
5142013-08-20 Kenichi Handa <handa@gnu.org>
515
516 * character.c (string_char): Improve commentary.
517
8c2f38aa
PE
5182013-08-20 Paul Eggert <eggert@cs.ucla.edu>
519
520 * image.c (SIGNATURE_DIGESTSIZE): Remove.
521 (struct animation_cache): Make signature a flexible array member.
522 All uses changed. This is a tad slower but may insulate us better
523 from future changes to ImageMagick.
524
bb566cea
PE
5252013-08-19 Paul Eggert <eggert@cs.ucla.edu>
526
527 * image.c: Shrink memory needed for animation cache.
528 (SIGNATURE_DIGESTSIZE): New constant.
529 (struct animation_cache): Make 'signature' a fixed size array of bytes.
530 (imagemagick_create_cache): Copy the signature. This saves
531 several KB of memory that ImageMagick wastes per signature.
532 Don't bother updating the update_time, as the caller does that now.
533 (imagemagick_prune_animation_cache): Don't destroy the signature, as
534 it's a fixed size struct member now.
535 (imagemagick_get_animation_cache): Always destroy the signature,
536 as it's now imagemagick_create_cache's responsibility to copy it.
537 Avoid duplicate calls to strcmp and to imagemagick_create_cache,
538 and use memcmp rather than strcmp.
539 eassert that ImageMagick returns a signature of the specified length.
540
6da26928
LMI
5412013-08-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
542
543 * image.c (imagemagick_get_animation_cache): Don't segfault on
544 each invocation.
453f4022
LMI
545 (imagemagick_get_animation_cache): Revert to previous definition
546 so that it actually works. But keep the memory leak fix.
547 (imagemagick_get_animation_cache): Fix memory leak.
6da26928 548
22490125
PE
5492013-08-19 Paul Eggert <eggert@cs.ucla.edu>
550
d0139df5
PE
551 * image.c: Fix animation cache signature memory leak.
552 Fix some other minor performance problems while we're at it.
553 (imagemagick_create_cache): Clear just the members that
554 need clearing. Don't set update_time, as caller does that now.
555 (imagemagick_prune_animation_cache, imagemagick_get_animation_cache):
556 Simplify by using pointer-to-pointer instead of a prev pointer.
557 (imagemagick_prune_animation_cache): Use make_emacs_time rather
558 than EMACS_TIME_FROM_DOUBLE, and DestroyString rather than free.
559 (imagemagick_get_animation_cache): Don't xstrdup the image signature;
560 it's already a copy. Free the signature probe unless it's cached.
561
22490125
PE
562 * process.c (handle_child_signal): Fix crash; deleted pid (Bug#15106).
563 This was introduced by my 2013-08-12 fix for Bug#15035.
564
deb31e75
DA
5652013-08-19 Dmitry Antipov <dmantipov@yandex.ru>
566
567 * image.c (imagemagick_create_cache, imagemagick_get_animation_cache)
568 (imagemagick_prune_animation_cache): Now static.
569
319a4d03
LMI
5702013-08-18 Lars Magne Ingebrigtsen <larsi@gnus.org>
571
572 * image.c (imagemagick_get_animation_cache): Don't segfault when
573 pruning all entries.
574
f747d82e
KB
5752013-08-18 Ken Brown <kbrown@cornell.edu>
576
577 * sheap.c (STATIC_HEAP_SIZE): Adjust to current needs; use bigger
578 static heap if ENABLE_CHECKING is defined.
579 (max_bss_sbrk_ptr): New variable.
580 (bss_sbrk): Use it.
581 (report_sheap_usage): Report maximum static heap usage instead of
582 ending static heap usage.
583
d2c28fab
EZ
5842013-08-17 Eli Zaretskii <eliz@gnu.org>
585
586 * decompress.c (Fzlib_available_p) [WINDOWSNT]: Update the value
587 of zlib_initialized according to the results of calling
588 init_zlib_functions.
589
274ff63f
LMI
5902013-08-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
591
592 * image.c: Implement an ImageMagick per-image cache.
8a6f875f 593 (imagemagick_get_animation_cache): Fix a double-free error.
49ceb676
LMI
594 (imagemagick_load_image): Remove the ping_wand code, which only
595 apparently saved time on invalid animated images, and slowed down
596 everything else. Optimise for the common case.
274ff63f 597
2bede2ed
XF
5982013-08-16 Xue Fuqiao <xfq.free@gmail.com>
599
70ff8240
XF
600 * buffer.c (syms_of_buffer) <buffer-undo-list>: Doc fix.
601
de179a3e
XF
602 * editfns.c (insert_before_markers): Mention overlay in the doc string.
603
2bede2ed
XF
604 * marker.c (set_marker): Remove documentation of undefined behavior.
605
703dbeba
LMI
6062013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
607
608 * image.c (imagemagick_compute_animated_image): Animate correctly
609 when sub-images are smaller than the main image.
1d18b1e6
LMI
610 (imagemagick_compute_animated_image): Setting the iterator row to
611 zero is apparently not allowed.
79670014
LMI
612 (imagemagick_compute_animated_image): Allow images that say they
613 have sub-images that are bigger than the main image, but just crop
614 them.
703dbeba 615
63216c5e
JD
6162013-08-15 Jan Djärv <jan.h.d@swipnet.se>
617
618 * nsmenu.m (menuWillOpen:): Fix preprocessor test (Bug#15001).
619
a5b5f73f
LMI
6202013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
621
622 * image.c (imagemagick_compute_animated_image): Respect the GIF
623 disposal methods.
624
0fe73012
KB
6252013-08-15 Ken Brown <kbrown@cornell.edu>
626
627 * emacs.c (main): Update comment about G_SLICE_ALWAYS_MALLOC.
628 * gmalloc.c (memalign) [CYGWIN]: Revert last change; it's not
629 needed.
630
691a357f
PE
6312013-08-15 Paul Eggert <eggert@cs.ucla.edu>
632
633 Fix minor problems found by static checking.
634 * frame.c (delete_frame):
635 * xdisp.c (next_element_from_display_vector):
636 Avoid uninitialized local.
637 * image.c (imagemagick_compute_animated_image): Port to C89.
638 Prefer usual GNU indentation style for loops.
639 Be more careful about bizarrely large sizes, by using ptrdiff_t
640 instead of int.
641
42fe2e88
DA
6422013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
643
644 Fix infinite frame selection loop (Bug#15025).
645 * frame.c (delete_frame): Prefer fast ad-hoc loop to next_frame.
646
d39a3da6
EZ
6472013-08-15 Eli Zaretskii <eliz@gnu.org>
648
068f9124
SM
649 * xdisp.c (compute_window_start_on_continuation_line):
650 When WORD_WRAP is in effect, use move_it_to instead of move_it_by_lines
d39a3da6
EZ
651 to make sure we end up setting the window start at the leftmost
652 visible character of the display line. This avoids funky
653 horizontal shifting because the window start is not kept on the
654 same position. (Bug#15090)
05426239
EZ
655 (next_element_from_display_vector): Support 'box' face attribute
656 in the face definitions of a display vector. (Bug#15099)
d39a3da6 657
6e856b69
LMI
6582013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
659
660 * image.c (imagemagick_compute_animated_image): Implement animated
661 images (bug#14700).
995be755
LMI
662 (imagemagick_compute_animated_image): Fix some compilation
663 warnings. Implement a very simple cache to make the animation
664 usable at all, but it should be replaced with a per-image cache.
6e856b69 665
d5a1acfa
DA
6662013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
667
668 * lisp.h (FOR_EACH_ALIST_VALUE): New macro
669 to do `for' loops over alist values.
670 * buffer.h (FOR_EACH_BUFFER):
671 * process.c (FOR_EACH_PROCESS): Use it.
672 (handle_child_signal, status_notify, Fget_buffer_process)
673 (kill_buffer_processes): Use FOR_EACH_PROCESS.
674
9c253307
DA
6752013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
676
677 * term.c (get_named_tty, create_tty_output, tty_free_frame_resources)
678 (tty_free_frame_resources, delete_tty): Prefer eassert to emacs_abort.
679 * image.c (make_image_cache): For struct image_cache, prefer xmalloc
680 to xzalloc and so avoid redundant call to memset.
681 * xterm.c (x_term_init): Avoid unnecessary initializations of dpyinfo
682 members because it is allocated with xzalloc and so already zeroed.
683
05e64f9f
KB
6842013-08-14 Ken Brown <kbrown@cornell.edu>
685
686 * gmalloc.c (memalign) [CYGWIN]: Rename to emacs_memalign
687 (Bug#15094).
688
5b71542d
DA
6892013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
690
691 Utility function and macro to copy Lisp string to C string.
692 * lisp.h (xlispstrdupa): New macro.
693 (xlispstrdup): New prototype.
694 * alloc.c (xlispstrdup): New function.
695 * callint.c (Fcall_interactively):
696 * fileio.c (Ffile_name_directory, Fexpand_file_name)
697 (Fsubstitute_in_file_name):
698 * frame.c (Fmake_terminal_frame): Use xlispstrdupa.
699 * image.c (x_create_bitmap_from_file):
700 * w32term.c (w32_term_init):
701 * xterm.c (x_term_init): Use xlispstrdup.
702
71530c97
LMI
7032013-08-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
704
4ce82fb8
LMI
705 * image.c (imagemagick_load_image): Make animated pictures work.
706 There's still some problems with background color settings, though
707 (bug#14700).
708
71530c97
LMI
709 * decompress.c (unwind_decompress): Always restore point.
710
7510a061
XF
7112013-08-14 Xue Fuqiao <xfq.free@gmail.com>
712
713 * marker.c (set_marker): Reformat documentation.
714
01c3051f
PE
7152013-08-14 Paul Eggert <eggert@cs.ucla.edu>
716
aab1fcdf
PE
717 * xdisp.c (cursor_type_changed): Now static.
718
01c3051f
PE
719 * image.c (imagemagick_filename_hint): New arg HINT_BUFFER.
720 Use changed. This avoids the need to call xmalloc and for the
721 caller to call xfree, and avoids memory leaks in some situations.
722
2084152a
DA
7232013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
724
725 * xdisp.c (adjust_window_ends): Move duplicated code to new function.
726 (try_window, try_window_reusing_current_matrix, try_window_id): Use it.
94a4e898
DA
727 (redisplay_window): If window_end_valid is cleared due to non-zero
728 windows_or_buffers_changed, clear current_matrix_up_to_date_p and
729 so do not call to try_cursor_movement for that window.
2084152a 730
02455cb6
DA
7312013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
732
733 * window.h (struct window): Convert window_end_pos and
734 window_end_vpos from Lisp_Object to ptrdiff_t and int, respectively.
735 (wset_window_end_pos, wset_window_end_vpos): Remove.
736 * dispnew.c (adjust_glyph_matrix):
737 * window.c (Fwindow_end, replace_window, set_window_buffer)
738 (make_window):
739 * xdisp.c (check_window_end, move_it_to, redisplay_internal)
740 (set_vertical_scroll_bar, redisplay_window, try_window)
741 (try_window_reusing_current_matrix, find_first_unchanged_at_end_row)
742 (try_window_id, decode_mode_spec, mouse_face_from_buffer_pos)
743 (note_mouse_highlight): Adjust users.
744 (try_cursor_movement): Likewise. Convert old precondition to eassert.
745 Add comment.
746
da5707e8
DA
7472013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
748
749 Fix --enable-gcc-warnings errors introduced in 2013-08-13 commit.
750 * image.c (imagemagick_filename_hint): Use `const char *' and
751 prefer SSDATA to SDATA to avoid warnings.
752
25554267
DA
7532013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
754
755 Cleanup window fringes, margins and scroll bars adjustments.
756 * window.c (set_window_fringes, set_window_margins)
757 (set_window_scroll_bars, apply_window_adjustment): New functions.
758 (set_window_buffer, Fset_window_margins, Fset_window_fringes)
759 (Fset_window_scroll_bars): Use them.
760
38a2c910
DA
7612013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
762
763 * window.h (struct window): Convert scroll_bar_width
764 from Lisp_Object to integer. Adjust comment.
765 (WINDOW_CONFIG_SCROLL_BAR_WIDTH, WINDOW_CONFIG_SCROLL_BAR_COLS):
766 Adjust users.
767 * window.c (wset_scroll_bar_width): Remove.
768 (make_window): Initialize scroll_bar_width.
769 (Fsplit_window_internal): Use direct assignment.
770 (Fset_window_configuration, save_window_save):
771 Convert Lisp_Object to integer and back where appropriate.
772 (Fset_window_scroll_bars): Adjust user. Return t if any scroll
773 bar was actually changed, and mention this in docstring.
774
2d065031
PE
7752013-08-13 Paul Eggert <eggert@cs.ucla.edu>
776
777 * decompress.c: Minor simplifications.
778 (Fzlib_decompress_region): Don't bother verifying
779 that avail_out <= UINT_MAX, as that was confusing.
780 Mention the restriction in a comment instead.
781 Prefer 'int' to 'ptrdiff_t' when 'int' is wide enough.
782
a5bd5abb
JD
7832013-08-13 Jan Djärv <jan.h.d@swipnet.se>
784
785 * nsmenu.m (x_activate_menubar): Check for OSX >= 10.5
786 (trackingNotification:): Call ns_check_menu_open only for OSX >= 10.5.
787
66e7901a
LMI
7882013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
789
790 * image.c (imagemagick_filename_hint): Check for errors in the
791 alist structure.
792
2fa611b7
EZ
7932013-08-13 Eli Zaretskii <eliz@gnu.org>
794
795 * window.c (Fwindow_margins): Return nil when there's no marginal
796 area, as per the documented API.
797
798 * w32term.c (x_scroll_bar_create): Use ALLOCATE_PSEUDOVECTOR, not
799 Fmake_vector, as scroll bar's struct members are not all Lisp
800 objects now. This avoids crashes in GC.
801
802 * w32term.h (struct scroll_bar): Convert fringe_extended_p to a
803 bool, so its address could be taken.
804
8259030d
LMI
8052013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
806
807 * image.c (imagemagick_filename_hint): New function to possibly
808 apply `image-content-type-suffixes'.
809 (imagemagick_load_image): Use it.
810
866c710e
EZ
8112013-08-13 Eli Zaretskii <eliz@gnu.org>
812
813 * decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil
814 if loading zlib failed.
815
f10490f0
JD
8162013-08-13 Jan Djärv <jan.h.d@swipnet.se>
817
96311be7
JD
818 * nsterm.m (ns_set_vertical_scroll_bar): Fix breakage intruduced by
819 2013-08-13 checkin below. Change bool to BOOL, rule is:
820 All Obj-C code uses BOOL, except for interfaces callable from C.
821
f10490f0
JD
822 * nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).
823
c8ae93b0
DA
8242013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
825
826 * window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
827 * nsterm.m (ns_set_vertical_scroll_bar): Use it. Use convenient
828 bool instead of BOOL.
829 * w32term.h (struct scroll_bar): Convert fringe_extended_p
830 from Lisp_Object to bitfield. Adjust comment.
831 * w32term.c (x_scroll_bar_create): Adjust user.
832 Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
833 * xterm.c (XTset_vertical_scroll_bar): Likewise.
834 Use bool for boolean.
835 * xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
836 to `unsigned int' when defining a bitfield.
837
53b64418
PE
8382013-08-13 Paul Eggert <eggert@cs.ucla.edu>
839
840 * decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
841
eeaf9bf3
DA
8422013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
843
844 * window.h (struct window): Convert left_margin_cols and
845 right_margin_cols from Lisp_Objects to integers. Adjust comment.
846 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
847 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
848 Adjust users.
849 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
850 Adjust comment.
851 (showing_window_margins_p, update_window_line, update_frame_1):
852 * fringe.c (draw_fringe_bitmap_1):
853 * xdisp.c (window_box_width): Adjust users.
854 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
855 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
856 Use direct assignment.
857 (Fset_window_configuration, save_window_save, Fwindow_margins):
858 Convert Lisp_Object to integer and back where appropriate.
859 (Fset_window_margins): Adjust user. Return t if any margin
860 was actually changed, and mention this in docstring.
861
956720af
XF
8622013-08-13 Xue Fuqiao <xfq.free@gmail.com>
863
f73f4ce6 864 * syntax.c (forward_word):
956720af
XF
865 * cmds.c (forward_char, backward_char): Mention the optional argument.
866
9e37ee3b
DA
8672013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
868
869 * window.h (struct window): Convert left_fringe_width
870 and right_fringe_width from Lisp_Objects to integers.
871 Adjust comment.
872 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
873 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
874 * window.c (wset_left_fringe_width, wset_right_fringe_width):
875 Remove.
876 (make_window): Initialize new integer fields to -1.
877 (Fsplit_window_internal): Use direct assignment.
068f9124
SM
878 (Fset_window_configuration, save_window_save):
879 Convert Lisp_Object to integer and back where appropriate.
9e37ee3b
DA
880 (Fset_window_fringes): Adjust user. Return t if any fringe
881 was actually changed, and mention this in docstring.
882
e4375ca7
DA
8832013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
884
885 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
9cda66e4
DA
886 * nsfns.m (x_set_cursor_type):
887 * w32fns.c (x_set_cursor_type):
888 * xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
889 * xdisp.c (set_frame_cursor_types): ...but in common code.
e4375ca7 890
a45543bc
DA
8912013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
892
893 * font.c (clear_font_cache): New function, stripped from...
894 (Fclear_font_cache): ...here, which now uses the function
895 above. Adjust comment.
896 * font.h (clear_font_cache): Add prototype.
897 * xfaces.c (clear_face_cache): Use clear_font_cache.
898
ae966a86
DA
8992013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
900
901 * window.c (Fset_window_start): Compare `w', not `window' because
902 `w' might not be equal to `window' after call to decode_live_window.
903
297a545b
PE
9042013-08-12 Paul Eggert <eggert@cs.ucla.edu>
905
906 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
907 This fixes a problem introduced by the Bug#15035 patch
908 when using GPG. Reported by Herbert J. Skuhra.
909
aa942e2b
EZ
9102013-08-12 Eli Zaretskii <eliz@gnu.org>
911
912 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
913 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
914 not yet initialized.
915
7699d09e
LMI
9162013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
917
918 * decompress.c (Fzlib_decompress_region): Support zlib
919 decompression, too, and rename.
920
1d238bc7
PE
9212013-08-12 Paul Eggert <eggert@cs.ucla.edu>
922
923 Minor zlib configuration tweaks.
924 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
925 Don't assume presence of fn_inflateInit2_ zlib internal function.
926
8a44a184
LMI
9272013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
928
929 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
930 include the zlib prefix.
931
594a4307
EZ
9322013-08-12 Eli Zaretskii <eliz@gnu.org>
933
934 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
935 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
936 define static variables that are pointers to zlib functions to be
937 dynamically loaded.
938 (init_zlib_functions) [WINDOWSNT]: New function.
939 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
940 New macros.
941 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
942 macros instead of invoking the zlib functions directly.
068f9124
SM
943 (syms_of_decompress): DEFSYM Qzlib_dll.
944 Staticpro Szlib_available_p.
594a4307 945
d2e113bc
DA
9462013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
947
948 Avoid looping over all frame windows to freeze and unfreeze.
949 * window.h (struct window): Drop frozen_window_start_p.
950 (freeze_window_starts): Drop prototype.
951 * frame.h (struct frame): New frozen_window_starts flag.
952 (FRAME_WINDOWS_FROZEN): New macro.
953 * window.c (freeze_window_start, freeze_window_starts):
954 Remove.
955 (select_window, replace_window): Adjust users.
956 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
957 (window_frozen_p): New function.
958 (redisplay_window): Use it.
959
94fcd171
PE
9602013-08-12 Paul Eggert <eggert@cs.ucla.edu>
961
962 Fix some fd issues when running subprocesses (Bug#15035).
963 Fix bugs that can leak files or file descriptors on errors.
964 Don't unlink open temp files, as that's hard for users to diagnose
965 when things go awry (e.g., temp disk exhausted).
966 Don't bother to lock temp files. Check for invalid recursion.
967 * callproc.c (synch_process_fd): Remove. All uses removed.
968 (synch_process_tempfile): New var or macro.
969 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
970 New constants.
971 (record_kill_process): New arg, the temp name. All callers changed.
972 (delete_temp_file): Now just a simple wrapper around unlink.
973 (call_process_kill): New arg, the call_process_fd array.
974 Close them all. Clear synch_process_pid. Remove the temp file,
975 or arrange for it to be removed.
976 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
977 that's been moved to synch_process_tempfile. Caller changed.
978 Do not remove the tempfile; that's now call_process_kill's
979 responsibility.
980 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
981 call_process_kill; the caller now does that.
982 (call_process_cleanup): Do not close the process fd; that's now
983 call_process_kill's responsibility.
984 (Fcall_process): Implement via new function call_process, which
985 has most of the old body of Fcall_process, but with a different API.
986 (call_process): New function that does not open or close filefd if
987 it is nonnegative. Record which fds need to be closed, and let
988 call_process_kill close (and remove the tempfile, on MSDOS) on error.
989 Signal an error if invoked recursively (could be done via a hook).
990 Simplify creation of the tempfile in the MSDOS case.
991 Don't create the output file until after checking for the executable.
992 Report any failure to open /dev/null.
993 Don't open /dev/null for writing twice; once is enough.
994 Don't create pipe if all output is being discarded or sent to file.
995 Don't worry about setting up the coding system or reading from the
996 pipe if all output is being discarded.
997 Hoist fd_error local into top level, to lessen block nesting.
998 Don't record deleted pid here; now done by Fcall_process_region.
999 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
1000 and note its success in synch_process_tempfile.
1001 Do not leak resources when child_setup fails.
1002 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
1003 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
1004 (create_temp_file): Now returns open fd, with an additional
1005 Lisp_Object * argument to return the name. All callers changed.
1006 Do not close the file; rewind it instead, and leave it open for
1007 the caller. Do not lock the temp file. Unwind-protect the file
1008 and the file-descriptor.
1009 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
1010 If an asynchrounous process, record it here, not in call_process.
1011 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
1012 * eval.c (set_unwind_protect): New function.
1013 * fileio.c (write_region): New function, generalized from the
1014 old Fwrite_region. Do not lock temp files.
1015 (Fwrite_region): Use it.
1016 * lisp.h (set_unwind_protect, write_region): New decls.
1017 * process.c: Include <verify.h>.
1018 (make_process): Mark fds as initially closed.
1019 (deleted_pid_list): Now a list of pid-filename pairs.
1020 All uses changed.
1021 (close_process_fd): New function.
1022 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
1023 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
1024 New constants. Verify that their number matches PROCESS_OPEN_FDS.
1025 (create_process, create_pty, Fmake_serial_process)
1026 (server_accept_connection): Record which fds need to be closed,
1027 and let deactivate_process close them.
1028 (Fmake_network_process): Do not discard the unwind-protect
1029 until it's safe to do so.
1030 (deactivate_process): Close the fds opened by create_process etc.
1031 (Fprocess_send_eof): Adjust to new way of recording open fds.
1032 Report an error if /dev/null can't be opened, instead of aborting.
1033 * process.h (PROCESS_OPEN_FDS): New constant.
1034 (struct Lisp_Process): New member open_fds.
1035 (record_kill_process, record_deleted_pid): Adjust signatures.
1036 (record_deleted_pid): Move decl here ...
1037 * syswait.h (record_deleted_pid): ... from here.
1038
d0e615c3
PE
10392013-08-11 Paul Eggert <eggert@cs.ucla.edu>
1040
1041 * decompress.c: Fix bugs with large buffers and weird inputs.
1042 Tune a bit. Reindent as per usual Emacs style.
1043 (BUFFER_SIZE): Remove.
1044 (Fdecompress_gzipped_region): Do not mishandle input buffers with
1045 more than UINT_MAX bytes. Decompress into the gap instead of into
1046 an auto buffer, as this should avoid copying. Return nil if
1047 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
1048 set immediate_quit; we shouldn't trust zlib code that much.
1049
313546eb
LMI
10502013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1051
99a32242
LMI
1052 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
1053 errors, and really move the gap to where we want it.
1054
313546eb
LMI
1055 * lisp.h: Include decompress.c support.
1056
1057 * emacs.c (main): Include decompress.c support.
1058
1059 * Makefile.in: Include -lz if present.
1060
d2d699ac
JD
10612013-08-11 Jan Djärv <jan.h.d@swipnet.se>
1062
f90e3ebd
JD
1063 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
1064 (initWithTitle:): Initialize frame to 0.
1065 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
068f9124 1066 (fillWithWidgetValue:frame:): Rename from
f90e3ebd
JD
1067 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
1068
1069 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
1070 fillWithWidgetValue:frame:
1071
423d3b3f
JD
1072 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
1073 remove memory leak warnings.
1074
d2d699ac
JD
1075 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
1076 (ns_check_menu_open): Handle menu == nil. Remove assignment to
1077 menu_pending_title.
1078
1079 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
1080 (x_activate_menubar): Update the whole menu.
1081 (trackingNotification:): Call ns_check_menu_open if tracking ends.
1082 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
1083 current event is not NSSystemDefined (Bug#15001).
1084 Call ns_check_menu_open only if trackingMenu is 2.
1085 (menuDidClose:): New method, decrease trackingMenu.
1086 (fillWithWidgetValue:setDelegate:): New method.
1087 (fillWithWidgetValue:): Call the above.
1088
1089 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
1090
7d652d97
PE
10912013-08-11 Paul Eggert <eggert@cs.ucla.edu>
1092
1093 Omit some unnecessary casts.
1094 Many of these go back to the old pre-C89 days, when they may have
1095 been needed, but we've been assuming C89 or later for a while now.
1096 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
1097 (live_float_p, live_misc_p, live_vector_p):
1098 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
1099 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
1100 (defvar_per_buffer):
1101 * callint.c (Fcall_interactively):
1102 * doc.c (Fsubstitute_command_keys):
1103 * filelock.c (get_boot_time):
1104 * frame.c (xrdb_get_resource):
1105 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
1106 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
1107 (xg_get_file_name_from_selector, menuitem_destroy_callback)
1108 (menuitem_highlight_callback, menu_destroy_callback)
1109 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
1110 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
1111 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
1112 (xg_tool_bar_help_callback, tb_size_cb):
1113 * image.c (xpm_alloc_color, png_read_from_memory)
1114 (png_read_from_file, png_load_body, our_memory_skip_input_data)
1115 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
1116 (syms_of_image):
1117 * keymap.c (describe_map):
1118 * nsfns.m (Fns_display_monitor_attributes_list):
1119 * nsmenu.m (process_dialog:):
1120 * nsterm.m (hold_event):
1121 * process.c (wait_reading_process_output):
1122 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
1123 * scroll.c (do_direct_scrolling, scrolling_1):
1124 * termcap.c (tgetent):
1125 * window.c (check_window_containing, add_window_to_list)
1126 (freeze_window_starts):
1127 * xdisp.c (compare_overlay_entries, vmessage):
1128 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
1129 (x_get_monitor_attributes_xrandr)
1130 (Fx_display_monitor_attributes_list, x_display_info_for_name)
1131 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
1132 * xfont.c (xfont_match, xfont_open):
1133 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
1134 (menubar_selection_callback, menu_position_func)
1135 (popup_selection_callback, create_and_show_popup_menu)
1136 (dialog_selection_callback, create_and_show_dialog):
1137 * xrdb.c (x_get_string_resource):
1138 (main) [TESTRM]:
1139 * xsmfns.c (x_session_check_input):
1140 * xterm.c (x_draw_glyphless_glyph_string_foreground)
1141 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
1142 (xaw_jump_callback, xaw_scroll_callback):
1143 Omit unnecessary casts.
1144
9acc1074
PE
11452013-08-10 Paul Eggert <eggert@cs.ucla.edu>
1146
1147 Minor string-length refactoring.
1148 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
1149 * frame.c (make_monitor_attribute_list):
1150 Prefer build_string to strlen + make_string.
1151
361c0eb8
JD
11522013-08-10 Jan Djärv <jan.h.d@swipnet.se>
1153
1154 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
1155 don't check minor_code (Bug#14417).
1156
14ba0822
EZ
11572013-08-09 Eli Zaretskii <eliz@gnu.org>
1158
1159 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
1160 vertical positions instead. This avoids calling MATRIX_ROW with
1161 row numbers that are possibly beyond valid limits. (Bug#15064)
1162
309f24d1
DA
11632013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
1164
1165 Use xstrdup and build_unibyte_string where applicable.
1166 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
1167 * xfns.c (x_window):
1168 * xrdb.c (x_get_customization_string):
1169 * xterm.c (xim_initialize):
1170 * w32fns.c (w32_window): Use xstrdup.
1171 (w32_display_monitor_attributes_list):
1172 * emacs.c (init_cmdargs):
1173 * keyboard.c (PUSH_C_STR):
1174 * nsfont.m (nsfont_open):
1175 * sysdep.c (system_process_attributes):
1176 * w32.c (system_process_attributes):
1177 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
1178
55902276
EZ
11792013-08-09 Eli Zaretskii <eliz@gnu.org>
1180
1181 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
1182 variables of these types so that GDB would know about them, as aid
1183 for debugging fatal exceptions. (Bug#15024) See also
1184 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
1185 discussions.
1186
10bf7f5a
JD
11872013-08-08 Jan Djärv <jan.h.d@swipnet.se>
1188
1189 * nsterm.m (ns_update_begin): Don't change clip path if it would be
1190 larger than the NSWindow (Bug#14934).
1191
65620264
DA
11922013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1193
1194 Redesign redisplay interface to drop global variable updated_window.
1195 Always pass currently updated window as a parameter to update routines.
1196 * dispextern.h (updated_window): Remove declaration.
1197 (struct redisplay_interface): Pass window parameter to
1198 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
1199 and after_update_window_hook.
1200 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
1201 Adjust prototypes.
1202 * dispnew.c (updated_window): Remove.
1203 (redraw_overlapped_rows, update_marginal_area, update_text_area)
1204 (update_window_line): Adjust to match redisplay interface changes.
1205 * nsterm.m (ns_update_window_begin, ns_update_window_end)
1206 (ns_scroll_run, ns_after_update_window_line):
1207 * w32term.c (x_update_window_begin, x_update_window_end)
1208 (x_after_update_window_line, x_scroll_run):
1209 * xterm.c (x_update_window_begin, x_update_window_end)
1210 (x_after_update_window_line, x_scroll_run):
1211 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1212 Likewise. Adjust comments where appropriate.
1213 (x_cursor_to): Simplify because this is always called during window
1214 update (but install debugging check anyway).
1215 (expose_window): Check must_be_updated_p flag to see whether this
1216 function is called during window update.
1217
628fdc56
DA
12182013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1219
1220 Do not reset window modification event counters excessively.
1221 These leftovers and poor man's tricky methods to catch extra
1222 redisplay's attention are no longer needed.
1223 * frame.c (set_menu_bar_lines_1):
1224 * minibuf.c (read_minibuf_unwind):
1225 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
1226 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
1227 (window_scroll_line_based, Fset_window_configuration):
1228 * xdisp.c (redisplay_window): Do not reset last_modified and
1229 last_overlay_modified counters.
1230
8fd9c92e
JD
12312013-08-07 Jan Djärv <jan.h.d@swipnet.se>
1232
1233 * xselect.c (x_send_client_event): Set send_event and serial, memset
1234 data.l as it might be bigger than data.b. Use 24 bit mask to
1235 XSendEvent (Bug#15034).
1236
0ee18172
EZ
12372013-08-07 Eli Zaretskii <eliz@gnu.org>
1238
1239 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
1240 for TTY frames that are not the top frame on their console.
1241 (Bug#14616)
1242
16ddd1a6
MR
12432013-08-07 Martin Rudalics <rudalics@gmx.at>
1244
1245 * w32term.c (w32fullscreen_hook): Really maximize frame when
1246 asked for (Bug#14841).
1247
d2a95ffb
DA
12482013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1249
1250 Prefer selected_window to Fselected_window, likewise for frames.
1251 * buffer.c (Fbuffer_swap_text):
1252 * data.c (Fvariable_binding_locus):
1253 * window.c (run_window_configuration_change_hook): Adjust users.
1254 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
1255 Use decode_live_frame.
1256
170da1ec
DA
12572013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1258
1259 Be more careful if selected window shows the buffer other than current,
1260 use window_outdated only if this is not so. This change should also
1261 address some weird issues discussed in Bug#13012.
1262 * window.h (window_outdated): New prototype.
1263 * window.c (window_outdated): Now here. Convert from static and
1264 always assume window's buffer.
1265 (Fwindow_end, Fwindow_line_height): Use it.
1266 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
1267 and always assume window's buffer.
1268 (redisplay_window): Adjust user.
e5eefe9b 1269 (redisplay_internal): Call to reconsider_clip_changes once and
170da1ec
DA
1270 check whether mode line should be updated only if selected window
1271 shows current buffer.
1272 (run_window_scroll_functions): Use eassert for debugging check.
1273 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
1274
56b5d5b1
DA
12752013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1276
1277 * window.c (window_scroll, window_scroll_pixel_based)
1278 (window_scroll_line_based): Use bool for booleans.
1279
2878ba7e
PE
12802013-08-06 Paul Eggert <eggert@cs.ucla.edu>
1281
1282 * process.c: Fix minor off-by-one issues in descriptor counts.
1283 This shouldn't fix any real bugs, but it cleans up the code a bit.
1284 (max_process_desc, max_input_desc): -1, not 0, means none.
1285 All uses changed.
1286 (delete_input_desc): New function.
1287 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
1288 (deactivate_process): Scan backwards when recomuting max_process_desc;
1289 that should be faster.
1290 (init_process_emacs): Initialize max_input_desc.
1291
e30b79c1
DA
12922013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1293
1294 Use region cache to speedup bidi_find_paragraph_start.
1295 * buffer.h (struct buffer): New member bidi_paragraph_cache.
1296 Rename cache_long_line_scans to cache_long_scans.
1297 * buffer.c (bset_cache_long_line_scans): Rename to
1298 bset_cache_long_scans.
1299 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
1300 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
1301 into account.
1302 (syms_of_buffer): Rename cache-long-line-scans to
1303 cache-long-scans. Adjust docstring.
1304 * search.c (newline_cache_on_off):
1305 * indent.c (width_run_cache_on_off): Adjust users.
1306 * bidi.c (bidi_paragraph_cache_on_off): New function.
1307 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
068f9124
SM
1308 * insdel.c (prepare_to_modify_buffer):
1309 Invalidate bidi_paragraph_cache if enabled.
e30b79c1 1310
00012b86
DA
13112013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1312
1313 Invalidate region caches only if buffer text is going to be changed.
1314 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
1315 (modify_text): ...new prototype.
1316 (prepare_to_modify_buffer_1): New prototype.
1317 * textprop.c (modify_region): Rename to...
1318 (modify_text_properties): ...new function.
1319 (add_text_properties_1, set_text_properties, Fremove_text_properties)
1320 (Fremove_list_of_text_properties): Adjust users.
1321 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
1322 (modify_text): ...new function.
1323 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
1324 (prepare_to_modify_buffer_1): ...new function.
1325 * casefiddle.c (casify_region):
1326 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
1327 (Ftranspose_regions): Use modify_text.
1328
dc6c0eda
SM
13292013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
1330
1331 * lisp.mk (lisp): Add nadvice.elc.
1332
8f3a2c26
DA
13332013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
1334
1335 New macro to iterate over live buffers similar to frames.
1336 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
1337 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
1338 Declare buffer-related variables here to offload lisp.h.
1339 * buffer.c (Vbuffer_alist): Adjust comment.
1340 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
1341 (other_buffer_safely):
1342 * data.c (store_symval_forwarding):
1343 * dispnew.c (Fframe_or_buffer_changed_p):
1344 * fileio.c (Fdo_auto_save):
1345 * filelock.c (unlock_all_files):
1346 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
1347
e0fdb694
PE
13482013-08-04 Paul Eggert <eggert@cs.ucla.edu>
1349
1350 Fix some minor races in hosts lacking mkostemp (Bug#15015).
1351 * callproc.c (create_temp_file):
1352 * filelock.c (create_lock_file):
1353 Assume mkostemp, since it's now provided by Gnulib.
1354
63f5c6c2
EZ
13552013-08-04 Eli Zaretskii <eliz@gnu.org>
1356
1357 * w32.c (mkostemp): New function.
1358 (mktemp): Remove, no longer used. Most of the code reused in
1359 mkostemp. (Bug#15015)
484ab239 1360 (mktemp): Don't undef.
63f5c6c2 1361
f0b79313
DA
13622013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
1363
1364 * dispnew.c (glyph_matrix_count, glyph_pool_count):
1365 Move under GLYPH_DEBUG and ENABLE_CHECKING.
1366 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
1367 (free_glyph_pool, check_glyph_memory): Likewise for
1368 all users. Adjust comments where appropriate.
1369
98f638d6
PE
13702013-08-03 Paul Eggert <eggert@cs.ucla.edu>
1371
1372 * composite.h: Minor fixups.
1373 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
1374 to fix a misspelling, and change it to an inline function while
1375 we're at it (it need not be a macro). All uses changed.
1376 (composition_method, composition_valid_p):
1377 Rewrite to avoid assignments in if-conditions.
1378
75c59fb3
DA
13792013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
1380
1381 Do not use global Lisp_Object in composition macros.
1382 * composite.h (composition_temp): Remove declaration.
1383 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
1384 (composition_method, composition_valid_p): ...inline functions.
416a3e01 1385 (compose_region): Remove the leftover.
75c59fb3
DA
1386 * composite.c (composition_temp): Remove.
1387 (run_composition_function, update_compositions)
1388 (composition_compute_stop_pos, composition_adjust_point)
1389 (Ffind_composition_internal):
1390 * coding.c (handle_composition_annotation):
1391 * xdisp.c (handle_composition_prop, check_point_in_composition):
1392 Related users changed.
1393
a10c8269
DA
13942013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
1395
1396 Drop FRAME_PTR typedef.
1397 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
1398 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
1399 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
1400 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
1401 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
1402 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
1403 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
1404 All related users changed.
1405
a104f656
SM
14062013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1407
1408 * eval.c (default_toplevel_binding): New function.
1409 (Fdefvar): Use it.
1410 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
1411 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
1412 (syms_of_eval): Export them.
1413 * data.c (Fdefault_value): Micro cleanup.
1414 * term.c (init_tty): Use "false".
1415
4b5c9326
DA
14162013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1417
1418 Fix X GC leak in GTK and raw (no toolkit) X ports.
1419 * xterm.c (x_free_frame_resources): If white and black relief
1420 GCs are allocated, always free them here.
1421 * xfns.c (x_make_gc): Omit redundant initialization.
1422 * widget.c (create_frame_gcs): Remove the leftover.
1423 (EmacsFrameDestroy): Do nothing because all GCs are now freed
1424 in x_free_frame_resources.
1425
b19aa636
JD
14262013-08-02 Jan Djärv <jan.h.d@swipnet.se>
1427
1428 * nsterm.m (windowWillResize:toSize:): Only change title if
1429 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
1430 modifying it.
1431 (viewDidEndLiveResize): New method.
1432
1433 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
1434 inside NS_IMPL_COCOA.
1435
af1f7e06
DA
14362013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1437
1438 * insdel.c (adjust_after_replace, replace_range, del_range_2):
1439 Do not check whether undo is enabled because record_insert and
1440 record_delete does that themselves.
1441
65b02bb9
DA
14422013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1443
1444 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
1445 member which is not really used any more.
1446 (FRAME_XIC_BASE_FONTNAME): Remove.
1447 * xfns.c (xic_free_fontset): Adjust user.
1448 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
1449 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
1450 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
1451 (xdialog_show): Use eassert for debugging check.
7ee0f047 1452 * w32term.c (x_unfocus_frame): Remove unused dummy function.
65b02bb9 1453
6318cde0
PE
14542013-08-01 Paul Eggert <eggert@cs.ucla.edu>
1455
1456 * fileio.c, fns.c (merge): Move extern decl from here ...
1457 * lisp.h (merge): ... to here.
1458
6c1a09ba
DA
14592013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1460
1461 Fix last font-related change.
1462 * w32font.h (w32font_list_internal, w32font_match_internal):
1463 Fix prototype.
1464 * w32uniscribe.c (uniscribe_list, uniscribe_match):
1465 (uniscribe_list_family): Adjust to match font API change.
1466 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
1467 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
1468
f8c20208
DA
14692013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1470
1471 * frame.h (FRAME_MOUSE_UPDATE):
1472 * nsterm.m (ns_frame_up_to_date): Omit redundant check
1473 whether hlinfo->mouse_face_mouse_frame is non-NULL.
1474
fdb396e2
DA
14752013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1476
1477 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
1478 * font.h (struct font_driver): Change list, match, and list_family
1479 functions to accept struct frame * as first arg.
068f9124
SM
1480 * font.c (font_score, font_compare, font_sort_entities):
1481 Remove prototypes.
fdb396e2
DA
1482 (font_sort_entities, font_list_entities, font_select_entity):
1483 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
1484 match font API change.
1485 * xfont.c (xfont_list, xfont_match, xfont_list_family):
1486 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
1487 * ftxfont.c (ftxfont_list, ftxfont_match):
1488 * xftfont.c (xftfont_list, xftfont_match):
1489 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
1490 * w32font.c (w32font_list, w32font_match, w32font_list):
1491 (w32font_list_internal, w32_font_match_internal): Likewise.
1492 * xfaces.c (Fx_family_fonts): Adjust user.
1493
52b8a085
DA
14942013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1495
1496 Do not use pure Xism x_wm_set_icon_position in non-X ports.
1497 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
1498 only if HAVE_X_WINDOWS is in use.
1499 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
1500 * nsterm.m (x_wm_set_icon_position): Remove no-op.
1501 * w32term.c (x_wm_set_icon_position): Likewise.
1502 * w32fns.c (x_icon): Adjust user.
1503
c791c18e
DA
15042013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1505
1506 * xterm.c (last_mouse_press_frame): Remove the
1507 leftover which is not really used any more.
1508 (handle_one_xevent, syms_of_xterm): Adjust users.
1ca6cc28
DA
1509 (x_flush): Call XFlush once per each X display, not frame.
1510 This is better because this code always unconditionally skips
1511 non-X frames in Vframe_list and issues the only XFlush if we
1512 have more than one X frame on the same X display.
2f935d86
DA
1513 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
1514 Use bool for booleans.
1515 (x_draw_glyph_string_background, cvt_string_to_pixel):
1516 (cvt_pixel_dtor): Drop unnecessary prototypes.
1517 * xterm.h (x_display_ok): Adjust prototype.
c791c18e 1518
f435830e
DA
15192013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1520
1521 Drop unnecessary functions that deals with frame pixel size.
1522 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
1523 (x_pixel_height): Drop prototypes.
1524 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
1525 (x_pixel_height): Drop implementations.
1526 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
1527 which should be always valid for window frame.
1528 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
1529 * w32menu.c (Fx_popup_dialog):
1530 * xmenu.c (Fx_popup_dialog): Likewise for both.
1531
84231434
DA
15322013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1533
1534 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
1535 frame parameters and call to Fmodify_frame_parameters just once.
4c131798
DA
1536 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
1537 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
1538 and mention nil frame in docstring.
84231434 1539
959067a1
DA
15402013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1541
1542 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
1543 (x_figure_window_size): Likewise. Adjust to return long.
1544 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
1545 (toplevel): Move Qterminal_live_p to...
1546 * terminal.c (toplevel): ...here, make it static, and...
1547 (syms_of_terminal): ...DEFSYM here.
1548 * frame.h (Qterminal_live_p): Remove declaration.
1549 (make_frame, x_figure_window_size): Adjust prototype.
1550 * nsfns.m (Fx_create_frame): Use long for window flags.
1551
f4b169ce
PE
15522013-07-30 Paul Eggert <eggert@cs.ucla.edu>
1553
1554 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
1555 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
1556 Do not assume that emacs_close (INT_MAX) is a no-op.
1557
bee6a2c7
DA
15582013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1559
1560 * xfaces.c (make_face_cache): For struct face_cache, prefer
1561 xmalloc to xzalloc and so avoid redundant call to memset.
1562 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
1563
d7e6881a
DA
15642013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1565
1566 * fringe.c (draw_window_fringes, update_window_fringes)
1567 (compute_fringe_widths):
1568 * w32term.c (x_draw_glyph_string):
1569 * window.c (candidate_window_p, Frecenter):
1570 * xfaces.c (realize_basic_faces, realize_default_face)
1571 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
1572 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
1573 * xfns.c (x_set_cursor_color, xic_free_xfontset):
1574 * xmenu.c (Fx_menu_bar_open_internal):
1575 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
1576 * xsettings.c (xft_settings_event):
1577 * xterm.c (x_draw_glyph_string, x_had_errors_p):
1578 Use bool for booleans. Adjust style and comments where
1579 appropriate.
1580 * dispextern.h (draw_window_fringes, update_window_fringes)
1581 (compute_fringe_widths):
1582 * xterm.h (x_had_errors_p): Adjust prototype.
1583
ec3058af
DA
15842013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1585
1586 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
1587 CHECK_LIST. Rewrite the loop to avoid useless local variable.
1588
218e0637
DA
15892013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
1590
1591 * fns.c (toplevel): Remove comment before Fsafe_length because
1592 it checks for QUIT.
1593
e560aba9
PE
15942013-07-28 Paul Eggert <eggert@cs.ucla.edu>
1595
1596 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
1597
2e5ce5de
EZ
15982013-07-28 Eli Zaretskii <eliz@gnu.org>
1599
1600 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
1601 frame which got the message is still alive, before dereferencing
1602 its pointer. (Bug#14970)
1603
1604 * frame.c (delete_frame): Test "this" frame's minibuffer window to
1605 be a live window, before using it as such. (Bug#14970)
1606
e95da6d3
EZ
16072013-07-27 Eli Zaretskii <eliz@gnu.org>
1608
1609 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
1610 w32_detect_focus_change instead of doing part of its job by hand.
1611 This fixes the problem whereby FOCUS_OUT events were not sent to
1612 the event queue.
1613
a8f93651
EZ
16142013-07-26 Eli Zaretskii <eliz@gnu.org>
1615
fec92060
EZ
1616 * process.c (Fprocess_list): Doc fix.
1617
a8f93651
EZ
1618 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
1619 being re-exposed only if it didn't ask to become visible.
1620 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
1621 was previously iconified. (Bug#14841)
1622 (x_iconify_frame): Mark the frame iconified.
1623
d5a7a9d9
PE
16242013-07-26 Paul Eggert <eggert@cs.ucla.edu>
1625
1626 Fix minor problems found by static checking.
1627 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
1628 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
1629
56ea7291
SM
16302013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
1631
1632 * eval.c (set_specpdl_old_value): New function.
1633 (unbind_to): Minor simplification.
1634 (get_backtrace_frame): New function.
1635 (Fbacktrace_frame): Use it. Add `base' argument.
1636 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
1637 (syms_of_eval): Export backtrace-eval.
1638 * xterm.c (x_focus_changed): Simplify.
1639
9d611ffe
PE
16402013-07-25 Paul Eggert <eggert@cs.ucla.edu>
1641
1642 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
1643
999c74e3
EZ
16442013-07-24 Eli Zaretskii <eliz@gnu.org>
1645
1646 * xdisp.c (redisplay_window): Instead of moving point out of
1647 scroll margin, reject the force_start method, and try scrolling
1648 instead. (Bug#14780)
1649
198fa217
KB
16502013-07-24 Ken Brown <kbrown@cornell.edu>
1651
1652 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
1653 (Bug#14944).
1654
53840e55
PE
16552013-07-24 Paul Eggert <eggert@cs.ucla.edu>
1656
1657 * eval.c (Fprogn): Do not check that BODY is a proper list.
1658 This undoes the previous change. The check slows down the
1659 interpreter, and is not needed to prevent a crash. See
1660 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
1661
60967f56
GM
16622013-07-23 Glenn Morris <rgm@gnu.org>
1663
1664 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
1665
9ca960e2
PE
16662013-07-23 Paul Eggert <eggert@cs.ucla.edu>
1667
a29c3e6d
PE
1668 Port to GNU/Linux systems with tinfo but not ncurses.
1669 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
1670 to decide whether ncurses is being used. Without this change,
1671 GCC complains about tgetent not being declared, on a system
1672 that has tinfo installed but ncurses not installed.
1673
f274311c
PE
1674 * eval.c (Fprogn): Check that BODY is a proper list.
1675
16b0520a
PE
1676 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
1677 * data.c (Fsetq_default):
1678 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
1679 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
1680 (Fcondition_case):
1681 Tune by taking advantage of the fact that ARGS is always a list
1682 when a function is declared to have UNEVALLED args.
1683
9ca960e2
PE
1684 * emacsgtkfixed.c: Port to GCC 4.6.
1685 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
1686
afacaa1b
JB
16872013-07-23 Juanma Barranquero <lekktu@gmail.com>
1688
1689 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
1690 here to silence compiler warnings.
1691
368a85a4
PE
16922013-07-22 Paul Eggert <eggert@cs.ucla.edu>
1693
1694 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
1695 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
1696 from messing up Emacs's 'struct frame' (Bug#14923).
1697
f4e891b5
PE
16982013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1699
1700 * alloc.c (make_save_ptr_ptr): Define this function.
1701 It was inadvertently omitted. It's needed only if
1702 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
1703
96c8b65e
JD
17042013-07-21 Jan Djärv <jan.h.d@swipnet.se>
1705
1706 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
1707 frame have focus (Bug#14895).
1708
ee010797
PE
17092013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1710
1711 Avoid vfork-related deadlock more cleanly.
1712 * callproc.c (child_setup): When the child's exec fails, output
1713 the program name, as that's more useful. Use O_NONBLOCK to avoid
1714 deadlock.
1715 * process.c (create_process_1): Remove; no longer needed.
1716 (create_process): Remove timer hack; no longer needed, now that
1717 the child avoids deadlock.
1718
f0398ec1 17192013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
1720
1721 * image.c (Fimage_flush): Fix doc typo.
1722
b2a069c2
PE
17232013-07-20 Paul Eggert <eggert@cs.ucla.edu>
1724
6496aec9
PE
1725 Fix array bounds violation when pty allocation fails.
1726 * process.c (PTY_NAME_SIZE): New constant.
1727 (pty_name): Remove static variable; it's now auto.
1728 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
1729 Take pty_name as an arg rather than using a static variable.
1730 All callers changed.
1731 (create_process): Recover pty_flag from process, not from volatile local.
1732 (create_pty): Stay inside array even when pty allocation fails.
1733 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
1734
b2a069c2
PE
1735 * lread.c (Fload): Avoid initialization only when lint checking.
1736 Mention that it's needed only for older GCCs.
1737
99107004
KH
17382013-07-20 Kenichi Handa <handa@gnu.org>
1739
1740 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
1741 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
1742
6b1b199d
AS
17432013-07-20 Andreas Schwab <schwab@linux-m68k.org>
1744
1745 * lread.c (Fload): Avoid uninitialized warning.
1746
4195afc3
PE
17472013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1748
3f5bef16
PE
1749 Fix some minor file descriptor leaks and related glitches.
1750 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
1751 (create_lock_file): Use write, not emacs_write.
1752 * image.c (slurp_file, png_load_body):
1753 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
1754 (server_accept_connection):
1755 Don't leak an fd on memory allocation failure.
1756 * image.c (slurp_file): Add a cheap heuristic for growing files.
1757 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
1758 as that's what the other routines do. Maybe input need not be
1759 blocked at all, but it's better to be consistent.
1760 Avoid undefined behavior when strlen is zero.
1761
4195afc3
PE
1762 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
1763 (NSTATICS): Now a constant; doesn't need to be a macro.
1764
a1aeeffe
RS
17652013-07-19 Richard Stallman <rms@gnu.org>
1766
1767 * coding.c (decode_coding_utf_8): Add simple loop for fast
1768 processing of ASCII characters.
1769
63b34baa
PE
17702013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1771
1772 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
1773
621dd9ac
EZ
17742013-07-19 Eli Zaretskii <eliz@gnu.org>
1775
1776 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
1777 unportable 'struct x_display_info'.
1778 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
1779 is a portable type.
1780
1396ac86
PE
17812013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1782
ab9980cd
PE
1783 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
1784 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
1785 or fscanf fails.
1786 (system_process_attributes): Prefer plain char to unsigned char
1787 when either will do. Clean up properly if interrupted or if
068f9124
SM
1788 memory allocations fail. Don't assume sscanf succeeds.
1789 Remove no-longer-needed workaround to stop GCC from whining.
1790 Read command-line once, instead of multiple times. Check read status a
ab9980cd
PE
1791 bit more carefully.
1792
1396ac86
PE
1793 Fix obscure porting bug with varargs functions.
1794 The code assumed that int is treated like ptrdiff_t in a vararg
1795 function, which is not a portable assumption. There was a similar
1796 -- though these days less likely -- porting problem with various
1797 assumptions that pointers of different types all smell the same as
1798 far as vararg functions is conserved. To make this problem less
1799 likely in the future, redo the API to use varargs functions.
1800 * alloc.c (make_save_value): Remove this vararg function.
1801 All uses changed to ...
1802 (make_save_int_int_int, make_save_obj_obj_obj_obj)
1803 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
1804 New functions.
1805 (make_save_ptr): Rename from make_save_pointer, for consistency with
1806 the above. Define only on platforms that need it. All uses changed.
1807
4d19d194
PE
18082013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1809
1810 * keyboard.c: Try to fix typos in previous change.
1811 (DISPLAY_LIST_INFO): New macro.
1812 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 1813 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 1814
945c5bb1
JB
18152013-07-18 Juanma Barranquero <lekktu@gmail.com>
1816
1817 * keyboard.c (kbd_buffer_get_event):
1818 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
1819 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
1820
f4b1eb36
PE
18212013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1822
5e679a2c
PE
1823 * filelock.c: Fix unlikely file descriptor leaks.
1824 (get_boot_time_1): Rework to avoid using emacs_open.
1825 This doesn't actually fix a leak, but is better anyway.
1826 (read_lock_data): Use read, not emacs_read.
1827
a8cd4836
PE
1828 * doc.c: Fix minor memory and file descriptor leaks.
1829 * doc.c (get_doc_string): Fix memory leak when doc file absent.
1830 (get_doc_string, Fsnarf_documentation):
1831 Fix file descriptor leak on error.
1832
ef30e638
PE
1833 * term.c: Fix minor fdopen-related file descriptor leaks.
1834 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
1835 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
1836
f4b1eb36
PE
1837 * charset.c: Fix file descriptor leaks and errno issues.
1838 Include <errno.h>.
1839 (load_charset_map_from_file): Don't leak file descriptor on error.
1840 Use plain record_xmalloc since the allocation is larger than
1841 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
1842 of entries.
1843 * eval.c (record_unwind_protect_nothing):
1844 * fileio.c (fclose_unwind):
1845 New functions.
1846 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
1847 The replacement doesn't block input, but that no longer seems
1848 necessary.
1849
b648c163
PE
18502013-07-17 Paul Eggert <eggert@cs.ucla.edu>
1851
a0931322
PE
1852 * lread.c: Fix file descriptor leaks and errno issues.
1853 (Fload): Close some races that leaked fds or streams when 'load'
1854 was interrupted.
1855 (Fload, openp): Report error number of last nontrivial failure to open.
1856 ENOENT counts as trivial.
1857 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
1858 New functions.
1859 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
1860 now that the function is always called with a nonnegative arg.
1861 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
1862 All uses replaced with ...
1863 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
1864
b648c163
PE
1865 A few more minor file errno-reporting bugs.
1866 * callproc.c (Fcall_process):
1867 * doc.c (Fsnarf_documentation):
1868 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
1869 * process.c (set_socket_option):
1870 Don't let a constructor trash errno.
1871 * doc.c: Include <errno.h>.
1872
b1dc4084
JB
18732013-07-16 Juanma Barranquero <lekktu@gmail.com>
1874
1875 * w32fns.c (unwind_create_tip_frame): Fix declaration.
1876
c43843aa
PE
18772013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1878
50a30cce
PE
1879 Fix w32 bug with call-process-region (Bug#14885).
1880 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
1881 to Fcall_process when the input is empty. This simplifies the
1882 code a bit. It makes no difference on POSIXish platforms but
1883 apparently it fixes a bug on w32.
1884
44e18199 1885 Fix bug where insert-file-contents closes a file twice (Bug#14839).
41d48a42
PE
1886 * fileio.c (close_file_unwind): Don't close if FD is negative;
1887 this can happen when unwinding a zapped file descriptor.
1888 (Finsert_file_contents): Unwind-protect the fd before the point marker,
1889 in case Emacs runs out of memory between the two unwind-protects.
1890 Don't trash errno when closing FD.
1891 Zap the FD in the specpdl when closing it, instead of deferring
1892 the removal of the unwind-protect; this fixes a bug where a child
1893 function unwinds the stack past us.
1894
27e498e6
PE
1895 New unwind-protect flavors to better type-check C callbacks.
1896 This also lessens the need to write wrappers for callbacks,
1897 and the need for make_save_pointer.
1898 * alloca.c (free_save_value):
1899 * atimer.c (run_all_atimers):
1900 Now extern.
1901 * alloc.c (safe_alloca_unwind):
1902 * atimer.c (unwind_stop_other_atimers):
1903 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
1904 * menu.c (cleanup_popup_menu) [HAVE_NS]:
1905 * minibuf.c (choose_minibuf_frame_1):
1906 * process.c (make_serial_process_unwind):
1907 * xdisp.h (pop_message_unwind):
1908 * xselect.c (queue_selection_requests_unwind):
1909 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
1910 * alloca.c (record_xmalloc):
1911 Prefer record_unwind_protect_ptr to record_unwind_protect with
1912 make_save_pointer.
1913 * alloca.c (Fgarbage_collect):
1914 Prefer record_unwind_protect_void to passing a dummy.
1915 * buffer.c (restore_buffer):
1916 * window.c (restore_window_configuration):
1917 * xfns.c, w32fns.c (do_unwind_create_frame)
1918 New wrapper. All record-unwind uses of wrappee changed.
1919 * buffer.c (set_buffer_if_live):
1920 * callproc.c (call_process_cleanup, delete_temp_file):
1921 * coding.c (code_conversion_restore):
1922 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
1923 * editfns.c (save_excursion_restore)
1924 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
1925 (save_restriction_restore):
1926 * eval.c (restore_stack_limits, un_autoload):
1927 * fns.c (require_unwind):
1928 * keyboard.c (recursive_edit_unwind, tracking_off):
1929 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
1930 * macros.c (pop_kbd_macro, restore_menu_items):
1931 * nsfns.m (unwind_create_frame):
1932 * print.c (print_unwind):
1933 * process.c (start_process_unwind):
1934 * search.c (unwind_set_match_data):
1935 * window.c (select_window_norecord, select_frame_norecord):
1936 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
1937 (fast_set_selected_frame):
1938 * xfns.c, w32fns.c (unwind_create_tip_frame):
1939 Return void, not a dummy Lisp_Object. All uses changed.
1940 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
1941 * callproc.c (call_process_kill):
1942 * fileio.c (restore_point_unwind, decide_coding_unwind)
1943 (build_annotations_unwind):
1944 * insdel.c (Fcombine_after_change_execute_1):
1945 * keyboard.c (read_char_help_form_unwind):
1946 * menu.c (unuse_menu_items):
1947 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
1948 * sound.c (sound_cleanup):
1949 * xdisp.c (unwind_redisplay):
1950 * xfns.c (clean_up_dialog):
1951 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
1952 Accept no args and return void, instead of accepting and returning
1953 a dummy Lisp_Object. All uses changed.
1954 * cygw32.c (fchdir_unwind):
1955 * fileio.c (close_file_unwind):
1956 * keyboard.c (restore_kboard_configuration):
1957 * lread.c (readevalllop_1):
1958 * process.c (wait_reading_process_output_unwind):
1959 Accept int and return void, rather than accepting an Emacs integer
1960 and returning a dummy object. In some cases this fixes an
1961 unlikely bug when the corresponding int is outside Emacs integer
1962 range. All uses changed.
1963 * dired.c (directory_files_internal_unwind):
1964 * fileio.c (do_auto_save_unwind):
1965 * gtkutil.c (pop_down_dialog):
1966 * insdel.c (reset_var_on_error):
1967 * lread.c (load_unwind):
1968 * xfns.c (clean_up_file_dialog):
1969 * xmenu.c, nsmenu.m (pop_down_menu):
1970 * xmenu.c (cleanup_widget_value_tree):
1971 * xselect.c (wait_for_property_change_unwind):
1972 Accept pointer and return void, rather than accepting an Emacs
1973 save value encapsulating the pointer and returning a dummy object.
1974 All uses changed.
1975 * editfns.c (Fformat): Update the saved pointer directly via
1976 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
1977 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
1978 (unwind_body): New function.
1979 (record_unwind_protect): First arg is now a function returning void,
1980 not a dummy Lisp_Object.
1981 (record_unwind_protect_ptr, record_unwind_protect_int)
1982 (record_unwind_protect_void): New functions.
1983 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
1984 * fileio.c (struct auto_save_unwind): New type.
1985 (do_auto_save_unwind): Use it.
1986 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
1987 * insdel.c (struct rvoe_arg): New type.
1988 (reset_var_on_error): Use it.
1989 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
1990 New constants.
1991 (specbinding_func): Remove; there are now several such functions.
1992 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
1993 (set_unwind_protect_ptr): New function.
1994 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
1995
4e604a5d
PE
1996 Be simpler and more consistent about reporting I/O errors.
1997 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1998 Say "Read error" and "Write error", rather than "I/O error", or
1999 "IO error reading", or "IO error writing", when a read or write
2000 error occurs.
2001 * process.c (Fmake_network_process, wait_reading_process_output)
2002 (send_process, Fprocess_send_eof, wait_reading_process_output):
2003 Capitalize diagnostics consistently. Put "failed foo" at the
2004 start of the diagnostic, so that we don't capitalize the
2005 function name "foo". Consistently say "failed" for such
2006 diagnostics.
2007 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
2008 All callers changed. This is so it can use report_file_error.
2009 * sysdep.c (serial_open, serial_configure): Capitalize I/O
2010 diagnostics consistently as above.
2011
a9757f6a
PE
2012 * fileio.c (report_file_errno): Fix errno reporting bug.
2013 If the file name is neither null nor a pair, package it up as a
2014 singleton list. All callers changed, both to this function and to
2015 report_file_error. This fixes a bug where the memory allocator
2016 invoked by list1 set errno so that the immediately following
2017 report_file_error reported the wrong errno value.
2018
c43843aa
PE
2019 Fix minor problems found by --enable-gcc-warnings.
2020 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
2021 * keyboard.c (kbd_buffer_get_event): Remove unused local.
2022
18c26d81
JD
20232013-07-16 Jan Djärv <jan.h.d@swipnet.se>
2024
2025 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
2026 Set event->arg to Qt if switch-event shall be generated.
2027 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
2028
2029 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
2030
2031 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
2032 FOCUS_OUT_EVENT.
2033
2034 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
2035 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
2036 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
2037 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
44e18199 2038 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
18c26d81
JD
2039 and there is a focused frame.
2040 (head_table): Add focus-in and focus-out.
2041 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
2042 bind to handle-focus-in/out.
2043
2044 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
2045 (Fhandle_switch_frame): Call Fhandle_focus_in.
2046 (syms_of_frame): defsubr handle-focus-in/out.
2047
6c6f1994
PE
20482013-07-16 Paul Eggert <eggert@cs.ucla.edu>
2049
c7ddc792
PE
2050 Fix porting bug to older POSIXish platforms (Bug#14862).
2051 * sysdep.c (emacs_pipe): New function, that implements
2052 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
2053 This should port better to CentOS 5 and to Mac OS X 10.6.
2054 All calls to pipe2 changed.
2055
6c6f1994
PE
2056 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
2057 This makes the code easier to read and the executable a bit smaller.
2058 Do not replace all calls to Fcons that happen to create lists,
2059 just calls that are intended to create lists. For example, when
2060 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
2061 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
2062 Similarly for list2 through list5.
2063 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2064 * bytecode.c (exec_byte_code):
2065 * callint.c (quotify_arg, Fcall_interactively):
2066 * callproc.c (Fcall_process, create_temp_file):
2067 * charset.c (load_charset_map_from_file)
2068 (Fdefine_charset_internal, init_charset):
2069 * coding.c (get_translation_table, detect_coding_system)
2070 (Fcheck_coding_systems_region)
2071 (Fset_terminal_coding_system_internal)
2072 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
2073 * composite.c (update_compositions, Ffind_composition_internal):
2074 * dired.c (directory_files_internal, file_name_completion)
2075 (Fsystem_users):
2076 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
2077 * doc.c (Fsnarf_documentation):
2078 * editfns.c (Fmessage_box):
2079 * emacs.c (main):
2080 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
2081 (Feval, eval_sub, Ffuncall, apply_lambda):
2082 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
2083 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
2084 (Fset_file_times, Finsert_file_contents)
2085 (Fchoose_write_coding_system, Fwrite_region):
2086 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
2087 * font.c (font_registry_charsets, font_parse_fcname)
2088 (font_prepare_cache, font_update_drivers, Flist_fonts):
2089 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
2090 * frame.c (make_frame, Fmake_terminal_frame)
2091 (x_set_frame_parameters, x_report_frame_params)
2092 (x_default_parameter, Fx_parse_geometry):
2093 * ftfont.c (syms_of_ftfont):
2094 * image.c (gif_load):
2095 * keyboard.c (command_loop_1):
2096 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
2097 (Fcopy_keymap, append_key, Fcurrent_active_maps)
2098 (Fminor_mode_key_binding, accessible_keymaps_1)
2099 (Faccessible_keymaps, Fwhere_is_internal):
2100 * lread.c (read_emacs_mule_char):
2101 * menu.c (find_and_return_menu_selection):
2102 * minibuf.c (get_minibuffer):
2103 * nsfns.m (Fns_perform_service):
2104 * nsfont.m (ns_script_to_charset):
2105 * nsmenu.m (ns_popup_dialog):
2106 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
2107 (Fx_own_selection_internal):
2108 * nsterm.m (append2):
2109 * print.c (Fredirect_debugging_output)
2110 (print_prune_string_charset):
2111 * process.c (Fdelete_process, Fprocess_contact)
2112 (Fformat_network_address, set_socket_option)
2113 (read_and_dispose_of_process_output, write_queue_push)
2114 (send_process, exec_sentinel):
2115 * sound.c (Fplay_sound_internal):
2116 * textprop.c (validate_plist, add_properties)
2117 (Fput_text_property, Fadd_face_text_property)
2118 (copy_text_properties, text_property_list, syms_of_textprop):
2119 * unexaix.c (report_error):
2120 * unexcoff.c (report_error):
2121 * unexsol.c (unexec):
2122 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
2123 (Fformat_mode_line, syms_of_xdisp):
2124 * xfaces.c (set_font_frame_param)
2125 (Finternal_lisp_face_attribute_values)
2126 (Finternal_merge_in_global_face, syms_of_xfaces):
2127 * xfns.c (x_default_scroll_bar_color_parameter)
2128 (x_default_font_parameter, x_create_tip_frame):
2129 * xfont.c (xfont_supported_scripts):
2130 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
2131 (menu_help_callback, xmenu_show):
2132 * xml.c (make_dom):
2133 * xterm.c (set_wm_state):
2134 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
2135 and similarly for list2 through list5.
2136
bafe80ce
PE
21372013-07-15 Paul Eggert <eggert@cs.ucla.edu>
2138
2139 * callproc.c (Fcall_process_region): Fix minor race and tune.
2140 (create_temp_file): New function, with the temp-file-creation part
2141 of the old Fcall_process_region. Use Fcopy_sequence to create the
2142 temp file name, rather than alloca + build_string, for simplicity.
2143 Don't bother to block input around the temp file creation;
068f9124
SM
2144 shouldn't be needed. Simplify use of mktemp.
2145 Use record_unwind_protect immediately after creating the temp file;
bafe80ce
PE
2146 this closes an unlikely race where the temp file was not removed.
2147 Use memcpy rather than an open-coded loop.
2148 (Fcall_process_region): Use the new function. If the input is
2149 empty, redirect from /dev/null rather than from a newly created
2150 empty temp file; this avoids unnecessary file system traffic.
2151
4700b5a5
PE
21522013-07-14 Paul Eggert <eggert@cs.ucla.edu>
2153
5c97beae
PE
2154 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
2155 Simplify by making this case like the other two. This is a bit
2156 slower on obsolete hosts, but the extra complexity isn't worth it.
2157
4700b5a5
PE
2158 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
2159 * process.c (create_process) [!DOS_NT]:
2160 Remove now-unnecessary calls to emacs_close.
2161
f9a74c4c
EZ
21622013-07-13 Eli Zaretskii <eliz@gnu.org>
2163
922ae7ee
EZ
2164 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
2165 returning early. (Bug#14850)
2166
f9a74c4c
EZ
2167 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
2168 and inhibit-iso-escape-detection attributes of 'undecided'.
2169 (Bug#14822)
2170
5e301d76
PE
21712013-07-13 Paul Eggert <eggert@cs.ucla.edu>
2172
69e0e5ee
PE
2173 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
2174 Reported by Herbert J. Skuhra in
2175 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
2176
5e301d76
PE
2177 Don't lose top specpdl entry when memory is exhausted.
2178 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
2179 specpdl overflow here, to simplify callers; all callers changed.
2180 Always reserve an unused entry at the stack top; this avoids
2181 losing the top entry's information when memory is exhausted.
2182
7e649856
PE
21832013-07-12 Paul Eggert <eggert@cs.ucla.edu>
2184
a773ed9a
PE
2185 Clean up errno reporting and fix some errno-reporting bugs.
2186 * callproc.c (Fcall_process):
2187 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
2188 * process.c (create_process, Fmake_network_process):
2189 * unexaix.c (report_error):
2190 * unexcoff.c (report_error):
2191 Be more careful about reporting the errno of failed operations.
2192 The code previously reported the wrong errno sometimes.
2193 Also, prefer report_file_errno to setting errno + report_file_error.
2194 (Fcall_process): Look at openp return value rather than at path,
2195 as that's a bit faster and clearer when there's a numeric predicate.
2196 * fileio.c (report_file_errno): New function, with most of the
2197 old contents of report_file_error.
2198 (report_file_error): Use it.
2199 (Ffile_exists_p, Ffile_accessible_directory_p):
2200 Set errno to 0 when it is junk.
2201 * fileio.c (Faccess_file):
2202 * image.c (x_create_bitmap_from_file):
2203 Use faccessat rather than opening the file, to avoid the hassle of
2204 having a file descriptor open.
2205 * lisp.h (report_file_errno): New decl.
2206 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
2207
7e649856
PE
2208 Minor EBADF fixes.
2209 * process.c (create_process, wait_reading_process_output) [AIX]:
2210 Remove obsolete SIGHUP-related code, as Emacs no longer disables
2211 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
2212 a multithreaded environment anyway).
2213 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
2214
f6774c1a
AS
22152013-07-12 Andreas Schwab <schwab@linux-m68k.org>
2216
2217 * image.c (x_find_image_file): Don't close a remote file handle.
2218
bacba3c2
PE
22192013-07-12 Paul Eggert <eggert@cs.ucla.edu>
2220
2221 Fix races with threads and file descriptors.
2222 * callproc.c (Fcall_process_region):
2223 * dired.c (open_directory):
2224 * emacs.c (main, Fdaemon_initialized):
2225 * image.c (x_find_image_file):
2226 * inotify.c (Finotify_rm_watch):
2227 * lread.c (Flocate_file_internal):
2228 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
2229 * term.c (term_mouse_moveto, init_tty):
2230 * termcap.c (tgetent):
2231 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
2232 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
2233 * unexhp9k800.c, unexmacosx.c (unexec):
2234 * callproc.c (Fcall_process_region):
2235 Use emacs_close, not close.
2236 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
2237 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
2238 and posix_close function on current platforms (which all lack them).
2239 (emacs_close): Use it. This should fix the races on GNU/Linux and
2240 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
2241 and it should avoid closing random victim file descriptors on
2242 other platforms.
2243
653d4f43
PE
22442013-07-11 Paul Eggert <eggert@cs.ucla.edu>
2245
c8536ec4
PE
2246 * inotify.c (uninitialized): Remove. All uses replaced by -1.
2247 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
2248 Touch up doc a bit.
2249
9c203066
PE
2250 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
2251 This is for .gdbinit xbacktrace.
2252
653d4f43
PE
2253 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
2254 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
2255 (emacs_set_tty): Now static.
2256 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
2257 * term.c (tty_capable_p, tty_default_color_capabilities)
2258 (get_tty_terminal, term_mouse_movement)
2259 (handle_one_term_event, init_tty, maybe_fatal):
2260 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
2261 (tgetent, scan_file, name_match, compare_contin):
2262 * terminal.c (get_terminal):
2263 Use bool for boolean.
2264 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
2265 Prefer char to unsigned char if either will do.
2266 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
2267 (tty_write_glyphs): Prefer int to unsigned.
2268 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
2269 All callers changed.
2270 * termcap.c (tprint, main) [TEST]: Remove non-working test.
2271
45b683a1
PE
22722013-07-10 Paul Eggert <eggert@cs.ucla.edu>
2273
29abe551
PE
2274 Port to C89.
2275 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
2276 (B__dummy__): New dummy symbol, to pacify C89.
2277 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
2278 they can't grok varargs macros.
2279 * dispnew.c (add_window_display_history)
2280 (add_frame_display_history):
2281 * print.c (print_object):
2282 * xdisp.c (debug_method_add):
2283 Use %p printf format only for void pointers.
2284 * emacs.c (usage_message): New constant, replacing ...
2285 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
2286 (main): Adjust to usage reorg.
2287 * fns.c (syms_of_fns):
2288 * profiler.c (syms_of_profiler):
2289 Don't use non-constant struct initializers.
2290 * gnutls.h (gnutls_initstage_t):
2291 * lisp.h (enum Lisp_Fwd_Type):
2292 * lread.c (lisp_file_lexically_bound_p):
2293 * xsettings.c (anonymous enum):
2294 Remove trailing comma.
2295 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
2296 * lisp.h (ENUM_BF): Use unsigned if pedantic.
2297 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
2298 (DEFUN): Use it.
2299 * regex.c (const_re_char): New type, to pacify strict C89.
2300 All uses of 'const re_char' replaced to use it.
2301 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
2302 with glibc when strict C89. This change is imported from gnulib.
2303 All uses changed.
2304 (_Restrict_arr_): Rename from __restrict_arr, similarly.
2305 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
2306 Omit GNU_LINUX implementation, since it requires long long.
2307 * xterm.c (x_draw_underwave):
2308 Do not assume the traditional order of struct's members.
2309 (x_term_init): Rewrite to avoid the need for non-constant structure
2310 initializers.
2311
45b683a1 2312 Syntax cleanup, mostly replacing macros with functions.
763a086d 2313 This removes the need for the syntax_temp hack.
45b683a1
PE
2314 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
2315 * syntax.c (SYNTAX_INLINE): New macro.
2316 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
2317 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
2318 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
2319 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
2320 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
2321 (SYNTAX_COMEND_FIRST): Now functions, not macros.
2322 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
2323 Now constants, not macros.
2324 (syntax_temp) [!__GNUC__]: Remove.
2325 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
2326 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
2327 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
2328 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
2329 Move here from syntax.h; now functions, not macros. Except for the
2330 last function, these are static since only syntax.c uses them.
2331 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
2332 All uses changed. Now a function, not a macro; use this fact
2333 to simplify the code.
2334 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
2335 compiler bugs; no longer relevant.
2336 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2337 (SYNTAX_INLINE): New macro.
2338 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
2339 for the new functions. Use bool for boolean member.
2340 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
2341 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
2342 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
2343 (SETUP_BUFFER_SYNTAX_TABLE):
2344 Now extern inline functions, not macros.
2345 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
2346 Remove; all uses replaced by implementation.
2347 (syntax_temp) [!__GNUC__]: Remove decl.
2348 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
2349
29be4a50
JD
23502013-07-10 Jan Djärv <jan.h.d@swipnet.se>
2351
2352 * emacs.c (main): Fix syntax error.
2353
954b166e
PE
23542013-07-10 Paul Eggert <eggert@cs.ucla.edu>
2355
2356 Timestamp fixes for undo (Bug#14824).
2357 * atimer.c (schedule_atimer):
2358 * fileio.c (Ffile_newer_than_file_p):
2359 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
2360 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
2361 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
2362 (syms_of_fileio): Remove Sclear_visited_file_name.
2363 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
2364 file doesn't exist; this avoids an ambiguity with negative timestamps.
2365 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
2366 * systime.h (make_emacs_time, invalid_emacs_time):
2367 Don't assume struct timespec layout; POSIX doesn't guarantee it.
2368 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
2369 * undo.c (record_first_change): Push (visited-file-modtime) onto
2370 undo list rather than reimplementing it by hand, incorrectly.
2371
d74647c3
KB
23722013-07-09 Ken Brown <kbrown@cornell.edu>
2373
2374 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
2375
3c51b96b
JB
23762013-07-09 Juanma Barranquero <lekktu@gmail.com>
2377
2378 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
2379
4ebbdd67
PE
23802013-07-09 Paul Eggert <eggert@cs.ucla.edu>
2381
2382 Handle errno and exit status a bit more carefully.
2383 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
2384 number into an exit status. Instead, use EXIT_CANCELED.
2385 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
2386 * callproc.c (relocate_fd):
2387 * emacs.c (close_output_streams, main):
2388 * process.c (create_process):
2389 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
2390 Use emacs_perror for simplicity.
2391 * callproc.c (relocate_fd, main):
2392 * sysdep.c (sys_subshell):
2393 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
2394 (shut_down_emacs): Use emacs_write, not write.
2395 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
2396 * fileio.c (Fcopy_file, e_write):
2397 * nsterm.m (ns_select):
2398 * process.c (send_process):
2399 * sound.c (vox_write):
2400 Use emacs_write_sig, not emacs_write.
2401 * lisp.h (emacs_write_sig, emacs_perror): New decls.
2402 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
2403 New constants.
2404 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
2405 of write.
2406 (emacs_full_write): New function.
2407 (emacs_write): Rewrite to use it.
2408 (emacswrite_sig, emacs_perror): New functions.
2409 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
2410
44e18199 24112013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
e4b1e5af
JD
2412
2413 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
2414 on NS even if it is present. Pixmap on NS is a void*.
2415
9caab067
PE
24162013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2417
2418 Port to Ubuntu 10 (Bug#14803).
2419 Problem reported by T.V. Raman.
2420 * process.c (close_on_exec, accept4, process_socket):
2421 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
2422
1d442672
EZ
24232013-07-07 Eli Zaretskii <eliz@gnu.org>
2424
2425 * w32.c (sys_dup): Declare prototype.
2426
2427 * filelock.c:
2428 * emacs.c:
2429 * callproc.c [WINDOWSNT]: Include sys/socket.h.
2430
067428c1
PE
24312013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2432
2433 Make file descriptors close-on-exec when possible (Bug#14803).
2434 This simplifies Emacs a bit, since it no longer needs to worry
2435 about closing file descriptors by hand in some cases.
2436 It also fixes some unlikely races. Not all such races, as
2437 libraries often open files internally without setting
2438 close-on-exec, but it's an improvement.
2439 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
2440 * callproc.c (Fcall_process) [!MSDOS]:
2441 * emacs.c (main) [!DOS_NT]:
2442 * nsterm.m (ns_term_init):
2443 * process.c (create_process):
2444 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
2445 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
2446 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
2447 Prefer mkostemp with O_CLOEXEC to mkstemp.
2448 * callproc.c (relocate_fd) [!WINDOWSNT]:
2449 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
2450 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
2451 now using pipe2.
2452 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
2453 Make the resulting file descriptor close-on-exec.
2454 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
2455 * lread.c (load_descriptor_list, load_descriptor_unwind):
2456 Remove; no longer needed. All uses removed.
2457 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
2458 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
2459 New functions.
2460 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
2461 (Fmake_network_process, Fnetwork_interface_list):
2462 (Fnetwork_interface_info, server_accept_connection):
2463 Make newly-created socket close-on-exec.
2464 * sysdep.c (emacs_open, emacs_fopen):
2465 Make new-created descriptor close-on-exec.
2466 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
2467 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
2468
0da857dd
JD
24692013-07-07 Jan Djärv <jan.h.d@swipnet.se>
2470
2471 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
2472 for NS_IMPL_GNUSTEP.
2473
5f86adcd
PE
24742013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2475
2476 Fix openp errno handling.
2477 * callproc.c (Fcall_process): Preserve openp errno around close.
2478 * lread.c (openp): Set errno when returning -1, as some callers
2479 expect this.
2480
1afb1d07
JD
24812013-07-06 Jan Djärv <jan.h.d@swipnet.se>
2482
2483 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
2484
2485 * nsterm.h (NSSavePanel): Update comment.
2486 (NSAPP_DATA2_RUNFILEDIALOG): Define.
2487 (ns_run_file_dialog): Declare.
2488
2489 * nsfns.m: Remove panelOK.
2490 (ns_fd_data): New.
2491 (ns_run_file_dialog): New function.
2492 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
2493 event loop, so file dialog is popped up by ns_run_file_dialog, called
2494 by sendEvent (Bug#14578).
2495 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
2496
3323c263
EZ
24972013-07-06 Eli Zaretskii <eliz@gnu.org>
2498
fdda0220
EZ
2499 * xdisp.c (default_line_pixel_height): New function.
2500 (pos_visible_p, move_it_vertically_backward, try_scrolling)
2501 (try_cursor_movement, redisplay_window, try_window)
2502 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
2503
068f9124
SM
2504 * window.c (window_scroll_pixel_based):
2505 use default_line_pixel_height.
fdda0220
EZ
2506
2507 * dispextern.h (default_line_pixel_height): Add prototype.
2508
2509 * frame.c (x_set_line_spacing): Accept a float value for
2510 line-spacing parameter, per the documentation.
2511
3323c263
EZ
2512 * data.c (Fmultibyte_string_p): Doc fix.
2513
47ba6d43
PE
25142013-07-05 Paul Eggert <eggert@cs.ucla.edu>
2515
406af475
PE
2516 Use emacs_open more consistently when opening files.
2517 This handles EINTR more consistently now, and makes it easier
2518 to introduce other uniform changes to file descriptor handling.
2519 * src/systdio.h: New file.
2520 * src/buffer.c (mmap_init):
2521 * cygw32.c (chdir_to_default_directory):
2522 * dispnew.c (Fopen_termscript):
2523 * emacs.c (Fdaemon_initialized):
2524 * fileio.c (Fdo_auto_save):
2525 * image.c (slurp_file, png_load_body, jpeg_load_body):
2526 * keyboard.c (Fopen_dribble_file):
2527 * lread.c (Fload):
2528 * print.c (Fredirect_debugging_output):
2529 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
2530 * termcap.c (tgetent):
2531 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
2532 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
2533 * w32term.c (w32_initialize) [CYGWIN]:
2534 * xfaces.c (Fx_load_color_file):
2535 Use emacs_open instead of plain open, and emacs_fopen instead of
2536 plain fopen.
2537 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
2538 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
2539 * callproc.c (default_output_mode): New constant.
2540 (Fcall_process): Use it to call emacs_open instead of plain creat.
2541 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
2542 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
2543 (emacs_fopen): New function.
2544 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
2545 Include <lisp.h>, for emacs_open.
2546 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
2547
47ba6d43
PE
2548 Remove duplicate #include directives.
2549 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
2550 * xfaces.c:
2551 Don't include stdio.h twice.
2552 * buffer.c [USE_MMAP_FOR_BUFFERS]:
2553 Don't include sys/types.h or stdio.h twice.
2554 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
2555 * lread.c: Don't include coding.h twice.
2556 * nsfont.m: Don't include frame.h twice.
2557 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
2558 * ralloc.c: Don't include <unistd.h> twice.
2559 * xdisp.c: Don't include font.h twice.
2560 * xterm.c: Don't include fontset.h twice.
2561 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
2562
b9ed53d5
PE
25632013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2564
2565 Scale ImageMagick images more carefully.
2566 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
2567 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
2568 Be more careful about avoiding undefined behavior after
2569 integer overflow and division by zero.
2570
cf13177e
YM
25712013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2572
2573 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
2574 (syms_of_w32fns): DEFSYM them.
2575 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
2576 (CCHDEVICENAME): Define macros if not defined.
2577 (struct MONITOR_INFO_EX): New struct.
2578 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
2579 (enum_display_monitors_fn): New variable.
2580 (globals_of_w32fns): Initialize it.
2581 (Fx_display_pixel_width, Fx_display_pixel_height)
2582 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
2583 multi-monitor setups in docstrings.
2584 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
2585 screen size by primary monitor's millimeter per pixel.
2586 (w32_monitor_enum, w32_display_monitor_attributes_list)
2587 (w32_display_monitor_attributes_list_fallback)
2588 (Fw32_display_monitor_attributes_list): New functions.
2589 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
2590
2591 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
2592 if not defined.
2593 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
2594
86dfb7a8
MA
25952013-07-04 Michael Albinus <michael.albinus@gmx.de>
2596
2597 * fileio.c (Qfile_notify_error): New error symbol.
2598
2599 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
2600 * inotify.c (inotify_callback, symbol_to_inotifymask)
2601 (Finotify_add_watch, Finotify_rm_watch): Use it.
2602 (inotifyevent_to_event): Exchange order of cookie and file name.
2603 (Finotify_add_watch): Adapt docstring.
2604
2605 * lisp.h (Qfile_notify_error): Declare.
2606
2c1c974b
PE
26072013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2608
2609 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
2610 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2611 Do not clear _malloc_thread_enabled_p, undoing the previous change,
2612 which did not work (see <http://bugs.gnu.org/14569#307>).
2613 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
2614 && (!noninteractive || initialized)). This attempts to thread
2615 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
2616
7a35b20f
JB
26172013-07-04 Juanma Barranquero <lekktu@gmail.com>
2618
2619 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
2620 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
2621
1ce5cd04
PE
26222013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2623
2624 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
2625 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2626 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
2627 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
2628
57f8c490
PE
26292013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2630
2631 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
2632 Define to __sys_siglist.
2633
bcffb5ca
EZ
26342013-07-02 Eli Zaretskii <eliz@gnu.org>
2635
2636 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
2637 word-wrap, so that overflow-newline-into-fringe would work in
2638 visual-line-mode. (Bug#2749)
2639 (move_it_in_display_line_to): When the last scanned display
2640 element fits exactly on the display line, and
2641 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
2642 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
2643 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
2644 finding buffer position that corresponds to pixel coordinates,
2645 e.g. in buffer_posn_from_coords.
2646
2c41e781
JD
26472013-07-02 Jan Djärv <jan.h.d@swipnet.se>
2648
2649 * process.c (handle_child_signal): Call catch_child_signal if
2650 NS_IMPL_GNUSTEP.
2651
c2418359
PE
26522013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2653
52a9bcae
PE
2654 Don't convert function pointers to void * and back.
2655 It isn't portable C, and it's easy enough to avoid.
2656 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
2657 (make_save_value): Add support for SAVE_FUNCPOINTER.
2658 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
2659 * print.c (print_object):
2660 Distinguish function from object pointers.
2661 * lisp.h (SAVE_FUNCPOINTER): New constant.
2662 (SAVE_SLOT_BITS): Adjust to it.
2663 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
2664 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
2665 (voidfuncptr): New typedef.
2666 (struct Lisp_Save_Value): New member data[0].funcpointer.
2667 (XSAVE_FUNCPOINTER): New function.
2668
c2418359
PE
2669 Simplify buildobj processing.
2670 * Makefile.in (buildobj.h): Make it a sequence of strings each
2671 followed by comma, rather than a single string. Put it into a
2672 .tmp file in case there's an error while generating it.
2673 (gl-stamp): Use .tmp for temp files.
2674 (mostlyclean): Clean .tmp files.
2675 * doc.c (buildobj): Move to just the routine that needs it.
2676 It's now an array of strings, so processing is simpler.
2677
8f43ce49
PE
26782013-07-01 Paul Eggert <eggert@cs.ucla.edu>
2679
2680 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
2681 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
2682 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2683 Invoke malloc_enable_thread even when not interactive.
2684 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
2685 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
2686 in this case, since the underlying bug has now been fixed.
2687
24827db9
JB
26882013-07-01 Juanma Barranquero <lekktu@gmail.com>
2689
2690 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
2691 unlinking it (bug#14691).
2692
ef099a94
MN
26932013-06-30 Michal Nazarewicz <mina86@mina86.com>
2694
2695 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
2696 before checking whether buffer is modified. This lets
2697 `kill-buffer-query-functions' cancel killing of the buffer or save
2698 its content before `kill-buffer' asks user the "Buffer %s
2699 modified; kill anyway?" question.
2700
9d3f2fc2
JD
27012013-06-30 Jan Djärv <jan.h.d@swipnet.se>
2702
2703 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
2704 Let the super performKeyEquivalent deal with them (Bug#14747).
2705
e6c6c8c7
PE
27062013-06-30 Paul Eggert <eggert@cs.ucla.edu>
2707
1d71c1d9
PE
2708 * widget.c (resize_cb): Remove unused local.
2709
8f5f35cc
PE
2710 Do not use GTK 3 if it exists but cannot be compiled.
2711 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
2712 * xterm.c (x_error_handler) [!USE_GTK]:
2713 Do not use GTK 3.
2714
e6c6c8c7
PE
2715 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
2716
0ba54312
EZ
27172013-06-30 Eli Zaretskii <eliz@gnu.org>
2718
5d1c3286
EZ
2719 * intervals.c (get_local_map): Instead of aborting, clip POSITION
2720 to the valid range of values. (Bug#14753)
2721
0ba54312
EZ
2722 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
2723 when moving point by using the current glyph matrix. This avoids
2724 the need to force redisplay when this function is called in a
2725 loop.
2726
9c90cc06
PE
27272013-06-29 Paul Eggert <eggert@cs.ucla.edu>
2728
2729 Fix minor problems found by static checking.
2730 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
2731 Redo the latter's body to sidestep GCC parenthesization warnings.
2732 (setup_coding_system, detect_coding, detect_coding_system): Use them.
2733 * coding.c (detect_coding, detect_coding_system):
2734 * coding.h (struct undecided_spec):
2735 Use bool for boolean.
2736 * image.c (QCmax_width, QCmax_height): Now static.
2737 * xdisp.c (Fmove_point_visually): Remove unused local.
2738
4c672a0f
EZ
27392013-06-29 Eli Zaretskii <eliz@gnu.org>
2740
2741 * xdisp.c (Fmove_point_visually): New function.
2742
c1ea3abf
JB
27432013-06-28 Kenichi Handa <handa@gnu.org>
2744
2745 * coding.h (define_coding_undecided_arg_index): New enum.
2746 (coding_attr_index): New members
2747 coding_attr_undecided_inhibit_null_byte_detection,
2748 coding_attr_undecided_inhibit_iso_escape_detection,
2749 coding_attr_undecided_prefer_utf_8.
2750 (undecided_spec): New struct.
2751 (struct coding_system): New member `undecided' of the member
2752 `spec'.
2753
2754 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
2755 (detect_coding): Likewise.
2756 (detect_coding_system): Likewise.
2757 (Fdefine_coding_system_internal): New coding system properties
2758 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
2759 :prefer-utf-8.
2760 (syms_of_coding): Adjust for coding_arg_undecided_max.
2761
ba3de9e6
PE
27622013-06-28 Paul Eggert <eggert@cs.ucla.edu>
2763
2764 * image.c (x_from_xcolors): Remove unused local.
2765
547c9269
YM
27662013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2767
2768 Defer image data transfer between X client and server until actual
2769 display happens.
2770
2771 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
2772 and `mask_img'.
2773
2774 * image.c (Destroy_Image): Remove.
2775 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
2776 `mask_p', and `colors_p'. All uses changed.
2777 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
2778 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
2779 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
2780 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
2781 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 2782 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
2783 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
2784 (image_get_x_image, image_unget_x_image): New functions or macros.
2785 (image_background, image_background_transparent, x_to_xcolors)
2786 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
2787 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
2788 instead of Destroy_Image.
2789 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
2790 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
2791 (png_load_body, jpeg_load_body, tiff_load, gif_load)
2792 (imagemagick_load_image, svg_load_image): Use them instead of
2793 x_create_x_image_and_pixmap, and x_put_x_image followed by
2794 x_destroy_x_image, respectively.
2795 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
2796 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
2797 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
2798 background_transparent fields.
2799 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
2800 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
2801
dae2f5ef
PE
28022013-06-27 Paul Eggert <eggert@cs.ucla.edu>
2803
2804 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
2805 This mostly consists of undoing recent changes.
2806 * callproc.c (Fcall_process):
2807 * process.c (create_process):
2808 Do not worry about catching SIGCHLD here, undoing previous change.
2809 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
2810 * process.c, process.h (catch_child_signal):
2811 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
2812 * process.c (catch_child_handler): Don't worry about being called
2813 lazily and do not assume caller has blocked SIGCHLD, undoing
2814 previous change. Move first-time stuff back to
2815 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
2816 tickle glib, as that causes Cygwin bootstrap to fail. Do not
2817 set lib_child_handler if it's already initialized, which may
2818 help avoid problems on GNUStep.
2819
fa55d2aa
PE
28202013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2821
2822 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
2823 * callproc.c (Fcall_process):
2824 * process.c (create_process):
2825 Make sure SIGCHLD is caught before we fork,
2826 since Emacs startup no arranges to catch SIGCHLD.
2827 * process.c (lib_child_handler): Initialize to null, not to
2828 dummy_handler.
2829 (catch_child_signal): Allow self to be called lazily.
2830 Do nothing if it's already been called.
2831 Assume caller has blocked SIGCHLD (all callers do now).
2832 * emacs.c (main): Do not catch SIGCHLD here; defer it until
2833 just before it's really needed.
2834 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
2835 since it hasn't been caught yet.
2836
f3f9606c
LMI
28372013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
2838
2839 * image.c (compute_image_size): New function to implement
2840 :max-width and :max-height.
2841 (imagemagick_load_image): Use it.
2842
c7041908
PE
28432013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2844
2845 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
2846 * callproc.c, process.h (block_child_signal, unblock_child_signal):
2847 Now extern.
2848 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
2849 * process.c (catch_child_signal): Block SIGCHLD while futzing with
2850 the SIGCHLD handler, since the code is not atomic and (due to glib)
2851 signals may be arriving now.
2852 * sysdep.c (init_signals): Do not catch child signals here;
2853 'main' now does that later, at a safer time.
2854
f86852b4
PE
28552013-06-22 Paul Eggert <eggert@cs.ucla.edu>
2856
0dfeed58
PE
2857 Clean up SIGCHLD handling a bit (Bug#14569).
2858 * process.c, process.h (catch_child_signal):
2859 Now always extern, even if !NS_IMPL_GNUSTEP.
2860 * process.c (catch_child_signal): Move glib tickler here from
2861 init_process_emacs, so that it's done earlier in Emacs
2862 initialization. Also move the noninteractive && !initialized
2863 check here from init_process_emacs. This is all a bit cleaner for
2864 GNUish platforms, and I hope it works around the Cygwin bug.
2865 * sysdep.c (init_signals): Invoke catch_child_signal here, so
2866 that glib signal handling is tickled before glib creates threads.
2867
f86852b4
PE
2868 * process.c (wait_reading_process_output): Avoid int overflow
2869 when reading more than 2 GiB total from a process.
2870
cbd6509c
PE
28712013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2872
2873 * process.c (create_process): Handle a couple more cases,
2874 i.e., work even if new_argv and wait_child_setup[i] are cached.
2875 Use Fcall_process's style for volatile vars.
2876
9de1114a
AS
28772013-06-21 Andreas Schwab <schwab@linux-m68k.org>
2878
2879 * process.c (create_process): Mark PROCESS volatile.
2880
fbe9e0b9
PE
28812013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2882
2883 Use C99-style flexible array members if available.
2884 This avoids some subtle aliasing issues, which typically
2885 aren't a problem with GCC but may be a problem elsewhere.
2886 * alloc.c (sdata): New typedef, replacing the old struct sdata.
2887 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
2888 In either case, it uses a flexible array member rather than
2889 the old struct hack. All uses changed.
2890 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
2891 Adjust to sdata reorganization.
2892 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
2893 Use offsetof (struct, flex_array_member), not sizeof (struct), as
2894 that ports better to pre-C99 non-GCC.
2895 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
2896 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
2897 as the latter has changed.
2898 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
2899 and port better to pre-C99 GCC.
2900 * image.c (struct xpm_cached_color):
2901 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
2902 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
2903 Use FLEXIBLE_ARRAY_MEMBER.
2904 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
2905 Move decl to top level so it gets checked against implementation.
2906 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
2907 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
2908
1fc71008
PE
29092013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2910
2911 * syntax.c: Integer cleanups.
2912 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
2913 All uses that need 0-or-2 changed to:
2914 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
2915 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
2916 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
2917 (char_quoted, prev_char_comend_first, back_comment)
2918 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2919 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
2920 Use bool for boolean.
2921 (update_syntax_table, skip_chars, skip_syntaxes):
2922 Prefer int to unsigned when either will do.
2923 (back_comment): Return boolean success flag, like forw_comment,
2924 instead of positive-or-minus-1 (which might have overflowed int anyway).
2925 Don't stuff ptrdiff_t into int.
2926 (syntax_spec_code, syntax_code_spec): Now const.
2927 (Fmatching_paren, scan_lists, scan_sexps_forward):
2928 Use enum syntaxcode for syntax code.
2929 (Fmatching_paren): Check that arg is a character, not just an integer.
2930 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
2931 (Finternal_describe_syntax_value): Omit no-longer-needed
2932 comparison to 0.
2933 (skip_chars): Use char, not unsigned char, when the distinction
2934 doesn't matter.
2935 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
2936 * bytecode.c (exec_byte_code):
2937 * syntax.c (syntax_spec_code, Fchar_syntax)
2938 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2939 (init_syntax_once):
2940 * syntax.h (SYNTAX_WITH_FLAGS):
2941 Omit unnecessary casts.
2942
b932cad7
EZ
29432013-06-20 Eli Zaretskii <eliz@gnu.org>
2944
2945 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
2946 line dimensions here, to avoid race conditions with the main
2947 thread. (Bug#14062, bug#14630, bug#14669)
2948
2949 * w32term.c (w32_draw_window_cursor): Compute the header line and
2950 mode line dimensions here.
2951 <w32_system_caret_window, w32_system_caret_hdr_height>:
2952 <w32_system_caret_mode_height>: New variables.
2953
2954 * w32term.h: Declare them.
2955
89561f72
PE
29562013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2957
5013fc08
PE
2958 * alloc.c (die): Move "assertion failed" string here ...
2959 * lisp.h (eassert): ... from here. Also, suppress evaluation of
2960 COND when SUPPRESS_CHECKING. This shrinks the executable text
2961 size by 0.8% to 2.2% when configured with --enable-checking,
2962 depending on optimization flags (GCC 4.8.1 x86-64).
2963
89561f72
PE
2964 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
2965
763a086d 29662013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
2967
2968 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
2969 base is 2; this is more accurate.
2970
983aeb9a
JB
29712013-06-19 Juanma Barranquero <lekktu@gmail.com>
2972
2973 * sound.c (string_default): Move to !WINDOWSNT section.
2974 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
2975
178ba3e6
PE
29762013-06-19 Paul Eggert <eggert@cs.ucla.edu>
2977
bbc51b15
PE
2978 * sound.c: Integer cleanups.
2979 Remove unnecessary forward decls.
2980 (struct sound_device): The 'file' member is now a Lisp_Object, not
2981 a char *, so that we needn't invoke alloca on a huge size.
2982 (Fplay_sound_internal): Adjust to this.
2983 (string_default): New function.
2984 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
2985 Use it to adjust to the struct sound_device change.
2986 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
2987 (be2hs) [0]: Remove.
2988
178ba3e6
PE
2989 * syntax.c (skip_chars): Don't use uninitialized storage
2990 when searching a multibyte buffer for characters that are not in a
2991 unibyte string that contains non-ASCII characters.
2992
69f60cdc
JD
29932013-06-18 Jan Djärv <jan.h.d@swipnet.se>
2994
2995 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
2996 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
2997
0d6224d4
PE
29982013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2999
3000 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
3001
3c542890
KH
30022013-06-18 Kenichi Handa <handa@gnu.org>
3003
f7e3f7cd
KH
3004 * font.c (Ffont_spec): Signal an error for an invalid font name
3005 (Bug#14648).
3c542890 3006
9349e5f7
PE
30072013-06-18 Paul Eggert <eggert@cs.ucla.edu>
3008
3009 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
3010 In particular this ports to 32-bit sparc Sun cc.
3011 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
3012 array with a dummy element at specpdl[-1], so that its address can
3013 be taken portably.
3014 (unbind_to): Do not copy the binding; not needed, now that we
3015 copy old_value in the one place where the copy is needed.
3016 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
3017 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
3018 (union specbinding): Rename from struct specbinding. Redo layout
3019 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
3020 which is not portable. With Sun C 5.12 32-bit sparc, the
3021 declaration causes nargs to be an unsigned bitfield, a behavior
3022 that the C standard allows; but Emacs wants nargs to be signed.
3023 The overall type is now a union of structures rather than a
3024 structure of union of structures, and the 'kind' member is now a
3025 bitfield, so that the overall type doesn't grow. All uses changed.
3026 * process.c (Fmake_serial_process): Remove unnecessary initialization.
3027
0a4df6a5
PE
30282013-06-17 Paul Eggert <eggert@cs.ucla.edu>
3029
ec6ecaad
PE
3030 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
3031 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
3032
0a4df6a5
PE
3033 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
3034
7bfe8dbc
EZ
30352013-06-17 Eli Zaretskii <eliz@gnu.org>
3036
3037 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
3038 unless we know that the window w's frame is a frame object.
3039 Another attempt at solving bug#14062 and bug#14630.
3040
708e05f6
LMI
30412013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
3042
3043 * textprop.c (property_set_type): New enum.
3044 (add_properties): Allow appending/prepending text properties.
3045 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 3046 (Fadd_text_properties): Move all the code into
708e05f6
LMI
3047 add_text_properties_1.
3048 (Fadd_face_text_property): New function that calls
3049 add_text_properties_1.
3050
84575e67
PE
30512013-06-17 Paul Eggert <eggert@cs.ucla.edu>
3052
3053 Move functions from lisp.h to individual modules when possible.
3054 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
3055 * alloc.c (XFLOAT_INIT, set_symbol_name):
3056 * buffer.c (CHECK_OVERLAY):
3057 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
3058 (set_char_table_parent):
3059 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
3060 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
3061 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
3062 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
3063 (set_blv_valcell):
3064 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
3065 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
3066 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
3067 (backtrace_args, backtrace_debug_on_exit):
3068 * floatfns.c (CHECK_FLOAT):
3069 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
3070 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
3071 (set_hash_hash, set_hash_hash_slot, set_hash_index)
3072 (set_hash_index_slot):
3073 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
3074 * marker.c (CHECK_MARKER):
3075 * textprop.c (CHECK_STRING_OR_BUFFER):
3076 * window.c (CHECK_WINDOW_CONFIGURATION):
3077 Move here from lisp.h, and make these functions static rather than
3078 extern inline.
3079 * buffer.c (Qoverlayp):
3080 * data.c (Qsubrp):
3081 * fns.c (Qhash_table_p):
3082 * window.c (Qwindow_configuration_p):
3083 Now static.
3084 * lisp.h: Remove the abovementioned defns and decls.
3085
44e18199 3086 Use functions, not macros, for XINT etc (Bug#11935).
84575e67
PE
3087 In lisp.h, prefer functions to function-like macros, and
3088 constants to object-like macros, when either will do. This:
3089 . simplifies use, as there's no more need to worry about
3090 arguments' side effects being evaluated multiple times.
3091 . makes the code easier to debug on some platforms.
3092 However, when using gcc -O0, keep using function-like macros
3093 for a few critical operations, for performance reasons.
3094 This sort of thing isn't needed with gcc -Og, but -Og
3095 is a GCC 4.8 feature and isn't widely-enough available yet.
3096 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
3097 Remove enum lsb_bits; no longer needed.
3098 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
3099 * buffer.c (Qoverlap):
3100 * data.c (Qsubrp):
3101 * fns.c (Qhash_table_p):
3102 Now extern, so lisp.h can use these symbols.
3103 * dispextern.h: Include character.h, for MAX_CHAR etc.
3104 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
3105 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
3106 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
3107 (GLYPH_CODE_P): Move here from lisp.h.
3108 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
3109 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
3110 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
3111 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
3112 XUNTAG now returns void *.
3113 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
3114 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
3115 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
3116 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
3117 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
3118 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
3119 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
3120 (lisp_h_XPNTR, lisp_h_XSYMBOL):
3121 New macros, renamed from their sans-lisp_h_ counterparts.
3122 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
3123 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
3124 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
3125 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
3126 If compiling via GCC without optimization, define these as macros
3127 in addition to inline functions.
3128 To disable this, compile with -DINLINING=0.
3129 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
3130 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
3131 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
3132 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
3133 (INTMASK, VALMASK): Now macros, since static values cannot be
3134 accessed from extern inline functions.
3135 (VALMASK): Also a constant, for benefit of old GDB.
3136 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
3137 is INTEGERP, which can fold it in.
5165d44a 3138 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
3139 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
3140 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
3141 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
3142 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
3143 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
3144 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
3145 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
3146 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
3147 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
3148 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
3149 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
3150 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
3151 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
3152 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
3153 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
3154 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
3155 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
3156 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
3157 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
3158 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
3159 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
3160 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
3161 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
3162 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
3163 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
3164 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
3165 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
3166 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
3167 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
3168 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
3169 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
3170 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
3171 Now functions.
3172 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
3173 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
3174 (VALMASK): Define in one place rather than in two, merging the
3175 USE_LSB_TAG parts; this is simpler.
3176 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
3177 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
3178 Move up, to avoid use before definition.
3179 Also include "globals.h" earlier, for the same reason.
3180 (make_natnum): New function.
3181 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
3182 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
3183 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
3184 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
3185 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
3186 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
3187 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
3188 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
3189 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
3190 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
3191 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
3192 (Qwindow_configuration_p, Qimage): New forward declarations.
3193 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
3194 (STRING_COPYIN): Remove; unused.
3195 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
3196 (xcar_addr, xcdr_addr): New functions. All uses changed.
3197 (IEEE_FLOATING_POINT): Now a constant, not a macro.
3198 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
3199 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
3200 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
3201 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
3202 (TYPE_RANGED_INTEGERP): Simplify.
3203 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
3204 (setlocale, fixup_locale, synchronize_system_messages_locale)
3205 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
3206 Now empty functions, not macros.
3207 (functionp): Return bool, not int.
3208 * window.c (Qwindow_configuration_p): Now extern,
3209 so window.h can use it.
3210 * window.h (Qwindowp): Move decl back to lisp.h.
3211
9583ec36
EZ
32122013-06-15 Eli Zaretskii <eliz@gnu.org>
3213
3214 * xdisp.c (Fline_pixel_height): New function, required for solving
3215 bug #14567.
3216
210272ce
PE
32172013-06-15 Paul Eggert <eggert@cs.ucla.edu>
3218
3219 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
3220
de0503df
SM
32212013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
3222
3223 * lread.c (syms_of_lread):
3224 * fns.c (Fprovide): Adjust to new format of after-load-alist.
3225
afbfe143
KD
32262013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
3227
3228 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
3229
d177e213
XF
32302013-06-12 Xue Fuqiao <xfq.free@gmail.com>
3231
3232 * fileio.c (expand_file_name): Doc fix.
3233
05e3e412
PE
32342013-06-11 Paul Eggert <eggert@cs.ucla.edu>
3235
f7394b12
PE
3236 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
3237 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
3238 Wait for self, not for 0. This can't hurt on GNU or similar
3239 system, and may help with Cygwin.
3240
05e3e412
PE
3241 * keyboard.c: Don't use PROP (...) as an lvalue.
3242 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
3243 Use set_prop (A, B), not PROP (A) = B.
3244
17dd3097
EZ
32452013-06-10 Eli Zaretskii <eliz@gnu.org>
3246
3247 * xdisp.c (get_it_property): Use it->window instead of generating
3248 a Lisp object from it->w.
3249
52fab9c9
EZ
32502013-06-09 Eli Zaretskii <eliz@gnu.org>
3251
3252 * xdisp.c (get_it_property): If it->object is a buffer, pass to
3253 get-char-property the window that is being rendered, instead of
3254 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
3255 (compute_display_string_pos): When W is NULL, use the current
3256 buffer as the object to pass to get-char-property.
3257 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
3258 pointer member of the bidi iterator, since no window is pertinent
3259 to this function.
52fab9c9 3260
5bf97bfc
EZ
32612013-06-08 Eli Zaretskii <eliz@gnu.org>
3262
3263 * bidi.c (bidi_fetch_char): Accept additional argument, the window
3264 being displayed, and pass it to compute_display_string_pos.
3265 (bidi_level_of_next_char, bidi_resolve_explicit_1)
3266 (bidi_paragraph_init): All callers changed.
3267
3268 * xdisp.c (init_from_display_pos, init_iterator)
3269 (handle_single_display_spec, next_overlay_string)
3270 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
3271 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
3272 Set bidi_it.w member from it->w.
5bf97bfc
EZ
3273 (compute_display_string_pos): Accept additional argument, the
3274 window being displayed, and pass it to Fget_char_property.
3275 (Bug#14575)
3276
3277 * dispextern.h (struct bidi_it): New member w, the window being
3278 displayed.
3279 (compute_display_string_pos): Adjust prototype.
3280
5de0e011
JD
32812013-06-08 Jan Djärv <jan.h.d@swipnet.se>
3282
e7b41c4c 3283 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
3284
3285 * process.c (wait_reading_process_output): Check for NS before GLIB.
3286 GLIB may be linked in due to rsvg, but ns_select must be called.
3287
5de0e011
JD
3288 * xgselect.c (xg_select): Remove call to window_system_available
3289 and g_main_context_pending at the top, so Gdk events (i.e. file
3290 notify) are processed when Emacs is started with -nw.
3291
a822acff
EZ
32922013-06-07 Eli Zaretskii <eliz@gnu.org>
3293
3294 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
3295 (ctagsfiles3): New variable, includes only *.m files.
3296 (TAGS): Use an explicit language name in the regular expressions,
3297 to avoid transformation of '/SOMETHING' by MSYS to
3298 'c:\MSYS\SOMETHING'.
3299
6c0a9ed1
RC
33002013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
3301
3302 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
3303
9ef6111b
EZ
33042013-06-06 Eli Zaretskii <eliz@gnu.org>
3305
3306 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
3307 still need to set the mouse pointer shape and activate help-echo.
3308 (Bug#14558)
3309
7d300d64
PE
33102013-06-06 Paul Eggert <eggert@cs.ucla.edu>
3311
3312 A few porting etc. fixes for the new file monitor code.
3313 See the thread containing
3314 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
3315 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
3316 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
3317 (dir_monitor_callback, Fgfile_rm_watch):
3318 Use assq_no_quit instead of Fassoc, for speed.
3319 (dir_monitor_callback, Fgfile_rm_watch):
3320 eassert that the monitor is a fixnum.
3321 (dir_monitor_callback): No need for CDR_SAFE.
3322 Simplify building of lisp with alternative tails.
3323 (Fgfile_add_watch, Fgfile_rm_watch):
3324 Do not assume glib functions set errno reliably on failure.
3325 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
3326 and signal an error otherwise.
3327 (Fgfile_rm_watch): Prefer CONSP to !NILP.
3328 Use Fdelq instead of Fdelete, for speed.
3329
817ebfcf
EZ
33302013-06-05 Eli Zaretskii <eliz@gnu.org>
3331
3332 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
3333 don't insist on being invoked on a highlighted tool-bar button.
3334 Avoids losing tool-bar functionality when mouse-highlight is nil.
3335 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
3336 Don't highlight when mouse-highlight is nil.
3337 (note_mouse_highlight): When mouse-highlight is nil, don't return
3338 right away; instead, run tool-bar and mode-line highlight
3339 subroutine, clear any existing highlight, and revert the mouse
3340 pointer to its default shape. (Bug#14558)
3341
55577e7c
SM
33422013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
3343
3344 * lisp.mk (lisp): Add prog-mode.el.
3345
f019a684
PE
33462013-06-05 Paul Eggert <eggert@cs.ucla.edu>
3347
3348 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
3349 * process.c (dummy_handler): New function.
3350 (lib_child_handler): New static var.
3351 (handle_child_signal): Invoke it.
3352 (catch_child_signal): If a library has set up a signal handler,
3353 save it into lib_child_handler.
3354 (init_process_emacs): If using glib and not on Windows, tickle glib's
3355 child-handling code so that it initializes its private SIGCHLD handler.
3356 * syssignal.h (SA_SIGINFO): Default to 0.
3357 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
3358 31; it should no longer be needed now.
3359
90db8702
MA
33602013-06-05 Michael Albinus <michael.albinus@gmx.de>
3361
3362 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
3363
3364 * gfilenotify.c (globals_of_gfilenotify): New function.
3365 (syms_of_gfilenotify): Move global initialization there.
3366
3367 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
3368
bfa3acd6
SM
33692013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
3370
3371 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
3372 * keyboard.c (menu_bar_items, tool_bar_items):
3373 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
3374 not override local keymaps any more.
3375
ba59bd80
EZ
33762013-06-04 Eli Zaretskii <eliz@gnu.org>
3377
3378 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
3379
7f203aa1
EZ
33802013-06-03 Eli Zaretskii <eliz@gnu.org>
3381
9337e206
EZ
3382 * w32console.c (initialize_w32_display): Return the dimensions of
3383 the console window via 2 additional arguments, not via the current
3384 frame. This avoids crashes due to overrunning the bounds of
3385 frame's decode_mode_spec_buffer, which is not resized following
3386 the change of the frame dimensions from the initial 10x10.
3387
3388 * w32term.h (w32_initialize_display_info): Adjust prototype.
3389
3390 * term.c (init_tty): Take dimensions of the frame from the values
3391 returned by initialize_w32_display.
3392
7f203aa1
EZ
3393 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
3394 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
3395 (LIBES): Add $(GFILENOTIFY_LIBS).
3396
3397 * w32inevt.c (handle_file_notifications): Add dummy implementation
3398 for !HAVE_W32NOTIFY.
3399
3400 * w32term.c: Wrap code with HAVE_W32NOTIFY.
3401
55a87246
JD
34022013-06-03 Jan Djärv <jan.h.d@swipnet.se>
3403
3404 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
3405
3406 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
3407
3408 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
3409
3d5ee10a
PE
34102013-06-03 Paul Eggert <eggert@cs.ucla.edu>
3411
3412 Fix minor problems found by static checking.
3413 * data.c (pure_write_error):
3414 Use xsignal2, not Fsignal, as Fsignal might return.
3415 * eval.c (set_backtrace_debug_on_exit): Now static.
3416 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
3417 No longer inline. EXTERN_INLINE is needed only for functions
3418 defined in .h files. Reindent function header as per GNU style.
3419 (backtrace_p, backtrace_top, backtrace_next):
3420 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
3421 compiler or linker. Add extern decls to pacify gcc -Wall.
3422 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
3423 Now static.
3424 * frame.c (free_monitors): Define only on platforms that need it.
3425 * nsterm.m (ns_term_init):
3426 * process.c (catch_child_signal):
3427 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
3428 defined on all porting targets these days.
3429 * process.c, process.h (catch_child_signal):
3430 Make it extern only if NS_IMPL_GNUSTEP is defined.
3431
e2d8a6f0
EZ
34322013-06-03 Eli Zaretskii <eliz@gnu.org>
3433
3434 * w32.c (gettimeofday): Make the signature identical to prototype
3435 in nt/inc/sys/time.h.
3436
a8a7c5f6
SM
34372013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
3438
3439 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
3440 .gdbinit.
3441
3442 * keyboard.c (safe_run_hooks_error): Improve error message.
3443
3444 * data.c (pure_write_error): Add `object' argument.
3445 * puresize.h (CHECK_IMPURE): Use it.
3446
c9628c79
MA
34472013-06-03 Michael Albinus <michael.albinus@gmx.de>
3448
3449 * Makefile.in (NOTIFY_OBJ): New variable.
3450 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
3451
3452 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
3453 Call syms_of_gfilenotify.
3454
3455 * gfilenotify.c: New file.
3456
3457 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
3458 and Qfile_w32notify.
3459 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
3460 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
3461
3462 * lisp.h: Declare syms_of_gfilenotify.
3463
3464 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
3465
2f592f95
SM
34662013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
3467
3468 Merge the specpdl and backtrace stacks. Make the structure of the
3469 specpdl entries more obvious via a tagged union of structs.
3470 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
3471 (enum specbind_tag): New enum.
3472 (struct specbinding): Make it a tagged union of structs.
3473 Add a case for backtrace records.
3474 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
3475 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
3476 (backtrace_debug_on_exit): New accessors.
3477 (struct backtrace): Remove.
3478 (struct catchtag): Remove backlist field.
3479 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3480 Move to eval.c.
3481 (Flocal_variable_p): Speed up the common case where the binding is
3482 already loaded.
3483 * eval.c (backtrace_list): Remove.
3484 (set_specpdl_symbol, set_specpdl_old_value): Remove.
3485 (set_backtrace_args, set_backtrace_nargs)
3486 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
3487 (backtrace_next): New functions.
3488 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
3489 (unwind_to_catch, internal_lisp_condition_case)
3490 (internal_condition_case, internal_condition_case_1)
3491 (internal_condition_case_2, internal_condition_case_n): Don't bother
3492 with backtrace_list any more.
3493 (Fsignal): Adjust to new backtrace format.
3494 (grow_specpdl): Move up.
3495 (record_in_backtrace): New function.
3496 (eval_sub, Ffuncall): Use it.
3497 (apply_lambda): Adjust to new backtrace format.
3498 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
3499 data.c.
3500 (specbind): Adjust to new specpdl format. Simplify.
3501 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
3502 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
3503 backtrace format.
3504 (mark_backtrace): Remove.
3505 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
3506 * xdisp.c (redisplay_internal): Use record_in_backtrace.
3507 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
3508 Use mark_specpdl.
3509 * profiler.c (record_backtrace): Use get_backtrace.
3510 (handle_profiler_signal): Use backtrace_top_function.
3511 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
3512 accessor functions.
3513
c0342369
JD
35142013-06-02 Jan Djärv <jan.h.d@swipnet.se>
3515
3516 * process.h (catch_child_signal): Declare.
3517
3518 * process.c (catch_child_signal): New function.
3519 (init_process_emacs): Call it.
3520
3521 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
3522 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
3523 NS_IMPL_COCOA.
3524 (x_set_cursor_type): Remove declaration.
3525 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
3526 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
3527 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
3528 (ns_get_color): Use F suffix on float.
3529 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
3530 (ns_get_rgb_color): Remove.
3531 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
3532 (note_mouse_movement): x and y are CGFloat.
3533 (ns_draw_fringe_bitmap): Remove unused rowY.
3534 Change #if to COCOA && >= 10_6.
3535 (ns_draw_window_cursor): Remove unused overspill.
3536 (ns_draw_underwave): width and x are EamcsCGFloat.
3537 (ns_draw_box): thickness is CGFloat.
3538 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
3539 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
3540 if not in main thread.
3541 (ns_get_pending_menu_title, ns_check_menu_open)
3542 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
3543 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
3544 (sendFromMainThread:): New method.
3545 (changeFont:): size is CGFloat.
3546 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
3547 Disable warning about permanent text.
3548 (characterIndexForPoint:): Adjust return type depending on GNUStep
3549 version.
3550 (mouseDown:): delta is CGFloat.
3551 (updateFrameSize): Remove unised variable f.
3552 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
3553 Cast float to EmacsCGFloat.
3554 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
3555 also to -1 when restoring.
3556 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
3557 inside NS_IMPL_COCOA.
3558 (toggleFullScreen:): Put call to toggleFullScreen inside
3559 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
3560 (setPosition:portion:whole:): por is CGFloat.
3561 (getMouseMotionPart:window:x:y:): Add F suffix to float.
3562 (mouseDown:): Use CGFloat.
3563 (mouseDragged:): Remove unised variable edge.
3564 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
3565
3566 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
3567 of CGFloat differs.
3568 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
3569 when NS_IMPL_GNUSTEP.
3570 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
3571 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
3572 (EmacsToolbar): Add clearAll. Add tag argument to
3573 addDisplayItemWithImage.
3574 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
3575
3576 * nsselect.m (ns_get_local_selection): Remove unused variable type.
3577
3578 * nsmenu.m (ns_update_menubar): Make static.
3579 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
3580 (fillWithWidgetValue:): Add cast to SEL for setAction.
3581 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
3582 (update_frame_tool_bar): Update code for GNUStep.
3583 (clearAll): New method.
3584 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 3585 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 3586 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
3587 call to insertItemWithItemIdentifier.
3588 (validateVisibleItems): Fix indentation.
3589 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
3590 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
3591 UtilityWindow to aStyle, remove call to setStyleMask.
3592
3593 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
3594
3595 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
3596 (ns_charset_covers, ns_get_covering_families, nsfont_open):
3597 Use F suffix on floats.
3598 (ns_char_width): Returns CGFloat.
3599 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 3600 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
3601 DPSxshow.
3602 (ns_glyph_metrics): CGFloat instead of float.
3603
a0eb10b3
JB
3604 * nsfns.m (x_set_foreground_color, x_set_background_color):
3605 Use EmacsCGFloat.
3606 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
3607 remove unused variables.
3608 (Fns_read_file_name): Keep track if panel is for save.
3609 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 3610 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
3611 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
3612 Just return the input if GNUStep.
c0342369
JD
3613 (x_screen_planes): Remove.
3614 (Fxw_color_values): Use EmacsCGFloat
3615 (Fns_display_monitor_attributes_list): Only get screen number for
3616 Cocoa.
ef099a94 3617 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
3618 EmacsSavePanel.
3619 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
3620 ns_directory_from_panel.
3621
da9aff11
PE
36222013-06-01 Paul Eggert <eggert@cs.ucla.edu>
3623
3624 * process.c (handle_child_signal): Also use WCONTINUED.
3625 This is so that list-processes doesn't mistakenly list the process
3626 as stopped, when the process has actually been continued and is
3627 now running.
3628
0e64479a
PE
36292013-05-31 Paul Eggert <eggert@cs.ucla.edu>
3630
fc186a96
PE
3631 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
3632 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
3633 not already configured.
3634
0e64479a
PE
3635 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
3636
38b787fa
EZ
36372013-05-29 Eli Zaretskii <eliz@gnu.org>
3638
3639 * Makefile.in (mostlyclean): Remove *.res files.
3640
22513e52
SM
36412013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
3642
3643 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
3644 a buffer (bug#8447).
3645
6ef3db10
EZ
36462013-05-27 Eli Zaretskii <eliz@gnu.org>
3647
3648 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
3649 display vector, and we backtrack, handle the case that the
3650 previous character position is also displayed from a display
3651 vector or covered by a display string or image. (Bug#14476)
3652
6799bb26
JD
36532013-05-25 Jan Djärv <jan.h.d@swipnet.se>
3654
3655 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3656 (struct MonitorInfo, free_monitors): Remove.
3657 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
3658 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
3659 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3660 Qframes, Qsource.
3661
3662 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3663 (struct MonitorInfo, free_monitors): Remove.
3664 (ns_screen_name): Make static.
3665 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
3666 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3667 Qframes, Qsource.
3668
3669 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3670 (struct MonitorInfo): New struct.
3671 (free_monitors, make_monitor_attribute_list): Declare.
3672
22513e52
SM
3673 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
3674 New Lisp_Object:s.
6799bb26
JD
3675 (free_monitors, make_monitor_attribute_list): New functions.
3676 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
3677 Qsource.
3678
38cd43eb
XF
36792013-05-25 Xue Fuqiao <xfq.free@gmail.com>
3680
3681 * callproc.c (call_process): Refine the doc string. (Bug#14045)
3682
2af0948d
SM
36832013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
3684
a7eb9b0f
SM
3685 * keyboard.c: Apply keyboard decoding only to events that come directly
3686 from the tty, not from unread-command-events (bug#14368).
3687 (read_event_from_main_queue): New function, extracted from read_char).
3688 (read_decoded_char): Remove.
3689 (read_decoded_event_from_main_queue): New function to replace it.
3690 (read_char): Use it.
3691 (read_key_sequence): Use read_char rather than read_decoded_char.
3692
2af0948d
SM
3693 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
3694
1413e9a5
BR
36952013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
3696
3697 * casetab.c (init_casetab_once): Fix last change (bug#14424).
3698
e6d2f155
KH
36992013-05-22 Kenichi Handa <handa@gnu.org>
3700
3701 The following changes are to fix the setting of
3702 buffer-file-coding-system on, for instance, C-x RET c unix RET
3703 _FILE_OF_DOS_EOL_TYPE_ RET.
3704
3705 * coding.h (struct coding_system): New member detected_utf8_chars.
3706
3707 * coding.c (detect_coding_utf_8): Count characters and check EOL
3708 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
3709 BOM is there.
3710 (setup_coding_system): Do not initialize coding->head_ascii.
3711 (check_ascii): Do not set coding->eol_seen but update it. Do not
3712 call adjust_coding_eol_type here.
1413e9a5
BR
3713 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
3714 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
3715 of the found coding-system.
3716 (decode_coding_gap): Cancel previous change. Utilize the
3717 character numbers counted by detect_coding_utf_8. Fix detection
3718 of BOM for utf-8.
3719
ab56a6f4 37202013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
3721
3722 * search.c (looking_at_1): Only set last_thing_searched if the match
3723 changed the match-data (bug#14281).
3724
ecc3c6ed
DA
37252013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
3726
3727 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 3728 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
3729 (move_it_vertically_backward): Likewise.
3730
5ba8bf35
YM
37312013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3732
3733 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 3734 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
3735 (Fx_display_mm_width, Fx_display_mm_height):
3736 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 3737
91e8418b 3738 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 3739 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
3740 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
3741 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
3742 (Fx_display_backing_store, Fx_display_visual_class)
3743 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
3744 (Fx_display_grayscale_p, Fx_display_pixel_width)
3745 (Fx_display_pixel_height, Fx_display_planes)
3746 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
3747 (Fx_display_screens): Don't confuse X11 screens with NS screens.
3748 (Fx_display_mm_width, Fx_display_mm_height)
3749 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
3750 height for all physical monitors as in X11.
3751
fc30d803
SM
3752 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
3753 Return pixel width or height for all physical monitors as in X11.
91e8418b 3754
31ff141c
PE
37552013-05-18 Paul Eggert <eggert@cs.ucla.edu>
3756
3757 Port --enable-gcc-warnings to clang.
3758 * bytecode.c (exec_byte_code):
3759 * regex.c:
3760 Redo diagnostic pragmas to pacify clang, too.
3761 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
3762 * editfns.c (Fencode_time):
3763 * fileio.c (file_accessible_directory_p):
3764 * font.c (font_unparse_xlfd):
3765 Use '&"string"[index]' instead of '"string" + (index)'.
3766 * undo.c (user_error): Remove; unused.
3767
df065a0b
EZ
37682013-05-16 Eli Zaretskii <eliz@gnu.org>
3769
04d360e7
EZ
3770 * insdel.c (insert_1_both): Document the arguments, instead of
3771 referring to insert_1, which no longer exists.
3772
5bb98290
EZ
3773 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
3774 some window, increment windows_or_buffers_changed, so that
3775 *Messages* display in that window is updated. (Bug#14408)
3776
df065a0b
EZ
3777 * w32.c: Include epaths.h.
3778 (init_environment): Use cmdproxy.exe without leading directories.
3779 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
3780 case.
3781 (gettimeofday): Adjust signature and return value to Posix
3782 expectations.
3783
3784 * unexw32.c (open_output_file): Delete the existing emacs.exe
3785 before creating it, to break the hard link to the versioned
3786 executable.
3787
3788 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
3789 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
3790 (FIRSTFILE_OBJ): New variables.
3791 (W32_RES): Rename to EMACSRES. All users changed.
3792 (base_obj): Use $(CM_OBJ).
3793 (ALLOBJS): Use $(FIRSTFILE_OBJ).
3794 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
3795 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
3796 $(W32_RES_LINK) before $(LIBES).
3797 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
3798
1aa8d505
SM
37992013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3800
6e911150
SM
3801 * makefile.w32-in (DOC): Use just "DOC".
3802
3803 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
3804
1aa8d505
SM
3805 * process.c: Export default filters and sentinels to Elisp.
3806 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
3807 New constants.
3808 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
3809 (Fset_process_sentinel, Fformat_network_address):
3810 Default to them instead of nil.
3811 (server_accept_connection): Sentinels can't be nil any more.
3812 (read_and_dispose_of_process_output): New function, extracted from
3813 read_process_output.
3814 (read_process_output): Use it; filters can't be nil.
3815 (Finternal_default_process_filter): New function, extracted from
3816 read_process_output.
3817 (exec_sentinel_unwind): Remove function.
3818 (exec_sentinel): Don't zilch sentinel while running.
3819 (status_notify): Sentinels can't be nil.
3820 (Finternal_default_process_sentinel): New function extracted from
3821 status_notify.
3822 (setup_process_coding_systems): Default filter is not nil any more.
3823 (syms_of_process): Export new Elisp functions and initialize
3824 new constants.
3825 * lisp.h (make_lisp_proc): New function.
3826
5ac2eb34
SM
38272013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3828
3829 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
3830
eda9c7d7
EZ
38312013-05-14 Eli Zaretskii <eliz@gnu.org>
3832
3833 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
3834 unless we know that the window w is a leaf window.
3835 Another attempt at solving bug#14062.
eda9c7d7 3836
8fdeaad5
JD
38372013-05-14 Jan Djärv <jan.h.d@swipnet.se>
3838
3839 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
3840 fdesc (Bug#14375).
3841
44aa9ee6
PE
38422013-05-12 Paul Eggert <eggert@cs.ucla.edu>
3843
3844 * image.c (gif_load): Check that subimages fit (Bug#14345).
3845
759fd763
SM
38462013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
3847
3848 * lread.c (skip_dyn_eof): New function.
3849 (read1): Use it to skip the end of a file in response to #@00.
3850
3851 * doc.c (get_doc_string): Slightly relax the sanity checking.
3852
4465bfb4
JD
38532013-05-09 Jan Djärv <jan.h.d@swipnet.se>
3854
3855 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
3856 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3857 (MonitorInfo): New struct.
3858 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
3859 (Fns_display_monitor_attributes_list): New functions.
3860 (display-usable-bounds): Remove.
3861 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
3862 Qsource.
3863
7583e2a0
PE
38642013-05-09 Paul Eggert <eggert@cs.ucla.edu>
3865
3866 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
3867 (GTK_CHECK_VERSION): New macro, if not already defined.
3868 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
3869 replaced by GTK_CHECK_VERSION.
3870
ad75d77e
PE
38712013-05-08 Paul Eggert <eggert@cs.ucla.edu>
3872
3873 * xterm.h (GTK_PREREQ): New macro.
3874 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
3875 to use this macro instead, for consistency and clarity.
3876
07525f77
EZ
38772013-05-08 Eli Zaretskii <eliz@gnu.org>
3878
3879 * xdisp.c (row_for_charpos_p): New function, with code of
3880 cursor_row_p, but accepts an additional argument CHARPOS instead
3881 of using a hardcoded PT.
3882 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
3883 (row_containing_pos): Call row_for_charpos_p instead of partially
3884 doing the same. Fixes cursor positioning under longlines-mode
3885 when longlines-show-effect includes more than one newline, when
3886 moving the cursor vertically up.
3887
d901fc8d
JB
38882013-05-08 Juanma Barranquero <lekktu@gmail.com>
3889
3890 * makefile.w32-in (ACL_H): New macro.
3891 ($(BLD)/fileio.$(O)): Update dependencies.
3892
f269bc61
PE
38932013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3894
e7b41c4c 3895 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
3896 * Makefile.in (LIB_ACL): New macro.
3897 (LIBACL_LIBS): Remove.
3898 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
3899 * fileio.c: Include <acl.h>.
3900 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
3901 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
3902 !acl_errno_valid.
3903 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
3904 it ourselves.
3905
f269bc61
PE
3906 * unexelf.c: Don't assume ElfW (Half) fits in int.
3907 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
3908 when dealing with ElfW (Half) values, since they can exceed 2**31
3909 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
3910 (entry_address): Omit unused NUM arg. All uses changed.
3911
a261c53e
JL
39122013-05-07 Juri Linkov <juri@jurta.org>
3913
3914 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
3915 to the string converted from number with `Fnumber_to_string'.
3916 (Bug#14254)
3917
2b66427d
PE
39182013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3919
3920 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
3921 This fixes a problem introduced by my previous change.
3922
15acfe41
GM
39232013-05-07 Glenn Morris <rgm@gnu.org>
3924
3925 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
3926
5ea03bf5
JD
39272013-05-07 Jan Djärv <jan.h.d@swipnet.se>
3928
3929 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
3930
e0c9d565
PE
39312013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3932
3933 Static checking by GCC 4.8.0.
3934 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
3935 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
3936 (x_get_monitor_attributes_fallback)
3937 (x_get_monitor_attributes_xinerama)
3938 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
3939 Define only if USE_GTK.
3940 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
3941 (x_get_monitor_attributes_fallback): Omit unused locals.
3942 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
3943 Use double, not float, to avoid mixed-mode floating point arithmetic.
3944
4e3f9230
YM
39452013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3946 Jan Djärv <jan.h.d@swipnet.se>
3947
3948 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
3949 (XINERAMA_CFLAGS): New macros.
3950 (ALL_CFLAGS, LIBES): Use them.
3951
3952 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
3953 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
3954 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
3955 (syms_of_xfns): DEFSYM them.
3956 (struct MonitorInfo): New struct.
3957 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
3958 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
3959 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
3960 (x_get_monitor_attributes_xinerama): New functions.
3961 (Fx_display_monitor_attributes_list): New primitive.
3962 (syms_of_xfns): Defsubr it.
3963
3964 * xterm.h (x_display_info): Add Xatom_net_workarea and
3965 Xatom_net_current_desktop.
3966
3967 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
3968 and dpyinfo->Xatom_net_current_desktop.
3969
05839b6a
EZ
39702013-05-06 Eli Zaretskii <eliz@gnu.org>
3971
3972 * xdisp.c (pos_visible_p): Use the special code for finding the
3973 beginning of a display property or overlay for any "replacing"
3974 display property, not just for display strings. This solves
3975 incorrect reporting of position by posn-at-point. (Bug#14241)
3976
dc4a2ee0
PE
39772013-05-06 Paul Eggert <eggert@cs.ucla.edu>
3978
5ee94506
PE
3979 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
3980 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
3981 Verify that ElfW (Half) fits in int.
3982 (fatal): Use same signature as lisp.h.
3983 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
3984 configure and build with -DUNEXELF_DEBUG without worrying about
3985 other modules that use DEBUG.
3986 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
3987 possibly-wide integers now uses it instead of plain fprintf.
3988 (entry_address): New function, which avoids problems with 32-bit
3989 overflow on 64-bit hosts.
3990 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
3991 (round_up): Don't assume the remainder fits in int.
3992 (find_section): Use bool for boolean. Simplify debug code.
3993 (unexec): Don't assume file sizes fit in int or size_t.
3994 Omit unnecessary trailing newline in 'fatal' format.
3995 Use strerror rather than outputting decimal error number.
3996 Remove unused code when emacs is not defined;
3997 this file relies on Emacs now.
3998 Don't assume e_phnum and e_shnum are positive.
3999
dc4a2ee0
PE
4000 * regex.c: Fix problems when DEBUG is defined.
4001 (extract_number, extract_number_and_incr): Define regardless of
4002 whether DEBUG is defined; that's simpler and makes the code less
4003 likely to go stale in the normal case when DEBUG is not defined.
4004 Return int rather than taking an int * arg. All callers changed.
4005 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
4006 Remove, replacing with ...
4007 (DEBUG_PRINT): New macro. All callers changed.
4008 (DEBUG_COMPILES_ARGUMENTS): New macro.
4009 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
4010 (print_compiled_pattern, print_double_string) [DEBUG]:
4011 Use prototype rather than old-style definition.
4012 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
4013 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
4014 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
4015 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
4016 Don't assume ptrdiff_t, size_t, and long are the same width as int.
4017 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
4018 This matters only when DEBUG is defined.
4019
14c7ed05
EZ
40202013-05-05 Eli Zaretskii <eliz@gnu.org>
4021
4022 * xdisp.c (set_iterator_to_next): Set the
4023 ignore_overlay_strings_at_pos_p flag only if we are _really_
4024 iterating over an overlay string, as indicated by the
4025 current.overlay_string_index member. (Bug#14306)
4026
e6076b1b
JD
40272013-05-05 Jan Djärv <jan.h.d@swipnet.se>
4028
4029 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
4030 to where it is used, to avoid autorelease issues (Bug#14050).
4031
cbee2131
PE
40322013-05-05 Paul Eggert <eggert@cs.ucla.edu>
4033
4034 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
4035 * fileio.c (syms_of_fileio): Implement this.
4036 * filelock.c (create_lock_file): If symbolic links don't work, so
4037 we use a regular file as a lock file, do not fsync the lock file;
4038 it's not needed.
4039
30c7e542
SM
40402013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4041
4042 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
4043 (syms_of_minibuf): Adjust accodingly.
4044 * lread.c (Fread):
4045 * callint.c (Fcall_interactively): Adjust calls accordingly.
4046
5bebd186
EZ
40472013-05-04 Eli Zaretskii <eliz@gnu.org>
4048
4049 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
4050 w->contents is a buffer before computing everything else.
4051 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
4052
4053 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
4054 assertion violations. (Bug#14062)
4055
0fb0a4f3
DR
40562013-05-01 David Reitter <david.reitter@gmail.com>
4057
4058 * nsfns.m (ns_tooltip): Initialize.
4059
9e63b4a5
EZ
40602013-04-28 Eli Zaretskii <eliz@gnu.org>
4061
4062 * coding.c (decode_coding_gap): Don't remove the character before
4063 a newline unless it's a CR character. (Bug#14287)
4064
ad60824e
DN
40652013-04-28 Dan Nicolaescu <dann@gnu.org>
4066
4067 * dispextern.h (struct face): Move enum face_underline_type
4068 earlier so that bitfields can be in the same word.
4069
edbdcec0
JD
40702013-04-28 Jan Djärv <jan.h.d@swipnet.se>
4071
4072 * nsfns.m (handlePanelKeys): New function.
4073 (EmacsOpenPanel:performKeyEquivalent:)
4074 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
4075 arrows/function/control and copy/paste keys (Bug#14296).
4076
0208ede7
JL
40772013-04-27 Juri Linkov <juri@jurta.org>
4078
4079 * callint.c (Fcall_interactively): Call `Qread_number' for
4080 interactive code letter `n' instead of using duplicate code.
4081 (Bug#14254)
4082
b8dd59f7
PE
40832013-04-27 Paul Eggert <eggert@cs.ucla.edu>
4084
4085 * systime.h (make_timeval): Declare as 'const'.
4086
8bd722db
KH
40872013-04-27 Kenichi Handa <handa@gnu.org>
4088
4089 * font.c (font_open_entity): Always open a font of manageable
4090 size.
4091
13d0e56f 40922013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 4093
f780d632
PE
4094 Port better to AIX (Bug#14258).
4095 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
4096 to pacify AIX xlc.
4097
ec509856
KH
40982013-04-24 Kenichi Handa <handa@gnu.org>
4099
4100 * coding.c (decode_coding_iso_2022): When an invalid escape
4101 sequence is encountered, reset the invocation and designation
4102 status to the safest one.
4103
84fc48e5
PE
41042013-04-22 Paul Eggert <eggert@cs.ucla.edu>
4105
4106 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
4107 Without this fix, "make distclean" leaves stamp-h1 behind.
4108
806bda47
EC
41092013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
4110
4111 * w32fns.c (w32_fullscreen_rect): New function to compute the
4112 window rectangle for the given fullscreen mode.
4113 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
4114 longer tunes the window size. This keeps the window's edges flush
4115 with the screen and allows the taskbar to hide itself in fullboth.
4116
4117 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
4118 window decorations and uses the entire screen.
4119
4120 * w32term.h (w32_fullscreen_rect) Add prototype.
4121 (struct w32_output): Replace normal_width, normal_height,
4122 normal_top, and normal_left members with a single normal_placement
4123 struct.
4124 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
4125 Remove macros.
4126 (FRAME_NORMAL_PLACEMENT): New macro.
4127
9cc2810b
JB
41282013-04-16 Juanma Barranquero <lekktu@gmail.com>
4129
4130 * minibuf.c (Ftest_completion): Silence compiler warning.
4131
fd16b54c
EZ
41322013-04-15 Eli Zaretskii <eliz@gnu.org>
4133
4134 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 4135 bug#14062.
fd16b54c
EZ
4136
4137 * frame.h (WINDOW_FRAME): Protect macro and its argument with
4138 parentheses.
4139
4140 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
4141 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
4142 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
4143 parentheses where appropriate.
4144
9e3379a0
PE
41452013-04-14 Paul Eggert <eggert@cs.ucla.edu>
4146
4147 * keyboard.c (timer_start_idle): Remove no-longer-used local.
4148
ddd6b685
EZ
41492013-04-14 Eli Zaretskii <eliz@gnu.org>
4150
4151 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
4152 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
4153 Mention in the doc string that setting these variables takes
4154 effect only after a call to set-window-buffer. (Bug#14200)
4155
29b79ba1
EZ
41562013-04-13 Eli Zaretskii <eliz@gnu.org>
4157
4158 * indent.c (Fvertical_motion): Don't consider display strings on
4159 overlay strings as display strings on the buffer position we
4160 started from. This prevents vertical cursor motion from jumping
4161 more than one line when there's an overlay string with a display
4162 property at end of line.
4163 Reported by Karl Chen <Karl.Chen@quarl.org> in
4164 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
4165
562c6ee9
SM
41662013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
4167
4168 * window.c (select_window): `record_buffer' even if window is
4169 already selected (bug#14191).
4170
fcc1fe85
EZ
41712013-04-11 Eli Zaretskii <eliz@gnu.org>
4172
4173 * window.c (Fwindow_end): Test more flags, including the buffer's
4174 last_overlay_modified flag, to determine whether the window's
4175 display is really up-to-date. Prevents the function from
4176 returning a stale value. (Bug#14170)
4177 (Fwindow_line_height): Fix the test for up-to-date-ness of the
4178 current matrix.
4179
f009190a
EZ
41802013-04-10 Eli Zaretskii <eliz@gnu.org>
4181
4182 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
4183 garbaged only if it is not already the top frame on its TTY.
4184 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
4185 there are GUI frames open in the same session. (Bug#13864)
4186
78ce603d
SM
41872013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
4188
4189 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
4190 of marking the idle timers directly.
4191
a8036e40
SM
41922013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
4193
4194 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
4195 tables (bug#14054).
4196
7ffe7ef6
SM
41972013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
4198
4199 * window.c (select_window): Don't record_buffer while the invariant is
4200 temporarily broken (bug#14161).
4201
4202 * fns.c (Fdelq): Don't assume !NILP => CONSP.
4203
7d9f6883
EZ
42042013-04-07 Eli Zaretskii <eliz@gnu.org>
4205
4206 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
4207
5406cfd9
RF
42082013-04-07 Romain Francoise <romain@orebokech.com>
4209
4210 Ignore additional platform-specific ACL errors (Bug#13702).
4211 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
4212 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
4213
95c0e83b
JD
42142013-03-31 Jan Djärv <jan.h.d@swipnet.se>
4215
4216 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
4217 f->output_data.ns.
4218
876da980
PE
42192013-04-07 Paul Eggert <eggert@cs.ucla.edu>
4220
4221 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
4222 This bug was introduced by my 2013-02-25 change that simplified
4223 data_start configuration. Without this change, on GNU/Linux
4224 an Emacs configured with --enable-profiling fails immediately
4225 due to a profiler signal.
4226 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
4227 with these flags. On platforms where special flags are needed
4228 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
4229 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
4230 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
4231
7452b7bd
DA
42322013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
4233
4234 Get rid of some platform-specific functions examining window
4235 system and its capabilities. This is a partial rework of the
4236 2013-04-05 change.
4237 * lisp.h (have_menus_p): Remove prototype. This function is
4238 replaced with platform-independent window_system_available.
4239 (check_window_system): Move to...
4240 * frame.h (decode_window_system_frame, window_system_available):
4241 ...here, add new prototypes.
4242 * frame.c (window_system_available, decode_window_system_frame):
4243 New functions.
4244 (check_window_system): Platform-independent now.
4245 * xterm.h (x_in_use): Remove declaration.
4246 (check_x_frame):
4247 * w32term.h (check_x_frame):
4248 * nsterm.h (check_x_frame): Remove prototypes. This function
4249 is replaced with platform-independent decode_window_system_frame.
4250 * msdos.c (have_menus_p): Remove.
4251 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
4252 Remove platform-specific functions. Use check_window_system,
4253 decode_window_system_frame and check_ns_display_info where
4254 appropriate. Minor style and comment tweaks.
4255 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
4256 (check_x_frame): Likewise.
4257 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
4258 Likewise.
4259 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
4260 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
4261 * xmenu.c, xselect.c: All related users changed.
4262
251e9147
KH
42632013-04-03 Kenichi Handa <handa@gnu.org>
4264
4265 The following changes is to optimize the code for reading UTF-8
4266 files.
4267
562c6ee9 4268 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
4269 changed. Check EOL format. Do not call adjust_coding_eol_type
4270 here.
4271 (check_utf_8): New function.
4272 (adjust_coding_eol_type): Do nothing if already adjusted.
4273 (detect_coding): Compare the return value of check_ascii with
4274 coding->src_bytes. Call adjust_coding_eol_type if necessary.
4275 (decode_coding_gap): Optimize for valid UTF-8.
4276
8bc369d4
KH
42772013-03-21 Kenichi Handa <handa@gnu.org>
4278
4279 * coding.c (syms_of_coding): Cancel previous change.
4280
4281 * insdel.c (insert_from_gap): Fix previous change.
4282
73931ad1
DA
42832013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
4284
4285 Consistently use platform-specific function to detect window system.
4286 * lisp.h (check_window_system): New prototype. This function is
4287 going to replace check_x, check_w32 and check_ns.
4288 (have_menus_p): Mention msdos.c in comment.
4289 * fontset.c (check_window_system_func): Remove. Adjust all users.
4290 * fontset.h (check_window_system_func): Remove prototype.
4291 * nsterm.h (check_ns):
4292 * xterm.h (check_x):
4293 * w32term.h (check_w32): Likewise.
4294 * menu.c (Fx_popup_menu): Use check_window_system.
4295 * msdos.c (check_window_system): Define for MS-DOS.
4296 * nsfns.m (check_window_system): Define for NS. Adjust all users.
4297 * w32fns.c (check_window_system): Likewise for MS-Windows.
4298 * xfns.c (check_window_system): Likewise for X.
4299 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
4300 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
4301
7216e43b
PE
43022013-04-02 Paul Eggert <eggert@cs.ucla.edu>
4303
4304 Prefer < to > in range checks such as 0 <= i && i < N.
4305 This makes it easier to visualize quantities on a number line.
4306 This patch doesn't apply to all such range checks,
4307 only to the range checks affected by the 2013-03-24 change.
4308 This patch reverts most of the 2013-03-24 change.
4309 * alloc.c (xpalloc, Fgarbage_collect):
4310 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
4311 * character.c (string_escape_byte8):
4312 * charset.c (read_hex):
4313 * data.c (cons_to_unsigned):
4314 * dispnew.c (update_frame_1):
4315 * doc.c (Fsubstitute_command_keys):
4316 * doprnt.c (doprnt):
4317 * editfns.c (hi_time, decode_time_components):
4318 * fileio.c (file_offset):
4319 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
4320 * font.c (font_intern_prop):
4321 * frame.c (x_set_alpha):
4322 * gtkutil.c (get_utf8_string):
4323 * indent.c (check_display_width):
4324 * keymap.c (Fkey_description):
4325 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
4326 * lread.c (read1):
4327 * minibuf.c (read_minibuf_noninteractive):
4328 * process.c (wait_reading_process_output):
4329 * search.c (Freplace_match):
4330 * window.c (get_phys_cursor_glyph):
4331 * xdisp.c (redisplay_internal):
4332 * xsmfns.c (smc_save_yourself_CB):
4333 Prefer < to > for range checks.
4334 * dispnew.c (sit_for): Don't mishandle NaNs.
4335 This fixes a bug introduced in the 2013-03-24 change.
4336 * editfns.c (decode_time_components): Don't hoist comparison.
4337 This fixes another bug introduced in the 2013-03-24 change.
4338
92759988
DA
43392013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
4340
4341 * frame.h (struct frame): Drop scroll_bottom_vpos
4342 member becaue all real users are dead long ago.
4343 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
4344 * xdisp.c (redisplay_internal): Adjust user.
4345
9a1971bb
GM
43462013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
4347
f38ab167
JD
4348 * nsmenu.m (showAtX:Y:for:): setLevel to
4349 NSPopUpMenuWindowLevel (Bug#13998).
4350
6d01f1fe
JD
43512013-03-30 Jan Djärv <jan.h.d@swipnet.se>
4352
4353 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
4354 (ns_check_pending_open_menu): Declare.
4355
4356 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
4357 (x_activate_menubar): Update the menu with title that matches
4358 ns_get_pending_menu_title, and call
4359 ns_check_pending_openmenu (Bug#12698).
4360 (menuWillOpen:): New method.
4361 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
4362
4363 * nsterm.m (menu_will_open_state, menu_mouse_point)
4364 (menu_pending_title): New varaibles.
4365 (ns_get_pending_menu_title, ns_check_menu_open)
4366 (ns_check_pending_open_menu): New functions.
4367
781f4782
DA
43682013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
4369
4370 * indent.c (current_column_bol_cache): Remove leftover which is not
4371 used in Fmove_to_column any more.
4372 (current_column, scan_for_column): Adjust users.
4373 * keyboard.c (last_point_position_buffer, last_point_position_window):
4374 Remove leftovers which are not used for recording undo any more.
4375 (command_loop_1, syms_of_keyboard): Adjust users.
4376 * xdisp.c (last_max_ascent): Remove leftover which is not used in
4377 redisplay_window any more.
4378 (move_it_to): Adjust user.
4379
1921c31b
JB
43802013-03-29 Juanma Barranquero <lekktu@gmail.com>
4381
4382 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
4383 Update dependencies.
4384
717b8bcd
SM
43852013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4386
4387 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
4388 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
4389 forward references.
4390
e74aeda8
DA
43912013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
4392
4393 * window.h (struct window): Replace hchild, vchild and buffer slots
4394 with the only contents slot. This is possible because each valid
4395 window may have either the child window (in vertical or horizontal
4396 combination) or buffer to display (for the leaf window). Using that,
4397 a lof of operations to traverse and/or change window hierarchies may
4398 be simplified. New member horizontal is used to distinguish between
4399 horizontal and vertical combinations of internal windows.
4400 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
4401 (WINDOW_VERTICAL_COMBINATION_P): New macros.
4402 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
4403 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
4404 Use contents slot, not buffer, where appropriate.
4405 (wset_combination): New function.
4406 (wset_buffer): Add eassert.
4407 (Fframe_first_window): Simplify the loop reaching first window.
4408 (Fwindow_buffer): Use WINDOW_LEAF_P.
4409 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
4410 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
4411 (unshow_buffer): Convert initial debugging check to eassert.
4412 (replace_window, recombine_windows, Fdelete_other_windows_internal)
4413 (make_parent_window, window_resize_check, window_resize_apply)
4414 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
4415 (Fset_window_configuration, delete_all_child_windows, save_window_save):
4416 Adjust to match struct window changes.
4417 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
4418 (mark_window_cursors_off, count_windows, get_leaf_windows)
4419 (foreach_window_1): Simplify the loop.
4420 * alloc.c (mark_object): Do not check for the leaf window because
4421 internal windows has no glyph matrices anyway.
4422 * dispnew.c (clear_window_matrices, showing_window_margins_p)
4423 (allocate_matrices_for_window_redisplay, fake_current_matrices)
4424 (allocate_matrices_for_frame_redisplay, free_window_matrices)
4425 (build_frame_matrix_from_window_tree, mirror_make_current)
4426 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
4427 (update_window_tree, set_window_update_flags): Simplify the loop.
4428 (sync_window_with_frame_matrix_rows): Enforce live window.
4429 Use contents slot, not buffer, where appropriate.
4430 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
4431 and WINDOW_HORIZONTAL_COMBINATION_P.
4432 (make_frame_visible_1): Simplify the loop.
4433 Use contents slot, not buffer, where appropriate.
4434 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
4435 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
4436 (expose_window_tree): Likewise.
4437 Use contents slot, not buffer, where appropriate.
4438 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
4439 to avoid deleted windows. Use contents slot instead of buffer.
4440 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
4441 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
4442 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
4443 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
4444
121ab1cd
EZ
44452013-03-28 Eli Zaretskii <eliz@gnu.org>
4446
ef454cf7
EZ
4447 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
4448 identify the reasons for assertion violations in bug#14062 and
4449 similar ones.
21e930f8
EZ
4450 (Fx_show_tip): Fix compilation error under
4451 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 4452
121ab1cd
EZ
4453 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
4454 Reported by <rzl24ozi@gmail.com>.
4455
5c89ca24
DA
44562013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
4457
4458 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
4459 start marker...
562c6ee9
SM
4460 (unwind_with_echo_area_buffer): ...to restore it here.
4461 This is needed to ensure that...
5c89ca24
DA
4462 (redisplay_window): ...both window markers are valid here,
4463 which is verified by eassert.
4464 * editfns.c (save_excursion_save): Do not assume that
4465 selected_window always displays the buffer.
c7f53895
DA
4466 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
4467 Fix comment.
5c89ca24 4468
f557c1b1
SM
44692013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
4470
4471 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
4472 the upcase table.
4473
40693bba 44742013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
4475
4476 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
4477
c86f791f
EZ
44782013-03-27 Eli Zaretskii <eliz@gnu.org>
4479
4480 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
4481 since MinGW's w32api headers do. This avoids compiler warnings.
4482
4483 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
4484 if already defined.
4485
c6e72e17
EZ
44862013-03-26 Eli Zaretskii <eliz@gnu.org>
4487
4488 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
4489
54e95010
JD
44902013-03-26 Jan Djärv <jan.h.d@swipnet.se>
4491
4492 * gtkutil.c (style_changed_cb): Check if frame is live and an
4493 X frame (Bug#14038).
4494
b88b62de
EZ
44952013-03-26 Eli Zaretskii <eliz@gnu.org>
4496
a18d7de6
EZ
4497 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
4498 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
4499 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
4500 MinGW64.
8f5e14c8
EZ
4501 Move inclusion of time.h before sys/time.h, so that MinGW64 could
4502 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 4503
b88b62de
EZ
4504 Fix incompatibilities between MinGW.org and MinGW64 headers.
4505 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
4506
4507 * w32.c (REPARSE_DATA_BUFFER): Guard with
4508 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
4509
c074e458
JD
45102013-03-25 Jan Djärv <jan.h.d@swipnet.se>
4511
4512 * xterm.c: Include X11/XKBlib.h
4513 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
4514
908589fd
AS
45152013-03-24 Andreas Schwab <schwab@linux-m68k.org>
4516
4517 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
4518 written backwards.
4519 * blockinput.h (input_blocked_p): Likewise.
4520 * bytecode.c (exec_byte_code): Likewise.
4521 * callproc.c (call_process_kill, call_process_cleanup)
4522 (Fcall_process): Likewise.
4523 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
4524 (Fccl_execute_on_string): Likewise.
4525 * character.c (string_escape_byte8): Likewise.
4526 * charset.c (read_hex): Likewise.
4527 * cm.c (calccost): Likewise.
4528 * data.c (cons_to_unsigned): Likewise.
4529 * dired.c (directory_files_internal, file_name_completion):
4530 Likewise.
4531 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
4532 (sit_for): Likewise.
4533 * doc.c (Fsubstitute_command_keys): Likewise.
4534 * doprnt.c (doprnt): Likewise.
4535 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
4536 * emacsgtkfixed.c: Likewise.
4537 * fileio.c (file_offset, Fwrite_region): Likewise.
4538 * floatfns.c (Fexpt, fmod_float): Likewise.
4539 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
4540 Likewise.
4541 * font.c (font_intern_prop): Likewise.
4542 * frame.c (x_set_alpha): Likewise.
4543 * gtkutil.c (get_utf8_string): Likewise.
4544 * indent.c (check_display_width): Likewise.
4545 * intervals.c (create_root_interval, rotate_right, rotate_left)
4546 (split_interval_right, split_interval_left)
4547 (adjust_intervals_for_insertion, delete_node)
4548 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4549 (merge_interval_right, merge_interval_left, copy_intervals)
4550 (set_intervals_multibyte_1): Likewise.
4551 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
4552 * keymap.c (Fkey_description): Likewise.
4553 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
4554 * lread.c (openp, read_integer, read1, string_to_number):
4555 Likewise.
4556 * menu.c (ensure_menu_items): Likewise.
4557 * minibuf.c (read_minibuf_noninteractive): Likewise.
4558 * print.c (printchar, strout): Likewise.
4559 * process.c (create_process, Faccept_process_output)
4560 (wait_reading_process_output, read_process_output, send_process)
4561 (wait_reading_process_output): Likewise.
4562 * profiler.c (make_log, handle_profiler_signal): Likewise.
4563 * regex.c (re_exec): Likewise.
4564 * regex.h: Likewise.
4565 * search.c (looking_at_1, Freplace_match): Likewise.
4566 * sysdep.c (get_child_status, procfs_ttyname)
4567 (procfs_get_total_memory): Likewise.
4568 * systime.h (EMACS_TIME_VALID_P): Likewise.
4569 * term.c (dissociate_if_controlling_tty): Likewise.
4570 * window.c (get_phys_cursor_glyph): Likewise.
4571 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
4572 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
4573 Likewise.
4574 * xfns.c (Fx_window_property): Likewise.
4575 * xmenu.c (set_frame_menubar): Likewise.
4576 * xselect.c (x_get_window_property, x_handle_dnd_message):
4577 Likewise.
4578 * xsmfns.c (smc_save_yourself_CB): Likewise.
4579 * xterm.c (x_scroll_bar_set_handle): Likewise.
4580
2bf7d27a
DA
45812013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
4582
4583 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
4584 to be optional or nil. Adjust comment and convert it to docstring.
4585 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
4586 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
4587
a9ebfa0b
PE
45882013-03-24 Paul Eggert <eggert@cs.ucla.edu>
4589
4590 Static checking by GCC 4.8-20130319.
4591 * image.c (gif_load): Assume pass < 3 to pacify GCC.
4592 * process.c (Fset_process_datagram_address)
4593 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
4594 * xdisp.c (get_char_face_and_encoding):
4595 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
4596 (get_glyph_face_and_encoding): Prepare face before possibly using it.
4597 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
4598
4f3576ee
KB
45992013-03-24 Ken Brown <kbrown@cornell.edu>
4600
789b5e9a
KB
4601 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
4602 fix compilation on 64-bit Cygwin, where underscores are not
4603 automatically prepended.
4604
4f3576ee
KB
4605 * w32term.c (w32_initialize): Silence compiler warning.
4606
b5b7745f
EZ
46072013-03-23 Eli Zaretskii <eliz@gnu.org>
4608
cdc0d0bd
EZ
4609 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
4610 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
4611 variables, to save and restore frame dimensions.
4612 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
4613 after returning from a 'fullscreen' configuration.
4614 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
4615 to avoid races between the main thread and the input thread.
4616
4617 * w32term.h (struct w32_output): New members normal_width,
4618 normal_height, normal_top, normal_left, and prev_fsmode.
4619 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
4620 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
4621 members of a frame.
4622
b5b7745f
EZ
4623 * w32term.c (w32fullscreen_hook): Record last value of the frame's
4624 'fullscreen' parameter. Always record previous width and height
4625 of the frame, except when switching out of maximized modes, so
4626 that they could be restored correctly, instead of resetting to the
4627 default frame dimensions. Send SC_RESTORE command to the frame,
4628 unless we are going to send SC_MAXIMIZE, to restore the frame
4629 resize hints in the mouse pointer shown by the window manager.
4630 (Bug#14032)
4631
4632 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
4633
4634 * lisp.h (get_frame_param): Adjust conditions for prototype
4635 declaration.
4636
a3454eed
KB
46372013-03-22 Ken Brown <kbrown@cornell.edu>
4638
4639 * unexcw.c: Drop unneeded inclusion of w32common.h.
4640 (report_sheap_usage): Declare.
4641 (read_exe_header): Add magic numbers for x86_64.
4642 (fixup_executable): Fix printf format specifier for unsigned long
4643 argument.
4644
5a49b79c
DA
46452013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
4646
4647 * frame.h (struct frame): Put menu_bar_window under #ifdef
4648 because this member is not needed when X toolkit is in use.
4649 (fset_menu_bar_window):
4650 * dispnew.c (clear_current_matrices, clear_desired_matrices)
4651 (free_glyphs, update_frame):
4652 * xdisp.c (expose_frame): Likewise.
4653 (display_menu_bar): Likewise. Remove redundant eassert.
4654 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
4655 toolkit is in use.
4656
d6723bf7
PE
46572013-03-21 Paul Eggert <eggert@cs.ucla.edu>
4658
7b1123d8
PE
4659 Use functions and constants to manipulate Lisp_Save_Value objects.
4660 This replaces code that used macros and strings and token-pasting.
4661 The change makes the C source a bit easier to follow,
4662 and shrinks the Emacs executable a bit.
4663 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
4664 (make_save_value): Change 1st arg from string to enum. All callers
4665 changed.
4666 (INTX): Remove.
4667 (mark_object): Use if, not #if, for GC_MARK_STACK.
4668 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
4669 (XSAVE_OBJECT): Now functions, not macros.
4670 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
4671 the constant was never used.
4672 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
4673 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
4674 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
4675 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
4676 New constants.
4677 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
4678 type3 with a single member save_type. All uses changed.
4679 (save_type, set_save_pointer, set_save_integer): New functions.
4680 * print.c (PRINTX): Remove.
4681
d6723bf7
PE
4682 * alloc.c: Remove redundant static declarations.
4683
5f24fa51
DA
46842013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4685
4686 * window.h (struct window): Convert left_col, top_line, total_lines
4687 and total_cols from Lisp_Objects to integers. Adjust comments.
4688 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
4689 Remove.
4690 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
4691 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
4692 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
4693 Adjust users where appropriate.
4694
42143acd
DA
46952013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4696
4697 * frame.h (struct frame): Drop resx and resy because the same data is
4698 available from window system-specific output context. Adjust users.
562c6ee9
SM
4699 (default_pixels_per_inch_x, default_pixels_per_inch_y):
4700 New functions to provide defaults when no window system available.
42143acd 4701 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 4702 (NUMVAL): Move from xdisp.c.
42143acd
DA
4703 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
4704 (Ffont_face_attributes, Fopen_font):
4705 * image.c (gs_load):
4706 * w32font.c (fill_in_logfont):
4707 * xdisp.c (calc_pixel_width_or_height):
4708 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
4709 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
4710
c0a17406
KH
47112013-03-20 Kenichi Handa <handa@gnu.org>
4712
4713 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
4714 to 1 (temporary workaround until a bug related to ASCII
4715 optimization is fixed).
4716
095d384d
DA
47172013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
4718
4719 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
4720 Signal error if window is not internal. Adjust docstring.
4721 (delete_all_child_windows): Use combination_limit to save the buffer.
4722 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
4723 * print.c (syms_of_print): Initialize debugging output not here...
4724 (init_print_once): ...but in a new function here.
4725 * lisp.h (init_print_once): Add prototype.
4726 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 4727
748fa866
DA
47282013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
4729
4730 * window.c (window_resize_check, window_resize_apply)
4731 (window_from_coordinates, recombine_windows, set_window_buffer)
4732 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
4733 (Fsplit_window_internal, Fdelete_window_internal)
4734 (freeze_window_starts): Use bool for booleans.
4735 * window.h (window_frame_coordinates, resize_frame_windows)
4736 (freeze_window_starts, set_window_buffer): Adjust prototypes.
4737
81519fd2
SM
47382013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
4739
4740 * dispnew.c (bitch_at_user): Use `user-error'.
4741
6db423a9
KB
47422013-03-17 Ken Brown <kbrown@cornell.edu>
4743
4744 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
4745 as return type of image_background. (Bug#13981)
4746 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
4747
8f2906f5
JD
47482013-03-16 Jan Djärv <jan.h.d@swipnet.se>
4749
960ce480 4750 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 4751 (ns_select): Don't return with result uninitialized.
960ce480 4752
8f2906f5
JD
4753 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
4754 and getDirectory.
4755
81519fd2
SM
4756 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
4757 New functions.
8f2906f5
JD
4758 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
4759 directories. If filename is nil, get directory name (Bug#13932).
4760 Use getFilename and getDirectory.
4761 (getFilename, getDirectory): New methods for EmacsSavePanel and
4762 EmacsOpenPanel.
4763 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
4764
cded56c1
PE
47652013-03-15 Paul Eggert <eggert@cs.ucla.edu>
4766
4767 * coding.c (decode_coding_gap): Fix typo caught by static checking.
4768
251e9147 47692013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
4770
4771 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
4772 (adjust_after_replace): Make it back to static. Delete the third
4773 arg text_at_gap_tail. Cancel the code for handling it.
4774
4775 * coding.h (struct coding_system): New member eol_seen.
4776
4777 * coding.c (detect_ascii): New function.
4778 (detect_coding): Set coding->head_ascii and coding->eol_seen only
4779 when the source bytes are actually scanned. On detecting for
4780 coding_category_utf_8_auto, call detect_ascii instead of scanning
4781 source bytes directly.
4782 (produce_chars): Call insert_from_gap with the new arg 0.
4783 (encode_coding): Likewise.
4784 (decode_coding_gap): Control ASCII optimization by the variable
4785 disable_ascii_optimization instead of #ifndef .. #endif.
4786 Deccode EOL format according to coding->eol_seen.
4787 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
4788 variable.
4789
8a44e6d1
KH
4790 * lisp.h (adjust_after_replace): Cancel externing it.
4791 (insert_from_gap): Adjust prototype.
4792
5f795e34
EZ
47932013-03-15 Eli Zaretskii <eliz@gnu.org>
4794
4795 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
4796 FULLSCREEN_MAXIMIZED. (Bug#13935)
4797
f258b4be
DA
47982013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
4799
4800 * region-cache.c (find_cache_boundary, move_cache_gap)
4801 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
4802 Simplify debugging check and convert to eassert. Adjust comment.
4803 (pp_cache): Put under ENABLE_CHECKING.
4804
a5cc4dde
EZ
48052013-03-14 Eli Zaretskii <eliz@gnu.org>
4806
4807 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
4808 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
4809 and WM_ACTIVATEAPP.
4810 (w32fullscreen_hook): If the frame is visible, reset
4811 f->want_fullscreen flag after changing the frame size. If the
4812 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
4813 (Bug#13953)
4814
3fc5e44a
DC
48152013-03-13 Daniel Colascione <dancol@dancol.org>
4816
4817 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
4818 too so that these builds can use Cygwin's file conversion
4819 functions. (We've been building and linking cygw32.o all along
4820 and just not using it.)
4821
47d7532e
PE
48222013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4823
4824 File synchronization fixes (Bug#13944).
4825 * Makefile.in (LIB_FDATASYNC): New macro.
4826 (LIBES): Use it.
4827 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
4828 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
4829 Don't worry about HAVE_FSYNC, since a substitute fsync is
4830 available if the system lacks one.
4831 (Fwrite_regin): Retry fsync if interrupted.
4832
c7ffccaf
EZ
48332013-03-13 Eli Zaretskii <eliz@gnu.org>
4834
4e2df81d 4835 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
4836 activated, call w32fullscreen_hook, to make sure the new frame
4837 dimensions are in effect. (Bug#13937)
4838
8a7debc1
DA
48392013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
4840
4841 * xdisp.c (init_iterator): Simplify because both character and byte
4842 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
4843 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
4844 character and byte positions can be obtained from marker.
8a7debc1 4845
7fd8c501
PE
48462013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4847
d9df6f40
PE
4848 Static checking by Sun C 5.12.
4849 * alloc.c (buffer_memory_full) [REL_ALLOC]:
4850 * bytecode.c (exec_byte_code):
4851 * dispnew.c (init_display):
4852 * eval.c (error):
4853 * fileio.c (Fsubstitute_in_file_name):
4854 * keyboard.c (Fevent_convert_list):
4855 * keymap.c (Fsingle_key_description):
4856 * term.c (maybe_fatal, fatal):
4857 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
4858 * xsmfns.c (Fhandle_save_session):
4859 Omit unreachable code.
4860 * keymap.c (map_keymap_char_table_item): Cast void * to
4861 a function pointer type; the C Standard requires this.
4862
7fd8c501
PE
4863 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
4864 Include <sys/param.h> unconditionally, as that works elsewhere and
4865 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
4866 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
4867 and FreeBSD now.
4868
a020afb9 4869See ChangeLog.12 for earlier changes.
aac0c6e3
MR
4870
4871;; Local Variables:
4872;; coding: utf-8
aac0c6e3
MR
4873;; End:
4874
ab422c4d 4875 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
4876
4877 This file is part of GNU Emacs.
4878
4879 GNU Emacs is free software: you can redistribute it and/or modify
4880 it under the terms of the GNU General Public License as published by
4881 the Free Software Foundation, either version 3 of the License, or
4882 (at your option) any later version.
4883
4884 GNU Emacs is distributed in the hope that it will be useful,
4885 but WITHOUT ANY WARRANTY; without even the implied warranty of
4886 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4887 GNU General Public License for more details.
4888
4889 You should have received a copy of the GNU General Public License
4890 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.