Fix crash on OSX >= 10.7.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
d2d699ac
JD
12013-08-11 Jan Djärv <jan.h.d@swipnet.se>
2
f90e3ebd
JD
3 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
4 (initWithTitle:): Initialize frame to 0.
5 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
6 (fillWithWidgetValue:frame:): Renamed from
7 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
8
9 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
10 fillWithWidgetValue:frame:
11
423d3b3f
JD
12 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
13 remove memory leak warnings.
14
d2d699ac
JD
15 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
16 (ns_check_menu_open): Handle menu == nil. Remove assignment to
17 menu_pending_title.
18
19 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
20 (x_activate_menubar): Update the whole menu.
21 (trackingNotification:): Call ns_check_menu_open if tracking ends.
22 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
23 current event is not NSSystemDefined (Bug#15001).
24 Call ns_check_menu_open only if trackingMenu is 2.
25 (menuDidClose:): New method, decrease trackingMenu.
26 (fillWithWidgetValue:setDelegate:): New method.
27 (fillWithWidgetValue:): Call the above.
28
29 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
30
7d652d97
PE
312013-08-11 Paul Eggert <eggert@cs.ucla.edu>
32
33 Omit some unnecessary casts.
34 Many of these go back to the old pre-C89 days, when they may have
35 been needed, but we've been assuming C89 or later for a while now.
36 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
37 (live_float_p, live_misc_p, live_vector_p):
38 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
39 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
40 (defvar_per_buffer):
41 * callint.c (Fcall_interactively):
42 * doc.c (Fsubstitute_command_keys):
43 * filelock.c (get_boot_time):
44 * frame.c (xrdb_get_resource):
45 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
46 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
47 (xg_get_file_name_from_selector, menuitem_destroy_callback)
48 (menuitem_highlight_callback, menu_destroy_callback)
49 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
50 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
51 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
52 (xg_tool_bar_help_callback, tb_size_cb):
53 * image.c (xpm_alloc_color, png_read_from_memory)
54 (png_read_from_file, png_load_body, our_memory_skip_input_data)
55 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
56 (syms_of_image):
57 * keymap.c (describe_map):
58 * nsfns.m (Fns_display_monitor_attributes_list):
59 * nsmenu.m (process_dialog:):
60 * nsterm.m (hold_event):
61 * process.c (wait_reading_process_output):
62 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
63 * scroll.c (do_direct_scrolling, scrolling_1):
64 * termcap.c (tgetent):
65 * window.c (check_window_containing, add_window_to_list)
66 (freeze_window_starts):
67 * xdisp.c (compare_overlay_entries, vmessage):
68 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
69 (x_get_monitor_attributes_xrandr)
70 (Fx_display_monitor_attributes_list, x_display_info_for_name)
71 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
72 * xfont.c (xfont_match, xfont_open):
73 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
74 (menubar_selection_callback, menu_position_func)
75 (popup_selection_callback, create_and_show_popup_menu)
76 (dialog_selection_callback, create_and_show_dialog):
77 * xrdb.c (x_get_string_resource):
78 (main) [TESTRM]:
79 * xsmfns.c (x_session_check_input):
80 * xterm.c (x_draw_glyphless_glyph_string_foreground)
81 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
82 (xaw_jump_callback, xaw_scroll_callback):
83 Omit unnecessary casts.
84
9acc1074
PE
852013-08-10 Paul Eggert <eggert@cs.ucla.edu>
86
87 Minor string-length refactoring.
88 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
89 * frame.c (make_monitor_attribute_list):
90 Prefer build_string to strlen + make_string.
91
361c0eb8
JD
922013-08-10 Jan Djärv <jan.h.d@swipnet.se>
93
94 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
95 don't check minor_code (Bug#14417).
96
14ba0822
EZ
972013-08-09 Eli Zaretskii <eliz@gnu.org>
98
99 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
100 vertical positions instead. This avoids calling MATRIX_ROW with
101 row numbers that are possibly beyond valid limits. (Bug#15064)
102
309f24d1
DA
1032013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
104
105 Use xstrdup and build_unibyte_string where applicable.
106 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
107 * xfns.c (x_window):
108 * xrdb.c (x_get_customization_string):
109 * xterm.c (xim_initialize):
110 * w32fns.c (w32_window): Use xstrdup.
111 (w32_display_monitor_attributes_list):
112 * emacs.c (init_cmdargs):
113 * keyboard.c (PUSH_C_STR):
114 * nsfont.m (nsfont_open):
115 * sysdep.c (system_process_attributes):
116 * w32.c (system_process_attributes):
117 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
118
55902276
EZ
1192013-08-09 Eli Zaretskii <eliz@gnu.org>
120
121 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
122 variables of these types so that GDB would know about them, as aid
123 for debugging fatal exceptions. (Bug#15024) See also
124 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
125 discussions.
126
10bf7f5a
JD
1272013-08-08 Jan Djärv <jan.h.d@swipnet.se>
128
129 * nsterm.m (ns_update_begin): Don't change clip path if it would be
130 larger than the NSWindow (Bug#14934).
131
65620264
DA
1322013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
133
134 Redesign redisplay interface to drop global variable updated_window.
135 Always pass currently updated window as a parameter to update routines.
136 * dispextern.h (updated_window): Remove declaration.
137 (struct redisplay_interface): Pass window parameter to
138 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
139 and after_update_window_hook.
140 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
141 Adjust prototypes.
142 * dispnew.c (updated_window): Remove.
143 (redraw_overlapped_rows, update_marginal_area, update_text_area)
144 (update_window_line): Adjust to match redisplay interface changes.
145 * nsterm.m (ns_update_window_begin, ns_update_window_end)
146 (ns_scroll_run, ns_after_update_window_line):
147 * w32term.c (x_update_window_begin, x_update_window_end)
148 (x_after_update_window_line, x_scroll_run):
149 * xterm.c (x_update_window_begin, x_update_window_end)
150 (x_after_update_window_line, x_scroll_run):
151 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
152 Likewise. Adjust comments where appropriate.
153 (x_cursor_to): Simplify because this is always called during window
154 update (but install debugging check anyway).
155 (expose_window): Check must_be_updated_p flag to see whether this
156 function is called during window update.
157
628fdc56
DA
1582013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
159
160 Do not reset window modification event counters excessively.
161 These leftovers and poor man's tricky methods to catch extra
162 redisplay's attention are no longer needed.
163 * frame.c (set_menu_bar_lines_1):
164 * minibuf.c (read_minibuf_unwind):
165 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
166 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
167 (window_scroll_line_based, Fset_window_configuration):
168 * xdisp.c (redisplay_window): Do not reset last_modified and
169 last_overlay_modified counters.
170
8fd9c92e
JD
1712013-08-07 Jan Djärv <jan.h.d@swipnet.se>
172
173 * xselect.c (x_send_client_event): Set send_event and serial, memset
174 data.l as it might be bigger than data.b. Use 24 bit mask to
175 XSendEvent (Bug#15034).
176
0ee18172
EZ
1772013-08-07 Eli Zaretskii <eliz@gnu.org>
178
179 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
180 for TTY frames that are not the top frame on their console.
181 (Bug#14616)
182
16ddd1a6
MR
1832013-08-07 Martin Rudalics <rudalics@gmx.at>
184
185 * w32term.c (w32fullscreen_hook): Really maximize frame when
186 asked for (Bug#14841).
187
d2a95ffb
DA
1882013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
189
190 Prefer selected_window to Fselected_window, likewise for frames.
191 * buffer.c (Fbuffer_swap_text):
192 * data.c (Fvariable_binding_locus):
193 * window.c (run_window_configuration_change_hook): Adjust users.
194 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
195 Use decode_live_frame.
196
170da1ec
DA
1972013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
198
199 Be more careful if selected window shows the buffer other than current,
200 use window_outdated only if this is not so. This change should also
201 address some weird issues discussed in Bug#13012.
202 * window.h (window_outdated): New prototype.
203 * window.c (window_outdated): Now here. Convert from static and
204 always assume window's buffer.
205 (Fwindow_end, Fwindow_line_height): Use it.
206 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
207 and always assume window's buffer.
208 (redisplay_window): Adjust user.
e5eefe9b 209 (redisplay_internal): Call to reconsider_clip_changes once and
170da1ec
DA
210 check whether mode line should be updated only if selected window
211 shows current buffer.
212 (run_window_scroll_functions): Use eassert for debugging check.
213 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
214
56b5d5b1
DA
2152013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
216
217 * window.c (window_scroll, window_scroll_pixel_based)
218 (window_scroll_line_based): Use bool for booleans.
219
2878ba7e
PE
2202013-08-06 Paul Eggert <eggert@cs.ucla.edu>
221
222 * process.c: Fix minor off-by-one issues in descriptor counts.
223 This shouldn't fix any real bugs, but it cleans up the code a bit.
224 (max_process_desc, max_input_desc): -1, not 0, means none.
225 All uses changed.
226 (delete_input_desc): New function.
227 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
228 (deactivate_process): Scan backwards when recomuting max_process_desc;
229 that should be faster.
230 (init_process_emacs): Initialize max_input_desc.
231
e30b79c1
DA
2322013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
233
234 Use region cache to speedup bidi_find_paragraph_start.
235 * buffer.h (struct buffer): New member bidi_paragraph_cache.
236 Rename cache_long_line_scans to cache_long_scans.
237 * buffer.c (bset_cache_long_line_scans): Rename to
238 bset_cache_long_scans.
239 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
240 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
241 into account.
242 (syms_of_buffer): Rename cache-long-line-scans to
243 cache-long-scans. Adjust docstring.
244 * search.c (newline_cache_on_off):
245 * indent.c (width_run_cache_on_off): Adjust users.
246 * bidi.c (bidi_paragraph_cache_on_off): New function.
247 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
248 * insdel.c (prepare_to_modify_buffer): Invalidate
249 bidi_paragraph_cache if enabled.
250
00012b86
DA
2512013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
252
253 Invalidate region caches only if buffer text is going to be changed.
254 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
255 (modify_text): ...new prototype.
256 (prepare_to_modify_buffer_1): New prototype.
257 * textprop.c (modify_region): Rename to...
258 (modify_text_properties): ...new function.
259 (add_text_properties_1, set_text_properties, Fremove_text_properties)
260 (Fremove_list_of_text_properties): Adjust users.
261 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
262 (modify_text): ...new function.
263 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
264 (prepare_to_modify_buffer_1): ...new function.
265 * casefiddle.c (casify_region):
266 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
267 (Ftranspose_regions): Use modify_text.
268
dc6c0eda
SM
2692013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
270
271 * lisp.mk (lisp): Add nadvice.elc.
272
8f3a2c26
DA
2732013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
274
275 New macro to iterate over live buffers similar to frames.
276 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
277 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
278 Declare buffer-related variables here to offload lisp.h.
279 * buffer.c (Vbuffer_alist): Adjust comment.
280 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
281 (other_buffer_safely):
282 * data.c (store_symval_forwarding):
283 * dispnew.c (Fframe_or_buffer_changed_p):
284 * fileio.c (Fdo_auto_save):
285 * filelock.c (unlock_all_files):
286 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
287
e0fdb694
PE
2882013-08-04 Paul Eggert <eggert@cs.ucla.edu>
289
290 Fix some minor races in hosts lacking mkostemp (Bug#15015).
291 * callproc.c (create_temp_file):
292 * filelock.c (create_lock_file):
293 Assume mkostemp, since it's now provided by Gnulib.
294
63f5c6c2
EZ
2952013-08-04 Eli Zaretskii <eliz@gnu.org>
296
297 * w32.c (mkostemp): New function.
298 (mktemp): Remove, no longer used. Most of the code reused in
299 mkostemp. (Bug#15015)
484ab239 300 (mktemp): Don't undef.
63f5c6c2 301
f0b79313
DA
3022013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
303
304 * dispnew.c (glyph_matrix_count, glyph_pool_count):
305 Move under GLYPH_DEBUG and ENABLE_CHECKING.
306 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
307 (free_glyph_pool, check_glyph_memory): Likewise for
308 all users. Adjust comments where appropriate.
309
98f638d6
PE
3102013-08-03 Paul Eggert <eggert@cs.ucla.edu>
311
312 * composite.h: Minor fixups.
313 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
314 to fix a misspelling, and change it to an inline function while
315 we're at it (it need not be a macro). All uses changed.
316 (composition_method, composition_valid_p):
317 Rewrite to avoid assignments in if-conditions.
318
75c59fb3
DA
3192013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
320
321 Do not use global Lisp_Object in composition macros.
322 * composite.h (composition_temp): Remove declaration.
323 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
324 (composition_method, composition_valid_p): ...inline functions.
416a3e01 325 (compose_region): Remove the leftover.
75c59fb3
DA
326 * composite.c (composition_temp): Remove.
327 (run_composition_function, update_compositions)
328 (composition_compute_stop_pos, composition_adjust_point)
329 (Ffind_composition_internal):
330 * coding.c (handle_composition_annotation):
331 * xdisp.c (handle_composition_prop, check_point_in_composition):
332 Related users changed.
333
a10c8269
DA
3342013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
335
336 Drop FRAME_PTR typedef.
337 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
338 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
339 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
340 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
341 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
342 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
343 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
344 All related users changed.
345
a104f656
SM
3462013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
347
348 * eval.c (default_toplevel_binding): New function.
349 (Fdefvar): Use it.
350 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
351 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
352 (syms_of_eval): Export them.
353 * data.c (Fdefault_value): Micro cleanup.
354 * term.c (init_tty): Use "false".
355
4b5c9326
DA
3562013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
357
358 Fix X GC leak in GTK and raw (no toolkit) X ports.
359 * xterm.c (x_free_frame_resources): If white and black relief
360 GCs are allocated, always free them here.
361 * xfns.c (x_make_gc): Omit redundant initialization.
362 * widget.c (create_frame_gcs): Remove the leftover.
363 (EmacsFrameDestroy): Do nothing because all GCs are now freed
364 in x_free_frame_resources.
365
b19aa636
JD
3662013-08-02 Jan Djärv <jan.h.d@swipnet.se>
367
368 * nsterm.m (windowWillResize:toSize:): Only change title if
369 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
370 modifying it.
371 (viewDidEndLiveResize): New method.
372
373 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
374 inside NS_IMPL_COCOA.
375
af1f7e06
DA
3762013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
377
378 * insdel.c (adjust_after_replace, replace_range, del_range_2):
379 Do not check whether undo is enabled because record_insert and
380 record_delete does that themselves.
381
65b02bb9
DA
3822013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
383
384 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
385 member which is not really used any more.
386 (FRAME_XIC_BASE_FONTNAME): Remove.
387 * xfns.c (xic_free_fontset): Adjust user.
388 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
389 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
390 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
391 (xdialog_show): Use eassert for debugging check.
7ee0f047 392 * w32term.c (x_unfocus_frame): Remove unused dummy function.
65b02bb9 393
6318cde0
PE
3942013-08-01 Paul Eggert <eggert@cs.ucla.edu>
395
396 * fileio.c, fns.c (merge): Move extern decl from here ...
397 * lisp.h (merge): ... to here.
398
6c1a09ba
DA
3992013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
400
401 Fix last font-related change.
402 * w32font.h (w32font_list_internal, w32font_match_internal):
403 Fix prototype.
404 * w32uniscribe.c (uniscribe_list, uniscribe_match):
405 (uniscribe_list_family): Adjust to match font API change.
406 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
407 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
408
f8c20208
DA
4092013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
410
411 * frame.h (FRAME_MOUSE_UPDATE):
412 * nsterm.m (ns_frame_up_to_date): Omit redundant check
413 whether hlinfo->mouse_face_mouse_frame is non-NULL.
414
fdb396e2
DA
4152013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
416
417 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
418 * font.h (struct font_driver): Change list, match, and list_family
419 functions to accept struct frame * as first arg.
420 * font.c (font_score, font_compare, font_sort_entities): Remove
421 prototypes.
422 (font_sort_entities, font_list_entities, font_select_entity):
423 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
424 match font API change.
425 * xfont.c (xfont_list, xfont_match, xfont_list_family):
426 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
427 * ftxfont.c (ftxfont_list, ftxfont_match):
428 * xftfont.c (xftfont_list, xftfont_match):
429 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
430 * w32font.c (w32font_list, w32font_match, w32font_list):
431 (w32font_list_internal, w32_font_match_internal): Likewise.
432 * xfaces.c (Fx_family_fonts): Adjust user.
433
52b8a085
DA
4342013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
435
436 Do not use pure Xism x_wm_set_icon_position in non-X ports.
437 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
438 only if HAVE_X_WINDOWS is in use.
439 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
440 * nsterm.m (x_wm_set_icon_position): Remove no-op.
441 * w32term.c (x_wm_set_icon_position): Likewise.
442 * w32fns.c (x_icon): Adjust user.
443
c791c18e
DA
4442013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
445
446 * xterm.c (last_mouse_press_frame): Remove the
447 leftover which is not really used any more.
448 (handle_one_xevent, syms_of_xterm): Adjust users.
1ca6cc28
DA
449 (x_flush): Call XFlush once per each X display, not frame.
450 This is better because this code always unconditionally skips
451 non-X frames in Vframe_list and issues the only XFlush if we
452 have more than one X frame on the same X display.
2f935d86
DA
453 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
454 Use bool for booleans.
455 (x_draw_glyph_string_background, cvt_string_to_pixel):
456 (cvt_pixel_dtor): Drop unnecessary prototypes.
457 * xterm.h (x_display_ok): Adjust prototype.
c791c18e 458
f435830e
DA
4592013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
460
461 Drop unnecessary functions that deals with frame pixel size.
462 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
463 (x_pixel_height): Drop prototypes.
464 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
465 (x_pixel_height): Drop implementations.
466 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
467 which should be always valid for window frame.
468 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
469 * w32menu.c (Fx_popup_dialog):
470 * xmenu.c (Fx_popup_dialog): Likewise for both.
471
84231434
DA
4722013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
473
474 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
475 frame parameters and call to Fmodify_frame_parameters just once.
4c131798
DA
476 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
477 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
478 and mention nil frame in docstring.
84231434 479
959067a1
DA
4802013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
481
482 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
483 (x_figure_window_size): Likewise. Adjust to return long.
484 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
485 (toplevel): Move Qterminal_live_p to...
486 * terminal.c (toplevel): ...here, make it static, and...
487 (syms_of_terminal): ...DEFSYM here.
488 * frame.h (Qterminal_live_p): Remove declaration.
489 (make_frame, x_figure_window_size): Adjust prototype.
490 * nsfns.m (Fx_create_frame): Use long for window flags.
491
f4b169ce
PE
4922013-07-30 Paul Eggert <eggert@cs.ucla.edu>
493
494 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
495 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
496 Do not assume that emacs_close (INT_MAX) is a no-op.
497
bee6a2c7
DA
4982013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
499
500 * xfaces.c (make_face_cache): For struct face_cache, prefer
501 xmalloc to xzalloc and so avoid redundant call to memset.
502 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
503
d7e6881a
DA
5042013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
505
506 * fringe.c (draw_window_fringes, update_window_fringes)
507 (compute_fringe_widths):
508 * w32term.c (x_draw_glyph_string):
509 * window.c (candidate_window_p, Frecenter):
510 * xfaces.c (realize_basic_faces, realize_default_face)
511 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
512 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
513 * xfns.c (x_set_cursor_color, xic_free_xfontset):
514 * xmenu.c (Fx_menu_bar_open_internal):
515 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
516 * xsettings.c (xft_settings_event):
517 * xterm.c (x_draw_glyph_string, x_had_errors_p):
518 Use bool for booleans. Adjust style and comments where
519 appropriate.
520 * dispextern.h (draw_window_fringes, update_window_fringes)
521 (compute_fringe_widths):
522 * xterm.h (x_had_errors_p): Adjust prototype.
523
ec3058af
DA
5242013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
525
526 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
527 CHECK_LIST. Rewrite the loop to avoid useless local variable.
528
218e0637
DA
5292013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
530
531 * fns.c (toplevel): Remove comment before Fsafe_length because
532 it checks for QUIT.
533
e560aba9
PE
5342013-07-28 Paul Eggert <eggert@cs.ucla.edu>
535
536 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
537
2e5ce5de
EZ
5382013-07-28 Eli Zaretskii <eliz@gnu.org>
539
540 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
541 frame which got the message is still alive, before dereferencing
542 its pointer. (Bug#14970)
543
544 * frame.c (delete_frame): Test "this" frame's minibuffer window to
545 be a live window, before using it as such. (Bug#14970)
546
e95da6d3
EZ
5472013-07-27 Eli Zaretskii <eliz@gnu.org>
548
549 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
550 w32_detect_focus_change instead of doing part of its job by hand.
551 This fixes the problem whereby FOCUS_OUT events were not sent to
552 the event queue.
553
a8f93651
EZ
5542013-07-26 Eli Zaretskii <eliz@gnu.org>
555
fec92060
EZ
556 * process.c (Fprocess_list): Doc fix.
557
a8f93651
EZ
558 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
559 being re-exposed only if it didn't ask to become visible.
560 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
561 was previously iconified. (Bug#14841)
562 (x_iconify_frame): Mark the frame iconified.
563
d5a7a9d9
PE
5642013-07-26 Paul Eggert <eggert@cs.ucla.edu>
565
566 Fix minor problems found by static checking.
567 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
568 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
569
56ea7291
SM
5702013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
571
572 * eval.c (set_specpdl_old_value): New function.
573 (unbind_to): Minor simplification.
574 (get_backtrace_frame): New function.
575 (Fbacktrace_frame): Use it. Add `base' argument.
576 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
577 (syms_of_eval): Export backtrace-eval.
578 * xterm.c (x_focus_changed): Simplify.
579
9d611ffe
PE
5802013-07-25 Paul Eggert <eggert@cs.ucla.edu>
581
582 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
583
999c74e3
EZ
5842013-07-24 Eli Zaretskii <eliz@gnu.org>
585
586 * xdisp.c (redisplay_window): Instead of moving point out of
587 scroll margin, reject the force_start method, and try scrolling
588 instead. (Bug#14780)
589
198fa217
KB
5902013-07-24 Ken Brown <kbrown@cornell.edu>
591
592 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
593 (Bug#14944).
594
53840e55
PE
5952013-07-24 Paul Eggert <eggert@cs.ucla.edu>
596
597 * eval.c (Fprogn): Do not check that BODY is a proper list.
598 This undoes the previous change. The check slows down the
599 interpreter, and is not needed to prevent a crash. See
600 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
601
60967f56
GM
6022013-07-23 Glenn Morris <rgm@gnu.org>
603
604 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
605
9ca960e2
PE
6062013-07-23 Paul Eggert <eggert@cs.ucla.edu>
607
a29c3e6d
PE
608 Port to GNU/Linux systems with tinfo but not ncurses.
609 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
610 to decide whether ncurses is being used. Without this change,
611 GCC complains about tgetent not being declared, on a system
612 that has tinfo installed but ncurses not installed.
613
f274311c
PE
614 * eval.c (Fprogn): Check that BODY is a proper list.
615
16b0520a
PE
616 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
617 * data.c (Fsetq_default):
618 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
619 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
620 (Fcondition_case):
621 Tune by taking advantage of the fact that ARGS is always a list
622 when a function is declared to have UNEVALLED args.
623
9ca960e2
PE
624 * emacsgtkfixed.c: Port to GCC 4.6.
625 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
626
afacaa1b
JB
6272013-07-23 Juanma Barranquero <lekktu@gmail.com>
628
629 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
630 here to silence compiler warnings.
631
368a85a4
PE
6322013-07-22 Paul Eggert <eggert@cs.ucla.edu>
633
634 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
635 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
636 from messing up Emacs's 'struct frame' (Bug#14923).
637
f4e891b5
PE
6382013-07-21 Paul Eggert <eggert@cs.ucla.edu>
639
640 * alloc.c (make_save_ptr_ptr): Define this function.
641 It was inadvertently omitted. It's needed only if
642 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
643
96c8b65e
JD
6442013-07-21 Jan Djärv <jan.h.d@swipnet.se>
645
646 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
647 frame have focus (Bug#14895).
648
ee010797
PE
6492013-07-21 Paul Eggert <eggert@cs.ucla.edu>
650
651 Avoid vfork-related deadlock more cleanly.
652 * callproc.c (child_setup): When the child's exec fails, output
653 the program name, as that's more useful. Use O_NONBLOCK to avoid
654 deadlock.
655 * process.c (create_process_1): Remove; no longer needed.
656 (create_process): Remove timer hack; no longer needed, now that
657 the child avoids deadlock.
658
f0398ec1 6592013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
660
661 * image.c (Fimage_flush): Fix doc typo.
662
b2a069c2
PE
6632013-07-20 Paul Eggert <eggert@cs.ucla.edu>
664
6496aec9
PE
665 Fix array bounds violation when pty allocation fails.
666 * process.c (PTY_NAME_SIZE): New constant.
667 (pty_name): Remove static variable; it's now auto.
668 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
669 Take pty_name as an arg rather than using a static variable.
670 All callers changed.
671 (create_process): Recover pty_flag from process, not from volatile local.
672 (create_pty): Stay inside array even when pty allocation fails.
673 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
674
b2a069c2
PE
675 * lread.c (Fload): Avoid initialization only when lint checking.
676 Mention that it's needed only for older GCCs.
677
99107004
KH
6782013-07-20 Kenichi Handa <handa@gnu.org>
679
680 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
681 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
682
6b1b199d
AS
6832013-07-20 Andreas Schwab <schwab@linux-m68k.org>
684
685 * lread.c (Fload): Avoid uninitialized warning.
686
4195afc3
PE
6872013-07-19 Paul Eggert <eggert@cs.ucla.edu>
688
3f5bef16
PE
689 Fix some minor file descriptor leaks and related glitches.
690 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
691 (create_lock_file): Use write, not emacs_write.
692 * image.c (slurp_file, png_load_body):
693 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
694 (server_accept_connection):
695 Don't leak an fd on memory allocation failure.
696 * image.c (slurp_file): Add a cheap heuristic for growing files.
697 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
698 as that's what the other routines do. Maybe input need not be
699 blocked at all, but it's better to be consistent.
700 Avoid undefined behavior when strlen is zero.
701
4195afc3
PE
702 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
703 (NSTATICS): Now a constant; doesn't need to be a macro.
704
a1aeeffe
RS
7052013-07-19 Richard Stallman <rms@gnu.org>
706
707 * coding.c (decode_coding_utf_8): Add simple loop for fast
708 processing of ASCII characters.
709
63b34baa
PE
7102013-07-19 Paul Eggert <eggert@cs.ucla.edu>
711
712 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
713
621dd9ac
EZ
7142013-07-19 Eli Zaretskii <eliz@gnu.org>
715
716 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
717 unportable 'struct x_display_info'.
718 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
719 is a portable type.
720
1396ac86
PE
7212013-07-19 Paul Eggert <eggert@cs.ucla.edu>
722
ab9980cd
PE
723 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
724 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
725 or fscanf fails.
726 (system_process_attributes): Prefer plain char to unsigned char
727 when either will do. Clean up properly if interrupted or if
728 memory allocations fail. Don't assume sscanf succeeds. Remove
729 no-longer-needed workaround to stop GCC from whining. Read
730 command-line once, instead of multiple times. Check read status a
731 bit more carefully.
732
1396ac86
PE
733 Fix obscure porting bug with varargs functions.
734 The code assumed that int is treated like ptrdiff_t in a vararg
735 function, which is not a portable assumption. There was a similar
736 -- though these days less likely -- porting problem with various
737 assumptions that pointers of different types all smell the same as
738 far as vararg functions is conserved. To make this problem less
739 likely in the future, redo the API to use varargs functions.
740 * alloc.c (make_save_value): Remove this vararg function.
741 All uses changed to ...
742 (make_save_int_int_int, make_save_obj_obj_obj_obj)
743 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
744 New functions.
745 (make_save_ptr): Rename from make_save_pointer, for consistency with
746 the above. Define only on platforms that need it. All uses changed.
747
4d19d194
PE
7482013-07-18 Paul Eggert <eggert@cs.ucla.edu>
749
750 * keyboard.c: Try to fix typos in previous change.
751 (DISPLAY_LIST_INFO): New macro.
752 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 753 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 754
945c5bb1
JB
7552013-07-18 Juanma Barranquero <lekktu@gmail.com>
756
757 * keyboard.c (kbd_buffer_get_event):
758 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
759 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
760
f4b1eb36
PE
7612013-07-18 Paul Eggert <eggert@cs.ucla.edu>
762
5e679a2c
PE
763 * filelock.c: Fix unlikely file descriptor leaks.
764 (get_boot_time_1): Rework to avoid using emacs_open.
765 This doesn't actually fix a leak, but is better anyway.
766 (read_lock_data): Use read, not emacs_read.
767
a8cd4836
PE
768 * doc.c: Fix minor memory and file descriptor leaks.
769 * doc.c (get_doc_string): Fix memory leak when doc file absent.
770 (get_doc_string, Fsnarf_documentation):
771 Fix file descriptor leak on error.
772
ef30e638
PE
773 * term.c: Fix minor fdopen-related file descriptor leaks.
774 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
775 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
776
f4b1eb36
PE
777 * charset.c: Fix file descriptor leaks and errno issues.
778 Include <errno.h>.
779 (load_charset_map_from_file): Don't leak file descriptor on error.
780 Use plain record_xmalloc since the allocation is larger than
781 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
782 of entries.
783 * eval.c (record_unwind_protect_nothing):
784 * fileio.c (fclose_unwind):
785 New functions.
786 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
787 The replacement doesn't block input, but that no longer seems
788 necessary.
789
b648c163
PE
7902013-07-17 Paul Eggert <eggert@cs.ucla.edu>
791
a0931322
PE
792 * lread.c: Fix file descriptor leaks and errno issues.
793 (Fload): Close some races that leaked fds or streams when 'load'
794 was interrupted.
795 (Fload, openp): Report error number of last nontrivial failure to open.
796 ENOENT counts as trivial.
797 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
798 New functions.
799 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
800 now that the function is always called with a nonnegative arg.
801 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
802 All uses replaced with ...
803 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
804
b648c163
PE
805 A few more minor file errno-reporting bugs.
806 * callproc.c (Fcall_process):
807 * doc.c (Fsnarf_documentation):
808 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
809 * process.c (set_socket_option):
810 Don't let a constructor trash errno.
811 * doc.c: Include <errno.h>.
812
b1dc4084
JB
8132013-07-16 Juanma Barranquero <lekktu@gmail.com>
814
815 * w32fns.c (unwind_create_tip_frame): Fix declaration.
816
c43843aa
PE
8172013-07-16 Paul Eggert <eggert@cs.ucla.edu>
818
50a30cce
PE
819 Fix w32 bug with call-process-region (Bug#14885).
820 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
821 to Fcall_process when the input is empty. This simplifies the
822 code a bit. It makes no difference on POSIXish platforms but
823 apparently it fixes a bug on w32.
824
44e18199 825 Fix bug where insert-file-contents closes a file twice (Bug#14839).
41d48a42
PE
826 * fileio.c (close_file_unwind): Don't close if FD is negative;
827 this can happen when unwinding a zapped file descriptor.
828 (Finsert_file_contents): Unwind-protect the fd before the point marker,
829 in case Emacs runs out of memory between the two unwind-protects.
830 Don't trash errno when closing FD.
831 Zap the FD in the specpdl when closing it, instead of deferring
832 the removal of the unwind-protect; this fixes a bug where a child
833 function unwinds the stack past us.
834
27e498e6
PE
835 New unwind-protect flavors to better type-check C callbacks.
836 This also lessens the need to write wrappers for callbacks,
837 and the need for make_save_pointer.
838 * alloca.c (free_save_value):
839 * atimer.c (run_all_atimers):
840 Now extern.
841 * alloc.c (safe_alloca_unwind):
842 * atimer.c (unwind_stop_other_atimers):
843 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
844 * menu.c (cleanup_popup_menu) [HAVE_NS]:
845 * minibuf.c (choose_minibuf_frame_1):
846 * process.c (make_serial_process_unwind):
847 * xdisp.h (pop_message_unwind):
848 * xselect.c (queue_selection_requests_unwind):
849 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
850 * alloca.c (record_xmalloc):
851 Prefer record_unwind_protect_ptr to record_unwind_protect with
852 make_save_pointer.
853 * alloca.c (Fgarbage_collect):
854 Prefer record_unwind_protect_void to passing a dummy.
855 * buffer.c (restore_buffer):
856 * window.c (restore_window_configuration):
857 * xfns.c, w32fns.c (do_unwind_create_frame)
858 New wrapper. All record-unwind uses of wrappee changed.
859 * buffer.c (set_buffer_if_live):
860 * callproc.c (call_process_cleanup, delete_temp_file):
861 * coding.c (code_conversion_restore):
862 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
863 * editfns.c (save_excursion_restore)
864 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
865 (save_restriction_restore):
866 * eval.c (restore_stack_limits, un_autoload):
867 * fns.c (require_unwind):
868 * keyboard.c (recursive_edit_unwind, tracking_off):
869 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
870 * macros.c (pop_kbd_macro, restore_menu_items):
871 * nsfns.m (unwind_create_frame):
872 * print.c (print_unwind):
873 * process.c (start_process_unwind):
874 * search.c (unwind_set_match_data):
875 * window.c (select_window_norecord, select_frame_norecord):
876 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
877 (fast_set_selected_frame):
878 * xfns.c, w32fns.c (unwind_create_tip_frame):
879 Return void, not a dummy Lisp_Object. All uses changed.
880 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
881 * callproc.c (call_process_kill):
882 * fileio.c (restore_point_unwind, decide_coding_unwind)
883 (build_annotations_unwind):
884 * insdel.c (Fcombine_after_change_execute_1):
885 * keyboard.c (read_char_help_form_unwind):
886 * menu.c (unuse_menu_items):
887 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
888 * sound.c (sound_cleanup):
889 * xdisp.c (unwind_redisplay):
890 * xfns.c (clean_up_dialog):
891 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
892 Accept no args and return void, instead of accepting and returning
893 a dummy Lisp_Object. All uses changed.
894 * cygw32.c (fchdir_unwind):
895 * fileio.c (close_file_unwind):
896 * keyboard.c (restore_kboard_configuration):
897 * lread.c (readevalllop_1):
898 * process.c (wait_reading_process_output_unwind):
899 Accept int and return void, rather than accepting an Emacs integer
900 and returning a dummy object. In some cases this fixes an
901 unlikely bug when the corresponding int is outside Emacs integer
902 range. All uses changed.
903 * dired.c (directory_files_internal_unwind):
904 * fileio.c (do_auto_save_unwind):
905 * gtkutil.c (pop_down_dialog):
906 * insdel.c (reset_var_on_error):
907 * lread.c (load_unwind):
908 * xfns.c (clean_up_file_dialog):
909 * xmenu.c, nsmenu.m (pop_down_menu):
910 * xmenu.c (cleanup_widget_value_tree):
911 * xselect.c (wait_for_property_change_unwind):
912 Accept pointer and return void, rather than accepting an Emacs
913 save value encapsulating the pointer and returning a dummy object.
914 All uses changed.
915 * editfns.c (Fformat): Update the saved pointer directly via
916 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
917 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
918 (unwind_body): New function.
919 (record_unwind_protect): First arg is now a function returning void,
920 not a dummy Lisp_Object.
921 (record_unwind_protect_ptr, record_unwind_protect_int)
922 (record_unwind_protect_void): New functions.
923 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
924 * fileio.c (struct auto_save_unwind): New type.
925 (do_auto_save_unwind): Use it.
926 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
927 * insdel.c (struct rvoe_arg): New type.
928 (reset_var_on_error): Use it.
929 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
930 New constants.
931 (specbinding_func): Remove; there are now several such functions.
932 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
933 (set_unwind_protect_ptr): New function.
934 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
935
4e604a5d
PE
936 Be simpler and more consistent about reporting I/O errors.
937 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
938 Say "Read error" and "Write error", rather than "I/O error", or
939 "IO error reading", or "IO error writing", when a read or write
940 error occurs.
941 * process.c (Fmake_network_process, wait_reading_process_output)
942 (send_process, Fprocess_send_eof, wait_reading_process_output):
943 Capitalize diagnostics consistently. Put "failed foo" at the
944 start of the diagnostic, so that we don't capitalize the
945 function name "foo". Consistently say "failed" for such
946 diagnostics.
947 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
948 All callers changed. This is so it can use report_file_error.
949 * sysdep.c (serial_open, serial_configure): Capitalize I/O
950 diagnostics consistently as above.
951
a9757f6a
PE
952 * fileio.c (report_file_errno): Fix errno reporting bug.
953 If the file name is neither null nor a pair, package it up as a
954 singleton list. All callers changed, both to this function and to
955 report_file_error. This fixes a bug where the memory allocator
956 invoked by list1 set errno so that the immediately following
957 report_file_error reported the wrong errno value.
958
c43843aa
PE
959 Fix minor problems found by --enable-gcc-warnings.
960 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
961 * keyboard.c (kbd_buffer_get_event): Remove unused local.
962
18c26d81
JD
9632013-07-16 Jan Djärv <jan.h.d@swipnet.se>
964
965 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
966 Set event->arg to Qt if switch-event shall be generated.
967 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
968
969 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
970
971 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
972 FOCUS_OUT_EVENT.
973
974 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
975 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
976 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
977 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
44e18199 978 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
18c26d81
JD
979 and there is a focused frame.
980 (head_table): Add focus-in and focus-out.
981 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
982 bind to handle-focus-in/out.
983
984 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
985 (Fhandle_switch_frame): Call Fhandle_focus_in.
986 (syms_of_frame): defsubr handle-focus-in/out.
987
6c6f1994
PE
9882013-07-16 Paul Eggert <eggert@cs.ucla.edu>
989
c7ddc792
PE
990 Fix porting bug to older POSIXish platforms (Bug#14862).
991 * sysdep.c (emacs_pipe): New function, that implements
992 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
993 This should port better to CentOS 5 and to Mac OS X 10.6.
994 All calls to pipe2 changed.
995
6c6f1994
PE
996 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
997 This makes the code easier to read and the executable a bit smaller.
998 Do not replace all calls to Fcons that happen to create lists,
999 just calls that are intended to create lists. For example, when
1000 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
1001 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
1002 Similarly for list2 through list5.
1003 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1004 * bytecode.c (exec_byte_code):
1005 * callint.c (quotify_arg, Fcall_interactively):
1006 * callproc.c (Fcall_process, create_temp_file):
1007 * charset.c (load_charset_map_from_file)
1008 (Fdefine_charset_internal, init_charset):
1009 * coding.c (get_translation_table, detect_coding_system)
1010 (Fcheck_coding_systems_region)
1011 (Fset_terminal_coding_system_internal)
1012 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
1013 * composite.c (update_compositions, Ffind_composition_internal):
1014 * dired.c (directory_files_internal, file_name_completion)
1015 (Fsystem_users):
1016 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
1017 * doc.c (Fsnarf_documentation):
1018 * editfns.c (Fmessage_box):
1019 * emacs.c (main):
1020 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
1021 (Feval, eval_sub, Ffuncall, apply_lambda):
1022 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
1023 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
1024 (Fset_file_times, Finsert_file_contents)
1025 (Fchoose_write_coding_system, Fwrite_region):
1026 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
1027 * font.c (font_registry_charsets, font_parse_fcname)
1028 (font_prepare_cache, font_update_drivers, Flist_fonts):
1029 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
1030 * frame.c (make_frame, Fmake_terminal_frame)
1031 (x_set_frame_parameters, x_report_frame_params)
1032 (x_default_parameter, Fx_parse_geometry):
1033 * ftfont.c (syms_of_ftfont):
1034 * image.c (gif_load):
1035 * keyboard.c (command_loop_1):
1036 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
1037 (Fcopy_keymap, append_key, Fcurrent_active_maps)
1038 (Fminor_mode_key_binding, accessible_keymaps_1)
1039 (Faccessible_keymaps, Fwhere_is_internal):
1040 * lread.c (read_emacs_mule_char):
1041 * menu.c (find_and_return_menu_selection):
1042 * minibuf.c (get_minibuffer):
1043 * nsfns.m (Fns_perform_service):
1044 * nsfont.m (ns_script_to_charset):
1045 * nsmenu.m (ns_popup_dialog):
1046 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
1047 (Fx_own_selection_internal):
1048 * nsterm.m (append2):
1049 * print.c (Fredirect_debugging_output)
1050 (print_prune_string_charset):
1051 * process.c (Fdelete_process, Fprocess_contact)
1052 (Fformat_network_address, set_socket_option)
1053 (read_and_dispose_of_process_output, write_queue_push)
1054 (send_process, exec_sentinel):
1055 * sound.c (Fplay_sound_internal):
1056 * textprop.c (validate_plist, add_properties)
1057 (Fput_text_property, Fadd_face_text_property)
1058 (copy_text_properties, text_property_list, syms_of_textprop):
1059 * unexaix.c (report_error):
1060 * unexcoff.c (report_error):
1061 * unexsol.c (unexec):
1062 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
1063 (Fformat_mode_line, syms_of_xdisp):
1064 * xfaces.c (set_font_frame_param)
1065 (Finternal_lisp_face_attribute_values)
1066 (Finternal_merge_in_global_face, syms_of_xfaces):
1067 * xfns.c (x_default_scroll_bar_color_parameter)
1068 (x_default_font_parameter, x_create_tip_frame):
1069 * xfont.c (xfont_supported_scripts):
1070 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
1071 (menu_help_callback, xmenu_show):
1072 * xml.c (make_dom):
1073 * xterm.c (set_wm_state):
1074 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
1075 and similarly for list2 through list5.
1076
bafe80ce
PE
10772013-07-15 Paul Eggert <eggert@cs.ucla.edu>
1078
1079 * callproc.c (Fcall_process_region): Fix minor race and tune.
1080 (create_temp_file): New function, with the temp-file-creation part
1081 of the old Fcall_process_region. Use Fcopy_sequence to create the
1082 temp file name, rather than alloca + build_string, for simplicity.
1083 Don't bother to block input around the temp file creation;
1084 shouldn't be needed. Simplify use of mktemp. Use
1085 record_unwind_protect immediately after creating the temp file;
1086 this closes an unlikely race where the temp file was not removed.
1087 Use memcpy rather than an open-coded loop.
1088 (Fcall_process_region): Use the new function. If the input is
1089 empty, redirect from /dev/null rather than from a newly created
1090 empty temp file; this avoids unnecessary file system traffic.
1091
4700b5a5
PE
10922013-07-14 Paul Eggert <eggert@cs.ucla.edu>
1093
5c97beae
PE
1094 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
1095 Simplify by making this case like the other two. This is a bit
1096 slower on obsolete hosts, but the extra complexity isn't worth it.
1097
4700b5a5
PE
1098 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
1099 * process.c (create_process) [!DOS_NT]:
1100 Remove now-unnecessary calls to emacs_close.
1101
f9a74c4c
EZ
11022013-07-13 Eli Zaretskii <eliz@gnu.org>
1103
922ae7ee
EZ
1104 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
1105 returning early. (Bug#14850)
1106
f9a74c4c
EZ
1107 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
1108 and inhibit-iso-escape-detection attributes of 'undecided'.
1109 (Bug#14822)
1110
5e301d76
PE
11112013-07-13 Paul Eggert <eggert@cs.ucla.edu>
1112
69e0e5ee
PE
1113 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
1114 Reported by Herbert J. Skuhra in
1115 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
1116
5e301d76
PE
1117 Don't lose top specpdl entry when memory is exhausted.
1118 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
1119 specpdl overflow here, to simplify callers; all callers changed.
1120 Always reserve an unused entry at the stack top; this avoids
1121 losing the top entry's information when memory is exhausted.
1122
7e649856
PE
11232013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1124
a773ed9a
PE
1125 Clean up errno reporting and fix some errno-reporting bugs.
1126 * callproc.c (Fcall_process):
1127 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1128 * process.c (create_process, Fmake_network_process):
1129 * unexaix.c (report_error):
1130 * unexcoff.c (report_error):
1131 Be more careful about reporting the errno of failed operations.
1132 The code previously reported the wrong errno sometimes.
1133 Also, prefer report_file_errno to setting errno + report_file_error.
1134 (Fcall_process): Look at openp return value rather than at path,
1135 as that's a bit faster and clearer when there's a numeric predicate.
1136 * fileio.c (report_file_errno): New function, with most of the
1137 old contents of report_file_error.
1138 (report_file_error): Use it.
1139 (Ffile_exists_p, Ffile_accessible_directory_p):
1140 Set errno to 0 when it is junk.
1141 * fileio.c (Faccess_file):
1142 * image.c (x_create_bitmap_from_file):
1143 Use faccessat rather than opening the file, to avoid the hassle of
1144 having a file descriptor open.
1145 * lisp.h (report_file_errno): New decl.
1146 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
1147
7e649856
PE
1148 Minor EBADF fixes.
1149 * process.c (create_process, wait_reading_process_output) [AIX]:
1150 Remove obsolete SIGHUP-related code, as Emacs no longer disables
1151 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
1152 a multithreaded environment anyway).
1153 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
1154
f6774c1a
AS
11552013-07-12 Andreas Schwab <schwab@linux-m68k.org>
1156
1157 * image.c (x_find_image_file): Don't close a remote file handle.
1158
bacba3c2
PE
11592013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1160
1161 Fix races with threads and file descriptors.
1162 * callproc.c (Fcall_process_region):
1163 * dired.c (open_directory):
1164 * emacs.c (main, Fdaemon_initialized):
1165 * image.c (x_find_image_file):
1166 * inotify.c (Finotify_rm_watch):
1167 * lread.c (Flocate_file_internal):
1168 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
1169 * term.c (term_mouse_moveto, init_tty):
1170 * termcap.c (tgetent):
1171 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
1172 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
1173 * unexhp9k800.c, unexmacosx.c (unexec):
1174 * callproc.c (Fcall_process_region):
1175 Use emacs_close, not close.
1176 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
1177 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
1178 and posix_close function on current platforms (which all lack them).
1179 (emacs_close): Use it. This should fix the races on GNU/Linux and
1180 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
1181 and it should avoid closing random victim file descriptors on
1182 other platforms.
1183
653d4f43
PE
11842013-07-11 Paul Eggert <eggert@cs.ucla.edu>
1185
c8536ec4
PE
1186 * inotify.c (uninitialized): Remove. All uses replaced by -1.
1187 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
1188 Touch up doc a bit.
1189
9c203066
PE
1190 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
1191 This is for .gdbinit xbacktrace.
1192
653d4f43
PE
1193 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
1194 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
1195 (emacs_set_tty): Now static.
1196 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
1197 * term.c (tty_capable_p, tty_default_color_capabilities)
1198 (get_tty_terminal, term_mouse_movement)
1199 (handle_one_term_event, init_tty, maybe_fatal):
1200 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
1201 (tgetent, scan_file, name_match, compare_contin):
1202 * terminal.c (get_terminal):
1203 Use bool for boolean.
1204 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
1205 Prefer char to unsigned char if either will do.
1206 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
1207 (tty_write_glyphs): Prefer int to unsigned.
1208 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
1209 All callers changed.
1210 * termcap.c (tprint, main) [TEST]: Remove non-working test.
1211
45b683a1
PE
12122013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1213
29abe551
PE
1214 Port to C89.
1215 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
1216 (B__dummy__): New dummy symbol, to pacify C89.
1217 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
1218 they can't grok varargs macros.
1219 * dispnew.c (add_window_display_history)
1220 (add_frame_display_history):
1221 * print.c (print_object):
1222 * xdisp.c (debug_method_add):
1223 Use %p printf format only for void pointers.
1224 * emacs.c (usage_message): New constant, replacing ...
1225 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
1226 (main): Adjust to usage reorg.
1227 * fns.c (syms_of_fns):
1228 * profiler.c (syms_of_profiler):
1229 Don't use non-constant struct initializers.
1230 * gnutls.h (gnutls_initstage_t):
1231 * lisp.h (enum Lisp_Fwd_Type):
1232 * lread.c (lisp_file_lexically_bound_p):
1233 * xsettings.c (anonymous enum):
1234 Remove trailing comma.
1235 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
1236 * lisp.h (ENUM_BF): Use unsigned if pedantic.
1237 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
1238 (DEFUN): Use it.
1239 * regex.c (const_re_char): New type, to pacify strict C89.
1240 All uses of 'const re_char' replaced to use it.
1241 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
1242 with glibc when strict C89. This change is imported from gnulib.
1243 All uses changed.
1244 (_Restrict_arr_): Rename from __restrict_arr, similarly.
1245 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
1246 Omit GNU_LINUX implementation, since it requires long long.
1247 * xterm.c (x_draw_underwave):
1248 Do not assume the traditional order of struct's members.
1249 (x_term_init): Rewrite to avoid the need for non-constant structure
1250 initializers.
1251
45b683a1 1252 Syntax cleanup, mostly replacing macros with functions.
763a086d 1253 This removes the need for the syntax_temp hack.
45b683a1
PE
1254 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
1255 * syntax.c (SYNTAX_INLINE): New macro.
1256 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
1257 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
1258 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
1259 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
1260 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
1261 (SYNTAX_COMEND_FIRST): Now functions, not macros.
1262 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
1263 Now constants, not macros.
1264 (syntax_temp) [!__GNUC__]: Remove.
1265 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
1266 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
1267 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
1268 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
1269 Move here from syntax.h; now functions, not macros. Except for the
1270 last function, these are static since only syntax.c uses them.
1271 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
1272 All uses changed. Now a function, not a macro; use this fact
1273 to simplify the code.
1274 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
1275 compiler bugs; no longer relevant.
1276 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1277 (SYNTAX_INLINE): New macro.
1278 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
1279 for the new functions. Use bool for boolean member.
1280 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
1281 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
1282 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
1283 (SETUP_BUFFER_SYNTAX_TABLE):
1284 Now extern inline functions, not macros.
1285 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
1286 Remove; all uses replaced by implementation.
1287 (syntax_temp) [!__GNUC__]: Remove decl.
1288 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
1289
29be4a50
JD
12902013-07-10 Jan Djärv <jan.h.d@swipnet.se>
1291
1292 * emacs.c (main): Fix syntax error.
1293
954b166e
PE
12942013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1295
1296 Timestamp fixes for undo (Bug#14824).
1297 * atimer.c (schedule_atimer):
1298 * fileio.c (Ffile_newer_than_file_p):
1299 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
1300 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
1301 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
1302 (syms_of_fileio): Remove Sclear_visited_file_name.
1303 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
1304 file doesn't exist; this avoids an ambiguity with negative timestamps.
1305 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
1306 * systime.h (make_emacs_time, invalid_emacs_time):
1307 Don't assume struct timespec layout; POSIX doesn't guarantee it.
1308 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
1309 * undo.c (record_first_change): Push (visited-file-modtime) onto
1310 undo list rather than reimplementing it by hand, incorrectly.
1311
d74647c3
KB
13122013-07-09 Ken Brown <kbrown@cornell.edu>
1313
1314 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
1315
3c51b96b
JB
13162013-07-09 Juanma Barranquero <lekktu@gmail.com>
1317
1318 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
1319
4ebbdd67
PE
13202013-07-09 Paul Eggert <eggert@cs.ucla.edu>
1321
1322 Handle errno and exit status a bit more carefully.
1323 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
1324 number into an exit status. Instead, use EXIT_CANCELED.
1325 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
1326 * callproc.c (relocate_fd):
1327 * emacs.c (close_output_streams, main):
1328 * process.c (create_process):
1329 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
1330 Use emacs_perror for simplicity.
1331 * callproc.c (relocate_fd, main):
1332 * sysdep.c (sys_subshell):
1333 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
1334 (shut_down_emacs): Use emacs_write, not write.
1335 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
1336 * fileio.c (Fcopy_file, e_write):
1337 * nsterm.m (ns_select):
1338 * process.c (send_process):
1339 * sound.c (vox_write):
1340 Use emacs_write_sig, not emacs_write.
1341 * lisp.h (emacs_write_sig, emacs_perror): New decls.
1342 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
1343 New constants.
1344 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
1345 of write.
1346 (emacs_full_write): New function.
1347 (emacs_write): Rewrite to use it.
1348 (emacswrite_sig, emacs_perror): New functions.
1349 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
1350
44e18199 13512013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
e4b1e5af
JD
1352
1353 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
1354 on NS even if it is present. Pixmap on NS is a void*.
1355
9caab067
PE
13562013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1357
1358 Port to Ubuntu 10 (Bug#14803).
1359 Problem reported by T.V. Raman.
1360 * process.c (close_on_exec, accept4, process_socket):
1361 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
1362
1d442672
EZ
13632013-07-07 Eli Zaretskii <eliz@gnu.org>
1364
1365 * w32.c (sys_dup): Declare prototype.
1366
1367 * filelock.c:
1368 * emacs.c:
1369 * callproc.c [WINDOWSNT]: Include sys/socket.h.
1370
067428c1
PE
13712013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1372
1373 Make file descriptors close-on-exec when possible (Bug#14803).
1374 This simplifies Emacs a bit, since it no longer needs to worry
1375 about closing file descriptors by hand in some cases.
1376 It also fixes some unlikely races. Not all such races, as
1377 libraries often open files internally without setting
1378 close-on-exec, but it's an improvement.
1379 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
1380 * callproc.c (Fcall_process) [!MSDOS]:
1381 * emacs.c (main) [!DOS_NT]:
1382 * nsterm.m (ns_term_init):
1383 * process.c (create_process):
1384 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
1385 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
1386 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
1387 Prefer mkostemp with O_CLOEXEC to mkstemp.
1388 * callproc.c (relocate_fd) [!WINDOWSNT]:
1389 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
1390 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
1391 now using pipe2.
1392 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
1393 Make the resulting file descriptor close-on-exec.
1394 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
1395 * lread.c (load_descriptor_list, load_descriptor_unwind):
1396 Remove; no longer needed. All uses removed.
1397 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
1398 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
1399 New functions.
1400 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
1401 (Fmake_network_process, Fnetwork_interface_list):
1402 (Fnetwork_interface_info, server_accept_connection):
1403 Make newly-created socket close-on-exec.
1404 * sysdep.c (emacs_open, emacs_fopen):
1405 Make new-created descriptor close-on-exec.
1406 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
1407 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
1408
0da857dd
JD
14092013-07-07 Jan Djärv <jan.h.d@swipnet.se>
1410
1411 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
1412 for NS_IMPL_GNUSTEP.
1413
5f86adcd
PE
14142013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1415
1416 Fix openp errno handling.
1417 * callproc.c (Fcall_process): Preserve openp errno around close.
1418 * lread.c (openp): Set errno when returning -1, as some callers
1419 expect this.
1420
1afb1d07
JD
14212013-07-06 Jan Djärv <jan.h.d@swipnet.se>
1422
1423 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
1424
1425 * nsterm.h (NSSavePanel): Update comment.
1426 (NSAPP_DATA2_RUNFILEDIALOG): Define.
1427 (ns_run_file_dialog): Declare.
1428
1429 * nsfns.m: Remove panelOK.
1430 (ns_fd_data): New.
1431 (ns_run_file_dialog): New function.
1432 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
1433 event loop, so file dialog is popped up by ns_run_file_dialog, called
1434 by sendEvent (Bug#14578).
1435 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
1436
3323c263
EZ
14372013-07-06 Eli Zaretskii <eliz@gnu.org>
1438
fdda0220
EZ
1439 * xdisp.c (default_line_pixel_height): New function.
1440 (pos_visible_p, move_it_vertically_backward, try_scrolling)
1441 (try_cursor_movement, redisplay_window, try_window)
1442 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
1443
1444 * window.c (window_scroll_pixel_based): use
1445 default_line_pixel_height.
1446
1447 * dispextern.h (default_line_pixel_height): Add prototype.
1448
1449 * frame.c (x_set_line_spacing): Accept a float value for
1450 line-spacing parameter, per the documentation.
1451
3323c263
EZ
1452 * data.c (Fmultibyte_string_p): Doc fix.
1453
47ba6d43
PE
14542013-07-05 Paul Eggert <eggert@cs.ucla.edu>
1455
406af475
PE
1456 Use emacs_open more consistently when opening files.
1457 This handles EINTR more consistently now, and makes it easier
1458 to introduce other uniform changes to file descriptor handling.
1459 * src/systdio.h: New file.
1460 * src/buffer.c (mmap_init):
1461 * cygw32.c (chdir_to_default_directory):
1462 * dispnew.c (Fopen_termscript):
1463 * emacs.c (Fdaemon_initialized):
1464 * fileio.c (Fdo_auto_save):
1465 * image.c (slurp_file, png_load_body, jpeg_load_body):
1466 * keyboard.c (Fopen_dribble_file):
1467 * lread.c (Fload):
1468 * print.c (Fredirect_debugging_output):
1469 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
1470 * termcap.c (tgetent):
1471 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
1472 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
1473 * w32term.c (w32_initialize) [CYGWIN]:
1474 * xfaces.c (Fx_load_color_file):
1475 Use emacs_open instead of plain open, and emacs_fopen instead of
1476 plain fopen.
1477 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
1478 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
1479 * callproc.c (default_output_mode): New constant.
1480 (Fcall_process): Use it to call emacs_open instead of plain creat.
1481 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
1482 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
1483 (emacs_fopen): New function.
1484 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
1485 Include <lisp.h>, for emacs_open.
1486 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
1487
47ba6d43
PE
1488 Remove duplicate #include directives.
1489 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
1490 * xfaces.c:
1491 Don't include stdio.h twice.
1492 * buffer.c [USE_MMAP_FOR_BUFFERS]:
1493 Don't include sys/types.h or stdio.h twice.
1494 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
1495 * lread.c: Don't include coding.h twice.
1496 * nsfont.m: Don't include frame.h twice.
1497 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
1498 * ralloc.c: Don't include <unistd.h> twice.
1499 * xdisp.c: Don't include font.h twice.
1500 * xterm.c: Don't include fontset.h twice.
1501 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
1502
b9ed53d5
PE
15032013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1504
1505 Scale ImageMagick images more carefully.
1506 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
1507 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
1508 Be more careful about avoiding undefined behavior after
1509 integer overflow and division by zero.
1510
cf13177e
YM
15112013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1512
1513 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
1514 (syms_of_w32fns): DEFSYM them.
1515 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
1516 (CCHDEVICENAME): Define macros if not defined.
1517 (struct MONITOR_INFO_EX): New struct.
1518 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
1519 (enum_display_monitors_fn): New variable.
1520 (globals_of_w32fns): Initialize it.
1521 (Fx_display_pixel_width, Fx_display_pixel_height)
1522 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
1523 multi-monitor setups in docstrings.
1524 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
1525 screen size by primary monitor's millimeter per pixel.
1526 (w32_monitor_enum, w32_display_monitor_attributes_list)
1527 (w32_display_monitor_attributes_list_fallback)
1528 (Fw32_display_monitor_attributes_list): New functions.
1529 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
1530
1531 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
1532 if not defined.
1533 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
1534
86dfb7a8
MA
15352013-07-04 Michael Albinus <michael.albinus@gmx.de>
1536
1537 * fileio.c (Qfile_notify_error): New error symbol.
1538
1539 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
1540 * inotify.c (inotify_callback, symbol_to_inotifymask)
1541 (Finotify_add_watch, Finotify_rm_watch): Use it.
1542 (inotifyevent_to_event): Exchange order of cookie and file name.
1543 (Finotify_add_watch): Adapt docstring.
1544
1545 * lisp.h (Qfile_notify_error): Declare.
1546
2c1c974b
PE
15472013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1548
1549 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
1550 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1551 Do not clear _malloc_thread_enabled_p, undoing the previous change,
1552 which did not work (see <http://bugs.gnu.org/14569#307>).
1553 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
1554 && (!noninteractive || initialized)). This attempts to thread
1555 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
1556
7a35b20f
JB
15572013-07-04 Juanma Barranquero <lekktu@gmail.com>
1558
1559 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
1560 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
1561
1ce5cd04
PE
15622013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1563
1564 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
1565 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1566 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
1567 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
1568
57f8c490
PE
15692013-07-02 Paul Eggert <eggert@cs.ucla.edu>
1570
1571 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
1572 Define to __sys_siglist.
1573
bcffb5ca
EZ
15742013-07-02 Eli Zaretskii <eliz@gnu.org>
1575
1576 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
1577 word-wrap, so that overflow-newline-into-fringe would work in
1578 visual-line-mode. (Bug#2749)
1579 (move_it_in_display_line_to): When the last scanned display
1580 element fits exactly on the display line, and
1581 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
1582 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
1583 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
1584 finding buffer position that corresponds to pixel coordinates,
1585 e.g. in buffer_posn_from_coords.
1586
2c41e781
JD
15872013-07-02 Jan Djärv <jan.h.d@swipnet.se>
1588
1589 * process.c (handle_child_signal): Call catch_child_signal if
1590 NS_IMPL_GNUSTEP.
1591
c2418359
PE
15922013-07-02 Paul Eggert <eggert@cs.ucla.edu>
1593
52a9bcae
PE
1594 Don't convert function pointers to void * and back.
1595 It isn't portable C, and it's easy enough to avoid.
1596 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
1597 (make_save_value): Add support for SAVE_FUNCPOINTER.
1598 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
1599 * print.c (print_object):
1600 Distinguish function from object pointers.
1601 * lisp.h (SAVE_FUNCPOINTER): New constant.
1602 (SAVE_SLOT_BITS): Adjust to it.
1603 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
1604 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
1605 (voidfuncptr): New typedef.
1606 (struct Lisp_Save_Value): New member data[0].funcpointer.
1607 (XSAVE_FUNCPOINTER): New function.
1608
c2418359
PE
1609 Simplify buildobj processing.
1610 * Makefile.in (buildobj.h): Make it a sequence of strings each
1611 followed by comma, rather than a single string. Put it into a
1612 .tmp file in case there's an error while generating it.
1613 (gl-stamp): Use .tmp for temp files.
1614 (mostlyclean): Clean .tmp files.
1615 * doc.c (buildobj): Move to just the routine that needs it.
1616 It's now an array of strings, so processing is simpler.
1617
8f43ce49
PE
16182013-07-01 Paul Eggert <eggert@cs.ucla.edu>
1619
1620 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
1621 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
1622 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1623 Invoke malloc_enable_thread even when not interactive.
1624 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
1625 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
1626 in this case, since the underlying bug has now been fixed.
1627
24827db9
JB
16282013-07-01 Juanma Barranquero <lekktu@gmail.com>
1629
1630 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
1631 unlinking it (bug#14691).
1632
ef099a94
MN
16332013-06-30 Michal Nazarewicz <mina86@mina86.com>
1634
1635 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
1636 before checking whether buffer is modified. This lets
1637 `kill-buffer-query-functions' cancel killing of the buffer or save
1638 its content before `kill-buffer' asks user the "Buffer %s
1639 modified; kill anyway?" question.
1640
9d3f2fc2
JD
16412013-06-30 Jan Djärv <jan.h.d@swipnet.se>
1642
1643 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
1644 Let the super performKeyEquivalent deal with them (Bug#14747).
1645
e6c6c8c7
PE
16462013-06-30 Paul Eggert <eggert@cs.ucla.edu>
1647
1d71c1d9
PE
1648 * widget.c (resize_cb): Remove unused local.
1649
8f5f35cc
PE
1650 Do not use GTK 3 if it exists but cannot be compiled.
1651 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
1652 * xterm.c (x_error_handler) [!USE_GTK]:
1653 Do not use GTK 3.
1654
e6c6c8c7
PE
1655 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
1656
0ba54312
EZ
16572013-06-30 Eli Zaretskii <eliz@gnu.org>
1658
5d1c3286
EZ
1659 * intervals.c (get_local_map): Instead of aborting, clip POSITION
1660 to the valid range of values. (Bug#14753)
1661
0ba54312
EZ
1662 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
1663 when moving point by using the current glyph matrix. This avoids
1664 the need to force redisplay when this function is called in a
1665 loop.
1666
9c90cc06
PE
16672013-06-29 Paul Eggert <eggert@cs.ucla.edu>
1668
1669 Fix minor problems found by static checking.
1670 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
1671 Redo the latter's body to sidestep GCC parenthesization warnings.
1672 (setup_coding_system, detect_coding, detect_coding_system): Use them.
1673 * coding.c (detect_coding, detect_coding_system):
1674 * coding.h (struct undecided_spec):
1675 Use bool for boolean.
1676 * image.c (QCmax_width, QCmax_height): Now static.
1677 * xdisp.c (Fmove_point_visually): Remove unused local.
1678
4c672a0f
EZ
16792013-06-29 Eli Zaretskii <eliz@gnu.org>
1680
1681 * xdisp.c (Fmove_point_visually): New function.
1682
c1ea3abf
JB
16832013-06-28 Kenichi Handa <handa@gnu.org>
1684
1685 * coding.h (define_coding_undecided_arg_index): New enum.
1686 (coding_attr_index): New members
1687 coding_attr_undecided_inhibit_null_byte_detection,
1688 coding_attr_undecided_inhibit_iso_escape_detection,
1689 coding_attr_undecided_prefer_utf_8.
1690 (undecided_spec): New struct.
1691 (struct coding_system): New member `undecided' of the member
1692 `spec'.
1693
1694 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
1695 (detect_coding): Likewise.
1696 (detect_coding_system): Likewise.
1697 (Fdefine_coding_system_internal): New coding system properties
1698 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
1699 :prefer-utf-8.
1700 (syms_of_coding): Adjust for coding_arg_undecided_max.
1701
ba3de9e6
PE
17022013-06-28 Paul Eggert <eggert@cs.ucla.edu>
1703
1704 * image.c (x_from_xcolors): Remove unused local.
1705
547c9269
YM
17062013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1707
1708 Defer image data transfer between X client and server until actual
1709 display happens.
1710
1711 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
1712 and `mask_img'.
1713
1714 * image.c (Destroy_Image): Remove.
1715 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
1716 `mask_p', and `colors_p'. All uses changed.
1717 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
1718 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
1719 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
1720 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
1721 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 1722 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
1723 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
1724 (image_get_x_image, image_unget_x_image): New functions or macros.
1725 (image_background, image_background_transparent, x_to_xcolors)
1726 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
1727 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
1728 instead of Destroy_Image.
1729 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
1730 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
1731 (png_load_body, jpeg_load_body, tiff_load, gif_load)
1732 (imagemagick_load_image, svg_load_image): Use them instead of
1733 x_create_x_image_and_pixmap, and x_put_x_image followed by
1734 x_destroy_x_image, respectively.
1735 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
1736 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
1737 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
1738 background_transparent fields.
1739 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
1740 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
1741
dae2f5ef
PE
17422013-06-27 Paul Eggert <eggert@cs.ucla.edu>
1743
1744 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
1745 This mostly consists of undoing recent changes.
1746 * callproc.c (Fcall_process):
1747 * process.c (create_process):
1748 Do not worry about catching SIGCHLD here, undoing previous change.
1749 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
1750 * process.c, process.h (catch_child_signal):
1751 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
1752 * process.c (catch_child_handler): Don't worry about being called
1753 lazily and do not assume caller has blocked SIGCHLD, undoing
1754 previous change. Move first-time stuff back to
1755 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
1756 tickle glib, as that causes Cygwin bootstrap to fail. Do not
1757 set lib_child_handler if it's already initialized, which may
1758 help avoid problems on GNUStep.
1759
fa55d2aa
PE
17602013-06-23 Paul Eggert <eggert@cs.ucla.edu>
1761
1762 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
1763 * callproc.c (Fcall_process):
1764 * process.c (create_process):
1765 Make sure SIGCHLD is caught before we fork,
1766 since Emacs startup no arranges to catch SIGCHLD.
1767 * process.c (lib_child_handler): Initialize to null, not to
1768 dummy_handler.
1769 (catch_child_signal): Allow self to be called lazily.
1770 Do nothing if it's already been called.
1771 Assume caller has blocked SIGCHLD (all callers do now).
1772 * emacs.c (main): Do not catch SIGCHLD here; defer it until
1773 just before it's really needed.
1774 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
1775 since it hasn't been caught yet.
1776
f3f9606c
LMI
17772013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
1778
1779 * image.c (compute_image_size): New function to implement
1780 :max-width and :max-height.
1781 (imagemagick_load_image): Use it.
1782
c7041908
PE
17832013-06-23 Paul Eggert <eggert@cs.ucla.edu>
1784
1785 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
1786 * callproc.c, process.h (block_child_signal, unblock_child_signal):
1787 Now extern.
1788 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
1789 * process.c (catch_child_signal): Block SIGCHLD while futzing with
1790 the SIGCHLD handler, since the code is not atomic and (due to glib)
1791 signals may be arriving now.
1792 * sysdep.c (init_signals): Do not catch child signals here;
1793 'main' now does that later, at a safer time.
1794
f86852b4
PE
17952013-06-22 Paul Eggert <eggert@cs.ucla.edu>
1796
0dfeed58
PE
1797 Clean up SIGCHLD handling a bit (Bug#14569).
1798 * process.c, process.h (catch_child_signal):
1799 Now always extern, even if !NS_IMPL_GNUSTEP.
1800 * process.c (catch_child_signal): Move glib tickler here from
1801 init_process_emacs, so that it's done earlier in Emacs
1802 initialization. Also move the noninteractive && !initialized
1803 check here from init_process_emacs. This is all a bit cleaner for
1804 GNUish platforms, and I hope it works around the Cygwin bug.
1805 * sysdep.c (init_signals): Invoke catch_child_signal here, so
1806 that glib signal handling is tickled before glib creates threads.
1807
f86852b4
PE
1808 * process.c (wait_reading_process_output): Avoid int overflow
1809 when reading more than 2 GiB total from a process.
1810
cbd6509c
PE
18112013-06-21 Paul Eggert <eggert@cs.ucla.edu>
1812
1813 * process.c (create_process): Handle a couple more cases,
1814 i.e., work even if new_argv and wait_child_setup[i] are cached.
1815 Use Fcall_process's style for volatile vars.
1816
9de1114a
AS
18172013-06-21 Andreas Schwab <schwab@linux-m68k.org>
1818
1819 * process.c (create_process): Mark PROCESS volatile.
1820
fbe9e0b9
PE
18212013-06-21 Paul Eggert <eggert@cs.ucla.edu>
1822
1823 Use C99-style flexible array members if available.
1824 This avoids some subtle aliasing issues, which typically
1825 aren't a problem with GCC but may be a problem elsewhere.
1826 * alloc.c (sdata): New typedef, replacing the old struct sdata.
1827 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
1828 In either case, it uses a flexible array member rather than
1829 the old struct hack. All uses changed.
1830 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
1831 Adjust to sdata reorganization.
1832 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
1833 Use offsetof (struct, flex_array_member), not sizeof (struct), as
1834 that ports better to pre-C99 non-GCC.
1835 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
1836 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
1837 as the latter has changed.
1838 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
1839 and port better to pre-C99 GCC.
1840 * image.c (struct xpm_cached_color):
1841 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
1842 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
1843 Use FLEXIBLE_ARRAY_MEMBER.
1844 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
1845 Move decl to top level so it gets checked against implementation.
1846 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
1847 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
1848
1fc71008
PE
18492013-06-20 Paul Eggert <eggert@cs.ucla.edu>
1850
1851 * syntax.c: Integer cleanups.
1852 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
1853 All uses that need 0-or-2 changed to:
1854 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
1855 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
1856 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
1857 (char_quoted, prev_char_comend_first, back_comment)
1858 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
1859 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
1860 Use bool for boolean.
1861 (update_syntax_table, skip_chars, skip_syntaxes):
1862 Prefer int to unsigned when either will do.
1863 (back_comment): Return boolean success flag, like forw_comment,
1864 instead of positive-or-minus-1 (which might have overflowed int anyway).
1865 Don't stuff ptrdiff_t into int.
1866 (syntax_spec_code, syntax_code_spec): Now const.
1867 (Fmatching_paren, scan_lists, scan_sexps_forward):
1868 Use enum syntaxcode for syntax code.
1869 (Fmatching_paren): Check that arg is a character, not just an integer.
1870 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
1871 (Finternal_describe_syntax_value): Omit no-longer-needed
1872 comparison to 0.
1873 (skip_chars): Use char, not unsigned char, when the distinction
1874 doesn't matter.
1875 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
1876 * bytecode.c (exec_byte_code):
1877 * syntax.c (syntax_spec_code, Fchar_syntax)
1878 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
1879 (init_syntax_once):
1880 * syntax.h (SYNTAX_WITH_FLAGS):
1881 Omit unnecessary casts.
1882
b932cad7
EZ
18832013-06-20 Eli Zaretskii <eliz@gnu.org>
1884
1885 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
1886 line dimensions here, to avoid race conditions with the main
1887 thread. (Bug#14062, bug#14630, bug#14669)
1888
1889 * w32term.c (w32_draw_window_cursor): Compute the header line and
1890 mode line dimensions here.
1891 <w32_system_caret_window, w32_system_caret_hdr_height>:
1892 <w32_system_caret_mode_height>: New variables.
1893
1894 * w32term.h: Declare them.
1895
89561f72
PE
18962013-06-20 Paul Eggert <eggert@cs.ucla.edu>
1897
5013fc08
PE
1898 * alloc.c (die): Move "assertion failed" string here ...
1899 * lisp.h (eassert): ... from here. Also, suppress evaluation of
1900 COND when SUPPRESS_CHECKING. This shrinks the executable text
1901 size by 0.8% to 2.2% when configured with --enable-checking,
1902 depending on optimization flags (GCC 4.8.1 x86-64).
1903
89561f72
PE
1904 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
1905
763a086d 19062013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
1907
1908 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
1909 base is 2; this is more accurate.
1910
983aeb9a
JB
19112013-06-19 Juanma Barranquero <lekktu@gmail.com>
1912
1913 * sound.c (string_default): Move to !WINDOWSNT section.
1914 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
1915
178ba3e6
PE
19162013-06-19 Paul Eggert <eggert@cs.ucla.edu>
1917
bbc51b15
PE
1918 * sound.c: Integer cleanups.
1919 Remove unnecessary forward decls.
1920 (struct sound_device): The 'file' member is now a Lisp_Object, not
1921 a char *, so that we needn't invoke alloca on a huge size.
1922 (Fplay_sound_internal): Adjust to this.
1923 (string_default): New function.
1924 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
1925 Use it to adjust to the struct sound_device change.
1926 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
1927 (be2hs) [0]: Remove.
1928
178ba3e6
PE
1929 * syntax.c (skip_chars): Don't use uninitialized storage
1930 when searching a multibyte buffer for characters that are not in a
1931 unibyte string that contains non-ASCII characters.
1932
69f60cdc
JD
19332013-06-18 Jan Djärv <jan.h.d@swipnet.se>
1934
1935 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
1936 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
1937
0d6224d4
PE
19382013-06-18 Paul Eggert <eggert@cs.ucla.edu>
1939
1940 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
1941
3c542890
KH
19422013-06-18 Kenichi Handa <handa@gnu.org>
1943
f7e3f7cd
KH
1944 * font.c (Ffont_spec): Signal an error for an invalid font name
1945 (Bug#14648).
3c542890 1946
9349e5f7
PE
19472013-06-18 Paul Eggert <eggert@cs.ucla.edu>
1948
1949 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
1950 In particular this ports to 32-bit sparc Sun cc.
1951 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
1952 array with a dummy element at specpdl[-1], so that its address can
1953 be taken portably.
1954 (unbind_to): Do not copy the binding; not needed, now that we
1955 copy old_value in the one place where the copy is needed.
1956 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
1957 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
1958 (union specbinding): Rename from struct specbinding. Redo layout
1959 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
1960 which is not portable. With Sun C 5.12 32-bit sparc, the
1961 declaration causes nargs to be an unsigned bitfield, a behavior
1962 that the C standard allows; but Emacs wants nargs to be signed.
1963 The overall type is now a union of structures rather than a
1964 structure of union of structures, and the 'kind' member is now a
1965 bitfield, so that the overall type doesn't grow. All uses changed.
1966 * process.c (Fmake_serial_process): Remove unnecessary initialization.
1967
0a4df6a5
PE
19682013-06-17 Paul Eggert <eggert@cs.ucla.edu>
1969
ec6ecaad
PE
1970 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
1971 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
1972
0a4df6a5
PE
1973 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
1974
7bfe8dbc
EZ
19752013-06-17 Eli Zaretskii <eliz@gnu.org>
1976
1977 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
1978 unless we know that the window w's frame is a frame object.
1979 Another attempt at solving bug#14062 and bug#14630.
1980
708e05f6
LMI
19812013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
1982
1983 * textprop.c (property_set_type): New enum.
1984 (add_properties): Allow appending/prepending text properties.
1985 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 1986 (Fadd_text_properties): Move all the code into
708e05f6
LMI
1987 add_text_properties_1.
1988 (Fadd_face_text_property): New function that calls
1989 add_text_properties_1.
1990
84575e67
PE
19912013-06-17 Paul Eggert <eggert@cs.ucla.edu>
1992
1993 Move functions from lisp.h to individual modules when possible.
1994 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
1995 * alloc.c (XFLOAT_INIT, set_symbol_name):
1996 * buffer.c (CHECK_OVERLAY):
1997 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
1998 (set_char_table_parent):
1999 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
2000 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
2001 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
2002 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
2003 (set_blv_valcell):
2004 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
2005 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
2006 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
2007 (backtrace_args, backtrace_debug_on_exit):
2008 * floatfns.c (CHECK_FLOAT):
2009 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
2010 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
2011 (set_hash_hash, set_hash_hash_slot, set_hash_index)
2012 (set_hash_index_slot):
2013 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
2014 * marker.c (CHECK_MARKER):
2015 * textprop.c (CHECK_STRING_OR_BUFFER):
2016 * window.c (CHECK_WINDOW_CONFIGURATION):
2017 Move here from lisp.h, and make these functions static rather than
2018 extern inline.
2019 * buffer.c (Qoverlayp):
2020 * data.c (Qsubrp):
2021 * fns.c (Qhash_table_p):
2022 * window.c (Qwindow_configuration_p):
2023 Now static.
2024 * lisp.h: Remove the abovementioned defns and decls.
2025
44e18199 2026 Use functions, not macros, for XINT etc (Bug#11935).
84575e67
PE
2027 In lisp.h, prefer functions to function-like macros, and
2028 constants to object-like macros, when either will do. This:
2029 . simplifies use, as there's no more need to worry about
2030 arguments' side effects being evaluated multiple times.
2031 . makes the code easier to debug on some platforms.
2032 However, when using gcc -O0, keep using function-like macros
2033 for a few critical operations, for performance reasons.
2034 This sort of thing isn't needed with gcc -Og, but -Og
2035 is a GCC 4.8 feature and isn't widely-enough available yet.
2036 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
2037 Remove enum lsb_bits; no longer needed.
2038 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
2039 * buffer.c (Qoverlap):
2040 * data.c (Qsubrp):
2041 * fns.c (Qhash_table_p):
2042 Now extern, so lisp.h can use these symbols.
2043 * dispextern.h: Include character.h, for MAX_CHAR etc.
2044 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2045 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2046 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2047 (GLYPH_CODE_P): Move here from lisp.h.
2048 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2049 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
2050 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
2051 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
2052 XUNTAG now returns void *.
2053 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
2054 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
2055 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
2056 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
2057 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
2058 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
2059 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
2060 (lisp_h_XPNTR, lisp_h_XSYMBOL):
2061 New macros, renamed from their sans-lisp_h_ counterparts.
2062 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
2063 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
2064 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
2065 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
2066 If compiling via GCC without optimization, define these as macros
2067 in addition to inline functions.
2068 To disable this, compile with -DINLINING=0.
2069 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
2070 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
2071 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
2072 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
2073 (INTMASK, VALMASK): Now macros, since static values cannot be
2074 accessed from extern inline functions.
2075 (VALMASK): Also a constant, for benefit of old GDB.
2076 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
2077 is INTEGERP, which can fold it in.
5165d44a 2078 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
2079 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
2080 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
2081 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
2082 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
2083 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
2084 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
2085 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
2086 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
2087 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
2088 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
2089 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
2090 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
2091 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
2092 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
2093 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
2094 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
2095 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
2096 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
2097 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
2098 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
2099 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
2100 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
2101 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
2102 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
2103 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
2104 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
2105 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
2106 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
2107 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
2108 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
2109 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
2110 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
2111 Now functions.
2112 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
2113 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
2114 (VALMASK): Define in one place rather than in two, merging the
2115 USE_LSB_TAG parts; this is simpler.
2116 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
2117 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
2118 Move up, to avoid use before definition.
2119 Also include "globals.h" earlier, for the same reason.
2120 (make_natnum): New function.
2121 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
2122 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
2123 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
2124 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
2125 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
2126 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
2127 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
2128 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
2129 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
2130 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
2131 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
2132 (Qwindow_configuration_p, Qimage): New forward declarations.
2133 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
2134 (STRING_COPYIN): Remove; unused.
2135 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
2136 (xcar_addr, xcdr_addr): New functions. All uses changed.
2137 (IEEE_FLOATING_POINT): Now a constant, not a macro.
2138 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2139 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2140 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2141 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
2142 (TYPE_RANGED_INTEGERP): Simplify.
2143 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
2144 (setlocale, fixup_locale, synchronize_system_messages_locale)
2145 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
2146 Now empty functions, not macros.
2147 (functionp): Return bool, not int.
2148 * window.c (Qwindow_configuration_p): Now extern,
2149 so window.h can use it.
2150 * window.h (Qwindowp): Move decl back to lisp.h.
2151
9583ec36
EZ
21522013-06-15 Eli Zaretskii <eliz@gnu.org>
2153
2154 * xdisp.c (Fline_pixel_height): New function, required for solving
2155 bug #14567.
2156
210272ce
PE
21572013-06-15 Paul Eggert <eggert@cs.ucla.edu>
2158
2159 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
2160
de0503df
SM
21612013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
2162
2163 * lread.c (syms_of_lread):
2164 * fns.c (Fprovide): Adjust to new format of after-load-alist.
2165
afbfe143
KD
21662013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
2167
2168 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
2169
d177e213
XF
21702013-06-12 Xue Fuqiao <xfq.free@gmail.com>
2171
2172 * fileio.c (expand_file_name): Doc fix.
2173
05e3e412
PE
21742013-06-11 Paul Eggert <eggert@cs.ucla.edu>
2175
f7394b12
PE
2176 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
2177 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
2178 Wait for self, not for 0. This can't hurt on GNU or similar
2179 system, and may help with Cygwin.
2180
05e3e412
PE
2181 * keyboard.c: Don't use PROP (...) as an lvalue.
2182 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
2183 Use set_prop (A, B), not PROP (A) = B.
2184
17dd3097
EZ
21852013-06-10 Eli Zaretskii <eliz@gnu.org>
2186
2187 * xdisp.c (get_it_property): Use it->window instead of generating
2188 a Lisp object from it->w.
2189
52fab9c9
EZ
21902013-06-09 Eli Zaretskii <eliz@gnu.org>
2191
2192 * xdisp.c (get_it_property): If it->object is a buffer, pass to
2193 get-char-property the window that is being rendered, instead of
2194 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
2195 (compute_display_string_pos): When W is NULL, use the current
2196 buffer as the object to pass to get-char-property.
2197 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
2198 pointer member of the bidi iterator, since no window is pertinent
2199 to this function.
52fab9c9 2200
5bf97bfc
EZ
22012013-06-08 Eli Zaretskii <eliz@gnu.org>
2202
2203 * bidi.c (bidi_fetch_char): Accept additional argument, the window
2204 being displayed, and pass it to compute_display_string_pos.
2205 (bidi_level_of_next_char, bidi_resolve_explicit_1)
2206 (bidi_paragraph_init): All callers changed.
2207
2208 * xdisp.c (init_from_display_pos, init_iterator)
2209 (handle_single_display_spec, next_overlay_string)
2210 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
2211 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
2212 Set bidi_it.w member from it->w.
5bf97bfc
EZ
2213 (compute_display_string_pos): Accept additional argument, the
2214 window being displayed, and pass it to Fget_char_property.
2215 (Bug#14575)
2216
2217 * dispextern.h (struct bidi_it): New member w, the window being
2218 displayed.
2219 (compute_display_string_pos): Adjust prototype.
2220
5de0e011
JD
22212013-06-08 Jan Djärv <jan.h.d@swipnet.se>
2222
e7b41c4c 2223 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
2224
2225 * process.c (wait_reading_process_output): Check for NS before GLIB.
2226 GLIB may be linked in due to rsvg, but ns_select must be called.
2227
5de0e011
JD
2228 * xgselect.c (xg_select): Remove call to window_system_available
2229 and g_main_context_pending at the top, so Gdk events (i.e. file
2230 notify) are processed when Emacs is started with -nw.
2231
a822acff
EZ
22322013-06-07 Eli Zaretskii <eliz@gnu.org>
2233
2234 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
2235 (ctagsfiles3): New variable, includes only *.m files.
2236 (TAGS): Use an explicit language name in the regular expressions,
2237 to avoid transformation of '/SOMETHING' by MSYS to
2238 'c:\MSYS\SOMETHING'.
2239
6c0a9ed1
RC
22402013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
2241
2242 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
2243
9ef6111b
EZ
22442013-06-06 Eli Zaretskii <eliz@gnu.org>
2245
2246 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
2247 still need to set the mouse pointer shape and activate help-echo.
2248 (Bug#14558)
2249
7d300d64
PE
22502013-06-06 Paul Eggert <eggert@cs.ucla.edu>
2251
2252 A few porting etc. fixes for the new file monitor code.
2253 See the thread containing
2254 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
2255 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
2256 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
2257 (dir_monitor_callback, Fgfile_rm_watch):
2258 Use assq_no_quit instead of Fassoc, for speed.
2259 (dir_monitor_callback, Fgfile_rm_watch):
2260 eassert that the monitor is a fixnum.
2261 (dir_monitor_callback): No need for CDR_SAFE.
2262 Simplify building of lisp with alternative tails.
2263 (Fgfile_add_watch, Fgfile_rm_watch):
2264 Do not assume glib functions set errno reliably on failure.
2265 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
2266 and signal an error otherwise.
2267 (Fgfile_rm_watch): Prefer CONSP to !NILP.
2268 Use Fdelq instead of Fdelete, for speed.
2269
817ebfcf
EZ
22702013-06-05 Eli Zaretskii <eliz@gnu.org>
2271
2272 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
2273 don't insist on being invoked on a highlighted tool-bar button.
2274 Avoids losing tool-bar functionality when mouse-highlight is nil.
2275 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
2276 Don't highlight when mouse-highlight is nil.
2277 (note_mouse_highlight): When mouse-highlight is nil, don't return
2278 right away; instead, run tool-bar and mode-line highlight
2279 subroutine, clear any existing highlight, and revert the mouse
2280 pointer to its default shape. (Bug#14558)
2281
55577e7c
SM
22822013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2283
2284 * lisp.mk (lisp): Add prog-mode.el.
2285
f019a684
PE
22862013-06-05 Paul Eggert <eggert@cs.ucla.edu>
2287
2288 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
2289 * process.c (dummy_handler): New function.
2290 (lib_child_handler): New static var.
2291 (handle_child_signal): Invoke it.
2292 (catch_child_signal): If a library has set up a signal handler,
2293 save it into lib_child_handler.
2294 (init_process_emacs): If using glib and not on Windows, tickle glib's
2295 child-handling code so that it initializes its private SIGCHLD handler.
2296 * syssignal.h (SA_SIGINFO): Default to 0.
2297 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
2298 31; it should no longer be needed now.
2299
90db8702
MA
23002013-06-05 Michael Albinus <michael.albinus@gmx.de>
2301
2302 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
2303
2304 * gfilenotify.c (globals_of_gfilenotify): New function.
2305 (syms_of_gfilenotify): Move global initialization there.
2306
2307 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
2308
bfa3acd6
SM
23092013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2310
2311 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
2312 * keyboard.c (menu_bar_items, tool_bar_items):
2313 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
2314 not override local keymaps any more.
2315
ba59bd80
EZ
23162013-06-04 Eli Zaretskii <eliz@gnu.org>
2317
2318 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
2319
7f203aa1
EZ
23202013-06-03 Eli Zaretskii <eliz@gnu.org>
2321
9337e206
EZ
2322 * w32console.c (initialize_w32_display): Return the dimensions of
2323 the console window via 2 additional arguments, not via the current
2324 frame. This avoids crashes due to overrunning the bounds of
2325 frame's decode_mode_spec_buffer, which is not resized following
2326 the change of the frame dimensions from the initial 10x10.
2327
2328 * w32term.h (w32_initialize_display_info): Adjust prototype.
2329
2330 * term.c (init_tty): Take dimensions of the frame from the values
2331 returned by initialize_w32_display.
2332
7f203aa1
EZ
2333 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
2334 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
2335 (LIBES): Add $(GFILENOTIFY_LIBS).
2336
2337 * w32inevt.c (handle_file_notifications): Add dummy implementation
2338 for !HAVE_W32NOTIFY.
2339
2340 * w32term.c: Wrap code with HAVE_W32NOTIFY.
2341
55a87246
JD
23422013-06-03 Jan Djärv <jan.h.d@swipnet.se>
2343
2344 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
2345
2346 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
2347
2348 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
2349
3d5ee10a
PE
23502013-06-03 Paul Eggert <eggert@cs.ucla.edu>
2351
2352 Fix minor problems found by static checking.
2353 * data.c (pure_write_error):
2354 Use xsignal2, not Fsignal, as Fsignal might return.
2355 * eval.c (set_backtrace_debug_on_exit): Now static.
2356 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
2357 No longer inline. EXTERN_INLINE is needed only for functions
2358 defined in .h files. Reindent function header as per GNU style.
2359 (backtrace_p, backtrace_top, backtrace_next):
2360 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
2361 compiler or linker. Add extern decls to pacify gcc -Wall.
2362 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
2363 Now static.
2364 * frame.c (free_monitors): Define only on platforms that need it.
2365 * nsterm.m (ns_term_init):
2366 * process.c (catch_child_signal):
2367 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
2368 defined on all porting targets these days.
2369 * process.c, process.h (catch_child_signal):
2370 Make it extern only if NS_IMPL_GNUSTEP is defined.
2371
e2d8a6f0
EZ
23722013-06-03 Eli Zaretskii <eliz@gnu.org>
2373
2374 * w32.c (gettimeofday): Make the signature identical to prototype
2375 in nt/inc/sys/time.h.
2376
a8a7c5f6
SM
23772013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
2378
2379 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
2380 .gdbinit.
2381
2382 * keyboard.c (safe_run_hooks_error): Improve error message.
2383
2384 * data.c (pure_write_error): Add `object' argument.
2385 * puresize.h (CHECK_IMPURE): Use it.
2386
c9628c79
MA
23872013-06-03 Michael Albinus <michael.albinus@gmx.de>
2388
2389 * Makefile.in (NOTIFY_OBJ): New variable.
2390 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
2391
2392 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
2393 Call syms_of_gfilenotify.
2394
2395 * gfilenotify.c: New file.
2396
2397 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
2398 and Qfile_w32notify.
2399 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
2400 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
2401
2402 * lisp.h: Declare syms_of_gfilenotify.
2403
2404 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
2405
2f592f95
SM
24062013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
2407
2408 Merge the specpdl and backtrace stacks. Make the structure of the
2409 specpdl entries more obvious via a tagged union of structs.
2410 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
2411 (enum specbind_tag): New enum.
2412 (struct specbinding): Make it a tagged union of structs.
2413 Add a case for backtrace records.
2414 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
2415 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
2416 (backtrace_debug_on_exit): New accessors.
2417 (struct backtrace): Remove.
2418 (struct catchtag): Remove backlist field.
2419 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2420 Move to eval.c.
2421 (Flocal_variable_p): Speed up the common case where the binding is
2422 already loaded.
2423 * eval.c (backtrace_list): Remove.
2424 (set_specpdl_symbol, set_specpdl_old_value): Remove.
2425 (set_backtrace_args, set_backtrace_nargs)
2426 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
2427 (backtrace_next): New functions.
2428 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
2429 (unwind_to_catch, internal_lisp_condition_case)
2430 (internal_condition_case, internal_condition_case_1)
2431 (internal_condition_case_2, internal_condition_case_n): Don't bother
2432 with backtrace_list any more.
2433 (Fsignal): Adjust to new backtrace format.
2434 (grow_specpdl): Move up.
2435 (record_in_backtrace): New function.
2436 (eval_sub, Ffuncall): Use it.
2437 (apply_lambda): Adjust to new backtrace format.
2438 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
2439 data.c.
2440 (specbind): Adjust to new specpdl format. Simplify.
2441 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
2442 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
2443 backtrace format.
2444 (mark_backtrace): Remove.
2445 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
2446 * xdisp.c (redisplay_internal): Use record_in_backtrace.
2447 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
2448 Use mark_specpdl.
2449 * profiler.c (record_backtrace): Use get_backtrace.
2450 (handle_profiler_signal): Use backtrace_top_function.
2451 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
2452 accessor functions.
2453
c0342369
JD
24542013-06-02 Jan Djärv <jan.h.d@swipnet.se>
2455
2456 * process.h (catch_child_signal): Declare.
2457
2458 * process.c (catch_child_signal): New function.
2459 (init_process_emacs): Call it.
2460
2461 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
2462 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
2463 NS_IMPL_COCOA.
2464 (x_set_cursor_type): Remove declaration.
2465 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
2466 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
2467 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
2468 (ns_get_color): Use F suffix on float.
2469 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
2470 (ns_get_rgb_color): Remove.
2471 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
2472 (note_mouse_movement): x and y are CGFloat.
2473 (ns_draw_fringe_bitmap): Remove unused rowY.
2474 Change #if to COCOA && >= 10_6.
2475 (ns_draw_window_cursor): Remove unused overspill.
2476 (ns_draw_underwave): width and x are EamcsCGFloat.
2477 (ns_draw_box): thickness is CGFloat.
2478 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
2479 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
2480 if not in main thread.
2481 (ns_get_pending_menu_title, ns_check_menu_open)
2482 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
2483 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
2484 (sendFromMainThread:): New method.
2485 (changeFont:): size is CGFloat.
2486 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
2487 Disable warning about permanent text.
2488 (characterIndexForPoint:): Adjust return type depending on GNUStep
2489 version.
2490 (mouseDown:): delta is CGFloat.
2491 (updateFrameSize): Remove unised variable f.
2492 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
2493 Cast float to EmacsCGFloat.
2494 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
2495 also to -1 when restoring.
2496 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
2497 inside NS_IMPL_COCOA.
2498 (toggleFullScreen:): Put call to toggleFullScreen inside
2499 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
2500 (setPosition:portion:whole:): por is CGFloat.
2501 (getMouseMotionPart:window:x:y:): Add F suffix to float.
2502 (mouseDown:): Use CGFloat.
2503 (mouseDragged:): Remove unised variable edge.
2504 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
2505
2506 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
2507 of CGFloat differs.
2508 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
2509 when NS_IMPL_GNUSTEP.
2510 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
2511 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
2512 (EmacsToolbar): Add clearAll. Add tag argument to
2513 addDisplayItemWithImage.
2514 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
2515
2516 * nsselect.m (ns_get_local_selection): Remove unused variable type.
2517
2518 * nsmenu.m (ns_update_menubar): Make static.
2519 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
2520 (fillWithWidgetValue:): Add cast to SEL for setAction.
2521 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
2522 (update_frame_tool_bar): Update code for GNUStep.
2523 (clearAll): New method.
2524 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 2525 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 2526 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
2527 call to insertItemWithItemIdentifier.
2528 (validateVisibleItems): Fix indentation.
2529 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
2530 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
2531 UtilityWindow to aStyle, remove call to setStyleMask.
2532
2533 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
2534
2535 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
2536 (ns_charset_covers, ns_get_covering_families, nsfont_open):
2537 Use F suffix on floats.
2538 (ns_char_width): Returns CGFloat.
2539 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 2540 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
2541 DPSxshow.
2542 (ns_glyph_metrics): CGFloat instead of float.
2543
a0eb10b3
JB
2544 * nsfns.m (x_set_foreground_color, x_set_background_color):
2545 Use EmacsCGFloat.
2546 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
2547 remove unused variables.
2548 (Fns_read_file_name): Keep track if panel is for save.
2549 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 2550 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
2551 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
2552 Just return the input if GNUStep.
c0342369
JD
2553 (x_screen_planes): Remove.
2554 (Fxw_color_values): Use EmacsCGFloat
2555 (Fns_display_monitor_attributes_list): Only get screen number for
2556 Cocoa.
ef099a94 2557 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
2558 EmacsSavePanel.
2559 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
2560 ns_directory_from_panel.
2561
da9aff11
PE
25622013-06-01 Paul Eggert <eggert@cs.ucla.edu>
2563
2564 * process.c (handle_child_signal): Also use WCONTINUED.
2565 This is so that list-processes doesn't mistakenly list the process
2566 as stopped, when the process has actually been continued and is
2567 now running.
2568
0e64479a
PE
25692013-05-31 Paul Eggert <eggert@cs.ucla.edu>
2570
fc186a96
PE
2571 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
2572 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
2573 not already configured.
2574
0e64479a
PE
2575 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
2576
38b787fa
EZ
25772013-05-29 Eli Zaretskii <eliz@gnu.org>
2578
2579 * Makefile.in (mostlyclean): Remove *.res files.
2580
22513e52
SM
25812013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
2582
2583 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
2584 a buffer (bug#8447).
2585
6ef3db10
EZ
25862013-05-27 Eli Zaretskii <eliz@gnu.org>
2587
2588 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
2589 display vector, and we backtrack, handle the case that the
2590 previous character position is also displayed from a display
2591 vector or covered by a display string or image. (Bug#14476)
2592
6799bb26
JD
25932013-05-25 Jan Djärv <jan.h.d@swipnet.se>
2594
2595 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
2596 (struct MonitorInfo, free_monitors): Remove.
2597 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
2598 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
2599 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
2600 Qframes, Qsource.
2601
2602 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
2603 (struct MonitorInfo, free_monitors): Remove.
2604 (ns_screen_name): Make static.
2605 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
2606 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
2607 Qframes, Qsource.
2608
2609 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
2610 (struct MonitorInfo): New struct.
2611 (free_monitors, make_monitor_attribute_list): Declare.
2612
22513e52
SM
2613 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
2614 New Lisp_Object:s.
6799bb26
JD
2615 (free_monitors, make_monitor_attribute_list): New functions.
2616 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
2617 Qsource.
2618
38cd43eb
XF
26192013-05-25 Xue Fuqiao <xfq.free@gmail.com>
2620
2621 * callproc.c (call_process): Refine the doc string. (Bug#14045)
2622
2af0948d
SM
26232013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
2624
a7eb9b0f
SM
2625 * keyboard.c: Apply keyboard decoding only to events that come directly
2626 from the tty, not from unread-command-events (bug#14368).
2627 (read_event_from_main_queue): New function, extracted from read_char).
2628 (read_decoded_char): Remove.
2629 (read_decoded_event_from_main_queue): New function to replace it.
2630 (read_char): Use it.
2631 (read_key_sequence): Use read_char rather than read_decoded_char.
2632
2af0948d
SM
2633 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
2634
1413e9a5
BR
26352013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
2636
2637 * casetab.c (init_casetab_once): Fix last change (bug#14424).
2638
e6d2f155
KH
26392013-05-22 Kenichi Handa <handa@gnu.org>
2640
2641 The following changes are to fix the setting of
2642 buffer-file-coding-system on, for instance, C-x RET c unix RET
2643 _FILE_OF_DOS_EOL_TYPE_ RET.
2644
2645 * coding.h (struct coding_system): New member detected_utf8_chars.
2646
2647 * coding.c (detect_coding_utf_8): Count characters and check EOL
2648 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
2649 BOM is there.
2650 (setup_coding_system): Do not initialize coding->head_ascii.
2651 (check_ascii): Do not set coding->eol_seen but update it. Do not
2652 call adjust_coding_eol_type here.
1413e9a5
BR
2653 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
2654 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
2655 of the found coding-system.
2656 (decode_coding_gap): Cancel previous change. Utilize the
2657 character numbers counted by detect_coding_utf_8. Fix detection
2658 of BOM for utf-8.
2659
ab56a6f4 26602013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
2661
2662 * search.c (looking_at_1): Only set last_thing_searched if the match
2663 changed the match-data (bug#14281).
2664
ecc3c6ed
DA
26652013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
2666
2667 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 2668 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
2669 (move_it_vertically_backward): Likewise.
2670
5ba8bf35
YM
26712013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2672
2673 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 2674 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
2675 (Fx_display_mm_width, Fx_display_mm_height):
2676 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 2677
91e8418b 2678 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 2679 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
2680 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
2681 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
2682 (Fx_display_backing_store, Fx_display_visual_class)
2683 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
2684 (Fx_display_grayscale_p, Fx_display_pixel_width)
2685 (Fx_display_pixel_height, Fx_display_planes)
2686 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
2687 (Fx_display_screens): Don't confuse X11 screens with NS screens.
2688 (Fx_display_mm_width, Fx_display_mm_height)
2689 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
2690 height for all physical monitors as in X11.
2691
fc30d803
SM
2692 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
2693 Return pixel width or height for all physical monitors as in X11.
91e8418b 2694
31ff141c
PE
26952013-05-18 Paul Eggert <eggert@cs.ucla.edu>
2696
2697 Port --enable-gcc-warnings to clang.
2698 * bytecode.c (exec_byte_code):
2699 * regex.c:
2700 Redo diagnostic pragmas to pacify clang, too.
2701 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
2702 * editfns.c (Fencode_time):
2703 * fileio.c (file_accessible_directory_p):
2704 * font.c (font_unparse_xlfd):
2705 Use '&"string"[index]' instead of '"string" + (index)'.
2706 * undo.c (user_error): Remove; unused.
2707
df065a0b
EZ
27082013-05-16 Eli Zaretskii <eliz@gnu.org>
2709
04d360e7
EZ
2710 * insdel.c (insert_1_both): Document the arguments, instead of
2711 referring to insert_1, which no longer exists.
2712
5bb98290
EZ
2713 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
2714 some window, increment windows_or_buffers_changed, so that
2715 *Messages* display in that window is updated. (Bug#14408)
2716
df065a0b
EZ
2717 * w32.c: Include epaths.h.
2718 (init_environment): Use cmdproxy.exe without leading directories.
2719 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
2720 case.
2721 (gettimeofday): Adjust signature and return value to Posix
2722 expectations.
2723
2724 * unexw32.c (open_output_file): Delete the existing emacs.exe
2725 before creating it, to break the hard link to the versioned
2726 executable.
2727
2728 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
2729 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
2730 (FIRSTFILE_OBJ): New variables.
2731 (W32_RES): Rename to EMACSRES. All users changed.
2732 (base_obj): Use $(CM_OBJ).
2733 (ALLOBJS): Use $(FIRSTFILE_OBJ).
2734 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
2735 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
2736 $(W32_RES_LINK) before $(LIBES).
2737 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
2738
1aa8d505
SM
27392013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2740
6e911150
SM
2741 * makefile.w32-in (DOC): Use just "DOC".
2742
2743 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
2744
1aa8d505
SM
2745 * process.c: Export default filters and sentinels to Elisp.
2746 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
2747 New constants.
2748 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
2749 (Fset_process_sentinel, Fformat_network_address):
2750 Default to them instead of nil.
2751 (server_accept_connection): Sentinels can't be nil any more.
2752 (read_and_dispose_of_process_output): New function, extracted from
2753 read_process_output.
2754 (read_process_output): Use it; filters can't be nil.
2755 (Finternal_default_process_filter): New function, extracted from
2756 read_process_output.
2757 (exec_sentinel_unwind): Remove function.
2758 (exec_sentinel): Don't zilch sentinel while running.
2759 (status_notify): Sentinels can't be nil.
2760 (Finternal_default_process_sentinel): New function extracted from
2761 status_notify.
2762 (setup_process_coding_systems): Default filter is not nil any more.
2763 (syms_of_process): Export new Elisp functions and initialize
2764 new constants.
2765 * lisp.h (make_lisp_proc): New function.
2766
5ac2eb34
SM
27672013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2768
2769 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
2770
eda9c7d7
EZ
27712013-05-14 Eli Zaretskii <eliz@gnu.org>
2772
2773 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
2774 unless we know that the window w is a leaf window.
2775 Another attempt at solving bug#14062.
eda9c7d7 2776
8fdeaad5
JD
27772013-05-14 Jan Djärv <jan.h.d@swipnet.se>
2778
2779 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
2780 fdesc (Bug#14375).
2781
44aa9ee6
PE
27822013-05-12 Paul Eggert <eggert@cs.ucla.edu>
2783
2784 * image.c (gif_load): Check that subimages fit (Bug#14345).
2785
759fd763
SM
27862013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
2787
2788 * lread.c (skip_dyn_eof): New function.
2789 (read1): Use it to skip the end of a file in response to #@00.
2790
2791 * doc.c (get_doc_string): Slightly relax the sanity checking.
2792
4465bfb4
JD
27932013-05-09 Jan Djärv <jan.h.d@swipnet.se>
2794
2795 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
2796 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
2797 (MonitorInfo): New struct.
2798 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
2799 (Fns_display_monitor_attributes_list): New functions.
2800 (display-usable-bounds): Remove.
2801 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
2802 Qsource.
2803
7583e2a0
PE
28042013-05-09 Paul Eggert <eggert@cs.ucla.edu>
2805
2806 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
2807 (GTK_CHECK_VERSION): New macro, if not already defined.
2808 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
2809 replaced by GTK_CHECK_VERSION.
2810
ad75d77e
PE
28112013-05-08 Paul Eggert <eggert@cs.ucla.edu>
2812
2813 * xterm.h (GTK_PREREQ): New macro.
2814 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
2815 to use this macro instead, for consistency and clarity.
2816
07525f77
EZ
28172013-05-08 Eli Zaretskii <eliz@gnu.org>
2818
2819 * xdisp.c (row_for_charpos_p): New function, with code of
2820 cursor_row_p, but accepts an additional argument CHARPOS instead
2821 of using a hardcoded PT.
2822 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
2823 (row_containing_pos): Call row_for_charpos_p instead of partially
2824 doing the same. Fixes cursor positioning under longlines-mode
2825 when longlines-show-effect includes more than one newline, when
2826 moving the cursor vertically up.
2827
d901fc8d
JB
28282013-05-08 Juanma Barranquero <lekktu@gmail.com>
2829
2830 * makefile.w32-in (ACL_H): New macro.
2831 ($(BLD)/fileio.$(O)): Update dependencies.
2832
f269bc61
PE
28332013-05-07 Paul Eggert <eggert@cs.ucla.edu>
2834
e7b41c4c 2835 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
2836 * Makefile.in (LIB_ACL): New macro.
2837 (LIBACL_LIBS): Remove.
2838 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
2839 * fileio.c: Include <acl.h>.
2840 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
2841 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
2842 !acl_errno_valid.
2843 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
2844 it ourselves.
2845
f269bc61
PE
2846 * unexelf.c: Don't assume ElfW (Half) fits in int.
2847 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
2848 when dealing with ElfW (Half) values, since they can exceed 2**31
2849 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
2850 (entry_address): Omit unused NUM arg. All uses changed.
2851
a261c53e
JL
28522013-05-07 Juri Linkov <juri@jurta.org>
2853
2854 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
2855 to the string converted from number with `Fnumber_to_string'.
2856 (Bug#14254)
2857
2b66427d
PE
28582013-05-07 Paul Eggert <eggert@cs.ucla.edu>
2859
2860 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
2861 This fixes a problem introduced by my previous change.
2862
15acfe41
GM
28632013-05-07 Glenn Morris <rgm@gnu.org>
2864
2865 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
2866
5ea03bf5
JD
28672013-05-07 Jan Djärv <jan.h.d@swipnet.se>
2868
2869 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
2870
e0c9d565
PE
28712013-05-07 Paul Eggert <eggert@cs.ucla.edu>
2872
2873 Static checking by GCC 4.8.0.
2874 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
2875 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
2876 (x_get_monitor_attributes_fallback)
2877 (x_get_monitor_attributes_xinerama)
2878 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
2879 Define only if USE_GTK.
2880 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
2881 (x_get_monitor_attributes_fallback): Omit unused locals.
2882 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
2883 Use double, not float, to avoid mixed-mode floating point arithmetic.
2884
4e3f9230
YM
28852013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2886 Jan Djärv <jan.h.d@swipnet.se>
2887
2888 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
2889 (XINERAMA_CFLAGS): New macros.
2890 (ALL_CFLAGS, LIBES): Use them.
2891
2892 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
2893 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
2894 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
2895 (syms_of_xfns): DEFSYM them.
2896 (struct MonitorInfo): New struct.
2897 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
2898 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
2899 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
2900 (x_get_monitor_attributes_xinerama): New functions.
2901 (Fx_display_monitor_attributes_list): New primitive.
2902 (syms_of_xfns): Defsubr it.
2903
2904 * xterm.h (x_display_info): Add Xatom_net_workarea and
2905 Xatom_net_current_desktop.
2906
2907 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
2908 and dpyinfo->Xatom_net_current_desktop.
2909
05839b6a
EZ
29102013-05-06 Eli Zaretskii <eliz@gnu.org>
2911
2912 * xdisp.c (pos_visible_p): Use the special code for finding the
2913 beginning of a display property or overlay for any "replacing"
2914 display property, not just for display strings. This solves
2915 incorrect reporting of position by posn-at-point. (Bug#14241)
2916
dc4a2ee0
PE
29172013-05-06 Paul Eggert <eggert@cs.ucla.edu>
2918
5ee94506
PE
2919 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
2920 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
2921 Verify that ElfW (Half) fits in int.
2922 (fatal): Use same signature as lisp.h.
2923 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
2924 configure and build with -DUNEXELF_DEBUG without worrying about
2925 other modules that use DEBUG.
2926 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
2927 possibly-wide integers now uses it instead of plain fprintf.
2928 (entry_address): New function, which avoids problems with 32-bit
2929 overflow on 64-bit hosts.
2930 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
2931 (round_up): Don't assume the remainder fits in int.
2932 (find_section): Use bool for boolean. Simplify debug code.
2933 (unexec): Don't assume file sizes fit in int or size_t.
2934 Omit unnecessary trailing newline in 'fatal' format.
2935 Use strerror rather than outputting decimal error number.
2936 Remove unused code when emacs is not defined;
2937 this file relies on Emacs now.
2938 Don't assume e_phnum and e_shnum are positive.
2939
dc4a2ee0
PE
2940 * regex.c: Fix problems when DEBUG is defined.
2941 (extract_number, extract_number_and_incr): Define regardless of
2942 whether DEBUG is defined; that's simpler and makes the code less
2943 likely to go stale in the normal case when DEBUG is not defined.
2944 Return int rather than taking an int * arg. All callers changed.
2945 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
2946 Remove, replacing with ...
2947 (DEBUG_PRINT): New macro. All callers changed.
2948 (DEBUG_COMPILES_ARGUMENTS): New macro.
2949 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
2950 (print_compiled_pattern, print_double_string) [DEBUG]:
2951 Use prototype rather than old-style definition.
2952 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
2953 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
2954 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
2955 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
2956 Don't assume ptrdiff_t, size_t, and long are the same width as int.
2957 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
2958 This matters only when DEBUG is defined.
2959
14c7ed05
EZ
29602013-05-05 Eli Zaretskii <eliz@gnu.org>
2961
2962 * xdisp.c (set_iterator_to_next): Set the
2963 ignore_overlay_strings_at_pos_p flag only if we are _really_
2964 iterating over an overlay string, as indicated by the
2965 current.overlay_string_index member. (Bug#14306)
2966
e6076b1b
JD
29672013-05-05 Jan Djärv <jan.h.d@swipnet.se>
2968
2969 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
2970 to where it is used, to avoid autorelease issues (Bug#14050).
2971
cbee2131
PE
29722013-05-05 Paul Eggert <eggert@cs.ucla.edu>
2973
2974 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
2975 * fileio.c (syms_of_fileio): Implement this.
2976 * filelock.c (create_lock_file): If symbolic links don't work, so
2977 we use a regular file as a lock file, do not fsync the lock file;
2978 it's not needed.
2979
30c7e542
SM
29802013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2981
2982 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
2983 (syms_of_minibuf): Adjust accodingly.
2984 * lread.c (Fread):
2985 * callint.c (Fcall_interactively): Adjust calls accordingly.
2986
5bebd186
EZ
29872013-05-04 Eli Zaretskii <eliz@gnu.org>
2988
2989 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
2990 w->contents is a buffer before computing everything else.
2991 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
2992
2993 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
2994 assertion violations. (Bug#14062)
2995
0fb0a4f3
DR
29962013-05-01 David Reitter <david.reitter@gmail.com>
2997
2998 * nsfns.m (ns_tooltip): Initialize.
2999
9e63b4a5
EZ
30002013-04-28 Eli Zaretskii <eliz@gnu.org>
3001
3002 * coding.c (decode_coding_gap): Don't remove the character before
3003 a newline unless it's a CR character. (Bug#14287)
3004
ad60824e
DN
30052013-04-28 Dan Nicolaescu <dann@gnu.org>
3006
3007 * dispextern.h (struct face): Move enum face_underline_type
3008 earlier so that bitfields can be in the same word.
3009
edbdcec0
JD
30102013-04-28 Jan Djärv <jan.h.d@swipnet.se>
3011
3012 * nsfns.m (handlePanelKeys): New function.
3013 (EmacsOpenPanel:performKeyEquivalent:)
3014 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
3015 arrows/function/control and copy/paste keys (Bug#14296).
3016
0208ede7
JL
30172013-04-27 Juri Linkov <juri@jurta.org>
3018
3019 * callint.c (Fcall_interactively): Call `Qread_number' for
3020 interactive code letter `n' instead of using duplicate code.
3021 (Bug#14254)
3022
b8dd59f7
PE
30232013-04-27 Paul Eggert <eggert@cs.ucla.edu>
3024
3025 * systime.h (make_timeval): Declare as 'const'.
3026
8bd722db
KH
30272013-04-27 Kenichi Handa <handa@gnu.org>
3028
3029 * font.c (font_open_entity): Always open a font of manageable
3030 size.
3031
13d0e56f 30322013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 3033
f780d632
PE
3034 Port better to AIX (Bug#14258).
3035 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
3036 to pacify AIX xlc.
3037
ec509856
KH
30382013-04-24 Kenichi Handa <handa@gnu.org>
3039
3040 * coding.c (decode_coding_iso_2022): When an invalid escape
3041 sequence is encountered, reset the invocation and designation
3042 status to the safest one.
3043
84fc48e5
PE
30442013-04-22 Paul Eggert <eggert@cs.ucla.edu>
3045
3046 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
3047 Without this fix, "make distclean" leaves stamp-h1 behind.
3048
806bda47
EC
30492013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
3050
3051 * w32fns.c (w32_fullscreen_rect): New function to compute the
3052 window rectangle for the given fullscreen mode.
3053 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
3054 longer tunes the window size. This keeps the window's edges flush
3055 with the screen and allows the taskbar to hide itself in fullboth.
3056
3057 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
3058 window decorations and uses the entire screen.
3059
3060 * w32term.h (w32_fullscreen_rect) Add prototype.
3061 (struct w32_output): Replace normal_width, normal_height,
3062 normal_top, and normal_left members with a single normal_placement
3063 struct.
3064 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
3065 Remove macros.
3066 (FRAME_NORMAL_PLACEMENT): New macro.
3067
9cc2810b
JB
30682013-04-16 Juanma Barranquero <lekktu@gmail.com>
3069
3070 * minibuf.c (Ftest_completion): Silence compiler warning.
3071
fd16b54c
EZ
30722013-04-15 Eli Zaretskii <eliz@gnu.org>
3073
3074 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 3075 bug#14062.
fd16b54c
EZ
3076
3077 * frame.h (WINDOW_FRAME): Protect macro and its argument with
3078 parentheses.
3079
3080 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
3081 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
3082 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
3083 parentheses where appropriate.
3084
9e3379a0
PE
30852013-04-14 Paul Eggert <eggert@cs.ucla.edu>
3086
3087 * keyboard.c (timer_start_idle): Remove no-longer-used local.
3088
ddd6b685
EZ
30892013-04-14 Eli Zaretskii <eliz@gnu.org>
3090
3091 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
3092 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
3093 Mention in the doc string that setting these variables takes
3094 effect only after a call to set-window-buffer. (Bug#14200)
3095
29b79ba1
EZ
30962013-04-13 Eli Zaretskii <eliz@gnu.org>
3097
3098 * indent.c (Fvertical_motion): Don't consider display strings on
3099 overlay strings as display strings on the buffer position we
3100 started from. This prevents vertical cursor motion from jumping
3101 more than one line when there's an overlay string with a display
3102 property at end of line.
3103 Reported by Karl Chen <Karl.Chen@quarl.org> in
3104 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
3105
562c6ee9
SM
31062013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
3107
3108 * window.c (select_window): `record_buffer' even if window is
3109 already selected (bug#14191).
3110
fcc1fe85
EZ
31112013-04-11 Eli Zaretskii <eliz@gnu.org>
3112
3113 * window.c (Fwindow_end): Test more flags, including the buffer's
3114 last_overlay_modified flag, to determine whether the window's
3115 display is really up-to-date. Prevents the function from
3116 returning a stale value. (Bug#14170)
3117 (Fwindow_line_height): Fix the test for up-to-date-ness of the
3118 current matrix.
3119
f009190a
EZ
31202013-04-10 Eli Zaretskii <eliz@gnu.org>
3121
3122 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
3123 garbaged only if it is not already the top frame on its TTY.
3124 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
3125 there are GUI frames open in the same session. (Bug#13864)
3126
78ce603d
SM
31272013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
3128
3129 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
3130 of marking the idle timers directly.
3131
a8036e40
SM
31322013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
3133
3134 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
3135 tables (bug#14054).
3136
7ffe7ef6
SM
31372013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
3138
3139 * window.c (select_window): Don't record_buffer while the invariant is
3140 temporarily broken (bug#14161).
3141
3142 * fns.c (Fdelq): Don't assume !NILP => CONSP.
3143
7d9f6883
EZ
31442013-04-07 Eli Zaretskii <eliz@gnu.org>
3145
3146 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
3147
5406cfd9
RF
31482013-04-07 Romain Francoise <romain@orebokech.com>
3149
3150 Ignore additional platform-specific ACL errors (Bug#13702).
3151 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
3152 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
3153
95c0e83b
JD
31542013-03-31 Jan Djärv <jan.h.d@swipnet.se>
3155
3156 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
3157 f->output_data.ns.
3158
876da980
PE
31592013-04-07 Paul Eggert <eggert@cs.ucla.edu>
3160
3161 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
3162 This bug was introduced by my 2013-02-25 change that simplified
3163 data_start configuration. Without this change, on GNU/Linux
3164 an Emacs configured with --enable-profiling fails immediately
3165 due to a profiler signal.
3166 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
3167 with these flags. On platforms where special flags are needed
3168 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
3169 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
3170 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
3171
7452b7bd
DA
31722013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
3173
3174 Get rid of some platform-specific functions examining window
3175 system and its capabilities. This is a partial rework of the
3176 2013-04-05 change.
3177 * lisp.h (have_menus_p): Remove prototype. This function is
3178 replaced with platform-independent window_system_available.
3179 (check_window_system): Move to...
3180 * frame.h (decode_window_system_frame, window_system_available):
3181 ...here, add new prototypes.
3182 * frame.c (window_system_available, decode_window_system_frame):
3183 New functions.
3184 (check_window_system): Platform-independent now.
3185 * xterm.h (x_in_use): Remove declaration.
3186 (check_x_frame):
3187 * w32term.h (check_x_frame):
3188 * nsterm.h (check_x_frame): Remove prototypes. This function
3189 is replaced with platform-independent decode_window_system_frame.
3190 * msdos.c (have_menus_p): Remove.
3191 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
3192 Remove platform-specific functions. Use check_window_system,
3193 decode_window_system_frame and check_ns_display_info where
3194 appropriate. Minor style and comment tweaks.
3195 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
3196 (check_x_frame): Likewise.
3197 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
3198 Likewise.
3199 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
3200 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
3201 * xmenu.c, xselect.c: All related users changed.
3202
251e9147
KH
32032013-04-03 Kenichi Handa <handa@gnu.org>
3204
3205 The following changes is to optimize the code for reading UTF-8
3206 files.
3207
562c6ee9 3208 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
3209 changed. Check EOL format. Do not call adjust_coding_eol_type
3210 here.
3211 (check_utf_8): New function.
3212 (adjust_coding_eol_type): Do nothing if already adjusted.
3213 (detect_coding): Compare the return value of check_ascii with
3214 coding->src_bytes. Call adjust_coding_eol_type if necessary.
3215 (decode_coding_gap): Optimize for valid UTF-8.
3216
8bc369d4
KH
32172013-03-21 Kenichi Handa <handa@gnu.org>
3218
3219 * coding.c (syms_of_coding): Cancel previous change.
3220
3221 * insdel.c (insert_from_gap): Fix previous change.
3222
73931ad1
DA
32232013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
3224
3225 Consistently use platform-specific function to detect window system.
3226 * lisp.h (check_window_system): New prototype. This function is
3227 going to replace check_x, check_w32 and check_ns.
3228 (have_menus_p): Mention msdos.c in comment.
3229 * fontset.c (check_window_system_func): Remove. Adjust all users.
3230 * fontset.h (check_window_system_func): Remove prototype.
3231 * nsterm.h (check_ns):
3232 * xterm.h (check_x):
3233 * w32term.h (check_w32): Likewise.
3234 * menu.c (Fx_popup_menu): Use check_window_system.
3235 * msdos.c (check_window_system): Define for MS-DOS.
3236 * nsfns.m (check_window_system): Define for NS. Adjust all users.
3237 * w32fns.c (check_window_system): Likewise for MS-Windows.
3238 * xfns.c (check_window_system): Likewise for X.
3239 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
3240 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
3241
7216e43b
PE
32422013-04-02 Paul Eggert <eggert@cs.ucla.edu>
3243
3244 Prefer < to > in range checks such as 0 <= i && i < N.
3245 This makes it easier to visualize quantities on a number line.
3246 This patch doesn't apply to all such range checks,
3247 only to the range checks affected by the 2013-03-24 change.
3248 This patch reverts most of the 2013-03-24 change.
3249 * alloc.c (xpalloc, Fgarbage_collect):
3250 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
3251 * character.c (string_escape_byte8):
3252 * charset.c (read_hex):
3253 * data.c (cons_to_unsigned):
3254 * dispnew.c (update_frame_1):
3255 * doc.c (Fsubstitute_command_keys):
3256 * doprnt.c (doprnt):
3257 * editfns.c (hi_time, decode_time_components):
3258 * fileio.c (file_offset):
3259 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
3260 * font.c (font_intern_prop):
3261 * frame.c (x_set_alpha):
3262 * gtkutil.c (get_utf8_string):
3263 * indent.c (check_display_width):
3264 * keymap.c (Fkey_description):
3265 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
3266 * lread.c (read1):
3267 * minibuf.c (read_minibuf_noninteractive):
3268 * process.c (wait_reading_process_output):
3269 * search.c (Freplace_match):
3270 * window.c (get_phys_cursor_glyph):
3271 * xdisp.c (redisplay_internal):
3272 * xsmfns.c (smc_save_yourself_CB):
3273 Prefer < to > for range checks.
3274 * dispnew.c (sit_for): Don't mishandle NaNs.
3275 This fixes a bug introduced in the 2013-03-24 change.
3276 * editfns.c (decode_time_components): Don't hoist comparison.
3277 This fixes another bug introduced in the 2013-03-24 change.
3278
92759988
DA
32792013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
3280
3281 * frame.h (struct frame): Drop scroll_bottom_vpos
3282 member becaue all real users are dead long ago.
3283 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
3284 * xdisp.c (redisplay_internal): Adjust user.
3285
9a1971bb
GM
32862013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
3287
f38ab167
JD
3288 * nsmenu.m (showAtX:Y:for:): setLevel to
3289 NSPopUpMenuWindowLevel (Bug#13998).
3290
6d01f1fe
JD
32912013-03-30 Jan Djärv <jan.h.d@swipnet.se>
3292
3293 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
3294 (ns_check_pending_open_menu): Declare.
3295
3296 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
3297 (x_activate_menubar): Update the menu with title that matches
3298 ns_get_pending_menu_title, and call
3299 ns_check_pending_openmenu (Bug#12698).
3300 (menuWillOpen:): New method.
3301 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
3302
3303 * nsterm.m (menu_will_open_state, menu_mouse_point)
3304 (menu_pending_title): New varaibles.
3305 (ns_get_pending_menu_title, ns_check_menu_open)
3306 (ns_check_pending_open_menu): New functions.
3307
781f4782
DA
33082013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
3309
3310 * indent.c (current_column_bol_cache): Remove leftover which is not
3311 used in Fmove_to_column any more.
3312 (current_column, scan_for_column): Adjust users.
3313 * keyboard.c (last_point_position_buffer, last_point_position_window):
3314 Remove leftovers which are not used for recording undo any more.
3315 (command_loop_1, syms_of_keyboard): Adjust users.
3316 * xdisp.c (last_max_ascent): Remove leftover which is not used in
3317 redisplay_window any more.
3318 (move_it_to): Adjust user.
3319
1921c31b
JB
33202013-03-29 Juanma Barranquero <lekktu@gmail.com>
3321
3322 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
3323 Update dependencies.
3324
717b8bcd
SM
33252013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3326
3327 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
3328 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
3329 forward references.
3330
e74aeda8
DA
33312013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
3332
3333 * window.h (struct window): Replace hchild, vchild and buffer slots
3334 with the only contents slot. This is possible because each valid
3335 window may have either the child window (in vertical or horizontal
3336 combination) or buffer to display (for the leaf window). Using that,
3337 a lof of operations to traverse and/or change window hierarchies may
3338 be simplified. New member horizontal is used to distinguish between
3339 horizontal and vertical combinations of internal windows.
3340 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
3341 (WINDOW_VERTICAL_COMBINATION_P): New macros.
3342 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
3343 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
3344 Use contents slot, not buffer, where appropriate.
3345 (wset_combination): New function.
3346 (wset_buffer): Add eassert.
3347 (Fframe_first_window): Simplify the loop reaching first window.
3348 (Fwindow_buffer): Use WINDOW_LEAF_P.
3349 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
3350 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
3351 (unshow_buffer): Convert initial debugging check to eassert.
3352 (replace_window, recombine_windows, Fdelete_other_windows_internal)
3353 (make_parent_window, window_resize_check, window_resize_apply)
3354 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
3355 (Fset_window_configuration, delete_all_child_windows, save_window_save):
3356 Adjust to match struct window changes.
3357 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
3358 (mark_window_cursors_off, count_windows, get_leaf_windows)
3359 (foreach_window_1): Simplify the loop.
3360 * alloc.c (mark_object): Do not check for the leaf window because
3361 internal windows has no glyph matrices anyway.
3362 * dispnew.c (clear_window_matrices, showing_window_margins_p)
3363 (allocate_matrices_for_window_redisplay, fake_current_matrices)
3364 (allocate_matrices_for_frame_redisplay, free_window_matrices)
3365 (build_frame_matrix_from_window_tree, mirror_make_current)
3366 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
3367 (update_window_tree, set_window_update_flags): Simplify the loop.
3368 (sync_window_with_frame_matrix_rows): Enforce live window.
3369 Use contents slot, not buffer, where appropriate.
3370 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
3371 and WINDOW_HORIZONTAL_COMBINATION_P.
3372 (make_frame_visible_1): Simplify the loop.
3373 Use contents slot, not buffer, where appropriate.
3374 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
3375 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
3376 (expose_window_tree): Likewise.
3377 Use contents slot, not buffer, where appropriate.
3378 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
3379 to avoid deleted windows. Use contents slot instead of buffer.
3380 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
3381 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
3382 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
3383 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
3384
121ab1cd
EZ
33852013-03-28 Eli Zaretskii <eliz@gnu.org>
3386
ef454cf7
EZ
3387 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
3388 identify the reasons for assertion violations in bug#14062 and
3389 similar ones.
21e930f8
EZ
3390 (Fx_show_tip): Fix compilation error under
3391 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 3392
121ab1cd
EZ
3393 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
3394 Reported by <rzl24ozi@gmail.com>.
3395
5c89ca24
DA
33962013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
3397
3398 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
3399 start marker...
562c6ee9
SM
3400 (unwind_with_echo_area_buffer): ...to restore it here.
3401 This is needed to ensure that...
5c89ca24
DA
3402 (redisplay_window): ...both window markers are valid here,
3403 which is verified by eassert.
3404 * editfns.c (save_excursion_save): Do not assume that
3405 selected_window always displays the buffer.
c7f53895
DA
3406 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
3407 Fix comment.
5c89ca24 3408
f557c1b1
SM
34092013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
3410
3411 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
3412 the upcase table.
3413
40693bba 34142013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
3415
3416 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
3417
c86f791f
EZ
34182013-03-27 Eli Zaretskii <eliz@gnu.org>
3419
3420 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
3421 since MinGW's w32api headers do. This avoids compiler warnings.
3422
3423 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
3424 if already defined.
3425
c6e72e17
EZ
34262013-03-26 Eli Zaretskii <eliz@gnu.org>
3427
3428 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
3429
54e95010
JD
34302013-03-26 Jan Djärv <jan.h.d@swipnet.se>
3431
3432 * gtkutil.c (style_changed_cb): Check if frame is live and an
3433 X frame (Bug#14038).
3434
b88b62de
EZ
34352013-03-26 Eli Zaretskii <eliz@gnu.org>
3436
a18d7de6
EZ
3437 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
3438 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
3439 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
3440 MinGW64.
8f5e14c8
EZ
3441 Move inclusion of time.h before sys/time.h, so that MinGW64 could
3442 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 3443
b88b62de
EZ
3444 Fix incompatibilities between MinGW.org and MinGW64 headers.
3445 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
3446
3447 * w32.c (REPARSE_DATA_BUFFER): Guard with
3448 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
3449
c074e458
JD
34502013-03-25 Jan Djärv <jan.h.d@swipnet.se>
3451
3452 * xterm.c: Include X11/XKBlib.h
3453 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
3454
908589fd
AS
34552013-03-24 Andreas Schwab <schwab@linux-m68k.org>
3456
3457 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
3458 written backwards.
3459 * blockinput.h (input_blocked_p): Likewise.
3460 * bytecode.c (exec_byte_code): Likewise.
3461 * callproc.c (call_process_kill, call_process_cleanup)
3462 (Fcall_process): Likewise.
3463 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
3464 (Fccl_execute_on_string): Likewise.
3465 * character.c (string_escape_byte8): Likewise.
3466 * charset.c (read_hex): Likewise.
3467 * cm.c (calccost): Likewise.
3468 * data.c (cons_to_unsigned): Likewise.
3469 * dired.c (directory_files_internal, file_name_completion):
3470 Likewise.
3471 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
3472 (sit_for): Likewise.
3473 * doc.c (Fsubstitute_command_keys): Likewise.
3474 * doprnt.c (doprnt): Likewise.
3475 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
3476 * emacsgtkfixed.c: Likewise.
3477 * fileio.c (file_offset, Fwrite_region): Likewise.
3478 * floatfns.c (Fexpt, fmod_float): Likewise.
3479 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
3480 Likewise.
3481 * font.c (font_intern_prop): Likewise.
3482 * frame.c (x_set_alpha): Likewise.
3483 * gtkutil.c (get_utf8_string): Likewise.
3484 * indent.c (check_display_width): Likewise.
3485 * intervals.c (create_root_interval, rotate_right, rotate_left)
3486 (split_interval_right, split_interval_left)
3487 (adjust_intervals_for_insertion, delete_node)
3488 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3489 (merge_interval_right, merge_interval_left, copy_intervals)
3490 (set_intervals_multibyte_1): Likewise.
3491 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
3492 * keymap.c (Fkey_description): Likewise.
3493 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
3494 * lread.c (openp, read_integer, read1, string_to_number):
3495 Likewise.
3496 * menu.c (ensure_menu_items): Likewise.
3497 * minibuf.c (read_minibuf_noninteractive): Likewise.
3498 * print.c (printchar, strout): Likewise.
3499 * process.c (create_process, Faccept_process_output)
3500 (wait_reading_process_output, read_process_output, send_process)
3501 (wait_reading_process_output): Likewise.
3502 * profiler.c (make_log, handle_profiler_signal): Likewise.
3503 * regex.c (re_exec): Likewise.
3504 * regex.h: Likewise.
3505 * search.c (looking_at_1, Freplace_match): Likewise.
3506 * sysdep.c (get_child_status, procfs_ttyname)
3507 (procfs_get_total_memory): Likewise.
3508 * systime.h (EMACS_TIME_VALID_P): Likewise.
3509 * term.c (dissociate_if_controlling_tty): Likewise.
3510 * window.c (get_phys_cursor_glyph): Likewise.
3511 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
3512 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
3513 Likewise.
3514 * xfns.c (Fx_window_property): Likewise.
3515 * xmenu.c (set_frame_menubar): Likewise.
3516 * xselect.c (x_get_window_property, x_handle_dnd_message):
3517 Likewise.
3518 * xsmfns.c (smc_save_yourself_CB): Likewise.
3519 * xterm.c (x_scroll_bar_set_handle): Likewise.
3520
2bf7d27a
DA
35212013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
3522
3523 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
3524 to be optional or nil. Adjust comment and convert it to docstring.
3525 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
3526 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
3527
a9ebfa0b
PE
35282013-03-24 Paul Eggert <eggert@cs.ucla.edu>
3529
3530 Static checking by GCC 4.8-20130319.
3531 * image.c (gif_load): Assume pass < 3 to pacify GCC.
3532 * process.c (Fset_process_datagram_address)
3533 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
3534 * xdisp.c (get_char_face_and_encoding):
3535 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
3536 (get_glyph_face_and_encoding): Prepare face before possibly using it.
3537 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
3538
4f3576ee
KB
35392013-03-24 Ken Brown <kbrown@cornell.edu>
3540
789b5e9a
KB
3541 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
3542 fix compilation on 64-bit Cygwin, where underscores are not
3543 automatically prepended.
3544
4f3576ee
KB
3545 * w32term.c (w32_initialize): Silence compiler warning.
3546
b5b7745f
EZ
35472013-03-23 Eli Zaretskii <eliz@gnu.org>
3548
cdc0d0bd
EZ
3549 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
3550 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
3551 variables, to save and restore frame dimensions.
3552 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
3553 after returning from a 'fullscreen' configuration.
3554 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
3555 to avoid races between the main thread and the input thread.
3556
3557 * w32term.h (struct w32_output): New members normal_width,
3558 normal_height, normal_top, normal_left, and prev_fsmode.
3559 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
3560 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
3561 members of a frame.
3562
b5b7745f
EZ
3563 * w32term.c (w32fullscreen_hook): Record last value of the frame's
3564 'fullscreen' parameter. Always record previous width and height
3565 of the frame, except when switching out of maximized modes, so
3566 that they could be restored correctly, instead of resetting to the
3567 default frame dimensions. Send SC_RESTORE command to the frame,
3568 unless we are going to send SC_MAXIMIZE, to restore the frame
3569 resize hints in the mouse pointer shown by the window manager.
3570 (Bug#14032)
3571
3572 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
3573
3574 * lisp.h (get_frame_param): Adjust conditions for prototype
3575 declaration.
3576
a3454eed
KB
35772013-03-22 Ken Brown <kbrown@cornell.edu>
3578
3579 * unexcw.c: Drop unneeded inclusion of w32common.h.
3580 (report_sheap_usage): Declare.
3581 (read_exe_header): Add magic numbers for x86_64.
3582 (fixup_executable): Fix printf format specifier for unsigned long
3583 argument.
3584
5a49b79c
DA
35852013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
3586
3587 * frame.h (struct frame): Put menu_bar_window under #ifdef
3588 because this member is not needed when X toolkit is in use.
3589 (fset_menu_bar_window):
3590 * dispnew.c (clear_current_matrices, clear_desired_matrices)
3591 (free_glyphs, update_frame):
3592 * xdisp.c (expose_frame): Likewise.
3593 (display_menu_bar): Likewise. Remove redundant eassert.
3594 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
3595 toolkit is in use.
3596
d6723bf7
PE
35972013-03-21 Paul Eggert <eggert@cs.ucla.edu>
3598
7b1123d8
PE
3599 Use functions and constants to manipulate Lisp_Save_Value objects.
3600 This replaces code that used macros and strings and token-pasting.
3601 The change makes the C source a bit easier to follow,
3602 and shrinks the Emacs executable a bit.
3603 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
3604 (make_save_value): Change 1st arg from string to enum. All callers
3605 changed.
3606 (INTX): Remove.
3607 (mark_object): Use if, not #if, for GC_MARK_STACK.
3608 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
3609 (XSAVE_OBJECT): Now functions, not macros.
3610 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
3611 the constant was never used.
3612 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
3613 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
3614 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
3615 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
3616 New constants.
3617 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
3618 type3 with a single member save_type. All uses changed.
3619 (save_type, set_save_pointer, set_save_integer): New functions.
3620 * print.c (PRINTX): Remove.
3621
d6723bf7
PE
3622 * alloc.c: Remove redundant static declarations.
3623
5f24fa51
DA
36242013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
3625
3626 * window.h (struct window): Convert left_col, top_line, total_lines
3627 and total_cols from Lisp_Objects to integers. Adjust comments.
3628 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
3629 Remove.
3630 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
3631 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
3632 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
3633 Adjust users where appropriate.
3634
42143acd
DA
36352013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
3636
3637 * frame.h (struct frame): Drop resx and resy because the same data is
3638 available from window system-specific output context. Adjust users.
562c6ee9
SM
3639 (default_pixels_per_inch_x, default_pixels_per_inch_y):
3640 New functions to provide defaults when no window system available.
42143acd 3641 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 3642 (NUMVAL): Move from xdisp.c.
42143acd
DA
3643 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
3644 (Ffont_face_attributes, Fopen_font):
3645 * image.c (gs_load):
3646 * w32font.c (fill_in_logfont):
3647 * xdisp.c (calc_pixel_width_or_height):
3648 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
3649 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
3650
c0a17406
KH
36512013-03-20 Kenichi Handa <handa@gnu.org>
3652
3653 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
3654 to 1 (temporary workaround until a bug related to ASCII
3655 optimization is fixed).
3656
095d384d
DA
36572013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
3658
3659 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
3660 Signal error if window is not internal. Adjust docstring.
3661 (delete_all_child_windows): Use combination_limit to save the buffer.
3662 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
3663 * print.c (syms_of_print): Initialize debugging output not here...
3664 (init_print_once): ...but in a new function here.
3665 * lisp.h (init_print_once): Add prototype.
3666 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 3667
748fa866
DA
36682013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
3669
3670 * window.c (window_resize_check, window_resize_apply)
3671 (window_from_coordinates, recombine_windows, set_window_buffer)
3672 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
3673 (Fsplit_window_internal, Fdelete_window_internal)
3674 (freeze_window_starts): Use bool for booleans.
3675 * window.h (window_frame_coordinates, resize_frame_windows)
3676 (freeze_window_starts, set_window_buffer): Adjust prototypes.
3677
81519fd2
SM
36782013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
3679
3680 * dispnew.c (bitch_at_user): Use `user-error'.
3681
6db423a9
KB
36822013-03-17 Ken Brown <kbrown@cornell.edu>
3683
3684 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
3685 as return type of image_background. (Bug#13981)
3686 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
3687
8f2906f5
JD
36882013-03-16 Jan Djärv <jan.h.d@swipnet.se>
3689
960ce480 3690 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 3691 (ns_select): Don't return with result uninitialized.
960ce480 3692
8f2906f5
JD
3693 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
3694 and getDirectory.
3695
81519fd2
SM
3696 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
3697 New functions.
8f2906f5
JD
3698 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
3699 directories. If filename is nil, get directory name (Bug#13932).
3700 Use getFilename and getDirectory.
3701 (getFilename, getDirectory): New methods for EmacsSavePanel and
3702 EmacsOpenPanel.
3703 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
3704
cded56c1
PE
37052013-03-15 Paul Eggert <eggert@cs.ucla.edu>
3706
3707 * coding.c (decode_coding_gap): Fix typo caught by static checking.
3708
251e9147 37092013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
3710
3711 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
3712 (adjust_after_replace): Make it back to static. Delete the third
3713 arg text_at_gap_tail. Cancel the code for handling it.
3714
3715 * coding.h (struct coding_system): New member eol_seen.
3716
3717 * coding.c (detect_ascii): New function.
3718 (detect_coding): Set coding->head_ascii and coding->eol_seen only
3719 when the source bytes are actually scanned. On detecting for
3720 coding_category_utf_8_auto, call detect_ascii instead of scanning
3721 source bytes directly.
3722 (produce_chars): Call insert_from_gap with the new arg 0.
3723 (encode_coding): Likewise.
3724 (decode_coding_gap): Control ASCII optimization by the variable
3725 disable_ascii_optimization instead of #ifndef .. #endif.
3726 Deccode EOL format according to coding->eol_seen.
3727 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
3728 variable.
3729
8a44e6d1
KH
3730 * lisp.h (adjust_after_replace): Cancel externing it.
3731 (insert_from_gap): Adjust prototype.
3732
5f795e34
EZ
37332013-03-15 Eli Zaretskii <eliz@gnu.org>
3734
3735 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
3736 FULLSCREEN_MAXIMIZED. (Bug#13935)
3737
f258b4be
DA
37382013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
3739
3740 * region-cache.c (find_cache_boundary, move_cache_gap)
3741 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
3742 Simplify debugging check and convert to eassert. Adjust comment.
3743 (pp_cache): Put under ENABLE_CHECKING.
3744
a5cc4dde
EZ
37452013-03-14 Eli Zaretskii <eliz@gnu.org>
3746
3747 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
3748 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
3749 and WM_ACTIVATEAPP.
3750 (w32fullscreen_hook): If the frame is visible, reset
3751 f->want_fullscreen flag after changing the frame size. If the
3752 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
3753 (Bug#13953)
3754
3fc5e44a
DC
37552013-03-13 Daniel Colascione <dancol@dancol.org>
3756
3757 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
3758 too so that these builds can use Cygwin's file conversion
3759 functions. (We've been building and linking cygw32.o all along
3760 and just not using it.)
3761
47d7532e
PE
37622013-03-13 Paul Eggert <eggert@cs.ucla.edu>
3763
3764 File synchronization fixes (Bug#13944).
3765 * Makefile.in (LIB_FDATASYNC): New macro.
3766 (LIBES): Use it.
3767 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
3768 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
3769 Don't worry about HAVE_FSYNC, since a substitute fsync is
3770 available if the system lacks one.
3771 (Fwrite_regin): Retry fsync if interrupted.
3772
c7ffccaf
EZ
37732013-03-13 Eli Zaretskii <eliz@gnu.org>
3774
4e2df81d 3775 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
3776 activated, call w32fullscreen_hook, to make sure the new frame
3777 dimensions are in effect. (Bug#13937)
3778
8a7debc1
DA
37792013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
3780
3781 * xdisp.c (init_iterator): Simplify because both character and byte
3782 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
3783 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
3784 character and byte positions can be obtained from marker.
8a7debc1 3785
7fd8c501
PE
37862013-03-13 Paul Eggert <eggert@cs.ucla.edu>
3787
d9df6f40
PE
3788 Static checking by Sun C 5.12.
3789 * alloc.c (buffer_memory_full) [REL_ALLOC]:
3790 * bytecode.c (exec_byte_code):
3791 * dispnew.c (init_display):
3792 * eval.c (error):
3793 * fileio.c (Fsubstitute_in_file_name):
3794 * keyboard.c (Fevent_convert_list):
3795 * keymap.c (Fsingle_key_description):
3796 * term.c (maybe_fatal, fatal):
3797 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
3798 * xsmfns.c (Fhandle_save_session):
3799 Omit unreachable code.
3800 * keymap.c (map_keymap_char_table_item): Cast void * to
3801 a function pointer type; the C Standard requires this.
3802
7fd8c501
PE
3803 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
3804 Include <sys/param.h> unconditionally, as that works elsewhere and
3805 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
3806 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
3807 and FreeBSD now.
3808
a020afb9 3809See ChangeLog.12 for earlier changes.
aac0c6e3
MR
3810
3811;; Local Variables:
3812;; coding: utf-8
aac0c6e3
MR
3813;; End:
3814
ab422c4d 3815 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
3816
3817 This file is part of GNU Emacs.
3818
3819 GNU Emacs is free software: you can redistribute it and/or modify
3820 it under the terms of the GNU General Public License as published by
3821 the Free Software Foundation, either version 3 of the License, or
3822 (at your option) any later version.
3823
3824 GNU Emacs is distributed in the hope that it will be useful,
3825 but WITHOUT ANY WARRANTY; without even the implied warranty of
3826 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3827 GNU General Public License for more details.
3828
3829 You should have received a copy of the GNU General Public License
3830 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.