Signal error when reading an empty byte-code object (Bug#15405)
[bpt/emacs.git] / src / ChangeLog
CommitLineData
ba355de0
BR
12013-09-26 Barry O'Reilly <gundaetiapo@gmail.com>
2
3 Signal error when reading an empty byte-code object (Bug#15405)
4 * lread.c (read1): signal error
5 * alloc.c (make_byte_code): eassert header size
6 (sweep_vectors): change an int to size_t
7
4710d6f4
PE
82013-09-24 Paul Eggert <eggert@cs.ucla.edu>
9
cf647d93
PE
10 * dispnew.c (clear_glyph_row, copy_row_except_pointers): Use enums
11 instead of ints, as it's the usual style for offsetof constants. See:
12 http://lists.gnu.org/archive/html/emacs-devel/2013-09/msg00478.html
13
4710d6f4
PE
14 * data.c (POPCOUNT_STATIC_INLINE): New macro, as a hack for popcount.
15 This is ugly, but it should fix the performance problem for older
16 GCC versions in the short run. I'll look into integrating the
17 Gnulib module for popcount, as a better fix.
18 See the thread starting in:
19 http://lists.gnu.org/archive/html/emacs-devel/2013-09/msg00474.html
20 (popcount_size_t_generic) [NEED_GENERIC_POPCOUNT]:
21 (popcount_size_t_msc) [USE_MSC_POPCOUNT]:
22 (popcount_size_t_gcc) [USE_GCC_POPCOUNT]:
23 (popcount_size_t): Use it.
24
10ebac9d
DC
252013-09-24 Daniel Colascione <dancol@dancol.org>
26
27 * process.c (Fnetwork_interface_info): Fix build break due to
28 vector changes.
29
9da0f50e
PE
302013-09-24 Paul Eggert <eggert@cs.ucla.edu>
31
32 * dispnew.c (clear_glyph_row, copy_row_except_pointers):
33 Prefer signed to unsigned integers where either will do.
34 No need for 'const' on locals that do not escape.
35 Omit easserts with unnecessary and unportable assumptions about
36 alignment. Avoid unnecessary casts to char *.
37
d6d9cbc1
DA
382013-09-24 Dmitry Antipov <dmantipov@yandex.ru>
39
40 Use union for the payload of struct Lisp_Vector.
41 This helps to avoid a few glitches dictated by C's aliasing rules.
42 * lisp.h (struct Lisp_Vector): Use union for next and
43 contents member. Adjust comment. Change related users.
44 * alloc.c (next_in_free_list, set_next_in_free_list): Remove.
45 Related users changed.
46 * buffer.c, bytecode.c, ccl.c, character.h, chartab.c, composite.c:
47 * composite.h, disptab.h, fns.c, fontset.c, indent.c, keyboard.c:
48 * lread.c, msdos.c, process.c, w32menu.c, window.c, xdisp.c:
49 * xfaces.c, xfont.c, xmenu.c: Related users changed.
50
ec7bc82f
DA
512013-09-24 Dmitry Antipov <dmantipov@yandex.ru>
52
53 Optimize glyph row clearing and copying routines.
54 * dispextern.h (struct glyph_row): Change layout of struct
55 glyph_row to help copy_row_except_pointers. Adjust comment.
56 * dispnew.c (null_row): Remove.
57 (clear_glyph_row): Use offsetof and memset to find and clear
58 just the members that need clearing. Adjust comment.
59 (copy_row_except_pointers): Likewise for copying.
60
d160dd0c
PE
612013-09-24 Paul Eggert <eggert@cs.ucla.edu>
62
7be68de5
PE
63 Some minor cleanups of recently-added bool vector code.
64 * conf_post.h (assume): Always return void. Use lint version
65 only if GCC and MSC versions don't apply.
66 * conf_post.h (assume):
67 * data.c (USC_MSC_POPCOUNT, count_trailing_zero_bits):
68 Depend on _MSC_VER, not __MSC_VER, for consistency with
69 the rest of Emacs.
70 * data.c (bool_vector_spare_mask, popcount_size_t_generic)
71 (popcount_size_t_msc, popcount_size_t_gcc, popcount_size_t)
72 (bool_vector_binop_driver, count_trailing_zero_bits)
73 (size_t_to_host_endian): Now static, not static inline;
74 the latter isn't needed with modern compilers and doesn't
75 work with older compilers anyway.
76
d160dd0c
PE
77 * alloc.c (valgrind_p): Use bool for boolean.
78
e08813d0
DA
792013-09-23 Dmitry Antipov <dmantipov@yandex.ru>
80
81 * xdisp.c (noninteractive_need_newline, message_log_need_newline)
82 (overlay_arrow_seen, message_enable_multibyte, line_number_displayed)
83 (display_last_displayed_message_p, message_buf_print)
84 (message_cleared_p, help_echo_showing_p, hourglass_shown_p):
85 Use bool for boolean.
3a6a78fd
DA
86 * dispextern.h (cancel_line, init_desired_glyphs):
87 Remove ancient leftover.
88 (help_echo_showing_p, hourglass_shown_p):
e08813d0
DA
89 * lisp.h (noninteractive_need_newline): Adjust declaration.
90
5492865b
DA
912013-09-23 Dmitry Antipov <dmantipov@yandex.ru>
92
93 * dispnew.c (frame_garbaged, selected_frame, last_nonminibuf_frame):
94 Move to...
95 * frame.c (frame_garbaged, selected_frame, last_nonminibuf_frame):
96 ...this file and convert the latter to static. Adjust comment.
97 (make_initial_frame):
98 * window.c (init_window_once): Adjust user.
99 * frame.h (last_nonminibuf_frame): Remove declaration.
100 * lisp.h (selected_frame): Likewise.
101 * msdos.c (the_only_display_info): Adjust comment.
102
cd548fa4
EZ
1032013-09-23 Eli Zaretskii <eliz@gnu.org>
104
f03eddbf
EZ
105 * xdisp.c (mouse_face_from_string_pos): Fix off-by-one error in
106 computing the end column of mouse-highlight that comes from
107 display or overlay strings. (Bug#15437)
b519df23
EZ
108 (note_mouse_highlight): Adapt calculation of last argument to
109 mouse_face_from_string_pos to the above change.
f03eddbf 110
cd548fa4
EZ
111 * conf_post.h (__has_builtin): Define to zero, if undefined, on
112 all platforms, not just for clang.
113
8762e524
JD
1142013-09-23 Jan Djärv <jan.h.d@swipnet.se>
115
116 * filelock.c (lock_file_1): Rearrange to remove compiler warning
117 about excess arguments to snprintf.
118
119 * conf_post.h(assume): Use __builtin_unreachable for clang.
120
d4a9284f
JB
1212013-09-23 Juanma Barranquero <lekktu@gmail.com>
122
123 * w32console.c (initialize_w32_display): Remove unused variable hlinfo.
124 * w32term.c (w32_scroll_bar_handle_click): Remove unused variable f.
125
a84683fd
DC
1262013-09-23 Daniel Colascione <dancol@dancol.org>
127
128 * alloc.c (USE_VALGRIND): New macro; on by default
129 when ENABLE_CHECKING.
130 (mark_maybe_object,mark_maybe_pointer)
131 [USE_VALGRIND]: Mark conservatively-scanned regions valid for
132 valgrind purposes.
133 (valgrind_p) [USE_VALGRIND]: New variable.
134 (init_alloc) [USE_VALGRIND]: Initialize valgrind_p.
135
8fef36c6
JD
1362013-09-22 Jan Djärv <jan.h.d@swipnet.se>
137
fb83ea63
JD
138 * process.c (wait_reading_process_output): Change int pnamelen to
139 socklen_t.
140
141 * nsterm.m (setMarkedText:selectedRange:):
142 (deleteWorkingText):
143 * nsmenu.m (addDisplayItemWithImage:idx:tag:helpText:enabled:):
144 * nsfont.m (ns_get_covering_families, ns_findfonts): Cast NSLog
145 argument to unsigned long to avoid warning.
146 (nsfont_draw): Use 0.25 instead of Fix2X (kATSItalicQDSkew).
147
8fef36c6
JD
148 * conf_post.h (assume): Fix compiler error: x shall be cond.
149
cd9356f2
DC
1502013-09-22 Daniel Colascione <dancol@dancol.org>
151
152 * xfns.c (x_get_monitor_attributes): Suppress unused variable
153 warning when compiling without a window system.
154
3e0b94e7
DC
1552013-09-22 Daniel Colascione <dancol@dancol.org>
156
157 * data.c (Qbool_vector_p): New symbol.
158 (bool_vector_spare_mask,popcount_size_t_generic)
159 (popcount_size_t_msc,popcount_size_t_gcc)
160 (popcount_size_t)
161 (bool_vector_binop_driver)
162 (count_trailing_zero_bits,size_t_to_host_endian)
163 (Fbool_vector_exclusive_or)
164 (Fbool_vector_union)
165 (Fbool_vector_intersection,Fbool_vector_set_difference)
166 (Fbool_vector_subsetp,Fbool_vector_not)
167 (Fbool_vector_count_matches)
168 (Fbool_vector_count_matches_at): New functions.
169 (syms_of_data): Intern new symbol, functions.
170 * alloc.c (bool_vector_payload_bytes): New function.
171 (Fmake_bool_vector): Instead of calling Fmake_vector,
172 which performs redundant initialization and argument checking,
173 just call allocate_vector ourselves. Make sure we clear any
174 terminating padding to zero.
175 (vector_nbytes,sweep_vectors): Use bool_vector_payload_bytes
176 instead of open-coding the size calculation.
177 (vroundup_ct): New macro.
178 (vroundup): Assume argument >= 0; invoke vroundup_ct.
179 * casetab.c (shuffle,set_identity): Change lint_assume to assume.
180 * composite.c (composition_gstring_put_cache): Change
181 lint_assume to assume.
182 * conf_post.h (assume): New macro.
183 (lint_assume): Remove.
184 * dispnew.c (update_frame_1): Change lint_assume to assume.
185 * ftfont.c (ftfont_shape_by_flt): Change lint_assume
186 to assume.
187 * image.c (gif_load): Change lint_assume to assume.
188 * lisp.h (eassert_and_assume): New macro.
189 (Qbool_vector_p): Declare.
190 (CHECK_BOOL_VECTOR,ROUNDUP,BITS_PER_SIZE_T): New macros.
191 (swap16,swap32,swap64): New inline functions.
192 * macfont.c (macfont_shape): Change lint_assume to assume.
193 * ralloc.c: Rename ROUNDUP to PAGE_ROUNDUP throughout.
194 * xsettings.c (parse_settings): Use new swap16 and
195 swap32 from lisp.h instead of file-specific macros.
196
76880d88
EZ
1972013-09-22 Eli Zaretskii <eliz@gnu.org>
198
199 * xdisp.c (try_window_id): Don't abort if cursor row could not be
200 found (which can legitimately happen when the glyph row at the
201 window start is disabled in the current_matrix. (Bug#15365)
202
c6cfd910
PE
2032013-09-22 Paul Eggert <eggert@cs.ucla.edu>
204
205 Fix syntax.h bug introduced by recent INLINE change.
206 syntax.h defined an extern inline function SYNTAX_ENTRY that was
207 conditionally compiled one way in some modules, and a different
208 way in others. This doesn't work with extern inline functions,
209 which must have the same definition in all modules, because the
210 defining code might be shared across modules, depending on the
211 implementation. Symptoms reported by Martin Rudalics in:
212 http://lists.gnu.org/archive/html/emacs-devel/2013-09/msg00414.html
213 * regex.c, syntax.c (SYNTAX_ENTRY_VIA_PROPERTY): Remove.
214 (SYNTAX, SYNTAX_ENTRY, SYNTAX_WITH_FLAGS): New macros,
215 overriding the corresponding functions in syntax.h.
216 * syntax.h (syntax_property_entry, syntax_property_with_flags)
217 (syntax_property): New inline functions.
218 (SYNTAX_ENTRY, SYNTAX_WITH_FLAGS, SYNTAX):
219 Rewrite in terms of these new functions.
220
b3f1d119
EZ
2212013-09-21 Eli Zaretskii <eliz@gnu.org>
222
223 * dired.c (directory_files_internal): Use multibyte_chars_in_text,
224 not chars_in_text, whose result depends on the multibyteness of
225 the current buffer. (Bug#15426)
226
00382e8b
PE
2272013-09-20 Paul Eggert <eggert@cs.ucla.edu>
228
e3b29769
PE
229 Port recent change to hosts where pointers aren't 'long'.
230 * xterm.c (x_send_scroll_bar_event, x_scroll_bar_to_input_event):
231 Don't assume that pointers are the same width as 'long'.
232 Add a compile-time check that a pointer fits into two X slots.
233
00382e8b
PE
234 A simpler, centralized INLINE.
235 * conf_post.h (INLINE): Define only if not already defined.
236 This allows us to use a single INLINE, defined by one file
237 per executable.
238 * emacs.c (INLINE): Define it.
239 Also, include category.h, charset.h, composite.h, dispextern.h,
240 syntax.h, systime.h, so that their INLINE definitions are expanded
241 properly for Emacs.
242 * blockinput.h, keyboard.c (BLOCKINPUT_INLINE):
243 * buffer.h, buffer.c (BUFFER_INLINE):
244 * category.h, category.c (CATEGORY_INLINE):
245 * character.h, character.c (CHARACTER_INLINE):
246 * charset.h, charset.c (CHARSET_INLINE):
247 * composite.h, composite.c (COMPOSITE_INLINE):
248 * dispextern.h, dispnew.c (DISPEXTERN_INLINE):
249 * frame.h, frame.c (FRAME_INLINE):
250 * intervals.h, intervals.c (INTERVALS_INLINE):
251 * keyboard.h, keyboard.c (KEYBOARD_INLINE):
252 * lisp.h, alloc.c (LISP_INLINE):
253 * process.h, process.c (PROCESS_INLINE):
254 * syntax.h, syntax.c (SYNTAX_INLINE):
255 * systime.h, sysdep.c (SYSTIME_INLINE):
256 * termhooks.h, terminal.h (TERMHOOKS_INLINE):
257 * window.h, window.c (WINDOW_INLINE):
258 Remove. All uses replaced with INLINE.
259
2b943ba6
DA
2602013-09-20 Dmitry Antipov <dmantipov@yandex.ru>
261
262 * xterm.c (handle_one_xevent): Revert part of 2013-09-17 change
263 to avoid Bug#15398.
264
13d9698a
EZ
2652013-09-19 Eli Zaretskii <eliz@gnu.org>
266
267 * w32reg.c (w32_get_string_resource): Make the first 2 arguments
268 'const char *' to avoid compiler warnings due to similar change in
269 the prototype of x_get_string_resource.
270
ced135eb
DA
2712013-09-19 Dmitry Antipov <dmantipov@yandex.ru>
272
273 * xterm.h (struct x_display_info): New members last_mouse_glyph_frame,
274 last_mouse_scroll_bar, last_mouse_glyph and last_mouse_movement_time,
275 going to replace static variables below. Adjust comments.
276 * xterm.c (last_mouse_glyph, last_mouse_glyph_frame)
277 (last_mouse_scroll_bar, last_mouse_movement_time): Remove.
278 (note_mouse_movement, XTmouse_position, x_scroll_bar_note_movement)
279 (x_scroll_bar_report_motion, handle_one_xevent, syms_of_xterm):
280 Related users changed.
281 * w32term.h (struct w32_display_info): New members last_mouse_glyph_frame,
282 last_mouse_scroll_bar, last_mouse_scroll_bar_pos, last_mouse_glyph and
283 last_mouse_movement_time, going to replace static variables below.
284 Adjust comments.
285 * w32term.c (last_mouse_glyph_frame, last_mouse_scroll_bar)
286 (last_mouse_scroll_bar_pos, last_mouse_glyph, last_mouse_movement_time):
287 Remove.
288 (note_mouse_movement, w32_mouse_position, w32_scroll_bar_handle_click)
289 (x_scroll_bar_report_motion, syms_of_w32term): Related users changed.
290 * nsterm.h (struct ns_display_info): New members last_mouse_glyph,
291 last_mouse_movement_time and last_mouse_scroll_bar, going to replace
292 static variables below.
293 * nsterm.m (last_mouse_glyph, last_mouse_movement_time)
294 (last_mouse_scroll_bar): Remove.
295 (note_mouse_movement, ns_mouse_position, mouseMoved, mouseEntered)
296 (mouseExited): Related users changed.
297
091f1e1f
DA
2982013-09-19 Dmitry Antipov <dmantipov@yandex.ru>
299
300 Do not use external array to process X scroll bar messages.
301 * xterm.c (scroll_bar_windows, scroll_bar_windows_size): Remove.
302 (x_send_scroll_bar_event): Pack window pointer into two slots
303 of XClientMessageEvent if we're 64-bit. Adjust comment.
304 (x_scroll_bar_to_input_event): Unpack accordingly.
305
582ed56c
DA
3062013-09-18 Dmitry Antipov <dmantipov@yandex.ru>
307
308 Ifdef away recent changes which aren't relevant to NS port.
309 * dispextern.h (x_mouse_grabbed, x_redo_mouse_highlight)
310 [!HAVE_NS]: Declare as such.
311 * frame.c (x_mouse_grabbed, x_redo_mouse_highlight)
312 [!HAVE_NS]: Define as such.
313
18da0d8a
DA
3142013-09-18 Dmitry Antipov <dmantipov@yandex.ru>
315
316 * frame.c (x_redo_mouse_highlight): New function
317 to factor out common code used in W32 and X ports.
318 * dispextern.h (x_redo_mouse_highlight): Add prototype.
319 * xterm.h (struct x_display_info):
320 * w32term.h (struct w32_display_info):
321 * nsterm.h (struct ns_display_info): New members
322 last_mouse_motion_frame, last_mouse_motion_x and
323 last_mouse_motion_y, going to replace static variables below.
324 * xterm.c (last_mouse_motion_event, last_mouse_motion_frame)
325 (redo_mouse_highlight): Remove.
326 (note_mouse_movement, syms_of_xterm): Adjust user.
327 (handle_one_xevent): Likewise. Use x_redo_mouse_highlight.
328 * w32term.c (last_mouse_motion_event, last_mouse_motion_frame)
329 (redo_mouse_highlight): Remove.
330 (note_mouse_movement, syms_of_w32term): Adjust user.
331 (w32_read_socket): Likewise. Use x_redo_mouse_highlight.
332 * nsterm.m (last_mouse_motion_position, last_mouse_motion_frame):
333 Remove.
334 (note_mouse_movement, mouseMoved, syms_of_nsterm):
335 * nsfns.m (compute_tip_xy): Adjust user.
336
7a0c745a
DA
3372013-09-18 Dmitry Antipov <dmantipov@yandex.ru>
338
339 * frame.c (x_mouse_grabbed): New function.
340 * dispextern.h (x_mouse_grabbed): Add prototype.
341 (last_mouse_frame): Remove declaration.
342 * xterm.h (struct x_display_info):
343 * w32term.h (struct w32_display_info):
344 * nsterm.h (struct ns_display_info): New member
345 last_mouse_frame, going to replace...
346 * xdisp.c (last_mouse_frame): ...global variable.
347 (note_tool_bar_highlight):
348 * w32term.c (w32_mouse_position, w32_read_socket):
349 * xterm.c (XTmouse_position, handle_one_xevent):
350 Use x_mouse_grabbed.
351 * nsterm.m (ns_mouse_position, mouseDown): Adjust user.
352
0791d107
DA
3532013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
354
355 * w32term.c (w32_read_socket): Avoid temporary
356 variables in a call to x_real_positions.
357 * xterm.c (handle_one_xevent): Likewise.
358
2cd98812
DA
3592013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
360
361 * frame.h (x_set_bitmap_icon) [!HAVE_NS]: New function.
362 (x_icon_type): Remove prototype.
363 (x_bitmap_icon) [!HAVE_NS]: Declare as such.
364 * frame.c (x_icon_type): Remove.
365 * w32term.c (x_make_frame_visible, x_iconify_frame):
366 * xterm.c (x_make_frame_visible, x_iconify_frame):
367 Use x_set_bitmap_icon to factor out common code.
368
a6c2ee1b
DA
3692013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
370
371 * dispextern.h (check_x_display_info, x_get_string_resource):
372 Declare here just once and unify the latter.
373 * frame.c (check_x_display_info, x_get_string_resource):
374 * nsterm.h (check_x_display_info):
375 * xrdb.c (x_get_string_resource):
376 * xterm.h (check_x_display_info): Remove prototypes.
377 * nsfns.m (x_get_string_resource): Likewise. Adjust definition.
378 * w32reg.c (x_get_string_resource): Likewise.
379 (w32_get_rdb_resource): Adjust user.
380
baed3603
DA
3812013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
382
383 * xterm.h (struct x_display_info): New member
384 x_pending_autoraise_frame, going to replace...
385 * xterm.c (pending_autoraise_frame): ...static variable.
386 (x_new_focus_frame, XTread_socket): Adjust users.
387 * w32term.h (struct w32_display_info): New member
388 w32_pending_autoraise_frame, going to replace...
389 * w32term.c (pending_autoraise_frame): ...global variable.
390 (x_new_focus_frame, w32_read_socket): Adjust users.
391
90582f05
GM
3922013-09-17 Glenn Morris <rgm@gnu.org>
393
394 * xdisp.c (message_dolog): If we create *Messages*,
395 switch it to messages-buffer-mode.
396
b7ad2f74
PE
3972013-09-17 Paul Eggert <eggert@cs.ucla.edu>
398
399 Don't overuse 'const' in types of locals.
400 * bidi.c (bidi_count_bytes):
401 * gtkutil.c, gtkutil.h (xg_event_is_for_menubar)
402 (xg_event_is_for_scrollbar):
403 * xselect.c (x_handle_property_notify)
404 (x_handle_selection_notify, x_handle_dnd_message):
405 * xsettings.c, xsettings.h (xft_settings_event):
406 * xterm.c (x_handle_net_wm_state, handle_one_event)
407 (x_menubar_window_to_frame, x_detect_focus_change)
408 (construct_mouse_click, note_mouse_movement)
409 (x_scroll_bar_to_input_event, x_scroll_bar_expose)
410 (x_scroll_bar_handle_click, x_scroll_bar_note_movement)
411 (handle_one_xevent, x_handle_net_wm_state):
412 * xterm.h (x_handle_property_notify, x_handle_selection_notify)
413 (x_handle_dnd_message):
414 Avoid unnecessary 'const', typically the second 'const' in
415 'const foo * const arg', a 'const' that does not affect the API
416 and doesn't significantly help the human reader.
417
19452b86
DA
4182013-09-17 Dmitry Antipov <dmantipov@yandex.ru>
419
420 * image.c (fn_g_type_init) [WINDOWSNT]: Define and load
421 only if Glib < 2.36.0.
422 (fn_g_type_init) [!WINDOWSNT]: Define only if Glib < 2.36.0.
423 * xsettings.c (init_gconf, init_gsettings): Do not check
424 for g_type_init.
1893694e
DA
425 * xterm.c (handle_one_xevent): Do not call to x_clear_area
426 if GTK >= 2.7.0.
33b83dd7 427 (toplevel) [USE_MOTIF]: Include xlwmenu.h to pacify GCC.
19452b86 428
6434e343
JD
4292013-09-16 Jan Djärv <jan.h.d@swipnet.se>
430
3f386383
JD
431 * xsettings.c (init_gconf, init_gsettings): Check for Glib 2.36.0
432 before calling g_type_init.
433
6434e343
JD
434 * font.c (syms_of_font): Move call to syms_of_(ns|mac)font ...
435
436 * nsterm.m (syms_of_nsterm): ... to here.
437
83a119f8
DA
4382013-09-16 Dmitry Antipov <dmantipov@yandex.ru>
439
440 * xterm.c (toolkit_scroll_bar_interaction): Use bool for boolean.
441 (ignore_next_mouse_click_timeout): Use Time as X does.
442 (handle_one_xevent): Avoid cast and use unsigned comparison.
443
61582e6a
DA
4442013-09-16 Dmitry Antipov <dmantipov@yandex.ru>
445
446 Do not copy X event in handle_one_xevent except KeyPress case.
447 Wnen XEvent is processed, it is unlikely to be changed except
448 KeyPress case, so we can avoid copying and use const pointer to
449 const data to make sure that an event is not changed elsewhere.
450 * xterm.c (handle_one_xevent): Change 2nd arg to 'const XEvent *
451 const' and do not create local copy except for the KeyPress event.
452 Use casts to avoid a few glitches. Adjust formatting. Add comments.
453 (SET_SAVED_BUTTON_EVENT): Remove and move the code to the only user.
454 (x_handle_net_wm_state, x_menubar_window_to_frame)
455 (x_detect_focus_change, construct_mouse_click, note_mouse_movement)
456 (x_scroll_bar_to_input_event, x_scroll_bar_expose)
457 (x_scroll_bar_handle_click, x_scroll_bar_note_movement):
458 * gtkutil.c (xg_event_is_for_menubar, xg_event_is_for_scrollbar):
459 * xselect.c (x_handle_property_notify, x_handle_selection_notify)
460 (x_handle_dnd_message):
461 * xsettings.c (xft_settings_event):
462 Use 'const XEvent * const' where appropriate.
463 * xterm.h, gtkutil.h, xsettngs.h: Adjust related prototypes.
464
f8eb1572
DA
4652013-09-16 Dmitry Antipov <dmantipov@yandex.ru>
466
467 Fix X event waiting to handle multiple frames.
468 * frame.h (struct frame) [HAVE_X_WINDOWS]: New member wait_event_type.
469 * xterm.c (pending_event_wait): Remove. Adjust users.
470 (x_detect_focus_change): Pass frame arg.
471 (handle_one_xevent): Find related frame early and clear per-frame
472 wait_event_type only if this is an event for the relevant frame.
473 (x_wait_for_event): Use per-frame wait_event_type.
474
3fa2054e
JD
4752013-09-15 Jan Djärv <jan.h.d@swipnet.se>
476
745d3809
JD
477 * nsfns.m (Fx_create_frame): Fix font driver registration for
478 GNUStep.
479
480 * font.c (syms_of_font): Check MAC_OS_X_VERSION_MAX_ALLOWED >= 1050
481 for syms_of_macfont.
482
3fa2054e
JD
483 * nsterm.m: Include macfont.h.
484 (ns_tmp_flags, ns_tmp_font): Remove.
485 (ns_compute_glyph_string_overhangs): Check for driver Qns.
486 (ns_draw_glyph_string): Use local variables instead of ns_tmp_flags,
487 ns_tmp_font. Call ns_draw_text_decoration here instead of nsfont.m.
488 (changeFont:): Fix code style. Check for font driver type when
489 getiing font.
490
491 * nsterm.h (FONT_DESCENT, FONT_ASCENT): Define to (f)->ascent and
492 (f)->descent.
493
494 * nsfont.m (ns_tmp_flags, ns_tmp_font): Remove.
495 (nsfont_open): Set font driver type.
496 Set font->ascent and font->descent. Figure out font instead of
497 ns_tmp_font, and flags instead of ns_tmp_flags.
498 Fix indentation. Remove call to ns_draw_text_decoration,
499 moved to nsterm.
500
501 * nsfns.m: Include macfont.h.
502 (Fx_create_frame): Register macfont driver, make a better default font.
503 (Fns_popup_font_panel): Get font from macfont driver, if used.
504
505 * macfont.m, macfont.h, maccuvs.h: New files.
506
507 * font.h: Declare syms_of_macfont.
508
509 * font.c (syms_of_font): Call syms_of_macfont.
510
511 * Makefile.in (NS_OBJ, SOME_MACHINE_OBJECTS): Add macfont.o.
512
0eed0355
DA
5132013-09-15 Dmitry Antipov <dmantipov@yandex.ru>
514
515 Drop VERTICAL_SCROLL_BAR_WIDTH_TRIM. For X, it is zero since 1999,
516 and it is always zero for others, so I assume that this is an ancient
517 leftover which nobody will want to change any more.
518 * xterm.h, w32term.h, nsterm.h (VERTICAL_SCROLL_BAR_WIDTH_TRIM): Remove.
519 (VERTICAL_SCROLL_BAR_INSIDE_WIDTH):
520 * frame.c (x_set_scroll_bar_width):
521 * w32fns.c (w32_createscrollbar):
522 * w32term.c (w32_set_vertical_scroll_bar):
523 * xfns.c (x_set_scroll_bar_default_width):
524 * xterm.c (XTflash, x_scroll_bar_create, XTset_vertical_scroll_bar)
525 (x_scroll_bar_expose): Related users changed.
526
07013c68
DA
5272013-09-15 Dmitry Antipov <dmantipov@yandex.ru>
528
529 * xterm.h (FRAME_X_SCREEN_NUMBER): Add comment.
530 (BLACK_PIX_DEFAULT, WHITE_PIX_DEFAULT): Use FRAME_X_SCREEN_NUMBER.
901049a6
DA
531 (SCROLL_BAR_X_WIDGET, SET_SCROLL_BAR_X_WIDGET) [USE_X_TOOLKIT]:
532 Define as such.
c7cc32f7
DA
533 * frame.h (FRAME_SMALLEST_CHAR_WIDTH, FRAME_SMALLEST_FONT_HEIGHT):
534 Define once here...
535 * nsterm.h, w32term.h, xterm.h: ...and not here.
901049a6
DA
536 * w32term.h (SCROLL_BAR_X_WIDGET, SET_SCROLL_BAR_X_WIDGET):
537 Remove unused Xisms.
7f09455e
DA
538 * xterm.c, xfns.c (toplevel): Remove #ifdef HAVE_X_WINDOWS because
539 these modules are never compiled otherwise.
07013c68 540
0df00f59
EZ
5412013-09-14 Eli Zaretskii <eliz@gnu.org>
542
08a209bf 543 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>:
0df00f59
EZ
544 Doc fix. (Bug#15375)
545
fcd42c11
DA
5462013-09-13 Dmitry Antipov <dmantipov@yandex.ru>
547
548 Unify Fx_focus_frame between all ports.
549 * frame.h (x_focus_frame): New prototype.
550 * xfns.c (Fx_focus_frame): Remove.
551 (syms_of_xfns): Do not defsubr it.
552 (x_focus_frame): X implementation.
553 * nsfns.m (Fx_focus_frame): Remove.
554 (syms_of_nsfns): Do not defsubr it.
555 (x_focus_frame): NS implementation.
556 * w32term.c (Fx_focus_frame): Remove.
557 (x_focus_on_frame): Rename to...
558 (x_focus_frame): W32 implementation.
559 * w32term.h (x_focus_on_frame): Remove prototype.
560 * w32fns.c (Fx_focus_frame): Remove.
561 (syms_of_w32fns): Do not defsubr it.
562 * frame.c (Fx_focus_frame): Define here.
563 (syms_of_frame): Defsubr here.
564 * gtkutil.c (xg_tool_bar_callback): Use x_focus_frame.
565
aad3612f
DA
5662013-09-13 Dmitry Antipov <dmantipov@yandex.ru>
567
568 Unify FRAME_window_system_DISPLAY_INFO macros between all ports.
569 All of them are replaced with FRAME_DISPLAY_INFO, defined in
570 each port to reference the port-specific window system data.
571 * msdos.h (FRAME_X_DISPLAY_INFO): Remove.
572 (FRAME_DISPLAY_INFO): Define.
573 * w32term.h (FRAME_W32_DISPLAY_INFO, FRAME_X_DISPLAY_INFO): Remove.
574 (FRAME_DISPLAY_INFO): Define. Adjust users.
575 * xterm.h (FRAME_X_DISPLAY_INFO): Remove.
576 (FRAME_DISPLAY_INFO): Define. Adjust users.
577 * frame.h (FRAME_RES_X, FRAME_RES_Y): Unify.
578 * font.c, frame.c, gtkutil.c, image.c, menu.c, msdos.c, nsfns.m:
579 * nsfont.m, nsterm.m, w32fns.c, w32font.c, w32menu.c, w32term.c:
580 * w32xfns.c, widget.c, xdisp.c, xfaces.c, xfns.c, xfont.c, xmenu.c:
581 * xselect.c, xterm.c: All related users changed.
582
9a650e62
DA
5832013-09-13 Dmitry Antipov <dmantipov@yandex.ru>
584
585 * xterm.h (x_window_to_frame, x_any_window_to_frame)
586 (x_menubar_window_to_frame): Remove prototypes.
587 * xfns.c (x_window_to_frame, x_any_window_to_frame)
588 (x_menubar_window_to_frame, x_top_window_to_frame):
589 Move from here...
590 * xterm.c (x_window_to_frame, x_any_window_to_frame)
591 (x_menubar_window_to_frame, x_top_window_to_frame):
592 ...to here and convert all but the last to static.
593
347ae3e1
EZ
5942013-09-12 Eli Zaretskii <eliz@gnu.org>
595
596 * lisp.mk (lisp): Add w32-common-fns.elc.
597
15c6d837
XF
5982013-09-12 Xue Fuqiao <xfq.free@gmail.com>
599
600 * charset.c (char_charset): Document an exception for char-charset.
601
27e90f77
DA
6022013-09-12 Dmitry Antipov <dmantipov@yandex.ru>
603
604 * xterm.h (x_display_info): New field last_user_time...
605 * xterm.c (toplevel): ...to replace static last_user_time.
606 (handle_one_xevent, x_ewmh_activate_frame): Adjust users.
607
8ffbc36b
DA
6082013-09-12 Dmitry Antipov <dmantipov@yandex.ru>
609
610 * xterm.c (x_set_scroll_bar_thumb) [USE_LUCID && !HAVE_XAW3D]: Clip
611 scroll bar values to prevent thumb from disappear and update comment.
612
5ec0337a
GM
6132013-09-11 Glenn Morris <rgm@gnu.org>
614
615 * emacs.c (usage_message): Possessive apostrophe tweak.
616
fb55b9d1
DA
6172013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
618
8d2db8be
DA
619 * nsterm.m (syms_of_nsterm): Use Qns.
620 * w32fns.c (Fx_open_connection): Remove old '#if 0' code.
621 * w32term.c (w32_create_terminal, syms_of_w32term): Use Qw32.
622 * xfns.c (x_display_info_for_name, Fx_open_connection):
623 Remove old '#if 0' code.
624 (syms_of_xfns): Use Qx.
fb55b9d1
DA
625 * termhooks.h (fullscreen_hook): Remove the leftover.
626 (struct terminal): Fix typo in comment.
627
927eec55
DA
6282013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
629
630 Cleaning up a few X scroll bar bits.
631 * termhooks.h (enum scroll_bar_part): Add scroll_bar_nowhere member.
632 * xterm.h (struct scroll_bar) [USE_TOOLKIT_SCROLL_BARS && USE_LUCID]:
633 New member last_seen_part, going to replace...
634 * xterm.c [USE_TOOLKIT_SCROLL_BARS]: ...global last_scroll_bar_part.
635 (xt_action_hook) [USE_LUCID]: Adjust user.
636 (xm_scroll_callback, xg_scroll_callback): Do not bloat with
637 Lucid-specific scroll bar support.
638 (xaw_jump_callback, xaw_scroll_callback): Prefer enum scroll_par_part
639 to int and adjust to use last_seen_part member.
640 (x_set_toolkit_scroll_bar_thumb) [USE_LUCID]: Adjust user.
641 (x_scroll_bar_create) [USE_TOOLKIT_SCROLL_BARS && USE_LUCID]:
642 Initialize last_seen_part.
643
71b28baa
SM
6442013-09-11 Stefan Monnier <monnier@iro.umontreal.ca>
645
646 * insdel.c (insert_from_buffer_1): Don't mark buffer as modified when
647 insert-buffer-substring an empty string.
648
f5dacaae
PE
6492013-09-11 Paul Eggert <eggert@cs.ucla.edu>
650
651 * xdisp.c (Ftool_bar_lines_needed): Declare as 'const' if ifdeffed out,
652 avoiding a GCC warning.
653
742516e0
DA
6542013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
655
656 Ifdef away frame tool bar code when it is not really used.
657 * frame.h (struct frame) [HAVE_WINDOW_SYSTEM && !USE_GTK && !HAVE_NS]:
658 Move tool_bar_window, desired_tool_bar_string, current_tool_bar_string
659 and minimize_tool_bar_window_p under the above.
660 (fset_current_tool_bar_string, fset_desired_tool_bar_string)
661 (fset_tool_bar_window): Likewise.
662 * dispnew.c (clear_current_matrices, clear_desired_matrices)
663 (adjust_frame_glyphs_for_window_redisplay, free_glyphs, update_frame)
664 (change_frame_size_1):
665 * window.c (window_from_coordinates, Frecenter): Adjust users.
666 * window.h (WINDOW_TOOL_BAR_P): Define to zero when frame tool bar
667 code is not really used.
668 * xdisp.c (build_desired_tool_bar_string, display_tool_bar_line)
669 (tool_bar_lines_needed, MAX_FRAME_TOOL_BAR_HEIGHT, tool_bar_item_info)
670 (get_tool_bar_item, handle_tool_bar_click, note_tool_bar_highlight)
671 [!USE_GTK && !HAVE_NS]: Define as such.
672 (Ftool_bar_lines_needed, redisplay_tool_bar, show_mouse_face)
673 (note_mouse_highlight, expose_frame):
674 * xfns.c (x_set_tool_bar_lines):
675 * xterm.c (handle_one_xevent): Adjust users.
676
73f82c7e
PE
6772013-09-11 Paul Eggert <eggert@cs.ucla.edu>
678
679 Fix corruption with multiple emacsclient -t instances (Bug#15222).
680 This bug was introduced by my 2013-08-26 patch, which incorrectly
681 assumed that the terminfo implementation doesn't use termcap buffers.
682 * term.c (init_tty) [TERMINFO]: Remove optimization, as
683 these buffers apparently are used after all.
684 * termchar.h (TERMCAP_BUFFER_SIZE) [TERMINFO]: Define here too.
685 (struct tty_display_info): Define members termcap_term_buffer and
686 termcap_strings_buffer even if TERMINFO.
687
53482f41
DA
6882013-09-11 Dmitry Antipov <dmantipov@yandex.ru>
689
690 Fix last change.
691 * data.c (Feqlsign, Flss, Fgtr, Fleq, Fgeq): Add convenient
692 'usage' docstring entry to pacify make-docfile.
693
6942013-09-11 Barry O'Reilly <gundaetiapo@gmail.com>
695
696 Change comparison functions =, <, >, <=, >= to take many arguments.
697 * data.c: Change comparison functions' interface and implementation.
698 * lisp.h: Make arithcompare available for efficient two arg
699 comparisons.
700 * bytecode.c: Use arithcompare.
701 * fileio.c: Use new interface.
702
533f258f
SM
7032013-09-11 Stefan Monnier <monnier@iro.umontreal.ca>
704
705 * keyboard.c (read_char): Don't break immediate_echo (bug#15332).
706
8c27f5ff
SM
7072013-09-10 Stefan Monnier <monnier@iro.umontreal.ca>
708
709 * eval.c (Feval): Document the new use of `lexical'.
710
0750a308
DA
7112013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
712
713 Review and drop old frame resize hack.
714 * frame.h (struct frame): Remove force_flush_display_p.
715 * dispnew.c (update_frame): Adjust user and don't call
716 flush_frame here. The comment has said that there was an issues
717 with redisplaying fringes, but I don't see any differences with
718 and without this hack. Hopefully we can continue without it.
719 * xdisp.c (clear_garbaged_frames): Adjust user and do not clear
720 current frame matrices twice if resized_p is set.
721
83fc0554
DA
7222013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
723
724 Do not populate pure Xism x_sync to other ports.
725 * frame.h (x_sync): Move under HAVE_X_WINDOWS.
726 * frame.c (other_visible_frames) [HAVE_X_WINDOWS]: Use as such.
727 * nsfns.m, w32xfns.c (x_sync): Remove no-op.
728 * w32term.h (x_sync): Remove prototype.
729
fd462129
DA
7302013-09-09 Dmitry Antipov <dmantipov@yandex.ru>
731
732 Cleanup frame flushing.
8c27f5ff
SM
733 * dispextern.h (struct redisplay_interface):
734 Drop flush_display_optional because flush_display is enough
fd462129
DA
735 for X and flushing via RIF is just a no-op for others.
736 * frame.h (flush_frame): New function.
737 * dispnew.c (update_frame):
738 * minibuf.c (read_minibuf):
739 * xdisp.c (echo_area_display, redisplay_preserve_echo_area):
740 Use it.
741 * keyboard.c (detect_input_pending_run_timers): Do not flush
742 all frames but selected one in redisplay_preserve_echo_area.
743 * nsterm.m (ns_flush): Remove no-op.
744 (ns_redisplay_interface): Adjust user.
745 * w32term.h (x_flush): Remove no-op.
746 (w32_redisplay_interface): Adjust user.
747 * xterm.c (x_flush): Simplify because we do not flush all
748 frames at once any more. Adjust comment.
749 (x_redisplay_interface): Adjust user.
750
4b73fc73
PE
7512013-09-07 Paul Eggert <eggert@cs.ucla.edu>
752
753 Port --without-x --enable-gcc-warnings to Fedora 19.
754 * gfilenotify.c (globals_of_gfilenotify):
755 Call g_type_init only if using an older glib version that needs it.
756
77394d40
DA
7572013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
758
759 * lisp.h (last_glyphless_glyph_frame, last_glyphless_glyph_face_id)
760 (last_glyphless_glyph_merged_face_id): Remove declarations.
761 * dispextern.h (merge_glyphless_glyph_face): Add prototype.
762 * xdisp.c (last_glyphless_glyph_frame, last_glyphless_glyph_face_id)
763 (last_glyphless_glyph_merged_face_id): Now static.
764 (merge_escape_glyph_face): New function, refactored from...
765 (get_next_display_element): ...here.
766 (merge_glyphless_glyph_face): New function, refactored from...
767 (produce_glyphless_glyph): ...here...
768 * term.c (produce_glyphless_glyph): ...and here.
769
306d67bd
SM
7702013-09-06 Stefan Monnier <monnier@iro.umontreal.ca>
771
772 * eval.c (eval_sub): Only call Ffunction if necessary.
773
7f6c6450
DA
7742013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
775
776 Attempt to make redisplay more selective when changing cursor type.
777 * frame.h (struct frame): New bitfield cursor_type_changed.
778 * xdisp.c (cursor_type_changed): Remove.
779 (try_cursor_movement, redisplay_window, try_window_id)
780 (set_frame_cursor_types, try_window_reusing_current_matrix):
781 Adjust to use per-frame bitfield.
782 (redisplay_internal): Look for cursor type change on each visible
783 frame and consider all frames if cursor type has been changed on
784 the frame other than selected. If cursor type has been changed on
785 selected frame only, do not use fast update.
786
bd0443bb
DA
7872013-09-06 Dmitry Antipov <dmantipov@yandex.ru>
788
789 Attempt to make redisplay more selective when changing fonts.
790 * frame.h (struct frame): New bitfield fonts_changed.
791 * dispextern.h (fonts_changed_p, adjust_glyphs): Remove declaration.
792 (adjust_frame_glyphs): Add prototype.
793 * dispnew.c (fonts_changed_p): Remove.
8bda01d3 794 (adjust_glyphs): Remove because we do not
bd0443bb
DA
795 adjust matrices on all frames at once any more.
796 (adjust_frame_glyphs): Block and unblock input here.
797 (adjust_glyph_matrix): Use fonts_changed.
798 (change_frame_size_1): Use adjust_frame_glyphs.
799 * font.c (font_open_entity): Use fonts_changed.
800 * frame.c (set_menu_bar_lines, Fmake_terminal_frame):
801 * w32fns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_show_tip):
802 * window.c (Fdelete_other_windows_internal, Fwindow_resize_apply)
803 (Fsplit_window_internal, Fdelete_window_internal, grow_mini_window)
804 (shrink_mini_window, Fresize_mini_window_internal)
805 (window_scroll_pixel_based, Fset_window_configuration)
806 (apply_window_adjustment, Fset_window_vscroll):
807 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_show_tip):
808 Use adjust_frame_glyphs.
809 * xdisp.c (redisplay_tool_bar, redisplay_window, try_window)
810 (try_window_reusing_current_matrix, try_window_id, display_line)
811 (IT_EXPAND_MATRIX_WIDTH): Use fonts_changed.
812 (redisplay_internal): Consider fonts_changed and adjust frame
813 matrices for each frame only if the frame is visible. If font
814 has been changed on some frame during full redisplay, retry
815 only visible frames where the font has been actually changed.
816
b9695828
DA
8172013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
818
819 Cache current header and mode line height for each window.
820 * window.h (struct window): New fields mode_line_height
821 and header_line_height.
822 * window.c (make_window): Initialize them.
823 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
824 (CURRENT_HEADER_LINE_HEIGHT): Use them. Adjust comment.
825 (current_mode_line_height, current_header_line_height):
826 Remove declaration.
827 * xdisp.c (current_mode_line_height, current_header_line_height):
828 Remove.
829 (pos_visible_p, init_xdisp): Adjust user.
830 (redisplay_window): Invalidate mode_line_height and
831 header_line_height if current and desired matrices do not agree.
832
66738305
DA
8332013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
834
835 * fontset.c, window.c, xdisp.c (toplevel): Use TERM_HEADER.
836 * xfaces.c (toplevel) [HAVE_X_WINDOWS]: Do not include xterm.h twice.
837
257b3b03
DA
8382013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
839
840 Make --without-x compatible with --enable-gcc-warnings.
841 * font.c (register_font_driver): Move check under HAVE_WINDOW_SYSTEM.
842 * font.h (struct font_driver): Move draw, get_bitmap and free_bitmap
843 members under HAVE_WINDOW_SYSTEM.
844 * keyboard.c (make_lispy_focus_out): Likewise.
845 (record_menu_key): Move under HAVE_MENUS.
846 * xdisp.c (toplevel): Move hourglass_shown_p, hourglass_atimer and
847 THIN_SPACE_WIDTH under HAVE_WINDOW_SYSTEM.
848 (syms_of_xdisp): Adjust user.
849 (window_box_edges): Define only if HAVE_WINDOW_SYSTEM.
850 (start_hourglass, cancel_hourglass):
851 * xfaces.c (toplevel): Likewise with PT_PER_INCH,
852 clear_font_table_count, CLEAR_FONT_TABLE_COUNT
853 and CLEAR_FONT_TABLE_NFONTS.
854 (set_font_frame_param, clear_face_gcs, realize_non_ascii_face):
855 Declare only if HAVE_WINDOW_SYSTEM.
856 (lface_same_font_attributes_p, clear_face_gcs): Define only
857 if HAVE_WINDOW_SYSTEM.
858
98b7f4bd
DA
8592013-09-05 Dmitry Antipov <dmantipov@yandex.ru>
860
861 * frame.c (check_minibuf_window): Update 'frame' with frame pointer.
862 * xterm.c (x_scroll_bar_handle_click) [!USE_TOOLKIT_SCROLL_BARS]:
863 Don't pass C integer to XINT (tiny fix for 2013-09-03 change).
864
a7e43722
SM
8652013-09-05 Stefan Monnier <monnier@iro.umontreal.ca>
866
867 * cmds.c (Fself_insert_command): Don't pass a non-integer to XINT.
868
0c90b9ee
PE
8692013-09-04 Paul Eggert <eggert@cs.ucla.edu>
870
871 * alloc.c (make_event_array): First arg is now ptrdiff_t, not int.
872 This fixes a type error on hosts where ptrdiff_t is wider than int.
873
d99760fa
SM
8742013-09-04 Stefan Monnier <monnier@iro.umontreal.ca>
875
6629638e
SM
876 * keyboard.c (read_key_sequence_vs): New function.
877 (Fread_key_sequence_vector, Fread_key_sequence): Use it to factor out
878 common code.
879
d99760fa
SM
880 * callint.c (Fcall_interactively): Always return a vector for 'K'.
881
224e313d
PE
8822013-09-04 Paul Eggert <eggert@cs.ucla.edu>
883
884 Makefile improvements.
885 * Makefile.in (config.status): Don't use double-colon rules, as
886 they are not portable according to POSIX. Fix shell typo with `;
887 I guess this rule has never been tested?
888 (VCSWITNESS): New macro, to override any environment var.
889
6d6ed1af
DA
8902013-09-04 Dmitry Antipov <dmantipov@yandex.ru>
891
892 * xterm.h (struct x_display_info): Do not track X connection
893 fd separately because it is always available from Display.
894 * xterm.c (x_term_init, x_delete_terminal, x_delete_display):
895 Adjust users.
896
bc923770
DA
8972013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
898
899 * buffer.c (drop_overlay):
900 * fileio.c (restore_point_unwind): Prefer unchain_marker to
901 Fset_marker (X, Qnil, ...) (which is the same but a bit slower).
902
b1cf96de
DA
9032013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
904
905 * buffer.c (Fmake_overlay, Fmove_overlay):
906 * intervals.c (set_point_from_marker):
907 * print.c (PRINTPREPARE): Prefer signal_error
908 to plain error and report unsuitable marker too.
909
d1fc6c21
DA
9102013-09-03 Dmitry Antipov <dmantipov@yandex.ru>
911
912 * xterm.h (struct scroll_bar): Prefer int to Lisp_Object
913 for 'dragging' member.
d1ae6a0b
DA
914 (struct x_output): Remove set-but-unused leftovers
915 'left_before_move' and 'top_before_move'.
d1fc6c21
DA
916 * gtkutil.c (xg_set_toolkit_scroll_bar_thumb):
917 * xterm.c (xt_action_hook, xm_scroll_callback, xg_scroll_callback)
918 (xg_end_scroll_callback, xaw_jump_callback, xaw_scroll_callback)
919 (x_set_toolkit_scroll_bar_thumb, x_scroll_bar_create)
920 (x_scroll_bar_set_handle, XTset_vertical_scroll_bar)
921 (x_scroll_bar_handle_click, x_scroll_bar_note_movement)
d1ae6a0b 922 (x_scroll_bar_report_motion, x_set_offset): Related users changed.
ec5e7504 923 * xfns.c, image.c (XLIB_ILLEGAL_ACCESS): No longer needed.
d1fc6c21 924
0ce9f6de
JD
9252013-09-03 Jan Djärv <jan.h.d@swipnet.se>
926
927 * nsfont.m (INVALID_GLYPH): New define.
928 (nsfont_encode_char): Use INVALID_GLYPH.
929 (ns_uni_to_glyphs): Ditto, check for NSNullGlyph (Bug#15138).
930
b594a96c
DA
9312013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
932
933 * xterm.c (x_last_mouse_movement_time): Revert last change.
934 This code should use XDisplayMotionBufferSize to check display's
935 motion history first, and there are few other issues as well.
936 (x_scroll_bar_note_movement): Pass XMotionEvent rather than XEvent.
937 (handle_one_xevent): Adjust user.
938
8b098236
MR
9392013-09-02 Martin Rudalics <rudalics@gmx.at>
940
9718b207
MR
941 * dispnew.c (Flast_nonminibuf_frame): Move from here ...
942 * frame.c (Flast_nonminibuf_frame): ... to here.
943 (check_minibuf_window): Don't abort if no window was found
944 (Bug#15247).
8b098236 945
84e70bba
DA
9462013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
947
948 Use XGetMotionEvents to ask the last mouse motion time from X server.
949 * xterm.c (X_MOTION_HISTORY): Default to 1.
950 (x_last_mouse_movement_time) [X_MOTION_HISTORY]: New function.
951 (x_last_mouse_movement_time) [!X_MOTION_HISTORY]: Legacy version.
952 (note_mouse_movement, x_scroll_bar_note_movement) [!X_MOTION_HISTORY]:
953 Ifdef away legacy code.
954 (XTmouse_position, x_scroll_bar_report_motion):
955 Use x_last_mouse_movement_time.
fc85e20b
DA
956 (handle_one_xevent): Use event.xunmap and not event.xmap when handling
957 UnmapNotify event.
84e70bba 958
1fccc530
DA
9592013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
960
961 * msdos.c (last_mouse_window): Move to...
962 (dos_rawgetc): ...this function and adjust comment.
963 * nsterm.m (last_window): Rename to last_mouse_window, move to...
964 (mouseMoved): ...this function and adjust comment.
965 * w32term.c (last_window): Likewise with...
966 (w32_read_socket): ...this function.
967 * xterm.c (last_window): Likewise with...
968 (handle_one_xevent): ...this function.
969
0ab10992
DA
9702013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
971
b7da754d 972 * window.h (Vmouse_window, Vmouse_event): Remove the leftovers.
0ab10992
DA
973 * xterm.c (toplevel): Drop obsolete comment and move compose_status...
974 (handle_one_xevent): ...to here.
975 (STORE_KEYSYM_FOR_DEBUG): Move under ENABLE_CHECKING and make no-op
976 otherwise.
977
0c7f856e
DA
9782013-09-02 Dmitry Antipov <dmantipov@yandex.ru>
979
980 * msdos.c (IT_set_terminal_window): Remove no-op.
981 (initialize_msdos_display): Adjust terminal setup.
982 * w32console.c (w32con_set_terminal_window): Remove no-op.
983 (initialize_w32_display): Adjust terminal setup.
984 * w32term.c (w32_set_terminal_window): Remove no-op.
985 (w32_create_terminal): Adjust terminal setup.
986 * xterm.c (XTset_terminal_window): Remove no-op.
987 (x_create_terminal): Adjust terminal setup.
988
a892a94c
DA
9892013-09-01 Dmitry Antipov <dmantipov@yandex.ru>
990
991 * nsterm.m (ns_set_terminal_modes, ns_reset_terminal_modes):
992 Remove no-ops.
993 (ns_create_terminal): Adjust terminal setup.
994 * w32term.c (w32_set_terminal_modes, w32_reset_terminal_modes):
995 Remove no-ops.
996 (w32_create_terminal): Adjust terminal setup.
997 * xterm.c (XTset_terminal_modes, XTreset_terminal_modes):
998 Remove no-ops.
999 (x_create_terminal): Adjust terminal setup.
1000
cf91889a
DA
10012013-09-01 Dmitry Antipov <dmantipov@yandex.ru>
1002
1003 * dispextern.h (SET_TEXT_POS_FROM_MARKER): Indent.
1004 (CLIP_TEXT_POS_FROM_MARKER): New macro.
1005 * dispnew.c (buffer_posn_from_coords):
1006 * window.c (Fwindow_end, displayed_window_lines):
1007 * xdisp.c (redisplay_mode_lines): Use it.
1008
5b0891df
JD
10092013-09-01 Jan Djärv <jan.h.d@swipnet.se>
1010
1011 * fontset.c (face_for_char): Check char in the current face font first
1012 if HAVE_NS (Bug#15138).
1013
0a357e98
MR
10142013-08-31 Martin Rudalics <rudalics@gmx.at>
1015
1016 * window.c (temp_output_buffer_show): Make sure window returned
1017 by display_buffer is live (Bug#15213).
1018
9d7693d7
DA
10192013-08-30 Dmitry Antipov <dmantipov@yandex.ru>
1020
1021 Minor cleanup to avoid forward declarations.
1022 * coding.h (struct ccl_spec): Remove forward declaration.
1023 * composite.h (toplevel): Include font.h.
1024 (struct composition_it, struct face, struct font_metrics):
1025 Remove forward declaration.
1026 * dispextern.h (struct image, struct atimer): Likewise.
1027 * emacsgtkfixed.h (struct frame): Likewise.
1028 * emacsgtkfixed.c (toplevel): Reorder headers and drop stdio.h.
1029 * font.h (struct font_driver, struct font, struct glyph_string)
1030 (struct face): Remove forward declaration.
1031 * fontset.h (struct face, struct font): Likewise.
1032 * frame.h (toplevel): Style cleanup.
1033 (enum output_method): Move to...
1034 * termhooks.h (enum output_method): ...here.
1035 (struct glyph, struct frame, struct ns_display_info)
1036 (struct x_display_info, struct w32_display_info):
1037 Remove forward declaration.
1038 * xterm.h (toplevel): Include termhooks.h.
1039 (struct font, struct window, struct glyph_matrix, struct frame)
1040 (struct input_event, struct face, struct image): Remove forward
1041 declaration.
1042 * gtkutil.h (struct _widget_value): Likewise.
1043 * keyboard.h (toplevel): Include termhooks.h.
1044 (struct input_event): Remove forward declaration.
1045
032f7451
DA
10462013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1047
1048 * intervals.c (set_point_from_marker): New function.
1049 * editfns.c (Fgoto_char):
1050 * process.c (Finternal_default_process_filter):
1051 * window.c (select_window_1): Use it.
1052 * buffer.h (set_point_from_marker): Add prototype.
1053
3f940c5a
EZ
10542013-08-29 Eli Zaretskii <eliz@gnu.org>
1055
1056 * w32.c (term_winsock): Call release_listen_threads before calling
1057 WSACleanup.
1058 (_sys_wait_accept): Wait for accept event in a loop with a finite
1059 timeout, instead of waiting indefinitely. Will hopefully avoid
1060 hanging during exit because WSACleanup deadlocks waiting for the
1061 event object to be released. (Bug#14333)
1062
1063 * w32proc.c (release_listen_threads): New function, signals all
1064 the reader threads that listen for connections to stop waiting.
1065
1066 * w32.h (release_listen_threads): Add prototype.
1067
101ed2bb
DA
10682013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1069
1070 * alloc.c (Fmake_marker, build_marker): Zero need_adjustment
1071 field of new marker (for sanity and safety).
20de2834
DA
1072 * lisp.h (XSETMARKER): Remove unused macro (it doesn't work
1073 anyway because XMISCTYPE is a function and can't be an lvalue).
101ed2bb 1074
1f5cf200
DA
10752013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1076
1077 * xterm.c (x_clear_area): Lost 7th arg because it is always False.
1078 (x_after_update_window_line, x_scroll_bar_create):
1079 (x_scroll_bar_set_handle, XTset_vertical_scroll_bar):
1080 (handle_one_xevent, x_clear_frame_area):
1081 * gtkutil.c (xg_clear_under_internal_border, xg_update_scrollbar_pos):
1082 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Adjust users.
1083 * xterm.h (x_clear_area): Adjust prototype.
1084
d2b36813
DA
10852013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
1086
1087 Hook scanning and indentation functions to find_newline. This helps
1088 to avoid duplicated code and renders more respect to newline cache.
1089 * lisp.h (scan_newline): Prefer ptrdiff_t to EMACS_INT.
1090 * cmds.c (Fforward_line):
1091 * indent.c (scan_for_column, Fcurrent_indentation, indented_beyond_p):
1092 Use find_newline and avoid unnecessary point movements.
1093 * search.c (scan_newline): Implement on top of find_newline.
1094
3ec7babc
SM
10952013-08-28 Stefan Monnier <monnier@iro.umontreal.ca>
1096
1097 * eval.c (Ffuncall): Fix handling of ((lambda ..) ..) in lexically
1098 scoped code (bug#11258).
1099
5ab473cd
JD
11002013-08-28 Davor Cubranic <cubranic@stat.ubc.ca> (tiny change)
1101
1102 * nsterm.m (last_window): New variable.
1103 (EV_TRAILER2): New macro.
1104 (EV_TRAILER): Call EV_TRAILER2.
1105 (mouseMoved:): Add support for mouse-autoselect-window
1106 on nextstep (Bug#6888).
1107
78779650
AS
11082013-08-28 Andreas Schwab <schwab@suse.de>
1109
1110 * regex.c (CHAR_CHARSET, CHARSET_LEADING_CODE_BASE, CHAR_HEAD_P)
1111 (SINGLE_BYTE_CHAR_P, SAME_CHARSET_P, MAKE_CHAR, BYTE8_TO_CHAR):
1112 Remove unused macro definitions.
1113 (CHARSET_RANGE_TABLE_BITS, EXTEND_RANGE_TABLE)
3ec7babc
SM
1114 (SET_RANGE_TABLE_WORK_AREA_BIT, SET_RANGE_TABLE_WORK_AREA):
1115 Only define if emacs.
78779650 1116
c3c4768d
DA
11172013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1118
1119 Prefer enum glyph_row_area to int where appropriate.
1120 * dispextern.h (enum glyph_row_area): Add ANY_AREA member.
1121 Fix comment.
1122 (window_box, window_box_width, window_box_left, window_box_left_offset)
1123 (window_box_right, window_box_right_offset): Adjust prototypes.
1124 * xdisp.c (window_box, window_box_width, window_box_left)
1125 (window_box_left_offset, window_box_right, window_box_right_offset):
1126 Use enum glyph_row_area. Adjust users and tweak comment where needed.
1127 (window_box_edges): Likewise. Lost 2nd arg since it is always ANY_AREA.
1128 * nsterm.m (ns_clip_to_row):
1129 * w32term.c (w32_clip_to_row):
1130 * xterm.c (x_clip_to_row): Likewise.
1131
6bdcbfe1
DA
11322013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1133
1134 * buffer.c (Foverlays_at, Foverlays_in, Fnext_overlay_change)
1135 (Fprevious_overlay_change): Fast path for buffer with no overlays.
1136
50b13cde
PE
11372013-08-28 Paul Eggert <eggert@cs.ucla.edu>
1138
1139 * Makefile.in (SHELL): Now @SHELL@, not /bin/sh,
1140 for portability to hosts where /bin/sh has problems.
1141
f60e429a
DA
11422013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1143
1144 Redesign redisplay interface to drop global output_cursor.
1145 * dispextern.h (struct redisplay_interface): Remove cursor_to member.
1146 (toplevel): Remove declaration of output_cursor.
1147 (set_output_cursor, x_cursor_to): Remove prototype.
1148 * window.h (struct window): New member output_cursor.
1149 (output_cursor_to): New function to replace RIF member.
1150 * dispnew.c (redraw_overlapped_rows, update_marginal_area)
1151 (update_text_area, set_window_cursor_after_update): Use it.
1152 * xdisp.c (output_cursor, set_output_cursor, x_cursor_to): Remove.
1153 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1154 * nsterm.m (ns_update_window_begin, ns_update_window_end):
1155 * w32term.c (x_update_window_begin, x_update_window_end):
1156 * xterm.c (x_update_window_begin, x_update_window_end):
1157 Adjust to use per-window output cursor.
1158
43aac990
PE
11592013-08-27 Paul Eggert <eggert@cs.ucla.edu>
1160
d486344e
PE
1161 Simplify SELECT_TYPE-related code.
1162 Like EMACS_TIME, this portability layer is no longer needed, since
1163 Emacs has been using fd_set as a portability layer for some time.
1164 * sysselect.h (FD_SETSIZE): Rename from MAXDESC. All uses changed.
1165 (SELECT_TYPE): Remove. All uses changed to fd_set.
1166 (fd_set) [!FD_SET]: New typedef.
1167
43aac990
PE
1168 Simplify EMACS_TIME-related code.
1169 This portability layer is no longer needed, since Emacs has been
1170 using struct timespec as a portability layer for some time.
1171 * atimer.h, buffer.h, dispextern.h, xgselect.h:
1172 Include <time.h> rather than "systime.h"; that's all that's needed now.
1173 * dispnew.c: Include <timespec.h> rather than "systime.h";
1174 that's all that's needed now.
1175 * systime.h (EMACS_TIME): Remove. All uses changed to struct timespec.
1176 (EMACS_TIME_RESOLUTION): Remove. All uses changed to
1177 TIMESPEC_RESOLUTION.
1178 (LOG10_EMACS_TIME_RESOLUTION): Remove. All uses changed to
1179 LOG10_TIMESPEC_RESOLUTION.
1180 (EMACS_SECS, emacs_secs_addr): Remove. All uses changed to tv_sec.
1181 (EMACS_NSECS): Remove. All uses changed to tv_nsec.
1182 (make_emacs_time): Remove. All used changed to make_timespec.
1183 (invalid_timespec): Rename from invalid_emacs_time. All uses changed.
1184 (current_timespec): Rename from current_emacs_time. All uses changed.
1185 (add_emacs_time): Remove. All uses changed to timespec_add.
1186 (sub_emacs_time): Remove. All uses change dot timespec_sub.
1187 (EMACS_TIME_SIGN): Remove. All uses changed to timespec_sign.
1188 (timespec_valid_p): Rename from EMACS_TIME_VALID_P. All uses changed.
1189 (EMACS_TIME_FROM_DOUBLE): Remove. All uses changed to dtotimespec.
1190 (EMACS_TIME_TO_DOUBLE): Remove. All uses changed to timespectod.
1191 (current_timespec): Rename from current_emacs_time. All uses changed.
1192 (EMACS_TIME_EQ, EMACS_TIME_LT, EMACS_TIME_LE): Remove. All uses
1193 changed to timespec_cmp.
1194 * xgselect.c: Include <timespec.h>, since our .h files don't.
1195
d350e350
DA
11962013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
1197
1198 * xterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE:)
1199 * nsterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE):
1200 Remove the leftovers.
1201 * gtkutil.c (toplevel): Do not declare Qxft but include
1202 font.h to do so.
1203 * image.c (toplevel): Do not declare Vlibrary_cache because
1204 it's already done in lisp.h.
1205
9fed9729
DA
12062013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
1207
1208 * lisp.h (Mouse_HLInfo): Move from here...
1209 * dispextern.h (Mouse_HLInfo): ...to here and offload lisp.h.
1210 (reset_mouse_highlight): New function.
1211 * msdos.c (dos_set_window_size, IT_update_begin)
1212 (internal_terminal_init):
1213 * nsterm.m (ns_update_window_end, x_free_frame_resources)
1214 (ns_initialize_display_info):
1215 * w32console.c (initialize_w32_display):
1216 * w32term.c (x_update_window_end, x_free_frame_resources)
1217 (w32_initialize_display_info):
1218 * xterm.c (x_update_window_end, x_free_frame_resources, x_term_init):
1219 * window.c (Fdelete_other_windows_internal):
1220 * xdisp.c (clear_mouse_face, cancel_mouse_face): Use it.
1221 * termchar.h (toplevel):
1222 * xterm.h (toplevel): Include dispextern.h.
1223
f462f075
PE
12242013-08-26 Paul Eggert <eggert@cs.ucla.edu>
1225
1226 Fix minor problems found by static checking.
1227 * image.c (XGetPixel, XPutPixel) [HAVE_NS]: Now static.
1228 (expect): Avoid nested-if warning.
1229 (x_build_heuristic_mask) [HAVE_NS]: Avoid unused-var warning.
1230 * nsmenu.m (fillWithWidgetValue:): Avoid type warning.
1231 * nsterm.h, nsterm.m (ns_select):
1232 * xgselect.c, xgselect.h (xg_select):
1233 Adjust signature to better match pselect's.
1234 * nsterm.m (ns_select):
1235 Don't set *TIMEOUT, since pselect doesn't.
1236 * regex.c (whitespace_regexp): Now const_re_char *, to avoid
1237 diagnostic about assigning const char * to it.
1238 * xfaces.c (x_display_info) [HAVE_NS]: Remove; unused.
1239
068f9124
SM
12402013-08-26 Stefan Monnier <monnier@iro.umontreal.ca>
1241
1242 * lread.c (substitute_object_recurse): Handle hash-tables as well
1243 (bug#15190).
1244
f5adc984
PE
12452013-08-26 Paul Eggert <eggert@cs.ucla.edu>
1246
1fc8eb33
PE
1247 Fix unlikely core dump in init_tty, and simplify terminfo case.
1248 * term.c (init_tty) [TERMINFO]: Fix check for buffer overrun.
1249 The old version incorrectly dumped core if malloc returned a
1250 buffer containing only non-NUL bytes.
1251 (init_tty): Do not allocate or free termcap buffers; the
1252 struct does that for us now.
1253 * termchar.h (TERMCAP_BUFFER_SIZE) [!TERMINFO]: New constant.
1254 (struct tty_display_info): Define members termcap_term_buffer and
1255 termcap_strings_buffer only if !TERMINFO, since terminfo doesn't
1256 use them. Allocate them directly in struct rather than indirectly
1257 via a pointer, to simplify init_tty.
1258
f5adc984
PE
1259 * frame.c (check_minibuf_window): Initialize 'window' properly,
1260 so that Emacs reliably aborts later if 'window' is not initialized.
1261
efec3894
JD
12622013-08-26 Jan Djärv <jan.h.d@swipnet.se>
1263
1264 * gtkutil.c (xg_initialize): Set gtk-menu-bar-accel to "" instead
1265 of VoidSymbol (Bug#15154).
1266
e1d0341e
DA
12672013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1268
1269 * lisp.h (Mouse_HLInfo): Drop set-but-unused members
1270 mouse_face_beg_y and mouse_face_end_y.
1271 * xdisp.c (note_tool_bar_highlight, mouse_face_from_buffer_pos)
1272 (mouse_face_from_string_pos, note_mode_line_or_margin_highlight):
1273 Adjust users and update comment where appropriate.
1274
bfff6445
MR
12752013-08-26 Martin Rudalics <rudalics@gmx.at>
1276
1277 * frame.c (check_minibuf_window): New function.
068f9124
SM
1278 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
1279 Call check_minibuf_window (Bug#15183).
bfff6445 1280
c80016b3
DA
12812013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1282
1283 * window.h (struct window): Replace last_cursor with last_cursor_vpos
1284 because this is the only last cursor data we need to keep and consult.
1285 * window.c (replace_window, set_window_buffer, Fsplit_window_internal):
1286 * xdisp.c (mark_window_display_accurate_1, try_cursor_movement):
1287 Adjust users.
1288
de396731
DA
12892013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1290
068f9124
SM
1291 Fix recovering from possible decompression error.
1292 Since insert_from_gap doesn't always move point, we can't use PT as
de396731 1293 the position where the partially decompressed data ends, and
447218dd 1294 should count how many bytes was produced so far.
de396731
DA
1295 * decompress.c (struct decompress_unwind_data): Add nbytes member.
1296 (unwind_decompress): Really delete partially uncompressed data.
1297 (Fzlib_decompress_region): Take decompressed data size into account.
1298
c76826d9
DA
12992013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
1300
1301 * syntax.c (init_syntax_once): Adjust comment and do an early
1302 initialization of Qchar_table_extra_slots just once...
1303 * casetab.c (init_casetab_once):
1304 * category.c (init_category_once):
1305 * character.c (syms_of_character):
1306 * coding.c (syms_of_coding):
1307 * xdisp.c (syms_of_xdisp): ...and omit it here.
1308
b34454d0
EZ
13092013-08-24 Eli Zaretskii <eliz@gnu.org>
1310
11f20add
EZ
1311 * xdisp.c (get_next_display_element): Don't apply to characters
1312 from a display vector the logic of setting it->end_of_box_run_p
1313 suitable for characters from a buffer. (Bug#15175)
1314
b34454d0
EZ
1315 * w32.c (fdutimens): Call 'utime', which is implemented on w32.c
1316 to handle directories, rather than '_utime' which doesn't.
1317 (Bug#15176)
1318
6e1b469e
JD
13192013-08-24 Jan Djärv <jan.h.d@swipnet.se>
1320
1321 * gtkutil.c (x_wm_set_size_hint): Don't set hints when maximized
1322 or fullscreen (Bug#14627).
1323
9c05bccf
PE
13242013-08-24 Paul Eggert <eggert@cs.ucla.edu>
1325
1326 System-dependent integer overflow fixes.
1327 * process.c (Fset_process_window_size): Signal an error if
1328 the window size is outside the range supported by the lower level.
1329 * sysdep.c (set_window_size): Return negative on error,
1330 nonnegative on success, rather than -1, 0, 1 on not in system,
1331 failure, success. This is simpler. Caller changed.
1332 (serial_configure): Remove unnecessary initialization of local.
1333 (procfs_get_total_memory) [GNU_LINUX]: Don't assume system memory
1334 size fits in unsigned long; this isn't true on some 32-bit hosts.
1335 Avoid buffer overrun if some future version of /proc/meminfo has a
1336 variable name longer than 20 bytes.
1337 (system_process_attributes) [__FreeBSD__]:
1338 Don't assume hw.availpages fits in 'int'.
1339
c365c355
PE
13402013-08-23 Paul Eggert <eggert@cs.ucla.edu>
1341
1342 Don't let very long directory names overrun the stack.
1343 Fix some related minor problems involving "//", vfork.
1344 * callproc.c (encode_current_directory): New function.
1345 (call_process): Don't append "/"; not needed.
1346 * fileio.c (file_name_as_directory_slop): New constant.
1347 (file_name_as_directory): Allow SRC to be longer than SRCLEN;
1348 this can save the caller having to alloca.
1349 (Ffile_name_as_directory, Fdirectory_file_name, Fexpand_file_name):
1350 Use SAFE_ALLOCA, not alloca.
1351 (directory_file_name, Fexpand_file_name): Leave leading "//"
1352 alone, since it can be special even on POSIX platforms.
1353 * callproc.c (call_process):
1354 * process.c (Fformat_network_address):
1355 * sysdep.c (sys_subshell):
1356 Use encode_current_directory rather than rolling our own.
1357 (create_process): No need to encode directory; caller does that now.
1358 * process.h (encode_current_directory): New decl.
1359 * sysdep.c (sys_subshell): Work even if vfork trashes saved_handlers.
1360 Rework to avoid 'goto xyzzy;'.
1361
6c6014d4
EZ
13622013-08-23 Eli Zaretskii <eliz@gnu.org>
1363
1364 * xdisp.c (handle_face_prop): If the default face was remapped use
1365 the remapped face for strings from prefix properties. (Bug#15155)
1366
9997ec56
DA
13672013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
1368
1369 Minor cleanup for redisplay interface and few related functions.
1370 * frame.h (enum text_cursor_kinds): Move from here...
1371 * dispextern.h (enum text_cursor_kinds): ...to here.
1372 (toplevel): Drop unnecessary declarations.
1373 (struct redisplay_interface): Use bool and enum text_cursor_kinds
1374 in update_window_end_hook and draw_window_cursor functions.
1375 (display_and_set_cursor, x_update_cursor): Adjust prototypes.
1376 * nsterm.m (ns_update_window_end, ns_draw_window_cursor):
1377 * w32term.c (x_update_window_end,w32_draw_window_cursor):
1378 * xterm.c (x_update_window_end, x_draw_window_cursor):
1379 * xdisp.c (display_and_set_cursor, update_window_cursor)
1380 (update_cursor_in_window_tree, x_update_cursor): Use bool and
1381 enum text_cursor_kinds where appropriate.
1382
7f780da6
DA
13832013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
1384
1385 Redesign redisplay interface to drop updated_row and updated_area.
1386 * dispextern.h (updated_row, updated_area): Remove declaration.
1387 (struct redisplay_interface): Pass glyph row and row area parameters
1388 to write_glyphs, insert_glyphs and clear_end_of_line functions.
1389 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1390 Adjust prototypes.
1391 * dispnew.c (updated_row, updated_area): Remove.
1392 (redraw_overlapped_rows, update_window_line): Adjust user.
1393 (update_marginal_area, update_text_area): Likewise. Pass updated row
1394 as a parameter. Prefer enum glyph_row_area to int where appropriate.
1395 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1396 Adjust users.
1397
26495794
PE
13982013-08-22 Paul Eggert <eggert@cs.ucla.edu>
1399
1400 * process.c (flush_pending_output): Remove stub.
1401 All uses removed.
1402
4a88129a
PE
14032013-08-21 Paul Eggert <eggert@cs.ucla.edu>
1404
1405 * callproc.c: Fix race that killed background processes (Bug#15144).
1406 (call_process): New arg TEMPFILE_INDEX. Callers changed.
1407 Record deleted process-id in critical section, not afterwards.
1408 Don't mistakenly kill process created by a call-process invocation
1409 that discards output and does not wait.
1410
0c5307b0
DA
14112013-08-21 Dmitry Antipov <dmantipov@yandex.ru>
1412
1413 Fix compilation with GC_MARK_STACK == GC_USE_GCPROS_AS_BEFORE
1414 and GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES.
1415 * alloc.c (toplevel): Remove unnecessary nested #if...#endif.
1416 (mark_maybe_object) [!GC_MARK_STACK]: Define to emacs_abort
1417 to shut up compiler in mark_object.
1418 (dump_zombies): Convert to global and add EXTERNALLY_VISIBLE.
1419
0d7c1e66
PE
14202013-08-21 Paul Eggert <eggert@cs.ucla.edu>
1421
1422 * process.c (allocate_pty) [PTY_OPEN]: Set fd's FD_CLOEXEC flag.
1423 We can't portably rely on PTY_OPEN doing that, even if
1424 it calls posix_openpt with O_CLOEXEC.
1425
3f246b65
KH
14262013-08-20 Kenichi Handa <handa@gnu.org>
1427
1428 * character.c (string_char): Improve commentary.
1429
8c2f38aa
PE
14302013-08-20 Paul Eggert <eggert@cs.ucla.edu>
1431
1432 * image.c (SIGNATURE_DIGESTSIZE): Remove.
1433 (struct animation_cache): Make signature a flexible array member.
1434 All uses changed. This is a tad slower but may insulate us better
1435 from future changes to ImageMagick.
1436
bb566cea
PE
14372013-08-19 Paul Eggert <eggert@cs.ucla.edu>
1438
1439 * image.c: Shrink memory needed for animation cache.
1440 (SIGNATURE_DIGESTSIZE): New constant.
1441 (struct animation_cache): Make 'signature' a fixed size array of bytes.
1442 (imagemagick_create_cache): Copy the signature. This saves
1443 several KB of memory that ImageMagick wastes per signature.
1444 Don't bother updating the update_time, as the caller does that now.
1445 (imagemagick_prune_animation_cache): Don't destroy the signature, as
1446 it's a fixed size struct member now.
1447 (imagemagick_get_animation_cache): Always destroy the signature,
1448 as it's now imagemagick_create_cache's responsibility to copy it.
1449 Avoid duplicate calls to strcmp and to imagemagick_create_cache,
1450 and use memcmp rather than strcmp.
1451 eassert that ImageMagick returns a signature of the specified length.
1452
6da26928
LMI
14532013-08-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1454
1455 * image.c (imagemagick_get_animation_cache): Don't segfault on
1456 each invocation.
453f4022
LMI
1457 (imagemagick_get_animation_cache): Revert to previous definition
1458 so that it actually works. But keep the memory leak fix.
1459 (imagemagick_get_animation_cache): Fix memory leak.
6da26928 1460
22490125
PE
14612013-08-19 Paul Eggert <eggert@cs.ucla.edu>
1462
d0139df5
PE
1463 * image.c: Fix animation cache signature memory leak.
1464 Fix some other minor performance problems while we're at it.
1465 (imagemagick_create_cache): Clear just the members that
1466 need clearing. Don't set update_time, as caller does that now.
1467 (imagemagick_prune_animation_cache, imagemagick_get_animation_cache):
1468 Simplify by using pointer-to-pointer instead of a prev pointer.
1469 (imagemagick_prune_animation_cache): Use make_emacs_time rather
1470 than EMACS_TIME_FROM_DOUBLE, and DestroyString rather than free.
1471 (imagemagick_get_animation_cache): Don't xstrdup the image signature;
1472 it's already a copy. Free the signature probe unless it's cached.
1473
22490125
PE
1474 * process.c (handle_child_signal): Fix crash; deleted pid (Bug#15106).
1475 This was introduced by my 2013-08-12 fix for Bug#15035.
1476
deb31e75
DA
14772013-08-19 Dmitry Antipov <dmantipov@yandex.ru>
1478
1479 * image.c (imagemagick_create_cache, imagemagick_get_animation_cache)
1480 (imagemagick_prune_animation_cache): Now static.
1481
319a4d03
LMI
14822013-08-18 Lars Magne Ingebrigtsen <larsi@gnus.org>
1483
1484 * image.c (imagemagick_get_animation_cache): Don't segfault when
1485 pruning all entries.
1486
f747d82e
KB
14872013-08-18 Ken Brown <kbrown@cornell.edu>
1488
1489 * sheap.c (STATIC_HEAP_SIZE): Adjust to current needs; use bigger
1490 static heap if ENABLE_CHECKING is defined.
1491 (max_bss_sbrk_ptr): New variable.
1492 (bss_sbrk): Use it.
1493 (report_sheap_usage): Report maximum static heap usage instead of
1494 ending static heap usage.
1495
d2c28fab
EZ
14962013-08-17 Eli Zaretskii <eliz@gnu.org>
1497
1498 * decompress.c (Fzlib_available_p) [WINDOWSNT]: Update the value
1499 of zlib_initialized according to the results of calling
1500 init_zlib_functions.
1501
274ff63f
LMI
15022013-08-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1503
1504 * image.c: Implement an ImageMagick per-image cache.
8a6f875f 1505 (imagemagick_get_animation_cache): Fix a double-free error.
49ceb676
LMI
1506 (imagemagick_load_image): Remove the ping_wand code, which only
1507 apparently saved time on invalid animated images, and slowed down
1508 everything else. Optimise for the common case.
274ff63f 1509
2bede2ed
XF
15102013-08-16 Xue Fuqiao <xfq.free@gmail.com>
1511
70ff8240
XF
1512 * buffer.c (syms_of_buffer) <buffer-undo-list>: Doc fix.
1513
de179a3e
XF
1514 * editfns.c (insert_before_markers): Mention overlay in the doc string.
1515
2bede2ed
XF
1516 * marker.c (set_marker): Remove documentation of undefined behavior.
1517
703dbeba
LMI
15182013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1519
1520 * image.c (imagemagick_compute_animated_image): Animate correctly
1521 when sub-images are smaller than the main image.
1d18b1e6
LMI
1522 (imagemagick_compute_animated_image): Setting the iterator row to
1523 zero is apparently not allowed.
79670014
LMI
1524 (imagemagick_compute_animated_image): Allow images that say they
1525 have sub-images that are bigger than the main image, but just crop
1526 them.
703dbeba 1527
63216c5e
JD
15282013-08-15 Jan Djärv <jan.h.d@swipnet.se>
1529
1530 * nsmenu.m (menuWillOpen:): Fix preprocessor test (Bug#15001).
1531
a5b5f73f
LMI
15322013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1533
1534 * image.c (imagemagick_compute_animated_image): Respect the GIF
1535 disposal methods.
1536
0fe73012
KB
15372013-08-15 Ken Brown <kbrown@cornell.edu>
1538
1539 * emacs.c (main): Update comment about G_SLICE_ALWAYS_MALLOC.
1540 * gmalloc.c (memalign) [CYGWIN]: Revert last change; it's not
1541 needed.
1542
691a357f
PE
15432013-08-15 Paul Eggert <eggert@cs.ucla.edu>
1544
1545 Fix minor problems found by static checking.
1546 * frame.c (delete_frame):
1547 * xdisp.c (next_element_from_display_vector):
1548 Avoid uninitialized local.
1549 * image.c (imagemagick_compute_animated_image): Port to C89.
1550 Prefer usual GNU indentation style for loops.
1551 Be more careful about bizarrely large sizes, by using ptrdiff_t
1552 instead of int.
1553
42fe2e88
DA
15542013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
1555
1556 Fix infinite frame selection loop (Bug#15025).
1557 * frame.c (delete_frame): Prefer fast ad-hoc loop to next_frame.
1558
d39a3da6
EZ
15592013-08-15 Eli Zaretskii <eliz@gnu.org>
1560
068f9124
SM
1561 * xdisp.c (compute_window_start_on_continuation_line):
1562 When WORD_WRAP is in effect, use move_it_to instead of move_it_by_lines
d39a3da6
EZ
1563 to make sure we end up setting the window start at the leftmost
1564 visible character of the display line. This avoids funky
1565 horizontal shifting because the window start is not kept on the
1566 same position. (Bug#15090)
05426239
EZ
1567 (next_element_from_display_vector): Support 'box' face attribute
1568 in the face definitions of a display vector. (Bug#15099)
d39a3da6 1569
6e856b69
LMI
15702013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1571
1572 * image.c (imagemagick_compute_animated_image): Implement animated
1573 images (bug#14700).
995be755
LMI
1574 (imagemagick_compute_animated_image): Fix some compilation
1575 warnings. Implement a very simple cache to make the animation
1576 usable at all, but it should be replaced with a per-image cache.
6e856b69 1577
d5a1acfa
DA
15782013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
1579
1580 * lisp.h (FOR_EACH_ALIST_VALUE): New macro
1581 to do `for' loops over alist values.
1582 * buffer.h (FOR_EACH_BUFFER):
1583 * process.c (FOR_EACH_PROCESS): Use it.
1584 (handle_child_signal, status_notify, Fget_buffer_process)
1585 (kill_buffer_processes): Use FOR_EACH_PROCESS.
1586
9c253307
DA
15872013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
1588
1589 * term.c (get_named_tty, create_tty_output, tty_free_frame_resources)
1590 (tty_free_frame_resources, delete_tty): Prefer eassert to emacs_abort.
1591 * image.c (make_image_cache): For struct image_cache, prefer xmalloc
1592 to xzalloc and so avoid redundant call to memset.
1593 * xterm.c (x_term_init): Avoid unnecessary initializations of dpyinfo
1594 members because it is allocated with xzalloc and so already zeroed.
1595
05e64f9f
KB
15962013-08-14 Ken Brown <kbrown@cornell.edu>
1597
1598 * gmalloc.c (memalign) [CYGWIN]: Rename to emacs_memalign
1599 (Bug#15094).
1600
5b71542d
DA
16012013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1602
1603 Utility function and macro to copy Lisp string to C string.
1604 * lisp.h (xlispstrdupa): New macro.
1605 (xlispstrdup): New prototype.
1606 * alloc.c (xlispstrdup): New function.
1607 * callint.c (Fcall_interactively):
1608 * fileio.c (Ffile_name_directory, Fexpand_file_name)
1609 (Fsubstitute_in_file_name):
1610 * frame.c (Fmake_terminal_frame): Use xlispstrdupa.
1611 * image.c (x_create_bitmap_from_file):
1612 * w32term.c (w32_term_init):
1613 * xterm.c (x_term_init): Use xlispstrdup.
1614
71530c97
LMI
16152013-08-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1616
4ce82fb8
LMI
1617 * image.c (imagemagick_load_image): Make animated pictures work.
1618 There's still some problems with background color settings, though
1619 (bug#14700).
1620
71530c97
LMI
1621 * decompress.c (unwind_decompress): Always restore point.
1622
7510a061
XF
16232013-08-14 Xue Fuqiao <xfq.free@gmail.com>
1624
1625 * marker.c (set_marker): Reformat documentation.
1626
01c3051f
PE
16272013-08-14 Paul Eggert <eggert@cs.ucla.edu>
1628
aab1fcdf
PE
1629 * xdisp.c (cursor_type_changed): Now static.
1630
01c3051f
PE
1631 * image.c (imagemagick_filename_hint): New arg HINT_BUFFER.
1632 Use changed. This avoids the need to call xmalloc and for the
1633 caller to call xfree, and avoids memory leaks in some situations.
1634
2084152a
DA
16352013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1636
1637 * xdisp.c (adjust_window_ends): Move duplicated code to new function.
1638 (try_window, try_window_reusing_current_matrix, try_window_id): Use it.
94a4e898
DA
1639 (redisplay_window): If window_end_valid is cleared due to non-zero
1640 windows_or_buffers_changed, clear current_matrix_up_to_date_p and
1641 so do not call to try_cursor_movement for that window.
2084152a 1642
02455cb6
DA
16432013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1644
1645 * window.h (struct window): Convert window_end_pos and
1646 window_end_vpos from Lisp_Object to ptrdiff_t and int, respectively.
1647 (wset_window_end_pos, wset_window_end_vpos): Remove.
1648 * dispnew.c (adjust_glyph_matrix):
1649 * window.c (Fwindow_end, replace_window, set_window_buffer)
1650 (make_window):
1651 * xdisp.c (check_window_end, move_it_to, redisplay_internal)
1652 (set_vertical_scroll_bar, redisplay_window, try_window)
1653 (try_window_reusing_current_matrix, find_first_unchanged_at_end_row)
1654 (try_window_id, decode_mode_spec, mouse_face_from_buffer_pos)
1655 (note_mouse_highlight): Adjust users.
1656 (try_cursor_movement): Likewise. Convert old precondition to eassert.
1657 Add comment.
1658
da5707e8
DA
16592013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1660
1661 Fix --enable-gcc-warnings errors introduced in 2013-08-13 commit.
1662 * image.c (imagemagick_filename_hint): Use `const char *' and
1663 prefer SSDATA to SDATA to avoid warnings.
1664
25554267
DA
16652013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1666
1667 Cleanup window fringes, margins and scroll bars adjustments.
1668 * window.c (set_window_fringes, set_window_margins)
1669 (set_window_scroll_bars, apply_window_adjustment): New functions.
1670 (set_window_buffer, Fset_window_margins, Fset_window_fringes)
1671 (Fset_window_scroll_bars): Use them.
1672
38a2c910
DA
16732013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1674
1675 * window.h (struct window): Convert scroll_bar_width
1676 from Lisp_Object to integer. Adjust comment.
1677 (WINDOW_CONFIG_SCROLL_BAR_WIDTH, WINDOW_CONFIG_SCROLL_BAR_COLS):
1678 Adjust users.
1679 * window.c (wset_scroll_bar_width): Remove.
1680 (make_window): Initialize scroll_bar_width.
1681 (Fsplit_window_internal): Use direct assignment.
1682 (Fset_window_configuration, save_window_save):
1683 Convert Lisp_Object to integer and back where appropriate.
1684 (Fset_window_scroll_bars): Adjust user. Return t if any scroll
1685 bar was actually changed, and mention this in docstring.
1686
2d065031
PE
16872013-08-13 Paul Eggert <eggert@cs.ucla.edu>
1688
1689 * decompress.c: Minor simplifications.
1690 (Fzlib_decompress_region): Don't bother verifying
1691 that avail_out <= UINT_MAX, as that was confusing.
1692 Mention the restriction in a comment instead.
1693 Prefer 'int' to 'ptrdiff_t' when 'int' is wide enough.
1694
a5bd5abb
JD
16952013-08-13 Jan Djärv <jan.h.d@swipnet.se>
1696
1697 * nsmenu.m (x_activate_menubar): Check for OSX >= 10.5
1698 (trackingNotification:): Call ns_check_menu_open only for OSX >= 10.5.
1699
66e7901a
LMI
17002013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1701
1702 * image.c (imagemagick_filename_hint): Check for errors in the
1703 alist structure.
1704
2fa611b7
EZ
17052013-08-13 Eli Zaretskii <eliz@gnu.org>
1706
1707 * window.c (Fwindow_margins): Return nil when there's no marginal
1708 area, as per the documented API.
1709
1710 * w32term.c (x_scroll_bar_create): Use ALLOCATE_PSEUDOVECTOR, not
1711 Fmake_vector, as scroll bar's struct members are not all Lisp
1712 objects now. This avoids crashes in GC.
1713
1714 * w32term.h (struct scroll_bar): Convert fringe_extended_p to a
1715 bool, so its address could be taken.
1716
8259030d
LMI
17172013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1718
1719 * image.c (imagemagick_filename_hint): New function to possibly
1720 apply `image-content-type-suffixes'.
1721 (imagemagick_load_image): Use it.
1722
866c710e
EZ
17232013-08-13 Eli Zaretskii <eliz@gnu.org>
1724
1725 * decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil
1726 if loading zlib failed.
1727
f10490f0
JD
17282013-08-13 Jan Djärv <jan.h.d@swipnet.se>
1729
96311be7
JD
1730 * nsterm.m (ns_set_vertical_scroll_bar): Fix breakage intruduced by
1731 2013-08-13 checkin below. Change bool to BOOL, rule is:
1732 All Obj-C code uses BOOL, except for interfaces callable from C.
1733
f10490f0
JD
1734 * nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).
1735
c8ae93b0
DA
17362013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1737
1738 * window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
1739 * nsterm.m (ns_set_vertical_scroll_bar): Use it. Use convenient
1740 bool instead of BOOL.
1741 * w32term.h (struct scroll_bar): Convert fringe_extended_p
1742 from Lisp_Object to bitfield. Adjust comment.
1743 * w32term.c (x_scroll_bar_create): Adjust user.
1744 Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
1745 * xterm.c (XTset_vertical_scroll_bar): Likewise.
1746 Use bool for boolean.
1747 * xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
1748 to `unsigned int' when defining a bitfield.
1749
53b64418
PE
17502013-08-13 Paul Eggert <eggert@cs.ucla.edu>
1751
1752 * decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
1753
eeaf9bf3
DA
17542013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1755
1756 * window.h (struct window): Convert left_margin_cols and
1757 right_margin_cols from Lisp_Objects to integers. Adjust comment.
1758 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
1759 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
1760 Adjust users.
1761 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
1762 Adjust comment.
1763 (showing_window_margins_p, update_window_line, update_frame_1):
1764 * fringe.c (draw_fringe_bitmap_1):
1765 * xdisp.c (window_box_width): Adjust users.
1766 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
1767 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
1768 Use direct assignment.
1769 (Fset_window_configuration, save_window_save, Fwindow_margins):
1770 Convert Lisp_Object to integer and back where appropriate.
1771 (Fset_window_margins): Adjust user. Return t if any margin
1772 was actually changed, and mention this in docstring.
1773
956720af
XF
17742013-08-13 Xue Fuqiao <xfq.free@gmail.com>
1775
f73f4ce6 1776 * syntax.c (forward_word):
956720af
XF
1777 * cmds.c (forward_char, backward_char): Mention the optional argument.
1778
9e37ee3b
DA
17792013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1780
1781 * window.h (struct window): Convert left_fringe_width
1782 and right_fringe_width from Lisp_Objects to integers.
1783 Adjust comment.
1784 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
1785 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
1786 * window.c (wset_left_fringe_width, wset_right_fringe_width):
1787 Remove.
1788 (make_window): Initialize new integer fields to -1.
1789 (Fsplit_window_internal): Use direct assignment.
068f9124
SM
1790 (Fset_window_configuration, save_window_save):
1791 Convert Lisp_Object to integer and back where appropriate.
9e37ee3b
DA
1792 (Fset_window_fringes): Adjust user. Return t if any fringe
1793 was actually changed, and mention this in docstring.
1794
e4375ca7
DA
17952013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1796
1797 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
9cda66e4
DA
1798 * nsfns.m (x_set_cursor_type):
1799 * w32fns.c (x_set_cursor_type):
1800 * xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
1801 * xdisp.c (set_frame_cursor_types): ...but in common code.
e4375ca7 1802
a45543bc
DA
18032013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1804
1805 * font.c (clear_font_cache): New function, stripped from...
1806 (Fclear_font_cache): ...here, which now uses the function
1807 above. Adjust comment.
1808 * font.h (clear_font_cache): Add prototype.
1809 * xfaces.c (clear_face_cache): Use clear_font_cache.
1810
ae966a86
DA
18112013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1812
1813 * window.c (Fset_window_start): Compare `w', not `window' because
1814 `w' might not be equal to `window' after call to decode_live_window.
1815
297a545b
PE
18162013-08-12 Paul Eggert <eggert@cs.ucla.edu>
1817
1818 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
1819 This fixes a problem introduced by the Bug#15035 patch
1820 when using GPG. Reported by Herbert J. Skuhra.
1821
aa942e2b
EZ
18222013-08-12 Eli Zaretskii <eliz@gnu.org>
1823
1824 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
1825 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
1826 not yet initialized.
1827
7699d09e
LMI
18282013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1829
1830 * decompress.c (Fzlib_decompress_region): Support zlib
1831 decompression, too, and rename.
1832
1d238bc7
PE
18332013-08-12 Paul Eggert <eggert@cs.ucla.edu>
1834
1835 Minor zlib configuration tweaks.
1836 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
1837 Don't assume presence of fn_inflateInit2_ zlib internal function.
1838
8a44a184
LMI
18392013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1840
1841 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
1842 include the zlib prefix.
1843
594a4307
EZ
18442013-08-12 Eli Zaretskii <eliz@gnu.org>
1845
1846 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
1847 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
1848 define static variables that are pointers to zlib functions to be
1849 dynamically loaded.
1850 (init_zlib_functions) [WINDOWSNT]: New function.
1851 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
1852 New macros.
1853 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
1854 macros instead of invoking the zlib functions directly.
068f9124
SM
1855 (syms_of_decompress): DEFSYM Qzlib_dll.
1856 Staticpro Szlib_available_p.
594a4307 1857
d2e113bc
DA
18582013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
1859
1860 Avoid looping over all frame windows to freeze and unfreeze.
1861 * window.h (struct window): Drop frozen_window_start_p.
1862 (freeze_window_starts): Drop prototype.
1863 * frame.h (struct frame): New frozen_window_starts flag.
1864 (FRAME_WINDOWS_FROZEN): New macro.
1865 * window.c (freeze_window_start, freeze_window_starts):
1866 Remove.
1867 (select_window, replace_window): Adjust users.
1868 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
1869 (window_frozen_p): New function.
1870 (redisplay_window): Use it.
1871
94fcd171
PE
18722013-08-12 Paul Eggert <eggert@cs.ucla.edu>
1873
1874 Fix some fd issues when running subprocesses (Bug#15035).
1875 Fix bugs that can leak files or file descriptors on errors.
1876 Don't unlink open temp files, as that's hard for users to diagnose
1877 when things go awry (e.g., temp disk exhausted).
1878 Don't bother to lock temp files. Check for invalid recursion.
1879 * callproc.c (synch_process_fd): Remove. All uses removed.
1880 (synch_process_tempfile): New var or macro.
1881 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
1882 New constants.
1883 (record_kill_process): New arg, the temp name. All callers changed.
1884 (delete_temp_file): Now just a simple wrapper around unlink.
1885 (call_process_kill): New arg, the call_process_fd array.
1886 Close them all. Clear synch_process_pid. Remove the temp file,
1887 or arrange for it to be removed.
1888 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
1889 that's been moved to synch_process_tempfile. Caller changed.
1890 Do not remove the tempfile; that's now call_process_kill's
1891 responsibility.
1892 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
1893 call_process_kill; the caller now does that.
1894 (call_process_cleanup): Do not close the process fd; that's now
1895 call_process_kill's responsibility.
1896 (Fcall_process): Implement via new function call_process, which
1897 has most of the old body of Fcall_process, but with a different API.
1898 (call_process): New function that does not open or close filefd if
1899 it is nonnegative. Record which fds need to be closed, and let
1900 call_process_kill close (and remove the tempfile, on MSDOS) on error.
1901 Signal an error if invoked recursively (could be done via a hook).
1902 Simplify creation of the tempfile in the MSDOS case.
1903 Don't create the output file until after checking for the executable.
1904 Report any failure to open /dev/null.
1905 Don't open /dev/null for writing twice; once is enough.
1906 Don't create pipe if all output is being discarded or sent to file.
1907 Don't worry about setting up the coding system or reading from the
1908 pipe if all output is being discarded.
1909 Hoist fd_error local into top level, to lessen block nesting.
1910 Don't record deleted pid here; now done by Fcall_process_region.
1911 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
1912 and note its success in synch_process_tempfile.
1913 Do not leak resources when child_setup fails.
1914 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
1915 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
1916 (create_temp_file): Now returns open fd, with an additional
1917 Lisp_Object * argument to return the name. All callers changed.
1918 Do not close the file; rewind it instead, and leave it open for
1919 the caller. Do not lock the temp file. Unwind-protect the file
1920 and the file-descriptor.
1921 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
1922 If an asynchrounous process, record it here, not in call_process.
1923 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
1924 * eval.c (set_unwind_protect): New function.
1925 * fileio.c (write_region): New function, generalized from the
1926 old Fwrite_region. Do not lock temp files.
1927 (Fwrite_region): Use it.
1928 * lisp.h (set_unwind_protect, write_region): New decls.
1929 * process.c: Include <verify.h>.
1930 (make_process): Mark fds as initially closed.
1931 (deleted_pid_list): Now a list of pid-filename pairs.
1932 All uses changed.
1933 (close_process_fd): New function.
1934 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
1935 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
1936 New constants. Verify that their number matches PROCESS_OPEN_FDS.
1937 (create_process, create_pty, Fmake_serial_process)
1938 (server_accept_connection): Record which fds need to be closed,
1939 and let deactivate_process close them.
1940 (Fmake_network_process): Do not discard the unwind-protect
1941 until it's safe to do so.
1942 (deactivate_process): Close the fds opened by create_process etc.
1943 (Fprocess_send_eof): Adjust to new way of recording open fds.
1944 Report an error if /dev/null can't be opened, instead of aborting.
1945 * process.h (PROCESS_OPEN_FDS): New constant.
1946 (struct Lisp_Process): New member open_fds.
1947 (record_kill_process, record_deleted_pid): Adjust signatures.
1948 (record_deleted_pid): Move decl here ...
1949 * syswait.h (record_deleted_pid): ... from here.
1950
d0e615c3
PE
19512013-08-11 Paul Eggert <eggert@cs.ucla.edu>
1952
1953 * decompress.c: Fix bugs with large buffers and weird inputs.
1954 Tune a bit. Reindent as per usual Emacs style.
1955 (BUFFER_SIZE): Remove.
1956 (Fdecompress_gzipped_region): Do not mishandle input buffers with
1957 more than UINT_MAX bytes. Decompress into the gap instead of into
1958 an auto buffer, as this should avoid copying. Return nil if
1959 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
1960 set immediate_quit; we shouldn't trust zlib code that much.
1961
313546eb
LMI
19622013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1963
99a32242
LMI
1964 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
1965 errors, and really move the gap to where we want it.
1966
313546eb
LMI
1967 * lisp.h: Include decompress.c support.
1968
1969 * emacs.c (main): Include decompress.c support.
1970
1971 * Makefile.in: Include -lz if present.
1972
d2d699ac
JD
19732013-08-11 Jan Djärv <jan.h.d@swipnet.se>
1974
f90e3ebd
JD
1975 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
1976 (initWithTitle:): Initialize frame to 0.
1977 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
068f9124 1978 (fillWithWidgetValue:frame:): Rename from
f90e3ebd
JD
1979 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
1980
1981 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
1982 fillWithWidgetValue:frame:
1983
423d3b3f
JD
1984 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
1985 remove memory leak warnings.
1986
d2d699ac
JD
1987 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
1988 (ns_check_menu_open): Handle menu == nil. Remove assignment to
1989 menu_pending_title.
1990
1991 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
1992 (x_activate_menubar): Update the whole menu.
1993 (trackingNotification:): Call ns_check_menu_open if tracking ends.
1994 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
1995 current event is not NSSystemDefined (Bug#15001).
1996 Call ns_check_menu_open only if trackingMenu is 2.
1997 (menuDidClose:): New method, decrease trackingMenu.
1998 (fillWithWidgetValue:setDelegate:): New method.
1999 (fillWithWidgetValue:): Call the above.
2000
2001 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
2002
7d652d97
PE
20032013-08-11 Paul Eggert <eggert@cs.ucla.edu>
2004
2005 Omit some unnecessary casts.
2006 Many of these go back to the old pre-C89 days, when they may have
2007 been needed, but we've been assuming C89 or later for a while now.
2008 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
2009 (live_float_p, live_misc_p, live_vector_p):
2010 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
2011 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
2012 (defvar_per_buffer):
2013 * callint.c (Fcall_interactively):
2014 * doc.c (Fsubstitute_command_keys):
2015 * filelock.c (get_boot_time):
2016 * frame.c (xrdb_get_resource):
2017 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
2018 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
2019 (xg_get_file_name_from_selector, menuitem_destroy_callback)
2020 (menuitem_highlight_callback, menu_destroy_callback)
2021 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
2022 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
2023 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
2024 (xg_tool_bar_help_callback, tb_size_cb):
2025 * image.c (xpm_alloc_color, png_read_from_memory)
2026 (png_read_from_file, png_load_body, our_memory_skip_input_data)
2027 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
2028 (syms_of_image):
2029 * keymap.c (describe_map):
2030 * nsfns.m (Fns_display_monitor_attributes_list):
2031 * nsmenu.m (process_dialog:):
2032 * nsterm.m (hold_event):
2033 * process.c (wait_reading_process_output):
2034 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
2035 * scroll.c (do_direct_scrolling, scrolling_1):
2036 * termcap.c (tgetent):
2037 * window.c (check_window_containing, add_window_to_list)
2038 (freeze_window_starts):
2039 * xdisp.c (compare_overlay_entries, vmessage):
2040 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
2041 (x_get_monitor_attributes_xrandr)
2042 (Fx_display_monitor_attributes_list, x_display_info_for_name)
2043 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
2044 * xfont.c (xfont_match, xfont_open):
2045 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
2046 (menubar_selection_callback, menu_position_func)
2047 (popup_selection_callback, create_and_show_popup_menu)
2048 (dialog_selection_callback, create_and_show_dialog):
2049 * xrdb.c (x_get_string_resource):
2050 (main) [TESTRM]:
2051 * xsmfns.c (x_session_check_input):
2052 * xterm.c (x_draw_glyphless_glyph_string_foreground)
2053 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
2054 (xaw_jump_callback, xaw_scroll_callback):
2055 Omit unnecessary casts.
2056
9acc1074
PE
20572013-08-10 Paul Eggert <eggert@cs.ucla.edu>
2058
2059 Minor string-length refactoring.
2060 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
2061 * frame.c (make_monitor_attribute_list):
2062 Prefer build_string to strlen + make_string.
2063
361c0eb8
JD
20642013-08-10 Jan Djärv <jan.h.d@swipnet.se>
2065
2066 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
2067 don't check minor_code (Bug#14417).
2068
14ba0822
EZ
20692013-08-09 Eli Zaretskii <eliz@gnu.org>
2070
2071 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
2072 vertical positions instead. This avoids calling MATRIX_ROW with
2073 row numbers that are possibly beyond valid limits. (Bug#15064)
2074
309f24d1
DA
20752013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
2076
2077 Use xstrdup and build_unibyte_string where applicable.
2078 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
2079 * xfns.c (x_window):
2080 * xrdb.c (x_get_customization_string):
2081 * xterm.c (xim_initialize):
2082 * w32fns.c (w32_window): Use xstrdup.
2083 (w32_display_monitor_attributes_list):
2084 * emacs.c (init_cmdargs):
2085 * keyboard.c (PUSH_C_STR):
2086 * nsfont.m (nsfont_open):
2087 * sysdep.c (system_process_attributes):
2088 * w32.c (system_process_attributes):
2089 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
2090
55902276
EZ
20912013-08-09 Eli Zaretskii <eliz@gnu.org>
2092
2093 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
2094 variables of these types so that GDB would know about them, as aid
2095 for debugging fatal exceptions. (Bug#15024) See also
2096 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
2097 discussions.
2098
10bf7f5a
JD
20992013-08-08 Jan Djärv <jan.h.d@swipnet.se>
2100
2101 * nsterm.m (ns_update_begin): Don't change clip path if it would be
2102 larger than the NSWindow (Bug#14934).
2103
65620264
DA
21042013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2105
2106 Redesign redisplay interface to drop global variable updated_window.
2107 Always pass currently updated window as a parameter to update routines.
2108 * dispextern.h (updated_window): Remove declaration.
2109 (struct redisplay_interface): Pass window parameter to
2110 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
2111 and after_update_window_hook.
2112 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
2113 Adjust prototypes.
2114 * dispnew.c (updated_window): Remove.
2115 (redraw_overlapped_rows, update_marginal_area, update_text_area)
2116 (update_window_line): Adjust to match redisplay interface changes.
2117 * nsterm.m (ns_update_window_begin, ns_update_window_end)
2118 (ns_scroll_run, ns_after_update_window_line):
2119 * w32term.c (x_update_window_begin, x_update_window_end)
2120 (x_after_update_window_line, x_scroll_run):
2121 * xterm.c (x_update_window_begin, x_update_window_end)
2122 (x_after_update_window_line, x_scroll_run):
2123 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
2124 Likewise. Adjust comments where appropriate.
2125 (x_cursor_to): Simplify because this is always called during window
2126 update (but install debugging check anyway).
2127 (expose_window): Check must_be_updated_p flag to see whether this
2128 function is called during window update.
2129
628fdc56
DA
21302013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2131
2132 Do not reset window modification event counters excessively.
2133 These leftovers and poor man's tricky methods to catch extra
2134 redisplay's attention are no longer needed.
2135 * frame.c (set_menu_bar_lines_1):
2136 * minibuf.c (read_minibuf_unwind):
2137 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
2138 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
2139 (window_scroll_line_based, Fset_window_configuration):
2140 * xdisp.c (redisplay_window): Do not reset last_modified and
2141 last_overlay_modified counters.
2142
8fd9c92e
JD
21432013-08-07 Jan Djärv <jan.h.d@swipnet.se>
2144
2145 * xselect.c (x_send_client_event): Set send_event and serial, memset
2146 data.l as it might be bigger than data.b. Use 24 bit mask to
2147 XSendEvent (Bug#15034).
2148
0ee18172
EZ
21492013-08-07 Eli Zaretskii <eliz@gnu.org>
2150
2151 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
2152 for TTY frames that are not the top frame on their console.
2153 (Bug#14616)
2154
16ddd1a6
MR
21552013-08-07 Martin Rudalics <rudalics@gmx.at>
2156
2157 * w32term.c (w32fullscreen_hook): Really maximize frame when
2158 asked for (Bug#14841).
2159
d2a95ffb
DA
21602013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2161
2162 Prefer selected_window to Fselected_window, likewise for frames.
2163 * buffer.c (Fbuffer_swap_text):
2164 * data.c (Fvariable_binding_locus):
2165 * window.c (run_window_configuration_change_hook): Adjust users.
2166 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
2167 Use decode_live_frame.
2168
170da1ec
DA
21692013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2170
2171 Be more careful if selected window shows the buffer other than current,
2172 use window_outdated only if this is not so. This change should also
2173 address some weird issues discussed in Bug#13012.
2174 * window.h (window_outdated): New prototype.
2175 * window.c (window_outdated): Now here. Convert from static and
2176 always assume window's buffer.
2177 (Fwindow_end, Fwindow_line_height): Use it.
2178 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
2179 and always assume window's buffer.
2180 (redisplay_window): Adjust user.
e5eefe9b 2181 (redisplay_internal): Call to reconsider_clip_changes once and
170da1ec
DA
2182 check whether mode line should be updated only if selected window
2183 shows current buffer.
2184 (run_window_scroll_functions): Use eassert for debugging check.
2185 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
2186
56b5d5b1
DA
21872013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2188
2189 * window.c (window_scroll, window_scroll_pixel_based)
2190 (window_scroll_line_based): Use bool for booleans.
2191
2878ba7e
PE
21922013-08-06 Paul Eggert <eggert@cs.ucla.edu>
2193
2194 * process.c: Fix minor off-by-one issues in descriptor counts.
2195 This shouldn't fix any real bugs, but it cleans up the code a bit.
2196 (max_process_desc, max_input_desc): -1, not 0, means none.
2197 All uses changed.
2198 (delete_input_desc): New function.
2199 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
2200 (deactivate_process): Scan backwards when recomuting max_process_desc;
2201 that should be faster.
2202 (init_process_emacs): Initialize max_input_desc.
2203
e30b79c1
DA
22042013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2205
2206 Use region cache to speedup bidi_find_paragraph_start.
2207 * buffer.h (struct buffer): New member bidi_paragraph_cache.
2208 Rename cache_long_line_scans to cache_long_scans.
2209 * buffer.c (bset_cache_long_line_scans): Rename to
2210 bset_cache_long_scans.
2211 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
2212 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
2213 into account.
2214 (syms_of_buffer): Rename cache-long-line-scans to
2215 cache-long-scans. Adjust docstring.
2216 * search.c (newline_cache_on_off):
2217 * indent.c (width_run_cache_on_off): Adjust users.
2218 * bidi.c (bidi_paragraph_cache_on_off): New function.
2219 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
068f9124
SM
2220 * insdel.c (prepare_to_modify_buffer):
2221 Invalidate bidi_paragraph_cache if enabled.
e30b79c1 2222
00012b86
DA
22232013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2224
2225 Invalidate region caches only if buffer text is going to be changed.
2226 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
2227 (modify_text): ...new prototype.
2228 (prepare_to_modify_buffer_1): New prototype.
2229 * textprop.c (modify_region): Rename to...
2230 (modify_text_properties): ...new function.
2231 (add_text_properties_1, set_text_properties, Fremove_text_properties)
2232 (Fremove_list_of_text_properties): Adjust users.
2233 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
2234 (modify_text): ...new function.
2235 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
2236 (prepare_to_modify_buffer_1): ...new function.
2237 * casefiddle.c (casify_region):
2238 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
2239 (Ftranspose_regions): Use modify_text.
2240
dc6c0eda
SM
22412013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
2242
2243 * lisp.mk (lisp): Add nadvice.elc.
2244
8f3a2c26
DA
22452013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
2246
2247 New macro to iterate over live buffers similar to frames.
2248 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
2249 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
2250 Declare buffer-related variables here to offload lisp.h.
2251 * buffer.c (Vbuffer_alist): Adjust comment.
2252 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
2253 (other_buffer_safely):
2254 * data.c (store_symval_forwarding):
2255 * dispnew.c (Fframe_or_buffer_changed_p):
2256 * fileio.c (Fdo_auto_save):
2257 * filelock.c (unlock_all_files):
2258 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
2259
e0fdb694
PE
22602013-08-04 Paul Eggert <eggert@cs.ucla.edu>
2261
2262 Fix some minor races in hosts lacking mkostemp (Bug#15015).
2263 * callproc.c (create_temp_file):
2264 * filelock.c (create_lock_file):
2265 Assume mkostemp, since it's now provided by Gnulib.
2266
63f5c6c2
EZ
22672013-08-04 Eli Zaretskii <eliz@gnu.org>
2268
2269 * w32.c (mkostemp): New function.
2270 (mktemp): Remove, no longer used. Most of the code reused in
2271 mkostemp. (Bug#15015)
484ab239 2272 (mktemp): Don't undef.
63f5c6c2 2273
f0b79313
DA
22742013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
2275
2276 * dispnew.c (glyph_matrix_count, glyph_pool_count):
2277 Move under GLYPH_DEBUG and ENABLE_CHECKING.
2278 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
2279 (free_glyph_pool, check_glyph_memory): Likewise for
2280 all users. Adjust comments where appropriate.
2281
98f638d6
PE
22822013-08-03 Paul Eggert <eggert@cs.ucla.edu>
2283
2284 * composite.h: Minor fixups.
2285 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
2286 to fix a misspelling, and change it to an inline function while
2287 we're at it (it need not be a macro). All uses changed.
2288 (composition_method, composition_valid_p):
2289 Rewrite to avoid assignments in if-conditions.
2290
75c59fb3
DA
22912013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
2292
2293 Do not use global Lisp_Object in composition macros.
2294 * composite.h (composition_temp): Remove declaration.
2295 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
2296 (composition_method, composition_valid_p): ...inline functions.
416a3e01 2297 (compose_region): Remove the leftover.
75c59fb3
DA
2298 * composite.c (composition_temp): Remove.
2299 (run_composition_function, update_compositions)
2300 (composition_compute_stop_pos, composition_adjust_point)
2301 (Ffind_composition_internal):
2302 * coding.c (handle_composition_annotation):
2303 * xdisp.c (handle_composition_prop, check_point_in_composition):
2304 Related users changed.
2305
a10c8269
DA
23062013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
2307
2308 Drop FRAME_PTR typedef.
2309 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
2310 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
2311 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
2312 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
2313 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
2314 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
2315 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
2316 All related users changed.
2317
a104f656
SM
23182013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2319
2320 * eval.c (default_toplevel_binding): New function.
2321 (Fdefvar): Use it.
2322 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
2323 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
2324 (syms_of_eval): Export them.
2325 * data.c (Fdefault_value): Micro cleanup.
2326 * term.c (init_tty): Use "false".
2327
4b5c9326
DA
23282013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
2329
2330 Fix X GC leak in GTK and raw (no toolkit) X ports.
2331 * xterm.c (x_free_frame_resources): If white and black relief
2332 GCs are allocated, always free them here.
2333 * xfns.c (x_make_gc): Omit redundant initialization.
2334 * widget.c (create_frame_gcs): Remove the leftover.
2335 (EmacsFrameDestroy): Do nothing because all GCs are now freed
2336 in x_free_frame_resources.
2337
b19aa636
JD
23382013-08-02 Jan Djärv <jan.h.d@swipnet.se>
2339
2340 * nsterm.m (windowWillResize:toSize:): Only change title if
2341 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
2342 modifying it.
2343 (viewDidEndLiveResize): New method.
2344
2345 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
2346 inside NS_IMPL_COCOA.
2347
af1f7e06
DA
23482013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
2349
2350 * insdel.c (adjust_after_replace, replace_range, del_range_2):
2351 Do not check whether undo is enabled because record_insert and
2352 record_delete does that themselves.
2353
65b02bb9
DA
23542013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
2355
2356 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
2357 member which is not really used any more.
2358 (FRAME_XIC_BASE_FONTNAME): Remove.
2359 * xfns.c (xic_free_fontset): Adjust user.
2360 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
2361 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
2362 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
2363 (xdialog_show): Use eassert for debugging check.
7ee0f047 2364 * w32term.c (x_unfocus_frame): Remove unused dummy function.
65b02bb9 2365
6318cde0
PE
23662013-08-01 Paul Eggert <eggert@cs.ucla.edu>
2367
2368 * fileio.c, fns.c (merge): Move extern decl from here ...
2369 * lisp.h (merge): ... to here.
2370
6c1a09ba
DA
23712013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2372
2373 Fix last font-related change.
2374 * w32font.h (w32font_list_internal, w32font_match_internal):
2375 Fix prototype.
2376 * w32uniscribe.c (uniscribe_list, uniscribe_match):
2377 (uniscribe_list_family): Adjust to match font API change.
2378 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
2379 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
2380
f8c20208
DA
23812013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2382
2383 * frame.h (FRAME_MOUSE_UPDATE):
2384 * nsterm.m (ns_frame_up_to_date): Omit redundant check
2385 whether hlinfo->mouse_face_mouse_frame is non-NULL.
2386
fdb396e2
DA
23872013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2388
2389 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
2390 * font.h (struct font_driver): Change list, match, and list_family
2391 functions to accept struct frame * as first arg.
068f9124
SM
2392 * font.c (font_score, font_compare, font_sort_entities):
2393 Remove prototypes.
fdb396e2
DA
2394 (font_sort_entities, font_list_entities, font_select_entity):
2395 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
2396 match font API change.
2397 * xfont.c (xfont_list, xfont_match, xfont_list_family):
2398 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
2399 * ftxfont.c (ftxfont_list, ftxfont_match):
2400 * xftfont.c (xftfont_list, xftfont_match):
2401 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
2402 * w32font.c (w32font_list, w32font_match, w32font_list):
2403 (w32font_list_internal, w32_font_match_internal): Likewise.
2404 * xfaces.c (Fx_family_fonts): Adjust user.
2405
52b8a085
DA
24062013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2407
2408 Do not use pure Xism x_wm_set_icon_position in non-X ports.
2409 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
2410 only if HAVE_X_WINDOWS is in use.
2411 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
2412 * nsterm.m (x_wm_set_icon_position): Remove no-op.
2413 * w32term.c (x_wm_set_icon_position): Likewise.
2414 * w32fns.c (x_icon): Adjust user.
2415
c791c18e
DA
24162013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2417
2418 * xterm.c (last_mouse_press_frame): Remove the
2419 leftover which is not really used any more.
2420 (handle_one_xevent, syms_of_xterm): Adjust users.
1ca6cc28
DA
2421 (x_flush): Call XFlush once per each X display, not frame.
2422 This is better because this code always unconditionally skips
2423 non-X frames in Vframe_list and issues the only XFlush if we
2424 have more than one X frame on the same X display.
2f935d86
DA
2425 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
2426 Use bool for booleans.
2427 (x_draw_glyph_string_background, cvt_string_to_pixel):
2428 (cvt_pixel_dtor): Drop unnecessary prototypes.
2429 * xterm.h (x_display_ok): Adjust prototype.
c791c18e 2430
f435830e
DA
24312013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2432
2433 Drop unnecessary functions that deals with frame pixel size.
2434 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
2435 (x_pixel_height): Drop prototypes.
2436 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
2437 (x_pixel_height): Drop implementations.
2438 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
2439 which should be always valid for window frame.
2440 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
2441 * w32menu.c (Fx_popup_dialog):
2442 * xmenu.c (Fx_popup_dialog): Likewise for both.
2443
84231434
DA
24442013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2445
2446 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
2447 frame parameters and call to Fmodify_frame_parameters just once.
4c131798
DA
2448 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
2449 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
2450 and mention nil frame in docstring.
84231434 2451
959067a1
DA
24522013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2453
2454 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
2455 (x_figure_window_size): Likewise. Adjust to return long.
2456 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
2457 (toplevel): Move Qterminal_live_p to...
2458 * terminal.c (toplevel): ...here, make it static, and...
2459 (syms_of_terminal): ...DEFSYM here.
2460 * frame.h (Qterminal_live_p): Remove declaration.
2461 (make_frame, x_figure_window_size): Adjust prototype.
2462 * nsfns.m (Fx_create_frame): Use long for window flags.
2463
f4b169ce
PE
24642013-07-30 Paul Eggert <eggert@cs.ucla.edu>
2465
2466 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
2467 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
2468 Do not assume that emacs_close (INT_MAX) is a no-op.
2469
bee6a2c7
DA
24702013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2471
2472 * xfaces.c (make_face_cache): For struct face_cache, prefer
2473 xmalloc to xzalloc and so avoid redundant call to memset.
2474 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
2475
d7e6881a
DA
24762013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2477
2478 * fringe.c (draw_window_fringes, update_window_fringes)
2479 (compute_fringe_widths):
2480 * w32term.c (x_draw_glyph_string):
2481 * window.c (candidate_window_p, Frecenter):
2482 * xfaces.c (realize_basic_faces, realize_default_face)
2483 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
2484 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
2485 * xfns.c (x_set_cursor_color, xic_free_xfontset):
2486 * xmenu.c (Fx_menu_bar_open_internal):
2487 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
2488 * xsettings.c (xft_settings_event):
2489 * xterm.c (x_draw_glyph_string, x_had_errors_p):
2490 Use bool for booleans. Adjust style and comments where
2491 appropriate.
2492 * dispextern.h (draw_window_fringes, update_window_fringes)
2493 (compute_fringe_widths):
2494 * xterm.h (x_had_errors_p): Adjust prototype.
2495
ec3058af
DA
24962013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2497
2498 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
2499 CHECK_LIST. Rewrite the loop to avoid useless local variable.
2500
218e0637
DA
25012013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
2502
2503 * fns.c (toplevel): Remove comment before Fsafe_length because
2504 it checks for QUIT.
2505
e560aba9
PE
25062013-07-28 Paul Eggert <eggert@cs.ucla.edu>
2507
2508 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
2509
2e5ce5de
EZ
25102013-07-28 Eli Zaretskii <eliz@gnu.org>
2511
2512 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
2513 frame which got the message is still alive, before dereferencing
2514 its pointer. (Bug#14970)
2515
2516 * frame.c (delete_frame): Test "this" frame's minibuffer window to
2517 be a live window, before using it as such. (Bug#14970)
2518
e95da6d3
EZ
25192013-07-27 Eli Zaretskii <eliz@gnu.org>
2520
2521 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
2522 w32_detect_focus_change instead of doing part of its job by hand.
2523 This fixes the problem whereby FOCUS_OUT events were not sent to
2524 the event queue.
2525
a8f93651
EZ
25262013-07-26 Eli Zaretskii <eliz@gnu.org>
2527
fec92060
EZ
2528 * process.c (Fprocess_list): Doc fix.
2529
a8f93651
EZ
2530 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
2531 being re-exposed only if it didn't ask to become visible.
2532 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
2533 was previously iconified. (Bug#14841)
2534 (x_iconify_frame): Mark the frame iconified.
2535
d5a7a9d9
PE
25362013-07-26 Paul Eggert <eggert@cs.ucla.edu>
2537
2538 Fix minor problems found by static checking.
2539 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
2540 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
2541
56ea7291
SM
25422013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
2543
2544 * eval.c (set_specpdl_old_value): New function.
2545 (unbind_to): Minor simplification.
2546 (get_backtrace_frame): New function.
2547 (Fbacktrace_frame): Use it. Add `base' argument.
2548 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
2549 (syms_of_eval): Export backtrace-eval.
2550 * xterm.c (x_focus_changed): Simplify.
2551
9d611ffe
PE
25522013-07-25 Paul Eggert <eggert@cs.ucla.edu>
2553
2554 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
2555
999c74e3
EZ
25562013-07-24 Eli Zaretskii <eliz@gnu.org>
2557
2558 * xdisp.c (redisplay_window): Instead of moving point out of
2559 scroll margin, reject the force_start method, and try scrolling
2560 instead. (Bug#14780)
2561
198fa217
KB
25622013-07-24 Ken Brown <kbrown@cornell.edu>
2563
2564 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
2565 (Bug#14944).
2566
53840e55
PE
25672013-07-24 Paul Eggert <eggert@cs.ucla.edu>
2568
2569 * eval.c (Fprogn): Do not check that BODY is a proper list.
2570 This undoes the previous change. The check slows down the
2571 interpreter, and is not needed to prevent a crash. See
2572 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
2573
60967f56
GM
25742013-07-23 Glenn Morris <rgm@gnu.org>
2575
2576 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
2577
9ca960e2
PE
25782013-07-23 Paul Eggert <eggert@cs.ucla.edu>
2579
a29c3e6d
PE
2580 Port to GNU/Linux systems with tinfo but not ncurses.
2581 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
2582 to decide whether ncurses is being used. Without this change,
2583 GCC complains about tgetent not being declared, on a system
2584 that has tinfo installed but ncurses not installed.
2585
f274311c
PE
2586 * eval.c (Fprogn): Check that BODY is a proper list.
2587
16b0520a
PE
2588 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
2589 * data.c (Fsetq_default):
2590 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
2591 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
2592 (Fcondition_case):
2593 Tune by taking advantage of the fact that ARGS is always a list
2594 when a function is declared to have UNEVALLED args.
2595
9ca960e2
PE
2596 * emacsgtkfixed.c: Port to GCC 4.6.
2597 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
2598
afacaa1b
JB
25992013-07-23 Juanma Barranquero <lekktu@gmail.com>
2600
2601 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
2602 here to silence compiler warnings.
2603
368a85a4
PE
26042013-07-22 Paul Eggert <eggert@cs.ucla.edu>
2605
2606 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
2607 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
2608 from messing up Emacs's 'struct frame' (Bug#14923).
2609
f4e891b5
PE
26102013-07-21 Paul Eggert <eggert@cs.ucla.edu>
2611
2612 * alloc.c (make_save_ptr_ptr): Define this function.
2613 It was inadvertently omitted. It's needed only if
2614 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
2615
96c8b65e
JD
26162013-07-21 Jan Djärv <jan.h.d@swipnet.se>
2617
2618 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
2619 frame have focus (Bug#14895).
2620
ee010797
PE
26212013-07-21 Paul Eggert <eggert@cs.ucla.edu>
2622
2623 Avoid vfork-related deadlock more cleanly.
2624 * callproc.c (child_setup): When the child's exec fails, output
2625 the program name, as that's more useful. Use O_NONBLOCK to avoid
2626 deadlock.
2627 * process.c (create_process_1): Remove; no longer needed.
2628 (create_process): Remove timer hack; no longer needed, now that
2629 the child avoids deadlock.
2630
f0398ec1 26312013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
2632
2633 * image.c (Fimage_flush): Fix doc typo.
2634
b2a069c2
PE
26352013-07-20 Paul Eggert <eggert@cs.ucla.edu>
2636
6496aec9
PE
2637 Fix array bounds violation when pty allocation fails.
2638 * process.c (PTY_NAME_SIZE): New constant.
2639 (pty_name): Remove static variable; it's now auto.
2640 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
2641 Take pty_name as an arg rather than using a static variable.
2642 All callers changed.
2643 (create_process): Recover pty_flag from process, not from volatile local.
2644 (create_pty): Stay inside array even when pty allocation fails.
2645 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
2646
b2a069c2
PE
2647 * lread.c (Fload): Avoid initialization only when lint checking.
2648 Mention that it's needed only for older GCCs.
2649
99107004
KH
26502013-07-20 Kenichi Handa <handa@gnu.org>
2651
2652 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
2653 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
2654
6b1b199d
AS
26552013-07-20 Andreas Schwab <schwab@linux-m68k.org>
2656
2657 * lread.c (Fload): Avoid uninitialized warning.
2658
4195afc3
PE
26592013-07-19 Paul Eggert <eggert@cs.ucla.edu>
2660
3f5bef16
PE
2661 Fix some minor file descriptor leaks and related glitches.
2662 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
2663 (create_lock_file): Use write, not emacs_write.
2664 * image.c (slurp_file, png_load_body):
2665 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
2666 (server_accept_connection):
2667 Don't leak an fd on memory allocation failure.
2668 * image.c (slurp_file): Add a cheap heuristic for growing files.
2669 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
2670 as that's what the other routines do. Maybe input need not be
2671 blocked at all, but it's better to be consistent.
2672 Avoid undefined behavior when strlen is zero.
2673
4195afc3
PE
2674 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
2675 (NSTATICS): Now a constant; doesn't need to be a macro.
2676
a1aeeffe
RS
26772013-07-19 Richard Stallman <rms@gnu.org>
2678
2679 * coding.c (decode_coding_utf_8): Add simple loop for fast
2680 processing of ASCII characters.
2681
63b34baa
PE
26822013-07-19 Paul Eggert <eggert@cs.ucla.edu>
2683
2684 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
2685
621dd9ac
EZ
26862013-07-19 Eli Zaretskii <eliz@gnu.org>
2687
2688 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
2689 unportable 'struct x_display_info'.
2690 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
2691 is a portable type.
2692
1396ac86
PE
26932013-07-19 Paul Eggert <eggert@cs.ucla.edu>
2694
ab9980cd
PE
2695 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
2696 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
2697 or fscanf fails.
2698 (system_process_attributes): Prefer plain char to unsigned char
2699 when either will do. Clean up properly if interrupted or if
068f9124
SM
2700 memory allocations fail. Don't assume sscanf succeeds.
2701 Remove no-longer-needed workaround to stop GCC from whining.
2702 Read command-line once, instead of multiple times. Check read status a
ab9980cd
PE
2703 bit more carefully.
2704
1396ac86
PE
2705 Fix obscure porting bug with varargs functions.
2706 The code assumed that int is treated like ptrdiff_t in a vararg
2707 function, which is not a portable assumption. There was a similar
2708 -- though these days less likely -- porting problem with various
2709 assumptions that pointers of different types all smell the same as
2710 far as vararg functions is conserved. To make this problem less
2711 likely in the future, redo the API to use varargs functions.
2712 * alloc.c (make_save_value): Remove this vararg function.
2713 All uses changed to ...
2714 (make_save_int_int_int, make_save_obj_obj_obj_obj)
2715 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
2716 New functions.
2717 (make_save_ptr): Rename from make_save_pointer, for consistency with
2718 the above. Define only on platforms that need it. All uses changed.
2719
4d19d194
PE
27202013-07-18 Paul Eggert <eggert@cs.ucla.edu>
2721
2722 * keyboard.c: Try to fix typos in previous change.
2723 (DISPLAY_LIST_INFO): New macro.
2724 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 2725 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 2726
945c5bb1
JB
27272013-07-18 Juanma Barranquero <lekktu@gmail.com>
2728
2729 * keyboard.c (kbd_buffer_get_event):
2730 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
2731 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
2732
f4b1eb36
PE
27332013-07-18 Paul Eggert <eggert@cs.ucla.edu>
2734
5e679a2c
PE
2735 * filelock.c: Fix unlikely file descriptor leaks.
2736 (get_boot_time_1): Rework to avoid using emacs_open.
2737 This doesn't actually fix a leak, but is better anyway.
2738 (read_lock_data): Use read, not emacs_read.
2739
a8cd4836
PE
2740 * doc.c: Fix minor memory and file descriptor leaks.
2741 * doc.c (get_doc_string): Fix memory leak when doc file absent.
2742 (get_doc_string, Fsnarf_documentation):
2743 Fix file descriptor leak on error.
2744
ef30e638
PE
2745 * term.c: Fix minor fdopen-related file descriptor leaks.
2746 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
2747 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
2748
f4b1eb36
PE
2749 * charset.c: Fix file descriptor leaks and errno issues.
2750 Include <errno.h>.
2751 (load_charset_map_from_file): Don't leak file descriptor on error.
2752 Use plain record_xmalloc since the allocation is larger than
2753 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
2754 of entries.
2755 * eval.c (record_unwind_protect_nothing):
2756 * fileio.c (fclose_unwind):
2757 New functions.
2758 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
2759 The replacement doesn't block input, but that no longer seems
2760 necessary.
2761
b648c163
PE
27622013-07-17 Paul Eggert <eggert@cs.ucla.edu>
2763
a0931322
PE
2764 * lread.c: Fix file descriptor leaks and errno issues.
2765 (Fload): Close some races that leaked fds or streams when 'load'
2766 was interrupted.
2767 (Fload, openp): Report error number of last nontrivial failure to open.
2768 ENOENT counts as trivial.
2769 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
2770 New functions.
2771 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
2772 now that the function is always called with a nonnegative arg.
2773 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
2774 All uses replaced with ...
2775 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
2776
b648c163
PE
2777 A few more minor file errno-reporting bugs.
2778 * callproc.c (Fcall_process):
2779 * doc.c (Fsnarf_documentation):
2780 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
2781 * process.c (set_socket_option):
2782 Don't let a constructor trash errno.
2783 * doc.c: Include <errno.h>.
2784
b1dc4084
JB
27852013-07-16 Juanma Barranquero <lekktu@gmail.com>
2786
2787 * w32fns.c (unwind_create_tip_frame): Fix declaration.
2788
c43843aa
PE
27892013-07-16 Paul Eggert <eggert@cs.ucla.edu>
2790
50a30cce
PE
2791 Fix w32 bug with call-process-region (Bug#14885).
2792 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
2793 to Fcall_process when the input is empty. This simplifies the
2794 code a bit. It makes no difference on POSIXish platforms but
2795 apparently it fixes a bug on w32.
2796
44e18199 2797 Fix bug where insert-file-contents closes a file twice (Bug#14839).
41d48a42
PE
2798 * fileio.c (close_file_unwind): Don't close if FD is negative;
2799 this can happen when unwinding a zapped file descriptor.
2800 (Finsert_file_contents): Unwind-protect the fd before the point marker,
2801 in case Emacs runs out of memory between the two unwind-protects.
2802 Don't trash errno when closing FD.
2803 Zap the FD in the specpdl when closing it, instead of deferring
2804 the removal of the unwind-protect; this fixes a bug where a child
2805 function unwinds the stack past us.
2806
27e498e6
PE
2807 New unwind-protect flavors to better type-check C callbacks.
2808 This also lessens the need to write wrappers for callbacks,
2809 and the need for make_save_pointer.
2810 * alloca.c (free_save_value):
2811 * atimer.c (run_all_atimers):
2812 Now extern.
2813 * alloc.c (safe_alloca_unwind):
2814 * atimer.c (unwind_stop_other_atimers):
2815 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
2816 * menu.c (cleanup_popup_menu) [HAVE_NS]:
2817 * minibuf.c (choose_minibuf_frame_1):
2818 * process.c (make_serial_process_unwind):
2819 * xdisp.h (pop_message_unwind):
2820 * xselect.c (queue_selection_requests_unwind):
2821 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
2822 * alloca.c (record_xmalloc):
2823 Prefer record_unwind_protect_ptr to record_unwind_protect with
2824 make_save_pointer.
2825 * alloca.c (Fgarbage_collect):
2826 Prefer record_unwind_protect_void to passing a dummy.
2827 * buffer.c (restore_buffer):
2828 * window.c (restore_window_configuration):
2829 * xfns.c, w32fns.c (do_unwind_create_frame)
2830 New wrapper. All record-unwind uses of wrappee changed.
2831 * buffer.c (set_buffer_if_live):
2832 * callproc.c (call_process_cleanup, delete_temp_file):
2833 * coding.c (code_conversion_restore):
2834 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
2835 * editfns.c (save_excursion_restore)
2836 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
2837 (save_restriction_restore):
2838 * eval.c (restore_stack_limits, un_autoload):
2839 * fns.c (require_unwind):
2840 * keyboard.c (recursive_edit_unwind, tracking_off):
2841 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
2842 * macros.c (pop_kbd_macro, restore_menu_items):
2843 * nsfns.m (unwind_create_frame):
2844 * print.c (print_unwind):
2845 * process.c (start_process_unwind):
2846 * search.c (unwind_set_match_data):
2847 * window.c (select_window_norecord, select_frame_norecord):
2848 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
2849 (fast_set_selected_frame):
2850 * xfns.c, w32fns.c (unwind_create_tip_frame):
2851 Return void, not a dummy Lisp_Object. All uses changed.
2852 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
2853 * callproc.c (call_process_kill):
2854 * fileio.c (restore_point_unwind, decide_coding_unwind)
2855 (build_annotations_unwind):
2856 * insdel.c (Fcombine_after_change_execute_1):
2857 * keyboard.c (read_char_help_form_unwind):
2858 * menu.c (unuse_menu_items):
2859 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
2860 * sound.c (sound_cleanup):
2861 * xdisp.c (unwind_redisplay):
2862 * xfns.c (clean_up_dialog):
2863 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
2864 Accept no args and return void, instead of accepting and returning
2865 a dummy Lisp_Object. All uses changed.
2866 * cygw32.c (fchdir_unwind):
2867 * fileio.c (close_file_unwind):
2868 * keyboard.c (restore_kboard_configuration):
2869 * lread.c (readevalllop_1):
2870 * process.c (wait_reading_process_output_unwind):
2871 Accept int and return void, rather than accepting an Emacs integer
2872 and returning a dummy object. In some cases this fixes an
2873 unlikely bug when the corresponding int is outside Emacs integer
2874 range. All uses changed.
2875 * dired.c (directory_files_internal_unwind):
2876 * fileio.c (do_auto_save_unwind):
2877 * gtkutil.c (pop_down_dialog):
2878 * insdel.c (reset_var_on_error):
2879 * lread.c (load_unwind):
2880 * xfns.c (clean_up_file_dialog):
2881 * xmenu.c, nsmenu.m (pop_down_menu):
2882 * xmenu.c (cleanup_widget_value_tree):
2883 * xselect.c (wait_for_property_change_unwind):
2884 Accept pointer and return void, rather than accepting an Emacs
2885 save value encapsulating the pointer and returning a dummy object.
2886 All uses changed.
2887 * editfns.c (Fformat): Update the saved pointer directly via
2888 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
2889 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
2890 (unwind_body): New function.
2891 (record_unwind_protect): First arg is now a function returning void,
2892 not a dummy Lisp_Object.
2893 (record_unwind_protect_ptr, record_unwind_protect_int)
2894 (record_unwind_protect_void): New functions.
2895 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
2896 * fileio.c (struct auto_save_unwind): New type.
2897 (do_auto_save_unwind): Use it.
2898 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
2899 * insdel.c (struct rvoe_arg): New type.
2900 (reset_var_on_error): Use it.
2901 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
2902 New constants.
2903 (specbinding_func): Remove; there are now several such functions.
2904 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
2905 (set_unwind_protect_ptr): New function.
2906 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
2907
4e604a5d
PE
2908 Be simpler and more consistent about reporting I/O errors.
2909 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
2910 Say "Read error" and "Write error", rather than "I/O error", or
2911 "IO error reading", or "IO error writing", when a read or write
2912 error occurs.
2913 * process.c (Fmake_network_process, wait_reading_process_output)
2914 (send_process, Fprocess_send_eof, wait_reading_process_output):
2915 Capitalize diagnostics consistently. Put "failed foo" at the
2916 start of the diagnostic, so that we don't capitalize the
2917 function name "foo". Consistently say "failed" for such
2918 diagnostics.
2919 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
2920 All callers changed. This is so it can use report_file_error.
2921 * sysdep.c (serial_open, serial_configure): Capitalize I/O
2922 diagnostics consistently as above.
2923
a9757f6a
PE
2924 * fileio.c (report_file_errno): Fix errno reporting bug.
2925 If the file name is neither null nor a pair, package it up as a
2926 singleton list. All callers changed, both to this function and to
2927 report_file_error. This fixes a bug where the memory allocator
2928 invoked by list1 set errno so that the immediately following
2929 report_file_error reported the wrong errno value.
2930
c43843aa
PE
2931 Fix minor problems found by --enable-gcc-warnings.
2932 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
2933 * keyboard.c (kbd_buffer_get_event): Remove unused local.
2934
18c26d81
JD
29352013-07-16 Jan Djärv <jan.h.d@swipnet.se>
2936
2937 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
2938 Set event->arg to Qt if switch-event shall be generated.
2939 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
2940
2941 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
2942
2943 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
2944 FOCUS_OUT_EVENT.
2945
2946 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
2947 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
2948 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
2949 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
44e18199 2950 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
18c26d81
JD
2951 and there is a focused frame.
2952 (head_table): Add focus-in and focus-out.
2953 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
2954 bind to handle-focus-in/out.
2955
2956 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
2957 (Fhandle_switch_frame): Call Fhandle_focus_in.
2958 (syms_of_frame): defsubr handle-focus-in/out.
2959
6c6f1994
PE
29602013-07-16 Paul Eggert <eggert@cs.ucla.edu>
2961
c7ddc792
PE
2962 Fix porting bug to older POSIXish platforms (Bug#14862).
2963 * sysdep.c (emacs_pipe): New function, that implements
2964 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
2965 This should port better to CentOS 5 and to Mac OS X 10.6.
2966 All calls to pipe2 changed.
2967
6c6f1994
PE
2968 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
2969 This makes the code easier to read and the executable a bit smaller.
2970 Do not replace all calls to Fcons that happen to create lists,
2971 just calls that are intended to create lists. For example, when
2972 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
2973 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
2974 Similarly for list2 through list5.
2975 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2976 * bytecode.c (exec_byte_code):
2977 * callint.c (quotify_arg, Fcall_interactively):
2978 * callproc.c (Fcall_process, create_temp_file):
2979 * charset.c (load_charset_map_from_file)
2980 (Fdefine_charset_internal, init_charset):
2981 * coding.c (get_translation_table, detect_coding_system)
2982 (Fcheck_coding_systems_region)
2983 (Fset_terminal_coding_system_internal)
2984 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
2985 * composite.c (update_compositions, Ffind_composition_internal):
2986 * dired.c (directory_files_internal, file_name_completion)
2987 (Fsystem_users):
2988 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
2989 * doc.c (Fsnarf_documentation):
2990 * editfns.c (Fmessage_box):
2991 * emacs.c (main):
2992 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
2993 (Feval, eval_sub, Ffuncall, apply_lambda):
2994 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
2995 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
2996 (Fset_file_times, Finsert_file_contents)
2997 (Fchoose_write_coding_system, Fwrite_region):
2998 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
2999 * font.c (font_registry_charsets, font_parse_fcname)
3000 (font_prepare_cache, font_update_drivers, Flist_fonts):
3001 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
3002 * frame.c (make_frame, Fmake_terminal_frame)
3003 (x_set_frame_parameters, x_report_frame_params)
3004 (x_default_parameter, Fx_parse_geometry):
3005 * ftfont.c (syms_of_ftfont):
3006 * image.c (gif_load):
3007 * keyboard.c (command_loop_1):
3008 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
3009 (Fcopy_keymap, append_key, Fcurrent_active_maps)
3010 (Fminor_mode_key_binding, accessible_keymaps_1)
3011 (Faccessible_keymaps, Fwhere_is_internal):
3012 * lread.c (read_emacs_mule_char):
3013 * menu.c (find_and_return_menu_selection):
3014 * minibuf.c (get_minibuffer):
3015 * nsfns.m (Fns_perform_service):
3016 * nsfont.m (ns_script_to_charset):
3017 * nsmenu.m (ns_popup_dialog):
3018 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
3019 (Fx_own_selection_internal):
3020 * nsterm.m (append2):
3021 * print.c (Fredirect_debugging_output)
3022 (print_prune_string_charset):
3023 * process.c (Fdelete_process, Fprocess_contact)
3024 (Fformat_network_address, set_socket_option)
3025 (read_and_dispose_of_process_output, write_queue_push)
3026 (send_process, exec_sentinel):
3027 * sound.c (Fplay_sound_internal):
3028 * textprop.c (validate_plist, add_properties)
3029 (Fput_text_property, Fadd_face_text_property)
3030 (copy_text_properties, text_property_list, syms_of_textprop):
3031 * unexaix.c (report_error):
3032 * unexcoff.c (report_error):
3033 * unexsol.c (unexec):
3034 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
3035 (Fformat_mode_line, syms_of_xdisp):
3036 * xfaces.c (set_font_frame_param)
3037 (Finternal_lisp_face_attribute_values)
3038 (Finternal_merge_in_global_face, syms_of_xfaces):
3039 * xfns.c (x_default_scroll_bar_color_parameter)
3040 (x_default_font_parameter, x_create_tip_frame):
3041 * xfont.c (xfont_supported_scripts):
3042 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
3043 (menu_help_callback, xmenu_show):
3044 * xml.c (make_dom):
3045 * xterm.c (set_wm_state):
3046 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
3047 and similarly for list2 through list5.
3048
bafe80ce
PE
30492013-07-15 Paul Eggert <eggert@cs.ucla.edu>
3050
3051 * callproc.c (Fcall_process_region): Fix minor race and tune.
3052 (create_temp_file): New function, with the temp-file-creation part
3053 of the old Fcall_process_region. Use Fcopy_sequence to create the
3054 temp file name, rather than alloca + build_string, for simplicity.
3055 Don't bother to block input around the temp file creation;
068f9124
SM
3056 shouldn't be needed. Simplify use of mktemp.
3057 Use record_unwind_protect immediately after creating the temp file;
bafe80ce
PE
3058 this closes an unlikely race where the temp file was not removed.
3059 Use memcpy rather than an open-coded loop.
3060 (Fcall_process_region): Use the new function. If the input is
3061 empty, redirect from /dev/null rather than from a newly created
3062 empty temp file; this avoids unnecessary file system traffic.
3063
4700b5a5
PE
30642013-07-14 Paul Eggert <eggert@cs.ucla.edu>
3065
5c97beae
PE
3066 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
3067 Simplify by making this case like the other two. This is a bit
3068 slower on obsolete hosts, but the extra complexity isn't worth it.
3069
4700b5a5
PE
3070 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
3071 * process.c (create_process) [!DOS_NT]:
3072 Remove now-unnecessary calls to emacs_close.
3073
f9a74c4c
EZ
30742013-07-13 Eli Zaretskii <eliz@gnu.org>
3075
922ae7ee
EZ
3076 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
3077 returning early. (Bug#14850)
3078
f9a74c4c
EZ
3079 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
3080 and inhibit-iso-escape-detection attributes of 'undecided'.
3081 (Bug#14822)
3082
5e301d76
PE
30832013-07-13 Paul Eggert <eggert@cs.ucla.edu>
3084
69e0e5ee
PE
3085 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
3086 Reported by Herbert J. Skuhra in
3087 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
3088
5e301d76
PE
3089 Don't lose top specpdl entry when memory is exhausted.
3090 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
3091 specpdl overflow here, to simplify callers; all callers changed.
3092 Always reserve an unused entry at the stack top; this avoids
3093 losing the top entry's information when memory is exhausted.
3094
7e649856
PE
30952013-07-12 Paul Eggert <eggert@cs.ucla.edu>
3096
a773ed9a
PE
3097 Clean up errno reporting and fix some errno-reporting bugs.
3098 * callproc.c (Fcall_process):
3099 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
3100 * process.c (create_process, Fmake_network_process):
3101 * unexaix.c (report_error):
3102 * unexcoff.c (report_error):
3103 Be more careful about reporting the errno of failed operations.
3104 The code previously reported the wrong errno sometimes.
3105 Also, prefer report_file_errno to setting errno + report_file_error.
3106 (Fcall_process): Look at openp return value rather than at path,
3107 as that's a bit faster and clearer when there's a numeric predicate.
3108 * fileio.c (report_file_errno): New function, with most of the
3109 old contents of report_file_error.
3110 (report_file_error): Use it.
3111 (Ffile_exists_p, Ffile_accessible_directory_p):
3112 Set errno to 0 when it is junk.
3113 * fileio.c (Faccess_file):
3114 * image.c (x_create_bitmap_from_file):
3115 Use faccessat rather than opening the file, to avoid the hassle of
3116 having a file descriptor open.
3117 * lisp.h (report_file_errno): New decl.
3118 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
3119
7e649856
PE
3120 Minor EBADF fixes.
3121 * process.c (create_process, wait_reading_process_output) [AIX]:
3122 Remove obsolete SIGHUP-related code, as Emacs no longer disables
3123 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
3124 a multithreaded environment anyway).
3125 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
3126
f6774c1a
AS
31272013-07-12 Andreas Schwab <schwab@linux-m68k.org>
3128
3129 * image.c (x_find_image_file): Don't close a remote file handle.
3130
bacba3c2
PE
31312013-07-12 Paul Eggert <eggert@cs.ucla.edu>
3132
3133 Fix races with threads and file descriptors.
3134 * callproc.c (Fcall_process_region):
3135 * dired.c (open_directory):
3136 * emacs.c (main, Fdaemon_initialized):
3137 * image.c (x_find_image_file):
3138 * inotify.c (Finotify_rm_watch):
3139 * lread.c (Flocate_file_internal):
3140 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
3141 * term.c (term_mouse_moveto, init_tty):
3142 * termcap.c (tgetent):
3143 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
3144 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
3145 * unexhp9k800.c, unexmacosx.c (unexec):
3146 * callproc.c (Fcall_process_region):
3147 Use emacs_close, not close.
3148 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
3149 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
3150 and posix_close function on current platforms (which all lack them).
3151 (emacs_close): Use it. This should fix the races on GNU/Linux and
3152 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
3153 and it should avoid closing random victim file descriptors on
3154 other platforms.
3155
653d4f43
PE
31562013-07-11 Paul Eggert <eggert@cs.ucla.edu>
3157
c8536ec4
PE
3158 * inotify.c (uninitialized): Remove. All uses replaced by -1.
3159 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
3160 Touch up doc a bit.
3161
9c203066
PE
3162 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
3163 This is for .gdbinit xbacktrace.
3164
653d4f43
PE
3165 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
3166 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
3167 (emacs_set_tty): Now static.
3168 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
3169 * term.c (tty_capable_p, tty_default_color_capabilities)
3170 (get_tty_terminal, term_mouse_movement)
3171 (handle_one_term_event, init_tty, maybe_fatal):
3172 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
3173 (tgetent, scan_file, name_match, compare_contin):
3174 * terminal.c (get_terminal):
3175 Use bool for boolean.
3176 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
3177 Prefer char to unsigned char if either will do.
3178 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
3179 (tty_write_glyphs): Prefer int to unsigned.
3180 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
3181 All callers changed.
3182 * termcap.c (tprint, main) [TEST]: Remove non-working test.
3183
45b683a1
PE
31842013-07-10 Paul Eggert <eggert@cs.ucla.edu>
3185
29abe551
PE
3186 Port to C89.
3187 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
3188 (B__dummy__): New dummy symbol, to pacify C89.
3189 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
3190 they can't grok varargs macros.
3191 * dispnew.c (add_window_display_history)
3192 (add_frame_display_history):
3193 * print.c (print_object):
3194 * xdisp.c (debug_method_add):
3195 Use %p printf format only for void pointers.
3196 * emacs.c (usage_message): New constant, replacing ...
3197 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
3198 (main): Adjust to usage reorg.
3199 * fns.c (syms_of_fns):
3200 * profiler.c (syms_of_profiler):
3201 Don't use non-constant struct initializers.
3202 * gnutls.h (gnutls_initstage_t):
3203 * lisp.h (enum Lisp_Fwd_Type):
3204 * lread.c (lisp_file_lexically_bound_p):
3205 * xsettings.c (anonymous enum):
3206 Remove trailing comma.
3207 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
3208 * lisp.h (ENUM_BF): Use unsigned if pedantic.
3209 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
3210 (DEFUN): Use it.
3211 * regex.c (const_re_char): New type, to pacify strict C89.
3212 All uses of 'const re_char' replaced to use it.
3213 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
3214 with glibc when strict C89. This change is imported from gnulib.
3215 All uses changed.
3216 (_Restrict_arr_): Rename from __restrict_arr, similarly.
3217 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
3218 Omit GNU_LINUX implementation, since it requires long long.
3219 * xterm.c (x_draw_underwave):
3220 Do not assume the traditional order of struct's members.
3221 (x_term_init): Rewrite to avoid the need for non-constant structure
3222 initializers.
3223
45b683a1 3224 Syntax cleanup, mostly replacing macros with functions.
763a086d 3225 This removes the need for the syntax_temp hack.
45b683a1
PE
3226 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
3227 * syntax.c (SYNTAX_INLINE): New macro.
3228 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
3229 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
3230 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
3231 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
3232 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
3233 (SYNTAX_COMEND_FIRST): Now functions, not macros.
3234 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
3235 Now constants, not macros.
3236 (syntax_temp) [!__GNUC__]: Remove.
3237 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
3238 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
3239 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
3240 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
3241 Move here from syntax.h; now functions, not macros. Except for the
3242 last function, these are static since only syntax.c uses them.
3243 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
3244 All uses changed. Now a function, not a macro; use this fact
3245 to simplify the code.
3246 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
3247 compiler bugs; no longer relevant.
3248 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
3249 (SYNTAX_INLINE): New macro.
3250 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
3251 for the new functions. Use bool for boolean member.
3252 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
3253 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
3254 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
3255 (SETUP_BUFFER_SYNTAX_TABLE):
3256 Now extern inline functions, not macros.
3257 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
3258 Remove; all uses replaced by implementation.
3259 (syntax_temp) [!__GNUC__]: Remove decl.
3260 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
3261
29be4a50
JD
32622013-07-10 Jan Djärv <jan.h.d@swipnet.se>
3263
3264 * emacs.c (main): Fix syntax error.
3265
954b166e
PE
32662013-07-10 Paul Eggert <eggert@cs.ucla.edu>
3267
3268 Timestamp fixes for undo (Bug#14824).
3269 * atimer.c (schedule_atimer):
3270 * fileio.c (Ffile_newer_than_file_p):
3271 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
3272 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
3273 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
3274 (syms_of_fileio): Remove Sclear_visited_file_name.
3275 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
3276 file doesn't exist; this avoids an ambiguity with negative timestamps.
3277 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
3278 * systime.h (make_emacs_time, invalid_emacs_time):
3279 Don't assume struct timespec layout; POSIX doesn't guarantee it.
3280 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
3281 * undo.c (record_first_change): Push (visited-file-modtime) onto
3282 undo list rather than reimplementing it by hand, incorrectly.
3283
d74647c3
KB
32842013-07-09 Ken Brown <kbrown@cornell.edu>
3285
3286 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
3287
3c51b96b
JB
32882013-07-09 Juanma Barranquero <lekktu@gmail.com>
3289
3290 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
3291
4ebbdd67
PE
32922013-07-09 Paul Eggert <eggert@cs.ucla.edu>
3293
3294 Handle errno and exit status a bit more carefully.
3295 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
3296 number into an exit status. Instead, use EXIT_CANCELED.
3297 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
3298 * callproc.c (relocate_fd):
3299 * emacs.c (close_output_streams, main):
3300 * process.c (create_process):
3301 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
3302 Use emacs_perror for simplicity.
3303 * callproc.c (relocate_fd, main):
3304 * sysdep.c (sys_subshell):
3305 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
3306 (shut_down_emacs): Use emacs_write, not write.
3307 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
3308 * fileio.c (Fcopy_file, e_write):
3309 * nsterm.m (ns_select):
3310 * process.c (send_process):
3311 * sound.c (vox_write):
3312 Use emacs_write_sig, not emacs_write.
3313 * lisp.h (emacs_write_sig, emacs_perror): New decls.
3314 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
3315 New constants.
3316 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
3317 of write.
3318 (emacs_full_write): New function.
3319 (emacs_write): Rewrite to use it.
3320 (emacswrite_sig, emacs_perror): New functions.
3321 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
3322
44e18199 33232013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
e4b1e5af
JD
3324
3325 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
3326 on NS even if it is present. Pixmap on NS is a void*.
3327
9caab067
PE
33282013-07-07 Paul Eggert <eggert@cs.ucla.edu>
3329
3330 Port to Ubuntu 10 (Bug#14803).
3331 Problem reported by T.V. Raman.
3332 * process.c (close_on_exec, accept4, process_socket):
3333 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
3334
1d442672
EZ
33352013-07-07 Eli Zaretskii <eliz@gnu.org>
3336
3337 * w32.c (sys_dup): Declare prototype.
3338
3339 * filelock.c:
3340 * emacs.c:
3341 * callproc.c [WINDOWSNT]: Include sys/socket.h.
3342
067428c1
PE
33432013-07-07 Paul Eggert <eggert@cs.ucla.edu>
3344
3345 Make file descriptors close-on-exec when possible (Bug#14803).
3346 This simplifies Emacs a bit, since it no longer needs to worry
3347 about closing file descriptors by hand in some cases.
3348 It also fixes some unlikely races. Not all such races, as
3349 libraries often open files internally without setting
3350 close-on-exec, but it's an improvement.
3351 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
3352 * callproc.c (Fcall_process) [!MSDOS]:
3353 * emacs.c (main) [!DOS_NT]:
3354 * nsterm.m (ns_term_init):
3355 * process.c (create_process):
3356 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
3357 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
3358 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
3359 Prefer mkostemp with O_CLOEXEC to mkstemp.
3360 * callproc.c (relocate_fd) [!WINDOWSNT]:
3361 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
3362 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
3363 now using pipe2.
3364 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
3365 Make the resulting file descriptor close-on-exec.
3366 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
3367 * lread.c (load_descriptor_list, load_descriptor_unwind):
3368 Remove; no longer needed. All uses removed.
3369 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
3370 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
3371 New functions.
3372 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
3373 (Fmake_network_process, Fnetwork_interface_list):
3374 (Fnetwork_interface_info, server_accept_connection):
3375 Make newly-created socket close-on-exec.
3376 * sysdep.c (emacs_open, emacs_fopen):
3377 Make new-created descriptor close-on-exec.
3378 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
3379 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
3380
0da857dd
JD
33812013-07-07 Jan Djärv <jan.h.d@swipnet.se>
3382
3383 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
3384 for NS_IMPL_GNUSTEP.
3385
5f86adcd
PE
33862013-07-07 Paul Eggert <eggert@cs.ucla.edu>
3387
3388 Fix openp errno handling.
3389 * callproc.c (Fcall_process): Preserve openp errno around close.
3390 * lread.c (openp): Set errno when returning -1, as some callers
3391 expect this.
3392
1afb1d07
JD
33932013-07-06 Jan Djärv <jan.h.d@swipnet.se>
3394
3395 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
3396
3397 * nsterm.h (NSSavePanel): Update comment.
3398 (NSAPP_DATA2_RUNFILEDIALOG): Define.
3399 (ns_run_file_dialog): Declare.
3400
3401 * nsfns.m: Remove panelOK.
3402 (ns_fd_data): New.
3403 (ns_run_file_dialog): New function.
3404 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
3405 event loop, so file dialog is popped up by ns_run_file_dialog, called
3406 by sendEvent (Bug#14578).
3407 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
3408
3323c263
EZ
34092013-07-06 Eli Zaretskii <eliz@gnu.org>
3410
fdda0220
EZ
3411 * xdisp.c (default_line_pixel_height): New function.
3412 (pos_visible_p, move_it_vertically_backward, try_scrolling)
3413 (try_cursor_movement, redisplay_window, try_window)
3414 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
3415
068f9124
SM
3416 * window.c (window_scroll_pixel_based):
3417 use default_line_pixel_height.
fdda0220
EZ
3418
3419 * dispextern.h (default_line_pixel_height): Add prototype.
3420
3421 * frame.c (x_set_line_spacing): Accept a float value for
3422 line-spacing parameter, per the documentation.
3423
3323c263
EZ
3424 * data.c (Fmultibyte_string_p): Doc fix.
3425
47ba6d43
PE
34262013-07-05 Paul Eggert <eggert@cs.ucla.edu>
3427
406af475
PE
3428 Use emacs_open more consistently when opening files.
3429 This handles EINTR more consistently now, and makes it easier
3430 to introduce other uniform changes to file descriptor handling.
3431 * src/systdio.h: New file.
3432 * src/buffer.c (mmap_init):
3433 * cygw32.c (chdir_to_default_directory):
3434 * dispnew.c (Fopen_termscript):
3435 * emacs.c (Fdaemon_initialized):
3436 * fileio.c (Fdo_auto_save):
3437 * image.c (slurp_file, png_load_body, jpeg_load_body):
3438 * keyboard.c (Fopen_dribble_file):
3439 * lread.c (Fload):
3440 * print.c (Fredirect_debugging_output):
3441 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
3442 * termcap.c (tgetent):
3443 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
3444 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
3445 * w32term.c (w32_initialize) [CYGWIN]:
3446 * xfaces.c (Fx_load_color_file):
3447 Use emacs_open instead of plain open, and emacs_fopen instead of
3448 plain fopen.
3449 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
3450 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
3451 * callproc.c (default_output_mode): New constant.
3452 (Fcall_process): Use it to call emacs_open instead of plain creat.
3453 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
3454 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
3455 (emacs_fopen): New function.
3456 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
3457 Include <lisp.h>, for emacs_open.
3458 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
3459
47ba6d43
PE
3460 Remove duplicate #include directives.
3461 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
3462 * xfaces.c:
3463 Don't include stdio.h twice.
3464 * buffer.c [USE_MMAP_FOR_BUFFERS]:
3465 Don't include sys/types.h or stdio.h twice.
3466 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
3467 * lread.c: Don't include coding.h twice.
3468 * nsfont.m: Don't include frame.h twice.
3469 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
3470 * ralloc.c: Don't include <unistd.h> twice.
3471 * xdisp.c: Don't include font.h twice.
3472 * xterm.c: Don't include fontset.h twice.
3473 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
3474
b9ed53d5
PE
34752013-07-04 Paul Eggert <eggert@cs.ucla.edu>
3476
3477 Scale ImageMagick images more carefully.
3478 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
3479 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
3480 Be more careful about avoiding undefined behavior after
3481 integer overflow and division by zero.
3482
cf13177e
YM
34832013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3484
3485 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
3486 (syms_of_w32fns): DEFSYM them.
3487 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
3488 (CCHDEVICENAME): Define macros if not defined.
3489 (struct MONITOR_INFO_EX): New struct.
3490 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
3491 (enum_display_monitors_fn): New variable.
3492 (globals_of_w32fns): Initialize it.
3493 (Fx_display_pixel_width, Fx_display_pixel_height)
3494 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
3495 multi-monitor setups in docstrings.
3496 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
3497 screen size by primary monitor's millimeter per pixel.
3498 (w32_monitor_enum, w32_display_monitor_attributes_list)
3499 (w32_display_monitor_attributes_list_fallback)
3500 (Fw32_display_monitor_attributes_list): New functions.
3501 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
3502
3503 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
3504 if not defined.
3505 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
3506
86dfb7a8
MA
35072013-07-04 Michael Albinus <michael.albinus@gmx.de>
3508
3509 * fileio.c (Qfile_notify_error): New error symbol.
3510
3511 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
3512 * inotify.c (inotify_callback, symbol_to_inotifymask)
3513 (Finotify_add_watch, Finotify_rm_watch): Use it.
3514 (inotifyevent_to_event): Exchange order of cookie and file name.
3515 (Finotify_add_watch): Adapt docstring.
3516
3517 * lisp.h (Qfile_notify_error): Declare.
3518
2c1c974b
PE
35192013-07-04 Paul Eggert <eggert@cs.ucla.edu>
3520
3521 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
3522 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
3523 Do not clear _malloc_thread_enabled_p, undoing the previous change,
3524 which did not work (see <http://bugs.gnu.org/14569#307>).
3525 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
3526 && (!noninteractive || initialized)). This attempts to thread
3527 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
3528
7a35b20f
JB
35292013-07-04 Juanma Barranquero <lekktu@gmail.com>
3530
3531 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
3532 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
3533
1ce5cd04
PE
35342013-07-04 Paul Eggert <eggert@cs.ucla.edu>
3535
3536 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
3537 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
3538 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
3539 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
3540
57f8c490
PE
35412013-07-02 Paul Eggert <eggert@cs.ucla.edu>
3542
3543 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
3544 Define to __sys_siglist.
3545
bcffb5ca
EZ
35462013-07-02 Eli Zaretskii <eliz@gnu.org>
3547
3548 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
3549 word-wrap, so that overflow-newline-into-fringe would work in
3550 visual-line-mode. (Bug#2749)
3551 (move_it_in_display_line_to): When the last scanned display
3552 element fits exactly on the display line, and
3553 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
3554 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
3555 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
3556 finding buffer position that corresponds to pixel coordinates,
3557 e.g. in buffer_posn_from_coords.
3558
2c41e781
JD
35592013-07-02 Jan Djärv <jan.h.d@swipnet.se>
3560
3561 * process.c (handle_child_signal): Call catch_child_signal if
3562 NS_IMPL_GNUSTEP.
3563
c2418359
PE
35642013-07-02 Paul Eggert <eggert@cs.ucla.edu>
3565
52a9bcae
PE
3566 Don't convert function pointers to void * and back.
3567 It isn't portable C, and it's easy enough to avoid.
3568 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
3569 (make_save_value): Add support for SAVE_FUNCPOINTER.
3570 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
3571 * print.c (print_object):
3572 Distinguish function from object pointers.
3573 * lisp.h (SAVE_FUNCPOINTER): New constant.
3574 (SAVE_SLOT_BITS): Adjust to it.
3575 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
3576 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
3577 (voidfuncptr): New typedef.
3578 (struct Lisp_Save_Value): New member data[0].funcpointer.
3579 (XSAVE_FUNCPOINTER): New function.
3580
c2418359
PE
3581 Simplify buildobj processing.
3582 * Makefile.in (buildobj.h): Make it a sequence of strings each
3583 followed by comma, rather than a single string. Put it into a
3584 .tmp file in case there's an error while generating it.
3585 (gl-stamp): Use .tmp for temp files.
3586 (mostlyclean): Clean .tmp files.
3587 * doc.c (buildobj): Move to just the routine that needs it.
3588 It's now an array of strings, so processing is simpler.
3589
8f43ce49
PE
35902013-07-01 Paul Eggert <eggert@cs.ucla.edu>
3591
3592 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
3593 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
3594 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
3595 Invoke malloc_enable_thread even when not interactive.
3596 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
3597 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
3598 in this case, since the underlying bug has now been fixed.
3599
24827db9
JB
36002013-07-01 Juanma Barranquero <lekktu@gmail.com>
3601
3602 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
3603 unlinking it (bug#14691).
3604
ef099a94
MN
36052013-06-30 Michal Nazarewicz <mina86@mina86.com>
3606
3607 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
3608 before checking whether buffer is modified. This lets
3609 `kill-buffer-query-functions' cancel killing of the buffer or save
3610 its content before `kill-buffer' asks user the "Buffer %s
3611 modified; kill anyway?" question.
3612
9d3f2fc2
JD
36132013-06-30 Jan Djärv <jan.h.d@swipnet.se>
3614
3615 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
3616 Let the super performKeyEquivalent deal with them (Bug#14747).
3617
e6c6c8c7
PE
36182013-06-30 Paul Eggert <eggert@cs.ucla.edu>
3619
1d71c1d9
PE
3620 * widget.c (resize_cb): Remove unused local.
3621
8f5f35cc
PE
3622 Do not use GTK 3 if it exists but cannot be compiled.
3623 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
3624 * xterm.c (x_error_handler) [!USE_GTK]:
3625 Do not use GTK 3.
3626
e6c6c8c7
PE
3627 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
3628
0ba54312
EZ
36292013-06-30 Eli Zaretskii <eliz@gnu.org>
3630
5d1c3286
EZ
3631 * intervals.c (get_local_map): Instead of aborting, clip POSITION
3632 to the valid range of values. (Bug#14753)
3633
0ba54312
EZ
3634 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
3635 when moving point by using the current glyph matrix. This avoids
3636 the need to force redisplay when this function is called in a
3637 loop.
3638
9c90cc06
PE
36392013-06-29 Paul Eggert <eggert@cs.ucla.edu>
3640
3641 Fix minor problems found by static checking.
3642 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
3643 Redo the latter's body to sidestep GCC parenthesization warnings.
3644 (setup_coding_system, detect_coding, detect_coding_system): Use them.
3645 * coding.c (detect_coding, detect_coding_system):
3646 * coding.h (struct undecided_spec):
3647 Use bool for boolean.
3648 * image.c (QCmax_width, QCmax_height): Now static.
3649 * xdisp.c (Fmove_point_visually): Remove unused local.
3650
4c672a0f
EZ
36512013-06-29 Eli Zaretskii <eliz@gnu.org>
3652
3653 * xdisp.c (Fmove_point_visually): New function.
3654
c1ea3abf
JB
36552013-06-28 Kenichi Handa <handa@gnu.org>
3656
3657 * coding.h (define_coding_undecided_arg_index): New enum.
3658 (coding_attr_index): New members
3659 coding_attr_undecided_inhibit_null_byte_detection,
3660 coding_attr_undecided_inhibit_iso_escape_detection,
3661 coding_attr_undecided_prefer_utf_8.
3662 (undecided_spec): New struct.
3663 (struct coding_system): New member `undecided' of the member
3664 `spec'.
3665
3666 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
3667 (detect_coding): Likewise.
3668 (detect_coding_system): Likewise.
3669 (Fdefine_coding_system_internal): New coding system properties
3670 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
3671 :prefer-utf-8.
3672 (syms_of_coding): Adjust for coding_arg_undecided_max.
3673
ba3de9e6
PE
36742013-06-28 Paul Eggert <eggert@cs.ucla.edu>
3675
3676 * image.c (x_from_xcolors): Remove unused local.
3677
547c9269
YM
36782013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3679
3680 Defer image data transfer between X client and server until actual
3681 display happens.
3682
3683 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
3684 and `mask_img'.
3685
3686 * image.c (Destroy_Image): Remove.
3687 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
3688 `mask_p', and `colors_p'. All uses changed.
3689 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
3690 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
3691 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
3692 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
3693 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 3694 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
3695 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
3696 (image_get_x_image, image_unget_x_image): New functions or macros.
3697 (image_background, image_background_transparent, x_to_xcolors)
3698 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
3699 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
3700 instead of Destroy_Image.
3701 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
3702 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
3703 (png_load_body, jpeg_load_body, tiff_load, gif_load)
3704 (imagemagick_load_image, svg_load_image): Use them instead of
3705 x_create_x_image_and_pixmap, and x_put_x_image followed by
3706 x_destroy_x_image, respectively.
3707 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
3708 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
3709 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
3710 background_transparent fields.
3711 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
3712 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
3713
dae2f5ef
PE
37142013-06-27 Paul Eggert <eggert@cs.ucla.edu>
3715
3716 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
3717 This mostly consists of undoing recent changes.
3718 * callproc.c (Fcall_process):
3719 * process.c (create_process):
3720 Do not worry about catching SIGCHLD here, undoing previous change.
3721 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
3722 * process.c, process.h (catch_child_signal):
3723 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
3724 * process.c (catch_child_handler): Don't worry about being called
3725 lazily and do not assume caller has blocked SIGCHLD, undoing
3726 previous change. Move first-time stuff back to
3727 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
3728 tickle glib, as that causes Cygwin bootstrap to fail. Do not
3729 set lib_child_handler if it's already initialized, which may
3730 help avoid problems on GNUStep.
3731
fa55d2aa
PE
37322013-06-23 Paul Eggert <eggert@cs.ucla.edu>
3733
3734 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
3735 * callproc.c (Fcall_process):
3736 * process.c (create_process):
3737 Make sure SIGCHLD is caught before we fork,
3738 since Emacs startup no arranges to catch SIGCHLD.
3739 * process.c (lib_child_handler): Initialize to null, not to
3740 dummy_handler.
3741 (catch_child_signal): Allow self to be called lazily.
3742 Do nothing if it's already been called.
3743 Assume caller has blocked SIGCHLD (all callers do now).
3744 * emacs.c (main): Do not catch SIGCHLD here; defer it until
3745 just before it's really needed.
3746 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
3747 since it hasn't been caught yet.
3748
f3f9606c
LMI
37492013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
3750
3751 * image.c (compute_image_size): New function to implement
3752 :max-width and :max-height.
3753 (imagemagick_load_image): Use it.
3754
c7041908
PE
37552013-06-23 Paul Eggert <eggert@cs.ucla.edu>
3756
3757 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
3758 * callproc.c, process.h (block_child_signal, unblock_child_signal):
3759 Now extern.
3760 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
3761 * process.c (catch_child_signal): Block SIGCHLD while futzing with
3762 the SIGCHLD handler, since the code is not atomic and (due to glib)
3763 signals may be arriving now.
3764 * sysdep.c (init_signals): Do not catch child signals here;
3765 'main' now does that later, at a safer time.
3766
f86852b4
PE
37672013-06-22 Paul Eggert <eggert@cs.ucla.edu>
3768
0dfeed58
PE
3769 Clean up SIGCHLD handling a bit (Bug#14569).
3770 * process.c, process.h (catch_child_signal):
3771 Now always extern, even if !NS_IMPL_GNUSTEP.
3772 * process.c (catch_child_signal): Move glib tickler here from
3773 init_process_emacs, so that it's done earlier in Emacs
3774 initialization. Also move the noninteractive && !initialized
3775 check here from init_process_emacs. This is all a bit cleaner for
3776 GNUish platforms, and I hope it works around the Cygwin bug.
3777 * sysdep.c (init_signals): Invoke catch_child_signal here, so
3778 that glib signal handling is tickled before glib creates threads.
3779
f86852b4
PE
3780 * process.c (wait_reading_process_output): Avoid int overflow
3781 when reading more than 2 GiB total from a process.
3782
cbd6509c
PE
37832013-06-21 Paul Eggert <eggert@cs.ucla.edu>
3784
3785 * process.c (create_process): Handle a couple more cases,
3786 i.e., work even if new_argv and wait_child_setup[i] are cached.
3787 Use Fcall_process's style for volatile vars.
3788
9de1114a
AS
37892013-06-21 Andreas Schwab <schwab@linux-m68k.org>
3790
3791 * process.c (create_process): Mark PROCESS volatile.
3792
fbe9e0b9
PE
37932013-06-21 Paul Eggert <eggert@cs.ucla.edu>
3794
3795 Use C99-style flexible array members if available.
3796 This avoids some subtle aliasing issues, which typically
3797 aren't a problem with GCC but may be a problem elsewhere.
3798 * alloc.c (sdata): New typedef, replacing the old struct sdata.
3799 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
3800 In either case, it uses a flexible array member rather than
3801 the old struct hack. All uses changed.
3802 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
3803 Adjust to sdata reorganization.
3804 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
3805 Use offsetof (struct, flex_array_member), not sizeof (struct), as
3806 that ports better to pre-C99 non-GCC.
3807 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
3808 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
3809 as the latter has changed.
3810 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
3811 and port better to pre-C99 GCC.
3812 * image.c (struct xpm_cached_color):
3813 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
3814 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
3815 Use FLEXIBLE_ARRAY_MEMBER.
3816 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
3817 Move decl to top level so it gets checked against implementation.
3818 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
3819 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
3820
1fc71008
PE
38212013-06-20 Paul Eggert <eggert@cs.ucla.edu>
3822
3823 * syntax.c: Integer cleanups.
3824 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
3825 All uses that need 0-or-2 changed to:
3826 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
3827 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
3828 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
3829 (char_quoted, prev_char_comend_first, back_comment)
3830 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
3831 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
3832 Use bool for boolean.
3833 (update_syntax_table, skip_chars, skip_syntaxes):
3834 Prefer int to unsigned when either will do.
3835 (back_comment): Return boolean success flag, like forw_comment,
3836 instead of positive-or-minus-1 (which might have overflowed int anyway).
3837 Don't stuff ptrdiff_t into int.
3838 (syntax_spec_code, syntax_code_spec): Now const.
3839 (Fmatching_paren, scan_lists, scan_sexps_forward):
3840 Use enum syntaxcode for syntax code.
3841 (Fmatching_paren): Check that arg is a character, not just an integer.
3842 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
3843 (Finternal_describe_syntax_value): Omit no-longer-needed
3844 comparison to 0.
3845 (skip_chars): Use char, not unsigned char, when the distinction
3846 doesn't matter.
3847 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
3848 * bytecode.c (exec_byte_code):
3849 * syntax.c (syntax_spec_code, Fchar_syntax)
3850 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
3851 (init_syntax_once):
3852 * syntax.h (SYNTAX_WITH_FLAGS):
3853 Omit unnecessary casts.
3854
b932cad7
EZ
38552013-06-20 Eli Zaretskii <eliz@gnu.org>
3856
3857 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
3858 line dimensions here, to avoid race conditions with the main
3859 thread. (Bug#14062, bug#14630, bug#14669)
3860
3861 * w32term.c (w32_draw_window_cursor): Compute the header line and
3862 mode line dimensions here.
3863 <w32_system_caret_window, w32_system_caret_hdr_height>:
3864 <w32_system_caret_mode_height>: New variables.
3865
3866 * w32term.h: Declare them.
3867
89561f72
PE
38682013-06-20 Paul Eggert <eggert@cs.ucla.edu>
3869
5013fc08
PE
3870 * alloc.c (die): Move "assertion failed" string here ...
3871 * lisp.h (eassert): ... from here. Also, suppress evaluation of
3872 COND when SUPPRESS_CHECKING. This shrinks the executable text
3873 size by 0.8% to 2.2% when configured with --enable-checking,
3874 depending on optimization flags (GCC 4.8.1 x86-64).
3875
89561f72
PE
3876 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
3877
763a086d 38782013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
3879
3880 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
3881 base is 2; this is more accurate.
3882
983aeb9a
JB
38832013-06-19 Juanma Barranquero <lekktu@gmail.com>
3884
3885 * sound.c (string_default): Move to !WINDOWSNT section.
3886 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
3887
178ba3e6
PE
38882013-06-19 Paul Eggert <eggert@cs.ucla.edu>
3889
bbc51b15
PE
3890 * sound.c: Integer cleanups.
3891 Remove unnecessary forward decls.
3892 (struct sound_device): The 'file' member is now a Lisp_Object, not
3893 a char *, so that we needn't invoke alloca on a huge size.
3894 (Fplay_sound_internal): Adjust to this.
3895 (string_default): New function.
3896 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
3897 Use it to adjust to the struct sound_device change.
3898 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
3899 (be2hs) [0]: Remove.
3900
178ba3e6
PE
3901 * syntax.c (skip_chars): Don't use uninitialized storage
3902 when searching a multibyte buffer for characters that are not in a
3903 unibyte string that contains non-ASCII characters.
3904
69f60cdc
JD
39052013-06-18 Jan Djärv <jan.h.d@swipnet.se>
3906
3907 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
3908 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
3909
0d6224d4
PE
39102013-06-18 Paul Eggert <eggert@cs.ucla.edu>
3911
3912 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
3913
3c542890
KH
39142013-06-18 Kenichi Handa <handa@gnu.org>
3915
f7e3f7cd
KH
3916 * font.c (Ffont_spec): Signal an error for an invalid font name
3917 (Bug#14648).
3c542890 3918
9349e5f7
PE
39192013-06-18 Paul Eggert <eggert@cs.ucla.edu>
3920
3921 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
3922 In particular this ports to 32-bit sparc Sun cc.
3923 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
3924 array with a dummy element at specpdl[-1], so that its address can
3925 be taken portably.
3926 (unbind_to): Do not copy the binding; not needed, now that we
3927 copy old_value in the one place where the copy is needed.
3928 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
3929 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
3930 (union specbinding): Rename from struct specbinding. Redo layout
3931 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
3932 which is not portable. With Sun C 5.12 32-bit sparc, the
3933 declaration causes nargs to be an unsigned bitfield, a behavior
3934 that the C standard allows; but Emacs wants nargs to be signed.
3935 The overall type is now a union of structures rather than a
3936 structure of union of structures, and the 'kind' member is now a
3937 bitfield, so that the overall type doesn't grow. All uses changed.
3938 * process.c (Fmake_serial_process): Remove unnecessary initialization.
3939
0a4df6a5
PE
39402013-06-17 Paul Eggert <eggert@cs.ucla.edu>
3941
ec6ecaad
PE
3942 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
3943 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
3944
0a4df6a5
PE
3945 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
3946
7bfe8dbc
EZ
39472013-06-17 Eli Zaretskii <eliz@gnu.org>
3948
3949 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
3950 unless we know that the window w's frame is a frame object.
3951 Another attempt at solving bug#14062 and bug#14630.
3952
708e05f6
LMI
39532013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
3954
3955 * textprop.c (property_set_type): New enum.
3956 (add_properties): Allow appending/prepending text properties.
3957 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 3958 (Fadd_text_properties): Move all the code into
708e05f6
LMI
3959 add_text_properties_1.
3960 (Fadd_face_text_property): New function that calls
3961 add_text_properties_1.
3962
84575e67
PE
39632013-06-17 Paul Eggert <eggert@cs.ucla.edu>
3964
3965 Move functions from lisp.h to individual modules when possible.
3966 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
3967 * alloc.c (XFLOAT_INIT, set_symbol_name):
3968 * buffer.c (CHECK_OVERLAY):
3969 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
3970 (set_char_table_parent):
3971 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
3972 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
3973 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
3974 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
3975 (set_blv_valcell):
3976 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
3977 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
3978 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
3979 (backtrace_args, backtrace_debug_on_exit):
3980 * floatfns.c (CHECK_FLOAT):
3981 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
3982 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
3983 (set_hash_hash, set_hash_hash_slot, set_hash_index)
3984 (set_hash_index_slot):
3985 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
3986 * marker.c (CHECK_MARKER):
3987 * textprop.c (CHECK_STRING_OR_BUFFER):
3988 * window.c (CHECK_WINDOW_CONFIGURATION):
3989 Move here from lisp.h, and make these functions static rather than
3990 extern inline.
3991 * buffer.c (Qoverlayp):
3992 * data.c (Qsubrp):
3993 * fns.c (Qhash_table_p):
3994 * window.c (Qwindow_configuration_p):
3995 Now static.
3996 * lisp.h: Remove the abovementioned defns and decls.
3997
44e18199 3998 Use functions, not macros, for XINT etc (Bug#11935).
84575e67
PE
3999 In lisp.h, prefer functions to function-like macros, and
4000 constants to object-like macros, when either will do. This:
4001 . simplifies use, as there's no more need to worry about
4002 arguments' side effects being evaluated multiple times.
4003 . makes the code easier to debug on some platforms.
4004 However, when using gcc -O0, keep using function-like macros
4005 for a few critical operations, for performance reasons.
4006 This sort of thing isn't needed with gcc -Og, but -Og
4007 is a GCC 4.8 feature and isn't widely-enough available yet.
4008 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
4009 Remove enum lsb_bits; no longer needed.
4010 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
4011 * buffer.c (Qoverlap):
4012 * data.c (Qsubrp):
4013 * fns.c (Qhash_table_p):
4014 Now extern, so lisp.h can use these symbols.
4015 * dispextern.h: Include character.h, for MAX_CHAR etc.
4016 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
4017 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
4018 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
4019 (GLYPH_CODE_P): Move here from lisp.h.
4020 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
4021 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
4022 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
4023 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
4024 XUNTAG now returns void *.
4025 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
4026 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
4027 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
4028 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
4029 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
4030 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
4031 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
4032 (lisp_h_XPNTR, lisp_h_XSYMBOL):
4033 New macros, renamed from their sans-lisp_h_ counterparts.
4034 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
4035 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
4036 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
4037 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
4038 If compiling via GCC without optimization, define these as macros
4039 in addition to inline functions.
4040 To disable this, compile with -DINLINING=0.
4041 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
4042 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
4043 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
4044 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
4045 (INTMASK, VALMASK): Now macros, since static values cannot be
4046 accessed from extern inline functions.
4047 (VALMASK): Also a constant, for benefit of old GDB.
4048 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
4049 is INTEGERP, which can fold it in.
5165d44a 4050 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
4051 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
4052 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
4053 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
4054 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
4055 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
4056 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
4057 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
4058 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
4059 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
4060 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
4061 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
4062 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
4063 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
4064 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
4065 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
4066 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
4067 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
4068 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
4069 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
4070 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
4071 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
4072 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
4073 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
4074 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
4075 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
4076 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
4077 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
4078 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
4079 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
4080 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
4081 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
4082 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
4083 Now functions.
4084 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
4085 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
4086 (VALMASK): Define in one place rather than in two, merging the
4087 USE_LSB_TAG parts; this is simpler.
4088 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
4089 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
4090 Move up, to avoid use before definition.
4091 Also include "globals.h" earlier, for the same reason.
4092 (make_natnum): New function.
4093 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
4094 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
4095 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
4096 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
4097 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
4098 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
4099 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
4100 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
4101 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
4102 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
4103 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
4104 (Qwindow_configuration_p, Qimage): New forward declarations.
4105 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
4106 (STRING_COPYIN): Remove; unused.
4107 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
4108 (xcar_addr, xcdr_addr): New functions. All uses changed.
4109 (IEEE_FLOATING_POINT): Now a constant, not a macro.
4110 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
4111 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
4112 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
4113 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
4114 (TYPE_RANGED_INTEGERP): Simplify.
4115 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
4116 (setlocale, fixup_locale, synchronize_system_messages_locale)
4117 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
4118 Now empty functions, not macros.
4119 (functionp): Return bool, not int.
4120 * window.c (Qwindow_configuration_p): Now extern,
4121 so window.h can use it.
4122 * window.h (Qwindowp): Move decl back to lisp.h.
4123
9583ec36
EZ
41242013-06-15 Eli Zaretskii <eliz@gnu.org>
4125
4126 * xdisp.c (Fline_pixel_height): New function, required for solving
4127 bug #14567.
4128
210272ce
PE
41292013-06-15 Paul Eggert <eggert@cs.ucla.edu>
4130
4131 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
4132
de0503df
SM
41332013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
4134
4135 * lread.c (syms_of_lread):
4136 * fns.c (Fprovide): Adjust to new format of after-load-alist.
4137
afbfe143
KD
41382013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
4139
4140 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
4141
d177e213
XF
41422013-06-12 Xue Fuqiao <xfq.free@gmail.com>
4143
4144 * fileio.c (expand_file_name): Doc fix.
4145
05e3e412
PE
41462013-06-11 Paul Eggert <eggert@cs.ucla.edu>
4147
f7394b12
PE
4148 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
4149 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
4150 Wait for self, not for 0. This can't hurt on GNU or similar
4151 system, and may help with Cygwin.
4152
05e3e412
PE
4153 * keyboard.c: Don't use PROP (...) as an lvalue.
4154 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
4155 Use set_prop (A, B), not PROP (A) = B.
4156
17dd3097
EZ
41572013-06-10 Eli Zaretskii <eliz@gnu.org>
4158
4159 * xdisp.c (get_it_property): Use it->window instead of generating
4160 a Lisp object from it->w.
4161
52fab9c9
EZ
41622013-06-09 Eli Zaretskii <eliz@gnu.org>
4163
4164 * xdisp.c (get_it_property): If it->object is a buffer, pass to
4165 get-char-property the window that is being rendered, instead of
4166 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
4167 (compute_display_string_pos): When W is NULL, use the current
4168 buffer as the object to pass to get-char-property.
4169 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
4170 pointer member of the bidi iterator, since no window is pertinent
4171 to this function.
52fab9c9 4172
5bf97bfc
EZ
41732013-06-08 Eli Zaretskii <eliz@gnu.org>
4174
4175 * bidi.c (bidi_fetch_char): Accept additional argument, the window
4176 being displayed, and pass it to compute_display_string_pos.
4177 (bidi_level_of_next_char, bidi_resolve_explicit_1)
4178 (bidi_paragraph_init): All callers changed.
4179
4180 * xdisp.c (init_from_display_pos, init_iterator)
4181 (handle_single_display_spec, next_overlay_string)
4182 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
4183 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
4184 Set bidi_it.w member from it->w.
5bf97bfc
EZ
4185 (compute_display_string_pos): Accept additional argument, the
4186 window being displayed, and pass it to Fget_char_property.
4187 (Bug#14575)
4188
4189 * dispextern.h (struct bidi_it): New member w, the window being
4190 displayed.
4191 (compute_display_string_pos): Adjust prototype.
4192
5de0e011
JD
41932013-06-08 Jan Djärv <jan.h.d@swipnet.se>
4194
e7b41c4c 4195 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
4196
4197 * process.c (wait_reading_process_output): Check for NS before GLIB.
4198 GLIB may be linked in due to rsvg, but ns_select must be called.
4199
5de0e011
JD
4200 * xgselect.c (xg_select): Remove call to window_system_available
4201 and g_main_context_pending at the top, so Gdk events (i.e. file
4202 notify) are processed when Emacs is started with -nw.
4203
a822acff
EZ
42042013-06-07 Eli Zaretskii <eliz@gnu.org>
4205
4206 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
4207 (ctagsfiles3): New variable, includes only *.m files.
4208 (TAGS): Use an explicit language name in the regular expressions,
4209 to avoid transformation of '/SOMETHING' by MSYS to
4210 'c:\MSYS\SOMETHING'.
4211
6c0a9ed1
RC
42122013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
4213
4214 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
4215
9ef6111b
EZ
42162013-06-06 Eli Zaretskii <eliz@gnu.org>
4217
4218 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
4219 still need to set the mouse pointer shape and activate help-echo.
4220 (Bug#14558)
4221
7d300d64
PE
42222013-06-06 Paul Eggert <eggert@cs.ucla.edu>
4223
4224 A few porting etc. fixes for the new file monitor code.
4225 See the thread containing
4226 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
4227 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
4228 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
4229 (dir_monitor_callback, Fgfile_rm_watch):
4230 Use assq_no_quit instead of Fassoc, for speed.
4231 (dir_monitor_callback, Fgfile_rm_watch):
4232 eassert that the monitor is a fixnum.
4233 (dir_monitor_callback): No need for CDR_SAFE.
4234 Simplify building of lisp with alternative tails.
4235 (Fgfile_add_watch, Fgfile_rm_watch):
4236 Do not assume glib functions set errno reliably on failure.
4237 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
4238 and signal an error otherwise.
4239 (Fgfile_rm_watch): Prefer CONSP to !NILP.
4240 Use Fdelq instead of Fdelete, for speed.
4241
817ebfcf
EZ
42422013-06-05 Eli Zaretskii <eliz@gnu.org>
4243
4244 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
4245 don't insist on being invoked on a highlighted tool-bar button.
4246 Avoids losing tool-bar functionality when mouse-highlight is nil.
4247 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
4248 Don't highlight when mouse-highlight is nil.
4249 (note_mouse_highlight): When mouse-highlight is nil, don't return
4250 right away; instead, run tool-bar and mode-line highlight
4251 subroutine, clear any existing highlight, and revert the mouse
4252 pointer to its default shape. (Bug#14558)
4253
55577e7c
SM
42542013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
4255
4256 * lisp.mk (lisp): Add prog-mode.el.
4257
f019a684
PE
42582013-06-05 Paul Eggert <eggert@cs.ucla.edu>
4259
4260 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
4261 * process.c (dummy_handler): New function.
4262 (lib_child_handler): New static var.
4263 (handle_child_signal): Invoke it.
4264 (catch_child_signal): If a library has set up a signal handler,
4265 save it into lib_child_handler.
4266 (init_process_emacs): If using glib and not on Windows, tickle glib's
4267 child-handling code so that it initializes its private SIGCHLD handler.
4268 * syssignal.h (SA_SIGINFO): Default to 0.
4269 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
4270 31; it should no longer be needed now.
4271
90db8702
MA
42722013-06-05 Michael Albinus <michael.albinus@gmx.de>
4273
4274 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
4275
4276 * gfilenotify.c (globals_of_gfilenotify): New function.
4277 (syms_of_gfilenotify): Move global initialization there.
4278
4279 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
4280
bfa3acd6
SM
42812013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
4282
4283 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
4284 * keyboard.c (menu_bar_items, tool_bar_items):
4285 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
4286 not override local keymaps any more.
4287
ba59bd80
EZ
42882013-06-04 Eli Zaretskii <eliz@gnu.org>
4289
4290 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
4291
7f203aa1
EZ
42922013-06-03 Eli Zaretskii <eliz@gnu.org>
4293
9337e206
EZ
4294 * w32console.c (initialize_w32_display): Return the dimensions of
4295 the console window via 2 additional arguments, not via the current
4296 frame. This avoids crashes due to overrunning the bounds of
4297 frame's decode_mode_spec_buffer, which is not resized following
4298 the change of the frame dimensions from the initial 10x10.
4299
4300 * w32term.h (w32_initialize_display_info): Adjust prototype.
4301
4302 * term.c (init_tty): Take dimensions of the frame from the values
4303 returned by initialize_w32_display.
4304
7f203aa1
EZ
4305 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
4306 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
4307 (LIBES): Add $(GFILENOTIFY_LIBS).
4308
4309 * w32inevt.c (handle_file_notifications): Add dummy implementation
4310 for !HAVE_W32NOTIFY.
4311
4312 * w32term.c: Wrap code with HAVE_W32NOTIFY.
4313
55a87246
JD
43142013-06-03 Jan Djärv <jan.h.d@swipnet.se>
4315
4316 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
4317
4318 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
4319
4320 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
4321
3d5ee10a
PE
43222013-06-03 Paul Eggert <eggert@cs.ucla.edu>
4323
4324 Fix minor problems found by static checking.
4325 * data.c (pure_write_error):
4326 Use xsignal2, not Fsignal, as Fsignal might return.
4327 * eval.c (set_backtrace_debug_on_exit): Now static.
4328 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
4329 No longer inline. EXTERN_INLINE is needed only for functions
4330 defined in .h files. Reindent function header as per GNU style.
4331 (backtrace_p, backtrace_top, backtrace_next):
4332 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
4333 compiler or linker. Add extern decls to pacify gcc -Wall.
4334 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
4335 Now static.
4336 * frame.c (free_monitors): Define only on platforms that need it.
4337 * nsterm.m (ns_term_init):
4338 * process.c (catch_child_signal):
4339 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
4340 defined on all porting targets these days.
4341 * process.c, process.h (catch_child_signal):
4342 Make it extern only if NS_IMPL_GNUSTEP is defined.
4343
e2d8a6f0
EZ
43442013-06-03 Eli Zaretskii <eliz@gnu.org>
4345
4346 * w32.c (gettimeofday): Make the signature identical to prototype
4347 in nt/inc/sys/time.h.
4348
a8a7c5f6
SM
43492013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
4350
4351 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
4352 .gdbinit.
4353
4354 * keyboard.c (safe_run_hooks_error): Improve error message.
4355
4356 * data.c (pure_write_error): Add `object' argument.
4357 * puresize.h (CHECK_IMPURE): Use it.
4358
c9628c79
MA
43592013-06-03 Michael Albinus <michael.albinus@gmx.de>
4360
4361 * Makefile.in (NOTIFY_OBJ): New variable.
4362 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
4363
4364 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
4365 Call syms_of_gfilenotify.
4366
4367 * gfilenotify.c: New file.
4368
4369 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
4370 and Qfile_w32notify.
4371 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
4372 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
4373
4374 * lisp.h: Declare syms_of_gfilenotify.
4375
4376 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
4377
2f592f95
SM
43782013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
4379
4380 Merge the specpdl and backtrace stacks. Make the structure of the
4381 specpdl entries more obvious via a tagged union of structs.
4382 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
4383 (enum specbind_tag): New enum.
4384 (struct specbinding): Make it a tagged union of structs.
4385 Add a case for backtrace records.
4386 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
4387 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
4388 (backtrace_debug_on_exit): New accessors.
4389 (struct backtrace): Remove.
4390 (struct catchtag): Remove backlist field.
4391 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
4392 Move to eval.c.
4393 (Flocal_variable_p): Speed up the common case where the binding is
4394 already loaded.
4395 * eval.c (backtrace_list): Remove.
4396 (set_specpdl_symbol, set_specpdl_old_value): Remove.
4397 (set_backtrace_args, set_backtrace_nargs)
4398 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
4399 (backtrace_next): New functions.
4400 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
4401 (unwind_to_catch, internal_lisp_condition_case)
4402 (internal_condition_case, internal_condition_case_1)
4403 (internal_condition_case_2, internal_condition_case_n): Don't bother
4404 with backtrace_list any more.
4405 (Fsignal): Adjust to new backtrace format.
4406 (grow_specpdl): Move up.
4407 (record_in_backtrace): New function.
4408 (eval_sub, Ffuncall): Use it.
4409 (apply_lambda): Adjust to new backtrace format.
4410 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
4411 data.c.
4412 (specbind): Adjust to new specpdl format. Simplify.
4413 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
4414 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
4415 backtrace format.
4416 (mark_backtrace): Remove.
4417 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
4418 * xdisp.c (redisplay_internal): Use record_in_backtrace.
4419 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
4420 Use mark_specpdl.
4421 * profiler.c (record_backtrace): Use get_backtrace.
4422 (handle_profiler_signal): Use backtrace_top_function.
4423 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
4424 accessor functions.
4425
c0342369
JD
44262013-06-02 Jan Djärv <jan.h.d@swipnet.se>
4427
4428 * process.h (catch_child_signal): Declare.
4429
4430 * process.c (catch_child_signal): New function.
4431 (init_process_emacs): Call it.
4432
4433 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
4434 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
4435 NS_IMPL_COCOA.
4436 (x_set_cursor_type): Remove declaration.
4437 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
4438 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
4439 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
4440 (ns_get_color): Use F suffix on float.
4441 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
4442 (ns_get_rgb_color): Remove.
4443 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
4444 (note_mouse_movement): x and y are CGFloat.
4445 (ns_draw_fringe_bitmap): Remove unused rowY.
4446 Change #if to COCOA && >= 10_6.
4447 (ns_draw_window_cursor): Remove unused overspill.
4448 (ns_draw_underwave): width and x are EamcsCGFloat.
4449 (ns_draw_box): thickness is CGFloat.
4450 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
4451 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
4452 if not in main thread.
4453 (ns_get_pending_menu_title, ns_check_menu_open)
4454 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
4455 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
4456 (sendFromMainThread:): New method.
4457 (changeFont:): size is CGFloat.
4458 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
4459 Disable warning about permanent text.
4460 (characterIndexForPoint:): Adjust return type depending on GNUStep
4461 version.
4462 (mouseDown:): delta is CGFloat.
4463 (updateFrameSize): Remove unised variable f.
4464 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
4465 Cast float to EmacsCGFloat.
4466 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
4467 also to -1 when restoring.
4468 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
4469 inside NS_IMPL_COCOA.
4470 (toggleFullScreen:): Put call to toggleFullScreen inside
4471 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
4472 (setPosition:portion:whole:): por is CGFloat.
4473 (getMouseMotionPart:window:x:y:): Add F suffix to float.
4474 (mouseDown:): Use CGFloat.
4475 (mouseDragged:): Remove unised variable edge.
4476 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
4477
4478 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
4479 of CGFloat differs.
4480 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
4481 when NS_IMPL_GNUSTEP.
4482 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
4483 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
4484 (EmacsToolbar): Add clearAll. Add tag argument to
4485 addDisplayItemWithImage.
4486 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
4487
4488 * nsselect.m (ns_get_local_selection): Remove unused variable type.
4489
4490 * nsmenu.m (ns_update_menubar): Make static.
4491 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
4492 (fillWithWidgetValue:): Add cast to SEL for setAction.
4493 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
4494 (update_frame_tool_bar): Update code for GNUStep.
4495 (clearAll): New method.
4496 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 4497 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 4498 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
4499 call to insertItemWithItemIdentifier.
4500 (validateVisibleItems): Fix indentation.
4501 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
4502 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
4503 UtilityWindow to aStyle, remove call to setStyleMask.
4504
4505 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
4506
4507 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
4508 (ns_charset_covers, ns_get_covering_families, nsfont_open):
4509 Use F suffix on floats.
4510 (ns_char_width): Returns CGFloat.
4511 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 4512 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
4513 DPSxshow.
4514 (ns_glyph_metrics): CGFloat instead of float.
4515
a0eb10b3
JB
4516 * nsfns.m (x_set_foreground_color, x_set_background_color):
4517 Use EmacsCGFloat.
4518 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
4519 remove unused variables.
4520 (Fns_read_file_name): Keep track if panel is for save.
4521 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 4522 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
4523 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
4524 Just return the input if GNUStep.
c0342369
JD
4525 (x_screen_planes): Remove.
4526 (Fxw_color_values): Use EmacsCGFloat
4527 (Fns_display_monitor_attributes_list): Only get screen number for
4528 Cocoa.
ef099a94 4529 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
4530 EmacsSavePanel.
4531 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
4532 ns_directory_from_panel.
4533
da9aff11
PE
45342013-06-01 Paul Eggert <eggert@cs.ucla.edu>
4535
4536 * process.c (handle_child_signal): Also use WCONTINUED.
4537 This is so that list-processes doesn't mistakenly list the process
4538 as stopped, when the process has actually been continued and is
4539 now running.
4540
0e64479a
PE
45412013-05-31 Paul Eggert <eggert@cs.ucla.edu>
4542
fc186a96
PE
4543 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
4544 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
4545 not already configured.
4546
0e64479a
PE
4547 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
4548
38b787fa
EZ
45492013-05-29 Eli Zaretskii <eliz@gnu.org>
4550
4551 * Makefile.in (mostlyclean): Remove *.res files.
4552
22513e52
SM
45532013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
4554
4555 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
4556 a buffer (bug#8447).
4557
6ef3db10
EZ
45582013-05-27 Eli Zaretskii <eliz@gnu.org>
4559
4560 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
4561 display vector, and we backtrack, handle the case that the
4562 previous character position is also displayed from a display
4563 vector or covered by a display string or image. (Bug#14476)
4564
6799bb26
JD
45652013-05-25 Jan Djärv <jan.h.d@swipnet.se>
4566
4567 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
4568 (struct MonitorInfo, free_monitors): Remove.
4569 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
4570 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
4571 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
4572 Qframes, Qsource.
4573
4574 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
4575 (struct MonitorInfo, free_monitors): Remove.
4576 (ns_screen_name): Make static.
4577 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
4578 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
4579 Qframes, Qsource.
4580
4581 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
4582 (struct MonitorInfo): New struct.
4583 (free_monitors, make_monitor_attribute_list): Declare.
4584
22513e52
SM
4585 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
4586 New Lisp_Object:s.
6799bb26
JD
4587 (free_monitors, make_monitor_attribute_list): New functions.
4588 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
4589 Qsource.
4590
38cd43eb
XF
45912013-05-25 Xue Fuqiao <xfq.free@gmail.com>
4592
4593 * callproc.c (call_process): Refine the doc string. (Bug#14045)
4594
2af0948d
SM
45952013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
4596
a7eb9b0f
SM
4597 * keyboard.c: Apply keyboard decoding only to events that come directly
4598 from the tty, not from unread-command-events (bug#14368).
4599 (read_event_from_main_queue): New function, extracted from read_char).
4600 (read_decoded_char): Remove.
4601 (read_decoded_event_from_main_queue): New function to replace it.
4602 (read_char): Use it.
4603 (read_key_sequence): Use read_char rather than read_decoded_char.
4604
2af0948d
SM
4605 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
4606
1413e9a5
BR
46072013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
4608
4609 * casetab.c (init_casetab_once): Fix last change (bug#14424).
4610
e6d2f155
KH
46112013-05-22 Kenichi Handa <handa@gnu.org>
4612
4613 The following changes are to fix the setting of
4614 buffer-file-coding-system on, for instance, C-x RET c unix RET
4615 _FILE_OF_DOS_EOL_TYPE_ RET.
4616
4617 * coding.h (struct coding_system): New member detected_utf8_chars.
4618
4619 * coding.c (detect_coding_utf_8): Count characters and check EOL
4620 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
4621 BOM is there.
4622 (setup_coding_system): Do not initialize coding->head_ascii.
4623 (check_ascii): Do not set coding->eol_seen but update it. Do not
4624 call adjust_coding_eol_type here.
1413e9a5
BR
4625 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
4626 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
4627 of the found coding-system.
4628 (decode_coding_gap): Cancel previous change. Utilize the
4629 character numbers counted by detect_coding_utf_8. Fix detection
4630 of BOM for utf-8.
4631
ab56a6f4 46322013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
4633
4634 * search.c (looking_at_1): Only set last_thing_searched if the match
4635 changed the match-data (bug#14281).
4636
ecc3c6ed
DA
46372013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
4638
4639 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 4640 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
4641 (move_it_vertically_backward): Likewise.
4642
5ba8bf35
YM
46432013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4644
4645 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 4646 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
4647 (Fx_display_mm_width, Fx_display_mm_height):
4648 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 4649
91e8418b 4650 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 4651 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
4652 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
4653 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
4654 (Fx_display_backing_store, Fx_display_visual_class)
4655 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
4656 (Fx_display_grayscale_p, Fx_display_pixel_width)
4657 (Fx_display_pixel_height, Fx_display_planes)
4658 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
4659 (Fx_display_screens): Don't confuse X11 screens with NS screens.
4660 (Fx_display_mm_width, Fx_display_mm_height)
4661 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
4662 height for all physical monitors as in X11.
4663
fc30d803
SM
4664 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
4665 Return pixel width or height for all physical monitors as in X11.
91e8418b 4666
31ff141c
PE
46672013-05-18 Paul Eggert <eggert@cs.ucla.edu>
4668
4669 Port --enable-gcc-warnings to clang.
4670 * bytecode.c (exec_byte_code):
4671 * regex.c:
4672 Redo diagnostic pragmas to pacify clang, too.
4673 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
4674 * editfns.c (Fencode_time):
4675 * fileio.c (file_accessible_directory_p):
4676 * font.c (font_unparse_xlfd):
4677 Use '&"string"[index]' instead of '"string" + (index)'.
4678 * undo.c (user_error): Remove; unused.
4679
df065a0b
EZ
46802013-05-16 Eli Zaretskii <eliz@gnu.org>
4681
04d360e7
EZ
4682 * insdel.c (insert_1_both): Document the arguments, instead of
4683 referring to insert_1, which no longer exists.
4684
5bb98290
EZ
4685 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
4686 some window, increment windows_or_buffers_changed, so that
4687 *Messages* display in that window is updated. (Bug#14408)
4688
df065a0b
EZ
4689 * w32.c: Include epaths.h.
4690 (init_environment): Use cmdproxy.exe without leading directories.
4691 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
4692 case.
4693 (gettimeofday): Adjust signature and return value to Posix
4694 expectations.
4695
4696 * unexw32.c (open_output_file): Delete the existing emacs.exe
4697 before creating it, to break the hard link to the versioned
4698 executable.
4699
4700 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
4701 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
4702 (FIRSTFILE_OBJ): New variables.
4703 (W32_RES): Rename to EMACSRES. All users changed.
4704 (base_obj): Use $(CM_OBJ).
4705 (ALLOBJS): Use $(FIRSTFILE_OBJ).
4706 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
4707 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
4708 $(W32_RES_LINK) before $(LIBES).
4709 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
4710
1aa8d505
SM
47112013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4712
6e911150
SM
4713 * makefile.w32-in (DOC): Use just "DOC".
4714
4715 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
4716
1aa8d505
SM
4717 * process.c: Export default filters and sentinels to Elisp.
4718 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
4719 New constants.
4720 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
4721 (Fset_process_sentinel, Fformat_network_address):
4722 Default to them instead of nil.
4723 (server_accept_connection): Sentinels can't be nil any more.
4724 (read_and_dispose_of_process_output): New function, extracted from
4725 read_process_output.
4726 (read_process_output): Use it; filters can't be nil.
4727 (Finternal_default_process_filter): New function, extracted from
4728 read_process_output.
4729 (exec_sentinel_unwind): Remove function.
4730 (exec_sentinel): Don't zilch sentinel while running.
4731 (status_notify): Sentinels can't be nil.
4732 (Finternal_default_process_sentinel): New function extracted from
4733 status_notify.
4734 (setup_process_coding_systems): Default filter is not nil any more.
4735 (syms_of_process): Export new Elisp functions and initialize
4736 new constants.
4737 * lisp.h (make_lisp_proc): New function.
4738
5ac2eb34
SM
47392013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4740
4741 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
4742
eda9c7d7
EZ
47432013-05-14 Eli Zaretskii <eliz@gnu.org>
4744
4745 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
4746 unless we know that the window w is a leaf window.
4747 Another attempt at solving bug#14062.
eda9c7d7 4748
8fdeaad5
JD
47492013-05-14 Jan Djärv <jan.h.d@swipnet.se>
4750
4751 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
4752 fdesc (Bug#14375).
4753
44aa9ee6
PE
47542013-05-12 Paul Eggert <eggert@cs.ucla.edu>
4755
4756 * image.c (gif_load): Check that subimages fit (Bug#14345).
4757
759fd763
SM
47582013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
4759
4760 * lread.c (skip_dyn_eof): New function.
4761 (read1): Use it to skip the end of a file in response to #@00.
4762
4763 * doc.c (get_doc_string): Slightly relax the sanity checking.
4764
4465bfb4
JD
47652013-05-09 Jan Djärv <jan.h.d@swipnet.se>
4766
4767 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
4768 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
4769 (MonitorInfo): New struct.
4770 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
4771 (Fns_display_monitor_attributes_list): New functions.
4772 (display-usable-bounds): Remove.
4773 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
4774 Qsource.
4775
7583e2a0
PE
47762013-05-09 Paul Eggert <eggert@cs.ucla.edu>
4777
4778 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
4779 (GTK_CHECK_VERSION): New macro, if not already defined.
4780 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
4781 replaced by GTK_CHECK_VERSION.
4782
ad75d77e
PE
47832013-05-08 Paul Eggert <eggert@cs.ucla.edu>
4784
4785 * xterm.h (GTK_PREREQ): New macro.
4786 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
4787 to use this macro instead, for consistency and clarity.
4788
07525f77
EZ
47892013-05-08 Eli Zaretskii <eliz@gnu.org>
4790
4791 * xdisp.c (row_for_charpos_p): New function, with code of
4792 cursor_row_p, but accepts an additional argument CHARPOS instead
4793 of using a hardcoded PT.
4794 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
4795 (row_containing_pos): Call row_for_charpos_p instead of partially
4796 doing the same. Fixes cursor positioning under longlines-mode
4797 when longlines-show-effect includes more than one newline, when
4798 moving the cursor vertically up.
4799
d901fc8d
JB
48002013-05-08 Juanma Barranquero <lekktu@gmail.com>
4801
4802 * makefile.w32-in (ACL_H): New macro.
4803 ($(BLD)/fileio.$(O)): Update dependencies.
4804
f269bc61
PE
48052013-05-07 Paul Eggert <eggert@cs.ucla.edu>
4806
e7b41c4c 4807 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
4808 * Makefile.in (LIB_ACL): New macro.
4809 (LIBACL_LIBS): Remove.
4810 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
4811 * fileio.c: Include <acl.h>.
4812 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
4813 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
4814 !acl_errno_valid.
4815 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
4816 it ourselves.
4817
f269bc61
PE
4818 * unexelf.c: Don't assume ElfW (Half) fits in int.
4819 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
4820 when dealing with ElfW (Half) values, since they can exceed 2**31
4821 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
4822 (entry_address): Omit unused NUM arg. All uses changed.
4823
a261c53e
JL
48242013-05-07 Juri Linkov <juri@jurta.org>
4825
4826 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
4827 to the string converted from number with `Fnumber_to_string'.
4828 (Bug#14254)
4829
2b66427d
PE
48302013-05-07 Paul Eggert <eggert@cs.ucla.edu>
4831
4832 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
4833 This fixes a problem introduced by my previous change.
4834
15acfe41
GM
48352013-05-07 Glenn Morris <rgm@gnu.org>
4836
4837 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
4838
5ea03bf5
JD
48392013-05-07 Jan Djärv <jan.h.d@swipnet.se>
4840
4841 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
4842
e0c9d565
PE
48432013-05-07 Paul Eggert <eggert@cs.ucla.edu>
4844
4845 Static checking by GCC 4.8.0.
4846 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
4847 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
4848 (x_get_monitor_attributes_fallback)
4849 (x_get_monitor_attributes_xinerama)
4850 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
4851 Define only if USE_GTK.
4852 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
4853 (x_get_monitor_attributes_fallback): Omit unused locals.
4854 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
4855 Use double, not float, to avoid mixed-mode floating point arithmetic.
4856
4e3f9230
YM
48572013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4858 Jan Djärv <jan.h.d@swipnet.se>
4859
4860 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
4861 (XINERAMA_CFLAGS): New macros.
4862 (ALL_CFLAGS, LIBES): Use them.
4863
4864 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
4865 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
4866 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
4867 (syms_of_xfns): DEFSYM them.
4868 (struct MonitorInfo): New struct.
4869 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
4870 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
4871 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
4872 (x_get_monitor_attributes_xinerama): New functions.
4873 (Fx_display_monitor_attributes_list): New primitive.
4874 (syms_of_xfns): Defsubr it.
4875
4876 * xterm.h (x_display_info): Add Xatom_net_workarea and
4877 Xatom_net_current_desktop.
4878
4879 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
4880 and dpyinfo->Xatom_net_current_desktop.
4881
05839b6a
EZ
48822013-05-06 Eli Zaretskii <eliz@gnu.org>
4883
4884 * xdisp.c (pos_visible_p): Use the special code for finding the
4885 beginning of a display property or overlay for any "replacing"
4886 display property, not just for display strings. This solves
4887 incorrect reporting of position by posn-at-point. (Bug#14241)
4888
dc4a2ee0
PE
48892013-05-06 Paul Eggert <eggert@cs.ucla.edu>
4890
5ee94506
PE
4891 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
4892 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
4893 Verify that ElfW (Half) fits in int.
4894 (fatal): Use same signature as lisp.h.
4895 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
4896 configure and build with -DUNEXELF_DEBUG without worrying about
4897 other modules that use DEBUG.
4898 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
4899 possibly-wide integers now uses it instead of plain fprintf.
4900 (entry_address): New function, which avoids problems with 32-bit
4901 overflow on 64-bit hosts.
4902 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
4903 (round_up): Don't assume the remainder fits in int.
4904 (find_section): Use bool for boolean. Simplify debug code.
4905 (unexec): Don't assume file sizes fit in int or size_t.
4906 Omit unnecessary trailing newline in 'fatal' format.
4907 Use strerror rather than outputting decimal error number.
4908 Remove unused code when emacs is not defined;
4909 this file relies on Emacs now.
4910 Don't assume e_phnum and e_shnum are positive.
4911
dc4a2ee0
PE
4912 * regex.c: Fix problems when DEBUG is defined.
4913 (extract_number, extract_number_and_incr): Define regardless of
4914 whether DEBUG is defined; that's simpler and makes the code less
4915 likely to go stale in the normal case when DEBUG is not defined.
4916 Return int rather than taking an int * arg. All callers changed.
4917 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
4918 Remove, replacing with ...
4919 (DEBUG_PRINT): New macro. All callers changed.
4920 (DEBUG_COMPILES_ARGUMENTS): New macro.
4921 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
4922 (print_compiled_pattern, print_double_string) [DEBUG]:
4923 Use prototype rather than old-style definition.
4924 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
4925 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
4926 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
4927 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
4928 Don't assume ptrdiff_t, size_t, and long are the same width as int.
4929 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
4930 This matters only when DEBUG is defined.
4931
14c7ed05
EZ
49322013-05-05 Eli Zaretskii <eliz@gnu.org>
4933
4934 * xdisp.c (set_iterator_to_next): Set the
4935 ignore_overlay_strings_at_pos_p flag only if we are _really_
4936 iterating over an overlay string, as indicated by the
4937 current.overlay_string_index member. (Bug#14306)
4938
e6076b1b
JD
49392013-05-05 Jan Djärv <jan.h.d@swipnet.se>
4940
4941 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
4942 to where it is used, to avoid autorelease issues (Bug#14050).
4943
cbee2131
PE
49442013-05-05 Paul Eggert <eggert@cs.ucla.edu>
4945
4946 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
4947 * fileio.c (syms_of_fileio): Implement this.
4948 * filelock.c (create_lock_file): If symbolic links don't work, so
4949 we use a regular file as a lock file, do not fsync the lock file;
4950 it's not needed.
4951
30c7e542
SM
49522013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4953
4954 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
4955 (syms_of_minibuf): Adjust accodingly.
4956 * lread.c (Fread):
4957 * callint.c (Fcall_interactively): Adjust calls accordingly.
4958
5bebd186
EZ
49592013-05-04 Eli Zaretskii <eliz@gnu.org>
4960
4961 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
4962 w->contents is a buffer before computing everything else.
4963 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
4964
4965 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
4966 assertion violations. (Bug#14062)
4967
0fb0a4f3
DR
49682013-05-01 David Reitter <david.reitter@gmail.com>
4969
4970 * nsfns.m (ns_tooltip): Initialize.
4971
9e63b4a5
EZ
49722013-04-28 Eli Zaretskii <eliz@gnu.org>
4973
4974 * coding.c (decode_coding_gap): Don't remove the character before
4975 a newline unless it's a CR character. (Bug#14287)
4976
ad60824e
DN
49772013-04-28 Dan Nicolaescu <dann@gnu.org>
4978
4979 * dispextern.h (struct face): Move enum face_underline_type
4980 earlier so that bitfields can be in the same word.
4981
edbdcec0
JD
49822013-04-28 Jan Djärv <jan.h.d@swipnet.se>
4983
4984 * nsfns.m (handlePanelKeys): New function.
4985 (EmacsOpenPanel:performKeyEquivalent:)
4986 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
4987 arrows/function/control and copy/paste keys (Bug#14296).
4988
0208ede7
JL
49892013-04-27 Juri Linkov <juri@jurta.org>
4990
4991 * callint.c (Fcall_interactively): Call `Qread_number' for
4992 interactive code letter `n' instead of using duplicate code.
4993 (Bug#14254)
4994
b8dd59f7
PE
49952013-04-27 Paul Eggert <eggert@cs.ucla.edu>
4996
4997 * systime.h (make_timeval): Declare as 'const'.
4998
8bd722db
KH
49992013-04-27 Kenichi Handa <handa@gnu.org>
5000
5001 * font.c (font_open_entity): Always open a font of manageable
5002 size.
5003
13d0e56f 50042013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 5005
f780d632
PE
5006 Port better to AIX (Bug#14258).
5007 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
5008 to pacify AIX xlc.
5009
ec509856
KH
50102013-04-24 Kenichi Handa <handa@gnu.org>
5011
5012 * coding.c (decode_coding_iso_2022): When an invalid escape
5013 sequence is encountered, reset the invocation and designation
5014 status to the safest one.
5015
84fc48e5
PE
50162013-04-22 Paul Eggert <eggert@cs.ucla.edu>
5017
5018 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
5019 Without this fix, "make distclean" leaves stamp-h1 behind.
5020
806bda47
EC
50212013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
5022
5023 * w32fns.c (w32_fullscreen_rect): New function to compute the
5024 window rectangle for the given fullscreen mode.
5025 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
5026 longer tunes the window size. This keeps the window's edges flush
5027 with the screen and allows the taskbar to hide itself in fullboth.
5028
5029 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
5030 window decorations and uses the entire screen.
5031
5032 * w32term.h (w32_fullscreen_rect) Add prototype.
5033 (struct w32_output): Replace normal_width, normal_height,
5034 normal_top, and normal_left members with a single normal_placement
5035 struct.
5036 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
5037 Remove macros.
5038 (FRAME_NORMAL_PLACEMENT): New macro.
5039
9cc2810b
JB
50402013-04-16 Juanma Barranquero <lekktu@gmail.com>
5041
5042 * minibuf.c (Ftest_completion): Silence compiler warning.
5043
fd16b54c
EZ
50442013-04-15 Eli Zaretskii <eliz@gnu.org>
5045
5046 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 5047 bug#14062.
fd16b54c
EZ
5048
5049 * frame.h (WINDOW_FRAME): Protect macro and its argument with
5050 parentheses.
5051
5052 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
5053 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
5054 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
5055 parentheses where appropriate.
5056
9e3379a0
PE
50572013-04-14 Paul Eggert <eggert@cs.ucla.edu>
5058
5059 * keyboard.c (timer_start_idle): Remove no-longer-used local.
5060
ddd6b685
EZ
50612013-04-14 Eli Zaretskii <eliz@gnu.org>
5062
5063 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
5064 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
5065 Mention in the doc string that setting these variables takes
5066 effect only after a call to set-window-buffer. (Bug#14200)
5067
29b79ba1
EZ
50682013-04-13 Eli Zaretskii <eliz@gnu.org>
5069
5070 * indent.c (Fvertical_motion): Don't consider display strings on
5071 overlay strings as display strings on the buffer position we
5072 started from. This prevents vertical cursor motion from jumping
5073 more than one line when there's an overlay string with a display
5074 property at end of line.
5075 Reported by Karl Chen <Karl.Chen@quarl.org> in
5076 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
5077
562c6ee9
SM
50782013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
5079
5080 * window.c (select_window): `record_buffer' even if window is
5081 already selected (bug#14191).
5082
fcc1fe85
EZ
50832013-04-11 Eli Zaretskii <eliz@gnu.org>
5084
5085 * window.c (Fwindow_end): Test more flags, including the buffer's
5086 last_overlay_modified flag, to determine whether the window's
5087 display is really up-to-date. Prevents the function from
5088 returning a stale value. (Bug#14170)
5089 (Fwindow_line_height): Fix the test for up-to-date-ness of the
5090 current matrix.
5091
f009190a
EZ
50922013-04-10 Eli Zaretskii <eliz@gnu.org>
5093
5094 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
5095 garbaged only if it is not already the top frame on its TTY.
5096 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
5097 there are GUI frames open in the same session. (Bug#13864)
5098
78ce603d
SM
50992013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
5100
5101 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
5102 of marking the idle timers directly.
5103
a8036e40
SM
51042013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
5105
5106 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
5107 tables (bug#14054).
5108
7ffe7ef6
SM
51092013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
5110
5111 * window.c (select_window): Don't record_buffer while the invariant is
5112 temporarily broken (bug#14161).
5113
5114 * fns.c (Fdelq): Don't assume !NILP => CONSP.
5115
7d9f6883
EZ
51162013-04-07 Eli Zaretskii <eliz@gnu.org>
5117
5118 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
5119
5406cfd9
RF
51202013-04-07 Romain Francoise <romain@orebokech.com>
5121
5122 Ignore additional platform-specific ACL errors (Bug#13702).
5123 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
5124 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
5125
95c0e83b
JD
51262013-03-31 Jan Djärv <jan.h.d@swipnet.se>
5127
5128 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
5129 f->output_data.ns.
5130
876da980
PE
51312013-04-07 Paul Eggert <eggert@cs.ucla.edu>
5132
5133 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
5134 This bug was introduced by my 2013-02-25 change that simplified
5135 data_start configuration. Without this change, on GNU/Linux
5136 an Emacs configured with --enable-profiling fails immediately
5137 due to a profiler signal.
5138 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
5139 with these flags. On platforms where special flags are needed
5140 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
5141 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
5142 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
5143
7452b7bd
DA
51442013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
5145
5146 Get rid of some platform-specific functions examining window
5147 system and its capabilities. This is a partial rework of the
5148 2013-04-05 change.
5149 * lisp.h (have_menus_p): Remove prototype. This function is
5150 replaced with platform-independent window_system_available.
5151 (check_window_system): Move to...
5152 * frame.h (decode_window_system_frame, window_system_available):
5153 ...here, add new prototypes.
5154 * frame.c (window_system_available, decode_window_system_frame):
5155 New functions.
5156 (check_window_system): Platform-independent now.
5157 * xterm.h (x_in_use): Remove declaration.
5158 (check_x_frame):
5159 * w32term.h (check_x_frame):
5160 * nsterm.h (check_x_frame): Remove prototypes. This function
5161 is replaced with platform-independent decode_window_system_frame.
5162 * msdos.c (have_menus_p): Remove.
5163 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
5164 Remove platform-specific functions. Use check_window_system,
5165 decode_window_system_frame and check_ns_display_info where
5166 appropriate. Minor style and comment tweaks.
5167 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
5168 (check_x_frame): Likewise.
5169 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
5170 Likewise.
5171 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
5172 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
5173 * xmenu.c, xselect.c: All related users changed.
5174
251e9147
KH
51752013-04-03 Kenichi Handa <handa@gnu.org>
5176
5177 The following changes is to optimize the code for reading UTF-8
5178 files.
5179
562c6ee9 5180 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
5181 changed. Check EOL format. Do not call adjust_coding_eol_type
5182 here.
5183 (check_utf_8): New function.
5184 (adjust_coding_eol_type): Do nothing if already adjusted.
5185 (detect_coding): Compare the return value of check_ascii with
5186 coding->src_bytes. Call adjust_coding_eol_type if necessary.
5187 (decode_coding_gap): Optimize for valid UTF-8.
5188
8bc369d4
KH
51892013-03-21 Kenichi Handa <handa@gnu.org>
5190
5191 * coding.c (syms_of_coding): Cancel previous change.
5192
5193 * insdel.c (insert_from_gap): Fix previous change.
5194
73931ad1
DA
51952013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
5196
5197 Consistently use platform-specific function to detect window system.
5198 * lisp.h (check_window_system): New prototype. This function is
5199 going to replace check_x, check_w32 and check_ns.
5200 (have_menus_p): Mention msdos.c in comment.
5201 * fontset.c (check_window_system_func): Remove. Adjust all users.
5202 * fontset.h (check_window_system_func): Remove prototype.
5203 * nsterm.h (check_ns):
5204 * xterm.h (check_x):
5205 * w32term.h (check_w32): Likewise.
5206 * menu.c (Fx_popup_menu): Use check_window_system.
5207 * msdos.c (check_window_system): Define for MS-DOS.
5208 * nsfns.m (check_window_system): Define for NS. Adjust all users.
5209 * w32fns.c (check_window_system): Likewise for MS-Windows.
5210 * xfns.c (check_window_system): Likewise for X.
5211 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
5212 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
5213
7216e43b
PE
52142013-04-02 Paul Eggert <eggert@cs.ucla.edu>
5215
5216 Prefer < to > in range checks such as 0 <= i && i < N.
5217 This makes it easier to visualize quantities on a number line.
5218 This patch doesn't apply to all such range checks,
5219 only to the range checks affected by the 2013-03-24 change.
5220 This patch reverts most of the 2013-03-24 change.
5221 * alloc.c (xpalloc, Fgarbage_collect):
5222 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
5223 * character.c (string_escape_byte8):
5224 * charset.c (read_hex):
5225 * data.c (cons_to_unsigned):
5226 * dispnew.c (update_frame_1):
5227 * doc.c (Fsubstitute_command_keys):
5228 * doprnt.c (doprnt):
5229 * editfns.c (hi_time, decode_time_components):
5230 * fileio.c (file_offset):
5231 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
5232 * font.c (font_intern_prop):
5233 * frame.c (x_set_alpha):
5234 * gtkutil.c (get_utf8_string):
5235 * indent.c (check_display_width):
5236 * keymap.c (Fkey_description):
5237 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
5238 * lread.c (read1):
5239 * minibuf.c (read_minibuf_noninteractive):
5240 * process.c (wait_reading_process_output):
5241 * search.c (Freplace_match):
5242 * window.c (get_phys_cursor_glyph):
5243 * xdisp.c (redisplay_internal):
5244 * xsmfns.c (smc_save_yourself_CB):
5245 Prefer < to > for range checks.
5246 * dispnew.c (sit_for): Don't mishandle NaNs.
5247 This fixes a bug introduced in the 2013-03-24 change.
5248 * editfns.c (decode_time_components): Don't hoist comparison.
5249 This fixes another bug introduced in the 2013-03-24 change.
5250
92759988
DA
52512013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
5252
5253 * frame.h (struct frame): Drop scroll_bottom_vpos
5254 member becaue all real users are dead long ago.
5255 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
5256 * xdisp.c (redisplay_internal): Adjust user.
5257
9a1971bb
GM
52582013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
5259
f38ab167
JD
5260 * nsmenu.m (showAtX:Y:for:): setLevel to
5261 NSPopUpMenuWindowLevel (Bug#13998).
5262
6d01f1fe
JD
52632013-03-30 Jan Djärv <jan.h.d@swipnet.se>
5264
5265 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
5266 (ns_check_pending_open_menu): Declare.
5267
5268 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
5269 (x_activate_menubar): Update the menu with title that matches
5270 ns_get_pending_menu_title, and call
5271 ns_check_pending_openmenu (Bug#12698).
5272 (menuWillOpen:): New method.
5273 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
5274
5275 * nsterm.m (menu_will_open_state, menu_mouse_point)
5276 (menu_pending_title): New varaibles.
5277 (ns_get_pending_menu_title, ns_check_menu_open)
5278 (ns_check_pending_open_menu): New functions.
5279
781f4782
DA
52802013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
5281
5282 * indent.c (current_column_bol_cache): Remove leftover which is not
5283 used in Fmove_to_column any more.
5284 (current_column, scan_for_column): Adjust users.
5285 * keyboard.c (last_point_position_buffer, last_point_position_window):
5286 Remove leftovers which are not used for recording undo any more.
5287 (command_loop_1, syms_of_keyboard): Adjust users.
5288 * xdisp.c (last_max_ascent): Remove leftover which is not used in
5289 redisplay_window any more.
5290 (move_it_to): Adjust user.
5291
1921c31b
JB
52922013-03-29 Juanma Barranquero <lekktu@gmail.com>
5293
5294 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
5295 Update dependencies.
5296
717b8bcd
SM
52972013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5298
5299 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
5300 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
5301 forward references.
5302
e74aeda8
DA
53032013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
5304
5305 * window.h (struct window): Replace hchild, vchild and buffer slots
5306 with the only contents slot. This is possible because each valid
5307 window may have either the child window (in vertical or horizontal
5308 combination) or buffer to display (for the leaf window). Using that,
5309 a lof of operations to traverse and/or change window hierarchies may
5310 be simplified. New member horizontal is used to distinguish between
5311 horizontal and vertical combinations of internal windows.
5312 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
5313 (WINDOW_VERTICAL_COMBINATION_P): New macros.
5314 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
5315 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
5316 Use contents slot, not buffer, where appropriate.
5317 (wset_combination): New function.
5318 (wset_buffer): Add eassert.
5319 (Fframe_first_window): Simplify the loop reaching first window.
5320 (Fwindow_buffer): Use WINDOW_LEAF_P.
5321 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
5322 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
5323 (unshow_buffer): Convert initial debugging check to eassert.
5324 (replace_window, recombine_windows, Fdelete_other_windows_internal)
5325 (make_parent_window, window_resize_check, window_resize_apply)
5326 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
5327 (Fset_window_configuration, delete_all_child_windows, save_window_save):
5328 Adjust to match struct window changes.
5329 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
5330 (mark_window_cursors_off, count_windows, get_leaf_windows)
5331 (foreach_window_1): Simplify the loop.
5332 * alloc.c (mark_object): Do not check for the leaf window because
5333 internal windows has no glyph matrices anyway.
5334 * dispnew.c (clear_window_matrices, showing_window_margins_p)
5335 (allocate_matrices_for_window_redisplay, fake_current_matrices)
5336 (allocate_matrices_for_frame_redisplay, free_window_matrices)
5337 (build_frame_matrix_from_window_tree, mirror_make_current)
5338 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
5339 (update_window_tree, set_window_update_flags): Simplify the loop.
5340 (sync_window_with_frame_matrix_rows): Enforce live window.
5341 Use contents slot, not buffer, where appropriate.
5342 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
5343 and WINDOW_HORIZONTAL_COMBINATION_P.
5344 (make_frame_visible_1): Simplify the loop.
5345 Use contents slot, not buffer, where appropriate.
5346 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
5347 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
5348 (expose_window_tree): Likewise.
5349 Use contents slot, not buffer, where appropriate.
5350 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
5351 to avoid deleted windows. Use contents slot instead of buffer.
5352 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
5353 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
5354 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
5355 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
5356
121ab1cd
EZ
53572013-03-28 Eli Zaretskii <eliz@gnu.org>
5358
ef454cf7
EZ
5359 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
5360 identify the reasons for assertion violations in bug#14062 and
5361 similar ones.
21e930f8
EZ
5362 (Fx_show_tip): Fix compilation error under
5363 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 5364
121ab1cd
EZ
5365 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
5366 Reported by <rzl24ozi@gmail.com>.
5367
5c89ca24
DA
53682013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
5369
5370 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
5371 start marker...
562c6ee9
SM
5372 (unwind_with_echo_area_buffer): ...to restore it here.
5373 This is needed to ensure that...
5c89ca24
DA
5374 (redisplay_window): ...both window markers are valid here,
5375 which is verified by eassert.
5376 * editfns.c (save_excursion_save): Do not assume that
5377 selected_window always displays the buffer.
c7f53895
DA
5378 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
5379 Fix comment.
5c89ca24 5380
f557c1b1
SM
53812013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
5382
5383 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
5384 the upcase table.
5385
40693bba 53862013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
5387
5388 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
5389
c86f791f
EZ
53902013-03-27 Eli Zaretskii <eliz@gnu.org>
5391
5392 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
5393 since MinGW's w32api headers do. This avoids compiler warnings.
5394
5395 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
5396 if already defined.
5397
c6e72e17
EZ
53982013-03-26 Eli Zaretskii <eliz@gnu.org>
5399
5400 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
5401
54e95010
JD
54022013-03-26 Jan Djärv <jan.h.d@swipnet.se>
5403
5404 * gtkutil.c (style_changed_cb): Check if frame is live and an
5405 X frame (Bug#14038).
5406
b88b62de
EZ
54072013-03-26 Eli Zaretskii <eliz@gnu.org>
5408
a18d7de6
EZ
5409 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
5410 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
5411 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
5412 MinGW64.
8f5e14c8
EZ
5413 Move inclusion of time.h before sys/time.h, so that MinGW64 could
5414 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 5415
b88b62de
EZ
5416 Fix incompatibilities between MinGW.org and MinGW64 headers.
5417 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
5418
5419 * w32.c (REPARSE_DATA_BUFFER): Guard with
5420 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
5421
c074e458
JD
54222013-03-25 Jan Djärv <jan.h.d@swipnet.se>
5423
5424 * xterm.c: Include X11/XKBlib.h
5425 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
5426
908589fd
AS
54272013-03-24 Andreas Schwab <schwab@linux-m68k.org>
5428
5429 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
5430 written backwards.
5431 * blockinput.h (input_blocked_p): Likewise.
5432 * bytecode.c (exec_byte_code): Likewise.
5433 * callproc.c (call_process_kill, call_process_cleanup)
5434 (Fcall_process): Likewise.
5435 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
5436 (Fccl_execute_on_string): Likewise.
5437 * character.c (string_escape_byte8): Likewise.
5438 * charset.c (read_hex): Likewise.
5439 * cm.c (calccost): Likewise.
5440 * data.c (cons_to_unsigned): Likewise.
5441 * dired.c (directory_files_internal, file_name_completion):
5442 Likewise.
5443 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
5444 (sit_for): Likewise.
5445 * doc.c (Fsubstitute_command_keys): Likewise.
5446 * doprnt.c (doprnt): Likewise.
5447 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
5448 * emacsgtkfixed.c: Likewise.
5449 * fileio.c (file_offset, Fwrite_region): Likewise.
5450 * floatfns.c (Fexpt, fmod_float): Likewise.
5451 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
5452 Likewise.
5453 * font.c (font_intern_prop): Likewise.
5454 * frame.c (x_set_alpha): Likewise.
5455 * gtkutil.c (get_utf8_string): Likewise.
5456 * indent.c (check_display_width): Likewise.
5457 * intervals.c (create_root_interval, rotate_right, rotate_left)
5458 (split_interval_right, split_interval_left)
5459 (adjust_intervals_for_insertion, delete_node)
5460 (interval_deletion_adjustment, adjust_intervals_for_deletion)
5461 (merge_interval_right, merge_interval_left, copy_intervals)
5462 (set_intervals_multibyte_1): Likewise.
5463 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
5464 * keymap.c (Fkey_description): Likewise.
5465 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
5466 * lread.c (openp, read_integer, read1, string_to_number):
5467 Likewise.
5468 * menu.c (ensure_menu_items): Likewise.
5469 * minibuf.c (read_minibuf_noninteractive): Likewise.
5470 * print.c (printchar, strout): Likewise.
5471 * process.c (create_process, Faccept_process_output)
5472 (wait_reading_process_output, read_process_output, send_process)
5473 (wait_reading_process_output): Likewise.
5474 * profiler.c (make_log, handle_profiler_signal): Likewise.
5475 * regex.c (re_exec): Likewise.
5476 * regex.h: Likewise.
5477 * search.c (looking_at_1, Freplace_match): Likewise.
5478 * sysdep.c (get_child_status, procfs_ttyname)
5479 (procfs_get_total_memory): Likewise.
5480 * systime.h (EMACS_TIME_VALID_P): Likewise.
5481 * term.c (dissociate_if_controlling_tty): Likewise.
5482 * window.c (get_phys_cursor_glyph): Likewise.
5483 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
5484 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
5485 Likewise.
5486 * xfns.c (Fx_window_property): Likewise.
5487 * xmenu.c (set_frame_menubar): Likewise.
5488 * xselect.c (x_get_window_property, x_handle_dnd_message):
5489 Likewise.
5490 * xsmfns.c (smc_save_yourself_CB): Likewise.
5491 * xterm.c (x_scroll_bar_set_handle): Likewise.
5492
2bf7d27a
DA
54932013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
5494
5495 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
5496 to be optional or nil. Adjust comment and convert it to docstring.
5497 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
5498 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
5499
a9ebfa0b
PE
55002013-03-24 Paul Eggert <eggert@cs.ucla.edu>
5501
5502 Static checking by GCC 4.8-20130319.
5503 * image.c (gif_load): Assume pass < 3 to pacify GCC.
5504 * process.c (Fset_process_datagram_address)
5505 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
5506 * xdisp.c (get_char_face_and_encoding):
5507 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
5508 (get_glyph_face_and_encoding): Prepare face before possibly using it.
5509 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
5510
4f3576ee
KB
55112013-03-24 Ken Brown <kbrown@cornell.edu>
5512
789b5e9a
KB
5513 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
5514 fix compilation on 64-bit Cygwin, where underscores are not
5515 automatically prepended.
5516
4f3576ee
KB
5517 * w32term.c (w32_initialize): Silence compiler warning.
5518
b5b7745f
EZ
55192013-03-23 Eli Zaretskii <eliz@gnu.org>
5520
cdc0d0bd
EZ
5521 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
5522 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
5523 variables, to save and restore frame dimensions.
5524 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
5525 after returning from a 'fullscreen' configuration.
5526 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
5527 to avoid races between the main thread and the input thread.
5528
5529 * w32term.h (struct w32_output): New members normal_width,
5530 normal_height, normal_top, normal_left, and prev_fsmode.
5531 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
5532 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
5533 members of a frame.
5534
b5b7745f
EZ
5535 * w32term.c (w32fullscreen_hook): Record last value of the frame's
5536 'fullscreen' parameter. Always record previous width and height
5537 of the frame, except when switching out of maximized modes, so
5538 that they could be restored correctly, instead of resetting to the
5539 default frame dimensions. Send SC_RESTORE command to the frame,
5540 unless we are going to send SC_MAXIMIZE, to restore the frame
5541 resize hints in the mouse pointer shown by the window manager.
5542 (Bug#14032)
5543
5544 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
5545
5546 * lisp.h (get_frame_param): Adjust conditions for prototype
5547 declaration.
5548
a3454eed
KB
55492013-03-22 Ken Brown <kbrown@cornell.edu>
5550
5551 * unexcw.c: Drop unneeded inclusion of w32common.h.
5552 (report_sheap_usage): Declare.
5553 (read_exe_header): Add magic numbers for x86_64.
5554 (fixup_executable): Fix printf format specifier for unsigned long
5555 argument.
5556
5a49b79c
DA
55572013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
5558
5559 * frame.h (struct frame): Put menu_bar_window under #ifdef
5560 because this member is not needed when X toolkit is in use.
5561 (fset_menu_bar_window):
5562 * dispnew.c (clear_current_matrices, clear_desired_matrices)
5563 (free_glyphs, update_frame):
5564 * xdisp.c (expose_frame): Likewise.
5565 (display_menu_bar): Likewise. Remove redundant eassert.
5566 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
5567 toolkit is in use.
5568
d6723bf7
PE
55692013-03-21 Paul Eggert <eggert@cs.ucla.edu>
5570
7b1123d8
PE
5571 Use functions and constants to manipulate Lisp_Save_Value objects.
5572 This replaces code that used macros and strings and token-pasting.
5573 The change makes the C source a bit easier to follow,
5574 and shrinks the Emacs executable a bit.
5575 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
5576 (make_save_value): Change 1st arg from string to enum. All callers
5577 changed.
5578 (INTX): Remove.
5579 (mark_object): Use if, not #if, for GC_MARK_STACK.
5580 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
5581 (XSAVE_OBJECT): Now functions, not macros.
5582 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
5583 the constant was never used.
5584 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
5585 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
5586 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
5587 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
5588 New constants.
5589 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
5590 type3 with a single member save_type. All uses changed.
5591 (save_type, set_save_pointer, set_save_integer): New functions.
5592 * print.c (PRINTX): Remove.
5593
d6723bf7
PE
5594 * alloc.c: Remove redundant static declarations.
5595
5f24fa51
DA
55962013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
5597
5598 * window.h (struct window): Convert left_col, top_line, total_lines
5599 and total_cols from Lisp_Objects to integers. Adjust comments.
5600 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
5601 Remove.
5602 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
5603 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
5604 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
5605 Adjust users where appropriate.
5606
42143acd
DA
56072013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
5608
5609 * frame.h (struct frame): Drop resx and resy because the same data is
5610 available from window system-specific output context. Adjust users.
562c6ee9
SM
5611 (default_pixels_per_inch_x, default_pixels_per_inch_y):
5612 New functions to provide defaults when no window system available.
42143acd 5613 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 5614 (NUMVAL): Move from xdisp.c.
42143acd
DA
5615 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
5616 (Ffont_face_attributes, Fopen_font):
5617 * image.c (gs_load):
5618 * w32font.c (fill_in_logfont):
5619 * xdisp.c (calc_pixel_width_or_height):
5620 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
5621 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
5622
c0a17406
KH
56232013-03-20 Kenichi Handa <handa@gnu.org>
5624
5625 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
5626 to 1 (temporary workaround until a bug related to ASCII
5627 optimization is fixed).
5628
095d384d
DA
56292013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
5630
5631 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
5632 Signal error if window is not internal. Adjust docstring.
5633 (delete_all_child_windows): Use combination_limit to save the buffer.
5634 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
5635 * print.c (syms_of_print): Initialize debugging output not here...
5636 (init_print_once): ...but in a new function here.
5637 * lisp.h (init_print_once): Add prototype.
5638 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 5639
748fa866
DA
56402013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
5641
5642 * window.c (window_resize_check, window_resize_apply)
5643 (window_from_coordinates, recombine_windows, set_window_buffer)
5644 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
5645 (Fsplit_window_internal, Fdelete_window_internal)
5646 (freeze_window_starts): Use bool for booleans.
5647 * window.h (window_frame_coordinates, resize_frame_windows)
5648 (freeze_window_starts, set_window_buffer): Adjust prototypes.
5649
81519fd2
SM
56502013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
5651
5652 * dispnew.c (bitch_at_user): Use `user-error'.
5653
6db423a9
KB
56542013-03-17 Ken Brown <kbrown@cornell.edu>
5655
5656 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
5657 as return type of image_background. (Bug#13981)
5658 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
5659
8f2906f5
JD
56602013-03-16 Jan Djärv <jan.h.d@swipnet.se>
5661
960ce480 5662 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 5663 (ns_select): Don't return with result uninitialized.
960ce480 5664
8f2906f5
JD
5665 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
5666 and getDirectory.
5667
81519fd2
SM
5668 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
5669 New functions.
8f2906f5
JD
5670 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
5671 directories. If filename is nil, get directory name (Bug#13932).
5672 Use getFilename and getDirectory.
5673 (getFilename, getDirectory): New methods for EmacsSavePanel and
5674 EmacsOpenPanel.
5675 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
5676
cded56c1
PE
56772013-03-15 Paul Eggert <eggert@cs.ucla.edu>
5678
5679 * coding.c (decode_coding_gap): Fix typo caught by static checking.
5680
251e9147 56812013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
5682
5683 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
5684 (adjust_after_replace): Make it back to static. Delete the third
5685 arg text_at_gap_tail. Cancel the code for handling it.
5686
5687 * coding.h (struct coding_system): New member eol_seen.
5688
5689 * coding.c (detect_ascii): New function.
5690 (detect_coding): Set coding->head_ascii and coding->eol_seen only
5691 when the source bytes are actually scanned. On detecting for
5692 coding_category_utf_8_auto, call detect_ascii instead of scanning
5693 source bytes directly.
5694 (produce_chars): Call insert_from_gap with the new arg 0.
5695 (encode_coding): Likewise.
5696 (decode_coding_gap): Control ASCII optimization by the variable
5697 disable_ascii_optimization instead of #ifndef .. #endif.
5698 Deccode EOL format according to coding->eol_seen.
5699 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
5700 variable.
5701
8a44e6d1
KH
5702 * lisp.h (adjust_after_replace): Cancel externing it.
5703 (insert_from_gap): Adjust prototype.
5704
5f795e34
EZ
57052013-03-15 Eli Zaretskii <eliz@gnu.org>
5706
5707 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
5708 FULLSCREEN_MAXIMIZED. (Bug#13935)
5709
f258b4be
DA
57102013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
5711
5712 * region-cache.c (find_cache_boundary, move_cache_gap)
5713 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
5714 Simplify debugging check and convert to eassert. Adjust comment.
5715 (pp_cache): Put under ENABLE_CHECKING.
5716
a5cc4dde
EZ
57172013-03-14 Eli Zaretskii <eliz@gnu.org>
5718
5719 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
5720 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
5721 and WM_ACTIVATEAPP.
5722 (w32fullscreen_hook): If the frame is visible, reset
5723 f->want_fullscreen flag after changing the frame size. If the
5724 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
5725 (Bug#13953)
5726
3fc5e44a
DC
57272013-03-13 Daniel Colascione <dancol@dancol.org>
5728
5729 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
5730 too so that these builds can use Cygwin's file conversion
5731 functions. (We've been building and linking cygw32.o all along
5732 and just not using it.)
5733
47d7532e
PE
57342013-03-13 Paul Eggert <eggert@cs.ucla.edu>
5735
5736 File synchronization fixes (Bug#13944).
5737 * Makefile.in (LIB_FDATASYNC): New macro.
5738 (LIBES): Use it.
5739 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
5740 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
5741 Don't worry about HAVE_FSYNC, since a substitute fsync is
5742 available if the system lacks one.
5743 (Fwrite_regin): Retry fsync if interrupted.
5744
c7ffccaf
EZ
57452013-03-13 Eli Zaretskii <eliz@gnu.org>
5746
4e2df81d 5747 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
5748 activated, call w32fullscreen_hook, to make sure the new frame
5749 dimensions are in effect. (Bug#13937)
5750
8a7debc1
DA
57512013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
5752
5753 * xdisp.c (init_iterator): Simplify because both character and byte
5754 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
5755 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
5756 character and byte positions can be obtained from marker.
8a7debc1 5757
7fd8c501
PE
57582013-03-13 Paul Eggert <eggert@cs.ucla.edu>
5759
d9df6f40
PE
5760 Static checking by Sun C 5.12.
5761 * alloc.c (buffer_memory_full) [REL_ALLOC]:
5762 * bytecode.c (exec_byte_code):
5763 * dispnew.c (init_display):
5764 * eval.c (error):
5765 * fileio.c (Fsubstitute_in_file_name):
5766 * keyboard.c (Fevent_convert_list):
5767 * keymap.c (Fsingle_key_description):
5768 * term.c (maybe_fatal, fatal):
5769 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
5770 * xsmfns.c (Fhandle_save_session):
5771 Omit unreachable code.
5772 * keymap.c (map_keymap_char_table_item): Cast void * to
5773 a function pointer type; the C Standard requires this.
5774
7fd8c501
PE
5775 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
5776 Include <sys/param.h> unconditionally, as that works elsewhere and
5777 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
5778 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
5779 and FreeBSD now.
5780
a020afb9 5781See ChangeLog.12 for earlier changes.
aac0c6e3
MR
5782
5783;; Local Variables:
5784;; coding: utf-8
aac0c6e3
MR
5785;; End:
5786
ab422c4d 5787 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
5788
5789 This file is part of GNU Emacs.
5790
5791 GNU Emacs is free software: you can redistribute it and/or modify
5792 it under the terms of the GNU General Public License as published by
5793 the Free Software Foundation, either version 3 of the License, or
5794 (at your option) any later version.
5795
5796 GNU Emacs is distributed in the hope that it will be useful,
5797 but WITHOUT ANY WARRANTY; without even the implied warranty of
5798 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5799 GNU General Public License for more details.
5800
5801 You should have received a copy of the GNU General Public License
5802 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.