Fix recovering from possible decompression error. Since
[bpt/emacs.git] / src / ChangeLog
CommitLineData
de396731
DA
12013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
2
3 Fix recovering from possible decompression error. Since
4 insert_from_gap doesn't always move point, we can't use PT as
5 the position where the partially decompressed data ends, and
6 should count how may bytes was produced so far.
7 * decompress.c (struct decompress_unwind_data): Add nbytes member.
8 (unwind_decompress): Really delete partially uncompressed data.
9 (Fzlib_decompress_region): Take decompressed data size into account.
10
c76826d9
DA
112013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
12
13 * syntax.c (init_syntax_once): Adjust comment and do an early
14 initialization of Qchar_table_extra_slots just once...
15 * casetab.c (init_casetab_once):
16 * category.c (init_category_once):
17 * character.c (syms_of_character):
18 * coding.c (syms_of_coding):
19 * xdisp.c (syms_of_xdisp): ...and omit it here.
20
b34454d0
EZ
212013-08-24 Eli Zaretskii <eliz@gnu.org>
22
11f20add
EZ
23 * xdisp.c (get_next_display_element): Don't apply to characters
24 from a display vector the logic of setting it->end_of_box_run_p
25 suitable for characters from a buffer. (Bug#15175)
26
b34454d0
EZ
27 * w32.c (fdutimens): Call 'utime', which is implemented on w32.c
28 to handle directories, rather than '_utime' which doesn't.
29 (Bug#15176)
30
6e1b469e
JD
312013-08-24 Jan Djärv <jan.h.d@swipnet.se>
32
33 * gtkutil.c (x_wm_set_size_hint): Don't set hints when maximized
34 or fullscreen (Bug#14627).
35
9c05bccf
PE
362013-08-24 Paul Eggert <eggert@cs.ucla.edu>
37
38 System-dependent integer overflow fixes.
39 * process.c (Fset_process_window_size): Signal an error if
40 the window size is outside the range supported by the lower level.
41 * sysdep.c (set_window_size): Return negative on error,
42 nonnegative on success, rather than -1, 0, 1 on not in system,
43 failure, success. This is simpler. Caller changed.
44 (serial_configure): Remove unnecessary initialization of local.
45 (procfs_get_total_memory) [GNU_LINUX]: Don't assume system memory
46 size fits in unsigned long; this isn't true on some 32-bit hosts.
47 Avoid buffer overrun if some future version of /proc/meminfo has a
48 variable name longer than 20 bytes.
49 (system_process_attributes) [__FreeBSD__]:
50 Don't assume hw.availpages fits in 'int'.
51
c365c355
PE
522013-08-23 Paul Eggert <eggert@cs.ucla.edu>
53
54 Don't let very long directory names overrun the stack.
55 Fix some related minor problems involving "//", vfork.
56 * callproc.c (encode_current_directory): New function.
57 (call_process): Don't append "/"; not needed.
58 * fileio.c (file_name_as_directory_slop): New constant.
59 (file_name_as_directory): Allow SRC to be longer than SRCLEN;
60 this can save the caller having to alloca.
61 (Ffile_name_as_directory, Fdirectory_file_name, Fexpand_file_name):
62 Use SAFE_ALLOCA, not alloca.
63 (directory_file_name, Fexpand_file_name): Leave leading "//"
64 alone, since it can be special even on POSIX platforms.
65 * callproc.c (call_process):
66 * process.c (Fformat_network_address):
67 * sysdep.c (sys_subshell):
68 Use encode_current_directory rather than rolling our own.
69 (create_process): No need to encode directory; caller does that now.
70 * process.h (encode_current_directory): New decl.
71 * sysdep.c (sys_subshell): Work even if vfork trashes saved_handlers.
72 Rework to avoid 'goto xyzzy;'.
73
6c6014d4
EZ
742013-08-23 Eli Zaretskii <eliz@gnu.org>
75
76 * xdisp.c (handle_face_prop): If the default face was remapped use
77 the remapped face for strings from prefix properties. (Bug#15155)
78
9997ec56
DA
792013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
80
81 Minor cleanup for redisplay interface and few related functions.
82 * frame.h (enum text_cursor_kinds): Move from here...
83 * dispextern.h (enum text_cursor_kinds): ...to here.
84 (toplevel): Drop unnecessary declarations.
85 (struct redisplay_interface): Use bool and enum text_cursor_kinds
86 in update_window_end_hook and draw_window_cursor functions.
87 (display_and_set_cursor, x_update_cursor): Adjust prototypes.
88 * nsterm.m (ns_update_window_end, ns_draw_window_cursor):
89 * w32term.c (x_update_window_end,w32_draw_window_cursor):
90 * xterm.c (x_update_window_end, x_draw_window_cursor):
91 * xdisp.c (display_and_set_cursor, update_window_cursor)
92 (update_cursor_in_window_tree, x_update_cursor): Use bool and
93 enum text_cursor_kinds where appropriate.
94
7f780da6
DA
952013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
96
97 Redesign redisplay interface to drop updated_row and updated_area.
98 * dispextern.h (updated_row, updated_area): Remove declaration.
99 (struct redisplay_interface): Pass glyph row and row area parameters
100 to write_glyphs, insert_glyphs and clear_end_of_line functions.
101 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
102 Adjust prototypes.
103 * dispnew.c (updated_row, updated_area): Remove.
104 (redraw_overlapped_rows, update_window_line): Adjust user.
105 (update_marginal_area, update_text_area): Likewise. Pass updated row
106 as a parameter. Prefer enum glyph_row_area to int where appropriate.
107 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
108 Adjust users.
109
26495794
PE
1102013-08-22 Paul Eggert <eggert@cs.ucla.edu>
111
112 * process.c (flush_pending_output): Remove stub.
113 All uses removed.
114
4a88129a
PE
1152013-08-21 Paul Eggert <eggert@cs.ucla.edu>
116
117 * callproc.c: Fix race that killed background processes (Bug#15144).
118 (call_process): New arg TEMPFILE_INDEX. Callers changed.
119 Record deleted process-id in critical section, not afterwards.
120 Don't mistakenly kill process created by a call-process invocation
121 that discards output and does not wait.
122
0c5307b0
DA
1232013-08-21 Dmitry Antipov <dmantipov@yandex.ru>
124
125 Fix compilation with GC_MARK_STACK == GC_USE_GCPROS_AS_BEFORE
126 and GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES.
127 * alloc.c (toplevel): Remove unnecessary nested #if...#endif.
128 (mark_maybe_object) [!GC_MARK_STACK]: Define to emacs_abort
129 to shut up compiler in mark_object.
130 (dump_zombies): Convert to global and add EXTERNALLY_VISIBLE.
131
0d7c1e66
PE
1322013-08-21 Paul Eggert <eggert@cs.ucla.edu>
133
134 * process.c (allocate_pty) [PTY_OPEN]: Set fd's FD_CLOEXEC flag.
135 We can't portably rely on PTY_OPEN doing that, even if
136 it calls posix_openpt with O_CLOEXEC.
137
3f246b65
KH
1382013-08-20 Kenichi Handa <handa@gnu.org>
139
140 * character.c (string_char): Improve commentary.
141
8c2f38aa
PE
1422013-08-20 Paul Eggert <eggert@cs.ucla.edu>
143
144 * image.c (SIGNATURE_DIGESTSIZE): Remove.
145 (struct animation_cache): Make signature a flexible array member.
146 All uses changed. This is a tad slower but may insulate us better
147 from future changes to ImageMagick.
148
bb566cea
PE
1492013-08-19 Paul Eggert <eggert@cs.ucla.edu>
150
151 * image.c: Shrink memory needed for animation cache.
152 (SIGNATURE_DIGESTSIZE): New constant.
153 (struct animation_cache): Make 'signature' a fixed size array of bytes.
154 (imagemagick_create_cache): Copy the signature. This saves
155 several KB of memory that ImageMagick wastes per signature.
156 Don't bother updating the update_time, as the caller does that now.
157 (imagemagick_prune_animation_cache): Don't destroy the signature, as
158 it's a fixed size struct member now.
159 (imagemagick_get_animation_cache): Always destroy the signature,
160 as it's now imagemagick_create_cache's responsibility to copy it.
161 Avoid duplicate calls to strcmp and to imagemagick_create_cache,
162 and use memcmp rather than strcmp.
163 eassert that ImageMagick returns a signature of the specified length.
164
6da26928
LMI
1652013-08-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
166
167 * image.c (imagemagick_get_animation_cache): Don't segfault on
168 each invocation.
453f4022
LMI
169 (imagemagick_get_animation_cache): Revert to previous definition
170 so that it actually works. But keep the memory leak fix.
171 (imagemagick_get_animation_cache): Fix memory leak.
6da26928 172
22490125
PE
1732013-08-19 Paul Eggert <eggert@cs.ucla.edu>
174
d0139df5
PE
175 * image.c: Fix animation cache signature memory leak.
176 Fix some other minor performance problems while we're at it.
177 (imagemagick_create_cache): Clear just the members that
178 need clearing. Don't set update_time, as caller does that now.
179 (imagemagick_prune_animation_cache, imagemagick_get_animation_cache):
180 Simplify by using pointer-to-pointer instead of a prev pointer.
181 (imagemagick_prune_animation_cache): Use make_emacs_time rather
182 than EMACS_TIME_FROM_DOUBLE, and DestroyString rather than free.
183 (imagemagick_get_animation_cache): Don't xstrdup the image signature;
184 it's already a copy. Free the signature probe unless it's cached.
185
22490125
PE
186 * process.c (handle_child_signal): Fix crash; deleted pid (Bug#15106).
187 This was introduced by my 2013-08-12 fix for Bug#15035.
188
deb31e75
DA
1892013-08-19 Dmitry Antipov <dmantipov@yandex.ru>
190
191 * image.c (imagemagick_create_cache, imagemagick_get_animation_cache)
192 (imagemagick_prune_animation_cache): Now static.
193
319a4d03
LMI
1942013-08-18 Lars Magne Ingebrigtsen <larsi@gnus.org>
195
196 * image.c (imagemagick_get_animation_cache): Don't segfault when
197 pruning all entries.
198
f747d82e
KB
1992013-08-18 Ken Brown <kbrown@cornell.edu>
200
201 * sheap.c (STATIC_HEAP_SIZE): Adjust to current needs; use bigger
202 static heap if ENABLE_CHECKING is defined.
203 (max_bss_sbrk_ptr): New variable.
204 (bss_sbrk): Use it.
205 (report_sheap_usage): Report maximum static heap usage instead of
206 ending static heap usage.
207
d2c28fab
EZ
2082013-08-17 Eli Zaretskii <eliz@gnu.org>
209
210 * decompress.c (Fzlib_available_p) [WINDOWSNT]: Update the value
211 of zlib_initialized according to the results of calling
212 init_zlib_functions.
213
274ff63f
LMI
2142013-08-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
215
216 * image.c: Implement an ImageMagick per-image cache.
8a6f875f 217 (imagemagick_get_animation_cache): Fix a double-free error.
49ceb676
LMI
218 (imagemagick_load_image): Remove the ping_wand code, which only
219 apparently saved time on invalid animated images, and slowed down
220 everything else. Optimise for the common case.
274ff63f 221
2bede2ed
XF
2222013-08-16 Xue Fuqiao <xfq.free@gmail.com>
223
70ff8240
XF
224 * buffer.c (syms_of_buffer) <buffer-undo-list>: Doc fix.
225
de179a3e
XF
226 * editfns.c (insert_before_markers): Mention overlay in the doc string.
227
2bede2ed
XF
228 * marker.c (set_marker): Remove documentation of undefined behavior.
229
703dbeba
LMI
2302013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
231
232 * image.c (imagemagick_compute_animated_image): Animate correctly
233 when sub-images are smaller than the main image.
1d18b1e6
LMI
234 (imagemagick_compute_animated_image): Setting the iterator row to
235 zero is apparently not allowed.
79670014
LMI
236 (imagemagick_compute_animated_image): Allow images that say they
237 have sub-images that are bigger than the main image, but just crop
238 them.
703dbeba 239
63216c5e
JD
2402013-08-15 Jan Djärv <jan.h.d@swipnet.se>
241
242 * nsmenu.m (menuWillOpen:): Fix preprocessor test (Bug#15001).
243
a5b5f73f
LMI
2442013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
245
246 * image.c (imagemagick_compute_animated_image): Respect the GIF
247 disposal methods.
248
0fe73012
KB
2492013-08-15 Ken Brown <kbrown@cornell.edu>
250
251 * emacs.c (main): Update comment about G_SLICE_ALWAYS_MALLOC.
252 * gmalloc.c (memalign) [CYGWIN]: Revert last change; it's not
253 needed.
254
691a357f
PE
2552013-08-15 Paul Eggert <eggert@cs.ucla.edu>
256
257 Fix minor problems found by static checking.
258 * frame.c (delete_frame):
259 * xdisp.c (next_element_from_display_vector):
260 Avoid uninitialized local.
261 * image.c (imagemagick_compute_animated_image): Port to C89.
262 Prefer usual GNU indentation style for loops.
263 Be more careful about bizarrely large sizes, by using ptrdiff_t
264 instead of int.
265
42fe2e88
DA
2662013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
267
268 Fix infinite frame selection loop (Bug#15025).
269 * frame.c (delete_frame): Prefer fast ad-hoc loop to next_frame.
270
d39a3da6
EZ
2712013-08-15 Eli Zaretskii <eliz@gnu.org>
272
273 * xdisp.c (compute_window_start_on_continuation_line): When
274 WORD_WRAP is in effect, use move_it_to instead of move_it_by_lines
275 to make sure we end up setting the window start at the leftmost
276 visible character of the display line. This avoids funky
277 horizontal shifting because the window start is not kept on the
278 same position. (Bug#15090)
05426239
EZ
279 (next_element_from_display_vector): Support 'box' face attribute
280 in the face definitions of a display vector. (Bug#15099)
d39a3da6 281
6e856b69
LMI
2822013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
283
284 * image.c (imagemagick_compute_animated_image): Implement animated
285 images (bug#14700).
995be755
LMI
286 (imagemagick_compute_animated_image): Fix some compilation
287 warnings. Implement a very simple cache to make the animation
288 usable at all, but it should be replaced with a per-image cache.
6e856b69 289
d5a1acfa
DA
2902013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
291
292 * lisp.h (FOR_EACH_ALIST_VALUE): New macro
293 to do `for' loops over alist values.
294 * buffer.h (FOR_EACH_BUFFER):
295 * process.c (FOR_EACH_PROCESS): Use it.
296 (handle_child_signal, status_notify, Fget_buffer_process)
297 (kill_buffer_processes): Use FOR_EACH_PROCESS.
298
9c253307
DA
2992013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
300
301 * term.c (get_named_tty, create_tty_output, tty_free_frame_resources)
302 (tty_free_frame_resources, delete_tty): Prefer eassert to emacs_abort.
303 * image.c (make_image_cache): For struct image_cache, prefer xmalloc
304 to xzalloc and so avoid redundant call to memset.
305 * xterm.c (x_term_init): Avoid unnecessary initializations of dpyinfo
306 members because it is allocated with xzalloc and so already zeroed.
307
05e64f9f
KB
3082013-08-14 Ken Brown <kbrown@cornell.edu>
309
310 * gmalloc.c (memalign) [CYGWIN]: Rename to emacs_memalign
311 (Bug#15094).
312
5b71542d
DA
3132013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
314
315 Utility function and macro to copy Lisp string to C string.
316 * lisp.h (xlispstrdupa): New macro.
317 (xlispstrdup): New prototype.
318 * alloc.c (xlispstrdup): New function.
319 * callint.c (Fcall_interactively):
320 * fileio.c (Ffile_name_directory, Fexpand_file_name)
321 (Fsubstitute_in_file_name):
322 * frame.c (Fmake_terminal_frame): Use xlispstrdupa.
323 * image.c (x_create_bitmap_from_file):
324 * w32term.c (w32_term_init):
325 * xterm.c (x_term_init): Use xlispstrdup.
326
71530c97
LMI
3272013-08-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
328
4ce82fb8
LMI
329 * image.c (imagemagick_load_image): Make animated pictures work.
330 There's still some problems with background color settings, though
331 (bug#14700).
332
71530c97
LMI
333 * decompress.c (unwind_decompress): Always restore point.
334
7510a061
XF
3352013-08-14 Xue Fuqiao <xfq.free@gmail.com>
336
337 * marker.c (set_marker): Reformat documentation.
338
01c3051f
PE
3392013-08-14 Paul Eggert <eggert@cs.ucla.edu>
340
aab1fcdf
PE
341 * xdisp.c (cursor_type_changed): Now static.
342
01c3051f
PE
343 * image.c (imagemagick_filename_hint): New arg HINT_BUFFER.
344 Use changed. This avoids the need to call xmalloc and for the
345 caller to call xfree, and avoids memory leaks in some situations.
346
2084152a
DA
3472013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
348
349 * xdisp.c (adjust_window_ends): Move duplicated code to new function.
350 (try_window, try_window_reusing_current_matrix, try_window_id): Use it.
94a4e898
DA
351 (redisplay_window): If window_end_valid is cleared due to non-zero
352 windows_or_buffers_changed, clear current_matrix_up_to_date_p and
353 so do not call to try_cursor_movement for that window.
2084152a 354
02455cb6
DA
3552013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
356
357 * window.h (struct window): Convert window_end_pos and
358 window_end_vpos from Lisp_Object to ptrdiff_t and int, respectively.
359 (wset_window_end_pos, wset_window_end_vpos): Remove.
360 * dispnew.c (adjust_glyph_matrix):
361 * window.c (Fwindow_end, replace_window, set_window_buffer)
362 (make_window):
363 * xdisp.c (check_window_end, move_it_to, redisplay_internal)
364 (set_vertical_scroll_bar, redisplay_window, try_window)
365 (try_window_reusing_current_matrix, find_first_unchanged_at_end_row)
366 (try_window_id, decode_mode_spec, mouse_face_from_buffer_pos)
367 (note_mouse_highlight): Adjust users.
368 (try_cursor_movement): Likewise. Convert old precondition to eassert.
369 Add comment.
370
da5707e8
DA
3712013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
372
373 Fix --enable-gcc-warnings errors introduced in 2013-08-13 commit.
374 * image.c (imagemagick_filename_hint): Use `const char *' and
375 prefer SSDATA to SDATA to avoid warnings.
376
25554267
DA
3772013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
378
379 Cleanup window fringes, margins and scroll bars adjustments.
380 * window.c (set_window_fringes, set_window_margins)
381 (set_window_scroll_bars, apply_window_adjustment): New functions.
382 (set_window_buffer, Fset_window_margins, Fset_window_fringes)
383 (Fset_window_scroll_bars): Use them.
384
38a2c910
DA
3852013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
386
387 * window.h (struct window): Convert scroll_bar_width
388 from Lisp_Object to integer. Adjust comment.
389 (WINDOW_CONFIG_SCROLL_BAR_WIDTH, WINDOW_CONFIG_SCROLL_BAR_COLS):
390 Adjust users.
391 * window.c (wset_scroll_bar_width): Remove.
392 (make_window): Initialize scroll_bar_width.
393 (Fsplit_window_internal): Use direct assignment.
394 (Fset_window_configuration, save_window_save):
395 Convert Lisp_Object to integer and back where appropriate.
396 (Fset_window_scroll_bars): Adjust user. Return t if any scroll
397 bar was actually changed, and mention this in docstring.
398
2d065031
PE
3992013-08-13 Paul Eggert <eggert@cs.ucla.edu>
400
401 * decompress.c: Minor simplifications.
402 (Fzlib_decompress_region): Don't bother verifying
403 that avail_out <= UINT_MAX, as that was confusing.
404 Mention the restriction in a comment instead.
405 Prefer 'int' to 'ptrdiff_t' when 'int' is wide enough.
406
a5bd5abb
JD
4072013-08-13 Jan Djärv <jan.h.d@swipnet.se>
408
409 * nsmenu.m (x_activate_menubar): Check for OSX >= 10.5
410 (trackingNotification:): Call ns_check_menu_open only for OSX >= 10.5.
411
66e7901a
LMI
4122013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
413
414 * image.c (imagemagick_filename_hint): Check for errors in the
415 alist structure.
416
2fa611b7
EZ
4172013-08-13 Eli Zaretskii <eliz@gnu.org>
418
419 * window.c (Fwindow_margins): Return nil when there's no marginal
420 area, as per the documented API.
421
422 * w32term.c (x_scroll_bar_create): Use ALLOCATE_PSEUDOVECTOR, not
423 Fmake_vector, as scroll bar's struct members are not all Lisp
424 objects now. This avoids crashes in GC.
425
426 * w32term.h (struct scroll_bar): Convert fringe_extended_p to a
427 bool, so its address could be taken.
428
8259030d
LMI
4292013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
430
431 * image.c (imagemagick_filename_hint): New function to possibly
432 apply `image-content-type-suffixes'.
433 (imagemagick_load_image): Use it.
434
866c710e
EZ
4352013-08-13 Eli Zaretskii <eliz@gnu.org>
436
437 * decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil
438 if loading zlib failed.
439
f10490f0
JD
4402013-08-13 Jan Djärv <jan.h.d@swipnet.se>
441
96311be7
JD
442 * nsterm.m (ns_set_vertical_scroll_bar): Fix breakage intruduced by
443 2013-08-13 checkin below. Change bool to BOOL, rule is:
444 All Obj-C code uses BOOL, except for interfaces callable from C.
445
f10490f0
JD
446 * nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).
447
c8ae93b0
DA
4482013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
449
450 * window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
451 * nsterm.m (ns_set_vertical_scroll_bar): Use it. Use convenient
452 bool instead of BOOL.
453 * w32term.h (struct scroll_bar): Convert fringe_extended_p
454 from Lisp_Object to bitfield. Adjust comment.
455 * w32term.c (x_scroll_bar_create): Adjust user.
456 Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
457 * xterm.c (XTset_vertical_scroll_bar): Likewise.
458 Use bool for boolean.
459 * xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
460 to `unsigned int' when defining a bitfield.
461
53b64418
PE
4622013-08-13 Paul Eggert <eggert@cs.ucla.edu>
463
464 * decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
465
eeaf9bf3
DA
4662013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
467
468 * window.h (struct window): Convert left_margin_cols and
469 right_margin_cols from Lisp_Objects to integers. Adjust comment.
470 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
471 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
472 Adjust users.
473 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
474 Adjust comment.
475 (showing_window_margins_p, update_window_line, update_frame_1):
476 * fringe.c (draw_fringe_bitmap_1):
477 * xdisp.c (window_box_width): Adjust users.
478 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
479 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
480 Use direct assignment.
481 (Fset_window_configuration, save_window_save, Fwindow_margins):
482 Convert Lisp_Object to integer and back where appropriate.
483 (Fset_window_margins): Adjust user. Return t if any margin
484 was actually changed, and mention this in docstring.
485
956720af
XF
4862013-08-13 Xue Fuqiao <xfq.free@gmail.com>
487
f73f4ce6 488 * syntax.c (forward_word):
956720af
XF
489 * cmds.c (forward_char, backward_char): Mention the optional argument.
490
9e37ee3b
DA
4912013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
492
493 * window.h (struct window): Convert left_fringe_width
494 and right_fringe_width from Lisp_Objects to integers.
495 Adjust comment.
496 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
497 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
498 * window.c (wset_left_fringe_width, wset_right_fringe_width):
499 Remove.
500 (make_window): Initialize new integer fields to -1.
501 (Fsplit_window_internal): Use direct assignment.
502 (Fset_window_configuration, save_window_save): Convert
503 Lisp_Object to integer and back where appropriate.
504 (Fset_window_fringes): Adjust user. Return t if any fringe
505 was actually changed, and mention this in docstring.
506
e4375ca7
DA
5072013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
508
509 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
9cda66e4
DA
510 * nsfns.m (x_set_cursor_type):
511 * w32fns.c (x_set_cursor_type):
512 * xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
513 * xdisp.c (set_frame_cursor_types): ...but in common code.
e4375ca7 514
a45543bc
DA
5152013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
516
517 * font.c (clear_font_cache): New function, stripped from...
518 (Fclear_font_cache): ...here, which now uses the function
519 above. Adjust comment.
520 * font.h (clear_font_cache): Add prototype.
521 * xfaces.c (clear_face_cache): Use clear_font_cache.
522
ae966a86
DA
5232013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
524
525 * window.c (Fset_window_start): Compare `w', not `window' because
526 `w' might not be equal to `window' after call to decode_live_window.
527
297a545b
PE
5282013-08-12 Paul Eggert <eggert@cs.ucla.edu>
529
530 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
531 This fixes a problem introduced by the Bug#15035 patch
532 when using GPG. Reported by Herbert J. Skuhra.
533
aa942e2b
EZ
5342013-08-12 Eli Zaretskii <eliz@gnu.org>
535
536 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
537 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
538 not yet initialized.
539
7699d09e
LMI
5402013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
541
542 * decompress.c (Fzlib_decompress_region): Support zlib
543 decompression, too, and rename.
544
1d238bc7
PE
5452013-08-12 Paul Eggert <eggert@cs.ucla.edu>
546
547 Minor zlib configuration tweaks.
548 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
549 Don't assume presence of fn_inflateInit2_ zlib internal function.
550
8a44a184
LMI
5512013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
552
553 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
554 include the zlib prefix.
555
594a4307
EZ
5562013-08-12 Eli Zaretskii <eliz@gnu.org>
557
558 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
559 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
560 define static variables that are pointers to zlib functions to be
561 dynamically loaded.
562 (init_zlib_functions) [WINDOWSNT]: New function.
563 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
564 New macros.
565 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
566 macros instead of invoking the zlib functions directly.
567 (syms_of_decompress): DEFSYM Qzlib_dll. Staticpro
568 Szlib_available_p.
569
d2e113bc
DA
5702013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
571
572 Avoid looping over all frame windows to freeze and unfreeze.
573 * window.h (struct window): Drop frozen_window_start_p.
574 (freeze_window_starts): Drop prototype.
575 * frame.h (struct frame): New frozen_window_starts flag.
576 (FRAME_WINDOWS_FROZEN): New macro.
577 * window.c (freeze_window_start, freeze_window_starts):
578 Remove.
579 (select_window, replace_window): Adjust users.
580 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
581 (window_frozen_p): New function.
582 (redisplay_window): Use it.
583
94fcd171
PE
5842013-08-12 Paul Eggert <eggert@cs.ucla.edu>
585
586 Fix some fd issues when running subprocesses (Bug#15035).
587 Fix bugs that can leak files or file descriptors on errors.
588 Don't unlink open temp files, as that's hard for users to diagnose
589 when things go awry (e.g., temp disk exhausted).
590 Don't bother to lock temp files. Check for invalid recursion.
591 * callproc.c (synch_process_fd): Remove. All uses removed.
592 (synch_process_tempfile): New var or macro.
593 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
594 New constants.
595 (record_kill_process): New arg, the temp name. All callers changed.
596 (delete_temp_file): Now just a simple wrapper around unlink.
597 (call_process_kill): New arg, the call_process_fd array.
598 Close them all. Clear synch_process_pid. Remove the temp file,
599 or arrange for it to be removed.
600 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
601 that's been moved to synch_process_tempfile. Caller changed.
602 Do not remove the tempfile; that's now call_process_kill's
603 responsibility.
604 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
605 call_process_kill; the caller now does that.
606 (call_process_cleanup): Do not close the process fd; that's now
607 call_process_kill's responsibility.
608 (Fcall_process): Implement via new function call_process, which
609 has most of the old body of Fcall_process, but with a different API.
610 (call_process): New function that does not open or close filefd if
611 it is nonnegative. Record which fds need to be closed, and let
612 call_process_kill close (and remove the tempfile, on MSDOS) on error.
613 Signal an error if invoked recursively (could be done via a hook).
614 Simplify creation of the tempfile in the MSDOS case.
615 Don't create the output file until after checking for the executable.
616 Report any failure to open /dev/null.
617 Don't open /dev/null for writing twice; once is enough.
618 Don't create pipe if all output is being discarded or sent to file.
619 Don't worry about setting up the coding system or reading from the
620 pipe if all output is being discarded.
621 Hoist fd_error local into top level, to lessen block nesting.
622 Don't record deleted pid here; now done by Fcall_process_region.
623 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
624 and note its success in synch_process_tempfile.
625 Do not leak resources when child_setup fails.
626 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
627 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
628 (create_temp_file): Now returns open fd, with an additional
629 Lisp_Object * argument to return the name. All callers changed.
630 Do not close the file; rewind it instead, and leave it open for
631 the caller. Do not lock the temp file. Unwind-protect the file
632 and the file-descriptor.
633 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
634 If an asynchrounous process, record it here, not in call_process.
635 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
636 * eval.c (set_unwind_protect): New function.
637 * fileio.c (write_region): New function, generalized from the
638 old Fwrite_region. Do not lock temp files.
639 (Fwrite_region): Use it.
640 * lisp.h (set_unwind_protect, write_region): New decls.
641 * process.c: Include <verify.h>.
642 (make_process): Mark fds as initially closed.
643 (deleted_pid_list): Now a list of pid-filename pairs.
644 All uses changed.
645 (close_process_fd): New function.
646 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
647 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
648 New constants. Verify that their number matches PROCESS_OPEN_FDS.
649 (create_process, create_pty, Fmake_serial_process)
650 (server_accept_connection): Record which fds need to be closed,
651 and let deactivate_process close them.
652 (Fmake_network_process): Do not discard the unwind-protect
653 until it's safe to do so.
654 (deactivate_process): Close the fds opened by create_process etc.
655 (Fprocess_send_eof): Adjust to new way of recording open fds.
656 Report an error if /dev/null can't be opened, instead of aborting.
657 * process.h (PROCESS_OPEN_FDS): New constant.
658 (struct Lisp_Process): New member open_fds.
659 (record_kill_process, record_deleted_pid): Adjust signatures.
660 (record_deleted_pid): Move decl here ...
661 * syswait.h (record_deleted_pid): ... from here.
662
d0e615c3
PE
6632013-08-11 Paul Eggert <eggert@cs.ucla.edu>
664
665 * decompress.c: Fix bugs with large buffers and weird inputs.
666 Tune a bit. Reindent as per usual Emacs style.
667 (BUFFER_SIZE): Remove.
668 (Fdecompress_gzipped_region): Do not mishandle input buffers with
669 more than UINT_MAX bytes. Decompress into the gap instead of into
670 an auto buffer, as this should avoid copying. Return nil if
671 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
672 set immediate_quit; we shouldn't trust zlib code that much.
673
313546eb
LMI
6742013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
675
99a32242
LMI
676 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
677 errors, and really move the gap to where we want it.
678
313546eb
LMI
679 * lisp.h: Include decompress.c support.
680
681 * emacs.c (main): Include decompress.c support.
682
683 * Makefile.in: Include -lz if present.
684
d2d699ac
JD
6852013-08-11 Jan Djärv <jan.h.d@swipnet.se>
686
f90e3ebd
JD
687 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
688 (initWithTitle:): Initialize frame to 0.
689 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
690 (fillWithWidgetValue:frame:): Renamed from
691 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
692
693 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
694 fillWithWidgetValue:frame:
695
423d3b3f
JD
696 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
697 remove memory leak warnings.
698
d2d699ac
JD
699 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
700 (ns_check_menu_open): Handle menu == nil. Remove assignment to
701 menu_pending_title.
702
703 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
704 (x_activate_menubar): Update the whole menu.
705 (trackingNotification:): Call ns_check_menu_open if tracking ends.
706 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
707 current event is not NSSystemDefined (Bug#15001).
708 Call ns_check_menu_open only if trackingMenu is 2.
709 (menuDidClose:): New method, decrease trackingMenu.
710 (fillWithWidgetValue:setDelegate:): New method.
711 (fillWithWidgetValue:): Call the above.
712
713 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
714
7d652d97
PE
7152013-08-11 Paul Eggert <eggert@cs.ucla.edu>
716
717 Omit some unnecessary casts.
718 Many of these go back to the old pre-C89 days, when they may have
719 been needed, but we've been assuming C89 or later for a while now.
720 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
721 (live_float_p, live_misc_p, live_vector_p):
722 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
723 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
724 (defvar_per_buffer):
725 * callint.c (Fcall_interactively):
726 * doc.c (Fsubstitute_command_keys):
727 * filelock.c (get_boot_time):
728 * frame.c (xrdb_get_resource):
729 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
730 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
731 (xg_get_file_name_from_selector, menuitem_destroy_callback)
732 (menuitem_highlight_callback, menu_destroy_callback)
733 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
734 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
735 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
736 (xg_tool_bar_help_callback, tb_size_cb):
737 * image.c (xpm_alloc_color, png_read_from_memory)
738 (png_read_from_file, png_load_body, our_memory_skip_input_data)
739 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
740 (syms_of_image):
741 * keymap.c (describe_map):
742 * nsfns.m (Fns_display_monitor_attributes_list):
743 * nsmenu.m (process_dialog:):
744 * nsterm.m (hold_event):
745 * process.c (wait_reading_process_output):
746 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
747 * scroll.c (do_direct_scrolling, scrolling_1):
748 * termcap.c (tgetent):
749 * window.c (check_window_containing, add_window_to_list)
750 (freeze_window_starts):
751 * xdisp.c (compare_overlay_entries, vmessage):
752 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
753 (x_get_monitor_attributes_xrandr)
754 (Fx_display_monitor_attributes_list, x_display_info_for_name)
755 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
756 * xfont.c (xfont_match, xfont_open):
757 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
758 (menubar_selection_callback, menu_position_func)
759 (popup_selection_callback, create_and_show_popup_menu)
760 (dialog_selection_callback, create_and_show_dialog):
761 * xrdb.c (x_get_string_resource):
762 (main) [TESTRM]:
763 * xsmfns.c (x_session_check_input):
764 * xterm.c (x_draw_glyphless_glyph_string_foreground)
765 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
766 (xaw_jump_callback, xaw_scroll_callback):
767 Omit unnecessary casts.
768
9acc1074
PE
7692013-08-10 Paul Eggert <eggert@cs.ucla.edu>
770
771 Minor string-length refactoring.
772 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
773 * frame.c (make_monitor_attribute_list):
774 Prefer build_string to strlen + make_string.
775
361c0eb8
JD
7762013-08-10 Jan Djärv <jan.h.d@swipnet.se>
777
778 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
779 don't check minor_code (Bug#14417).
780
14ba0822
EZ
7812013-08-09 Eli Zaretskii <eliz@gnu.org>
782
783 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
784 vertical positions instead. This avoids calling MATRIX_ROW with
785 row numbers that are possibly beyond valid limits. (Bug#15064)
786
309f24d1
DA
7872013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
788
789 Use xstrdup and build_unibyte_string where applicable.
790 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
791 * xfns.c (x_window):
792 * xrdb.c (x_get_customization_string):
793 * xterm.c (xim_initialize):
794 * w32fns.c (w32_window): Use xstrdup.
795 (w32_display_monitor_attributes_list):
796 * emacs.c (init_cmdargs):
797 * keyboard.c (PUSH_C_STR):
798 * nsfont.m (nsfont_open):
799 * sysdep.c (system_process_attributes):
800 * w32.c (system_process_attributes):
801 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
802
55902276
EZ
8032013-08-09 Eli Zaretskii <eliz@gnu.org>
804
805 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
806 variables of these types so that GDB would know about them, as aid
807 for debugging fatal exceptions. (Bug#15024) See also
808 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
809 discussions.
810
10bf7f5a
JD
8112013-08-08 Jan Djärv <jan.h.d@swipnet.se>
812
813 * nsterm.m (ns_update_begin): Don't change clip path if it would be
814 larger than the NSWindow (Bug#14934).
815
65620264
DA
8162013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
817
818 Redesign redisplay interface to drop global variable updated_window.
819 Always pass currently updated window as a parameter to update routines.
820 * dispextern.h (updated_window): Remove declaration.
821 (struct redisplay_interface): Pass window parameter to
822 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
823 and after_update_window_hook.
824 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
825 Adjust prototypes.
826 * dispnew.c (updated_window): Remove.
827 (redraw_overlapped_rows, update_marginal_area, update_text_area)
828 (update_window_line): Adjust to match redisplay interface changes.
829 * nsterm.m (ns_update_window_begin, ns_update_window_end)
830 (ns_scroll_run, ns_after_update_window_line):
831 * w32term.c (x_update_window_begin, x_update_window_end)
832 (x_after_update_window_line, x_scroll_run):
833 * xterm.c (x_update_window_begin, x_update_window_end)
834 (x_after_update_window_line, x_scroll_run):
835 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
836 Likewise. Adjust comments where appropriate.
837 (x_cursor_to): Simplify because this is always called during window
838 update (but install debugging check anyway).
839 (expose_window): Check must_be_updated_p flag to see whether this
840 function is called during window update.
841
628fdc56
DA
8422013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
843
844 Do not reset window modification event counters excessively.
845 These leftovers and poor man's tricky methods to catch extra
846 redisplay's attention are no longer needed.
847 * frame.c (set_menu_bar_lines_1):
848 * minibuf.c (read_minibuf_unwind):
849 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
850 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
851 (window_scroll_line_based, Fset_window_configuration):
852 * xdisp.c (redisplay_window): Do not reset last_modified and
853 last_overlay_modified counters.
854
8fd9c92e
JD
8552013-08-07 Jan Djärv <jan.h.d@swipnet.se>
856
857 * xselect.c (x_send_client_event): Set send_event and serial, memset
858 data.l as it might be bigger than data.b. Use 24 bit mask to
859 XSendEvent (Bug#15034).
860
0ee18172
EZ
8612013-08-07 Eli Zaretskii <eliz@gnu.org>
862
863 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
864 for TTY frames that are not the top frame on their console.
865 (Bug#14616)
866
16ddd1a6
MR
8672013-08-07 Martin Rudalics <rudalics@gmx.at>
868
869 * w32term.c (w32fullscreen_hook): Really maximize frame when
870 asked for (Bug#14841).
871
d2a95ffb
DA
8722013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
873
874 Prefer selected_window to Fselected_window, likewise for frames.
875 * buffer.c (Fbuffer_swap_text):
876 * data.c (Fvariable_binding_locus):
877 * window.c (run_window_configuration_change_hook): Adjust users.
878 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
879 Use decode_live_frame.
880
170da1ec
DA
8812013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
882
883 Be more careful if selected window shows the buffer other than current,
884 use window_outdated only if this is not so. This change should also
885 address some weird issues discussed in Bug#13012.
886 * window.h (window_outdated): New prototype.
887 * window.c (window_outdated): Now here. Convert from static and
888 always assume window's buffer.
889 (Fwindow_end, Fwindow_line_height): Use it.
890 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
891 and always assume window's buffer.
892 (redisplay_window): Adjust user.
e5eefe9b 893 (redisplay_internal): Call to reconsider_clip_changes once and
170da1ec
DA
894 check whether mode line should be updated only if selected window
895 shows current buffer.
896 (run_window_scroll_functions): Use eassert for debugging check.
897 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
898
56b5d5b1
DA
8992013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
900
901 * window.c (window_scroll, window_scroll_pixel_based)
902 (window_scroll_line_based): Use bool for booleans.
903
2878ba7e
PE
9042013-08-06 Paul Eggert <eggert@cs.ucla.edu>
905
906 * process.c: Fix minor off-by-one issues in descriptor counts.
907 This shouldn't fix any real bugs, but it cleans up the code a bit.
908 (max_process_desc, max_input_desc): -1, not 0, means none.
909 All uses changed.
910 (delete_input_desc): New function.
911 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
912 (deactivate_process): Scan backwards when recomuting max_process_desc;
913 that should be faster.
914 (init_process_emacs): Initialize max_input_desc.
915
e30b79c1
DA
9162013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
917
918 Use region cache to speedup bidi_find_paragraph_start.
919 * buffer.h (struct buffer): New member bidi_paragraph_cache.
920 Rename cache_long_line_scans to cache_long_scans.
921 * buffer.c (bset_cache_long_line_scans): Rename to
922 bset_cache_long_scans.
923 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
924 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
925 into account.
926 (syms_of_buffer): Rename cache-long-line-scans to
927 cache-long-scans. Adjust docstring.
928 * search.c (newline_cache_on_off):
929 * indent.c (width_run_cache_on_off): Adjust users.
930 * bidi.c (bidi_paragraph_cache_on_off): New function.
931 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
932 * insdel.c (prepare_to_modify_buffer): Invalidate
933 bidi_paragraph_cache if enabled.
934
00012b86
DA
9352013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
936
937 Invalidate region caches only if buffer text is going to be changed.
938 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
939 (modify_text): ...new prototype.
940 (prepare_to_modify_buffer_1): New prototype.
941 * textprop.c (modify_region): Rename to...
942 (modify_text_properties): ...new function.
943 (add_text_properties_1, set_text_properties, Fremove_text_properties)
944 (Fremove_list_of_text_properties): Adjust users.
945 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
946 (modify_text): ...new function.
947 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
948 (prepare_to_modify_buffer_1): ...new function.
949 * casefiddle.c (casify_region):
950 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
951 (Ftranspose_regions): Use modify_text.
952
dc6c0eda
SM
9532013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
954
955 * lisp.mk (lisp): Add nadvice.elc.
956
8f3a2c26
DA
9572013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
958
959 New macro to iterate over live buffers similar to frames.
960 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
961 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
962 Declare buffer-related variables here to offload lisp.h.
963 * buffer.c (Vbuffer_alist): Adjust comment.
964 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
965 (other_buffer_safely):
966 * data.c (store_symval_forwarding):
967 * dispnew.c (Fframe_or_buffer_changed_p):
968 * fileio.c (Fdo_auto_save):
969 * filelock.c (unlock_all_files):
970 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
971
e0fdb694
PE
9722013-08-04 Paul Eggert <eggert@cs.ucla.edu>
973
974 Fix some minor races in hosts lacking mkostemp (Bug#15015).
975 * callproc.c (create_temp_file):
976 * filelock.c (create_lock_file):
977 Assume mkostemp, since it's now provided by Gnulib.
978
63f5c6c2
EZ
9792013-08-04 Eli Zaretskii <eliz@gnu.org>
980
981 * w32.c (mkostemp): New function.
982 (mktemp): Remove, no longer used. Most of the code reused in
983 mkostemp. (Bug#15015)
484ab239 984 (mktemp): Don't undef.
63f5c6c2 985
f0b79313
DA
9862013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
987
988 * dispnew.c (glyph_matrix_count, glyph_pool_count):
989 Move under GLYPH_DEBUG and ENABLE_CHECKING.
990 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
991 (free_glyph_pool, check_glyph_memory): Likewise for
992 all users. Adjust comments where appropriate.
993
98f638d6
PE
9942013-08-03 Paul Eggert <eggert@cs.ucla.edu>
995
996 * composite.h: Minor fixups.
997 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
998 to fix a misspelling, and change it to an inline function while
999 we're at it (it need not be a macro). All uses changed.
1000 (composition_method, composition_valid_p):
1001 Rewrite to avoid assignments in if-conditions.
1002
75c59fb3
DA
10032013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
1004
1005 Do not use global Lisp_Object in composition macros.
1006 * composite.h (composition_temp): Remove declaration.
1007 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
1008 (composition_method, composition_valid_p): ...inline functions.
416a3e01 1009 (compose_region): Remove the leftover.
75c59fb3
DA
1010 * composite.c (composition_temp): Remove.
1011 (run_composition_function, update_compositions)
1012 (composition_compute_stop_pos, composition_adjust_point)
1013 (Ffind_composition_internal):
1014 * coding.c (handle_composition_annotation):
1015 * xdisp.c (handle_composition_prop, check_point_in_composition):
1016 Related users changed.
1017
a10c8269
DA
10182013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
1019
1020 Drop FRAME_PTR typedef.
1021 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
1022 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
1023 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
1024 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
1025 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
1026 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
1027 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
1028 All related users changed.
1029
a104f656
SM
10302013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1031
1032 * eval.c (default_toplevel_binding): New function.
1033 (Fdefvar): Use it.
1034 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
1035 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
1036 (syms_of_eval): Export them.
1037 * data.c (Fdefault_value): Micro cleanup.
1038 * term.c (init_tty): Use "false".
1039
4b5c9326
DA
10402013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1041
1042 Fix X GC leak in GTK and raw (no toolkit) X ports.
1043 * xterm.c (x_free_frame_resources): If white and black relief
1044 GCs are allocated, always free them here.
1045 * xfns.c (x_make_gc): Omit redundant initialization.
1046 * widget.c (create_frame_gcs): Remove the leftover.
1047 (EmacsFrameDestroy): Do nothing because all GCs are now freed
1048 in x_free_frame_resources.
1049
b19aa636
JD
10502013-08-02 Jan Djärv <jan.h.d@swipnet.se>
1051
1052 * nsterm.m (windowWillResize:toSize:): Only change title if
1053 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
1054 modifying it.
1055 (viewDidEndLiveResize): New method.
1056
1057 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
1058 inside NS_IMPL_COCOA.
1059
af1f7e06
DA
10602013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1061
1062 * insdel.c (adjust_after_replace, replace_range, del_range_2):
1063 Do not check whether undo is enabled because record_insert and
1064 record_delete does that themselves.
1065
65b02bb9
DA
10662013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1067
1068 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
1069 member which is not really used any more.
1070 (FRAME_XIC_BASE_FONTNAME): Remove.
1071 * xfns.c (xic_free_fontset): Adjust user.
1072 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
1073 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
1074 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
1075 (xdialog_show): Use eassert for debugging check.
7ee0f047 1076 * w32term.c (x_unfocus_frame): Remove unused dummy function.
65b02bb9 1077
6318cde0
PE
10782013-08-01 Paul Eggert <eggert@cs.ucla.edu>
1079
1080 * fileio.c, fns.c (merge): Move extern decl from here ...
1081 * lisp.h (merge): ... to here.
1082
6c1a09ba
DA
10832013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1084
1085 Fix last font-related change.
1086 * w32font.h (w32font_list_internal, w32font_match_internal):
1087 Fix prototype.
1088 * w32uniscribe.c (uniscribe_list, uniscribe_match):
1089 (uniscribe_list_family): Adjust to match font API change.
1090 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
1091 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
1092
f8c20208
DA
10932013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1094
1095 * frame.h (FRAME_MOUSE_UPDATE):
1096 * nsterm.m (ns_frame_up_to_date): Omit redundant check
1097 whether hlinfo->mouse_face_mouse_frame is non-NULL.
1098
fdb396e2
DA
10992013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1100
1101 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
1102 * font.h (struct font_driver): Change list, match, and list_family
1103 functions to accept struct frame * as first arg.
1104 * font.c (font_score, font_compare, font_sort_entities): Remove
1105 prototypes.
1106 (font_sort_entities, font_list_entities, font_select_entity):
1107 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
1108 match font API change.
1109 * xfont.c (xfont_list, xfont_match, xfont_list_family):
1110 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
1111 * ftxfont.c (ftxfont_list, ftxfont_match):
1112 * xftfont.c (xftfont_list, xftfont_match):
1113 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
1114 * w32font.c (w32font_list, w32font_match, w32font_list):
1115 (w32font_list_internal, w32_font_match_internal): Likewise.
1116 * xfaces.c (Fx_family_fonts): Adjust user.
1117
52b8a085
DA
11182013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1119
1120 Do not use pure Xism x_wm_set_icon_position in non-X ports.
1121 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
1122 only if HAVE_X_WINDOWS is in use.
1123 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
1124 * nsterm.m (x_wm_set_icon_position): Remove no-op.
1125 * w32term.c (x_wm_set_icon_position): Likewise.
1126 * w32fns.c (x_icon): Adjust user.
1127
c791c18e
DA
11282013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1129
1130 * xterm.c (last_mouse_press_frame): Remove the
1131 leftover which is not really used any more.
1132 (handle_one_xevent, syms_of_xterm): Adjust users.
1ca6cc28
DA
1133 (x_flush): Call XFlush once per each X display, not frame.
1134 This is better because this code always unconditionally skips
1135 non-X frames in Vframe_list and issues the only XFlush if we
1136 have more than one X frame on the same X display.
2f935d86
DA
1137 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
1138 Use bool for booleans.
1139 (x_draw_glyph_string_background, cvt_string_to_pixel):
1140 (cvt_pixel_dtor): Drop unnecessary prototypes.
1141 * xterm.h (x_display_ok): Adjust prototype.
c791c18e 1142
f435830e
DA
11432013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1144
1145 Drop unnecessary functions that deals with frame pixel size.
1146 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
1147 (x_pixel_height): Drop prototypes.
1148 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
1149 (x_pixel_height): Drop implementations.
1150 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
1151 which should be always valid for window frame.
1152 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
1153 * w32menu.c (Fx_popup_dialog):
1154 * xmenu.c (Fx_popup_dialog): Likewise for both.
1155
84231434
DA
11562013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1157
1158 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
1159 frame parameters and call to Fmodify_frame_parameters just once.
4c131798
DA
1160 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
1161 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
1162 and mention nil frame in docstring.
84231434 1163
959067a1
DA
11642013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1165
1166 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
1167 (x_figure_window_size): Likewise. Adjust to return long.
1168 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
1169 (toplevel): Move Qterminal_live_p to...
1170 * terminal.c (toplevel): ...here, make it static, and...
1171 (syms_of_terminal): ...DEFSYM here.
1172 * frame.h (Qterminal_live_p): Remove declaration.
1173 (make_frame, x_figure_window_size): Adjust prototype.
1174 * nsfns.m (Fx_create_frame): Use long for window flags.
1175
f4b169ce
PE
11762013-07-30 Paul Eggert <eggert@cs.ucla.edu>
1177
1178 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
1179 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
1180 Do not assume that emacs_close (INT_MAX) is a no-op.
1181
bee6a2c7
DA
11822013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1183
1184 * xfaces.c (make_face_cache): For struct face_cache, prefer
1185 xmalloc to xzalloc and so avoid redundant call to memset.
1186 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
1187
d7e6881a
DA
11882013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1189
1190 * fringe.c (draw_window_fringes, update_window_fringes)
1191 (compute_fringe_widths):
1192 * w32term.c (x_draw_glyph_string):
1193 * window.c (candidate_window_p, Frecenter):
1194 * xfaces.c (realize_basic_faces, realize_default_face)
1195 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
1196 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
1197 * xfns.c (x_set_cursor_color, xic_free_xfontset):
1198 * xmenu.c (Fx_menu_bar_open_internal):
1199 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
1200 * xsettings.c (xft_settings_event):
1201 * xterm.c (x_draw_glyph_string, x_had_errors_p):
1202 Use bool for booleans. Adjust style and comments where
1203 appropriate.
1204 * dispextern.h (draw_window_fringes, update_window_fringes)
1205 (compute_fringe_widths):
1206 * xterm.h (x_had_errors_p): Adjust prototype.
1207
ec3058af
DA
12082013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1209
1210 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
1211 CHECK_LIST. Rewrite the loop to avoid useless local variable.
1212
218e0637
DA
12132013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
1214
1215 * fns.c (toplevel): Remove comment before Fsafe_length because
1216 it checks for QUIT.
1217
e560aba9
PE
12182013-07-28 Paul Eggert <eggert@cs.ucla.edu>
1219
1220 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
1221
2e5ce5de
EZ
12222013-07-28 Eli Zaretskii <eliz@gnu.org>
1223
1224 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
1225 frame which got the message is still alive, before dereferencing
1226 its pointer. (Bug#14970)
1227
1228 * frame.c (delete_frame): Test "this" frame's minibuffer window to
1229 be a live window, before using it as such. (Bug#14970)
1230
e95da6d3
EZ
12312013-07-27 Eli Zaretskii <eliz@gnu.org>
1232
1233 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
1234 w32_detect_focus_change instead of doing part of its job by hand.
1235 This fixes the problem whereby FOCUS_OUT events were not sent to
1236 the event queue.
1237
a8f93651
EZ
12382013-07-26 Eli Zaretskii <eliz@gnu.org>
1239
fec92060
EZ
1240 * process.c (Fprocess_list): Doc fix.
1241
a8f93651
EZ
1242 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
1243 being re-exposed only if it didn't ask to become visible.
1244 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
1245 was previously iconified. (Bug#14841)
1246 (x_iconify_frame): Mark the frame iconified.
1247
d5a7a9d9
PE
12482013-07-26 Paul Eggert <eggert@cs.ucla.edu>
1249
1250 Fix minor problems found by static checking.
1251 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
1252 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
1253
56ea7291
SM
12542013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
1255
1256 * eval.c (set_specpdl_old_value): New function.
1257 (unbind_to): Minor simplification.
1258 (get_backtrace_frame): New function.
1259 (Fbacktrace_frame): Use it. Add `base' argument.
1260 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
1261 (syms_of_eval): Export backtrace-eval.
1262 * xterm.c (x_focus_changed): Simplify.
1263
9d611ffe
PE
12642013-07-25 Paul Eggert <eggert@cs.ucla.edu>
1265
1266 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
1267
999c74e3
EZ
12682013-07-24 Eli Zaretskii <eliz@gnu.org>
1269
1270 * xdisp.c (redisplay_window): Instead of moving point out of
1271 scroll margin, reject the force_start method, and try scrolling
1272 instead. (Bug#14780)
1273
198fa217
KB
12742013-07-24 Ken Brown <kbrown@cornell.edu>
1275
1276 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
1277 (Bug#14944).
1278
53840e55
PE
12792013-07-24 Paul Eggert <eggert@cs.ucla.edu>
1280
1281 * eval.c (Fprogn): Do not check that BODY is a proper list.
1282 This undoes the previous change. The check slows down the
1283 interpreter, and is not needed to prevent a crash. See
1284 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
1285
60967f56
GM
12862013-07-23 Glenn Morris <rgm@gnu.org>
1287
1288 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
1289
9ca960e2
PE
12902013-07-23 Paul Eggert <eggert@cs.ucla.edu>
1291
a29c3e6d
PE
1292 Port to GNU/Linux systems with tinfo but not ncurses.
1293 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
1294 to decide whether ncurses is being used. Without this change,
1295 GCC complains about tgetent not being declared, on a system
1296 that has tinfo installed but ncurses not installed.
1297
f274311c
PE
1298 * eval.c (Fprogn): Check that BODY is a proper list.
1299
16b0520a
PE
1300 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
1301 * data.c (Fsetq_default):
1302 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
1303 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
1304 (Fcondition_case):
1305 Tune by taking advantage of the fact that ARGS is always a list
1306 when a function is declared to have UNEVALLED args.
1307
9ca960e2
PE
1308 * emacsgtkfixed.c: Port to GCC 4.6.
1309 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
1310
afacaa1b
JB
13112013-07-23 Juanma Barranquero <lekktu@gmail.com>
1312
1313 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
1314 here to silence compiler warnings.
1315
368a85a4
PE
13162013-07-22 Paul Eggert <eggert@cs.ucla.edu>
1317
1318 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
1319 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
1320 from messing up Emacs's 'struct frame' (Bug#14923).
1321
f4e891b5
PE
13222013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1323
1324 * alloc.c (make_save_ptr_ptr): Define this function.
1325 It was inadvertently omitted. It's needed only if
1326 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
1327
96c8b65e
JD
13282013-07-21 Jan Djärv <jan.h.d@swipnet.se>
1329
1330 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
1331 frame have focus (Bug#14895).
1332
ee010797
PE
13332013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1334
1335 Avoid vfork-related deadlock more cleanly.
1336 * callproc.c (child_setup): When the child's exec fails, output
1337 the program name, as that's more useful. Use O_NONBLOCK to avoid
1338 deadlock.
1339 * process.c (create_process_1): Remove; no longer needed.
1340 (create_process): Remove timer hack; no longer needed, now that
1341 the child avoids deadlock.
1342
f0398ec1 13432013-07-20 Glenn Morris <rgm@gnu.org>
8bfcc21a
GM
1344
1345 * image.c (Fimage_flush): Fix doc typo.
1346
b2a069c2
PE
13472013-07-20 Paul Eggert <eggert@cs.ucla.edu>
1348
6496aec9
PE
1349 Fix array bounds violation when pty allocation fails.
1350 * process.c (PTY_NAME_SIZE): New constant.
1351 (pty_name): Remove static variable; it's now auto.
1352 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
1353 Take pty_name as an arg rather than using a static variable.
1354 All callers changed.
1355 (create_process): Recover pty_flag from process, not from volatile local.
1356 (create_pty): Stay inside array even when pty allocation fails.
1357 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
1358
b2a069c2
PE
1359 * lread.c (Fload): Avoid initialization only when lint checking.
1360 Mention that it's needed only for older GCCs.
1361
99107004
KH
13622013-07-20 Kenichi Handa <handa@gnu.org>
1363
1364 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
1365 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
1366
6b1b199d
AS
13672013-07-20 Andreas Schwab <schwab@linux-m68k.org>
1368
1369 * lread.c (Fload): Avoid uninitialized warning.
1370
4195afc3
PE
13712013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1372
3f5bef16
PE
1373 Fix some minor file descriptor leaks and related glitches.
1374 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
1375 (create_lock_file): Use write, not emacs_write.
1376 * image.c (slurp_file, png_load_body):
1377 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
1378 (server_accept_connection):
1379 Don't leak an fd on memory allocation failure.
1380 * image.c (slurp_file): Add a cheap heuristic for growing files.
1381 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
1382 as that's what the other routines do. Maybe input need not be
1383 blocked at all, but it's better to be consistent.
1384 Avoid undefined behavior when strlen is zero.
1385
4195afc3
PE
1386 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
1387 (NSTATICS): Now a constant; doesn't need to be a macro.
1388
a1aeeffe
RS
13892013-07-19 Richard Stallman <rms@gnu.org>
1390
1391 * coding.c (decode_coding_utf_8): Add simple loop for fast
1392 processing of ASCII characters.
1393
63b34baa
PE
13942013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1395
1396 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
1397
621dd9ac
EZ
13982013-07-19 Eli Zaretskii <eliz@gnu.org>
1399
1400 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
1401 unportable 'struct x_display_info'.
1402 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
1403 is a portable type.
1404
1396ac86
PE
14052013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1406
ab9980cd
PE
1407 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
1408 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
1409 or fscanf fails.
1410 (system_process_attributes): Prefer plain char to unsigned char
1411 when either will do. Clean up properly if interrupted or if
1412 memory allocations fail. Don't assume sscanf succeeds. Remove
1413 no-longer-needed workaround to stop GCC from whining. Read
1414 command-line once, instead of multiple times. Check read status a
1415 bit more carefully.
1416
1396ac86
PE
1417 Fix obscure porting bug with varargs functions.
1418 The code assumed that int is treated like ptrdiff_t in a vararg
1419 function, which is not a portable assumption. There was a similar
1420 -- though these days less likely -- porting problem with various
1421 assumptions that pointers of different types all smell the same as
1422 far as vararg functions is conserved. To make this problem less
1423 likely in the future, redo the API to use varargs functions.
1424 * alloc.c (make_save_value): Remove this vararg function.
1425 All uses changed to ...
1426 (make_save_int_int_int, make_save_obj_obj_obj_obj)
1427 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
1428 New functions.
1429 (make_save_ptr): Rename from make_save_pointer, for consistency with
1430 the above. Define only on platforms that need it. All uses changed.
1431
4d19d194
PE
14322013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1433
1434 * keyboard.c: Try to fix typos in previous change.
1435 (DISPLAY_LIST_INFO): New macro.
1436 (kbd_buffer_get_event): Do not access members that are not present
c7064f05 1437 in X11. Revert inadvertent change of "!=" to "=".
4d19d194 1438
945c5bb1
JB
14392013-07-18 Juanma Barranquero <lekktu@gmail.com>
1440
1441 * keyboard.c (kbd_buffer_get_event):
1442 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
1443 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
1444
f4b1eb36
PE
14452013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1446
5e679a2c
PE
1447 * filelock.c: Fix unlikely file descriptor leaks.
1448 (get_boot_time_1): Rework to avoid using emacs_open.
1449 This doesn't actually fix a leak, but is better anyway.
1450 (read_lock_data): Use read, not emacs_read.
1451
a8cd4836
PE
1452 * doc.c: Fix minor memory and file descriptor leaks.
1453 * doc.c (get_doc_string): Fix memory leak when doc file absent.
1454 (get_doc_string, Fsnarf_documentation):
1455 Fix file descriptor leak on error.
1456
ef30e638
PE
1457 * term.c: Fix minor fdopen-related file descriptor leaks.
1458 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
1459 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
1460
f4b1eb36
PE
1461 * charset.c: Fix file descriptor leaks and errno issues.
1462 Include <errno.h>.
1463 (load_charset_map_from_file): Don't leak file descriptor on error.
1464 Use plain record_xmalloc since the allocation is larger than
1465 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
1466 of entries.
1467 * eval.c (record_unwind_protect_nothing):
1468 * fileio.c (fclose_unwind):
1469 New functions.
1470 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
1471 The replacement doesn't block input, but that no longer seems
1472 necessary.
1473
b648c163
PE
14742013-07-17 Paul Eggert <eggert@cs.ucla.edu>
1475
a0931322
PE
1476 * lread.c: Fix file descriptor leaks and errno issues.
1477 (Fload): Close some races that leaked fds or streams when 'load'
1478 was interrupted.
1479 (Fload, openp): Report error number of last nontrivial failure to open.
1480 ENOENT counts as trivial.
1481 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
1482 New functions.
1483 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
1484 now that the function is always called with a nonnegative arg.
1485 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
1486 All uses replaced with ...
1487 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
1488
b648c163
PE
1489 A few more minor file errno-reporting bugs.
1490 * callproc.c (Fcall_process):
1491 * doc.c (Fsnarf_documentation):
1492 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
1493 * process.c (set_socket_option):
1494 Don't let a constructor trash errno.
1495 * doc.c: Include <errno.h>.
1496
b1dc4084
JB
14972013-07-16 Juanma Barranquero <lekktu@gmail.com>
1498
1499 * w32fns.c (unwind_create_tip_frame): Fix declaration.
1500
c43843aa
PE
15012013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1502
50a30cce
PE
1503 Fix w32 bug with call-process-region (Bug#14885).
1504 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
1505 to Fcall_process when the input is empty. This simplifies the
1506 code a bit. It makes no difference on POSIXish platforms but
1507 apparently it fixes a bug on w32.
1508
44e18199 1509 Fix bug where insert-file-contents closes a file twice (Bug#14839).
41d48a42
PE
1510 * fileio.c (close_file_unwind): Don't close if FD is negative;
1511 this can happen when unwinding a zapped file descriptor.
1512 (Finsert_file_contents): Unwind-protect the fd before the point marker,
1513 in case Emacs runs out of memory between the two unwind-protects.
1514 Don't trash errno when closing FD.
1515 Zap the FD in the specpdl when closing it, instead of deferring
1516 the removal of the unwind-protect; this fixes a bug where a child
1517 function unwinds the stack past us.
1518
27e498e6
PE
1519 New unwind-protect flavors to better type-check C callbacks.
1520 This also lessens the need to write wrappers for callbacks,
1521 and the need for make_save_pointer.
1522 * alloca.c (free_save_value):
1523 * atimer.c (run_all_atimers):
1524 Now extern.
1525 * alloc.c (safe_alloca_unwind):
1526 * atimer.c (unwind_stop_other_atimers):
1527 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
1528 * menu.c (cleanup_popup_menu) [HAVE_NS]:
1529 * minibuf.c (choose_minibuf_frame_1):
1530 * process.c (make_serial_process_unwind):
1531 * xdisp.h (pop_message_unwind):
1532 * xselect.c (queue_selection_requests_unwind):
1533 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
1534 * alloca.c (record_xmalloc):
1535 Prefer record_unwind_protect_ptr to record_unwind_protect with
1536 make_save_pointer.
1537 * alloca.c (Fgarbage_collect):
1538 Prefer record_unwind_protect_void to passing a dummy.
1539 * buffer.c (restore_buffer):
1540 * window.c (restore_window_configuration):
1541 * xfns.c, w32fns.c (do_unwind_create_frame)
1542 New wrapper. All record-unwind uses of wrappee changed.
1543 * buffer.c (set_buffer_if_live):
1544 * callproc.c (call_process_cleanup, delete_temp_file):
1545 * coding.c (code_conversion_restore):
1546 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
1547 * editfns.c (save_excursion_restore)
1548 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
1549 (save_restriction_restore):
1550 * eval.c (restore_stack_limits, un_autoload):
1551 * fns.c (require_unwind):
1552 * keyboard.c (recursive_edit_unwind, tracking_off):
1553 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
1554 * macros.c (pop_kbd_macro, restore_menu_items):
1555 * nsfns.m (unwind_create_frame):
1556 * print.c (print_unwind):
1557 * process.c (start_process_unwind):
1558 * search.c (unwind_set_match_data):
1559 * window.c (select_window_norecord, select_frame_norecord):
1560 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
1561 (fast_set_selected_frame):
1562 * xfns.c, w32fns.c (unwind_create_tip_frame):
1563 Return void, not a dummy Lisp_Object. All uses changed.
1564 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
1565 * callproc.c (call_process_kill):
1566 * fileio.c (restore_point_unwind, decide_coding_unwind)
1567 (build_annotations_unwind):
1568 * insdel.c (Fcombine_after_change_execute_1):
1569 * keyboard.c (read_char_help_form_unwind):
1570 * menu.c (unuse_menu_items):
1571 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
1572 * sound.c (sound_cleanup):
1573 * xdisp.c (unwind_redisplay):
1574 * xfns.c (clean_up_dialog):
1575 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
1576 Accept no args and return void, instead of accepting and returning
1577 a dummy Lisp_Object. All uses changed.
1578 * cygw32.c (fchdir_unwind):
1579 * fileio.c (close_file_unwind):
1580 * keyboard.c (restore_kboard_configuration):
1581 * lread.c (readevalllop_1):
1582 * process.c (wait_reading_process_output_unwind):
1583 Accept int and return void, rather than accepting an Emacs integer
1584 and returning a dummy object. In some cases this fixes an
1585 unlikely bug when the corresponding int is outside Emacs integer
1586 range. All uses changed.
1587 * dired.c (directory_files_internal_unwind):
1588 * fileio.c (do_auto_save_unwind):
1589 * gtkutil.c (pop_down_dialog):
1590 * insdel.c (reset_var_on_error):
1591 * lread.c (load_unwind):
1592 * xfns.c (clean_up_file_dialog):
1593 * xmenu.c, nsmenu.m (pop_down_menu):
1594 * xmenu.c (cleanup_widget_value_tree):
1595 * xselect.c (wait_for_property_change_unwind):
1596 Accept pointer and return void, rather than accepting an Emacs
1597 save value encapsulating the pointer and returning a dummy object.
1598 All uses changed.
1599 * editfns.c (Fformat): Update the saved pointer directly via
1600 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
1601 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
1602 (unwind_body): New function.
1603 (record_unwind_protect): First arg is now a function returning void,
1604 not a dummy Lisp_Object.
1605 (record_unwind_protect_ptr, record_unwind_protect_int)
1606 (record_unwind_protect_void): New functions.
1607 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
1608 * fileio.c (struct auto_save_unwind): New type.
1609 (do_auto_save_unwind): Use it.
1610 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
1611 * insdel.c (struct rvoe_arg): New type.
1612 (reset_var_on_error): Use it.
1613 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
1614 New constants.
1615 (specbinding_func): Remove; there are now several such functions.
1616 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
1617 (set_unwind_protect_ptr): New function.
1618 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
1619
4e604a5d
PE
1620 Be simpler and more consistent about reporting I/O errors.
1621 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1622 Say "Read error" and "Write error", rather than "I/O error", or
1623 "IO error reading", or "IO error writing", when a read or write
1624 error occurs.
1625 * process.c (Fmake_network_process, wait_reading_process_output)
1626 (send_process, Fprocess_send_eof, wait_reading_process_output):
1627 Capitalize diagnostics consistently. Put "failed foo" at the
1628 start of the diagnostic, so that we don't capitalize the
1629 function name "foo". Consistently say "failed" for such
1630 diagnostics.
1631 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
1632 All callers changed. This is so it can use report_file_error.
1633 * sysdep.c (serial_open, serial_configure): Capitalize I/O
1634 diagnostics consistently as above.
1635
a9757f6a
PE
1636 * fileio.c (report_file_errno): Fix errno reporting bug.
1637 If the file name is neither null nor a pair, package it up as a
1638 singleton list. All callers changed, both to this function and to
1639 report_file_error. This fixes a bug where the memory allocator
1640 invoked by list1 set errno so that the immediately following
1641 report_file_error reported the wrong errno value.
1642
c43843aa
PE
1643 Fix minor problems found by --enable-gcc-warnings.
1644 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
1645 * keyboard.c (kbd_buffer_get_event): Remove unused local.
1646
18c26d81
JD
16472013-07-16 Jan Djärv <jan.h.d@swipnet.se>
1648
1649 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
1650 Set event->arg to Qt if switch-event shall be generated.
1651 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
1652
1653 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
1654
1655 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
1656 FOCUS_OUT_EVENT.
1657
1658 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
1659 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
1660 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
1661 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
44e18199 1662 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
18c26d81
JD
1663 and there is a focused frame.
1664 (head_table): Add focus-in and focus-out.
1665 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
1666 bind to handle-focus-in/out.
1667
1668 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
1669 (Fhandle_switch_frame): Call Fhandle_focus_in.
1670 (syms_of_frame): defsubr handle-focus-in/out.
1671
6c6f1994
PE
16722013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1673
c7ddc792
PE
1674 Fix porting bug to older POSIXish platforms (Bug#14862).
1675 * sysdep.c (emacs_pipe): New function, that implements
1676 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
1677 This should port better to CentOS 5 and to Mac OS X 10.6.
1678 All calls to pipe2 changed.
1679
6c6f1994
PE
1680 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
1681 This makes the code easier to read and the executable a bit smaller.
1682 Do not replace all calls to Fcons that happen to create lists,
1683 just calls that are intended to create lists. For example, when
1684 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
1685 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
1686 Similarly for list2 through list5.
1687 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1688 * bytecode.c (exec_byte_code):
1689 * callint.c (quotify_arg, Fcall_interactively):
1690 * callproc.c (Fcall_process, create_temp_file):
1691 * charset.c (load_charset_map_from_file)
1692 (Fdefine_charset_internal, init_charset):
1693 * coding.c (get_translation_table, detect_coding_system)
1694 (Fcheck_coding_systems_region)
1695 (Fset_terminal_coding_system_internal)
1696 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
1697 * composite.c (update_compositions, Ffind_composition_internal):
1698 * dired.c (directory_files_internal, file_name_completion)
1699 (Fsystem_users):
1700 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
1701 * doc.c (Fsnarf_documentation):
1702 * editfns.c (Fmessage_box):
1703 * emacs.c (main):
1704 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
1705 (Feval, eval_sub, Ffuncall, apply_lambda):
1706 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
1707 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
1708 (Fset_file_times, Finsert_file_contents)
1709 (Fchoose_write_coding_system, Fwrite_region):
1710 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
1711 * font.c (font_registry_charsets, font_parse_fcname)
1712 (font_prepare_cache, font_update_drivers, Flist_fonts):
1713 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
1714 * frame.c (make_frame, Fmake_terminal_frame)
1715 (x_set_frame_parameters, x_report_frame_params)
1716 (x_default_parameter, Fx_parse_geometry):
1717 * ftfont.c (syms_of_ftfont):
1718 * image.c (gif_load):
1719 * keyboard.c (command_loop_1):
1720 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
1721 (Fcopy_keymap, append_key, Fcurrent_active_maps)
1722 (Fminor_mode_key_binding, accessible_keymaps_1)
1723 (Faccessible_keymaps, Fwhere_is_internal):
1724 * lread.c (read_emacs_mule_char):
1725 * menu.c (find_and_return_menu_selection):
1726 * minibuf.c (get_minibuffer):
1727 * nsfns.m (Fns_perform_service):
1728 * nsfont.m (ns_script_to_charset):
1729 * nsmenu.m (ns_popup_dialog):
1730 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
1731 (Fx_own_selection_internal):
1732 * nsterm.m (append2):
1733 * print.c (Fredirect_debugging_output)
1734 (print_prune_string_charset):
1735 * process.c (Fdelete_process, Fprocess_contact)
1736 (Fformat_network_address, set_socket_option)
1737 (read_and_dispose_of_process_output, write_queue_push)
1738 (send_process, exec_sentinel):
1739 * sound.c (Fplay_sound_internal):
1740 * textprop.c (validate_plist, add_properties)
1741 (Fput_text_property, Fadd_face_text_property)
1742 (copy_text_properties, text_property_list, syms_of_textprop):
1743 * unexaix.c (report_error):
1744 * unexcoff.c (report_error):
1745 * unexsol.c (unexec):
1746 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
1747 (Fformat_mode_line, syms_of_xdisp):
1748 * xfaces.c (set_font_frame_param)
1749 (Finternal_lisp_face_attribute_values)
1750 (Finternal_merge_in_global_face, syms_of_xfaces):
1751 * xfns.c (x_default_scroll_bar_color_parameter)
1752 (x_default_font_parameter, x_create_tip_frame):
1753 * xfont.c (xfont_supported_scripts):
1754 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
1755 (menu_help_callback, xmenu_show):
1756 * xml.c (make_dom):
1757 * xterm.c (set_wm_state):
1758 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
1759 and similarly for list2 through list5.
1760
bafe80ce
PE
17612013-07-15 Paul Eggert <eggert@cs.ucla.edu>
1762
1763 * callproc.c (Fcall_process_region): Fix minor race and tune.
1764 (create_temp_file): New function, with the temp-file-creation part
1765 of the old Fcall_process_region. Use Fcopy_sequence to create the
1766 temp file name, rather than alloca + build_string, for simplicity.
1767 Don't bother to block input around the temp file creation;
1768 shouldn't be needed. Simplify use of mktemp. Use
1769 record_unwind_protect immediately after creating the temp file;
1770 this closes an unlikely race where the temp file was not removed.
1771 Use memcpy rather than an open-coded loop.
1772 (Fcall_process_region): Use the new function. If the input is
1773 empty, redirect from /dev/null rather than from a newly created
1774 empty temp file; this avoids unnecessary file system traffic.
1775
4700b5a5
PE
17762013-07-14 Paul Eggert <eggert@cs.ucla.edu>
1777
5c97beae
PE
1778 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
1779 Simplify by making this case like the other two. This is a bit
1780 slower on obsolete hosts, but the extra complexity isn't worth it.
1781
4700b5a5
PE
1782 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
1783 * process.c (create_process) [!DOS_NT]:
1784 Remove now-unnecessary calls to emacs_close.
1785
f9a74c4c
EZ
17862013-07-13 Eli Zaretskii <eliz@gnu.org>
1787
922ae7ee
EZ
1788 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
1789 returning early. (Bug#14850)
1790
f9a74c4c
EZ
1791 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
1792 and inhibit-iso-escape-detection attributes of 'undecided'.
1793 (Bug#14822)
1794
5e301d76
PE
17952013-07-13 Paul Eggert <eggert@cs.ucla.edu>
1796
69e0e5ee
PE
1797 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
1798 Reported by Herbert J. Skuhra in
1799 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
1800
5e301d76
PE
1801 Don't lose top specpdl entry when memory is exhausted.
1802 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
1803 specpdl overflow here, to simplify callers; all callers changed.
1804 Always reserve an unused entry at the stack top; this avoids
1805 losing the top entry's information when memory is exhausted.
1806
7e649856
PE
18072013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1808
a773ed9a
PE
1809 Clean up errno reporting and fix some errno-reporting bugs.
1810 * callproc.c (Fcall_process):
1811 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1812 * process.c (create_process, Fmake_network_process):
1813 * unexaix.c (report_error):
1814 * unexcoff.c (report_error):
1815 Be more careful about reporting the errno of failed operations.
1816 The code previously reported the wrong errno sometimes.
1817 Also, prefer report_file_errno to setting errno + report_file_error.
1818 (Fcall_process): Look at openp return value rather than at path,
1819 as that's a bit faster and clearer when there's a numeric predicate.
1820 * fileio.c (report_file_errno): New function, with most of the
1821 old contents of report_file_error.
1822 (report_file_error): Use it.
1823 (Ffile_exists_p, Ffile_accessible_directory_p):
1824 Set errno to 0 when it is junk.
1825 * fileio.c (Faccess_file):
1826 * image.c (x_create_bitmap_from_file):
1827 Use faccessat rather than opening the file, to avoid the hassle of
1828 having a file descriptor open.
1829 * lisp.h (report_file_errno): New decl.
1830 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
1831
7e649856
PE
1832 Minor EBADF fixes.
1833 * process.c (create_process, wait_reading_process_output) [AIX]:
1834 Remove obsolete SIGHUP-related code, as Emacs no longer disables
1835 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
1836 a multithreaded environment anyway).
1837 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
1838
f6774c1a
AS
18392013-07-12 Andreas Schwab <schwab@linux-m68k.org>
1840
1841 * image.c (x_find_image_file): Don't close a remote file handle.
1842
bacba3c2
PE
18432013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1844
1845 Fix races with threads and file descriptors.
1846 * callproc.c (Fcall_process_region):
1847 * dired.c (open_directory):
1848 * emacs.c (main, Fdaemon_initialized):
1849 * image.c (x_find_image_file):
1850 * inotify.c (Finotify_rm_watch):
1851 * lread.c (Flocate_file_internal):
1852 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
1853 * term.c (term_mouse_moveto, init_tty):
1854 * termcap.c (tgetent):
1855 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
1856 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
1857 * unexhp9k800.c, unexmacosx.c (unexec):
1858 * callproc.c (Fcall_process_region):
1859 Use emacs_close, not close.
1860 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
1861 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
1862 and posix_close function on current platforms (which all lack them).
1863 (emacs_close): Use it. This should fix the races on GNU/Linux and
1864 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
1865 and it should avoid closing random victim file descriptors on
1866 other platforms.
1867
653d4f43
PE
18682013-07-11 Paul Eggert <eggert@cs.ucla.edu>
1869
c8536ec4
PE
1870 * inotify.c (uninitialized): Remove. All uses replaced by -1.
1871 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
1872 Touch up doc a bit.
1873
9c203066
PE
1874 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
1875 This is for .gdbinit xbacktrace.
1876
653d4f43
PE
1877 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
1878 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
1879 (emacs_set_tty): Now static.
1880 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
1881 * term.c (tty_capable_p, tty_default_color_capabilities)
1882 (get_tty_terminal, term_mouse_movement)
1883 (handle_one_term_event, init_tty, maybe_fatal):
1884 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
1885 (tgetent, scan_file, name_match, compare_contin):
1886 * terminal.c (get_terminal):
1887 Use bool for boolean.
1888 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
1889 Prefer char to unsigned char if either will do.
1890 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
1891 (tty_write_glyphs): Prefer int to unsigned.
1892 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
1893 All callers changed.
1894 * termcap.c (tprint, main) [TEST]: Remove non-working test.
1895
45b683a1
PE
18962013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1897
29abe551
PE
1898 Port to C89.
1899 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
1900 (B__dummy__): New dummy symbol, to pacify C89.
1901 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
1902 they can't grok varargs macros.
1903 * dispnew.c (add_window_display_history)
1904 (add_frame_display_history):
1905 * print.c (print_object):
1906 * xdisp.c (debug_method_add):
1907 Use %p printf format only for void pointers.
1908 * emacs.c (usage_message): New constant, replacing ...
1909 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
1910 (main): Adjust to usage reorg.
1911 * fns.c (syms_of_fns):
1912 * profiler.c (syms_of_profiler):
1913 Don't use non-constant struct initializers.
1914 * gnutls.h (gnutls_initstage_t):
1915 * lisp.h (enum Lisp_Fwd_Type):
1916 * lread.c (lisp_file_lexically_bound_p):
1917 * xsettings.c (anonymous enum):
1918 Remove trailing comma.
1919 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
1920 * lisp.h (ENUM_BF): Use unsigned if pedantic.
1921 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
1922 (DEFUN): Use it.
1923 * regex.c (const_re_char): New type, to pacify strict C89.
1924 All uses of 'const re_char' replaced to use it.
1925 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
1926 with glibc when strict C89. This change is imported from gnulib.
1927 All uses changed.
1928 (_Restrict_arr_): Rename from __restrict_arr, similarly.
1929 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
1930 Omit GNU_LINUX implementation, since it requires long long.
1931 * xterm.c (x_draw_underwave):
1932 Do not assume the traditional order of struct's members.
1933 (x_term_init): Rewrite to avoid the need for non-constant structure
1934 initializers.
1935
45b683a1 1936 Syntax cleanup, mostly replacing macros with functions.
763a086d 1937 This removes the need for the syntax_temp hack.
45b683a1
PE
1938 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
1939 * syntax.c (SYNTAX_INLINE): New macro.
1940 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
1941 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
1942 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
1943 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
1944 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
1945 (SYNTAX_COMEND_FIRST): Now functions, not macros.
1946 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
1947 Now constants, not macros.
1948 (syntax_temp) [!__GNUC__]: Remove.
1949 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
1950 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
1951 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
1952 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
1953 Move here from syntax.h; now functions, not macros. Except for the
1954 last function, these are static since only syntax.c uses them.
1955 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
1956 All uses changed. Now a function, not a macro; use this fact
1957 to simplify the code.
1958 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
1959 compiler bugs; no longer relevant.
1960 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1961 (SYNTAX_INLINE): New macro.
1962 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
1963 for the new functions. Use bool for boolean member.
1964 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
1965 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
1966 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
1967 (SETUP_BUFFER_SYNTAX_TABLE):
1968 Now extern inline functions, not macros.
1969 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
1970 Remove; all uses replaced by implementation.
1971 (syntax_temp) [!__GNUC__]: Remove decl.
1972 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
1973
29be4a50
JD
19742013-07-10 Jan Djärv <jan.h.d@swipnet.se>
1975
1976 * emacs.c (main): Fix syntax error.
1977
954b166e
PE
19782013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1979
1980 Timestamp fixes for undo (Bug#14824).
1981 * atimer.c (schedule_atimer):
1982 * fileio.c (Ffile_newer_than_file_p):
1983 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
1984 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
1985 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
1986 (syms_of_fileio): Remove Sclear_visited_file_name.
1987 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
1988 file doesn't exist; this avoids an ambiguity with negative timestamps.
1989 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
1990 * systime.h (make_emacs_time, invalid_emacs_time):
1991 Don't assume struct timespec layout; POSIX doesn't guarantee it.
1992 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
1993 * undo.c (record_first_change): Push (visited-file-modtime) onto
1994 undo list rather than reimplementing it by hand, incorrectly.
1995
d74647c3
KB
19962013-07-09 Ken Brown <kbrown@cornell.edu>
1997
1998 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
1999
3c51b96b
JB
20002013-07-09 Juanma Barranquero <lekktu@gmail.com>
2001
2002 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
2003
4ebbdd67
PE
20042013-07-09 Paul Eggert <eggert@cs.ucla.edu>
2005
2006 Handle errno and exit status a bit more carefully.
2007 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
2008 number into an exit status. Instead, use EXIT_CANCELED.
2009 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
2010 * callproc.c (relocate_fd):
2011 * emacs.c (close_output_streams, main):
2012 * process.c (create_process):
2013 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
2014 Use emacs_perror for simplicity.
2015 * callproc.c (relocate_fd, main):
2016 * sysdep.c (sys_subshell):
2017 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
2018 (shut_down_emacs): Use emacs_write, not write.
2019 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
2020 * fileio.c (Fcopy_file, e_write):
2021 * nsterm.m (ns_select):
2022 * process.c (send_process):
2023 * sound.c (vox_write):
2024 Use emacs_write_sig, not emacs_write.
2025 * lisp.h (emacs_write_sig, emacs_perror): New decls.
2026 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
2027 New constants.
2028 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
2029 of write.
2030 (emacs_full_write): New function.
2031 (emacs_write): Rewrite to use it.
2032 (emacswrite_sig, emacs_perror): New functions.
2033 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
2034
44e18199 20352013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
e4b1e5af
JD
2036
2037 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
2038 on NS even if it is present. Pixmap on NS is a void*.
2039
9caab067
PE
20402013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2041
2042 Port to Ubuntu 10 (Bug#14803).
2043 Problem reported by T.V. Raman.
2044 * process.c (close_on_exec, accept4, process_socket):
2045 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
2046
1d442672
EZ
20472013-07-07 Eli Zaretskii <eliz@gnu.org>
2048
2049 * w32.c (sys_dup): Declare prototype.
2050
2051 * filelock.c:
2052 * emacs.c:
2053 * callproc.c [WINDOWSNT]: Include sys/socket.h.
2054
067428c1
PE
20552013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2056
2057 Make file descriptors close-on-exec when possible (Bug#14803).
2058 This simplifies Emacs a bit, since it no longer needs to worry
2059 about closing file descriptors by hand in some cases.
2060 It also fixes some unlikely races. Not all such races, as
2061 libraries often open files internally without setting
2062 close-on-exec, but it's an improvement.
2063 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
2064 * callproc.c (Fcall_process) [!MSDOS]:
2065 * emacs.c (main) [!DOS_NT]:
2066 * nsterm.m (ns_term_init):
2067 * process.c (create_process):
2068 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
2069 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
2070 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
2071 Prefer mkostemp with O_CLOEXEC to mkstemp.
2072 * callproc.c (relocate_fd) [!WINDOWSNT]:
2073 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
2074 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
2075 now using pipe2.
2076 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
2077 Make the resulting file descriptor close-on-exec.
2078 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
2079 * lread.c (load_descriptor_list, load_descriptor_unwind):
2080 Remove; no longer needed. All uses removed.
2081 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
2082 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
2083 New functions.
2084 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
2085 (Fmake_network_process, Fnetwork_interface_list):
2086 (Fnetwork_interface_info, server_accept_connection):
2087 Make newly-created socket close-on-exec.
2088 * sysdep.c (emacs_open, emacs_fopen):
2089 Make new-created descriptor close-on-exec.
2090 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
2091 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
2092
0da857dd
JD
20932013-07-07 Jan Djärv <jan.h.d@swipnet.se>
2094
2095 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
2096 for NS_IMPL_GNUSTEP.
2097
5f86adcd
PE
20982013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2099
2100 Fix openp errno handling.
2101 * callproc.c (Fcall_process): Preserve openp errno around close.
2102 * lread.c (openp): Set errno when returning -1, as some callers
2103 expect this.
2104
1afb1d07
JD
21052013-07-06 Jan Djärv <jan.h.d@swipnet.se>
2106
2107 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
2108
2109 * nsterm.h (NSSavePanel): Update comment.
2110 (NSAPP_DATA2_RUNFILEDIALOG): Define.
2111 (ns_run_file_dialog): Declare.
2112
2113 * nsfns.m: Remove panelOK.
2114 (ns_fd_data): New.
2115 (ns_run_file_dialog): New function.
2116 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
2117 event loop, so file dialog is popped up by ns_run_file_dialog, called
2118 by sendEvent (Bug#14578).
2119 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
2120
3323c263
EZ
21212013-07-06 Eli Zaretskii <eliz@gnu.org>
2122
fdda0220
EZ
2123 * xdisp.c (default_line_pixel_height): New function.
2124 (pos_visible_p, move_it_vertically_backward, try_scrolling)
2125 (try_cursor_movement, redisplay_window, try_window)
2126 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
2127
2128 * window.c (window_scroll_pixel_based): use
2129 default_line_pixel_height.
2130
2131 * dispextern.h (default_line_pixel_height): Add prototype.
2132
2133 * frame.c (x_set_line_spacing): Accept a float value for
2134 line-spacing parameter, per the documentation.
2135
3323c263
EZ
2136 * data.c (Fmultibyte_string_p): Doc fix.
2137
47ba6d43
PE
21382013-07-05 Paul Eggert <eggert@cs.ucla.edu>
2139
406af475
PE
2140 Use emacs_open more consistently when opening files.
2141 This handles EINTR more consistently now, and makes it easier
2142 to introduce other uniform changes to file descriptor handling.
2143 * src/systdio.h: New file.
2144 * src/buffer.c (mmap_init):
2145 * cygw32.c (chdir_to_default_directory):
2146 * dispnew.c (Fopen_termscript):
2147 * emacs.c (Fdaemon_initialized):
2148 * fileio.c (Fdo_auto_save):
2149 * image.c (slurp_file, png_load_body, jpeg_load_body):
2150 * keyboard.c (Fopen_dribble_file):
2151 * lread.c (Fload):
2152 * print.c (Fredirect_debugging_output):
2153 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
2154 * termcap.c (tgetent):
2155 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
2156 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
2157 * w32term.c (w32_initialize) [CYGWIN]:
2158 * xfaces.c (Fx_load_color_file):
2159 Use emacs_open instead of plain open, and emacs_fopen instead of
2160 plain fopen.
2161 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
2162 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
2163 * callproc.c (default_output_mode): New constant.
2164 (Fcall_process): Use it to call emacs_open instead of plain creat.
2165 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
2166 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
2167 (emacs_fopen): New function.
2168 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
2169 Include <lisp.h>, for emacs_open.
2170 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
2171
47ba6d43
PE
2172 Remove duplicate #include directives.
2173 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
2174 * xfaces.c:
2175 Don't include stdio.h twice.
2176 * buffer.c [USE_MMAP_FOR_BUFFERS]:
2177 Don't include sys/types.h or stdio.h twice.
2178 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
2179 * lread.c: Don't include coding.h twice.
2180 * nsfont.m: Don't include frame.h twice.
2181 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
2182 * ralloc.c: Don't include <unistd.h> twice.
2183 * xdisp.c: Don't include font.h twice.
2184 * xterm.c: Don't include fontset.h twice.
2185 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
2186
b9ed53d5
PE
21872013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2188
2189 Scale ImageMagick images more carefully.
2190 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
2191 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
2192 Be more careful about avoiding undefined behavior after
2193 integer overflow and division by zero.
2194
cf13177e
YM
21952013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2196
2197 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
2198 (syms_of_w32fns): DEFSYM them.
2199 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
2200 (CCHDEVICENAME): Define macros if not defined.
2201 (struct MONITOR_INFO_EX): New struct.
2202 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
2203 (enum_display_monitors_fn): New variable.
2204 (globals_of_w32fns): Initialize it.
2205 (Fx_display_pixel_width, Fx_display_pixel_height)
2206 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
2207 multi-monitor setups in docstrings.
2208 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
2209 screen size by primary monitor's millimeter per pixel.
2210 (w32_monitor_enum, w32_display_monitor_attributes_list)
2211 (w32_display_monitor_attributes_list_fallback)
2212 (Fw32_display_monitor_attributes_list): New functions.
2213 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
2214
2215 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
2216 if not defined.
2217 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
2218
86dfb7a8
MA
22192013-07-04 Michael Albinus <michael.albinus@gmx.de>
2220
2221 * fileio.c (Qfile_notify_error): New error symbol.
2222
2223 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
2224 * inotify.c (inotify_callback, symbol_to_inotifymask)
2225 (Finotify_add_watch, Finotify_rm_watch): Use it.
2226 (inotifyevent_to_event): Exchange order of cookie and file name.
2227 (Finotify_add_watch): Adapt docstring.
2228
2229 * lisp.h (Qfile_notify_error): Declare.
2230
2c1c974b
PE
22312013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2232
2233 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
2234 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2235 Do not clear _malloc_thread_enabled_p, undoing the previous change,
2236 which did not work (see <http://bugs.gnu.org/14569#307>).
2237 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
2238 && (!noninteractive || initialized)). This attempts to thread
2239 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
2240
7a35b20f
JB
22412013-07-04 Juanma Barranquero <lekktu@gmail.com>
2242
2243 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
2244 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
2245
1ce5cd04
PE
22462013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2247
2248 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
2249 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2250 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
2251 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
2252
57f8c490
PE
22532013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2254
2255 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
2256 Define to __sys_siglist.
2257
bcffb5ca
EZ
22582013-07-02 Eli Zaretskii <eliz@gnu.org>
2259
2260 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
2261 word-wrap, so that overflow-newline-into-fringe would work in
2262 visual-line-mode. (Bug#2749)
2263 (move_it_in_display_line_to): When the last scanned display
2264 element fits exactly on the display line, and
2265 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
2266 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
2267 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
2268 finding buffer position that corresponds to pixel coordinates,
2269 e.g. in buffer_posn_from_coords.
2270
2c41e781
JD
22712013-07-02 Jan Djärv <jan.h.d@swipnet.se>
2272
2273 * process.c (handle_child_signal): Call catch_child_signal if
2274 NS_IMPL_GNUSTEP.
2275
c2418359
PE
22762013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2277
52a9bcae
PE
2278 Don't convert function pointers to void * and back.
2279 It isn't portable C, and it's easy enough to avoid.
2280 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
2281 (make_save_value): Add support for SAVE_FUNCPOINTER.
2282 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
2283 * print.c (print_object):
2284 Distinguish function from object pointers.
2285 * lisp.h (SAVE_FUNCPOINTER): New constant.
2286 (SAVE_SLOT_BITS): Adjust to it.
2287 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
2288 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
2289 (voidfuncptr): New typedef.
2290 (struct Lisp_Save_Value): New member data[0].funcpointer.
2291 (XSAVE_FUNCPOINTER): New function.
2292
c2418359
PE
2293 Simplify buildobj processing.
2294 * Makefile.in (buildobj.h): Make it a sequence of strings each
2295 followed by comma, rather than a single string. Put it into a
2296 .tmp file in case there's an error while generating it.
2297 (gl-stamp): Use .tmp for temp files.
2298 (mostlyclean): Clean .tmp files.
2299 * doc.c (buildobj): Move to just the routine that needs it.
2300 It's now an array of strings, so processing is simpler.
2301
8f43ce49
PE
23022013-07-01 Paul Eggert <eggert@cs.ucla.edu>
2303
2304 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
2305 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
2306 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2307 Invoke malloc_enable_thread even when not interactive.
2308 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
2309 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
2310 in this case, since the underlying bug has now been fixed.
2311
24827db9
JB
23122013-07-01 Juanma Barranquero <lekktu@gmail.com>
2313
2314 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
2315 unlinking it (bug#14691).
2316
ef099a94
MN
23172013-06-30 Michal Nazarewicz <mina86@mina86.com>
2318
2319 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
2320 before checking whether buffer is modified. This lets
2321 `kill-buffer-query-functions' cancel killing of the buffer or save
2322 its content before `kill-buffer' asks user the "Buffer %s
2323 modified; kill anyway?" question.
2324
9d3f2fc2
JD
23252013-06-30 Jan Djärv <jan.h.d@swipnet.se>
2326
2327 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
2328 Let the super performKeyEquivalent deal with them (Bug#14747).
2329
e6c6c8c7
PE
23302013-06-30 Paul Eggert <eggert@cs.ucla.edu>
2331
1d71c1d9
PE
2332 * widget.c (resize_cb): Remove unused local.
2333
8f5f35cc
PE
2334 Do not use GTK 3 if it exists but cannot be compiled.
2335 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
2336 * xterm.c (x_error_handler) [!USE_GTK]:
2337 Do not use GTK 3.
2338
e6c6c8c7
PE
2339 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
2340
0ba54312
EZ
23412013-06-30 Eli Zaretskii <eliz@gnu.org>
2342
5d1c3286
EZ
2343 * intervals.c (get_local_map): Instead of aborting, clip POSITION
2344 to the valid range of values. (Bug#14753)
2345
0ba54312
EZ
2346 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
2347 when moving point by using the current glyph matrix. This avoids
2348 the need to force redisplay when this function is called in a
2349 loop.
2350
9c90cc06
PE
23512013-06-29 Paul Eggert <eggert@cs.ucla.edu>
2352
2353 Fix minor problems found by static checking.
2354 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
2355 Redo the latter's body to sidestep GCC parenthesization warnings.
2356 (setup_coding_system, detect_coding, detect_coding_system): Use them.
2357 * coding.c (detect_coding, detect_coding_system):
2358 * coding.h (struct undecided_spec):
2359 Use bool for boolean.
2360 * image.c (QCmax_width, QCmax_height): Now static.
2361 * xdisp.c (Fmove_point_visually): Remove unused local.
2362
4c672a0f
EZ
23632013-06-29 Eli Zaretskii <eliz@gnu.org>
2364
2365 * xdisp.c (Fmove_point_visually): New function.
2366
c1ea3abf
JB
23672013-06-28 Kenichi Handa <handa@gnu.org>
2368
2369 * coding.h (define_coding_undecided_arg_index): New enum.
2370 (coding_attr_index): New members
2371 coding_attr_undecided_inhibit_null_byte_detection,
2372 coding_attr_undecided_inhibit_iso_escape_detection,
2373 coding_attr_undecided_prefer_utf_8.
2374 (undecided_spec): New struct.
2375 (struct coding_system): New member `undecided' of the member
2376 `spec'.
2377
2378 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
2379 (detect_coding): Likewise.
2380 (detect_coding_system): Likewise.
2381 (Fdefine_coding_system_internal): New coding system properties
2382 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
2383 :prefer-utf-8.
2384 (syms_of_coding): Adjust for coding_arg_undecided_max.
2385
ba3de9e6
PE
23862013-06-28 Paul Eggert <eggert@cs.ucla.edu>
2387
2388 * image.c (x_from_xcolors): Remove unused local.
2389
547c9269
YM
23902013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2391
2392 Defer image data transfer between X client and server until actual
2393 display happens.
2394
2395 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
2396 and `mask_img'.
2397
2398 * image.c (Destroy_Image): Remove.
2399 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
2400 `mask_p', and `colors_p'. All uses changed.
2401 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
ef099a94
MN
2402 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
2403 New macros for `flags' arg to x_clear_image_1.
547c9269
YM
2404 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
2405 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
04b66ce7 2406 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
547c9269
YM
2407 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
2408 (image_get_x_image, image_unget_x_image): New functions or macros.
2409 (image_background, image_background_transparent, x_to_xcolors)
2410 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
2411 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
2412 instead of Destroy_Image.
2413 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
2414 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
2415 (png_load_body, jpeg_load_body, tiff_load, gif_load)
2416 (imagemagick_load_image, svg_load_image): Use them instead of
2417 x_create_x_image_and_pixmap, and x_put_x_image followed by
2418 x_destroy_x_image, respectively.
2419 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
2420 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
2421 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
2422 background_transparent fields.
2423 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
2424 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
2425
dae2f5ef
PE
24262013-06-27 Paul Eggert <eggert@cs.ucla.edu>
2427
2428 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
2429 This mostly consists of undoing recent changes.
2430 * callproc.c (Fcall_process):
2431 * process.c (create_process):
2432 Do not worry about catching SIGCHLD here, undoing previous change.
2433 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
2434 * process.c, process.h (catch_child_signal):
2435 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
2436 * process.c (catch_child_handler): Don't worry about being called
2437 lazily and do not assume caller has blocked SIGCHLD, undoing
2438 previous change. Move first-time stuff back to
2439 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
2440 tickle glib, as that causes Cygwin bootstrap to fail. Do not
2441 set lib_child_handler if it's already initialized, which may
2442 help avoid problems on GNUStep.
2443
fa55d2aa
PE
24442013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2445
2446 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
2447 * callproc.c (Fcall_process):
2448 * process.c (create_process):
2449 Make sure SIGCHLD is caught before we fork,
2450 since Emacs startup no arranges to catch SIGCHLD.
2451 * process.c (lib_child_handler): Initialize to null, not to
2452 dummy_handler.
2453 (catch_child_signal): Allow self to be called lazily.
2454 Do nothing if it's already been called.
2455 Assume caller has blocked SIGCHLD (all callers do now).
2456 * emacs.c (main): Do not catch SIGCHLD here; defer it until
2457 just before it's really needed.
2458 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
2459 since it hasn't been caught yet.
2460
f3f9606c
LMI
24612013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
2462
2463 * image.c (compute_image_size): New function to implement
2464 :max-width and :max-height.
2465 (imagemagick_load_image): Use it.
2466
c7041908
PE
24672013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2468
2469 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
2470 * callproc.c, process.h (block_child_signal, unblock_child_signal):
2471 Now extern.
2472 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
2473 * process.c (catch_child_signal): Block SIGCHLD while futzing with
2474 the SIGCHLD handler, since the code is not atomic and (due to glib)
2475 signals may be arriving now.
2476 * sysdep.c (init_signals): Do not catch child signals here;
2477 'main' now does that later, at a safer time.
2478
f86852b4
PE
24792013-06-22 Paul Eggert <eggert@cs.ucla.edu>
2480
0dfeed58
PE
2481 Clean up SIGCHLD handling a bit (Bug#14569).
2482 * process.c, process.h (catch_child_signal):
2483 Now always extern, even if !NS_IMPL_GNUSTEP.
2484 * process.c (catch_child_signal): Move glib tickler here from
2485 init_process_emacs, so that it's done earlier in Emacs
2486 initialization. Also move the noninteractive && !initialized
2487 check here from init_process_emacs. This is all a bit cleaner for
2488 GNUish platforms, and I hope it works around the Cygwin bug.
2489 * sysdep.c (init_signals): Invoke catch_child_signal here, so
2490 that glib signal handling is tickled before glib creates threads.
2491
f86852b4
PE
2492 * process.c (wait_reading_process_output): Avoid int overflow
2493 when reading more than 2 GiB total from a process.
2494
cbd6509c
PE
24952013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2496
2497 * process.c (create_process): Handle a couple more cases,
2498 i.e., work even if new_argv and wait_child_setup[i] are cached.
2499 Use Fcall_process's style for volatile vars.
2500
9de1114a
AS
25012013-06-21 Andreas Schwab <schwab@linux-m68k.org>
2502
2503 * process.c (create_process): Mark PROCESS volatile.
2504
fbe9e0b9
PE
25052013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2506
2507 Use C99-style flexible array members if available.
2508 This avoids some subtle aliasing issues, which typically
2509 aren't a problem with GCC but may be a problem elsewhere.
2510 * alloc.c (sdata): New typedef, replacing the old struct sdata.
2511 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
2512 In either case, it uses a flexible array member rather than
2513 the old struct hack. All uses changed.
2514 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
2515 Adjust to sdata reorganization.
2516 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
2517 Use offsetof (struct, flex_array_member), not sizeof (struct), as
2518 that ports better to pre-C99 non-GCC.
2519 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
2520 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
2521 as the latter has changed.
2522 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
2523 and port better to pre-C99 GCC.
2524 * image.c (struct xpm_cached_color):
2525 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
2526 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
2527 Use FLEXIBLE_ARRAY_MEMBER.
2528 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
2529 Move decl to top level so it gets checked against implementation.
2530 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
2531 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
2532
1fc71008
PE
25332013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2534
2535 * syntax.c: Integer cleanups.
2536 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
2537 All uses that need 0-or-2 changed to:
2538 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
2539 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
2540 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
2541 (char_quoted, prev_char_comend_first, back_comment)
2542 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2543 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
2544 Use bool for boolean.
2545 (update_syntax_table, skip_chars, skip_syntaxes):
2546 Prefer int to unsigned when either will do.
2547 (back_comment): Return boolean success flag, like forw_comment,
2548 instead of positive-or-minus-1 (which might have overflowed int anyway).
2549 Don't stuff ptrdiff_t into int.
2550 (syntax_spec_code, syntax_code_spec): Now const.
2551 (Fmatching_paren, scan_lists, scan_sexps_forward):
2552 Use enum syntaxcode for syntax code.
2553 (Fmatching_paren): Check that arg is a character, not just an integer.
2554 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
2555 (Finternal_describe_syntax_value): Omit no-longer-needed
2556 comparison to 0.
2557 (skip_chars): Use char, not unsigned char, when the distinction
2558 doesn't matter.
2559 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
2560 * bytecode.c (exec_byte_code):
2561 * syntax.c (syntax_spec_code, Fchar_syntax)
2562 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2563 (init_syntax_once):
2564 * syntax.h (SYNTAX_WITH_FLAGS):
2565 Omit unnecessary casts.
2566
b932cad7
EZ
25672013-06-20 Eli Zaretskii <eliz@gnu.org>
2568
2569 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
2570 line dimensions here, to avoid race conditions with the main
2571 thread. (Bug#14062, bug#14630, bug#14669)
2572
2573 * w32term.c (w32_draw_window_cursor): Compute the header line and
2574 mode line dimensions here.
2575 <w32_system_caret_window, w32_system_caret_hdr_height>:
2576 <w32_system_caret_mode_height>: New variables.
2577
2578 * w32term.h: Declare them.
2579
89561f72
PE
25802013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2581
5013fc08
PE
2582 * alloc.c (die): Move "assertion failed" string here ...
2583 * lisp.h (eassert): ... from here. Also, suppress evaluation of
2584 COND when SUPPRESS_CHECKING. This shrinks the executable text
2585 size by 0.8% to 2.2% when configured with --enable-checking,
2586 depending on optimization flags (GCC 4.8.1 x86-64).
2587
89561f72
PE
2588 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
2589
763a086d 25902013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
89561f72
PE
2591
2592 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
2593 base is 2; this is more accurate.
2594
983aeb9a
JB
25952013-06-19 Juanma Barranquero <lekktu@gmail.com>
2596
2597 * sound.c (string_default): Move to !WINDOWSNT section.
2598 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
2599
178ba3e6
PE
26002013-06-19 Paul Eggert <eggert@cs.ucla.edu>
2601
bbc51b15
PE
2602 * sound.c: Integer cleanups.
2603 Remove unnecessary forward decls.
2604 (struct sound_device): The 'file' member is now a Lisp_Object, not
2605 a char *, so that we needn't invoke alloca on a huge size.
2606 (Fplay_sound_internal): Adjust to this.
2607 (string_default): New function.
2608 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
2609 Use it to adjust to the struct sound_device change.
2610 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
2611 (be2hs) [0]: Remove.
2612
178ba3e6
PE
2613 * syntax.c (skip_chars): Don't use uninitialized storage
2614 when searching a multibyte buffer for characters that are not in a
2615 unibyte string that contains non-ASCII characters.
2616
69f60cdc
JD
26172013-06-18 Jan Djärv <jan.h.d@swipnet.se>
2618
2619 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
2620 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
2621
0d6224d4
PE
26222013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2623
2624 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
2625
3c542890
KH
26262013-06-18 Kenichi Handa <handa@gnu.org>
2627
f7e3f7cd
KH
2628 * font.c (Ffont_spec): Signal an error for an invalid font name
2629 (Bug#14648).
3c542890 2630
9349e5f7
PE
26312013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2632
2633 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
2634 In particular this ports to 32-bit sparc Sun cc.
2635 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
2636 array with a dummy element at specpdl[-1], so that its address can
2637 be taken portably.
2638 (unbind_to): Do not copy the binding; not needed, now that we
2639 copy old_value in the one place where the copy is needed.
2640 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
2641 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
2642 (union specbinding): Rename from struct specbinding. Redo layout
2643 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
2644 which is not portable. With Sun C 5.12 32-bit sparc, the
2645 declaration causes nargs to be an unsigned bitfield, a behavior
2646 that the C standard allows; but Emacs wants nargs to be signed.
2647 The overall type is now a union of structures rather than a
2648 structure of union of structures, and the 'kind' member is now a
2649 bitfield, so that the overall type doesn't grow. All uses changed.
2650 * process.c (Fmake_serial_process): Remove unnecessary initialization.
2651
0a4df6a5
PE
26522013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2653
ec6ecaad
PE
2654 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
2655 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
2656
0a4df6a5
PE
2657 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
2658
7bfe8dbc
EZ
26592013-06-17 Eli Zaretskii <eliz@gnu.org>
2660
2661 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
2662 unless we know that the window w's frame is a frame object.
2663 Another attempt at solving bug#14062 and bug#14630.
2664
708e05f6
LMI
26652013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
2666
2667 * textprop.c (property_set_type): New enum.
2668 (add_properties): Allow appending/prepending text properties.
2669 (add_text_properties_1): Factored out of Fadd_text_properties.
ef099a94 2670 (Fadd_text_properties): Move all the code into
708e05f6
LMI
2671 add_text_properties_1.
2672 (Fadd_face_text_property): New function that calls
2673 add_text_properties_1.
2674
84575e67
PE
26752013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2676
2677 Move functions from lisp.h to individual modules when possible.
2678 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
2679 * alloc.c (XFLOAT_INIT, set_symbol_name):
2680 * buffer.c (CHECK_OVERLAY):
2681 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
2682 (set_char_table_parent):
2683 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
2684 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
2685 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
2686 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
2687 (set_blv_valcell):
2688 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
2689 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
2690 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
2691 (backtrace_args, backtrace_debug_on_exit):
2692 * floatfns.c (CHECK_FLOAT):
2693 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
2694 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
2695 (set_hash_hash, set_hash_hash_slot, set_hash_index)
2696 (set_hash_index_slot):
2697 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
2698 * marker.c (CHECK_MARKER):
2699 * textprop.c (CHECK_STRING_OR_BUFFER):
2700 * window.c (CHECK_WINDOW_CONFIGURATION):
2701 Move here from lisp.h, and make these functions static rather than
2702 extern inline.
2703 * buffer.c (Qoverlayp):
2704 * data.c (Qsubrp):
2705 * fns.c (Qhash_table_p):
2706 * window.c (Qwindow_configuration_p):
2707 Now static.
2708 * lisp.h: Remove the abovementioned defns and decls.
2709
44e18199 2710 Use functions, not macros, for XINT etc (Bug#11935).
84575e67
PE
2711 In lisp.h, prefer functions to function-like macros, and
2712 constants to object-like macros, when either will do. This:
2713 . simplifies use, as there's no more need to worry about
2714 arguments' side effects being evaluated multiple times.
2715 . makes the code easier to debug on some platforms.
2716 However, when using gcc -O0, keep using function-like macros
2717 for a few critical operations, for performance reasons.
2718 This sort of thing isn't needed with gcc -Og, but -Og
2719 is a GCC 4.8 feature and isn't widely-enough available yet.
2720 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
2721 Remove enum lsb_bits; no longer needed.
2722 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
2723 * buffer.c (Qoverlap):
2724 * data.c (Qsubrp):
2725 * fns.c (Qhash_table_p):
2726 Now extern, so lisp.h can use these symbols.
2727 * dispextern.h: Include character.h, for MAX_CHAR etc.
2728 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2729 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2730 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2731 (GLYPH_CODE_P): Move here from lisp.h.
2732 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2733 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
2734 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
2735 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
2736 XUNTAG now returns void *.
2737 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
2738 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
2739 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
2740 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
2741 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
2742 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
2743 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
2744 (lisp_h_XPNTR, lisp_h_XSYMBOL):
2745 New macros, renamed from their sans-lisp_h_ counterparts.
2746 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
2747 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
2748 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
2749 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
2750 If compiling via GCC without optimization, define these as macros
2751 in addition to inline functions.
2752 To disable this, compile with -DINLINING=0.
2753 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
2754 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
2755 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
2756 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
2757 (INTMASK, VALMASK): Now macros, since static values cannot be
2758 accessed from extern inline functions.
2759 (VALMASK): Also a constant, for benefit of old GDB.
2760 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
2761 is INTEGERP, which can fold it in.
5165d44a 2762 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
84575e67
PE
2763 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
2764 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
2765 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
2766 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
2767 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
2768 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
2769 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
2770 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
2771 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
2772 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
2773 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
2774 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
2775 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
2776 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
2777 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
2778 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
2779 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
2780 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
2781 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
2782 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
2783 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
2784 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
2785 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
2786 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
2787 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
2788 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
2789 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
2790 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
2791 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
2792 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
2793 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
2794 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
2795 Now functions.
2796 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
2797 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
2798 (VALMASK): Define in one place rather than in two, merging the
2799 USE_LSB_TAG parts; this is simpler.
2800 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
2801 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
2802 Move up, to avoid use before definition.
2803 Also include "globals.h" earlier, for the same reason.
2804 (make_natnum): New function.
2805 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
2806 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
2807 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
2808 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
2809 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
2810 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
2811 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
2812 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
2813 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
2814 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
2815 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
2816 (Qwindow_configuration_p, Qimage): New forward declarations.
2817 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
2818 (STRING_COPYIN): Remove; unused.
2819 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
2820 (xcar_addr, xcdr_addr): New functions. All uses changed.
2821 (IEEE_FLOATING_POINT): Now a constant, not a macro.
2822 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2823 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2824 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2825 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
2826 (TYPE_RANGED_INTEGERP): Simplify.
2827 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
2828 (setlocale, fixup_locale, synchronize_system_messages_locale)
2829 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
2830 Now empty functions, not macros.
2831 (functionp): Return bool, not int.
2832 * window.c (Qwindow_configuration_p): Now extern,
2833 so window.h can use it.
2834 * window.h (Qwindowp): Move decl back to lisp.h.
2835
9583ec36
EZ
28362013-06-15 Eli Zaretskii <eliz@gnu.org>
2837
2838 * xdisp.c (Fline_pixel_height): New function, required for solving
2839 bug #14567.
2840
210272ce
PE
28412013-06-15 Paul Eggert <eggert@cs.ucla.edu>
2842
2843 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
2844
de0503df
SM
28452013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
2846
2847 * lread.c (syms_of_lread):
2848 * fns.c (Fprovide): Adjust to new format of after-load-alist.
2849
afbfe143
KD
28502013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
2851
2852 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
2853
d177e213
XF
28542013-06-12 Xue Fuqiao <xfq.free@gmail.com>
2855
2856 * fileio.c (expand_file_name): Doc fix.
2857
05e3e412
PE
28582013-06-11 Paul Eggert <eggert@cs.ucla.edu>
2859
f7394b12
PE
2860 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
2861 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
2862 Wait for self, not for 0. This can't hurt on GNU or similar
2863 system, and may help with Cygwin.
2864
05e3e412
PE
2865 * keyboard.c: Don't use PROP (...) as an lvalue.
2866 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
2867 Use set_prop (A, B), not PROP (A) = B.
2868
17dd3097
EZ
28692013-06-10 Eli Zaretskii <eliz@gnu.org>
2870
2871 * xdisp.c (get_it_property): Use it->window instead of generating
2872 a Lisp object from it->w.
2873
52fab9c9
EZ
28742013-06-09 Eli Zaretskii <eliz@gnu.org>
2875
2876 * xdisp.c (get_it_property): If it->object is a buffer, pass to
2877 get-char-property the window that is being rendered, instead of
2878 the buffer, to support window-specific overlays. (Bug#14575)
ad257d4f
EZ
2879 (compute_display_string_pos): When W is NULL, use the current
2880 buffer as the object to pass to get-char-property.
2881 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
2882 pointer member of the bidi iterator, since no window is pertinent
2883 to this function.
52fab9c9 2884
5bf97bfc
EZ
28852013-06-08 Eli Zaretskii <eliz@gnu.org>
2886
2887 * bidi.c (bidi_fetch_char): Accept additional argument, the window
2888 being displayed, and pass it to compute_display_string_pos.
2889 (bidi_level_of_next_char, bidi_resolve_explicit_1)
2890 (bidi_paragraph_init): All callers changed.
2891
2892 * xdisp.c (init_from_display_pos, init_iterator)
2893 (handle_single_display_spec, next_overlay_string)
2894 (get_overlay_strings_1, reseat_1, reseat_to_string)
e7b41c4c
JB
2895 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
2896 Set bidi_it.w member from it->w.
5bf97bfc
EZ
2897 (compute_display_string_pos): Accept additional argument, the
2898 window being displayed, and pass it to Fget_char_property.
2899 (Bug#14575)
2900
2901 * dispextern.h (struct bidi_it): New member w, the window being
2902 displayed.
2903 (compute_display_string_pos): Adjust prototype.
2904
5de0e011
JD
29052013-06-08 Jan Djärv <jan.h.d@swipnet.se>
2906
e7b41c4c 2907 * xgselect.c: Remove unneeded include xterm.h.
b33f93ee
JD
2908
2909 * process.c (wait_reading_process_output): Check for NS before GLIB.
2910 GLIB may be linked in due to rsvg, but ns_select must be called.
2911
5de0e011
JD
2912 * xgselect.c (xg_select): Remove call to window_system_available
2913 and g_main_context_pending at the top, so Gdk events (i.e. file
2914 notify) are processed when Emacs is started with -nw.
2915
a822acff
EZ
29162013-06-07 Eli Zaretskii <eliz@gnu.org>
2917
2918 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
2919 (ctagsfiles3): New variable, includes only *.m files.
2920 (TAGS): Use an explicit language name in the regular expressions,
2921 to avoid transformation of '/SOMETHING' by MSYS to
2922 'c:\MSYS\SOMETHING'.
2923
6c0a9ed1
RC
29242013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
2925
2926 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
2927
9ef6111b
EZ
29282013-06-06 Eli Zaretskii <eliz@gnu.org>
2929
2930 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
2931 still need to set the mouse pointer shape and activate help-echo.
2932 (Bug#14558)
2933
7d300d64
PE
29342013-06-06 Paul Eggert <eggert@cs.ucla.edu>
2935
2936 A few porting etc. fixes for the new file monitor code.
2937 See the thread containing
2938 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
2939 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
2940 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
2941 (dir_monitor_callback, Fgfile_rm_watch):
2942 Use assq_no_quit instead of Fassoc, for speed.
2943 (dir_monitor_callback, Fgfile_rm_watch):
2944 eassert that the monitor is a fixnum.
2945 (dir_monitor_callback): No need for CDR_SAFE.
2946 Simplify building of lisp with alternative tails.
2947 (Fgfile_add_watch, Fgfile_rm_watch):
2948 Do not assume glib functions set errno reliably on failure.
2949 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
2950 and signal an error otherwise.
2951 (Fgfile_rm_watch): Prefer CONSP to !NILP.
2952 Use Fdelq instead of Fdelete, for speed.
2953
817ebfcf
EZ
29542013-06-05 Eli Zaretskii <eliz@gnu.org>
2955
2956 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
2957 don't insist on being invoked on a highlighted tool-bar button.
2958 Avoids losing tool-bar functionality when mouse-highlight is nil.
2959 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
2960 Don't highlight when mouse-highlight is nil.
2961 (note_mouse_highlight): When mouse-highlight is nil, don't return
2962 right away; instead, run tool-bar and mode-line highlight
2963 subroutine, clear any existing highlight, and revert the mouse
2964 pointer to its default shape. (Bug#14558)
2965
55577e7c
SM
29662013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2967
2968 * lisp.mk (lisp): Add prog-mode.el.
2969
f019a684
PE
29702013-06-05 Paul Eggert <eggert@cs.ucla.edu>
2971
2972 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
2973 * process.c (dummy_handler): New function.
2974 (lib_child_handler): New static var.
2975 (handle_child_signal): Invoke it.
2976 (catch_child_signal): If a library has set up a signal handler,
2977 save it into lib_child_handler.
2978 (init_process_emacs): If using glib and not on Windows, tickle glib's
2979 child-handling code so that it initializes its private SIGCHLD handler.
2980 * syssignal.h (SA_SIGINFO): Default to 0.
2981 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
2982 31; it should no longer be needed now.
2983
90db8702
MA
29842013-06-05 Michael Albinus <michael.albinus@gmx.de>
2985
2986 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
2987
2988 * gfilenotify.c (globals_of_gfilenotify): New function.
2989 (syms_of_gfilenotify): Move global initialization there.
2990
2991 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
2992
bfa3acd6
SM
29932013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2994
2995 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
2996 * keyboard.c (menu_bar_items, tool_bar_items):
2997 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
2998 not override local keymaps any more.
2999
ba59bd80
EZ
30002013-06-04 Eli Zaretskii <eliz@gnu.org>
3001
3002 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
3003
7f203aa1
EZ
30042013-06-03 Eli Zaretskii <eliz@gnu.org>
3005
9337e206
EZ
3006 * w32console.c (initialize_w32_display): Return the dimensions of
3007 the console window via 2 additional arguments, not via the current
3008 frame. This avoids crashes due to overrunning the bounds of
3009 frame's decode_mode_spec_buffer, which is not resized following
3010 the change of the frame dimensions from the initial 10x10.
3011
3012 * w32term.h (w32_initialize_display_info): Adjust prototype.
3013
3014 * term.c (init_tty): Take dimensions of the frame from the values
3015 returned by initialize_w32_display.
3016
7f203aa1
EZ
3017 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
3018 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
3019 (LIBES): Add $(GFILENOTIFY_LIBS).
3020
3021 * w32inevt.c (handle_file_notifications): Add dummy implementation
3022 for !HAVE_W32NOTIFY.
3023
3024 * w32term.c: Wrap code with HAVE_W32NOTIFY.
3025
55a87246
JD
30262013-06-03 Jan Djärv <jan.h.d@swipnet.se>
3027
3028 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
3029
3030 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
3031
3032 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
3033
3d5ee10a
PE
30342013-06-03 Paul Eggert <eggert@cs.ucla.edu>
3035
3036 Fix minor problems found by static checking.
3037 * data.c (pure_write_error):
3038 Use xsignal2, not Fsignal, as Fsignal might return.
3039 * eval.c (set_backtrace_debug_on_exit): Now static.
3040 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
3041 No longer inline. EXTERN_INLINE is needed only for functions
3042 defined in .h files. Reindent function header as per GNU style.
3043 (backtrace_p, backtrace_top, backtrace_next):
3044 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
3045 compiler or linker. Add extern decls to pacify gcc -Wall.
3046 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
3047 Now static.
3048 * frame.c (free_monitors): Define only on platforms that need it.
3049 * nsterm.m (ns_term_init):
3050 * process.c (catch_child_signal):
3051 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
3052 defined on all porting targets these days.
3053 * process.c, process.h (catch_child_signal):
3054 Make it extern only if NS_IMPL_GNUSTEP is defined.
3055
e2d8a6f0
EZ
30562013-06-03 Eli Zaretskii <eliz@gnu.org>
3057
3058 * w32.c (gettimeofday): Make the signature identical to prototype
3059 in nt/inc/sys/time.h.
3060
a8a7c5f6
SM
30612013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
3062
3063 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
3064 .gdbinit.
3065
3066 * keyboard.c (safe_run_hooks_error): Improve error message.
3067
3068 * data.c (pure_write_error): Add `object' argument.
3069 * puresize.h (CHECK_IMPURE): Use it.
3070
c9628c79
MA
30712013-06-03 Michael Albinus <michael.albinus@gmx.de>
3072
3073 * Makefile.in (NOTIFY_OBJ): New variable.
3074 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
3075
3076 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
3077 Call syms_of_gfilenotify.
3078
3079 * gfilenotify.c: New file.
3080
3081 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
3082 and Qfile_w32notify.
3083 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
3084 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
3085
3086 * lisp.h: Declare syms_of_gfilenotify.
3087
3088 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
3089
2f592f95
SM
30902013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
3091
3092 Merge the specpdl and backtrace stacks. Make the structure of the
3093 specpdl entries more obvious via a tagged union of structs.
3094 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
3095 (enum specbind_tag): New enum.
3096 (struct specbinding): Make it a tagged union of structs.
3097 Add a case for backtrace records.
3098 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
3099 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
3100 (backtrace_debug_on_exit): New accessors.
3101 (struct backtrace): Remove.
3102 (struct catchtag): Remove backlist field.
3103 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3104 Move to eval.c.
3105 (Flocal_variable_p): Speed up the common case where the binding is
3106 already loaded.
3107 * eval.c (backtrace_list): Remove.
3108 (set_specpdl_symbol, set_specpdl_old_value): Remove.
3109 (set_backtrace_args, set_backtrace_nargs)
3110 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
3111 (backtrace_next): New functions.
3112 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
3113 (unwind_to_catch, internal_lisp_condition_case)
3114 (internal_condition_case, internal_condition_case_1)
3115 (internal_condition_case_2, internal_condition_case_n): Don't bother
3116 with backtrace_list any more.
3117 (Fsignal): Adjust to new backtrace format.
3118 (grow_specpdl): Move up.
3119 (record_in_backtrace): New function.
3120 (eval_sub, Ffuncall): Use it.
3121 (apply_lambda): Adjust to new backtrace format.
3122 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
3123 data.c.
3124 (specbind): Adjust to new specpdl format. Simplify.
3125 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
3126 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
3127 backtrace format.
3128 (mark_backtrace): Remove.
3129 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
3130 * xdisp.c (redisplay_internal): Use record_in_backtrace.
3131 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
3132 Use mark_specpdl.
3133 * profiler.c (record_backtrace): Use get_backtrace.
3134 (handle_profiler_signal): Use backtrace_top_function.
3135 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
3136 accessor functions.
3137
c0342369
JD
31382013-06-02 Jan Djärv <jan.h.d@swipnet.se>
3139
3140 * process.h (catch_child_signal): Declare.
3141
3142 * process.c (catch_child_signal): New function.
3143 (init_process_emacs): Call it.
3144
3145 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
3146 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
3147 NS_IMPL_COCOA.
3148 (x_set_cursor_type): Remove declaration.
3149 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
3150 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
3151 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
3152 (ns_get_color): Use F suffix on float.
3153 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
3154 (ns_get_rgb_color): Remove.
3155 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
3156 (note_mouse_movement): x and y are CGFloat.
3157 (ns_draw_fringe_bitmap): Remove unused rowY.
3158 Change #if to COCOA && >= 10_6.
3159 (ns_draw_window_cursor): Remove unused overspill.
3160 (ns_draw_underwave): width and x are EamcsCGFloat.
3161 (ns_draw_box): thickness is CGFloat.
3162 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
3163 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
3164 if not in main thread.
3165 (ns_get_pending_menu_title, ns_check_menu_open)
3166 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
3167 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
3168 (sendFromMainThread:): New method.
3169 (changeFont:): size is CGFloat.
3170 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
3171 Disable warning about permanent text.
3172 (characterIndexForPoint:): Adjust return type depending on GNUStep
3173 version.
3174 (mouseDown:): delta is CGFloat.
3175 (updateFrameSize): Remove unised variable f.
3176 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
3177 Cast float to EmacsCGFloat.
3178 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
3179 also to -1 when restoring.
3180 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
3181 inside NS_IMPL_COCOA.
3182 (toggleFullScreen:): Put call to toggleFullScreen inside
3183 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
3184 (setPosition:portion:whole:): por is CGFloat.
3185 (getMouseMotionPart:window:x:y:): Add F suffix to float.
3186 (mouseDown:): Use CGFloat.
3187 (mouseDragged:): Remove unised variable edge.
3188 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
3189
3190 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
3191 of CGFloat differs.
3192 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
3193 when NS_IMPL_GNUSTEP.
3194 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
3195 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
3196 (EmacsToolbar): Add clearAll. Add tag argument to
3197 addDisplayItemWithImage.
3198 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
3199
3200 * nsselect.m (ns_get_local_selection): Remove unused variable type.
3201
3202 * nsmenu.m (ns_update_menubar): Make static.
3203 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
3204 (fillWithWidgetValue:): Add cast to SEL for setAction.
3205 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
3206 (update_frame_tool_bar): Update code for GNUStep.
3207 (clearAll): New method.
3208 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
4f405069 3209 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
e7b41c4c 3210 Move identifierToItem setObject and activeIdentifiers addObject before
c0342369
JD
3211 call to insertItemWithItemIdentifier.
3212 (validateVisibleItems): Fix indentation.
3213 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
3214 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
3215 UtilityWindow to aStyle, remove call to setStyleMask.
3216
3217 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
3218
3219 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
3220 (ns_charset_covers, ns_get_covering_families, nsfont_open):
3221 Use F suffix on floats.
3222 (ns_char_width): Returns CGFloat.
3223 (ns_ascii_average_width): w is CGFloat instead of float.
e7b41c4c 3224 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
c0342369
JD
3225 DPSxshow.
3226 (ns_glyph_metrics): CGFloat instead of float.
3227
a0eb10b3
JB
3228 * nsfns.m (x_set_foreground_color, x_set_background_color):
3229 Use EmacsCGFloat.
3230 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
3231 remove unused variables.
3232 (Fns_read_file_name): Keep track if panel is for save.
3233 Use ns_filename_from_panel/ns_directory_from_panel.
c0342369 3234 (Fns_list_services): delegate only used for COCOA.
a0eb10b3
JB
3235 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
3236 Just return the input if GNUStep.
c0342369
JD
3237 (x_screen_planes): Remove.
3238 (Fxw_color_values): Use EmacsCGFloat
3239 (Fns_display_monitor_attributes_list): Only get screen number for
3240 Cocoa.
ef099a94 3241 (getDirectory, getFilename): Remove from EmacsOpenPanel and
c0342369
JD
3242 EmacsSavePanel.
3243 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
3244 ns_directory_from_panel.
3245
da9aff11
PE
32462013-06-01 Paul Eggert <eggert@cs.ucla.edu>
3247
3248 * process.c (handle_child_signal): Also use WCONTINUED.
3249 This is so that list-processes doesn't mistakenly list the process
3250 as stopped, when the process has actually been continued and is
3251 now running.
3252
0e64479a
PE
32532013-05-31 Paul Eggert <eggert@cs.ucla.edu>
3254
fc186a96
PE
3255 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
3256 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
3257 not already configured.
3258
0e64479a
PE
3259 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
3260
38b787fa
EZ
32612013-05-29 Eli Zaretskii <eliz@gnu.org>
3262
3263 * Makefile.in (mostlyclean): Remove *.res files.
3264
22513e52
SM
32652013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
3266
3267 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
3268 a buffer (bug#8447).
3269
6ef3db10
EZ
32702013-05-27 Eli Zaretskii <eliz@gnu.org>
3271
3272 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
3273 display vector, and we backtrack, handle the case that the
3274 previous character position is also displayed from a display
3275 vector or covered by a display string or image. (Bug#14476)
3276
6799bb26
JD
32772013-05-25 Jan Djärv <jan.h.d@swipnet.se>
3278
3279 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3280 (struct MonitorInfo, free_monitors): Remove.
3281 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
3282 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
3283 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3284 Qframes, Qsource.
3285
3286 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3287 (struct MonitorInfo, free_monitors): Remove.
3288 (ns_screen_name): Make static.
3289 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
3290 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3291 Qframes, Qsource.
3292
3293 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3294 (struct MonitorInfo): New struct.
3295 (free_monitors, make_monitor_attribute_list): Declare.
3296
22513e52
SM
3297 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
3298 New Lisp_Object:s.
6799bb26
JD
3299 (free_monitors, make_monitor_attribute_list): New functions.
3300 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
3301 Qsource.
3302
38cd43eb
XF
33032013-05-25 Xue Fuqiao <xfq.free@gmail.com>
3304
3305 * callproc.c (call_process): Refine the doc string. (Bug#14045)
3306
2af0948d
SM
33072013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
3308
a7eb9b0f
SM
3309 * keyboard.c: Apply keyboard decoding only to events that come directly
3310 from the tty, not from unread-command-events (bug#14368).
3311 (read_event_from_main_queue): New function, extracted from read_char).
3312 (read_decoded_char): Remove.
3313 (read_decoded_event_from_main_queue): New function to replace it.
3314 (read_char): Use it.
3315 (read_key_sequence): Use read_char rather than read_decoded_char.
3316
2af0948d
SM
3317 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
3318
1413e9a5
BR
33192013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
3320
3321 * casetab.c (init_casetab_once): Fix last change (bug#14424).
3322
e6d2f155
KH
33232013-05-22 Kenichi Handa <handa@gnu.org>
3324
3325 The following changes are to fix the setting of
3326 buffer-file-coding-system on, for instance, C-x RET c unix RET
3327 _FILE_OF_DOS_EOL_TYPE_ RET.
3328
3329 * coding.h (struct coding_system): New member detected_utf8_chars.
3330
3331 * coding.c (detect_coding_utf_8): Count characters and check EOL
3332 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
3333 BOM is there.
3334 (setup_coding_system): Do not initialize coding->head_ascii.
3335 (check_ascii): Do not set coding->eol_seen but update it. Do not
3336 call adjust_coding_eol_type here.
1413e9a5
BR
3337 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
3338 If the eol-type of CODING is already specified, adjust the eol type
e6d2f155
KH
3339 of the found coding-system.
3340 (decode_coding_gap): Cancel previous change. Utilize the
3341 character numbers counted by detect_coding_utf_8. Fix detection
3342 of BOM for utf-8.
3343
ab56a6f4 33442013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
fc30d803
SM
3345
3346 * search.c (looking_at_1): Only set last_thing_searched if the match
3347 changed the match-data (bug#14281).
3348
ecc3c6ed
DA
33492013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
3350
3351 * xdisp.c (reseat_at_previous_visible_line_start):
a0eb10b3 3352 Already declared in dispextern.h, so remove it here.
ecc3c6ed
DA
3353 (move_it_vertically_backward): Likewise.
3354
5ba8bf35
YM
33552013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3356
3357 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
d6635ba2 3358 (Fx_display_pixel_width, Fx_display_pixel_height)
fc30d803
SM
3359 (Fx_display_mm_width, Fx_display_mm_height):
3360 Mention `display-monitor-attributes-list' in docstrings.
5ba8bf35 3361
91e8418b 3362 * nsfns.m (ns_get_screen): Remove function. All uses removed.
a0eb10b3 3363 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
91e8418b
YM
3364 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
3365 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
3366 (Fx_display_backing_store, Fx_display_visual_class)
3367 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
3368 (Fx_display_grayscale_p, Fx_display_pixel_width)
3369 (Fx_display_pixel_height, Fx_display_planes)
3370 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
3371 (Fx_display_screens): Don't confuse X11 screens with NS screens.
3372 (Fx_display_mm_width, Fx_display_mm_height)
3373 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
3374 height for all physical monitors as in X11.
3375
fc30d803
SM
3376 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
3377 Return pixel width or height for all physical monitors as in X11.
91e8418b 3378
31ff141c
PE
33792013-05-18 Paul Eggert <eggert@cs.ucla.edu>
3380
3381 Port --enable-gcc-warnings to clang.
3382 * bytecode.c (exec_byte_code):
3383 * regex.c:
3384 Redo diagnostic pragmas to pacify clang, too.
3385 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
3386 * editfns.c (Fencode_time):
3387 * fileio.c (file_accessible_directory_p):
3388 * font.c (font_unparse_xlfd):
3389 Use '&"string"[index]' instead of '"string" + (index)'.
3390 * undo.c (user_error): Remove; unused.
3391
df065a0b
EZ
33922013-05-16 Eli Zaretskii <eliz@gnu.org>
3393
04d360e7
EZ
3394 * insdel.c (insert_1_both): Document the arguments, instead of
3395 referring to insert_1, which no longer exists.
3396
5bb98290
EZ
3397 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
3398 some window, increment windows_or_buffers_changed, so that
3399 *Messages* display in that window is updated. (Bug#14408)
3400
df065a0b
EZ
3401 * w32.c: Include epaths.h.
3402 (init_environment): Use cmdproxy.exe without leading directories.
3403 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
3404 case.
3405 (gettimeofday): Adjust signature and return value to Posix
3406 expectations.
3407
3408 * unexw32.c (open_output_file): Delete the existing emacs.exe
3409 before creating it, to break the hard link to the versioned
3410 executable.
3411
3412 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
3413 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
3414 (FIRSTFILE_OBJ): New variables.
3415 (W32_RES): Rename to EMACSRES. All users changed.
3416 (base_obj): Use $(CM_OBJ).
3417 (ALLOBJS): Use $(FIRSTFILE_OBJ).
3418 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
3419 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
3420 $(W32_RES_LINK) before $(LIBES).
3421 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
3422
1aa8d505
SM
34232013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3424
6e911150
SM
3425 * makefile.w32-in (DOC): Use just "DOC".
3426
3427 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
3428
1aa8d505
SM
3429 * process.c: Export default filters and sentinels to Elisp.
3430 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
3431 New constants.
3432 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
3433 (Fset_process_sentinel, Fformat_network_address):
3434 Default to them instead of nil.
3435 (server_accept_connection): Sentinels can't be nil any more.
3436 (read_and_dispose_of_process_output): New function, extracted from
3437 read_process_output.
3438 (read_process_output): Use it; filters can't be nil.
3439 (Finternal_default_process_filter): New function, extracted from
3440 read_process_output.
3441 (exec_sentinel_unwind): Remove function.
3442 (exec_sentinel): Don't zilch sentinel while running.
3443 (status_notify): Sentinels can't be nil.
3444 (Finternal_default_process_sentinel): New function extracted from
3445 status_notify.
3446 (setup_process_coding_systems): Default filter is not nil any more.
3447 (syms_of_process): Export new Elisp functions and initialize
3448 new constants.
3449 * lisp.h (make_lisp_proc): New function.
3450
5ac2eb34
SM
34512013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3452
3453 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
3454
eda9c7d7
EZ
34552013-05-14 Eli Zaretskii <eliz@gnu.org>
3456
3457 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
5ac2eb34
SM
3458 unless we know that the window w is a leaf window.
3459 Another attempt at solving bug#14062.
eda9c7d7 3460
8fdeaad5
JD
34612013-05-14 Jan Djärv <jan.h.d@swipnet.se>
3462
3463 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
3464 fdesc (Bug#14375).
3465
44aa9ee6
PE
34662013-05-12 Paul Eggert <eggert@cs.ucla.edu>
3467
3468 * image.c (gif_load): Check that subimages fit (Bug#14345).
3469
759fd763
SM
34702013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
3471
3472 * lread.c (skip_dyn_eof): New function.
3473 (read1): Use it to skip the end of a file in response to #@00.
3474
3475 * doc.c (get_doc_string): Slightly relax the sanity checking.
3476
4465bfb4
JD
34772013-05-09 Jan Djärv <jan.h.d@swipnet.se>
3478
3479 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
3480 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3481 (MonitorInfo): New struct.
3482 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
3483 (Fns_display_monitor_attributes_list): New functions.
3484 (display-usable-bounds): Remove.
3485 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
3486 Qsource.
3487
7583e2a0
PE
34882013-05-09 Paul Eggert <eggert@cs.ucla.edu>
3489
3490 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
3491 (GTK_CHECK_VERSION): New macro, if not already defined.
3492 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
3493 replaced by GTK_CHECK_VERSION.
3494
ad75d77e
PE
34952013-05-08 Paul Eggert <eggert@cs.ucla.edu>
3496
3497 * xterm.h (GTK_PREREQ): New macro.
3498 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
3499 to use this macro instead, for consistency and clarity.
3500
07525f77
EZ
35012013-05-08 Eli Zaretskii <eliz@gnu.org>
3502
3503 * xdisp.c (row_for_charpos_p): New function, with code of
3504 cursor_row_p, but accepts an additional argument CHARPOS instead
3505 of using a hardcoded PT.
3506 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
3507 (row_containing_pos): Call row_for_charpos_p instead of partially
3508 doing the same. Fixes cursor positioning under longlines-mode
3509 when longlines-show-effect includes more than one newline, when
3510 moving the cursor vertically up.
3511
d901fc8d
JB
35122013-05-08 Juanma Barranquero <lekktu@gmail.com>
3513
3514 * makefile.w32-in (ACL_H): New macro.
3515 ($(BLD)/fileio.$(O)): Update dependencies.
3516
f269bc61
PE
35172013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3518
e7b41c4c 3519 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
ffdc270a
PE
3520 * Makefile.in (LIB_ACL): New macro.
3521 (LIBACL_LIBS): Remove.
3522 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
3523 * fileio.c: Include <acl.h>.
3524 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
3525 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
3526 !acl_errno_valid.
3527 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
3528 it ourselves.
3529
f269bc61
PE
3530 * unexelf.c: Don't assume ElfW (Half) fits in int.
3531 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
3532 when dealing with ElfW (Half) values, since they can exceed 2**31
3533 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
3534 (entry_address): Omit unused NUM arg. All uses changed.
3535
a261c53e
JL
35362013-05-07 Juri Linkov <juri@jurta.org>
3537
3538 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
3539 to the string converted from number with `Fnumber_to_string'.
3540 (Bug#14254)
3541
2b66427d
PE
35422013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3543
3544 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
3545 This fixes a problem introduced by my previous change.
3546
15acfe41
GM
35472013-05-07 Glenn Morris <rgm@gnu.org>
3548
3549 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
3550
5ea03bf5
JD
35512013-05-07 Jan Djärv <jan.h.d@swipnet.se>
3552
3553 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
3554
e0c9d565
PE
35552013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3556
3557 Static checking by GCC 4.8.0.
3558 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
3559 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
3560 (x_get_monitor_attributes_fallback)
3561 (x_get_monitor_attributes_xinerama)
3562 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
3563 Define only if USE_GTK.
3564 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
3565 (x_get_monitor_attributes_fallback): Omit unused locals.
3566 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
3567 Use double, not float, to avoid mixed-mode floating point arithmetic.
3568
4e3f9230
YM
35692013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3570 Jan Djärv <jan.h.d@swipnet.se>
3571
3572 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
3573 (XINERAMA_CFLAGS): New macros.
3574 (ALL_CFLAGS, LIBES): Use them.
3575
3576 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
3577 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
3578 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
3579 (syms_of_xfns): DEFSYM them.
3580 (struct MonitorInfo): New struct.
3581 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
3582 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
3583 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
3584 (x_get_monitor_attributes_xinerama): New functions.
3585 (Fx_display_monitor_attributes_list): New primitive.
3586 (syms_of_xfns): Defsubr it.
3587
3588 * xterm.h (x_display_info): Add Xatom_net_workarea and
3589 Xatom_net_current_desktop.
3590
3591 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
3592 and dpyinfo->Xatom_net_current_desktop.
3593
05839b6a
EZ
35942013-05-06 Eli Zaretskii <eliz@gnu.org>
3595
3596 * xdisp.c (pos_visible_p): Use the special code for finding the
3597 beginning of a display property or overlay for any "replacing"
3598 display property, not just for display strings. This solves
3599 incorrect reporting of position by posn-at-point. (Bug#14241)
3600
dc4a2ee0
PE
36012013-05-06 Paul Eggert <eggert@cs.ucla.edu>
3602
5ee94506
PE
3603 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
3604 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
3605 Verify that ElfW (Half) fits in int.
3606 (fatal): Use same signature as lisp.h.
3607 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
3608 configure and build with -DUNEXELF_DEBUG without worrying about
3609 other modules that use DEBUG.
3610 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
3611 possibly-wide integers now uses it instead of plain fprintf.
3612 (entry_address): New function, which avoids problems with 32-bit
3613 overflow on 64-bit hosts.
3614 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
3615 (round_up): Don't assume the remainder fits in int.
3616 (find_section): Use bool for boolean. Simplify debug code.
3617 (unexec): Don't assume file sizes fit in int or size_t.
3618 Omit unnecessary trailing newline in 'fatal' format.
3619 Use strerror rather than outputting decimal error number.
3620 Remove unused code when emacs is not defined;
3621 this file relies on Emacs now.
3622 Don't assume e_phnum and e_shnum are positive.
3623
dc4a2ee0
PE
3624 * regex.c: Fix problems when DEBUG is defined.
3625 (extract_number, extract_number_and_incr): Define regardless of
3626 whether DEBUG is defined; that's simpler and makes the code less
3627 likely to go stale in the normal case when DEBUG is not defined.
3628 Return int rather than taking an int * arg. All callers changed.
3629 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
3630 Remove, replacing with ...
3631 (DEBUG_PRINT): New macro. All callers changed.
3632 (DEBUG_COMPILES_ARGUMENTS): New macro.
3633 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
3634 (print_compiled_pattern, print_double_string) [DEBUG]:
3635 Use prototype rather than old-style definition.
3636 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
3637 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
3638 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
3639 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
3640 Don't assume ptrdiff_t, size_t, and long are the same width as int.
3641 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
3642 This matters only when DEBUG is defined.
3643
14c7ed05
EZ
36442013-05-05 Eli Zaretskii <eliz@gnu.org>
3645
3646 * xdisp.c (set_iterator_to_next): Set the
3647 ignore_overlay_strings_at_pos_p flag only if we are _really_
3648 iterating over an overlay string, as indicated by the
3649 current.overlay_string_index member. (Bug#14306)
3650
e6076b1b
JD
36512013-05-05 Jan Djärv <jan.h.d@swipnet.se>
3652
3653 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
3654 to where it is used, to avoid autorelease issues (Bug#14050).
3655
cbee2131
PE
36562013-05-05 Paul Eggert <eggert@cs.ucla.edu>
3657
3658 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
3659 * fileio.c (syms_of_fileio): Implement this.
3660 * filelock.c (create_lock_file): If symbolic links don't work, so
3661 we use a regular file as a lock file, do not fsync the lock file;
3662 it's not needed.
3663
30c7e542
SM
36642013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3665
3666 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
3667 (syms_of_minibuf): Adjust accodingly.
3668 * lread.c (Fread):
3669 * callint.c (Fcall_interactively): Adjust calls accordingly.
3670
5bebd186
EZ
36712013-05-04 Eli Zaretskii <eliz@gnu.org>
3672
3673 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
30c7e542
SM
3674 w->contents is a buffer before computing everything else.
3675 Use parentheses to disambiguate last part of the condition.
5bebd186
EZ
3676
3677 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
3678 assertion violations. (Bug#14062)
3679
0fb0a4f3
DR
36802013-05-01 David Reitter <david.reitter@gmail.com>
3681
3682 * nsfns.m (ns_tooltip): Initialize.
3683
9e63b4a5
EZ
36842013-04-28 Eli Zaretskii <eliz@gnu.org>
3685
3686 * coding.c (decode_coding_gap): Don't remove the character before
3687 a newline unless it's a CR character. (Bug#14287)
3688
ad60824e
DN
36892013-04-28 Dan Nicolaescu <dann@gnu.org>
3690
3691 * dispextern.h (struct face): Move enum face_underline_type
3692 earlier so that bitfields can be in the same word.
3693
edbdcec0
JD
36942013-04-28 Jan Djärv <jan.h.d@swipnet.se>
3695
3696 * nsfns.m (handlePanelKeys): New function.
3697 (EmacsOpenPanel:performKeyEquivalent:)
3698 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
3699 arrows/function/control and copy/paste keys (Bug#14296).
3700
0208ede7
JL
37012013-04-27 Juri Linkov <juri@jurta.org>
3702
3703 * callint.c (Fcall_interactively): Call `Qread_number' for
3704 interactive code letter `n' instead of using duplicate code.
3705 (Bug#14254)
3706
b8dd59f7
PE
37072013-04-27 Paul Eggert <eggert@cs.ucla.edu>
3708
3709 * systime.h (make_timeval): Declare as 'const'.
3710
8bd722db
KH
37112013-04-27 Kenichi Handa <handa@gnu.org>
3712
3713 * font.c (font_open_entity): Always open a font of manageable
3714 size.
3715
13d0e56f 37162013-04-26 Paul Eggert <eggert@cs.ucla.edu>
cbee2131 3717
f780d632
PE
3718 Port better to AIX (Bug#14258).
3719 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
3720 to pacify AIX xlc.
3721
ec509856
KH
37222013-04-24 Kenichi Handa <handa@gnu.org>
3723
3724 * coding.c (decode_coding_iso_2022): When an invalid escape
3725 sequence is encountered, reset the invocation and designation
3726 status to the safest one.
3727
84fc48e5
PE
37282013-04-22 Paul Eggert <eggert@cs.ucla.edu>
3729
3730 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
3731 Without this fix, "make distclean" leaves stamp-h1 behind.
3732
806bda47
EC
37332013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
3734
3735 * w32fns.c (w32_fullscreen_rect): New function to compute the
3736 window rectangle for the given fullscreen mode.
3737 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
3738 longer tunes the window size. This keeps the window's edges flush
3739 with the screen and allows the taskbar to hide itself in fullboth.
3740
3741 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
3742 window decorations and uses the entire screen.
3743
3744 * w32term.h (w32_fullscreen_rect) Add prototype.
3745 (struct w32_output): Replace normal_width, normal_height,
3746 normal_top, and normal_left members with a single normal_placement
3747 struct.
3748 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
3749 Remove macros.
3750 (FRAME_NORMAL_PLACEMENT): New macro.
3751
9cc2810b
JB
37522013-04-16 Juanma Barranquero <lekktu@gmail.com>
3753
3754 * minibuf.c (Ftest_completion): Silence compiler warning.
3755
fd16b54c
EZ
37562013-04-15 Eli Zaretskii <eliz@gnu.org>
3757
3758 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
5fbcd237 3759 bug#14062.
fd16b54c
EZ
3760
3761 * frame.h (WINDOW_FRAME): Protect macro and its argument with
3762 parentheses.
3763
3764 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
3765 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
3766 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
3767 parentheses where appropriate.
3768
9e3379a0
PE
37692013-04-14 Paul Eggert <eggert@cs.ucla.edu>
3770
3771 * keyboard.c (timer_start_idle): Remove no-longer-used local.
3772
ddd6b685
EZ
37732013-04-14 Eli Zaretskii <eliz@gnu.org>
3774
3775 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
3776 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
3777 Mention in the doc string that setting these variables takes
3778 effect only after a call to set-window-buffer. (Bug#14200)
3779
29b79ba1
EZ
37802013-04-13 Eli Zaretskii <eliz@gnu.org>
3781
3782 * indent.c (Fvertical_motion): Don't consider display strings on
3783 overlay strings as display strings on the buffer position we
3784 started from. This prevents vertical cursor motion from jumping
3785 more than one line when there's an overlay string with a display
3786 property at end of line.
3787 Reported by Karl Chen <Karl.Chen@quarl.org> in
3788 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
3789
562c6ee9
SM
37902013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
3791
3792 * window.c (select_window): `record_buffer' even if window is
3793 already selected (bug#14191).
3794
fcc1fe85
EZ
37952013-04-11 Eli Zaretskii <eliz@gnu.org>
3796
3797 * window.c (Fwindow_end): Test more flags, including the buffer's
3798 last_overlay_modified flag, to determine whether the window's
3799 display is really up-to-date. Prevents the function from
3800 returning a stale value. (Bug#14170)
3801 (Fwindow_line_height): Fix the test for up-to-date-ness of the
3802 current matrix.
3803
f009190a
EZ
38042013-04-10 Eli Zaretskii <eliz@gnu.org>
3805
3806 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
562c6ee9
SM
3807 garbaged only if it is not already the top frame on its TTY.
3808 This prevents flickering due to constant redrawing of TTY frames when
f009190a
EZ
3809 there are GUI frames open in the same session. (Bug#13864)
3810
78ce603d
SM
38112013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
3812
3813 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
3814 of marking the idle timers directly.
3815
a8036e40
SM
38162013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
3817
3818 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
3819 tables (bug#14054).
3820
7ffe7ef6
SM
38212013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
3822
3823 * window.c (select_window): Don't record_buffer while the invariant is
3824 temporarily broken (bug#14161).
3825
3826 * fns.c (Fdelq): Don't assume !NILP => CONSP.
3827
7d9f6883
EZ
38282013-04-07 Eli Zaretskii <eliz@gnu.org>
3829
3830 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
3831
5406cfd9
RF
38322013-04-07 Romain Francoise <romain@orebokech.com>
3833
3834 Ignore additional platform-specific ACL errors (Bug#13702).
3835 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
3836 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
3837
95c0e83b
JD
38382013-03-31 Jan Djärv <jan.h.d@swipnet.se>
3839
3840 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
3841 f->output_data.ns.
3842
876da980
PE
38432013-04-07 Paul Eggert <eggert@cs.ucla.edu>
3844
3845 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
3846 This bug was introduced by my 2013-02-25 change that simplified
3847 data_start configuration. Without this change, on GNU/Linux
3848 an Emacs configured with --enable-profiling fails immediately
3849 due to a profiler signal.
3850 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
3851 with these flags. On platforms where special flags are needed
3852 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
3853 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
3854 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
3855
7452b7bd
DA
38562013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
3857
3858 Get rid of some platform-specific functions examining window
3859 system and its capabilities. This is a partial rework of the
3860 2013-04-05 change.
3861 * lisp.h (have_menus_p): Remove prototype. This function is
3862 replaced with platform-independent window_system_available.
3863 (check_window_system): Move to...
3864 * frame.h (decode_window_system_frame, window_system_available):
3865 ...here, add new prototypes.
3866 * frame.c (window_system_available, decode_window_system_frame):
3867 New functions.
3868 (check_window_system): Platform-independent now.
3869 * xterm.h (x_in_use): Remove declaration.
3870 (check_x_frame):
3871 * w32term.h (check_x_frame):
3872 * nsterm.h (check_x_frame): Remove prototypes. This function
3873 is replaced with platform-independent decode_window_system_frame.
3874 * msdos.c (have_menus_p): Remove.
3875 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
3876 Remove platform-specific functions. Use check_window_system,
3877 decode_window_system_frame and check_ns_display_info where
3878 appropriate. Minor style and comment tweaks.
3879 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
3880 (check_x_frame): Likewise.
3881 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
3882 Likewise.
3883 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
3884 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
3885 * xmenu.c, xselect.c: All related users changed.
3886
251e9147
KH
38872013-04-03 Kenichi Handa <handa@gnu.org>
3888
3889 The following changes is to optimize the code for reading UTF-8
3890 files.
3891
562c6ee9 3892 * coding.c (check_ascii): Rename from detect_ascii. Return value
251e9147
KH
3893 changed. Check EOL format. Do not call adjust_coding_eol_type
3894 here.
3895 (check_utf_8): New function.
3896 (adjust_coding_eol_type): Do nothing if already adjusted.
3897 (detect_coding): Compare the return value of check_ascii with
3898 coding->src_bytes. Call adjust_coding_eol_type if necessary.
3899 (decode_coding_gap): Optimize for valid UTF-8.
3900
8bc369d4
KH
39012013-03-21 Kenichi Handa <handa@gnu.org>
3902
3903 * coding.c (syms_of_coding): Cancel previous change.
3904
3905 * insdel.c (insert_from_gap): Fix previous change.
3906
73931ad1
DA
39072013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
3908
3909 Consistently use platform-specific function to detect window system.
3910 * lisp.h (check_window_system): New prototype. This function is
3911 going to replace check_x, check_w32 and check_ns.
3912 (have_menus_p): Mention msdos.c in comment.
3913 * fontset.c (check_window_system_func): Remove. Adjust all users.
3914 * fontset.h (check_window_system_func): Remove prototype.
3915 * nsterm.h (check_ns):
3916 * xterm.h (check_x):
3917 * w32term.h (check_w32): Likewise.
3918 * menu.c (Fx_popup_menu): Use check_window_system.
3919 * msdos.c (check_window_system): Define for MS-DOS.
3920 * nsfns.m (check_window_system): Define for NS. Adjust all users.
3921 * w32fns.c (check_window_system): Likewise for MS-Windows.
3922 * xfns.c (check_window_system): Likewise for X.
3923 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
3924 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
3925
7216e43b
PE
39262013-04-02 Paul Eggert <eggert@cs.ucla.edu>
3927
3928 Prefer < to > in range checks such as 0 <= i && i < N.
3929 This makes it easier to visualize quantities on a number line.
3930 This patch doesn't apply to all such range checks,
3931 only to the range checks affected by the 2013-03-24 change.
3932 This patch reverts most of the 2013-03-24 change.
3933 * alloc.c (xpalloc, Fgarbage_collect):
3934 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
3935 * character.c (string_escape_byte8):
3936 * charset.c (read_hex):
3937 * data.c (cons_to_unsigned):
3938 * dispnew.c (update_frame_1):
3939 * doc.c (Fsubstitute_command_keys):
3940 * doprnt.c (doprnt):
3941 * editfns.c (hi_time, decode_time_components):
3942 * fileio.c (file_offset):
3943 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
3944 * font.c (font_intern_prop):
3945 * frame.c (x_set_alpha):
3946 * gtkutil.c (get_utf8_string):
3947 * indent.c (check_display_width):
3948 * keymap.c (Fkey_description):
3949 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
3950 * lread.c (read1):
3951 * minibuf.c (read_minibuf_noninteractive):
3952 * process.c (wait_reading_process_output):
3953 * search.c (Freplace_match):
3954 * window.c (get_phys_cursor_glyph):
3955 * xdisp.c (redisplay_internal):
3956 * xsmfns.c (smc_save_yourself_CB):
3957 Prefer < to > for range checks.
3958 * dispnew.c (sit_for): Don't mishandle NaNs.
3959 This fixes a bug introduced in the 2013-03-24 change.
3960 * editfns.c (decode_time_components): Don't hoist comparison.
3961 This fixes another bug introduced in the 2013-03-24 change.
3962
92759988
DA
39632013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
3964
3965 * frame.h (struct frame): Drop scroll_bottom_vpos
3966 member becaue all real users are dead long ago.
3967 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
3968 * xdisp.c (redisplay_internal): Adjust user.
3969
9a1971bb
GM
39702013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
3971
f38ab167
JD
3972 * nsmenu.m (showAtX:Y:for:): setLevel to
3973 NSPopUpMenuWindowLevel (Bug#13998).
3974
6d01f1fe
JD
39752013-03-30 Jan Djärv <jan.h.d@swipnet.se>
3976
3977 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
3978 (ns_check_pending_open_menu): Declare.
3979
3980 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
3981 (x_activate_menubar): Update the menu with title that matches
3982 ns_get_pending_menu_title, and call
3983 ns_check_pending_openmenu (Bug#12698).
3984 (menuWillOpen:): New method.
3985 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
3986
3987 * nsterm.m (menu_will_open_state, menu_mouse_point)
3988 (menu_pending_title): New varaibles.
3989 (ns_get_pending_menu_title, ns_check_menu_open)
3990 (ns_check_pending_open_menu): New functions.
3991
781f4782
DA
39922013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
3993
3994 * indent.c (current_column_bol_cache): Remove leftover which is not
3995 used in Fmove_to_column any more.
3996 (current_column, scan_for_column): Adjust users.
3997 * keyboard.c (last_point_position_buffer, last_point_position_window):
3998 Remove leftovers which are not used for recording undo any more.
3999 (command_loop_1, syms_of_keyboard): Adjust users.
4000 * xdisp.c (last_max_ascent): Remove leftover which is not used in
4001 redisplay_window any more.
4002 (move_it_to): Adjust user.
4003
1921c31b
JB
40042013-03-29 Juanma Barranquero <lekktu@gmail.com>
4005
4006 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
4007 Update dependencies.
4008
717b8bcd
SM
40092013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4010
4011 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
4012 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
4013 forward references.
4014
e74aeda8
DA
40152013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
4016
4017 * window.h (struct window): Replace hchild, vchild and buffer slots
4018 with the only contents slot. This is possible because each valid
4019 window may have either the child window (in vertical or horizontal
4020 combination) or buffer to display (for the leaf window). Using that,
4021 a lof of operations to traverse and/or change window hierarchies may
4022 be simplified. New member horizontal is used to distinguish between
4023 horizontal and vertical combinations of internal windows.
4024 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
4025 (WINDOW_VERTICAL_COMBINATION_P): New macros.
4026 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
4027 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
4028 Use contents slot, not buffer, where appropriate.
4029 (wset_combination): New function.
4030 (wset_buffer): Add eassert.
4031 (Fframe_first_window): Simplify the loop reaching first window.
4032 (Fwindow_buffer): Use WINDOW_LEAF_P.
4033 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
4034 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
4035 (unshow_buffer): Convert initial debugging check to eassert.
4036 (replace_window, recombine_windows, Fdelete_other_windows_internal)
4037 (make_parent_window, window_resize_check, window_resize_apply)
4038 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
4039 (Fset_window_configuration, delete_all_child_windows, save_window_save):
4040 Adjust to match struct window changes.
4041 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
4042 (mark_window_cursors_off, count_windows, get_leaf_windows)
4043 (foreach_window_1): Simplify the loop.
4044 * alloc.c (mark_object): Do not check for the leaf window because
4045 internal windows has no glyph matrices anyway.
4046 * dispnew.c (clear_window_matrices, showing_window_margins_p)
4047 (allocate_matrices_for_window_redisplay, fake_current_matrices)
4048 (allocate_matrices_for_frame_redisplay, free_window_matrices)
4049 (build_frame_matrix_from_window_tree, mirror_make_current)
4050 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
4051 (update_window_tree, set_window_update_flags): Simplify the loop.
4052 (sync_window_with_frame_matrix_rows): Enforce live window.
4053 Use contents slot, not buffer, where appropriate.
4054 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
4055 and WINDOW_HORIZONTAL_COMBINATION_P.
4056 (make_frame_visible_1): Simplify the loop.
4057 Use contents slot, not buffer, where appropriate.
4058 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
4059 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
4060 (expose_window_tree): Likewise.
4061 Use contents slot, not buffer, where appropriate.
4062 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
4063 to avoid deleted windows. Use contents slot instead of buffer.
4064 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
4065 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
4066 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
4067 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
4068
121ab1cd
EZ
40692013-03-28 Eli Zaretskii <eliz@gnu.org>
4070
ef454cf7
EZ
4071 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
4072 identify the reasons for assertion violations in bug#14062 and
4073 similar ones.
21e930f8
EZ
4074 (Fx_show_tip): Fix compilation error under
4075 "--enable-check-lisp-object-type". (Bug#14073)
ef454cf7 4076
121ab1cd
EZ
4077 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
4078 Reported by <rzl24ozi@gmail.com>.
4079
5c89ca24
DA
40802013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
4081
4082 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
4083 start marker...
562c6ee9
SM
4084 (unwind_with_echo_area_buffer): ...to restore it here.
4085 This is needed to ensure that...
5c89ca24
DA
4086 (redisplay_window): ...both window markers are valid here,
4087 which is verified by eassert.
4088 * editfns.c (save_excursion_save): Do not assume that
4089 selected_window always displays the buffer.
c7f53895
DA
4090 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
4091 Fix comment.
5c89ca24 4092
f557c1b1
SM
40932013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
4094
4095 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
4096 the upcase table.
4097
40693bba 40982013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
4099
4100 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
4101
c86f791f
EZ
41022013-03-27 Eli Zaretskii <eliz@gnu.org>
4103
4104 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
4105 since MinGW's w32api headers do. This avoids compiler warnings.
4106
4107 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
4108 if already defined.
4109
c6e72e17
EZ
41102013-03-26 Eli Zaretskii <eliz@gnu.org>
4111
4112 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
4113
54e95010
JD
41142013-03-26 Jan Djärv <jan.h.d@swipnet.se>
4115
4116 * gtkutil.c (style_changed_cb): Check if frame is live and an
4117 X frame (Bug#14038).
4118
b88b62de
EZ
41192013-03-26 Eli Zaretskii <eliz@gnu.org>
4120
a18d7de6
EZ
4121 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
4122 Define only for _WIN32_WINNT less than 0x0500.
da9dcbb8
EZ
4123 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
4124 MinGW64.
8f5e14c8
EZ
4125 Move inclusion of time.h before sys/time.h, so that MinGW64 could
4126 see its own definitions of 'struct timeval' and 'struct timezone'.
a18d7de6 4127
b88b62de
EZ
4128 Fix incompatibilities between MinGW.org and MinGW64 headers.
4129 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
4130
4131 * w32.c (REPARSE_DATA_BUFFER): Guard with
4132 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
4133
c074e458
JD
41342013-03-25 Jan Djärv <jan.h.d@swipnet.se>
4135
4136 * xterm.c: Include X11/XKBlib.h
4137 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
4138
908589fd
AS
41392013-03-24 Andreas Schwab <schwab@linux-m68k.org>
4140
4141 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
4142 written backwards.
4143 * blockinput.h (input_blocked_p): Likewise.
4144 * bytecode.c (exec_byte_code): Likewise.
4145 * callproc.c (call_process_kill, call_process_cleanup)
4146 (Fcall_process): Likewise.
4147 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
4148 (Fccl_execute_on_string): Likewise.
4149 * character.c (string_escape_byte8): Likewise.
4150 * charset.c (read_hex): Likewise.
4151 * cm.c (calccost): Likewise.
4152 * data.c (cons_to_unsigned): Likewise.
4153 * dired.c (directory_files_internal, file_name_completion):
4154 Likewise.
4155 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
4156 (sit_for): Likewise.
4157 * doc.c (Fsubstitute_command_keys): Likewise.
4158 * doprnt.c (doprnt): Likewise.
4159 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
4160 * emacsgtkfixed.c: Likewise.
4161 * fileio.c (file_offset, Fwrite_region): Likewise.
4162 * floatfns.c (Fexpt, fmod_float): Likewise.
4163 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
4164 Likewise.
4165 * font.c (font_intern_prop): Likewise.
4166 * frame.c (x_set_alpha): Likewise.
4167 * gtkutil.c (get_utf8_string): Likewise.
4168 * indent.c (check_display_width): Likewise.
4169 * intervals.c (create_root_interval, rotate_right, rotate_left)
4170 (split_interval_right, split_interval_left)
4171 (adjust_intervals_for_insertion, delete_node)
4172 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4173 (merge_interval_right, merge_interval_left, copy_intervals)
4174 (set_intervals_multibyte_1): Likewise.
4175 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
4176 * keymap.c (Fkey_description): Likewise.
4177 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
4178 * lread.c (openp, read_integer, read1, string_to_number):
4179 Likewise.
4180 * menu.c (ensure_menu_items): Likewise.
4181 * minibuf.c (read_minibuf_noninteractive): Likewise.
4182 * print.c (printchar, strout): Likewise.
4183 * process.c (create_process, Faccept_process_output)
4184 (wait_reading_process_output, read_process_output, send_process)
4185 (wait_reading_process_output): Likewise.
4186 * profiler.c (make_log, handle_profiler_signal): Likewise.
4187 * regex.c (re_exec): Likewise.
4188 * regex.h: Likewise.
4189 * search.c (looking_at_1, Freplace_match): Likewise.
4190 * sysdep.c (get_child_status, procfs_ttyname)
4191 (procfs_get_total_memory): Likewise.
4192 * systime.h (EMACS_TIME_VALID_P): Likewise.
4193 * term.c (dissociate_if_controlling_tty): Likewise.
4194 * window.c (get_phys_cursor_glyph): Likewise.
4195 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
4196 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
4197 Likewise.
4198 * xfns.c (Fx_window_property): Likewise.
4199 * xmenu.c (set_frame_menubar): Likewise.
4200 * xselect.c (x_get_window_property, x_handle_dnd_message):
4201 Likewise.
4202 * xsmfns.c (smc_save_yourself_CB): Likewise.
4203 * xterm.c (x_scroll_bar_set_handle): Likewise.
4204
2bf7d27a
DA
42052013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
4206
4207 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
4208 to be optional or nil. Adjust comment and convert it to docstring.
4209 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
4210 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
4211
a9ebfa0b
PE
42122013-03-24 Paul Eggert <eggert@cs.ucla.edu>
4213
4214 Static checking by GCC 4.8-20130319.
4215 * image.c (gif_load): Assume pass < 3 to pacify GCC.
4216 * process.c (Fset_process_datagram_address)
4217 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
4218 * xdisp.c (get_char_face_and_encoding):
4219 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
4220 (get_glyph_face_and_encoding): Prepare face before possibly using it.
4221 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
4222
4f3576ee
KB
42232013-03-24 Ken Brown <kbrown@cornell.edu>
4224
789b5e9a
KB
4225 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
4226 fix compilation on 64-bit Cygwin, where underscores are not
4227 automatically prepended.
4228
4f3576ee
KB
4229 * w32term.c (w32_initialize): Silence compiler warning.
4230
b5b7745f
EZ
42312013-03-23 Eli Zaretskii <eliz@gnu.org>
4232
cdc0d0bd
EZ
4233 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
4234 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
562c6ee9
SM
4235 variables, to save and restore frame dimensions.
4236 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
4237 after returning from a 'fullscreen' configuration.
4238 use SendMessage instead of PostMessage to send the SC_RESTORE message,
cdc0d0bd
EZ
4239 to avoid races between the main thread and the input thread.
4240
4241 * w32term.h (struct w32_output): New members normal_width,
4242 normal_height, normal_top, normal_left, and prev_fsmode.
4243 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
4244 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
4245 members of a frame.
4246
b5b7745f
EZ
4247 * w32term.c (w32fullscreen_hook): Record last value of the frame's
4248 'fullscreen' parameter. Always record previous width and height
4249 of the frame, except when switching out of maximized modes, so
4250 that they could be restored correctly, instead of resetting to the
4251 default frame dimensions. Send SC_RESTORE command to the frame,
4252 unless we are going to send SC_MAXIMIZE, to restore the frame
4253 resize hints in the mouse pointer shown by the window manager.
4254 (Bug#14032)
4255
4256 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
4257
4258 * lisp.h (get_frame_param): Adjust conditions for prototype
4259 declaration.
4260
a3454eed
KB
42612013-03-22 Ken Brown <kbrown@cornell.edu>
4262
4263 * unexcw.c: Drop unneeded inclusion of w32common.h.
4264 (report_sheap_usage): Declare.
4265 (read_exe_header): Add magic numbers for x86_64.
4266 (fixup_executable): Fix printf format specifier for unsigned long
4267 argument.
4268
5a49b79c
DA
42692013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
4270
4271 * frame.h (struct frame): Put menu_bar_window under #ifdef
4272 because this member is not needed when X toolkit is in use.
4273 (fset_menu_bar_window):
4274 * dispnew.c (clear_current_matrices, clear_desired_matrices)
4275 (free_glyphs, update_frame):
4276 * xdisp.c (expose_frame): Likewise.
4277 (display_menu_bar): Likewise. Remove redundant eassert.
4278 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
4279 toolkit is in use.
4280
d6723bf7
PE
42812013-03-21 Paul Eggert <eggert@cs.ucla.edu>
4282
7b1123d8
PE
4283 Use functions and constants to manipulate Lisp_Save_Value objects.
4284 This replaces code that used macros and strings and token-pasting.
4285 The change makes the C source a bit easier to follow,
4286 and shrinks the Emacs executable a bit.
4287 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
4288 (make_save_value): Change 1st arg from string to enum. All callers
4289 changed.
4290 (INTX): Remove.
4291 (mark_object): Use if, not #if, for GC_MARK_STACK.
4292 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
4293 (XSAVE_OBJECT): Now functions, not macros.
4294 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
4295 the constant was never used.
4296 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
4297 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
4298 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
4299 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
4300 New constants.
4301 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
4302 type3 with a single member save_type. All uses changed.
4303 (save_type, set_save_pointer, set_save_integer): New functions.
4304 * print.c (PRINTX): Remove.
4305
d6723bf7
PE
4306 * alloc.c: Remove redundant static declarations.
4307
5f24fa51
DA
43082013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4309
4310 * window.h (struct window): Convert left_col, top_line, total_lines
4311 and total_cols from Lisp_Objects to integers. Adjust comments.
4312 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
4313 Remove.
4314 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
4315 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
4316 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
4317 Adjust users where appropriate.
4318
42143acd
DA
43192013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4320
4321 * frame.h (struct frame): Drop resx and resy because the same data is
4322 available from window system-specific output context. Adjust users.
562c6ee9
SM
4323 (default_pixels_per_inch_x, default_pixels_per_inch_y):
4324 New functions to provide defaults when no window system available.
42143acd 4325 (FRAME_RES_X, FRAME_RES_Y): New macros.
562c6ee9 4326 (NUMVAL): Move from xdisp.c.
42143acd
DA
4327 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
4328 (Ffont_face_attributes, Fopen_font):
4329 * image.c (gs_load):
4330 * w32font.c (fill_in_logfont):
4331 * xdisp.c (calc_pixel_width_or_height):
4332 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
4333 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
4334
c0a17406
KH
43352013-03-20 Kenichi Handa <handa@gnu.org>
4336
4337 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
4338 to 1 (temporary workaround until a bug related to ASCII
4339 optimization is fixed).
4340
095d384d
DA
43412013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
4342
4343 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
4344 Signal error if window is not internal. Adjust docstring.
4345 (delete_all_child_windows): Use combination_limit to save the buffer.
4346 (Fset_window_configuration): Adjust accordingly.
cf4bb06d
DA
4347 * print.c (syms_of_print): Initialize debugging output not here...
4348 (init_print_once): ...but in a new function here.
4349 * lisp.h (init_print_once): Add prototype.
4350 * emacs.c (main): Add call to init_print_once. Adjust comments.
095d384d 4351
748fa866
DA
43522013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
4353
4354 * window.c (window_resize_check, window_resize_apply)
4355 (window_from_coordinates, recombine_windows, set_window_buffer)
4356 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
4357 (Fsplit_window_internal, Fdelete_window_internal)
4358 (freeze_window_starts): Use bool for booleans.
4359 * window.h (window_frame_coordinates, resize_frame_windows)
4360 (freeze_window_starts, set_window_buffer): Adjust prototypes.
4361
81519fd2
SM
43622013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
4363
4364 * dispnew.c (bitch_at_user): Use `user-error'.
4365
6db423a9
KB
43662013-03-17 Ken Brown <kbrown@cornell.edu>
4367
4368 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
4369 as return type of image_background. (Bug#13981)
4370 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
4371
8f2906f5
JD
43722013-03-16 Jan Djärv <jan.h.d@swipnet.se>
4373
960ce480 4374 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 4375 (ns_select): Don't return with result uninitialized.
960ce480 4376
8f2906f5
JD
4377 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
4378 and getDirectory.
4379
81519fd2
SM
4380 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
4381 New functions.
8f2906f5
JD
4382 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
4383 directories. If filename is nil, get directory name (Bug#13932).
4384 Use getFilename and getDirectory.
4385 (getFilename, getDirectory): New methods for EmacsSavePanel and
4386 EmacsOpenPanel.
4387 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
4388
cded56c1
PE
43892013-03-15 Paul Eggert <eggert@cs.ucla.edu>
4390
4391 * coding.c (decode_coding_gap): Fix typo caught by static checking.
4392
251e9147 43932013-03-15 Kenichi Handa <handa@gnu.org>
8a44e6d1
KH
4394
4395 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
4396 (adjust_after_replace): Make it back to static. Delete the third
4397 arg text_at_gap_tail. Cancel the code for handling it.
4398
4399 * coding.h (struct coding_system): New member eol_seen.
4400
4401 * coding.c (detect_ascii): New function.
4402 (detect_coding): Set coding->head_ascii and coding->eol_seen only
4403 when the source bytes are actually scanned. On detecting for
4404 coding_category_utf_8_auto, call detect_ascii instead of scanning
4405 source bytes directly.
4406 (produce_chars): Call insert_from_gap with the new arg 0.
4407 (encode_coding): Likewise.
4408 (decode_coding_gap): Control ASCII optimization by the variable
4409 disable_ascii_optimization instead of #ifndef .. #endif.
4410 Deccode EOL format according to coding->eol_seen.
4411 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
4412 variable.
4413
8a44e6d1
KH
4414 * lisp.h (adjust_after_replace): Cancel externing it.
4415 (insert_from_gap): Adjust prototype.
4416
5f795e34
EZ
44172013-03-15 Eli Zaretskii <eliz@gnu.org>
4418
4419 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
4420 FULLSCREEN_MAXIMIZED. (Bug#13935)
4421
f258b4be
DA
44222013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
4423
4424 * region-cache.c (find_cache_boundary, move_cache_gap)
4425 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
4426 Simplify debugging check and convert to eassert. Adjust comment.
4427 (pp_cache): Put under ENABLE_CHECKING.
4428
a5cc4dde
EZ
44292013-03-14 Eli Zaretskii <eliz@gnu.org>
4430
4431 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
4432 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
4433 and WM_ACTIVATEAPP.
4434 (w32fullscreen_hook): If the frame is visible, reset
4435 f->want_fullscreen flag after changing the frame size. If the
4436 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
4437 (Bug#13953)
4438
3fc5e44a
DC
44392013-03-13 Daniel Colascione <dancol@dancol.org>
4440
4441 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
4442 too so that these builds can use Cygwin's file conversion
4443 functions. (We've been building and linking cygw32.o all along
4444 and just not using it.)
4445
47d7532e
PE
44462013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4447
4448 File synchronization fixes (Bug#13944).
4449 * Makefile.in (LIB_FDATASYNC): New macro.
4450 (LIBES): Use it.
4451 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
4452 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
4453 Don't worry about HAVE_FSYNC, since a substitute fsync is
4454 available if the system lacks one.
4455 (Fwrite_regin): Retry fsync if interrupted.
4456
c7ffccaf
EZ
44572013-03-13 Eli Zaretskii <eliz@gnu.org>
4458
4e2df81d 4459 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
4460 activated, call w32fullscreen_hook, to make sure the new frame
4461 dimensions are in effect. (Bug#13937)
4462
8a7debc1
DA
44632013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
4464
4465 * xdisp.c (init_iterator): Simplify because both character and byte
4466 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
4467 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
4468 character and byte positions can be obtained from marker.
8a7debc1 4469
7fd8c501
PE
44702013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4471
d9df6f40
PE
4472 Static checking by Sun C 5.12.
4473 * alloc.c (buffer_memory_full) [REL_ALLOC]:
4474 * bytecode.c (exec_byte_code):
4475 * dispnew.c (init_display):
4476 * eval.c (error):
4477 * fileio.c (Fsubstitute_in_file_name):
4478 * keyboard.c (Fevent_convert_list):
4479 * keymap.c (Fsingle_key_description):
4480 * term.c (maybe_fatal, fatal):
4481 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
4482 * xsmfns.c (Fhandle_save_session):
4483 Omit unreachable code.
4484 * keymap.c (map_keymap_char_table_item): Cast void * to
4485 a function pointer type; the C Standard requires this.
4486
7fd8c501
PE
4487 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
4488 Include <sys/param.h> unconditionally, as that works elsewhere and
4489 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
4490 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
4491 and FreeBSD now.
4492
a020afb9 4493See ChangeLog.12 for earlier changes.
aac0c6e3
MR
4494
4495;; Local Variables:
4496;; coding: utf-8
aac0c6e3
MR
4497;; End:
4498
ab422c4d 4499 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
4500
4501 This file is part of GNU Emacs.
4502
4503 GNU Emacs is free software: you can redistribute it and/or modify
4504 it under the terms of the GNU General Public License as published by
4505 the Free Software Foundation, either version 3 of the License, or
4506 (at your option) any later version.
4507
4508 GNU Emacs is distributed in the hope that it will be useful,
4509 but WITHOUT ANY WARRANTY; without even the implied warranty of
4510 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4511 GNU General Public License for more details.
4512
4513 You should have received a copy of the GNU General Public License
4514 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.