* fileio.c: Add FIXMES mentioning Bug#8496.
[bpt/emacs.git] / src / ChangeLog
... / ...
CommitLineData
12011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2
3 * sysdep.c (croak): Now static, if
4 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5 * syssignal.h (croak): Declare only if not static.
6
7 * alloc.c (refill_memory_reserve): Now static if
8 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9 * lisp.h (refill_memory_reserve): Declare only if not static.
10
11 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12 Define only if USE_LUCID.
13
14 * xrdb.c (x_customization_string, x_rm_string): Now static.
15
16 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
17 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
18
19 * xdisp.c (draw_row_with_mouse_face): Now static.
20 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
21
22 * window.h (check_all_windows): Mark externally visible.
23
24 * window.c (window_deletion_count): Now static.
25
26 * undo.c: Make symbols static if they're not exported.
27 (last_undo_buffer, last_boundary_position, pending_boundary):
28 Now static.
29
30 * textprop.c (interval_insert_behind_hooks): Now static.
31 (interval_insert_in_front_hooks): Likewise.
32
33 * term.c: Make symbols static if they're not exported.
34 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
35 (max_frame_lines, tty_set_terminal_modes):
36 (tty_reset_terminal_modes, tty_turn_off_highlight):
37 (get_tty_terminal): Now static.
38 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
39 * termhooks.h (term_mouse_moveto): Do not declare if
40 HAVE_WINDOW_SYSTEMM.
41 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
42 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
43
44 * sysdep.c: Make symbols static if they're not exported.
45 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
46 Now static.
47 (sigprocmask_set, full_mask): Remove; unused.
48 (wait_debugging): Mark as visible.
49 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
50 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
51
52 * syntax.c (syntax_temp): Define only if !__GNUC__.
53
54 * sound.c (current_sound_device, current_sound): Now static.
55
56 * search.c (searchbufs, searchbuf_head): Now static.
57
58 * scroll.c (scroll_cost): Remove; unused.
59 * dispextern.h (scroll_cost): Remove decl.
60
61 * region-cache.h (pp_cache): Mark as externally visible.
62
63 * process.c: Make symbols static if they're not exported.
64 (process_tick, update_tick, create_process, chan_process):
65 (Vprocess_alist, proc_buffered_char, datagram_access):
66 (fd_callback_data, send_process_frame, process_sent_to): Now static.
67 (deactivate_process): Mark defn as static, as well as decl.
68 * lisp.h (create_process): Remove decl.
69 * process.h (chan_process, Vprocess_alist): Remove decls.
70
71 * print.c: Make symbols static if they're not exported.
72 (print_depth, new_backquote_output, being_printed, print_buffer):
73 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
74 (print_interval, print_number_index, initial_stderr_stream):
75 Now static.
76 * lisp.h (Fprinc): Remove decl.
77 (debug_output_compilation_hack): Mark as externally visible.
78
79 * sysdep.c (croak): Move decl from here to syssignal.h.
80 * syssignal.h (croak): Put it here, so the API can be checked when
81 'croak' is called from dissociate_if_controlling_tty.
82
83 * minibuf.c: Make symbols static if they're not exported.
84 (minibuf_save_list, choose_minibuf_frame): Now static.
85 * lisp.h (choose_minibuf_frame): Remove decl.
86
87 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
88
89 * lread.c: Make symbols static if they're not exported.
90 (read_objects, initial_obarray, oblookup_last_bucket_number):
91 Now static.
92 (make_symbol): Remove; unused.
93 * lisp.h (initial_obarray, make_symbol): Remove decls.
94
95 * keyboard.c: Make symbols static if they're not exported.
96 (single_kboard, recent_keys_index, total_keys, recent_keys):
97 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
98 (this_single_command_key_start, echoing, last_auto_save):
99 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
100 (command_loop, echo_now, keyboard_init_hook, help_char_p):
101 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
102 (Vlispy_mouse_stem, double_click_count):
103 Now static.
104 (force_auto_save_soon): Define only if SIGDANGER.
105 (ignore_mouse_drag_p): Now static if
106 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
107 (print_help): Remove; unused.
108 (stop_character, last_timer_event): Mark as externally visible.
109 * keyboard.h (ignore_mouse_drag_p): Declare only if
110 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
111 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
112 * lisp.h (echoing): Remove decl.
113 (force_auto_save_soon): Declare only if SIGDANGER.
114 * xdisp.c (redisplay_window): Simplify code, to make it more
115 obvious that ignore_mouse_drag_p is not accessed if !defined
116 USE_GTK && !defined HAVE_NS.
117
118 * intervals.c: Make symbols static if they're not exported.
119 (merge_properties_sticky, merge_interval_right, delete_interval):
120 Now static.
121 * intervals.h (merge_interval_right, delete_interval): Remove decls.
122
1232011-04-13 Paul Eggert <eggert@cs.ucla.edu>
124
125 * insdel.c: Make symbols static if they're not exported.
126 However, leave prepare_to_modify_buffer alone. It's never
127 called from outside this function, but that appears to be a bug.
128 (combine_after_change_list, combine_after_change_buffer):
129 (adjust_after_replace, signal_before_change): Now static.
130 (adjust_after_replace_noundo): Remove; unused.
131 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
132 (signal_before_change): Remove decls.
133
134 * indent.c (val_compute_motion, val_vmotion): Now static.
135
136 * image.c: Make symbols static if they're not exported.
137 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
138 if USE_GTK.
139 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
140 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
141
142 * fringe.c (standard_bitmaps): Now static.
143 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
144
145 * frame.c: Make symbols static if they're not exported.
146 (x_report_frame_params, make_terminal_frame): Now static.
147 (get_frame_param): Now static, unless HAVE_NS.
148 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
149 (x_get_resource_string): Remove; not used.
150 * frame.h (make_terminal_frame, x_report_frame_params):
151 (x_get_resource_string); Remove decls.
152 (x_fullscreen_adjust): Declare only if WINDOWSNT.
153 * lisp.h (get_frame_param): Declare only if HAVE_NS.
154
155 * font.c, fontset.c: Make symbols static if they're not exported.
156 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
157 (FACE_SUITABLE_FOR_CHAR_P): Use it.
158 * font.c (font_close_object): Now static.
159 * font.h (font_close_object): Remove.
160 * fontset.c (FONTSET_OBJLIST): Remove.
161 (free_realized_fontset) #if-0 the body, which does nothing.
162 (face_suitable_for_char_p): #if-0, as it's never called.
163 * fontset.h (face_suitable_for_char_p): Remove decl.
164 * xfaces.c (face_at_string_position): Use
165 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
166 since 0 is always ASCII.
167
168 * fns.c (weak_hash_tables): Now static.
169
170 * fileio.c: Make symbols static if they're not exported.
171 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
172 (Vwrite_region_annotation_buffers): Now static.
173
174 * eval.c: Make symbols static if they're not exported.
175 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
176 * lisp.h (backtrace_list): Remove decl.
177
178 * emacs.c: Make symbols static if they're not exported.
179 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
180 (fatal_error_code, fatal_error_signal_hook, standard_args):
181 Now static.
182 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
183 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
184 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
185 * lisp.h (fatal_error_signal_hook): Remove decl.
186 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
187
188 * editfns.c: Move a (normally-unused) function to its only use.
189 * editfns.c, lisp.h (get_operating_system_release): Remove.
190 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
191 worth the hassle of breaking this out.
192
193 * xterm.c: Make symbols static if they're not exported.
194 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
195 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
196 (x_destroy_window, x_delete_display):
197 Now static.
198 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
199 (x_mouse_leave): Remove; unused.
200 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
201 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
202 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
203 Remove decls.
204 (x_mouse_leave): Declare only if WINDOWSNT.
205 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
206 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
207 USE_X_TOOLKIT.
208
2092011-04-12 Paul Eggert <eggert@cs.ucla.edu>
210
211 * ftxfont.c: Make symbols static if they're not exported.
212 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
213 HAVE_FREETYPE.
214 * font.h (ftxfont_driver): Likewise.
215
216 * xfns.c: Make symbols static if they're not exported.
217 (x_last_font_name, x_display_info_for_name):
218 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
219 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
220 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
221 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
222 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
223 (last_show_tip_args): Now static.
224 (xic_defaut_fontset, xic_create_fontsetname): Define only if
225 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
226 (x_screen_planes): Remove; unused.
227 * dispextern.h (x_screen_planes): Remove decl.
228
229 * dispnew.c: Make symbols static if they're not exported.
230 * dispextern.h (redraw_garbaged_frames, scrolling):
231 (increment_row_positions): Remove.
232 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
233 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
234 Now static.
235 (redraw_garbaged_frames): Remove; unused.
236
237 * xfaces.c: Make symbols static if they're not exported.
238 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
239 Remove decls.
240 * xterm.h (defined_color): Remove decls.
241 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
242 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
243 (menu_face_changed_default, defined_color, free_realized_face):
244 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
245 (ascii_face_of_lisp_face): Remove; unused.
246
247 * xdisp.c: Make symbols static if they're not exported.
248 * dispextern.h (scratch_glyph_row, window_box_edges):
249 (glyph_to_pixel_coords, set_cursor_from_row):
250 (get_next_display_element, set_iterator_to_next):
251 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
252 (show_mouse_face): Remove decls
253 * frame.h (message_buf_print): Likewise.
254 * lisp.h (pop_message, set_message, check_point_in_composition):
255 Likewise.
256 * xterm.h (set_vertical_scroll_bar): Likewise.
257 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
258 (message_buf_print, scratch_glyph_row, displayed_buffer):
259 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
260 (get_next_display_element, show_mouse_face, window_box_edges):
261 (frame_to_window_pixel_xy, check_point_in_composition):
262 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
263 (glyph_to_pixel_coords): Remove; unused.
264
265 * dired.c (file_name_completion): Now static.
266
267 * dbusbind.c (xd_in_read_queued_messages): Now static.
268
269 * lisp.h (circular_list_error, FOREACH): Remove; unused.
270 * data.c (circular_list_error): Remove.
271
2722011-04-11 Paul Eggert <eggert@cs.ucla.edu>
273
274 * commands.h (last_point_position, last_point_position_buffer):
275 (last_point_position_window): Remove decls.
276 * keyboard.c: Make these variables static.
277
278 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
279 decls.
280 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
281 (iso_code_class, detect_coding, code_convert_region): Now static.
282 (encode_coding_gap): Remove; unused.
283
284 * chartab.c (chartab_chars, chartab_bits): Now static.
285
286 * charset.h (charset_iso_8859_1): Remove decl.
287 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
288 Now static.
289
290 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
291 * ccl.c (Vccl_program_table): Now static.
292 (check_ccl_update): Remove; unused.
293
294 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
295 * category.h: ... from here.
296 * category.c (check_category_table, set_category_set): Now static.
297
298 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
299 * lisp.h: Remove these decls.
300
301 * buffer.c (buffer_count): Remove unused var.
302
303 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
304 so that it's not optimized away.
305 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
306 * dispextern.h (bidi_dump_cached_states): Remove, since it's
307 exported only to the debugger.
308
309 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
310 * atimer.h (run_all_atimers): Removed; not exported.
311
312 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
313 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
314 was inaccessible from Lisp.
315 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
316 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
317
318 alloc.c: Import and export fewer symbols, and remove unused items.
319 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
320 is defined.
321 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
322 it's not optimized away by whole-program optimization.
323 (message_enable_multibyte, free_misc): Remove.
324 (catchlist, handlerlist, mark_backtrace):
325 Declare only if BYTE_MARK_STACK.
326 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
327 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
328 (message_enable_multibyte): Remove decl.
329 (free_misc, interval_free_list, float_block, float_block_index):
330 (n_float_blocks, float_free_list, cons_block, cons_block_index):
331 (cons_free_list, last_marked_index):
332 Now static.
333 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
334 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
335 (mark_backtrace): Define only if BYTE_MARK_STACK.
336 * xdisp.c (message_enable_multibyte): Now static.
337
338 Declare Lisp_Object Q* variables to be 'static' if not exproted.
339 This makes it easier for human readers (and static analyzers)
340 to see whether these variables are used from other modules.
341 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
342 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
343 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
344 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
345 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
346 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
347 * xmenu.c, xselect.c:
348 Declare Q* vars static if they are not used in other modules.
349 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
350 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
351 Remove decls of unexported vars.
352 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
353
354 * lisp.h (DEFINE_FUNC): Make sname 'static'.
355
356 Make Emacs functions such as Fatom 'static' by default.
357 This makes it easier for human readers (and static analyzers)
358 to see whether these functions can be called from other modules.
359 DEFUN now defines a static function. To make the function external
360 so that it can be used in other C modules, use the new macro DEFUE.
361 * lisp.h (DEFINE_FUNC): New macro, with the old contents of DEFUN.
362 (DEFUN): Rewrite in terms of DEFINE_FUNC. It now generates a
363 static function definition. Use DEFUE if you want an extern one.
364 (DEFUE, INFUN): New macros.
365 (Funibyte_char_to_multibyte, Fsyntax_table_p, Finit_image_library):
366 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
367 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
368 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
369 Remove decls, since these functions are now static.
370 (Funintern, Fget_internal_run_time): New decls, since these functions
371 were already external.
372
373 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
374 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
375 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
376 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
377 * keyboard.c, keymap.c, lread.c:
378 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
379 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
380 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
381 Mark functions with DEFUE instead of DEFUN,
382 if they are used in other modules.
383 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
384 decls for now-static functions.
385 * buffer.h (Fdelete_overlay): Remove decl.
386 * callproc.c (Fgetenv_internal): Mark as internal.
387 * composite.c (Fremove_list_of_text_properties): Remove decl.
388 (Fcomposition_get_gstring): New forward static decl.
389 * composite.h (Fcomposite_get_gstring): Remove decl.
390 * dired.c (Ffile_attributes): New forward static decl.
391 * doc.c (Fdocumntation_property): New forward static decl.
392 * eval.c (Ffetch_bytecode): New forward static decl.
393 (Funintern): Remove extern decl; now in .h file where it belongs.
394 * fileio.c (Fmake_symbolic_link): New forward static decl.
395 * image.c (Finit_image_library): New forward static decl.
396 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
397 * intervals.h (Fprevious_property_change):
398 (Fremove_list_of_text_properties): Remove decls.
399 * keyboard.c (Fthis_command_keys): Remove decl.
400 (Fcommand_execute): New forward static decl.
401 * keymap.c (Flookup_key): New forward static decl.
402 (Fcopy_keymap): Now static.
403 * keymap.h (Flookup_key): Remove decl.
404 * process.c (Fget_process): New forward static decl.
405 (Fprocess_datagram_address): Mark as internal.
406 * syntax.c (Fsyntax_table_p): New forward static decl.
407 (skip_chars): Remove duplicate decl.
408 * textprop.c (Fprevious_property_change): New forward static decl.
409 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
410 Now internal.
411 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
412 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
413
4142011-04-10 Paul Eggert <eggert@cs.ucla.edu>
415
416 * editfns.c (Fformat): Remove unreachable code.
417
4182011-04-10 Paul Eggert <eggert@cs.ucla.edu>
419
420 Fix more problems found by GCC 4.6.0's static checks.
421
422 * xdisp.c (vmessage): Use a better test for character truncation.
423
424 * charset.c (load_charset_map): <, not <=, for optimization,
425 and to avoid potential problems with integer overflow.
426 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
427 * casetab.c (set_identity, shuffle): Likewise.
428 * editfns.c (Fformat): Likewise.
429 * syntax.c (skip_chars): Likewise.
430
431 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
432 This also lets GCC 4.6.0 generate slightly better loop code.
433
434 * callint.c (Fcall_interactively): <, not <=, for optimization.
435 (Fcall_interactively): Count the number of arguments produced,
436 not the number of arguments given. This is simpler and lets GCC
437 4.6.0 generate slightly better code.
438
439 * ftfont.c: Distingish more carefully between FcChar8 and char.
440 The previous code passed unsigned char * to a functions like
441 strlen and xstrcasecmp that expect char *, which does not
442 conform to the C standard.
443 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
444 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
445 char * when the C standard requires it.
446
447 * keyboard.c (read_char): Remove unused var.
448
449 * eval.c: Port to Windows vsnprintf (Bug#8435).
450 Include <limits.h>.
451 (SIZE_MAX): Define if the headers do not.
452 (verror): Do not give up if vsnprintf returns a negative count.
453 Instead, grow the buffer. This ports to Windows vsnprintf, which
454 does not conform to C99. Problem reported by Eli Zaretskii.
455 Also, simplify the allocation scheme, by avoiding the need for
456 calling realloc, and removing the ALLOCATED variable.
457
458 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
459
460 Remove invocations of doprnt, as Emacs now uses vsnprintf.
461 But keep the doprint source code for now, as we might revamp it
462 and use it again (Bug#8435).
463 * lisp.h (doprnt): Remove.
464 * Makefile.in (base_obj): Remove doprnt.o.
465 * deps.mk (doprnt.o): Remove.
466
467 error: Print 32- and 64-bit integers portably (Bug#8435).
468 Without this change, on typical 64-bit hosts error ("...%d...", N)
469 was used to print both 32- and 64-bit integers N, which relied on
470 undefined behavior.
471 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
472 New macro.
473 * lisp.h (error, verror): Mark as printf-like functions.
474 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
475 Report overflow in size calculations when allocating printf buffer.
476 Do not truncate output string at its first null byte.
477 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
478 Truncate the output at a character boundary, since vsnprintf does not
479 do that.
480 * charset.c (check_iso_charset_parameter): Convert internal
481 character to string before calling 'error', since %c now has the
482 printf meaning.
483 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
484 overflow when computing char to be passed to 'error'. Do not
485 pass Lisp_Object to 'error'; pass the integer instead.
486 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
487 formatted with plain %d.
488
489 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
490
491 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
492
493 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
494
495 * xterm.c (x_catch_errors): Remove duplicate declaration.
496
497 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
498
499 * xdisp.c, lisp.h (message_nolog): Remove; unused.
500
5012011-04-10 Jim Meyering <meyering@redhat.com>
502
503 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
504 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
505 return ssize_t not "int", and use size_t as the buffer length.
506 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
507 * gnutls.h: Update declarations.
508 * process.c (read_process_output): Use ssize_t, to match.
509 (send_process): Likewise.
510
5112011-04-09 Chong Yidong <cyd@stupidchicken.com>
512
513 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
514
5152011-04-09 Chong Yidong <cyd@stupidchicken.com>
516
517 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
518 unsigned char, to match FcChar8 type definition.
519
520 * xterm.c (handle_one_xevent):
521 * xmenu.c (create_and_show_popup_menu):
522 * xselect.c (x_decline_selection_request)
523 (x_reply_selection_request): Avoid type-punned deref of X events.
524
5252011-04-09 Eli Zaretskii <eliz@emacstest.gnu.org>
526
527 Fix some uses of `int' instead of EMACS_INT.
528 * search.c (string_match_1, fast_string_match)
529 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
530 (scan_buffer, find_next_newline_no_quit)
531 (find_before_next_newline, search_command, Freplace_match)
532 (Fmatch_data): Make some `int' variables be EMACS_INT.
533
534 * xdisp.c (display_count_lines): 3rd argument and return value now
535 EMACS_INT. All callers changed.
536 (pint2hrstr): Last argument is now EMACS_INT.
537
538 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
539 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
540 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
541 (decode_coding_utf_16, decode_coding_emacs_mule)
542 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
543 (decode_coding_ccl, decode_coding_charset)
544 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
545 (decode_coding_iso_2022, decode_coding_emacs_mule)
546 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
547 <char_offset, last_offset>: Declare EMACS_INT.
548 (encode_coding_utf_8, encode_coding_utf_16)
549 (encode_coding_emacs_mule, encode_invocation_designation)
550 (encode_designation_at_bol, encode_coding_iso_2022)
551 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
552 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
553 Declare EMACS_INT.
554 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
555 (encode_invocation_designation): Last argument P_NCHARS is now
556 EMACS_INT.
557 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
558 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
559
560 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
561 All users changed.
562
563 * ccl.c (Fccl_execute_on_string): Declare some variables
564 EMACS_INT.
565
5662011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
567
568 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
569
5702011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
571
572 * process.c (Fformat_network_address): Doc fix.
573
5742011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
575
576 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
577
5782011-04-08 Chong Yidong <cyd@stupidchicken.com>
579
580 * keyboard.c (read_char): Call Lisp function help-form-show,
581 instead of using internal_with_output_to_temp_buffer.
582 (Qhelp_form_show): New var.
583 (syms_of_keyboard): Use DEFSYM macro.
584
585 * print.c (internal_with_output_to_temp_buffer): Function deleted.
586
587 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
588
5892011-04-06 Chong Yidong <cyd@stupidchicken.com>
590
591 * process.c (Flist_processes): Removed to Lisp.
592 (list_processes_1): Deleted.
593
5942011-04-06 Eli Zaretskii <eliz@gnu.org>
595
596 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
597
598 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
599
6002011-04-06 Paul Eggert <eggert@cs.ucla.edu>
601
602 Fix more problems found by GCC 4.6.0's static checks.
603
604 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
605
606 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
607
608 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
609
610 * xdisp.c (vmessage): Mark as a printf-like function.
611
612 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
613
614 * sound.c (sound_warning): Don't crash if arg contains a printf format.
615
616 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
617 printf-like functions.
618 (tiff_load): Add casts to remove these marks before passing them
619 to system-supplied API.
620
621 * eval.c (Fsignal): Remove excess argument to 'fatal'.
622
623 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
624 This avoids several warnings with gcc -Wstrict-overflow.
625 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
626 directly, rather than having caller test rule sign. This avoids
627 some unnecessary tests.
628 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
629 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
630 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
631
632 * xfont.c (xfont_text_extents): Remove var that was set but not used.
633 (xfont_open): Avoid unnecessary tests.
634
635 * composite.c (composition_gstring_put_cache): Use unsigned integer.
636
637 * composite.h, composite.c (composition_gstring_put_cache):
638 Use EMACS_INT, not int, for length.
639
640 * composite.h (COMPOSITION_DECODE_REFS): New macro,
641 breaking out part of COMPOSITION_DECODE_RULE.
642 (COMPOSITION_DECODE_RULE): Use it.
643 * composite.c (get_composition_id): Remove unused local vars,
644 by using the new macro.
645
646 * textprop.c (set_text_properties_1): Change while to do-while,
647 since the condition is always true at first.
648
649 * intervals.c (graft_intervals_into_buffer): Mark var as used.
650 (interval_deletion_adjustment): Return unsigned value.
651 All uses changed.
652
653 * process.c (list_processes_1, create_pty, read_process_output):
654 (exec_sentinel): Remove vars that were set but not used.
655 (create_pty): Remove unnecessary "volatile"s.
656 (Fnetwork_interface_info): Avoid possibility of int overflow.
657 (read_process_output): Do adaptive read buffering even if carryover.
658 (read_process_output): Simplify nbytes computation if buffered.
659
660 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
661
662 * syntax.c (scan_words): Remove var that was set but not used.
663 (update_syntax_table): Use unsigned instead of int.
664
665 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
666 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
667 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
668
669 * print.c (print_error_message): Avoid int overflow.
670
671 * font.c (font_list_entities): Redo for clarity,
672 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
673
674 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
675 (font_score): Avoid potential overflow in diff calculation.
676
677 * fns.c (substring_both): Remove var that is set but not used.
678 (sxhash): Redo loop for clarity and to avoid wraparound warning.
679
680 * eval.c (funcall_lambda): Rename local to avoid shadowing.
681
682 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
683 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
684 can always succeed if overflow has undefined behavior.
685
686 * search.c (boyer_moore, wordify): Remove vars set but not used.
687 (wordify): Omit three unnecessary tests.
688
689 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
690 All callers changed. This avoids the need for an unused var.
691
692 * casefiddle.c (casify_region): Remove var that is set but not used.
693
694 * dired.c (file_name_completion): Remove var that is set but not used.
695
696 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
697
698 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
699 (Finsert_file_contents): Remove unnecessary code checking fd.
700
701 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
702 Check for integer overflow on size calculations.
703
704 * buffer.c (Fprevious_overlay_change): Remove var that is set
705 but not used.
706
707 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
708 Remove vars that are set but not used.
709 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
710 (timer_check_2): Mark vars as initialized.
711
712 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
713
714 * image.c (lookup_image): Remove var that is set but not used.
715 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
716
717 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
718 that are set but not used.
719
720 * xfns.c (make_invisible_cursor): Don't return garbage
721 if XCreateBitmapFromData fails (Bug#8410).
722
723 * xselect.c (x_get_local_selection, x_handle_property_notify):
724 Remove vars that are set but not used.
725
726 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
727 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
728
729 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
730 Remove var that is set but not used.
731 (scroll_bar_windows_size): Now size_t, not int.
732 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
733 Check for overflow.
734
735 * xfaces.c (realize_named_face): Remove vars that are set but not used.
736 (map_tty_color) [!defined MSDOS]: Likewise.
737
738 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
739
740 * coding.c: Remove vars that are set but not used.
741 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
742 All callers changed.
743 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
744 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
745 (decode_coding_charset): Remove vars that are set but not used.
746
747 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
748 that is set but not used.
749
750 * print.c (print_object): Remove var that is set but not used.
751
752 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
753 The gnulib version avoids calling malloc in the usual case,
754 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
755 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
756 * filelock.c (current_lock_owner): Likewise.
757 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
758 * sysdep.c: Include allocator.h, careadlinkat.h.
759 (emacs_no_realloc_allocator): New static constant.
760 (emacs_readlink): New function.
761 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
762 ../lib/careadlinkat.h.
763
7642011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
765
766 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
767 first non-nil return value).
768
7692011-04-03 Jan Djärv <jan.h.d@swipnet.se>
770
771 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
772 if not defined (Bug#8403).
773
7742011-04-02 Juanma Barranquero <lekktu@gmail.com>
775
776 * xdisp.c (display_count_lines): Remove parameter `start',
777 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
778 (get_char_face_and_encoding): Remove parameter `multibyte_p',
779 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
780 (fill_stretch_glyph_string): Remove parameters `row' and `area',
781 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
782 and thereabouts. All callers changed.
783 (get_per_char_metric): Remove parameter `f', unused since
784 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
785
7862011-04-02 Jim Meyering <meyering@redhat.com>
787
788 do not dereference NULL upon failed strdup
789 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
790 (ns_get_family): Likewise.
791
7922011-04-02 Juanma Barranquero <lekktu@gmail.com>
793
794 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
795
7962011-04-02 Jan Djärv <jan.h.d@swipnet.se>
797
798 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
799 later (Bug#8403).
800
8012011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
802
803 Add lexical binding.
804
805 * window.c (Ftemp_output_buffer_show): New fun.
806 (Fsave_window_excursion):
807 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
808
809 * lread.c (lisp_file_lexically_bound_p): New function.
810 (Fload): Bind Qlexical_binding.
811 (readevalloop): Remove `evalfun' arg.
812 Bind Qinternal_interpreter_environment.
813 (Feval_buffer): Bind Qlexical_binding.
814 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
815 Mark as dynamic.
816 (syms_of_lread): Declare `lexical-binding'.
817
818 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
819
820 * keyboard.c (eval_dyn): New fun.
821 (menu_item_eval_property): Use it.
822
823 * image.c (parse_image_spec): Use Ffunctionp.
824
825 * fns.c (concat, mapcar1): Accept byte-code-functions.
826
827 * eval.c (Fsetq): Handle lexical vars.
828 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
829 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
830 (FletX, Flet): Obey lexical binding.
831 (Fcommandp): Handle closures.
832 (Feval): New `lexical' arg.
833 (eval_sub): New function extracted from Feval. Use it almost
834 everywhere where Feval was used. Look up vars in lexical env.
835 Handle closures.
836 (Ffunctionp): Move from subr.el.
837 (Ffuncall): Handle closures.
838 (apply_lambda): Remove `eval_flags'.
839 (funcall_lambda): Handle closures and new byte-code-functions.
840 (Fspecial_variable_p): New function.
841 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
842 but without exporting it to Lisp.
843
844 * doc.c (Fdocumentation, store_function_docstring):
845 * data.c (Finteractive_form): Handle closures.
846
847 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
848 interactive spec.
849
850 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
851 byte-codes.
852 (exec_byte_code): New function extracted from Fbyte_code to handle new
853 calling convention for byte-code-functions. Add new byte-codes.
854
855 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
856
857 * alloc.c (Fmake_symbol): Init new `declared_special' field.
858
8592011-03-31 Juanma Barranquero <lekktu@gmail.com>
860
861 * xdisp.c (redisplay_internal): Fix prototype.
862
8632011-03-31 Eli Zaretskii <eliz@gnu.org>
864
865 * xdisp.c (SCROLL_LIMIT): New macro.
866 (try_scrolling): Use it when setting scroll_limit. Limit
867 scrolling to 100 screen lines.
868 (redisplay_window): Even when falling back on "recentering",
869 position point in the window according to scroll-conservatively,
870 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
871
872 (try_scrolling): When point is above the window, allow searching
873 as far as scroll_max, or one screenful, to compute vertical
874 distance from PT to the scroll margin position. This prevents
875 try_scrolling from unnecessarily failing when
876 scroll-conservatively is set to a value slightly larger than the
877 window height. Clean up the case of PT below the margin at bottom
878 of window: scroll_max can no longer be INT_MAX. When aggressive
879 scrolling is in use, don't let point enter the opposite scroll
880 margin as result of the scroll.
881 (syms_of_xdisp) <scroll-conservatively>: Document the
882 threshold of 100 lines for never-recentering scrolling.
883
8842011-03-31 Juanma Barranquero <lekktu@gmail.com>
885
886 * dispextern.h (move_it_by_lines):
887 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
888 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
889 (message_log_check_duplicate): Remove parameters `prev_bol' and
890 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
891 (redisplay_internal): Remove parameter `preserve_echo_area',
892 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
893
894 * indent.c (Fvertical_motion):
895 * window.c (window_scroll_pixel_based, Frecenter):
896 Don't pass `need_y_p' to `move_it_by_lines'.
897
8982011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
899
900 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
901 steal a few bits to be more compact.
902 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
903 Remove unneeded casts.
904
905 * bytecode.c (Fbyte_code): CAR and CDR can GC.
906
9072011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
908
909 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
910 binding" message (bug#7967).
911
9122011-03-30 Paul Eggert <eggert@cs.ucla.edu>
913
914 Fix more problems found by GCC 4.6.0's static checks.
915
916 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
917 Remove unused local var.
918
919 * editfns.c (Fmessage_box): Remove unused local var.
920
921 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
922 (note_mode_line_or_margin_highlight, note_mouse_highlight):
923 Omit unused local vars.
924 * window.c (shrink_windows): Omit unused local var.
925 * menu.c (digest_single_submenu): Omit unused local var.
926 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
927 Omit unused local var.
928
929 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
930 Don't assume string length fits in int.
931 (keyremap_step, read_key_sequence): Use size_t for sizes.
932 (read_key_sequence): Don't check last_real_key_start redundantly.
933
934 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
935 instead of alloca (Bug#8344).
936
937 * eval.c (Fbacktrace): Don't assume nargs fits in int.
938 (Fbacktrace_frame): Don't assume nframes fits in int.
939
940 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
941
942 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
943 concerns.
944
945 * term.c (produce_glyphless_glyph): Remove unnecessary test.
946
947 * cm.c (calccost): Turn while-do into do-while, for clarity.
948
949 * keyboard.c (syms_of_keyboard): Use the same style as later
950 in this function when indexing through an array. This also
951 works around GCC bug 48267.
952
953 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
954
955 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
956
957 * chartab.c (sub_char_table_ref_and_range): Redo for slight
958 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
959
960 * keyboard.c, keyboard.h (num_input_events): Now size_t.
961 This avoids undefined behavior on integer overflow, and is a bit
962 more convenient anyway since it is compared to a size_t variable.
963
964 Variadic C functions now count arguments with size_t, not int.
965 This avoids an unnecessary limitation on 64-bit machines, which
966 caused (substring ...) to crash on large vectors (Bug#8344).
967 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
968 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
969 All variadic functions and their callers changed accordingly.
970 (struct gcpro.nvars): Now size_t, not int. All uses changed.
971 * data.c (arith_driver, float_arith_driver): Likewise.
972 * editfns.c (general_insert_function): Likewise.
973 * eval.c (struct backtrace.nargs, interactive_p)
974 (internal_condition_case_n, run_hook_with_args, apply_lambda)
975 (funcall_lambda, mark_backtrace): Likewise.
976 * fns.c (concat): Likewise.
977 * frame.c (x_set_frame_parameters): Likewise.
978 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
979 0 if not found, not -1. All callers changed.
980
981 * alloc.c (garbage_collect): Don't assume stack size fits in int.
982 (stack_copy_size): Now size_t, not int.
983 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
984
9852011-03-28 Juanma Barranquero <lekktu@gmail.com>
986
987 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
988 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
989 All callers changed.
990
991 * lisp.h (multibyte_char_to_unibyte):
992 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
993 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
994 * character.h (CHAR_TO_BYTE8):
995 * cmds.c (internal_self_insert):
996 * editfns.c (general_insert_function):
997 * keymap.c (push_key_description):
998 * search.c (Freplace_match):
999 * xdisp.c (message_dolog, set_message_1): All callers changed.
1000
10012011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1002
1003 * keyboard.c (safe_run_hook_funcall): New function.
1004 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1005 don't set the hook to nil, but remove the offending function instead.
1006 (Qcommand_hook_internal): Remove, unused.
1007 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1008 Vcommand_hook_internal.
1009
1010 * eval.c (enum run_hooks_condition): Remove.
1011 (funcall_nil, funcall_not): New functions.
1012 (run_hook_with_args): Call each function through a `funcall' argument.
1013 Remove `cond' argument, now redundant.
1014 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1015 (Frun_hook_with_args_until_failure): Adjust accordingly.
1016 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1017
10182011-03-28 Juanma Barranquero <lekktu@gmail.com>
1019
1020 * dispextern.h (string_buffer_position): Remove declaration.
1021
1022 * print.c (strout): Remove parameter `multibyte', unused since
1023 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1024
1025 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1026 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1027 All callers changed.
1028
1029 * w32.c (_wsa_errlist): Use braces for struct initializers.
1030
1031 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1032 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1033 All callers changed.
1034 (string_buffer_position): Likewise. Also, make static (it's never
1035 used outside xdisp.c).
1036 (cursor_row_p): Remove parameter `w', unused since
1037 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1038 (decode_mode_spec): Remove parameter `precision', introduced during
1039 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1040 All callers changed.
1041
10422011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1043
1044 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1045
10462011-03-27 Anders Lindgren <andlind@gmail.com>
1047
1048 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1049 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1050 (ns_update_auto_hide_menu_bar): New functions.
1051 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1052 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1053 ns_constrain_all_frames.
1054 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1055 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1056
10572011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1058
1059 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1060
10612011-03-27 Glenn Morris <rgm@gnu.org>
1062
1063 * syssignal.h: Replace RETSIGTYPE with void.
1064 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1065 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1066 Replace SIGTYPE with void everywhere.
1067 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1068 * s/template.h (SIGTYPE): Remove commented out definition.
1069
10702011-03-26 Eli Zaretskii <eliz@gnu.org>
1071
1072 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1073 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1074
10752011-03-26 Juanma Barranquero <lekktu@gmail.com>
1076
1077 * w32.c (read_unc_volume): Use parameter `henum', instead of
1078 global variable `wget_enum_handle'.
1079
1080 * keymap.c (describe_vector): Remove parameters `indices' and
1081 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1082 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1083
1084 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1085
1086 * keyboard.c (timer_check): Remove parameter `do_it_now',
1087 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1088 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1089 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1090
1091 * keyboard.c (read_char):
1092 * w32menu.c (w32_menu_display_help):
1093 * xmenu.c (show_help_event, menu_help_callback):
1094 Adjust calls to `show_help_echo'.
1095
1096 * gtkutil.c (xg_maybe_add_timer):
1097 * keyboard.c (readable_events):
1098 * process.c (wait_reading_process_output):
1099 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1100
1101 * insdel.c (adjust_markers_gap_motion):
1102 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1103 (gap_left, gap_right): Don't call it.
1104
11052011-03-25 Chong Yidong <cyd@stupidchicken.com>
1106
1107 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1108 incurred during fontification.
1109
11102011-03-25 Juanma Barranquero <lekktu@gmail.com>
1111
1112 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1113 (DEFVAR_PER_BUFFER): Don't pass it.
1114
1115 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1116 (scrolling_window): Don't pass it.
1117
11182011-03-25 Juanma Barranquero <lekktu@gmail.com>
1119
1120 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1121
1122 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1123 and `suffix'.
1124 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1125 of variables specific to SELinux and computation of `encoded_absname'.
1126
1127 * image.c (XPutPixel): Remove unused variable `height'.
1128
1129 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1130
1131 * unexw32.c (get_section_info): Remove unused variable `section'.
1132
1133 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1134 (system_process_attributes): Remove unused variable `sess'.
1135 (sys_read): Remove unused variable `err'.
1136
1137 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1138 (w32_wnd_proc): Remove unused variable `isdead'.
1139 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1140 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1141 (x_create_tip_frame): Remove unused variable `tem'.
1142
1143 * w32inevt.c (w32_console_read_socket):
1144 Remove unused variable `no_events'.
1145
1146 * w32term.c (x_draw_composite_glyph_string_foreground):
1147 Remove unused variable `width'.
1148
11492011-03-24 Juanma Barranquero <lekktu@gmail.com>
1150
1151 * w32term.c (x_set_glyph_string_clipping):
1152 Don't pass uninitialized region to CombineRgn.
1153
11542011-03-23 Juanma Barranquero <lekktu@gmail.com>
1155
1156 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1157 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1158 (Fx_close_connection): Remove unused variable `i'.
1159
1160 * w32font.c (w32font_draw): Return number of glyphs.
1161 (w32font_open_internal): Remove unused variable `i'.
1162 (w32font_driver): Add missing initializer.
1163
1164 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1165 (fill_in_menu): Remove unused variable `items_added'.
1166
1167 * w32term.c (last_mouse_press_frame): Remove static global variable.
1168 (w32_clip_to_row): Remove unused variable `f'.
1169 (x_delete_terminal): Remove unused variable `i'.
1170
1171 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1172 (NOTHING): Remove unused static global variable.
1173 (uniscribe_check_otf): Remove unused variable `table'.
1174 (uniscribe_font_driver): Add missing initializers.
1175
11762011-03-23 Julien Danjou <julien@danjou.info>
1177
1178 * term.c (Fsuspend_tty, Fresume_tty):
1179 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1180 * window.c (temp_output_buffer_show):
1181 * insdel.c (signal_before_change):
1182 * frame.c (Fhandle_switch_frame):
1183 * fileio.c (Fdo_auto_save):
1184 * emacs.c (Fkill_emacs):
1185 * editfns.c (save_excursion_restore):
1186 * cmds.c (internal_self_insert):
1187 * callint.c (Fcall_interactively):
1188 * buffer.c (Fkill_all_local_variables):
1189 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1190 Use Frun_hooks.
1191 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
1192 unconditionnaly since it does the check itself.
1193
11942011-03-23 Paul Eggert <eggert@cs.ucla.edu>
1195
1196 Fix more problems found by GCC 4.5.2's static checks.
1197
1198 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1199 the first time through the loop, since we know p0 < p1 then.
1200 This also avoids a gcc -Wstrict-overflow warning.
1201
1202 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1203 leading to a memory leak, possible in functions like
1204 load_charset_map_from_file that can allocate an unbounded number
1205 of objects (Bug#8318).
1206
1207 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1208 that could (at least in theory) be that large.
1209
1210 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1211 This is less likely to overflow, and avoids undefined behavior if
1212 overflow does occur. All callers changed. Use strtoul to scan
1213 for the unsigned long integer.
1214 (pint2hrstr): Simplify and tune code slightly.
1215 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
1216
1217 * scroll.c (do_scrolling): Work around GCC bug 48228.
1218 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1219
1220 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1221 This also avoids a warning with gcc -Wstrict-overflow.
1222 (validate_x_resource_name): Simplify count usage.
1223 This also avoids a warning with gcc -Wstrict-overflow.
1224
1225 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1226 fail (Bug#8306).
1227
1228 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
1229
1230 * process.c (Fmake_network_process): Use socklen_t, not int,
1231 where POSIX says socklen_t is required in portable programs.
1232 This fixes a porting bug on hosts like 64-bit HP-UX, where
1233 socklen_t is wider than int (Bug#8277).
1234 (Fmake_network_process, server_accept_connection):
1235 (wait_reading_process_output, read_process_output):
1236 Likewise.
1237
1238 * process.c: Rename or move locals to avoid shadowing.
1239 (list_processes_1, Fmake_network_process):
1240 (read_process_output_error_handler, exec_sentinel_error_handler):
1241 Rename or move locals.
1242 (Fmake_network_process): Define label "retry_connect" only if needed.
1243 (Fnetwork_interface_info): Fix pointer signedness.
1244 (process_send_signal): Add cast to avoid pointer signedness problem.
1245 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
1246 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
1247
1248 Make tparam.h and terminfo.c consistent.
1249 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1250 Include tparam.h instead, since it declares them.
1251 * cm.h (PC): Remove extern decl; tparam.h now does this.
1252 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1253 * terminfo.c: Include tparam.h, to check interfaces.
1254 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1255 (tparam): Adjust signature to match interface in tparam.h;
1256 this removes some undefined behavior. Check that outstring and len
1257 are zero, which they always are with Emacs.
1258 * tparam.h (PC, BC, UP): New extern decls.
1259
1260 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
1261 (xftfont_open): Rename locals to avoid shadowing.
1262
1263 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
1264 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1265 (OTF_TAG_SYM): Omit macro if not needed.
1266 (ftfont_list): Remove unused local.
1267 (get_adstyle_property, ftfont_pattern_entity):
1268 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1269 Rename locals to avoid shadowing.
1270
1271 * xfont.c (xfont_list_family): Mark var as initialized.
1272
1273 * xml.c (make_dom): Now static.
1274
1275 * composite.c (composition_compute_stop_pos): Rename local to
1276 avoid shadowing.
1277 (composition_reseat_it): Remove unused locals.
1278 (find_automatic_composition, composition_adjust_point): Likewise.
1279 (composition_update_it): Mark var as initialized.
1280 (find_automatic_composition): Mark vars as initialized,
1281 with a FIXME (Bug#8290).
1282
1283 character.h: Rename locals to avoid shadowing.
1284 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1285 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1286 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1287 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1288 to avoid shadowing.
1289
1290 * textprop.c (property_change_between_p): Remove; unused.
1291
1292 * intervals.c (interval_start_pos): Now static.
1293
1294 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1295
1296 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1297 Rename locals to avoid shadowing.
1298
1299 * sound.c (wav_play, au_play, Fplay_sound_internal):
1300 Fix pointer signedness.
1301 (alsa_choose_format): Remove unused local var.
1302 (wav_play): Initialize a variable to 0, to prevent undefined
1303 behavior (Bug#8278).
1304
1305 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1306
1307 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1308
1309 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1310 clobbering (Bug#8298).
1311 * sysdep.c (sys_subshell): Likewise.
1312 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
1313
1314 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1315 This should get cleaned up, so that child_setup has the
1316 same signature on all platforms.
1317
1318 * callproc.c (call_process_cleanup): Now static.
1319 (relocate_fd): Rename locals to avoid shadowing.
1320
13212011-03-22 Chong Yidong <cyd@stupidchicken.com>
1322
1323 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1324 not to be necessary, and produces flickering.
1325
13262011-03-20 Glenn Morris <rgm@gnu.org>
1327
1328 * config.in: Remove file.
1329
13302011-03-20 Juanma Barranquero <lekktu@gmail.com>
1331
1332 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1333 are now in src/globals.h.
1334 (syms_of_minibuf): Remove spurious & from previous change.
1335
13362011-03-20 Leo <sdl.web@gmail.com>
1337
1338 * minibuf.c (completing-read-function): New variable.
1339 (completing-read-default): Rename from completing-read.
1340 (completing-read): Call completing-read-function.
1341
13422011-03-19 Juanma Barranquero <lekktu@gmail.com>
1343
1344 * xfaces.c (Fx_load_color_file):
1345 Read color file from absolute filename (bug#8250).
1346
13472011-03-19 Juanma Barranquero <lekktu@gmail.com>
1348
1349 * makefile.w32-in: Update dependencies.
1350
13512011-03-17 Eli Zaretskii <eliz@gnu.org>
1352
1353 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1354
13552011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1356
1357 Fix more problems found by GCC 4.5.2's static checks.
1358
1359 * process.c (make_serial_process_unwind, send_process_trap):
1360 (sigchld_handler): Now static.
1361
1362 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1363 That way, the code declares only the vars that it needs.
1364 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1365 * s/cygwin.h (PTY_ITERATION): Likewise.
1366 * s/darwin.h (PTY_ITERATION): Likewise.
1367 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1368
1369 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1370 * process.c (allocate_pty): Don't declare stb unless it's needed.
1371
1372 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
1373 (CONSTANTLIM): Remove; unused.
1374 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1375 Define only if needed.
1376
1377 * unexelf.c (unexec): Name an expression,
1378 to avoid gcc -Wbad-function-cast warning.
1379 Use a different way to cause a compilation error if anyone uses
1380 n rather than nn, a way that does not involve shadowing.
1381 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
1382
1383 * deps.mk (unexalpha.o): Remove; unused.
1384
1385 New file unexec.h, the (simple) interface for unexec (Bug#8267).
1386 * unexec.h: New file.
1387 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1388 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1389 Depend on unexec.h.
1390 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1391 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1392 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
1393 Change as necessary to match prototype in unexec.h.
1394
1395 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1396 shadowing.
1397 (back_comment, skip_chars): Mark vars as initialized.
1398
1399 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1400 Rename locals to avoid shadowing.
1401
1402 * lread.c (read1): Rewrite so as not to use empty "else".
1403 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
1404
1405 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1406
1407 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1408 warning when compiling print.c.
1409
1410 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1411 instead of using an uninitialized var.
1412 (font_sort_entities): Mark var as initialized.
1413
1414 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1415
1416 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1417 pointers to constants.
1418 (font_parse_fcname): Remove unused vars.
1419 (font_delete_unmatched): Now static.
1420 (font_get_spec): Remove; unused.
1421 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1422 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1423 Rename or move locals to avoid shadowing.
1424
1425 * fns.c (require_nesting_list, require_unwind): Now static.
1426 (Ffillarray): Rename locals to avoid shadowing.
1427
1428 * floatfns.c (domain_error2): Define only if needed.
1429 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1430
1431 * alloc.c (mark_backtrace): Move decl from here ...
1432 * lisp.h: ... to here, so that it can be checked.
1433
1434 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
1435 (Fdefvar): Rewrite so as not to use empty "else".
1436 (lisp_indirect_variable): Name an expression,
1437 to avoid gcc -Wbad-function-cast warning.
1438 (Fdefvar): Rename locals to avoid shadowing.
1439
1440 * callint.c (quotify_arg, quotify_args): Now static.
1441 (Fcall_interactively): Rename locals to avoid shadowing.
1442 Use const pointer when appropriate.
1443
1444 * lisp.h (get_system_name, get_operating_system_release):
1445 Move decls here, to check interfaces.
1446 * process.c (get_operating_system_release): Move decl to lisp.h.
1447 * xrdb.c (get_system_name): Likewise.
1448 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1449 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1450 some of which prompt warnings from gcc -Wbad-function-cast.
1451 (Fformat_time_string, Fencode_time, Finsert_char):
1452 (Ftranslate_region_internal, Fformat):
1453 Rename or remove local vars to avoid shadowing.
1454 (Ftranslate_region_internal): Mark var as initialized.
1455
1456 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1457 avoid shadowing.
1458
1459 * lisp.h (eassert): Check that the argument compiles, even if
1460 ENABLE_CHECKING is not defined.
1461
1462 * data.c (Findirect_variable): Name an expression, to avoid
1463 gcc -Wbad-function-cast warning.
1464 (default_value, arithcompare, arith_driver, arith_error): Now static.
1465 (store_symval_forwarding): Rename local to avoid shadowing.
1466 (Fmake_variable_buffer_local, Fmake_local_variable):
1467 Mark variables as initialized.
1468 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
1469
1470 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
1471 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1472 Rename locals to avoid shadowing.
1473 (mark_stack): Move local variables into the #ifdef region where
1474 they're used.
1475 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1476 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1477 needed otherwise.
1478 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1479 (GC_STRING_CHARS): Remove; not used.
1480 (Fmemory_limit): Cast sbrk's returned value to char *.
1481
1482 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1483 avoids undefined behavior in theory.
1484
1485 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1486
1487 Use functions, not macros, for up- and down-casing (Bug#8254).
1488 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1489 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1490 to use the following functions instead of these macros.
1491 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1492 EMACS_INT, since callers assume the returned value fits in int.
1493 (upcase1): Likewise, for UPCASE_TABLE.
1494 (uppercasep, lowercasep, upcase): New static inline functions.
1495 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
1496 the race-condition problem in the old DOWNCASE.
1497
1498 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1499 Rename locals to avoid shadowing.
1500 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
1501 (regex_compile, re_search_2, re_match_2_internal):
1502 Remove unused local vars.
1503 (FREE_VAR): Rewrite so as not to use empty "else",
1504 which gcc can warn about.
1505 (regex_compile, re_match_2_internal): Mark locals as initialized.
1506 (RETALLOC_IF): Define only if needed.
1507 (WORDCHAR_P): Likewise. This one is never needed, but is used
1508 only in a comment talking about a compiler bug, so put inside
1509 the #if 0 of that comment.
1510 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1511 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1512 Remove; unused.
1513
1514 * search.c (boyer_moore): Rename locals to avoid shadowing.
1515 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1516 (PREV_CHAR_BOUNDARY): Likewise.
1517
1518 * search.c (simple_search): Remove unused var.
1519
1520 * dired.c (compile_pattern): Move decl from here ...
1521 * lisp.h: ... to here, so that it can be checked.
1522 (struct re_registers): New forward decl.
1523
1524 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1525
1526 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1527 All uses changed.
1528 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1529 Rename locals to avoid shadowing.
1530 (Fvertical_motion): Mark locals as initialized.
1531
1532 * casefiddle.c (casify_object, casify_region): Now static.
1533 (casify_region): Mark local as initialized.
1534
1535 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1536
1537 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1538 New macros, so that the caller can use some names other than
1539 gcpro1, gcpro2, etc.
1540 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1541 of the new macros.
1542 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1543 argument, for consistency with GCPRO2_VAR, etc: it is now the
1544 prefix of the variable, not the variable itself. All uses
1545 changed.
1546 * dired.c (directory_files_internal, file_name_completion):
1547 Rename locals to avoid shadowing.
1548
1549 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1550 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1551 dired.c's scmp function, had undefined behavior.
1552 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1553 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1554 * buffer.h: ... to here, because these macros use current_buffer,
1555 and the new implementation with inline functions needs to have
1556 current_buffer in scope now, rather than later when the macros
1557 are used.
1558 (downcase, upcase1): New static inline functions.
1559 (DOWNCASE, UPCASE1): Reimplement using these functions.
1560 This avoids undefined behavior in expressions like
1561 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1562 from race conditions in accessing the global variables
1563 case_temp1 and case_temp2.
1564 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1565 * lisp.h (case_temp1, case_temp2): Remove their decls.
1566 * character.h (ASCII_CHAR_P): Move from here ...
1567 * lisp.h: ... to here, so that the inline functions mentioned
1568 above can use them.
1569
1570 * dired.c (directory_files_internal_unwind): Now static.
1571
1572 * fileio.c (file_name_as_directory, directory_file_name):
1573 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1574 Now static.
1575 (file_name_as_directory): Use const pointers when appropriate.
1576 (Fexpand_file_name): Likewise. In particular, newdir might
1577 point at constant storage, so make it a const pointer.
1578 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
1579 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1580 signedness issues.
1581 (Fset_file_times, Finsert_file_contents, auto_save_error):
1582 Rename locals to avoid shadowing.
1583
1584 * minibuf.c (choose_minibuf_frame_1): Now static.
1585 (Ftry_completion, Fall_completions): Rename or remove locals
1586 to avoid shadowing.
1587
1588 * marker.c (bytepos_to_charpos): Remove; unused.
1589
1590 * lisp.h (verify_bytepos, count_markers): New decls,
1591 so that gcc does not warn that these functions aren't declared.
1592
1593 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1594 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
1595 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
1596 (copy_text): Remove unused local var.
1597
1598 * filelock.c (within_one_second): Now static.
1599 (lock_file_1): Rename local to avoid shadowing.
1600
1601 * buffer.c (fix_overlays_before): Mark locals as initialized.
1602 (fix_start_end_in_overlays): Likewise. This function should be
1603 simplified by using pointers-to-pointers, but that's a different
1604 matter.
1605 (switch_to_buffer_1): Now static.
1606 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1607 (report_overlay_modification): Rename locals to avoid shadowing.
1608
1609 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
1610 Fix pointer signedness issue.
1611 (sys_subshell): Mark local as volatile if checking for lint,
1612 to suppress a gcc -Wclobbered warning that does not seem to be right.
1613 (MAXPATHLEN): Define only if needed.
1614
1615 * process.c (serial_open, serial_configure): Move decls from here ...
1616 * systty.h: ... to here, so that they can be checked.
1617
1618 * fns.c (get_random, seed_random): Move extern decls from here ...
1619 * lisp.h: ... to here, so that they can be checked.
1620
1621 * sysdep.c (reset_io): Now static.
1622 (wait_for_termination_signal): Remove; unused.
1623
1624 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1625 (copy_keymap_item, append_key, push_text_char_description):
1626 Now static.
1627 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
1628 (DENSE_TABLE_SIZE): Remove; unused.
1629 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1630 (describe_map_tree):
1631 Rename locals to avoid shadowing.
1632
1633 * keyboard.c: Declare functions static if they are not used elsewhere.
1634 (echo_char, echo_dash, cmd_error, top_level_2):
1635 (poll_for_input, handle_async_input): Now static.
1636 (read_char, kbd_buffer_get_event, make_lispy_position):
1637 (make_lispy_event, make_lispy_movement, apply_modifiers):
1638 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1639 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1640 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
1641 (read_key_sequence, read_char): Mark locals as initialized.
1642 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
1643
1644 * keyboard.h (make_ctrl_char): New decl.
1645 (mark_kboards): Move decl here ...
1646 * alloc.c (mark_kboards): ... from here.
1647
1648 * lisp.h (force_auto_save_soon): New decl.
1649
1650 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
1651 (DEFINE_DUMMY_FUNCTION): New macro.
1652 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1653 Use it.
1654 (main): Add casts to avoid warnings
1655 if GCC considers string literals to be constants.
1656
1657 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1658
1659 * dbusbind.c: Pointer signedness fixes.
1660 (xd_signature, xd_append_arg, xd_initialize):
1661 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1662 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1663 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1664 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1665
1666 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1667 if GCC considers string literals to be constants.
1668 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
1669
16702011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1671
1672 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1673 (print_preprocess, print_object): New macro to fix last change.
1674
1675 * print.c (print_preprocess): Don't forget font objects.
1676
16772011-03-16 Juanma Barranquero <lekktu@gmail.com>
1678
1679 * emacs.c (USAGE3): Doc fixes.
1680
16812011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1682
1683 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1684 structure.
1685
16862011-03-14 Juanma Barranquero <lekktu@gmail.com>
1687
1688 * lisp.h (VWindow_system, Qfile_name_history):
1689 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1690 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1691 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1692
1693 * w32select.c: Don't #include "keyboard.h".
1694 (run_protected): Add extern declaration for waiting_for_input.
1695
1696 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1697 * w32console.c (detect_input_pending, read_input_pending)
1698 (encode_terminal_code):
1699 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1700 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1701 (w32_system_caret_y, Qfile_name_history):
1702 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1703 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1704 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1705 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1706 * w32proc.c (Qlocal, report_file_error):
1707 * w32term.c (Vwindow_system, updating_frame):
1708 * w32uniscribe.c (initialized, uniscribe_font_driver):
1709 Remove unneeded extern declarations.
1710
17112011-03-14 Chong Yidong <cyd@stupidchicken.com>
1712
1713 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
1714
17152011-03-13 Chong Yidong <cyd@stupidchicken.com>
1716
1717 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1718 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1719 These macros can no longer be used for assignment.
1720
1721 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1722 Assign struct members directly, instead of using BUF_BEGV etc.
1723 (record_buffer_markers, fetch_buffer_markers): New functions for
1724 recording and fetching special buffer markers.
1725 (set_buffer_internal_1, set_buffer_temp): Use them.
1726
1727 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1728
1729 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1730
1731 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1732 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1733
1734 * xdisp.c (hscroll_window_tree):
1735 (reconsider_clip_changes): Use PT instead of BUF_PT.
1736
17372011-03-13 Eli Zaretskii <eliz@gnu.org>
1738
1739 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1740 $(EMACS_ROOT)/lib/intprops.h.
1741
17422011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1743
1744 Fix more problems found by GCC 4.5.2's static checks.
1745
1746 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1747 to unsigned char * to avoid compiler diagnostic.
1748 (xg_free_frame_widgets): Make it clear that a local variable is
1749 needed only if USE_GTK_TOOLTIP.
1750 (gdk_window_get_screen): Make it clear that this macro is needed
1751 only if USE_GTK_TOOLTIP.
1752 (int_gtk_range_get_value): New function, which avoids a diagnostic
1753 from gcc -Wbad-function-cast.
1754 (xg_set_toolkit_scroll_bar_thumb): Use it.
1755 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1756 diagnostic from gcc -Wbad-function-cast.
1757 (get_utf8_string, xg_get_file_with_chooser):
1758 Rename locals to avoid shadowing.
1759 (create_dialog): Move locals to avoid shadowing.
1760
1761 * xgselect.c (xg_select): Remove unused var.
1762
1763 * image.c (four_corners_best): Mark locals as initialized.
1764 (gif_load): Initialize transparent_p to zero (Bug#8238).
1765 Mark another local as initialized.
1766 (my_png_error, my_error_exit): Mark with NO_RETURN.
1767
1768 * image.c (clear_image_cache): Now static.
1769 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
1770 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
1771 (x_edge_detection): Remove unnecessary cast that
1772 gcc -Wbad-function-cast diagnoses.
1773 (gif_load): Fix pointer signedness.
1774 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1775 (jpeg_load, gif_load): Rename locals to avoid shadowing.
1776
17772011-03-12 Paul Eggert <eggert@cs.ucla.edu>
1778
1779 Improve quality of tests for time stamp overflow.
1780 For example, without this patch (encode-time 0 0 0 1 1
1781 1152921504606846976) returns the obviously-bogus value (-948597
1782 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1783 reports time overflow. See
1784 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
1785 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1786 * editfns.c: Include limits.h and intprops.h.
1787 (TIME_T_MIN, TIME_T_MAX): New macros.
1788 (time_overflow): Move earlier, to before first use.
1789 (hi_time, lo_time): New functions, for an accurate test for
1790 out-of-range times.
1791 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1792 (Fget_internal_run_time): Don't assume time_t fits in int.
1793 (make_time): Use list2 instead of Fcons twice.
1794 (Fdecode_time): More accurate test for out-of-range times.
1795 (check_tm_member): New function.
1796 (Fencode_time): Use it, to test for out-of-range times.
1797 (lisp_time_argument): Don't rely on undefined left-shift and
1798 right-shift behavior when checking for time stamp overflow.
1799
1800 * editfns.c (time_overflow): New function, refactoring common code.
1801 (Fformat_time_string, Fdecode_time, Fencode_time):
1802 (Fcurrent_time_string): Use it.
1803
1804 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1805 * dired.c (make_time): Move to ...
1806 * editfns.c (make_time): ... here.
1807 * systime.h: Note the move.
1808
18092011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1810
1811 * fringe.c (update_window_fringes): Remove unused variables.
1812
1813 * unexmacosx.c (copy_data_segment): Also copy __got section.
1814 (Bug#8223)
1815
18162011-03-12 Eli Zaretskii <eliz@gnu.org>
1817
1818 * termcap.c [MSDOS]: Include "msdos.h".
1819 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1820 Constify `char *' arguments and their references according to
1821 prototypes in tparam.h.
1822
1823 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
1824
1825 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1826 Adapt all references accordingly.
1827
1828 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1829
18302011-03-11 Tom Tromey <tromey@redhat.com>
1831
1832 * buffer.c (syms_of_buffer): Remove obsolete comment.
1833
18342011-03-11 Eli Zaretskii <eliz@gnu.org>
1835
1836 * termhooks.h (encode_terminal_code): Declare prototype.
1837
1838 * msdos.c (encode_terminal_code): Don't declare prototype.
1839
1840 * term.c (encode_terminal_code): Now external again, used by
1841 w32console.c and msdos.c.
1842
1843 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
1844 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
1845
18462011-03-11 Paul Eggert <eggert@cs.ucla.edu>
1847
1848 Fix some minor problems found by GCC 4.5.2's static checks.
1849
1850 * fringe.c (update_window_fringes): Mark locals as initialized
1851 (Bug#8227).
1852 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
1853
1854 * alloc.c (mark_fringe_data): Move decl from here ...
1855 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
1856 to check its interface.
1857 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
1858
1859 * fontset.c (free_realized_fontset): Now static.
1860 (Fset_fontset_font): Rename local to avoid shadowing.
1861 (fontset_font): Mark local as initialized.
1862 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
1863
1864 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
1865
1866 * xselect.c (x_disown_buffer_selections): Remove; not used.
1867 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
1868 (x_own_selection, Fx_disown_selection_internal): Rename locals
1869 to avoid shadowing.
1870 (x_handle_dnd_message): Remove local to avoid shadowing.
1871
1872 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
1873 so that the caller can use some name other than gcpro1.
1874 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
1875 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1876 (Fx_backspace_delete_keys_p):
1877 Use them to avoid shadowing, and rename vars to avoid shadowing.
1878 (x_decode_color, x_set_name, x_window): Now static.
1879 (Fx_create_frame): Add braces to silence GCC warning.
1880 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
1881 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
1882 Remove unused locals.
1883 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1884 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
1885 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
1886 macros.
1887
1888 * xterm.h (x_mouse_leave): New decl.
1889
1890 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
1891 Remove unused functions.
1892 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
1893 (x_calc_absolute_position): Now static.
1894 (XTread_socket): Don't define label "out" unless it's used.
1895 Don't declare local "event" unless it's used.
1896 (x_iconify_frame, x_free_frame_resources): Don't declare locals
1897 unless they are used.
1898 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
1899 (x_fatal_error_signal): Remove; not used.
1900 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
1901 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
1902 (x_error_catcher, x_connection_closed, x_error_handler):
1903 (x_error_quitter, xembed_send_message, x_iconify_frame):
1904 (my_log_handler): Rename locals to avoid shadowing.
1905 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
1906 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
1907
1908 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
1909 Rename or move locals to avoid shadowing.
1910 (tty_defined_color, merge_face_heights): Now static.
1911 (free_realized_faces_for_fontset): Remove; not used.
1912 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
1913 does not deduce is never used uninitialized.
1914 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
1915 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
1916
1917 * terminal.c (store_terminal_param): Now static.
1918
1919 * xmenu.c (menu_highlight_callback): Now static.
1920 (set_frame_menubar): Remove unused local.
1921 (xmenu_show): Rename parameter to avoid shadowing.
1922 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
1923 since they might point to immutable storage.
1924 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
1925 since it's unused otherwise.
1926
1927 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
1928 Add a FIXME, since the code still doesn't look right. (Bug#8215)
1929 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
1930 avoids a gcc -Wuninitialized diagnostic.
1931 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
1932 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
1933 does not deduce are never used uninitialized.
1934
1935 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
1936
1937 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
1938 * window.c (window_loop, size_window):
1939 (run_window_configuration_change_hook, enlarge_window): Likewise.
1940
1941 * window.c (display_buffer): Now static.
1942 (size_window): Mark variables that gcc -Wuninitialized
1943 does not deduce are never used uninitialized.
1944 * window.h (check_all_windows): New decl, to forestall
1945 gcc -Wmissing-prototypes diagnostic.
1946 * dispextern.h (bidi_dump_cached_states): Likewise.
1947
1948 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
1949 shadowing.
1950 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
1951 Include <limits.h>.
1952 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
1953 and to avoid gcc -Wuninitialized warning.
1954 (load_charset_map): Mark variables that gcc -Wuninitialized
1955 does not deduce are never used uninitialized.
1956 (load_charset): Abort instead of using uninitialized var (Bug#8229).
1957
1958 * coding.c (coding_set_source, coding_set_destination):
1959 Use "else { /* comment */ }" rather than "else /* comment */;"
1960 for clarity, and to avoid gcc -Wempty-body warning.
1961 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
1962 a block, when the outer 'i' will do.
1963 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
1964 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
1965 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
1966 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
1967 (Fdecode_sjis_char, Fdefine_coding_system_internal):
1968 Rename locals to avoid shadowing.
1969 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
1970 * coding.c (emacs_mule_char, encode_invocation_designation):
1971 Now static, since they're not used elsewhere.
1972 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
1973 (decode_coding_object, encode_coding_object, detect_coding_system):
1974 (decode_coding_emacs_mule): Mark variables that gcc
1975 -Wuninitialized does not deduce are never used uninitialized.
1976 (detect_coding_iso_2022): Initialize a local variable that might
1977 be used uninitialized. Leave a FIXME because it's not clear that
1978 this initialization is needed. (Bug#8211)
1979 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
1980 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
1981 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
1982 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
1983 Remove unused macros.
1984
1985 * category.c (hash_get_category_set): Remove unused local var.
1986 (copy_category_table): Now static, since it's not used elsewhere.
1987 * character.c (string_count_byte8): Likewise.
1988
1989 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
1990 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
1991
1992 * chartab.c (copy_sub_char_table): Now static, since it's not used
1993 elsewhere.
1994 (sub_char_table_ref_and_range, char_table_ref_and_range):
1995 Rename locals to avoid shadowing.
1996 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
1997
1998 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
1999 (BIDI_BOB): Remove unused macro.
2000
2001 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2002 deduce are never used uninitialized.
2003 * term.c (encode_terminal_code): Likewise.
2004
2005 * term.c (encode_terminal_code): Now static. Remove unused local.
2006
2007 * tparam.h: New file.
2008 * term.c, tparam.h: Include it.
2009 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2010 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2011 Move these decls to tparam.h, and make them agree with what
2012 is actually in tparam.c. The previous trick of using incompatible
2013 decls in different modules does not conform to the C standard.
2014 All callers of tparam changed to use tparam's actual API.
2015 * tparam.c (tparam1, tparam, tgoto):
2016 Use const pointers where appropriate.
2017
2018 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2019 * cm.h (struct cm): Likewise.
2020 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2021 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2022 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2023 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2024 (turn_on_face, init_tty): Likewise.
2025 * termchar.h (struct tty_display_info): Likewise.
2026
2027 * term.c (term_mouse_position): Rename local to avoid shadowing.
2028
2029 * alloc.c (mark_ttys): Move decl from here ...
2030 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2031
20322011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2033
2034 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2035
20362011-03-09 Juanma Barranquero <lekktu@gmail.com>
2037
2038 * search.c (compile_pattern_1): Remove argument regp, unused since
2039 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2040 (compile_pattern): Don't pass it.
2041
20422011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2043
2044 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2045 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2046 for ! HAVE_GTK3.
2047 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2048
2049 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2050
2051 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2052 gdk_window_get_screen, gdk_window_get_geometry,
2053 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2054 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2055 (xg_get_pixbuf_from_pixmap): New function.
2056 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2057 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2058 Call xg_get_pixbuf_from_pixmap instead of
2059 gdk_pixbuf_get_from_drawable.
2060 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2061 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2062 (xg_check_special_colors): Use GtkStyleContext and its functions
2063 for HAVE_GTK3.
2064 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2065 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2066 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
2067 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2068 Call gtk_widget_get_preferred_size.
2069 (xg_frame_resized): gdk_window_get_geometry only takes 5
2070 parameters.
2071 (xg_win_to_widget, xg_event_is_for_menubar):
2072 Call gdk_x11_window_lookup_for_display.
2073 (xg_set_widget_bg): New function.
2074 (delete_cb): New function.
2075 (xg_create_frame_widgets): connect delete-event to delete_cb.
2076 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2077 (xg_set_background_color): Call xg_set_widget_bg.
2078 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2079 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2080 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2081 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2082 if ! HAVE_GTK3.
2083 (update_frame_tool_bar): Call gtk_widget_hide.
2084 (xg_initialize): Use GDK_KEY_g.
2085
2086 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2087 if ! HAVE_GTK3
2088 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2089
2090 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2091 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2092 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2093
20942011-03-08 Juanma Barranquero <lekktu@gmail.com>
2095
2096 * w32xfns.c (select_palette): Check success of RealizePalette against
2097 GDI_ERROR, not zero.
2098
2099See ChangeLog.11 for earlier changes.
2100
2101;; Local Variables:
2102;; coding: utf-8
2103;; End:
2104
2105 Copyright (C) 2011 Free Software Foundation, Inc.
2106
2107 This file is part of GNU Emacs.
2108
2109 GNU Emacs is free software: you can redistribute it and/or modify
2110 it under the terms of the GNU General Public License as published by
2111 the Free Software Foundation, either version 3 of the License, or
2112 (at your option) any later version.
2113
2114 GNU Emacs is distributed in the hope that it will be useful,
2115 but WITHOUT ANY WARRANTY; without even the implied warranty of
2116 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2117 GNU General Public License for more details.
2118
2119 You should have received a copy of the GNU General Public License
2120 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.