* xdisp.c (vmessage): Use a better test for character truncation.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
762f8d96 12011-04-09 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2
7d66342c
PE
3 * xdisp.c (vmessage): Use a better test for character truncation.
4
bbf47d44
PE
5 * charset.c (load_charset_map): <, not <=, for optimization,
6 and to avoid potential problems with integer overflow.
9248994d 7 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 8 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 9 * editfns.c (Fformat): Likewise.
1e69125e 10 * syntax.c (skip_chars): Likewise.
3befa583 11
e3019616
PE
12 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
13 This also lets GCC 4.6.0 generate slightly better loop code.
14
becfa255
PE
15 * callint.c (Fcall_interactively): <, not <=, for optimization.
16 (Fcall_interactively): Count the number of arguments produced,
17 not the number of arguments given. This is simpler and lets GCC
18 4.6.0 generate slightly better code.
19
dae0cd48
PE
20 * ftfont.c: Distingish more carefully between FcChar8 and char.
21 The previous code passed unsigned char * to a functions like
22 strlen and xstrcasecmp that expect char *, which does not
23 conform to the C standard.
24 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
25 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
26 char * when the C standard requires it.
27
76032d70
PE
28 * keyboard.c (read_char): Remove unused var.
29
eb3f1cc8
PE
30 * eval.c: Port to Windows vsnprintf (Bug#8435).
31 Include <limits.h>.
32 (SIZE_MAX): Define if the headers do not.
33 (verror): Do not give up if vsnprintf returns a negative count.
34 Instead, grow the buffer. This ports to Windows vsnprintf, which
35 does not conform to C99. Problem reported by Eli Zaretskii.
36 Also, simplify the allocation scheme, by avoiding the need for
37 calling realloc, and removing the ALLOCATED variable.
38
70476b54
PE
39 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
40
ea6c7ae6
PE
41 Remove the doprnt implementation, as Emacs now uses vsnprintf.
42 * doprnt.c: Remove.
43 * lisp.h (doprnt): Remove.
44 * Makefile.in (base_obj): Remove doprnt.o.
45 * deps.mk (doprnt.o): Remove.
46
5fdb398c
PE
47 error: Print 32- and 64-bit integers portably (Bug#8435).
48 Without this change, on typical 64-bit hosts error ("...%d...", N)
49 was used to print both 32- and 64-bit integers N, which relied on
50 undefined behavior.
51 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
52 New macro.
53 * lisp.h (error, verror): Mark as printf-like functions.
54 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
55 Report overflow in size calculations when allocating printf buffer.
56 Do not truncate output string at its first null byte.
57 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
58 Truncate the output at a character boundary, since vsnprintf does not
59 do that.
60 * charset.c (check_iso_charset_parameter): Convert internal
61 character to string before calling 'error', since %c now has the
62 printf meaning.
63 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
64 overflow when computing char to be passed to 'error'. Do not
65 pass Lisp_Object to 'error'; pass the integer instead.
66 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
67 formatted with plain %d.
68
b189fa66
PE
69 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
70
bff87ef0
PE
71 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
72
7e2cac20
PE
73 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
74
ce4d90b5
PE
75 * xterm.c (x_catch_errors): Remove duplicate declaration.
76
266c9547
PE
77 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
78
79c49ad2
PE
79 * xdisp.c, lisp.h (message_nolog): Remove; unused.
80
8546720e 812011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 82
8546720e
GM
83 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
84 unsigned char, to match FcChar8 type definition.
aac0c6e3 85
8546720e
GM
86 * xterm.c (handle_one_xevent):
87 * xmenu.c (create_and_show_popup_menu):
88 * xselect.c (x_decline_selection_request)
89 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 90
a53e2e89
EZ
912011-04-09 Eli Zaretskii <eliz@emacstest.gnu.org>
92
93 Fix some uses of `int' instead of EMACS_INT.
94 * search.c (string_match_1, fast_string_match)
95 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
96 (scan_buffer, find_next_newline_no_quit)
97 (find_before_next_newline, search_command, Freplace_match)
98 (Fmatch_data): Make some `int' variables be EMACS_INT.
99
100 * xdisp.c (display_count_lines): 3rd argument and return value now
101 EMACS_INT. All callers changed.
102 (pint2hrstr): Last argument is now EMACS_INT.
103
104 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
105 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
106 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
107 (decode_coding_utf_16, decode_coding_emacs_mule)
108 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
109 (decode_coding_ccl, decode_coding_charset)
110 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
111 (decode_coding_iso_2022, decode_coding_emacs_mule)
112 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
113 <char_offset, last_offset>: Declare EMACS_INT.
114 (encode_coding_utf_8, encode_coding_utf_16)
115 (encode_coding_emacs_mule, encode_invocation_designation)
116 (encode_designation_at_bol, encode_coding_iso_2022)
117 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
118 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
119 Declare EMACS_INT.
120 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
121 (encode_invocation_designation): Last argument P_NCHARS is now
122 EMACS_INT.
123 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
124 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
125
126 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
127 All users changed.
128
129 * ccl.c (Fccl_execute_on_string): Declare some variables
130 EMACS_INT.
131
8546720e 1322011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
133
134 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
135
4e19a977
CS
1362011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
137
138 * process.c (Fformat_network_address): Doc fix.
139
87302331
R
1402011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
141
142 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
143
cbb59342
CY
1442011-04-08 Chong Yidong <cyd@stupidchicken.com>
145
146 * keyboard.c (read_char): Call Lisp function help-form-show,
147 instead of using internal_with_output_to_temp_buffer.
148 (Qhelp_form_show): New var.
e0d38eeb 149 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
150
151 * print.c (internal_with_output_to_temp_buffer): Function deleted.
152
153 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
154
e67a13ab
CY
1552011-04-06 Chong Yidong <cyd@stupidchicken.com>
156
157 * process.c (Flist_processes): Removed to Lisp.
158 (list_processes_1): Deleted.
159
973f782d
EZ
1602011-04-06 Eli Zaretskii <eliz@gnu.org>
161
7c106b1e
EZ
162 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
163
973f782d
EZ
164 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
165
41cf7d1a 1662011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 167
ca23cc88
PE
168 Fix more problems found by GCC 4.6.0's static checks.
169
f390e2d5
PE
170 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
171
42eea0d0
PE
172 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
173
b69769da 174 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 175
f9541e84
PE
176 * xdisp.c (vmessage): Mark as a printf-like function.
177
13841b55
PE
178 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
179
c136c10f
PE
180 * sound.c (sound_warning): Don't crash if arg contains a printf format.
181
5e2d4a30
PE
182 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
183 printf-like functions.
184 (tiff_load): Add casts to remove these marks before passing them
185 to system-supplied API.
186
583f48b9
PE
187 * eval.c (Fsignal): Remove excess argument to 'fatal'.
188
b25d760e
PE
189 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
190 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
191 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
192 directly, rather than having caller test rule sign. This avoids
193 some unnecessary tests.
194 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
195 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
196 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 197
bc7b6697 198 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 199 (xfont_open): Avoid unnecessary tests.
bc7b6697 200
27ccc379
PE
201 * composite.c (composition_gstring_put_cache): Use unsigned integer.
202
dcd5c89a
PE
203 * composite.h, composite.c (composition_gstring_put_cache):
204 Use EMACS_INT, not int, for length.
205
b13a45c6
PE
206 * composite.h (COMPOSITION_DECODE_REFS): New macro,
207 breaking out part of COMPOSITION_DECODE_RULE.
208 (COMPOSITION_DECODE_RULE): Use it.
209 * composite.c (get_composition_id): Remove unused local vars,
210 by using the new macro.
211
1e792e4d
PE
212 * textprop.c (set_text_properties_1): Change while to do-while,
213 since the condition is always true at first.
214
dc6c6455 215 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
216 (interval_deletion_adjustment): Return unsigned value.
217 All uses changed.
dc6c6455 218
aba7731a
PE
219 * process.c (list_processes_1, create_pty, read_process_output):
220 (exec_sentinel): Remove vars that were set but not used.
afd4052b 221 (create_pty): Remove unnecessary "volatile"s.
bc57d757 222 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 223 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 224 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 225
fdfc4bf3
PE
226 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
227
fca8fe46 228 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 229 (update_syntax_table): Use unsigned instead of int.
fca8fe46 230
06a0259a 231 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 232 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 233 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 234
e7b9e80f
PE
235 * print.c (print_error_message): Avoid int overflow.
236
56201685
PE
237 * font.c (font_list_entities): Redo for clarity,
238 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
239
78834453 240 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 241 (font_score): Avoid potential overflow in diff calculation.
78834453 242
0bc0b309 243 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 244 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 245
e610eaca
PE
246 * eval.c (funcall_lambda): Rename local to avoid shadowing.
247
b895abce
PE
248 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
249 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
250 can always succeed if overflow has undefined behavior.
251
1f1d9321 252 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 253 (wordify): Omit three unnecessary tests.
1f1d9321 254
c59478bc
PE
255 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
256 All callers changed. This avoids the need for an unused var.
257
79b73827
PE
258 * casefiddle.c (casify_region): Remove var that is set but not used.
259
a4db5dfe
PE
260 * dired.c (file_name_completion): Remove var that is set but not used.
261
43aae36e
PE
262 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
263
2a47c44d 264 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 265 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 266
a37c69bf
PE
267 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
268 Check for integer overflow on size calculations.
269
328ab8e7
PE
270 * buffer.c (Fprevious_overlay_change): Remove var that is set
271 but not used.
272
e5a2a5cb
PE
273 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
274 Remove vars that are set but not used.
8d84a6eb 275 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 276 (timer_check_2): Mark vars as initialized.
e5a2a5cb 277
a60e5f68
PE
278 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
279
f661cb61 280 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 281 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 282
f0397f5a
PE
283 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
284 that are set but not used.
285
8664db06 286 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 287 if XCreateBitmapFromData fails (Bug#8410).
8664db06 288
6abdaa4a
PE
289 * xselect.c (x_get_local_selection, x_handle_property_notify):
290 Remove vars that are set but not used.
291
0ce7538d 292 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 293 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 294
9ae848fc
PE
295 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
296 Remove var that is set but not used.
0b918413
PE
297 (scroll_bar_windows_size): Now size_t, not int.
298 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
299 Check for overflow.
9ae848fc 300
a5a62657
PE
301 * xfaces.c (realize_named_face): Remove vars that are set but not used.
302 (map_tty_color) [!defined MSDOS]: Likewise.
303
5c5cdd39
PE
304 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
305
66ebf983
PE
306 * coding.c: Remove vars that are set but not used.
307 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
308 All callers changed.
309 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
310 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
311 (decode_coding_charset): Remove vars that are set but not used.
312
1be4d761
PE
313 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
314 that is set but not used.
315
47553fa8
PE
316 * print.c (print_object): Remove var that is set but not used.
317
1f7196bf 318 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
319 The gnulib version avoids calling malloc in the usual case,
320 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
321 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
322 * filelock.c (current_lock_owner): Likewise.
323 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
324 * sysdep.c: Include allocator.h, careadlinkat.h.
325 (emacs_no_realloc_allocator): New static constant.
326 (emacs_readlink): New function.
fdb61804
PE
327 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
328 ../lib/careadlinkat.h.
d1fdcab7 329
f84c17c7
SM
3302011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
331
332 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
333 first non-nil return value).
334
ef3862ad
JD
3352011-04-03 Jan Djärv <jan.h.d@swipnet.se>
336
337 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
338 if not defined (Bug#8403).
339
376a7006
JB
3402011-04-02 Juanma Barranquero <lekktu@gmail.com>
341
342 * xdisp.c (display_count_lines): Remove parameter `start',
343 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
344 (get_char_face_and_encoding): Remove parameter `multibyte_p',
345 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
346 (fill_stretch_glyph_string): Remove parameters `row' and `area',
347 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
348 and thereabouts. All callers changed.
349 (get_per_char_metric): Remove parameter `f', unused since
350 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
351
6ca3801d
JM
3522011-04-02 Jim Meyering <meyering@redhat.com>
353
354 do not dereference NULL upon failed strdup
355 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
356 (ns_get_family): Likewise.
357
d8e2b5ba
JB
3582011-04-02 Juanma Barranquero <lekktu@gmail.com>
359
360 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
361
8c74fcbd
JD
3622011-04-02 Jan Djärv <jan.h.d@swipnet.se>
363
364 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
365 later (Bug#8403).
366
7200d79c
SM
3672011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
368
03408648 369 Add lexical binding.
7200d79c 370
03408648
SM
371 * window.c (Ftemp_output_buffer_show): New fun.
372 (Fsave_window_excursion):
373 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
374
375 * lread.c (lisp_file_lexically_bound_p): New function.
376 (Fload): Bind Qlexical_binding.
377 (readevalloop): Remove `evalfun' arg.
378 Bind Qinternal_interpreter_environment.
379 (Feval_buffer): Bind Qlexical_binding.
380 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
381 Mark as dynamic.
382 (syms_of_lread): Declare `lexical-binding'.
383
384 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
385
386 * keyboard.c (eval_dyn): New fun.
387 (menu_item_eval_property): Use it.
ca105506
SM
388
389 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 390
03408648
SM
391 * fns.c (concat, mapcar1): Accept byte-code-functions.
392
393 * eval.c (Fsetq): Handle lexical vars.
394 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
395 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
396 (FletX, Flet): Obey lexical binding.
397 (Fcommandp): Handle closures.
398 (Feval): New `lexical' arg.
399 (eval_sub): New function extracted from Feval. Use it almost
400 everywhere where Feval was used. Look up vars in lexical env.
401 Handle closures.
402 (Ffunctionp): Move from subr.el.
403 (Ffuncall): Handle closures.
404 (apply_lambda): Remove `eval_flags'.
405 (funcall_lambda): Handle closures and new byte-code-functions.
406 (Fspecial_variable_p): New function.
407 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
408 but without exporting it to Lisp.
23aba0ea 409
23aba0ea 410 * doc.c (Fdocumentation, store_function_docstring):
03408648 411 * data.c (Finteractive_form): Handle closures.
23aba0ea 412
03408648
SM
413 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
414 interactive spec.
ba83908c 415
03408648
SM
416 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
417 byte-codes.
418 (exec_byte_code): New function extracted from Fbyte_code to handle new
419 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 420
03408648 421 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 422
03408648 423 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 424
e2abce01
JB
4252011-03-31 Juanma Barranquero <lekktu@gmail.com>
426
427 * xdisp.c (redisplay_internal): Fix prototype.
428
63696a73 4292011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 430
63696a73
EZ
431 * xdisp.c (SCROLL_LIMIT): New macro.
432 (try_scrolling): Use it when setting scroll_limit. Limit
433 scrolling to 100 screen lines.
434 (redisplay_window): Even when falling back on "recentering",
435 position point in the window according to scroll-conservatively,
436 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
437
438 (try_scrolling): When point is above the window, allow searching
439 as far as scroll_max, or one screenful, to compute vertical
440 distance from PT to the scroll margin position. This prevents
441 try_scrolling from unnecessarily failing when
442 scroll-conservatively is set to a value slightly larger than the
443 window height. Clean up the case of PT below the margin at bottom
444 of window: scroll_max can no longer be INT_MAX. When aggressive
445 scrolling is in use, don't let point enter the opposite scroll
446 margin as result of the scroll.
447 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
448 threshold of 100 lines for never-recentering scrolling.
449
e4cc2dfc
JB
4502011-03-31 Juanma Barranquero <lekktu@gmail.com>
451
452 * dispextern.h (move_it_by_lines):
453 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
454 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
455 (message_log_check_duplicate): Remove parameters `prev_bol' and
456 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
457 (redisplay_internal): Remove parameter `preserve_echo_area',
458 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
459
460 * indent.c (Fvertical_motion):
461 * window.c (window_scroll_pixel_based, Frecenter):
462 Don't pass `need_y_p' to `move_it_by_lines'.
463
1c470562
SM
4642011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
465
44f230aa
SM
466 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
467 steal a few bits to be more compact.
468 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
469 Remove unneeded casts.
470
1c470562
SM
471 * bytecode.c (Fbyte_code): CAR and CDR can GC.
472
888adce9
ZK
4732011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
474
475 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
476 binding" message (bug#7967).
477
f838ed7b
PE
4782011-03-30 Paul Eggert <eggert@cs.ucla.edu>
479
77861b95
PE
480 Fix more problems found by GCC 4.6.0's static checks.
481
de6dbc14
PE
482 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
483 Remove unused local var.
484
f838ed7b
PE
485 * editfns.c (Fmessage_box): Remove unused local var.
486
792c7b2b
PE
487 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
488 (note_mode_line_or_margin_highlight, note_mouse_highlight):
489 Omit unused local vars.
c499e557 490 * window.c (shrink_windows): Omit unused local var.
b01a1c29 491 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
492 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
493 Omit unused local var.
494
ba0165e1
PE
495 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
496 Don't assume string length fits in int.
32ad8845 497 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 498 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 499
3c59b4c9
PE
500 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
501 instead of alloca (Bug#8344).
502
a3eed478 503 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 504 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 505
eb4d412d
PE
506 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
507
1658b401
PE
508 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
509 concerns.
510
511 * term.c (produce_glyphless_glyph): Remove unnecessary test.
512
513 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 514
9a2c6e05
PE
515 * keyboard.c (syms_of_keyboard): Use the same style as later
516 in this function when indexing through an array. This also
517 works around GCC bug 48267.
518
03d0a109
PE
519 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
520
44f730c8
PE
521 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
522
fe75f926
PE
523 * chartab.c (sub_char_table_ref_and_range): Redo for slight
524 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
525
ffa8c828
PE
526 * keyboard.c, keyboard.h (num_input_events): Now size_t.
527 This avoids undefined behavior on integer overflow, and is a bit
528 more convenient anyway since it is compared to a size_t variable.
529
c5101a77
PE
530 Variadic C functions now count arguments with size_t, not int.
531 This avoids an unnecessary limitation on 64-bit machines, which
532 caused (substring ...) to crash on large vectors (Bug#8344).
533 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
534 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 535 All variadic functions and their callers changed accordingly.
c5101a77
PE
536 (struct gcpro.nvars): Now size_t, not int. All uses changed.
537 * data.c (arith_driver, float_arith_driver): Likewise.
538 * editfns.c (general_insert_function): Likewise.
539 * eval.c (struct backtrace.nargs, interactive_p)
540 (internal_condition_case_n, run_hook_with_args, apply_lambda)
541 (funcall_lambda, mark_backtrace): Likewise.
542 * fns.c (concat): Likewise.
543 * frame.c (x_set_frame_parameters): Likewise.
544 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
545 0 if not found, not -1. All callers changed.
546
dd3f25f7
PE
547 * alloc.c (garbage_collect): Don't assume stack size fits in int.
548 (stack_copy_size): Now size_t, not int.
549 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
550
461c2ab9
JB
5512011-03-28 Juanma Barranquero <lekktu@gmail.com>
552
553 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
554 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
555 All callers changed.
556
557 * lisp.h (multibyte_char_to_unibyte):
558 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
559 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
560 * character.h (CHAR_TO_BYTE8):
561 * cmds.c (internal_self_insert):
562 * editfns.c (general_insert_function):
563 * keymap.c (push_key_description):
564 * search.c (Freplace_match):
565 * xdisp.c (message_dolog, set_message_1): All callers changed.
566
f6d62986
SM
5672011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
568
569 * keyboard.c (safe_run_hook_funcall): New function.
570 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
571 don't set the hook to nil, but remove the offending function instead.
572 (Qcommand_hook_internal): Remove, unused.
573 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
574 Vcommand_hook_internal.
575
576 * eval.c (enum run_hooks_condition): Remove.
577 (funcall_nil, funcall_not): New functions.
578 (run_hook_with_args): Call each function through a `funcall' argument.
579 Remove `cond' argument, now redundant.
580 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
581 (Frun_hook_with_args_until_failure): Adjust accordingly.
582 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
583
1db5b1ad
JB
5842011-03-28 Juanma Barranquero <lekktu@gmail.com>
585
586 * dispextern.h (string_buffer_position): Remove declaration.
587
588 * print.c (strout): Remove parameter `multibyte', unused since
589 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
590
591 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
592 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
593 All callers changed.
594
595 * w32.c (_wsa_errlist): Use braces for struct initializers.
596
597 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
598 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
599 All callers changed.
600 (string_buffer_position): Likewise. Also, make static (it's never
601 used outside xdisp.c).
602 (cursor_row_p): Remove parameter `w', unused since
603 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
604 (decode_mode_spec): Remove parameter `precision', introduced during
605 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
606 All callers changed.
607
5ffb62aa
JD
6082011-03-27 Jan Djärv <jan.h.d@swipnet.se>
609
610 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
611
461c2ab9 6122011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
613
614 * nsterm.m (ns_menu_bar_is_hidden): New variable.
615 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
616 (ns_update_auto_hide_menu_bar): New functions.
617 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
618 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
619 ns_constrain_all_frames.
620 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
621 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
622
5c380ffb
JD
6232011-03-27 Jan Djärv <jan.h.d@swipnet.se>
624
625 * nsmenu.m (runDialogAt): Remove argument to timer_check.
626
9af30bdf
GM
6272011-03-27 Glenn Morris <rgm@gnu.org>
628
629 * syssignal.h: Replace RETSIGTYPE with void.
630 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
631 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
632 Replace SIGTYPE with void everywhere.
633 * s/usg5-4-common.h (SIGTYPE): Remove definition.
634 * s/template.h (SIGTYPE): Remove commented out definition.
635
e2abce01
JB
6362011-03-26 Eli Zaretskii <eliz@gnu.org>
637
638 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
639 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
640
f868cd8a
JB
6412011-03-26 Juanma Barranquero <lekktu@gmail.com>
642
59eb0929
JB
643 * w32.c (read_unc_volume): Use parameter `henum', instead of
644 global variable `wget_enum_handle'.
645
646 * keymap.c (describe_vector): Remove parameters `indices' and
647 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
648 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
649
f868cd8a
JB
650 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
651
652 * keyboard.c (timer_check): Remove parameter `do_it_now',
653 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
654 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
655 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
656
657 * keyboard.c (read_char):
658 * w32menu.c (w32_menu_display_help):
659 * xmenu.c (show_help_event, menu_help_callback):
660 Adjust calls to `show_help_echo'.
661
662 * gtkutil.c (xg_maybe_add_timer):
663 * keyboard.c (readable_events):
664 * process.c (wait_reading_process_output):
665 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
666
667 * insdel.c (adjust_markers_gap_motion):
668 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
669 (gap_left, gap_right): Don't call it.
670
2ecf6fdb
CY
6712011-03-25 Chong Yidong <cyd@stupidchicken.com>
672
673 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
674 incurred during fontification.
675
6b1f9ba4
JB
6762011-03-25 Juanma Barranquero <lekktu@gmail.com>
677
678 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
679 (DEFVAR_PER_BUFFER): Don't pass it.
680
681 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
682 (scrolling_window): Don't pass it.
683
0f4a96b5
JB
6842011-03-25 Juanma Barranquero <lekktu@gmail.com>
685
686 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
687
688 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
689 and `suffix'.
690 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
691 of variables specific to SELinux and computation of `encoded_absname'.
692
693 * image.c (XPutPixel): Remove unused variable `height'.
694
695 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
696
697 * unexw32.c (get_section_info): Remove unused variable `section'.
698
699 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
700 (system_process_attributes): Remove unused variable `sess'.
701 (sys_read): Remove unused variable `err'.
702
703 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
704 (w32_wnd_proc): Remove unused variable `isdead'.
705 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
706 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
707 (x_create_tip_frame): Remove unused variable `tem'.
708
709 * w32inevt.c (w32_console_read_socket):
710 Remove unused variable `no_events'.
711
712 * w32term.c (x_draw_composite_glyph_string_foreground):
713 Remove unused variable `width'.
714
1149507c
JB
7152011-03-24 Juanma Barranquero <lekktu@gmail.com>
716
717 * w32term.c (x_set_glyph_string_clipping):
718 Don't pass uninitialized region to CombineRgn.
719
9c88f339
JB
7202011-03-23 Juanma Barranquero <lekktu@gmail.com>
721
722 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
723 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
724 (Fx_close_connection): Remove unused variable `i'.
725
726 * w32font.c (w32font_draw): Return number of glyphs.
727 (w32font_open_internal): Remove unused variable `i'.
728 (w32font_driver): Add missing initializer.
729
730 * w32menu.c (utf8to16): Remove unused variable `utf16'.
731 (fill_in_menu): Remove unused variable `items_added'.
732
733 * w32term.c (last_mouse_press_frame): Remove static global variable.
734 (w32_clip_to_row): Remove unused variable `f'.
735 (x_delete_terminal): Remove unused variable `i'.
736
737 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
738 (NOTHING): Remove unused static global variable.
739 (uniscribe_check_otf): Remove unused variable `table'.
740 (uniscribe_font_driver): Add missing initializers.
741
dee091a3
JD
7422011-03-23 Julien Danjou <julien@danjou.info>
743
744 * term.c (Fsuspend_tty, Fresume_tty):
745 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
746 * window.c (temp_output_buffer_show):
747 * insdel.c (signal_before_change):
748 * frame.c (Fhandle_switch_frame):
749 * fileio.c (Fdo_auto_save):
750 * emacs.c (Fkill_emacs):
751 * editfns.c (save_excursion_restore):
752 * cmds.c (internal_self_insert):
753 * callint.c (Fcall_interactively):
754 * buffer.c (Fkill_all_local_variables):
755 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
756 Use Frun_hooks.
0f4a96b5 757 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
758 unconditionnaly since it does the check itself.
759
2c520ab5 7602011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 761
c9c49752
PE
762 Fix more problems found by GCC 4.5.2's static checks.
763
8abc3f12
PE
764 * coding.c (encode_coding_raw_text): Avoid unnecessary test
765 the first time through the loop, since we know p0 < p1 then.
766 This also avoids a gcc -Wstrict-overflow warning.
767
a2d26660
PE
768 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
769 leading to a memory leak, possible in functions like
770 load_charset_map_from_file that can allocate an unbounded number
b12ef411 771 of objects (Bug#8318).
a2d26660 772
916c72e9
PE
773 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
774 that could (at least in theory) be that large.
775
19ab8a18
PE
776 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
777 This is less likely to overflow, and avoids undefined behavior if
778 overflow does occur. All callers changed. Use strtoul to scan
779 for the unsigned long integer.
b7cbbd6f
PE
780 (pint2hrstr): Simplify and tune code slightly.
781 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 782
f0641eff
PE
783 * scroll.c (do_scrolling): Work around GCC bug 48228.
784 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
785
7f650bb9
PE
786 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
787 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
788 (validate_x_resource_name): Simplify count usage.
789 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 790
37dd57d1
PE
791 * fileio.c (Fcopy_file): Report error if fchown or fchmod
792 fail (Bug#8306).
81e56e61 793
699979fc 794 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 795
401bf9b4
PE
796 * process.c (Fmake_network_process): Use socklen_t, not int,
797 where POSIX says socklen_t is required in portable programs.
798 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 799 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
800 (Fmake_network_process, server_accept_connection):
801 (wait_reading_process_output, read_process_output):
802 Likewise.
803
b93aacde
PE
804 * process.c: Rename or move locals to avoid shadowing.
805 (list_processes_1, Fmake_network_process):
806 (read_process_output_error_handler, exec_sentinel_error_handler):
807 Rename or move locals.
4dc343ee 808 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 809 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 810 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 811 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 812 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 813
af8a867c 814 Make tparam.h and terminfo.c consistent.
44f230aa
SM
815 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
816 Include tparam.h instead, since it declares them.
af8a867c
PE
817 * cm.h (PC): Remove extern decl; tparam.h now does this.
818 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
819 * terminfo.c: Include tparam.h, to check interfaces.
820 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
821 (tparam): Adjust signature to match interface in tparam.h;
822 this removes some undefined behavior. Check that outstring and len
823 are zero, which they always are with Emacs.
824 * tparam.h (PC, BC, UP): New extern decls.
825
0248044d 826 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 827 (xftfont_open): Rename locals to avoid shadowing.
0248044d 828
8ff096c1 829 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
830 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
831 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 832 (ftfont_list): Remove unused local.
49eaafba
PE
833 (get_adstyle_property, ftfont_pattern_entity):
834 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
835 Rename locals to avoid shadowing.
8ff096c1 836
e2be39f6
PE
837 * xfont.c (xfont_list_family): Mark var as initialized.
838
c9735e30
PE
839 * xml.c (make_dom): Now static.
840
8f5201ae
PE
841 * composite.c (composition_compute_stop_pos): Rename local to
842 avoid shadowing.
b246f932
PE
843 (composition_reseat_it): Remove unused locals.
844 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 845 (composition_update_it): Mark var as initialized.
11b61122
PE
846 (find_automatic_composition): Mark vars as initialized,
847 with a FIXME (Bug#8290).
8f5201ae 848
760fbc2c
PE
849 character.h: Rename locals to avoid shadowing.
850 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
851 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
852 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
853 (BUF_DEC_POS): Be more systematic about renaming local temporaries
854 to avoid shadowing.
855
ff08eb85
PE
856 * textprop.c (property_change_between_p): Remove; unused.
857
fc7bf025
PE
858 * intervals.c (interval_start_pos): Now static.
859
235d7abc
PE
860 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
861
44f230aa
SM
862 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
863 Rename locals to avoid shadowing.
3e7d6594 864
50060332
PE
865 * sound.c (wav_play, au_play, Fplay_sound_internal):
866 Fix pointer signedness.
d01f234b 867 (alsa_choose_format): Remove unused local var.
c83b8872
PE
868 (wav_play): Initialize a variable to 0, to prevent undefined
869 behavior (Bug#8278).
50060332 870
c4fc4e30
PE
871 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
872
918436ed
PE
873 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
874
c939f91b
PE
875 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
876 clobbering (Bug#8298).
b9c7f648
PE
877 * sysdep.c (sys_subshell): Likewise.
878 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 879
6bd8c144
PE
880 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
881 This should get cleaned up, so that child_setup has the
882 same signature on all platforms.
883
7710357c 884 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 885 (relocate_fd): Rename locals to avoid shadowing.
7710357c 886
c59da222
CY
8872011-03-22 Chong Yidong <cyd@stupidchicken.com>
888
889 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
890 not to be necessary, and produces flickering.
891
66b87493
GM
8922011-03-20 Glenn Morris <rgm@gnu.org>
893
894 * config.in: Remove file.
895
45b6f6d5
JB
8962011-03-20 Juanma Barranquero <lekktu@gmail.com>
897
898 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
899 are now in src/globals.h.
900 (syms_of_minibuf): Remove spurious & from previous change.
901
3ec03f7e
LL
9022011-03-20 Leo <sdl.web@gmail.com>
903
904 * minibuf.c (completing-read-function): New variable.
905 (completing-read-default): Rename from completing-read.
906 (completing-read): Call completing-read-function.
907
b14e3e21
CY
9082011-03-19 Juanma Barranquero <lekktu@gmail.com>
909
910 * xfaces.c (Fx_load_color_file):
911 Read color file from absolute filename (bug#8250).
912
f2b726e6
JB
9132011-03-19 Juanma Barranquero <lekktu@gmail.com>
914
915 * makefile.w32-in: Update dependencies.
916
09f6ff02
EZ
9172011-03-17 Eli Zaretskii <eliz@gnu.org>
918
919 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
920
29a6015a
PE
9212011-03-17 Paul Eggert <eggert@cs.ucla.edu>
922
a3a6c54e
PE
923 Fix more problems found by GCC 4.5.2's static checks.
924
b766f867
PE
925 * process.c (make_serial_process_unwind, send_process_trap):
926 (sigchld_handler): Now static.
927
be02381c
PE
928 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
929 That way, the code declares only the vars that it needs.
930 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
931 * s/cygwin.h (PTY_ITERATION): Likewise.
932 * s/darwin.h (PTY_ITERATION): Likewise.
933 * s/gnu-linux.h (PTY_ITERATION): Likewise.
934
57048744
PE
935 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
936 * process.c (allocate_pty): Don't declare stb unless it's needed.
937
7914961c 938 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
939 (CONSTANTLIM): Remove; unused.
940 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
941 Define only if needed.
7914961c 942
b3967b18
PE
943 * unexelf.c (unexec): Name an expression,
944 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
945 Use a different way to cause a compilation error if anyone uses
946 n rather than nn, a way that does not involve shadowing.
73366a00 947 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 948
29a6015a
PE
949 * deps.mk (unexalpha.o): Remove; unused.
950
43cfc33e 951 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 952 * unexec.h: New file.
ce701a33
PE
953 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
954 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
955 Depend on unexec.h.
956 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
957 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
958 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 959 Change as necessary to match prototype in unexec.h.
ce701a33 960
01f44d5a
PE
961 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
962 shadowing.
4f63c6bb 963 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 964
a6670b0b
PE
965 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
966 Rename locals to avoid shadowing.
967
cef2010d 968 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 969 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 970
d4d7173a
PE
971 * print.c (Fredirect_debugging_output): Fix pointer signedess.
972
f08b802a
PE
973 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
974 warning when compiling print.c.
975
3ddb0639
PE
976 * font.c (font_unparse_fcname): Abort in an "impossible" situation
977 instead of using an uninitialized var.
5ad03b97 978 (font_sort_entities): Mark var as initialized.
3ddb0639 979
170a2692
PE
980 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
981
e663c700
PE
982 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
983 pointers to constants.
89bc529a 984 (font_parse_fcname): Remove unused vars.
7b81e2d0 985 (font_delete_unmatched): Now static.
ea838e10 986 (font_get_spec): Remove; unused.
13a547c6
PE
987 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
988 (font_update_drivers, Ffont_get_glyphs, font_add_log):
989 Rename or move locals to avoid shadowing.
e663c700 990
2a80c887 991 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 992 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 993
1384fa33 994 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 995 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 996
8b2c52e9
PE
997 * alloc.c (mark_backtrace): Move decl from here ...
998 * lisp.h: ... to here, so that it can be checked.
999
475545b5 1000 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 1001 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
1002 (lisp_indirect_variable): Name an expression,
1003 to avoid gcc -Wbad-function-cast warning.
1faed8ae 1004 (Fdefvar): Rename locals to avoid shadowing.
475545b5 1005
b1349114 1006 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 1007 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 1008 Use const pointer when appropriate.
b1349114 1009
a2928364
PE
1010 * lisp.h (get_system_name, get_operating_system_release):
1011 Move decls here, to check interfaces.
1012 * process.c (get_operating_system_release): Move decl to lisp.h.
1013 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
1014 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1015 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1016 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
1017 (Fformat_time_string, Fencode_time, Finsert_char):
1018 (Ftranslate_region_internal, Fformat):
1019 Rename or remove local vars to avoid shadowing.
9710023e 1020 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 1021
a415e694
PE
1022 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1023 avoid shadowing.
1024
8ef4622d
PE
1025 * lisp.h (eassert): Check that the argument compiles, even if
1026 ENABLE_CHECKING is not defined.
1027
946f9a5b
PE
1028 * data.c (Findirect_variable): Name an expression, to avoid
1029 gcc -Wbad-function-cast warning.
112396d6 1030 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 1031 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
1032 (Fmake_variable_buffer_local, Fmake_local_variable):
1033 Mark variables as initialized.
52746918 1034 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 1035
e5aab7e7 1036 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
1037 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1038 Rename locals to avoid shadowing.
dff45157
PE
1039 (mark_stack): Move local variables into the #ifdef region where
1040 they're used.
7bc26fdb
PE
1041 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1042 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1043 needed otherwise.
1044 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1045 (GC_STRING_CHARS): Remove; not used.
d40d4be1 1046 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 1047
e5aab7e7
PE
1048 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1049 avoids undefined behavior in theory.
1050
4da60324
PE
1051 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1052
88043301
PE
1053 Use functions, not macros, for up- and down-casing (Bug#8254).
1054 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1055 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1056 to use the following functions instead of these macros.
1057 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1058 EMACS_INT, since callers assume the returned value fits in int.
1059 (upcase1): Likewise, for UPCASE_TABLE.
1060 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 1061 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 1062 the race-condition problem in the old DOWNCASE.
88043301 1063
19ed5445
PE
1064 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1065 Rename locals to avoid shadowing.
1066 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
1067 (regex_compile, re_search_2, re_match_2_internal):
1068 Remove unused local vars.
952db0d7
PE
1069 (FREE_VAR): Rewrite so as not to use empty "else",
1070 which gcc can warn about.
da053e48 1071 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
1072 (RETALLOC_IF): Define only if needed.
1073 (WORDCHAR_P): Likewise. This one is never needed, but is used
1074 only in a comment talking about a compiler bug, so put inside
1075 the #if 0 of that comment.
1076 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1077 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1078 Remove; unused.
19ed5445 1079
1f3561e4 1080 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
1081 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1082 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 1083
ded6f8f7
PE
1084 * search.c (simple_search): Remove unused var.
1085
dbd37a95
PE
1086 * dired.c (compile_pattern): Move decl from here ...
1087 * lisp.h: ... to here, so that it can be checked.
1088 (struct re_registers): New forward decl.
1089
7e47afad
PE
1090 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1091
85f24f61
PE
1092 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1093 All uses changed.
1094 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1095 Rename locals to avoid shadowing.
5671df8f 1096 (Fvertical_motion): Mark locals as initialized.
85f24f61 1097
181aa2be 1098 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 1099 (casify_region): Mark local as initialized.
181aa2be 1100
930d429c
PE
1101 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1102
7082eac6
PE
1103 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1104 New macros, so that the caller can use some names other than
1105 gcpro1, gcpro2, etc.
1106 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1107 of the new macros.
1108 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1109 argument, for consistency with GCPRO2_VAR, etc: it is now the
1110 prefix of the variable, not the variable itself. All uses
1111 changed.
38b2c076
PE
1112 * dired.c (directory_files_internal, file_name_completion):
1113 Rename locals to avoid shadowing.
1114
15206ed9
PE
1115 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1116 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1117 dired.c's scmp function, had undefined behavior.
1118 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1119 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1120 * buffer.h: ... to here, because these macros use current_buffer,
1121 and the new implementation with inline functions needs to have
1122 current_buffer in scope now, rather than later when the macros
1123 are used.
1124 (downcase, upcase1): New static inline functions.
1125 (DOWNCASE, UPCASE1): Reimplement using these functions.
1126 This avoids undefined behavior in expressions like
1127 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1128 from race conditions in accessing the global variables
1129 case_temp1 and case_temp2.
1130 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1131 * lisp.h (case_temp1, case_temp2): Remove their decls.
1132 * character.h (ASCII_CHAR_P): Move from here ...
1133 * lisp.h: ... to here, so that the inline functions mentioned
1134 above can use them.
1135
4a6bea26
PE
1136 * dired.c (directory_files_internal_unwind): Now static.
1137
f14b7e14
PE
1138 * fileio.c (file_name_as_directory, directory_file_name):
1139 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1140 Now static.
2893f146
PE
1141 (file_name_as_directory): Use const pointers when appropriate.
1142 (Fexpand_file_name): Likewise. In particular, newdir might
1143 point at constant storage, so make it a const pointer.
fd4ead52 1144 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
1145 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1146 signedness issues.
f839df0c
PE
1147 (Fset_file_times, Finsert_file_contents, auto_save_error):
1148 Rename locals to avoid shadowing.
f14b7e14 1149
5716756e 1150 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
1151 (Ftry_completion, Fall_completions): Rename or remove locals
1152 to avoid shadowing.
5716756e 1153
b4c3046a
PE
1154 * marker.c (bytepos_to_charpos): Remove; unused.
1155
b45db522
PE
1156 * lisp.h (verify_bytepos, count_markers): New decls,
1157 so that gcc does not warn that these functions aren't declared.
1158
85876d07
PE
1159 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1160 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 1161 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 1162 (copy_text): Remove unused local var.
85876d07 1163
03d78a21 1164 * filelock.c (within_one_second): Now static.
b3dd38ab 1165 (lock_file_1): Rename local to avoid shadowing.
03d78a21 1166
5df8f01b
PE
1167 * buffer.c (fix_overlays_before): Mark locals as initialized.
1168 (fix_start_end_in_overlays): Likewise. This function should be
1169 simplified by using pointers-to-pointers, but that's a different
1170 matter.
b1d876f1 1171 (switch_to_buffer_1): Now static.
8f54f30a
PE
1172 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1173 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 1174
a70072c9 1175 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 1176 Fix pointer signedness issue.
edced198
PE
1177 (sys_subshell): Mark local as volatile if checking for lint,
1178 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 1179 (MAXPATHLEN): Define only if needed.
a70072c9 1180
a0977c44
PE
1181 * process.c (serial_open, serial_configure): Move decls from here ...
1182 * systty.h: ... to here, so that they can be checked.
1183
a884fdcc
PE
1184 * fns.c (get_random, seed_random): Move extern decls from here ...
1185 * lisp.h: ... to here, so that they can be checked.
1186
604efe86 1187 * sysdep.c (reset_io): Now static.
b8950c94 1188 (wait_for_termination_signal): Remove; unused.
604efe86 1189
38fc62d9
PE
1190 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1191 (copy_keymap_item, append_key, push_text_char_description):
1192 Now static.
1004a21a 1193 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 1194 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
1195 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1196 (describe_map_tree):
1197 Rename locals to avoid shadowing.
38fc62d9 1198
2f2650da
PE
1199 * keyboard.c: Declare functions static if they are not used elsewhere.
1200 (echo_char, echo_dash, cmd_error, top_level_2):
1201 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
1202 (read_char, kbd_buffer_get_event, make_lispy_position):
1203 (make_lispy_event, make_lispy_movement, apply_modifiers):
1204 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1205 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1206 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 1207 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 1208 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 1209
a053e86c 1210 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
1211 (mark_kboards): Move decl here ...
1212 * alloc.c (mark_kboards): ... from here.
a053e86c 1213
4752793e
PE
1214 * lisp.h (force_auto_save_soon): New decl.
1215
74f10ca7 1216 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
1217 (DEFINE_DUMMY_FUNCTION): New macro.
1218 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1219 Use it.
c03cd23f
PE
1220 (main): Add casts to avoid warnings
1221 if GCC considers string literals to be constants.
74f10ca7 1222
022e70d4
PE
1223 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1224
59d6fe83
PE
1225 * dbusbind.c: Pointer signedness fixes.
1226 (xd_signature, xd_append_arg, xd_initialize):
1227 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1228 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1229 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1230 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1231
78320123
PE
1232 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1233 if GCC considers string literals to be constants.
49cebcca 1234 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 1235
35ac2a97
SM
12362011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1237
fb103ca9
SM
1238 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1239 (print_preprocess, print_object): New macro to fix last change.
1240
35ac2a97
SM
1241 * print.c (print_preprocess): Don't forget font objects.
1242
62973b41
JB
12432011-03-16 Juanma Barranquero <lekktu@gmail.com>
1244
1245 * emacs.c (USAGE3): Doc fixes.
1246
0e48bb22
AS
12472011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1248
1249 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1250 structure.
1251
7684e57b
JB
12522011-03-14 Juanma Barranquero <lekktu@gmail.com>
1253
1254 * lisp.h (VWindow_system, Qfile_name_history):
1255 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1256 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1257 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1258
1259 * w32select.c: Don't #include "keyboard.h".
c96bbc66 1260 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
1261
1262 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1263 * w32console.c (detect_input_pending, read_input_pending)
1264 (encode_terminal_code):
1265 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1266 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1267 (w32_system_caret_y, Qfile_name_history):
1268 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1269 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1270 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1271 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1272 * w32proc.c (Qlocal, report_file_error):
1273 * w32term.c (Vwindow_system, updating_frame):
1274 * w32uniscribe.c (initialized, uniscribe_font_driver):
1275 Remove unneeded extern declarations.
1276
2aa46d6c
CY
12772011-03-14 Chong Yidong <cyd@stupidchicken.com>
1278
c96bbc66 1279 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 1280
cffc6f3b
CY
12812011-03-13 Chong Yidong <cyd@stupidchicken.com>
1282
1283 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1284 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1285 These macros can no longer be used for assignment.
1286
44f230aa
SM
1287 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1288 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
1289 (record_buffer_markers, fetch_buffer_markers): New functions for
1290 recording and fetching special buffer markers.
1291 (set_buffer_internal_1, set_buffer_temp): Use them.
1292
1293 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1294
1295 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1296
1297 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1298 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1299
1300 * xdisp.c (hscroll_window_tree):
1301 (reconsider_clip_changes): Use PT instead of BUF_PT.
1302
d251f04b
EZ
13032011-03-13 Eli Zaretskii <eliz@gnu.org>
1304
1305 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1306 $(EMACS_ROOT)/lib/intprops.h.
1307
f0c77cd1
PE
13082011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1309
3eca4629
PE
1310 Fix more problems found by GCC 4.5.2's static checks.
1311
7c86ee98
PE
1312 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1313 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
1314 (xg_free_frame_widgets): Make it clear that a local variable is
1315 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
1316 (gdk_window_get_screen): Make it clear that this macro is needed
1317 only if USE_GTK_TOOLTIP.
1e5524e7
PE
1318 (int_gtk_range_get_value): New function, which avoids a diagnostic
1319 from gcc -Wbad-function-cast.
1320 (xg_set_toolkit_scroll_bar_thumb): Use it.
1321 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1322 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
1323 (get_utf8_string, xg_get_file_with_chooser):
1324 Rename locals to avoid shadowing.
1325 (create_dialog): Move locals to avoid shadowing.
7c86ee98 1326
41729b81
PE
1327 * xgselect.c (xg_select): Remove unused var.
1328
f0c77cd1
PE
1329 * image.c (four_corners_best): Mark locals as initialized.
1330 (gif_load): Initialize transparent_p to zero (Bug#8238).
1331 Mark another local as initialized.
ec6cf4c6 1332 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 1333
ce0ad53d 1334 * image.c (clear_image_cache): Now static.
d5d5a617 1335 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 1336 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
1337 (x_edge_detection): Remove unnecessary cast that
1338 gcc -Wbad-function-cast diagnoses.
2037898d 1339 (gif_load): Fix pointer signedness.
6ae141d6
PE
1340 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1341 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 1342
33383987 13432011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 1344
d32df629
PE
1345 Improve quality of tests for time stamp overflow.
1346 For example, without this patch (encode-time 0 0 0 1 1
1347 1152921504606846976) returns the obviously-bogus value (-948597
1348 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1349 reports time overflow. See
1350 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
1351 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1352 * editfns.c: Include limits.h and intprops.h.
1353 (TIME_T_MIN, TIME_T_MAX): New macros.
1354 (time_overflow): Move earlier, to before first use.
1355 (hi_time, lo_time): New functions, for an accurate test for
1356 out-of-range times.
1357 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1358 (Fget_internal_run_time): Don't assume time_t fits in int.
1359 (make_time): Use list2 instead of Fcons twice.
1360 (Fdecode_time): More accurate test for out-of-range times.
1361 (check_tm_member): New function.
1362 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
1363 (lisp_time_argument): Don't rely on undefined left-shift and
1364 right-shift behavior when checking for time stamp overflow.
8be6f318 1365
fe31d94c
PE
1366 * editfns.c (time_overflow): New function, refactoring common code.
1367 (Fformat_time_string, Fdecode_time, Fencode_time):
1368 (Fcurrent_time_string): Use it.
1369
8be6f318
PE
1370 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1371 * dired.c (make_time): Move to ...
1372 * editfns.c (make_time): ... here.
1373 * systime.h: Note the move.
1374
09d9db2c 13752011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 1376
126bc0dc
YM
1377 * fringe.c (update_window_fringes): Remove unused variables.
1378
c47cbdfd
YM
1379 * unexmacosx.c (copy_data_segment): Also copy __got section.
1380 (Bug#8223)
1381
7ac80be9
EZ
13822011-03-12 Eli Zaretskii <eliz@gnu.org>
1383
c96bbc66 1384 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
1385 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1386 Constify `char *' arguments and their references according to
1387 prototypes in tparam.h.
1388
ecb0f94d 1389 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 1390
7ac80be9
EZ
1391 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1392 Adapt all references accordingly.
1393
1394 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1395
ef1fd07e
TT
13962011-03-11 Tom Tromey <tromey@redhat.com>
1397
1398 * buffer.c (syms_of_buffer): Remove obsolete comment.
1399
7ef4b50c
EZ
14002011-03-11 Eli Zaretskii <eliz@gnu.org>
1401
1402 * termhooks.h (encode_terminal_code): Declare prototype.
1403
1404 * msdos.c (encode_terminal_code): Don't declare prototype.
1405
1406 * term.c (encode_terminal_code): Now external again, used by
1407 w32console.c and msdos.c.
1408
44f230aa
SM
1409 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
1410 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 1411
4b1ec863 14122011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 1413
1714f52b 1414 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 1415
4b1ec863
PE
1416 * fringe.c (update_window_fringes): Mark locals as initialized
1417 (Bug#8227).
1418 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 1419
524c7aa6
PE
1420 * alloc.c (mark_fringe_data): Move decl from here ...
1421 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
1422 to check its interface.
1423 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
1424
a5c0af81 1425 * fontset.c (free_realized_fontset): Now static.
7519b8cd 1426 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 1427 (fontset_font): Mark local as initialized.
a9a06e0b 1428 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 1429
b4716021
PE
1430 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
1431
811e9bac 1432 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 1433 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
1434 (x_own_selection, Fx_disown_selection_internal): Rename locals
1435 to avoid shadowing.
1436 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 1437
7e3ab302
PE
1438 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
1439 so that the caller can use some name other than gcpro1.
1440 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
1441 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1442 (Fx_backspace_delete_keys_p):
1443 Use them to avoid shadowing, and rename vars to avoid shadowing.
1444 (x_decode_color, x_set_name, x_window): Now static.
6b437900 1445 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 1446 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
1447 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
1448 Remove unused locals.
7e3ab302
PE
1449 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1450 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
1451 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
1452 macros.
f78faa98 1453
e2b13473
PE
1454 * xterm.h (x_mouse_leave): New decl.
1455
77f23912
PE
1456 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
1457 Remove unused functions.
cdf4ba58
PE
1458 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
1459 (x_calc_absolute_position): Now static.
7411c686 1460 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 1461 Don't declare local "event" unless it's used.
ed7bf3a5
PE
1462 (x_iconify_frame, x_free_frame_resources): Don't declare locals
1463 unless they are used.
38d0b34a
PE
1464 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
1465 (x_fatal_error_signal): Remove; not used.
a6067996
PE
1466 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
1467 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
1468 (x_error_catcher, x_connection_closed, x_error_handler):
1469 (x_error_quitter, xembed_send_message, x_iconify_frame):
1470 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 1471 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 1472 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 1473
44f230aa
SM
1474 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
1475 Rename or move locals to avoid shadowing.
6b463e58 1476 (tty_defined_color, merge_face_heights): Now static.
5967d051 1477 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
1478 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
1479 does not deduce is never used uninitialized.
73719eba
PE
1480 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
1481 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 1482
426994c3 1483 * terminal.c (store_terminal_param): Now static.
5489860b 1484
032f1620 1485 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 1486 (set_frame_menubar): Remove unused local.
d4323972 1487 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
1488 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
1489 since they might point to immutable storage.
281585b0
PE
1490 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
1491 since it's unused otherwise.
032f1620 1492
367c19e5 1493 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 1494 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
1495 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
1496 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 1497 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
1498 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
1499 does not deduce are never used uninitialized.
70739cbe 1500
07b48fa9
PE
1501 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
1502
8868a238 1503 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
1504 * window.c (window_loop, size_window):
1505 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 1506
7e5cf297 1507 * window.c (display_buffer): Now static.
d6550a9f
PE
1508 (size_window): Mark variables that gcc -Wuninitialized
1509 does not deduce are never used uninitialized.
a586633d
PE
1510 * window.h (check_all_windows): New decl, to forestall
1511 gcc -Wmissing-prototypes diagnostic.
5b555da1 1512 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 1513
f6095868
PE
1514 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
1515 shadowing.
1516 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
1517 Include <limits.h>.
1518 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
1519 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
1520 (load_charset_map): Mark variables that gcc -Wuninitialized
1521 does not deduce are never used uninitialized.
53df7c11 1522 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 1523
f38b440c
PE
1524 * coding.c (coding_set_source, coding_set_destination):
1525 Use "else { /* comment */ }" rather than "else /* comment */;"
1526 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
1527 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
1528 a block, when the outer 'i' will do.
1529 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
1530 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
1531 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
1532 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
1533 (Fdecode_sjis_char, Fdefine_coding_system_internal):
1534 Rename locals to avoid shadowing.
1535 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
1536 * coding.c (emacs_mule_char, encode_invocation_designation):
1537 Now static, since they're not used elsewhere.
413bb2db 1538 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 1539 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
1540 (decode_coding_emacs_mule): Mark variables that gcc
1541 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
1542 (detect_coding_iso_2022): Initialize a local variable that might
1543 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 1544 this initialization is needed. (Bug#8211)
5f58e762
PE
1545 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
1546 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
1547 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
1548 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
1549 Remove unused macros.
f38b440c 1550
232b38b9 1551 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 1552 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 1553 * character.c (string_count_byte8): Likewise.
232b38b9 1554
fb90da1b
PE
1555 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
1556 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
1557
fb93dbc2
PE
1558 * chartab.c (copy_sub_char_table): Now static, since it's not used
1559 elsewhere.
5c156ace
PE
1560 (sub_char_table_ref_and_range, char_table_ref_and_range):
1561 Rename locals to avoid shadowing.
bbcd0949 1562 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 1563
7d3b3862 1564 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 1565 (BIDI_BOB): Remove unused macro.
7d3b3862 1566
6be7d3da
PE
1567 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
1568 deduce are never used uninitialized.
c2ed9c8b 1569 * term.c (encode_terminal_code): Likewise.
6be7d3da 1570
75f8807f 1571 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 1572
50938595
PE
1573 * tparam.h: New file.
1574 * term.c, tparam.h: Include it.
1575 * deps.mk (term.o, tparam.o): Depend on tparam.h.
1576 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
1577 Move these decls to tparam.h, and make them agree with what
1578 is actually in tparam.c. The previous trick of using incompatible
1579 decls in different modules does not conform to the C standard.
1580 All callers of tparam changed to use tparam's actual API.
1581 * tparam.c (tparam1, tparam, tgoto):
1582 Use const pointers where appropriate.
1583
fbceeba2
PE
1584 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
1585 * cm.h (struct cm): Likewise.
1586 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
1587 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
1588 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
1589 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
1590 (turn_on_face, init_tty): Likewise.
1591 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 1592
7f3f1250
PE
1593 * term.c (term_mouse_position): Rename local to avoid shadowing.
1594
e6ca6543
PE
1595 * alloc.c (mark_ttys): Move decl from here ...
1596 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
1597
c40f8d15
AS
15982011-03-11 Andreas Schwab <schwab@linux-m68k.org>
1599
1600 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
1601
cfe0661d
JB
16022011-03-09 Juanma Barranquero <lekktu@gmail.com>
1603
1604 * search.c (compile_pattern_1): Remove argument regp, unused since
1605 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
1606 (compile_pattern): Don't pass it.
1607
0afb4571
J
16082011-03-08 Jan Djärv <jan.h.d@swipnet.se>
1609
1610 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
1611 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
1612 for ! HAVE_GTK3.
1613 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
1614
1615 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
1616
1617 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
1618 gdk_window_get_screen, gdk_window_get_geometry,
1619 gdk_x11_window_lookup_for_display and GDK_KEY_g.
1620 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
1621 (xg_get_pixbuf_from_pixmap): New function.
1622 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
1623 to Pixmap, take frame as parameter, remove GdkColormap parameter.
1624 Call xg_get_pixbuf_from_pixmap instead of
1625 gdk_pixbuf_get_from_drawable.
1626 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
1627 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
1628 (xg_check_special_colors): Use GtkStyleContext and its functions
1629 for HAVE_GTK3.
1630 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
1631 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
1632 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
1633 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
1634 Call gtk_widget_get_preferred_size.
0afb4571
J
1635 (xg_frame_resized): gdk_window_get_geometry only takes 5
1636 parameters.
44f230aa
SM
1637 (xg_win_to_widget, xg_event_is_for_menubar):
1638 Call gdk_x11_window_lookup_for_display.
0afb4571
J
1639 (xg_set_widget_bg): New function.
1640 (delete_cb): New function.
1641 (xg_create_frame_widgets): connect delete-event to delete_cb.
1642 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
1643 (xg_set_background_color): Call xg_set_widget_bg.
1644 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
1645 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
1646 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
1647 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
1648 if ! HAVE_GTK3.
1649 (update_frame_tool_bar): Call gtk_widget_hide.
1650 (xg_initialize): Use GDK_KEY_g.
1651
1652 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
1653 if ! HAVE_GTK3
1654 (x_session_initialize): Call gdk_x11_set_sm_client_id.
1655
1656 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
1657 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
1658 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
1659
1c2cc4ef
JB
16602011-03-08 Juanma Barranquero <lekktu@gmail.com>
1661
1662 * w32xfns.c (select_palette): Check success of RealizePalette against
1663 GDI_ERROR, not zero.
1664
33383987 1665See ChangeLog.11 for earlier changes.
aac0c6e3
MR
1666
1667;; Local Variables:
1668;; coding: utf-8
aac0c6e3
MR
1669;; End:
1670
33383987 1671 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
1672
1673 This file is part of GNU Emacs.
1674
1675 GNU Emacs is free software: you can redistribute it and/or modify
1676 it under the terms of the GNU General Public License as published by
1677 the Free Software Foundation, either version 3 of the License, or
1678 (at your option) any later version.
1679
1680 GNU Emacs is distributed in the hope that it will be useful,
1681 but WITHOUT ANY WARRANTY; without even the implied warranty of
1682 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
1683 GNU General Public License for more details.
1684
1685 You should have received a copy of the GNU General Public License
1686 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.