1 2011-04-07 Paul Eggert <eggert@cs.ucla.edu>
3 Remove the doprnt implementation, as Emacs now uses vsnprintf.
5 * lisp.h (doprnt): Remove.
6 * Makefile.in (base_obj): Remove doprnt.o.
7 * deps.mk (doprnt.o): Remove.
9 error: Print 32- and 64-bit integers portably (Bug#8435).
10 Without this change, on typical 64-bit hosts error ("...%d...", N)
11 was used to print both 32- and 64-bit integers N, which relied on
13 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
15 * lisp.h (error, verror): Mark as printf-like functions.
16 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
17 Report overflow in size calculations when allocating printf buffer.
18 Do not truncate output string at its first null byte.
19 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
20 Truncate the output at a character boundary, since vsnprintf does not
22 * charset.c (check_iso_charset_parameter): Convert internal
23 character to string before calling 'error', since %c now has the
25 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
26 overflow when computing char to be passed to 'error'. Do not
27 pass Lisp_Object to 'error'; pass the integer instead.
28 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
29 formatted with plain %d.
31 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
33 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
35 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
37 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
39 * xterm.c (x_catch_errors): Remove duplicate declaration.
41 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
43 * xdisp.c, lisp.h (message_nolog): Remove; unused.
45 2011-04-06 Eli Zaretskii <eliz@gnu.org>
47 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
49 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
51 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
53 Fix more problems found by GCC 4.6.0's static checks.
55 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
57 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
59 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
61 * xdisp.c (vmessage): Mark as a printf-like function.
63 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
65 * sound.c (sound_warning): Don't crash if arg contains a printf format.
67 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
68 printf-like functions.
69 (tiff_load): Add casts to remove these marks before passing them
70 to system-supplied API.
72 * eval.c (Fsignal): Remove excess argument to 'fatal'.
74 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
75 This avoids several warnings with gcc -Wstrict-overflow.
76 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
77 directly, rather than having caller test rule sign. This avoids
78 some unnecessary tests.
79 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
80 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
81 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
83 * xfont.c (xfont_text_extents): Remove var that was set but not used.
84 (xfont_open): Avoid unnecessary tests.
86 * composite.c (composition_gstring_put_cache): Use unsigned integer.
88 * composite.h, composite.c (composition_gstring_put_cache):
89 Use EMACS_INT, not int, for length.
91 * composite.h (COMPOSITION_DECODE_REFS): New macro,
92 breaking out part of COMPOSITION_DECODE_RULE.
93 (COMPOSITION_DECODE_RULE): Use it.
94 * composite.c (get_composition_id): Remove unused local vars,
95 by using the new macro.
97 * textprop.c (set_text_properties_1): Change while to do-while,
98 since the condition is always true at first.
100 * intervals.c (graft_intervals_into_buffer): Mark var as used.
101 (interval_deletion_adjustment): Return unsigned value.
104 * process.c (list_processes_1, create_pty, read_process_output):
105 (exec_sentinel): Remove vars that were set but not used.
106 (create_pty): Remove unnecessary "volatile"s.
107 (Fnetwork_interface_info): Avoid possibility of int overflow.
108 (read_process_output): Do adaptive read buffering even if carryover.
109 (read_process_output): Simplify nbytes computation if buffered.
111 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
113 * syntax.c (scan_words): Remove var that was set but not used.
114 (update_syntax_table): Use unsigned instead of int.
116 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
117 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
118 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
120 * print.c (print_error_message): Avoid int overflow.
122 * font.c (font_list_entities): Redo for clarity,
123 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
125 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
126 (font_score): Avoid potential overflow in diff calculation.
128 * fns.c (substring_both): Remove var that is set but not used.
129 (sxhash): Redo loop for clarity and to avoid wraparound warning.
131 * eval.c (funcall_lambda): Rename local to avoid shadowing.
133 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
134 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
135 can always succeed if overflow has undefined behavior.
137 * search.c (boyer_moore, wordify): Remove vars set but not used.
138 (wordify): Omit three unnecessary tests.
140 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
141 All callers changed. This avoids the need for an unused var.
143 * casefiddle.c (casify_region): Remove var that is set but not used.
145 * dired.c (file_name_completion): Remove var that is set but not used.
147 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
149 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
150 (Finsert_file_contents): Remove unnecessary code checking fd.
152 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
153 Check for integer overflow on size calculations.
155 * buffer.c (Fprevious_overlay_change): Remove var that is set
158 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
159 Remove vars that are set but not used.
160 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
161 (timer_check_2): Mark vars as initialized.
163 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
165 * image.c (lookup_image): Remove var that is set but not used.
166 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
168 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
169 that are set but not used.
171 * xfns.c (make_invisible_cursor): Don't return garbage
172 if XCreateBitmapFromData fails (Bug#8410).
174 * xselect.c (x_get_local_selection, x_handle_property_notify):
175 Remove vars that are set but not used.
177 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
178 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
180 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
181 Remove var that is set but not used.
182 (scroll_bar_windows_size): Now size_t, not int.
183 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
186 * xfaces.c (realize_named_face): Remove vars that are set but not used.
187 (map_tty_color) [!defined MSDOS]: Likewise.
189 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
191 * coding.c: Remove vars that are set but not used.
192 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
194 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
195 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
196 (decode_coding_charset): Remove vars that are set but not used.
198 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
199 that is set but not used.
201 * print.c (print_object): Remove var that is set but not used.
203 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
204 The gnulib version avoids calling malloc in the usual case,
205 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
206 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
207 * filelock.c (current_lock_owner): Likewise.
208 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
209 * sysdep.c: Include allocator.h, careadlinkat.h.
210 (emacs_no_realloc_allocator): New static constant.
211 (emacs_readlink): New function.
212 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
213 ../lib/careadlinkat.h.
215 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
217 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
218 first non-nil return value).
220 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
222 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
223 if not defined (Bug#8403).
225 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
227 * xdisp.c (display_count_lines): Remove parameter `start',
228 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
229 (get_char_face_and_encoding): Remove parameter `multibyte_p',
230 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
231 (fill_stretch_glyph_string): Remove parameters `row' and `area',
232 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
233 and thereabouts. All callers changed.
234 (get_per_char_metric): Remove parameter `f', unused since
235 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
237 2011-04-02 Jim Meyering <meyering@redhat.com>
239 do not dereference NULL upon failed strdup
240 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
241 (ns_get_family): Likewise.
243 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
245 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
247 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
249 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
252 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
256 * window.c (Ftemp_output_buffer_show): New fun.
257 (Fsave_window_excursion):
258 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
260 * lread.c (lisp_file_lexically_bound_p): New function.
261 (Fload): Bind Qlexical_binding.
262 (readevalloop): Remove `evalfun' arg.
263 Bind Qinternal_interpreter_environment.
264 (Feval_buffer): Bind Qlexical_binding.
265 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
267 (syms_of_lread): Declare `lexical-binding'.
269 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
271 * keyboard.c (eval_dyn): New fun.
272 (menu_item_eval_property): Use it.
274 * image.c (parse_image_spec): Use Ffunctionp.
276 * fns.c (concat, mapcar1): Accept byte-code-functions.
278 * eval.c (Fsetq): Handle lexical vars.
279 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
280 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
281 (FletX, Flet): Obey lexical binding.
282 (Fcommandp): Handle closures.
283 (Feval): New `lexical' arg.
284 (eval_sub): New function extracted from Feval. Use it almost
285 everywhere where Feval was used. Look up vars in lexical env.
287 (Ffunctionp): Move from subr.el.
288 (Ffuncall): Handle closures.
289 (apply_lambda): Remove `eval_flags'.
290 (funcall_lambda): Handle closures and new byte-code-functions.
291 (Fspecial_variable_p): New function.
292 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
293 but without exporting it to Lisp.
295 * doc.c (Fdocumentation, store_function_docstring):
296 * data.c (Finteractive_form): Handle closures.
298 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
301 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
303 (exec_byte_code): New function extracted from Fbyte_code to handle new
304 calling convention for byte-code-functions. Add new byte-codes.
306 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
308 * alloc.c (Fmake_symbol): Init new `declared_special' field.
310 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
312 * xdisp.c (redisplay_internal): Fix prototype.
314 2011-03-31 Eli Zaretskii <eliz@gnu.org>
316 * xdisp.c (SCROLL_LIMIT): New macro.
317 (try_scrolling): Use it when setting scroll_limit. Limit
318 scrolling to 100 screen lines.
319 (redisplay_window): Even when falling back on "recentering",
320 position point in the window according to scroll-conservatively,
321 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
323 (try_scrolling): When point is above the window, allow searching
324 as far as scroll_max, or one screenful, to compute vertical
325 distance from PT to the scroll margin position. This prevents
326 try_scrolling from unnecessarily failing when
327 scroll-conservatively is set to a value slightly larger than the
328 window height. Clean up the case of PT below the margin at bottom
329 of window: scroll_max can no longer be INT_MAX. When aggressive
330 scrolling is in use, don't let point enter the opposite scroll
331 margin as result of the scroll.
332 (syms_of_xdisp) <scroll-conservatively>: Document the
333 threshold of 100 lines for never-recentering scrolling.
335 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
337 * dispextern.h (move_it_by_lines):
338 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
339 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
340 (message_log_check_duplicate): Remove parameters `prev_bol' and
341 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
342 (redisplay_internal): Remove parameter `preserve_echo_area',
343 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
345 * indent.c (Fvertical_motion):
346 * window.c (window_scroll_pixel_based, Frecenter):
347 Don't pass `need_y_p' to `move_it_by_lines'.
349 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
351 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
352 steal a few bits to be more compact.
353 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
354 Remove unneeded casts.
356 * bytecode.c (Fbyte_code): CAR and CDR can GC.
358 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
360 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
361 binding" message (bug#7967).
363 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
365 Fix more problems found by GCC 4.6.0's static checks.
367 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
368 Remove unused local var.
370 * editfns.c (Fmessage_box): Remove unused local var.
372 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
373 (note_mode_line_or_margin_highlight, note_mouse_highlight):
374 Omit unused local vars.
375 * window.c (shrink_windows): Omit unused local var.
376 * menu.c (digest_single_submenu): Omit unused local var.
377 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
378 Omit unused local var.
380 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
381 Don't assume string length fits in int.
382 (keyremap_step, read_key_sequence): Use size_t for sizes.
383 (read_key_sequence): Don't check last_real_key_start redundantly.
385 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
386 instead of alloca (Bug#8344).
388 * eval.c (Fbacktrace): Don't assume nargs fits in int.
389 (Fbacktrace_frame): Don't assume nframes fits in int.
391 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
393 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
396 * term.c (produce_glyphless_glyph): Remove unnecessary test.
398 * cm.c (calccost): Turn while-do into do-while, for clarity.
400 * keyboard.c (syms_of_keyboard): Use the same style as later
401 in this function when indexing through an array. This also
402 works around GCC bug 48267.
404 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
406 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
408 * chartab.c (sub_char_table_ref_and_range): Redo for slight
409 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
411 * keyboard.c, keyboard.h (num_input_events): Now size_t.
412 This avoids undefined behavior on integer overflow, and is a bit
413 more convenient anyway since it is compared to a size_t variable.
415 Variadic C functions now count arguments with size_t, not int.
416 This avoids an unnecessary limitation on 64-bit machines, which
417 caused (substring ...) to crash on large vectors (Bug#8344).
418 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
419 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
420 All variadic functions and their callers changed accordingly.
421 (struct gcpro.nvars): Now size_t, not int. All uses changed.
422 * data.c (arith_driver, float_arith_driver): Likewise.
423 * editfns.c (general_insert_function): Likewise.
424 * eval.c (struct backtrace.nargs, interactive_p)
425 (internal_condition_case_n, run_hook_with_args, apply_lambda)
426 (funcall_lambda, mark_backtrace): Likewise.
427 * fns.c (concat): Likewise.
428 * frame.c (x_set_frame_parameters): Likewise.
429 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
430 0 if not found, not -1. All callers changed.
432 * alloc.c (garbage_collect): Don't assume stack size fits in int.
433 (stack_copy_size): Now size_t, not int.
434 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
436 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
438 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
439 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
442 * lisp.h (multibyte_char_to_unibyte):
443 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
444 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
445 * character.h (CHAR_TO_BYTE8):
446 * cmds.c (internal_self_insert):
447 * editfns.c (general_insert_function):
448 * keymap.c (push_key_description):
449 * search.c (Freplace_match):
450 * xdisp.c (message_dolog, set_message_1): All callers changed.
452 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
454 * keyboard.c (safe_run_hook_funcall): New function.
455 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
456 don't set the hook to nil, but remove the offending function instead.
457 (Qcommand_hook_internal): Remove, unused.
458 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
459 Vcommand_hook_internal.
461 * eval.c (enum run_hooks_condition): Remove.
462 (funcall_nil, funcall_not): New functions.
463 (run_hook_with_args): Call each function through a `funcall' argument.
464 Remove `cond' argument, now redundant.
465 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
466 (Frun_hook_with_args_until_failure): Adjust accordingly.
467 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
469 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
471 * dispextern.h (string_buffer_position): Remove declaration.
473 * print.c (strout): Remove parameter `multibyte', unused since
474 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
476 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
477 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
480 * w32.c (_wsa_errlist): Use braces for struct initializers.
482 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
483 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
485 (string_buffer_position): Likewise. Also, make static (it's never
486 used outside xdisp.c).
487 (cursor_row_p): Remove parameter `w', unused since
488 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
489 (decode_mode_spec): Remove parameter `precision', introduced during
490 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
493 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
495 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
497 2011-03-27 Anders Lindgren <andlind@gmail.com>
499 * nsterm.m (ns_menu_bar_is_hidden): New variable.
500 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
501 (ns_update_auto_hide_menu_bar): New functions.
502 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
503 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
504 ns_constrain_all_frames.
505 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
506 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
508 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
510 * nsmenu.m (runDialogAt): Remove argument to timer_check.
512 2011-03-27 Glenn Morris <rgm@gnu.org>
514 * syssignal.h: Replace RETSIGTYPE with void.
515 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
516 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
517 Replace SIGTYPE with void everywhere.
518 * s/usg5-4-common.h (SIGTYPE): Remove definition.
519 * s/template.h (SIGTYPE): Remove commented out definition.
521 2011-03-26 Eli Zaretskii <eliz@gnu.org>
523 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
524 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
526 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
528 * w32.c (read_unc_volume): Use parameter `henum', instead of
529 global variable `wget_enum_handle'.
531 * keymap.c (describe_vector): Remove parameters `indices' and
532 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
533 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
535 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
537 * keyboard.c (timer_check): Remove parameter `do_it_now',
538 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
539 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
540 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
542 * keyboard.c (read_char):
543 * w32menu.c (w32_menu_display_help):
544 * xmenu.c (show_help_event, menu_help_callback):
545 Adjust calls to `show_help_echo'.
547 * gtkutil.c (xg_maybe_add_timer):
548 * keyboard.c (readable_events):
549 * process.c (wait_reading_process_output):
550 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
552 * insdel.c (adjust_markers_gap_motion):
553 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
554 (gap_left, gap_right): Don't call it.
556 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
558 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
559 incurred during fontification.
561 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
563 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
564 (DEFVAR_PER_BUFFER): Don't pass it.
566 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
567 (scrolling_window): Don't pass it.
569 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
571 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
573 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
575 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
576 of variables specific to SELinux and computation of `encoded_absname'.
578 * image.c (XPutPixel): Remove unused variable `height'.
580 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
582 * unexw32.c (get_section_info): Remove unused variable `section'.
584 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
585 (system_process_attributes): Remove unused variable `sess'.
586 (sys_read): Remove unused variable `err'.
588 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
589 (w32_wnd_proc): Remove unused variable `isdead'.
590 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
591 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
592 (x_create_tip_frame): Remove unused variable `tem'.
594 * w32inevt.c (w32_console_read_socket):
595 Remove unused variable `no_events'.
597 * w32term.c (x_draw_composite_glyph_string_foreground):
598 Remove unused variable `width'.
600 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
602 * w32term.c (x_set_glyph_string_clipping):
603 Don't pass uninitialized region to CombineRgn.
605 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
607 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
608 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
609 (Fx_close_connection): Remove unused variable `i'.
611 * w32font.c (w32font_draw): Return number of glyphs.
612 (w32font_open_internal): Remove unused variable `i'.
613 (w32font_driver): Add missing initializer.
615 * w32menu.c (utf8to16): Remove unused variable `utf16'.
616 (fill_in_menu): Remove unused variable `items_added'.
618 * w32term.c (last_mouse_press_frame): Remove static global variable.
619 (w32_clip_to_row): Remove unused variable `f'.
620 (x_delete_terminal): Remove unused variable `i'.
622 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
623 (NOTHING): Remove unused static global variable.
624 (uniscribe_check_otf): Remove unused variable `table'.
625 (uniscribe_font_driver): Add missing initializers.
627 2011-03-23 Julien Danjou <julien@danjou.info>
629 * term.c (Fsuspend_tty, Fresume_tty):
630 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
631 * window.c (temp_output_buffer_show):
632 * insdel.c (signal_before_change):
633 * frame.c (Fhandle_switch_frame):
634 * fileio.c (Fdo_auto_save):
635 * emacs.c (Fkill_emacs):
636 * editfns.c (save_excursion_restore):
637 * cmds.c (internal_self_insert):
638 * callint.c (Fcall_interactively):
639 * buffer.c (Fkill_all_local_variables):
640 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
642 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
643 unconditionnaly since it does the check itself.
645 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
647 Fix more problems found by GCC 4.5.2's static checks.
649 * coding.c (encode_coding_raw_text): Avoid unnecessary test
650 the first time through the loop, since we know p0 < p1 then.
651 This also avoids a gcc -Wstrict-overflow warning.
653 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
654 leading to a memory leak, possible in functions like
655 load_charset_map_from_file that can allocate an unbounded number
656 of objects (Bug#8318).
658 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
659 that could (at least in theory) be that large.
661 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
662 This is less likely to overflow, and avoids undefined behavior if
663 overflow does occur. All callers changed. Use strtoul to scan
664 for the unsigned long integer.
665 (pint2hrstr): Simplify and tune code slightly.
666 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
668 * scroll.c (do_scrolling): Work around GCC bug 48228.
669 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
671 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
672 This also avoids a warning with gcc -Wstrict-overflow.
673 (validate_x_resource_name): Simplify count usage.
674 This also avoids a warning with gcc -Wstrict-overflow.
676 * fileio.c (Fcopy_file): Report error if fchown or fchmod
679 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
681 * process.c (Fmake_network_process): Use socklen_t, not int,
682 where POSIX says socklen_t is required in portable programs.
683 This fixes a porting bug on hosts like 64-bit HP-UX, where
684 socklen_t is wider than int (Bug#8277).
685 (Fmake_network_process, server_accept_connection):
686 (wait_reading_process_output, read_process_output):
689 * process.c: Rename or move locals to avoid shadowing.
690 (list_processes_1, Fmake_network_process):
691 (read_process_output_error_handler, exec_sentinel_error_handler):
692 Rename or move locals.
693 (Fmake_network_process): Define label "retry_connect" only if needed.
694 (Fnetwork_interface_info): Fix pointer signedness.
695 (process_send_signal): Add cast to avoid pointer signedness problem.
696 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
697 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
699 Make tparam.h and terminfo.c consistent.
700 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
701 Include tparam.h instead, since it declares them.
702 * cm.h (PC): Remove extern decl; tparam.h now does this.
703 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
704 * terminfo.c: Include tparam.h, to check interfaces.
705 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
706 (tparam): Adjust signature to match interface in tparam.h;
707 this removes some undefined behavior. Check that outstring and len
708 are zero, which they always are with Emacs.
709 * tparam.h (PC, BC, UP): New extern decls.
711 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
712 (xftfont_open): Rename locals to avoid shadowing.
714 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
715 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
716 (OTF_TAG_SYM): Omit macro if not needed.
717 (ftfont_list): Remove unused local.
718 (get_adstyle_property, ftfont_pattern_entity):
719 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
720 Rename locals to avoid shadowing.
722 * xfont.c (xfont_list_family): Mark var as initialized.
724 * xml.c (make_dom): Now static.
726 * composite.c (composition_compute_stop_pos): Rename local to
728 (composition_reseat_it): Remove unused locals.
729 (find_automatic_composition, composition_adjust_point): Likewise.
730 (composition_update_it): Mark var as initialized.
731 (find_automatic_composition): Mark vars as initialized,
732 with a FIXME (Bug#8290).
734 character.h: Rename locals to avoid shadowing.
735 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
736 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
737 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
738 (BUF_DEC_POS): Be more systematic about renaming local temporaries
741 * textprop.c (property_change_between_p): Remove; unused.
743 * intervals.c (interval_start_pos): Now static.
745 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
747 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
748 Rename locals to avoid shadowing.
750 * sound.c (wav_play, au_play, Fplay_sound_internal):
751 Fix pointer signedness.
752 (alsa_choose_format): Remove unused local var.
753 (wav_play): Initialize a variable to 0, to prevent undefined
756 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
758 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
760 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
761 clobbering (Bug#8298).
762 * sysdep.c (sys_subshell): Likewise.
763 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
765 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
766 This should get cleaned up, so that child_setup has the
767 same signature on all platforms.
769 * callproc.c (call_process_cleanup): Now static.
770 (relocate_fd): Rename locals to avoid shadowing.
772 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
774 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
775 not to be necessary, and produces flickering.
777 2011-03-20 Glenn Morris <rgm@gnu.org>
779 * config.in: Remove file.
781 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
783 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
784 are now in src/globals.h.
785 (syms_of_minibuf): Remove spurious & from previous change.
787 2011-03-20 Leo <sdl.web@gmail.com>
789 * minibuf.c (completing-read-function): New variable.
790 (completing-read-default): Rename from completing-read.
791 (completing-read): Call completing-read-function.
793 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
795 * xfaces.c (Fx_load_color_file):
796 Read color file from absolute filename (bug#8250).
798 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
800 * makefile.w32-in: Update dependencies.
802 2011-03-17 Eli Zaretskii <eliz@gnu.org>
804 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
806 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
808 Fix more problems found by GCC 4.5.2's static checks.
810 * process.c (make_serial_process_unwind, send_process_trap):
811 (sigchld_handler): Now static.
813 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
814 That way, the code declares only the vars that it needs.
815 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
816 * s/cygwin.h (PTY_ITERATION): Likewise.
817 * s/darwin.h (PTY_ITERATION): Likewise.
818 * s/gnu-linux.h (PTY_ITERATION): Likewise.
820 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
821 * process.c (allocate_pty): Don't declare stb unless it's needed.
823 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
824 (CONSTANTLIM): Remove; unused.
825 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
826 Define only if needed.
828 * unexelf.c (unexec): Name an expression,
829 to avoid gcc -Wbad-function-cast warning.
830 Use a different way to cause a compilation error if anyone uses
831 n rather than nn, a way that does not involve shadowing.
832 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
834 * deps.mk (unexalpha.o): Remove; unused.
836 New file unexec.h, the (simple) interface for unexec (Bug#8267).
837 * unexec.h: New file.
838 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
839 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
841 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
842 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
843 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
844 Change as necessary to match prototype in unexec.h.
846 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
848 (back_comment, skip_chars): Mark vars as initialized.
850 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
851 Rename locals to avoid shadowing.
853 * lread.c (read1): Rewrite so as not to use empty "else".
854 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
856 * print.c (Fredirect_debugging_output): Fix pointer signedess.
858 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
859 warning when compiling print.c.
861 * font.c (font_unparse_fcname): Abort in an "impossible" situation
862 instead of using an uninitialized var.
863 (font_sort_entities): Mark var as initialized.
865 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
867 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
868 pointers to constants.
869 (font_parse_fcname): Remove unused vars.
870 (font_delete_unmatched): Now static.
871 (font_get_spec): Remove; unused.
872 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
873 (font_update_drivers, Ffont_get_glyphs, font_add_log):
874 Rename or move locals to avoid shadowing.
876 * fns.c (require_nesting_list, require_unwind): Now static.
877 (Ffillarray): Rename locals to avoid shadowing.
879 * floatfns.c (domain_error2): Define only if needed.
880 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
882 * alloc.c (mark_backtrace): Move decl from here ...
883 * lisp.h: ... to here, so that it can be checked.
885 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
886 (Fdefvar): Rewrite so as not to use empty "else".
887 (lisp_indirect_variable): Name an expression,
888 to avoid gcc -Wbad-function-cast warning.
889 (Fdefvar): Rename locals to avoid shadowing.
891 * callint.c (quotify_arg, quotify_args): Now static.
892 (Fcall_interactively): Rename locals to avoid shadowing.
893 Use const pointer when appropriate.
895 * lisp.h (get_system_name, get_operating_system_release):
896 Move decls here, to check interfaces.
897 * process.c (get_operating_system_release): Move decl to lisp.h.
898 * xrdb.c (get_system_name): Likewise.
899 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
900 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
901 some of which prompt warnings from gcc -Wbad-function-cast.
902 (Fformat_time_string, Fencode_time, Finsert_char):
903 (Ftranslate_region_internal, Fformat):
904 Rename or remove local vars to avoid shadowing.
905 (Ftranslate_region_internal): Mark var as initialized.
907 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
910 * lisp.h (eassert): Check that the argument compiles, even if
911 ENABLE_CHECKING is not defined.
913 * data.c (Findirect_variable): Name an expression, to avoid
914 gcc -Wbad-function-cast warning.
915 (default_value, arithcompare, arith_driver, arith_error): Now static.
916 (store_symval_forwarding): Rename local to avoid shadowing.
917 (Fmake_variable_buffer_local, Fmake_local_variable):
918 Mark variables as initialized.
919 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
921 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
922 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
923 Rename locals to avoid shadowing.
924 (mark_stack): Move local variables into the #ifdef region where
926 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
927 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
929 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
930 (GC_STRING_CHARS): Remove; not used.
931 (Fmemory_limit): Cast sbrk's returned value to char *.
933 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
934 avoids undefined behavior in theory.
936 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
938 Use functions, not macros, for up- and down-casing (Bug#8254).
939 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
940 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
941 to use the following functions instead of these macros.
942 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
943 EMACS_INT, since callers assume the returned value fits in int.
944 (upcase1): Likewise, for UPCASE_TABLE.
945 (uppercasep, lowercasep, upcase): New static inline functions.
946 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
947 the race-condition problem in the old DOWNCASE.
949 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
950 Rename locals to avoid shadowing.
951 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
952 (regex_compile, re_search_2, re_match_2_internal):
953 Remove unused local vars.
954 (FREE_VAR): Rewrite so as not to use empty "else",
955 which gcc can warn about.
956 (regex_compile, re_match_2_internal): Mark locals as initialized.
957 (RETALLOC_IF): Define only if needed.
958 (WORDCHAR_P): Likewise. This one is never needed, but is used
959 only in a comment talking about a compiler bug, so put inside
960 the #if 0 of that comment.
961 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
962 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
965 * search.c (boyer_moore): Rename locals to avoid shadowing.
966 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
967 (PREV_CHAR_BOUNDARY): Likewise.
969 * search.c (simple_search): Remove unused var.
971 * dired.c (compile_pattern): Move decl from here ...
972 * lisp.h: ... to here, so that it can be checked.
973 (struct re_registers): New forward decl.
975 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
977 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
979 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
980 Rename locals to avoid shadowing.
981 (Fvertical_motion): Mark locals as initialized.
983 * casefiddle.c (casify_object, casify_region): Now static.
984 (casify_region): Mark local as initialized.
986 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
988 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
989 New macros, so that the caller can use some names other than
991 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
993 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
994 argument, for consistency with GCPRO2_VAR, etc: it is now the
995 prefix of the variable, not the variable itself. All uses
997 * dired.c (directory_files_internal, file_name_completion):
998 Rename locals to avoid shadowing.
1000 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1001 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1002 dired.c's scmp function, had undefined behavior.
1003 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1004 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1005 * buffer.h: ... to here, because these macros use current_buffer,
1006 and the new implementation with inline functions needs to have
1007 current_buffer in scope now, rather than later when the macros
1009 (downcase, upcase1): New static inline functions.
1010 (DOWNCASE, UPCASE1): Reimplement using these functions.
1011 This avoids undefined behavior in expressions like
1012 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1013 from race conditions in accessing the global variables
1014 case_temp1 and case_temp2.
1015 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1016 * lisp.h (case_temp1, case_temp2): Remove their decls.
1017 * character.h (ASCII_CHAR_P): Move from here ...
1018 * lisp.h: ... to here, so that the inline functions mentioned
1021 * dired.c (directory_files_internal_unwind): Now static.
1023 * fileio.c (file_name_as_directory, directory_file_name):
1024 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1026 (file_name_as_directory): Use const pointers when appropriate.
1027 (Fexpand_file_name): Likewise. In particular, newdir might
1028 point at constant storage, so make it a const pointer.
1029 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
1030 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1032 (Fset_file_times, Finsert_file_contents, auto_save_error):
1033 Rename locals to avoid shadowing.
1035 * minibuf.c (choose_minibuf_frame_1): Now static.
1036 (Ftry_completion, Fall_completions): Rename or remove locals
1039 * marker.c (bytepos_to_charpos): Remove; unused.
1041 * lisp.h (verify_bytepos, count_markers): New decls,
1042 so that gcc does not warn that these functions aren't declared.
1044 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1045 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
1046 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
1047 (copy_text): Remove unused local var.
1049 * filelock.c (within_one_second): Now static.
1050 (lock_file_1): Rename local to avoid shadowing.
1052 * buffer.c (fix_overlays_before): Mark locals as initialized.
1053 (fix_start_end_in_overlays): Likewise. This function should be
1054 simplified by using pointers-to-pointers, but that's a different
1056 (switch_to_buffer_1): Now static.
1057 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1058 (report_overlay_modification): Rename locals to avoid shadowing.
1060 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
1061 Fix pointer signedness issue.
1062 (sys_subshell): Mark local as volatile if checking for lint,
1063 to suppress a gcc -Wclobbered warning that does not seem to be right.
1064 (MAXPATHLEN): Define only if needed.
1066 * process.c (serial_open, serial_configure): Move decls from here ...
1067 * systty.h: ... to here, so that they can be checked.
1069 * fns.c (get_random, seed_random): Move extern decls from here ...
1070 * lisp.h: ... to here, so that they can be checked.
1072 * sysdep.c (reset_io): Now static.
1073 (wait_for_termination_signal): Remove; unused.
1075 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1076 (copy_keymap_item, append_key, push_text_char_description):
1078 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
1079 (DENSE_TABLE_SIZE): Remove; unused.
1080 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1081 (describe_map_tree):
1082 Rename locals to avoid shadowing.
1084 * keyboard.c: Declare functions static if they are not used elsewhere.
1085 (echo_char, echo_dash, cmd_error, top_level_2):
1086 (poll_for_input, handle_async_input): Now static.
1087 (read_char, kbd_buffer_get_event, make_lispy_position):
1088 (make_lispy_event, make_lispy_movement, apply_modifiers):
1089 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1090 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1091 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
1092 (read_key_sequence, read_char): Mark locals as initialized.
1093 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
1095 * keyboard.h (make_ctrl_char): New decl.
1096 (mark_kboards): Move decl here ...
1097 * alloc.c (mark_kboards): ... from here.
1099 * lisp.h (force_auto_save_soon): New decl.
1101 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
1102 (DEFINE_DUMMY_FUNCTION): New macro.
1103 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1105 (main): Add casts to avoid warnings
1106 if GCC considers string literals to be constants.
1108 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1110 * dbusbind.c: Pointer signedness fixes.
1111 (xd_signature, xd_append_arg, xd_initialize):
1112 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1113 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1114 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1115 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1117 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1118 if GCC considers string literals to be constants.
1119 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
1121 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1123 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1124 (print_preprocess, print_object): New macro to fix last change.
1126 * print.c (print_preprocess): Don't forget font objects.
1128 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
1130 * emacs.c (USAGE3): Doc fixes.
1132 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1134 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1137 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
1139 * lisp.h (VWindow_system, Qfile_name_history):
1140 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1141 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1142 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1144 * w32select.c: Don't #include "keyboard.h".
1145 (run_protected): Add extern declaration for waiting_for_input.
1147 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1148 * w32console.c (detect_input_pending, read_input_pending)
1149 (encode_terminal_code):
1150 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1151 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1152 (w32_system_caret_y, Qfile_name_history):
1153 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1154 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1155 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1156 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1157 * w32proc.c (Qlocal, report_file_error):
1158 * w32term.c (Vwindow_system, updating_frame):
1159 * w32uniscribe.c (initialized, uniscribe_font_driver):
1160 Remove unneeded extern declarations.
1162 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
1164 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
1166 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
1168 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1169 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1170 These macros can no longer be used for assignment.
1172 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1173 Assign struct members directly, instead of using BUF_BEGV etc.
1174 (record_buffer_markers, fetch_buffer_markers): New functions for
1175 recording and fetching special buffer markers.
1176 (set_buffer_internal_1, set_buffer_temp): Use them.
1178 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1180 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1182 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1183 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1185 * xdisp.c (hscroll_window_tree):
1186 (reconsider_clip_changes): Use PT instead of BUF_PT.
1188 2011-03-13 Eli Zaretskii <eliz@gnu.org>
1190 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1191 $(EMACS_ROOT)/lib/intprops.h.
1193 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1195 Fix more problems found by GCC 4.5.2's static checks.
1197 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1198 to unsigned char * to avoid compiler diagnostic.
1199 (xg_free_frame_widgets): Make it clear that a local variable is
1200 needed only if USE_GTK_TOOLTIP.
1201 (gdk_window_get_screen): Make it clear that this macro is needed
1202 only if USE_GTK_TOOLTIP.
1203 (int_gtk_range_get_value): New function, which avoids a diagnostic
1204 from gcc -Wbad-function-cast.
1205 (xg_set_toolkit_scroll_bar_thumb): Use it.
1206 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1207 diagnostic from gcc -Wbad-function-cast.
1208 (get_utf8_string, xg_get_file_with_chooser):
1209 Rename locals to avoid shadowing.
1210 (create_dialog): Move locals to avoid shadowing.
1212 * xgselect.c (xg_select): Remove unused var.
1214 * image.c (four_corners_best): Mark locals as initialized.
1215 (gif_load): Initialize transparent_p to zero (Bug#8238).
1216 Mark another local as initialized.
1217 (my_png_error, my_error_exit): Mark with NO_RETURN.
1219 * image.c (clear_image_cache): Now static.
1220 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
1221 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
1222 (x_edge_detection): Remove unnecessary cast that
1223 gcc -Wbad-function-cast diagnoses.
1224 (gif_load): Fix pointer signedness.
1225 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1226 (jpeg_load, gif_load): Rename locals to avoid shadowing.
1228 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
1230 Improve quality of tests for time stamp overflow.
1231 For example, without this patch (encode-time 0 0 0 1 1
1232 1152921504606846976) returns the obviously-bogus value (-948597
1233 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1234 reports time overflow. See
1235 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
1236 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1237 * editfns.c: Include limits.h and intprops.h.
1238 (TIME_T_MIN, TIME_T_MAX): New macros.
1239 (time_overflow): Move earlier, to before first use.
1240 (hi_time, lo_time): New functions, for an accurate test for
1242 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1243 (Fget_internal_run_time): Don't assume time_t fits in int.
1244 (make_time): Use list2 instead of Fcons twice.
1245 (Fdecode_time): More accurate test for out-of-range times.
1246 (check_tm_member): New function.
1247 (Fencode_time): Use it, to test for out-of-range times.
1248 (lisp_time_argument): Don't rely on undefined left-shift and
1249 right-shift behavior when checking for time stamp overflow.
1251 * editfns.c (time_overflow): New function, refactoring common code.
1252 (Fformat_time_string, Fdecode_time, Fencode_time):
1253 (Fcurrent_time_string): Use it.
1255 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1256 * dired.c (make_time): Move to ...
1257 * editfns.c (make_time): ... here.
1258 * systime.h: Note the move.
1260 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1262 * fringe.c (update_window_fringes): Remove unused variables.
1264 * unexmacosx.c (copy_data_segment): Also copy __got section.
1267 2011-03-12 Eli Zaretskii <eliz@gnu.org>
1269 * termcap.c [MSDOS]: Include "msdos.h".
1270 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1271 Constify `char *' arguments and their references according to
1272 prototypes in tparam.h.
1274 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
1276 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1277 Adapt all references accordingly.
1279 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1281 2011-03-11 Tom Tromey <tromey@redhat.com>
1283 * buffer.c (syms_of_buffer): Remove obsolete comment.
1285 2011-03-11 Eli Zaretskii <eliz@gnu.org>
1287 * termhooks.h (encode_terminal_code): Declare prototype.
1289 * msdos.c (encode_terminal_code): Don't declare prototype.
1291 * term.c (encode_terminal_code): Now external again, used by
1292 w32console.c and msdos.c.
1294 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
1295 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
1297 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
1299 Fix some minor problems found by GCC 4.5.2's static checks.
1301 * fringe.c (update_window_fringes): Mark locals as initialized
1303 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
1305 * alloc.c (mark_fringe_data): Move decl from here ...
1306 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
1307 to check its interface.
1308 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
1310 * fontset.c (free_realized_fontset): Now static.
1311 (Fset_fontset_font): Rename local to avoid shadowing.
1312 (fontset_font): Mark local as initialized.
1313 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
1315 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
1317 * xselect.c (x_disown_buffer_selections): Remove; not used.
1318 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
1319 (x_own_selection, Fx_disown_selection_internal): Rename locals
1321 (x_handle_dnd_message): Remove local to avoid shadowing.
1323 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
1324 so that the caller can use some name other than gcpro1.
1325 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
1326 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1327 (Fx_backspace_delete_keys_p):
1328 Use them to avoid shadowing, and rename vars to avoid shadowing.
1329 (x_decode_color, x_set_name, x_window): Now static.
1330 (Fx_create_frame): Add braces to silence GCC warning.
1331 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
1332 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
1333 Remove unused locals.
1334 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1335 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
1336 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
1339 * xterm.h (x_mouse_leave): New decl.
1341 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
1342 Remove unused functions.
1343 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
1344 (x_calc_absolute_position): Now static.
1345 (XTread_socket): Don't define label "out" unless it's used.
1346 Don't declare local "event" unless it's used.
1347 (x_iconify_frame, x_free_frame_resources): Don't declare locals
1348 unless they are used.
1349 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
1350 (x_fatal_error_signal): Remove; not used.
1351 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
1352 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
1353 (x_error_catcher, x_connection_closed, x_error_handler):
1354 (x_error_quitter, xembed_send_message, x_iconify_frame):
1355 (my_log_handler): Rename locals to avoid shadowing.
1356 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
1357 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
1359 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
1360 Rename or move locals to avoid shadowing.
1361 (tty_defined_color, merge_face_heights): Now static.
1362 (free_realized_faces_for_fontset): Remove; not used.
1363 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
1364 does not deduce is never used uninitialized.
1365 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
1366 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
1368 * terminal.c (store_terminal_param): Now static.
1370 * xmenu.c (menu_highlight_callback): Now static.
1371 (set_frame_menubar): Remove unused local.
1372 (xmenu_show): Rename parameter to avoid shadowing.
1373 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
1374 since they might point to immutable storage.
1375 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
1376 since it's unused otherwise.
1378 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
1379 Add a FIXME, since the code still doesn't look right. (Bug#8215)
1380 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
1381 avoids a gcc -Wuninitialized diagnostic.
1382 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
1383 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
1384 does not deduce are never used uninitialized.
1386 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
1388 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
1389 * window.c (window_loop, size_window):
1390 (run_window_configuration_change_hook, enlarge_window): Likewise.
1392 * window.c (display_buffer): Now static.
1393 (size_window): Mark variables that gcc -Wuninitialized
1394 does not deduce are never used uninitialized.
1395 * window.h (check_all_windows): New decl, to forestall
1396 gcc -Wmissing-prototypes diagnostic.
1397 * dispextern.h (bidi_dump_cached_states): Likewise.
1399 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
1401 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
1403 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
1404 and to avoid gcc -Wuninitialized warning.
1405 (load_charset_map): Mark variables that gcc -Wuninitialized
1406 does not deduce are never used uninitialized.
1407 (load_charset): Abort instead of using uninitialized var (Bug#8229).
1409 * coding.c (coding_set_source, coding_set_destination):
1410 Use "else { /* comment */ }" rather than "else /* comment */;"
1411 for clarity, and to avoid gcc -Wempty-body warning.
1412 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
1413 a block, when the outer 'i' will do.
1414 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
1415 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
1416 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
1417 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
1418 (Fdecode_sjis_char, Fdefine_coding_system_internal):
1419 Rename locals to avoid shadowing.
1420 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
1421 * coding.c (emacs_mule_char, encode_invocation_designation):
1422 Now static, since they're not used elsewhere.
1423 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
1424 (decode_coding_object, encode_coding_object, detect_coding_system):
1425 (decode_coding_emacs_mule): Mark variables that gcc
1426 -Wuninitialized does not deduce are never used uninitialized.
1427 (detect_coding_iso_2022): Initialize a local variable that might
1428 be used uninitialized. Leave a FIXME because it's not clear that
1429 this initialization is needed. (Bug#8211)
1430 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
1431 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
1432 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
1433 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
1434 Remove unused macros.
1436 * category.c (hash_get_category_set): Remove unused local var.
1437 (copy_category_table): Now static, since it's not used elsewhere.
1438 * character.c (string_count_byte8): Likewise.
1440 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
1441 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
1443 * chartab.c (copy_sub_char_table): Now static, since it's not used
1445 (sub_char_table_ref_and_range, char_table_ref_and_range):
1446 Rename locals to avoid shadowing.
1447 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
1449 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
1450 (BIDI_BOB): Remove unused macro.
1452 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
1453 deduce are never used uninitialized.
1454 * term.c (encode_terminal_code): Likewise.
1456 * term.c (encode_terminal_code): Now static. Remove unused local.
1458 * tparam.h: New file.
1459 * term.c, tparam.h: Include it.
1460 * deps.mk (term.o, tparam.o): Depend on tparam.h.
1461 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
1462 Move these decls to tparam.h, and make them agree with what
1463 is actually in tparam.c. The previous trick of using incompatible
1464 decls in different modules does not conform to the C standard.
1465 All callers of tparam changed to use tparam's actual API.
1466 * tparam.c (tparam1, tparam, tgoto):
1467 Use const pointers where appropriate.
1469 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
1470 * cm.h (struct cm): Likewise.
1471 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
1472 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
1473 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
1474 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
1475 (turn_on_face, init_tty): Likewise.
1476 * termchar.h (struct tty_display_info): Likewise.
1478 * term.c (term_mouse_position): Rename local to avoid shadowing.
1480 * alloc.c (mark_ttys): Move decl from here ...
1481 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
1483 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
1485 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
1487 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
1489 * search.c (compile_pattern_1): Remove argument regp, unused since
1490 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
1491 (compile_pattern): Don't pass it.
1493 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
1495 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
1496 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
1498 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
1500 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
1502 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
1503 gdk_window_get_screen, gdk_window_get_geometry,
1504 gdk_x11_window_lookup_for_display and GDK_KEY_g.
1505 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
1506 (xg_get_pixbuf_from_pixmap): New function.
1507 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
1508 to Pixmap, take frame as parameter, remove GdkColormap parameter.
1509 Call xg_get_pixbuf_from_pixmap instead of
1510 gdk_pixbuf_get_from_drawable.
1511 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
1512 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
1513 (xg_check_special_colors): Use GtkStyleContext and its functions
1515 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
1516 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
1517 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
1518 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
1519 Call gtk_widget_get_preferred_size.
1520 (xg_frame_resized): gdk_window_get_geometry only takes 5
1522 (xg_win_to_widget, xg_event_is_for_menubar):
1523 Call gdk_x11_window_lookup_for_display.
1524 (xg_set_widget_bg): New function.
1525 (delete_cb): New function.
1526 (xg_create_frame_widgets): connect delete-event to delete_cb.
1527 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
1528 (xg_set_background_color): Call xg_set_widget_bg.
1529 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
1530 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
1531 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
1532 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
1534 (update_frame_tool_bar): Call gtk_widget_hide.
1535 (xg_initialize): Use GDK_KEY_g.
1537 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
1539 (x_session_initialize): Call gdk_x11_set_sm_client_id.
1541 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
1542 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
1543 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
1545 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
1547 * w32xfns.c (select_palette): Check success of RealizePalette against
1548 GDI_ERROR, not zero.
1550 See ChangeLog.11 for earlier changes.
1556 Copyright (C) 2011 Free Software Foundation, Inc.
1558 This file is part of GNU Emacs.
1560 GNU Emacs is free software: you can redistribute it and/or modify
1561 it under the terms of the GNU General Public License as published by
1562 the Free Software Foundation, either version 3 of the License, or
1563 (at your option) any later version.
1565 GNU Emacs is distributed in the hope that it will be useful,
1566 but WITHOUT ANY WARRANTY; without even the implied warranty of
1567 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
1568 GNU General Public License for more details.
1570 You should have received a copy of the GNU General Public License
1571 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.
HCoop / bpt / emacs.git / blob