1 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
4 setting frame foreground color (Bug#9175).
5 (x_set_background_color): Likewise.
7 * nsmenu.m (-setText): Size tooltip dimensions precisely to
9 (EmacsTooltip -init): Remove bezels and add shadows to
12 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
14 Implement strike-through and overline on NextStep (Bug#8863).
16 * nsfont.m (nsfont_open): Use underline position provided by font,
17 instead of hard-coded value of 2.
18 (nsfont_draw): Call ns_draw_text_decoration instead.
20 * nsterm.h: Add declaration for ns_draw_text_decoration.
22 * nsterm.m (ns_draw_text_decoration): New function for drawing
23 underline, overline, and strike-through.
24 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
25 ns_draw_text_decoration. Change treatment of cursor drawing to
26 accomodate underlining, etc.
28 2011-07-28 Eli Zaretskii <eliz@gnu.org>
30 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
33 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
35 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
36 Without this fix, if a signal arrives just after memory fills up,
37 'malloc' might be invoked reentrantly.
39 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
40 In other words, assume that every image size is allowed, on non-X
41 hosts. This assumption is probably wrong, but it lets Emacs compile.
43 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
45 * regex.c (re_iswctype): Convert return values to boolean.
47 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
49 * xdisp.c (compute_display_string_pos): Don't use cached display
50 string position if the buffer had its restriction changed.
53 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
55 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
57 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
59 Integer signedness and overflow and related fixes. (Bug#9079)
61 * bidi.c: Integer size and overflow fixes.
62 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
63 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
64 (bidi_cache_find_level_change, bidi_cache_ensure_space)
65 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
66 (bidi_find_other_level_edge):
67 Use ptrdiff_t instead of EMACS_INT where either will do.
68 This works better on 32-bit hosts configured --with-wide-int.
69 (bidi_cache_ensure_space): Check for size-calculation overflow.
70 Use % rather than repeated addition, for better worst-case speed.
71 Don't set bidi_cache_size until after xrealloc returns, because it
73 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
74 (bidi_cache_ensure_space): Also check that the bidi cache size
75 does not exceed that of the largest Lisp string or buffer. See Eli
76 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
78 * alloc.c (__malloc_size_t): Remove.
79 All uses replaced by size_t. See Andreas Schwab's note
80 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
82 * image.c: Improve checking for integer overflow.
83 (check_image_size): Assume that f is nonnull, since
84 it is always nonnull in practice. This is one less thing to
85 worry about when checking for integer overflow later.
86 (x_check_image_size): New function, which checks for integer
87 overflow issues inside X.
88 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
89 This removes the need for a memory_full check.
90 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
91 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
92 (xbm_read_bitmap_data): Change locals back to 'int', since
93 their values must fit in 'int'.
94 (xpm_load_image, png_load, tiff_load):
95 Invoke x_create_x_image_and_pixmap earlier,
96 to avoid much needless work if the image is too large.
97 (tiff_load): Treat overly large images as if
98 x_create_x_image_and_pixmap failed, not as malloc failures.
99 (gs_load): Use x_check_image_size.
101 * gtkutil.c: Omit integer casts.
102 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
103 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
105 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
107 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
108 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
109 would wrongly return t on a 64-bit host.
111 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
112 The plain *_OVERFLOW macros run afoul of GCC bug 49705
113 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
114 and therefore cause GCC to emit a bogus diagnostic in some cases.
116 * image.c: Integer signedness and overflow and related fixes.
117 This is not an exhaustive set of fixes, but it's time to
118 record what I've got.
119 (lookup_pixel_color, check_image_size): Remove redundant decls.
120 (check_image_size): Don't assume that arbitrary EMACS_INT values
121 fit in 'int', or that arbitrary 'double' values fit in 'int'.
122 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
123 (tiff_load, imagemagick_load_image):
124 Check for overflow in size calculations.
125 (x_create_x_image_and_pixmap): Remove unnecessary test for
126 xmalloc returning NULL; that can't happen.
127 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
128 (xpm_color_bucket): Use better integer hashing function.
129 (xpm_cache_color): Don't possibly over-allocate memory.
130 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
132 Use ptrdiff_t, not int or size_t, to record sizes.
133 (png_load): Don't assume values greater than 2**31 fit in 'int'.
134 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
135 either works, as we prefer signed integers.
136 (tiff_read_from_memory, tiff_write_from_memory):
137 Return tsize_t, not size_t, since that's what the TIFF API wants.
138 (tiff_read_from_memory): Don't fail simply because the read would
139 go past EOF; instead, return a short read.
140 (tiff_load): Omit no-longer-needed casts.
141 (Fimagemagick_types): Don't assume size fits into 'int'.
143 Improve hashing quality when configured --with-wide-int.
144 * fns.c (hash_string): New function, taken from sxhash_string.
145 Do not discard information about ASCII character case; this
146 discarding is no longer needed.
147 (sxhash-string): Use it. Change sig to match it. Caller changed.
148 * lisp.h: Declare it.
149 * lread.c (hash_string): Remove, since we now use fns.c's version.
150 The fns.c version returns a wider integer if --with-wide-int is
151 specified, so this should help the quality of the hashing a bit.
153 * emacs.c: Integer overflow minor fix.
154 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
155 Define only if GNU_LINUX.
156 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
158 * dispnew.c: Integer signedness and overflow fixes.
159 Remove unnecessary forward decls, that were a maintenance hassle.
160 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
162 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
163 (scrolling_window): Use ptrdiff_t, not int, for byte count.
164 (prepare_desired_row, line_draw_cost):
165 Use int, not unsigned, where either works.
166 (save_current_matrix, restore_current_matrix):
167 Use ptrdiff_t, not size_t, where either works.
168 (init_display): Check for overflow more accurately, and without
169 relying on undefined behavior.
171 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
172 Remove, replacing with the new symbols in lisp.h. All uses changed.
173 * fileio.c (make_temp_name):
174 * filelock.c (lock_file_1, lock_file):
175 * xdisp.c (message_dolog):
176 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
177 Use pMd etc. instead.
178 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
179 replacing the pWIDE etc. symbols removed from editfns.c.
181 * keyboard.h (num_input_events): Now uintmax_t.
182 This is (very slightly) less likely to mess up due to wraparound.
185 * buffer.c: Integer signedness fixes.
186 (alloc_buffer_text, enlarge_buffer_text):
187 Use ptrdiff_t rather than size_t when either will do, as we prefer
190 * alloc.c: Integer signedness and overflow fixes.
191 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
192 (__malloc_size_t): Default to size_t, not to int.
193 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
194 (Fgarbage_collect, mark_object_loop_halt, mark_object):
195 Prefer ptrdiff_t to size_t when either would do, as we prefer
197 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
198 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
199 Now const. Initialize with values that are in range even if char
201 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
202 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
203 These functions do the right thing with sizes > 2**32.
204 (check_depth): Now ptrdiff_t, not int.
205 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
206 Adjust to new way of storing sizes. Check for size overflow bugs
208 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
209 slightly wrong anyway, as it missed one instance of
210 XMALLOC_OVERRUN_CHECK_OVERHEAD.
211 (refill_memory_reserve): Omit needless cast to size_t.
212 (mark_object_loop_halt): Mark as externally visible.
214 * xselect.c: Integer signedness and overflow fixes.
215 (Fx_register_dnd_atom, x_handle_dnd_message):
216 Use ptrdiff_t, not size_t, since we prefer signed.
217 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
218 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
219 x_dnd_atoms_size and x_dnd_atoms_length.
221 * doprnt.c: Prefer signed to unsigned when either works.
225 * xdisp.c (vmessage):
226 Use ptrdiff_t, not size_t, when using or implementing doprnt,
227 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
228 prefer signed arithmetic to avoid comparison confusion.
229 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
232 Assume freestanding C89 headers, string.h, stdlib.h.
233 * data.c, doprnt.c, floatfns.c, print.c:
234 Include float.h unconditionally.
235 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
236 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
237 * regex.c: Likewise for stddef.h, string.h.
238 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
239 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
240 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
241 (STDC_HEADERS): Remove obsolete defines.
242 * sysdep.c: Include limits.h unconditionally.
244 Assume support for memcmp, memcpy, memmove, memset.
245 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
246 * regex.c (memcmp, memcpy):
247 Remove; we assume C89 now.
249 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
250 (__malloc_safe_bcopy): Remove; no longer needed.
252 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
253 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
254 well either way, and we prefer signed to unsigned.
256 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
258 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
259 closes the connection while we're reading (bug#9182).
261 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
263 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
264 are specified (Bug#9168).
266 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
268 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
269 Found by GCC static checking and --with-wide-int on a 32-bit host.
271 2011-07-25 Eli Zaretskii <eliz@gnu.org>
273 * xdisp.c (compute_display_string_pos): Fix logic of caching
274 previous display string position. Initialize cached_prev_pos to
275 -1. Fixes slow-down at the beginning of a buffer.
277 2011-07-24 Eli Zaretskii <eliz@gnu.org>
279 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
280 for attrs[LFACE_FONTSET_INDEX].
282 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
284 * xml.c (parse_region): Remove unused local
285 that was recently introduced.
287 2011-07-23 Eli Zaretskii <eliz@gnu.org>
289 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
290 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
292 * xdisp.c (move_it_in_display_line_to): Record the best matching
293 position for TO_CHARPOS while scanning the line, and restore it on
294 exit if none of the characters scanned was an exact match. Fixes
295 vertical-motion and pos-visible-in-window-p under bidi redisplay
296 when exact match is impossible due to invisible text, and the
299 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
301 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
304 2011-07-22 Eli Zaretskii <eliz@gnu.org>
306 Fix a significant slow-down of cursor motion with C-n, C-p,
307 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
308 auto-repeat under bidi redisplay in fontified buffers.
309 * xdisp.c (compute_stop_pos_backwards): New function.
310 (next_element_from_buffer): Call compute_stop_pos_backwards to
311 find a suitable prev_stop when we find ourselves before
313 (reseat): Don't look for prev_stop, as that could mean a very long
315 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
316 <cached_disp_overlay_modiff>: Cache for last found display string
318 (compute_display_string_pos): Return the cached position if asked
319 about the same buffer in the same area of character positions, and
320 the buffer wasn't changed since the time the display string
323 2011-07-22 Eli Zaretskii <eliz@gnu.org>
325 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
326 is an integer, which is important for empty lines. (Bug#9149)
328 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
330 * frame.c (Fmodify_frame_parameters): In tty case, update the
331 default face if necessary (Bug#4238).
333 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
335 * editfns.c (Fstring_to_char): No need to explain what a character
336 is in the docstring (Bug#6576).
338 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
340 * xml.c (parse_region): Make sure we always return a tree.
342 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
344 * xml.c (parse_region): If a document contains only comments,
347 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
349 * xml.c (make_dom): Return comments, too.
351 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
354 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
355 and the surrounding thread.
356 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
357 rather than fgets, and retry after EINTR. Otherwise, 'emacs
358 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
360 * s/openbsd.h (BROKEN_SIGIO): Define.
361 * unexelf.c (unexec) [__OpenBSD__]:
362 Don't update the .mdebug section of the Alpha COFF symbol table.
364 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
366 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
369 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
371 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
372 This fixes some race conditions on the permissions of any newly
375 * alloc.c (valid_pointer_p): Use pipe, not open.
376 This fixes some permissions issues when debugging.
378 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
379 If fchown fails to set both uid and gid, try to set just gid,
380 as that is sometimes allowed. Adjust the file's mode to eliminate
381 setuid or setgid bits that are inappropriate if fchown fails.
383 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
385 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
386 to compare Lisp_Objects.
387 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
388 global_gnutls_log_level, don't mistake it for a Lisp_Object.
389 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
391 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
393 * lread.c (read_integer): Unread even EOF character.
394 (read1): Likewise. Properly record start position of symbol.
396 * lread.c (read1): Read `#:' as empty uninterned symbol if no
397 symbol character follows.
399 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
401 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
402 This works around a problem with the previous change to Fcopy_file.
403 Recent glibc declares fchown with __attribute__((warn_unused_result)),
404 and without this change, GCC might complain about discarding
405 fchown's return value.
407 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
409 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
411 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
413 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
415 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
417 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
418 it's used from the C level.
420 * process.c: Use the same condition for POLL_FOR_INPUT in both
421 keyboard.c and process.c (bug#1858).
423 2011-07-09 Lawrence Mitchell <wence@gmx.li>
425 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
426 (Fgnutls_boot): Use it.
428 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
430 * doc.c (Fsubstitute_command_keys): Revert last change.
432 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
434 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
435 quotes the next character, and doesn't affect other longer
436 sequences (bug#8935).
438 * lread.c (syms_of_lread): Clarify that is isn't only
439 `eval-buffer' and `eval-defun' that's affected by
440 `lexical-binding' (bug#8460).
442 2011-07-15 Eli Zaretskii <eliz@gnu.org>
444 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
445 bidi redisplay when a line includes both an image and is
448 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
450 Fix minor problems found by static checking.
451 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
452 (elsz): Now a signed constant, not a size_t var. We prefer signed
453 types to unsigned, to avoid integer comparison confusion. Without
454 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
455 "cannot optimize loop, the loop counter may overflow", a symptom
457 * indent.c (Fvertical_motion): Mark locals as initialized.
458 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
460 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
462 * search.c (Fre_search_backward): Mention `case-fold-search' in
463 all the re_search_* functions (bug#8138).
465 * keyboard.c (Fopen_dribble_file): Document when the file is
468 2011-07-14 Eli Zaretskii <eliz@gnu.org>
470 * bidi.c (bidi_dump_cached_states): Fix format of displaying
473 Support bidi reordering of display and overlay strings.
474 * xdisp.c (compute_display_string_pos)
475 (compute_display_string_end): Accept additional argument STRING.
476 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
477 (reseat_to_string): Initialize bidi_it->string.s and
478 bidi_it->string.schars.
479 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
480 NULL (avoids a crash in bidi_paragraph_init). Initialize
482 (init_iterator): Call bidi_init_it only of a valid
483 buffer position was specified. Initialize paragraph_embedding to
485 (reseat_to_string): Initialize the bidi iterator.
486 (display_string): If we need to ignore text properties of
487 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
488 original value of -1 will not work with bidi.)
489 (compute_display_string_pos): First arg is now struct
490 `text_pos *'; all callers changed. Support display properties on
492 (compute_display_string_end): Support display properties on Lisp
494 (init_iterator, reseat_1, reseat_to_string): Initialize the
495 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
496 when iterating on a string not from display properties).
497 (compute_display_string_pos, compute_display_string_end): Fix
498 calculation of the object to scan. Fixes an error when using
500 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
501 base_level_stop; instead, set base_level_stop to BEGV. Fixes
502 crashes in vertical-motion.
503 (next_element_from_buffer): Improve commentary for when
504 the iterator is before prev_stop.
505 (init_iterator): Initialize bidi_p from the default value of
506 bidi-display-reordering, not from buffer-local value. Use the
507 buffer-local value only if initializing for buffer iteration.
508 (handle_invisible_prop): Support invisible properties on strings
509 that are being bidi-reordered.
510 (set_iterator_to_next): Support bidi reordering of C strings and
512 (next_element_from_string): Support bidi reordering of Lisp
514 (handle_stop_backwards): Support Lisp strings as well.
515 (display_string): Support display of R2L glyph rows. Use
516 IT_STRING_CHARPOS when displaying from a Lisp string.
517 (init_iterator): Don't initialize it->bidi_p for strings
519 (reseat_to_string): Initialize it->bidi_p for strings here.
520 (next_element_from_string, next_element_from_c_string)
521 (next_element_from_buffer): Add xassert's for correspondence
522 between IT's object being iterated and it->bidi_it.string
524 (face_before_or_after_it_pos): Support bidi iteration.
525 (next_element_from_c_string): Handle the case of the first string
526 character that is not the first one in the visual order.
527 (get_visually_first_element): New function, refactored from common
528 parts of next_element_from_buffer, next_element_from_string, and
529 next_element_from_c_string.
530 (tool_bar_lines_needed, redisplay_tool_bar)
531 (display_menu_bar): Force left-to-right direction. Add a FIXME
532 comment for making that be controlled by a user option.
533 (push_it, pop_it): Save and restore the state of the
534 bidi iterator. Save and restore the bidi_p flag.
535 (pop_it): Iterate out of display property for string iteration as
537 (iterate_out_of_display_property): Support iteration over strings.
538 (handle_single_display_spec): Set up it->bidi_it for iteration
539 over a display string, and call bidi_init_it.
540 (handle_single_display_spec, next_overlay_string)
541 (get_overlay_strings_1, push_display_prop): Set up the bidi
542 iterator for displaying display or overlay strings.
543 (forward_to_next_line_start): Don't use the shortcut if
545 (back_to_previous_visible_line_start): If handle_display_prop
546 pushed the iterator stack, restore the internal state of the bidi
547 iterator by calling bidi_pop_it same number of times.
548 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
549 and we are bidi-iterating, don't decrement the iterator position;
550 instead, set the first_elt flag in the bidi iterator, to produce
552 (reseat_1): Remove redundant setting of string_from_display_prop_p.
553 (push_display_prop): xassert that we are iterating a buffer.
554 (push_it, pop_it): Save and restore paragraph_embedding member.
555 (handle_single_display_spec, next_overlay_string)
556 (get_overlay_strings_1, reseat_1, reseat_to_string)
557 (push_display_prop): Set up the `unibyte' member of bidi_it.string
558 correctly. Don't assume unibyte strings are not bidi-reordered.
559 (compute_display_string_pos)
560 (compute_display_string_end): Fix handling the case of C string.
561 (push_it, pop_it): Save and restore from_disp_prop_p.
562 (handle_single_display_spec, push_display_prop): Set the
563 from_disp_prop_p flag.
564 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
565 (pop_it): Call iterate_out_of_display_property only if we are
566 popping after iteration over a string that came from a display
567 property. Fix a typo in popping stretch info. Add an assertion
568 for verifying that the iterator position is in sync with the bidi
570 (handle_single_display_spec, get_overlay_strings_1)
571 (push_display_prop): Fix initialization of paragraph direction for
572 string when that of the parent object is not yet determined.
573 (reseat_1): Call bidi_init_it to resync the bidi
574 iterator with IT's position. (Bug#7616)
575 (find_row_edges): If ROW->start.pos gives position
576 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
577 (handle_stop, back_to_previous_visible_line_start, reseat_1):
578 Reset the from_disp_prop_p flag.
579 (SAVE_IT, RESTORE_IT): New macros.
580 (pos_visible_p, face_before_or_after_it_pos)
581 (back_to_previous_visible_line_start)
582 (move_it_in_display_line_to, move_it_in_display_line)
583 (move_it_to, move_it_vertically_backward, move_it_by_lines)
584 (try_scrolling, redisplay_window, display_line): Use them when
585 saving a temporary copy of the iterator and restoring it back.
586 (back_to_previous_visible_line_start, reseat_1)
587 (init_iterator): Empty the bidi cache "stack".
588 (move_it_in_display_line_to): If iterator ended up at
589 EOL, but we never saw any buffer positions smaller than
590 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
591 motion in bidi-reordered lines.
592 (move_it_in_display_line_to): Record prev_method and prev_pos
593 immediately before the call to set_iterator_to_next. Fixes cursor
594 motion in bidi-reordered lines with stretch glyphs and strings
595 displayed in margins. (Bug#8133) (Bug#8867)
596 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
598 (pos_visible_p): Support positions in bidi-reordered lines. Save
599 and restore bidi cache.
601 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
602 (bidi_paragraph_info): Delete unused struct.
603 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
604 (bidi_cache_start): New variable.
605 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
607 (bidi_cache_fetch_state, bidi_cache_search)
608 (bidi_cache_find_level_change, bidi_cache_iterator_state)
609 (bidi_cache_find, bidi_peek_at_next_level)
610 (bidi_level_of_next_char, bidi_find_other_level_edge)
611 (bidi_move_to_visually_next): Compare cache index with
612 bidi_cache_start rather than with zero.
613 (bidi_fetch_char): Accept new argument STRING; all callers
614 changed. Support iteration over a string. Support strings with
615 display properties. Support unibyte strings. Fix the type of
616 `len' according to what STRING_CHAR_AND_LENGTH expects.
617 (bidi_paragraph_init, bidi_resolve_explicit_1)
618 (bidi_resolve_explicit, bidi_resolve_weak)
619 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
620 iteration over a string.
621 (bidi_set_sor_type, bidi_resolve_explicit_1)
622 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
623 can now be zero (for strings); special values 0 and -1 were
624 changed to -1 and -2, respectively.
625 (bidi_char_at_pos): New function.
626 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
627 Call it instead of FETCH_MULTIBYTE_CHAR.
628 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
629 initialized to valid values.
630 (bidi_init_it): Don't initialize charpos and bytepos with invalid
632 (bidi_level_of_next_char): Allow the sentinel "position" to pass
633 the test for valid cached positions. Fix the logic for looking up
634 the sentinel state in the cache. GCPRO the Lisp string we are
636 (bidi_push_it, bidi_pop_it): New functions.
637 (bidi_initialize): Initialize the bidi cache start stack pointer.
638 (bidi_cache_ensure_space): New function, refactored from part of
639 bidi_cache_iterator_state. Don't assume the required size is just
640 one BIDI_CACHE_CHUNK away.
641 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
642 (bidi_count_bytes, bidi_char_at_pos): New functions.
643 (bidi_cache_search): Don't assume bidi_cache_last_idx is
644 always valid if bidi_cache_idx is valid.
645 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
646 is valid if it's going to be used.
647 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
648 (bidi_cache_fetch_state, bidi_cache_search)
649 (bidi_cache_find_level_change, bidi_cache_ensure_space)
650 (bidi_cache_iterator_state, bidi_cache_find)
651 (bidi_find_other_level_edge, bidi_cache_start_stack): All
652 variables related to cache indices are now EMACS_INT.
654 * dispextern.h (struct bidi_string_data): New structure.
655 (struct bidi_it): New member `string'. Make flag members be 1-bit
656 fields, and put them last in the struct.
657 (compute_display_string_pos, compute_display_string_end): Update
659 (bidi_push_it, bidi_pop_it): Add prototypes.
660 (struct iterator_stack_entry): New members bidi_p,
661 paragraph_embedding, and from_disp_prop_p.
662 (struct it): Member bidi_p is now a bit field 1 bit wide.
663 (bidi_shelve_cache, bidi_unshelve_cache): Declare
666 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
667 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
668 and vector-like objects.
670 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
671 cache around display iteration.
673 * window.c (Fwindow_end, window_scroll_pixel_based)
674 (displayed_window_lines, Frecenter): Save and restore the bidi
675 cache around display iteration.
677 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
679 * editfns.c (Fdelete_region): Clarify the use of the named
680 parameters (bug#6788).
682 2011-07-14 Martin Rudalics <rudalics@gmx.at>
684 * indent.c (Fvertical_motion): Set and restore w->pointm when
685 saving and restoring the window's buffer (Bug#9006).
687 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
689 * editfns.c (Fstring_to_char): Clarify just what is returned
690 (bug#6576). Text by Eli Zaretskii.
692 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
694 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
696 2011-07-13 Eli Zaretskii <eliz@gnu.org>
698 * buffer.c (mmap_find): Fix a typo.
700 2011-07-13 Johan Bockgård <bojohan@gnu.org>
702 Fix execution of x selection hooks.
703 * xselect.c (Qx_lost_selection_functions)
704 (Qx_sent_selection_functions): New vars.
705 (syms_of_xselect): DEFSYM them.
706 (x_handle_selection_request): Pass Qx_sent_selection_functions
707 rather than Vx_sent_selection_functions to Frun_hook_with_args.
708 (x_handle_selection_clear,x_clear_frame_selections):
709 Pass Qx_lost_selection_functions rather than
710 Vx_lost_selection_functions to Frun_hook_with_args.
712 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
714 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
715 The old code sometimes used this field without initializing it.
717 * alloc.c (gc_sweep): Don't read past end of array.
718 In theory, the old code could also have corrupted Emacs internals,
719 though it'd be very unlikely.
721 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
723 * character.c (Fcharacterp): Don't advertise optional ignored
726 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
728 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
731 * window.c (Fset_window_start): Doc fix (bug#4199).
732 (Fset_window_hscroll): Ditto.
734 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
736 Fix minor new problems caught by GCC 4.6.1.
737 * term.c (init_tty): Remove unused local.
738 * xsettings.c (store_monospaced_changed): Define this function only
739 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
742 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
744 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
746 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
748 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
749 are the mini-buffer and the echo area (bug#3320).
751 * term.c (init_tty): Remove support for supdup, c10 and perq
752 terminals, which are no longer supported (bug#1482).
754 2011-07-10 Johan Bockgård <bojohan@gnu.org>
756 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
758 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
760 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
761 for non-popups (Bug#3642).
763 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
765 * alloc.c (reset_malloc_hooks): Protoize.
766 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
767 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
768 * cm.c (losecursor): Likewise.
769 * data.c (fmod): Likewise.
770 * dispnew.c (swap_glyphs_in_rows): Likewise.
771 * emacs.c (memory_warning_signal): Likewise.
772 * floatfns.c (float_error): Likewise.
773 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
774 (otf_open, font_otf_capability, generate_otf_features)
775 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
777 * image.c (pbm_read_file): Likewise.
778 * indent.c (string_display_width): Likewise.
779 * intervals.c (check_for_interval, search_for_interval)
780 (inc_interval_count, count_intervals, root_interval)
781 (adjust_intervals_for_insertion, make_new_interval): Likewise.
782 * lread.c (defalias): Likewise.
783 * ralloc.c (r_alloc_check): Likewise.
784 * regex.c (set_image_of_range_1, set_image_of_range)
785 (regex_grow_registers): Likewise.
786 * sysdep.c (strerror): Likewise.
787 * termcap.c (valid_filename_p, tprint, main): Likewise.
788 * tparam.c (main): Likewise.
789 * unexhp9k800.c (run_time_remap, save_data_space)
790 (update_file_ptrs, read_header, write_header, calculate_checksum)
791 (copy_file, copy_rest, display_header): Likewise.
792 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
794 * xdisp.c (check_it): Likewise.
795 * xfaces.c (register_color, unregister_color, unregister_colors):
797 * xfns.c (print_fontset_result): Likewise.
798 * xrdb.c (member, fatal, main): Likewise.
800 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
802 Fix minor problems found by static checking (Bug#9031).
803 * chartab.c (char_table_set_range, map_sub_char_table):
804 Remove unused locals.
805 (uniprop_table): Now static.
806 * composite.c (_work_char): Remove unused static var.
808 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
810 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
812 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
814 * gtkutil.c (qttip_cb): Remove code without function.
816 2011-07-09 Eli Zaretskii <eliz@gnu.org>
818 * w32.c (pthread_sigmask): New stub.
820 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
822 Use pthread_sigmask, not sigprocmask (Bug#9010).
823 sigprocmask is portable only for single-threaded applications, and
824 Emacs can be multi-threaded when it uses GTK.
825 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
827 * callproc.c (Fcall_process):
828 * process.c (create_process):
829 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
830 Use pthread_sigmask, not sigprocmask.
832 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
834 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
835 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
838 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
840 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
841 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
842 (xg_hide_tooltip): Fix comment.
844 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
845 in registerServicesMenuSendTypes.
846 (validRequestorForSendType): Don't check ns_return_types.
848 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
851 2011-07-08 Jason Rumney <jasonr@gnu.org>
853 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
854 frame struct members of non-existent frames (Bug#6284).
856 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
858 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
859 variable firstTime not needed on OSX >= 10.6.
860 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
861 >= 10.5. Use setKnobProportion, setDoubleValue.
863 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
864 (MAC_OS_X_VERSION_10_5): Define if not defined.
865 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
866 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
867 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
869 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
870 cString and lossyCString on OSX >= 10.4
872 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
873 sizeToFit on OSX >= 10.2.
875 * nsimage.m (allocInitFromFile): Don't use deprecated method
876 bestRepresentationForDevice on OSX >= 10.6.
878 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
881 * emacs.c: Declare unexec_init_emacs_zone.
883 * nsgui.h: Fix compiler warning about gnulib redefining verify.
885 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
887 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
888 on svcsMenu (Bug#8842).
890 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
892 (Fns_list_services): Just return Qnil on 10.6, code not working there.
894 * nsterm.m (QUTF8_STRING): Declare.
895 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
896 (validRequestorForSendType): Return type is (id).
897 Change indexOfObjectIdenticalTo to indexOfObject.
898 Check if we have local selection before returning self (Bug#8842).
899 (writeSelectionToPasteboard): Put local selection into paste board
900 if we have a local selection (Bug#8842).
901 (syms_of_nsterm): DEFSYM QUTF8_STRING.
903 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
904 (ns_get_local_selection): Declare.
906 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
908 * keymap.c (describe_map_tree): Don't insert a double newline at
909 the end of the buffer (bug#1169) and return whether we inserted
912 * callint.c (Fcall_interactively): Change "reading args" to
913 "providing args" to try to clarify what it does (bug#1010).
915 2011-07-07 Kenichi Handa <handa@m17n.org>
917 * composite.c (composition_compute_stop_pos): Ignore a static
918 composition starting before CHARPOS (Bug#8915).
920 * xdisp.c (handle_composition_prop): Likewise.
922 2011-07-07 Eli Zaretskii <eliz@gnu.org>
924 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
927 2011-07-07 Kenichi Handa <handa@m17n.org>
929 * character.h (unicode_category_t): New enum type.
931 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
932 (Qchar_code_property_table): New variable.
933 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
934 (UNIPROP_COMPRESSED_FORM_P): New macros.
935 (char_table_ascii): Uncompress the compressed values.
936 (sub_char_table_ref): New arg is_uniprop. Callers changed.
937 Uncompress the compressed values.
938 (sub_char_table_ref_and_range): Likewise.
939 (char_table_ref_and_range): Uncompress the compressed values.
940 (sub_char_table_set): New arg is_uniprop. Callers changed.
941 Uncompress the compressed values.
942 (sub_char_table_set_range): Args changed. Callers changed.
943 (char_table_set_range): Adjuted for the above change.
944 (map_sub_char_table): Delete args default_val and parent. Add arg
945 top. Give decoded values to a Lisp function.
946 (map_char_table): Adjusted for the above change. Give decoded
947 values to a Lisp function. Gcpro more variables.
948 (uniprop_table_uncompress)
949 (uniprop_decode_value_run_length): New functions.
950 (uniprop_decoder, uniprop_decoder_count): New variables.
951 (uniprop_get_decoder, uniprop_encode_value_character)
952 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
954 (uniprop_encoder, uniprop_encoder_count): New variables.
955 (uniprop_get_encoder, uniprop_table)
956 (Funicode_property_table_internal, Fget_unicode_property_internal)
957 (Fput_unicode_property_internal): New functions.
958 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
959 Sunicode_property_table_internal, Sget_unicode_property_internal,
960 and Sput_unicode_property_internal. Defvar_lisp
961 char-code-property-alist.
963 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
964 Vunicode_category_table.
966 * font.c (font_range): Adjusted for the change of
967 Vunicode_category_table.
969 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
971 * m/iris4d.h: Remove file, move contents ...
972 * s/irix6-5.h: ... here.
974 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
976 Remove unportable assumption about struct layout (Bug#8884).
977 * alloc.c (mark_buffer):
978 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
979 (clone_per_buffer_values): Don't assume that
980 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
981 This isn't true in general, and it's particularly not true
982 if Emacs is configured with --with-wide-int.
983 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
984 New macros, used in the buffer.c change.
986 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
988 * xsettings.c: Use both GConf and GSettings if both are available.
989 (store_config_changed_event): Add comment.
990 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
991 (store_tool_bar_style_changed): New functions.
992 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
993 (struct xsettings): Move font inside HAVE_XFT.
994 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
995 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
996 Move inside HAVE_XFT.
997 (something_changed_gsettingsCB): Renamed from something_changedCB.
998 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1000 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1001 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1002 (something_changed_gconfCB): Renamed from something_changedCB.
1003 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1004 (parse_settings): Move check for font inside HAVE_XFT.
1005 (read_settings, apply_xft_settings): Add comment.
1006 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1007 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1008 call store_font_name_changed.
1009 (xft_settings_event): Add comment.
1010 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1011 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1012 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1013 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1014 (xsettings_initialize): Call init_gsettings last.
1015 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
1018 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1020 Random fixes. E.g., (random) never returned negative values.
1021 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1022 subseconds part to the entropy, as that's a bit more random.
1023 Prefer signed to unsigned, since the signedness doesn't matter and
1024 in general we prefer signed. When given a limit, use a
1025 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1026 latter isn't right if USE_2_TAGS_FOR_INTS.
1027 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1028 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1030 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1032 * textprop.c (text_property_stickiness):
1033 Obey Vtext_property_default_nonsticky.
1034 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1035 * w32fns.c (syms_of_w32fns):
1036 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1038 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1040 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1041 This is more efficient than Ffile_directory_p and avoids a minor race.
1043 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1045 * buffer.c (Foverlay_put): Say what the return value is
1048 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1049 is a directory before asking whether to use the file name
1051 (barf_or_query_if_file_exists): Make the "File is a directory"
1052 error be more correct.
1054 * fns.c (Frequire): Remove the mention of the .gz files, since
1055 that's installation-specific, but keep the mention of
1056 `get-load-suffixes'.
1058 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1060 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1061 Report string overflow if the output is too long.
1063 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1065 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1066 (syms_of_gnutls): Remove duplicate DEFSYM for
1067 Qgnutls_bootprop_verify_hostname_error, an error for
1068 Qgnutls_bootprop_verify_error (which is no longer used).
1070 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1071 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1072 Also (re)move comments that are misplaced or no longer relevant.
1074 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1076 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1078 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1080 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1081 and background color parameters if they have been changed.
1083 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1085 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1087 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1089 * xsettings.c (SYSTEM_FONT): Define only when used.
1090 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1092 * keymap.c (access_keymap_1): Now static.
1094 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1096 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1097 leave any prefix arg for the up event (Bug#1586).
1099 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1101 * lread.c (syms_of_lread): Mention single symbols defined by
1102 `defvar' or `defconst' (bug#7154).
1104 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1105 (Frequire): Mention get-load-suffixes.
1107 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1109 * window.h (window): Remove clone_number slot.
1110 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1112 (make_parent_window, make_window, saved_window)
1113 (Fset_window_configuration, save_window_save): Don't deal with
1115 * buffer.c (Qclone_number): Remove declaration.
1116 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1118 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1120 Add multiple inheritance to keymaps.
1121 * keymap.c (Fmake_composed_keymap): New function.
1122 (Fset_keymap_parent): Simplify.
1123 (fix_submap_inheritance): Remove.
1124 (access_keymap_1): New function extracted from access_keymap to handle
1125 embedded parents and handle lists of maps.
1126 (access_keymap): Use it.
1127 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1128 (Fcopy_keymap): Handle embedded parents.
1129 (Fcommand_remapping, define_as_prefix): Simplify.
1130 (Fkey_binding): Simplify.
1131 (syms_of_keymap): Move minibuffer-local-completion-map,
1132 minibuffer-local-filename-completion-map,
1133 minibuffer-local-must-match-map, and
1134 minibuffer-local-filename-must-match-map to Elisp.
1135 (syms_of_keymap): Defsubr make-composed-keymap.
1136 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1137 (parse_menu_item): Trivial simplification.
1139 2011-07-01 Glenn Morris <rgm@gnu.org>
1141 * Makefile.in (SETTINGS_LIBS): Fix typo.
1143 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1145 * coding.c (Fencode_coding_string): Record the last coding system
1146 used, as the function doc string says (bug#8738).
1148 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1150 * xsettings.c (store_monospaced_changed): Take new font as arg and
1151 check for change against current_mono_font.
1152 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1153 (emacs_settings_constructor, emacs_settings_get_property)
1154 (emacs_settings_set_property, emacs_settings_class_init)
1155 (emacs_settings_init, gsettings_obj): Remove.
1156 (something_changedCB): New function for HAVE_GSETTINGS.
1157 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1158 with value as argument.
1159 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1160 g_settings_new (Bug#8967). Do not create gsettings_obj.
1161 Remove calls to g_settings_bind. Connect something_changedCB to
1164 * xgselect.c: Add defined (HAVE_GSETTINGS).
1165 (xgselect_initialize): Ditto.
1167 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1168 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1171 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1173 * eval.c (struct backtrace): Simplify and port the data structure.
1174 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1175 signed bit field, as this assumption is not portable and it makes
1176 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1177 "char debug_on_exit : 1" as this is not portable either; instead,
1178 use the portable "unsigned int debug_on_exit : 1". Remove unused
1179 member evalargs. Remove obsolete comments about cc bombing out.
1181 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1183 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1184 Let HAVE_GSETTINGS override HAVE_GCONF.
1185 (store_monospaced_changed): New function.
1186 (EMACS_SETTINGS): A new type derived from GObject to handle
1187 GSettings notifications.
1188 (emacs_settings_constructor, emacs_settings_get_property)
1189 (emacs_settings_set_property, emacs_settings_class_init):
1191 (gsettings_client, gsettings_obj): New variables.
1192 (GSETTINGS_SCHEMA): New define.
1193 (something_changedCB): Call store_monospaced_changed.
1194 (init_gsettings): New function.
1195 (xsettings_initialize): Call init_gsettings.
1196 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1199 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
1202 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1204 * window.c (resize_root_window, grow_mini_window)
1205 (shrink_mini_window): Rename Qresize_root_window to
1206 Qwindow_resize_root_window and Qresize_root_window_vertically to
1207 Qwindow_resize_root_window_vertically.
1209 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1211 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1213 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1215 * makefile.w32-in: Redesign dependencies so they reflect more
1216 clearly which files are directly included by each source file,
1217 and not through other includes.
1219 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1221 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1222 (sort_overlays, overlay_strings): When an overlay's clone number
1223 matches the window's clone number process the overlay even if
1224 the overlay's window property doesn't match the current window.
1226 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1227 (Fwindow_hchild): Rename to Fwindow_left_child.
1228 (Fwindow_next): Rename to Fwindow_next_sibling.
1229 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1230 (resize_window_check): Rename to window_resize_check.
1231 (resize_window_apply): Rename to window_resize_apply.
1232 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1233 (Fdelete_other_windows_internal, resize_frame_windows)
1234 (Fsplit_window_internal, Fdelete_window_internal)
1235 (grow_mini_window, shrink_mini_window)
1236 (Fresize_mini_window_internal): Fix callers accordingly.
1238 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1240 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1241 (emacs_fixed_set_min_size): Remove.
1242 (emacs_fixed_new): Take frame as argument.
1244 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1245 (_EmacsFixedPrivate): Remove minwidth/height.
1246 Add struct frame *f.
1247 (emacs_fixed_init): Initialize priv->f.
1248 (get_parent_class, emacs_fixed_set_min_size): Remove.
1249 (emacs_fixed_new): Set priv->f to argument.
1250 (emacs_fixed_get_preferred_width)
1251 (emacs_fixed_get_preferred_height): Use min_width/height from
1252 frames size_hint to set minimum and natural (Bug#8919).
1253 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1254 and use min_width/height from frames size_hint to set
1255 min_width/height (Bug#8919).
1257 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1258 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1261 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1263 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1264 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1267 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1269 * process.c (wait_reading_process_output): Bypass select if
1270 waiting for a cell while ignoring keyboard input, and input is
1271 pending. Suggested by Jan Djärv (Bug#8869).
1273 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1275 Use gnulib's dup2 module instead of rolling our own.
1276 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1278 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1280 * dispnew.c (scrolling_window): Before scrolling, turn off a
1281 mouse-highlight in the window being scrolled.
1283 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1285 Move DEFSYM to lisp.h and use everywhere.
1287 * character.h (DEFSYM): Move declaration...
1288 * lisp.h (DEFSYM): ...here.
1294 * w32select.c: Don't include character.h.
1296 * alloc.c (syms_of_alloc):
1297 * buffer.c (syms_of_buffer):
1298 * bytecode.c (syms_of_bytecode):
1299 * callint.c (syms_of_callint):
1300 * casefiddle.c (syms_of_casefiddle):
1301 * casetab.c (init_casetab_once):
1302 * category.c (init_category_once, syms_of_category):
1303 * ccl.c (syms_of_ccl):
1304 * cmds.c (syms_of_cmds):
1305 * composite.c (syms_of_composite):
1306 * dbusbind.c (syms_of_dbusbind):
1307 * dired.c (syms_of_dired):
1308 * dispnew.c (syms_of_display):
1309 * doc.c (syms_of_doc):
1310 * editfns.c (syms_of_editfns):
1311 * emacs.c (syms_of_emacs):
1312 * eval.c (syms_of_eval):
1313 * fileio.c (syms_of_fileio):
1314 * fns.c (syms_of_fns):
1315 * frame.c (syms_of_frame):
1316 * fringe.c (syms_of_fringe):
1317 * insdel.c (syms_of_insdel):
1318 * keymap.c (syms_of_keymap):
1319 * lread.c (init_obarray, syms_of_lread):
1320 * macros.c (syms_of_macros):
1321 * msdos.c (syms_of_msdos):
1322 * print.c (syms_of_print):
1323 * process.c (syms_of_process):
1324 * search.c (syms_of_search):
1325 * sound.c (syms_of_sound):
1326 * syntax.c (init_syntax_once, syms_of_syntax):
1327 * terminal.c (syms_of_terminal):
1328 * textprop.c (syms_of_textprop):
1329 * undo.c (syms_of_undo):
1330 * w32.c (globals_of_w32):
1331 * window.c (syms_of_window):
1332 * xdisp.c (syms_of_xdisp):
1333 * xfaces.c (syms_of_xfaces):
1334 * xfns.c (syms_of_xfns):
1335 * xmenu.c (syms_of_xmenu):
1336 * xsettings.c (syms_of_xsettings):
1337 * xterm.c (syms_of_xterm): Use DEFSYM.
1339 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1341 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1343 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1345 Integer and buffer overflow fixes (Bug#8873).
1347 * print.c (printchar, strout): Check for string overflow.
1348 (PRINTPREPARE, printchar, strout):
1349 Don't set size unless allocation succeeds.
1351 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1352 for sizes. Check for string overflow more accurately.
1353 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1355 * macros.c: Integer and buffer overflow fixes.
1356 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1357 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1358 Use ptrdiff_t, not int, for sizes.
1359 Don't increment bufsize until after realloc succeeds.
1360 Check for size-calculation overflow.
1361 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1363 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1365 * lread.c: Integer overflow fixes.
1366 (read_integer): Radix is now EMACS_INT, not int,
1367 to improve quality of diagnostics for out-of-range radices.
1368 Calculate buffer size correctly for out-of-range radices.
1369 (read1): Check for integer overflow in radices, and in
1370 read-circle numbers.
1371 (read_escape): Avoid int overflow.
1372 (Fload, openp, read_buffer_size, read1)
1373 (substitute_object_recurse, read_vector, read_list, map_obarray):
1374 Use ptrdiff_t, not int, for sizes.
1375 (read1): Use EMACS_INT, not int, for sizes.
1376 Check for size overflow.
1378 * image.c (cache_image): Check for size arithmetic overflow.
1380 * lread.c: Integer overflow issues.
1381 (saved_doc_string_size, saved_doc_string_length)
1382 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1383 Now ptrdiff_t, not int.
1384 (read1): Don't assume doc string length fits in int. Check for
1385 out-of-range doc string lengths.
1386 (read_list): Don't assume file position fits in int.
1387 (read_escape): Check for hex character overflow.
1389 2011-06-22 Leo Liu <sdl.web@gmail.com>
1391 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1392 Move to minibuffer.el.
1394 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1396 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1397 The following patches are for when GLYPH_DEBUG && !XASSERT.
1398 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1399 * dispnew.c (flush_stdout):
1400 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1401 Mark as externally visible.
1402 * dispnew.c (check_window_matrix_pointers): Now static.
1403 * dispnew.c (window_to_frame_vpos):
1404 * xfns.c (unwind_create_frame):
1405 * xterm.c (x_check_font): Remove unused local.
1406 * scroll.c (CHECK_BOUNDS):
1407 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1408 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1409 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1410 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1411 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1413 (debug_method_add): Use va_list and vsprintf rather than relying
1414 on undefined behavior with wrong number of arguments.
1415 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1416 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1417 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1418 since we're not interested in debugging glyphs with old libraries.
1419 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1420 GCC 4.6.0's static checking.
1422 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1424 Integer overflow and signedness fixes (Bug#8873).
1425 A few related buffer overrun fixes, too.
1427 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1429 * dispextern.h (struct face.stipple):
1430 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1431 (x_bitmap_mask, x_allocate_bitmap_record)
1432 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1433 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1434 (x_create_bitmap_from_xpm_data):
1435 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1436 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1438 * xfaces.c (load_pixmap):
1439 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1440 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1441 (.bitmaps_last, struct x_output.icon_bitmap):
1442 Use ptrdiff_t, not int, for bitmap indexes.
1443 (x_allocate_bitmap_record): Check for size overflow.
1444 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1446 Use ptrdiff_t, not int, for overlay counts.
1447 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1448 * editfns.c (overlays_around, get_pos_property):
1449 * textprop.c (get_char_property_and_overlay):
1450 * xdisp.c (next_overlay_change, note_mouse_highlight):
1451 * xfaces.c (face_at_buffer_position):
1452 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1453 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1454 (Fnext_overlay_change, Fprevious_overlay_change)
1455 (mouse_face_overlay_overlaps, Foverlays_in):
1456 Use ptrdiff_t, not int, for sizes.
1457 (overlays_at, overlays_in): Check for size-calculation overflow.
1459 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1461 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1462 (x_session_initialize): Do not assume string length fits in int.
1464 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1465 This is unlikely, but can occur if DPI is outlandish.
1467 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1468 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1470 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1471 * xrdb.c (magic_file_p, search_magic_path):
1472 Omit last arg SUFFIX; it was always 0. All callers changed.
1473 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1475 * xfont.c (xfont_match): Avoid need for strlen.
1477 * xfns.c: Don't assume strlen fits in int.
1478 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1480 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1481 not unsigned long, as we prefer signed integers. All callers changed.
1482 Detect integer overflow in repeat count.
1483 (message_dolog): Don't assume print length fits in 39 bytes.
1484 (display_mode_element): Don't assume strlen fits in int.
1486 * termcap.c: Don't assume sizes fit in int and never overflow.
1487 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1488 (gobble_line): Check for size-calculation overflow.
1490 * minibuf.c (Fread_buffer):
1491 * lread.c (intern, intern_c_string):
1492 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1493 Don't assume string length fits in int.
1495 * keyboard.c (parse_tool_bar_item):
1496 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1498 * font.c: Don't assume string length fits in int.
1499 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1500 Use ptrdiff_t, not int.
1501 (font_intern_prop): Don't assume string length fits in int.
1502 Don't assume integer property fits in fixnum.
1503 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1505 * filelock.c: Fix some buffer overrun and integer overflow issues.
1506 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1507 Reformulate so as not to need the command string.
1508 Invoke gzip -cd rather than gunzip, as it's more portable.
1509 (lock_info_type, lock_file_1, lock_file):
1510 Don't assume pid_t and time_t fit in unsigned long.
1511 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1512 (current_lock_owner): Prefer signed type for sizes.
1513 Use memcpy, not strncpy, where memcpy is what is really wanted.
1514 Don't assume (via atoi) that time_t and pid_t fit in int.
1515 Check for time_t and/or pid_t out of range, e.g., via a network share.
1516 Don't alloca where an auto var works fine.
1518 * fileio.c: Fix some integer overflow issues.
1519 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1520 Don't assume string length fits in int.
1521 (directory_file_name): Don't assume string length fits in long.
1522 (make_temp_name): Don't assume pid fits in int, or that its print
1523 length is less than 20.
1525 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1527 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1529 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1531 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1532 We prefer signed integers, even for size calculations.
1534 * emacs.c: Don't assume string length fits in 'int'.
1535 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1536 (main): Don't invoke strlen when not needed.
1538 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1539 (XD_DEBUG_MESSAGE): Don't waste a byte.
1541 * callproc.c (getenv_internal_1, getenv_internal)
1543 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1545 * lread.c (invalid_syntax): Omit length argument.
1546 All uses changed. This doesn't fix a bug, but it simplifies the
1547 code away from its former Hollerith-constant appearance, and it's
1548 one less 'int' to worry about when looking at integer-overflow issues.
1549 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1551 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1552 This didn't break anything, but it didn't help either.
1553 It's confusing to put a bogus integer in a place where the actual
1554 value does not matter.
1555 (LIST_END_P): Remove unused macro and its bogus comment.
1556 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1558 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1559 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1561 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1562 We prefer signed types, and the value cannot exceed the EMACS_INT
1563 range anyway (because otherwise the length would not be representable).
1564 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1565 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1566 This avoids a GCC warning when WIDE_EMACS_INT.
1568 * indent.c (sane_tab_width): New function.
1569 (current_column, scan_for_column, Findent_to, position_indentation)
1570 (compute_motion): Use it. This is just for clarity.
1571 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1573 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1575 * lisp.h (lint_assume): New macro.
1576 * composite.c (composition_gstring_put_cache):
1577 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1579 * editfns.c, insdel.c:
1580 Omit unnecessary forward decls, to simplify future changes.
1582 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1584 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1586 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1587 Use much-faster test for byte-length change.
1588 Don't assume string byte-length fits in 'int'.
1589 Check that character arg fits in 'int'.
1590 (mapcar1): Declare byte as byte, for clarity.
1592 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1594 * fns.c (concat): Catch string overflow earlier.
1595 Do not rely on integer wraparound.
1597 * dispextern.h (struct it.overlay_strings_charpos)
1598 (struct it.selective): Now EMACS_INT, not int.
1599 * xdisp.c (forward_to_next_line_start)
1600 (back_to_previous_visible_line_start)
1601 (reseat_at_next_visible_line_start, next_element_from_buffer):
1602 Don't arbitrarily truncate the value of 'selective' to int.
1604 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1606 * composite.c: Don't truncate sizes to 'int'.
1607 (composition_gstring_p, composition_reseat_it)
1608 (composition_adjust_point): Use EMACS_INT, not int.
1609 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1610 not EMACS_UINT, for indexes.
1612 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1614 * buffer.c: Include <verify.h>.
1615 (struct sortvec.priority, struct sortstr.priority):
1616 Now EMACS_INT, not int.
1617 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1618 (struct sortstr.size, record_overlay_string)
1619 (struct sortstrlist.size, struct sortlist.used):
1620 Don't truncate size to int.
1621 (record_overlay_string): Check for size-calculation overflow.
1622 (init_buffer_once): Check at compile-time, not run-time.
1624 2011-06-22 Jim Meyering <meyering@redhat.com>
1626 Don't leak an XBM-image-sized buffer
1627 * image.c (xbm_load): Free the image buffer after using it.
1629 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1632 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1633 that Sun C diagnosed.
1634 * fns.c (secure_hash): Fix pointer signedness issue.
1635 * intervals.c (static_offset_intervals): New function.
1636 (offset_intervals): Use it.
1638 2011-06-21 Leo Liu <sdl.web@gmail.com>
1641 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1644 * fns.c (secure_hash): Rename from crypto_hash_function and change
1645 the first arg to accept symbols.
1646 (Fsecure_hash): New primitive.
1647 (syms_of_fns): New symbols.
1649 2011-06-20 Deniz Dogan <deniz@dogan.se>
1651 * process.c (Fset_process_buffer): Clarify return value in
1654 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1656 * dispnew.c (add_window_display_history): Use BVAR.
1658 * xdisp.c (debug_method_add): Use BVAR.
1659 (check_window_end, dump_glyph_matrix, dump_glyph)
1660 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1662 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1665 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1666 check till after the cache is created in init_frame_faces.
1668 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1670 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1672 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1674 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1675 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1676 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1678 Improve buffer-overflow checking (Bug#8873).
1679 * fileio.c (Finsert_file_contents):
1680 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1681 Remove the old (too-loose) buffer overflow checks.
1682 They weren't needed, since make_gap checks for buffer overflow.
1683 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1684 The old code merely checked for Emacs fixnum overflow, and relied
1685 on undefined (wraparound) behavior. The new code avoids undefined
1686 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1688 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1689 Tune. Don't use wider integers than needed. Don't use alloca.
1690 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1692 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1694 * insdel.c, lisp.h (buffer_overflow): New function.
1695 (insert_from_buffer_1, replace_range, replace_range_2):
1696 * insdel.c (make_gap_larger):
1697 * editfns.c (Finsert_char):
1698 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1700 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1702 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1704 Integer overflow and signedness fixes (Bug#8873).
1706 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1707 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1709 * fileio.c: Don't assume EMACS_INT fits in off_t.
1710 (emacs_lseek): New static function.
1711 (Finsert_file_contents, Fwrite_region): Use it.
1712 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1714 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1716 * fns.c: Don't overflow int when computing a list length.
1717 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1718 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1719 truncation on 64-bit hosts. Check for QUIT every
1720 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1721 faster and is responsive enough.
1722 (Flength): Report an error instead of overflowing an integer.
1723 (Fsafe_length): Return a float if the value is not representable
1724 as a fixnum. This shouldn't happen except in contrived situations.
1725 (Fnthcdr, Fsort): Don't assume list length fits in int.
1726 (Fcopy_sequence): Don't assume vector length fits in int.
1728 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1729 (header_size, word_size): New constants.
1730 (allocate_vectorlike): Don't check size overflow here.
1731 (allocate_vector): Check it here instead, since this is the only
1732 caller of allocate_vectorlike that could cause overflow.
1733 Check that the new vector's length is representable as a fixnum.
1735 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1736 The previous code was bogus. For example, next_almost_prime (32)
1737 returned 39, which is undesirable as it is a multiple of 3; and
1738 next_almost_prime (24) returned 25, which is a multiple of 5 so
1739 why was the code bothering to check for multiples of 7?
1741 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1743 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1745 Variadic C functions now count arguments with ptrdiff_t.
1746 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1747 Back then I didn't know that the Emacs coding style prefers signed int.
1748 Also, in the meantime I found a few more instances where arguments
1749 were being counted with int, which may truncate counts on 64-bit
1750 machines, or EMACS_INT, which may be unnecessarily wide.
1751 * lisp.h (struct Lisp_Subr.function.aMANY)
1752 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1753 Arg counts are now ptrdiff_t, not size_t.
1754 All variadic functions and their callers changed accordingly.
1755 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1756 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1757 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1758 * callint.c (Fcall_interactively): Check arg count for overflow,
1759 to avoid potential buffer overrun. Use signed char, not 'int',
1760 for 'varies' array, so that we needn't bother to check its size
1761 calculation for overflow.
1762 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1763 * eval.c (apply_lambda):
1764 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1765 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1766 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1768 * callint.c (Fcall_interactively): Don't use index var as event count.
1770 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1771 * mem-limits.h (SIZE): Remove; no longer used.
1773 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1775 Remove unnecessary casts.
1776 * xterm.c (x_term_init):
1777 * xfns.c (x_set_border_pixel):
1778 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1779 These aren't needed now that we assume ANSI C.
1781 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1782 It's more likely to cause problems (due to unsigned overflow)
1785 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1787 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1789 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1791 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1793 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1795 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1797 GLYPH_CODE_FACE returns EMACS_INT, not int.
1798 * dispextern.h (merge_faces):
1799 * xfaces.c (merge_faces):
1800 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1801 Don't assume EMACS_INT fits in int.
1803 * character.h (CHAR_VALID_P): Remove unused parameter.
1804 * fontset.c, lisp.h, xdisp.c: All uses changed.
1806 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1808 * fns.c (concat): Minor tuning based on overflow analysis.
1809 This doesn't fix any bugs. Use int to hold character, instead
1810 of constantly refetching from Emacs object. Use XFASTINT, not
1811 XINT, for value known to be a character. Don't bother comparing
1812 a single byte to 0400, as it's always less.
1814 * floatfns.c (Fexpt):
1815 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1817 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1820 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1822 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1823 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1824 incorrectly succeed when S was a string, because 4294967386 was
1825 truncated before it was used.
1827 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1828 Otherwise, an out-of-range integer could cause undefined behavior
1831 * composite.c: Use int, not EMACS_INT, for characters.
1832 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1833 EMACS_INT, for values that are known to be in character range.
1834 This doesn't fix any bugs but is the usual style inside Emacs and
1835 may generate better code on 32-bit machines.
1837 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1838 This is for reasons similar to the recent CHAR_STRING fix.
1839 * charset.c (Fencode_char): Check that character arg is actually
1840 a character. Pass an int to ENCODE_CHAR.
1841 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1842 wider than 'int', as a compile-time check to prevent future regressions
1845 * character.c (char_string): Remove unnecessary casts.
1847 Make sure a 64-bit char is never passed to CHAR_STRING.
1848 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1849 by silently ignoring the top 32 bits, allowing some values
1850 that were far too large to be valid characters.
1851 * character.h: Include <verify.h>.
1852 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1853 arguments are no wider than unsigned, as a compile-time check
1854 to prevent future regressions in this area.
1856 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1857 (Fsubst_char_in_region):
1859 * xdisp.c (decode_mode_spec_coding):
1860 Adjust to CHAR_STRING's new requirement.
1861 * editfns.c (Finsert_char, Fsubst_char_in_region):
1862 * fns.c (concat): Check that character args are actually
1863 characters. Without this test, these functions did the wrong
1864 thing with wildly out-of-range values on 64-bit hosts.
1866 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1867 These casts should not be needed on 32-bit hosts, either.
1868 * keyboard.c (read_char):
1869 * lread.c (Fload): Remove casts to unsigned.
1871 * lisp.h (UNSIGNED_CMP): New macro.
1872 This fixes comparison bugs on 64-bit hosts.
1873 (ASCII_CHAR_P): Use it.
1874 * casefiddle.c (casify_object):
1875 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
1876 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1877 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1878 * dispextern.h (FACE_FROM_ID):
1879 * keyboard.c (read_char): Use UNSIGNED_CMP.
1881 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1882 not to EMACS_INT, to avoid GCC warning.
1884 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1886 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1887 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1888 isn't needed on 32-bit machines.
1890 * buffer.c (Fgenerate_new_buffer_name):
1891 Use EMACS_INT for count, not int.
1892 (advance_to_char_boundary): Return EMACS_INT, not int.
1894 * data.c (Qcompiled_function): Now static.
1896 * window.c (window_body_lines): Now static.
1898 * image.c (gif_load): Rename local to avoid shadowing.
1900 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1901 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1902 * alloc.c (make_save_value): Integer argument is now of type
1904 (mark_object): Use ptrdiff_t, not int.
1905 * lisp.h (pD): New macro.
1906 * print.c (print_object): Use it.
1908 * alloc.c: Use EMACS_INT, not int, to count objects.
1909 (total_conses, total_markers, total_symbols, total_vector_size)
1910 (total_free_conses, total_free_markers, total_free_symbols)
1911 (total_free_floats, total_floats, total_free_intervals)
1912 (total_intervals, total_strings, total_free_strings):
1913 Now EMACS_INT, not int. All uses changed.
1914 (Fgarbage_collect): Compute overall total using a double, so that
1915 integer overflow is less likely to be a problem. Check for overflow
1916 when converting back to an integer.
1917 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1918 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1919 These were 'int' variables that could overflow on 64-bit hosts;
1920 they were never used, so remove them instead of repairing them.
1921 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
1922 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1923 Previously, this ceilinged at INT_MAX, but that doesn't work on
1925 (allocate_pseudovector): Don't use EMACS_INT when int would do.
1927 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
1928 (allocate_vectorlike): Check for ptrdiff_t overflow.
1929 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1930 when a (possibly-narrower) signed value would do just as well.
1931 We prefer using signed arithmetic, to avoid comparison confusion.
1933 * alloc.c: Catch some string size overflows that we were missing.
1934 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1935 for convenience in STRING_BYTES_MAX.
1936 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1937 The definition here is exact; the one in lisp.h was approximate.
1938 (allocate_string_data): Check for string overflow. This catches
1939 some instances we weren't catching before. Also, it catches
1940 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1941 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1942 and ptrdiff_t and EMACS_INT are both 64 bits.
1944 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1945 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1946 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1948 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1950 * alloc.c (Fmake_string): Check for out-of-range init.
1952 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1954 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1956 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1958 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1959 xg_get_default_scrollbar_width.
1961 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1962 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1963 (style_changed_cb): Call update_theme_scrollbar_width and call
1964 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1965 all frames (Bug#8505).
1966 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1967 Call gtk_window_set_resizable if HAVE_GTK3.
1968 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1969 and height if HAVE_GTK3 (Bug#8505).
1970 (scroll_bar_width_for_theme): New variable.
1971 (update_theme_scrollbar_width): New function.
1972 (xg_get_default_scrollbar_width): Move code to
1973 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1974 (xg_initialize): Call update_theme_scrollbar_width.
1976 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1978 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1980 2011-06-12 Martin Rudalics <rudalics@gmx.at>
1982 * frame.c (make_frame): Call other_buffer_safely instead of
1985 * window.c (temp_output_buffer_show): Call display_buffer with
1986 second argument Vtemp_buffer_show_specifiers and reset latter
1987 immediately after the call.
1988 (Vtemp_buffer_show_specifiers): New variable.
1989 (auto_window_vscroll_p, next_screen_context_lines)
1990 (Vscroll_preserve_screen_position): Remove leading asterisks from
1993 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
1995 Fix minor problems found by GCC 4.6.0 static checking.
1996 * buffer.c (Qclone_number): Remove for now, as it's unused.
1997 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1998 (record_buffer): Remove unused local.
1999 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2000 (set_frame_buffer_list): Remove; unused.
2001 * frame.h (other_visible_frames): Remove decl.
2002 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2003 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2004 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2006 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2007 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2008 Define only if HAVE_GPM.
2009 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2010 (update_hints_inhibit): Remove; never set. All uses removed.
2011 * widgetprv.h (emacsFrameClassRec): Remove decl.
2012 * window.c (delete_deletable_window): Now returns void, since it
2013 wasn't returning anything.
2014 (compare_window_configurations): Remove unused locals.
2015 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2016 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2017 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2018 the same widths as pointers. This follows up on the 2011-05-06 patch.
2019 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2020 * xterm.h: Likewise.
2021 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2023 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2025 * makefile.w32-in: Update dependencies.
2026 (LISP_H): Add lib/intprops.h.
2028 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2030 * image.c (gif_load): Add animation frame delay to the metadata.
2031 (syms_of_image): Use DEFSYM. New symbol `delay'.
2033 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2035 * window.c (delete_deletable_window): Re-add.
2036 (Fset_window_configuration): Rewrite to handle dead buffers and
2037 consequently deletable windows.
2038 (window_tree, Fwindow_tree): Remove. Supply functionality in
2040 (compare_window_configurations): Simplify code.
2042 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2044 * image.c (imagemagick_load_image): Fix type mismatch.
2045 (Fimagemagick_types): Likewise.
2047 * window.h (replace_buffer_in_windows): Declare.
2049 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2051 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2052 Qclone_number. Remove external declaration of Qdelete_window.
2053 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2055 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
2056 Qbuffer_list_update_hook if allowed.
2057 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2058 buffer list implementation.
2059 (other_buffer_safely): New function.
2060 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2061 calls to replace_buffer_in_windows and
2062 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2064 (record_buffer): Inhibit quitting and rewrite using quittable
2065 functions. Run Qbuffer_list_update_hook if allowed.
2066 (Frecord_buffer, Funrecord_buffer): New functions.
2067 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
2068 switch-to-buffer to window.el.
2069 (bury-buffer): Move to window.el.
2070 (Vbuffer_list_update_hook): New variable.
2072 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2075 * window.h (resize_frame_windows): Move up in code.
2076 (Fwindow_frame): Remove EXFUN.
2077 (replace_buffer_in_all_windows): Remove prototype.
2078 (replace_buffer_in_windows_safely): Add prototype.
2080 * window.c: Declare Qdelete_window static again. Move down
2081 declaration of select_count.
2082 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2083 (Fother_window): Move to window.el.
2084 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2085 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2086 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2088 (replace_buffer_in_windows): Implement by calling
2089 Qreplace_buffer_in_windows.
2090 (replace_buffer_in_all_windows): Remove with some functionality
2091 moved into replace_buffer_in_windows_safely.
2092 (replace_buffer_in_windows_safely): New function.
2093 (select_window_norecord, select_frame_norecord): Move in front
2094 of run_window_configuration_change_hook. Remove now obsolete
2096 (Fset_window_buffer): Rewrite doc-string. Call
2097 Qrecord_window_buffer.
2098 (keys_of_window): Move binding for other-window to window.el.
2100 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2102 * dispextern.h (struct image): Replace data member, whose int_val
2103 and ptr_val fields were not used by anything, with a single
2106 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2107 (gif_clear_image, gif_load, imagemagick_load_image)
2108 (gs_clear_image, gs_load): Callers changed.
2110 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2112 * buffer.h: Include <time.h>, for time_t.
2113 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2115 Fix minor problems found by static checking.
2117 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2119 Make identifiers static if they are not used in other modules.
2120 * data.c (Qcompiled_function, Qframe, Qvector):
2121 * image.c (QimageMagick, Qsvg):
2122 * minibuf.c (Qmetadata):
2123 * window.c (resize_window_check, resize_root_window): Now static.
2124 * window.h (resize_window_check, resize_root_window): Remove decls.
2126 * window.c (window_deletion_count, delete_deletable_window):
2128 (window_body_lines): Now static.
2129 (Fdelete_other_windows_internal): Mark vars as initialized.
2130 Make sure 'resize_failed' is initialized.
2131 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2132 (resize_window_apply): Remove unused local.
2133 * window.h (delete_deletable_window): Remove decl.
2135 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2136 (imagemagick_load_image): Fix pointer signedness problem by changing
2137 last arg from unsigned char * to char *. All uses changed.
2138 Also, fix a local for similar reasons.
2139 Remove unused locals. Remove locals to avoid shadowing.
2140 (fn_rsvg_handle_free): Remove; unused.
2141 (svg_load, svg_load_image): Fix pointer signedness problem.
2142 (imagemagick_load_image): Don't use garbage pointer image_wand.
2144 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2146 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2148 * image.c (gif_load): Fix omitted cast error introduced by
2151 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2153 * window.h (resize_proportionally, orig_total_lines)
2154 (orig_top_line): Remove from window structure.
2155 (set_window_height, set_window_width, change_window_heights)
2156 (Fdelete_window): Remove prototypes.
2157 (resize_frame_windows): Remove duplicate declaration.
2159 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2161 * window.h (resize_frame_windows, resize_window_check)
2162 (delete_deletable_window, resize_root_window)
2163 (resize_frame_windows): Declare prototypes.
2165 * window.c (resize_window_apply): Make definition be "static" to
2166 match the prototype.
2168 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2170 * window.c: Remove declarations of Qwindow_size_fixed,
2171 window_min_size_1, window_min_size_2, window_min_size,
2172 size_window, window_fixed_size_p, enlarge_window, delete_window.
2173 Remove static from declaration of Qdelete_window, it's
2174 temporarily needed by Fbury_buffer.
2175 (replace_window): Don't assign orig_top_line and
2177 (Fdelete_window, delete_window): Remove. Window deletion is
2178 handled by window.el.
2179 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
2180 Fdelete_window calls with calls to Qdelete_window.
2181 (Fdelete_other_windows): Remove. Deleting other windows is
2182 handled by window.el.
2183 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2184 handled in window.el.
2185 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2186 Window minimum sizes are handled in window.el.
2187 (shrink_windows, size_window, set_window_height)
2188 (set_window_width, change_window_heights, window_height)
2189 (window_width, CURBEG, CURSIZE, enlarge_window)
2190 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2191 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2192 handled in window.el.
2193 (make_dummy_parent): Rename to make_parent_window and give it a
2194 second argument horflag.
2195 (make_window): Don't set resize_proportionally any more.
2196 (Fsplit_window): Remove. Windows are split in window.el.
2197 (save_restore_action, save_restore_orig_size)
2198 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2199 Resize mini windows in window.el.
2200 (grow_mini_window, shrink_mini_window): Implement by calling
2201 Qresize_root_window_vertically, resize_window_check and
2202 resize_window_apply.
2203 (saved_window, Fset_window_configuration, save_window_save): Do
2204 not handle orig_top_line, orig_total_lines, and
2205 resize_proportionally.
2206 (window_min_height, window_min_width): Move to window.el.
2207 (keys_of_window): Move bindings for delete-other-windows,
2208 split-window, delete-window and enlarge-window to window.el.
2210 * buffer.c: Temporarily extern Qdelete_window.
2211 (Fbury_buffer): Temporarily call Qdelete_window instead of
2212 Fdelete_window (Fbury_buffer will move to window.el soon).
2214 * frame.c (set_menu_bar_lines_1): Remove code handling
2215 orig_top_line and orig_total_lines.
2217 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2218 set_window_height but set heights directly.
2219 (change_frame_size_1): Use resize_frame_windows.
2221 * xdisp.c (init_xdisp): Don't use set_window_height but set
2224 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
2225 resize_frame_windows instead of change_window_heights and run
2226 run_window_configuration_change_hook.
2228 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2229 instead of change_window_heights and run
2230 run_window_configuration_change_hook.
2232 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2234 * window.c (replace_window): Rename second argument REPLACEMENT to
2235 NEW. New third argument SETFLAG. Rewrite.
2236 (delete_window, make_dummy_parent): Call replace_window with
2238 (window_list_1): Move down in code.
2239 (run_window_configuration_change_hook): Move set_buffer part
2240 before select_frame_norecord part in order to unwind correctly.
2241 Rename count1 to count.
2242 (recombine_windows, delete_deletable_window, resize_root_window)
2243 (Fdelete_other_windows_internal)
2244 (Frun_window_configuration_change_hook, make_parent_window)
2245 (resize_window_check, resize_window_apply, Fresize_window_apply)
2246 (resize_frame_windows, Fsplit_window_internal)
2247 (Fdelete_window_internal, Fresize_mini_window_internal): New
2249 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2251 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2253 * window.h (window): Add some new members to window structure -
2254 normal_lines, normal_cols, new_total, new_normal, clone_number,
2255 splits, nest, prev_buffers, next_buffers.
2256 (WINDOW_TOTAL_SIZE): Move here from window.c.
2257 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2259 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2261 (make_dummy_parent): Set new members of windows structure.
2262 (make_window): Move down in code. Handle new members of window
2264 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2265 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2266 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2267 (Fset_window_prev_buffers, Fwindow_next_buffers)
2268 (Fset_window_next_buffers, Fset_window_clone_number): New
2270 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2271 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2273 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2274 Argument WINDOW can be now internal window too.
2275 (Fwindow_use_time): Move up in code.
2276 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2278 (Fset_window_configuration, saved_window)
2279 (Fcurrent_window_configuration, save_window_save): Handle new
2280 members of window structure.
2281 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2282 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2283 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2284 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2285 Qget_mru_window, Qresize_root_window,
2286 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2287 Qauto_buffer_name; staticpro them.
2289 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2291 * window.c (Fwindow_total_size, Fwindow_left_column)
2292 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2293 (Fwindow_list_1): New functions.
2294 (window_box_text_cols): Replace with window_body_cols.
2295 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2296 window_body_cols instead of window_box_text_cols.
2297 (delete_window, Fset_window_configuration): Call
2298 delete_all_subwindows with window as argument.
2299 (delete_all_subwindows): Take a window as argument and not a
2301 (window_loop): Remove handling of GET_LRU_WINDOW and
2303 (Fget_lru_window, Fget_largest_window): Move to window.el.
2305 * window.h: Extern window_body_cols instead of
2306 window_box_text_cols. delete_all_subwindows now takes a
2307 Lisp_Object as argument.
2309 * indent.c (compute_motion, Fcompute_motion): Use
2310 window_body_cols instead of window_box_text_cols.
2312 * frame.c (delete_frame): Call delete_all_subwindows with root
2315 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2317 * fns.c (Fputhash): Document return value.
2319 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2321 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2323 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2325 Cons<->int and similar integer overflow fixes (Bug#8794).
2327 Check for overflow when converting integer to cons and back.
2328 * charset.c (Fdefine_charset_internal, Fdecode_char):
2329 Use cons_to_unsigned to catch overflow.
2330 (Fencode_char): Use INTEGER_TO_CONS.
2331 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2332 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2333 * data.c (long_to_cons, cons_to_long): Remove.
2334 (cons_to_unsigned, cons_to_signed): New functions.
2335 These signal an error for invalid or out-of-range values.
2336 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2337 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2338 * font.c (Ffont_variation_glyphs):
2339 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2340 * lisp.h: Include <intprops.h>.
2341 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2342 (cons_to_signed, cons_to_unsigned): New decls.
2343 (long_to_cons, cons_to_long): Remove decls.
2344 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2345 (Fprimitive_undo): Use CONS_TO_INTEGER.
2346 * xfns.c (Fx_window_property): Likewise.
2347 * xselect.c: Include <limits.h>.
2348 (x_own_selection, selection_data_to_lisp_data):
2349 Use INTEGER_TO_CONS.
2350 (x_handle_selection_request, x_handle_selection_clear)
2351 (x_get_foreign_selection, Fx_disown_selection_internal)
2352 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2353 (lisp_data_to_selection_data): Use cons_to_unsigned.
2354 (x_fill_property_data): Use cons_to_signed.
2355 Report values out of range.
2357 Check for buffer and string overflow more precisely.
2358 * buffer.h (BUF_BYTES_MAX): New macro.
2359 * lisp.h (STRING_BYTES_MAX): New macro.
2360 * alloc.c (Fmake_string):
2361 * character.c (string_escape_byte8):
2362 * coding.c (coding_alloc_by_realloc):
2363 * doprnt.c (doprnt):
2364 * editfns.c (Fformat):
2366 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2367 since they may not be the same number.
2368 * editfns.c (Finsert_char):
2369 * fileio.c (Finsert_file_contents):
2370 Likewise for BUF_BYTES_MAX.
2372 * image.c: Use ptrdiff_t, not int, for sizes.
2373 (slurp_file): Switch from int to ptrdiff_t.
2375 (slurp_file): Check that file size fits in both size_t (for
2376 malloc) and ptrdiff_t (for sanity and safety).
2378 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2379 if b->modtime has its maximal value.
2381 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2383 Don't assume time_t can fit into int.
2384 * buffer.h (struct buffer.modtime): Now time_t, not int.
2385 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2386 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2388 Minor fixes for signed vs unsigned integers.
2389 * character.h (MAYBE_UNIFY_CHAR):
2390 * charset.c (maybe_unify_char):
2391 * keyboard.c (read_char, reorder_modifiers):
2392 XINT -> XFASTINT, since the integer must be nonnegative.
2393 * ftfont.c (ftfont_spec_pattern):
2394 * keymap.c (access_keymap, silly_event_symbol_error):
2395 XUINT -> XFASTINT, since the integer must be nonnegative.
2396 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2397 since it makes no difference and we prefer signed.
2398 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2399 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2402 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2404 * window.h (Fwindow_frame): Declare.
2406 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2408 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2409 (SPARE_MEMORY): Always define.
2410 (LARGE_REQUEST): Remove.
2411 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2413 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2415 * lisp.h: Move EXFUNS for Fframe_root_window,
2416 Fframe_first_window and Fset_frame_selected_window to window.h.
2418 * window.h: Move EXFUNS for Fframe_root_window,
2419 Fframe_first_window and Fset_frame_selected_window here from
2422 * frame.c (Fwindow_frame, Fframe_first_window)
2423 (Fframe_root_window, Fframe_selected_window)
2424 (Fset_frame_selected_window): Move to window.c.
2425 (Factive_minibuffer_window): Move to minibuf.c.
2426 (Fother_visible_frames_p): New function.
2428 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2430 * window.c (decode_window, decode_any_window): Move up in code.
2431 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2432 (inhibit_frame_unsplittable): Remove unused variable.
2433 (Fwindow_buffer): Move up and rewrite doc-string.
2434 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2435 (Fwindow_prev): New functions.
2436 (Fwindow_frame): Move here from frame.c. Accept any window as
2438 (Fframe_root_window, Fframe_first_window)
2439 (Fframe_selected_window): Move here from frame.c. Accept frame
2440 or arbitrary window as argument. Update doc-strings.
2441 (Fminibuffer_window): Move up in code.
2442 (Fwindow_minibuffer_p): Move up in code and simplify.
2443 (Fset_frame_selected_window): Move here from frame.c.
2445 (Fselected_window, select_window, Fselect_window): Move up in
2446 code. Minor doc-string fixes.
2448 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2450 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2451 Do not assume that spare memory exists; that assumption is valid
2452 only if SYSTEM_MALLOC.
2453 (LARGE_REQUEST): New macro, so that the issue of large requests
2454 is separated from the issue of spare memory.
2456 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2458 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2461 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2463 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2466 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2468 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2470 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2472 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2473 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2475 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2477 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2479 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2481 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2482 (x_clipboard_manager_save): Add return value.
2483 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2485 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2486 Obey Vx_select_enable_clipboard_manager. Catch errors in
2487 x_clipboard_manager_save (Bug#8779).
2488 (Vx_select_enable_clipboard_manager): New variable.
2489 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2491 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2493 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2495 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2497 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2498 in the current matrix if keep_current_p is non-zero.
2500 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2502 * bidi.c (bidi_level_of_next_char): Fix last change.
2504 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2506 Support bidi reordering of text covered by display properties.
2508 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2509 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2510 (bidi_cache_search, bidi_cache_iterator_state)
2511 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2512 (bidi_level_of_next_char, bidi_move_to_visually_next):
2513 Support character positions inside a run of characters covered by a
2515 (bidi_paragraph_init, bidi_resolve_explicit_1)
2516 (bidi_level_of_next_char): Call bidi_fetch_char and
2517 bidi_fetch_char_advance instead of FETCH_CHAR and
2519 (bidi_init_it): Initialize new members.
2520 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2522 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2523 instead of using explicit *_CHAR codes.
2524 (bidi_resolve_explicit, bidi_resolve_weak):
2525 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2526 bidirectional text is supported only in multibyte buffers.
2527 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2528 it to initialize the frame_window_p member of struct bidi_it.
2529 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2530 (bidi_resolve_explicit, bidi_resolve_weak)
2531 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2532 bidi_it->nchars is non-positive.
2533 (bidi_level_of_next_char): Don't try to lookup the cache for the
2534 next/previous character if nothing is cached there yet, or if we
2535 were just reseat()'ed to a new position.
2537 * xdisp.c (set_cursor_from_row): Set start and stop points
2538 according to the row's direction when priming the loop that looks
2539 for the glyph on which to display cursor.
2540 (single_display_spec_intangible_p): Function deleted.
2541 (display_prop_intangible_p): Reimplement to call
2542 handle_display_spec instead of single_display_spec_intangible_p.
2543 Accept 3 additional arguments needed by handle_display_spec.
2544 This fixes incorrect cursor motion across display property with complex
2545 values: lists, `(when COND...)' forms, etc.
2546 (single_display_spec_string_p): Support property values that are
2547 lists with the argument STRING its top-level element.
2548 (display_prop_string_p): Fix the condition for processing a
2549 property that is a list to be consistent with handle_display_spec.
2550 (handle_display_spec): New function, refactored from the
2551 last portion of handle_display_prop.
2552 (compute_display_string_pos): Accept additional argument
2553 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2554 value of a `display' property is a "replacing spec".
2555 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2556 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2557 the display property, but just return a value indicating whether
2558 the display property will replace the characters it covers.
2559 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2560 frame_window_p members of struct bidi_it.
2561 (compute_display_string_pos, compute_display_string_end):
2563 (push_it): Accept second argument POSITION, where pop_it should
2564 jump to continue iteration.
2565 (reseat_1): Initialize bidi_it.disp_pos.
2567 * keyboard.c (adjust_point_for_property): Adjust the call to
2568 display_prop_intangible_p to its new signature.
2570 * dispextern.h (struct bidi_it): New member frame_window_p.
2571 (bidi_init_it): Update prototypes.
2572 (display_prop_intangible_p): Update prototype.
2573 (compute_display_string_pos, compute_display_string_end):
2575 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2578 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2580 Malloc failure behavior now depends on size of allocation.
2581 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2582 * lisp.h: Change signatures accordingly.
2583 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2584 All callers changed. (Bug#8762)
2586 * gnutls.c: Use Emacs's memory allocators.
2587 Without this change, the gnutls library would invoke malloc etc.
2588 directly, which causes problems on non-SYNC_INPUT hosts, and which
2589 runs afoul of improving memory_full behavior. (Bug#8761)
2590 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2591 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2592 xfree instead of the default malloc, realloc, free.
2593 (Fgnutls_boot): No need to check for memory allocation failure,
2594 since xmalloc does that for us.
2596 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2597 * category.c (hash_get_category_set):
2598 * ccl.c (ccl_driver):
2599 * charset.c (Fdefine_charset_internal):
2600 * charset.h (struct charset.hash_index):
2601 * composite.c (get_composition_id, gstring_lookup_cache)
2602 (composition_gstring_put_cache):
2603 * composite.h (struct composition.hash_index):
2604 * dispextern.h (struct image.hash):
2605 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2606 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2607 (hashfn_equal, hashfn_user_defined, make_hash_table)
2608 (maybe_resize_hash_table, hash_lookup, hash_put)
2609 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2610 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2611 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2612 * image.c (make_image, search_image_cache, lookup_image)
2613 (xpm_put_color_table_h):
2614 * lisp.h (struct Lisp_Hash_Table):
2615 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2616 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2617 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2618 * alloc.c (allocate_vectorlike):
2619 Check for overflow in vector size calculations.
2620 * ccl.c (ccl_driver):
2621 Check for overflow when converting EMACS_INT to int.
2622 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2623 need to be updated by these changes.
2624 * fns.c (make_hash_table, maybe_resize_hash_table):
2625 Check for integer overflow with large hash tables.
2626 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2627 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2628 (SXHASH_REDUCE): New macro.
2629 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2630 Use it instead of discarding useful hash info with large hash values.
2631 (sxhash_float): New function.
2632 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2633 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2634 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2635 Rewrite to use FIXNUM_BITS, as this simplifies things.
2636 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2637 Adjust signatures to match updated version of code.
2638 (consing_since_gc): Now EMACS_INT, since a single hash table can
2639 use more than INT_MAX bytes.
2641 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2643 Make it possible to build with GCC-4.6+ -O2 -flto.
2645 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2647 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2649 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2650 Call minibuffer-inactive-mode.
2652 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2654 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2655 Update dependencies.
2657 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2659 * data.c (init_data): Remove code for UTS, this system is not
2662 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2664 Don't force ./temacs to start in terminal mode.
2666 * frame.c (make_initial_frame): Initialize faces in all cases, not
2667 only when CANNOT_DUMP is defined.
2668 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2670 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2672 * dispnew.c (add_window_display_history): Use const for the string
2673 pointer. Remove declaration, not needed.
2675 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2677 Use 'inline', not 'INLINE'.
2678 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2679 * alloc.c, fontset.c (INLINE): Remove.
2680 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2681 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2682 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2683 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2684 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2686 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2688 Make it possible to run ./temacs.
2690 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2691 syms_of_callproc does the same thing. Remove test for
2692 "initialized", do it in the caller.
2693 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2695 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2697 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2698 (read_minibuf): Use get_minibuffer.
2699 (syms_of_minibuf): Use DEFSYM.
2700 (Qmetadata): New var.
2701 * data.c (Qbuffer): Don't make it static.
2702 (syms_of_data): Use DEFSYM.
2704 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2706 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2707 (CCL_CODE_MIN): New macro.
2709 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2711 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2713 * eval.c (Qdebug): Now static.
2714 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2715 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2716 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2718 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2720 * image.c: Various fixes to ImageMagick code comments.
2721 (Fimagemagick_types): Doc fix.
2723 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2725 Minor fixes prompted by GCC 4.6.0 warnings.
2727 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2729 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2730 (x_clipboard_manager_save_all): Move extern decl to ...
2731 * xterm.h: ... here, so that it can be checked for consistency.
2733 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2735 * xselect.c (x_clipboard_manager_save_frame)
2736 (x_clipboard_manager_save_all): New functions.
2737 (Fx_clipboard_manager_save): Lisp function deleted.
2739 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2740 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2742 * xterm.h: Update prototype.
2744 2011-05-28 William Xu <william.xwl@gmail.com>
2746 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2749 2011-05-28 Jim Meyering <meyering@redhat.com>
2751 Avoid a sign-extension bug in crypto_hash_function.
2752 * fns.c (to_uchar): Define.
2753 (crypto_hash_function): Use it to convert some newly-signed
2754 variables to unsigned, to avoid sign-extension bugs. For example,
2755 without this change, (md5 "truc") would evaluate to
2756 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2757 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2758 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2760 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2762 Integer overflow fixes.
2764 * dbusbind.c: Serial number integer overflow fixes.
2765 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2766 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2767 to hold a serial number that is too large for a fixnum.
2768 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2769 Check for serial numbers out of range. Decode any serial number
2770 that was so large that it became a float. (Bug#8722)
2772 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2773 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2774 Use XFASTINT rather than XUINT when numbers are nonnegative.
2775 (xd_append_arg, Fdbus_method_return_internal):
2776 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2777 arguments, check that Lisp number is nonnegative, rather than
2778 silently wrapping negative numbers around. (Bug#8722)
2779 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2782 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2784 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2786 ccl: add integer overflow checks
2787 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2788 (IN_INT_RANGE): New macros.
2789 (ccl_driver): Use them to check for integer overflow when
2790 decoding a CCL program. Many of the new checks are whether XINT (x)
2791 fits in int; it doesn't always, on 64-bit hosts. The new version
2792 doesn't catch all possible integer overflows, but it's an
2793 improvement. (Bug#8719)
2795 * alloc.c (make_event_array): Use XINT, not XUINT.
2796 There's no need for unsigned here.
2798 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2799 This follows up to the 2011-05-06 change that substituted uintptr_t
2800 for EMACS_INT. This case wasn't caught back then.
2802 Rework Fformat to avoid integer overflow issues.
2803 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2804 now (part of C89). Include <verify.h>.
2805 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2806 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2807 (Fformat): Avoid the prepass trying to compute sizes; it was only
2808 approximate and thus did not catch overflow reliably. Instead, walk
2809 through the format just once, formatting and computing sizes as we go,
2810 checking for integer overflow at every step, and allocating a larger
2811 buffer as needed. Keep track separately whether the format is
2812 multibyte. Keep only the most-recently calculated precision, rather
2813 than them all. Record whether each argument has been converted to
2814 string. Use EMACS_INT, not int, for byte and char and arg counts.
2815 Support field widths and precisions larger than INT_MAX. Avoid
2816 sprintf's undefined behavior with conversion specifications such as %#d
2817 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2818 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2819 formatting out-of-range floating point numbers with int
2822 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2824 * data.c: Avoid integer truncation in expressions involving floats.
2825 * data.c: Include <intprops.h>.
2826 (arith_driver): When there's an integer overflow in an expression
2827 involving floating point, convert the integers to floating point
2828 so that the resulting value does not suffer from catastrophic
2829 integer truncation. For example, on a 64-bit host (* 4
2830 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2831 Do not rely on undefined behavior after integer overflow.
2833 merge count_size_as_multibyte, parse_str_to_multibyte
2834 * character.c, character.h (count_size_as_multibyte):
2835 Rename from parse_str_to_multibyte; all uses changed.
2836 Check for integer overflow.
2837 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2838 since it's now a duplicate of the other. This is more of
2839 a character than a buffer op, so better that it's in character.c.
2840 * fns.c, print.c: Adjust to above changes.
2842 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2844 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2846 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2848 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2849 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2850 (x_clipboard_manager_save): Now static.
2851 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2853 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2854 (crypto_hash_function): Now static.
2855 Fix pointer signedness problems. Avoid unnecessary initializations.
2857 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2859 * termhooks.h (Vselection_alist): Make it terminal-local.
2861 * terminal.c (create_terminal): Initialize it.
2863 * xselect.c: Support for clipboard managers.
2864 (Vselection_alist): Move to termhooks.h as terminal-local var.
2865 (LOCAL_SELECTION): New macro.
2866 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2867 (symbol_to_x_atom): Remove gratuitous arg.
2868 (x_handle_selection_request, lisp_data_to_selection_data)
2869 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
2870 (x_own_selection, x_get_local_selection, x_convert_selection):
2871 New arg, specifying work frame. Use terminal-local Vselection_alist.
2872 (some_frame_on_display): Delete unused function.
2873 (Fx_own_selection_internal, Fx_get_selection_internal)
2874 (Fx_disown_selection_internal, Fx_selection_owner_p)
2875 (Fx_selection_exists_p): New optional frame arg.
2876 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2877 (x_handle_selection_clear): Don't treat other terminals with the
2878 same keyboard specially. Use the terminal-local Vselection_alist.
2879 (x_clear_frame_selections): Use Frun_hook_with_args.
2881 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2883 * xterm.h: Add support for those atoms.
2885 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
2887 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2888 (converted_selections, conversion_fail_tag): New global variables.
2889 (x_selection_request_lisp_error): Free the above.
2890 (x_get_local_selection): Remove unnecessary code.
2891 (x_reply_selection_request): Args changed; handle arbitrary array
2892 of converted selections stored in converted_selections.
2893 Separate the XChangeProperty and SelectionNotify steps.
2894 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2895 (x_convert_selection): New function.
2896 (x_handle_selection_event): Simplify.
2897 (x_get_foreign_selection): Don't ignore incoming requests while
2898 waiting for an answer; this will fail when we implement
2899 SAVE_TARGETS, and seems unnecessary anyway.
2900 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2901 (Vx_sent_selection_functions): Doc fix.
2903 2011-05-26 Leo Liu <sdl.web@gmail.com>
2905 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2907 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2909 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2911 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2912 for fringe update if it has periodic bitmap.
2913 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2914 and fringe_bitmap_periodic_p.
2916 * fringe.c (get_fringe_bitmap_data): New function.
2917 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2918 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2919 row. Mark glyph row for fringe update if periodicity changed.
2921 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2922 for fringe update unless it has periodic bitmap.
2924 2011-05-25 Kenichi Handa <handa@m17n.org>
2926 * xdisp.c (get_next_display_element): Set correct it->face_id for
2927 a static composition.
2929 2011-05-24 Leo Liu <sdl.web@gmail.com>
2932 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2934 * fns.c (crypto_hash_function, Fsha1): New function.
2935 (Fmd5): Use crypto_hash_function.
2936 (syms_of_fns): Add Ssha1.
2938 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2940 * gnutls.c: Remove unused macros.
2941 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2942 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2943 Remove macros that are defined and never used.
2944 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2946 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2948 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2949 (Fx_get_selection_internal): Minor cleanup.
2950 (Fx_own_selection_internal): Rename arguments for consistency with
2953 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2955 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2957 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2959 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2961 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2963 * dispnew.c (scrolling_window): Don't exclude the case that the
2964 last enabled row in the desired matrix touches the bottom boundary.
2966 2011-05-21 Glenn Morris <rgm@gnu.org>
2968 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
2969 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2970 and add some more files.
2972 2011-05-20 Eli Zaretskii <eliz@gnu.org>
2974 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2975 report_file_error introduced by the change from 2011-05-07.
2977 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2979 * systime.h (Time): Define only if emacs is defined.
2980 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2981 where the include path doesn't have X11/X.h by default. See
2982 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2984 2011-05-20 Kenichi Handa <handa@m17n.org>
2986 * composite.c (find_automatic_composition): Fix previous change.
2988 2011-05-20 Glenn Morris <rgm@gnu.org>
2990 * lisp.mk: New file, split from Makefile.in.
2991 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2992 (shortlisp): Remove.
2993 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2995 2011-05-19 Glenn Morris <rgm@gnu.org>
2997 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2998 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2999 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3000 (lisp): Set the order to that of loadup.el.
3001 (shortlisp): Make it a copy of $lisp.
3002 (SOME_MACHINE_LISP): Remove.
3003 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3004 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3006 2011-05-18 Kenichi Handa <handa@m17n.org>
3008 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3009 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3010 (find_automatic_composition): Mostly rewrite for efficiency.
3012 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3014 * makefile.w32-in: Update dependencies.
3016 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3018 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3019 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3021 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3023 Fix some integer overflow issues, such as string length overflow.
3025 * insdel.c (count_size_as_multibyte): Check for string overflow.
3027 * character.c (lisp_string_width): Check for string overflow.
3028 Use EMACS_INT, not int, for string indexes and lengths; in
3029 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3030 the resulting string length overflows an EMACS_INT; instead,
3031 report a string overflow if no precision given. When checking for
3032 precision exhaustion, use a check that cannot possibly have
3033 integer overflow. (Bug#8675)
3034 * character.h (lisp_string_width): Adjust to new signature.
3036 * alloc.c (string_overflow): New function.
3037 (Fmake_string): Use it. This doesn't change behavior, but saves
3038 a few bytes and will simplify future changes.
3039 * character.c (string_escape_byte8): Likewise.
3040 * lisp.h (string_overflow): New decl.
3042 Fixups, following up to the user-interface timestamp change.
3043 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3044 for UI timestamps, instead of unsigned long.
3045 * msdos.c (mouse_get_pos): Likewise.
3046 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3047 * w32gui.h (Time): Define by including "systime.h" rather than by
3048 declaring it ourselves. (Bug#8664)
3050 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3051 * image.c (clear_image_cache): Likewise.
3053 * term.c (term_mouse_position): Don't assume time_t wraparound.
3055 Be more systematic about user-interface timestamps.
3056 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3057 and sometimes 'EMACS_UINT', to represent these timestamps.
3058 This change causes it to use 'Time' uniformly, as that's what X uses.
3059 This makes the code easier to follow, and makes it easier to catch
3060 integer overflow bugs such as Bug#8664.
3061 * frame.c (Fmouse_position, Fmouse_pixel_position):
3062 Use Time, not unsigned long, for user-interface timestamps.
3063 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3064 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3065 * keyboard.h (last_event_timestamp): Likewise.
3066 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3067 * menu.h (xmenu_show): Likewise.
3068 * term.c (term_mouse_position): Likewise.
3069 * termhooks.h (struct input_event.timestamp): Likewise.
3070 (struct terminal.mouse_position_hook): Likewise.
3071 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3072 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3073 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3074 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3076 * menu.h, termhooks.h: Include "systime.h", for Time.
3078 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3079 Don't assume that the difference between two unsigned long values
3080 can fit into an integer. At this point, we know button_down_time
3081 <= event->timestamp, so the difference must be nonnegative, so
3082 there's no need to cast the result if double-click-time is
3083 nonnegative, as it should be; check that it's nonnegative, just in
3084 case. This bug is triggered when events are more than 2**31 ms
3085 apart (about 25 days). (Bug#8664)
3087 * xselect.c (last_event_timestamp): Remove duplicate decl.
3088 (x_own_selection): Remove needless cast to unsigned long.
3090 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3091 that always fit in int. Use a sentinel instead of a counter, to
3092 avoid a temp and to allay GCC's concerns about possible int overflow.
3093 * frame.h (struct frame): Use int for menu_bar_items_used
3094 instead of EMACS_INT, since it always fits in int.
3096 * menu.c (grow_menu_items): Check for int overflow.
3098 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3100 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3101 Before, the code was not consistent. These values cannot exceed
3102 2**31 - 1 so there's no need to make them unsigned.
3103 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3104 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3105 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3107 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3109 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3110 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3111 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3112 presumably because the widths might not match.
3114 * window.c (size_window): Avoid needless test at loop start.
3116 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3118 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3120 2011-05-12 Drew Adams <drew.adams@oracle.com>
3122 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3124 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3126 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3127 `width' to `bar_area_x' and `bar_area_width', respectively.
3128 (x_scroll_run): Take account of fringe background extension.
3130 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3131 Rename local vars `left' and `width' to `bar_area_x' and
3132 `bar_area_width', respectively.
3133 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3134 background extension.
3136 2011-05-10 Jim Meyering <meyering@redhat.com>
3138 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3140 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3142 * image.c (Finit_image_library): Return t for built-in image types,
3143 like pbm and xbm. (Bug#8640)
3145 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3147 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3149 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3151 * w32console.c (Fset_screen_color): Doc fix.
3152 (Fget_screen_color): New function.
3153 (syms_of_ntterm): Defsubr it.
3155 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3156 unlink the temporary file if Fcall_process didn't create it in the
3158 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3159 child process will be redirected to a file specified with `:file'.
3160 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3161 cue to call_process_cleanup not to close that handle.
3163 2011-05-07 Ben Key <bkey76@gmail.com>
3165 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3166 one of two shell specific rules, either bootstrap-temacs-CMD or
3167 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3168 to the previous implementation of the bootstrap-temacs rule.
3169 The bootstrap-temacs-CMD rule is similar to the previous
3170 implementation of the bootstrap-temacs rule except that it
3171 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3174 These changes, along with some changes to nt/configure.bat,
3175 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3176 earlier fix to add support for --cflags and --ldflags options
3177 that include quotes so that it works whether make uses cmd or
3180 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3182 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3183 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3185 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3186 a string. Handle both cases.
3187 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3188 (Fdbus_register_method): Use Qinvalid_function.
3190 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3192 * makefile.w32-in: Update dependencies.
3193 (LISP_H): Add inttypes.h and stdin.h.
3194 (PROCESS_H): Add unistd.h.
3196 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3198 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3199 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3201 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3203 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3205 * term.c (vfatal): Remove stray call to va_end.
3206 It's not needed and the C Standard doesn't allow it here anyway.
3208 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3209 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3211 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3214 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3216 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3218 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3220 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3222 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3224 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3225 * charset.c (Fdefine_charset_internal): Don't initialize
3226 charset.code_space[15]. The value was garbage, on hosts with
3227 32-bit int (Bug#8600).
3229 * lread.c (read_integer): Be more consistent with string-to-number.
3230 Use string_to_number to do the actual conversion; this avoids
3231 rounding errors and fixes some other screwups. Without this fix,
3232 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3233 (digit_to_number): Move earlier, for benefit of read_integer.
3234 Return -1 if the digit is out of range for the base, -2 if it is
3235 not a digit in any supported base. (Bug#8602)
3237 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3239 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3240 to match comment at start of function. This also removes a
3241 GCC warning about overflow in a 32+64-bit port.
3243 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3245 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3246 Reported by Stefan Monnier in
3247 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3248 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3249 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3251 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3252 (EMACS_UINTPTR): Likewise, with uintptr_t.
3254 * lisp.h: Prefer 64-bit EMACS_INT if available.
3255 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3256 on 32-bit hosts that have 64-bit int, so that they can access
3258 However, temporarily disable this change unless the temporary
3259 symbol WIDE_EMACS_INT is defined.
3261 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3263 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3264 This removes an assumption that EMACS_INT and long are the same
3265 width as pointers. The assumption is true for Emacs porting targets
3266 now, but we want to make other targets possible.
3267 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3268 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3269 In the rest of the code, change types of integers that hold casted
3270 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3271 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3272 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3273 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3274 No need to cast type when ORing.
3275 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3276 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3277 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3278 assume EMACS_INT is the same width as char *.
3279 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3280 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3281 Remove no-longer-needed casts.
3282 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3283 (xg_tool_bar_help_callback, xg_make_tool_item):
3284 Use EMACS_INTPTR to hold an integer
3285 that will be cast to void *; this can avoid a GCC warning
3286 if EMACS_INT is not the same width as void *.
3287 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3288 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3289 (current_message_1, set_message_1):
3290 Use a local to convert to proper width without a cast.
3291 * xmenu.c (dialog_selection_callback): Likewise.
3293 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3294 Also, don't assume VALBITS / RAND_BITS is less than 5,
3295 and don't rely on undefined behavior when shifting a 1 left into
3297 * lisp.h (get_random): Change signature to match.
3299 * lread.c (hash_string): Use size_t, not int, for hash computation.
3300 Normally we prefer signed values; but hashing is special, because
3301 it's better to use unsigned division on hash table sizes so that
3302 the remainder is nonnegative. Also, size_t is the natural width
3303 for hashing into memory. The previous code used 'int', which doesn't
3304 retain enough info to hash well into very large tables.
3305 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3307 * dbusbind.c: Don't possibly lose pointer info when converting.
3308 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3309 Use XPNTR rather than XHASH, so that the high-order bits of
3310 the pointer aren't lost when converting through void *.
3312 * eval.c (Fautoload): Don't double-shift a pointer.
3314 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3316 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3318 * gnutls.c (DEF_GNUTLS_FN):
3319 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3321 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3323 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3326 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3328 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3329 New version that can reserve upto 2GB of heap space.
3331 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3333 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3335 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3337 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3338 `gnutls_certificate_set_x509_key_file'.
3340 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3342 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3343 Update dependencies.
3345 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3347 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3348 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3349 Remove unused parameter `fildes'.
3350 * process.c (read_process_output, send_process): Don't pass it.
3352 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3354 Fix previous change: the library cache is defined in w32.c.
3355 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3356 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3358 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3360 Implement dynamic loading of GnuTLS on Windows.
3362 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3363 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3364 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3367 * gnutls.c (Qgnutls_dll): Define.
3368 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3369 (gnutls_*): Declare function pointers.
3370 (init_gnutls_functions): New function to initialize function pointers.
3371 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3372 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3373 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3374 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3375 (emacs_gnutls_write, emacs_gnutls_read)
3376 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3377 (Fgnutls_available_p): New function.
3378 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3379 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3380 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3382 * image.c: Include w32.h.
3383 (Vimage_type_cache): Delete.
3384 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3385 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3386 (w32_delayed_load): Move to w32.c.
3388 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3390 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3391 (w32_delayed_load): Move from image.c. When loading a library, record
3392 its filename in the :loaded-from property of the library id.
3393 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3394 Initialize and staticpro them.
3395 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3397 * process.c: Include lisp.h before w32.h, not after.
3398 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3399 instead of gnutls_record_check_pending.
3401 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3403 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3405 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3406 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3409 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3411 * xterm.c (x_set_frame_alpha): Do not set property on anything
3412 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3414 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3416 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3418 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3420 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3421 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3422 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3423 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3424 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3425 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3426 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3427 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3428 (Qgnutls_bootprop_callbacks_verify): Make static.
3430 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3432 * callproc.c: Indentation fixup.
3434 * sysdep.c (wait_for_termination_1): Make static.
3435 (wait_for_termination, interruptible_wait_for_termination):
3436 Move after wait_for_termination_1.
3438 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3440 * sysdep.c (interruptible_wait_for_termination): New function
3441 which is like wait_for_termination, but allows keyboard
3444 * callproc.c (Fcall_process): Add (:file "file") as an option for
3446 (Fcall_process_region): Ditto.
3448 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3450 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3451 rather than `XVECTOR (FOO)->size'.
3453 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3454 inttypes.h, as a gnulib replacement is used if it not available in
3457 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3459 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3460 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3461 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3463 * coding.c (coding_alloc_by_realloc): Error out if destination
3464 will grow beyond MOST_POSITIVE_FIXNUM.
3465 (decode_coding_emacs_mule): Abort if there isn't enough place in
3466 charbuf for the composition carryover bytes. Reserve an extra
3467 space for up to 2 characters produced in a loop.
3468 (decode_coding_iso_2022): Abort if there isn't enough place in
3469 charbuf for the composition carryover bytes.
3471 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3473 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3474 aborting when %lld or %lll format is passed.
3475 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3476 %llo or %llx format is passed. (Bug#8545)
3478 * window.c (window_scroll_line_based): Use a marker instead of
3479 simple variables to record original value of point. (Bug#7952)
3481 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3482 produced by %s or %c overflows available buffer space. (Bug#8545)
3484 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3486 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3487 (SIZE_MAX): Move defn after all includes, as they might #define it.
3489 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3491 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3493 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3495 * keyboard.c (Qdelayed_warnings_hook): Define.
3496 (command_loop_1): Run `delayed-warnings-hook'
3497 if Vdelayed_warnings_list is non-nil.
3498 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3499 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3501 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3503 * doprnt.c (doprnt): Don't return value smaller than the buffer
3504 size if the message was truncated. (Bug#8545).
3506 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3508 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3509 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3511 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3513 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3515 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3517 * makefile.w32-in: Update dependencies.
3519 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3521 Improve `doprnt' and its usage. (Bug#8545)
3522 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3523 `format_end'. Remove support for %l as a conversion specifier.
3524 Don't use xrealloc. Improve diagnostics when the %l size modifier
3525 is used. Update the commentary.
3527 * eval.c (verror): Simplify calculation of size_t.
3529 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3532 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3534 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3537 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3539 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3540 This makes this file independent of the recent pseudovector change.
3542 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3544 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3546 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3547 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3548 Remove unused local.
3549 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3551 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3552 GCC 4.6.0 optimizes based on type-based alias analysis.
3553 For example, if b is of type struct buffer * and v of type struct
3554 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3555 != &v->size, and therefore "v->size = 1; b->size = 2; return
3556 v->size;" must therefore return 1. This assumption is incorrect
3557 for Emacs, since it type-puns struct Lisp_Vector * with many other
3558 types. To fix this problem, this patch adds a new type struct
3559 vectorlike_header that documents the constraints on layout of vectors
3560 and pseudovectors, and helps optimizing compilers not get fooled
3561 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3562 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3563 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3565 (XSETPVECTYPE): Rewrite in terms of new macro.
3566 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3567 This is a bit clearer, and further avoids the possibility of
3568 undesirable aliasing.
3569 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3570 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3571 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3572 since Lisp_Subr is a special case (no "next" field).
3573 (ASIZE): Now uses header.size rather than size.
3574 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3575 to avoid the hassle of writing XVECTOR (foo)->header.size.
3576 (struct vectorlike_header): New type.
3577 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3578 object, to help avoid aliasing.
3579 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3580 (SUBRP): Likewise, since Lisp_Subr is a special case.
3581 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3582 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3583 (struct Lisp_Hash_Table): Combine first two members into a single
3584 struct vectorlike_header member. All uses of "size" and "next" members
3585 changed to be "header.size" and "header.next".
3586 * buffer.h (struct buffer): Likewise.
3587 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3588 * frame.h (struct frame): Likewise.
3589 * process.h (struct Lisp_Process): Likewise.
3590 * termhooks.h (struct terminal): Likewise.
3591 * window.c (struct save_window_data, struct saved_window): Likewise.
3592 * window.h (struct window): Likewise.
3593 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3594 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3595 * buffer.c (init_buffer_once): Likewise.
3596 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3598 * process.c (Fformat_network_address): Use local var for size,
3601 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3603 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3604 * data.c (atof): Remove decl; no longer used or needed.
3605 (digit_to_number): Move to lread.c.
3606 (Fstring_to_number): Use new string_to_number function, to be
3607 consistent with how the Lisp reader treats infinities and NaNs.
3608 Do not assume that floating-point numbers represent EMACS_INT
3609 without losing information; this is not true on most 64-bit hosts.
3610 Avoid double-rounding errors, by insisting on integers when
3611 parsing non-base-10 numbers, as the documentation specifies.
3612 * lisp.h (string_to_number): New decl, replacing ...
3613 (isfloat_string): Remove.
3614 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3615 (read1): Do not accept +. and -. as integers; this
3616 appears to have been a coding error. Similarly, do not accept
3617 strings like +-1e0 as floating point numbers. Do not report
3618 overflow for integer overflows unless the base is not 10 which
3619 means we have no simple and reliable way to continue.
3620 Break out the floating-point parsing into a new
3621 function string_to_number, so that Fstring_to_number parses
3622 floating point numbers consistently with the Lisp reader.
3623 (digit_to_number): Move here from data.c. Make it static inline.
3624 (E_CHAR, EXP_INT): Remove, replacing with ...
3625 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3626 (string_to_number): New function, replacing isfloat_string.
3627 This function checks for valid syntax and produces the resulting
3628 Lisp float number too. Rework it so that string-to-number
3629 no longer mishandles examples like "1.0e+". Use strtoumax,
3630 so that overflow for non-base-10 numbers is reported only when
3631 there's no portable and simple way to convert to floating point.
3633 * textprop.c (set_text_properties_1): Rewrite for clarity,
3634 and to avoid GCC warning about integer overflow.
3636 * intervals.h (struct interval): Use EMACS_INT for members
3637 where EMACS_UINT might cause problems. See
3638 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3639 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3640 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3642 (offset_intervals): Tell GCC not to worry about length overflow
3643 when negating a negative length.
3645 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3646 (overrun_check_free): Likewise.
3648 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3649 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3652 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3653 (gnutls_make_error): Rename local to avoid shadowing.
3654 (gnutls_emacs_global_deinit): ifdef out; not used.
3655 (Fgnutls_boot): Use const for pointer to readonly storage.
3656 Comment out unused local. Fix pointer signedness problems.
3658 * lread.c (openp): Don't stuff size_t into an 'int'.
3659 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3660 about possible signed overflow.
3662 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3663 (GDK_KEY_g): Don't define if already defined.
3664 (xg_prepare_tooltip): Avoid pointer signedness problem.
3665 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3667 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3668 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3670 * xfns.c (Fx_window_property): Simplify a bit,
3671 to make a bit faster and to avoid GCC 4.6.0 warning.
3672 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3674 * fns.c (internal_equal): Don't assume size_t fits in int.
3676 * alloc.c (compact_small_strings): Tighten assertion a little.
3678 Replace pEd with more-general pI, and fix some printf arg casts.
3679 * lisp.h (pI): New macro, generalizing old pEd macro to other
3680 conversion specifiers. For example, use "...%"pI"d..." rather
3681 than "...%"pEd"...".
3682 (pEd): Remove. All uses replaced with similar uses of pI.
3683 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3684 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3685 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3686 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3687 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3688 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3689 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3691 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3692 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3693 * print.c (safe_debug_print, print_object): Likewise.
3694 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3696 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3697 avoiding the 0 flag, which is not portable.
3698 * process.c (Fmake_network_process): Use pI to avoid cast.
3699 * region-cache.c (pp_cache): Likewise.
3700 * xdisp.c (decode_mode_spec): Likewise.
3701 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3702 behavior on 64-bit hosts with printf arg.
3703 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3704 (x_stop_queuing_selection_requests): Likewise.
3705 (x_get_window_property): Don't truncate byte count to an 'int'
3708 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3709 here, since it parses constructs like leading '-' and spaces,
3710 which are not wanted; and it overflows with large numbers.
3711 Instead, simply match F[0-9]+, which is what is wanted anyway.
3713 * alloc.c: Remove unportable assumptions about struct layout.
3714 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3715 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3716 (allocate_vectorlike, make_pure_vector): Use the new macros,
3717 plus offsetof, to remove unportable assumptions about struct layout.
3718 These assumptions hold on all porting targets that I know of, but
3719 they are not guaranteed, they're easy to remove, and removing them
3720 makes further changes easier.
3722 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3723 This doesn't fix a bug but makes the code clearer.
3724 (string_overrun_cookie): Now const. Use initializers that
3725 don't formally overflow signed char, to avoid warnings.
3726 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3727 can cause Emacs to crash when string overrun checking is enabled.
3728 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3729 multiple of sizeof (EMACS_INT); it need not be, if
3730 alignof(EMACS_INT) < sizeof (EMACS_INT).
3731 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3733 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3735 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3737 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3739 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3740 supposed to be handshaking. (Bug#8556)
3741 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3743 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3745 * lisp.h (Qdebug): List symbol.
3746 * eval.c (Qdebug): Restore global linkage.
3747 * keyboard.c (debug-on-event): New variable.
3748 (handle_user_signal): Break into debugger when debug-on-event
3749 matches the current signal symbol.
3751 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3753 * alloc.c (check_sblock, check_string_bytes)
3754 (check_string_free_list): Convert to standard C.
3756 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3758 * w32.c (emacs_gnutls_push): Fix typo.
3760 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3762 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3763 "cast to pointer from integer of different size".
3765 Improve doprnt and its use in verror. (Bug#8545)
3766 * doprnt.c (doprnt): Document the set of format control sequences
3767 supported by the function. Use SAFE_ALLOCA instead of always
3770 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3771 is one byte too soon. Don't use xrealloc; instead xfree and
3774 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3776 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3779 * gnutls.c: Renamed global_initialized to
3780 gnutls_global_initialized. Added internals for the
3781 :verify-hostname-error, :verify-error, and :verify-flags
3782 parameters of `gnutls-boot' and documented those parameters in the
3783 docstring. Start callback support.
3784 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3785 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3786 on error. Return error code.
3787 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3788 (emacs_gnutls_read): Likewise.
3789 (Fgnutls_boot): Return handshake error code.
3790 (emacs_gnutls_handle_error): New function.
3791 (wsaerror_to_errno): Likewise.
3793 * w32.h (emacs_gnutls_pull): Add prototype.
3794 (emacs_gnutls_push): Likewise.
3796 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3797 (emacs_gnutls_push): Likewise.
3799 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3801 * process.c (wait_reading_process_output): Check if GnuTLS
3802 buffered some data internally if no FDs are set for TLS
3805 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3806 (LIBS): Link to USER_LIBS.
3807 ($(BLD)/gnutls.$(0)): New target.
3809 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3811 * xdisp.c (handle_single_display_spec): Rename the
3812 display_replaced_before_p argument into display_replaced_p, to
3813 make it consistent with the commentary. Fix typos in the
3816 * textprop.c (syms_of_textprop): Remove dead code.
3817 (copy_text_properties): Delete obsolete commentary about an
3818 interface that was deleted long ago. Fix typos in the description
3821 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3822 to changes in oldXMenu/XMenu.h from 2011-04-16.
3823 <menu_help_message, prev_menu_help_message>: Constify.
3824 (IT_menu_make_room): menu->help_text is now `const char **';
3827 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3828 to changes in oldXMenu/XMenu.h from 2011-04-16.
3829 (struct XMenu): Declare `help_text' `const char **'.
3831 * xfaces.c <Qunspecified>: Make extern again.
3833 * syntax.c: Include sys/types.h before including regex.h, as
3836 * doc.c (get_doc_string): Improve the format passed to `error'.
3838 * doprnt.c (doprnt): Improve commentary.
3840 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3842 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3845 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3846 changes in globals.h immediately force recompilation.
3847 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3848 $(CURDIR)/s/ms-w32.h.
3849 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3851 * character.c (Fchar_direction): Function deleted.
3852 (syms_of_character): Don't defsubr it.
3853 <char-direction-table>: Deleted.
3855 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3857 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3858 * doprnt.c: Include limits.h.
3859 (SIZE_MAX): New macro.
3860 (doprnt): Return a size_t value. 2nd arg is now size_t.
3861 Many local variables are now size_t instead of int or unsigned.
3862 Improve overflow protection. Support `l' modifier for integer
3863 conversions. Support %l conversion. Don't assume an EMACS_INT
3864 argument for integer conversions and for %c.
3866 * lisp.h (doprnt): Restore prototype.
3868 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3871 * Makefile.in (base_obj): Add back doprnt.o.
3873 * deps.mk (doprnt.o): Add back prerequisites.
3874 (callint.o): Depend on character.h.
3876 * eval.c (internal_lisp_condition_case): Include the handler
3877 representation in the error message.
3878 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3879 when breaking from the loop.
3881 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3883 * callint.c (Fcall_interactively): When displaying error message
3884 about invalid control letter, pass the character's codepoint, not
3885 a pointer to its multibyte form. Improve display of the character
3886 in octal and display also its hex code.
3888 * character.c (char_string): Use %x to display the (unsigned)
3889 codepoint of an invalid character, to avoid displaying a bogus
3892 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3893 `error', not SYMBOL_NAME itself.
3895 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3896 character arguments to `error'.
3898 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3899 to `error' in error message about FINAL_CHAR argument. Make sure
3900 FINAL_CHAR is a character, and use %c when it is passed as
3901 argument to `error'.
3903 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3905 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3907 * w32.c: Include <time.h>.
3908 (sys_localtime): New function.
3910 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
3912 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3914 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
3916 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
3918 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3921 2011-04-19 Eli Zaretskii <eliz@gnu.org>
3923 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3924 gl_state.e_property when gl_state.object is Qt.
3926 * insdel.c (make_gap_larger): Remove limitation of buffer size
3929 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
3931 * xdisp.c (lookup_glyphless_char_display)
3932 (produce_glyphless_glyph): Handle cons cell entry in
3933 glyphless-char-display.
3934 (Vglyphless_char_display): Document it.
3936 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3937 glyphless-char-display.
3939 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
3941 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3943 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3945 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3946 definition for no-X builds.
3948 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
3950 Static checks with GCC 4.6.0 and non-default toolkits.
3952 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3954 * process.c (keyboard_bit_set): Define only if SIGIO.
3955 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3956 (send_process): Repair possible setjmp clobbering.
3958 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3960 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3962 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3964 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3965 Define only if needed.
3967 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3968 by pacifying GCC about it. Maybe it's time to retire it?
3969 * xfaces.c (USG, __TIMEVAL__): Likewise.
3971 * dispextern.h (struct redisplay_interface): Rename param
3973 * termhooks.h (struct terminal): Likewise.
3974 * xterm.c (xembed_send_message): Likewise.
3976 * insdel.c (make_gap_smaller): Define only if
3977 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3979 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3982 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3983 so that we aren't warned about unused symbols.
3985 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3987 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
3989 * xfns.c (x_real_positions): Mark locals as initialized.
3991 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3993 * xterm.c: Fix problems found by static analysis with other toolkits.
3994 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
3995 (x_dispatch_event): Declare static if USE_GTK, and
3996 define if USE_GTK || USE_X_TOOLKIT.
3997 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
3998 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
3999 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4000 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4002 * xmenu.c (menu_help_callback): Pointer type fixes.
4003 Use const pointers when pointing at readonly data. Avoid pointer
4005 (FALSE): Remove unused macro.
4006 (update_frame_menubar): Remove unused decl.
4008 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4010 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4011 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4012 (single_menu_item): Rename local to avoid shadowing.
4014 * keyboard.c (make_lispy_event): Remove unused local var.
4016 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4017 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4019 * bitmaps: Change bitmaps from unsigned char back to the X11
4020 compatible char. Avoid the old compiler warnings about
4021 out-of-range initializers by using, for example, '\xab' rather
4024 * xgselect.c (xgselect_initialize): Check vs interface
4025 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4027 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4029 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4030 to read-only memory.
4032 * fns.c (vector): Remove; this old hack is no longer needed.
4034 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4036 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4038 * xrdb.c (x_load_resources): Omit unused local.
4040 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4041 (x_window): Rename locals to avoid shadowing.
4042 (USG): Use the kludged USG macro, to pacify gcc.
4044 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4045 (x_term_init): Remove local to avoid shadowing.
4047 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4049 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4050 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4052 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4054 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4056 Fix regex.c, syntax.c and friends for buffers > 2GB.
4057 * syntax.h (struct gl_state_s): Declare character position members
4060 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4062 * textprop.c (verify_interval_modification, interval_of):
4063 Declare arguments EMACS_INT.
4065 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4068 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4070 * indent.c (Fvertical_motion): Local variable it_start is now
4073 * regex.c (re_match, re_match_2, re_match_2_internal)
4074 (bcmp_translate, regcomp, regexec, print_double_string)
4075 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4076 (re_compile_pattern, re_exec): Declare arguments and local
4077 variables `size_t' and `ssize_t' and return values `regoff_t', as
4079 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4080 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4081 <compile_stack_type>: `size' and `avail' are now `size_t'.
4083 * regex.h <regoff_t>: Use ssize_t, not int.
4084 (re_search, re_search_2, re_match, re_match_2): Arguments that
4085 specify buffer/string position and length are now ssize_t and
4086 size_t. Return type is regoff_t.
4088 2011-04-16 Ben Key <bkey76@gmail.com>
4090 * nsfont.m: Fixed bugs in ns_get_family and
4091 ns_descriptor_to_entity that were caused by using free to
4092 deallocate memory blocks that were allocated by xmalloc (via
4093 xstrdup). This caused Emacs to crash when compiled with
4094 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4095 --enable-checking=xmallocoverrun). xfree is now used to
4096 deallocate these memory blocks.
4098 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4100 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4102 emacs_write: Accept and return EMACS_INT for sizes.
4103 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4105 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4106 Accept and return EMACS_INT.
4107 (emacs_gnutls_write): Return the number of bytes written on
4109 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4110 (emacs_read, emacs_write): Remove check for negative size, as the
4111 Emacs source code has been audited now.
4112 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4113 (emacs_read, emacs_write): Use it.
4114 * process.c (send_process): Adjust to the new signatures of
4115 emacs_write and emacs_gnutls_write. Do not attempt to store
4116 a byte offset into an 'int'; it might overflow.
4117 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4119 * sound.c: Don't assume sizes fit in 'int'.
4120 (struct sound_device.period_size, alsa_period_size):
4121 Return EMACS_INT, not int.
4122 (struct sound_device.write, vox_write, alsa_write):
4123 Accept EMACS_INT, not int.
4124 (wav_play, au_play): Use EMACS_INT to store sizes and to
4125 record read return values.
4127 2011-04-15 Ben Key <bkey76@gmail.com>
4129 * keyboard.c (Qundefined): Don't declare static since it is used
4131 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4132 static since they are used in nsfont.m.
4134 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4136 * process.c (Qprocessp): Don't declare static.
4137 * lisp.h (Qprocessp): Declare again.
4139 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4141 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4143 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4145 Improve C-level modularity by making more things 'static'.
4147 Don't publish debugger-only interfaces to other modules.
4148 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4149 (verify_bytepos, count_markers): Move decls to the only modules
4151 * region-cache.h (pp_cache): Likewise.
4152 * window.h (check_all_windows): Likewise.
4153 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4155 * sysdep.c (croak): Now static, if
4156 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4157 * syssignal.h (croak): Declare only if not static.
4159 * alloc.c (refill_memory_reserve): Now static if
4160 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4161 * lisp.h (refill_memory_reserve): Declare only if not static.
4163 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4164 Define only if USE_LUCID.
4166 * xrdb.c (x_customization_string, x_rm_string): Now static.
4168 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4169 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4171 * xdisp.c (draw_row_with_mouse_face): Now static.
4172 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4174 * window.h (check_all_windows): Mark externally visible.
4176 * window.c (window_deletion_count): Now static.
4178 * undo.c: Make symbols static if they're not exported.
4179 (last_undo_buffer, last_boundary_position, pending_boundary):
4182 * textprop.c (interval_insert_behind_hooks): Now static.
4183 (interval_insert_in_front_hooks): Likewise.
4185 * term.c: Make symbols static if they're not exported.
4186 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4187 (max_frame_lines, tty_set_terminal_modes):
4188 (tty_reset_terminal_modes, tty_turn_off_highlight):
4189 (get_tty_terminal): Now static.
4190 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4191 * termhooks.h (term_mouse_moveto): Do not declare if
4193 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4194 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4196 * sysdep.c: Make symbols static if they're not exported.
4197 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4199 (sigprocmask_set, full_mask): Remove; unused.
4200 (wait_debugging): Mark as visible.
4201 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4202 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4204 * syntax.c (syntax_temp): Define only if !__GNUC__.
4206 * sound.c (current_sound_device, current_sound): Now static.
4208 * search.c (searchbufs, searchbuf_head): Now static.
4210 * scroll.c (scroll_cost): Remove; unused.
4211 * dispextern.h (scroll_cost): Remove decl.
4213 * region-cache.h (pp_cache): Mark as externally visible.
4215 * process.c: Make symbols static if they're not exported.
4216 (process_tick, update_tick, create_process, chan_process):
4217 (Vprocess_alist, proc_buffered_char, datagram_access):
4218 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4219 (deactivate_process): Mark defn as static, as well as decl.
4220 * lisp.h (create_process): Remove decl.
4221 * process.h (chan_process, Vprocess_alist): Remove decls.
4223 * print.c: Make symbols static if they're not exported.
4224 (print_depth, new_backquote_output, being_printed, print_buffer):
4225 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4226 (print_interval, print_number_index, initial_stderr_stream):
4228 * lisp.h (Fprinc): Remove decl.
4229 (debug_output_compilation_hack): Mark as externally visible.
4231 * sysdep.c (croak): Move decl from here to syssignal.h.
4232 * syssignal.h (croak): Put it here, so the API can be checked when
4233 'croak' is called from dissociate_if_controlling_tty.
4235 * minibuf.c: Make symbols static if they're not exported.
4236 (minibuf_save_list, choose_minibuf_frame): Now static.
4237 * lisp.h (choose_minibuf_frame): Remove decl.
4239 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4241 * lread.c: Make symbols static if they're not exported.
4242 (read_objects, initial_obarray, oblookup_last_bucket_number):
4244 (make_symbol): Remove; unused.
4245 * lisp.h (initial_obarray, make_symbol): Remove decls.
4247 * keyboard.c: Make symbols static if they're not exported.
4248 (single_kboard, recent_keys_index, total_keys, recent_keys):
4249 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4250 (this_single_command_key_start, echoing, last_auto_save):
4251 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4252 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4253 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4254 (Vlispy_mouse_stem, double_click_count):
4256 (force_auto_save_soon): Define only if SIGDANGER.
4257 (ignore_mouse_drag_p): Now static if
4258 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4259 (print_help): Remove; unused.
4260 (stop_character, last_timer_event): Mark as externally visible.
4261 * keyboard.h (ignore_mouse_drag_p): Declare only if
4262 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4263 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4264 * lisp.h (echoing): Remove decl.
4265 (force_auto_save_soon): Declare only if SIGDANGER.
4266 * xdisp.c (redisplay_window): Simplify code, to make it more
4267 obvious that ignore_mouse_drag_p is not accessed if !defined
4268 USE_GTK && !defined HAVE_NS.
4270 * intervals.c: Make symbols static if they're not exported.
4271 (merge_properties_sticky, merge_interval_right, delete_interval):
4273 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4275 * insdel.c: Make symbols static if they're not exported.
4276 However, leave prepare_to_modify_buffer alone. It's never
4277 called from outside this function, but that appears to be a bug.
4278 (combine_after_change_list, combine_after_change_buffer):
4279 (adjust_after_replace, signal_before_change): Now static.
4280 (adjust_after_replace_noundo): Remove; unused.
4281 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4282 (signal_before_change): Remove decls.
4284 * indent.c (val_compute_motion, val_vmotion): Now static.
4286 * image.c: Make symbols static if they're not exported.
4287 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4289 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4290 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4292 * fringe.c (standard_bitmaps): Now static.
4293 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4295 * frame.c: Make symbols static if they're not exported.
4296 (x_report_frame_params, make_terminal_frame): Now static.
4297 (get_frame_param): Now static, unless HAVE_NS.
4298 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4299 (x_get_resource_string): Remove; not used.
4300 * frame.h (make_terminal_frame, x_report_frame_params):
4301 (x_get_resource_string); Remove decls.
4302 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4303 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4305 * font.c, fontset.c: Make symbols static if they're not exported.
4306 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4307 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4308 * font.c (font_close_object): Now static.
4309 * font.h (font_close_object): Remove.
4310 * fontset.c (FONTSET_OBJLIST): Remove.
4311 (free_realized_fontset) #if-0 the body, which does nothing.
4312 (face_suitable_for_char_p): #if-0, as it's never called.
4313 * fontset.h (face_suitable_for_char_p): Remove decl.
4314 * xfaces.c (face_at_string_position):
4315 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4316 since 0 is always ASCII.
4318 * fns.c (weak_hash_tables): Now static.
4320 * fileio.c: Make symbols static if they're not exported.
4321 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4322 (Vwrite_region_annotation_buffers): Now static.
4324 * eval.c: Make symbols static if they're not exported.
4325 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4326 * lisp.h (backtrace_list): Remove decl.
4328 * emacs.c: Make symbols static if they're not exported.
4329 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4330 (fatal_error_code, fatal_error_signal_hook, standard_args):
4332 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4333 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4334 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4335 * lisp.h (fatal_error_signal_hook): Remove decl.
4336 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4338 * editfns.c: Move a (normally-unused) function to its only use.
4339 * editfns.c, lisp.h (get_operating_system_release): Remove.
4340 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4341 worth the hassle of breaking this out.
4343 * xterm.c: Make symbols static if they're not exported.
4344 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4345 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4346 (x_destroy_window, x_delete_display):
4348 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4349 (x_mouse_leave): Remove; unused.
4350 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4351 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4352 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4354 (x_mouse_leave): Declare only if WINDOWSNT.
4355 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4356 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4359 * ftxfont.c: Make symbols static if they're not exported.
4360 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4362 * font.h (ftxfont_driver): Likewise.
4364 * xfns.c: Make symbols static if they're not exported.
4365 (x_last_font_name, x_display_info_for_name):
4366 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4367 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4368 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4369 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4370 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4371 (last_show_tip_args): Now static.
4372 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4373 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4374 (x_screen_planes): Remove; unused.
4375 * dispextern.h (x_screen_planes): Remove decl.
4377 * dispnew.c: Make symbols static if they're not exported.
4378 * dispextern.h (redraw_garbaged_frames, scrolling):
4379 (increment_row_positions): Remove.
4380 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4381 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4383 (redraw_garbaged_frames): Remove; unused.
4385 * xfaces.c: Make symbols static if they're not exported.
4386 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4388 * xterm.h (defined_color): Remove decls.
4389 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4390 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4391 (menu_face_changed_default, defined_color, free_realized_face):
4392 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4393 (ascii_face_of_lisp_face): Remove; unused.
4395 * xdisp.c: Make symbols static if they're not exported.
4396 * dispextern.h (scratch_glyph_row, window_box_edges):
4397 (glyph_to_pixel_coords, set_cursor_from_row):
4398 (get_next_display_element, set_iterator_to_next):
4399 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4400 (show_mouse_face): Remove decls
4401 * frame.h (message_buf_print): Likewise.
4402 * lisp.h (pop_message, set_message, check_point_in_composition):
4404 * xterm.h (set_vertical_scroll_bar): Likewise.
4405 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4406 (message_buf_print, scratch_glyph_row, displayed_buffer):
4407 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4408 (get_next_display_element, show_mouse_face, window_box_edges):
4409 (frame_to_window_pixel_xy, check_point_in_composition):
4410 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4411 (glyph_to_pixel_coords): Remove; unused.
4413 * dired.c (file_name_completion): Now static.
4415 * dbusbind.c (xd_in_read_queued_messages): Now static.
4417 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4418 * data.c (circular_list_error): Remove.
4420 * commands.h (last_point_position, last_point_position_buffer):
4421 (last_point_position_window): Remove decls.
4422 * keyboard.c: Make these variables static.
4424 * coding.h (coding, code_convert_region, encode_coding_gap):
4426 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4427 (iso_code_class, detect_coding, code_convert_region): Now static.
4428 (encode_coding_gap): Remove; unused.
4430 * chartab.c (chartab_chars, chartab_bits): Now static.
4432 * charset.h (charset_iso_8859_1): Remove decl.
4433 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4436 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4437 * ccl.c (Vccl_program_table): Now static.
4438 (check_ccl_update): Remove; unused.
4440 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4441 * category.h: ... from here.
4442 * category.c (check_category_table, set_category_set): Now static.
4444 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4445 * lisp.h: Remove these decls.
4447 * buffer.c (buffer_count): Remove unused var.
4449 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4450 so that it's not optimized away.
4451 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4452 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4453 exported only to the debugger.
4455 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4456 * atimer.h (run_all_atimers): Remove; not exported.
4458 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4459 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4460 was inaccessible from Lisp.
4461 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4462 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4464 alloc.c: Import and export fewer symbols, and remove unused items.
4465 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4467 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4468 it's not optimized away by whole-program optimization.
4469 (message_enable_multibyte, free_misc): Remove.
4470 (catchlist, handlerlist, mark_backtrace):
4471 Declare only if BYTE_MARK_STACK.
4472 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4473 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4474 (message_enable_multibyte): Remove decl.
4475 (free_misc, interval_free_list, float_block, float_block_index):
4476 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4477 (cons_free_list, last_marked_index):
4479 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4480 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4481 (mark_backtrace): Define only if BYTE_MARK_STACK.
4482 * xdisp.c (message_enable_multibyte): Now static.
4484 Declare Lisp_Object Q* variables to be 'static' if not exported.
4485 This makes it easier for human readers (and static analyzers)
4486 to see whether these variables are used from other modules.
4487 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4488 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4489 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4490 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4491 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4492 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4493 * xmenu.c, xselect.c:
4494 Declare Q* vars static if they are not used in other modules.
4495 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4496 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4497 Remove decls of unexported vars.
4498 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4500 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4502 Make Emacs functions such as Fatom 'static' by default.
4503 This makes it easier for human readers (and static analyzers)
4504 to see whether these functions can be called from other modules.
4505 DEFUN now defines a static function. To make the function external
4506 so that it can be used in other C modules, use the new macro DEFUE.
4507 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4508 (Finit_image_library):
4509 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4510 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4511 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4512 Remove decls, since these functions are now static.
4513 (Funintern, Fget_internal_run_time): New decls, since these functions
4514 were already external.
4516 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4517 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4518 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4519 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4520 * keyboard.c, keymap.c, lread.c:
4521 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4522 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4523 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4524 Mark functions with DEFUE instead of DEFUN,
4525 if they are used in other modules.
4526 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4527 decls for now-static functions.
4528 * buffer.h (Fdelete_overlay): Remove decl.
4529 * callproc.c (Fgetenv_internal): Mark as internal.
4530 * composite.c (Fremove_list_of_text_properties): Remove decl.
4531 (Fcomposition_get_gstring): New forward static decl.
4532 * composite.h (Fcomposite_get_gstring): Remove decl.
4533 * dired.c (Ffile_attributes): New forward static decl.
4534 * doc.c (Fdocumntation_property): New forward static decl.
4535 * eval.c (Ffetch_bytecode): New forward static decl.
4536 (Funintern): Remove extern decl; now in .h file where it belongs.
4537 * fileio.c (Fmake_symbolic_link): New forward static decl.
4538 * image.c (Finit_image_library): New forward static decl.
4539 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4540 * intervals.h (Fprevious_property_change):
4541 (Fremove_list_of_text_properties): Remove decls.
4542 * keyboard.c (Fthis_command_keys): Remove decl.
4543 (Fcommand_execute): New forward static decl.
4544 * keymap.c (Flookup_key): New forward static decl.
4545 (Fcopy_keymap): Now static.
4546 * keymap.h (Flookup_key): Remove decl.
4547 * process.c (Fget_process): New forward static decl.
4548 (Fprocess_datagram_address): Mark as internal.
4549 * syntax.c (Fsyntax_table_p): New forward static decl.
4550 (skip_chars): Remove duplicate decl.
4551 * textprop.c (Fprevious_property_change): New forward static decl.
4552 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4554 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4555 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4557 * editfns.c (Fformat): Remove unreachable code.
4559 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4561 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4564 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4566 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4567 when at ZV. (Bug#8487)
4569 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4571 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4573 * keyboard.c (parse_tool_bar_item): Likewise.
4574 * sound.c (sound_cleanup, alsa_close): Likewise.
4575 * termcap.c (tgetent): Likewise.
4576 * xfns.c (x_default_font_parameter): Likewise.
4577 * xsettings.c (read_and_apply_settings): Likewise.
4579 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4580 (overrun_check_free): Protoize.
4582 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4584 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4585 since callers should never pass a negative size.
4586 Change the signature to match that of plain 'read' and 'write'; see
4587 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4588 * lisp.h: Update prototypes of emacs_write and emacs_read.
4590 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4592 * xdisp.c (redisplay_window): Don't try to determine the character
4593 position of the scroll margin if the window start point w->startp
4594 is outside the buffer's accessible region. (Bug#8468)
4596 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4598 Fix write-region and its subroutines for buffers > 2GB.
4599 * fileio.c (a_write, e_write): Modify declaration of arguments and
4600 local variables to support buffers larger than 2GB.
4601 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4603 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4604 argument, local variables, and return value.
4606 * lisp.h: Update prototypes of emacs_write and emacs_read.
4608 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4610 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4612 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4614 Fix more problems found by GCC 4.6.0's static checks.
4616 * xdisp.c (vmessage): Use a better test for character truncation.
4618 * charset.c (load_charset_map): <, not <=, for optimization,
4619 and to avoid potential problems with integer overflow.
4620 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4621 * casetab.c (set_identity, shuffle): Likewise.
4622 * editfns.c (Fformat): Likewise.
4623 * syntax.c (skip_chars): Likewise.
4625 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4626 This also lets GCC 4.6.0 generate slightly better loop code.
4628 * callint.c (Fcall_interactively): <, not <=, for optimization.
4629 (Fcall_interactively): Count the number of arguments produced,
4630 not the number of arguments given. This is simpler and lets GCC
4631 4.6.0 generate slightly better code.
4633 * ftfont.c: Distingish more carefully between FcChar8 and char.
4634 The previous code passed unsigned char * to a functions like
4635 strlen and xstrcasecmp that expect char *, which does not
4636 conform to the C standard.
4637 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4638 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4639 char * when the C standard requires it.
4641 * keyboard.c (read_char): Remove unused var.
4643 * eval.c: Port to Windows vsnprintf (Bug#8435).
4645 (SIZE_MAX): Define if the headers do not.
4646 (verror): Do not give up if vsnprintf returns a negative count.
4647 Instead, grow the buffer. This ports to Windows vsnprintf, which
4648 does not conform to C99. Problem reported by Eli Zaretskii.
4649 Also, simplify the allocation scheme, by avoiding the need for
4650 calling realloc, and removing the ALLOCATED variable.
4652 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4654 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4655 But keep the doprint source code for now, as we might revamp it
4656 and use it again (Bug#8435).
4657 * lisp.h (doprnt): Remove.
4658 * Makefile.in (base_obj): Remove doprnt.o.
4659 * deps.mk (doprnt.o): Remove.
4661 error: Print 32- and 64-bit integers portably (Bug#8435).
4662 Without this change, on typical 64-bit hosts error ("...%d...", N)
4663 was used to print both 32- and 64-bit integers N, which relied on
4665 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4667 * lisp.h (error, verror): Mark as printf-like functions.
4668 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4669 Report overflow in size calculations when allocating printf buffer.
4670 Do not truncate output string at its first null byte.
4671 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4672 Truncate the output at a character boundary, since vsnprintf does not
4674 * charset.c (check_iso_charset_parameter): Convert internal
4675 character to string before calling 'error', since %c now has the
4677 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4678 overflow when computing char to be passed to 'error'. Do not
4679 pass Lisp_Object to 'error'; pass the integer instead.
4680 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4681 formatted with plain %d.
4683 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4685 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4687 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4689 * xterm.c (x_catch_errors): Remove duplicate declaration.
4691 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4693 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4695 2011-04-10 Jim Meyering <meyering@redhat.com>
4697 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4698 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4699 return ssize_t not "int", and use size_t as the buffer length.
4700 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4701 * gnutls.h: Update declarations.
4702 * process.c (read_process_output): Use ssize_t, to match.
4703 (send_process): Likewise.
4705 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4707 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4709 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4711 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4712 Use unsigned char, to match FcChar8 type definition.
4714 * xterm.c (handle_one_xevent):
4715 * xmenu.c (create_and_show_popup_menu):
4716 * xselect.c (x_decline_selection_request)
4717 (x_reply_selection_request): Avoid type-punned deref of X events.
4719 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4721 Fix some uses of `int' instead of EMACS_INT.
4722 * search.c (string_match_1, fast_string_match)
4723 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4724 (scan_buffer, find_next_newline_no_quit)
4725 (find_before_next_newline, search_command, Freplace_match)
4726 (Fmatch_data): Make some `int' variables be EMACS_INT.
4728 * xdisp.c (display_count_lines): 3rd argument and return value now
4729 EMACS_INT. All callers changed.
4730 (pint2hrstr): Last argument is now EMACS_INT.
4732 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4733 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4734 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4735 (decode_coding_utf_16, decode_coding_emacs_mule)
4736 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4737 (decode_coding_ccl, decode_coding_charset)
4738 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4739 (decode_coding_iso_2022, decode_coding_emacs_mule)
4740 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4741 <char_offset, last_offset>: Declare EMACS_INT.
4742 (encode_coding_utf_8, encode_coding_utf_16)
4743 (encode_coding_emacs_mule, encode_invocation_designation)
4744 (encode_designation_at_bol, encode_coding_iso_2022)
4745 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4746 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4748 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4749 (encode_invocation_designation): Last argument P_NCHARS is now
4751 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4752 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4754 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4757 * ccl.c (Fccl_execute_on_string): Declare some variables
4760 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4762 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4764 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4766 * process.c (Fformat_network_address): Doc fix.
4768 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4770 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4772 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4774 * keyboard.c (read_char): Call Lisp function help-form-show,
4775 instead of using internal_with_output_to_temp_buffer.
4776 (Qhelp_form_show): New var.
4777 (syms_of_keyboard): Use DEFSYM macro.
4779 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4781 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4783 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4785 * process.c (Flist_processes): Remove to Lisp.
4786 (list_processes_1): Delete.
4788 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4790 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4792 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4794 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4796 Fix more problems found by GCC 4.6.0's static checks.
4798 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4800 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4802 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4804 * xdisp.c (vmessage): Mark as a printf-like function.
4806 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4808 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4810 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4811 printf-like functions.
4812 (tiff_load): Add casts to remove these marks before passing them
4813 to system-supplied API.
4815 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4817 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4818 This avoids several warnings with gcc -Wstrict-overflow.
4819 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4820 directly, rather than having caller test rule sign. This avoids
4821 some unnecessary tests.
4822 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4823 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4824 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4826 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4827 (xfont_open): Avoid unnecessary tests.
4829 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4831 * composite.h, composite.c (composition_gstring_put_cache):
4832 Use EMACS_INT, not int, for length.
4834 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4835 breaking out part of COMPOSITION_DECODE_RULE.
4836 (COMPOSITION_DECODE_RULE): Use it.
4837 * composite.c (get_composition_id): Remove unused local vars,
4838 by using the new macro.
4840 * textprop.c (set_text_properties_1): Change while to do-while,
4841 since the condition is always true at first.
4843 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4844 (interval_deletion_adjustment): Return unsigned value.
4847 * process.c (list_processes_1, create_pty, read_process_output):
4848 (exec_sentinel): Remove vars that were set but not used.
4849 (create_pty): Remove unnecessary "volatile"s.
4850 (Fnetwork_interface_info): Avoid possibility of int overflow.
4851 (read_process_output): Do adaptive read buffering even if carryover.
4852 (read_process_output): Simplify nbytes computation if buffered.
4854 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4856 * syntax.c (scan_words): Remove var that was set but not used.
4857 (update_syntax_table): Use unsigned instead of int.
4859 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4860 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4861 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4863 * print.c (print_error_message): Avoid int overflow.
4865 * font.c (font_list_entities): Redo for clarity,
4866 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4868 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
4869 (font_score): Avoid potential overflow in diff calculation.
4871 * fns.c (substring_both): Remove var that is set but not used.
4872 (sxhash): Redo loop for clarity and to avoid wraparound warning.
4874 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4876 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4877 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4878 can always succeed if overflow has undefined behavior.
4880 * search.c (boyer_moore, wordify): Remove vars set but not used.
4881 (wordify): Omit three unnecessary tests.
4883 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4884 All callers changed. This avoids the need for an unused var.
4886 * casefiddle.c (casify_region): Remove var that is set but not used.
4888 * dired.c (file_name_completion): Remove var that is set but not used.
4890 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4892 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
4893 (Finsert_file_contents): Remove unnecessary code checking fd.
4895 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4896 Check for integer overflow on size calculations.
4898 * buffer.c (Fprevious_overlay_change): Remove var that is set
4901 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4902 Remove vars that are set but not used.
4903 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
4904 (timer_check_2): Mark vars as initialized.
4906 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4908 * image.c (lookup_image): Remove var that is set but not used.
4909 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
4911 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4912 that are set but not used.
4914 * xfns.c (make_invisible_cursor): Don't return garbage
4915 if XCreateBitmapFromData fails (Bug#8410).
4917 * xselect.c (x_get_local_selection, x_handle_property_notify):
4918 Remove vars that are set but not used.
4920 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
4921 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
4923 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4924 Remove var that is set but not used.
4925 (scroll_bar_windows_size): Now size_t, not int.
4926 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4929 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4930 (map_tty_color) [!defined MSDOS]: Likewise.
4932 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4934 * coding.c: Remove vars that are set but not used.
4935 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4936 All callers changed.
4937 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4938 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4939 (decode_coding_charset): Remove vars that are set but not used.
4941 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4942 that is set but not used.
4944 * print.c (print_object): Remove var that is set but not used.
4946 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
4947 The gnulib version avoids calling malloc in the usual case,
4948 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4949 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4950 * filelock.c (current_lock_owner): Likewise.
4951 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4952 * sysdep.c: Include allocator.h, careadlinkat.h.
4953 (emacs_no_realloc_allocator): New static constant.
4954 (emacs_readlink): New function.
4955 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4956 ../lib/careadlinkat.h.
4958 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4960 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4961 first non-nil return value).
4963 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4965 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4966 if not defined (Bug#8403).
4968 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4970 * xdisp.c (display_count_lines): Remove parameter `start',
4971 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4972 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4973 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4974 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4975 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4976 and thereabouts. All callers changed.
4977 (get_per_char_metric): Remove parameter `f', unused since
4978 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4980 2011-04-02 Jim Meyering <meyering@redhat.com>
4982 do not dereference NULL upon failed strdup
4983 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4984 (ns_get_family): Likewise.
4986 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4988 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4990 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4992 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4995 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4997 Add lexical binding.
4999 * window.c (Ftemp_output_buffer_show): New fun.
5000 (Fsave_window_excursion):
5001 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5003 * lread.c (lisp_file_lexically_bound_p): New function.
5004 (Fload): Bind Qlexical_binding.
5005 (readevalloop): Remove `evalfun' arg.
5006 Bind Qinternal_interpreter_environment.
5007 (Feval_buffer): Bind Qlexical_binding.
5008 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5010 (syms_of_lread): Declare `lexical-binding'.
5012 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5014 * keyboard.c (eval_dyn): New fun.
5015 (menu_item_eval_property): Use it.
5017 * image.c (parse_image_spec): Use Ffunctionp.
5019 * fns.c (concat, mapcar1): Accept byte-code-functions.
5021 * eval.c (Fsetq): Handle lexical vars.
5022 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5023 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5024 (FletX, Flet): Obey lexical binding.
5025 (Fcommandp): Handle closures.
5026 (Feval): New `lexical' arg.
5027 (eval_sub): New function extracted from Feval. Use it almost
5028 everywhere where Feval was used. Look up vars in lexical env.
5030 (Ffunctionp): Move from subr.el.
5031 (Ffuncall): Handle closures.
5032 (apply_lambda): Remove `eval_flags'.
5033 (funcall_lambda): Handle closures and new byte-code-functions.
5034 (Fspecial_variable_p): New function.
5035 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5036 but without exporting it to Lisp.
5038 * doc.c (Fdocumentation, store_function_docstring):
5039 * data.c (Finteractive_form): Handle closures.
5041 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5044 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5046 (exec_byte_code): New function extracted from Fbyte_code to handle new
5047 calling convention for byte-code-functions. Add new byte-codes.
5049 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5051 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5053 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5055 * xdisp.c (redisplay_internal): Fix prototype.
5057 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5059 * xdisp.c (SCROLL_LIMIT): New macro.
5060 (try_scrolling): Use it when setting scroll_limit.
5061 Limit scrolling to 100 screen lines.
5062 (redisplay_window): Even when falling back on "recentering",
5063 position point in the window according to scroll-conservatively,
5064 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5066 (try_scrolling): When point is above the window, allow searching
5067 as far as scroll_max, or one screenful, to compute vertical
5068 distance from PT to the scroll margin position. This prevents
5069 try_scrolling from unnecessarily failing when
5070 scroll-conservatively is set to a value slightly larger than the
5071 window height. Clean up the case of PT below the margin at bottom
5072 of window: scroll_max can no longer be INT_MAX. When aggressive
5073 scrolling is in use, don't let point enter the opposite scroll
5074 margin as result of the scroll.
5075 (syms_of_xdisp) <scroll-conservatively>: Document the
5076 threshold of 100 lines for never-recentering scrolling.
5078 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5080 * dispextern.h (move_it_by_lines):
5081 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5082 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5083 (message_log_check_duplicate): Remove parameters `prev_bol' and
5084 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5085 (redisplay_internal): Remove parameter `preserve_echo_area',
5086 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5088 * indent.c (Fvertical_motion):
5089 * window.c (window_scroll_pixel_based, Frecenter):
5090 Don't pass `need_y_p' to `move_it_by_lines'.
5092 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5094 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5095 steal a few bits to be more compact.
5096 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5097 Remove unneeded casts.
5099 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5101 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5103 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5104 binding" message (bug#7967).
5106 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5108 Fix more problems found by GCC 4.6.0's static checks.
5110 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5111 Remove unused local var.
5113 * editfns.c (Fmessage_box): Remove unused local var.
5115 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5116 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5117 Omit unused local vars.
5118 * window.c (shrink_windows): Omit unused local var.
5119 * menu.c (digest_single_submenu): Omit unused local var.
5120 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5121 Omit unused local var.
5123 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5124 Don't assume string length fits in int.
5125 (keyremap_step, read_key_sequence): Use size_t for sizes.
5126 (read_key_sequence): Don't check last_real_key_start redundantly.
5128 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5129 instead of alloca (Bug#8344).
5131 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5132 (Fbacktrace_frame): Don't assume nframes fits in int.
5134 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5136 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5139 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5141 * cm.c (calccost): Turn while-do into do-while, for clarity.
5143 * keyboard.c (syms_of_keyboard): Use the same style as later
5144 in this function when indexing through an array. This also
5145 works around GCC bug 48267.
5147 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5149 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5151 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5152 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5154 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5155 This avoids undefined behavior on integer overflow, and is a bit
5156 more convenient anyway since it is compared to a size_t variable.
5158 Variadic C functions now count arguments with size_t, not int.
5159 This avoids an unnecessary limitation on 64-bit machines, which
5160 caused (substring ...) to crash on large vectors (Bug#8344).
5161 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5162 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5163 All variadic functions and their callers changed accordingly.
5164 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5165 * data.c (arith_driver, float_arith_driver): Likewise.
5166 * editfns.c (general_insert_function): Likewise.
5167 * eval.c (struct backtrace.nargs, interactive_p)
5168 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5169 (funcall_lambda, mark_backtrace): Likewise.
5170 * fns.c (concat): Likewise.
5171 * frame.c (x_set_frame_parameters): Likewise.
5172 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5173 0 if not found, not -1. All callers changed.
5175 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5176 (stack_copy_size): Now size_t, not int.
5177 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5179 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5181 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5182 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5183 All callers changed.
5185 * lisp.h (multibyte_char_to_unibyte):
5186 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5187 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5188 * character.h (CHAR_TO_BYTE8):
5189 * cmds.c (internal_self_insert):
5190 * editfns.c (general_insert_function):
5191 * keymap.c (push_key_description):
5192 * search.c (Freplace_match):
5193 * xdisp.c (message_dolog, set_message_1): All callers changed.
5195 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5197 * keyboard.c (safe_run_hook_funcall): New function.
5198 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5199 don't set the hook to nil, but remove the offending function instead.
5200 (Qcommand_hook_internal): Remove, unused.
5201 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5202 Vcommand_hook_internal.
5204 * eval.c (enum run_hooks_condition): Remove.
5205 (funcall_nil, funcall_not): New functions.
5206 (run_hook_with_args): Call each function through a `funcall' argument.
5207 Remove `cond' argument, now redundant.
5208 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5209 (Frun_hook_with_args_until_failure): Adjust accordingly.
5210 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5212 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5214 * dispextern.h (string_buffer_position): Remove declaration.
5216 * print.c (strout): Remove parameter `multibyte', unused since
5217 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5219 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5220 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5221 All callers changed.
5223 * w32.c (_wsa_errlist): Use braces for struct initializers.
5225 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5226 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5227 All callers changed.
5228 (string_buffer_position): Likewise. Also, make static (it's never
5229 used outside xdisp.c).
5230 (cursor_row_p): Remove parameter `w', unused since
5231 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5232 (decode_mode_spec): Remove parameter `precision', introduced during
5233 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5234 All callers changed.
5236 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5238 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5240 2011-03-27 Anders Lindgren <andlind@gmail.com>
5242 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5243 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5244 (ns_update_auto_hide_menu_bar): New functions.
5245 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5246 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5247 ns_constrain_all_frames.
5248 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5249 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5251 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5253 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5255 2011-03-27 Glenn Morris <rgm@gnu.org>
5257 * syssignal.h: Replace RETSIGTYPE with void.
5258 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5259 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5260 Replace SIGTYPE with void everywhere.
5261 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5262 * s/template.h (SIGTYPE): Remove commented out definition.
5264 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5266 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5267 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5269 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5271 * w32.c (read_unc_volume): Use parameter `henum', instead of
5272 global variable `wget_enum_handle'.
5274 * keymap.c (describe_vector): Remove parameters `indices' and
5275 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5276 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5278 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5280 * keyboard.c (timer_check): Remove parameter `do_it_now',
5281 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5282 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5283 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5285 * keyboard.c (read_char):
5286 * w32menu.c (w32_menu_display_help):
5287 * xmenu.c (show_help_event, menu_help_callback):
5288 Adjust calls to `show_help_echo'.
5290 * gtkutil.c (xg_maybe_add_timer):
5291 * keyboard.c (readable_events):
5292 * process.c (wait_reading_process_output):
5293 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5295 * insdel.c (adjust_markers_gap_motion):
5296 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5297 (gap_left, gap_right): Don't call it.
5299 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5301 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5302 incurred during fontification.
5304 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5306 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5307 (DEFVAR_PER_BUFFER): Don't pass it.
5309 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5310 (scrolling_window): Don't pass it.
5312 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5314 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5316 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5318 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5319 of variables specific to SELinux and computation of `encoded_absname'.
5321 * image.c (XPutPixel): Remove unused variable `height'.
5323 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5325 * unexw32.c (get_section_info): Remove unused variable `section'.
5327 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5328 (system_process_attributes): Remove unused variable `sess'.
5329 (sys_read): Remove unused variable `err'.
5331 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5332 (w32_wnd_proc): Remove unused variable `isdead'.
5333 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5334 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5335 (x_create_tip_frame): Remove unused variable `tem'.
5337 * w32inevt.c (w32_console_read_socket):
5338 Remove unused variable `no_events'.
5340 * w32term.c (x_draw_composite_glyph_string_foreground):
5341 Remove unused variable `width'.
5343 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5345 * w32term.c (x_set_glyph_string_clipping):
5346 Don't pass uninitialized region to CombineRgn.
5348 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5350 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5351 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5352 (Fx_close_connection): Remove unused variable `i'.
5354 * w32font.c (w32font_draw): Return number of glyphs.
5355 (w32font_open_internal): Remove unused variable `i'.
5356 (w32font_driver): Add missing initializer.
5358 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5359 (fill_in_menu): Remove unused variable `items_added'.
5361 * w32term.c (last_mouse_press_frame): Remove static global variable.
5362 (w32_clip_to_row): Remove unused variable `f'.
5363 (x_delete_terminal): Remove unused variable `i'.
5365 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5366 (NOTHING): Remove unused static global variable.
5367 (uniscribe_check_otf): Remove unused variable `table'.
5368 (uniscribe_font_driver): Add missing initializers.
5370 2011-03-23 Julien Danjou <julien@danjou.info>
5372 * term.c (Fsuspend_tty, Fresume_tty):
5373 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5374 * window.c (temp_output_buffer_show):
5375 * insdel.c (signal_before_change):
5376 * frame.c (Fhandle_switch_frame):
5377 * fileio.c (Fdo_auto_save):
5378 * emacs.c (Fkill_emacs):
5379 * editfns.c (save_excursion_restore):
5380 * cmds.c (internal_self_insert):
5381 * callint.c (Fcall_interactively):
5382 * buffer.c (Fkill_all_local_variables):
5383 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5385 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5386 unconditionnaly since it does the check itself.
5388 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5390 Fix more problems found by GCC 4.5.2's static checks.
5392 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5393 the first time through the loop, since we know p0 < p1 then.
5394 This also avoids a gcc -Wstrict-overflow warning.
5396 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5397 leading to a memory leak, possible in functions like
5398 load_charset_map_from_file that can allocate an unbounded number
5399 of objects (Bug#8318).
5401 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5402 that could (at least in theory) be that large.
5404 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5405 This is less likely to overflow, and avoids undefined behavior if
5406 overflow does occur. All callers changed. Use strtoul to scan
5407 for the unsigned long integer.
5408 (pint2hrstr): Simplify and tune code slightly.
5409 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5411 * scroll.c (do_scrolling): Work around GCC bug 48228.
5412 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5414 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5415 This also avoids a warning with gcc -Wstrict-overflow.
5416 (validate_x_resource_name): Simplify count usage.
5417 This also avoids a warning with gcc -Wstrict-overflow.
5419 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5422 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5424 * process.c (Fmake_network_process): Use socklen_t, not int,
5425 where POSIX says socklen_t is required in portable programs.
5426 This fixes a porting bug on hosts like 64-bit HP-UX, where
5427 socklen_t is wider than int (Bug#8277).
5428 (Fmake_network_process, server_accept_connection):
5429 (wait_reading_process_output, read_process_output):
5432 * process.c: Rename or move locals to avoid shadowing.
5433 (list_processes_1, Fmake_network_process):
5434 (read_process_output_error_handler, exec_sentinel_error_handler):
5435 Rename or move locals.
5436 (Fmake_network_process): Define label "retry_connect" only if needed.
5437 (Fnetwork_interface_info): Fix pointer signedness.
5438 (process_send_signal): Add cast to avoid pointer signedness problem.
5439 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5440 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5442 Make tparam.h and terminfo.c consistent.
5443 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5444 Include tparam.h instead, since it declares them.
5445 * cm.h (PC): Remove extern decl; tparam.h now does this.
5446 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5447 * terminfo.c: Include tparam.h, to check interfaces.
5448 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5449 (tparam): Adjust signature to match interface in tparam.h;
5450 this removes some undefined behavior. Check that outstring and len
5451 are zero, which they always are with Emacs.
5452 * tparam.h (PC, BC, UP): New extern decls.
5454 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5455 (xftfont_open): Rename locals to avoid shadowing.
5457 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5458 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5459 (OTF_TAG_SYM): Omit macro if not needed.
5460 (ftfont_list): Remove unused local.
5461 (get_adstyle_property, ftfont_pattern_entity):
5462 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5463 Rename locals to avoid shadowing.
5465 * xfont.c (xfont_list_family): Mark var as initialized.
5467 * xml.c (make_dom): Now static.
5469 * composite.c (composition_compute_stop_pos): Rename local to
5471 (composition_reseat_it): Remove unused locals.
5472 (find_automatic_composition, composition_adjust_point): Likewise.
5473 (composition_update_it): Mark var as initialized.
5474 (find_automatic_composition): Mark vars as initialized,
5475 with a FIXME (Bug#8290).
5477 character.h: Rename locals to avoid shadowing.
5478 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5479 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5480 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5481 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5484 * textprop.c (property_change_between_p): Remove; unused.
5486 * intervals.c (interval_start_pos): Now static.
5488 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5490 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5491 Rename locals to avoid shadowing.
5493 * sound.c (wav_play, au_play, Fplay_sound_internal):
5494 Fix pointer signedness.
5495 (alsa_choose_format): Remove unused local var.
5496 (wav_play): Initialize a variable to 0, to prevent undefined
5497 behavior (Bug#8278).
5499 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5501 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5503 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5504 clobbering (Bug#8298).
5505 * sysdep.c (sys_subshell): Likewise.
5506 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5508 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5509 This should get cleaned up, so that child_setup has the
5510 same signature on all platforms.
5512 * callproc.c (call_process_cleanup): Now static.
5513 (relocate_fd): Rename locals to avoid shadowing.
5515 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5517 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5518 not to be necessary, and produces flickering.
5520 2011-03-20 Glenn Morris <rgm@gnu.org>
5522 * config.in: Remove file.
5524 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5526 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5527 are now in src/globals.h.
5528 (syms_of_minibuf): Remove spurious & from previous change.
5530 2011-03-20 Leo <sdl.web@gmail.com>
5532 * minibuf.c (completing-read-function): New variable.
5533 (completing-read-default): Rename from completing-read.
5534 (completing-read): Call completing-read-function.
5536 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5538 * xfaces.c (Fx_load_color_file):
5539 Read color file from absolute filename (bug#8250).
5541 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5543 * makefile.w32-in: Update dependencies.
5545 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5547 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5549 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5551 Fix more problems found by GCC 4.5.2's static checks.
5553 * process.c (make_serial_process_unwind, send_process_trap):
5554 (sigchld_handler): Now static.
5556 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5557 That way, the code declares only the vars that it needs.
5558 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5559 * s/cygwin.h (PTY_ITERATION): Likewise.
5560 * s/darwin.h (PTY_ITERATION): Likewise.
5561 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5563 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5564 * process.c (allocate_pty): Don't declare stb unless it's needed.
5566 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5567 (CONSTANTLIM): Remove; unused.
5568 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5569 Define only if needed.
5571 * unexelf.c (unexec): Name an expression,
5572 to avoid gcc -Wbad-function-cast warning.
5573 Use a different way to cause a compilation error if anyone uses
5574 n rather than nn, a way that does not involve shadowing.
5575 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5577 * deps.mk (unexalpha.o): Remove; unused.
5579 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5580 * unexec.h: New file.
5581 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5582 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5584 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5585 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5586 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5587 Change as necessary to match prototype in unexec.h.
5589 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5591 (back_comment, skip_chars): Mark vars as initialized.
5593 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5594 Rename locals to avoid shadowing.
5596 * lread.c (read1): Rewrite so as not to use empty "else".
5597 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5599 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5601 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5602 warning when compiling print.c.
5604 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5605 instead of using an uninitialized var.
5606 (font_sort_entities): Mark var as initialized.
5608 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5610 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5611 pointers to constants.
5612 (font_parse_fcname): Remove unused vars.
5613 (font_delete_unmatched): Now static.
5614 (font_get_spec): Remove; unused.
5615 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5616 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5617 Rename or move locals to avoid shadowing.
5619 * fns.c (require_nesting_list, require_unwind): Now static.
5620 (Ffillarray): Rename locals to avoid shadowing.
5622 * floatfns.c (domain_error2): Define only if needed.
5623 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5625 * alloc.c (mark_backtrace): Move decl from here ...
5626 * lisp.h: ... to here, so that it can be checked.
5628 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5629 (Fdefvar): Rewrite so as not to use empty "else".
5630 (lisp_indirect_variable): Name an expression,
5631 to avoid gcc -Wbad-function-cast warning.
5632 (Fdefvar): Rename locals to avoid shadowing.
5634 * callint.c (quotify_arg, quotify_args): Now static.
5635 (Fcall_interactively): Rename locals to avoid shadowing.
5636 Use const pointer when appropriate.
5638 * lisp.h (get_system_name, get_operating_system_release):
5639 Move decls here, to check interfaces.
5640 * process.c (get_operating_system_release): Move decl to lisp.h.
5641 * xrdb.c (get_system_name): Likewise.
5642 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5643 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5644 some of which prompt warnings from gcc -Wbad-function-cast.
5645 (Fformat_time_string, Fencode_time, Finsert_char):
5646 (Ftranslate_region_internal, Fformat):
5647 Rename or remove local vars to avoid shadowing.
5648 (Ftranslate_region_internal): Mark var as initialized.
5650 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5653 * lisp.h (eassert): Check that the argument compiles, even if
5654 ENABLE_CHECKING is not defined.
5656 * data.c (Findirect_variable): Name an expression, to avoid
5657 gcc -Wbad-function-cast warning.
5658 (default_value, arithcompare, arith_driver, arith_error): Now static.
5659 (store_symval_forwarding): Rename local to avoid shadowing.
5660 (Fmake_variable_buffer_local, Fmake_local_variable):
5661 Mark variables as initialized.
5662 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5664 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5665 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5666 Rename locals to avoid shadowing.
5667 (mark_stack): Move local variables into the #ifdef region where
5669 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5670 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5672 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5673 (GC_STRING_CHARS): Remove; not used.
5674 (Fmemory_limit): Cast sbrk's returned value to char *.
5676 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5677 avoids undefined behavior in theory.
5679 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5681 Use functions, not macros, for up- and down-casing (Bug#8254).
5682 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5683 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5684 to use the following functions instead of these macros.
5685 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5686 EMACS_INT, since callers assume the returned value fits in int.
5687 (upcase1): Likewise, for UPCASE_TABLE.
5688 (uppercasep, lowercasep, upcase): New static inline functions.
5689 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5690 the race-condition problem in the old DOWNCASE.
5692 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5693 Rename locals to avoid shadowing.
5694 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5695 (regex_compile, re_search_2, re_match_2_internal):
5696 Remove unused local vars.
5697 (FREE_VAR): Rewrite so as not to use empty "else",
5698 which gcc can warn about.
5699 (regex_compile, re_match_2_internal): Mark locals as initialized.
5700 (RETALLOC_IF): Define only if needed.
5701 (WORDCHAR_P): Likewise. This one is never needed, but is used
5702 only in a comment talking about a compiler bug, so put inside
5703 the #if 0 of that comment.
5704 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5705 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5708 * search.c (boyer_moore): Rename locals to avoid shadowing.
5709 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5710 (PREV_CHAR_BOUNDARY): Likewise.
5712 * search.c (simple_search): Remove unused var.
5714 * dired.c (compile_pattern): Move decl from here ...
5715 * lisp.h: ... to here, so that it can be checked.
5716 (struct re_registers): New forward decl.
5718 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5720 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5722 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5723 Rename locals to avoid shadowing.
5724 (Fvertical_motion): Mark locals as initialized.
5726 * casefiddle.c (casify_object, casify_region): Now static.
5727 (casify_region): Mark local as initialized.
5729 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5731 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5732 New macros, so that the caller can use some names other than
5733 gcpro1, gcpro2, etc.
5734 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5736 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5737 argument, for consistency with GCPRO2_VAR, etc: it is now the
5738 prefix of the variable, not the variable itself. All uses
5740 * dired.c (directory_files_internal, file_name_completion):
5741 Rename locals to avoid shadowing.
5743 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5744 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5745 dired.c's scmp function, had undefined behavior.
5746 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5747 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5748 * buffer.h: ... to here, because these macros use current_buffer,
5749 and the new implementation with inline functions needs to have
5750 current_buffer in scope now, rather than later when the macros
5752 (downcase, upcase1): New static inline functions.
5753 (DOWNCASE, UPCASE1): Reimplement using these functions.
5754 This avoids undefined behavior in expressions like
5755 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5756 from race conditions in accessing the global variables
5757 case_temp1 and case_temp2.
5758 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5759 * lisp.h (case_temp1, case_temp2): Remove their decls.
5760 * character.h (ASCII_CHAR_P): Move from here ...
5761 * lisp.h: ... to here, so that the inline functions mentioned
5764 * dired.c (directory_files_internal_unwind): Now static.
5766 * fileio.c (file_name_as_directory, directory_file_name):
5767 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5769 (file_name_as_directory): Use const pointers when appropriate.
5770 (Fexpand_file_name): Likewise. In particular, newdir might
5771 point at constant storage, so make it a const pointer.
5772 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5773 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5775 (Fset_file_times, Finsert_file_contents, auto_save_error):
5776 Rename locals to avoid shadowing.
5778 * minibuf.c (choose_minibuf_frame_1): Now static.
5779 (Ftry_completion, Fall_completions): Rename or remove locals
5782 * marker.c (bytepos_to_charpos): Remove; unused.
5784 * lisp.h (verify_bytepos, count_markers): New decls,
5785 so that gcc does not warn that these functions aren't declared.
5787 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5788 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5789 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5790 (copy_text): Remove unused local var.
5792 * filelock.c (within_one_second): Now static.
5793 (lock_file_1): Rename local to avoid shadowing.
5795 * buffer.c (fix_overlays_before): Mark locals as initialized.
5796 (fix_start_end_in_overlays): Likewise. This function should be
5797 simplified by using pointers-to-pointers, but that's a different
5799 (switch_to_buffer_1): Now static.
5800 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5801 (report_overlay_modification): Rename locals to avoid shadowing.
5803 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5804 Fix pointer signedness issue.
5805 (sys_subshell): Mark local as volatile if checking for lint,
5806 to suppress a gcc -Wclobbered warning that does not seem to be right.
5807 (MAXPATHLEN): Define only if needed.
5809 * process.c (serial_open, serial_configure): Move decls from here ...
5810 * systty.h: ... to here, so that they can be checked.
5812 * fns.c (get_random, seed_random): Move extern decls from here ...
5813 * lisp.h: ... to here, so that they can be checked.
5815 * sysdep.c (reset_io): Now static.
5816 (wait_for_termination_signal): Remove; unused.
5818 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5819 (copy_keymap_item, append_key, push_text_char_description):
5821 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5822 (DENSE_TABLE_SIZE): Remove; unused.
5823 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5824 (describe_map_tree):
5825 Rename locals to avoid shadowing.
5827 * keyboard.c: Declare functions static if they are not used elsewhere.
5828 (echo_char, echo_dash, cmd_error, top_level_2):
5829 (poll_for_input, handle_async_input): Now static.
5830 (read_char, kbd_buffer_get_event, make_lispy_position):
5831 (make_lispy_event, make_lispy_movement, apply_modifiers):
5832 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5833 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5834 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5835 (read_key_sequence, read_char): Mark locals as initialized.
5836 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5838 * keyboard.h (make_ctrl_char): New decl.
5839 (mark_kboards): Move decl here ...
5840 * alloc.c (mark_kboards): ... from here.
5842 * lisp.h (force_auto_save_soon): New decl.
5844 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5845 (DEFINE_DUMMY_FUNCTION): New macro.
5846 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5848 (main): Add casts to avoid warnings
5849 if GCC considers string literals to be constants.
5851 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5853 * dbusbind.c: Pointer signedness fixes.
5854 (xd_signature, xd_append_arg, xd_initialize):
5855 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5856 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5857 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5858 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5860 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5861 if GCC considers string literals to be constants.
5862 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5864 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5866 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5867 (print_preprocess, print_object): New macro to fix last change.
5869 * print.c (print_preprocess): Don't forget font objects.
5871 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
5873 * emacs.c (USAGE3): Doc fixes.
5875 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5877 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5880 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
5882 * lisp.h (VWindow_system, Qfile_name_history):
5883 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5884 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5885 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5887 * w32select.c: Don't #include "keyboard.h".
5888 (run_protected): Add extern declaration for waiting_for_input.
5890 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5891 * w32console.c (detect_input_pending, read_input_pending)
5892 (encode_terminal_code):
5893 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5894 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5895 (w32_system_caret_y, Qfile_name_history):
5896 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5897 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5898 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5899 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5900 * w32proc.c (Qlocal, report_file_error):
5901 * w32term.c (Vwindow_system, updating_frame):
5902 * w32uniscribe.c (initialized, uniscribe_font_driver):
5903 Remove unneeded extern declarations.
5905 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
5907 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
5909 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
5911 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5912 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5913 These macros can no longer be used for assignment.
5915 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5916 Assign struct members directly, instead of using BUF_BEGV etc.
5917 (record_buffer_markers, fetch_buffer_markers): New functions for
5918 recording and fetching special buffer markers.
5919 (set_buffer_internal_1, set_buffer_temp): Use them.
5921 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5923 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5925 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5926 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5928 * xdisp.c (hscroll_window_tree):
5929 (reconsider_clip_changes): Use PT instead of BUF_PT.
5931 2011-03-13 Eli Zaretskii <eliz@gnu.org>
5933 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5934 $(EMACS_ROOT)/lib/intprops.h.
5936 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5938 Fix more problems found by GCC 4.5.2's static checks.
5940 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5941 to unsigned char * to avoid compiler diagnostic.
5942 (xg_free_frame_widgets): Make it clear that a local variable is
5943 needed only if USE_GTK_TOOLTIP.
5944 (gdk_window_get_screen): Make it clear that this macro is needed
5945 only if USE_GTK_TOOLTIP.
5946 (int_gtk_range_get_value): New function, which avoids a diagnostic
5947 from gcc -Wbad-function-cast.
5948 (xg_set_toolkit_scroll_bar_thumb): Use it.
5949 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5950 diagnostic from gcc -Wbad-function-cast.
5951 (get_utf8_string, xg_get_file_with_chooser):
5952 Rename locals to avoid shadowing.
5953 (create_dialog): Move locals to avoid shadowing.
5955 * xgselect.c (xg_select): Remove unused var.
5957 * image.c (four_corners_best): Mark locals as initialized.
5958 (gif_load): Initialize transparent_p to zero (Bug#8238).
5959 Mark another local as initialized.
5960 (my_png_error, my_error_exit): Mark with NO_RETURN.
5962 * image.c (clear_image_cache): Now static.
5963 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
5964 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
5965 (x_edge_detection): Remove unnecessary cast that
5966 gcc -Wbad-function-cast diagnoses.
5967 (gif_load): Fix pointer signedness.
5968 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5969 (jpeg_load, gif_load): Rename locals to avoid shadowing.
5971 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
5973 Improve quality of tests for time stamp overflow.
5974 For example, without this patch (encode-time 0 0 0 1 1
5975 1152921504606846976) returns the obviously-bogus value (-948597
5976 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5977 reports time overflow. See
5978 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
5979 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5980 * editfns.c: Include limits.h and intprops.h.
5981 (TIME_T_MIN, TIME_T_MAX): New macros.
5982 (time_overflow): Move earlier, to before first use.
5983 (hi_time, lo_time): New functions, for an accurate test for
5985 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5986 (Fget_internal_run_time): Don't assume time_t fits in int.
5987 (make_time): Use list2 instead of Fcons twice.
5988 (Fdecode_time): More accurate test for out-of-range times.
5989 (check_tm_member): New function.
5990 (Fencode_time): Use it, to test for out-of-range times.
5991 (lisp_time_argument): Don't rely on undefined left-shift and
5992 right-shift behavior when checking for time stamp overflow.
5994 * editfns.c (time_overflow): New function, refactoring common code.
5995 (Fformat_time_string, Fdecode_time, Fencode_time):
5996 (Fcurrent_time_string): Use it.
5998 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5999 * dired.c (make_time): Move to ...
6000 * editfns.c (make_time): ... here.
6001 * systime.h: Note the move.
6003 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6005 * fringe.c (update_window_fringes): Remove unused variables.
6007 * unexmacosx.c (copy_data_segment): Also copy __got section.
6010 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6012 * termcap.c [MSDOS]: Include "msdos.h".
6013 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6014 Constify `char *' arguments and their references according to
6015 prototypes in tparam.h.
6017 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6019 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6020 Adapt all references accordingly.
6022 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6024 2011-03-11 Tom Tromey <tromey@redhat.com>
6026 * buffer.c (syms_of_buffer): Remove obsolete comment.
6028 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6030 * termhooks.h (encode_terminal_code): Declare prototype.
6032 * msdos.c (encode_terminal_code): Don't declare prototype.
6034 * term.c (encode_terminal_code): Now external again, used by
6035 w32console.c and msdos.c.
6037 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6038 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6040 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6042 Fix some minor problems found by GCC 4.5.2's static checks.
6044 * fringe.c (update_window_fringes): Mark locals as initialized
6046 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6048 * alloc.c (mark_fringe_data): Move decl from here ...
6049 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6050 to check its interface.
6051 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6053 * fontset.c (free_realized_fontset): Now static.
6054 (Fset_fontset_font): Rename local to avoid shadowing.
6055 (fontset_font): Mark local as initialized.
6056 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6058 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6060 * xselect.c (x_disown_buffer_selections): Remove; not used.
6061 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6062 (x_own_selection, Fx_disown_selection_internal): Rename locals
6064 (x_handle_dnd_message): Remove local to avoid shadowing.
6066 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6067 so that the caller can use some name other than gcpro1.
6068 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6069 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6070 (Fx_backspace_delete_keys_p):
6071 Use them to avoid shadowing, and rename vars to avoid shadowing.
6072 (x_decode_color, x_set_name, x_window): Now static.
6073 (Fx_create_frame): Add braces to silence GCC warning.
6074 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6075 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6076 Remove unused locals.
6077 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6078 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6079 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6082 * xterm.h (x_mouse_leave): New decl.
6084 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6085 Remove unused functions.
6086 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6087 (x_calc_absolute_position): Now static.
6088 (XTread_socket): Don't define label "out" unless it's used.
6089 Don't declare local "event" unless it's used.
6090 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6091 unless they are used.
6092 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6093 (x_fatal_error_signal): Remove; not used.
6094 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6095 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6096 (x_error_catcher, x_connection_closed, x_error_handler):
6097 (x_error_quitter, xembed_send_message, x_iconify_frame):
6098 (my_log_handler): Rename locals to avoid shadowing.
6099 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6100 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6102 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6103 Rename or move locals to avoid shadowing.
6104 (tty_defined_color, merge_face_heights): Now static.
6105 (free_realized_faces_for_fontset): Remove; not used.
6106 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6107 does not deduce is never used uninitialized.
6108 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6109 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6111 * terminal.c (store_terminal_param): Now static.
6113 * xmenu.c (menu_highlight_callback): Now static.
6114 (set_frame_menubar): Remove unused local.
6115 (xmenu_show): Rename parameter to avoid shadowing.
6116 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6117 since they might point to immutable storage.
6118 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6119 since it's unused otherwise.
6121 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6122 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6123 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6124 avoids a gcc -Wuninitialized diagnostic.
6125 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6126 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6127 does not deduce are never used uninitialized.
6129 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6131 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6132 * window.c (window_loop, size_window):
6133 (run_window_configuration_change_hook, enlarge_window): Likewise.
6135 * window.c (display_buffer): Now static.
6136 (size_window): Mark variables that gcc -Wuninitialized
6137 does not deduce are never used uninitialized.
6138 * window.h (check_all_windows): New decl, to forestall
6139 gcc -Wmissing-prototypes diagnostic.
6140 * dispextern.h (bidi_dump_cached_states): Likewise.
6142 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6144 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6146 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6147 and to avoid gcc -Wuninitialized warning.
6148 (load_charset_map): Mark variables that gcc -Wuninitialized
6149 does not deduce are never used uninitialized.
6150 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6152 * coding.c (coding_set_source, coding_set_destination):
6153 Use "else { /* comment */ }" rather than "else /* comment */;"
6154 for clarity, and to avoid gcc -Wempty-body warning.
6155 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6156 a block, when the outer 'i' will do.
6157 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6158 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6159 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6160 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6161 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6162 Rename locals to avoid shadowing.
6163 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6164 * coding.c (emacs_mule_char, encode_invocation_designation):
6165 Now static, since they're not used elsewhere.
6166 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6167 (decode_coding_object, encode_coding_object, detect_coding_system):
6168 (decode_coding_emacs_mule): Mark variables that gcc
6169 -Wuninitialized does not deduce are never used uninitialized.
6170 (detect_coding_iso_2022): Initialize a local variable that might
6171 be used uninitialized. Leave a FIXME because it's not clear that
6172 this initialization is needed. (Bug#8211)
6173 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6174 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6175 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6176 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6177 Remove unused macros.
6179 * category.c (hash_get_category_set): Remove unused local var.
6180 (copy_category_table): Now static, since it's not used elsewhere.
6181 * character.c (string_count_byte8): Likewise.
6183 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6184 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6186 * chartab.c (copy_sub_char_table): Now static, since it's not used
6188 (sub_char_table_ref_and_range, char_table_ref_and_range):
6189 Rename locals to avoid shadowing.
6190 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6192 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6193 (BIDI_BOB): Remove unused macro.
6195 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6196 deduce are never used uninitialized.
6197 * term.c (encode_terminal_code): Likewise.
6199 * term.c (encode_terminal_code): Now static. Remove unused local.
6201 * tparam.h: New file.
6202 * term.c, tparam.h: Include it.
6203 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6204 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6205 Move these decls to tparam.h, and make them agree with what
6206 is actually in tparam.c. The previous trick of using incompatible
6207 decls in different modules does not conform to the C standard.
6208 All callers of tparam changed to use tparam's actual API.
6209 * tparam.c (tparam1, tparam, tgoto):
6210 Use const pointers where appropriate.
6212 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6213 * cm.h (struct cm): Likewise.
6214 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6215 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6216 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6217 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6218 (turn_on_face, init_tty): Likewise.
6219 * termchar.h (struct tty_display_info): Likewise.
6221 * term.c (term_mouse_position): Rename local to avoid shadowing.
6223 * alloc.c (mark_ttys): Move decl from here ...
6224 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6226 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6228 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6230 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6232 * search.c (compile_pattern_1): Remove argument regp, unused since
6233 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6234 (compile_pattern): Don't pass it.
6236 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6238 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6239 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6241 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6243 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6245 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6246 gdk_window_get_screen, gdk_window_get_geometry,
6247 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6248 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6249 (xg_get_pixbuf_from_pixmap): New function.
6250 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6251 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6252 Call xg_get_pixbuf_from_pixmap instead of
6253 gdk_pixbuf_get_from_drawable.
6254 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6255 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6256 (xg_check_special_colors): Use GtkStyleContext and its functions
6258 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6259 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6260 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6261 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6262 Call gtk_widget_get_preferred_size.
6263 (xg_frame_resized): gdk_window_get_geometry only takes 5
6265 (xg_win_to_widget, xg_event_is_for_menubar):
6266 Call gdk_x11_window_lookup_for_display.
6267 (xg_set_widget_bg): New function.
6268 (delete_cb): New function.
6269 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6270 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6271 (xg_set_background_color): Call xg_set_widget_bg.
6272 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6273 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6274 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6275 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6277 (update_frame_tool_bar): Call gtk_widget_hide.
6278 (xg_initialize): Use GDK_KEY_g.
6280 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6282 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6284 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6285 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6286 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6288 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6290 * w32xfns.c (select_palette): Check success of RealizePalette against
6291 GDI_ERROR, not zero.
6293 See ChangeLog.11 for earlier changes.
6299 Copyright (C) 2011 Free Software Foundation, Inc.
6301 This file is part of GNU Emacs.
6303 GNU Emacs is free software: you can redistribute it and/or modify
6304 it under the terms of the GNU General Public License as published by
6305 the Free Software Foundation, either version 3 of the License, or
6306 (at your option) any later version.
6308 GNU Emacs is distributed in the hope that it will be useful,
6309 but WITHOUT ANY WARRANTY; without even the implied warranty of
6310 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6311 GNU General Public License for more details.
6313 You should have received a copy of the GNU General Public License
6314 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.