* print.c (printchar, strout): Check for string overflow.
[bpt/emacs.git] / src / ChangeLog
1 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2
3 * print.c (printchar, strout): Check for string overflow.
4 (PRINTPREPARE, printchar, strout):
5 Don't set size unless allocation succeeds.
6
7 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8 for sizes. Check for string overflow more accurately.
9 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
10
11 * macros.c: Integer and buffer overflow fixes.
12 * keyboard.h (struct keyboard.kbd_macro_bufsize):
13 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
14 Use ptrdiff_t, not int, for sizes.
15 Don't increment bufsize until after realloc succeeds.
16 Check for size-calculation overflow.
17 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
18
19 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
20
21 * lread.c: Integer overflow fixes.
22 (read_integer): Radix is now EMACS_INT, not int,
23 to improve quality of diagnostics for out-of-range radices.
24 Calculate buffer size correctly for out-of-range radices.
25 (read1): Check for integer overflow in radices, and in
26 read-circle numbers.
27 (read_escape): Avoid int overflow.
28 (Fload, openp, read_buffer_size, read1)
29 (substitute_object_recurse, read_vector, read_list, map_obarray):
30 Use ptrdiff_t, not int, for sizes.
31 (read1): Use EMACS_INT, not int, for sizes.
32 Check for size overflow.
33
34 * image.c (cache_image): Check for size arithmetic overflow.
35
36 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
37
38 * lread.c: Integer overflow issues.
39 (saved_doc_string_size, saved_doc_string_length)
40 (prev_saved_doc_string_size, prev_saved_doc_string_length):
41 Now ptrdiff_t, not int.
42 (read1): Don't assume doc string length fits in int. Check for
43 out-of-range doc string lengths.
44 (read_list): Don't assume file position fits in int.
45 (read_escape): Check for hex character overflow.
46
47 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
48 The following patches are for when GLYPH_DEBUG && !XASSERT.
49 * dispextern.h (trace_redisplay_p, dump_glyph_string):
50 * dispnew.c (flush_stdout):
51 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
52 Mark as externally visible.
53 * dispnew.c (check_window_matrix_pointers): Now static.
54 * dispnew.c (window_to_frame_vpos):
55 * xfns.c (unwind_create_frame):
56 * xterm.c (x_check_font): Remove unused local.
57 * scroll.c (CHECK_BOUNDS):
58 * xfaces.c (cache_fache): Rename local to avoid shadowing.
59 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
60 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
61 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
62 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
63 Now static.
64 (debug_method_add): Use va_list and vsprintf rather than relying
65 on undefined behavior with wrong number of arguments.
66 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
67 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
68 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
69 since we're not interested in debugging glyphs with old libraries.
70 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
71 GCC 4.6.0's static checking.
72
73 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
74
75 Integer overflow and signedness fixes (Bug#8873).
76 A few related buffer overrun fixes, too.
77
78 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
79
80 * dispextern.h (struct face.stipple):
81 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
82 (x_bitmap_mask, x_allocate_bitmap_record)
83 (x_create_bitmap_from_data, x_create_bitmap_from_file)
84 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
85 (x_create_bitmap_from_xpm_data):
86 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
87 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
88 (.bitmaps_last):
89 * xfaces.c (load_pixmap):
90 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
91 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
92 (.bitmaps_last, struct x_output.icon_bitmap):
93 Use ptrdiff_t, not int, for bitmap indexes.
94 (x_allocate_bitmap_record): Check for size overflow.
95 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
96
97 Use ptrdiff_t, not int, for overlay counts.
98 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
99 * editfns.c (overlays_around, get_pos_property):
100 * textprop.c (get_char_property_and_overlay):
101 * xdisp.c (next_overlay_change, note_mouse_highlight):
102 * xfaces.c (face_at_buffer_position):
103 * buffer.c (OVERLAY_COUNT_MAX): New macro.
104 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
105 (Fnext_overlay_change, Fprevious_overlay_change)
106 (mouse_face_overlay_overlaps, Foverlays_in):
107 Use ptrdiff_t, not int, for sizes.
108 (overlays_at, overlays_in): Check for size-calculation overflow.
109
110 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
111
112 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
113 (x_session_initialize): Do not assume string length fits in int.
114
115 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
116 This is unlikely, but can occur if DPI is outlandish.
117
118 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
119 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
120
121 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
122 * xrdb.c (magic_file_p, search_magic_path):
123 Omit last arg SUFFIX; it was always 0. All callers changed.
124 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
125
126 * xfont.c (xfont_match): Avoid need for strlen.
127
128 * xfns.c: Don't assume strlen fits in int.
129 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
130
131 * xdisp.c (message_log_check_duplicate): Return intmax_t,
132 not unsigned long, as we prefer signed integers. All callers changed.
133 Detect integer overflow in repeat count.
134 (message_dolog): Don't assume print length fits in 39 bytes.
135 (display_mode_element): Don't assume strlen fits in int.
136
137 * termcap.c: Don't assume sizes fit in int and never overflow.
138 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
139 (gobble_line): Check for size-calculation overflow.
140
141 * minibuf.c (Fread_buffer):
142 * lread.c (intern, intern_c_string):
143 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
144 Don't assume string length fits in int.
145
146 * keyboard.c (parse_tool_bar_item):
147 * gtkutil.c (style_changed_cb): Avoid need for strlen.
148
149 * font.c: Don't assume string length fits in int.
150 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
151 Use ptrdiff_t, not int.
152 (font_intern_prop): Don't assume string length fits in int.
153 Don't assume integer property fits in fixnum.
154 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
155
156 * filelock.c: Fix some buffer overrun and integer overflow issues.
157 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
158 Reformulate so as not to need the command string.
159 Invoke gzip -cd rather than gunzip, as it's more portable.
160 (lock_info_type, lock_file_1, lock_file):
161 Don't assume pid_t and time_t fit in unsigned long.
162 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
163 (current_lock_owner): Prefer signed type for sizes.
164 Use memcpy, not strncpy, where memcpy is what is really wanted.
165 Don't assume (via atoi) that time_t and pid_t fit in int.
166 Check for time_t and/or pid_t out of range, e.g., via a network share.
167 Don't alloca where an auto var works fine.
168
169 * fileio.c: Fix some integer overflow issues.
170 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
171 Don't assume string length fits in int.
172 (directory_file_name): Don't assume string length fits in long.
173 (make_temp_name): Don't assume pid fits in int, or that its print
174 length is less than 20.
175
176 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
177
178 * coding.c (make_subsidiaries): Don't assume string length fits in int.
179
180 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
181
182 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
183 We prefer signed integers, even for size calculations.
184
185 * emacs.c: Don't assume string length fits in 'int'.
186 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
187 (main): Don't invoke strlen when not needed.
188
189 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
190 (XD_DEBUG_MESSAGE): Don't waste a byte.
191
192 * callproc.c (getenv_internal_1, getenv_internal)
193 (Fgetenv_internal):
194 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
195
196 * lread.c (invalid_syntax): Omit length argument.
197 All uses changed. This doesn't fix a bug, but it simplifies the
198 code away from its former Hollerith-constant appearance, and it's
199 one less 'int' to worry about when looking at integer-overflow issues.
200 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
201
202 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
203 This didn't break anything, but it didn't help either.
204 It's confusing to put a bogus integer in a place where the actual
205 value does not matter.
206 (LIST_END_P): Remove unused macro and its bogus comment.
207 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
208
209 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
210 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
211 implementation.
212 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
213 We prefer signed types, and the value cannot exceed the EMACS_INT
214 range anyway (because otherwise the length would not be representable).
215 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
216 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
217 This avoids a GCC warning when WIDE_EMACS_INT.
218
219 * indent.c (sane_tab_width): New function.
220 (current_column, scan_for_column, Findent_to, position_indentation)
221 (compute_motion): Use it. This is just for clarity.
222 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
223
224 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
225
226 * lisp.h (lint_assume): New macro.
227 * composite.c (composition_gstring_put_cache):
228 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
229
230 * editfns.c, insdel.c:
231 Omit unnecessary forward decls, to simplify future changes.
232
233 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
234
235 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
236
237 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
238 Use much-faster test for byte-length change.
239 Don't assume string byte-length fits in 'int'.
240 Check that character arg fits in 'int'.
241 (mapcar1): Declare byte as byte, for clarity.
242
243 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
244
245 * fns.c (concat): Catch string overflow earlier.
246 Do not rely on integer wraparound.
247
248 * dispextern.h (struct it.overlay_strings_charpos)
249 (struct it.selective): Now EMACS_INT, not int.
250 * xdisp.c (forward_to_next_line_start)
251 (back_to_previous_visible_line_start)
252 (reseat_at_next_visible_line_start, next_element_from_buffer):
253 Don't arbitrarily truncate the value of 'selective' to int.
254
255 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
256
257 * composite.c: Don't truncate sizes to 'int'.
258 (composition_gstring_p, composition_reseat_it)
259 (composition_adjust_point): Use EMACS_INT, not int.
260 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
261 not EMACS_UINT, for indexes.
262
263 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
264
265 * buffer.c: Include <verify.h>.
266 (struct sortvec.priority, struct sortstr.priority):
267 Now EMACS_INT, not int.
268 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
269 (struct sortstr.size, record_overlay_string)
270 (struct sortstrlist.size, struct sortlist.used):
271 Don't truncate size to int.
272 (record_overlay_string): Check for size-calculation overflow.
273 (init_buffer_once): Check at compile-time, not run-time.
274
275 2011-06-22 Jim Meyering <meyering@redhat.com>
276
277 don't leak an XBM-image-sized buffer
278 * image.c (xbm_load): Free the image buffer after using it.
279
280 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
281
282 Port to Sun C.
283 * composite.c (find_automatic_composition): Omit needless 'return 0;'
284 that Sun C diagnosed.
285 * fns.c (secure_hash): Fix pointer signedness issue.
286 * intervals.c (static_offset_intervals): New function.
287 (offset_intervals): Use it.
288
289 2011-06-21 Leo Liu <sdl.web@gmail.com>
290
291 * deps.mk (fns.o):
292 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
293 sha512.h.
294
295 * fns.c (secure_hash): Rename from crypto_hash_function and change
296 the first arg to accept symbols.
297 (Fsecure_hash): New primtive.
298 (syms_of_fns): New symbols.
299
300 2011-06-20 Deniz Dogan <deniz@dogan.se>
301
302 * process.c (Fset_process_buffer): Clarify return value in
303 docstring.
304
305 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
306
307 * dispnew.c (add_window_display_history): Use BVAR.
308
309 * xdisp.c (debug_method_add): Use BVAR.
310 (check_window_end, dump_glyph_matrix, dump_glyph)
311 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
312
313 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
314 Likewise.
315
316 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
317 check till after the cache is created in init_frame_faces.
318
319 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
320
321 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
322
323 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
324
325 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
326 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
327 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
328
329 Improve buffer-overflow checking (Bug#8873).
330 * fileio.c (Finsert_file_contents):
331 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
332 Remove the old (too-loose) buffer overflow checks.
333 They weren't needed, since make_gap checks for buffer overflow.
334 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
335 The old code merely checked for Emacs fixnum overflow, and relied
336 on undefined (wraparound) behavior. The new code avoids undefined
337 behavior, and also checks for ptrdiff_t and/or size_t overflow.
338
339 * editfns.c (Finsert_char): Don't dump core with very negative counts.
340 Tune. Don't use wider integers than needed. Don't use alloca.
341 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
342
343 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
344
345 * insdel.c, lisp.h (buffer_overflow): New function.
346 (insert_from_buffer_1, replace_range, replace_range_2):
347 * insdel.c (make_gap_larger):
348 * editfns.c (Finsert_char):
349 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
350
351 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
352
353 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
354
355 Integer overflow and signedness fixes (Bug#8873).
356
357 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
358 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
359
360 * fileio.c: Don't assume EMACS_INT fits in off_t.
361 (emacs_lseek): New static function.
362 (Finsert_file_contents, Fwrite_region): Use it.
363 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
364
365 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
366
367 * fns.c: Don't overflow int when computing a list length.
368 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
369 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
370 truncation on 64-bit hosts. Check for QUIT every
371 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
372 faster and is responsive enough.
373 (Flength): Report an error instead of overflowing an integer.
374 (Fsafe_length): Return a float if the value is not representable
375 as a fixnum. This shouldn't happen except in contrived situations.
376 (Fnthcdr, Fsort): Don't assume list length fits in int.
377 (Fcopy_sequence): Don't assume vector length fits in int.
378
379 * alloc.c: Check that resized vectors' lengths fit in fixnums.
380 (header_size, word_size): New constants.
381 (allocate_vectorlike): Don't check size overflow here.
382 (allocate_vector): Check it here instead, since this is the only
383 caller of allocate_vectorlike that could cause overflow.
384 Check that the new vector's length is representable as a fixnum.
385
386 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
387 The previous code was bogus. For example, next_almost_prime (32)
388 returned 39, which is undesirable as it is a multiple of 3; and
389 next_almost_prime (24) returned 25, which is a multiple of 5 so
390 why was the code bothering to check for multiples of 7?
391
392 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
393
394 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
395
396 Variadic C functions now count arguments with ptrdiff_t.
397 This partly undoes my 2011-03-30 change, which replaced int with size_t.
398 Back then I didn't know that the Emacs coding style prefers signed int.
399 Also, in the meantime I found a few more instances where arguments
400 were being counted with int, which may truncate counts on 64-bit
401 machines, or EMACS_INT, which may be unnecessarily wide.
402 * lisp.h (struct Lisp_Subr.function.aMANY)
403 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
404 Arg counts are now ptrdiff_t, not size_t.
405 All variadic functions and their callers changed accordingly.
406 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
407 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
408 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
409 * callint.c (Fcall_interactively): Check arg count for overflow,
410 to avoid potential buffer overrun. Use signed char, not 'int',
411 for 'varies' array, so that we needn't bother to check its size
412 calculation for overflow.
413 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
414 * eval.c (apply_lambda):
415 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
416 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
417 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
418
419 * callint.c (Fcall_interactively): Don't use index var as event count.
420
421 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
422 * mem-limits.h (SIZE): Remove; no longer used.
423
424 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
425
426 Remove unnecessary casts.
427 * xterm.c (x_term_init):
428 * xfns.c (x_set_border_pixel):
429 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
430 These aren't needed now that we assume ANSI C.
431
432 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
433 It's more likely to cause problems (due to unsigned overflow)
434 than to cure them.
435
436 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
437
438 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
439
440 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
441
442 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
443
444 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
445
446 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
447
448 GLYPH_CODE_FACE returns EMACS_INT, not int.
449 * dispextern.h (merge_faces):
450 * xfaces.c (merge_faces):
451 * xdisp.c (get_next_display_element, next_element_from_display_vector):
452 Don't assume EMACS_INT fits in int.
453
454 * character.h (CHAR_VALID_P): Remove unused parameter.
455 * fontset.c, lisp.h, xdisp.c: All uses changed.
456
457 * editfns.c (Ftranslate_region_internal): Omit redundant test.
458
459 * fns.c (concat): Minor tuning based on overflow analysis.
460 This doesn't fix any bugs. Use int to hold character, instead
461 of constantly refetching from Emacs object. Use XFASTINT, not
462 XINT, for value known to be a character. Don't bother comparing
463 a single byte to 0400, as it's always less.
464
465 * floatfns.c (Fexpt):
466 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
467
468 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
469 for characters.
470
471 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
472
473 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
474 Without this fix, on a 64-bit host (aset S 0 4294967386) would
475 incorrectly succeed when S was a string, because 4294967386 was
476 truncated before it was used.
477
478 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
479 Otherwise, an out-of-range integer could cause undefined behavior
480 on a 64-bit host.
481
482 * composite.c: Use int, not EMACS_INT, for characters.
483 (fill_gstring_body, composition_compute_stop_pos): Use int, not
484 EMACS_INT, for values that are known to be in character range.
485 This doesn't fix any bugs but is the usual style inside Emacs and
486 may generate better code on 32-bit machines.
487
488 Make sure a 64-bit char is never passed to ENCODE_CHAR.
489 This is for reasons similar to the recent CHAR_STRING fix.
490 * charset.c (Fencode_char): Check that character arg is actually
491 a character. Pass an int to ENCODE_CHAR.
492 * charset.h (ENCODE_CHAR): Verify that the character argument is no
493 wider than 'int', as a compile-time check to prevent future regressions
494 in this area.
495
496 * character.c (char_string): Remove unnecessary casts.
497
498 Make sure a 64-bit char is never passed to CHAR_STRING.
499 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
500 by silently ignoring the top 32 bits, allowing some values
501 that were far too large to be valid characters.
502 * character.h: Include <verify.h>.
503 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
504 arguments are no wider than unsigned, as a compile-time check
505 to prevent future regressions in this area.
506 * data.c (Faset):
507 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
508 (Fsubst_char_in_region):
509 * fns.c (concat):
510 * xdisp.c (decode_mode_spec_coding):
511 Adjust to CHAR_STRING's new requirement.
512 * editfns.c (Finsert_char, Fsubst_char_in_region):
513 * fns.c (concat): Check that character args are actually
514 characters. Without this test, these functions did the wrong
515 thing with wildly out-of-range values on 64-bit hosts.
516
517 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
518 These casts should not be needed on 32-bit hosts, either.
519 * keyboard.c (read_char):
520 * lread.c (Fload): Remove casts to unsigned.
521
522 * lisp.h (UNSIGNED_CMP): New macro.
523 This fixes comparison bugs on 64-bit hosts.
524 (ASCII_CHAR_P): Use it.
525 * casefiddle.c (casify_object):
526 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
527 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
528 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
529 * dispextern.h (FACE_FROM_ID):
530 * keyboard.c (read_char): Use UNSIGNED_CMP.
531
532 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
533 not to EMACS_INT, to avoid GCC warning.
534
535 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
536
537 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
538 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
539 isn't needed on 32-bit machines.
540
541 * buffer.c (Fgenerate_new_buffer_name):
542 Use EMACS_INT for count, not int.
543 (advance_to_char_boundary): Return EMACS_INT, not int.
544
545 * data.c (Qcompiled_function): Now static.
546
547 * window.c (window_body_lines): Now static.
548
549 * image.c (gif_load): Rename local to avoid shadowing.
550
551 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
552 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
553 * alloc.c (make_save_value): Integer argument is now of type
554 ptrdiff_t, not int.
555 (mark_object): Use ptrdiff_t, not int.
556 * lisp.h (pD): New macro.
557 * print.c (print_object): Use it.
558
559 * alloc.c: Use EMACS_INT, not int, to count objects.
560 (total_conses, total_markers, total_symbols, total_vector_size)
561 (total_free_conses, total_free_markers, total_free_symbols)
562 (total_free_floats, total_floats, total_free_intervals)
563 (total_intervals, total_strings, total_free_strings):
564 Now EMACS_INT, not int. All uses changed.
565 (Fgarbage_collect): Compute overall total using a double, so that
566 integer overflow is less likely to be a problem. Check for overflow
567 when converting back to an integer.
568 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
569 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
570 These were 'int' variables that could overflow on 64-bit hosts;
571 they were never used, so remove them instead of repairing them.
572 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
573 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
574 Previously, this ceilinged at INT_MAX, but that doesn't work on
575 64-bit machines.
576 (allocate_pseudovector): Don't use EMACS_INT when int would do.
577
578 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
579 (allocate_vectorlike): Check for ptrdiff_t overflow.
580 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
581 when a (possibly-narrower) signed value would do just as well.
582 We prefer using signed arithmetic, to avoid comparison confusion.
583
584 * alloc.c: Catch some string size overflows that we were missing.
585 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
586 for convenience in STRING_BYTES_MAX.
587 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
588 The definition here is exact; the one in lisp.h was approximate.
589 (allocate_string_data): Check for string overflow. This catches
590 some instances we weren't catching before. Also, it catches
591 size_t overflow on (unusual) hosts where SIZE_MAX <= min
592 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
593 and ptrdiff_t and EMACS_INT are both 64 bits.
594
595 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
596 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
597 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
598
599 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
600
601 * alloc.c (Fmake_string): Check for out-of-range init.
602
603 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
604
605 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
606
607 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
608
609 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
610 xg_get_default_scrollbar_width.
611
612 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
613 (int_gtk_range_get_value): Move to the scroll bar part of the file.
614 (style_changed_cb): Call update_theme_scrollbar_width and call
615 x_set_scroll_bar_default_width and xg_frame_set_char_size for
616 all frames (Bug#8505).
617 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
618 Call gtk_window_set_resizable if HAVE_GTK3.
619 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
620 and height if HAVE_GTK3 (Bug#8505).
621 (scroll_bar_width_for_theme): New variable.
622 (update_theme_scrollbar_width): New function.
623 (xg_get_default_scrollbar_width): Move code to
624 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
625 (xg_initialize): Call update_theme_scrollbar_width.
626
627 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
628
629 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
630
631 2011-06-12 Martin Rudalics <rudalics@gmx.at>
632
633 * frame.c (make_frame): Call other_buffer_safely instead of
634 other_buffer.
635
636 * window.c (temp_output_buffer_show): Call display_buffer with
637 second argument Vtemp_buffer_show_specifiers and reset latter
638 immediately after the call.
639 (Vtemp_buffer_show_specifiers): New variable.
640 (auto_window_vscroll_p, next_screen_context_lines)
641 (Vscroll_preserve_screen_position): Remove leading asterisks from
642 doc-strings.
643
644 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
645
646 Fix minor problems found by GCC 4.6.0 static checking.
647 * buffer.c (Qclone_number): Remove for now, as it's unused.
648 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
649 (record_buffer): Remove unused local.
650 * frame.c (other_visible_frames, frame_buffer_list): Now static.
651 (set_frame_buffer_list): Remove; unused.
652 * frame.h (other_visible_frames): Remove decl.
653 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
654 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
655 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
656 if HAVE_GPM.
657 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
658 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
659 Define only if HAVE_GPM.
660 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
661 (update_hints_inhibit): Remove; never set. All uses removed.
662 * widgetprv.h (emacsFrameClassRec): Remove decl.
663 * window.c (delete_deletable_window): Now returns void, since it
664 wasn't returning anything.
665 (compare_window_configurations): Remove unused locals.
666 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
667 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
668 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
669 the same widths as pointers. This follows up on the 2011-05-06 patch.
670 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
671 * xterm.h: Likewise.
672 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
673
674 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
675
676 * makefile.w32-in: Update dependencies.
677 (LISP_H): Add lib/intprops.h.
678
679 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
680
681 * image.c (gif_load): Add animation frame delay to the metadata.
682 (syms_of_image): Use DEFSYM. New symbol `delay'.
683
684 2011-06-11 Martin Rudalics <rudalics@gmx.at>
685
686 * window.c (delete_deletable_window): Re-add.
687 (Fset_window_configuration): Rewrite to handle dead buffers and
688 consequently deletable windows.
689 (window_tree, Fwindow_tree): Remove. Supply functionality in
690 window.el.
691 (compare_window_configurations): Simplify code.
692
693 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
694
695 * image.c (imagemagick_load_image): Fix type mismatch.
696 (Fimagemagick_types): Likewise.
697
698 * window.h (replace_buffer_in_windows): Declare.
699
700 2011-06-11 Martin Rudalics <rudalics@gmx.at>
701
702 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
703 Qclone_number. Remove external declaration of Qdelete_window.
704 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
705 code.
706 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
707 Qbuffer_list_update_hook if allowed.
708 (Fother_buffer): Rewrite doc-string. Major rewrite for new
709 buffer list implementation.
710 (other_buffer_safely): New function.
711 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
712 calls to replace_buffer_in_windows and
713 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
714 if allowed.
715 (record_buffer): Inhibit quitting and rewrite using quittable
716 functions. Run Qbuffer_list_update_hook if allowed.
717 (Frecord_buffer, Funrecord_buffer): New functions.
718 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
719 switch-to-buffer to window.el.
720 (bury-buffer): Move to window.el.
721 (Vbuffer_list_update_hook): New variable.
722
723 * lisp.h (other_buffer_safely): Add prototype in buffer.c
724 section.
725
726 * window.h (resize_frame_windows): Move up in code.
727 (Fwindow_frame): Remove EXFUN.
728 (replace_buffer_in_all_windows): Remove prototype.
729 (replace_buffer_in_windows_safely): Add prototype.
730
731 * window.c: Declare Qdelete_window static again. Move down
732 declaration of select_count.
733 (Fnext_window, Fprevious_window): Rewrite doc-strings.
734 (Fother_window): Move to window.el.
735 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
736 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
737 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
738 window.el.
739 (replace_buffer_in_windows): Implement by calling
740 Qreplace_buffer_in_windows.
741 (replace_buffer_in_all_windows): Remove with some functionality
742 moved into replace_buffer_in_windows_safely.
743 (replace_buffer_in_windows_safely): New function.
744 (select_window_norecord, select_frame_norecord): Move in front
745 of run_window_configuration_change_hook. Remove now obsolete
746 declarations.
747 (Fset_window_buffer): Rewrite doc-string. Call
748 Qrecord_window_buffer.
749 (keys_of_window): Move binding for other-window to window.el.
750
751 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
752
753 * dispextern.h (struct image): Replace data member, whose int_val
754 and ptr_val fields were not used by anything, with a single
755 lisp_val object.
756
757 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
758 (gif_clear_image, gif_load, imagemagick_load_image)
759 (gs_clear_image, gs_load): Callers changed.
760
761 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
762
763 * buffer.h: Include <time.h>, for time_t.
764 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
765
766 Fix minor problems found by static checking.
767
768 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
769
770 Make identifiers static if they are not used in other modules.
771 * data.c (Qcompiled_function, Qframe, Qvector):
772 * image.c (QimageMagick, Qsvg):
773 * minibuf.c (Qmetadata):
774 * window.c (resize_window_check, resize_root_window): Now static.
775 * window.h (resize_window_check, resize_root_window): Remove decls.
776
777 * window.c (window_deletion_count, delete_deletable_window):
778 Remove; unused.
779 (window_body_lines): Now static.
780 (Fdelete_other_windows_internal): Mark vars as initialized.
781 Make sure 'resize_failed' is initialized.
782 (run_window_configuration_change_hook): Rename local to avoid shadowing.
783 (resize_window_apply): Remove unused local.
784 * window.h (delete_deletable_window): Remove decl.
785
786 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
787 (imagemagick_load_image): Fix pointer signedness problem by changing
788 last arg from unsigned char * to char *. All uses changed.
789 Also, fix a local for similar reasons.
790 Remove unused locals. Remove locals to avoid shadowing.
791 (fn_rsvg_handle_free): Remove; unused.
792 (svg_load, svg_load_image): Fix pointer signedness problem.
793 (imagemagick_load_image): Don't use garbage pointer image_wand.
794
795 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
796
797 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
798
799 * image.c (gif_load): Fix omitted cast error introduced by
800 2011-06-06 change.
801
802 2011-06-10 Martin Rudalics <rudalics@gmx.at>
803
804 * window.h (resize_proportionally, orig_total_lines)
805 (orig_top_line): Remove from window structure.
806 (set_window_height, set_window_width, change_window_heights)
807 (Fdelete_window): Remove prototypes.
808 (resize_frame_windows): Remove duplicate declaration.
809
810 2011-06-10 Eli Zaretskii <eliz@gnu.org>
811
812 * window.h (resize_frame_windows, resize_window_check)
813 (delete_deletable_window, resize_root_window)
814 (resize_frame_windows): Declare prototypes.
815
816 * window.c (resize_window_apply): Make definition be "static" to
817 match the prototype.
818
819 2011-06-10 Martin Rudalics <rudalics@gmx.at>
820
821 * window.c: Remove declarations of Qwindow_size_fixed,
822 window_min_size_1, window_min_size_2, window_min_size,
823 size_window, window_fixed_size_p, enlarge_window, delete_window.
824 Remove static from declaration of Qdelete_window, it's
825 temporarily needed by Fbury_buffer.
826 (replace_window): Don't assign orig_top_line and
827 orig_total_lines.
828 (Fdelete_window, delete_window): Remove. Window deletion is
829 handled by window.el.
830 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
831 Fdelete_window calls with calls to Qdelete_window.
832 (Fdelete_other_windows): Remove. Deleting other windows is
833 handled by window.el.
834 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
835 handled in window.el.
836 (window_min_size_2, window_min_size_1, window_min_size): Remove.
837 Window minimum sizes are handled in window.el.
838 (shrink_windows, size_window, set_window_height)
839 (set_window_width, change_window_heights, window_height)
840 (window_width, CURBEG, CURSIZE, enlarge_window)
841 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
842 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
843 handled in window.el.
844 (make_dummy_parent): Rename to make_parent_window and give it a
845 second argument horflag.
846 (make_window): Don't set resize_proportionally any more.
847 (Fsplit_window): Remove. Windows are split in window.el.
848 (save_restore_action, save_restore_orig_size)
849 (shrink_window_lowest_first, save_restore_orig_size): Remove.
850 Resize mini windows in window.el.
851 (grow_mini_window, shrink_mini_window): Implement by calling
852 Qresize_root_window_vertically, resize_window_check and
853 resize_window_apply.
854 (saved_window, Fset_window_configuration, save_window_save): Do
855 not handle orig_top_line, orig_total_lines, and
856 resize_proportionally.
857 (window_min_height, window_min_width): Move to window.el.
858 (keys_of_window): Move bindings for delete-other-windows,
859 split-window, delete-window and enlarge-window to window.el.
860
861 * buffer.c: Temporarily extern Qdelete_window.
862 (Fbury_buffer): Temporarily call Qdelete_window instead of
863 Fdelete_window (Fbury_buffer will move to window.el soon).
864
865 * frame.c (set_menu_bar_lines_1): Remove code handling
866 orig_top_line and orig_total_lines.
867
868 * dispnew.c (adjust_frame_glyphs_initially): Don't use
869 set_window_height but set heights directly.
870 (change_frame_size_1): Use resize_frame_windows.
871
872 * xdisp.c (init_xdisp): Don't use set_window_height but set
873 heights directly.
874
875 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
876 resize_frame_windows instead of change_window_heights and run
877 run_window_configuration_change_hook.
878
879 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
880 instead of change_window_heights and run
881 run_window_configuration_change_hook.
882
883 2011-06-09 Martin Rudalics <rudalics@gmx.at>
884
885 * window.c (replace_window): Rename second argument REPLACEMENT to
886 NEW. New third argument SETFLAG. Rewrite.
887 (delete_window, make_dummy_parent): Call replace_window with
888 third argument 1.
889 (window_list_1): Move down in code.
890 (run_window_configuration_change_hook): Move set_buffer part
891 before select_frame_norecord part in order to unwind correctly.
892 Rename count1 to count.
893 (recombine_windows, delete_deletable_window, resize_root_window)
894 (Fdelete_other_windows_internal)
895 (Frun_window_configuration_change_hook, make_parent_window)
896 (resize_window_check, resize_window_apply, Fresize_window_apply)
897 (resize_frame_windows, Fsplit_window_internal)
898 (Fdelete_window_internal, Fresize_mini_window_internal): New
899 functions.
900 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
901
902 2011-06-08 Martin Rudalics <rudalics@gmx.at>
903
904 * window.h (window): Add some new members to window structure -
905 normal_lines, normal_cols, new_total, new_normal, clone_number,
906 splits, nest, prev_buffers, next_buffers.
907 (WINDOW_TOTAL_SIZE): Move here from window.c.
908 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
909
910 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
911 Remove.
912 (make_dummy_parent): Set new members of windows structure.
913 (make_window): Move down in code. Handle new members of window
914 structure.
915 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
916 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
917 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
918 (Fset_window_prev_buffers, Fwindow_next_buffers)
919 (Fset_window_next_buffers, Fset_window_clone_number): New
920 functions.
921 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
922 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
923 Doc-string fixes.
924 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
925 Argument WINDOW can be now internal window too.
926 (Fwindow_use_time): Move up in code.
927 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
928 Rewrite doc-string.
929 (Fset_window_configuration, saved_window)
930 (Fcurrent_window_configuration, save_window_save): Handle new
931 members of window structure.
932 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
933 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
934 (syms_of_window): New Lisp objects Qrecord_window_buffer,
935 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
936 Qget_mru_window, Qresize_root_window,
937 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
938 Qauto_buffer_name; staticpro them.
939
940 2011-06-07 Martin Rudalics <rudalics@gmx.at>
941
942 * window.c (Fwindow_total_size, Fwindow_left_column)
943 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
944 (Fwindow_list_1): New functions.
945 (window_box_text_cols): Replace with window_body_cols.
946 (Fwindow_width, Fscroll_left, Fscroll_right): Use
947 window_body_cols instead of window_box_text_cols.
948 (delete_window, Fset_window_configuration): Call
949 delete_all_subwindows with window as argument.
950 (delete_all_subwindows): Take a window as argument and not a
951 structure. Rewrite.
952 (window_loop): Remove handling of GET_LRU_WINDOW and
953 GET_LARGEST_WINDOW.
954 (Fget_lru_window, Fget_largest_window): Move to window.el.
955
956 * window.h: Extern window_body_cols instead of
957 window_box_text_cols. delete_all_subwindows now takes a
958 Lisp_Object as argument.
959
960 * indent.c (compute_motion, Fcompute_motion): Use
961 window_body_cols instead of window_box_text_cols.
962
963 * frame.c (delete_frame): Call delete_all_subwindows with root
964 window as argument.
965
966 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
967
968 * fns.c (Fputhash): Document return value.
969
970 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
971
972 * image.c (gif_load): Implement gif89a spec "no disposal" method.
973
974 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
975
976 Cons<->int and similar integer overflow fixes (Bug#8794).
977
978 Check for overflow when converting integer to cons and back.
979 * charset.c (Fdefine_charset_internal, Fdecode_char):
980 Use cons_to_unsigned to catch overflow.
981 (Fencode_char): Use INTEGER_TO_CONS.
982 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
983 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
984 * data.c (long_to_cons, cons_to_long): Remove.
985 (cons_to_unsigned, cons_to_signed): New functions.
986 These signal an error for invalid or out-of-range values.
987 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
988 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
989 * font.c (Ffont_variation_glyphs):
990 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
991 * lisp.h: Include <intprops.h>.
992 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
993 (cons_to_signed, cons_to_unsigned): New decls.
994 (long_to_cons, cons_to_long): Remove decls.
995 * undo.c (record_first_change): Use INTEGER_TO_CONS.
996 (Fprimitive_undo): Use CONS_TO_INTEGER.
997 * xfns.c (Fx_window_property): Likewise.
998 * xselect.c: Include <limits.h>.
999 (x_own_selection, selection_data_to_lisp_data):
1000 Use INTEGER_TO_CONS.
1001 (x_handle_selection_request, x_handle_selection_clear)
1002 (x_get_foreign_selection, Fx_disown_selection_internal)
1003 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1004 (lisp_data_to_selection_data): Use cons_to_unsigned.
1005 (x_fill_property_data): Use cons_to_signed.
1006 Report values out of range.
1007
1008 Check for buffer and string overflow more precisely.
1009 * buffer.h (BUF_BYTES_MAX): New macro.
1010 * lisp.h (STRING_BYTES_MAX): New macro.
1011 * alloc.c (Fmake_string):
1012 * character.c (string_escape_byte8):
1013 * coding.c (coding_alloc_by_realloc):
1014 * doprnt.c (doprnt):
1015 * editfns.c (Fformat):
1016 * eval.c (verror):
1017 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1018 since they may not be the same number.
1019 * editfns.c (Finsert_char):
1020 * fileio.c (Finsert_file_contents):
1021 Likewise for BUF_BYTES_MAX.
1022
1023 * image.c: Use ptrdiff_t, not int, for sizes.
1024 (slurp_file): Switch from int to ptrdiff_t.
1025 All uses changed.
1026 (slurp_file): Check that file size fits in both size_t (for
1027 malloc) and ptrdiff_t (for sanity and safety).
1028
1029 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1030 if b->modtime has its maximal value.
1031
1032 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1033
1034 Don't assume time_t can fit into int.
1035 * buffer.h (struct buffer.modtime): Now time_t, not int.
1036 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1037 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1038
1039 Minor fixes for signed vs unsigned integers.
1040 * character.h (MAYBE_UNIFY_CHAR):
1041 * charset.c (maybe_unify_char):
1042 * keyboard.c (read_char, reorder_modifiers):
1043 XINT -> XFASTINT, since the integer must be nonnegative.
1044 * ftfont.c (ftfont_spec_pattern):
1045 * keymap.c (access_keymap, silly_event_symbol_error):
1046 XUINT -> XFASTINT, since the integer must be nonnegative.
1047 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1048 since it makes no difference and we prefer signed.
1049 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1050 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1051 nonnegative.
1052
1053 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1054
1055 * window.h (Fwindow_frame): Declare.
1056
1057 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1058
1059 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1060 (SPARE_MEMORY): Always define.
1061 (LARGE_REQUEST): Remove.
1062 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1063
1064 2011-06-06 Martin Rudalics <rudalics@gmx.at>
1065
1066 * lisp.h: Move EXFUNS for Fframe_root_window,
1067 Fframe_first_window and Fset_frame_selected_window to window.h.
1068
1069 * window.h: Move EXFUNS for Fframe_root_window,
1070 Fframe_first_window and Fset_frame_selected_window here from
1071 lisp.h.
1072
1073 * frame.c (Fwindow_frame, Fframe_first_window)
1074 (Fframe_root_window, Fframe_selected_window)
1075 (Fset_frame_selected_window): Move to window.c.
1076 (Factive_minibuffer_window): Move to minibuf.c.
1077 (Fother_visible_frames_p): New function.
1078
1079 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1080
1081 * window.c (decode_window, decode_any_window): Move up in code.
1082 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1083 (inhibit_frame_unsplittable): Remove unused variable.
1084 (Fwindow_buffer): Move up and rewrite doc-string.
1085 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1086 (Fwindow_prev): New functions.
1087 (Fwindow_frame): Move here from frame.c. Accept any window as
1088 argument.
1089 (Fframe_root_window, Fframe_first_window)
1090 (Fframe_selected_window): Move here from frame.c. Accept frame
1091 or arbitrary window as argument. Update doc-strings.
1092 (Fminibuffer_window): Move up in code.
1093 (Fwindow_minibuffer_p): Move up in code and simplify.
1094 (Fset_frame_selected_window): Move here from frame.c.
1095 Marginal rewrite.
1096 (Fselected_window, select_window, Fselect_window): Move up in
1097 code. Minor doc-string fixes.
1098
1099 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1100
1101 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1102 Do not assume that spare memory exists; that assumption is valid
1103 only if SYSTEM_MALLOC.
1104 (LARGE_REQUEST): New macro, so that the issue of large requests
1105 is separated from the issue of spare memory.
1106
1107 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1108
1109 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1110 format. (Bug#8806)
1111
1112 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1113
1114 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1115 before statements.
1116
1117 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1118
1119 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1120
1121 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1122
1123 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1124 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1125
1126 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
1127
1128 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1129
1130 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
1131
1132 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1133 (x_clipboard_manager_save): Add return value.
1134 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1135 New error handlers.
1136 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1137 Obey Vx_select_enable_clipboard_manager. Catch errors in
1138 x_clipboard_manager_save (Bug#8779).
1139 (Vx_select_enable_clipboard_manager): New variable.
1140 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
1141
1142 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
1143
1144 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1145
1146 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1147
1148 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1149 in the current matrix if keep_current_p is non-zero.
1150
1151 2011-06-04 Eli Zaretskii <eliz@gnu.org>
1152
1153 * bidi.c (bidi_level_of_next_char): Fix last change.
1154
1155 2011-06-03 Eli Zaretskii <eliz@gnu.org>
1156
1157 Support bidi reordering of text covered by display properties.
1158
1159 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1160 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1161 (bidi_cache_search, bidi_cache_iterator_state)
1162 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1163 (bidi_level_of_next_char, bidi_move_to_visually_next):
1164 Support character positions inside a run of characters covered by a
1165 display string.
1166 (bidi_paragraph_init, bidi_resolve_explicit_1)
1167 (bidi_level_of_next_char): Call bidi_fetch_char and
1168 bidi_fetch_char_advance instead of FETCH_CHAR and
1169 FETCH_CHAR_ADVANCE.
1170 (bidi_init_it): Initialize new members.
1171 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1172 definitions.
1173 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1174 instead of using explicit *_CHAR codes.
1175 (bidi_resolve_explicit, bidi_resolve_weak):
1176 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
1177 bidirectional text is supported only in multibyte buffers.
1178 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1179 it to initialize the frame_window_p member of struct bidi_it.
1180 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1181 (bidi_resolve_explicit, bidi_resolve_weak)
1182 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1183 bidi_it->nchars is non-positive.
1184 (bidi_level_of_next_char): Don't try to lookup the cache for the
1185 next/previous character if nothing is cached there yet, or if we
1186 were just reseat()'ed to a new position.
1187
1188 * xdisp.c (set_cursor_from_row): Set start and stop points
1189 according to the row's direction when priming the loop that looks
1190 for the glyph on which to display cursor.
1191 (single_display_spec_intangible_p): Function deleted.
1192 (display_prop_intangible_p): Reimplement to call
1193 handle_display_spec instead of single_display_spec_intangible_p.
1194 Accept 3 additional arguments needed by handle_display_spec.
1195 This fixes incorrect cursor motion across display property with complex
1196 values: lists, `(when COND...)' forms, etc.
1197 (single_display_spec_string_p): Support property values that are
1198 lists with the argument STRING its top-level element.
1199 (display_prop_string_p): Fix the condition for processing a
1200 property that is a list to be consistent with handle_display_spec.
1201 (handle_display_spec): New function, refactored from the
1202 last portion of handle_display_prop.
1203 (compute_display_string_pos): Accept additional argument
1204 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1205 value of a `display' property is a "replacing spec".
1206 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1207 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1208 the display property, but just return a value indicating whether
1209 the display property will replace the characters it covers.
1210 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1211 frame_window_p members of struct bidi_it.
1212 (compute_display_string_pos, compute_display_string_end):
1213 New functions.
1214 (push_it): Accept second argument POSITION, where pop_it should
1215 jump to continue iteration.
1216 (reseat_1): Initialize bidi_it.disp_pos.
1217
1218 * keyboard.c (adjust_point_for_property): Adjust the call to
1219 display_prop_intangible_p to its new signature.
1220
1221 * dispextern.h (struct bidi_it): New member frame_window_p.
1222 (bidi_init_it): Update prototypes.
1223 (display_prop_intangible_p): Update prototype.
1224 (compute_display_string_pos, compute_display_string_end):
1225 Declare prototypes.
1226 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1227 EMACS_INT.
1228
1229 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
1230
1231 Malloc failure behavior now depends on size of allocation.
1232 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1233 * lisp.h: Change signatures accordingly.
1234 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1235 All callers changed. (Bug#8762)
1236
1237 * gnutls.c: Use Emacs's memory allocators.
1238 Without this change, the gnutls library would invoke malloc etc.
1239 directly, which causes problems on non-SYNC_INPUT hosts, and which
1240 runs afoul of improving memory_full behavior. (Bug#8761)
1241 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1242 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1243 xfree instead of the default malloc, realloc, free.
1244 (Fgnutls_boot): No need to check for memory allocation failure,
1245 since xmalloc does that for us.
1246
1247 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
1248 * category.c (hash_get_category_set):
1249 * ccl.c (ccl_driver):
1250 * charset.c (Fdefine_charset_internal):
1251 * charset.h (struct charset.hash_index):
1252 * composite.c (get_composition_id, gstring_lookup_cache)
1253 (composition_gstring_put_cache):
1254 * composite.h (struct composition.hash_index):
1255 * dispextern.h (struct image.hash):
1256 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1257 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1258 (hashfn_equal, hashfn_user_defined, make_hash_table)
1259 (maybe_resize_hash_table, hash_lookup, hash_put)
1260 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1261 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1262 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1263 * image.c (make_image, search_image_cache, lookup_image)
1264 (xpm_put_color_table_h):
1265 * lisp.h (struct Lisp_Hash_Table):
1266 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
1267 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1268 for hashes and hash indexes, instead of 'unsigned' and 'int'.
1269 * alloc.c (allocate_vectorlike):
1270 Check for overflow in vector size calculations.
1271 * ccl.c (ccl_driver):
1272 Check for overflow when converting EMACS_INT to int.
1273 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1274 need to be updated by these changes.
1275 * fns.c (make_hash_table, maybe_resize_hash_table):
1276 Check for integer overflow with large hash tables.
1277 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1278 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1279 (SXHASH_REDUCE): New macro.
1280 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1281 Use it instead of discarding useful hash info with large hash values.
1282 (sxhash_float): New function.
1283 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1284 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
1285 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1286 Rewrite to use FIXNUM_BITS, as this simplifies things.
1287 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1288 Adjust signatures to match updated version of code.
1289 (consing_since_gc): Now EMACS_INT, since a single hash table can
1290 use more than INT_MAX bytes.
1291
1292 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1293
1294 Make it possible to build with GCC-4.6+ -O2 -flto.
1295
1296 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1297
1298 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1299
1300 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1301 Call minibuffer-inactive-mode.
1302
1303 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
1304
1305 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1306 Update dependencies.
1307
1308 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1309
1310 * data.c (init_data): Remove code for UTS, this system is not
1311 supported anymore.
1312
1313 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1314
1315 Don't force ./temacs to start in terminal mode.
1316
1317 * frame.c (make_initial_frame): Initialize faces in all cases, not
1318 only when CANNOT_DUMP is defined.
1319 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1320
1321 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1322
1323 * dispnew.c (add_window_display_history): Use const for the string
1324 pointer. Remove declaration, not needed.
1325
1326 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1327
1328 Use 'inline', not 'INLINE'.
1329 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1330 * alloc.c, fontset.c (INLINE): Remove.
1331 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1332 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1333 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1334 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1335 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1336
1337 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1338
1339 Make it possible to run ./temacs.
1340
1341 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1342 syms_of_callproc does the same thing. Remove test for
1343 "initialized", do it in the caller.
1344 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1345
1346 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1347
1348 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1349 (read_minibuf): Use get_minibuffer.
1350 (syms_of_minibuf): Use DEFSYM.
1351 (Qmetadata): New var.
1352 * data.c (Qbuffer): Don't make it static.
1353 (syms_of_data): Use DEFSYM.
1354
1355 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1356
1357 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1358 (CCL_CODE_MIN): New macro.
1359
1360 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1361
1362 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1363
1364 * eval.c (Qdebug): Now static.
1365 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1366 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1367 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1368
1369 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1370
1371 * image.c: Various fixes to ImageMagick code comments.
1372 (Fimagemagick_types): Doc fix.
1373
1374 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1375
1376 Minor fixes prompted by GCC 4.6.0 warnings.
1377
1378 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1379
1380 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1381 (x_clipboard_manager_save_all): Move extern decl to ...
1382 * xterm.h: ... here, so that it can be checked for consistency.
1383
1384 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1385
1386 * xselect.c (x_clipboard_manager_save_frame)
1387 (x_clipboard_manager_save_all): New functions.
1388 (Fx_clipboard_manager_save): Lisp function deleted.
1389
1390 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1391 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1392
1393 * xterm.h: Update prototype.
1394
1395 2011-05-28 William Xu <william.xwl@gmail.com>
1396
1397 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1398 exiting (Bug#8239).
1399
1400 2011-05-28 Jim Meyering <meyering@redhat.com>
1401
1402 Avoid a sign-extension bug in crypto_hash_function.
1403 * fns.c (to_uchar): Define.
1404 (crypto_hash_function): Use it to convert some newly-signed
1405 variables to unsigned, to avoid sign-extension bugs. For example,
1406 without this change, (md5 "truc") would evaluate to
1407 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1408 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1409 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1410
1411 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1412
1413 Integer overflow fixes.
1414
1415 * dbusbind.c: Serial number integer overflow fixes.
1416 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1417 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1418 to hold a serial number that is too large for a fixnum.
1419 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1420 Check for serial numbers out of range. Decode any serial number
1421 that was so large that it became a float. (Bug#8722)
1422
1423 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1424 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1425 Use XFASTINT rather than XUINT when numbers are nonnegative.
1426 (xd_append_arg, Fdbus_method_return_internal):
1427 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1428 arguments, check that Lisp number is nonnegative, rather than
1429 silently wrapping negative numbers around. (Bug#8722)
1430 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1431 (Bug#8722)
1432
1433 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1434
1435 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1436
1437 ccl: add integer overflow checks
1438 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1439 (IN_INT_RANGE): New macros.
1440 (ccl_driver): Use them to check for integer overflow when
1441 decoding a CCL program. Many of the new checks are whether XINT (x)
1442 fits in int; it doesn't always, on 64-bit hosts. The new version
1443 doesn't catch all possible integer overflows, but it's an
1444 improvement. (Bug#8719)
1445
1446 * alloc.c (make_event_array): Use XINT, not XUINT.
1447 There's no need for unsigned here.
1448
1449 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1450 This follows up to the 2011-05-06 change that substituted uintptr_t
1451 for EMACS_INT. This case wasn't caught back then.
1452
1453 Rework Fformat to avoid integer overflow issues.
1454 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1455 now (part of C89). Include <verify.h>.
1456 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1457 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1458 (Fformat): Avoid the prepass trying to compute sizes; it was only
1459 approximate and thus did not catch overflow reliably. Instead, walk
1460 through the format just once, formatting and computing sizes as we go,
1461 checking for integer overflow at every step, and allocating a larger
1462 buffer as needed. Keep track separately whether the format is
1463 multibyte. Keep only the most-recently calculated precision, rather
1464 than them all. Record whether each argument has been converted to
1465 string. Use EMACS_INT, not int, for byte and char and arg counts.
1466 Support field widths and precisions larger than INT_MAX. Avoid
1467 sprintf's undefined behavior with conversion specifications such as %#d
1468 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1469 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1470 formatting out-of-range floating point numbers with int
1471 formats. (Bug#8668)
1472
1473 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1474
1475 * data.c: Avoid integer truncation in expressions involving floats.
1476 * data.c: Include <intprops.h>.
1477 (arith_driver): When there's an integer overflow in an expression
1478 involving floating point, convert the integers to floating point
1479 so that the resulting value does not suffer from catastrophic
1480 integer truncation. For example, on a 64-bit host (* 4
1481 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1482 Do not rely on undefined behavior after integer overflow.
1483
1484 merge count_size_as_multibyte, parse_str_to_multibyte
1485 * character.c, character.h (count_size_as_multibyte):
1486 Rename from parse_str_to_multibyte; all uses changed.
1487 Check for integer overflow.
1488 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1489 since it's now a duplicate of the other. This is more of
1490 a character than a buffer op, so better that it's in character.c.
1491 * fns.c, print.c: Adjust to above changes.
1492
1493 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1494
1495 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1496
1497 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1498
1499 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1500 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1501 (x_clipboard_manager_save): Now static.
1502 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1503
1504 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1505 (crypto_hash_function): Now static.
1506 Fix pointer signedness problems. Avoid unnecessary initializations.
1507
1508 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1509
1510 * termhooks.h (Vselection_alist): Make it terminal-local.
1511
1512 * terminal.c (create_terminal): Initialize it.
1513
1514 * xselect.c: Support for clipboard managers.
1515 (Vselection_alist): Move to termhooks.h as terminal-local var.
1516 (LOCAL_SELECTION): New macro.
1517 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1518 (symbol_to_x_atom): Remove gratuitous arg.
1519 (x_handle_selection_request, lisp_data_to_selection_data)
1520 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1521 (x_own_selection, x_get_local_selection, x_convert_selection):
1522 New arg, specifying work frame. Use terminal-local Vselection_alist.
1523 (some_frame_on_display): Delete unused function.
1524 (Fx_own_selection_internal, Fx_get_selection_internal)
1525 (Fx_disown_selection_internal, Fx_selection_owner_p)
1526 (Fx_selection_exists_p): New optional frame arg.
1527 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1528 (x_handle_selection_clear): Don't treat other terminals with the
1529 same keyboard specially. Use the terminal-local Vselection_alist.
1530 (x_clear_frame_selections): Use Frun_hook_with_args.
1531
1532 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1533
1534 * xterm.h: Add support for those atoms.
1535
1536 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
1537
1538 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1539 (converted_selections, conversion_fail_tag): New global variables.
1540 (x_selection_request_lisp_error): Free the above.
1541 (x_get_local_selection): Remove unnecessary code.
1542 (x_reply_selection_request): Args changed; handle arbitrary array
1543 of converted selections stored in converted_selections.
1544 Separate the XChangeProperty and SelectionNotify steps.
1545 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1546 (x_convert_selection): New function.
1547 (x_handle_selection_event): Simplify.
1548 (x_get_foreign_selection): Don't ignore incoming requests while
1549 waiting for an answer; this will fail when we implement
1550 SAVE_TARGETS, and seems unnecessary anyway.
1551 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1552 (Vx_sent_selection_functions): Doc fix.
1553
1554 2011-05-26 Leo Liu <sdl.web@gmail.com>
1555
1556 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1557
1558 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1559
1560 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1561
1562 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1563 for fringe update if it has periodic bitmap.
1564 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1565 and fringe_bitmap_periodic_p.
1566
1567 * fringe.c (get_fringe_bitmap_data): New function.
1568 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1569 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1570 row. Mark glyph row for fringe update if periodicity changed.
1571
1572 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1573 for fringe update unless it has periodic bitmap.
1574
1575 2011-05-25 Kenichi Handa <handa@m17n.org>
1576
1577 * xdisp.c (get_next_display_element): Set correct it->face_id for
1578 a static composition.
1579
1580 2011-05-24 Leo Liu <sdl.web@gmail.com>
1581
1582 * deps.mk (fns.o):
1583 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1584
1585 * fns.c (crypto_hash_function, Fsha1): New function.
1586 (Fmd5): Use crypto_hash_function.
1587 (syms_of_fns): Add Ssha1.
1588
1589 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1590
1591 * gnutls.c: Remove unused macros.
1592 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1593 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1594 Remove macros that are defined and never used.
1595 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1596
1597 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1598
1599 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1600 (Fx_get_selection_internal): Minor cleanup.
1601 (Fx_own_selection_internal): Rename arguments for consistency with
1602 select.el.
1603
1604 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1605
1606 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1607
1608 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1609
1610 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1611
1612 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1613
1614 * dispnew.c (scrolling_window): Don't exclude the case that the
1615 last enabled row in the desired matrix touches the bottom boundary.
1616
1617 2011-05-21 Glenn Morris <rgm@gnu.org>
1618
1619 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
1620 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1621 and add some more files.
1622
1623 2011-05-20 Eli Zaretskii <eliz@gnu.org>
1624
1625 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1626 report_file_error introduced by the change from 2011-05-07.
1627
1628 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1629
1630 * systime.h (Time): Define only if emacs is defined.
1631 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1632 where the include path doesn't have X11/X.h by default. See
1633 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1634
1635 2011-05-20 Kenichi Handa <handa@m17n.org>
1636
1637 * composite.c (find_automatic_composition): Fix previous change.
1638
1639 2011-05-20 Glenn Morris <rgm@gnu.org>
1640
1641 * lisp.mk: New file, split from Makefile.in.
1642 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1643 (shortlisp): Remove.
1644 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1645
1646 2011-05-19 Glenn Morris <rgm@gnu.org>
1647
1648 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1649 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1650 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1651 (lisp): Set the order to that of loadup.el.
1652 (shortlisp): Make it a copy of $lisp.
1653 (SOME_MACHINE_LISP): Remove.
1654 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1655 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1656
1657 2011-05-18 Kenichi Handa <handa@m17n.org>
1658
1659 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1660 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1661 (find_automatic_composition): Mostly rewrite for efficiency.
1662
1663 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
1664
1665 * makefile.w32-in: Update dependencies.
1666
1667 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1668
1669 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1670 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
1671
1672 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
1673
1674 Fix some integer overflow issues, such as string length overflow.
1675
1676 * insdel.c (count_size_as_multibyte): Check for string overflow.
1677
1678 * character.c (lisp_string_width): Check for string overflow.
1679 Use EMACS_INT, not int, for string indexes and lengths; in
1680 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1681 the resulting string length overflows an EMACS_INT; instead,
1682 report a string overflow if no precision given. When checking for
1683 precision exhaustion, use a check that cannot possibly have
1684 integer overflow. (Bug#8675)
1685 * character.h (lisp_string_width): Adjust to new signature.
1686
1687 * alloc.c (string_overflow): New function.
1688 (Fmake_string): Use it. This doesn't change behavior, but saves
1689 a few bytes and will simplify future changes.
1690 * character.c (string_escape_byte8): Likewise.
1691 * lisp.h (string_overflow): New decl.
1692
1693 Fixups, following up to the user-interface timestamp change.
1694 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1695 for UI timestamps, instead of unsigned long.
1696 * msdos.c (mouse_get_pos): Likewise.
1697 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1698 * w32gui.h (Time): Define by including "systime.h" rather than by
1699 declaring it ourselves. (Bug#8664)
1700
1701 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1702 * image.c (clear_image_cache): Likewise.
1703
1704 * term.c (term_mouse_position): Don't assume time_t wraparound.
1705
1706 Be more systematic about user-interface timestamps.
1707 Before, the code sometimes used 'Time', sometimes 'unsigned long',
1708 and sometimes 'EMACS_UINT', to represent these timestamps.
1709 This change causes it to use 'Time' uniformly, as that's what X uses.
1710 This makes the code easier to follow, and makes it easier to catch
1711 integer overflow bugs such as Bug#8664.
1712 * frame.c (Fmouse_position, Fmouse_pixel_position):
1713 Use Time, not unsigned long, for user-interface timestamps.
1714 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1715 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1716 * keyboard.h (last_event_timestamp): Likewise.
1717 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1718 * menu.h (xmenu_show): Likewise.
1719 * term.c (term_mouse_position): Likewise.
1720 * termhooks.h (struct input_event.timestamp): Likewise.
1721 (struct terminal.mouse_position_hook): Likewise.
1722 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1723 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1724 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1725 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1726 what it was before.
1727 * menu.h, termhooks.h: Include "systime.h", for Time.
1728
1729 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1730 Don't assume that the difference between two unsigned long values
1731 can fit into an integer. At this point, we know button_down_time
1732 <= event->timestamp, so the difference must be nonnegative, so
1733 there's no need to cast the result if double-click-time is
1734 nonnegative, as it should be; check that it's nonnegative, just in
1735 case. This bug is triggered when events are more than 2**31 ms
1736 apart (about 25 days). (Bug#8664)
1737
1738 * xselect.c (last_event_timestamp): Remove duplicate decl.
1739 (x_own_selection): Remove needless cast to unsigned long.
1740
1741 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1742 that always fit in int. Use a sentinel instead of a counter, to
1743 avoid a temp and to allay GCC's concerns about possible int overflow.
1744 * frame.h (struct frame): Use int for menu_bar_items_used
1745 instead of EMACS_INT, since it always fits in int.
1746
1747 * menu.c (grow_menu_items): Check for int overflow.
1748
1749 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1750
1751 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1752 Before, the code was not consistent. These values cannot exceed
1753 2**31 - 1 so there's no need to make them unsigned.
1754 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1755 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1756 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1757 as modifiers.
1758 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1759
1760 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1761 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1762 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1763 presumably because the widths might not match.
1764
1765 * window.c (size_window): Avoid needless test at loop start.
1766
1767 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1768
1769 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1770
1771 2011-05-12 Drew Adams <drew.adams@oracle.com>
1772
1773 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1774
1775 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1776
1777 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1778 `width' to `bar_area_x' and `bar_area_width', respectively.
1779 (x_scroll_run): Take account of fringe background extension.
1780
1781 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1782 Rename local vars `left' and `width' to `bar_area_x' and
1783 `bar_area_width', respectively.
1784 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1785 background extension.
1786
1787 2011-05-10 Jim Meyering <meyering@redhat.com>
1788
1789 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1790
1791 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
1792
1793 * image.c (Finit_image_library): Return t for built-in image types,
1794 like pbm and xbm. (Bug#8640)
1795
1796 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1797
1798 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1799
1800 2011-05-07 Eli Zaretskii <eliz@gnu.org>
1801
1802 * w32console.c (Fset_screen_color): Doc fix.
1803 (Fget_screen_color): New function.
1804 (syms_of_ntterm): Defsubr it.
1805
1806 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1807 unlink the temporary file if Fcall_process didn't create it in the
1808 first place.
1809 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1810 child process will be redirected to a file specified with `:file'.
1811 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1812 cue to call_process_cleanup not to close that handle.
1813
1814 2011-05-07 Ben Key <bkey76@gmail.com>
1815
1816 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1817 one of two shell specific rules, either bootstrap-temacs-CMD or
1818 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1819 to the previous implementation of the bootstrap-temacs rule.
1820 The bootstrap-temacs-CMD rule is similar to the previous
1821 implementation of the bootstrap-temacs rule except that it
1822 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1823 variable.
1824
1825 These changes, along with some changes to nt/configure.bat,
1826 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1827 earlier fix to add support for --cflags and --ldflags options
1828 that include quotes so that it works whether make uses cmd or
1829 sh as the shell.
1830
1831 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
1832
1833 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1834 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1835 is a constant.
1836 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1837 a string. Handle both cases.
1838 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1839 (Fdbus_register_method): Use Qinvalid_function.
1840
1841 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1842
1843 * makefile.w32-in: Update dependencies.
1844 (LISP_H): Add inttypes.h and stdin.h.
1845 (PROCESS_H): Add unistd.h.
1846
1847 2011-05-06 Eli Zaretskii <eliz@gnu.org>
1848
1849 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1850 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1851
1852 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
1853
1854 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1855
1856 * term.c (vfatal): Remove stray call to va_end.
1857 It's not needed and the C Standard doesn't allow it here anyway.
1858
1859 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1860 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1861
1862 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1863 bytes.
1864
1865 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1866
1867 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1868
1869 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1870
1871 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1872
1873 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1874
1875 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1876 * charset.c (Fdefine_charset_internal): Don't initialize
1877 charset.code_space[15]. The value was garbage, on hosts with
1878 32-bit int (Bug#8600).
1879
1880 * lread.c (read_integer): Be more consistent with string-to-number.
1881 Use string_to_number to do the actual conversion; this avoids
1882 rounding errors and fixes some other screwups. Without this fix,
1883 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1884 (digit_to_number): Move earlier, for benefit of read_integer.
1885 Return -1 if the digit is out of range for the base, -2 if it is
1886 not a digit in any supported base. (Bug#8602)
1887
1888 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1889
1890 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1891 to match comment at start of function. This also removes a
1892 GCC warning about overflow in a 32+64-bit port.
1893
1894 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1895
1896 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1897 Reported by Stefan Monnier in
1898 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
1899 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1900 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
1901
1902 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1903 (EMACS_UINTPTR): Likewise, with uintptr_t.
1904
1905 * lisp.h: Prefer 64-bit EMACS_INT if available.
1906 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1907 on 32-bit hosts that have 64-bit int, so that they can access
1908 large files.
1909 However, temporarily disable this change unless the temporary
1910 symbol WIDE_EMACS_INT is defined.
1911
1912 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1913
1914 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1915 This removes an assumption that EMACS_INT and long are the same
1916 width as pointers. The assumption is true for Emacs porting targets
1917 now, but we want to make other targets possible.
1918 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1919 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1920 In the rest of the code, change types of integers that hold casted
1921 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1922 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1923 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1924 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1925 No need to cast type when ORing.
1926 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1927 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1928 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1929 assume EMACS_INT is the same width as char *.
1930 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1931 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1932 Remove no-longer-needed casts.
1933 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1934 (xg_tool_bar_help_callback, xg_make_tool_item):
1935 Use EMACS_INTPTR to hold an integer
1936 that will be cast to void *; this can avoid a GCC warning
1937 if EMACS_INT is not the same width as void *.
1938 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1939 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1940 (current_message_1, set_message_1):
1941 Use a local to convert to proper width without a cast.
1942 * xmenu.c (dialog_selection_callback): Likewise.
1943
1944 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1945 Also, don't assume VALBITS / RAND_BITS is less than 5,
1946 and don't rely on undefined behavior when shifting a 1 left into
1947 the sign bit.
1948 * lisp.h (get_random): Change signature to match.
1949
1950 * lread.c (hash_string): Use size_t, not int, for hash computation.
1951 Normally we prefer signed values; but hashing is special, because
1952 it's better to use unsigned division on hash table sizes so that
1953 the remainder is nonnegative. Also, size_t is the natural width
1954 for hashing into memory. The previous code used 'int', which doesn't
1955 retain enough info to hash well into very large tables.
1956 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1957
1958 * dbusbind.c: Don't possibly lose pointer info when converting.
1959 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1960 Use XPNTR rather than XHASH, so that the high-order bits of
1961 the pointer aren't lost when converting through void *.
1962
1963 * eval.c (Fautoload): Don't double-shift a pointer.
1964
1965 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1966
1967 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1968
1969 * gnutls.c (DEF_GNUTLS_FN):
1970 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1971
1972 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1973
1974 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1975 marker. (Bug#8610)
1976
1977 2011-05-05 Eli Zaretskii <eliz@gnu.org>
1978
1979 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1980 New version that can reserve upto 2GB of heap space.
1981
1982 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
1983
1984 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1985
1986 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1987
1988 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1989 `gnutls_certificate_set_x509_key_file'.
1990
1991 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
1992
1993 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1994 Update dependencies.
1995
1996 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1997
1998 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1999 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2000 Remove unused parameter `fildes'.
2001 * process.c (read_process_output, send_process): Don't pass it.
2002
2003 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2004
2005 Fix previous change: the library cache is defined in w32.c.
2006 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2007 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2008
2009 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2010
2011 Implement dynamic loading of GnuTLS on Windows.
2012
2013 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2014 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2015 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2016 Declare.
2017
2018 * gnutls.c (Qgnutls_dll): Define.
2019 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2020 (gnutls_*): Declare function pointers.
2021 (init_gnutls_functions): New function to initialize function pointers.
2022 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2023 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2024 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2025 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2026 (emacs_gnutls_write, emacs_gnutls_read)
2027 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2028 (Fgnutls_available_p): New function.
2029 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2030 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2031 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2032
2033 * image.c: Include w32.h.
2034 (Vimage_type_cache): Delete.
2035 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2036 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2037 (w32_delayed_load): Move to w32.c.
2038
2039 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2040
2041 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2042 (w32_delayed_load): Move from image.c. When loading a library, record
2043 its filename in the :loaded-from property of the library id.
2044 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2045 Initialize and staticpro them.
2046 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2047
2048 * process.c: Include lisp.h before w32.h, not after.
2049 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2050 instead of gnutls_record_check_pending.
2051
2052 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2053
2054 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2055
2056 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2057 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2058 as passed in.
2059
2060 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2061
2062 * xterm.c (x_set_frame_alpha): Do not set property on anything
2063 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2064
2065 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2066
2067 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2068
2069 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2070
2071 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2072 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2073 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2074 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2075 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2076 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2077 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2078 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2079 (Qgnutls_bootprop_callbacks_verify): Make static.
2080
2081 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2082
2083 * callproc.c: Indentation fixup.
2084
2085 * sysdep.c (wait_for_termination_1): Make static.
2086 (wait_for_termination, interruptible_wait_for_termination):
2087 Move after wait_for_termination_1.
2088
2089 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2090
2091 * sysdep.c (interruptible_wait_for_termination): New function
2092 which is like wait_for_termination, but allows keyboard
2093 interruptions.
2094
2095 * callproc.c (Fcall_process): Add (:file "file") as an option for
2096 the STDOUT buffer.
2097 (Fcall_process_region): Ditto.
2098
2099 2011-04-30 Eli Zaretskii <eliz@gnu.org>
2100
2101 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2102 rather than `XVECTOR (FOO)->size'.
2103
2104 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2105 inttypes.h, as a gnulib replacement is used if it not available in
2106 system headers.
2107
2108 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2109
2110 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2111 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2112 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2113
2114 * coding.c (coding_alloc_by_realloc): Error out if destination
2115 will grow beyond MOST_POSITIVE_FIXNUM.
2116 (decode_coding_emacs_mule): Abort if there isn't enough place in
2117 charbuf for the composition carryover bytes. Reserve an extra
2118 space for up to 2 characters produced in a loop.
2119 (decode_coding_iso_2022): Abort if there isn't enough place in
2120 charbuf for the composition carryover bytes.
2121
2122 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2123
2124 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2125 aborting when %lld or %lll format is passed.
2126 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2127 %llo or %llx format is passed. (Bug#8545)
2128
2129 * window.c (window_scroll_line_based): Use a marker instead of
2130 simple variables to record original value of point. (Bug#7952)
2131
2132 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2133 produced by %s or %c overflows available buffer space. (Bug#8545)
2134
2135 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2136
2137 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
2138 (SIZE_MAX): Move defn after all includes, as they might #define it.
2139
2140 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2141
2142 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2143
2144 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2145
2146 * keyboard.c (Qdelayed_warnings_hook): Define.
2147 (command_loop_1): Run `delayed-warnings-hook'
2148 if Vdelayed_warnings_list is non-nil.
2149 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2150 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2151
2152 2011-04-28 Eli Zaretskii <eliz@gnu.org>
2153
2154 * doprnt.c (doprnt): Don't return value smaller than the buffer
2155 size if the message was truncated. (Bug#8545).
2156
2157 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2158
2159 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2160 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2161
2162 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2163
2164 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2165
2166 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
2167
2168 * makefile.w32-in: Update dependencies.
2169
2170 2011-04-27 Eli Zaretskii <eliz@gnu.org>
2171
2172 Improve `doprnt' and its usage. (Bug#8545)
2173 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2174 `format_end'. Remove support for %l as a conversion specifier.
2175 Don't use xrealloc. Improve diagnostics when the %l size modifier
2176 is used. Update the commentary.
2177
2178 * eval.c (verror): Simplify calculation of size_t.
2179
2180 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2181 messages.
2182
2183 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2184
2185 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2186 change.
2187
2188 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2189
2190 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2191 This makes this file independent of the recent pseudovector change.
2192
2193 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
2194
2195 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2196
2197 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
2198 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
2199 Remove unused local.
2200 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
2201
2202 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
2203 GCC 4.6.0 optimizes based on type-based alias analysis.
2204 For example, if b is of type struct buffer * and v of type struct
2205 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2206 != &v->size, and therefore "v->size = 1; b->size = 2; return
2207 v->size;" must therefore return 1. This assumption is incorrect
2208 for Emacs, since it type-puns struct Lisp_Vector * with many other
2209 types. To fix this problem, this patch adds a new type struct
2210 vectorlike_header that documents the constraints on layout of vectors
2211 and pseudovectors, and helps optimizing compilers not get fooled
2212 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2213 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
2214 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2215 the size member.
2216 (XSETPVECTYPE): Rewrite in terms of new macro.
2217 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2218 This is a bit clearer, and further avoids the possibility of
2219 undesirable aliasing.
2220 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
2221 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
2222 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2223 since Lisp_Subr is a special case (no "next" field).
2224 (ASIZE): Now uses header.size rather than size.
2225 All previous uses of XVECTOR (foo)->size replaced to use this macro,
2226 to avoid the hassle of writing XVECTOR (foo)->header.size.
2227 (struct vectorlike_header): New type.
2228 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2229 object, to help avoid aliasing.
2230 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2231 (SUBRP): Likewise, since Lisp_Subr is a special case.
2232 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2233 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2234 (struct Lisp_Hash_Table): Combine first two members into a single
2235 struct vectorlike_header member. All uses of "size" and "next" members
2236 changed to be "header.size" and "header.next".
2237 * buffer.h (struct buffer): Likewise.
2238 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2239 * frame.h (struct frame): Likewise.
2240 * process.h (struct Lisp_Process): Likewise.
2241 * termhooks.h (struct terminal): Likewise.
2242 * window.c (struct save_window_data, struct saved_window): Likewise.
2243 * window.h (struct window): Likewise.
2244 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2245 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2246 * buffer.c (init_buffer_once): Likewise.
2247 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2248 special case.
2249 * process.c (Fformat_network_address): Use local var for size,
2250 for brevity.
2251
2252 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2253
2254 Make the Lisp reader and string-to-float more consistent (Bug#8525)
2255 * data.c (atof): Remove decl; no longer used or needed.
2256 (digit_to_number): Move to lread.c.
2257 (Fstring_to_number): Use new string_to_number function, to be
2258 consistent with how the Lisp reader treats infinities and NaNs.
2259 Do not assume that floating-point numbers represent EMACS_INT
2260 without losing information; this is not true on most 64-bit hosts.
2261 Avoid double-rounding errors, by insisting on integers when
2262 parsing non-base-10 numbers, as the documentation specifies.
2263 * lisp.h (string_to_number): New decl, replacing ...
2264 (isfloat_string): Remove.
2265 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
2266 (read1): Do not accept +. and -. as integers; this
2267 appears to have been a coding error. Similarly, do not accept
2268 strings like +-1e0 as floating point numbers. Do not report
2269 overflow for integer overflows unless the base is not 10 which
2270 means we have no simple and reliable way to continue.
2271 Break out the floating-point parsing into a new
2272 function string_to_number, so that Fstring_to_number parses
2273 floating point numbers consistently with the Lisp reader.
2274 (digit_to_number): Move here from data.c. Make it static inline.
2275 (E_CHAR, EXP_INT): Remove, replacing with ...
2276 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2277 (string_to_number): New function, replacing isfloat_string.
2278 This function checks for valid syntax and produces the resulting
2279 Lisp float number too. Rework it so that string-to-number
2280 no longer mishandles examples like "1.0e+". Use strtoumax,
2281 so that overflow for non-base-10 numbers is reported only when
2282 there's no portable and simple way to convert to floating point.
2283
2284 * textprop.c (set_text_properties_1): Rewrite for clarity,
2285 and to avoid GCC warning about integer overflow.
2286
2287 * intervals.h (struct interval): Use EMACS_INT for members
2288 where EMACS_UINT might cause problems. See
2289 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2290 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2291 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2292 All uses changed.
2293 (offset_intervals): Tell GCC not to worry about length overflow
2294 when negating a negative length.
2295
2296 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2297 (overrun_check_free): Likewise.
2298
2299 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2300 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2301 word size.
2302
2303 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2304 (gnutls_make_error): Rename local to avoid shadowing.
2305 (gnutls_emacs_global_deinit): ifdef out; not used.
2306 (Fgnutls_boot): Use const for pointer to readonly storage.
2307 Comment out unused local. Fix pointer signedness problems.
2308
2309 * lread.c (openp): Don't stuff size_t into an 'int'.
2310 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2311 about possible signed overflow.
2312
2313 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2314 (GDK_KEY_g): Don't define if already defined.
2315 (xg_prepare_tooltip): Avoid pointer signedness problem.
2316 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2317
2318 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2319 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2320
2321 * xfns.c (Fx_window_property): Simplify a bit,
2322 to make a bit faster and to avoid GCC 4.6.0 warning.
2323 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2324
2325 * fns.c (internal_equal): Don't assume size_t fits in int.
2326
2327 * alloc.c (compact_small_strings): Tighten assertion a little.
2328
2329 Replace pEd with more-general pI, and fix some printf arg casts.
2330 * lisp.h (pI): New macro, generalizing old pEd macro to other
2331 conversion specifiers. For example, use "...%"pI"d..." rather
2332 than "...%"pEd"...".
2333 (pEd): Remove. All uses replaced with similar uses of pI.
2334 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2335 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2336 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2337 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2338 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2339 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2340 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2341 64-bit hosts.
2342 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2343 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2344 * print.c (safe_debug_print, print_object): Likewise.
2345 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2346 to int.
2347 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2348 avoiding the 0 flag, which is not portable.
2349 * process.c (Fmake_network_process): Use pI to avoid cast.
2350 * region-cache.c (pp_cache): Likewise.
2351 * xdisp.c (decode_mode_spec): Likewise.
2352 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2353 behavior on 64-bit hosts with printf arg.
2354 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2355 (x_stop_queuing_selection_requests): Likewise.
2356 (x_get_window_property): Don't truncate byte count to an 'int'
2357 when tracing.
2358
2359 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2360 here, since it parses constructs like leading '-' and spaces,
2361 which are not wanted; and it overflows with large numbers.
2362 Instead, simply match F[0-9]+, which is what is wanted anyway.
2363
2364 * alloc.c: Remove unportable assumptions about struct layout.
2365 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2366 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2367 (allocate_vectorlike, make_pure_vector): Use the new macros,
2368 plus offsetof, to remove unportable assumptions about struct layout.
2369 These assumptions hold on all porting targets that I know of, but
2370 they are not guaranteed, they're easy to remove, and removing them
2371 makes further changes easier.
2372
2373 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2374 This doesn't fix a bug but makes the code clearer.
2375 (string_overrun_cookie): Now const. Use initializers that
2376 don't formally overflow signed char, to avoid warnings.
2377 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2378 can cause Emacs to crash when string overrun checking is enabled.
2379 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2380 multiple of sizeof (EMACS_INT); it need not be, if
2381 alignof(EMACS_INT) < sizeof (EMACS_INT).
2382 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2383
2384 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2385
2386 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2387
2388 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2389
2390 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2391 supposed to be handshaking. (Bug#8556)
2392 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2393
2394 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2395
2396 * lisp.h (Qdebug): List symbol.
2397 * eval.c (Qdebug): Restore global linkage.
2398 * keyboard.c (debug-on-event): New variable.
2399 (handle_user_signal): Break into debugger when debug-on-event
2400 matches the current signal symbol.
2401
2402 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2403
2404 * alloc.c (check_sblock, check_string_bytes)
2405 (check_string_free_list): Convert to standard C.
2406
2407 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2408
2409 * w32.c (emacs_gnutls_push): Fix typo.
2410
2411 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2412
2413 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2414 "cast to pointer from integer of different size".
2415
2416 Improve doprnt and its use in verror. (Bug#8545)
2417 * doprnt.c (doprnt): Document the set of format control sequences
2418 supported by the function. Use SAFE_ALLOCA instead of always
2419 using `alloca'.
2420
2421 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2422 is one byte too soon. Don't use xrealloc; instead xfree and
2423 xmalloc anew.
2424
2425 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2426
2427 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2428 callbacks stage.
2429
2430 * gnutls.c: Renamed global_initialized to
2431 gnutls_global_initialized. Added internals for the
2432 :verify-hostname-error, :verify-error, and :verify-flags
2433 parameters of `gnutls-boot' and documented those parameters in the
2434 docstring. Start callback support.
2435 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2436 unless a fatal error occured. Call gnutls_alert_send_appropriate
2437 on error. Return error code.
2438 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2439 (emacs_gnutls_read): Likewise.
2440 (Fgnutls_boot): Return handshake error code.
2441 (emacs_gnutls_handle_error): New function.
2442 (wsaerror_to_errno): Likewise.
2443
2444 * w32.h (emacs_gnutls_pull): Add prototype.
2445 (emacs_gnutls_push): Likewise.
2446
2447 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2448 (emacs_gnutls_push): Likewise.
2449
2450 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2451
2452 * process.c (wait_reading_process_output): Check if GnuTLS
2453 buffered some data internally if no FDs are set for TLS
2454 connections.
2455
2456 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2457 (LIBS): Link to USER_LIBS.
2458 ($(BLD)/gnutls.$(0)): New target.
2459
2460 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2461
2462 * xdisp.c (handle_single_display_spec): Rename the
2463 display_replaced_before_p argument into display_replaced_p, to
2464 make it consistent with the commentary. Fix typos in the
2465 commentary.
2466
2467 * textprop.c (syms_of_textprop): Remove dead code.
2468 (copy_text_properties): Delete obsolete commentary about an
2469 interface that was deleted long ago. Fix typos in the description
2470 of arguments.
2471
2472 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2473 to changes in oldXMenu/XMenu.h from 2011-04-16.
2474 <menu_help_message, prev_menu_help_message>: Constify.
2475 (IT_menu_make_room): menu->help_text is now `const char **';
2476 adjust.
2477
2478 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2479 to changes in oldXMenu/XMenu.h from 2011-04-16.
2480 (struct XMenu): Declare `help_text' `const char **'.
2481
2482 * xfaces.c <Qunspecified>: Make extern again.
2483
2484 * syntax.c: Include sys/types.h before including regex.h, as
2485 required by Posix.
2486
2487 * doc.c (get_doc_string): Improve the format passed to `error'.
2488
2489 * doprnt.c (doprnt): Improve commentary.
2490
2491 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2492
2493 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2494 them with etags.
2495
2496 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2497 changes in globals.h immediately force recompilation.
2498 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2499 $(CURDIR)/s/ms-w32.h.
2500 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2501
2502 * character.c (Fchar_direction): Function deleted.
2503 (syms_of_character): Don't defsubr it.
2504 <char-direction-table>: Deleted.
2505
2506 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2507
2508 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2509 * doprnt.c: Include limits.h.
2510 (SIZE_MAX): New macro.
2511 (doprnt): Return a size_t value. 2nd arg is now size_t.
2512 Many local variables are now size_t instead of int or unsigned.
2513 Improve overflow protection. Support `l' modifier for integer
2514 conversions. Support %l conversion. Don't assume an EMACS_INT
2515 argument for integer conversions and for %c.
2516
2517 * lisp.h (doprnt): Restore prototype.
2518
2519 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2520 $(SRC)/character.h.
2521
2522 * Makefile.in (base_obj): Add back doprnt.o.
2523
2524 * deps.mk (doprnt.o): Add back prerequisites.
2525 (callint.o): Depend on character.h.
2526
2527 * eval.c (internal_lisp_condition_case): Include the handler
2528 representation in the error message.
2529 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2530 when breaking from the loop.
2531
2532 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2533
2534 * callint.c (Fcall_interactively): When displaying error message
2535 about invalid control letter, pass the character's codepoint, not
2536 a pointer to its multibyte form. Improve display of the character
2537 in octal and display also its hex code.
2538
2539 * character.c (char_string): Use %x to display the (unsigned)
2540 codepoint of an invalid character, to avoid displaying a bogus
2541 negative value.
2542
2543 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2544 `error', not SYMBOL_NAME itself.
2545
2546 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2547 character arguments to `error'.
2548
2549 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2550 to `error' in error message about FINAL_CHAR argument. Make sure
2551 FINAL_CHAR is a character, and use %c when it is passed as
2552 argument to `error'.
2553
2554 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2555
2556 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2557
2558 * w32.c: Include <time.h>.
2559 (sys_localtime): New function.
2560
2561 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
2562
2563 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2564
2565 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
2566
2567 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
2568
2569 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2570 zombies (Bug#8467).
2571
2572 2011-04-19 Eli Zaretskii <eliz@gnu.org>
2573
2574 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2575 gl_state.e_property when gl_state.object is Qt.
2576
2577 * insdel.c (make_gap_larger): Remove limitation of buffer size
2578 to <= INT_MAX.
2579
2580 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
2581
2582 * xdisp.c (lookup_glyphless_char_display)
2583 (produce_glyphless_glyph): Handle cons cell entry in
2584 glyphless-char-display.
2585 (Vglyphless_char_display): Document it.
2586
2587 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2588 glyphless-char-display.
2589
2590 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
2591
2592 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2593
2594 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2595
2596 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2597 definition for no-X builds.
2598
2599 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
2600
2601 Static checks with GCC 4.6.0 and non-default toolkits.
2602
2603 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2604
2605 * process.c (keyboard_bit_set): Define only if SIGIO.
2606 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2607 (send_process): Repair possible setjmp clobbering.
2608
2609 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2610
2611 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2612
2613 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2614
2615 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2616 Define only if needed.
2617
2618 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2619 by pacifying GCC about it. Maybe it's time to retire it?
2620 * xfaces.c (USG, __TIMEVAL__): Likewise.
2621
2622 * dispextern.h (struct redisplay_interface): Rename param
2623 to avoid shadowing.
2624 * termhooks.h (struct terminal): Likewise.
2625 * xterm.c (xembed_send_message): Likewise.
2626
2627 * insdel.c (make_gap_smaller): Define only if
2628 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2629
2630 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2631 it.
2632
2633 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2634 so that we aren't warned about unused symbols.
2635
2636 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2637
2638 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
2639
2640 * xfns.c (x_real_positions): Mark locals as initialized.
2641
2642 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2643
2644 * xterm.c: Fix problems found by static analysis with other toolkits.
2645 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
2646 (x_dispatch_event): Declare static if USE_GTK, and
2647 define if USE_GTK || USE_X_TOOLKIT.
2648 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
2649 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
2650 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2651 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
2652
2653 * xmenu.c (menu_help_callback): Pointer type fixes.
2654 Use const pointers when pointing at readonly data. Avoid pointer
2655 signedness clashes.
2656 (FALSE): Remove unused macro.
2657 (update_frame_menubar): Remove unused decl.
2658
2659 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2660
2661 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2662 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2663 (single_menu_item): Rename local to avoid shadowing.
2664
2665 * keyboard.c (make_lispy_event): Remove unused local var.
2666
2667 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2668 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2669
2670 * bitmaps: Change bitmaps from unsigned char back to the X11
2671 compatible char. Avoid the old compiler warnings about
2672 out-of-range initializers by using, for example, '\xab' rather
2673 than 0xab.
2674
2675 * xgselect.c (xgselect_initialize): Check vs interface
2676 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2677
2678 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2679
2680 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2681 to read-only memory.
2682
2683 * fns.c (vector): Remove; this old hack is no longer needed.
2684
2685 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
2686 Remove unused var.
2687 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2688
2689 * xrdb.c (x_load_resources): Omit unused local.
2690
2691 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
2692 (x_window): Rename locals to avoid shadowing.
2693 (USG): Use the kludged USG macro, to pacify gcc.
2694
2695 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
2696 (x_term_init): Remove local to avoid shadowing.
2697
2698 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
2699
2700 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2701 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2702
2703 2011-04-16 Eli Zaretskii <eliz@gnu.org>
2704
2705 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2706
2707 Fix regex.c, syntax.c and friends for buffers > 2GB.
2708 * syntax.h (struct gl_state_s): Declare character position members
2709 EMACS_INT.
2710
2711 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2712
2713 * textprop.c (verify_interval_modification, interval_of):
2714 Declare arguments EMACS_INT.
2715
2716 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2717 EMACS_INT.
2718
2719 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2720
2721 * indent.c (Fvertical_motion): Local variable it_start is now
2722 EMACS_INT.
2723
2724 * regex.c (re_match, re_match_2, re_match_2_internal)
2725 (bcmp_translate, regcomp, regexec, print_double_string)
2726 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2727 (re_compile_pattern, re_exec): Declare arguments and local
2728 variables `size_t' and `ssize_t' and return values `regoff_t', as
2729 appropriate.
2730 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2731 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2732 <compile_stack_type>: `size' and `avail' are now `size_t'.
2733
2734 * regex.h <regoff_t>: Use ssize_t, not int.
2735 (re_search, re_search_2, re_match, re_match_2): Arguments that
2736 specify buffer/string position and length are now ssize_t and
2737 size_t. Return type is regoff_t.
2738
2739 2011-04-16 Ben Key <bkey76@gmail.com>
2740
2741 * nsfont.m: Fixed bugs in ns_get_family and
2742 ns_descriptor_to_entity that were caused by using free to
2743 deallocate memory blocks that were allocated by xmalloc (via
2744 xstrdup). This caused Emacs to crash when compiled with
2745 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2746 --enable-checking=xmallocoverrun). xfree is now used to
2747 deallocate these memory blocks.
2748
2749 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
2750
2751 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2752
2753 emacs_write: Accept and return EMACS_INT for sizes.
2754 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2755 et seq.
2756 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2757 Accept and return EMACS_INT.
2758 (emacs_gnutls_write): Return the number of bytes written on
2759 partial writes.
2760 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
2761 (emacs_read, emacs_write): Remove check for negative size, as the
2762 Emacs source code has been audited now.
2763 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2764 (emacs_read, emacs_write): Use it.
2765 * process.c (send_process): Adjust to the new signatures of
2766 emacs_write and emacs_gnutls_write. Do not attempt to store
2767 a byte offset into an 'int'; it might overflow.
2768 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
2769
2770 * sound.c: Don't assume sizes fit in 'int'.
2771 (struct sound_device.period_size, alsa_period_size):
2772 Return EMACS_INT, not int.
2773 (struct sound_device.write, vox_write, alsa_write):
2774 Accept EMACS_INT, not int.
2775 (wav_play, au_play): Use EMACS_INT to store sizes and to
2776 record read return values.
2777
2778 2011-04-15 Ben Key <bkey76@gmail.com>
2779
2780 * keyboard.c (Qundefined): Don't declare static since it is used
2781 in nsfns.m.
2782 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2783 static since they are used in nsfont.m.
2784
2785 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2786
2787 * process.c (Qprocessp): Don't declare static.
2788 * lisp.h (Qprocessp): Declare again.
2789
2790 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
2791
2792 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2793
2794 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2795
2796 Improve C-level modularity by making more things 'static'.
2797
2798 Don't publish debugger-only interfaces to other modules.
2799 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2800 (verify_bytepos, count_markers): Move decls to the only modules
2801 that need them.
2802 * region-cache.h (pp_cache): Likewise.
2803 * window.h (check_all_windows): Likewise.
2804 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2805
2806 * sysdep.c (croak): Now static, if
2807 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2808 * syssignal.h (croak): Declare only if not static.
2809
2810 * alloc.c (refill_memory_reserve): Now static if
2811 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2812 * lisp.h (refill_memory_reserve): Declare only if not static.
2813
2814 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2815 Define only if USE_LUCID.
2816
2817 * xrdb.c (x_customization_string, x_rm_string): Now static.
2818
2819 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2820 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2821
2822 * xdisp.c (draw_row_with_mouse_face): Now static.
2823 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2824
2825 * window.h (check_all_windows): Mark externally visible.
2826
2827 * window.c (window_deletion_count): Now static.
2828
2829 * undo.c: Make symbols static if they're not exported.
2830 (last_undo_buffer, last_boundary_position, pending_boundary):
2831 Now static.
2832
2833 * textprop.c (interval_insert_behind_hooks): Now static.
2834 (interval_insert_in_front_hooks): Likewise.
2835
2836 * term.c: Make symbols static if they're not exported.
2837 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2838 (max_frame_lines, tty_set_terminal_modes):
2839 (tty_reset_terminal_modes, tty_turn_off_highlight):
2840 (get_tty_terminal): Now static.
2841 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2842 * termhooks.h (term_mouse_moveto): Do not declare if
2843 HAVE_WINDOW_SYSTEM.
2844 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2845 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2846
2847 * sysdep.c: Make symbols static if they're not exported.
2848 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2849 Now static.
2850 (sigprocmask_set, full_mask): Remove; unused.
2851 (wait_debugging): Mark as visible.
2852 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2853 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2854
2855 * syntax.c (syntax_temp): Define only if !__GNUC__.
2856
2857 * sound.c (current_sound_device, current_sound): Now static.
2858
2859 * search.c (searchbufs, searchbuf_head): Now static.
2860
2861 * scroll.c (scroll_cost): Remove; unused.
2862 * dispextern.h (scroll_cost): Remove decl.
2863
2864 * region-cache.h (pp_cache): Mark as externally visible.
2865
2866 * process.c: Make symbols static if they're not exported.
2867 (process_tick, update_tick, create_process, chan_process):
2868 (Vprocess_alist, proc_buffered_char, datagram_access):
2869 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2870 (deactivate_process): Mark defn as static, as well as decl.
2871 * lisp.h (create_process): Remove decl.
2872 * process.h (chan_process, Vprocess_alist): Remove decls.
2873
2874 * print.c: Make symbols static if they're not exported.
2875 (print_depth, new_backquote_output, being_printed, print_buffer):
2876 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2877 (print_interval, print_number_index, initial_stderr_stream):
2878 Now static.
2879 * lisp.h (Fprinc): Remove decl.
2880 (debug_output_compilation_hack): Mark as externally visible.
2881
2882 * sysdep.c (croak): Move decl from here to syssignal.h.
2883 * syssignal.h (croak): Put it here, so the API can be checked when
2884 'croak' is called from dissociate_if_controlling_tty.
2885
2886 * minibuf.c: Make symbols static if they're not exported.
2887 (minibuf_save_list, choose_minibuf_frame): Now static.
2888 * lisp.h (choose_minibuf_frame): Remove decl.
2889
2890 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2891
2892 * lread.c: Make symbols static if they're not exported.
2893 (read_objects, initial_obarray, oblookup_last_bucket_number):
2894 Now static.
2895 (make_symbol): Remove; unused.
2896 * lisp.h (initial_obarray, make_symbol): Remove decls.
2897
2898 * keyboard.c: Make symbols static if they're not exported.
2899 (single_kboard, recent_keys_index, total_keys, recent_keys):
2900 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2901 (this_single_command_key_start, echoing, last_auto_save):
2902 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2903 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2904 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2905 (Vlispy_mouse_stem, double_click_count):
2906 Now static.
2907 (force_auto_save_soon): Define only if SIGDANGER.
2908 (ignore_mouse_drag_p): Now static if
2909 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2910 (print_help): Remove; unused.
2911 (stop_character, last_timer_event): Mark as externally visible.
2912 * keyboard.h (ignore_mouse_drag_p): Declare only if
2913 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2914 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2915 * lisp.h (echoing): Remove decl.
2916 (force_auto_save_soon): Declare only if SIGDANGER.
2917 * xdisp.c (redisplay_window): Simplify code, to make it more
2918 obvious that ignore_mouse_drag_p is not accessed if !defined
2919 USE_GTK && !defined HAVE_NS.
2920
2921 * intervals.c: Make symbols static if they're not exported.
2922 (merge_properties_sticky, merge_interval_right, delete_interval):
2923 Now static.
2924 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2925
2926 * insdel.c: Make symbols static if they're not exported.
2927 However, leave prepare_to_modify_buffer alone. It's never
2928 called from outside this function, but that appears to be a bug.
2929 (combine_after_change_list, combine_after_change_buffer):
2930 (adjust_after_replace, signal_before_change): Now static.
2931 (adjust_after_replace_noundo): Remove; unused.
2932 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
2933 (signal_before_change): Remove decls.
2934
2935 * indent.c (val_compute_motion, val_vmotion): Now static.
2936
2937 * image.c: Make symbols static if they're not exported.
2938 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2939 if USE_GTK.
2940 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2941 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2942
2943 * fringe.c (standard_bitmaps): Now static.
2944 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2945
2946 * frame.c: Make symbols static if they're not exported.
2947 (x_report_frame_params, make_terminal_frame): Now static.
2948 (get_frame_param): Now static, unless HAVE_NS.
2949 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2950 (x_get_resource_string): Remove; not used.
2951 * frame.h (make_terminal_frame, x_report_frame_params):
2952 (x_get_resource_string); Remove decls.
2953 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2954 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2955
2956 * font.c, fontset.c: Make symbols static if they're not exported.
2957 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2958 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2959 * font.c (font_close_object): Now static.
2960 * font.h (font_close_object): Remove.
2961 * fontset.c (FONTSET_OBJLIST): Remove.
2962 (free_realized_fontset) #if-0 the body, which does nothing.
2963 (face_suitable_for_char_p): #if-0, as it's never called.
2964 * fontset.h (face_suitable_for_char_p): Remove decl.
2965 * xfaces.c (face_at_string_position):
2966 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
2967 since 0 is always ASCII.
2968
2969 * fns.c (weak_hash_tables): Now static.
2970
2971 * fileio.c: Make symbols static if they're not exported.
2972 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2973 (Vwrite_region_annotation_buffers): Now static.
2974
2975 * eval.c: Make symbols static if they're not exported.
2976 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2977 * lisp.h (backtrace_list): Remove decl.
2978
2979 * emacs.c: Make symbols static if they're not exported.
2980 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2981 (fatal_error_code, fatal_error_signal_hook, standard_args):
2982 Now static.
2983 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2984 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2985 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2986 * lisp.h (fatal_error_signal_hook): Remove decl.
2987 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2988
2989 * editfns.c: Move a (normally-unused) function to its only use.
2990 * editfns.c, lisp.h (get_operating_system_release): Remove.
2991 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2992 worth the hassle of breaking this out.
2993
2994 * xterm.c: Make symbols static if they're not exported.
2995 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2996 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2997 (x_destroy_window, x_delete_display):
2998 Now static.
2999 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3000 (x_mouse_leave): Remove; unused.
3001 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3002 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3003 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3004 Remove decls.
3005 (x_mouse_leave): Declare only if WINDOWSNT.
3006 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3007 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3008 USE_X_TOOLKIT.
3009
3010 * ftxfont.c: Make symbols static if they're not exported.
3011 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3012 HAVE_FREETYPE.
3013 * font.h (ftxfont_driver): Likewise.
3014
3015 * xfns.c: Make symbols static if they're not exported.
3016 (x_last_font_name, x_display_info_for_name):
3017 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3018 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3019 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3020 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3021 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3022 (last_show_tip_args): Now static.
3023 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3024 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3025 (x_screen_planes): Remove; unused.
3026 * dispextern.h (x_screen_planes): Remove decl.
3027
3028 * dispnew.c: Make symbols static if they're not exported.
3029 * dispextern.h (redraw_garbaged_frames, scrolling):
3030 (increment_row_positions): Remove.
3031 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3032 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3033 Now static.
3034 (redraw_garbaged_frames): Remove; unused.
3035
3036 * xfaces.c: Make symbols static if they're not exported.
3037 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3038 Remove decls.
3039 * xterm.h (defined_color): Remove decls.
3040 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3041 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3042 (menu_face_changed_default, defined_color, free_realized_face):
3043 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3044 (ascii_face_of_lisp_face): Remove; unused.
3045
3046 * xdisp.c: Make symbols static if they're not exported.
3047 * dispextern.h (scratch_glyph_row, window_box_edges):
3048 (glyph_to_pixel_coords, set_cursor_from_row):
3049 (get_next_display_element, set_iterator_to_next):
3050 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3051 (show_mouse_face): Remove decls
3052 * frame.h (message_buf_print): Likewise.
3053 * lisp.h (pop_message, set_message, check_point_in_composition):
3054 Likewise.
3055 * xterm.h (set_vertical_scroll_bar): Likewise.
3056 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3057 (message_buf_print, scratch_glyph_row, displayed_buffer):
3058 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3059 (get_next_display_element, show_mouse_face, window_box_edges):
3060 (frame_to_window_pixel_xy, check_point_in_composition):
3061 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3062 (glyph_to_pixel_coords): Remove; unused.
3063
3064 * dired.c (file_name_completion): Now static.
3065
3066 * dbusbind.c (xd_in_read_queued_messages): Now static.
3067
3068 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3069 * data.c (circular_list_error): Remove.
3070
3071 * commands.h (last_point_position, last_point_position_buffer):
3072 (last_point_position_window): Remove decls.
3073 * keyboard.c: Make these variables static.
3074
3075 * coding.h (coding, code_convert_region, encode_coding_gap):
3076 Remove decls.
3077 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3078 (iso_code_class, detect_coding, code_convert_region): Now static.
3079 (encode_coding_gap): Remove; unused.
3080
3081 * chartab.c (chartab_chars, chartab_bits): Now static.
3082
3083 * charset.h (charset_iso_8859_1): Remove decl.
3084 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3085 Now static.
3086
3087 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3088 * ccl.c (Vccl_program_table): Now static.
3089 (check_ccl_update): Remove; unused.
3090
3091 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3092 * category.h: ... from here.
3093 * category.c (check_category_table, set_category_set): Now static.
3094
3095 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3096 * lisp.h: Remove these decls.
3097
3098 * buffer.c (buffer_count): Remove unused var.
3099
3100 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3101 so that it's not optimized away.
3102 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3103 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3104 exported only to the debugger.
3105
3106 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
3107 * atimer.h (run_all_atimers): Remove; not exported.
3108
3109 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3110 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3111 was inaccessible from Lisp.
3112 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3113 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3114
3115 alloc.c: Import and export fewer symbols, and remove unused items.
3116 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3117 is defined.
3118 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3119 it's not optimized away by whole-program optimization.
3120 (message_enable_multibyte, free_misc): Remove.
3121 (catchlist, handlerlist, mark_backtrace):
3122 Declare only if BYTE_MARK_STACK.
3123 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3124 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3125 (message_enable_multibyte): Remove decl.
3126 (free_misc, interval_free_list, float_block, float_block_index):
3127 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3128 (cons_free_list, last_marked_index):
3129 Now static.
3130 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3131 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3132 (mark_backtrace): Define only if BYTE_MARK_STACK.
3133 * xdisp.c (message_enable_multibyte): Now static.
3134
3135 Declare Lisp_Object Q* variables to be 'static' if not exported.
3136 This makes it easier for human readers (and static analyzers)
3137 to see whether these variables are used from other modules.
3138 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3139 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3140 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3141 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3142 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3143 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3144 * xmenu.c, xselect.c:
3145 Declare Q* vars static if they are not used in other modules.
3146 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3147 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3148 Remove decls of unexported vars.
3149 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3150
3151 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3152
3153 Make Emacs functions such as Fatom 'static' by default.
3154 This makes it easier for human readers (and static analyzers)
3155 to see whether these functions can be called from other modules.
3156 DEFUN now defines a static function. To make the function external
3157 so that it can be used in other C modules, use the new macro DEFUE.
3158 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3159 (Finit_image_library):
3160 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3161 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3162 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3163 Remove decls, since these functions are now static.
3164 (Funintern, Fget_internal_run_time): New decls, since these functions
3165 were already external.
3166
3167 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3168 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3169 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3170 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3171 * keyboard.c, keymap.c, lread.c:
3172 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3173 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3174 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3175 Mark functions with DEFUE instead of DEFUN,
3176 if they are used in other modules.
3177 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3178 decls for now-static functions.
3179 * buffer.h (Fdelete_overlay): Remove decl.
3180 * callproc.c (Fgetenv_internal): Mark as internal.
3181 * composite.c (Fremove_list_of_text_properties): Remove decl.
3182 (Fcomposition_get_gstring): New forward static decl.
3183 * composite.h (Fcomposite_get_gstring): Remove decl.
3184 * dired.c (Ffile_attributes): New forward static decl.
3185 * doc.c (Fdocumntation_property): New forward static decl.
3186 * eval.c (Ffetch_bytecode): New forward static decl.
3187 (Funintern): Remove extern decl; now in .h file where it belongs.
3188 * fileio.c (Fmake_symbolic_link): New forward static decl.
3189 * image.c (Finit_image_library): New forward static decl.
3190 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3191 * intervals.h (Fprevious_property_change):
3192 (Fremove_list_of_text_properties): Remove decls.
3193 * keyboard.c (Fthis_command_keys): Remove decl.
3194 (Fcommand_execute): New forward static decl.
3195 * keymap.c (Flookup_key): New forward static decl.
3196 (Fcopy_keymap): Now static.
3197 * keymap.h (Flookup_key): Remove decl.
3198 * process.c (Fget_process): New forward static decl.
3199 (Fprocess_datagram_address): Mark as internal.
3200 * syntax.c (Fsyntax_table_p): New forward static decl.
3201 (skip_chars): Remove duplicate decl.
3202 * textprop.c (Fprevious_property_change): New forward static decl.
3203 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3204 Now internal.
3205 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3206 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3207
3208 * editfns.c (Fformat): Remove unreachable code.
3209
3210 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3211
3212 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3213 change. (Bug#8496)
3214
3215 2011-04-13 Eli Zaretskii <eliz@gnu.org>
3216
3217 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3218 when at ZV. (Bug#8487)
3219
3220 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3221
3222 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3223 (Bug#8437)
3224 * keyboard.c (parse_tool_bar_item): Likewise.
3225 * sound.c (sound_cleanup, alsa_close): Likewise.
3226 * termcap.c (tgetent): Likewise.
3227 * xfns.c (x_default_font_parameter): Likewise.
3228 * xsettings.c (read_and_apply_settings): Likewise.
3229
3230 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3231 (overrun_check_free): Protoize.
3232
3233 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3234
3235 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3236 since callers should never pass a negative size.
3237 Change the signature to match that of plain 'read' and 'write'; see
3238 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3239 * lisp.h: Update prototypes of emacs_write and emacs_read.
3240
3241 2011-04-11 Eli Zaretskii <eliz@gnu.org>
3242
3243 * xdisp.c (redisplay_window): Don't try to determine the character
3244 position of the scroll margin if the window start point w->startp
3245 is outside the buffer's accessible region. (Bug#8468)
3246
3247 2011-04-10 Eli Zaretskii <eliz@gnu.org>
3248
3249 Fix write-region and its subroutines for buffers > 2GB.
3250 * fileio.c (a_write, e_write): Modify declaration of arguments and
3251 local variables to support buffers larger than 2GB.
3252 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3253
3254 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3255 argument, local variables, and return value.
3256
3257 * lisp.h: Update prototypes of emacs_write and emacs_read.
3258
3259 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3260
3261 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
3262
3263 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3264
3265 Fix more problems found by GCC 4.6.0's static checks.
3266
3267 * xdisp.c (vmessage): Use a better test for character truncation.
3268
3269 * charset.c (load_charset_map): <, not <=, for optimization,
3270 and to avoid potential problems with integer overflow.
3271 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
3272 * casetab.c (set_identity, shuffle): Likewise.
3273 * editfns.c (Fformat): Likewise.
3274 * syntax.c (skip_chars): Likewise.
3275
3276 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3277 This also lets GCC 4.6.0 generate slightly better loop code.
3278
3279 * callint.c (Fcall_interactively): <, not <=, for optimization.
3280 (Fcall_interactively): Count the number of arguments produced,
3281 not the number of arguments given. This is simpler and lets GCC
3282 4.6.0 generate slightly better code.
3283
3284 * ftfont.c: Distingish more carefully between FcChar8 and char.
3285 The previous code passed unsigned char * to a functions like
3286 strlen and xstrcasecmp that expect char *, which does not
3287 conform to the C standard.
3288 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3289 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3290 char * when the C standard requires it.
3291
3292 * keyboard.c (read_char): Remove unused var.
3293
3294 * eval.c: Port to Windows vsnprintf (Bug#8435).
3295 Include <limits.h>.
3296 (SIZE_MAX): Define if the headers do not.
3297 (verror): Do not give up if vsnprintf returns a negative count.
3298 Instead, grow the buffer. This ports to Windows vsnprintf, which
3299 does not conform to C99. Problem reported by Eli Zaretskii.
3300 Also, simplify the allocation scheme, by avoiding the need for
3301 calling realloc, and removing the ALLOCATED variable.
3302
3303 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3304
3305 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3306 But keep the doprint source code for now, as we might revamp it
3307 and use it again (Bug#8435).
3308 * lisp.h (doprnt): Remove.
3309 * Makefile.in (base_obj): Remove doprnt.o.
3310 * deps.mk (doprnt.o): Remove.
3311
3312 error: Print 32- and 64-bit integers portably (Bug#8435).
3313 Without this change, on typical 64-bit hosts error ("...%d...", N)
3314 was used to print both 32- and 64-bit integers N, which relied on
3315 undefined behavior.
3316 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3317 New macro.
3318 * lisp.h (error, verror): Mark as printf-like functions.
3319 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3320 Report overflow in size calculations when allocating printf buffer.
3321 Do not truncate output string at its first null byte.
3322 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3323 Truncate the output at a character boundary, since vsnprintf does not
3324 do that.
3325 * charset.c (check_iso_charset_parameter): Convert internal
3326 character to string before calling 'error', since %c now has the
3327 printf meaning.
3328 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3329 overflow when computing char to be passed to 'error'. Do not
3330 pass Lisp_Object to 'error'; pass the integer instead.
3331 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3332 formatted with plain %d.
3333
3334 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3335
3336 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3337
3338 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3339
3340 * xterm.c (x_catch_errors): Remove duplicate declaration.
3341
3342 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3343
3344 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3345
3346 2011-04-10 Jim Meyering <meyering@redhat.com>
3347
3348 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3349 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3350 return ssize_t not "int", and use size_t as the buffer length.
3351 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3352 * gnutls.h: Update declarations.
3353 * process.c (read_process_output): Use ssize_t, to match.
3354 (send_process): Likewise.
3355
3356 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3357
3358 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3359
3360 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3361
3362 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3363 Use unsigned char, to match FcChar8 type definition.
3364
3365 * xterm.c (handle_one_xevent):
3366 * xmenu.c (create_and_show_popup_menu):
3367 * xselect.c (x_decline_selection_request)
3368 (x_reply_selection_request): Avoid type-punned deref of X events.
3369
3370 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3371
3372 Fix some uses of `int' instead of EMACS_INT.
3373 * search.c (string_match_1, fast_string_match)
3374 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3375 (scan_buffer, find_next_newline_no_quit)
3376 (find_before_next_newline, search_command, Freplace_match)
3377 (Fmatch_data): Make some `int' variables be EMACS_INT.
3378
3379 * xdisp.c (display_count_lines): 3rd argument and return value now
3380 EMACS_INT. All callers changed.
3381 (pint2hrstr): Last argument is now EMACS_INT.
3382
3383 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3384 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3385 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3386 (decode_coding_utf_16, decode_coding_emacs_mule)
3387 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3388 (decode_coding_ccl, decode_coding_charset)
3389 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3390 (decode_coding_iso_2022, decode_coding_emacs_mule)
3391 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3392 <char_offset, last_offset>: Declare EMACS_INT.
3393 (encode_coding_utf_8, encode_coding_utf_16)
3394 (encode_coding_emacs_mule, encode_invocation_designation)
3395 (encode_designation_at_bol, encode_coding_iso_2022)
3396 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3397 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3398 Declare EMACS_INT.
3399 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3400 (encode_invocation_designation): Last argument P_NCHARS is now
3401 EMACS_INT.
3402 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3403 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3404
3405 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3406 All users changed.
3407
3408 * ccl.c (Fccl_execute_on_string): Declare some variables
3409 EMACS_INT.
3410
3411 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3412
3413 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3414
3415 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3416
3417 * process.c (Fformat_network_address): Doc fix.
3418
3419 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3420
3421 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3422
3423 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3424
3425 * keyboard.c (read_char): Call Lisp function help-form-show,
3426 instead of using internal_with_output_to_temp_buffer.
3427 (Qhelp_form_show): New var.
3428 (syms_of_keyboard): Use DEFSYM macro.
3429
3430 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3431
3432 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3433
3434 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3435
3436 * process.c (Flist_processes): Remove to Lisp.
3437 (list_processes_1): Delete.
3438
3439 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3440
3441 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3442
3443 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3444
3445 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3446
3447 Fix more problems found by GCC 4.6.0's static checks.
3448
3449 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3450
3451 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3452
3453 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3454
3455 * xdisp.c (vmessage): Mark as a printf-like function.
3456
3457 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3458
3459 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3460
3461 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3462 printf-like functions.
3463 (tiff_load): Add casts to remove these marks before passing them
3464 to system-supplied API.
3465
3466 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3467
3468 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3469 This avoids several warnings with gcc -Wstrict-overflow.
3470 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3471 directly, rather than having caller test rule sign. This avoids
3472 some unnecessary tests.
3473 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3474 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3475 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3476
3477 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3478 (xfont_open): Avoid unnecessary tests.
3479
3480 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3481
3482 * composite.h, composite.c (composition_gstring_put_cache):
3483 Use EMACS_INT, not int, for length.
3484
3485 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3486 breaking out part of COMPOSITION_DECODE_RULE.
3487 (COMPOSITION_DECODE_RULE): Use it.
3488 * composite.c (get_composition_id): Remove unused local vars,
3489 by using the new macro.
3490
3491 * textprop.c (set_text_properties_1): Change while to do-while,
3492 since the condition is always true at first.
3493
3494 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3495 (interval_deletion_adjustment): Return unsigned value.
3496 All uses changed.
3497
3498 * process.c (list_processes_1, create_pty, read_process_output):
3499 (exec_sentinel): Remove vars that were set but not used.
3500 (create_pty): Remove unnecessary "volatile"s.
3501 (Fnetwork_interface_info): Avoid possibility of int overflow.
3502 (read_process_output): Do adaptive read buffering even if carryover.
3503 (read_process_output): Simplify nbytes computation if buffered.
3504
3505 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3506
3507 * syntax.c (scan_words): Remove var that was set but not used.
3508 (update_syntax_table): Use unsigned instead of int.
3509
3510 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3511 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3512 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3513
3514 * print.c (print_error_message): Avoid int overflow.
3515
3516 * font.c (font_list_entities): Redo for clarity,
3517 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3518
3519 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3520 (font_score): Avoid potential overflow in diff calculation.
3521
3522 * fns.c (substring_both): Remove var that is set but not used.
3523 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3524
3525 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3526
3527 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3528 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3529 can always succeed if overflow has undefined behavior.
3530
3531 * search.c (boyer_moore, wordify): Remove vars set but not used.
3532 (wordify): Omit three unnecessary tests.
3533
3534 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3535 All callers changed. This avoids the need for an unused var.
3536
3537 * casefiddle.c (casify_region): Remove var that is set but not used.
3538
3539 * dired.c (file_name_completion): Remove var that is set but not used.
3540
3541 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3542
3543 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
3544 (Finsert_file_contents): Remove unnecessary code checking fd.
3545
3546 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3547 Check for integer overflow on size calculations.
3548
3549 * buffer.c (Fprevious_overlay_change): Remove var that is set
3550 but not used.
3551
3552 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3553 Remove vars that are set but not used.
3554 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
3555 (timer_check_2): Mark vars as initialized.
3556
3557 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3558
3559 * image.c (lookup_image): Remove var that is set but not used.
3560 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
3561
3562 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3563 that are set but not used.
3564
3565 * xfns.c (make_invisible_cursor): Don't return garbage
3566 if XCreateBitmapFromData fails (Bug#8410).
3567
3568 * xselect.c (x_get_local_selection, x_handle_property_notify):
3569 Remove vars that are set but not used.
3570
3571 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
3572 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
3573
3574 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3575 Remove var that is set but not used.
3576 (scroll_bar_windows_size): Now size_t, not int.
3577 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3578 Check for overflow.
3579
3580 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3581 (map_tty_color) [!defined MSDOS]: Likewise.
3582
3583 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3584
3585 * coding.c: Remove vars that are set but not used.
3586 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3587 All callers changed.
3588 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3589 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3590 (decode_coding_charset): Remove vars that are set but not used.
3591
3592 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3593 that is set but not used.
3594
3595 * print.c (print_object): Remove var that is set but not used.
3596
3597 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
3598 The gnulib version avoids calling malloc in the usual case,
3599 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3600 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3601 * filelock.c (current_lock_owner): Likewise.
3602 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3603 * sysdep.c: Include allocator.h, careadlinkat.h.
3604 (emacs_no_realloc_allocator): New static constant.
3605 (emacs_readlink): New function.
3606 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3607 ../lib/careadlinkat.h.
3608
3609 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3610
3611 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3612 first non-nil return value).
3613
3614 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3615
3616 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3617 if not defined (Bug#8403).
3618
3619 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3620
3621 * xdisp.c (display_count_lines): Remove parameter `start',
3622 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3623 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3624 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3625 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3626 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3627 and thereabouts. All callers changed.
3628 (get_per_char_metric): Remove parameter `f', unused since
3629 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3630
3631 2011-04-02 Jim Meyering <meyering@redhat.com>
3632
3633 do not dereference NULL upon failed strdup
3634 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3635 (ns_get_family): Likewise.
3636
3637 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3638
3639 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3640
3641 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3642
3643 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3644 later (Bug#8403).
3645
3646 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3647
3648 Add lexical binding.
3649
3650 * window.c (Ftemp_output_buffer_show): New fun.
3651 (Fsave_window_excursion):
3652 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3653
3654 * lread.c (lisp_file_lexically_bound_p): New function.
3655 (Fload): Bind Qlexical_binding.
3656 (readevalloop): Remove `evalfun' arg.
3657 Bind Qinternal_interpreter_environment.
3658 (Feval_buffer): Bind Qlexical_binding.
3659 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3660 Mark as dynamic.
3661 (syms_of_lread): Declare `lexical-binding'.
3662
3663 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3664
3665 * keyboard.c (eval_dyn): New fun.
3666 (menu_item_eval_property): Use it.
3667
3668 * image.c (parse_image_spec): Use Ffunctionp.
3669
3670 * fns.c (concat, mapcar1): Accept byte-code-functions.
3671
3672 * eval.c (Fsetq): Handle lexical vars.
3673 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3674 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3675 (FletX, Flet): Obey lexical binding.
3676 (Fcommandp): Handle closures.
3677 (Feval): New `lexical' arg.
3678 (eval_sub): New function extracted from Feval. Use it almost
3679 everywhere where Feval was used. Look up vars in lexical env.
3680 Handle closures.
3681 (Ffunctionp): Move from subr.el.
3682 (Ffuncall): Handle closures.
3683 (apply_lambda): Remove `eval_flags'.
3684 (funcall_lambda): Handle closures and new byte-code-functions.
3685 (Fspecial_variable_p): New function.
3686 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3687 but without exporting it to Lisp.
3688
3689 * doc.c (Fdocumentation, store_function_docstring):
3690 * data.c (Finteractive_form): Handle closures.
3691
3692 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3693 interactive spec.
3694
3695 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3696 New byte-codes.
3697 (exec_byte_code): New function extracted from Fbyte_code to handle new
3698 calling convention for byte-code-functions. Add new byte-codes.
3699
3700 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
3701
3702 * alloc.c (Fmake_symbol): Init new `declared_special' field.
3703
3704 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3705
3706 * xdisp.c (redisplay_internal): Fix prototype.
3707
3708 2011-03-31 Eli Zaretskii <eliz@gnu.org>
3709
3710 * xdisp.c (SCROLL_LIMIT): New macro.
3711 (try_scrolling): Use it when setting scroll_limit.
3712 Limit scrolling to 100 screen lines.
3713 (redisplay_window): Even when falling back on "recentering",
3714 position point in the window according to scroll-conservatively,
3715 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3716
3717 (try_scrolling): When point is above the window, allow searching
3718 as far as scroll_max, or one screenful, to compute vertical
3719 distance from PT to the scroll margin position. This prevents
3720 try_scrolling from unnecessarily failing when
3721 scroll-conservatively is set to a value slightly larger than the
3722 window height. Clean up the case of PT below the margin at bottom
3723 of window: scroll_max can no longer be INT_MAX. When aggressive
3724 scrolling is in use, don't let point enter the opposite scroll
3725 margin as result of the scroll.
3726 (syms_of_xdisp) <scroll-conservatively>: Document the
3727 threshold of 100 lines for never-recentering scrolling.
3728
3729 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3730
3731 * dispextern.h (move_it_by_lines):
3732 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3733 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3734 (message_log_check_duplicate): Remove parameters `prev_bol' and
3735 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3736 (redisplay_internal): Remove parameter `preserve_echo_area',
3737 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3738
3739 * indent.c (Fvertical_motion):
3740 * window.c (window_scroll_pixel_based, Frecenter):
3741 Don't pass `need_y_p' to `move_it_by_lines'.
3742
3743 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3744
3745 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3746 steal a few bits to be more compact.
3747 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3748 Remove unneeded casts.
3749
3750 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3751
3752 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3753
3754 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3755 binding" message (bug#7967).
3756
3757 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3758
3759 Fix more problems found by GCC 4.6.0's static checks.
3760
3761 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3762 Remove unused local var.
3763
3764 * editfns.c (Fmessage_box): Remove unused local var.
3765
3766 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3767 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3768 Omit unused local vars.
3769 * window.c (shrink_windows): Omit unused local var.
3770 * menu.c (digest_single_submenu): Omit unused local var.
3771 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3772 Omit unused local var.
3773
3774 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3775 Don't assume string length fits in int.
3776 (keyremap_step, read_key_sequence): Use size_t for sizes.
3777 (read_key_sequence): Don't check last_real_key_start redundantly.
3778
3779 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3780 instead of alloca (Bug#8344).
3781
3782 * eval.c (Fbacktrace): Don't assume nargs fits in int.
3783 (Fbacktrace_frame): Don't assume nframes fits in int.
3784
3785 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3786
3787 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3788 concerns.
3789
3790 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3791
3792 * cm.c (calccost): Turn while-do into do-while, for clarity.
3793
3794 * keyboard.c (syms_of_keyboard): Use the same style as later
3795 in this function when indexing through an array. This also
3796 works around GCC bug 48267.
3797
3798 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3799
3800 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3801
3802 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3803 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3804
3805 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3806 This avoids undefined behavior on integer overflow, and is a bit
3807 more convenient anyway since it is compared to a size_t variable.
3808
3809 Variadic C functions now count arguments with size_t, not int.
3810 This avoids an unnecessary limitation on 64-bit machines, which
3811 caused (substring ...) to crash on large vectors (Bug#8344).
3812 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3813 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
3814 All variadic functions and their callers changed accordingly.
3815 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3816 * data.c (arith_driver, float_arith_driver): Likewise.
3817 * editfns.c (general_insert_function): Likewise.
3818 * eval.c (struct backtrace.nargs, interactive_p)
3819 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3820 (funcall_lambda, mark_backtrace): Likewise.
3821 * fns.c (concat): Likewise.
3822 * frame.c (x_set_frame_parameters): Likewise.
3823 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3824 0 if not found, not -1. All callers changed.
3825
3826 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3827 (stack_copy_size): Now size_t, not int.
3828 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3829
3830 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3831
3832 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3833 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3834 All callers changed.
3835
3836 * lisp.h (multibyte_char_to_unibyte):
3837 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3838 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3839 * character.h (CHAR_TO_BYTE8):
3840 * cmds.c (internal_self_insert):
3841 * editfns.c (general_insert_function):
3842 * keymap.c (push_key_description):
3843 * search.c (Freplace_match):
3844 * xdisp.c (message_dolog, set_message_1): All callers changed.
3845
3846 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3847
3848 * keyboard.c (safe_run_hook_funcall): New function.
3849 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3850 don't set the hook to nil, but remove the offending function instead.
3851 (Qcommand_hook_internal): Remove, unused.
3852 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3853 Vcommand_hook_internal.
3854
3855 * eval.c (enum run_hooks_condition): Remove.
3856 (funcall_nil, funcall_not): New functions.
3857 (run_hook_with_args): Call each function through a `funcall' argument.
3858 Remove `cond' argument, now redundant.
3859 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3860 (Frun_hook_with_args_until_failure): Adjust accordingly.
3861 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3862
3863 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3864
3865 * dispextern.h (string_buffer_position): Remove declaration.
3866
3867 * print.c (strout): Remove parameter `multibyte', unused since
3868 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3869
3870 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3871 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3872 All callers changed.
3873
3874 * w32.c (_wsa_errlist): Use braces for struct initializers.
3875
3876 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3877 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3878 All callers changed.
3879 (string_buffer_position): Likewise. Also, make static (it's never
3880 used outside xdisp.c).
3881 (cursor_row_p): Remove parameter `w', unused since
3882 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3883 (decode_mode_spec): Remove parameter `precision', introduced during
3884 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3885 All callers changed.
3886
3887 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3888
3889 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3890
3891 2011-03-27 Anders Lindgren <andlind@gmail.com>
3892
3893 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3894 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3895 (ns_update_auto_hide_menu_bar): New functions.
3896 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3897 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3898 ns_constrain_all_frames.
3899 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3900 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3901
3902 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3903
3904 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3905
3906 2011-03-27 Glenn Morris <rgm@gnu.org>
3907
3908 * syssignal.h: Replace RETSIGTYPE with void.
3909 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3910 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3911 Replace SIGTYPE with void everywhere.
3912 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3913 * s/template.h (SIGTYPE): Remove commented out definition.
3914
3915 2011-03-26 Eli Zaretskii <eliz@gnu.org>
3916
3917 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3918 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3919
3920 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
3921
3922 * w32.c (read_unc_volume): Use parameter `henum', instead of
3923 global variable `wget_enum_handle'.
3924
3925 * keymap.c (describe_vector): Remove parameters `indices' and
3926 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3927 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3928
3929 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3930
3931 * keyboard.c (timer_check): Remove parameter `do_it_now',
3932 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3933 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3934 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3935
3936 * keyboard.c (read_char):
3937 * w32menu.c (w32_menu_display_help):
3938 * xmenu.c (show_help_event, menu_help_callback):
3939 Adjust calls to `show_help_echo'.
3940
3941 * gtkutil.c (xg_maybe_add_timer):
3942 * keyboard.c (readable_events):
3943 * process.c (wait_reading_process_output):
3944 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3945
3946 * insdel.c (adjust_markers_gap_motion):
3947 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3948 (gap_left, gap_right): Don't call it.
3949
3950 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
3951
3952 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3953 incurred during fontification.
3954
3955 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3956
3957 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3958 (DEFVAR_PER_BUFFER): Don't pass it.
3959
3960 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3961 (scrolling_window): Don't pass it.
3962
3963 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3964
3965 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3966
3967 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3968 and `suffix'.
3969 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3970 of variables specific to SELinux and computation of `encoded_absname'.
3971
3972 * image.c (XPutPixel): Remove unused variable `height'.
3973
3974 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3975
3976 * unexw32.c (get_section_info): Remove unused variable `section'.
3977
3978 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3979 (system_process_attributes): Remove unused variable `sess'.
3980 (sys_read): Remove unused variable `err'.
3981
3982 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3983 (w32_wnd_proc): Remove unused variable `isdead'.
3984 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3985 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3986 (x_create_tip_frame): Remove unused variable `tem'.
3987
3988 * w32inevt.c (w32_console_read_socket):
3989 Remove unused variable `no_events'.
3990
3991 * w32term.c (x_draw_composite_glyph_string_foreground):
3992 Remove unused variable `width'.
3993
3994 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
3995
3996 * w32term.c (x_set_glyph_string_clipping):
3997 Don't pass uninitialized region to CombineRgn.
3998
3999 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
4000
4001 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4002 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4003 (Fx_close_connection): Remove unused variable `i'.
4004
4005 * w32font.c (w32font_draw): Return number of glyphs.
4006 (w32font_open_internal): Remove unused variable `i'.
4007 (w32font_driver): Add missing initializer.
4008
4009 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4010 (fill_in_menu): Remove unused variable `items_added'.
4011
4012 * w32term.c (last_mouse_press_frame): Remove static global variable.
4013 (w32_clip_to_row): Remove unused variable `f'.
4014 (x_delete_terminal): Remove unused variable `i'.
4015
4016 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4017 (NOTHING): Remove unused static global variable.
4018 (uniscribe_check_otf): Remove unused variable `table'.
4019 (uniscribe_font_driver): Add missing initializers.
4020
4021 2011-03-23 Julien Danjou <julien@danjou.info>
4022
4023 * term.c (Fsuspend_tty, Fresume_tty):
4024 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4025 * window.c (temp_output_buffer_show):
4026 * insdel.c (signal_before_change):
4027 * frame.c (Fhandle_switch_frame):
4028 * fileio.c (Fdo_auto_save):
4029 * emacs.c (Fkill_emacs):
4030 * editfns.c (save_excursion_restore):
4031 * cmds.c (internal_self_insert):
4032 * callint.c (Fcall_interactively):
4033 * buffer.c (Fkill_all_local_variables):
4034 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4035 Use Frun_hooks.
4036 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
4037 unconditionnaly since it does the check itself.
4038
4039 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
4040
4041 Fix more problems found by GCC 4.5.2's static checks.
4042
4043 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4044 the first time through the loop, since we know p0 < p1 then.
4045 This also avoids a gcc -Wstrict-overflow warning.
4046
4047 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4048 leading to a memory leak, possible in functions like
4049 load_charset_map_from_file that can allocate an unbounded number
4050 of objects (Bug#8318).
4051
4052 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4053 that could (at least in theory) be that large.
4054
4055 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4056 This is less likely to overflow, and avoids undefined behavior if
4057 overflow does occur. All callers changed. Use strtoul to scan
4058 for the unsigned long integer.
4059 (pint2hrstr): Simplify and tune code slightly.
4060 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
4061
4062 * scroll.c (do_scrolling): Work around GCC bug 48228.
4063 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4064
4065 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4066 This also avoids a warning with gcc -Wstrict-overflow.
4067 (validate_x_resource_name): Simplify count usage.
4068 This also avoids a warning with gcc -Wstrict-overflow.
4069
4070 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4071 fail (Bug#8306).
4072
4073 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
4074
4075 * process.c (Fmake_network_process): Use socklen_t, not int,
4076 where POSIX says socklen_t is required in portable programs.
4077 This fixes a porting bug on hosts like 64-bit HP-UX, where
4078 socklen_t is wider than int (Bug#8277).
4079 (Fmake_network_process, server_accept_connection):
4080 (wait_reading_process_output, read_process_output):
4081 Likewise.
4082
4083 * process.c: Rename or move locals to avoid shadowing.
4084 (list_processes_1, Fmake_network_process):
4085 (read_process_output_error_handler, exec_sentinel_error_handler):
4086 Rename or move locals.
4087 (Fmake_network_process): Define label "retry_connect" only if needed.
4088 (Fnetwork_interface_info): Fix pointer signedness.
4089 (process_send_signal): Add cast to avoid pointer signedness problem.
4090 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
4091 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
4092
4093 Make tparam.h and terminfo.c consistent.
4094 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4095 Include tparam.h instead, since it declares them.
4096 * cm.h (PC): Remove extern decl; tparam.h now does this.
4097 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4098 * terminfo.c: Include tparam.h, to check interfaces.
4099 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4100 (tparam): Adjust signature to match interface in tparam.h;
4101 this removes some undefined behavior. Check that outstring and len
4102 are zero, which they always are with Emacs.
4103 * tparam.h (PC, BC, UP): New extern decls.
4104
4105 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
4106 (xftfont_open): Rename locals to avoid shadowing.
4107
4108 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
4109 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4110 (OTF_TAG_SYM): Omit macro if not needed.
4111 (ftfont_list): Remove unused local.
4112 (get_adstyle_property, ftfont_pattern_entity):
4113 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4114 Rename locals to avoid shadowing.
4115
4116 * xfont.c (xfont_list_family): Mark var as initialized.
4117
4118 * xml.c (make_dom): Now static.
4119
4120 * composite.c (composition_compute_stop_pos): Rename local to
4121 avoid shadowing.
4122 (composition_reseat_it): Remove unused locals.
4123 (find_automatic_composition, composition_adjust_point): Likewise.
4124 (composition_update_it): Mark var as initialized.
4125 (find_automatic_composition): Mark vars as initialized,
4126 with a FIXME (Bug#8290).
4127
4128 character.h: Rename locals to avoid shadowing.
4129 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4130 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4131 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4132 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4133 to avoid shadowing.
4134
4135 * textprop.c (property_change_between_p): Remove; unused.
4136
4137 * intervals.c (interval_start_pos): Now static.
4138
4139 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4140
4141 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4142 Rename locals to avoid shadowing.
4143
4144 * sound.c (wav_play, au_play, Fplay_sound_internal):
4145 Fix pointer signedness.
4146 (alsa_choose_format): Remove unused local var.
4147 (wav_play): Initialize a variable to 0, to prevent undefined
4148 behavior (Bug#8278).
4149
4150 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4151
4152 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4153
4154 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4155 clobbering (Bug#8298).
4156 * sysdep.c (sys_subshell): Likewise.
4157 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
4158
4159 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4160 This should get cleaned up, so that child_setup has the
4161 same signature on all platforms.
4162
4163 * callproc.c (call_process_cleanup): Now static.
4164 (relocate_fd): Rename locals to avoid shadowing.
4165
4166 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
4167
4168 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4169 not to be necessary, and produces flickering.
4170
4171 2011-03-20 Glenn Morris <rgm@gnu.org>
4172
4173 * config.in: Remove file.
4174
4175 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
4176
4177 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4178 are now in src/globals.h.
4179 (syms_of_minibuf): Remove spurious & from previous change.
4180
4181 2011-03-20 Leo <sdl.web@gmail.com>
4182
4183 * minibuf.c (completing-read-function): New variable.
4184 (completing-read-default): Rename from completing-read.
4185 (completing-read): Call completing-read-function.
4186
4187 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4188
4189 * xfaces.c (Fx_load_color_file):
4190 Read color file from absolute filename (bug#8250).
4191
4192 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4193
4194 * makefile.w32-in: Update dependencies.
4195
4196 2011-03-17 Eli Zaretskii <eliz@gnu.org>
4197
4198 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4199
4200 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4201
4202 Fix more problems found by GCC 4.5.2's static checks.
4203
4204 * process.c (make_serial_process_unwind, send_process_trap):
4205 (sigchld_handler): Now static.
4206
4207 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4208 That way, the code declares only the vars that it needs.
4209 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4210 * s/cygwin.h (PTY_ITERATION): Likewise.
4211 * s/darwin.h (PTY_ITERATION): Likewise.
4212 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4213
4214 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4215 * process.c (allocate_pty): Don't declare stb unless it's needed.
4216
4217 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
4218 (CONSTANTLIM): Remove; unused.
4219 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4220 Define only if needed.
4221
4222 * unexelf.c (unexec): Name an expression,
4223 to avoid gcc -Wbad-function-cast warning.
4224 Use a different way to cause a compilation error if anyone uses
4225 n rather than nn, a way that does not involve shadowing.
4226 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
4227
4228 * deps.mk (unexalpha.o): Remove; unused.
4229
4230 New file unexec.h, the (simple) interface for unexec (Bug#8267).
4231 * unexec.h: New file.
4232 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4233 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4234 Depend on unexec.h.
4235 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4236 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4237 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
4238 Change as necessary to match prototype in unexec.h.
4239
4240 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4241 shadowing.
4242 (back_comment, skip_chars): Mark vars as initialized.
4243
4244 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4245 Rename locals to avoid shadowing.
4246
4247 * lread.c (read1): Rewrite so as not to use empty "else".
4248 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
4249
4250 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4251
4252 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4253 warning when compiling print.c.
4254
4255 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4256 instead of using an uninitialized var.
4257 (font_sort_entities): Mark var as initialized.
4258
4259 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4260
4261 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4262 pointers to constants.
4263 (font_parse_fcname): Remove unused vars.
4264 (font_delete_unmatched): Now static.
4265 (font_get_spec): Remove; unused.
4266 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4267 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4268 Rename or move locals to avoid shadowing.
4269
4270 * fns.c (require_nesting_list, require_unwind): Now static.
4271 (Ffillarray): Rename locals to avoid shadowing.
4272
4273 * floatfns.c (domain_error2): Define only if needed.
4274 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
4275
4276 * alloc.c (mark_backtrace): Move decl from here ...
4277 * lisp.h: ... to here, so that it can be checked.
4278
4279 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
4280 (Fdefvar): Rewrite so as not to use empty "else".
4281 (lisp_indirect_variable): Name an expression,
4282 to avoid gcc -Wbad-function-cast warning.
4283 (Fdefvar): Rename locals to avoid shadowing.
4284
4285 * callint.c (quotify_arg, quotify_args): Now static.
4286 (Fcall_interactively): Rename locals to avoid shadowing.
4287 Use const pointer when appropriate.
4288
4289 * lisp.h (get_system_name, get_operating_system_release):
4290 Move decls here, to check interfaces.
4291 * process.c (get_operating_system_release): Move decl to lisp.h.
4292 * xrdb.c (get_system_name): Likewise.
4293 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4294 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4295 some of which prompt warnings from gcc -Wbad-function-cast.
4296 (Fformat_time_string, Fencode_time, Finsert_char):
4297 (Ftranslate_region_internal, Fformat):
4298 Rename or remove local vars to avoid shadowing.
4299 (Ftranslate_region_internal): Mark var as initialized.
4300
4301 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4302 avoid shadowing.
4303
4304 * lisp.h (eassert): Check that the argument compiles, even if
4305 ENABLE_CHECKING is not defined.
4306
4307 * data.c (Findirect_variable): Name an expression, to avoid
4308 gcc -Wbad-function-cast warning.
4309 (default_value, arithcompare, arith_driver, arith_error): Now static.
4310 (store_symval_forwarding): Rename local to avoid shadowing.
4311 (Fmake_variable_buffer_local, Fmake_local_variable):
4312 Mark variables as initialized.
4313 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4314
4315 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4316 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4317 Rename locals to avoid shadowing.
4318 (mark_stack): Move local variables into the #ifdef region where
4319 they're used.
4320 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4321 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4322 needed otherwise.
4323 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4324 (GC_STRING_CHARS): Remove; not used.
4325 (Fmemory_limit): Cast sbrk's returned value to char *.
4326
4327 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4328 avoids undefined behavior in theory.
4329
4330 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4331
4332 Use functions, not macros, for up- and down-casing (Bug#8254).
4333 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4334 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4335 to use the following functions instead of these macros.
4336 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4337 EMACS_INT, since callers assume the returned value fits in int.
4338 (upcase1): Likewise, for UPCASE_TABLE.
4339 (uppercasep, lowercasep, upcase): New static inline functions.
4340 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4341 the race-condition problem in the old DOWNCASE.
4342
4343 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4344 Rename locals to avoid shadowing.
4345 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4346 (regex_compile, re_search_2, re_match_2_internal):
4347 Remove unused local vars.
4348 (FREE_VAR): Rewrite so as not to use empty "else",
4349 which gcc can warn about.
4350 (regex_compile, re_match_2_internal): Mark locals as initialized.
4351 (RETALLOC_IF): Define only if needed.
4352 (WORDCHAR_P): Likewise. This one is never needed, but is used
4353 only in a comment talking about a compiler bug, so put inside
4354 the #if 0 of that comment.
4355 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4356 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4357 Remove; unused.
4358
4359 * search.c (boyer_moore): Rename locals to avoid shadowing.
4360 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4361 (PREV_CHAR_BOUNDARY): Likewise.
4362
4363 * search.c (simple_search): Remove unused var.
4364
4365 * dired.c (compile_pattern): Move decl from here ...
4366 * lisp.h: ... to here, so that it can be checked.
4367 (struct re_registers): New forward decl.
4368
4369 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4370
4371 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4372 All uses changed.
4373 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4374 Rename locals to avoid shadowing.
4375 (Fvertical_motion): Mark locals as initialized.
4376
4377 * casefiddle.c (casify_object, casify_region): Now static.
4378 (casify_region): Mark local as initialized.
4379
4380 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4381
4382 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4383 New macros, so that the caller can use some names other than
4384 gcpro1, gcpro2, etc.
4385 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4386 of the new macros.
4387 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4388 argument, for consistency with GCPRO2_VAR, etc: it is now the
4389 prefix of the variable, not the variable itself. All uses
4390 changed.
4391 * dired.c (directory_files_internal, file_name_completion):
4392 Rename locals to avoid shadowing.
4393
4394 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4395 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4396 dired.c's scmp function, had undefined behavior.
4397 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4398 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4399 * buffer.h: ... to here, because these macros use current_buffer,
4400 and the new implementation with inline functions needs to have
4401 current_buffer in scope now, rather than later when the macros
4402 are used.
4403 (downcase, upcase1): New static inline functions.
4404 (DOWNCASE, UPCASE1): Reimplement using these functions.
4405 This avoids undefined behavior in expressions like
4406 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4407 from race conditions in accessing the global variables
4408 case_temp1 and case_temp2.
4409 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4410 * lisp.h (case_temp1, case_temp2): Remove their decls.
4411 * character.h (ASCII_CHAR_P): Move from here ...
4412 * lisp.h: ... to here, so that the inline functions mentioned
4413 above can use them.
4414
4415 * dired.c (directory_files_internal_unwind): Now static.
4416
4417 * fileio.c (file_name_as_directory, directory_file_name):
4418 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4419 Now static.
4420 (file_name_as_directory): Use const pointers when appropriate.
4421 (Fexpand_file_name): Likewise. In particular, newdir might
4422 point at constant storage, so make it a const pointer.
4423 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4424 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4425 signedness issues.
4426 (Fset_file_times, Finsert_file_contents, auto_save_error):
4427 Rename locals to avoid shadowing.
4428
4429 * minibuf.c (choose_minibuf_frame_1): Now static.
4430 (Ftry_completion, Fall_completions): Rename or remove locals
4431 to avoid shadowing.
4432
4433 * marker.c (bytepos_to_charpos): Remove; unused.
4434
4435 * lisp.h (verify_bytepos, count_markers): New decls,
4436 so that gcc does not warn that these functions aren't declared.
4437
4438 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4439 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4440 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4441 (copy_text): Remove unused local var.
4442
4443 * filelock.c (within_one_second): Now static.
4444 (lock_file_1): Rename local to avoid shadowing.
4445
4446 * buffer.c (fix_overlays_before): Mark locals as initialized.
4447 (fix_start_end_in_overlays): Likewise. This function should be
4448 simplified by using pointers-to-pointers, but that's a different
4449 matter.
4450 (switch_to_buffer_1): Now static.
4451 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4452 (report_overlay_modification): Rename locals to avoid shadowing.
4453
4454 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4455 Fix pointer signedness issue.
4456 (sys_subshell): Mark local as volatile if checking for lint,
4457 to suppress a gcc -Wclobbered warning that does not seem to be right.
4458 (MAXPATHLEN): Define only if needed.
4459
4460 * process.c (serial_open, serial_configure): Move decls from here ...
4461 * systty.h: ... to here, so that they can be checked.
4462
4463 * fns.c (get_random, seed_random): Move extern decls from here ...
4464 * lisp.h: ... to here, so that they can be checked.
4465
4466 * sysdep.c (reset_io): Now static.
4467 (wait_for_termination_signal): Remove; unused.
4468
4469 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4470 (copy_keymap_item, append_key, push_text_char_description):
4471 Now static.
4472 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4473 (DENSE_TABLE_SIZE): Remove; unused.
4474 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4475 (describe_map_tree):
4476 Rename locals to avoid shadowing.
4477
4478 * keyboard.c: Declare functions static if they are not used elsewhere.
4479 (echo_char, echo_dash, cmd_error, top_level_2):
4480 (poll_for_input, handle_async_input): Now static.
4481 (read_char, kbd_buffer_get_event, make_lispy_position):
4482 (make_lispy_event, make_lispy_movement, apply_modifiers):
4483 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4484 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4485 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4486 (read_key_sequence, read_char): Mark locals as initialized.
4487 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4488
4489 * keyboard.h (make_ctrl_char): New decl.
4490 (mark_kboards): Move decl here ...
4491 * alloc.c (mark_kboards): ... from here.
4492
4493 * lisp.h (force_auto_save_soon): New decl.
4494
4495 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4496 (DEFINE_DUMMY_FUNCTION): New macro.
4497 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4498 Use it.
4499 (main): Add casts to avoid warnings
4500 if GCC considers string literals to be constants.
4501
4502 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4503
4504 * dbusbind.c: Pointer signedness fixes.
4505 (xd_signature, xd_append_arg, xd_initialize):
4506 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4507 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4508 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4509 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4510
4511 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4512 if GCC considers string literals to be constants.
4513 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4514
4515 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4516
4517 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4518 (print_preprocess, print_object): New macro to fix last change.
4519
4520 * print.c (print_preprocess): Don't forget font objects.
4521
4522 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
4523
4524 * emacs.c (USAGE3): Doc fixes.
4525
4526 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4527
4528 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4529 structure.
4530
4531 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
4532
4533 * lisp.h (VWindow_system, Qfile_name_history):
4534 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4535 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4536 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4537
4538 * w32select.c: Don't #include "keyboard.h".
4539 (run_protected): Add extern declaration for waiting_for_input.
4540
4541 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4542 * w32console.c (detect_input_pending, read_input_pending)
4543 (encode_terminal_code):
4544 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4545 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4546 (w32_system_caret_y, Qfile_name_history):
4547 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4548 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4549 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4550 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4551 * w32proc.c (Qlocal, report_file_error):
4552 * w32term.c (Vwindow_system, updating_frame):
4553 * w32uniscribe.c (initialized, uniscribe_font_driver):
4554 Remove unneeded extern declarations.
4555
4556 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
4557
4558 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
4559
4560 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
4561
4562 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4563 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4564 These macros can no longer be used for assignment.
4565
4566 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4567 Assign struct members directly, instead of using BUF_BEGV etc.
4568 (record_buffer_markers, fetch_buffer_markers): New functions for
4569 recording and fetching special buffer markers.
4570 (set_buffer_internal_1, set_buffer_temp): Use them.
4571
4572 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4573
4574 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4575
4576 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4577 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4578
4579 * xdisp.c (hscroll_window_tree):
4580 (reconsider_clip_changes): Use PT instead of BUF_PT.
4581
4582 2011-03-13 Eli Zaretskii <eliz@gnu.org>
4583
4584 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4585 $(EMACS_ROOT)/lib/intprops.h.
4586
4587 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4588
4589 Fix more problems found by GCC 4.5.2's static checks.
4590
4591 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4592 to unsigned char * to avoid compiler diagnostic.
4593 (xg_free_frame_widgets): Make it clear that a local variable is
4594 needed only if USE_GTK_TOOLTIP.
4595 (gdk_window_get_screen): Make it clear that this macro is needed
4596 only if USE_GTK_TOOLTIP.
4597 (int_gtk_range_get_value): New function, which avoids a diagnostic
4598 from gcc -Wbad-function-cast.
4599 (xg_set_toolkit_scroll_bar_thumb): Use it.
4600 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4601 diagnostic from gcc -Wbad-function-cast.
4602 (get_utf8_string, xg_get_file_with_chooser):
4603 Rename locals to avoid shadowing.
4604 (create_dialog): Move locals to avoid shadowing.
4605
4606 * xgselect.c (xg_select): Remove unused var.
4607
4608 * image.c (four_corners_best): Mark locals as initialized.
4609 (gif_load): Initialize transparent_p to zero (Bug#8238).
4610 Mark another local as initialized.
4611 (my_png_error, my_error_exit): Mark with NO_RETURN.
4612
4613 * image.c (clear_image_cache): Now static.
4614 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
4615 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
4616 (x_edge_detection): Remove unnecessary cast that
4617 gcc -Wbad-function-cast diagnoses.
4618 (gif_load): Fix pointer signedness.
4619 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4620 (jpeg_load, gif_load): Rename locals to avoid shadowing.
4621
4622 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
4623
4624 Improve quality of tests for time stamp overflow.
4625 For example, without this patch (encode-time 0 0 0 1 1
4626 1152921504606846976) returns the obviously-bogus value (-948597
4627 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4628 reports time overflow. See
4629 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
4630 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4631 * editfns.c: Include limits.h and intprops.h.
4632 (TIME_T_MIN, TIME_T_MAX): New macros.
4633 (time_overflow): Move earlier, to before first use.
4634 (hi_time, lo_time): New functions, for an accurate test for
4635 out-of-range times.
4636 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4637 (Fget_internal_run_time): Don't assume time_t fits in int.
4638 (make_time): Use list2 instead of Fcons twice.
4639 (Fdecode_time): More accurate test for out-of-range times.
4640 (check_tm_member): New function.
4641 (Fencode_time): Use it, to test for out-of-range times.
4642 (lisp_time_argument): Don't rely on undefined left-shift and
4643 right-shift behavior when checking for time stamp overflow.
4644
4645 * editfns.c (time_overflow): New function, refactoring common code.
4646 (Fformat_time_string, Fdecode_time, Fencode_time):
4647 (Fcurrent_time_string): Use it.
4648
4649 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4650 * dired.c (make_time): Move to ...
4651 * editfns.c (make_time): ... here.
4652 * systime.h: Note the move.
4653
4654 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4655
4656 * fringe.c (update_window_fringes): Remove unused variables.
4657
4658 * unexmacosx.c (copy_data_segment): Also copy __got section.
4659 (Bug#8223)
4660
4661 2011-03-12 Eli Zaretskii <eliz@gnu.org>
4662
4663 * termcap.c [MSDOS]: Include "msdos.h".
4664 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4665 Constify `char *' arguments and their references according to
4666 prototypes in tparam.h.
4667
4668 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
4669
4670 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4671 Adapt all references accordingly.
4672
4673 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4674
4675 2011-03-11 Tom Tromey <tromey@redhat.com>
4676
4677 * buffer.c (syms_of_buffer): Remove obsolete comment.
4678
4679 2011-03-11 Eli Zaretskii <eliz@gnu.org>
4680
4681 * termhooks.h (encode_terminal_code): Declare prototype.
4682
4683 * msdos.c (encode_terminal_code): Don't declare prototype.
4684
4685 * term.c (encode_terminal_code): Now external again, used by
4686 w32console.c and msdos.c.
4687
4688 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4689 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
4690
4691 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
4692
4693 Fix some minor problems found by GCC 4.5.2's static checks.
4694
4695 * fringe.c (update_window_fringes): Mark locals as initialized
4696 (Bug#8227).
4697 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
4698
4699 * alloc.c (mark_fringe_data): Move decl from here ...
4700 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4701 to check its interface.
4702 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4703
4704 * fontset.c (free_realized_fontset): Now static.
4705 (Fset_fontset_font): Rename local to avoid shadowing.
4706 (fontset_font): Mark local as initialized.
4707 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
4708
4709 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4710
4711 * xselect.c (x_disown_buffer_selections): Remove; not used.
4712 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
4713 (x_own_selection, Fx_disown_selection_internal): Rename locals
4714 to avoid shadowing.
4715 (x_handle_dnd_message): Remove local to avoid shadowing.
4716
4717 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4718 so that the caller can use some name other than gcpro1.
4719 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
4720 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4721 (Fx_backspace_delete_keys_p):
4722 Use them to avoid shadowing, and rename vars to avoid shadowing.
4723 (x_decode_color, x_set_name, x_window): Now static.
4724 (Fx_create_frame): Add braces to silence GCC warning.
4725 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
4726 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4727 Remove unused locals.
4728 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4729 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4730 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4731 macros.
4732
4733 * xterm.h (x_mouse_leave): New decl.
4734
4735 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4736 Remove unused functions.
4737 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4738 (x_calc_absolute_position): Now static.
4739 (XTread_socket): Don't define label "out" unless it's used.
4740 Don't declare local "event" unless it's used.
4741 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4742 unless they are used.
4743 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4744 (x_fatal_error_signal): Remove; not used.
4745 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4746 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4747 (x_error_catcher, x_connection_closed, x_error_handler):
4748 (x_error_quitter, xembed_send_message, x_iconify_frame):
4749 (my_log_handler): Rename locals to avoid shadowing.
4750 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
4751 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
4752
4753 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4754 Rename or move locals to avoid shadowing.
4755 (tty_defined_color, merge_face_heights): Now static.
4756 (free_realized_faces_for_fontset): Remove; not used.
4757 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4758 does not deduce is never used uninitialized.
4759 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4760 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
4761
4762 * terminal.c (store_terminal_param): Now static.
4763
4764 * xmenu.c (menu_highlight_callback): Now static.
4765 (set_frame_menubar): Remove unused local.
4766 (xmenu_show): Rename parameter to avoid shadowing.
4767 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4768 since they might point to immutable storage.
4769 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4770 since it's unused otherwise.
4771
4772 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
4773 Add a FIXME, since the code still doesn't look right. (Bug#8215)
4774 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4775 avoids a gcc -Wuninitialized diagnostic.
4776 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
4777 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4778 does not deduce are never used uninitialized.
4779
4780 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4781
4782 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4783 * window.c (window_loop, size_window):
4784 (run_window_configuration_change_hook, enlarge_window): Likewise.
4785
4786 * window.c (display_buffer): Now static.
4787 (size_window): Mark variables that gcc -Wuninitialized
4788 does not deduce are never used uninitialized.
4789 * window.h (check_all_windows): New decl, to forestall
4790 gcc -Wmissing-prototypes diagnostic.
4791 * dispextern.h (bidi_dump_cached_states): Likewise.
4792
4793 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4794 shadowing.
4795 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
4796 Include <limits.h>.
4797 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4798 and to avoid gcc -Wuninitialized warning.
4799 (load_charset_map): Mark variables that gcc -Wuninitialized
4800 does not deduce are never used uninitialized.
4801 (load_charset): Abort instead of using uninitialized var (Bug#8229).
4802
4803 * coding.c (coding_set_source, coding_set_destination):
4804 Use "else { /* comment */ }" rather than "else /* comment */;"
4805 for clarity, and to avoid gcc -Wempty-body warning.
4806 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4807 a block, when the outer 'i' will do.
4808 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4809 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4810 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4811 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4812 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4813 Rename locals to avoid shadowing.
4814 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
4815 * coding.c (emacs_mule_char, encode_invocation_designation):
4816 Now static, since they're not used elsewhere.
4817 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
4818 (decode_coding_object, encode_coding_object, detect_coding_system):
4819 (decode_coding_emacs_mule): Mark variables that gcc
4820 -Wuninitialized does not deduce are never used uninitialized.
4821 (detect_coding_iso_2022): Initialize a local variable that might
4822 be used uninitialized. Leave a FIXME because it's not clear that
4823 this initialization is needed. (Bug#8211)
4824 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4825 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4826 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4827 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4828 Remove unused macros.
4829
4830 * category.c (hash_get_category_set): Remove unused local var.
4831 (copy_category_table): Now static, since it's not used elsewhere.
4832 * character.c (string_count_byte8): Likewise.
4833
4834 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4835 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4836
4837 * chartab.c (copy_sub_char_table): Now static, since it's not used
4838 elsewhere.
4839 (sub_char_table_ref_and_range, char_table_ref_and_range):
4840 Rename locals to avoid shadowing.
4841 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
4842
4843 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
4844 (BIDI_BOB): Remove unused macro.
4845
4846 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4847 deduce are never used uninitialized.
4848 * term.c (encode_terminal_code): Likewise.
4849
4850 * term.c (encode_terminal_code): Now static. Remove unused local.
4851
4852 * tparam.h: New file.
4853 * term.c, tparam.h: Include it.
4854 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4855 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4856 Move these decls to tparam.h, and make them agree with what
4857 is actually in tparam.c. The previous trick of using incompatible
4858 decls in different modules does not conform to the C standard.
4859 All callers of tparam changed to use tparam's actual API.
4860 * tparam.c (tparam1, tparam, tgoto):
4861 Use const pointers where appropriate.
4862
4863 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4864 * cm.h (struct cm): Likewise.
4865 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4866 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4867 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4868 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4869 (turn_on_face, init_tty): Likewise.
4870 * termchar.h (struct tty_display_info): Likewise.
4871
4872 * term.c (term_mouse_position): Rename local to avoid shadowing.
4873
4874 * alloc.c (mark_ttys): Move decl from here ...
4875 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4876
4877 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4878
4879 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4880
4881 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
4882
4883 * search.c (compile_pattern_1): Remove argument regp, unused since
4884 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4885 (compile_pattern): Don't pass it.
4886
4887 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4888
4889 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4890 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4891 for ! HAVE_GTK3.
4892 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4893
4894 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4895
4896 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4897 gdk_window_get_screen, gdk_window_get_geometry,
4898 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4899 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4900 (xg_get_pixbuf_from_pixmap): New function.
4901 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4902 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4903 Call xg_get_pixbuf_from_pixmap instead of
4904 gdk_pixbuf_get_from_drawable.
4905 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4906 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4907 (xg_check_special_colors): Use GtkStyleContext and its functions
4908 for HAVE_GTK3.
4909 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4910 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4911 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
4912 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4913 Call gtk_widget_get_preferred_size.
4914 (xg_frame_resized): gdk_window_get_geometry only takes 5
4915 parameters.
4916 (xg_win_to_widget, xg_event_is_for_menubar):
4917 Call gdk_x11_window_lookup_for_display.
4918 (xg_set_widget_bg): New function.
4919 (delete_cb): New function.
4920 (xg_create_frame_widgets): Connect delete-event to delete_cb.
4921 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4922 (xg_set_background_color): Call xg_set_widget_bg.
4923 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4924 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4925 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4926 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4927 if ! HAVE_GTK3.
4928 (update_frame_tool_bar): Call gtk_widget_hide.
4929 (xg_initialize): Use GDK_KEY_g.
4930
4931 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4932 if ! HAVE_GTK3
4933 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4934
4935 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4936 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4937 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4938
4939 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
4940
4941 * w32xfns.c (select_palette): Check success of RealizePalette against
4942 GDI_ERROR, not zero.
4943
4944 See ChangeLog.11 for earlier changes.
4945
4946 ;; Local Variables:
4947 ;; coding: utf-8
4948 ;; End:
4949
4950 Copyright (C) 2011 Free Software Foundation, Inc.
4951
4952 This file is part of GNU Emacs.
4953
4954 GNU Emacs is free software: you can redistribute it and/or modify
4955 it under the terms of the GNU General Public License as published by
4956 the Free Software Foundation, either version 3 of the License, or
4957 (at your option) any later version.
4958
4959 GNU Emacs is distributed in the hope that it will be useful,
4960 but WITHOUT ANY WARRANTY; without even the implied warranty of
4961 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4962 GNU General Public License for more details.
4963
4964 You should have received a copy of the GNU General Public License
4965 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.