1 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3 Remove dependency on glibc malloc internals.
4 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5 Move back here from lisp.h, but with their new implementations.
6 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
8 * charset.c (charset_table_init): New static var.
9 (syms_of_charset): Use it instead of xmalloc. This removes a
10 dependency on glibc malloc internals. See Eli Zaretskii's comment in
11 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
12 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
14 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
15 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
17 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
19 * nsterm.m (windowDidResize): Call x_set_window_size only when
20 ns_in_resize is true. Otherwise set pixelwidth/height and
21 call change_frame_size (Bug#9628).
23 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
25 Port --enable-checking=all to Fedora 14 x86-64.
26 * charset.c (syms_of_charset): Also account for glibc malloc's
27 internal overhead when calculating the initial malloc maximum.
29 Port --enable-checking=all to Fedora 14 x86.
30 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
32 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
33 (overrun_check_realloc, overrun_check_free):
34 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
35 That way, xmalloc returns a properly-aligned pointer even if
36 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
37 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
38 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
39 into account when calculating the initial malloc maximum.
40 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
41 Move here from alloc.c, so that charset.c can use it too.
42 Properly align; the old code wasn't right for common 32-bit hosts
43 when configured with --enable-checking=all.
44 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
45 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
47 2011-09-29 Eli Zaretskii <eliz@gnu.org>
49 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
52 2011-09-28 Eli Zaretskii <eliz@gnu.org>
54 * xdisp.c (compute_display_string_end): If there's no display
55 string at CHARPOS, return -1.
57 * bidi.c (bidi_fetch_char): When compute_display_string_end
58 returns a negative value, treat the character as a normal
59 character not covered by a display string. (Bug#9624)
61 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
63 * lread.c (Fread_from_string): Fix typo in docstring.
65 2011-09-27 Eli Zaretskii <eliz@gnu.org>
67 * xdisp.c (handle_invisible_prop): If invisible text ends on a
68 newline, reseat the iterator instead of bidi-iterating there one
69 character at a time. (Bug#9610)
70 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail out when
71 past TO_CHARPOS if the bidi iterator is at base embedding level.
73 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
75 * lread.c (readevalloop): Use correct code for NBSP.
76 (read1): Likewise. (Bug#9608)
78 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
80 * dbusbind.c (Fdbus_register_signal): When service is not
81 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
83 2011-09-25 Glenn Morris <rgm@gnu.org>
85 * buffer.c (truncate-lines): Doc fix.
87 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
89 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
90 (Fset_window_next_buffers): Doc fix.
92 2011-09-24 Glenn Morris <rgm@gnu.org>
94 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
96 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
98 Fix minor problems found by static checking.
99 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
100 * indent.c (Fvertical_motion): Fix == vs = typo.
102 2011-09-24 Eli Zaretskii <eliz@gnu.org>
104 * dispnew.c (syms_of_display) <redisplay-dont-pause>: Default
105 value is now t. Doc fix.
107 * indent.c (Fvertical_motion): Compute and apply the overshoot
108 logic also when moving up, not only when moving down. Fix the
109 confusing name and values of the it_overshoot_expected variable;
110 logic changed accordingly. (Bug#9254) (Bug#9549)
112 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
113 CHARPOS is covered by a display string which includes newlines.
114 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
115 is covered by a display string with embedded newlines.
117 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
119 * dbusbind.c (Fdbus_register_signal): Add match rule to
120 Vdbus_registered_objects_table. (Bug#9581)
121 (Fdbus_register_method, Vdbus_registered_objects_table): Fix
124 2011-09-24 Jim Meyering <meyering@redhat.com>
126 Do not ignore write error for any output size.
127 The previous change was incomplete.
128 While it makes emacs --batch detect the vast majority of stdout
129 write failures, errors were still ignored whenever the output size is
130 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
131 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
132 && echo FAIL: ignored write error
133 FAIL: ignored write error
134 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
135 && echo FAIL: ignored write error
136 FAIL: ignored write error
137 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
139 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
141 * emacs.c (Fkill_emacs): In noninteractive mode exit
142 non-successfully if a write error occurred on stdout. (Bug#9574)
144 2011-09-21 Eli Zaretskii <eliz@gnu.org>
146 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
149 * dispextern.h (struct it): Update the comment documenting what
152 2011-09-20 Eli Zaretskii <eliz@gnu.org>
154 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
155 a display string, extend search for cursor position to end of row.
156 (find_row_edges): If the row ends in a newline from a display
157 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
158 Handle the case of a display string with multiple newlines.
159 (Fcurrent_bidi_paragraph_direction): Fix search for previous
160 non-empty line. Fixes confusing cursor motion with arrow keys at
161 the beginning of a line that starts with whitespace.
163 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
165 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
168 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
170 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
173 2011-09-18 Eli Zaretskii <eliz@gnu.org>
175 * xdisp.c (display_line): Record maximum and minimum buffer
176 positions even if no glyphs were produced (e.g., by a zero-width
177 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
178 buffer positions that will be removed from the glyph row because
180 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
181 column is beyond frame width: don't subtract 1 "pixel" when
182 computing width of the stretch.
183 (reseat_at_next_visible_line_start): Undo the change made on
184 2011-09-17 that saved paragraph information and restored it after
185 the call to `reseat'. (Bug#9545)
187 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
189 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
190 and turn window cursor on if cleared (Bug#9415).
192 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
194 * search.c (boyer_moore): Take unibyte characters from pattern
195 literally. (Bug#9458)
197 2011-09-18 Eli Zaretskii <eliz@gnu.org>
199 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
201 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
203 Fix minor problem found by static checking.
204 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
205 initialized, to pacify gcc -Wuninitialized.
207 * fileio.c: Report proper errno when syscall falls.
208 (Finsert_file_contents): Save and restore errno,
209 so that report_file_error outputs the correct diagnostic.
210 (Fwrite_region) [CLASH_DETECTION]: Likewise.
212 2011-09-18 Eli Zaretskii <eliz@gnu.org>
214 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
216 2011-09-17 Eli Zaretskii <eliz@gnu.org>
218 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
219 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
221 2011-09-17 Eli Zaretskii <eliz@gnu.org>
223 * xdisp.c (reseat_at_next_visible_line_start): Keep information
224 about the current paragraph and restore it after the call to
227 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
228 (bidi_find_paragraph_start): Search back for paragraph beginning
229 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
230 (bidi_move_to_visually_next): Only trigger paragraph-related
231 computations when the last character is a newline or at EOB, not
232 just any NEUTRAL_B. (Bug#9470)
234 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
235 truncated lines if point is covered by a display string. (Bug#9524)
237 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
239 * xselect.c: Relax test for outgoing X longs (Bug#9498).
240 (cons_to_x_long): New function.
241 (lisp_data_to_selection_data): Use it. Correct the test for
242 short-versus-long data; it was negated. Break out of vector
243 loop, for efficiency, when a long datum is discovered.
245 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
247 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
249 2011-09-16 Eli Zaretskii <eliz@gnu.org>
251 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
252 GCC PR/17406) by declaring this function with external scope.
254 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
256 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
257 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
259 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
261 * editfns.c (Fformat): Correctly handle text properties on "%%".
263 2011-09-15 Eli Zaretskii <eliz@gnu.org>
265 * xterm.c (x_draw_composite_glyph_string_foreground):
266 * w32term.c (x_draw_composite_glyph_string_foreground):
267 * term.c (encode_terminal_code):
268 * composite.c (composition_update_it, get_composition_id):
269 * xdisp.c (get_next_display_element)
270 (fill_composite_glyph_string): Add comments about special meaning
271 of TAB characters in a composition.
273 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
275 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
276 This occurs when processing a multibyte format.
277 Problem reported by Wolfgang Jenker.
279 2011-09-15 Johan Bockgård <bojohan@gnu.org>
281 * xdisp.c (try_cursor_movement): Only check for exact match if
282 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
284 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
286 Remove unused external symbols.
287 * dispextern.h (calc_pixel_width_or_height): Remove decl.
288 * xdisp.c (calc_pixel_width_or_height): Now static.
289 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
290 * indent.c (check_display_width):
291 * w32term.c: Fix comment to match code.
292 * xterm.c, xterm.h (x_catching_errors): Remove.
294 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
296 * xselect.c: Use signed conversions more consistently (Bug#9498).
297 (selection_data_to_lisp_data): Assume incoming selection data are
298 signed integers, not unsigned. This is to be consistent with
299 outgoing selection data, which was modified to use signed integers
300 in as part of the fix to Bug#9196 in response to Jan D.'s comment
301 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
302 expects long, not unsigned long.
304 2011-09-14 Eli Zaretskii <eliz@gnu.org>
306 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
307 computation of loop end. Reported by Johan Bockgård
310 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
312 * frame.c (Fother_visible_frames_p): Function deleted.
314 2011-09-12 Eli Zaretskii <eliz@gnu.org>
316 * indent.c (compute_motion): Process display vector front to back
317 rather than the other way around. (Bug#2496)
319 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
321 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
323 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
325 * minibuf.c (Fread_from_minibuffer): Doc fix.
327 2011-09-11 Eli Zaretskii <eliz@gnu.org>
329 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
330 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
332 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
334 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
335 value for non-existent files.
337 2011-09-11 Eli Zaretskii <eliz@gnu.org>
339 * fileio.c (Finsert_file_contents): If the file cannot be opened,
340 set its "size" to -1. This will set the modtime_size field of
341 the corresponding buffer to -1, which is what
342 verify-visited-file-modtime expects for files that do not exist.
345 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
347 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
349 * lisp.h: ... from here. push_key_description is no longer
350 defined in keyboard.c, so its declaration should not be in
351 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
352 logically belongs with push_key_description.
354 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
356 * buffer.h: Include <sys/types.h> instead of <time.h>.
357 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
358 Problem reported by Herbert J. Skuhra.
360 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
362 * xml.c (parse_region): Make the parsing work for
363 non-comment-starting XML files again (bug#9144).
365 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
367 * image.c (gif_load): Fix calculation of bottom and right corner.
370 2011-09-10 Eli Zaretskii <eliz@gnu.org>
372 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
373 redisplay in small windows.
375 2011-09-09 Eli Zaretskii <eliz@gnu.org>
377 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
379 2011-09-08 Martin Rudalics <rudalics@gmx.at>
381 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
382 Operate on live windows only.
384 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
386 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
388 2011-09-07 Eli Zaretskii <eliz@gnu.org>
390 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
391 only under bidi iteration.
393 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
395 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
397 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
399 isnan: Fix porting problem to Solaris 10 with bundled gcc.
400 Without this fix, the command to link temacs failed due to an
401 undefined symbol __builtin_isnan. This is because
402 /usr/include/iso/math_c99.h #defines isnan(x) to
403 __builtin_isnan(x), but the bundled gcc, which identifies itself
404 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
406 * floatfns.c (isnan): #undef, and then #define to a clone of
408 (Fisnan): Always define, since it's always available now.
409 (syms_of_floatfns): Always define isnan at the Lisp level.
411 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
413 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
415 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
417 * fileio.c: Fix bugs with large file offsets (Bug#9428).
418 The previous code assumed that file offsets (off_t values) fit in
419 EMACS_INT variables, which is not true on typical 32-bit hosts.
420 The code messed up by falsely reporting buffer overflow in cases
421 such as (insert-file-contents "big" nil 1 2) into an empty buffer
422 when "big" contains more than 2**29 bytes, even though this
423 inserts just one byte and does not overflow the buffer.
424 (Finsert_file_contents): Store file offsets as off_t
425 values, not as EMACS_INT values. Check for overflow when
426 converting between EMACS_INT and off_t. When checking for
427 buffer overflow or for overlap, take the offsets into account.
428 Don't use EMACS_INT for small values where int suffices.
429 When checking for overlap, fix a typo: ZV was used where
430 ZV_BYTE was intended.
431 (Fwrite_region): Don't assume off_t fits into 'long'.
432 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
434 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
436 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
438 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
440 sprintf-related integer and memory overflow issues (Bug#9412).
442 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
443 (esprintf, exprintf, evxprintf): New functions.
444 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
445 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
446 (modify_event_symbol): Do not assume that the length of
447 name_alist_or_stem is safe to alloca and fits in int.
448 (Fexecute_extended_command): Likewise for function name and binding.
449 (Frecursion_depth): Wrap around reliably on integer overflow.
450 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
451 since some callers pass EMACS_INT values.
452 (Fsingle_key_description): Don't crash if symbol name contains more
453 than MAX_ALLOCA bytes.
454 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
455 (get_minibuffer): Arg is now EMACS_INT, not int.
456 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
457 (esprintf, exprintf, evxprintf): New decls.
458 * window.h (command_loop_level, minibuf_level): Reflect API changes.
460 * dbusbind.c (signature_cat): New function.
461 (xd_signature, Fdbus_register_signal):
462 Do not overrun buffer; instead, report string overflow.
464 * dispnew.c (add_window_display_history): Don't overrun buffer.
465 Truncate instead; this is OK since it's just a log.
467 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
468 even if the time zone offset is outlandishly large.
469 Don't mishandle offset == INT_MIN.
471 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
472 when creating daemon; the previous buffer-overflow check was incorrect.
474 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
475 which has the guts of the old verror function.
477 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
478 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
480 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
481 (font_unparse_xlfd): Don't blindly alloca long strings.
482 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
483 fits in int, when using sprintf. Use single snprintf to count
484 length of string rather than counting it via multiple sprintfs;
485 that's simpler and more reliable.
486 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
487 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
488 sprintf, in case result does not fit in int.
490 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
491 (fontset_from_font): Print it.
493 * frame.c (tty_frame_count): Now printmax_t, not int.
494 (make_terminal_frame, set_term_frame_name): Print it.
495 (x_report_frame_params): In X, window IDs are unsigned long,
496 not signed long, so print them as unsigned.
497 (validate_x_resource_name): Check for implausibly long names,
498 and don't assume name length fits in 'int'.
499 (x_get_resource_string): Don't blindly alloca invocation name;
500 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
503 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
504 (xg_check_special_colors, xg_set_geometry):
505 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
507 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
508 Use esprintf, not sprintf, in case result does not fit in int.
510 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
511 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
512 it as a large positive number.
513 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
514 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
516 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
517 in case result does not fit in int.
519 * print.c (float_to_string): Detect width overflow more reliably.
520 (print_object): Make sprintf buffer a bit bigger, to avoid potential
521 buffer overrun. Don't assume list length fits in 'int'. Treat
522 print length of 0 as 0, not as infinity; to be consistent with other
523 uses of print length in this function. Don't overflow print length
524 index. Don't assume hash table size fits in 'long', or that
525 vectorlike size fits in 'unsigned long'.
527 * process.c (make_process): Use printmax_t, not int, to format
528 process-name gensyms.
530 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
532 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
533 to avoid potential buffer overrun.
535 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
536 if X resource line is longer than 512 bytes.
538 * xfns.c (x_window): Make sprintf buffer a bit bigger
539 to avoid potential buffer overrun.
541 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
543 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
545 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
547 Integer overflow fixes for scrolling, etc.
548 Without these, Emacs silently mishandles large integers sometimes.
549 For example, "C-u 4294967297 M-x recenter" was treated as if
550 it were "C-u 1 M-x recenter" on a typical 64-bit host.
552 * xdisp.c (try_window_id): Check Emacs fixnum range before
555 * window.c (window_scroll_line_based, Frecenter):
556 Check that an Emacs fixnum is in range before assigning it to 'int'.
557 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
558 values converted from Emacs fixnums.
559 (Frecenter): Don't wrap around a line count if it is out of 'int'
560 range; instead, treat it as an extreme value.
561 (Fset_window_configuration, compare_window_configurations):
562 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
564 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
565 that can exceed INT_MAX. Check that EMACS_INT value is in range
566 before assigning it to the (possibly-narrower) index.
567 (match_limit): Don't assume that a fixnum can fit in 'int'.
569 * print.c (print_object): Use ptrdiff_t, not int, for index that can
572 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
573 (Fvertical_motion): Don't wrap around LINES values that don't fit
574 in 'int'. Instead, treat them as extreme values. This is good
575 enough for windows, which can't have more than INT_MAX lines anyway.
577 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
579 * Require libxml/parser.h to avoid compilation warning.
581 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
583 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
584 since this reportedly can destroy thread storage.
586 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
588 * syntax.c (find_defun_start): Update all cache variables if
589 exiting early (Bug#9401).
591 2011-08-30 Eli Zaretskii <eliz@gnu.org>
593 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
595 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
596 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
597 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
599 * term.c (tty_append_glyph): New function.
600 (produce_stretch_glyph): Static function and its prototype deleted.
602 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
605 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
607 * image.c (parse_image_spec): Check for nonnegative, not for positive,
608 when checking :margin (Bug#9390).
609 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
610 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
611 so that the name doesn't mislead. All uses changed.
613 2011-08-28 Johan Bockgård <bojohan@gnu.org>
615 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
618 2011-08-27 Eli Zaretskii <eliz@gnu.org>
620 * xdisp.c (move_it_to): Don't bail out early when reaching
621 position beyond to_charpos, if we are scanning backwards.
622 (move_it_vertically_backward): When DY == 0, make sure we get to
623 the first character in the line after the newline.
625 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
627 * ccl.c: Improve and simplify overflow checking (Bug#9196).
628 (ccl_driver): Do not generate an out-of-range pointer.
629 (Fccl_execute_on_string): Remove unnecessary check for
630 integer overflow, noted by Stefan Monnier in
631 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
632 Remove a FIXME that didn't need fixing.
633 Simplify the newly-introduced buffer reallocation code.
635 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
637 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
639 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
641 Integer and memory overflow issues (Bug#9196).
643 * doc.c (get_doc_string): Rework so that
644 get_doc_string_buffer_size is the actual buffer size, rather than
645 being 1 less than the actual buffer size; this makes xpalloc more
648 * image.c (x_allocate_bitmap_record, cache_image):
649 * xselect.c (Fx_register_dnd_atom):
650 Simplify previous changes by using xpalloc.
652 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
653 since either will do and ptrdiff_t is convenient with xpalloc.
655 * charset.c (charset_table_size)
656 (struct charset_sort_data.priority): Now ptrdiff_t.
657 (charset_compare): Don't overflow if priorities differ greatly.
658 (Fsort_charsets): Don't assume list length fits in int.
659 Check for size-calculation overflow when allocating sort data.
660 (syms_of_charset): Allocate an initial charset table that is
661 just under 64 KiB, to avoid problems with glibc malloc and mmap.
663 * cmds.c (internal_self_insert): Check for size-calculation overflow.
665 * composite.h (struct composition.glyph_len): Now int, not unsigned.
666 The actual value is always <= INT_MAX, and leaving it unsigned made
667 overflow checking harder.
669 * dispextern.h (struct glyph_matrix.rows_allocated)
670 (struct face_cache.size): Now ptrdiff_t, for convenience in use
671 with xpalloc. The values are still always <= INT_MAX.
673 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
675 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
676 (SAFE_NALLOCA): New macro.
678 * region-cache.c (struct boundary.pos, find_cache_boundary)
679 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
680 (set_cache_region, invalidate_region_cache)
681 (revalidate_region_cache, know_region_cache, region_cache_forward)
682 (region_cache_backward, pp_cache):
683 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
684 so that ptrdiff_t * can be passed to xpalloc.
685 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
686 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
687 (pp_cache): Don't assume cache_len fits in int.
688 * region-cache.h: Adjust extern decls to match.
690 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
691 EMACS_INT, since either will do, for xpalloc.
693 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
694 (xnmalloc, xnrealloc, xpalloc): New functions.
696 * bidi.c (bidi_shelve_header_size): New constant.
697 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
698 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
700 * bidi.c (bidi_cache_shrink):
701 * buffer.c (overlays_at, overlays_in, record_overlay_string)
703 Don't update size of array until after memory allocation succeeds,
704 because xmalloc/xrealloc may not return.
705 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
706 now that we have proper integer overflow checking.
707 (record_overlay_string, overlay_strings): Catch overflows when
708 calculating size of overlay_str_buf.
710 * callproc.c (Fcall_process): Check for size overflow when
711 calculating size of args2.
712 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
713 Normally we prefer signed values, but sticking with ptrdiff_t would
714 require adding more-complicated checks.
716 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
717 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
718 Redo buffer-overflow calculations to avoid integer overflow.
719 Add a FIXME comment where memory seems to be over-allocated.
721 * character.c (Fstring): Check for size-calculation overflow.
723 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
724 unnecessary integer overflow. Check for size overflow.
725 (encode_coding_object): Don't update size until xmalloc succeeds.
727 * composite.c (get_composition_id): Check for overflow in glyph
730 Integer and memory overflow fixes for display code.
731 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
732 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
733 (scrolling_window): Check for overflow in size calculations.
734 (line_draw_cost, realloc_glyph_pool, add_row_entry):
735 Don't assume glyph table len fits in int.
736 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
737 (row_table_size): Now ptrdiff_t, not int.
738 (scrolling_window): Avoid overflow in size calculations.
739 Don't update size until allocation succeeds.
740 * fns.c (concat): Check for overflow in size calculations.
741 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
742 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
743 (NEXT_ALMOST_PRIME_LIMIT): New constant.
745 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
746 (get_doc_string): Check for size calculation overflow.
747 Don't update size until allocation succeeds.
748 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
749 EMACS_INT, where ptrdiff_t will do.
750 (Fsubstitute_command_keys): Check for string overflow.
752 * editfns.c (set_time_zone_rule): Don't assume environment length
754 (message_length): Now ptrdiff_t, not int.
755 (Fmessage_box): Don't update size until allocation succeeds.
756 Don't assume message length fits in int.
757 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
759 * emacs.c (main): Do not reallocate argv, since there is a null at
760 the end that can be overwritten, and this way there's no need to
761 worry about size-calculation overflow.
762 (sort_args): Check for size-calculation overflow.
764 * eval.c (init_eval_once, grow_specpdl): Don't update size until
766 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
768 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
769 (x_set_scroll_bar_width, x_figure_window_size):
770 Check for integer overflow.
771 (x_set_alpha): Do not assume XINT fits in int.
773 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
774 This is for the members text_lines, text_cols, total_lines, total_cols,
775 where the system imposes an 'int' limit.
777 * fringe.c (Fdefine_fringe_bitmap):
778 Don't update size until alloc works.
780 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
781 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
783 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
784 Check for size-calculation overflow.
785 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
786 do, as we prefer signed integers.
787 (id_to_widget.max_size, id_to_widget.used)
788 (xg_store_widget_in_map, xg_remove_widget_from_map)
789 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
790 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
791 Use and return ptrdiff_t, not int.
792 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
793 * gtkutil.h: Change prototypes to match the above.
795 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
796 are duplicate now that they've been promoted to lisp.h.
797 (x_allocate_bitmap_record, x_alloc_image_color)
798 (make_image_cache, cache_image, xpm_load):
799 Don't update size until alloc is done.
800 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
802 Check for size calculation overflow.
803 (ct_colors_allocated_max): New constant.
804 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
807 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
808 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
809 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
810 Use ptrdiff_t, not int, to count maps.
811 (read_char_minibuf_menu_prompt): Check for overflow in size
812 calculations. Don't update size until allocation succeeds. Redo
813 calculations to avoid overflow.
814 * keyboard.h: Change prototypes to match the above.
816 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
818 (current_minor_maps): Check for size calculation overflow.
819 * keymap.h: Change prototypes to match the above.
821 * lread.c (read1, init_obarray): Don't update size until alloc done.
823 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
824 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
826 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
827 Now ptrdiff_t, not int.
828 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
829 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
831 * process.c (Fnetwork_interface_list): Check for overflow
834 * region-cache.c (move_cache_gap): Check for size calculation overflow.
836 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
837 overflow. Don't bother calling xmalloc when xrealloc will do.
839 * search.c (Freplace_match): Check for size calculation overflow.
840 (Fset_match_data): Don't assume list lengths fit in 'int'.
842 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
843 for command line length. Do not attempt to address one before the
844 beginning of an array, as that's not portable.
846 * term.c (max_frame_lines): Remove; unused.
847 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
849 (encode_terminal_code, calculate_costs): Check for size
850 calculation overflow.
851 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
852 table lengths and related sizes. Don't update size until alloc
853 done. Redo calculations to avoid overflow.
854 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
856 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
857 subtracting pointers.
858 (gobble_line): Check for overflow more carefully. Don't update size
861 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
862 Don't update size until alloc done.
863 Redo size calculations to avoid overflow.
864 Check for size calculation overflow.
865 (main) [DEBUG]: Fix typo in invoking tparam1.
867 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
868 Use ptrdiff_t, not int, for sizes.
869 (store_mode_line_noprop_char): Don't update size until alloc done.
871 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
872 Use ptrdiff_t, not int, for sizes.
873 (Finternal_make_lisp_face, cache_face):
874 Check for size calculation overflow.
875 (cache_face): Treat size calculation overflows as if they were
876 memory exhaustion (the usual treatment), rather than aborting.
878 * xfns.c (x_encode_text, x_set_name_internal)
879 (Fx_change_window_property): Use ptrdiff_t, not int, to count
880 sizes, since they can exceed INT_MAX in size. Check for size
881 calculation overflow.
883 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
884 (xg_select): Check for size calculation overflow.
885 Don't update size until alloc done.
887 * xrdb.c (get_environ_db): Don't assume path length fits in int,
888 as sprintf is limited to int lengths.
890 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
891 (X_LONG_MIN): New macros.
892 Use them to make the following changes clearer.
893 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
894 This change doesn't affect the value now, but it may help remind
895 future maintainers not to raise the value too much later.
896 (SELECTION_QUANTUM): Remove, replacing with ...
897 (selection_quantum): ... new function, which avoids overflow.
899 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
900 assumption that selection length fits in 'int'.
901 (x_reply_selection_request, x_handle_selection_request)
902 (x_get_window_property, receive_incremental_selection)
903 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
904 (lisp_data_to_selection_data, clean_local_selection_data):
905 Use ptrdiff_t, not int, to record length of selection.
906 (x_reply_selection_request, x_get_window_property)
907 (receive_incremental_selection, x_property_data_to_lisp):
908 Redo calculations to avoid overflow.
909 (x_reply_selection_request): When sending hint, ceiling it at
910 X_LONG_MAX rather than relying on wraparound overflow to send
912 (x_get_window_property, receive_incremental_selection)
913 (lisp_data_to_selection_data, x_property_data_to_lisp):
914 Check for size-calculation overflow.
915 (x_get_window_property, receive_incremental_selection)
916 (lisp_data_to_selection_data, Fx_register_dnd_atom):
917 Don't store size until memory allocation succeeds.
918 (x_get_window_property): Plug memory leak on memory exhaustion.
919 Don't double-block input; malloc is safe here. Don't assume 2**34
920 - 4 fits in unsigned long. Add an xassert to check
921 XGetWindowProperty overflow. Be more careful about overflow
922 calculations, and distinguish size from memory overflow better.
923 (receive_incremental_selection): When tracing, don't assume
924 unsigned int is less than INT_MAX.
925 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
926 harmful) conversions of unsigned short to int.
927 (lisp_data_to_selection_data): Don't assume that integers
928 in the range -65535 through -1 fit in an X unsigned short.
929 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
930 result parameters unless successful. Rely on cons_to_unsigned
931 to report problems with elements; the old code wasn't right anyway.
932 (x_check_property_data): Check for int overflow; we cannot use
933 a wider type due to X limits.
934 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
936 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
938 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
939 (x_term_init): Check for size calculation overflow.
940 (x_color_cells): Don't store size until memory allocation succeeds.
941 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
942 Don't assume alloca size is less than MAX_ALLOCA.
943 (x_term_init): Don't assume length fits in int (sprintf is limited
946 Use ptrdiff_t for composition IDs.
947 * character.c (lisp_string_width):
948 * composite.c (composition_table_size, n_compositions)
949 (get_composition_id, composition_gstring_from_id):
950 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
951 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
952 * window.c (Frecenter):
953 Use ptrdiff_t, not int, for composition IDs.
954 * composite.c (get_composition_id): Check for integer overflow.
955 * composite.h: Adjust prototypes to match the above changes.
957 Use ptrdiff_t for hash table indexes.
958 * category.c (hash_get_category_set):
959 * ccl.c (ccl_driver):
960 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
961 * coding.c (coding_system_charset_list, detect_coding_system):
962 * coding.h (struct coding_system.id):
963 * composite.c (get_composition_id, gstring_lookup_cache):
964 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
965 * image.c (xpm_get_color_table_h):
966 * lisp.h (hash_lookup, hash_put):
967 * minibuf.c (Ftest_completion):
968 Use ptrdiff_t for hash table indexes, not int (which is too
969 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
970 32-bit --with-wide-int hosts).
972 * charset.c (Fdefine_charset_internal): Check for integer overflow.
973 Add a FIXME comment about memory leaks.
974 (syms_of_charset): Don't assume xmalloc returns.
976 Don't assume that stated character widths fit in int.
977 * character.c (Fchar_width, c_string_width, lisp_string_width):
978 * character.h (CHAR_WIDTH):
979 * indent.c (MULTIBYTE_BYTES_WIDTH):
980 Use sanitize_char_width to avoid undefined and/or bad behavior
981 with outlandish widths.
982 * character.h (sanitize_tab_width): Renamed from sanitize_width,
983 now that we have two such functions. All uses changed.
984 (sanitize_char_width): New inline function.
986 Don't assume that tab-width fits in int.
987 * character.h (sanitize_width): New inline function.
988 (SANE_TAB_WIDTH): New macro.
989 (ASCII_CHAR_WIDTH): Use it.
990 * indent.c (sane_tab_width): Remove. All uses replaced by
991 SANE_TAB_WIDTH (current_buffer).
992 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
994 * fileio.c: Integer overflow issues with file modes.
995 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
997 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
998 Remove unreachable code.
999 (read_hex, load_charset_map_from_file): Check for integer overflow.
1001 * xterm.c: don't go over XClientMessageEvent limit
1002 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1003 (x_send_scroll_bar_event): Likewise. Check that the size does not
1004 exceed limits imposed by XClientMessageEvent, as well as the usual
1005 ptrdiff_t and size_t limits.
1007 * keyboard.c: Overflow, signedness and related fixes.
1008 (make_lispy_movement): Use same integer type in forward decl
1009 that is used in the definition.
1010 (read_key_sequence, keyremap_step):
1011 Change bufsize argument back to int, undoing my 2011-03-30 change.
1012 We prefer signed types, and int is wide enough here.
1013 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1014 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1015 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1016 length, not size_t. Use ptrdiff_t for index, not int.
1017 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1018 possibility of integer overflow.
1020 Overflow, signedness and related fixes for images.
1022 * dispextern.h (struct it.stack[0].u.image.image_id)
1023 (struct_it.image_id, struct image.id, struct image_cache.size)
1024 (struct image_cache.used, struct image_cache.ref_count):
1025 * gtkutil.c (update_frame_tool_bar):
1026 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1027 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1028 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1029 * nsmenu.m (update_frame_tool_bar):
1030 * xdisp.c (calc_pixel_width_or_height):
1031 * xfns.c (image_cache_refcount):
1032 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1033 on typical 64-bit hosts.
1035 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1036 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1037 Omit unnecessary casts to int.
1038 (parse_image_spec): Check that integers fall into 'int' range
1039 when the callers expect that.
1040 (image_ascent): Redo ascent calculation to avoid int overflow.
1041 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1042 (lookup_image): Remove unnecessary tests.
1043 (xbm_image_p): Locals are now of int, not EMACS_INT,
1044 since parse_image_check makes sure they fit into int.
1045 (png_load, gif_load, svg_load_image):
1046 Prefer int to unsigned where either will do.
1047 (tiff_handler): New function, combining the cores of the
1048 old tiff_error_handler and tiff_warning_handler. This
1049 function is rewritten to use vsnprintf and thereby avoid
1050 stack buffer overflows. It uses only the features of vsnprintf
1051 that are common to both POSIX and native Microsoft.
1052 (tiff_error_handler, tiff_warning_handler): Use it.
1053 (tiff_load, gif_load, imagemagick_load_image):
1054 Don't assume :index value fits in 'int'.
1055 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1056 (imagemagick_load_image): Check that crop parameters fit into
1057 the integer types that MagickCropImage accepts. Don't assume
1058 Vimagemagick_render_type has a nonnegative value. Don't assume
1059 size_t fits in 'long'.
1060 (gs_load): Use printmax_t to print the widest integers possible.
1061 Check for integer overflow when computing image height and width.
1063 2011-08-26 Eli Zaretskii <eliz@gnu.org>
1065 * xdisp.c (redisplay_window): Don't force window start if point
1066 will be invisible in the resulting window. (Bug#9324)
1068 2011-08-25 Eli Zaretskii <eliz@gnu.org>
1070 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1071 the display spec is of the form `(space ...)'.
1072 (handle_display_spec): Return the value returned by
1073 handle_single_display_spec, not just 1 or zero.
1074 (handle_single_display_spec): If the display spec is of the form
1075 `(space ...)', and specifies display in the text area, return 2
1077 (try_cursor_movement): Check for the need to scroll more
1078 accurately, and prefer exact match for point under bidi. Don't
1079 advance `row' beyond the last row of the window.
1081 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1082 into disp_prop; all users changed.
1084 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1085 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1086 for the text covered by the display property.
1088 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
1090 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1091 Change return value to nil.
1092 (Frecord_buffer): Delete unused function.
1094 2011-08-24 Eli Zaretskii <eliz@gnu.org>
1096 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1097 buffers, return left-to-right.
1098 (set_cursor_from_row): Consider candidate row a win if its glyph
1099 represents a newline and point is on that newline. Fixes cursor
1100 positioning on the newline at EOL of R2L text within L2R
1101 paragraph, and vice versa.
1102 (try_cursor_movement): Check continued rows, in addition to
1103 continuation rows. Fixes unwarranted scroll when point enters a
1104 continued line of R2L text within an L2R paragraph, or vice versa.
1105 (cursor_row_p): Consider the case of point being equal to
1106 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1107 from the end of a short line to the beginning of a continued line
1108 of R2L text within L2R paragraph.
1109 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1110 composed characters.
1112 * bidi.c (bidi_check_type): Use xassert.
1113 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1116 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1118 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1121 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
1123 * nsfont.m (ns_otf_to_script): Fix typo.
1125 2011-08-22 Kenichi Handa <handa@m17n.org>
1127 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1128 extra slot even if the purpose is char-code-property-table.
1130 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1132 * xdisp.c (redisplay_window): When computing centering_position,
1133 account for the height of the header line. (Bug#8874)
1135 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1136 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1137 candidate is selected by the mouse, and that candidate has a
1138 composed character under the mouse.
1140 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1141 coordinates reported by pos-visible-in-window-p for a composed
1142 character in column zero.
1144 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1146 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1148 2011-08-22 Eli Zaretskii <eliz@gnu.org>
1150 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1151 consider it a hit if to_charpos is anywhere in the range of the
1152 composed buffer positions.
1154 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
1156 * image.c (gif_load): Don't assume that each subimage has the same
1157 dimensions as the base image. Handle disposal method that is
1158 "undefined" by the gif spec (Bug#9335).
1160 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
1162 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
1163 (Fcondition_case): Document `debug' symbol in error handler.
1165 2011-08-19 Eli Zaretskii <eliz@gnu.org>
1167 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1168 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1169 from an Org mode buffer to a Speedbar frame.
1171 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1172 a composition, take its buffer position from IT->cmp_it.charpos.
1173 Fixes cursor positioning at the beginning of a line that begins
1174 with a composed character.
1176 2011-08-18 Eli Zaretskii <eliz@gnu.org>
1178 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1179 character bidirectional type, use STRONG_L instead. Fixes crashes
1180 in a buffer produced by `describe-categories'.
1182 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1183 members before the level stack, so they would be saved and
1184 restored when copying iterator state. Fixes incorrect reordering
1185 around TABs covered by display properties.
1187 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1189 * process.c (Fnetwork_interface_list): Correctly determine buffer
1192 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
1194 * eval.c (internal_condition_case, internal_condition_case_1)
1195 (internal_condition_case_2, internal_condition_case_n):
1196 Remove unnecessary aborts (Bug#9081).
1198 2011-08-17 Eli Zaretskii <eliz@gnu.org>
1200 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1201 has no `load' handler, try opening the file locally. (Bug#9311)
1203 2011-08-16 Ken Brown <kbrown@cornell.edu>
1205 * gmalloc.c: Expand comment.
1207 2011-08-16 Eli Zaretskii <eliz@gnu.org>
1209 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1210 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1212 2011-08-16 Ken Brown <kbrown@cornell.edu>
1214 Fix memory allocation problems in Cygwin build (Bug#9273).
1216 * unexcw.c ( __malloc_initialized): Declare external variable.
1217 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1219 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1221 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1223 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1225 [CYGWIN] (special_realloc): New function.
1226 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1227 requests to realloc storage in the static heap.
1229 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1231 * bidi.c (bidi_initialize): Remove unused local.
1233 2011-08-15 Eli Zaretskii <eliz@gnu.org>
1235 * biditype.h: File removed.
1237 * bidimirror.h: File removed.
1239 * deps.mk (bidi.o): Remove biditype.h and
1242 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
1245 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1247 * chartab.c: Improve commentary for the uniprop_table API.
1249 * bidi.c (bidi_paragraph_init): Support zero value of
1250 bidi_ignore_explicit_marks_for_paragraph_level.
1251 (bidi_initialize): Use uniprop_table instead of including
1252 biditype.h and bidimirror.h.
1254 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1255 coordinates of the iterator when restoring from ppos_it.
1258 2011-08-14 Kenichi Handa <handa@m17n.org>
1260 * process.c (create_process): Call setup_process_coding_systems
1261 after the pid of the process is set to -1 (Bug#8162).
1263 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1265 * xdisp.c (move_it_in_display_line_to): Don't invoke
1266 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1267 ppos_it. Fixes vertical cursor motion when line beginning is
1268 covered by an image. (Bug#9296)
1270 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1272 * nsterm.h (ns_run_ascript): Declare.
1273 (NSAPP_DATA2_RUNASSCRIPT): Define.
1275 * nsfns.m (as_script, as_result, as_status): New static variables.
1276 (ns_run_ascript): New function.
1277 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1278 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1279 the event loop. Get status from as_status (Bug#7276).
1281 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1282 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1283 the event loop (Bug#7276).
1285 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1287 * gnutls.c (QCgnutls_bootprop_priority)
1288 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1289 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1290 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1291 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1292 (QCgnutls_bootprop_verify_hostname_error)
1293 (QCgnutls_bootprop_callbacks_verify): Rename from
1294 Qgnutls_bootprop_..., all uses changed.
1296 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1299 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1301 * xfaces.c (Qframe_set_background_mode): Now static.
1302 * dispextern.h (Qframe_set_background_mode): Remove decl.
1304 * process.c (Fnetwork_interface_info): Declare local only if needed.
1306 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1308 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1309 (Fnetwork_interface_list): Allocate in increments of bytes instead
1310 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1311 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1313 (struct ifflag_def): notrailers is smart on OSX.
1314 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1315 Get hardware address with getifaddrs if available.
1317 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1319 * xdisp.c (iterate_out_of_display_property): xassert that
1320 IT->position is set to within IT->object's boundaries. Break from
1321 the loop as soon as EOB is reached; avoids infloops in redisplay
1322 when IT->position is set up wrongly due to some bug.
1323 Set IT->current to match the bidi iterator unconditionally.
1324 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1325 entry. Force push_it to save on the stack the current
1326 buffer/string position, to be restored by pop_it. Fix flags in
1327 the iterator structure wrt the object coming from a display
1328 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1329 properties. (Bug#9284)
1331 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1333 * fontset.c (fontset_get_font_group): Add proper type checks.
1336 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1338 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1339 and LC_VERSION_MIN_MACOSX.
1340 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1341 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1343 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1345 * xdisp.c (forward_to_next_line_start): Allow to use the
1346 no-display-properties-and-no-overlays under bidi display.
1347 Set disp_pos in the bidi iterator to avoid searches for display
1348 properties and overlays.
1350 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1352 * editfns.c (Fset_time_zone_rule): Document relationship with the
1355 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1356 the font entity extracted from the cache (Bug#8109).
1358 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1360 * composite.c (autocmp_chars): Don't reset point. That is done by
1361 restore_point_unwind (Bug#5984).
1363 2011-08-07 Juri Linkov <juri@jurta.org>
1365 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1366 to show the arg `TIME' instead of `TIMEVAL'.
1368 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1370 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1371 display property strides EOL and includes a newline, as in
1372 longlines-mode. (Bug#9254)
1373 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1374 word-wrap under bidirectional display. (Bug#9224)
1376 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1377 is non-zero, even if the data buffer is NULL. Fixes a crash in
1378 vertical-motion with longlines-mode. (Bug#9254)
1380 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1382 * bidi.c <bidi_cache_total_alloc>: Now static.
1383 (bidi_initialize): Initialize bidi_cache_total_alloc.
1385 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1388 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1389 amount allocated this far in `bidi_cache_total_alloc'.
1390 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1391 non-zero, only free the data buffer without restoring the cache
1392 contents. All callers changed.
1394 * dispextern.h (bidi_unshelve_cache): Update prototype.
1396 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1397 (move_it_in_display_line, move_it_to)
1398 (move_it_vertically_backward, move_it_by_lines): Replace the call
1399 to xfree to an equivalent call to bidi_unshelve_cache.
1400 (move_it_in_display_line_to): Fix logic of returning
1401 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1403 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1405 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1406 came from a string character with a `cursor' property. (Bug#9229)
1408 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1410 * Makefile.in (LIB_PTHREAD): New variable.
1411 (LIBES): Add LIB_PTHREAD (Bug#9216).
1413 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1414 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1416 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1418 * regex.c (re_iswctype): Remove some redundant boolean
1421 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1423 * xterm.c (x_find_topmost_parent): New function.
1424 (x_set_frame_alpha): Find topmost parent window with
1425 x_find_topmost_parent and set the property there also (bug#9181).
1426 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1428 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1430 * callproc.c (Fcall_process): Avoid vfork clobbering
1431 the local vars buffer, coding_systems, current_dir.
1433 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1435 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1437 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1439 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1440 so that it is not optimized away.
1442 * xdisp.c (compute_display_string_pos): Remove unused local.
1444 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1446 Fix slow cursor motion and scrolling in large buffers with
1447 selective display, like Org Mode buffers. (Bug#9218)
1449 * dispextern.h (struct bidi_it): New member disp_prop_p.
1451 * xdisp.c: Remove one-slot cache of display string positions.
1452 (compute_display_string_pos): Accept an additional argument
1453 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1454 for a display string or property. If found, set DISP_PROP_P
1457 * bidi.c (bidi_fetch_char): Accept an additional argument
1458 DISP_PROP_P, and pass it to compute_display_string_pos.
1459 Only handle text covered by a display string if DISP_PROP_P is returned
1460 non-zero. All callers of bidi_fetch_char changed.
1462 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1464 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1466 2010-12-03 Don March <don@ohspite.net>
1468 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1469 last character M-[char] is translated to ESC [char] (bug#7541).
1471 2011-08-02 Kenichi Handa <handa@m17n.org>
1473 * lisp.h (uniprop_table): Extern it.
1475 * chartab.c (uniprop_table): Make it non-static.
1477 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1479 * xdisp.c (forward_to_next_line_start): Accept additional argument
1480 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1482 (reseat_at_next_visible_line_start): Use the bidi iterator state
1483 returned by forward_to_next_line_start to restore the state of
1484 it->bidi_it after backing up to previous newline. (Bug#9212)
1486 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1488 * regex.c (re_comp): Protoize.
1489 (re_exec): Fix return type.
1490 (regexec): Fix type of `ret'. (Bug#9203)
1492 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1494 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1495 This is needed if max-image-size is a floating-point number.
1497 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1499 * print.c (print_object): Print empty symbol as ##.
1501 * lread.c (read1): Read ## as empty symbol.
1503 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1505 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1506 setting frame foreground color (Bug#9175).
1507 (x_set_background_color): Likewise.
1509 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1510 contents (Bug#9176).
1511 (EmacsTooltip -init): Remove bezels and add shadows to
1514 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1515 or scroll bar (Bug#8470).
1517 * nsfont.m (nsfont_open): Remove assignment to voffset and
1518 unnecessary vars hshink, expand, hd, full_height, min_height.
1519 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1521 * nsterm.h (nsfont_info): Remove voffset field.
1523 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1525 Implement strike-through and overline on NextStep (Bug#8863).
1527 * nsfont.m (nsfont_open): Use underline position provided by font,
1528 instead of hard-coded value of 2.
1529 (nsfont_draw): Call ns_draw_text_decoration instead.
1531 * nsterm.h: Add declaration for ns_draw_text_decoration.
1533 * nsterm.m (ns_draw_text_decoration): New function for drawing
1534 underline, overline, and strike-through.
1535 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1536 ns_draw_text_decoration. Change treatment of cursor drawing to
1537 accommodate underlining, etc.
1539 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1541 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1544 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1546 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1547 Without this fix, if a signal arrives just after memory fills up,
1548 'malloc' might be invoked reentrantly.
1550 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1551 In other words, assume that every image size is allowed, on non-X
1552 hosts. This assumption is probably wrong, but it lets Emacs compile.
1554 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1556 * regex.c (re_iswctype): Convert return values to boolean.
1558 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1560 * xdisp.c (compute_display_string_pos): Don't use cached display
1561 string position if the buffer had its restriction changed.
1564 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1566 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1568 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1570 Integer signedness and overflow and related fixes. (Bug#9079)
1572 * bidi.c: Integer size and overflow fixes.
1573 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1574 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1575 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1576 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1577 (bidi_find_other_level_edge):
1578 Use ptrdiff_t instead of EMACS_INT where either will do.
1579 This works better on 32-bit hosts configured --with-wide-int.
1580 (bidi_cache_ensure_space): Check for size-calculation overflow.
1581 Use % rather than repeated addition, for better worst-case speed.
1582 Don't set bidi_cache_size until after xrealloc returns, because it
1584 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1585 (bidi_cache_ensure_space): Also check that the bidi cache size
1586 does not exceed that of the largest Lisp string or buffer. See Eli
1587 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1589 * alloc.c (__malloc_size_t): Remove.
1590 All uses replaced by size_t. See Andreas Schwab's note
1591 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1593 * image.c: Improve checking for integer overflow.
1594 (check_image_size): Assume that f is nonnull, since
1595 it is always nonnull in practice. This is one less thing to
1596 worry about when checking for integer overflow later.
1597 (x_check_image_size): New function, which checks for integer
1598 overflow issues inside X.
1599 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1600 This removes the need for a memory_full check.
1601 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1602 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1603 (xbm_read_bitmap_data): Change locals back to 'int', since
1604 their values must fit in 'int'.
1605 (xpm_load_image, png_load, tiff_load):
1606 Invoke x_create_x_image_and_pixmap earlier,
1607 to avoid much needless work if the image is too large.
1608 (tiff_load): Treat overly large images as if
1609 x_create_x_image_and_pixmap failed, not as malloc failures.
1610 (gs_load): Use x_check_image_size.
1612 * gtkutil.c: Omit integer casts.
1613 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1614 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1616 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1618 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1619 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1620 would wrongly return t on a 64-bit host.
1622 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1623 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1624 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1625 and therefore cause GCC to emit a bogus diagnostic in some cases.
1627 * image.c: Integer signedness and overflow and related fixes.
1628 This is not an exhaustive set of fixes, but it's time to
1629 record what I've got.
1630 (lookup_pixel_color, check_image_size): Remove redundant decls.
1631 (check_image_size): Don't assume that arbitrary EMACS_INT values
1632 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1633 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1634 (tiff_load, imagemagick_load_image):
1635 Check for overflow in size calculations.
1636 (x_create_x_image_and_pixmap): Remove unnecessary test for
1637 xmalloc returning NULL; that can't happen.
1638 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1639 (xpm_color_bucket): Use better integer hashing function.
1640 (xpm_cache_color): Don't possibly over-allocate memory.
1641 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1642 (gif_memory_source):
1643 Use ptrdiff_t, not int or size_t, to record sizes.
1644 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1645 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1646 either works, as we prefer signed integers.
1647 (tiff_read_from_memory, tiff_write_from_memory):
1648 Return tsize_t, not size_t, since that's what the TIFF API wants.
1649 (tiff_read_from_memory): Don't fail simply because the read would
1650 go past EOF; instead, return a short read.
1651 (tiff_load): Omit no-longer-needed casts.
1652 (Fimagemagick_types): Don't assume size fits into 'int'.
1654 Improve hashing quality when configured --with-wide-int.
1655 * fns.c (hash_string): New function, taken from sxhash_string.
1656 Do not discard information about ASCII character case; this
1657 discarding is no longer needed.
1658 (sxhash-string): Use it. Change sig to match it. Caller changed.
1659 * lisp.h: Declare it.
1660 * lread.c (hash_string): Remove, since we now use fns.c's version.
1661 The fns.c version returns a wider integer if --with-wide-int is
1662 specified, so this should help the quality of the hashing a bit.
1664 * emacs.c: Integer overflow minor fix.
1665 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1666 Define only if GNU_LINUX.
1667 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1669 * dispnew.c: Integer signedness and overflow fixes.
1670 Remove unnecessary forward decls, that were a maintenance hassle.
1671 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1673 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1674 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1675 (prepare_desired_row, line_draw_cost):
1676 Use int, not unsigned, where either works.
1677 (save_current_matrix, restore_current_matrix):
1678 Use ptrdiff_t, not size_t, where either works.
1679 (init_display): Check for overflow more accurately, and without
1680 relying on undefined behavior.
1682 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1683 Remove, replacing with the new symbols in lisp.h. All uses changed.
1684 * fileio.c (make_temp_name):
1685 * filelock.c (lock_file_1, lock_file):
1686 * xdisp.c (message_dolog):
1687 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1688 Use pMd etc. instead.
1689 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1690 replacing the pWIDE etc. symbols removed from editfns.c.
1692 * keyboard.h (num_input_events): Now uintmax_t.
1693 This is (very slightly) less likely to mess up due to wraparound.
1696 * buffer.c: Integer signedness fixes.
1697 (alloc_buffer_text, enlarge_buffer_text):
1698 Use ptrdiff_t rather than size_t when either will do, as we prefer
1701 * alloc.c: Integer signedness and overflow fixes.
1702 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1703 (__malloc_size_t): Default to size_t, not to int.
1704 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1705 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1706 Prefer ptrdiff_t to size_t when either would do, as we prefer
1708 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1709 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1710 Now const. Initialize with values that are in range even if char
1712 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1713 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1714 These functions do the right thing with sizes > 2**32.
1715 (check_depth): Now ptrdiff_t, not int.
1716 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1717 Adjust to new way of storing sizes. Check for size overflow bugs
1719 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1720 slightly wrong anyway, as it missed one instance of
1721 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1722 (refill_memory_reserve): Omit needless cast to size_t.
1723 (mark_object_loop_halt): Mark as externally visible.
1725 * xselect.c: Integer signedness and overflow fixes.
1726 (Fx_register_dnd_atom, x_handle_dnd_message):
1727 Use ptrdiff_t, not size_t, since we prefer signed.
1728 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1729 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1730 x_dnd_atoms_size and x_dnd_atoms_length.
1732 * doprnt.c: Prefer signed to unsigned when either works.
1734 * doprnt.c (doprnt):
1736 * xdisp.c (vmessage):
1737 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1738 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1739 prefer signed arithmetic to avoid comparison confusion.
1740 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1741 but is a bit tricky.
1743 Assume freestanding C89 headers, string.h, stdlib.h.
1744 * data.c, doprnt.c, floatfns.c, print.c:
1745 Include float.h unconditionally.
1746 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1747 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1748 * regex.c: Likewise for stddef.h, string.h.
1749 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1750 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1751 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1752 (STDC_HEADERS): Remove obsolete defines.
1753 * sysdep.c: Include limits.h unconditionally.
1755 Assume support for memcmp, memcpy, memmove, memset.
1756 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1757 * regex.c (memcmp, memcpy):
1758 Remove; we assume C89 now.
1760 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1761 (__malloc_safe_bcopy): Remove; no longer needed.
1763 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1764 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1765 well either way, and we prefer signed to unsigned.
1767 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1769 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1770 closes the connection while we're reading (bug#9182).
1772 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1774 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1775 are specified (Bug#9168).
1777 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1779 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1780 Found by GCC static checking and --with-wide-int on a 32-bit host.
1782 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1784 * xdisp.c (compute_display_string_pos): Fix logic of caching
1785 previous display string position. Initialize cached_prev_pos to
1786 -1. Fixes slow-down at the beginning of a buffer.
1788 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1790 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1791 for attrs[LFACE_FONTSET_INDEX].
1793 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1795 * xml.c (parse_region): Remove unused local
1796 that was recently introduced.
1798 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1800 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1801 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1803 * xdisp.c (move_it_in_display_line_to): Record the best matching
1804 position for TO_CHARPOS while scanning the line, and restore it on
1805 exit if none of the characters scanned was an exact match.
1806 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1807 when exact match is impossible due to invisible text, and the
1808 lines are truncated.
1810 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1812 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1815 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1817 Fix a significant slow-down of cursor motion with C-n, C-p,
1818 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1819 auto-repeat under bidi redisplay in fontified buffers.
1820 * xdisp.c (compute_stop_pos_backwards): New function.
1821 (next_element_from_buffer): Call compute_stop_pos_backwards to
1822 find a suitable prev_stop when we find ourselves before
1824 (reseat): Don't look for prev_stop, as that could mean a very long
1826 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1827 <cached_disp_overlay_modiff>: Cache for last found display string
1829 (compute_display_string_pos): Return the cached position if asked
1830 about the same buffer in the same area of character positions, and
1831 the buffer wasn't changed since the time the display string
1832 position was cached.
1834 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1836 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1837 is an integer, which is important for empty lines. (Bug#9149)
1839 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1841 * frame.c (Fmodify_frame_parameters): In tty case, update the
1842 default face if necessary (Bug#4238).
1844 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1846 * editfns.c (Fstring_to_char): No need to explain what a character
1847 is in the docstring (Bug#6576).
1849 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1851 * xml.c (parse_region): Make sure we always return a tree.
1853 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1855 * xml.c (parse_region): If a document contains only comments,
1858 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1860 * xml.c (make_dom): Return comments, too.
1862 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1865 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1866 and the surrounding thread.
1867 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1868 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1869 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1871 * s/openbsd.h (BROKEN_SIGIO): Define.
1872 * unexelf.c (unexec) [__OpenBSD__]:
1873 Don't update the .mdebug section of the Alpha COFF symbol table.
1875 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1877 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1880 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1882 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1883 This fixes some race conditions on the permissions of any newly
1886 * alloc.c (valid_pointer_p): Use pipe, not open.
1887 This fixes some permissions issues when debugging.
1889 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1890 If fchown fails to set both uid and gid, try to set just gid,
1891 as that is sometimes allowed. Adjust the file's mode to eliminate
1892 setuid or setgid bits that are inappropriate if fchown fails.
1894 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1896 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1897 to compare Lisp_Objects.
1898 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1899 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1900 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1902 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1904 * lread.c (read_integer): Unread even EOF character.
1905 (read1): Likewise. Properly record start position of symbol.
1907 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1908 symbol character follows.
1910 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1912 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1913 This works around a problem with the previous change to Fcopy_file.
1914 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1915 and without this change, GCC might complain about discarding
1916 fchown's return value.
1918 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1920 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1922 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1924 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1926 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1928 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1929 it's used from the C level.
1931 * process.c: Use the same condition for POLL_FOR_INPUT in both
1932 keyboard.c and process.c (bug#1858).
1934 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1936 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1937 (Fgnutls_boot): Use it.
1939 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1941 * doc.c (Fsubstitute_command_keys): Revert last change.
1943 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1945 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1946 quotes the next character, and doesn't affect other longer
1947 sequences (bug#8935).
1949 * lread.c (syms_of_lread): Clarify that is isn't only
1950 `eval-buffer' and `eval-defun' that's affected by
1951 `lexical-binding' (bug#8460).
1953 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1955 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1956 bidi redisplay when a line includes both an image and is
1959 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1961 Fix minor problems found by static checking.
1962 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1963 (elsz): Now a signed constant, not a size_t var. We prefer signed
1964 types to unsigned, to avoid integer comparison confusion. Without
1965 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1966 "cannot optimize loop, the loop counter may overflow", a symptom
1968 * indent.c (Fvertical_motion): Mark locals as initialized.
1969 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1971 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1973 * search.c (Fre_search_backward): Mention `case-fold-search' in
1974 all the re_search_* functions (bug#8138).
1976 * keyboard.c (Fopen_dribble_file): Document when the file is
1979 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1981 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1984 Support bidi reordering of display and overlay strings.
1985 * xdisp.c (compute_display_string_pos)
1986 (compute_display_string_end): Accept additional argument STRING.
1987 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1988 (reseat_to_string): Initialize bidi_it->string.s and
1989 bidi_it->string.schars.
1990 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1991 NULL (avoids a crash in bidi_paragraph_init).
1992 Initialize itb.string.lstring.
1993 (init_iterator): Call bidi_init_it only of a valid
1994 buffer position was specified. Initialize paragraph_embedding to
1996 (reseat_to_string): Initialize the bidi iterator.
1997 (display_string): If we need to ignore text properties of
1998 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1999 original value of -1 will not work with bidi.)
2000 (compute_display_string_pos): First arg is now struct
2001 `text_pos *'; all callers changed. Support display properties on
2003 (compute_display_string_end): Support display properties on Lisp
2005 (init_iterator, reseat_1, reseat_to_string): Initialize the
2006 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2007 when iterating on a string not from display properties).
2008 (compute_display_string_pos, compute_display_string_end):
2009 Fix calculation of the object to scan. Fixes an error when using
2011 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
2012 base_level_stop; instead, set base_level_stop to BEGV.
2013 Fixes crashes in vertical-motion.
2014 (next_element_from_buffer): Improve commentary for when
2015 the iterator is before prev_stop.
2016 (init_iterator): Initialize bidi_p from the default value of
2017 bidi-display-reordering, not from buffer-local value. Use the
2018 buffer-local value only if initializing for buffer iteration.
2019 (handle_invisible_prop): Support invisible properties on strings
2020 that are being bidi-reordered.
2021 (set_iterator_to_next): Support bidi reordering of C strings and
2023 (next_element_from_string): Support bidi reordering of Lisp
2025 (handle_stop_backwards): Support Lisp strings as well.
2026 (display_string): Support display of R2L glyph rows.
2027 Use IT_STRING_CHARPOS when displaying from a Lisp string.
2028 (init_iterator): Don't initialize it->bidi_p for strings
2030 (reseat_to_string): Initialize it->bidi_p for strings here.
2031 (next_element_from_string, next_element_from_c_string)
2032 (next_element_from_buffer): Add xassert's for correspondence
2033 between IT's object being iterated and it->bidi_it.string
2035 (face_before_or_after_it_pos): Support bidi iteration.
2036 (next_element_from_c_string): Handle the case of the first string
2037 character that is not the first one in the visual order.
2038 (get_visually_first_element): New function, refactored from common
2039 parts of next_element_from_buffer, next_element_from_string, and
2040 next_element_from_c_string.
2041 (tool_bar_lines_needed, redisplay_tool_bar)
2042 (display_menu_bar): Force left-to-right direction. Add a FIXME
2043 comment for making that be controlled by a user option.
2044 (push_it, pop_it): Save and restore the state of the
2045 bidi iterator. Save and restore the bidi_p flag.
2046 (pop_it): Iterate out of display property for string iteration as
2048 (iterate_out_of_display_property): Support iteration over strings.
2049 (handle_single_display_spec): Set up it->bidi_it for iteration
2050 over a display string, and call bidi_init_it.
2051 (handle_single_display_spec, next_overlay_string)
2052 (get_overlay_strings_1, push_display_prop): Set up the bidi
2053 iterator for displaying display or overlay strings.
2054 (forward_to_next_line_start): Don't use the shortcut if
2056 (back_to_previous_visible_line_start): If handle_display_prop
2057 pushed the iterator stack, restore the internal state of the bidi
2058 iterator by calling bidi_pop_it same number of times.
2059 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2060 and we are bidi-iterating, don't decrement the iterator position;
2061 instead, set the first_elt flag in the bidi iterator, to produce
2063 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2064 (push_display_prop): xassert that we are iterating a buffer.
2065 (push_it, pop_it): Save and restore paragraph_embedding member.
2066 (handle_single_display_spec, next_overlay_string)
2067 (get_overlay_strings_1, reseat_1, reseat_to_string)
2068 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2069 correctly. Don't assume unibyte strings are not bidi-reordered.
2070 (compute_display_string_pos)
2071 (compute_display_string_end): Fix handling the case of C string.
2072 (push_it, pop_it): Save and restore from_disp_prop_p.
2073 (handle_single_display_spec, push_display_prop): Set the
2074 from_disp_prop_p flag.
2075 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2076 (pop_it): Call iterate_out_of_display_property only if we are
2077 popping after iteration over a string that came from a display
2078 property. Fix a typo in popping stretch info. Add an assertion
2079 for verifying that the iterator position is in sync with the bidi
2081 (handle_single_display_spec, get_overlay_strings_1)
2082 (push_display_prop): Fix initialization of paragraph direction for
2083 string when that of the parent object is not yet determined.
2084 (reseat_1): Call bidi_init_it to resync the bidi
2085 iterator with IT's position. (Bug#7616)
2086 (find_row_edges): If ROW->start.pos gives position
2087 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2088 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2089 Reset the from_disp_prop_p flag.
2090 (SAVE_IT, RESTORE_IT): New macros.
2091 (pos_visible_p, face_before_or_after_it_pos)
2092 (back_to_previous_visible_line_start)
2093 (move_it_in_display_line_to, move_it_in_display_line)
2094 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2095 (try_scrolling, redisplay_window, display_line): Use them when
2096 saving a temporary copy of the iterator and restoring it back.
2097 (back_to_previous_visible_line_start, reseat_1)
2098 (init_iterator): Empty the bidi cache "stack".
2099 (move_it_in_display_line_to): If iterator ended up at
2100 EOL, but we never saw any buffer positions smaller than
2101 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2102 motion in bidi-reordered lines.
2103 (move_it_in_display_line_to): Record prev_method and prev_pos
2104 immediately before the call to set_iterator_to_next. Fixes cursor
2105 motion in bidi-reordered lines with stretch glyphs and strings
2106 displayed in margins. (Bug#8133) (Bug#8867)
2107 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2109 (pos_visible_p): Support positions in bidi-reordered lines.
2110 Save and restore bidi cache.
2112 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2113 (bidi_paragraph_info): Delete unused struct.
2114 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2115 (bidi_cache_start): New variable.
2116 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2118 (bidi_cache_fetch_state, bidi_cache_search)
2119 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2120 (bidi_cache_find, bidi_peek_at_next_level)
2121 (bidi_level_of_next_char, bidi_find_other_level_edge)
2122 (bidi_move_to_visually_next): Compare cache index with
2123 bidi_cache_start rather than with zero.
2124 (bidi_fetch_char): Accept new argument STRING; all callers
2125 changed. Support iteration over a string. Support strings with
2126 display properties. Support unibyte strings. Fix the type of
2127 `len' according to what STRING_CHAR_AND_LENGTH expects.
2128 (bidi_paragraph_init, bidi_resolve_explicit_1)
2129 (bidi_resolve_explicit, bidi_resolve_weak)
2130 (bidi_level_of_next_char, bidi_move_to_visually_next):
2131 Support iteration over a string.
2132 (bidi_set_sor_type, bidi_resolve_explicit_1)
2133 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2134 can now be zero (for strings); special values 0 and -1 were
2135 changed to -1 and -2, respectively.
2136 (bidi_char_at_pos): New function.
2137 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2138 Call it instead of FETCH_MULTIBYTE_CHAR.
2139 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2140 initialized to valid values.
2141 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2143 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2144 the test for valid cached positions. Fix the logic for looking up
2145 the sentinel state in the cache. GCPRO the Lisp string we are
2147 (bidi_push_it, bidi_pop_it): New functions.
2148 (bidi_initialize): Initialize the bidi cache start stack pointer.
2149 (bidi_cache_ensure_space): New function, refactored from part of
2150 bidi_cache_iterator_state. Don't assume the required size is just
2151 one BIDI_CACHE_CHUNK away.
2152 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2153 (bidi_count_bytes, bidi_char_at_pos): New functions.
2154 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2155 always valid if bidi_cache_idx is valid.
2156 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2157 is valid if it's going to be used.
2158 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2159 (bidi_cache_fetch_state, bidi_cache_search)
2160 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2161 (bidi_cache_iterator_state, bidi_cache_find)
2162 (bidi_find_other_level_edge, bidi_cache_start_stack):
2163 All variables related to cache indices are now EMACS_INT.
2165 * dispextern.h (struct bidi_string_data): New structure.
2166 (struct bidi_it): New member `string'. Make flag members be 1-bit
2167 fields, and put them last in the struct.
2168 (compute_display_string_pos, compute_display_string_end):
2170 (bidi_push_it, bidi_pop_it): Add prototypes.
2171 (struct iterator_stack_entry): New members bidi_p,
2172 paragraph_embedding, and from_disp_prop_p.
2173 (struct it): Member bidi_p is now a bit field 1 bit wide.
2174 (bidi_shelve_cache, bidi_unshelve_cache):
2177 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2178 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2179 and vector-like objects.
2181 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2182 cache around display iteration.
2184 * window.c (Fwindow_end, window_scroll_pixel_based)
2185 (displayed_window_lines, Frecenter): Save and restore the bidi
2186 cache around display iteration.
2188 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2190 * editfns.c (Fdelete_region): Clarify the use of the named
2191 parameters (bug#6788).
2193 2011-07-14 Martin Rudalics <rudalics@gmx.at>
2195 * indent.c (Fvertical_motion): Set and restore w->pointm when
2196 saving and restoring the window's buffer (Bug#9006).
2198 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2200 * editfns.c (Fstring_to_char): Clarify just what is returned
2201 (bug#6576). Text by Eli Zaretskii.
2203 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
2205 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2207 2011-07-13 Eli Zaretskii <eliz@gnu.org>
2209 * buffer.c (mmap_find): Fix a typo.
2211 2011-07-13 Johan Bockgård <bojohan@gnu.org>
2213 Fix execution of x selection hooks.
2214 * xselect.c (Qx_lost_selection_functions)
2215 (Qx_sent_selection_functions): New vars.
2216 (syms_of_xselect): DEFSYM them.
2217 (x_handle_selection_request): Pass Qx_sent_selection_functions
2218 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2219 (x_handle_selection_clear,x_clear_frame_selections):
2220 Pass Qx_lost_selection_functions rather than
2221 Vx_lost_selection_functions to Frun_hook_with_args.
2223 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2225 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2226 The old code sometimes used this field without initializing it.
2228 * alloc.c (gc_sweep): Don't read past end of array.
2229 In theory, the old code could also have corrupted Emacs internals,
2230 though it'd be very unlikely.
2232 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2234 * character.c (Fcharacterp): Don't advertise optional ignored
2235 argument. (Bug#4026)
2237 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2239 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2242 * window.c (Fset_window_start): Doc fix (bug#4199).
2243 (Fset_window_hscroll): Ditto.
2245 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2247 Fix minor new problems caught by GCC 4.6.1.
2248 * term.c (init_tty): Remove unused local.
2249 * xsettings.c (store_monospaced_changed): Define this function only
2250 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
2253 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
2255 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2257 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2259 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2260 are the mini-buffer and the echo area (bug#3320).
2262 * term.c (init_tty): Remove support for supdup, c10 and perq
2263 terminals, which are no longer supported (bug#1482).
2265 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2267 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2269 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2271 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2272 for non-popups (Bug#3642).
2274 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2276 * alloc.c (reset_malloc_hooks): Protoize.
2277 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2278 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2279 * cm.c (losecursor): Likewise.
2280 * data.c (fmod): Likewise.
2281 * dispnew.c (swap_glyphs_in_rows): Likewise.
2282 * emacs.c (memory_warning_signal): Likewise.
2283 * floatfns.c (float_error): Likewise.
2284 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2285 (otf_open, font_otf_capability, generate_otf_features)
2286 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2288 * image.c (pbm_read_file): Likewise.
2289 * indent.c (string_display_width): Likewise.
2290 * intervals.c (check_for_interval, search_for_interval)
2291 (inc_interval_count, count_intervals, root_interval)
2292 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2293 * lread.c (defalias): Likewise.
2294 * ralloc.c (r_alloc_check): Likewise.
2295 * regex.c (set_image_of_range_1, set_image_of_range)
2296 (regex_grow_registers): Likewise.
2297 * sysdep.c (strerror): Likewise.
2298 * termcap.c (valid_filename_p, tprint, main): Likewise.
2299 * tparam.c (main): Likewise.
2300 * unexhp9k800.c (run_time_remap, save_data_space)
2301 (update_file_ptrs, read_header, write_header, calculate_checksum)
2302 (copy_file, copy_rest, display_header): Likewise.
2303 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2305 * xdisp.c (check_it): Likewise.
2306 * xfaces.c (register_color, unregister_color, unregister_colors):
2308 * xfns.c (print_fontset_result): Likewise.
2309 * xrdb.c (member, fatal, main): Likewise.
2311 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2313 Fix minor problems found by static checking (Bug#9031).
2314 * chartab.c (char_table_set_range, map_sub_char_table):
2315 Remove unused locals.
2316 (uniprop_table): Now static.
2317 * composite.c (_work_char): Remove unused static var.
2319 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2321 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2323 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2325 * gtkutil.c (qttip_cb): Remove code without function.
2327 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2329 * w32.c (pthread_sigmask): New stub.
2331 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2333 Use pthread_sigmask, not sigprocmask (Bug#9010).
2334 sigprocmask is portable only for single-threaded applications, and
2335 Emacs can be multi-threaded when it uses GTK.
2336 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2338 * callproc.c (Fcall_process):
2339 * process.c (create_process):
2340 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2341 Use pthread_sigmask, not sigprocmask.
2343 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2345 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2346 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2349 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2351 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2352 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2353 (xg_hide_tooltip): Fix comment.
2355 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2356 in registerServicesMenuSendTypes.
2357 (validRequestorForSendType): Don't check ns_return_types.
2359 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2362 2011-07-08 Jason Rumney <jasonr@gnu.org>
2364 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2365 frame struct members of non-existent frames (Bug#6284).
2367 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2369 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2370 variable firstTime not needed on OSX >= 10.6.
2371 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2372 >= 10.5. Use setKnobProportion, setDoubleValue.
2374 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2375 (MAC_OS_X_VERSION_10_5): Define if not defined.
2376 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2377 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2378 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2380 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2381 cString and lossyCString on OSX >= 10.4
2383 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2384 sizeToFit on OSX >= 10.2.
2386 * nsimage.m (allocInitFromFile): Don't use deprecated method
2387 bestRepresentationForDevice on OSX >= 10.6.
2389 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2392 * emacs.c: Declare unexec_init_emacs_zone.
2394 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2396 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2398 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2399 on svcsMenu (Bug#8842).
2401 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2403 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2405 * nsterm.m (QUTF8_STRING): Declare.
2406 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2407 (validRequestorForSendType): Return type is (id).
2408 Change indexOfObjectIdenticalTo to indexOfObject.
2409 Check if we have local selection before returning self (Bug#8842).
2410 (writeSelectionToPasteboard): Put local selection into paste board
2411 if we have a local selection (Bug#8842).
2412 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2414 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2415 (ns_get_local_selection): Declare.
2417 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2419 * keymap.c (describe_map_tree): Don't insert a double newline at
2420 the end of the buffer (bug#1169) and return whether we inserted
2423 * callint.c (Fcall_interactively): Change "reading args" to
2424 "providing args" to try to clarify what it does (bug#1010).
2426 2011-07-07 Kenichi Handa <handa@m17n.org>
2428 * composite.c (composition_compute_stop_pos): Ignore a static
2429 composition starting before CHARPOS (Bug#8915).
2431 * xdisp.c (handle_composition_prop): Likewise.
2433 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2435 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2438 2011-07-07 Kenichi Handa <handa@m17n.org>
2440 * character.h (unicode_category_t): New enum type.
2442 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2443 (Qchar_code_property_table): New variable.
2444 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2445 (UNIPROP_COMPRESSED_FORM_P): New macros.
2446 (char_table_ascii): Uncompress the compressed values.
2447 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2448 Uncompress the compressed values.
2449 (sub_char_table_ref_and_range): Likewise.
2450 (char_table_ref_and_range): Uncompress the compressed values.
2451 (sub_char_table_set): New arg is_uniprop. Callers changed.
2452 Uncompress the compressed values.
2453 (sub_char_table_set_range): Args changed. Callers changed.
2454 (char_table_set_range): Adjuted for the above change.
2455 (map_sub_char_table): Delete args default_val and parent. Add arg
2456 top. Give decoded values to a Lisp function.
2457 (map_char_table): Adjust for the above change. Give decoded
2458 values to a Lisp function. Gcpro more variables.
2459 (uniprop_table_uncompress)
2460 (uniprop_decode_value_run_length): New functions.
2461 (uniprop_decoder, uniprop_decoder_count): New variables.
2462 (uniprop_get_decoder, uniprop_encode_value_character)
2463 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2465 (uniprop_encoder, uniprop_encoder_count): New variables.
2466 (uniprop_get_encoder, uniprop_table)
2467 (Funicode_property_table_internal, Fget_unicode_property_internal)
2468 (Fput_unicode_property_internal): New functions.
2469 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2470 Sunicode_property_table_internal, Sget_unicode_property_internal,
2471 and Sput_unicode_property_internal. Defvar_lisp
2472 char-code-property-alist.
2474 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2475 Vunicode_category_table.
2477 * font.c (font_range): Adjust for the change of
2478 Vunicode_category_table.
2480 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2482 * m/iris4d.h: Remove file, move contents ...
2483 * s/irix6-5.h: ... here.
2485 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2487 Remove unportable assumption about struct layout (Bug#8884).
2488 * alloc.c (mark_buffer):
2489 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2490 (clone_per_buffer_values): Don't assume that
2491 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2492 This isn't true in general, and it's particularly not true
2493 if Emacs is configured with --with-wide-int.
2494 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2495 New macros, used in the buffer.c change.
2497 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2499 * xsettings.c: Use both GConf and GSettings if both are available.
2500 (store_config_changed_event): Add comment.
2501 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2502 (store_tool_bar_style_changed): New functions.
2503 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2504 (struct xsettings): Move font inside HAVE_XFT.
2505 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2506 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2507 Move inside HAVE_XFT.
2508 (something_changed_gsettingsCB): Rename from something_changedCB.
2509 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2511 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2512 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2513 (something_changed_gconfCB): Rename from something_changedCB.
2514 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2515 (parse_settings): Move check for font inside HAVE_XFT.
2516 (read_settings, apply_xft_settings): Add comment.
2517 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2518 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2519 call store_font_name_changed.
2520 (xft_settings_event): Add comment.
2521 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2522 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2523 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2524 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2525 (xsettings_initialize): Call init_gsettings last.
2526 (xsettings_get_system_font, xsettings_get_system_normal_font):
2529 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2531 Random fixes. E.g., (random) never returned negative values.
2532 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2533 subseconds part to the entropy, as that's a bit more random.
2534 Prefer signed to unsigned, since the signedness doesn't matter and
2535 in general we prefer signed. When given a limit, use a
2536 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2537 latter isn't right if USE_2_TAGS_FOR_INTS.
2538 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2539 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2541 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2543 * textprop.c (text_property_stickiness):
2544 Obey Vtext_property_default_nonsticky.
2545 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2546 * w32fns.c (syms_of_w32fns):
2547 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2549 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2551 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2552 This is more efficient than Ffile_directory_p and avoids a minor race.
2554 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2556 * buffer.c (Foverlay_put): Say what the return value is
2559 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2560 is a directory before asking whether to use the file name
2562 (barf_or_query_if_file_exists): Make the "File is a directory"
2563 error be more correct.
2565 * fns.c (Frequire): Remove the mention of the .gz files, since
2566 that's installation-specific, but keep the mention of
2567 `get-load-suffixes'.
2569 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2571 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2572 Report string overflow if the output is too long.
2574 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2576 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2577 (syms_of_gnutls): Remove duplicate DEFSYM for
2578 Qgnutls_bootprop_verify_hostname_error, an error for
2579 Qgnutls_bootprop_verify_error (which is no longer used).
2581 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2582 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2583 Also (re)move comments that are misplaced or no longer relevant.
2585 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2587 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2589 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2591 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2592 and background color parameters if they have been changed.
2594 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2596 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2598 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2600 * xsettings.c (SYSTEM_FONT): Define only when used.
2601 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2603 * keymap.c (access_keymap_1): Now static.
2605 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2607 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2608 leave any prefix arg for the up event (Bug#1586).
2610 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2612 * lread.c (syms_of_lread): Mention single symbols defined by
2613 `defvar' or `defconst' (bug#7154).
2615 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2616 (Frequire): Mention get-load-suffixes.
2618 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2620 * window.h (window): Remove clone_number slot.
2621 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2623 (make_parent_window, make_window, saved_window)
2624 (Fset_window_configuration, save_window_save): Don't deal with
2626 * buffer.c (Qclone_number): Remove declaration.
2627 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2629 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2631 Add multiple inheritance to keymaps.
2632 * keymap.c (Fmake_composed_keymap): New function.
2633 (Fset_keymap_parent): Simplify.
2634 (fix_submap_inheritance): Remove.
2635 (access_keymap_1): New function extracted from access_keymap to handle
2636 embedded parents and handle lists of maps.
2637 (access_keymap): Use it.
2638 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2639 (Fcopy_keymap): Handle embedded parents.
2640 (Fcommand_remapping, define_as_prefix): Simplify.
2641 (Fkey_binding): Simplify.
2642 (syms_of_keymap): Move minibuffer-local-completion-map,
2643 minibuffer-local-filename-completion-map,
2644 minibuffer-local-must-match-map, and
2645 minibuffer-local-filename-must-match-map to Elisp.
2646 (syms_of_keymap): Defsubr make-composed-keymap.
2647 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2648 (parse_menu_item): Trivial simplification.
2650 2011-07-01 Glenn Morris <rgm@gnu.org>
2652 * Makefile.in (SETTINGS_LIBS): Fix typo.
2654 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2656 * coding.c (Fencode_coding_string): Record the last coding system
2657 used, as the function doc string says (bug#8738).
2659 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2661 * xsettings.c (store_monospaced_changed): Take new font as arg and
2662 check for change against current_mono_font.
2663 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2664 (emacs_settings_constructor, emacs_settings_get_property)
2665 (emacs_settings_set_property, emacs_settings_class_init)
2666 (emacs_settings_init, gsettings_obj): Remove.
2667 (something_changedCB): New function for HAVE_GSETTINGS.
2668 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2669 with value as argument.
2670 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2671 g_settings_new (Bug#8967). Do not create gsettings_obj.
2672 Remove calls to g_settings_bind. Connect something_changedCB to
2675 * xgselect.c: Add defined (HAVE_GSETTINGS).
2676 (xgselect_initialize): Ditto.
2678 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2679 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2682 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2684 * eval.c (struct backtrace): Simplify and port the data structure.
2685 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2686 signed bit field, as this assumption is not portable and it makes
2687 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2688 "char debug_on_exit : 1" as this is not portable either; instead,
2689 use the portable "unsigned int debug_on_exit : 1". Remove unused
2690 member evalargs. Remove obsolete comments about cc bombing out.
2692 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2694 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2695 Let HAVE_GSETTINGS override HAVE_GCONF.
2696 (store_monospaced_changed): New function.
2697 (EMACS_SETTINGS): A new type derived from GObject to handle
2698 GSettings notifications.
2699 (emacs_settings_constructor, emacs_settings_get_property)
2700 (emacs_settings_set_property, emacs_settings_class_init):
2702 (gsettings_client, gsettings_obj): New variables.
2703 (GSETTINGS_SCHEMA): New define.
2704 (something_changedCB): Call store_monospaced_changed.
2705 (init_gsettings): New function.
2706 (xsettings_initialize): Call init_gsettings.
2707 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2710 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2713 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2715 * window.c (resize_root_window, grow_mini_window)
2716 (shrink_mini_window): Rename Qresize_root_window to
2717 Qwindow_resize_root_window and Qresize_root_window_vertically to
2718 Qwindow_resize_root_window_vertically.
2720 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2722 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2724 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2726 * makefile.w32-in: Redesign dependencies so they reflect more
2727 clearly which files are directly included by each source file,
2728 and not through other includes.
2730 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2732 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2733 (sort_overlays, overlay_strings): When an overlay's clone number
2734 matches the window's clone number process the overlay even if
2735 the overlay's window property doesn't match the current window.
2737 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2738 (Fwindow_hchild): Rename to Fwindow_left_child.
2739 (Fwindow_next): Rename to Fwindow_next_sibling.
2740 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2741 (resize_window_check): Rename to window_resize_check.
2742 (resize_window_apply): Rename to window_resize_apply.
2743 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2744 (Fdelete_other_windows_internal, resize_frame_windows)
2745 (Fsplit_window_internal, Fdelete_window_internal)
2746 (grow_mini_window, shrink_mini_window)
2747 (Fresize_mini_window_internal): Fix callers accordingly.
2749 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2751 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2752 (emacs_fixed_set_min_size): Remove.
2753 (emacs_fixed_new): Take frame as argument.
2755 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2756 (_EmacsFixedPrivate): Remove minwidth/height.
2757 Add struct frame *f.
2758 (emacs_fixed_init): Initialize priv->f.
2759 (get_parent_class, emacs_fixed_set_min_size): Remove.
2760 (emacs_fixed_new): Set priv->f to argument.
2761 (emacs_fixed_get_preferred_width)
2762 (emacs_fixed_get_preferred_height): Use min_width/height from
2763 frames size_hint to set minimum and natural (Bug#8919).
2764 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2765 and use min_width/height from frames size_hint to set
2766 min_width/height (Bug#8919).
2768 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2769 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2772 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2774 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2775 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2778 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2780 * process.c (wait_reading_process_output): Bypass select if
2781 waiting for a cell while ignoring keyboard input, and input is
2782 pending. Suggested by Jan Djärv (Bug#8869).
2784 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2786 Use gnulib's dup2 module instead of rolling our own.
2787 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2789 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2791 * dispnew.c (scrolling_window): Before scrolling, turn off a
2792 mouse-highlight in the window being scrolled.
2794 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2796 Move DEFSYM to lisp.h and use everywhere.
2798 * character.h (DEFSYM): Move declaration...
2799 * lisp.h (DEFSYM): ...here.
2805 * w32select.c: Don't include character.h.
2807 * alloc.c (syms_of_alloc):
2808 * buffer.c (syms_of_buffer):
2809 * bytecode.c (syms_of_bytecode):
2810 * callint.c (syms_of_callint):
2811 * casefiddle.c (syms_of_casefiddle):
2812 * casetab.c (init_casetab_once):
2813 * category.c (init_category_once, syms_of_category):
2814 * ccl.c (syms_of_ccl):
2815 * cmds.c (syms_of_cmds):
2816 * composite.c (syms_of_composite):
2817 * dbusbind.c (syms_of_dbusbind):
2818 * dired.c (syms_of_dired):
2819 * dispnew.c (syms_of_display):
2820 * doc.c (syms_of_doc):
2821 * editfns.c (syms_of_editfns):
2822 * emacs.c (syms_of_emacs):
2823 * eval.c (syms_of_eval):
2824 * fileio.c (syms_of_fileio):
2825 * fns.c (syms_of_fns):
2826 * frame.c (syms_of_frame):
2827 * fringe.c (syms_of_fringe):
2828 * insdel.c (syms_of_insdel):
2829 * keymap.c (syms_of_keymap):
2830 * lread.c (init_obarray, syms_of_lread):
2831 * macros.c (syms_of_macros):
2832 * msdos.c (syms_of_msdos):
2833 * print.c (syms_of_print):
2834 * process.c (syms_of_process):
2835 * search.c (syms_of_search):
2836 * sound.c (syms_of_sound):
2837 * syntax.c (init_syntax_once, syms_of_syntax):
2838 * terminal.c (syms_of_terminal):
2839 * textprop.c (syms_of_textprop):
2840 * undo.c (syms_of_undo):
2841 * w32.c (globals_of_w32):
2842 * window.c (syms_of_window):
2843 * xdisp.c (syms_of_xdisp):
2844 * xfaces.c (syms_of_xfaces):
2845 * xfns.c (syms_of_xfns):
2846 * xmenu.c (syms_of_xmenu):
2847 * xsettings.c (syms_of_xsettings):
2848 * xterm.c (syms_of_xterm): Use DEFSYM.
2850 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2852 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2854 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2856 Integer and buffer overflow fixes (Bug#8873).
2858 * print.c (printchar, strout): Check for string overflow.
2859 (PRINTPREPARE, printchar, strout):
2860 Don't set size unless allocation succeeds.
2862 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2863 for sizes. Check for string overflow more accurately.
2864 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2866 * macros.c: Integer and buffer overflow fixes.
2867 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2868 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2869 Use ptrdiff_t, not int, for sizes.
2870 Don't increment bufsize until after realloc succeeds.
2871 Check for size-calculation overflow.
2872 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2874 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2876 * lread.c: Integer overflow fixes.
2877 (read_integer): Radix is now EMACS_INT, not int,
2878 to improve quality of diagnostics for out-of-range radices.
2879 Calculate buffer size correctly for out-of-range radices.
2880 (read1): Check for integer overflow in radices, and in
2881 read-circle numbers.
2882 (read_escape): Avoid int overflow.
2883 (Fload, openp, read_buffer_size, read1)
2884 (substitute_object_recurse, read_vector, read_list, map_obarray):
2885 Use ptrdiff_t, not int, for sizes.
2886 (read1): Use EMACS_INT, not int, for sizes.
2887 Check for size overflow.
2889 * image.c (cache_image): Check for size arithmetic overflow.
2891 * lread.c: Integer overflow issues.
2892 (saved_doc_string_size, saved_doc_string_length)
2893 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2894 Now ptrdiff_t, not int.
2895 (read1): Don't assume doc string length fits in int. Check for
2896 out-of-range doc string lengths.
2897 (read_list): Don't assume file position fits in int.
2898 (read_escape): Check for hex character overflow.
2900 2011-06-22 Leo Liu <sdl.web@gmail.com>
2902 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2903 Move to minibuffer.el.
2905 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2907 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2908 The following patches are for when GLYPH_DEBUG && !XASSERT.
2909 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2910 * dispnew.c (flush_stdout):
2911 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2912 Mark as externally visible.
2913 * dispnew.c (check_window_matrix_pointers): Now static.
2914 * dispnew.c (window_to_frame_vpos):
2915 * xfns.c (unwind_create_frame):
2916 * xterm.c (x_check_font): Remove unused local.
2917 * scroll.c (CHECK_BOUNDS):
2918 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2919 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2920 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2921 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2922 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2924 (debug_method_add): Use va_list and vsprintf rather than relying
2925 on undefined behavior with wrong number of arguments.
2926 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2927 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2928 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2929 since we're not interested in debugging glyphs with old libraries.
2930 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2931 GCC 4.6.0's static checking.
2933 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2935 Integer overflow and signedness fixes (Bug#8873).
2936 A few related buffer overrun fixes, too.
2938 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2940 * dispextern.h (struct face.stipple):
2941 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2942 (x_bitmap_mask, x_allocate_bitmap_record)
2943 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2944 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2945 (x_create_bitmap_from_xpm_data):
2946 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2947 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2949 * xfaces.c (load_pixmap):
2950 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2951 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2952 (.bitmaps_last, struct x_output.icon_bitmap):
2953 Use ptrdiff_t, not int, for bitmap indexes.
2954 (x_allocate_bitmap_record): Check for size overflow.
2955 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2957 Use ptrdiff_t, not int, for overlay counts.
2958 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2959 * editfns.c (overlays_around, get_pos_property):
2960 * textprop.c (get_char_property_and_overlay):
2961 * xdisp.c (next_overlay_change, note_mouse_highlight):
2962 * xfaces.c (face_at_buffer_position):
2963 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2964 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2965 (Fnext_overlay_change, Fprevious_overlay_change)
2966 (mouse_face_overlay_overlaps, Foverlays_in):
2967 Use ptrdiff_t, not int, for sizes.
2968 (overlays_at, overlays_in): Check for size-calculation overflow.
2970 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2972 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2973 (x_session_initialize): Do not assume string length fits in int.
2975 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2976 This is unlikely, but can occur if DPI is outlandish.
2978 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2979 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2981 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2982 * xrdb.c (magic_file_p, search_magic_path):
2983 Omit last arg SUFFIX; it was always 0. All callers changed.
2984 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2986 * xfont.c (xfont_match): Avoid need for strlen.
2988 * xfns.c: Don't assume strlen fits in int.
2989 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2991 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2992 not unsigned long, as we prefer signed integers. All callers changed.
2993 Detect integer overflow in repeat count.
2994 (message_dolog): Don't assume print length fits in 39 bytes.
2995 (display_mode_element): Don't assume strlen fits in int.
2997 * termcap.c: Don't assume sizes fit in int and never overflow.
2998 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2999 (gobble_line): Check for size-calculation overflow.
3001 * minibuf.c (Fread_buffer):
3002 * lread.c (intern, intern_c_string):
3003 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3004 Don't assume string length fits in int.
3006 * keyboard.c (parse_tool_bar_item):
3007 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3009 * font.c: Don't assume string length fits in int.
3010 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3011 Use ptrdiff_t, not int.
3012 (font_intern_prop): Don't assume string length fits in int.
3013 Don't assume integer property fits in fixnum.
3014 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
3016 * filelock.c: Fix some buffer overrun and integer overflow issues.
3017 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
3018 Reformulate so as not to need the command string.
3019 Invoke gzip -cd rather than gunzip, as it's more portable.
3020 (lock_info_type, lock_file_1, lock_file):
3021 Don't assume pid_t and time_t fit in unsigned long.
3022 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3023 (current_lock_owner): Prefer signed type for sizes.
3024 Use memcpy, not strncpy, where memcpy is what is really wanted.
3025 Don't assume (via atoi) that time_t and pid_t fit in int.
3026 Check for time_t and/or pid_t out of range, e.g., via a network share.
3027 Don't alloca where an auto var works fine.
3029 * fileio.c: Fix some integer overflow issues.
3030 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3031 Don't assume string length fits in int.
3032 (directory_file_name): Don't assume string length fits in long.
3033 (make_temp_name): Don't assume pid fits in int, or that its print
3034 length is less than 20.
3036 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3038 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3040 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3042 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3043 We prefer signed integers, even for size calculations.
3045 * emacs.c: Don't assume string length fits in 'int'.
3046 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3047 (main): Don't invoke strlen when not needed.
3049 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3050 (XD_DEBUG_MESSAGE): Don't waste a byte.
3052 * callproc.c (getenv_internal_1, getenv_internal)
3054 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3056 * lread.c (invalid_syntax): Omit length argument.
3057 All uses changed. This doesn't fix a bug, but it simplifies the
3058 code away from its former Hollerith-constant appearance, and it's
3059 one less 'int' to worry about when looking at integer-overflow issues.
3060 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
3062 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3063 This didn't break anything, but it didn't help either.
3064 It's confusing to put a bogus integer in a place where the actual
3065 value does not matter.
3066 (LIST_END_P): Remove unused macro and its bogus comment.
3067 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
3069 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3070 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3072 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3073 We prefer signed types, and the value cannot exceed the EMACS_INT
3074 range anyway (because otherwise the length would not be representable).
3075 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3076 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3077 This avoids a GCC warning when WIDE_EMACS_INT.
3079 * indent.c (sane_tab_width): New function.
3080 (current_column, scan_for_column, Findent_to, position_indentation)
3081 (compute_motion): Use it. This is just for clarity.
3082 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
3084 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
3086 * lisp.h (lint_assume): New macro.
3087 * composite.c (composition_gstring_put_cache):
3088 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3090 * editfns.c, insdel.c:
3091 Omit unnecessary forward decls, to simplify future changes.
3093 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3095 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3097 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
3098 Use much-faster test for byte-length change.
3099 Don't assume string byte-length fits in 'int'.
3100 Check that character arg fits in 'int'.
3101 (mapcar1): Declare byte as byte, for clarity.
3103 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3105 * fns.c (concat): Catch string overflow earlier.
3106 Do not rely on integer wraparound.
3108 * dispextern.h (struct it.overlay_strings_charpos)
3109 (struct it.selective): Now EMACS_INT, not int.
3110 * xdisp.c (forward_to_next_line_start)
3111 (back_to_previous_visible_line_start)
3112 (reseat_at_next_visible_line_start, next_element_from_buffer):
3113 Don't arbitrarily truncate the value of 'selective' to int.
3115 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3117 * composite.c: Don't truncate sizes to 'int'.
3118 (composition_gstring_p, composition_reseat_it)
3119 (composition_adjust_point): Use EMACS_INT, not int.
3120 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3121 not EMACS_UINT, for indexes.
3123 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3125 * buffer.c: Include <verify.h>.
3126 (struct sortvec.priority, struct sortstr.priority):
3127 Now EMACS_INT, not int.
3128 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
3129 (struct sortstr.size, record_overlay_string)
3130 (struct sortstrlist.size, struct sortlist.used):
3131 Don't truncate size to int.
3132 (record_overlay_string): Check for size-calculation overflow.
3133 (init_buffer_once): Check at compile-time, not run-time.
3135 2011-06-22 Jim Meyering <meyering@redhat.com>
3137 Don't leak an XBM-image-sized buffer
3138 * image.c (xbm_load): Free the image buffer after using it.
3140 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3143 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3144 that Sun C diagnosed.
3145 * fns.c (secure_hash): Fix pointer signedness issue.
3146 * intervals.c (static_offset_intervals): New function.
3147 (offset_intervals): Use it.
3149 2011-06-21 Leo Liu <sdl.web@gmail.com>
3152 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3155 * fns.c (secure_hash): Rename from crypto_hash_function and change
3156 the first arg to accept symbols.
3157 (Fsecure_hash): New primitive.
3158 (syms_of_fns): New symbols.
3160 2011-06-20 Deniz Dogan <deniz@dogan.se>
3162 * process.c (Fset_process_buffer): Clarify return value in
3165 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
3167 * dispnew.c (add_window_display_history): Use BVAR.
3169 * xdisp.c (debug_method_add): Use BVAR.
3170 (check_window_end, dump_glyph_matrix, dump_glyph)
3171 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3173 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3176 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3177 check till after the cache is created in init_frame_faces.
3179 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3181 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3183 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3185 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3186 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3187 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3189 Improve buffer-overflow checking (Bug#8873).
3190 * fileio.c (Finsert_file_contents):
3191 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3192 Remove the old (too-loose) buffer overflow checks.
3193 They weren't needed, since make_gap checks for buffer overflow.
3194 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3195 The old code merely checked for Emacs fixnum overflow, and relied
3196 on undefined (wraparound) behavior. The new code avoids undefined
3197 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3199 * editfns.c (Finsert_char): Don't dump core with very negative counts.
3200 Tune. Don't use wider integers than needed. Don't use alloca.
3201 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
3203 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3205 * insdel.c, lisp.h (buffer_overflow): New function.
3206 (insert_from_buffer_1, replace_range, replace_range_2):
3207 * insdel.c (make_gap_larger):
3208 * editfns.c (Finsert_char):
3209 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3211 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3213 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3215 Integer overflow and signedness fixes (Bug#8873).
3217 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3218 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3220 * fileio.c: Don't assume EMACS_INT fits in off_t.
3221 (emacs_lseek): New static function.
3222 (Finsert_file_contents, Fwrite_region): Use it.
3223 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3225 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3227 * fns.c: Don't overflow int when computing a list length.
3228 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3229 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3230 truncation on 64-bit hosts. Check for QUIT every
3231 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3232 faster and is responsive enough.
3233 (Flength): Report an error instead of overflowing an integer.
3234 (Fsafe_length): Return a float if the value is not representable
3235 as a fixnum. This shouldn't happen except in contrived situations.
3236 (Fnthcdr, Fsort): Don't assume list length fits in int.
3237 (Fcopy_sequence): Don't assume vector length fits in int.
3239 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3240 (header_size, word_size): New constants.
3241 (allocate_vectorlike): Don't check size overflow here.
3242 (allocate_vector): Check it here instead, since this is the only
3243 caller of allocate_vectorlike that could cause overflow.
3244 Check that the new vector's length is representable as a fixnum.
3246 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3247 The previous code was bogus. For example, next_almost_prime (32)
3248 returned 39, which is undesirable as it is a multiple of 3; and
3249 next_almost_prime (24) returned 25, which is a multiple of 5 so
3250 why was the code bothering to check for multiples of 7?
3252 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3254 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3256 Variadic C functions now count arguments with ptrdiff_t.
3257 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3258 Back then I didn't know that the Emacs coding style prefers signed int.
3259 Also, in the meantime I found a few more instances where arguments
3260 were being counted with int, which may truncate counts on 64-bit
3261 machines, or EMACS_INT, which may be unnecessarily wide.
3262 * lisp.h (struct Lisp_Subr.function.aMANY)
3263 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3264 Arg counts are now ptrdiff_t, not size_t.
3265 All variadic functions and their callers changed accordingly.
3266 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3267 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3268 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3269 * callint.c (Fcall_interactively): Check arg count for overflow,
3270 to avoid potential buffer overrun. Use signed char, not 'int',
3271 for 'varies' array, so that we needn't bother to check its size
3272 calculation for overflow.
3273 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3274 * eval.c (apply_lambda):
3275 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3276 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3277 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3279 * callint.c (Fcall_interactively): Don't use index var as event count.
3281 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3282 * mem-limits.h (SIZE): Remove; no longer used.
3284 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3286 Remove unnecessary casts.
3287 * xterm.c (x_term_init):
3288 * xfns.c (x_set_border_pixel):
3289 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3290 These aren't needed now that we assume ANSI C.
3292 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3293 It's more likely to cause problems (due to unsigned overflow)
3296 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3298 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3300 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3302 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3304 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3306 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3308 GLYPH_CODE_FACE returns EMACS_INT, not int.
3309 * dispextern.h (merge_faces):
3310 * xfaces.c (merge_faces):
3311 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3312 Don't assume EMACS_INT fits in int.
3314 * character.h (CHAR_VALID_P): Remove unused parameter.
3315 * fontset.c, lisp.h, xdisp.c: All uses changed.
3317 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3319 * fns.c (concat): Minor tuning based on overflow analysis.
3320 This doesn't fix any bugs. Use int to hold character, instead
3321 of constantly refetching from Emacs object. Use XFASTINT, not
3322 XINT, for value known to be a character. Don't bother comparing
3323 a single byte to 0400, as it's always less.
3325 * floatfns.c (Fexpt):
3326 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3328 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3331 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3333 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3334 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3335 incorrectly succeed when S was a string, because 4294967386 was
3336 truncated before it was used.
3338 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3339 Otherwise, an out-of-range integer could cause undefined behavior
3342 * composite.c: Use int, not EMACS_INT, for characters.
3343 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3344 EMACS_INT, for values that are known to be in character range.
3345 This doesn't fix any bugs but is the usual style inside Emacs and
3346 may generate better code on 32-bit machines.
3348 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3349 This is for reasons similar to the recent CHAR_STRING fix.
3350 * charset.c (Fencode_char): Check that character arg is actually
3351 a character. Pass an int to ENCODE_CHAR.
3352 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3353 wider than 'int', as a compile-time check to prevent future regressions
3356 * character.c (char_string): Remove unnecessary casts.
3358 Make sure a 64-bit char is never passed to CHAR_STRING.
3359 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3360 by silently ignoring the top 32 bits, allowing some values
3361 that were far too large to be valid characters.
3362 * character.h: Include <verify.h>.
3363 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3364 arguments are no wider than unsigned, as a compile-time check
3365 to prevent future regressions in this area.
3367 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3368 (Fsubst_char_in_region):
3370 * xdisp.c (decode_mode_spec_coding):
3371 Adjust to CHAR_STRING's new requirement.
3372 * editfns.c (Finsert_char, Fsubst_char_in_region):
3373 * fns.c (concat): Check that character args are actually
3374 characters. Without this test, these functions did the wrong
3375 thing with wildly out-of-range values on 64-bit hosts.
3377 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3378 These casts should not be needed on 32-bit hosts, either.
3379 * keyboard.c (read_char):
3380 * lread.c (Fload): Remove casts to unsigned.
3382 * lisp.h (UNSIGNED_CMP): New macro.
3383 This fixes comparison bugs on 64-bit hosts.
3384 (ASCII_CHAR_P): Use it.
3385 * casefiddle.c (casify_object):
3386 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3387 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3388 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3389 * dispextern.h (FACE_FROM_ID):
3390 * keyboard.c (read_char): Use UNSIGNED_CMP.
3392 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3393 not to EMACS_INT, to avoid GCC warning.
3395 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3397 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3398 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3399 isn't needed on 32-bit machines.
3401 * buffer.c (Fgenerate_new_buffer_name):
3402 Use EMACS_INT for count, not int.
3403 (advance_to_char_boundary): Return EMACS_INT, not int.
3405 * data.c (Qcompiled_function): Now static.
3407 * window.c (window_body_lines): Now static.
3409 * image.c (gif_load): Rename local to avoid shadowing.
3411 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3412 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3413 * alloc.c (make_save_value): Integer argument is now of type
3415 (mark_object): Use ptrdiff_t, not int.
3416 * lisp.h (pD): New macro.
3417 * print.c (print_object): Use it.
3419 * alloc.c: Use EMACS_INT, not int, to count objects.
3420 (total_conses, total_markers, total_symbols, total_vector_size)
3421 (total_free_conses, total_free_markers, total_free_symbols)
3422 (total_free_floats, total_floats, total_free_intervals)
3423 (total_intervals, total_strings, total_free_strings):
3424 Now EMACS_INT, not int. All uses changed.
3425 (Fgarbage_collect): Compute overall total using a double, so that
3426 integer overflow is less likely to be a problem. Check for overflow
3427 when converting back to an integer.
3428 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3429 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3430 These were 'int' variables that could overflow on 64-bit hosts;
3431 they were never used, so remove them instead of repairing them.
3432 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3433 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3434 Previously, this ceilinged at INT_MAX, but that doesn't work on
3436 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3438 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3439 (allocate_vectorlike): Check for ptrdiff_t overflow.
3440 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3441 when a (possibly-narrower) signed value would do just as well.
3442 We prefer using signed arithmetic, to avoid comparison confusion.
3444 * alloc.c: Catch some string size overflows that we were missing.
3445 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3446 for convenience in STRING_BYTES_MAX.
3447 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3448 The definition here is exact; the one in lisp.h was approximate.
3449 (allocate_string_data): Check for string overflow. This catches
3450 some instances we weren't catching before. Also, it catches
3451 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3452 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3453 and ptrdiff_t and EMACS_INT are both 64 bits.
3455 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3456 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3457 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3459 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3461 * alloc.c (Fmake_string): Check for out-of-range init.
3463 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3465 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3467 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3469 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3470 xg_get_default_scrollbar_width.
3472 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3473 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3474 (style_changed_cb): Call update_theme_scrollbar_width and call
3475 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3476 all frames (Bug#8505).
3477 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3478 Call gtk_window_set_resizable if HAVE_GTK3.
3479 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3480 and height if HAVE_GTK3 (Bug#8505).
3481 (scroll_bar_width_for_theme): New variable.
3482 (update_theme_scrollbar_width): New function.
3483 (xg_get_default_scrollbar_width): Move code to
3484 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3485 (xg_initialize): Call update_theme_scrollbar_width.
3487 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3489 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3491 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3493 * frame.c (make_frame): Call other_buffer_safely instead of
3496 * window.c (temp_output_buffer_show): Call display_buffer with
3497 second argument Vtemp_buffer_show_specifiers and reset latter
3498 immediately after the call.
3499 (Vtemp_buffer_show_specifiers): New variable.
3500 (auto_window_vscroll_p, next_screen_context_lines)
3501 (Vscroll_preserve_screen_position): Remove leading asterisks from
3504 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3506 Fix minor problems found by GCC 4.6.0 static checking.
3507 * buffer.c (Qclone_number): Remove for now, as it's unused.
3508 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3509 (record_buffer): Remove unused local.
3510 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3511 (set_frame_buffer_list): Remove; unused.
3512 * frame.h (other_visible_frames): Remove decl.
3513 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3514 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3515 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3517 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3518 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3519 Define only if HAVE_GPM.
3520 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3521 (update_hints_inhibit): Remove; never set. All uses removed.
3522 * widgetprv.h (emacsFrameClassRec): Remove decl.
3523 * window.c (delete_deletable_window): Now returns void, since it
3524 wasn't returning anything.
3525 (compare_window_configurations): Remove unused locals.
3526 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3527 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3528 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3529 the same widths as pointers. This follows up on the 2011-05-06 patch.
3530 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3531 * xterm.h: Likewise.
3532 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3534 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3536 * makefile.w32-in: Update dependencies.
3537 (LISP_H): Add lib/intprops.h.
3539 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3541 * image.c (gif_load): Add animation frame delay to the metadata.
3542 (syms_of_image): Use DEFSYM. New symbol `delay'.
3544 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3546 * window.c (delete_deletable_window): Re-add.
3547 (Fset_window_configuration): Rewrite to handle dead buffers and
3548 consequently deletable windows.
3549 (window_tree, Fwindow_tree): Remove. Supply functionality in
3551 (compare_window_configurations): Simplify code.
3553 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3555 * image.c (imagemagick_load_image): Fix type mismatch.
3556 (Fimagemagick_types): Likewise.
3558 * window.h (replace_buffer_in_windows): Declare.
3560 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3562 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3563 Qclone_number. Remove external declaration of Qdelete_window.
3564 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3566 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3567 Run Qbuffer_list_update_hook if allowed.
3568 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3569 buffer list implementation.
3570 (other_buffer_safely): New function.
3571 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3572 calls to replace_buffer_in_windows and
3573 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3575 (record_buffer): Inhibit quitting and rewrite using quittable
3576 functions. Run Qbuffer_list_update_hook if allowed.
3577 (Frecord_buffer, Funrecord_buffer): New functions.
3578 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3579 Move switch-to-buffer to window.el.
3580 (bury-buffer): Move to window.el.
3581 (Vbuffer_list_update_hook): New variable.
3583 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3586 * window.h (resize_frame_windows): Move up in code.
3587 (Fwindow_frame): Remove EXFUN.
3588 (replace_buffer_in_all_windows): Remove prototype.
3589 (replace_buffer_in_windows_safely): Add prototype.
3591 * window.c: Declare Qdelete_window static again. Move down
3592 declaration of select_count.
3593 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3594 (Fother_window): Move to window.el.
3595 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3596 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3597 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3599 (replace_buffer_in_windows): Implement by calling
3600 Qreplace_buffer_in_windows.
3601 (replace_buffer_in_all_windows): Remove with some functionality
3602 moved into replace_buffer_in_windows_safely.
3603 (replace_buffer_in_windows_safely): New function.
3604 (select_window_norecord, select_frame_norecord): Move in front
3605 of run_window_configuration_change_hook. Remove now obsolete
3607 (Fset_window_buffer): Rewrite doc-string.
3608 Call Qrecord_window_buffer.
3609 (keys_of_window): Move binding for other-window to window.el.
3611 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3613 * dispextern.h (struct image): Replace data member, whose int_val
3614 and ptr_val fields were not used by anything, with a single
3617 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3618 (gif_clear_image, gif_load, imagemagick_load_image)
3619 (gs_clear_image, gs_load): Callers changed.
3621 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3623 * buffer.h: Include <time.h>, for time_t.
3624 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3626 Fix minor problems found by static checking.
3628 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3630 Make identifiers static if they are not used in other modules.
3631 * data.c (Qcompiled_function, Qframe, Qvector):
3632 * image.c (QimageMagick, Qsvg):
3633 * minibuf.c (Qmetadata):
3634 * window.c (resize_window_check, resize_root_window): Now static.
3635 * window.h (resize_window_check, resize_root_window): Remove decls.
3637 * window.c (window_deletion_count, delete_deletable_window):
3639 (window_body_lines): Now static.
3640 (Fdelete_other_windows_internal): Mark vars as initialized.
3641 Make sure 'resize_failed' is initialized.
3642 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3643 (resize_window_apply): Remove unused local.
3644 * window.h (delete_deletable_window): Remove decl.
3646 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3647 (imagemagick_load_image): Fix pointer signedness problem by changing
3648 last arg from unsigned char * to char *. All uses changed.
3649 Also, fix a local for similar reasons.
3650 Remove unused locals. Remove locals to avoid shadowing.
3651 (fn_rsvg_handle_free): Remove; unused.
3652 (svg_load, svg_load_image): Fix pointer signedness problem.
3653 (imagemagick_load_image): Don't use garbage pointer image_wand.
3655 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3657 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3659 * image.c (gif_load): Fix omitted cast error introduced by
3662 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3664 * window.h (resize_proportionally, orig_total_lines)
3665 (orig_top_line): Remove from window structure.
3666 (set_window_height, set_window_width, change_window_heights)
3667 (Fdelete_window): Remove prototypes.
3668 (resize_frame_windows): Remove duplicate declaration.
3670 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3672 * window.h (resize_frame_windows, resize_window_check)
3673 (delete_deletable_window, resize_root_window)
3674 (resize_frame_windows): Declare prototypes.
3676 * window.c (resize_window_apply): Make definition be "static" to
3677 match the prototype.
3679 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3681 * window.c: Remove declarations of Qwindow_size_fixed,
3682 window_min_size_1, window_min_size_2, window_min_size,
3683 size_window, window_fixed_size_p, enlarge_window, delete_window.
3684 Remove static from declaration of Qdelete_window, it's
3685 temporarily needed by Fbury_buffer.
3686 (replace_window): Don't assign orig_top_line and
3688 (Fdelete_window, delete_window): Remove. Window deletion is
3689 handled by window.el.
3690 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3691 Replace Fdelete_window calls with calls to Qdelete_window.
3692 (Fdelete_other_windows): Remove. Deleting other windows is
3693 handled by window.el.
3694 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3695 handled in window.el.
3696 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3697 Window minimum sizes are handled in window.el.
3698 (shrink_windows, size_window, set_window_height)
3699 (set_window_width, change_window_heights, window_height)
3700 (window_width, CURBEG, CURSIZE, enlarge_window)
3701 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3702 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3703 handled in window.el.
3704 (make_dummy_parent): Rename to make_parent_window and give it a
3705 second argument horflag.
3706 (make_window): Don't set resize_proportionally any more.
3707 (Fsplit_window): Remove. Windows are split in window.el.
3708 (save_restore_action, save_restore_orig_size)
3709 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3710 Resize mini windows in window.el.
3711 (grow_mini_window, shrink_mini_window): Implement by calling
3712 Qresize_root_window_vertically, resize_window_check and
3713 resize_window_apply.
3714 (saved_window, Fset_window_configuration, save_window_save):
3715 Do not handle orig_top_line, orig_total_lines, and
3716 resize_proportionally.
3717 (window_min_height, window_min_width): Move to window.el.
3718 (keys_of_window): Move bindings for delete-other-windows,
3719 split-window, delete-window and enlarge-window to window.el.
3721 * buffer.c: Temporarily extern Qdelete_window.
3722 (Fbury_buffer): Temporarily call Qdelete_window instead of
3723 Fdelete_window (Fbury_buffer will move to window.el soon).
3725 * frame.c (set_menu_bar_lines_1): Remove code handling
3726 orig_top_line and orig_total_lines.
3728 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3729 set_window_height but set heights directly.
3730 (change_frame_size_1): Use resize_frame_windows.
3732 * xdisp.c (init_xdisp): Don't use set_window_height but set
3735 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3736 Use resize_frame_windows instead of change_window_heights and run
3737 run_window_configuration_change_hook.
3739 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3740 instead of change_window_heights and run
3741 run_window_configuration_change_hook.
3743 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3745 * window.c (replace_window): Rename second argument REPLACEMENT to
3746 NEW. New third argument SETFLAG. Rewrite.
3747 (delete_window, make_dummy_parent): Call replace_window with
3749 (window_list_1): Move down in code.
3750 (run_window_configuration_change_hook): Move set_buffer part
3751 before select_frame_norecord part in order to unwind correctly.
3752 Rename count1 to count.
3753 (recombine_windows, delete_deletable_window, resize_root_window)
3754 (Fdelete_other_windows_internal)
3755 (Frun_window_configuration_change_hook, make_parent_window)
3756 (resize_window_check, resize_window_apply, Fresize_window_apply)
3757 (resize_frame_windows, Fsplit_window_internal)
3758 (Fdelete_window_internal, Fresize_mini_window_internal):
3760 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3762 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3764 * window.h (window): Add some new members to window structure -
3765 normal_lines, normal_cols, new_total, new_normal, clone_number,
3766 splits, nest, prev_buffers, next_buffers.
3767 (WINDOW_TOTAL_SIZE): Move here from window.c.
3768 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3770 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3772 (make_dummy_parent): Set new members of windows structure.
3773 (make_window): Move down in code. Handle new members of window
3775 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3776 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3777 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3778 (Fset_window_prev_buffers, Fwindow_next_buffers)
3779 (Fset_window_next_buffers, Fset_window_clone_number):
3781 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3782 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3784 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3785 Argument WINDOW can be now internal window too.
3786 (Fwindow_use_time): Move up in code.
3787 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3789 (Fset_window_configuration, saved_window)
3790 (Fcurrent_window_configuration, save_window_save): Handle new
3791 members of window structure.
3792 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3793 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3794 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3795 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3796 Qget_mru_window, Qresize_root_window,
3797 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3798 Qauto_buffer_name; staticpro them.
3800 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3802 * window.c (Fwindow_total_size, Fwindow_left_column)
3803 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3804 (Fwindow_list_1): New functions.
3805 (window_box_text_cols): Replace with window_body_cols.
3806 (Fwindow_width, Fscroll_left, Fscroll_right):
3807 Use window_body_cols instead of window_box_text_cols.
3808 (delete_window, Fset_window_configuration):
3809 Call delete_all_subwindows with window as argument.
3810 (delete_all_subwindows): Take a window as argument and not a
3812 (window_loop): Remove handling of GET_LRU_WINDOW and
3814 (Fget_lru_window, Fget_largest_window): Move to window.el.
3816 * window.h: Extern window_body_cols instead of
3817 window_box_text_cols. delete_all_subwindows now takes a
3818 Lisp_Object as argument.
3820 * indent.c (compute_motion, Fcompute_motion):
3821 Use window_body_cols instead of window_box_text_cols.
3823 * frame.c (delete_frame): Call delete_all_subwindows with root
3826 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3828 * fns.c (Fputhash): Document return value.
3830 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3832 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3834 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3836 Cons<->int and similar integer overflow fixes (Bug#8794).
3838 Check for overflow when converting integer to cons and back.
3839 * charset.c (Fdefine_charset_internal, Fdecode_char):
3840 Use cons_to_unsigned to catch overflow.
3841 (Fencode_char): Use INTEGER_TO_CONS.
3842 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3843 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3844 * data.c (long_to_cons, cons_to_long): Remove.
3845 (cons_to_unsigned, cons_to_signed): New functions.
3846 These signal an error for invalid or out-of-range values.
3847 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3848 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3849 * font.c (Ffont_variation_glyphs):
3850 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3851 * lisp.h: Include <intprops.h>.
3852 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3853 (cons_to_signed, cons_to_unsigned): New decls.
3854 (long_to_cons, cons_to_long): Remove decls.
3855 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3856 (Fprimitive_undo): Use CONS_TO_INTEGER.
3857 * xfns.c (Fx_window_property): Likewise.
3858 * xselect.c: Include <limits.h>.
3859 (x_own_selection, selection_data_to_lisp_data):
3860 Use INTEGER_TO_CONS.
3861 (x_handle_selection_request, x_handle_selection_clear)
3862 (x_get_foreign_selection, Fx_disown_selection_internal)
3863 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3864 (lisp_data_to_selection_data): Use cons_to_unsigned.
3865 (x_fill_property_data): Use cons_to_signed.
3866 Report values out of range.
3868 Check for buffer and string overflow more precisely.
3869 * buffer.h (BUF_BYTES_MAX): New macro.
3870 * lisp.h (STRING_BYTES_MAX): New macro.
3871 * alloc.c (Fmake_string):
3872 * character.c (string_escape_byte8):
3873 * coding.c (coding_alloc_by_realloc):
3874 * doprnt.c (doprnt):
3875 * editfns.c (Fformat):
3877 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3878 since they may not be the same number.
3879 * editfns.c (Finsert_char):
3880 * fileio.c (Finsert_file_contents):
3881 Likewise for BUF_BYTES_MAX.
3883 * image.c: Use ptrdiff_t, not int, for sizes.
3884 (slurp_file): Switch from int to ptrdiff_t.
3886 (slurp_file): Check that file size fits in both size_t (for
3887 malloc) and ptrdiff_t (for sanity and safety).
3889 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3890 if b->modtime has its maximal value.
3892 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3894 Don't assume time_t can fit into int.
3895 * buffer.h (struct buffer.modtime): Now time_t, not int.
3896 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3897 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3899 Minor fixes for signed vs unsigned integers.
3900 * character.h (MAYBE_UNIFY_CHAR):
3901 * charset.c (maybe_unify_char):
3902 * keyboard.c (read_char, reorder_modifiers):
3903 XINT -> XFASTINT, since the integer must be nonnegative.
3904 * ftfont.c (ftfont_spec_pattern):
3905 * keymap.c (access_keymap, silly_event_symbol_error):
3906 XUINT -> XFASTINT, since the integer must be nonnegative.
3907 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3908 since it makes no difference and we prefer signed.
3909 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3910 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3913 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3915 * window.h (Fwindow_frame): Declare.
3917 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3919 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3920 (SPARE_MEMORY): Always define.
3921 (LARGE_REQUEST): Remove.
3922 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3924 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3926 * lisp.h: Move EXFUNS for Fframe_root_window,
3927 Fframe_first_window and Fset_frame_selected_window to window.h.
3929 * window.h: Move EXFUNS for Fframe_root_window,
3930 Fframe_first_window and Fset_frame_selected_window here from
3933 * frame.c (Fwindow_frame, Fframe_first_window)
3934 (Fframe_root_window, Fframe_selected_window)
3935 (Fset_frame_selected_window): Move to window.c.
3936 (Factive_minibuffer_window): Move to minibuf.c.
3937 (Fother_visible_frames_p): New function.
3939 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3941 * window.c (decode_window, decode_any_window): Move up in code.
3942 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3943 (inhibit_frame_unsplittable): Remove unused variable.
3944 (Fwindow_buffer): Move up and rewrite doc-string.
3945 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3946 (Fwindow_prev): New functions.
3947 (Fwindow_frame): Move here from frame.c. Accept any window as
3949 (Fframe_root_window, Fframe_first_window)
3950 (Fframe_selected_window): Move here from frame.c. Accept frame
3951 or arbitrary window as argument. Update doc-strings.
3952 (Fminibuffer_window): Move up in code.
3953 (Fwindow_minibuffer_p): Move up in code and simplify.
3954 (Fset_frame_selected_window): Move here from frame.c.
3956 (Fselected_window, select_window, Fselect_window): Move up in
3957 code. Minor doc-string fixes.
3959 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3961 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3962 Do not assume that spare memory exists; that assumption is valid
3963 only if SYSTEM_MALLOC.
3964 (LARGE_REQUEST): New macro, so that the issue of large requests
3965 is separated from the issue of spare memory.
3967 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3969 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3972 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3974 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3977 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3979 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3981 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3983 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3984 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3986 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3988 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3990 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3992 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3993 (x_clipboard_manager_save): Add return value.
3994 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3996 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3997 Obey Vx_select_enable_clipboard_manager. Catch errors in
3998 x_clipboard_manager_save (Bug#8779).
3999 (Vx_select_enable_clipboard_manager): New variable.
4000 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4002 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
4004 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4006 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4008 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4009 in the current matrix if keep_current_p is non-zero.
4011 2011-06-04 Eli Zaretskii <eliz@gnu.org>
4013 * bidi.c (bidi_level_of_next_char): Fix last change.
4015 2011-06-03 Eli Zaretskii <eliz@gnu.org>
4017 Support bidi reordering of text covered by display properties.
4019 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4020 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4021 (bidi_cache_search, bidi_cache_iterator_state)
4022 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4023 (bidi_level_of_next_char, bidi_move_to_visually_next):
4024 Support character positions inside a run of characters covered by a
4026 (bidi_paragraph_init, bidi_resolve_explicit_1)
4027 (bidi_level_of_next_char): Call bidi_fetch_char and
4028 bidi_fetch_char_advance instead of FETCH_CHAR and
4030 (bidi_init_it): Initialize new members.
4031 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4033 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4034 instead of using explicit *_CHAR codes.
4035 (bidi_resolve_explicit, bidi_resolve_weak):
4036 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
4037 bidirectional text is supported only in multibyte buffers.
4038 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4039 it to initialize the frame_window_p member of struct bidi_it.
4040 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4041 (bidi_resolve_explicit, bidi_resolve_weak)
4042 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4043 bidi_it->nchars is non-positive.
4044 (bidi_level_of_next_char): Don't try to lookup the cache for the
4045 next/previous character if nothing is cached there yet, or if we
4046 were just reseat()'ed to a new position.
4048 * xdisp.c (set_cursor_from_row): Set start and stop points
4049 according to the row's direction when priming the loop that looks
4050 for the glyph on which to display cursor.
4051 (single_display_spec_intangible_p): Function deleted.
4052 (display_prop_intangible_p): Reimplement to call
4053 handle_display_spec instead of single_display_spec_intangible_p.
4054 Accept 3 additional arguments needed by handle_display_spec.
4055 This fixes incorrect cursor motion across display property with complex
4056 values: lists, `(when COND...)' forms, etc.
4057 (single_display_spec_string_p): Support property values that are
4058 lists with the argument STRING its top-level element.
4059 (display_prop_string_p): Fix the condition for processing a
4060 property that is a list to be consistent with handle_display_spec.
4061 (handle_display_spec): New function, refactored from the
4062 last portion of handle_display_prop.
4063 (compute_display_string_pos): Accept additional argument
4064 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4065 value of a `display' property is a "replacing spec".
4066 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4067 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4068 the display property, but just return a value indicating whether
4069 the display property will replace the characters it covers.
4070 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4071 frame_window_p members of struct bidi_it.
4072 (compute_display_string_pos, compute_display_string_end):
4074 (push_it): Accept second argument POSITION, where pop_it should
4075 jump to continue iteration.
4076 (reseat_1): Initialize bidi_it.disp_pos.
4078 * keyboard.c (adjust_point_for_property): Adjust the call to
4079 display_prop_intangible_p to its new signature.
4081 * dispextern.h (struct bidi_it): New member frame_window_p.
4082 (bidi_init_it): Update prototypes.
4083 (display_prop_intangible_p): Update prototype.
4084 (compute_display_string_pos, compute_display_string_end):
4086 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4089 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
4091 Malloc failure behavior now depends on size of allocation.
4092 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4093 * lisp.h: Change signatures accordingly.
4094 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4095 All callers changed. (Bug#8762)
4097 * gnutls.c: Use Emacs's memory allocators.
4098 Without this change, the gnutls library would invoke malloc etc.
4099 directly, which causes problems on non-SYNC_INPUT hosts, and which
4100 runs afoul of improving memory_full behavior. (Bug#8761)
4101 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4102 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4103 xfree instead of the default malloc, realloc, free.
4104 (Fgnutls_boot): No need to check for memory allocation failure,
4105 since xmalloc does that for us.
4107 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
4108 * category.c (hash_get_category_set):
4109 * ccl.c (ccl_driver):
4110 * charset.c (Fdefine_charset_internal):
4111 * charset.h (struct charset.hash_index):
4112 * composite.c (get_composition_id, gstring_lookup_cache)
4113 (composition_gstring_put_cache):
4114 * composite.h (struct composition.hash_index):
4115 * dispextern.h (struct image.hash):
4116 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4117 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4118 (hashfn_equal, hashfn_user_defined, make_hash_table)
4119 (maybe_resize_hash_table, hash_lookup, hash_put)
4120 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4121 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4122 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4123 * image.c (make_image, search_image_cache, lookup_image)
4124 (xpm_put_color_table_h):
4125 * lisp.h (struct Lisp_Hash_Table):
4126 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
4127 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
4128 for hashes and hash indexes, instead of 'unsigned' and 'int'.
4129 * alloc.c (allocate_vectorlike):
4130 Check for overflow in vector size calculations.
4131 * ccl.c (ccl_driver):
4132 Check for overflow when converting EMACS_INT to int.
4133 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4134 need to be updated by these changes.
4135 * fns.c (make_hash_table, maybe_resize_hash_table):
4136 Check for integer overflow with large hash tables.
4137 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4138 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4139 (SXHASH_REDUCE): New macro.
4140 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4141 Use it instead of discarding useful hash info with large hash values.
4142 (sxhash_float): New function.
4143 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4144 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
4145 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4146 Rewrite to use FIXNUM_BITS, as this simplifies things.
4147 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4148 Adjust signatures to match updated version of code.
4149 (consing_since_gc): Now EMACS_INT, since a single hash table can
4150 use more than INT_MAX bytes.
4152 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4154 Make it possible to build with GCC-4.6+ -O2 -flto.
4156 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4158 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4160 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4161 Call minibuffer-inactive-mode.
4163 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
4165 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4166 Update dependencies.
4168 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4170 * data.c (init_data): Remove code for UTS, this system is not
4173 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4175 Don't force ./temacs to start in terminal mode.
4177 * frame.c (make_initial_frame): Initialize faces in all cases, not
4178 only when CANNOT_DUMP is defined.
4179 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4181 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4183 * dispnew.c (add_window_display_history): Use const for the string
4184 pointer. Remove declaration, not needed.
4186 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4188 Use 'inline', not 'INLINE'.
4189 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
4190 * alloc.c, fontset.c (INLINE): Remove.
4191 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4192 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4193 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4194 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4195 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4197 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4199 Make it possible to run ./temacs.
4201 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4202 syms_of_callproc does the same thing. Remove test for
4203 "initialized", do it in the caller.
4204 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4206 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4208 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4209 (read_minibuf): Use get_minibuffer.
4210 (syms_of_minibuf): Use DEFSYM.
4211 (Qmetadata): New var.
4212 * data.c (Qbuffer): Don't make it static.
4213 (syms_of_data): Use DEFSYM.
4215 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4217 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4218 (CCL_CODE_MIN): New macro.
4220 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4222 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4224 * eval.c (Qdebug): Now static.
4225 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4226 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4227 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4229 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4231 * image.c: Various fixes to ImageMagick code comments.
4232 (Fimagemagick_types): Doc fix.
4234 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4236 Minor fixes prompted by GCC 4.6.0 warnings.
4238 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4240 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4241 (x_clipboard_manager_save_all): Move extern decl to ...
4242 * xterm.h: ... here, so that it can be checked for consistency.
4244 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4246 * xselect.c (x_clipboard_manager_save_frame)
4247 (x_clipboard_manager_save_all): New functions.
4248 (Fx_clipboard_manager_save): Lisp function deleted.
4250 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4251 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4253 * xterm.h: Update prototype.
4255 2011-05-28 William Xu <william.xwl@gmail.com>
4257 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4260 2011-05-28 Jim Meyering <meyering@redhat.com>
4262 Avoid a sign-extension bug in crypto_hash_function.
4263 * fns.c (to_uchar): Define.
4264 (crypto_hash_function): Use it to convert some newly-signed
4265 variables to unsigned, to avoid sign-extension bugs. For example,
4266 without this change, (md5 "truc") would evaluate to
4267 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4268 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
4269 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
4271 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4273 Integer overflow fixes.
4275 * dbusbind.c: Serial number integer overflow fixes.
4276 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
4277 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4278 to hold a serial number that is too large for a fixnum.
4279 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4280 Check for serial numbers out of range. Decode any serial number
4281 that was so large that it became a float. (Bug#8722)
4283 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4284 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4285 Use XFASTINT rather than XUINT when numbers are nonnegative.
4286 (xd_append_arg, Fdbus_method_return_internal):
4287 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4288 arguments, check that Lisp number is nonnegative, rather than
4289 silently wrapping negative numbers around. (Bug#8722)
4290 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
4293 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4295 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4297 ccl: add integer overflow checks
4298 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4299 (IN_INT_RANGE): New macros.
4300 (ccl_driver): Use them to check for integer overflow when
4301 decoding a CCL program. Many of the new checks are whether XINT (x)
4302 fits in int; it doesn't always, on 64-bit hosts. The new version
4303 doesn't catch all possible integer overflows, but it's an
4304 improvement. (Bug#8719)
4306 * alloc.c (make_event_array): Use XINT, not XUINT.
4307 There's no need for unsigned here.
4309 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4310 This follows up to the 2011-05-06 change that substituted uintptr_t
4311 for EMACS_INT. This case wasn't caught back then.
4313 Rework Fformat to avoid integer overflow issues.
4314 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4315 now (part of C89). Include <verify.h>.
4316 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4317 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4318 (Fformat): Avoid the prepass trying to compute sizes; it was only
4319 approximate and thus did not catch overflow reliably. Instead, walk
4320 through the format just once, formatting and computing sizes as we go,
4321 checking for integer overflow at every step, and allocating a larger
4322 buffer as needed. Keep track separately whether the format is
4323 multibyte. Keep only the most-recently calculated precision, rather
4324 than them all. Record whether each argument has been converted to
4325 string. Use EMACS_INT, not int, for byte and char and arg counts.
4326 Support field widths and precisions larger than INT_MAX. Avoid
4327 sprintf's undefined behavior with conversion specifications such as %#d
4328 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4329 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4330 formatting out-of-range floating point numbers with int
4333 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4335 * data.c: Avoid integer truncation in expressions involving floats.
4336 * data.c: Include <intprops.h>.
4337 (arith_driver): When there's an integer overflow in an expression
4338 involving floating point, convert the integers to floating point
4339 so that the resulting value does not suffer from catastrophic
4340 integer truncation. For example, on a 64-bit host (* 4
4341 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4342 Do not rely on undefined behavior after integer overflow.
4344 merge count_size_as_multibyte, parse_str_to_multibyte
4345 * character.c, character.h (count_size_as_multibyte):
4346 Rename from parse_str_to_multibyte; all uses changed.
4347 Check for integer overflow.
4348 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4349 since it's now a duplicate of the other. This is more of
4350 a character than a buffer op, so better that it's in character.c.
4351 * fns.c, print.c: Adjust to above changes.
4353 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4355 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4357 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4359 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4360 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4361 (x_clipboard_manager_save): Now static.
4362 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4364 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4365 (crypto_hash_function): Now static.
4366 Fix pointer signedness problems. Avoid unnecessary initializations.
4368 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4370 * termhooks.h (Vselection_alist): Make it terminal-local.
4372 * terminal.c (create_terminal): Initialize it.
4374 * xselect.c: Support for clipboard managers.
4375 (Vselection_alist): Move to termhooks.h as terminal-local var.
4376 (LOCAL_SELECTION): New macro.
4377 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4378 (symbol_to_x_atom): Remove gratuitous arg.
4379 (x_handle_selection_request, lisp_data_to_selection_data)
4380 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4381 (x_own_selection, x_get_local_selection, x_convert_selection):
4382 New arg, specifying work frame. Use terminal-local Vselection_alist.
4383 (some_frame_on_display): Delete unused function.
4384 (Fx_own_selection_internal, Fx_get_selection_internal)
4385 (Fx_disown_selection_internal, Fx_selection_owner_p)
4386 (Fx_selection_exists_p): New optional frame arg.
4387 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4388 (x_handle_selection_clear): Don't treat other terminals with the
4389 same keyboard specially. Use the terminal-local Vselection_alist.
4390 (x_clear_frame_selections): Use Frun_hook_with_args.
4392 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4394 * xterm.h: Add support for those atoms.
4396 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4398 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4399 (converted_selections, conversion_fail_tag): New global variables.
4400 (x_selection_request_lisp_error): Free the above.
4401 (x_get_local_selection): Remove unnecessary code.
4402 (x_reply_selection_request): Args changed; handle arbitrary array
4403 of converted selections stored in converted_selections.
4404 Separate the XChangeProperty and SelectionNotify steps.
4405 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4406 (x_convert_selection): New function.
4407 (x_handle_selection_event): Simplify.
4408 (x_get_foreign_selection): Don't ignore incoming requests while
4409 waiting for an answer; this will fail when we implement
4410 SAVE_TARGETS, and seems unnecessary anyway.
4411 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4412 (Vx_sent_selection_functions): Doc fix.
4414 2011-05-26 Leo Liu <sdl.web@gmail.com>
4416 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4418 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4420 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4422 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4423 for fringe update if it has periodic bitmap.
4424 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4425 and fringe_bitmap_periodic_p.
4427 * fringe.c (get_fringe_bitmap_data): New function.
4428 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4429 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4430 row. Mark glyph row for fringe update if periodicity changed.
4432 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4433 for fringe update unless it has periodic bitmap.
4435 2011-05-25 Kenichi Handa <handa@m17n.org>
4437 * xdisp.c (get_next_display_element): Set correct it->face_id for
4438 a static composition.
4440 2011-05-24 Leo Liu <sdl.web@gmail.com>
4443 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4445 * fns.c (crypto_hash_function, Fsha1): New function.
4446 (Fmd5): Use crypto_hash_function.
4447 (syms_of_fns): Add Ssha1.
4449 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4451 * gnutls.c: Remove unused macros.
4452 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4453 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4454 Remove macros that are defined and never used.
4455 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4457 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4459 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4460 (Fx_get_selection_internal): Minor cleanup.
4461 (Fx_own_selection_internal): Rename arguments for consistency with
4464 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4466 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4468 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4470 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4472 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4474 * dispnew.c (scrolling_window): Don't exclude the case that the
4475 last enabled row in the desired matrix touches the bottom boundary.
4477 2011-05-21 Glenn Morris <rgm@gnu.org>
4479 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4480 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4481 and add some more files.
4483 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4485 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4486 report_file_error introduced by the change from 2011-05-07.
4488 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4490 * systime.h (Time): Define only if emacs is defined.
4491 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4492 where the include path doesn't have X11/X.h by default. See
4493 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4495 2011-05-20 Kenichi Handa <handa@m17n.org>
4497 * composite.c (find_automatic_composition): Fix previous change.
4499 2011-05-20 Glenn Morris <rgm@gnu.org>
4501 * lisp.mk: New file, split from Makefile.in.
4502 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4503 (shortlisp): Remove.
4504 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4506 2011-05-19 Glenn Morris <rgm@gnu.org>
4508 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4509 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4510 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4511 (lisp): Set the order to that of loadup.el.
4512 (shortlisp): Make it a copy of $lisp.
4513 (SOME_MACHINE_LISP): Remove.
4514 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4515 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4517 2011-05-18 Kenichi Handa <handa@m17n.org>
4519 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4520 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4521 (find_automatic_composition): Mostly rewrite for efficiency.
4523 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4525 * makefile.w32-in: Update dependencies.
4527 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4529 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4530 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4532 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4534 Fix some integer overflow issues, such as string length overflow.
4536 * insdel.c (count_size_as_multibyte): Check for string overflow.
4538 * character.c (lisp_string_width): Check for string overflow.
4539 Use EMACS_INT, not int, for string indexes and lengths; in
4540 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4541 the resulting string length overflows an EMACS_INT; instead,
4542 report a string overflow if no precision given. When checking for
4543 precision exhaustion, use a check that cannot possibly have
4544 integer overflow. (Bug#8675)
4545 * character.h (lisp_string_width): Adjust to new signature.
4547 * alloc.c (string_overflow): New function.
4548 (Fmake_string): Use it. This doesn't change behavior, but saves
4549 a few bytes and will simplify future changes.
4550 * character.c (string_escape_byte8): Likewise.
4551 * lisp.h (string_overflow): New decl.
4553 Fixups, following up to the user-interface timestamp change.
4554 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4555 for UI timestamps, instead of unsigned long.
4556 * msdos.c (mouse_get_pos): Likewise.
4557 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4558 * w32gui.h (Time): Define by including "systime.h" rather than by
4559 declaring it ourselves. (Bug#8664)
4561 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4562 * image.c (clear_image_cache): Likewise.
4564 * term.c (term_mouse_position): Don't assume time_t wraparound.
4566 Be more systematic about user-interface timestamps.
4567 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4568 and sometimes 'EMACS_UINT', to represent these timestamps.
4569 This change causes it to use 'Time' uniformly, as that's what X uses.
4570 This makes the code easier to follow, and makes it easier to catch
4571 integer overflow bugs such as Bug#8664.
4572 * frame.c (Fmouse_position, Fmouse_pixel_position):
4573 Use Time, not unsigned long, for user-interface timestamps.
4574 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4575 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4576 * keyboard.h (last_event_timestamp): Likewise.
4577 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4578 * menu.h (xmenu_show): Likewise.
4579 * term.c (term_mouse_position): Likewise.
4580 * termhooks.h (struct input_event.timestamp): Likewise.
4581 (struct terminal.mouse_position_hook): Likewise.
4582 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4583 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4584 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4585 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4587 * menu.h, termhooks.h: Include "systime.h", for Time.
4589 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4590 Don't assume that the difference between two unsigned long values
4591 can fit into an integer. At this point, we know button_down_time
4592 <= event->timestamp, so the difference must be nonnegative, so
4593 there's no need to cast the result if double-click-time is
4594 nonnegative, as it should be; check that it's nonnegative, just in
4595 case. This bug is triggered when events are more than 2**31 ms
4596 apart (about 25 days). (Bug#8664)
4598 * xselect.c (last_event_timestamp): Remove duplicate decl.
4599 (x_own_selection): Remove needless cast to unsigned long.
4601 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4602 that always fit in int. Use a sentinel instead of a counter, to
4603 avoid a temp and to allay GCC's concerns about possible int overflow.
4604 * frame.h (struct frame): Use int for menu_bar_items_used
4605 instead of EMACS_INT, since it always fits in int.
4607 * menu.c (grow_menu_items): Check for int overflow.
4609 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4611 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4612 Before, the code was not consistent. These values cannot exceed
4613 2**31 - 1 so there's no need to make them unsigned.
4614 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4615 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4616 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4618 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4620 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4621 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4622 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4623 presumably because the widths might not match.
4625 * window.c (size_window): Avoid needless test at loop start.
4627 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4629 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4631 2011-05-12 Drew Adams <drew.adams@oracle.com>
4633 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4635 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4637 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4638 `width' to `bar_area_x' and `bar_area_width', respectively.
4639 (x_scroll_run): Take account of fringe background extension.
4641 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4642 Rename local vars `left' and `width' to `bar_area_x' and
4643 `bar_area_width', respectively.
4644 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4645 background extension.
4647 2011-05-10 Jim Meyering <meyering@redhat.com>
4649 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4651 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4653 * image.c (Finit_image_library): Return t for built-in image types,
4654 like pbm and xbm. (Bug#8640)
4656 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4658 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4660 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4662 * w32console.c (Fset_screen_color): Doc fix.
4663 (Fget_screen_color): New function.
4664 (syms_of_ntterm): Defsubr it.
4666 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4667 unlink the temporary file if Fcall_process didn't create it in the
4669 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4670 child process will be redirected to a file specified with `:file'.
4671 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4672 cue to call_process_cleanup not to close that handle.
4674 2011-05-07 Ben Key <bkey76@gmail.com>
4676 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4677 one of two shell specific rules, either bootstrap-temacs-CMD or
4678 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4679 to the previous implementation of the bootstrap-temacs rule.
4680 The bootstrap-temacs-CMD rule is similar to the previous
4681 implementation of the bootstrap-temacs rule except that it
4682 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4685 These changes, along with some changes to nt/configure.bat,
4686 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4687 earlier fix to add support for --cflags and --ldflags options
4688 that include quotes so that it works whether make uses cmd or
4691 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4693 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4694 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4696 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4697 a string. Handle both cases.
4698 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4699 (Fdbus_register_method): Use Qinvalid_function.
4701 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4703 * makefile.w32-in: Update dependencies.
4704 (LISP_H): Add inttypes.h and stdin.h.
4705 (PROCESS_H): Add unistd.h.
4707 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4709 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4710 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4712 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4714 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4716 * term.c (vfatal): Remove stray call to va_end.
4717 It's not needed and the C Standard doesn't allow it here anyway.
4719 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4720 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4722 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4725 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4727 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4729 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4731 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4733 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4735 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4736 * charset.c (Fdefine_charset_internal): Don't initialize
4737 charset.code_space[15]. The value was garbage, on hosts with
4738 32-bit int (Bug#8600).
4740 * lread.c (read_integer): Be more consistent with string-to-number.
4741 Use string_to_number to do the actual conversion; this avoids
4742 rounding errors and fixes some other screwups. Without this fix,
4743 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4744 (digit_to_number): Move earlier, for benefit of read_integer.
4745 Return -1 if the digit is out of range for the base, -2 if it is
4746 not a digit in any supported base. (Bug#8602)
4748 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4750 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4751 to match comment at start of function. This also removes a
4752 GCC warning about overflow in a 32+64-bit port.
4754 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4756 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4757 Reported by Stefan Monnier in
4758 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4759 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4760 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4762 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4763 (EMACS_UINTPTR): Likewise, with uintptr_t.
4765 * lisp.h: Prefer 64-bit EMACS_INT if available.
4766 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4767 on 32-bit hosts that have 64-bit int, so that they can access
4769 However, temporarily disable this change unless the temporary
4770 symbol WIDE_EMACS_INT is defined.
4772 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4774 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4775 This removes an assumption that EMACS_INT and long are the same
4776 width as pointers. The assumption is true for Emacs porting targets
4777 now, but we want to make other targets possible.
4778 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4779 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4780 In the rest of the code, change types of integers that hold casted
4781 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4782 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4783 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4784 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4785 No need to cast type when ORing.
4786 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4787 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4788 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4789 assume EMACS_INT is the same width as char *.
4790 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4791 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4792 Remove no-longer-needed casts.
4793 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4794 (xg_tool_bar_help_callback, xg_make_tool_item):
4795 Use EMACS_INTPTR to hold an integer
4796 that will be cast to void *; this can avoid a GCC warning
4797 if EMACS_INT is not the same width as void *.
4798 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4799 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4800 (current_message_1, set_message_1):
4801 Use a local to convert to proper width without a cast.
4802 * xmenu.c (dialog_selection_callback): Likewise.
4804 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4805 Also, don't assume VALBITS / RAND_BITS is less than 5,
4806 and don't rely on undefined behavior when shifting a 1 left into
4808 * lisp.h (get_random): Change signature to match.
4810 * lread.c (hash_string): Use size_t, not int, for hash computation.
4811 Normally we prefer signed values; but hashing is special, because
4812 it's better to use unsigned division on hash table sizes so that
4813 the remainder is nonnegative. Also, size_t is the natural width
4814 for hashing into memory. The previous code used 'int', which doesn't
4815 retain enough info to hash well into very large tables.
4816 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4818 * dbusbind.c: Don't possibly lose pointer info when converting.
4819 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4820 Use XPNTR rather than XHASH, so that the high-order bits of
4821 the pointer aren't lost when converting through void *.
4823 * eval.c (Fautoload): Don't double-shift a pointer.
4825 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4827 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4829 * gnutls.c (DEF_GNUTLS_FN):
4830 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4832 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4834 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4837 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4839 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4840 New version that can reserve upto 2GB of heap space.
4842 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4844 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4846 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4848 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4849 `gnutls_certificate_set_x509_key_file'.
4851 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4853 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4854 Update dependencies.
4856 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4858 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4859 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4860 Remove unused parameter `fildes'.
4861 * process.c (read_process_output, send_process): Don't pass it.
4863 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4865 Fix previous change: the library cache is defined in w32.c.
4866 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4867 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4869 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4871 Implement dynamic loading of GnuTLS on Windows.
4873 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4874 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4875 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4878 * gnutls.c (Qgnutls_dll): Define.
4879 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4880 (gnutls_*): Declare function pointers.
4881 (init_gnutls_functions): New function to initialize function pointers.
4882 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4883 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4884 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4885 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4886 (emacs_gnutls_write, emacs_gnutls_read)
4887 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4888 (Fgnutls_available_p): New function.
4889 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4890 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4891 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4893 * image.c: Include w32.h.
4894 (Vimage_type_cache): Delete.
4895 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4896 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4897 (w32_delayed_load): Move to w32.c.
4899 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4901 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4902 (w32_delayed_load): Move from image.c. When loading a library, record
4903 its filename in the :loaded-from property of the library id.
4904 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4905 Initialize and staticpro them.
4906 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4908 * process.c: Include lisp.h before w32.h, not after.
4909 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4910 instead of gnutls_record_check_pending.
4912 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4914 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4916 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4917 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4920 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4922 * xterm.c (x_set_frame_alpha): Do not set property on anything
4923 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4925 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4927 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4929 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4931 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4932 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4933 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4934 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4935 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4936 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4937 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4938 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4939 (Qgnutls_bootprop_callbacks_verify): Make static.
4941 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4943 * callproc.c: Indentation fixup.
4945 * sysdep.c (wait_for_termination_1): Make static.
4946 (wait_for_termination, interruptible_wait_for_termination):
4947 Move after wait_for_termination_1.
4949 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4951 * sysdep.c (interruptible_wait_for_termination): New function
4952 which is like wait_for_termination, but allows keyboard
4955 * callproc.c (Fcall_process): Add (:file "file") as an option for
4957 (Fcall_process_region): Ditto.
4959 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4961 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4962 rather than `XVECTOR (FOO)->size'.
4964 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4965 inttypes.h, as a gnulib replacement is used if it not available in
4968 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4970 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4971 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4972 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4974 * coding.c (coding_alloc_by_realloc): Error out if destination
4975 will grow beyond MOST_POSITIVE_FIXNUM.
4976 (decode_coding_emacs_mule): Abort if there isn't enough place in
4977 charbuf for the composition carryover bytes. Reserve an extra
4978 space for up to 2 characters produced in a loop.
4979 (decode_coding_iso_2022): Abort if there isn't enough place in
4980 charbuf for the composition carryover bytes.
4982 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4984 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4985 aborting when %lld or %lll format is passed.
4986 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4987 %llo or %llx format is passed. (Bug#8545)
4989 * window.c (window_scroll_line_based): Use a marker instead of
4990 simple variables to record original value of point. (Bug#7952)
4992 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4993 produced by %s or %c overflows available buffer space. (Bug#8545)
4995 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4997 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4998 (SIZE_MAX): Move defn after all includes, as they might #define it.
5000 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5002 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5004 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5006 * keyboard.c (Qdelayed_warnings_hook): Define.
5007 (command_loop_1): Run `delayed-warnings-hook'
5008 if Vdelayed_warnings_list is non-nil.
5009 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5010 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5012 2011-04-28 Eli Zaretskii <eliz@gnu.org>
5014 * doprnt.c (doprnt): Don't return value smaller than the buffer
5015 size if the message was truncated. (Bug#8545).
5017 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5019 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5020 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5022 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5024 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5026 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
5028 * makefile.w32-in: Update dependencies.
5030 2011-04-27 Eli Zaretskii <eliz@gnu.org>
5032 Improve `doprnt' and its usage. (Bug#8545)
5033 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5034 `format_end'. Remove support for %l as a conversion specifier.
5035 Don't use xrealloc. Improve diagnostics when the %l size modifier
5036 is used. Update the commentary.
5038 * eval.c (verror): Simplify calculation of size_t.
5040 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5043 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5045 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5048 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5050 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5051 This makes this file independent of the recent pseudovector change.
5053 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
5055 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5057 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
5058 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
5059 Remove unused local.
5060 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
5062 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
5063 GCC 4.6.0 optimizes based on type-based alias analysis.
5064 For example, if b is of type struct buffer * and v of type struct
5065 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5066 != &v->size, and therefore "v->size = 1; b->size = 2; return
5067 v->size;" must therefore return 1. This assumption is incorrect
5068 for Emacs, since it type-puns struct Lisp_Vector * with many other
5069 types. To fix this problem, this patch adds a new type struct
5070 vectorlike_header that documents the constraints on layout of vectors
5071 and pseudovectors, and helps optimizing compilers not get fooled
5072 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5073 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
5074 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5076 (XSETPVECTYPE): Rewrite in terms of new macro.
5077 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5078 This is a bit clearer, and further avoids the possibility of
5079 undesirable aliasing.
5080 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
5081 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
5082 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5083 since Lisp_Subr is a special case (no "next" field).
5084 (ASIZE): Now uses header.size rather than size.
5085 All previous uses of XVECTOR (foo)->size replaced to use this macro,
5086 to avoid the hassle of writing XVECTOR (foo)->header.size.
5087 (struct vectorlike_header): New type.
5088 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5089 object, to help avoid aliasing.
5090 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5091 (SUBRP): Likewise, since Lisp_Subr is a special case.
5092 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5093 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5094 (struct Lisp_Hash_Table): Combine first two members into a single
5095 struct vectorlike_header member. All uses of "size" and "next" members
5096 changed to be "header.size" and "header.next".
5097 * buffer.h (struct buffer): Likewise.
5098 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5099 * frame.h (struct frame): Likewise.
5100 * process.h (struct Lisp_Process): Likewise.
5101 * termhooks.h (struct terminal): Likewise.
5102 * window.c (struct save_window_data, struct saved_window): Likewise.
5103 * window.h (struct window): Likewise.
5104 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5105 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5106 * buffer.c (init_buffer_once): Likewise.
5107 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5109 * process.c (Fformat_network_address): Use local var for size,
5112 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5114 Make the Lisp reader and string-to-float more consistent (Bug#8525)
5115 * data.c (atof): Remove decl; no longer used or needed.
5116 (digit_to_number): Move to lread.c.
5117 (Fstring_to_number): Use new string_to_number function, to be
5118 consistent with how the Lisp reader treats infinities and NaNs.
5119 Do not assume that floating-point numbers represent EMACS_INT
5120 without losing information; this is not true on most 64-bit hosts.
5121 Avoid double-rounding errors, by insisting on integers when
5122 parsing non-base-10 numbers, as the documentation specifies.
5123 * lisp.h (string_to_number): New decl, replacing ...
5124 (isfloat_string): Remove.
5125 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
5126 (read1): Do not accept +. and -. as integers; this
5127 appears to have been a coding error. Similarly, do not accept
5128 strings like +-1e0 as floating point numbers. Do not report
5129 overflow for integer overflows unless the base is not 10 which
5130 means we have no simple and reliable way to continue.
5131 Break out the floating-point parsing into a new
5132 function string_to_number, so that Fstring_to_number parses
5133 floating point numbers consistently with the Lisp reader.
5134 (digit_to_number): Move here from data.c. Make it static inline.
5135 (E_CHAR, EXP_INT): Remove, replacing with ...
5136 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5137 (string_to_number): New function, replacing isfloat_string.
5138 This function checks for valid syntax and produces the resulting
5139 Lisp float number too. Rework it so that string-to-number
5140 no longer mishandles examples like "1.0e+". Use strtoumax,
5141 so that overflow for non-base-10 numbers is reported only when
5142 there's no portable and simple way to convert to floating point.
5144 * textprop.c (set_text_properties_1): Rewrite for clarity,
5145 and to avoid GCC warning about integer overflow.
5147 * intervals.h (struct interval): Use EMACS_INT for members
5148 where EMACS_UINT might cause problems. See
5149 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5150 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5151 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5153 (offset_intervals): Tell GCC not to worry about length overflow
5154 when negating a negative length.
5156 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5157 (overrun_check_free): Likewise.
5159 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5160 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5163 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5164 (gnutls_make_error): Rename local to avoid shadowing.
5165 (gnutls_emacs_global_deinit): ifdef out; not used.
5166 (Fgnutls_boot): Use const for pointer to readonly storage.
5167 Comment out unused local. Fix pointer signedness problems.
5169 * lread.c (openp): Don't stuff size_t into an 'int'.
5170 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5171 about possible signed overflow.
5173 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5174 (GDK_KEY_g): Don't define if already defined.
5175 (xg_prepare_tooltip): Avoid pointer signedness problem.
5176 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5178 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5179 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5181 * xfns.c (Fx_window_property): Simplify a bit,
5182 to make a bit faster and to avoid GCC 4.6.0 warning.
5183 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5185 * fns.c (internal_equal): Don't assume size_t fits in int.
5187 * alloc.c (compact_small_strings): Tighten assertion a little.
5189 Replace pEd with more-general pI, and fix some printf arg casts.
5190 * lisp.h (pI): New macro, generalizing old pEd macro to other
5191 conversion specifiers. For example, use "...%"pI"d..." rather
5192 than "...%"pEd"...".
5193 (pEd): Remove. All uses replaced with similar uses of pI.
5194 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5195 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5196 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5197 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5198 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5199 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5200 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5202 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5203 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5204 * print.c (safe_debug_print, print_object): Likewise.
5205 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5207 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5208 avoiding the 0 flag, which is not portable.
5209 * process.c (Fmake_network_process): Use pI to avoid cast.
5210 * region-cache.c (pp_cache): Likewise.
5211 * xdisp.c (decode_mode_spec): Likewise.
5212 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5213 behavior on 64-bit hosts with printf arg.
5214 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
5215 (x_stop_queuing_selection_requests): Likewise.
5216 (x_get_window_property): Don't truncate byte count to an 'int'
5219 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5220 here, since it parses constructs like leading '-' and spaces,
5221 which are not wanted; and it overflows with large numbers.
5222 Instead, simply match F[0-9]+, which is what is wanted anyway.
5224 * alloc.c: Remove unportable assumptions about struct layout.
5225 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5226 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5227 (allocate_vectorlike, make_pure_vector): Use the new macros,
5228 plus offsetof, to remove unportable assumptions about struct layout.
5229 These assumptions hold on all porting targets that I know of, but
5230 they are not guaranteed, they're easy to remove, and removing them
5231 makes further changes easier.
5233 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5234 This doesn't fix a bug but makes the code clearer.
5235 (string_overrun_cookie): Now const. Use initializers that
5236 don't formally overflow signed char, to avoid warnings.
5237 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5238 can cause Emacs to crash when string overrun checking is enabled.
5239 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5240 multiple of sizeof (EMACS_INT); it need not be, if
5241 alignof(EMACS_INT) < sizeof (EMACS_INT).
5242 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
5244 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
5246 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5248 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5250 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
5251 supposed to be handshaking. (Bug#8556)
5252 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5254 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
5256 * lisp.h (Qdebug): List symbol.
5257 * eval.c (Qdebug): Restore global linkage.
5258 * keyboard.c (debug-on-event): New variable.
5259 (handle_user_signal): Break into debugger when debug-on-event
5260 matches the current signal symbol.
5262 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5264 * alloc.c (check_sblock, check_string_bytes)
5265 (check_string_free_list): Convert to standard C.
5267 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5269 * w32.c (emacs_gnutls_push): Fix typo.
5271 2011-04-25 Eli Zaretskii <eliz@gnu.org>
5273 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5274 "cast to pointer from integer of different size".
5276 Improve doprnt and its use in verror. (Bug#8545)
5277 * doprnt.c (doprnt): Document the set of format control sequences
5278 supported by the function. Use SAFE_ALLOCA instead of always
5281 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5282 is one byte too soon. Don't use xrealloc; instead xfree and
5285 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5287 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5290 * gnutls.c: Renamed global_initialized to
5291 gnutls_global_initialized. Added internals for the
5292 :verify-hostname-error, :verify-error, and :verify-flags
5293 parameters of `gnutls-boot' and documented those parameters in the
5294 docstring. Start callback support.
5295 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5296 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5297 on error. Return error code.
5298 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5299 (emacs_gnutls_read): Likewise.
5300 (Fgnutls_boot): Return handshake error code.
5301 (emacs_gnutls_handle_error): New function.
5302 (wsaerror_to_errno): Likewise.
5304 * w32.h (emacs_gnutls_pull): Add prototype.
5305 (emacs_gnutls_push): Likewise.
5307 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5308 (emacs_gnutls_push): Likewise.
5310 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5312 * process.c (wait_reading_process_output): Check if GnuTLS
5313 buffered some data internally if no FDs are set for TLS
5316 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5317 (LIBS): Link to USER_LIBS.
5318 ($(BLD)/gnutls.$(0)): New target.
5320 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5322 * xdisp.c (handle_single_display_spec): Rename the
5323 display_replaced_before_p argument into display_replaced_p, to
5324 make it consistent with the commentary. Fix typos in the
5327 * textprop.c (syms_of_textprop): Remove dead code.
5328 (copy_text_properties): Delete obsolete commentary about an
5329 interface that was deleted long ago. Fix typos in the description
5332 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5333 to changes in oldXMenu/XMenu.h from 2011-04-16.
5334 <menu_help_message, prev_menu_help_message>: Constify.
5335 (IT_menu_make_room): menu->help_text is now `const char **';
5338 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5339 to changes in oldXMenu/XMenu.h from 2011-04-16.
5340 (struct XMenu): Declare `help_text' `const char **'.
5342 * xfaces.c <Qunspecified>: Make extern again.
5344 * syntax.c: Include sys/types.h before including regex.h, as
5347 * doc.c (get_doc_string): Improve the format passed to `error'.
5349 * doprnt.c (doprnt): Improve commentary.
5351 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5353 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5356 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5357 changes in globals.h immediately force recompilation.
5358 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5359 $(CURDIR)/s/ms-w32.h.
5360 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5362 * character.c (Fchar_direction): Function deleted.
5363 (syms_of_character): Don't defsubr it.
5364 <char-direction-table>: Deleted.
5366 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5368 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5369 * doprnt.c: Include limits.h.
5370 (SIZE_MAX): New macro.
5371 (doprnt): Return a size_t value. 2nd arg is now size_t.
5372 Many local variables are now size_t instead of int or unsigned.
5373 Improve overflow protection. Support `l' modifier for integer
5374 conversions. Support %l conversion. Don't assume an EMACS_INT
5375 argument for integer conversions and for %c.
5377 * lisp.h (doprnt): Restore prototype.
5379 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5382 * Makefile.in (base_obj): Add back doprnt.o.
5384 * deps.mk (doprnt.o): Add back prerequisites.
5385 (callint.o): Depend on character.h.
5387 * eval.c (internal_lisp_condition_case): Include the handler
5388 representation in the error message.
5389 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5390 when breaking from the loop.
5392 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5394 * callint.c (Fcall_interactively): When displaying error message
5395 about invalid control letter, pass the character's codepoint, not
5396 a pointer to its multibyte form. Improve display of the character
5397 in octal and display also its hex code.
5399 * character.c (char_string): Use %x to display the (unsigned)
5400 codepoint of an invalid character, to avoid displaying a bogus
5403 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5404 `error', not SYMBOL_NAME itself.
5406 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5407 character arguments to `error'.
5409 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5410 to `error' in error message about FINAL_CHAR argument. Make sure
5411 FINAL_CHAR is a character, and use %c when it is passed as
5412 argument to `error'.
5414 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5416 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5418 * w32.c: Include <time.h>.
5419 (sys_localtime): New function.
5421 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5423 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5425 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5427 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5429 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5432 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5434 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5435 gl_state.e_property when gl_state.object is Qt.
5437 * insdel.c (make_gap_larger): Remove limitation of buffer size
5440 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5442 * xdisp.c (lookup_glyphless_char_display)
5443 (produce_glyphless_glyph): Handle cons cell entry in
5444 glyphless-char-display.
5445 (Vglyphless_char_display): Document it.
5447 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5448 glyphless-char-display.
5450 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5452 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5454 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5456 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5457 definition for no-X builds.
5459 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5461 Static checks with GCC 4.6.0 and non-default toolkits.
5463 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5465 * process.c (keyboard_bit_set): Define only if SIGIO.
5466 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5467 (send_process): Repair possible setjmp clobbering.
5469 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5471 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5473 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5475 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5476 Define only if needed.
5478 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5479 by pacifying GCC about it. Maybe it's time to retire it?
5480 * xfaces.c (USG, __TIMEVAL__): Likewise.
5482 * dispextern.h (struct redisplay_interface): Rename param
5484 * termhooks.h (struct terminal): Likewise.
5485 * xterm.c (xembed_send_message): Likewise.
5487 * insdel.c (make_gap_smaller): Define only if
5488 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5490 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5493 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5494 so that we aren't warned about unused symbols.
5496 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5498 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5500 * xfns.c (x_real_positions): Mark locals as initialized.
5502 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5504 * xterm.c: Fix problems found by static analysis with other toolkits.
5505 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5506 (x_dispatch_event): Declare static if USE_GTK, and
5507 define if USE_GTK || USE_X_TOOLKIT.
5508 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5509 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5510 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5511 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5513 * xmenu.c (menu_help_callback): Pointer type fixes.
5514 Use const pointers when pointing at readonly data. Avoid pointer
5516 (FALSE): Remove unused macro.
5517 (update_frame_menubar): Remove unused decl.
5519 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5521 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5522 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5523 (single_menu_item): Rename local to avoid shadowing.
5525 * keyboard.c (make_lispy_event): Remove unused local var.
5527 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5528 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5530 * bitmaps: Change bitmaps from unsigned char back to the X11
5531 compatible char. Avoid the old compiler warnings about
5532 out-of-range initializers by using, for example, '\xab' rather
5535 * xgselect.c (xgselect_initialize): Check vs interface
5536 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5538 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5540 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5541 to read-only memory.
5543 * fns.c (vector): Remove; this old hack is no longer needed.
5545 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5547 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5549 * xrdb.c (x_load_resources): Omit unused local.
5551 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5552 (x_window): Rename locals to avoid shadowing.
5553 (USG): Use the kludged USG macro, to pacify gcc.
5555 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5556 (x_term_init): Remove local to avoid shadowing.
5558 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5560 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5561 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5563 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5565 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5567 Fix regex.c, syntax.c and friends for buffers > 2GB.
5568 * syntax.h (struct gl_state_s): Declare character position members
5571 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5573 * textprop.c (verify_interval_modification, interval_of):
5574 Declare arguments EMACS_INT.
5576 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5579 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5581 * indent.c (Fvertical_motion): Local variable it_start is now
5584 * regex.c (re_match, re_match_2, re_match_2_internal)
5585 (bcmp_translate, regcomp, regexec, print_double_string)
5586 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5587 (re_compile_pattern, re_exec): Declare arguments and local
5588 variables `size_t' and `ssize_t' and return values `regoff_t', as
5590 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5591 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5592 <compile_stack_type>: `size' and `avail' are now `size_t'.
5594 * regex.h <regoff_t>: Use ssize_t, not int.
5595 (re_search, re_search_2, re_match, re_match_2): Arguments that
5596 specify buffer/string position and length are now ssize_t and
5597 size_t. Return type is regoff_t.
5599 2011-04-16 Ben Key <bkey76@gmail.com>
5601 * nsfont.m: Fixed bugs in ns_get_family and
5602 ns_descriptor_to_entity that were caused by using free to
5603 deallocate memory blocks that were allocated by xmalloc (via
5604 xstrdup). This caused Emacs to crash when compiled with
5605 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5606 --enable-checking=xmallocoverrun). xfree is now used to
5607 deallocate these memory blocks.
5609 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5611 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5613 emacs_write: Accept and return EMACS_INT for sizes.
5614 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5616 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5617 Accept and return EMACS_INT.
5618 (emacs_gnutls_write): Return the number of bytes written on
5620 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5621 (emacs_read, emacs_write): Remove check for negative size, as the
5622 Emacs source code has been audited now.
5623 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5624 (emacs_read, emacs_write): Use it.
5625 * process.c (send_process): Adjust to the new signatures of
5626 emacs_write and emacs_gnutls_write. Do not attempt to store
5627 a byte offset into an 'int'; it might overflow.
5628 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5630 * sound.c: Don't assume sizes fit in 'int'.
5631 (struct sound_device.period_size, alsa_period_size):
5632 Return EMACS_INT, not int.
5633 (struct sound_device.write, vox_write, alsa_write):
5634 Accept EMACS_INT, not int.
5635 (wav_play, au_play): Use EMACS_INT to store sizes and to
5636 record read return values.
5638 2011-04-15 Ben Key <bkey76@gmail.com>
5640 * keyboard.c (Qundefined): Don't declare static since it is used
5642 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5643 static since they are used in nsfont.m.
5645 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5647 * process.c (Qprocessp): Don't declare static.
5648 * lisp.h (Qprocessp): Declare again.
5650 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5652 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5654 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5656 Improve C-level modularity by making more things 'static'.
5658 Don't publish debugger-only interfaces to other modules.
5659 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5660 (verify_bytepos, count_markers): Move decls to the only modules
5662 * region-cache.h (pp_cache): Likewise.
5663 * window.h (check_all_windows): Likewise.
5664 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5666 * sysdep.c (croak): Now static, if
5667 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5668 * syssignal.h (croak): Declare only if not static.
5670 * alloc.c (refill_memory_reserve): Now static if
5671 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5672 * lisp.h (refill_memory_reserve): Declare only if not static.
5674 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5675 Define only if USE_LUCID.
5677 * xrdb.c (x_customization_string, x_rm_string): Now static.
5679 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5680 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5682 * xdisp.c (draw_row_with_mouse_face): Now static.
5683 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5685 * window.h (check_all_windows): Mark externally visible.
5687 * window.c (window_deletion_count): Now static.
5689 * undo.c: Make symbols static if they're not exported.
5690 (last_undo_buffer, last_boundary_position, pending_boundary):
5693 * textprop.c (interval_insert_behind_hooks): Now static.
5694 (interval_insert_in_front_hooks): Likewise.
5696 * term.c: Make symbols static if they're not exported.
5697 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5698 (max_frame_lines, tty_set_terminal_modes):
5699 (tty_reset_terminal_modes, tty_turn_off_highlight):
5700 (get_tty_terminal): Now static.
5701 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5702 * termhooks.h (term_mouse_moveto): Do not declare if
5704 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5705 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5707 * sysdep.c: Make symbols static if they're not exported.
5708 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5710 (sigprocmask_set, full_mask): Remove; unused.
5711 (wait_debugging): Mark as visible.
5712 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5713 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5715 * syntax.c (syntax_temp): Define only if !__GNUC__.
5717 * sound.c (current_sound_device, current_sound): Now static.
5719 * search.c (searchbufs, searchbuf_head): Now static.
5721 * scroll.c (scroll_cost): Remove; unused.
5722 * dispextern.h (scroll_cost): Remove decl.
5724 * region-cache.h (pp_cache): Mark as externally visible.
5726 * process.c: Make symbols static if they're not exported.
5727 (process_tick, update_tick, create_process, chan_process):
5728 (Vprocess_alist, proc_buffered_char, datagram_access):
5729 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5730 (deactivate_process): Mark defn as static, as well as decl.
5731 * lisp.h (create_process): Remove decl.
5732 * process.h (chan_process, Vprocess_alist): Remove decls.
5734 * print.c: Make symbols static if they're not exported.
5735 (print_depth, new_backquote_output, being_printed, print_buffer):
5736 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5737 (print_interval, print_number_index, initial_stderr_stream):
5739 * lisp.h (Fprinc): Remove decl.
5740 (debug_output_compilation_hack): Mark as externally visible.
5742 * sysdep.c (croak): Move decl from here to syssignal.h.
5743 * syssignal.h (croak): Put it here, so the API can be checked when
5744 'croak' is called from dissociate_if_controlling_tty.
5746 * minibuf.c: Make symbols static if they're not exported.
5747 (minibuf_save_list, choose_minibuf_frame): Now static.
5748 * lisp.h (choose_minibuf_frame): Remove decl.
5750 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5752 * lread.c: Make symbols static if they're not exported.
5753 (read_objects, initial_obarray, oblookup_last_bucket_number):
5755 (make_symbol): Remove; unused.
5756 * lisp.h (initial_obarray, make_symbol): Remove decls.
5758 * keyboard.c: Make symbols static if they're not exported.
5759 (single_kboard, recent_keys_index, total_keys, recent_keys):
5760 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5761 (this_single_command_key_start, echoing, last_auto_save):
5762 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5763 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5764 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5765 (Vlispy_mouse_stem, double_click_count):
5767 (force_auto_save_soon): Define only if SIGDANGER.
5768 (ignore_mouse_drag_p): Now static if
5769 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5770 (print_help): Remove; unused.
5771 (stop_character, last_timer_event): Mark as externally visible.
5772 * keyboard.h (ignore_mouse_drag_p): Declare only if
5773 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5774 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5775 * lisp.h (echoing): Remove decl.
5776 (force_auto_save_soon): Declare only if SIGDANGER.
5777 * xdisp.c (redisplay_window): Simplify code, to make it more
5778 obvious that ignore_mouse_drag_p is not accessed if !defined
5779 USE_GTK && !defined HAVE_NS.
5781 * intervals.c: Make symbols static if they're not exported.
5782 (merge_properties_sticky, merge_interval_right, delete_interval):
5784 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5786 * insdel.c: Make symbols static if they're not exported.
5787 However, leave prepare_to_modify_buffer alone. It's never
5788 called from outside this function, but that appears to be a bug.
5789 (combine_after_change_list, combine_after_change_buffer):
5790 (adjust_after_replace, signal_before_change): Now static.
5791 (adjust_after_replace_noundo): Remove; unused.
5792 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5793 (signal_before_change): Remove decls.
5795 * indent.c (val_compute_motion, val_vmotion): Now static.
5797 * image.c: Make symbols static if they're not exported.
5798 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5800 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5801 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5803 * fringe.c (standard_bitmaps): Now static.
5804 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5806 * frame.c: Make symbols static if they're not exported.
5807 (x_report_frame_params, make_terminal_frame): Now static.
5808 (get_frame_param): Now static, unless HAVE_NS.
5809 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5810 (x_get_resource_string): Remove; not used.
5811 * frame.h (make_terminal_frame, x_report_frame_params):
5812 (x_get_resource_string); Remove decls.
5813 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5814 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5816 * font.c, fontset.c: Make symbols static if they're not exported.
5817 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5818 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5819 * font.c (font_close_object): Now static.
5820 * font.h (font_close_object): Remove.
5821 * fontset.c (FONTSET_OBJLIST): Remove.
5822 (free_realized_fontset) #if-0 the body, which does nothing.
5823 (face_suitable_for_char_p): #if-0, as it's never called.
5824 * fontset.h (face_suitable_for_char_p): Remove decl.
5825 * xfaces.c (face_at_string_position):
5826 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5827 since 0 is always ASCII.
5829 * fns.c (weak_hash_tables): Now static.
5831 * fileio.c: Make symbols static if they're not exported.
5832 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5833 (Vwrite_region_annotation_buffers): Now static.
5835 * eval.c: Make symbols static if they're not exported.
5836 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5837 * lisp.h (backtrace_list): Remove decl.
5839 * emacs.c: Make symbols static if they're not exported.
5840 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5841 (fatal_error_code, fatal_error_signal_hook, standard_args):
5843 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5844 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5845 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5846 * lisp.h (fatal_error_signal_hook): Remove decl.
5847 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5849 * editfns.c: Move a (normally-unused) function to its only use.
5850 * editfns.c, lisp.h (get_operating_system_release): Remove.
5851 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5852 worth the hassle of breaking this out.
5854 * xterm.c: Make symbols static if they're not exported.
5855 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5856 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5857 (x_destroy_window, x_delete_display):
5859 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5860 (x_mouse_leave): Remove; unused.
5861 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5862 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5863 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5865 (x_mouse_leave): Declare only if WINDOWSNT.
5866 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5867 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5870 * ftxfont.c: Make symbols static if they're not exported.
5871 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5873 * font.h (ftxfont_driver): Likewise.
5875 * xfns.c: Make symbols static if they're not exported.
5876 (x_last_font_name, x_display_info_for_name):
5877 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5878 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5879 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5880 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5881 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5882 (last_show_tip_args): Now static.
5883 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5884 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5885 (x_screen_planes): Remove; unused.
5886 * dispextern.h (x_screen_planes): Remove decl.
5888 * dispnew.c: Make symbols static if they're not exported.
5889 * dispextern.h (redraw_garbaged_frames, scrolling):
5890 (increment_row_positions): Remove.
5891 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5892 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5894 (redraw_garbaged_frames): Remove; unused.
5896 * xfaces.c: Make symbols static if they're not exported.
5897 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5899 * xterm.h (defined_color): Remove decls.
5900 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5901 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5902 (menu_face_changed_default, defined_color, free_realized_face):
5903 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5904 (ascii_face_of_lisp_face): Remove; unused.
5906 * xdisp.c: Make symbols static if they're not exported.
5907 * dispextern.h (scratch_glyph_row, window_box_edges):
5908 (glyph_to_pixel_coords, set_cursor_from_row):
5909 (get_next_display_element, set_iterator_to_next):
5910 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5911 (show_mouse_face): Remove decls
5912 * frame.h (message_buf_print): Likewise.
5913 * lisp.h (pop_message, set_message, check_point_in_composition):
5915 * xterm.h (set_vertical_scroll_bar): Likewise.
5916 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5917 (message_buf_print, scratch_glyph_row, displayed_buffer):
5918 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5919 (get_next_display_element, show_mouse_face, window_box_edges):
5920 (frame_to_window_pixel_xy, check_point_in_composition):
5921 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5922 (glyph_to_pixel_coords): Remove; unused.
5924 * dired.c (file_name_completion): Now static.
5926 * dbusbind.c (xd_in_read_queued_messages): Now static.
5928 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5929 * data.c (circular_list_error): Remove.
5931 * commands.h (last_point_position, last_point_position_buffer):
5932 (last_point_position_window): Remove decls.
5933 * keyboard.c: Make these variables static.
5935 * coding.h (coding, code_convert_region, encode_coding_gap):
5937 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5938 (iso_code_class, detect_coding, code_convert_region): Now static.
5939 (encode_coding_gap): Remove; unused.
5941 * chartab.c (chartab_chars, chartab_bits): Now static.
5943 * charset.h (charset_iso_8859_1): Remove decl.
5944 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5947 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5948 * ccl.c (Vccl_program_table): Now static.
5949 (check_ccl_update): Remove; unused.
5951 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5952 * category.h: ... from here.
5953 * category.c (check_category_table, set_category_set): Now static.
5955 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5956 * lisp.h: Remove these decls.
5958 * buffer.c (buffer_count): Remove unused var.
5960 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5961 so that it's not optimized away.
5962 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5963 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5964 exported only to the debugger.
5966 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5967 * atimer.h (run_all_atimers): Remove; not exported.
5969 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5970 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5971 was inaccessible from Lisp.
5972 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5973 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5975 alloc.c: Import and export fewer symbols, and remove unused items.
5976 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5978 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5979 it's not optimized away by whole-program optimization.
5980 (message_enable_multibyte, free_misc): Remove.
5981 (catchlist, handlerlist, mark_backtrace):
5982 Declare only if BYTE_MARK_STACK.
5983 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5984 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5985 (message_enable_multibyte): Remove decl.
5986 (free_misc, interval_free_list, float_block, float_block_index):
5987 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5988 (cons_free_list, last_marked_index):
5990 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5991 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5992 (mark_backtrace): Define only if BYTE_MARK_STACK.
5993 * xdisp.c (message_enable_multibyte): Now static.
5995 Declare Lisp_Object Q* variables to be 'static' if not exported.
5996 This makes it easier for human readers (and static analyzers)
5997 to see whether these variables are used from other modules.
5998 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5999 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6000 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6001 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6002 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6003 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6004 * xmenu.c, xselect.c:
6005 Declare Q* vars static if they are not used in other modules.
6006 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6007 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6008 Remove decls of unexported vars.
6009 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6011 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6013 Make Emacs functions such as Fatom 'static' by default.
6014 This makes it easier for human readers (and static analyzers)
6015 to see whether these functions can be called from other modules.
6016 DEFUN now defines a static function. To make the function external
6017 so that it can be used in other C modules, use the new macro DEFUE.
6018 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6019 (Finit_image_library):
6020 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6021 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6022 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6023 Remove decls, since these functions are now static.
6024 (Funintern, Fget_internal_run_time): New decls, since these functions
6025 were already external.
6027 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6028 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6029 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6030 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6031 * keyboard.c, keymap.c, lread.c:
6032 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6033 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6034 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6035 Mark functions with DEFUE instead of DEFUN,
6036 if they are used in other modules.
6037 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6038 decls for now-static functions.
6039 * buffer.h (Fdelete_overlay): Remove decl.
6040 * callproc.c (Fgetenv_internal): Mark as internal.
6041 * composite.c (Fremove_list_of_text_properties): Remove decl.
6042 (Fcomposition_get_gstring): New forward static decl.
6043 * composite.h (Fcomposite_get_gstring): Remove decl.
6044 * dired.c (Ffile_attributes): New forward static decl.
6045 * doc.c (Fdocumntation_property): New forward static decl.
6046 * eval.c (Ffetch_bytecode): New forward static decl.
6047 (Funintern): Remove extern decl; now in .h file where it belongs.
6048 * fileio.c (Fmake_symbolic_link): New forward static decl.
6049 * image.c (Finit_image_library): New forward static decl.
6050 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6051 * intervals.h (Fprevious_property_change):
6052 (Fremove_list_of_text_properties): Remove decls.
6053 * keyboard.c (Fthis_command_keys): Remove decl.
6054 (Fcommand_execute): New forward static decl.
6055 * keymap.c (Flookup_key): New forward static decl.
6056 (Fcopy_keymap): Now static.
6057 * keymap.h (Flookup_key): Remove decl.
6058 * process.c (Fget_process): New forward static decl.
6059 (Fprocess_datagram_address): Mark as internal.
6060 * syntax.c (Fsyntax_table_p): New forward static decl.
6061 (skip_chars): Remove duplicate decl.
6062 * textprop.c (Fprevious_property_change): New forward static decl.
6063 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6065 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6066 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6068 * editfns.c (Fformat): Remove unreachable code.
6070 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6072 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6075 2011-04-13 Eli Zaretskii <eliz@gnu.org>
6077 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6078 when at ZV. (Bug#8487)
6080 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6082 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6084 * keyboard.c (parse_tool_bar_item): Likewise.
6085 * sound.c (sound_cleanup, alsa_close): Likewise.
6086 * termcap.c (tgetent): Likewise.
6087 * xfns.c (x_default_font_parameter): Likewise.
6088 * xsettings.c (read_and_apply_settings): Likewise.
6090 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6091 (overrun_check_free): Protoize.
6093 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6095 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6096 since callers should never pass a negative size.
6097 Change the signature to match that of plain 'read' and 'write'; see
6098 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6099 * lisp.h: Update prototypes of emacs_write and emacs_read.
6101 2011-04-11 Eli Zaretskii <eliz@gnu.org>
6103 * xdisp.c (redisplay_window): Don't try to determine the character
6104 position of the scroll margin if the window start point w->startp
6105 is outside the buffer's accessible region. (Bug#8468)
6107 2011-04-10 Eli Zaretskii <eliz@gnu.org>
6109 Fix write-region and its subroutines for buffers > 2GB.
6110 * fileio.c (a_write, e_write): Modify declaration of arguments and
6111 local variables to support buffers larger than 2GB.
6112 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6114 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6115 argument, local variables, and return value.
6117 * lisp.h: Update prototypes of emacs_write and emacs_read.
6119 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6121 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
6123 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6125 Fix more problems found by GCC 4.6.0's static checks.
6127 * xdisp.c (vmessage): Use a better test for character truncation.
6129 * charset.c (load_charset_map): <, not <=, for optimization,
6130 and to avoid potential problems with integer overflow.
6131 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
6132 * casetab.c (set_identity, shuffle): Likewise.
6133 * editfns.c (Fformat): Likewise.
6134 * syntax.c (skip_chars): Likewise.
6136 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6137 This also lets GCC 4.6.0 generate slightly better loop code.
6139 * callint.c (Fcall_interactively): <, not <=, for optimization.
6140 (Fcall_interactively): Count the number of arguments produced,
6141 not the number of arguments given. This is simpler and lets GCC
6142 4.6.0 generate slightly better code.
6144 * ftfont.c: Distingish more carefully between FcChar8 and char.
6145 The previous code passed unsigned char * to a functions like
6146 strlen and xstrcasecmp that expect char *, which does not
6147 conform to the C standard.
6148 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6149 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6150 char * when the C standard requires it.
6152 * keyboard.c (read_char): Remove unused var.
6154 * eval.c: Port to Windows vsnprintf (Bug#8435).
6156 (SIZE_MAX): Define if the headers do not.
6157 (verror): Do not give up if vsnprintf returns a negative count.
6158 Instead, grow the buffer. This ports to Windows vsnprintf, which
6159 does not conform to C99. Problem reported by Eli Zaretskii.
6160 Also, simplify the allocation scheme, by avoiding the need for
6161 calling realloc, and removing the ALLOCATED variable.
6163 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6165 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6166 But keep the doprint source code for now, as we might revamp it
6167 and use it again (Bug#8435).
6168 * lisp.h (doprnt): Remove.
6169 * Makefile.in (base_obj): Remove doprnt.o.
6170 * deps.mk (doprnt.o): Remove.
6172 error: Print 32- and 64-bit integers portably (Bug#8435).
6173 Without this change, on typical 64-bit hosts error ("...%d...", N)
6174 was used to print both 32- and 64-bit integers N, which relied on
6176 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6178 * lisp.h (error, verror): Mark as printf-like functions.
6179 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6180 Report overflow in size calculations when allocating printf buffer.
6181 Do not truncate output string at its first null byte.
6182 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6183 Truncate the output at a character boundary, since vsnprintf does not
6185 * charset.c (check_iso_charset_parameter): Convert internal
6186 character to string before calling 'error', since %c now has the
6188 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6189 overflow when computing char to be passed to 'error'. Do not
6190 pass Lisp_Object to 'error'; pass the integer instead.
6191 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6192 formatted with plain %d.
6194 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6196 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6198 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6200 * xterm.c (x_catch_errors): Remove duplicate declaration.
6202 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6204 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6206 2011-04-10 Jim Meyering <meyering@redhat.com>
6208 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6209 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6210 return ssize_t not "int", and use size_t as the buffer length.
6211 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6212 * gnutls.h: Update declarations.
6213 * process.c (read_process_output): Use ssize_t, to match.
6214 (send_process): Likewise.
6216 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6218 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6220 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6222 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6223 Use unsigned char, to match FcChar8 type definition.
6225 * xterm.c (handle_one_xevent):
6226 * xmenu.c (create_and_show_popup_menu):
6227 * xselect.c (x_decline_selection_request)
6228 (x_reply_selection_request): Avoid type-punned deref of X events.
6230 2011-04-09 Eli Zaretskii <eliz@gnu.org>
6232 Fix some uses of `int' instead of EMACS_INT.
6233 * search.c (string_match_1, fast_string_match)
6234 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6235 (scan_buffer, find_next_newline_no_quit)
6236 (find_before_next_newline, search_command, Freplace_match)
6237 (Fmatch_data): Make some `int' variables be EMACS_INT.
6239 * xdisp.c (display_count_lines): 3rd argument and return value now
6240 EMACS_INT. All callers changed.
6241 (pint2hrstr): Last argument is now EMACS_INT.
6243 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6244 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6245 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6246 (decode_coding_utf_16, decode_coding_emacs_mule)
6247 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6248 (decode_coding_ccl, decode_coding_charset)
6249 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6250 (decode_coding_iso_2022, decode_coding_emacs_mule)
6251 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6252 <char_offset, last_offset>: Declare EMACS_INT.
6253 (encode_coding_utf_8, encode_coding_utf_16)
6254 (encode_coding_emacs_mule, encode_invocation_designation)
6255 (encode_designation_at_bol, encode_coding_iso_2022)
6256 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6257 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6259 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6260 (encode_invocation_designation): Last argument P_NCHARS is now
6262 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6263 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6265 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6268 * ccl.c (Fccl_execute_on_string): Declare some variables
6271 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
6273 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6275 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6277 * process.c (Fformat_network_address): Doc fix.
6279 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6281 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6283 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6285 * keyboard.c (read_char): Call Lisp function help-form-show,
6286 instead of using internal_with_output_to_temp_buffer.
6287 (Qhelp_form_show): New var.
6288 (syms_of_keyboard): Use DEFSYM macro.
6290 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6292 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6294 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
6296 * process.c (Flist_processes): Remove to Lisp.
6297 (list_processes_1): Delete.
6299 2011-04-06 Eli Zaretskii <eliz@gnu.org>
6301 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6303 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6305 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
6307 Fix more problems found by GCC 4.6.0's static checks.
6309 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6311 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6313 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6315 * xdisp.c (vmessage): Mark as a printf-like function.
6317 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6319 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6321 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6322 printf-like functions.
6323 (tiff_load): Add casts to remove these marks before passing them
6324 to system-supplied API.
6326 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6328 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6329 This avoids several warnings with gcc -Wstrict-overflow.
6330 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6331 directly, rather than having caller test rule sign. This avoids
6332 some unnecessary tests.
6333 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6334 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6335 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6337 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6338 (xfont_open): Avoid unnecessary tests.
6340 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6342 * composite.h, composite.c (composition_gstring_put_cache):
6343 Use EMACS_INT, not int, for length.
6345 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6346 breaking out part of COMPOSITION_DECODE_RULE.
6347 (COMPOSITION_DECODE_RULE): Use it.
6348 * composite.c (get_composition_id): Remove unused local vars,
6349 by using the new macro.
6351 * textprop.c (set_text_properties_1): Change while to do-while,
6352 since the condition is always true at first.
6354 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6355 (interval_deletion_adjustment): Return unsigned value.
6358 * process.c (list_processes_1, create_pty, read_process_output):
6359 (exec_sentinel): Remove vars that were set but not used.
6360 (create_pty): Remove unnecessary "volatile"s.
6361 (Fnetwork_interface_info): Avoid possibility of int overflow.
6362 (read_process_output): Do adaptive read buffering even if carryover.
6363 (read_process_output): Simplify nbytes computation if buffered.
6365 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6367 * syntax.c (scan_words): Remove var that was set but not used.
6368 (update_syntax_table): Use unsigned instead of int.
6370 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6371 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6372 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6374 * print.c (print_error_message): Avoid int overflow.
6376 * font.c (font_list_entities): Redo for clarity,
6377 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6379 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6380 (font_score): Avoid potential overflow in diff calculation.
6382 * fns.c (substring_both): Remove var that is set but not used.
6383 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6385 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6387 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6388 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6389 can always succeed if overflow has undefined behavior.
6391 * search.c (boyer_moore, wordify): Remove vars set but not used.
6392 (wordify): Omit three unnecessary tests.
6394 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6395 All callers changed. This avoids the need for an unused var.
6397 * casefiddle.c (casify_region): Remove var that is set but not used.
6399 * dired.c (file_name_completion): Remove var that is set but not used.
6401 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6403 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6404 (Finsert_file_contents): Remove unnecessary code checking fd.
6406 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6407 Check for integer overflow on size calculations.
6409 * buffer.c (Fprevious_overlay_change): Remove var that is set
6412 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6413 Remove vars that are set but not used.
6414 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6415 (timer_check_2): Mark vars as initialized.
6417 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6419 * image.c (lookup_image): Remove var that is set but not used.
6420 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6422 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6423 that are set but not used.
6425 * xfns.c (make_invisible_cursor): Don't return garbage
6426 if XCreateBitmapFromData fails (Bug#8410).
6428 * xselect.c (x_get_local_selection, x_handle_property_notify):
6429 Remove vars that are set but not used.
6431 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6432 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6434 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6435 Remove var that is set but not used.
6436 (scroll_bar_windows_size): Now size_t, not int.
6437 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6440 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6441 (map_tty_color) [!defined MSDOS]: Likewise.
6443 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6445 * coding.c: Remove vars that are set but not used.
6446 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6447 All callers changed.
6448 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6449 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6450 (decode_coding_charset): Remove vars that are set but not used.
6452 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6453 that is set but not used.
6455 * print.c (print_object): Remove var that is set but not used.
6457 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6458 The gnulib version avoids calling malloc in the usual case,
6459 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6460 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6461 * filelock.c (current_lock_owner): Likewise.
6462 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6463 * sysdep.c: Include allocator.h, careadlinkat.h.
6464 (emacs_no_realloc_allocator): New static constant.
6465 (emacs_readlink): New function.
6466 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6467 ../lib/careadlinkat.h.
6469 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6471 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6472 first non-nil return value).
6474 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6476 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6477 if not defined (Bug#8403).
6479 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6481 * xdisp.c (display_count_lines): Remove parameter `start',
6482 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6483 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6484 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6485 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6486 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6487 and thereabouts. All callers changed.
6488 (get_per_char_metric): Remove parameter `f', unused since
6489 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6491 2011-04-02 Jim Meyering <meyering@redhat.com>
6493 do not dereference NULL upon failed strdup
6494 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6495 (ns_get_family): Likewise.
6497 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6499 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6501 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6503 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6506 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6508 Add lexical binding.
6510 * window.c (Ftemp_output_buffer_show): New fun.
6511 (Fsave_window_excursion):
6512 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6514 * lread.c (lisp_file_lexically_bound_p): New function.
6515 (Fload): Bind Qlexical_binding.
6516 (readevalloop): Remove `evalfun' arg.
6517 Bind Qinternal_interpreter_environment.
6518 (Feval_buffer): Bind Qlexical_binding.
6519 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6521 (syms_of_lread): Declare `lexical-binding'.
6523 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6525 * keyboard.c (eval_dyn): New fun.
6526 (menu_item_eval_property): Use it.
6528 * image.c (parse_image_spec): Use Ffunctionp.
6530 * fns.c (concat, mapcar1): Accept byte-code-functions.
6532 * eval.c (Fsetq): Handle lexical vars.
6533 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6534 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6535 (FletX, Flet): Obey lexical binding.
6536 (Fcommandp): Handle closures.
6537 (Feval): New `lexical' arg.
6538 (eval_sub): New function extracted from Feval. Use it almost
6539 everywhere where Feval was used. Look up vars in lexical env.
6541 (Ffunctionp): Move from subr.el.
6542 (Ffuncall): Handle closures.
6543 (apply_lambda): Remove `eval_flags'.
6544 (funcall_lambda): Handle closures and new byte-code-functions.
6545 (Fspecial_variable_p): New function.
6546 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6547 but without exporting it to Lisp.
6549 * doc.c (Fdocumentation, store_function_docstring):
6550 * data.c (Finteractive_form): Handle closures.
6552 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6555 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6557 (exec_byte_code): New function extracted from Fbyte_code to handle new
6558 calling convention for byte-code-functions. Add new byte-codes.
6560 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6562 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6564 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6566 * xdisp.c (redisplay_internal): Fix prototype.
6568 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6570 * xdisp.c (SCROLL_LIMIT): New macro.
6571 (try_scrolling): Use it when setting scroll_limit.
6572 Limit scrolling to 100 screen lines.
6573 (redisplay_window): Even when falling back on "recentering",
6574 position point in the window according to scroll-conservatively,
6575 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6577 (try_scrolling): When point is above the window, allow searching
6578 as far as scroll_max, or one screenful, to compute vertical
6579 distance from PT to the scroll margin position. This prevents
6580 try_scrolling from unnecessarily failing when
6581 scroll-conservatively is set to a value slightly larger than the
6582 window height. Clean up the case of PT below the margin at bottom
6583 of window: scroll_max can no longer be INT_MAX. When aggressive
6584 scrolling is in use, don't let point enter the opposite scroll
6585 margin as result of the scroll.
6586 (syms_of_xdisp) <scroll-conservatively>: Document the
6587 threshold of 100 lines for never-recentering scrolling.
6589 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6591 * dispextern.h (move_it_by_lines):
6592 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6593 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6594 (message_log_check_duplicate): Remove parameters `prev_bol' and
6595 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6596 (redisplay_internal): Remove parameter `preserve_echo_area',
6597 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6599 * indent.c (Fvertical_motion):
6600 * window.c (window_scroll_pixel_based, Frecenter):
6601 Don't pass `need_y_p' to `move_it_by_lines'.
6603 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6605 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6606 steal a few bits to be more compact.
6607 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6608 Remove unneeded casts.
6610 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6612 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6614 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6615 binding" message (bug#7967).
6617 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6619 Fix more problems found by GCC 4.6.0's static checks.
6621 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6622 Remove unused local var.
6624 * editfns.c (Fmessage_box): Remove unused local var.
6626 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6627 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6628 Omit unused local vars.
6629 * window.c (shrink_windows): Omit unused local var.
6630 * menu.c (digest_single_submenu): Omit unused local var.
6631 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6632 Omit unused local var.
6634 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6635 Don't assume string length fits in int.
6636 (keyremap_step, read_key_sequence): Use size_t for sizes.
6637 (read_key_sequence): Don't check last_real_key_start redundantly.
6639 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6640 instead of alloca (Bug#8344).
6642 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6643 (Fbacktrace_frame): Don't assume nframes fits in int.
6645 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6647 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6650 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6652 * cm.c (calccost): Turn while-do into do-while, for clarity.
6654 * keyboard.c (syms_of_keyboard): Use the same style as later
6655 in this function when indexing through an array. This also
6656 works around GCC bug 48267.
6658 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6660 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6662 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6663 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6665 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6666 This avoids undefined behavior on integer overflow, and is a bit
6667 more convenient anyway since it is compared to a size_t variable.
6669 Variadic C functions now count arguments with size_t, not int.
6670 This avoids an unnecessary limitation on 64-bit machines, which
6671 caused (substring ...) to crash on large vectors (Bug#8344).
6672 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6673 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6674 All variadic functions and their callers changed accordingly.
6675 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6676 * data.c (arith_driver, float_arith_driver): Likewise.
6677 * editfns.c (general_insert_function): Likewise.
6678 * eval.c (struct backtrace.nargs, interactive_p)
6679 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6680 (funcall_lambda, mark_backtrace): Likewise.
6681 * fns.c (concat): Likewise.
6682 * frame.c (x_set_frame_parameters): Likewise.
6683 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6684 0 if not found, not -1. All callers changed.
6686 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6687 (stack_copy_size): Now size_t, not int.
6688 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6690 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6692 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6693 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6694 All callers changed.
6696 * lisp.h (multibyte_char_to_unibyte):
6697 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6698 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6699 * character.h (CHAR_TO_BYTE8):
6700 * cmds.c (internal_self_insert):
6701 * editfns.c (general_insert_function):
6702 * keymap.c (push_key_description):
6703 * search.c (Freplace_match):
6704 * xdisp.c (message_dolog, set_message_1): All callers changed.
6706 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6708 * keyboard.c (safe_run_hook_funcall): New function.
6709 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6710 don't set the hook to nil, but remove the offending function instead.
6711 (Qcommand_hook_internal): Remove, unused.
6712 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6713 Vcommand_hook_internal.
6715 * eval.c (enum run_hooks_condition): Remove.
6716 (funcall_nil, funcall_not): New functions.
6717 (run_hook_with_args): Call each function through a `funcall' argument.
6718 Remove `cond' argument, now redundant.
6719 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6720 (Frun_hook_with_args_until_failure): Adjust accordingly.
6721 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6723 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6725 * dispextern.h (string_buffer_position): Remove declaration.
6727 * print.c (strout): Remove parameter `multibyte', unused since
6728 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6730 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6731 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6732 All callers changed.
6734 * w32.c (_wsa_errlist): Use braces for struct initializers.
6736 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6737 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6738 All callers changed.
6739 (string_buffer_position): Likewise. Also, make static (it's never
6740 used outside xdisp.c).
6741 (cursor_row_p): Remove parameter `w', unused since
6742 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6743 (decode_mode_spec): Remove parameter `precision', introduced during
6744 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6745 All callers changed.
6747 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6749 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6751 2011-03-27 Anders Lindgren <andlind@gmail.com>
6753 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6754 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6755 (ns_update_auto_hide_menu_bar): New functions.
6756 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6757 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6758 ns_constrain_all_frames.
6759 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6760 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6762 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6764 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6766 2011-03-27 Glenn Morris <rgm@gnu.org>
6768 * syssignal.h: Replace RETSIGTYPE with void.
6769 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6770 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6771 Replace SIGTYPE with void everywhere.
6772 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6773 * s/template.h (SIGTYPE): Remove commented out definition.
6775 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6777 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6778 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6780 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6782 * w32.c (read_unc_volume): Use parameter `henum', instead of
6783 global variable `wget_enum_handle'.
6785 * keymap.c (describe_vector): Remove parameters `indices' and
6786 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6787 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6789 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6791 * keyboard.c (timer_check): Remove parameter `do_it_now',
6792 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6793 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6794 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6796 * keyboard.c (read_char):
6797 * w32menu.c (w32_menu_display_help):
6798 * xmenu.c (show_help_event, menu_help_callback):
6799 Adjust calls to `show_help_echo'.
6801 * gtkutil.c (xg_maybe_add_timer):
6802 * keyboard.c (readable_events):
6803 * process.c (wait_reading_process_output):
6804 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6806 * insdel.c (adjust_markers_gap_motion):
6807 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6808 (gap_left, gap_right): Don't call it.
6810 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6812 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6813 incurred during fontification.
6815 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6817 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6818 (DEFVAR_PER_BUFFER): Don't pass it.
6820 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6821 (scrolling_window): Don't pass it.
6823 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6825 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6827 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6829 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6830 of variables specific to SELinux and computation of `encoded_absname'.
6832 * image.c (XPutPixel): Remove unused variable `height'.
6834 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6836 * unexw32.c (get_section_info): Remove unused variable `section'.
6838 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6839 (system_process_attributes): Remove unused variable `sess'.
6840 (sys_read): Remove unused variable `err'.
6842 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6843 (w32_wnd_proc): Remove unused variable `isdead'.
6844 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6845 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6846 (x_create_tip_frame): Remove unused variable `tem'.
6848 * w32inevt.c (w32_console_read_socket):
6849 Remove unused variable `no_events'.
6851 * w32term.c (x_draw_composite_glyph_string_foreground):
6852 Remove unused variable `width'.
6854 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6856 * w32term.c (x_set_glyph_string_clipping):
6857 Don't pass uninitialized region to CombineRgn.
6859 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6861 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6862 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6863 (Fx_close_connection): Remove unused variable `i'.
6865 * w32font.c (w32font_draw): Return number of glyphs.
6866 (w32font_open_internal): Remove unused variable `i'.
6867 (w32font_driver): Add missing initializer.
6869 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6870 (fill_in_menu): Remove unused variable `items_added'.
6872 * w32term.c (last_mouse_press_frame): Remove static global variable.
6873 (w32_clip_to_row): Remove unused variable `f'.
6874 (x_delete_terminal): Remove unused variable `i'.
6876 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6877 (NOTHING): Remove unused static global variable.
6878 (uniscribe_check_otf): Remove unused variable `table'.
6879 (uniscribe_font_driver): Add missing initializers.
6881 2011-03-23 Julien Danjou <julien@danjou.info>
6883 * term.c (Fsuspend_tty, Fresume_tty):
6884 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6885 * window.c (temp_output_buffer_show):
6886 * insdel.c (signal_before_change):
6887 * frame.c (Fhandle_switch_frame):
6888 * fileio.c (Fdo_auto_save):
6889 * emacs.c (Fkill_emacs):
6890 * editfns.c (save_excursion_restore):
6891 * cmds.c (internal_self_insert):
6892 * callint.c (Fcall_interactively):
6893 * buffer.c (Fkill_all_local_variables):
6894 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6896 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6897 unconditionnaly since it does the check itself.
6899 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6901 Fix more problems found by GCC 4.5.2's static checks.
6903 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6904 the first time through the loop, since we know p0 < p1 then.
6905 This also avoids a gcc -Wstrict-overflow warning.
6907 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6908 leading to a memory leak, possible in functions like
6909 load_charset_map_from_file that can allocate an unbounded number
6910 of objects (Bug#8318).
6912 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6913 that could (at least in theory) be that large.
6915 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6916 This is less likely to overflow, and avoids undefined behavior if
6917 overflow does occur. All callers changed. Use strtoul to scan
6918 for the unsigned long integer.
6919 (pint2hrstr): Simplify and tune code slightly.
6920 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6922 * scroll.c (do_scrolling): Work around GCC bug 48228.
6923 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6925 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6926 This also avoids a warning with gcc -Wstrict-overflow.
6927 (validate_x_resource_name): Simplify count usage.
6928 This also avoids a warning with gcc -Wstrict-overflow.
6930 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6933 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6935 * process.c (Fmake_network_process): Use socklen_t, not int,
6936 where POSIX says socklen_t is required in portable programs.
6937 This fixes a porting bug on hosts like 64-bit HP-UX, where
6938 socklen_t is wider than int (Bug#8277).
6939 (Fmake_network_process, server_accept_connection):
6940 (wait_reading_process_output, read_process_output):
6943 * process.c: Rename or move locals to avoid shadowing.
6944 (list_processes_1, Fmake_network_process):
6945 (read_process_output_error_handler, exec_sentinel_error_handler):
6946 Rename or move locals.
6947 (Fmake_network_process): Define label "retry_connect" only if needed.
6948 (Fnetwork_interface_info): Fix pointer signedness.
6949 (process_send_signal): Add cast to avoid pointer signedness problem.
6950 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6951 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6953 Make tparam.h and terminfo.c consistent.
6954 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6955 Include tparam.h instead, since it declares them.
6956 * cm.h (PC): Remove extern decl; tparam.h now does this.
6957 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6958 * terminfo.c: Include tparam.h, to check interfaces.
6959 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6960 (tparam): Adjust signature to match interface in tparam.h;
6961 this removes some undefined behavior. Check that outstring and len
6962 are zero, which they always are with Emacs.
6963 * tparam.h (PC, BC, UP): New extern decls.
6965 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6966 (xftfont_open): Rename locals to avoid shadowing.
6968 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6969 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6970 (OTF_TAG_SYM): Omit macro if not needed.
6971 (ftfont_list): Remove unused local.
6972 (get_adstyle_property, ftfont_pattern_entity):
6973 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6974 Rename locals to avoid shadowing.
6976 * xfont.c (xfont_list_family): Mark var as initialized.
6978 * xml.c (make_dom): Now static.
6980 * composite.c (composition_compute_stop_pos): Rename local to
6982 (composition_reseat_it): Remove unused locals.
6983 (find_automatic_composition, composition_adjust_point): Likewise.
6984 (composition_update_it): Mark var as initialized.
6985 (find_automatic_composition): Mark vars as initialized,
6986 with a FIXME (Bug#8290).
6988 character.h: Rename locals to avoid shadowing.
6989 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6990 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6991 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6992 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6995 * textprop.c (property_change_between_p): Remove; unused.
6997 * intervals.c (interval_start_pos): Now static.
6999 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7001 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7002 Rename locals to avoid shadowing.
7004 * sound.c (wav_play, au_play, Fplay_sound_internal):
7005 Fix pointer signedness.
7006 (alsa_choose_format): Remove unused local var.
7007 (wav_play): Initialize a variable to 0, to prevent undefined
7008 behavior (Bug#8278).
7010 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7012 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7014 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7015 clobbering (Bug#8298).
7016 * sysdep.c (sys_subshell): Likewise.
7017 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7019 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7020 This should get cleaned up, so that child_setup has the
7021 same signature on all platforms.
7023 * callproc.c (call_process_cleanup): Now static.
7024 (relocate_fd): Rename locals to avoid shadowing.
7026 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
7028 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7029 not to be necessary, and produces flickering.
7031 2011-03-20 Glenn Morris <rgm@gnu.org>
7033 * config.in: Remove file.
7035 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
7037 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7038 are now in src/globals.h.
7039 (syms_of_minibuf): Remove spurious & from previous change.
7041 2011-03-20 Leo <sdl.web@gmail.com>
7043 * minibuf.c (completing-read-function): New variable.
7044 (completing-read-default): Rename from completing-read.
7045 (completing-read): Call completing-read-function.
7047 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7049 * xfaces.c (Fx_load_color_file):
7050 Read color file from absolute filename (bug#8250).
7052 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7054 * makefile.w32-in: Update dependencies.
7056 2011-03-17 Eli Zaretskii <eliz@gnu.org>
7058 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7060 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7062 Fix more problems found by GCC 4.5.2's static checks.
7064 * process.c (make_serial_process_unwind, send_process_trap):
7065 (sigchld_handler): Now static.
7067 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7068 That way, the code declares only the vars that it needs.
7069 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7070 * s/cygwin.h (PTY_ITERATION): Likewise.
7071 * s/darwin.h (PTY_ITERATION): Likewise.
7072 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7074 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7075 * process.c (allocate_pty): Don't declare stb unless it's needed.
7077 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
7078 (CONSTANTLIM): Remove; unused.
7079 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7080 Define only if needed.
7082 * unexelf.c (unexec): Name an expression,
7083 to avoid gcc -Wbad-function-cast warning.
7084 Use a different way to cause a compilation error if anyone uses
7085 n rather than nn, a way that does not involve shadowing.
7086 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
7088 * deps.mk (unexalpha.o): Remove; unused.
7090 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7091 * unexec.h: New file.
7092 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7093 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7095 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7096 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7097 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
7098 Change as necessary to match prototype in unexec.h.
7100 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7102 (back_comment, skip_chars): Mark vars as initialized.
7104 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7105 Rename locals to avoid shadowing.
7107 * lread.c (read1): Rewrite so as not to use empty "else".
7108 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
7110 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7112 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7113 warning when compiling print.c.
7115 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7116 instead of using an uninitialized var.
7117 (font_sort_entities): Mark var as initialized.
7119 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7121 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7122 pointers to constants.
7123 (font_parse_fcname): Remove unused vars.
7124 (font_delete_unmatched): Now static.
7125 (font_get_spec): Remove; unused.
7126 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7127 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7128 Rename or move locals to avoid shadowing.
7130 * fns.c (require_nesting_list, require_unwind): Now static.
7131 (Ffillarray): Rename locals to avoid shadowing.
7133 * floatfns.c (domain_error2): Define only if needed.
7134 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
7136 * alloc.c (mark_backtrace): Move decl from here ...
7137 * lisp.h: ... to here, so that it can be checked.
7139 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
7140 (Fdefvar): Rewrite so as not to use empty "else".
7141 (lisp_indirect_variable): Name an expression,
7142 to avoid gcc -Wbad-function-cast warning.
7143 (Fdefvar): Rename locals to avoid shadowing.
7145 * callint.c (quotify_arg, quotify_args): Now static.
7146 (Fcall_interactively): Rename locals to avoid shadowing.
7147 Use const pointer when appropriate.
7149 * lisp.h (get_system_name, get_operating_system_release):
7150 Move decls here, to check interfaces.
7151 * process.c (get_operating_system_release): Move decl to lisp.h.
7152 * xrdb.c (get_system_name): Likewise.
7153 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7154 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7155 some of which prompt warnings from gcc -Wbad-function-cast.
7156 (Fformat_time_string, Fencode_time, Finsert_char):
7157 (Ftranslate_region_internal, Fformat):
7158 Rename or remove local vars to avoid shadowing.
7159 (Ftranslate_region_internal): Mark var as initialized.
7161 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7164 * lisp.h (eassert): Check that the argument compiles, even if
7165 ENABLE_CHECKING is not defined.
7167 * data.c (Findirect_variable): Name an expression, to avoid
7168 gcc -Wbad-function-cast warning.
7169 (default_value, arithcompare, arith_driver, arith_error): Now static.
7170 (store_symval_forwarding): Rename local to avoid shadowing.
7171 (Fmake_variable_buffer_local, Fmake_local_variable):
7172 Mark variables as initialized.
7173 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
7175 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
7176 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7177 Rename locals to avoid shadowing.
7178 (mark_stack): Move local variables into the #ifdef region where
7180 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7181 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7183 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7184 (GC_STRING_CHARS): Remove; not used.
7185 (Fmemory_limit): Cast sbrk's returned value to char *.
7187 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7188 avoids undefined behavior in theory.
7190 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7192 Use functions, not macros, for up- and down-casing (Bug#8254).
7193 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7194 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7195 to use the following functions instead of these macros.
7196 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7197 EMACS_INT, since callers assume the returned value fits in int.
7198 (upcase1): Likewise, for UPCASE_TABLE.
7199 (uppercasep, lowercasep, upcase): New static inline functions.
7200 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
7201 the race-condition problem in the old DOWNCASE.
7203 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7204 Rename locals to avoid shadowing.
7205 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
7206 (regex_compile, re_search_2, re_match_2_internal):
7207 Remove unused local vars.
7208 (FREE_VAR): Rewrite so as not to use empty "else",
7209 which gcc can warn about.
7210 (regex_compile, re_match_2_internal): Mark locals as initialized.
7211 (RETALLOC_IF): Define only if needed.
7212 (WORDCHAR_P): Likewise. This one is never needed, but is used
7213 only in a comment talking about a compiler bug, so put inside
7214 the #if 0 of that comment.
7215 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7216 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7219 * search.c (boyer_moore): Rename locals to avoid shadowing.
7220 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7221 (PREV_CHAR_BOUNDARY): Likewise.
7223 * search.c (simple_search): Remove unused var.
7225 * dired.c (compile_pattern): Move decl from here ...
7226 * lisp.h: ... to here, so that it can be checked.
7227 (struct re_registers): New forward decl.
7229 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7231 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7233 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7234 Rename locals to avoid shadowing.
7235 (Fvertical_motion): Mark locals as initialized.
7237 * casefiddle.c (casify_object, casify_region): Now static.
7238 (casify_region): Mark local as initialized.
7240 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7242 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7243 New macros, so that the caller can use some names other than
7244 gcpro1, gcpro2, etc.
7245 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7247 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7248 argument, for consistency with GCPRO2_VAR, etc: it is now the
7249 prefix of the variable, not the variable itself. All uses
7251 * dired.c (directory_files_internal, file_name_completion):
7252 Rename locals to avoid shadowing.
7254 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7255 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7256 dired.c's scmp function, had undefined behavior.
7257 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7258 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7259 * buffer.h: ... to here, because these macros use current_buffer,
7260 and the new implementation with inline functions needs to have
7261 current_buffer in scope now, rather than later when the macros
7263 (downcase, upcase1): New static inline functions.
7264 (DOWNCASE, UPCASE1): Reimplement using these functions.
7265 This avoids undefined behavior in expressions like
7266 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7267 from race conditions in accessing the global variables
7268 case_temp1 and case_temp2.
7269 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7270 * lisp.h (case_temp1, case_temp2): Remove their decls.
7271 * character.h (ASCII_CHAR_P): Move from here ...
7272 * lisp.h: ... to here, so that the inline functions mentioned
7275 * dired.c (directory_files_internal_unwind): Now static.
7277 * fileio.c (file_name_as_directory, directory_file_name):
7278 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7280 (file_name_as_directory): Use const pointers when appropriate.
7281 (Fexpand_file_name): Likewise. In particular, newdir might
7282 point at constant storage, so make it a const pointer.
7283 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7284 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7286 (Fset_file_times, Finsert_file_contents, auto_save_error):
7287 Rename locals to avoid shadowing.
7289 * minibuf.c (choose_minibuf_frame_1): Now static.
7290 (Ftry_completion, Fall_completions): Rename or remove locals
7293 * marker.c (bytepos_to_charpos): Remove; unused.
7295 * lisp.h (verify_bytepos, count_markers): New decls,
7296 so that gcc does not warn that these functions aren't declared.
7298 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7299 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
7300 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
7301 (copy_text): Remove unused local var.
7303 * filelock.c (within_one_second): Now static.
7304 (lock_file_1): Rename local to avoid shadowing.
7306 * buffer.c (fix_overlays_before): Mark locals as initialized.
7307 (fix_start_end_in_overlays): Likewise. This function should be
7308 simplified by using pointers-to-pointers, but that's a different
7310 (switch_to_buffer_1): Now static.
7311 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7312 (report_overlay_modification): Rename locals to avoid shadowing.
7314 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7315 Fix pointer signedness issue.
7316 (sys_subshell): Mark local as volatile if checking for lint,
7317 to suppress a gcc -Wclobbered warning that does not seem to be right.
7318 (MAXPATHLEN): Define only if needed.
7320 * process.c (serial_open, serial_configure): Move decls from here ...
7321 * systty.h: ... to here, so that they can be checked.
7323 * fns.c (get_random, seed_random): Move extern decls from here ...
7324 * lisp.h: ... to here, so that they can be checked.
7326 * sysdep.c (reset_io): Now static.
7327 (wait_for_termination_signal): Remove; unused.
7329 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7330 (copy_keymap_item, append_key, push_text_char_description):
7332 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7333 (DENSE_TABLE_SIZE): Remove; unused.
7334 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7335 (describe_map_tree):
7336 Rename locals to avoid shadowing.
7338 * keyboard.c: Declare functions static if they are not used elsewhere.
7339 (echo_char, echo_dash, cmd_error, top_level_2):
7340 (poll_for_input, handle_async_input): Now static.
7341 (read_char, kbd_buffer_get_event, make_lispy_position):
7342 (make_lispy_event, make_lispy_movement, apply_modifiers):
7343 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7344 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7345 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7346 (read_key_sequence, read_char): Mark locals as initialized.
7347 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7349 * keyboard.h (make_ctrl_char): New decl.
7350 (mark_kboards): Move decl here ...
7351 * alloc.c (mark_kboards): ... from here.
7353 * lisp.h (force_auto_save_soon): New decl.
7355 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7356 (DEFINE_DUMMY_FUNCTION): New macro.
7357 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7359 (main): Add casts to avoid warnings
7360 if GCC considers string literals to be constants.
7362 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7364 * dbusbind.c: Pointer signedness fixes.
7365 (xd_signature, xd_append_arg, xd_initialize):
7366 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7367 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7368 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7369 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7371 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7372 if GCC considers string literals to be constants.
7373 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7375 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7377 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7378 (print_preprocess, print_object): New macro to fix last change.
7380 * print.c (print_preprocess): Don't forget font objects.
7382 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7384 * emacs.c (USAGE3): Doc fixes.
7386 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7388 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7391 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7393 * lisp.h (VWindow_system, Qfile_name_history):
7394 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7395 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7396 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7398 * w32select.c: Don't #include "keyboard.h".
7399 (run_protected): Add extern declaration for waiting_for_input.
7401 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7402 * w32console.c (detect_input_pending, read_input_pending)
7403 (encode_terminal_code):
7404 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7405 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7406 (w32_system_caret_y, Qfile_name_history):
7407 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7408 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7409 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7410 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7411 * w32proc.c (Qlocal, report_file_error):
7412 * w32term.c (Vwindow_system, updating_frame):
7413 * w32uniscribe.c (initialized, uniscribe_font_driver):
7414 Remove unneeded extern declarations.
7416 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7418 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7420 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7422 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7423 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7424 These macros can no longer be used for assignment.
7426 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7427 Assign struct members directly, instead of using BUF_BEGV etc.
7428 (record_buffer_markers, fetch_buffer_markers): New functions for
7429 recording and fetching special buffer markers.
7430 (set_buffer_internal_1, set_buffer_temp): Use them.
7432 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7434 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7436 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7437 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7439 * xdisp.c (hscroll_window_tree):
7440 (reconsider_clip_changes): Use PT instead of BUF_PT.
7442 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7444 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7445 $(EMACS_ROOT)/lib/intprops.h.
7447 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7449 Fix more problems found by GCC 4.5.2's static checks.
7451 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7452 to unsigned char * to avoid compiler diagnostic.
7453 (xg_free_frame_widgets): Make it clear that a local variable is
7454 needed only if USE_GTK_TOOLTIP.
7455 (gdk_window_get_screen): Make it clear that this macro is needed
7456 only if USE_GTK_TOOLTIP.
7457 (int_gtk_range_get_value): New function, which avoids a diagnostic
7458 from gcc -Wbad-function-cast.
7459 (xg_set_toolkit_scroll_bar_thumb): Use it.
7460 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7461 diagnostic from gcc -Wbad-function-cast.
7462 (get_utf8_string, xg_get_file_with_chooser):
7463 Rename locals to avoid shadowing.
7464 (create_dialog): Move locals to avoid shadowing.
7466 * xgselect.c (xg_select): Remove unused var.
7468 * image.c (four_corners_best): Mark locals as initialized.
7469 (gif_load): Initialize transparent_p to zero (Bug#8238).
7470 Mark another local as initialized.
7471 (my_png_error, my_error_exit): Mark with NO_RETURN.
7473 * image.c (clear_image_cache): Now static.
7474 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7475 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7476 (x_edge_detection): Remove unnecessary cast that
7477 gcc -Wbad-function-cast diagnoses.
7478 (gif_load): Fix pointer signedness.
7479 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7480 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7482 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7484 Improve quality of tests for time stamp overflow.
7485 For example, without this patch (encode-time 0 0 0 1 1
7486 1152921504606846976) returns the obviously-bogus value (-948597
7487 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7488 reports time overflow. See
7489 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7490 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7491 * editfns.c: Include limits.h and intprops.h.
7492 (TIME_T_MIN, TIME_T_MAX): New macros.
7493 (time_overflow): Move earlier, to before first use.
7494 (hi_time, lo_time): New functions, for an accurate test for
7496 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7497 (Fget_internal_run_time): Don't assume time_t fits in int.
7498 (make_time): Use list2 instead of Fcons twice.
7499 (Fdecode_time): More accurate test for out-of-range times.
7500 (check_tm_member): New function.
7501 (Fencode_time): Use it, to test for out-of-range times.
7502 (lisp_time_argument): Don't rely on undefined left-shift and
7503 right-shift behavior when checking for time stamp overflow.
7505 * editfns.c (time_overflow): New function, refactoring common code.
7506 (Fformat_time_string, Fdecode_time, Fencode_time):
7507 (Fcurrent_time_string): Use it.
7509 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7510 * dired.c (make_time): Move to ...
7511 * editfns.c (make_time): ... here.
7512 * systime.h: Note the move.
7514 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7516 * fringe.c (update_window_fringes): Remove unused variables.
7518 * unexmacosx.c (copy_data_segment): Also copy __got section.
7521 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7523 * termcap.c [MSDOS]: Include "msdos.h".
7524 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7525 Constify `char *' arguments and their references according to
7526 prototypes in tparam.h.
7528 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7530 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7531 Adapt all references accordingly.
7533 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7535 2011-03-11 Tom Tromey <tromey@redhat.com>
7537 * buffer.c (syms_of_buffer): Remove obsolete comment.
7539 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7541 * termhooks.h (encode_terminal_code): Declare prototype.
7543 * msdos.c (encode_terminal_code): Don't declare prototype.
7545 * term.c (encode_terminal_code): Now external again, used by
7546 w32console.c and msdos.c.
7548 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7549 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7551 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7553 Fix some minor problems found by GCC 4.5.2's static checks.
7555 * fringe.c (update_window_fringes): Mark locals as initialized
7557 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7559 * alloc.c (mark_fringe_data): Move decl from here ...
7560 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7561 to check its interface.
7562 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7564 * fontset.c (free_realized_fontset): Now static.
7565 (Fset_fontset_font): Rename local to avoid shadowing.
7566 (fontset_font): Mark local as initialized.
7567 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7569 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7571 * xselect.c (x_disown_buffer_selections): Remove; not used.
7572 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7573 (x_own_selection, Fx_disown_selection_internal): Rename locals
7575 (x_handle_dnd_message): Remove local to avoid shadowing.
7577 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7578 so that the caller can use some name other than gcpro1.
7579 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7580 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7581 (Fx_backspace_delete_keys_p):
7582 Use them to avoid shadowing, and rename vars to avoid shadowing.
7583 (x_decode_color, x_set_name, x_window): Now static.
7584 (Fx_create_frame): Add braces to silence GCC warning.
7585 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7586 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7587 Remove unused locals.
7588 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7589 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7590 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7593 * xterm.h (x_mouse_leave): New decl.
7595 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7596 Remove unused functions.
7597 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7598 (x_calc_absolute_position): Now static.
7599 (XTread_socket): Don't define label "out" unless it's used.
7600 Don't declare local "event" unless it's used.
7601 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7602 unless they are used.
7603 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7604 (x_fatal_error_signal): Remove; not used.
7605 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7606 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7607 (x_error_catcher, x_connection_closed, x_error_handler):
7608 (x_error_quitter, xembed_send_message, x_iconify_frame):
7609 (my_log_handler): Rename locals to avoid shadowing.
7610 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7611 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7613 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7614 Rename or move locals to avoid shadowing.
7615 (tty_defined_color, merge_face_heights): Now static.
7616 (free_realized_faces_for_fontset): Remove; not used.
7617 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7618 does not deduce is never used uninitialized.
7619 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7620 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7622 * terminal.c (store_terminal_param): Now static.
7624 * xmenu.c (menu_highlight_callback): Now static.
7625 (set_frame_menubar): Remove unused local.
7626 (xmenu_show): Rename parameter to avoid shadowing.
7627 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7628 since they might point to immutable storage.
7629 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7630 since it's unused otherwise.
7632 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7633 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7634 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7635 avoids a gcc -Wuninitialized diagnostic.
7636 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7637 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7638 does not deduce are never used uninitialized.
7640 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7642 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7643 * window.c (window_loop, size_window):
7644 (run_window_configuration_change_hook, enlarge_window): Likewise.
7646 * window.c (display_buffer): Now static.
7647 (size_window): Mark variables that gcc -Wuninitialized
7648 does not deduce are never used uninitialized.
7649 * window.h (check_all_windows): New decl, to forestall
7650 gcc -Wmissing-prototypes diagnostic.
7651 * dispextern.h (bidi_dump_cached_states): Likewise.
7653 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7655 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7657 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7658 and to avoid gcc -Wuninitialized warning.
7659 (load_charset_map): Mark variables that gcc -Wuninitialized
7660 does not deduce are never used uninitialized.
7661 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7663 * coding.c (coding_set_source, coding_set_destination):
7664 Use "else { /* comment */ }" rather than "else /* comment */;"
7665 for clarity, and to avoid gcc -Wempty-body warning.
7666 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7667 a block, when the outer 'i' will do.
7668 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7669 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7670 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7671 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7672 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7673 Rename locals to avoid shadowing.
7674 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7675 * coding.c (emacs_mule_char, encode_invocation_designation):
7676 Now static, since they're not used elsewhere.
7677 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7678 (decode_coding_object, encode_coding_object, detect_coding_system):
7679 (decode_coding_emacs_mule): Mark variables that gcc
7680 -Wuninitialized does not deduce are never used uninitialized.
7681 (detect_coding_iso_2022): Initialize a local variable that might
7682 be used uninitialized. Leave a FIXME because it's not clear that
7683 this initialization is needed. (Bug#8211)
7684 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7685 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7686 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7687 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7688 Remove unused macros.
7690 * category.c (hash_get_category_set): Remove unused local var.
7691 (copy_category_table): Now static, since it's not used elsewhere.
7692 * character.c (string_count_byte8): Likewise.
7694 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7695 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7697 * chartab.c (copy_sub_char_table): Now static, since it's not used
7699 (sub_char_table_ref_and_range, char_table_ref_and_range):
7700 Rename locals to avoid shadowing.
7701 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7703 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7704 (BIDI_BOB): Remove unused macro.
7706 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7707 deduce are never used uninitialized.
7708 * term.c (encode_terminal_code): Likewise.
7710 * term.c (encode_terminal_code): Now static. Remove unused local.
7712 * tparam.h: New file.
7713 * term.c, tparam.h: Include it.
7714 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7715 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7716 Move these decls to tparam.h, and make them agree with what
7717 is actually in tparam.c. The previous trick of using incompatible
7718 decls in different modules does not conform to the C standard.
7719 All callers of tparam changed to use tparam's actual API.
7720 * tparam.c (tparam1, tparam, tgoto):
7721 Use const pointers where appropriate.
7723 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7724 * cm.h (struct cm): Likewise.
7725 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7726 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7727 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7728 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7729 (turn_on_face, init_tty): Likewise.
7730 * termchar.h (struct tty_display_info): Likewise.
7732 * term.c (term_mouse_position): Rename local to avoid shadowing.
7734 * alloc.c (mark_ttys): Move decl from here ...
7735 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7737 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7739 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7741 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7743 * search.c (compile_pattern_1): Remove argument regp, unused since
7744 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7745 (compile_pattern): Don't pass it.
7747 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7749 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7750 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7752 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7754 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7756 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7757 gdk_window_get_screen, gdk_window_get_geometry,
7758 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7759 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7760 (xg_get_pixbuf_from_pixmap): New function.
7761 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7762 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7763 Call xg_get_pixbuf_from_pixmap instead of
7764 gdk_pixbuf_get_from_drawable.
7765 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7766 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7767 (xg_check_special_colors): Use GtkStyleContext and its functions
7769 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7770 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7771 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7772 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7773 Call gtk_widget_get_preferred_size.
7774 (xg_frame_resized): gdk_window_get_geometry only takes 5
7776 (xg_win_to_widget, xg_event_is_for_menubar):
7777 Call gdk_x11_window_lookup_for_display.
7778 (xg_set_widget_bg): New function.
7779 (delete_cb): New function.
7780 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7781 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7782 (xg_set_background_color): Call xg_set_widget_bg.
7783 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7784 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7785 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7786 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7788 (update_frame_tool_bar): Call gtk_widget_hide.
7789 (xg_initialize): Use GDK_KEY_g.
7791 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7793 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7795 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7796 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7797 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7799 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7801 * w32xfns.c (select_palette): Check success of RealizePalette against
7802 GDI_ERROR, not zero.
7804 See ChangeLog.11 for earlier changes.
7810 Copyright (C) 2011 Free Software Foundation, Inc.
7812 This file is part of GNU Emacs.
7814 GNU Emacs is free software: you can redistribute it and/or modify
7815 it under the terms of the GNU General Public License as published by
7816 the Free Software Foundation, either version 3 of the License, or
7817 (at your option) any later version.
7819 GNU Emacs is distributed in the hope that it will be useful,
7820 but WITHOUT ANY WARRANTY; without even the implied warranty of
7821 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7822 GNU General Public License for more details.
7824 You should have received a copy of the GNU General Public License
7825 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.