1 2011-06-14 Paul Eggert <eggert@cs.ucla.edu>
3 Variadic C functions now count arguments with ptrdiff_t.
4 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5 Back then I didn't know that the Emacs coding style prefers signed int.
6 Also, in the meantime I found a few more instances where arguments
7 were being counted with int, which may be too narrow, or EMACS_INT, which
9 * lisp.h (struct Lisp_Subr.function.aMANY)
10 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
11 Arg counts are now ptrdiff_t, not size_t.
12 All variadic functions and their callers changed accordingly.
13 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
14 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
15 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
16 * callint.c (Fcall_interactively): Check arg count for overflow,
17 to avoid potential buffer overrun. Use signed char, not 'int',
18 for 'varies' array, so that we needn't bother to check its size
19 calculation for overflow.
20 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
21 * eval.c (apply_lambda):
22 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
23 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
24 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
26 * callint.c (Fcall_interactively): Don't use index var as event count.
28 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
29 * mem-limits.h (SIZE): Remove; no longer used.
31 2011-06-13 Paul Eggert <eggert@cs.ucla.edu>
33 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
35 Remove unnecessary casts.
36 * xterm.c (x_term_init):
37 * xfns.c (x_set_border_pixel):
38 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
39 These aren't needed now that we assume ANSI C.
41 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
42 It's more likely to cause problems (due to unsigned overflow)
45 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
47 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
49 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
51 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
53 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
55 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
57 GLYPH_CODE_FACE returns EMACS_INT, not int.
58 * dispextern.h (merge_faces):
59 * xfaces.c (merge_faces):
60 * xdisp.c (get_next_display_element, next_element_from_display_vector):
61 Don't assume EMACS_INT fits in int.
63 * character.h (CHAR_VALID_P): Remove unused parameter.
64 * fontset.c, lisp.h, xdisp.c: All uses changed.
66 * editfns.c (Ftranslate_region_internal): Omit redundant test.
68 * fns.c (concat): Minor tuning based on overflow analysis.
69 This doesn't fix any bugs. Use int to hold character, instead
70 of constantly refetching from Emacs object. Use XFASTINT, not
71 XINT, for value known to be a character. Don't bother comparing
72 a single byte to 0400, as it's always less.
75 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
77 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
80 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
82 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
83 Without this fix, on a 64-bit host (aset S 0 4294967386) would
84 incorrectly succeed when S was a string, because 4294967386 was
85 truncated before it was used.
87 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
88 Otherwise, an out-of-range integer could cause undefined behavior
91 * composite.c: Use int, not EMACS_INT, for characters.
92 (fill_gstring_body, composition_compute_stop_pos): Use int, not
93 EMACS_INT, for values that are known to be in character range.
94 This doesn't fix any bugs but is the usual style inside Emacs and
95 may generate better code on 32-bit machines.
97 Make sure a 64-bit char is never passed to ENCODE_CHAR.
98 This is for reasons similar to the recent CHAR_STRING fix.
99 * charset.c (Fencode_char): Check that character arg is actually
100 a character. Pass an int to ENCODE_CHAR.
101 * charset.h (ENCODE_CHAR): Verify that the character argument is no
102 wider than 'int', as a compile-time check to prevent future regressions
105 * character.c (char_string): Remove unnecessary casts.
107 Make sure a 64-bit char is never passed to CHAR_STRING.
108 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
109 by silently ignoring the top 32 bits, allowing some values
110 that were far too large to be valid characters.
111 * character.h: Include <verify.h>.
112 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
113 arguments are no wider than unsigned, as a compile-time check
114 to prevent future regressions in this area.
116 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
117 (Fsubst_char_in_region):
119 * xdisp.c (decode_mode_spec_coding):
120 Adjust to CHAR_STRING's new requirement.
121 * editfns.c (Finsert_char, Fsubst_char_in_region):
122 * fns.c (concat): Check that character args are actually
123 characters. Without this test, these functions did the wrong
124 thing with wildly out-of-range values on 64-bit hosts.
126 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
127 These casts should not be needed on 32-bit hosts, either.
128 * keyboard.c (read_char):
129 * lread.c (Fload): Remove casts to unsigned.
131 * lisp.h (UNSIGNED_CMP): New macro.
132 This fixes comparison bugs on 64-bit hosts.
133 (ASCII_CHAR_P): Use it.
134 * casefiddle.c (casify_object):
135 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
136 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
137 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
138 * dispextern.h (FACE_FROM_ID):
139 * keyboard.c (read_char): Use UNSIGNED_CMP.
141 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
142 not to EMACS_INT, to avoid GCC warning.
144 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
146 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
147 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
148 isn't needed on 32-bit machines.
150 * buffer.c (Fgenerate_new_buffer_name):
151 Use EMACS_INT for count, not int.
152 (advance_to_char_boundary): Return EMACS_INT, not int.
154 * data.c (Qcompiled_function): Now static.
156 * window.c (window_body_lines): Now static.
158 * image.c (gif_load): Rename local to avoid shadowing.
160 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
161 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
162 * alloc.c (make_save_value): Integer argument is now of type
164 (mark_object): Use ptrdiff_t, not int.
165 * lisp.h (pD): New macro.
166 * print.c (print_object): Use it.
168 * alloc.c: Use EMACS_INT, not int, to count objects.
169 (total_conses, total_markers, total_symbols, total_vector_size)
170 (total_free_conses, total_free_markers, total_free_symbols)
171 (total_free_floats, total_floats, total_free_intervals)
172 (total_intervals, total_strings, total_free_strings):
173 Now EMACS_INT, not int. All uses changed.
174 (Fgarbage_collect): Compute overall total using a double, so that
175 integer overflow is less likely to be a problem. Check for overflow
176 when converting back to an integer.
177 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
178 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
179 These were 'int' variables that could overflow on 64-bit hosts;
180 they were never used, so remove them instead of repairing them.
181 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
182 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
183 Previously, this ceilinged at INT_MAX, but that doesn't work on
185 (allocate_pseudovector): Don't use EMACS_INT when int would do.
187 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
188 (allocate_vectorlike): Check for ptrdiff_t overflow.
189 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
190 when a (possibly-narrower) signed value would do just as well.
191 We prefer using signed arithmetic, to avoid comparison confusion.
193 * alloc.c: Catch some string size overflows that we were missing.
194 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
195 for convenience in STRING_BYTES_MAX.
196 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
197 The definition here is exact; the one in lisp.h was approximate.
198 (allocate_string_data): Check for string overflow. This catches
199 some instances we weren't catching before. Also, it catches
200 size_t overflow on (unusual) hosts where SIZE_MAX <= min
201 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
202 and ptrdiff_t and EMACS_INT are both 64 bits.
204 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
205 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
206 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
208 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
210 * alloc.c (Fmake_string): Check for out-of-range init.
212 2011-06-12 Martin Rudalics <rudalics@gmx.at>
214 * frame.c (make_frame): Call other_buffer_safely instead of
217 * window.c (temp_output_buffer_show): Call display_buffer with
218 second argument Vtemp_buffer_show_specifiers and reset latter
219 immediately after the call.
220 (Vtemp_buffer_show_specifiers): New variable.
221 (auto_window_vscroll_p, next_screen_context_lines)
222 (Vscroll_preserve_screen_position): Remove leading asterisks from
225 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
227 Fix minor problems found by GCC 4.6.0 static checking.
228 * buffer.c (Qclone_number): Remove for now, as it's unused.
229 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
230 (record_buffer): Remove unused local.
231 * frame.c (other_visible_frames, frame_buffer_list): Now static.
232 (set_frame_buffer_list): Remove; unused.
233 * frame.h (other_visible_frames): Remove decl.
234 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
235 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
236 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
238 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
239 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
240 Define only if HAVE_GPM.
241 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
242 (update_hints_inhibit): Remove; never set. All uses removed.
243 * widgetprv.h (emacsFrameClassRec): Remove decl.
244 * window.c (delete_deletable_window): Now returns void, since it
245 wasn't returning anything.
246 (compare_window_configurations): Remove unused locals.
247 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
248 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
249 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
250 the same widths as pointers. This follows up on the 2011-05-06 patch.
251 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
253 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
255 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
257 * makefile.w32-in: Update dependencies.
258 (LISP_H): Add lib/intprops.h.
260 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
262 * image.c (gif_load): Add animation frame delay to the metadata.
263 (syms_of_image): Use DEFSYM. New symbol `delay'.
265 2011-06-11 Martin Rudalics <rudalics@gmx.at>
267 * window.c (delete_deletable_window): Re-add.
268 (Fset_window_configuration): Rewrite to handle dead buffers and
269 consequently deletable windows.
270 (window_tree, Fwindow_tree): Remove. Supply functionality in
272 (compare_window_configurations): Simplify code.
274 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
276 * image.c (imagemagick_load_image): Fix type mismatch.
277 (Fimagemagick_types): Likewise.
279 * window.h (replace_buffer_in_windows): Declare.
281 2011-06-11 Martin Rudalics <rudalics@gmx.at>
283 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
284 Qclone_number. Remove external declaration of Qdelete_window.
285 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
287 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
288 Qbuffer_list_update_hook if allowed.
289 (Fother_buffer): Rewrite doc-string. Major rewrite for new
290 buffer list implementation.
291 (other_buffer_safely): New function.
292 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
293 calls to replace_buffer_in_windows and
294 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
296 (record_buffer): Inhibit quitting and rewrite using quittable
297 functions. Run Qbuffer_list_update_hook if allowed.
298 (Frecord_buffer, Funrecord_buffer): New functions.
299 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
300 switch-to-buffer to window.el.
301 (bury-buffer): Move to window.el.
302 (Vbuffer_list_update_hook): New variable.
304 * lisp.h (other_buffer_safely): Add prototype in buffer.c
307 * window.h (resize_frame_windows): Move up in code.
308 (Fwindow_frame): Remove EXFUN.
309 (replace_buffer_in_all_windows): Remove prototype.
310 (replace_buffer_in_windows_safely): Add prototype.
312 * window.c: Declare Qdelete_window static again. Move down
313 declaration of select_count.
314 (Fnext_window, Fprevious_window): Rewrite doc-strings.
315 (Fother_window): Move to window.el.
316 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
317 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
318 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
320 (replace_buffer_in_windows): Implement by calling
321 Qreplace_buffer_in_windows.
322 (replace_buffer_in_all_windows): Remove with some functionality
323 moved into replace_buffer_in_windows_safely.
324 (replace_buffer_in_windows_safely): New function.
325 (select_window_norecord, select_frame_norecord): Move in front
326 of run_window_configuration_change_hook. Remove now obsolete
328 (Fset_window_buffer): Rewrite doc-string. Call
329 Qrecord_window_buffer.
330 (keys_of_window): Move binding for other-window to window.el.
332 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
334 * dispextern.h (struct image): Replace data member, whose int_val
335 and ptr_val fields were not used by anything, with a single
338 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
339 (gif_clear_image, gif_load, imagemagick_load_image)
340 (gs_clear_image, gs_load): Callers changed.
342 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
344 * buffer.h: Include <time.h>, for time_t.
345 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
347 Fix minor problems found by static checking.
349 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
351 Make identifiers static if they are not used in other modules.
352 * data.c (Qcompiled_function, Qframe, Qvector):
353 * image.c (QimageMagick, Qsvg):
354 * minibuf.c (Qmetadata):
355 * window.c (resize_window_check, resize_root_window): Now static.
356 * window.h (resize_window_check, resize_root_window): Remove decls.
358 * window.c (window_deletion_count, delete_deletable_window):
360 (window_body_lines): Now static.
361 (Fdelete_other_windows_internal): Mark vars as initialized.
362 Make sure 'resize_failed' is initialized.
363 (run_window_configuration_change_hook): Rename local to avoid shadowing.
364 (resize_window_apply): Remove unused local.
365 * window.h (delete_deletable_window): Remove decl.
367 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
368 (imagemagick_load_image): Fix pointer signedness problem by changing
369 last arg from unsigned char * to char *. All uses changed.
370 Also, fix a local for similar reasons.
371 Remove unused locals. Remove locals to avoid shadowing.
372 (fn_rsvg_handle_free): Remove; unused.
373 (svg_load, svg_load_image): Fix pointer signedness problem.
374 (imagemagick_load_image): Don't use garbage pointer image_wand.
376 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
378 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
380 * image.c (gif_load): Fix omitted cast error introduced by
383 2011-06-10 Martin Rudalics <rudalics@gmx.at>
385 * window.h (resize_proportionally, orig_total_lines)
386 (orig_top_line): Remove from window structure.
387 (set_window_height, set_window_width, change_window_heights)
388 (Fdelete_window): Remove prototypes.
389 (resize_frame_windows): Remove duplicate declaration.
391 2011-06-10 Eli Zaretskii <eliz@gnu.org>
393 * window.h (resize_frame_windows, resize_window_check)
394 (delete_deletable_window, resize_root_window)
395 (resize_frame_windows): Declare prototypes.
397 * window.c (resize_window_apply): Make definition be "static" to
400 2011-06-10 Martin Rudalics <rudalics@gmx.at>
402 * window.c: Remove declarations of Qwindow_size_fixed,
403 window_min_size_1, window_min_size_2, window_min_size,
404 size_window, window_fixed_size_p, enlarge_window, delete_window.
405 Remove static from declaration of Qdelete_window, it's
406 temporarily needed by Fbury_buffer.
407 (replace_window): Don't assign orig_top_line and
409 (Fdelete_window, delete_window): Remove. Window deletion is
410 handled by window.el.
411 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
412 Fdelete_window calls with calls to Qdelete_window.
413 (Fdelete_other_windows): Remove. Deleting other windows is
414 handled by window.el.
415 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
416 handled in window.el.
417 (window_min_size_2, window_min_size_1, window_min_size): Remove.
418 Window minimum sizes are handled in window.el.
419 (shrink_windows, size_window, set_window_height)
420 (set_window_width, change_window_heights, window_height)
421 (window_width, CURBEG, CURSIZE, enlarge_window)
422 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
423 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
424 handled in window.el.
425 (make_dummy_parent): Rename to make_parent_window and give it a
426 second argument horflag.
427 (make_window): Don't set resize_proportionally any more.
428 (Fsplit_window): Remove. Windows are split in window.el.
429 (save_restore_action, save_restore_orig_size)
430 (shrink_window_lowest_first, save_restore_orig_size): Remove.
431 Resize mini windows in window.el.
432 (grow_mini_window, shrink_mini_window): Implement by calling
433 Qresize_root_window_vertically, resize_window_check and
435 (saved_window, Fset_window_configuration, save_window_save): Do
436 not handle orig_top_line, orig_total_lines, and
437 resize_proportionally.
438 (window_min_height, window_min_width): Move to window.el.
439 (keys_of_window): Move bindings for delete-other-windows,
440 split-window, delete-window and enlarge-window to window.el.
442 * buffer.c: Temporarily extern Qdelete_window.
443 (Fbury_buffer): Temporarily call Qdelete_window instead of
444 Fdelete_window (Fbury_buffer will move to window.el soon).
446 * frame.c (set_menu_bar_lines_1): Remove code handling
447 orig_top_line and orig_total_lines.
449 * dispnew.c (adjust_frame_glyphs_initially): Don't use
450 set_window_height but set heights directly.
451 (change_frame_size_1): Use resize_frame_windows.
453 * xdisp.c (init_xdisp): Don't use set_window_height but set
456 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
457 resize_frame_windows instead of change_window_heights and run
458 run_window_configuration_change_hook.
460 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
461 instead of change_window_heights and run
462 run_window_configuration_change_hook.
464 2011-06-09 Martin Rudalics <rudalics@gmx.at>
466 * window.c (replace_window): Rename second argument REPLACEMENT to
467 NEW. New third argument SETFLAG. Rewrite.
468 (delete_window, make_dummy_parent): Call replace_window with
470 (window_list_1): Move down in code.
471 (run_window_configuration_change_hook): Move set_buffer part
472 before select_frame_norecord part in order to unwind correctly.
473 Rename count1 to count.
474 (recombine_windows, delete_deletable_window, resize_root_window)
475 (Fdelete_other_windows_internal)
476 (Frun_window_configuration_change_hook, make_parent_window)
477 (resize_window_check, resize_window_apply, Fresize_window_apply)
478 (resize_frame_windows, Fsplit_window_internal)
479 (Fdelete_window_internal, Fresize_mini_window_internal): New
481 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
483 2011-06-08 Martin Rudalics <rudalics@gmx.at>
485 * window.h (window): Add some new members to window structure -
486 normal_lines, normal_cols, new_total, new_normal, clone_number,
487 splits, nest, prev_buffers, next_buffers.
488 (WINDOW_TOTAL_SIZE): Move here from window.c.
489 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
491 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
493 (make_dummy_parent): Set new members of windows structure.
494 (make_window): Move down in code. Handle new members of window
496 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
497 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
498 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
499 (Fset_window_prev_buffers, Fwindow_next_buffers)
500 (Fset_window_next_buffers, Fset_window_clone_number): New
502 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
503 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
505 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
506 Argument WINDOW can be now internal window too.
507 (Fwindow_use_time): Move up in code.
508 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
510 (Fset_window_configuration, saved_window)
511 (Fcurrent_window_configuration, save_window_save): Handle new
512 members of window structure.
513 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
514 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
515 (syms_of_window): New Lisp objects Qrecord_window_buffer,
516 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
517 Qget_mru_window, Qresize_root_window,
518 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
519 Qauto_buffer_name; staticpro them.
521 2011-06-07 Martin Rudalics <rudalics@gmx.at>
523 * window.c (Fwindow_total_size, Fwindow_left_column)
524 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
525 (Fwindow_list_1): New functions.
526 (window_box_text_cols): Replace with window_body_cols.
527 (Fwindow_width, Fscroll_left, Fscroll_right): Use
528 window_body_cols instead of window_box_text_cols.
529 (delete_window, Fset_window_configuration): Call
530 delete_all_subwindows with window as argument.
531 (delete_all_subwindows): Take a window as argument and not a
533 (window_loop): Remove handling of GET_LRU_WINDOW and
535 (Fget_lru_window, Fget_largest_window): Move to window.el.
537 * window.h: Extern window_body_cols instead of
538 window_box_text_cols. delete_all_subwindows now takes a
539 Lisp_Object as argument.
541 * indent.c (compute_motion, Fcompute_motion): Use
542 window_body_cols instead of window_box_text_cols.
544 * frame.c (delete_frame): Call delete_all_subwindows with root
547 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
549 * fns.c (Fputhash): Document return value.
551 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
553 * image.c (gif_load): Implement gif89a spec "no disposal" method.
555 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
557 Cons<->int and similar integer overflow fixes (Bug#8794).
559 Check for overflow when converting integer to cons and back.
560 * charset.c (Fdefine_charset_internal, Fdecode_char):
561 Use cons_to_unsigned to catch overflow.
562 (Fencode_char): Use INTEGER_TO_CONS.
563 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
564 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
565 * data.c (long_to_cons, cons_to_long): Remove.
566 (cons_to_unsigned, cons_to_signed): New functions.
567 These signal an error for invalid or out-of-range values.
568 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
569 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
570 * font.c (Ffont_variation_glyphs):
571 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
572 * lisp.h: Include <intprops.h>.
573 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
574 (cons_to_signed, cons_to_unsigned): New decls.
575 (long_to_cons, cons_to_long): Remove decls.
576 * undo.c (record_first_change): Use INTEGER_TO_CONS.
577 (Fprimitive_undo): Use CONS_TO_INTEGER.
578 * xfns.c (Fx_window_property): Likewise.
579 * xselect.c: Include <limits.h>.
580 (x_own_selection, selection_data_to_lisp_data):
582 (x_handle_selection_request, x_handle_selection_clear)
583 (x_get_foreign_selection, Fx_disown_selection_internal)
584 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
585 (lisp_data_to_selection_data): Use cons_to_unsigned.
586 (x_fill_property_data): Use cons_to_signed.
587 Report values out of range.
589 Check for buffer and string overflow more precisely.
590 * buffer.h (BUF_BYTES_MAX): New macro.
591 * lisp.h (STRING_BYTES_MAX): New macro.
592 * alloc.c (Fmake_string):
593 * character.c (string_escape_byte8):
594 * coding.c (coding_alloc_by_realloc):
596 * editfns.c (Fformat):
598 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
599 since they may not be the same number.
600 * editfns.c (Finsert_char):
601 * fileio.c (Finsert_file_contents):
602 Likewise for BUF_BYTES_MAX.
604 * image.c: Use ptrdiff_t, not int, for sizes.
605 (slurp_file): Switch from int to ptrdiff_t.
607 (slurp_file): Check that file size fits in both size_t (for
608 malloc) and ptrdiff_t (for sanity and safety).
610 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
611 if b->modtime has its maximal value.
613 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
615 Don't assume time_t can fit into int.
616 * buffer.h (struct buffer.modtime): Now time_t, not int.
617 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
618 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
620 Minor fixes for signed vs unsigned integers.
621 * character.h (MAYBE_UNIFY_CHAR):
622 * charset.c (maybe_unify_char):
623 * keyboard.c (read_char, reorder_modifiers):
624 XINT -> XFASTINT, since the integer must be nonnegative.
625 * ftfont.c (ftfont_spec_pattern):
626 * keymap.c (access_keymap, silly_event_symbol_error):
627 XUINT -> XFASTINT, since the integer must be nonnegative.
628 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
629 since it makes no difference and we prefer signed.
630 * keyboard.c (record_char): Use XUINT when all the neighbors do.
631 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
634 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
636 * window.h (Fwindow_frame): Declare.
638 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
640 * alloc.c: Simplify handling of large-request failures (Bug#8800).
641 (SPARE_MEMORY): Always define.
642 (LARGE_REQUEST): Remove.
643 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
645 2011-06-06 Martin Rudalics <rudalics@gmx.at>
647 * lisp.h: Move EXFUNS for Fframe_root_window,
648 Fframe_first_window and Fset_frame_selected_window to window.h.
650 * window.h: Move EXFUNS for Fframe_root_window,
651 Fframe_first_window and Fset_frame_selected_window here from
654 * frame.c (Fwindow_frame, Fframe_first_window)
655 (Fframe_root_window, Fframe_selected_window)
656 (Fset_frame_selected_window): Move to window.c.
657 (Factive_minibuffer_window): Move to minibuf.c.
658 (Fother_visible_frames_p): New function.
660 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
662 * window.c (decode_window, decode_any_window): Move up in code.
663 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
664 (inhibit_frame_unsplittable): Remove unused variable.
665 (Fwindow_buffer): Move up and rewrite doc-string.
666 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
667 (Fwindow_prev): New functions.
668 (Fwindow_frame): Move here from frame.c. Accept any window as
670 (Fframe_root_window, Fframe_first_window)
671 (Fframe_selected_window): Move here from frame.c. Accept frame
672 or arbitrary window as argument. Update doc-strings.
673 (Fminibuffer_window): Move up in code.
674 (Fwindow_minibuffer_p): Move up in code and simplify.
675 (Fset_frame_selected_window): Move here from frame.c.
677 (Fselected_window, select_window, Fselect_window): Move up in
678 code. Minor doc-string fixes.
680 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
682 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
683 Do not assume that spare memory exists; that assumption is valid
684 only if SYSTEM_MALLOC.
685 (LARGE_REQUEST): New macro, so that the issue of large requests
686 is separated from the issue of spare memory.
688 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
690 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
693 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
695 * xfns.c (x_set_scroll_bar_default_width): Move declarations
698 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
700 * gtkutil.c (xg_get_default_scrollbar_width): New function.
702 * gtkutil.h: Declare xg_get_default_scrollbar_width.
704 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
705 min width by calling x_set_scroll_bar_default_width (Bug#8505).
707 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
709 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
711 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
713 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
714 (x_clipboard_manager_save): Add return value.
715 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
717 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
718 Obey Vx_select_enable_clipboard_manager. Catch errors in
719 x_clipboard_manager_save (Bug#8779).
720 (Vx_select_enable_clipboard_manager): New variable.
721 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
723 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
725 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
727 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
729 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
730 in the current matrix if keep_current_p is non-zero.
732 2011-06-04 Eli Zaretskii <eliz@gnu.org>
734 * bidi.c (bidi_level_of_next_char): Fix last change.
736 2011-06-03 Eli Zaretskii <eliz@gnu.org>
738 Support bidi reordering of text covered by display properties.
740 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
741 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
742 (bidi_cache_search, bidi_cache_iterator_state)
743 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
744 (bidi_level_of_next_char, bidi_move_to_visually_next):
745 Support character positions inside a run of characters covered by a
747 (bidi_paragraph_init, bidi_resolve_explicit_1)
748 (bidi_level_of_next_char): Call bidi_fetch_char and
749 bidi_fetch_char_advance instead of FETCH_CHAR and
751 (bidi_init_it): Initialize new members.
752 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
754 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
755 instead of using explicit *_CHAR codes.
756 (bidi_resolve_explicit, bidi_resolve_weak):
757 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
758 bidirectional text is supported only in multibyte buffers.
759 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
760 it to initialize the frame_window_p member of struct bidi_it.
761 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
762 (bidi_resolve_explicit, bidi_resolve_weak)
763 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
764 bidi_it->nchars is non-positive.
765 (bidi_level_of_next_char): Don't try to lookup the cache for the
766 next/previous character if nothing is cached there yet, or if we
767 were just reseat()'ed to a new position.
769 * xdisp.c (set_cursor_from_row): Set start and stop points
770 according to the row's direction when priming the loop that looks
771 for the glyph on which to display cursor.
772 (single_display_spec_intangible_p): Function deleted.
773 (display_prop_intangible_p): Reimplement to call
774 handle_display_spec instead of single_display_spec_intangible_p.
775 Accept 3 additional arguments needed by handle_display_spec.
776 This fixes incorrect cursor motion across display property with complex
777 values: lists, `(when COND...)' forms, etc.
778 (single_display_spec_string_p): Support property values that are
779 lists with the argument STRING its top-level element.
780 (display_prop_string_p): Fix the condition for processing a
781 property that is a list to be consistent with handle_display_spec.
782 (handle_display_spec): New function, refactored from the
783 last portion of handle_display_prop.
784 (compute_display_string_pos): Accept additional argument
785 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
786 value of a `display' property is a "replacing spec".
787 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
788 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
789 the display property, but just return a value indicating whether
790 the display property will replace the characters it covers.
791 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
792 frame_window_p members of struct bidi_it.
793 (compute_display_string_pos, compute_display_string_end):
795 (push_it): Accept second argument POSITION, where pop_it should
796 jump to continue iteration.
797 (reseat_1): Initialize bidi_it.disp_pos.
799 * keyboard.c (adjust_point_for_property): Adjust the call to
800 display_prop_intangible_p to its new signature.
802 * dispextern.h (struct bidi_it): New member frame_window_p.
803 (bidi_init_it): Update prototypes.
804 (display_prop_intangible_p): Update prototype.
805 (compute_display_string_pos, compute_display_string_end):
807 (struct bidi_it): New members nchars and disp_pos. ch_len is now
810 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
812 Malloc failure behavior now depends on size of allocation.
813 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
814 * lisp.h: Change signatures accordingly.
815 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
816 All callers changed. (Bug#8762)
818 * gnutls.c: Use Emacs's memory allocators.
819 Without this change, the gnutls library would invoke malloc etc.
820 directly, which causes problems on non-SYNC_INPUT hosts, and which
821 runs afoul of improving memory_full behavior. (Bug#8761)
822 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
823 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
824 xfree instead of the default malloc, realloc, free.
825 (Fgnutls_boot): No need to check for memory allocation failure,
826 since xmalloc does that for us.
828 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
829 * category.c (hash_get_category_set):
830 * ccl.c (ccl_driver):
831 * charset.c (Fdefine_charset_internal):
832 * charset.h (struct charset.hash_index):
833 * composite.c (get_composition_id, gstring_lookup_cache)
834 (composition_gstring_put_cache):
835 * composite.h (struct composition.hash_index):
836 * dispextern.h (struct image.hash):
837 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
838 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
839 (hashfn_equal, hashfn_user_defined, make_hash_table)
840 (maybe_resize_hash_table, hash_lookup, hash_put)
841 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
842 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
843 (Fsxhash, Fgethash, Fputhash, Fmaphash):
844 * image.c (make_image, search_image_cache, lookup_image)
845 (xpm_put_color_table_h):
846 * lisp.h (struct Lisp_Hash_Table):
847 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
848 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
849 for hashes and hash indexes, instead of 'unsigned' and 'int'.
850 * alloc.c (allocate_vectorlike):
851 Check for overflow in vector size calculations.
852 * ccl.c (ccl_driver):
853 Check for overflow when converting EMACS_INT to int.
854 * fns.c, image.c: Remove unnecessary static decls that would otherwise
855 need to be updated by these changes.
856 * fns.c (make_hash_table, maybe_resize_hash_table):
857 Check for integer overflow with large hash tables.
858 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
859 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
860 (SXHASH_REDUCE): New macro.
861 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
862 Use it instead of discarding useful hash info with large hash values.
863 (sxhash_float): New function.
864 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
865 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
866 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
867 Rewrite to use FIXNUM_BITS, as this simplifies things.
868 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
869 Adjust signatures to match updated version of code.
870 (consing_since_gc): Now EMACS_INT, since a single hash table can
871 use more than INT_MAX bytes.
873 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
875 Make it possible to build with GCC-4.6+ -O2 -flto.
877 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
879 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
881 * minibuf.c (get_minibuffer, read_minibuf_unwind):
882 Call minibuffer-inactive-mode.
884 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
886 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
889 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
891 * data.c (init_data): Remove code for UTS, this system is not
894 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
896 Don't force ./temacs to start in terminal mode.
898 * frame.c (make_initial_frame): Initialize faces in all cases, not
899 only when CANNOT_DUMP is defined.
900 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
902 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
904 * dispnew.c (add_window_display_history): Use const for the string
905 pointer. Remove declaration, not needed.
907 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
909 Use 'inline', not 'INLINE'.
910 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
911 * alloc.c, fontset.c (INLINE): Remove.
912 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
913 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
914 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
915 * gmalloc.c (register_heapinfo): Use inline unconditionally.
916 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
918 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
920 Make it possible to run ./temacs.
922 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
923 syms_of_callproc does the same thing. Remove test for
924 "initialized", do it in the caller.
925 * emacs.c (main): Avoid calling set_initial_environment when dumping.
927 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
929 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
930 (read_minibuf): Use get_minibuffer.
931 (syms_of_minibuf): Use DEFSYM.
932 (Qmetadata): New var.
933 * data.c (Qbuffer): Don't make it static.
934 (syms_of_data): Use DEFSYM.
936 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
938 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
939 (CCL_CODE_MIN): New macro.
941 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
943 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
945 * eval.c (Qdebug): Now static.
946 * lisp.h (Qdebug): Remove decl. This reverts a part of the
947 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
948 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
950 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
952 * image.c: Various fixes to ImageMagick code comments.
953 (Fimagemagick_types): Doc fix.
955 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
957 Minor fixes prompted by GCC 4.6.0 warnings.
959 * xselect.c (converted_selections, conversion_fail_tag): Now static.
961 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
962 (x_clipboard_manager_save_all): Move extern decl to ...
963 * xterm.h: ... here, so that it can be checked for consistency.
965 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
967 * xselect.c (x_clipboard_manager_save_frame)
968 (x_clipboard_manager_save_all): New functions.
969 (Fx_clipboard_manager_save): Lisp function deleted.
971 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
972 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
974 * xterm.h: Update prototype.
976 2011-05-28 William Xu <william.xwl@gmail.com>
978 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
981 2011-05-28 Jim Meyering <meyering@redhat.com>
983 Avoid a sign-extension bug in crypto_hash_function.
984 * fns.c (to_uchar): Define.
985 (crypto_hash_function): Use it to convert some newly-signed
986 variables to unsigned, to avoid sign-extension bugs. For example,
987 without this change, (md5 "truc") would evaluate to
988 45723a2aff78ff4fff7fff1114760e62 rather than the expected
989 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
990 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
992 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
994 Integer overflow fixes.
996 * dbusbind.c: Serial number integer overflow fixes.
997 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
998 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
999 to hold a serial number that is too large for a fixnum.
1000 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1001 Check for serial numbers out of range. Decode any serial number
1002 that was so large that it became a float. (Bug#8722)
1004 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1005 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1006 Use XFASTINT rather than XUINT when numbers are nonnegative.
1007 (xd_append_arg, Fdbus_method_return_internal):
1008 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1009 arguments, check that Lisp number is nonnegative, rather than
1010 silently wrapping negative numbers around. (Bug#8722)
1011 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1014 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1016 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1018 ccl: add integer overflow checks
1019 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1020 (IN_INT_RANGE): New macros.
1021 (ccl_driver): Use them to check for integer overflow when
1022 decoding a CCL program. Many of the new checks are whether XINT (x)
1023 fits in int; it doesn't always, on 64-bit hosts. The new version
1024 doesn't catch all possible integer overflows, but it's an
1025 improvement. (Bug#8719)
1027 * alloc.c (make_event_array): Use XINT, not XUINT.
1028 There's no need for unsigned here.
1030 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1031 This follows up to the 2011-05-06 change that substituted uintptr_t
1032 for EMACS_INT. This case wasn't caught back then.
1034 Rework Fformat to avoid integer overflow issues.
1035 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1036 now (part of C89). Include <verify.h>.
1037 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1038 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1039 (Fformat): Avoid the prepass trying to compute sizes; it was only
1040 approximate and thus did not catch overflow reliably. Instead, walk
1041 through the format just once, formatting and computing sizes as we go,
1042 checking for integer overflow at every step, and allocating a larger
1043 buffer as needed. Keep track separately whether the format is
1044 multibyte. Keep only the most-recently calculated precision, rather
1045 than them all. Record whether each argument has been converted to
1046 string. Use EMACS_INT, not int, for byte and char and arg counts.
1047 Support field widths and precisions larger than INT_MAX. Avoid
1048 sprintf's undefined behavior with conversion specifications such as %#d
1049 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1050 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1051 formatting out-of-range floating point numbers with int
1054 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1056 * data.c: Avoid integer truncation in expressions involving floats.
1057 * data.c: Include <intprops.h>.
1058 (arith_driver): When there's an integer overflow in an expression
1059 involving floating point, convert the integers to floating point
1060 so that the resulting value does not suffer from catastrophic
1061 integer truncation. For example, on a 64-bit host (* 4
1062 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1063 Do not rely on undefined behavior after integer overflow.
1065 merge count_size_as_multibyte, parse_str_to_multibyte
1066 * character.c, character.h (count_size_as_multibyte):
1067 Rename from parse_str_to_multibyte; all uses changed.
1068 Check for integer overflow.
1069 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1070 since it's now a duplicate of the other. This is more of
1071 a character than a buffer op, so better that it's in character.c.
1072 * fns.c, print.c: Adjust to above changes.
1074 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1076 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1078 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1080 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1081 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1082 (x_clipboard_manager_save): Now static.
1083 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1085 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1086 (crypto_hash_function): Now static.
1087 Fix pointer signedness problems. Avoid unnecessary initializations.
1089 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1091 * termhooks.h (Vselection_alist): Make it terminal-local.
1093 * terminal.c (create_terminal): Initialize it.
1095 * xselect.c: Support for clipboard managers.
1096 (Vselection_alist): Move to termhooks.h as terminal-local var.
1097 (LOCAL_SELECTION): New macro.
1098 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1099 (symbol_to_x_atom): Remove gratuitous arg.
1100 (x_handle_selection_request, lisp_data_to_selection_data)
1101 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1102 (x_own_selection, x_get_local_selection, x_convert_selection):
1103 New arg, specifying work frame. Use terminal-local Vselection_alist.
1104 (some_frame_on_display): Delete unused function.
1105 (Fx_own_selection_internal, Fx_get_selection_internal)
1106 (Fx_disown_selection_internal, Fx_selection_owner_p)
1107 (Fx_selection_exists_p): New optional frame arg.
1108 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1109 (x_handle_selection_clear): Don't treat other terminals with the
1110 same keyboard specially. Use the terminal-local Vselection_alist.
1111 (x_clear_frame_selections): Use Frun_hook_with_args.
1113 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1115 * xterm.h: Add support for those atoms.
1117 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
1119 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1120 (converted_selections, conversion_fail_tag): New global variables.
1121 (x_selection_request_lisp_error): Free the above.
1122 (x_get_local_selection): Remove unnecessary code.
1123 (x_reply_selection_request): Args changed; handle arbitrary array
1124 of converted selections stored in converted_selections.
1125 Separate the XChangeProperty and SelectionNotify steps.
1126 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1127 (x_convert_selection): New function.
1128 (x_handle_selection_event): Simplify.
1129 (x_get_foreign_selection): Don't ignore incoming requests while
1130 waiting for an answer; this will fail when we implement
1131 SAVE_TARGETS, and seems unnecessary anyway.
1132 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1133 (Vx_sent_selection_functions): Doc fix.
1135 2011-05-26 Leo Liu <sdl.web@gmail.com>
1137 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1139 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1141 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1143 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1144 for fringe update if it has periodic bitmap.
1145 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1146 and fringe_bitmap_periodic_p.
1148 * fringe.c (get_fringe_bitmap_data): New function.
1149 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1150 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1151 row. Mark glyph row for fringe update if periodicity changed.
1153 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1154 for fringe update unless it has periodic bitmap.
1156 2011-05-25 Kenichi Handa <handa@m17n.org>
1158 * xdisp.c (get_next_display_element): Set correct it->face_id for
1159 a static composition.
1161 2011-05-24 Leo Liu <sdl.web@gmail.com>
1164 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1166 * fns.c (crypto_hash_function, Fsha1): New function.
1167 (Fmd5): Use crypto_hash_function.
1168 (syms_of_fns): Add Ssha1.
1170 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1172 * gnutls.c: Remove unused macros.
1173 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1174 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1175 Remove macros that are defined and never used.
1176 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1178 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1180 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1181 (Fx_get_selection_internal): Minor cleanup.
1182 (Fx_own_selection_internal): Rename arguments for consistency with
1185 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1187 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1189 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1191 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1193 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1195 * dispnew.c (scrolling_window): Don't exclude the case that the
1196 last enabled row in the desired matrix touches the bottom boundary.
1198 2011-05-21 Glenn Morris <rgm@gnu.org>
1200 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
1201 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1202 and add some more files.
1204 2011-05-20 Eli Zaretskii <eliz@gnu.org>
1206 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1207 report_file_error introduced by the change from 2011-05-07.
1209 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1211 * systime.h (Time): Define only if emacs is defined.
1212 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1213 where the include path doesn't have X11/X.h by default. See
1214 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1216 2011-05-20 Kenichi Handa <handa@m17n.org>
1218 * composite.c (find_automatic_composition): Fix previous change.
1220 2011-05-20 Glenn Morris <rgm@gnu.org>
1222 * lisp.mk: New file, split from Makefile.in.
1223 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1224 (shortlisp): Remove.
1225 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1227 2011-05-19 Glenn Morris <rgm@gnu.org>
1229 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1230 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1231 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1232 (lisp): Set the order to that of loadup.el.
1233 (shortlisp): Make it a copy of $lisp.
1234 (SOME_MACHINE_LISP): Remove.
1235 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1236 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1238 2011-05-18 Kenichi Handa <handa@m17n.org>
1240 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1241 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1242 (find_automatic_composition): Mostly rewrite for efficiency.
1244 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
1246 * makefile.w32-in: Update dependencies.
1248 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1250 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1253 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
1255 Fix some integer overflow issues, such as string length overflow.
1257 * insdel.c (count_size_as_multibyte): Check for string overflow.
1259 * character.c (lisp_string_width): Check for string overflow.
1260 Use EMACS_INT, not int, for string indexes and lengths; in
1261 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1262 the resulting string length overflows an EMACS_INT; instead,
1263 report a string overflow if no precision given. When checking for
1264 precision exhaustion, use a check that cannot possibly have
1265 integer overflow. (Bug#8675)
1266 * character.h (lisp_string_width): Adjust to new signature.
1268 * alloc.c (string_overflow): New function.
1269 (Fmake_string): Use it. This doesn't change behavior, but saves
1270 a few bytes and will simplify future changes.
1271 * character.c (string_escape_byte8): Likewise.
1272 * lisp.h (string_overflow): New decl.
1274 Fixups, following up to the user-interface timestamp change.
1275 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1276 for UI timestamps, instead of unsigned long.
1277 * msdos.c (mouse_get_pos): Likewise.
1278 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1279 * w32gui.h (Time): Define by including "systime.h" rather than by
1280 declaring it ourselves. (Bug#8664)
1282 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1283 * image.c (clear_image_cache): Likewise.
1285 * term.c (term_mouse_position): Don't assume time_t wraparound.
1287 Be more systematic about user-interface timestamps.
1288 Before, the code sometimes used 'Time', sometimes 'unsigned long',
1289 and sometimes 'EMACS_UINT', to represent these timestamps.
1290 This change causes it to use 'Time' uniformly, as that's what X uses.
1291 This makes the code easier to follow, and makes it easier to catch
1292 integer overflow bugs such as Bug#8664.
1293 * frame.c (Fmouse_position, Fmouse_pixel_position):
1294 Use Time, not unsigned long, for user-interface timestamps.
1295 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1296 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1297 * keyboard.h (last_event_timestamp): Likewise.
1298 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1299 * menu.h (xmenu_show): Likewise.
1300 * term.c (term_mouse_position): Likewise.
1301 * termhooks.h (struct input_event.timestamp): Likewise.
1302 (struct terminal.mouse_position_hook): Likewise.
1303 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1304 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1305 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1306 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1308 * menu.h, termhooks.h: Include "systime.h", for Time.
1310 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1311 Don't assume that the difference between two unsigned long values
1312 can fit into an integer. At this point, we know button_down_time
1313 <= event->timestamp, so the difference must be nonnegative, so
1314 there's no need to cast the result if double-click-time is
1315 nonnegative, as it should be; check that it's nonnegative, just in
1316 case. This bug is triggered when events are more than 2**31 ms
1317 apart (about 25 days). (Bug#8664)
1319 * xselect.c (last_event_timestamp): Remove duplicate decl.
1320 (x_own_selection): Remove needless cast to unsigned long.
1322 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1323 that always fit in int. Use a sentinel instead of a counter, to
1324 avoid a temp and to allay GCC's concerns about possible int overflow.
1325 * frame.h (struct frame): Use int for menu_bar_items_used
1326 instead of EMACS_INT, since it always fits in int.
1328 * menu.c (grow_menu_items): Check for int overflow.
1330 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1332 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1333 Before, the code was not consistent. These values cannot exceed
1334 2**31 - 1 so there's no need to make them unsigned.
1335 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1336 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1337 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1339 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1341 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1342 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1343 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1344 presumably because the widths might not match.
1346 * window.c (size_window): Avoid needless test at loop start.
1348 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1350 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1352 2011-05-12 Drew Adams <drew.adams@oracle.com>
1354 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1356 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1358 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1359 `width' to `bar_area_x' and `bar_area_width', respectively.
1360 (x_scroll_run): Take account of fringe background extension.
1362 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1363 Rename local vars `left' and `width' to `bar_area_x' and
1364 `bar_area_width', respectively.
1365 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1366 background extension.
1368 2011-05-10 Jim Meyering <meyering@redhat.com>
1370 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1372 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
1374 * image.c (Finit_image_library): Return t for built-in image types,
1375 like pbm and xbm. (Bug#8640)
1377 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1379 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1381 2011-05-07 Eli Zaretskii <eliz@gnu.org>
1383 * w32console.c (Fset_screen_color): Doc fix.
1384 (Fget_screen_color): New function.
1385 (syms_of_ntterm): Defsubr it.
1387 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1388 unlink the temporary file if Fcall_process didn't create it in the
1390 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1391 child process will be redirected to a file specified with `:file'.
1392 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1393 cue to call_process_cleanup not to close that handle.
1395 2011-05-07 Ben Key <bkey76@gmail.com>
1397 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1398 one of two shell specific rules, either bootstrap-temacs-CMD or
1399 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1400 to the previous implementation of the bootstrap-temacs rule.
1401 The bootstrap-temacs-CMD rule is similar to the previous
1402 implementation of the bootstrap-temacs rule except that it
1403 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1406 These changes, along with some changes to nt/configure.bat,
1407 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1408 earlier fix to add support for --cflags and --ldflags options
1409 that include quotes so that it works whether make uses cmd or
1412 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
1414 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1415 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1417 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1418 a string. Handle both cases.
1419 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1420 (Fdbus_register_method): Use Qinvalid_function.
1422 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1424 * makefile.w32-in: Update dependencies.
1425 (LISP_H): Add inttypes.h and stdin.h.
1426 (PROCESS_H): Add unistd.h.
1428 2011-05-06 Eli Zaretskii <eliz@gnu.org>
1430 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1431 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1433 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
1435 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1437 * term.c (vfatal): Remove stray call to va_end.
1438 It's not needed and the C Standard doesn't allow it here anyway.
1440 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1441 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1443 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1446 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1448 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1450 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1452 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1454 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1456 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1457 * charset.c (Fdefine_charset_internal): Don't initialize
1458 charset.code_space[15]. The value was garbage, on hosts with
1459 32-bit int (Bug#8600).
1461 * lread.c (read_integer): Be more consistent with string-to-number.
1462 Use string_to_number to do the actual conversion; this avoids
1463 rounding errors and fixes some other screwups. Without this fix,
1464 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1465 (digit_to_number): Move earlier, for benefit of read_integer.
1466 Return -1 if the digit is out of range for the base, -2 if it is
1467 not a digit in any supported base. (Bug#8602)
1469 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1471 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1472 to match comment at start of function. This also removes a
1473 GCC warning about overflow in a 32+64-bit port.
1475 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1477 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1478 Reported by Stefan Monnier in
1479 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
1480 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1481 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
1483 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1484 (EMACS_UINTPTR): Likewise, with uintptr_t.
1486 * lisp.h: Prefer 64-bit EMACS_INT if available.
1487 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1488 on 32-bit hosts that have 64-bit int, so that they can access
1490 However, temporarily disable this change unless the temporary
1491 symbol WIDE_EMACS_INT is defined.
1493 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1495 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1496 This removes an assumption that EMACS_INT and long are the same
1497 width as pointers. The assumption is true for Emacs porting targets
1498 now, but we want to make other targets possible.
1499 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1500 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1501 In the rest of the code, change types of integers that hold casted
1502 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1503 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1504 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1505 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1506 No need to cast type when ORing.
1507 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1508 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1509 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1510 assume EMACS_INT is the same width as char *.
1511 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1512 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1513 Remove no-longer-needed casts.
1514 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1515 (xg_tool_bar_help_callback, xg_make_tool_item):
1516 Use EMACS_INTPTR to hold an integer
1517 that will be cast to void *; this can avoid a GCC warning
1518 if EMACS_INT is not the same width as void *.
1519 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1520 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1521 (current_message_1, set_message_1):
1522 Use a local to convert to proper width without a cast.
1523 * xmenu.c (dialog_selection_callback): Likewise.
1525 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1526 Also, don't assume VALBITS / RAND_BITS is less than 5,
1527 and don't rely on undefined behavior when shifting a 1 left into
1529 * lisp.h (get_random): Change signature to match.
1531 * lread.c (hash_string): Use size_t, not int, for hash computation.
1532 Normally we prefer signed values; but hashing is special, because
1533 it's better to use unsigned division on hash table sizes so that
1534 the remainder is nonnegative. Also, size_t is the natural width
1535 for hashing into memory. The previous code used 'int', which doesn't
1536 retain enough info to hash well into very large tables.
1537 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1539 * dbusbind.c: Don't possibly lose pointer info when converting.
1540 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1541 Use XPNTR rather than XHASH, so that the high-order bits of
1542 the pointer aren't lost when converting through void *.
1544 * eval.c (Fautoload): Don't double-shift a pointer.
1546 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1548 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1550 * gnutls.c (DEF_GNUTLS_FN):
1551 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1553 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1555 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1558 2011-05-05 Eli Zaretskii <eliz@gnu.org>
1560 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1561 New version that can reserve upto 2GB of heap space.
1563 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
1565 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1567 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1569 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1570 `gnutls_certificate_set_x509_key_file'.
1572 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
1574 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1575 Update dependencies.
1577 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1579 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1580 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1581 Remove unused parameter `fildes'.
1582 * process.c (read_process_output, send_process): Don't pass it.
1584 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1586 Fix previous change: the library cache is defined in w32.c.
1587 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1588 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1590 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1592 Implement dynamic loading of GnuTLS on Windows.
1594 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1595 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1596 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1599 * gnutls.c (Qgnutls_dll): Define.
1600 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1601 (gnutls_*): Declare function pointers.
1602 (init_gnutls_functions): New function to initialize function pointers.
1603 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1604 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1605 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1606 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1607 (emacs_gnutls_write, emacs_gnutls_read)
1608 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1609 (Fgnutls_available_p): New function.
1610 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1611 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1612 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1614 * image.c: Include w32.h.
1615 (Vimage_type_cache): Delete.
1616 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1617 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1618 (w32_delayed_load): Move to w32.c.
1620 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1622 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1623 (w32_delayed_load): Move from image.c. When loading a library, record
1624 its filename in the :loaded-from property of the library id.
1625 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1626 Initialize and staticpro them.
1627 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1629 * process.c: Include lisp.h before w32.h, not after.
1630 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1631 instead of gnutls_record_check_pending.
1633 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1635 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1637 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1638 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1641 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1643 * xterm.c (x_set_frame_alpha): Do not set property on anything
1644 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1646 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1648 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1650 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1652 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1653 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1654 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1655 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1656 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1657 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1658 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1659 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1660 (Qgnutls_bootprop_callbacks_verify): Make static.
1662 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1664 * callproc.c: Indentation fixup.
1666 * sysdep.c (wait_for_termination_1): Make static.
1667 (wait_for_termination, interruptible_wait_for_termination):
1668 Move after wait_for_termination_1.
1670 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1672 * sysdep.c (interruptible_wait_for_termination): New function
1673 which is like wait_for_termination, but allows keyboard
1676 * callproc.c (Fcall_process): Add (:file "file") as an option for
1678 (Fcall_process_region): Ditto.
1680 2011-04-30 Eli Zaretskii <eliz@gnu.org>
1682 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1683 rather than `XVECTOR (FOO)->size'.
1685 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1686 inttypes.h, as a gnulib replacement is used if it not available in
1689 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1691 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1692 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1693 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1695 * coding.c (coding_alloc_by_realloc): Error out if destination
1696 will grow beyond MOST_POSITIVE_FIXNUM.
1697 (decode_coding_emacs_mule): Abort if there isn't enough place in
1698 charbuf for the composition carryover bytes. Reserve an extra
1699 space for up to 2 characters produced in a loop.
1700 (decode_coding_iso_2022): Abort if there isn't enough place in
1701 charbuf for the composition carryover bytes.
1703 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1705 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1706 aborting when %lld or %lll format is passed.
1707 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1708 %llo or %llx format is passed. (Bug#8545)
1710 * window.c (window_scroll_line_based): Use a marker instead of
1711 simple variables to record original value of point. (Bug#7952)
1713 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1714 produced by %s or %c overflows available buffer space. (Bug#8545)
1716 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1718 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1719 (SIZE_MAX): Move defn after all includes, as they might #define it.
1721 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1723 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1725 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1727 * keyboard.c (Qdelayed_warnings_hook): Define.
1728 (command_loop_1): Run `delayed-warnings-hook'
1729 if Vdelayed_warnings_list is non-nil.
1730 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1731 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1733 2011-04-28 Eli Zaretskii <eliz@gnu.org>
1735 * doprnt.c (doprnt): Don't return value smaller than the buffer
1736 size if the message was truncated. (Bug#8545).
1738 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1740 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1741 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1743 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1745 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1747 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
1749 * makefile.w32-in: Update dependencies.
1751 2011-04-27 Eli Zaretskii <eliz@gnu.org>
1753 Improve `doprnt' and its usage. (Bug#8545)
1754 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1755 `format_end'. Remove support for %l as a conversion specifier.
1756 Don't use xrealloc. Improve diagnostics when the %l size modifier
1757 is used. Update the commentary.
1759 * eval.c (verror): Simplify calculation of size_t.
1761 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1764 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1766 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1769 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1771 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1772 This makes this file independent of the recent pseudovector change.
1774 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
1776 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1778 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
1779 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
1780 Remove unused local.
1781 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
1783 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
1784 GCC 4.6.0 optimizes based on type-based alias analysis.
1785 For example, if b is of type struct buffer * and v of type struct
1786 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1787 != &v->size, and therefore "v->size = 1; b->size = 2; return
1788 v->size;" must therefore return 1. This assumption is incorrect
1789 for Emacs, since it type-puns struct Lisp_Vector * with many other
1790 types. To fix this problem, this patch adds a new type struct
1791 vectorlike_header that documents the constraints on layout of vectors
1792 and pseudovectors, and helps optimizing compilers not get fooled
1793 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1794 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
1795 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1797 (XSETPVECTYPE): Rewrite in terms of new macro.
1798 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1799 This is a bit clearer, and further avoids the possibility of
1800 undesirable aliasing.
1801 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
1802 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
1803 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1804 since Lisp_Subr is a special case (no "next" field).
1805 (ASIZE): Now uses header.size rather than size.
1806 All previous uses of XVECTOR (foo)->size replaced to use this macro,
1807 to avoid the hassle of writing XVECTOR (foo)->header.size.
1808 (struct vectorlike_header): New type.
1809 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1810 object, to help avoid aliasing.
1811 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1812 (SUBRP): Likewise, since Lisp_Subr is a special case.
1813 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1814 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1815 (struct Lisp_Hash_Table): Combine first two members into a single
1816 struct vectorlike_header member. All uses of "size" and "next" members
1817 changed to be "header.size" and "header.next".
1818 * buffer.h (struct buffer): Likewise.
1819 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1820 * frame.h (struct frame): Likewise.
1821 * process.h (struct Lisp_Process): Likewise.
1822 * termhooks.h (struct terminal): Likewise.
1823 * window.c (struct save_window_data, struct saved_window): Likewise.
1824 * window.h (struct window): Likewise.
1825 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1826 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1827 * buffer.c (init_buffer_once): Likewise.
1828 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1830 * process.c (Fformat_network_address): Use local var for size,
1833 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1835 Make the Lisp reader and string-to-float more consistent (Bug#8525)
1836 * data.c (atof): Remove decl; no longer used or needed.
1837 (digit_to_number): Move to lread.c.
1838 (Fstring_to_number): Use new string_to_number function, to be
1839 consistent with how the Lisp reader treats infinities and NaNs.
1840 Do not assume that floating-point numbers represent EMACS_INT
1841 without losing information; this is not true on most 64-bit hosts.
1842 Avoid double-rounding errors, by insisting on integers when
1843 parsing non-base-10 numbers, as the documentation specifies.
1844 * lisp.h (string_to_number): New decl, replacing ...
1845 (isfloat_string): Remove.
1846 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
1847 (read1): Do not accept +. and -. as integers; this
1848 appears to have been a coding error. Similarly, do not accept
1849 strings like +-1e0 as floating point numbers. Do not report
1850 overflow for integer overflows unless the base is not 10 which
1851 means we have no simple and reliable way to continue.
1852 Break out the floating-point parsing into a new
1853 function string_to_number, so that Fstring_to_number parses
1854 floating point numbers consistently with the Lisp reader.
1855 (digit_to_number): Move here from data.c. Make it static inline.
1856 (E_CHAR, EXP_INT): Remove, replacing with ...
1857 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1858 (string_to_number): New function, replacing isfloat_string.
1859 This function checks for valid syntax and produces the resulting
1860 Lisp float number too. Rework it so that string-to-number
1861 no longer mishandles examples like "1.0e+". Use strtoumax,
1862 so that overflow for non-base-10 numbers is reported only when
1863 there's no portable and simple way to convert to floating point.
1865 * textprop.c (set_text_properties_1): Rewrite for clarity,
1866 and to avoid GCC warning about integer overflow.
1868 * intervals.h (struct interval): Use EMACS_INT for members
1869 where EMACS_UINT might cause problems. See
1870 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1871 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1872 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1874 (offset_intervals): Tell GCC not to worry about length overflow
1875 when negating a negative length.
1877 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1878 (overrun_check_free): Likewise.
1880 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1881 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1884 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1885 (gnutls_make_error): Rename local to avoid shadowing.
1886 (gnutls_emacs_global_deinit): ifdef out; not used.
1887 (Fgnutls_boot): Use const for pointer to readonly storage.
1888 Comment out unused local. Fix pointer signedness problems.
1890 * lread.c (openp): Don't stuff size_t into an 'int'.
1891 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1892 about possible signed overflow.
1894 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1895 (GDK_KEY_g): Don't define if already defined.
1896 (xg_prepare_tooltip): Avoid pointer signedness problem.
1897 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1899 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1900 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1902 * xfns.c (Fx_window_property): Simplify a bit,
1903 to make a bit faster and to avoid GCC 4.6.0 warning.
1904 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1906 * fns.c (internal_equal): Don't assume size_t fits in int.
1908 * alloc.c (compact_small_strings): Tighten assertion a little.
1910 Replace pEd with more-general pI, and fix some printf arg casts.
1911 * lisp.h (pI): New macro, generalizing old pEd macro to other
1912 conversion specifiers. For example, use "...%"pI"d..." rather
1913 than "...%"pEd"...".
1914 (pEd): Remove. All uses replaced with similar uses of pI.
1915 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1916 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1917 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1918 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1919 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1920 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1921 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1923 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1924 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1925 * print.c (safe_debug_print, print_object): Likewise.
1926 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1928 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1929 avoiding the 0 flag, which is not portable.
1930 * process.c (Fmake_network_process): Use pI to avoid cast.
1931 * region-cache.c (pp_cache): Likewise.
1932 * xdisp.c (decode_mode_spec): Likewise.
1933 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1934 behavior on 64-bit hosts with printf arg.
1935 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
1936 (x_stop_queuing_selection_requests): Likewise.
1937 (x_get_window_property): Don't truncate byte count to an 'int'
1940 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1941 here, since it parses constructs like leading '-' and spaces,
1942 which are not wanted; and it overflows with large numbers.
1943 Instead, simply match F[0-9]+, which is what is wanted anyway.
1945 * alloc.c: Remove unportable assumptions about struct layout.
1946 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1947 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1948 (allocate_vectorlike, make_pure_vector): Use the new macros,
1949 plus offsetof, to remove unportable assumptions about struct layout.
1950 These assumptions hold on all porting targets that I know of, but
1951 they are not guaranteed, they're easy to remove, and removing them
1952 makes further changes easier.
1954 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1955 This doesn't fix a bug but makes the code clearer.
1956 (string_overrun_cookie): Now const. Use initializers that
1957 don't formally overflow signed char, to avoid warnings.
1958 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1959 can cause Emacs to crash when string overrun checking is enabled.
1960 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1961 multiple of sizeof (EMACS_INT); it need not be, if
1962 alignof(EMACS_INT) < sizeof (EMACS_INT).
1963 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
1965 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
1967 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1969 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1971 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
1972 supposed to be handshaking. (Bug#8556)
1973 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1975 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
1977 * lisp.h (Qdebug): List symbol.
1978 * eval.c (Qdebug): Restore global linkage.
1979 * keyboard.c (debug-on-event): New variable.
1980 (handle_user_signal): Break into debugger when debug-on-event
1981 matches the current signal symbol.
1983 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1985 * alloc.c (check_sblock, check_string_bytes)
1986 (check_string_free_list): Convert to standard C.
1988 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1990 * w32.c (emacs_gnutls_push): Fix typo.
1992 2011-04-25 Eli Zaretskii <eliz@gnu.org>
1994 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1995 "cast to pointer from integer of different size".
1997 Improve doprnt and its use in verror. (Bug#8545)
1998 * doprnt.c (doprnt): Document the set of format control sequences
1999 supported by the function. Use SAFE_ALLOCA instead of always
2002 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2003 is one byte too soon. Don't use xrealloc; instead xfree and
2006 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2008 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2011 * gnutls.c: Renamed global_initialized to
2012 gnutls_global_initialized. Added internals for the
2013 :verify-hostname-error, :verify-error, and :verify-flags
2014 parameters of `gnutls-boot' and documented those parameters in the
2015 docstring. Start callback support.
2016 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2017 unless a fatal error occured. Call gnutls_alert_send_appropriate
2018 on error. Return error code.
2019 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2020 (emacs_gnutls_read): Likewise.
2021 (Fgnutls_boot): Return handshake error code.
2022 (emacs_gnutls_handle_error): New function.
2023 (wsaerror_to_errno): Likewise.
2025 * w32.h (emacs_gnutls_pull): Add prototype.
2026 (emacs_gnutls_push): Likewise.
2028 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2029 (emacs_gnutls_push): Likewise.
2031 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2033 * process.c (wait_reading_process_output): Check if GnuTLS
2034 buffered some data internally if no FDs are set for TLS
2037 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2038 (LIBS): Link to USER_LIBS.
2039 ($(BLD)/gnutls.$(0)): New target.
2041 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2043 * xdisp.c (handle_single_display_spec): Rename the
2044 display_replaced_before_p argument into display_replaced_p, to
2045 make it consistent with the commentary. Fix typos in the
2048 * textprop.c (syms_of_textprop): Remove dead code.
2049 (copy_text_properties): Delete obsolete commentary about an
2050 interface that was deleted long ago. Fix typos in the description
2053 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2054 to changes in oldXMenu/XMenu.h from 2011-04-16.
2055 <menu_help_message, prev_menu_help_message>: Constify.
2056 (IT_menu_make_room): menu->help_text is now `const char **';
2059 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2060 to changes in oldXMenu/XMenu.h from 2011-04-16.
2061 (struct XMenu): Declare `help_text' `const char **'.
2063 * xfaces.c <Qunspecified>: Make extern again.
2065 * syntax.c: Include sys/types.h before including regex.h, as
2068 * doc.c (get_doc_string): Improve the format passed to `error'.
2070 * doprnt.c (doprnt): Improve commentary.
2072 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2074 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2077 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2078 changes in globals.h immediately force recompilation.
2079 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2080 $(CURDIR)/s/ms-w32.h.
2081 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2083 * character.c (Fchar_direction): Function deleted.
2084 (syms_of_character): Don't defsubr it.
2085 <char-direction-table>: Deleted.
2087 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2089 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2090 * doprnt.c: Include limits.h.
2091 (SIZE_MAX): New macro.
2092 (doprnt): Return a size_t value. 2nd arg is now size_t.
2093 Many local variables are now size_t instead of int or unsigned.
2094 Improve overflow protection. Support `l' modifier for integer
2095 conversions. Support %l conversion. Don't assume an EMACS_INT
2096 argument for integer conversions and for %c.
2098 * lisp.h (doprnt): Restore prototype.
2100 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2103 * Makefile.in (base_obj): Add back doprnt.o.
2105 * deps.mk (doprnt.o): Add back prerequisites.
2106 (callint.o): Depend on character.h.
2108 * eval.c (internal_lisp_condition_case): Include the handler
2109 representation in the error message.
2110 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2111 when breaking from the loop.
2113 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2115 * callint.c (Fcall_interactively): When displaying error message
2116 about invalid control letter, pass the character's codepoint, not
2117 a pointer to its multibyte form. Improve display of the character
2118 in octal and display also its hex code.
2120 * character.c (char_string): Use %x to display the (unsigned)
2121 codepoint of an invalid character, to avoid displaying a bogus
2124 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2125 `error', not SYMBOL_NAME itself.
2127 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2128 character arguments to `error'.
2130 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2131 to `error' in error message about FINAL_CHAR argument. Make sure
2132 FINAL_CHAR is a character, and use %c when it is passed as
2133 argument to `error'.
2135 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2137 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2139 * w32.c: Include <time.h>.
2140 (sys_localtime): New function.
2142 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
2144 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2146 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
2148 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
2150 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2153 2011-04-19 Eli Zaretskii <eliz@gnu.org>
2155 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2156 gl_state.e_property when gl_state.object is Qt.
2158 * insdel.c (make_gap_larger): Remove limitation of buffer size
2161 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
2163 * xdisp.c (lookup_glyphless_char_display)
2164 (produce_glyphless_glyph): Handle cons cell entry in
2165 glyphless-char-display.
2166 (Vglyphless_char_display): Document it.
2168 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2169 glyphless-char-display.
2171 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
2173 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2175 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2177 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2178 definition for no-X builds.
2180 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
2182 Static checks with GCC 4.6.0 and non-default toolkits.
2184 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2186 * process.c (keyboard_bit_set): Define only if SIGIO.
2187 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2188 (send_process): Repair possible setjmp clobbering.
2190 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2192 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2194 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2196 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2197 Define only if needed.
2199 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2200 by pacifying GCC about it. Maybe it's time to retire it?
2201 * xfaces.c (USG, __TIMEVAL__): Likewise.
2203 * dispextern.h (struct redisplay_interface): Rename param
2205 * termhooks.h (struct terminal): Likewise.
2206 * xterm.c (xembed_send_message): Likewise.
2208 * insdel.c (make_gap_smaller): Define only if
2209 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2211 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2214 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2215 so that we aren't warned about unused symbols.
2217 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2219 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
2221 * xfns.c (x_real_positions): Mark locals as initialized.
2223 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2225 * xterm.c: Fix problems found by static analysis with other toolkits.
2226 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
2227 (x_dispatch_event): Declare static if USE_GTK, and
2228 define if USE_GTK || USE_X_TOOLKIT.
2229 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
2230 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
2231 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2232 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
2234 * xmenu.c (menu_help_callback): Pointer type fixes.
2235 Use const pointers when pointing at readonly data. Avoid pointer
2237 (FALSE): Remove unused macro.
2238 (update_frame_menubar): Remove unused decl.
2240 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2242 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2243 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2244 (single_menu_item): Rename local to avoid shadowing.
2246 * keyboard.c (make_lispy_event): Remove unused local var.
2248 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2249 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2251 * bitmaps: Change bitmaps from unsigned char back to the X11
2252 compatible char. Avoid the old compiler warnings about
2253 out-of-range initializers by using, for example, '\xab' rather
2256 * xgselect.c (xgselect_initialize): Check vs interface
2257 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2259 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2261 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2262 to read-only memory.
2264 * fns.c (vector): Remove; this old hack is no longer needed.
2266 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
2268 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2270 * xrdb.c (x_load_resources): Omit unused local.
2272 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
2273 (x_window): Rename locals to avoid shadowing.
2274 (USG): Use the kludged USG macro, to pacify gcc.
2276 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
2277 (x_term_init): Remove local to avoid shadowing.
2279 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
2281 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2282 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2284 2011-04-16 Eli Zaretskii <eliz@gnu.org>
2286 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2288 Fix regex.c, syntax.c and friends for buffers > 2GB.
2289 * syntax.h (struct gl_state_s): Declare character position members
2292 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2294 * textprop.c (verify_interval_modification, interval_of):
2295 Declare arguments EMACS_INT.
2297 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2300 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2302 * indent.c (Fvertical_motion): Local variable it_start is now
2305 * regex.c (re_match, re_match_2, re_match_2_internal)
2306 (bcmp_translate, regcomp, regexec, print_double_string)
2307 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2308 (re_compile_pattern, re_exec): Declare arguments and local
2309 variables `size_t' and `ssize_t' and return values `regoff_t', as
2311 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2312 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2313 <compile_stack_type>: `size' and `avail' are now `size_t'.
2315 * regex.h <regoff_t>: Use ssize_t, not int.
2316 (re_search, re_search_2, re_match, re_match_2): Arguments that
2317 specify buffer/string position and length are now ssize_t and
2318 size_t. Return type is regoff_t.
2320 2011-04-16 Ben Key <bkey76@gmail.com>
2322 * nsfont.m: Fixed bugs in ns_get_family and
2323 ns_descriptor_to_entity that were caused by using free to
2324 deallocate memory blocks that were allocated by xmalloc (via
2325 xstrdup). This caused Emacs to crash when compiled with
2326 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2327 --enable-checking=xmallocoverrun). xfree is now used to
2328 deallocate these memory blocks.
2330 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
2332 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2334 emacs_write: Accept and return EMACS_INT for sizes.
2335 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2337 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2338 Accept and return EMACS_INT.
2339 (emacs_gnutls_write): Return the number of bytes written on
2341 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
2342 (emacs_read, emacs_write): Remove check for negative size, as the
2343 Emacs source code has been audited now.
2344 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2345 (emacs_read, emacs_write): Use it.
2346 * process.c (send_process): Adjust to the new signatures of
2347 emacs_write and emacs_gnutls_write. Do not attempt to store
2348 a byte offset into an 'int'; it might overflow.
2349 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
2351 * sound.c: Don't assume sizes fit in 'int'.
2352 (struct sound_device.period_size, alsa_period_size):
2353 Return EMACS_INT, not int.
2354 (struct sound_device.write, vox_write, alsa_write):
2355 Accept EMACS_INT, not int.
2356 (wav_play, au_play): Use EMACS_INT to store sizes and to
2357 record read return values.
2359 2011-04-15 Ben Key <bkey76@gmail.com>
2361 * keyboard.c (Qundefined): Don't declare static since it is used
2363 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2364 static since they are used in nsfont.m.
2366 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2368 * process.c (Qprocessp): Don't declare static.
2369 * lisp.h (Qprocessp): Declare again.
2371 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
2373 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2375 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2377 Improve C-level modularity by making more things 'static'.
2379 Don't publish debugger-only interfaces to other modules.
2380 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2381 (verify_bytepos, count_markers): Move decls to the only modules
2383 * region-cache.h (pp_cache): Likewise.
2384 * window.h (check_all_windows): Likewise.
2385 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2387 * sysdep.c (croak): Now static, if
2388 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2389 * syssignal.h (croak): Declare only if not static.
2391 * alloc.c (refill_memory_reserve): Now static if
2392 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2393 * lisp.h (refill_memory_reserve): Declare only if not static.
2395 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2396 Define only if USE_LUCID.
2398 * xrdb.c (x_customization_string, x_rm_string): Now static.
2400 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2401 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2403 * xdisp.c (draw_row_with_mouse_face): Now static.
2404 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2406 * window.h (check_all_windows): Mark externally visible.
2408 * window.c (window_deletion_count): Now static.
2410 * undo.c: Make symbols static if they're not exported.
2411 (last_undo_buffer, last_boundary_position, pending_boundary):
2414 * textprop.c (interval_insert_behind_hooks): Now static.
2415 (interval_insert_in_front_hooks): Likewise.
2417 * term.c: Make symbols static if they're not exported.
2418 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2419 (max_frame_lines, tty_set_terminal_modes):
2420 (tty_reset_terminal_modes, tty_turn_off_highlight):
2421 (get_tty_terminal): Now static.
2422 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2423 * termhooks.h (term_mouse_moveto): Do not declare if
2425 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2426 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2428 * sysdep.c: Make symbols static if they're not exported.
2429 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2431 (sigprocmask_set, full_mask): Remove; unused.
2432 (wait_debugging): Mark as visible.
2433 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2434 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2436 * syntax.c (syntax_temp): Define only if !__GNUC__.
2438 * sound.c (current_sound_device, current_sound): Now static.
2440 * search.c (searchbufs, searchbuf_head): Now static.
2442 * scroll.c (scroll_cost): Remove; unused.
2443 * dispextern.h (scroll_cost): Remove decl.
2445 * region-cache.h (pp_cache): Mark as externally visible.
2447 * process.c: Make symbols static if they're not exported.
2448 (process_tick, update_tick, create_process, chan_process):
2449 (Vprocess_alist, proc_buffered_char, datagram_access):
2450 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2451 (deactivate_process): Mark defn as static, as well as decl.
2452 * lisp.h (create_process): Remove decl.
2453 * process.h (chan_process, Vprocess_alist): Remove decls.
2455 * print.c: Make symbols static if they're not exported.
2456 (print_depth, new_backquote_output, being_printed, print_buffer):
2457 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2458 (print_interval, print_number_index, initial_stderr_stream):
2460 * lisp.h (Fprinc): Remove decl.
2461 (debug_output_compilation_hack): Mark as externally visible.
2463 * sysdep.c (croak): Move decl from here to syssignal.h.
2464 * syssignal.h (croak): Put it here, so the API can be checked when
2465 'croak' is called from dissociate_if_controlling_tty.
2467 * minibuf.c: Make symbols static if they're not exported.
2468 (minibuf_save_list, choose_minibuf_frame): Now static.
2469 * lisp.h (choose_minibuf_frame): Remove decl.
2471 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2473 * lread.c: Make symbols static if they're not exported.
2474 (read_objects, initial_obarray, oblookup_last_bucket_number):
2476 (make_symbol): Remove; unused.
2477 * lisp.h (initial_obarray, make_symbol): Remove decls.
2479 * keyboard.c: Make symbols static if they're not exported.
2480 (single_kboard, recent_keys_index, total_keys, recent_keys):
2481 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2482 (this_single_command_key_start, echoing, last_auto_save):
2483 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2484 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2485 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2486 (Vlispy_mouse_stem, double_click_count):
2488 (force_auto_save_soon): Define only if SIGDANGER.
2489 (ignore_mouse_drag_p): Now static if
2490 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2491 (print_help): Remove; unused.
2492 (stop_character, last_timer_event): Mark as externally visible.
2493 * keyboard.h (ignore_mouse_drag_p): Declare only if
2494 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2495 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2496 * lisp.h (echoing): Remove decl.
2497 (force_auto_save_soon): Declare only if SIGDANGER.
2498 * xdisp.c (redisplay_window): Simplify code, to make it more
2499 obvious that ignore_mouse_drag_p is not accessed if !defined
2500 USE_GTK && !defined HAVE_NS.
2502 * intervals.c: Make symbols static if they're not exported.
2503 (merge_properties_sticky, merge_interval_right, delete_interval):
2505 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2507 * insdel.c: Make symbols static if they're not exported.
2508 However, leave prepare_to_modify_buffer alone. It's never
2509 called from outside this function, but that appears to be a bug.
2510 (combine_after_change_list, combine_after_change_buffer):
2511 (adjust_after_replace, signal_before_change): Now static.
2512 (adjust_after_replace_noundo): Remove; unused.
2513 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
2514 (signal_before_change): Remove decls.
2516 * indent.c (val_compute_motion, val_vmotion): Now static.
2518 * image.c: Make symbols static if they're not exported.
2519 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2521 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2522 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2524 * fringe.c (standard_bitmaps): Now static.
2525 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2527 * frame.c: Make symbols static if they're not exported.
2528 (x_report_frame_params, make_terminal_frame): Now static.
2529 (get_frame_param): Now static, unless HAVE_NS.
2530 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2531 (x_get_resource_string): Remove; not used.
2532 * frame.h (make_terminal_frame, x_report_frame_params):
2533 (x_get_resource_string); Remove decls.
2534 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2535 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2537 * font.c, fontset.c: Make symbols static if they're not exported.
2538 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2539 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2540 * font.c (font_close_object): Now static.
2541 * font.h (font_close_object): Remove.
2542 * fontset.c (FONTSET_OBJLIST): Remove.
2543 (free_realized_fontset) #if-0 the body, which does nothing.
2544 (face_suitable_for_char_p): #if-0, as it's never called.
2545 * fontset.h (face_suitable_for_char_p): Remove decl.
2546 * xfaces.c (face_at_string_position):
2547 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
2548 since 0 is always ASCII.
2550 * fns.c (weak_hash_tables): Now static.
2552 * fileio.c: Make symbols static if they're not exported.
2553 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2554 (Vwrite_region_annotation_buffers): Now static.
2556 * eval.c: Make symbols static if they're not exported.
2557 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2558 * lisp.h (backtrace_list): Remove decl.
2560 * emacs.c: Make symbols static if they're not exported.
2561 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2562 (fatal_error_code, fatal_error_signal_hook, standard_args):
2564 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2565 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2566 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2567 * lisp.h (fatal_error_signal_hook): Remove decl.
2568 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2570 * editfns.c: Move a (normally-unused) function to its only use.
2571 * editfns.c, lisp.h (get_operating_system_release): Remove.
2572 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2573 worth the hassle of breaking this out.
2575 * xterm.c: Make symbols static if they're not exported.
2576 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2577 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2578 (x_destroy_window, x_delete_display):
2580 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2581 (x_mouse_leave): Remove; unused.
2582 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2583 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2584 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2586 (x_mouse_leave): Declare only if WINDOWSNT.
2587 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2588 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2591 * ftxfont.c: Make symbols static if they're not exported.
2592 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2594 * font.h (ftxfont_driver): Likewise.
2596 * xfns.c: Make symbols static if they're not exported.
2597 (x_last_font_name, x_display_info_for_name):
2598 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2599 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2600 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2601 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2602 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2603 (last_show_tip_args): Now static.
2604 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2605 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2606 (x_screen_planes): Remove; unused.
2607 * dispextern.h (x_screen_planes): Remove decl.
2609 * dispnew.c: Make symbols static if they're not exported.
2610 * dispextern.h (redraw_garbaged_frames, scrolling):
2611 (increment_row_positions): Remove.
2612 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2613 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2615 (redraw_garbaged_frames): Remove; unused.
2617 * xfaces.c: Make symbols static if they're not exported.
2618 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2620 * xterm.h (defined_color): Remove decls.
2621 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2622 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2623 (menu_face_changed_default, defined_color, free_realized_face):
2624 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2625 (ascii_face_of_lisp_face): Remove; unused.
2627 * xdisp.c: Make symbols static if they're not exported.
2628 * dispextern.h (scratch_glyph_row, window_box_edges):
2629 (glyph_to_pixel_coords, set_cursor_from_row):
2630 (get_next_display_element, set_iterator_to_next):
2631 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2632 (show_mouse_face): Remove decls
2633 * frame.h (message_buf_print): Likewise.
2634 * lisp.h (pop_message, set_message, check_point_in_composition):
2636 * xterm.h (set_vertical_scroll_bar): Likewise.
2637 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2638 (message_buf_print, scratch_glyph_row, displayed_buffer):
2639 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2640 (get_next_display_element, show_mouse_face, window_box_edges):
2641 (frame_to_window_pixel_xy, check_point_in_composition):
2642 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2643 (glyph_to_pixel_coords): Remove; unused.
2645 * dired.c (file_name_completion): Now static.
2647 * dbusbind.c (xd_in_read_queued_messages): Now static.
2649 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2650 * data.c (circular_list_error): Remove.
2652 * commands.h (last_point_position, last_point_position_buffer):
2653 (last_point_position_window): Remove decls.
2654 * keyboard.c: Make these variables static.
2656 * coding.h (coding, code_convert_region, encode_coding_gap):
2658 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2659 (iso_code_class, detect_coding, code_convert_region): Now static.
2660 (encode_coding_gap): Remove; unused.
2662 * chartab.c (chartab_chars, chartab_bits): Now static.
2664 * charset.h (charset_iso_8859_1): Remove decl.
2665 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2668 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2669 * ccl.c (Vccl_program_table): Now static.
2670 (check_ccl_update): Remove; unused.
2672 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2673 * category.h: ... from here.
2674 * category.c (check_category_table, set_category_set): Now static.
2676 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2677 * lisp.h: Remove these decls.
2679 * buffer.c (buffer_count): Remove unused var.
2681 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2682 so that it's not optimized away.
2683 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2684 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2685 exported only to the debugger.
2687 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2688 * atimer.h (run_all_atimers): Remove; not exported.
2690 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2691 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2692 was inaccessible from Lisp.
2693 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2694 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2696 alloc.c: Import and export fewer symbols, and remove unused items.
2697 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2699 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2700 it's not optimized away by whole-program optimization.
2701 (message_enable_multibyte, free_misc): Remove.
2702 (catchlist, handlerlist, mark_backtrace):
2703 Declare only if BYTE_MARK_STACK.
2704 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2705 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2706 (message_enable_multibyte): Remove decl.
2707 (free_misc, interval_free_list, float_block, float_block_index):
2708 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2709 (cons_free_list, last_marked_index):
2711 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2712 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2713 (mark_backtrace): Define only if BYTE_MARK_STACK.
2714 * xdisp.c (message_enable_multibyte): Now static.
2716 Declare Lisp_Object Q* variables to be 'static' if not exported.
2717 This makes it easier for human readers (and static analyzers)
2718 to see whether these variables are used from other modules.
2719 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2720 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2721 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2722 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2723 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2724 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2725 * xmenu.c, xselect.c:
2726 Declare Q* vars static if they are not used in other modules.
2727 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2728 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2729 Remove decls of unexported vars.
2730 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2732 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2734 Make Emacs functions such as Fatom 'static' by default.
2735 This makes it easier for human readers (and static analyzers)
2736 to see whether these functions can be called from other modules.
2737 DEFUN now defines a static function. To make the function external
2738 so that it can be used in other C modules, use the new macro DEFUE.
2739 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2740 (Finit_image_library):
2741 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2742 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2743 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2744 Remove decls, since these functions are now static.
2745 (Funintern, Fget_internal_run_time): New decls, since these functions
2746 were already external.
2748 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2749 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2750 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2751 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2752 * keyboard.c, keymap.c, lread.c:
2753 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2754 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2755 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2756 Mark functions with DEFUE instead of DEFUN,
2757 if they are used in other modules.
2758 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2759 decls for now-static functions.
2760 * buffer.h (Fdelete_overlay): Remove decl.
2761 * callproc.c (Fgetenv_internal): Mark as internal.
2762 * composite.c (Fremove_list_of_text_properties): Remove decl.
2763 (Fcomposition_get_gstring): New forward static decl.
2764 * composite.h (Fcomposite_get_gstring): Remove decl.
2765 * dired.c (Ffile_attributes): New forward static decl.
2766 * doc.c (Fdocumntation_property): New forward static decl.
2767 * eval.c (Ffetch_bytecode): New forward static decl.
2768 (Funintern): Remove extern decl; now in .h file where it belongs.
2769 * fileio.c (Fmake_symbolic_link): New forward static decl.
2770 * image.c (Finit_image_library): New forward static decl.
2771 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2772 * intervals.h (Fprevious_property_change):
2773 (Fremove_list_of_text_properties): Remove decls.
2774 * keyboard.c (Fthis_command_keys): Remove decl.
2775 (Fcommand_execute): New forward static decl.
2776 * keymap.c (Flookup_key): New forward static decl.
2777 (Fcopy_keymap): Now static.
2778 * keymap.h (Flookup_key): Remove decl.
2779 * process.c (Fget_process): New forward static decl.
2780 (Fprocess_datagram_address): Mark as internal.
2781 * syntax.c (Fsyntax_table_p): New forward static decl.
2782 (skip_chars): Remove duplicate decl.
2783 * textprop.c (Fprevious_property_change): New forward static decl.
2784 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2786 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2787 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2789 * editfns.c (Fformat): Remove unreachable code.
2791 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2793 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2796 2011-04-13 Eli Zaretskii <eliz@gnu.org>
2798 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2799 when at ZV. (Bug#8487)
2801 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2803 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2805 * keyboard.c (parse_tool_bar_item): Likewise.
2806 * sound.c (sound_cleanup, alsa_close): Likewise.
2807 * termcap.c (tgetent): Likewise.
2808 * xfns.c (x_default_font_parameter): Likewise.
2809 * xsettings.c (read_and_apply_settings): Likewise.
2811 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2812 (overrun_check_free): Protoize.
2814 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2816 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2817 since callers should never pass a negative size.
2818 Change the signature to match that of plain 'read' and 'write'; see
2819 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2820 * lisp.h: Update prototypes of emacs_write and emacs_read.
2822 2011-04-11 Eli Zaretskii <eliz@gnu.org>
2824 * xdisp.c (redisplay_window): Don't try to determine the character
2825 position of the scroll margin if the window start point w->startp
2826 is outside the buffer's accessible region. (Bug#8468)
2828 2011-04-10 Eli Zaretskii <eliz@gnu.org>
2830 Fix write-region and its subroutines for buffers > 2GB.
2831 * fileio.c (a_write, e_write): Modify declaration of arguments and
2832 local variables to support buffers larger than 2GB.
2833 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2835 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2836 argument, local variables, and return value.
2838 * lisp.h: Update prototypes of emacs_write and emacs_read.
2840 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2842 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
2844 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2846 Fix more problems found by GCC 4.6.0's static checks.
2848 * xdisp.c (vmessage): Use a better test for character truncation.
2850 * charset.c (load_charset_map): <, not <=, for optimization,
2851 and to avoid potential problems with integer overflow.
2852 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
2853 * casetab.c (set_identity, shuffle): Likewise.
2854 * editfns.c (Fformat): Likewise.
2855 * syntax.c (skip_chars): Likewise.
2857 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2858 This also lets GCC 4.6.0 generate slightly better loop code.
2860 * callint.c (Fcall_interactively): <, not <=, for optimization.
2861 (Fcall_interactively): Count the number of arguments produced,
2862 not the number of arguments given. This is simpler and lets GCC
2863 4.6.0 generate slightly better code.
2865 * ftfont.c: Distingish more carefully between FcChar8 and char.
2866 The previous code passed unsigned char * to a functions like
2867 strlen and xstrcasecmp that expect char *, which does not
2868 conform to the C standard.
2869 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2870 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2871 char * when the C standard requires it.
2873 * keyboard.c (read_char): Remove unused var.
2875 * eval.c: Port to Windows vsnprintf (Bug#8435).
2877 (SIZE_MAX): Define if the headers do not.
2878 (verror): Do not give up if vsnprintf returns a negative count.
2879 Instead, grow the buffer. This ports to Windows vsnprintf, which
2880 does not conform to C99. Problem reported by Eli Zaretskii.
2881 Also, simplify the allocation scheme, by avoiding the need for
2882 calling realloc, and removing the ALLOCATED variable.
2884 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2886 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2887 But keep the doprint source code for now, as we might revamp it
2888 and use it again (Bug#8435).
2889 * lisp.h (doprnt): Remove.
2890 * Makefile.in (base_obj): Remove doprnt.o.
2891 * deps.mk (doprnt.o): Remove.
2893 error: Print 32- and 64-bit integers portably (Bug#8435).
2894 Without this change, on typical 64-bit hosts error ("...%d...", N)
2895 was used to print both 32- and 64-bit integers N, which relied on
2897 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2899 * lisp.h (error, verror): Mark as printf-like functions.
2900 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2901 Report overflow in size calculations when allocating printf buffer.
2902 Do not truncate output string at its first null byte.
2903 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2904 Truncate the output at a character boundary, since vsnprintf does not
2906 * charset.c (check_iso_charset_parameter): Convert internal
2907 character to string before calling 'error', since %c now has the
2909 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2910 overflow when computing char to be passed to 'error'. Do not
2911 pass Lisp_Object to 'error'; pass the integer instead.
2912 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2913 formatted with plain %d.
2915 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2917 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2919 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2921 * xterm.c (x_catch_errors): Remove duplicate declaration.
2923 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2925 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2927 2011-04-10 Jim Meyering <meyering@redhat.com>
2929 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2930 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2931 return ssize_t not "int", and use size_t as the buffer length.
2932 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2933 * gnutls.h: Update declarations.
2934 * process.c (read_process_output): Use ssize_t, to match.
2935 (send_process): Likewise.
2937 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2939 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2941 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2943 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2944 Use unsigned char, to match FcChar8 type definition.
2946 * xterm.c (handle_one_xevent):
2947 * xmenu.c (create_and_show_popup_menu):
2948 * xselect.c (x_decline_selection_request)
2949 (x_reply_selection_request): Avoid type-punned deref of X events.
2951 2011-04-09 Eli Zaretskii <eliz@gnu.org>
2953 Fix some uses of `int' instead of EMACS_INT.
2954 * search.c (string_match_1, fast_string_match)
2955 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2956 (scan_buffer, find_next_newline_no_quit)
2957 (find_before_next_newline, search_command, Freplace_match)
2958 (Fmatch_data): Make some `int' variables be EMACS_INT.
2960 * xdisp.c (display_count_lines): 3rd argument and return value now
2961 EMACS_INT. All callers changed.
2962 (pint2hrstr): Last argument is now EMACS_INT.
2964 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2965 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2966 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2967 (decode_coding_utf_16, decode_coding_emacs_mule)
2968 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2969 (decode_coding_ccl, decode_coding_charset)
2970 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2971 (decode_coding_iso_2022, decode_coding_emacs_mule)
2972 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2973 <char_offset, last_offset>: Declare EMACS_INT.
2974 (encode_coding_utf_8, encode_coding_utf_16)
2975 (encode_coding_emacs_mule, encode_invocation_designation)
2976 (encode_designation_at_bol, encode_coding_iso_2022)
2977 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2978 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2980 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2981 (encode_invocation_designation): Last argument P_NCHARS is now
2983 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2984 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2986 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2989 * ccl.c (Fccl_execute_on_string): Declare some variables
2992 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
2994 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2996 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2998 * process.c (Fformat_network_address): Doc fix.
3000 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3002 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3004 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3006 * keyboard.c (read_char): Call Lisp function help-form-show,
3007 instead of using internal_with_output_to_temp_buffer.
3008 (Qhelp_form_show): New var.
3009 (syms_of_keyboard): Use DEFSYM macro.
3011 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3013 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3015 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3017 * process.c (Flist_processes): Remove to Lisp.
3018 (list_processes_1): Delete.
3020 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3022 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3024 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3026 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3028 Fix more problems found by GCC 4.6.0's static checks.
3030 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3032 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3034 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3036 * xdisp.c (vmessage): Mark as a printf-like function.
3038 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3040 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3042 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3043 printf-like functions.
3044 (tiff_load): Add casts to remove these marks before passing them
3045 to system-supplied API.
3047 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3049 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3050 This avoids several warnings with gcc -Wstrict-overflow.
3051 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3052 directly, rather than having caller test rule sign. This avoids
3053 some unnecessary tests.
3054 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3055 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3056 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3058 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3059 (xfont_open): Avoid unnecessary tests.
3061 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3063 * composite.h, composite.c (composition_gstring_put_cache):
3064 Use EMACS_INT, not int, for length.
3066 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3067 breaking out part of COMPOSITION_DECODE_RULE.
3068 (COMPOSITION_DECODE_RULE): Use it.
3069 * composite.c (get_composition_id): Remove unused local vars,
3070 by using the new macro.
3072 * textprop.c (set_text_properties_1): Change while to do-while,
3073 since the condition is always true at first.
3075 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3076 (interval_deletion_adjustment): Return unsigned value.
3079 * process.c (list_processes_1, create_pty, read_process_output):
3080 (exec_sentinel): Remove vars that were set but not used.
3081 (create_pty): Remove unnecessary "volatile"s.
3082 (Fnetwork_interface_info): Avoid possibility of int overflow.
3083 (read_process_output): Do adaptive read buffering even if carryover.
3084 (read_process_output): Simplify nbytes computation if buffered.
3086 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3088 * syntax.c (scan_words): Remove var that was set but not used.
3089 (update_syntax_table): Use unsigned instead of int.
3091 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3092 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3093 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3095 * print.c (print_error_message): Avoid int overflow.
3097 * font.c (font_list_entities): Redo for clarity,
3098 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3100 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3101 (font_score): Avoid potential overflow in diff calculation.
3103 * fns.c (substring_both): Remove var that is set but not used.
3104 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3106 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3108 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3109 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3110 can always succeed if overflow has undefined behavior.
3112 * search.c (boyer_moore, wordify): Remove vars set but not used.
3113 (wordify): Omit three unnecessary tests.
3115 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3116 All callers changed. This avoids the need for an unused var.
3118 * casefiddle.c (casify_region): Remove var that is set but not used.
3120 * dired.c (file_name_completion): Remove var that is set but not used.
3122 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3124 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
3125 (Finsert_file_contents): Remove unnecessary code checking fd.
3127 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3128 Check for integer overflow on size calculations.
3130 * buffer.c (Fprevious_overlay_change): Remove var that is set
3133 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3134 Remove vars that are set but not used.
3135 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
3136 (timer_check_2): Mark vars as initialized.
3138 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3140 * image.c (lookup_image): Remove var that is set but not used.
3141 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
3143 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3144 that are set but not used.
3146 * xfns.c (make_invisible_cursor): Don't return garbage
3147 if XCreateBitmapFromData fails (Bug#8410).
3149 * xselect.c (x_get_local_selection, x_handle_property_notify):
3150 Remove vars that are set but not used.
3152 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
3153 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
3155 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3156 Remove var that is set but not used.
3157 (scroll_bar_windows_size): Now size_t, not int.
3158 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3161 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3162 (map_tty_color) [!defined MSDOS]: Likewise.
3164 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3166 * coding.c: Remove vars that are set but not used.
3167 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3168 All callers changed.
3169 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3170 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3171 (decode_coding_charset): Remove vars that are set but not used.
3173 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3174 that is set but not used.
3176 * print.c (print_object): Remove var that is set but not used.
3178 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
3179 The gnulib version avoids calling malloc in the usual case,
3180 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3181 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3182 * filelock.c (current_lock_owner): Likewise.
3183 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3184 * sysdep.c: Include allocator.h, careadlinkat.h.
3185 (emacs_no_realloc_allocator): New static constant.
3186 (emacs_readlink): New function.
3187 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3188 ../lib/careadlinkat.h.
3190 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3192 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3193 first non-nil return value).
3195 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3197 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3198 if not defined (Bug#8403).
3200 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3202 * xdisp.c (display_count_lines): Remove parameter `start',
3203 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3204 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3205 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3206 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3207 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3208 and thereabouts. All callers changed.
3209 (get_per_char_metric): Remove parameter `f', unused since
3210 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3212 2011-04-02 Jim Meyering <meyering@redhat.com>
3214 do not dereference NULL upon failed strdup
3215 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3216 (ns_get_family): Likewise.
3218 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3220 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3222 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3224 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3227 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3229 Add lexical binding.
3231 * window.c (Ftemp_output_buffer_show): New fun.
3232 (Fsave_window_excursion):
3233 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3235 * lread.c (lisp_file_lexically_bound_p): New function.
3236 (Fload): Bind Qlexical_binding.
3237 (readevalloop): Remove `evalfun' arg.
3238 Bind Qinternal_interpreter_environment.
3239 (Feval_buffer): Bind Qlexical_binding.
3240 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3242 (syms_of_lread): Declare `lexical-binding'.
3244 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3246 * keyboard.c (eval_dyn): New fun.
3247 (menu_item_eval_property): Use it.
3249 * image.c (parse_image_spec): Use Ffunctionp.
3251 * fns.c (concat, mapcar1): Accept byte-code-functions.
3253 * eval.c (Fsetq): Handle lexical vars.
3254 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3255 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3256 (FletX, Flet): Obey lexical binding.
3257 (Fcommandp): Handle closures.
3258 (Feval): New `lexical' arg.
3259 (eval_sub): New function extracted from Feval. Use it almost
3260 everywhere where Feval was used. Look up vars in lexical env.
3262 (Ffunctionp): Move from subr.el.
3263 (Ffuncall): Handle closures.
3264 (apply_lambda): Remove `eval_flags'.
3265 (funcall_lambda): Handle closures and new byte-code-functions.
3266 (Fspecial_variable_p): New function.
3267 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3268 but without exporting it to Lisp.
3270 * doc.c (Fdocumentation, store_function_docstring):
3271 * data.c (Finteractive_form): Handle closures.
3273 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3276 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3278 (exec_byte_code): New function extracted from Fbyte_code to handle new
3279 calling convention for byte-code-functions. Add new byte-codes.
3281 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
3283 * alloc.c (Fmake_symbol): Init new `declared_special' field.
3285 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3287 * xdisp.c (redisplay_internal): Fix prototype.
3289 2011-03-31 Eli Zaretskii <eliz@gnu.org>
3291 * xdisp.c (SCROLL_LIMIT): New macro.
3292 (try_scrolling): Use it when setting scroll_limit.
3293 Limit scrolling to 100 screen lines.
3294 (redisplay_window): Even when falling back on "recentering",
3295 position point in the window according to scroll-conservatively,
3296 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3298 (try_scrolling): When point is above the window, allow searching
3299 as far as scroll_max, or one screenful, to compute vertical
3300 distance from PT to the scroll margin position. This prevents
3301 try_scrolling from unnecessarily failing when
3302 scroll-conservatively is set to a value slightly larger than the
3303 window height. Clean up the case of PT below the margin at bottom
3304 of window: scroll_max can no longer be INT_MAX. When aggressive
3305 scrolling is in use, don't let point enter the opposite scroll
3306 margin as result of the scroll.
3307 (syms_of_xdisp) <scroll-conservatively>: Document the
3308 threshold of 100 lines for never-recentering scrolling.
3310 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3312 * dispextern.h (move_it_by_lines):
3313 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3314 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3315 (message_log_check_duplicate): Remove parameters `prev_bol' and
3316 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3317 (redisplay_internal): Remove parameter `preserve_echo_area',
3318 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3320 * indent.c (Fvertical_motion):
3321 * window.c (window_scroll_pixel_based, Frecenter):
3322 Don't pass `need_y_p' to `move_it_by_lines'.
3324 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3326 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3327 steal a few bits to be more compact.
3328 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3329 Remove unneeded casts.
3331 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3333 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3335 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3336 binding" message (bug#7967).
3338 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3340 Fix more problems found by GCC 4.6.0's static checks.
3342 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3343 Remove unused local var.
3345 * editfns.c (Fmessage_box): Remove unused local var.
3347 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3348 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3349 Omit unused local vars.
3350 * window.c (shrink_windows): Omit unused local var.
3351 * menu.c (digest_single_submenu): Omit unused local var.
3352 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3353 Omit unused local var.
3355 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3356 Don't assume string length fits in int.
3357 (keyremap_step, read_key_sequence): Use size_t for sizes.
3358 (read_key_sequence): Don't check last_real_key_start redundantly.
3360 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3361 instead of alloca (Bug#8344).
3363 * eval.c (Fbacktrace): Don't assume nargs fits in int.
3364 (Fbacktrace_frame): Don't assume nframes fits in int.
3366 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3368 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3371 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3373 * cm.c (calccost): Turn while-do into do-while, for clarity.
3375 * keyboard.c (syms_of_keyboard): Use the same style as later
3376 in this function when indexing through an array. This also
3377 works around GCC bug 48267.
3379 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3381 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3383 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3384 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3386 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3387 This avoids undefined behavior on integer overflow, and is a bit
3388 more convenient anyway since it is compared to a size_t variable.
3390 Variadic C functions now count arguments with size_t, not int.
3391 This avoids an unnecessary limitation on 64-bit machines, which
3392 caused (substring ...) to crash on large vectors (Bug#8344).
3393 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3394 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
3395 All variadic functions and their callers changed accordingly.
3396 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3397 * data.c (arith_driver, float_arith_driver): Likewise.
3398 * editfns.c (general_insert_function): Likewise.
3399 * eval.c (struct backtrace.nargs, interactive_p)
3400 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3401 (funcall_lambda, mark_backtrace): Likewise.
3402 * fns.c (concat): Likewise.
3403 * frame.c (x_set_frame_parameters): Likewise.
3404 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3405 0 if not found, not -1. All callers changed.
3407 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3408 (stack_copy_size): Now size_t, not int.
3409 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3411 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3413 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3414 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3415 All callers changed.
3417 * lisp.h (multibyte_char_to_unibyte):
3418 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3419 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3420 * character.h (CHAR_TO_BYTE8):
3421 * cmds.c (internal_self_insert):
3422 * editfns.c (general_insert_function):
3423 * keymap.c (push_key_description):
3424 * search.c (Freplace_match):
3425 * xdisp.c (message_dolog, set_message_1): All callers changed.
3427 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3429 * keyboard.c (safe_run_hook_funcall): New function.
3430 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3431 don't set the hook to nil, but remove the offending function instead.
3432 (Qcommand_hook_internal): Remove, unused.
3433 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3434 Vcommand_hook_internal.
3436 * eval.c (enum run_hooks_condition): Remove.
3437 (funcall_nil, funcall_not): New functions.
3438 (run_hook_with_args): Call each function through a `funcall' argument.
3439 Remove `cond' argument, now redundant.
3440 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3441 (Frun_hook_with_args_until_failure): Adjust accordingly.
3442 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3444 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3446 * dispextern.h (string_buffer_position): Remove declaration.
3448 * print.c (strout): Remove parameter `multibyte', unused since
3449 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3451 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3452 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3453 All callers changed.
3455 * w32.c (_wsa_errlist): Use braces for struct initializers.
3457 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3458 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3459 All callers changed.
3460 (string_buffer_position): Likewise. Also, make static (it's never
3461 used outside xdisp.c).
3462 (cursor_row_p): Remove parameter `w', unused since
3463 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3464 (decode_mode_spec): Remove parameter `precision', introduced during
3465 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3466 All callers changed.
3468 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3470 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3472 2011-03-27 Anders Lindgren <andlind@gmail.com>
3474 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3475 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3476 (ns_update_auto_hide_menu_bar): New functions.
3477 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3478 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3479 ns_constrain_all_frames.
3480 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3481 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3483 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3485 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3487 2011-03-27 Glenn Morris <rgm@gnu.org>
3489 * syssignal.h: Replace RETSIGTYPE with void.
3490 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3491 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3492 Replace SIGTYPE with void everywhere.
3493 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3494 * s/template.h (SIGTYPE): Remove commented out definition.
3496 2011-03-26 Eli Zaretskii <eliz@gnu.org>
3498 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3499 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3501 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
3503 * w32.c (read_unc_volume): Use parameter `henum', instead of
3504 global variable `wget_enum_handle'.
3506 * keymap.c (describe_vector): Remove parameters `indices' and
3507 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3508 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3510 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3512 * keyboard.c (timer_check): Remove parameter `do_it_now',
3513 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3514 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3515 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3517 * keyboard.c (read_char):
3518 * w32menu.c (w32_menu_display_help):
3519 * xmenu.c (show_help_event, menu_help_callback):
3520 Adjust calls to `show_help_echo'.
3522 * gtkutil.c (xg_maybe_add_timer):
3523 * keyboard.c (readable_events):
3524 * process.c (wait_reading_process_output):
3525 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3527 * insdel.c (adjust_markers_gap_motion):
3528 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3529 (gap_left, gap_right): Don't call it.
3531 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
3533 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3534 incurred during fontification.
3536 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3538 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3539 (DEFVAR_PER_BUFFER): Don't pass it.
3541 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3542 (scrolling_window): Don't pass it.
3544 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3546 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3548 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3550 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3551 of variables specific to SELinux and computation of `encoded_absname'.
3553 * image.c (XPutPixel): Remove unused variable `height'.
3555 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3557 * unexw32.c (get_section_info): Remove unused variable `section'.
3559 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3560 (system_process_attributes): Remove unused variable `sess'.
3561 (sys_read): Remove unused variable `err'.
3563 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3564 (w32_wnd_proc): Remove unused variable `isdead'.
3565 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3566 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3567 (x_create_tip_frame): Remove unused variable `tem'.
3569 * w32inevt.c (w32_console_read_socket):
3570 Remove unused variable `no_events'.
3572 * w32term.c (x_draw_composite_glyph_string_foreground):
3573 Remove unused variable `width'.
3575 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
3577 * w32term.c (x_set_glyph_string_clipping):
3578 Don't pass uninitialized region to CombineRgn.
3580 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
3582 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3583 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3584 (Fx_close_connection): Remove unused variable `i'.
3586 * w32font.c (w32font_draw): Return number of glyphs.
3587 (w32font_open_internal): Remove unused variable `i'.
3588 (w32font_driver): Add missing initializer.
3590 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3591 (fill_in_menu): Remove unused variable `items_added'.
3593 * w32term.c (last_mouse_press_frame): Remove static global variable.
3594 (w32_clip_to_row): Remove unused variable `f'.
3595 (x_delete_terminal): Remove unused variable `i'.
3597 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3598 (NOTHING): Remove unused static global variable.
3599 (uniscribe_check_otf): Remove unused variable `table'.
3600 (uniscribe_font_driver): Add missing initializers.
3602 2011-03-23 Julien Danjou <julien@danjou.info>
3604 * term.c (Fsuspend_tty, Fresume_tty):
3605 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3606 * window.c (temp_output_buffer_show):
3607 * insdel.c (signal_before_change):
3608 * frame.c (Fhandle_switch_frame):
3609 * fileio.c (Fdo_auto_save):
3610 * emacs.c (Fkill_emacs):
3611 * editfns.c (save_excursion_restore):
3612 * cmds.c (internal_self_insert):
3613 * callint.c (Fcall_interactively):
3614 * buffer.c (Fkill_all_local_variables):
3615 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3617 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
3618 unconditionnaly since it does the check itself.
3620 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
3622 Fix more problems found by GCC 4.5.2's static checks.
3624 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3625 the first time through the loop, since we know p0 < p1 then.
3626 This also avoids a gcc -Wstrict-overflow warning.
3628 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3629 leading to a memory leak, possible in functions like
3630 load_charset_map_from_file that can allocate an unbounded number
3631 of objects (Bug#8318).
3633 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3634 that could (at least in theory) be that large.
3636 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3637 This is less likely to overflow, and avoids undefined behavior if
3638 overflow does occur. All callers changed. Use strtoul to scan
3639 for the unsigned long integer.
3640 (pint2hrstr): Simplify and tune code slightly.
3641 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
3643 * scroll.c (do_scrolling): Work around GCC bug 48228.
3644 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3646 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3647 This also avoids a warning with gcc -Wstrict-overflow.
3648 (validate_x_resource_name): Simplify count usage.
3649 This also avoids a warning with gcc -Wstrict-overflow.
3651 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3654 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
3656 * process.c (Fmake_network_process): Use socklen_t, not int,
3657 where POSIX says socklen_t is required in portable programs.
3658 This fixes a porting bug on hosts like 64-bit HP-UX, where
3659 socklen_t is wider than int (Bug#8277).
3660 (Fmake_network_process, server_accept_connection):
3661 (wait_reading_process_output, read_process_output):
3664 * process.c: Rename or move locals to avoid shadowing.
3665 (list_processes_1, Fmake_network_process):
3666 (read_process_output_error_handler, exec_sentinel_error_handler):
3667 Rename or move locals.
3668 (Fmake_network_process): Define label "retry_connect" only if needed.
3669 (Fnetwork_interface_info): Fix pointer signedness.
3670 (process_send_signal): Add cast to avoid pointer signedness problem.
3671 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
3672 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
3674 Make tparam.h and terminfo.c consistent.
3675 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3676 Include tparam.h instead, since it declares them.
3677 * cm.h (PC): Remove extern decl; tparam.h now does this.
3678 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3679 * terminfo.c: Include tparam.h, to check interfaces.
3680 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3681 (tparam): Adjust signature to match interface in tparam.h;
3682 this removes some undefined behavior. Check that outstring and len
3683 are zero, which they always are with Emacs.
3684 * tparam.h (PC, BC, UP): New extern decls.
3686 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3687 (xftfont_open): Rename locals to avoid shadowing.
3689 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3690 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3691 (OTF_TAG_SYM): Omit macro if not needed.
3692 (ftfont_list): Remove unused local.
3693 (get_adstyle_property, ftfont_pattern_entity):
3694 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3695 Rename locals to avoid shadowing.
3697 * xfont.c (xfont_list_family): Mark var as initialized.
3699 * xml.c (make_dom): Now static.
3701 * composite.c (composition_compute_stop_pos): Rename local to
3703 (composition_reseat_it): Remove unused locals.
3704 (find_automatic_composition, composition_adjust_point): Likewise.
3705 (composition_update_it): Mark var as initialized.
3706 (find_automatic_composition): Mark vars as initialized,
3707 with a FIXME (Bug#8290).
3709 character.h: Rename locals to avoid shadowing.
3710 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3711 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3712 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3713 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3716 * textprop.c (property_change_between_p): Remove; unused.
3718 * intervals.c (interval_start_pos): Now static.
3720 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3722 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3723 Rename locals to avoid shadowing.
3725 * sound.c (wav_play, au_play, Fplay_sound_internal):
3726 Fix pointer signedness.
3727 (alsa_choose_format): Remove unused local var.
3728 (wav_play): Initialize a variable to 0, to prevent undefined
3729 behavior (Bug#8278).
3731 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3733 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3735 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3736 clobbering (Bug#8298).
3737 * sysdep.c (sys_subshell): Likewise.
3738 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
3740 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3741 This should get cleaned up, so that child_setup has the
3742 same signature on all platforms.
3744 * callproc.c (call_process_cleanup): Now static.
3745 (relocate_fd): Rename locals to avoid shadowing.
3747 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
3749 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3750 not to be necessary, and produces flickering.
3752 2011-03-20 Glenn Morris <rgm@gnu.org>
3754 * config.in: Remove file.
3756 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
3758 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3759 are now in src/globals.h.
3760 (syms_of_minibuf): Remove spurious & from previous change.
3762 2011-03-20 Leo <sdl.web@gmail.com>
3764 * minibuf.c (completing-read-function): New variable.
3765 (completing-read-default): Rename from completing-read.
3766 (completing-read): Call completing-read-function.
3768 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3770 * xfaces.c (Fx_load_color_file):
3771 Read color file from absolute filename (bug#8250).
3773 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3775 * makefile.w32-in: Update dependencies.
3777 2011-03-17 Eli Zaretskii <eliz@gnu.org>
3779 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3781 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3783 Fix more problems found by GCC 4.5.2's static checks.
3785 * process.c (make_serial_process_unwind, send_process_trap):
3786 (sigchld_handler): Now static.
3788 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3789 That way, the code declares only the vars that it needs.
3790 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3791 * s/cygwin.h (PTY_ITERATION): Likewise.
3792 * s/darwin.h (PTY_ITERATION): Likewise.
3793 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3795 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3796 * process.c (allocate_pty): Don't declare stb unless it's needed.
3798 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
3799 (CONSTANTLIM): Remove; unused.
3800 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3801 Define only if needed.
3803 * unexelf.c (unexec): Name an expression,
3804 to avoid gcc -Wbad-function-cast warning.
3805 Use a different way to cause a compilation error if anyone uses
3806 n rather than nn, a way that does not involve shadowing.
3807 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
3809 * deps.mk (unexalpha.o): Remove; unused.
3811 New file unexec.h, the (simple) interface for unexec (Bug#8267).
3812 * unexec.h: New file.
3813 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3814 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3816 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3817 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3818 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
3819 Change as necessary to match prototype in unexec.h.
3821 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3823 (back_comment, skip_chars): Mark vars as initialized.
3825 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3826 Rename locals to avoid shadowing.
3828 * lread.c (read1): Rewrite so as not to use empty "else".
3829 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
3831 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3833 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3834 warning when compiling print.c.
3836 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3837 instead of using an uninitialized var.
3838 (font_sort_entities): Mark var as initialized.
3840 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3842 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3843 pointers to constants.
3844 (font_parse_fcname): Remove unused vars.
3845 (font_delete_unmatched): Now static.
3846 (font_get_spec): Remove; unused.
3847 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3848 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3849 Rename or move locals to avoid shadowing.
3851 * fns.c (require_nesting_list, require_unwind): Now static.
3852 (Ffillarray): Rename locals to avoid shadowing.
3854 * floatfns.c (domain_error2): Define only if needed.
3855 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
3857 * alloc.c (mark_backtrace): Move decl from here ...
3858 * lisp.h: ... to here, so that it can be checked.
3860 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
3861 (Fdefvar): Rewrite so as not to use empty "else".
3862 (lisp_indirect_variable): Name an expression,
3863 to avoid gcc -Wbad-function-cast warning.
3864 (Fdefvar): Rename locals to avoid shadowing.
3866 * callint.c (quotify_arg, quotify_args): Now static.
3867 (Fcall_interactively): Rename locals to avoid shadowing.
3868 Use const pointer when appropriate.
3870 * lisp.h (get_system_name, get_operating_system_release):
3871 Move decls here, to check interfaces.
3872 * process.c (get_operating_system_release): Move decl to lisp.h.
3873 * xrdb.c (get_system_name): Likewise.
3874 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3875 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3876 some of which prompt warnings from gcc -Wbad-function-cast.
3877 (Fformat_time_string, Fencode_time, Finsert_char):
3878 (Ftranslate_region_internal, Fformat):
3879 Rename or remove local vars to avoid shadowing.
3880 (Ftranslate_region_internal): Mark var as initialized.
3882 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3885 * lisp.h (eassert): Check that the argument compiles, even if
3886 ENABLE_CHECKING is not defined.
3888 * data.c (Findirect_variable): Name an expression, to avoid
3889 gcc -Wbad-function-cast warning.
3890 (default_value, arithcompare, arith_driver, arith_error): Now static.
3891 (store_symval_forwarding): Rename local to avoid shadowing.
3892 (Fmake_variable_buffer_local, Fmake_local_variable):
3893 Mark variables as initialized.
3894 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
3896 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
3897 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3898 Rename locals to avoid shadowing.
3899 (mark_stack): Move local variables into the #ifdef region where
3901 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3902 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3904 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3905 (GC_STRING_CHARS): Remove; not used.
3906 (Fmemory_limit): Cast sbrk's returned value to char *.
3908 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3909 avoids undefined behavior in theory.
3911 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3913 Use functions, not macros, for up- and down-casing (Bug#8254).
3914 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3915 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3916 to use the following functions instead of these macros.
3917 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3918 EMACS_INT, since callers assume the returned value fits in int.
3919 (upcase1): Likewise, for UPCASE_TABLE.
3920 (uppercasep, lowercasep, upcase): New static inline functions.
3921 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
3922 the race-condition problem in the old DOWNCASE.
3924 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3925 Rename locals to avoid shadowing.
3926 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
3927 (regex_compile, re_search_2, re_match_2_internal):
3928 Remove unused local vars.
3929 (FREE_VAR): Rewrite so as not to use empty "else",
3930 which gcc can warn about.
3931 (regex_compile, re_match_2_internal): Mark locals as initialized.
3932 (RETALLOC_IF): Define only if needed.
3933 (WORDCHAR_P): Likewise. This one is never needed, but is used
3934 only in a comment talking about a compiler bug, so put inside
3935 the #if 0 of that comment.
3936 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3937 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3940 * search.c (boyer_moore): Rename locals to avoid shadowing.
3941 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3942 (PREV_CHAR_BOUNDARY): Likewise.
3944 * search.c (simple_search): Remove unused var.
3946 * dired.c (compile_pattern): Move decl from here ...
3947 * lisp.h: ... to here, so that it can be checked.
3948 (struct re_registers): New forward decl.
3950 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3952 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3954 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3955 Rename locals to avoid shadowing.
3956 (Fvertical_motion): Mark locals as initialized.
3958 * casefiddle.c (casify_object, casify_region): Now static.
3959 (casify_region): Mark local as initialized.
3961 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3963 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3964 New macros, so that the caller can use some names other than
3965 gcpro1, gcpro2, etc.
3966 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3968 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3969 argument, for consistency with GCPRO2_VAR, etc: it is now the
3970 prefix of the variable, not the variable itself. All uses
3972 * dired.c (directory_files_internal, file_name_completion):
3973 Rename locals to avoid shadowing.
3975 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3976 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3977 dired.c's scmp function, had undefined behavior.
3978 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3979 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3980 * buffer.h: ... to here, because these macros use current_buffer,
3981 and the new implementation with inline functions needs to have
3982 current_buffer in scope now, rather than later when the macros
3984 (downcase, upcase1): New static inline functions.
3985 (DOWNCASE, UPCASE1): Reimplement using these functions.
3986 This avoids undefined behavior in expressions like
3987 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3988 from race conditions in accessing the global variables
3989 case_temp1 and case_temp2.
3990 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3991 * lisp.h (case_temp1, case_temp2): Remove their decls.
3992 * character.h (ASCII_CHAR_P): Move from here ...
3993 * lisp.h: ... to here, so that the inline functions mentioned
3996 * dired.c (directory_files_internal_unwind): Now static.
3998 * fileio.c (file_name_as_directory, directory_file_name):
3999 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4001 (file_name_as_directory): Use const pointers when appropriate.
4002 (Fexpand_file_name): Likewise. In particular, newdir might
4003 point at constant storage, so make it a const pointer.
4004 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4005 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4007 (Fset_file_times, Finsert_file_contents, auto_save_error):
4008 Rename locals to avoid shadowing.
4010 * minibuf.c (choose_minibuf_frame_1): Now static.
4011 (Ftry_completion, Fall_completions): Rename or remove locals
4014 * marker.c (bytepos_to_charpos): Remove; unused.
4016 * lisp.h (verify_bytepos, count_markers): New decls,
4017 so that gcc does not warn that these functions aren't declared.
4019 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4020 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4021 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4022 (copy_text): Remove unused local var.
4024 * filelock.c (within_one_second): Now static.
4025 (lock_file_1): Rename local to avoid shadowing.
4027 * buffer.c (fix_overlays_before): Mark locals as initialized.
4028 (fix_start_end_in_overlays): Likewise. This function should be
4029 simplified by using pointers-to-pointers, but that's a different
4031 (switch_to_buffer_1): Now static.
4032 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4033 (report_overlay_modification): Rename locals to avoid shadowing.
4035 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4036 Fix pointer signedness issue.
4037 (sys_subshell): Mark local as volatile if checking for lint,
4038 to suppress a gcc -Wclobbered warning that does not seem to be right.
4039 (MAXPATHLEN): Define only if needed.
4041 * process.c (serial_open, serial_configure): Move decls from here ...
4042 * systty.h: ... to here, so that they can be checked.
4044 * fns.c (get_random, seed_random): Move extern decls from here ...
4045 * lisp.h: ... to here, so that they can be checked.
4047 * sysdep.c (reset_io): Now static.
4048 (wait_for_termination_signal): Remove; unused.
4050 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4051 (copy_keymap_item, append_key, push_text_char_description):
4053 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4054 (DENSE_TABLE_SIZE): Remove; unused.
4055 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4056 (describe_map_tree):
4057 Rename locals to avoid shadowing.
4059 * keyboard.c: Declare functions static if they are not used elsewhere.
4060 (echo_char, echo_dash, cmd_error, top_level_2):
4061 (poll_for_input, handle_async_input): Now static.
4062 (read_char, kbd_buffer_get_event, make_lispy_position):
4063 (make_lispy_event, make_lispy_movement, apply_modifiers):
4064 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4065 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4066 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4067 (read_key_sequence, read_char): Mark locals as initialized.
4068 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4070 * keyboard.h (make_ctrl_char): New decl.
4071 (mark_kboards): Move decl here ...
4072 * alloc.c (mark_kboards): ... from here.
4074 * lisp.h (force_auto_save_soon): New decl.
4076 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4077 (DEFINE_DUMMY_FUNCTION): New macro.
4078 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4080 (main): Add casts to avoid warnings
4081 if GCC considers string literals to be constants.
4083 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4085 * dbusbind.c: Pointer signedness fixes.
4086 (xd_signature, xd_append_arg, xd_initialize):
4087 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4088 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4089 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4090 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4092 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4093 if GCC considers string literals to be constants.
4094 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4096 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4098 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4099 (print_preprocess, print_object): New macro to fix last change.
4101 * print.c (print_preprocess): Don't forget font objects.
4103 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
4105 * emacs.c (USAGE3): Doc fixes.
4107 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4109 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4112 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
4114 * lisp.h (VWindow_system, Qfile_name_history):
4115 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4116 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4117 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4119 * w32select.c: Don't #include "keyboard.h".
4120 (run_protected): Add extern declaration for waiting_for_input.
4122 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4123 * w32console.c (detect_input_pending, read_input_pending)
4124 (encode_terminal_code):
4125 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4126 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4127 (w32_system_caret_y, Qfile_name_history):
4128 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4129 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4130 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4131 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4132 * w32proc.c (Qlocal, report_file_error):
4133 * w32term.c (Vwindow_system, updating_frame):
4134 * w32uniscribe.c (initialized, uniscribe_font_driver):
4135 Remove unneeded extern declarations.
4137 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
4139 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
4141 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
4143 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4144 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4145 These macros can no longer be used for assignment.
4147 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4148 Assign struct members directly, instead of using BUF_BEGV etc.
4149 (record_buffer_markers, fetch_buffer_markers): New functions for
4150 recording and fetching special buffer markers.
4151 (set_buffer_internal_1, set_buffer_temp): Use them.
4153 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4155 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4157 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4158 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4160 * xdisp.c (hscroll_window_tree):
4161 (reconsider_clip_changes): Use PT instead of BUF_PT.
4163 2011-03-13 Eli Zaretskii <eliz@gnu.org>
4165 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4166 $(EMACS_ROOT)/lib/intprops.h.
4168 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4170 Fix more problems found by GCC 4.5.2's static checks.
4172 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4173 to unsigned char * to avoid compiler diagnostic.
4174 (xg_free_frame_widgets): Make it clear that a local variable is
4175 needed only if USE_GTK_TOOLTIP.
4176 (gdk_window_get_screen): Make it clear that this macro is needed
4177 only if USE_GTK_TOOLTIP.
4178 (int_gtk_range_get_value): New function, which avoids a diagnostic
4179 from gcc -Wbad-function-cast.
4180 (xg_set_toolkit_scroll_bar_thumb): Use it.
4181 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4182 diagnostic from gcc -Wbad-function-cast.
4183 (get_utf8_string, xg_get_file_with_chooser):
4184 Rename locals to avoid shadowing.
4185 (create_dialog): Move locals to avoid shadowing.
4187 * xgselect.c (xg_select): Remove unused var.
4189 * image.c (four_corners_best): Mark locals as initialized.
4190 (gif_load): Initialize transparent_p to zero (Bug#8238).
4191 Mark another local as initialized.
4192 (my_png_error, my_error_exit): Mark with NO_RETURN.
4194 * image.c (clear_image_cache): Now static.
4195 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
4196 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
4197 (x_edge_detection): Remove unnecessary cast that
4198 gcc -Wbad-function-cast diagnoses.
4199 (gif_load): Fix pointer signedness.
4200 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4201 (jpeg_load, gif_load): Rename locals to avoid shadowing.
4203 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
4205 Improve quality of tests for time stamp overflow.
4206 For example, without this patch (encode-time 0 0 0 1 1
4207 1152921504606846976) returns the obviously-bogus value (-948597
4208 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4209 reports time overflow. See
4210 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
4211 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4212 * editfns.c: Include limits.h and intprops.h.
4213 (TIME_T_MIN, TIME_T_MAX): New macros.
4214 (time_overflow): Move earlier, to before first use.
4215 (hi_time, lo_time): New functions, for an accurate test for
4217 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4218 (Fget_internal_run_time): Don't assume time_t fits in int.
4219 (make_time): Use list2 instead of Fcons twice.
4220 (Fdecode_time): More accurate test for out-of-range times.
4221 (check_tm_member): New function.
4222 (Fencode_time): Use it, to test for out-of-range times.
4223 (lisp_time_argument): Don't rely on undefined left-shift and
4224 right-shift behavior when checking for time stamp overflow.
4226 * editfns.c (time_overflow): New function, refactoring common code.
4227 (Fformat_time_string, Fdecode_time, Fencode_time):
4228 (Fcurrent_time_string): Use it.
4230 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4231 * dired.c (make_time): Move to ...
4232 * editfns.c (make_time): ... here.
4233 * systime.h: Note the move.
4235 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4237 * fringe.c (update_window_fringes): Remove unused variables.
4239 * unexmacosx.c (copy_data_segment): Also copy __got section.
4242 2011-03-12 Eli Zaretskii <eliz@gnu.org>
4244 * termcap.c [MSDOS]: Include "msdos.h".
4245 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4246 Constify `char *' arguments and their references according to
4247 prototypes in tparam.h.
4249 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
4251 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4252 Adapt all references accordingly.
4254 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4256 2011-03-11 Tom Tromey <tromey@redhat.com>
4258 * buffer.c (syms_of_buffer): Remove obsolete comment.
4260 2011-03-11 Eli Zaretskii <eliz@gnu.org>
4262 * termhooks.h (encode_terminal_code): Declare prototype.
4264 * msdos.c (encode_terminal_code): Don't declare prototype.
4266 * term.c (encode_terminal_code): Now external again, used by
4267 w32console.c and msdos.c.
4269 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4270 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
4272 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
4274 Fix some minor problems found by GCC 4.5.2's static checks.
4276 * fringe.c (update_window_fringes): Mark locals as initialized
4278 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
4280 * alloc.c (mark_fringe_data): Move decl from here ...
4281 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4282 to check its interface.
4283 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4285 * fontset.c (free_realized_fontset): Now static.
4286 (Fset_fontset_font): Rename local to avoid shadowing.
4287 (fontset_font): Mark local as initialized.
4288 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
4290 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4292 * xselect.c (x_disown_buffer_selections): Remove; not used.
4293 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
4294 (x_own_selection, Fx_disown_selection_internal): Rename locals
4296 (x_handle_dnd_message): Remove local to avoid shadowing.
4298 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4299 so that the caller can use some name other than gcpro1.
4300 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
4301 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4302 (Fx_backspace_delete_keys_p):
4303 Use them to avoid shadowing, and rename vars to avoid shadowing.
4304 (x_decode_color, x_set_name, x_window): Now static.
4305 (Fx_create_frame): Add braces to silence GCC warning.
4306 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
4307 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4308 Remove unused locals.
4309 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4310 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4311 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4314 * xterm.h (x_mouse_leave): New decl.
4316 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4317 Remove unused functions.
4318 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4319 (x_calc_absolute_position): Now static.
4320 (XTread_socket): Don't define label "out" unless it's used.
4321 Don't declare local "event" unless it's used.
4322 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4323 unless they are used.
4324 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4325 (x_fatal_error_signal): Remove; not used.
4326 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4327 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4328 (x_error_catcher, x_connection_closed, x_error_handler):
4329 (x_error_quitter, xembed_send_message, x_iconify_frame):
4330 (my_log_handler): Rename locals to avoid shadowing.
4331 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
4332 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
4334 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4335 Rename or move locals to avoid shadowing.
4336 (tty_defined_color, merge_face_heights): Now static.
4337 (free_realized_faces_for_fontset): Remove; not used.
4338 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4339 does not deduce is never used uninitialized.
4340 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4341 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
4343 * terminal.c (store_terminal_param): Now static.
4345 * xmenu.c (menu_highlight_callback): Now static.
4346 (set_frame_menubar): Remove unused local.
4347 (xmenu_show): Rename parameter to avoid shadowing.
4348 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4349 since they might point to immutable storage.
4350 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4351 since it's unused otherwise.
4353 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
4354 Add a FIXME, since the code still doesn't look right. (Bug#8215)
4355 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4356 avoids a gcc -Wuninitialized diagnostic.
4357 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
4358 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4359 does not deduce are never used uninitialized.
4361 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4363 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4364 * window.c (window_loop, size_window):
4365 (run_window_configuration_change_hook, enlarge_window): Likewise.
4367 * window.c (display_buffer): Now static.
4368 (size_window): Mark variables that gcc -Wuninitialized
4369 does not deduce are never used uninitialized.
4370 * window.h (check_all_windows): New decl, to forestall
4371 gcc -Wmissing-prototypes diagnostic.
4372 * dispextern.h (bidi_dump_cached_states): Likewise.
4374 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4376 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
4378 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4379 and to avoid gcc -Wuninitialized warning.
4380 (load_charset_map): Mark variables that gcc -Wuninitialized
4381 does not deduce are never used uninitialized.
4382 (load_charset): Abort instead of using uninitialized var (Bug#8229).
4384 * coding.c (coding_set_source, coding_set_destination):
4385 Use "else { /* comment */ }" rather than "else /* comment */;"
4386 for clarity, and to avoid gcc -Wempty-body warning.
4387 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4388 a block, when the outer 'i' will do.
4389 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4390 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4391 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4392 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4393 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4394 Rename locals to avoid shadowing.
4395 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
4396 * coding.c (emacs_mule_char, encode_invocation_designation):
4397 Now static, since they're not used elsewhere.
4398 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
4399 (decode_coding_object, encode_coding_object, detect_coding_system):
4400 (decode_coding_emacs_mule): Mark variables that gcc
4401 -Wuninitialized does not deduce are never used uninitialized.
4402 (detect_coding_iso_2022): Initialize a local variable that might
4403 be used uninitialized. Leave a FIXME because it's not clear that
4404 this initialization is needed. (Bug#8211)
4405 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4406 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4407 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4408 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4409 Remove unused macros.
4411 * category.c (hash_get_category_set): Remove unused local var.
4412 (copy_category_table): Now static, since it's not used elsewhere.
4413 * character.c (string_count_byte8): Likewise.
4415 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4416 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4418 * chartab.c (copy_sub_char_table): Now static, since it's not used
4420 (sub_char_table_ref_and_range, char_table_ref_and_range):
4421 Rename locals to avoid shadowing.
4422 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
4424 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
4425 (BIDI_BOB): Remove unused macro.
4427 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4428 deduce are never used uninitialized.
4429 * term.c (encode_terminal_code): Likewise.
4431 * term.c (encode_terminal_code): Now static. Remove unused local.
4433 * tparam.h: New file.
4434 * term.c, tparam.h: Include it.
4435 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4436 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4437 Move these decls to tparam.h, and make them agree with what
4438 is actually in tparam.c. The previous trick of using incompatible
4439 decls in different modules does not conform to the C standard.
4440 All callers of tparam changed to use tparam's actual API.
4441 * tparam.c (tparam1, tparam, tgoto):
4442 Use const pointers where appropriate.
4444 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4445 * cm.h (struct cm): Likewise.
4446 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4447 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4448 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4449 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4450 (turn_on_face, init_tty): Likewise.
4451 * termchar.h (struct tty_display_info): Likewise.
4453 * term.c (term_mouse_position): Rename local to avoid shadowing.
4455 * alloc.c (mark_ttys): Move decl from here ...
4456 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4458 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4460 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4462 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
4464 * search.c (compile_pattern_1): Remove argument regp, unused since
4465 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4466 (compile_pattern): Don't pass it.
4468 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4470 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4471 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4473 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4475 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4477 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4478 gdk_window_get_screen, gdk_window_get_geometry,
4479 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4480 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4481 (xg_get_pixbuf_from_pixmap): New function.
4482 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4483 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4484 Call xg_get_pixbuf_from_pixmap instead of
4485 gdk_pixbuf_get_from_drawable.
4486 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4487 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4488 (xg_check_special_colors): Use GtkStyleContext and its functions
4490 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4491 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4492 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
4493 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4494 Call gtk_widget_get_preferred_size.
4495 (xg_frame_resized): gdk_window_get_geometry only takes 5
4497 (xg_win_to_widget, xg_event_is_for_menubar):
4498 Call gdk_x11_window_lookup_for_display.
4499 (xg_set_widget_bg): New function.
4500 (delete_cb): New function.
4501 (xg_create_frame_widgets): Connect delete-event to delete_cb.
4502 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4503 (xg_set_background_color): Call xg_set_widget_bg.
4504 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4505 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4506 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4507 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4509 (update_frame_tool_bar): Call gtk_widget_hide.
4510 (xg_initialize): Use GDK_KEY_g.
4512 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4514 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4516 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4517 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4518 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4520 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
4522 * w32xfns.c (select_palette): Check success of RealizePalette against
4523 GDI_ERROR, not zero.
4525 See ChangeLog.11 for earlier changes.
4531 Copyright (C) 2011 Free Software Foundation, Inc.
4533 This file is part of GNU Emacs.
4535 GNU Emacs is free software: you can redistribute it and/or modify
4536 it under the terms of the GNU General Public License as published by
4537 the Free Software Foundation, either version 3 of the License, or
4538 (at your option) any later version.
4540 GNU Emacs is distributed in the hope that it will be useful,
4541 but WITHOUT ANY WARRANTY; without even the implied warranty of
4542 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4543 GNU General Public License for more details.
4545 You should have received a copy of the GNU General Public License
4546 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.