1 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific
6 2012-03-25 Kenichi Handa <handa@m17n.org>
8 * dispextern.h (struct glyph): Change the bit length of
9 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
11 2012-03-24 Eli Zaretskii <eliz@gnu.org>
13 * s/ms-w32.h (tzname): Include time.h before redirecting to
14 _tzname. Fixes the MSVC build. (Bug#9960)
16 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
18 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
21 * xterm.c (XTread_socket): Only modify handling_signal if
22 !SYNC_INPUT. (Bug#11080)
24 2012-03-23 Eli Zaretskii <eliz@gnu.org>
26 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
27 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
28 when fetching a multibyte character consumes more bytes than
29 CHAR_BYTES returns, due to unification of CJK characters in
30 string_char. (Bug#11073)
32 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
34 * process.c (wait_reading_process_output): Handle pty disconnect
35 by refraining from sending oneself a SIGCHLD (bug#10933).
37 2012-03-22 Chong Yidong <cyd@gnu.org>
39 * dispextern.h (struct it): New member string_from_prefix_prop_p.
41 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
42 Mark string as coming from a prefix property.
43 (handle_face_prop): Use default face for prefix strings (Bug#4281).
44 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
46 2012-03-21 Chong Yidong <cyd@gnu.org>
48 * xfaces.c (Vface_remapping_alist): Doc fix.
50 2012-03-20 Eli Zaretskii <eliz@gnu.org>
52 * w32proc.c (Fw32_set_console_codepage)
53 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
56 2012-03-20 Chong Yidong <cyd@gnu.org>
58 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
59 to reflect default non-nil value of redisplay-dont-pause.
61 2012-03-19 Kenichi Handa <handa@m17n.org>
63 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
64 it fit in a valid range (Bug#11003).
66 2012-03-18 Eli Zaretskii <eliz@gnu.org>
68 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
69 that is not from display property, accept the row as a "cursor
70 row" if one of the string's character has a non-nil `cursor'
71 property. Fixes cursor positioning when there are newlines in
72 overlay strings, e.g. in icomplete.el. (Bug#11035)
74 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
76 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
78 2012-03-12 Chong Yidong <cyd@gnu.org>
80 * eval.c (inhibit_lisp_code): Rename from
81 inhibit_window_configuration_change_hook; move from window.c.
83 * xfns.c (unwind_create_frame_1, Fx_create_frame):
84 * window.c (run_window_configuration_change_hook)
85 (syms_of_window): Callers changed.
87 2012-03-11 Chong Yidong <cyd@gnu.org>
89 * keymap.c (Fkey_description): Doc fix (Bug#9700).
91 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
93 2012-03-10 Chong Yidong <cyd@gnu.org>
95 * frame.c (other_visible_frames): Don't assume the selected frame
96 is visible (Bug#10955).
98 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
100 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
102 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
104 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
105 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
108 2012-03-03 Glenn Morris <rgm@gnu.org>
110 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
112 2012-03-02 Eli Zaretskii <eliz@gnu.org>
114 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
115 position past the first glyph_row that ends at ZV. (Bug#10902)
116 (redisplay_window, next_element_from_string): Fix typos in
118 (redisplay_window): Pass to move_it_vertically the margin in
119 pixels, not in screen lines.
121 2012-03-02 Glenn Morris <rgm@gnu.org>
123 * buffer.c (buffer-list-update-hook): Doc fix.
125 2012-02-29 Eli Zaretskii <eliz@gnu.org>
127 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
128 push_it before setting up the iterator for the first overlay
129 string, even if we have an empty string loaded.
130 (next_overlay_string): If there's an empty string on the iterator
131 stack, pop the stack. (Bug#10903)
133 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
135 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
136 Suggested by Stefan Monnier in
137 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
138 * alloc.c (widen_to_Lisp_Object): New static function.
139 (mark_memory): Also mark Lisp_Objects by fetching pointer words
140 and widening them to Lisp_Objects. This would work even if
141 USE_LSB_TAG is defined and wide integers are used, which might
142 happen in a future version of Emacs.
144 2012-02-25 Chong Yidong <cyd@gnu.org>
146 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
149 * xselect.c (Fx_selection_exists_p): Doc fix.
150 (x_clipboard_manager_save_all): Print an informative message
151 before saving to clipboard manager.
153 2012-02-24 Chong Yidong <cyd@gnu.org>
155 * keyboard.c (process_special_events): Handle all X selection
156 requests in kbd_buffer, not just the next one (Bug#8869).
158 2012-02-23 Chong Yidong <cyd@gnu.org>
160 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
161 call when setting menu-bar-lines and tool-bar-lines parameters.
162 (unwind_create_frame_1): New helper function.
164 * window.c (inhibit_window_configuration_change_hook): New var.
165 (run_window_configuration_change_hook): Obey it.
166 (syms_of_window): Initialize it.
168 2012-02-22 Chong Yidong <cyd@gnu.org>
170 * xterm.c (x_draw_image_relief): Add missing type check for
171 Vtool_bar_button_margin (Bug#10743).
173 2012-02-21 Chong Yidong <cyd@gnu.org>
175 * fileio.c (Vfile_name_handler_alist): Doc fix.
177 * buffer.c (Fget_file_buffer): Protect against invalid file
178 handler return value.
180 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
182 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
183 when computing $valmask.
185 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
186 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
187 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
188 It's useless in that case, and it can cause problems on hosts
189 that allocate halves of EMACS_INT values separately.
190 Reported by Dan Horák. Diagnosed by Andreas Schwab in
191 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
192 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
193 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
194 it avoids undefined behavior on hosts where shifting right by more
195 than the word width has undefined behavior.
197 2012-02-19 Chong Yidong <cyd@gnu.org>
199 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
200 (Funhandled_file_name_directory, Ffile_name_as_directory)
201 (Fdirectory_file_name, Fexpand_file_name)
202 (Fsubstitute_in_file_name): Protect against invalid file handler
203 return values (Bug#10845).
205 2012-02-18 Eli Zaretskii <eliz@gnu.org>
207 * .gdbinit (pitx): Fix incorrect references to fields of the
210 2012-02-17 Chong Yidong <cyd@gnu.org>
212 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
214 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
216 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
217 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
219 2012-02-15 Chong Yidong <cyd@gnu.org>
221 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
222 marked as special. Also, starting docstrings with * is obsolete.
224 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
226 * gnutls.c (emacs_gnutls_write): Fix last change.
228 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
230 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
233 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
235 * keymap.c (Fsingle_key_description): Handle char ranges.
237 2012-02-12 Chong Yidong <cyd@gnu.org>
239 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
240 as that creates a dangerous corner case.
242 * window.c (Fdelete_window_internal): Invalidate the mouse
243 highlight (Bug#9904).
245 2012-02-12 Glenn Morris <rgm@gnu.org>
247 * xselect.c (Fx_own_selection_internal)
248 (Fx_get_selection_internal, Fx_disown_selection_internal)
249 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
250 * nsselect.m (Fx_own_selection_internal)
251 (Fx_disown_selection_internal, Fx_selection_exists_p)
252 (Fx_selection_owner_p, Fx_get_selection_internal):
253 Sync docs and argument specs with the xselect.c versions.
255 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
257 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
259 2012-02-11 Eli Zaretskii <eliz@gnu.org>
261 * w32select.c (Fx_selection_exists_p): Sync doc string and
262 argument list with xselect.c. (Bug#10783)
264 * w16select.c (Fx_selection_exists_p): Sync doc string and
265 argument list with xselect.c. (Bug#10783)
267 2012-02-10 Glenn Morris <rgm@gnu.org>
269 * fns.c (Fsecure_hash): Doc fix.
271 2012-02-09 Kenichi Handa <handa@m17n.org>
273 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
275 2012-02-07 Chong Yidong <cyd@gnu.org>
277 * buffer.c (Fbuffer_local_variables)
278 (buffer_lisp_local_variables): Handle unbound vars correctly;
279 don't let Qunbound leak into Lisp.
281 2012-02-07 Glenn Morris <rgm@gnu.org>
283 * image.c (Fimagemagick_types): Doc fix.
285 * image.c (imagemagick-render-type): Change it from a lisp object
286 to an integer. Move the doc here from the lisp manual.
287 Treat all values not equal to 0 the same.
289 2012-02-06 Chong Yidong <cyd@gnu.org>
291 * doc.c (store_function_docstring): Avoid applying docstring of
292 alias to base function (Bug#2603).
294 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
296 * .gdbinit (pp1, pv1): Remove redundant defines.
299 2012-02-04 Chong Yidong <cyd@gnu.org>
301 * nsterm.m: Declare a global (Bug#10694).
303 2012-02-04 Eli Zaretskii <eliz@gnu.org>
305 * w32.c (get_emacs_configuration_options):
306 Include --enable-checking, if specified, in the return value.
308 2012-02-04 Martin Rudalics <rudalics@gmx.at>
310 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
311 after rounding frame sizes. (Bug#9723)
313 2012-02-04 Eli Zaretskii <eliz@gnu.org>
315 * keyboard.c (adjust_point_for_property): Don't position point
316 before BEGV. (Bug#10696)
318 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
320 Handle overflow when computing char display width (Bug#9496).
321 * character.c (char_width): Return EMACS_INT, not int.
322 (char_width, c_string_width): Check for overflow when
323 computing the width; this is possible now that individual
324 characters can have unbounded width. Problem introduced
325 by merge from Emacs 23 on 2012-01-19.
327 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
329 * dbusbind.c (Fdbus_register_method): Mention the return value
330 :ignore in the docstring.
332 2012-02-02 Glenn Morris <rgm@gnu.org>
334 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
336 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
337 Unconditionally set to t. (Bug#10673)
338 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
339 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
340 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
342 2012-02-02 Kenichi Handa <handa@m17n.org>
344 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
345 0, do not call append_composite_glyph.
347 2012-02-02 Kenichi Handa <handa@m17n.org>
349 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
351 (x_produce_glyphs): If the component of a composition is a null
352 string, set it->pixel_width to 1 to avoid zero-width glyph.
354 2012-02-01 Eli Zaretskii <eliz@gnu.org>
356 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
357 first 2 arguments are identical. This makes inserting large
358 output from a subprocess an order of magnitude faster on
359 MS-Windows, where all sbrk'ed memory is always contiguous.
361 2012-01-31 Glenn Morris <rgm@gnu.org>
363 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
364 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
365 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
367 2012-01-29 Glenn Morris <rgm@gnu.org>
369 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
371 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
373 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
375 2012-01-28 Chong Yidong <cyd@gnu.org>
377 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
379 2012-01-26 Chong Yidong <cyd@gnu.org>
381 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
383 * search.c (Fsearch_forward, Fsearch_backward): Document negative
384 repeat counts (Bug#10507).
386 2012-01-26 Glenn Morris <rgm@gnu.org>
388 * lread.c (syms_of_lread): Doc fix.
390 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
392 * coding.c (encode_designation_at_bol): Change return value to
395 2012-01-25 Chong Yidong <cyd@gnu.org>
397 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
399 2012-01-21 Chong Yidong <cyd@gnu.org>
401 * floatfns.c (Fcopysign): Make the second argument non-optional,
402 since nil is not allowed anyway.
404 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
406 * process.c (read_process_output): Use p instead of XPROCESS (proc).
407 (send_process): Likewise.
409 2012-01-19 Martin Rudalics <rudalics@gmx.at>
411 * window.c (save_window_save, Fcurrent_window_configuration)
412 (Vwindow_persistent_parameters): Do not use Qstate.
415 2012-01-19 Kenichi Handa <handa@m17n.org>
417 * character.c (char_width): New function.
418 (Fchar_width, c_string_width, lisp_string_width):
419 Use char_width (Bug#9496).
421 2012-01-16 Martin Rudalics <rudalics@gmx.at>
423 * window.c (Vwindow_persistent_parameters): New variable.
424 (Fset_window_configuration, save_window_save): Handle persistent
427 2012-01-14 Eli Zaretskii <eliz@gnu.org>
429 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
430 thrashing the stack of the thread. (Bug#9087)
432 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
434 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
436 2012-01-11 Eli Zaretskii <eliz@gnu.org>
438 * xdisp.c (rows_from_pos_range): Handle the case where the
439 highlight ends on a newline. (Bug#10464)
440 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
441 he end column for display of highlight that ends on a newline
444 2012-01-11 Glenn Morris <rgm@gnu.org>
446 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
447 from load-path also when installation-directory is nil. (Bug#10208)
449 2012-01-10 Glenn Morris <rgm@gnu.org>
451 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
453 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
454 Update template values to be closer to their typical values these days.
456 2012-01-09 Eli Zaretskii <eliz@gnu.org>
458 * xdisp.c (rows_from_pos_range): Accept additional argument
459 DISP_STRING, and accept any glyph in a row whose object is that
460 string as eligible for mouse highlight. Fixes mouse highlight of
461 display strings from overlays. (Bug#10464)
463 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
465 emacs: fix an auto-save permissions race condition (Bug#10400)
466 * fileio.c (auto_saving_dir_umask): New static var.
467 (Fmake_directory_internal): Use it.
468 (do_auto_save_make_dir): Set it, instead of invoking chmod after
469 creating the directory. The old code temporarily assigns
470 too-generous permissions to the directory.
471 (do_auto_save_eh): Clear it.
472 (Fdo_auto_save): Catch all errors, not just file errors, so
473 that the var is always cleared.
475 2012-01-07 Eli Zaretskii <eliz@gnu.org>
477 * search.c (scan_buffer): Pass character positions to
478 know_region_cache, not byte positions. (Bug#6540)
480 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
482 * w32.c (sys_rename): Report EXDEV when rename of a directory
483 fails because the target is on another logical disk. (Bug#10284)
485 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
487 * xterm.c (x_embed_request_focus): New function.
489 * xterm.h: Add prototype.
491 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
493 2012-01-05 Glenn Morris <rgm@gnu.org>
495 * emacs.c (emacs_copyright): Update short copyright year to 2012.
497 2012-01-01 Eli Zaretskii <eliz@gnu.org>
499 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
500 Load gnutls_transport_set_lowat only if GnuTLS version is below
502 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
503 GnuTLS versions below 2.11.1.
505 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
507 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
508 to the doc string advising against its use for altering the way
509 windows are scrolled.
511 2011-12-28 Kenichi Handa <handa@m17n.org>
513 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
514 coding-system ASCII compatible only when it does not produce BOM
515 on encoding (Bug#10383).
517 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
519 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
521 (create_and_show_popup_menu): Always use menu_position_func for
524 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
526 * callint.c (Fcall_interactively): Don't truncate prompt string.
528 2011-12-23 Eli Zaretskii <eliz@gnu.org>
530 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
531 property that ends at ZV, so that the bidi iteration could be
532 resumed from there (after widening). (Bug#10360)
534 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
536 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
538 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
540 * nsterm.m (x_free_frame_resources):
541 Release f->output_data.ns->miniimage.
542 (ns_index_color): Fix indentation. Do not retain
543 color_table->colors[i].
545 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
548 * nsfns.m (x_set_background_color): Assign return value from
549 ns_index_color to face-background instead of NSColor*.
550 (ns_implicitly_set_icon_type): Fix indentation.
551 Change assignment in for loop to comparison.
553 * emacs.c (ns_pool): New variable.
554 (main): Assign ns_pool.
555 (Fkill_emacs): Call ns_release_autorelease_pool.
557 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
558 autorelease fdesc, release fdAttrs and tdict.
559 (ns_get_covering_families): Release charset.
560 (ns_findfonts): Release NSFontDescriptor created with new.
561 (ns_uni_to_glyphs): Fix indentation.
562 (setString): Release attrStr before assigning new value.
564 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
566 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
568 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
569 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
571 2011-12-18 David Reitter <reitter@cmu.edu>
573 * nsterm.m (ns_term_init): Subscribe for notifications
574 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
575 to method trackingNotification in EmacsMenu.
577 * nsmenu.m (trackingMenu): New variable.
578 (trackingNotification): New method (from Aquamacs).
579 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
580 from Aquamacs (Bug#7030).
582 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
584 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
585 (symbol_to_nsstring): Fix indentation.
586 (ns_symbol_to_pb): New function.
587 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
588 (Fns_rotate_cut_buffers_internal): Remove.
589 (Fns_store_selection_internal): Rename from
590 Fns_store_cut_buffer_internal.
591 (ns_get_foreign_selection, Fx_own_selection_internal)
592 (Fx_disown_selection_internal, Fx_selection_exists_p)
593 (Fns_get_selection_internal, Fns_store_selection_internal):
594 Use ns_symbol_to_pb and check if return value is nil.
595 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
596 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
597 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
598 renamed to Sns_store_selection_internal.
599 (ns_handle_selection_request): Move code to Fx_own_selection_internal
600 and remove this function.
601 (ns_handle_selection_clear): Remove, never used.
602 (Fx_own_selection_internal): Move code from ns_handle_selection_request
605 2011-12-17 Ken Brown <kbrown@cornell.edu>
607 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
608 GID is unknown (Bug#10257).
610 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
612 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
613 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
614 which caused a build failure on GNU/Linux IA-64. This problem was
615 introduced by my 2011-10-07 patch.
617 2011-12-15 Juri Linkov <juri@jurta.org>
619 * image.c (imagemagick_error): New function. (Bug#10112)
620 (imagemagick_load_image): Comment out `MagickSetResolution' call.
621 Use `imagemagick_error' where ImageMagick functions return
623 (Fimagemagick_types): Add `Fnreverse' to return the list in the
626 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
628 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
629 fill background (Bug#8992).
631 2011-12-13 Martin Rudalics <rudalics@gmx.at>
633 * window.c (Vwindow_combination_resize)
634 (Vwindow_combination_limit): Use t instead of non-nil in
636 (Vrecenter_redisplay): Add first sentence of doc-string on
638 (Frecenter): Fix doc-string typo.
640 2011-12-11 Kenichi Handa <handa@m17n.org>
642 * coding.c (Funencodable_char_position): Pay attention to the
643 buffer text relocation (Bug#9389).
645 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
647 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
648 gtk_init (Bug#10100).
650 2011-12-10 Eli Zaretskii <eliz@gnu.org>
652 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
653 IT->string is nil. (Bug#10263)
655 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
657 * nsterm.h (x_free_frame_resources): Declare.
659 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
660 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
662 * nsterm.h (ns_get_defaults_value): Declare.
664 * nsterm.m (ns_default): Call ns_get_defaults_value.
666 2011-12-09 Eli Zaretskii <eliz@gnu.org>
668 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
671 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
673 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
674 that where the value of an _OBJC_* symbol points to is in the .bss
677 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
679 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
680 after the loop to call ccl_driver at least once (Bug#8619).
682 2011-12-08 Kenichi Handa <handa@m17n.org>
684 * ftfont.c (get_adstyle_property): Fix previous change
687 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
689 * w32.c (init_environment): If no_site_lisp, remove site-lisp
690 dirs from the default value of EMACSLOADPATH (bug#10208).
692 2011-12-07 Glenn Morris <rgm@gnu.org>
694 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
695 installation and source directories as well. (Bug#10208)
697 2011-12-06 Chong Yidong <cyd@gnu.org>
699 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
701 2011-12-06 Glenn Morris <rgm@gnu.org>
703 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
704 as an error, not just -1. (Bug#10217)
706 2011-12-05 Chong Yidong <cyd@gnu.org>
708 * keyboard.c (process_special_events): New function.
709 (swallow_events, Finput_pending_p): Use it (Bug#10195).
711 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
713 * coding.c (encode_designation_at_bol): Don't use uninitialized
714 local variable (Bug#9318).
716 2011-12-05 Kenichi Handa <handa@m17n.org>
718 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
719 return Qnil (Bug#8046, Bug#10193).
721 2011-12-05 Kenichi Handa <handa@m17n.org>
723 * coding.c (encode_designation_at_bol): New args charbuf_end and
724 dst. Return the number of produced bytes. Callers changed.
725 (coding_set_source): Return how many bytes coding->source was
727 (coding_set_destination): Return how many bytes
728 coding->destination was relocated.
729 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
730 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
732 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
734 * coding.c (CODING_CHAR_CHARSET_P): New macro.
735 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
738 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
740 The following changes are to fix Bug#9318.
742 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
743 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
744 (encode_coding_iso_2022, encode_coding_sjis)
745 (encode_coding_big5, encode_coding_charset): Use the above macros.
747 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
749 * lisp.h (process_quit_flag): Fix external declaration.
751 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
753 Don't macro-inline non-performance-critical code.
754 * eval.c (process_quit_flag): New function.
755 * lisp.h (QUIT): Use it.
757 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
759 * nsfns.m (get_geometry_from_preferences): New function.
760 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
762 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
764 * emacs.c (Qkill_emacs): Define.
765 (syms_of_emacs): Initialize it.
766 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
767 Qquit_flag to `kill-emacs' instead.
768 (quit_throw_to_read_char): Add parameter `from_signal'.
769 All callers changed. Call Fkill_emacs if requested and safe.
770 * lisp.h (QUIT): Call Fkill_emacs if requested.
772 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
774 * widget.c (update_wm_hints): Return if wmshell is null.
775 (widget_update_wm_size_hints): New function.
777 * widget.h (widget_update_wm_size_hints): Declare.
779 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
780 widget_update_wm_size_hints (Bug#10104).
782 2011-12-03 Eli Zaretskii <eliz@gnu.org>
784 * xdisp.c (handle_invisible_prop): If the invisible text ends just
785 before a newline, prepare the bidi iterator for consuming the
786 newline, and keep the current paragraph direction. (Bug#10183)
787 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
789 2011-12-02 Juri Linkov <juri@jurta.org>
791 * search.c (Fword_search_regexp): New Lisp function created from
792 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
793 (Fword_search_backward, Fword_search_forward)
794 (Fword_search_backward_lax, Fword_search_forward_lax):
795 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
796 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
798 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
800 * fileio.c (Finsert_file_contents): Move after-change-function call
801 to before the "handled:" label, since all "goto handled" appear in
802 cases where the *-change-functions have already been properly called
805 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
807 * keyboard.c (interrupt_signal): Don't call kill-emacs when
808 waiting for input. (Bug#10169)
810 2011-11-30 Eli Zaretskii <eliz@gnu.org>
812 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
813 verifies glyph row's hash code--we have just reallocated the
814 glyphs, so their contents can be complete garbage. (Bug#10164)
816 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
818 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
820 2011-11-30 Eli Zaretskii <eliz@gnu.org>
822 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
823 attributes are tested _before_ calling verify_row_hash, to protect
824 against GCC re-ordering of the tests. (Bug#10164)
826 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
828 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
830 * xterm.c (handle_one_xevent): Only set async_visible and friends
831 if net_wm_state_hidden_seen is non-zero (Bug#10002)
832 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
833 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
835 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
837 Remove GCPRO-related macros that exist only to avoid shadowing locals.
838 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
839 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
840 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
841 All uses changed to use GCPRO1 etc.
842 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
843 Revert to old implementation (i.e., before 2011-03-11).
845 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
847 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
848 of scroll runs so as to avoid assigning disabled bogus rows and
849 unnecessary graphics copy operations.
851 2011-11-27 Eli Zaretskii <eliz@gnu.org>
853 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
854 (snprintf) [_MSC_VER]: Redirect to _snprintf.
855 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
856 (malloc, free, realloc, calloc): Redirect to e_* only when
859 * lisp.h (GCTYPEBITS): Move before first use.
860 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
861 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
862 this macro definition.
864 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
867 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
869 * gtkutil.c (xg_create_frame_widgets):
870 Call gtk_window_set_has_resize_grip (FALSE) if that function is
871 present with Gtk+ 2.0.
873 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
875 * fileio.c (Finsert_file_contents): Undo previous change; see
876 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
878 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
880 Rename locals to avoid shadowing.
881 * fileio.c (Finsert_file_contents):
882 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
883 * process.c (wait_reading_process_output):
884 Rename inner 'proc' to 'p' to avoid shadowing.
885 Indent for consistency with usual Emacs style.
887 2011-11-25 Eli Zaretskii <eliz@gnu.org>
889 * xdisp.c (redisplay_window): If cursor row is not fully visible
890 after recentering, and scroll-conservatively is set to a large
891 number, scroll window by a few more lines to make the cursor fully
892 visible and out of scroll-margin. (Bug#10105)
893 (start_display): Don't move to the next line if the display should
894 start at a newline that is part of a display vector or an overlay
897 2011-11-24 Juri Linkov <juri@jurta.org>
899 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
900 after the `MagickPingImage' call. (Bug#10112)
902 2011-11-23 Chong Yidong <cyd@gnu.org>
904 * window.c (Fcoordinates_in_window_p): Accept only live windows.
906 2011-11-23 Martin Rudalics <rudalics@gmx.at>
908 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
909 making another buffer current. (Bug#10114)
911 2011-11-23 Glenn Morris <rgm@gnu.org>
913 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
915 2011-11-23 Chong Yidong <cyd@gnu.org>
917 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
920 2011-11-22 Eli Zaretskii <eliz@gnu.org>
922 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
923 and header-lines, as they don't have one computed for them.
926 * .gdbinit (prow): Make displayed values more self-explaining.
929 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
931 * process.c (wait_reading_process_output): Fix asynchrounous
932 GnuTLS socket handling on some versions of the GnuTLS library.
933 (wait_reading_process_output): Add comment and URL.
935 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
937 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
939 2011-11-21 Chong Yidong <cyd@gnu.org>
941 * window.c (Fnext_window, Fprevious_window): Doc fix.
943 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
945 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
947 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
949 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
951 2011-11-20 Martin Rudalics <rudalics@gmx.at>
953 * window.c (Fset_window_combination_limit): Rename argument
955 (Vwindow_combination_limit): Remove "status" from doc-string.
957 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
959 * m/ibms390.h: Remove.
960 * m/ibms390x.h: Don't include "ibms390.h".
962 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
964 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
965 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
967 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
969 * casetab.c (Fset_case_table):
970 * charset.c (Fcharset_after): Fix typos.
972 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
974 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
975 Otherwise, valgrind does not work on some platforms.
976 Problem reported by Andreas Schwab in
977 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
978 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
979 is set, removing the need for VIRT_ADDRESS_VARIES.
980 (PURE_P): Use a more-efficient implementation that needs just one
981 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
982 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
983 to 4 (xorl, subq, cmpq, setbe).
984 * alloc.c (pure): Always extern now, since that's the
985 VIRT_ADDR_VARIES behavior.
986 (PURE_POINTER_P): Use a single comparison, not two, for
987 consistency with the new puresize.h.
988 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
989 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
990 Remove VIRT_ADDR_VARIES no longer needed.
992 2011-11-19 Eli Zaretskii <eliz@gnu.org>
994 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
995 (erase_phys_cursor, update_window_cursor, show_mouse_face)
996 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
997 behave as if the cursor position were at the window margin.
999 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1000 and the cursor position is out of bounds, behave as if the cursor
1001 position were at the window margin. (Bug#10075)
1003 2011-11-18 Chong Yidong <cyd@gnu.org>
1005 * window.c (Fwindow_combination_limit): Make first argument
1006 non-optional, since it is meaningless for live windows like the
1009 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1011 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1013 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1015 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1016 (graft_intervals_into_buffer): Simplify.
1018 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1020 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1021 hash values of the two rows.
1022 (copy_row_except_pointers): Preserve the used[] arrays and the
1023 hash values of the two rows. (Bug#10035)
1024 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1026 * xdisp.c (row_hash): New function, body extracted from
1027 compute_line_metrics.
1028 (compute_line_metrics): Call row_hash, instead of computing the
1031 * dispnew.c (verify_row_hash): Call row_hash for computing the
1032 hash code of a row, instead of duplicating code from xdisp.c.
1034 * dispextern.h (row_hash): Add prototype.
1036 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1038 * frame.c (delete_frame): Don't delete the terminal when the last
1039 X frame is closed if emacs is built with GTK toolkit.
1041 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1043 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1045 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1047 * window.c (Vwindow_splits): Rename to
1048 Vwindow_combination_resize. Suggested by Juri Linkov.
1049 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1052 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1054 * nsfns.m (Fns_font_name):
1055 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1057 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1059 * window.h (window): Rename slot "nest" to "combination_limit".
1060 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1061 (Fset_window_nest): Rename to Fset_window_combination_limit.
1062 (Vwindow_nest): Rename to Vwindow_combination_limit.
1063 (recombine_windows, make_parent_window, make_window)
1064 (Fsplit_window_internal, saved_window)
1065 (Fset_window_configuration, save_window_save): Rename all
1066 occurrences of window_nest to window_combination_limit.
1068 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1070 * image.c (imagemagick_load_image): Fix typo.
1072 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1074 * xdisp.c (display_line): Move the call to
1075 highlight_trailing_whitespace before the call to
1076 compute_line_metrics, since the latter needs to see the final
1077 faces of all the glyphs to compute ROW's hash value.
1078 Fixes assertion violations in row_equal_p. (Bug#10035)
1080 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1082 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1083 just return (bug#10044).
1085 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1087 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1088 with user-defined heap size. Bump the default size of the temacs
1089 heap to 27MB, to avoid memory warning when running temacs.
1090 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1092 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1093 current_matrix and desired_matrix. (Bug#9990)
1094 (verify_row_hash) [XASSERTS]: New function.
1095 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1096 that the hash value of glyph rows is correct.
1098 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1100 * window.h (window): Remove splits slot.
1101 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1102 (Fdelete_other_windows_internal, make_parent_window)
1103 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1104 (Fset_window_configuration, save_window_save): Don't deal with
1105 split status of windows.
1106 (saved_window): Remove splits slot.
1107 (Vwindow_splits): Rewrite doc-string.
1109 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1111 * xfns.c (unwind_create_frame):
1112 * nsfns.m (unwind_create_frame):
1113 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1114 Vframe_list (Bug#9999).
1116 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1118 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1120 2011-11-11 Kenichi Handa <handa@m17n.org>
1122 * callproc.c (Fcall_process): Set the member dst_multibyte of
1125 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1127 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1128 avoid a crash (bug#9496).
1130 2011-11-09 Chong Yidong <cyd@gnu.org>
1132 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1133 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1135 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1137 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1139 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1141 Avoid some portability problems by eschewing 'extern inline' functions.
1142 The trivial performance wins aren't worth the portability hassles; see
1143 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1145 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1146 (window_box_width, window_box_left, window_box_left_offset)
1147 (window_box_right, window_box_right_offset): Undo previous change,
1148 by removing the "extern"s.
1149 * intervals.c (adjust_intervals_for_insertion)
1150 (adjust_intervals_for_deletion): Undo previous change,
1151 making these static again.
1152 (offset_intervals, temp_set_point_both, temp_set_point)
1153 (copy_intervals_to_string): No longer inline.
1154 * xdisp.c (window_text_bottom_y, window_box_width)
1155 (window_box_height, window_box_left_offset)
1156 (window_box_right_offset, window_box_left, window_box_right)
1157 (window_box): No longer inline.
1159 2011-11-08 Chong Yidong <cyd@gnu.org>
1161 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1162 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1163 Signal an error if not a live window.
1164 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1165 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1167 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1169 * lisp.h (syms_of_abbrev): Remove declaration.
1170 Reported by CHENG Gao <chenggao@royau.me>.
1172 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1174 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1175 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1176 of temacs in GUI mode.
1178 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1180 * window.h: Declare delete_all_child_windows instead of
1181 delete_all_subwindows.
1182 * window.c (Fwindow_nest, Fset_window_nest)
1183 (Fset_window_new_total, Fset_window_new_normal)
1184 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1185 (delete_all_subwindows): Rename to delete_all_child_windows.
1186 (Fdelete_other_windows_internal, Fset_window_configuration):
1187 Call delete_all_child_windows instead of delete_all_subwindows.
1188 * frame.c (delete_frame): Call delete_all_child_windows instead
1189 of delete_all_subwindows.
1191 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1193 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1194 This is also needed for porting to any host where GC_MARK_STACK is
1195 not GC_MAKE_GCPROS_NOOPS.
1196 (which_symbols): Use it.
1198 2011-11-07 Kenichi Handa <handa@m17n.org>
1200 * coding.c (coding_set_destination): Check coding->src_pos only
1201 when coding->src_object is a buffer (bug#9910).
1203 * process.c (send_process): Set the member src_multibyte of coding
1204 to 0 (bug#9911) when sending a unibyte text.
1206 * callproc.c (Fcall_process): Set the member src_multibyte of
1207 process_coding to 0 (bug#9912).
1209 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1211 * xmenu.c (cleanup_widget_value_tree): New function.
1212 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1213 calling free_menubar_widget_value_tree directly (Bug#9830).
1215 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1217 Fix some portability problems with 'inline'.
1218 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1219 (window_box_width, window_box_left, window_box_left_offset)
1220 (window_box_right, window_box_right_offset): Declare extern.
1221 Otherwise, these inline functions do not conform to C99 and
1222 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1223 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1224 * intervals.c (adjust_intervals_for_insertion)
1225 (adjust_intervals_for_deletion): Now extern, because otherwise the
1226 extern inline functions 'offset_intervals' couldn't refer to it.
1227 (static_offset_intervals): Remove.
1228 (offset_intervals): Rewrite using the old contents of
1229 static_offset_intervals. The old version didn't conform to C99
1230 because an extern inline function contained a reference to an
1231 identifier with static linkage.
1233 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1235 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1238 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1240 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1241 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1242 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1243 return Qleft_to_right.
1245 2011-11-06 Chong Yidong <cyd@gnu.org>
1247 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1248 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1249 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1250 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1251 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1252 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1253 (Fwindow_vscroll): Doc fix.
1254 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1255 argument, since it makes no sense to pass a live window and for
1256 consistency with window-child.
1258 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1260 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1263 2011-11-05 Jason Rumney <jasonr@gnu.org>
1265 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1266 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1268 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1269 bitwise arithmetic preventing use of unicode-sip and non-truetype
1272 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1274 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1277 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1278 initialization code to keep similarity to xfns.c after changes
1281 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1283 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1284 (unwind_create_frame): New function (Bug#9943).
1285 (Fx_create_frame): Restructure code to be more similar to the one in
1286 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1287 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1288 Move terminal->reference_count++ just before making the frame official
1291 * nsterm.m (x_free_frame_resources): New function.
1292 (x_destroy_window): Move code to x_free_frame_resources.
1294 * xfns.c (unwind_create_frame): Fix comment.
1295 (Fx_create_frame, x_create_tip_frame):
1296 Move terminal->reference_count++ just before making the frame
1297 official. Move initialization of image_cache_refcount and
1298 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1300 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1302 Support MSVC build with newer versions of Visual Studio.
1303 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1304 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1307 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1308 which are not supported by MSVC.
1309 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1310 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1312 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1314 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1316 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1318 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1320 Support MSVC build with newer versions of Visual Studio.
1321 * w32.c: Don't include w32api.h for MSVC.
1322 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1324 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1325 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1326 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1327 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1329 (alloca) [_MSC_VER]: Define to _alloca.
1331 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1333 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1335 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1337 * xdisp.c (note_mouse_highlight): If either of
1338 previous/next-single-property-change returns nil, treat that as
1339 the beginning or the end of the buffer. (Bug#9955)
1341 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1343 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1344 label is not null (Bug#9951).
1345 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1348 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1350 * window.c (Fwindow_body_size): Mention in the doc string that the
1351 return value is in frame's canonical units. (Bug#9949)
1353 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1355 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1357 * w32fns.c (unwind_create_frame): If needed, free the glyph
1358 matrices of the partially constructed frame. (Bug#9943)
1359 * xfns.c (unwind_create_frame): Likewise.
1361 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1363 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1364 Don't stop backward scan on the continuation glyph, even though
1365 its CHARPOS is positive.
1366 (mouse_face_from_buffer_pos, note_mouse_highlight):
1367 Rename cover_string to disp_string.
1369 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1371 * window.c (temp_output_buffer_show): Don't use
1372 Vtemp_buffer_show_specifiers.
1373 (Vtemp_buffer_show_specifiers): Remove unused variable.
1375 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1377 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1378 past the beginning of the current glyph matrix.
1380 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1382 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1383 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1384 HAVE_GTK3 (Bug#9869).
1386 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1387 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1389 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1391 * xterm.c: Declare x_handle_net_wm_state to return int.
1392 (handle_one_xevent): Check if we are iconified but don't have
1393 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1394 (get_current_wm_state): Return non-zero if not hidden,
1395 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1396 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1397 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1398 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1400 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1402 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1403 so that this new function doesn't get optimized away by a
1404 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1406 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1408 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1410 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1412 Fix the `xbytecode' command.
1413 * .gdbinit (xprintbytestr): New command.
1414 (xwhichsymbols): Rename from `which'; all callers changed.
1415 (xbytecode): Print the byte-code string as well.
1417 2011-10-29 Kim Storm <storm@cua.dk>
1419 * alloc.c (which_symbols): New function.
1421 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1423 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1426 2011-10-29 Glenn Morris <rgm@gnu.org>
1428 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1429 Not clear what it was for, and it causes various bugs. (Bug#9839)
1431 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1433 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1434 possible random value that matches one of those tested as
1435 condition to clear the mouse face.
1437 2011-10-28 Chong Yidong <cyd@gnu.org>
1439 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1441 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1443 * window.c (make_window): Initialize phys_cursor_on_p.
1445 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1447 * lisp.h (struct Lisp_Symbol): Update comments.
1449 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1451 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1453 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1455 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1456 <oslsachem@gmail.com> for helping to debug this.
1458 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1459 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1460 (g_b_init_get_glyph_outline_w): New static variables.
1461 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1462 (GetGlyphOutlineW_Proc): New typedefs.
1463 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1464 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1466 (w32font_open_internal, compute_metrics):
1467 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1468 instead of calling the "wide" APIs directly.
1470 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1472 * w32.h (syms_of_w32font): Add prototype.
1474 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1476 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1477 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1478 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1479 (Fmove_to_window_line): Doc fix.
1481 2011-10-27 Chong Yidong <cyd@gnu.org>
1483 * process.c (make_process): Set gnutls_state to NULL.
1485 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1486 non-NULL, regardless of GNUTLS_INITSTAGE.
1487 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1488 an error. Set process slots as soon as we allocate them.
1490 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1492 2011-10-27 Chong Yidong <cyd@gnu.org>
1494 * gnutls.c (emacs_gnutls_deinit): New function.
1495 Deallocate credentials structures as well as calling gnutls_deinit.
1496 (Fgnutls_deinit, Fgnutls_boot): Use it.
1498 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1499 (deactivate_process): Call emacs_gnutls_deinit.
1501 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1503 * image.c (x_create_x_image_and_pixmap):
1504 * w32.c (sys_rename, w32_delayed_load):
1505 * w32font.c (fill_in_logfont):
1506 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1508 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1510 * w32fns.c (w32_default_color_map): New function,
1511 extracted from Fw32_default_color_map.
1512 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1514 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1516 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1518 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1520 * keyboard.c (test_undefined): New function (bug#9751).
1521 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1523 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1525 * sysdep.c (init_sys_modes): Fix the check for the controlling
1526 terminal (Bug#6649).
1528 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1530 * dispextern.h (struct bidi_it): New member next_en_type.
1532 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1533 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1534 current character, check also for next_en_type being WEAK_EN.
1535 (bidi_resolve_weak): Don't enter the expensive loop if the current
1536 position is before next_en_pos. Record the bidi type of the first
1537 non-ET, non-BN character we find, in addition to its position.
1538 (bidi_level_of_next_char): Invalidate next_en_type when
1539 next_en_pos is over-stepped.
1541 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1543 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1544 * editfns.c: Rewrite current-time-zone so that it invokes
1545 the equivalent of (format-time-string "%Z") to get the time zone name.
1546 This fixes a bug when the time zone name contains characters that
1547 need converting from the system time locale to Emacs internal format.
1548 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1549 that patch fixed format-time-string to do the conversion, but
1550 I forgot to fix current-time-zone.
1551 (format_time_string): New function, containing most of
1552 what Fformat_time_string used to contain.
1553 (Fformat_time_string): Rewrite in terms of format_time_string.
1554 This doesn't change this function's behavior.
1555 (current-time-zone): Rewrite to use format_time_string.
1556 This fixes the bug reported by Michael Schierl in
1557 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1558 Jason Rumney's 2007-06-07 change worked around this bug, but
1560 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1562 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1564 * xdisp.c (start_display): If the character at POS is displayed
1565 via a display vector, reset IT->current.dpvec_index to zero.
1566 (try_window_reusing_current_matrix): If a line ends in a display
1567 vector or the next line starts in a display vector, continue
1568 redrawing the window even though the character position of
1569 start_row was reached.
1572 2011-10-18 Chong Yidong <cyd@gnu.org>
1574 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1575 with nobreak-char-display too.
1577 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1579 Fix part 3 of bug#9771.
1580 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1581 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1582 non-neutral characters if the current character is a paragraph
1583 separator (a.k.a. Newline). This avoids running the same
1584 expensive loop twice, once when we consume the preceding newline
1585 and the other time when the line actually needs to be displayed.
1586 Avoid the loop when we see neutrals on the base embedding level
1587 following a character whose directionality is the same as the
1588 paragraph's. This avoids running the expensive loop when a line
1589 ends in a long sequence of neutrals, like control characters.
1590 Add assertion against STRONG_AL type. Slightly rearrange code
1591 that determines the type of a neutral given the first non-neutral
1593 (bidi_level_of_next_char): Set next_en_pos to zero when
1594 invalidating its info.
1596 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1598 * xdisp.c (push_display_prop): Determine whether to record string
1599 or buffer position by IT->string, not by IT->method. Allow
1600 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1601 (move_it_vertically_backward): Don't look for character position
1602 immediately after the newline when in a continuation line.
1605 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1607 * window.c (coordinates_in_window): Rewrite and delabelize
1608 vertical border check. (Bug#5357) (Bug#9618)
1610 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1612 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1613 errors in XSetWindowBorder (bug#9310).
1615 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1617 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1618 avoid crash when xmalloc overrun checking is enabled.
1620 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1622 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1623 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1624 cursor motion with <left> and <right> arrow keys.
1626 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1627 some callers set that themselves.
1629 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1631 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1632 display string and the previous row comes from the same string and
1633 is empty. (Bug#9739) (Bug#9738)
1635 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1637 * doc.c (get_doc_string): Encode file name (bug#9735).
1639 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1641 * bidi.c (bidi_level_of_next_char):
1642 * xdisp.c (get_visually_first_element): Remove old incorrect
1643 comments regarding the Unicode Line Separator character.
1645 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1647 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1649 * alloc.c (Fgc_status): Do not access beyond zombies array
1650 boundary if nzombies > MAX_ZOMBIES.
1651 * alloc.c (dump_zombies): Add missing format specifier.
1653 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1655 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1656 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1658 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1659 Some packages use them to denote characters with modifiers.
1661 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1663 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1664 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1665 matching a pp-number. Rename parameter var to var1.
1667 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1669 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1671 2011-10-08 Glenn Morris <rgm@gnu.org>
1673 * callint.c (Fcall_interactively): Give a more explicit error for the
1674 'c' case with a non-character input. (Bug#8479)
1676 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1678 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1680 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1681 lines that are hscrolled on the left.
1683 * dispnew.c (buffer_posn_from_coords): Account for a possible
1684 presence of header-line. (Bug#4426)
1686 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1688 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1689 Don't advertise functionality which we discourage or doesn't work.
1691 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1693 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1694 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1695 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1696 this makes Emacs dump core during garbage collection on rare
1697 occasions. sizeof is obviously inferior to offsetof here, so
1698 stick with offsetof.
1699 (GC_POINTER_ALIGNMENT): New macro.
1700 (mark_memory): Omit 3rd (offset) arg; caller changed.
1701 Don't assume EMACS_INT alignment is the same as pointer alignment.
1703 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1705 * keyboard.c (read_key_sequence_remapped): New var.
1706 (read_key_sequence): Compute remapping in the right buffer.
1707 (command_loop_1): Use read_key_sequence's remapping directly.
1709 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1711 * dired.c (file_name_completion): Don't expand file name.
1712 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1713 before checking file name handler.
1715 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1716 they've been requested explicitly (bug#9591).
1718 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1720 * keymap.c (Fsingle_key_description): Use make_specified_string
1721 instead of build_string to build string from push_key_description.
1724 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1726 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1727 This fixes a Y2038 bug on 64-bit hosts.
1728 * buffer.c (reset_buffer):
1729 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1730 (Fclear_buffer_auto_save_failure):
1731 Use 0, not -1, to represent an unset failure time, since time_t
1732 might not be signed.
1734 Remove dependency on glibc malloc internals.
1735 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1736 Move back here from lisp.h, but with their new implementations.
1737 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1738 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1739 * charset.c (charset_table_init): New static var.
1740 (syms_of_charset): Use it instead of xmalloc. This removes a
1741 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1742 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1743 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1744 Move back to alloc.c.
1745 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1746 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1748 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1750 * nsterm.m (windowDidResize): Call x_set_window_size only when
1751 ns_in_resize is true. Otherwise set pixelwidth/height and
1752 call change_frame_size (Bug#9628).
1754 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1756 Port --enable-checking=all to Fedora 14 x86-64.
1757 * charset.c (syms_of_charset): Also account for glibc malloc's
1758 internal overhead when calculating the initial malloc maximum.
1760 Port --enable-checking=all to Fedora 14 x86.
1761 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1763 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1764 (overrun_check_realloc, overrun_check_free):
1765 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1766 That way, xmalloc returns a properly-aligned pointer even if
1767 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1768 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1769 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1770 into account when calculating the initial malloc maximum.
1771 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1772 Move here from alloc.c, so that charset.c can use it too.
1773 Properly align; the old code wasn't right for common 32-bit hosts
1774 when configured with --enable-checking=all.
1775 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1776 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1778 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1780 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1783 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1785 * xdisp.c (compute_display_string_end): If there's no display
1786 string at CHARPOS, return -1.
1788 * bidi.c (bidi_fetch_char): When compute_display_string_end
1789 returns a negative value, treat the character as a normal
1790 character not covered by a display string. (Bug#9624)
1792 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1794 * lread.c (Fread_from_string): Fix typo in docstring.
1796 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1798 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1799 newline, reseat the iterator instead of bidi-iterating there one
1800 character at a time. (Bug#9610)
1801 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1802 TO_CHARPOS if the bidi iterator is at base embedding level.
1804 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1806 * lread.c (readevalloop): Use correct code for NBSP.
1807 (read1): Likewise. (Bug#9608)
1809 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1811 * dbusbind.c (Fdbus_register_signal): When service is not
1812 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1814 2011-09-25 Glenn Morris <rgm@gnu.org>
1816 * buffer.c (truncate-lines): Doc fix.
1818 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1820 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1821 (Fset_window_next_buffers): Doc fix.
1823 2011-09-24 Glenn Morris <rgm@gnu.org>
1825 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1827 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1829 Fix minor problems found by static checking.
1830 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1831 * indent.c (Fvertical_motion): Fix == vs = typo.
1833 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1835 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1836 Default value is now t. Doc fix.
1838 * indent.c (Fvertical_motion): Compute and apply the overshoot
1839 logic when moving up, not only when moving down. Fix the
1840 confusing name and values of the it_overshoot_expected variable;
1841 logic changes accordingly. (Bug#9254) (Bug#9549)
1843 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1844 CHARPOS is covered by a display string which includes newlines.
1845 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1846 is covered by a display string with embedded newlines.
1848 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1850 * dbusbind.c (Fdbus_register_signal): Add match rule to
1851 Vdbus_registered_objects_table. (Bug#9581)
1852 (Fdbus_register_method, Vdbus_registered_objects_table):
1855 2011-09-24 Jim Meyering <meyering@redhat.com>
1857 do not ignore write error for any output size
1858 The previous change was incomplete.
1859 While it makes emacs --batch detect the vast majority of stdout
1860 write failures, errors were still ignored whenever the output size is
1861 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1862 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1863 && echo FAIL: ignored write error
1864 FAIL: ignored write error
1865 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1866 && echo FAIL: ignored write error
1867 FAIL: ignored write error
1868 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1870 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1872 * emacs.c (Fkill_emacs): In noninteractive mode exit
1873 non-successfully if a write error occurred on stdout. (Bug#9574)
1875 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1877 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1880 * dispextern.h (struct it): Update the comment documenting what
1883 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1885 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1886 a display string, extend search for cursor position to end of row.
1887 (find_row_edges): If the row ends in a newline from a display
1888 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1889 Handle the case of a display string with multiple newlines.
1890 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1891 non-empty line. Fixes confusing cursor motion with arrow keys at
1892 the beginning of a line that starts with whitespace.
1894 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1896 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1899 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1901 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1904 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1906 * xdisp.c (display_line): Record maximum and minimum buffer
1907 positions even if no glyphs were produced (e.g., by a zero-width
1908 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1909 buffer positions that will be removed from the glyph row because
1911 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1912 column is beyond frame width: don't subtract 1 "pixel" when
1913 computing width of the stretch.
1914 (reseat_at_next_visible_line_start): Undo the change made on
1915 2011-09-17 that saved paragraph information and restored it after
1916 the call to `reseat'. (Bug#9545)
1918 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1920 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1921 and turn window cursor on if cleared (Bug#9415).
1923 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1925 * search.c (boyer_moore): Take unibyte characters from pattern
1926 literally. (Bug#9458)
1928 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1930 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1932 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1934 Fix minor problem found by static checking.
1935 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1936 initialized, to pacify gcc -Wuninitialized.
1938 * fileio.c: Report proper errno when syscall falls.
1939 (Finsert_file_contents): Save and restore errno,
1940 so that report_file_error outputs the correct diagnostic.
1941 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1943 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1945 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1947 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1949 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1950 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1952 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1954 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1955 about the current paragraph and restore it after the call to reseat.
1957 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1958 (bidi_find_paragraph_start): Search back for paragraph beginning
1959 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1960 (bidi_move_to_visually_next): Only trigger paragraph-related
1961 computations when the last character is a newline or at EOB, not
1962 just any NEUTRAL_B. (Bug#9470)
1964 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1965 truncated lines if point is covered by a display string. (Bug#9524)
1967 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1969 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1970 (cons_to_x_long): New function.
1971 (lisp_data_to_selection_data): Use it. Correct the test for
1972 short-versus-long data; it was negated. Break out of vector
1973 loop, for efficiency, when a long datum is discovered.
1975 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1977 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1979 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1981 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1982 GCC PR/17406) by declaring this function with external scope.
1984 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1986 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1987 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1989 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1991 * editfns.c (Fformat): Correctly handle text properties on "%%".
1993 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1995 * xterm.c (x_draw_composite_glyph_string_foreground):
1996 * w32term.c (x_draw_composite_glyph_string_foreground):
1997 * term.c (encode_terminal_code):
1998 * composite.c (composition_update_it, get_composition_id):
1999 * xdisp.c (get_next_display_element)
2000 (fill_composite_glyph_string): Add comments about special meaning
2001 of TAB characters in a composition.
2003 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2005 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2006 This occurs when processing a multibyte format.
2007 Problem reported by Wolfgang Jenker.
2009 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2011 * xdisp.c (try_cursor_movement): Only check for exact match if
2012 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2014 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2016 Remove unused external symbols.
2017 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2018 * xdisp.c (calc_pixel_width_or_height): Now static.
2019 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2020 * indent.c (check_display_width):
2021 * w32term.c: Fix comment to match code.
2022 * xterm.c, xterm.h (x_catching_errors): Remove.
2024 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2026 * xselect.c: Use signed conversions more consistently (Bug#9498).
2027 (selection_data_to_lisp_data): Assume incoming selection data are
2028 signed integers, not unsigned. This is to be consistent with
2029 outgoing selection data, which was modified to use signed integers
2030 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2031 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2032 expects long, not unsigned long.
2034 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2036 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2037 computation of loop end. Reported by Johan Bockgård
2040 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2042 * frame.c (Fother_visible_frames_p): Function deleted.
2044 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2046 * indent.c (compute_motion): Process display vector front to back
2047 rather than the other way around. (Bug#2496)
2049 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2051 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2053 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2055 * minibuf.c (Fread_from_minibuffer): Doc fix.
2057 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2059 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2060 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2062 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2064 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2065 value for non-existent files.
2067 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2069 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2070 set its "size" to -1. This will set the modtime_size field of
2071 the corresponding buffer to -1, which is what
2072 verify-visited-file-modtime expects for files that do not exist.
2075 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2077 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2079 * lisp.h: ... from here. push_key_description is no longer
2080 defined in keyboard.c, so its declaration should not be in
2081 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2082 logically belongs with push_key_description.
2084 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2086 * buffer.h: Include <sys/types.h> instead of <time.h>.
2087 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2088 Problem reported by Herbert J. Skuhra.
2090 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2092 * xml.c (parse_region): Make the parsing work for
2093 non-comment-starting XML files again (bug#9144).
2095 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2097 * image.c (gif_load): Fix calculation of bottom and right corner.
2100 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2102 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2103 redisplay in small windows.
2105 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2107 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2109 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2111 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2112 Operate on live windows only.
2114 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2116 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2118 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2120 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2121 only under bidi iteration.
2123 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2125 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2127 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2129 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2130 Without this fix, the command to link temacs failed due to an
2131 undefined symbol __builtin_isnan. This is because
2132 /usr/include/iso/math_c99.h #defines isnan(x) to
2133 __builtin_isnan(x), but the bundled gcc, which identifies itself
2134 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2136 * floatfns.c (isnan): #undef, and then #define to a clone of
2138 (Fisnan): Always define, since it's always available now.
2139 (syms_of_floatfns): Always define isnan at the Lisp level.
2141 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2143 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2145 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2147 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2148 The previous code assumed that file offsets (off_t values) fit in
2149 EMACS_INT variables, which is not true on typical 32-bit hosts.
2150 The code messed up by falsely reporting buffer overflow in cases
2151 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2152 when "big" contains more than 2**29 bytes, even though this
2153 inserts just one byte and does not overflow the buffer.
2154 (Finsert_file_contents): Store file offsets as off_t
2155 values, not as EMACS_INT values. Check for overflow when
2156 converting between EMACS_INT and off_t. When checking for
2157 buffer overflow or for overlap, take the offsets into account.
2158 Don't use EMACS_INT for small values where int suffices.
2159 When checking for overlap, fix a typo: ZV was used where
2160 ZV_BYTE was intended.
2161 (Fwrite_region): Don't assume off_t fits into 'long'.
2162 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2164 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2166 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2168 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2170 sprintf-related integer and memory overflow issues (Bug#9412).
2172 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2173 (esprintf, exprintf, evxprintf): New functions.
2174 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2175 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2176 (modify_event_symbol): Do not assume that the length of
2177 name_alist_or_stem is safe to alloca and fits in int.
2178 (Fexecute_extended_command): Likewise for function name and binding.
2179 (Frecursion_depth): Wrap around reliably on integer overflow.
2180 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2181 since some callers pass EMACS_INT values.
2182 (Fsingle_key_description): Don't crash if symbol name contains more
2183 than MAX_ALLOCA bytes.
2184 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2185 (get_minibuffer): Arg is now EMACS_INT, not int.
2186 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2187 (esprintf, exprintf, evxprintf): New decls.
2188 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2190 * dbusbind.c (signature_cat): New function.
2191 (xd_signature, Fdbus_register_signal):
2192 Do not overrun buffer; instead, report string overflow.
2194 * dispnew.c (add_window_display_history): Don't overrun buffer.
2195 Truncate instead; this is OK since it's just a log.
2197 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2198 even if the time zone offset is outlandishly large.
2199 Don't mishandle offset == INT_MIN.
2201 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2202 when creating daemon; the previous buffer-overflow check was incorrect.
2204 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2205 which has the guts of the old verror function.
2207 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2208 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2210 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2211 (font_unparse_xlfd): Don't blindly alloca long strings.
2212 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2213 fits in int, when using sprintf. Use single snprintf to count
2214 length of string rather than counting it via multiple sprintfs;
2215 that's simpler and more reliable.
2216 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2217 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2218 sprintf, in case result does not fit in int.
2220 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2221 (fontset_from_font): Print it.
2223 * frame.c (tty_frame_count): Now printmax_t, not int.
2224 (make_terminal_frame, set_term_frame_name): Print it.
2225 (x_report_frame_params): In X, window IDs are unsigned long,
2226 not signed long, so print them as unsigned.
2227 (validate_x_resource_name): Check for implausibly long names,
2228 and don't assume name length fits in 'int'.
2229 (x_get_resource_string): Don't blindly alloca invocation name;
2230 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2233 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2234 (xg_check_special_colors, xg_set_geometry):
2235 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2237 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2238 Use esprintf, not sprintf, in case result does not fit in int.
2240 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2241 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2242 it as a large positive number.
2243 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2244 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2246 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2247 in case result does not fit in int.
2249 * print.c (float_to_string): Detect width overflow more reliably.
2250 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2251 buffer overrun. Don't assume list length fits in 'int'. Treat
2252 print length of 0 as 0, not as infinity; to be consistent with other
2253 uses of print length in this function. Don't overflow print length
2254 index. Don't assume hash table size fits in 'long', or that
2255 vectorlike size fits in 'unsigned long'.
2257 * process.c (make_process): Use printmax_t, not int, to format
2258 process-name gensyms.
2260 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2262 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2263 to avoid potential buffer overrun.
2265 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2266 if X resource line is longer than 512 bytes.
2268 * xfns.c (x_window): Make sprintf buffer a bit bigger
2269 to avoid potential buffer overrun.
2271 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2273 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2275 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2277 Integer overflow fixes for scrolling, etc.
2278 Without these, Emacs silently mishandles large integers sometimes.
2279 For example, "C-u 4294967297 M-x recenter" was treated as if
2280 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2282 * xdisp.c (try_window_id): Check Emacs fixnum range before
2283 converting to 'int'.
2285 * window.c (window_scroll_line_based, Frecenter):
2286 Check that an Emacs fixnum is in range before assigning it to 'int'.
2287 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2288 values converted from Emacs fixnums.
2289 (Frecenter): Don't wrap around a line count if it is out of 'int'
2290 range; instead, treat it as an extreme value.
2291 (Fset_window_configuration, compare_window_configurations):
2292 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2294 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2295 that can exceed INT_MAX. Check that EMACS_INT value is in range
2296 before assigning it to the (possibly-narrower) index.
2297 (match_limit): Don't assume that a fixnum can fit in 'int'.
2299 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2302 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2303 (Fvertical_motion): Don't wrap around LINES values that don't fit
2304 in 'int'. Instead, treat them as extreme values. This is good
2305 enough for windows, which can't have more than INT_MAX lines anyway.
2307 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2309 * Require libxml/parser.h to avoid compilation warning.
2311 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2313 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2314 since this reportedly can destroy thread storage.
2316 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2318 * syntax.c (find_defun_start): Update all cache variables if
2319 exiting early (Bug#9401).
2321 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2323 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2325 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2326 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2327 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2329 * term.c (tty_append_glyph): New function.
2330 (produce_stretch_glyph): Static function and its prototype deleted.
2332 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2335 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2337 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2338 when checking :margin (Bug#9390).
2339 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2340 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2341 so that the name doesn't mislead. All uses changed.
2343 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2345 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2348 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2350 * xdisp.c (move_it_to): Don't bail out early when reaching
2351 position beyond to_charpos, if we are scanning backwards.
2352 (move_it_vertically_backward): When DY == 0, make sure we get to
2353 the first character in the line after the newline.
2355 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2357 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2358 (ccl_driver): Do not generate an out-of-range pointer.
2359 (Fccl_execute_on_string): Remove unnecessary check for
2360 integer overflow, noted by Stefan Monnier in
2361 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2362 Remove a FIXME that didn't need fixing.
2363 Simplify the newly-introduced buffer reallocation code.
2365 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2367 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2369 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2371 Integer and memory overflow issues (Bug#9196).
2373 * doc.c (get_doc_string): Rework so that
2374 get_doc_string_buffer_size is the actual buffer size, rather than
2375 being 1 less than the actual buffer size; this makes xpalloc more
2378 * image.c (x_allocate_bitmap_record, cache_image):
2379 * xselect.c (Fx_register_dnd_atom):
2380 Simplify previous changes by using xpalloc.
2382 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2383 since either will do and ptrdiff_t is convenient with xpalloc.
2385 * charset.c (charset_table_size)
2386 (struct charset_sort_data.priority): Now ptrdiff_t.
2387 (charset_compare): Don't overflow if priorities differ greatly.
2388 (Fsort_charsets): Don't assume list length fits in int.
2389 Check for size-calculation overflow when allocating sort data.
2390 (syms_of_charset): Allocate an initial charset table that is
2391 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2393 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2395 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2396 The actual value is always <= INT_MAX, and leaving it unsigned made
2397 overflow checking harder.
2399 * dispextern.h (struct glyph_matrix.rows_allocated)
2400 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2401 with xpalloc. The values are still always <= INT_MAX.
2403 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2405 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2406 (SAFE_NALLOCA): New macro.
2408 * region-cache.c (struct boundary.pos, find_cache_boundary)
2409 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2410 (set_cache_region, invalidate_region_cache)
2411 (revalidate_region_cache, know_region_cache, region_cache_forward)
2412 (region_cache_backward, pp_cache):
2413 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2414 so that ptrdiff_t * can be passed to xpalloc.
2415 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2416 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2417 (pp_cache): Don't assume cache_len fits in int.
2418 * region-cache.h: Adjust extern decls to match.
2420 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2421 EMACS_INT, since either will do, for xpalloc.
2423 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2424 (xnmalloc, xnrealloc, xpalloc): New functions.
2426 * bidi.c (bidi_shelve_header_size): New constant.
2427 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2428 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2430 * bidi.c (bidi_cache_shrink):
2431 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2433 Don't update size of array until after memory allocation succeeds,
2434 because xmalloc/xrealloc may not return.
2435 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2436 now that we have proper integer overflow checking.
2437 (record_overlay_string, overlay_strings): Catch overflows when
2438 calculating size of overlay_str_buf.
2440 * callproc.c (Fcall_process): Check for size overflow when
2441 calculating size of args2.
2442 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2443 Normally we prefer signed values, but sticking with ptrdiff_t would
2444 require adding more-complicated checks.
2446 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2447 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2448 Redo buffer-overflow calculations to avoid integer overflow.
2449 Add a FIXME comment where memory seems to be over-allocated.
2451 * character.c (Fstring): Check for size-calculation overflow.
2453 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2454 unnecessary integer overflow. Check for size overflow.
2455 (encode_coding_object): Don't update size until xmalloc succeeds.
2457 * composite.c (get_composition_id): Check for overflow in glyph
2458 length calculations.
2460 Integer and memory overflow fixes for display code.
2461 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2462 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2463 (scrolling_window): Check for overflow in size calculations.
2464 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2465 Don't assume glyph table len fits in int.
2466 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2467 (row_table_size): Now ptrdiff_t, not int.
2468 (scrolling_window): Avoid overflow in size calculations.
2469 Don't update size until allocation succeeds.
2470 * fns.c (concat): Check for overflow in size calculations.
2471 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2472 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2473 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2475 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2476 (get_doc_string): Check for size calculation overflow.
2477 Don't update size until allocation succeeds.
2478 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2479 EMACS_INT, where ptrdiff_t will do.
2480 (Fsubstitute_command_keys): Check for string overflow.
2482 * editfns.c (set_time_zone_rule): Don't assume environment length
2484 (message_length): Now ptrdiff_t, not int.
2485 (Fmessage_box): Don't update size until allocation succeeds.
2486 Don't assume message length fits in int.
2487 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2489 * emacs.c (main): Do not reallocate argv, since there is a null at
2490 the end that can be overwritten, and this way there's no need to
2491 worry about size-calculation overflow.
2492 (sort_args): Check for size-calculation overflow.
2494 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2496 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2498 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2499 (x_set_scroll_bar_width, x_figure_window_size):
2500 Check for integer overflow.
2501 (x_set_alpha): Do not assume XINT fits in int.
2503 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2504 This is for the members text_lines, text_cols, total_lines, total_cols,
2505 where the system imposes an 'int' limit.
2507 * fringe.c (Fdefine_fringe_bitmap):
2508 Don't update size until alloc works.
2510 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2511 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2513 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2514 Check for size-calculation overflow.
2515 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2516 do, as we prefer signed integers.
2517 (id_to_widget.max_size, id_to_widget.used)
2518 (xg_store_widget_in_map, xg_remove_widget_from_map)
2519 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2520 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2521 Use and return ptrdiff_t, not int.
2522 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2523 * gtkutil.h: Change prototypes to match the above.
2525 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2526 are duplicate now that they've been promoted to lisp.h.
2527 (x_allocate_bitmap_record, x_alloc_image_color)
2528 (make_image_cache, cache_image, xpm_load):
2529 Don't update size until alloc is done.
2530 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2532 Check for size calculation overflow.
2533 (ct_colors_allocated_max): New constant.
2534 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2537 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2538 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2539 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2540 Use ptrdiff_t, not int, to count maps.
2541 (read_char_minibuf_menu_prompt): Check for overflow in size
2542 calculations. Don't update size until allocation succeeds.
2543 Redo calculations to avoid overflow.
2544 * keyboard.h: Change prototypes to match the above.
2546 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2548 (current_minor_maps): Check for size calculation overflow.
2549 * keymap.h: Change prototypes to match the above.
2551 * lread.c (read1, init_obarray): Don't update size until alloc done.
2553 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2554 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2556 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2557 Now ptrdiff_t, not int.
2558 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2559 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2561 * process.c (Fnetwork_interface_list): Check for overflow
2562 in size calculation.
2564 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2566 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2567 overflow. Don't bother calling xmalloc when xrealloc will do.
2569 * search.c (Freplace_match): Check for size calculation overflow.
2570 (Fset_match_data): Don't assume list lengths fit in 'int'.
2572 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2573 for command line length. Do not attempt to address one before the
2574 beginning of an array, as that's not portable.
2576 * term.c (max_frame_lines): Remove; unused.
2577 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2579 (encode_terminal_code, calculate_costs): Check for size
2580 calculation overflow.
2581 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2582 table lengths and related sizes. Don't update size until alloc
2583 done. Redo calculations to avoid overflow.
2584 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2586 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2587 subtracting pointers.
2588 (gobble_line): Check for overflow more carefully. Don't update size
2591 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2592 Don't update size until alloc done.
2593 Redo size calculations to avoid overflow.
2594 Check for size calculation overflow.
2595 (main) [DEBUG]: Fix typo in invoking tparam1.
2597 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2598 Use ptrdiff_t, not int, for sizes.
2599 (store_mode_line_noprop_char): Don't update size until alloc done.
2601 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2602 Use ptrdiff_t, not int, for sizes.
2603 (Finternal_make_lisp_face, cache_face):
2604 Check for size calculation overflow.
2605 (cache_face): Treat size calculation overflows as if they were
2606 memory exhaustion (the usual treatment), rather than aborting.
2608 * xfns.c (x_encode_text, x_set_name_internal)
2609 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2610 sizes, since they can exceed INT_MAX in size. Check for size
2611 calculation overflow.
2613 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2614 (xg_select): Check for size calculation overflow.
2615 Don't update size until alloc done.
2617 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2618 as sprintf is limited to int lengths.
2620 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2621 (X_LONG_MIN): New macros.
2622 Use them to make the following changes clearer.
2623 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2624 This change doesn't affect the value now, but it may help remind
2625 future maintainers not to raise the value too much later.
2626 (SELECTION_QUANTUM): Remove, replacing with ...
2627 (selection_quantum): ... new function, which avoids overflow.
2629 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2630 assumption that selection length fits in 'int'.
2631 (x_reply_selection_request, x_handle_selection_request)
2632 (x_get_window_property, receive_incremental_selection)
2633 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2634 (lisp_data_to_selection_data, clean_local_selection_data):
2635 Use ptrdiff_t, not int, to record length of selection.
2636 (x_reply_selection_request, x_get_window_property)
2637 (receive_incremental_selection, x_property_data_to_lisp):
2638 Redo calculations to avoid overflow.
2639 (x_reply_selection_request): When sending hint, ceiling it at
2640 X_LONG_MAX rather than relying on wraparound overflow to send
2642 (x_get_window_property, receive_incremental_selection)
2643 (lisp_data_to_selection_data, x_property_data_to_lisp):
2644 Check for size-calculation overflow.
2645 (x_get_window_property, receive_incremental_selection)
2646 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2647 Don't store size until memory allocation succeeds.
2648 (x_get_window_property): Plug memory leak on memory exhaustion.
2649 Don't double-block input; malloc is safe here. Don't assume 2**34
2650 - 4 fits in unsigned long. Add an xassert to check
2651 XGetWindowProperty overflow. Be more careful about overflow
2652 calculations, and distinguish size from memory overflow better.
2653 (receive_incremental_selection): When tracing, don't assume
2654 unsigned int is less than INT_MAX.
2655 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2656 harmful) conversions of unsigned short to int.
2657 (lisp_data_to_selection_data): Don't assume that integers
2658 in the range -65535 through -1 fit in an X unsigned short.
2659 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2660 result parameters unless successful. Rely on cons_to_unsigned
2661 to report problems with elements; the old code wasn't right anyway.
2662 (x_check_property_data): Check for int overflow; we cannot use
2663 a wider type due to X limits.
2664 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2666 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2668 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2669 (x_term_init): Check for size calculation overflow.
2670 (x_color_cells): Don't store size until memory allocation succeeds.
2671 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2672 Don't assume alloca size is less than MAX_ALLOCA.
2673 (x_term_init): Don't assume length fits in int (sprintf is limited
2676 Use ptrdiff_t for composition IDs.
2677 * character.c (lisp_string_width):
2678 * composite.c (composition_table_size, n_compositions)
2679 (get_composition_id, composition_gstring_from_id):
2680 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2681 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2682 * window.c (Frecenter):
2683 Use ptrdiff_t, not int, for composition IDs.
2684 * composite.c (get_composition_id): Check for integer overflow.
2685 * composite.h: Adjust prototypes to match the above changes.
2687 Use ptrdiff_t for hash table indexes.
2688 * category.c (hash_get_category_set):
2689 * ccl.c (ccl_driver):
2690 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2691 * coding.c (coding_system_charset_list, detect_coding_system):
2692 * coding.h (struct coding_system.id):
2693 * composite.c (get_composition_id, gstring_lookup_cache):
2694 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2695 * image.c (xpm_get_color_table_h):
2696 * lisp.h (hash_lookup, hash_put):
2697 * minibuf.c (Ftest_completion):
2698 Use ptrdiff_t for hash table indexes, not int (which is too
2699 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2700 32-bit --with-wide-int hosts).
2702 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2703 Add a FIXME comment about memory leaks.
2704 (syms_of_charset): Don't assume xmalloc returns.
2706 Don't assume that stated character widths fit in int.
2707 * character.c (Fchar_width, c_string_width, lisp_string_width):
2708 * character.h (CHAR_WIDTH):
2709 * indent.c (MULTIBYTE_BYTES_WIDTH):
2710 Use sanitize_char_width to avoid undefined and/or bad behavior
2711 with outlandish widths.
2712 * character.h (sanitize_tab_width): Rename from sanitize_width,
2713 now that we have two such functions. All uses changed.
2714 (sanitize_char_width): New inline function.
2716 Don't assume that tab-width fits in int.
2717 * character.h (sanitize_width): New inline function.
2718 (SANE_TAB_WIDTH): New macro.
2719 (ASCII_CHAR_WIDTH): Use it.
2720 * indent.c (sane_tab_width): Remove. All uses replaced by
2721 SANE_TAB_WIDTH (current_buffer).
2722 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2724 * fileio.c: Integer overflow issues with file modes.
2725 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2727 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2728 Remove unreachable code.
2729 (read_hex, load_charset_map_from_file): Check for integer overflow.
2731 * xterm.c: Don't go over XClientMessageEvent limit.
2732 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2733 (x_send_scroll_bar_event): Likewise. Check that the size does not
2734 exceed limits imposed by XClientMessageEvent, as well as the usual
2735 ptrdiff_t and size_t limits.
2737 * keyboard.c: Overflow, signedness and related fixes.
2738 (make_lispy_movement): Use same integer type in forward decl
2739 that is used in the definition.
2740 (read_key_sequence, keyremap_step):
2741 Change bufsize argument back to int, undoing my 2011-03-30 change.
2742 We prefer signed types, and int is wide enough here.
2743 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2744 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2745 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2746 length, not size_t. Use ptrdiff_t for index, not int.
2747 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2748 possibility of integer overflow.
2750 Overflow, signedness and related fixes for images.
2752 * dispextern.h (struct it.stack[0].u.image.image_id)
2753 (struct_it.image_id, struct image.id, struct image_cache.size)
2754 (struct image_cache.used, struct image_cache.ref_count):
2755 * gtkutil.c (update_frame_tool_bar):
2756 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2757 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2758 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2759 * nsmenu.m (update_frame_tool_bar):
2760 * xdisp.c (calc_pixel_width_or_height):
2761 * xfns.c (image_cache_refcount):
2762 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2763 on typical 64-bit hosts.
2765 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2766 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2767 Omit unnecessary casts to int.
2768 (parse_image_spec): Check that integers fall into 'int' range
2769 when the callers expect that.
2770 (image_ascent): Redo ascent calculation to avoid int overflow.
2771 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2772 (lookup_image): Remove unnecessary tests.
2773 (xbm_image_p): Locals are now of int, not EMACS_INT,
2774 since parse_image_check makes sure they fit into int.
2775 (png_load, gif_load, svg_load_image):
2776 Prefer int to unsigned where either will do.
2777 (tiff_handler): New function, combining the cores of the
2778 old tiff_error_handler and tiff_warning_handler.
2779 This function is rewritten to use vsnprintf and thereby avoid
2780 stack buffer overflows. It uses only the features of vsnprintf
2781 that are common to both POSIX and native Microsoft.
2782 (tiff_error_handler, tiff_warning_handler): Use it.
2783 (tiff_load, gif_load, imagemagick_load_image):
2784 Don't assume :index value fits in 'int'.
2785 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2786 (imagemagick_load_image): Check that crop parameters fit into
2787 the integer types that MagickCropImage accepts. Don't assume
2788 Vimagemagick_render_type has a nonnegative value. Don't assume
2789 size_t fits in 'long'.
2790 (gs_load): Use printmax_t to print the widest integers possible.
2791 Check for integer overflow when computing image height and width.
2793 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2795 * xdisp.c (redisplay_window): Don't force window start if point
2796 will be invisible in the resulting window. (Bug#9324)
2798 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2800 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2801 the display spec is of the form `(space ...)'.
2802 (handle_display_spec): Return the value returned by
2803 handle_single_display_spec, not just 1 or zero.
2804 (handle_single_display_spec): If the display spec is of the form
2805 `(space ...)', and specifies display in the text area, return 2
2807 (try_cursor_movement): Check for the need to scroll more
2808 accurately, and prefer exact match for point under bidi.
2809 Don't advance `row' beyond the last row of the window.
2811 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2812 into disp_prop; all users changed.
2814 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2815 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2816 for the text covered by the display property.
2818 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2820 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2821 Change return value to nil.
2822 (Frecord_buffer): Delete unused function.
2824 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2826 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2827 buffers, return left-to-right.
2828 (set_cursor_from_row): Consider candidate row a win if its glyph
2829 represents a newline and point is on that newline. Fixes cursor
2830 positioning on the newline at EOL of R2L text within L2R
2831 paragraph, and vice versa.
2832 (try_cursor_movement): Check continued rows, in addition to
2833 continuation rows. Fixes unwarranted scroll when point enters a
2834 continued line of R2L text within an L2R paragraph, or vice versa.
2835 (cursor_row_p): Consider the case of point being equal to
2836 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2837 from the end of a short line to the beginning of a continued line
2838 of R2L text within L2R paragraph.
2839 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2840 composed characters.
2842 * bidi.c (bidi_check_type): Use xassert.
2843 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2846 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2848 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2851 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2853 * nsfont.m (ns_otf_to_script): Fix typo.
2855 2011-08-22 Kenichi Handa <handa@m17n.org>
2857 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2858 extra slot even if the purpose is char-code-property-table.
2860 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2862 * xdisp.c (redisplay_window): When computing centering_position,
2863 account for the height of the header line. (Bug#8874)
2865 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2866 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2867 candidate is selected by the mouse, and that candidate has a
2868 composed character under the mouse.
2870 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2871 coordinates reported by pos-visible-in-window-p for a composed
2872 character in column zero.
2874 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2876 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2878 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2880 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2881 consider it a hit if to_charpos is anywhere in the range of the
2882 composed buffer positions.
2884 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2886 * image.c (gif_load): Don't assume that each subimage has the same
2887 dimensions as the base image. Handle disposal method that is
2888 "undefined" by the gif spec (Bug#9335).
2890 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2892 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2893 (Fcondition_case): Document `debug' symbol in error handler.
2895 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2897 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2898 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2899 from an Org mode buffer to a Speedbar frame.
2901 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2902 a composition, take its buffer position from IT->cmp_it.charpos.
2903 Fixes cursor positioning at the beginning of a line that begins
2904 with a composed character.
2906 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2908 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2909 character bidirectional type, use STRONG_L instead. Fixes crashes
2910 in a buffer produced by `describe-categories'.
2912 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2913 members before the level stack, so they would be saved and
2914 restored when copying iterator state. Fixes incorrect reordering
2915 around TABs covered by display properties.
2917 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2919 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2921 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2923 * eval.c (internal_condition_case, internal_condition_case_1)
2924 (internal_condition_case_2, internal_condition_case_n):
2925 Remove unnecessary aborts (Bug#9081).
2927 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2929 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2930 has no `load' handler, try opening the file locally. (Bug#9311)
2932 2011-08-16 Ken Brown <kbrown@cornell.edu>
2934 * gmalloc.c: Expand comment.
2936 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2938 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2939 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2941 2011-08-16 Ken Brown <kbrown@cornell.edu>
2943 Fix memory allocation problems in Cygwin build (Bug#9273).
2945 * unexcw.c ( __malloc_initialized): Declare external variable.
2946 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2948 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2950 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2952 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2954 [CYGWIN] (special_realloc): New function.
2955 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2956 requests to realloc storage in the static heap.
2958 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2960 * bidi.c (bidi_initialize): Remove unused local.
2962 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2965 * biditype.h: Remove file.
2966 * makefile.w32-in ($(BLD)/bidi.$(O)):
2967 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2969 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2971 * chartab.c: Improve commentary for the uniprop_table API.
2973 * bidi.c (bidi_paragraph_init): Support zero value of
2974 bidi_ignore_explicit_marks_for_paragraph_level.
2975 (bidi_initialize): Use uniprop_table instead of including
2976 biditype.h and bidimirror.h.
2978 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2979 coordinates of the iterator when restoring from ppos_it.
2982 2011-08-14 Kenichi Handa <handa@m17n.org>
2984 * process.c (create_process): Call setup_process_coding_systems
2985 after the pid of the process is set to -1 (Bug#8162).
2987 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2989 * xdisp.c (move_it_in_display_line_to): Don't invoke
2990 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2991 ppos_it. Fixes vertical cursor motion when line beginning is
2992 covered by an image. (Bug#9296)
2994 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2996 * nsterm.h (ns_run_ascript): Declare.
2997 (NSAPP_DATA2_RUNASSCRIPT): Define.
2999 * nsfns.m (as_script, as_result, as_status): New static variables.
3000 (ns_run_ascript): New function.
3001 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3002 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3003 the event loop. Get status from as_status (Bug#7276).
3005 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3006 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3007 the event loop (Bug#7276).
3009 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3011 * gnutls.c (QCgnutls_bootprop_priority)
3012 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3013 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3014 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3015 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3016 (QCgnutls_bootprop_verify_hostname_error)
3017 (QCgnutls_bootprop_callbacks_verify): Rename from
3018 Qgnutls_bootprop_..., all uses changed.
3020 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3023 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3025 * xfaces.c (Qframe_set_background_mode): Now static.
3026 * dispextern.h (Qframe_set_background_mode): Remove decl.
3028 * process.c (Fnetwork_interface_info): Declare local only if needed.
3030 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3032 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3033 (Fnetwork_interface_list): Allocate in increments of bytes instead
3034 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3035 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3037 (struct ifflag_def): notrailers is smart on OSX.
3038 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3039 Get hardware address with getifaddrs if available.
3041 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3043 * xdisp.c (iterate_out_of_display_property): xassert that
3044 IT->position is set to within IT->object's boundaries. Break from
3045 the loop as soon as EOB is reached; avoids infloops in redisplay
3046 when IT->position is set up wrongly due to some bug.
3047 Set IT->current to match the bidi iterator unconditionally.
3048 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3049 entry. Force push_it to save on the stack the current
3050 buffer/string position, to be restored by pop_it. Fix flags in
3051 the iterator structure wrt the object coming from a display
3052 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3053 properties. (Bug#9284)
3055 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3057 * fontset.c (fontset_get_font_group): Add proper type checks.
3060 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3062 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3063 and LC_VERSION_MIN_MACOSX.
3064 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3065 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3067 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3069 * xdisp.c (forward_to_next_line_start): Allow to use the
3070 no-display-properties-and-no-overlays under bidi display.
3071 Set disp_pos in the bidi iterator to avoid searches for display
3072 properties and overlays.
3074 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3076 * editfns.c (Fset_time_zone_rule): Document relationship with the
3079 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3080 the font entity extracted from the cache (Bug#8109).
3082 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3084 * composite.c (autocmp_chars): Don't reset point. That is done by
3085 restore_point_unwind (Bug#5984).
3087 2011-08-07 Juri Linkov <juri@jurta.org>
3089 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3090 to show the arg `TIME' instead of `TIMEVAL'.
3092 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3094 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3095 display property strides EOL and includes a newline, as in
3096 longlines-mode. (Bug#9254)
3097 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3098 word-wrap under bidirectional display. (Bug#9224)
3100 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3101 is non-zero, even if the data buffer is NULL. Fixes a crash in
3102 vertical-motion with longlines-mode. (Bug#9254)
3104 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3106 * bidi.c <bidi_cache_total_alloc>: Now static.
3107 (bidi_initialize): Initialize bidi_cache_total_alloc.
3109 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3112 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3113 amount allocated this far in `bidi_cache_total_alloc'.
3114 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3115 non-zero, only free the data buffer without restoring the cache
3116 contents. All callers changed.
3118 * dispextern.h (bidi_unshelve_cache): Update prototype.
3120 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3121 (move_it_in_display_line, move_it_to)
3122 (move_it_vertically_backward, move_it_by_lines): Replace the call
3123 to xfree to an equivalent call to bidi_unshelve_cache.
3124 (move_it_in_display_line_to): Fix logic of returning
3125 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3127 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3129 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3130 came from a string character with a `cursor' property. (Bug#9229)
3132 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3134 * Makefile.in (LIB_PTHREAD): New variable.
3135 (LIBES): Add LIB_PTHREAD (Bug#9216).
3137 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3138 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3140 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3142 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3144 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3146 * xterm.c (x_find_topmost_parent): New function.
3147 (x_set_frame_alpha): Find topmost parent window with
3148 x_find_topmost_parent and set the property there also (bug#9181).
3149 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3151 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3153 * callproc.c (Fcall_process): Avoid vfork clobbering
3154 the local vars buffer, coding_systems, current_dir.
3156 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3158 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3160 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3162 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3163 so that it is not optimized away.
3165 * xdisp.c (compute_display_string_pos): Remove unused local.
3167 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3169 Fix slow cursor motion and scrolling in large buffers with
3170 selective display, like Org Mode buffers. (Bug#9218)
3172 * dispextern.h (struct bidi_it): New member disp_prop_p.
3174 * xdisp.c: Remove one-slot cache of display string positions.
3175 (compute_display_string_pos): Accept an additional argument
3176 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3177 for a display string or property. If found, set DISP_PROP_P
3180 * bidi.c (bidi_fetch_char): Accept an additional argument
3181 DISP_PROP_P, and pass it to compute_display_string_pos.
3182 Only handle text covered by a display string if DISP_PROP_P is returned
3183 non-zero. All callers of bidi_fetch_char changed.
3185 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3187 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3189 2010-12-03 Don March <don@ohspite.net>
3191 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3192 last character M-[char] is translated to ESC [char] (bug#7541).
3194 2011-08-02 Kenichi Handa <handa@m17n.org>
3196 * lisp.h (uniprop_table): Extern it.
3198 * chartab.c (uniprop_table): Make it non-static.
3200 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3202 * xdisp.c (forward_to_next_line_start): Accept additional argument
3203 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3205 (reseat_at_next_visible_line_start): Use the bidi iterator state
3206 returned by forward_to_next_line_start to restore the state of
3207 it->bidi_it after backing up to previous newline. (Bug#9212)
3209 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3211 * regex.c (re_comp): Protoize.
3212 (re_exec): Fix return type.
3213 (regexec): Fix type of `ret'. (Bug#9203)
3215 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3217 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3218 This is needed if max-image-size is a floating-point number.
3220 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3222 * print.c (print_object): Print empty symbol as ##.
3224 * lread.c (read1): Read ## as empty symbol.
3226 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3228 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3229 setting frame foreground color (Bug#9175).
3230 (x_set_background_color): Likewise.
3232 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3233 contents (Bug#9176).
3234 (EmacsTooltip -init): Remove bezels and add shadows to
3237 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3238 or scroll bar (Bug#8470).
3240 * nsfont.m (nsfont_open): Remove assignment to voffset and
3241 unnecessary vars hshink, expand, hd, full_height, min_height.
3242 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3244 * nsterm.h (nsfont_info): Remove voffset field.
3246 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3248 Implement strike-through and overline on NextStep (Bug#8863).
3250 * nsfont.m (nsfont_open): Use underline position provided by font,
3251 instead of hard-coded value of 2.
3252 (nsfont_draw): Call ns_draw_text_decoration instead.
3254 * nsterm.h: Add declaration for ns_draw_text_decoration.
3256 * nsterm.m (ns_draw_text_decoration): New function for drawing
3257 underline, overline, and strike-through.
3258 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3259 ns_draw_text_decoration. Change treatment of cursor drawing to
3260 accommodate underlining, etc.
3262 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3264 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3267 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3269 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3270 Without this fix, if a signal arrives just after memory fills up,
3271 'malloc' might be invoked reentrantly.
3273 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3274 In other words, assume that every image size is allowed, on non-X
3275 hosts. This assumption is probably wrong, but it lets Emacs compile.
3277 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3279 * regex.c (re_iswctype): Convert return values to boolean.
3281 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3283 * xdisp.c (compute_display_string_pos): Don't use cached display
3284 string position if the buffer had its restriction changed.
3287 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3289 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3291 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3293 Integer signedness and overflow and related fixes. (Bug#9079)
3295 * bidi.c: Integer size and overflow fixes.
3296 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3297 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3298 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3299 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3300 (bidi_find_other_level_edge):
3301 Use ptrdiff_t instead of EMACS_INT where either will do.
3302 This works better on 32-bit hosts configured --with-wide-int.
3303 (bidi_cache_ensure_space): Check for size-calculation overflow.
3304 Use % rather than repeated addition, for better worst-case speed.
3305 Don't set bidi_cache_size until after xrealloc returns, because it
3307 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3308 (bidi_cache_ensure_space): Also check that the bidi cache size
3309 does not exceed that of the largest Lisp string or buffer. See Eli
3310 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3312 * alloc.c (__malloc_size_t): Remove.
3313 All uses replaced by size_t. See Andreas Schwab's note
3314 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3316 * image.c: Improve checking for integer overflow.
3317 (check_image_size): Assume that f is nonnull, since
3318 it is always nonnull in practice. This is one less thing to
3319 worry about when checking for integer overflow later.
3320 (x_check_image_size): New function, which checks for integer
3321 overflow issues inside X.
3322 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3323 This removes the need for a memory_full check.
3324 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3325 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3326 (xbm_read_bitmap_data): Change locals back to 'int', since
3327 their values must fit in 'int'.
3328 (xpm_load_image, png_load, tiff_load):
3329 Invoke x_create_x_image_and_pixmap earlier,
3330 to avoid much needless work if the image is too large.
3331 (tiff_load): Treat overly large images as if
3332 x_create_x_image_and_pixmap failed, not as malloc failures.
3333 (gs_load): Use x_check_image_size.
3335 * gtkutil.c: Omit integer casts.
3336 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3337 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3339 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3341 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3342 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3343 would wrongly return t on a 64-bit host.
3345 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3346 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3347 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3348 and therefore cause GCC to emit a bogus diagnostic in some cases.
3350 * image.c: Integer signedness and overflow and related fixes.
3351 This is not an exhaustive set of fixes, but it's time to
3352 record what I've got.
3353 (lookup_pixel_color, check_image_size): Remove redundant decls.
3354 (check_image_size): Don't assume that arbitrary EMACS_INT values
3355 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3356 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3357 (tiff_load, imagemagick_load_image):
3358 Check for overflow in size calculations.
3359 (x_create_x_image_and_pixmap): Remove unnecessary test for
3360 xmalloc returning NULL; that can't happen.
3361 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3362 (xpm_color_bucket): Use better integer hashing function.
3363 (xpm_cache_color): Don't possibly over-allocate memory.
3364 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3365 (gif_memory_source):
3366 Use ptrdiff_t, not int or size_t, to record sizes.
3367 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3368 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3369 either works, as we prefer signed integers.
3370 (tiff_read_from_memory, tiff_write_from_memory):
3371 Return tsize_t, not size_t, since that's what the TIFF API wants.
3372 (tiff_read_from_memory): Don't fail simply because the read would
3373 go past EOF; instead, return a short read.
3374 (tiff_load): Omit no-longer-needed casts.
3375 (Fimagemagick_types): Don't assume size fits into 'int'.
3377 Improve hashing quality when configured --with-wide-int.
3378 * fns.c (hash_string): New function, taken from sxhash_string.
3379 Do not discard information about ASCII character case; this
3380 discarding is no longer needed.
3381 (sxhash-string): Use it. Change sig to match it. Caller changed.
3382 * lisp.h: Declare it.
3383 * lread.c (hash_string): Remove, since we now use fns.c's version.
3384 The fns.c version returns a wider integer if --with-wide-int is
3385 specified, so this should help the quality of the hashing a bit.
3387 * emacs.c: Integer overflow minor fix.
3388 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3389 Define only if GNU_LINUX.
3390 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3392 * dispnew.c: Integer signedness and overflow fixes.
3393 Remove unnecessary forward decls, that were a maintenance hassle.
3394 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3396 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3397 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3398 (prepare_desired_row, line_draw_cost):
3399 Use int, not unsigned, where either works.
3400 (save_current_matrix, restore_current_matrix):
3401 Use ptrdiff_t, not size_t, where either works.
3402 (init_display): Check for overflow more accurately, and without
3403 relying on undefined behavior.
3405 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3406 Remove, replacing with the new symbols in lisp.h. All uses changed.
3407 * fileio.c (make_temp_name):
3408 * filelock.c (lock_file_1, lock_file):
3409 * xdisp.c (message_dolog):
3410 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3411 Use pMd etc. instead.
3412 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3413 replacing the pWIDE etc. symbols removed from editfns.c.
3415 * keyboard.h (num_input_events): Now uintmax_t.
3416 This is (very slightly) less likely to mess up due to wraparound.
3419 * buffer.c: Integer signedness fixes.
3420 (alloc_buffer_text, enlarge_buffer_text):
3421 Use ptrdiff_t rather than size_t when either will do, as we prefer
3424 * alloc.c: Integer signedness and overflow fixes.
3425 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3426 (__malloc_size_t): Default to size_t, not to int.
3427 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3428 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3429 Prefer ptrdiff_t to size_t when either would do, as we prefer
3431 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3432 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3433 Now const. Initialize with values that are in range even if char
3435 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3436 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3437 These functions do the right thing with sizes > 2**32.
3438 (check_depth): Now ptrdiff_t, not int.
3439 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3440 Adjust to new way of storing sizes. Check for size overflow bugs
3442 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3443 slightly wrong anyway, as it missed one instance of
3444 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3445 (refill_memory_reserve): Omit needless cast to size_t.
3446 (mark_object_loop_halt): Mark as externally visible.
3448 * xselect.c: Integer signedness and overflow fixes.
3449 (Fx_register_dnd_atom, x_handle_dnd_message):
3450 Use ptrdiff_t, not size_t, since we prefer signed.
3451 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3452 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3453 x_dnd_atoms_size and x_dnd_atoms_length.
3455 * doprnt.c: Prefer signed to unsigned when either works.
3457 * doprnt.c (doprnt):
3459 * xdisp.c (vmessage):
3460 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3461 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3462 prefer signed arithmetic to avoid comparison confusion.
3463 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3464 but is a bit tricky.
3466 Assume freestanding C89 headers, string.h, stdlib.h.
3467 * data.c, doprnt.c, floatfns.c, print.c:
3468 Include float.h unconditionally.
3469 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3470 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3471 * regex.c: Likewise for stddef.h, string.h.
3472 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3473 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3474 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3475 (STDC_HEADERS): Remove obsolete defines.
3476 * sysdep.c: Include limits.h unconditionally.
3478 Assume support for memcmp, memcpy, memmove, memset.
3479 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3480 * regex.c (memcmp, memcpy):
3481 Remove; we assume C89 now.
3483 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3484 (__malloc_safe_bcopy): Remove; no longer needed.
3486 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3487 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3488 well either way, and we prefer signed to unsigned.
3490 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3492 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3493 closes the connection while we're reading (bug#9182).
3495 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3497 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3498 are specified (Bug#9168).
3500 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3502 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3503 Found by GCC static checking and --with-wide-int on a 32-bit host.
3505 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3507 * xdisp.c (compute_display_string_pos): Fix logic of caching
3508 previous display string position. Initialize cached_prev_pos to
3509 -1. Fixes slow-down at the beginning of a buffer.
3511 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3513 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3514 for attrs[LFACE_FONTSET_INDEX].
3516 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3518 * xml.c (parse_region): Remove unused local
3519 that was recently introduced.
3521 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3523 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3524 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3526 * xdisp.c (move_it_in_display_line_to): Record the best matching
3527 position for TO_CHARPOS while scanning the line, and restore it on
3528 exit if none of the characters scanned was an exact match.
3529 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3530 when exact match is impossible due to invisible text, and the
3531 lines are truncated.
3533 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3535 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3538 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3540 Fix a significant slow-down of cursor motion with C-n, C-p,
3541 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3542 auto-repeat under bidi redisplay in fontified buffers.
3543 * xdisp.c (compute_stop_pos_backwards): New function.
3544 (next_element_from_buffer): Call compute_stop_pos_backwards to
3545 find a suitable prev_stop when we find ourselves before
3547 (reseat): Don't look for prev_stop, as that could mean a very long
3549 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3550 <cached_disp_overlay_modiff>: Cache for last found display string
3552 (compute_display_string_pos): Return the cached position if asked
3553 about the same buffer in the same area of character positions, and
3554 the buffer wasn't changed since the time the display string
3555 position was cached.
3557 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3559 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3560 is an integer, which is important for empty lines. (Bug#9149)
3562 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3564 * frame.c (Fmodify_frame_parameters): In tty case, update the
3565 default face if necessary (Bug#4238).
3567 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3569 * editfns.c (Fstring_to_char): No need to explain what a character
3570 is in the docstring (Bug#6576).
3572 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3574 * xml.c (parse_region): Make sure we always return a tree.
3576 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3578 * xml.c (parse_region): If a document contains only comments,
3581 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3583 * xml.c (make_dom): Return comments, too.
3585 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3588 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3589 and the surrounding thread.
3590 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3591 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3592 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3594 * s/openbsd.h (BROKEN_SIGIO): Define.
3595 * unexelf.c (unexec) [__OpenBSD__]:
3596 Don't update the .mdebug section of the Alpha COFF symbol table.
3598 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3600 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3603 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3605 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3606 This fixes some race conditions on the permissions of any newly
3609 * alloc.c (valid_pointer_p): Use pipe, not open.
3610 This fixes some permissions issues when debugging.
3612 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3613 If fchown fails to set both uid and gid, try to set just gid,
3614 as that is sometimes allowed. Adjust the file's mode to eliminate
3615 setuid or setgid bits that are inappropriate if fchown fails.
3617 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3619 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3620 to compare Lisp_Objects.
3621 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3622 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3623 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3625 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3627 * lread.c (read_integer): Unread even EOF character.
3628 (read1): Likewise. Properly record start position of symbol.
3630 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3631 symbol character follows.
3633 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3635 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3636 This works around a problem with the previous change to Fcopy_file.
3637 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3638 and without this change, GCC might complain about discarding
3639 fchown's return value.
3641 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3643 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3645 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3647 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3649 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3651 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3652 it's used from the C level.
3654 * process.c: Use the same condition for POLL_FOR_INPUT in both
3655 keyboard.c and process.c (bug#1858).
3657 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3659 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3660 (Fgnutls_boot): Use it.
3662 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3664 * doc.c (Fsubstitute_command_keys): Revert last change.
3666 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3668 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3669 quotes the next character, and doesn't affect other longer
3670 sequences (bug#8935).
3672 * lread.c (syms_of_lread): Clarify that is isn't only
3673 `eval-buffer' and `eval-defun' that's affected by
3674 `lexical-binding' (bug#8460).
3676 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3678 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3679 bidi redisplay when a line includes both an image and is truncated.
3681 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3683 Fix minor problems found by static checking.
3684 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3685 (elsz): Now a signed constant, not a size_t var. We prefer signed
3686 types to unsigned, to avoid integer comparison confusion. Without
3687 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3688 "cannot optimize loop, the loop counter may overflow", a symptom
3690 * indent.c (Fvertical_motion): Mark locals as initialized.
3691 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3693 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3695 * search.c (Fre_search_backward): Mention `case-fold-search' in
3696 all the re_search_* functions (bug#8138).
3698 * keyboard.c (Fopen_dribble_file): Document when the file is
3701 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3703 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3706 Support bidi reordering of display and overlay strings.
3707 * xdisp.c (compute_display_string_pos)
3708 (compute_display_string_end): Accept additional argument STRING.
3709 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3710 (reseat_to_string): Initialize bidi_it->string.s and
3711 bidi_it->string.schars.
3712 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3713 NULL (avoids a crash in bidi_paragraph_init).
3714 Initialize itb.string.lstring.
3715 (init_iterator): Call bidi_init_it only of a valid
3716 buffer position was specified. Initialize paragraph_embedding to
3718 (reseat_to_string): Initialize the bidi iterator.
3719 (display_string): If we need to ignore text properties of
3720 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3721 original value of -1 will not work with bidi.)
3722 (compute_display_string_pos): First arg is now struct
3723 `text_pos *'; all callers changed. Support display properties on
3725 (compute_display_string_end): Support display properties on Lisp
3727 (init_iterator, reseat_1, reseat_to_string): Initialize the
3728 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3729 when iterating on a string not from display properties).
3730 (compute_display_string_pos, compute_display_string_end):
3731 Fix calculation of the object to scan. Fixes an error when using
3733 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3734 base_level_stop; instead, set base_level_stop to BEGV.
3735 Fixes crashes in vertical-motion.
3736 (next_element_from_buffer): Improve commentary for when
3737 the iterator is before prev_stop.
3738 (init_iterator): Initialize bidi_p from the default value of
3739 bidi-display-reordering, not from buffer-local value. Use the
3740 buffer-local value only if initializing for buffer iteration.
3741 (handle_invisible_prop): Support invisible properties on strings
3742 that are being bidi-reordered.
3743 (set_iterator_to_next): Support bidi reordering of C strings and
3745 (next_element_from_string): Support bidi reordering of Lisp
3747 (handle_stop_backwards): Support Lisp strings as well.
3748 (display_string): Support display of R2L glyph rows.
3749 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3750 (init_iterator): Don't initialize it->bidi_p for strings
3752 (reseat_to_string): Initialize it->bidi_p for strings here.
3753 (next_element_from_string, next_element_from_c_string)
3754 (next_element_from_buffer): Add xassert's for correspondence
3755 between IT's object being iterated and it->bidi_it.string
3757 (face_before_or_after_it_pos): Support bidi iteration.
3758 (next_element_from_c_string): Handle the case of the first string
3759 character that is not the first one in the visual order.
3760 (get_visually_first_element): New function, refactored from common
3761 parts of next_element_from_buffer, next_element_from_string, and
3762 next_element_from_c_string.
3763 (tool_bar_lines_needed, redisplay_tool_bar)
3764 (display_menu_bar): Force left-to-right direction. Add a FIXME
3765 comment for making that be controlled by a user option.
3766 (push_it, pop_it): Save and restore the state of the
3767 bidi iterator. Save and restore the bidi_p flag.
3768 (pop_it): Iterate out of display property for string iteration as
3770 (iterate_out_of_display_property): Support iteration over strings.
3771 (handle_single_display_spec): Set up it->bidi_it for iteration
3772 over a display string, and call bidi_init_it.
3773 (handle_single_display_spec, next_overlay_string)
3774 (get_overlay_strings_1, push_display_prop): Set up the bidi
3775 iterator for displaying display or overlay strings.
3776 (forward_to_next_line_start): Don't use the shortcut if
3778 (back_to_previous_visible_line_start): If handle_display_prop
3779 pushed the iterator stack, restore the internal state of the bidi
3780 iterator by calling bidi_pop_it same number of times.
3781 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3782 and we are bidi-iterating, don't decrement the iterator position;
3783 instead, set the first_elt flag in the bidi iterator, to produce
3785 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3786 (push_display_prop): xassert that we are iterating a buffer.
3787 (push_it, pop_it): Save and restore paragraph_embedding member.
3788 (handle_single_display_spec, next_overlay_string)
3789 (get_overlay_strings_1, reseat_1, reseat_to_string)
3790 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3791 correctly. Don't assume unibyte strings are not bidi-reordered.
3792 (compute_display_string_pos)
3793 (compute_display_string_end): Fix handling the case of C string.
3794 (push_it, pop_it): Save and restore from_disp_prop_p.
3795 (handle_single_display_spec, push_display_prop): Set the
3796 from_disp_prop_p flag.
3797 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3798 (pop_it): Call iterate_out_of_display_property only if we are
3799 popping after iteration over a string that came from a display
3800 property. Fix a typo in popping stretch info. Add an assertion
3801 for verifying that the iterator position is in sync with the bidi
3803 (handle_single_display_spec, get_overlay_strings_1)
3804 (push_display_prop): Fix initialization of paragraph direction for
3805 string when that of the parent object is not yet determined.
3806 (reseat_1): Call bidi_init_it to resync the bidi
3807 iterator with IT's position. (Bug#7616)
3808 (find_row_edges): If ROW->start.pos gives position
3809 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3810 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3811 Reset the from_disp_prop_p flag.
3812 (SAVE_IT, RESTORE_IT): New macros.
3813 (pos_visible_p, face_before_or_after_it_pos)
3814 (back_to_previous_visible_line_start)
3815 (move_it_in_display_line_to, move_it_in_display_line)
3816 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3817 (try_scrolling, redisplay_window, display_line): Use them when
3818 saving a temporary copy of the iterator and restoring it back.
3819 (back_to_previous_visible_line_start, reseat_1)
3820 (init_iterator): Empty the bidi cache "stack".
3821 (move_it_in_display_line_to): If iterator ended up at
3822 EOL, but we never saw any buffer positions smaller than
3823 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3824 motion in bidi-reordered lines.
3825 (move_it_in_display_line_to): Record prev_method and prev_pos
3826 immediately before the call to set_iterator_to_next. Fixes cursor
3827 motion in bidi-reordered lines with stretch glyphs and strings
3828 displayed in margins. (Bug#8133) (Bug#8867)
3829 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3831 (pos_visible_p): Support positions in bidi-reordered lines.
3832 Save and restore bidi cache.
3834 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3835 (bidi_paragraph_info): Delete unused struct.
3836 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3837 (bidi_cache_start): New variable.
3838 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3840 (bidi_cache_fetch_state, bidi_cache_search)
3841 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3842 (bidi_cache_find, bidi_peek_at_next_level)
3843 (bidi_level_of_next_char, bidi_find_other_level_edge)
3844 (bidi_move_to_visually_next): Compare cache index with
3845 bidi_cache_start rather than with zero.
3846 (bidi_fetch_char): Accept new argument STRING; all callers
3847 changed. Support iteration over a string. Support strings with
3848 display properties. Support unibyte strings. Fix the type of
3849 `len' according to what STRING_CHAR_AND_LENGTH expects.
3850 (bidi_paragraph_init, bidi_resolve_explicit_1)
3851 (bidi_resolve_explicit, bidi_resolve_weak)
3852 (bidi_level_of_next_char, bidi_move_to_visually_next):
3853 Support iteration over a string.
3854 (bidi_set_sor_type, bidi_resolve_explicit_1)
3855 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3856 can now be zero (for strings); special values 0 and -1 were
3857 changed to -1 and -2, respectively.
3858 (bidi_char_at_pos): New function.
3859 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3860 Call it instead of FETCH_MULTIBYTE_CHAR.
3861 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3862 initialized to valid values.
3863 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3865 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3866 the test for valid cached positions. Fix the logic for looking up
3867 the sentinel state in the cache. GCPRO the Lisp string we are
3869 (bidi_push_it, bidi_pop_it): New functions.
3870 (bidi_initialize): Initialize the bidi cache start stack pointer.
3871 (bidi_cache_ensure_space): New function, refactored from part of
3872 bidi_cache_iterator_state. Don't assume the required size is just
3873 one BIDI_CACHE_CHUNK away.
3874 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3875 (bidi_count_bytes, bidi_char_at_pos): New functions.
3876 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3877 always valid if bidi_cache_idx is valid.
3878 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3879 is valid if it's going to be used.
3880 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3881 (bidi_cache_fetch_state, bidi_cache_search)
3882 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3883 (bidi_cache_iterator_state, bidi_cache_find)
3884 (bidi_find_other_level_edge, bidi_cache_start_stack):
3885 All variables related to cache indices are now EMACS_INT.
3887 * dispextern.h (struct bidi_string_data): New structure.
3888 (struct bidi_it): New member `string'. Make flag members be 1-bit
3889 fields, and put them last in the struct.
3890 (compute_display_string_pos, compute_display_string_end):
3892 (bidi_push_it, bidi_pop_it): Add prototypes.
3893 (struct iterator_stack_entry): New members bidi_p,
3894 paragraph_embedding, and from_disp_prop_p.
3895 (struct it): Member bidi_p is now a bit field 1 bit wide.
3896 (bidi_shelve_cache, bidi_unshelve_cache):
3899 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3900 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3901 and vector-like objects.
3903 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3904 cache around display iteration.
3906 * window.c (Fwindow_end, window_scroll_pixel_based)
3907 (displayed_window_lines, Frecenter): Save and restore the bidi
3908 cache around display iteration.
3910 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3912 * editfns.c (Fdelete_region): Clarify the use of the named
3913 parameters (bug#6788).
3915 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3917 * indent.c (Fvertical_motion): Set and restore w->pointm when
3918 saving and restoring the window's buffer (Bug#9006).
3920 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3922 * editfns.c (Fstring_to_char): Clarify just what is returned
3923 (bug#6576). Text by Eli Zaretskii.
3925 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3927 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3929 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3931 * buffer.c (mmap_find): Fix a typo.
3933 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3935 Fix execution of x selection hooks.
3936 * xselect.c (Qx_lost_selection_functions)
3937 (Qx_sent_selection_functions): New vars.
3938 (syms_of_xselect): DEFSYM them.
3939 (x_handle_selection_request): Pass Qx_sent_selection_functions
3940 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3941 (x_handle_selection_clear,x_clear_frame_selections):
3942 Pass Qx_lost_selection_functions rather than
3943 Vx_lost_selection_functions to Frun_hook_with_args.
3945 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3947 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3948 The old code sometimes used this field without initializing it.
3950 * alloc.c (gc_sweep): Don't read past end of array.
3951 In theory, the old code could also have corrupted Emacs internals,
3952 though it'd be very unlikely.
3954 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3956 * character.c (Fcharacterp): Don't advertise optional ignored
3957 argument. (Bug#4026)
3959 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3961 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3964 * window.c (Fset_window_start): Doc fix (bug#4199).
3965 (Fset_window_hscroll): Ditto.
3967 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3969 Fix minor new problems caught by GCC 4.6.1.
3970 * term.c (init_tty): Remove unused local.
3971 * xsettings.c (store_monospaced_changed): Define this function only
3972 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3975 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3977 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3979 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3981 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3982 are the mini-buffer and the echo area (bug#3320).
3984 * term.c (init_tty): Remove support for supdup, c10 and perq
3985 terminals, which are no longer supported (bug#1482).
3987 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3989 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3991 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3993 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3994 for non-popups (Bug#3642).
3996 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3998 * alloc.c (reset_malloc_hooks): Protoize.
3999 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4000 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4001 * cm.c (losecursor): Likewise.
4002 * data.c (fmod): Likewise.
4003 * dispnew.c (swap_glyphs_in_rows): Likewise.
4004 * emacs.c (memory_warning_signal): Likewise.
4005 * floatfns.c (float_error): Likewise.
4006 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4007 (otf_open, font_otf_capability, generate_otf_features)
4008 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4010 * image.c (pbm_read_file): Likewise.
4011 * indent.c (string_display_width): Likewise.
4012 * intervals.c (check_for_interval, search_for_interval)
4013 (inc_interval_count, count_intervals, root_interval)
4014 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4015 * lread.c (defalias): Likewise.
4016 * ralloc.c (r_alloc_check): Likewise.
4017 * regex.c (set_image_of_range_1, set_image_of_range)
4018 (regex_grow_registers): Likewise.
4019 * sysdep.c (strerror): Likewise.
4020 * termcap.c (valid_filename_p, tprint, main): Likewise.
4021 * tparam.c (main): Likewise.
4022 * unexhp9k800.c (run_time_remap, save_data_space)
4023 (update_file_ptrs, read_header, write_header, calculate_checksum)
4024 (copy_file, copy_rest, display_header): Likewise.
4025 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4027 * xdisp.c (check_it): Likewise.
4028 * xfaces.c (register_color, unregister_color, unregister_colors):
4030 * xfns.c (print_fontset_result): Likewise.
4031 * xrdb.c (member, fatal, main): Likewise.
4033 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4035 Fix minor problems found by static checking (Bug#9031).
4036 * chartab.c (char_table_set_range, map_sub_char_table):
4037 Remove unused locals.
4038 (uniprop_table): Now static.
4039 * composite.c (_work_char): Remove unused static var.
4041 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4043 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4045 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4047 * gtkutil.c (qttip_cb): Remove code without function.
4049 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4051 * w32.c (pthread_sigmask): New stub.
4053 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4055 Use pthread_sigmask, not sigprocmask (Bug#9010).
4056 sigprocmask is portable only for single-threaded applications, and
4057 Emacs can be multi-threaded when it uses GTK.
4058 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4060 * callproc.c (Fcall_process):
4061 * process.c (create_process):
4062 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4063 Use pthread_sigmask, not sigprocmask.
4065 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4067 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4068 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4071 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4073 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4074 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4075 (xg_hide_tooltip): Fix comment.
4077 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4078 in registerServicesMenuSendTypes.
4079 (validRequestorForSendType): Don't check ns_return_types.
4081 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4084 2011-07-08 Jason Rumney <jasonr@gnu.org>
4086 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4087 SH_SHOW for hidden windows (Bug#5482).
4089 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4090 frame struct members of non-existent frames (Bug#6284).
4092 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4094 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4095 variable firstTime not needed on OSX >= 10.6.
4096 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4097 >= 10.5. Use setKnobProportion, setDoubleValue.
4099 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4100 (MAC_OS_X_VERSION_10_5): Define if not defined.
4101 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4102 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4103 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4105 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4106 cString and lossyCString on OSX >= 10.4
4108 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4109 sizeToFit on OSX >= 10.2.
4111 * nsimage.m (allocInitFromFile): Don't use deprecated method
4112 bestRepresentationForDevice on OSX >= 10.6.
4114 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4117 * emacs.c: Declare unexec_init_emacs_zone.
4119 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4121 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4123 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4124 on svcsMenu (Bug#8842).
4126 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4128 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4130 * nsterm.m (QUTF8_STRING): Declare.
4131 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4132 (validRequestorForSendType): Return type is (id).
4133 Change indexOfObjectIdenticalTo to indexOfObject.
4134 Check if we have local selection before returning self (Bug#8842).
4135 (writeSelectionToPasteboard): Put local selection into paste board
4136 if we have a local selection (Bug#8842).
4137 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4139 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4140 (ns_get_local_selection): Declare.
4142 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4144 * keymap.c (describe_map_tree): Don't insert a double newline at
4145 the end of the buffer (bug#1169) and return whether we inserted
4148 * callint.c (Fcall_interactively): Change "reading args" to
4149 "providing args" to try to clarify what it does (bug#1010).
4151 2011-07-07 Kenichi Handa <handa@m17n.org>
4153 * composite.c (composition_compute_stop_pos): Ignore a static
4154 composition starting before CHARPOS (Bug#8915).
4156 * xdisp.c (handle_composition_prop): Likewise.
4158 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4160 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4163 2011-07-07 Kenichi Handa <handa@m17n.org>
4165 * character.h (unicode_category_t): New enum type.
4167 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4168 (Qchar_code_property_table): New variable.
4169 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4170 (UNIPROP_COMPRESSED_FORM_P): New macros.
4171 (char_table_ascii): Uncompress the compressed values.
4172 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4173 Uncompress the compressed values.
4174 (sub_char_table_ref_and_range): Likewise.
4175 (char_table_ref_and_range): Uncompress the compressed values.
4176 (sub_char_table_set): New arg is_uniprop. Callers changed.
4177 Uncompress the compressed values.
4178 (sub_char_table_set_range): Args changed. Callers changed.
4179 (char_table_set_range): Adjuted for the above change.
4180 (map_sub_char_table): Delete args default_val and parent. Add arg
4181 top. Give decoded values to a Lisp function.
4182 (map_char_table): Adjust for the above change. Give decoded
4183 values to a Lisp function. Gcpro more variables.
4184 (uniprop_table_uncompress)
4185 (uniprop_decode_value_run_length): New functions.
4186 (uniprop_decoder, uniprop_decoder_count): New variables.
4187 (uniprop_get_decoder, uniprop_encode_value_character)
4188 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4190 (uniprop_encoder, uniprop_encoder_count): New variables.
4191 (uniprop_get_encoder, uniprop_table)
4192 (Funicode_property_table_internal, Fget_unicode_property_internal)
4193 (Fput_unicode_property_internal): New functions.
4194 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4195 Sunicode_property_table_internal, Sget_unicode_property_internal,
4196 and Sput_unicode_property_internal. Defvar_lisp
4197 char-code-property-alist.
4199 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4200 Vunicode_category_table.
4202 * font.c (font_range): Adjust for the change of
4203 Vunicode_category_table.
4205 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4207 * m/iris4d.h: Remove file, move contents ...
4208 * s/irix6-5.h: ... here.
4210 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4212 Remove unportable assumption about struct layout (Bug#8884).
4213 * alloc.c (mark_buffer):
4214 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4215 (clone_per_buffer_values): Don't assume that
4216 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4217 This isn't true in general, and it's particularly not true
4218 if Emacs is configured with --with-wide-int.
4219 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4220 New macros, used in the buffer.c change.
4222 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4224 * xsettings.c: Use both GConf and GSettings if both are available.
4225 (store_config_changed_event): Add comment.
4226 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4227 (store_tool_bar_style_changed): New functions.
4228 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4229 (struct xsettings): Move font inside HAVE_XFT.
4230 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4231 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4232 Move inside HAVE_XFT.
4233 (something_changed_gsettingsCB): Rename from something_changedCB.
4234 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4236 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4237 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4238 (something_changed_gconfCB): Rename from something_changedCB.
4239 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4240 (parse_settings): Move check for font inside HAVE_XFT.
4241 (read_settings, apply_xft_settings): Add comment.
4242 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4243 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4244 call store_font_name_changed.
4245 (xft_settings_event): Add comment.
4246 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4247 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4248 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4249 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4250 (xsettings_initialize): Call init_gsettings last.
4251 (xsettings_get_system_font, xsettings_get_system_normal_font):
4254 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4256 Random fixes. E.g., (random) never returned negative values.
4257 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4258 subseconds part to the entropy, as that's a bit more random.
4259 Prefer signed to unsigned, since the signedness doesn't matter and
4260 in general we prefer signed. When given a limit, use a
4261 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4262 latter isn't right if USE_2_TAGS_FOR_INTS.
4263 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4264 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4266 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4268 * textprop.c (text_property_stickiness):
4269 Obey Vtext_property_default_nonsticky.
4270 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4271 * w32fns.c (syms_of_w32fns):
4272 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4274 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4276 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4277 This is more efficient than Ffile_directory_p and avoids a minor race.
4279 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4281 * buffer.c (Foverlay_put): Say what the return value is
4284 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4285 is a directory before asking whether to use the file name
4287 (barf_or_query_if_file_exists): Make the "File is a directory"
4288 error be more correct.
4290 * fns.c (Frequire): Remove the mention of the .gz files, since
4291 that's installation-specific, but keep the mention of
4292 `get-load-suffixes'.
4294 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4296 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4297 Report string overflow if the output is too long.
4299 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4301 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4302 (syms_of_gnutls): Remove duplicate DEFSYM for
4303 Qgnutls_bootprop_verify_hostname_error, an error for
4304 Qgnutls_bootprop_verify_error (which is no longer used).
4306 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4307 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4308 Also (re)move comments that are misplaced or no longer relevant.
4310 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4312 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4314 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4316 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4317 and background color parameters if they have been changed.
4319 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4321 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4323 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4325 * xsettings.c (SYSTEM_FONT): Define only when used.
4326 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4328 * keymap.c (access_keymap_1): Now static.
4330 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4332 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4333 leave any prefix arg for the up event (Bug#1586).
4335 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4337 * lread.c (syms_of_lread): Mention single symbols defined by
4338 `defvar' or `defconst' (bug#7154).
4340 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4341 (Frequire): Mention get-load-suffixes.
4343 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4345 * window.h (window): Remove clone_number slot.
4346 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4348 (make_parent_window, make_window, saved_window)
4349 (Fset_window_configuration, save_window_save): Don't deal with
4351 * buffer.c (Qclone_number): Remove declaration.
4352 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4354 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4356 Add multiple inheritance to keymaps.
4357 * keymap.c (Fmake_composed_keymap): New function.
4358 (Fset_keymap_parent): Simplify.
4359 (fix_submap_inheritance): Remove.
4360 (access_keymap_1): New function extracted from access_keymap to handle
4361 embedded parents and handle lists of maps.
4362 (access_keymap): Use it.
4363 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4364 (Fcopy_keymap): Handle embedded parents.
4365 (Fcommand_remapping, define_as_prefix): Simplify.
4366 (Fkey_binding): Simplify.
4367 (syms_of_keymap): Move minibuffer-local-completion-map,
4368 minibuffer-local-filename-completion-map,
4369 minibuffer-local-must-match-map, and
4370 minibuffer-local-filename-must-match-map to Elisp.
4371 (syms_of_keymap): Defsubr make-composed-keymap.
4372 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4373 (parse_menu_item): Trivial simplification.
4375 2011-07-01 Glenn Morris <rgm@gnu.org>
4377 * Makefile.in (SETTINGS_LIBS): Fix typo.
4379 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4381 * coding.c (Fencode_coding_string): Record the last coding system
4382 used, as the function doc string says (bug#8738).
4384 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4386 * xsettings.c (store_monospaced_changed): Take new font as arg and
4387 check for change against current_mono_font.
4388 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4389 (emacs_settings_constructor, emacs_settings_get_property)
4390 (emacs_settings_set_property, emacs_settings_class_init)
4391 (emacs_settings_init, gsettings_obj): Remove.
4392 (something_changedCB): New function for HAVE_GSETTINGS.
4393 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4394 with value as argument.
4395 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4396 g_settings_new (Bug#8967). Do not create gsettings_obj.
4397 Remove calls to g_settings_bind. Connect something_changedCB to
4400 * xgselect.c: Add defined (HAVE_GSETTINGS).
4401 (xgselect_initialize): Ditto.
4403 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4404 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4407 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4409 * eval.c (struct backtrace): Simplify and port the data structure.
4410 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4411 signed bit field, as this assumption is not portable and it makes
4412 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4413 "char debug_on_exit : 1" as this is not portable either; instead,
4414 use the portable "unsigned int debug_on_exit : 1". Remove unused
4415 member evalargs. Remove obsolete comments about cc bombing out.
4417 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4419 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4420 Let HAVE_GSETTINGS override HAVE_GCONF.
4421 (store_monospaced_changed): New function.
4422 (EMACS_SETTINGS): A new type derived from GObject to handle
4423 GSettings notifications.
4424 (emacs_settings_constructor, emacs_settings_get_property)
4425 (emacs_settings_set_property, emacs_settings_class_init):
4427 (gsettings_client, gsettings_obj): New variables.
4428 (GSETTINGS_SCHEMA): New define.
4429 (something_changedCB): Call store_monospaced_changed.
4430 (init_gsettings): New function.
4431 (xsettings_initialize): Call init_gsettings.
4432 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4435 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4438 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4440 * window.c (resize_root_window, grow_mini_window)
4441 (shrink_mini_window): Rename Qresize_root_window to
4442 Qwindow_resize_root_window and Qresize_root_window_vertically to
4443 Qwindow_resize_root_window_vertically.
4445 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4447 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4449 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4451 * makefile.w32-in: Redesign dependencies so they reflect more
4452 clearly which files are directly included by each source file,
4453 and not through other includes.
4455 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4457 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4458 (sort_overlays, overlay_strings): When an overlay's clone number
4459 matches the window's clone number process the overlay even if
4460 the overlay's window property doesn't match the current window.
4462 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4463 (Fwindow_hchild): Rename to Fwindow_left_child.
4464 (Fwindow_next): Rename to Fwindow_next_sibling.
4465 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4466 (resize_window_check): Rename to window_resize_check.
4467 (resize_window_apply): Rename to window_resize_apply.
4468 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4469 (Fdelete_other_windows_internal, resize_frame_windows)
4470 (Fsplit_window_internal, Fdelete_window_internal)
4471 (grow_mini_window, shrink_mini_window)
4472 (Fresize_mini_window_internal): Fix callers accordingly.
4474 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4476 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4477 (emacs_fixed_set_min_size): Remove.
4478 (emacs_fixed_new): Take frame as argument.
4480 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4481 (_EmacsFixedPrivate): Remove minwidth/height.
4482 Add struct frame *f.
4483 (emacs_fixed_init): Initialize priv->f.
4484 (get_parent_class, emacs_fixed_set_min_size): Remove.
4485 (emacs_fixed_new): Set priv->f to argument.
4486 (emacs_fixed_get_preferred_width)
4487 (emacs_fixed_get_preferred_height): Use min_width/height from
4488 frames size_hint to set minimum and natural (Bug#8919).
4489 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4490 and use min_width/height from frames size_hint to set
4491 min_width/height (Bug#8919).
4493 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4494 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4497 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4499 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4500 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4503 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4505 * process.c (wait_reading_process_output): Bypass select if
4506 waiting for a cell while ignoring keyboard input, and input is
4507 pending. Suggested by Jan Djärv (Bug#8869).
4509 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4511 Use gnulib's dup2 module instead of rolling our own.
4512 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4514 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4516 * dispnew.c (scrolling_window): Before scrolling, turn off a
4517 mouse-highlight in the window being scrolled.
4519 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4521 Move DEFSYM to lisp.h and use everywhere.
4523 * character.h (DEFSYM): Move declaration...
4524 * lisp.h (DEFSYM): ...here.
4530 * w32select.c: Don't include character.h.
4532 * alloc.c (syms_of_alloc):
4533 * buffer.c (syms_of_buffer):
4534 * bytecode.c (syms_of_bytecode):
4535 * callint.c (syms_of_callint):
4536 * casefiddle.c (syms_of_casefiddle):
4537 * casetab.c (init_casetab_once):
4538 * category.c (init_category_once, syms_of_category):
4539 * ccl.c (syms_of_ccl):
4540 * cmds.c (syms_of_cmds):
4541 * composite.c (syms_of_composite):
4542 * dbusbind.c (syms_of_dbusbind):
4543 * dired.c (syms_of_dired):
4544 * dispnew.c (syms_of_display):
4545 * doc.c (syms_of_doc):
4546 * editfns.c (syms_of_editfns):
4547 * emacs.c (syms_of_emacs):
4548 * eval.c (syms_of_eval):
4549 * fileio.c (syms_of_fileio):
4550 * fns.c (syms_of_fns):
4551 * frame.c (syms_of_frame):
4552 * fringe.c (syms_of_fringe):
4553 * insdel.c (syms_of_insdel):
4554 * keymap.c (syms_of_keymap):
4555 * lread.c (init_obarray, syms_of_lread):
4556 * macros.c (syms_of_macros):
4557 * msdos.c (syms_of_msdos):
4558 * print.c (syms_of_print):
4559 * process.c (syms_of_process):
4560 * search.c (syms_of_search):
4561 * sound.c (syms_of_sound):
4562 * syntax.c (init_syntax_once, syms_of_syntax):
4563 * terminal.c (syms_of_terminal):
4564 * textprop.c (syms_of_textprop):
4565 * undo.c (syms_of_undo):
4566 * w32.c (globals_of_w32):
4567 * window.c (syms_of_window):
4568 * xdisp.c (syms_of_xdisp):
4569 * xfaces.c (syms_of_xfaces):
4570 * xfns.c (syms_of_xfns):
4571 * xmenu.c (syms_of_xmenu):
4572 * xsettings.c (syms_of_xsettings):
4573 * xterm.c (syms_of_xterm): Use DEFSYM.
4575 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4577 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4579 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4581 Integer and buffer overflow fixes (Bug#8873).
4583 * print.c (printchar, strout): Check for string overflow.
4584 (PRINTPREPARE, printchar, strout):
4585 Don't set size unless allocation succeeds.
4587 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4588 for sizes. Check for string overflow more accurately.
4589 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4591 * macros.c: Integer and buffer overflow fixes.
4592 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4593 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4594 Use ptrdiff_t, not int, for sizes.
4595 Don't increment bufsize until after realloc succeeds.
4596 Check for size-calculation overflow.
4597 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4599 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4601 * lread.c: Integer overflow fixes.
4602 (read_integer): Radix is now EMACS_INT, not int,
4603 to improve quality of diagnostics for out-of-range radices.
4604 Calculate buffer size correctly for out-of-range radices.
4605 (read1): Check for integer overflow in radices, and in
4606 read-circle numbers.
4607 (read_escape): Avoid int overflow.
4608 (Fload, openp, read_buffer_size, read1)
4609 (substitute_object_recurse, read_vector, read_list, map_obarray):
4610 Use ptrdiff_t, not int, for sizes.
4611 (read1): Use EMACS_INT, not int, for sizes.
4612 Check for size overflow.
4614 * image.c (cache_image): Check for size arithmetic overflow.
4616 * lread.c: Integer overflow issues.
4617 (saved_doc_string_size, saved_doc_string_length)
4618 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4619 Now ptrdiff_t, not int.
4620 (read1): Don't assume doc string length fits in int. Check for
4621 out-of-range doc string lengths.
4622 (read_list): Don't assume file position fits in int.
4623 (read_escape): Check for hex character overflow.
4625 2011-06-22 Leo Liu <sdl.web@gmail.com>
4627 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4628 Move to minibuffer.el.
4630 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4632 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4633 The following patches are for when GLYPH_DEBUG && !XASSERT.
4634 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4635 * dispnew.c (flush_stdout):
4636 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4637 Mark as externally visible.
4638 * dispnew.c (check_window_matrix_pointers): Now static.
4639 * dispnew.c (window_to_frame_vpos):
4640 * xfns.c (unwind_create_frame):
4641 * xterm.c (x_check_font): Remove unused local.
4642 * scroll.c (CHECK_BOUNDS):
4643 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4644 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4645 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4646 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4647 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4649 (debug_method_add): Use va_list and vsprintf rather than relying
4650 on undefined behavior with wrong number of arguments.
4651 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4652 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4653 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4654 since we're not interested in debugging glyphs with old libraries.
4655 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4656 GCC 4.6.0's static checking.
4658 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4660 Integer overflow and signedness fixes (Bug#8873).
4661 A few related buffer overrun fixes, too.
4663 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4665 * dispextern.h (struct face.stipple):
4666 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4667 (x_bitmap_mask, x_allocate_bitmap_record)
4668 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4669 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4670 (x_create_bitmap_from_xpm_data):
4671 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4672 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4674 * xfaces.c (load_pixmap):
4675 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4676 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4677 (.bitmaps_last, struct x_output.icon_bitmap):
4678 Use ptrdiff_t, not int, for bitmap indexes.
4679 (x_allocate_bitmap_record): Check for size overflow.
4680 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4682 Use ptrdiff_t, not int, for overlay counts.
4683 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4684 * editfns.c (overlays_around, get_pos_property):
4685 * textprop.c (get_char_property_and_overlay):
4686 * xdisp.c (next_overlay_change, note_mouse_highlight):
4687 * xfaces.c (face_at_buffer_position):
4688 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4689 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4690 (Fnext_overlay_change, Fprevious_overlay_change)
4691 (mouse_face_overlay_overlaps, Foverlays_in):
4692 Use ptrdiff_t, not int, for sizes.
4693 (overlays_at, overlays_in): Check for size-calculation overflow.
4695 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4697 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4698 (x_session_initialize): Do not assume string length fits in int.
4700 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4701 This is unlikely, but can occur if DPI is outlandish.
4703 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4704 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4706 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4707 * xrdb.c (magic_file_p, search_magic_path):
4708 Omit last arg SUFFIX; it was always 0. All callers changed.
4709 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4711 * xfont.c (xfont_match): Avoid need for strlen.
4713 * xfns.c: Don't assume strlen fits in int.
4714 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4716 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4717 not unsigned long, as we prefer signed integers. All callers changed.
4718 Detect integer overflow in repeat count.
4719 (message_dolog): Don't assume print length fits in 39 bytes.
4720 (display_mode_element): Don't assume strlen fits in int.
4722 * termcap.c: Don't assume sizes fit in int and never overflow.
4723 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4724 (gobble_line): Check for size-calculation overflow.
4726 * minibuf.c (Fread_buffer):
4727 * lread.c (intern, intern_c_string):
4728 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4729 Don't assume string length fits in int.
4731 * keyboard.c (parse_tool_bar_item):
4732 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4734 * font.c: Don't assume string length fits in int.
4735 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4736 Use ptrdiff_t, not int.
4737 (font_intern_prop): Don't assume string length fits in int.
4738 Don't assume integer property fits in fixnum.
4739 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4741 * filelock.c: Fix some buffer overrun and integer overflow issues.
4742 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4743 Reformulate so as not to need the command string.
4744 Invoke gzip -cd rather than gunzip, as it's more portable.
4745 (lock_info_type, lock_file_1, lock_file):
4746 Don't assume pid_t and time_t fit in unsigned long.
4747 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4748 (current_lock_owner): Prefer signed type for sizes.
4749 Use memcpy, not strncpy, where memcpy is what is really wanted.
4750 Don't assume (via atoi) that time_t and pid_t fit in int.
4751 Check for time_t and/or pid_t out of range, e.g., via a network share.
4752 Don't alloca where an auto var works fine.
4754 * fileio.c: Fix some integer overflow issues.
4755 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4756 Don't assume string length fits in int.
4757 (directory_file_name): Don't assume string length fits in long.
4758 (make_temp_name): Don't assume pid fits in int, or that its print
4759 length is less than 20.
4761 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4763 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4765 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4767 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4768 We prefer signed integers, even for size calculations.
4770 * emacs.c: Don't assume string length fits in 'int'.
4771 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4772 (main): Don't invoke strlen when not needed.
4774 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4775 (XD_DEBUG_MESSAGE): Don't waste a byte.
4777 * callproc.c (getenv_internal_1, getenv_internal)
4779 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4781 * lread.c (invalid_syntax): Omit length argument.
4782 All uses changed. This doesn't fix a bug, but it simplifies the
4783 code away from its former Hollerith-constant appearance, and it's
4784 one less 'int' to worry about when looking at integer-overflow issues.
4785 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4787 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4788 This didn't break anything, but it didn't help either.
4789 It's confusing to put a bogus integer in a place where the actual
4790 value does not matter.
4791 (LIST_END_P): Remove unused macro and its bogus comment.
4792 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4794 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4795 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4797 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4798 We prefer signed types, and the value cannot exceed the EMACS_INT
4799 range anyway (because otherwise the length would not be representable).
4800 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4801 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4802 This avoids a GCC warning when WIDE_EMACS_INT.
4804 * indent.c (sane_tab_width): New function.
4805 (current_column, scan_for_column, Findent_to, position_indentation)
4806 (compute_motion): Use it. This is just for clarity.
4807 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4809 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4811 * lisp.h (lint_assume): New macro.
4812 * composite.c (composition_gstring_put_cache):
4813 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4815 * editfns.c, insdel.c:
4816 Omit unnecessary forward decls, to simplify future changes.
4818 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4820 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4822 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4823 Use much-faster test for byte-length change.
4824 Don't assume string byte-length fits in 'int'.
4825 Check that character arg fits in 'int'.
4826 (mapcar1): Declare byte as byte, for clarity.
4828 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4830 * fns.c (concat): Catch string overflow earlier.
4831 Do not rely on integer wraparound.
4833 * dispextern.h (struct it.overlay_strings_charpos)
4834 (struct it.selective): Now EMACS_INT, not int.
4835 * xdisp.c (forward_to_next_line_start)
4836 (back_to_previous_visible_line_start)
4837 (reseat_at_next_visible_line_start, next_element_from_buffer):
4838 Don't arbitrarily truncate the value of 'selective' to int.
4840 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4842 * composite.c: Don't truncate sizes to 'int'.
4843 (composition_gstring_p, composition_reseat_it)
4844 (composition_adjust_point): Use EMACS_INT, not int.
4845 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4846 not EMACS_UINT, for indexes.
4848 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4850 * buffer.c: Include <verify.h>.
4851 (struct sortvec.priority, struct sortstr.priority):
4852 Now EMACS_INT, not int.
4853 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4854 (struct sortstr.size, record_overlay_string)
4855 (struct sortstrlist.size, struct sortlist.used):
4856 Don't truncate size to int.
4857 (record_overlay_string): Check for size-calculation overflow.
4858 (init_buffer_once): Check at compile-time, not run-time.
4860 2011-06-22 Jim Meyering <meyering@redhat.com>
4862 Don't leak an XBM-image-sized buffer
4863 * image.c (xbm_load): Free the image buffer after using it.
4865 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4868 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4869 that Sun C diagnosed.
4870 * fns.c (secure_hash): Fix pointer signedness issue.
4871 * intervals.c (static_offset_intervals): New function.
4872 (offset_intervals): Use it.
4874 2011-06-21 Leo Liu <sdl.web@gmail.com>
4877 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4880 * fns.c (secure_hash): Rename from crypto_hash_function and change
4881 the first arg to accept symbols.
4882 (Fsecure_hash): New primitive.
4883 (syms_of_fns): New symbols.
4885 2011-06-20 Deniz Dogan <deniz@dogan.se>
4887 * process.c (Fset_process_buffer): Clarify return value in
4890 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4892 * dispnew.c (add_window_display_history): Use BVAR.
4894 * xdisp.c (debug_method_add): Use BVAR.
4895 (check_window_end, dump_glyph_matrix, dump_glyph)
4896 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4898 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4901 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4902 check till after the cache is created in init_frame_faces.
4904 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4906 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4908 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4910 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4911 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4912 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4914 Improve buffer-overflow checking (Bug#8873).
4915 * fileio.c (Finsert_file_contents):
4916 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4917 Remove the old (too-loose) buffer overflow checks.
4918 They weren't needed, since make_gap checks for buffer overflow.
4919 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4920 The old code merely checked for Emacs fixnum overflow, and relied
4921 on undefined (wraparound) behavior. The new code avoids undefined
4922 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4924 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4925 Tune. Don't use wider integers than needed. Don't use alloca.
4926 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4928 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4930 * insdel.c, lisp.h (buffer_overflow): New function.
4931 (insert_from_buffer_1, replace_range, replace_range_2):
4932 * insdel.c (make_gap_larger):
4933 * editfns.c (Finsert_char):
4934 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4936 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4938 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4940 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4942 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4943 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4945 * fileio.c: Don't assume EMACS_INT fits in off_t.
4946 (emacs_lseek): New static function.
4947 (Finsert_file_contents, Fwrite_region): Use it.
4948 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4950 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4952 * fns.c: Don't overflow int when computing a list length.
4953 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4954 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4955 truncation on 64-bit hosts. Check for QUIT every
4956 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4957 faster and is responsive enough.
4958 (Flength): Report an error instead of overflowing an integer.
4959 (Fsafe_length): Return a float if the value is not representable
4960 as a fixnum. This shouldn't happen except in contrived situations.
4961 (Fnthcdr, Fsort): Don't assume list length fits in int.
4962 (Fcopy_sequence): Don't assume vector length fits in int.
4964 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4965 (header_size, word_size): New constants.
4966 (allocate_vectorlike): Don't check size overflow here.
4967 (allocate_vector): Check it here instead, since this is the only
4968 caller of allocate_vectorlike that could cause overflow.
4969 Check that the new vector's length is representable as a fixnum.
4971 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4972 The previous code was bogus. For example, next_almost_prime (32)
4973 returned 39, which is undesirable as it is a multiple of 3; and
4974 next_almost_prime (24) returned 25, which is a multiple of 5 so
4975 why was the code bothering to check for multiples of 7?
4977 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4979 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4981 Variadic C functions now count arguments with ptrdiff_t.
4982 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4983 Back then I didn't know that the Emacs coding style prefers signed int.
4984 Also, in the meantime I found a few more instances where arguments
4985 were being counted with int, which may truncate counts on 64-bit
4986 machines, or EMACS_INT, which may be unnecessarily wide.
4987 * lisp.h (struct Lisp_Subr.function.aMANY)
4988 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4989 Arg counts are now ptrdiff_t, not size_t.
4990 All variadic functions and their callers changed accordingly.
4991 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4992 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4993 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4994 * callint.c (Fcall_interactively): Check arg count for overflow,
4995 to avoid potential buffer overrun. Use signed char, not 'int',
4996 for 'varies' array, so that we needn't bother to check its size
4997 calculation for overflow.
4998 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4999 * eval.c (apply_lambda):
5000 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5001 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5002 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5004 * callint.c (Fcall_interactively): Don't use index var as event count.
5006 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5007 * mem-limits.h (SIZE): Remove; no longer used.
5009 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5011 Remove unnecessary casts.
5012 * xterm.c (x_term_init):
5013 * xfns.c (x_set_border_pixel):
5014 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5015 These aren't needed now that we assume ANSI C.
5017 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5018 It's more likely to cause problems (due to unsigned overflow)
5021 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5023 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5025 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5027 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5029 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5031 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5033 GLYPH_CODE_FACE returns EMACS_INT, not int.
5034 * dispextern.h (merge_faces):
5035 * xfaces.c (merge_faces):
5036 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5037 Don't assume EMACS_INT fits in int.
5039 * character.h (CHAR_VALID_P): Remove unused parameter.
5040 * fontset.c, lisp.h, xdisp.c: All uses changed.
5042 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5044 * fns.c (concat): Minor tuning based on overflow analysis.
5045 This doesn't fix any bugs. Use int to hold character, instead
5046 of constantly refetching from Emacs object. Use XFASTINT, not
5047 XINT, for value known to be a character. Don't bother comparing
5048 a single byte to 0400, as it's always less.
5050 * floatfns.c (Fexpt):
5051 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5053 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5056 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5058 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5059 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5060 incorrectly succeed when S was a string, because 4294967386 was
5061 truncated before it was used.
5063 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5064 Otherwise, an out-of-range integer could cause undefined behavior
5067 * composite.c: Use int, not EMACS_INT, for characters.
5068 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5069 EMACS_INT, for values that are known to be in character range.
5070 This doesn't fix any bugs but is the usual style inside Emacs and
5071 may generate better code on 32-bit machines.
5073 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5074 This is for reasons similar to the recent CHAR_STRING fix.
5075 * charset.c (Fencode_char): Check that character arg is actually
5076 a character. Pass an int to ENCODE_CHAR.
5077 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5078 wider than 'int', as a compile-time check to prevent future regressions
5081 * character.c (char_string): Remove unnecessary casts.
5083 Make sure a 64-bit char is never passed to CHAR_STRING.
5084 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5085 by silently ignoring the top 32 bits, allowing some values
5086 that were far too large to be valid characters.
5087 * character.h: Include <verify.h>.
5088 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5089 arguments are no wider than unsigned, as a compile-time check
5090 to prevent future regressions in this area.
5092 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5093 (Fsubst_char_in_region):
5095 * xdisp.c (decode_mode_spec_coding):
5096 Adjust to CHAR_STRING's new requirement.
5097 * editfns.c (Finsert_char, Fsubst_char_in_region):
5098 * fns.c (concat): Check that character args are actually
5099 characters. Without this test, these functions did the wrong
5100 thing with wildly out-of-range values on 64-bit hosts.
5102 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5103 These casts should not be needed on 32-bit hosts, either.
5104 * keyboard.c (read_char):
5105 * lread.c (Fload): Remove casts to unsigned.
5107 * lisp.h (UNSIGNED_CMP): New macro.
5108 This fixes comparison bugs on 64-bit hosts.
5109 (ASCII_CHAR_P): Use it.
5110 * casefiddle.c (casify_object):
5111 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5112 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5113 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5114 * dispextern.h (FACE_FROM_ID):
5115 * keyboard.c (read_char): Use UNSIGNED_CMP.
5117 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5118 not to EMACS_INT, to avoid GCC warning.
5120 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5122 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5123 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5124 isn't needed on 32-bit machines.
5126 * buffer.c (Fgenerate_new_buffer_name):
5127 Use EMACS_INT for count, not int.
5128 (advance_to_char_boundary): Return EMACS_INT, not int.
5130 * data.c (Qcompiled_function): Now static.
5132 * window.c (window_body_lines): Now static.
5134 * image.c (gif_load): Rename local to avoid shadowing.
5136 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5137 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5138 * alloc.c (make_save_value): Integer argument is now of type
5140 (mark_object): Use ptrdiff_t, not int.
5141 * lisp.h (pD): New macro.
5142 * print.c (print_object): Use it.
5144 * alloc.c: Use EMACS_INT, not int, to count objects.
5145 (total_conses, total_markers, total_symbols, total_vector_size)
5146 (total_free_conses, total_free_markers, total_free_symbols)
5147 (total_free_floats, total_floats, total_free_intervals)
5148 (total_intervals, total_strings, total_free_strings):
5149 Now EMACS_INT, not int. All uses changed.
5150 (Fgarbage_collect): Compute overall total using a double, so that
5151 integer overflow is less likely to be a problem. Check for overflow
5152 when converting back to an integer.
5153 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5154 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5155 These were 'int' variables that could overflow on 64-bit hosts;
5156 they were never used, so remove them instead of repairing them.
5157 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5158 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5159 Previously, this ceilinged at INT_MAX, but that doesn't work on
5161 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5163 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5164 (allocate_vectorlike): Check for ptrdiff_t overflow.
5165 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5166 when a (possibly-narrower) signed value would do just as well.
5167 We prefer using signed arithmetic, to avoid comparison confusion.
5169 * alloc.c: Catch some string size overflows that we were missing.
5170 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5171 for convenience in STRING_BYTES_MAX.
5172 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5173 The definition here is exact; the one in lisp.h was approximate.
5174 (allocate_string_data): Check for string overflow. This catches
5175 some instances we weren't catching before. Also, it catches
5176 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5177 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5178 and ptrdiff_t and EMACS_INT are both 64 bits.
5180 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5181 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5182 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5184 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5186 * alloc.c (Fmake_string): Check for out-of-range init.
5188 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5190 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5192 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5194 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5195 xg_get_default_scrollbar_width.
5197 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5198 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5199 (style_changed_cb): Call update_theme_scrollbar_width and call
5200 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5201 all frames (Bug#8505).
5202 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5203 Call gtk_window_set_resizable if HAVE_GTK3.
5204 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5205 and height if HAVE_GTK3 (Bug#8505).
5206 (scroll_bar_width_for_theme): New variable.
5207 (update_theme_scrollbar_width): New function.
5208 (xg_get_default_scrollbar_width): Move code to
5209 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5210 (xg_initialize): Call update_theme_scrollbar_width.
5212 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5214 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5216 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5218 * frame.c (make_frame): Call other_buffer_safely instead of
5221 * window.c (temp_output_buffer_show): Call display_buffer with
5222 second argument Vtemp_buffer_show_specifiers and reset latter
5223 immediately after the call.
5224 (Vtemp_buffer_show_specifiers): New variable.
5225 (auto_window_vscroll_p, next_screen_context_lines)
5226 (Vscroll_preserve_screen_position): Remove leading asterisks from
5229 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5231 Fix minor problems found by GCC 4.6.0 static checking.
5232 * buffer.c (Qclone_number): Remove for now, as it's unused.
5233 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5234 (record_buffer): Remove unused local.
5235 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5236 (set_frame_buffer_list): Remove; unused.
5237 * frame.h (other_visible_frames): Remove decl.
5238 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5239 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5240 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5242 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5243 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5244 Define only if HAVE_GPM.
5245 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5246 (update_hints_inhibit): Remove; never set. All uses removed.
5247 * widgetprv.h (emacsFrameClassRec): Remove decl.
5248 * window.c (delete_deletable_window): Now returns void, since it
5249 wasn't returning anything.
5250 (compare_window_configurations): Remove unused locals.
5251 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5252 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5253 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5254 the same widths as pointers. This follows up on the 2011-05-06 patch.
5255 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5256 * xterm.h: Likewise.
5257 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5259 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5261 * makefile.w32-in: Update dependencies.
5262 (LISP_H): Add lib/intprops.h.
5264 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5266 * image.c (gif_load): Add animation frame delay to the metadata.
5267 (syms_of_image): Use DEFSYM. New symbol `delay'.
5269 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5271 * window.c (delete_deletable_window): Re-add.
5272 (Fset_window_configuration): Rewrite to handle dead buffers and
5273 consequently deletable windows.
5274 (window_tree, Fwindow_tree): Remove. Supply functionality in
5276 (compare_window_configurations): Simplify code.
5278 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5280 * image.c (imagemagick_load_image): Fix type mismatch.
5281 (Fimagemagick_types): Likewise.
5283 * window.h (replace_buffer_in_windows): Declare.
5285 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5287 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5288 Qclone_number. Remove external declaration of Qdelete_window.
5289 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5291 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5292 Run Qbuffer_list_update_hook if allowed.
5293 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5294 buffer list implementation.
5295 (other_buffer_safely): New function.
5296 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5297 calls to replace_buffer_in_windows and
5298 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5300 (record_buffer): Inhibit quitting and rewrite using quittable
5301 functions. Run Qbuffer_list_update_hook if allowed.
5302 (Frecord_buffer, Funrecord_buffer): New functions.
5303 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5304 Move switch-to-buffer to window.el.
5305 (bury-buffer): Move to window.el.
5306 (Vbuffer_list_update_hook): New variable.
5308 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5311 * window.h (resize_frame_windows): Move up in code.
5312 (Fwindow_frame): Remove EXFUN.
5313 (replace_buffer_in_all_windows): Remove prototype.
5314 (replace_buffer_in_windows_safely): Add prototype.
5316 * window.c: Declare Qdelete_window static again. Move down
5317 declaration of select_count.
5318 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5319 (Fother_window): Move to window.el.
5320 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5321 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5322 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5324 (replace_buffer_in_windows): Implement by calling
5325 Qreplace_buffer_in_windows.
5326 (replace_buffer_in_all_windows): Remove with some functionality
5327 moved into replace_buffer_in_windows_safely.
5328 (replace_buffer_in_windows_safely): New function.
5329 (select_window_norecord, select_frame_norecord): Move in front
5330 of run_window_configuration_change_hook. Remove now obsolete
5332 (Fset_window_buffer): Rewrite doc-string.
5333 Call Qrecord_window_buffer.
5334 (keys_of_window): Move binding for other-window to window.el.
5336 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5338 * dispextern.h (struct image): Replace data member, whose int_val
5339 and ptr_val fields were not used by anything, with a single
5342 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5343 (gif_clear_image, gif_load, imagemagick_load_image)
5344 (gs_clear_image, gs_load): Callers changed.
5346 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5348 * buffer.h: Include <time.h>, for time_t.
5349 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5351 Fix minor problems found by static checking.
5353 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5355 Make identifiers static if they are not used in other modules.
5356 * data.c (Qcompiled_function, Qframe, Qvector):
5357 * image.c (QimageMagick, Qsvg):
5358 * minibuf.c (Qmetadata):
5359 * window.c (resize_window_check, resize_root_window): Now static.
5360 * window.h (resize_window_check, resize_root_window): Remove decls.
5362 * window.c (window_deletion_count, delete_deletable_window):
5364 (window_body_lines): Now static.
5365 (Fdelete_other_windows_internal): Mark vars as initialized.
5366 Make sure 'resize_failed' is initialized.
5367 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5368 (resize_window_apply): Remove unused local.
5369 * window.h (delete_deletable_window): Remove decl.
5371 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5372 (imagemagick_load_image): Fix pointer signedness problem by changing
5373 last arg from unsigned char * to char *. All uses changed.
5374 Also, fix a local for similar reasons.
5375 Remove unused locals. Remove locals to avoid shadowing.
5376 (fn_rsvg_handle_free): Remove; unused.
5377 (svg_load, svg_load_image): Fix pointer signedness problem.
5378 (imagemagick_load_image): Don't use garbage pointer image_wand.
5380 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5382 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5384 * image.c (gif_load): Fix omitted cast error introduced by
5387 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5389 * window.h (resize_proportionally, orig_total_lines)
5390 (orig_top_line): Remove from window structure.
5391 (set_window_height, set_window_width, change_window_heights)
5392 (Fdelete_window): Remove prototypes.
5393 (resize_frame_windows): Remove duplicate declaration.
5395 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5397 * window.h (resize_frame_windows, resize_window_check)
5398 (delete_deletable_window, resize_root_window)
5399 (resize_frame_windows): Declare prototypes.
5401 * window.c (resize_window_apply): Make definition be "static" to
5402 match the prototype.
5404 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5406 * window.c: Remove declarations of Qwindow_size_fixed,
5407 window_min_size_1, window_min_size_2, window_min_size,
5408 size_window, window_fixed_size_p, enlarge_window, delete_window.
5409 Remove static from declaration of Qdelete_window, it's
5410 temporarily needed by Fbury_buffer.
5411 (replace_window): Don't assign orig_top_line and
5413 (Fdelete_window, delete_window): Remove. Window deletion is
5414 handled by window.el.
5415 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5416 Replace Fdelete_window calls with calls to Qdelete_window.
5417 (Fdelete_other_windows): Remove. Deleting other windows is
5418 handled by window.el.
5419 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5420 handled in window.el.
5421 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5422 Window minimum sizes are handled in window.el.
5423 (shrink_windows, size_window, set_window_height)
5424 (set_window_width, change_window_heights, window_height)
5425 (window_width, CURBEG, CURSIZE, enlarge_window)
5426 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5427 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5428 handled in window.el.
5429 (make_dummy_parent): Rename to make_parent_window and give it a
5430 second argument horflag.
5431 (make_window): Don't set resize_proportionally any more.
5432 (Fsplit_window): Remove. Windows are split in window.el.
5433 (save_restore_action, save_restore_orig_size)
5434 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5435 Resize mini windows in window.el.
5436 (grow_mini_window, shrink_mini_window): Implement by calling
5437 Qresize_root_window_vertically, resize_window_check and
5438 resize_window_apply.
5439 (saved_window, Fset_window_configuration, save_window_save):
5440 Do not handle orig_top_line, orig_total_lines, and
5441 resize_proportionally.
5442 (window_min_height, window_min_width): Move to window.el.
5443 (keys_of_window): Move bindings for delete-other-windows,
5444 split-window, delete-window and enlarge-window to window.el.
5446 * buffer.c: Temporarily extern Qdelete_window.
5447 (Fbury_buffer): Temporarily call Qdelete_window instead of
5448 Fdelete_window (Fbury_buffer will move to window.el soon).
5450 * frame.c (set_menu_bar_lines_1): Remove code handling
5451 orig_top_line and orig_total_lines.
5453 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5454 set_window_height but set heights directly.
5455 (change_frame_size_1): Use resize_frame_windows.
5457 * xdisp.c (init_xdisp): Don't use set_window_height but set
5460 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5461 Use resize_frame_windows instead of change_window_heights and run
5462 run_window_configuration_change_hook.
5464 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5465 instead of change_window_heights and run
5466 run_window_configuration_change_hook.
5468 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5470 * window.c (replace_window): Rename second argument REPLACEMENT to
5471 NEW. New third argument SETFLAG. Rewrite.
5472 (delete_window, make_dummy_parent): Call replace_window with
5474 (window_list_1): Move down in code.
5475 (run_window_configuration_change_hook): Move set_buffer part
5476 before select_frame_norecord part in order to unwind correctly.
5477 Rename count1 to count.
5478 (recombine_windows, delete_deletable_window, resize_root_window)
5479 (Fdelete_other_windows_internal)
5480 (Frun_window_configuration_change_hook, make_parent_window)
5481 (resize_window_check, resize_window_apply, Fresize_window_apply)
5482 (resize_frame_windows, Fsplit_window_internal)
5483 (Fdelete_window_internal, Fresize_mini_window_internal):
5485 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5487 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5489 * window.h (window): Add some new members to window structure -
5490 normal_lines, normal_cols, new_total, new_normal, clone_number,
5491 splits, nest, prev_buffers, next_buffers.
5492 (WINDOW_TOTAL_SIZE): Move here from window.c.
5493 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5495 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5497 (make_dummy_parent): Set new members of windows structure.
5498 (make_window): Move down in code. Handle new members of window
5500 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5501 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5502 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5503 (Fset_window_prev_buffers, Fwindow_next_buffers)
5504 (Fset_window_next_buffers, Fset_window_clone_number):
5506 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5507 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5509 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5510 Argument WINDOW can be now internal window too.
5511 (Fwindow_use_time): Move up in code.
5512 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5514 (Fset_window_configuration, saved_window)
5515 (Fcurrent_window_configuration, save_window_save): Handle new
5516 members of window structure.
5517 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5518 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5519 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5520 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5521 Qget_mru_window, Qresize_root_window,
5522 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5523 Qauto_buffer_name; staticpro them.
5525 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5527 * window.c (Fwindow_total_size, Fwindow_left_column)
5528 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5529 (Fwindow_list_1): New functions.
5530 (window_box_text_cols): Replace with window_body_cols.
5531 (Fwindow_width, Fscroll_left, Fscroll_right):
5532 Use window_body_cols instead of window_box_text_cols.
5533 (delete_window, Fset_window_configuration):
5534 Call delete_all_subwindows with window as argument.
5535 (delete_all_subwindows): Take a window as argument and not a
5537 (window_loop): Remove handling of GET_LRU_WINDOW and
5539 (Fget_lru_window, Fget_largest_window): Move to window.el.
5541 * window.h: Extern window_body_cols instead of
5542 window_box_text_cols. delete_all_subwindows now takes a
5543 Lisp_Object as argument.
5545 * indent.c (compute_motion, Fcompute_motion):
5546 Use window_body_cols instead of window_box_text_cols.
5548 * frame.c (delete_frame): Call delete_all_subwindows with root
5551 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5553 * fns.c (Fputhash): Document return value.
5555 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5557 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5559 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5561 Cons<->int and similar integer overflow fixes (Bug#8794).
5563 Check for overflow when converting integer to cons and back.
5564 * charset.c (Fdefine_charset_internal, Fdecode_char):
5565 Use cons_to_unsigned to catch overflow.
5566 (Fencode_char): Use INTEGER_TO_CONS.
5567 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5568 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5569 * data.c (long_to_cons, cons_to_long): Remove.
5570 (cons_to_unsigned, cons_to_signed): New functions.
5571 These signal an error for invalid or out-of-range values.
5572 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5573 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5574 * font.c (Ffont_variation_glyphs):
5575 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5576 * lisp.h: Include <intprops.h>.
5577 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5578 (cons_to_signed, cons_to_unsigned): New decls.
5579 (long_to_cons, cons_to_long): Remove decls.
5580 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5581 (Fprimitive_undo): Use CONS_TO_INTEGER.
5582 * xfns.c (Fx_window_property): Likewise.
5583 * xselect.c: Include <limits.h>.
5584 (x_own_selection, selection_data_to_lisp_data):
5585 Use INTEGER_TO_CONS.
5586 (x_handle_selection_request, x_handle_selection_clear)
5587 (x_get_foreign_selection, Fx_disown_selection_internal)
5588 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5589 (lisp_data_to_selection_data): Use cons_to_unsigned.
5590 (x_fill_property_data): Use cons_to_signed.
5591 Report values out of range.
5593 Check for buffer and string overflow more precisely.
5594 * buffer.h (BUF_BYTES_MAX): New macro.
5595 * lisp.h (STRING_BYTES_MAX): New macro.
5596 * alloc.c (Fmake_string):
5597 * character.c (string_escape_byte8):
5598 * coding.c (coding_alloc_by_realloc):
5599 * doprnt.c (doprnt):
5600 * editfns.c (Fformat):
5602 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5603 since they may not be the same number.
5604 * editfns.c (Finsert_char):
5605 * fileio.c (Finsert_file_contents):
5606 Likewise for BUF_BYTES_MAX.
5608 * image.c: Use ptrdiff_t, not int, for sizes.
5609 (slurp_file): Switch from int to ptrdiff_t.
5611 (slurp_file): Check that file size fits in both size_t (for
5612 malloc) and ptrdiff_t (for sanity and safety).
5614 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5615 if b->modtime has its maximal value.
5617 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5619 Don't assume time_t can fit into int.
5620 * buffer.h (struct buffer.modtime): Now time_t, not int.
5621 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5622 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5624 Minor fixes for signed vs unsigned integers.
5625 * character.h (MAYBE_UNIFY_CHAR):
5626 * charset.c (maybe_unify_char):
5627 * keyboard.c (read_char, reorder_modifiers):
5628 XINT -> XFASTINT, since the integer must be nonnegative.
5629 * ftfont.c (ftfont_spec_pattern):
5630 * keymap.c (access_keymap, silly_event_symbol_error):
5631 XUINT -> XFASTINT, since the integer must be nonnegative.
5632 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5633 since it makes no difference and we prefer signed.
5634 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5635 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5638 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5640 * window.h (Fwindow_frame): Declare.
5642 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5644 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5645 (SPARE_MEMORY): Always define.
5646 (LARGE_REQUEST): Remove.
5647 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5649 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5651 * lisp.h: Move EXFUNS for Fframe_root_window,
5652 Fframe_first_window and Fset_frame_selected_window to window.h.
5654 * window.h: Move EXFUNS for Fframe_root_window,
5655 Fframe_first_window and Fset_frame_selected_window here from
5658 * frame.c (Fwindow_frame, Fframe_first_window)
5659 (Fframe_root_window, Fframe_selected_window)
5660 (Fset_frame_selected_window): Move to window.c.
5661 (Factive_minibuffer_window): Move to minibuf.c.
5662 (Fother_visible_frames_p): New function.
5664 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5666 * window.c (decode_window, decode_any_window): Move up in code.
5667 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5668 (inhibit_frame_unsplittable): Remove unused variable.
5669 (Fwindow_buffer): Move up and rewrite doc-string.
5670 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5671 (Fwindow_prev): New functions.
5672 (Fwindow_frame): Move here from frame.c. Accept any window as
5674 (Fframe_root_window, Fframe_first_window)
5675 (Fframe_selected_window): Move here from frame.c. Accept frame
5676 or arbitrary window as argument. Update doc-strings.
5677 (Fminibuffer_window): Move up in code.
5678 (Fwindow_minibuffer_p): Move up in code and simplify.
5679 (Fset_frame_selected_window): Move here from frame.c.
5681 (Fselected_window, select_window, Fselect_window): Move up in
5682 code. Minor doc-string fixes.
5684 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5686 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5687 Do not assume that spare memory exists; that assumption is valid
5688 only if SYSTEM_MALLOC.
5689 (LARGE_REQUEST): New macro, so that the issue of large requests
5690 is separated from the issue of spare memory.
5692 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5694 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5697 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5699 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5702 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5704 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5706 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5708 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5709 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5711 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5713 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5715 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5717 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5718 (x_clipboard_manager_save): Add return value.
5719 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5721 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5722 Obey Vx_select_enable_clipboard_manager. Catch errors in
5723 x_clipboard_manager_save (Bug#8779).
5724 (Vx_select_enable_clipboard_manager): New variable.
5725 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5727 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5729 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5731 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5733 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5734 in the current matrix if keep_current_p is non-zero.
5736 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5738 * bidi.c (bidi_level_of_next_char): Fix last change.
5740 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5742 Support bidi reordering of text covered by display properties.
5744 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5745 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5746 (bidi_cache_search, bidi_cache_iterator_state)
5747 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5748 (bidi_level_of_next_char, bidi_move_to_visually_next):
5749 Support character positions inside a run of characters covered by a
5751 (bidi_paragraph_init, bidi_resolve_explicit_1)
5752 (bidi_level_of_next_char): Call bidi_fetch_char and
5753 bidi_fetch_char_advance instead of FETCH_CHAR and
5755 (bidi_init_it): Initialize new members.
5756 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5758 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5759 instead of using explicit *_CHAR codes.
5760 (bidi_resolve_explicit, bidi_resolve_weak):
5761 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5762 bidirectional text is supported only in multibyte buffers.
5763 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5764 it to initialize the frame_window_p member of struct bidi_it.
5765 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5766 (bidi_resolve_explicit, bidi_resolve_weak)
5767 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5768 bidi_it->nchars is non-positive.
5769 (bidi_level_of_next_char): Don't try to lookup the cache for the
5770 next/previous character if nothing is cached there yet, or if we
5771 were just reseat()'ed to a new position.
5773 * xdisp.c (set_cursor_from_row): Set start and stop points
5774 according to the row's direction when priming the loop that looks
5775 for the glyph on which to display cursor.
5776 (single_display_spec_intangible_p): Function deleted.
5777 (display_prop_intangible_p): Reimplement to call
5778 handle_display_spec instead of single_display_spec_intangible_p.
5779 Accept 3 additional arguments needed by handle_display_spec.
5780 This fixes incorrect cursor motion across display property with complex
5781 values: lists, `(when COND...)' forms, etc.
5782 (single_display_spec_string_p): Support property values that are
5783 lists with the argument STRING its top-level element.
5784 (display_prop_string_p): Fix the condition for processing a
5785 property that is a list to be consistent with handle_display_spec.
5786 (handle_display_spec): New function, refactored from the
5787 last portion of handle_display_prop.
5788 (compute_display_string_pos): Accept additional argument
5789 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5790 value of a `display' property is a "replacing spec".
5791 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5792 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5793 the display property, but just return a value indicating whether
5794 the display property will replace the characters it covers.
5795 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5796 frame_window_p members of struct bidi_it.
5797 (compute_display_string_pos, compute_display_string_end):
5799 (push_it): Accept second argument POSITION, where pop_it should
5800 jump to continue iteration.
5801 (reseat_1): Initialize bidi_it.disp_pos.
5803 * keyboard.c (adjust_point_for_property): Adjust the call to
5804 display_prop_intangible_p to its new signature.
5806 * dispextern.h (struct bidi_it): New member frame_window_p.
5807 (bidi_init_it): Update prototypes.
5808 (display_prop_intangible_p): Update prototype.
5809 (compute_display_string_pos, compute_display_string_end):
5811 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5814 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5816 Malloc failure behavior now depends on size of allocation.
5817 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5818 * lisp.h: Change signatures accordingly.
5819 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5820 All callers changed. (Bug#8762)
5822 * gnutls.c: Use Emacs's memory allocators.
5823 Without this change, the gnutls library would invoke malloc etc.
5824 directly, which causes problems on non-SYNC_INPUT hosts, and which
5825 runs afoul of improving memory_full behavior. (Bug#8761)
5826 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5827 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5828 xfree instead of the default malloc, realloc, free.
5829 (Fgnutls_boot): No need to check for memory allocation failure,
5830 since xmalloc does that for us.
5832 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5833 * category.c (hash_get_category_set):
5834 * ccl.c (ccl_driver):
5835 * charset.c (Fdefine_charset_internal):
5836 * charset.h (struct charset.hash_index):
5837 * composite.c (get_composition_id, gstring_lookup_cache)
5838 (composition_gstring_put_cache):
5839 * composite.h (struct composition.hash_index):
5840 * dispextern.h (struct image.hash):
5841 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5842 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5843 (hashfn_equal, hashfn_user_defined, make_hash_table)
5844 (maybe_resize_hash_table, hash_lookup, hash_put)
5845 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5846 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5847 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5848 * image.c (make_image, search_image_cache, lookup_image)
5849 (xpm_put_color_table_h):
5850 * lisp.h (struct Lisp_Hash_Table):
5851 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5852 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5853 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5854 * alloc.c (allocate_vectorlike):
5855 Check for overflow in vector size calculations.
5856 * ccl.c (ccl_driver):
5857 Check for overflow when converting EMACS_INT to int.
5858 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5859 need to be updated by these changes.
5860 * fns.c (make_hash_table, maybe_resize_hash_table):
5861 Check for integer overflow with large hash tables.
5862 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5863 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5864 (SXHASH_REDUCE): New macro.
5865 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5866 Use it instead of discarding useful hash info with large hash values.
5867 (sxhash_float): New function.
5868 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5869 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5870 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5871 Rewrite to use FIXNUM_BITS, as this simplifies things.
5872 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5873 Adjust signatures to match updated version of code.
5874 (consing_since_gc): Now EMACS_INT, since a single hash table can
5875 use more than INT_MAX bytes.
5877 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5879 Make it possible to build with GCC-4.6+ -O2 -flto.
5881 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5883 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5885 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5886 Call minibuffer-inactive-mode.
5888 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5890 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5891 Update dependencies.
5893 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5895 * data.c (init_data): Remove code for UTS, this system is not
5898 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5900 Don't force ./temacs to start in terminal mode.
5902 * frame.c (make_initial_frame): Initialize faces in all cases, not
5903 only when CANNOT_DUMP is defined.
5904 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5906 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5908 * dispnew.c (add_window_display_history): Use const for the string
5909 pointer. Remove declaration, not needed.
5911 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5913 Use 'inline', not 'INLINE'.
5914 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5915 * alloc.c, fontset.c (INLINE): Remove.
5916 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5917 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5918 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5919 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5920 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5922 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5924 Make it possible to run ./temacs.
5926 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5927 syms_of_callproc does the same thing. Remove test for
5928 "initialized", do it in the caller.
5929 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5931 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5933 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5934 (read_minibuf): Use get_minibuffer.
5935 (syms_of_minibuf): Use DEFSYM.
5936 (Qmetadata): New var.
5937 * data.c (Qbuffer): Don't make it static.
5938 (syms_of_data): Use DEFSYM.
5940 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5942 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5943 (CCL_CODE_MIN): New macro.
5945 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5947 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5949 * eval.c (Qdebug): Now static.
5950 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5951 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5952 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5954 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5956 * image.c: Various fixes to ImageMagick code comments.
5957 (Fimagemagick_types): Doc fix.
5959 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5961 Minor fixes prompted by GCC 4.6.0 warnings.
5963 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5965 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5966 (x_clipboard_manager_save_all): Move extern decl to ...
5967 * xterm.h: ... here, so that it can be checked for consistency.
5969 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5971 * xselect.c (x_clipboard_manager_save_frame)
5972 (x_clipboard_manager_save_all): New functions.
5973 (Fx_clipboard_manager_save): Lisp function deleted.
5975 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5976 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5978 * xterm.h: Update prototype.
5980 2011-05-28 William Xu <william.xwl@gmail.com>
5982 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5985 2011-05-28 Jim Meyering <meyering@redhat.com>
5987 Avoid a sign-extension bug in crypto_hash_function.
5988 * fns.c (to_uchar): Define.
5989 (crypto_hash_function): Use it to convert some newly-signed
5990 variables to unsigned, to avoid sign-extension bugs. For example,
5991 without this change, (md5 "truc") would evaluate to
5992 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5993 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5994 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5996 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5998 Integer overflow fixes.
6000 * dbusbind.c: Serial number integer overflow fixes.
6001 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6002 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6003 to hold a serial number that is too large for a fixnum.
6004 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6005 Check for serial numbers out of range. Decode any serial number
6006 that was so large that it became a float. (Bug#8722)
6008 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6009 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6010 Use XFASTINT rather than XUINT when numbers are nonnegative.
6011 (xd_append_arg, Fdbus_method_return_internal):
6012 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6013 arguments, check that Lisp number is nonnegative, rather than
6014 silently wrapping negative numbers around. (Bug#8722)
6015 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6018 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6020 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6022 ccl: Add integer overflow checks.
6023 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6024 (IN_INT_RANGE): New macros.
6025 (ccl_driver): Use them to check for integer overflow when
6026 decoding a CCL program. Many of the new checks are whether XINT (x)
6027 fits in int; it doesn't always, on 64-bit hosts. The new version
6028 doesn't catch all possible integer overflows, but it's an
6029 improvement. (Bug#8719)
6031 * alloc.c (make_event_array): Use XINT, not XUINT.
6032 There's no need for unsigned here.
6034 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6035 This follows up to the 2011-05-06 change that substituted uintptr_t
6036 for EMACS_INT. This case wasn't caught back then.
6038 Rework Fformat to avoid integer overflow issues.
6039 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6040 now (part of C89). Include <verify.h>.
6041 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6042 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6043 (Fformat): Avoid the prepass trying to compute sizes; it was only
6044 approximate and thus did not catch overflow reliably. Instead, walk
6045 through the format just once, formatting and computing sizes as we go,
6046 checking for integer overflow at every step, and allocating a larger
6047 buffer as needed. Keep track separately whether the format is
6048 multibyte. Keep only the most-recently calculated precision, rather
6049 than them all. Record whether each argument has been converted to
6050 string. Use EMACS_INT, not int, for byte and char and arg counts.
6051 Support field widths and precisions larger than INT_MAX. Avoid
6052 sprintf's undefined behavior with conversion specifications such as %#d
6053 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6054 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6055 formatting out-of-range floating point numbers with int
6058 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6060 * data.c: Avoid integer truncation in expressions involving floats.
6061 * data.c: Include <intprops.h>.
6062 (arith_driver): When there's an integer overflow in an expression
6063 involving floating point, convert the integers to floating point
6064 so that the resulting value does not suffer from catastrophic
6065 integer truncation. For example, on a 64-bit host (* 4
6066 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6067 Do not rely on undefined behavior after integer overflow.
6069 merge count_size_as_multibyte, parse_str_to_multibyte
6070 * character.c, character.h (count_size_as_multibyte):
6071 Rename from parse_str_to_multibyte; all uses changed.
6072 Check for integer overflow.
6073 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6074 since it's now a duplicate of the other. This is more of
6075 a character than a buffer op, so better that it's in character.c.
6076 * fns.c, print.c: Adjust to above changes.
6078 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6080 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6082 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6084 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6085 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6086 (x_clipboard_manager_save): Now static.
6087 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6089 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6090 (crypto_hash_function): Now static.
6091 Fix pointer signedness problems. Avoid unnecessary initializations.
6093 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6095 * termhooks.h (Vselection_alist): Make it terminal-local.
6097 * terminal.c (create_terminal): Initialize it.
6099 * xselect.c: Support for clipboard managers.
6100 (Vselection_alist): Move to termhooks.h as terminal-local var.
6101 (LOCAL_SELECTION): New macro.
6102 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6103 (symbol_to_x_atom): Remove gratuitous arg.
6104 (x_handle_selection_request, lisp_data_to_selection_data)
6105 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6106 (x_own_selection, x_get_local_selection, x_convert_selection):
6107 New arg, specifying work frame. Use terminal-local Vselection_alist.
6108 (some_frame_on_display): Delete unused function.
6109 (Fx_own_selection_internal, Fx_get_selection_internal)
6110 (Fx_disown_selection_internal, Fx_selection_owner_p)
6111 (Fx_selection_exists_p): New optional frame arg.
6112 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6113 (x_handle_selection_clear): Don't treat other terminals with the
6114 same keyboard specially. Use the terminal-local Vselection_alist.
6115 (x_clear_frame_selections): Use Frun_hook_with_args.
6117 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6119 * xterm.h: Add support for those atoms.
6121 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6123 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6124 (converted_selections, conversion_fail_tag): New global variables.
6125 (x_selection_request_lisp_error): Free the above.
6126 (x_get_local_selection): Remove unnecessary code.
6127 (x_reply_selection_request): Args changed; handle arbitrary array
6128 of converted selections stored in converted_selections.
6129 Separate the XChangeProperty and SelectionNotify steps.
6130 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6131 (x_convert_selection): New function.
6132 (x_handle_selection_event): Simplify.
6133 (x_get_foreign_selection): Don't ignore incoming requests while
6134 waiting for an answer; this will fail when we implement
6135 SAVE_TARGETS, and seems unnecessary anyway.
6136 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6137 (Vx_sent_selection_functions): Doc fix.
6139 2011-05-26 Leo Liu <sdl.web@gmail.com>
6141 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6143 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6145 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6147 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6148 for fringe update if it has periodic bitmap.
6149 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6150 and fringe_bitmap_periodic_p.
6152 * fringe.c (get_fringe_bitmap_data): New function.
6153 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6154 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6155 row. Mark glyph row for fringe update if periodicity changed.
6157 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6158 for fringe update unless it has periodic bitmap.
6160 2011-05-25 Kenichi Handa <handa@m17n.org>
6162 * xdisp.c (get_next_display_element): Set correct it->face_id for
6163 a static composition.
6165 2011-05-24 Leo Liu <sdl.web@gmail.com>
6168 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6170 * fns.c (crypto_hash_function, Fsha1): New function.
6171 (Fmd5): Use crypto_hash_function.
6172 (syms_of_fns): Add Ssha1.
6174 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6176 * gnutls.c: Remove unused macros.
6177 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6178 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6179 Remove macros that are defined and never used.
6180 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6182 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6184 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6185 (Fx_get_selection_internal): Minor cleanup.
6186 (Fx_own_selection_internal): Rename arguments for consistency with
6189 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6191 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6193 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6195 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6197 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6199 * dispnew.c (scrolling_window): Don't exclude the case that the
6200 last enabled row in the desired matrix touches the bottom boundary.
6202 2011-05-21 Glenn Morris <rgm@gnu.org>
6204 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6205 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6206 and add some more files.
6208 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6210 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6211 report_file_error introduced by the change from 2011-05-07.
6213 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6215 * systime.h (Time): Define only if emacs is defined.
6216 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6217 where the include path doesn't have X11/X.h by default. See
6218 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6220 2011-05-20 Kenichi Handa <handa@m17n.org>
6222 * composite.c (find_automatic_composition): Fix previous change.
6224 2011-05-20 Glenn Morris <rgm@gnu.org>
6226 * lisp.mk: New file, split from Makefile.in.
6227 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6228 (shortlisp): Remove.
6229 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6231 2011-05-19 Glenn Morris <rgm@gnu.org>
6233 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6234 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6235 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6236 (lisp): Set the order to that of loadup.el.
6237 (shortlisp): Make it a copy of $lisp.
6238 (SOME_MACHINE_LISP): Remove.
6239 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6240 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6242 2011-05-18 Kenichi Handa <handa@m17n.org>
6244 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6245 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6246 (find_automatic_composition): Mostly rewrite for efficiency.
6248 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6250 * makefile.w32-in: Update dependencies.
6252 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6254 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6255 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6257 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6259 Fix some integer overflow issues, such as string length overflow.
6261 * insdel.c (count_size_as_multibyte): Check for string overflow.
6263 * character.c (lisp_string_width): Check for string overflow.
6264 Use EMACS_INT, not int, for string indexes and lengths; in
6265 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6266 the resulting string length overflows an EMACS_INT; instead,
6267 report a string overflow if no precision given. When checking for
6268 precision exhaustion, use a check that cannot possibly have
6269 integer overflow. (Bug#8675)
6270 * character.h (lisp_string_width): Adjust to new signature.
6272 * alloc.c (string_overflow): New function.
6273 (Fmake_string): Use it. This doesn't change behavior, but saves
6274 a few bytes and will simplify future changes.
6275 * character.c (string_escape_byte8): Likewise.
6276 * lisp.h (string_overflow): New decl.
6278 Fixups, following up to the user-interface timestamp change.
6279 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6280 for UI timestamps, instead of unsigned long.
6281 * msdos.c (mouse_get_pos): Likewise.
6282 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6283 * w32gui.h (Time): Define by including "systime.h" rather than by
6284 declaring it ourselves. (Bug#8664)
6286 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6287 * image.c (clear_image_cache): Likewise.
6289 * term.c (term_mouse_position): Don't assume time_t wraparound.
6291 Be more systematic about user-interface timestamps.
6292 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6293 and sometimes 'EMACS_UINT', to represent these timestamps.
6294 This change causes it to use 'Time' uniformly, as that's what X uses.
6295 This makes the code easier to follow, and makes it easier to catch
6296 integer overflow bugs such as Bug#8664.
6297 * frame.c (Fmouse_position, Fmouse_pixel_position):
6298 Use Time, not unsigned long, for user-interface timestamps.
6299 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6300 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6301 * keyboard.h (last_event_timestamp): Likewise.
6302 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6303 * menu.h (xmenu_show): Likewise.
6304 * term.c (term_mouse_position): Likewise.
6305 * termhooks.h (struct input_event.timestamp): Likewise.
6306 (struct terminal.mouse_position_hook): Likewise.
6307 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6308 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6309 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6310 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6312 * menu.h, termhooks.h: Include "systime.h", for Time.
6314 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6315 Don't assume that the difference between two unsigned long values
6316 can fit into an integer. At this point, we know button_down_time
6317 <= event->timestamp, so the difference must be nonnegative, so
6318 there's no need to cast the result if double-click-time is
6319 nonnegative, as it should be; check that it's nonnegative, just in
6320 case. This bug is triggered when events are more than 2**31 ms
6321 apart (about 25 days). (Bug#8664)
6323 * xselect.c (last_event_timestamp): Remove duplicate decl.
6324 (x_own_selection): Remove needless cast to unsigned long.
6326 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6327 that always fit in int. Use a sentinel instead of a counter, to
6328 avoid a temp and to allay GCC's concerns about possible int overflow.
6329 * frame.h (struct frame): Use int for menu_bar_items_used
6330 instead of EMACS_INT, since it always fits in int.
6332 * menu.c (grow_menu_items): Check for int overflow.
6334 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6336 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6337 Before, the code was not consistent. These values cannot exceed
6338 2**31 - 1 so there's no need to make them unsigned.
6339 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6340 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6341 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6343 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6345 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6346 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6347 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6348 presumably because the widths might not match.
6350 * window.c (size_window): Avoid needless test at loop start.
6352 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6354 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6356 2011-05-12 Drew Adams <drew.adams@oracle.com>
6358 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6360 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6362 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6363 `width' to `bar_area_x' and `bar_area_width', respectively.
6364 (x_scroll_run): Take account of fringe background extension.
6366 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6367 Rename local vars `left' and `width' to `bar_area_x' and
6368 `bar_area_width', respectively.
6369 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6370 background extension.
6372 2011-05-10 Jim Meyering <meyering@redhat.com>
6374 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6376 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6378 * image.c (Finit_image_library): Return t for built-in image types,
6379 like pbm and xbm. (Bug#8640)
6381 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6383 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6385 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6387 * w32console.c (Fset_screen_color): Doc fix.
6388 (Fget_screen_color): New function.
6389 (syms_of_ntterm): Defsubr it.
6391 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6392 unlink the temporary file if Fcall_process didn't create it in the
6394 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6395 child process will be redirected to a file specified with `:file'.
6396 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6397 cue to call_process_cleanup not to close that handle.
6399 2011-05-07 Ben Key <bkey76@gmail.com>
6401 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6402 one of two shell specific rules, either bootstrap-temacs-CMD or
6403 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6404 to the previous implementation of the bootstrap-temacs rule.
6405 The bootstrap-temacs-CMD rule is similar to the previous
6406 implementation of the bootstrap-temacs rule except that it
6407 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6410 These changes, along with some changes to nt/configure.bat,
6411 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6412 earlier fix to add support for --cflags and --ldflags options
6413 that include quotes so that it works whether make uses cmd or
6416 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6418 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6419 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6421 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6422 a string. Handle both cases.
6423 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6424 (Fdbus_register_method): Use Qinvalid_function.
6426 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6428 * makefile.w32-in: Update dependencies.
6429 (LISP_H): Add inttypes.h and stdin.h.
6430 (PROCESS_H): Add unistd.h.
6432 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6434 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6435 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6437 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6439 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6441 * term.c (vfatal): Remove stray call to va_end.
6442 It's not needed and the C Standard doesn't allow it here anyway.
6444 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6445 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6447 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6450 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6452 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6454 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6456 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6458 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6460 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6461 * charset.c (Fdefine_charset_internal): Don't initialize
6462 charset.code_space[15]. The value was garbage, on hosts with
6463 32-bit int (Bug#8600).
6465 * lread.c (read_integer): Be more consistent with string-to-number.
6466 Use string_to_number to do the actual conversion; this avoids
6467 rounding errors and fixes some other screwups. Without this fix,
6468 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6469 (digit_to_number): Move earlier, for benefit of read_integer.
6470 Return -1 if the digit is out of range for the base, -2 if it is
6471 not a digit in any supported base. (Bug#8602)
6473 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6475 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6476 to match comment at start of function. This also removes a
6477 GCC warning about overflow in a 32+64-bit port.
6479 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6481 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6482 Reported by Stefan Monnier in
6483 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6484 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6485 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6487 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6488 (EMACS_UINTPTR): Likewise, with uintptr_t.
6490 * lisp.h: Prefer 64-bit EMACS_INT if available.
6491 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6492 on 32-bit hosts that have 64-bit int, so that they can access
6494 However, temporarily disable this change unless the temporary
6495 symbol WIDE_EMACS_INT is defined.
6497 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6499 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6500 This removes an assumption that EMACS_INT and long are the same
6501 width as pointers. The assumption is true for Emacs porting targets
6502 now, but we want to make other targets possible.
6503 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6504 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6505 In the rest of the code, change types of integers that hold casted
6506 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6507 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6508 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6509 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6510 No need to cast type when ORing.
6511 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6512 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6513 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6514 assume EMACS_INT is the same width as char *.
6515 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6516 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6517 Remove no-longer-needed casts.
6518 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6519 (xg_tool_bar_help_callback, xg_make_tool_item):
6520 Use EMACS_INTPTR to hold an integer
6521 that will be cast to void *; this can avoid a GCC warning
6522 if EMACS_INT is not the same width as void *.
6523 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6524 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6525 (current_message_1, set_message_1):
6526 Use a local to convert to proper width without a cast.
6527 * xmenu.c (dialog_selection_callback): Likewise.
6529 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6530 Also, don't assume VALBITS / RAND_BITS is less than 5,
6531 and don't rely on undefined behavior when shifting a 1 left into
6533 * lisp.h (get_random): Change signature to match.
6535 * lread.c (hash_string): Use size_t, not int, for hash computation.
6536 Normally we prefer signed values; but hashing is special, because
6537 it's better to use unsigned division on hash table sizes so that
6538 the remainder is nonnegative. Also, size_t is the natural width
6539 for hashing into memory. The previous code used 'int', which doesn't
6540 retain enough info to hash well into very large tables.
6541 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6543 * dbusbind.c: Don't possibly lose pointer info when converting.
6544 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6545 Use XPNTR rather than XHASH, so that the high-order bits of
6546 the pointer aren't lost when converting through void *.
6548 * eval.c (Fautoload): Don't double-shift a pointer.
6550 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6552 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6554 * gnutls.c (DEF_GNUTLS_FN):
6555 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6557 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6559 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6562 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6564 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6565 New version that can reserve upto 2GB of heap space.
6567 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6569 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6571 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6573 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6574 `gnutls_certificate_set_x509_key_file'.
6576 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6578 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6579 Update dependencies.
6581 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6583 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6584 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6585 Remove unused parameter `fildes'.
6586 * process.c (read_process_output, send_process): Don't pass it.
6588 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6590 Fix previous change: the library cache is defined in w32.c.
6591 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6592 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6594 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6596 Implement dynamic loading of GnuTLS on Windows.
6598 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6599 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6600 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6603 * gnutls.c (Qgnutls_dll): Define.
6604 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6605 (gnutls_*): Declare function pointers.
6606 (init_gnutls_functions): New function to initialize function pointers.
6607 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6608 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6609 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6610 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6611 (emacs_gnutls_write, emacs_gnutls_read)
6612 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6613 (Fgnutls_available_p): New function.
6614 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6615 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6616 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6618 * image.c: Include w32.h.
6619 (Vimage_type_cache): Delete.
6620 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6621 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6622 (w32_delayed_load): Move to w32.c.
6624 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6626 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6627 (w32_delayed_load): Move from image.c. When loading a library, record
6628 its filename in the :loaded-from property of the library id.
6629 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6630 Initialize and staticpro them.
6631 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6633 * process.c: Include lisp.h before w32.h, not after.
6634 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6635 instead of gnutls_record_check_pending.
6637 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6639 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6641 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6642 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6645 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6647 * xterm.c (x_set_frame_alpha): Do not set property on anything
6648 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6650 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6652 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6654 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6656 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6657 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6658 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6659 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6660 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6661 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6662 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6663 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6664 (Qgnutls_bootprop_callbacks_verify): Make static.
6666 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6668 * callproc.c: Indentation fixup.
6670 * sysdep.c (wait_for_termination_1): Make static.
6671 (wait_for_termination, interruptible_wait_for_termination):
6672 Move after wait_for_termination_1.
6674 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6676 * sysdep.c (interruptible_wait_for_termination): New function
6677 which is like wait_for_termination, but allows keyboard
6680 * callproc.c (Fcall_process): Add (:file "file") as an option for
6682 (Fcall_process_region): Ditto.
6684 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6686 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6687 rather than `XVECTOR (FOO)->size'.
6689 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6690 inttypes.h, as a gnulib replacement is used if it not available in
6693 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6695 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6696 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6697 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6699 * coding.c (coding_alloc_by_realloc): Error out if destination
6700 will grow beyond MOST_POSITIVE_FIXNUM.
6701 (decode_coding_emacs_mule): Abort if there isn't enough place in
6702 charbuf for the composition carryover bytes. Reserve an extra
6703 space for up to 2 characters produced in a loop.
6704 (decode_coding_iso_2022): Abort if there isn't enough place in
6705 charbuf for the composition carryover bytes.
6707 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6709 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6710 aborting when %lld or %lll format is passed.
6711 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6712 %llo or %llx format is passed. (Bug#8545)
6714 * window.c (window_scroll_line_based): Use a marker instead of
6715 simple variables to record original value of point. (Bug#7952)
6717 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6718 produced by %s or %c overflows available buffer space. (Bug#8545)
6720 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6722 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6723 (SIZE_MAX): Move defn after all includes, as they might #define it.
6725 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6727 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6729 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6731 * keyboard.c (Qdelayed_warnings_hook): Define.
6732 (command_loop_1): Run `delayed-warnings-hook'
6733 if Vdelayed_warnings_list is non-nil.
6734 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6735 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6737 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6739 * doprnt.c (doprnt): Don't return value smaller than the buffer
6740 size if the message was truncated. (Bug#8545).
6742 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6744 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6745 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6747 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6749 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6751 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6753 * makefile.w32-in: Update dependencies.
6755 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6757 Improve `doprnt' and its usage. (Bug#8545)
6758 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6759 `format_end'. Remove support for %l as a conversion specifier.
6760 Don't use xrealloc. Improve diagnostics when the %l size modifier
6761 is used. Update the commentary.
6763 * eval.c (verror): Simplify calculation of size_t.
6765 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6768 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6770 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6773 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6775 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6776 This makes this file independent of the recent pseudovector change.
6778 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6780 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6782 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6783 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6784 Remove unused local.
6785 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6787 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6788 GCC 4.6.0 optimizes based on type-based alias analysis.
6789 For example, if b is of type struct buffer * and v of type struct
6790 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6791 != &v->size, and therefore "v->size = 1; b->size = 2; return
6792 v->size;" must therefore return 1. This assumption is incorrect
6793 for Emacs, since it type-puns struct Lisp_Vector * with many other
6794 types. To fix this problem, this patch adds a new type struct
6795 vectorlike_header that documents the constraints on layout of vectors
6796 and pseudovectors, and helps optimizing compilers not get fooled
6797 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6798 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6799 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6801 (XSETPVECTYPE): Rewrite in terms of new macro.
6802 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6803 This is a bit clearer, and further avoids the possibility of
6804 undesirable aliasing.
6805 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6806 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6807 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6808 since Lisp_Subr is a special case (no "next" field).
6809 (ASIZE): Now uses header.size rather than size.
6810 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6811 to avoid the hassle of writing XVECTOR (foo)->header.size.
6812 (struct vectorlike_header): New type.
6813 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6814 object, to help avoid aliasing.
6815 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6816 (SUBRP): Likewise, since Lisp_Subr is a special case.
6817 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6818 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6819 (struct Lisp_Hash_Table): Combine first two members into a single
6820 struct vectorlike_header member. All uses of "size" and "next" members
6821 changed to be "header.size" and "header.next".
6822 * buffer.h (struct buffer): Likewise.
6823 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6824 * frame.h (struct frame): Likewise.
6825 * process.h (struct Lisp_Process): Likewise.
6826 * termhooks.h (struct terminal): Likewise.
6827 * window.c (struct save_window_data, struct saved_window): Likewise.
6828 * window.h (struct window): Likewise.
6829 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6830 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6831 * buffer.c (init_buffer_once): Likewise.
6832 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6834 * process.c (Fformat_network_address): Use local var for size,
6837 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6839 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6840 * data.c (atof): Remove decl; no longer used or needed.
6841 (digit_to_number): Move to lread.c.
6842 (Fstring_to_number): Use new string_to_number function, to be
6843 consistent with how the Lisp reader treats infinities and NaNs.
6844 Do not assume that floating-point numbers represent EMACS_INT
6845 without losing information; this is not true on most 64-bit hosts.
6846 Avoid double-rounding errors, by insisting on integers when
6847 parsing non-base-10 numbers, as the documentation specifies.
6848 * lisp.h (string_to_number): New decl, replacing ...
6849 (isfloat_string): Remove.
6850 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6851 (read1): Do not accept +. and -. as integers; this
6852 appears to have been a coding error. Similarly, do not accept
6853 strings like +-1e0 as floating point numbers. Do not report
6854 overflow for integer overflows unless the base is not 10 which
6855 means we have no simple and reliable way to continue.
6856 Break out the floating-point parsing into a new
6857 function string_to_number, so that Fstring_to_number parses
6858 floating point numbers consistently with the Lisp reader.
6859 (digit_to_number): Move here from data.c. Make it static inline.
6860 (E_CHAR, EXP_INT): Remove, replacing with ...
6861 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6862 (string_to_number): New function, replacing isfloat_string.
6863 This function checks for valid syntax and produces the resulting
6864 Lisp float number too. Rework it so that string-to-number
6865 no longer mishandles examples like "1.0e+". Use strtoumax,
6866 so that overflow for non-base-10 numbers is reported only when
6867 there's no portable and simple way to convert to floating point.
6869 * textprop.c (set_text_properties_1): Rewrite for clarity,
6870 and to avoid GCC warning about integer overflow.
6872 * intervals.h (struct interval): Use EMACS_INT for members
6873 where EMACS_UINT might cause problems. See
6874 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6875 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6876 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6878 (offset_intervals): Tell GCC not to worry about length overflow
6879 when negating a negative length.
6881 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6882 (overrun_check_free): Likewise.
6884 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6885 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6888 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6889 (gnutls_make_error): Rename local to avoid shadowing.
6890 (gnutls_emacs_global_deinit): ifdef out; not used.
6891 (Fgnutls_boot): Use const for pointer to readonly storage.
6892 Comment out unused local. Fix pointer signedness problems.
6894 * lread.c (openp): Don't stuff size_t into an 'int'.
6895 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6896 about possible signed overflow.
6898 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6899 (GDK_KEY_g): Don't define if already defined.
6900 (xg_prepare_tooltip): Avoid pointer signedness problem.
6901 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6903 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6904 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6906 * xfns.c (Fx_window_property): Simplify a bit,
6907 to make a bit faster and to avoid GCC 4.6.0 warning.
6908 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6910 * fns.c (internal_equal): Don't assume size_t fits in int.
6912 * alloc.c (compact_small_strings): Tighten assertion a little.
6914 Replace pEd with more-general pI, and fix some printf arg casts.
6915 * lisp.h (pI): New macro, generalizing old pEd macro to other
6916 conversion specifiers. For example, use "...%"pI"d..." rather
6917 than "...%"pEd"...".
6918 (pEd): Remove. All uses replaced with similar uses of pI.
6919 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
6920 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6921 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6922 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6923 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6924 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6925 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6927 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6928 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6929 * print.c (safe_debug_print, print_object): Likewise.
6930 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6932 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6933 avoiding the 0 flag, which is not portable.
6934 * process.c (Fmake_network_process): Use pI to avoid cast.
6935 * region-cache.c (pp_cache): Likewise.
6936 * xdisp.c (decode_mode_spec): Likewise.
6937 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6938 behavior on 64-bit hosts with printf arg.
6939 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6940 (x_stop_queuing_selection_requests): Likewise.
6941 (x_get_window_property): Don't truncate byte count to an 'int'
6944 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6945 here, since it parses constructs like leading '-' and spaces,
6946 which are not wanted; and it overflows with large numbers.
6947 Instead, simply match F[0-9]+, which is what is wanted anyway.
6949 * alloc.c: Remove unportable assumptions about struct layout.
6950 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6951 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6952 (allocate_vectorlike, make_pure_vector): Use the new macros,
6953 plus offsetof, to remove unportable assumptions about struct layout.
6954 These assumptions hold on all porting targets that I know of, but
6955 they are not guaranteed, they're easy to remove, and removing them
6956 makes further changes easier.
6958 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6959 This doesn't fix a bug but makes the code clearer.
6960 (string_overrun_cookie): Now const. Use initializers that
6961 don't formally overflow signed char, to avoid warnings.
6962 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6963 can cause Emacs to crash when string overrun checking is enabled.
6964 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6965 multiple of sizeof (EMACS_INT); it need not be, if
6966 alignof(EMACS_INT) < sizeof (EMACS_INT).
6967 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6969 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6971 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6973 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6975 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6976 supposed to be handshaking. (Bug#8556)
6977 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6979 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6981 * lisp.h (Qdebug): List symbol.
6982 * eval.c (Qdebug): Restore global linkage.
6983 * keyboard.c (debug-on-event): New variable.
6984 (handle_user_signal): Break into debugger when debug-on-event
6985 matches the current signal symbol.
6987 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6989 * alloc.c (check_sblock, check_string_bytes)
6990 (check_string_free_list): Convert to standard C.
6992 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6994 * w32.c (emacs_gnutls_push): Fix typo.
6996 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6998 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6999 "cast to pointer from integer of different size".
7001 Improve doprnt and its use in verror. (Bug#8545)
7002 * doprnt.c (doprnt): Document the set of format control sequences
7003 supported by the function. Use SAFE_ALLOCA instead of always
7006 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7007 is one byte too soon. Don't use xrealloc; instead xfree and
7010 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7012 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7015 * gnutls.c: Renamed global_initialized to
7016 gnutls_global_initialized. Added internals for the
7017 :verify-hostname-error, :verify-error, and :verify-flags
7018 parameters of `gnutls-boot' and documented those parameters in the
7019 docstring. Start callback support.
7020 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7021 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7022 on error. Return error code.
7023 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7024 (emacs_gnutls_read): Likewise.
7025 (Fgnutls_boot): Return handshake error code.
7026 (emacs_gnutls_handle_error): New function.
7027 (wsaerror_to_errno): Likewise.
7029 * w32.h (emacs_gnutls_pull): Add prototype.
7030 (emacs_gnutls_push): Likewise.
7032 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7033 (emacs_gnutls_push): Likewise.
7035 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7037 * process.c (wait_reading_process_output): Check if GnuTLS
7038 buffered some data internally if no FDs are set for TLS
7041 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7042 (LIBS): Link to USER_LIBS.
7043 ($(BLD)/gnutls.$(0)): New target.
7045 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7047 * xdisp.c (handle_single_display_spec): Rename the
7048 display_replaced_before_p argument into display_replaced_p, to
7049 make it consistent with the commentary. Fix typos in the
7052 * textprop.c (syms_of_textprop): Remove dead code.
7053 (copy_text_properties): Delete obsolete commentary about an
7054 interface that was deleted long ago. Fix typos in the description
7057 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7058 to changes in oldXMenu/XMenu.h from 2011-04-16.
7059 <menu_help_message, prev_menu_help_message>: Constify.
7060 (IT_menu_make_room): menu->help_text is now `const char **';
7063 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7064 to changes in oldXMenu/XMenu.h from 2011-04-16.
7065 (struct XMenu): Declare `help_text' `const char **'.
7067 * xfaces.c <Qunspecified>: Make extern again.
7069 * syntax.c: Include sys/types.h before including regex.h, as
7072 * doc.c (get_doc_string): Improve the format passed to `error'.
7074 * doprnt.c (doprnt): Improve commentary.
7076 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7078 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7081 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7082 changes in globals.h immediately force recompilation.
7083 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7084 $(CURDIR)/s/ms-w32.h.
7085 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7087 * character.c (Fchar_direction): Function deleted.
7088 (syms_of_character): Don't defsubr it.
7089 <char-direction-table>: Deleted.
7091 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7093 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7094 * doprnt.c: Include limits.h.
7095 (SIZE_MAX): New macro.
7096 (doprnt): Return a size_t value. 2nd arg is now size_t.
7097 Many local variables are now size_t instead of int or unsigned.
7098 Improve overflow protection. Support `l' modifier for integer
7099 conversions. Support %l conversion. Don't assume an EMACS_INT
7100 argument for integer conversions and for %c.
7102 * lisp.h (doprnt): Restore prototype.
7104 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7107 * Makefile.in (base_obj): Add back doprnt.o.
7109 * deps.mk (doprnt.o): Add back prerequisites.
7110 (callint.o): Depend on character.h.
7112 * eval.c (internal_lisp_condition_case): Include the handler
7113 representation in the error message.
7114 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7115 when breaking from the loop.
7117 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7119 * callint.c (Fcall_interactively): When displaying error message
7120 about invalid control letter, pass the character's codepoint, not
7121 a pointer to its multibyte form. Improve display of the character
7122 in octal and display also its hex code.
7124 * character.c (char_string): Use %x to display the (unsigned)
7125 codepoint of an invalid character, to avoid displaying a bogus
7128 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7129 `error', not SYMBOL_NAME itself.
7131 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7132 character arguments to `error'.
7134 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7135 to `error' in error message about FINAL_CHAR argument. Make sure
7136 FINAL_CHAR is a character, and use %c when it is passed as
7137 argument to `error'.
7139 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7141 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7143 * w32.c: Include <time.h>.
7144 (sys_localtime): New function.
7146 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7148 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7150 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7152 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7154 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7157 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7159 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7160 gl_state.e_property when gl_state.object is Qt.
7162 * insdel.c (make_gap_larger): Remove limitation of buffer size
7165 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7167 * xdisp.c (lookup_glyphless_char_display)
7168 (produce_glyphless_glyph): Handle cons cell entry in
7169 glyphless-char-display.
7170 (Vglyphless_char_display): Document it.
7172 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7173 glyphless-char-display.
7175 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7177 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7179 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7181 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7182 definition for no-X builds.
7184 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7186 Static checks with GCC 4.6.0 and non-default toolkits.
7188 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7190 * process.c (keyboard_bit_set): Define only if SIGIO.
7191 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7192 (send_process): Repair possible setjmp clobbering.
7194 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7196 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7198 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7200 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7201 Define only if needed.
7203 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7204 by pacifying GCC about it. Maybe it's time to retire it?
7205 * xfaces.c (USG, __TIMEVAL__): Likewise.
7207 * dispextern.h (struct redisplay_interface): Rename param
7209 * termhooks.h (struct terminal): Likewise.
7210 * xterm.c (xembed_send_message): Likewise.
7212 * insdel.c (make_gap_smaller): Define only if
7213 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7215 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7218 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7219 so that we aren't warned about unused symbols.
7221 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7223 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7225 * xfns.c (x_real_positions): Mark locals as initialized.
7227 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7229 * xterm.c: Fix problems found by static analysis with other toolkits.
7230 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7231 (x_dispatch_event): Declare static if USE_GTK, and
7232 define if USE_GTK || USE_X_TOOLKIT.
7233 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7234 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7235 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7236 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7238 * xmenu.c (menu_help_callback): Pointer type fixes.
7239 Use const pointers when pointing at readonly data. Avoid pointer
7241 (FALSE): Remove unused macro.
7242 (update_frame_menubar): Remove unused decl.
7244 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7246 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7247 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7248 (single_menu_item): Rename local to avoid shadowing.
7250 * keyboard.c (make_lispy_event): Remove unused local var.
7252 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7253 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7255 * bitmaps: Change bitmaps from unsigned char back to the X11
7256 compatible char. Avoid the old compiler warnings about
7257 out-of-range initializers by using, for example, '\xab' rather
7260 * xgselect.c (xgselect_initialize): Check vs interface
7261 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7263 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7265 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7266 to read-only memory.
7268 * fns.c (vector): Remove; this old hack is no longer needed.
7270 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7272 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7274 * xrdb.c (x_load_resources): Omit unused local.
7276 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7277 (x_window): Rename locals to avoid shadowing.
7278 (USG): Use the kludged USG macro, to pacify gcc.
7280 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7281 (x_term_init): Remove local to avoid shadowing.
7283 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7285 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7286 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7288 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7290 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7292 Fix regex.c, syntax.c and friends for buffers > 2GB.
7293 * syntax.h (struct gl_state_s): Declare character position members
7296 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7298 * textprop.c (verify_interval_modification, interval_of):
7299 Declare arguments EMACS_INT.
7301 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7304 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7306 * indent.c (Fvertical_motion): Local variable it_start is now
7309 * regex.c (re_match, re_match_2, re_match_2_internal)
7310 (bcmp_translate, regcomp, regexec, print_double_string)
7311 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7312 (re_compile_pattern, re_exec): Declare arguments and local
7313 variables `size_t' and `ssize_t' and return values `regoff_t', as
7315 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7316 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7317 <compile_stack_type>: `size' and `avail' are now `size_t'.
7319 * regex.h <regoff_t>: Use ssize_t, not int.
7320 (re_search, re_search_2, re_match, re_match_2): Arguments that
7321 specify buffer/string position and length are now ssize_t and
7322 size_t. Return type is regoff_t.
7324 2011-04-16 Ben Key <bkey76@gmail.com>
7326 * nsfont.m: Fixed bugs in ns_get_family and
7327 ns_descriptor_to_entity that were caused by using free to
7328 deallocate memory blocks that were allocated by xmalloc (via
7329 xstrdup). This caused Emacs to crash when compiled with
7330 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7331 --enable-checking=xmallocoverrun). xfree is now used to
7332 deallocate these memory blocks.
7334 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7336 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7338 emacs_write: Accept and return EMACS_INT for sizes.
7339 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7341 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7342 Accept and return EMACS_INT.
7343 (emacs_gnutls_write): Return the number of bytes written on
7345 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7346 (emacs_read, emacs_write): Remove check for negative size, as the
7347 Emacs source code has been audited now.
7348 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7349 (emacs_read, emacs_write): Use it.
7350 * process.c (send_process): Adjust to the new signatures of
7351 emacs_write and emacs_gnutls_write. Do not attempt to store
7352 a byte offset into an 'int'; it might overflow.
7353 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7355 * sound.c: Don't assume sizes fit in 'int'.
7356 (struct sound_device.period_size, alsa_period_size):
7357 Return EMACS_INT, not int.
7358 (struct sound_device.write, vox_write, alsa_write):
7359 Accept EMACS_INT, not int.
7360 (wav_play, au_play): Use EMACS_INT to store sizes and to
7361 record read return values.
7363 2011-04-15 Ben Key <bkey76@gmail.com>
7365 * keyboard.c (Qundefined): Don't declare static since it is used
7367 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7368 static since they are used in nsfont.m.
7370 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7372 * process.c (Qprocessp): Don't declare static.
7373 * lisp.h (Qprocessp): Declare again.
7375 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7377 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7379 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7381 Improve C-level modularity by making more things 'static'.
7383 Don't publish debugger-only interfaces to other modules.
7384 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7385 (verify_bytepos, count_markers): Move decls to the only modules
7387 * region-cache.h (pp_cache): Likewise.
7388 * window.h (check_all_windows): Likewise.
7389 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7391 * sysdep.c (croak): Now static, if
7392 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7393 * syssignal.h (croak): Declare only if not static.
7395 * alloc.c (refill_memory_reserve): Now static if
7396 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7397 * lisp.h (refill_memory_reserve): Declare only if not static.
7399 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7400 Define only if USE_LUCID.
7402 * xrdb.c (x_customization_string, x_rm_string): Now static.
7404 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7405 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7407 * xdisp.c (draw_row_with_mouse_face): Now static.
7408 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7410 * window.h (check_all_windows): Mark externally visible.
7412 * window.c (window_deletion_count): Now static.
7414 * undo.c: Make symbols static if they're not exported.
7415 (last_undo_buffer, last_boundary_position, pending_boundary):
7418 * textprop.c (interval_insert_behind_hooks): Now static.
7419 (interval_insert_in_front_hooks): Likewise.
7421 * term.c: Make symbols static if they're not exported.
7422 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7423 (max_frame_lines, tty_set_terminal_modes):
7424 (tty_reset_terminal_modes, tty_turn_off_highlight):
7425 (get_tty_terminal): Now static.
7426 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7427 * termhooks.h (term_mouse_moveto): Do not declare if
7429 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7430 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7432 * sysdep.c: Make symbols static if they're not exported.
7433 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7435 (sigprocmask_set, full_mask): Remove; unused.
7436 (wait_debugging): Mark as visible.
7437 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7438 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7440 * syntax.c (syntax_temp): Define only if !__GNUC__.
7442 * sound.c (current_sound_device, current_sound): Now static.
7444 * search.c (searchbufs, searchbuf_head): Now static.
7446 * scroll.c (scroll_cost): Remove; unused.
7447 * dispextern.h (scroll_cost): Remove decl.
7449 * region-cache.h (pp_cache): Mark as externally visible.
7451 * process.c: Make symbols static if they're not exported.
7452 (process_tick, update_tick, create_process, chan_process):
7453 (Vprocess_alist, proc_buffered_char, datagram_access):
7454 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7455 (deactivate_process): Mark defn as static, as well as decl.
7456 * lisp.h (create_process): Remove decl.
7457 * process.h (chan_process, Vprocess_alist): Remove decls.
7459 * print.c: Make symbols static if they're not exported.
7460 (print_depth, new_backquote_output, being_printed, print_buffer):
7461 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7462 (print_interval, print_number_index, initial_stderr_stream):
7464 * lisp.h (Fprinc): Remove decl.
7465 (debug_output_compilation_hack): Mark as externally visible.
7467 * sysdep.c (croak): Move decl from here to syssignal.h.
7468 * syssignal.h (croak): Put it here, so the API can be checked when
7469 'croak' is called from dissociate_if_controlling_tty.
7471 * minibuf.c: Make symbols static if they're not exported.
7472 (minibuf_save_list, choose_minibuf_frame): Now static.
7473 * lisp.h (choose_minibuf_frame): Remove decl.
7475 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7477 * lread.c: Make symbols static if they're not exported.
7478 (read_objects, initial_obarray, oblookup_last_bucket_number):
7480 (make_symbol): Remove; unused.
7481 * lisp.h (initial_obarray, make_symbol): Remove decls.
7483 * keyboard.c: Make symbols static if they're not exported.
7484 (single_kboard, recent_keys_index, total_keys, recent_keys):
7485 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7486 (this_single_command_key_start, echoing, last_auto_save):
7487 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7488 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7489 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7490 (Vlispy_mouse_stem, double_click_count):
7492 (force_auto_save_soon): Define only if SIGDANGER.
7493 (ignore_mouse_drag_p): Now static if
7494 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7495 (print_help): Remove; unused.
7496 (stop_character, last_timer_event): Mark as externally visible.
7497 * keyboard.h (ignore_mouse_drag_p): Declare only if
7498 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7499 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7500 * lisp.h (echoing): Remove decl.
7501 (force_auto_save_soon): Declare only if SIGDANGER.
7502 * xdisp.c (redisplay_window): Simplify code, to make it more
7503 obvious that ignore_mouse_drag_p is not accessed if !defined
7504 USE_GTK && !defined HAVE_NS.
7506 * intervals.c: Make symbols static if they're not exported.
7507 (merge_properties_sticky, merge_interval_right, delete_interval):
7509 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7511 * insdel.c: Make symbols static if they're not exported.
7512 However, leave prepare_to_modify_buffer alone. It's never
7513 called from outside this function, but that appears to be a bug.
7514 (combine_after_change_list, combine_after_change_buffer):
7515 (adjust_after_replace, signal_before_change): Now static.
7516 (adjust_after_replace_noundo): Remove; unused.
7517 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7518 (signal_before_change): Remove decls.
7520 * indent.c (val_compute_motion, val_vmotion): Now static.
7522 * image.c: Make symbols static if they're not exported.
7523 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7525 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7526 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7528 * fringe.c (standard_bitmaps): Now static.
7529 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7531 * frame.c: Make symbols static if they're not exported.
7532 (x_report_frame_params, make_terminal_frame): Now static.
7533 (get_frame_param): Now static, unless HAVE_NS.
7534 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7535 (x_get_resource_string): Remove; not used.
7536 * frame.h (make_terminal_frame, x_report_frame_params):
7537 (x_get_resource_string); Remove decls.
7538 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7539 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7541 * font.c, fontset.c: Make symbols static if they're not exported.
7542 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7543 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7544 * font.c (font_close_object): Now static.
7545 * font.h (font_close_object): Remove.
7546 * fontset.c (FONTSET_OBJLIST): Remove.
7547 (free_realized_fontset) #if-0 the body, which does nothing.
7548 (face_suitable_for_char_p): #if-0, as it's never called.
7549 * fontset.h (face_suitable_for_char_p): Remove decl.
7550 * xfaces.c (face_at_string_position):
7551 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7552 since 0 is always ASCII.
7554 * fns.c (weak_hash_tables): Now static.
7556 * fileio.c: Make symbols static if they're not exported.
7557 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7558 (Vwrite_region_annotation_buffers): Now static.
7560 * eval.c: Make symbols static if they're not exported.
7561 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7562 * lisp.h (backtrace_list): Remove decl.
7564 * emacs.c: Make symbols static if they're not exported.
7565 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7566 (fatal_error_code, fatal_error_signal_hook, standard_args):
7568 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7569 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7570 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7571 * lisp.h (fatal_error_signal_hook): Remove decl.
7572 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7574 * editfns.c: Move a (normally-unused) function to its only use.
7575 * editfns.c, lisp.h (get_operating_system_release): Remove.
7576 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7577 worth the hassle of breaking this out.
7579 * xterm.c: Make symbols static if they're not exported.
7580 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7581 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7582 (x_destroy_window, x_delete_display):
7584 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7585 (x_mouse_leave): Remove; unused.
7586 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7587 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7588 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7590 (x_mouse_leave): Declare only if WINDOWSNT.
7591 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7592 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7595 * ftxfont.c: Make symbols static if they're not exported.
7596 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7598 * font.h (ftxfont_driver): Likewise.
7600 * xfns.c: Make symbols static if they're not exported.
7601 (x_last_font_name, x_display_info_for_name):
7602 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7603 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7604 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7605 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7606 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7607 (last_show_tip_args): Now static.
7608 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7609 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7610 (x_screen_planes): Remove; unused.
7611 * dispextern.h (x_screen_planes): Remove decl.
7613 * dispnew.c: Make symbols static if they're not exported.
7614 * dispextern.h (redraw_garbaged_frames, scrolling):
7615 (increment_row_positions): Remove.
7616 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7617 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7619 (redraw_garbaged_frames): Remove; unused.
7621 * xfaces.c: Make symbols static if they're not exported.
7622 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7624 * xterm.h (defined_color): Remove decls.
7625 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7626 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7627 (menu_face_changed_default, defined_color, free_realized_face):
7628 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7629 (ascii_face_of_lisp_face): Remove; unused.
7631 * xdisp.c: Make symbols static if they're not exported.
7632 * dispextern.h (scratch_glyph_row, window_box_edges):
7633 (glyph_to_pixel_coords, set_cursor_from_row):
7634 (get_next_display_element, set_iterator_to_next):
7635 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7636 (show_mouse_face): Remove decls
7637 * frame.h (message_buf_print): Likewise.
7638 * lisp.h (pop_message, set_message, check_point_in_composition):
7640 * xterm.h (set_vertical_scroll_bar): Likewise.
7641 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7642 (message_buf_print, scratch_glyph_row, displayed_buffer):
7643 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7644 (get_next_display_element, show_mouse_face, window_box_edges):
7645 (frame_to_window_pixel_xy, check_point_in_composition):
7646 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7647 (glyph_to_pixel_coords): Remove; unused.
7649 * dired.c (file_name_completion): Now static.
7651 * dbusbind.c (xd_in_read_queued_messages): Now static.
7653 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7654 * data.c (circular_list_error): Remove.
7656 * commands.h (last_point_position, last_point_position_buffer):
7657 (last_point_position_window): Remove decls.
7658 * keyboard.c: Make these variables static.
7660 * coding.h (coding, code_convert_region, encode_coding_gap):
7662 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7663 (iso_code_class, detect_coding, code_convert_region): Now static.
7664 (encode_coding_gap): Remove; unused.
7666 * chartab.c (chartab_chars, chartab_bits): Now static.
7668 * charset.h (charset_iso_8859_1): Remove decl.
7669 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7672 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7673 * ccl.c (Vccl_program_table): Now static.
7674 (check_ccl_update): Remove; unused.
7676 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7677 * category.h: ... from here.
7678 * category.c (check_category_table, set_category_set): Now static.
7680 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7681 * lisp.h: Remove these decls.
7683 * buffer.c (buffer_count): Remove unused var.
7685 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7686 so that it's not optimized away.
7687 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7688 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7689 exported only to the debugger.
7691 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7692 * atimer.h (run_all_atimers): Remove; not exported.
7694 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7695 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7696 was inaccessible from Lisp.
7697 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7698 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7700 alloc.c: Import and export fewer symbols, and remove unused items.
7701 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7703 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7704 it's not optimized away by whole-program optimization.
7705 (message_enable_multibyte, free_misc): Remove.
7706 (catchlist, handlerlist, mark_backtrace):
7707 Declare only if BYTE_MARK_STACK.
7708 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7709 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7710 (message_enable_multibyte): Remove decl.
7711 (free_misc, interval_free_list, float_block, float_block_index):
7712 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7713 (cons_free_list, last_marked_index):
7715 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7716 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7717 (mark_backtrace): Define only if BYTE_MARK_STACK.
7718 * xdisp.c (message_enable_multibyte): Now static.
7720 Declare Lisp_Object Q* variables to be 'static' if not exported.
7721 This makes it easier for human readers (and static analyzers)
7722 to see whether these variables are used from other modules.
7723 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7724 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7725 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7726 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7727 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7728 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7729 * xmenu.c, xselect.c:
7730 Declare Q* vars static if they are not used in other modules.
7731 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7732 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7733 Remove decls of unexported vars.
7734 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7736 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7738 Make Emacs functions such as Fatom 'static' by default.
7739 This makes it easier for human readers (and static analyzers)
7740 to see whether these functions can be called from other modules.
7741 DEFUN now defines a static function. To make the function external
7742 so that it can be used in other C modules, use the new macro DEFUE.
7743 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7744 (Finit_image_library):
7745 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7746 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7747 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7748 Remove decls, since these functions are now static.
7749 (Funintern, Fget_internal_run_time): New decls, since these functions
7750 were already external.
7752 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7753 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7754 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7755 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7756 * keyboard.c, keymap.c, lread.c:
7757 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7758 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7759 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7760 Mark functions with DEFUE instead of DEFUN,
7761 if they are used in other modules.
7762 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7763 decls for now-static functions.
7764 * buffer.h (Fdelete_overlay): Remove decl.
7765 * callproc.c (Fgetenv_internal): Mark as internal.
7766 * composite.c (Fremove_list_of_text_properties): Remove decl.
7767 (Fcomposition_get_gstring): New forward static decl.
7768 * composite.h (Fcomposite_get_gstring): Remove decl.
7769 * dired.c (Ffile_attributes): New forward static decl.
7770 * doc.c (Fdocumntation_property): New forward static decl.
7771 * eval.c (Ffetch_bytecode): New forward static decl.
7772 (Funintern): Remove extern decl; now in .h file where it belongs.
7773 * fileio.c (Fmake_symbolic_link): New forward static decl.
7774 * image.c (Finit_image_library): New forward static decl.
7775 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7776 * intervals.h (Fprevious_property_change):
7777 (Fremove_list_of_text_properties): Remove decls.
7778 * keyboard.c (Fthis_command_keys): Remove decl.
7779 (Fcommand_execute): New forward static decl.
7780 * keymap.c (Flookup_key): New forward static decl.
7781 (Fcopy_keymap): Now static.
7782 * keymap.h (Flookup_key): Remove decl.
7783 * process.c (Fget_process): New forward static decl.
7784 (Fprocess_datagram_address): Mark as internal.
7785 * syntax.c (Fsyntax_table_p): New forward static decl.
7786 (skip_chars): Remove duplicate decl.
7787 * textprop.c (Fprevious_property_change): New forward static decl.
7788 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7790 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7791 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7793 * editfns.c (Fformat): Remove unreachable code.
7795 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7797 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7800 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7802 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7803 when at ZV. (Bug#8487)
7805 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7807 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7809 * keyboard.c (parse_tool_bar_item): Likewise.
7810 * sound.c (sound_cleanup, alsa_close): Likewise.
7811 * termcap.c (tgetent): Likewise.
7812 * xfns.c (x_default_font_parameter): Likewise.
7813 * xsettings.c (read_and_apply_settings): Likewise.
7815 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7816 (overrun_check_free): Protoize.
7818 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7820 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7821 since callers should never pass a negative size.
7822 Change the signature to match that of plain 'read' and 'write'; see
7823 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7824 * lisp.h: Update prototypes of emacs_write and emacs_read.
7826 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7828 * xdisp.c (redisplay_window): Don't try to determine the character
7829 position of the scroll margin if the window start point w->startp
7830 is outside the buffer's accessible region. (Bug#8468)
7832 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7834 Fix write-region and its subroutines for buffers > 2GB.
7835 * fileio.c (a_write, e_write): Modify declaration of arguments and
7836 local variables to support buffers larger than 2GB.
7837 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7839 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7840 argument, local variables, and return value.
7842 * lisp.h: Update prototypes of emacs_write and emacs_read.
7844 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7846 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7848 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7850 Fix more problems found by GCC 4.6.0's static checks.
7852 * xdisp.c (vmessage): Use a better test for character truncation.
7854 * charset.c (load_charset_map): <, not <=, for optimization,
7855 and to avoid potential problems with integer overflow.
7856 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7857 * casetab.c (set_identity, shuffle): Likewise.
7858 * editfns.c (Fformat): Likewise.
7859 * syntax.c (skip_chars): Likewise.
7861 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7862 This also lets GCC 4.6.0 generate slightly better loop code.
7864 * callint.c (Fcall_interactively): <, not <=, for optimization.
7865 (Fcall_interactively): Count the number of arguments produced,
7866 not the number of arguments given. This is simpler and lets GCC
7867 4.6.0 generate slightly better code.
7869 * ftfont.c: Distingish more carefully between FcChar8 and char.
7870 The previous code passed unsigned char * to a functions like
7871 strlen and xstrcasecmp that expect char *, which does not
7872 conform to the C standard.
7873 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7874 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7875 char * when the C standard requires it.
7877 * keyboard.c (read_char): Remove unused var.
7879 * eval.c: Port to Windows vsnprintf (Bug#8435).
7881 (SIZE_MAX): Define if the headers do not.
7882 (verror): Do not give up if vsnprintf returns a negative count.
7883 Instead, grow the buffer. This ports to Windows vsnprintf, which
7884 does not conform to C99. Problem reported by Eli Zaretskii.
7885 Also, simplify the allocation scheme, by avoiding the need for
7886 calling realloc, and removing the ALLOCATED variable.
7888 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7890 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7891 But keep the doprint source code for now, as we might revamp it
7892 and use it again (Bug#8435).
7893 * lisp.h (doprnt): Remove.
7894 * Makefile.in (base_obj): Remove doprnt.o.
7895 * deps.mk (doprnt.o): Remove.
7897 error: Print 32- and 64-bit integers portably (Bug#8435).
7898 Without this change, on typical 64-bit hosts error ("...%d...", N)
7899 was used to print both 32- and 64-bit integers N, which relied on
7901 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
7902 * lisp.h (error, verror): Mark as printf-like functions.
7903 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7904 Report overflow in size calculations when allocating printf buffer.
7905 Do not truncate output string at its first null byte.
7906 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7907 Truncate the output at a character boundary, since vsnprintf does not
7909 * charset.c (check_iso_charset_parameter): Convert internal
7910 character to string before calling 'error', since %c now has the
7912 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7913 overflow when computing char to be passed to 'error'. Do not
7914 pass Lisp_Object to 'error'; pass the integer instead.
7915 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7916 formatted with plain %d.
7918 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7920 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7922 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7924 * xterm.c (x_catch_errors): Remove duplicate declaration.
7926 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7928 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7930 2011-04-10 Jim Meyering <meyering@redhat.com>
7932 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7933 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7934 return ssize_t not "int", and use size_t as the buffer length.
7935 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7936 * gnutls.h: Update declarations.
7937 * process.c (read_process_output): Use ssize_t, to match.
7938 (send_process): Likewise.
7940 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7942 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7944 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7946 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7947 Use unsigned char, to match FcChar8 type definition.
7949 * xterm.c (handle_one_xevent):
7950 * xmenu.c (create_and_show_popup_menu):
7951 * xselect.c (x_decline_selection_request)
7952 (x_reply_selection_request): Avoid type-punned deref of X events.
7954 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7956 Fix some uses of `int' instead of EMACS_INT.
7957 * search.c (string_match_1, fast_string_match)
7958 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7959 (scan_buffer, find_next_newline_no_quit)
7960 (find_before_next_newline, search_command, Freplace_match)
7961 (Fmatch_data): Make some `int' variables be EMACS_INT.
7963 * xdisp.c (display_count_lines): 3rd argument and return value now
7964 EMACS_INT. All callers changed.
7965 (pint2hrstr): Last argument is now EMACS_INT.
7967 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7968 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7969 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7970 (decode_coding_utf_16, decode_coding_emacs_mule)
7971 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7972 (decode_coding_ccl, decode_coding_charset)
7973 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7974 (decode_coding_iso_2022, decode_coding_emacs_mule)
7975 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7976 <char_offset, last_offset>: Declare EMACS_INT.
7977 (encode_coding_utf_8, encode_coding_utf_16)
7978 (encode_coding_emacs_mule, encode_invocation_designation)
7979 (encode_designation_at_bol, encode_coding_iso_2022)
7980 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7981 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7983 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7984 (encode_invocation_designation): Last argument P_NCHARS is now
7986 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7987 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7989 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7992 * ccl.c (Fccl_execute_on_string): Declare some variables
7995 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7997 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7999 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8001 * process.c (Fformat_network_address): Doc fix.
8003 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8005 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8007 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8009 * keyboard.c (read_char): Call Lisp function help-form-show,
8010 instead of using internal_with_output_to_temp_buffer.
8011 (Qhelp_form_show): New var.
8012 (syms_of_keyboard): Use DEFSYM macro.
8014 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8016 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8018 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8020 * process.c (Flist_processes): Remove to Lisp.
8021 (list_processes_1): Delete.
8023 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8025 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8027 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8029 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8031 Fix more problems found by GCC 4.6.0's static checks.
8033 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8035 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8037 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8039 * xdisp.c (vmessage): Mark as a printf-like function.
8041 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8043 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8045 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8046 printf-like functions.
8047 (tiff_load): Add casts to remove these marks before passing them
8048 to system-supplied API.
8050 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8052 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8053 This avoids several warnings with gcc -Wstrict-overflow.
8054 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8055 directly, rather than having caller test rule sign. This avoids
8056 some unnecessary tests.
8057 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8058 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8059 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8061 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8062 (xfont_open): Avoid unnecessary tests.
8064 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8066 * composite.h, composite.c (composition_gstring_put_cache):
8067 Use EMACS_INT, not int, for length.
8069 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8070 breaking out part of COMPOSITION_DECODE_RULE.
8071 (COMPOSITION_DECODE_RULE): Use it.
8072 * composite.c (get_composition_id): Remove unused local vars,
8073 by using the new macro.
8075 * textprop.c (set_text_properties_1): Change while to do-while,
8076 since the condition is always true at first.
8078 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8079 (interval_deletion_adjustment): Return unsigned value.
8082 * process.c (list_processes_1, create_pty, read_process_output):
8083 (exec_sentinel): Remove vars that were set but not used.
8084 (create_pty): Remove unnecessary "volatile"s.
8085 (Fnetwork_interface_info): Avoid possibility of int overflow.
8086 (read_process_output): Do adaptive read buffering even if carryover.
8087 (read_process_output): Simplify nbytes computation if buffered.
8089 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8091 * syntax.c (scan_words): Remove var that was set but not used.
8092 (update_syntax_table): Use unsigned instead of int.
8094 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8095 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8096 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8098 * print.c (print_error_message): Avoid int overflow.
8100 * font.c (font_list_entities): Redo for clarity,
8101 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8103 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8104 (font_score): Avoid potential overflow in diff calculation.
8106 * fns.c (substring_both): Remove var that is set but not used.
8107 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8109 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8111 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8112 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8113 can always succeed if overflow has undefined behavior.
8115 * search.c (boyer_moore, wordify): Remove vars set but not used.
8116 (wordify): Omit three unnecessary tests.
8118 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8119 All callers changed. This avoids the need for an unused var.
8121 * casefiddle.c (casify_region): Remove var that is set but not used.
8123 * dired.c (file_name_completion): Remove var that is set but not used.
8125 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8127 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8128 (Finsert_file_contents): Remove unnecessary code checking fd.
8130 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8131 Check for integer overflow on size calculations.
8133 * buffer.c (Fprevious_overlay_change): Remove var that is set
8136 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8137 Remove vars that are set but not used.
8138 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8139 (timer_check_2): Mark vars as initialized.
8141 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8143 * image.c (lookup_image): Remove var that is set but not used.
8144 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8146 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8147 that are set but not used.
8149 * xfns.c (make_invisible_cursor): Don't return garbage
8150 if XCreateBitmapFromData fails (Bug#8410).
8152 * xselect.c (x_get_local_selection, x_handle_property_notify):
8153 Remove vars that are set but not used.
8155 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8156 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8158 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8159 Remove var that is set but not used.
8160 (scroll_bar_windows_size): Now size_t, not int.
8161 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8164 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8165 (map_tty_color) [!defined MSDOS]: Likewise.
8167 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8169 * coding.c: Remove vars that are set but not used.
8170 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8171 All callers changed.
8172 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8173 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8174 (decode_coding_charset): Remove vars that are set but not used.
8176 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8177 that is set but not used.
8179 * print.c (print_object): Remove var that is set but not used.
8181 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8182 The gnulib version avoids calling malloc in the usual case,
8183 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8184 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8185 * filelock.c (current_lock_owner): Likewise.
8186 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8187 * sysdep.c: Include allocator.h, careadlinkat.h.
8188 (emacs_no_realloc_allocator): New static constant.
8189 (emacs_readlink): New function.
8190 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8191 ../lib/careadlinkat.h.
8193 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8195 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8196 first non-nil return value).
8198 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8200 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8201 if not defined (Bug#8403).
8203 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8205 * xdisp.c (display_count_lines): Remove parameter `start',
8206 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8207 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8208 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8209 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8210 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8211 and thereabouts. All callers changed.
8212 (get_per_char_metric): Remove parameter `f', unused since
8213 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8215 2011-04-02 Jim Meyering <meyering@redhat.com>
8217 do not dereference NULL upon failed strdup
8218 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8219 (ns_get_family): Likewise.
8221 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8223 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8225 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8227 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8230 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8232 Add lexical binding.
8234 * window.c (Ftemp_output_buffer_show): New fun.
8235 (Fsave_window_excursion):
8236 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8238 * lread.c (lisp_file_lexically_bound_p): New function.
8239 (Fload): Bind Qlexical_binding.
8240 (readevalloop): Remove `evalfun' arg.
8241 Bind Qinternal_interpreter_environment.
8242 (Feval_buffer): Bind Qlexical_binding.
8243 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8245 (syms_of_lread): Declare `lexical-binding'.
8247 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8249 * keyboard.c (eval_dyn): New fun.
8250 (menu_item_eval_property): Use it.
8252 * image.c (parse_image_spec): Use Ffunctionp.
8254 * fns.c (concat, mapcar1): Accept byte-code-functions.
8256 * eval.c (Fsetq): Handle lexical vars.
8257 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8258 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8259 (FletX, Flet): Obey lexical binding.
8260 (Fcommandp): Handle closures.
8261 (Feval): New `lexical' arg.
8262 (eval_sub): New function extracted from Feval. Use it almost
8263 everywhere where Feval was used. Look up vars in lexical env.
8265 (Ffunctionp): Move from subr.el.
8266 (Ffuncall): Handle closures.
8267 (apply_lambda): Remove `eval_flags'.
8268 (funcall_lambda): Handle closures and new byte-code-functions.
8269 (Fspecial_variable_p): New function.
8270 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8271 but without exporting it to Lisp.
8273 * doc.c (Fdocumentation, store_function_docstring):
8274 * data.c (Finteractive_form): Handle closures.
8276 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8279 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8281 (exec_byte_code): New function extracted from Fbyte_code to handle new
8282 calling convention for byte-code-functions. Add new byte-codes.
8284 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8286 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8288 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8290 * xdisp.c (redisplay_internal): Fix prototype.
8292 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8294 * xdisp.c (SCROLL_LIMIT): New macro.
8295 (try_scrolling): Use it when setting scroll_limit.
8296 Limit scrolling to 100 screen lines.
8297 (redisplay_window): Even when falling back on "recentering",
8298 position point in the window according to scroll-conservatively,
8299 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8301 (try_scrolling): When point is above the window, allow searching
8302 as far as scroll_max, or one screenful, to compute vertical
8303 distance from PT to the scroll margin position. This prevents
8304 try_scrolling from unnecessarily failing when
8305 scroll-conservatively is set to a value slightly larger than the
8306 window height. Clean up the case of PT below the margin at bottom
8307 of window: scroll_max can no longer be INT_MAX. When aggressive
8308 scrolling is in use, don't let point enter the opposite scroll
8309 margin as result of the scroll.
8310 (syms_of_xdisp) <scroll-conservatively>: Document the
8311 threshold of 100 lines for never-recentering scrolling.
8313 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8315 * dispextern.h (move_it_by_lines):
8316 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8317 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8318 (message_log_check_duplicate): Remove parameters `prev_bol' and
8319 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8320 (redisplay_internal): Remove parameter `preserve_echo_area',
8321 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8323 * indent.c (Fvertical_motion):
8324 * window.c (window_scroll_pixel_based, Frecenter):
8325 Don't pass `need_y_p' to `move_it_by_lines'.
8327 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8329 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8330 steal a few bits to be more compact.
8331 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8332 Remove unneeded casts.
8334 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8336 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8338 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8339 binding" message (bug#7967).
8341 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8343 Fix more problems found by GCC 4.6.0's static checks.
8345 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8346 Remove unused local var.
8348 * editfns.c (Fmessage_box): Remove unused local var.
8350 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8351 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8352 Omit unused local vars.
8353 * window.c (shrink_windows): Omit unused local var.
8354 * menu.c (digest_single_submenu): Omit unused local var.
8355 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8356 Omit unused local var.
8358 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8359 Don't assume string length fits in int.
8360 (keyremap_step, read_key_sequence): Use size_t for sizes.
8361 (read_key_sequence): Don't check last_real_key_start redundantly.
8363 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8364 instead of alloca (Bug#8344).
8366 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8367 (Fbacktrace_frame): Don't assume nframes fits in int.
8369 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8371 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8374 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8376 * cm.c (calccost): Turn while-do into do-while, for clarity.
8378 * keyboard.c (syms_of_keyboard): Use the same style as later
8379 in this function when indexing through an array. This also
8380 works around GCC bug 48267.
8382 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8384 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8386 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8387 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8389 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8390 This avoids undefined behavior on integer overflow, and is a bit
8391 more convenient anyway since it is compared to a size_t variable.
8393 Variadic C functions now count arguments with size_t, not int.
8394 This avoids an unnecessary limitation on 64-bit machines, which
8395 caused (substring ...) to crash on large vectors (Bug#8344).
8396 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8397 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8398 All variadic functions and their callers changed accordingly.
8399 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8400 * data.c (arith_driver, float_arith_driver): Likewise.
8401 * editfns.c (general_insert_function): Likewise.
8402 * eval.c (struct backtrace.nargs, interactive_p)
8403 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8404 (funcall_lambda, mark_backtrace): Likewise.
8405 * fns.c (concat): Likewise.
8406 * frame.c (x_set_frame_parameters): Likewise.
8407 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8408 0 if not found, not -1. All callers changed.
8410 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8411 (stack_copy_size): Now size_t, not int.
8412 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8414 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8416 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8417 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8418 All callers changed.
8420 * lisp.h (multibyte_char_to_unibyte):
8421 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8422 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8423 * character.h (CHAR_TO_BYTE8):
8424 * cmds.c (internal_self_insert):
8425 * editfns.c (general_insert_function):
8426 * keymap.c (push_key_description):
8427 * search.c (Freplace_match):
8428 * xdisp.c (message_dolog, set_message_1): All callers changed.
8430 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8432 * keyboard.c (safe_run_hook_funcall): New function.
8433 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8434 don't set the hook to nil, but remove the offending function instead.
8435 (Qcommand_hook_internal): Remove, unused.
8436 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8437 Vcommand_hook_internal.
8439 * eval.c (enum run_hooks_condition): Remove.
8440 (funcall_nil, funcall_not): New functions.
8441 (run_hook_with_args): Call each function through a `funcall' argument.
8442 Remove `cond' argument, now redundant.
8443 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8444 (Frun_hook_with_args_until_failure): Adjust accordingly.
8445 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8447 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8449 * dispextern.h (string_buffer_position): Remove declaration.
8451 * print.c (strout): Remove parameter `multibyte', unused since
8452 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8454 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8455 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8456 All callers changed.
8458 * w32.c (_wsa_errlist): Use braces for struct initializers.
8460 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8461 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8462 All callers changed.
8463 (string_buffer_position): Likewise. Also, make static (it's never
8464 used outside xdisp.c).
8465 (cursor_row_p): Remove parameter `w', unused since
8466 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8467 (decode_mode_spec): Remove parameter `precision', introduced during
8468 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8469 All callers changed.
8471 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8473 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8475 2011-03-27 Anders Lindgren <andlind@gmail.com>
8477 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8478 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8479 (ns_update_auto_hide_menu_bar): New functions.
8480 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8481 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8482 ns_constrain_all_frames.
8483 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8484 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8486 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8488 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8490 2011-03-27 Glenn Morris <rgm@gnu.org>
8492 * syssignal.h: Replace RETSIGTYPE with void.
8493 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8494 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8495 Replace SIGTYPE with void everywhere.
8496 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8497 * s/template.h (SIGTYPE): Remove commented out definition.
8499 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8501 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8502 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8504 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8506 * w32.c (read_unc_volume): Use parameter `henum', instead of
8507 global variable `wget_enum_handle'.
8509 * keymap.c (describe_vector): Remove parameters `indices' and
8510 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8511 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8513 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8515 * keyboard.c (timer_check): Remove parameter `do_it_now',
8516 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8517 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8518 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8520 * keyboard.c (read_char):
8521 * w32menu.c (w32_menu_display_help):
8522 * xmenu.c (show_help_event, menu_help_callback):
8523 Adjust calls to `show_help_echo'.
8525 * gtkutil.c (xg_maybe_add_timer):
8526 * keyboard.c (readable_events):
8527 * process.c (wait_reading_process_output):
8528 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8530 * insdel.c (adjust_markers_gap_motion):
8531 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8532 (gap_left, gap_right): Don't call it.
8534 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8536 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8537 incurred during fontification.
8539 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8541 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8542 (DEFVAR_PER_BUFFER): Don't pass it.
8544 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8545 (scrolling_window): Don't pass it.
8547 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8549 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8551 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8553 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8554 of variables specific to SELinux and computation of `encoded_absname'.
8556 * image.c (XPutPixel): Remove unused variable `height'.
8558 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8560 * unexw32.c (get_section_info): Remove unused variable `section'.
8562 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8563 (system_process_attributes): Remove unused variable `sess'.
8564 (sys_read): Remove unused variable `err'.
8566 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8567 (w32_wnd_proc): Remove unused variable `isdead'.
8568 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8569 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8570 (x_create_tip_frame): Remove unused variable `tem'.
8572 * w32inevt.c (w32_console_read_socket):
8573 Remove unused variable `no_events'.
8575 * w32term.c (x_draw_composite_glyph_string_foreground):
8576 Remove unused variable `width'.
8578 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8580 * w32term.c (x_set_glyph_string_clipping):
8581 Don't pass uninitialized region to CombineRgn.
8583 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8585 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8586 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8587 (Fx_close_connection): Remove unused variable `i'.
8589 * w32font.c (w32font_draw): Return number of glyphs.
8590 (w32font_open_internal): Remove unused variable `i'.
8591 (w32font_driver): Add missing initializer.
8593 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8594 (fill_in_menu): Remove unused variable `items_added'.
8596 * w32term.c (last_mouse_press_frame): Remove static global variable.
8597 (w32_clip_to_row): Remove unused variable `f'.
8598 (x_delete_terminal): Remove unused variable `i'.
8600 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8601 (NOTHING): Remove unused static global variable.
8602 (uniscribe_check_otf): Remove unused variable `table'.
8603 (uniscribe_font_driver): Add missing initializers.
8605 2011-03-23 Julien Danjou <julien@danjou.info>
8607 * term.c (Fsuspend_tty, Fresume_tty):
8608 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8609 * window.c (temp_output_buffer_show):
8610 * insdel.c (signal_before_change):
8611 * frame.c (Fhandle_switch_frame):
8612 * fileio.c (Fdo_auto_save):
8613 * emacs.c (Fkill_emacs):
8614 * editfns.c (save_excursion_restore):
8615 * cmds.c (internal_self_insert):
8616 * callint.c (Fcall_interactively):
8617 * buffer.c (Fkill_all_local_variables):
8618 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8620 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8621 unconditionally since it does the check itself.
8623 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8625 Fix more problems found by GCC 4.5.2's static checks.
8627 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8628 the first time through the loop, since we know p0 < p1 then.
8629 This also avoids a gcc -Wstrict-overflow warning.
8631 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8632 leading to a memory leak, possible in functions like
8633 load_charset_map_from_file that can allocate an unbounded number
8634 of objects (Bug#8318).
8636 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8637 that could (at least in theory) be that large.
8639 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8640 This is less likely to overflow, and avoids undefined behavior if
8641 overflow does occur. All callers changed. Use strtoul to scan
8642 for the unsigned long integer.
8643 (pint2hrstr): Simplify and tune code slightly.
8644 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8646 * scroll.c (do_scrolling): Work around GCC bug 48228.
8647 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8649 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8650 This also avoids a warning with gcc -Wstrict-overflow.
8651 (validate_x_resource_name): Simplify count usage.
8652 This also avoids a warning with gcc -Wstrict-overflow.
8654 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8657 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8659 * process.c (Fmake_network_process): Use socklen_t, not int,
8660 where POSIX says socklen_t is required in portable programs.
8661 This fixes a porting bug on hosts like 64-bit HP-UX, where
8662 socklen_t is wider than int (Bug#8277).
8663 (Fmake_network_process, server_accept_connection):
8664 (wait_reading_process_output, read_process_output):
8667 * process.c: Rename or move locals to avoid shadowing.
8668 (list_processes_1, Fmake_network_process):
8669 (read_process_output_error_handler, exec_sentinel_error_handler):
8670 Rename or move locals.
8671 (Fmake_network_process): Define label "retry_connect" only if needed.
8672 (Fnetwork_interface_info): Fix pointer signedness.
8673 (process_send_signal): Add cast to avoid pointer signedness problem.
8674 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8675 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8677 Make tparam.h and terminfo.c consistent.
8678 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8679 Include tparam.h instead, since it declares them.
8680 * cm.h (PC): Remove extern decl; tparam.h now does this.
8681 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8682 * terminfo.c: Include tparam.h, to check interfaces.
8683 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8684 (tparam): Adjust signature to match interface in tparam.h;
8685 this removes some undefined behavior. Check that outstring and len
8686 are zero, which they always are with Emacs.
8687 * tparam.h (PC, BC, UP): New extern decls.
8689 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8690 (xftfont_open): Rename locals to avoid shadowing.
8692 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8693 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8694 (OTF_TAG_SYM): Omit macro if not needed.
8695 (ftfont_list): Remove unused local.
8696 (get_adstyle_property, ftfont_pattern_entity):
8697 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8698 Rename locals to avoid shadowing.
8700 * xfont.c (xfont_list_family): Mark var as initialized.
8702 * xml.c (make_dom): Now static.
8704 * composite.c (composition_compute_stop_pos): Rename local to
8706 (composition_reseat_it): Remove unused locals.
8707 (find_automatic_composition, composition_adjust_point): Likewise.
8708 (composition_update_it): Mark var as initialized.
8709 (find_automatic_composition): Mark vars as initialized,
8710 with a FIXME (Bug#8290).
8712 character.h: Rename locals to avoid shadowing.
8713 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8714 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8715 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8716 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8719 * textprop.c (property_change_between_p): Remove; unused.
8721 * intervals.c (interval_start_pos): Now static.
8723 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8725 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8726 Rename locals to avoid shadowing.
8728 * sound.c (wav_play, au_play, Fplay_sound_internal):
8729 Fix pointer signedness.
8730 (alsa_choose_format): Remove unused local var.
8731 (wav_play): Initialize a variable to 0, to prevent undefined
8732 behavior (Bug#8278).
8734 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8736 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8738 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8739 clobbering (Bug#8298).
8740 * sysdep.c (sys_subshell): Likewise.
8741 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8743 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8744 This should get cleaned up, so that child_setup has the
8745 same signature on all platforms.
8747 * callproc.c (call_process_cleanup): Now static.
8748 (relocate_fd): Rename locals to avoid shadowing.
8750 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8752 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8753 not to be necessary, and produces flickering.
8755 2011-03-20 Glenn Morris <rgm@gnu.org>
8757 * config.in: Remove file.
8759 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8761 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8762 are now in src/globals.h.
8763 (syms_of_minibuf): Remove spurious & from previous change.
8765 2011-03-20 Leo Liu <sdl.web@gmail.com>
8767 * minibuf.c (completing-read-function): New variable.
8768 (completing-read-default): Rename from completing-read.
8769 (completing-read): Call completing-read-function.
8771 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8773 * xfaces.c (Fx_load_color_file):
8774 Read color file from absolute filename (bug#8250).
8776 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8778 * makefile.w32-in: Update dependencies.
8780 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8782 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8784 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8786 Fix more problems found by GCC 4.5.2's static checks.
8788 * process.c (make_serial_process_unwind, send_process_trap):
8789 (sigchld_handler): Now static.
8791 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8792 That way, the code declares only the vars that it needs.
8793 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8794 * s/cygwin.h (PTY_ITERATION): Likewise.
8795 * s/darwin.h (PTY_ITERATION): Likewise.
8796 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8798 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8799 * process.c (allocate_pty): Don't declare stb unless it's needed.
8801 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8802 (CONSTANTLIM): Remove; unused.
8803 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8804 Define only if needed.
8806 * unexelf.c (unexec): Name an expression,
8807 to avoid gcc -Wbad-function-cast warning.
8808 Use a different way to cause a compilation error if anyone uses
8809 n rather than nn, a way that does not involve shadowing.
8810 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8812 * deps.mk (unexalpha.o): Remove; unused.
8814 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8815 * unexec.h: New file.
8816 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8817 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8819 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8820 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8821 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8822 Change as necessary to match prototype in unexec.h.
8824 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8826 (back_comment, skip_chars): Mark vars as initialized.
8828 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8829 Rename locals to avoid shadowing.
8831 * lread.c (read1): Rewrite so as not to use empty "else".
8832 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8834 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8836 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8837 warning when compiling print.c.
8839 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8840 instead of using an uninitialized var.
8841 (font_sort_entities): Mark var as initialized.
8843 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8845 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8846 pointers to constants.
8847 (font_parse_fcname): Remove unused vars.
8848 (font_delete_unmatched): Now static.
8849 (font_get_spec): Remove; unused.
8850 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8851 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8852 Rename or move locals to avoid shadowing.
8854 * fns.c (require_nesting_list, require_unwind): Now static.
8855 (Ffillarray): Rename locals to avoid shadowing.
8857 * floatfns.c (domain_error2): Define only if needed.
8858 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8860 * alloc.c (mark_backtrace): Move decl from here ...
8861 * lisp.h: ... to here, so that it can be checked.
8863 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8864 (Fdefvar): Rewrite so as not to use empty "else".
8865 (lisp_indirect_variable): Name an expression,
8866 to avoid gcc -Wbad-function-cast warning.
8867 (Fdefvar): Rename locals to avoid shadowing.
8869 * callint.c (quotify_arg, quotify_args): Now static.
8870 (Fcall_interactively): Rename locals to avoid shadowing.
8871 Use const pointer when appropriate.
8873 * lisp.h (get_system_name, get_operating_system_release):
8874 Move decls here, to check interfaces.
8875 * process.c (get_operating_system_release): Move decl to lisp.h.
8876 * xrdb.c (get_system_name): Likewise.
8877 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8878 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8879 some of which prompt warnings from gcc -Wbad-function-cast.
8880 (Fformat_time_string, Fencode_time, Finsert_char):
8881 (Ftranslate_region_internal, Fformat):
8882 Rename or remove local vars to avoid shadowing.
8883 (Ftranslate_region_internal): Mark var as initialized.
8885 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8888 * lisp.h (eassert): Check that the argument compiles, even if
8889 ENABLE_CHECKING is not defined.
8891 * data.c (Findirect_variable): Name an expression, to avoid
8892 gcc -Wbad-function-cast warning.
8893 (default_value, arithcompare, arith_driver, arith_error): Now static.
8894 (store_symval_forwarding): Rename local to avoid shadowing.
8895 (Fmake_variable_buffer_local, Fmake_local_variable):
8896 Mark variables as initialized.
8897 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8899 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8900 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8901 Rename locals to avoid shadowing.
8902 (mark_stack): Move local variables into the #ifdef region where
8904 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8905 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8907 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8908 (GC_STRING_CHARS): Remove; not used.
8909 (Fmemory_limit): Cast sbrk's returned value to char *.
8911 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8912 avoids undefined behavior in theory.
8914 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8916 Use functions, not macros, for up- and down-casing (Bug#8254).
8917 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8918 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8919 to use the following functions instead of these macros.
8920 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8921 EMACS_INT, since callers assume the returned value fits in int.
8922 (upcase1): Likewise, for UPCASE_TABLE.
8923 (uppercasep, lowercasep, upcase): New static inline functions.
8924 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8925 the race-condition problem in the old DOWNCASE.
8927 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8928 Rename locals to avoid shadowing.
8929 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8930 (regex_compile, re_search_2, re_match_2_internal):
8931 Remove unused local vars.
8932 (FREE_VAR): Rewrite so as not to use empty "else",
8933 which gcc can warn about.
8934 (regex_compile, re_match_2_internal): Mark locals as initialized.
8935 (RETALLOC_IF): Define only if needed.
8936 (WORDCHAR_P): Likewise. This one is never needed, but is used
8937 only in a comment talking about a compiler bug, so put inside
8938 the #if 0 of that comment.
8939 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8940 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8943 * search.c (boyer_moore): Rename locals to avoid shadowing.
8944 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8945 (PREV_CHAR_BOUNDARY): Likewise.
8947 * search.c (simple_search): Remove unused var.
8949 * dired.c (compile_pattern): Move decl from here ...
8950 * lisp.h: ... to here, so that it can be checked.
8951 (struct re_registers): New forward decl.
8953 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8955 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8957 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8958 Rename locals to avoid shadowing.
8959 (Fvertical_motion): Mark locals as initialized.
8961 * casefiddle.c (casify_object, casify_region): Now static.
8962 (casify_region): Mark local as initialized.
8964 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8966 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8967 New macros, so that the caller can use some names other than
8968 gcpro1, gcpro2, etc.
8969 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8971 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8972 argument, for consistency with GCPRO2_VAR, etc: it is now the
8973 prefix of the variable, not the variable itself. All uses
8975 * dired.c (directory_files_internal, file_name_completion):
8976 Rename locals to avoid shadowing.
8978 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8979 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8980 dired.c's scmp function, had undefined behavior.
8981 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8982 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8983 * buffer.h: ... to here, because these macros use current_buffer,
8984 and the new implementation with inline functions needs to have
8985 current_buffer in scope now, rather than later when the macros
8987 (downcase, upcase1): New static inline functions.
8988 (DOWNCASE, UPCASE1): Reimplement using these functions.
8989 This avoids undefined behavior in expressions like
8990 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8991 from race conditions in accessing the global variables
8992 case_temp1 and case_temp2.
8993 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8994 * lisp.h (case_temp1, case_temp2): Remove their decls.
8995 * character.h (ASCII_CHAR_P): Move from here ...
8996 * lisp.h: ... to here, so that the inline functions mentioned
8999 * dired.c (directory_files_internal_unwind): Now static.
9001 * fileio.c (file_name_as_directory, directory_file_name):
9002 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9004 (file_name_as_directory): Use const pointers when appropriate.
9005 (Fexpand_file_name): Likewise. In particular, newdir might
9006 point at constant storage, so make it a const pointer.
9007 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9008 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9010 (Fset_file_times, Finsert_file_contents, auto_save_error):
9011 Rename locals to avoid shadowing.
9013 * minibuf.c (choose_minibuf_frame_1): Now static.
9014 (Ftry_completion, Fall_completions): Rename or remove locals
9017 * marker.c (bytepos_to_charpos): Remove; unused.
9019 * lisp.h (verify_bytepos, count_markers): New decls,
9020 so that gcc does not warn that these functions aren't declared.
9022 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9023 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9024 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9025 (copy_text): Remove unused local var.
9027 * filelock.c (within_one_second): Now static.
9028 (lock_file_1): Rename local to avoid shadowing.
9030 * buffer.c (fix_overlays_before): Mark locals as initialized.
9031 (fix_start_end_in_overlays): Likewise. This function should be
9032 simplified by using pointers-to-pointers, but that's a different
9034 (switch_to_buffer_1): Now static.
9035 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9036 (report_overlay_modification): Rename locals to avoid shadowing.
9038 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9039 Fix pointer signedness issue.
9040 (sys_subshell): Mark local as volatile if checking for lint,
9041 to suppress a gcc -Wclobbered warning that does not seem to be right.
9042 (MAXPATHLEN): Define only if needed.
9044 * process.c (serial_open, serial_configure): Move decls from here ...
9045 * systty.h: ... to here, so that they can be checked.
9047 * fns.c (get_random, seed_random): Move extern decls from here ...
9048 * lisp.h: ... to here, so that they can be checked.
9050 * sysdep.c (reset_io): Now static.
9051 (wait_for_termination_signal): Remove; unused.
9053 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9054 (copy_keymap_item, append_key, push_text_char_description):
9056 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9057 (DENSE_TABLE_SIZE): Remove; unused.
9058 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9059 (describe_map_tree):
9060 Rename locals to avoid shadowing.
9062 * keyboard.c: Declare functions static if they are not used elsewhere.
9063 (echo_char, echo_dash, cmd_error, top_level_2):
9064 (poll_for_input, handle_async_input): Now static.
9065 (read_char, kbd_buffer_get_event, make_lispy_position):
9066 (make_lispy_event, make_lispy_movement, apply_modifiers):
9067 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9068 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9069 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9070 (read_key_sequence, read_char): Mark locals as initialized.
9071 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9073 * keyboard.h (make_ctrl_char): New decl.
9074 (mark_kboards): Move decl here ...
9075 * alloc.c (mark_kboards): ... from here.
9077 * lisp.h (force_auto_save_soon): New decl.
9079 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9080 (DEFINE_DUMMY_FUNCTION): New macro.
9081 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9083 (main): Add casts to avoid warnings
9084 if GCC considers string literals to be constants.
9086 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9088 * dbusbind.c: Pointer signedness fixes.
9089 (xd_signature, xd_append_arg, xd_initialize):
9090 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9091 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9092 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9093 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9095 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9096 if GCC considers string literals to be constants.
9097 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9099 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9101 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9102 (print_preprocess, print_object): New macro to fix last change.
9104 * print.c (print_preprocess): Don't forget font objects.
9106 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9108 * emacs.c (USAGE3): Doc fixes.
9110 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9112 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9115 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9117 * lisp.h (VWindow_system, Qfile_name_history):
9118 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9119 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9120 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9122 * w32select.c: Don't #include "keyboard.h".
9123 (run_protected): Add extern declaration for waiting_for_input.
9125 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9126 * w32console.c (detect_input_pending, read_input_pending)
9127 (encode_terminal_code):
9128 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9129 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9130 (w32_system_caret_y, Qfile_name_history):
9131 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9132 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9133 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9134 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9135 * w32proc.c (Qlocal, report_file_error):
9136 * w32term.c (Vwindow_system, updating_frame):
9137 * w32uniscribe.c (initialized, uniscribe_font_driver):
9138 Remove unneeded extern declarations.
9140 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9142 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9144 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9146 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9147 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9148 These macros can no longer be used for assignment.
9150 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9151 Assign struct members directly, instead of using BUF_BEGV etc.
9152 (record_buffer_markers, fetch_buffer_markers): New functions for
9153 recording and fetching special buffer markers.
9154 (set_buffer_internal_1, set_buffer_temp): Use them.
9156 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9158 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9160 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9161 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9163 * xdisp.c (hscroll_window_tree):
9164 (reconsider_clip_changes): Use PT instead of BUF_PT.
9166 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9168 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9169 $(EMACS_ROOT)/lib/intprops.h.
9171 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9173 Fix more problems found by GCC 4.5.2's static checks.
9175 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9176 to unsigned char * to avoid compiler diagnostic.
9177 (xg_free_frame_widgets): Make it clear that a local variable is
9178 needed only if USE_GTK_TOOLTIP.
9179 (gdk_window_get_screen): Make it clear that this macro is needed
9180 only if USE_GTK_TOOLTIP.
9181 (int_gtk_range_get_value): New function, which avoids a diagnostic
9182 from gcc -Wbad-function-cast.
9183 (xg_set_toolkit_scroll_bar_thumb): Use it.
9184 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9185 diagnostic from gcc -Wbad-function-cast.
9186 (get_utf8_string, xg_get_file_with_chooser):
9187 Rename locals to avoid shadowing.
9188 (create_dialog): Move locals to avoid shadowing.
9190 * xgselect.c (xg_select): Remove unused var.
9192 * image.c (four_corners_best): Mark locals as initialized.
9193 (gif_load): Initialize transparent_p to zero (Bug#8238).
9194 Mark another local as initialized.
9195 (my_png_error, my_error_exit): Mark with NO_RETURN.
9197 * image.c (clear_image_cache): Now static.
9198 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9199 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9200 (x_edge_detection): Remove unnecessary cast that
9201 gcc -Wbad-function-cast diagnoses.
9202 (gif_load): Fix pointer signedness.
9203 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9204 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9206 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9208 Improve quality of tests for time stamp overflow.
9209 For example, without this patch (encode-time 0 0 0 1 1
9210 1152921504606846976) returns the obviously-bogus value (-948597
9211 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9212 reports time overflow. See
9213 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9214 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9215 * editfns.c: Include limits.h and intprops.h.
9216 (TIME_T_MIN, TIME_T_MAX): New macros.
9217 (time_overflow): Move earlier, to before first use.
9218 (hi_time, lo_time): New functions, for an accurate test for
9220 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9221 (Fget_internal_run_time): Don't assume time_t fits in int.
9222 (make_time): Use list2 instead of Fcons twice.
9223 (Fdecode_time): More accurate test for out-of-range times.
9224 (check_tm_member): New function.
9225 (Fencode_time): Use it, to test for out-of-range times.
9226 (lisp_time_argument): Don't rely on undefined left-shift and
9227 right-shift behavior when checking for time stamp overflow.
9229 * editfns.c (time_overflow): New function, refactoring common code.
9230 (Fformat_time_string, Fdecode_time, Fencode_time):
9231 (Fcurrent_time_string): Use it.
9233 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9234 * dired.c (make_time): Move to ...
9235 * editfns.c (make_time): ... here.
9236 * systime.h: Note the move.
9238 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9240 * fringe.c (update_window_fringes): Remove unused variables.
9242 * unexmacosx.c (copy_data_segment): Also copy __got section.
9245 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9247 * termcap.c [MSDOS]: Include "msdos.h".
9248 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9249 Constify `char *' arguments and their references according to
9250 prototypes in tparam.h.
9252 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9254 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9255 Adapt all references accordingly.
9257 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9259 2011-03-11 Tom Tromey <tromey@redhat.com>
9261 * buffer.c (syms_of_buffer): Remove obsolete comment.
9263 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9265 * termhooks.h (encode_terminal_code): Declare prototype.
9267 * msdos.c (encode_terminal_code): Don't declare prototype.
9269 * term.c (encode_terminal_code): Now external again, used by
9270 w32console.c and msdos.c.
9272 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9273 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9275 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9277 Fix some minor problems found by GCC 4.5.2's static checks.
9279 * fringe.c (update_window_fringes): Mark locals as initialized
9281 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9283 * alloc.c (mark_fringe_data): Move decl from here ...
9284 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9285 to check its interface.
9286 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9288 * fontset.c (free_realized_fontset): Now static.
9289 (Fset_fontset_font): Rename local to avoid shadowing.
9290 (fontset_font): Mark local as initialized.
9291 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9293 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9295 * xselect.c (x_disown_buffer_selections): Remove; not used.
9296 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9297 (x_own_selection, Fx_disown_selection_internal): Rename locals
9299 (x_handle_dnd_message): Remove local to avoid shadowing.
9301 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9302 so that the caller can use some name other than gcpro1.
9303 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9304 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9305 (Fx_backspace_delete_keys_p):
9306 Use them to avoid shadowing, and rename vars to avoid shadowing.
9307 (x_decode_color, x_set_name, x_window): Now static.
9308 (Fx_create_frame): Add braces to silence GCC warning.
9309 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9310 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9311 Remove unused locals.
9312 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9313 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9314 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9317 * xterm.h (x_mouse_leave): New decl.
9319 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9320 Remove unused functions.
9321 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9322 (x_calc_absolute_position): Now static.
9323 (XTread_socket): Don't define label "out" unless it's used.
9324 Don't declare local "event" unless it's used.
9325 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9326 unless they are used.
9327 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9328 (x_fatal_error_signal): Remove; not used.
9329 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9330 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9331 (x_error_catcher, x_connection_closed, x_error_handler):
9332 (x_error_quitter, xembed_send_message, x_iconify_frame):
9333 (my_log_handler): Rename locals to avoid shadowing.
9334 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9335 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9337 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9338 Rename or move locals to avoid shadowing.
9339 (tty_defined_color, merge_face_heights): Now static.
9340 (free_realized_faces_for_fontset): Remove; not used.
9341 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9342 does not deduce is never used uninitialized.
9343 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9344 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9346 * terminal.c (store_terminal_param): Now static.
9348 * xmenu.c (menu_highlight_callback): Now static.
9349 (set_frame_menubar): Remove unused local.
9350 (xmenu_show): Rename parameter to avoid shadowing.
9351 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9352 since they might point to immutable storage.
9353 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9354 since it's unused otherwise.
9356 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9357 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9358 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9359 avoids a gcc -Wuninitialized diagnostic.
9360 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9361 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9362 does not deduce are never used uninitialized.
9364 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9366 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9367 * window.c (window_loop, size_window):
9368 (run_window_configuration_change_hook, enlarge_window): Likewise.
9370 * window.c (display_buffer): Now static.
9371 (size_window): Mark variables that gcc -Wuninitialized
9372 does not deduce are never used uninitialized.
9373 * window.h (check_all_windows): New decl, to forestall
9374 gcc -Wmissing-prototypes diagnostic.
9375 * dispextern.h (bidi_dump_cached_states): Likewise.
9377 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9379 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9381 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9382 and to avoid gcc -Wuninitialized warning.
9383 (load_charset_map): Mark variables that gcc -Wuninitialized
9384 does not deduce are never used uninitialized.
9385 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9387 * coding.c (coding_set_source, coding_set_destination):
9388 Use "else { /* comment */ }" rather than "else /* comment */;"
9389 for clarity, and to avoid gcc -Wempty-body warning.
9390 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9391 a block, when the outer 'i' will do.
9392 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9393 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9394 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9395 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9396 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9397 Rename locals to avoid shadowing.
9398 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9399 * coding.c (emacs_mule_char, encode_invocation_designation):
9400 Now static, since they're not used elsewhere.
9401 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9402 (decode_coding_object, encode_coding_object, detect_coding_system):
9403 (decode_coding_emacs_mule): Mark variables that gcc
9404 -Wuninitialized does not deduce are never used uninitialized.
9405 (detect_coding_iso_2022): Initialize a local variable that might
9406 be used uninitialized. Leave a FIXME because it's not clear that
9407 this initialization is needed. (Bug#8211)
9408 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9409 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9410 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9411 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9412 Remove unused macros.
9414 * category.c (hash_get_category_set): Remove unused local var.
9415 (copy_category_table): Now static, since it's not used elsewhere.
9416 * character.c (string_count_byte8): Likewise.
9418 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9419 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9421 * chartab.c (copy_sub_char_table): Now static, since it's not used
9423 (sub_char_table_ref_and_range, char_table_ref_and_range):
9424 Rename locals to avoid shadowing.
9425 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9427 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9428 (BIDI_BOB): Remove unused macro.
9430 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9431 deduce are never used uninitialized.
9432 * term.c (encode_terminal_code): Likewise.
9434 * term.c (encode_terminal_code): Now static. Remove unused local.
9436 * tparam.h: New file.
9437 * term.c, tparam.h: Include it.
9438 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9439 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9440 Move these decls to tparam.h, and make them agree with what
9441 is actually in tparam.c. The previous trick of using incompatible
9442 decls in different modules does not conform to the C standard.
9443 All callers of tparam changed to use tparam's actual API.
9444 * tparam.c (tparam1, tparam, tgoto):
9445 Use const pointers where appropriate.
9447 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9448 * cm.h (struct cm): Likewise.
9449 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9450 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9451 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9452 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9453 (turn_on_face, init_tty): Likewise.
9454 * termchar.h (struct tty_display_info): Likewise.
9456 * term.c (term_mouse_position): Rename local to avoid shadowing.
9458 * alloc.c (mark_ttys): Move decl from here ...
9459 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9461 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9463 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9465 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9467 * search.c (compile_pattern_1): Remove argument regp, unused since
9468 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9469 (compile_pattern): Don't pass it.
9471 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9473 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9474 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9476 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9478 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9480 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9481 gdk_window_get_screen, gdk_window_get_geometry,
9482 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9483 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9484 (xg_get_pixbuf_from_pixmap): New function.
9485 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9486 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9487 Call xg_get_pixbuf_from_pixmap instead of
9488 gdk_pixbuf_get_from_drawable.
9489 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9490 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9491 (xg_check_special_colors): Use GtkStyleContext and its functions
9493 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9494 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9495 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9496 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9497 Call gtk_widget_get_preferred_size.
9498 (xg_frame_resized): gdk_window_get_geometry only takes 5
9500 (xg_win_to_widget, xg_event_is_for_menubar):
9501 Call gdk_x11_window_lookup_for_display.
9502 (xg_set_widget_bg): New function.
9503 (delete_cb): New function.
9504 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9505 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9506 (xg_set_background_color): Call xg_set_widget_bg.
9507 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9508 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9509 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9510 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9512 (update_frame_tool_bar): Call gtk_widget_hide.
9513 (xg_initialize): Use GDK_KEY_g.
9515 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9517 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9519 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9520 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9521 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9523 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9525 * w32xfns.c (select_palette): Check success of RealizePalette against
9526 GDI_ERROR, not zero.
9528 See ChangeLog.11 for earlier changes.
9534 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9536 This file is part of GNU Emacs.
9538 GNU Emacs is free software: you can redistribute it and/or modify
9539 it under the terms of the GNU General Public License as published by
9540 the Free Software Foundation, either version 3 of the License, or
9541 (at your option) any later version.
9543 GNU Emacs is distributed in the hope that it will be useful,
9544 but WITHOUT ANY WARRANTY; without even the implied warranty of
9545 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9546 GNU General Public License for more details.
9548 You should have received a copy of the GNU General Public License
9549 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.