1 2012-04-23 Eli Zaretskii <eliz@gnu.org>
3 * xdisp.c (pos_visible_p): If the window start position is beyond
4 ZV, start the display from buffer beginning. Prevents assertion
5 violation in init_iterator when the minibuffer window is scrolled
8 * window.c (window_scroll_pixel_based): Likewise.
10 2012-04-23 Chong Yidong <cyd@gnu.org>
12 * keymap.c (where_is_internal): Doc fix (Bug#10872).
14 2012-04-20 Glenn Morris <rgm@gnu.org>
16 * fileio.c (Fcopy_file, Fset_file_selinux_context):
17 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
19 2012-04-20 Eli Zaretskii <eliz@gnu.org>
21 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers): Don't
22 overrun array limits of glyph row's used[] array. (Bug#11288)
24 2012-04-20 Chong Yidong <cyd@gnu.org>
26 * process.c (wait_reading_process_output): If EIO occurs on a pty,
27 set the status to "failed" and ensure that sentinel is run.
29 2012-04-18 Glenn Morris <rgm@gnu.org>
31 * process.c (Fset_process_inherit_coding_system_flag)
32 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
33 (Fmake_network_process, Fmake_serial_process): Doc fix.
35 2012-04-17 Eli Zaretskii <eliz@gnu.org>
37 * xdisp.c (string_buffer_position_lim): Limit starting position to
39 (set_cursor_from_row): If called for a mode-line or header-line
40 row, return zero immediately.
41 (try_cursor_movement): If inside continuation line, don't back up
42 farther than the first row after the header line, if any. Don't
43 consider the header-line row as "partially visible", even if
44 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
46 2012-04-13 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
48 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n" (bug#11238).
50 2012-04-10 Teodor Zlatanov <tzz@lifelogs.com>
52 * process.c (make_process):
53 * process.h: Add integer `gnutls_handshakes_tried' member to
56 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
57 Add convenience `GNUTLS_LOG2i' macro.
59 * gnutls.c (gnutls_log_function2i): Convenience log function.
60 (emacs_gnutls_read): Use new log functions,
61 `gnutls_handshakes_tried' process member, and
62 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
63 attempts per process (connection).
65 2012-04-09 Eli Zaretskii <eliz@gnu.org>
67 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
68 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
70 2012-04-09 Jan Djärv <jan.h.d@swipnet.se>
72 * nsterm.m (constrainFrameRect): Always constrain when there is only
73 one screen (Bug#10962).
75 2012-04-06 Eli Zaretskii <eliz@gnu.org>
77 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
78 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
79 about subtle differences between FETCH_CHAR* and STRING_CHAR*
80 macros related to unification of CJK characters. For the details,
81 see the discussion following the message here:
82 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
84 2012-04-04 Chong Yidong <cyd@gnu.org>
86 * keyboard.c (Vdelayed_warnings_list): Doc fix.
88 2012-04-01 Eli Zaretskii <eliz@gnu.org>
90 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
91 instead of alloca. (Bug#11138)
93 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
95 * w32menu.c (is_simple_dialog): Properly check lisp types.
98 2012-03-31 Eli Zaretskii <eliz@gnu.org>
100 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
101 position we get to after a call to move_it_to fails the
102 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
103 only if we wind up in a string from display property. (Bug#11063)
105 * window.c (Fdelete_other_windows_internal): Invalidate the row
106 and column information about mouse highlight, so that redisplay
107 restores it after reallocating the glyph matrices. (Bug#7464)
109 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
110 string comes from a `display' text property, use the buffer
111 position of that property as if we actually saw that position in
113 (move_it_by_lines): Remove the assertion that
114 "it->current_x == 0 && it->hpos == 0" which can be legitimately
115 violated when there's a before-string at the beginning of a line.
118 2012-03-30 Eli Zaretskii <eliz@gnu.org>
120 * xdisp.c (append_space_for_newline): If the default face was
121 remapped, use the remapped face for the appended newline.
122 (extend_face_to_end_of_line): Use the remapped default face for
123 extending the face to the end of the line.
124 (display_line): Call extend_face_to_end_of_line when the default
125 face was remapped. (Bug#11068)
127 2012-03-29 Eli Zaretskii <eliz@gnu.org>
129 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
131 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
133 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
135 2012-03-27 Glenn Morris <rgm@gnu.org>
137 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
140 2012-03-26 Kenichi Handa <handa@m17n.org>
142 * dispextern.h (struct glyph): Fix previous change. Change the
143 bit length of glyphless.ch to 25 (Bug#11082).
145 2012-03-26 Chong Yidong <cyd@gnu.org>
147 * keyboard.c (Vselection_inhibit_update_commands): New variable.
148 (command_loop_1): Use it; inhibit selection update for
149 handle-select-window too (Bug#8996).
151 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
153 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
155 2012-03-25 Kenichi Handa <handa@m17n.org>
157 * dispextern.h (struct glyph): Change the bit length of
158 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
160 2012-03-24 Eli Zaretskii <eliz@gnu.org>
162 * s/ms-w32.h (tzname): Include time.h before redirecting to
163 _tzname. Fixes the MSVC build. (Bug#9960)
165 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
167 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
170 * xterm.c (XTread_socket): Only modify handling_signal if
171 !SYNC_INPUT. (Bug#11080)
173 2012-03-23 Eli Zaretskii <eliz@gnu.org>
175 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
176 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
177 when fetching a multibyte character consumes more bytes than
178 CHAR_BYTES returns, due to unification of CJK characters in
179 string_char. (Bug#11073)
181 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
183 * process.c (wait_reading_process_output): Handle pty disconnect
184 by refraining from sending oneself a SIGCHLD (bug#10933).
186 2012-03-22 Chong Yidong <cyd@gnu.org>
188 * dispextern.h (struct it): New member string_from_prefix_prop_p.
190 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
191 Mark string as coming from a prefix property.
192 (handle_face_prop): Use default face for prefix strings (Bug#4281).
193 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
195 2012-03-21 Chong Yidong <cyd@gnu.org>
197 * xfaces.c (Vface_remapping_alist): Doc fix.
199 2012-03-20 Eli Zaretskii <eliz@gnu.org>
201 * w32proc.c (Fw32_set_console_codepage)
202 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
205 2012-03-20 Chong Yidong <cyd@gnu.org>
207 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
208 to reflect default non-nil value of redisplay-dont-pause.
210 2012-03-19 Kenichi Handa <handa@m17n.org>
212 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
213 it fit in a valid range (Bug#11003).
215 2012-03-18 Eli Zaretskii <eliz@gnu.org>
217 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
218 that is not from display property, accept the row as a "cursor
219 row" if one of the string's character has a non-nil `cursor'
220 property. Fixes cursor positioning when there are newlines in
221 overlay strings, e.g. in icomplete.el. (Bug#11035)
223 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
225 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
227 2012-03-12 Chong Yidong <cyd@gnu.org>
229 * eval.c (inhibit_lisp_code): Rename from
230 inhibit_window_configuration_change_hook; move from window.c.
232 * xfns.c (unwind_create_frame_1, Fx_create_frame):
233 * window.c (run_window_configuration_change_hook)
234 (syms_of_window): Callers changed.
236 2012-03-11 Chong Yidong <cyd@gnu.org>
238 * keymap.c (Fkey_description): Doc fix (Bug#9700).
240 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
242 2012-03-10 Chong Yidong <cyd@gnu.org>
244 * frame.c (other_visible_frames): Don't assume the selected frame
245 is visible (Bug#10955).
247 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
249 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
251 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
253 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
254 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
257 2012-03-03 Glenn Morris <rgm@gnu.org>
259 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
261 2012-03-02 Eli Zaretskii <eliz@gnu.org>
263 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
264 position past the first glyph_row that ends at ZV. (Bug#10902)
265 (redisplay_window, next_element_from_string): Fix typos in
267 (redisplay_window): Pass to move_it_vertically the margin in
268 pixels, not in screen lines.
270 2012-03-02 Glenn Morris <rgm@gnu.org>
272 * buffer.c (buffer-list-update-hook): Doc fix.
274 2012-02-29 Eli Zaretskii <eliz@gnu.org>
276 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
277 push_it before setting up the iterator for the first overlay
278 string, even if we have an empty string loaded.
279 (next_overlay_string): If there's an empty string on the iterator
280 stack, pop the stack. (Bug#10903)
282 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
284 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
285 Suggested by Stefan Monnier in
286 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
287 * alloc.c (widen_to_Lisp_Object): New static function.
288 (mark_memory): Also mark Lisp_Objects by fetching pointer words
289 and widening them to Lisp_Objects. This would work even if
290 USE_LSB_TAG is defined and wide integers are used, which might
291 happen in a future version of Emacs.
293 2012-02-25 Chong Yidong <cyd@gnu.org>
295 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
298 * xselect.c (Fx_selection_exists_p): Doc fix.
299 (x_clipboard_manager_save_all): Print an informative message
300 before saving to clipboard manager.
302 2012-02-24 Chong Yidong <cyd@gnu.org>
304 * keyboard.c (process_special_events): Handle all X selection
305 requests in kbd_buffer, not just the next one (Bug#8869).
307 2012-02-23 Chong Yidong <cyd@gnu.org>
309 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
310 call when setting menu-bar-lines and tool-bar-lines parameters.
311 (unwind_create_frame_1): New helper function.
313 * window.c (inhibit_window_configuration_change_hook): New var.
314 (run_window_configuration_change_hook): Obey it.
315 (syms_of_window): Initialize it.
317 2012-02-22 Chong Yidong <cyd@gnu.org>
319 * xterm.c (x_draw_image_relief): Add missing type check for
320 Vtool_bar_button_margin (Bug#10743).
322 2012-02-21 Chong Yidong <cyd@gnu.org>
324 * fileio.c (Vfile_name_handler_alist): Doc fix.
326 * buffer.c (Fget_file_buffer): Protect against invalid file
327 handler return value.
329 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
331 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
332 when computing $valmask.
334 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
335 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
336 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
337 It's useless in that case, and it can cause problems on hosts
338 that allocate halves of EMACS_INT values separately.
339 Reported by Dan Horák. Diagnosed by Andreas Schwab in
340 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
341 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
342 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
343 it avoids undefined behavior on hosts where shifting right by more
344 than the word width has undefined behavior.
346 2012-02-19 Chong Yidong <cyd@gnu.org>
348 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
349 (Funhandled_file_name_directory, Ffile_name_as_directory)
350 (Fdirectory_file_name, Fexpand_file_name)
351 (Fsubstitute_in_file_name): Protect against invalid file handler
352 return values (Bug#10845).
354 2012-02-18 Eli Zaretskii <eliz@gnu.org>
356 * .gdbinit (pitx): Fix incorrect references to fields of the
359 2012-02-17 Chong Yidong <cyd@gnu.org>
361 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
363 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
365 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
366 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
368 2012-02-15 Chong Yidong <cyd@gnu.org>
370 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
371 marked as special. Also, starting docstrings with * is obsolete.
373 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
375 * gnutls.c (emacs_gnutls_write): Fix last change.
377 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
379 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
382 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
384 * keymap.c (Fsingle_key_description): Handle char ranges.
386 2012-02-12 Chong Yidong <cyd@gnu.org>
388 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
389 as that creates a dangerous corner case.
391 * window.c (Fdelete_window_internal): Invalidate the mouse
392 highlight (Bug#9904).
394 2012-02-12 Glenn Morris <rgm@gnu.org>
396 * xselect.c (Fx_own_selection_internal)
397 (Fx_get_selection_internal, Fx_disown_selection_internal)
398 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
399 * nsselect.m (Fx_own_selection_internal)
400 (Fx_disown_selection_internal, Fx_selection_exists_p)
401 (Fx_selection_owner_p, Fx_get_selection_internal):
402 Sync docs and argument specs with the xselect.c versions.
404 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
406 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
408 2012-02-11 Eli Zaretskii <eliz@gnu.org>
410 * w32select.c (Fx_selection_exists_p): Sync doc string and
411 argument list with xselect.c. (Bug#10783)
413 * w16select.c (Fx_selection_exists_p): Sync doc string and
414 argument list with xselect.c. (Bug#10783)
416 2012-02-10 Glenn Morris <rgm@gnu.org>
418 * fns.c (Fsecure_hash): Doc fix.
420 2012-02-09 Kenichi Handa <handa@m17n.org>
422 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
424 2012-02-07 Chong Yidong <cyd@gnu.org>
426 * buffer.c (Fbuffer_local_variables)
427 (buffer_lisp_local_variables): Handle unbound vars correctly;
428 don't let Qunbound leak into Lisp.
430 2012-02-07 Glenn Morris <rgm@gnu.org>
432 * image.c (Fimagemagick_types): Doc fix.
434 * image.c (imagemagick-render-type): Change it from a lisp object
435 to an integer. Move the doc here from the lisp manual.
436 Treat all values not equal to 0 the same.
438 2012-02-06 Chong Yidong <cyd@gnu.org>
440 * doc.c (store_function_docstring): Avoid applying docstring of
441 alias to base function (Bug#2603).
443 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
445 * .gdbinit (pp1, pv1): Remove redundant defines.
448 2012-02-04 Chong Yidong <cyd@gnu.org>
450 * nsterm.m: Declare a global (Bug#10694).
452 2012-02-04 Eli Zaretskii <eliz@gnu.org>
454 * w32.c (get_emacs_configuration_options):
455 Include --enable-checking, if specified, in the return value.
457 2012-02-04 Martin Rudalics <rudalics@gmx.at>
459 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
460 after rounding frame sizes. (Bug#9723)
462 2012-02-04 Eli Zaretskii <eliz@gnu.org>
464 * keyboard.c (adjust_point_for_property): Don't position point
465 before BEGV. (Bug#10696)
467 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
469 Handle overflow when computing char display width (Bug#9496).
470 * character.c (char_width): Return EMACS_INT, not int.
471 (char_width, c_string_width): Check for overflow when
472 computing the width; this is possible now that individual
473 characters can have unbounded width. Problem introduced
474 by merge from Emacs 23 on 2012-01-19.
476 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
478 * dbusbind.c (Fdbus_register_method): Mention the return value
479 :ignore in the docstring.
481 2012-02-02 Glenn Morris <rgm@gnu.org>
483 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
485 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
486 Unconditionally set to t. (Bug#10673)
487 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
488 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
489 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
491 2012-02-02 Kenichi Handa <handa@m17n.org>
493 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
494 0, do not call append_composite_glyph.
496 2012-02-02 Kenichi Handa <handa@m17n.org>
498 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
500 (x_produce_glyphs): If the component of a composition is a null
501 string, set it->pixel_width to 1 to avoid zero-width glyph.
503 2012-02-01 Eli Zaretskii <eliz@gnu.org>
505 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
506 first 2 arguments are identical. This makes inserting large
507 output from a subprocess an order of magnitude faster on
508 MS-Windows, where all sbrk'ed memory is always contiguous.
510 2012-01-31 Glenn Morris <rgm@gnu.org>
512 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
513 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
514 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
516 2012-01-29 Glenn Morris <rgm@gnu.org>
518 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
520 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
522 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
524 2012-01-28 Chong Yidong <cyd@gnu.org>
526 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
528 2012-01-26 Chong Yidong <cyd@gnu.org>
530 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
532 * search.c (Fsearch_forward, Fsearch_backward): Document negative
533 repeat counts (Bug#10507).
535 2012-01-26 Glenn Morris <rgm@gnu.org>
537 * lread.c (syms_of_lread): Doc fix.
539 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
541 * coding.c (encode_designation_at_bol): Change return value to
544 2012-01-25 Chong Yidong <cyd@gnu.org>
546 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
548 2012-01-21 Chong Yidong <cyd@gnu.org>
550 * floatfns.c (Fcopysign): Make the second argument non-optional,
551 since nil is not allowed anyway.
553 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
555 * process.c (read_process_output): Use p instead of XPROCESS (proc).
556 (send_process): Likewise.
558 2012-01-19 Martin Rudalics <rudalics@gmx.at>
560 * window.c (save_window_save, Fcurrent_window_configuration)
561 (Vwindow_persistent_parameters): Do not use Qstate.
564 2012-01-19 Kenichi Handa <handa@m17n.org>
566 * character.c (char_width): New function.
567 (Fchar_width, c_string_width, lisp_string_width):
568 Use char_width (Bug#9496).
570 2012-01-16 Martin Rudalics <rudalics@gmx.at>
572 * window.c (Vwindow_persistent_parameters): New variable.
573 (Fset_window_configuration, save_window_save): Handle persistent
576 2012-01-14 Eli Zaretskii <eliz@gnu.org>
578 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
579 thrashing the stack of the thread. (Bug#9087)
581 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
583 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
585 2012-01-11 Eli Zaretskii <eliz@gnu.org>
587 * xdisp.c (rows_from_pos_range): Handle the case where the
588 highlight ends on a newline. (Bug#10464)
589 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
590 he end column for display of highlight that ends on a newline
593 2012-01-11 Glenn Morris <rgm@gnu.org>
595 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
596 from load-path also when installation-directory is nil. (Bug#10208)
598 2012-01-10 Glenn Morris <rgm@gnu.org>
600 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
602 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
603 Update template values to be closer to their typical values these days.
605 2012-01-09 Eli Zaretskii <eliz@gnu.org>
607 * xdisp.c (rows_from_pos_range): Accept additional argument
608 DISP_STRING, and accept any glyph in a row whose object is that
609 string as eligible for mouse highlight. Fixes mouse highlight of
610 display strings from overlays. (Bug#10464)
612 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
614 emacs: fix an auto-save permissions race condition (Bug#10400)
615 * fileio.c (auto_saving_dir_umask): New static var.
616 (Fmake_directory_internal): Use it.
617 (do_auto_save_make_dir): Set it, instead of invoking chmod after
618 creating the directory. The old code temporarily assigns
619 too-generous permissions to the directory.
620 (do_auto_save_eh): Clear it.
621 (Fdo_auto_save): Catch all errors, not just file errors, so
622 that the var is always cleared.
624 2012-01-07 Eli Zaretskii <eliz@gnu.org>
626 * search.c (scan_buffer): Pass character positions to
627 know_region_cache, not byte positions. (Bug#6540)
629 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
631 * w32.c (sys_rename): Report EXDEV when rename of a directory
632 fails because the target is on another logical disk. (Bug#10284)
634 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
636 * xterm.c (x_embed_request_focus): New function.
638 * xterm.h: Add prototype.
640 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
642 2012-01-05 Glenn Morris <rgm@gnu.org>
644 * emacs.c (emacs_copyright): Update short copyright year to 2012.
646 2012-01-01 Eli Zaretskii <eliz@gnu.org>
648 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
649 Load gnutls_transport_set_lowat only if GnuTLS version is below
651 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
652 GnuTLS versions below 2.11.1.
654 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
656 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
657 to the doc string advising against its use for altering the way
658 windows are scrolled.
660 2011-12-28 Kenichi Handa <handa@m17n.org>
662 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
663 coding-system ASCII compatible only when it does not produce BOM
664 on encoding (Bug#10383).
666 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
668 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
670 (create_and_show_popup_menu): Always use menu_position_func for
673 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
675 * callint.c (Fcall_interactively): Don't truncate prompt string.
677 2011-12-23 Eli Zaretskii <eliz@gnu.org>
679 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
680 property that ends at ZV, so that the bidi iteration could be
681 resumed from there (after widening). (Bug#10360)
683 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
685 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
687 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
689 * nsterm.m (x_free_frame_resources):
690 Release f->output_data.ns->miniimage.
691 (ns_index_color): Fix indentation. Do not retain
692 color_table->colors[i].
694 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
697 * nsfns.m (x_set_background_color): Assign return value from
698 ns_index_color to face-background instead of NSColor*.
699 (ns_implicitly_set_icon_type): Fix indentation.
700 Change assignment in for loop to comparison.
702 * emacs.c (ns_pool): New variable.
703 (main): Assign ns_pool.
704 (Fkill_emacs): Call ns_release_autorelease_pool.
706 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
707 autorelease fdesc, release fdAttrs and tdict.
708 (ns_get_covering_families): Release charset.
709 (ns_findfonts): Release NSFontDescriptor created with new.
710 (ns_uni_to_glyphs): Fix indentation.
711 (setString): Release attrStr before assigning new value.
713 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
715 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
717 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
718 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
720 2011-12-18 David Reitter <reitter@cmu.edu>
722 * nsterm.m (ns_term_init): Subscribe for notifications
723 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
724 to method trackingNotification in EmacsMenu.
726 * nsmenu.m (trackingMenu): New variable.
727 (trackingNotification): New method (from Aquamacs).
728 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
729 from Aquamacs (Bug#7030).
731 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
733 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
734 (symbol_to_nsstring): Fix indentation.
735 (ns_symbol_to_pb): New function.
736 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
737 (Fns_rotate_cut_buffers_internal): Remove.
738 (Fns_store_selection_internal): Rename from
739 Fns_store_cut_buffer_internal.
740 (ns_get_foreign_selection, Fx_own_selection_internal)
741 (Fx_disown_selection_internal, Fx_selection_exists_p)
742 (Fns_get_selection_internal, Fns_store_selection_internal):
743 Use ns_symbol_to_pb and check if return value is nil.
744 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
745 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
746 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
747 renamed to Sns_store_selection_internal.
748 (ns_handle_selection_request): Move code to Fx_own_selection_internal
749 and remove this function.
750 (ns_handle_selection_clear): Remove, never used.
751 (Fx_own_selection_internal): Move code from ns_handle_selection_request
754 2011-12-17 Ken Brown <kbrown@cornell.edu>
756 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
757 GID is unknown (Bug#10257).
759 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
761 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
762 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
763 which caused a build failure on GNU/Linux IA-64. This problem was
764 introduced by my 2011-10-07 patch.
766 2011-12-15 Juri Linkov <juri@jurta.org>
768 * image.c (imagemagick_error): New function. (Bug#10112)
769 (imagemagick_load_image): Comment out `MagickSetResolution' call.
770 Use `imagemagick_error' where ImageMagick functions return
772 (Fimagemagick_types): Add `Fnreverse' to return the list in the
775 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
777 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
778 fill background (Bug#8992).
780 2011-12-13 Martin Rudalics <rudalics@gmx.at>
782 * window.c (Vwindow_combination_resize)
783 (Vwindow_combination_limit): Use t instead of non-nil in
785 (Vrecenter_redisplay): Add first sentence of doc-string on
787 (Frecenter): Fix doc-string typo.
789 2011-12-11 Kenichi Handa <handa@m17n.org>
791 * coding.c (Funencodable_char_position): Pay attention to the
792 buffer text relocation (Bug#9389).
794 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
796 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
797 gtk_init (Bug#10100).
799 2011-12-10 Eli Zaretskii <eliz@gnu.org>
801 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
802 IT->string is nil. (Bug#10263)
804 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
806 * nsterm.h (x_free_frame_resources): Declare.
808 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
809 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
811 * nsterm.h (ns_get_defaults_value): Declare.
813 * nsterm.m (ns_default): Call ns_get_defaults_value.
815 2011-12-09 Eli Zaretskii <eliz@gnu.org>
817 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
820 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
822 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
823 that where the value of an _OBJC_* symbol points to is in the .bss
826 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
828 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
829 after the loop to call ccl_driver at least once (Bug#8619).
831 2011-12-08 Kenichi Handa <handa@m17n.org>
833 * ftfont.c (get_adstyle_property): Fix previous change
836 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
838 * w32.c (init_environment): If no_site_lisp, remove site-lisp
839 dirs from the default value of EMACSLOADPATH (bug#10208).
841 2011-12-07 Glenn Morris <rgm@gnu.org>
843 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
844 installation and source directories as well. (Bug#10208)
846 2011-12-06 Chong Yidong <cyd@gnu.org>
848 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
850 2011-12-06 Glenn Morris <rgm@gnu.org>
852 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
853 as an error, not just -1. (Bug#10217)
855 2011-12-05 Chong Yidong <cyd@gnu.org>
857 * keyboard.c (process_special_events): New function.
858 (swallow_events, Finput_pending_p): Use it (Bug#10195).
860 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
862 * coding.c (encode_designation_at_bol): Don't use uninitialized
863 local variable (Bug#9318).
865 2011-12-05 Kenichi Handa <handa@m17n.org>
867 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
868 return Qnil (Bug#8046, Bug#10193).
870 2011-12-05 Kenichi Handa <handa@m17n.org>
872 * coding.c (encode_designation_at_bol): New args charbuf_end and
873 dst. Return the number of produced bytes. Callers changed.
874 (coding_set_source): Return how many bytes coding->source was
876 (coding_set_destination): Return how many bytes
877 coding->destination was relocated.
878 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
879 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
881 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
883 * coding.c (CODING_CHAR_CHARSET_P): New macro.
884 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
887 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
889 The following changes are to fix Bug#9318.
891 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
892 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
893 (encode_coding_iso_2022, encode_coding_sjis)
894 (encode_coding_big5, encode_coding_charset): Use the above macros.
896 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
898 * lisp.h (process_quit_flag): Fix external declaration.
900 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
902 Don't macro-inline non-performance-critical code.
903 * eval.c (process_quit_flag): New function.
904 * lisp.h (QUIT): Use it.
906 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
908 * nsfns.m (get_geometry_from_preferences): New function.
909 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
911 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
913 * emacs.c (Qkill_emacs): Define.
914 (syms_of_emacs): Initialize it.
915 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
916 Qquit_flag to `kill-emacs' instead.
917 (quit_throw_to_read_char): Add parameter `from_signal'.
918 All callers changed. Call Fkill_emacs if requested and safe.
919 * lisp.h (QUIT): Call Fkill_emacs if requested.
921 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
923 * widget.c (update_wm_hints): Return if wmshell is null.
924 (widget_update_wm_size_hints): New function.
926 * widget.h (widget_update_wm_size_hints): Declare.
928 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
929 widget_update_wm_size_hints (Bug#10104).
931 2011-12-03 Eli Zaretskii <eliz@gnu.org>
933 * xdisp.c (handle_invisible_prop): If the invisible text ends just
934 before a newline, prepare the bidi iterator for consuming the
935 newline, and keep the current paragraph direction. (Bug#10183)
936 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
938 2011-12-02 Juri Linkov <juri@jurta.org>
940 * search.c (Fword_search_regexp): New Lisp function created from
941 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
942 (Fword_search_backward, Fword_search_forward)
943 (Fword_search_backward_lax, Fword_search_forward_lax):
944 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
945 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
947 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
949 * fileio.c (Finsert_file_contents): Move after-change-function call
950 to before the "handled:" label, since all "goto handled" appear in
951 cases where the *-change-functions have already been properly called
954 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
956 * keyboard.c (interrupt_signal): Don't call kill-emacs when
957 waiting for input. (Bug#10169)
959 2011-11-30 Eli Zaretskii <eliz@gnu.org>
961 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
962 verifies glyph row's hash code--we have just reallocated the
963 glyphs, so their contents can be complete garbage. (Bug#10164)
965 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
967 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
969 2011-11-30 Eli Zaretskii <eliz@gnu.org>
971 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
972 attributes are tested _before_ calling verify_row_hash, to protect
973 against GCC re-ordering of the tests. (Bug#10164)
975 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
977 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
979 * xterm.c (handle_one_xevent): Only set async_visible and friends
980 if net_wm_state_hidden_seen is non-zero (Bug#10002)
981 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
982 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
984 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
986 Remove GCPRO-related macros that exist only to avoid shadowing locals.
987 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
988 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
989 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
990 All uses changed to use GCPRO1 etc.
991 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
992 Revert to old implementation (i.e., before 2011-03-11).
994 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
996 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
997 of scroll runs so as to avoid assigning disabled bogus rows and
998 unnecessary graphics copy operations.
1000 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1002 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1003 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1004 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1005 (malloc, free, realloc, calloc): Redirect to e_* only when
1008 * lisp.h (GCTYPEBITS): Move before first use.
1009 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1010 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1011 this macro definition.
1013 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1016 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1018 * gtkutil.c (xg_create_frame_widgets):
1019 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1020 present with Gtk+ 2.0.
1022 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1024 * fileio.c (Finsert_file_contents): Undo previous change; see
1025 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1027 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1029 Rename locals to avoid shadowing.
1030 * fileio.c (Finsert_file_contents):
1031 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1032 * process.c (wait_reading_process_output):
1033 Rename inner 'proc' to 'p' to avoid shadowing.
1034 Indent for consistency with usual Emacs style.
1036 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1038 * xdisp.c (redisplay_window): If cursor row is not fully visible
1039 after recentering, and scroll-conservatively is set to a large
1040 number, scroll window by a few more lines to make the cursor fully
1041 visible and out of scroll-margin. (Bug#10105)
1042 (start_display): Don't move to the next line if the display should
1043 start at a newline that is part of a display vector or an overlay
1046 2011-11-24 Juri Linkov <juri@jurta.org>
1048 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1049 after the `MagickPingImage' call. (Bug#10112)
1051 2011-11-23 Chong Yidong <cyd@gnu.org>
1053 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1055 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1057 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1058 making another buffer current. (Bug#10114)
1060 2011-11-23 Glenn Morris <rgm@gnu.org>
1062 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1064 2011-11-23 Chong Yidong <cyd@gnu.org>
1066 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1067 using it (Bug#5984).
1069 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1071 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1072 and header-lines, as they don't have one computed for them.
1075 * .gdbinit (prow): Make displayed values more self-explaining.
1076 Add row's hash code.
1078 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1080 * process.c (wait_reading_process_output): Fix asynchrounous
1081 GnuTLS socket handling on some versions of the GnuTLS library.
1082 (wait_reading_process_output): Add comment and URL.
1084 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1086 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1088 2011-11-21 Chong Yidong <cyd@gnu.org>
1090 * window.c (Fnext_window, Fprevious_window): Doc fix.
1092 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1094 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1096 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1098 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1100 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1102 * window.c (Fset_window_combination_limit): Rename argument
1104 (Vwindow_combination_limit): Remove "status" from doc-string.
1106 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1108 * m/ibms390.h: Remove.
1109 * m/ibms390x.h: Don't include "ibms390.h".
1111 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1113 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1114 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1116 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1118 * casetab.c (Fset_case_table):
1119 * charset.c (Fcharset_after): Fix typos.
1121 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1123 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1124 Otherwise, valgrind does not work on some platforms.
1125 Problem reported by Andreas Schwab in
1126 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1127 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1128 is set, removing the need for VIRT_ADDRESS_VARIES.
1129 (PURE_P): Use a more-efficient implementation that needs just one
1130 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1131 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1132 to 4 (xorl, subq, cmpq, setbe).
1133 * alloc.c (pure): Always extern now, since that's the
1134 VIRT_ADDR_VARIES behavior.
1135 (PURE_POINTER_P): Use a single comparison, not two, for
1136 consistency with the new puresize.h.
1137 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1138 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1139 Remove VIRT_ADDR_VARIES no longer needed.
1141 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1143 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1144 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1145 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1146 behave as if the cursor position were at the window margin.
1148 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1149 and the cursor position is out of bounds, behave as if the cursor
1150 position were at the window margin. (Bug#10075)
1152 2011-11-18 Chong Yidong <cyd@gnu.org>
1154 * window.c (Fwindow_combination_limit): Make first argument
1155 non-optional, since it is meaningless for live windows like the
1158 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1160 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1162 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1164 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1165 (graft_intervals_into_buffer): Simplify.
1167 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1169 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1170 hash values of the two rows.
1171 (copy_row_except_pointers): Preserve the used[] arrays and the
1172 hash values of the two rows. (Bug#10035)
1173 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1175 * xdisp.c (row_hash): New function, body extracted from
1176 compute_line_metrics.
1177 (compute_line_metrics): Call row_hash, instead of computing the
1180 * dispnew.c (verify_row_hash): Call row_hash for computing the
1181 hash code of a row, instead of duplicating code from xdisp.c.
1183 * dispextern.h (row_hash): Add prototype.
1185 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1187 * frame.c (delete_frame): Don't delete the terminal when the last
1188 X frame is closed if emacs is built with GTK toolkit.
1190 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1192 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1194 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1196 * window.c (Vwindow_splits): Rename to
1197 Vwindow_combination_resize. Suggested by Juri Linkov.
1198 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1201 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1203 * nsfns.m (Fns_font_name):
1204 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1206 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1208 * window.h (window): Rename slot "nest" to "combination_limit".
1209 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1210 (Fset_window_nest): Rename to Fset_window_combination_limit.
1211 (Vwindow_nest): Rename to Vwindow_combination_limit.
1212 (recombine_windows, make_parent_window, make_window)
1213 (Fsplit_window_internal, saved_window)
1214 (Fset_window_configuration, save_window_save): Rename all
1215 occurrences of window_nest to window_combination_limit.
1217 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1219 * image.c (imagemagick_load_image): Fix typo.
1221 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1223 * xdisp.c (display_line): Move the call to
1224 highlight_trailing_whitespace before the call to
1225 compute_line_metrics, since the latter needs to see the final
1226 faces of all the glyphs to compute ROW's hash value.
1227 Fixes assertion violations in row_equal_p. (Bug#10035)
1229 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1231 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1232 just return (bug#10044).
1234 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1236 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1237 with user-defined heap size. Bump the default size of the temacs
1238 heap to 27MB, to avoid memory warning when running temacs.
1239 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1241 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1242 current_matrix and desired_matrix. (Bug#9990)
1243 (verify_row_hash) [XASSERTS]: New function.
1244 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1245 that the hash value of glyph rows is correct.
1247 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1249 * window.h (window): Remove splits slot.
1250 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1251 (Fdelete_other_windows_internal, make_parent_window)
1252 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1253 (Fset_window_configuration, save_window_save): Don't deal with
1254 split status of windows.
1255 (saved_window): Remove splits slot.
1256 (Vwindow_splits): Rewrite doc-string.
1258 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1260 * xfns.c (unwind_create_frame):
1261 * nsfns.m (unwind_create_frame):
1262 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1263 Vframe_list (Bug#9999).
1265 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1267 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1269 2011-11-11 Kenichi Handa <handa@m17n.org>
1271 * callproc.c (Fcall_process): Set the member dst_multibyte of
1274 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1276 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1277 avoid a crash (bug#9496).
1279 2011-11-09 Chong Yidong <cyd@gnu.org>
1281 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1282 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1284 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1286 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1288 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1290 Avoid some portability problems by eschewing 'extern inline' functions.
1291 The trivial performance wins aren't worth the portability hassles; see
1292 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1294 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1295 (window_box_width, window_box_left, window_box_left_offset)
1296 (window_box_right, window_box_right_offset): Undo previous change,
1297 by removing the "extern"s.
1298 * intervals.c (adjust_intervals_for_insertion)
1299 (adjust_intervals_for_deletion): Undo previous change,
1300 making these static again.
1301 (offset_intervals, temp_set_point_both, temp_set_point)
1302 (copy_intervals_to_string): No longer inline.
1303 * xdisp.c (window_text_bottom_y, window_box_width)
1304 (window_box_height, window_box_left_offset)
1305 (window_box_right_offset, window_box_left, window_box_right)
1306 (window_box): No longer inline.
1308 2011-11-08 Chong Yidong <cyd@gnu.org>
1310 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1311 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1312 Signal an error if not a live window.
1313 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1314 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1316 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1318 * lisp.h (syms_of_abbrev): Remove declaration.
1319 Reported by CHENG Gao <chenggao@royau.me>.
1321 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1323 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1324 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1325 of temacs in GUI mode.
1327 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1329 * window.h: Declare delete_all_child_windows instead of
1330 delete_all_subwindows.
1331 * window.c (Fwindow_nest, Fset_window_nest)
1332 (Fset_window_new_total, Fset_window_new_normal)
1333 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1334 (delete_all_subwindows): Rename to delete_all_child_windows.
1335 (Fdelete_other_windows_internal, Fset_window_configuration):
1336 Call delete_all_child_windows instead of delete_all_subwindows.
1337 * frame.c (delete_frame): Call delete_all_child_windows instead
1338 of delete_all_subwindows.
1340 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1342 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1343 This is also needed for porting to any host where GC_MARK_STACK is
1344 not GC_MAKE_GCPROS_NOOPS.
1345 (which_symbols): Use it.
1347 2011-11-07 Kenichi Handa <handa@m17n.org>
1349 * coding.c (coding_set_destination): Check coding->src_pos only
1350 when coding->src_object is a buffer (bug#9910).
1352 * process.c (send_process): Set the member src_multibyte of coding
1353 to 0 (bug#9911) when sending a unibyte text.
1355 * callproc.c (Fcall_process): Set the member src_multibyte of
1356 process_coding to 0 (bug#9912).
1358 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1360 * xmenu.c (cleanup_widget_value_tree): New function.
1361 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1362 calling free_menubar_widget_value_tree directly (Bug#9830).
1364 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1366 Fix some portability problems with 'inline'.
1367 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1368 (window_box_width, window_box_left, window_box_left_offset)
1369 (window_box_right, window_box_right_offset): Declare extern.
1370 Otherwise, these inline functions do not conform to C99 and
1371 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1372 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1373 * intervals.c (adjust_intervals_for_insertion)
1374 (adjust_intervals_for_deletion): Now extern, because otherwise the
1375 extern inline functions 'offset_intervals' couldn't refer to it.
1376 (static_offset_intervals): Remove.
1377 (offset_intervals): Rewrite using the old contents of
1378 static_offset_intervals. The old version didn't conform to C99
1379 because an extern inline function contained a reference to an
1380 identifier with static linkage.
1382 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1384 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1387 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1389 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1390 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1391 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1392 return Qleft_to_right.
1394 2011-11-06 Chong Yidong <cyd@gnu.org>
1396 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1397 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1398 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1399 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1400 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1401 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1402 (Fwindow_vscroll): Doc fix.
1403 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1404 argument, since it makes no sense to pass a live window and for
1405 consistency with window-child.
1407 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1409 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1412 2011-11-05 Jason Rumney <jasonr@gnu.org>
1414 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1415 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1417 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1418 bitwise arithmetic preventing use of unicode-sip and non-truetype
1421 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1423 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1426 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1427 initialization code to keep similarity to xfns.c after changes
1430 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1432 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1433 (unwind_create_frame): New function (Bug#9943).
1434 (Fx_create_frame): Restructure code to be more similar to the one in
1435 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1436 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1437 Move terminal->reference_count++ just before making the frame official
1440 * nsterm.m (x_free_frame_resources): New function.
1441 (x_destroy_window): Move code to x_free_frame_resources.
1443 * xfns.c (unwind_create_frame): Fix comment.
1444 (Fx_create_frame, x_create_tip_frame):
1445 Move terminal->reference_count++ just before making the frame
1446 official. Move initialization of image_cache_refcount and
1447 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1449 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1451 Support MSVC build with newer versions of Visual Studio.
1452 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1453 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1456 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1457 which are not supported by MSVC.
1458 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1459 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1461 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1463 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1465 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1467 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1469 Support MSVC build with newer versions of Visual Studio.
1470 * w32.c: Don't include w32api.h for MSVC.
1471 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1473 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1474 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1475 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1476 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1478 (alloca) [_MSC_VER]: Define to _alloca.
1480 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1482 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1484 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1486 * xdisp.c (note_mouse_highlight): If either of
1487 previous/next-single-property-change returns nil, treat that as
1488 the beginning or the end of the buffer. (Bug#9955)
1490 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1492 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1493 label is not null (Bug#9951).
1494 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1497 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1499 * window.c (Fwindow_body_size): Mention in the doc string that the
1500 return value is in frame's canonical units. (Bug#9949)
1502 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1504 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1506 * w32fns.c (unwind_create_frame): If needed, free the glyph
1507 matrices of the partially constructed frame. (Bug#9943)
1508 * xfns.c (unwind_create_frame): Likewise.
1510 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1512 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1513 Don't stop backward scan on the continuation glyph, even though
1514 its CHARPOS is positive.
1515 (mouse_face_from_buffer_pos, note_mouse_highlight):
1516 Rename cover_string to disp_string.
1518 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1520 * window.c (temp_output_buffer_show): Don't use
1521 Vtemp_buffer_show_specifiers.
1522 (Vtemp_buffer_show_specifiers): Remove unused variable.
1524 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1526 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1527 past the beginning of the current glyph matrix.
1529 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1531 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1532 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1533 HAVE_GTK3 (Bug#9869).
1535 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1536 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1538 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1540 * xterm.c: Declare x_handle_net_wm_state to return int.
1541 (handle_one_xevent): Check if we are iconified but don't have
1542 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1543 (get_current_wm_state): Return non-zero if not hidden,
1544 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1545 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1546 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1547 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1549 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1551 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1552 so that this new function doesn't get optimized away by a
1553 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1555 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1557 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1559 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1561 Fix the `xbytecode' command.
1562 * .gdbinit (xprintbytestr): New command.
1563 (xwhichsymbols): Rename from `which'; all callers changed.
1564 (xbytecode): Print the byte-code string as well.
1566 2011-10-29 Kim Storm <storm@cua.dk>
1568 * alloc.c (which_symbols): New function.
1570 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1572 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1575 2011-10-29 Glenn Morris <rgm@gnu.org>
1577 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1578 Not clear what it was for, and it causes various bugs. (Bug#9839)
1580 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1582 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1583 possible random value that matches one of those tested as
1584 condition to clear the mouse face.
1586 2011-10-28 Chong Yidong <cyd@gnu.org>
1588 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1590 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1592 * window.c (make_window): Initialize phys_cursor_on_p.
1594 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1596 * lisp.h (struct Lisp_Symbol): Update comments.
1598 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1600 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1602 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1604 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1605 <oslsachem@gmail.com> for helping to debug this.
1607 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1608 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1609 (g_b_init_get_glyph_outline_w): New static variables.
1610 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1611 (GetGlyphOutlineW_Proc): New typedefs.
1612 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1613 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1615 (w32font_open_internal, compute_metrics):
1616 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1617 instead of calling the "wide" APIs directly.
1619 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1621 * w32.h (syms_of_w32font): Add prototype.
1623 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1625 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1626 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1627 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1628 (Fmove_to_window_line): Doc fix.
1630 2011-10-27 Chong Yidong <cyd@gnu.org>
1632 * process.c (make_process): Set gnutls_state to NULL.
1634 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1635 non-NULL, regardless of GNUTLS_INITSTAGE.
1636 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1637 an error. Set process slots as soon as we allocate them.
1639 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1641 2011-10-27 Chong Yidong <cyd@gnu.org>
1643 * gnutls.c (emacs_gnutls_deinit): New function.
1644 Deallocate credentials structures as well as calling gnutls_deinit.
1645 (Fgnutls_deinit, Fgnutls_boot): Use it.
1647 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1648 (deactivate_process): Call emacs_gnutls_deinit.
1650 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1652 * image.c (x_create_x_image_and_pixmap):
1653 * w32.c (sys_rename, w32_delayed_load):
1654 * w32font.c (fill_in_logfont):
1655 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1657 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1659 * w32fns.c (w32_default_color_map): New function,
1660 extracted from Fw32_default_color_map.
1661 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1663 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1665 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1667 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1669 * keyboard.c (test_undefined): New function (bug#9751).
1670 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1672 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1674 * sysdep.c (init_sys_modes): Fix the check for the controlling
1675 terminal (Bug#6649).
1677 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1679 * dispextern.h (struct bidi_it): New member next_en_type.
1681 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1682 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1683 current character, check also for next_en_type being WEAK_EN.
1684 (bidi_resolve_weak): Don't enter the expensive loop if the current
1685 position is before next_en_pos. Record the bidi type of the first
1686 non-ET, non-BN character we find, in addition to its position.
1687 (bidi_level_of_next_char): Invalidate next_en_type when
1688 next_en_pos is over-stepped.
1690 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1692 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1693 * editfns.c: Rewrite current-time-zone so that it invokes
1694 the equivalent of (format-time-string "%Z") to get the time zone name.
1695 This fixes a bug when the time zone name contains characters that
1696 need converting from the system time locale to Emacs internal format.
1697 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1698 that patch fixed format-time-string to do the conversion, but
1699 I forgot to fix current-time-zone.
1700 (format_time_string): New function, containing most of
1701 what Fformat_time_string used to contain.
1702 (Fformat_time_string): Rewrite in terms of format_time_string.
1703 This doesn't change this function's behavior.
1704 (current-time-zone): Rewrite to use format_time_string.
1705 This fixes the bug reported by Michael Schierl in
1706 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1707 Jason Rumney's 2007-06-07 change worked around this bug, but
1709 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1711 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1713 * xdisp.c (start_display): If the character at POS is displayed
1714 via a display vector, reset IT->current.dpvec_index to zero.
1715 (try_window_reusing_current_matrix): If a line ends in a display
1716 vector or the next line starts in a display vector, continue
1717 redrawing the window even though the character position of
1718 start_row was reached.
1721 2011-10-18 Chong Yidong <cyd@gnu.org>
1723 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1724 with nobreak-char-display too.
1726 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1728 Fix part 3 of bug#9771.
1729 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1730 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1731 non-neutral characters if the current character is a paragraph
1732 separator (a.k.a. Newline). This avoids running the same
1733 expensive loop twice, once when we consume the preceding newline
1734 and the other time when the line actually needs to be displayed.
1735 Avoid the loop when we see neutrals on the base embedding level
1736 following a character whose directionality is the same as the
1737 paragraph's. This avoids running the expensive loop when a line
1738 ends in a long sequence of neutrals, like control characters.
1739 Add assertion against STRONG_AL type. Slightly rearrange code
1740 that determines the type of a neutral given the first non-neutral
1742 (bidi_level_of_next_char): Set next_en_pos to zero when
1743 invalidating its info.
1745 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1747 * xdisp.c (push_display_prop): Determine whether to record string
1748 or buffer position by IT->string, not by IT->method. Allow
1749 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1750 (move_it_vertically_backward): Don't look for character position
1751 immediately after the newline when in a continuation line.
1754 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1756 * window.c (coordinates_in_window): Rewrite and delabelize
1757 vertical border check. (Bug#5357) (Bug#9618)
1759 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1761 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1762 errors in XSetWindowBorder (bug#9310).
1764 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1766 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1767 avoid crash when xmalloc overrun checking is enabled.
1769 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1771 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1772 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1773 cursor motion with <left> and <right> arrow keys.
1775 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1776 some callers set that themselves.
1778 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1780 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1781 display string and the previous row comes from the same string and
1782 is empty. (Bug#9739) (Bug#9738)
1784 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1786 * doc.c (get_doc_string): Encode file name (bug#9735).
1788 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1790 * bidi.c (bidi_level_of_next_char):
1791 * xdisp.c (get_visually_first_element): Remove old incorrect
1792 comments regarding the Unicode Line Separator character.
1794 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1796 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1798 * alloc.c (Fgc_status): Do not access beyond zombies array
1799 boundary if nzombies > MAX_ZOMBIES.
1800 * alloc.c (dump_zombies): Add missing format specifier.
1802 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1804 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1805 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1807 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1808 Some packages use them to denote characters with modifiers.
1810 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1812 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1813 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1814 matching a pp-number. Rename parameter var to var1.
1816 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1818 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1820 2011-10-08 Glenn Morris <rgm@gnu.org>
1822 * callint.c (Fcall_interactively): Give a more explicit error for the
1823 'c' case with a non-character input. (Bug#8479)
1825 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1827 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1829 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1830 lines that are hscrolled on the left.
1832 * dispnew.c (buffer_posn_from_coords): Account for a possible
1833 presence of header-line. (Bug#4426)
1835 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1837 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1838 Don't advertise functionality which we discourage or doesn't work.
1840 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1842 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1843 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1844 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1845 this makes Emacs dump core during garbage collection on rare
1846 occasions. sizeof is obviously inferior to offsetof here, so
1847 stick with offsetof.
1848 (GC_POINTER_ALIGNMENT): New macro.
1849 (mark_memory): Omit 3rd (offset) arg; caller changed.
1850 Don't assume EMACS_INT alignment is the same as pointer alignment.
1852 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1854 * keyboard.c (read_key_sequence_remapped): New var.
1855 (read_key_sequence): Compute remapping in the right buffer.
1856 (command_loop_1): Use read_key_sequence's remapping directly.
1858 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1860 * dired.c (file_name_completion): Don't expand file name.
1861 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1862 before checking file name handler.
1864 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1865 they've been requested explicitly (bug#9591).
1867 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1869 * keymap.c (Fsingle_key_description): Use make_specified_string
1870 instead of build_string to build string from push_key_description.
1873 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1875 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1876 This fixes a Y2038 bug on 64-bit hosts.
1877 * buffer.c (reset_buffer):
1878 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1879 (Fclear_buffer_auto_save_failure):
1880 Use 0, not -1, to represent an unset failure time, since time_t
1881 might not be signed.
1883 Remove dependency on glibc malloc internals.
1884 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1885 Move back here from lisp.h, but with their new implementations.
1886 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1887 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1888 * charset.c (charset_table_init): New static var.
1889 (syms_of_charset): Use it instead of xmalloc. This removes a
1890 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1891 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1892 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1893 Move back to alloc.c.
1894 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1895 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1897 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1899 * nsterm.m (windowDidResize): Call x_set_window_size only when
1900 ns_in_resize is true. Otherwise set pixelwidth/height and
1901 call change_frame_size (Bug#9628).
1903 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1905 Port --enable-checking=all to Fedora 14 x86-64.
1906 * charset.c (syms_of_charset): Also account for glibc malloc's
1907 internal overhead when calculating the initial malloc maximum.
1909 Port --enable-checking=all to Fedora 14 x86.
1910 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1912 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1913 (overrun_check_realloc, overrun_check_free):
1914 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1915 That way, xmalloc returns a properly-aligned pointer even if
1916 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1917 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1918 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1919 into account when calculating the initial malloc maximum.
1920 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1921 Move here from alloc.c, so that charset.c can use it too.
1922 Properly align; the old code wasn't right for common 32-bit hosts
1923 when configured with --enable-checking=all.
1924 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1925 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1927 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1929 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1932 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1934 * xdisp.c (compute_display_string_end): If there's no display
1935 string at CHARPOS, return -1.
1937 * bidi.c (bidi_fetch_char): When compute_display_string_end
1938 returns a negative value, treat the character as a normal
1939 character not covered by a display string. (Bug#9624)
1941 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1943 * lread.c (Fread_from_string): Fix typo in docstring.
1945 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1947 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1948 newline, reseat the iterator instead of bidi-iterating there one
1949 character at a time. (Bug#9610)
1950 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1951 TO_CHARPOS if the bidi iterator is at base embedding level.
1953 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1955 * lread.c (readevalloop): Use correct code for NBSP.
1956 (read1): Likewise. (Bug#9608)
1958 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1960 * dbusbind.c (Fdbus_register_signal): When service is not
1961 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1963 2011-09-25 Glenn Morris <rgm@gnu.org>
1965 * buffer.c (truncate-lines): Doc fix.
1967 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1969 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1970 (Fset_window_next_buffers): Doc fix.
1972 2011-09-24 Glenn Morris <rgm@gnu.org>
1974 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1976 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1978 Fix minor problems found by static checking.
1979 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1980 * indent.c (Fvertical_motion): Fix == vs = typo.
1982 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1984 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1985 Default value is now t. Doc fix.
1987 * indent.c (Fvertical_motion): Compute and apply the overshoot
1988 logic when moving up, not only when moving down. Fix the
1989 confusing name and values of the it_overshoot_expected variable;
1990 logic changes accordingly. (Bug#9254) (Bug#9549)
1992 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1993 CHARPOS is covered by a display string which includes newlines.
1994 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1995 is covered by a display string with embedded newlines.
1997 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1999 * dbusbind.c (Fdbus_register_signal): Add match rule to
2000 Vdbus_registered_objects_table. (Bug#9581)
2001 (Fdbus_register_method, Vdbus_registered_objects_table):
2004 2011-09-24 Jim Meyering <meyering@redhat.com>
2006 do not ignore write error for any output size
2007 The previous change was incomplete.
2008 While it makes emacs --batch detect the vast majority of stdout
2009 write failures, errors were still ignored whenever the output size is
2010 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2011 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2012 && echo FAIL: ignored write error
2013 FAIL: ignored write error
2014 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2015 && echo FAIL: ignored write error
2016 FAIL: ignored write error
2017 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2019 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2021 * emacs.c (Fkill_emacs): In noninteractive mode exit
2022 non-successfully if a write error occurred on stdout. (Bug#9574)
2024 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2026 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2029 * dispextern.h (struct it): Update the comment documenting what
2032 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2034 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2035 a display string, extend search for cursor position to end of row.
2036 (find_row_edges): If the row ends in a newline from a display
2037 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2038 Handle the case of a display string with multiple newlines.
2039 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2040 non-empty line. Fixes confusing cursor motion with arrow keys at
2041 the beginning of a line that starts with whitespace.
2043 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2045 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2048 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2050 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2053 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2055 * xdisp.c (display_line): Record maximum and minimum buffer
2056 positions even if no glyphs were produced (e.g., by a zero-width
2057 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2058 buffer positions that will be removed from the glyph row because
2060 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2061 column is beyond frame width: don't subtract 1 "pixel" when
2062 computing width of the stretch.
2063 (reseat_at_next_visible_line_start): Undo the change made on
2064 2011-09-17 that saved paragraph information and restored it after
2065 the call to `reseat'. (Bug#9545)
2067 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2069 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2070 and turn window cursor on if cleared (Bug#9415).
2072 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2074 * search.c (boyer_moore): Take unibyte characters from pattern
2075 literally. (Bug#9458)
2077 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2079 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2081 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2083 Fix minor problem found by static checking.
2084 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2085 initialized, to pacify gcc -Wuninitialized.
2087 * fileio.c: Report proper errno when syscall falls.
2088 (Finsert_file_contents): Save and restore errno,
2089 so that report_file_error outputs the correct diagnostic.
2090 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2092 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2094 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2096 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2098 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2099 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2101 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2103 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2104 about the current paragraph and restore it after the call to reseat.
2106 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2107 (bidi_find_paragraph_start): Search back for paragraph beginning
2108 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2109 (bidi_move_to_visually_next): Only trigger paragraph-related
2110 computations when the last character is a newline or at EOB, not
2111 just any NEUTRAL_B. (Bug#9470)
2113 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2114 truncated lines if point is covered by a display string. (Bug#9524)
2116 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2118 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2119 (cons_to_x_long): New function.
2120 (lisp_data_to_selection_data): Use it. Correct the test for
2121 short-versus-long data; it was negated. Break out of vector
2122 loop, for efficiency, when a long datum is discovered.
2124 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2126 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2128 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2130 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2131 GCC PR/17406) by declaring this function with external scope.
2133 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2135 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2136 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2138 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2140 * editfns.c (Fformat): Correctly handle text properties on "%%".
2142 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2144 * xterm.c (x_draw_composite_glyph_string_foreground):
2145 * w32term.c (x_draw_composite_glyph_string_foreground):
2146 * term.c (encode_terminal_code):
2147 * composite.c (composition_update_it, get_composition_id):
2148 * xdisp.c (get_next_display_element)
2149 (fill_composite_glyph_string): Add comments about special meaning
2150 of TAB characters in a composition.
2152 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2154 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2155 This occurs when processing a multibyte format.
2156 Problem reported by Wolfgang Jenker.
2158 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2160 * xdisp.c (try_cursor_movement): Only check for exact match if
2161 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2163 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2165 Remove unused external symbols.
2166 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2167 * xdisp.c (calc_pixel_width_or_height): Now static.
2168 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2169 * indent.c (check_display_width):
2170 * w32term.c: Fix comment to match code.
2171 * xterm.c, xterm.h (x_catching_errors): Remove.
2173 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2175 * xselect.c: Use signed conversions more consistently (Bug#9498).
2176 (selection_data_to_lisp_data): Assume incoming selection data are
2177 signed integers, not unsigned. This is to be consistent with
2178 outgoing selection data, which was modified to use signed integers
2179 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2180 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2181 expects long, not unsigned long.
2183 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2185 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2186 computation of loop end. Reported by Johan Bockgård
2189 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2191 * frame.c (Fother_visible_frames_p): Function deleted.
2193 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2195 * indent.c (compute_motion): Process display vector front to back
2196 rather than the other way around. (Bug#2496)
2198 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2200 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2202 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2204 * minibuf.c (Fread_from_minibuffer): Doc fix.
2206 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2208 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2209 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2211 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2213 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2214 value for non-existent files.
2216 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2218 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2219 set its "size" to -1. This will set the modtime_size field of
2220 the corresponding buffer to -1, which is what
2221 verify-visited-file-modtime expects for files that do not exist.
2224 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2226 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2228 * lisp.h: ... from here. push_key_description is no longer
2229 defined in keyboard.c, so its declaration should not be in
2230 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2231 logically belongs with push_key_description.
2233 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2235 * buffer.h: Include <sys/types.h> instead of <time.h>.
2236 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2237 Problem reported by Herbert J. Skuhra.
2239 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2241 * xml.c (parse_region): Make the parsing work for
2242 non-comment-starting XML files again (bug#9144).
2244 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2246 * image.c (gif_load): Fix calculation of bottom and right corner.
2249 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2251 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2252 redisplay in small windows.
2254 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2256 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2258 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2260 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2261 Operate on live windows only.
2263 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2265 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2267 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2269 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2270 only under bidi iteration.
2272 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2274 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2276 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2278 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2279 Without this fix, the command to link temacs failed due to an
2280 undefined symbol __builtin_isnan. This is because
2281 /usr/include/iso/math_c99.h #defines isnan(x) to
2282 __builtin_isnan(x), but the bundled gcc, which identifies itself
2283 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2285 * floatfns.c (isnan): #undef, and then #define to a clone of
2287 (Fisnan): Always define, since it's always available now.
2288 (syms_of_floatfns): Always define isnan at the Lisp level.
2290 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2292 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2294 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2296 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2297 The previous code assumed that file offsets (off_t values) fit in
2298 EMACS_INT variables, which is not true on typical 32-bit hosts.
2299 The code messed up by falsely reporting buffer overflow in cases
2300 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2301 when "big" contains more than 2**29 bytes, even though this
2302 inserts just one byte and does not overflow the buffer.
2303 (Finsert_file_contents): Store file offsets as off_t
2304 values, not as EMACS_INT values. Check for overflow when
2305 converting between EMACS_INT and off_t. When checking for
2306 buffer overflow or for overlap, take the offsets into account.
2307 Don't use EMACS_INT for small values where int suffices.
2308 When checking for overlap, fix a typo: ZV was used where
2309 ZV_BYTE was intended.
2310 (Fwrite_region): Don't assume off_t fits into 'long'.
2311 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2313 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2315 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2317 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2319 sprintf-related integer and memory overflow issues (Bug#9412).
2321 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2322 (esprintf, exprintf, evxprintf): New functions.
2323 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2324 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2325 (modify_event_symbol): Do not assume that the length of
2326 name_alist_or_stem is safe to alloca and fits in int.
2327 (Fexecute_extended_command): Likewise for function name and binding.
2328 (Frecursion_depth): Wrap around reliably on integer overflow.
2329 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2330 since some callers pass EMACS_INT values.
2331 (Fsingle_key_description): Don't crash if symbol name contains more
2332 than MAX_ALLOCA bytes.
2333 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2334 (get_minibuffer): Arg is now EMACS_INT, not int.
2335 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2336 (esprintf, exprintf, evxprintf): New decls.
2337 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2339 * dbusbind.c (signature_cat): New function.
2340 (xd_signature, Fdbus_register_signal):
2341 Do not overrun buffer; instead, report string overflow.
2343 * dispnew.c (add_window_display_history): Don't overrun buffer.
2344 Truncate instead; this is OK since it's just a log.
2346 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2347 even if the time zone offset is outlandishly large.
2348 Don't mishandle offset == INT_MIN.
2350 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2351 when creating daemon; the previous buffer-overflow check was incorrect.
2353 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2354 which has the guts of the old verror function.
2356 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2357 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2359 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2360 (font_unparse_xlfd): Don't blindly alloca long strings.
2361 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2362 fits in int, when using sprintf. Use single snprintf to count
2363 length of string rather than counting it via multiple sprintfs;
2364 that's simpler and more reliable.
2365 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2366 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2367 sprintf, in case result does not fit in int.
2369 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2370 (fontset_from_font): Print it.
2372 * frame.c (tty_frame_count): Now printmax_t, not int.
2373 (make_terminal_frame, set_term_frame_name): Print it.
2374 (x_report_frame_params): In X, window IDs are unsigned long,
2375 not signed long, so print them as unsigned.
2376 (validate_x_resource_name): Check for implausibly long names,
2377 and don't assume name length fits in 'int'.
2378 (x_get_resource_string): Don't blindly alloca invocation name;
2379 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2382 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2383 (xg_check_special_colors, xg_set_geometry):
2384 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2386 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2387 Use esprintf, not sprintf, in case result does not fit in int.
2389 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2390 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2391 it as a large positive number.
2392 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2393 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2395 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2396 in case result does not fit in int.
2398 * print.c (float_to_string): Detect width overflow more reliably.
2399 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2400 buffer overrun. Don't assume list length fits in 'int'. Treat
2401 print length of 0 as 0, not as infinity; to be consistent with other
2402 uses of print length in this function. Don't overflow print length
2403 index. Don't assume hash table size fits in 'long', or that
2404 vectorlike size fits in 'unsigned long'.
2406 * process.c (make_process): Use printmax_t, not int, to format
2407 process-name gensyms.
2409 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2411 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2412 to avoid potential buffer overrun.
2414 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2415 if X resource line is longer than 512 bytes.
2417 * xfns.c (x_window): Make sprintf buffer a bit bigger
2418 to avoid potential buffer overrun.
2420 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2422 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2424 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2426 Integer overflow fixes for scrolling, etc.
2427 Without these, Emacs silently mishandles large integers sometimes.
2428 For example, "C-u 4294967297 M-x recenter" was treated as if
2429 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2431 * xdisp.c (try_window_id): Check Emacs fixnum range before
2432 converting to 'int'.
2434 * window.c (window_scroll_line_based, Frecenter):
2435 Check that an Emacs fixnum is in range before assigning it to 'int'.
2436 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2437 values converted from Emacs fixnums.
2438 (Frecenter): Don't wrap around a line count if it is out of 'int'
2439 range; instead, treat it as an extreme value.
2440 (Fset_window_configuration, compare_window_configurations):
2441 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2443 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2444 that can exceed INT_MAX. Check that EMACS_INT value is in range
2445 before assigning it to the (possibly-narrower) index.
2446 (match_limit): Don't assume that a fixnum can fit in 'int'.
2448 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2451 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2452 (Fvertical_motion): Don't wrap around LINES values that don't fit
2453 in 'int'. Instead, treat them as extreme values. This is good
2454 enough for windows, which can't have more than INT_MAX lines anyway.
2456 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2458 * Require libxml/parser.h to avoid compilation warning.
2460 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2462 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2463 since this reportedly can destroy thread storage.
2465 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2467 * syntax.c (find_defun_start): Update all cache variables if
2468 exiting early (Bug#9401).
2470 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2472 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2474 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2475 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2476 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2478 * term.c (tty_append_glyph): New function.
2479 (produce_stretch_glyph): Static function and its prototype deleted.
2481 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2484 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2486 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2487 when checking :margin (Bug#9390).
2488 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2489 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2490 so that the name doesn't mislead. All uses changed.
2492 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2494 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2497 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2499 * xdisp.c (move_it_to): Don't bail out early when reaching
2500 position beyond to_charpos, if we are scanning backwards.
2501 (move_it_vertically_backward): When DY == 0, make sure we get to
2502 the first character in the line after the newline.
2504 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2506 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2507 (ccl_driver): Do not generate an out-of-range pointer.
2508 (Fccl_execute_on_string): Remove unnecessary check for
2509 integer overflow, noted by Stefan Monnier in
2510 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2511 Remove a FIXME that didn't need fixing.
2512 Simplify the newly-introduced buffer reallocation code.
2514 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2516 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2518 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2520 Integer and memory overflow issues (Bug#9196).
2522 * doc.c (get_doc_string): Rework so that
2523 get_doc_string_buffer_size is the actual buffer size, rather than
2524 being 1 less than the actual buffer size; this makes xpalloc more
2527 * image.c (x_allocate_bitmap_record, cache_image):
2528 * xselect.c (Fx_register_dnd_atom):
2529 Simplify previous changes by using xpalloc.
2531 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2532 since either will do and ptrdiff_t is convenient with xpalloc.
2534 * charset.c (charset_table_size)
2535 (struct charset_sort_data.priority): Now ptrdiff_t.
2536 (charset_compare): Don't overflow if priorities differ greatly.
2537 (Fsort_charsets): Don't assume list length fits in int.
2538 Check for size-calculation overflow when allocating sort data.
2539 (syms_of_charset): Allocate an initial charset table that is
2540 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2542 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2544 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2545 The actual value is always <= INT_MAX, and leaving it unsigned made
2546 overflow checking harder.
2548 * dispextern.h (struct glyph_matrix.rows_allocated)
2549 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2550 with xpalloc. The values are still always <= INT_MAX.
2552 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2554 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2555 (SAFE_NALLOCA): New macro.
2557 * region-cache.c (struct boundary.pos, find_cache_boundary)
2558 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2559 (set_cache_region, invalidate_region_cache)
2560 (revalidate_region_cache, know_region_cache, region_cache_forward)
2561 (region_cache_backward, pp_cache):
2562 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2563 so that ptrdiff_t * can be passed to xpalloc.
2564 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2565 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2566 (pp_cache): Don't assume cache_len fits in int.
2567 * region-cache.h: Adjust extern decls to match.
2569 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2570 EMACS_INT, since either will do, for xpalloc.
2572 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2573 (xnmalloc, xnrealloc, xpalloc): New functions.
2575 * bidi.c (bidi_shelve_header_size): New constant.
2576 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2577 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2579 * bidi.c (bidi_cache_shrink):
2580 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2582 Don't update size of array until after memory allocation succeeds,
2583 because xmalloc/xrealloc may not return.
2584 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2585 now that we have proper integer overflow checking.
2586 (record_overlay_string, overlay_strings): Catch overflows when
2587 calculating size of overlay_str_buf.
2589 * callproc.c (Fcall_process): Check for size overflow when
2590 calculating size of args2.
2591 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2592 Normally we prefer signed values, but sticking with ptrdiff_t would
2593 require adding more-complicated checks.
2595 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2596 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2597 Redo buffer-overflow calculations to avoid integer overflow.
2598 Add a FIXME comment where memory seems to be over-allocated.
2600 * character.c (Fstring): Check for size-calculation overflow.
2602 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2603 unnecessary integer overflow. Check for size overflow.
2604 (encode_coding_object): Don't update size until xmalloc succeeds.
2606 * composite.c (get_composition_id): Check for overflow in glyph
2607 length calculations.
2609 Integer and memory overflow fixes for display code.
2610 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2611 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2612 (scrolling_window): Check for overflow in size calculations.
2613 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2614 Don't assume glyph table len fits in int.
2615 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2616 (row_table_size): Now ptrdiff_t, not int.
2617 (scrolling_window): Avoid overflow in size calculations.
2618 Don't update size until allocation succeeds.
2619 * fns.c (concat): Check for overflow in size calculations.
2620 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2621 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2622 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2624 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2625 (get_doc_string): Check for size calculation overflow.
2626 Don't update size until allocation succeeds.
2627 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2628 EMACS_INT, where ptrdiff_t will do.
2629 (Fsubstitute_command_keys): Check for string overflow.
2631 * editfns.c (set_time_zone_rule): Don't assume environment length
2633 (message_length): Now ptrdiff_t, not int.
2634 (Fmessage_box): Don't update size until allocation succeeds.
2635 Don't assume message length fits in int.
2636 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2638 * emacs.c (main): Do not reallocate argv, since there is a null at
2639 the end that can be overwritten, and this way there's no need to
2640 worry about size-calculation overflow.
2641 (sort_args): Check for size-calculation overflow.
2643 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2645 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2647 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2648 (x_set_scroll_bar_width, x_figure_window_size):
2649 Check for integer overflow.
2650 (x_set_alpha): Do not assume XINT fits in int.
2652 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2653 This is for the members text_lines, text_cols, total_lines, total_cols,
2654 where the system imposes an 'int' limit.
2656 * fringe.c (Fdefine_fringe_bitmap):
2657 Don't update size until alloc works.
2659 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2660 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2662 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2663 Check for size-calculation overflow.
2664 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2665 do, as we prefer signed integers.
2666 (id_to_widget.max_size, id_to_widget.used)
2667 (xg_store_widget_in_map, xg_remove_widget_from_map)
2668 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2669 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2670 Use and return ptrdiff_t, not int.
2671 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2672 * gtkutil.h: Change prototypes to match the above.
2674 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2675 are duplicate now that they've been promoted to lisp.h.
2676 (x_allocate_bitmap_record, x_alloc_image_color)
2677 (make_image_cache, cache_image, xpm_load):
2678 Don't update size until alloc is done.
2679 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2681 Check for size calculation overflow.
2682 (ct_colors_allocated_max): New constant.
2683 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2686 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2687 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2688 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2689 Use ptrdiff_t, not int, to count maps.
2690 (read_char_minibuf_menu_prompt): Check for overflow in size
2691 calculations. Don't update size until allocation succeeds.
2692 Redo calculations to avoid overflow.
2693 * keyboard.h: Change prototypes to match the above.
2695 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2697 (current_minor_maps): Check for size calculation overflow.
2698 * keymap.h: Change prototypes to match the above.
2700 * lread.c (read1, init_obarray): Don't update size until alloc done.
2702 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2703 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2705 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2706 Now ptrdiff_t, not int.
2707 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2708 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2710 * process.c (Fnetwork_interface_list): Check for overflow
2711 in size calculation.
2713 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2715 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2716 overflow. Don't bother calling xmalloc when xrealloc will do.
2718 * search.c (Freplace_match): Check for size calculation overflow.
2719 (Fset_match_data): Don't assume list lengths fit in 'int'.
2721 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2722 for command line length. Do not attempt to address one before the
2723 beginning of an array, as that's not portable.
2725 * term.c (max_frame_lines): Remove; unused.
2726 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2728 (encode_terminal_code, calculate_costs): Check for size
2729 calculation overflow.
2730 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2731 table lengths and related sizes. Don't update size until alloc
2732 done. Redo calculations to avoid overflow.
2733 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2735 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2736 subtracting pointers.
2737 (gobble_line): Check for overflow more carefully. Don't update size
2740 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2741 Don't update size until alloc done.
2742 Redo size calculations to avoid overflow.
2743 Check for size calculation overflow.
2744 (main) [DEBUG]: Fix typo in invoking tparam1.
2746 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2747 Use ptrdiff_t, not int, for sizes.
2748 (store_mode_line_noprop_char): Don't update size until alloc done.
2750 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2751 Use ptrdiff_t, not int, for sizes.
2752 (Finternal_make_lisp_face, cache_face):
2753 Check for size calculation overflow.
2754 (cache_face): Treat size calculation overflows as if they were
2755 memory exhaustion (the usual treatment), rather than aborting.
2757 * xfns.c (x_encode_text, x_set_name_internal)
2758 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2759 sizes, since they can exceed INT_MAX in size. Check for size
2760 calculation overflow.
2762 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2763 (xg_select): Check for size calculation overflow.
2764 Don't update size until alloc done.
2766 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2767 as sprintf is limited to int lengths.
2769 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2770 (X_LONG_MIN): New macros.
2771 Use them to make the following changes clearer.
2772 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2773 This change doesn't affect the value now, but it may help remind
2774 future maintainers not to raise the value too much later.
2775 (SELECTION_QUANTUM): Remove, replacing with ...
2776 (selection_quantum): ... new function, which avoids overflow.
2778 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2779 assumption that selection length fits in 'int'.
2780 (x_reply_selection_request, x_handle_selection_request)
2781 (x_get_window_property, receive_incremental_selection)
2782 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2783 (lisp_data_to_selection_data, clean_local_selection_data):
2784 Use ptrdiff_t, not int, to record length of selection.
2785 (x_reply_selection_request, x_get_window_property)
2786 (receive_incremental_selection, x_property_data_to_lisp):
2787 Redo calculations to avoid overflow.
2788 (x_reply_selection_request): When sending hint, ceiling it at
2789 X_LONG_MAX rather than relying on wraparound overflow to send
2791 (x_get_window_property, receive_incremental_selection)
2792 (lisp_data_to_selection_data, x_property_data_to_lisp):
2793 Check for size-calculation overflow.
2794 (x_get_window_property, receive_incremental_selection)
2795 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2796 Don't store size until memory allocation succeeds.
2797 (x_get_window_property): Plug memory leak on memory exhaustion.
2798 Don't double-block input; malloc is safe here. Don't assume 2**34
2799 - 4 fits in unsigned long. Add an xassert to check
2800 XGetWindowProperty overflow. Be more careful about overflow
2801 calculations, and distinguish size from memory overflow better.
2802 (receive_incremental_selection): When tracing, don't assume
2803 unsigned int is less than INT_MAX.
2804 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2805 harmful) conversions of unsigned short to int.
2806 (lisp_data_to_selection_data): Don't assume that integers
2807 in the range -65535 through -1 fit in an X unsigned short.
2808 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2809 result parameters unless successful. Rely on cons_to_unsigned
2810 to report problems with elements; the old code wasn't right anyway.
2811 (x_check_property_data): Check for int overflow; we cannot use
2812 a wider type due to X limits.
2813 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2815 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2817 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2818 (x_term_init): Check for size calculation overflow.
2819 (x_color_cells): Don't store size until memory allocation succeeds.
2820 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2821 Don't assume alloca size is less than MAX_ALLOCA.
2822 (x_term_init): Don't assume length fits in int (sprintf is limited
2825 Use ptrdiff_t for composition IDs.
2826 * character.c (lisp_string_width):
2827 * composite.c (composition_table_size, n_compositions)
2828 (get_composition_id, composition_gstring_from_id):
2829 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2830 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2831 * window.c (Frecenter):
2832 Use ptrdiff_t, not int, for composition IDs.
2833 * composite.c (get_composition_id): Check for integer overflow.
2834 * composite.h: Adjust prototypes to match the above changes.
2836 Use ptrdiff_t for hash table indexes.
2837 * category.c (hash_get_category_set):
2838 * ccl.c (ccl_driver):
2839 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2840 * coding.c (coding_system_charset_list, detect_coding_system):
2841 * coding.h (struct coding_system.id):
2842 * composite.c (get_composition_id, gstring_lookup_cache):
2843 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2844 * image.c (xpm_get_color_table_h):
2845 * lisp.h (hash_lookup, hash_put):
2846 * minibuf.c (Ftest_completion):
2847 Use ptrdiff_t for hash table indexes, not int (which is too
2848 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2849 32-bit --with-wide-int hosts).
2851 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2852 Add a FIXME comment about memory leaks.
2853 (syms_of_charset): Don't assume xmalloc returns.
2855 Don't assume that stated character widths fit in int.
2856 * character.c (Fchar_width, c_string_width, lisp_string_width):
2857 * character.h (CHAR_WIDTH):
2858 * indent.c (MULTIBYTE_BYTES_WIDTH):
2859 Use sanitize_char_width to avoid undefined and/or bad behavior
2860 with outlandish widths.
2861 * character.h (sanitize_tab_width): Rename from sanitize_width,
2862 now that we have two such functions. All uses changed.
2863 (sanitize_char_width): New inline function.
2865 Don't assume that tab-width fits in int.
2866 * character.h (sanitize_width): New inline function.
2867 (SANE_TAB_WIDTH): New macro.
2868 (ASCII_CHAR_WIDTH): Use it.
2869 * indent.c (sane_tab_width): Remove. All uses replaced by
2870 SANE_TAB_WIDTH (current_buffer).
2871 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2873 * fileio.c: Integer overflow issues with file modes.
2874 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2876 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2877 Remove unreachable code.
2878 (read_hex, load_charset_map_from_file): Check for integer overflow.
2880 * xterm.c: Don't go over XClientMessageEvent limit.
2881 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2882 (x_send_scroll_bar_event): Likewise. Check that the size does not
2883 exceed limits imposed by XClientMessageEvent, as well as the usual
2884 ptrdiff_t and size_t limits.
2886 * keyboard.c: Overflow, signedness and related fixes.
2887 (make_lispy_movement): Use same integer type in forward decl
2888 that is used in the definition.
2889 (read_key_sequence, keyremap_step):
2890 Change bufsize argument back to int, undoing my 2011-03-30 change.
2891 We prefer signed types, and int is wide enough here.
2892 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2893 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2894 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2895 length, not size_t. Use ptrdiff_t for index, not int.
2896 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2897 possibility of integer overflow.
2899 Overflow, signedness and related fixes for images.
2901 * dispextern.h (struct it.stack[0].u.image.image_id)
2902 (struct_it.image_id, struct image.id, struct image_cache.size)
2903 (struct image_cache.used, struct image_cache.ref_count):
2904 * gtkutil.c (update_frame_tool_bar):
2905 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2906 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2907 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2908 * nsmenu.m (update_frame_tool_bar):
2909 * xdisp.c (calc_pixel_width_or_height):
2910 * xfns.c (image_cache_refcount):
2911 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2912 on typical 64-bit hosts.
2914 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2915 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2916 Omit unnecessary casts to int.
2917 (parse_image_spec): Check that integers fall into 'int' range
2918 when the callers expect that.
2919 (image_ascent): Redo ascent calculation to avoid int overflow.
2920 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2921 (lookup_image): Remove unnecessary tests.
2922 (xbm_image_p): Locals are now of int, not EMACS_INT,
2923 since parse_image_check makes sure they fit into int.
2924 (png_load, gif_load, svg_load_image):
2925 Prefer int to unsigned where either will do.
2926 (tiff_handler): New function, combining the cores of the
2927 old tiff_error_handler and tiff_warning_handler.
2928 This function is rewritten to use vsnprintf and thereby avoid
2929 stack buffer overflows. It uses only the features of vsnprintf
2930 that are common to both POSIX and native Microsoft.
2931 (tiff_error_handler, tiff_warning_handler): Use it.
2932 (tiff_load, gif_load, imagemagick_load_image):
2933 Don't assume :index value fits in 'int'.
2934 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2935 (imagemagick_load_image): Check that crop parameters fit into
2936 the integer types that MagickCropImage accepts. Don't assume
2937 Vimagemagick_render_type has a nonnegative value. Don't assume
2938 size_t fits in 'long'.
2939 (gs_load): Use printmax_t to print the widest integers possible.
2940 Check for integer overflow when computing image height and width.
2942 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2944 * xdisp.c (redisplay_window): Don't force window start if point
2945 will be invisible in the resulting window. (Bug#9324)
2947 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2949 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2950 the display spec is of the form `(space ...)'.
2951 (handle_display_spec): Return the value returned by
2952 handle_single_display_spec, not just 1 or zero.
2953 (handle_single_display_spec): If the display spec is of the form
2954 `(space ...)', and specifies display in the text area, return 2
2956 (try_cursor_movement): Check for the need to scroll more
2957 accurately, and prefer exact match for point under bidi.
2958 Don't advance `row' beyond the last row of the window.
2960 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2961 into disp_prop; all users changed.
2963 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2964 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2965 for the text covered by the display property.
2967 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2969 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2970 Change return value to nil.
2971 (Frecord_buffer): Delete unused function.
2973 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2975 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2976 buffers, return left-to-right.
2977 (set_cursor_from_row): Consider candidate row a win if its glyph
2978 represents a newline and point is on that newline. Fixes cursor
2979 positioning on the newline at EOL of R2L text within L2R
2980 paragraph, and vice versa.
2981 (try_cursor_movement): Check continued rows, in addition to
2982 continuation rows. Fixes unwarranted scroll when point enters a
2983 continued line of R2L text within an L2R paragraph, or vice versa.
2984 (cursor_row_p): Consider the case of point being equal to
2985 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2986 from the end of a short line to the beginning of a continued line
2987 of R2L text within L2R paragraph.
2988 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2989 composed characters.
2991 * bidi.c (bidi_check_type): Use xassert.
2992 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2995 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2997 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3000 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3002 * nsfont.m (ns_otf_to_script): Fix typo.
3004 2011-08-22 Kenichi Handa <handa@m17n.org>
3006 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3007 extra slot even if the purpose is char-code-property-table.
3009 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3011 * xdisp.c (redisplay_window): When computing centering_position,
3012 account for the height of the header line. (Bug#8874)
3014 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3015 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3016 candidate is selected by the mouse, and that candidate has a
3017 composed character under the mouse.
3019 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3020 coordinates reported by pos-visible-in-window-p for a composed
3021 character in column zero.
3023 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3025 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3027 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3029 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3030 consider it a hit if to_charpos is anywhere in the range of the
3031 composed buffer positions.
3033 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3035 * image.c (gif_load): Don't assume that each subimage has the same
3036 dimensions as the base image. Handle disposal method that is
3037 "undefined" by the gif spec (Bug#9335).
3039 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3041 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3042 (Fcondition_case): Document `debug' symbol in error handler.
3044 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3046 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3047 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3048 from an Org mode buffer to a Speedbar frame.
3050 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3051 a composition, take its buffer position from IT->cmp_it.charpos.
3052 Fixes cursor positioning at the beginning of a line that begins
3053 with a composed character.
3055 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3057 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3058 character bidirectional type, use STRONG_L instead. Fixes crashes
3059 in a buffer produced by `describe-categories'.
3061 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3062 members before the level stack, so they would be saved and
3063 restored when copying iterator state. Fixes incorrect reordering
3064 around TABs covered by display properties.
3066 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3068 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3070 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3072 * eval.c (internal_condition_case, internal_condition_case_1)
3073 (internal_condition_case_2, internal_condition_case_n):
3074 Remove unnecessary aborts (Bug#9081).
3076 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3078 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3079 has no `load' handler, try opening the file locally. (Bug#9311)
3081 2011-08-16 Ken Brown <kbrown@cornell.edu>
3083 * gmalloc.c: Expand comment.
3085 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3087 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3088 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3090 2011-08-16 Ken Brown <kbrown@cornell.edu>
3092 Fix memory allocation problems in Cygwin build (Bug#9273).
3094 * unexcw.c ( __malloc_initialized): Declare external variable.
3095 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3097 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3099 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3101 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3103 [CYGWIN] (special_realloc): New function.
3104 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3105 requests to realloc storage in the static heap.
3107 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3109 * bidi.c (bidi_initialize): Remove unused local.
3111 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3114 * biditype.h: Remove file.
3115 * makefile.w32-in ($(BLD)/bidi.$(O)):
3116 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3118 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3120 * chartab.c: Improve commentary for the uniprop_table API.
3122 * bidi.c (bidi_paragraph_init): Support zero value of
3123 bidi_ignore_explicit_marks_for_paragraph_level.
3124 (bidi_initialize): Use uniprop_table instead of including
3125 biditype.h and bidimirror.h.
3127 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3128 coordinates of the iterator when restoring from ppos_it.
3131 2011-08-14 Kenichi Handa <handa@m17n.org>
3133 * process.c (create_process): Call setup_process_coding_systems
3134 after the pid of the process is set to -1 (Bug#8162).
3136 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3138 * xdisp.c (move_it_in_display_line_to): Don't invoke
3139 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3140 ppos_it. Fixes vertical cursor motion when line beginning is
3141 covered by an image. (Bug#9296)
3143 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3145 * nsterm.h (ns_run_ascript): Declare.
3146 (NSAPP_DATA2_RUNASSCRIPT): Define.
3148 * nsfns.m (as_script, as_result, as_status): New static variables.
3149 (ns_run_ascript): New function.
3150 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3151 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3152 the event loop. Get status from as_status (Bug#7276).
3154 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3155 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3156 the event loop (Bug#7276).
3158 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3160 * gnutls.c (QCgnutls_bootprop_priority)
3161 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3162 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3163 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3164 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3165 (QCgnutls_bootprop_verify_hostname_error)
3166 (QCgnutls_bootprop_callbacks_verify): Rename from
3167 Qgnutls_bootprop_..., all uses changed.
3169 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3172 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3174 * xfaces.c (Qframe_set_background_mode): Now static.
3175 * dispextern.h (Qframe_set_background_mode): Remove decl.
3177 * process.c (Fnetwork_interface_info): Declare local only if needed.
3179 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3181 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3182 (Fnetwork_interface_list): Allocate in increments of bytes instead
3183 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3184 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3186 (struct ifflag_def): notrailers is smart on OSX.
3187 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3188 Get hardware address with getifaddrs if available.
3190 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3192 * xdisp.c (iterate_out_of_display_property): xassert that
3193 IT->position is set to within IT->object's boundaries. Break from
3194 the loop as soon as EOB is reached; avoids infloops in redisplay
3195 when IT->position is set up wrongly due to some bug.
3196 Set IT->current to match the bidi iterator unconditionally.
3197 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3198 entry. Force push_it to save on the stack the current
3199 buffer/string position, to be restored by pop_it. Fix flags in
3200 the iterator structure wrt the object coming from a display
3201 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3202 properties. (Bug#9284)
3204 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3206 * fontset.c (fontset_get_font_group): Add proper type checks.
3209 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3211 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3212 and LC_VERSION_MIN_MACOSX.
3213 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3214 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3216 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3218 * xdisp.c (forward_to_next_line_start): Allow to use the
3219 no-display-properties-and-no-overlays under bidi display.
3220 Set disp_pos in the bidi iterator to avoid searches for display
3221 properties and overlays.
3223 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3225 * editfns.c (Fset_time_zone_rule): Document relationship with the
3228 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3229 the font entity extracted from the cache (Bug#8109).
3231 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3233 * composite.c (autocmp_chars): Don't reset point. That is done by
3234 restore_point_unwind (Bug#5984).
3236 2011-08-07 Juri Linkov <juri@jurta.org>
3238 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3239 to show the arg `TIME' instead of `TIMEVAL'.
3241 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3243 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3244 display property strides EOL and includes a newline, as in
3245 longlines-mode. (Bug#9254)
3246 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3247 word-wrap under bidirectional display. (Bug#9224)
3249 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3250 is non-zero, even if the data buffer is NULL. Fixes a crash in
3251 vertical-motion with longlines-mode. (Bug#9254)
3253 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3255 * bidi.c <bidi_cache_total_alloc>: Now static.
3256 (bidi_initialize): Initialize bidi_cache_total_alloc.
3258 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3261 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3262 amount allocated this far in `bidi_cache_total_alloc'.
3263 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3264 non-zero, only free the data buffer without restoring the cache
3265 contents. All callers changed.
3267 * dispextern.h (bidi_unshelve_cache): Update prototype.
3269 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3270 (move_it_in_display_line, move_it_to)
3271 (move_it_vertically_backward, move_it_by_lines): Replace the call
3272 to xfree to an equivalent call to bidi_unshelve_cache.
3273 (move_it_in_display_line_to): Fix logic of returning
3274 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3276 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3278 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3279 came from a string character with a `cursor' property. (Bug#9229)
3281 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3283 * Makefile.in (LIB_PTHREAD): New variable.
3284 (LIBES): Add LIB_PTHREAD (Bug#9216).
3286 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3287 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3289 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3291 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3293 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3295 * xterm.c (x_find_topmost_parent): New function.
3296 (x_set_frame_alpha): Find topmost parent window with
3297 x_find_topmost_parent and set the property there also (bug#9181).
3298 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3300 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3302 * callproc.c (Fcall_process): Avoid vfork clobbering
3303 the local vars buffer, coding_systems, current_dir.
3305 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3307 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3309 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3311 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3312 so that it is not optimized away.
3314 * xdisp.c (compute_display_string_pos): Remove unused local.
3316 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3318 Fix slow cursor motion and scrolling in large buffers with
3319 selective display, like Org Mode buffers. (Bug#9218)
3321 * dispextern.h (struct bidi_it): New member disp_prop_p.
3323 * xdisp.c: Remove one-slot cache of display string positions.
3324 (compute_display_string_pos): Accept an additional argument
3325 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3326 for a display string or property. If found, set DISP_PROP_P
3329 * bidi.c (bidi_fetch_char): Accept an additional argument
3330 DISP_PROP_P, and pass it to compute_display_string_pos.
3331 Only handle text covered by a display string if DISP_PROP_P is returned
3332 non-zero. All callers of bidi_fetch_char changed.
3334 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3336 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3338 2010-12-03 Don March <don@ohspite.net>
3340 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3341 last character M-[char] is translated to ESC [char] (bug#7541).
3343 2011-08-02 Kenichi Handa <handa@m17n.org>
3345 * lisp.h (uniprop_table): Extern it.
3347 * chartab.c (uniprop_table): Make it non-static.
3349 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3351 * xdisp.c (forward_to_next_line_start): Accept additional argument
3352 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3354 (reseat_at_next_visible_line_start): Use the bidi iterator state
3355 returned by forward_to_next_line_start to restore the state of
3356 it->bidi_it after backing up to previous newline. (Bug#9212)
3358 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3360 * regex.c (re_comp): Protoize.
3361 (re_exec): Fix return type.
3362 (regexec): Fix type of `ret'. (Bug#9203)
3364 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3366 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3367 This is needed if max-image-size is a floating-point number.
3369 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3371 * print.c (print_object): Print empty symbol as ##.
3373 * lread.c (read1): Read ## as empty symbol.
3375 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3377 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3378 setting frame foreground color (Bug#9175).
3379 (x_set_background_color): Likewise.
3381 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3382 contents (Bug#9176).
3383 (EmacsTooltip -init): Remove bezels and add shadows to
3386 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3387 or scroll bar (Bug#8470).
3389 * nsfont.m (nsfont_open): Remove assignment to voffset and
3390 unnecessary vars hshink, expand, hd, full_height, min_height.
3391 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3393 * nsterm.h (nsfont_info): Remove voffset field.
3395 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3397 Implement strike-through and overline on NextStep (Bug#8863).
3399 * nsfont.m (nsfont_open): Use underline position provided by font,
3400 instead of hard-coded value of 2.
3401 (nsfont_draw): Call ns_draw_text_decoration instead.
3403 * nsterm.h: Add declaration for ns_draw_text_decoration.
3405 * nsterm.m (ns_draw_text_decoration): New function for drawing
3406 underline, overline, and strike-through.
3407 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3408 ns_draw_text_decoration. Change treatment of cursor drawing to
3409 accommodate underlining, etc.
3411 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3413 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3416 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3418 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3419 Without this fix, if a signal arrives just after memory fills up,
3420 'malloc' might be invoked reentrantly.
3422 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3423 In other words, assume that every image size is allowed, on non-X
3424 hosts. This assumption is probably wrong, but it lets Emacs compile.
3426 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3428 * regex.c (re_iswctype): Convert return values to boolean.
3430 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3432 * xdisp.c (compute_display_string_pos): Don't use cached display
3433 string position if the buffer had its restriction changed.
3436 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3438 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3440 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3442 Integer signedness and overflow and related fixes. (Bug#9079)
3444 * bidi.c: Integer size and overflow fixes.
3445 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3446 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3447 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3448 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3449 (bidi_find_other_level_edge):
3450 Use ptrdiff_t instead of EMACS_INT where either will do.
3451 This works better on 32-bit hosts configured --with-wide-int.
3452 (bidi_cache_ensure_space): Check for size-calculation overflow.
3453 Use % rather than repeated addition, for better worst-case speed.
3454 Don't set bidi_cache_size until after xrealloc returns, because it
3456 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3457 (bidi_cache_ensure_space): Also check that the bidi cache size
3458 does not exceed that of the largest Lisp string or buffer. See Eli
3459 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3461 * alloc.c (__malloc_size_t): Remove.
3462 All uses replaced by size_t. See Andreas Schwab's note
3463 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3465 * image.c: Improve checking for integer overflow.
3466 (check_image_size): Assume that f is nonnull, since
3467 it is always nonnull in practice. This is one less thing to
3468 worry about when checking for integer overflow later.
3469 (x_check_image_size): New function, which checks for integer
3470 overflow issues inside X.
3471 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3472 This removes the need for a memory_full check.
3473 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3474 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3475 (xbm_read_bitmap_data): Change locals back to 'int', since
3476 their values must fit in 'int'.
3477 (xpm_load_image, png_load, tiff_load):
3478 Invoke x_create_x_image_and_pixmap earlier,
3479 to avoid much needless work if the image is too large.
3480 (tiff_load): Treat overly large images as if
3481 x_create_x_image_and_pixmap failed, not as malloc failures.
3482 (gs_load): Use x_check_image_size.
3484 * gtkutil.c: Omit integer casts.
3485 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3486 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3488 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3490 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3491 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3492 would wrongly return t on a 64-bit host.
3494 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3495 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3496 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3497 and therefore cause GCC to emit a bogus diagnostic in some cases.
3499 * image.c: Integer signedness and overflow and related fixes.
3500 This is not an exhaustive set of fixes, but it's time to
3501 record what I've got.
3502 (lookup_pixel_color, check_image_size): Remove redundant decls.
3503 (check_image_size): Don't assume that arbitrary EMACS_INT values
3504 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3505 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3506 (tiff_load, imagemagick_load_image):
3507 Check for overflow in size calculations.
3508 (x_create_x_image_and_pixmap): Remove unnecessary test for
3509 xmalloc returning NULL; that can't happen.
3510 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3511 (xpm_color_bucket): Use better integer hashing function.
3512 (xpm_cache_color): Don't possibly over-allocate memory.
3513 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3514 (gif_memory_source):
3515 Use ptrdiff_t, not int or size_t, to record sizes.
3516 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3517 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3518 either works, as we prefer signed integers.
3519 (tiff_read_from_memory, tiff_write_from_memory):
3520 Return tsize_t, not size_t, since that's what the TIFF API wants.
3521 (tiff_read_from_memory): Don't fail simply because the read would
3522 go past EOF; instead, return a short read.
3523 (tiff_load): Omit no-longer-needed casts.
3524 (Fimagemagick_types): Don't assume size fits into 'int'.
3526 Improve hashing quality when configured --with-wide-int.
3527 * fns.c (hash_string): New function, taken from sxhash_string.
3528 Do not discard information about ASCII character case; this
3529 discarding is no longer needed.
3530 (sxhash-string): Use it. Change sig to match it. Caller changed.
3531 * lisp.h: Declare it.
3532 * lread.c (hash_string): Remove, since we now use fns.c's version.
3533 The fns.c version returns a wider integer if --with-wide-int is
3534 specified, so this should help the quality of the hashing a bit.
3536 * emacs.c: Integer overflow minor fix.
3537 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3538 Define only if GNU_LINUX.
3539 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3541 * dispnew.c: Integer signedness and overflow fixes.
3542 Remove unnecessary forward decls, that were a maintenance hassle.
3543 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3545 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3546 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3547 (prepare_desired_row, line_draw_cost):
3548 Use int, not unsigned, where either works.
3549 (save_current_matrix, restore_current_matrix):
3550 Use ptrdiff_t, not size_t, where either works.
3551 (init_display): Check for overflow more accurately, and without
3552 relying on undefined behavior.
3554 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3555 Remove, replacing with the new symbols in lisp.h. All uses changed.
3556 * fileio.c (make_temp_name):
3557 * filelock.c (lock_file_1, lock_file):
3558 * xdisp.c (message_dolog):
3559 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3560 Use pMd etc. instead.
3561 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3562 replacing the pWIDE etc. symbols removed from editfns.c.
3564 * keyboard.h (num_input_events): Now uintmax_t.
3565 This is (very slightly) less likely to mess up due to wraparound.
3568 * buffer.c: Integer signedness fixes.
3569 (alloc_buffer_text, enlarge_buffer_text):
3570 Use ptrdiff_t rather than size_t when either will do, as we prefer
3573 * alloc.c: Integer signedness and overflow fixes.
3574 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3575 (__malloc_size_t): Default to size_t, not to int.
3576 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3577 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3578 Prefer ptrdiff_t to size_t when either would do, as we prefer
3580 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3581 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3582 Now const. Initialize with values that are in range even if char
3584 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3585 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3586 These functions do the right thing with sizes > 2**32.
3587 (check_depth): Now ptrdiff_t, not int.
3588 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3589 Adjust to new way of storing sizes. Check for size overflow bugs
3591 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3592 slightly wrong anyway, as it missed one instance of
3593 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3594 (refill_memory_reserve): Omit needless cast to size_t.
3595 (mark_object_loop_halt): Mark as externally visible.
3597 * xselect.c: Integer signedness and overflow fixes.
3598 (Fx_register_dnd_atom, x_handle_dnd_message):
3599 Use ptrdiff_t, not size_t, since we prefer signed.
3600 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3601 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3602 x_dnd_atoms_size and x_dnd_atoms_length.
3604 * doprnt.c: Prefer signed to unsigned when either works.
3606 * doprnt.c (doprnt):
3608 * xdisp.c (vmessage):
3609 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3610 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3611 prefer signed arithmetic to avoid comparison confusion.
3612 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3613 but is a bit tricky.
3615 Assume freestanding C89 headers, string.h, stdlib.h.
3616 * data.c, doprnt.c, floatfns.c, print.c:
3617 Include float.h unconditionally.
3618 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3619 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3620 * regex.c: Likewise for stddef.h, string.h.
3621 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3622 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3623 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3624 (STDC_HEADERS): Remove obsolete defines.
3625 * sysdep.c: Include limits.h unconditionally.
3627 Assume support for memcmp, memcpy, memmove, memset.
3628 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3629 * regex.c (memcmp, memcpy):
3630 Remove; we assume C89 now.
3632 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3633 (__malloc_safe_bcopy): Remove; no longer needed.
3635 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3636 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3637 well either way, and we prefer signed to unsigned.
3639 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3641 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3642 closes the connection while we're reading (bug#9182).
3644 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3646 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3647 are specified (Bug#9168).
3649 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3651 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3652 Found by GCC static checking and --with-wide-int on a 32-bit host.
3654 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3656 * xdisp.c (compute_display_string_pos): Fix logic of caching
3657 previous display string position. Initialize cached_prev_pos to
3658 -1. Fixes slow-down at the beginning of a buffer.
3660 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3662 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3663 for attrs[LFACE_FONTSET_INDEX].
3665 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3667 * xml.c (parse_region): Remove unused local
3668 that was recently introduced.
3670 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3672 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3673 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3675 * xdisp.c (move_it_in_display_line_to): Record the best matching
3676 position for TO_CHARPOS while scanning the line, and restore it on
3677 exit if none of the characters scanned was an exact match.
3678 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3679 when exact match is impossible due to invisible text, and the
3680 lines are truncated.
3682 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3684 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3687 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3689 Fix a significant slow-down of cursor motion with C-n, C-p,
3690 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3691 auto-repeat under bidi redisplay in fontified buffers.
3692 * xdisp.c (compute_stop_pos_backwards): New function.
3693 (next_element_from_buffer): Call compute_stop_pos_backwards to
3694 find a suitable prev_stop when we find ourselves before
3696 (reseat): Don't look for prev_stop, as that could mean a very long
3698 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3699 <cached_disp_overlay_modiff>: Cache for last found display string
3701 (compute_display_string_pos): Return the cached position if asked
3702 about the same buffer in the same area of character positions, and
3703 the buffer wasn't changed since the time the display string
3704 position was cached.
3706 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3708 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3709 is an integer, which is important for empty lines. (Bug#9149)
3711 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3713 * frame.c (Fmodify_frame_parameters): In tty case, update the
3714 default face if necessary (Bug#4238).
3716 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3718 * editfns.c (Fstring_to_char): No need to explain what a character
3719 is in the docstring (Bug#6576).
3721 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3723 * xml.c (parse_region): Make sure we always return a tree.
3725 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3727 * xml.c (parse_region): If a document contains only comments,
3730 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3732 * xml.c (make_dom): Return comments, too.
3734 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3737 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3738 and the surrounding thread.
3739 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3740 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3741 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3743 * s/openbsd.h (BROKEN_SIGIO): Define.
3744 * unexelf.c (unexec) [__OpenBSD__]:
3745 Don't update the .mdebug section of the Alpha COFF symbol table.
3747 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3749 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3752 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3754 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3755 This fixes some race conditions on the permissions of any newly
3758 * alloc.c (valid_pointer_p): Use pipe, not open.
3759 This fixes some permissions issues when debugging.
3761 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3762 If fchown fails to set both uid and gid, try to set just gid,
3763 as that is sometimes allowed. Adjust the file's mode to eliminate
3764 setuid or setgid bits that are inappropriate if fchown fails.
3766 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3768 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3769 to compare Lisp_Objects.
3770 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3771 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3772 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3774 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3776 * lread.c (read_integer): Unread even EOF character.
3777 (read1): Likewise. Properly record start position of symbol.
3779 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3780 symbol character follows.
3782 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3784 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3785 This works around a problem with the previous change to Fcopy_file.
3786 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3787 and without this change, GCC might complain about discarding
3788 fchown's return value.
3790 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3792 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3794 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3796 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3798 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3800 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3801 it's used from the C level.
3803 * process.c: Use the same condition for POLL_FOR_INPUT in both
3804 keyboard.c and process.c (bug#1858).
3806 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3808 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3809 (Fgnutls_boot): Use it.
3811 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3813 * doc.c (Fsubstitute_command_keys): Revert last change.
3815 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3817 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3818 quotes the next character, and doesn't affect other longer
3819 sequences (bug#8935).
3821 * lread.c (syms_of_lread): Clarify that is isn't only
3822 `eval-buffer' and `eval-defun' that's affected by
3823 `lexical-binding' (bug#8460).
3825 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3827 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3828 bidi redisplay when a line includes both an image and is truncated.
3830 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3832 Fix minor problems found by static checking.
3833 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3834 (elsz): Now a signed constant, not a size_t var. We prefer signed
3835 types to unsigned, to avoid integer comparison confusion. Without
3836 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3837 "cannot optimize loop, the loop counter may overflow", a symptom
3839 * indent.c (Fvertical_motion): Mark locals as initialized.
3840 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3842 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3844 * search.c (Fre_search_backward): Mention `case-fold-search' in
3845 all the re_search_* functions (bug#8138).
3847 * keyboard.c (Fopen_dribble_file): Document when the file is
3850 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3852 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3855 Support bidi reordering of display and overlay strings.
3856 * xdisp.c (compute_display_string_pos)
3857 (compute_display_string_end): Accept additional argument STRING.
3858 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3859 (reseat_to_string): Initialize bidi_it->string.s and
3860 bidi_it->string.schars.
3861 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3862 NULL (avoids a crash in bidi_paragraph_init).
3863 Initialize itb.string.lstring.
3864 (init_iterator): Call bidi_init_it only of a valid
3865 buffer position was specified. Initialize paragraph_embedding to
3867 (reseat_to_string): Initialize the bidi iterator.
3868 (display_string): If we need to ignore text properties of
3869 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3870 original value of -1 will not work with bidi.)
3871 (compute_display_string_pos): First arg is now struct
3872 `text_pos *'; all callers changed. Support display properties on
3874 (compute_display_string_end): Support display properties on Lisp
3876 (init_iterator, reseat_1, reseat_to_string): Initialize the
3877 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3878 when iterating on a string not from display properties).
3879 (compute_display_string_pos, compute_display_string_end):
3880 Fix calculation of the object to scan. Fixes an error when using
3882 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3883 base_level_stop; instead, set base_level_stop to BEGV.
3884 Fixes crashes in vertical-motion.
3885 (next_element_from_buffer): Improve commentary for when
3886 the iterator is before prev_stop.
3887 (init_iterator): Initialize bidi_p from the default value of
3888 bidi-display-reordering, not from buffer-local value. Use the
3889 buffer-local value only if initializing for buffer iteration.
3890 (handle_invisible_prop): Support invisible properties on strings
3891 that are being bidi-reordered.
3892 (set_iterator_to_next): Support bidi reordering of C strings and
3894 (next_element_from_string): Support bidi reordering of Lisp
3896 (handle_stop_backwards): Support Lisp strings as well.
3897 (display_string): Support display of R2L glyph rows.
3898 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3899 (init_iterator): Don't initialize it->bidi_p for strings
3901 (reseat_to_string): Initialize it->bidi_p for strings here.
3902 (next_element_from_string, next_element_from_c_string)
3903 (next_element_from_buffer): Add xassert's for correspondence
3904 between IT's object being iterated and it->bidi_it.string
3906 (face_before_or_after_it_pos): Support bidi iteration.
3907 (next_element_from_c_string): Handle the case of the first string
3908 character that is not the first one in the visual order.
3909 (get_visually_first_element): New function, refactored from common
3910 parts of next_element_from_buffer, next_element_from_string, and
3911 next_element_from_c_string.
3912 (tool_bar_lines_needed, redisplay_tool_bar)
3913 (display_menu_bar): Force left-to-right direction. Add a FIXME
3914 comment for making that be controlled by a user option.
3915 (push_it, pop_it): Save and restore the state of the
3916 bidi iterator. Save and restore the bidi_p flag.
3917 (pop_it): Iterate out of display property for string iteration as
3919 (iterate_out_of_display_property): Support iteration over strings.
3920 (handle_single_display_spec): Set up it->bidi_it for iteration
3921 over a display string, and call bidi_init_it.
3922 (handle_single_display_spec, next_overlay_string)
3923 (get_overlay_strings_1, push_display_prop): Set up the bidi
3924 iterator for displaying display or overlay strings.
3925 (forward_to_next_line_start): Don't use the shortcut if
3927 (back_to_previous_visible_line_start): If handle_display_prop
3928 pushed the iterator stack, restore the internal state of the bidi
3929 iterator by calling bidi_pop_it same number of times.
3930 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3931 and we are bidi-iterating, don't decrement the iterator position;
3932 instead, set the first_elt flag in the bidi iterator, to produce
3934 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3935 (push_display_prop): xassert that we are iterating a buffer.
3936 (push_it, pop_it): Save and restore paragraph_embedding member.
3937 (handle_single_display_spec, next_overlay_string)
3938 (get_overlay_strings_1, reseat_1, reseat_to_string)
3939 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3940 correctly. Don't assume unibyte strings are not bidi-reordered.
3941 (compute_display_string_pos)
3942 (compute_display_string_end): Fix handling the case of C string.
3943 (push_it, pop_it): Save and restore from_disp_prop_p.
3944 (handle_single_display_spec, push_display_prop): Set the
3945 from_disp_prop_p flag.
3946 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3947 (pop_it): Call iterate_out_of_display_property only if we are
3948 popping after iteration over a string that came from a display
3949 property. Fix a typo in popping stretch info. Add an assertion
3950 for verifying that the iterator position is in sync with the bidi
3952 (handle_single_display_spec, get_overlay_strings_1)
3953 (push_display_prop): Fix initialization of paragraph direction for
3954 string when that of the parent object is not yet determined.
3955 (reseat_1): Call bidi_init_it to resync the bidi
3956 iterator with IT's position. (Bug#7616)
3957 (find_row_edges): If ROW->start.pos gives position
3958 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3959 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3960 Reset the from_disp_prop_p flag.
3961 (SAVE_IT, RESTORE_IT): New macros.
3962 (pos_visible_p, face_before_or_after_it_pos)
3963 (back_to_previous_visible_line_start)
3964 (move_it_in_display_line_to, move_it_in_display_line)
3965 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3966 (try_scrolling, redisplay_window, display_line): Use them when
3967 saving a temporary copy of the iterator and restoring it back.
3968 (back_to_previous_visible_line_start, reseat_1)
3969 (init_iterator): Empty the bidi cache "stack".
3970 (move_it_in_display_line_to): If iterator ended up at
3971 EOL, but we never saw any buffer positions smaller than
3972 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3973 motion in bidi-reordered lines.
3974 (move_it_in_display_line_to): Record prev_method and prev_pos
3975 immediately before the call to set_iterator_to_next. Fixes cursor
3976 motion in bidi-reordered lines with stretch glyphs and strings
3977 displayed in margins. (Bug#8133) (Bug#8867)
3978 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3980 (pos_visible_p): Support positions in bidi-reordered lines.
3981 Save and restore bidi cache.
3983 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3984 (bidi_paragraph_info): Delete unused struct.
3985 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3986 (bidi_cache_start): New variable.
3987 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3989 (bidi_cache_fetch_state, bidi_cache_search)
3990 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3991 (bidi_cache_find, bidi_peek_at_next_level)
3992 (bidi_level_of_next_char, bidi_find_other_level_edge)
3993 (bidi_move_to_visually_next): Compare cache index with
3994 bidi_cache_start rather than with zero.
3995 (bidi_fetch_char): Accept new argument STRING; all callers
3996 changed. Support iteration over a string. Support strings with
3997 display properties. Support unibyte strings. Fix the type of
3998 `len' according to what STRING_CHAR_AND_LENGTH expects.
3999 (bidi_paragraph_init, bidi_resolve_explicit_1)
4000 (bidi_resolve_explicit, bidi_resolve_weak)
4001 (bidi_level_of_next_char, bidi_move_to_visually_next):
4002 Support iteration over a string.
4003 (bidi_set_sor_type, bidi_resolve_explicit_1)
4004 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4005 can now be zero (for strings); special values 0 and -1 were
4006 changed to -1 and -2, respectively.
4007 (bidi_char_at_pos): New function.
4008 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4009 Call it instead of FETCH_MULTIBYTE_CHAR.
4010 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4011 initialized to valid values.
4012 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4014 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4015 the test for valid cached positions. Fix the logic for looking up
4016 the sentinel state in the cache. GCPRO the Lisp string we are
4018 (bidi_push_it, bidi_pop_it): New functions.
4019 (bidi_initialize): Initialize the bidi cache start stack pointer.
4020 (bidi_cache_ensure_space): New function, refactored from part of
4021 bidi_cache_iterator_state. Don't assume the required size is just
4022 one BIDI_CACHE_CHUNK away.
4023 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4024 (bidi_count_bytes, bidi_char_at_pos): New functions.
4025 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4026 always valid if bidi_cache_idx is valid.
4027 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4028 is valid if it's going to be used.
4029 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4030 (bidi_cache_fetch_state, bidi_cache_search)
4031 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4032 (bidi_cache_iterator_state, bidi_cache_find)
4033 (bidi_find_other_level_edge, bidi_cache_start_stack):
4034 All variables related to cache indices are now EMACS_INT.
4036 * dispextern.h (struct bidi_string_data): New structure.
4037 (struct bidi_it): New member `string'. Make flag members be 1-bit
4038 fields, and put them last in the struct.
4039 (compute_display_string_pos, compute_display_string_end):
4041 (bidi_push_it, bidi_pop_it): Add prototypes.
4042 (struct iterator_stack_entry): New members bidi_p,
4043 paragraph_embedding, and from_disp_prop_p.
4044 (struct it): Member bidi_p is now a bit field 1 bit wide.
4045 (bidi_shelve_cache, bidi_unshelve_cache):
4048 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4049 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4050 and vector-like objects.
4052 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4053 cache around display iteration.
4055 * window.c (Fwindow_end, window_scroll_pixel_based)
4056 (displayed_window_lines, Frecenter): Save and restore the bidi
4057 cache around display iteration.
4059 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4061 * editfns.c (Fdelete_region): Clarify the use of the named
4062 parameters (bug#6788).
4064 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4066 * indent.c (Fvertical_motion): Set and restore w->pointm when
4067 saving and restoring the window's buffer (Bug#9006).
4069 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4071 * editfns.c (Fstring_to_char): Clarify just what is returned
4072 (bug#6576). Text by Eli Zaretskii.
4074 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4076 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4078 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4080 * buffer.c (mmap_find): Fix a typo.
4082 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4084 Fix execution of x selection hooks.
4085 * xselect.c (Qx_lost_selection_functions)
4086 (Qx_sent_selection_functions): New vars.
4087 (syms_of_xselect): DEFSYM them.
4088 (x_handle_selection_request): Pass Qx_sent_selection_functions
4089 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4090 (x_handle_selection_clear,x_clear_frame_selections):
4091 Pass Qx_lost_selection_functions rather than
4092 Vx_lost_selection_functions to Frun_hook_with_args.
4094 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4096 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4097 The old code sometimes used this field without initializing it.
4099 * alloc.c (gc_sweep): Don't read past end of array.
4100 In theory, the old code could also have corrupted Emacs internals,
4101 though it'd be very unlikely.
4103 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4105 * character.c (Fcharacterp): Don't advertise optional ignored
4106 argument. (Bug#4026)
4108 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4110 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4113 * window.c (Fset_window_start): Doc fix (bug#4199).
4114 (Fset_window_hscroll): Ditto.
4116 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4118 Fix minor new problems caught by GCC 4.6.1.
4119 * term.c (init_tty): Remove unused local.
4120 * xsettings.c (store_monospaced_changed): Define this function only
4121 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4124 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4126 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4128 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4130 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4131 are the mini-buffer and the echo area (bug#3320).
4133 * term.c (init_tty): Remove support for supdup, c10 and perq
4134 terminals, which are no longer supported (bug#1482).
4136 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4138 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4140 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4142 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4143 for non-popups (Bug#3642).
4145 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4147 * alloc.c (reset_malloc_hooks): Protoize.
4148 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4149 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4150 * cm.c (losecursor): Likewise.
4151 * data.c (fmod): Likewise.
4152 * dispnew.c (swap_glyphs_in_rows): Likewise.
4153 * emacs.c (memory_warning_signal): Likewise.
4154 * floatfns.c (float_error): Likewise.
4155 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4156 (otf_open, font_otf_capability, generate_otf_features)
4157 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4159 * image.c (pbm_read_file): Likewise.
4160 * indent.c (string_display_width): Likewise.
4161 * intervals.c (check_for_interval, search_for_interval)
4162 (inc_interval_count, count_intervals, root_interval)
4163 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4164 * lread.c (defalias): Likewise.
4165 * ralloc.c (r_alloc_check): Likewise.
4166 * regex.c (set_image_of_range_1, set_image_of_range)
4167 (regex_grow_registers): Likewise.
4168 * sysdep.c (strerror): Likewise.
4169 * termcap.c (valid_filename_p, tprint, main): Likewise.
4170 * tparam.c (main): Likewise.
4171 * unexhp9k800.c (run_time_remap, save_data_space)
4172 (update_file_ptrs, read_header, write_header, calculate_checksum)
4173 (copy_file, copy_rest, display_header): Likewise.
4174 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4176 * xdisp.c (check_it): Likewise.
4177 * xfaces.c (register_color, unregister_color, unregister_colors):
4179 * xfns.c (print_fontset_result): Likewise.
4180 * xrdb.c (member, fatal, main): Likewise.
4182 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4184 Fix minor problems found by static checking (Bug#9031).
4185 * chartab.c (char_table_set_range, map_sub_char_table):
4186 Remove unused locals.
4187 (uniprop_table): Now static.
4188 * composite.c (_work_char): Remove unused static var.
4190 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4192 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4194 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4196 * gtkutil.c (qttip_cb): Remove code without function.
4198 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4200 * w32.c (pthread_sigmask): New stub.
4202 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4204 Use pthread_sigmask, not sigprocmask (Bug#9010).
4205 sigprocmask is portable only for single-threaded applications, and
4206 Emacs can be multi-threaded when it uses GTK.
4207 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4209 * callproc.c (Fcall_process):
4210 * process.c (create_process):
4211 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4212 Use pthread_sigmask, not sigprocmask.
4214 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4216 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4217 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4220 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4222 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4223 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4224 (xg_hide_tooltip): Fix comment.
4226 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4227 in registerServicesMenuSendTypes.
4228 (validRequestorForSendType): Don't check ns_return_types.
4230 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4233 2011-07-08 Jason Rumney <jasonr@gnu.org>
4235 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4236 SH_SHOW for hidden windows (Bug#5482).
4238 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4239 frame struct members of non-existent frames (Bug#6284).
4241 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4243 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4244 variable firstTime not needed on OSX >= 10.6.
4245 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4246 >= 10.5. Use setKnobProportion, setDoubleValue.
4248 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4249 (MAC_OS_X_VERSION_10_5): Define if not defined.
4250 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4251 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4252 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4254 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4255 cString and lossyCString on OSX >= 10.4
4257 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4258 sizeToFit on OSX >= 10.2.
4260 * nsimage.m (allocInitFromFile): Don't use deprecated method
4261 bestRepresentationForDevice on OSX >= 10.6.
4263 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4266 * emacs.c: Declare unexec_init_emacs_zone.
4268 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4270 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4272 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4273 on svcsMenu (Bug#8842).
4275 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4277 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4279 * nsterm.m (QUTF8_STRING): Declare.
4280 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4281 (validRequestorForSendType): Return type is (id).
4282 Change indexOfObjectIdenticalTo to indexOfObject.
4283 Check if we have local selection before returning self (Bug#8842).
4284 (writeSelectionToPasteboard): Put local selection into paste board
4285 if we have a local selection (Bug#8842).
4286 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4288 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4289 (ns_get_local_selection): Declare.
4291 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4293 * keymap.c (describe_map_tree): Don't insert a double newline at
4294 the end of the buffer (bug#1169) and return whether we inserted
4297 * callint.c (Fcall_interactively): Change "reading args" to
4298 "providing args" to try to clarify what it does (bug#1010).
4300 2011-07-07 Kenichi Handa <handa@m17n.org>
4302 * composite.c (composition_compute_stop_pos): Ignore a static
4303 composition starting before CHARPOS (Bug#8915).
4305 * xdisp.c (handle_composition_prop): Likewise.
4307 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4309 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4312 2011-07-07 Kenichi Handa <handa@m17n.org>
4314 * character.h (unicode_category_t): New enum type.
4316 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4317 (Qchar_code_property_table): New variable.
4318 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4319 (UNIPROP_COMPRESSED_FORM_P): New macros.
4320 (char_table_ascii): Uncompress the compressed values.
4321 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4322 Uncompress the compressed values.
4323 (sub_char_table_ref_and_range): Likewise.
4324 (char_table_ref_and_range): Uncompress the compressed values.
4325 (sub_char_table_set): New arg is_uniprop. Callers changed.
4326 Uncompress the compressed values.
4327 (sub_char_table_set_range): Args changed. Callers changed.
4328 (char_table_set_range): Adjuted for the above change.
4329 (map_sub_char_table): Delete args default_val and parent. Add arg
4330 top. Give decoded values to a Lisp function.
4331 (map_char_table): Adjust for the above change. Give decoded
4332 values to a Lisp function. Gcpro more variables.
4333 (uniprop_table_uncompress)
4334 (uniprop_decode_value_run_length): New functions.
4335 (uniprop_decoder, uniprop_decoder_count): New variables.
4336 (uniprop_get_decoder, uniprop_encode_value_character)
4337 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4339 (uniprop_encoder, uniprop_encoder_count): New variables.
4340 (uniprop_get_encoder, uniprop_table)
4341 (Funicode_property_table_internal, Fget_unicode_property_internal)
4342 (Fput_unicode_property_internal): New functions.
4343 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4344 Sunicode_property_table_internal, Sget_unicode_property_internal,
4345 and Sput_unicode_property_internal. Defvar_lisp
4346 char-code-property-alist.
4348 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4349 Vunicode_category_table.
4351 * font.c (font_range): Adjust for the change of
4352 Vunicode_category_table.
4354 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4356 * m/iris4d.h: Remove file, move contents ...
4357 * s/irix6-5.h: ... here.
4359 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4361 Remove unportable assumption about struct layout (Bug#8884).
4362 * alloc.c (mark_buffer):
4363 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4364 (clone_per_buffer_values): Don't assume that
4365 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4366 This isn't true in general, and it's particularly not true
4367 if Emacs is configured with --with-wide-int.
4368 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4369 New macros, used in the buffer.c change.
4371 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4373 * xsettings.c: Use both GConf and GSettings if both are available.
4374 (store_config_changed_event): Add comment.
4375 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4376 (store_tool_bar_style_changed): New functions.
4377 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4378 (struct xsettings): Move font inside HAVE_XFT.
4379 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4380 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4381 Move inside HAVE_XFT.
4382 (something_changed_gsettingsCB): Rename from something_changedCB.
4383 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4385 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4386 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4387 (something_changed_gconfCB): Rename from something_changedCB.
4388 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4389 (parse_settings): Move check for font inside HAVE_XFT.
4390 (read_settings, apply_xft_settings): Add comment.
4391 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4392 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4393 call store_font_name_changed.
4394 (xft_settings_event): Add comment.
4395 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4396 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4397 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4398 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4399 (xsettings_initialize): Call init_gsettings last.
4400 (xsettings_get_system_font, xsettings_get_system_normal_font):
4403 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4405 Random fixes. E.g., (random) never returned negative values.
4406 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4407 subseconds part to the entropy, as that's a bit more random.
4408 Prefer signed to unsigned, since the signedness doesn't matter and
4409 in general we prefer signed. When given a limit, use a
4410 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4411 latter isn't right if USE_2_TAGS_FOR_INTS.
4412 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4413 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4415 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4417 * textprop.c (text_property_stickiness):
4418 Obey Vtext_property_default_nonsticky.
4419 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4420 * w32fns.c (syms_of_w32fns):
4421 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4423 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4425 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4426 This is more efficient than Ffile_directory_p and avoids a minor race.
4428 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4430 * buffer.c (Foverlay_put): Say what the return value is
4433 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4434 is a directory before asking whether to use the file name
4436 (barf_or_query_if_file_exists): Make the "File is a directory"
4437 error be more correct.
4439 * fns.c (Frequire): Remove the mention of the .gz files, since
4440 that's installation-specific, but keep the mention of
4441 `get-load-suffixes'.
4443 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4445 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4446 Report string overflow if the output is too long.
4448 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4450 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4451 (syms_of_gnutls): Remove duplicate DEFSYM for
4452 Qgnutls_bootprop_verify_hostname_error, an error for
4453 Qgnutls_bootprop_verify_error (which is no longer used).
4455 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4456 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4457 Also (re)move comments that are misplaced or no longer relevant.
4459 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4461 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4463 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4465 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4466 and background color parameters if they have been changed.
4468 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4470 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4472 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4474 * xsettings.c (SYSTEM_FONT): Define only when used.
4475 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4477 * keymap.c (access_keymap_1): Now static.
4479 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4481 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4482 leave any prefix arg for the up event (Bug#1586).
4484 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4486 * lread.c (syms_of_lread): Mention single symbols defined by
4487 `defvar' or `defconst' (bug#7154).
4489 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4490 (Frequire): Mention get-load-suffixes.
4492 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4494 * window.h (window): Remove clone_number slot.
4495 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4497 (make_parent_window, make_window, saved_window)
4498 (Fset_window_configuration, save_window_save): Don't deal with
4500 * buffer.c (Qclone_number): Remove declaration.
4501 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4503 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4505 Add multiple inheritance to keymaps.
4506 * keymap.c (Fmake_composed_keymap): New function.
4507 (Fset_keymap_parent): Simplify.
4508 (fix_submap_inheritance): Remove.
4509 (access_keymap_1): New function extracted from access_keymap to handle
4510 embedded parents and handle lists of maps.
4511 (access_keymap): Use it.
4512 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4513 (Fcopy_keymap): Handle embedded parents.
4514 (Fcommand_remapping, define_as_prefix): Simplify.
4515 (Fkey_binding): Simplify.
4516 (syms_of_keymap): Move minibuffer-local-completion-map,
4517 minibuffer-local-filename-completion-map,
4518 minibuffer-local-must-match-map, and
4519 minibuffer-local-filename-must-match-map to Elisp.
4520 (syms_of_keymap): Defsubr make-composed-keymap.
4521 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4522 (parse_menu_item): Trivial simplification.
4524 2011-07-01 Glenn Morris <rgm@gnu.org>
4526 * Makefile.in (SETTINGS_LIBS): Fix typo.
4528 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4530 * coding.c (Fencode_coding_string): Record the last coding system
4531 used, as the function doc string says (bug#8738).
4533 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4535 * xsettings.c (store_monospaced_changed): Take new font as arg and
4536 check for change against current_mono_font.
4537 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4538 (emacs_settings_constructor, emacs_settings_get_property)
4539 (emacs_settings_set_property, emacs_settings_class_init)
4540 (emacs_settings_init, gsettings_obj): Remove.
4541 (something_changedCB): New function for HAVE_GSETTINGS.
4542 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4543 with value as argument.
4544 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4545 g_settings_new (Bug#8967). Do not create gsettings_obj.
4546 Remove calls to g_settings_bind. Connect something_changedCB to
4549 * xgselect.c: Add defined (HAVE_GSETTINGS).
4550 (xgselect_initialize): Ditto.
4552 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4553 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4556 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4558 * eval.c (struct backtrace): Simplify and port the data structure.
4559 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4560 signed bit field, as this assumption is not portable and it makes
4561 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4562 "char debug_on_exit : 1" as this is not portable either; instead,
4563 use the portable "unsigned int debug_on_exit : 1". Remove unused
4564 member evalargs. Remove obsolete comments about cc bombing out.
4566 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4568 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4569 Let HAVE_GSETTINGS override HAVE_GCONF.
4570 (store_monospaced_changed): New function.
4571 (EMACS_SETTINGS): A new type derived from GObject to handle
4572 GSettings notifications.
4573 (emacs_settings_constructor, emacs_settings_get_property)
4574 (emacs_settings_set_property, emacs_settings_class_init):
4576 (gsettings_client, gsettings_obj): New variables.
4577 (GSETTINGS_SCHEMA): New define.
4578 (something_changedCB): Call store_monospaced_changed.
4579 (init_gsettings): New function.
4580 (xsettings_initialize): Call init_gsettings.
4581 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4584 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4587 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4589 * window.c (resize_root_window, grow_mini_window)
4590 (shrink_mini_window): Rename Qresize_root_window to
4591 Qwindow_resize_root_window and Qresize_root_window_vertically to
4592 Qwindow_resize_root_window_vertically.
4594 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4596 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4598 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4600 * makefile.w32-in: Redesign dependencies so they reflect more
4601 clearly which files are directly included by each source file,
4602 and not through other includes.
4604 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4606 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4607 (sort_overlays, overlay_strings): When an overlay's clone number
4608 matches the window's clone number process the overlay even if
4609 the overlay's window property doesn't match the current window.
4611 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4612 (Fwindow_hchild): Rename to Fwindow_left_child.
4613 (Fwindow_next): Rename to Fwindow_next_sibling.
4614 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4615 (resize_window_check): Rename to window_resize_check.
4616 (resize_window_apply): Rename to window_resize_apply.
4617 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4618 (Fdelete_other_windows_internal, resize_frame_windows)
4619 (Fsplit_window_internal, Fdelete_window_internal)
4620 (grow_mini_window, shrink_mini_window)
4621 (Fresize_mini_window_internal): Fix callers accordingly.
4623 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4625 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4626 (emacs_fixed_set_min_size): Remove.
4627 (emacs_fixed_new): Take frame as argument.
4629 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4630 (_EmacsFixedPrivate): Remove minwidth/height.
4631 Add struct frame *f.
4632 (emacs_fixed_init): Initialize priv->f.
4633 (get_parent_class, emacs_fixed_set_min_size): Remove.
4634 (emacs_fixed_new): Set priv->f to argument.
4635 (emacs_fixed_get_preferred_width)
4636 (emacs_fixed_get_preferred_height): Use min_width/height from
4637 frames size_hint to set minimum and natural (Bug#8919).
4638 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4639 and use min_width/height from frames size_hint to set
4640 min_width/height (Bug#8919).
4642 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4643 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4646 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4648 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4649 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4652 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4654 * process.c (wait_reading_process_output): Bypass select if
4655 waiting for a cell while ignoring keyboard input, and input is
4656 pending. Suggested by Jan Djärv (Bug#8869).
4658 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4660 Use gnulib's dup2 module instead of rolling our own.
4661 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4663 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4665 * dispnew.c (scrolling_window): Before scrolling, turn off a
4666 mouse-highlight in the window being scrolled.
4668 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4670 Move DEFSYM to lisp.h and use everywhere.
4672 * character.h (DEFSYM): Move declaration...
4673 * lisp.h (DEFSYM): ...here.
4679 * w32select.c: Don't include character.h.
4681 * alloc.c (syms_of_alloc):
4682 * buffer.c (syms_of_buffer):
4683 * bytecode.c (syms_of_bytecode):
4684 * callint.c (syms_of_callint):
4685 * casefiddle.c (syms_of_casefiddle):
4686 * casetab.c (init_casetab_once):
4687 * category.c (init_category_once, syms_of_category):
4688 * ccl.c (syms_of_ccl):
4689 * cmds.c (syms_of_cmds):
4690 * composite.c (syms_of_composite):
4691 * dbusbind.c (syms_of_dbusbind):
4692 * dired.c (syms_of_dired):
4693 * dispnew.c (syms_of_display):
4694 * doc.c (syms_of_doc):
4695 * editfns.c (syms_of_editfns):
4696 * emacs.c (syms_of_emacs):
4697 * eval.c (syms_of_eval):
4698 * fileio.c (syms_of_fileio):
4699 * fns.c (syms_of_fns):
4700 * frame.c (syms_of_frame):
4701 * fringe.c (syms_of_fringe):
4702 * insdel.c (syms_of_insdel):
4703 * keymap.c (syms_of_keymap):
4704 * lread.c (init_obarray, syms_of_lread):
4705 * macros.c (syms_of_macros):
4706 * msdos.c (syms_of_msdos):
4707 * print.c (syms_of_print):
4708 * process.c (syms_of_process):
4709 * search.c (syms_of_search):
4710 * sound.c (syms_of_sound):
4711 * syntax.c (init_syntax_once, syms_of_syntax):
4712 * terminal.c (syms_of_terminal):
4713 * textprop.c (syms_of_textprop):
4714 * undo.c (syms_of_undo):
4715 * w32.c (globals_of_w32):
4716 * window.c (syms_of_window):
4717 * xdisp.c (syms_of_xdisp):
4718 * xfaces.c (syms_of_xfaces):
4719 * xfns.c (syms_of_xfns):
4720 * xmenu.c (syms_of_xmenu):
4721 * xsettings.c (syms_of_xsettings):
4722 * xterm.c (syms_of_xterm): Use DEFSYM.
4724 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4726 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4728 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4730 Integer and buffer overflow fixes (Bug#8873).
4732 * print.c (printchar, strout): Check for string overflow.
4733 (PRINTPREPARE, printchar, strout):
4734 Don't set size unless allocation succeeds.
4736 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4737 for sizes. Check for string overflow more accurately.
4738 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4740 * macros.c: Integer and buffer overflow fixes.
4741 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4742 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4743 Use ptrdiff_t, not int, for sizes.
4744 Don't increment bufsize until after realloc succeeds.
4745 Check for size-calculation overflow.
4746 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4748 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4750 * lread.c: Integer overflow fixes.
4751 (read_integer): Radix is now EMACS_INT, not int,
4752 to improve quality of diagnostics for out-of-range radices.
4753 Calculate buffer size correctly for out-of-range radices.
4754 (read1): Check for integer overflow in radices, and in
4755 read-circle numbers.
4756 (read_escape): Avoid int overflow.
4757 (Fload, openp, read_buffer_size, read1)
4758 (substitute_object_recurse, read_vector, read_list, map_obarray):
4759 Use ptrdiff_t, not int, for sizes.
4760 (read1): Use EMACS_INT, not int, for sizes.
4761 Check for size overflow.
4763 * image.c (cache_image): Check for size arithmetic overflow.
4765 * lread.c: Integer overflow issues.
4766 (saved_doc_string_size, saved_doc_string_length)
4767 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4768 Now ptrdiff_t, not int.
4769 (read1): Don't assume doc string length fits in int. Check for
4770 out-of-range doc string lengths.
4771 (read_list): Don't assume file position fits in int.
4772 (read_escape): Check for hex character overflow.
4774 2011-06-22 Leo Liu <sdl.web@gmail.com>
4776 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4777 Move to minibuffer.el.
4779 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4781 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4782 The following patches are for when GLYPH_DEBUG && !XASSERT.
4783 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4784 * dispnew.c (flush_stdout):
4785 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4786 Mark as externally visible.
4787 * dispnew.c (check_window_matrix_pointers): Now static.
4788 * dispnew.c (window_to_frame_vpos):
4789 * xfns.c (unwind_create_frame):
4790 * xterm.c (x_check_font): Remove unused local.
4791 * scroll.c (CHECK_BOUNDS):
4792 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4793 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4794 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4795 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4796 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4798 (debug_method_add): Use va_list and vsprintf rather than relying
4799 on undefined behavior with wrong number of arguments.
4800 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4801 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4802 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4803 since we're not interested in debugging glyphs with old libraries.
4804 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4805 GCC 4.6.0's static checking.
4807 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4809 Integer overflow and signedness fixes (Bug#8873).
4810 A few related buffer overrun fixes, too.
4812 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4814 * dispextern.h (struct face.stipple):
4815 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4816 (x_bitmap_mask, x_allocate_bitmap_record)
4817 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4818 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4819 (x_create_bitmap_from_xpm_data):
4820 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4821 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4823 * xfaces.c (load_pixmap):
4824 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4825 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4826 (.bitmaps_last, struct x_output.icon_bitmap):
4827 Use ptrdiff_t, not int, for bitmap indexes.
4828 (x_allocate_bitmap_record): Check for size overflow.
4829 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4831 Use ptrdiff_t, not int, for overlay counts.
4832 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4833 * editfns.c (overlays_around, get_pos_property):
4834 * textprop.c (get_char_property_and_overlay):
4835 * xdisp.c (next_overlay_change, note_mouse_highlight):
4836 * xfaces.c (face_at_buffer_position):
4837 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4838 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4839 (Fnext_overlay_change, Fprevious_overlay_change)
4840 (mouse_face_overlay_overlaps, Foverlays_in):
4841 Use ptrdiff_t, not int, for sizes.
4842 (overlays_at, overlays_in): Check for size-calculation overflow.
4844 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4846 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4847 (x_session_initialize): Do not assume string length fits in int.
4849 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4850 This is unlikely, but can occur if DPI is outlandish.
4852 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4853 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4855 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4856 * xrdb.c (magic_file_p, search_magic_path):
4857 Omit last arg SUFFIX; it was always 0. All callers changed.
4858 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4860 * xfont.c (xfont_match): Avoid need for strlen.
4862 * xfns.c: Don't assume strlen fits in int.
4863 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4865 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4866 not unsigned long, as we prefer signed integers. All callers changed.
4867 Detect integer overflow in repeat count.
4868 (message_dolog): Don't assume print length fits in 39 bytes.
4869 (display_mode_element): Don't assume strlen fits in int.
4871 * termcap.c: Don't assume sizes fit in int and never overflow.
4872 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4873 (gobble_line): Check for size-calculation overflow.
4875 * minibuf.c (Fread_buffer):
4876 * lread.c (intern, intern_c_string):
4877 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4878 Don't assume string length fits in int.
4880 * keyboard.c (parse_tool_bar_item):
4881 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4883 * font.c: Don't assume string length fits in int.
4884 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4885 Use ptrdiff_t, not int.
4886 (font_intern_prop): Don't assume string length fits in int.
4887 Don't assume integer property fits in fixnum.
4888 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4890 * filelock.c: Fix some buffer overrun and integer overflow issues.
4891 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4892 Reformulate so as not to need the command string.
4893 Invoke gzip -cd rather than gunzip, as it's more portable.
4894 (lock_info_type, lock_file_1, lock_file):
4895 Don't assume pid_t and time_t fit in unsigned long.
4896 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4897 (current_lock_owner): Prefer signed type for sizes.
4898 Use memcpy, not strncpy, where memcpy is what is really wanted.
4899 Don't assume (via atoi) that time_t and pid_t fit in int.
4900 Check for time_t and/or pid_t out of range, e.g., via a network share.
4901 Don't alloca where an auto var works fine.
4903 * fileio.c: Fix some integer overflow issues.
4904 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4905 Don't assume string length fits in int.
4906 (directory_file_name): Don't assume string length fits in long.
4907 (make_temp_name): Don't assume pid fits in int, or that its print
4908 length is less than 20.
4910 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4912 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4914 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4916 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4917 We prefer signed integers, even for size calculations.
4919 * emacs.c: Don't assume string length fits in 'int'.
4920 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4921 (main): Don't invoke strlen when not needed.
4923 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4924 (XD_DEBUG_MESSAGE): Don't waste a byte.
4926 * callproc.c (getenv_internal_1, getenv_internal)
4928 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4930 * lread.c (invalid_syntax): Omit length argument.
4931 All uses changed. This doesn't fix a bug, but it simplifies the
4932 code away from its former Hollerith-constant appearance, and it's
4933 one less 'int' to worry about when looking at integer-overflow issues.
4934 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4936 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4937 This didn't break anything, but it didn't help either.
4938 It's confusing to put a bogus integer in a place where the actual
4939 value does not matter.
4940 (LIST_END_P): Remove unused macro and its bogus comment.
4941 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4943 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4944 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4946 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4947 We prefer signed types, and the value cannot exceed the EMACS_INT
4948 range anyway (because otherwise the length would not be representable).
4949 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4950 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4951 This avoids a GCC warning when WIDE_EMACS_INT.
4953 * indent.c (sane_tab_width): New function.
4954 (current_column, scan_for_column, Findent_to, position_indentation)
4955 (compute_motion): Use it. This is just for clarity.
4956 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4958 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4960 * lisp.h (lint_assume): New macro.
4961 * composite.c (composition_gstring_put_cache):
4962 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4964 * editfns.c, insdel.c:
4965 Omit unnecessary forward decls, to simplify future changes.
4967 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4969 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4971 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4972 Use much-faster test for byte-length change.
4973 Don't assume string byte-length fits in 'int'.
4974 Check that character arg fits in 'int'.
4975 (mapcar1): Declare byte as byte, for clarity.
4977 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4979 * fns.c (concat): Catch string overflow earlier.
4980 Do not rely on integer wraparound.
4982 * dispextern.h (struct it.overlay_strings_charpos)
4983 (struct it.selective): Now EMACS_INT, not int.
4984 * xdisp.c (forward_to_next_line_start)
4985 (back_to_previous_visible_line_start)
4986 (reseat_at_next_visible_line_start, next_element_from_buffer):
4987 Don't arbitrarily truncate the value of 'selective' to int.
4989 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4991 * composite.c: Don't truncate sizes to 'int'.
4992 (composition_gstring_p, composition_reseat_it)
4993 (composition_adjust_point): Use EMACS_INT, not int.
4994 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4995 not EMACS_UINT, for indexes.
4997 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4999 * buffer.c: Include <verify.h>.
5000 (struct sortvec.priority, struct sortstr.priority):
5001 Now EMACS_INT, not int.
5002 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5003 (struct sortstr.size, record_overlay_string)
5004 (struct sortstrlist.size, struct sortlist.used):
5005 Don't truncate size to int.
5006 (record_overlay_string): Check for size-calculation overflow.
5007 (init_buffer_once): Check at compile-time, not run-time.
5009 2011-06-22 Jim Meyering <meyering@redhat.com>
5011 Don't leak an XBM-image-sized buffer
5012 * image.c (xbm_load): Free the image buffer after using it.
5014 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5017 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5018 that Sun C diagnosed.
5019 * fns.c (secure_hash): Fix pointer signedness issue.
5020 * intervals.c (static_offset_intervals): New function.
5021 (offset_intervals): Use it.
5023 2011-06-21 Leo Liu <sdl.web@gmail.com>
5026 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5029 * fns.c (secure_hash): Rename from crypto_hash_function and change
5030 the first arg to accept symbols.
5031 (Fsecure_hash): New primitive.
5032 (syms_of_fns): New symbols.
5034 2011-06-20 Deniz Dogan <deniz@dogan.se>
5036 * process.c (Fset_process_buffer): Clarify return value in
5039 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5041 * dispnew.c (add_window_display_history): Use BVAR.
5043 * xdisp.c (debug_method_add): Use BVAR.
5044 (check_window_end, dump_glyph_matrix, dump_glyph)
5045 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5047 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5050 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5051 check till after the cache is created in init_frame_faces.
5053 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5055 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5057 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5059 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5060 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5061 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5063 Improve buffer-overflow checking (Bug#8873).
5064 * fileio.c (Finsert_file_contents):
5065 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5066 Remove the old (too-loose) buffer overflow checks.
5067 They weren't needed, since make_gap checks for buffer overflow.
5068 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5069 The old code merely checked for Emacs fixnum overflow, and relied
5070 on undefined (wraparound) behavior. The new code avoids undefined
5071 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5073 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5074 Tune. Don't use wider integers than needed. Don't use alloca.
5075 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5077 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5079 * insdel.c, lisp.h (buffer_overflow): New function.
5080 (insert_from_buffer_1, replace_range, replace_range_2):
5081 * insdel.c (make_gap_larger):
5082 * editfns.c (Finsert_char):
5083 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5085 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5087 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5089 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5091 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5092 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5094 * fileio.c: Don't assume EMACS_INT fits in off_t.
5095 (emacs_lseek): New static function.
5096 (Finsert_file_contents, Fwrite_region): Use it.
5097 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5099 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5101 * fns.c: Don't overflow int when computing a list length.
5102 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5103 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5104 truncation on 64-bit hosts. Check for QUIT every
5105 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5106 faster and is responsive enough.
5107 (Flength): Report an error instead of overflowing an integer.
5108 (Fsafe_length): Return a float if the value is not representable
5109 as a fixnum. This shouldn't happen except in contrived situations.
5110 (Fnthcdr, Fsort): Don't assume list length fits in int.
5111 (Fcopy_sequence): Don't assume vector length fits in int.
5113 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5114 (header_size, word_size): New constants.
5115 (allocate_vectorlike): Don't check size overflow here.
5116 (allocate_vector): Check it here instead, since this is the only
5117 caller of allocate_vectorlike that could cause overflow.
5118 Check that the new vector's length is representable as a fixnum.
5120 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5121 The previous code was bogus. For example, next_almost_prime (32)
5122 returned 39, which is undesirable as it is a multiple of 3; and
5123 next_almost_prime (24) returned 25, which is a multiple of 5 so
5124 why was the code bothering to check for multiples of 7?
5126 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5128 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5130 Variadic C functions now count arguments with ptrdiff_t.
5131 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5132 Back then I didn't know that the Emacs coding style prefers signed int.
5133 Also, in the meantime I found a few more instances where arguments
5134 were being counted with int, which may truncate counts on 64-bit
5135 machines, or EMACS_INT, which may be unnecessarily wide.
5136 * lisp.h (struct Lisp_Subr.function.aMANY)
5137 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5138 Arg counts are now ptrdiff_t, not size_t.
5139 All variadic functions and their callers changed accordingly.
5140 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5141 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5142 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5143 * callint.c (Fcall_interactively): Check arg count for overflow,
5144 to avoid potential buffer overrun. Use signed char, not 'int',
5145 for 'varies' array, so that we needn't bother to check its size
5146 calculation for overflow.
5147 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5148 * eval.c (apply_lambda):
5149 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5150 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5151 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5153 * callint.c (Fcall_interactively): Don't use index var as event count.
5155 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5156 * mem-limits.h (SIZE): Remove; no longer used.
5158 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5160 Remove unnecessary casts.
5161 * xterm.c (x_term_init):
5162 * xfns.c (x_set_border_pixel):
5163 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5164 These aren't needed now that we assume ANSI C.
5166 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5167 It's more likely to cause problems (due to unsigned overflow)
5170 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5172 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5174 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5176 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5178 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5180 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5182 GLYPH_CODE_FACE returns EMACS_INT, not int.
5183 * dispextern.h (merge_faces):
5184 * xfaces.c (merge_faces):
5185 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5186 Don't assume EMACS_INT fits in int.
5188 * character.h (CHAR_VALID_P): Remove unused parameter.
5189 * fontset.c, lisp.h, xdisp.c: All uses changed.
5191 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5193 * fns.c (concat): Minor tuning based on overflow analysis.
5194 This doesn't fix any bugs. Use int to hold character, instead
5195 of constantly refetching from Emacs object. Use XFASTINT, not
5196 XINT, for value known to be a character. Don't bother comparing
5197 a single byte to 0400, as it's always less.
5199 * floatfns.c (Fexpt):
5200 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5202 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5205 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5207 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5208 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5209 incorrectly succeed when S was a string, because 4294967386 was
5210 truncated before it was used.
5212 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5213 Otherwise, an out-of-range integer could cause undefined behavior
5216 * composite.c: Use int, not EMACS_INT, for characters.
5217 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5218 EMACS_INT, for values that are known to be in character range.
5219 This doesn't fix any bugs but is the usual style inside Emacs and
5220 may generate better code on 32-bit machines.
5222 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5223 This is for reasons similar to the recent CHAR_STRING fix.
5224 * charset.c (Fencode_char): Check that character arg is actually
5225 a character. Pass an int to ENCODE_CHAR.
5226 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5227 wider than 'int', as a compile-time check to prevent future regressions
5230 * character.c (char_string): Remove unnecessary casts.
5232 Make sure a 64-bit char is never passed to CHAR_STRING.
5233 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5234 by silently ignoring the top 32 bits, allowing some values
5235 that were far too large to be valid characters.
5236 * character.h: Include <verify.h>.
5237 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5238 arguments are no wider than unsigned, as a compile-time check
5239 to prevent future regressions in this area.
5241 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5242 (Fsubst_char_in_region):
5244 * xdisp.c (decode_mode_spec_coding):
5245 Adjust to CHAR_STRING's new requirement.
5246 * editfns.c (Finsert_char, Fsubst_char_in_region):
5247 * fns.c (concat): Check that character args are actually
5248 characters. Without this test, these functions did the wrong
5249 thing with wildly out-of-range values on 64-bit hosts.
5251 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5252 These casts should not be needed on 32-bit hosts, either.
5253 * keyboard.c (read_char):
5254 * lread.c (Fload): Remove casts to unsigned.
5256 * lisp.h (UNSIGNED_CMP): New macro.
5257 This fixes comparison bugs on 64-bit hosts.
5258 (ASCII_CHAR_P): Use it.
5259 * casefiddle.c (casify_object):
5260 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5261 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5262 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5263 * dispextern.h (FACE_FROM_ID):
5264 * keyboard.c (read_char): Use UNSIGNED_CMP.
5266 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5267 not to EMACS_INT, to avoid GCC warning.
5269 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5271 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5272 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5273 isn't needed on 32-bit machines.
5275 * buffer.c (Fgenerate_new_buffer_name):
5276 Use EMACS_INT for count, not int.
5277 (advance_to_char_boundary): Return EMACS_INT, not int.
5279 * data.c (Qcompiled_function): Now static.
5281 * window.c (window_body_lines): Now static.
5283 * image.c (gif_load): Rename local to avoid shadowing.
5285 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5286 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5287 * alloc.c (make_save_value): Integer argument is now of type
5289 (mark_object): Use ptrdiff_t, not int.
5290 * lisp.h (pD): New macro.
5291 * print.c (print_object): Use it.
5293 * alloc.c: Use EMACS_INT, not int, to count objects.
5294 (total_conses, total_markers, total_symbols, total_vector_size)
5295 (total_free_conses, total_free_markers, total_free_symbols)
5296 (total_free_floats, total_floats, total_free_intervals)
5297 (total_intervals, total_strings, total_free_strings):
5298 Now EMACS_INT, not int. All uses changed.
5299 (Fgarbage_collect): Compute overall total using a double, so that
5300 integer overflow is less likely to be a problem. Check for overflow
5301 when converting back to an integer.
5302 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5303 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5304 These were 'int' variables that could overflow on 64-bit hosts;
5305 they were never used, so remove them instead of repairing them.
5306 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5307 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5308 Previously, this ceilinged at INT_MAX, but that doesn't work on
5310 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5312 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5313 (allocate_vectorlike): Check for ptrdiff_t overflow.
5314 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5315 when a (possibly-narrower) signed value would do just as well.
5316 We prefer using signed arithmetic, to avoid comparison confusion.
5318 * alloc.c: Catch some string size overflows that we were missing.
5319 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5320 for convenience in STRING_BYTES_MAX.
5321 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5322 The definition here is exact; the one in lisp.h was approximate.
5323 (allocate_string_data): Check for string overflow. This catches
5324 some instances we weren't catching before. Also, it catches
5325 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5326 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5327 and ptrdiff_t and EMACS_INT are both 64 bits.
5329 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5330 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5331 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5333 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5335 * alloc.c (Fmake_string): Check for out-of-range init.
5337 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5339 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5341 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5343 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5344 xg_get_default_scrollbar_width.
5346 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5347 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5348 (style_changed_cb): Call update_theme_scrollbar_width and call
5349 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5350 all frames (Bug#8505).
5351 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5352 Call gtk_window_set_resizable if HAVE_GTK3.
5353 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5354 and height if HAVE_GTK3 (Bug#8505).
5355 (scroll_bar_width_for_theme): New variable.
5356 (update_theme_scrollbar_width): New function.
5357 (xg_get_default_scrollbar_width): Move code to
5358 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5359 (xg_initialize): Call update_theme_scrollbar_width.
5361 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5363 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5365 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5367 * frame.c (make_frame): Call other_buffer_safely instead of
5370 * window.c (temp_output_buffer_show): Call display_buffer with
5371 second argument Vtemp_buffer_show_specifiers and reset latter
5372 immediately after the call.
5373 (Vtemp_buffer_show_specifiers): New variable.
5374 (auto_window_vscroll_p, next_screen_context_lines)
5375 (Vscroll_preserve_screen_position): Remove leading asterisks from
5378 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5380 Fix minor problems found by GCC 4.6.0 static checking.
5381 * buffer.c (Qclone_number): Remove for now, as it's unused.
5382 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5383 (record_buffer): Remove unused local.
5384 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5385 (set_frame_buffer_list): Remove; unused.
5386 * frame.h (other_visible_frames): Remove decl.
5387 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5388 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5389 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5391 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5392 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5393 Define only if HAVE_GPM.
5394 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5395 (update_hints_inhibit): Remove; never set. All uses removed.
5396 * widgetprv.h (emacsFrameClassRec): Remove decl.
5397 * window.c (delete_deletable_window): Now returns void, since it
5398 wasn't returning anything.
5399 (compare_window_configurations): Remove unused locals.
5400 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5401 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5402 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5403 the same widths as pointers. This follows up on the 2011-05-06 patch.
5404 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5405 * xterm.h: Likewise.
5406 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5408 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5410 * makefile.w32-in: Update dependencies.
5411 (LISP_H): Add lib/intprops.h.
5413 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5415 * image.c (gif_load): Add animation frame delay to the metadata.
5416 (syms_of_image): Use DEFSYM. New symbol `delay'.
5418 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5420 * window.c (delete_deletable_window): Re-add.
5421 (Fset_window_configuration): Rewrite to handle dead buffers and
5422 consequently deletable windows.
5423 (window_tree, Fwindow_tree): Remove. Supply functionality in
5425 (compare_window_configurations): Simplify code.
5427 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5429 * image.c (imagemagick_load_image): Fix type mismatch.
5430 (Fimagemagick_types): Likewise.
5432 * window.h (replace_buffer_in_windows): Declare.
5434 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5436 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5437 Qclone_number. Remove external declaration of Qdelete_window.
5438 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5440 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5441 Run Qbuffer_list_update_hook if allowed.
5442 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5443 buffer list implementation.
5444 (other_buffer_safely): New function.
5445 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5446 calls to replace_buffer_in_windows and
5447 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5449 (record_buffer): Inhibit quitting and rewrite using quittable
5450 functions. Run Qbuffer_list_update_hook if allowed.
5451 (Frecord_buffer, Funrecord_buffer): New functions.
5452 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5453 Move switch-to-buffer to window.el.
5454 (bury-buffer): Move to window.el.
5455 (Vbuffer_list_update_hook): New variable.
5457 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5460 * window.h (resize_frame_windows): Move up in code.
5461 (Fwindow_frame): Remove EXFUN.
5462 (replace_buffer_in_all_windows): Remove prototype.
5463 (replace_buffer_in_windows_safely): Add prototype.
5465 * window.c: Declare Qdelete_window static again. Move down
5466 declaration of select_count.
5467 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5468 (Fother_window): Move to window.el.
5469 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5470 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5471 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5473 (replace_buffer_in_windows): Implement by calling
5474 Qreplace_buffer_in_windows.
5475 (replace_buffer_in_all_windows): Remove with some functionality
5476 moved into replace_buffer_in_windows_safely.
5477 (replace_buffer_in_windows_safely): New function.
5478 (select_window_norecord, select_frame_norecord): Move in front
5479 of run_window_configuration_change_hook. Remove now obsolete
5481 (Fset_window_buffer): Rewrite doc-string.
5482 Call Qrecord_window_buffer.
5483 (keys_of_window): Move binding for other-window to window.el.
5485 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5487 * dispextern.h (struct image): Replace data member, whose int_val
5488 and ptr_val fields were not used by anything, with a single
5491 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5492 (gif_clear_image, gif_load, imagemagick_load_image)
5493 (gs_clear_image, gs_load): Callers changed.
5495 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5497 * buffer.h: Include <time.h>, for time_t.
5498 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5500 Fix minor problems found by static checking.
5502 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5504 Make identifiers static if they are not used in other modules.
5505 * data.c (Qcompiled_function, Qframe, Qvector):
5506 * image.c (QimageMagick, Qsvg):
5507 * minibuf.c (Qmetadata):
5508 * window.c (resize_window_check, resize_root_window): Now static.
5509 * window.h (resize_window_check, resize_root_window): Remove decls.
5511 * window.c (window_deletion_count, delete_deletable_window):
5513 (window_body_lines): Now static.
5514 (Fdelete_other_windows_internal): Mark vars as initialized.
5515 Make sure 'resize_failed' is initialized.
5516 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5517 (resize_window_apply): Remove unused local.
5518 * window.h (delete_deletable_window): Remove decl.
5520 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5521 (imagemagick_load_image): Fix pointer signedness problem by changing
5522 last arg from unsigned char * to char *. All uses changed.
5523 Also, fix a local for similar reasons.
5524 Remove unused locals. Remove locals to avoid shadowing.
5525 (fn_rsvg_handle_free): Remove; unused.
5526 (svg_load, svg_load_image): Fix pointer signedness problem.
5527 (imagemagick_load_image): Don't use garbage pointer image_wand.
5529 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5531 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5533 * image.c (gif_load): Fix omitted cast error introduced by
5536 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5538 * window.h (resize_proportionally, orig_total_lines)
5539 (orig_top_line): Remove from window structure.
5540 (set_window_height, set_window_width, change_window_heights)
5541 (Fdelete_window): Remove prototypes.
5542 (resize_frame_windows): Remove duplicate declaration.
5544 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5546 * window.h (resize_frame_windows, resize_window_check)
5547 (delete_deletable_window, resize_root_window)
5548 (resize_frame_windows): Declare prototypes.
5550 * window.c (resize_window_apply): Make definition be "static" to
5551 match the prototype.
5553 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5555 * window.c: Remove declarations of Qwindow_size_fixed,
5556 window_min_size_1, window_min_size_2, window_min_size,
5557 size_window, window_fixed_size_p, enlarge_window, delete_window.
5558 Remove static from declaration of Qdelete_window, it's
5559 temporarily needed by Fbury_buffer.
5560 (replace_window): Don't assign orig_top_line and
5562 (Fdelete_window, delete_window): Remove. Window deletion is
5563 handled by window.el.
5564 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5565 Replace Fdelete_window calls with calls to Qdelete_window.
5566 (Fdelete_other_windows): Remove. Deleting other windows is
5567 handled by window.el.
5568 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5569 handled in window.el.
5570 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5571 Window minimum sizes are handled in window.el.
5572 (shrink_windows, size_window, set_window_height)
5573 (set_window_width, change_window_heights, window_height)
5574 (window_width, CURBEG, CURSIZE, enlarge_window)
5575 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5576 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5577 handled in window.el.
5578 (make_dummy_parent): Rename to make_parent_window and give it a
5579 second argument horflag.
5580 (make_window): Don't set resize_proportionally any more.
5581 (Fsplit_window): Remove. Windows are split in window.el.
5582 (save_restore_action, save_restore_orig_size)
5583 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5584 Resize mini windows in window.el.
5585 (grow_mini_window, shrink_mini_window): Implement by calling
5586 Qresize_root_window_vertically, resize_window_check and
5587 resize_window_apply.
5588 (saved_window, Fset_window_configuration, save_window_save):
5589 Do not handle orig_top_line, orig_total_lines, and
5590 resize_proportionally.
5591 (window_min_height, window_min_width): Move to window.el.
5592 (keys_of_window): Move bindings for delete-other-windows,
5593 split-window, delete-window and enlarge-window to window.el.
5595 * buffer.c: Temporarily extern Qdelete_window.
5596 (Fbury_buffer): Temporarily call Qdelete_window instead of
5597 Fdelete_window (Fbury_buffer will move to window.el soon).
5599 * frame.c (set_menu_bar_lines_1): Remove code handling
5600 orig_top_line and orig_total_lines.
5602 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5603 set_window_height but set heights directly.
5604 (change_frame_size_1): Use resize_frame_windows.
5606 * xdisp.c (init_xdisp): Don't use set_window_height but set
5609 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5610 Use resize_frame_windows instead of change_window_heights and run
5611 run_window_configuration_change_hook.
5613 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5614 instead of change_window_heights and run
5615 run_window_configuration_change_hook.
5617 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5619 * window.c (replace_window): Rename second argument REPLACEMENT to
5620 NEW. New third argument SETFLAG. Rewrite.
5621 (delete_window, make_dummy_parent): Call replace_window with
5623 (window_list_1): Move down in code.
5624 (run_window_configuration_change_hook): Move set_buffer part
5625 before select_frame_norecord part in order to unwind correctly.
5626 Rename count1 to count.
5627 (recombine_windows, delete_deletable_window, resize_root_window)
5628 (Fdelete_other_windows_internal)
5629 (Frun_window_configuration_change_hook, make_parent_window)
5630 (resize_window_check, resize_window_apply, Fresize_window_apply)
5631 (resize_frame_windows, Fsplit_window_internal)
5632 (Fdelete_window_internal, Fresize_mini_window_internal):
5634 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5636 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5638 * window.h (window): Add some new members to window structure -
5639 normal_lines, normal_cols, new_total, new_normal, clone_number,
5640 splits, nest, prev_buffers, next_buffers.
5641 (WINDOW_TOTAL_SIZE): Move here from window.c.
5642 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5644 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5646 (make_dummy_parent): Set new members of windows structure.
5647 (make_window): Move down in code. Handle new members of window
5649 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5650 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5651 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5652 (Fset_window_prev_buffers, Fwindow_next_buffers)
5653 (Fset_window_next_buffers, Fset_window_clone_number):
5655 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5656 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5658 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5659 Argument WINDOW can be now internal window too.
5660 (Fwindow_use_time): Move up in code.
5661 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5663 (Fset_window_configuration, saved_window)
5664 (Fcurrent_window_configuration, save_window_save): Handle new
5665 members of window structure.
5666 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5667 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5668 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5669 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5670 Qget_mru_window, Qresize_root_window,
5671 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5672 Qauto_buffer_name; staticpro them.
5674 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5676 * window.c (Fwindow_total_size, Fwindow_left_column)
5677 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5678 (Fwindow_list_1): New functions.
5679 (window_box_text_cols): Replace with window_body_cols.
5680 (Fwindow_width, Fscroll_left, Fscroll_right):
5681 Use window_body_cols instead of window_box_text_cols.
5682 (delete_window, Fset_window_configuration):
5683 Call delete_all_subwindows with window as argument.
5684 (delete_all_subwindows): Take a window as argument and not a
5686 (window_loop): Remove handling of GET_LRU_WINDOW and
5688 (Fget_lru_window, Fget_largest_window): Move to window.el.
5690 * window.h: Extern window_body_cols instead of
5691 window_box_text_cols. delete_all_subwindows now takes a
5692 Lisp_Object as argument.
5694 * indent.c (compute_motion, Fcompute_motion):
5695 Use window_body_cols instead of window_box_text_cols.
5697 * frame.c (delete_frame): Call delete_all_subwindows with root
5700 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5702 * fns.c (Fputhash): Document return value.
5704 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5706 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5708 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5710 Cons<->int and similar integer overflow fixes (Bug#8794).
5712 Check for overflow when converting integer to cons and back.
5713 * charset.c (Fdefine_charset_internal, Fdecode_char):
5714 Use cons_to_unsigned to catch overflow.
5715 (Fencode_char): Use INTEGER_TO_CONS.
5716 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5717 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5718 * data.c (long_to_cons, cons_to_long): Remove.
5719 (cons_to_unsigned, cons_to_signed): New functions.
5720 These signal an error for invalid or out-of-range values.
5721 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5722 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5723 * font.c (Ffont_variation_glyphs):
5724 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5725 * lisp.h: Include <intprops.h>.
5726 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5727 (cons_to_signed, cons_to_unsigned): New decls.
5728 (long_to_cons, cons_to_long): Remove decls.
5729 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5730 (Fprimitive_undo): Use CONS_TO_INTEGER.
5731 * xfns.c (Fx_window_property): Likewise.
5732 * xselect.c: Include <limits.h>.
5733 (x_own_selection, selection_data_to_lisp_data):
5734 Use INTEGER_TO_CONS.
5735 (x_handle_selection_request, x_handle_selection_clear)
5736 (x_get_foreign_selection, Fx_disown_selection_internal)
5737 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5738 (lisp_data_to_selection_data): Use cons_to_unsigned.
5739 (x_fill_property_data): Use cons_to_signed.
5740 Report values out of range.
5742 Check for buffer and string overflow more precisely.
5743 * buffer.h (BUF_BYTES_MAX): New macro.
5744 * lisp.h (STRING_BYTES_MAX): New macro.
5745 * alloc.c (Fmake_string):
5746 * character.c (string_escape_byte8):
5747 * coding.c (coding_alloc_by_realloc):
5748 * doprnt.c (doprnt):
5749 * editfns.c (Fformat):
5751 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5752 since they may not be the same number.
5753 * editfns.c (Finsert_char):
5754 * fileio.c (Finsert_file_contents):
5755 Likewise for BUF_BYTES_MAX.
5757 * image.c: Use ptrdiff_t, not int, for sizes.
5758 (slurp_file): Switch from int to ptrdiff_t.
5760 (slurp_file): Check that file size fits in both size_t (for
5761 malloc) and ptrdiff_t (for sanity and safety).
5763 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5764 if b->modtime has its maximal value.
5766 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5768 Don't assume time_t can fit into int.
5769 * buffer.h (struct buffer.modtime): Now time_t, not int.
5770 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5771 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5773 Minor fixes for signed vs unsigned integers.
5774 * character.h (MAYBE_UNIFY_CHAR):
5775 * charset.c (maybe_unify_char):
5776 * keyboard.c (read_char, reorder_modifiers):
5777 XINT -> XFASTINT, since the integer must be nonnegative.
5778 * ftfont.c (ftfont_spec_pattern):
5779 * keymap.c (access_keymap, silly_event_symbol_error):
5780 XUINT -> XFASTINT, since the integer must be nonnegative.
5781 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5782 since it makes no difference and we prefer signed.
5783 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5784 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5787 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5789 * window.h (Fwindow_frame): Declare.
5791 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5793 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5794 (SPARE_MEMORY): Always define.
5795 (LARGE_REQUEST): Remove.
5796 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5798 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5800 * lisp.h: Move EXFUNS for Fframe_root_window,
5801 Fframe_first_window and Fset_frame_selected_window to window.h.
5803 * window.h: Move EXFUNS for Fframe_root_window,
5804 Fframe_first_window and Fset_frame_selected_window here from
5807 * frame.c (Fwindow_frame, Fframe_first_window)
5808 (Fframe_root_window, Fframe_selected_window)
5809 (Fset_frame_selected_window): Move to window.c.
5810 (Factive_minibuffer_window): Move to minibuf.c.
5811 (Fother_visible_frames_p): New function.
5813 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5815 * window.c (decode_window, decode_any_window): Move up in code.
5816 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5817 (inhibit_frame_unsplittable): Remove unused variable.
5818 (Fwindow_buffer): Move up and rewrite doc-string.
5819 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5820 (Fwindow_prev): New functions.
5821 (Fwindow_frame): Move here from frame.c. Accept any window as
5823 (Fframe_root_window, Fframe_first_window)
5824 (Fframe_selected_window): Move here from frame.c. Accept frame
5825 or arbitrary window as argument. Update doc-strings.
5826 (Fminibuffer_window): Move up in code.
5827 (Fwindow_minibuffer_p): Move up in code and simplify.
5828 (Fset_frame_selected_window): Move here from frame.c.
5830 (Fselected_window, select_window, Fselect_window): Move up in
5831 code. Minor doc-string fixes.
5833 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5835 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5836 Do not assume that spare memory exists; that assumption is valid
5837 only if SYSTEM_MALLOC.
5838 (LARGE_REQUEST): New macro, so that the issue of large requests
5839 is separated from the issue of spare memory.
5841 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5843 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5846 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5848 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5851 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5853 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5855 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5857 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5858 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5860 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5862 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5864 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5866 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5867 (x_clipboard_manager_save): Add return value.
5868 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5870 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5871 Obey Vx_select_enable_clipboard_manager. Catch errors in
5872 x_clipboard_manager_save (Bug#8779).
5873 (Vx_select_enable_clipboard_manager): New variable.
5874 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5876 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5878 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5880 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5882 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5883 in the current matrix if keep_current_p is non-zero.
5885 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5887 * bidi.c (bidi_level_of_next_char): Fix last change.
5889 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5891 Support bidi reordering of text covered by display properties.
5893 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5894 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5895 (bidi_cache_search, bidi_cache_iterator_state)
5896 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5897 (bidi_level_of_next_char, bidi_move_to_visually_next):
5898 Support character positions inside a run of characters covered by a
5900 (bidi_paragraph_init, bidi_resolve_explicit_1)
5901 (bidi_level_of_next_char): Call bidi_fetch_char and
5902 bidi_fetch_char_advance instead of FETCH_CHAR and
5904 (bidi_init_it): Initialize new members.
5905 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5907 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5908 instead of using explicit *_CHAR codes.
5909 (bidi_resolve_explicit, bidi_resolve_weak):
5910 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5911 bidirectional text is supported only in multibyte buffers.
5912 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5913 it to initialize the frame_window_p member of struct bidi_it.
5914 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5915 (bidi_resolve_explicit, bidi_resolve_weak)
5916 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5917 bidi_it->nchars is non-positive.
5918 (bidi_level_of_next_char): Don't try to lookup the cache for the
5919 next/previous character if nothing is cached there yet, or if we
5920 were just reseat()'ed to a new position.
5922 * xdisp.c (set_cursor_from_row): Set start and stop points
5923 according to the row's direction when priming the loop that looks
5924 for the glyph on which to display cursor.
5925 (single_display_spec_intangible_p): Function deleted.
5926 (display_prop_intangible_p): Reimplement to call
5927 handle_display_spec instead of single_display_spec_intangible_p.
5928 Accept 3 additional arguments needed by handle_display_spec.
5929 This fixes incorrect cursor motion across display property with complex
5930 values: lists, `(when COND...)' forms, etc.
5931 (single_display_spec_string_p): Support property values that are
5932 lists with the argument STRING its top-level element.
5933 (display_prop_string_p): Fix the condition for processing a
5934 property that is a list to be consistent with handle_display_spec.
5935 (handle_display_spec): New function, refactored from the
5936 last portion of handle_display_prop.
5937 (compute_display_string_pos): Accept additional argument
5938 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5939 value of a `display' property is a "replacing spec".
5940 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5941 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5942 the display property, but just return a value indicating whether
5943 the display property will replace the characters it covers.
5944 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5945 frame_window_p members of struct bidi_it.
5946 (compute_display_string_pos, compute_display_string_end):
5948 (push_it): Accept second argument POSITION, where pop_it should
5949 jump to continue iteration.
5950 (reseat_1): Initialize bidi_it.disp_pos.
5952 * keyboard.c (adjust_point_for_property): Adjust the call to
5953 display_prop_intangible_p to its new signature.
5955 * dispextern.h (struct bidi_it): New member frame_window_p.
5956 (bidi_init_it): Update prototypes.
5957 (display_prop_intangible_p): Update prototype.
5958 (compute_display_string_pos, compute_display_string_end):
5960 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5963 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5965 Malloc failure behavior now depends on size of allocation.
5966 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5967 * lisp.h: Change signatures accordingly.
5968 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5969 All callers changed. (Bug#8762)
5971 * gnutls.c: Use Emacs's memory allocators.
5972 Without this change, the gnutls library would invoke malloc etc.
5973 directly, which causes problems on non-SYNC_INPUT hosts, and which
5974 runs afoul of improving memory_full behavior. (Bug#8761)
5975 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5976 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5977 xfree instead of the default malloc, realloc, free.
5978 (Fgnutls_boot): No need to check for memory allocation failure,
5979 since xmalloc does that for us.
5981 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5982 * category.c (hash_get_category_set):
5983 * ccl.c (ccl_driver):
5984 * charset.c (Fdefine_charset_internal):
5985 * charset.h (struct charset.hash_index):
5986 * composite.c (get_composition_id, gstring_lookup_cache)
5987 (composition_gstring_put_cache):
5988 * composite.h (struct composition.hash_index):
5989 * dispextern.h (struct image.hash):
5990 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5991 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5992 (hashfn_equal, hashfn_user_defined, make_hash_table)
5993 (maybe_resize_hash_table, hash_lookup, hash_put)
5994 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5995 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5996 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5997 * image.c (make_image, search_image_cache, lookup_image)
5998 (xpm_put_color_table_h):
5999 * lisp.h (struct Lisp_Hash_Table):
6000 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6001 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6002 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6003 * alloc.c (allocate_vectorlike):
6004 Check for overflow in vector size calculations.
6005 * ccl.c (ccl_driver):
6006 Check for overflow when converting EMACS_INT to int.
6007 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6008 need to be updated by these changes.
6009 * fns.c (make_hash_table, maybe_resize_hash_table):
6010 Check for integer overflow with large hash tables.
6011 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6012 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6013 (SXHASH_REDUCE): New macro.
6014 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6015 Use it instead of discarding useful hash info with large hash values.
6016 (sxhash_float): New function.
6017 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6018 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6019 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6020 Rewrite to use FIXNUM_BITS, as this simplifies things.
6021 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6022 Adjust signatures to match updated version of code.
6023 (consing_since_gc): Now EMACS_INT, since a single hash table can
6024 use more than INT_MAX bytes.
6026 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6028 Make it possible to build with GCC-4.6+ -O2 -flto.
6030 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6032 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6034 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6035 Call minibuffer-inactive-mode.
6037 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6039 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6040 Update dependencies.
6042 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6044 * data.c (init_data): Remove code for UTS, this system is not
6047 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6049 Don't force ./temacs to start in terminal mode.
6051 * frame.c (make_initial_frame): Initialize faces in all cases, not
6052 only when CANNOT_DUMP is defined.
6053 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6055 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6057 * dispnew.c (add_window_display_history): Use const for the string
6058 pointer. Remove declaration, not needed.
6060 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6062 Use 'inline', not 'INLINE'.
6063 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6064 * alloc.c, fontset.c (INLINE): Remove.
6065 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6066 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6067 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6068 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6069 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6071 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6073 Make it possible to run ./temacs.
6075 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6076 syms_of_callproc does the same thing. Remove test for
6077 "initialized", do it in the caller.
6078 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6080 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6082 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6083 (read_minibuf): Use get_minibuffer.
6084 (syms_of_minibuf): Use DEFSYM.
6085 (Qmetadata): New var.
6086 * data.c (Qbuffer): Don't make it static.
6087 (syms_of_data): Use DEFSYM.
6089 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6091 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6092 (CCL_CODE_MIN): New macro.
6094 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6096 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6098 * eval.c (Qdebug): Now static.
6099 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6100 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6101 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6103 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6105 * image.c: Various fixes to ImageMagick code comments.
6106 (Fimagemagick_types): Doc fix.
6108 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6110 Minor fixes prompted by GCC 4.6.0 warnings.
6112 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6114 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6115 (x_clipboard_manager_save_all): Move extern decl to ...
6116 * xterm.h: ... here, so that it can be checked for consistency.
6118 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6120 * xselect.c (x_clipboard_manager_save_frame)
6121 (x_clipboard_manager_save_all): New functions.
6122 (Fx_clipboard_manager_save): Lisp function deleted.
6124 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6125 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6127 * xterm.h: Update prototype.
6129 2011-05-28 William Xu <william.xwl@gmail.com>
6131 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6134 2011-05-28 Jim Meyering <meyering@redhat.com>
6136 Avoid a sign-extension bug in crypto_hash_function.
6137 * fns.c (to_uchar): Define.
6138 (crypto_hash_function): Use it to convert some newly-signed
6139 variables to unsigned, to avoid sign-extension bugs. For example,
6140 without this change, (md5 "truc") would evaluate to
6141 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6142 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6143 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6145 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6147 Integer overflow fixes.
6149 * dbusbind.c: Serial number integer overflow fixes.
6150 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6151 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6152 to hold a serial number that is too large for a fixnum.
6153 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6154 Check for serial numbers out of range. Decode any serial number
6155 that was so large that it became a float. (Bug#8722)
6157 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6158 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6159 Use XFASTINT rather than XUINT when numbers are nonnegative.
6160 (xd_append_arg, Fdbus_method_return_internal):
6161 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6162 arguments, check that Lisp number is nonnegative, rather than
6163 silently wrapping negative numbers around. (Bug#8722)
6164 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6167 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6169 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6171 ccl: Add integer overflow checks.
6172 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6173 (IN_INT_RANGE): New macros.
6174 (ccl_driver): Use them to check for integer overflow when
6175 decoding a CCL program. Many of the new checks are whether XINT (x)
6176 fits in int; it doesn't always, on 64-bit hosts. The new version
6177 doesn't catch all possible integer overflows, but it's an
6178 improvement. (Bug#8719)
6180 * alloc.c (make_event_array): Use XINT, not XUINT.
6181 There's no need for unsigned here.
6183 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6184 This follows up to the 2011-05-06 change that substituted uintptr_t
6185 for EMACS_INT. This case wasn't caught back then.
6187 Rework Fformat to avoid integer overflow issues.
6188 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6189 now (part of C89). Include <verify.h>.
6190 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6191 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6192 (Fformat): Avoid the prepass trying to compute sizes; it was only
6193 approximate and thus did not catch overflow reliably. Instead, walk
6194 through the format just once, formatting and computing sizes as we go,
6195 checking for integer overflow at every step, and allocating a larger
6196 buffer as needed. Keep track separately whether the format is
6197 multibyte. Keep only the most-recently calculated precision, rather
6198 than them all. Record whether each argument has been converted to
6199 string. Use EMACS_INT, not int, for byte and char and arg counts.
6200 Support field widths and precisions larger than INT_MAX. Avoid
6201 sprintf's undefined behavior with conversion specifications such as %#d
6202 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6203 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6204 formatting out-of-range floating point numbers with int
6207 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6209 * data.c: Avoid integer truncation in expressions involving floats.
6210 * data.c: Include <intprops.h>.
6211 (arith_driver): When there's an integer overflow in an expression
6212 involving floating point, convert the integers to floating point
6213 so that the resulting value does not suffer from catastrophic
6214 integer truncation. For example, on a 64-bit host (* 4
6215 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6216 Do not rely on undefined behavior after integer overflow.
6218 merge count_size_as_multibyte, parse_str_to_multibyte
6219 * character.c, character.h (count_size_as_multibyte):
6220 Rename from parse_str_to_multibyte; all uses changed.
6221 Check for integer overflow.
6222 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6223 since it's now a duplicate of the other. This is more of
6224 a character than a buffer op, so better that it's in character.c.
6225 * fns.c, print.c: Adjust to above changes.
6227 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6229 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6231 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6233 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6234 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6235 (x_clipboard_manager_save): Now static.
6236 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6238 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6239 (crypto_hash_function): Now static.
6240 Fix pointer signedness problems. Avoid unnecessary initializations.
6242 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6244 * termhooks.h (Vselection_alist): Make it terminal-local.
6246 * terminal.c (create_terminal): Initialize it.
6248 * xselect.c: Support for clipboard managers.
6249 (Vselection_alist): Move to termhooks.h as terminal-local var.
6250 (LOCAL_SELECTION): New macro.
6251 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6252 (symbol_to_x_atom): Remove gratuitous arg.
6253 (x_handle_selection_request, lisp_data_to_selection_data)
6254 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6255 (x_own_selection, x_get_local_selection, x_convert_selection):
6256 New arg, specifying work frame. Use terminal-local Vselection_alist.
6257 (some_frame_on_display): Delete unused function.
6258 (Fx_own_selection_internal, Fx_get_selection_internal)
6259 (Fx_disown_selection_internal, Fx_selection_owner_p)
6260 (Fx_selection_exists_p): New optional frame arg.
6261 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6262 (x_handle_selection_clear): Don't treat other terminals with the
6263 same keyboard specially. Use the terminal-local Vselection_alist.
6264 (x_clear_frame_selections): Use Frun_hook_with_args.
6266 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6268 * xterm.h: Add support for those atoms.
6270 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6272 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6273 (converted_selections, conversion_fail_tag): New global variables.
6274 (x_selection_request_lisp_error): Free the above.
6275 (x_get_local_selection): Remove unnecessary code.
6276 (x_reply_selection_request): Args changed; handle arbitrary array
6277 of converted selections stored in converted_selections.
6278 Separate the XChangeProperty and SelectionNotify steps.
6279 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6280 (x_convert_selection): New function.
6281 (x_handle_selection_event): Simplify.
6282 (x_get_foreign_selection): Don't ignore incoming requests while
6283 waiting for an answer; this will fail when we implement
6284 SAVE_TARGETS, and seems unnecessary anyway.
6285 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6286 (Vx_sent_selection_functions): Doc fix.
6288 2011-05-26 Leo Liu <sdl.web@gmail.com>
6290 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6292 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6294 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6296 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6297 for fringe update if it has periodic bitmap.
6298 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6299 and fringe_bitmap_periodic_p.
6301 * fringe.c (get_fringe_bitmap_data): New function.
6302 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6303 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6304 row. Mark glyph row for fringe update if periodicity changed.
6306 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6307 for fringe update unless it has periodic bitmap.
6309 2011-05-25 Kenichi Handa <handa@m17n.org>
6311 * xdisp.c (get_next_display_element): Set correct it->face_id for
6312 a static composition.
6314 2011-05-24 Leo Liu <sdl.web@gmail.com>
6317 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6319 * fns.c (crypto_hash_function, Fsha1): New function.
6320 (Fmd5): Use crypto_hash_function.
6321 (syms_of_fns): Add Ssha1.
6323 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6325 * gnutls.c: Remove unused macros.
6326 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6327 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6328 Remove macros that are defined and never used.
6329 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6331 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6333 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6334 (Fx_get_selection_internal): Minor cleanup.
6335 (Fx_own_selection_internal): Rename arguments for consistency with
6338 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6340 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6342 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6344 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6346 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6348 * dispnew.c (scrolling_window): Don't exclude the case that the
6349 last enabled row in the desired matrix touches the bottom boundary.
6351 2011-05-21 Glenn Morris <rgm@gnu.org>
6353 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6354 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6355 and add some more files.
6357 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6359 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6360 report_file_error introduced by the change from 2011-05-07.
6362 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6364 * systime.h (Time): Define only if emacs is defined.
6365 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6366 where the include path doesn't have X11/X.h by default. See
6367 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6369 2011-05-20 Kenichi Handa <handa@m17n.org>
6371 * composite.c (find_automatic_composition): Fix previous change.
6373 2011-05-20 Glenn Morris <rgm@gnu.org>
6375 * lisp.mk: New file, split from Makefile.in.
6376 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6377 (shortlisp): Remove.
6378 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6380 2011-05-19 Glenn Morris <rgm@gnu.org>
6382 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6383 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6384 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6385 (lisp): Set the order to that of loadup.el.
6386 (shortlisp): Make it a copy of $lisp.
6387 (SOME_MACHINE_LISP): Remove.
6388 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6389 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6391 2011-05-18 Kenichi Handa <handa@m17n.org>
6393 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6394 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6395 (find_automatic_composition): Mostly rewrite for efficiency.
6397 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6399 * makefile.w32-in: Update dependencies.
6401 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6403 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6404 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6406 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6408 Fix some integer overflow issues, such as string length overflow.
6410 * insdel.c (count_size_as_multibyte): Check for string overflow.
6412 * character.c (lisp_string_width): Check for string overflow.
6413 Use EMACS_INT, not int, for string indexes and lengths; in
6414 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6415 the resulting string length overflows an EMACS_INT; instead,
6416 report a string overflow if no precision given. When checking for
6417 precision exhaustion, use a check that cannot possibly have
6418 integer overflow. (Bug#8675)
6419 * character.h (lisp_string_width): Adjust to new signature.
6421 * alloc.c (string_overflow): New function.
6422 (Fmake_string): Use it. This doesn't change behavior, but saves
6423 a few bytes and will simplify future changes.
6424 * character.c (string_escape_byte8): Likewise.
6425 * lisp.h (string_overflow): New decl.
6427 Fixups, following up to the user-interface timestamp change.
6428 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6429 for UI timestamps, instead of unsigned long.
6430 * msdos.c (mouse_get_pos): Likewise.
6431 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6432 * w32gui.h (Time): Define by including "systime.h" rather than by
6433 declaring it ourselves. (Bug#8664)
6435 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6436 * image.c (clear_image_cache): Likewise.
6438 * term.c (term_mouse_position): Don't assume time_t wraparound.
6440 Be more systematic about user-interface timestamps.
6441 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6442 and sometimes 'EMACS_UINT', to represent these timestamps.
6443 This change causes it to use 'Time' uniformly, as that's what X uses.
6444 This makes the code easier to follow, and makes it easier to catch
6445 integer overflow bugs such as Bug#8664.
6446 * frame.c (Fmouse_position, Fmouse_pixel_position):
6447 Use Time, not unsigned long, for user-interface timestamps.
6448 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6449 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6450 * keyboard.h (last_event_timestamp): Likewise.
6451 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6452 * menu.h (xmenu_show): Likewise.
6453 * term.c (term_mouse_position): Likewise.
6454 * termhooks.h (struct input_event.timestamp): Likewise.
6455 (struct terminal.mouse_position_hook): Likewise.
6456 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6457 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6458 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6459 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6461 * menu.h, termhooks.h: Include "systime.h", for Time.
6463 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6464 Don't assume that the difference between two unsigned long values
6465 can fit into an integer. At this point, we know button_down_time
6466 <= event->timestamp, so the difference must be nonnegative, so
6467 there's no need to cast the result if double-click-time is
6468 nonnegative, as it should be; check that it's nonnegative, just in
6469 case. This bug is triggered when events are more than 2**31 ms
6470 apart (about 25 days). (Bug#8664)
6472 * xselect.c (last_event_timestamp): Remove duplicate decl.
6473 (x_own_selection): Remove needless cast to unsigned long.
6475 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6476 that always fit in int. Use a sentinel instead of a counter, to
6477 avoid a temp and to allay GCC's concerns about possible int overflow.
6478 * frame.h (struct frame): Use int for menu_bar_items_used
6479 instead of EMACS_INT, since it always fits in int.
6481 * menu.c (grow_menu_items): Check for int overflow.
6483 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6485 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6486 Before, the code was not consistent. These values cannot exceed
6487 2**31 - 1 so there's no need to make them unsigned.
6488 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6489 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6490 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6492 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6494 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6495 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6496 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6497 presumably because the widths might not match.
6499 * window.c (size_window): Avoid needless test at loop start.
6501 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6503 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6505 2011-05-12 Drew Adams <drew.adams@oracle.com>
6507 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6509 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6511 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6512 `width' to `bar_area_x' and `bar_area_width', respectively.
6513 (x_scroll_run): Take account of fringe background extension.
6515 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6516 Rename local vars `left' and `width' to `bar_area_x' and
6517 `bar_area_width', respectively.
6518 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6519 background extension.
6521 2011-05-10 Jim Meyering <meyering@redhat.com>
6523 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6525 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6527 * image.c (Finit_image_library): Return t for built-in image types,
6528 like pbm and xbm. (Bug#8640)
6530 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6532 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6534 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6536 * w32console.c (Fset_screen_color): Doc fix.
6537 (Fget_screen_color): New function.
6538 (syms_of_ntterm): Defsubr it.
6540 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6541 unlink the temporary file if Fcall_process didn't create it in the
6543 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6544 child process will be redirected to a file specified with `:file'.
6545 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6546 cue to call_process_cleanup not to close that handle.
6548 2011-05-07 Ben Key <bkey76@gmail.com>
6550 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6551 one of two shell specific rules, either bootstrap-temacs-CMD or
6552 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6553 to the previous implementation of the bootstrap-temacs rule.
6554 The bootstrap-temacs-CMD rule is similar to the previous
6555 implementation of the bootstrap-temacs rule except that it
6556 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6559 These changes, along with some changes to nt/configure.bat,
6560 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6561 earlier fix to add support for --cflags and --ldflags options
6562 that include quotes so that it works whether make uses cmd or
6565 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6567 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6568 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6570 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6571 a string. Handle both cases.
6572 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6573 (Fdbus_register_method): Use Qinvalid_function.
6575 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6577 * makefile.w32-in: Update dependencies.
6578 (LISP_H): Add inttypes.h and stdin.h.
6579 (PROCESS_H): Add unistd.h.
6581 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6583 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6584 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6586 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6588 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6590 * term.c (vfatal): Remove stray call to va_end.
6591 It's not needed and the C Standard doesn't allow it here anyway.
6593 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6594 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6596 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6599 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6601 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6603 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6605 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6607 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6609 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6610 * charset.c (Fdefine_charset_internal): Don't initialize
6611 charset.code_space[15]. The value was garbage, on hosts with
6612 32-bit int (Bug#8600).
6614 * lread.c (read_integer): Be more consistent with string-to-number.
6615 Use string_to_number to do the actual conversion; this avoids
6616 rounding errors and fixes some other screwups. Without this fix,
6617 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6618 (digit_to_number): Move earlier, for benefit of read_integer.
6619 Return -1 if the digit is out of range for the base, -2 if it is
6620 not a digit in any supported base. (Bug#8602)
6622 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6624 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6625 to match comment at start of function. This also removes a
6626 GCC warning about overflow in a 32+64-bit port.
6628 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6630 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6631 Reported by Stefan Monnier in
6632 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6633 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6634 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6636 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6637 (EMACS_UINTPTR): Likewise, with uintptr_t.
6639 * lisp.h: Prefer 64-bit EMACS_INT if available.
6640 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6641 on 32-bit hosts that have 64-bit int, so that they can access
6643 However, temporarily disable this change unless the temporary
6644 symbol WIDE_EMACS_INT is defined.
6646 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6648 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6649 This removes an assumption that EMACS_INT and long are the same
6650 width as pointers. The assumption is true for Emacs porting targets
6651 now, but we want to make other targets possible.
6652 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6653 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6654 In the rest of the code, change types of integers that hold casted
6655 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6656 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6657 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6658 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6659 No need to cast type when ORing.
6660 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6661 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6662 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6663 assume EMACS_INT is the same width as char *.
6664 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6665 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6666 Remove no-longer-needed casts.
6667 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6668 (xg_tool_bar_help_callback, xg_make_tool_item):
6669 Use EMACS_INTPTR to hold an integer
6670 that will be cast to void *; this can avoid a GCC warning
6671 if EMACS_INT is not the same width as void *.
6672 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6673 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6674 (current_message_1, set_message_1):
6675 Use a local to convert to proper width without a cast.
6676 * xmenu.c (dialog_selection_callback): Likewise.
6678 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6679 Also, don't assume VALBITS / RAND_BITS is less than 5,
6680 and don't rely on undefined behavior when shifting a 1 left into
6682 * lisp.h (get_random): Change signature to match.
6684 * lread.c (hash_string): Use size_t, not int, for hash computation.
6685 Normally we prefer signed values; but hashing is special, because
6686 it's better to use unsigned division on hash table sizes so that
6687 the remainder is nonnegative. Also, size_t is the natural width
6688 for hashing into memory. The previous code used 'int', which doesn't
6689 retain enough info to hash well into very large tables.
6690 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6692 * dbusbind.c: Don't possibly lose pointer info when converting.
6693 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6694 Use XPNTR rather than XHASH, so that the high-order bits of
6695 the pointer aren't lost when converting through void *.
6697 * eval.c (Fautoload): Don't double-shift a pointer.
6699 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6701 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6703 * gnutls.c (DEF_GNUTLS_FN):
6704 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6706 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6708 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6711 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6713 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6714 New version that can reserve upto 2GB of heap space.
6716 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6718 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6720 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6722 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6723 `gnutls_certificate_set_x509_key_file'.
6725 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6727 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6728 Update dependencies.
6730 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6732 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6733 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6734 Remove unused parameter `fildes'.
6735 * process.c (read_process_output, send_process): Don't pass it.
6737 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6739 Fix previous change: the library cache is defined in w32.c.
6740 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6741 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6743 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6745 Implement dynamic loading of GnuTLS on Windows.
6747 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6748 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6749 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6752 * gnutls.c (Qgnutls_dll): Define.
6753 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6754 (gnutls_*): Declare function pointers.
6755 (init_gnutls_functions): New function to initialize function pointers.
6756 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6757 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6758 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6759 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6760 (emacs_gnutls_write, emacs_gnutls_read)
6761 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6762 (Fgnutls_available_p): New function.
6763 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6764 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6765 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6767 * image.c: Include w32.h.
6768 (Vimage_type_cache): Delete.
6769 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6770 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6771 (w32_delayed_load): Move to w32.c.
6773 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6775 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6776 (w32_delayed_load): Move from image.c. When loading a library, record
6777 its filename in the :loaded-from property of the library id.
6778 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6779 Initialize and staticpro them.
6780 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6782 * process.c: Include lisp.h before w32.h, not after.
6783 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6784 instead of gnutls_record_check_pending.
6786 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6788 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6790 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6791 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6794 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6796 * xterm.c (x_set_frame_alpha): Do not set property on anything
6797 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6799 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6801 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6803 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6805 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6806 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6807 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6808 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6809 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6810 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6811 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6812 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6813 (Qgnutls_bootprop_callbacks_verify): Make static.
6815 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6817 * callproc.c: Indentation fixup.
6819 * sysdep.c (wait_for_termination_1): Make static.
6820 (wait_for_termination, interruptible_wait_for_termination):
6821 Move after wait_for_termination_1.
6823 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6825 * sysdep.c (interruptible_wait_for_termination): New function
6826 which is like wait_for_termination, but allows keyboard
6829 * callproc.c (Fcall_process): Add (:file "file") as an option for
6831 (Fcall_process_region): Ditto.
6833 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6835 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6836 rather than `XVECTOR (FOO)->size'.
6838 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6839 inttypes.h, as a gnulib replacement is used if it not available in
6842 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6844 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6845 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6846 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6848 * coding.c (coding_alloc_by_realloc): Error out if destination
6849 will grow beyond MOST_POSITIVE_FIXNUM.
6850 (decode_coding_emacs_mule): Abort if there isn't enough place in
6851 charbuf for the composition carryover bytes. Reserve an extra
6852 space for up to 2 characters produced in a loop.
6853 (decode_coding_iso_2022): Abort if there isn't enough place in
6854 charbuf for the composition carryover bytes.
6856 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6858 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6859 aborting when %lld or %lll format is passed.
6860 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6861 %llo or %llx format is passed. (Bug#8545)
6863 * window.c (window_scroll_line_based): Use a marker instead of
6864 simple variables to record original value of point. (Bug#7952)
6866 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6867 produced by %s or %c overflows available buffer space. (Bug#8545)
6869 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6871 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6872 (SIZE_MAX): Move defn after all includes, as they might #define it.
6874 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6876 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6878 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6880 * keyboard.c (Qdelayed_warnings_hook): Define.
6881 (command_loop_1): Run `delayed-warnings-hook'
6882 if Vdelayed_warnings_list is non-nil.
6883 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6884 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6886 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6888 * doprnt.c (doprnt): Don't return value smaller than the buffer
6889 size if the message was truncated. (Bug#8545).
6891 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6893 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6894 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6896 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6898 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6900 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6902 * makefile.w32-in: Update dependencies.
6904 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6906 Improve `doprnt' and its usage. (Bug#8545)
6907 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6908 `format_end'. Remove support for %l as a conversion specifier.
6909 Don't use xrealloc. Improve diagnostics when the %l size modifier
6910 is used. Update the commentary.
6912 * eval.c (verror): Simplify calculation of size_t.
6914 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6917 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6919 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6922 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6924 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6925 This makes this file independent of the recent pseudovector change.
6927 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6929 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6931 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6932 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6933 Remove unused local.
6934 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6936 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6937 GCC 4.6.0 optimizes based on type-based alias analysis.
6938 For example, if b is of type struct buffer * and v of type struct
6939 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6940 != &v->size, and therefore "v->size = 1; b->size = 2; return
6941 v->size;" must therefore return 1. This assumption is incorrect
6942 for Emacs, since it type-puns struct Lisp_Vector * with many other
6943 types. To fix this problem, this patch adds a new type struct
6944 vectorlike_header that documents the constraints on layout of vectors
6945 and pseudovectors, and helps optimizing compilers not get fooled
6946 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6947 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6948 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6950 (XSETPVECTYPE): Rewrite in terms of new macro.
6951 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6952 This is a bit clearer, and further avoids the possibility of
6953 undesirable aliasing.
6954 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6955 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6956 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6957 since Lisp_Subr is a special case (no "next" field).
6958 (ASIZE): Now uses header.size rather than size.
6959 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6960 to avoid the hassle of writing XVECTOR (foo)->header.size.
6961 (struct vectorlike_header): New type.
6962 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6963 object, to help avoid aliasing.
6964 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6965 (SUBRP): Likewise, since Lisp_Subr is a special case.
6966 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6967 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6968 (struct Lisp_Hash_Table): Combine first two members into a single
6969 struct vectorlike_header member. All uses of "size" and "next" members
6970 changed to be "header.size" and "header.next".
6971 * buffer.h (struct buffer): Likewise.
6972 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6973 * frame.h (struct frame): Likewise.
6974 * process.h (struct Lisp_Process): Likewise.
6975 * termhooks.h (struct terminal): Likewise.
6976 * window.c (struct save_window_data, struct saved_window): Likewise.
6977 * window.h (struct window): Likewise.
6978 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6979 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6980 * buffer.c (init_buffer_once): Likewise.
6981 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6983 * process.c (Fformat_network_address): Use local var for size,
6986 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6988 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6989 * data.c (atof): Remove decl; no longer used or needed.
6990 (digit_to_number): Move to lread.c.
6991 (Fstring_to_number): Use new string_to_number function, to be
6992 consistent with how the Lisp reader treats infinities and NaNs.
6993 Do not assume that floating-point numbers represent EMACS_INT
6994 without losing information; this is not true on most 64-bit hosts.
6995 Avoid double-rounding errors, by insisting on integers when
6996 parsing non-base-10 numbers, as the documentation specifies.
6997 * lisp.h (string_to_number): New decl, replacing ...
6998 (isfloat_string): Remove.
6999 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7000 (read1): Do not accept +. and -. as integers; this
7001 appears to have been a coding error. Similarly, do not accept
7002 strings like +-1e0 as floating point numbers. Do not report
7003 overflow for integer overflows unless the base is not 10 which
7004 means we have no simple and reliable way to continue.
7005 Break out the floating-point parsing into a new
7006 function string_to_number, so that Fstring_to_number parses
7007 floating point numbers consistently with the Lisp reader.
7008 (digit_to_number): Move here from data.c. Make it static inline.
7009 (E_CHAR, EXP_INT): Remove, replacing with ...
7010 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7011 (string_to_number): New function, replacing isfloat_string.
7012 This function checks for valid syntax and produces the resulting
7013 Lisp float number too. Rework it so that string-to-number
7014 no longer mishandles examples like "1.0e+". Use strtoumax,
7015 so that overflow for non-base-10 numbers is reported only when
7016 there's no portable and simple way to convert to floating point.
7018 * textprop.c (set_text_properties_1): Rewrite for clarity,
7019 and to avoid GCC warning about integer overflow.
7021 * intervals.h (struct interval): Use EMACS_INT for members
7022 where EMACS_UINT might cause problems. See
7023 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7024 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7025 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7027 (offset_intervals): Tell GCC not to worry about length overflow
7028 when negating a negative length.
7030 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7031 (overrun_check_free): Likewise.
7033 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7034 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7037 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7038 (gnutls_make_error): Rename local to avoid shadowing.
7039 (gnutls_emacs_global_deinit): ifdef out; not used.
7040 (Fgnutls_boot): Use const for pointer to readonly storage.
7041 Comment out unused local. Fix pointer signedness problems.
7043 * lread.c (openp): Don't stuff size_t into an 'int'.
7044 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7045 about possible signed overflow.
7047 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7048 (GDK_KEY_g): Don't define if already defined.
7049 (xg_prepare_tooltip): Avoid pointer signedness problem.
7050 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7052 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7053 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7055 * xfns.c (Fx_window_property): Simplify a bit,
7056 to make a bit faster and to avoid GCC 4.6.0 warning.
7057 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7059 * fns.c (internal_equal): Don't assume size_t fits in int.
7061 * alloc.c (compact_small_strings): Tighten assertion a little.
7063 Replace pEd with more-general pI, and fix some printf arg casts.
7064 * lisp.h (pI): New macro, generalizing old pEd macro to other
7065 conversion specifiers. For example, use "...%"pI"d..." rather
7066 than "...%"pEd"...".
7067 (pEd): Remove. All uses replaced with similar uses of pI.
7068 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7069 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7070 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7071 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7072 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7073 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7074 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7076 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7077 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7078 * print.c (safe_debug_print, print_object): Likewise.
7079 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7081 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7082 avoiding the 0 flag, which is not portable.
7083 * process.c (Fmake_network_process): Use pI to avoid cast.
7084 * region-cache.c (pp_cache): Likewise.
7085 * xdisp.c (decode_mode_spec): Likewise.
7086 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7087 behavior on 64-bit hosts with printf arg.
7088 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7089 (x_stop_queuing_selection_requests): Likewise.
7090 (x_get_window_property): Don't truncate byte count to an 'int'
7093 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7094 here, since it parses constructs like leading '-' and spaces,
7095 which are not wanted; and it overflows with large numbers.
7096 Instead, simply match F[0-9]+, which is what is wanted anyway.
7098 * alloc.c: Remove unportable assumptions about struct layout.
7099 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7100 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7101 (allocate_vectorlike, make_pure_vector): Use the new macros,
7102 plus offsetof, to remove unportable assumptions about struct layout.
7103 These assumptions hold on all porting targets that I know of, but
7104 they are not guaranteed, they're easy to remove, and removing them
7105 makes further changes easier.
7107 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7108 This doesn't fix a bug but makes the code clearer.
7109 (string_overrun_cookie): Now const. Use initializers that
7110 don't formally overflow signed char, to avoid warnings.
7111 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7112 can cause Emacs to crash when string overrun checking is enabled.
7113 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7114 multiple of sizeof (EMACS_INT); it need not be, if
7115 alignof(EMACS_INT) < sizeof (EMACS_INT).
7116 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7118 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7120 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7122 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7124 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7125 supposed to be handshaking. (Bug#8556)
7126 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7128 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7130 * lisp.h (Qdebug): List symbol.
7131 * eval.c (Qdebug): Restore global linkage.
7132 * keyboard.c (debug-on-event): New variable.
7133 (handle_user_signal): Break into debugger when debug-on-event
7134 matches the current signal symbol.
7136 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7138 * alloc.c (check_sblock, check_string_bytes)
7139 (check_string_free_list): Convert to standard C.
7141 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7143 * w32.c (emacs_gnutls_push): Fix typo.
7145 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7147 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7148 "cast to pointer from integer of different size".
7150 Improve doprnt and its use in verror. (Bug#8545)
7151 * doprnt.c (doprnt): Document the set of format control sequences
7152 supported by the function. Use SAFE_ALLOCA instead of always
7155 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7156 is one byte too soon. Don't use xrealloc; instead xfree and
7159 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7161 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7164 * gnutls.c: Renamed global_initialized to
7165 gnutls_global_initialized. Added internals for the
7166 :verify-hostname-error, :verify-error, and :verify-flags
7167 parameters of `gnutls-boot' and documented those parameters in the
7168 docstring. Start callback support.
7169 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7170 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7171 on error. Return error code.
7172 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7173 (emacs_gnutls_read): Likewise.
7174 (Fgnutls_boot): Return handshake error code.
7175 (emacs_gnutls_handle_error): New function.
7176 (wsaerror_to_errno): Likewise.
7178 * w32.h (emacs_gnutls_pull): Add prototype.
7179 (emacs_gnutls_push): Likewise.
7181 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7182 (emacs_gnutls_push): Likewise.
7184 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7186 * process.c (wait_reading_process_output): Check if GnuTLS
7187 buffered some data internally if no FDs are set for TLS
7190 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7191 (LIBS): Link to USER_LIBS.
7192 ($(BLD)/gnutls.$(0)): New target.
7194 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7196 * xdisp.c (handle_single_display_spec): Rename the
7197 display_replaced_before_p argument into display_replaced_p, to
7198 make it consistent with the commentary. Fix typos in the
7201 * textprop.c (syms_of_textprop): Remove dead code.
7202 (copy_text_properties): Delete obsolete commentary about an
7203 interface that was deleted long ago. Fix typos in the description
7206 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7207 to changes in oldXMenu/XMenu.h from 2011-04-16.
7208 <menu_help_message, prev_menu_help_message>: Constify.
7209 (IT_menu_make_room): menu->help_text is now `const char **';
7212 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7213 to changes in oldXMenu/XMenu.h from 2011-04-16.
7214 (struct XMenu): Declare `help_text' `const char **'.
7216 * xfaces.c <Qunspecified>: Make extern again.
7218 * syntax.c: Include sys/types.h before including regex.h, as
7221 * doc.c (get_doc_string): Improve the format passed to `error'.
7223 * doprnt.c (doprnt): Improve commentary.
7225 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7227 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7230 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7231 changes in globals.h immediately force recompilation.
7232 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7233 $(CURDIR)/s/ms-w32.h.
7234 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7236 * character.c (Fchar_direction): Function deleted.
7237 (syms_of_character): Don't defsubr it.
7238 <char-direction-table>: Deleted.
7240 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7242 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7243 * doprnt.c: Include limits.h.
7244 (SIZE_MAX): New macro.
7245 (doprnt): Return a size_t value. 2nd arg is now size_t.
7246 Many local variables are now size_t instead of int or unsigned.
7247 Improve overflow protection. Support `l' modifier for integer
7248 conversions. Support %l conversion. Don't assume an EMACS_INT
7249 argument for integer conversions and for %c.
7251 * lisp.h (doprnt): Restore prototype.
7253 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7256 * Makefile.in (base_obj): Add back doprnt.o.
7258 * deps.mk (doprnt.o): Add back prerequisites.
7259 (callint.o): Depend on character.h.
7261 * eval.c (internal_lisp_condition_case): Include the handler
7262 representation in the error message.
7263 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7264 when breaking from the loop.
7266 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7268 * callint.c (Fcall_interactively): When displaying error message
7269 about invalid control letter, pass the character's codepoint, not
7270 a pointer to its multibyte form. Improve display of the character
7271 in octal and display also its hex code.
7273 * character.c (char_string): Use %x to display the (unsigned)
7274 codepoint of an invalid character, to avoid displaying a bogus
7277 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7278 `error', not SYMBOL_NAME itself.
7280 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7281 character arguments to `error'.
7283 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7284 to `error' in error message about FINAL_CHAR argument. Make sure
7285 FINAL_CHAR is a character, and use %c when it is passed as
7286 argument to `error'.
7288 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7290 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7292 * w32.c: Include <time.h>.
7293 (sys_localtime): New function.
7295 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7297 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7299 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7301 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7303 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7306 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7308 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7309 gl_state.e_property when gl_state.object is Qt.
7311 * insdel.c (make_gap_larger): Remove limitation of buffer size
7314 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7316 * xdisp.c (lookup_glyphless_char_display)
7317 (produce_glyphless_glyph): Handle cons cell entry in
7318 glyphless-char-display.
7319 (Vglyphless_char_display): Document it.
7321 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7322 glyphless-char-display.
7324 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7326 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7328 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7330 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7331 definition for no-X builds.
7333 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7335 Static checks with GCC 4.6.0 and non-default toolkits.
7337 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7339 * process.c (keyboard_bit_set): Define only if SIGIO.
7340 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7341 (send_process): Repair possible setjmp clobbering.
7343 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7345 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7347 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7349 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7350 Define only if needed.
7352 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7353 by pacifying GCC about it. Maybe it's time to retire it?
7354 * xfaces.c (USG, __TIMEVAL__): Likewise.
7356 * dispextern.h (struct redisplay_interface): Rename param
7358 * termhooks.h (struct terminal): Likewise.
7359 * xterm.c (xembed_send_message): Likewise.
7361 * insdel.c (make_gap_smaller): Define only if
7362 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7364 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7367 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7368 so that we aren't warned about unused symbols.
7370 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7372 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7374 * xfns.c (x_real_positions): Mark locals as initialized.
7376 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7378 * xterm.c: Fix problems found by static analysis with other toolkits.
7379 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7380 (x_dispatch_event): Declare static if USE_GTK, and
7381 define if USE_GTK || USE_X_TOOLKIT.
7382 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7383 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7384 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7385 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7387 * xmenu.c (menu_help_callback): Pointer type fixes.
7388 Use const pointers when pointing at readonly data. Avoid pointer
7390 (FALSE): Remove unused macro.
7391 (update_frame_menubar): Remove unused decl.
7393 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7395 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7396 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7397 (single_menu_item): Rename local to avoid shadowing.
7399 * keyboard.c (make_lispy_event): Remove unused local var.
7401 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7402 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7404 * bitmaps: Change bitmaps from unsigned char back to the X11
7405 compatible char. Avoid the old compiler warnings about
7406 out-of-range initializers by using, for example, '\xab' rather
7409 * xgselect.c (xgselect_initialize): Check vs interface
7410 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7412 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7414 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7415 to read-only memory.
7417 * fns.c (vector): Remove; this old hack is no longer needed.
7419 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7421 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7423 * xrdb.c (x_load_resources): Omit unused local.
7425 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7426 (x_window): Rename locals to avoid shadowing.
7427 (USG): Use the kludged USG macro, to pacify gcc.
7429 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7430 (x_term_init): Remove local to avoid shadowing.
7432 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7434 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7435 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7437 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7439 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7441 Fix regex.c, syntax.c and friends for buffers > 2GB.
7442 * syntax.h (struct gl_state_s): Declare character position members
7445 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7447 * textprop.c (verify_interval_modification, interval_of):
7448 Declare arguments EMACS_INT.
7450 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7453 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7455 * indent.c (Fvertical_motion): Local variable it_start is now
7458 * regex.c (re_match, re_match_2, re_match_2_internal)
7459 (bcmp_translate, regcomp, regexec, print_double_string)
7460 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7461 (re_compile_pattern, re_exec): Declare arguments and local
7462 variables `size_t' and `ssize_t' and return values `regoff_t', as
7464 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7465 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7466 <compile_stack_type>: `size' and `avail' are now `size_t'.
7468 * regex.h <regoff_t>: Use ssize_t, not int.
7469 (re_search, re_search_2, re_match, re_match_2): Arguments that
7470 specify buffer/string position and length are now ssize_t and
7471 size_t. Return type is regoff_t.
7473 2011-04-16 Ben Key <bkey76@gmail.com>
7475 * nsfont.m: Fixed bugs in ns_get_family and
7476 ns_descriptor_to_entity that were caused by using free to
7477 deallocate memory blocks that were allocated by xmalloc (via
7478 xstrdup). This caused Emacs to crash when compiled with
7479 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7480 --enable-checking=xmallocoverrun). xfree is now used to
7481 deallocate these memory blocks.
7483 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7485 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7487 emacs_write: Accept and return EMACS_INT for sizes.
7488 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7490 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7491 Accept and return EMACS_INT.
7492 (emacs_gnutls_write): Return the number of bytes written on
7494 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7495 (emacs_read, emacs_write): Remove check for negative size, as the
7496 Emacs source code has been audited now.
7497 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7498 (emacs_read, emacs_write): Use it.
7499 * process.c (send_process): Adjust to the new signatures of
7500 emacs_write and emacs_gnutls_write. Do not attempt to store
7501 a byte offset into an 'int'; it might overflow.
7502 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7504 * sound.c: Don't assume sizes fit in 'int'.
7505 (struct sound_device.period_size, alsa_period_size):
7506 Return EMACS_INT, not int.
7507 (struct sound_device.write, vox_write, alsa_write):
7508 Accept EMACS_INT, not int.
7509 (wav_play, au_play): Use EMACS_INT to store sizes and to
7510 record read return values.
7512 2011-04-15 Ben Key <bkey76@gmail.com>
7514 * keyboard.c (Qundefined): Don't declare static since it is used
7516 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7517 static since they are used in nsfont.m.
7519 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7521 * process.c (Qprocessp): Don't declare static.
7522 * lisp.h (Qprocessp): Declare again.
7524 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7526 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7528 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7530 Improve C-level modularity by making more things 'static'.
7532 Don't publish debugger-only interfaces to other modules.
7533 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7534 (verify_bytepos, count_markers): Move decls to the only modules
7536 * region-cache.h (pp_cache): Likewise.
7537 * window.h (check_all_windows): Likewise.
7538 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7540 * sysdep.c (croak): Now static, if
7541 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7542 * syssignal.h (croak): Declare only if not static.
7544 * alloc.c (refill_memory_reserve): Now static if
7545 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7546 * lisp.h (refill_memory_reserve): Declare only if not static.
7548 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7549 Define only if USE_LUCID.
7551 * xrdb.c (x_customization_string, x_rm_string): Now static.
7553 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7554 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7556 * xdisp.c (draw_row_with_mouse_face): Now static.
7557 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7559 * window.h (check_all_windows): Mark externally visible.
7561 * window.c (window_deletion_count): Now static.
7563 * undo.c: Make symbols static if they're not exported.
7564 (last_undo_buffer, last_boundary_position, pending_boundary):
7567 * textprop.c (interval_insert_behind_hooks): Now static.
7568 (interval_insert_in_front_hooks): Likewise.
7570 * term.c: Make symbols static if they're not exported.
7571 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7572 (max_frame_lines, tty_set_terminal_modes):
7573 (tty_reset_terminal_modes, tty_turn_off_highlight):
7574 (get_tty_terminal): Now static.
7575 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7576 * termhooks.h (term_mouse_moveto): Do not declare if
7578 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7579 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7581 * sysdep.c: Make symbols static if they're not exported.
7582 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7584 (sigprocmask_set, full_mask): Remove; unused.
7585 (wait_debugging): Mark as visible.
7586 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7587 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7589 * syntax.c (syntax_temp): Define only if !__GNUC__.
7591 * sound.c (current_sound_device, current_sound): Now static.
7593 * search.c (searchbufs, searchbuf_head): Now static.
7595 * scroll.c (scroll_cost): Remove; unused.
7596 * dispextern.h (scroll_cost): Remove decl.
7598 * region-cache.h (pp_cache): Mark as externally visible.
7600 * process.c: Make symbols static if they're not exported.
7601 (process_tick, update_tick, create_process, chan_process):
7602 (Vprocess_alist, proc_buffered_char, datagram_access):
7603 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7604 (deactivate_process): Mark defn as static, as well as decl.
7605 * lisp.h (create_process): Remove decl.
7606 * process.h (chan_process, Vprocess_alist): Remove decls.
7608 * print.c: Make symbols static if they're not exported.
7609 (print_depth, new_backquote_output, being_printed, print_buffer):
7610 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7611 (print_interval, print_number_index, initial_stderr_stream):
7613 * lisp.h (Fprinc): Remove decl.
7614 (debug_output_compilation_hack): Mark as externally visible.
7616 * sysdep.c (croak): Move decl from here to syssignal.h.
7617 * syssignal.h (croak): Put it here, so the API can be checked when
7618 'croak' is called from dissociate_if_controlling_tty.
7620 * minibuf.c: Make symbols static if they're not exported.
7621 (minibuf_save_list, choose_minibuf_frame): Now static.
7622 * lisp.h (choose_minibuf_frame): Remove decl.
7624 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7626 * lread.c: Make symbols static if they're not exported.
7627 (read_objects, initial_obarray, oblookup_last_bucket_number):
7629 (make_symbol): Remove; unused.
7630 * lisp.h (initial_obarray, make_symbol): Remove decls.
7632 * keyboard.c: Make symbols static if they're not exported.
7633 (single_kboard, recent_keys_index, total_keys, recent_keys):
7634 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7635 (this_single_command_key_start, echoing, last_auto_save):
7636 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7637 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7638 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7639 (Vlispy_mouse_stem, double_click_count):
7641 (force_auto_save_soon): Define only if SIGDANGER.
7642 (ignore_mouse_drag_p): Now static if
7643 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7644 (print_help): Remove; unused.
7645 (stop_character, last_timer_event): Mark as externally visible.
7646 * keyboard.h (ignore_mouse_drag_p): Declare only if
7647 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7648 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7649 * lisp.h (echoing): Remove decl.
7650 (force_auto_save_soon): Declare only if SIGDANGER.
7651 * xdisp.c (redisplay_window): Simplify code, to make it more
7652 obvious that ignore_mouse_drag_p is not accessed if !defined
7653 USE_GTK && !defined HAVE_NS.
7655 * intervals.c: Make symbols static if they're not exported.
7656 (merge_properties_sticky, merge_interval_right, delete_interval):
7658 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7660 * insdel.c: Make symbols static if they're not exported.
7661 However, leave prepare_to_modify_buffer alone. It's never
7662 called from outside this function, but that appears to be a bug.
7663 (combine_after_change_list, combine_after_change_buffer):
7664 (adjust_after_replace, signal_before_change): Now static.
7665 (adjust_after_replace_noundo): Remove; unused.
7666 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7667 (signal_before_change): Remove decls.
7669 * indent.c (val_compute_motion, val_vmotion): Now static.
7671 * image.c: Make symbols static if they're not exported.
7672 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7674 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7675 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7677 * fringe.c (standard_bitmaps): Now static.
7678 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7680 * frame.c: Make symbols static if they're not exported.
7681 (x_report_frame_params, make_terminal_frame): Now static.
7682 (get_frame_param): Now static, unless HAVE_NS.
7683 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7684 (x_get_resource_string): Remove; not used.
7685 * frame.h (make_terminal_frame, x_report_frame_params):
7686 (x_get_resource_string); Remove decls.
7687 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7688 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7690 * font.c, fontset.c: Make symbols static if they're not exported.
7691 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7692 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7693 * font.c (font_close_object): Now static.
7694 * font.h (font_close_object): Remove.
7695 * fontset.c (FONTSET_OBJLIST): Remove.
7696 (free_realized_fontset) #if-0 the body, which does nothing.
7697 (face_suitable_for_char_p): #if-0, as it's never called.
7698 * fontset.h (face_suitable_for_char_p): Remove decl.
7699 * xfaces.c (face_at_string_position):
7700 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7701 since 0 is always ASCII.
7703 * fns.c (weak_hash_tables): Now static.
7705 * fileio.c: Make symbols static if they're not exported.
7706 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7707 (Vwrite_region_annotation_buffers): Now static.
7709 * eval.c: Make symbols static if they're not exported.
7710 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7711 * lisp.h (backtrace_list): Remove decl.
7713 * emacs.c: Make symbols static if they're not exported.
7714 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7715 (fatal_error_code, fatal_error_signal_hook, standard_args):
7717 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7718 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7719 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7720 * lisp.h (fatal_error_signal_hook): Remove decl.
7721 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7723 * editfns.c: Move a (normally-unused) function to its only use.
7724 * editfns.c, lisp.h (get_operating_system_release): Remove.
7725 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7726 worth the hassle of breaking this out.
7728 * xterm.c: Make symbols static if they're not exported.
7729 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7730 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7731 (x_destroy_window, x_delete_display):
7733 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7734 (x_mouse_leave): Remove; unused.
7735 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7736 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7737 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7739 (x_mouse_leave): Declare only if WINDOWSNT.
7740 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7741 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7744 * ftxfont.c: Make symbols static if they're not exported.
7745 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7747 * font.h (ftxfont_driver): Likewise.
7749 * xfns.c: Make symbols static if they're not exported.
7750 (x_last_font_name, x_display_info_for_name):
7751 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7752 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7753 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7754 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7755 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7756 (last_show_tip_args): Now static.
7757 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7758 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7759 (x_screen_planes): Remove; unused.
7760 * dispextern.h (x_screen_planes): Remove decl.
7762 * dispnew.c: Make symbols static if they're not exported.
7763 * dispextern.h (redraw_garbaged_frames, scrolling):
7764 (increment_row_positions): Remove.
7765 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7766 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7768 (redraw_garbaged_frames): Remove; unused.
7770 * xfaces.c: Make symbols static if they're not exported.
7771 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7773 * xterm.h (defined_color): Remove decls.
7774 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7775 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7776 (menu_face_changed_default, defined_color, free_realized_face):
7777 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7778 (ascii_face_of_lisp_face): Remove; unused.
7780 * xdisp.c: Make symbols static if they're not exported.
7781 * dispextern.h (scratch_glyph_row, window_box_edges):
7782 (glyph_to_pixel_coords, set_cursor_from_row):
7783 (get_next_display_element, set_iterator_to_next):
7784 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7785 (show_mouse_face): Remove decls
7786 * frame.h (message_buf_print): Likewise.
7787 * lisp.h (pop_message, set_message, check_point_in_composition):
7789 * xterm.h (set_vertical_scroll_bar): Likewise.
7790 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7791 (message_buf_print, scratch_glyph_row, displayed_buffer):
7792 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7793 (get_next_display_element, show_mouse_face, window_box_edges):
7794 (frame_to_window_pixel_xy, check_point_in_composition):
7795 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7796 (glyph_to_pixel_coords): Remove; unused.
7798 * dired.c (file_name_completion): Now static.
7800 * dbusbind.c (xd_in_read_queued_messages): Now static.
7802 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7803 * data.c (circular_list_error): Remove.
7805 * commands.h (last_point_position, last_point_position_buffer):
7806 (last_point_position_window): Remove decls.
7807 * keyboard.c: Make these variables static.
7809 * coding.h (coding, code_convert_region, encode_coding_gap):
7811 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7812 (iso_code_class, detect_coding, code_convert_region): Now static.
7813 (encode_coding_gap): Remove; unused.
7815 * chartab.c (chartab_chars, chartab_bits): Now static.
7817 * charset.h (charset_iso_8859_1): Remove decl.
7818 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7821 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7822 * ccl.c (Vccl_program_table): Now static.
7823 (check_ccl_update): Remove; unused.
7825 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7826 * category.h: ... from here.
7827 * category.c (check_category_table, set_category_set): Now static.
7829 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7830 * lisp.h: Remove these decls.
7832 * buffer.c (buffer_count): Remove unused var.
7834 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7835 so that it's not optimized away.
7836 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7837 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7838 exported only to the debugger.
7840 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7841 * atimer.h (run_all_atimers): Remove; not exported.
7843 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7844 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7845 was inaccessible from Lisp.
7846 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7847 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7849 alloc.c: Import and export fewer symbols, and remove unused items.
7850 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7852 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7853 it's not optimized away by whole-program optimization.
7854 (message_enable_multibyte, free_misc): Remove.
7855 (catchlist, handlerlist, mark_backtrace):
7856 Declare only if BYTE_MARK_STACK.
7857 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7858 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7859 (message_enable_multibyte): Remove decl.
7860 (free_misc, interval_free_list, float_block, float_block_index):
7861 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7862 (cons_free_list, last_marked_index):
7864 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7865 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7866 (mark_backtrace): Define only if BYTE_MARK_STACK.
7867 * xdisp.c (message_enable_multibyte): Now static.
7869 Declare Lisp_Object Q* variables to be 'static' if not exported.
7870 This makes it easier for human readers (and static analyzers)
7871 to see whether these variables are used from other modules.
7872 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7873 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7874 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7875 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7876 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7877 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7878 * xmenu.c, xselect.c:
7879 Declare Q* vars static if they are not used in other modules.
7880 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7881 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7882 Remove decls of unexported vars.
7883 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7885 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7887 Make Emacs functions such as Fatom 'static' by default.
7888 This makes it easier for human readers (and static analyzers)
7889 to see whether these functions can be called from other modules.
7890 DEFUN now defines a static function. To make the function external
7891 so that it can be used in other C modules, use the new macro DEFUE.
7892 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7893 (Finit_image_library):
7894 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7895 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7896 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7897 Remove decls, since these functions are now static.
7898 (Funintern, Fget_internal_run_time): New decls, since these functions
7899 were already external.
7901 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7902 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7903 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7904 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7905 * keyboard.c, keymap.c, lread.c:
7906 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7907 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7908 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7909 Mark functions with DEFUE instead of DEFUN,
7910 if they are used in other modules.
7911 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7912 decls for now-static functions.
7913 * buffer.h (Fdelete_overlay): Remove decl.
7914 * callproc.c (Fgetenv_internal): Mark as internal.
7915 * composite.c (Fremove_list_of_text_properties): Remove decl.
7916 (Fcomposition_get_gstring): New forward static decl.
7917 * composite.h (Fcomposite_get_gstring): Remove decl.
7918 * dired.c (Ffile_attributes): New forward static decl.
7919 * doc.c (Fdocumntation_property): New forward static decl.
7920 * eval.c (Ffetch_bytecode): New forward static decl.
7921 (Funintern): Remove extern decl; now in .h file where it belongs.
7922 * fileio.c (Fmake_symbolic_link): New forward static decl.
7923 * image.c (Finit_image_library): New forward static decl.
7924 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7925 * intervals.h (Fprevious_property_change):
7926 (Fremove_list_of_text_properties): Remove decls.
7927 * keyboard.c (Fthis_command_keys): Remove decl.
7928 (Fcommand_execute): New forward static decl.
7929 * keymap.c (Flookup_key): New forward static decl.
7930 (Fcopy_keymap): Now static.
7931 * keymap.h (Flookup_key): Remove decl.
7932 * process.c (Fget_process): New forward static decl.
7933 (Fprocess_datagram_address): Mark as internal.
7934 * syntax.c (Fsyntax_table_p): New forward static decl.
7935 (skip_chars): Remove duplicate decl.
7936 * textprop.c (Fprevious_property_change): New forward static decl.
7937 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7939 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7940 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7942 * editfns.c (Fformat): Remove unreachable code.
7944 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7946 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7949 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7951 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7952 when at ZV. (Bug#8487)
7954 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7956 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7958 * keyboard.c (parse_tool_bar_item): Likewise.
7959 * sound.c (sound_cleanup, alsa_close): Likewise.
7960 * termcap.c (tgetent): Likewise.
7961 * xfns.c (x_default_font_parameter): Likewise.
7962 * xsettings.c (read_and_apply_settings): Likewise.
7964 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7965 (overrun_check_free): Protoize.
7967 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7969 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7970 since callers should never pass a negative size.
7971 Change the signature to match that of plain 'read' and 'write'; see
7972 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7973 * lisp.h: Update prototypes of emacs_write and emacs_read.
7975 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7977 * xdisp.c (redisplay_window): Don't try to determine the character
7978 position of the scroll margin if the window start point w->startp
7979 is outside the buffer's accessible region. (Bug#8468)
7981 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7983 Fix write-region and its subroutines for buffers > 2GB.
7984 * fileio.c (a_write, e_write): Modify declaration of arguments and
7985 local variables to support buffers larger than 2GB.
7986 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7988 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7989 argument, local variables, and return value.
7991 * lisp.h: Update prototypes of emacs_write and emacs_read.
7993 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7995 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7997 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7999 Fix more problems found by GCC 4.6.0's static checks.
8001 * xdisp.c (vmessage): Use a better test for character truncation.
8003 * charset.c (load_charset_map): <, not <=, for optimization,
8004 and to avoid potential problems with integer overflow.
8005 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8006 * casetab.c (set_identity, shuffle): Likewise.
8007 * editfns.c (Fformat): Likewise.
8008 * syntax.c (skip_chars): Likewise.
8010 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8011 This also lets GCC 4.6.0 generate slightly better loop code.
8013 * callint.c (Fcall_interactively): <, not <=, for optimization.
8014 (Fcall_interactively): Count the number of arguments produced,
8015 not the number of arguments given. This is simpler and lets GCC
8016 4.6.0 generate slightly better code.
8018 * ftfont.c: Distingish more carefully between FcChar8 and char.
8019 The previous code passed unsigned char * to a functions like
8020 strlen and xstrcasecmp that expect char *, which does not
8021 conform to the C standard.
8022 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8023 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8024 char * when the C standard requires it.
8026 * keyboard.c (read_char): Remove unused var.
8028 * eval.c: Port to Windows vsnprintf (Bug#8435).
8030 (SIZE_MAX): Define if the headers do not.
8031 (verror): Do not give up if vsnprintf returns a negative count.
8032 Instead, grow the buffer. This ports to Windows vsnprintf, which
8033 does not conform to C99. Problem reported by Eli Zaretskii.
8034 Also, simplify the allocation scheme, by avoiding the need for
8035 calling realloc, and removing the ALLOCATED variable.
8037 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8039 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8040 But keep the doprint source code for now, as we might revamp it
8041 and use it again (Bug#8435).
8042 * lisp.h (doprnt): Remove.
8043 * Makefile.in (base_obj): Remove doprnt.o.
8044 * deps.mk (doprnt.o): Remove.
8046 error: Print 32- and 64-bit integers portably (Bug#8435).
8047 Without this change, on typical 64-bit hosts error ("...%d...", N)
8048 was used to print both 32- and 64-bit integers N, which relied on
8050 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8051 * lisp.h (error, verror): Mark as printf-like functions.
8052 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8053 Report overflow in size calculations when allocating printf buffer.
8054 Do not truncate output string at its first null byte.
8055 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8056 Truncate the output at a character boundary, since vsnprintf does not
8058 * charset.c (check_iso_charset_parameter): Convert internal
8059 character to string before calling 'error', since %c now has the
8061 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8062 overflow when computing char to be passed to 'error'. Do not
8063 pass Lisp_Object to 'error'; pass the integer instead.
8064 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8065 formatted with plain %d.
8067 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8069 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8071 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8073 * xterm.c (x_catch_errors): Remove duplicate declaration.
8075 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8077 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8079 2011-04-10 Jim Meyering <meyering@redhat.com>
8081 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8082 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8083 return ssize_t not "int", and use size_t as the buffer length.
8084 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8085 * gnutls.h: Update declarations.
8086 * process.c (read_process_output): Use ssize_t, to match.
8087 (send_process): Likewise.
8089 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8091 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8093 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8095 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8096 Use unsigned char, to match FcChar8 type definition.
8098 * xterm.c (handle_one_xevent):
8099 * xmenu.c (create_and_show_popup_menu):
8100 * xselect.c (x_decline_selection_request)
8101 (x_reply_selection_request): Avoid type-punned deref of X events.
8103 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8105 Fix some uses of `int' instead of EMACS_INT.
8106 * search.c (string_match_1, fast_string_match)
8107 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8108 (scan_buffer, find_next_newline_no_quit)
8109 (find_before_next_newline, search_command, Freplace_match)
8110 (Fmatch_data): Make some `int' variables be EMACS_INT.
8112 * xdisp.c (display_count_lines): 3rd argument and return value now
8113 EMACS_INT. All callers changed.
8114 (pint2hrstr): Last argument is now EMACS_INT.
8116 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8117 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8118 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8119 (decode_coding_utf_16, decode_coding_emacs_mule)
8120 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8121 (decode_coding_ccl, decode_coding_charset)
8122 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8123 (decode_coding_iso_2022, decode_coding_emacs_mule)
8124 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8125 <char_offset, last_offset>: Declare EMACS_INT.
8126 (encode_coding_utf_8, encode_coding_utf_16)
8127 (encode_coding_emacs_mule, encode_invocation_designation)
8128 (encode_designation_at_bol, encode_coding_iso_2022)
8129 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8130 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8132 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8133 (encode_invocation_designation): Last argument P_NCHARS is now
8135 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8136 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8138 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8141 * ccl.c (Fccl_execute_on_string): Declare some variables
8144 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8146 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8148 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8150 * process.c (Fformat_network_address): Doc fix.
8152 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8154 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8156 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8158 * keyboard.c (read_char): Call Lisp function help-form-show,
8159 instead of using internal_with_output_to_temp_buffer.
8160 (Qhelp_form_show): New var.
8161 (syms_of_keyboard): Use DEFSYM macro.
8163 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8165 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8167 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8169 * process.c (Flist_processes): Remove to Lisp.
8170 (list_processes_1): Delete.
8172 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8174 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8176 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8178 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8180 Fix more problems found by GCC 4.6.0's static checks.
8182 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8184 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8186 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8188 * xdisp.c (vmessage): Mark as a printf-like function.
8190 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8192 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8194 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8195 printf-like functions.
8196 (tiff_load): Add casts to remove these marks before passing them
8197 to system-supplied API.
8199 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8201 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8202 This avoids several warnings with gcc -Wstrict-overflow.
8203 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8204 directly, rather than having caller test rule sign. This avoids
8205 some unnecessary tests.
8206 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8207 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8208 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8210 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8211 (xfont_open): Avoid unnecessary tests.
8213 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8215 * composite.h, composite.c (composition_gstring_put_cache):
8216 Use EMACS_INT, not int, for length.
8218 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8219 breaking out part of COMPOSITION_DECODE_RULE.
8220 (COMPOSITION_DECODE_RULE): Use it.
8221 * composite.c (get_composition_id): Remove unused local vars,
8222 by using the new macro.
8224 * textprop.c (set_text_properties_1): Change while to do-while,
8225 since the condition is always true at first.
8227 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8228 (interval_deletion_adjustment): Return unsigned value.
8231 * process.c (list_processes_1, create_pty, read_process_output):
8232 (exec_sentinel): Remove vars that were set but not used.
8233 (create_pty): Remove unnecessary "volatile"s.
8234 (Fnetwork_interface_info): Avoid possibility of int overflow.
8235 (read_process_output): Do adaptive read buffering even if carryover.
8236 (read_process_output): Simplify nbytes computation if buffered.
8238 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8240 * syntax.c (scan_words): Remove var that was set but not used.
8241 (update_syntax_table): Use unsigned instead of int.
8243 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8244 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8245 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8247 * print.c (print_error_message): Avoid int overflow.
8249 * font.c (font_list_entities): Redo for clarity,
8250 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8252 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8253 (font_score): Avoid potential overflow in diff calculation.
8255 * fns.c (substring_both): Remove var that is set but not used.
8256 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8258 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8260 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8261 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8262 can always succeed if overflow has undefined behavior.
8264 * search.c (boyer_moore, wordify): Remove vars set but not used.
8265 (wordify): Omit three unnecessary tests.
8267 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8268 All callers changed. This avoids the need for an unused var.
8270 * casefiddle.c (casify_region): Remove var that is set but not used.
8272 * dired.c (file_name_completion): Remove var that is set but not used.
8274 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8276 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8277 (Finsert_file_contents): Remove unnecessary code checking fd.
8279 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8280 Check for integer overflow on size calculations.
8282 * buffer.c (Fprevious_overlay_change): Remove var that is set
8285 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8286 Remove vars that are set but not used.
8287 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8288 (timer_check_2): Mark vars as initialized.
8290 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8292 * image.c (lookup_image): Remove var that is set but not used.
8293 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8295 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8296 that are set but not used.
8298 * xfns.c (make_invisible_cursor): Don't return garbage
8299 if XCreateBitmapFromData fails (Bug#8410).
8301 * xselect.c (x_get_local_selection, x_handle_property_notify):
8302 Remove vars that are set but not used.
8304 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8305 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8307 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8308 Remove var that is set but not used.
8309 (scroll_bar_windows_size): Now size_t, not int.
8310 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8313 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8314 (map_tty_color) [!defined MSDOS]: Likewise.
8316 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8318 * coding.c: Remove vars that are set but not used.
8319 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8320 All callers changed.
8321 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8322 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8323 (decode_coding_charset): Remove vars that are set but not used.
8325 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8326 that is set but not used.
8328 * print.c (print_object): Remove var that is set but not used.
8330 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8331 The gnulib version avoids calling malloc in the usual case,
8332 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8333 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8334 * filelock.c (current_lock_owner): Likewise.
8335 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8336 * sysdep.c: Include allocator.h, careadlinkat.h.
8337 (emacs_no_realloc_allocator): New static constant.
8338 (emacs_readlink): New function.
8339 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8340 ../lib/careadlinkat.h.
8342 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8344 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8345 first non-nil return value).
8347 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8349 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8350 if not defined (Bug#8403).
8352 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8354 * xdisp.c (display_count_lines): Remove parameter `start',
8355 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8356 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8357 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8358 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8359 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8360 and thereabouts. All callers changed.
8361 (get_per_char_metric): Remove parameter `f', unused since
8362 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8364 2011-04-02 Jim Meyering <meyering@redhat.com>
8366 do not dereference NULL upon failed strdup
8367 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8368 (ns_get_family): Likewise.
8370 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8372 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8374 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8376 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8379 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8381 Add lexical binding.
8383 * window.c (Ftemp_output_buffer_show): New fun.
8384 (Fsave_window_excursion):
8385 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8387 * lread.c (lisp_file_lexically_bound_p): New function.
8388 (Fload): Bind Qlexical_binding.
8389 (readevalloop): Remove `evalfun' arg.
8390 Bind Qinternal_interpreter_environment.
8391 (Feval_buffer): Bind Qlexical_binding.
8392 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8394 (syms_of_lread): Declare `lexical-binding'.
8396 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8398 * keyboard.c (eval_dyn): New fun.
8399 (menu_item_eval_property): Use it.
8401 * image.c (parse_image_spec): Use Ffunctionp.
8403 * fns.c (concat, mapcar1): Accept byte-code-functions.
8405 * eval.c (Fsetq): Handle lexical vars.
8406 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8407 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8408 (FletX, Flet): Obey lexical binding.
8409 (Fcommandp): Handle closures.
8410 (Feval): New `lexical' arg.
8411 (eval_sub): New function extracted from Feval. Use it almost
8412 everywhere where Feval was used. Look up vars in lexical env.
8414 (Ffunctionp): Move from subr.el.
8415 (Ffuncall): Handle closures.
8416 (apply_lambda): Remove `eval_flags'.
8417 (funcall_lambda): Handle closures and new byte-code-functions.
8418 (Fspecial_variable_p): New function.
8419 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8420 but without exporting it to Lisp.
8422 * doc.c (Fdocumentation, store_function_docstring):
8423 * data.c (Finteractive_form): Handle closures.
8425 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8428 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8430 (exec_byte_code): New function extracted from Fbyte_code to handle new
8431 calling convention for byte-code-functions. Add new byte-codes.
8433 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8435 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8437 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8439 * xdisp.c (redisplay_internal): Fix prototype.
8441 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8443 * xdisp.c (SCROLL_LIMIT): New macro.
8444 (try_scrolling): Use it when setting scroll_limit.
8445 Limit scrolling to 100 screen lines.
8446 (redisplay_window): Even when falling back on "recentering",
8447 position point in the window according to scroll-conservatively,
8448 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8450 (try_scrolling): When point is above the window, allow searching
8451 as far as scroll_max, or one screenful, to compute vertical
8452 distance from PT to the scroll margin position. This prevents
8453 try_scrolling from unnecessarily failing when
8454 scroll-conservatively is set to a value slightly larger than the
8455 window height. Clean up the case of PT below the margin at bottom
8456 of window: scroll_max can no longer be INT_MAX. When aggressive
8457 scrolling is in use, don't let point enter the opposite scroll
8458 margin as result of the scroll.
8459 (syms_of_xdisp) <scroll-conservatively>: Document the
8460 threshold of 100 lines for never-recentering scrolling.
8462 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8464 * dispextern.h (move_it_by_lines):
8465 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8466 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8467 (message_log_check_duplicate): Remove parameters `prev_bol' and
8468 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8469 (redisplay_internal): Remove parameter `preserve_echo_area',
8470 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8472 * indent.c (Fvertical_motion):
8473 * window.c (window_scroll_pixel_based, Frecenter):
8474 Don't pass `need_y_p' to `move_it_by_lines'.
8476 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8478 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8479 steal a few bits to be more compact.
8480 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8481 Remove unneeded casts.
8483 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8485 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8487 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8488 binding" message (bug#7967).
8490 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8492 Fix more problems found by GCC 4.6.0's static checks.
8494 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8495 Remove unused local var.
8497 * editfns.c (Fmessage_box): Remove unused local var.
8499 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8500 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8501 Omit unused local vars.
8502 * window.c (shrink_windows): Omit unused local var.
8503 * menu.c (digest_single_submenu): Omit unused local var.
8504 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8505 Omit unused local var.
8507 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8508 Don't assume string length fits in int.
8509 (keyremap_step, read_key_sequence): Use size_t for sizes.
8510 (read_key_sequence): Don't check last_real_key_start redundantly.
8512 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8513 instead of alloca (Bug#8344).
8515 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8516 (Fbacktrace_frame): Don't assume nframes fits in int.
8518 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8520 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8523 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8525 * cm.c (calccost): Turn while-do into do-while, for clarity.
8527 * keyboard.c (syms_of_keyboard): Use the same style as later
8528 in this function when indexing through an array. This also
8529 works around GCC bug 48267.
8531 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8533 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8535 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8536 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8538 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8539 This avoids undefined behavior on integer overflow, and is a bit
8540 more convenient anyway since it is compared to a size_t variable.
8542 Variadic C functions now count arguments with size_t, not int.
8543 This avoids an unnecessary limitation on 64-bit machines, which
8544 caused (substring ...) to crash on large vectors (Bug#8344).
8545 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8546 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8547 All variadic functions and their callers changed accordingly.
8548 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8549 * data.c (arith_driver, float_arith_driver): Likewise.
8550 * editfns.c (general_insert_function): Likewise.
8551 * eval.c (struct backtrace.nargs, interactive_p)
8552 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8553 (funcall_lambda, mark_backtrace): Likewise.
8554 * fns.c (concat): Likewise.
8555 * frame.c (x_set_frame_parameters): Likewise.
8556 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8557 0 if not found, not -1. All callers changed.
8559 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8560 (stack_copy_size): Now size_t, not int.
8561 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8563 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8565 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8566 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8567 All callers changed.
8569 * lisp.h (multibyte_char_to_unibyte):
8570 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8571 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8572 * character.h (CHAR_TO_BYTE8):
8573 * cmds.c (internal_self_insert):
8574 * editfns.c (general_insert_function):
8575 * keymap.c (push_key_description):
8576 * search.c (Freplace_match):
8577 * xdisp.c (message_dolog, set_message_1): All callers changed.
8579 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8581 * keyboard.c (safe_run_hook_funcall): New function.
8582 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8583 don't set the hook to nil, but remove the offending function instead.
8584 (Qcommand_hook_internal): Remove, unused.
8585 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8586 Vcommand_hook_internal.
8588 * eval.c (enum run_hooks_condition): Remove.
8589 (funcall_nil, funcall_not): New functions.
8590 (run_hook_with_args): Call each function through a `funcall' argument.
8591 Remove `cond' argument, now redundant.
8592 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8593 (Frun_hook_with_args_until_failure): Adjust accordingly.
8594 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8596 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8598 * dispextern.h (string_buffer_position): Remove declaration.
8600 * print.c (strout): Remove parameter `multibyte', unused since
8601 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8603 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8604 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8605 All callers changed.
8607 * w32.c (_wsa_errlist): Use braces for struct initializers.
8609 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8610 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8611 All callers changed.
8612 (string_buffer_position): Likewise. Also, make static (it's never
8613 used outside xdisp.c).
8614 (cursor_row_p): Remove parameter `w', unused since
8615 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8616 (decode_mode_spec): Remove parameter `precision', introduced during
8617 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8618 All callers changed.
8620 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8622 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8624 2011-03-27 Anders Lindgren <andlind@gmail.com>
8626 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8627 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8628 (ns_update_auto_hide_menu_bar): New functions.
8629 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8630 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8631 ns_constrain_all_frames.
8632 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8633 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8635 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8637 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8639 2011-03-27 Glenn Morris <rgm@gnu.org>
8641 * syssignal.h: Replace RETSIGTYPE with void.
8642 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8643 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8644 Replace SIGTYPE with void everywhere.
8645 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8646 * s/template.h (SIGTYPE): Remove commented out definition.
8648 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8650 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8651 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8653 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8655 * w32.c (read_unc_volume): Use parameter `henum', instead of
8656 global variable `wget_enum_handle'.
8658 * keymap.c (describe_vector): Remove parameters `indices' and
8659 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8660 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8662 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8664 * keyboard.c (timer_check): Remove parameter `do_it_now',
8665 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8666 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8667 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8669 * keyboard.c (read_char):
8670 * w32menu.c (w32_menu_display_help):
8671 * xmenu.c (show_help_event, menu_help_callback):
8672 Adjust calls to `show_help_echo'.
8674 * gtkutil.c (xg_maybe_add_timer):
8675 * keyboard.c (readable_events):
8676 * process.c (wait_reading_process_output):
8677 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8679 * insdel.c (adjust_markers_gap_motion):
8680 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8681 (gap_left, gap_right): Don't call it.
8683 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8685 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8686 incurred during fontification.
8688 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8690 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8691 (DEFVAR_PER_BUFFER): Don't pass it.
8693 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8694 (scrolling_window): Don't pass it.
8696 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8698 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8700 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8702 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8703 of variables specific to SELinux and computation of `encoded_absname'.
8705 * image.c (XPutPixel): Remove unused variable `height'.
8707 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8709 * unexw32.c (get_section_info): Remove unused variable `section'.
8711 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8712 (system_process_attributes): Remove unused variable `sess'.
8713 (sys_read): Remove unused variable `err'.
8715 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8716 (w32_wnd_proc): Remove unused variable `isdead'.
8717 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8718 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8719 (x_create_tip_frame): Remove unused variable `tem'.
8721 * w32inevt.c (w32_console_read_socket):
8722 Remove unused variable `no_events'.
8724 * w32term.c (x_draw_composite_glyph_string_foreground):
8725 Remove unused variable `width'.
8727 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8729 * w32term.c (x_set_glyph_string_clipping):
8730 Don't pass uninitialized region to CombineRgn.
8732 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8734 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8735 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8736 (Fx_close_connection): Remove unused variable `i'.
8738 * w32font.c (w32font_draw): Return number of glyphs.
8739 (w32font_open_internal): Remove unused variable `i'.
8740 (w32font_driver): Add missing initializer.
8742 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8743 (fill_in_menu): Remove unused variable `items_added'.
8745 * w32term.c (last_mouse_press_frame): Remove static global variable.
8746 (w32_clip_to_row): Remove unused variable `f'.
8747 (x_delete_terminal): Remove unused variable `i'.
8749 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8750 (NOTHING): Remove unused static global variable.
8751 (uniscribe_check_otf): Remove unused variable `table'.
8752 (uniscribe_font_driver): Add missing initializers.
8754 2011-03-23 Julien Danjou <julien@danjou.info>
8756 * term.c (Fsuspend_tty, Fresume_tty):
8757 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8758 * window.c (temp_output_buffer_show):
8759 * insdel.c (signal_before_change):
8760 * frame.c (Fhandle_switch_frame):
8761 * fileio.c (Fdo_auto_save):
8762 * emacs.c (Fkill_emacs):
8763 * editfns.c (save_excursion_restore):
8764 * cmds.c (internal_self_insert):
8765 * callint.c (Fcall_interactively):
8766 * buffer.c (Fkill_all_local_variables):
8767 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8769 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8770 unconditionally since it does the check itself.
8772 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8774 Fix more problems found by GCC 4.5.2's static checks.
8776 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8777 the first time through the loop, since we know p0 < p1 then.
8778 This also avoids a gcc -Wstrict-overflow warning.
8780 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8781 leading to a memory leak, possible in functions like
8782 load_charset_map_from_file that can allocate an unbounded number
8783 of objects (Bug#8318).
8785 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8786 that could (at least in theory) be that large.
8788 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8789 This is less likely to overflow, and avoids undefined behavior if
8790 overflow does occur. All callers changed. Use strtoul to scan
8791 for the unsigned long integer.
8792 (pint2hrstr): Simplify and tune code slightly.
8793 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8795 * scroll.c (do_scrolling): Work around GCC bug 48228.
8796 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8798 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8799 This also avoids a warning with gcc -Wstrict-overflow.
8800 (validate_x_resource_name): Simplify count usage.
8801 This also avoids a warning with gcc -Wstrict-overflow.
8803 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8806 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8808 * process.c (Fmake_network_process): Use socklen_t, not int,
8809 where POSIX says socklen_t is required in portable programs.
8810 This fixes a porting bug on hosts like 64-bit HP-UX, where
8811 socklen_t is wider than int (Bug#8277).
8812 (Fmake_network_process, server_accept_connection):
8813 (wait_reading_process_output, read_process_output):
8816 * process.c: Rename or move locals to avoid shadowing.
8817 (list_processes_1, Fmake_network_process):
8818 (read_process_output_error_handler, exec_sentinel_error_handler):
8819 Rename or move locals.
8820 (Fmake_network_process): Define label "retry_connect" only if needed.
8821 (Fnetwork_interface_info): Fix pointer signedness.
8822 (process_send_signal): Add cast to avoid pointer signedness problem.
8823 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8824 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8826 Make tparam.h and terminfo.c consistent.
8827 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8828 Include tparam.h instead, since it declares them.
8829 * cm.h (PC): Remove extern decl; tparam.h now does this.
8830 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8831 * terminfo.c: Include tparam.h, to check interfaces.
8832 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8833 (tparam): Adjust signature to match interface in tparam.h;
8834 this removes some undefined behavior. Check that outstring and len
8835 are zero, which they always are with Emacs.
8836 * tparam.h (PC, BC, UP): New extern decls.
8838 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8839 (xftfont_open): Rename locals to avoid shadowing.
8841 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8842 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8843 (OTF_TAG_SYM): Omit macro if not needed.
8844 (ftfont_list): Remove unused local.
8845 (get_adstyle_property, ftfont_pattern_entity):
8846 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8847 Rename locals to avoid shadowing.
8849 * xfont.c (xfont_list_family): Mark var as initialized.
8851 * xml.c (make_dom): Now static.
8853 * composite.c (composition_compute_stop_pos): Rename local to
8855 (composition_reseat_it): Remove unused locals.
8856 (find_automatic_composition, composition_adjust_point): Likewise.
8857 (composition_update_it): Mark var as initialized.
8858 (find_automatic_composition): Mark vars as initialized,
8859 with a FIXME (Bug#8290).
8861 character.h: Rename locals to avoid shadowing.
8862 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8863 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8864 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8865 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8868 * textprop.c (property_change_between_p): Remove; unused.
8870 * intervals.c (interval_start_pos): Now static.
8872 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8874 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8875 Rename locals to avoid shadowing.
8877 * sound.c (wav_play, au_play, Fplay_sound_internal):
8878 Fix pointer signedness.
8879 (alsa_choose_format): Remove unused local var.
8880 (wav_play): Initialize a variable to 0, to prevent undefined
8881 behavior (Bug#8278).
8883 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8885 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8887 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8888 clobbering (Bug#8298).
8889 * sysdep.c (sys_subshell): Likewise.
8890 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8892 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8893 This should get cleaned up, so that child_setup has the
8894 same signature on all platforms.
8896 * callproc.c (call_process_cleanup): Now static.
8897 (relocate_fd): Rename locals to avoid shadowing.
8899 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8901 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8902 not to be necessary, and produces flickering.
8904 2011-03-20 Glenn Morris <rgm@gnu.org>
8906 * config.in: Remove file.
8908 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8910 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8911 are now in src/globals.h.
8912 (syms_of_minibuf): Remove spurious & from previous change.
8914 2011-03-20 Leo Liu <sdl.web@gmail.com>
8916 * minibuf.c (completing-read-function): New variable.
8917 (completing-read-default): Rename from completing-read.
8918 (completing-read): Call completing-read-function.
8920 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8922 * xfaces.c (Fx_load_color_file):
8923 Read color file from absolute filename (bug#8250).
8925 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8927 * makefile.w32-in: Update dependencies.
8929 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8931 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8933 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8935 Fix more problems found by GCC 4.5.2's static checks.
8937 * process.c (make_serial_process_unwind, send_process_trap):
8938 (sigchld_handler): Now static.
8940 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8941 That way, the code declares only the vars that it needs.
8942 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8943 * s/cygwin.h (PTY_ITERATION): Likewise.
8944 * s/darwin.h (PTY_ITERATION): Likewise.
8945 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8947 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8948 * process.c (allocate_pty): Don't declare stb unless it's needed.
8950 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8951 (CONSTANTLIM): Remove; unused.
8952 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8953 Define only if needed.
8955 * unexelf.c (unexec): Name an expression,
8956 to avoid gcc -Wbad-function-cast warning.
8957 Use a different way to cause a compilation error if anyone uses
8958 n rather than nn, a way that does not involve shadowing.
8959 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8961 * deps.mk (unexalpha.o): Remove; unused.
8963 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8964 * unexec.h: New file.
8965 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8966 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8968 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8969 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8970 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8971 Change as necessary to match prototype in unexec.h.
8973 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8975 (back_comment, skip_chars): Mark vars as initialized.
8977 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8978 Rename locals to avoid shadowing.
8980 * lread.c (read1): Rewrite so as not to use empty "else".
8981 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8983 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8985 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8986 warning when compiling print.c.
8988 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8989 instead of using an uninitialized var.
8990 (font_sort_entities): Mark var as initialized.
8992 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8994 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8995 pointers to constants.
8996 (font_parse_fcname): Remove unused vars.
8997 (font_delete_unmatched): Now static.
8998 (font_get_spec): Remove; unused.
8999 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9000 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9001 Rename or move locals to avoid shadowing.
9003 * fns.c (require_nesting_list, require_unwind): Now static.
9004 (Ffillarray): Rename locals to avoid shadowing.
9006 * floatfns.c (domain_error2): Define only if needed.
9007 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9009 * alloc.c (mark_backtrace): Move decl from here ...
9010 * lisp.h: ... to here, so that it can be checked.
9012 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9013 (Fdefvar): Rewrite so as not to use empty "else".
9014 (lisp_indirect_variable): Name an expression,
9015 to avoid gcc -Wbad-function-cast warning.
9016 (Fdefvar): Rename locals to avoid shadowing.
9018 * callint.c (quotify_arg, quotify_args): Now static.
9019 (Fcall_interactively): Rename locals to avoid shadowing.
9020 Use const pointer when appropriate.
9022 * lisp.h (get_system_name, get_operating_system_release):
9023 Move decls here, to check interfaces.
9024 * process.c (get_operating_system_release): Move decl to lisp.h.
9025 * xrdb.c (get_system_name): Likewise.
9026 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9027 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9028 some of which prompt warnings from gcc -Wbad-function-cast.
9029 (Fformat_time_string, Fencode_time, Finsert_char):
9030 (Ftranslate_region_internal, Fformat):
9031 Rename or remove local vars to avoid shadowing.
9032 (Ftranslate_region_internal): Mark var as initialized.
9034 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9037 * lisp.h (eassert): Check that the argument compiles, even if
9038 ENABLE_CHECKING is not defined.
9040 * data.c (Findirect_variable): Name an expression, to avoid
9041 gcc -Wbad-function-cast warning.
9042 (default_value, arithcompare, arith_driver, arith_error): Now static.
9043 (store_symval_forwarding): Rename local to avoid shadowing.
9044 (Fmake_variable_buffer_local, Fmake_local_variable):
9045 Mark variables as initialized.
9046 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9048 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9049 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9050 Rename locals to avoid shadowing.
9051 (mark_stack): Move local variables into the #ifdef region where
9053 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9054 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9056 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9057 (GC_STRING_CHARS): Remove; not used.
9058 (Fmemory_limit): Cast sbrk's returned value to char *.
9060 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9061 avoids undefined behavior in theory.
9063 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9065 Use functions, not macros, for up- and down-casing (Bug#8254).
9066 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9067 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9068 to use the following functions instead of these macros.
9069 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9070 EMACS_INT, since callers assume the returned value fits in int.
9071 (upcase1): Likewise, for UPCASE_TABLE.
9072 (uppercasep, lowercasep, upcase): New static inline functions.
9073 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9074 the race-condition problem in the old DOWNCASE.
9076 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9077 Rename locals to avoid shadowing.
9078 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9079 (regex_compile, re_search_2, re_match_2_internal):
9080 Remove unused local vars.
9081 (FREE_VAR): Rewrite so as not to use empty "else",
9082 which gcc can warn about.
9083 (regex_compile, re_match_2_internal): Mark locals as initialized.
9084 (RETALLOC_IF): Define only if needed.
9085 (WORDCHAR_P): Likewise. This one is never needed, but is used
9086 only in a comment talking about a compiler bug, so put inside
9087 the #if 0 of that comment.
9088 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9089 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9092 * search.c (boyer_moore): Rename locals to avoid shadowing.
9093 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9094 (PREV_CHAR_BOUNDARY): Likewise.
9096 * search.c (simple_search): Remove unused var.
9098 * dired.c (compile_pattern): Move decl from here ...
9099 * lisp.h: ... to here, so that it can be checked.
9100 (struct re_registers): New forward decl.
9102 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9104 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9106 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9107 Rename locals to avoid shadowing.
9108 (Fvertical_motion): Mark locals as initialized.
9110 * casefiddle.c (casify_object, casify_region): Now static.
9111 (casify_region): Mark local as initialized.
9113 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9115 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9116 New macros, so that the caller can use some names other than
9117 gcpro1, gcpro2, etc.
9118 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9120 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9121 argument, for consistency with GCPRO2_VAR, etc: it is now the
9122 prefix of the variable, not the variable itself. All uses
9124 * dired.c (directory_files_internal, file_name_completion):
9125 Rename locals to avoid shadowing.
9127 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9128 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9129 dired.c's scmp function, had undefined behavior.
9130 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9131 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9132 * buffer.h: ... to here, because these macros use current_buffer,
9133 and the new implementation with inline functions needs to have
9134 current_buffer in scope now, rather than later when the macros
9136 (downcase, upcase1): New static inline functions.
9137 (DOWNCASE, UPCASE1): Reimplement using these functions.
9138 This avoids undefined behavior in expressions like
9139 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9140 from race conditions in accessing the global variables
9141 case_temp1 and case_temp2.
9142 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9143 * lisp.h (case_temp1, case_temp2): Remove their decls.
9144 * character.h (ASCII_CHAR_P): Move from here ...
9145 * lisp.h: ... to here, so that the inline functions mentioned
9148 * dired.c (directory_files_internal_unwind): Now static.
9150 * fileio.c (file_name_as_directory, directory_file_name):
9151 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9153 (file_name_as_directory): Use const pointers when appropriate.
9154 (Fexpand_file_name): Likewise. In particular, newdir might
9155 point at constant storage, so make it a const pointer.
9156 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9157 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9159 (Fset_file_times, Finsert_file_contents, auto_save_error):
9160 Rename locals to avoid shadowing.
9162 * minibuf.c (choose_minibuf_frame_1): Now static.
9163 (Ftry_completion, Fall_completions): Rename or remove locals
9166 * marker.c (bytepos_to_charpos): Remove; unused.
9168 * lisp.h (verify_bytepos, count_markers): New decls,
9169 so that gcc does not warn that these functions aren't declared.
9171 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9172 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9173 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9174 (copy_text): Remove unused local var.
9176 * filelock.c (within_one_second): Now static.
9177 (lock_file_1): Rename local to avoid shadowing.
9179 * buffer.c (fix_overlays_before): Mark locals as initialized.
9180 (fix_start_end_in_overlays): Likewise. This function should be
9181 simplified by using pointers-to-pointers, but that's a different
9183 (switch_to_buffer_1): Now static.
9184 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9185 (report_overlay_modification): Rename locals to avoid shadowing.
9187 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9188 Fix pointer signedness issue.
9189 (sys_subshell): Mark local as volatile if checking for lint,
9190 to suppress a gcc -Wclobbered warning that does not seem to be right.
9191 (MAXPATHLEN): Define only if needed.
9193 * process.c (serial_open, serial_configure): Move decls from here ...
9194 * systty.h: ... to here, so that they can be checked.
9196 * fns.c (get_random, seed_random): Move extern decls from here ...
9197 * lisp.h: ... to here, so that they can be checked.
9199 * sysdep.c (reset_io): Now static.
9200 (wait_for_termination_signal): Remove; unused.
9202 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9203 (copy_keymap_item, append_key, push_text_char_description):
9205 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9206 (DENSE_TABLE_SIZE): Remove; unused.
9207 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9208 (describe_map_tree):
9209 Rename locals to avoid shadowing.
9211 * keyboard.c: Declare functions static if they are not used elsewhere.
9212 (echo_char, echo_dash, cmd_error, top_level_2):
9213 (poll_for_input, handle_async_input): Now static.
9214 (read_char, kbd_buffer_get_event, make_lispy_position):
9215 (make_lispy_event, make_lispy_movement, apply_modifiers):
9216 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9217 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9218 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9219 (read_key_sequence, read_char): Mark locals as initialized.
9220 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9222 * keyboard.h (make_ctrl_char): New decl.
9223 (mark_kboards): Move decl here ...
9224 * alloc.c (mark_kboards): ... from here.
9226 * lisp.h (force_auto_save_soon): New decl.
9228 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9229 (DEFINE_DUMMY_FUNCTION): New macro.
9230 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9232 (main): Add casts to avoid warnings
9233 if GCC considers string literals to be constants.
9235 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9237 * dbusbind.c: Pointer signedness fixes.
9238 (xd_signature, xd_append_arg, xd_initialize):
9239 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9240 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9241 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9242 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9244 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9245 if GCC considers string literals to be constants.
9246 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9248 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9250 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9251 (print_preprocess, print_object): New macro to fix last change.
9253 * print.c (print_preprocess): Don't forget font objects.
9255 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9257 * emacs.c (USAGE3): Doc fixes.
9259 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9261 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9264 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9266 * lisp.h (VWindow_system, Qfile_name_history):
9267 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9268 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9269 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9271 * w32select.c: Don't #include "keyboard.h".
9272 (run_protected): Add extern declaration for waiting_for_input.
9274 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9275 * w32console.c (detect_input_pending, read_input_pending)
9276 (encode_terminal_code):
9277 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9278 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9279 (w32_system_caret_y, Qfile_name_history):
9280 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9281 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9282 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9283 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9284 * w32proc.c (Qlocal, report_file_error):
9285 * w32term.c (Vwindow_system, updating_frame):
9286 * w32uniscribe.c (initialized, uniscribe_font_driver):
9287 Remove unneeded extern declarations.
9289 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9291 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9293 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9295 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9296 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9297 These macros can no longer be used for assignment.
9299 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9300 Assign struct members directly, instead of using BUF_BEGV etc.
9301 (record_buffer_markers, fetch_buffer_markers): New functions for
9302 recording and fetching special buffer markers.
9303 (set_buffer_internal_1, set_buffer_temp): Use them.
9305 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9307 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9309 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9310 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9312 * xdisp.c (hscroll_window_tree):
9313 (reconsider_clip_changes): Use PT instead of BUF_PT.
9315 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9317 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9318 $(EMACS_ROOT)/lib/intprops.h.
9320 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9322 Fix more problems found by GCC 4.5.2's static checks.
9324 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9325 to unsigned char * to avoid compiler diagnostic.
9326 (xg_free_frame_widgets): Make it clear that a local variable is
9327 needed only if USE_GTK_TOOLTIP.
9328 (gdk_window_get_screen): Make it clear that this macro is needed
9329 only if USE_GTK_TOOLTIP.
9330 (int_gtk_range_get_value): New function, which avoids a diagnostic
9331 from gcc -Wbad-function-cast.
9332 (xg_set_toolkit_scroll_bar_thumb): Use it.
9333 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9334 diagnostic from gcc -Wbad-function-cast.
9335 (get_utf8_string, xg_get_file_with_chooser):
9336 Rename locals to avoid shadowing.
9337 (create_dialog): Move locals to avoid shadowing.
9339 * xgselect.c (xg_select): Remove unused var.
9341 * image.c (four_corners_best): Mark locals as initialized.
9342 (gif_load): Initialize transparent_p to zero (Bug#8238).
9343 Mark another local as initialized.
9344 (my_png_error, my_error_exit): Mark with NO_RETURN.
9346 * image.c (clear_image_cache): Now static.
9347 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9348 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9349 (x_edge_detection): Remove unnecessary cast that
9350 gcc -Wbad-function-cast diagnoses.
9351 (gif_load): Fix pointer signedness.
9352 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9353 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9355 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9357 Improve quality of tests for time stamp overflow.
9358 For example, without this patch (encode-time 0 0 0 1 1
9359 1152921504606846976) returns the obviously-bogus value (-948597
9360 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9361 reports time overflow. See
9362 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9363 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9364 * editfns.c: Include limits.h and intprops.h.
9365 (TIME_T_MIN, TIME_T_MAX): New macros.
9366 (time_overflow): Move earlier, to before first use.
9367 (hi_time, lo_time): New functions, for an accurate test for
9369 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9370 (Fget_internal_run_time): Don't assume time_t fits in int.
9371 (make_time): Use list2 instead of Fcons twice.
9372 (Fdecode_time): More accurate test for out-of-range times.
9373 (check_tm_member): New function.
9374 (Fencode_time): Use it, to test for out-of-range times.
9375 (lisp_time_argument): Don't rely on undefined left-shift and
9376 right-shift behavior when checking for time stamp overflow.
9378 * editfns.c (time_overflow): New function, refactoring common code.
9379 (Fformat_time_string, Fdecode_time, Fencode_time):
9380 (Fcurrent_time_string): Use it.
9382 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9383 * dired.c (make_time): Move to ...
9384 * editfns.c (make_time): ... here.
9385 * systime.h: Note the move.
9387 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9389 * fringe.c (update_window_fringes): Remove unused variables.
9391 * unexmacosx.c (copy_data_segment): Also copy __got section.
9394 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9396 * termcap.c [MSDOS]: Include "msdos.h".
9397 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9398 Constify `char *' arguments and their references according to
9399 prototypes in tparam.h.
9401 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9403 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9404 Adapt all references accordingly.
9406 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9408 2011-03-11 Tom Tromey <tromey@redhat.com>
9410 * buffer.c (syms_of_buffer): Remove obsolete comment.
9412 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9414 * termhooks.h (encode_terminal_code): Declare prototype.
9416 * msdos.c (encode_terminal_code): Don't declare prototype.
9418 * term.c (encode_terminal_code): Now external again, used by
9419 w32console.c and msdos.c.
9421 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9422 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9424 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9426 Fix some minor problems found by GCC 4.5.2's static checks.
9428 * fringe.c (update_window_fringes): Mark locals as initialized
9430 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9432 * alloc.c (mark_fringe_data): Move decl from here ...
9433 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9434 to check its interface.
9435 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9437 * fontset.c (free_realized_fontset): Now static.
9438 (Fset_fontset_font): Rename local to avoid shadowing.
9439 (fontset_font): Mark local as initialized.
9440 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9442 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9444 * xselect.c (x_disown_buffer_selections): Remove; not used.
9445 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9446 (x_own_selection, Fx_disown_selection_internal): Rename locals
9448 (x_handle_dnd_message): Remove local to avoid shadowing.
9450 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9451 so that the caller can use some name other than gcpro1.
9452 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9453 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9454 (Fx_backspace_delete_keys_p):
9455 Use them to avoid shadowing, and rename vars to avoid shadowing.
9456 (x_decode_color, x_set_name, x_window): Now static.
9457 (Fx_create_frame): Add braces to silence GCC warning.
9458 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9459 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9460 Remove unused locals.
9461 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9462 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9463 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9466 * xterm.h (x_mouse_leave): New decl.
9468 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9469 Remove unused functions.
9470 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9471 (x_calc_absolute_position): Now static.
9472 (XTread_socket): Don't define label "out" unless it's used.
9473 Don't declare local "event" unless it's used.
9474 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9475 unless they are used.
9476 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9477 (x_fatal_error_signal): Remove; not used.
9478 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9479 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9480 (x_error_catcher, x_connection_closed, x_error_handler):
9481 (x_error_quitter, xembed_send_message, x_iconify_frame):
9482 (my_log_handler): Rename locals to avoid shadowing.
9483 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9484 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9486 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9487 Rename or move locals to avoid shadowing.
9488 (tty_defined_color, merge_face_heights): Now static.
9489 (free_realized_faces_for_fontset): Remove; not used.
9490 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9491 does not deduce is never used uninitialized.
9492 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9493 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9495 * terminal.c (store_terminal_param): Now static.
9497 * xmenu.c (menu_highlight_callback): Now static.
9498 (set_frame_menubar): Remove unused local.
9499 (xmenu_show): Rename parameter to avoid shadowing.
9500 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9501 since they might point to immutable storage.
9502 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9503 since it's unused otherwise.
9505 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9506 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9507 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9508 avoids a gcc -Wuninitialized diagnostic.
9509 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9510 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9511 does not deduce are never used uninitialized.
9513 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9515 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9516 * window.c (window_loop, size_window):
9517 (run_window_configuration_change_hook, enlarge_window): Likewise.
9519 * window.c (display_buffer): Now static.
9520 (size_window): Mark variables that gcc -Wuninitialized
9521 does not deduce are never used uninitialized.
9522 * window.h (check_all_windows): New decl, to forestall
9523 gcc -Wmissing-prototypes diagnostic.
9524 * dispextern.h (bidi_dump_cached_states): Likewise.
9526 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9528 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9530 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9531 and to avoid gcc -Wuninitialized warning.
9532 (load_charset_map): Mark variables that gcc -Wuninitialized
9533 does not deduce are never used uninitialized.
9534 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9536 * coding.c (coding_set_source, coding_set_destination):
9537 Use "else { /* comment */ }" rather than "else /* comment */;"
9538 for clarity, and to avoid gcc -Wempty-body warning.
9539 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9540 a block, when the outer 'i' will do.
9541 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9542 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9543 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9544 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9545 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9546 Rename locals to avoid shadowing.
9547 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9548 * coding.c (emacs_mule_char, encode_invocation_designation):
9549 Now static, since they're not used elsewhere.
9550 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9551 (decode_coding_object, encode_coding_object, detect_coding_system):
9552 (decode_coding_emacs_mule): Mark variables that gcc
9553 -Wuninitialized does not deduce are never used uninitialized.
9554 (detect_coding_iso_2022): Initialize a local variable that might
9555 be used uninitialized. Leave a FIXME because it's not clear that
9556 this initialization is needed. (Bug#8211)
9557 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9558 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9559 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9560 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9561 Remove unused macros.
9563 * category.c (hash_get_category_set): Remove unused local var.
9564 (copy_category_table): Now static, since it's not used elsewhere.
9565 * character.c (string_count_byte8): Likewise.
9567 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9568 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9570 * chartab.c (copy_sub_char_table): Now static, since it's not used
9572 (sub_char_table_ref_and_range, char_table_ref_and_range):
9573 Rename locals to avoid shadowing.
9574 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9576 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9577 (BIDI_BOB): Remove unused macro.
9579 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9580 deduce are never used uninitialized.
9581 * term.c (encode_terminal_code): Likewise.
9583 * term.c (encode_terminal_code): Now static. Remove unused local.
9585 * tparam.h: New file.
9586 * term.c, tparam.h: Include it.
9587 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9588 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9589 Move these decls to tparam.h, and make them agree with what
9590 is actually in tparam.c. The previous trick of using incompatible
9591 decls in different modules does not conform to the C standard.
9592 All callers of tparam changed to use tparam's actual API.
9593 * tparam.c (tparam1, tparam, tgoto):
9594 Use const pointers where appropriate.
9596 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9597 * cm.h (struct cm): Likewise.
9598 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9599 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9600 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9601 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9602 (turn_on_face, init_tty): Likewise.
9603 * termchar.h (struct tty_display_info): Likewise.
9605 * term.c (term_mouse_position): Rename local to avoid shadowing.
9607 * alloc.c (mark_ttys): Move decl from here ...
9608 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9610 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9612 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9614 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9616 * search.c (compile_pattern_1): Remove argument regp, unused since
9617 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9618 (compile_pattern): Don't pass it.
9620 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9622 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9623 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9625 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9627 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9629 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9630 gdk_window_get_screen, gdk_window_get_geometry,
9631 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9632 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9633 (xg_get_pixbuf_from_pixmap): New function.
9634 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9635 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9636 Call xg_get_pixbuf_from_pixmap instead of
9637 gdk_pixbuf_get_from_drawable.
9638 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9639 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9640 (xg_check_special_colors): Use GtkStyleContext and its functions
9642 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9643 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9644 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9645 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9646 Call gtk_widget_get_preferred_size.
9647 (xg_frame_resized): gdk_window_get_geometry only takes 5
9649 (xg_win_to_widget, xg_event_is_for_menubar):
9650 Call gdk_x11_window_lookup_for_display.
9651 (xg_set_widget_bg): New function.
9652 (delete_cb): New function.
9653 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9654 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9655 (xg_set_background_color): Call xg_set_widget_bg.
9656 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9657 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9658 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9659 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9661 (update_frame_tool_bar): Call gtk_widget_hide.
9662 (xg_initialize): Use GDK_KEY_g.
9664 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9666 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9668 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9669 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9670 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9672 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9674 * w32xfns.c (select_palette): Check success of RealizePalette against
9675 GDI_ERROR, not zero.
9677 See ChangeLog.11 for earlier changes.
9683 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9685 This file is part of GNU Emacs.
9687 GNU Emacs is free software: you can redistribute it and/or modify
9688 it under the terms of the GNU General Public License as published by
9689 the Free Software Foundation, either version 3 of the License, or
9690 (at your option) any later version.
9692 GNU Emacs is distributed in the hope that it will be useful,
9693 but WITHOUT ANY WARRANTY; without even the implied warranty of
9694 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9695 GNU General Public License for more details.
9697 You should have received a copy of the GNU General Public License
9698 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.