1 2011-06-18 Paul Eggert <eggert@cs.ucla.edu>
3 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4 Use much-faster test for byte-length change.
6 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8 * fns.c (concat): Catch string overflow earlier.
9 Do not rely on integer wraparound.
11 * dispextern.h (struct it.overlay_strings_charpos): EMACS_INT, not int.
13 2011-06-17 Paul Eggert <eggert@cs.ucla.edu>
15 * dispextern.h (struct it.selective): Now EMACS_INT, not int.
16 * xdisp.c (forward_to_next_line_start)
17 (back_to_previous_visible_line_start)
18 (reseat_at_next_visible_line_start, next_element_from_buffer):
19 Don't arbitrarily truncate the value of 'selective' to int.
21 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
23 * composite.c: Don't truncate sizes to 'int'.
24 (composition_gstring_p, composition_reseat_it)
25 (composition_adjust_point): Use EMACS_INT, not int.
26 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
27 not EMACS_UINT, for indexes.
29 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
31 * buffer.c: Include <verify.h>.
32 (struct sortvec.priority, struct sortstr.priority):
33 Now EMACS_INT, not int.
34 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
35 (struct sortstr.size, record_overlay_string)
36 (struct sortstrlist.size, struct sortlist.used):
37 Don't truncate size to int.
38 (record_overlay_string): Check for size-calculation overflow.
39 (init_buffer_once): Check at compile-time, not run-time.
41 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
43 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
44 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
45 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
47 Improve buffer-overflow checking (Bug#8873).
48 * fileio.c (Finsert_file_contents):
49 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
50 Remove the old (too-loose) buffer overflow checks.
51 They weren't needed, since make_gap checks for buffer overflow.
52 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
53 The old code merely checked for Emacs fixnum overflow, and relied
54 on undefined (wraparound) behavior. The new code avoids undefined
55 behavior, and also checks for ptrdiff_t and/or size_t overflow.
57 * editfns.c (Finsert_char): Don't dump core with very negative counts.
58 Tune. Don't use wider integers than needed. Don't use alloca.
59 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
61 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
63 * insdel.c, lisp.h (buffer_overflow): New function.
64 (insert_from_buffer_1, replace_range, replace_range_2):
65 * insdel.c (make_gap_larger):
66 * editfns.c (Finsert_char):
67 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
69 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
71 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
73 Integer overflow and signedness fixes (Bug#8873).
75 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
76 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
78 * fileio.c: Don't assume EMACS_INT fits in off_t.
79 (emacs_lseek): New static function.
80 (Finsert_file_contents, Fwrite_region): Use it.
81 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
83 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
85 * fns.c: Don't overflow int when computing a list length.
86 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
87 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
88 truncation on 64-bit hosts. Check for QUIT every
89 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
90 faster and is responsive enough.
91 (Flength): Report an error instead of overflowing an integer.
92 (Fsafe_length): Return a float if the value is not representable
93 as a fixnum. This shouldn't happen except in contrived situations.
94 (Fnthcdr, Fsort): Don't assume list length fits in int.
95 (Fcopy_sequence): Don't assume vector length fits in int.
97 * alloc.c: Check that resized vectors' lengths fit in fixnums.
98 (header_size, word_size): New constants.
99 (allocate_vectorlike): Don't check size overflow here.
100 (allocate_vector): Check it here instead, since this is the only
101 caller of allocate_vectorlike that could cause overflow.
102 Check that the new vector's length is representable as a fixnum.
104 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
105 The previous code was bogus. For example, next_almost_prime (32)
106 returned 39, which is undesirable as it is a multiple of 3; and
107 next_almost_prime (24) returned 25, which is a multiple of 5 so
108 why was the code bothering to check for multiples of 7?
110 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
112 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
114 Variadic C functions now count arguments with ptrdiff_t.
115 This partly undoes my 2011-03-30 change, which replaced int with size_t.
116 Back then I didn't know that the Emacs coding style prefers signed int.
117 Also, in the meantime I found a few more instances where arguments
118 were being counted with int, which may truncate counts on 64-bit
119 machines, or EMACS_INT, which may be unnecessarily wide.
120 * lisp.h (struct Lisp_Subr.function.aMANY)
121 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
122 Arg counts are now ptrdiff_t, not size_t.
123 All variadic functions and their callers changed accordingly.
124 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
125 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
126 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
127 * callint.c (Fcall_interactively): Check arg count for overflow,
128 to avoid potential buffer overrun. Use signed char, not 'int',
129 for 'varies' array, so that we needn't bother to check its size
130 calculation for overflow.
131 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
132 * eval.c (apply_lambda):
133 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
134 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
135 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
137 * callint.c (Fcall_interactively): Don't use index var as event count.
139 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
140 * mem-limits.h (SIZE): Remove; no longer used.
142 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
144 Remove unnecessary casts.
145 * xterm.c (x_term_init):
146 * xfns.c (x_set_border_pixel):
147 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
148 These aren't needed now that we assume ANSI C.
150 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
151 It's more likely to cause problems (due to unsigned overflow)
154 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
156 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
158 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
160 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
162 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
164 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
166 GLYPH_CODE_FACE returns EMACS_INT, not int.
167 * dispextern.h (merge_faces):
168 * xfaces.c (merge_faces):
169 * xdisp.c (get_next_display_element, next_element_from_display_vector):
170 Don't assume EMACS_INT fits in int.
172 * character.h (CHAR_VALID_P): Remove unused parameter.
173 * fontset.c, lisp.h, xdisp.c: All uses changed.
175 * editfns.c (Ftranslate_region_internal): Omit redundant test.
177 * fns.c (concat): Minor tuning based on overflow analysis.
178 This doesn't fix any bugs. Use int to hold character, instead
179 of constantly refetching from Emacs object. Use XFASTINT, not
180 XINT, for value known to be a character. Don't bother comparing
181 a single byte to 0400, as it's always less.
183 * floatfns.c (Fexpt):
184 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
186 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
189 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
191 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
192 Without this fix, on a 64-bit host (aset S 0 4294967386) would
193 incorrectly succeed when S was a string, because 4294967386 was
194 truncated before it was used.
196 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
197 Otherwise, an out-of-range integer could cause undefined behavior
200 * composite.c: Use int, not EMACS_INT, for characters.
201 (fill_gstring_body, composition_compute_stop_pos): Use int, not
202 EMACS_INT, for values that are known to be in character range.
203 This doesn't fix any bugs but is the usual style inside Emacs and
204 may generate better code on 32-bit machines.
206 Make sure a 64-bit char is never passed to ENCODE_CHAR.
207 This is for reasons similar to the recent CHAR_STRING fix.
208 * charset.c (Fencode_char): Check that character arg is actually
209 a character. Pass an int to ENCODE_CHAR.
210 * charset.h (ENCODE_CHAR): Verify that the character argument is no
211 wider than 'int', as a compile-time check to prevent future regressions
214 * character.c (char_string): Remove unnecessary casts.
216 Make sure a 64-bit char is never passed to CHAR_STRING.
217 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
218 by silently ignoring the top 32 bits, allowing some values
219 that were far too large to be valid characters.
220 * character.h: Include <verify.h>.
221 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
222 arguments are no wider than unsigned, as a compile-time check
223 to prevent future regressions in this area.
225 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
226 (Fsubst_char_in_region):
228 * xdisp.c (decode_mode_spec_coding):
229 Adjust to CHAR_STRING's new requirement.
230 * editfns.c (Finsert_char, Fsubst_char_in_region):
231 * fns.c (concat): Check that character args are actually
232 characters. Without this test, these functions did the wrong
233 thing with wildly out-of-range values on 64-bit hosts.
235 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
236 These casts should not be needed on 32-bit hosts, either.
237 * keyboard.c (read_char):
238 * lread.c (Fload): Remove casts to unsigned.
240 * lisp.h (UNSIGNED_CMP): New macro.
241 This fixes comparison bugs on 64-bit hosts.
242 (ASCII_CHAR_P): Use it.
243 * casefiddle.c (casify_object):
244 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
245 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
246 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
247 * dispextern.h (FACE_FROM_ID):
248 * keyboard.c (read_char): Use UNSIGNED_CMP.
250 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
251 not to EMACS_INT, to avoid GCC warning.
253 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
255 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
256 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
257 isn't needed on 32-bit machines.
259 * buffer.c (Fgenerate_new_buffer_name):
260 Use EMACS_INT for count, not int.
261 (advance_to_char_boundary): Return EMACS_INT, not int.
263 * data.c (Qcompiled_function): Now static.
265 * window.c (window_body_lines): Now static.
267 * image.c (gif_load): Rename local to avoid shadowing.
269 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
270 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
271 * alloc.c (make_save_value): Integer argument is now of type
273 (mark_object): Use ptrdiff_t, not int.
274 * lisp.h (pD): New macro.
275 * print.c (print_object): Use it.
277 * alloc.c: Use EMACS_INT, not int, to count objects.
278 (total_conses, total_markers, total_symbols, total_vector_size)
279 (total_free_conses, total_free_markers, total_free_symbols)
280 (total_free_floats, total_floats, total_free_intervals)
281 (total_intervals, total_strings, total_free_strings):
282 Now EMACS_INT, not int. All uses changed.
283 (Fgarbage_collect): Compute overall total using a double, so that
284 integer overflow is less likely to be a problem. Check for overflow
285 when converting back to an integer.
286 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
287 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
288 These were 'int' variables that could overflow on 64-bit hosts;
289 they were never used, so remove them instead of repairing them.
290 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
291 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
292 Previously, this ceilinged at INT_MAX, but that doesn't work on
294 (allocate_pseudovector): Don't use EMACS_INT when int would do.
296 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
297 (allocate_vectorlike): Check for ptrdiff_t overflow.
298 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
299 when a (possibly-narrower) signed value would do just as well.
300 We prefer using signed arithmetic, to avoid comparison confusion.
302 * alloc.c: Catch some string size overflows that we were missing.
303 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
304 for convenience in STRING_BYTES_MAX.
305 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
306 The definition here is exact; the one in lisp.h was approximate.
307 (allocate_string_data): Check for string overflow. This catches
308 some instances we weren't catching before. Also, it catches
309 size_t overflow on (unusual) hosts where SIZE_MAX <= min
310 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
311 and ptrdiff_t and EMACS_INT are both 64 bits.
313 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
314 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
315 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
317 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
319 * alloc.c (Fmake_string): Check for out-of-range init.
321 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
323 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
325 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
327 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
328 xg_get_default_scrollbar_width.
330 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
331 (int_gtk_range_get_value): Move to the scroll bar part of the file.
332 (style_changed_cb): Call update_theme_scrollbar_width and call
333 x_set_scroll_bar_default_width and xg_frame_set_char_size for
334 all frames (Bug#8505).
335 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
336 Call gtk_window_set_resizable if HAVE_GTK3.
337 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
338 and height if HAVE_GTK3 (Bug#8505).
339 (scroll_bar_width_for_theme): New variable.
340 (update_theme_scrollbar_width): New function.
341 (xg_get_default_scrollbar_width): Move code to
342 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
343 (xg_initialize): Call update_theme_scrollbar_width.
345 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
347 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
349 2011-06-12 Martin Rudalics <rudalics@gmx.at>
351 * frame.c (make_frame): Call other_buffer_safely instead of
354 * window.c (temp_output_buffer_show): Call display_buffer with
355 second argument Vtemp_buffer_show_specifiers and reset latter
356 immediately after the call.
357 (Vtemp_buffer_show_specifiers): New variable.
358 (auto_window_vscroll_p, next_screen_context_lines)
359 (Vscroll_preserve_screen_position): Remove leading asterisks from
362 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
364 Fix minor problems found by GCC 4.6.0 static checking.
365 * buffer.c (Qclone_number): Remove for now, as it's unused.
366 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
367 (record_buffer): Remove unused local.
368 * frame.c (other_visible_frames, frame_buffer_list): Now static.
369 (set_frame_buffer_list): Remove; unused.
370 * frame.h (other_visible_frames): Remove decl.
371 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
372 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
373 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
375 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
376 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
377 Define only if HAVE_GPM.
378 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
379 (update_hints_inhibit): Remove; never set. All uses removed.
380 * widgetprv.h (emacsFrameClassRec): Remove decl.
381 * window.c (delete_deletable_window): Now returns void, since it
382 wasn't returning anything.
383 (compare_window_configurations): Remove unused locals.
384 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
385 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
386 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
387 the same widths as pointers. This follows up on the 2011-05-06 patch.
388 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
390 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
392 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
394 * makefile.w32-in: Update dependencies.
395 (LISP_H): Add lib/intprops.h.
397 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
399 * image.c (gif_load): Add animation frame delay to the metadata.
400 (syms_of_image): Use DEFSYM. New symbol `delay'.
402 2011-06-11 Martin Rudalics <rudalics@gmx.at>
404 * window.c (delete_deletable_window): Re-add.
405 (Fset_window_configuration): Rewrite to handle dead buffers and
406 consequently deletable windows.
407 (window_tree, Fwindow_tree): Remove. Supply functionality in
409 (compare_window_configurations): Simplify code.
411 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
413 * image.c (imagemagick_load_image): Fix type mismatch.
414 (Fimagemagick_types): Likewise.
416 * window.h (replace_buffer_in_windows): Declare.
418 2011-06-11 Martin Rudalics <rudalics@gmx.at>
420 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
421 Qclone_number. Remove external declaration of Qdelete_window.
422 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
424 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
425 Qbuffer_list_update_hook if allowed.
426 (Fother_buffer): Rewrite doc-string. Major rewrite for new
427 buffer list implementation.
428 (other_buffer_safely): New function.
429 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
430 calls to replace_buffer_in_windows and
431 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
433 (record_buffer): Inhibit quitting and rewrite using quittable
434 functions. Run Qbuffer_list_update_hook if allowed.
435 (Frecord_buffer, Funrecord_buffer): New functions.
436 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
437 switch-to-buffer to window.el.
438 (bury-buffer): Move to window.el.
439 (Vbuffer_list_update_hook): New variable.
441 * lisp.h (other_buffer_safely): Add prototype in buffer.c
444 * window.h (resize_frame_windows): Move up in code.
445 (Fwindow_frame): Remove EXFUN.
446 (replace_buffer_in_all_windows): Remove prototype.
447 (replace_buffer_in_windows_safely): Add prototype.
449 * window.c: Declare Qdelete_window static again. Move down
450 declaration of select_count.
451 (Fnext_window, Fprevious_window): Rewrite doc-strings.
452 (Fother_window): Move to window.el.
453 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
454 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
455 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
457 (replace_buffer_in_windows): Implement by calling
458 Qreplace_buffer_in_windows.
459 (replace_buffer_in_all_windows): Remove with some functionality
460 moved into replace_buffer_in_windows_safely.
461 (replace_buffer_in_windows_safely): New function.
462 (select_window_norecord, select_frame_norecord): Move in front
463 of run_window_configuration_change_hook. Remove now obsolete
465 (Fset_window_buffer): Rewrite doc-string. Call
466 Qrecord_window_buffer.
467 (keys_of_window): Move binding for other-window to window.el.
469 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
471 * dispextern.h (struct image): Replace data member, whose int_val
472 and ptr_val fields were not used by anything, with a single
475 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
476 (gif_clear_image, gif_load, imagemagick_load_image)
477 (gs_clear_image, gs_load): Callers changed.
479 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
481 * buffer.h: Include <time.h>, for time_t.
482 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
484 Fix minor problems found by static checking.
486 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
488 Make identifiers static if they are not used in other modules.
489 * data.c (Qcompiled_function, Qframe, Qvector):
490 * image.c (QimageMagick, Qsvg):
491 * minibuf.c (Qmetadata):
492 * window.c (resize_window_check, resize_root_window): Now static.
493 * window.h (resize_window_check, resize_root_window): Remove decls.
495 * window.c (window_deletion_count, delete_deletable_window):
497 (window_body_lines): Now static.
498 (Fdelete_other_windows_internal): Mark vars as initialized.
499 Make sure 'resize_failed' is initialized.
500 (run_window_configuration_change_hook): Rename local to avoid shadowing.
501 (resize_window_apply): Remove unused local.
502 * window.h (delete_deletable_window): Remove decl.
504 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
505 (imagemagick_load_image): Fix pointer signedness problem by changing
506 last arg from unsigned char * to char *. All uses changed.
507 Also, fix a local for similar reasons.
508 Remove unused locals. Remove locals to avoid shadowing.
509 (fn_rsvg_handle_free): Remove; unused.
510 (svg_load, svg_load_image): Fix pointer signedness problem.
511 (imagemagick_load_image): Don't use garbage pointer image_wand.
513 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
515 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
517 * image.c (gif_load): Fix omitted cast error introduced by
520 2011-06-10 Martin Rudalics <rudalics@gmx.at>
522 * window.h (resize_proportionally, orig_total_lines)
523 (orig_top_line): Remove from window structure.
524 (set_window_height, set_window_width, change_window_heights)
525 (Fdelete_window): Remove prototypes.
526 (resize_frame_windows): Remove duplicate declaration.
528 2011-06-10 Eli Zaretskii <eliz@gnu.org>
530 * window.h (resize_frame_windows, resize_window_check)
531 (delete_deletable_window, resize_root_window)
532 (resize_frame_windows): Declare prototypes.
534 * window.c (resize_window_apply): Make definition be "static" to
537 2011-06-10 Martin Rudalics <rudalics@gmx.at>
539 * window.c: Remove declarations of Qwindow_size_fixed,
540 window_min_size_1, window_min_size_2, window_min_size,
541 size_window, window_fixed_size_p, enlarge_window, delete_window.
542 Remove static from declaration of Qdelete_window, it's
543 temporarily needed by Fbury_buffer.
544 (replace_window): Don't assign orig_top_line and
546 (Fdelete_window, delete_window): Remove. Window deletion is
547 handled by window.el.
548 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
549 Fdelete_window calls with calls to Qdelete_window.
550 (Fdelete_other_windows): Remove. Deleting other windows is
551 handled by window.el.
552 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
553 handled in window.el.
554 (window_min_size_2, window_min_size_1, window_min_size): Remove.
555 Window minimum sizes are handled in window.el.
556 (shrink_windows, size_window, set_window_height)
557 (set_window_width, change_window_heights, window_height)
558 (window_width, CURBEG, CURSIZE, enlarge_window)
559 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
560 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
561 handled in window.el.
562 (make_dummy_parent): Rename to make_parent_window and give it a
563 second argument horflag.
564 (make_window): Don't set resize_proportionally any more.
565 (Fsplit_window): Remove. Windows are split in window.el.
566 (save_restore_action, save_restore_orig_size)
567 (shrink_window_lowest_first, save_restore_orig_size): Remove.
568 Resize mini windows in window.el.
569 (grow_mini_window, shrink_mini_window): Implement by calling
570 Qresize_root_window_vertically, resize_window_check and
572 (saved_window, Fset_window_configuration, save_window_save): Do
573 not handle orig_top_line, orig_total_lines, and
574 resize_proportionally.
575 (window_min_height, window_min_width): Move to window.el.
576 (keys_of_window): Move bindings for delete-other-windows,
577 split-window, delete-window and enlarge-window to window.el.
579 * buffer.c: Temporarily extern Qdelete_window.
580 (Fbury_buffer): Temporarily call Qdelete_window instead of
581 Fdelete_window (Fbury_buffer will move to window.el soon).
583 * frame.c (set_menu_bar_lines_1): Remove code handling
584 orig_top_line and orig_total_lines.
586 * dispnew.c (adjust_frame_glyphs_initially): Don't use
587 set_window_height but set heights directly.
588 (change_frame_size_1): Use resize_frame_windows.
590 * xdisp.c (init_xdisp): Don't use set_window_height but set
593 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
594 resize_frame_windows instead of change_window_heights and run
595 run_window_configuration_change_hook.
597 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
598 instead of change_window_heights and run
599 run_window_configuration_change_hook.
601 2011-06-09 Martin Rudalics <rudalics@gmx.at>
603 * window.c (replace_window): Rename second argument REPLACEMENT to
604 NEW. New third argument SETFLAG. Rewrite.
605 (delete_window, make_dummy_parent): Call replace_window with
607 (window_list_1): Move down in code.
608 (run_window_configuration_change_hook): Move set_buffer part
609 before select_frame_norecord part in order to unwind correctly.
610 Rename count1 to count.
611 (recombine_windows, delete_deletable_window, resize_root_window)
612 (Fdelete_other_windows_internal)
613 (Frun_window_configuration_change_hook, make_parent_window)
614 (resize_window_check, resize_window_apply, Fresize_window_apply)
615 (resize_frame_windows, Fsplit_window_internal)
616 (Fdelete_window_internal, Fresize_mini_window_internal): New
618 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
620 2011-06-08 Martin Rudalics <rudalics@gmx.at>
622 * window.h (window): Add some new members to window structure -
623 normal_lines, normal_cols, new_total, new_normal, clone_number,
624 splits, nest, prev_buffers, next_buffers.
625 (WINDOW_TOTAL_SIZE): Move here from window.c.
626 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
628 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
630 (make_dummy_parent): Set new members of windows structure.
631 (make_window): Move down in code. Handle new members of window
633 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
634 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
635 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
636 (Fset_window_prev_buffers, Fwindow_next_buffers)
637 (Fset_window_next_buffers, Fset_window_clone_number): New
639 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
640 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
642 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
643 Argument WINDOW can be now internal window too.
644 (Fwindow_use_time): Move up in code.
645 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
647 (Fset_window_configuration, saved_window)
648 (Fcurrent_window_configuration, save_window_save): Handle new
649 members of window structure.
650 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
651 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
652 (syms_of_window): New Lisp objects Qrecord_window_buffer,
653 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
654 Qget_mru_window, Qresize_root_window,
655 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
656 Qauto_buffer_name; staticpro them.
658 2011-06-07 Martin Rudalics <rudalics@gmx.at>
660 * window.c (Fwindow_total_size, Fwindow_left_column)
661 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
662 (Fwindow_list_1): New functions.
663 (window_box_text_cols): Replace with window_body_cols.
664 (Fwindow_width, Fscroll_left, Fscroll_right): Use
665 window_body_cols instead of window_box_text_cols.
666 (delete_window, Fset_window_configuration): Call
667 delete_all_subwindows with window as argument.
668 (delete_all_subwindows): Take a window as argument and not a
670 (window_loop): Remove handling of GET_LRU_WINDOW and
672 (Fget_lru_window, Fget_largest_window): Move to window.el.
674 * window.h: Extern window_body_cols instead of
675 window_box_text_cols. delete_all_subwindows now takes a
676 Lisp_Object as argument.
678 * indent.c (compute_motion, Fcompute_motion): Use
679 window_body_cols instead of window_box_text_cols.
681 * frame.c (delete_frame): Call delete_all_subwindows with root
684 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
686 * fns.c (Fputhash): Document return value.
688 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
690 * image.c (gif_load): Implement gif89a spec "no disposal" method.
692 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
694 Cons<->int and similar integer overflow fixes (Bug#8794).
696 Check for overflow when converting integer to cons and back.
697 * charset.c (Fdefine_charset_internal, Fdecode_char):
698 Use cons_to_unsigned to catch overflow.
699 (Fencode_char): Use INTEGER_TO_CONS.
700 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
701 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
702 * data.c (long_to_cons, cons_to_long): Remove.
703 (cons_to_unsigned, cons_to_signed): New functions.
704 These signal an error for invalid or out-of-range values.
705 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
706 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
707 * font.c (Ffont_variation_glyphs):
708 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
709 * lisp.h: Include <intprops.h>.
710 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
711 (cons_to_signed, cons_to_unsigned): New decls.
712 (long_to_cons, cons_to_long): Remove decls.
713 * undo.c (record_first_change): Use INTEGER_TO_CONS.
714 (Fprimitive_undo): Use CONS_TO_INTEGER.
715 * xfns.c (Fx_window_property): Likewise.
716 * xselect.c: Include <limits.h>.
717 (x_own_selection, selection_data_to_lisp_data):
719 (x_handle_selection_request, x_handle_selection_clear)
720 (x_get_foreign_selection, Fx_disown_selection_internal)
721 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
722 (lisp_data_to_selection_data): Use cons_to_unsigned.
723 (x_fill_property_data): Use cons_to_signed.
724 Report values out of range.
726 Check for buffer and string overflow more precisely.
727 * buffer.h (BUF_BYTES_MAX): New macro.
728 * lisp.h (STRING_BYTES_MAX): New macro.
729 * alloc.c (Fmake_string):
730 * character.c (string_escape_byte8):
731 * coding.c (coding_alloc_by_realloc):
733 * editfns.c (Fformat):
735 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
736 since they may not be the same number.
737 * editfns.c (Finsert_char):
738 * fileio.c (Finsert_file_contents):
739 Likewise for BUF_BYTES_MAX.
741 * image.c: Use ptrdiff_t, not int, for sizes.
742 (slurp_file): Switch from int to ptrdiff_t.
744 (slurp_file): Check that file size fits in both size_t (for
745 malloc) and ptrdiff_t (for sanity and safety).
747 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
748 if b->modtime has its maximal value.
750 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
752 Don't assume time_t can fit into int.
753 * buffer.h (struct buffer.modtime): Now time_t, not int.
754 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
755 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
757 Minor fixes for signed vs unsigned integers.
758 * character.h (MAYBE_UNIFY_CHAR):
759 * charset.c (maybe_unify_char):
760 * keyboard.c (read_char, reorder_modifiers):
761 XINT -> XFASTINT, since the integer must be nonnegative.
762 * ftfont.c (ftfont_spec_pattern):
763 * keymap.c (access_keymap, silly_event_symbol_error):
764 XUINT -> XFASTINT, since the integer must be nonnegative.
765 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
766 since it makes no difference and we prefer signed.
767 * keyboard.c (record_char): Use XUINT when all the neighbors do.
768 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
771 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
773 * window.h (Fwindow_frame): Declare.
775 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
777 * alloc.c: Simplify handling of large-request failures (Bug#8800).
778 (SPARE_MEMORY): Always define.
779 (LARGE_REQUEST): Remove.
780 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
782 2011-06-06 Martin Rudalics <rudalics@gmx.at>
784 * lisp.h: Move EXFUNS for Fframe_root_window,
785 Fframe_first_window and Fset_frame_selected_window to window.h.
787 * window.h: Move EXFUNS for Fframe_root_window,
788 Fframe_first_window and Fset_frame_selected_window here from
791 * frame.c (Fwindow_frame, Fframe_first_window)
792 (Fframe_root_window, Fframe_selected_window)
793 (Fset_frame_selected_window): Move to window.c.
794 (Factive_minibuffer_window): Move to minibuf.c.
795 (Fother_visible_frames_p): New function.
797 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
799 * window.c (decode_window, decode_any_window): Move up in code.
800 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
801 (inhibit_frame_unsplittable): Remove unused variable.
802 (Fwindow_buffer): Move up and rewrite doc-string.
803 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
804 (Fwindow_prev): New functions.
805 (Fwindow_frame): Move here from frame.c. Accept any window as
807 (Fframe_root_window, Fframe_first_window)
808 (Fframe_selected_window): Move here from frame.c. Accept frame
809 or arbitrary window as argument. Update doc-strings.
810 (Fminibuffer_window): Move up in code.
811 (Fwindow_minibuffer_p): Move up in code and simplify.
812 (Fset_frame_selected_window): Move here from frame.c.
814 (Fselected_window, select_window, Fselect_window): Move up in
815 code. Minor doc-string fixes.
817 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
819 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
820 Do not assume that spare memory exists; that assumption is valid
821 only if SYSTEM_MALLOC.
822 (LARGE_REQUEST): New macro, so that the issue of large requests
823 is separated from the issue of spare memory.
825 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
827 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
830 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
832 * xfns.c (x_set_scroll_bar_default_width): Move declarations
835 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
837 * gtkutil.c (xg_get_default_scrollbar_width): New function.
839 * gtkutil.h: Declare xg_get_default_scrollbar_width.
841 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
842 min width by calling x_set_scroll_bar_default_width (Bug#8505).
844 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
846 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
848 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
850 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
851 (x_clipboard_manager_save): Add return value.
852 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
854 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
855 Obey Vx_select_enable_clipboard_manager. Catch errors in
856 x_clipboard_manager_save (Bug#8779).
857 (Vx_select_enable_clipboard_manager): New variable.
858 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
860 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
862 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
864 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
866 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
867 in the current matrix if keep_current_p is non-zero.
869 2011-06-04 Eli Zaretskii <eliz@gnu.org>
871 * bidi.c (bidi_level_of_next_char): Fix last change.
873 2011-06-03 Eli Zaretskii <eliz@gnu.org>
875 Support bidi reordering of text covered by display properties.
877 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
878 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
879 (bidi_cache_search, bidi_cache_iterator_state)
880 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
881 (bidi_level_of_next_char, bidi_move_to_visually_next):
882 Support character positions inside a run of characters covered by a
884 (bidi_paragraph_init, bidi_resolve_explicit_1)
885 (bidi_level_of_next_char): Call bidi_fetch_char and
886 bidi_fetch_char_advance instead of FETCH_CHAR and
888 (bidi_init_it): Initialize new members.
889 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
891 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
892 instead of using explicit *_CHAR codes.
893 (bidi_resolve_explicit, bidi_resolve_weak):
894 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
895 bidirectional text is supported only in multibyte buffers.
896 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
897 it to initialize the frame_window_p member of struct bidi_it.
898 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
899 (bidi_resolve_explicit, bidi_resolve_weak)
900 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
901 bidi_it->nchars is non-positive.
902 (bidi_level_of_next_char): Don't try to lookup the cache for the
903 next/previous character if nothing is cached there yet, or if we
904 were just reseat()'ed to a new position.
906 * xdisp.c (set_cursor_from_row): Set start and stop points
907 according to the row's direction when priming the loop that looks
908 for the glyph on which to display cursor.
909 (single_display_spec_intangible_p): Function deleted.
910 (display_prop_intangible_p): Reimplement to call
911 handle_display_spec instead of single_display_spec_intangible_p.
912 Accept 3 additional arguments needed by handle_display_spec.
913 This fixes incorrect cursor motion across display property with complex
914 values: lists, `(when COND...)' forms, etc.
915 (single_display_spec_string_p): Support property values that are
916 lists with the argument STRING its top-level element.
917 (display_prop_string_p): Fix the condition for processing a
918 property that is a list to be consistent with handle_display_spec.
919 (handle_display_spec): New function, refactored from the
920 last portion of handle_display_prop.
921 (compute_display_string_pos): Accept additional argument
922 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
923 value of a `display' property is a "replacing spec".
924 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
925 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
926 the display property, but just return a value indicating whether
927 the display property will replace the characters it covers.
928 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
929 frame_window_p members of struct bidi_it.
930 (compute_display_string_pos, compute_display_string_end):
932 (push_it): Accept second argument POSITION, where pop_it should
933 jump to continue iteration.
934 (reseat_1): Initialize bidi_it.disp_pos.
936 * keyboard.c (adjust_point_for_property): Adjust the call to
937 display_prop_intangible_p to its new signature.
939 * dispextern.h (struct bidi_it): New member frame_window_p.
940 (bidi_init_it): Update prototypes.
941 (display_prop_intangible_p): Update prototype.
942 (compute_display_string_pos, compute_display_string_end):
944 (struct bidi_it): New members nchars and disp_pos. ch_len is now
947 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
949 Malloc failure behavior now depends on size of allocation.
950 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
951 * lisp.h: Change signatures accordingly.
952 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
953 All callers changed. (Bug#8762)
955 * gnutls.c: Use Emacs's memory allocators.
956 Without this change, the gnutls library would invoke malloc etc.
957 directly, which causes problems on non-SYNC_INPUT hosts, and which
958 runs afoul of improving memory_full behavior. (Bug#8761)
959 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
960 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
961 xfree instead of the default malloc, realloc, free.
962 (Fgnutls_boot): No need to check for memory allocation failure,
963 since xmalloc does that for us.
965 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
966 * category.c (hash_get_category_set):
967 * ccl.c (ccl_driver):
968 * charset.c (Fdefine_charset_internal):
969 * charset.h (struct charset.hash_index):
970 * composite.c (get_composition_id, gstring_lookup_cache)
971 (composition_gstring_put_cache):
972 * composite.h (struct composition.hash_index):
973 * dispextern.h (struct image.hash):
974 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
975 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
976 (hashfn_equal, hashfn_user_defined, make_hash_table)
977 (maybe_resize_hash_table, hash_lookup, hash_put)
978 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
979 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
980 (Fsxhash, Fgethash, Fputhash, Fmaphash):
981 * image.c (make_image, search_image_cache, lookup_image)
982 (xpm_put_color_table_h):
983 * lisp.h (struct Lisp_Hash_Table):
984 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
985 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
986 for hashes and hash indexes, instead of 'unsigned' and 'int'.
987 * alloc.c (allocate_vectorlike):
988 Check for overflow in vector size calculations.
989 * ccl.c (ccl_driver):
990 Check for overflow when converting EMACS_INT to int.
991 * fns.c, image.c: Remove unnecessary static decls that would otherwise
992 need to be updated by these changes.
993 * fns.c (make_hash_table, maybe_resize_hash_table):
994 Check for integer overflow with large hash tables.
995 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
996 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
997 (SXHASH_REDUCE): New macro.
998 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
999 Use it instead of discarding useful hash info with large hash values.
1000 (sxhash_float): New function.
1001 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1002 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
1003 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1004 Rewrite to use FIXNUM_BITS, as this simplifies things.
1005 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1006 Adjust signatures to match updated version of code.
1007 (consing_since_gc): Now EMACS_INT, since a single hash table can
1008 use more than INT_MAX bytes.
1010 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1012 Make it possible to build with GCC-4.6+ -O2 -flto.
1014 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1016 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1018 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1019 Call minibuffer-inactive-mode.
1021 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
1023 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1024 Update dependencies.
1026 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1028 * data.c (init_data): Remove code for UTS, this system is not
1031 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1033 Don't force ./temacs to start in terminal mode.
1035 * frame.c (make_initial_frame): Initialize faces in all cases, not
1036 only when CANNOT_DUMP is defined.
1037 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1039 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1041 * dispnew.c (add_window_display_history): Use const for the string
1042 pointer. Remove declaration, not needed.
1044 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1046 Use 'inline', not 'INLINE'.
1047 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1048 * alloc.c, fontset.c (INLINE): Remove.
1049 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1050 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1051 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1052 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1053 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1055 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1057 Make it possible to run ./temacs.
1059 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1060 syms_of_callproc does the same thing. Remove test for
1061 "initialized", do it in the caller.
1062 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1064 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1066 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1067 (read_minibuf): Use get_minibuffer.
1068 (syms_of_minibuf): Use DEFSYM.
1069 (Qmetadata): New var.
1070 * data.c (Qbuffer): Don't make it static.
1071 (syms_of_data): Use DEFSYM.
1073 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1075 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1076 (CCL_CODE_MIN): New macro.
1078 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1080 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1082 * eval.c (Qdebug): Now static.
1083 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1084 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1085 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1087 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1089 * image.c: Various fixes to ImageMagick code comments.
1090 (Fimagemagick_types): Doc fix.
1092 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1094 Minor fixes prompted by GCC 4.6.0 warnings.
1096 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1098 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1099 (x_clipboard_manager_save_all): Move extern decl to ...
1100 * xterm.h: ... here, so that it can be checked for consistency.
1102 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1104 * xselect.c (x_clipboard_manager_save_frame)
1105 (x_clipboard_manager_save_all): New functions.
1106 (Fx_clipboard_manager_save): Lisp function deleted.
1108 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1109 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1111 * xterm.h: Update prototype.
1113 2011-05-28 William Xu <william.xwl@gmail.com>
1115 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1118 2011-05-28 Jim Meyering <meyering@redhat.com>
1120 Avoid a sign-extension bug in crypto_hash_function.
1121 * fns.c (to_uchar): Define.
1122 (crypto_hash_function): Use it to convert some newly-signed
1123 variables to unsigned, to avoid sign-extension bugs. For example,
1124 without this change, (md5 "truc") would evaluate to
1125 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1126 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1127 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1129 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1131 Integer overflow fixes.
1133 * dbusbind.c: Serial number integer overflow fixes.
1134 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1135 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1136 to hold a serial number that is too large for a fixnum.
1137 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1138 Check for serial numbers out of range. Decode any serial number
1139 that was so large that it became a float. (Bug#8722)
1141 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1142 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1143 Use XFASTINT rather than XUINT when numbers are nonnegative.
1144 (xd_append_arg, Fdbus_method_return_internal):
1145 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1146 arguments, check that Lisp number is nonnegative, rather than
1147 silently wrapping negative numbers around. (Bug#8722)
1148 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1151 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1153 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1155 ccl: add integer overflow checks
1156 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1157 (IN_INT_RANGE): New macros.
1158 (ccl_driver): Use them to check for integer overflow when
1159 decoding a CCL program. Many of the new checks are whether XINT (x)
1160 fits in int; it doesn't always, on 64-bit hosts. The new version
1161 doesn't catch all possible integer overflows, but it's an
1162 improvement. (Bug#8719)
1164 * alloc.c (make_event_array): Use XINT, not XUINT.
1165 There's no need for unsigned here.
1167 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1168 This follows up to the 2011-05-06 change that substituted uintptr_t
1169 for EMACS_INT. This case wasn't caught back then.
1171 Rework Fformat to avoid integer overflow issues.
1172 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1173 now (part of C89). Include <verify.h>.
1174 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1175 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1176 (Fformat): Avoid the prepass trying to compute sizes; it was only
1177 approximate and thus did not catch overflow reliably. Instead, walk
1178 through the format just once, formatting and computing sizes as we go,
1179 checking for integer overflow at every step, and allocating a larger
1180 buffer as needed. Keep track separately whether the format is
1181 multibyte. Keep only the most-recently calculated precision, rather
1182 than them all. Record whether each argument has been converted to
1183 string. Use EMACS_INT, not int, for byte and char and arg counts.
1184 Support field widths and precisions larger than INT_MAX. Avoid
1185 sprintf's undefined behavior with conversion specifications such as %#d
1186 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1187 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1188 formatting out-of-range floating point numbers with int
1191 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1193 * data.c: Avoid integer truncation in expressions involving floats.
1194 * data.c: Include <intprops.h>.
1195 (arith_driver): When there's an integer overflow in an expression
1196 involving floating point, convert the integers to floating point
1197 so that the resulting value does not suffer from catastrophic
1198 integer truncation. For example, on a 64-bit host (* 4
1199 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1200 Do not rely on undefined behavior after integer overflow.
1202 merge count_size_as_multibyte, parse_str_to_multibyte
1203 * character.c, character.h (count_size_as_multibyte):
1204 Rename from parse_str_to_multibyte; all uses changed.
1205 Check for integer overflow.
1206 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1207 since it's now a duplicate of the other. This is more of
1208 a character than a buffer op, so better that it's in character.c.
1209 * fns.c, print.c: Adjust to above changes.
1211 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1213 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1215 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1217 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1218 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1219 (x_clipboard_manager_save): Now static.
1220 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1222 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1223 (crypto_hash_function): Now static.
1224 Fix pointer signedness problems. Avoid unnecessary initializations.
1226 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1228 * termhooks.h (Vselection_alist): Make it terminal-local.
1230 * terminal.c (create_terminal): Initialize it.
1232 * xselect.c: Support for clipboard managers.
1233 (Vselection_alist): Move to termhooks.h as terminal-local var.
1234 (LOCAL_SELECTION): New macro.
1235 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1236 (symbol_to_x_atom): Remove gratuitous arg.
1237 (x_handle_selection_request, lisp_data_to_selection_data)
1238 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1239 (x_own_selection, x_get_local_selection, x_convert_selection):
1240 New arg, specifying work frame. Use terminal-local Vselection_alist.
1241 (some_frame_on_display): Delete unused function.
1242 (Fx_own_selection_internal, Fx_get_selection_internal)
1243 (Fx_disown_selection_internal, Fx_selection_owner_p)
1244 (Fx_selection_exists_p): New optional frame arg.
1245 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1246 (x_handle_selection_clear): Don't treat other terminals with the
1247 same keyboard specially. Use the terminal-local Vselection_alist.
1248 (x_clear_frame_selections): Use Frun_hook_with_args.
1250 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1252 * xterm.h: Add support for those atoms.
1254 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
1256 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1257 (converted_selections, conversion_fail_tag): New global variables.
1258 (x_selection_request_lisp_error): Free the above.
1259 (x_get_local_selection): Remove unnecessary code.
1260 (x_reply_selection_request): Args changed; handle arbitrary array
1261 of converted selections stored in converted_selections.
1262 Separate the XChangeProperty and SelectionNotify steps.
1263 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1264 (x_convert_selection): New function.
1265 (x_handle_selection_event): Simplify.
1266 (x_get_foreign_selection): Don't ignore incoming requests while
1267 waiting for an answer; this will fail when we implement
1268 SAVE_TARGETS, and seems unnecessary anyway.
1269 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1270 (Vx_sent_selection_functions): Doc fix.
1272 2011-05-26 Leo Liu <sdl.web@gmail.com>
1274 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1276 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1278 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1280 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1281 for fringe update if it has periodic bitmap.
1282 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1283 and fringe_bitmap_periodic_p.
1285 * fringe.c (get_fringe_bitmap_data): New function.
1286 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1287 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1288 row. Mark glyph row for fringe update if periodicity changed.
1290 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1291 for fringe update unless it has periodic bitmap.
1293 2011-05-25 Kenichi Handa <handa@m17n.org>
1295 * xdisp.c (get_next_display_element): Set correct it->face_id for
1296 a static composition.
1298 2011-05-24 Leo Liu <sdl.web@gmail.com>
1301 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1303 * fns.c (crypto_hash_function, Fsha1): New function.
1304 (Fmd5): Use crypto_hash_function.
1305 (syms_of_fns): Add Ssha1.
1307 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1309 * gnutls.c: Remove unused macros.
1310 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1311 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1312 Remove macros that are defined and never used.
1313 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1315 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1317 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1318 (Fx_get_selection_internal): Minor cleanup.
1319 (Fx_own_selection_internal): Rename arguments for consistency with
1322 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1324 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1326 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1328 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1330 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1332 * dispnew.c (scrolling_window): Don't exclude the case that the
1333 last enabled row in the desired matrix touches the bottom boundary.
1335 2011-05-21 Glenn Morris <rgm@gnu.org>
1337 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
1338 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1339 and add some more files.
1341 2011-05-20 Eli Zaretskii <eliz@gnu.org>
1343 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1344 report_file_error introduced by the change from 2011-05-07.
1346 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1348 * systime.h (Time): Define only if emacs is defined.
1349 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1350 where the include path doesn't have X11/X.h by default. See
1351 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1353 2011-05-20 Kenichi Handa <handa@m17n.org>
1355 * composite.c (find_automatic_composition): Fix previous change.
1357 2011-05-20 Glenn Morris <rgm@gnu.org>
1359 * lisp.mk: New file, split from Makefile.in.
1360 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1361 (shortlisp): Remove.
1362 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1364 2011-05-19 Glenn Morris <rgm@gnu.org>
1366 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1367 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1368 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1369 (lisp): Set the order to that of loadup.el.
1370 (shortlisp): Make it a copy of $lisp.
1371 (SOME_MACHINE_LISP): Remove.
1372 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1373 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1375 2011-05-18 Kenichi Handa <handa@m17n.org>
1377 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1378 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1379 (find_automatic_composition): Mostly rewrite for efficiency.
1381 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
1383 * makefile.w32-in: Update dependencies.
1385 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1387 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1388 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
1390 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
1392 Fix some integer overflow issues, such as string length overflow.
1394 * insdel.c (count_size_as_multibyte): Check for string overflow.
1396 * character.c (lisp_string_width): Check for string overflow.
1397 Use EMACS_INT, not int, for string indexes and lengths; in
1398 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1399 the resulting string length overflows an EMACS_INT; instead,
1400 report a string overflow if no precision given. When checking for
1401 precision exhaustion, use a check that cannot possibly have
1402 integer overflow. (Bug#8675)
1403 * character.h (lisp_string_width): Adjust to new signature.
1405 * alloc.c (string_overflow): New function.
1406 (Fmake_string): Use it. This doesn't change behavior, but saves
1407 a few bytes and will simplify future changes.
1408 * character.c (string_escape_byte8): Likewise.
1409 * lisp.h (string_overflow): New decl.
1411 Fixups, following up to the user-interface timestamp change.
1412 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1413 for UI timestamps, instead of unsigned long.
1414 * msdos.c (mouse_get_pos): Likewise.
1415 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1416 * w32gui.h (Time): Define by including "systime.h" rather than by
1417 declaring it ourselves. (Bug#8664)
1419 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1420 * image.c (clear_image_cache): Likewise.
1422 * term.c (term_mouse_position): Don't assume time_t wraparound.
1424 Be more systematic about user-interface timestamps.
1425 Before, the code sometimes used 'Time', sometimes 'unsigned long',
1426 and sometimes 'EMACS_UINT', to represent these timestamps.
1427 This change causes it to use 'Time' uniformly, as that's what X uses.
1428 This makes the code easier to follow, and makes it easier to catch
1429 integer overflow bugs such as Bug#8664.
1430 * frame.c (Fmouse_position, Fmouse_pixel_position):
1431 Use Time, not unsigned long, for user-interface timestamps.
1432 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1433 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1434 * keyboard.h (last_event_timestamp): Likewise.
1435 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1436 * menu.h (xmenu_show): Likewise.
1437 * term.c (term_mouse_position): Likewise.
1438 * termhooks.h (struct input_event.timestamp): Likewise.
1439 (struct terminal.mouse_position_hook): Likewise.
1440 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1441 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1442 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1443 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1445 * menu.h, termhooks.h: Include "systime.h", for Time.
1447 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1448 Don't assume that the difference between two unsigned long values
1449 can fit into an integer. At this point, we know button_down_time
1450 <= event->timestamp, so the difference must be nonnegative, so
1451 there's no need to cast the result if double-click-time is
1452 nonnegative, as it should be; check that it's nonnegative, just in
1453 case. This bug is triggered when events are more than 2**31 ms
1454 apart (about 25 days). (Bug#8664)
1456 * xselect.c (last_event_timestamp): Remove duplicate decl.
1457 (x_own_selection): Remove needless cast to unsigned long.
1459 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1460 that always fit in int. Use a sentinel instead of a counter, to
1461 avoid a temp and to allay GCC's concerns about possible int overflow.
1462 * frame.h (struct frame): Use int for menu_bar_items_used
1463 instead of EMACS_INT, since it always fits in int.
1465 * menu.c (grow_menu_items): Check for int overflow.
1467 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1469 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1470 Before, the code was not consistent. These values cannot exceed
1471 2**31 - 1 so there's no need to make them unsigned.
1472 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1473 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1474 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1476 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1478 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1479 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1480 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1481 presumably because the widths might not match.
1483 * window.c (size_window): Avoid needless test at loop start.
1485 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1487 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1489 2011-05-12 Drew Adams <drew.adams@oracle.com>
1491 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1493 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1495 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1496 `width' to `bar_area_x' and `bar_area_width', respectively.
1497 (x_scroll_run): Take account of fringe background extension.
1499 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1500 Rename local vars `left' and `width' to `bar_area_x' and
1501 `bar_area_width', respectively.
1502 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1503 background extension.
1505 2011-05-10 Jim Meyering <meyering@redhat.com>
1507 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1509 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
1511 * image.c (Finit_image_library): Return t for built-in image types,
1512 like pbm and xbm. (Bug#8640)
1514 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1516 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1518 2011-05-07 Eli Zaretskii <eliz@gnu.org>
1520 * w32console.c (Fset_screen_color): Doc fix.
1521 (Fget_screen_color): New function.
1522 (syms_of_ntterm): Defsubr it.
1524 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1525 unlink the temporary file if Fcall_process didn't create it in the
1527 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1528 child process will be redirected to a file specified with `:file'.
1529 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1530 cue to call_process_cleanup not to close that handle.
1532 2011-05-07 Ben Key <bkey76@gmail.com>
1534 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1535 one of two shell specific rules, either bootstrap-temacs-CMD or
1536 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1537 to the previous implementation of the bootstrap-temacs rule.
1538 The bootstrap-temacs-CMD rule is similar to the previous
1539 implementation of the bootstrap-temacs rule except that it
1540 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1543 These changes, along with some changes to nt/configure.bat,
1544 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1545 earlier fix to add support for --cflags and --ldflags options
1546 that include quotes so that it works whether make uses cmd or
1549 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
1551 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1552 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1554 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1555 a string. Handle both cases.
1556 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1557 (Fdbus_register_method): Use Qinvalid_function.
1559 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1561 * makefile.w32-in: Update dependencies.
1562 (LISP_H): Add inttypes.h and stdin.h.
1563 (PROCESS_H): Add unistd.h.
1565 2011-05-06 Eli Zaretskii <eliz@gnu.org>
1567 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1568 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1570 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
1572 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1574 * term.c (vfatal): Remove stray call to va_end.
1575 It's not needed and the C Standard doesn't allow it here anyway.
1577 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1578 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1580 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1583 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1585 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1587 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1589 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1591 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1593 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1594 * charset.c (Fdefine_charset_internal): Don't initialize
1595 charset.code_space[15]. The value was garbage, on hosts with
1596 32-bit int (Bug#8600).
1598 * lread.c (read_integer): Be more consistent with string-to-number.
1599 Use string_to_number to do the actual conversion; this avoids
1600 rounding errors and fixes some other screwups. Without this fix,
1601 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1602 (digit_to_number): Move earlier, for benefit of read_integer.
1603 Return -1 if the digit is out of range for the base, -2 if it is
1604 not a digit in any supported base. (Bug#8602)
1606 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1608 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1609 to match comment at start of function. This also removes a
1610 GCC warning about overflow in a 32+64-bit port.
1612 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1614 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1615 Reported by Stefan Monnier in
1616 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
1617 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1618 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
1620 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1621 (EMACS_UINTPTR): Likewise, with uintptr_t.
1623 * lisp.h: Prefer 64-bit EMACS_INT if available.
1624 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1625 on 32-bit hosts that have 64-bit int, so that they can access
1627 However, temporarily disable this change unless the temporary
1628 symbol WIDE_EMACS_INT is defined.
1630 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1632 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1633 This removes an assumption that EMACS_INT and long are the same
1634 width as pointers. The assumption is true for Emacs porting targets
1635 now, but we want to make other targets possible.
1636 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1637 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1638 In the rest of the code, change types of integers that hold casted
1639 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1640 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1641 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1642 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1643 No need to cast type when ORing.
1644 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1645 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1646 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1647 assume EMACS_INT is the same width as char *.
1648 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1649 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1650 Remove no-longer-needed casts.
1651 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1652 (xg_tool_bar_help_callback, xg_make_tool_item):
1653 Use EMACS_INTPTR to hold an integer
1654 that will be cast to void *; this can avoid a GCC warning
1655 if EMACS_INT is not the same width as void *.
1656 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1657 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1658 (current_message_1, set_message_1):
1659 Use a local to convert to proper width without a cast.
1660 * xmenu.c (dialog_selection_callback): Likewise.
1662 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1663 Also, don't assume VALBITS / RAND_BITS is less than 5,
1664 and don't rely on undefined behavior when shifting a 1 left into
1666 * lisp.h (get_random): Change signature to match.
1668 * lread.c (hash_string): Use size_t, not int, for hash computation.
1669 Normally we prefer signed values; but hashing is special, because
1670 it's better to use unsigned division on hash table sizes so that
1671 the remainder is nonnegative. Also, size_t is the natural width
1672 for hashing into memory. The previous code used 'int', which doesn't
1673 retain enough info to hash well into very large tables.
1674 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1676 * dbusbind.c: Don't possibly lose pointer info when converting.
1677 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1678 Use XPNTR rather than XHASH, so that the high-order bits of
1679 the pointer aren't lost when converting through void *.
1681 * eval.c (Fautoload): Don't double-shift a pointer.
1683 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1685 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1687 * gnutls.c (DEF_GNUTLS_FN):
1688 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1690 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1692 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1695 2011-05-05 Eli Zaretskii <eliz@gnu.org>
1697 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1698 New version that can reserve upto 2GB of heap space.
1700 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
1702 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1704 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1706 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1707 `gnutls_certificate_set_x509_key_file'.
1709 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
1711 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1712 Update dependencies.
1714 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1716 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1717 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1718 Remove unused parameter `fildes'.
1719 * process.c (read_process_output, send_process): Don't pass it.
1721 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1723 Fix previous change: the library cache is defined in w32.c.
1724 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1725 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1727 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1729 Implement dynamic loading of GnuTLS on Windows.
1731 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1732 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1733 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1736 * gnutls.c (Qgnutls_dll): Define.
1737 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1738 (gnutls_*): Declare function pointers.
1739 (init_gnutls_functions): New function to initialize function pointers.
1740 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1741 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1742 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1743 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1744 (emacs_gnutls_write, emacs_gnutls_read)
1745 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1746 (Fgnutls_available_p): New function.
1747 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1748 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1749 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1751 * image.c: Include w32.h.
1752 (Vimage_type_cache): Delete.
1753 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1754 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1755 (w32_delayed_load): Move to w32.c.
1757 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1759 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1760 (w32_delayed_load): Move from image.c. When loading a library, record
1761 its filename in the :loaded-from property of the library id.
1762 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1763 Initialize and staticpro them.
1764 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1766 * process.c: Include lisp.h before w32.h, not after.
1767 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1768 instead of gnutls_record_check_pending.
1770 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1772 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1774 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1775 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1778 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1780 * xterm.c (x_set_frame_alpha): Do not set property on anything
1781 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1783 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1785 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1787 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1789 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1790 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1791 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1792 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1793 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1794 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1795 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1796 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1797 (Qgnutls_bootprop_callbacks_verify): Make static.
1799 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1801 * callproc.c: Indentation fixup.
1803 * sysdep.c (wait_for_termination_1): Make static.
1804 (wait_for_termination, interruptible_wait_for_termination):
1805 Move after wait_for_termination_1.
1807 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1809 * sysdep.c (interruptible_wait_for_termination): New function
1810 which is like wait_for_termination, but allows keyboard
1813 * callproc.c (Fcall_process): Add (:file "file") as an option for
1815 (Fcall_process_region): Ditto.
1817 2011-04-30 Eli Zaretskii <eliz@gnu.org>
1819 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1820 rather than `XVECTOR (FOO)->size'.
1822 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1823 inttypes.h, as a gnulib replacement is used if it not available in
1826 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1828 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1829 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1830 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1832 * coding.c (coding_alloc_by_realloc): Error out if destination
1833 will grow beyond MOST_POSITIVE_FIXNUM.
1834 (decode_coding_emacs_mule): Abort if there isn't enough place in
1835 charbuf for the composition carryover bytes. Reserve an extra
1836 space for up to 2 characters produced in a loop.
1837 (decode_coding_iso_2022): Abort if there isn't enough place in
1838 charbuf for the composition carryover bytes.
1840 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1842 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1843 aborting when %lld or %lll format is passed.
1844 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1845 %llo or %llx format is passed. (Bug#8545)
1847 * window.c (window_scroll_line_based): Use a marker instead of
1848 simple variables to record original value of point. (Bug#7952)
1850 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1851 produced by %s or %c overflows available buffer space. (Bug#8545)
1853 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1855 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1856 (SIZE_MAX): Move defn after all includes, as they might #define it.
1858 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1860 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1862 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1864 * keyboard.c (Qdelayed_warnings_hook): Define.
1865 (command_loop_1): Run `delayed-warnings-hook'
1866 if Vdelayed_warnings_list is non-nil.
1867 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1868 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1870 2011-04-28 Eli Zaretskii <eliz@gnu.org>
1872 * doprnt.c (doprnt): Don't return value smaller than the buffer
1873 size if the message was truncated. (Bug#8545).
1875 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1877 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1878 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1880 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1882 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1884 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
1886 * makefile.w32-in: Update dependencies.
1888 2011-04-27 Eli Zaretskii <eliz@gnu.org>
1890 Improve `doprnt' and its usage. (Bug#8545)
1891 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1892 `format_end'. Remove support for %l as a conversion specifier.
1893 Don't use xrealloc. Improve diagnostics when the %l size modifier
1894 is used. Update the commentary.
1896 * eval.c (verror): Simplify calculation of size_t.
1898 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1901 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1903 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1906 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1908 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1909 This makes this file independent of the recent pseudovector change.
1911 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
1913 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1915 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
1916 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
1917 Remove unused local.
1918 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
1920 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
1921 GCC 4.6.0 optimizes based on type-based alias analysis.
1922 For example, if b is of type struct buffer * and v of type struct
1923 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1924 != &v->size, and therefore "v->size = 1; b->size = 2; return
1925 v->size;" must therefore return 1. This assumption is incorrect
1926 for Emacs, since it type-puns struct Lisp_Vector * with many other
1927 types. To fix this problem, this patch adds a new type struct
1928 vectorlike_header that documents the constraints on layout of vectors
1929 and pseudovectors, and helps optimizing compilers not get fooled
1930 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1931 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
1932 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1934 (XSETPVECTYPE): Rewrite in terms of new macro.
1935 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1936 This is a bit clearer, and further avoids the possibility of
1937 undesirable aliasing.
1938 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
1939 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
1940 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1941 since Lisp_Subr is a special case (no "next" field).
1942 (ASIZE): Now uses header.size rather than size.
1943 All previous uses of XVECTOR (foo)->size replaced to use this macro,
1944 to avoid the hassle of writing XVECTOR (foo)->header.size.
1945 (struct vectorlike_header): New type.
1946 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1947 object, to help avoid aliasing.
1948 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1949 (SUBRP): Likewise, since Lisp_Subr is a special case.
1950 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1951 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1952 (struct Lisp_Hash_Table): Combine first two members into a single
1953 struct vectorlike_header member. All uses of "size" and "next" members
1954 changed to be "header.size" and "header.next".
1955 * buffer.h (struct buffer): Likewise.
1956 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1957 * frame.h (struct frame): Likewise.
1958 * process.h (struct Lisp_Process): Likewise.
1959 * termhooks.h (struct terminal): Likewise.
1960 * window.c (struct save_window_data, struct saved_window): Likewise.
1961 * window.h (struct window): Likewise.
1962 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1963 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1964 * buffer.c (init_buffer_once): Likewise.
1965 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1967 * process.c (Fformat_network_address): Use local var for size,
1970 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1972 Make the Lisp reader and string-to-float more consistent (Bug#8525)
1973 * data.c (atof): Remove decl; no longer used or needed.
1974 (digit_to_number): Move to lread.c.
1975 (Fstring_to_number): Use new string_to_number function, to be
1976 consistent with how the Lisp reader treats infinities and NaNs.
1977 Do not assume that floating-point numbers represent EMACS_INT
1978 without losing information; this is not true on most 64-bit hosts.
1979 Avoid double-rounding errors, by insisting on integers when
1980 parsing non-base-10 numbers, as the documentation specifies.
1981 * lisp.h (string_to_number): New decl, replacing ...
1982 (isfloat_string): Remove.
1983 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
1984 (read1): Do not accept +. and -. as integers; this
1985 appears to have been a coding error. Similarly, do not accept
1986 strings like +-1e0 as floating point numbers. Do not report
1987 overflow for integer overflows unless the base is not 10 which
1988 means we have no simple and reliable way to continue.
1989 Break out the floating-point parsing into a new
1990 function string_to_number, so that Fstring_to_number parses
1991 floating point numbers consistently with the Lisp reader.
1992 (digit_to_number): Move here from data.c. Make it static inline.
1993 (E_CHAR, EXP_INT): Remove, replacing with ...
1994 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1995 (string_to_number): New function, replacing isfloat_string.
1996 This function checks for valid syntax and produces the resulting
1997 Lisp float number too. Rework it so that string-to-number
1998 no longer mishandles examples like "1.0e+". Use strtoumax,
1999 so that overflow for non-base-10 numbers is reported only when
2000 there's no portable and simple way to convert to floating point.
2002 * textprop.c (set_text_properties_1): Rewrite for clarity,
2003 and to avoid GCC warning about integer overflow.
2005 * intervals.h (struct interval): Use EMACS_INT for members
2006 where EMACS_UINT might cause problems. See
2007 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2008 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2009 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2011 (offset_intervals): Tell GCC not to worry about length overflow
2012 when negating a negative length.
2014 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2015 (overrun_check_free): Likewise.
2017 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2018 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2021 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2022 (gnutls_make_error): Rename local to avoid shadowing.
2023 (gnutls_emacs_global_deinit): ifdef out; not used.
2024 (Fgnutls_boot): Use const for pointer to readonly storage.
2025 Comment out unused local. Fix pointer signedness problems.
2027 * lread.c (openp): Don't stuff size_t into an 'int'.
2028 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2029 about possible signed overflow.
2031 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2032 (GDK_KEY_g): Don't define if already defined.
2033 (xg_prepare_tooltip): Avoid pointer signedness problem.
2034 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2036 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2037 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2039 * xfns.c (Fx_window_property): Simplify a bit,
2040 to make a bit faster and to avoid GCC 4.6.0 warning.
2041 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2043 * fns.c (internal_equal): Don't assume size_t fits in int.
2045 * alloc.c (compact_small_strings): Tighten assertion a little.
2047 Replace pEd with more-general pI, and fix some printf arg casts.
2048 * lisp.h (pI): New macro, generalizing old pEd macro to other
2049 conversion specifiers. For example, use "...%"pI"d..." rather
2050 than "...%"pEd"...".
2051 (pEd): Remove. All uses replaced with similar uses of pI.
2052 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2053 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2054 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2055 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2056 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2057 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2058 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2060 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2061 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2062 * print.c (safe_debug_print, print_object): Likewise.
2063 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2065 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2066 avoiding the 0 flag, which is not portable.
2067 * process.c (Fmake_network_process): Use pI to avoid cast.
2068 * region-cache.c (pp_cache): Likewise.
2069 * xdisp.c (decode_mode_spec): Likewise.
2070 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2071 behavior on 64-bit hosts with printf arg.
2072 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2073 (x_stop_queuing_selection_requests): Likewise.
2074 (x_get_window_property): Don't truncate byte count to an 'int'
2077 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2078 here, since it parses constructs like leading '-' and spaces,
2079 which are not wanted; and it overflows with large numbers.
2080 Instead, simply match F[0-9]+, which is what is wanted anyway.
2082 * alloc.c: Remove unportable assumptions about struct layout.
2083 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2084 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2085 (allocate_vectorlike, make_pure_vector): Use the new macros,
2086 plus offsetof, to remove unportable assumptions about struct layout.
2087 These assumptions hold on all porting targets that I know of, but
2088 they are not guaranteed, they're easy to remove, and removing them
2089 makes further changes easier.
2091 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2092 This doesn't fix a bug but makes the code clearer.
2093 (string_overrun_cookie): Now const. Use initializers that
2094 don't formally overflow signed char, to avoid warnings.
2095 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2096 can cause Emacs to crash when string overrun checking is enabled.
2097 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2098 multiple of sizeof (EMACS_INT); it need not be, if
2099 alignof(EMACS_INT) < sizeof (EMACS_INT).
2100 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2102 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2104 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2106 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2108 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2109 supposed to be handshaking. (Bug#8556)
2110 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2112 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2114 * lisp.h (Qdebug): List symbol.
2115 * eval.c (Qdebug): Restore global linkage.
2116 * keyboard.c (debug-on-event): New variable.
2117 (handle_user_signal): Break into debugger when debug-on-event
2118 matches the current signal symbol.
2120 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2122 * alloc.c (check_sblock, check_string_bytes)
2123 (check_string_free_list): Convert to standard C.
2125 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2127 * w32.c (emacs_gnutls_push): Fix typo.
2129 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2131 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2132 "cast to pointer from integer of different size".
2134 Improve doprnt and its use in verror. (Bug#8545)
2135 * doprnt.c (doprnt): Document the set of format control sequences
2136 supported by the function. Use SAFE_ALLOCA instead of always
2139 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2140 is one byte too soon. Don't use xrealloc; instead xfree and
2143 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2145 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2148 * gnutls.c: Renamed global_initialized to
2149 gnutls_global_initialized. Added internals for the
2150 :verify-hostname-error, :verify-error, and :verify-flags
2151 parameters of `gnutls-boot' and documented those parameters in the
2152 docstring. Start callback support.
2153 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2154 unless a fatal error occured. Call gnutls_alert_send_appropriate
2155 on error. Return error code.
2156 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2157 (emacs_gnutls_read): Likewise.
2158 (Fgnutls_boot): Return handshake error code.
2159 (emacs_gnutls_handle_error): New function.
2160 (wsaerror_to_errno): Likewise.
2162 * w32.h (emacs_gnutls_pull): Add prototype.
2163 (emacs_gnutls_push): Likewise.
2165 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2166 (emacs_gnutls_push): Likewise.
2168 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2170 * process.c (wait_reading_process_output): Check if GnuTLS
2171 buffered some data internally if no FDs are set for TLS
2174 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2175 (LIBS): Link to USER_LIBS.
2176 ($(BLD)/gnutls.$(0)): New target.
2178 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2180 * xdisp.c (handle_single_display_spec): Rename the
2181 display_replaced_before_p argument into display_replaced_p, to
2182 make it consistent with the commentary. Fix typos in the
2185 * textprop.c (syms_of_textprop): Remove dead code.
2186 (copy_text_properties): Delete obsolete commentary about an
2187 interface that was deleted long ago. Fix typos in the description
2190 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2191 to changes in oldXMenu/XMenu.h from 2011-04-16.
2192 <menu_help_message, prev_menu_help_message>: Constify.
2193 (IT_menu_make_room): menu->help_text is now `const char **';
2196 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2197 to changes in oldXMenu/XMenu.h from 2011-04-16.
2198 (struct XMenu): Declare `help_text' `const char **'.
2200 * xfaces.c <Qunspecified>: Make extern again.
2202 * syntax.c: Include sys/types.h before including regex.h, as
2205 * doc.c (get_doc_string): Improve the format passed to `error'.
2207 * doprnt.c (doprnt): Improve commentary.
2209 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2211 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2214 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2215 changes in globals.h immediately force recompilation.
2216 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2217 $(CURDIR)/s/ms-w32.h.
2218 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2220 * character.c (Fchar_direction): Function deleted.
2221 (syms_of_character): Don't defsubr it.
2222 <char-direction-table>: Deleted.
2224 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2226 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2227 * doprnt.c: Include limits.h.
2228 (SIZE_MAX): New macro.
2229 (doprnt): Return a size_t value. 2nd arg is now size_t.
2230 Many local variables are now size_t instead of int or unsigned.
2231 Improve overflow protection. Support `l' modifier for integer
2232 conversions. Support %l conversion. Don't assume an EMACS_INT
2233 argument for integer conversions and for %c.
2235 * lisp.h (doprnt): Restore prototype.
2237 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2240 * Makefile.in (base_obj): Add back doprnt.o.
2242 * deps.mk (doprnt.o): Add back prerequisites.
2243 (callint.o): Depend on character.h.
2245 * eval.c (internal_lisp_condition_case): Include the handler
2246 representation in the error message.
2247 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2248 when breaking from the loop.
2250 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2252 * callint.c (Fcall_interactively): When displaying error message
2253 about invalid control letter, pass the character's codepoint, not
2254 a pointer to its multibyte form. Improve display of the character
2255 in octal and display also its hex code.
2257 * character.c (char_string): Use %x to display the (unsigned)
2258 codepoint of an invalid character, to avoid displaying a bogus
2261 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2262 `error', not SYMBOL_NAME itself.
2264 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2265 character arguments to `error'.
2267 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2268 to `error' in error message about FINAL_CHAR argument. Make sure
2269 FINAL_CHAR is a character, and use %c when it is passed as
2270 argument to `error'.
2272 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2274 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2276 * w32.c: Include <time.h>.
2277 (sys_localtime): New function.
2279 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
2281 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2283 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
2285 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
2287 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2290 2011-04-19 Eli Zaretskii <eliz@gnu.org>
2292 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2293 gl_state.e_property when gl_state.object is Qt.
2295 * insdel.c (make_gap_larger): Remove limitation of buffer size
2298 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
2300 * xdisp.c (lookup_glyphless_char_display)
2301 (produce_glyphless_glyph): Handle cons cell entry in
2302 glyphless-char-display.
2303 (Vglyphless_char_display): Document it.
2305 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2306 glyphless-char-display.
2308 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
2310 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2312 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2314 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2315 definition for no-X builds.
2317 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
2319 Static checks with GCC 4.6.0 and non-default toolkits.
2321 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2323 * process.c (keyboard_bit_set): Define only if SIGIO.
2324 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2325 (send_process): Repair possible setjmp clobbering.
2327 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2329 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2331 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2333 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2334 Define only if needed.
2336 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2337 by pacifying GCC about it. Maybe it's time to retire it?
2338 * xfaces.c (USG, __TIMEVAL__): Likewise.
2340 * dispextern.h (struct redisplay_interface): Rename param
2342 * termhooks.h (struct terminal): Likewise.
2343 * xterm.c (xembed_send_message): Likewise.
2345 * insdel.c (make_gap_smaller): Define only if
2346 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2348 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2351 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2352 so that we aren't warned about unused symbols.
2354 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2356 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
2358 * xfns.c (x_real_positions): Mark locals as initialized.
2360 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2362 * xterm.c: Fix problems found by static analysis with other toolkits.
2363 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
2364 (x_dispatch_event): Declare static if USE_GTK, and
2365 define if USE_GTK || USE_X_TOOLKIT.
2366 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
2367 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
2368 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2369 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
2371 * xmenu.c (menu_help_callback): Pointer type fixes.
2372 Use const pointers when pointing at readonly data. Avoid pointer
2374 (FALSE): Remove unused macro.
2375 (update_frame_menubar): Remove unused decl.
2377 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2379 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2380 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2381 (single_menu_item): Rename local to avoid shadowing.
2383 * keyboard.c (make_lispy_event): Remove unused local var.
2385 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2386 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2388 * bitmaps: Change bitmaps from unsigned char back to the X11
2389 compatible char. Avoid the old compiler warnings about
2390 out-of-range initializers by using, for example, '\xab' rather
2393 * xgselect.c (xgselect_initialize): Check vs interface
2394 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2396 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2398 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2399 to read-only memory.
2401 * fns.c (vector): Remove; this old hack is no longer needed.
2403 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
2405 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2407 * xrdb.c (x_load_resources): Omit unused local.
2409 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
2410 (x_window): Rename locals to avoid shadowing.
2411 (USG): Use the kludged USG macro, to pacify gcc.
2413 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
2414 (x_term_init): Remove local to avoid shadowing.
2416 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
2418 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2419 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2421 2011-04-16 Eli Zaretskii <eliz@gnu.org>
2423 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2425 Fix regex.c, syntax.c and friends for buffers > 2GB.
2426 * syntax.h (struct gl_state_s): Declare character position members
2429 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2431 * textprop.c (verify_interval_modification, interval_of):
2432 Declare arguments EMACS_INT.
2434 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2437 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2439 * indent.c (Fvertical_motion): Local variable it_start is now
2442 * regex.c (re_match, re_match_2, re_match_2_internal)
2443 (bcmp_translate, regcomp, regexec, print_double_string)
2444 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2445 (re_compile_pattern, re_exec): Declare arguments and local
2446 variables `size_t' and `ssize_t' and return values `regoff_t', as
2448 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2449 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2450 <compile_stack_type>: `size' and `avail' are now `size_t'.
2452 * regex.h <regoff_t>: Use ssize_t, not int.
2453 (re_search, re_search_2, re_match, re_match_2): Arguments that
2454 specify buffer/string position and length are now ssize_t and
2455 size_t. Return type is regoff_t.
2457 2011-04-16 Ben Key <bkey76@gmail.com>
2459 * nsfont.m: Fixed bugs in ns_get_family and
2460 ns_descriptor_to_entity that were caused by using free to
2461 deallocate memory blocks that were allocated by xmalloc (via
2462 xstrdup). This caused Emacs to crash when compiled with
2463 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2464 --enable-checking=xmallocoverrun). xfree is now used to
2465 deallocate these memory blocks.
2467 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
2469 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2471 emacs_write: Accept and return EMACS_INT for sizes.
2472 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2474 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2475 Accept and return EMACS_INT.
2476 (emacs_gnutls_write): Return the number of bytes written on
2478 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
2479 (emacs_read, emacs_write): Remove check for negative size, as the
2480 Emacs source code has been audited now.
2481 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2482 (emacs_read, emacs_write): Use it.
2483 * process.c (send_process): Adjust to the new signatures of
2484 emacs_write and emacs_gnutls_write. Do not attempt to store
2485 a byte offset into an 'int'; it might overflow.
2486 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
2488 * sound.c: Don't assume sizes fit in 'int'.
2489 (struct sound_device.period_size, alsa_period_size):
2490 Return EMACS_INT, not int.
2491 (struct sound_device.write, vox_write, alsa_write):
2492 Accept EMACS_INT, not int.
2493 (wav_play, au_play): Use EMACS_INT to store sizes and to
2494 record read return values.
2496 2011-04-15 Ben Key <bkey76@gmail.com>
2498 * keyboard.c (Qundefined): Don't declare static since it is used
2500 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2501 static since they are used in nsfont.m.
2503 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2505 * process.c (Qprocessp): Don't declare static.
2506 * lisp.h (Qprocessp): Declare again.
2508 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
2510 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2512 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2514 Improve C-level modularity by making more things 'static'.
2516 Don't publish debugger-only interfaces to other modules.
2517 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2518 (verify_bytepos, count_markers): Move decls to the only modules
2520 * region-cache.h (pp_cache): Likewise.
2521 * window.h (check_all_windows): Likewise.
2522 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2524 * sysdep.c (croak): Now static, if
2525 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2526 * syssignal.h (croak): Declare only if not static.
2528 * alloc.c (refill_memory_reserve): Now static if
2529 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2530 * lisp.h (refill_memory_reserve): Declare only if not static.
2532 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2533 Define only if USE_LUCID.
2535 * xrdb.c (x_customization_string, x_rm_string): Now static.
2537 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2538 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2540 * xdisp.c (draw_row_with_mouse_face): Now static.
2541 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2543 * window.h (check_all_windows): Mark externally visible.
2545 * window.c (window_deletion_count): Now static.
2547 * undo.c: Make symbols static if they're not exported.
2548 (last_undo_buffer, last_boundary_position, pending_boundary):
2551 * textprop.c (interval_insert_behind_hooks): Now static.
2552 (interval_insert_in_front_hooks): Likewise.
2554 * term.c: Make symbols static if they're not exported.
2555 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2556 (max_frame_lines, tty_set_terminal_modes):
2557 (tty_reset_terminal_modes, tty_turn_off_highlight):
2558 (get_tty_terminal): Now static.
2559 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2560 * termhooks.h (term_mouse_moveto): Do not declare if
2562 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2563 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2565 * sysdep.c: Make symbols static if they're not exported.
2566 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2568 (sigprocmask_set, full_mask): Remove; unused.
2569 (wait_debugging): Mark as visible.
2570 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2571 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2573 * syntax.c (syntax_temp): Define only if !__GNUC__.
2575 * sound.c (current_sound_device, current_sound): Now static.
2577 * search.c (searchbufs, searchbuf_head): Now static.
2579 * scroll.c (scroll_cost): Remove; unused.
2580 * dispextern.h (scroll_cost): Remove decl.
2582 * region-cache.h (pp_cache): Mark as externally visible.
2584 * process.c: Make symbols static if they're not exported.
2585 (process_tick, update_tick, create_process, chan_process):
2586 (Vprocess_alist, proc_buffered_char, datagram_access):
2587 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2588 (deactivate_process): Mark defn as static, as well as decl.
2589 * lisp.h (create_process): Remove decl.
2590 * process.h (chan_process, Vprocess_alist): Remove decls.
2592 * print.c: Make symbols static if they're not exported.
2593 (print_depth, new_backquote_output, being_printed, print_buffer):
2594 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2595 (print_interval, print_number_index, initial_stderr_stream):
2597 * lisp.h (Fprinc): Remove decl.
2598 (debug_output_compilation_hack): Mark as externally visible.
2600 * sysdep.c (croak): Move decl from here to syssignal.h.
2601 * syssignal.h (croak): Put it here, so the API can be checked when
2602 'croak' is called from dissociate_if_controlling_tty.
2604 * minibuf.c: Make symbols static if they're not exported.
2605 (minibuf_save_list, choose_minibuf_frame): Now static.
2606 * lisp.h (choose_minibuf_frame): Remove decl.
2608 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2610 * lread.c: Make symbols static if they're not exported.
2611 (read_objects, initial_obarray, oblookup_last_bucket_number):
2613 (make_symbol): Remove; unused.
2614 * lisp.h (initial_obarray, make_symbol): Remove decls.
2616 * keyboard.c: Make symbols static if they're not exported.
2617 (single_kboard, recent_keys_index, total_keys, recent_keys):
2618 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2619 (this_single_command_key_start, echoing, last_auto_save):
2620 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2621 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2622 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2623 (Vlispy_mouse_stem, double_click_count):
2625 (force_auto_save_soon): Define only if SIGDANGER.
2626 (ignore_mouse_drag_p): Now static if
2627 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2628 (print_help): Remove; unused.
2629 (stop_character, last_timer_event): Mark as externally visible.
2630 * keyboard.h (ignore_mouse_drag_p): Declare only if
2631 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2632 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2633 * lisp.h (echoing): Remove decl.
2634 (force_auto_save_soon): Declare only if SIGDANGER.
2635 * xdisp.c (redisplay_window): Simplify code, to make it more
2636 obvious that ignore_mouse_drag_p is not accessed if !defined
2637 USE_GTK && !defined HAVE_NS.
2639 * intervals.c: Make symbols static if they're not exported.
2640 (merge_properties_sticky, merge_interval_right, delete_interval):
2642 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2644 * insdel.c: Make symbols static if they're not exported.
2645 However, leave prepare_to_modify_buffer alone. It's never
2646 called from outside this function, but that appears to be a bug.
2647 (combine_after_change_list, combine_after_change_buffer):
2648 (adjust_after_replace, signal_before_change): Now static.
2649 (adjust_after_replace_noundo): Remove; unused.
2650 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
2651 (signal_before_change): Remove decls.
2653 * indent.c (val_compute_motion, val_vmotion): Now static.
2655 * image.c: Make symbols static if they're not exported.
2656 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2658 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2659 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2661 * fringe.c (standard_bitmaps): Now static.
2662 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2664 * frame.c: Make symbols static if they're not exported.
2665 (x_report_frame_params, make_terminal_frame): Now static.
2666 (get_frame_param): Now static, unless HAVE_NS.
2667 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2668 (x_get_resource_string): Remove; not used.
2669 * frame.h (make_terminal_frame, x_report_frame_params):
2670 (x_get_resource_string); Remove decls.
2671 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2672 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2674 * font.c, fontset.c: Make symbols static if they're not exported.
2675 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2676 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2677 * font.c (font_close_object): Now static.
2678 * font.h (font_close_object): Remove.
2679 * fontset.c (FONTSET_OBJLIST): Remove.
2680 (free_realized_fontset) #if-0 the body, which does nothing.
2681 (face_suitable_for_char_p): #if-0, as it's never called.
2682 * fontset.h (face_suitable_for_char_p): Remove decl.
2683 * xfaces.c (face_at_string_position):
2684 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
2685 since 0 is always ASCII.
2687 * fns.c (weak_hash_tables): Now static.
2689 * fileio.c: Make symbols static if they're not exported.
2690 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2691 (Vwrite_region_annotation_buffers): Now static.
2693 * eval.c: Make symbols static if they're not exported.
2694 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2695 * lisp.h (backtrace_list): Remove decl.
2697 * emacs.c: Make symbols static if they're not exported.
2698 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2699 (fatal_error_code, fatal_error_signal_hook, standard_args):
2701 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2702 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2703 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2704 * lisp.h (fatal_error_signal_hook): Remove decl.
2705 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2707 * editfns.c: Move a (normally-unused) function to its only use.
2708 * editfns.c, lisp.h (get_operating_system_release): Remove.
2709 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2710 worth the hassle of breaking this out.
2712 * xterm.c: Make symbols static if they're not exported.
2713 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2714 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2715 (x_destroy_window, x_delete_display):
2717 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2718 (x_mouse_leave): Remove; unused.
2719 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2720 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2721 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2723 (x_mouse_leave): Declare only if WINDOWSNT.
2724 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2725 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2728 * ftxfont.c: Make symbols static if they're not exported.
2729 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2731 * font.h (ftxfont_driver): Likewise.
2733 * xfns.c: Make symbols static if they're not exported.
2734 (x_last_font_name, x_display_info_for_name):
2735 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2736 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2737 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2738 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2739 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2740 (last_show_tip_args): Now static.
2741 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2742 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2743 (x_screen_planes): Remove; unused.
2744 * dispextern.h (x_screen_planes): Remove decl.
2746 * dispnew.c: Make symbols static if they're not exported.
2747 * dispextern.h (redraw_garbaged_frames, scrolling):
2748 (increment_row_positions): Remove.
2749 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2750 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2752 (redraw_garbaged_frames): Remove; unused.
2754 * xfaces.c: Make symbols static if they're not exported.
2755 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2757 * xterm.h (defined_color): Remove decls.
2758 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2759 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2760 (menu_face_changed_default, defined_color, free_realized_face):
2761 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2762 (ascii_face_of_lisp_face): Remove; unused.
2764 * xdisp.c: Make symbols static if they're not exported.
2765 * dispextern.h (scratch_glyph_row, window_box_edges):
2766 (glyph_to_pixel_coords, set_cursor_from_row):
2767 (get_next_display_element, set_iterator_to_next):
2768 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2769 (show_mouse_face): Remove decls
2770 * frame.h (message_buf_print): Likewise.
2771 * lisp.h (pop_message, set_message, check_point_in_composition):
2773 * xterm.h (set_vertical_scroll_bar): Likewise.
2774 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2775 (message_buf_print, scratch_glyph_row, displayed_buffer):
2776 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2777 (get_next_display_element, show_mouse_face, window_box_edges):
2778 (frame_to_window_pixel_xy, check_point_in_composition):
2779 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2780 (glyph_to_pixel_coords): Remove; unused.
2782 * dired.c (file_name_completion): Now static.
2784 * dbusbind.c (xd_in_read_queued_messages): Now static.
2786 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2787 * data.c (circular_list_error): Remove.
2789 * commands.h (last_point_position, last_point_position_buffer):
2790 (last_point_position_window): Remove decls.
2791 * keyboard.c: Make these variables static.
2793 * coding.h (coding, code_convert_region, encode_coding_gap):
2795 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2796 (iso_code_class, detect_coding, code_convert_region): Now static.
2797 (encode_coding_gap): Remove; unused.
2799 * chartab.c (chartab_chars, chartab_bits): Now static.
2801 * charset.h (charset_iso_8859_1): Remove decl.
2802 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2805 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2806 * ccl.c (Vccl_program_table): Now static.
2807 (check_ccl_update): Remove; unused.
2809 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2810 * category.h: ... from here.
2811 * category.c (check_category_table, set_category_set): Now static.
2813 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2814 * lisp.h: Remove these decls.
2816 * buffer.c (buffer_count): Remove unused var.
2818 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2819 so that it's not optimized away.
2820 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2821 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2822 exported only to the debugger.
2824 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2825 * atimer.h (run_all_atimers): Remove; not exported.
2827 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2828 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2829 was inaccessible from Lisp.
2830 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2831 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2833 alloc.c: Import and export fewer symbols, and remove unused items.
2834 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2836 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2837 it's not optimized away by whole-program optimization.
2838 (message_enable_multibyte, free_misc): Remove.
2839 (catchlist, handlerlist, mark_backtrace):
2840 Declare only if BYTE_MARK_STACK.
2841 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2842 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2843 (message_enable_multibyte): Remove decl.
2844 (free_misc, interval_free_list, float_block, float_block_index):
2845 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2846 (cons_free_list, last_marked_index):
2848 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2849 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2850 (mark_backtrace): Define only if BYTE_MARK_STACK.
2851 * xdisp.c (message_enable_multibyte): Now static.
2853 Declare Lisp_Object Q* variables to be 'static' if not exported.
2854 This makes it easier for human readers (and static analyzers)
2855 to see whether these variables are used from other modules.
2856 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2857 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2858 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2859 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2860 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2861 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2862 * xmenu.c, xselect.c:
2863 Declare Q* vars static if they are not used in other modules.
2864 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2865 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2866 Remove decls of unexported vars.
2867 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2869 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2871 Make Emacs functions such as Fatom 'static' by default.
2872 This makes it easier for human readers (and static analyzers)
2873 to see whether these functions can be called from other modules.
2874 DEFUN now defines a static function. To make the function external
2875 so that it can be used in other C modules, use the new macro DEFUE.
2876 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2877 (Finit_image_library):
2878 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2879 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2880 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2881 Remove decls, since these functions are now static.
2882 (Funintern, Fget_internal_run_time): New decls, since these functions
2883 were already external.
2885 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2886 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2887 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2888 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2889 * keyboard.c, keymap.c, lread.c:
2890 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2891 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2892 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2893 Mark functions with DEFUE instead of DEFUN,
2894 if they are used in other modules.
2895 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2896 decls for now-static functions.
2897 * buffer.h (Fdelete_overlay): Remove decl.
2898 * callproc.c (Fgetenv_internal): Mark as internal.
2899 * composite.c (Fremove_list_of_text_properties): Remove decl.
2900 (Fcomposition_get_gstring): New forward static decl.
2901 * composite.h (Fcomposite_get_gstring): Remove decl.
2902 * dired.c (Ffile_attributes): New forward static decl.
2903 * doc.c (Fdocumntation_property): New forward static decl.
2904 * eval.c (Ffetch_bytecode): New forward static decl.
2905 (Funintern): Remove extern decl; now in .h file where it belongs.
2906 * fileio.c (Fmake_symbolic_link): New forward static decl.
2907 * image.c (Finit_image_library): New forward static decl.
2908 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2909 * intervals.h (Fprevious_property_change):
2910 (Fremove_list_of_text_properties): Remove decls.
2911 * keyboard.c (Fthis_command_keys): Remove decl.
2912 (Fcommand_execute): New forward static decl.
2913 * keymap.c (Flookup_key): New forward static decl.
2914 (Fcopy_keymap): Now static.
2915 * keymap.h (Flookup_key): Remove decl.
2916 * process.c (Fget_process): New forward static decl.
2917 (Fprocess_datagram_address): Mark as internal.
2918 * syntax.c (Fsyntax_table_p): New forward static decl.
2919 (skip_chars): Remove duplicate decl.
2920 * textprop.c (Fprevious_property_change): New forward static decl.
2921 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2923 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2924 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2926 * editfns.c (Fformat): Remove unreachable code.
2928 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2930 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2933 2011-04-13 Eli Zaretskii <eliz@gnu.org>
2935 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2936 when at ZV. (Bug#8487)
2938 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2940 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2942 * keyboard.c (parse_tool_bar_item): Likewise.
2943 * sound.c (sound_cleanup, alsa_close): Likewise.
2944 * termcap.c (tgetent): Likewise.
2945 * xfns.c (x_default_font_parameter): Likewise.
2946 * xsettings.c (read_and_apply_settings): Likewise.
2948 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2949 (overrun_check_free): Protoize.
2951 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2953 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2954 since callers should never pass a negative size.
2955 Change the signature to match that of plain 'read' and 'write'; see
2956 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2957 * lisp.h: Update prototypes of emacs_write and emacs_read.
2959 2011-04-11 Eli Zaretskii <eliz@gnu.org>
2961 * xdisp.c (redisplay_window): Don't try to determine the character
2962 position of the scroll margin if the window start point w->startp
2963 is outside the buffer's accessible region. (Bug#8468)
2965 2011-04-10 Eli Zaretskii <eliz@gnu.org>
2967 Fix write-region and its subroutines for buffers > 2GB.
2968 * fileio.c (a_write, e_write): Modify declaration of arguments and
2969 local variables to support buffers larger than 2GB.
2970 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2972 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2973 argument, local variables, and return value.
2975 * lisp.h: Update prototypes of emacs_write and emacs_read.
2977 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2979 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
2981 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2983 Fix more problems found by GCC 4.6.0's static checks.
2985 * xdisp.c (vmessage): Use a better test for character truncation.
2987 * charset.c (load_charset_map): <, not <=, for optimization,
2988 and to avoid potential problems with integer overflow.
2989 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
2990 * casetab.c (set_identity, shuffle): Likewise.
2991 * editfns.c (Fformat): Likewise.
2992 * syntax.c (skip_chars): Likewise.
2994 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2995 This also lets GCC 4.6.0 generate slightly better loop code.
2997 * callint.c (Fcall_interactively): <, not <=, for optimization.
2998 (Fcall_interactively): Count the number of arguments produced,
2999 not the number of arguments given. This is simpler and lets GCC
3000 4.6.0 generate slightly better code.
3002 * ftfont.c: Distingish more carefully between FcChar8 and char.
3003 The previous code passed unsigned char * to a functions like
3004 strlen and xstrcasecmp that expect char *, which does not
3005 conform to the C standard.
3006 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3007 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3008 char * when the C standard requires it.
3010 * keyboard.c (read_char): Remove unused var.
3012 * eval.c: Port to Windows vsnprintf (Bug#8435).
3014 (SIZE_MAX): Define if the headers do not.
3015 (verror): Do not give up if vsnprintf returns a negative count.
3016 Instead, grow the buffer. This ports to Windows vsnprintf, which
3017 does not conform to C99. Problem reported by Eli Zaretskii.
3018 Also, simplify the allocation scheme, by avoiding the need for
3019 calling realloc, and removing the ALLOCATED variable.
3021 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3023 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3024 But keep the doprint source code for now, as we might revamp it
3025 and use it again (Bug#8435).
3026 * lisp.h (doprnt): Remove.
3027 * Makefile.in (base_obj): Remove doprnt.o.
3028 * deps.mk (doprnt.o): Remove.
3030 error: Print 32- and 64-bit integers portably (Bug#8435).
3031 Without this change, on typical 64-bit hosts error ("...%d...", N)
3032 was used to print both 32- and 64-bit integers N, which relied on
3034 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3036 * lisp.h (error, verror): Mark as printf-like functions.
3037 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3038 Report overflow in size calculations when allocating printf buffer.
3039 Do not truncate output string at its first null byte.
3040 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3041 Truncate the output at a character boundary, since vsnprintf does not
3043 * charset.c (check_iso_charset_parameter): Convert internal
3044 character to string before calling 'error', since %c now has the
3046 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3047 overflow when computing char to be passed to 'error'. Do not
3048 pass Lisp_Object to 'error'; pass the integer instead.
3049 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3050 formatted with plain %d.
3052 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3054 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3056 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3058 * xterm.c (x_catch_errors): Remove duplicate declaration.
3060 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3062 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3064 2011-04-10 Jim Meyering <meyering@redhat.com>
3066 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3067 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3068 return ssize_t not "int", and use size_t as the buffer length.
3069 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3070 * gnutls.h: Update declarations.
3071 * process.c (read_process_output): Use ssize_t, to match.
3072 (send_process): Likewise.
3074 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3076 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3078 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3080 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3081 Use unsigned char, to match FcChar8 type definition.
3083 * xterm.c (handle_one_xevent):
3084 * xmenu.c (create_and_show_popup_menu):
3085 * xselect.c (x_decline_selection_request)
3086 (x_reply_selection_request): Avoid type-punned deref of X events.
3088 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3090 Fix some uses of `int' instead of EMACS_INT.
3091 * search.c (string_match_1, fast_string_match)
3092 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3093 (scan_buffer, find_next_newline_no_quit)
3094 (find_before_next_newline, search_command, Freplace_match)
3095 (Fmatch_data): Make some `int' variables be EMACS_INT.
3097 * xdisp.c (display_count_lines): 3rd argument and return value now
3098 EMACS_INT. All callers changed.
3099 (pint2hrstr): Last argument is now EMACS_INT.
3101 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3102 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3103 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3104 (decode_coding_utf_16, decode_coding_emacs_mule)
3105 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3106 (decode_coding_ccl, decode_coding_charset)
3107 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3108 (decode_coding_iso_2022, decode_coding_emacs_mule)
3109 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3110 <char_offset, last_offset>: Declare EMACS_INT.
3111 (encode_coding_utf_8, encode_coding_utf_16)
3112 (encode_coding_emacs_mule, encode_invocation_designation)
3113 (encode_designation_at_bol, encode_coding_iso_2022)
3114 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3115 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3117 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3118 (encode_invocation_designation): Last argument P_NCHARS is now
3120 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3121 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3123 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3126 * ccl.c (Fccl_execute_on_string): Declare some variables
3129 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3131 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3133 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3135 * process.c (Fformat_network_address): Doc fix.
3137 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3139 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3141 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3143 * keyboard.c (read_char): Call Lisp function help-form-show,
3144 instead of using internal_with_output_to_temp_buffer.
3145 (Qhelp_form_show): New var.
3146 (syms_of_keyboard): Use DEFSYM macro.
3148 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3150 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3152 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3154 * process.c (Flist_processes): Remove to Lisp.
3155 (list_processes_1): Delete.
3157 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3159 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3161 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3163 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3165 Fix more problems found by GCC 4.6.0's static checks.
3167 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3169 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3171 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3173 * xdisp.c (vmessage): Mark as a printf-like function.
3175 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3177 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3179 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3180 printf-like functions.
3181 (tiff_load): Add casts to remove these marks before passing them
3182 to system-supplied API.
3184 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3186 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3187 This avoids several warnings with gcc -Wstrict-overflow.
3188 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3189 directly, rather than having caller test rule sign. This avoids
3190 some unnecessary tests.
3191 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3192 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3193 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3195 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3196 (xfont_open): Avoid unnecessary tests.
3198 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3200 * composite.h, composite.c (composition_gstring_put_cache):
3201 Use EMACS_INT, not int, for length.
3203 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3204 breaking out part of COMPOSITION_DECODE_RULE.
3205 (COMPOSITION_DECODE_RULE): Use it.
3206 * composite.c (get_composition_id): Remove unused local vars,
3207 by using the new macro.
3209 * textprop.c (set_text_properties_1): Change while to do-while,
3210 since the condition is always true at first.
3212 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3213 (interval_deletion_adjustment): Return unsigned value.
3216 * process.c (list_processes_1, create_pty, read_process_output):
3217 (exec_sentinel): Remove vars that were set but not used.
3218 (create_pty): Remove unnecessary "volatile"s.
3219 (Fnetwork_interface_info): Avoid possibility of int overflow.
3220 (read_process_output): Do adaptive read buffering even if carryover.
3221 (read_process_output): Simplify nbytes computation if buffered.
3223 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3225 * syntax.c (scan_words): Remove var that was set but not used.
3226 (update_syntax_table): Use unsigned instead of int.
3228 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3229 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3230 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3232 * print.c (print_error_message): Avoid int overflow.
3234 * font.c (font_list_entities): Redo for clarity,
3235 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3237 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3238 (font_score): Avoid potential overflow in diff calculation.
3240 * fns.c (substring_both): Remove var that is set but not used.
3241 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3243 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3245 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3246 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3247 can always succeed if overflow has undefined behavior.
3249 * search.c (boyer_moore, wordify): Remove vars set but not used.
3250 (wordify): Omit three unnecessary tests.
3252 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3253 All callers changed. This avoids the need for an unused var.
3255 * casefiddle.c (casify_region): Remove var that is set but not used.
3257 * dired.c (file_name_completion): Remove var that is set but not used.
3259 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3261 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
3262 (Finsert_file_contents): Remove unnecessary code checking fd.
3264 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3265 Check for integer overflow on size calculations.
3267 * buffer.c (Fprevious_overlay_change): Remove var that is set
3270 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3271 Remove vars that are set but not used.
3272 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
3273 (timer_check_2): Mark vars as initialized.
3275 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3277 * image.c (lookup_image): Remove var that is set but not used.
3278 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
3280 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3281 that are set but not used.
3283 * xfns.c (make_invisible_cursor): Don't return garbage
3284 if XCreateBitmapFromData fails (Bug#8410).
3286 * xselect.c (x_get_local_selection, x_handle_property_notify):
3287 Remove vars that are set but not used.
3289 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
3290 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
3292 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3293 Remove var that is set but not used.
3294 (scroll_bar_windows_size): Now size_t, not int.
3295 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3298 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3299 (map_tty_color) [!defined MSDOS]: Likewise.
3301 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3303 * coding.c: Remove vars that are set but not used.
3304 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3305 All callers changed.
3306 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3307 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3308 (decode_coding_charset): Remove vars that are set but not used.
3310 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3311 that is set but not used.
3313 * print.c (print_object): Remove var that is set but not used.
3315 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
3316 The gnulib version avoids calling malloc in the usual case,
3317 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3318 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3319 * filelock.c (current_lock_owner): Likewise.
3320 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3321 * sysdep.c: Include allocator.h, careadlinkat.h.
3322 (emacs_no_realloc_allocator): New static constant.
3323 (emacs_readlink): New function.
3324 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3325 ../lib/careadlinkat.h.
3327 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3329 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3330 first non-nil return value).
3332 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3334 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3335 if not defined (Bug#8403).
3337 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3339 * xdisp.c (display_count_lines): Remove parameter `start',
3340 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3341 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3342 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3343 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3344 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3345 and thereabouts. All callers changed.
3346 (get_per_char_metric): Remove parameter `f', unused since
3347 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3349 2011-04-02 Jim Meyering <meyering@redhat.com>
3351 do not dereference NULL upon failed strdup
3352 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3353 (ns_get_family): Likewise.
3355 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3357 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3359 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3361 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3364 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3366 Add lexical binding.
3368 * window.c (Ftemp_output_buffer_show): New fun.
3369 (Fsave_window_excursion):
3370 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3372 * lread.c (lisp_file_lexically_bound_p): New function.
3373 (Fload): Bind Qlexical_binding.
3374 (readevalloop): Remove `evalfun' arg.
3375 Bind Qinternal_interpreter_environment.
3376 (Feval_buffer): Bind Qlexical_binding.
3377 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3379 (syms_of_lread): Declare `lexical-binding'.
3381 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3383 * keyboard.c (eval_dyn): New fun.
3384 (menu_item_eval_property): Use it.
3386 * image.c (parse_image_spec): Use Ffunctionp.
3388 * fns.c (concat, mapcar1): Accept byte-code-functions.
3390 * eval.c (Fsetq): Handle lexical vars.
3391 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3392 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3393 (FletX, Flet): Obey lexical binding.
3394 (Fcommandp): Handle closures.
3395 (Feval): New `lexical' arg.
3396 (eval_sub): New function extracted from Feval. Use it almost
3397 everywhere where Feval was used. Look up vars in lexical env.
3399 (Ffunctionp): Move from subr.el.
3400 (Ffuncall): Handle closures.
3401 (apply_lambda): Remove `eval_flags'.
3402 (funcall_lambda): Handle closures and new byte-code-functions.
3403 (Fspecial_variable_p): New function.
3404 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3405 but without exporting it to Lisp.
3407 * doc.c (Fdocumentation, store_function_docstring):
3408 * data.c (Finteractive_form): Handle closures.
3410 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3413 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3415 (exec_byte_code): New function extracted from Fbyte_code to handle new
3416 calling convention for byte-code-functions. Add new byte-codes.
3418 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
3420 * alloc.c (Fmake_symbol): Init new `declared_special' field.
3422 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3424 * xdisp.c (redisplay_internal): Fix prototype.
3426 2011-03-31 Eli Zaretskii <eliz@gnu.org>
3428 * xdisp.c (SCROLL_LIMIT): New macro.
3429 (try_scrolling): Use it when setting scroll_limit.
3430 Limit scrolling to 100 screen lines.
3431 (redisplay_window): Even when falling back on "recentering",
3432 position point in the window according to scroll-conservatively,
3433 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3435 (try_scrolling): When point is above the window, allow searching
3436 as far as scroll_max, or one screenful, to compute vertical
3437 distance from PT to the scroll margin position. This prevents
3438 try_scrolling from unnecessarily failing when
3439 scroll-conservatively is set to a value slightly larger than the
3440 window height. Clean up the case of PT below the margin at bottom
3441 of window: scroll_max can no longer be INT_MAX. When aggressive
3442 scrolling is in use, don't let point enter the opposite scroll
3443 margin as result of the scroll.
3444 (syms_of_xdisp) <scroll-conservatively>: Document the
3445 threshold of 100 lines for never-recentering scrolling.
3447 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3449 * dispextern.h (move_it_by_lines):
3450 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3451 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3452 (message_log_check_duplicate): Remove parameters `prev_bol' and
3453 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3454 (redisplay_internal): Remove parameter `preserve_echo_area',
3455 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3457 * indent.c (Fvertical_motion):
3458 * window.c (window_scroll_pixel_based, Frecenter):
3459 Don't pass `need_y_p' to `move_it_by_lines'.
3461 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3463 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3464 steal a few bits to be more compact.
3465 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3466 Remove unneeded casts.
3468 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3470 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3472 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3473 binding" message (bug#7967).
3475 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3477 Fix more problems found by GCC 4.6.0's static checks.
3479 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3480 Remove unused local var.
3482 * editfns.c (Fmessage_box): Remove unused local var.
3484 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3485 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3486 Omit unused local vars.
3487 * window.c (shrink_windows): Omit unused local var.
3488 * menu.c (digest_single_submenu): Omit unused local var.
3489 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3490 Omit unused local var.
3492 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3493 Don't assume string length fits in int.
3494 (keyremap_step, read_key_sequence): Use size_t for sizes.
3495 (read_key_sequence): Don't check last_real_key_start redundantly.
3497 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3498 instead of alloca (Bug#8344).
3500 * eval.c (Fbacktrace): Don't assume nargs fits in int.
3501 (Fbacktrace_frame): Don't assume nframes fits in int.
3503 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3505 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3508 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3510 * cm.c (calccost): Turn while-do into do-while, for clarity.
3512 * keyboard.c (syms_of_keyboard): Use the same style as later
3513 in this function when indexing through an array. This also
3514 works around GCC bug 48267.
3516 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3518 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3520 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3521 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3523 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3524 This avoids undefined behavior on integer overflow, and is a bit
3525 more convenient anyway since it is compared to a size_t variable.
3527 Variadic C functions now count arguments with size_t, not int.
3528 This avoids an unnecessary limitation on 64-bit machines, which
3529 caused (substring ...) to crash on large vectors (Bug#8344).
3530 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3531 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
3532 All variadic functions and their callers changed accordingly.
3533 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3534 * data.c (arith_driver, float_arith_driver): Likewise.
3535 * editfns.c (general_insert_function): Likewise.
3536 * eval.c (struct backtrace.nargs, interactive_p)
3537 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3538 (funcall_lambda, mark_backtrace): Likewise.
3539 * fns.c (concat): Likewise.
3540 * frame.c (x_set_frame_parameters): Likewise.
3541 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3542 0 if not found, not -1. All callers changed.
3544 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3545 (stack_copy_size): Now size_t, not int.
3546 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3548 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3550 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3551 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3552 All callers changed.
3554 * lisp.h (multibyte_char_to_unibyte):
3555 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3556 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3557 * character.h (CHAR_TO_BYTE8):
3558 * cmds.c (internal_self_insert):
3559 * editfns.c (general_insert_function):
3560 * keymap.c (push_key_description):
3561 * search.c (Freplace_match):
3562 * xdisp.c (message_dolog, set_message_1): All callers changed.
3564 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3566 * keyboard.c (safe_run_hook_funcall): New function.
3567 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3568 don't set the hook to nil, but remove the offending function instead.
3569 (Qcommand_hook_internal): Remove, unused.
3570 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3571 Vcommand_hook_internal.
3573 * eval.c (enum run_hooks_condition): Remove.
3574 (funcall_nil, funcall_not): New functions.
3575 (run_hook_with_args): Call each function through a `funcall' argument.
3576 Remove `cond' argument, now redundant.
3577 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3578 (Frun_hook_with_args_until_failure): Adjust accordingly.
3579 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3581 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3583 * dispextern.h (string_buffer_position): Remove declaration.
3585 * print.c (strout): Remove parameter `multibyte', unused since
3586 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3588 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3589 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3590 All callers changed.
3592 * w32.c (_wsa_errlist): Use braces for struct initializers.
3594 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3595 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3596 All callers changed.
3597 (string_buffer_position): Likewise. Also, make static (it's never
3598 used outside xdisp.c).
3599 (cursor_row_p): Remove parameter `w', unused since
3600 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3601 (decode_mode_spec): Remove parameter `precision', introduced during
3602 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3603 All callers changed.
3605 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3607 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3609 2011-03-27 Anders Lindgren <andlind@gmail.com>
3611 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3612 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3613 (ns_update_auto_hide_menu_bar): New functions.
3614 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3615 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3616 ns_constrain_all_frames.
3617 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3618 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3620 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3622 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3624 2011-03-27 Glenn Morris <rgm@gnu.org>
3626 * syssignal.h: Replace RETSIGTYPE with void.
3627 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3628 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3629 Replace SIGTYPE with void everywhere.
3630 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3631 * s/template.h (SIGTYPE): Remove commented out definition.
3633 2011-03-26 Eli Zaretskii <eliz@gnu.org>
3635 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3636 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3638 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
3640 * w32.c (read_unc_volume): Use parameter `henum', instead of
3641 global variable `wget_enum_handle'.
3643 * keymap.c (describe_vector): Remove parameters `indices' and
3644 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3645 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3647 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3649 * keyboard.c (timer_check): Remove parameter `do_it_now',
3650 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3651 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3652 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3654 * keyboard.c (read_char):
3655 * w32menu.c (w32_menu_display_help):
3656 * xmenu.c (show_help_event, menu_help_callback):
3657 Adjust calls to `show_help_echo'.
3659 * gtkutil.c (xg_maybe_add_timer):
3660 * keyboard.c (readable_events):
3661 * process.c (wait_reading_process_output):
3662 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3664 * insdel.c (adjust_markers_gap_motion):
3665 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3666 (gap_left, gap_right): Don't call it.
3668 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
3670 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3671 incurred during fontification.
3673 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3675 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3676 (DEFVAR_PER_BUFFER): Don't pass it.
3678 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3679 (scrolling_window): Don't pass it.
3681 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3683 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3685 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3687 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3688 of variables specific to SELinux and computation of `encoded_absname'.
3690 * image.c (XPutPixel): Remove unused variable `height'.
3692 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3694 * unexw32.c (get_section_info): Remove unused variable `section'.
3696 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3697 (system_process_attributes): Remove unused variable `sess'.
3698 (sys_read): Remove unused variable `err'.
3700 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3701 (w32_wnd_proc): Remove unused variable `isdead'.
3702 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3703 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3704 (x_create_tip_frame): Remove unused variable `tem'.
3706 * w32inevt.c (w32_console_read_socket):
3707 Remove unused variable `no_events'.
3709 * w32term.c (x_draw_composite_glyph_string_foreground):
3710 Remove unused variable `width'.
3712 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
3714 * w32term.c (x_set_glyph_string_clipping):
3715 Don't pass uninitialized region to CombineRgn.
3717 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
3719 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3720 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3721 (Fx_close_connection): Remove unused variable `i'.
3723 * w32font.c (w32font_draw): Return number of glyphs.
3724 (w32font_open_internal): Remove unused variable `i'.
3725 (w32font_driver): Add missing initializer.
3727 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3728 (fill_in_menu): Remove unused variable `items_added'.
3730 * w32term.c (last_mouse_press_frame): Remove static global variable.
3731 (w32_clip_to_row): Remove unused variable `f'.
3732 (x_delete_terminal): Remove unused variable `i'.
3734 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3735 (NOTHING): Remove unused static global variable.
3736 (uniscribe_check_otf): Remove unused variable `table'.
3737 (uniscribe_font_driver): Add missing initializers.
3739 2011-03-23 Julien Danjou <julien@danjou.info>
3741 * term.c (Fsuspend_tty, Fresume_tty):
3742 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3743 * window.c (temp_output_buffer_show):
3744 * insdel.c (signal_before_change):
3745 * frame.c (Fhandle_switch_frame):
3746 * fileio.c (Fdo_auto_save):
3747 * emacs.c (Fkill_emacs):
3748 * editfns.c (save_excursion_restore):
3749 * cmds.c (internal_self_insert):
3750 * callint.c (Fcall_interactively):
3751 * buffer.c (Fkill_all_local_variables):
3752 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3754 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
3755 unconditionnaly since it does the check itself.
3757 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
3759 Fix more problems found by GCC 4.5.2's static checks.
3761 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3762 the first time through the loop, since we know p0 < p1 then.
3763 This also avoids a gcc -Wstrict-overflow warning.
3765 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3766 leading to a memory leak, possible in functions like
3767 load_charset_map_from_file that can allocate an unbounded number
3768 of objects (Bug#8318).
3770 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3771 that could (at least in theory) be that large.
3773 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3774 This is less likely to overflow, and avoids undefined behavior if
3775 overflow does occur. All callers changed. Use strtoul to scan
3776 for the unsigned long integer.
3777 (pint2hrstr): Simplify and tune code slightly.
3778 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
3780 * scroll.c (do_scrolling): Work around GCC bug 48228.
3781 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3783 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3784 This also avoids a warning with gcc -Wstrict-overflow.
3785 (validate_x_resource_name): Simplify count usage.
3786 This also avoids a warning with gcc -Wstrict-overflow.
3788 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3791 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
3793 * process.c (Fmake_network_process): Use socklen_t, not int,
3794 where POSIX says socklen_t is required in portable programs.
3795 This fixes a porting bug on hosts like 64-bit HP-UX, where
3796 socklen_t is wider than int (Bug#8277).
3797 (Fmake_network_process, server_accept_connection):
3798 (wait_reading_process_output, read_process_output):
3801 * process.c: Rename or move locals to avoid shadowing.
3802 (list_processes_1, Fmake_network_process):
3803 (read_process_output_error_handler, exec_sentinel_error_handler):
3804 Rename or move locals.
3805 (Fmake_network_process): Define label "retry_connect" only if needed.
3806 (Fnetwork_interface_info): Fix pointer signedness.
3807 (process_send_signal): Add cast to avoid pointer signedness problem.
3808 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
3809 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
3811 Make tparam.h and terminfo.c consistent.
3812 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3813 Include tparam.h instead, since it declares them.
3814 * cm.h (PC): Remove extern decl; tparam.h now does this.
3815 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3816 * terminfo.c: Include tparam.h, to check interfaces.
3817 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3818 (tparam): Adjust signature to match interface in tparam.h;
3819 this removes some undefined behavior. Check that outstring and len
3820 are zero, which they always are with Emacs.
3821 * tparam.h (PC, BC, UP): New extern decls.
3823 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3824 (xftfont_open): Rename locals to avoid shadowing.
3826 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3827 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3828 (OTF_TAG_SYM): Omit macro if not needed.
3829 (ftfont_list): Remove unused local.
3830 (get_adstyle_property, ftfont_pattern_entity):
3831 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3832 Rename locals to avoid shadowing.
3834 * xfont.c (xfont_list_family): Mark var as initialized.
3836 * xml.c (make_dom): Now static.
3838 * composite.c (composition_compute_stop_pos): Rename local to
3840 (composition_reseat_it): Remove unused locals.
3841 (find_automatic_composition, composition_adjust_point): Likewise.
3842 (composition_update_it): Mark var as initialized.
3843 (find_automatic_composition): Mark vars as initialized,
3844 with a FIXME (Bug#8290).
3846 character.h: Rename locals to avoid shadowing.
3847 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3848 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3849 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3850 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3853 * textprop.c (property_change_between_p): Remove; unused.
3855 * intervals.c (interval_start_pos): Now static.
3857 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3859 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3860 Rename locals to avoid shadowing.
3862 * sound.c (wav_play, au_play, Fplay_sound_internal):
3863 Fix pointer signedness.
3864 (alsa_choose_format): Remove unused local var.
3865 (wav_play): Initialize a variable to 0, to prevent undefined
3866 behavior (Bug#8278).
3868 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3870 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3872 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3873 clobbering (Bug#8298).
3874 * sysdep.c (sys_subshell): Likewise.
3875 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
3877 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3878 This should get cleaned up, so that child_setup has the
3879 same signature on all platforms.
3881 * callproc.c (call_process_cleanup): Now static.
3882 (relocate_fd): Rename locals to avoid shadowing.
3884 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
3886 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3887 not to be necessary, and produces flickering.
3889 2011-03-20 Glenn Morris <rgm@gnu.org>
3891 * config.in: Remove file.
3893 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
3895 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3896 are now in src/globals.h.
3897 (syms_of_minibuf): Remove spurious & from previous change.
3899 2011-03-20 Leo <sdl.web@gmail.com>
3901 * minibuf.c (completing-read-function): New variable.
3902 (completing-read-default): Rename from completing-read.
3903 (completing-read): Call completing-read-function.
3905 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3907 * xfaces.c (Fx_load_color_file):
3908 Read color file from absolute filename (bug#8250).
3910 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3912 * makefile.w32-in: Update dependencies.
3914 2011-03-17 Eli Zaretskii <eliz@gnu.org>
3916 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3918 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3920 Fix more problems found by GCC 4.5.2's static checks.
3922 * process.c (make_serial_process_unwind, send_process_trap):
3923 (sigchld_handler): Now static.
3925 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3926 That way, the code declares only the vars that it needs.
3927 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3928 * s/cygwin.h (PTY_ITERATION): Likewise.
3929 * s/darwin.h (PTY_ITERATION): Likewise.
3930 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3932 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3933 * process.c (allocate_pty): Don't declare stb unless it's needed.
3935 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
3936 (CONSTANTLIM): Remove; unused.
3937 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3938 Define only if needed.
3940 * unexelf.c (unexec): Name an expression,
3941 to avoid gcc -Wbad-function-cast warning.
3942 Use a different way to cause a compilation error if anyone uses
3943 n rather than nn, a way that does not involve shadowing.
3944 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
3946 * deps.mk (unexalpha.o): Remove; unused.
3948 New file unexec.h, the (simple) interface for unexec (Bug#8267).
3949 * unexec.h: New file.
3950 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3951 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3953 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3954 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3955 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
3956 Change as necessary to match prototype in unexec.h.
3958 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3960 (back_comment, skip_chars): Mark vars as initialized.
3962 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3963 Rename locals to avoid shadowing.
3965 * lread.c (read1): Rewrite so as not to use empty "else".
3966 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
3968 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3970 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3971 warning when compiling print.c.
3973 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3974 instead of using an uninitialized var.
3975 (font_sort_entities): Mark var as initialized.
3977 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3979 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3980 pointers to constants.
3981 (font_parse_fcname): Remove unused vars.
3982 (font_delete_unmatched): Now static.
3983 (font_get_spec): Remove; unused.
3984 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3985 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3986 Rename or move locals to avoid shadowing.
3988 * fns.c (require_nesting_list, require_unwind): Now static.
3989 (Ffillarray): Rename locals to avoid shadowing.
3991 * floatfns.c (domain_error2): Define only if needed.
3992 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
3994 * alloc.c (mark_backtrace): Move decl from here ...
3995 * lisp.h: ... to here, so that it can be checked.
3997 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
3998 (Fdefvar): Rewrite so as not to use empty "else".
3999 (lisp_indirect_variable): Name an expression,
4000 to avoid gcc -Wbad-function-cast warning.
4001 (Fdefvar): Rename locals to avoid shadowing.
4003 * callint.c (quotify_arg, quotify_args): Now static.
4004 (Fcall_interactively): Rename locals to avoid shadowing.
4005 Use const pointer when appropriate.
4007 * lisp.h (get_system_name, get_operating_system_release):
4008 Move decls here, to check interfaces.
4009 * process.c (get_operating_system_release): Move decl to lisp.h.
4010 * xrdb.c (get_system_name): Likewise.
4011 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4012 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4013 some of which prompt warnings from gcc -Wbad-function-cast.
4014 (Fformat_time_string, Fencode_time, Finsert_char):
4015 (Ftranslate_region_internal, Fformat):
4016 Rename or remove local vars to avoid shadowing.
4017 (Ftranslate_region_internal): Mark var as initialized.
4019 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4022 * lisp.h (eassert): Check that the argument compiles, even if
4023 ENABLE_CHECKING is not defined.
4025 * data.c (Findirect_variable): Name an expression, to avoid
4026 gcc -Wbad-function-cast warning.
4027 (default_value, arithcompare, arith_driver, arith_error): Now static.
4028 (store_symval_forwarding): Rename local to avoid shadowing.
4029 (Fmake_variable_buffer_local, Fmake_local_variable):
4030 Mark variables as initialized.
4031 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4033 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4034 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4035 Rename locals to avoid shadowing.
4036 (mark_stack): Move local variables into the #ifdef region where
4038 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4039 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4041 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4042 (GC_STRING_CHARS): Remove; not used.
4043 (Fmemory_limit): Cast sbrk's returned value to char *.
4045 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4046 avoids undefined behavior in theory.
4048 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4050 Use functions, not macros, for up- and down-casing (Bug#8254).
4051 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4052 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4053 to use the following functions instead of these macros.
4054 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4055 EMACS_INT, since callers assume the returned value fits in int.
4056 (upcase1): Likewise, for UPCASE_TABLE.
4057 (uppercasep, lowercasep, upcase): New static inline functions.
4058 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4059 the race-condition problem in the old DOWNCASE.
4061 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4062 Rename locals to avoid shadowing.
4063 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4064 (regex_compile, re_search_2, re_match_2_internal):
4065 Remove unused local vars.
4066 (FREE_VAR): Rewrite so as not to use empty "else",
4067 which gcc can warn about.
4068 (regex_compile, re_match_2_internal): Mark locals as initialized.
4069 (RETALLOC_IF): Define only if needed.
4070 (WORDCHAR_P): Likewise. This one is never needed, but is used
4071 only in a comment talking about a compiler bug, so put inside
4072 the #if 0 of that comment.
4073 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4074 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4077 * search.c (boyer_moore): Rename locals to avoid shadowing.
4078 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4079 (PREV_CHAR_BOUNDARY): Likewise.
4081 * search.c (simple_search): Remove unused var.
4083 * dired.c (compile_pattern): Move decl from here ...
4084 * lisp.h: ... to here, so that it can be checked.
4085 (struct re_registers): New forward decl.
4087 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4089 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4091 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4092 Rename locals to avoid shadowing.
4093 (Fvertical_motion): Mark locals as initialized.
4095 * casefiddle.c (casify_object, casify_region): Now static.
4096 (casify_region): Mark local as initialized.
4098 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4100 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4101 New macros, so that the caller can use some names other than
4102 gcpro1, gcpro2, etc.
4103 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4105 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4106 argument, for consistency with GCPRO2_VAR, etc: it is now the
4107 prefix of the variable, not the variable itself. All uses
4109 * dired.c (directory_files_internal, file_name_completion):
4110 Rename locals to avoid shadowing.
4112 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4113 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4114 dired.c's scmp function, had undefined behavior.
4115 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4116 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4117 * buffer.h: ... to here, because these macros use current_buffer,
4118 and the new implementation with inline functions needs to have
4119 current_buffer in scope now, rather than later when the macros
4121 (downcase, upcase1): New static inline functions.
4122 (DOWNCASE, UPCASE1): Reimplement using these functions.
4123 This avoids undefined behavior in expressions like
4124 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4125 from race conditions in accessing the global variables
4126 case_temp1 and case_temp2.
4127 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4128 * lisp.h (case_temp1, case_temp2): Remove their decls.
4129 * character.h (ASCII_CHAR_P): Move from here ...
4130 * lisp.h: ... to here, so that the inline functions mentioned
4133 * dired.c (directory_files_internal_unwind): Now static.
4135 * fileio.c (file_name_as_directory, directory_file_name):
4136 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4138 (file_name_as_directory): Use const pointers when appropriate.
4139 (Fexpand_file_name): Likewise. In particular, newdir might
4140 point at constant storage, so make it a const pointer.
4141 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4142 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4144 (Fset_file_times, Finsert_file_contents, auto_save_error):
4145 Rename locals to avoid shadowing.
4147 * minibuf.c (choose_minibuf_frame_1): Now static.
4148 (Ftry_completion, Fall_completions): Rename or remove locals
4151 * marker.c (bytepos_to_charpos): Remove; unused.
4153 * lisp.h (verify_bytepos, count_markers): New decls,
4154 so that gcc does not warn that these functions aren't declared.
4156 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4157 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4158 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4159 (copy_text): Remove unused local var.
4161 * filelock.c (within_one_second): Now static.
4162 (lock_file_1): Rename local to avoid shadowing.
4164 * buffer.c (fix_overlays_before): Mark locals as initialized.
4165 (fix_start_end_in_overlays): Likewise. This function should be
4166 simplified by using pointers-to-pointers, but that's a different
4168 (switch_to_buffer_1): Now static.
4169 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4170 (report_overlay_modification): Rename locals to avoid shadowing.
4172 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4173 Fix pointer signedness issue.
4174 (sys_subshell): Mark local as volatile if checking for lint,
4175 to suppress a gcc -Wclobbered warning that does not seem to be right.
4176 (MAXPATHLEN): Define only if needed.
4178 * process.c (serial_open, serial_configure): Move decls from here ...
4179 * systty.h: ... to here, so that they can be checked.
4181 * fns.c (get_random, seed_random): Move extern decls from here ...
4182 * lisp.h: ... to here, so that they can be checked.
4184 * sysdep.c (reset_io): Now static.
4185 (wait_for_termination_signal): Remove; unused.
4187 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4188 (copy_keymap_item, append_key, push_text_char_description):
4190 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4191 (DENSE_TABLE_SIZE): Remove; unused.
4192 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4193 (describe_map_tree):
4194 Rename locals to avoid shadowing.
4196 * keyboard.c: Declare functions static if they are not used elsewhere.
4197 (echo_char, echo_dash, cmd_error, top_level_2):
4198 (poll_for_input, handle_async_input): Now static.
4199 (read_char, kbd_buffer_get_event, make_lispy_position):
4200 (make_lispy_event, make_lispy_movement, apply_modifiers):
4201 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4202 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4203 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4204 (read_key_sequence, read_char): Mark locals as initialized.
4205 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4207 * keyboard.h (make_ctrl_char): New decl.
4208 (mark_kboards): Move decl here ...
4209 * alloc.c (mark_kboards): ... from here.
4211 * lisp.h (force_auto_save_soon): New decl.
4213 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4214 (DEFINE_DUMMY_FUNCTION): New macro.
4215 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4217 (main): Add casts to avoid warnings
4218 if GCC considers string literals to be constants.
4220 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4222 * dbusbind.c: Pointer signedness fixes.
4223 (xd_signature, xd_append_arg, xd_initialize):
4224 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4225 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4226 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4227 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4229 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4230 if GCC considers string literals to be constants.
4231 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4233 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4235 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4236 (print_preprocess, print_object): New macro to fix last change.
4238 * print.c (print_preprocess): Don't forget font objects.
4240 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
4242 * emacs.c (USAGE3): Doc fixes.
4244 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4246 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4249 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
4251 * lisp.h (VWindow_system, Qfile_name_history):
4252 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4253 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4254 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4256 * w32select.c: Don't #include "keyboard.h".
4257 (run_protected): Add extern declaration for waiting_for_input.
4259 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4260 * w32console.c (detect_input_pending, read_input_pending)
4261 (encode_terminal_code):
4262 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4263 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4264 (w32_system_caret_y, Qfile_name_history):
4265 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4266 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4267 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4268 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4269 * w32proc.c (Qlocal, report_file_error):
4270 * w32term.c (Vwindow_system, updating_frame):
4271 * w32uniscribe.c (initialized, uniscribe_font_driver):
4272 Remove unneeded extern declarations.
4274 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
4276 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
4278 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
4280 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4281 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4282 These macros can no longer be used for assignment.
4284 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4285 Assign struct members directly, instead of using BUF_BEGV etc.
4286 (record_buffer_markers, fetch_buffer_markers): New functions for
4287 recording and fetching special buffer markers.
4288 (set_buffer_internal_1, set_buffer_temp): Use them.
4290 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4292 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4294 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4295 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4297 * xdisp.c (hscroll_window_tree):
4298 (reconsider_clip_changes): Use PT instead of BUF_PT.
4300 2011-03-13 Eli Zaretskii <eliz@gnu.org>
4302 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4303 $(EMACS_ROOT)/lib/intprops.h.
4305 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4307 Fix more problems found by GCC 4.5.2's static checks.
4309 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4310 to unsigned char * to avoid compiler diagnostic.
4311 (xg_free_frame_widgets): Make it clear that a local variable is
4312 needed only if USE_GTK_TOOLTIP.
4313 (gdk_window_get_screen): Make it clear that this macro is needed
4314 only if USE_GTK_TOOLTIP.
4315 (int_gtk_range_get_value): New function, which avoids a diagnostic
4316 from gcc -Wbad-function-cast.
4317 (xg_set_toolkit_scroll_bar_thumb): Use it.
4318 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4319 diagnostic from gcc -Wbad-function-cast.
4320 (get_utf8_string, xg_get_file_with_chooser):
4321 Rename locals to avoid shadowing.
4322 (create_dialog): Move locals to avoid shadowing.
4324 * xgselect.c (xg_select): Remove unused var.
4326 * image.c (four_corners_best): Mark locals as initialized.
4327 (gif_load): Initialize transparent_p to zero (Bug#8238).
4328 Mark another local as initialized.
4329 (my_png_error, my_error_exit): Mark with NO_RETURN.
4331 * image.c (clear_image_cache): Now static.
4332 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
4333 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
4334 (x_edge_detection): Remove unnecessary cast that
4335 gcc -Wbad-function-cast diagnoses.
4336 (gif_load): Fix pointer signedness.
4337 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4338 (jpeg_load, gif_load): Rename locals to avoid shadowing.
4340 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
4342 Improve quality of tests for time stamp overflow.
4343 For example, without this patch (encode-time 0 0 0 1 1
4344 1152921504606846976) returns the obviously-bogus value (-948597
4345 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4346 reports time overflow. See
4347 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
4348 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4349 * editfns.c: Include limits.h and intprops.h.
4350 (TIME_T_MIN, TIME_T_MAX): New macros.
4351 (time_overflow): Move earlier, to before first use.
4352 (hi_time, lo_time): New functions, for an accurate test for
4354 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4355 (Fget_internal_run_time): Don't assume time_t fits in int.
4356 (make_time): Use list2 instead of Fcons twice.
4357 (Fdecode_time): More accurate test for out-of-range times.
4358 (check_tm_member): New function.
4359 (Fencode_time): Use it, to test for out-of-range times.
4360 (lisp_time_argument): Don't rely on undefined left-shift and
4361 right-shift behavior when checking for time stamp overflow.
4363 * editfns.c (time_overflow): New function, refactoring common code.
4364 (Fformat_time_string, Fdecode_time, Fencode_time):
4365 (Fcurrent_time_string): Use it.
4367 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4368 * dired.c (make_time): Move to ...
4369 * editfns.c (make_time): ... here.
4370 * systime.h: Note the move.
4372 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4374 * fringe.c (update_window_fringes): Remove unused variables.
4376 * unexmacosx.c (copy_data_segment): Also copy __got section.
4379 2011-03-12 Eli Zaretskii <eliz@gnu.org>
4381 * termcap.c [MSDOS]: Include "msdos.h".
4382 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4383 Constify `char *' arguments and their references according to
4384 prototypes in tparam.h.
4386 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
4388 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4389 Adapt all references accordingly.
4391 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4393 2011-03-11 Tom Tromey <tromey@redhat.com>
4395 * buffer.c (syms_of_buffer): Remove obsolete comment.
4397 2011-03-11 Eli Zaretskii <eliz@gnu.org>
4399 * termhooks.h (encode_terminal_code): Declare prototype.
4401 * msdos.c (encode_terminal_code): Don't declare prototype.
4403 * term.c (encode_terminal_code): Now external again, used by
4404 w32console.c and msdos.c.
4406 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4407 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
4409 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
4411 Fix some minor problems found by GCC 4.5.2's static checks.
4413 * fringe.c (update_window_fringes): Mark locals as initialized
4415 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
4417 * alloc.c (mark_fringe_data): Move decl from here ...
4418 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4419 to check its interface.
4420 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4422 * fontset.c (free_realized_fontset): Now static.
4423 (Fset_fontset_font): Rename local to avoid shadowing.
4424 (fontset_font): Mark local as initialized.
4425 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
4427 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4429 * xselect.c (x_disown_buffer_selections): Remove; not used.
4430 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
4431 (x_own_selection, Fx_disown_selection_internal): Rename locals
4433 (x_handle_dnd_message): Remove local to avoid shadowing.
4435 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4436 so that the caller can use some name other than gcpro1.
4437 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
4438 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4439 (Fx_backspace_delete_keys_p):
4440 Use them to avoid shadowing, and rename vars to avoid shadowing.
4441 (x_decode_color, x_set_name, x_window): Now static.
4442 (Fx_create_frame): Add braces to silence GCC warning.
4443 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
4444 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4445 Remove unused locals.
4446 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4447 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4448 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4451 * xterm.h (x_mouse_leave): New decl.
4453 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4454 Remove unused functions.
4455 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4456 (x_calc_absolute_position): Now static.
4457 (XTread_socket): Don't define label "out" unless it's used.
4458 Don't declare local "event" unless it's used.
4459 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4460 unless they are used.
4461 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4462 (x_fatal_error_signal): Remove; not used.
4463 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4464 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4465 (x_error_catcher, x_connection_closed, x_error_handler):
4466 (x_error_quitter, xembed_send_message, x_iconify_frame):
4467 (my_log_handler): Rename locals to avoid shadowing.
4468 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
4469 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
4471 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4472 Rename or move locals to avoid shadowing.
4473 (tty_defined_color, merge_face_heights): Now static.
4474 (free_realized_faces_for_fontset): Remove; not used.
4475 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4476 does not deduce is never used uninitialized.
4477 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4478 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
4480 * terminal.c (store_terminal_param): Now static.
4482 * xmenu.c (menu_highlight_callback): Now static.
4483 (set_frame_menubar): Remove unused local.
4484 (xmenu_show): Rename parameter to avoid shadowing.
4485 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4486 since they might point to immutable storage.
4487 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4488 since it's unused otherwise.
4490 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
4491 Add a FIXME, since the code still doesn't look right. (Bug#8215)
4492 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4493 avoids a gcc -Wuninitialized diagnostic.
4494 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
4495 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4496 does not deduce are never used uninitialized.
4498 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4500 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4501 * window.c (window_loop, size_window):
4502 (run_window_configuration_change_hook, enlarge_window): Likewise.
4504 * window.c (display_buffer): Now static.
4505 (size_window): Mark variables that gcc -Wuninitialized
4506 does not deduce are never used uninitialized.
4507 * window.h (check_all_windows): New decl, to forestall
4508 gcc -Wmissing-prototypes diagnostic.
4509 * dispextern.h (bidi_dump_cached_states): Likewise.
4511 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4513 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
4515 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4516 and to avoid gcc -Wuninitialized warning.
4517 (load_charset_map): Mark variables that gcc -Wuninitialized
4518 does not deduce are never used uninitialized.
4519 (load_charset): Abort instead of using uninitialized var (Bug#8229).
4521 * coding.c (coding_set_source, coding_set_destination):
4522 Use "else { /* comment */ }" rather than "else /* comment */;"
4523 for clarity, and to avoid gcc -Wempty-body warning.
4524 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4525 a block, when the outer 'i' will do.
4526 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4527 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4528 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4529 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4530 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4531 Rename locals to avoid shadowing.
4532 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
4533 * coding.c (emacs_mule_char, encode_invocation_designation):
4534 Now static, since they're not used elsewhere.
4535 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
4536 (decode_coding_object, encode_coding_object, detect_coding_system):
4537 (decode_coding_emacs_mule): Mark variables that gcc
4538 -Wuninitialized does not deduce are never used uninitialized.
4539 (detect_coding_iso_2022): Initialize a local variable that might
4540 be used uninitialized. Leave a FIXME because it's not clear that
4541 this initialization is needed. (Bug#8211)
4542 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4543 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4544 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4545 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4546 Remove unused macros.
4548 * category.c (hash_get_category_set): Remove unused local var.
4549 (copy_category_table): Now static, since it's not used elsewhere.
4550 * character.c (string_count_byte8): Likewise.
4552 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4553 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4555 * chartab.c (copy_sub_char_table): Now static, since it's not used
4557 (sub_char_table_ref_and_range, char_table_ref_and_range):
4558 Rename locals to avoid shadowing.
4559 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
4561 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
4562 (BIDI_BOB): Remove unused macro.
4564 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4565 deduce are never used uninitialized.
4566 * term.c (encode_terminal_code): Likewise.
4568 * term.c (encode_terminal_code): Now static. Remove unused local.
4570 * tparam.h: New file.
4571 * term.c, tparam.h: Include it.
4572 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4573 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4574 Move these decls to tparam.h, and make them agree with what
4575 is actually in tparam.c. The previous trick of using incompatible
4576 decls in different modules does not conform to the C standard.
4577 All callers of tparam changed to use tparam's actual API.
4578 * tparam.c (tparam1, tparam, tgoto):
4579 Use const pointers where appropriate.
4581 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4582 * cm.h (struct cm): Likewise.
4583 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4584 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4585 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4586 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4587 (turn_on_face, init_tty): Likewise.
4588 * termchar.h (struct tty_display_info): Likewise.
4590 * term.c (term_mouse_position): Rename local to avoid shadowing.
4592 * alloc.c (mark_ttys): Move decl from here ...
4593 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4595 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4597 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4599 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
4601 * search.c (compile_pattern_1): Remove argument regp, unused since
4602 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4603 (compile_pattern): Don't pass it.
4605 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4607 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4608 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4610 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4612 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4614 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4615 gdk_window_get_screen, gdk_window_get_geometry,
4616 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4617 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4618 (xg_get_pixbuf_from_pixmap): New function.
4619 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4620 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4621 Call xg_get_pixbuf_from_pixmap instead of
4622 gdk_pixbuf_get_from_drawable.
4623 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4624 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4625 (xg_check_special_colors): Use GtkStyleContext and its functions
4627 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4628 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4629 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
4630 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4631 Call gtk_widget_get_preferred_size.
4632 (xg_frame_resized): gdk_window_get_geometry only takes 5
4634 (xg_win_to_widget, xg_event_is_for_menubar):
4635 Call gdk_x11_window_lookup_for_display.
4636 (xg_set_widget_bg): New function.
4637 (delete_cb): New function.
4638 (xg_create_frame_widgets): Connect delete-event to delete_cb.
4639 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4640 (xg_set_background_color): Call xg_set_widget_bg.
4641 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4642 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4643 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4644 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4646 (update_frame_tool_bar): Call gtk_widget_hide.
4647 (xg_initialize): Use GDK_KEY_g.
4649 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4651 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4653 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4654 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4655 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4657 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
4659 * w32xfns.c (select_palette): Check success of RealizePalette against
4660 GDI_ERROR, not zero.
4662 See ChangeLog.11 for earlier changes.
4668 Copyright (C) 2011 Free Software Foundation, Inc.
4670 This file is part of GNU Emacs.
4672 GNU Emacs is free software: you can redistribute it and/or modify
4673 it under the terms of the GNU General Public License as published by
4674 the Free Software Foundation, either version 3 of the License, or
4675 (at your option) any later version.
4677 GNU Emacs is distributed in the hope that it will be useful,
4678 but WITHOUT ANY WARRANTY; without even the implied warranty of
4679 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4680 GNU General Public License for more details.
4682 You should have received a copy of the GNU General Public License
4683 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.