* src/sysdep.c (list_system_processes): Support Darwin.
[bpt/emacs.git] / src / ChangeLog
1 2012-04-22 Leo Liu <sdl.web@gmail.com>
2
3 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4
5 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
6
7 * sysdep.c [__FreeBSD__]: Minor cleanups.
8 (list_system_processes, system_process_attributes) [__FreeBSD__]:
9 Use Emacs indenting style more consistently. Avoid some casts.
10 Use 'double' consistently rather than mixing 'float' and 'double'.
11
12 2012-04-21 Eduard Wiebe <usenet@pusto.de>
13
14 * sysdep.c (list_system_processes, system_process_attributes): Add
15 implementation for FreeBSD (Bug#5243).
16
17 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
18
19 * lisp.mk (lisp): Update.
20
21 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
22
23 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
24 It is never used otherwise.
25
26 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
27
28 * print.c (print_preprocess): Only check print_depth if print-circle
29 is nil.
30 (print_object): Check for cycles even when print-circle is nil and
31 print-gensym is t, but only check print_depth if print-circle is nil.
32
33 2012-04-20 Chong Yidong <cyd@gnu.org>
34
35 * process.c (wait_reading_process_output): If EIO occurs on a pty,
36 set the status to "failed" and ensure that sentinel is run.
37
38 2012-04-20 Glenn Morris <rgm@gnu.org>
39
40 * process.c (Fset_process_inherit_coding_system_flag)
41 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
42 (Fmake_network_process, Fmake_serial_process): Doc fix.
43
44 2012-04-20 Eli Zaretskii <eliz@gnu.org>
45
46 * xdisp.c (string_buffer_position_lim): Limit starting position to
47 BEGV.
48 (set_cursor_from_row): If called for a mode-line or header-line
49 row, return zero immediately.
50 (try_cursor_movement): If inside continuation line, don't back up
51 farther than the first row after the header line, if any.
52 Don't consider the header-line row as "partially visible", even if
53 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
54
55 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
56
57 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
58 (bug#11238).
59
60 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
61 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
62
63 configure: new option --enable-gcc-warnings (Bug#11207)
64 * Makefile.in (C_WARNINGS_SWITCH): Remove.
65 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
66 (ALL_CFLAGS): Use new macros rather than old.
67 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
68 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
69 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
70 -Wunused-result, -Wunused-variable. This should go away once
71 the Emacs and Gnulib regex code is merged.
72 (xmalloc, xrealloc): Now static.
73
74 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
75
76 * dired.c (Fsystem_groups): Remove unused local.
77
78 2012-04-17 Glenn Morris <rgm@gnu.org>
79
80 * dired.c (Fsystem_users): Doc fix.
81
82 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
83
84 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
85 (syms_of_dired): Add them.
86
87 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
88
89 Fix minor alloc.c problems found by static checking.
90 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
91 New extern decls, to avoid calling undeclared functions.
92 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
93 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
94 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
95 (NEED_MEM_INSERT): New macro.
96 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
97 Remove one incorrect comment and fix another.
98
99 Fix minor ralloc.c problems found by static checking.
100 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
101 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
102 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
103 (r_alloc_sbrk): Now static.
104
105 Improve ralloc.c interface checking.
106 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
107 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
108 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
109 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
110 [REL_ALLOC]: ... to here, to check interface.
111 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
112 Remove decls. This fixes an "It stinks!".
113
114 * alloc.c (which_symbols): Fix alignment issue / type clash.
115
116 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
117
118 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
119 (struct Lisp_Misc_Any): Likewise.
120 (struct Lisp_Free): Likewise.
121 * alloc.c (union aligned_Lisp_Symbol): Define.
122 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
123 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
124 (union aligned_Lisp_Misc): Define.
125 (MARKER_BLOCK_SIZE, struct marker_block): Use union
126 aligned_Lisp_Misc instead of union Lisp_Misc.
127 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
128
129 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
130
131 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
132 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
133 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
134 * s/netbsd.h, s/sol2-6.h:
135 Remove definition of GC_MARK_STACK, since the default now works.
136 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
137 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
138 no longer the default.
139 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
140
141 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
142
143 * lread.c (lisp_file_lexically_bound_p):
144 Fix hang at ";-*-\n" (bug#11238).
145
146 2012-04-14 Eli Zaretskii <eliz@gnu.org>
147
148 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
149 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
150
151 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
152
153 * nsterm.m (constrainFrameRect): Always constrain when there is only
154 one screen (Bug#10962).
155
156 2012-04-13 Ken Brown <kbrown@cornell.edu>
157
158 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
159
160 2012-04-13 Reuben Thomas <rrt@sc3d.org>
161
162 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
163
164 2012-04-11 Daniel Colascione <dancol@dancol.org>
165
166 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
167 against is gone. It's better to use vfork now so that when Cygwin
168 gains a new, working vfork, we use it automatically (bug#10398).
169
170 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
171
172 * window.c (save_window_save): Obey window-point-insertion-type.
173
174 2012-04-11 Glenn Morris <rgm@gnu.org>
175
176 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
177
178 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
179
180 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
181
182 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
183
184 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
185 (force_quit_count): New var.
186 (handle_interrupt): Use it.
187
188 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
189
190 * w32.c (w32_delayed_load): Record the full path of the library
191 being loaded (bug#10424).
192
193 2012-04-09 Glenn Morris <rgm@gnu.org>
194
195 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
196 not just in the obarray, before snarfing them. (Bug#11036)
197
198 * Makefile.in ($(leimdir)/leim-list.el):
199 Pass EMACS rather than BUILT_EMACS.
200
201 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
202
203 * process.c (make_process):
204 * process.h: Add integer `gnutls_handshakes_tried' member to
205 process struct.
206
207 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
208 Add convenience `GNUTLS_LOG2i' macro.
209
210 * gnutls.c (gnutls_log_function2i): Convenience log function.
211 (emacs_gnutls_read): Use new log functions,
212 `gnutls_handshakes_tried' process member, and
213 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
214 attempts per process (connection).
215
216 2012-04-09 Chong Yidong <cyd@gnu.org>
217
218 * eval.c (Fuser_variable_p, user_variable_p_eh)
219 (lisp_indirect_variable): Functions deleted.
220 (Fdefvar): Caller changed.
221
222 * callint.c (Finteractive, Fcall_interactively):
223 * minibuf.c (Fread_variable): Callers changed.
224
225 2012-04-09 Eli Zaretskii <eliz@gnu.org>
226
227 * xdisp.c (set_cursor_from_row): If the display string appears in
228 the buffer at position that is closer to point than the position
229 after the display string, display the cursor on the first glyph of
230 the display string. Fixes cursor display when a 'display' text
231 property immediately follows invisible text. (Bug#11094)
232
233 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
234
235 composite.c: use 'double' consistently
236 * composite.c (get_composition_id): Use 'double' consistently
237 instead of converting 'float' to 'double' and vice versa; this is
238 easier to understand and avoids a GCC warning.
239
240 2012-04-09 Glenn Morris <rgm@gnu.org>
241
242 * Makefile.in: Generate leim-list with bootstrap-emacs, in
243 preparation for dumping it with emacs. (Bug#4789)
244 (leimdir): New variable.
245 ($(leimdir)/leim-list.el): New rule.
246 (emacs$(EXEEXT)): Depend on leim-list.el.
247
248 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
249 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
250 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
251
252 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
253
254 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
255 proper alignment.
256
257 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
258
259 * xml.c (init_libxml2_functions) [WINDOWSNT]:
260 Remove unused local variable.
261
262 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
263
264 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
265 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
266 (mark_memory): Mark Lisp_Objects only if pointers might hide in
267 objects, as mark_maybe_pointer will catch them otherwise.
268 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
269 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
270
271 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
272
273 Fix typo that broke non-Windows builds.
274 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
275
276 2012-04-07 Eli Zaretskii <eliz@gnu.org>
277
278 Support building on MS-Windows with libxml2.
279
280 * makefile.w32-in (OBJ2): Add xml.$(O).
281 (GLOBAL_SOURCES): Add xml.c.
282 ($(BLD)/xml.$(O)): New dependency list.
283
284 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
285 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
286 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
287 [!WINDOWSNT]: New macros.
288 (init_libxml2_functions, libxml2_loaded_p): New functions.
289 (parse_region): Call fn_xmlCheckVersion instead of using the macro
290 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
291 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
292 Calls xmlCleanupParser only if libxml2 was loaded (or statically
293 linked in).
294 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
295 Call init_libxml2_functions before calling libxml2 functions.
296 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
297
298 * emacs.c: Don't include libxml/parser.h.
299 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
300 xmlCleanupParser directly.
301
302 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
303
304 2012-04-07 Eli Zaretskii <eliz@gnu.org>
305
306 * indent.c (Fvertical_motion): If there is a display string at
307 point, use it.vpos to compute how many lines to backtrack after
308 move_it_to point. (Bug#11133)
309
310 2012-04-06 Eli Zaretskii <eliz@gnu.org>
311
312 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
313 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
314 about subtle differences between FETCH_CHAR* and STRING_CHAR*
315 macros related to unification of CJK characters. For the details,
316 see the discussion following the message here:
317 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
318
319 2012-04-04 Chong Yidong <cyd@gnu.org>
320
321 * keyboard.c (Vdelayed_warnings_list): Doc fix.
322
323 2012-04-01 Eli Zaretskii <eliz@gnu.org>
324
325 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
326 instead of alloca. (Bug#11138)
327
328 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
329
330 * w32menu.c (is_simple_dialog): Properly check lisp types.
331 (Bug#11141)
332
333 2012-03-31 Eli Zaretskii <eliz@gnu.org>
334
335 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
336 position we get to after a call to move_it_to fails the
337 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
338 only if we wind up in a string from display property. (Bug#11063)
339
340 * window.c (Fdelete_other_windows_internal): Invalidate the row
341 and column information about mouse highlight, so that redisplay
342 restores it after reallocating the glyph matrices. (Bug#7464)
343
344 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
345 string comes from a `display' text property, use the buffer
346 position of that property as if we actually saw that position in
347 the row's glyphs.
348 (move_it_by_lines): Remove the assertion that
349 "it->current_x == 0 && it->hpos == 0" which can be legitimately
350 violated when there's a before-string at the beginning of a line.
351 (Bug#11063)
352
353 2012-03-30 Eli Zaretskii <eliz@gnu.org>
354
355 * xdisp.c (append_space_for_newline): If the default face was
356 remapped, use the remapped face for the appended newline.
357 (extend_face_to_end_of_line): Use the remapped default face for
358 extending the face to the end of the line.
359 (display_line): Call extend_face_to_end_of_line when the default
360 face was remapped. (Bug#11068)
361
362 2012-03-29 Eli Zaretskii <eliz@gnu.org>
363
364 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
365
366 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
367
368 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
369
370 2012-03-27 Glenn Morris <rgm@gnu.org>
371
372 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
373 Doc fixes.
374
375 2012-03-26 Kenichi Handa <handa@m17n.org>
376
377 * dispextern.h (struct glyph): Fix previous change. Change the
378 bit length of glyphless.ch to 25 (Bug#11082).
379
380 2012-03-26 Chong Yidong <cyd@gnu.org>
381
382 * keyboard.c (Vselection_inhibit_update_commands): New variable.
383 (command_loop_1): Use it; inhibit selection update for
384 handle-select-window too (Bug#8996).
385
386 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
387
388 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
389
390 2012-03-25 Kenichi Handa <handa@m17n.org>
391
392 * dispextern.h (struct glyph): Change the bit length of
393 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
394
395 2012-03-24 Eli Zaretskii <eliz@gnu.org>
396
397 * s/ms-w32.h (tzname): Include time.h before redirecting to
398 _tzname. Fixes the MSVC build. (Bug#9960)
399
400 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
401
402 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
403 characters.
404
405 * xterm.c (XTread_socket): Only modify handling_signal if
406 !SYNC_INPUT. (Bug#11080)
407
408 2012-03-23 Eli Zaretskii <eliz@gnu.org>
409
410 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
411 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
412 when fetching a multibyte character consumes more bytes than
413 CHAR_BYTES returns, due to unification of CJK characters in
414 string_char. (Bug#11073)
415
416 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
417
418 * process.c (wait_reading_process_output): Handle pty disconnect
419 by refraining from sending oneself a SIGCHLD (bug#10933).
420
421 2012-03-22 Chong Yidong <cyd@gnu.org>
422
423 * dispextern.h (struct it): New member string_from_prefix_prop_p.
424
425 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
426 Mark string as coming from a prefix property.
427 (handle_face_prop): Use default face for prefix strings (Bug#4281).
428 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
429
430 2012-03-21 Chong Yidong <cyd@gnu.org>
431
432 * xfaces.c (Vface_remapping_alist): Doc fix.
433
434 2012-03-20 Eli Zaretskii <eliz@gnu.org>
435
436 * w32proc.c (Fw32_set_console_codepage)
437 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
438 Doc fixes.
439
440 2012-03-20 Chong Yidong <cyd@gnu.org>
441
442 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
443 to reflect default non-nil value of redisplay-dont-pause.
444
445 2012-03-19 Kenichi Handa <handa@m17n.org>
446
447 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
448 it fit in a valid range (Bug#11003).
449
450 2012-03-18 Eli Zaretskii <eliz@gnu.org>
451
452 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
453 that is not from display property, accept the row as a "cursor
454 row" if one of the string's character has a non-nil `cursor'
455 property. Fixes cursor positioning when there are newlines in
456 overlay strings, e.g. in icomplete.el. (Bug#11035)
457
458 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
459
460 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
461
462 2012-03-12 Chong Yidong <cyd@gnu.org>
463
464 * eval.c (inhibit_lisp_code): Rename from
465 inhibit_window_configuration_change_hook; move from window.c.
466
467 * xfns.c (unwind_create_frame_1, Fx_create_frame):
468 * window.c (run_window_configuration_change_hook)
469 (syms_of_window): Callers changed.
470
471 2012-03-11 Chong Yidong <cyd@gnu.org>
472
473 * keymap.c (Fkey_description): Doc fix (Bug#9700).
474
475 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
476
477 2012-03-10 Chong Yidong <cyd@gnu.org>
478
479 * frame.c (other_visible_frames): Don't assume the selected frame
480 is visible (Bug#10955).
481
482 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
483
484 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
485
486 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
487
488 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
489 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
490 zero (Bug#10954).
491
492 2012-03-03 Glenn Morris <rgm@gnu.org>
493
494 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
495
496 2012-03-02 Eli Zaretskii <eliz@gnu.org>
497
498 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
499 position past the first glyph_row that ends at ZV. (Bug#10902)
500 (redisplay_window, next_element_from_string): Fix typos in
501 comments.
502 (redisplay_window): Pass to move_it_vertically the margin in
503 pixels, not in screen lines.
504
505 2012-03-02 Glenn Morris <rgm@gnu.org>
506
507 * buffer.c (buffer-list-update-hook): Doc fix.
508
509 2012-02-29 Eli Zaretskii <eliz@gnu.org>
510
511 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
512 push_it before setting up the iterator for the first overlay
513 string, even if we have an empty string loaded.
514 (next_overlay_string): If there's an empty string on the iterator
515 stack, pop the stack. (Bug#10903)
516
517 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
518
519 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
520 Suggested by Stefan Monnier in
521 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
522 * alloc.c (widen_to_Lisp_Object): New static function.
523 (mark_memory): Also mark Lisp_Objects by fetching pointer words
524 and widening them to Lisp_Objects. This would work even if
525 USE_LSB_TAG is defined and wide integers are used, which might
526 happen in a future version of Emacs.
527
528 2012-02-25 Chong Yidong <cyd@gnu.org>
529
530 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
531 Doc fix.
532
533 * xselect.c (Fx_selection_exists_p): Doc fix.
534 (x_clipboard_manager_save_all): Print an informative message
535 before saving to clipboard manager.
536
537 2012-02-24 Chong Yidong <cyd@gnu.org>
538
539 * keyboard.c (process_special_events): Handle all X selection
540 requests in kbd_buffer, not just the next one (Bug#8869).
541
542 2012-02-23 Chong Yidong <cyd@gnu.org>
543
544 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
545 call when setting menu-bar-lines and tool-bar-lines parameters.
546 (unwind_create_frame_1): New helper function.
547
548 * window.c (inhibit_window_configuration_change_hook): New var.
549 (run_window_configuration_change_hook): Obey it.
550 (syms_of_window): Initialize it.
551
552 2012-02-22 Chong Yidong <cyd@gnu.org>
553
554 * xterm.c (x_draw_image_relief): Add missing type check for
555 Vtool_bar_button_margin (Bug#10743).
556
557 2012-02-21 Chong Yidong <cyd@gnu.org>
558
559 * fileio.c (Vfile_name_handler_alist): Doc fix.
560
561 * buffer.c (Fget_file_buffer): Protect against invalid file
562 handler return value.
563
564 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
565
566 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
567 when computing $valmask.
568
569 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
570 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
571 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
572 It's useless in that case, and it can cause problems on hosts
573 that allocate halves of EMACS_INT values separately.
574 Reported by Dan Horák. Diagnosed by Andreas Schwab in
575 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
576 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
577 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
578 it avoids undefined behavior on hosts where shifting right by more
579 than the word width has undefined behavior.
580
581 2012-02-19 Chong Yidong <cyd@gnu.org>
582
583 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
584 (Funhandled_file_name_directory, Ffile_name_as_directory)
585 (Fdirectory_file_name, Fexpand_file_name)
586 (Fsubstitute_in_file_name): Protect against invalid file handler
587 return values (Bug#10845).
588
589 2012-02-18 Eli Zaretskii <eliz@gnu.org>
590
591 * .gdbinit (pitx): Fix incorrect references to fields of the
592 iterator stack.
593
594 2012-02-17 Chong Yidong <cyd@gnu.org>
595
596 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
597
598 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
599
600 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
601 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
602
603 2012-02-15 Chong Yidong <cyd@gnu.org>
604
605 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
606 marked as special. Also, starting docstrings with * is obsolete.
607
608 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
609
610 * gnutls.c (emacs_gnutls_write): Fix last change.
611
612 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
613
614 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
615 send_process.
616
617 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
618
619 * keymap.c (Fsingle_key_description): Handle char ranges.
620
621 2012-02-12 Chong Yidong <cyd@gnu.org>
622
623 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
624 as that creates a dangerous corner case.
625
626 * window.c (Fdelete_window_internal): Invalidate the mouse
627 highlight (Bug#9904).
628
629 2012-02-12 Glenn Morris <rgm@gnu.org>
630
631 * xselect.c (Fx_own_selection_internal)
632 (Fx_get_selection_internal, Fx_disown_selection_internal)
633 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
634 * nsselect.m (Fx_own_selection_internal)
635 (Fx_disown_selection_internal, Fx_selection_exists_p)
636 (Fx_selection_owner_p, Fx_get_selection_internal):
637 Sync docs and argument specs with the xselect.c versions.
638
639 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
640
641 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
642
643 2012-02-11 Eli Zaretskii <eliz@gnu.org>
644
645 * w32select.c (Fx_selection_exists_p): Sync doc string and
646 argument list with xselect.c. (Bug#10783)
647
648 * w16select.c (Fx_selection_exists_p): Sync doc string and
649 argument list with xselect.c. (Bug#10783)
650
651 2012-02-10 Glenn Morris <rgm@gnu.org>
652
653 * fns.c (Fsecure_hash): Doc fix.
654
655 2012-02-09 Kenichi Handa <handa@m17n.org>
656
657 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
658
659 2012-02-07 Chong Yidong <cyd@gnu.org>
660
661 * buffer.c (Fbuffer_local_variables)
662 (buffer_lisp_local_variables): Handle unbound vars correctly;
663 don't let Qunbound leak into Lisp.
664
665 2012-02-07 Glenn Morris <rgm@gnu.org>
666
667 * image.c (Fimagemagick_types): Doc fix.
668
669 * image.c (imagemagick-render-type): Change it from a lisp object
670 to an integer. Move the doc here from the lisp manual.
671 Treat all values not equal to 0 the same.
672
673 2012-02-06 Chong Yidong <cyd@gnu.org>
674
675 * doc.c (store_function_docstring): Avoid applying docstring of
676 alias to base function (Bug#2603).
677
678 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
679
680 * .gdbinit (pp1, pv1): Remove redundant defines.
681 (pr): Use pp.
682
683 2012-02-04 Chong Yidong <cyd@gnu.org>
684
685 * nsterm.m: Declare a global (Bug#10694).
686
687 2012-02-04 Eli Zaretskii <eliz@gnu.org>
688
689 * w32.c (get_emacs_configuration_options):
690 Include --enable-checking, if specified, in the return value.
691
692 2012-02-04 Martin Rudalics <rudalics@gmx.at>
693
694 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
695 after rounding frame sizes. (Bug#9723)
696
697 2012-02-04 Eli Zaretskii <eliz@gnu.org>
698
699 * keyboard.c (adjust_point_for_property): Don't position point
700 before BEGV. (Bug#10696)
701
702 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
703
704 Handle overflow when computing char display width (Bug#9496).
705 * character.c (char_width): Return EMACS_INT, not int.
706 (char_width, c_string_width): Check for overflow when
707 computing the width; this is possible now that individual
708 characters can have unbounded width. Problem introduced
709 by merge from Emacs 23 on 2012-01-19.
710
711 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
712
713 * dbusbind.c (Fdbus_register_method): Mention the return value
714 :ignore in the docstring.
715
716 2012-02-02 Glenn Morris <rgm@gnu.org>
717
718 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
719
720 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
721 Unconditionally set to t. (Bug#10673)
722 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
723 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
724 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
725
726 2012-02-02 Kenichi Handa <handa@m17n.org>
727
728 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
729 0, do not call append_composite_glyph.
730
731 2012-02-02 Kenichi Handa <handa@m17n.org>
732
733 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
734 NULL (Bug#6988).
735 (x_produce_glyphs): If the component of a composition is a null
736 string, set it->pixel_width to 1 to avoid zero-width glyph.
737
738 2012-02-01 Eli Zaretskii <eliz@gnu.org>
739
740 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
741 first 2 arguments are identical. This makes inserting large
742 output from a subprocess an order of magnitude faster on
743 MS-Windows, where all sbrk'ed memory is always contiguous.
744
745 2012-01-31 Glenn Morris <rgm@gnu.org>
746
747 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
748 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
749 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
750
751 2012-01-29 Glenn Morris <rgm@gnu.org>
752
753 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
754
755 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
756
757 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
758
759 2012-01-28 Chong Yidong <cyd@gnu.org>
760
761 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
762
763 2012-01-26 Chong Yidong <cyd@gnu.org>
764
765 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
766
767 * search.c (Fsearch_forward, Fsearch_backward): Document negative
768 repeat counts (Bug#10507).
769
770 2012-01-26 Glenn Morris <rgm@gnu.org>
771
772 * lread.c (syms_of_lread): Doc fix.
773
774 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
775
776 * coding.c (encode_designation_at_bol): Change return value to
777 EMACS_INT.
778
779 2012-01-25 Chong Yidong <cyd@gnu.org>
780
781 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
782
783 2012-01-21 Chong Yidong <cyd@gnu.org>
784
785 * floatfns.c (Fcopysign): Make the second argument non-optional,
786 since nil is not allowed anyway.
787
788 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
789
790 * process.c (read_process_output): Use p instead of XPROCESS (proc).
791 (send_process): Likewise.
792
793 2012-01-19 Martin Rudalics <rudalics@gmx.at>
794
795 * window.c (save_window_save, Fcurrent_window_configuration)
796 (Vwindow_persistent_parameters): Do not use Qstate.
797 Rewrite doc-strings.
798
799 2012-01-19 Kenichi Handa <handa@m17n.org>
800
801 * character.c (char_width): New function.
802 (Fchar_width, c_string_width, lisp_string_width):
803 Use char_width (Bug#9496).
804
805 2012-01-16 Martin Rudalics <rudalics@gmx.at>
806
807 * window.c (Vwindow_persistent_parameters): New variable.
808 (Fset_window_configuration, save_window_save): Handle persistent
809 window parameters.
810
811 2012-01-14 Eli Zaretskii <eliz@gnu.org>
812
813 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
814 thrashing the stack of the thread. (Bug#9087)
815
816 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
817
818 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
819
820 2012-01-11 Eli Zaretskii <eliz@gnu.org>
821
822 * xdisp.c (rows_from_pos_range): Handle the case where the
823 highlight ends on a newline. (Bug#10464)
824 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
825 he end column for display of highlight that ends on a newline
826 before a R2L line.
827
828 2012-01-11 Glenn Morris <rgm@gnu.org>
829
830 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
831 from load-path also when installation-directory is nil. (Bug#10208)
832
833 2012-01-10 Glenn Morris <rgm@gnu.org>
834
835 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
836
837 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
838 Update template values to be closer to their typical values these days.
839
840 2012-01-09 Eli Zaretskii <eliz@gnu.org>
841
842 * xdisp.c (rows_from_pos_range): Accept additional argument
843 DISP_STRING, and accept any glyph in a row whose object is that
844 string as eligible for mouse highlight. Fixes mouse highlight of
845 display strings from overlays. (Bug#10464)
846
847 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
848
849 emacs: fix an auto-save permissions race condition (Bug#10400)
850 * fileio.c (auto_saving_dir_umask): New static var.
851 (Fmake_directory_internal): Use it.
852 (do_auto_save_make_dir): Set it, instead of invoking chmod after
853 creating the directory. The old code temporarily assigns
854 too-generous permissions to the directory.
855 (do_auto_save_eh): Clear it.
856 (Fdo_auto_save): Catch all errors, not just file errors, so
857 that the var is always cleared.
858
859 2012-01-07 Eli Zaretskii <eliz@gnu.org>
860
861 * search.c (scan_buffer): Pass character positions to
862 know_region_cache, not byte positions. (Bug#6540)
863
864 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
865
866 * w32.c (sys_rename): Report EXDEV when rename of a directory
867 fails because the target is on another logical disk. (Bug#10284)
868
869 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
870
871 * xterm.c (x_embed_request_focus): New function.
872
873 * xterm.h: Add prototype.
874
875 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
876
877 2012-01-05 Glenn Morris <rgm@gnu.org>
878
879 * emacs.c (emacs_copyright): Update short copyright year to 2012.
880
881 2012-01-01 Eli Zaretskii <eliz@gnu.org>
882
883 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
884 Load gnutls_transport_set_lowat only if GnuTLS version is below
885 2.11.1.
886 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
887 GnuTLS versions below 2.11.1.
888
889 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
890
891 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
892 to the doc string advising against its use for altering the way
893 windows are scrolled.
894
895 2011-12-28 Kenichi Handa <handa@m17n.org>
896
897 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
898 coding-system ASCII compatible only when it does not produce BOM
899 on encoding (Bug#10383).
900
901 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
902
903 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
904 can scroll.
905 (create_and_show_popup_menu): Always use menu_position_func for
906 Gtk3 (Bug#10361).
907
908 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
909
910 * callint.c (Fcall_interactively): Don't truncate prompt string.
911
912 2011-12-23 Eli Zaretskii <eliz@gnu.org>
913
914 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
915 property that ends at ZV, so that the bidi iteration could be
916 resumed from there (after widening). (Bug#10360)
917
918 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
919
920 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
921
922 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
923
924 * nsterm.m (x_free_frame_resources):
925 Release f->output_data.ns->miniimage.
926 (ns_index_color): Fix indentation. Do not retain
927 color_table->colors[i].
928
929 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
930 before returning.
931
932 * nsfns.m (x_set_background_color): Assign return value from
933 ns_index_color to face-background instead of NSColor*.
934 (ns_implicitly_set_icon_type): Fix indentation.
935 Change assignment in for loop to comparison.
936
937 * emacs.c (ns_pool): New variable.
938 (main): Assign ns_pool.
939 (Fkill_emacs): Call ns_release_autorelease_pool.
940
941 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
942 autorelease fdesc, release fdAttrs and tdict.
943 (ns_get_covering_families): Release charset.
944 (ns_findfonts): Release NSFontDescriptor created with new.
945 (ns_uni_to_glyphs): Fix indentation.
946 (setString): Release attrStr before assigning new value.
947
948 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
949
950 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
951 and NS_IMPL_COCOA.
952 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
953 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
954
955 2011-12-18 David Reitter <reitter@cmu.edu>
956
957 * nsterm.m (ns_term_init): Subscribe for notifications
958 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
959 to method trackingNotification in EmacsMenu.
960
961 * nsmenu.m (trackingMenu): New variable.
962 (trackingNotification): New method (from Aquamacs).
963 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
964 from Aquamacs (Bug#7030).
965
966 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
967
968 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
969 (symbol_to_nsstring): Fix indentation.
970 (ns_symbol_to_pb): New function.
971 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
972 (Fns_rotate_cut_buffers_internal): Remove.
973 (Fns_store_selection_internal): Rename from
974 Fns_store_cut_buffer_internal.
975 (ns_get_foreign_selection, Fx_own_selection_internal)
976 (Fx_disown_selection_internal, Fx_selection_exists_p)
977 (Fns_get_selection_internal, Fns_store_selection_internal):
978 Use ns_symbol_to_pb and check if return value is nil.
979 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
980 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
981 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
982 renamed to Sns_store_selection_internal.
983 (ns_handle_selection_request): Move code to Fx_own_selection_internal
984 and remove this function.
985 (ns_handle_selection_clear): Remove, never used.
986 (Fx_own_selection_internal): Move code from ns_handle_selection_request
987 here.
988
989 2011-12-17 Ken Brown <kbrown@cornell.edu>
990
991 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
992 GID is unknown (Bug#10257).
993
994 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
995
996 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
997 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
998 which caused a build failure on GNU/Linux IA-64. This problem was
999 introduced by my 2011-10-07 patch.
1000
1001 2011-12-15 Juri Linkov <juri@jurta.org>
1002
1003 * image.c (imagemagick_error): New function. (Bug#10112)
1004 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1005 Use `imagemagick_error' where ImageMagick functions return
1006 `MagickFalse'.
1007 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1008 proper order.
1009
1010 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1011
1012 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1013 fill background (Bug#8992).
1014
1015 2011-12-13 Martin Rudalics <rudalics@gmx.at>
1016
1017 * window.c (Vwindow_combination_resize)
1018 (Vwindow_combination_limit): Use t instead of non-nil in
1019 doc-strings.
1020 (Vrecenter_redisplay): Add first sentence of doc-string on
1021 separate line.
1022 (Frecenter): Fix doc-string typo.
1023
1024 2011-12-11 Kenichi Handa <handa@m17n.org>
1025
1026 * coding.c (Funencodable_char_position): Pay attention to the
1027 buffer text relocation (Bug#9389).
1028
1029 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1030
1031 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1032 gtk_init (Bug#10100).
1033
1034 2011-12-10 Eli Zaretskii <eliz@gnu.org>
1035
1036 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1037 IT->string is nil. (Bug#10263)
1038
1039 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1040
1041 * nsterm.h (x_free_frame_resources): Declare.
1042
1043 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1044 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1045
1046 * nsterm.h (ns_get_defaults_value): Declare.
1047
1048 * nsterm.m (ns_default): Call ns_get_defaults_value.
1049
1050 2011-12-09 Eli Zaretskii <eliz@gnu.org>
1051
1052 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1053 (Bug#10170)
1054
1055 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1056
1057 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1058 that where the value of an _OBJC_* symbol points to is in the .bss
1059 section (Bug#10240).
1060
1061 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1062
1063 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
1064 after the loop to call ccl_driver at least once (Bug#8619).
1065
1066 2011-12-08 Kenichi Handa <handa@m17n.org>
1067
1068 * ftfont.c (get_adstyle_property): Fix previous change
1069 (Bug#10233).
1070
1071 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
1072
1073 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1074 dirs from the default value of EMACSLOADPATH (bug#10208).
1075
1076 2011-12-07 Glenn Morris <rgm@gnu.org>
1077
1078 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1079 installation and source directories as well. (Bug#10208)
1080
1081 2011-12-06 Chong Yidong <cyd@gnu.org>
1082
1083 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1084
1085 2011-12-06 Glenn Morris <rgm@gnu.org>
1086
1087 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1088 as an error, not just -1. (Bug#10217)
1089
1090 2011-12-05 Chong Yidong <cyd@gnu.org>
1091
1092 * keyboard.c (process_special_events): New function.
1093 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1094
1095 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1096
1097 * coding.c (encode_designation_at_bol): Don't use uninitialized
1098 local variable (Bug#9318).
1099
1100 2011-12-05 Kenichi Handa <handa@m17n.org>
1101
1102 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1103 return Qnil (Bug#8046, Bug#10193).
1104
1105 2011-12-05 Kenichi Handa <handa@m17n.org>
1106
1107 * coding.c (encode_designation_at_bol): New args charbuf_end and
1108 dst. Return the number of produced bytes. Callers changed.
1109 (coding_set_source): Return how many bytes coding->source was
1110 relocated.
1111 (coding_set_destination): Return how many bytes
1112 coding->destination was relocated.
1113 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
1114 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
1115
1116 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1117
1118 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1119 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1120 macro (Bug#9318).
1121
1122 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1123
1124 The following changes are to fix Bug#9318.
1125
1126 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
1127 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1128 (encode_coding_iso_2022, encode_coding_sjis)
1129 (encode_coding_big5, encode_coding_charset): Use the above macros.
1130
1131 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
1132
1133 * lisp.h (process_quit_flag): Fix external declaration.
1134
1135 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1136
1137 Don't macro-inline non-performance-critical code.
1138 * eval.c (process_quit_flag): New function.
1139 * lisp.h (QUIT): Use it.
1140
1141 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1142
1143 * nsfns.m (get_geometry_from_preferences): New function.
1144 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1145
1146 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1147
1148 * emacs.c (Qkill_emacs): Define.
1149 (syms_of_emacs): Initialize it.
1150 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1151 Qquit_flag to `kill-emacs' instead.
1152 (quit_throw_to_read_char): Add parameter `from_signal'.
1153 All callers changed. Call Fkill_emacs if requested and safe.
1154 * lisp.h (QUIT): Call Fkill_emacs if requested.
1155
1156 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1157
1158 * widget.c (update_wm_hints): Return if wmshell is null.
1159 (widget_update_wm_size_hints): New function.
1160
1161 * widget.h (widget_update_wm_size_hints): Declare.
1162
1163 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1164 widget_update_wm_size_hints (Bug#10104).
1165
1166 2011-12-03 Eli Zaretskii <eliz@gnu.org>
1167
1168 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1169 before a newline, prepare the bidi iterator for consuming the
1170 newline, and keep the current paragraph direction. (Bug#10183)
1171 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1172
1173 2011-12-02 Juri Linkov <juri@jurta.org>
1174
1175 * search.c (Fword_search_regexp): New Lisp function created from
1176 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1177 (Fword_search_backward, Fword_search_forward)
1178 (Fword_search_backward_lax, Fword_search_forward_lax):
1179 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1180 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1181
1182 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1183
1184 * fileio.c (Finsert_file_contents): Move after-change-function call
1185 to before the "handled:" label, since all "goto handled" appear in
1186 cases where the *-change-functions have already been properly called
1187 (bug#10117).
1188
1189 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1190
1191 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1192 waiting for input. (Bug#10169)
1193
1194 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1195
1196 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1197 verifies glyph row's hash code--we have just reallocated the
1198 glyphs, so their contents can be complete garbage. (Bug#10164)
1199
1200 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1201
1202 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1203
1204 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1205
1206 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1207 attributes are tested _before_ calling verify_row_hash, to protect
1208 against GCC re-ordering of the tests. (Bug#10164)
1209
1210 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1211
1212 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1213
1214 * xterm.c (handle_one_xevent): Only set async_visible and friends
1215 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1216 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1217 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1218
1219 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1220
1221 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1222 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1223 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1224 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1225 All uses changed to use GCPRO1 etc.
1226 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1227 Revert to old implementation (i.e., before 2011-03-11).
1228
1229 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1230
1231 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1232 of scroll runs so as to avoid assigning disabled bogus rows and
1233 unnecessary graphics copy operations.
1234
1235 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1236
1237 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1238 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1239 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1240 (malloc, free, realloc, calloc): Redirect to e_* only when
1241 compiling Emacs.
1242
1243 * lisp.h (GCTYPEBITS): Move before first use.
1244 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1245 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1246 this macro definition.
1247
1248 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1249 _MSC_VER.
1250
1251 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1252
1253 * gtkutil.c (xg_create_frame_widgets):
1254 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1255 present with Gtk+ 2.0.
1256
1257 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1258
1259 * fileio.c (Finsert_file_contents): Undo previous change; see
1260 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1261
1262 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1263
1264 Rename locals to avoid shadowing.
1265 * fileio.c (Finsert_file_contents):
1266 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1267 * process.c (wait_reading_process_output):
1268 Rename inner 'proc' to 'p' to avoid shadowing.
1269 Indent for consistency with usual Emacs style.
1270
1271 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1272
1273 * xdisp.c (redisplay_window): If cursor row is not fully visible
1274 after recentering, and scroll-conservatively is set to a large
1275 number, scroll window by a few more lines to make the cursor fully
1276 visible and out of scroll-margin. (Bug#10105)
1277 (start_display): Don't move to the next line if the display should
1278 start at a newline that is part of a display vector or an overlay
1279 string. (Bug#10119)
1280
1281 2011-11-24 Juri Linkov <juri@jurta.org>
1282
1283 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1284 after the `MagickPingImage' call. (Bug#10112)
1285
1286 2011-11-23 Chong Yidong <cyd@gnu.org>
1287
1288 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1289
1290 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1291
1292 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1293 making another buffer current. (Bug#10114)
1294
1295 2011-11-23 Glenn Morris <rgm@gnu.org>
1296
1297 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1298
1299 2011-11-23 Chong Yidong <cyd@gnu.org>
1300
1301 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1302 using it (Bug#5984).
1303
1304 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1305
1306 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1307 and header-lines, as they don't have one computed for them.
1308 (Bug#10098)
1309
1310 * .gdbinit (prow): Make displayed values more self-explaining.
1311 Add row's hash code.
1312
1313 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1314
1315 * process.c (wait_reading_process_output): Fix asynchrounous
1316 GnuTLS socket handling on some versions of the GnuTLS library.
1317 (wait_reading_process_output): Add comment and URL.
1318
1319 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1320
1321 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1322
1323 2011-11-21 Chong Yidong <cyd@gnu.org>
1324
1325 * window.c (Fnext_window, Fprevious_window): Doc fix.
1326
1327 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1328
1329 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1330
1331 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1332
1333 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1334
1335 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1336
1337 * window.c (Fset_window_combination_limit): Rename argument
1338 STATUS to LIMIT.
1339 (Vwindow_combination_limit): Remove "status" from doc-string.
1340
1341 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1342
1343 * m/ibms390.h: Remove.
1344 * m/ibms390x.h: Don't include "ibms390.h".
1345
1346 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1347
1348 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1349 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1350
1351 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1352
1353 * casetab.c (Fset_case_table):
1354 * charset.c (Fcharset_after): Fix typos.
1355
1356 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1357
1358 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1359 Otherwise, valgrind does not work on some platforms.
1360 Problem reported by Andreas Schwab in
1361 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1362 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1363 is set, removing the need for VIRT_ADDRESS_VARIES.
1364 (PURE_P): Use a more-efficient implementation that needs just one
1365 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1366 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1367 to 4 (xorl, subq, cmpq, setbe).
1368 * alloc.c (pure): Always extern now, since that's the
1369 VIRT_ADDR_VARIES behavior.
1370 (PURE_POINTER_P): Use a single comparison, not two, for
1371 consistency with the new puresize.h.
1372 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1373 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1374 Remove VIRT_ADDR_VARIES no longer needed.
1375
1376 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1377
1378 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1379 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1380 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1381 behave as if the cursor position were at the window margin.
1382
1383 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1384 and the cursor position is out of bounds, behave as if the cursor
1385 position were at the window margin. (Bug#10075)
1386
1387 2011-11-18 Chong Yidong <cyd@gnu.org>
1388
1389 * window.c (Fwindow_combination_limit): Make first argument
1390 non-optional, since it is meaningless for live windows like the
1391 selected window.
1392
1393 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1394
1395 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1396
1397 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1398
1399 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1400 (graft_intervals_into_buffer): Simplify.
1401
1402 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1403
1404 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1405 hash values of the two rows.
1406 (copy_row_except_pointers): Preserve the used[] arrays and the
1407 hash values of the two rows. (Bug#10035)
1408 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1409
1410 * xdisp.c (row_hash): New function, body extracted from
1411 compute_line_metrics.
1412 (compute_line_metrics): Call row_hash, instead of computing the
1413 hash code inline.
1414
1415 * dispnew.c (verify_row_hash): Call row_hash for computing the
1416 hash code of a row, instead of duplicating code from xdisp.c.
1417
1418 * dispextern.h (row_hash): Add prototype.
1419
1420 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1421
1422 * frame.c (delete_frame): Don't delete the terminal when the last
1423 X frame is closed if emacs is built with GTK toolkit.
1424
1425 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1426
1427 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1428
1429 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1430
1431 * window.c (Vwindow_splits): Rename to
1432 Vwindow_combination_resize. Suggested by Juri Linkov.
1433 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1434 of Vwindow_splits.
1435
1436 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1437
1438 * nsfns.m (Fns_font_name):
1439 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1440
1441 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1442
1443 * window.h (window): Rename slot "nest" to "combination_limit".
1444 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1445 (Fset_window_nest): Rename to Fset_window_combination_limit.
1446 (Vwindow_nest): Rename to Vwindow_combination_limit.
1447 (recombine_windows, make_parent_window, make_window)
1448 (Fsplit_window_internal, saved_window)
1449 (Fset_window_configuration, save_window_save): Rename all
1450 occurrences of window_nest to window_combination_limit.
1451
1452 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1453
1454 * image.c (imagemagick_load_image): Fix typo.
1455
1456 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1457
1458 * xdisp.c (display_line): Move the call to
1459 highlight_trailing_whitespace before the call to
1460 compute_line_metrics, since the latter needs to see the final
1461 faces of all the glyphs to compute ROW's hash value.
1462 Fixes assertion violations in row_equal_p. (Bug#10035)
1463
1464 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1465
1466 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1467 just return (bug#10044).
1468
1469 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1470
1471 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1472 with user-defined heap size. Bump the default size of the temacs
1473 heap to 27MB, to avoid memory warning when running temacs.
1474 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1475
1476 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1477 current_matrix and desired_matrix. (Bug#9990)
1478 (verify_row_hash) [XASSERTS]: New function.
1479 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1480 that the hash value of glyph rows is correct.
1481
1482 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1483
1484 * window.h (window): Remove splits slot.
1485 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1486 (Fdelete_other_windows_internal, make_parent_window)
1487 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1488 (Fset_window_configuration, save_window_save): Don't deal with
1489 split status of windows.
1490 (saved_window): Remove splits slot.
1491 (Vwindow_splits): Rewrite doc-string.
1492
1493 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1494
1495 * xfns.c (unwind_create_frame):
1496 * nsfns.m (unwind_create_frame):
1497 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1498 Vframe_list (Bug#9999).
1499
1500 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1501
1502 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1503
1504 2011-11-11 Kenichi Handa <handa@m17n.org>
1505
1506 * callproc.c (Fcall_process): Set the member dst_multibyte of
1507 process_coding.
1508
1509 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1510
1511 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1512 avoid a crash (bug#9496).
1513
1514 2011-11-09 Chong Yidong <cyd@gnu.org>
1515
1516 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1517 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1518
1519 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1520
1521 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1522
1523 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1524
1525 Avoid some portability problems by eschewing 'extern inline' functions.
1526 The trivial performance wins aren't worth the portability hassles; see
1527 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1528 et seq.
1529 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1530 (window_box_width, window_box_left, window_box_left_offset)
1531 (window_box_right, window_box_right_offset): Undo previous change,
1532 by removing the "extern"s.
1533 * intervals.c (adjust_intervals_for_insertion)
1534 (adjust_intervals_for_deletion): Undo previous change,
1535 making these static again.
1536 (offset_intervals, temp_set_point_both, temp_set_point)
1537 (copy_intervals_to_string): No longer inline.
1538 * xdisp.c (window_text_bottom_y, window_box_width)
1539 (window_box_height, window_box_left_offset)
1540 (window_box_right_offset, window_box_left, window_box_right)
1541 (window_box): No longer inline.
1542
1543 2011-11-08 Chong Yidong <cyd@gnu.org>
1544
1545 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1546 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1547 Signal an error if not a live window.
1548 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1549 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1550
1551 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1552
1553 * lisp.h (syms_of_abbrev): Remove declaration.
1554 Reported by CHENG Gao <chenggao@royau.me>.
1555
1556 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1557
1558 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1559 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1560 of temacs in GUI mode.
1561
1562 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1563
1564 * window.h: Declare delete_all_child_windows instead of
1565 delete_all_subwindows.
1566 * window.c (Fwindow_nest, Fset_window_nest)
1567 (Fset_window_new_total, Fset_window_new_normal)
1568 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1569 (delete_all_subwindows): Rename to delete_all_child_windows.
1570 (Fdelete_other_windows_internal, Fset_window_configuration):
1571 Call delete_all_child_windows instead of delete_all_subwindows.
1572 * frame.c (delete_frame): Call delete_all_child_windows instead
1573 of delete_all_subwindows.
1574
1575 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1576
1577 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1578 This is also needed for porting to any host where GC_MARK_STACK is
1579 not GC_MAKE_GCPROS_NOOPS.
1580 (which_symbols): Use it.
1581
1582 2011-11-07 Kenichi Handa <handa@m17n.org>
1583
1584 * coding.c (coding_set_destination): Check coding->src_pos only
1585 when coding->src_object is a buffer (bug#9910).
1586
1587 * process.c (send_process): Set the member src_multibyte of coding
1588 to 0 (bug#9911) when sending a unibyte text.
1589
1590 * callproc.c (Fcall_process): Set the member src_multibyte of
1591 process_coding to 0 (bug#9912).
1592
1593 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1594
1595 * xmenu.c (cleanup_widget_value_tree): New function.
1596 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1597 calling free_menubar_widget_value_tree directly (Bug#9830).
1598
1599 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1600
1601 Fix some portability problems with 'inline'.
1602 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1603 (window_box_width, window_box_left, window_box_left_offset)
1604 (window_box_right, window_box_right_offset): Declare extern.
1605 Otherwise, these inline functions do not conform to C99 and
1606 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1607 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1608 * intervals.c (adjust_intervals_for_insertion)
1609 (adjust_intervals_for_deletion): Now extern, because otherwise the
1610 extern inline functions 'offset_intervals' couldn't refer to it.
1611 (static_offset_intervals): Remove.
1612 (offset_intervals): Rewrite using the old contents of
1613 static_offset_intervals. The old version didn't conform to C99
1614 because an extern inline function contained a reference to an
1615 identifier with static linkage.
1616
1617 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1618
1619 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1620 GC.
1621
1622 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1623
1624 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1625 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1626 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1627 return Qleft_to_right.
1628
1629 2011-11-06 Chong Yidong <cyd@gnu.org>
1630
1631 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1632 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1633 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1634 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1635 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1636 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1637 (Fwindow_vscroll): Doc fix.
1638 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1639 argument, since it makes no sense to pass a live window and for
1640 consistency with window-child.
1641
1642 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1643
1644 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1645 support MSVC.
1646
1647 2011-11-05 Jason Rumney <jasonr@gnu.org>
1648
1649 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1650 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1651 fonts (Bug#6029).
1652 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1653 bitwise arithmetic preventing use of unicode-sip and non-truetype
1654 opentype fonts.
1655
1656 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1657
1658 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1659 "emacs"-only part.
1660
1661 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1662 initialization code to keep similarity to xfns.c after changes
1663 from 2011-11-05.
1664
1665 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1666
1667 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1668 (unwind_create_frame): New function (Bug#9943).
1669 (Fx_create_frame): Restructure code to be more similar to the one in
1670 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1671 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1672 Move terminal->reference_count++ just before making the frame official
1673 (Bug#9943).
1674
1675 * nsterm.m (x_free_frame_resources): New function.
1676 (x_destroy_window): Move code to x_free_frame_resources.
1677
1678 * xfns.c (unwind_create_frame): Fix comment.
1679 (Fx_create_frame, x_create_tip_frame):
1680 Move terminal->reference_count++ just before making the frame
1681 official. Move initialization of image_cache_refcount and
1682 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1683
1684 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1685
1686 Support MSVC build with newer versions of Visual Studio.
1687 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1688 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1689 nt/gmake.defs.
1690
1691 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1692 which are not supported by MSVC.
1693 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1694 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1695 bitfields.
1696 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1697 types in bitfields.
1698 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1699
1700 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1701
1702 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1703
1704 Support MSVC build with newer versions of Visual Studio.
1705 * w32.c: Don't include w32api.h for MSVC.
1706 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1707
1708 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1709 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1710 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1711 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1712 e_* cousins.
1713 (alloca) [_MSC_VER]: Define to _alloca.
1714
1715 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1716
1717 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1718
1719 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1720
1721 * xdisp.c (note_mouse_highlight): If either of
1722 previous/next-single-property-change returns nil, treat that as
1723 the beginning or the end of the buffer. (Bug#9955)
1724
1725 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1726
1727 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1728 label is not null (Bug#9951).
1729 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1730 may be NULL.
1731
1732 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1733
1734 * window.c (Fwindow_body_size): Mention in the doc string that the
1735 return value is in frame's canonical units. (Bug#9949)
1736
1737 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1738
1739 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1740
1741 * w32fns.c (unwind_create_frame): If needed, free the glyph
1742 matrices of the partially constructed frame. (Bug#9943)
1743 * xfns.c (unwind_create_frame): Likewise.
1744
1745 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1746
1747 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1748 Don't stop backward scan on the continuation glyph, even though
1749 its CHARPOS is positive.
1750 (mouse_face_from_buffer_pos, note_mouse_highlight):
1751 Rename cover_string to disp_string.
1752
1753 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1754
1755 * window.c (temp_output_buffer_show): Don't use
1756 Vtemp_buffer_show_specifiers.
1757 (Vtemp_buffer_show_specifiers): Remove unused variable.
1758
1759 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1760
1761 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1762 past the beginning of the current glyph matrix.
1763
1764 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1765
1766 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1767 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1768 HAVE_GTK3 (Bug#9869).
1769
1770 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1771 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1772
1773 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1774
1775 * xterm.c: Declare x_handle_net_wm_state to return int.
1776 (handle_one_xevent): Check if we are iconified but don't have
1777 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1778 (get_current_wm_state): Return non-zero if not hidden,
1779 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1780 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1781 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1782 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1783
1784 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1785
1786 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1787 so that this new function doesn't get optimized away by a
1788 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1789
1790 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1791
1792 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1793
1794 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1795
1796 Fix the `xbytecode' command.
1797 * .gdbinit (xprintbytestr): New command.
1798 (xwhichsymbols): Rename from `which'; all callers changed.
1799 (xbytecode): Print the byte-code string as well.
1800
1801 2011-10-29 Kim Storm <storm@cua.dk>
1802
1803 * alloc.c (which_symbols): New function.
1804
1805 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1806
1807 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1808 line. (Bug#9903)
1809
1810 2011-10-29 Glenn Morris <rgm@gnu.org>
1811
1812 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1813 Not clear what it was for, and it causes various bugs. (Bug#9839)
1814
1815 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1816
1817 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1818 possible random value that matches one of those tested as
1819 condition to clear the mouse face.
1820
1821 2011-10-28 Chong Yidong <cyd@gnu.org>
1822
1823 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1824
1825 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1826
1827 * window.c (make_window): Initialize phys_cursor_on_p.
1828
1829 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1830
1831 * lisp.h (struct Lisp_Symbol): Update comments.
1832
1833 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1834
1835 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1836
1837 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1838
1839 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1840 <oslsachem@gmail.com> for helping to debug this.
1841
1842 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1843 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1844 (g_b_init_get_glyph_outline_w): New static variables.
1845 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1846 (GetGlyphOutlineW_Proc): New typedefs.
1847 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1848 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1849 New functions.
1850 (w32font_open_internal, compute_metrics):
1851 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1852 instead of calling the "wide" APIs directly.
1853
1854 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1855
1856 * w32.h (syms_of_w32font): Add prototype.
1857
1858 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1859
1860 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1861 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1862 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1863 (Fmove_to_window_line): Doc fix.
1864
1865 2011-10-27 Chong Yidong <cyd@gnu.org>
1866
1867 * process.c (make_process): Set gnutls_state to NULL.
1868
1869 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1870 non-NULL, regardless of GNUTLS_INITSTAGE.
1871 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1872 an error. Set process slots as soon as we allocate them.
1873
1874 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1875
1876 2011-10-27 Chong Yidong <cyd@gnu.org>
1877
1878 * gnutls.c (emacs_gnutls_deinit): New function.
1879 Deallocate credentials structures as well as calling gnutls_deinit.
1880 (Fgnutls_deinit, Fgnutls_boot): Use it.
1881
1882 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1883 (deactivate_process): Call emacs_gnutls_deinit.
1884
1885 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1886
1887 * image.c (x_create_x_image_and_pixmap):
1888 * w32.c (sys_rename, w32_delayed_load):
1889 * w32font.c (fill_in_logfont):
1890 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1891
1892 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1893
1894 * w32fns.c (w32_default_color_map): New function,
1895 extracted from Fw32_default_color_map.
1896 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1897
1898 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1899
1900 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1901
1902 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1903
1904 * keyboard.c (test_undefined): New function (bug#9751).
1905 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1906
1907 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1908
1909 * sysdep.c (init_sys_modes): Fix the check for the controlling
1910 terminal (Bug#6649).
1911
1912 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1913
1914 * dispextern.h (struct bidi_it): New member next_en_type.
1915
1916 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1917 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1918 current character, check also for next_en_type being WEAK_EN.
1919 (bidi_resolve_weak): Don't enter the expensive loop if the current
1920 position is before next_en_pos. Record the bidi type of the first
1921 non-ET, non-BN character we find, in addition to its position.
1922 (bidi_level_of_next_char): Invalidate next_en_type when
1923 next_en_pos is over-stepped.
1924
1925 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1926
1927 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1928 * editfns.c: Rewrite current-time-zone so that it invokes
1929 the equivalent of (format-time-string "%Z") to get the time zone name.
1930 This fixes a bug when the time zone name contains characters that
1931 need converting from the system time locale to Emacs internal format.
1932 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1933 that patch fixed format-time-string to do the conversion, but
1934 I forgot to fix current-time-zone.
1935 (format_time_string): New function, containing most of
1936 what Fformat_time_string used to contain.
1937 (Fformat_time_string): Rewrite in terms of format_time_string.
1938 This doesn't change this function's behavior.
1939 (current-time-zone): Rewrite to use format_time_string.
1940 This fixes the bug reported by Michael Schierl in
1941 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1942 Jason Rumney's 2007-06-07 change worked around this bug, but
1943 didn't fix it.
1944 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1945
1946 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1947
1948 * xdisp.c (start_display): If the character at POS is displayed
1949 via a display vector, reset IT->current.dpvec_index to zero.
1950 (try_window_reusing_current_matrix): If a line ends in a display
1951 vector or the next line starts in a display vector, continue
1952 redrawing the window even though the character position of
1953 start_row was reached.
1954 (Bug#9771, part 2)
1955
1956 2011-10-18 Chong Yidong <cyd@gnu.org>
1957
1958 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1959 with nobreak-char-display too.
1960
1961 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1962
1963 Fix part 3 of bug#9771.
1964 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1965 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1966 non-neutral characters if the current character is a paragraph
1967 separator (a.k.a. Newline). This avoids running the same
1968 expensive loop twice, once when we consume the preceding newline
1969 and the other time when the line actually needs to be displayed.
1970 Avoid the loop when we see neutrals on the base embedding level
1971 following a character whose directionality is the same as the
1972 paragraph's. This avoids running the expensive loop when a line
1973 ends in a long sequence of neutrals, like control characters.
1974 Add assertion against STRONG_AL type. Slightly rearrange code
1975 that determines the type of a neutral given the first non-neutral
1976 that follows it.
1977 (bidi_level_of_next_char): Set next_en_pos to zero when
1978 invalidating its info.
1979
1980 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1981
1982 * xdisp.c (push_display_prop): Determine whether to record string
1983 or buffer position by IT->string, not by IT->method. Allow
1984 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1985 (move_it_vertically_backward): Don't look for character position
1986 immediately after the newline when in a continuation line.
1987 (Bug#9771, part 1)
1988
1989 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1990
1991 * window.c (coordinates_in_window): Rewrite and delabelize
1992 vertical border check. (Bug#5357) (Bug#9618)
1993
1994 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1995
1996 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1997 errors in XSetWindowBorder (bug#9310).
1998
1999 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2000
2001 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2002 avoid crash when xmalloc overrun checking is enabled.
2003
2004 2011-10-13 Eli Zaretskii <eliz@gnu.org>
2005
2006 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2007 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2008 cursor motion with <left> and <right> arrow keys.
2009
2010 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2011 some callers set that themselves.
2012
2013 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2014
2015 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2016 display string and the previous row comes from the same string and
2017 is empty. (Bug#9739) (Bug#9738)
2018
2019 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2020
2021 * doc.c (get_doc_string): Encode file name (bug#9735).
2022
2023 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2024
2025 * bidi.c (bidi_level_of_next_char):
2026 * xdisp.c (get_visually_first_element): Remove old incorrect
2027 comments regarding the Unicode Line Separator character.
2028
2029 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2030
2031 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2032
2033 * alloc.c (Fgc_status): Do not access beyond zombies array
2034 boundary if nzombies > MAX_ZOMBIES.
2035 * alloc.c (dump_zombies): Add missing format specifier.
2036
2037 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2038
2039 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2040 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2041
2042 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2043 Some packages use them to denote characters with modifiers.
2044
2045 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2046
2047 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2048 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2049 matching a pp-number. Rename parameter var to var1.
2050
2051 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2052
2053 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2054
2055 2011-10-08 Glenn Morris <rgm@gnu.org>
2056
2057 * callint.c (Fcall_interactively): Give a more explicit error for the
2058 'c' case with a non-character input. (Bug#8479)
2059
2060 2011-10-08 Eli Zaretskii <eliz@gnu.org>
2061
2062 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2063 lines.
2064 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2065 lines that are hscrolled on the left.
2066
2067 * dispnew.c (buffer_posn_from_coords): Account for a possible
2068 presence of header-line. (Bug#4426)
2069
2070 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2071
2072 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2073 Don't advertise functionality which we discourage or doesn't work.
2074
2075 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2076
2077 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2078 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2079 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2080 this makes Emacs dump core during garbage collection on rare
2081 occasions. sizeof is obviously inferior to offsetof here, so
2082 stick with offsetof.
2083 (GC_POINTER_ALIGNMENT): New macro.
2084 (mark_memory): Omit 3rd (offset) arg; caller changed.
2085 Don't assume EMACS_INT alignment is the same as pointer alignment.
2086
2087 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2088
2089 * keyboard.c (read_key_sequence_remapped): New var.
2090 (read_key_sequence): Compute remapping in the right buffer.
2091 (command_loop_1): Use read_key_sequence's remapping directly.
2092
2093 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2094
2095 * dired.c (file_name_completion): Don't expand file name.
2096 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2097 before checking file name handler.
2098
2099 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2100 they've been requested explicitly (bug#9591).
2101
2102 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
2103
2104 * keymap.c (Fsingle_key_description): Use make_specified_string
2105 instead of build_string to build string from push_key_description.
2106 (Bug#5193)
2107
2108 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2109
2110 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2111 This fixes a Y2038 bug on 64-bit hosts.
2112 * buffer.c (reset_buffer):
2113 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2114 (Fclear_buffer_auto_save_failure):
2115 Use 0, not -1, to represent an unset failure time, since time_t
2116 might not be signed.
2117
2118 Remove dependency on glibc malloc internals.
2119 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2120 Move back here from lisp.h, but with their new implementations.
2121 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2122 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2123 * charset.c (charset_table_init): New static var.
2124 (syms_of_charset): Use it instead of xmalloc. This removes a
2125 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2126 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2127 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2128 Move back to alloc.c.
2129 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2130 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2131
2132 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2133
2134 * nsterm.m (windowDidResize): Call x_set_window_size only when
2135 ns_in_resize is true. Otherwise set pixelwidth/height and
2136 call change_frame_size (Bug#9628).
2137
2138 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2139
2140 Port --enable-checking=all to Fedora 14 x86-64.
2141 * charset.c (syms_of_charset): Also account for glibc malloc's
2142 internal overhead when calculating the initial malloc maximum.
2143
2144 Port --enable-checking=all to Fedora 14 x86.
2145 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2146 Move to lisp.h.
2147 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2148 (overrun_check_realloc, overrun_check_free):
2149 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2150 That way, xmalloc returns a properly-aligned pointer even if
2151 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2152 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2153 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2154 into account when calculating the initial malloc maximum.
2155 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2156 Move here from alloc.c, so that charset.c can use it too.
2157 Properly align; the old code wasn't right for common 32-bit hosts
2158 when configured with --enable-checking=all.
2159 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2160 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2161
2162 2011-09-29 Eli Zaretskii <eliz@gnu.org>
2163
2164 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2165 use EDOM.
2166
2167 2011-09-28 Eli Zaretskii <eliz@gnu.org>
2168
2169 * xdisp.c (compute_display_string_end): If there's no display
2170 string at CHARPOS, return -1.
2171
2172 * bidi.c (bidi_fetch_char): When compute_display_string_end
2173 returns a negative value, treat the character as a normal
2174 character not covered by a display string. (Bug#9624)
2175
2176 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2177
2178 * lread.c (Fread_from_string): Fix typo in docstring.
2179
2180 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2181
2182 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2183 newline, reseat the iterator instead of bidi-iterating there one
2184 character at a time. (Bug#9610)
2185 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2186 TO_CHARPOS if the bidi iterator is at base embedding level.
2187
2188 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2189
2190 * lread.c (readevalloop): Use correct code for NBSP.
2191 (read1): Likewise. (Bug#9608)
2192
2193 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2194
2195 * dbusbind.c (Fdbus_register_signal): When service is not
2196 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2197
2198 2011-09-25 Glenn Morris <rgm@gnu.org>
2199
2200 * buffer.c (truncate-lines): Doc fix.
2201
2202 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2203
2204 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2205 (Fset_window_next_buffers): Doc fix.
2206
2207 2011-09-24 Glenn Morris <rgm@gnu.org>
2208
2209 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2210
2211 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2212
2213 Fix minor problems found by static checking.
2214 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2215 * indent.c (Fvertical_motion): Fix == vs = typo.
2216
2217 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2218
2219 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2220 Default value is now t. Doc fix.
2221
2222 * indent.c (Fvertical_motion): Compute and apply the overshoot
2223 logic when moving up, not only when moving down. Fix the
2224 confusing name and values of the it_overshoot_expected variable;
2225 logic changes accordingly. (Bug#9254) (Bug#9549)
2226
2227 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2228 CHARPOS is covered by a display string which includes newlines.
2229 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2230 is covered by a display string with embedded newlines.
2231
2232 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2233
2234 * dbusbind.c (Fdbus_register_signal): Add match rule to
2235 Vdbus_registered_objects_table. (Bug#9581)
2236 (Fdbus_register_method, Vdbus_registered_objects_table):
2237 Fix docstring.
2238
2239 2011-09-24 Jim Meyering <meyering@redhat.com>
2240
2241 do not ignore write error for any output size
2242 The previous change was incomplete.
2243 While it makes emacs --batch detect the vast majority of stdout
2244 write failures, errors were still ignored whenever the output size is
2245 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2246 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2247 && echo FAIL: ignored write error
2248 FAIL: ignored write error
2249 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2250 && echo FAIL: ignored write error
2251 FAIL: ignored write error
2252 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2253
2254 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2255
2256 * emacs.c (Fkill_emacs): In noninteractive mode exit
2257 non-successfully if a write error occurred on stdout. (Bug#9574)
2258
2259 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2260
2261 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2262 the xassert test.
2263
2264 * dispextern.h (struct it): Update the comment documenting what
2265 can it->OBJECT be.
2266
2267 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2268
2269 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2270 a display string, extend search for cursor position to end of row.
2271 (find_row_edges): If the row ends in a newline from a display
2272 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2273 Handle the case of a display string with multiple newlines.
2274 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2275 non-empty line. Fixes confusing cursor motion with arrow keys at
2276 the beginning of a line that starts with whitespace.
2277
2278 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2279
2280 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2281 (bug#9493).
2282
2283 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2284
2285 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2286 boolean (Bug#9154).
2287
2288 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2289
2290 * xdisp.c (display_line): Record maximum and minimum buffer
2291 positions even if no glyphs were produced (e.g., by a zero-width
2292 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2293 buffer positions that will be removed from the glyph row because
2294 they don't fit.
2295 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2296 column is beyond frame width: don't subtract 1 "pixel" when
2297 computing width of the stretch.
2298 (reseat_at_next_visible_line_start): Undo the change made on
2299 2011-09-17 that saved paragraph information and restored it after
2300 the call to `reseat'. (Bug#9545)
2301
2302 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2303
2304 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2305 and turn window cursor on if cleared (Bug#9415).
2306
2307 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2308
2309 * search.c (boyer_moore): Take unibyte characters from pattern
2310 literally. (Bug#9458)
2311
2312 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2313
2314 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2315
2316 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2317
2318 Fix minor problem found by static checking.
2319 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2320 initialized, to pacify gcc -Wuninitialized.
2321
2322 * fileio.c: Report proper errno when syscall falls.
2323 (Finsert_file_contents): Save and restore errno,
2324 so that report_file_error outputs the correct diagnostic.
2325 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2326
2327 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2328
2329 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2330
2331 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2332
2333 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2334 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2335
2336 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2337
2338 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2339 about the current paragraph and restore it after the call to reseat.
2340
2341 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2342 (bidi_find_paragraph_start): Search back for paragraph beginning
2343 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2344 (bidi_move_to_visually_next): Only trigger paragraph-related
2345 computations when the last character is a newline or at EOB, not
2346 just any NEUTRAL_B. (Bug#9470)
2347
2348 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2349 truncated lines if point is covered by a display string. (Bug#9524)
2350
2351 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2352
2353 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2354 (cons_to_x_long): New function.
2355 (lisp_data_to_selection_data): Use it. Correct the test for
2356 short-versus-long data; it was negated. Break out of vector
2357 loop, for efficiency, when a long datum is discovered.
2358
2359 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2360
2361 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2362
2363 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2364
2365 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2366 GCC PR/17406) by declaring this function with external scope.
2367
2368 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2369
2370 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2371 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2372
2373 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2374
2375 * editfns.c (Fformat): Correctly handle text properties on "%%".
2376
2377 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2378
2379 * xterm.c (x_draw_composite_glyph_string_foreground):
2380 * w32term.c (x_draw_composite_glyph_string_foreground):
2381 * term.c (encode_terminal_code):
2382 * composite.c (composition_update_it, get_composition_id):
2383 * xdisp.c (get_next_display_element)
2384 (fill_composite_glyph_string): Add comments about special meaning
2385 of TAB characters in a composition.
2386
2387 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2388
2389 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2390 This occurs when processing a multibyte format.
2391 Problem reported by Wolfgang Jenker.
2392
2393 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2394
2395 * xdisp.c (try_cursor_movement): Only check for exact match if
2396 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2397
2398 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2399
2400 Remove unused external symbols.
2401 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2402 * xdisp.c (calc_pixel_width_or_height): Now static.
2403 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2404 * indent.c (check_display_width):
2405 * w32term.c: Fix comment to match code.
2406 * xterm.c, xterm.h (x_catching_errors): Remove.
2407
2408 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2409
2410 * xselect.c: Use signed conversions more consistently (Bug#9498).
2411 (selection_data_to_lisp_data): Assume incoming selection data are
2412 signed integers, not unsigned. This is to be consistent with
2413 outgoing selection data, which was modified to use signed integers
2414 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2415 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2416 expects long, not unsigned long.
2417
2418 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2419
2420 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2421 computation of loop end. Reported by Johan Bockgård
2422 <bojohan@gnu.org>.
2423
2424 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2425
2426 * frame.c (Fother_visible_frames_p): Function deleted.
2427
2428 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2429
2430 * indent.c (compute_motion): Process display vector front to back
2431 rather than the other way around. (Bug#2496)
2432
2433 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2434
2435 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2436
2437 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2438
2439 * minibuf.c (Fread_from_minibuffer): Doc fix.
2440
2441 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2442
2443 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2444 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2445
2446 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2447
2448 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2449 value for non-existent files.
2450
2451 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2452
2453 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2454 set its "size" to -1. This will set the modtime_size field of
2455 the corresponding buffer to -1, which is what
2456 verify-visited-file-modtime expects for files that do not exist.
2457 (Bug#9139)
2458
2459 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2460
2461 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2462 here ...
2463 * lisp.h: ... from here. push_key_description is no longer
2464 defined in keyboard.c, so its declaration should not be in
2465 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2466 logically belongs with push_key_description.
2467
2468 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2469
2470 * buffer.h: Include <sys/types.h> instead of <time.h>.
2471 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2472 Problem reported by Herbert J. Skuhra.
2473
2474 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2475
2476 * xml.c (parse_region): Make the parsing work for
2477 non-comment-starting XML files again (bug#9144).
2478
2479 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2480
2481 * image.c (gif_load): Fix calculation of bottom and right corner.
2482 (Bug#9468)
2483
2484 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2485
2486 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2487 redisplay in small windows.
2488
2489 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2490
2491 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2492
2493 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2494
2495 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2496 Operate on live windows only.
2497
2498 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2499
2500 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2501
2502 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2503
2504 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2505 only under bidi iteration.
2506
2507 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2508
2509 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2510
2511 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2512
2513 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2514 Without this fix, the command to link temacs failed due to an
2515 undefined symbol __builtin_isnan. This is because
2516 /usr/include/iso/math_c99.h #defines isnan(x) to
2517 __builtin_isnan(x), but the bundled gcc, which identifies itself
2518 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2519 a __builtin_isnan.
2520 * floatfns.c (isnan): #undef, and then #define to a clone of
2521 what's in data.c.
2522 (Fisnan): Always define, since it's always available now.
2523 (syms_of_floatfns): Always define isnan at the Lisp level.
2524
2525 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2526
2527 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2528
2529 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2530
2531 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2532 The previous code assumed that file offsets (off_t values) fit in
2533 EMACS_INT variables, which is not true on typical 32-bit hosts.
2534 The code messed up by falsely reporting buffer overflow in cases
2535 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2536 when "big" contains more than 2**29 bytes, even though this
2537 inserts just one byte and does not overflow the buffer.
2538 (Finsert_file_contents): Store file offsets as off_t
2539 values, not as EMACS_INT values. Check for overflow when
2540 converting between EMACS_INT and off_t. When checking for
2541 buffer overflow or for overlap, take the offsets into account.
2542 Don't use EMACS_INT for small values where int suffices.
2543 When checking for overlap, fix a typo: ZV was used where
2544 ZV_BYTE was intended.
2545 (Fwrite_region): Don't assume off_t fits into 'long'.
2546 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2547
2548 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2549
2550 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2551
2552 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2553
2554 sprintf-related integer and memory overflow issues (Bug#9412).
2555
2556 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2557 (esprintf, exprintf, evxprintf): New functions.
2558 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2559 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2560 (modify_event_symbol): Do not assume that the length of
2561 name_alist_or_stem is safe to alloca and fits in int.
2562 (Fexecute_extended_command): Likewise for function name and binding.
2563 (Frecursion_depth): Wrap around reliably on integer overflow.
2564 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2565 since some callers pass EMACS_INT values.
2566 (Fsingle_key_description): Don't crash if symbol name contains more
2567 than MAX_ALLOCA bytes.
2568 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2569 (get_minibuffer): Arg is now EMACS_INT, not int.
2570 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2571 (esprintf, exprintf, evxprintf): New decls.
2572 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2573
2574 * dbusbind.c (signature_cat): New function.
2575 (xd_signature, Fdbus_register_signal):
2576 Do not overrun buffer; instead, report string overflow.
2577
2578 * dispnew.c (add_window_display_history): Don't overrun buffer.
2579 Truncate instead; this is OK since it's just a log.
2580
2581 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2582 even if the time zone offset is outlandishly large.
2583 Don't mishandle offset == INT_MIN.
2584
2585 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2586 when creating daemon; the previous buffer-overflow check was incorrect.
2587
2588 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2589 which has the guts of the old verror function.
2590
2591 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2592 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2593
2594 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2595 (font_unparse_xlfd): Don't blindly alloca long strings.
2596 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2597 fits in int, when using sprintf. Use single snprintf to count
2598 length of string rather than counting it via multiple sprintfs;
2599 that's simpler and more reliable.
2600 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2601 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2602 sprintf, in case result does not fit in int.
2603
2604 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2605 (fontset_from_font): Print it.
2606
2607 * frame.c (tty_frame_count): Now printmax_t, not int.
2608 (make_terminal_frame, set_term_frame_name): Print it.
2609 (x_report_frame_params): In X, window IDs are unsigned long,
2610 not signed long, so print them as unsigned.
2611 (validate_x_resource_name): Check for implausibly long names,
2612 and don't assume name length fits in 'int'.
2613 (x_get_resource_string): Don't blindly alloca invocation name;
2614 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2615 not fit in int.
2616
2617 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2618 (xg_check_special_colors, xg_set_geometry):
2619 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2620
2621 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2622 Use esprintf, not sprintf, in case result does not fit in int.
2623
2624 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2625 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2626 it as a large positive number.
2627 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2628 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2629
2630 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2631 in case result does not fit in int.
2632
2633 * print.c (float_to_string): Detect width overflow more reliably.
2634 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2635 buffer overrun. Don't assume list length fits in 'int'. Treat
2636 print length of 0 as 0, not as infinity; to be consistent with other
2637 uses of print length in this function. Don't overflow print length
2638 index. Don't assume hash table size fits in 'long', or that
2639 vectorlike size fits in 'unsigned long'.
2640
2641 * process.c (make_process): Use printmax_t, not int, to format
2642 process-name gensyms.
2643
2644 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2645
2646 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2647 to avoid potential buffer overrun.
2648
2649 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2650 if X resource line is longer than 512 bytes.
2651
2652 * xfns.c (x_window): Make sprintf buffer a bit bigger
2653 to avoid potential buffer overrun.
2654
2655 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2656
2657 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2658
2659 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2660
2661 Integer overflow fixes for scrolling, etc.
2662 Without these, Emacs silently mishandles large integers sometimes.
2663 For example, "C-u 4294967297 M-x recenter" was treated as if
2664 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2665
2666 * xdisp.c (try_window_id): Check Emacs fixnum range before
2667 converting to 'int'.
2668
2669 * window.c (window_scroll_line_based, Frecenter):
2670 Check that an Emacs fixnum is in range before assigning it to 'int'.
2671 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2672 values converted from Emacs fixnums.
2673 (Frecenter): Don't wrap around a line count if it is out of 'int'
2674 range; instead, treat it as an extreme value.
2675 (Fset_window_configuration, compare_window_configurations):
2676 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2677
2678 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2679 that can exceed INT_MAX. Check that EMACS_INT value is in range
2680 before assigning it to the (possibly-narrower) index.
2681 (match_limit): Don't assume that a fixnum can fit in 'int'.
2682
2683 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2684 exceed INT_MAX.
2685
2686 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2687 (Fvertical_motion): Don't wrap around LINES values that don't fit
2688 in 'int'. Instead, treat them as extreme values. This is good
2689 enough for windows, which can't have more than INT_MAX lines anyway.
2690
2691 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2692
2693 * Require libxml/parser.h to avoid compilation warning.
2694
2695 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2696
2697 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2698 since this reportedly can destroy thread storage.
2699
2700 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2701
2702 * syntax.c (find_defun_start): Update all cache variables if
2703 exiting early (Bug#9401).
2704
2705 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2706
2707 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2708
2709 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2710 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2711 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2712
2713 * term.c (tty_append_glyph): New function.
2714 (produce_stretch_glyph): Static function and its prototype deleted.
2715
2716 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2717 Add prototypes.
2718
2719 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2720
2721 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2722 when checking :margin (Bug#9390).
2723 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2724 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2725 so that the name doesn't mislead. All uses changed.
2726
2727 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2728
2729 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2730 set_tty_hooks.
2731
2732 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2733
2734 * xdisp.c (move_it_to): Don't bail out early when reaching
2735 position beyond to_charpos, if we are scanning backwards.
2736 (move_it_vertically_backward): When DY == 0, make sure we get to
2737 the first character in the line after the newline.
2738
2739 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2740
2741 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2742 (ccl_driver): Do not generate an out-of-range pointer.
2743 (Fccl_execute_on_string): Remove unnecessary check for
2744 integer overflow, noted by Stefan Monnier in
2745 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2746 Remove a FIXME that didn't need fixing.
2747 Simplify the newly-introduced buffer reallocation code.
2748
2749 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2750
2751 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2752
2753 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2754
2755 Integer and memory overflow issues (Bug#9196).
2756
2757 * doc.c (get_doc_string): Rework so that
2758 get_doc_string_buffer_size is the actual buffer size, rather than
2759 being 1 less than the actual buffer size; this makes xpalloc more
2760 convenient.
2761
2762 * image.c (x_allocate_bitmap_record, cache_image):
2763 * xselect.c (Fx_register_dnd_atom):
2764 Simplify previous changes by using xpalloc.
2765
2766 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2767 since either will do and ptrdiff_t is convenient with xpalloc.
2768
2769 * charset.c (charset_table_size)
2770 (struct charset_sort_data.priority): Now ptrdiff_t.
2771 (charset_compare): Don't overflow if priorities differ greatly.
2772 (Fsort_charsets): Don't assume list length fits in int.
2773 Check for size-calculation overflow when allocating sort data.
2774 (syms_of_charset): Allocate an initial charset table that is
2775 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2776
2777 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2778
2779 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2780 The actual value is always <= INT_MAX, and leaving it unsigned made
2781 overflow checking harder.
2782
2783 * dispextern.h (struct glyph_matrix.rows_allocated)
2784 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2785 with xpalloc. The values are still always <= INT_MAX.
2786
2787 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2788
2789 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2790 (SAFE_NALLOCA): New macro.
2791
2792 * region-cache.c (struct boundary.pos, find_cache_boundary)
2793 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2794 (set_cache_region, invalidate_region_cache)
2795 (revalidate_region_cache, know_region_cache, region_cache_forward)
2796 (region_cache_backward, pp_cache):
2797 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2798 so that ptrdiff_t * can be passed to xpalloc.
2799 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2800 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2801 (pp_cache): Don't assume cache_len fits in int.
2802 * region-cache.h: Adjust extern decls to match.
2803
2804 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2805 EMACS_INT, since either will do, for xpalloc.
2806
2807 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2808 (xnmalloc, xnrealloc, xpalloc): New functions.
2809
2810 * bidi.c (bidi_shelve_header_size): New constant.
2811 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2812 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2813
2814 * bidi.c (bidi_cache_shrink):
2815 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2816 (overlay_strings):
2817 Don't update size of array until after memory allocation succeeds,
2818 because xmalloc/xrealloc may not return.
2819 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2820 now that we have proper integer overflow checking.
2821 (record_overlay_string, overlay_strings): Catch overflows when
2822 calculating size of overlay_str_buf.
2823
2824 * callproc.c (Fcall_process): Check for size overflow when
2825 calculating size of args2.
2826 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2827 Normally we prefer signed values, but sticking with ptrdiff_t would
2828 require adding more-complicated checks.
2829
2830 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2831 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2832 Redo buffer-overflow calculations to avoid integer overflow.
2833 Add a FIXME comment where memory seems to be over-allocated.
2834
2835 * character.c (Fstring): Check for size-calculation overflow.
2836
2837 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2838 unnecessary integer overflow. Check for size overflow.
2839 (encode_coding_object): Don't update size until xmalloc succeeds.
2840
2841 * composite.c (get_composition_id): Check for overflow in glyph
2842 length calculations.
2843
2844 Integer and memory overflow fixes for display code.
2845 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2846 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2847 (scrolling_window): Check for overflow in size calculations.
2848 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2849 Don't assume glyph table len fits in int.
2850 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2851 (row_table_size): Now ptrdiff_t, not int.
2852 (scrolling_window): Avoid overflow in size calculations.
2853 Don't update size until allocation succeeds.
2854 * fns.c (concat): Check for overflow in size calculations.
2855 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2856 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2857 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2858
2859 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2860 (get_doc_string): Check for size calculation overflow.
2861 Don't update size until allocation succeeds.
2862 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2863 EMACS_INT, where ptrdiff_t will do.
2864 (Fsubstitute_command_keys): Check for string overflow.
2865
2866 * editfns.c (set_time_zone_rule): Don't assume environment length
2867 fits in int.
2868 (message_length): Now ptrdiff_t, not int.
2869 (Fmessage_box): Don't update size until allocation succeeds.
2870 Don't assume message length fits in int.
2871 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2872
2873 * emacs.c (main): Do not reallocate argv, since there is a null at
2874 the end that can be overwritten, and this way there's no need to
2875 worry about size-calculation overflow.
2876 (sort_args): Check for size-calculation overflow.
2877
2878 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2879 alloc succeeds.
2880 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2881
2882 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2883 (x_set_scroll_bar_width, x_figure_window_size):
2884 Check for integer overflow.
2885 (x_set_alpha): Do not assume XINT fits in int.
2886
2887 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2888 This is for the members text_lines, text_cols, total_lines, total_cols,
2889 where the system imposes an 'int' limit.
2890
2891 * fringe.c (Fdefine_fringe_bitmap):
2892 Don't update size until alloc works.
2893
2894 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2895 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2896
2897 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2898 Check for size-calculation overflow.
2899 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2900 do, as we prefer signed integers.
2901 (id_to_widget.max_size, id_to_widget.used)
2902 (xg_store_widget_in_map, xg_remove_widget_from_map)
2903 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2904 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2905 Use and return ptrdiff_t, not int.
2906 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2907 * gtkutil.h: Change prototypes to match the above.
2908
2909 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2910 are duplicate now that they've been promoted to lisp.h.
2911 (x_allocate_bitmap_record, x_alloc_image_color)
2912 (make_image_cache, cache_image, xpm_load):
2913 Don't update size until alloc is done.
2914 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2915 (x_detect_edges):
2916 Check for size calculation overflow.
2917 (ct_colors_allocated_max): New constant.
2918 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2919 overflow.
2920
2921 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2922 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2923 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2924 Use ptrdiff_t, not int, to count maps.
2925 (read_char_minibuf_menu_prompt): Check for overflow in size
2926 calculations. Don't update size until allocation succeeds.
2927 Redo calculations to avoid overflow.
2928 * keyboard.h: Change prototypes to match the above.
2929
2930 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2931 to count maps.
2932 (current_minor_maps): Check for size calculation overflow.
2933 * keymap.h: Change prototypes to match the above.
2934
2935 * lread.c (read1, init_obarray): Don't update size until alloc done.
2936
2937 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2938 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2939
2940 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2941 Now ptrdiff_t, not int.
2942 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2943 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2944
2945 * process.c (Fnetwork_interface_list): Check for overflow
2946 in size calculation.
2947
2948 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2949
2950 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2951 overflow. Don't bother calling xmalloc when xrealloc will do.
2952
2953 * search.c (Freplace_match): Check for size calculation overflow.
2954 (Fset_match_data): Don't assume list lengths fit in 'int'.
2955
2956 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2957 for command line length. Do not attempt to address one before the
2958 beginning of an array, as that's not portable.
2959
2960 * term.c (max_frame_lines): Remove; unused.
2961 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2962 not int.
2963 (encode_terminal_code, calculate_costs): Check for size
2964 calculation overflow.
2965 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2966 table lengths and related sizes. Don't update size until alloc
2967 done. Redo calculations to avoid overflow.
2968 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2969
2970 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2971 subtracting pointers.
2972 (gobble_line): Check for overflow more carefully. Don't update size
2973 until alloc done.
2974
2975 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2976 Don't update size until alloc done.
2977 Redo size calculations to avoid overflow.
2978 Check for size calculation overflow.
2979 (main) [DEBUG]: Fix typo in invoking tparam1.
2980
2981 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2982 Use ptrdiff_t, not int, for sizes.
2983 (store_mode_line_noprop_char): Don't update size until alloc done.
2984
2985 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2986 Use ptrdiff_t, not int, for sizes.
2987 (Finternal_make_lisp_face, cache_face):
2988 Check for size calculation overflow.
2989 (cache_face): Treat size calculation overflows as if they were
2990 memory exhaustion (the usual treatment), rather than aborting.
2991
2992 * xfns.c (x_encode_text, x_set_name_internal)
2993 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2994 sizes, since they can exceed INT_MAX in size. Check for size
2995 calculation overflow.
2996
2997 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2998 (xg_select): Check for size calculation overflow.
2999 Don't update size until alloc done.
3000
3001 * xrdb.c (get_environ_db): Don't assume path length fits in int,
3002 as sprintf is limited to int lengths.
3003
3004 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3005 (X_LONG_MIN): New macros.
3006 Use them to make the following changes clearer.
3007 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3008 This change doesn't affect the value now, but it may help remind
3009 future maintainers not to raise the value too much later.
3010 (SELECTION_QUANTUM): Remove, replacing with ...
3011 (selection_quantum): ... new function, which avoids overflow.
3012 All uses changed.
3013 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3014 assumption that selection length fits in 'int'.
3015 (x_reply_selection_request, x_handle_selection_request)
3016 (x_get_window_property, receive_incremental_selection)
3017 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3018 (lisp_data_to_selection_data, clean_local_selection_data):
3019 Use ptrdiff_t, not int, to record length of selection.
3020 (x_reply_selection_request, x_get_window_property)
3021 (receive_incremental_selection, x_property_data_to_lisp):
3022 Redo calculations to avoid overflow.
3023 (x_reply_selection_request): When sending hint, ceiling it at
3024 X_LONG_MAX rather than relying on wraparound overflow to send
3025 something.
3026 (x_get_window_property, receive_incremental_selection)
3027 (lisp_data_to_selection_data, x_property_data_to_lisp):
3028 Check for size-calculation overflow.
3029 (x_get_window_property, receive_incremental_selection)
3030 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3031 Don't store size until memory allocation succeeds.
3032 (x_get_window_property): Plug memory leak on memory exhaustion.
3033 Don't double-block input; malloc is safe here. Don't assume 2**34
3034 - 4 fits in unsigned long. Add an xassert to check
3035 XGetWindowProperty overflow. Be more careful about overflow
3036 calculations, and distinguish size from memory overflow better.
3037 (receive_incremental_selection): When tracing, don't assume
3038 unsigned int is less than INT_MAX.
3039 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3040 harmful) conversions of unsigned short to int.
3041 (lisp_data_to_selection_data): Don't assume that integers
3042 in the range -65535 through -1 fit in an X unsigned short.
3043 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3044 result parameters unless successful. Rely on cons_to_unsigned
3045 to report problems with elements; the old code wasn't right anyway.
3046 (x_check_property_data): Check for int overflow; we cannot use
3047 a wider type due to X limits.
3048 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3049
3050 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
3051
3052 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3053 (x_term_init): Check for size calculation overflow.
3054 (x_color_cells): Don't store size until memory allocation succeeds.
3055 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
3056 Don't assume alloca size is less than MAX_ALLOCA.
3057 (x_term_init): Don't assume length fits in int (sprintf is limited
3058 to int size).
3059
3060 Use ptrdiff_t for composition IDs.
3061 * character.c (lisp_string_width):
3062 * composite.c (composition_table_size, n_compositions)
3063 (get_composition_id, composition_gstring_from_id):
3064 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3065 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3066 * window.c (Frecenter):
3067 Use ptrdiff_t, not int, for composition IDs.
3068 * composite.c (get_composition_id): Check for integer overflow.
3069 * composite.h: Adjust prototypes to match the above changes.
3070
3071 Use ptrdiff_t for hash table indexes.
3072 * category.c (hash_get_category_set):
3073 * ccl.c (ccl_driver):
3074 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3075 * coding.c (coding_system_charset_list, detect_coding_system):
3076 * coding.h (struct coding_system.id):
3077 * composite.c (get_composition_id, gstring_lookup_cache):
3078 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3079 * image.c (xpm_get_color_table_h):
3080 * lisp.h (hash_lookup, hash_put):
3081 * minibuf.c (Ftest_completion):
3082 Use ptrdiff_t for hash table indexes, not int (which is too
3083 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3084 32-bit --with-wide-int hosts).
3085
3086 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3087 Add a FIXME comment about memory leaks.
3088 (syms_of_charset): Don't assume xmalloc returns.
3089
3090 Don't assume that stated character widths fit in int.
3091 * character.c (Fchar_width, c_string_width, lisp_string_width):
3092 * character.h (CHAR_WIDTH):
3093 * indent.c (MULTIBYTE_BYTES_WIDTH):
3094 Use sanitize_char_width to avoid undefined and/or bad behavior
3095 with outlandish widths.
3096 * character.h (sanitize_tab_width): Rename from sanitize_width,
3097 now that we have two such functions. All uses changed.
3098 (sanitize_char_width): New inline function.
3099
3100 Don't assume that tab-width fits in int.
3101 * character.h (sanitize_width): New inline function.
3102 (SANE_TAB_WIDTH): New macro.
3103 (ASCII_CHAR_WIDTH): Use it.
3104 * indent.c (sane_tab_width): Remove. All uses replaced by
3105 SANE_TAB_WIDTH (current_buffer).
3106 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3107
3108 * fileio.c: Integer overflow issues with file modes.
3109 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3110
3111 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3112 Remove unreachable code.
3113 (read_hex, load_charset_map_from_file): Check for integer overflow.
3114
3115 * xterm.c: Don't go over XClientMessageEvent limit.
3116 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3117 (x_send_scroll_bar_event): Likewise. Check that the size does not
3118 exceed limits imposed by XClientMessageEvent, as well as the usual
3119 ptrdiff_t and size_t limits.
3120
3121 * keyboard.c: Overflow, signedness and related fixes.
3122 (make_lispy_movement): Use same integer type in forward decl
3123 that is used in the definition.
3124 (read_key_sequence, keyremap_step):
3125 Change bufsize argument back to int, undoing my 2011-03-30 change.
3126 We prefer signed types, and int is wide enough here.
3127 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3128 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3129 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3130 length, not size_t. Use ptrdiff_t for index, not int.
3131 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3132 possibility of integer overflow.
3133
3134 Overflow, signedness and related fixes for images.
3135
3136 * dispextern.h (struct it.stack[0].u.image.image_id)
3137 (struct_it.image_id, struct image.id, struct image_cache.size)
3138 (struct image_cache.used, struct image_cache.ref_count):
3139 * gtkutil.c (update_frame_tool_bar):
3140 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3141 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3142 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3143 * nsmenu.m (update_frame_tool_bar):
3144 * xdisp.c (calc_pixel_width_or_height):
3145 * xfns.c (image_cache_refcount):
3146 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3147 on typical 64-bit hosts.
3148
3149 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3150 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3151 Omit unnecessary casts to int.
3152 (parse_image_spec): Check that integers fall into 'int' range
3153 when the callers expect that.
3154 (image_ascent): Redo ascent calculation to avoid int overflow.
3155 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3156 (lookup_image): Remove unnecessary tests.
3157 (xbm_image_p): Locals are now of int, not EMACS_INT,
3158 since parse_image_check makes sure they fit into int.
3159 (png_load, gif_load, svg_load_image):
3160 Prefer int to unsigned where either will do.
3161 (tiff_handler): New function, combining the cores of the
3162 old tiff_error_handler and tiff_warning_handler.
3163 This function is rewritten to use vsnprintf and thereby avoid
3164 stack buffer overflows. It uses only the features of vsnprintf
3165 that are common to both POSIX and native Microsoft.
3166 (tiff_error_handler, tiff_warning_handler): Use it.
3167 (tiff_load, gif_load, imagemagick_load_image):
3168 Don't assume :index value fits in 'int'.
3169 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3170 (imagemagick_load_image): Check that crop parameters fit into
3171 the integer types that MagickCropImage accepts. Don't assume
3172 Vimagemagick_render_type has a nonnegative value. Don't assume
3173 size_t fits in 'long'.
3174 (gs_load): Use printmax_t to print the widest integers possible.
3175 Check for integer overflow when computing image height and width.
3176
3177 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3178
3179 * xdisp.c (redisplay_window): Don't force window start if point
3180 will be invisible in the resulting window. (Bug#9324)
3181
3182 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3183
3184 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3185 the display spec is of the form `(space ...)'.
3186 (handle_display_spec): Return the value returned by
3187 handle_single_display_spec, not just 1 or zero.
3188 (handle_single_display_spec): If the display spec is of the form
3189 `(space ...)', and specifies display in the text area, return 2
3190 rather than 1.
3191 (try_cursor_movement): Check for the need to scroll more
3192 accurately, and prefer exact match for point under bidi.
3193 Don't advance `row' beyond the last row of the window.
3194
3195 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3196 into disp_prop; all users changed.
3197
3198 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3199 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3200 for the text covered by the display property.
3201
3202 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3203
3204 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3205 Change return value to nil.
3206 (Frecord_buffer): Delete unused function.
3207
3208 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3209
3210 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3211 buffers, return left-to-right.
3212 (set_cursor_from_row): Consider candidate row a win if its glyph
3213 represents a newline and point is on that newline. Fixes cursor
3214 positioning on the newline at EOL of R2L text within L2R
3215 paragraph, and vice versa.
3216 (try_cursor_movement): Check continued rows, in addition to
3217 continuation rows. Fixes unwarranted scroll when point enters a
3218 continued line of R2L text within an L2R paragraph, or vice versa.
3219 (cursor_row_p): Consider the case of point being equal to
3220 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3221 from the end of a short line to the beginning of a continued line
3222 of R2L text within L2R paragraph.
3223 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3224 composed characters.
3225
3226 * bidi.c (bidi_check_type): Use xassert.
3227 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3228 members.
3229
3230 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3231
3232 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3233 a character.
3234
3235 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3236
3237 * nsfont.m (ns_otf_to_script): Fix typo.
3238
3239 2011-08-22 Kenichi Handa <handa@m17n.org>
3240
3241 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3242 extra slot even if the purpose is char-code-property-table.
3243
3244 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3245
3246 * xdisp.c (redisplay_window): When computing centering_position,
3247 account for the height of the header line. (Bug#8874)
3248
3249 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3250 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3251 candidate is selected by the mouse, and that candidate has a
3252 composed character under the mouse.
3253
3254 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3255 coordinates reported by pos-visible-in-window-p for a composed
3256 character in column zero.
3257
3258 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3259
3260 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3261
3262 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3263
3264 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3265 consider it a hit if to_charpos is anywhere in the range of the
3266 composed buffer positions.
3267
3268 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3269
3270 * image.c (gif_load): Don't assume that each subimage has the same
3271 dimensions as the base image. Handle disposal method that is
3272 "undefined" by the gif spec (Bug#9335).
3273
3274 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3275
3276 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3277 (Fcondition_case): Document `debug' symbol in error handler.
3278
3279 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3280
3281 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3282 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3283 from an Org mode buffer to a Speedbar frame.
3284
3285 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3286 a composition, take its buffer position from IT->cmp_it.charpos.
3287 Fixes cursor positioning at the beginning of a line that begins
3288 with a composed character.
3289
3290 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3291
3292 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3293 character bidirectional type, use STRONG_L instead. Fixes crashes
3294 in a buffer produced by `describe-categories'.
3295
3296 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3297 members before the level stack, so they would be saved and
3298 restored when copying iterator state. Fixes incorrect reordering
3299 around TABs covered by display properties.
3300
3301 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3302
3303 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3304
3305 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3306
3307 * eval.c (internal_condition_case, internal_condition_case_1)
3308 (internal_condition_case_2, internal_condition_case_n):
3309 Remove unnecessary aborts (Bug#9081).
3310
3311 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3312
3313 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3314 has no `load' handler, try opening the file locally. (Bug#9311)
3315
3316 2011-08-16 Ken Brown <kbrown@cornell.edu>
3317
3318 * gmalloc.c: Expand comment.
3319
3320 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3321
3322 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3323 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3324
3325 2011-08-16 Ken Brown <kbrown@cornell.edu>
3326
3327 Fix memory allocation problems in Cygwin build (Bug#9273).
3328
3329 * unexcw.c ( __malloc_initialized): Declare external variable.
3330 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3331
3332 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3333 New variables.
3334 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3335 dumped emacs.
3336 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3337 in the static heap.
3338 [CYGWIN] (special_realloc): New function.
3339 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3340 requests to realloc storage in the static heap.
3341
3342 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3343
3344 * bidi.c (bidi_initialize): Remove unused local.
3345
3346 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3347
3348 * bidimirror.h:
3349 * biditype.h: Remove file.
3350 * makefile.w32-in ($(BLD)/bidi.$(O)):
3351 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3352
3353 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3354
3355 * chartab.c: Improve commentary for the uniprop_table API.
3356
3357 * bidi.c (bidi_paragraph_init): Support zero value of
3358 bidi_ignore_explicit_marks_for_paragraph_level.
3359 (bidi_initialize): Use uniprop_table instead of including
3360 biditype.h and bidimirror.h.
3361
3362 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3363 coordinates of the iterator when restoring from ppos_it.
3364 (Bug#9296)
3365
3366 2011-08-14 Kenichi Handa <handa@m17n.org>
3367
3368 * process.c (create_process): Call setup_process_coding_systems
3369 after the pid of the process is set to -1 (Bug#8162).
3370
3371 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3372
3373 * xdisp.c (move_it_in_display_line_to): Don't invoke
3374 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3375 ppos_it. Fixes vertical cursor motion when line beginning is
3376 covered by an image. (Bug#9296)
3377
3378 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3379
3380 * nsterm.h (ns_run_ascript): Declare.
3381 (NSAPP_DATA2_RUNASSCRIPT): Define.
3382
3383 * nsfns.m (as_script, as_result, as_status): New static variables.
3384 (ns_run_ascript): New function.
3385 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3386 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3387 the event loop. Get status from as_status (Bug#7276).
3388
3389 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3390 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3391 the event loop (Bug#7276).
3392
3393 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3394
3395 * gnutls.c (QCgnutls_bootprop_priority)
3396 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3397 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3398 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3399 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3400 (QCgnutls_bootprop_verify_hostname_error)
3401 (QCgnutls_bootprop_callbacks_verify): Rename from
3402 Qgnutls_bootprop_..., all uses changed.
3403
3404 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3405 uses changed.
3406
3407 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3408
3409 * xfaces.c (Qframe_set_background_mode): Now static.
3410 * dispextern.h (Qframe_set_background_mode): Remove decl.
3411
3412 * process.c (Fnetwork_interface_info): Declare local only if needed.
3413
3414 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3415
3416 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3417 (Fnetwork_interface_list): Allocate in increments of bytes instead
3418 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3419 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3420 sockaddr.
3421 (struct ifflag_def): notrailers is smart on OSX.
3422 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3423 Get hardware address with getifaddrs if available.
3424
3425 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3426
3427 * xdisp.c (iterate_out_of_display_property): xassert that
3428 IT->position is set to within IT->object's boundaries. Break from
3429 the loop as soon as EOB is reached; avoids infloops in redisplay
3430 when IT->position is set up wrongly due to some bug.
3431 Set IT->current to match the bidi iterator unconditionally.
3432 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3433 entry. Force push_it to save on the stack the current
3434 buffer/string position, to be restored by pop_it. Fix flags in
3435 the iterator structure wrt the object coming from a display
3436 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3437 properties. (Bug#9284)
3438
3439 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3440
3441 * fontset.c (fontset_get_font_group): Add proper type checks.
3442 (Bug#9172)
3443
3444 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3445
3446 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3447 and LC_VERSION_MIN_MACOSX.
3448 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3449 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3450
3451 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3452
3453 * xdisp.c (forward_to_next_line_start): Allow to use the
3454 no-display-properties-and-no-overlays under bidi display.
3455 Set disp_pos in the bidi iterator to avoid searches for display
3456 properties and overlays.
3457
3458 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3459
3460 * editfns.c (Fset_time_zone_rule): Document relationship with the
3461 setenv function.
3462
3463 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3464 the font entity extracted from the cache (Bug#8109).
3465
3466 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3467
3468 * composite.c (autocmp_chars): Don't reset point. That is done by
3469 restore_point_unwind (Bug#5984).
3470
3471 2011-08-07 Juri Linkov <juri@jurta.org>
3472
3473 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3474 to show the arg `TIME' instead of `TIMEVAL'.
3475
3476 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3477
3478 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3479 display property strides EOL and includes a newline, as in
3480 longlines-mode. (Bug#9254)
3481 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3482 word-wrap under bidirectional display. (Bug#9224)
3483
3484 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3485 is non-zero, even if the data buffer is NULL. Fixes a crash in
3486 vertical-motion with longlines-mode. (Bug#9254)
3487
3488 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3489
3490 * bidi.c <bidi_cache_total_alloc>: Now static.
3491 (bidi_initialize): Initialize bidi_cache_total_alloc.
3492
3493 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3494 cache. (Bug#9221)
3495
3496 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3497 amount allocated this far in `bidi_cache_total_alloc'.
3498 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3499 non-zero, only free the data buffer without restoring the cache
3500 contents. All callers changed.
3501
3502 * dispextern.h (bidi_unshelve_cache): Update prototype.
3503
3504 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3505 (move_it_in_display_line, move_it_to)
3506 (move_it_vertically_backward, move_it_by_lines): Replace the call
3507 to xfree to an equivalent call to bidi_unshelve_cache.
3508 (move_it_in_display_line_to): Fix logic of returning
3509 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3510
3511 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3512
3513 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3514 came from a string character with a `cursor' property. (Bug#9229)
3515
3516 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3517
3518 * Makefile.in (LIB_PTHREAD): New variable.
3519 (LIBES): Add LIB_PTHREAD (Bug#9216).
3520
3521 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3522 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3523
3524 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3525
3526 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3527
3528 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3529
3530 * xterm.c (x_find_topmost_parent): New function.
3531 (x_set_frame_alpha): Find topmost parent window with
3532 x_find_topmost_parent and set the property there also (bug#9181).
3533 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3534
3535 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3536
3537 * callproc.c (Fcall_process): Avoid vfork clobbering
3538 the local vars buffer, coding_systems, current_dir.
3539
3540 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3541
3542 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3543
3544 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3545
3546 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3547 so that it is not optimized away.
3548
3549 * xdisp.c (compute_display_string_pos): Remove unused local.
3550
3551 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3552
3553 Fix slow cursor motion and scrolling in large buffers with
3554 selective display, like Org Mode buffers. (Bug#9218)
3555
3556 * dispextern.h (struct bidi_it): New member disp_prop_p.
3557
3558 * xdisp.c: Remove one-slot cache of display string positions.
3559 (compute_display_string_pos): Accept an additional argument
3560 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3561 for a display string or property. If found, set DISP_PROP_P
3562 non-zero.
3563
3564 * bidi.c (bidi_fetch_char): Accept an additional argument
3565 DISP_PROP_P, and pass it to compute_display_string_pos.
3566 Only handle text covered by a display string if DISP_PROP_P is returned
3567 non-zero. All callers of bidi_fetch_char changed.
3568
3569 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3570
3571 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3572
3573 2010-12-03 Don March <don@ohspite.net>
3574
3575 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3576 last character M-[char] is translated to ESC [char] (bug#7541).
3577
3578 2011-08-02 Kenichi Handa <handa@m17n.org>
3579
3580 * lisp.h (uniprop_table): Extern it.
3581
3582 * chartab.c (uniprop_table): Make it non-static.
3583
3584 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3585
3586 * xdisp.c (forward_to_next_line_start): Accept additional argument
3587 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3588 on the newline.
3589 (reseat_at_next_visible_line_start): Use the bidi iterator state
3590 returned by forward_to_next_line_start to restore the state of
3591 it->bidi_it after backing up to previous newline. (Bug#9212)
3592
3593 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3594
3595 * regex.c (re_comp): Protoize.
3596 (re_exec): Fix return type.
3597 (regexec): Fix type of `ret'. (Bug#9203)
3598
3599 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3600
3601 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3602 This is needed if max-image-size is a floating-point number.
3603
3604 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3605
3606 * print.c (print_object): Print empty symbol as ##.
3607
3608 * lread.c (read1): Read ## as empty symbol.
3609
3610 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3611
3612 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3613 setting frame foreground color (Bug#9175).
3614 (x_set_background_color): Likewise.
3615
3616 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3617 contents (Bug#9176).
3618 (EmacsTooltip -init): Remove bezels and add shadows to
3619 tooltip windows.
3620
3621 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3622 or scroll bar (Bug#8470).
3623
3624 * nsfont.m (nsfont_open): Remove assignment to voffset and
3625 unnecessary vars hshink, expand, hd, full_height, min_height.
3626 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3627
3628 * nsterm.h (nsfont_info): Remove voffset field.
3629
3630 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3631
3632 Implement strike-through and overline on NextStep (Bug#8863).
3633
3634 * nsfont.m (nsfont_open): Use underline position provided by font,
3635 instead of hard-coded value of 2.
3636 (nsfont_draw): Call ns_draw_text_decoration instead.
3637
3638 * nsterm.h: Add declaration for ns_draw_text_decoration.
3639
3640 * nsterm.m (ns_draw_text_decoration): New function for drawing
3641 underline, overline, and strike-through.
3642 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3643 ns_draw_text_decoration. Change treatment of cursor drawing to
3644 accommodate underlining, etc.
3645
3646 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3647
3648 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3649 default.
3650
3651 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3652
3653 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3654 Without this fix, if a signal arrives just after memory fills up,
3655 'malloc' might be invoked reentrantly.
3656
3657 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3658 In other words, assume that every image size is allowed, on non-X
3659 hosts. This assumption is probably wrong, but it lets Emacs compile.
3660
3661 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3662
3663 * regex.c (re_iswctype): Convert return values to boolean.
3664
3665 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3666
3667 * xdisp.c (compute_display_string_pos): Don't use cached display
3668 string position if the buffer had its restriction changed.
3669 (Bug#9184)
3670
3671 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3672
3673 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3674
3675 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3676
3677 Integer signedness and overflow and related fixes. (Bug#9079)
3678
3679 * bidi.c: Integer size and overflow fixes.
3680 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3681 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3682 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3683 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3684 (bidi_find_other_level_edge):
3685 Use ptrdiff_t instead of EMACS_INT where either will do.
3686 This works better on 32-bit hosts configured --with-wide-int.
3687 (bidi_cache_ensure_space): Check for size-calculation overflow.
3688 Use % rather than repeated addition, for better worst-case speed.
3689 Don't set bidi_cache_size until after xrealloc returns, because it
3690 might not return.
3691 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3692 (bidi_cache_ensure_space): Also check that the bidi cache size
3693 does not exceed that of the largest Lisp string or buffer. See Eli
3694 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3695
3696 * alloc.c (__malloc_size_t): Remove.
3697 All uses replaced by size_t. See Andreas Schwab's note
3698 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3699
3700 * image.c: Improve checking for integer overflow.
3701 (check_image_size): Assume that f is nonnull, since
3702 it is always nonnull in practice. This is one less thing to
3703 worry about when checking for integer overflow later.
3704 (x_check_image_size): New function, which checks for integer
3705 overflow issues inside X.
3706 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3707 This removes the need for a memory_full check.
3708 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3709 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3710 (xbm_read_bitmap_data): Change locals back to 'int', since
3711 their values must fit in 'int'.
3712 (xpm_load_image, png_load, tiff_load):
3713 Invoke x_create_x_image_and_pixmap earlier,
3714 to avoid much needless work if the image is too large.
3715 (tiff_load): Treat overly large images as if
3716 x_create_x_image_and_pixmap failed, not as malloc failures.
3717 (gs_load): Use x_check_image_size.
3718
3719 * gtkutil.c: Omit integer casts.
3720 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3721 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3722
3723 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3724
3725 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3726 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3727 would wrongly return t on a 64-bit host.
3728
3729 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3730 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3731 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3732 and therefore cause GCC to emit a bogus diagnostic in some cases.
3733
3734 * image.c: Integer signedness and overflow and related fixes.
3735 This is not an exhaustive set of fixes, but it's time to
3736 record what I've got.
3737 (lookup_pixel_color, check_image_size): Remove redundant decls.
3738 (check_image_size): Don't assume that arbitrary EMACS_INT values
3739 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3740 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3741 (tiff_load, imagemagick_load_image):
3742 Check for overflow in size calculations.
3743 (x_create_x_image_and_pixmap): Remove unnecessary test for
3744 xmalloc returning NULL; that can't happen.
3745 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3746 (xpm_color_bucket): Use better integer hashing function.
3747 (xpm_cache_color): Don't possibly over-allocate memory.
3748 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3749 (gif_memory_source):
3750 Use ptrdiff_t, not int or size_t, to record sizes.
3751 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3752 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3753 either works, as we prefer signed integers.
3754 (tiff_read_from_memory, tiff_write_from_memory):
3755 Return tsize_t, not size_t, since that's what the TIFF API wants.
3756 (tiff_read_from_memory): Don't fail simply because the read would
3757 go past EOF; instead, return a short read.
3758 (tiff_load): Omit no-longer-needed casts.
3759 (Fimagemagick_types): Don't assume size fits into 'int'.
3760
3761 Improve hashing quality when configured --with-wide-int.
3762 * fns.c (hash_string): New function, taken from sxhash_string.
3763 Do not discard information about ASCII character case; this
3764 discarding is no longer needed.
3765 (sxhash-string): Use it. Change sig to match it. Caller changed.
3766 * lisp.h: Declare it.
3767 * lread.c (hash_string): Remove, since we now use fns.c's version.
3768 The fns.c version returns a wider integer if --with-wide-int is
3769 specified, so this should help the quality of the hashing a bit.
3770
3771 * emacs.c: Integer overflow minor fix.
3772 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3773 Define only if GNU_LINUX.
3774 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3775
3776 * dispnew.c: Integer signedness and overflow fixes.
3777 Remove unnecessary forward decls, that were a maintenance hassle.
3778 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3779 All uses changed.
3780 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3781 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3782 (prepare_desired_row, line_draw_cost):
3783 Use int, not unsigned, where either works.
3784 (save_current_matrix, restore_current_matrix):
3785 Use ptrdiff_t, not size_t, where either works.
3786 (init_display): Check for overflow more accurately, and without
3787 relying on undefined behavior.
3788
3789 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3790 Remove, replacing with the new symbols in lisp.h. All uses changed.
3791 * fileio.c (make_temp_name):
3792 * filelock.c (lock_file_1, lock_file):
3793 * xdisp.c (message_dolog):
3794 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3795 Use pMd etc. instead.
3796 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3797 replacing the pWIDE etc. symbols removed from editfns.c.
3798
3799 * keyboard.h (num_input_events): Now uintmax_t.
3800 This is (very slightly) less likely to mess up due to wraparound.
3801 All uses changed.
3802
3803 * buffer.c: Integer signedness fixes.
3804 (alloc_buffer_text, enlarge_buffer_text):
3805 Use ptrdiff_t rather than size_t when either will do, as we prefer
3806 signed integers.
3807
3808 * alloc.c: Integer signedness and overflow fixes.
3809 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3810 (__malloc_size_t): Default to size_t, not to int.
3811 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3812 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3813 Prefer ptrdiff_t to size_t when either would do, as we prefer
3814 signed integers.
3815 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3816 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3817 Now const. Initialize with values that are in range even if char
3818 is signed.
3819 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3820 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3821 These functions do the right thing with sizes > 2**32.
3822 (check_depth): Now ptrdiff_t, not int.
3823 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3824 Adjust to new way of storing sizes. Check for size overflow bugs
3825 in rest of code.
3826 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3827 slightly wrong anyway, as it missed one instance of
3828 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3829 (refill_memory_reserve): Omit needless cast to size_t.
3830 (mark_object_loop_halt): Mark as externally visible.
3831
3832 * xselect.c: Integer signedness and overflow fixes.
3833 (Fx_register_dnd_atom, x_handle_dnd_message):
3834 Use ptrdiff_t, not size_t, since we prefer signed.
3835 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3836 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3837 x_dnd_atoms_size and x_dnd_atoms_length.
3838
3839 * doprnt.c: Prefer signed to unsigned when either works.
3840 * eval.c (verror):
3841 * doprnt.c (doprnt):
3842 * lisp.h (doprnt):
3843 * xdisp.c (vmessage):
3844 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3845 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3846 prefer signed arithmetic to avoid comparison confusion.
3847 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3848 but is a bit tricky.
3849
3850 Assume freestanding C89 headers, string.h, stdlib.h.
3851 * data.c, doprnt.c, floatfns.c, print.c:
3852 Include float.h unconditionally.
3853 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3854 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3855 * regex.c: Likewise for stddef.h, string.h.
3856 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3857 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3858 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3859 (STDC_HEADERS): Remove obsolete defines.
3860 * sysdep.c: Include limits.h unconditionally.
3861
3862 Assume support for memcmp, memcpy, memmove, memset.
3863 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3864 * regex.c (memcmp, memcpy):
3865 Remove; we assume C89 now.
3866
3867 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3868 (__malloc_safe_bcopy): Remove; no longer needed.
3869
3870 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3871 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3872 well either way, and we prefer signed to unsigned.
3873
3874 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3875
3876 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3877 closes the connection while we're reading (bug#9182).
3878
3879 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3880
3881 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3882 are specified (Bug#9168).
3883
3884 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3885
3886 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3887 Found by GCC static checking and --with-wide-int on a 32-bit host.
3888
3889 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3890
3891 * xdisp.c (compute_display_string_pos): Fix logic of caching
3892 previous display string position. Initialize cached_prev_pos to
3893 -1. Fixes slow-down at the beginning of a buffer.
3894
3895 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3896
3897 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3898 for attrs[LFACE_FONTSET_INDEX].
3899
3900 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3901
3902 * xml.c (parse_region): Remove unused local
3903 that was recently introduced.
3904
3905 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3906
3907 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3908 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3909
3910 * xdisp.c (move_it_in_display_line_to): Record the best matching
3911 position for TO_CHARPOS while scanning the line, and restore it on
3912 exit if none of the characters scanned was an exact match.
3913 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3914 when exact match is impossible due to invisible text, and the
3915 lines are truncated.
3916
3917 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3918
3919 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3920 for OSX >= 10.7.
3921
3922 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3923
3924 Fix a significant slow-down of cursor motion with C-n, C-p,
3925 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3926 auto-repeat under bidi redisplay in fontified buffers.
3927 * xdisp.c (compute_stop_pos_backwards): New function.
3928 (next_element_from_buffer): Call compute_stop_pos_backwards to
3929 find a suitable prev_stop when we find ourselves before
3930 base_level_stop.
3931 (reseat): Don't look for prev_stop, as that could mean a very long
3932 run.
3933 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3934 <cached_disp_overlay_modiff>: Cache for last found display string
3935 position.
3936 (compute_display_string_pos): Return the cached position if asked
3937 about the same buffer in the same area of character positions, and
3938 the buffer wasn't changed since the time the display string
3939 position was cached.
3940
3941 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3942
3943 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3944 is an integer, which is important for empty lines. (Bug#9149)
3945
3946 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3947
3948 * frame.c (Fmodify_frame_parameters): In tty case, update the
3949 default face if necessary (Bug#4238).
3950
3951 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3952
3953 * editfns.c (Fstring_to_char): No need to explain what a character
3954 is in the docstring (Bug#6576).
3955
3956 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3957
3958 * xml.c (parse_region): Make sure we always return a tree.
3959
3960 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3961
3962 * xml.c (parse_region): If a document contains only comments,
3963 return that, too.
3964
3965 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3966
3967 * xml.c (make_dom): Return comments, too.
3968
3969 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3970
3971 Port to OpenBSD.
3972 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3973 and the surrounding thread.
3974 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3975 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3976 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3977 timer goes off.
3978 * s/openbsd.h (BROKEN_SIGIO): Define.
3979 * unexelf.c (unexec) [__OpenBSD__]:
3980 Don't update the .mdebug section of the Alpha COFF symbol table.
3981
3982 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3983
3984 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3985 (bug#8460).
3986
3987 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3988
3989 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3990 This fixes some race conditions on the permissions of any newly
3991 created file.
3992
3993 * alloc.c (valid_pointer_p): Use pipe, not open.
3994 This fixes some permissions issues when debugging.
3995
3996 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3997 If fchown fails to set both uid and gid, try to set just gid,
3998 as that is sometimes allowed. Adjust the file's mode to eliminate
3999 setuid or setgid bits that are inappropriate if fchown fails.
4000
4001 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4002
4003 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4004 to compare Lisp_Objects.
4005 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4006 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4007 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4008
4009 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4010
4011 * lread.c (read_integer): Unread even EOF character.
4012 (read1): Likewise. Properly record start position of symbol.
4013
4014 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4015 symbol character follows.
4016
4017 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4018
4019 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4020 This works around a problem with the previous change to Fcopy_file.
4021 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4022 and without this change, GCC might complain about discarding
4023 fchown's return value.
4024
4025 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
4026
4027 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4028
4029 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4030
4031 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4032
4033 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4034
4035 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4036 it's used from the C level.
4037
4038 * process.c: Use the same condition for POLL_FOR_INPUT in both
4039 keyboard.c and process.c (bug#1858).
4040
4041 2011-07-09 Lawrence Mitchell <wence@gmx.li>
4042
4043 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4044 (Fgnutls_boot): Use it.
4045
4046 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4047
4048 * doc.c (Fsubstitute_command_keys): Revert last change.
4049
4050 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4051
4052 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4053 quotes the next character, and doesn't affect other longer
4054 sequences (bug#8935).
4055
4056 * lread.c (syms_of_lread): Clarify that is isn't only
4057 `eval-buffer' and `eval-defun' that's affected by
4058 `lexical-binding' (bug#8460).
4059
4060 2011-07-15 Eli Zaretskii <eliz@gnu.org>
4061
4062 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
4063 bidi redisplay when a line includes both an image and is truncated.
4064
4065 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4066
4067 Fix minor problems found by static checking.
4068 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4069 (elsz): Now a signed constant, not a size_t var. We prefer signed
4070 types to unsigned, to avoid integer comparison confusion. Without
4071 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4072 "cannot optimize loop, the loop counter may overflow", a symptom
4073 of the confusion.
4074 * indent.c (Fvertical_motion): Mark locals as initialized.
4075 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4076
4077 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4078
4079 * search.c (Fre_search_backward): Mention `case-fold-search' in
4080 all the re_search_* functions (bug#8138).
4081
4082 * keyboard.c (Fopen_dribble_file): Document when the file is
4083 closed (bug#8056).
4084
4085 2011-07-14 Eli Zaretskii <eliz@gnu.org>
4086
4087 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4088 bidi_cache_idx.
4089
4090 Support bidi reordering of display and overlay strings.
4091 * xdisp.c (compute_display_string_pos)
4092 (compute_display_string_end): Accept additional argument STRING.
4093 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4094 (reseat_to_string): Initialize bidi_it->string.s and
4095 bidi_it->string.schars.
4096 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
4097 NULL (avoids a crash in bidi_paragraph_init).
4098 Initialize itb.string.lstring.
4099 (init_iterator): Call bidi_init_it only of a valid
4100 buffer position was specified. Initialize paragraph_embedding to
4101 L2R.
4102 (reseat_to_string): Initialize the bidi iterator.
4103 (display_string): If we need to ignore text properties of
4104 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4105 original value of -1 will not work with bidi.)
4106 (compute_display_string_pos): First arg is now struct
4107 `text_pos *'; all callers changed. Support display properties on
4108 Lisp strings.
4109 (compute_display_string_end): Support display properties on Lisp
4110 strings.
4111 (init_iterator, reseat_1, reseat_to_string): Initialize the
4112 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4113 when iterating on a string not from display properties).
4114 (compute_display_string_pos, compute_display_string_end):
4115 Fix calculation of the object to scan. Fixes an error when using
4116 arrow keys.
4117 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
4118 base_level_stop; instead, set base_level_stop to BEGV.
4119 Fixes crashes in vertical-motion.
4120 (next_element_from_buffer): Improve commentary for when
4121 the iterator is before prev_stop.
4122 (init_iterator): Initialize bidi_p from the default value of
4123 bidi-display-reordering, not from buffer-local value. Use the
4124 buffer-local value only if initializing for buffer iteration.
4125 (handle_invisible_prop): Support invisible properties on strings
4126 that are being bidi-reordered.
4127 (set_iterator_to_next): Support bidi reordering of C strings and
4128 Lisp strings.
4129 (next_element_from_string): Support bidi reordering of Lisp
4130 strings.
4131 (handle_stop_backwards): Support Lisp strings as well.
4132 (display_string): Support display of R2L glyph rows.
4133 Use IT_STRING_CHARPOS when displaying from a Lisp string.
4134 (init_iterator): Don't initialize it->bidi_p for strings
4135 here.
4136 (reseat_to_string): Initialize it->bidi_p for strings here.
4137 (next_element_from_string, next_element_from_c_string)
4138 (next_element_from_buffer): Add xassert's for correspondence
4139 between IT's object being iterated and it->bidi_it.string
4140 structure.
4141 (face_before_or_after_it_pos): Support bidi iteration.
4142 (next_element_from_c_string): Handle the case of the first string
4143 character that is not the first one in the visual order.
4144 (get_visually_first_element): New function, refactored from common
4145 parts of next_element_from_buffer, next_element_from_string, and
4146 next_element_from_c_string.
4147 (tool_bar_lines_needed, redisplay_tool_bar)
4148 (display_menu_bar): Force left-to-right direction. Add a FIXME
4149 comment for making that be controlled by a user option.
4150 (push_it, pop_it): Save and restore the state of the
4151 bidi iterator. Save and restore the bidi_p flag.
4152 (pop_it): Iterate out of display property for string iteration as
4153 well.
4154 (iterate_out_of_display_property): Support iteration over strings.
4155 (handle_single_display_spec): Set up it->bidi_it for iteration
4156 over a display string, and call bidi_init_it.
4157 (handle_single_display_spec, next_overlay_string)
4158 (get_overlay_strings_1, push_display_prop): Set up the bidi
4159 iterator for displaying display or overlay strings.
4160 (forward_to_next_line_start): Don't use the shortcut if
4161 bidi-iterating.
4162 (back_to_previous_visible_line_start): If handle_display_prop
4163 pushed the iterator stack, restore the internal state of the bidi
4164 iterator by calling bidi_pop_it same number of times.
4165 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4166 and we are bidi-iterating, don't decrement the iterator position;
4167 instead, set the first_elt flag in the bidi iterator, to produce
4168 the same effect.
4169 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4170 (push_display_prop): xassert that we are iterating a buffer.
4171 (push_it, pop_it): Save and restore paragraph_embedding member.
4172 (handle_single_display_spec, next_overlay_string)
4173 (get_overlay_strings_1, reseat_1, reseat_to_string)
4174 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4175 correctly. Don't assume unibyte strings are not bidi-reordered.
4176 (compute_display_string_pos)
4177 (compute_display_string_end): Fix handling the case of C string.
4178 (push_it, pop_it): Save and restore from_disp_prop_p.
4179 (handle_single_display_spec, push_display_prop): Set the
4180 from_disp_prop_p flag.
4181 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4182 (pop_it): Call iterate_out_of_display_property only if we are
4183 popping after iteration over a string that came from a display
4184 property. Fix a typo in popping stretch info. Add an assertion
4185 for verifying that the iterator position is in sync with the bidi
4186 iterator.
4187 (handle_single_display_spec, get_overlay_strings_1)
4188 (push_display_prop): Fix initialization of paragraph direction for
4189 string when that of the parent object is not yet determined.
4190 (reseat_1): Call bidi_init_it to resync the bidi
4191 iterator with IT's position. (Bug#7616)
4192 (find_row_edges): If ROW->start.pos gives position
4193 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4194 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4195 Reset the from_disp_prop_p flag.
4196 (SAVE_IT, RESTORE_IT): New macros.
4197 (pos_visible_p, face_before_or_after_it_pos)
4198 (back_to_previous_visible_line_start)
4199 (move_it_in_display_line_to, move_it_in_display_line)
4200 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4201 (try_scrolling, redisplay_window, display_line): Use them when
4202 saving a temporary copy of the iterator and restoring it back.
4203 (back_to_previous_visible_line_start, reseat_1)
4204 (init_iterator): Empty the bidi cache "stack".
4205 (move_it_in_display_line_to): If iterator ended up at
4206 EOL, but we never saw any buffer positions smaller than
4207 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4208 motion in bidi-reordered lines.
4209 (move_it_in_display_line_to): Record prev_method and prev_pos
4210 immediately before the call to set_iterator_to_next. Fixes cursor
4211 motion in bidi-reordered lines with stretch glyphs and strings
4212 displayed in margins. (Bug#8133) (Bug#8867)
4213 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4214 TO_CHARPOS.
4215 (pos_visible_p): Support positions in bidi-reordered lines.
4216 Save and restore bidi cache.
4217
4218 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4219 (bidi_paragraph_info): Delete unused struct.
4220 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4221 (bidi_cache_start): New variable.
4222 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4223 to zero.
4224 (bidi_cache_fetch_state, bidi_cache_search)
4225 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4226 (bidi_cache_find, bidi_peek_at_next_level)
4227 (bidi_level_of_next_char, bidi_find_other_level_edge)
4228 (bidi_move_to_visually_next): Compare cache index with
4229 bidi_cache_start rather than with zero.
4230 (bidi_fetch_char): Accept new argument STRING; all callers
4231 changed. Support iteration over a string. Support strings with
4232 display properties. Support unibyte strings. Fix the type of
4233 `len' according to what STRING_CHAR_AND_LENGTH expects.
4234 (bidi_paragraph_init, bidi_resolve_explicit_1)
4235 (bidi_resolve_explicit, bidi_resolve_weak)
4236 (bidi_level_of_next_char, bidi_move_to_visually_next):
4237 Support iteration over a string.
4238 (bidi_set_sor_type, bidi_resolve_explicit_1)
4239 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4240 can now be zero (for strings); special values 0 and -1 were
4241 changed to -1 and -2, respectively.
4242 (bidi_char_at_pos): New function.
4243 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4244 Call it instead of FETCH_MULTIBYTE_CHAR.
4245 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4246 initialized to valid values.
4247 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4248 values.
4249 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4250 the test for valid cached positions. Fix the logic for looking up
4251 the sentinel state in the cache. GCPRO the Lisp string we are
4252 iterating.
4253 (bidi_push_it, bidi_pop_it): New functions.
4254 (bidi_initialize): Initialize the bidi cache start stack pointer.
4255 (bidi_cache_ensure_space): New function, refactored from part of
4256 bidi_cache_iterator_state. Don't assume the required size is just
4257 one BIDI_CACHE_CHUNK away.
4258 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4259 (bidi_count_bytes, bidi_char_at_pos): New functions.
4260 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4261 always valid if bidi_cache_idx is valid.
4262 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4263 is valid if it's going to be used.
4264 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4265 (bidi_cache_fetch_state, bidi_cache_search)
4266 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4267 (bidi_cache_iterator_state, bidi_cache_find)
4268 (bidi_find_other_level_edge, bidi_cache_start_stack):
4269 All variables related to cache indices are now EMACS_INT.
4270
4271 * dispextern.h (struct bidi_string_data): New structure.
4272 (struct bidi_it): New member `string'. Make flag members be 1-bit
4273 fields, and put them last in the struct.
4274 (compute_display_string_pos, compute_display_string_end):
4275 Update prototypes.
4276 (bidi_push_it, bidi_pop_it): Add prototypes.
4277 (struct iterator_stack_entry): New members bidi_p,
4278 paragraph_embedding, and from_disp_prop_p.
4279 (struct it): Member bidi_p is now a bit field 1 bit wide.
4280 (bidi_shelve_cache, bidi_unshelve_cache):
4281 Declare prototypes.
4282
4283 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4284 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4285 and vector-like objects.
4286
4287 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4288 cache around display iteration.
4289
4290 * window.c (Fwindow_end, window_scroll_pixel_based)
4291 (displayed_window_lines, Frecenter): Save and restore the bidi
4292 cache around display iteration.
4293
4294 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4295
4296 * editfns.c (Fdelete_region): Clarify the use of the named
4297 parameters (bug#6788).
4298
4299 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4300
4301 * indent.c (Fvertical_motion): Set and restore w->pointm when
4302 saving and restoring the window's buffer (Bug#9006).
4303
4304 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4305
4306 * editfns.c (Fstring_to_char): Clarify just what is returned
4307 (bug#6576). Text by Eli Zaretskii.
4308
4309 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4310
4311 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4312
4313 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4314
4315 * buffer.c (mmap_find): Fix a typo.
4316
4317 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4318
4319 Fix execution of x selection hooks.
4320 * xselect.c (Qx_lost_selection_functions)
4321 (Qx_sent_selection_functions): New vars.
4322 (syms_of_xselect): DEFSYM them.
4323 (x_handle_selection_request): Pass Qx_sent_selection_functions
4324 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4325 (x_handle_selection_clear,x_clear_frame_selections):
4326 Pass Qx_lost_selection_functions rather than
4327 Vx_lost_selection_functions to Frun_hook_with_args.
4328
4329 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4330
4331 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4332 The old code sometimes used this field without initializing it.
4333
4334 * alloc.c (gc_sweep): Don't read past end of array.
4335 In theory, the old code could also have corrupted Emacs internals,
4336 though it'd be very unlikely.
4337
4338 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4339
4340 * character.c (Fcharacterp): Don't advertise optional ignored
4341 argument. (Bug#4026)
4342
4343 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4344
4345 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4346 key" (bug#4257).
4347
4348 * window.c (Fset_window_start): Doc fix (bug#4199).
4349 (Fset_window_hscroll): Ditto.
4350
4351 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4352
4353 Fix minor new problems caught by GCC 4.6.1.
4354 * term.c (init_tty): Remove unused local.
4355 * xsettings.c (store_monospaced_changed): Define this function only
4356 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4357 not used otherwise.
4358
4359 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4360
4361 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4362
4363 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4364
4365 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4366 are the mini-buffer and the echo area (bug#3320).
4367
4368 * term.c (init_tty): Remove support for supdup, c10 and perq
4369 terminals, which are no longer supported (bug#1482).
4370
4371 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4372
4373 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4374
4375 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4376
4377 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4378 for non-popups (Bug#3642).
4379
4380 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4381
4382 * alloc.c (reset_malloc_hooks): Protoize.
4383 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4384 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4385 * cm.c (losecursor): Likewise.
4386 * data.c (fmod): Likewise.
4387 * dispnew.c (swap_glyphs_in_rows): Likewise.
4388 * emacs.c (memory_warning_signal): Likewise.
4389 * floatfns.c (float_error): Likewise.
4390 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4391 (otf_open, font_otf_capability, generate_otf_features)
4392 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4393 Likewise.
4394 * image.c (pbm_read_file): Likewise.
4395 * indent.c (string_display_width): Likewise.
4396 * intervals.c (check_for_interval, search_for_interval)
4397 (inc_interval_count, count_intervals, root_interval)
4398 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4399 * lread.c (defalias): Likewise.
4400 * ralloc.c (r_alloc_check): Likewise.
4401 * regex.c (set_image_of_range_1, set_image_of_range)
4402 (regex_grow_registers): Likewise.
4403 * sysdep.c (strerror): Likewise.
4404 * termcap.c (valid_filename_p, tprint, main): Likewise.
4405 * tparam.c (main): Likewise.
4406 * unexhp9k800.c (run_time_remap, save_data_space)
4407 (update_file_ptrs, read_header, write_header, calculate_checksum)
4408 (copy_file, copy_rest, display_header): Likewise.
4409 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4410 Likewise.
4411 * xdisp.c (check_it): Likewise.
4412 * xfaces.c (register_color, unregister_color, unregister_colors):
4413 Likewise.
4414 * xfns.c (print_fontset_result): Likewise.
4415 * xrdb.c (member, fatal, main): Likewise.
4416
4417 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4418
4419 Fix minor problems found by static checking (Bug#9031).
4420 * chartab.c (char_table_set_range, map_sub_char_table):
4421 Remove unused locals.
4422 (uniprop_table): Now static.
4423 * composite.c (_work_char): Remove unused static var.
4424
4425 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4426
4427 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4428
4429 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4430
4431 * gtkutil.c (qttip_cb): Remove code without function.
4432
4433 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4434
4435 * w32.c (pthread_sigmask): New stub.
4436
4437 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4438
4439 Use pthread_sigmask, not sigprocmask (Bug#9010).
4440 sigprocmask is portable only for single-threaded applications, and
4441 Emacs can be multi-threaded when it uses GTK.
4442 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4443 (LIBES): Use it.
4444 * callproc.c (Fcall_process):
4445 * process.c (create_process):
4446 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4447 Use pthread_sigmask, not sigprocmask.
4448
4449 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4450
4451 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4452 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4453 wrong (Bug#8591).
4454
4455 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4456
4457 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4458 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4459 (xg_hide_tooltip): Fix comment.
4460
4461 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4462 in registerServicesMenuSendTypes.
4463 (validRequestorForSendType): Don't check ns_return_types.
4464
4465 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4466 ns_return_type.
4467
4468 2011-07-08 Jason Rumney <jasonr@gnu.org>
4469
4470 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4471 SH_SHOW for hidden windows (Bug#5482).
4472
4473 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4474 frame struct members of non-existent frames (Bug#6284).
4475
4476 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4477
4478 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4479 variable firstTime not needed on OSX >= 10.6.
4480 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4481 >= 10.5. Use setKnobProportion, setDoubleValue.
4482
4483 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4484 (MAC_OS_X_VERSION_10_5): Define if not defined.
4485 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4486 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4487 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4488
4489 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4490 cString and lossyCString on OSX >= 10.4
4491
4492 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4493 sizeToFit on OSX >= 10.2.
4494
4495 * nsimage.m (allocInitFromFile): Don't use deprecated method
4496 bestRepresentationForDevice on OSX >= 10.6.
4497
4498 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4499 to avoid warning.
4500
4501 * emacs.c: Declare unexec_init_emacs_zone.
4502
4503 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4504
4505 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4506
4507 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4508 on svcsMenu (Bug#8842).
4509
4510 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4511 ns_return_types.
4512 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4513
4514 * nsterm.m (QUTF8_STRING): Declare.
4515 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4516 (validRequestorForSendType): Return type is (id).
4517 Change indexOfObjectIdenticalTo to indexOfObject.
4518 Check if we have local selection before returning self (Bug#8842).
4519 (writeSelectionToPasteboard): Put local selection into paste board
4520 if we have a local selection (Bug#8842).
4521 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4522
4523 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4524 (ns_get_local_selection): Declare.
4525
4526 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4527
4528 * keymap.c (describe_map_tree): Don't insert a double newline at
4529 the end of the buffer (bug#1169) and return whether we inserted
4530 something.
4531
4532 * callint.c (Fcall_interactively): Change "reading args" to
4533 "providing args" to try to clarify what it does (bug#1010).
4534
4535 2011-07-07 Kenichi Handa <handa@m17n.org>
4536
4537 * composite.c (composition_compute_stop_pos): Ignore a static
4538 composition starting before CHARPOS (Bug#8915).
4539
4540 * xdisp.c (handle_composition_prop): Likewise.
4541
4542 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4543
4544 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4545 (Bug#9015)
4546
4547 2011-07-07 Kenichi Handa <handa@m17n.org>
4548
4549 * character.h (unicode_category_t): New enum type.
4550
4551 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4552 (Qchar_code_property_table): New variable.
4553 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4554 (UNIPROP_COMPRESSED_FORM_P): New macros.
4555 (char_table_ascii): Uncompress the compressed values.
4556 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4557 Uncompress the compressed values.
4558 (sub_char_table_ref_and_range): Likewise.
4559 (char_table_ref_and_range): Uncompress the compressed values.
4560 (sub_char_table_set): New arg is_uniprop. Callers changed.
4561 Uncompress the compressed values.
4562 (sub_char_table_set_range): Args changed. Callers changed.
4563 (char_table_set_range): Adjuted for the above change.
4564 (map_sub_char_table): Delete args default_val and parent. Add arg
4565 top. Give decoded values to a Lisp function.
4566 (map_char_table): Adjust for the above change. Give decoded
4567 values to a Lisp function. Gcpro more variables.
4568 (uniprop_table_uncompress)
4569 (uniprop_decode_value_run_length): New functions.
4570 (uniprop_decoder, uniprop_decoder_count): New variables.
4571 (uniprop_get_decoder, uniprop_encode_value_character)
4572 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4573 New functions.
4574 (uniprop_encoder, uniprop_encoder_count): New variables.
4575 (uniprop_get_encoder, uniprop_table)
4576 (Funicode_property_table_internal, Fget_unicode_property_internal)
4577 (Fput_unicode_property_internal): New functions.
4578 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4579 Sunicode_property_table_internal, Sget_unicode_property_internal,
4580 and Sput_unicode_property_internal. Defvar_lisp
4581 char-code-property-alist.
4582
4583 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4584 Vunicode_category_table.
4585
4586 * font.c (font_range): Adjust for the change of
4587 Vunicode_category_table.
4588
4589 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4590
4591 * m/iris4d.h: Remove file, move contents ...
4592 * s/irix6-5.h: ... here.
4593
4594 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4595
4596 Remove unportable assumption about struct layout (Bug#8884).
4597 * alloc.c (mark_buffer):
4598 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4599 (clone_per_buffer_values): Don't assume that
4600 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4601 This isn't true in general, and it's particularly not true
4602 if Emacs is configured with --with-wide-int.
4603 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4604 New macros, used in the buffer.c change.
4605
4606 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4607
4608 * xsettings.c: Use both GConf and GSettings if both are available.
4609 (store_config_changed_event): Add comment.
4610 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4611 (store_tool_bar_style_changed): New functions.
4612 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4613 (struct xsettings): Move font inside HAVE_XFT.
4614 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4615 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4616 Move inside HAVE_XFT.
4617 (something_changed_gsettingsCB): Rename from something_changedCB.
4618 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4619 also.
4620 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4621 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4622 (something_changed_gconfCB): Rename from something_changedCB.
4623 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4624 (parse_settings): Move check for font inside HAVE_XFT.
4625 (read_settings, apply_xft_settings): Add comment.
4626 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4627 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4628 call store_font_name_changed.
4629 (xft_settings_event): Add comment.
4630 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4631 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4632 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4633 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4634 (xsettings_initialize): Call init_gsettings last.
4635 (xsettings_get_system_font, xsettings_get_system_normal_font):
4636 Add comment.
4637
4638 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4639
4640 Random fixes. E.g., (random) never returned negative values.
4641 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4642 subseconds part to the entropy, as that's a bit more random.
4643 Prefer signed to unsigned, since the signedness doesn't matter and
4644 in general we prefer signed. When given a limit, use a
4645 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4646 latter isn't right if USE_2_TAGS_FOR_INTS.
4647 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4648 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4649
4650 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4651
4652 * textprop.c (text_property_stickiness):
4653 Obey Vtext_property_default_nonsticky.
4654 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4655 * w32fns.c (syms_of_w32fns):
4656 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4657
4658 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4659
4660 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4661 This is more efficient than Ffile_directory_p and avoids a minor race.
4662
4663 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4664
4665 * buffer.c (Foverlay_put): Say what the return value is
4666 (bug#7835).
4667
4668 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4669 is a directory before asking whether to use the file name
4670 (bug#7564).
4671 (barf_or_query_if_file_exists): Make the "File is a directory"
4672 error be more correct.
4673
4674 * fns.c (Frequire): Remove the mention of the .gz files, since
4675 that's installation-specific, but keep the mention of
4676 `get-load-suffixes'.
4677
4678 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4679
4680 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4681 Report string overflow if the output is too long.
4682
4683 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4684
4685 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4686 (syms_of_gnutls): Remove duplicate DEFSYM for
4687 Qgnutls_bootprop_verify_hostname_error, an error for
4688 Qgnutls_bootprop_verify_error (which is no longer used).
4689
4690 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4691 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4692 Also (re)move comments that are misplaced or no longer relevant.
4693
4694 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4695
4696 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4697
4698 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4699
4700 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4701 and background color parameters if they have been changed.
4702
4703 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4704
4705 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4706
4707 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4708
4709 * xsettings.c (SYSTEM_FONT): Define only when used.
4710 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4711
4712 * keymap.c (access_keymap_1): Now static.
4713
4714 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4715
4716 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4717 leave any prefix arg for the up event (Bug#1586).
4718
4719 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4720
4721 * lread.c (syms_of_lread): Mention single symbols defined by
4722 `defvar' or `defconst' (bug#7154).
4723
4724 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4725 (Frequire): Mention get-load-suffixes.
4726
4727 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4728
4729 * window.h (window): Remove clone_number slot.
4730 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4731 Remove.
4732 (make_parent_window, make_window, saved_window)
4733 (Fset_window_configuration, save_window_save): Don't deal with
4734 clone numbers.
4735 * buffer.c (Qclone_number): Remove declaration.
4736 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4737
4738 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4739
4740 Add multiple inheritance to keymaps.
4741 * keymap.c (Fmake_composed_keymap): New function.
4742 (Fset_keymap_parent): Simplify.
4743 (fix_submap_inheritance): Remove.
4744 (access_keymap_1): New function extracted from access_keymap to handle
4745 embedded parents and handle lists of maps.
4746 (access_keymap): Use it.
4747 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4748 (Fcopy_keymap): Handle embedded parents.
4749 (Fcommand_remapping, define_as_prefix): Simplify.
4750 (Fkey_binding): Simplify.
4751 (syms_of_keymap): Move minibuffer-local-completion-map,
4752 minibuffer-local-filename-completion-map,
4753 minibuffer-local-must-match-map, and
4754 minibuffer-local-filename-must-match-map to Elisp.
4755 (syms_of_keymap): Defsubr make-composed-keymap.
4756 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4757 (parse_menu_item): Trivial simplification.
4758
4759 2011-07-01 Glenn Morris <rgm@gnu.org>
4760
4761 * Makefile.in (SETTINGS_LIBS): Fix typo.
4762
4763 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4764
4765 * coding.c (Fencode_coding_string): Record the last coding system
4766 used, as the function doc string says (bug#8738).
4767
4768 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4769
4770 * xsettings.c (store_monospaced_changed): Take new font as arg and
4771 check for change against current_mono_font.
4772 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4773 (emacs_settings_constructor, emacs_settings_get_property)
4774 (emacs_settings_set_property, emacs_settings_class_init)
4775 (emacs_settings_init, gsettings_obj): Remove.
4776 (something_changedCB): New function for HAVE_GSETTINGS.
4777 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4778 with value as argument.
4779 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4780 g_settings_new (Bug#8967). Do not create gsettings_obj.
4781 Remove calls to g_settings_bind. Connect something_changedCB to
4782 "changed".
4783
4784 * xgselect.c: Add defined (HAVE_GSETTINGS).
4785 (xgselect_initialize): Ditto.
4786
4787 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4788 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4789 xg_select.
4790
4791 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4792
4793 * eval.c (struct backtrace): Simplify and port the data structure.
4794 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4795 signed bit field, as this assumption is not portable and it makes
4796 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4797 "char debug_on_exit : 1" as this is not portable either; instead,
4798 use the portable "unsigned int debug_on_exit : 1". Remove unused
4799 member evalargs. Remove obsolete comments about cc bombing out.
4800
4801 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4802
4803 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4804 Let HAVE_GSETTINGS override HAVE_GCONF.
4805 (store_monospaced_changed): New function.
4806 (EMACS_SETTINGS): A new type derived from GObject to handle
4807 GSettings notifications.
4808 (emacs_settings_constructor, emacs_settings_get_property)
4809 (emacs_settings_set_property, emacs_settings_class_init):
4810 New functions.
4811 (gsettings_client, gsettings_obj): New variables.
4812 (GSETTINGS_SCHEMA): New define.
4813 (something_changedCB): Call store_monospaced_changed.
4814 (init_gsettings): New function.
4815 (xsettings_initialize): Call init_gsettings.
4816 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4817 to NULL.
4818
4819 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4820 GCONF_CFLAGS/LIBS.
4821
4822 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4823
4824 * window.c (resize_root_window, grow_mini_window)
4825 (shrink_mini_window): Rename Qresize_root_window to
4826 Qwindow_resize_root_window and Qresize_root_window_vertically to
4827 Qwindow_resize_root_window_vertically.
4828
4829 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4830
4831 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4832
4833 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4834
4835 * makefile.w32-in: Redesign dependencies so they reflect more
4836 clearly which files are directly included by each source file,
4837 and not through other includes.
4838
4839 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4840
4841 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4842 (sort_overlays, overlay_strings): When an overlay's clone number
4843 matches the window's clone number process the overlay even if
4844 the overlay's window property doesn't match the current window.
4845
4846 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4847 (Fwindow_hchild): Rename to Fwindow_left_child.
4848 (Fwindow_next): Rename to Fwindow_next_sibling.
4849 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4850 (resize_window_check): Rename to window_resize_check.
4851 (resize_window_apply): Rename to window_resize_apply.
4852 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4853 (Fdelete_other_windows_internal, resize_frame_windows)
4854 (Fsplit_window_internal, Fdelete_window_internal)
4855 (grow_mini_window, shrink_mini_window)
4856 (Fresize_mini_window_internal): Fix callers accordingly.
4857
4858 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4859
4860 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4861 (emacs_fixed_set_min_size): Remove.
4862 (emacs_fixed_new): Take frame as argument.
4863
4864 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4865 (_EmacsFixedPrivate): Remove minwidth/height.
4866 Add struct frame *f.
4867 (emacs_fixed_init): Initialize priv->f.
4868 (get_parent_class, emacs_fixed_set_min_size): Remove.
4869 (emacs_fixed_new): Set priv->f to argument.
4870 (emacs_fixed_get_preferred_width)
4871 (emacs_fixed_get_preferred_height): Use min_width/height from
4872 frames size_hint to set minimum and natural (Bug#8919).
4873 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4874 and use min_width/height from frames size_hint to set
4875 min_width/height (Bug#8919).
4876
4877 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4878 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4879 Fix indentation.
4880
4881 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4882
4883 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4884 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4885 called at ZV.
4886
4887 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4888
4889 * process.c (wait_reading_process_output): Bypass select if
4890 waiting for a cell while ignoring keyboard input, and input is
4891 pending. Suggested by Jan Djärv (Bug#8869).
4892
4893 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4894
4895 Use gnulib's dup2 module instead of rolling our own.
4896 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4897
4898 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4899
4900 * dispnew.c (scrolling_window): Before scrolling, turn off a
4901 mouse-highlight in the window being scrolled.
4902
4903 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4904
4905 Move DEFSYM to lisp.h and use everywhere.
4906
4907 * character.h (DEFSYM): Move declaration...
4908 * lisp.h (DEFSYM): ...here.
4909
4910 * gnutls.c:
4911 * minibuf.c:
4912 * w32menu.c:
4913 * w32proc.c:
4914 * w32select.c: Don't include character.h.
4915
4916 * alloc.c (syms_of_alloc):
4917 * buffer.c (syms_of_buffer):
4918 * bytecode.c (syms_of_bytecode):
4919 * callint.c (syms_of_callint):
4920 * casefiddle.c (syms_of_casefiddle):
4921 * casetab.c (init_casetab_once):
4922 * category.c (init_category_once, syms_of_category):
4923 * ccl.c (syms_of_ccl):
4924 * cmds.c (syms_of_cmds):
4925 * composite.c (syms_of_composite):
4926 * dbusbind.c (syms_of_dbusbind):
4927 * dired.c (syms_of_dired):
4928 * dispnew.c (syms_of_display):
4929 * doc.c (syms_of_doc):
4930 * editfns.c (syms_of_editfns):
4931 * emacs.c (syms_of_emacs):
4932 * eval.c (syms_of_eval):
4933 * fileio.c (syms_of_fileio):
4934 * fns.c (syms_of_fns):
4935 * frame.c (syms_of_frame):
4936 * fringe.c (syms_of_fringe):
4937 * insdel.c (syms_of_insdel):
4938 * keymap.c (syms_of_keymap):
4939 * lread.c (init_obarray, syms_of_lread):
4940 * macros.c (syms_of_macros):
4941 * msdos.c (syms_of_msdos):
4942 * print.c (syms_of_print):
4943 * process.c (syms_of_process):
4944 * search.c (syms_of_search):
4945 * sound.c (syms_of_sound):
4946 * syntax.c (init_syntax_once, syms_of_syntax):
4947 * terminal.c (syms_of_terminal):
4948 * textprop.c (syms_of_textprop):
4949 * undo.c (syms_of_undo):
4950 * w32.c (globals_of_w32):
4951 * window.c (syms_of_window):
4952 * xdisp.c (syms_of_xdisp):
4953 * xfaces.c (syms_of_xfaces):
4954 * xfns.c (syms_of_xfns):
4955 * xmenu.c (syms_of_xmenu):
4956 * xsettings.c (syms_of_xsettings):
4957 * xterm.c (syms_of_xterm): Use DEFSYM.
4958
4959 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4960
4961 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4962
4963 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4964
4965 Integer and buffer overflow fixes (Bug#8873).
4966
4967 * print.c (printchar, strout): Check for string overflow.
4968 (PRINTPREPARE, printchar, strout):
4969 Don't set size unless allocation succeeds.
4970
4971 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4972 for sizes. Check for string overflow more accurately.
4973 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4974
4975 * macros.c: Integer and buffer overflow fixes.
4976 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4977 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4978 Use ptrdiff_t, not int, for sizes.
4979 Don't increment bufsize until after realloc succeeds.
4980 Check for size-calculation overflow.
4981 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4982
4983 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4984
4985 * lread.c: Integer overflow fixes.
4986 (read_integer): Radix is now EMACS_INT, not int,
4987 to improve quality of diagnostics for out-of-range radices.
4988 Calculate buffer size correctly for out-of-range radices.
4989 (read1): Check for integer overflow in radices, and in
4990 read-circle numbers.
4991 (read_escape): Avoid int overflow.
4992 (Fload, openp, read_buffer_size, read1)
4993 (substitute_object_recurse, read_vector, read_list, map_obarray):
4994 Use ptrdiff_t, not int, for sizes.
4995 (read1): Use EMACS_INT, not int, for sizes.
4996 Check for size overflow.
4997
4998 * image.c (cache_image): Check for size arithmetic overflow.
4999
5000 * lread.c: Integer overflow issues.
5001 (saved_doc_string_size, saved_doc_string_length)
5002 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5003 Now ptrdiff_t, not int.
5004 (read1): Don't assume doc string length fits in int. Check for
5005 out-of-range doc string lengths.
5006 (read_list): Don't assume file position fits in int.
5007 (read_escape): Check for hex character overflow.
5008
5009 2011-06-22 Leo Liu <sdl.web@gmail.com>
5010
5011 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5012 Move to minibuffer.el.
5013
5014 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5015
5016 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
5017 The following patches are for when GLYPH_DEBUG && !XASSERT.
5018 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5019 * dispnew.c (flush_stdout):
5020 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5021 Mark as externally visible.
5022 * dispnew.c (check_window_matrix_pointers): Now static.
5023 * dispnew.c (window_to_frame_vpos):
5024 * xfns.c (unwind_create_frame):
5025 * xterm.c (x_check_font): Remove unused local.
5026 * scroll.c (CHECK_BOUNDS):
5027 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5028 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5029 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5030 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5031 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5032 Now static.
5033 (debug_method_add): Use va_list and vsprintf rather than relying
5034 on undefined behavior with wrong number of arguments.
5035 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5036 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5037 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5038 since we're not interested in debugging glyphs with old libraries.
5039 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5040 GCC 4.6.0's static checking.
5041
5042 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5043
5044 Integer overflow and signedness fixes (Bug#8873).
5045 A few related buffer overrun fixes, too.
5046
5047 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5048
5049 * dispextern.h (struct face.stipple):
5050 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5051 (x_bitmap_mask, x_allocate_bitmap_record)
5052 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5053 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5054 (x_create_bitmap_from_xpm_data):
5055 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5056 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5057 (.bitmaps_last):
5058 * xfaces.c (load_pixmap):
5059 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5060 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5061 (.bitmaps_last, struct x_output.icon_bitmap):
5062 Use ptrdiff_t, not int, for bitmap indexes.
5063 (x_allocate_bitmap_record): Check for size overflow.
5064 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5065
5066 Use ptrdiff_t, not int, for overlay counts.
5067 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5068 * editfns.c (overlays_around, get_pos_property):
5069 * textprop.c (get_char_property_and_overlay):
5070 * xdisp.c (next_overlay_change, note_mouse_highlight):
5071 * xfaces.c (face_at_buffer_position):
5072 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5073 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5074 (Fnext_overlay_change, Fprevious_overlay_change)
5075 (mouse_face_overlay_overlaps, Foverlays_in):
5076 Use ptrdiff_t, not int, for sizes.
5077 (overlays_at, overlays_in): Check for size-calculation overflow.
5078
5079 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5080
5081 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5082 (x_session_initialize): Do not assume string length fits in int.
5083
5084 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5085 This is unlikely, but can occur if DPI is outlandish.
5086
5087 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
5088 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5089
5090 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5091 * xrdb.c (magic_file_p, search_magic_path):
5092 Omit last arg SUFFIX; it was always 0. All callers changed.
5093 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5094
5095 * xfont.c (xfont_match): Avoid need for strlen.
5096
5097 * xfns.c: Don't assume strlen fits in int.
5098 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5099
5100 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5101 not unsigned long, as we prefer signed integers. All callers changed.
5102 Detect integer overflow in repeat count.
5103 (message_dolog): Don't assume print length fits in 39 bytes.
5104 (display_mode_element): Don't assume strlen fits in int.
5105
5106 * termcap.c: Don't assume sizes fit in int and never overflow.
5107 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5108 (gobble_line): Check for size-calculation overflow.
5109
5110 * minibuf.c (Fread_buffer):
5111 * lread.c (intern, intern_c_string):
5112 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5113 Don't assume string length fits in int.
5114
5115 * keyboard.c (parse_tool_bar_item):
5116 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5117
5118 * font.c: Don't assume string length fits in int.
5119 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5120 Use ptrdiff_t, not int.
5121 (font_intern_prop): Don't assume string length fits in int.
5122 Don't assume integer property fits in fixnum.
5123 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
5124
5125 * filelock.c: Fix some buffer overrun and integer overflow issues.
5126 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
5127 Reformulate so as not to need the command string.
5128 Invoke gzip -cd rather than gunzip, as it's more portable.
5129 (lock_info_type, lock_file_1, lock_file):
5130 Don't assume pid_t and time_t fit in unsigned long.
5131 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5132 (current_lock_owner): Prefer signed type for sizes.
5133 Use memcpy, not strncpy, where memcpy is what is really wanted.
5134 Don't assume (via atoi) that time_t and pid_t fit in int.
5135 Check for time_t and/or pid_t out of range, e.g., via a network share.
5136 Don't alloca where an auto var works fine.
5137
5138 * fileio.c: Fix some integer overflow issues.
5139 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5140 Don't assume string length fits in int.
5141 (directory_file_name): Don't assume string length fits in long.
5142 (make_temp_name): Don't assume pid fits in int, or that its print
5143 length is less than 20.
5144
5145 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5146
5147 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5148
5149 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5150
5151 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5152 We prefer signed integers, even for size calculations.
5153
5154 * emacs.c: Don't assume string length fits in 'int'.
5155 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5156 (main): Don't invoke strlen when not needed.
5157
5158 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5159 (XD_DEBUG_MESSAGE): Don't waste a byte.
5160
5161 * callproc.c (getenv_internal_1, getenv_internal)
5162 (Fgetenv_internal):
5163 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5164
5165 * lread.c (invalid_syntax): Omit length argument.
5166 All uses changed. This doesn't fix a bug, but it simplifies the
5167 code away from its former Hollerith-constant appearance, and it's
5168 one less 'int' to worry about when looking at integer-overflow issues.
5169 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5170
5171 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5172 This didn't break anything, but it didn't help either.
5173 It's confusing to put a bogus integer in a place where the actual
5174 value does not matter.
5175 (LIST_END_P): Remove unused macro and its bogus comment.
5176 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5177
5178 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5179 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5180 implementation.
5181 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5182 We prefer signed types, and the value cannot exceed the EMACS_INT
5183 range anyway (because otherwise the length would not be representable).
5184 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5185 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5186 This avoids a GCC warning when WIDE_EMACS_INT.
5187
5188 * indent.c (sane_tab_width): New function.
5189 (current_column, scan_for_column, Findent_to, position_indentation)
5190 (compute_motion): Use it. This is just for clarity.
5191 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5192
5193 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5194
5195 * lisp.h (lint_assume): New macro.
5196 * composite.c (composition_gstring_put_cache):
5197 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5198
5199 * editfns.c, insdel.c:
5200 Omit unnecessary forward decls, to simplify future changes.
5201
5202 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5203
5204 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5205
5206 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5207 Use much-faster test for byte-length change.
5208 Don't assume string byte-length fits in 'int'.
5209 Check that character arg fits in 'int'.
5210 (mapcar1): Declare byte as byte, for clarity.
5211
5212 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5213
5214 * fns.c (concat): Catch string overflow earlier.
5215 Do not rely on integer wraparound.
5216
5217 * dispextern.h (struct it.overlay_strings_charpos)
5218 (struct it.selective): Now EMACS_INT, not int.
5219 * xdisp.c (forward_to_next_line_start)
5220 (back_to_previous_visible_line_start)
5221 (reseat_at_next_visible_line_start, next_element_from_buffer):
5222 Don't arbitrarily truncate the value of 'selective' to int.
5223
5224 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5225
5226 * composite.c: Don't truncate sizes to 'int'.
5227 (composition_gstring_p, composition_reseat_it)
5228 (composition_adjust_point): Use EMACS_INT, not int.
5229 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5230 not EMACS_UINT, for indexes.
5231
5232 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5233
5234 * buffer.c: Include <verify.h>.
5235 (struct sortvec.priority, struct sortstr.priority):
5236 Now EMACS_INT, not int.
5237 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5238 (struct sortstr.size, record_overlay_string)
5239 (struct sortstrlist.size, struct sortlist.used):
5240 Don't truncate size to int.
5241 (record_overlay_string): Check for size-calculation overflow.
5242 (init_buffer_once): Check at compile-time, not run-time.
5243
5244 2011-06-22 Jim Meyering <meyering@redhat.com>
5245
5246 Don't leak an XBM-image-sized buffer
5247 * image.c (xbm_load): Free the image buffer after using it.
5248
5249 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5250
5251 Port to Sun C.
5252 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5253 that Sun C diagnosed.
5254 * fns.c (secure_hash): Fix pointer signedness issue.
5255 * intervals.c (static_offset_intervals): New function.
5256 (offset_intervals): Use it.
5257
5258 2011-06-21 Leo Liu <sdl.web@gmail.com>
5259
5260 * deps.mk (fns.o):
5261 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5262 sha512.h.
5263
5264 * fns.c (secure_hash): Rename from crypto_hash_function and change
5265 the first arg to accept symbols.
5266 (Fsecure_hash): New primitive.
5267 (syms_of_fns): New symbols.
5268
5269 2011-06-20 Deniz Dogan <deniz@dogan.se>
5270
5271 * process.c (Fset_process_buffer): Clarify return value in
5272 docstring.
5273
5274 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5275
5276 * dispnew.c (add_window_display_history): Use BVAR.
5277
5278 * xdisp.c (debug_method_add): Use BVAR.
5279 (check_window_end, dump_glyph_matrix, dump_glyph)
5280 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5281
5282 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5283 Likewise.
5284
5285 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5286 check till after the cache is created in init_frame_faces.
5287
5288 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5289
5290 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5291
5292 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5293
5294 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5295 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5296 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5297
5298 Improve buffer-overflow checking (Bug#8873).
5299 * fileio.c (Finsert_file_contents):
5300 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5301 Remove the old (too-loose) buffer overflow checks.
5302 They weren't needed, since make_gap checks for buffer overflow.
5303 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5304 The old code merely checked for Emacs fixnum overflow, and relied
5305 on undefined (wraparound) behavior. The new code avoids undefined
5306 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5307
5308 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5309 Tune. Don't use wider integers than needed. Don't use alloca.
5310 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5311
5312 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5313
5314 * insdel.c, lisp.h (buffer_overflow): New function.
5315 (insert_from_buffer_1, replace_range, replace_range_2):
5316 * insdel.c (make_gap_larger):
5317 * editfns.c (Finsert_char):
5318 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5319
5320 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5321
5322 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5323
5324 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5325
5326 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5327 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5328
5329 * fileio.c: Don't assume EMACS_INT fits in off_t.
5330 (emacs_lseek): New static function.
5331 (Finsert_file_contents, Fwrite_region): Use it.
5332 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5333
5334 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5335
5336 * fns.c: Don't overflow int when computing a list length.
5337 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5338 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5339 truncation on 64-bit hosts. Check for QUIT every
5340 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5341 faster and is responsive enough.
5342 (Flength): Report an error instead of overflowing an integer.
5343 (Fsafe_length): Return a float if the value is not representable
5344 as a fixnum. This shouldn't happen except in contrived situations.
5345 (Fnthcdr, Fsort): Don't assume list length fits in int.
5346 (Fcopy_sequence): Don't assume vector length fits in int.
5347
5348 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5349 (header_size, word_size): New constants.
5350 (allocate_vectorlike): Don't check size overflow here.
5351 (allocate_vector): Check it here instead, since this is the only
5352 caller of allocate_vectorlike that could cause overflow.
5353 Check that the new vector's length is representable as a fixnum.
5354
5355 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5356 The previous code was bogus. For example, next_almost_prime (32)
5357 returned 39, which is undesirable as it is a multiple of 3; and
5358 next_almost_prime (24) returned 25, which is a multiple of 5 so
5359 why was the code bothering to check for multiples of 7?
5360
5361 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5362
5363 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5364
5365 Variadic C functions now count arguments with ptrdiff_t.
5366 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5367 Back then I didn't know that the Emacs coding style prefers signed int.
5368 Also, in the meantime I found a few more instances where arguments
5369 were being counted with int, which may truncate counts on 64-bit
5370 machines, or EMACS_INT, which may be unnecessarily wide.
5371 * lisp.h (struct Lisp_Subr.function.aMANY)
5372 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5373 Arg counts are now ptrdiff_t, not size_t.
5374 All variadic functions and their callers changed accordingly.
5375 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5376 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5377 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5378 * callint.c (Fcall_interactively): Check arg count for overflow,
5379 to avoid potential buffer overrun. Use signed char, not 'int',
5380 for 'varies' array, so that we needn't bother to check its size
5381 calculation for overflow.
5382 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5383 * eval.c (apply_lambda):
5384 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5385 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5386 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5387
5388 * callint.c (Fcall_interactively): Don't use index var as event count.
5389
5390 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5391 * mem-limits.h (SIZE): Remove; no longer used.
5392
5393 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5394
5395 Remove unnecessary casts.
5396 * xterm.c (x_term_init):
5397 * xfns.c (x_set_border_pixel):
5398 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5399 These aren't needed now that we assume ANSI C.
5400
5401 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5402 It's more likely to cause problems (due to unsigned overflow)
5403 than to cure them.
5404
5405 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5406
5407 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5408
5409 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5410
5411 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5412
5413 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5414
5415 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5416
5417 GLYPH_CODE_FACE returns EMACS_INT, not int.
5418 * dispextern.h (merge_faces):
5419 * xfaces.c (merge_faces):
5420 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5421 Don't assume EMACS_INT fits in int.
5422
5423 * character.h (CHAR_VALID_P): Remove unused parameter.
5424 * fontset.c, lisp.h, xdisp.c: All uses changed.
5425
5426 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5427
5428 * fns.c (concat): Minor tuning based on overflow analysis.
5429 This doesn't fix any bugs. Use int to hold character, instead
5430 of constantly refetching from Emacs object. Use XFASTINT, not
5431 XINT, for value known to be a character. Don't bother comparing
5432 a single byte to 0400, as it's always less.
5433
5434 * floatfns.c (Fexpt):
5435 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5436
5437 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5438 for characters.
5439
5440 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5441
5442 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5443 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5444 incorrectly succeed when S was a string, because 4294967386 was
5445 truncated before it was used.
5446
5447 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5448 Otherwise, an out-of-range integer could cause undefined behavior
5449 on a 64-bit host.
5450
5451 * composite.c: Use int, not EMACS_INT, for characters.
5452 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5453 EMACS_INT, for values that are known to be in character range.
5454 This doesn't fix any bugs but is the usual style inside Emacs and
5455 may generate better code on 32-bit machines.
5456
5457 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5458 This is for reasons similar to the recent CHAR_STRING fix.
5459 * charset.c (Fencode_char): Check that character arg is actually
5460 a character. Pass an int to ENCODE_CHAR.
5461 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5462 wider than 'int', as a compile-time check to prevent future regressions
5463 in this area.
5464
5465 * character.c (char_string): Remove unnecessary casts.
5466
5467 Make sure a 64-bit char is never passed to CHAR_STRING.
5468 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5469 by silently ignoring the top 32 bits, allowing some values
5470 that were far too large to be valid characters.
5471 * character.h: Include <verify.h>.
5472 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5473 arguments are no wider than unsigned, as a compile-time check
5474 to prevent future regressions in this area.
5475 * data.c (Faset):
5476 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5477 (Fsubst_char_in_region):
5478 * fns.c (concat):
5479 * xdisp.c (decode_mode_spec_coding):
5480 Adjust to CHAR_STRING's new requirement.
5481 * editfns.c (Finsert_char, Fsubst_char_in_region):
5482 * fns.c (concat): Check that character args are actually
5483 characters. Without this test, these functions did the wrong
5484 thing with wildly out-of-range values on 64-bit hosts.
5485
5486 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5487 These casts should not be needed on 32-bit hosts, either.
5488 * keyboard.c (read_char):
5489 * lread.c (Fload): Remove casts to unsigned.
5490
5491 * lisp.h (UNSIGNED_CMP): New macro.
5492 This fixes comparison bugs on 64-bit hosts.
5493 (ASCII_CHAR_P): Use it.
5494 * casefiddle.c (casify_object):
5495 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5496 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5497 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5498 * dispextern.h (FACE_FROM_ID):
5499 * keyboard.c (read_char): Use UNSIGNED_CMP.
5500
5501 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5502 not to EMACS_INT, to avoid GCC warning.
5503
5504 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5505
5506 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5507 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5508 isn't needed on 32-bit machines.
5509
5510 * buffer.c (Fgenerate_new_buffer_name):
5511 Use EMACS_INT for count, not int.
5512 (advance_to_char_boundary): Return EMACS_INT, not int.
5513
5514 * data.c (Qcompiled_function): Now static.
5515
5516 * window.c (window_body_lines): Now static.
5517
5518 * image.c (gif_load): Rename local to avoid shadowing.
5519
5520 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5521 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5522 * alloc.c (make_save_value): Integer argument is now of type
5523 ptrdiff_t, not int.
5524 (mark_object): Use ptrdiff_t, not int.
5525 * lisp.h (pD): New macro.
5526 * print.c (print_object): Use it.
5527
5528 * alloc.c: Use EMACS_INT, not int, to count objects.
5529 (total_conses, total_markers, total_symbols, total_vector_size)
5530 (total_free_conses, total_free_markers, total_free_symbols)
5531 (total_free_floats, total_floats, total_free_intervals)
5532 (total_intervals, total_strings, total_free_strings):
5533 Now EMACS_INT, not int. All uses changed.
5534 (Fgarbage_collect): Compute overall total using a double, so that
5535 integer overflow is less likely to be a problem. Check for overflow
5536 when converting back to an integer.
5537 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5538 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5539 These were 'int' variables that could overflow on 64-bit hosts;
5540 they were never used, so remove them instead of repairing them.
5541 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5542 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5543 Previously, this ceilinged at INT_MAX, but that doesn't work on
5544 64-bit machines.
5545 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5546
5547 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5548 (allocate_vectorlike): Check for ptrdiff_t overflow.
5549 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5550 when a (possibly-narrower) signed value would do just as well.
5551 We prefer using signed arithmetic, to avoid comparison confusion.
5552
5553 * alloc.c: Catch some string size overflows that we were missing.
5554 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5555 for convenience in STRING_BYTES_MAX.
5556 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5557 The definition here is exact; the one in lisp.h was approximate.
5558 (allocate_string_data): Check for string overflow. This catches
5559 some instances we weren't catching before. Also, it catches
5560 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5561 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5562 and ptrdiff_t and EMACS_INT are both 64 bits.
5563
5564 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5565 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5566 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5567
5568 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5569
5570 * alloc.c (Fmake_string): Check for out-of-range init.
5571
5572 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5573
5574 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5575
5576 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5577
5578 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5579 xg_get_default_scrollbar_width.
5580
5581 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5582 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5583 (style_changed_cb): Call update_theme_scrollbar_width and call
5584 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5585 all frames (Bug#8505).
5586 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5587 Call gtk_window_set_resizable if HAVE_GTK3.
5588 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5589 and height if HAVE_GTK3 (Bug#8505).
5590 (scroll_bar_width_for_theme): New variable.
5591 (update_theme_scrollbar_width): New function.
5592 (xg_get_default_scrollbar_width): Move code to
5593 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5594 (xg_initialize): Call update_theme_scrollbar_width.
5595
5596 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5597
5598 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5599
5600 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5601
5602 * frame.c (make_frame): Call other_buffer_safely instead of
5603 other_buffer.
5604
5605 * window.c (temp_output_buffer_show): Call display_buffer with
5606 second argument Vtemp_buffer_show_specifiers and reset latter
5607 immediately after the call.
5608 (Vtemp_buffer_show_specifiers): New variable.
5609 (auto_window_vscroll_p, next_screen_context_lines)
5610 (Vscroll_preserve_screen_position): Remove leading asterisks from
5611 doc-strings.
5612
5613 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5614
5615 Fix minor problems found by GCC 4.6.0 static checking.
5616 * buffer.c (Qclone_number): Remove for now, as it's unused.
5617 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5618 (record_buffer): Remove unused local.
5619 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5620 (set_frame_buffer_list): Remove; unused.
5621 * frame.h (other_visible_frames): Remove decl.
5622 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5623 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5624 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5625 if HAVE_GPM.
5626 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5627 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5628 Define only if HAVE_GPM.
5629 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5630 (update_hints_inhibit): Remove; never set. All uses removed.
5631 * widgetprv.h (emacsFrameClassRec): Remove decl.
5632 * window.c (delete_deletable_window): Now returns void, since it
5633 wasn't returning anything.
5634 (compare_window_configurations): Remove unused locals.
5635 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5636 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5637 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5638 the same widths as pointers. This follows up on the 2011-05-06 patch.
5639 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5640 * xterm.h: Likewise.
5641 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5642
5643 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5644
5645 * makefile.w32-in: Update dependencies.
5646 (LISP_H): Add lib/intprops.h.
5647
5648 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5649
5650 * image.c (gif_load): Add animation frame delay to the metadata.
5651 (syms_of_image): Use DEFSYM. New symbol `delay'.
5652
5653 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5654
5655 * window.c (delete_deletable_window): Re-add.
5656 (Fset_window_configuration): Rewrite to handle dead buffers and
5657 consequently deletable windows.
5658 (window_tree, Fwindow_tree): Remove. Supply functionality in
5659 window.el.
5660 (compare_window_configurations): Simplify code.
5661
5662 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5663
5664 * image.c (imagemagick_load_image): Fix type mismatch.
5665 (Fimagemagick_types): Likewise.
5666
5667 * window.h (replace_buffer_in_windows): Declare.
5668
5669 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5670
5671 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5672 Qclone_number. Remove external declaration of Qdelete_window.
5673 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5674 code.
5675 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5676 Run Qbuffer_list_update_hook if allowed.
5677 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5678 buffer list implementation.
5679 (other_buffer_safely): New function.
5680 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5681 calls to replace_buffer_in_windows and
5682 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5683 if allowed.
5684 (record_buffer): Inhibit quitting and rewrite using quittable
5685 functions. Run Qbuffer_list_update_hook if allowed.
5686 (Frecord_buffer, Funrecord_buffer): New functions.
5687 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5688 Move switch-to-buffer to window.el.
5689 (bury-buffer): Move to window.el.
5690 (Vbuffer_list_update_hook): New variable.
5691
5692 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5693 section.
5694
5695 * window.h (resize_frame_windows): Move up in code.
5696 (Fwindow_frame): Remove EXFUN.
5697 (replace_buffer_in_all_windows): Remove prototype.
5698 (replace_buffer_in_windows_safely): Add prototype.
5699
5700 * window.c: Declare Qdelete_window static again. Move down
5701 declaration of select_count.
5702 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5703 (Fother_window): Move to window.el.
5704 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5705 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5706 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5707 window.el.
5708 (replace_buffer_in_windows): Implement by calling
5709 Qreplace_buffer_in_windows.
5710 (replace_buffer_in_all_windows): Remove with some functionality
5711 moved into replace_buffer_in_windows_safely.
5712 (replace_buffer_in_windows_safely): New function.
5713 (select_window_norecord, select_frame_norecord): Move in front
5714 of run_window_configuration_change_hook. Remove now obsolete
5715 declarations.
5716 (Fset_window_buffer): Rewrite doc-string.
5717 Call Qrecord_window_buffer.
5718 (keys_of_window): Move binding for other-window to window.el.
5719
5720 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5721
5722 * dispextern.h (struct image): Replace data member, whose int_val
5723 and ptr_val fields were not used by anything, with a single
5724 lisp_val object.
5725
5726 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5727 (gif_clear_image, gif_load, imagemagick_load_image)
5728 (gs_clear_image, gs_load): Callers changed.
5729
5730 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5731
5732 * buffer.h: Include <time.h>, for time_t.
5733 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5734
5735 Fix minor problems found by static checking.
5736
5737 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5738
5739 Make identifiers static if they are not used in other modules.
5740 * data.c (Qcompiled_function, Qframe, Qvector):
5741 * image.c (QimageMagick, Qsvg):
5742 * minibuf.c (Qmetadata):
5743 * window.c (resize_window_check, resize_root_window): Now static.
5744 * window.h (resize_window_check, resize_root_window): Remove decls.
5745
5746 * window.c (window_deletion_count, delete_deletable_window):
5747 Remove; unused.
5748 (window_body_lines): Now static.
5749 (Fdelete_other_windows_internal): Mark vars as initialized.
5750 Make sure 'resize_failed' is initialized.
5751 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5752 (resize_window_apply): Remove unused local.
5753 * window.h (delete_deletable_window): Remove decl.
5754
5755 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5756 (imagemagick_load_image): Fix pointer signedness problem by changing
5757 last arg from unsigned char * to char *. All uses changed.
5758 Also, fix a local for similar reasons.
5759 Remove unused locals. Remove locals to avoid shadowing.
5760 (fn_rsvg_handle_free): Remove; unused.
5761 (svg_load, svg_load_image): Fix pointer signedness problem.
5762 (imagemagick_load_image): Don't use garbage pointer image_wand.
5763
5764 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5765
5766 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5767
5768 * image.c (gif_load): Fix omitted cast error introduced by
5769 2011-06-06 change.
5770
5771 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5772
5773 * window.h (resize_proportionally, orig_total_lines)
5774 (orig_top_line): Remove from window structure.
5775 (set_window_height, set_window_width, change_window_heights)
5776 (Fdelete_window): Remove prototypes.
5777 (resize_frame_windows): Remove duplicate declaration.
5778
5779 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5780
5781 * window.h (resize_frame_windows, resize_window_check)
5782 (delete_deletable_window, resize_root_window)
5783 (resize_frame_windows): Declare prototypes.
5784
5785 * window.c (resize_window_apply): Make definition be "static" to
5786 match the prototype.
5787
5788 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5789
5790 * window.c: Remove declarations of Qwindow_size_fixed,
5791 window_min_size_1, window_min_size_2, window_min_size,
5792 size_window, window_fixed_size_p, enlarge_window, delete_window.
5793 Remove static from declaration of Qdelete_window, it's
5794 temporarily needed by Fbury_buffer.
5795 (replace_window): Don't assign orig_top_line and
5796 orig_total_lines.
5797 (Fdelete_window, delete_window): Remove. Window deletion is
5798 handled by window.el.
5799 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5800 Replace Fdelete_window calls with calls to Qdelete_window.
5801 (Fdelete_other_windows): Remove. Deleting other windows is
5802 handled by window.el.
5803 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5804 handled in window.el.
5805 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5806 Window minimum sizes are handled in window.el.
5807 (shrink_windows, size_window, set_window_height)
5808 (set_window_width, change_window_heights, window_height)
5809 (window_width, CURBEG, CURSIZE, enlarge_window)
5810 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5811 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5812 handled in window.el.
5813 (make_dummy_parent): Rename to make_parent_window and give it a
5814 second argument horflag.
5815 (make_window): Don't set resize_proportionally any more.
5816 (Fsplit_window): Remove. Windows are split in window.el.
5817 (save_restore_action, save_restore_orig_size)
5818 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5819 Resize mini windows in window.el.
5820 (grow_mini_window, shrink_mini_window): Implement by calling
5821 Qresize_root_window_vertically, resize_window_check and
5822 resize_window_apply.
5823 (saved_window, Fset_window_configuration, save_window_save):
5824 Do not handle orig_top_line, orig_total_lines, and
5825 resize_proportionally.
5826 (window_min_height, window_min_width): Move to window.el.
5827 (keys_of_window): Move bindings for delete-other-windows,
5828 split-window, delete-window and enlarge-window to window.el.
5829
5830 * buffer.c: Temporarily extern Qdelete_window.
5831 (Fbury_buffer): Temporarily call Qdelete_window instead of
5832 Fdelete_window (Fbury_buffer will move to window.el soon).
5833
5834 * frame.c (set_menu_bar_lines_1): Remove code handling
5835 orig_top_line and orig_total_lines.
5836
5837 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5838 set_window_height but set heights directly.
5839 (change_frame_size_1): Use resize_frame_windows.
5840
5841 * xdisp.c (init_xdisp): Don't use set_window_height but set
5842 heights directly.
5843
5844 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5845 Use resize_frame_windows instead of change_window_heights and run
5846 run_window_configuration_change_hook.
5847
5848 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5849 instead of change_window_heights and run
5850 run_window_configuration_change_hook.
5851
5852 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5853
5854 * window.c (replace_window): Rename second argument REPLACEMENT to
5855 NEW. New third argument SETFLAG. Rewrite.
5856 (delete_window, make_dummy_parent): Call replace_window with
5857 third argument 1.
5858 (window_list_1): Move down in code.
5859 (run_window_configuration_change_hook): Move set_buffer part
5860 before select_frame_norecord part in order to unwind correctly.
5861 Rename count1 to count.
5862 (recombine_windows, delete_deletable_window, resize_root_window)
5863 (Fdelete_other_windows_internal)
5864 (Frun_window_configuration_change_hook, make_parent_window)
5865 (resize_window_check, resize_window_apply, Fresize_window_apply)
5866 (resize_frame_windows, Fsplit_window_internal)
5867 (Fdelete_window_internal, Fresize_mini_window_internal):
5868 New functions.
5869 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5870
5871 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5872
5873 * window.h (window): Add some new members to window structure -
5874 normal_lines, normal_cols, new_total, new_normal, clone_number,
5875 splits, nest, prev_buffers, next_buffers.
5876 (WINDOW_TOTAL_SIZE): Move here from window.c.
5877 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5878
5879 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5880 Remove.
5881 (make_dummy_parent): Set new members of windows structure.
5882 (make_window): Move down in code. Handle new members of window
5883 structure.
5884 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5885 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5886 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5887 (Fset_window_prev_buffers, Fwindow_next_buffers)
5888 (Fset_window_next_buffers, Fset_window_clone_number):
5889 New functions.
5890 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5891 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5892 Doc-string fixes.
5893 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5894 Argument WINDOW can be now internal window too.
5895 (Fwindow_use_time): Move up in code.
5896 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5897 Rewrite doc-string.
5898 (Fset_window_configuration, saved_window)
5899 (Fcurrent_window_configuration, save_window_save): Handle new
5900 members of window structure.
5901 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5902 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5903 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5904 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5905 Qget_mru_window, Qresize_root_window,
5906 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5907 Qauto_buffer_name; staticpro them.
5908
5909 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5910
5911 * window.c (Fwindow_total_size, Fwindow_left_column)
5912 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5913 (Fwindow_list_1): New functions.
5914 (window_box_text_cols): Replace with window_body_cols.
5915 (Fwindow_width, Fscroll_left, Fscroll_right):
5916 Use window_body_cols instead of window_box_text_cols.
5917 (delete_window, Fset_window_configuration):
5918 Call delete_all_subwindows with window as argument.
5919 (delete_all_subwindows): Take a window as argument and not a
5920 structure. Rewrite.
5921 (window_loop): Remove handling of GET_LRU_WINDOW and
5922 GET_LARGEST_WINDOW.
5923 (Fget_lru_window, Fget_largest_window): Move to window.el.
5924
5925 * window.h: Extern window_body_cols instead of
5926 window_box_text_cols. delete_all_subwindows now takes a
5927 Lisp_Object as argument.
5928
5929 * indent.c (compute_motion, Fcompute_motion):
5930 Use window_body_cols instead of window_box_text_cols.
5931
5932 * frame.c (delete_frame): Call delete_all_subwindows with root
5933 window as argument.
5934
5935 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5936
5937 * fns.c (Fputhash): Document return value.
5938
5939 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5940
5941 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5942
5943 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5944
5945 Cons<->int and similar integer overflow fixes (Bug#8794).
5946
5947 Check for overflow when converting integer to cons and back.
5948 * charset.c (Fdefine_charset_internal, Fdecode_char):
5949 Use cons_to_unsigned to catch overflow.
5950 (Fencode_char): Use INTEGER_TO_CONS.
5951 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5952 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5953 * data.c (long_to_cons, cons_to_long): Remove.
5954 (cons_to_unsigned, cons_to_signed): New functions.
5955 These signal an error for invalid or out-of-range values.
5956 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5957 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5958 * font.c (Ffont_variation_glyphs):
5959 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5960 * lisp.h: Include <intprops.h>.
5961 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5962 (cons_to_signed, cons_to_unsigned): New decls.
5963 (long_to_cons, cons_to_long): Remove decls.
5964 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5965 (Fprimitive_undo): Use CONS_TO_INTEGER.
5966 * xfns.c (Fx_window_property): Likewise.
5967 * xselect.c: Include <limits.h>.
5968 (x_own_selection, selection_data_to_lisp_data):
5969 Use INTEGER_TO_CONS.
5970 (x_handle_selection_request, x_handle_selection_clear)
5971 (x_get_foreign_selection, Fx_disown_selection_internal)
5972 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5973 (lisp_data_to_selection_data): Use cons_to_unsigned.
5974 (x_fill_property_data): Use cons_to_signed.
5975 Report values out of range.
5976
5977 Check for buffer and string overflow more precisely.
5978 * buffer.h (BUF_BYTES_MAX): New macro.
5979 * lisp.h (STRING_BYTES_MAX): New macro.
5980 * alloc.c (Fmake_string):
5981 * character.c (string_escape_byte8):
5982 * coding.c (coding_alloc_by_realloc):
5983 * doprnt.c (doprnt):
5984 * editfns.c (Fformat):
5985 * eval.c (verror):
5986 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5987 since they may not be the same number.
5988 * editfns.c (Finsert_char):
5989 * fileio.c (Finsert_file_contents):
5990 Likewise for BUF_BYTES_MAX.
5991
5992 * image.c: Use ptrdiff_t, not int, for sizes.
5993 (slurp_file): Switch from int to ptrdiff_t.
5994 All uses changed.
5995 (slurp_file): Check that file size fits in both size_t (for
5996 malloc) and ptrdiff_t (for sanity and safety).
5997
5998 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5999 if b->modtime has its maximal value.
6000
6001 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6002
6003 Don't assume time_t can fit into int.
6004 * buffer.h (struct buffer.modtime): Now time_t, not int.
6005 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6006 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6007
6008 Minor fixes for signed vs unsigned integers.
6009 * character.h (MAYBE_UNIFY_CHAR):
6010 * charset.c (maybe_unify_char):
6011 * keyboard.c (read_char, reorder_modifiers):
6012 XINT -> XFASTINT, since the integer must be nonnegative.
6013 * ftfont.c (ftfont_spec_pattern):
6014 * keymap.c (access_keymap, silly_event_symbol_error):
6015 XUINT -> XFASTINT, since the integer must be nonnegative.
6016 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6017 since it makes no difference and we prefer signed.
6018 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6019 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6020 nonnegative.
6021
6022 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6023
6024 * window.h (Fwindow_frame): Declare.
6025
6026 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6027
6028 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6029 (SPARE_MEMORY): Always define.
6030 (LARGE_REQUEST): Remove.
6031 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6032
6033 2011-06-06 Martin Rudalics <rudalics@gmx.at>
6034
6035 * lisp.h: Move EXFUNS for Fframe_root_window,
6036 Fframe_first_window and Fset_frame_selected_window to window.h.
6037
6038 * window.h: Move EXFUNS for Fframe_root_window,
6039 Fframe_first_window and Fset_frame_selected_window here from
6040 lisp.h.
6041
6042 * frame.c (Fwindow_frame, Fframe_first_window)
6043 (Fframe_root_window, Fframe_selected_window)
6044 (Fset_frame_selected_window): Move to window.c.
6045 (Factive_minibuffer_window): Move to minibuf.c.
6046 (Fother_visible_frames_p): New function.
6047
6048 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6049
6050 * window.c (decode_window, decode_any_window): Move up in code.
6051 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6052 (inhibit_frame_unsplittable): Remove unused variable.
6053 (Fwindow_buffer): Move up and rewrite doc-string.
6054 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6055 (Fwindow_prev): New functions.
6056 (Fwindow_frame): Move here from frame.c. Accept any window as
6057 argument.
6058 (Fframe_root_window, Fframe_first_window)
6059 (Fframe_selected_window): Move here from frame.c. Accept frame
6060 or arbitrary window as argument. Update doc-strings.
6061 (Fminibuffer_window): Move up in code.
6062 (Fwindow_minibuffer_p): Move up in code and simplify.
6063 (Fset_frame_selected_window): Move here from frame.c.
6064 Marginal rewrite.
6065 (Fselected_window, select_window, Fselect_window): Move up in
6066 code. Minor doc-string fixes.
6067
6068 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6069
6070 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6071 Do not assume that spare memory exists; that assumption is valid
6072 only if SYSTEM_MALLOC.
6073 (LARGE_REQUEST): New macro, so that the issue of large requests
6074 is separated from the issue of spare memory.
6075
6076 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6077
6078 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6079 format. (Bug#8806)
6080
6081 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6082
6083 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6084 before statements.
6085
6086 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6087
6088 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6089
6090 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6091
6092 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6093 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6094
6095 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
6096
6097 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6098
6099 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
6100
6101 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6102 (x_clipboard_manager_save): Add return value.
6103 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6104 New error handlers.
6105 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6106 Obey Vx_select_enable_clipboard_manager. Catch errors in
6107 x_clipboard_manager_save (Bug#8779).
6108 (Vx_select_enable_clipboard_manager): New variable.
6109 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
6110
6111 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
6112
6113 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6114
6115 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6116
6117 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6118 in the current matrix if keep_current_p is non-zero.
6119
6120 2011-06-04 Eli Zaretskii <eliz@gnu.org>
6121
6122 * bidi.c (bidi_level_of_next_char): Fix last change.
6123
6124 2011-06-03 Eli Zaretskii <eliz@gnu.org>
6125
6126 Support bidi reordering of text covered by display properties.
6127
6128 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6129 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6130 (bidi_cache_search, bidi_cache_iterator_state)
6131 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6132 (bidi_level_of_next_char, bidi_move_to_visually_next):
6133 Support character positions inside a run of characters covered by a
6134 display string.
6135 (bidi_paragraph_init, bidi_resolve_explicit_1)
6136 (bidi_level_of_next_char): Call bidi_fetch_char and
6137 bidi_fetch_char_advance instead of FETCH_CHAR and
6138 FETCH_CHAR_ADVANCE.
6139 (bidi_init_it): Initialize new members.
6140 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6141 definitions.
6142 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6143 instead of using explicit *_CHAR codes.
6144 (bidi_resolve_explicit, bidi_resolve_weak):
6145 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
6146 bidirectional text is supported only in multibyte buffers.
6147 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6148 it to initialize the frame_window_p member of struct bidi_it.
6149 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6150 (bidi_resolve_explicit, bidi_resolve_weak)
6151 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6152 bidi_it->nchars is non-positive.
6153 (bidi_level_of_next_char): Don't try to lookup the cache for the
6154 next/previous character if nothing is cached there yet, or if we
6155 were just reseat()'ed to a new position.
6156
6157 * xdisp.c (set_cursor_from_row): Set start and stop points
6158 according to the row's direction when priming the loop that looks
6159 for the glyph on which to display cursor.
6160 (single_display_spec_intangible_p): Function deleted.
6161 (display_prop_intangible_p): Reimplement to call
6162 handle_display_spec instead of single_display_spec_intangible_p.
6163 Accept 3 additional arguments needed by handle_display_spec.
6164 This fixes incorrect cursor motion across display property with complex
6165 values: lists, `(when COND...)' forms, etc.
6166 (single_display_spec_string_p): Support property values that are
6167 lists with the argument STRING its top-level element.
6168 (display_prop_string_p): Fix the condition for processing a
6169 property that is a list to be consistent with handle_display_spec.
6170 (handle_display_spec): New function, refactored from the
6171 last portion of handle_display_prop.
6172 (compute_display_string_pos): Accept additional argument
6173 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6174 value of a `display' property is a "replacing spec".
6175 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6176 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6177 the display property, but just return a value indicating whether
6178 the display property will replace the characters it covers.
6179 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6180 frame_window_p members of struct bidi_it.
6181 (compute_display_string_pos, compute_display_string_end):
6182 New functions.
6183 (push_it): Accept second argument POSITION, where pop_it should
6184 jump to continue iteration.
6185 (reseat_1): Initialize bidi_it.disp_pos.
6186
6187 * keyboard.c (adjust_point_for_property): Adjust the call to
6188 display_prop_intangible_p to its new signature.
6189
6190 * dispextern.h (struct bidi_it): New member frame_window_p.
6191 (bidi_init_it): Update prototypes.
6192 (display_prop_intangible_p): Update prototype.
6193 (compute_display_string_pos, compute_display_string_end):
6194 Declare prototypes.
6195 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6196 EMACS_INT.
6197
6198 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6199
6200 Malloc failure behavior now depends on size of allocation.
6201 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6202 * lisp.h: Change signatures accordingly.
6203 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6204 All callers changed. (Bug#8762)
6205
6206 * gnutls.c: Use Emacs's memory allocators.
6207 Without this change, the gnutls library would invoke malloc etc.
6208 directly, which causes problems on non-SYNC_INPUT hosts, and which
6209 runs afoul of improving memory_full behavior. (Bug#8761)
6210 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6211 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6212 xfree instead of the default malloc, realloc, free.
6213 (Fgnutls_boot): No need to check for memory allocation failure,
6214 since xmalloc does that for us.
6215
6216 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6217 * category.c (hash_get_category_set):
6218 * ccl.c (ccl_driver):
6219 * charset.c (Fdefine_charset_internal):
6220 * charset.h (struct charset.hash_index):
6221 * composite.c (get_composition_id, gstring_lookup_cache)
6222 (composition_gstring_put_cache):
6223 * composite.h (struct composition.hash_index):
6224 * dispextern.h (struct image.hash):
6225 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6226 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6227 (hashfn_equal, hashfn_user_defined, make_hash_table)
6228 (maybe_resize_hash_table, hash_lookup, hash_put)
6229 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6230 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6231 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6232 * image.c (make_image, search_image_cache, lookup_image)
6233 (xpm_put_color_table_h):
6234 * lisp.h (struct Lisp_Hash_Table):
6235 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6236 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6237 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6238 * alloc.c (allocate_vectorlike):
6239 Check for overflow in vector size calculations.
6240 * ccl.c (ccl_driver):
6241 Check for overflow when converting EMACS_INT to int.
6242 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6243 need to be updated by these changes.
6244 * fns.c (make_hash_table, maybe_resize_hash_table):
6245 Check for integer overflow with large hash tables.
6246 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6247 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6248 (SXHASH_REDUCE): New macro.
6249 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6250 Use it instead of discarding useful hash info with large hash values.
6251 (sxhash_float): New function.
6252 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6253 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6254 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6255 Rewrite to use FIXNUM_BITS, as this simplifies things.
6256 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6257 Adjust signatures to match updated version of code.
6258 (consing_since_gc): Now EMACS_INT, since a single hash table can
6259 use more than INT_MAX bytes.
6260
6261 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6262
6263 Make it possible to build with GCC-4.6+ -O2 -flto.
6264
6265 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6266
6267 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6268
6269 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6270 Call minibuffer-inactive-mode.
6271
6272 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6273
6274 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6275 Update dependencies.
6276
6277 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6278
6279 * data.c (init_data): Remove code for UTS, this system is not
6280 supported anymore.
6281
6282 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6283
6284 Don't force ./temacs to start in terminal mode.
6285
6286 * frame.c (make_initial_frame): Initialize faces in all cases, not
6287 only when CANNOT_DUMP is defined.
6288 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6289
6290 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6291
6292 * dispnew.c (add_window_display_history): Use const for the string
6293 pointer. Remove declaration, not needed.
6294
6295 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6296
6297 Use 'inline', not 'INLINE'.
6298 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6299 * alloc.c, fontset.c (INLINE): Remove.
6300 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6301 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6302 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6303 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6304 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6305
6306 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6307
6308 Make it possible to run ./temacs.
6309
6310 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6311 syms_of_callproc does the same thing. Remove test for
6312 "initialized", do it in the caller.
6313 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6314
6315 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6316
6317 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6318 (read_minibuf): Use get_minibuffer.
6319 (syms_of_minibuf): Use DEFSYM.
6320 (Qmetadata): New var.
6321 * data.c (Qbuffer): Don't make it static.
6322 (syms_of_data): Use DEFSYM.
6323
6324 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6325
6326 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6327 (CCL_CODE_MIN): New macro.
6328
6329 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6330
6331 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6332
6333 * eval.c (Qdebug): Now static.
6334 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6335 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6336 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6337
6338 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6339
6340 * image.c: Various fixes to ImageMagick code comments.
6341 (Fimagemagick_types): Doc fix.
6342
6343 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6344
6345 Minor fixes prompted by GCC 4.6.0 warnings.
6346
6347 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6348
6349 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6350 (x_clipboard_manager_save_all): Move extern decl to ...
6351 * xterm.h: ... here, so that it can be checked for consistency.
6352
6353 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6354
6355 * xselect.c (x_clipboard_manager_save_frame)
6356 (x_clipboard_manager_save_all): New functions.
6357 (Fx_clipboard_manager_save): Lisp function deleted.
6358
6359 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6360 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6361
6362 * xterm.h: Update prototype.
6363
6364 2011-05-28 William Xu <william.xwl@gmail.com>
6365
6366 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6367 exiting (Bug#8239).
6368
6369 2011-05-28 Jim Meyering <meyering@redhat.com>
6370
6371 Avoid a sign-extension bug in crypto_hash_function.
6372 * fns.c (to_uchar): Define.
6373 (crypto_hash_function): Use it to convert some newly-signed
6374 variables to unsigned, to avoid sign-extension bugs. For example,
6375 without this change, (md5 "truc") would evaluate to
6376 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6377 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6378 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6379
6380 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6381
6382 Integer overflow fixes.
6383
6384 * dbusbind.c: Serial number integer overflow fixes.
6385 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6386 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6387 to hold a serial number that is too large for a fixnum.
6388 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6389 Check for serial numbers out of range. Decode any serial number
6390 that was so large that it became a float. (Bug#8722)
6391
6392 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6393 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6394 Use XFASTINT rather than XUINT when numbers are nonnegative.
6395 (xd_append_arg, Fdbus_method_return_internal):
6396 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6397 arguments, check that Lisp number is nonnegative, rather than
6398 silently wrapping negative numbers around. (Bug#8722)
6399 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6400 (Bug#8722)
6401
6402 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6403
6404 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6405
6406 ccl: Add integer overflow checks.
6407 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6408 (IN_INT_RANGE): New macros.
6409 (ccl_driver): Use them to check for integer overflow when
6410 decoding a CCL program. Many of the new checks are whether XINT (x)
6411 fits in int; it doesn't always, on 64-bit hosts. The new version
6412 doesn't catch all possible integer overflows, but it's an
6413 improvement. (Bug#8719)
6414
6415 * alloc.c (make_event_array): Use XINT, not XUINT.
6416 There's no need for unsigned here.
6417
6418 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6419 This follows up to the 2011-05-06 change that substituted uintptr_t
6420 for EMACS_INT. This case wasn't caught back then.
6421
6422 Rework Fformat to avoid integer overflow issues.
6423 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6424 now (part of C89). Include <verify.h>.
6425 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6426 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6427 (Fformat): Avoid the prepass trying to compute sizes; it was only
6428 approximate and thus did not catch overflow reliably. Instead, walk
6429 through the format just once, formatting and computing sizes as we go,
6430 checking for integer overflow at every step, and allocating a larger
6431 buffer as needed. Keep track separately whether the format is
6432 multibyte. Keep only the most-recently calculated precision, rather
6433 than them all. Record whether each argument has been converted to
6434 string. Use EMACS_INT, not int, for byte and char and arg counts.
6435 Support field widths and precisions larger than INT_MAX. Avoid
6436 sprintf's undefined behavior with conversion specifications such as %#d
6437 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6438 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6439 formatting out-of-range floating point numbers with int
6440 formats. (Bug#8668)
6441
6442 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6443
6444 * data.c: Avoid integer truncation in expressions involving floats.
6445 * data.c: Include <intprops.h>.
6446 (arith_driver): When there's an integer overflow in an expression
6447 involving floating point, convert the integers to floating point
6448 so that the resulting value does not suffer from catastrophic
6449 integer truncation. For example, on a 64-bit host (* 4
6450 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6451 Do not rely on undefined behavior after integer overflow.
6452
6453 merge count_size_as_multibyte, parse_str_to_multibyte
6454 * character.c, character.h (count_size_as_multibyte):
6455 Rename from parse_str_to_multibyte; all uses changed.
6456 Check for integer overflow.
6457 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6458 since it's now a duplicate of the other. This is more of
6459 a character than a buffer op, so better that it's in character.c.
6460 * fns.c, print.c: Adjust to above changes.
6461
6462 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6463
6464 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6465
6466 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6467
6468 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6469 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6470 (x_clipboard_manager_save): Now static.
6471 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6472
6473 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6474 (crypto_hash_function): Now static.
6475 Fix pointer signedness problems. Avoid unnecessary initializations.
6476
6477 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6478
6479 * termhooks.h (Vselection_alist): Make it terminal-local.
6480
6481 * terminal.c (create_terminal): Initialize it.
6482
6483 * xselect.c: Support for clipboard managers.
6484 (Vselection_alist): Move to termhooks.h as terminal-local var.
6485 (LOCAL_SELECTION): New macro.
6486 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6487 (symbol_to_x_atom): Remove gratuitous arg.
6488 (x_handle_selection_request, lisp_data_to_selection_data)
6489 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6490 (x_own_selection, x_get_local_selection, x_convert_selection):
6491 New arg, specifying work frame. Use terminal-local Vselection_alist.
6492 (some_frame_on_display): Delete unused function.
6493 (Fx_own_selection_internal, Fx_get_selection_internal)
6494 (Fx_disown_selection_internal, Fx_selection_owner_p)
6495 (Fx_selection_exists_p): New optional frame arg.
6496 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6497 (x_handle_selection_clear): Don't treat other terminals with the
6498 same keyboard specially. Use the terminal-local Vselection_alist.
6499 (x_clear_frame_selections): Use Frun_hook_with_args.
6500
6501 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6502
6503 * xterm.h: Add support for those atoms.
6504
6505 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6506
6507 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6508 (converted_selections, conversion_fail_tag): New global variables.
6509 (x_selection_request_lisp_error): Free the above.
6510 (x_get_local_selection): Remove unnecessary code.
6511 (x_reply_selection_request): Args changed; handle arbitrary array
6512 of converted selections stored in converted_selections.
6513 Separate the XChangeProperty and SelectionNotify steps.
6514 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6515 (x_convert_selection): New function.
6516 (x_handle_selection_event): Simplify.
6517 (x_get_foreign_selection): Don't ignore incoming requests while
6518 waiting for an answer; this will fail when we implement
6519 SAVE_TARGETS, and seems unnecessary anyway.
6520 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6521 (Vx_sent_selection_functions): Doc fix.
6522
6523 2011-05-26 Leo Liu <sdl.web@gmail.com>
6524
6525 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6526
6527 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6528
6529 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6530
6531 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6532 for fringe update if it has periodic bitmap.
6533 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6534 and fringe_bitmap_periodic_p.
6535
6536 * fringe.c (get_fringe_bitmap_data): New function.
6537 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6538 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6539 row. Mark glyph row for fringe update if periodicity changed.
6540
6541 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6542 for fringe update unless it has periodic bitmap.
6543
6544 2011-05-25 Kenichi Handa <handa@m17n.org>
6545
6546 * xdisp.c (get_next_display_element): Set correct it->face_id for
6547 a static composition.
6548
6549 2011-05-24 Leo Liu <sdl.web@gmail.com>
6550
6551 * deps.mk (fns.o):
6552 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6553
6554 * fns.c (crypto_hash_function, Fsha1): New function.
6555 (Fmd5): Use crypto_hash_function.
6556 (syms_of_fns): Add Ssha1.
6557
6558 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6559
6560 * gnutls.c: Remove unused macros.
6561 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6562 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6563 Remove macros that are defined and never used.
6564 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6565
6566 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6567
6568 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6569 (Fx_get_selection_internal): Minor cleanup.
6570 (Fx_own_selection_internal): Rename arguments for consistency with
6571 select.el.
6572
6573 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6574
6575 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6576
6577 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6578
6579 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6580
6581 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6582
6583 * dispnew.c (scrolling_window): Don't exclude the case that the
6584 last enabled row in the desired matrix touches the bottom boundary.
6585
6586 2011-05-21 Glenn Morris <rgm@gnu.org>
6587
6588 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6589 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6590 and add some more files.
6591
6592 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6593
6594 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6595 report_file_error introduced by the change from 2011-05-07.
6596
6597 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6598
6599 * systime.h (Time): Define only if emacs is defined.
6600 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6601 where the include path doesn't have X11/X.h by default. See
6602 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6603
6604 2011-05-20 Kenichi Handa <handa@m17n.org>
6605
6606 * composite.c (find_automatic_composition): Fix previous change.
6607
6608 2011-05-20 Glenn Morris <rgm@gnu.org>
6609
6610 * lisp.mk: New file, split from Makefile.in.
6611 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6612 (shortlisp): Remove.
6613 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6614
6615 2011-05-19 Glenn Morris <rgm@gnu.org>
6616
6617 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6618 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6619 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6620 (lisp): Set the order to that of loadup.el.
6621 (shortlisp): Make it a copy of $lisp.
6622 (SOME_MACHINE_LISP): Remove.
6623 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6624 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6625
6626 2011-05-18 Kenichi Handa <handa@m17n.org>
6627
6628 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6629 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6630 (find_automatic_composition): Mostly rewrite for efficiency.
6631
6632 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6633
6634 * makefile.w32-in: Update dependencies.
6635
6636 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6637
6638 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6639 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6640
6641 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6642
6643 Fix some integer overflow issues, such as string length overflow.
6644
6645 * insdel.c (count_size_as_multibyte): Check for string overflow.
6646
6647 * character.c (lisp_string_width): Check for string overflow.
6648 Use EMACS_INT, not int, for string indexes and lengths; in
6649 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6650 the resulting string length overflows an EMACS_INT; instead,
6651 report a string overflow if no precision given. When checking for
6652 precision exhaustion, use a check that cannot possibly have
6653 integer overflow. (Bug#8675)
6654 * character.h (lisp_string_width): Adjust to new signature.
6655
6656 * alloc.c (string_overflow): New function.
6657 (Fmake_string): Use it. This doesn't change behavior, but saves
6658 a few bytes and will simplify future changes.
6659 * character.c (string_escape_byte8): Likewise.
6660 * lisp.h (string_overflow): New decl.
6661
6662 Fixups, following up to the user-interface timestamp change.
6663 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6664 for UI timestamps, instead of unsigned long.
6665 * msdos.c (mouse_get_pos): Likewise.
6666 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6667 * w32gui.h (Time): Define by including "systime.h" rather than by
6668 declaring it ourselves. (Bug#8664)
6669
6670 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6671 * image.c (clear_image_cache): Likewise.
6672
6673 * term.c (term_mouse_position): Don't assume time_t wraparound.
6674
6675 Be more systematic about user-interface timestamps.
6676 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6677 and sometimes 'EMACS_UINT', to represent these timestamps.
6678 This change causes it to use 'Time' uniformly, as that's what X uses.
6679 This makes the code easier to follow, and makes it easier to catch
6680 integer overflow bugs such as Bug#8664.
6681 * frame.c (Fmouse_position, Fmouse_pixel_position):
6682 Use Time, not unsigned long, for user-interface timestamps.
6683 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6684 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6685 * keyboard.h (last_event_timestamp): Likewise.
6686 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6687 * menu.h (xmenu_show): Likewise.
6688 * term.c (term_mouse_position): Likewise.
6689 * termhooks.h (struct input_event.timestamp): Likewise.
6690 (struct terminal.mouse_position_hook): Likewise.
6691 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6692 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6693 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6694 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6695 what it was before.
6696 * menu.h, termhooks.h: Include "systime.h", for Time.
6697
6698 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6699 Don't assume that the difference between two unsigned long values
6700 can fit into an integer. At this point, we know button_down_time
6701 <= event->timestamp, so the difference must be nonnegative, so
6702 there's no need to cast the result if double-click-time is
6703 nonnegative, as it should be; check that it's nonnegative, just in
6704 case. This bug is triggered when events are more than 2**31 ms
6705 apart (about 25 days). (Bug#8664)
6706
6707 * xselect.c (last_event_timestamp): Remove duplicate decl.
6708 (x_own_selection): Remove needless cast to unsigned long.
6709
6710 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6711 that always fit in int. Use a sentinel instead of a counter, to
6712 avoid a temp and to allay GCC's concerns about possible int overflow.
6713 * frame.h (struct frame): Use int for menu_bar_items_used
6714 instead of EMACS_INT, since it always fits in int.
6715
6716 * menu.c (grow_menu_items): Check for int overflow.
6717
6718 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6719
6720 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6721 Before, the code was not consistent. These values cannot exceed
6722 2**31 - 1 so there's no need to make them unsigned.
6723 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6724 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6725 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6726 as modifiers.
6727 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6728
6729 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6730 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6731 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6732 presumably because the widths might not match.
6733
6734 * window.c (size_window): Avoid needless test at loop start.
6735
6736 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6737
6738 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6739
6740 2011-05-12 Drew Adams <drew.adams@oracle.com>
6741
6742 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6743
6744 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6745
6746 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6747 `width' to `bar_area_x' and `bar_area_width', respectively.
6748 (x_scroll_run): Take account of fringe background extension.
6749
6750 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6751 Rename local vars `left' and `width' to `bar_area_x' and
6752 `bar_area_width', respectively.
6753 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6754 background extension.
6755
6756 2011-05-10 Jim Meyering <meyering@redhat.com>
6757
6758 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6759
6760 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6761
6762 * image.c (Finit_image_library): Return t for built-in image types,
6763 like pbm and xbm. (Bug#8640)
6764
6765 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6766
6767 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6768
6769 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6770
6771 * w32console.c (Fset_screen_color): Doc fix.
6772 (Fget_screen_color): New function.
6773 (syms_of_ntterm): Defsubr it.
6774
6775 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6776 unlink the temporary file if Fcall_process didn't create it in the
6777 first place.
6778 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6779 child process will be redirected to a file specified with `:file'.
6780 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6781 cue to call_process_cleanup not to close that handle.
6782
6783 2011-05-07 Ben Key <bkey76@gmail.com>
6784
6785 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6786 one of two shell specific rules, either bootstrap-temacs-CMD or
6787 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6788 to the previous implementation of the bootstrap-temacs rule.
6789 The bootstrap-temacs-CMD rule is similar to the previous
6790 implementation of the bootstrap-temacs rule except that it
6791 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6792 variable.
6793
6794 These changes, along with some changes to nt/configure.bat,
6795 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6796 earlier fix to add support for --cflags and --ldflags options
6797 that include quotes so that it works whether make uses cmd or
6798 sh as the shell.
6799
6800 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6801
6802 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6803 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6804 is a constant.
6805 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6806 a string. Handle both cases.
6807 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6808 (Fdbus_register_method): Use Qinvalid_function.
6809
6810 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6811
6812 * makefile.w32-in: Update dependencies.
6813 (LISP_H): Add inttypes.h and stdin.h.
6814 (PROCESS_H): Add unistd.h.
6815
6816 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6817
6818 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6819 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6820
6821 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6822
6823 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6824
6825 * term.c (vfatal): Remove stray call to va_end.
6826 It's not needed and the C Standard doesn't allow it here anyway.
6827
6828 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6829 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6830
6831 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6832 bytes.
6833
6834 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6835
6836 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6837
6838 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6839
6840 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6841
6842 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6843
6844 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6845 * charset.c (Fdefine_charset_internal): Don't initialize
6846 charset.code_space[15]. The value was garbage, on hosts with
6847 32-bit int (Bug#8600).
6848
6849 * lread.c (read_integer): Be more consistent with string-to-number.
6850 Use string_to_number to do the actual conversion; this avoids
6851 rounding errors and fixes some other screwups. Without this fix,
6852 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6853 (digit_to_number): Move earlier, for benefit of read_integer.
6854 Return -1 if the digit is out of range for the base, -2 if it is
6855 not a digit in any supported base. (Bug#8602)
6856
6857 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6858
6859 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6860 to match comment at start of function. This also removes a
6861 GCC warning about overflow in a 32+64-bit port.
6862
6863 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6864
6865 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6866 Reported by Stefan Monnier in
6867 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6868 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6869 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6870
6871 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6872 (EMACS_UINTPTR): Likewise, with uintptr_t.
6873
6874 * lisp.h: Prefer 64-bit EMACS_INT if available.
6875 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6876 on 32-bit hosts that have 64-bit int, so that they can access
6877 large files.
6878 However, temporarily disable this change unless the temporary
6879 symbol WIDE_EMACS_INT is defined.
6880
6881 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6882
6883 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6884 This removes an assumption that EMACS_INT and long are the same
6885 width as pointers. The assumption is true for Emacs porting targets
6886 now, but we want to make other targets possible.
6887 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6888 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6889 In the rest of the code, change types of integers that hold casted
6890 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6891 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6892 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6893 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6894 No need to cast type when ORing.
6895 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6896 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6897 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6898 assume EMACS_INT is the same width as char *.
6899 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6900 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6901 Remove no-longer-needed casts.
6902 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6903 (xg_tool_bar_help_callback, xg_make_tool_item):
6904 Use EMACS_INTPTR to hold an integer
6905 that will be cast to void *; this can avoid a GCC warning
6906 if EMACS_INT is not the same width as void *.
6907 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6908 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6909 (current_message_1, set_message_1):
6910 Use a local to convert to proper width without a cast.
6911 * xmenu.c (dialog_selection_callback): Likewise.
6912
6913 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6914 Also, don't assume VALBITS / RAND_BITS is less than 5,
6915 and don't rely on undefined behavior when shifting a 1 left into
6916 the sign bit.
6917 * lisp.h (get_random): Change signature to match.
6918
6919 * lread.c (hash_string): Use size_t, not int, for hash computation.
6920 Normally we prefer signed values; but hashing is special, because
6921 it's better to use unsigned division on hash table sizes so that
6922 the remainder is nonnegative. Also, size_t is the natural width
6923 for hashing into memory. The previous code used 'int', which doesn't
6924 retain enough info to hash well into very large tables.
6925 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6926
6927 * dbusbind.c: Don't possibly lose pointer info when converting.
6928 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6929 Use XPNTR rather than XHASH, so that the high-order bits of
6930 the pointer aren't lost when converting through void *.
6931
6932 * eval.c (Fautoload): Don't double-shift a pointer.
6933
6934 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6935
6936 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6937
6938 * gnutls.c (DEF_GNUTLS_FN):
6939 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6940
6941 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6942
6943 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6944 marker. (Bug#8610)
6945
6946 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6947
6948 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6949 New version that can reserve upto 2GB of heap space.
6950
6951 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6952
6953 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6954
6955 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6956
6957 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6958 `gnutls_certificate_set_x509_key_file'.
6959
6960 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6961
6962 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6963 Update dependencies.
6964
6965 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6966
6967 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6968 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6969 Remove unused parameter `fildes'.
6970 * process.c (read_process_output, send_process): Don't pass it.
6971
6972 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6973
6974 Fix previous change: the library cache is defined in w32.c.
6975 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6976 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6977
6978 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6979
6980 Implement dynamic loading of GnuTLS on Windows.
6981
6982 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6983 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6984 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6985 Declare.
6986
6987 * gnutls.c (Qgnutls_dll): Define.
6988 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6989 (gnutls_*): Declare function pointers.
6990 (init_gnutls_functions): New function to initialize function pointers.
6991 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6992 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6993 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6994 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6995 (emacs_gnutls_write, emacs_gnutls_read)
6996 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6997 (Fgnutls_available_p): New function.
6998 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6999 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7000 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7001
7002 * image.c: Include w32.h.
7003 (Vimage_type_cache): Delete.
7004 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7005 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7006 (w32_delayed_load): Move to w32.c.
7007
7008 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7009
7010 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7011 (w32_delayed_load): Move from image.c. When loading a library, record
7012 its filename in the :loaded-from property of the library id.
7013 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7014 Initialize and staticpro them.
7015 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7016
7017 * process.c: Include lisp.h before w32.h, not after.
7018 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7019 instead of gnutls_record_check_pending.
7020
7021 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7022
7023 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7024
7025 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7026 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7027 as passed in.
7028
7029 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7030
7031 * xterm.c (x_set_frame_alpha): Do not set property on anything
7032 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7033
7034 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7035
7036 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7037
7038 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7039
7040 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7041 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7042 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7043 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7044 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7045 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7046 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7047 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7048 (Qgnutls_bootprop_callbacks_verify): Make static.
7049
7050 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7051
7052 * callproc.c: Indentation fixup.
7053
7054 * sysdep.c (wait_for_termination_1): Make static.
7055 (wait_for_termination, interruptible_wait_for_termination):
7056 Move after wait_for_termination_1.
7057
7058 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7059
7060 * sysdep.c (interruptible_wait_for_termination): New function
7061 which is like wait_for_termination, but allows keyboard
7062 interruptions.
7063
7064 * callproc.c (Fcall_process): Add (:file "file") as an option for
7065 the STDOUT buffer.
7066 (Fcall_process_region): Ditto.
7067
7068 2011-04-30 Eli Zaretskii <eliz@gnu.org>
7069
7070 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7071 rather than `XVECTOR (FOO)->size'.
7072
7073 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7074 inttypes.h, as a gnulib replacement is used if it not available in
7075 system headers.
7076
7077 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7078
7079 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7080 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7081 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7082
7083 * coding.c (coding_alloc_by_realloc): Error out if destination
7084 will grow beyond MOST_POSITIVE_FIXNUM.
7085 (decode_coding_emacs_mule): Abort if there isn't enough place in
7086 charbuf for the composition carryover bytes. Reserve an extra
7087 space for up to 2 characters produced in a loop.
7088 (decode_coding_iso_2022): Abort if there isn't enough place in
7089 charbuf for the composition carryover bytes.
7090
7091 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7092
7093 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7094 aborting when %lld or %lll format is passed.
7095 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7096 %llo or %llx format is passed. (Bug#8545)
7097
7098 * window.c (window_scroll_line_based): Use a marker instead of
7099 simple variables to record original value of point. (Bug#7952)
7100
7101 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7102 produced by %s or %c overflows available buffer space. (Bug#8545)
7103
7104 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7105
7106 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
7107 (SIZE_MAX): Move defn after all includes, as they might #define it.
7108
7109 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7110
7111 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7112
7113 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7114
7115 * keyboard.c (Qdelayed_warnings_hook): Define.
7116 (command_loop_1): Run `delayed-warnings-hook'
7117 if Vdelayed_warnings_list is non-nil.
7118 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7119 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7120
7121 2011-04-28 Eli Zaretskii <eliz@gnu.org>
7122
7123 * doprnt.c (doprnt): Don't return value smaller than the buffer
7124 size if the message was truncated. (Bug#8545).
7125
7126 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7127
7128 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7129 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7130
7131 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7132
7133 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7134
7135 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
7136
7137 * makefile.w32-in: Update dependencies.
7138
7139 2011-04-27 Eli Zaretskii <eliz@gnu.org>
7140
7141 Improve `doprnt' and its usage. (Bug#8545)
7142 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7143 `format_end'. Remove support for %l as a conversion specifier.
7144 Don't use xrealloc. Improve diagnostics when the %l size modifier
7145 is used. Update the commentary.
7146
7147 * eval.c (verror): Simplify calculation of size_t.
7148
7149 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7150 messages.
7151
7152 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7153
7154 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7155 change.
7156
7157 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7158
7159 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7160 This makes this file independent of the recent pseudovector change.
7161
7162 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7163
7164 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7165
7166 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7167 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7168 Remove unused local.
7169 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7170
7171 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7172 GCC 4.6.0 optimizes based on type-based alias analysis.
7173 For example, if b is of type struct buffer * and v of type struct
7174 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7175 != &v->size, and therefore "v->size = 1; b->size = 2; return
7176 v->size;" must therefore return 1. This assumption is incorrect
7177 for Emacs, since it type-puns struct Lisp_Vector * with many other
7178 types. To fix this problem, this patch adds a new type struct
7179 vectorlike_header that documents the constraints on layout of vectors
7180 and pseudovectors, and helps optimizing compilers not get fooled
7181 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7182 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7183 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7184 the size member.
7185 (XSETPVECTYPE): Rewrite in terms of new macro.
7186 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7187 This is a bit clearer, and further avoids the possibility of
7188 undesirable aliasing.
7189 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7190 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7191 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7192 since Lisp_Subr is a special case (no "next" field).
7193 (ASIZE): Now uses header.size rather than size.
7194 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7195 to avoid the hassle of writing XVECTOR (foo)->header.size.
7196 (struct vectorlike_header): New type.
7197 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7198 object, to help avoid aliasing.
7199 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7200 (SUBRP): Likewise, since Lisp_Subr is a special case.
7201 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7202 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7203 (struct Lisp_Hash_Table): Combine first two members into a single
7204 struct vectorlike_header member. All uses of "size" and "next" members
7205 changed to be "header.size" and "header.next".
7206 * buffer.h (struct buffer): Likewise.
7207 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7208 * frame.h (struct frame): Likewise.
7209 * process.h (struct Lisp_Process): Likewise.
7210 * termhooks.h (struct terminal): Likewise.
7211 * window.c (struct save_window_data, struct saved_window): Likewise.
7212 * window.h (struct window): Likewise.
7213 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7214 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7215 * buffer.c (init_buffer_once): Likewise.
7216 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7217 special case.
7218 * process.c (Fformat_network_address): Use local var for size,
7219 for brevity.
7220
7221 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7222
7223 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7224 * data.c (atof): Remove decl; no longer used or needed.
7225 (digit_to_number): Move to lread.c.
7226 (Fstring_to_number): Use new string_to_number function, to be
7227 consistent with how the Lisp reader treats infinities and NaNs.
7228 Do not assume that floating-point numbers represent EMACS_INT
7229 without losing information; this is not true on most 64-bit hosts.
7230 Avoid double-rounding errors, by insisting on integers when
7231 parsing non-base-10 numbers, as the documentation specifies.
7232 * lisp.h (string_to_number): New decl, replacing ...
7233 (isfloat_string): Remove.
7234 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7235 (read1): Do not accept +. and -. as integers; this
7236 appears to have been a coding error. Similarly, do not accept
7237 strings like +-1e0 as floating point numbers. Do not report
7238 overflow for integer overflows unless the base is not 10 which
7239 means we have no simple and reliable way to continue.
7240 Break out the floating-point parsing into a new
7241 function string_to_number, so that Fstring_to_number parses
7242 floating point numbers consistently with the Lisp reader.
7243 (digit_to_number): Move here from data.c. Make it static inline.
7244 (E_CHAR, EXP_INT): Remove, replacing with ...
7245 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7246 (string_to_number): New function, replacing isfloat_string.
7247 This function checks for valid syntax and produces the resulting
7248 Lisp float number too. Rework it so that string-to-number
7249 no longer mishandles examples like "1.0e+". Use strtoumax,
7250 so that overflow for non-base-10 numbers is reported only when
7251 there's no portable and simple way to convert to floating point.
7252
7253 * textprop.c (set_text_properties_1): Rewrite for clarity,
7254 and to avoid GCC warning about integer overflow.
7255
7256 * intervals.h (struct interval): Use EMACS_INT for members
7257 where EMACS_UINT might cause problems. See
7258 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7259 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7260 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7261 All uses changed.
7262 (offset_intervals): Tell GCC not to worry about length overflow
7263 when negating a negative length.
7264
7265 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7266 (overrun_check_free): Likewise.
7267
7268 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7269 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7270 word size.
7271
7272 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7273 (gnutls_make_error): Rename local to avoid shadowing.
7274 (gnutls_emacs_global_deinit): ifdef out; not used.
7275 (Fgnutls_boot): Use const for pointer to readonly storage.
7276 Comment out unused local. Fix pointer signedness problems.
7277
7278 * lread.c (openp): Don't stuff size_t into an 'int'.
7279 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7280 about possible signed overflow.
7281
7282 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7283 (GDK_KEY_g): Don't define if already defined.
7284 (xg_prepare_tooltip): Avoid pointer signedness problem.
7285 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7286
7287 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7288 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7289
7290 * xfns.c (Fx_window_property): Simplify a bit,
7291 to make a bit faster and to avoid GCC 4.6.0 warning.
7292 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7293
7294 * fns.c (internal_equal): Don't assume size_t fits in int.
7295
7296 * alloc.c (compact_small_strings): Tighten assertion a little.
7297
7298 Replace pEd with more-general pI, and fix some printf arg casts.
7299 * lisp.h (pI): New macro, generalizing old pEd macro to other
7300 conversion specifiers. For example, use "...%"pI"d..." rather
7301 than "...%"pEd"...".
7302 (pEd): Remove. All uses replaced with similar uses of pI.
7303 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7304 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7305 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7306 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7307 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7308 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7309 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7310 64-bit hosts.
7311 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7312 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7313 * print.c (safe_debug_print, print_object): Likewise.
7314 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7315 to int.
7316 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7317 avoiding the 0 flag, which is not portable.
7318 * process.c (Fmake_network_process): Use pI to avoid cast.
7319 * region-cache.c (pp_cache): Likewise.
7320 * xdisp.c (decode_mode_spec): Likewise.
7321 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7322 behavior on 64-bit hosts with printf arg.
7323 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7324 (x_stop_queuing_selection_requests): Likewise.
7325 (x_get_window_property): Don't truncate byte count to an 'int'
7326 when tracing.
7327
7328 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7329 here, since it parses constructs like leading '-' and spaces,
7330 which are not wanted; and it overflows with large numbers.
7331 Instead, simply match F[0-9]+, which is what is wanted anyway.
7332
7333 * alloc.c: Remove unportable assumptions about struct layout.
7334 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7335 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7336 (allocate_vectorlike, make_pure_vector): Use the new macros,
7337 plus offsetof, to remove unportable assumptions about struct layout.
7338 These assumptions hold on all porting targets that I know of, but
7339 they are not guaranteed, they're easy to remove, and removing them
7340 makes further changes easier.
7341
7342 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7343 This doesn't fix a bug but makes the code clearer.
7344 (string_overrun_cookie): Now const. Use initializers that
7345 don't formally overflow signed char, to avoid warnings.
7346 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7347 can cause Emacs to crash when string overrun checking is enabled.
7348 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7349 multiple of sizeof (EMACS_INT); it need not be, if
7350 alignof(EMACS_INT) < sizeof (EMACS_INT).
7351 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7352
7353 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7354
7355 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7356
7357 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7358
7359 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7360 supposed to be handshaking. (Bug#8556)
7361 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7362
7363 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7364
7365 * lisp.h (Qdebug): List symbol.
7366 * eval.c (Qdebug): Restore global linkage.
7367 * keyboard.c (debug-on-event): New variable.
7368 (handle_user_signal): Break into debugger when debug-on-event
7369 matches the current signal symbol.
7370
7371 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7372
7373 * alloc.c (check_sblock, check_string_bytes)
7374 (check_string_free_list): Convert to standard C.
7375
7376 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7377
7378 * w32.c (emacs_gnutls_push): Fix typo.
7379
7380 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7381
7382 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7383 "cast to pointer from integer of different size".
7384
7385 Improve doprnt and its use in verror. (Bug#8545)
7386 * doprnt.c (doprnt): Document the set of format control sequences
7387 supported by the function. Use SAFE_ALLOCA instead of always
7388 using `alloca'.
7389
7390 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7391 is one byte too soon. Don't use xrealloc; instead xfree and
7392 xmalloc anew.
7393
7394 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7395
7396 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7397 callbacks stage.
7398
7399 * gnutls.c: Renamed global_initialized to
7400 gnutls_global_initialized. Added internals for the
7401 :verify-hostname-error, :verify-error, and :verify-flags
7402 parameters of `gnutls-boot' and documented those parameters in the
7403 docstring. Start callback support.
7404 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7405 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7406 on error. Return error code.
7407 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7408 (emacs_gnutls_read): Likewise.
7409 (Fgnutls_boot): Return handshake error code.
7410 (emacs_gnutls_handle_error): New function.
7411 (wsaerror_to_errno): Likewise.
7412
7413 * w32.h (emacs_gnutls_pull): Add prototype.
7414 (emacs_gnutls_push): Likewise.
7415
7416 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7417 (emacs_gnutls_push): Likewise.
7418
7419 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7420
7421 * process.c (wait_reading_process_output): Check if GnuTLS
7422 buffered some data internally if no FDs are set for TLS
7423 connections.
7424
7425 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7426 (LIBS): Link to USER_LIBS.
7427 ($(BLD)/gnutls.$(0)): New target.
7428
7429 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7430
7431 * xdisp.c (handle_single_display_spec): Rename the
7432 display_replaced_before_p argument into display_replaced_p, to
7433 make it consistent with the commentary. Fix typos in the
7434 commentary.
7435
7436 * textprop.c (syms_of_textprop): Remove dead code.
7437 (copy_text_properties): Delete obsolete commentary about an
7438 interface that was deleted long ago. Fix typos in the description
7439 of arguments.
7440
7441 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7442 to changes in oldXMenu/XMenu.h from 2011-04-16.
7443 <menu_help_message, prev_menu_help_message>: Constify.
7444 (IT_menu_make_room): menu->help_text is now `const char **';
7445 adjust.
7446
7447 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7448 to changes in oldXMenu/XMenu.h from 2011-04-16.
7449 (struct XMenu): Declare `help_text' `const char **'.
7450
7451 * xfaces.c <Qunspecified>: Make extern again.
7452
7453 * syntax.c: Include sys/types.h before including regex.h, as
7454 required by POSIX.
7455
7456 * doc.c (get_doc_string): Improve the format passed to `error'.
7457
7458 * doprnt.c (doprnt): Improve commentary.
7459
7460 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7461
7462 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7463 them with etags.
7464
7465 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7466 changes in globals.h immediately force recompilation.
7467 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7468 $(CURDIR)/s/ms-w32.h.
7469 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7470
7471 * character.c (Fchar_direction): Function deleted.
7472 (syms_of_character): Don't defsubr it.
7473 <char-direction-table>: Deleted.
7474
7475 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7476
7477 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7478 * doprnt.c: Include limits.h.
7479 (SIZE_MAX): New macro.
7480 (doprnt): Return a size_t value. 2nd arg is now size_t.
7481 Many local variables are now size_t instead of int or unsigned.
7482 Improve overflow protection. Support `l' modifier for integer
7483 conversions. Support %l conversion. Don't assume an EMACS_INT
7484 argument for integer conversions and for %c.
7485
7486 * lisp.h (doprnt): Restore prototype.
7487
7488 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7489 $(SRC)/character.h.
7490
7491 * Makefile.in (base_obj): Add back doprnt.o.
7492
7493 * deps.mk (doprnt.o): Add back prerequisites.
7494 (callint.o): Depend on character.h.
7495
7496 * eval.c (internal_lisp_condition_case): Include the handler
7497 representation in the error message.
7498 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7499 when breaking from the loop.
7500
7501 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7502
7503 * callint.c (Fcall_interactively): When displaying error message
7504 about invalid control letter, pass the character's codepoint, not
7505 a pointer to its multibyte form. Improve display of the character
7506 in octal and display also its hex code.
7507
7508 * character.c (char_string): Use %x to display the (unsigned)
7509 codepoint of an invalid character, to avoid displaying a bogus
7510 negative value.
7511
7512 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7513 `error', not SYMBOL_NAME itself.
7514
7515 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7516 character arguments to `error'.
7517
7518 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7519 to `error' in error message about FINAL_CHAR argument. Make sure
7520 FINAL_CHAR is a character, and use %c when it is passed as
7521 argument to `error'.
7522
7523 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7524
7525 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7526
7527 * w32.c: Include <time.h>.
7528 (sys_localtime): New function.
7529
7530 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7531
7532 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7533
7534 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7535
7536 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7537
7538 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7539 zombies (Bug#8467).
7540
7541 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7542
7543 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7544 gl_state.e_property when gl_state.object is Qt.
7545
7546 * insdel.c (make_gap_larger): Remove limitation of buffer size
7547 to <= INT_MAX.
7548
7549 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7550
7551 * xdisp.c (lookup_glyphless_char_display)
7552 (produce_glyphless_glyph): Handle cons cell entry in
7553 glyphless-char-display.
7554 (Vglyphless_char_display): Document it.
7555
7556 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7557 glyphless-char-display.
7558
7559 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7560
7561 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7562
7563 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7564
7565 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7566 definition for no-X builds.
7567
7568 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7569
7570 Static checks with GCC 4.6.0 and non-default toolkits.
7571
7572 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7573
7574 * process.c (keyboard_bit_set): Define only if SIGIO.
7575 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7576 (send_process): Repair possible setjmp clobbering.
7577
7578 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7579
7580 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7581
7582 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7583
7584 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7585 Define only if needed.
7586
7587 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7588 by pacifying GCC about it. Maybe it's time to retire it?
7589 * xfaces.c (USG, __TIMEVAL__): Likewise.
7590
7591 * dispextern.h (struct redisplay_interface): Rename param
7592 to avoid shadowing.
7593 * termhooks.h (struct terminal): Likewise.
7594 * xterm.c (xembed_send_message): Likewise.
7595
7596 * insdel.c (make_gap_smaller): Define only if
7597 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7598
7599 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7600 it.
7601
7602 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7603 so that we aren't warned about unused symbols.
7604
7605 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7606
7607 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7608
7609 * xfns.c (x_real_positions): Mark locals as initialized.
7610
7611 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7612
7613 * xterm.c: Fix problems found by static analysis with other toolkits.
7614 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7615 (x_dispatch_event): Declare static if USE_GTK, and
7616 define if USE_GTK || USE_X_TOOLKIT.
7617 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7618 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7619 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7620 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7621
7622 * xmenu.c (menu_help_callback): Pointer type fixes.
7623 Use const pointers when pointing at readonly data. Avoid pointer
7624 signedness clashes.
7625 (FALSE): Remove unused macro.
7626 (update_frame_menubar): Remove unused decl.
7627
7628 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7629
7630 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7631 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7632 (single_menu_item): Rename local to avoid shadowing.
7633
7634 * keyboard.c (make_lispy_event): Remove unused local var.
7635
7636 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7637 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7638
7639 * bitmaps: Change bitmaps from unsigned char back to the X11
7640 compatible char. Avoid the old compiler warnings about
7641 out-of-range initializers by using, for example, '\xab' rather
7642 than 0xab.
7643
7644 * xgselect.c (xgselect_initialize): Check vs interface
7645 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7646
7647 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7648
7649 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7650 to read-only memory.
7651
7652 * fns.c (vector): Remove; this old hack is no longer needed.
7653
7654 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7655 Remove unused var.
7656 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7657
7658 * xrdb.c (x_load_resources): Omit unused local.
7659
7660 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7661 (x_window): Rename locals to avoid shadowing.
7662 (USG): Use the kludged USG macro, to pacify gcc.
7663
7664 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7665 (x_term_init): Remove local to avoid shadowing.
7666
7667 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7668
7669 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7670 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7671
7672 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7673
7674 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7675
7676 Fix regex.c, syntax.c and friends for buffers > 2GB.
7677 * syntax.h (struct gl_state_s): Declare character position members
7678 EMACS_INT.
7679
7680 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7681
7682 * textprop.c (verify_interval_modification, interval_of):
7683 Declare arguments EMACS_INT.
7684
7685 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7686 EMACS_INT.
7687
7688 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7689
7690 * indent.c (Fvertical_motion): Local variable it_start is now
7691 EMACS_INT.
7692
7693 * regex.c (re_match, re_match_2, re_match_2_internal)
7694 (bcmp_translate, regcomp, regexec, print_double_string)
7695 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7696 (re_compile_pattern, re_exec): Declare arguments and local
7697 variables `size_t' and `ssize_t' and return values `regoff_t', as
7698 appropriate.
7699 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7700 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7701 <compile_stack_type>: `size' and `avail' are now `size_t'.
7702
7703 * regex.h <regoff_t>: Use ssize_t, not int.
7704 (re_search, re_search_2, re_match, re_match_2): Arguments that
7705 specify buffer/string position and length are now ssize_t and
7706 size_t. Return type is regoff_t.
7707
7708 2011-04-16 Ben Key <bkey76@gmail.com>
7709
7710 * nsfont.m: Fixed bugs in ns_get_family and
7711 ns_descriptor_to_entity that were caused by using free to
7712 deallocate memory blocks that were allocated by xmalloc (via
7713 xstrdup). This caused Emacs to crash when compiled with
7714 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7715 --enable-checking=xmallocoverrun). xfree is now used to
7716 deallocate these memory blocks.
7717
7718 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7719
7720 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7721
7722 emacs_write: Accept and return EMACS_INT for sizes.
7723 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7724 et seq.
7725 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7726 Accept and return EMACS_INT.
7727 (emacs_gnutls_write): Return the number of bytes written on
7728 partial writes.
7729 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7730 (emacs_read, emacs_write): Remove check for negative size, as the
7731 Emacs source code has been audited now.
7732 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7733 (emacs_read, emacs_write): Use it.
7734 * process.c (send_process): Adjust to the new signatures of
7735 emacs_write and emacs_gnutls_write. Do not attempt to store
7736 a byte offset into an 'int'; it might overflow.
7737 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7738
7739 * sound.c: Don't assume sizes fit in 'int'.
7740 (struct sound_device.period_size, alsa_period_size):
7741 Return EMACS_INT, not int.
7742 (struct sound_device.write, vox_write, alsa_write):
7743 Accept EMACS_INT, not int.
7744 (wav_play, au_play): Use EMACS_INT to store sizes and to
7745 record read return values.
7746
7747 2011-04-15 Ben Key <bkey76@gmail.com>
7748
7749 * keyboard.c (Qundefined): Don't declare static since it is used
7750 in nsfns.m.
7751 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7752 static since they are used in nsfont.m.
7753
7754 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7755
7756 * process.c (Qprocessp): Don't declare static.
7757 * lisp.h (Qprocessp): Declare again.
7758
7759 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7760
7761 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7762
7763 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7764
7765 Improve C-level modularity by making more things 'static'.
7766
7767 Don't publish debugger-only interfaces to other modules.
7768 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7769 (verify_bytepos, count_markers): Move decls to the only modules
7770 that need them.
7771 * region-cache.h (pp_cache): Likewise.
7772 * window.h (check_all_windows): Likewise.
7773 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7774
7775 * sysdep.c (croak): Now static, if
7776 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7777 * syssignal.h (croak): Declare only if not static.
7778
7779 * alloc.c (refill_memory_reserve): Now static if
7780 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7781 * lisp.h (refill_memory_reserve): Declare only if not static.
7782
7783 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7784 Define only if USE_LUCID.
7785
7786 * xrdb.c (x_customization_string, x_rm_string): Now static.
7787
7788 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7789 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7790
7791 * xdisp.c (draw_row_with_mouse_face): Now static.
7792 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7793
7794 * window.h (check_all_windows): Mark externally visible.
7795
7796 * window.c (window_deletion_count): Now static.
7797
7798 * undo.c: Make symbols static if they're not exported.
7799 (last_undo_buffer, last_boundary_position, pending_boundary):
7800 Now static.
7801
7802 * textprop.c (interval_insert_behind_hooks): Now static.
7803 (interval_insert_in_front_hooks): Likewise.
7804
7805 * term.c: Make symbols static if they're not exported.
7806 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7807 (max_frame_lines, tty_set_terminal_modes):
7808 (tty_reset_terminal_modes, tty_turn_off_highlight):
7809 (get_tty_terminal): Now static.
7810 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7811 * termhooks.h (term_mouse_moveto): Do not declare if
7812 HAVE_WINDOW_SYSTEM.
7813 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7814 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7815
7816 * sysdep.c: Make symbols static if they're not exported.
7817 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7818 Now static.
7819 (sigprocmask_set, full_mask): Remove; unused.
7820 (wait_debugging): Mark as visible.
7821 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7822 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7823
7824 * syntax.c (syntax_temp): Define only if !__GNUC__.
7825
7826 * sound.c (current_sound_device, current_sound): Now static.
7827
7828 * search.c (searchbufs, searchbuf_head): Now static.
7829
7830 * scroll.c (scroll_cost): Remove; unused.
7831 * dispextern.h (scroll_cost): Remove decl.
7832
7833 * region-cache.h (pp_cache): Mark as externally visible.
7834
7835 * process.c: Make symbols static if they're not exported.
7836 (process_tick, update_tick, create_process, chan_process):
7837 (Vprocess_alist, proc_buffered_char, datagram_access):
7838 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7839 (deactivate_process): Mark defn as static, as well as decl.
7840 * lisp.h (create_process): Remove decl.
7841 * process.h (chan_process, Vprocess_alist): Remove decls.
7842
7843 * print.c: Make symbols static if they're not exported.
7844 (print_depth, new_backquote_output, being_printed, print_buffer):
7845 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7846 (print_interval, print_number_index, initial_stderr_stream):
7847 Now static.
7848 * lisp.h (Fprinc): Remove decl.
7849 (debug_output_compilation_hack): Mark as externally visible.
7850
7851 * sysdep.c (croak): Move decl from here to syssignal.h.
7852 * syssignal.h (croak): Put it here, so the API can be checked when
7853 'croak' is called from dissociate_if_controlling_tty.
7854
7855 * minibuf.c: Make symbols static if they're not exported.
7856 (minibuf_save_list, choose_minibuf_frame): Now static.
7857 * lisp.h (choose_minibuf_frame): Remove decl.
7858
7859 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7860
7861 * lread.c: Make symbols static if they're not exported.
7862 (read_objects, initial_obarray, oblookup_last_bucket_number):
7863 Now static.
7864 (make_symbol): Remove; unused.
7865 * lisp.h (initial_obarray, make_symbol): Remove decls.
7866
7867 * keyboard.c: Make symbols static if they're not exported.
7868 (single_kboard, recent_keys_index, total_keys, recent_keys):
7869 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7870 (this_single_command_key_start, echoing, last_auto_save):
7871 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7872 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7873 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7874 (Vlispy_mouse_stem, double_click_count):
7875 Now static.
7876 (force_auto_save_soon): Define only if SIGDANGER.
7877 (ignore_mouse_drag_p): Now static if
7878 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7879 (print_help): Remove; unused.
7880 (stop_character, last_timer_event): Mark as externally visible.
7881 * keyboard.h (ignore_mouse_drag_p): Declare only if
7882 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7883 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7884 * lisp.h (echoing): Remove decl.
7885 (force_auto_save_soon): Declare only if SIGDANGER.
7886 * xdisp.c (redisplay_window): Simplify code, to make it more
7887 obvious that ignore_mouse_drag_p is not accessed if !defined
7888 USE_GTK && !defined HAVE_NS.
7889
7890 * intervals.c: Make symbols static if they're not exported.
7891 (merge_properties_sticky, merge_interval_right, delete_interval):
7892 Now static.
7893 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7894
7895 * insdel.c: Make symbols static if they're not exported.
7896 However, leave prepare_to_modify_buffer alone. It's never
7897 called from outside this function, but that appears to be a bug.
7898 (combine_after_change_list, combine_after_change_buffer):
7899 (adjust_after_replace, signal_before_change): Now static.
7900 (adjust_after_replace_noundo): Remove; unused.
7901 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7902 (signal_before_change): Remove decls.
7903
7904 * indent.c (val_compute_motion, val_vmotion): Now static.
7905
7906 * image.c: Make symbols static if they're not exported.
7907 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7908 if USE_GTK.
7909 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7910 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7911
7912 * fringe.c (standard_bitmaps): Now static.
7913 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7914
7915 * frame.c: Make symbols static if they're not exported.
7916 (x_report_frame_params, make_terminal_frame): Now static.
7917 (get_frame_param): Now static, unless HAVE_NS.
7918 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7919 (x_get_resource_string): Remove; not used.
7920 * frame.h (make_terminal_frame, x_report_frame_params):
7921 (x_get_resource_string); Remove decls.
7922 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7923 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7924
7925 * font.c, fontset.c: Make symbols static if they're not exported.
7926 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7927 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7928 * font.c (font_close_object): Now static.
7929 * font.h (font_close_object): Remove.
7930 * fontset.c (FONTSET_OBJLIST): Remove.
7931 (free_realized_fontset) #if-0 the body, which does nothing.
7932 (face_suitable_for_char_p): #if-0, as it's never called.
7933 * fontset.h (face_suitable_for_char_p): Remove decl.
7934 * xfaces.c (face_at_string_position):
7935 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7936 since 0 is always ASCII.
7937
7938 * fns.c (weak_hash_tables): Now static.
7939
7940 * fileio.c: Make symbols static if they're not exported.
7941 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7942 (Vwrite_region_annotation_buffers): Now static.
7943
7944 * eval.c: Make symbols static if they're not exported.
7945 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7946 * lisp.h (backtrace_list): Remove decl.
7947
7948 * emacs.c: Make symbols static if they're not exported.
7949 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7950 (fatal_error_code, fatal_error_signal_hook, standard_args):
7951 Now static.
7952 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7953 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7954 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7955 * lisp.h (fatal_error_signal_hook): Remove decl.
7956 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7957
7958 * editfns.c: Move a (normally-unused) function to its only use.
7959 * editfns.c, lisp.h (get_operating_system_release): Remove.
7960 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7961 worth the hassle of breaking this out.
7962
7963 * xterm.c: Make symbols static if they're not exported.
7964 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7965 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7966 (x_destroy_window, x_delete_display):
7967 Now static.
7968 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7969 (x_mouse_leave): Remove; unused.
7970 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7971 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7972 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7973 Remove decls.
7974 (x_mouse_leave): Declare only if WINDOWSNT.
7975 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7976 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7977 USE_X_TOOLKIT.
7978
7979 * ftxfont.c: Make symbols static if they're not exported.
7980 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7981 HAVE_FREETYPE.
7982 * font.h (ftxfont_driver): Likewise.
7983
7984 * xfns.c: Make symbols static if they're not exported.
7985 (x_last_font_name, x_display_info_for_name):
7986 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7987 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7988 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7989 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7990 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7991 (last_show_tip_args): Now static.
7992 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7993 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7994 (x_screen_planes): Remove; unused.
7995 * dispextern.h (x_screen_planes): Remove decl.
7996
7997 * dispnew.c: Make symbols static if they're not exported.
7998 * dispextern.h (redraw_garbaged_frames, scrolling):
7999 (increment_row_positions): Remove.
8000 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8001 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8002 Now static.
8003 (redraw_garbaged_frames): Remove; unused.
8004
8005 * xfaces.c: Make symbols static if they're not exported.
8006 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8007 Remove decls.
8008 * xterm.h (defined_color): Remove decls.
8009 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8010 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8011 (menu_face_changed_default, defined_color, free_realized_face):
8012 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8013 (ascii_face_of_lisp_face): Remove; unused.
8014
8015 * xdisp.c: Make symbols static if they're not exported.
8016 * dispextern.h (scratch_glyph_row, window_box_edges):
8017 (glyph_to_pixel_coords, set_cursor_from_row):
8018 (get_next_display_element, set_iterator_to_next):
8019 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8020 (show_mouse_face): Remove decls
8021 * frame.h (message_buf_print): Likewise.
8022 * lisp.h (pop_message, set_message, check_point_in_composition):
8023 Likewise.
8024 * xterm.h (set_vertical_scroll_bar): Likewise.
8025 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8026 (message_buf_print, scratch_glyph_row, displayed_buffer):
8027 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8028 (get_next_display_element, show_mouse_face, window_box_edges):
8029 (frame_to_window_pixel_xy, check_point_in_composition):
8030 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8031 (glyph_to_pixel_coords): Remove; unused.
8032
8033 * dired.c (file_name_completion): Now static.
8034
8035 * dbusbind.c (xd_in_read_queued_messages): Now static.
8036
8037 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8038 * data.c (circular_list_error): Remove.
8039
8040 * commands.h (last_point_position, last_point_position_buffer):
8041 (last_point_position_window): Remove decls.
8042 * keyboard.c: Make these variables static.
8043
8044 * coding.h (coding, code_convert_region, encode_coding_gap):
8045 Remove decls.
8046 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8047 (iso_code_class, detect_coding, code_convert_region): Now static.
8048 (encode_coding_gap): Remove; unused.
8049
8050 * chartab.c (chartab_chars, chartab_bits): Now static.
8051
8052 * charset.h (charset_iso_8859_1): Remove decl.
8053 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8054 Now static.
8055
8056 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8057 * ccl.c (Vccl_program_table): Now static.
8058 (check_ccl_update): Remove; unused.
8059
8060 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8061 * category.h: ... from here.
8062 * category.c (check_category_table, set_category_set): Now static.
8063
8064 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8065 * lisp.h: Remove these decls.
8066
8067 * buffer.c (buffer_count): Remove unused var.
8068
8069 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8070 so that it's not optimized away.
8071 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8072 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8073 exported only to the debugger.
8074
8075 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
8076 * atimer.h (run_all_atimers): Remove; not exported.
8077
8078 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8079 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8080 was inaccessible from Lisp.
8081 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8082 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8083
8084 alloc.c: Import and export fewer symbols, and remove unused items.
8085 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8086 is defined.
8087 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8088 it's not optimized away by whole-program optimization.
8089 (message_enable_multibyte, free_misc): Remove.
8090 (catchlist, handlerlist, mark_backtrace):
8091 Declare only if BYTE_MARK_STACK.
8092 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8093 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8094 (message_enable_multibyte): Remove decl.
8095 (free_misc, interval_free_list, float_block, float_block_index):
8096 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8097 (cons_free_list, last_marked_index):
8098 Now static.
8099 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8100 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8101 (mark_backtrace): Define only if BYTE_MARK_STACK.
8102 * xdisp.c (message_enable_multibyte): Now static.
8103
8104 Declare Lisp_Object Q* variables to be 'static' if not exported.
8105 This makes it easier for human readers (and static analyzers)
8106 to see whether these variables are used from other modules.
8107 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8108 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8109 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8110 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8111 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8112 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8113 * xmenu.c, xselect.c:
8114 Declare Q* vars static if they are not used in other modules.
8115 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8116 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8117 Remove decls of unexported vars.
8118 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8119
8120 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8121
8122 Make Emacs functions such as Fatom 'static' by default.
8123 This makes it easier for human readers (and static analyzers)
8124 to see whether these functions can be called from other modules.
8125 DEFUN now defines a static function. To make the function external
8126 so that it can be used in other C modules, use the new macro DEFUE.
8127 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8128 (Finit_image_library):
8129 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8130 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8131 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8132 Remove decls, since these functions are now static.
8133 (Funintern, Fget_internal_run_time): New decls, since these functions
8134 were already external.
8135
8136 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8137 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8138 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8139 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8140 * keyboard.c, keymap.c, lread.c:
8141 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8142 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8143 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8144 Mark functions with DEFUE instead of DEFUN,
8145 if they are used in other modules.
8146 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8147 decls for now-static functions.
8148 * buffer.h (Fdelete_overlay): Remove decl.
8149 * callproc.c (Fgetenv_internal): Mark as internal.
8150 * composite.c (Fremove_list_of_text_properties): Remove decl.
8151 (Fcomposition_get_gstring): New forward static decl.
8152 * composite.h (Fcomposite_get_gstring): Remove decl.
8153 * dired.c (Ffile_attributes): New forward static decl.
8154 * doc.c (Fdocumntation_property): New forward static decl.
8155 * eval.c (Ffetch_bytecode): New forward static decl.
8156 (Funintern): Remove extern decl; now in .h file where it belongs.
8157 * fileio.c (Fmake_symbolic_link): New forward static decl.
8158 * image.c (Finit_image_library): New forward static decl.
8159 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8160 * intervals.h (Fprevious_property_change):
8161 (Fremove_list_of_text_properties): Remove decls.
8162 * keyboard.c (Fthis_command_keys): Remove decl.
8163 (Fcommand_execute): New forward static decl.
8164 * keymap.c (Flookup_key): New forward static decl.
8165 (Fcopy_keymap): Now static.
8166 * keymap.h (Flookup_key): Remove decl.
8167 * process.c (Fget_process): New forward static decl.
8168 (Fprocess_datagram_address): Mark as internal.
8169 * syntax.c (Fsyntax_table_p): New forward static decl.
8170 (skip_chars): Remove duplicate decl.
8171 * textprop.c (Fprevious_property_change): New forward static decl.
8172 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8173 Now internal.
8174 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8175 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8176
8177 * editfns.c (Fformat): Remove unreachable code.
8178
8179 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8180
8181 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8182 change. (Bug#8496)
8183
8184 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8185
8186 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8187 when at ZV. (Bug#8487)
8188
8189 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8190
8191 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8192 (Bug#8437)
8193 * keyboard.c (parse_tool_bar_item): Likewise.
8194 * sound.c (sound_cleanup, alsa_close): Likewise.
8195 * termcap.c (tgetent): Likewise.
8196 * xfns.c (x_default_font_parameter): Likewise.
8197 * xsettings.c (read_and_apply_settings): Likewise.
8198
8199 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8200 (overrun_check_free): Protoize.
8201
8202 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8203
8204 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8205 since callers should never pass a negative size.
8206 Change the signature to match that of plain 'read' and 'write'; see
8207 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8208 * lisp.h: Update prototypes of emacs_write and emacs_read.
8209
8210 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8211
8212 * xdisp.c (redisplay_window): Don't try to determine the character
8213 position of the scroll margin if the window start point w->startp
8214 is outside the buffer's accessible region. (Bug#8468)
8215
8216 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8217
8218 Fix write-region and its subroutines for buffers > 2GB.
8219 * fileio.c (a_write, e_write): Modify declaration of arguments and
8220 local variables to support buffers larger than 2GB.
8221 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8222
8223 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8224 argument, local variables, and return value.
8225
8226 * lisp.h: Update prototypes of emacs_write and emacs_read.
8227
8228 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8229
8230 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8231
8232 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8233
8234 Fix more problems found by GCC 4.6.0's static checks.
8235
8236 * xdisp.c (vmessage): Use a better test for character truncation.
8237
8238 * charset.c (load_charset_map): <, not <=, for optimization,
8239 and to avoid potential problems with integer overflow.
8240 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8241 * casetab.c (set_identity, shuffle): Likewise.
8242 * editfns.c (Fformat): Likewise.
8243 * syntax.c (skip_chars): Likewise.
8244
8245 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8246 This also lets GCC 4.6.0 generate slightly better loop code.
8247
8248 * callint.c (Fcall_interactively): <, not <=, for optimization.
8249 (Fcall_interactively): Count the number of arguments produced,
8250 not the number of arguments given. This is simpler and lets GCC
8251 4.6.0 generate slightly better code.
8252
8253 * ftfont.c: Distingish more carefully between FcChar8 and char.
8254 The previous code passed unsigned char * to a functions like
8255 strlen and xstrcasecmp that expect char *, which does not
8256 conform to the C standard.
8257 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8258 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8259 char * when the C standard requires it.
8260
8261 * keyboard.c (read_char): Remove unused var.
8262
8263 * eval.c: Port to Windows vsnprintf (Bug#8435).
8264 Include <limits.h>.
8265 (SIZE_MAX): Define if the headers do not.
8266 (verror): Do not give up if vsnprintf returns a negative count.
8267 Instead, grow the buffer. This ports to Windows vsnprintf, which
8268 does not conform to C99. Problem reported by Eli Zaretskii.
8269 Also, simplify the allocation scheme, by avoiding the need for
8270 calling realloc, and removing the ALLOCATED variable.
8271
8272 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8273
8274 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8275 But keep the doprint source code for now, as we might revamp it
8276 and use it again (Bug#8435).
8277 * lisp.h (doprnt): Remove.
8278 * Makefile.in (base_obj): Remove doprnt.o.
8279 * deps.mk (doprnt.o): Remove.
8280
8281 error: Print 32- and 64-bit integers portably (Bug#8435).
8282 Without this change, on typical 64-bit hosts error ("...%d...", N)
8283 was used to print both 32- and 64-bit integers N, which relied on
8284 undefined behavior.
8285 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8286 * lisp.h (error, verror): Mark as printf-like functions.
8287 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8288 Report overflow in size calculations when allocating printf buffer.
8289 Do not truncate output string at its first null byte.
8290 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8291 Truncate the output at a character boundary, since vsnprintf does not
8292 do that.
8293 * charset.c (check_iso_charset_parameter): Convert internal
8294 character to string before calling 'error', since %c now has the
8295 printf meaning.
8296 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8297 overflow when computing char to be passed to 'error'. Do not
8298 pass Lisp_Object to 'error'; pass the integer instead.
8299 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8300 formatted with plain %d.
8301
8302 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8303
8304 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8305
8306 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8307
8308 * xterm.c (x_catch_errors): Remove duplicate declaration.
8309
8310 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8311
8312 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8313
8314 2011-04-10 Jim Meyering <meyering@redhat.com>
8315
8316 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8317 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8318 return ssize_t not "int", and use size_t as the buffer length.
8319 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8320 * gnutls.h: Update declarations.
8321 * process.c (read_process_output): Use ssize_t, to match.
8322 (send_process): Likewise.
8323
8324 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8325
8326 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8327
8328 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8329
8330 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8331 Use unsigned char, to match FcChar8 type definition.
8332
8333 * xterm.c (handle_one_xevent):
8334 * xmenu.c (create_and_show_popup_menu):
8335 * xselect.c (x_decline_selection_request)
8336 (x_reply_selection_request): Avoid type-punned deref of X events.
8337
8338 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8339
8340 Fix some uses of `int' instead of EMACS_INT.
8341 * search.c (string_match_1, fast_string_match)
8342 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8343 (scan_buffer, find_next_newline_no_quit)
8344 (find_before_next_newline, search_command, Freplace_match)
8345 (Fmatch_data): Make some `int' variables be EMACS_INT.
8346
8347 * xdisp.c (display_count_lines): 3rd argument and return value now
8348 EMACS_INT. All callers changed.
8349 (pint2hrstr): Last argument is now EMACS_INT.
8350
8351 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8352 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8353 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8354 (decode_coding_utf_16, decode_coding_emacs_mule)
8355 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8356 (decode_coding_ccl, decode_coding_charset)
8357 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8358 (decode_coding_iso_2022, decode_coding_emacs_mule)
8359 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8360 <char_offset, last_offset>: Declare EMACS_INT.
8361 (encode_coding_utf_8, encode_coding_utf_16)
8362 (encode_coding_emacs_mule, encode_invocation_designation)
8363 (encode_designation_at_bol, encode_coding_iso_2022)
8364 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8365 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8366 Declare EMACS_INT.
8367 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8368 (encode_invocation_designation): Last argument P_NCHARS is now
8369 EMACS_INT.
8370 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8371 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8372
8373 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8374 All users changed.
8375
8376 * ccl.c (Fccl_execute_on_string): Declare some variables
8377 EMACS_INT.
8378
8379 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8380
8381 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8382
8383 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8384
8385 * process.c (Fformat_network_address): Doc fix.
8386
8387 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8388
8389 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8390
8391 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8392
8393 * keyboard.c (read_char): Call Lisp function help-form-show,
8394 instead of using internal_with_output_to_temp_buffer.
8395 (Qhelp_form_show): New var.
8396 (syms_of_keyboard): Use DEFSYM macro.
8397
8398 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8399
8400 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8401
8402 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8403
8404 * process.c (Flist_processes): Remove to Lisp.
8405 (list_processes_1): Delete.
8406
8407 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8408
8409 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8410
8411 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8412
8413 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8414
8415 Fix more problems found by GCC 4.6.0's static checks.
8416
8417 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8418
8419 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8420
8421 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8422
8423 * xdisp.c (vmessage): Mark as a printf-like function.
8424
8425 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8426
8427 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8428
8429 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8430 printf-like functions.
8431 (tiff_load): Add casts to remove these marks before passing them
8432 to system-supplied API.
8433
8434 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8435
8436 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8437 This avoids several warnings with gcc -Wstrict-overflow.
8438 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8439 directly, rather than having caller test rule sign. This avoids
8440 some unnecessary tests.
8441 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8442 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8443 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8444
8445 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8446 (xfont_open): Avoid unnecessary tests.
8447
8448 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8449
8450 * composite.h, composite.c (composition_gstring_put_cache):
8451 Use EMACS_INT, not int, for length.
8452
8453 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8454 breaking out part of COMPOSITION_DECODE_RULE.
8455 (COMPOSITION_DECODE_RULE): Use it.
8456 * composite.c (get_composition_id): Remove unused local vars,
8457 by using the new macro.
8458
8459 * textprop.c (set_text_properties_1): Change while to do-while,
8460 since the condition is always true at first.
8461
8462 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8463 (interval_deletion_adjustment): Return unsigned value.
8464 All uses changed.
8465
8466 * process.c (list_processes_1, create_pty, read_process_output):
8467 (exec_sentinel): Remove vars that were set but not used.
8468 (create_pty): Remove unnecessary "volatile"s.
8469 (Fnetwork_interface_info): Avoid possibility of int overflow.
8470 (read_process_output): Do adaptive read buffering even if carryover.
8471 (read_process_output): Simplify nbytes computation if buffered.
8472
8473 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8474
8475 * syntax.c (scan_words): Remove var that was set but not used.
8476 (update_syntax_table): Use unsigned instead of int.
8477
8478 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8479 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8480 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8481
8482 * print.c (print_error_message): Avoid int overflow.
8483
8484 * font.c (font_list_entities): Redo for clarity,
8485 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8486
8487 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8488 (font_score): Avoid potential overflow in diff calculation.
8489
8490 * fns.c (substring_both): Remove var that is set but not used.
8491 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8492
8493 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8494
8495 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8496 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8497 can always succeed if overflow has undefined behavior.
8498
8499 * search.c (boyer_moore, wordify): Remove vars set but not used.
8500 (wordify): Omit three unnecessary tests.
8501
8502 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8503 All callers changed. This avoids the need for an unused var.
8504
8505 * casefiddle.c (casify_region): Remove var that is set but not used.
8506
8507 * dired.c (file_name_completion): Remove var that is set but not used.
8508
8509 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8510
8511 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8512 (Finsert_file_contents): Remove unnecessary code checking fd.
8513
8514 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8515 Check for integer overflow on size calculations.
8516
8517 * buffer.c (Fprevious_overlay_change): Remove var that is set
8518 but not used.
8519
8520 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8521 Remove vars that are set but not used.
8522 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8523 (timer_check_2): Mark vars as initialized.
8524
8525 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8526
8527 * image.c (lookup_image): Remove var that is set but not used.
8528 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8529
8530 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8531 that are set but not used.
8532
8533 * xfns.c (make_invisible_cursor): Don't return garbage
8534 if XCreateBitmapFromData fails (Bug#8410).
8535
8536 * xselect.c (x_get_local_selection, x_handle_property_notify):
8537 Remove vars that are set but not used.
8538
8539 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8540 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8541
8542 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8543 Remove var that is set but not used.
8544 (scroll_bar_windows_size): Now size_t, not int.
8545 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8546 Check for overflow.
8547
8548 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8549 (map_tty_color) [!defined MSDOS]: Likewise.
8550
8551 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8552
8553 * coding.c: Remove vars that are set but not used.
8554 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8555 All callers changed.
8556 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8557 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8558 (decode_coding_charset): Remove vars that are set but not used.
8559
8560 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8561 that is set but not used.
8562
8563 * print.c (print_object): Remove var that is set but not used.
8564
8565 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8566 The gnulib version avoids calling malloc in the usual case,
8567 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8568 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8569 * filelock.c (current_lock_owner): Likewise.
8570 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8571 * sysdep.c: Include allocator.h, careadlinkat.h.
8572 (emacs_no_realloc_allocator): New static constant.
8573 (emacs_readlink): New function.
8574 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8575 ../lib/careadlinkat.h.
8576
8577 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8578
8579 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8580 first non-nil return value).
8581
8582 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8583
8584 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8585 if not defined (Bug#8403).
8586
8587 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8588
8589 * xdisp.c (display_count_lines): Remove parameter `start',
8590 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8591 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8592 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8593 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8594 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8595 and thereabouts. All callers changed.
8596 (get_per_char_metric): Remove parameter `f', unused since
8597 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8598
8599 2011-04-02 Jim Meyering <meyering@redhat.com>
8600
8601 do not dereference NULL upon failed strdup
8602 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8603 (ns_get_family): Likewise.
8604
8605 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8606
8607 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8608
8609 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8610
8611 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8612 later (Bug#8403).
8613
8614 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8615
8616 Add lexical binding.
8617
8618 * window.c (Ftemp_output_buffer_show): New fun.
8619 (Fsave_window_excursion):
8620 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8621
8622 * lread.c (lisp_file_lexically_bound_p): New function.
8623 (Fload): Bind Qlexical_binding.
8624 (readevalloop): Remove `evalfun' arg.
8625 Bind Qinternal_interpreter_environment.
8626 (Feval_buffer): Bind Qlexical_binding.
8627 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8628 Mark as dynamic.
8629 (syms_of_lread): Declare `lexical-binding'.
8630
8631 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8632
8633 * keyboard.c (eval_dyn): New fun.
8634 (menu_item_eval_property): Use it.
8635
8636 * image.c (parse_image_spec): Use Ffunctionp.
8637
8638 * fns.c (concat, mapcar1): Accept byte-code-functions.
8639
8640 * eval.c (Fsetq): Handle lexical vars.
8641 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8642 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8643 (FletX, Flet): Obey lexical binding.
8644 (Fcommandp): Handle closures.
8645 (Feval): New `lexical' arg.
8646 (eval_sub): New function extracted from Feval. Use it almost
8647 everywhere where Feval was used. Look up vars in lexical env.
8648 Handle closures.
8649 (Ffunctionp): Move from subr.el.
8650 (Ffuncall): Handle closures.
8651 (apply_lambda): Remove `eval_flags'.
8652 (funcall_lambda): Handle closures and new byte-code-functions.
8653 (Fspecial_variable_p): New function.
8654 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8655 but without exporting it to Lisp.
8656
8657 * doc.c (Fdocumentation, store_function_docstring):
8658 * data.c (Finteractive_form): Handle closures.
8659
8660 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8661 interactive spec.
8662
8663 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8664 New byte-codes.
8665 (exec_byte_code): New function extracted from Fbyte_code to handle new
8666 calling convention for byte-code-functions. Add new byte-codes.
8667
8668 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8669
8670 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8671
8672 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8673
8674 * xdisp.c (redisplay_internal): Fix prototype.
8675
8676 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8677
8678 * xdisp.c (SCROLL_LIMIT): New macro.
8679 (try_scrolling): Use it when setting scroll_limit.
8680 Limit scrolling to 100 screen lines.
8681 (redisplay_window): Even when falling back on "recentering",
8682 position point in the window according to scroll-conservatively,
8683 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8684
8685 (try_scrolling): When point is above the window, allow searching
8686 as far as scroll_max, or one screenful, to compute vertical
8687 distance from PT to the scroll margin position. This prevents
8688 try_scrolling from unnecessarily failing when
8689 scroll-conservatively is set to a value slightly larger than the
8690 window height. Clean up the case of PT below the margin at bottom
8691 of window: scroll_max can no longer be INT_MAX. When aggressive
8692 scrolling is in use, don't let point enter the opposite scroll
8693 margin as result of the scroll.
8694 (syms_of_xdisp) <scroll-conservatively>: Document the
8695 threshold of 100 lines for never-recentering scrolling.
8696
8697 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8698
8699 * dispextern.h (move_it_by_lines):
8700 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8701 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8702 (message_log_check_duplicate): Remove parameters `prev_bol' and
8703 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8704 (redisplay_internal): Remove parameter `preserve_echo_area',
8705 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8706
8707 * indent.c (Fvertical_motion):
8708 * window.c (window_scroll_pixel_based, Frecenter):
8709 Don't pass `need_y_p' to `move_it_by_lines'.
8710
8711 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8712
8713 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8714 steal a few bits to be more compact.
8715 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8716 Remove unneeded casts.
8717
8718 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8719
8720 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8721
8722 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8723 binding" message (bug#7967).
8724
8725 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8726
8727 Fix more problems found by GCC 4.6.0's static checks.
8728
8729 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8730 Remove unused local var.
8731
8732 * editfns.c (Fmessage_box): Remove unused local var.
8733
8734 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8735 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8736 Omit unused local vars.
8737 * window.c (shrink_windows): Omit unused local var.
8738 * menu.c (digest_single_submenu): Omit unused local var.
8739 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8740 Omit unused local var.
8741
8742 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8743 Don't assume string length fits in int.
8744 (keyremap_step, read_key_sequence): Use size_t for sizes.
8745 (read_key_sequence): Don't check last_real_key_start redundantly.
8746
8747 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8748 instead of alloca (Bug#8344).
8749
8750 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8751 (Fbacktrace_frame): Don't assume nframes fits in int.
8752
8753 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8754
8755 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8756 concerns.
8757
8758 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8759
8760 * cm.c (calccost): Turn while-do into do-while, for clarity.
8761
8762 * keyboard.c (syms_of_keyboard): Use the same style as later
8763 in this function when indexing through an array. This also
8764 works around GCC bug 48267.
8765
8766 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8767
8768 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8769
8770 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8771 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8772
8773 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8774 This avoids undefined behavior on integer overflow, and is a bit
8775 more convenient anyway since it is compared to a size_t variable.
8776
8777 Variadic C functions now count arguments with size_t, not int.
8778 This avoids an unnecessary limitation on 64-bit machines, which
8779 caused (substring ...) to crash on large vectors (Bug#8344).
8780 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8781 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8782 All variadic functions and their callers changed accordingly.
8783 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8784 * data.c (arith_driver, float_arith_driver): Likewise.
8785 * editfns.c (general_insert_function): Likewise.
8786 * eval.c (struct backtrace.nargs, interactive_p)
8787 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8788 (funcall_lambda, mark_backtrace): Likewise.
8789 * fns.c (concat): Likewise.
8790 * frame.c (x_set_frame_parameters): Likewise.
8791 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8792 0 if not found, not -1. All callers changed.
8793
8794 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8795 (stack_copy_size): Now size_t, not int.
8796 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8797
8798 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8799
8800 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8801 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8802 All callers changed.
8803
8804 * lisp.h (multibyte_char_to_unibyte):
8805 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8806 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8807 * character.h (CHAR_TO_BYTE8):
8808 * cmds.c (internal_self_insert):
8809 * editfns.c (general_insert_function):
8810 * keymap.c (push_key_description):
8811 * search.c (Freplace_match):
8812 * xdisp.c (message_dolog, set_message_1): All callers changed.
8813
8814 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8815
8816 * keyboard.c (safe_run_hook_funcall): New function.
8817 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8818 don't set the hook to nil, but remove the offending function instead.
8819 (Qcommand_hook_internal): Remove, unused.
8820 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8821 Vcommand_hook_internal.
8822
8823 * eval.c (enum run_hooks_condition): Remove.
8824 (funcall_nil, funcall_not): New functions.
8825 (run_hook_with_args): Call each function through a `funcall' argument.
8826 Remove `cond' argument, now redundant.
8827 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8828 (Frun_hook_with_args_until_failure): Adjust accordingly.
8829 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8830
8831 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8832
8833 * dispextern.h (string_buffer_position): Remove declaration.
8834
8835 * print.c (strout): Remove parameter `multibyte', unused since
8836 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8837
8838 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8839 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8840 All callers changed.
8841
8842 * w32.c (_wsa_errlist): Use braces for struct initializers.
8843
8844 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8845 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8846 All callers changed.
8847 (string_buffer_position): Likewise. Also, make static (it's never
8848 used outside xdisp.c).
8849 (cursor_row_p): Remove parameter `w', unused since
8850 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8851 (decode_mode_spec): Remove parameter `precision', introduced during
8852 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8853 All callers changed.
8854
8855 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8856
8857 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8858
8859 2011-03-27 Anders Lindgren <andlind@gmail.com>
8860
8861 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8862 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8863 (ns_update_auto_hide_menu_bar): New functions.
8864 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8865 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8866 ns_constrain_all_frames.
8867 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8868 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8869
8870 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8871
8872 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8873
8874 2011-03-27 Glenn Morris <rgm@gnu.org>
8875
8876 * syssignal.h: Replace RETSIGTYPE with void.
8877 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8878 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8879 Replace SIGTYPE with void everywhere.
8880 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8881 * s/template.h (SIGTYPE): Remove commented out definition.
8882
8883 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8884
8885 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8886 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8887
8888 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8889
8890 * w32.c (read_unc_volume): Use parameter `henum', instead of
8891 global variable `wget_enum_handle'.
8892
8893 * keymap.c (describe_vector): Remove parameters `indices' and
8894 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8895 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8896
8897 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8898
8899 * keyboard.c (timer_check): Remove parameter `do_it_now',
8900 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8901 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8902 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8903
8904 * keyboard.c (read_char):
8905 * w32menu.c (w32_menu_display_help):
8906 * xmenu.c (show_help_event, menu_help_callback):
8907 Adjust calls to `show_help_echo'.
8908
8909 * gtkutil.c (xg_maybe_add_timer):
8910 * keyboard.c (readable_events):
8911 * process.c (wait_reading_process_output):
8912 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8913
8914 * insdel.c (adjust_markers_gap_motion):
8915 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8916 (gap_left, gap_right): Don't call it.
8917
8918 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8919
8920 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8921 incurred during fontification.
8922
8923 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8924
8925 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8926 (DEFVAR_PER_BUFFER): Don't pass it.
8927
8928 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8929 (scrolling_window): Don't pass it.
8930
8931 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8932
8933 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8934
8935 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8936 and `suffix'.
8937 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8938 of variables specific to SELinux and computation of `encoded_absname'.
8939
8940 * image.c (XPutPixel): Remove unused variable `height'.
8941
8942 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8943
8944 * unexw32.c (get_section_info): Remove unused variable `section'.
8945
8946 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8947 (system_process_attributes): Remove unused variable `sess'.
8948 (sys_read): Remove unused variable `err'.
8949
8950 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8951 (w32_wnd_proc): Remove unused variable `isdead'.
8952 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8953 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8954 (x_create_tip_frame): Remove unused variable `tem'.
8955
8956 * w32inevt.c (w32_console_read_socket):
8957 Remove unused variable `no_events'.
8958
8959 * w32term.c (x_draw_composite_glyph_string_foreground):
8960 Remove unused variable `width'.
8961
8962 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8963
8964 * w32term.c (x_set_glyph_string_clipping):
8965 Don't pass uninitialized region to CombineRgn.
8966
8967 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8968
8969 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8970 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8971 (Fx_close_connection): Remove unused variable `i'.
8972
8973 * w32font.c (w32font_draw): Return number of glyphs.
8974 (w32font_open_internal): Remove unused variable `i'.
8975 (w32font_driver): Add missing initializer.
8976
8977 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8978 (fill_in_menu): Remove unused variable `items_added'.
8979
8980 * w32term.c (last_mouse_press_frame): Remove static global variable.
8981 (w32_clip_to_row): Remove unused variable `f'.
8982 (x_delete_terminal): Remove unused variable `i'.
8983
8984 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8985 (NOTHING): Remove unused static global variable.
8986 (uniscribe_check_otf): Remove unused variable `table'.
8987 (uniscribe_font_driver): Add missing initializers.
8988
8989 2011-03-23 Julien Danjou <julien@danjou.info>
8990
8991 * term.c (Fsuspend_tty, Fresume_tty):
8992 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8993 * window.c (temp_output_buffer_show):
8994 * insdel.c (signal_before_change):
8995 * frame.c (Fhandle_switch_frame):
8996 * fileio.c (Fdo_auto_save):
8997 * emacs.c (Fkill_emacs):
8998 * editfns.c (save_excursion_restore):
8999 * cmds.c (internal_self_insert):
9000 * callint.c (Fcall_interactively):
9001 * buffer.c (Fkill_all_local_variables):
9002 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9003 Use Frun_hooks.
9004 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
9005 unconditionally since it does the check itself.
9006
9007 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
9008
9009 Fix more problems found by GCC 4.5.2's static checks.
9010
9011 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9012 the first time through the loop, since we know p0 < p1 then.
9013 This also avoids a gcc -Wstrict-overflow warning.
9014
9015 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9016 leading to a memory leak, possible in functions like
9017 load_charset_map_from_file that can allocate an unbounded number
9018 of objects (Bug#8318).
9019
9020 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9021 that could (at least in theory) be that large.
9022
9023 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9024 This is less likely to overflow, and avoids undefined behavior if
9025 overflow does occur. All callers changed. Use strtoul to scan
9026 for the unsigned long integer.
9027 (pint2hrstr): Simplify and tune code slightly.
9028 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
9029
9030 * scroll.c (do_scrolling): Work around GCC bug 48228.
9031 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9032
9033 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9034 This also avoids a warning with gcc -Wstrict-overflow.
9035 (validate_x_resource_name): Simplify count usage.
9036 This also avoids a warning with gcc -Wstrict-overflow.
9037
9038 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9039 fail (Bug#8306).
9040
9041 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
9042
9043 * process.c (Fmake_network_process): Use socklen_t, not int,
9044 where POSIX says socklen_t is required in portable programs.
9045 This fixes a porting bug on hosts like 64-bit HP-UX, where
9046 socklen_t is wider than int (Bug#8277).
9047 (Fmake_network_process, server_accept_connection):
9048 (wait_reading_process_output, read_process_output):
9049 Likewise.
9050
9051 * process.c: Rename or move locals to avoid shadowing.
9052 (list_processes_1, Fmake_network_process):
9053 (read_process_output_error_handler, exec_sentinel_error_handler):
9054 Rename or move locals.
9055 (Fmake_network_process): Define label "retry_connect" only if needed.
9056 (Fnetwork_interface_info): Fix pointer signedness.
9057 (process_send_signal): Add cast to avoid pointer signedness problem.
9058 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
9059 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
9060
9061 Make tparam.h and terminfo.c consistent.
9062 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9063 Include tparam.h instead, since it declares them.
9064 * cm.h (PC): Remove extern decl; tparam.h now does this.
9065 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9066 * terminfo.c: Include tparam.h, to check interfaces.
9067 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9068 (tparam): Adjust signature to match interface in tparam.h;
9069 this removes some undefined behavior. Check that outstring and len
9070 are zero, which they always are with Emacs.
9071 * tparam.h (PC, BC, UP): New extern decls.
9072
9073 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
9074 (xftfont_open): Rename locals to avoid shadowing.
9075
9076 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
9077 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9078 (OTF_TAG_SYM): Omit macro if not needed.
9079 (ftfont_list): Remove unused local.
9080 (get_adstyle_property, ftfont_pattern_entity):
9081 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9082 Rename locals to avoid shadowing.
9083
9084 * xfont.c (xfont_list_family): Mark var as initialized.
9085
9086 * xml.c (make_dom): Now static.
9087
9088 * composite.c (composition_compute_stop_pos): Rename local to
9089 avoid shadowing.
9090 (composition_reseat_it): Remove unused locals.
9091 (find_automatic_composition, composition_adjust_point): Likewise.
9092 (composition_update_it): Mark var as initialized.
9093 (find_automatic_composition): Mark vars as initialized,
9094 with a FIXME (Bug#8290).
9095
9096 character.h: Rename locals to avoid shadowing.
9097 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9098 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9099 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9100 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9101 to avoid shadowing.
9102
9103 * textprop.c (property_change_between_p): Remove; unused.
9104
9105 * intervals.c (interval_start_pos): Now static.
9106
9107 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9108
9109 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9110 Rename locals to avoid shadowing.
9111
9112 * sound.c (wav_play, au_play, Fplay_sound_internal):
9113 Fix pointer signedness.
9114 (alsa_choose_format): Remove unused local var.
9115 (wav_play): Initialize a variable to 0, to prevent undefined
9116 behavior (Bug#8278).
9117
9118 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9119
9120 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9121
9122 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9123 clobbering (Bug#8298).
9124 * sysdep.c (sys_subshell): Likewise.
9125 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
9126
9127 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9128 This should get cleaned up, so that child_setup has the
9129 same signature on all platforms.
9130
9131 * callproc.c (call_process_cleanup): Now static.
9132 (relocate_fd): Rename locals to avoid shadowing.
9133
9134 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
9135
9136 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9137 not to be necessary, and produces flickering.
9138
9139 2011-03-20 Glenn Morris <rgm@gnu.org>
9140
9141 * config.in: Remove file.
9142
9143 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
9144
9145 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9146 are now in src/globals.h.
9147 (syms_of_minibuf): Remove spurious & from previous change.
9148
9149 2011-03-20 Leo Liu <sdl.web@gmail.com>
9150
9151 * minibuf.c (completing-read-function): New variable.
9152 (completing-read-default): Rename from completing-read.
9153 (completing-read): Call completing-read-function.
9154
9155 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9156
9157 * xfaces.c (Fx_load_color_file):
9158 Read color file from absolute filename (bug#8250).
9159
9160 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9161
9162 * makefile.w32-in: Update dependencies.
9163
9164 2011-03-17 Eli Zaretskii <eliz@gnu.org>
9165
9166 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9167
9168 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9169
9170 Fix more problems found by GCC 4.5.2's static checks.
9171
9172 * process.c (make_serial_process_unwind, send_process_trap):
9173 (sigchld_handler): Now static.
9174
9175 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9176 That way, the code declares only the vars that it needs.
9177 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9178 * s/cygwin.h (PTY_ITERATION): Likewise.
9179 * s/darwin.h (PTY_ITERATION): Likewise.
9180 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9181
9182 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9183 * process.c (allocate_pty): Don't declare stb unless it's needed.
9184
9185 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9186 (CONSTANTLIM): Remove; unused.
9187 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9188 Define only if needed.
9189
9190 * unexelf.c (unexec): Name an expression,
9191 to avoid gcc -Wbad-function-cast warning.
9192 Use a different way to cause a compilation error if anyone uses
9193 n rather than nn, a way that does not involve shadowing.
9194 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9195
9196 * deps.mk (unexalpha.o): Remove; unused.
9197
9198 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9199 * unexec.h: New file.
9200 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9201 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9202 Depend on unexec.h.
9203 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9204 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9205 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9206 Change as necessary to match prototype in unexec.h.
9207
9208 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9209 shadowing.
9210 (back_comment, skip_chars): Mark vars as initialized.
9211
9212 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9213 Rename locals to avoid shadowing.
9214
9215 * lread.c (read1): Rewrite so as not to use empty "else".
9216 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9217
9218 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9219
9220 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9221 warning when compiling print.c.
9222
9223 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9224 instead of using an uninitialized var.
9225 (font_sort_entities): Mark var as initialized.
9226
9227 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9228
9229 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9230 pointers to constants.
9231 (font_parse_fcname): Remove unused vars.
9232 (font_delete_unmatched): Now static.
9233 (font_get_spec): Remove; unused.
9234 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9235 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9236 Rename or move locals to avoid shadowing.
9237
9238 * fns.c (require_nesting_list, require_unwind): Now static.
9239 (Ffillarray): Rename locals to avoid shadowing.
9240
9241 * floatfns.c (domain_error2): Define only if needed.
9242 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9243
9244 * alloc.c (mark_backtrace): Move decl from here ...
9245 * lisp.h: ... to here, so that it can be checked.
9246
9247 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9248 (Fdefvar): Rewrite so as not to use empty "else".
9249 (lisp_indirect_variable): Name an expression,
9250 to avoid gcc -Wbad-function-cast warning.
9251 (Fdefvar): Rename locals to avoid shadowing.
9252
9253 * callint.c (quotify_arg, quotify_args): Now static.
9254 (Fcall_interactively): Rename locals to avoid shadowing.
9255 Use const pointer when appropriate.
9256
9257 * lisp.h (get_system_name, get_operating_system_release):
9258 Move decls here, to check interfaces.
9259 * process.c (get_operating_system_release): Move decl to lisp.h.
9260 * xrdb.c (get_system_name): Likewise.
9261 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9262 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9263 some of which prompt warnings from gcc -Wbad-function-cast.
9264 (Fformat_time_string, Fencode_time, Finsert_char):
9265 (Ftranslate_region_internal, Fformat):
9266 Rename or remove local vars to avoid shadowing.
9267 (Ftranslate_region_internal): Mark var as initialized.
9268
9269 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9270 avoid shadowing.
9271
9272 * lisp.h (eassert): Check that the argument compiles, even if
9273 ENABLE_CHECKING is not defined.
9274
9275 * data.c (Findirect_variable): Name an expression, to avoid
9276 gcc -Wbad-function-cast warning.
9277 (default_value, arithcompare, arith_driver, arith_error): Now static.
9278 (store_symval_forwarding): Rename local to avoid shadowing.
9279 (Fmake_variable_buffer_local, Fmake_local_variable):
9280 Mark variables as initialized.
9281 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9282
9283 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9284 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9285 Rename locals to avoid shadowing.
9286 (mark_stack): Move local variables into the #ifdef region where
9287 they're used.
9288 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9289 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9290 needed otherwise.
9291 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9292 (GC_STRING_CHARS): Remove; not used.
9293 (Fmemory_limit): Cast sbrk's returned value to char *.
9294
9295 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9296 avoids undefined behavior in theory.
9297
9298 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9299
9300 Use functions, not macros, for up- and down-casing (Bug#8254).
9301 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9302 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9303 to use the following functions instead of these macros.
9304 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9305 EMACS_INT, since callers assume the returned value fits in int.
9306 (upcase1): Likewise, for UPCASE_TABLE.
9307 (uppercasep, lowercasep, upcase): New static inline functions.
9308 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9309 the race-condition problem in the old DOWNCASE.
9310
9311 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9312 Rename locals to avoid shadowing.
9313 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9314 (regex_compile, re_search_2, re_match_2_internal):
9315 Remove unused local vars.
9316 (FREE_VAR): Rewrite so as not to use empty "else",
9317 which gcc can warn about.
9318 (regex_compile, re_match_2_internal): Mark locals as initialized.
9319 (RETALLOC_IF): Define only if needed.
9320 (WORDCHAR_P): Likewise. This one is never needed, but is used
9321 only in a comment talking about a compiler bug, so put inside
9322 the #if 0 of that comment.
9323 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9324 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9325 Remove; unused.
9326
9327 * search.c (boyer_moore): Rename locals to avoid shadowing.
9328 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9329 (PREV_CHAR_BOUNDARY): Likewise.
9330
9331 * search.c (simple_search): Remove unused var.
9332
9333 * dired.c (compile_pattern): Move decl from here ...
9334 * lisp.h: ... to here, so that it can be checked.
9335 (struct re_registers): New forward decl.
9336
9337 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9338
9339 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9340 All uses changed.
9341 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9342 Rename locals to avoid shadowing.
9343 (Fvertical_motion): Mark locals as initialized.
9344
9345 * casefiddle.c (casify_object, casify_region): Now static.
9346 (casify_region): Mark local as initialized.
9347
9348 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9349
9350 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9351 New macros, so that the caller can use some names other than
9352 gcpro1, gcpro2, etc.
9353 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9354 of the new macros.
9355 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9356 argument, for consistency with GCPRO2_VAR, etc: it is now the
9357 prefix of the variable, not the variable itself. All uses
9358 changed.
9359 * dired.c (directory_files_internal, file_name_completion):
9360 Rename locals to avoid shadowing.
9361
9362 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9363 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9364 dired.c's scmp function, had undefined behavior.
9365 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9366 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9367 * buffer.h: ... to here, because these macros use current_buffer,
9368 and the new implementation with inline functions needs to have
9369 current_buffer in scope now, rather than later when the macros
9370 are used.
9371 (downcase, upcase1): New static inline functions.
9372 (DOWNCASE, UPCASE1): Reimplement using these functions.
9373 This avoids undefined behavior in expressions like
9374 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9375 from race conditions in accessing the global variables
9376 case_temp1 and case_temp2.
9377 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9378 * lisp.h (case_temp1, case_temp2): Remove their decls.
9379 * character.h (ASCII_CHAR_P): Move from here ...
9380 * lisp.h: ... to here, so that the inline functions mentioned
9381 above can use them.
9382
9383 * dired.c (directory_files_internal_unwind): Now static.
9384
9385 * fileio.c (file_name_as_directory, directory_file_name):
9386 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9387 Now static.
9388 (file_name_as_directory): Use const pointers when appropriate.
9389 (Fexpand_file_name): Likewise. In particular, newdir might
9390 point at constant storage, so make it a const pointer.
9391 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9392 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9393 signedness issues.
9394 (Fset_file_times, Finsert_file_contents, auto_save_error):
9395 Rename locals to avoid shadowing.
9396
9397 * minibuf.c (choose_minibuf_frame_1): Now static.
9398 (Ftry_completion, Fall_completions): Rename or remove locals
9399 to avoid shadowing.
9400
9401 * marker.c (bytepos_to_charpos): Remove; unused.
9402
9403 * lisp.h (verify_bytepos, count_markers): New decls,
9404 so that gcc does not warn that these functions aren't declared.
9405
9406 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9407 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9408 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9409 (copy_text): Remove unused local var.
9410
9411 * filelock.c (within_one_second): Now static.
9412 (lock_file_1): Rename local to avoid shadowing.
9413
9414 * buffer.c (fix_overlays_before): Mark locals as initialized.
9415 (fix_start_end_in_overlays): Likewise. This function should be
9416 simplified by using pointers-to-pointers, but that's a different
9417 matter.
9418 (switch_to_buffer_1): Now static.
9419 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9420 (report_overlay_modification): Rename locals to avoid shadowing.
9421
9422 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9423 Fix pointer signedness issue.
9424 (sys_subshell): Mark local as volatile if checking for lint,
9425 to suppress a gcc -Wclobbered warning that does not seem to be right.
9426 (MAXPATHLEN): Define only if needed.
9427
9428 * process.c (serial_open, serial_configure): Move decls from here ...
9429 * systty.h: ... to here, so that they can be checked.
9430
9431 * fns.c (get_random, seed_random): Move extern decls from here ...
9432 * lisp.h: ... to here, so that they can be checked.
9433
9434 * sysdep.c (reset_io): Now static.
9435 (wait_for_termination_signal): Remove; unused.
9436
9437 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9438 (copy_keymap_item, append_key, push_text_char_description):
9439 Now static.
9440 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9441 (DENSE_TABLE_SIZE): Remove; unused.
9442 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9443 (describe_map_tree):
9444 Rename locals to avoid shadowing.
9445
9446 * keyboard.c: Declare functions static if they are not used elsewhere.
9447 (echo_char, echo_dash, cmd_error, top_level_2):
9448 (poll_for_input, handle_async_input): Now static.
9449 (read_char, kbd_buffer_get_event, make_lispy_position):
9450 (make_lispy_event, make_lispy_movement, apply_modifiers):
9451 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9452 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9453 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9454 (read_key_sequence, read_char): Mark locals as initialized.
9455 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9456
9457 * keyboard.h (make_ctrl_char): New decl.
9458 (mark_kboards): Move decl here ...
9459 * alloc.c (mark_kboards): ... from here.
9460
9461 * lisp.h (force_auto_save_soon): New decl.
9462
9463 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9464 (DEFINE_DUMMY_FUNCTION): New macro.
9465 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9466 Use it.
9467 (main): Add casts to avoid warnings
9468 if GCC considers string literals to be constants.
9469
9470 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9471
9472 * dbusbind.c: Pointer signedness fixes.
9473 (xd_signature, xd_append_arg, xd_initialize):
9474 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9475 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9476 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9477 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9478
9479 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9480 if GCC considers string literals to be constants.
9481 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9482
9483 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9484
9485 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9486 (print_preprocess, print_object): New macro to fix last change.
9487
9488 * print.c (print_preprocess): Don't forget font objects.
9489
9490 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9491
9492 * emacs.c (USAGE3): Doc fixes.
9493
9494 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9495
9496 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9497 structure.
9498
9499 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9500
9501 * lisp.h (VWindow_system, Qfile_name_history):
9502 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9503 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9504 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9505
9506 * w32select.c: Don't #include "keyboard.h".
9507 (run_protected): Add extern declaration for waiting_for_input.
9508
9509 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9510 * w32console.c (detect_input_pending, read_input_pending)
9511 (encode_terminal_code):
9512 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9513 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9514 (w32_system_caret_y, Qfile_name_history):
9515 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9516 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9517 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9518 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9519 * w32proc.c (Qlocal, report_file_error):
9520 * w32term.c (Vwindow_system, updating_frame):
9521 * w32uniscribe.c (initialized, uniscribe_font_driver):
9522 Remove unneeded extern declarations.
9523
9524 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9525
9526 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9527
9528 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9529
9530 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9531 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9532 These macros can no longer be used for assignment.
9533
9534 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9535 Assign struct members directly, instead of using BUF_BEGV etc.
9536 (record_buffer_markers, fetch_buffer_markers): New functions for
9537 recording and fetching special buffer markers.
9538 (set_buffer_internal_1, set_buffer_temp): Use them.
9539
9540 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9541
9542 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9543
9544 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9545 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9546
9547 * xdisp.c (hscroll_window_tree):
9548 (reconsider_clip_changes): Use PT instead of BUF_PT.
9549
9550 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9551
9552 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9553 $(EMACS_ROOT)/lib/intprops.h.
9554
9555 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9556
9557 Fix more problems found by GCC 4.5.2's static checks.
9558
9559 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9560 to unsigned char * to avoid compiler diagnostic.
9561 (xg_free_frame_widgets): Make it clear that a local variable is
9562 needed only if USE_GTK_TOOLTIP.
9563 (gdk_window_get_screen): Make it clear that this macro is needed
9564 only if USE_GTK_TOOLTIP.
9565 (int_gtk_range_get_value): New function, which avoids a diagnostic
9566 from gcc -Wbad-function-cast.
9567 (xg_set_toolkit_scroll_bar_thumb): Use it.
9568 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9569 diagnostic from gcc -Wbad-function-cast.
9570 (get_utf8_string, xg_get_file_with_chooser):
9571 Rename locals to avoid shadowing.
9572 (create_dialog): Move locals to avoid shadowing.
9573
9574 * xgselect.c (xg_select): Remove unused var.
9575
9576 * image.c (four_corners_best): Mark locals as initialized.
9577 (gif_load): Initialize transparent_p to zero (Bug#8238).
9578 Mark another local as initialized.
9579 (my_png_error, my_error_exit): Mark with NO_RETURN.
9580
9581 * image.c (clear_image_cache): Now static.
9582 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9583 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9584 (x_edge_detection): Remove unnecessary cast that
9585 gcc -Wbad-function-cast diagnoses.
9586 (gif_load): Fix pointer signedness.
9587 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9588 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9589
9590 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9591
9592 Improve quality of tests for time stamp overflow.
9593 For example, without this patch (encode-time 0 0 0 1 1
9594 1152921504606846976) returns the obviously-bogus value (-948597
9595 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9596 reports time overflow. See
9597 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9598 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9599 * editfns.c: Include limits.h and intprops.h.
9600 (TIME_T_MIN, TIME_T_MAX): New macros.
9601 (time_overflow): Move earlier, to before first use.
9602 (hi_time, lo_time): New functions, for an accurate test for
9603 out-of-range times.
9604 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9605 (Fget_internal_run_time): Don't assume time_t fits in int.
9606 (make_time): Use list2 instead of Fcons twice.
9607 (Fdecode_time): More accurate test for out-of-range times.
9608 (check_tm_member): New function.
9609 (Fencode_time): Use it, to test for out-of-range times.
9610 (lisp_time_argument): Don't rely on undefined left-shift and
9611 right-shift behavior when checking for time stamp overflow.
9612
9613 * editfns.c (time_overflow): New function, refactoring common code.
9614 (Fformat_time_string, Fdecode_time, Fencode_time):
9615 (Fcurrent_time_string): Use it.
9616
9617 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9618 * dired.c (make_time): Move to ...
9619 * editfns.c (make_time): ... here.
9620 * systime.h: Note the move.
9621
9622 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9623
9624 * fringe.c (update_window_fringes): Remove unused variables.
9625
9626 * unexmacosx.c (copy_data_segment): Also copy __got section.
9627 (Bug#8223)
9628
9629 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9630
9631 * termcap.c [MSDOS]: Include "msdos.h".
9632 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9633 Constify `char *' arguments and their references according to
9634 prototypes in tparam.h.
9635
9636 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9637
9638 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9639 Adapt all references accordingly.
9640
9641 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9642
9643 2011-03-11 Tom Tromey <tromey@redhat.com>
9644
9645 * buffer.c (syms_of_buffer): Remove obsolete comment.
9646
9647 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9648
9649 * termhooks.h (encode_terminal_code): Declare prototype.
9650
9651 * msdos.c (encode_terminal_code): Don't declare prototype.
9652
9653 * term.c (encode_terminal_code): Now external again, used by
9654 w32console.c and msdos.c.
9655
9656 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9657 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9658
9659 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9660
9661 Fix some minor problems found by GCC 4.5.2's static checks.
9662
9663 * fringe.c (update_window_fringes): Mark locals as initialized
9664 (Bug#8227).
9665 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9666
9667 * alloc.c (mark_fringe_data): Move decl from here ...
9668 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9669 to check its interface.
9670 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9671
9672 * fontset.c (free_realized_fontset): Now static.
9673 (Fset_fontset_font): Rename local to avoid shadowing.
9674 (fontset_font): Mark local as initialized.
9675 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9676
9677 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9678
9679 * xselect.c (x_disown_buffer_selections): Remove; not used.
9680 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9681 (x_own_selection, Fx_disown_selection_internal): Rename locals
9682 to avoid shadowing.
9683 (x_handle_dnd_message): Remove local to avoid shadowing.
9684
9685 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9686 so that the caller can use some name other than gcpro1.
9687 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9688 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9689 (Fx_backspace_delete_keys_p):
9690 Use them to avoid shadowing, and rename vars to avoid shadowing.
9691 (x_decode_color, x_set_name, x_window): Now static.
9692 (Fx_create_frame): Add braces to silence GCC warning.
9693 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9694 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9695 Remove unused locals.
9696 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9697 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9698 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9699 macros.
9700
9701 * xterm.h (x_mouse_leave): New decl.
9702
9703 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9704 Remove unused functions.
9705 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9706 (x_calc_absolute_position): Now static.
9707 (XTread_socket): Don't define label "out" unless it's used.
9708 Don't declare local "event" unless it's used.
9709 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9710 unless they are used.
9711 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9712 (x_fatal_error_signal): Remove; not used.
9713 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9714 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9715 (x_error_catcher, x_connection_closed, x_error_handler):
9716 (x_error_quitter, xembed_send_message, x_iconify_frame):
9717 (my_log_handler): Rename locals to avoid shadowing.
9718 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9719 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9720
9721 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9722 Rename or move locals to avoid shadowing.
9723 (tty_defined_color, merge_face_heights): Now static.
9724 (free_realized_faces_for_fontset): Remove; not used.
9725 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9726 does not deduce is never used uninitialized.
9727 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9728 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9729
9730 * terminal.c (store_terminal_param): Now static.
9731
9732 * xmenu.c (menu_highlight_callback): Now static.
9733 (set_frame_menubar): Remove unused local.
9734 (xmenu_show): Rename parameter to avoid shadowing.
9735 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9736 since they might point to immutable storage.
9737 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9738 since it's unused otherwise.
9739
9740 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9741 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9742 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9743 avoids a gcc -Wuninitialized diagnostic.
9744 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9745 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9746 does not deduce are never used uninitialized.
9747
9748 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9749
9750 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9751 * window.c (window_loop, size_window):
9752 (run_window_configuration_change_hook, enlarge_window): Likewise.
9753
9754 * window.c (display_buffer): Now static.
9755 (size_window): Mark variables that gcc -Wuninitialized
9756 does not deduce are never used uninitialized.
9757 * window.h (check_all_windows): New decl, to forestall
9758 gcc -Wmissing-prototypes diagnostic.
9759 * dispextern.h (bidi_dump_cached_states): Likewise.
9760
9761 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9762 shadowing.
9763 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9764 Include <limits.h>.
9765 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9766 and to avoid gcc -Wuninitialized warning.
9767 (load_charset_map): Mark variables that gcc -Wuninitialized
9768 does not deduce are never used uninitialized.
9769 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9770
9771 * coding.c (coding_set_source, coding_set_destination):
9772 Use "else { /* comment */ }" rather than "else /* comment */;"
9773 for clarity, and to avoid gcc -Wempty-body warning.
9774 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9775 a block, when the outer 'i' will do.
9776 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9777 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9778 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9779 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9780 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9781 Rename locals to avoid shadowing.
9782 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9783 * coding.c (emacs_mule_char, encode_invocation_designation):
9784 Now static, since they're not used elsewhere.
9785 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9786 (decode_coding_object, encode_coding_object, detect_coding_system):
9787 (decode_coding_emacs_mule): Mark variables that gcc
9788 -Wuninitialized does not deduce are never used uninitialized.
9789 (detect_coding_iso_2022): Initialize a local variable that might
9790 be used uninitialized. Leave a FIXME because it's not clear that
9791 this initialization is needed. (Bug#8211)
9792 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9793 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9794 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9795 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9796 Remove unused macros.
9797
9798 * category.c (hash_get_category_set): Remove unused local var.
9799 (copy_category_table): Now static, since it's not used elsewhere.
9800 * character.c (string_count_byte8): Likewise.
9801
9802 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9803 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9804
9805 * chartab.c (copy_sub_char_table): Now static, since it's not used
9806 elsewhere.
9807 (sub_char_table_ref_and_range, char_table_ref_and_range):
9808 Rename locals to avoid shadowing.
9809 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9810
9811 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9812 (BIDI_BOB): Remove unused macro.
9813
9814 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9815 deduce are never used uninitialized.
9816 * term.c (encode_terminal_code): Likewise.
9817
9818 * term.c (encode_terminal_code): Now static. Remove unused local.
9819
9820 * tparam.h: New file.
9821 * term.c, tparam.h: Include it.
9822 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9823 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9824 Move these decls to tparam.h, and make them agree with what
9825 is actually in tparam.c. The previous trick of using incompatible
9826 decls in different modules does not conform to the C standard.
9827 All callers of tparam changed to use tparam's actual API.
9828 * tparam.c (tparam1, tparam, tgoto):
9829 Use const pointers where appropriate.
9830
9831 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9832 * cm.h (struct cm): Likewise.
9833 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9834 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9835 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9836 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9837 (turn_on_face, init_tty): Likewise.
9838 * termchar.h (struct tty_display_info): Likewise.
9839
9840 * term.c (term_mouse_position): Rename local to avoid shadowing.
9841
9842 * alloc.c (mark_ttys): Move decl from here ...
9843 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9844
9845 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9846
9847 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9848
9849 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9850
9851 * search.c (compile_pattern_1): Remove argument regp, unused since
9852 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9853 (compile_pattern): Don't pass it.
9854
9855 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9856
9857 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9858 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9859 for ! HAVE_GTK3.
9860 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9861
9862 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9863
9864 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9865 gdk_window_get_screen, gdk_window_get_geometry,
9866 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9867 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9868 (xg_get_pixbuf_from_pixmap): New function.
9869 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9870 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9871 Call xg_get_pixbuf_from_pixmap instead of
9872 gdk_pixbuf_get_from_drawable.
9873 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9874 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9875 (xg_check_special_colors): Use GtkStyleContext and its functions
9876 for HAVE_GTK3.
9877 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9878 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9879 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9880 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9881 Call gtk_widget_get_preferred_size.
9882 (xg_frame_resized): gdk_window_get_geometry only takes 5
9883 parameters.
9884 (xg_win_to_widget, xg_event_is_for_menubar):
9885 Call gdk_x11_window_lookup_for_display.
9886 (xg_set_widget_bg): New function.
9887 (delete_cb): New function.
9888 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9889 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9890 (xg_set_background_color): Call xg_set_widget_bg.
9891 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9892 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9893 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9894 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9895 if ! HAVE_GTK3.
9896 (update_frame_tool_bar): Call gtk_widget_hide.
9897 (xg_initialize): Use GDK_KEY_g.
9898
9899 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9900 if ! HAVE_GTK3
9901 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9902
9903 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9904 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9905 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9906
9907 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9908
9909 * w32xfns.c (select_palette): Check success of RealizePalette against
9910 GDI_ERROR, not zero.
9911
9912 See ChangeLog.11 for earlier changes.
9913
9914 ;; Local Variables:
9915 ;; coding: utf-8
9916 ;; End:
9917
9918 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9919
9920 This file is part of GNU Emacs.
9921
9922 GNU Emacs is free software: you can redistribute it and/or modify
9923 it under the terms of the GNU General Public License as published by
9924 the Free Software Foundation, either version 3 of the License, or
9925 (at your option) any later version.
9926
9927 GNU Emacs is distributed in the hope that it will be useful,
9928 but WITHOUT ANY WARRANTY; without even the implied warranty of
9929 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9930 GNU General Public License for more details.
9931
9932 You should have received a copy of the GNU General Public License
9933 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.