1 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
3 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
4 undefined. Convert from xassert to eassert.
5 * nsmenu.m: Convert from xassert to eassert.
8 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
10 * editfns.c (region_limit): Clip to narrowing (bug#11770).
12 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
14 Avoid integer overflow on scroll-left and scroll-right.
15 * window.c (HSCROLL_MAX): New macro.
16 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
17 overflow when requested scroll falls outside ptrdiff_t range.
19 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
21 * window.h (struct window): Change type of 'hscroll',
22 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
23 'last_modified' and 'last_overlay_modified' to EMACS_INT.
24 Adjust users accordingly.
25 * xdisp.c (try_cursor_movement): Replace type check with eassert.
26 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
27 from EMACS_INT to ptrdiff_t.
28 (make_window): Omit redundant initialization.
30 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
32 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
34 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
36 * window.h (struct window): Change type of 'use_time' and
37 'sequence_number' from Lisp_Object to int.
38 * frame.c (make_frame): Adjust users accordingly.
39 * print.c (print_object): Likewise.
40 * window.c (select_window, Fwindow_use_time, make_parent_window)
41 (make_window): Likewise.
43 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
45 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
46 enabled with --enable-checking=[all,glyphs] configure option.
47 Fix GLYPH_DEBUG usage assuming that it may be undefined,
48 adjust comments accordingly.
49 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
50 undefined, adjust comments accordingly.
54 * w32term.c: Likewise.
60 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
62 Generalize run-time debugging checks.
63 * dispextern.h (XASSERTS): Remove.
64 * fontset.c (xassert): Remove.
65 Convert from xassert to eassert.
66 * alloc.c: Convert from xassert to eassert.
68 * dispnew.c: Likewise.
72 * gtkutil.c: Likewise.
74 * keyboard.c: Likewise.
76 * process.c: Likewise.
80 * w32console.c: Likewise.
82 * w32term.c: Likewise.
87 * xselect.c: Likewise.
90 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
92 * fns.c (maybe_resize_hash_table): Output message when growing the
95 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
97 * alloc.c (allocate_string_data): Remove dead code.
98 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
99 avoid GCC warning about unused macro.
101 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
103 * alloc.c (allocate_string): Omit intervals initialization.
104 * alloc.c (make_uninit_multibyte_string): Initialize intervals
105 as in make_pure_string and make_pure_c_string.
107 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
109 * alloc.c (allocate_string): Fix last change.
111 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
113 * alloc.c (allocate_string): Remove two redundant calls
114 to memset, add explicit initialization where appropriate.
116 2012-06-27 Glenn Morris <rgm@gnu.org>
118 * lisp.mk (lisp): Remove paths.elc.
120 2012-06-27 Chong Yidong <cyd@gnu.org>
122 * doc.c (Fsubstitute_command_keys): Fix punctuation.
124 2012-06-26 John Wiegley <johnw@newartisans.com>
126 * unexmacosx.c (copy_data_segment): Add two section names used
127 on Mac OS X Lion: __mod_init_func and __mod_term_func.
129 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
130 when building with Clang.
132 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
134 * eval.c (Fapply): Allow calling it with a single argument.
136 2012-06-26 Eli Zaretskii <eliz@gnu.org>
138 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
139 _stricmp and _strnicmp.
140 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
142 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
144 * alloc.c (allocate_window): Zero out non-Lisp part of newly
146 (allocate_process): Likewise for new process.
147 (allocate_terminal): Change to use offsetof.
148 (allocate_frame): Likewise.
149 * frame.c (make_frame): Omit redundant initialization.
150 * window.c (make_parent_window): Use memset.
151 (make_window): Omit redundant initialization.
152 * process.c (make_process): Omit redundant initialization.
153 * terminal.c (create_terminal): Likewise.
155 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
157 * term.c (delete_tty): Remove redundant call to memset.
159 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
161 * alloc.c: Remove build_string.
162 * lisp.h: Define build_string as static inline. This provides
163 a better opportunity to optimize away calls to strlen when the
164 function is called with compile-time constant argument.
165 * image.c (imagemagick_error): Convert to build_string.
166 * w32proc.c (sys_spawnve): Likewise.
167 * xterm.c (x_term_init): Likewise.
169 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
171 Use sprintf return value instead of invoking strlen on result.
172 In the old days this wasn't portable, since some sprintf
173 implementations returned char *. But they died out years ago and
174 Emacs already assumes sprintf returns int.
175 Similarly for float_to_string.
176 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
177 * ccl.c (ccl_driver):
178 * character.c (string_escape_byte8):
179 * data.c (Fnumber_to_string):
181 * print.c (print_object):
182 * xdisp.c (message_dolog):
183 * xfns.c (syms_of_xfns):
184 Use sprintf or float_to_string result to avoid need to call strlen.
185 * data.c (Fnumber_to_string):
186 Use make_unibyte_string, since the string must be ASCII.
187 * lisp.h, print.c (float_to_string): Now returns int length.
188 * term.c (produce_glyphless_glyph):
189 Use sprintf result rather than recomputing it.
191 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
192 * Makefile.in (ALL_CFLAGS):
193 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
194 * gmalloc.c, regex.c: Include <config.h> unconditionally.
196 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
198 * dispextern.h (xstrcasecmp): Define to library function
199 strcasecmp if available.
200 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
202 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
204 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
205 Avoid comma operator.
206 * menu.c (push_submenu_start, push_submenu_end)
207 (push_left_right_boundary, push_menu_pane): Likewise.
208 * msdos.c (dos_rawgetc): Likewise.
210 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
212 * xfns.c (xic_create_fontsetname): Remove redundant calls
215 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
217 * gtkutil.c (get_utf8_string): Remove redundant assignment.
218 sprintf already null-terminates its output.
220 * xfns.c (x_window): Remove redundant cast.
222 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
224 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
225 `const char *' to `char *' to avoid compiler warning.
227 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
229 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
230 instead of truncating it to 63 (admittedly a generous limit).
232 * process.c: Fix spelling and caps in comments.
234 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
236 * emacs.c (setpgrp): Remove definition, unused.
237 * sysdep.c (setpgrp): Remove definition, not used in this file.
239 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
241 * makefile.w32-in: Update dependencies.
243 2012-06-24 Eli Zaretskii <eliz@gnu.org>
245 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
246 (SYSTIME_H): Add nt/inc/sys/time.h.
248 * systime.h [WINDOWSNT]: Include sys/time.h.
250 * s/ms-w32.h (struct timespec): Definition moved from
251 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
253 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
255 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
256 * buffer.h (buffer_slot_type_mismatch):
257 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
258 * eval.c (unwind_to_catch):
259 * image.c (my_png_error, my_error_exit):
260 * keyboard.c (quit_throw_to_read_char, user_error)
261 (Fexit_recursive_edit, Fabort_recursive_edit):
262 * lisp.h (die, args_out_of_range, args_out_of_range_3)
263 (wrong_type_argument, buffer_overflow, __executable_start)
264 (memory_full, buffer_memory_full, string_overflow, Fthrow)
265 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
266 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
268 (child_setup) [!DOS_NT]:
269 * lread.c (end_of_file_error, invalid_syntax):
270 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
271 * puresize.h (pure_write_error):
272 * search.c (matcher_overflow):
273 * sound.c (sound_perror, alsa_sound_perror):
274 * sysdep.c, syssignal.h (croak):
275 * term.c (maybe_fatal, vfatal):
276 * textprop.c (text_read_only):
277 * undo.c (user_error):
278 * unexmacosx.c (unexec_error):
279 * xterm.c (x_ins_del_lines, x_delete_glyphs):
280 Use _Noreturn rather than NO_RETURN.
281 No need for separate decl merely because of _Noreturn.
282 * sound.c (sound_warning, parse_sound):
283 Remove unnecessary forward decls.
285 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
287 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
288 * lisp.h (WAIT_READING_MAX): New macro.
289 * dispnew.c (Fsleep_for, sit_for):
290 * keyboard.c (kbd_buffer_get_event):
291 * process.c (Faccept_process_output):
292 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
293 This improves on the previous patch, which introduced a bug
294 when time_t is unsigned and as wide as intmax_t.
295 See <http://bugs.gnu.org/9000#51>.
297 2012-06-23 Eli Zaretskii <eliz@gnu.org>
299 * dispnew.c (sit_for, Fsleep_for):
300 * keyboard.c (kbd_buffer_get_event):
301 * process.c (Faccept_process_output): Avoid compiler warnings when
302 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
304 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
306 * makefile.w32-in: Update dependencies.
308 * w32.c (ltime): Add return type and declare static.
309 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
311 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
313 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
314 Privately reported by Herbert J. Skuhra.
315 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
317 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
318 not make_lisp_timeval, when the argument is of type EMACS_TIME.
320 2012-06-23 Eli Zaretskii <eliz@gnu.org>
322 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
323 last argument of make_unibyte_string.
325 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
326 language ID in the event parameters.
328 * w32term.c (w32_read_socket): Put the new keyboard codepage into
329 event.code, not the obscure "character set ID".
331 2012-06-23 Chong Yidong <cyd@gnu.org>
333 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
335 2012-06-23 Eli Zaretskii <eliz@gnu.org>
337 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
338 * w32.c (fdutimens): New function.
340 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
342 * s/ms-w32.h (pselect): Redirect to sys_select.
344 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
346 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
347 in the logic of incrementing and decrementing the value of
348 use_relocatable_buffers.
350 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
352 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
353 Privately reported by Herbert J. Skuhra.
354 [__FreeBSD__]: Remove "*/" typo after "#include".
355 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
356 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
357 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
358 Don't assume EMACS_TIME and struct timeval are the same type.
360 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
362 Support higher-resolution time stamps (Bug#9000).
363 The time stamps are only nanosecond-resolution at the C level,
364 since that's the best that any real-world system supports now.
365 But they are picosecond-resolution at the Lisp level, as that's
366 easy, and leaves room for future OS improvements.
368 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
371 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
372 Don't get current time unless it's needed.
374 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
375 now provides it if it's absent.
376 (start_atimer): Port to higher-res time stamps.
377 Check for time stamp overflow. Don't get current time more
378 often than is needed.
380 * buffer.h (struct buffer): Buffer modtime now has high resolution.
381 Include systime.h, not time.h.
382 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
384 * dired.c: Include stat-time.h.
385 (Ffile-attributes): File times now have higher resolution.
387 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
388 (struct image): Timestamp now has higher resolution.
390 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
391 has at least microseconds now. All uses removed.
392 (update_frame, update_single_window, update_window, update_frame_1)
393 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
395 * editfns.c (time_overflow): Now extern.
396 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
397 (float-time, Fformat_time_string, Fcurrent_time_string)
398 (Fcurrent_time_zone): Accept and generate higher-resolution
400 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
401 (decode_time_components, lisp_seconds_argument): New functions.
402 (make_time): Now static.
403 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
404 Report an error if the time is invalid, rather than having the caller
407 * fileio.c: Include <stat-time.h>
408 (Fcopy_file): Copy higher-resolution time stamps.
409 Prefer to set the time stamp via a file descriptor if that works.
410 (Fset_file_times, Finsert_file_contents, Fwrite_region)
411 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
412 (Fvisited_file_modtime, Fset_visited_file_modtime):
413 Support higher-resolution time stamps.
415 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
417 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
419 * image.c (prepare_image_for_display, clear_image_cache)
420 (lookup_image): Port to higer-resolution time stamps.
422 * keyboard.c (start_polling, bind_polling_period):
423 Check for time stamp overflow.
424 (read_char, kbd_buffer_get_event, timer_start_idle)
425 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
426 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
427 Port to higher-resolution time stamps. Do not assume time_t is signed.
428 (decode_timer): New function. Timers are now vectors of length 9,
429 not 8, to accommodate the picosecond component.
430 (timer_check_2): Use it.
432 * nsterm.m (select_timeout, timeval_subtract): Remove.
433 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
434 as they're a bit more accurate and handle overflow better.
435 (ns_select): Change prototype to be compatible with pselect.
436 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
437 * nsterm.h (ns_select): Adjust prototype.
439 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
440 us-resolution time stamps.
441 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
443 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
445 * lisp.h (time_overflow): New decl.
446 (wait_reading_process_output): First arg is now intmax_t, not int,
447 to accommodate larger waits.
449 * process.h (struct Lisp_Process.read_output_delay):
450 Now counts nanoseconds, not microseconds.
451 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
453 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
454 (wait_reading_process_output):
455 Port to ns-resolution time stamps.
456 (Faccept_process_output, wait_reading_process_output):
457 Check for time stamp overflow. Do not assume time_t is signed.
458 (select_wrapper): Remove; we now use pselect.
459 (Fprocess_attributes): Now generates ns-resolution time stamps.
461 * sysdep.c: Include utimens.h. Don't include utime.h
462 or worry about struct utimbuf; gnulib does that for us now.
463 (gettimeofday): Remove; gnulib provides a substitute.
464 (make_timeval): New function.
465 (set_file_times): Now sets ns-resolution time stamps.
466 New arg FD; all uses changed.
467 (time_from_jiffies, ltime_from_jiffies, get_up_time)
468 (system_process_attributes):
469 Now returns ns-resolution time stamp. All uses changed.
470 Check for time stamp overflow.
472 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
473 provides a substitute now.
475 * systime.h: Include timespec.h rather than sys/time.h and time.h,
476 since it guarantees struct timespec.
477 (EMACS_TIME): Now struct timespec, so that we can support
478 ns-resolution time stamps.
479 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
480 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
481 (EMACS_USECS): Remove.
482 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
483 so multiply the arg by 1000 before storing it.
484 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
486 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
487 Port to ns-resolution time stamps.
488 (EMACS_TIME_NEG_P): Remove; replaced by....
489 (EMACS_TIME_SIGN): New macro.
490 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
491 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
492 (set_file_times, make_time, lisp_time_argument): Adjust signature.
493 (make_timeval, make_lisp_time, decode_time_components): New decls.
494 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
495 that it mishandled time_t overflow. You can't compare by subtracting!
496 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
497 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
499 * term.c: Include <sys/time.h>.
500 (timeval_to_Time): New function, for proper overflow wraparound.
501 (term_mouse_position, term_mouse_click): Use it.
503 * undo.c (record_first_change): Support higher-resolution time stamps
505 (Fprimitive_undo): Use them when restoring time stamps.
507 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
508 (w32_get_internal_run_time):
509 Port to higher-resolution Emacs time stamps.
510 (ltime): Now accepts single 64-bit integer, as that's more convenient
513 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
515 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
516 for compatibility with pselect. Support ns-resolution time stamps.
518 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
520 * xselect.c (wait_for_property_change, x_get_foreign_selection):
521 Check for time stamp overflow, and support ns-resolution time stamps.
523 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
524 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
525 (timeval_subtract): Remove; no longer needed.
526 (XTflash, XTring_bell, x_wait_for_event):
527 Port to ns-resolution time stamps. Don't assume time_t is signed.
529 2012-06-22 Chong Yidong <cyd@gnu.org>
531 * xdisp.c (x_consider_frame_title): Revert last change.
533 2012-06-22 Eli Zaretskii <eliz@gnu.org>
535 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
536 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
537 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
538 staticidx goes up to 1597 out of 1600 = 0x640.)
540 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
542 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
543 Otherwise, the umask might be mistakenly 0 while handling input signals.
545 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
547 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
549 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
551 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
552 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
553 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
554 access to `contents' member of Lisp_Vector objects with AREF and ASET
557 2012-06-19 Chong Yidong <cyd@gnu.org>
559 * frame.c (delete_frame): When selecting a frame on a different
560 text terminal, do not alter the terminal's top-frame.
562 * xdisp.c (format_mode_line_unwind_data): Record the target
563 frame's selected window and its terminal's top-frame.
564 (unwind_format_mode_line): Restore them.
565 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
567 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
568 since tty frames can be explicitly named.
569 (prepare_menu_bars): Likewise.
571 * term.c (Ftty_top_frame): New function.
573 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
575 Port byte-code-meter to modern targets.
576 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
577 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
578 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
579 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
580 (METER_1, METER_2): Simplify.
582 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
584 * data.c (Fdefalias): Return `symbol' (bug#11686).
586 2012-06-18 Martin Rudalics <rudalics@gmx.at>
588 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
589 gets killed during executing of this function (Bug#11665).
590 Try to always return Qt when the buffer has been actually killed.
591 (Vkill_buffer_query_functions): In doc-string say that functions
592 run by this hook should not change the current buffer.
594 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
596 Fix recently-introduced process.c problems found by static checking.
597 * process.c (write_queue_push, write_queue_pop, send_process):
598 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
599 (write_queue_pop): Fix pointer signedness problem.
600 (send_process): Remove unused local.
602 2012-06-17 Chong Yidong <cyd@gnu.org>
604 * xdisp.c (redisplay_internal): No need to redisplay terminal
605 frames that are not on top.
607 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
609 * process.c (make_process): Initialize write_queue.
610 (write_queue_push, write_queue_pop): New functions.
611 (send_process): Use them to maintain correct ordering of process
614 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
616 * lisp.h (eassert): Assume C89 or later.
617 This removes the need for CHECK.
618 (CHECK): Remove. Its comments about always evaluating its
619 argument were confusing, as 'eassert' typically does not evaluate
622 * coding.c (produce_chars): Use ptrdiff_t, not int.
624 * xterm.c (x_draw_underwave): Check for integer overflow.
625 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
627 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
629 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
630 referenced (Bug#11583).
632 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
634 Implement wave-style variant of underlining.
635 * dispextern.h (face_underline_type): New enum.
636 (face): Add field for underline type.
637 * nsterm.m (ns_draw_underwave): New function.
638 (ns_draw_text_decoration): Use it.
639 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
641 (x_draw_glyph_string): Use them.
642 * xfaces.c (Qline, Qwave): New Lisp objects.
643 (check_lface_attrs, merge_face_ref)
644 (Finternal_set_lisp_face_attribute, realize_x_face):
645 Handle wave-style underline face attributes.
646 * xterm.c (x_draw_underwave): New function.
647 (x_draw_glyph_string): Use it.
649 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
651 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
652 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
653 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
654 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
655 ($(BLD)/w32select.$(O)): Update dependencies.
657 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
659 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
660 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
661 * character.c (_fetch_multibyte_char_p): Remove.
662 * alloc.c: Include "character.h" before "buffer.h".
664 * buffer.c: Likewise.
665 * bytecode.c: Likewise.
666 * callint.c: Likewise.
667 * callproc.c: Likewise.
668 * casefiddle.c: Likewise.
669 * casetab.c: Likewise.
670 * category.c: Likewise.
672 * coding.c: Likewise.
673 * composite.c: Likewise.
675 * dispnew.c: Likewise.
677 * dosfns.c: Likewise.
678 * editfns.c: Likewise.
680 * fileio.c: Likewise.
681 * filelock.c: Likewise.
683 * fontset.c: Likewise.
684 * fringe.c: Likewise.
685 * indent.c: Likewise.
686 * insdel.c: Likewise.
687 * intervals.c: Likewise.
688 * keyboard.c: Likewise.
689 * keymap.c: Likewise.
691 * macros.c: Likewise.
692 * marker.c: Likewise.
693 * minibuf.c: Likewise.
695 * nsmenu.m: Likewise.
697 * process.c: Likewise.
699 * region-cache.c: Likewise.
700 * search.c: Likewise.
701 * syntax.c: Likewise.
703 * textprop.c: Likewise.
705 * unexsol.c: Likewise.
706 * w16select.c: Likewise.
707 * w32fns.c: Likewise.
708 * w32menu.c: Likewise.
709 * window.c: Likewise.
714 * xselect.c: Likewise.
716 2012-06-16 Eli Zaretskii <eliz@gnu.org>
718 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
719 If all the glyphs of the glyph row came from strings, and we have no
720 cursor positioning clues, put the cursor on the first glyph of the
722 (handle_face_prop): Use chunk-relative overlay string index when
723 indexing into it->string_overlays array. (Bug#11653)
724 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
725 the rightmost. (Bug#11720)
727 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
729 * category.h (CHAR_HAS_CATEGORY): Define as inline.
730 (CATEGORY_MEMBER): Enforce 1/0 value.
731 * category.c (_temp_category_set): Remove.
733 2012-06-16 Eli Zaretskii <eliz@gnu.org>
735 * window.c (Fdelete_other_windows_internal)
736 (Fdelete_window_internal): Don't access frame's mouse highlight
737 info of the initial frame. (Bug#11677)
739 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
741 * .gdbinit (xgetint): Fix recently-introduced paren typo.
742 Assume USE_2_TAGS_FOR_INTS.
743 (xreload): Adjust $tagmask width to match recent lisp.h change.
745 Simplify lisp.h in minor ways that should not affect code.
746 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
747 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
748 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
749 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
750 (INTTYPEBITS): New macro, for clarity.
751 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
752 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
753 Simplify now that USE_LSB_TAG is always defined.
754 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
755 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
757 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
759 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
761 2012-06-13 Glenn Morris <rgm@gnu.org>
763 * s/bsd-common.h (BSD4_3):
764 * s/usg5-4-common.h (USG5_4): No longer define; unused.
766 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
768 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
771 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
773 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
774 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
775 * alloc.c (widen_to_Lisp_Object): Remove.
776 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
777 * frame.c (delete_frame): Remove outdated comment.
778 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
780 (Fw32_unregister_hot_key): Likewise.
781 (Fw32_toggle_lock_key): Likewise.
782 * w32menu.c (add_menu_item): Likewise.
783 (w32_menu_display_help): Use XIL instead of checking
785 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
786 (init_heap): Likewise.
787 * w32term.c (w32_read_socket): Update comment.
789 2012-06-13 Glenn Morris <rgm@gnu.org>
791 * s/usg5-4-common.h, src/s/unixware.h:
792 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
794 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
796 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
798 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
799 * alloc.c (make_number) [!defined make_number]:
800 Remove, as lisp.h always defines this now.
801 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
802 (roundup_size): Verify that it is a power of 2.
803 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
804 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
805 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
806 -DUSE_LSB_TAG=0, to override the automatically-selected default.
807 USE_LSB_TAG now is always defined to be either 0 or 1.
809 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
810 code works fine either way, and efficiency is not a concern here,
811 as the union type is for debugging, not for production.
812 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
813 Use an inline function on all platforms when using the union type,
814 since this is simpler and 'static inline' can be used portably
816 (LISP_INITIALLY_ZERO): New macro.
817 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
818 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
820 2012-06-12 Glenn Morris <rgm@gnu.org>
822 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
824 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
826 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
827 Move BROKEN_SIGIO to configure.
829 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
830 Move NO_TERMIO to configure.
832 2012-06-12 Chong Yidong <cyd@gnu.org>
834 * image.c (imagemagick_load_image): Use MagickFlattenImage if
835 MagickMergeImageLayers is undefined. Use pixel pusher loop if
836 MagickExportImagePixels is undefined.
838 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
840 * image.c (imagemagick_load_image): Remove unused label.
842 2012-06-11 Glenn Morris <rgm@gnu.org>
844 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
845 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
846 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
847 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
849 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
851 * alloc.c (make_byte_code): New function.
852 (Fmake_byte_code): Use it. Don't purify here.
853 * lread.c (read1): Use it as well to avoid extra allocation.
855 2012-06-11 Chong Yidong <cyd@gnu.org>
857 * image.c (imagemagick_load_image): Implement transparency.
859 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
861 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
862 account for preceding backslashes. (Bug#11663)
864 2012-06-09 Chong Yidong <cyd@gnu.org>
866 * term.c: Support italics in capable terminals (Bug#9652).
867 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
868 (turn_on_face): Output using TS_enter_italic_mode if available.
869 Don't handle unused blinking and alt-charset cases.
870 (turn_off_face): Handle italic case; discard unused tty_blinking_p
871 and tty_alt_charset_p cases.
872 (tty_capable_p, init_tty): Support italics.
874 * termchar.h (struct tty_display_info): Add field for italics.
875 Remove unused blink field.
877 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
880 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
881 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
882 tty_alt_charset_p. Add tty_italic_p.
884 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
886 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
887 dbus_type_is_basic if available.
888 (xd_extract_signed, xd_extract_unsigned): Rename from
889 extract_signed and extract_unsigned, respectively. Adapt callers.
891 2012-06-09 Chong Yidong <cyd@gnu.org>
893 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
895 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
898 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
900 * xdisp.c (vmessage): Treat frame message as multibyte.
901 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
902 would generate the diagnostic "Making \302\247 buffer-local while
905 2012-06-08 Eli Zaretskii <eliz@gnu.org>
907 * dispnew.c (showing_window_margins_p): Undo last change, which
908 was done due to an inadvertent commit.
909 (adjust_frame_glyphs_for_frame_redisplay): Do call
910 showing_window_margins_p.
912 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
914 * eval.c (Fmake_var_non_special): New primitive.
915 (syms_of_eval): Defsubr it.
916 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
918 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
920 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
921 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
923 2012-06-08 Eli Zaretskii <eliz@gnu.org>
925 * alloc.c (allocate_vectorlike): Fix last change.
927 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
929 Block-based vector allocation of small vectors.
930 * lisp.h (struct vectorlike_header): New field `nbytes',
931 adjust comment accordingly.
932 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
933 to denote vector blocks. Adjust users (live_vector_p,
934 mark_maybe_pointer, valid_lisp_object_p) accordingly.
935 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
936 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
937 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
938 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
939 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
940 (roundup_size): New constant.
941 (struct vector_block): New data type.
942 (vector_blocks, vector_free_lists, zero_vector): New variables.
943 (all_vectors): Rename to `large_vectors'.
944 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
945 (sweep_vectors): New functions.
946 (allocate_vectorlike): Return `zero_vector' as the only vector of
947 0 items. Allocate new vector from block if vector size is less than
948 or equal to VBLOCK_BYTES_MAX.
949 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
950 (init_alloc_once): Add call to init_vectors.
952 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
954 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
956 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
958 * doprnt.c (doprnt): Truncate multibyte char correctly.
959 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
960 would mishandle a string argument "Xc" if X was a multibyte
961 character of length 2: it would truncate after X's first byte
962 rather than including all of X.
964 2012-06-06 Chong Yidong <cyd@gnu.org>
966 * buffer.c (word_wrap): Doc fix.
968 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
970 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
972 2012-06-03 Glenn Morris <rgm@gnu.org>
974 * xdisp.c (tool-bar-style): Doc fix.
976 2012-06-03 Ulrich Müller <ulm@gentoo.org>
978 * Makefile.in (PAXCTL): Define.
979 (temacs$(EXEEXT)): Disable memory randomization for the temacs
980 binary via PaX flags if the paxctl utility is available.
981 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
982 Restore PaX flags to their default. (Bug#11398)
984 2012-06-03 Chong Yidong <cyd@gnu.org>
986 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
989 2012-06-03 Chong Yidong <cyd@gnu.org>
991 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
992 (note_mode_line_or_margin_highlight): If there is no help echo,
993 use mode-line-default-help-echo. Handle the case where the mouse
994 position is past the end of the mode line string.
996 * buffer.c (buffer_local_value_1): New function, split from
997 Fbuffer_local_value; can return Qunbound.
998 (Fbuffer_local_value): Use it.
999 (Vmode_line_format): Docstring tweaks.
1001 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1003 * sysdep.c (system_process_attributes): Improve comment.
1005 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1007 * keyboard.c: Export real-this-command to Elisp.
1008 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1009 and DEFVAR it. Update all users.
1011 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1013 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1015 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1016 Convert pctcpu and pctmem to Lisp float properly.
1017 Let the compiler fold better, as 100.0/0x8000 is exact.
1019 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1021 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1024 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1026 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1028 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1030 For a 'struct window', replace some Lisp_Object fields to
1031 bitfields where appropriate, remove unused fields.
1032 * window.h (struct window): Remove unused 'last_mark_x' and
1033 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1034 change it's type from Lisp_Object to bitfield.
1035 Change type of 'force_start', 'optional_new_start',
1036 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1037 fields from Lisp_Object to bitfield. Adjust users accordingly.
1039 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1041 Pacify gcc -Wdouble-precision when using Xaw.
1042 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1043 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1044 Use 'float' consistently, rather than 'float' in most places
1045 and 'double' in a couple of places.
1047 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1049 * xdisp.c (handle_stop): Detect whether we have overlay strings
1050 loaded by testing it->current.overlay_string_index to be
1051 non-negative, instead of checking whether n_overlay_strings is
1052 positive. (Bug#11587)
1054 2012-05-31 Chong Yidong <cyd@gnu.org>
1056 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1058 * doc.c (Fsubstitute_command_keys): Doc fix.
1060 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1062 * search.c (search_buffer): Remove calls to
1063 r_alloc_inhibit_buffer_relocation, as it is now called by
1064 maybe_unify_char, which was the cause of relocation of buffer text
1067 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1069 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1070 for the duration of call to load_charset, to avoid problems with
1071 callers of maybe_unify_char that access buffer text through C
1074 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1075 decrement the inhibition flag, instead of just setting or
1078 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1080 Remove obsolete '#define static' cruft.
1081 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1082 This #undef was "temporary" in 2000; it is no longer needed
1083 now that '#define static' has gone away.
1084 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1085 (gray_bitmap_bits): Remove; no longer needed.
1086 All uses replaced with definiens.
1087 * xterm.c: Include "bitmaps/gray.xbm".
1089 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1091 Clean up __executable_start, monstartup when --enable-profiling.
1092 The following changes affect the code only when profiling.
1093 * dispnew.c (__executable_start): Rename from safe_bcopy.
1094 Define only on platforms that need it.
1095 * emacs.c: Include <sys/gmon.h> when profiling.
1096 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1097 (__executable_start): Remove decl, since lisp.h does it now.
1098 (safe_bcopy): Remove decl; no longer has that name.
1099 (main): Coalesce #if into single bit of code, for simplicity.
1100 Cast pointers to uintptr_t, since standard libraries want integers
1102 * lisp.h (__executable_start): New decl.
1104 2012-05-31 Glenn Morris <rgm@gnu.org>
1106 * image.c (Fimagemagick_types): Doc fix.
1108 2012-05-30 Jim Meyering <meyering@redhat.com>
1110 * callproc.c (Fcall_process_region): Include directory component
1111 in mkstemp error message (Bug#11586).
1113 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1115 * alloc.c, lisp.h (make_pure_vector): Now static.
1117 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1119 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1120 Move to byte-run.el.
1121 (Fautoload): Do the hash-doc more carefully.
1122 * data.c (Fdefalias): Purify definition, except for keymaps.
1123 (Qdefun): Move from eval.c.
1124 * lisp.h (Qdefun): Remove.
1125 * lread.c (read1): Tiny simplification.
1127 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
1129 Do not create empty overlays with the evaporate property (Bug#9642).
1130 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1131 Bug#9642, but explicitly check that the buffer the overlay would
1132 be moved to is live and rearrange lines to make sure that errors
1133 will not put the overlay in an inconsistent state.
1134 (Fdelete_overlay): Cosmetics.
1136 2012-05-28 Eli Zaretskii <eliz@gnu.org>
1138 * w32term.c (my_bring_window_to_top): New function.
1139 (x_raise_frame): Use handle returned by DeferWindowPos, which
1140 could be different from the original one.
1141 Call my_bring_window_to_top instead of my_set_foreground_window.
1144 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1145 by calling BringWindowToTop.
1147 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1148 (WM_EMACS_END): Increase by one.
1150 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1152 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1153 This avoids undefined behavior that might cause the eassert
1154 to not catch an out-of-range value.
1156 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
1158 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1159 Update dependencies.
1161 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1163 * bidi.c (bidi_mirror_char): Fix last change.
1165 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1167 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1168 when referring to sectname field in printf format.
1170 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1172 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1173 Only r_alloc_inhibit_buffer_relocation needed to be added;
1174 the others were already declared.
1176 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1177 before checking whether it's out of range. Put the check inside
1179 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1181 2012-05-27 Ken Brown <kbrown@cornell.edu>
1183 * callproc.c (Fcall_process): Restore a line that was accidentally
1184 commented out in the 2011-02-13 change (bug#11547).
1186 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1188 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1189 defined on ralloc.c.
1191 * buffer.c [REL_ALLOC]: Remove prototypes of
1192 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1193 they are now on lisp.h.
1195 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1197 * search.c (search_buffer): Use it to inhibit relocation of buffer
1198 text while re_search_2 is doing its job, because re_search_2 is
1199 passed C pointers to buffer text. (Bug#11519)
1201 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1204 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1205 state after an additional call to move_it_in_display_line_to, keep
1206 the values of it->max_ascent and it->max_descent found for the
1208 (pos_visible_p): Revert the comparison against bottom_y to what it
1209 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1212 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1214 Fix coding-related core dumps with gcc -ftrapv.
1215 The code was computing A - B, where A and B are pointers, and B is
1216 random garbage. This can lead to core dumps on platforms that
1217 have special pointer registers, and it also leads to core dumps on
1218 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1219 A - B only when B is initialized properly.
1220 * coding.c (coding_set_source, coding_set_destination): Return void.
1221 (coding_change_source, coding_change_destinations): New functions,
1222 with the old behaviors of coding_set_source and coding_set_destination.
1223 All callers that need an offset changed to use these new functions.
1225 2012-05-26 Glenn Morris <rgm@gnu.org>
1227 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1229 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1231 Extend mouse support on W32 text-mode console.
1232 * xdisp.c (draw_row_with_mouse_face):
1233 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
1235 * w32console.c: Include window.h.
1236 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1238 (initialize_w32_display): Initialize mouse-highlight data.
1240 * w32inevt.c: Include termchar.h and window.h.
1241 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1242 moves, call note_mouse_highlight. If help_echo changed, call
1243 gen_help_event to produce help-echo message in the echo area.
1244 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1247 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1249 * lread.c (read1): Simplify slightly to avoid an overflow warning
1250 with GCC 4.7.0 on x86-64.
1252 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1254 * bidi.c (bidi_mirror_char): Revert last change: an int is
1255 definitely wide enough here.
1257 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
1259 Fix integer width and related bugs (Bug#9874).
1260 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
1261 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1262 (string_bytes, check_sblock, allocate_string_data):
1263 (compact_small_strings, Fmake_bool_vector, make_string)
1264 (make_unibyte_string, make_multibyte_string)
1265 (make_string_from_bytes, make_specified_string)
1266 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1267 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1269 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1270 (allocate_pseudovector):
1271 Use int, not EMACS_INT, where int is wide enough.
1272 (inhibit_garbage_collection, Fgarbage_collect):
1273 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1274 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1275 int might not be wide enough.
1276 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1277 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1278 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1279 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1280 (bidi_level_of_next_char, bidi_move_to_visually_next):
1281 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1282 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1283 (Fkill_buffer, Fset_buffer_major_mode)
1284 (advance_to_char_boundary, Fbuffer_swap_text)
1285 (Fset_buffer_multibyte, overlays_at, overlays_in)
1286 (overlay_touches_p, struct sortvec, record_overlay_string)
1287 (overlay_strings, recenter_overlay_lists)
1288 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1289 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1290 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1291 (Foverlay_recenter, last_overlay_modification_hooks_used)
1292 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1293 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1294 (validate_region): Omit unnecessary test for b <= e,
1295 since that's guaranteed by the previous test.
1296 (adjust_overlays_for_delete): Avoid pos + length overflow.
1297 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1298 (report_overlay_modification):
1299 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1300 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1301 Omit pointer cast, which isn't needed anyway, and doesn't work
1302 after the EMACS_INT -> ptrdiff_t change.
1303 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
1304 * buffer.h: Adjust decls to match defn changes elsewhere.
1305 (struct buffer_text, struct buffer):
1306 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1307 Use EMACS_INT, not int, where int might not be wide enough.
1308 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1309 not int, to avoid needless 32-bit limit on 64-bit hosts.
1310 (exec_byte_code): Use tighter memory-full test, one that checks
1311 for alloca overflow. Don't compute the address of the object just
1312 before an array, as that's not portable. Use EMACS_INT, not
1313 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
1314 * callint.c (Fcall_interactively):
1315 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1316 * callproc.c (call_process_kill, Fcall_process):
1317 Don't assume pid_t fits into an Emacs fixnum.
1318 (call_process_cleanup, Fcall_process, child_setup):
1319 Don't assume pid_t fits into int.
1320 (call_process_cleanup, Fcall_process, delete_temp_file)
1321 (Fcall_process_region):
1322 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1323 (Fcall_process): Simplify handling of volatile integers.
1324 Use int, not EMACS_INT, where int will do.
1325 * casefiddle.c (casify_object, casify_region, operate_on_word)
1326 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1327 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1328 (casify_object): Avoid integer overflow when overallocating buffer.
1329 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
1330 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
1331 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1332 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1333 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1334 integers are now checked earlier. All uses replaced with XINT.
1336 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1337 For CCL_MapSingle, check that content and value are in int range.
1338 (ccl_driver, Fregister_code_conversion_map):
1339 Check that Vcode_version_map_vector is a vector.
1340 (resolve_symbol_ccl_program): Check that vector header is in range.
1341 Always copy the vector, so that we can check its contents reliably
1342 now rather than having to recheck each instruction as it's being
1343 executed. Check that vector words fit in 'int'.
1344 (ccl_get_compiled_code, Fregister_ccl_program)
1345 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1346 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1347 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1348 contents are in range.
1349 (Fccl_execute_on_string): Check that status is in range.
1350 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1351 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1352 Accept and return EMACS_INT, not int, because callers can pass values
1354 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1355 (multibyte_chars_in_text, parse_str_as_multibyte)
1356 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1357 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1358 (string_escape_byte8, Fget_byte):
1359 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1360 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
1361 avoid mishandling large integers.
1362 * character.h: Adjust decls to match defn changes elsewhere.
1363 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1364 (Ffind_charset_region):
1365 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1366 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1367 (load_charset_map_from_vector, Fdefine_charset_internal):
1368 Don't assume fixnum fits in int.
1369 (load_charset_map_from_vector, Fmap_charset_chars):
1370 Remove now-unnecessary CHECK_NATNUMs.
1371 (Fdefine_charset_internal): Check ranges here, more carefully.
1372 Don't rely on undefined behavior with signed left shift overflow.
1373 Don't assume unsigned int fits into fixnum, or that fixnum fits
1374 into unsigned int. Don't require max_code to be a valid fixnum;
1375 that's not true for gb10830 4-byte on a 32-bit host. Allow
1376 invalid_code to be a cons, for the same reason. Require code_offset
1377 to be a character. Avoid int overflow if max_char is close
1379 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1380 this is intended anyway and avoids some undefined behavior.
1381 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1382 INDEX_TO_CODE_POINT, as that's what it expects.
1383 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
1384 * charset.h (DECODE_CHAR): Return int, not unsigned;
1385 this is what was intended anyway, and it avoids undefined behavior.
1386 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1387 integer-overflow issues.
1388 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1389 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1390 where the argument is EMACS_INT, and this behavior is not intended.
1391 * chartab.c (Fmake_char_table, Fset_char_table_range)
1392 (uniprop_get_decoder, uniprop_get_encoder):
1393 Don't assume fixnum fits in int.
1394 * cmds.c (move_point): New function, that does the gist of
1395 Fforward_char and Fbackward_char, but does so while checking
1396 for integer overflow more accurately.
1397 (Fforward_char, Fbackward_char): Use it.
1398 (Fforward_line, Fend_of_line, internal_self_insert)
1399 (internal_self_insert):
1400 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1401 Fix a FIXME, by checking for integer overflow when calculating
1402 target_clm and actual_clm.
1403 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
1404 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
1405 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1406 (coding_alloc_by_making_gap, alloc_destination)
1407 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1408 (encode_coding_utf_16, detect_coding_emacs_mule)
1409 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1410 (detect_coding_iso_2022, decode_coding_iso_2022)
1411 (encode_invocation_designation, encode_designation_at_bol)
1412 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1413 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1414 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1415 (encode_coding_ccl, encode_coding_raw_text)
1416 (detect_coding_charset, decode_coding_charset)
1417 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1418 (produce_composition, produce_charset, produce_annotation)
1419 (decode_coding, handle_composition_annotation)
1420 (handle_charset_annotation, consume_chars, decode_coding_gap)
1421 (decode_coding_object, encode_coding_object, detect_coding_system)
1422 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1423 (code_convert_region, code_convert_string)
1424 (Fdefine_coding_system_internal)
1425 (coding_set_source, coding_set_destination):
1426 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1427 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1428 (Fdefine_coding_system_internal):
1429 Don't assume fixnums fit in int.
1430 (decode_coding_gap, decode_coding_object, encode_coding_object)
1431 (Fread_coding_system, Fdetect_coding_region)
1432 (Funencodable_char_position, Fcheck_coding_systems_region)
1433 (get_translation, handle_composition_annotation, consume_chars):
1434 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1435 (consume_chars): Rewrite to not calculate an address outside buffer.
1436 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
1437 Don't access memory outside of the args array.
1438 (Fdefine_coding_system_internal): Check for charset-id overflow.
1439 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1440 result of ENCODE_CHAR.
1441 * coding.h: Adjust decls to match defn changes elsewhere.
1442 (struct coding_system):
1443 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1444 * composite.c (get_composition_id, find_composition)
1445 (run_composition_function, update_compositions)
1446 (compose_text, composition_gstring_put_cache)
1447 (composition_gstring_p, composition_gstring_width)
1448 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1449 (composition_compute_stop_pos, composition_reseat_it)
1450 (composition_update_it, struct position_record)
1451 (find_automatic_composition, composition_adjust_point)
1452 (Fcomposition_get_gstring, Ffind_composition_internal):
1453 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1454 (update_compositions):
1455 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1456 * composite.h: Adjust decls to match defn changes elsewhere.
1457 (struct composition):
1458 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1459 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1460 Do not attempt to compute the address of the object just before a
1461 buffer; this is not portable.
1463 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1464 (Faset): Use int, not EMACS_INT, where int is wide enough.
1465 (Fstring_to_number): Don't assume fixnums fit in int.
1466 (Frem): Don't assume arg is nonnegative.
1467 * dbusbind.c (xd_append_arg): Check for integers out of range.
1468 (Fdbus_call_method): Don't overflow the timeout int.
1469 (extract_signed, extract_unsigned): New functions.
1470 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1471 (xd_get_connection_references): Return ptrdiff_t, not int.
1473 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1474 (xd_read_message_1):
1475 Use int, not unsigned, where the dbus API uses int.
1476 (Fdbus_message_internal): Don't overflow mtype.
1477 (syms_of_dbusbind): Allocate right-sized buffer for integers.
1478 * dired.c (directory_files_internal, file_name_completion, scmp)
1479 (file_name_completion_stat):
1480 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1481 (file_name_completion): Don't overflow matchcount.
1482 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1483 * dispextern.h: Adjust decls to match defn changes elsewhere.
1484 (struct text_pos, struct glyph, struct bidi_saved_info)
1485 (struct bidi_string_data, struct bidi_it, struct composition_it)
1487 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1488 (struct display_pos, struct composition_it, struct it):
1489 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1490 * dispnew.c (increment_matrix_positions)
1491 (increment_row_positions, mode_line_string)
1492 (marginal_area_string):
1493 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1494 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
1495 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1496 (duration_to_sec_usec): New function, to check for overflow better.
1497 (Fsleep_for, sit_for): Use it.
1498 * doc.c (get_doc_string, store_function_docstring):
1499 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1500 (get_doc_string, Fsnarf_documentation):
1501 Use int, not EMACS_INT, where int is wide enough.
1503 Use SAFE_ALLOCA, not alloca.
1504 Check for overflow when converting EMACS_INT to off_t.
1505 * doprnt.c (doprnt):
1506 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1507 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1508 Don't assume uid_t fits into fixnum.
1509 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1510 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1511 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1512 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1513 (general_insert_function)
1514 (Finsert_char, make_buffer_string, make_buffer_string_both)
1515 (update_buffer_properties, Fbuffer_substring)
1516 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1517 (Fsubst_char_in_region, check_translation)
1518 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1519 (transpose_markers, Ftranspose_regions):
1520 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1521 (clip_to_bounds): Move to lisp.h as an inline function).
1522 (Fconstrain_to_field): Don't assume integers are nonnegative.
1523 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1524 (Fsubst_char_in_region, Fsave_restriction):
1525 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1526 (Femacs_pid): Don't assume pid_t fits into fixnum.
1527 (lo_time): Use int, not EMACS_INT, when int suffices.
1528 (lisp_time_argument): Check for usec out of range.
1529 (Fencode_time): Don't assume fixnum fits in int.
1530 (Fuser_login_name, Fuser_full_name): Signal an error
1531 if a uid argument is out of range, rather than relying on
1533 (Fformat_time_string): Remove now-unnecessary check.
1534 lisp_time_argument checks for out-of-range usec now.
1535 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
1536 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1537 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1538 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1539 (init_cmdargs, Fdump_emacs):
1540 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1541 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1542 the bottom (typically) 32 bits of the fixnum.
1543 * eval.c (specpdl_size, call_debugger):
1544 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1545 (when_entered_debugger, Fbacktrace_debug):
1546 Don't assume fixnum can fit in int.
1547 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1548 the object just before a buffer; this is not portable.
1549 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1550 (grow_specpdl, unbind_to):
1551 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1552 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1553 (grow_specpdl): Simplify allocation by using xpalloc.
1554 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
1555 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1556 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1557 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1558 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1560 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1561 (Fcopy_file, non_regular_nbytes, read_non_regular)
1562 (Finsert_file_contents):
1563 Use int, not EMACS_INT, where int is wide enough.
1564 (READ_BUF_SIZE): Verify that it fits in int.
1565 (Finsert_file_contents): Check that counts are in proper range,
1566 rather than assuming fixnums fit into ptrdiff_t etc.
1567 Don't assume fixnums fit into int.
1568 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
1569 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1570 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
1571 (string_char_to_byte, string_byte_to_char)
1572 (string_make_multibyte, string_to_multibyte)
1573 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1574 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1575 (substring_both, Fdelete, internal_equal, Ffillarray)
1576 (Fclear_string, mapcar1)
1577 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1578 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1579 (larger_vector, make_hash_table, maybe_resize_hash_table)
1580 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1581 (Fmaphash, secure_hash):
1582 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1583 (concat): Check for string index and length overflow.
1584 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1586 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1587 (larger_vector): New API (vec, incr_min, size_max) replaces old
1588 one (vec, new_size, init). This catches size overflow.
1589 INIT was removed because it was always Qnil.
1590 All callers changed.
1591 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1592 the upper bound on a hash table index size.
1593 (make_hash_table, maybe_resize_hash_table): Use it.
1594 (secure_hash): Computer start_byte and end_byte only after
1595 they're known to be in ptrdiff_t range.
1596 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1597 (Ffont_get_glyphs, Ffont_at):
1598 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1599 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1600 (Flist_fonts, Fopen_font):
1601 Don't assume fixnum can fit in int.
1602 (check_gstring): Don't assume index can fit in int.
1603 (font_match_p): Check that fixnum is a character, not a nonnegative
1604 fixnum, since the later code needs to stuff it into an int.
1605 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1606 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1607 conversion overflow issues.
1608 (Fopen_font): Check for integer out of range.
1609 (Ffont_get_glyphs): Don't assume index can fit in int.
1610 * font.h: Adjust decls to match defn changes elsewhere.
1611 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1613 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1614 printmax_t, where ptrdiff_t is wide enough.
1615 (Finternal_char_font):
1616 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1617 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1618 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1619 (Fset_frame_position, x_set_frame_parameters)
1620 (x_set_line_spacing, x_set_border_width)
1621 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1622 Check that fixnums are in proper range for system types.
1623 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1624 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1625 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1626 Use SAFE_ALLOCA_LISP, not alloca.
1627 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1628 intptr_t is wide enough.
1629 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1630 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1631 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1632 Check for fixnum out of range.
1633 * ftfont.c (ftfont_list): Don't assume index fits in int.
1634 Check that fixnums are in proper range for system types.
1635 (ftfont_shape_by_flt):
1636 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1637 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1638 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1639 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1640 Check that fixnums are in proper range for system types.
1641 * gnutls.h: Adjust decls to match defn changes elsewhere.
1642 * gtkutil.c (xg_dialog_run):
1643 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1644 (update_frame_tool_bar):
1645 Check that fixnums are in proper range for system types.
1646 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
1647 (lookup_image): Check that fixnums are in range for system types.
1648 * indent.c (last_known_column, last_known_column_point):
1649 (current_column_bol_cache):
1650 (skip_invisible, current_column, check_display_width):
1651 (check_display_width, scan_for_column, current_column_1)
1652 (Findent_to, Fcurrent_indentation, position_indentation)
1653 (indented_beyond_p, Fmove_to_column, compute_motion):
1654 (Fcompute_motion, Fvertical_motion):
1655 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1656 (last_known_column_modified): Use EMACS_INT, not int.
1657 (check_display_width):
1659 Check that fixnums and floats are in proper range for system types.
1660 (compute_motion): Don't assume index or fixnum fits in int.
1661 (compute_motion, Fcompute_motion):
1662 Use int, not EMACS_INT, when it is wide enough.
1663 (vmotion): Omit local var start_hpos that is always 0; that way
1664 we don't need to worry about overflow in expressions involving it.
1665 * indent.h: Adjust decls to match defn changes elsewhere.
1667 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1668 Use int, not EMACS_INT, where int is wide enough.
1669 Remove unused members ovstring_chars_done and tab_offset;
1671 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1672 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1673 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1674 (make_gap, copy_text, insert, insert_and_inherit)
1675 (insert_before_markers, insert_before_markers_and_inherit)
1676 (insert_1, count_combining_before, count_combining_after)
1677 (insert_1_both, insert_from_string)
1678 (insert_from_string_before_markers, insert_from_string_1)
1679 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1680 (adjust_after_replace, adjust_after_insert, replace_range)
1681 (replace_range_2, del_range, del_range_1, del_range_byte)
1682 (del_range_both, del_range_2, modify_region)
1683 (prepare_to_modify_buffer, signal_before_change)
1684 (signal_after_change, Fcombine_after_change_execute):
1685 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1686 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1687 (balance_an_interval, split_interval_right, split_interval_left)
1688 (find_interval, next_interval, update_interval)
1689 (adjust_intervals_for_insertion, delete_node, delete_interval)
1690 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1691 (static_offset_intervals, offset_intervals)
1692 (merge_interval_right, merge_interval_left, make_new_interval)
1693 (graft_intervals_into_buffer, temp_set_point_both)
1694 (temp_set_point, set_point, adjust_for_invis_intang)
1695 (set_point_both, move_if_not_intangible, get_property_and_range)
1696 (get_local_map, copy_intervals, copy_intervals_to_string)
1697 (compare_string_intervals, set_intervals_multibyte_1):
1698 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1699 * intervals.h: Adjust decls to match defn changes elsewhere.
1701 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1702 * keyboard.c (this_command_key_count, this_single_command_key_start)
1703 (before_command_key_count, before_command_echo_length, echo_now)
1704 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1705 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1706 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1707 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1708 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1709 (last_non_minibuf_size, last_point_position, echo_truncate)
1710 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1711 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1712 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1713 (stuff_buffered_input):
1714 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1715 (last_auto_save, command_loop_1, read_char):
1716 Use EMACS_INT, not int, to avoid integer overflow.
1717 (record_char): Avoid overflow in total_keys computation.
1718 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1719 * keyboard.h: Adjust decls to match defn changes elsewhere.
1720 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1721 (Fkey_description, Fdescribe_vector, Flookup_key):
1722 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1723 (click_position): New function, to check that positions are in range.
1724 (Fcurrent_active_maps):
1726 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1727 (Faccessible_keymaps, Fkey_description):
1728 (preferred_sequence_p):
1729 Don't assume fixnum can fit into int.
1730 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1731 Check for integer overflow in size calculations.
1732 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1733 avoid mishandling large integers.
1734 * lisp.h: Adjust decls to match defn changes elsewhere.
1735 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1736 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1737 (struct Lisp_Marker):
1738 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1739 (clip_to_bounds): Now an inline function, moved here from editfns.c.
1740 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1741 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1742 All callers changed.
1743 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1744 Assume the arg has valid form, since it always does.
1745 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1746 unsigned integer system type.
1747 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1748 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1749 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1750 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1751 (duration_to_sec_usec): New decl.
1752 * lread.c (read_from_string_index, read_from_string_index_byte)
1753 (read_from_string_limit, readchar, unreadchar, openp)
1754 (read_internal_start, read1, oblookup):
1755 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1756 (Fload, readevalloop, Feval_buffer, Feval_region):
1757 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1758 (openp): Check for out-of-range argument to 'access'.
1759 (read1): Use int, not EMACS_INT, where int is wide enough.
1760 Don't assume fixnum fits into int.
1761 Fix off-by-one error that can read outside a buffer.
1762 (read_filtered_event): Use duration_to_sec_usec
1763 to do proper overflow checking on durations.
1764 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1765 in size calculation.
1766 (Fexecute_kbd_macro):
1767 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1768 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1769 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1770 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1771 (set_marker_both, set_marker_restricted_both, marker_position)
1772 (marker_byte_position, Fbuffer_has_markers_at):
1773 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1774 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
1775 * menu.c (ensure_menu_items): Rename from grow_menu_items.
1776 It now merely ensures that the menu is large enough, without
1777 necessarily growing it, as this avoids some integer overflow issues.
1778 All callers changed.
1779 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1780 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1781 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1782 Use SAFE_ALLOCA_LISP, not alloca.
1783 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1784 to EMACS_INT. Check that fixnums are in proper range for system types.
1785 * minibuf.c (minibuf_prompt_width, string_to_object)
1786 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1787 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1788 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1789 (get_minibuffer, read_minibuf_unwind):
1790 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1791 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1792 this simplifies overflow checking. All callers changed.
1793 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1795 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1796 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1797 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1798 Check that fixnums are in proper range for system types.
1799 (Fx_create_frame, Fx_show_tip):
1800 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1801 * nsfont.m (ns_findfonts, nsfont_list_family):
1802 Don't assume fixnum fits in long.
1803 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1804 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1805 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1807 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
1808 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1809 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1810 (PRINTDECLARE, PRINTPREPARE):
1811 (strout, print_string):
1812 (print, print_preprocess, print_check_string_charset_prop)
1814 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1816 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1817 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1818 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
1819 (printchar, strout): Use xpalloc to catch size calculation overflow.
1820 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
1821 (print_error_message): Use SAFE_ALLOCA, not alloca.
1822 (print_object): Use int, not EMACS_INT, where int is wide enough.
1823 (print_depth, new_backquote_output, print_number_index):
1824 Use ptrdiff_t, not int, where int might not be wide enough.
1825 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1826 (Fset_process_window_size, Fformat_network_address)
1827 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
1829 Check that fixnums are in proper range for system types.
1830 (Fsignal_process): Simplify by avoiding a goto.
1831 Check for process-ids out of pid_t range rather than relying on
1833 (process_tick, update_tick): Use EMACS_INT, not int.
1834 (Fformat_network_address, read_process_output, send_process)
1835 (Fprocess_send_region, status_notify):
1836 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1837 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1838 (wait_reading_process_output, read_process_output, exec_sentinel):
1839 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1840 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1841 (Faccept_process_output): Use duration_to_sec_usec to do proper
1842 overflow checking on durations.
1843 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1844 Don't assume pid_t fits in int.
1845 * process.h (struct Lisp_Process): Members tick and update_tick
1846 are now of type EMACS_INT, not int.
1847 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1848 configured --with-wide-int.
1849 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1850 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1851 * search.c (looking_at_1, string_match_1):
1852 (fast_string_match, fast_c_string_match_ignore_case)
1853 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1854 (scan_newline, find_before_next_newline, search_command)
1855 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1856 (set_search_regs, wordify):
1859 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1860 (string_match_1, search_buffer, set_search_regs):
1862 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1863 (wordify): Check for overflow in size calculation.
1864 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1865 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1866 Check that fixnums are in proper range for system types.
1867 * sound.c (struct sound_device)
1868 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1869 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1870 (Fplay_sound_internal):
1871 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1872 * syntax.c (struct lisp_parse_state, find_start_modiff)
1873 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1874 (Fparse_partial_sexp):
1875 Don't assume fixnums can fit in int.
1876 (struct lisp_parse_state, find_start_pos, find_start_value)
1877 (find_start_value_byte, find_start_begv)
1878 (update_syntax_table, char_quoted, dec_bytepos)
1879 (find_defun_start, prev_char_comend_first, back_comment):
1880 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1881 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1882 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1883 (Finternal_describe_syntax_value): Check that match_lisp is a
1884 character, not an integer, since the code stuffs it into int.
1885 (scan_words, scan_sexps_forward):
1886 Check that fixnums are in proper range for system types.
1888 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1889 (scan_sexps_forward):
1890 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1891 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1892 * syntax.h: Adjust decls to match defn changes elsewhere.
1893 (struct gl_state_s):
1894 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1895 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1896 MOST_POSITIVE_FIXNUM.
1897 * sysdep.c (wait_for_termination_1, wait_for_termination)
1898 (interruptible_wait_for_termination, mkdir):
1899 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1900 (emacs_read, emacs_write):
1901 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1902 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1903 and double all fit in int.
1904 * term.c (set_tty_color_mode):
1905 Check that fixnums are in proper range for system types.
1906 * termhooks.h (struct input_event):
1907 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1908 * textprop.c (validate_interval_range, interval_of)
1909 (Fadd_text_properties, set_text_properties_1)
1910 (Fremove_text_properties, Fremove_list_of_text_properties)
1911 (Ftext_property_any, Ftext_property_not_all)
1912 (copy_text_properties, text_property_list, extend_property_ranges)
1913 (verify_interval_modification):
1914 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1915 (Fnext_single_char_property_change)
1916 (Fprevious_single_char_property_change):
1917 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1918 (copy_text_properties):
1919 Check for integer overflow in index calculation.
1920 * undo.c (last_boundary_position, record_point, record_insert)
1921 (record_delete, record_marker_adjustment, record_change)
1922 (record_property_change):
1923 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1924 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1925 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1926 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1927 (Fx_hide_tip, Fx_file_dialog):
1928 * w32menu.c (set_frame_menubar):
1929 Use ptrdiff_t, not int, for consistency with rest of code.
1930 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1931 (select_window, Fdelete_other_windows_internal)
1932 (window_scroll_pixel_based, window_scroll_line_based)
1933 (Frecenter, Fset_window_configuration):
1934 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1935 (Fset_window_hscroll, run_window_configuration_change_hook)
1936 (set_window_buffer, temp_output_buffer_show, scroll_command)
1937 (Fscroll_other_window, Frecenter):
1938 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1939 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1940 Don't assume fixnum fits in int.
1941 (Fset_window_scroll_bars):
1942 Check that fixnums are in proper range for system types.
1943 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1944 (string_pos, c_string_pos, number_of_chars, init_iterator)
1945 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1946 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1947 (compute_display_string_end, handle_face_prop)
1948 (face_before_or_after_it_pos, handle_invisible_prop)
1949 (handle_display_prop, handle_display_spec, handle_single_display_spec)
1950 (display_prop_intangible_p, string_buffer_position_lim)
1951 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1952 (get_overlay_strings_1, get_overlay_strings)
1953 (iterate_out_of_display_property, forward_to_next_line_start)
1954 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1955 (get_next_display_element, set_iterator_to_next)
1956 (get_visually_first_element, compute_stop_pos_backwards)
1957 (handle_stop_backwards, next_element_from_buffer)
1958 (move_it_in_display_line_to, move_it_in_display_line)
1959 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1960 (add_to_log, message_dolog, message_log_check_duplicate)
1961 (message2, message2_nolog, message3, message3_nolog
1962 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1963 (current_message_1, truncate_echo_area, truncate_message_1)
1964 (set_message, set_message_1, store_mode_line_noprop)
1965 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1966 (text_outside_line_unchanged_p, check_point_in_composition)
1967 (reconsider_clip_changes)
1968 (redisplay_internal, set_cursor_from_row, try_scrolling)
1969 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1970 (redisplay_window, find_last_unchanged_at_beg_row)
1971 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1972 (trailing_whitespace_p, find_row_edges, display_line)
1973 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1974 (display_mode_element, store_mode_line_string)
1975 (pint2str, pint2hrstr, decode_mode_spec)
1976 (display_count_lines, display_string, draw_glyphs)
1977 (x_produce_glyphs, x_insert_glyphs)
1978 (rows_from_pos_range, mouse_face_from_buffer_pos)
1979 (fast_find_string_pos, mouse_face_from_string_pos)
1980 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1981 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1982 (safe_call, init_from_display_pos, handle_fontified_prop)
1983 (handle_single_display_spec, load_overlay_strings)
1984 (with_echo_area_buffer, setup_echo_area_for_printing)
1985 (display_echo_area, echo_area_display)
1986 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1987 (update_tool_bar, hscroll_window_tree, redisplay_internal)
1988 (redisplay_window, dump_glyph_row, display_mode_line)
1989 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
1990 (handle_display_spec, display_prop_string_p):
1991 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1992 (handle_single_display_spec, build_desired_tool_bar_string)
1993 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1994 (get_specified_cursor_type):
1995 Check that fixnums are in proper range for system types.
1996 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1997 (Flookup_image_map):
1998 Don't assume fixnums fit in int.
1999 (compare_overlay_entries):
2000 Avoid mishandling comparisons due to subtraction overflow.
2001 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2002 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2003 (handle_tool_bar_click):
2004 Use int, not unsigned, since we prefer signed and the signedness
2005 doesn't matter here.
2006 (get_next_display_element, next_element_from_display_vector):
2007 Use int, not EMACS_INT, when int is wide enough.
2008 (start_hourglass): Use duration_to_sec_usec to do proper
2009 overflow checking on durations.
2010 * xfaces.c (Fbitmap_spec_p):
2011 Check that fixnums are in proper range for system types.
2012 (compare_fonts_by_sort_order):
2013 Avoid mishandling comparisons due to subtraction overflow.
2014 (Fx_family_fonts, realize_basic_faces):
2015 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2017 Don't assume fixnum fits in int.
2018 Use SAFE_ALLOCA_LISP, not alloca.
2019 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2020 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2021 (face_at_buffer_position, face_for_overlay_string)
2022 (face_at_string_position):
2023 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2024 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2025 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2027 Check that fixnums are in proper range for system types.
2028 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2029 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2030 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2031 (Fx_change_window_property): Don't assume fixnums fit in int.
2032 * xfont.c (xfont_chars_supported):
2033 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2034 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2035 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2036 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2037 * xml.c (parse_region):
2038 * xrdb.c (magic_file_p):
2039 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2040 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2041 (x_get_local_selection, x_reply_selection_request)
2042 (x_handle_selection_request, wait_for_property_change):
2043 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2044 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2045 short is wide enough.
2046 (x_send_client_event): Don't assume fixnum fits in int.
2047 * xterm.c (x_x_to_emacs_modifiers):
2048 Don't assume EMACS_INT overflows nicely into int.
2049 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2051 (handle_one_xevent): NATNUMP can eval its arg twice.
2052 (x_connection_closed):
2053 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2054 * xterm.h: Adjust decls to match defn changes elsewhere.
2055 (struct scroll_bar): Use struct vectorlike_header
2056 rather than rolling our own approximation.
2057 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2059 2012-05-25 Glenn Morris <rgm@gnu.org>
2061 * lisp.mk (lisp): Update for more files being compiled now.
2063 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2065 * lread.c: Remove `read_pure' which makes no difference.
2066 (read_pure): Remove var.
2067 (unreadpure): Remove function.
2068 (readevalloop): Don't call read_list with -1 flag.
2069 (read1, read_vector): Don't test read_pure any more.
2070 (read_list): Simplify.
2072 * fileio.c, character.h: Minor style tweaks.
2074 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2076 * window.h (clip_changed): Remove useless declaration.
2078 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
2080 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2081 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2083 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2086 This directory predates autoconf and is no longer needed nowadays.
2087 Move its few remaining bits of functionality to where they're needed.
2088 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2089 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2090 * m/template.h: Remove.
2091 * Makefile.in (M_FILE): Remove. All uses removed.
2092 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2093 * lisp.h (USE_LSB_TAG):
2094 * mem-limits.h (EXCEEDS_LISP_PTR):
2095 Use VAL_MAX, not VALBITS, in #if.
2096 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2097 (EMACS_UINT): Define unconditionally now.
2098 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2099 (BITS_PER_EMACS_INT): New constants, replacing
2100 what used to be in config.h, but not useful in #if.
2101 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2102 define them any more.
2103 (VAL_MAX): New macro.
2105 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2106 BITS_PER_EMACS_INT, in #if.
2107 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2108 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2109 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2110 * s/ms-w32.h (DATA_START):
2111 Move here from removed file m/intel386.h.
2112 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2113 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2115 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2117 Assume C89 or later.
2118 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2119 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2121 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2122 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2123 * textprop.c, tparam.c (NULL): Remove.
2124 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2125 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2126 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2127 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2128 * xterm.c (input_signal_count): Assume volatile works.
2130 2012-05-21 Ken Brown <kbrown@cornell.edu>
2132 * xgselect.c (xg_select): Fix first argument in call to 'select'
2135 2012-05-20 Ken Brown <kbrown@cornell.edu>
2137 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
2138 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
2140 2012-05-19 Ken Brown <kbrown@cornell.edu>
2142 * xfns.c (x_in_use): Remove `static' qualifier.
2143 * xterm.h (x_in_use): Declare.
2144 * xgselect.c: Include xterm.h.
2145 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2146 and `display_arg' (bug#9754).
2148 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2150 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2152 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2153 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2155 2012-05-18 Eli Zaretskii <eliz@gnu.org>
2157 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2159 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2160 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
2162 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2163 reference to image_cache->refcount.
2164 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2166 2012-05-17 Juri Linkov <juri@jurta.org>
2168 * search.c (Fword_search_regexp, Fword_search_backward)
2169 (Fword_search_forward, Fword_search_backward_lax)
2170 (Fword_search_forward_lax): Move functions to isearch.el
2171 (bug#10145, bug#11381).
2173 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2175 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2177 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2179 * lread.c (init_obarray): Declare Qt and Qnil as special.
2181 2012-05-14 Glenn Morris <rgm@gnu.org>
2183 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
2184 Put "libexec" before "bin", for the sake of init_callproc_1.
2186 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2188 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2190 * unexaix.c: Port to more-recent AIX compilers.
2191 (report_error, report_error_1, make_hdr, copy_sym)
2192 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2193 Make arguments const char *, not char *, to avoid violations of C
2194 standard and to fix some AIX warnings reported by Gilles Pion.
2196 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2198 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2199 already have overlays loaded.
2200 (handle_single_display_spec): Before returning without displaying
2201 fringe bitmap, synchronize the bidi iterator with the main display
2202 iterator, by calling iterate_out_of_display_property.
2203 (iterate_out_of_display_property): Detect buffer iteration by
2204 testing that it->string is a Lisp string.
2205 (get_next_display_element): When the current object is exhausted,
2206 and there's something on it->stack, call set_iterator_to_next to
2207 proceed with what's on the stack, instead of returning zero.
2208 (set_iterator_to_next): If called at the end of a Lisp string,
2209 proceed to consider_string_end without incrementing string
2210 position. Don't increment display vector index past the end of
2211 the display vector. (Bug#11417)
2212 (pos_visible_p): Don't report a position visible when move_it_to
2213 stopped at the last line of window, which happens to be scanned
2214 backwards by the bidi iteration. (Bug#11464)
2216 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2218 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2219 and right-margin display specs even if the spec is invalid or we
2220 are on a TTY, and thus unable to display on the fringes.
2221 That's because the text with the property will not be displayed anyway,
2222 so we need to signal to the caller that this is a "replacing"
2223 display spec. This fixes display when the spec is invalid or we
2226 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2228 * unexaix.c (make_hdr): Fix typo in prototype.
2229 This bug broke the build on AIX. Problem reported by Gilles Pion.
2231 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
2233 * keyboard.c (kbd_buffer_get_event): Read special events also in
2234 batch mode. (Bug#11415)
2236 2012-05-12 Glenn Morris <rgm@gnu.org>
2238 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2240 2012-05-12 Eli Zaretskii <eliz@gnu.org>
2242 * lisp.mk (lisp): Add newcomment.elc.
2244 2012-05-12 Glenn Morris <rgm@gnu.org>
2246 * Makefile.in (MKDIR_P): New, set by configure.
2247 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2249 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2251 Remove unused function hourglass_started.
2252 * dispextern.h (hourglass_started):
2253 * w32fns.c (hourglass_started):
2254 * xdisp.c (hourglass_started): Remove.
2256 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
2258 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2259 Update dependencies.
2261 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2263 * xgselect.c (xg_select): Put maxfds+1 into a var.
2264 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2266 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2268 2012-05-10 Dave Abrahams <dave@boostpro.com>
2270 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2271 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2273 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
2275 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2276 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2277 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2278 Initialize xd_registered_buses.
2280 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2282 Untag more efficiently if USE_LSB_TAG.
2283 This is based on a proposal by YAMAMOTO Mitsuharu in
2284 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2285 For an admittedly artificial (nth 8000 longlist) benchmark on
2286 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2287 Emacs's overall text size by 1%.
2288 * lisp.h (XUNTAG): New macro.
2289 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2290 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2291 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2292 * eval.c (Fautoload):
2293 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2294 * frame.h (XFRAME): Use XUNTAG.
2296 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2297 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2298 Remove unportable assumptions about print widths of types like
2300 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2301 intptr_t when converting between pointer and integer, to avoid GCC
2302 warnings about wrong width.
2304 2012-05-09 Eli Zaretskii <eliz@gnu.org>
2306 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2307 stack for each reader_thread, instead of defaulting to 8MB
2308 determined by the linker. This avoids failures in creating
2309 subprocesses on Windows 7, see the discussion in this thread:
2310 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2312 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2314 Fix up display of the *Minibuf-0* buffer in the mini window.
2315 * keyboard.c (read_char): Don't clear the echo area if there's no
2317 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2318 contents of *Minibuf-0*) if there's no message displayed in its stead.
2320 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
2322 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2325 2012-05-06 Chong Yidong <cyd@gnu.org>
2327 * lisp.mk (lisp): Update.
2329 2012-05-05 Jim Meyering <meyering@redhat.com>
2331 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2333 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2335 * data.c (PUT_ERROR): New macro.
2336 (syms_of_data): Use it. Add new error type `user-error'.
2337 * undo.c (user_error): New function.
2338 (Fprimitive_undo): Use it.
2339 * print.c (print_error_message): Adjust print style for `user-error'.
2340 * keyboard.c (user_error): New function.
2341 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2343 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2345 Do not limit current-time-string to years 1000..9999.
2346 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2347 (Fcurrent_time_string): Support any year that is supported by the
2348 underlying localtime representation. Don't use asctime, as it
2349 has undefined behavior for years outside the range -999..9999.
2351 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2353 Fix race conditions involving setenv, gmtime, localtime, asctime.
2354 Without this fix, interrupts could mess up code that uses these
2355 nonreentrant functions, since setting TZ invalidates existing
2356 tm_zone or tzname values, and since most of these functions return
2357 pointers to static storage.
2358 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2359 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2360 Grow the critical sections to include not just invoking
2361 localtime/gmtime, but also accessing these functions' results
2362 including their tm_zone values if any, and any related TZ setting.
2363 (format_time_string): Last arg is now struct tm *, not struct tm **,
2364 so that the struct tm is saved in the critical section.
2365 All callers changed. Simplify allocation of initial buffer, partly
2366 motivated by the fact that memory allocation needs to be outside
2367 the critical section.
2369 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2371 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2372 with RESET_INTERVAL.
2374 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2375 Remove duplicated buffer name initialization.
2377 2012-05-02 Jim Meyering <jim@meyering.net>
2379 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2381 * xfns.c (x_window): Use xstrdup (Bug#11375).
2383 2012-05-02 Eli Zaretskii <eliz@gnu.org>
2385 * xdisp.c (pos_visible_p): If already at a newline from the
2386 display string before the 'while' loop, don't walk back the glyphs
2387 from it3.glyph_row. Solves assertion violation when the display
2388 string begins with a newline (egg.el). (Bug#11367)
2390 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2392 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2395 2012-05-01 Glenn Morris <rgm@gnu.org>
2397 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2398 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2399 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2400 All were removed before 23.1.
2402 * dispnew.c: Remove HAVE_LIBNCURSES test;
2403 it is always true on relevant platforms.
2405 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2406 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2408 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2410 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2412 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2413 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2416 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2418 Do not avoid creating empty evaporating overlays (Bug#9642).
2419 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2420 That is, do not delete an evaporating overlay if it becomes
2421 empty after its bounds are adjusted to fit within its buffer.
2422 This fix caused other problems, and I'm reverting it until we get
2423 to the bottom of them.
2425 2012-04-27 Chong Yidong <cyd@gnu.org>
2427 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2429 2012-04-27 Eli Zaretskii <eliz@gnu.org>
2431 * xdisp.c (pos_visible_p): If the window start position is beyond
2432 ZV, start the display from buffer beginning. Prevents assertion
2433 violation in init_iterator when the minibuffer window is scrolled
2436 * window.c (window_scroll_pixel_based): Likewise.
2438 2012-04-27 Chong Yidong <cyd@gnu.org>
2440 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2442 2012-04-27 Glenn Morris <rgm@gnu.org>
2444 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2445 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2447 2012-04-27 Eli Zaretskii <eliz@gnu.org>
2449 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2450 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
2452 2012-04-26 Eli Zaretskii <eliz@gnu.org>
2454 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2455 display element, check also the underlying string or buffer
2456 character. (Bug#11341)
2458 * w32menu.c: Include w32heap.h.
2459 (add_menu_item): If the call to AppendMenuW (via
2460 unicode_append_menu) fails, disable Unicode menus only if we are
2461 running on Windows 9X/Me.
2463 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2465 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2466 (xgetint): Add missing shift for LSB tags.
2468 2012-04-24 Martin Rudalics <rudalics@gmx.at>
2470 * keyboard.c (read_char): Don't wipe echo area for select window
2471 events: These might get delayed via `mouse-autoselect-window'
2474 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
2476 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2477 manipulation of :loaded-from data.
2479 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
2481 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2482 now a cons (bug#11311).
2484 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2486 Do not create empty overlays with the evaporate property (Bug#9642).
2487 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2488 if it becomes empty after its bounds are adjusted to fit within
2489 its buffer. Without this fix, in a nonempty buffer (let ((o
2490 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2491 yields an empty overlay that has the evaporate property, which is
2492 not supposed to happen.
2494 Fix minor GTK3 problems found by static checking.
2495 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2496 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2497 (struct _EmacsFixedClass, emacs_fixed_get_type):
2498 Move decls here from emacsgtkfixed.h, since they needn't be public.
2499 (emacs_fixed_get_type): Now static.
2500 (emacs_fixed_class_init): Omit unused local.
2501 (emacs_fixed_child_type): Remove; unused.
2502 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2503 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2504 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2505 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2506 (EMACS_FIXED_GET_CLASS): Remove; unused.
2507 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2509 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2510 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2512 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2514 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
2515 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
2516 (__malloc_size_t, __malloc_ptrdiff_t):
2517 Remove. All uses removed, replaced by the definiens if needed,
2518 since we can assume C89 or better now.
2519 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2520 (protect_malloc_state, align, get_contiguous_space)
2521 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2522 (malloc_atfork_handler_child, malloc_enable_thread)
2523 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2524 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2525 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2526 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2527 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2528 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2529 Define using prototypes, not old style.
2530 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2531 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2532 (align): Don't assume that signed integer overflow wraps around.
2533 Omit unused local var.
2534 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2535 (_free_internal_nolock, memalign, mallochook, reallochook):
2536 Omit no-longer-needed casts.
2537 (valloc): Use getpagesize, not __getpagesize.
2538 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2539 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2541 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2543 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
2545 Move functions from C to Lisp. Make non-blocking method calls
2546 the default. Implement further D-Bus standard interfaces.
2548 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2549 (QCdbus_request_name_allow_replacement)
2550 (QCdbus_request_name_replace_existing)
2551 (QCdbus_request_name_do_not_queue)
2552 (QCdbus_request_name_reply_primary_owner)
2553 (QCdbus_request_name_reply_in_queue)
2554 (QCdbus_request_name_reply_exists)
2555 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2556 (QCdbus_registered_serial, QCdbus_registered_method)
2557 (QCdbus_registered_signal): New Lisp objects.
2558 (XD_DEBUG_MESSAGE): Use sizeof.
2559 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2560 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2561 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2562 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2563 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2564 (xd_signature, xd_append_arg): Allow float for integer types.
2565 (xd_get_connection_references): New function.
2566 (xd_get_connection_address): Rename from xd_initialize.
2567 Return cached address.
2568 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2569 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2571 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
2572 Return number of refcounts.
2573 (Fdbus_get_unique_name): Make stronger parameter check.
2574 (Fdbus_message_internal): New defun.
2575 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2576 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2577 (Fdbus_send_signal, Fdbus_register_service)
2578 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2579 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2580 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2581 (Vdbus_compiled_version, Vdbus_runtime_version)
2582 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2583 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2584 (Vdbus_message_type_signal): New defvars.
2585 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2588 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2590 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2591 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2592 Do not assume ptrdiff_t is the same width as 'int'.
2594 * alloc.c: Handle unusual debugging option combinations.
2595 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2596 since the two debugging options are incompatible.
2597 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2599 (mem_init, mem_insert, mem_insert_fixup):
2600 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2601 (NEED_MEM_INSERT): Remove; no longer needed.
2603 2012-04-22 Leo Liu <sdl.web@gmail.com>
2605 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2607 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2609 * sysdep.c [__FreeBSD__]: Minor cleanups.
2610 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2611 Use Emacs indenting style more consistently. Avoid some casts.
2612 Use 'double' consistently rather than mixing 'float' and 'double'.
2614 2012-04-21 Eduard Wiebe <usenet@pusto.de>
2616 * sysdep.c (list_system_processes, system_process_attributes):
2617 Add implementation for FreeBSD (Bug#5243).
2619 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2621 * lisp.mk (lisp): Update.
2623 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2625 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2626 It is never used otherwise.
2628 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2630 * print.c (print_preprocess): Only check print_depth if print-circle
2632 (print_object): Check for cycles even when print-circle is nil and
2633 print-gensym is t, but only check print_depth if print-circle is nil.
2635 2012-04-20 Chong Yidong <cyd@gnu.org>
2637 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2638 set the status to "failed" and ensure that sentinel is run.
2640 2012-04-20 Glenn Morris <rgm@gnu.org>
2642 * process.c (Fset_process_inherit_coding_system_flag)
2643 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
2644 (Fmake_network_process, Fmake_serial_process): Doc fix.
2646 2012-04-20 Eli Zaretskii <eliz@gnu.org>
2648 * xdisp.c (string_buffer_position_lim): Limit starting position to
2650 (set_cursor_from_row): If called for a mode-line or header-line
2651 row, return zero immediately.
2652 (try_cursor_movement): If inside continuation line, don't back up
2653 farther than the first row after the header line, if any.
2654 Don't consider the header-line row as "partially visible", even if
2655 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2657 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
2659 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2662 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
2663 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
2665 configure: new option --enable-gcc-warnings (Bug#11207)
2666 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2667 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2668 (ALL_CFLAGS): Use new macros rather than old.
2669 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2670 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2671 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2672 -Wunused-result, -Wunused-variable. This should go away once
2673 the Emacs and Gnulib regex code is merged.
2674 (xmalloc, xrealloc): Now static.
2676 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2678 * dired.c (Fsystem_groups): Remove unused local.
2680 2012-04-17 Glenn Morris <rgm@gnu.org>
2682 * dired.c (Fsystem_users): Doc fix.
2684 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2686 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2687 (syms_of_dired): Add them.
2689 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2691 Fix minor alloc.c problems found by static checking.
2692 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2693 New extern decls, to avoid calling undeclared functions.
2694 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2695 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2696 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2697 (NEED_MEM_INSERT): New macro.
2698 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
2699 Remove one incorrect comment and fix another.
2701 Fix minor ralloc.c problems found by static checking.
2702 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2703 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2704 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2705 (r_alloc_sbrk): Now static.
2707 Improve ralloc.c interface checking.
2708 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2709 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2710 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2711 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2712 [REL_ALLOC]: ... to here, to check interface.
2713 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2714 Remove decls. This fixes an "It stinks!".
2716 * alloc.c (which_symbols): Fix alignment issue / type clash.
2718 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2720 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2721 (struct Lisp_Misc_Any): Likewise.
2722 (struct Lisp_Free): Likewise.
2723 * alloc.c (union aligned_Lisp_Symbol): Define.
2724 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2725 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2726 (union aligned_Lisp_Misc): Define.
2727 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2728 aligned_Lisp_Misc instead of union Lisp_Misc.
2729 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
2731 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2733 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2734 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2735 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2736 * s/netbsd.h, s/sol2-6.h:
2737 Remove definition of GC_MARK_STACK, since the default now works.
2738 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2739 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2740 no longer the default.
2741 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2743 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
2745 * lread.c (lisp_file_lexically_bound_p):
2746 Fix hang at ";-*-\n" (bug#11238).
2748 2012-04-14 Eli Zaretskii <eliz@gnu.org>
2750 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2751 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2753 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2755 * nsterm.m (constrainFrameRect): Always constrain when there is only
2756 one screen (Bug#10962).
2758 2012-04-13 Ken Brown <kbrown@cornell.edu>
2760 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2762 2012-04-13 Reuben Thomas <rrt@sc3d.org>
2764 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2766 2012-04-11 Daniel Colascione <dancol@dancol.org>
2768 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2769 against is gone. It's better to use vfork now so that when Cygwin
2770 gains a new, working vfork, we use it automatically (bug#10398).
2772 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2774 * window.c (save_window_save): Obey window-point-insertion-type.
2776 2012-04-11 Glenn Morris <rgm@gnu.org>
2778 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2780 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2782 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2784 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
2786 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2787 (force_quit_count): New var.
2788 (handle_interrupt): Use it.
2790 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
2792 * w32.c (w32_delayed_load): Record the full path of the library
2793 being loaded (bug#10424).
2795 2012-04-09 Glenn Morris <rgm@gnu.org>
2797 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2798 not just in the obarray, before snarfing them. (Bug#11036)
2800 * Makefile.in ($(leimdir)/leim-list.el):
2801 Pass EMACS rather than BUILT_EMACS.
2803 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2805 * process.c (make_process):
2806 * process.h: Add integer `gnutls_handshakes_tried' member to
2809 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2810 Add convenience `GNUTLS_LOG2i' macro.
2812 * gnutls.c (gnutls_log_function2i): Convenience log function.
2813 (emacs_gnutls_read): Use new log functions,
2814 `gnutls_handshakes_tried' process member, and
2815 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2816 attempts per process (connection).
2818 2012-04-09 Chong Yidong <cyd@gnu.org>
2820 * eval.c (Fuser_variable_p, user_variable_p_eh)
2821 (lisp_indirect_variable): Functions deleted.
2822 (Fdefvar): Caller changed.
2824 * callint.c (Finteractive, Fcall_interactively):
2825 * minibuf.c (Fread_variable): Callers changed.
2827 2012-04-09 Eli Zaretskii <eliz@gnu.org>
2829 * xdisp.c (set_cursor_from_row): If the display string appears in
2830 the buffer at position that is closer to point than the position
2831 after the display string, display the cursor on the first glyph of
2832 the display string. Fixes cursor display when a 'display' text
2833 property immediately follows invisible text. (Bug#11094)
2835 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2837 composite.c: use 'double' consistently
2838 * composite.c (get_composition_id): Use 'double' consistently
2839 instead of converting 'float' to 'double' and vice versa; this is
2840 easier to understand and avoids a GCC warning.
2842 2012-04-09 Glenn Morris <rgm@gnu.org>
2844 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2845 preparation for dumping it with emacs. (Bug#4789)
2846 (leimdir): New variable.
2847 ($(leimdir)/leim-list.el): New rule.
2848 (emacs$(EXEEXT)): Depend on leim-list.el.
2850 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2851 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2852 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2854 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2856 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2859 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
2861 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2862 Remove unused local variable.
2864 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2866 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2867 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2868 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2869 objects, as mark_maybe_pointer will catch them otherwise.
2870 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2871 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2873 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2875 Fix typo that broke non-Windows builds.
2876 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2878 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2880 Support building on MS-Windows with libxml2.
2882 * makefile.w32-in (OBJ2): Add xml.$(O).
2883 (GLOBAL_SOURCES): Add xml.c.
2884 ($(BLD)/xml.$(O)): New dependency list.
2886 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2887 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2888 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2889 [!WINDOWSNT]: New macros.
2890 (init_libxml2_functions, libxml2_loaded_p): New functions.
2891 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2892 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2893 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2894 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2896 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2897 Call init_libxml2_functions before calling libxml2 functions.
2898 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2900 * emacs.c: Don't include libxml/parser.h.
2901 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2902 xmlCleanupParser directly.
2904 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2906 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2908 * indent.c (Fvertical_motion): If there is a display string at
2909 point, use it.vpos to compute how many lines to backtrack after
2910 move_it_to point. (Bug#11133)
2912 2012-04-06 Eli Zaretskii <eliz@gnu.org>
2914 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2915 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2916 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2917 macros related to unification of CJK characters. For the details,
2918 see the discussion following the message here:
2919 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2921 2012-04-04 Chong Yidong <cyd@gnu.org>
2923 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2925 2012-04-01 Eli Zaretskii <eliz@gnu.org>
2927 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2928 instead of alloca. (Bug#11138)
2930 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2932 * w32menu.c (is_simple_dialog): Properly check lisp types.
2935 2012-03-31 Eli Zaretskii <eliz@gnu.org>
2937 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2938 position we get to after a call to move_it_to fails the
2939 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2940 only if we wind up in a string from display property. (Bug#11063)
2942 * window.c (Fdelete_other_windows_internal): Invalidate the row
2943 and column information about mouse highlight, so that redisplay
2944 restores it after reallocating the glyph matrices. (Bug#7464)
2946 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2947 string comes from a `display' text property, use the buffer
2948 position of that property as if we actually saw that position in
2950 (move_it_by_lines): Remove the assertion that
2951 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2952 violated when there's a before-string at the beginning of a line.
2955 2012-03-30 Eli Zaretskii <eliz@gnu.org>
2957 * xdisp.c (append_space_for_newline): If the default face was
2958 remapped, use the remapped face for the appended newline.
2959 (extend_face_to_end_of_line): Use the remapped default face for
2960 extending the face to the end of the line.
2961 (display_line): Call extend_face_to_end_of_line when the default
2962 face was remapped. (Bug#11068)
2964 2012-03-29 Eli Zaretskii <eliz@gnu.org>
2966 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2968 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2970 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2972 2012-03-27 Glenn Morris <rgm@gnu.org>
2974 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2977 2012-03-26 Kenichi Handa <handa@m17n.org>
2979 * dispextern.h (struct glyph): Fix previous change. Change the
2980 bit length of glyphless.ch to 25 (Bug#11082).
2982 2012-03-26 Chong Yidong <cyd@gnu.org>
2984 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2985 (command_loop_1): Use it; inhibit selection update for
2986 handle-select-window too (Bug#8996).
2988 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2990 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
2992 2012-03-25 Kenichi Handa <handa@m17n.org>
2994 * dispextern.h (struct glyph): Change the bit length of
2995 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2997 2012-03-24 Eli Zaretskii <eliz@gnu.org>
2999 * s/ms-w32.h (tzname): Include time.h before redirecting to
3000 _tzname. Fixes the MSVC build. (Bug#9960)
3002 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3004 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3007 * xterm.c (XTread_socket): Only modify handling_signal if
3008 !SYNC_INPUT. (Bug#11080)
3010 2012-03-23 Eli Zaretskii <eliz@gnu.org>
3012 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3013 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3014 when fetching a multibyte character consumes more bytes than
3015 CHAR_BYTES returns, due to unification of CJK characters in
3016 string_char. (Bug#11073)
3018 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3020 * process.c (wait_reading_process_output): Handle pty disconnect
3021 by refraining from sending oneself a SIGCHLD (bug#10933).
3023 2012-03-22 Chong Yidong <cyd@gnu.org>
3025 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3027 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
3028 Mark string as coming from a prefix property.
3029 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3030 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3032 2012-03-21 Chong Yidong <cyd@gnu.org>
3034 * xfaces.c (Vface_remapping_alist): Doc fix.
3036 2012-03-20 Eli Zaretskii <eliz@gnu.org>
3038 * w32proc.c (Fw32_set_console_codepage)
3039 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3042 2012-03-20 Chong Yidong <cyd@gnu.org>
3044 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3045 to reflect default non-nil value of redisplay-dont-pause.
3047 2012-03-19 Kenichi Handa <handa@m17n.org>
3049 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3050 it fit in a valid range (Bug#11003).
3052 2012-03-18 Eli Zaretskii <eliz@gnu.org>
3054 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3055 that is not from display property, accept the row as a "cursor
3056 row" if one of the string's character has a non-nil `cursor'
3057 property. Fixes cursor positioning when there are newlines in
3058 overlay strings, e.g. in icomplete.el. (Bug#11035)
3060 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3062 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3064 2012-03-12 Chong Yidong <cyd@gnu.org>
3066 * eval.c (inhibit_lisp_code): Rename from
3067 inhibit_window_configuration_change_hook; move from window.c.
3069 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3070 * window.c (run_window_configuration_change_hook)
3071 (syms_of_window): Callers changed.
3073 2012-03-11 Chong Yidong <cyd@gnu.org>
3075 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3077 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3079 2012-03-10 Chong Yidong <cyd@gnu.org>
3081 * frame.c (other_visible_frames): Don't assume the selected frame
3082 is visible (Bug#10955).
3084 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3086 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3088 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3090 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3091 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3094 2012-03-03 Glenn Morris <rgm@gnu.org>
3096 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
3098 2012-03-02 Eli Zaretskii <eliz@gnu.org>
3100 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3101 position past the first glyph_row that ends at ZV. (Bug#10902)
3102 (redisplay_window, next_element_from_string): Fix typos in
3104 (redisplay_window): Pass to move_it_vertically the margin in
3105 pixels, not in screen lines.
3107 2012-03-02 Glenn Morris <rgm@gnu.org>
3109 * buffer.c (buffer-list-update-hook): Doc fix.
3111 2012-02-29 Eli Zaretskii <eliz@gnu.org>
3113 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3114 push_it before setting up the iterator for the first overlay
3115 string, even if we have an empty string loaded.
3116 (next_overlay_string): If there's an empty string on the iterator
3117 stack, pop the stack. (Bug#10903)
3119 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3121 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3122 Suggested by Stefan Monnier in
3123 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3124 * alloc.c (widen_to_Lisp_Object): New static function.
3125 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3126 and widening them to Lisp_Objects. This would work even if
3127 USE_LSB_TAG is defined and wide integers are used, which might
3128 happen in a future version of Emacs.
3130 2012-02-25 Chong Yidong <cyd@gnu.org>
3132 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3135 * xselect.c (Fx_selection_exists_p): Doc fix.
3136 (x_clipboard_manager_save_all): Print an informative message
3137 before saving to clipboard manager.
3139 2012-02-24 Chong Yidong <cyd@gnu.org>
3141 * keyboard.c (process_special_events): Handle all X selection
3142 requests in kbd_buffer, not just the next one (Bug#8869).
3144 2012-02-23 Chong Yidong <cyd@gnu.org>
3146 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3147 call when setting menu-bar-lines and tool-bar-lines parameters.
3148 (unwind_create_frame_1): New helper function.
3150 * window.c (inhibit_window_configuration_change_hook): New var.
3151 (run_window_configuration_change_hook): Obey it.
3152 (syms_of_window): Initialize it.
3154 2012-02-22 Chong Yidong <cyd@gnu.org>
3156 * xterm.c (x_draw_image_relief): Add missing type check for
3157 Vtool_bar_button_margin (Bug#10743).
3159 2012-02-21 Chong Yidong <cyd@gnu.org>
3161 * fileio.c (Vfile_name_handler_alist): Doc fix.
3163 * buffer.c (Fget_file_buffer): Protect against invalid file
3164 handler return value.
3166 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3168 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3169 when computing $valmask.
3171 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3172 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3173 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3174 It's useless in that case, and it can cause problems on hosts
3175 that allocate halves of EMACS_INT values separately.
3176 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3177 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3178 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3179 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3180 it avoids undefined behavior on hosts where shifting right by more
3181 than the word width has undefined behavior.
3183 2012-02-19 Chong Yidong <cyd@gnu.org>
3185 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3186 (Funhandled_file_name_directory, Ffile_name_as_directory)
3187 (Fdirectory_file_name, Fexpand_file_name)
3188 (Fsubstitute_in_file_name): Protect against invalid file handler
3189 return values (Bug#10845).
3191 2012-02-18 Eli Zaretskii <eliz@gnu.org>
3193 * .gdbinit (pitx): Fix incorrect references to fields of the
3196 2012-02-17 Chong Yidong <cyd@gnu.org>
3198 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3200 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3202 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3203 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3205 2012-02-15 Chong Yidong <cyd@gnu.org>
3207 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3208 marked as special. Also, starting docstrings with * is obsolete.
3210 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3212 * gnutls.c (emacs_gnutls_write): Fix last change.
3214 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3216 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3219 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3221 * keymap.c (Fsingle_key_description): Handle char ranges.
3223 2012-02-12 Chong Yidong <cyd@gnu.org>
3225 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3226 as that creates a dangerous corner case.
3228 * window.c (Fdelete_window_internal): Invalidate the mouse
3229 highlight (Bug#9904).
3231 2012-02-12 Glenn Morris <rgm@gnu.org>
3233 * xselect.c (Fx_own_selection_internal)
3234 (Fx_get_selection_internal, Fx_disown_selection_internal)
3235 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3236 * nsselect.m (Fx_own_selection_internal)
3237 (Fx_disown_selection_internal, Fx_selection_exists_p)
3238 (Fx_selection_owner_p, Fx_get_selection_internal):
3239 Sync docs and argument specs with the xselect.c versions.
3241 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3243 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3245 2012-02-11 Eli Zaretskii <eliz@gnu.org>
3247 * w32select.c (Fx_selection_exists_p): Sync doc string and
3248 argument list with xselect.c. (Bug#10783)
3250 * w16select.c (Fx_selection_exists_p): Sync doc string and
3251 argument list with xselect.c. (Bug#10783)
3253 2012-02-10 Glenn Morris <rgm@gnu.org>
3255 * fns.c (Fsecure_hash): Doc fix.
3257 2012-02-09 Kenichi Handa <handa@m17n.org>
3259 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3261 2012-02-07 Chong Yidong <cyd@gnu.org>
3263 * buffer.c (Fbuffer_local_variables)
3264 (buffer_lisp_local_variables): Handle unbound vars correctly;
3265 don't let Qunbound leak into Lisp.
3267 2012-02-07 Glenn Morris <rgm@gnu.org>
3269 * image.c (Fimagemagick_types): Doc fix.
3271 * image.c (imagemagick-render-type): Change it from a lisp object
3272 to an integer. Move the doc here from the lisp manual.
3273 Treat all values not equal to 0 the same.
3275 2012-02-06 Chong Yidong <cyd@gnu.org>
3277 * doc.c (store_function_docstring): Avoid applying docstring of
3278 alias to base function (Bug#2603).
3280 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3282 * .gdbinit (pp1, pv1): Remove redundant defines.
3285 2012-02-04 Chong Yidong <cyd@gnu.org>
3287 * nsterm.m: Declare a global (Bug#10694).
3289 2012-02-04 Eli Zaretskii <eliz@gnu.org>
3291 * w32.c (get_emacs_configuration_options):
3292 Include --enable-checking, if specified, in the return value.
3294 2012-02-04 Martin Rudalics <rudalics@gmx.at>
3296 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3297 after rounding frame sizes. (Bug#9723)
3299 2012-02-04 Eli Zaretskii <eliz@gnu.org>
3301 * keyboard.c (adjust_point_for_property): Don't position point
3302 before BEGV. (Bug#10696)
3304 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3306 Handle overflow when computing char display width (Bug#9496).
3307 * character.c (char_width): Return EMACS_INT, not int.
3308 (char_width, c_string_width): Check for overflow when
3309 computing the width; this is possible now that individual
3310 characters can have unbounded width. Problem introduced
3311 by merge from Emacs 23 on 2012-01-19.
3313 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
3315 * dbusbind.c (Fdbus_register_method): Mention the return value
3316 :ignore in the docstring.
3318 2012-02-02 Glenn Morris <rgm@gnu.org>
3320 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3322 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3323 Unconditionally set to t. (Bug#10673)
3324 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3325 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3326 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3328 2012-02-02 Kenichi Handa <handa@m17n.org>
3330 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3331 0, do not call append_composite_glyph.
3333 2012-02-02 Kenichi Handa <handa@m17n.org>
3335 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3337 (x_produce_glyphs): If the component of a composition is a null
3338 string, set it->pixel_width to 1 to avoid zero-width glyph.
3340 2012-02-01 Eli Zaretskii <eliz@gnu.org>
3342 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3343 first 2 arguments are identical. This makes inserting large
3344 output from a subprocess an order of magnitude faster on
3345 MS-Windows, where all sbrk'ed memory is always contiguous.
3347 2012-01-31 Glenn Morris <rgm@gnu.org>
3349 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3350 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3351 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3353 2012-01-29 Glenn Morris <rgm@gnu.org>
3355 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3357 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3359 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3361 2012-01-28 Chong Yidong <cyd@gnu.org>
3363 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3365 2012-01-26 Chong Yidong <cyd@gnu.org>
3367 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3369 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3370 repeat counts (Bug#10507).
3372 2012-01-26 Glenn Morris <rgm@gnu.org>
3374 * lread.c (syms_of_lread): Doc fix.
3376 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3378 * coding.c (encode_designation_at_bol): Change return value to
3381 2012-01-25 Chong Yidong <cyd@gnu.org>
3383 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3385 2012-01-21 Chong Yidong <cyd@gnu.org>
3387 * floatfns.c (Fcopysign): Make the second argument non-optional,
3388 since nil is not allowed anyway.
3390 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3392 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3393 (send_process): Likewise.
3395 2012-01-19 Martin Rudalics <rudalics@gmx.at>
3397 * window.c (save_window_save, Fcurrent_window_configuration)
3398 (Vwindow_persistent_parameters): Do not use Qstate.
3399 Rewrite doc-strings.
3401 2012-01-19 Kenichi Handa <handa@m17n.org>
3403 * character.c (char_width): New function.
3404 (Fchar_width, c_string_width, lisp_string_width):
3405 Use char_width (Bug#9496).
3407 2012-01-16 Martin Rudalics <rudalics@gmx.at>
3409 * window.c (Vwindow_persistent_parameters): New variable.
3410 (Fset_window_configuration, save_window_save): Handle persistent
3413 2012-01-14 Eli Zaretskii <eliz@gnu.org>
3415 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3416 thrashing the stack of the thread. (Bug#9087)
3418 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3420 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3422 2012-01-11 Eli Zaretskii <eliz@gnu.org>
3424 * xdisp.c (rows_from_pos_range): Handle the case where the
3425 highlight ends on a newline. (Bug#10464)
3426 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3427 he end column for display of highlight that ends on a newline
3430 2012-01-11 Glenn Morris <rgm@gnu.org>
3432 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3433 from load-path also when installation-directory is nil. (Bug#10208)
3435 2012-01-10 Glenn Morris <rgm@gnu.org>
3437 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3439 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3440 Update template values to be closer to their typical values these days.
3442 2012-01-09 Eli Zaretskii <eliz@gnu.org>
3444 * xdisp.c (rows_from_pos_range): Accept additional argument
3445 DISP_STRING, and accept any glyph in a row whose object is that
3446 string as eligible for mouse highlight. Fixes mouse highlight of
3447 display strings from overlays. (Bug#10464)
3449 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
3451 emacs: fix an auto-save permissions race condition (Bug#10400)
3452 * fileio.c (auto_saving_dir_umask): New static var.
3453 (Fmake_directory_internal): Use it.
3454 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3455 creating the directory. The old code temporarily assigns
3456 too-generous permissions to the directory.
3457 (do_auto_save_eh): Clear it.
3458 (Fdo_auto_save): Catch all errors, not just file errors, so
3459 that the var is always cleared.
3461 2012-01-07 Eli Zaretskii <eliz@gnu.org>
3463 * search.c (scan_buffer): Pass character positions to
3464 know_region_cache, not byte positions. (Bug#6540)
3466 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
3468 * w32.c (sys_rename): Report EXDEV when rename of a directory
3469 fails because the target is on another logical disk. (Bug#10284)
3471 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3473 * xterm.c (x_embed_request_focus): New function.
3475 * xterm.h: Add prototype.
3477 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3479 2012-01-05 Glenn Morris <rgm@gnu.org>
3481 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3483 2012-01-01 Eli Zaretskii <eliz@gnu.org>
3485 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3486 Load gnutls_transport_set_lowat only if GnuTLS version is below
3488 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3489 GnuTLS versions below 2.11.1.
3491 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3493 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3494 to the doc string advising against its use for altering the way
3495 windows are scrolled.
3497 2011-12-28 Kenichi Handa <handa@m17n.org>
3499 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3500 coding-system ASCII compatible only when it does not produce BOM
3501 on encoding (Bug#10383).
3503 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3505 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3507 (create_and_show_popup_menu): Always use menu_position_func for
3510 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3512 * callint.c (Fcall_interactively): Don't truncate prompt string.
3514 2011-12-23 Eli Zaretskii <eliz@gnu.org>
3516 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3517 property that ends at ZV, so that the bidi iteration could be
3518 resumed from there (after widening). (Bug#10360)
3520 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3522 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3524 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3526 * nsterm.m (x_free_frame_resources):
3527 Release f->output_data.ns->miniimage.
3528 (ns_index_color): Fix indentation. Do not retain
3529 color_table->colors[i].
3531 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3534 * nsfns.m (x_set_background_color): Assign return value from
3535 ns_index_color to face-background instead of NSColor*.
3536 (ns_implicitly_set_icon_type): Fix indentation.
3537 Change assignment in for loop to comparison.
3539 * emacs.c (ns_pool): New variable.
3540 (main): Assign ns_pool.
3541 (Fkill_emacs): Call ns_release_autorelease_pool.
3543 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3544 autorelease fdesc, release fdAttrs and tdict.
3545 (ns_get_covering_families): Release charset.
3546 (ns_findfonts): Release NSFontDescriptor created with new.
3547 (ns_uni_to_glyphs): Fix indentation.
3548 (setString): Release attrStr before assigning new value.
3550 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3552 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3554 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3555 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3557 2011-12-18 David Reitter <reitter@cmu.edu>
3559 * nsterm.m (ns_term_init): Subscribe for notifications
3560 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3561 to method trackingNotification in EmacsMenu.
3563 * nsmenu.m (trackingMenu): New variable.
3564 (trackingNotification): New method (from Aquamacs).
3565 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3566 from Aquamacs (Bug#7030).
3568 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3570 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3571 (symbol_to_nsstring): Fix indentation.
3572 (ns_symbol_to_pb): New function.
3573 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3574 (Fns_rotate_cut_buffers_internal): Remove.
3575 (Fns_store_selection_internal): Rename from
3576 Fns_store_cut_buffer_internal.
3577 (ns_get_foreign_selection, Fx_own_selection_internal)
3578 (Fx_disown_selection_internal, Fx_selection_exists_p)
3579 (Fns_get_selection_internal, Fns_store_selection_internal):
3580 Use ns_symbol_to_pb and check if return value is nil.
3581 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3582 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
3583 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3584 renamed to Sns_store_selection_internal.
3585 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3586 and remove this function.
3587 (ns_handle_selection_clear): Remove, never used.
3588 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3591 2011-12-17 Ken Brown <kbrown@cornell.edu>
3593 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3594 GID is unknown (Bug#10257).
3596 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3598 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3599 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3600 which caused a build failure on GNU/Linux IA-64. This problem was
3601 introduced by my 2011-10-07 patch.
3603 2011-12-15 Juri Linkov <juri@jurta.org>
3605 * image.c (imagemagick_error): New function. (Bug#10112)
3606 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3607 Use `imagemagick_error' where ImageMagick functions return
3609 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3612 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3614 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3615 fill background (Bug#8992).
3617 2011-12-13 Martin Rudalics <rudalics@gmx.at>
3619 * window.c (Vwindow_combination_resize)
3620 (Vwindow_combination_limit): Use t instead of non-nil in
3622 (Vrecenter_redisplay): Add first sentence of doc-string on
3624 (Frecenter): Fix doc-string typo.
3626 2011-12-11 Kenichi Handa <handa@m17n.org>
3628 * coding.c (Funencodable_char_position): Pay attention to the
3629 buffer text relocation (Bug#9389).
3631 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3633 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3634 gtk_init (Bug#10100).
3636 2011-12-10 Eli Zaretskii <eliz@gnu.org>
3638 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3639 IT->string is nil. (Bug#10263)
3641 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3643 * nsterm.h (x_free_frame_resources): Declare.
3645 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3646 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3648 * nsterm.h (ns_get_defaults_value): Declare.
3650 * nsterm.m (ns_default): Call ns_get_defaults_value.
3652 2011-12-09 Eli Zaretskii <eliz@gnu.org>
3654 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3657 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3659 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3660 that where the value of an _OBJC_* symbol points to is in the .bss
3661 section (Bug#10240).
3663 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3665 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
3666 after the loop to call ccl_driver at least once (Bug#8619).
3668 2011-12-08 Kenichi Handa <handa@m17n.org>
3670 * ftfont.c (get_adstyle_property): Fix previous change
3673 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
3675 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3676 dirs from the default value of EMACSLOADPATH (bug#10208).
3678 2011-12-07 Glenn Morris <rgm@gnu.org>
3680 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3681 installation and source directories as well. (Bug#10208)
3683 2011-12-06 Chong Yidong <cyd@gnu.org>
3685 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3687 2011-12-06 Glenn Morris <rgm@gnu.org>
3689 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3690 as an error, not just -1. (Bug#10217)
3692 2011-12-05 Chong Yidong <cyd@gnu.org>
3694 * keyboard.c (process_special_events): New function.
3695 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3697 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3699 * coding.c (encode_designation_at_bol): Don't use uninitialized
3700 local variable (Bug#9318).
3702 2011-12-05 Kenichi Handa <handa@m17n.org>
3704 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3705 return Qnil (Bug#8046, Bug#10193).
3707 2011-12-05 Kenichi Handa <handa@m17n.org>
3709 * coding.c (encode_designation_at_bol): New args charbuf_end and
3710 dst. Return the number of produced bytes. Callers changed.
3711 (coding_set_source): Return how many bytes coding->source was
3713 (coding_set_destination): Return how many bytes
3714 coding->destination was relocated.
3715 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
3716 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
3718 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3720 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3721 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3724 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3726 The following changes are to fix Bug#9318.
3728 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
3729 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3730 (encode_coding_iso_2022, encode_coding_sjis)
3731 (encode_coding_big5, encode_coding_charset): Use the above macros.
3733 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
3735 * lisp.h (process_quit_flag): Fix external declaration.
3737 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3739 Don't macro-inline non-performance-critical code.
3740 * eval.c (process_quit_flag): New function.
3741 * lisp.h (QUIT): Use it.
3743 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3745 * nsfns.m (get_geometry_from_preferences): New function.
3746 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3748 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3750 * emacs.c (Qkill_emacs): Define.
3751 (syms_of_emacs): Initialize it.
3752 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3753 Qquit_flag to `kill-emacs' instead.
3754 (quit_throw_to_read_char): Add parameter `from_signal'.
3755 All callers changed. Call Fkill_emacs if requested and safe.
3756 * lisp.h (QUIT): Call Fkill_emacs if requested.
3758 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3760 * widget.c (update_wm_hints): Return if wmshell is null.
3761 (widget_update_wm_size_hints): New function.
3763 * widget.h (widget_update_wm_size_hints): Declare.
3765 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3766 widget_update_wm_size_hints (Bug#10104).
3768 2011-12-03 Eli Zaretskii <eliz@gnu.org>
3770 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3771 before a newline, prepare the bidi iterator for consuming the
3772 newline, and keep the current paragraph direction. (Bug#10183)
3773 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
3775 2011-12-02 Juri Linkov <juri@jurta.org>
3777 * search.c (Fword_search_regexp): New Lisp function created from
3778 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3779 (Fword_search_backward, Fword_search_forward)
3780 (Fword_search_backward_lax, Fword_search_forward_lax):
3781 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3782 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3784 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3786 * fileio.c (Finsert_file_contents): Move after-change-function call
3787 to before the "handled:" label, since all "goto handled" appear in
3788 cases where the *-change-functions have already been properly called
3791 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3793 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3794 waiting for input. (Bug#10169)
3796 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3798 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3799 verifies glyph row's hash code--we have just reallocated the
3800 glyphs, so their contents can be complete garbage. (Bug#10164)
3802 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
3804 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3806 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3808 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3809 attributes are tested _before_ calling verify_row_hash, to protect
3810 against GCC re-ordering of the tests. (Bug#10164)
3812 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3814 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3816 * xterm.c (handle_one_xevent): Only set async_visible and friends
3817 if net_wm_state_hidden_seen is non-zero (Bug#10002)
3818 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
3819 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3821 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3823 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3824 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3825 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3826 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3827 All uses changed to use GCPRO1 etc.
3828 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3829 Revert to old implementation (i.e., before 2011-03-11).
3831 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3833 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3834 of scroll runs so as to avoid assigning disabled bogus rows and
3835 unnecessary graphics copy operations.
3837 2011-11-27 Eli Zaretskii <eliz@gnu.org>
3839 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3840 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3841 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3842 (malloc, free, realloc, calloc): Redirect to e_* only when
3845 * lisp.h (GCTYPEBITS): Move before first use.
3846 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3847 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3848 this macro definition.
3850 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3853 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3855 * gtkutil.c (xg_create_frame_widgets):
3856 Call gtk_window_set_has_resize_grip (FALSE) if that function is
3857 present with Gtk+ 2.0.
3859 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3861 * fileio.c (Finsert_file_contents): Undo previous change; see
3862 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3864 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3866 Rename locals to avoid shadowing.
3867 * fileio.c (Finsert_file_contents):
3868 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3869 * process.c (wait_reading_process_output):
3870 Rename inner 'proc' to 'p' to avoid shadowing.
3871 Indent for consistency with usual Emacs style.
3873 2011-11-25 Eli Zaretskii <eliz@gnu.org>
3875 * xdisp.c (redisplay_window): If cursor row is not fully visible
3876 after recentering, and scroll-conservatively is set to a large
3877 number, scroll window by a few more lines to make the cursor fully
3878 visible and out of scroll-margin. (Bug#10105)
3879 (start_display): Don't move to the next line if the display should
3880 start at a newline that is part of a display vector or an overlay
3883 2011-11-24 Juri Linkov <juri@jurta.org>
3885 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3886 after the `MagickPingImage' call. (Bug#10112)
3888 2011-11-23 Chong Yidong <cyd@gnu.org>
3890 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3892 2011-11-23 Martin Rudalics <rudalics@gmx.at>
3894 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3895 making another buffer current. (Bug#10114)
3897 2011-11-23 Glenn Morris <rgm@gnu.org>
3899 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3901 2011-11-23 Chong Yidong <cyd@gnu.org>
3903 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3904 using it (Bug#5984).
3906 2011-11-22 Eli Zaretskii <eliz@gnu.org>
3908 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3909 and header-lines, as they don't have one computed for them.
3912 * .gdbinit (prow): Make displayed values more self-explaining.
3913 Add row's hash code.
3915 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3917 * process.c (wait_reading_process_output): Fix asynchrounous
3918 GnuTLS socket handling on some versions of the GnuTLS library.
3919 (wait_reading_process_output): Add comment and URL.
3921 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3923 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3925 2011-11-21 Chong Yidong <cyd@gnu.org>
3927 * window.c (Fnext_window, Fprevious_window): Doc fix.
3929 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3931 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3933 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3935 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3937 2011-11-20 Martin Rudalics <rudalics@gmx.at>
3939 * window.c (Fset_window_combination_limit): Rename argument
3941 (Vwindow_combination_limit): Remove "status" from doc-string.
3943 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3945 * m/ibms390.h: Remove.
3946 * m/ibms390x.h: Don't include "ibms390.h".
3948 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3950 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3951 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3953 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3955 * casetab.c (Fset_case_table):
3956 * charset.c (Fcharset_after): Fix typos.
3958 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
3960 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3961 Otherwise, valgrind does not work on some platforms.
3962 Problem reported by Andreas Schwab in
3963 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3964 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3965 is set, removing the need for VIRT_ADDRESS_VARIES.
3966 (PURE_P): Use a more-efficient implementation that needs just one
3967 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3968 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3969 to 4 (xorl, subq, cmpq, setbe).
3970 * alloc.c (pure): Always extern now, since that's the
3971 VIRT_ADDR_VARIES behavior.
3972 (PURE_POINTER_P): Use a single comparison, not two, for
3973 consistency with the new puresize.h.
3974 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3975 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3976 Remove VIRT_ADDR_VARIES no longer needed.
3978 2011-11-19 Eli Zaretskii <eliz@gnu.org>
3980 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3981 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3982 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3983 behave as if the cursor position were at the window margin.
3985 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3986 and the cursor position is out of bounds, behave as if the cursor
3987 position were at the window margin. (Bug#10075)
3989 2011-11-18 Chong Yidong <cyd@gnu.org>
3991 * window.c (Fwindow_combination_limit): Make first argument
3992 non-optional, since it is meaningless for live windows like the
3995 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3997 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3999 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4001 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4002 (graft_intervals_into_buffer): Simplify.
4004 2011-11-18 Eli Zaretskii <eliz@gnu.org>
4006 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4007 hash values of the two rows.
4008 (copy_row_except_pointers): Preserve the used[] arrays and the
4009 hash values of the two rows. (Bug#10035)
4010 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
4012 * xdisp.c (row_hash): New function, body extracted from
4013 compute_line_metrics.
4014 (compute_line_metrics): Call row_hash, instead of computing the
4017 * dispnew.c (verify_row_hash): Call row_hash for computing the
4018 hash code of a row, instead of duplicating code from xdisp.c.
4020 * dispextern.h (row_hash): Add prototype.
4022 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4024 * frame.c (delete_frame): Don't delete the terminal when the last
4025 X frame is closed if emacs is built with GTK toolkit.
4027 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
4029 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4031 2011-11-17 Martin Rudalics <rudalics@gmx.at>
4033 * window.c (Vwindow_splits): Rename to
4034 Vwindow_combination_resize. Suggested by Juri Linkov.
4035 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4038 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
4040 * nsfns.m (Fns_font_name):
4041 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
4043 2011-11-16 Martin Rudalics <rudalics@gmx.at>
4045 * window.h (window): Rename slot "nest" to "combination_limit".
4046 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4047 (Fset_window_nest): Rename to Fset_window_combination_limit.
4048 (Vwindow_nest): Rename to Vwindow_combination_limit.
4049 (recombine_windows, make_parent_window, make_window)
4050 (Fsplit_window_internal, saved_window)
4051 (Fset_window_configuration, save_window_save): Rename all
4052 occurrences of window_nest to window_combination_limit.
4054 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
4056 * image.c (imagemagick_load_image): Fix typo.
4058 2011-11-14 Eli Zaretskii <eliz@gnu.org>
4060 * xdisp.c (display_line): Move the call to
4061 highlight_trailing_whitespace before the call to
4062 compute_line_metrics, since the latter needs to see the final
4063 faces of all the glyphs to compute ROW's hash value.
4064 Fixes assertion violations in row_equal_p. (Bug#10035)
4066 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
4068 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4069 just return (bug#10044).
4071 2011-11-12 Eli Zaretskii <eliz@gnu.org>
4073 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4074 with user-defined heap size. Bump the default size of the temacs
4075 heap to 27MB, to avoid memory warning when running temacs.
4076 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4078 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4079 current_matrix and desired_matrix. (Bug#9990)
4080 (verify_row_hash) [XASSERTS]: New function.
4081 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4082 that the hash value of glyph rows is correct.
4084 2011-11-12 Martin Rudalics <rudalics@gmx.at>
4086 * window.h (window): Remove splits slot.
4087 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4088 (Fdelete_other_windows_internal, make_parent_window)
4089 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4090 (Fset_window_configuration, save_window_save): Don't deal with
4091 split status of windows.
4092 (saved_window): Remove splits slot.
4093 (Vwindow_splits): Rewrite doc-string.
4095 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4097 * xfns.c (unwind_create_frame):
4098 * nsfns.m (unwind_create_frame):
4099 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4100 Vframe_list (Bug#9999).
4102 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4104 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
4106 2011-11-11 Kenichi Handa <handa@m17n.org>
4108 * callproc.c (Fcall_process): Set the member dst_multibyte of
4111 2011-11-11 Johan Bockgård <bojohan@gnu.org>
4113 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4114 avoid a crash (bug#9496).
4116 2011-11-09 Chong Yidong <cyd@gnu.org>
4118 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4119 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4121 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4123 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4125 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4127 Avoid some portability problems by eschewing 'extern inline' functions.
4128 The trivial performance wins aren't worth the portability hassles; see
4129 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4131 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4132 (window_box_width, window_box_left, window_box_left_offset)
4133 (window_box_right, window_box_right_offset): Undo previous change,
4134 by removing the "extern"s.
4135 * intervals.c (adjust_intervals_for_insertion)
4136 (adjust_intervals_for_deletion): Undo previous change,
4137 making these static again.
4138 (offset_intervals, temp_set_point_both, temp_set_point)
4139 (copy_intervals_to_string): No longer inline.
4140 * xdisp.c (window_text_bottom_y, window_box_width)
4141 (window_box_height, window_box_left_offset)
4142 (window_box_right_offset, window_box_left, window_box_right)
4143 (window_box): No longer inline.
4145 2011-11-08 Chong Yidong <cyd@gnu.org>
4147 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
4148 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4149 Signal an error if not a live window.
4150 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4151 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4153 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
4155 * lisp.h (syms_of_abbrev): Remove declaration.
4156 Reported by CHENG Gao <chenggao@royau.me>.
4158 2011-11-07 Eli Zaretskii <eliz@gnu.org>
4160 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4161 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4162 of temacs in GUI mode.
4164 2011-11-07 Martin Rudalics <rudalics@gmx.at>
4166 * window.h: Declare delete_all_child_windows instead of
4167 delete_all_subwindows.
4168 * window.c (Fwindow_nest, Fset_window_nest)
4169 (Fset_window_new_total, Fset_window_new_normal)
4170 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4171 (delete_all_subwindows): Rename to delete_all_child_windows.
4172 (Fdelete_other_windows_internal, Fset_window_configuration):
4173 Call delete_all_child_windows instead of delete_all_subwindows.
4174 * frame.c (delete_frame): Call delete_all_child_windows instead
4175 of delete_all_subwindows.
4177 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4179 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4180 This is also needed for porting to any host where GC_MARK_STACK is
4181 not GC_MAKE_GCPROS_NOOPS.
4182 (which_symbols): Use it.
4184 2011-11-07 Kenichi Handa <handa@m17n.org>
4186 * coding.c (coding_set_destination): Check coding->src_pos only
4187 when coding->src_object is a buffer (bug#9910).
4189 * process.c (send_process): Set the member src_multibyte of coding
4190 to 0 (bug#9911) when sending a unibyte text.
4192 * callproc.c (Fcall_process): Set the member src_multibyte of
4193 process_coding to 0 (bug#9912).
4195 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4197 * xmenu.c (cleanup_widget_value_tree): New function.
4198 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4199 calling free_menubar_widget_value_tree directly (Bug#9830).
4201 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4203 Fix some portability problems with 'inline'.
4204 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4205 (window_box_width, window_box_left, window_box_left_offset)
4206 (window_box_right, window_box_right_offset): Declare extern.
4207 Otherwise, these inline functions do not conform to C99 and
4208 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4209 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4210 * intervals.c (adjust_intervals_for_insertion)
4211 (adjust_intervals_for_deletion): Now extern, because otherwise the
4212 extern inline functions 'offset_intervals' couldn't refer to it.
4213 (static_offset_intervals): Remove.
4214 (offset_intervals): Rewrite using the old contents of
4215 static_offset_intervals. The old version didn't conform to C99
4216 because an extern inline function contained a reference to an
4217 identifier with static linkage.
4219 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4221 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4224 2011-11-06 Eli Zaretskii <eliz@gnu.org>
4226 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4227 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4228 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4229 return Qleft_to_right.
4231 2011-11-06 Chong Yidong <cyd@gnu.org>
4233 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4234 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4235 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4236 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4237 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4238 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4239 (Fwindow_vscroll): Doc fix.
4240 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4241 argument, since it makes no sense to pass a live window and for
4242 consistency with window-child.
4244 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4246 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4249 2011-11-05 Jason Rumney <jasonr@gnu.org>
4251 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4252 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4254 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4255 bitwise arithmetic preventing use of unicode-sip and non-truetype
4258 2011-11-05 Eli Zaretskii <eliz@gnu.org>
4260 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4263 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4264 initialization code to keep similarity to xfns.c after changes
4267 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4269 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4270 (unwind_create_frame): New function (Bug#9943).
4271 (Fx_create_frame): Restructure code to be more similar to the one in
4272 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4273 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4274 Move terminal->reference_count++ just before making the frame official
4277 * nsterm.m (x_free_frame_resources): New function.
4278 (x_destroy_window): Move code to x_free_frame_resources.
4280 * xfns.c (unwind_create_frame): Fix comment.
4281 (Fx_create_frame, x_create_tip_frame):
4282 Move terminal->reference_count++ just before making the frame
4283 official. Move initialization of image_cache_refcount and
4284 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4286 2011-11-05 Eli Zaretskii <eliz@gnu.org>
4288 Support MSVC build with newer versions of Visual Studio.
4289 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4290 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4293 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4294 which are not supported by MSVC.
4295 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4296 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4298 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4300 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4302 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4304 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
4306 Support MSVC build with newer versions of Visual Studio.
4307 * w32.c: Don't include w32api.h for MSVC.
4308 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4310 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4311 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4312 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4313 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4315 (alloca) [_MSC_VER]: Define to _alloca.
4317 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4319 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4321 2011-11-04 Eli Zaretskii <eliz@gnu.org>
4323 * xdisp.c (note_mouse_highlight): If either of
4324 previous/next-single-property-change returns nil, treat that as
4325 the beginning or the end of the buffer. (Bug#9955)
4327 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4329 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
4330 label is not null (Bug#9951).
4331 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4334 2011-11-04 Eli Zaretskii <eliz@gnu.org>
4336 * window.c (Fwindow_body_size): Mention in the doc string that the
4337 return value is in frame's canonical units. (Bug#9949)
4339 2011-11-03 Eli Zaretskii <eliz@gnu.org>
4341 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4343 * w32fns.c (unwind_create_frame): If needed, free the glyph
4344 matrices of the partially constructed frame. (Bug#9943)
4345 * xfns.c (unwind_create_frame): Likewise.
4347 2011-11-01 Eli Zaretskii <eliz@gnu.org>
4349 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4350 Don't stop backward scan on the continuation glyph, even though
4351 its CHARPOS is positive.
4352 (mouse_face_from_buffer_pos, note_mouse_highlight):
4353 Rename cover_string to disp_string.
4355 2011-11-01 Martin Rudalics <rudalics@gmx.at>
4357 * window.c (temp_output_buffer_show): Don't use
4358 Vtemp_buffer_show_specifiers.
4359 (Vtemp_buffer_show_specifiers): Remove unused variable.
4361 2011-10-30 Eli Zaretskii <eliz@gnu.org>
4363 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4364 past the beginning of the current glyph matrix.
4366 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
4368 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4369 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4370 HAVE_GTK3 (Bug#9869).
4372 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4373 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4375 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4377 * xterm.c: Declare x_handle_net_wm_state to return int.
4378 (handle_one_xevent): Check if we are iconified but don't have
4379 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4380 (get_current_wm_state): Return non-zero if not hidden,
4381 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4382 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4383 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4384 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4386 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4388 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4389 so that this new function doesn't get optimized away by a
4390 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4392 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4394 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4396 2011-10-29 Eli Zaretskii <eliz@gnu.org>
4398 Fix the `xbytecode' command.
4399 * .gdbinit (xprintbytestr): New command.
4400 (xwhichsymbols): Rename from `which'; all callers changed.
4401 (xbytecode): Print the byte-code string as well.
4403 2011-10-29 Kim Storm <storm@cua.dk>
4405 * alloc.c (which_symbols): New function.
4407 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4409 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4412 2011-10-29 Glenn Morris <rgm@gnu.org>
4414 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4415 Not clear what it was for, and it causes various bugs. (Bug#9839)
4417 2011-10-28 Eli Zaretskii <eliz@gnu.org>
4419 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4420 possible random value that matches one of those tested as
4421 condition to clear the mouse face.
4423 2011-10-28 Chong Yidong <cyd@gnu.org>
4425 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4427 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4429 * window.c (make_window): Initialize phys_cursor_on_p.
4431 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4433 * lisp.h (struct Lisp_Symbol): Update comments.
4435 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
4437 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4439 2011-10-28 Eli Zaretskii <eliz@gnu.org>
4441 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4442 <oslsachem@gmail.com> for helping to debug this.
4444 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4445 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4446 (g_b_init_get_glyph_outline_w): New static variables.
4447 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4448 (GetGlyphOutlineW_Proc): New typedefs.
4449 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
4450 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4452 (w32font_open_internal, compute_metrics):
4453 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
4454 instead of calling the "wide" APIs directly.
4456 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4458 * w32.h (syms_of_w32font): Add prototype.
4460 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
4462 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4463 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4464 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4465 (Fmove_to_window_line): Doc fix.
4467 2011-10-27 Chong Yidong <cyd@gnu.org>
4469 * process.c (make_process): Set gnutls_state to NULL.
4471 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4472 non-NULL, regardless of GNUTLS_INITSTAGE.
4473 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4474 an error. Set process slots as soon as we allocate them.
4476 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4478 2011-10-27 Chong Yidong <cyd@gnu.org>
4480 * gnutls.c (emacs_gnutls_deinit): New function.
4481 Deallocate credentials structures as well as calling gnutls_deinit.
4482 (Fgnutls_deinit, Fgnutls_boot): Use it.
4484 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4485 (deactivate_process): Call emacs_gnutls_deinit.
4487 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
4489 * image.c (x_create_x_image_and_pixmap):
4490 * w32.c (sys_rename, w32_delayed_load):
4491 * w32font.c (fill_in_logfont):
4492 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4494 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
4496 * w32fns.c (w32_default_color_map): New function,
4497 extracted from Fw32_default_color_map.
4498 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
4500 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4502 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4504 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4506 * keyboard.c (test_undefined): New function (bug#9751).
4507 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4509 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4511 * sysdep.c (init_sys_modes): Fix the check for the controlling
4512 terminal (Bug#6649).
4514 2011-10-20 Eli Zaretskii <eliz@gnu.org>
4516 * dispextern.h (struct bidi_it): New member next_en_type.
4518 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4519 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4520 current character, check also for next_en_type being WEAK_EN.
4521 (bidi_resolve_weak): Don't enter the expensive loop if the current
4522 position is before next_en_pos. Record the bidi type of the first
4523 non-ET, non-BN character we find, in addition to its position.
4524 (bidi_level_of_next_char): Invalidate next_en_type when
4525 next_en_pos is over-stepped.
4527 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4529 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4530 * editfns.c: Rewrite current-time-zone so that it invokes
4531 the equivalent of (format-time-string "%Z") to get the time zone name.
4532 This fixes a bug when the time zone name contains characters that
4533 need converting from the system time locale to Emacs internal format.
4534 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4535 that patch fixed format-time-string to do the conversion, but
4536 I forgot to fix current-time-zone.
4537 (format_time_string): New function, containing most of
4538 what Fformat_time_string used to contain.
4539 (Fformat_time_string): Rewrite in terms of format_time_string.
4540 This doesn't change this function's behavior.
4541 (current-time-zone): Rewrite to use format_time_string.
4542 This fixes the bug reported by Michael Schierl in
4543 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4544 Jason Rumney's 2007-06-07 change worked around this bug, but
4546 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4548 2011-10-19 Eli Zaretskii <eliz@gnu.org>
4550 * xdisp.c (start_display): If the character at POS is displayed
4551 via a display vector, reset IT->current.dpvec_index to zero.
4552 (try_window_reusing_current_matrix): If a line ends in a display
4553 vector or the next line starts in a display vector, continue
4554 redrawing the window even though the character position of
4555 start_row was reached.
4558 2011-10-18 Chong Yidong <cyd@gnu.org>
4560 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4561 with nobreak-char-display too.
4563 2011-10-18 Eli Zaretskii <eliz@gnu.org>
4565 Fix part 3 of bug#9771.
4566 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4567 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4568 non-neutral characters if the current character is a paragraph
4569 separator (a.k.a. Newline). This avoids running the same
4570 expensive loop twice, once when we consume the preceding newline
4571 and the other time when the line actually needs to be displayed.
4572 Avoid the loop when we see neutrals on the base embedding level
4573 following a character whose directionality is the same as the
4574 paragraph's. This avoids running the expensive loop when a line
4575 ends in a long sequence of neutrals, like control characters.
4576 Add assertion against STRONG_AL type. Slightly rearrange code
4577 that determines the type of a neutral given the first non-neutral
4579 (bidi_level_of_next_char): Set next_en_pos to zero when
4580 invalidating its info.
4582 2011-10-17 Eli Zaretskii <eliz@gnu.org>
4584 * xdisp.c (push_display_prop): Determine whether to record string
4585 or buffer position by IT->string, not by IT->method. Allow
4586 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
4587 (move_it_vertically_backward): Don't look for character position
4588 immediately after the newline when in a continuation line.
4591 2011-10-15 Martin Rudalics <rudalics@gmx.at>
4593 * window.c (coordinates_in_window): Rewrite and delabelize
4594 vertical border check. (Bug#5357) (Bug#9618)
4596 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4598 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4599 errors in XSetWindowBorder (bug#9310).
4601 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4603 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4604 avoid crash when xmalloc overrun checking is enabled.
4606 2011-10-13 Eli Zaretskii <eliz@gnu.org>
4608 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4609 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4610 cursor motion with <left> and <right> arrow keys.
4612 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4613 some callers set that themselves.
4615 2011-10-12 Eli Zaretskii <eliz@gnu.org>
4617 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4618 display string and the previous row comes from the same string and
4619 is empty. (Bug#9739) (Bug#9738)
4621 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4623 * doc.c (get_doc_string): Encode file name (bug#9735).
4625 2011-10-12 Eli Zaretskii <eliz@gnu.org>
4627 * bidi.c (bidi_level_of_next_char):
4628 * xdisp.c (get_visually_first_element): Remove old incorrect
4629 comments regarding the Unicode Line Separator character.
4631 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4633 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4635 * alloc.c (Fgc_status): Do not access beyond zombies array
4636 boundary if nzombies > MAX_ZOMBIES.
4637 * alloc.c (dump_zombies): Add missing format specifier.
4639 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4641 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4642 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4644 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4645 Some packages use them to denote characters with modifiers.
4647 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4649 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4650 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4651 matching a pp-number. Rename parameter var to var1.
4653 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4655 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4657 2011-10-08 Glenn Morris <rgm@gnu.org>
4659 * callint.c (Fcall_interactively): Give a more explicit error for the
4660 'c' case with a non-character input. (Bug#8479)
4662 2011-10-08 Eli Zaretskii <eliz@gnu.org>
4664 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4666 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4667 lines that are hscrolled on the left.
4669 * dispnew.c (buffer_posn_from_coords): Account for a possible
4670 presence of header-line. (Bug#4426)
4672 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4674 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4675 Don't advertise functionality which we discourage or doesn't work.
4677 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4679 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4680 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4681 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4682 this makes Emacs dump core during garbage collection on rare
4683 occasions. sizeof is obviously inferior to offsetof here, so
4684 stick with offsetof.
4685 (GC_POINTER_ALIGNMENT): New macro.
4686 (mark_memory): Omit 3rd (offset) arg; caller changed.
4687 Don't assume EMACS_INT alignment is the same as pointer alignment.
4689 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4691 * keyboard.c (read_key_sequence_remapped): New var.
4692 (read_key_sequence): Compute remapping in the right buffer.
4693 (command_loop_1): Use read_key_sequence's remapping directly.
4695 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4697 * dired.c (file_name_completion): Don't expand file name.
4698 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4699 before checking file name handler.
4701 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4702 they've been requested explicitly (bug#9591).
4704 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
4706 * keymap.c (Fsingle_key_description): Use make_specified_string
4707 instead of build_string to build string from push_key_description.
4710 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4712 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4713 This fixes a Y2038 bug on 64-bit hosts.
4714 * buffer.c (reset_buffer):
4715 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4716 (Fclear_buffer_auto_save_failure):
4717 Use 0, not -1, to represent an unset failure time, since time_t
4718 might not be signed.
4720 Remove dependency on glibc malloc internals.
4721 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4722 Move back here from lisp.h, but with their new implementations.
4723 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4724 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4725 * charset.c (charset_table_init): New static var.
4726 (syms_of_charset): Use it instead of xmalloc. This removes a
4727 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4728 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4729 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4730 Move back to alloc.c.
4731 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4732 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4734 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4736 * nsterm.m (windowDidResize): Call x_set_window_size only when
4737 ns_in_resize is true. Otherwise set pixelwidth/height and
4738 call change_frame_size (Bug#9628).
4740 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4742 Port --enable-checking=all to Fedora 14 x86-64.
4743 * charset.c (syms_of_charset): Also account for glibc malloc's
4744 internal overhead when calculating the initial malloc maximum.
4746 Port --enable-checking=all to Fedora 14 x86.
4747 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4749 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4750 (overrun_check_realloc, overrun_check_free):
4751 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4752 That way, xmalloc returns a properly-aligned pointer even if
4753 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4754 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4755 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4756 into account when calculating the initial malloc maximum.
4757 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4758 Move here from alloc.c, so that charset.c can use it too.
4759 Properly align; the old code wasn't right for common 32-bit hosts
4760 when configured with --enable-checking=all.
4761 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4762 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4764 2011-09-29 Eli Zaretskii <eliz@gnu.org>
4766 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
4769 2011-09-28 Eli Zaretskii <eliz@gnu.org>
4771 * xdisp.c (compute_display_string_end): If there's no display
4772 string at CHARPOS, return -1.
4774 * bidi.c (bidi_fetch_char): When compute_display_string_end
4775 returns a negative value, treat the character as a normal
4776 character not covered by a display string. (Bug#9624)
4778 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
4780 * lread.c (Fread_from_string): Fix typo in docstring.
4782 2011-09-27 Eli Zaretskii <eliz@gnu.org>
4784 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4785 newline, reseat the iterator instead of bidi-iterating there one
4786 character at a time. (Bug#9610)
4787 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4788 TO_CHARPOS if the bidi iterator is at base embedding level.
4790 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4792 * lread.c (readevalloop): Use correct code for NBSP.
4793 (read1): Likewise. (Bug#9608)
4795 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
4797 * dbusbind.c (Fdbus_register_signal): When service is not
4798 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4800 2011-09-25 Glenn Morris <rgm@gnu.org>
4802 * buffer.c (truncate-lines): Doc fix.
4804 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
4806 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4807 (Fset_window_next_buffers): Doc fix.
4809 2011-09-24 Glenn Morris <rgm@gnu.org>
4811 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4813 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4815 Fix minor problems found by static checking.
4816 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
4817 * indent.c (Fvertical_motion): Fix == vs = typo.
4819 2011-09-24 Eli Zaretskii <eliz@gnu.org>
4821 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4822 Default value is now t. Doc fix.
4824 * indent.c (Fvertical_motion): Compute and apply the overshoot
4825 logic when moving up, not only when moving down. Fix the
4826 confusing name and values of the it_overshoot_expected variable;
4827 logic changes accordingly. (Bug#9254) (Bug#9549)
4829 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4830 CHARPOS is covered by a display string which includes newlines.
4831 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4832 is covered by a display string with embedded newlines.
4834 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
4836 * dbusbind.c (Fdbus_register_signal): Add match rule to
4837 Vdbus_registered_objects_table. (Bug#9581)
4838 (Fdbus_register_method, Vdbus_registered_objects_table):
4841 2011-09-24 Jim Meyering <meyering@redhat.com>
4843 do not ignore write error for any output size
4844 The previous change was incomplete.
4845 While it makes emacs --batch detect the vast majority of stdout
4846 write failures, errors were still ignored whenever the output size is
4847 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4848 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4849 && echo FAIL: ignored write error
4850 FAIL: ignored write error
4851 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4852 && echo FAIL: ignored write error
4853 FAIL: ignored write error
4854 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4856 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4858 * emacs.c (Fkill_emacs): In noninteractive mode exit
4859 non-successfully if a write error occurred on stdout. (Bug#9574)
4861 2011-09-21 Eli Zaretskii <eliz@gnu.org>
4863 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4866 * dispextern.h (struct it): Update the comment documenting what
4869 2011-09-20 Eli Zaretskii <eliz@gnu.org>
4871 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4872 a display string, extend search for cursor position to end of row.
4873 (find_row_edges): If the row ends in a newline from a display
4874 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4875 Handle the case of a display string with multiple newlines.
4876 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4877 non-empty line. Fixes confusing cursor motion with arrow keys at
4878 the beginning of a line that starts with whitespace.
4880 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4882 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4885 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
4887 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4890 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4892 * xdisp.c (display_line): Record maximum and minimum buffer
4893 positions even if no glyphs were produced (e.g., by a zero-width
4894 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4895 buffer positions that will be removed from the glyph row because
4897 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4898 column is beyond frame width: don't subtract 1 "pixel" when
4899 computing width of the stretch.
4900 (reseat_at_next_visible_line_start): Undo the change made on
4901 2011-09-17 that saved paragraph information and restored it after
4902 the call to `reseat'. (Bug#9545)
4904 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4906 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4907 and turn window cursor on if cleared (Bug#9415).
4909 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
4911 * search.c (boyer_moore): Take unibyte characters from pattern
4912 literally. (Bug#9458)
4914 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4916 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4918 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4920 Fix minor problem found by static checking.
4921 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4922 initialized, to pacify gcc -Wuninitialized.
4924 * fileio.c: Report proper errno when syscall falls.
4925 (Finsert_file_contents): Save and restore errno,
4926 so that report_file_error outputs the correct diagnostic.
4927 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4929 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4931 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4933 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4935 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4936 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4938 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4940 * xdisp.c (reseat_at_next_visible_line_start): Keep information
4941 about the current paragraph and restore it after the call to reseat.
4943 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4944 (bidi_find_paragraph_start): Search back for paragraph beginning
4945 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4946 (bidi_move_to_visually_next): Only trigger paragraph-related
4947 computations when the last character is a newline or at EOB, not
4948 just any NEUTRAL_B. (Bug#9470)
4950 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4951 truncated lines if point is covered by a display string. (Bug#9524)
4953 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4955 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4956 (cons_to_x_long): New function.
4957 (lisp_data_to_selection_data): Use it. Correct the test for
4958 short-versus-long data; it was negated. Break out of vector
4959 loop, for efficiency, when a long datum is discovered.
4961 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4963 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4965 2011-09-16 Eli Zaretskii <eliz@gnu.org>
4967 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4968 GCC PR/17406) by declaring this function with external scope.
4970 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4972 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4973 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4975 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4977 * editfns.c (Fformat): Correctly handle text properties on "%%".
4979 2011-09-15 Eli Zaretskii <eliz@gnu.org>
4981 * xterm.c (x_draw_composite_glyph_string_foreground):
4982 * w32term.c (x_draw_composite_glyph_string_foreground):
4983 * term.c (encode_terminal_code):
4984 * composite.c (composition_update_it, get_composition_id):
4985 * xdisp.c (get_next_display_element)
4986 (fill_composite_glyph_string): Add comments about special meaning
4987 of TAB characters in a composition.
4989 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4991 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4992 This occurs when processing a multibyte format.
4993 Problem reported by Wolfgang Jenker.
4995 2011-09-15 Johan Bockgård <bojohan@gnu.org>
4997 * xdisp.c (try_cursor_movement): Only check for exact match if
4998 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5000 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5002 Remove unused external symbols.
5003 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5004 * xdisp.c (calc_pixel_width_or_height): Now static.
5005 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5006 * indent.c (check_display_width):
5007 * w32term.c: Fix comment to match code.
5008 * xterm.c, xterm.h (x_catching_errors): Remove.
5010 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5012 * xselect.c: Use signed conversions more consistently (Bug#9498).
5013 (selection_data_to_lisp_data): Assume incoming selection data are
5014 signed integers, not unsigned. This is to be consistent with
5015 outgoing selection data, which was modified to use signed integers
5016 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5017 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5018 expects long, not unsigned long.
5020 2011-09-14 Eli Zaretskii <eliz@gnu.org>
5022 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5023 computation of loop end. Reported by Johan Bockgård
5026 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
5028 * frame.c (Fother_visible_frames_p): Function deleted.
5030 2011-09-12 Eli Zaretskii <eliz@gnu.org>
5032 * indent.c (compute_motion): Process display vector front to back
5033 rather than the other way around. (Bug#2496)
5035 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5037 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5039 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
5041 * minibuf.c (Fread_from_minibuffer): Doc fix.
5043 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5045 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5046 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5048 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5050 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5051 value for non-existent files.
5053 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5055 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5056 set its "size" to -1. This will set the modtime_size field of
5057 the corresponding buffer to -1, which is what
5058 verify-visited-file-modtime expects for files that do not exist.
5061 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5063 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5065 * lisp.h: ... from here. push_key_description is no longer
5066 defined in keyboard.c, so its declaration should not be in
5067 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5068 logically belongs with push_key_description.
5070 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5072 * buffer.h: Include <sys/types.h> instead of <time.h>.
5073 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5074 Problem reported by Herbert J. Skuhra.
5076 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5078 * xml.c (parse_region): Make the parsing work for
5079 non-comment-starting XML files again (bug#9144).
5081 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5083 * image.c (gif_load): Fix calculation of bottom and right corner.
5086 2011-09-10 Eli Zaretskii <eliz@gnu.org>
5088 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5089 redisplay in small windows.
5091 2011-09-09 Eli Zaretskii <eliz@gnu.org>
5093 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5095 2011-09-08 Martin Rudalics <rudalics@gmx.at>
5097 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5098 Operate on live windows only.
5100 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
5102 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5104 2011-09-07 Eli Zaretskii <eliz@gnu.org>
5106 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5107 only under bidi iteration.
5109 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5111 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5113 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5115 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5116 Without this fix, the command to link temacs failed due to an
5117 undefined symbol __builtin_isnan. This is because
5118 /usr/include/iso/math_c99.h #defines isnan(x) to
5119 __builtin_isnan(x), but the bundled gcc, which identifies itself
5120 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5122 * floatfns.c (isnan): #undef, and then #define to a clone of
5124 (Fisnan): Always define, since it's always available now.
5125 (syms_of_floatfns): Always define isnan at the Lisp level.
5127 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5129 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5131 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5133 * fileio.c: Fix bugs with large file offsets (Bug#9428).
5134 The previous code assumed that file offsets (off_t values) fit in
5135 EMACS_INT variables, which is not true on typical 32-bit hosts.
5136 The code messed up by falsely reporting buffer overflow in cases
5137 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5138 when "big" contains more than 2**29 bytes, even though this
5139 inserts just one byte and does not overflow the buffer.
5140 (Finsert_file_contents): Store file offsets as off_t
5141 values, not as EMACS_INT values. Check for overflow when
5142 converting between EMACS_INT and off_t. When checking for
5143 buffer overflow or for overlap, take the offsets into account.
5144 Don't use EMACS_INT for small values where int suffices.
5145 When checking for overlap, fix a typo: ZV was used where
5146 ZV_BYTE was intended.
5147 (Fwrite_region): Don't assume off_t fits into 'long'.
5148 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5150 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
5152 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5154 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5156 sprintf-related integer and memory overflow issues (Bug#9412).
5158 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
5159 (esprintf, exprintf, evxprintf): New functions.
5160 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
5161 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
5162 (modify_event_symbol): Do not assume that the length of
5163 name_alist_or_stem is safe to alloca and fits in int.
5164 (Fexecute_extended_command): Likewise for function name and binding.
5165 (Frecursion_depth): Wrap around reliably on integer overflow.
5166 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5167 since some callers pass EMACS_INT values.
5168 (Fsingle_key_description): Don't crash if symbol name contains more
5169 than MAX_ALLOCA bytes.
5170 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5171 (get_minibuffer): Arg is now EMACS_INT, not int.
5172 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
5173 (esprintf, exprintf, evxprintf): New decls.
5174 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5176 * dbusbind.c (signature_cat): New function.
5177 (xd_signature, Fdbus_register_signal):
5178 Do not overrun buffer; instead, report string overflow.
5180 * dispnew.c (add_window_display_history): Don't overrun buffer.
5181 Truncate instead; this is OK since it's just a log.
5183 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5184 even if the time zone offset is outlandishly large.
5185 Don't mishandle offset == INT_MIN.
5187 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5188 when creating daemon; the previous buffer-overflow check was incorrect.
5190 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5191 which has the guts of the old verror function.
5193 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5194 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5196 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5197 (font_unparse_xlfd): Don't blindly alloca long strings.
5198 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
5199 fits in int, when using sprintf. Use single snprintf to count
5200 length of string rather than counting it via multiple sprintfs;
5201 that's simpler and more reliable.
5202 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5203 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5204 sprintf, in case result does not fit in int.
5206 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5207 (fontset_from_font): Print it.
5209 * frame.c (tty_frame_count): Now printmax_t, not int.
5210 (make_terminal_frame, set_term_frame_name): Print it.
5211 (x_report_frame_params): In X, window IDs are unsigned long,
5212 not signed long, so print them as unsigned.
5213 (validate_x_resource_name): Check for implausibly long names,
5214 and don't assume name length fits in 'int'.
5215 (x_get_resource_string): Don't blindly alloca invocation name;
5216 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5219 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5220 (xg_check_special_colors, xg_set_geometry):
5221 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5223 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5224 Use esprintf, not sprintf, in case result does not fit in int.
5226 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5227 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5228 it as a large positive number.
5229 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5230 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5232 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5233 in case result does not fit in int.
5235 * print.c (float_to_string): Detect width overflow more reliably.
5236 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5237 buffer overrun. Don't assume list length fits in 'int'. Treat
5238 print length of 0 as 0, not as infinity; to be consistent with other
5239 uses of print length in this function. Don't overflow print length
5240 index. Don't assume hash table size fits in 'long', or that
5241 vectorlike size fits in 'unsigned long'.
5243 * process.c (make_process): Use printmax_t, not int, to format
5244 process-name gensyms.
5246 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5248 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5249 to avoid potential buffer overrun.
5251 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5252 if X resource line is longer than 512 bytes.
5254 * xfns.c (x_window): Make sprintf buffer a bit bigger
5255 to avoid potential buffer overrun.
5257 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5259 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5261 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5263 Integer overflow fixes for scrolling, etc.
5264 Without these, Emacs silently mishandles large integers sometimes.
5265 For example, "C-u 4294967297 M-x recenter" was treated as if
5266 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5268 * xdisp.c (try_window_id): Check Emacs fixnum range before
5269 converting to 'int'.
5271 * window.c (window_scroll_line_based, Frecenter):
5272 Check that an Emacs fixnum is in range before assigning it to 'int'.
5273 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5274 values converted from Emacs fixnums.
5275 (Frecenter): Don't wrap around a line count if it is out of 'int'
5276 range; instead, treat it as an extreme value.
5277 (Fset_window_configuration, compare_window_configurations):
5278 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5280 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5281 that can exceed INT_MAX. Check that EMACS_INT value is in range
5282 before assigning it to the (possibly-narrower) index.
5283 (match_limit): Don't assume that a fixnum can fit in 'int'.
5285 * print.c (print_object): Use ptrdiff_t, not int, for index that can
5288 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
5289 (Fvertical_motion): Don't wrap around LINES values that don't fit
5290 in 'int'. Instead, treat them as extreme values. This is good
5291 enough for windows, which can't have more than INT_MAX lines anyway.
5293 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5295 * Require libxml/parser.h to avoid compilation warning.
5297 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5299 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5300 since this reportedly can destroy thread storage.
5302 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
5304 * syntax.c (find_defun_start): Update all cache variables if
5305 exiting early (Bug#9401).
5307 2011-08-30 Eli Zaretskii <eliz@gnu.org>
5309 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5311 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5312 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5313 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5315 * term.c (tty_append_glyph): New function.
5316 (produce_stretch_glyph): Static function and its prototype deleted.
5318 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5321 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5323 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5324 when checking :margin (Bug#9390).
5325 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
5326 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
5327 so that the name doesn't mislead. All uses changed.
5329 2011-08-28 Johan Bockgård <bojohan@gnu.org>
5331 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5334 2011-08-27 Eli Zaretskii <eliz@gnu.org>
5336 * xdisp.c (move_it_to): Don't bail out early when reaching
5337 position beyond to_charpos, if we are scanning backwards.
5338 (move_it_vertically_backward): When DY == 0, make sure we get to
5339 the first character in the line after the newline.
5341 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5343 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5344 (ccl_driver): Do not generate an out-of-range pointer.
5345 (Fccl_execute_on_string): Remove unnecessary check for
5346 integer overflow, noted by Stefan Monnier in
5347 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5348 Remove a FIXME that didn't need fixing.
5349 Simplify the newly-introduced buffer reallocation code.
5351 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
5353 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5355 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
5357 Integer and memory overflow issues (Bug#9196).
5359 * doc.c (get_doc_string): Rework so that
5360 get_doc_string_buffer_size is the actual buffer size, rather than
5361 being 1 less than the actual buffer size; this makes xpalloc more
5364 * image.c (x_allocate_bitmap_record, cache_image):
5365 * xselect.c (Fx_register_dnd_atom):
5366 Simplify previous changes by using xpalloc.
5368 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5369 since either will do and ptrdiff_t is convenient with xpalloc.
5371 * charset.c (charset_table_size)
5372 (struct charset_sort_data.priority): Now ptrdiff_t.
5373 (charset_compare): Don't overflow if priorities differ greatly.
5374 (Fsort_charsets): Don't assume list length fits in int.
5375 Check for size-calculation overflow when allocating sort data.
5376 (syms_of_charset): Allocate an initial charset table that is
5377 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5379 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5381 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5382 The actual value is always <= INT_MAX, and leaving it unsigned made
5383 overflow checking harder.
5385 * dispextern.h (struct glyph_matrix.rows_allocated)
5386 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5387 with xpalloc. The values are still always <= INT_MAX.
5389 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5391 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5392 (SAFE_NALLOCA): New macro.
5394 * region-cache.c (struct boundary.pos, find_cache_boundary)
5395 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5396 (set_cache_region, invalidate_region_cache)
5397 (revalidate_region_cache, know_region_cache, region_cache_forward)
5398 (region_cache_backward, pp_cache):
5399 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5400 so that ptrdiff_t * can be passed to xpalloc.
5401 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5402 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5403 (pp_cache): Don't assume cache_len fits in int.
5404 * region-cache.h: Adjust extern decls to match.
5406 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5407 EMACS_INT, since either will do, for xpalloc.
5409 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5410 (xnmalloc, xnrealloc, xpalloc): New functions.
5412 * bidi.c (bidi_shelve_header_size): New constant.
5413 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5414 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5416 * bidi.c (bidi_cache_shrink):
5417 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5419 Don't update size of array until after memory allocation succeeds,
5420 because xmalloc/xrealloc may not return.
5421 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5422 now that we have proper integer overflow checking.
5423 (record_overlay_string, overlay_strings): Catch overflows when
5424 calculating size of overlay_str_buf.
5426 * callproc.c (Fcall_process): Check for size overflow when
5427 calculating size of args2.
5428 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5429 Normally we prefer signed values, but sticking with ptrdiff_t would
5430 require adding more-complicated checks.
5432 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5433 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5434 Redo buffer-overflow calculations to avoid integer overflow.
5435 Add a FIXME comment where memory seems to be over-allocated.
5437 * character.c (Fstring): Check for size-calculation overflow.
5439 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5440 unnecessary integer overflow. Check for size overflow.
5441 (encode_coding_object): Don't update size until xmalloc succeeds.
5443 * composite.c (get_composition_id): Check for overflow in glyph
5444 length calculations.
5446 Integer and memory overflow fixes for display code.
5447 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5448 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5449 (scrolling_window): Check for overflow in size calculations.
5450 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5451 Don't assume glyph table len fits in int.
5452 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5453 (row_table_size): Now ptrdiff_t, not int.
5454 (scrolling_window): Avoid overflow in size calculations.
5455 Don't update size until allocation succeeds.
5456 * fns.c (concat): Check for overflow in size calculations.
5457 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5458 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5459 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5461 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5462 (get_doc_string): Check for size calculation overflow.
5463 Don't update size until allocation succeeds.
5464 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5465 EMACS_INT, where ptrdiff_t will do.
5466 (Fsubstitute_command_keys): Check for string overflow.
5468 * editfns.c (set_time_zone_rule): Don't assume environment length
5470 (message_length): Now ptrdiff_t, not int.
5471 (Fmessage_box): Don't update size until allocation succeeds.
5472 Don't assume message length fits in int.
5473 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5475 * emacs.c (main): Do not reallocate argv, since there is a null at
5476 the end that can be overwritten, and this way there's no need to
5477 worry about size-calculation overflow.
5478 (sort_args): Check for size-calculation overflow.
5480 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5482 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5484 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5485 (x_set_scroll_bar_width, x_figure_window_size):
5486 Check for integer overflow.
5487 (x_set_alpha): Do not assume XINT fits in int.
5489 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5490 This is for the members text_lines, text_cols, total_lines, total_cols,
5491 where the system imposes an 'int' limit.
5493 * fringe.c (Fdefine_fringe_bitmap):
5494 Don't update size until alloc works.
5496 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5497 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5499 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5500 Check for size-calculation overflow.
5501 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5502 do, as we prefer signed integers.
5503 (id_to_widget.max_size, id_to_widget.used)
5504 (xg_store_widget_in_map, xg_remove_widget_from_map)
5505 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5506 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5507 Use and return ptrdiff_t, not int.
5508 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5509 * gtkutil.h: Change prototypes to match the above.
5511 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5512 are duplicate now that they've been promoted to lisp.h.
5513 (x_allocate_bitmap_record, x_alloc_image_color)
5514 (make_image_cache, cache_image, xpm_load):
5515 Don't update size until alloc is done.
5516 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5518 Check for size calculation overflow.
5519 (ct_colors_allocated_max): New constant.
5520 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5523 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5524 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5525 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5526 Use ptrdiff_t, not int, to count maps.
5527 (read_char_minibuf_menu_prompt): Check for overflow in size
5528 calculations. Don't update size until allocation succeeds.
5529 Redo calculations to avoid overflow.
5530 * keyboard.h: Change prototypes to match the above.
5532 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5534 (current_minor_maps): Check for size calculation overflow.
5535 * keymap.h: Change prototypes to match the above.
5537 * lread.c (read1, init_obarray): Don't update size until alloc done.
5539 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5540 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5542 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5543 Now ptrdiff_t, not int.
5544 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5545 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5547 * process.c (Fnetwork_interface_list): Check for overflow
5548 in size calculation.
5550 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5552 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5553 overflow. Don't bother calling xmalloc when xrealloc will do.
5555 * search.c (Freplace_match): Check for size calculation overflow.
5556 (Fset_match_data): Don't assume list lengths fit in 'int'.
5558 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5559 for command line length. Do not attempt to address one before the
5560 beginning of an array, as that's not portable.
5562 * term.c (max_frame_lines): Remove; unused.
5563 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5565 (encode_terminal_code, calculate_costs): Check for size
5566 calculation overflow.
5567 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5568 table lengths and related sizes. Don't update size until alloc
5569 done. Redo calculations to avoid overflow.
5570 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5572 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5573 subtracting pointers.
5574 (gobble_line): Check for overflow more carefully. Don't update size
5577 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5578 Don't update size until alloc done.
5579 Redo size calculations to avoid overflow.
5580 Check for size calculation overflow.
5581 (main) [DEBUG]: Fix typo in invoking tparam1.
5583 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5584 Use ptrdiff_t, not int, for sizes.
5585 (store_mode_line_noprop_char): Don't update size until alloc done.
5587 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5588 Use ptrdiff_t, not int, for sizes.
5589 (Finternal_make_lisp_face, cache_face):
5590 Check for size calculation overflow.
5591 (cache_face): Treat size calculation overflows as if they were
5592 memory exhaustion (the usual treatment), rather than aborting.
5594 * xfns.c (x_encode_text, x_set_name_internal)
5595 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5596 sizes, since they can exceed INT_MAX in size. Check for size
5597 calculation overflow.
5599 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5600 (xg_select): Check for size calculation overflow.
5601 Don't update size until alloc done.
5603 * xrdb.c (get_environ_db): Don't assume path length fits in int,
5604 as sprintf is limited to int lengths.
5606 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5607 (X_LONG_MIN): New macros.
5608 Use them to make the following changes clearer.
5609 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5610 This change doesn't affect the value now, but it may help remind
5611 future maintainers not to raise the value too much later.
5612 (SELECTION_QUANTUM): Remove, replacing with ...
5613 (selection_quantum): ... new function, which avoids overflow.
5615 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5616 assumption that selection length fits in 'int'.
5617 (x_reply_selection_request, x_handle_selection_request)
5618 (x_get_window_property, receive_incremental_selection)
5619 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5620 (lisp_data_to_selection_data, clean_local_selection_data):
5621 Use ptrdiff_t, not int, to record length of selection.
5622 (x_reply_selection_request, x_get_window_property)
5623 (receive_incremental_selection, x_property_data_to_lisp):
5624 Redo calculations to avoid overflow.
5625 (x_reply_selection_request): When sending hint, ceiling it at
5626 X_LONG_MAX rather than relying on wraparound overflow to send
5628 (x_get_window_property, receive_incremental_selection)
5629 (lisp_data_to_selection_data, x_property_data_to_lisp):
5630 Check for size-calculation overflow.
5631 (x_get_window_property, receive_incremental_selection)
5632 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5633 Don't store size until memory allocation succeeds.
5634 (x_get_window_property): Plug memory leak on memory exhaustion.
5635 Don't double-block input; malloc is safe here. Don't assume 2**34
5636 - 4 fits in unsigned long. Add an xassert to check
5637 XGetWindowProperty overflow. Be more careful about overflow
5638 calculations, and distinguish size from memory overflow better.
5639 (receive_incremental_selection): When tracing, don't assume
5640 unsigned int is less than INT_MAX.
5641 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5642 harmful) conversions of unsigned short to int.
5643 (lisp_data_to_selection_data): Don't assume that integers
5644 in the range -65535 through -1 fit in an X unsigned short.
5645 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5646 result parameters unless successful. Rely on cons_to_unsigned
5647 to report problems with elements; the old code wasn't right anyway.
5648 (x_check_property_data): Check for int overflow; we cannot use
5649 a wider type due to X limits.
5650 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5652 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
5654 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5655 (x_term_init): Check for size calculation overflow.
5656 (x_color_cells): Don't store size until memory allocation succeeds.
5657 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
5658 Don't assume alloca size is less than MAX_ALLOCA.
5659 (x_term_init): Don't assume length fits in int (sprintf is limited
5662 Use ptrdiff_t for composition IDs.
5663 * character.c (lisp_string_width):
5664 * composite.c (composition_table_size, n_compositions)
5665 (get_composition_id, composition_gstring_from_id):
5666 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5667 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5668 * window.c (Frecenter):
5669 Use ptrdiff_t, not int, for composition IDs.
5670 * composite.c (get_composition_id): Check for integer overflow.
5671 * composite.h: Adjust prototypes to match the above changes.
5673 Use ptrdiff_t for hash table indexes.
5674 * category.c (hash_get_category_set):
5675 * ccl.c (ccl_driver):
5676 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5677 * coding.c (coding_system_charset_list, detect_coding_system):
5678 * coding.h (struct coding_system.id):
5679 * composite.c (get_composition_id, gstring_lookup_cache):
5680 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5681 * image.c (xpm_get_color_table_h):
5682 * lisp.h (hash_lookup, hash_put):
5683 * minibuf.c (Ftest_completion):
5684 Use ptrdiff_t for hash table indexes, not int (which is too
5685 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5686 32-bit --with-wide-int hosts).
5688 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5689 Add a FIXME comment about memory leaks.
5690 (syms_of_charset): Don't assume xmalloc returns.
5692 Don't assume that stated character widths fit in int.
5693 * character.c (Fchar_width, c_string_width, lisp_string_width):
5694 * character.h (CHAR_WIDTH):
5695 * indent.c (MULTIBYTE_BYTES_WIDTH):
5696 Use sanitize_char_width to avoid undefined and/or bad behavior
5697 with outlandish widths.
5698 * character.h (sanitize_tab_width): Rename from sanitize_width,
5699 now that we have two such functions. All uses changed.
5700 (sanitize_char_width): New inline function.
5702 Don't assume that tab-width fits in int.
5703 * character.h (sanitize_width): New inline function.
5704 (SANE_TAB_WIDTH): New macro.
5705 (ASCII_CHAR_WIDTH): Use it.
5706 * indent.c (sane_tab_width): Remove. All uses replaced by
5707 SANE_TAB_WIDTH (current_buffer).
5708 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5710 * fileio.c: Integer overflow issues with file modes.
5711 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5713 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5714 Remove unreachable code.
5715 (read_hex, load_charset_map_from_file): Check for integer overflow.
5717 * xterm.c: Don't go over XClientMessageEvent limit.
5718 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5719 (x_send_scroll_bar_event): Likewise. Check that the size does not
5720 exceed limits imposed by XClientMessageEvent, as well as the usual
5721 ptrdiff_t and size_t limits.
5723 * keyboard.c: Overflow, signedness and related fixes.
5724 (make_lispy_movement): Use same integer type in forward decl
5725 that is used in the definition.
5726 (read_key_sequence, keyremap_step):
5727 Change bufsize argument back to int, undoing my 2011-03-30 change.
5728 We prefer signed types, and int is wide enough here.
5729 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5730 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5731 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5732 length, not size_t. Use ptrdiff_t for index, not int.
5733 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5734 possibility of integer overflow.
5736 Overflow, signedness and related fixes for images.
5738 * dispextern.h (struct it.stack[0].u.image.image_id)
5739 (struct_it.image_id, struct image.id, struct image_cache.size)
5740 (struct image_cache.used, struct image_cache.ref_count):
5741 * gtkutil.c (update_frame_tool_bar):
5742 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5743 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5744 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5745 * nsmenu.m (update_frame_tool_bar):
5746 * xdisp.c (calc_pixel_width_or_height):
5747 * xfns.c (image_cache_refcount):
5748 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5749 on typical 64-bit hosts.
5751 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5752 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5753 Omit unnecessary casts to int.
5754 (parse_image_spec): Check that integers fall into 'int' range
5755 when the callers expect that.
5756 (image_ascent): Redo ascent calculation to avoid int overflow.
5757 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5758 (lookup_image): Remove unnecessary tests.
5759 (xbm_image_p): Locals are now of int, not EMACS_INT,
5760 since parse_image_check makes sure they fit into int.
5761 (png_load, gif_load, svg_load_image):
5762 Prefer int to unsigned where either will do.
5763 (tiff_handler): New function, combining the cores of the
5764 old tiff_error_handler and tiff_warning_handler.
5765 This function is rewritten to use vsnprintf and thereby avoid
5766 stack buffer overflows. It uses only the features of vsnprintf
5767 that are common to both POSIX and native Microsoft.
5768 (tiff_error_handler, tiff_warning_handler): Use it.
5769 (tiff_load, gif_load, imagemagick_load_image):
5770 Don't assume :index value fits in 'int'.
5771 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5772 (imagemagick_load_image): Check that crop parameters fit into
5773 the integer types that MagickCropImage accepts. Don't assume
5774 Vimagemagick_render_type has a nonnegative value. Don't assume
5775 size_t fits in 'long'.
5776 (gs_load): Use printmax_t to print the widest integers possible.
5777 Check for integer overflow when computing image height and width.
5779 2011-08-26 Eli Zaretskii <eliz@gnu.org>
5781 * xdisp.c (redisplay_window): Don't force window start if point
5782 will be invisible in the resulting window. (Bug#9324)
5784 2011-08-25 Eli Zaretskii <eliz@gnu.org>
5786 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5787 the display spec is of the form `(space ...)'.
5788 (handle_display_spec): Return the value returned by
5789 handle_single_display_spec, not just 1 or zero.
5790 (handle_single_display_spec): If the display spec is of the form
5791 `(space ...)', and specifies display in the text area, return 2
5793 (try_cursor_movement): Check for the need to scroll more
5794 accurately, and prefer exact match for point under bidi.
5795 Don't advance `row' beyond the last row of the window.
5797 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5798 into disp_prop; all users changed.
5800 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5801 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5802 for the text covered by the display property.
5804 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
5806 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5807 Change return value to nil.
5808 (Frecord_buffer): Delete unused function.
5810 2011-08-24 Eli Zaretskii <eliz@gnu.org>
5812 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5813 buffers, return left-to-right.
5814 (set_cursor_from_row): Consider candidate row a win if its glyph
5815 represents a newline and point is on that newline. Fixes cursor
5816 positioning on the newline at EOL of R2L text within L2R
5817 paragraph, and vice versa.
5818 (try_cursor_movement): Check continued rows, in addition to
5819 continuation rows. Fixes unwarranted scroll when point enters a
5820 continued line of R2L text within an L2R paragraph, or vice versa.
5821 (cursor_row_p): Consider the case of point being equal to
5822 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5823 from the end of a short line to the beginning of a continued line
5824 of R2L text within L2R paragraph.
5825 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5826 composed characters.
5828 * bidi.c (bidi_check_type): Use xassert.
5829 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5832 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5834 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5837 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
5839 * nsfont.m (ns_otf_to_script): Fix typo.
5841 2011-08-22 Kenichi Handa <handa@m17n.org>
5843 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5844 extra slot even if the purpose is char-code-property-table.
5846 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5848 * xdisp.c (redisplay_window): When computing centering_position,
5849 account for the height of the header line. (Bug#8874)
5851 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5852 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5853 candidate is selected by the mouse, and that candidate has a
5854 composed character under the mouse.
5856 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5857 coordinates reported by pos-visible-in-window-p for a composed
5858 character in column zero.
5860 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5862 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5864 2011-08-22 Eli Zaretskii <eliz@gnu.org>
5866 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5867 consider it a hit if to_charpos is anywhere in the range of the
5868 composed buffer positions.
5870 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
5872 * image.c (gif_load): Don't assume that each subimage has the same
5873 dimensions as the base image. Handle disposal method that is
5874 "undefined" by the gif spec (Bug#9335).
5876 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
5878 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
5879 (Fcondition_case): Document `debug' symbol in error handler.
5881 2011-08-19 Eli Zaretskii <eliz@gnu.org>
5883 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5884 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5885 from an Org mode buffer to a Speedbar frame.
5887 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5888 a composition, take its buffer position from IT->cmp_it.charpos.
5889 Fixes cursor positioning at the beginning of a line that begins
5890 with a composed character.
5892 2011-08-18 Eli Zaretskii <eliz@gnu.org>
5894 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5895 character bidirectional type, use STRONG_L instead. Fixes crashes
5896 in a buffer produced by `describe-categories'.
5898 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5899 members before the level stack, so they would be saved and
5900 restored when copying iterator state. Fixes incorrect reordering
5901 around TABs covered by display properties.
5903 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5905 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
5907 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
5909 * eval.c (internal_condition_case, internal_condition_case_1)
5910 (internal_condition_case_2, internal_condition_case_n):
5911 Remove unnecessary aborts (Bug#9081).
5913 2011-08-17 Eli Zaretskii <eliz@gnu.org>
5915 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5916 has no `load' handler, try opening the file locally. (Bug#9311)
5918 2011-08-16 Ken Brown <kbrown@cornell.edu>
5920 * gmalloc.c: Expand comment.
5922 2011-08-16 Eli Zaretskii <eliz@gnu.org>
5924 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5925 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5927 2011-08-16 Ken Brown <kbrown@cornell.edu>
5929 Fix memory allocation problems in Cygwin build (Bug#9273).
5931 * unexcw.c ( __malloc_initialized): Declare external variable.
5932 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5934 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5936 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5938 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5940 [CYGWIN] (special_realloc): New function.
5941 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5942 requests to realloc storage in the static heap.
5944 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5946 * bidi.c (bidi_initialize): Remove unused local.
5948 2011-08-15 Eli Zaretskii <eliz@gnu.org>
5951 * biditype.h: Remove file.
5952 * makefile.w32-in ($(BLD)/bidi.$(O)):
5953 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
5955 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5957 * chartab.c: Improve commentary for the uniprop_table API.
5959 * bidi.c (bidi_paragraph_init): Support zero value of
5960 bidi_ignore_explicit_marks_for_paragraph_level.
5961 (bidi_initialize): Use uniprop_table instead of including
5962 biditype.h and bidimirror.h.
5964 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5965 coordinates of the iterator when restoring from ppos_it.
5968 2011-08-14 Kenichi Handa <handa@m17n.org>
5970 * process.c (create_process): Call setup_process_coding_systems
5971 after the pid of the process is set to -1 (Bug#8162).
5973 2011-08-14 Eli Zaretskii <eliz@gnu.org>
5975 * xdisp.c (move_it_in_display_line_to): Don't invoke
5976 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5977 ppos_it. Fixes vertical cursor motion when line beginning is
5978 covered by an image. (Bug#9296)
5980 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5982 * nsterm.h (ns_run_ascript): Declare.
5983 (NSAPP_DATA2_RUNASSCRIPT): Define.
5985 * nsfns.m (as_script, as_result, as_status): New static variables.
5986 (ns_run_ascript): New function.
5987 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
5988 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5989 the event loop. Get status from as_status (Bug#7276).
5991 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5992 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5993 the event loop (Bug#7276).
5995 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5997 * gnutls.c (QCgnutls_bootprop_priority)
5998 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5999 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6000 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6001 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6002 (QCgnutls_bootprop_verify_hostname_error)
6003 (QCgnutls_bootprop_callbacks_verify): Rename from
6004 Qgnutls_bootprop_..., all uses changed.
6006 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6009 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6011 * xfaces.c (Qframe_set_background_mode): Now static.
6012 * dispextern.h (Qframe_set_background_mode): Remove decl.
6014 * process.c (Fnetwork_interface_info): Declare local only if needed.
6016 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6018 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6019 (Fnetwork_interface_list): Allocate in increments of bytes instead
6020 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6021 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6023 (struct ifflag_def): notrailers is smart on OSX.
6024 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6025 Get hardware address with getifaddrs if available.
6027 2011-08-12 Eli Zaretskii <eliz@gnu.org>
6029 * xdisp.c (iterate_out_of_display_property): xassert that
6030 IT->position is set to within IT->object's boundaries. Break from
6031 the loop as soon as EOB is reached; avoids infloops in redisplay
6032 when IT->position is set up wrongly due to some bug.
6033 Set IT->current to match the bidi iterator unconditionally.
6034 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6035 entry. Force push_it to save on the stack the current
6036 buffer/string position, to be restored by pop_it. Fix flags in
6037 the iterator structure wrt the object coming from a display
6038 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6039 properties. (Bug#9284)
6041 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
6043 * fontset.c (fontset_get_font_group): Add proper type checks.
6046 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6048 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6049 and LC_VERSION_MIN_MACOSX.
6050 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6051 (dump_it) [LC_FUNCTION_STARTS]: Use it.
6053 2011-08-08 Eli Zaretskii <eliz@gnu.org>
6055 * xdisp.c (forward_to_next_line_start): Allow to use the
6056 no-display-properties-and-no-overlays under bidi display.
6057 Set disp_pos in the bidi iterator to avoid searches for display
6058 properties and overlays.
6060 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
6062 * editfns.c (Fset_time_zone_rule): Document relationship with the
6065 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6066 the font entity extracted from the cache (Bug#8109).
6068 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
6070 * composite.c (autocmp_chars): Don't reset point. That is done by
6071 restore_point_unwind (Bug#5984).
6073 2011-08-07 Juri Linkov <juri@jurta.org>
6075 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6076 to show the arg `TIME' instead of `TIMEVAL'.
6078 2011-08-06 Eli Zaretskii <eliz@gnu.org>
6080 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6081 display property strides EOL and includes a newline, as in
6082 longlines-mode. (Bug#9254)
6083 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6084 word-wrap under bidirectional display. (Bug#9224)
6086 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6087 is non-zero, even if the data buffer is NULL. Fixes a crash in
6088 vertical-motion with longlines-mode. (Bug#9254)
6090 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6092 * bidi.c <bidi_cache_total_alloc>: Now static.
6093 (bidi_initialize): Initialize bidi_cache_total_alloc.
6095 * xdisp.c (display_line): Release buffer allocated for shelved bidi
6098 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6099 amount allocated this far in `bidi_cache_total_alloc'.
6100 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6101 non-zero, only free the data buffer without restoring the cache
6102 contents. All callers changed.
6104 * dispextern.h (bidi_unshelve_cache): Update prototype.
6106 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6107 (move_it_in_display_line, move_it_to)
6108 (move_it_vertically_backward, move_it_by_lines): Replace the call
6109 to xfree to an equivalent call to bidi_unshelve_cache.
6110 (move_it_in_display_line_to): Fix logic of returning
6111 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
6113 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6115 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6116 came from a string character with a `cursor' property. (Bug#9229)
6118 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6120 * Makefile.in (LIB_PTHREAD): New variable.
6121 (LIBES): Add LIB_PTHREAD (Bug#9216).
6123 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6124 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6126 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6128 * regex.c (re_iswctype): Remove some redundant boolean conversions.
6130 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6132 * xterm.c (x_find_topmost_parent): New function.
6133 (x_set_frame_alpha): Find topmost parent window with
6134 x_find_topmost_parent and set the property there also (bug#9181).
6135 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6137 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6139 * callproc.c (Fcall_process): Avoid vfork clobbering
6140 the local vars buffer, coding_systems, current_dir.
6142 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6144 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6146 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6148 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6149 so that it is not optimized away.
6151 * xdisp.c (compute_display_string_pos): Remove unused local.
6153 2011-08-02 Eli Zaretskii <eliz@gnu.org>
6155 Fix slow cursor motion and scrolling in large buffers with
6156 selective display, like Org Mode buffers. (Bug#9218)
6158 * dispextern.h (struct bidi_it): New member disp_prop_p.
6160 * xdisp.c: Remove one-slot cache of display string positions.
6161 (compute_display_string_pos): Accept an additional argument
6162 DISP_PROP_P; callers changed. Scan at most 5K characters forward
6163 for a display string or property. If found, set DISP_PROP_P
6166 * bidi.c (bidi_fetch_char): Accept an additional argument
6167 DISP_PROP_P, and pass it to compute_display_string_pos.
6168 Only handle text covered by a display string if DISP_PROP_P is returned
6169 non-zero. All callers of bidi_fetch_char changed.
6171 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6173 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6175 2010-12-03 Don March <don@ohspite.net>
6177 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6178 last character M-[char] is translated to ESC [char] (bug#7541).
6180 2011-08-02 Kenichi Handa <handa@m17n.org>
6182 * lisp.h (uniprop_table): Extern it.
6184 * chartab.c (uniprop_table): Make it non-static.
6186 2011-08-01 Eli Zaretskii <eliz@gnu.org>
6188 * xdisp.c (forward_to_next_line_start): Accept additional argument
6189 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6191 (reseat_at_next_visible_line_start): Use the bidi iterator state
6192 returned by forward_to_next_line_start to restore the state of
6193 it->bidi_it after backing up to previous newline. (Bug#9212)
6195 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6197 * regex.c (re_comp): Protoize.
6198 (re_exec): Fix return type.
6199 (regexec): Fix type of `ret'. (Bug#9203)
6201 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6203 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6204 This is needed if max-image-size is a floating-point number.
6206 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6208 * print.c (print_object): Print empty symbol as ##.
6210 * lread.c (read1): Read ## as empty symbol.
6212 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6214 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6215 setting frame foreground color (Bug#9175).
6216 (x_set_background_color): Likewise.
6218 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6219 contents (Bug#9176).
6220 (EmacsTooltip -init): Remove bezels and add shadows to
6223 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6224 or scroll bar (Bug#8470).
6226 * nsfont.m (nsfont_open): Remove assignment to voffset and
6227 unnecessary vars hshink, expand, hd, full_height, min_height.
6228 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6230 * nsterm.h (nsfont_info): Remove voffset field.
6232 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6234 Implement strike-through and overline on NextStep (Bug#8863).
6236 * nsfont.m (nsfont_open): Use underline position provided by font,
6237 instead of hard-coded value of 2.
6238 (nsfont_draw): Call ns_draw_text_decoration instead.
6240 * nsterm.h: Add declaration for ns_draw_text_decoration.
6242 * nsterm.m (ns_draw_text_decoration): New function for drawing
6243 underline, overline, and strike-through.
6244 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6245 ns_draw_text_decoration. Change treatment of cursor drawing to
6246 accommodate underlining, etc.
6248 2011-07-28 Eli Zaretskii <eliz@gnu.org>
6250 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6253 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6255 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6256 Without this fix, if a signal arrives just after memory fills up,
6257 'malloc' might be invoked reentrantly.
6259 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6260 In other words, assume that every image size is allowed, on non-X
6261 hosts. This assumption is probably wrong, but it lets Emacs compile.
6263 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6265 * regex.c (re_iswctype): Convert return values to boolean.
6267 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6269 * xdisp.c (compute_display_string_pos): Don't use cached display
6270 string position if the buffer had its restriction changed.
6273 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6275 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6277 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6279 Integer signedness and overflow and related fixes. (Bug#9079)
6281 * bidi.c: Integer size and overflow fixes.
6282 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6283 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6284 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6285 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6286 (bidi_find_other_level_edge):
6287 Use ptrdiff_t instead of EMACS_INT where either will do.
6288 This works better on 32-bit hosts configured --with-wide-int.
6289 (bidi_cache_ensure_space): Check for size-calculation overflow.
6290 Use % rather than repeated addition, for better worst-case speed.
6291 Don't set bidi_cache_size until after xrealloc returns, because it
6293 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
6294 (bidi_cache_ensure_space): Also check that the bidi cache size
6295 does not exceed that of the largest Lisp string or buffer. See Eli
6296 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
6298 * alloc.c (__malloc_size_t): Remove.
6299 All uses replaced by size_t. See Andreas Schwab's note
6300 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6302 * image.c: Improve checking for integer overflow.
6303 (check_image_size): Assume that f is nonnull, since
6304 it is always nonnull in practice. This is one less thing to
6305 worry about when checking for integer overflow later.
6306 (x_check_image_size): New function, which checks for integer
6307 overflow issues inside X.
6308 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6309 This removes the need for a memory_full check.
6310 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6311 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6312 (xbm_read_bitmap_data): Change locals back to 'int', since
6313 their values must fit in 'int'.
6314 (xpm_load_image, png_load, tiff_load):
6315 Invoke x_create_x_image_and_pixmap earlier,
6316 to avoid much needless work if the image is too large.
6317 (tiff_load): Treat overly large images as if
6318 x_create_x_image_and_pixmap failed, not as malloc failures.
6319 (gs_load): Use x_check_image_size.
6321 * gtkutil.c: Omit integer casts.
6322 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6323 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6325 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6327 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6328 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6329 would wrongly return t on a 64-bit host.
6331 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6332 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6333 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6334 and therefore cause GCC to emit a bogus diagnostic in some cases.
6336 * image.c: Integer signedness and overflow and related fixes.
6337 This is not an exhaustive set of fixes, but it's time to
6338 record what I've got.
6339 (lookup_pixel_color, check_image_size): Remove redundant decls.
6340 (check_image_size): Don't assume that arbitrary EMACS_INT values
6341 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6342 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6343 (tiff_load, imagemagick_load_image):
6344 Check for overflow in size calculations.
6345 (x_create_x_image_and_pixmap): Remove unnecessary test for
6346 xmalloc returning NULL; that can't happen.
6347 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6348 (xpm_color_bucket): Use better integer hashing function.
6349 (xpm_cache_color): Don't possibly over-allocate memory.
6350 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6351 (gif_memory_source):
6352 Use ptrdiff_t, not int or size_t, to record sizes.
6353 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6354 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6355 either works, as we prefer signed integers.
6356 (tiff_read_from_memory, tiff_write_from_memory):
6357 Return tsize_t, not size_t, since that's what the TIFF API wants.
6358 (tiff_read_from_memory): Don't fail simply because the read would
6359 go past EOF; instead, return a short read.
6360 (tiff_load): Omit no-longer-needed casts.
6361 (Fimagemagick_types): Don't assume size fits into 'int'.
6363 Improve hashing quality when configured --with-wide-int.
6364 * fns.c (hash_string): New function, taken from sxhash_string.
6365 Do not discard information about ASCII character case; this
6366 discarding is no longer needed.
6367 (sxhash-string): Use it. Change sig to match it. Caller changed.
6368 * lisp.h: Declare it.
6369 * lread.c (hash_string): Remove, since we now use fns.c's version.
6370 The fns.c version returns a wider integer if --with-wide-int is
6371 specified, so this should help the quality of the hashing a bit.
6373 * emacs.c: Integer overflow minor fix.
6374 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6375 Define only if GNU_LINUX.
6376 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6378 * dispnew.c: Integer signedness and overflow fixes.
6379 Remove unnecessary forward decls, that were a maintenance hassle.
6380 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6382 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6383 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6384 (prepare_desired_row, line_draw_cost):
6385 Use int, not unsigned, where either works.
6386 (save_current_matrix, restore_current_matrix):
6387 Use ptrdiff_t, not size_t, where either works.
6388 (init_display): Check for overflow more accurately, and without
6389 relying on undefined behavior.
6391 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6392 Remove, replacing with the new symbols in lisp.h. All uses changed.
6393 * fileio.c (make_temp_name):
6394 * filelock.c (lock_file_1, lock_file):
6395 * xdisp.c (message_dolog):
6396 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6397 Use pMd etc. instead.
6398 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6399 replacing the pWIDE etc. symbols removed from editfns.c.
6401 * keyboard.h (num_input_events): Now uintmax_t.
6402 This is (very slightly) less likely to mess up due to wraparound.
6405 * buffer.c: Integer signedness fixes.
6406 (alloc_buffer_text, enlarge_buffer_text):
6407 Use ptrdiff_t rather than size_t when either will do, as we prefer
6410 * alloc.c: Integer signedness and overflow fixes.
6411 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6412 (__malloc_size_t): Default to size_t, not to int.
6413 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6414 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6415 Prefer ptrdiff_t to size_t when either would do, as we prefer
6417 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6418 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6419 Now const. Initialize with values that are in range even if char
6421 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6422 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6423 These functions do the right thing with sizes > 2**32.
6424 (check_depth): Now ptrdiff_t, not int.
6425 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6426 Adjust to new way of storing sizes. Check for size overflow bugs
6428 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6429 slightly wrong anyway, as it missed one instance of
6430 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6431 (refill_memory_reserve): Omit needless cast to size_t.
6432 (mark_object_loop_halt): Mark as externally visible.
6434 * xselect.c: Integer signedness and overflow fixes.
6435 (Fx_register_dnd_atom, x_handle_dnd_message):
6436 Use ptrdiff_t, not size_t, since we prefer signed.
6437 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6438 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6439 x_dnd_atoms_size and x_dnd_atoms_length.
6441 * doprnt.c: Prefer signed to unsigned when either works.
6443 * doprnt.c (doprnt):
6445 * xdisp.c (vmessage):
6446 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6447 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6448 prefer signed arithmetic to avoid comparison confusion.
6449 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6450 but is a bit tricky.
6452 Assume freestanding C89 headers, string.h, stdlib.h.
6453 * data.c, doprnt.c, floatfns.c, print.c:
6454 Include float.h unconditionally.
6455 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6456 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6457 * regex.c: Likewise for stddef.h, string.h.
6458 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6459 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6460 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6461 (STDC_HEADERS): Remove obsolete defines.
6462 * sysdep.c: Include limits.h unconditionally.
6464 Assume support for memcmp, memcpy, memmove, memset.
6465 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6466 * regex.c (memcmp, memcpy):
6467 Remove; we assume C89 now.
6469 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6470 (__malloc_safe_bcopy): Remove; no longer needed.
6472 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6473 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6474 well either way, and we prefer signed to unsigned.
6476 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6478 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6479 closes the connection while we're reading (bug#9182).
6481 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
6483 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6484 are specified (Bug#9168).
6486 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6488 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6489 Found by GCC static checking and --with-wide-int on a 32-bit host.
6491 2011-07-25 Eli Zaretskii <eliz@gnu.org>
6493 * xdisp.c (compute_display_string_pos): Fix logic of caching
6494 previous display string position. Initialize cached_prev_pos to
6495 -1. Fixes slow-down at the beginning of a buffer.
6497 2011-07-24 Eli Zaretskii <eliz@gnu.org>
6499 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6500 for attrs[LFACE_FONTSET_INDEX].
6502 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6504 * xml.c (parse_region): Remove unused local
6505 that was recently introduced.
6507 2011-07-23 Eli Zaretskii <eliz@gnu.org>
6509 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6510 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6512 * xdisp.c (move_it_in_display_line_to): Record the best matching
6513 position for TO_CHARPOS while scanning the line, and restore it on
6514 exit if none of the characters scanned was an exact match.
6515 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
6516 when exact match is impossible due to invisible text, and the
6517 lines are truncated.
6519 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6521 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6524 2011-07-22 Eli Zaretskii <eliz@gnu.org>
6526 Fix a significant slow-down of cursor motion with C-n, C-p,
6527 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6528 auto-repeat under bidi redisplay in fontified buffers.
6529 * xdisp.c (compute_stop_pos_backwards): New function.
6530 (next_element_from_buffer): Call compute_stop_pos_backwards to
6531 find a suitable prev_stop when we find ourselves before
6533 (reseat): Don't look for prev_stop, as that could mean a very long
6535 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6536 <cached_disp_overlay_modiff>: Cache for last found display string
6538 (compute_display_string_pos): Return the cached position if asked
6539 about the same buffer in the same area of character positions, and
6540 the buffer wasn't changed since the time the display string
6541 position was cached.
6543 2011-07-22 Eli Zaretskii <eliz@gnu.org>
6545 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6546 is an integer, which is important for empty lines. (Bug#9149)
6548 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
6550 * frame.c (Fmodify_frame_parameters): In tty case, update the
6551 default face if necessary (Bug#4238).
6553 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
6555 * editfns.c (Fstring_to_char): No need to explain what a character
6556 is in the docstring (Bug#6576).
6558 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6560 * xml.c (parse_region): Make sure we always return a tree.
6562 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6564 * xml.c (parse_region): If a document contains only comments,
6567 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6569 * xml.c (make_dom): Return comments, too.
6571 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6574 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6575 and the surrounding thread.
6576 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6577 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6578 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6580 * s/openbsd.h (BROKEN_SIGIO): Define.
6581 * unexelf.c (unexec) [__OpenBSD__]:
6582 Don't update the .mdebug section of the Alpha COFF symbol table.
6584 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6586 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6589 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6591 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6592 This fixes some race conditions on the permissions of any newly
6595 * alloc.c (valid_pointer_p): Use pipe, not open.
6596 This fixes some permissions issues when debugging.
6598 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6599 If fchown fails to set both uid and gid, try to set just gid,
6600 as that is sometimes allowed. Adjust the file's mode to eliminate
6601 setuid or setgid bits that are inappropriate if fchown fails.
6603 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6605 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6606 to compare Lisp_Objects.
6607 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6608 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6609 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6611 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6613 * lread.c (read_integer): Unread even EOF character.
6614 (read1): Likewise. Properly record start position of symbol.
6616 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6617 symbol character follows.
6619 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6621 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6622 This works around a problem with the previous change to Fcopy_file.
6623 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6624 and without this change, GCC might complain about discarding
6625 fchown's return value.
6627 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
6629 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6631 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6633 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6635 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6637 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6638 it's used from the C level.
6640 * process.c: Use the same condition for POLL_FOR_INPUT in both
6641 keyboard.c and process.c (bug#1858).
6643 2011-07-09 Lawrence Mitchell <wence@gmx.li>
6645 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6646 (Fgnutls_boot): Use it.
6648 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6650 * doc.c (Fsubstitute_command_keys): Revert last change.
6652 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6654 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6655 quotes the next character, and doesn't affect other longer
6656 sequences (bug#8935).
6658 * lread.c (syms_of_lread): Clarify that is isn't only
6659 `eval-buffer' and `eval-defun' that's affected by
6660 `lexical-binding' (bug#8460).
6662 2011-07-15 Eli Zaretskii <eliz@gnu.org>
6664 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6665 bidi redisplay when a line includes both an image and is truncated.
6667 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6669 Fix minor problems found by static checking.
6670 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6671 (elsz): Now a signed constant, not a size_t var. We prefer signed
6672 types to unsigned, to avoid integer comparison confusion. Without
6673 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6674 "cannot optimize loop, the loop counter may overflow", a symptom
6676 * indent.c (Fvertical_motion): Mark locals as initialized.
6677 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6679 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6681 * search.c (Fre_search_backward): Mention `case-fold-search' in
6682 all the re_search_* functions (bug#8138).
6684 * keyboard.c (Fopen_dribble_file): Document when the file is
6687 2011-07-14 Eli Zaretskii <eliz@gnu.org>
6689 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6692 Support bidi reordering of display and overlay strings.
6693 * xdisp.c (compute_display_string_pos)
6694 (compute_display_string_end): Accept additional argument STRING.
6695 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6696 (reseat_to_string): Initialize bidi_it->string.s and
6697 bidi_it->string.schars.
6698 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
6699 NULL (avoids a crash in bidi_paragraph_init).
6700 Initialize itb.string.lstring.
6701 (init_iterator): Call bidi_init_it only of a valid
6702 buffer position was specified. Initialize paragraph_embedding to
6704 (reseat_to_string): Initialize the bidi iterator.
6705 (display_string): If we need to ignore text properties of
6706 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6707 original value of -1 will not work with bidi.)
6708 (compute_display_string_pos): First arg is now struct
6709 `text_pos *'; all callers changed. Support display properties on
6711 (compute_display_string_end): Support display properties on Lisp
6713 (init_iterator, reseat_1, reseat_to_string): Initialize the
6714 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6715 when iterating on a string not from display properties).
6716 (compute_display_string_pos, compute_display_string_end):
6717 Fix calculation of the object to scan. Fixes an error when using
6719 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
6720 base_level_stop; instead, set base_level_stop to BEGV.
6721 Fixes crashes in vertical-motion.
6722 (next_element_from_buffer): Improve commentary for when
6723 the iterator is before prev_stop.
6724 (init_iterator): Initialize bidi_p from the default value of
6725 bidi-display-reordering, not from buffer-local value. Use the
6726 buffer-local value only if initializing for buffer iteration.
6727 (handle_invisible_prop): Support invisible properties on strings
6728 that are being bidi-reordered.
6729 (set_iterator_to_next): Support bidi reordering of C strings and
6731 (next_element_from_string): Support bidi reordering of Lisp
6733 (handle_stop_backwards): Support Lisp strings as well.
6734 (display_string): Support display of R2L glyph rows.
6735 Use IT_STRING_CHARPOS when displaying from a Lisp string.
6736 (init_iterator): Don't initialize it->bidi_p for strings
6738 (reseat_to_string): Initialize it->bidi_p for strings here.
6739 (next_element_from_string, next_element_from_c_string)
6740 (next_element_from_buffer): Add xassert's for correspondence
6741 between IT's object being iterated and it->bidi_it.string
6743 (face_before_or_after_it_pos): Support bidi iteration.
6744 (next_element_from_c_string): Handle the case of the first string
6745 character that is not the first one in the visual order.
6746 (get_visually_first_element): New function, refactored from common
6747 parts of next_element_from_buffer, next_element_from_string, and
6748 next_element_from_c_string.
6749 (tool_bar_lines_needed, redisplay_tool_bar)
6750 (display_menu_bar): Force left-to-right direction. Add a FIXME
6751 comment for making that be controlled by a user option.
6752 (push_it, pop_it): Save and restore the state of the
6753 bidi iterator. Save and restore the bidi_p flag.
6754 (pop_it): Iterate out of display property for string iteration as
6756 (iterate_out_of_display_property): Support iteration over strings.
6757 (handle_single_display_spec): Set up it->bidi_it for iteration
6758 over a display string, and call bidi_init_it.
6759 (handle_single_display_spec, next_overlay_string)
6760 (get_overlay_strings_1, push_display_prop): Set up the bidi
6761 iterator for displaying display or overlay strings.
6762 (forward_to_next_line_start): Don't use the shortcut if
6764 (back_to_previous_visible_line_start): If handle_display_prop
6765 pushed the iterator stack, restore the internal state of the bidi
6766 iterator by calling bidi_pop_it same number of times.
6767 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6768 and we are bidi-iterating, don't decrement the iterator position;
6769 instead, set the first_elt flag in the bidi iterator, to produce
6771 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6772 (push_display_prop): xassert that we are iterating a buffer.
6773 (push_it, pop_it): Save and restore paragraph_embedding member.
6774 (handle_single_display_spec, next_overlay_string)
6775 (get_overlay_strings_1, reseat_1, reseat_to_string)
6776 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6777 correctly. Don't assume unibyte strings are not bidi-reordered.
6778 (compute_display_string_pos)
6779 (compute_display_string_end): Fix handling the case of C string.
6780 (push_it, pop_it): Save and restore from_disp_prop_p.
6781 (handle_single_display_spec, push_display_prop): Set the
6782 from_disp_prop_p flag.
6783 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6784 (pop_it): Call iterate_out_of_display_property only if we are
6785 popping after iteration over a string that came from a display
6786 property. Fix a typo in popping stretch info. Add an assertion
6787 for verifying that the iterator position is in sync with the bidi
6789 (handle_single_display_spec, get_overlay_strings_1)
6790 (push_display_prop): Fix initialization of paragraph direction for
6791 string when that of the parent object is not yet determined.
6792 (reseat_1): Call bidi_init_it to resync the bidi
6793 iterator with IT's position. (Bug#7616)
6794 (find_row_edges): If ROW->start.pos gives position
6795 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6796 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6797 Reset the from_disp_prop_p flag.
6798 (SAVE_IT, RESTORE_IT): New macros.
6799 (pos_visible_p, face_before_or_after_it_pos)
6800 (back_to_previous_visible_line_start)
6801 (move_it_in_display_line_to, move_it_in_display_line)
6802 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6803 (try_scrolling, redisplay_window, display_line): Use them when
6804 saving a temporary copy of the iterator and restoring it back.
6805 (back_to_previous_visible_line_start, reseat_1)
6806 (init_iterator): Empty the bidi cache "stack".
6807 (move_it_in_display_line_to): If iterator ended up at
6808 EOL, but we never saw any buffer positions smaller than
6809 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6810 motion in bidi-reordered lines.
6811 (move_it_in_display_line_to): Record prev_method and prev_pos
6812 immediately before the call to set_iterator_to_next. Fixes cursor
6813 motion in bidi-reordered lines with stretch glyphs and strings
6814 displayed in margins. (Bug#8133) (Bug#8867)
6815 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6817 (pos_visible_p): Support positions in bidi-reordered lines.
6818 Save and restore bidi cache.
6820 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6821 (bidi_paragraph_info): Delete unused struct.
6822 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6823 (bidi_cache_start): New variable.
6824 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6826 (bidi_cache_fetch_state, bidi_cache_search)
6827 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6828 (bidi_cache_find, bidi_peek_at_next_level)
6829 (bidi_level_of_next_char, bidi_find_other_level_edge)
6830 (bidi_move_to_visually_next): Compare cache index with
6831 bidi_cache_start rather than with zero.
6832 (bidi_fetch_char): Accept new argument STRING; all callers
6833 changed. Support iteration over a string. Support strings with
6834 display properties. Support unibyte strings. Fix the type of
6835 `len' according to what STRING_CHAR_AND_LENGTH expects.
6836 (bidi_paragraph_init, bidi_resolve_explicit_1)
6837 (bidi_resolve_explicit, bidi_resolve_weak)
6838 (bidi_level_of_next_char, bidi_move_to_visually_next):
6839 Support iteration over a string.
6840 (bidi_set_sor_type, bidi_resolve_explicit_1)
6841 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6842 can now be zero (for strings); special values 0 and -1 were
6843 changed to -1 and -2, respectively.
6844 (bidi_char_at_pos): New function.
6845 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6846 Call it instead of FETCH_MULTIBYTE_CHAR.
6847 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6848 initialized to valid values.
6849 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6851 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6852 the test for valid cached positions. Fix the logic for looking up
6853 the sentinel state in the cache. GCPRO the Lisp string we are
6855 (bidi_push_it, bidi_pop_it): New functions.
6856 (bidi_initialize): Initialize the bidi cache start stack pointer.
6857 (bidi_cache_ensure_space): New function, refactored from part of
6858 bidi_cache_iterator_state. Don't assume the required size is just
6859 one BIDI_CACHE_CHUNK away.
6860 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6861 (bidi_count_bytes, bidi_char_at_pos): New functions.
6862 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6863 always valid if bidi_cache_idx is valid.
6864 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6865 is valid if it's going to be used.
6866 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6867 (bidi_cache_fetch_state, bidi_cache_search)
6868 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6869 (bidi_cache_iterator_state, bidi_cache_find)
6870 (bidi_find_other_level_edge, bidi_cache_start_stack):
6871 All variables related to cache indices are now EMACS_INT.
6873 * dispextern.h (struct bidi_string_data): New structure.
6874 (struct bidi_it): New member `string'. Make flag members be 1-bit
6875 fields, and put them last in the struct.
6876 (compute_display_string_pos, compute_display_string_end):
6878 (bidi_push_it, bidi_pop_it): Add prototypes.
6879 (struct iterator_stack_entry): New members bidi_p,
6880 paragraph_embedding, and from_disp_prop_p.
6881 (struct it): Member bidi_p is now a bit field 1 bit wide.
6882 (bidi_shelve_cache, bidi_unshelve_cache):
6885 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6886 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6887 and vector-like objects.
6889 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6890 cache around display iteration.
6892 * window.c (Fwindow_end, window_scroll_pixel_based)
6893 (displayed_window_lines, Frecenter): Save and restore the bidi
6894 cache around display iteration.
6896 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6898 * editfns.c (Fdelete_region): Clarify the use of the named
6899 parameters (bug#6788).
6901 2011-07-14 Martin Rudalics <rudalics@gmx.at>
6903 * indent.c (Fvertical_motion): Set and restore w->pointm when
6904 saving and restoring the window's buffer (Bug#9006).
6906 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6908 * editfns.c (Fstring_to_char): Clarify just what is returned
6909 (bug#6576). Text by Eli Zaretskii.
6911 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
6913 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6915 2011-07-13 Eli Zaretskii <eliz@gnu.org>
6917 * buffer.c (mmap_find): Fix a typo.
6919 2011-07-13 Johan Bockgård <bojohan@gnu.org>
6921 Fix execution of x selection hooks.
6922 * xselect.c (Qx_lost_selection_functions)
6923 (Qx_sent_selection_functions): New vars.
6924 (syms_of_xselect): DEFSYM them.
6925 (x_handle_selection_request): Pass Qx_sent_selection_functions
6926 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6927 (x_handle_selection_clear,x_clear_frame_selections):
6928 Pass Qx_lost_selection_functions rather than
6929 Vx_lost_selection_functions to Frun_hook_with_args.
6931 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6933 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
6934 The old code sometimes used this field without initializing it.
6936 * alloc.c (gc_sweep): Don't read past end of array.
6937 In theory, the old code could also have corrupted Emacs internals,
6938 though it'd be very unlikely.
6940 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6942 * character.c (Fcharacterp): Don't advertise optional ignored
6943 argument. (Bug#4026)
6945 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6947 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6950 * window.c (Fset_window_start): Doc fix (bug#4199).
6951 (Fset_window_hscroll): Ditto.
6953 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6955 Fix minor new problems caught by GCC 4.6.1.
6956 * term.c (init_tty): Remove unused local.
6957 * xsettings.c (store_monospaced_changed): Define this function only
6958 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
6961 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
6963 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6965 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6967 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6968 are the mini-buffer and the echo area (bug#3320).
6970 * term.c (init_tty): Remove support for supdup, c10 and perq
6971 terminals, which are no longer supported (bug#1482).
6973 2011-07-10 Johan Bockgård <bojohan@gnu.org>
6975 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6977 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6979 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6980 for non-popups (Bug#3642).
6982 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6984 * alloc.c (reset_malloc_hooks): Protoize.
6985 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
6986 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6987 * cm.c (losecursor): Likewise.
6988 * data.c (fmod): Likewise.
6989 * dispnew.c (swap_glyphs_in_rows): Likewise.
6990 * emacs.c (memory_warning_signal): Likewise.
6991 * floatfns.c (float_error): Likewise.
6992 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6993 (otf_open, font_otf_capability, generate_otf_features)
6994 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6996 * image.c (pbm_read_file): Likewise.
6997 * indent.c (string_display_width): Likewise.
6998 * intervals.c (check_for_interval, search_for_interval)
6999 (inc_interval_count, count_intervals, root_interval)
7000 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7001 * lread.c (defalias): Likewise.
7002 * ralloc.c (r_alloc_check): Likewise.
7003 * regex.c (set_image_of_range_1, set_image_of_range)
7004 (regex_grow_registers): Likewise.
7005 * sysdep.c (strerror): Likewise.
7006 * termcap.c (valid_filename_p, tprint, main): Likewise.
7007 * tparam.c (main): Likewise.
7008 * unexhp9k800.c (run_time_remap, save_data_space)
7009 (update_file_ptrs, read_header, write_header, calculate_checksum)
7010 (copy_file, copy_rest, display_header): Likewise.
7011 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7013 * xdisp.c (check_it): Likewise.
7014 * xfaces.c (register_color, unregister_color, unregister_colors):
7016 * xfns.c (print_fontset_result): Likewise.
7017 * xrdb.c (member, fatal, main): Likewise.
7019 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7021 Fix minor problems found by static checking (Bug#9031).
7022 * chartab.c (char_table_set_range, map_sub_char_table):
7023 Remove unused locals.
7024 (uniprop_table): Now static.
7025 * composite.c (_work_char): Remove unused static var.
7027 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
7029 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7031 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7033 * gtkutil.c (qttip_cb): Remove code without function.
7035 2011-07-09 Eli Zaretskii <eliz@gnu.org>
7037 * w32.c (pthread_sigmask): New stub.
7039 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
7041 Use pthread_sigmask, not sigprocmask (Bug#9010).
7042 sigprocmask is portable only for single-threaded applications, and
7043 Emacs can be multi-threaded when it uses GTK.
7044 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7046 * callproc.c (Fcall_process):
7047 * process.c (create_process):
7048 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7049 Use pthread_sigmask, not sigprocmask.
7051 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7053 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7054 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7057 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7059 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7060 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7061 (xg_hide_tooltip): Fix comment.
7063 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7064 in registerServicesMenuSendTypes.
7065 (validRequestorForSendType): Don't check ns_return_types.
7067 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7070 2011-07-08 Jason Rumney <jasonr@gnu.org>
7072 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7073 SH_SHOW for hidden windows (Bug#5482).
7075 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7076 frame struct members of non-existent frames (Bug#6284).
7078 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7080 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7081 variable firstTime not needed on OSX >= 10.6.
7082 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7083 >= 10.5. Use setKnobProportion, setDoubleValue.
7085 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7086 (MAC_OS_X_VERSION_10_5): Define if not defined.
7087 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7088 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7089 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7091 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7092 cString and lossyCString on OSX >= 10.4
7094 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
7095 sizeToFit on OSX >= 10.2.
7097 * nsimage.m (allocInitFromFile): Don't use deprecated method
7098 bestRepresentationForDevice on OSX >= 10.6.
7100 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7103 * emacs.c: Declare unexec_init_emacs_zone.
7105 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7107 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7109 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7110 on svcsMenu (Bug#8842).
7112 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7114 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7116 * nsterm.m (QUTF8_STRING): Declare.
7117 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7118 (validRequestorForSendType): Return type is (id).
7119 Change indexOfObjectIdenticalTo to indexOfObject.
7120 Check if we have local selection before returning self (Bug#8842).
7121 (writeSelectionToPasteboard): Put local selection into paste board
7122 if we have a local selection (Bug#8842).
7123 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7125 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7126 (ns_get_local_selection): Declare.
7128 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7130 * keymap.c (describe_map_tree): Don't insert a double newline at
7131 the end of the buffer (bug#1169) and return whether we inserted
7134 * callint.c (Fcall_interactively): Change "reading args" to
7135 "providing args" to try to clarify what it does (bug#1010).
7137 2011-07-07 Kenichi Handa <handa@m17n.org>
7139 * composite.c (composition_compute_stop_pos): Ignore a static
7140 composition starting before CHARPOS (Bug#8915).
7142 * xdisp.c (handle_composition_prop): Likewise.
7144 2011-07-07 Eli Zaretskii <eliz@gnu.org>
7146 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7149 2011-07-07 Kenichi Handa <handa@m17n.org>
7151 * character.h (unicode_category_t): New enum type.
7153 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7154 (Qchar_code_property_table): New variable.
7155 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7156 (UNIPROP_COMPRESSED_FORM_P): New macros.
7157 (char_table_ascii): Uncompress the compressed values.
7158 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7159 Uncompress the compressed values.
7160 (sub_char_table_ref_and_range): Likewise.
7161 (char_table_ref_and_range): Uncompress the compressed values.
7162 (sub_char_table_set): New arg is_uniprop. Callers changed.
7163 Uncompress the compressed values.
7164 (sub_char_table_set_range): Args changed. Callers changed.
7165 (char_table_set_range): Adjuted for the above change.
7166 (map_sub_char_table): Delete args default_val and parent. Add arg
7167 top. Give decoded values to a Lisp function.
7168 (map_char_table): Adjust for the above change. Give decoded
7169 values to a Lisp function. Gcpro more variables.
7170 (uniprop_table_uncompress)
7171 (uniprop_decode_value_run_length): New functions.
7172 (uniprop_decoder, uniprop_decoder_count): New variables.
7173 (uniprop_get_decoder, uniprop_encode_value_character)
7174 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7176 (uniprop_encoder, uniprop_encoder_count): New variables.
7177 (uniprop_get_encoder, uniprop_table)
7178 (Funicode_property_table_internal, Fget_unicode_property_internal)
7179 (Fput_unicode_property_internal): New functions.
7180 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7181 Sunicode_property_table_internal, Sget_unicode_property_internal,
7182 and Sput_unicode_property_internal. Defvar_lisp
7183 char-code-property-alist.
7185 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
7186 Vunicode_category_table.
7188 * font.c (font_range): Adjust for the change of
7189 Vunicode_category_table.
7191 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7193 * m/iris4d.h: Remove file, move contents ...
7194 * s/irix6-5.h: ... here.
7196 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7198 Remove unportable assumption about struct layout (Bug#8884).
7199 * alloc.c (mark_buffer):
7200 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7201 (clone_per_buffer_values): Don't assume that
7202 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7203 This isn't true in general, and it's particularly not true
7204 if Emacs is configured with --with-wide-int.
7205 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7206 New macros, used in the buffer.c change.
7208 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7210 * xsettings.c: Use both GConf and GSettings if both are available.
7211 (store_config_changed_event): Add comment.
7212 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7213 (store_tool_bar_style_changed): New functions.
7214 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
7215 (struct xsettings): Move font inside HAVE_XFT.
7216 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
7217 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
7218 Move inside HAVE_XFT.
7219 (something_changed_gsettingsCB): Rename from something_changedCB.
7220 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7222 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
7223 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
7224 (something_changed_gconfCB): Rename from something_changedCB.
7225 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7226 (parse_settings): Move check for font inside HAVE_XFT.
7227 (read_settings, apply_xft_settings): Add comment.
7228 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7229 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7230 call store_font_name_changed.
7231 (xft_settings_event): Add comment.
7232 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7233 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7234 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7235 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7236 (xsettings_initialize): Call init_gsettings last.
7237 (xsettings_get_system_font, xsettings_get_system_normal_font):
7240 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7242 Random fixes. E.g., (random) never returned negative values.
7243 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7244 subseconds part to the entropy, as that's a bit more random.
7245 Prefer signed to unsigned, since the signedness doesn't matter and
7246 in general we prefer signed. When given a limit, use a
7247 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7248 latter isn't right if USE_2_TAGS_FOR_INTS.
7249 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7250 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7252 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7254 * textprop.c (text_property_stickiness):
7255 Obey Vtext_property_default_nonsticky.
7256 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7257 * w32fns.c (syms_of_w32fns):
7258 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7260 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7262 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7263 This is more efficient than Ffile_directory_p and avoids a minor race.
7265 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7267 * buffer.c (Foverlay_put): Say what the return value is
7270 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7271 is a directory before asking whether to use the file name
7273 (barf_or_query_if_file_exists): Make the "File is a directory"
7274 error be more correct.
7276 * fns.c (Frequire): Remove the mention of the .gz files, since
7277 that's installation-specific, but keep the mention of
7278 `get-load-suffixes'.
7280 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7282 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7283 Report string overflow if the output is too long.
7285 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
7287 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7288 (syms_of_gnutls): Remove duplicate DEFSYM for
7289 Qgnutls_bootprop_verify_hostname_error, an error for
7290 Qgnutls_bootprop_verify_error (which is no longer used).
7292 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7293 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7294 Also (re)move comments that are misplaced or no longer relevant.
7296 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7298 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7300 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
7302 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7303 and background color parameters if they have been changed.
7305 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7307 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7309 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7311 * xsettings.c (SYSTEM_FONT): Define only when used.
7312 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7314 * keymap.c (access_keymap_1): Now static.
7316 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
7318 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7319 leave any prefix arg for the up event (Bug#1586).
7321 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7323 * lread.c (syms_of_lread): Mention single symbols defined by
7324 `defvar' or `defconst' (bug#7154).
7326 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7327 (Frequire): Mention get-load-suffixes.
7329 2011-07-02 Martin Rudalics <rudalics@gmx.at>
7331 * window.h (window): Remove clone_number slot.
7332 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7334 (make_parent_window, make_window, saved_window)
7335 (Fset_window_configuration, save_window_save): Don't deal with
7337 * buffer.c (Qclone_number): Remove declaration.
7338 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7340 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7342 Add multiple inheritance to keymaps.
7343 * keymap.c (Fmake_composed_keymap): New function.
7344 (Fset_keymap_parent): Simplify.
7345 (fix_submap_inheritance): Remove.
7346 (access_keymap_1): New function extracted from access_keymap to handle
7347 embedded parents and handle lists of maps.
7348 (access_keymap): Use it.
7349 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7350 (Fcopy_keymap): Handle embedded parents.
7351 (Fcommand_remapping, define_as_prefix): Simplify.
7352 (Fkey_binding): Simplify.
7353 (syms_of_keymap): Move minibuffer-local-completion-map,
7354 minibuffer-local-filename-completion-map,
7355 minibuffer-local-must-match-map, and
7356 minibuffer-local-filename-must-match-map to Elisp.
7357 (syms_of_keymap): Defsubr make-composed-keymap.
7358 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7359 (parse_menu_item): Trivial simplification.
7361 2011-07-01 Glenn Morris <rgm@gnu.org>
7363 * Makefile.in (SETTINGS_LIBS): Fix typo.
7365 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7367 * coding.c (Fencode_coding_string): Record the last coding system
7368 used, as the function doc string says (bug#8738).
7370 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7372 * xsettings.c (store_monospaced_changed): Take new font as arg and
7373 check for change against current_mono_font.
7374 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7375 (emacs_settings_constructor, emacs_settings_get_property)
7376 (emacs_settings_set_property, emacs_settings_class_init)
7377 (emacs_settings_init, gsettings_obj): Remove.
7378 (something_changedCB): New function for HAVE_GSETTINGS.
7379 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7380 with value as argument.
7381 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7382 g_settings_new (Bug#8967). Do not create gsettings_obj.
7383 Remove calls to g_settings_bind. Connect something_changedCB to
7386 * xgselect.c: Add defined (HAVE_GSETTINGS).
7387 (xgselect_initialize): Ditto.
7389 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7390 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7393 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7395 * eval.c (struct backtrace): Simplify and port the data structure.
7396 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7397 signed bit field, as this assumption is not portable and it makes
7398 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7399 "char debug_on_exit : 1" as this is not portable either; instead,
7400 use the portable "unsigned int debug_on_exit : 1". Remove unused
7401 member evalargs. Remove obsolete comments about cc bombing out.
7403 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7405 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
7406 Let HAVE_GSETTINGS override HAVE_GCONF.
7407 (store_monospaced_changed): New function.
7408 (EMACS_SETTINGS): A new type derived from GObject to handle
7409 GSettings notifications.
7410 (emacs_settings_constructor, emacs_settings_get_property)
7411 (emacs_settings_set_property, emacs_settings_class_init):
7413 (gsettings_client, gsettings_obj): New variables.
7414 (GSETTINGS_SCHEMA): New define.
7415 (something_changedCB): Call store_monospaced_changed.
7416 (init_gsettings): New function.
7417 (xsettings_initialize): Call init_gsettings.
7418 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7421 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
7424 2011-06-29 Martin Rudalics <rudalics@gmx.at>
7426 * window.c (resize_root_window, grow_mini_window)
7427 (shrink_mini_window): Rename Qresize_root_window to
7428 Qwindow_resize_root_window and Qresize_root_window_vertically to
7429 Qwindow_resize_root_window_vertically.
7431 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7433 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7435 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
7437 * makefile.w32-in: Redesign dependencies so they reflect more
7438 clearly which files are directly included by each source file,
7439 and not through other includes.
7441 2011-06-27 Martin Rudalics <rudalics@gmx.at>
7443 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7444 (sort_overlays, overlay_strings): When an overlay's clone number
7445 matches the window's clone number process the overlay even if
7446 the overlay's window property doesn't match the current window.
7448 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7449 (Fwindow_hchild): Rename to Fwindow_left_child.
7450 (Fwindow_next): Rename to Fwindow_next_sibling.
7451 (Fwindow_prev): Rename to Fwindow_prev_sibling.
7452 (resize_window_check): Rename to window_resize_check.
7453 (resize_window_apply): Rename to window_resize_apply.
7454 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7455 (Fdelete_other_windows_internal, resize_frame_windows)
7456 (Fsplit_window_internal, Fdelete_window_internal)
7457 (grow_mini_window, shrink_mini_window)
7458 (Fresize_mini_window_internal): Fix callers accordingly.
7460 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7462 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7463 (emacs_fixed_set_min_size): Remove.
7464 (emacs_fixed_new): Take frame as argument.
7466 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7467 (_EmacsFixedPrivate): Remove minwidth/height.
7468 Add struct frame *f.
7469 (emacs_fixed_init): Initialize priv->f.
7470 (get_parent_class, emacs_fixed_set_min_size): Remove.
7471 (emacs_fixed_new): Set priv->f to argument.
7472 (emacs_fixed_get_preferred_width)
7473 (emacs_fixed_get_preferred_height): Use min_width/height from
7474 frames size_hint to set minimum and natural (Bug#8919).
7475 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7476 and use min_width/height from frames size_hint to set
7477 min_width/height (Bug#8919).
7479 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
7480 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7483 2011-06-26 Eli Zaretskii <eliz@gnu.org>
7485 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7486 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7489 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
7491 * process.c (wait_reading_process_output): Bypass select if
7492 waiting for a cell while ignoring keyboard input, and input is
7493 pending. Suggested by Jan Djärv (Bug#8869).
7495 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7497 Use gnulib's dup2 module instead of rolling our own.
7498 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7500 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7502 * dispnew.c (scrolling_window): Before scrolling, turn off a
7503 mouse-highlight in the window being scrolled.
7505 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
7507 Move DEFSYM to lisp.h and use everywhere.
7509 * character.h (DEFSYM): Move declaration...
7510 * lisp.h (DEFSYM): ...here.
7516 * w32select.c: Don't include character.h.
7518 * alloc.c (syms_of_alloc):
7519 * buffer.c (syms_of_buffer):
7520 * bytecode.c (syms_of_bytecode):
7521 * callint.c (syms_of_callint):
7522 * casefiddle.c (syms_of_casefiddle):
7523 * casetab.c (init_casetab_once):
7524 * category.c (init_category_once, syms_of_category):
7525 * ccl.c (syms_of_ccl):
7526 * cmds.c (syms_of_cmds):
7527 * composite.c (syms_of_composite):
7528 * dbusbind.c (syms_of_dbusbind):
7529 * dired.c (syms_of_dired):
7530 * dispnew.c (syms_of_display):
7531 * doc.c (syms_of_doc):
7532 * editfns.c (syms_of_editfns):
7533 * emacs.c (syms_of_emacs):
7534 * eval.c (syms_of_eval):
7535 * fileio.c (syms_of_fileio):
7536 * fns.c (syms_of_fns):
7537 * frame.c (syms_of_frame):
7538 * fringe.c (syms_of_fringe):
7539 * insdel.c (syms_of_insdel):
7540 * keymap.c (syms_of_keymap):
7541 * lread.c (init_obarray, syms_of_lread):
7542 * macros.c (syms_of_macros):
7543 * msdos.c (syms_of_msdos):
7544 * print.c (syms_of_print):
7545 * process.c (syms_of_process):
7546 * search.c (syms_of_search):
7547 * sound.c (syms_of_sound):
7548 * syntax.c (init_syntax_once, syms_of_syntax):
7549 * terminal.c (syms_of_terminal):
7550 * textprop.c (syms_of_textprop):
7551 * undo.c (syms_of_undo):
7552 * w32.c (globals_of_w32):
7553 * window.c (syms_of_window):
7554 * xdisp.c (syms_of_xdisp):
7555 * xfaces.c (syms_of_xfaces):
7556 * xfns.c (syms_of_xfns):
7557 * xmenu.c (syms_of_xmenu):
7558 * xsettings.c (syms_of_xsettings):
7559 * xterm.c (syms_of_xterm): Use DEFSYM.
7561 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7563 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
7565 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7567 Integer and buffer overflow fixes (Bug#8873).
7569 * print.c (printchar, strout): Check for string overflow.
7570 (PRINTPREPARE, printchar, strout):
7571 Don't set size unless allocation succeeds.
7573 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7574 for sizes. Check for string overflow more accurately.
7575 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7577 * macros.c: Integer and buffer overflow fixes.
7578 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7579 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7580 Use ptrdiff_t, not int, for sizes.
7581 Don't increment bufsize until after realloc succeeds.
7582 Check for size-calculation overflow.
7583 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7585 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7587 * lread.c: Integer overflow fixes.
7588 (read_integer): Radix is now EMACS_INT, not int,
7589 to improve quality of diagnostics for out-of-range radices.
7590 Calculate buffer size correctly for out-of-range radices.
7591 (read1): Check for integer overflow in radices, and in
7592 read-circle numbers.
7593 (read_escape): Avoid int overflow.
7594 (Fload, openp, read_buffer_size, read1)
7595 (substitute_object_recurse, read_vector, read_list, map_obarray):
7596 Use ptrdiff_t, not int, for sizes.
7597 (read1): Use EMACS_INT, not int, for sizes.
7598 Check for size overflow.
7600 * image.c (cache_image): Check for size arithmetic overflow.
7602 * lread.c: Integer overflow issues.
7603 (saved_doc_string_size, saved_doc_string_length)
7604 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7605 Now ptrdiff_t, not int.
7606 (read1): Don't assume doc string length fits in int. Check for
7607 out-of-range doc string lengths.
7608 (read_list): Don't assume file position fits in int.
7609 (read_escape): Check for hex character overflow.
7611 2011-06-22 Leo Liu <sdl.web@gmail.com>
7613 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7614 Move to minibuffer.el.
7616 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7618 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
7619 The following patches are for when GLYPH_DEBUG && !XASSERT.
7620 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7621 * dispnew.c (flush_stdout):
7622 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7623 Mark as externally visible.
7624 * dispnew.c (check_window_matrix_pointers): Now static.
7625 * dispnew.c (window_to_frame_vpos):
7626 * xfns.c (unwind_create_frame):
7627 * xterm.c (x_check_font): Remove unused local.
7628 * scroll.c (CHECK_BOUNDS):
7629 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7630 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7631 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7632 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7633 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7635 (debug_method_add): Use va_list and vsprintf rather than relying
7636 on undefined behavior with wrong number of arguments.
7637 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7638 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7639 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7640 since we're not interested in debugging glyphs with old libraries.
7641 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7642 GCC 4.6.0's static checking.
7644 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7646 Integer overflow and signedness fixes (Bug#8873).
7647 A few related buffer overrun fixes, too.
7649 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7651 * dispextern.h (struct face.stipple):
7652 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7653 (x_bitmap_mask, x_allocate_bitmap_record)
7654 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7655 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7656 (x_create_bitmap_from_xpm_data):
7657 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7658 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7660 * xfaces.c (load_pixmap):
7661 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7662 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7663 (.bitmaps_last, struct x_output.icon_bitmap):
7664 Use ptrdiff_t, not int, for bitmap indexes.
7665 (x_allocate_bitmap_record): Check for size overflow.
7666 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7668 Use ptrdiff_t, not int, for overlay counts.
7669 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7670 * editfns.c (overlays_around, get_pos_property):
7671 * textprop.c (get_char_property_and_overlay):
7672 * xdisp.c (next_overlay_change, note_mouse_highlight):
7673 * xfaces.c (face_at_buffer_position):
7674 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7675 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7676 (Fnext_overlay_change, Fprevious_overlay_change)
7677 (mouse_face_overlay_overlaps, Foverlays_in):
7678 Use ptrdiff_t, not int, for sizes.
7679 (overlays_at, overlays_in): Check for size-calculation overflow.
7681 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7683 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7684 (x_session_initialize): Do not assume string length fits in int.
7686 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7687 This is unlikely, but can occur if DPI is outlandish.
7689 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
7690 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7692 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7693 * xrdb.c (magic_file_p, search_magic_path):
7694 Omit last arg SUFFIX; it was always 0. All callers changed.
7695 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7697 * xfont.c (xfont_match): Avoid need for strlen.
7699 * xfns.c: Don't assume strlen fits in int.
7700 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7702 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7703 not unsigned long, as we prefer signed integers. All callers changed.
7704 Detect integer overflow in repeat count.
7705 (message_dolog): Don't assume print length fits in 39 bytes.
7706 (display_mode_element): Don't assume strlen fits in int.
7708 * termcap.c: Don't assume sizes fit in int and never overflow.
7709 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7710 (gobble_line): Check for size-calculation overflow.
7712 * minibuf.c (Fread_buffer):
7713 * lread.c (intern, intern_c_string):
7714 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7715 Don't assume string length fits in int.
7717 * keyboard.c (parse_tool_bar_item):
7718 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7720 * font.c: Don't assume string length fits in int.
7721 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7722 Use ptrdiff_t, not int.
7723 (font_intern_prop): Don't assume string length fits in int.
7724 Don't assume integer property fits in fixnum.
7725 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
7727 * filelock.c: Fix some buffer overrun and integer overflow issues.
7728 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
7729 Reformulate so as not to need the command string.
7730 Invoke gzip -cd rather than gunzip, as it's more portable.
7731 (lock_info_type, lock_file_1, lock_file):
7732 Don't assume pid_t and time_t fit in unsigned long.
7733 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7734 (current_lock_owner): Prefer signed type for sizes.
7735 Use memcpy, not strncpy, where memcpy is what is really wanted.
7736 Don't assume (via atoi) that time_t and pid_t fit in int.
7737 Check for time_t and/or pid_t out of range, e.g., via a network share.
7738 Don't alloca where an auto var works fine.
7740 * fileio.c: Fix some integer overflow issues.
7741 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7742 Don't assume string length fits in int.
7743 (directory_file_name): Don't assume string length fits in long.
7744 (make_temp_name): Don't assume pid fits in int, or that its print
7745 length is less than 20.
7747 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7749 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7751 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7753 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7754 We prefer signed integers, even for size calculations.
7756 * emacs.c: Don't assume string length fits in 'int'.
7757 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7758 (main): Don't invoke strlen when not needed.
7760 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7761 (XD_DEBUG_MESSAGE): Don't waste a byte.
7763 * callproc.c (getenv_internal_1, getenv_internal)
7765 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7767 * lread.c (invalid_syntax): Omit length argument.
7768 All uses changed. This doesn't fix a bug, but it simplifies the
7769 code away from its former Hollerith-constant appearance, and it's
7770 one less 'int' to worry about when looking at integer-overflow issues.
7771 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
7773 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7774 This didn't break anything, but it didn't help either.
7775 It's confusing to put a bogus integer in a place where the actual
7776 value does not matter.
7777 (LIST_END_P): Remove unused macro and its bogus comment.
7778 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
7780 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7781 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7783 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7784 We prefer signed types, and the value cannot exceed the EMACS_INT
7785 range anyway (because otherwise the length would not be representable).
7786 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7787 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7788 This avoids a GCC warning when WIDE_EMACS_INT.
7790 * indent.c (sane_tab_width): New function.
7791 (current_column, scan_for_column, Findent_to, position_indentation)
7792 (compute_motion): Use it. This is just for clarity.
7793 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
7795 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
7797 * lisp.h (lint_assume): New macro.
7798 * composite.c (composition_gstring_put_cache):
7799 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7801 * editfns.c, insdel.c:
7802 Omit unnecessary forward decls, to simplify future changes.
7804 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7806 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7808 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
7809 Use much-faster test for byte-length change.
7810 Don't assume string byte-length fits in 'int'.
7811 Check that character arg fits in 'int'.
7812 (mapcar1): Declare byte as byte, for clarity.
7814 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7816 * fns.c (concat): Catch string overflow earlier.
7817 Do not rely on integer wraparound.
7819 * dispextern.h (struct it.overlay_strings_charpos)
7820 (struct it.selective): Now EMACS_INT, not int.
7821 * xdisp.c (forward_to_next_line_start)
7822 (back_to_previous_visible_line_start)
7823 (reseat_at_next_visible_line_start, next_element_from_buffer):
7824 Don't arbitrarily truncate the value of 'selective' to int.
7826 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7828 * composite.c: Don't truncate sizes to 'int'.
7829 (composition_gstring_p, composition_reseat_it)
7830 (composition_adjust_point): Use EMACS_INT, not int.
7831 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7832 not EMACS_UINT, for indexes.
7834 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7836 * buffer.c: Include <verify.h>.
7837 (struct sortvec.priority, struct sortstr.priority):
7838 Now EMACS_INT, not int.
7839 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
7840 (struct sortstr.size, record_overlay_string)
7841 (struct sortstrlist.size, struct sortlist.used):
7842 Don't truncate size to int.
7843 (record_overlay_string): Check for size-calculation overflow.
7844 (init_buffer_once): Check at compile-time, not run-time.
7846 2011-06-22 Jim Meyering <meyering@redhat.com>
7848 Don't leak an XBM-image-sized buffer
7849 * image.c (xbm_load): Free the image buffer after using it.
7851 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7854 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7855 that Sun C diagnosed.
7856 * fns.c (secure_hash): Fix pointer signedness issue.
7857 * intervals.c (static_offset_intervals): New function.
7858 (offset_intervals): Use it.
7860 2011-06-21 Leo Liu <sdl.web@gmail.com>
7863 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7866 * fns.c (secure_hash): Rename from crypto_hash_function and change
7867 the first arg to accept symbols.
7868 (Fsecure_hash): New primitive.
7869 (syms_of_fns): New symbols.
7871 2011-06-20 Deniz Dogan <deniz@dogan.se>
7873 * process.c (Fset_process_buffer): Clarify return value in
7876 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
7878 * dispnew.c (add_window_display_history): Use BVAR.
7880 * xdisp.c (debug_method_add): Use BVAR.
7881 (check_window_end, dump_glyph_matrix, dump_glyph)
7882 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7884 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7887 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7888 check till after the cache is created in init_frame_faces.
7890 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7892 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7894 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7896 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7897 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7898 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7900 Improve buffer-overflow checking (Bug#8873).
7901 * fileio.c (Finsert_file_contents):
7902 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7903 Remove the old (too-loose) buffer overflow checks.
7904 They weren't needed, since make_gap checks for buffer overflow.
7905 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7906 The old code merely checked for Emacs fixnum overflow, and relied
7907 on undefined (wraparound) behavior. The new code avoids undefined
7908 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7910 * editfns.c (Finsert_char): Don't dump core with very negative counts.
7911 Tune. Don't use wider integers than needed. Don't use alloca.
7912 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
7914 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7916 * insdel.c, lisp.h (buffer_overflow): New function.
7917 (insert_from_buffer_1, replace_range, replace_range_2):
7918 * insdel.c (make_gap_larger):
7919 * editfns.c (Finsert_char):
7920 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7922 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7924 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7926 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
7928 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7929 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7931 * fileio.c: Don't assume EMACS_INT fits in off_t.
7932 (emacs_lseek): New static function.
7933 (Finsert_file_contents, Fwrite_region): Use it.
7934 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7936 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7938 * fns.c: Don't overflow int when computing a list length.
7939 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7940 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7941 truncation on 64-bit hosts. Check for QUIT every
7942 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7943 faster and is responsive enough.
7944 (Flength): Report an error instead of overflowing an integer.
7945 (Fsafe_length): Return a float if the value is not representable
7946 as a fixnum. This shouldn't happen except in contrived situations.
7947 (Fnthcdr, Fsort): Don't assume list length fits in int.
7948 (Fcopy_sequence): Don't assume vector length fits in int.
7950 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7951 (header_size, word_size): New constants.
7952 (allocate_vectorlike): Don't check size overflow here.
7953 (allocate_vector): Check it here instead, since this is the only
7954 caller of allocate_vectorlike that could cause overflow.
7955 Check that the new vector's length is representable as a fixnum.
7957 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7958 The previous code was bogus. For example, next_almost_prime (32)
7959 returned 39, which is undesirable as it is a multiple of 3; and
7960 next_almost_prime (24) returned 25, which is a multiple of 5 so
7961 why was the code bothering to check for multiples of 7?
7963 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7965 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7967 Variadic C functions now count arguments with ptrdiff_t.
7968 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7969 Back then I didn't know that the Emacs coding style prefers signed int.
7970 Also, in the meantime I found a few more instances where arguments
7971 were being counted with int, which may truncate counts on 64-bit
7972 machines, or EMACS_INT, which may be unnecessarily wide.
7973 * lisp.h (struct Lisp_Subr.function.aMANY)
7974 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7975 Arg counts are now ptrdiff_t, not size_t.
7976 All variadic functions and their callers changed accordingly.
7977 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7978 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7979 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7980 * callint.c (Fcall_interactively): Check arg count for overflow,
7981 to avoid potential buffer overrun. Use signed char, not 'int',
7982 for 'varies' array, so that we needn't bother to check its size
7983 calculation for overflow.
7984 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7985 * eval.c (apply_lambda):
7986 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7987 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7988 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7990 * callint.c (Fcall_interactively): Don't use index var as event count.
7992 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7993 * mem-limits.h (SIZE): Remove; no longer used.
7995 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
7997 Remove unnecessary casts.
7998 * xterm.c (x_term_init):
7999 * xfns.c (x_set_border_pixel):
8000 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8001 These aren't needed now that we assume ANSI C.
8003 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8004 It's more likely to cause problems (due to unsigned overflow)
8007 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8009 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8011 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8013 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8015 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8017 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8019 GLYPH_CODE_FACE returns EMACS_INT, not int.
8020 * dispextern.h (merge_faces):
8021 * xfaces.c (merge_faces):
8022 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8023 Don't assume EMACS_INT fits in int.
8025 * character.h (CHAR_VALID_P): Remove unused parameter.
8026 * fontset.c, lisp.h, xdisp.c: All uses changed.
8028 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8030 * fns.c (concat): Minor tuning based on overflow analysis.
8031 This doesn't fix any bugs. Use int to hold character, instead
8032 of constantly refetching from Emacs object. Use XFASTINT, not
8033 XINT, for value known to be a character. Don't bother comparing
8034 a single byte to 0400, as it's always less.
8036 * floatfns.c (Fexpt):
8037 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8039 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8042 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8044 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8045 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8046 incorrectly succeed when S was a string, because 4294967386 was
8047 truncated before it was used.
8049 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8050 Otherwise, an out-of-range integer could cause undefined behavior
8053 * composite.c: Use int, not EMACS_INT, for characters.
8054 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8055 EMACS_INT, for values that are known to be in character range.
8056 This doesn't fix any bugs but is the usual style inside Emacs and
8057 may generate better code on 32-bit machines.
8059 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8060 This is for reasons similar to the recent CHAR_STRING fix.
8061 * charset.c (Fencode_char): Check that character arg is actually
8062 a character. Pass an int to ENCODE_CHAR.
8063 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8064 wider than 'int', as a compile-time check to prevent future regressions
8067 * character.c (char_string): Remove unnecessary casts.
8069 Make sure a 64-bit char is never passed to CHAR_STRING.
8070 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8071 by silently ignoring the top 32 bits, allowing some values
8072 that were far too large to be valid characters.
8073 * character.h: Include <verify.h>.
8074 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8075 arguments are no wider than unsigned, as a compile-time check
8076 to prevent future regressions in this area.
8078 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
8079 (Fsubst_char_in_region):
8081 * xdisp.c (decode_mode_spec_coding):
8082 Adjust to CHAR_STRING's new requirement.
8083 * editfns.c (Finsert_char, Fsubst_char_in_region):
8084 * fns.c (concat): Check that character args are actually
8085 characters. Without this test, these functions did the wrong
8086 thing with wildly out-of-range values on 64-bit hosts.
8088 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8089 These casts should not be needed on 32-bit hosts, either.
8090 * keyboard.c (read_char):
8091 * lread.c (Fload): Remove casts to unsigned.
8093 * lisp.h (UNSIGNED_CMP): New macro.
8094 This fixes comparison bugs on 64-bit hosts.
8095 (ASCII_CHAR_P): Use it.
8096 * casefiddle.c (casify_object):
8097 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
8098 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8099 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8100 * dispextern.h (FACE_FROM_ID):
8101 * keyboard.c (read_char): Use UNSIGNED_CMP.
8103 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8104 not to EMACS_INT, to avoid GCC warning.
8106 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8108 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8109 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8110 isn't needed on 32-bit machines.
8112 * buffer.c (Fgenerate_new_buffer_name):
8113 Use EMACS_INT for count, not int.
8114 (advance_to_char_boundary): Return EMACS_INT, not int.
8116 * data.c (Qcompiled_function): Now static.
8118 * window.c (window_body_lines): Now static.
8120 * image.c (gif_load): Rename local to avoid shadowing.
8122 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8123 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8124 * alloc.c (make_save_value): Integer argument is now of type
8126 (mark_object): Use ptrdiff_t, not int.
8127 * lisp.h (pD): New macro.
8128 * print.c (print_object): Use it.
8130 * alloc.c: Use EMACS_INT, not int, to count objects.
8131 (total_conses, total_markers, total_symbols, total_vector_size)
8132 (total_free_conses, total_free_markers, total_free_symbols)
8133 (total_free_floats, total_floats, total_free_intervals)
8134 (total_intervals, total_strings, total_free_strings):
8135 Now EMACS_INT, not int. All uses changed.
8136 (Fgarbage_collect): Compute overall total using a double, so that
8137 integer overflow is less likely to be a problem. Check for overflow
8138 when converting back to an integer.
8139 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8140 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8141 These were 'int' variables that could overflow on 64-bit hosts;
8142 they were never used, so remove them instead of repairing them.
8143 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
8144 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8145 Previously, this ceilinged at INT_MAX, but that doesn't work on
8147 (allocate_pseudovector): Don't use EMACS_INT when int would do.
8149 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
8150 (allocate_vectorlike): Check for ptrdiff_t overflow.
8151 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8152 when a (possibly-narrower) signed value would do just as well.
8153 We prefer using signed arithmetic, to avoid comparison confusion.
8155 * alloc.c: Catch some string size overflows that we were missing.
8156 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8157 for convenience in STRING_BYTES_MAX.
8158 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8159 The definition here is exact; the one in lisp.h was approximate.
8160 (allocate_string_data): Check for string overflow. This catches
8161 some instances we weren't catching before. Also, it catches
8162 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8163 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8164 and ptrdiff_t and EMACS_INT are both 64 bits.
8166 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8167 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
8168 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
8170 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8172 * alloc.c (Fmake_string): Check for out-of-range init.
8174 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8176 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8178 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8180 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8181 xg_get_default_scrollbar_width.
8183 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8184 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8185 (style_changed_cb): Call update_theme_scrollbar_width and call
8186 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8187 all frames (Bug#8505).
8188 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8189 Call gtk_window_set_resizable if HAVE_GTK3.
8190 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8191 and height if HAVE_GTK3 (Bug#8505).
8192 (scroll_bar_width_for_theme): New variable.
8193 (update_theme_scrollbar_width): New function.
8194 (xg_get_default_scrollbar_width): Move code to
8195 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8196 (xg_initialize): Call update_theme_scrollbar_width.
8198 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8200 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8202 2011-06-12 Martin Rudalics <rudalics@gmx.at>
8204 * frame.c (make_frame): Call other_buffer_safely instead of
8207 * window.c (temp_output_buffer_show): Call display_buffer with
8208 second argument Vtemp_buffer_show_specifiers and reset latter
8209 immediately after the call.
8210 (Vtemp_buffer_show_specifiers): New variable.
8211 (auto_window_vscroll_p, next_screen_context_lines)
8212 (Vscroll_preserve_screen_position): Remove leading asterisks from
8215 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
8217 Fix minor problems found by GCC 4.6.0 static checking.
8218 * buffer.c (Qclone_number): Remove for now, as it's unused.
8219 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8220 (record_buffer): Remove unused local.
8221 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8222 (set_frame_buffer_list): Remove; unused.
8223 * frame.h (other_visible_frames): Remove decl.
8224 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8225 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8226 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8228 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8229 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8230 Define only if HAVE_GPM.
8231 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8232 (update_hints_inhibit): Remove; never set. All uses removed.
8233 * widgetprv.h (emacsFrameClassRec): Remove decl.
8234 * window.c (delete_deletable_window): Now returns void, since it
8235 wasn't returning anything.
8236 (compare_window_configurations): Remove unused locals.
8237 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8238 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
8239 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8240 the same widths as pointers. This follows up on the 2011-05-06 patch.
8241 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8242 * xterm.h: Likewise.
8243 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8245 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
8247 * makefile.w32-in: Update dependencies.
8248 (LISP_H): Add lib/intprops.h.
8250 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
8252 * image.c (gif_load): Add animation frame delay to the metadata.
8253 (syms_of_image): Use DEFSYM. New symbol `delay'.
8255 2011-06-11 Martin Rudalics <rudalics@gmx.at>
8257 * window.c (delete_deletable_window): Re-add.
8258 (Fset_window_configuration): Rewrite to handle dead buffers and
8259 consequently deletable windows.
8260 (window_tree, Fwindow_tree): Remove. Supply functionality in
8262 (compare_window_configurations): Simplify code.
8264 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8266 * image.c (imagemagick_load_image): Fix type mismatch.
8267 (Fimagemagick_types): Likewise.
8269 * window.h (replace_buffer_in_windows): Declare.
8271 2011-06-11 Martin Rudalics <rudalics@gmx.at>
8273 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8274 Qclone_number. Remove external declaration of Qdelete_window.
8275 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8277 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8278 Run Qbuffer_list_update_hook if allowed.
8279 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8280 buffer list implementation.
8281 (other_buffer_safely): New function.
8282 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8283 calls to replace_buffer_in_windows and
8284 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8286 (record_buffer): Inhibit quitting and rewrite using quittable
8287 functions. Run Qbuffer_list_update_hook if allowed.
8288 (Frecord_buffer, Funrecord_buffer): New functions.
8289 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8290 Move switch-to-buffer to window.el.
8291 (bury-buffer): Move to window.el.
8292 (Vbuffer_list_update_hook): New variable.
8294 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8297 * window.h (resize_frame_windows): Move up in code.
8298 (Fwindow_frame): Remove EXFUN.
8299 (replace_buffer_in_all_windows): Remove prototype.
8300 (replace_buffer_in_windows_safely): Add prototype.
8302 * window.c: Declare Qdelete_window static again. Move down
8303 declaration of select_count.
8304 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8305 (Fother_window): Move to window.el.
8306 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8307 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8308 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8310 (replace_buffer_in_windows): Implement by calling
8311 Qreplace_buffer_in_windows.
8312 (replace_buffer_in_all_windows): Remove with some functionality
8313 moved into replace_buffer_in_windows_safely.
8314 (replace_buffer_in_windows_safely): New function.
8315 (select_window_norecord, select_frame_norecord): Move in front
8316 of run_window_configuration_change_hook. Remove now obsolete
8318 (Fset_window_buffer): Rewrite doc-string.
8319 Call Qrecord_window_buffer.
8320 (keys_of_window): Move binding for other-window to window.el.
8322 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
8324 * dispextern.h (struct image): Replace data member, whose int_val
8325 and ptr_val fields were not used by anything, with a single
8328 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8329 (gif_clear_image, gif_load, imagemagick_load_image)
8330 (gs_clear_image, gs_load): Callers changed.
8332 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8334 * buffer.h: Include <time.h>, for time_t.
8335 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8337 Fix minor problems found by static checking.
8339 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8341 Make identifiers static if they are not used in other modules.
8342 * data.c (Qcompiled_function, Qframe, Qvector):
8343 * image.c (QimageMagick, Qsvg):
8344 * minibuf.c (Qmetadata):
8345 * window.c (resize_window_check, resize_root_window): Now static.
8346 * window.h (resize_window_check, resize_root_window): Remove decls.
8348 * window.c (window_deletion_count, delete_deletable_window):
8350 (window_body_lines): Now static.
8351 (Fdelete_other_windows_internal): Mark vars as initialized.
8352 Make sure 'resize_failed' is initialized.
8353 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8354 (resize_window_apply): Remove unused local.
8355 * window.h (delete_deletable_window): Remove decl.
8357 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
8358 (imagemagick_load_image): Fix pointer signedness problem by changing
8359 last arg from unsigned char * to char *. All uses changed.
8360 Also, fix a local for similar reasons.
8361 Remove unused locals. Remove locals to avoid shadowing.
8362 (fn_rsvg_handle_free): Remove; unused.
8363 (svg_load, svg_load_image): Fix pointer signedness problem.
8364 (imagemagick_load_image): Don't use garbage pointer image_wand.
8366 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8368 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
8370 * image.c (gif_load): Fix omitted cast error introduced by
8373 2011-06-10 Martin Rudalics <rudalics@gmx.at>
8375 * window.h (resize_proportionally, orig_total_lines)
8376 (orig_top_line): Remove from window structure.
8377 (set_window_height, set_window_width, change_window_heights)
8378 (Fdelete_window): Remove prototypes.
8379 (resize_frame_windows): Remove duplicate declaration.
8381 2011-06-10 Eli Zaretskii <eliz@gnu.org>
8383 * window.h (resize_frame_windows, resize_window_check)
8384 (delete_deletable_window, resize_root_window)
8385 (resize_frame_windows): Declare prototypes.
8387 * window.c (resize_window_apply): Make definition be "static" to
8388 match the prototype.
8390 2011-06-10 Martin Rudalics <rudalics@gmx.at>
8392 * window.c: Remove declarations of Qwindow_size_fixed,
8393 window_min_size_1, window_min_size_2, window_min_size,
8394 size_window, window_fixed_size_p, enlarge_window, delete_window.
8395 Remove static from declaration of Qdelete_window, it's
8396 temporarily needed by Fbury_buffer.
8397 (replace_window): Don't assign orig_top_line and
8399 (Fdelete_window, delete_window): Remove. Window deletion is
8400 handled by window.el.
8401 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8402 Replace Fdelete_window calls with calls to Qdelete_window.
8403 (Fdelete_other_windows): Remove. Deleting other windows is
8404 handled by window.el.
8405 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8406 handled in window.el.
8407 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8408 Window minimum sizes are handled in window.el.
8409 (shrink_windows, size_window, set_window_height)
8410 (set_window_width, change_window_heights, window_height)
8411 (window_width, CURBEG, CURSIZE, enlarge_window)
8412 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8413 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8414 handled in window.el.
8415 (make_dummy_parent): Rename to make_parent_window and give it a
8416 second argument horflag.
8417 (make_window): Don't set resize_proportionally any more.
8418 (Fsplit_window): Remove. Windows are split in window.el.
8419 (save_restore_action, save_restore_orig_size)
8420 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8421 Resize mini windows in window.el.
8422 (grow_mini_window, shrink_mini_window): Implement by calling
8423 Qresize_root_window_vertically, resize_window_check and
8424 resize_window_apply.
8425 (saved_window, Fset_window_configuration, save_window_save):
8426 Do not handle orig_top_line, orig_total_lines, and
8427 resize_proportionally.
8428 (window_min_height, window_min_width): Move to window.el.
8429 (keys_of_window): Move bindings for delete-other-windows,
8430 split-window, delete-window and enlarge-window to window.el.
8432 * buffer.c: Temporarily extern Qdelete_window.
8433 (Fbury_buffer): Temporarily call Qdelete_window instead of
8434 Fdelete_window (Fbury_buffer will move to window.el soon).
8436 * frame.c (set_menu_bar_lines_1): Remove code handling
8437 orig_top_line and orig_total_lines.
8439 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8440 set_window_height but set heights directly.
8441 (change_frame_size_1): Use resize_frame_windows.
8443 * xdisp.c (init_xdisp): Don't use set_window_height but set
8446 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8447 Use resize_frame_windows instead of change_window_heights and run
8448 run_window_configuration_change_hook.
8450 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8451 instead of change_window_heights and run
8452 run_window_configuration_change_hook.
8454 2011-06-09 Martin Rudalics <rudalics@gmx.at>
8456 * window.c (replace_window): Rename second argument REPLACEMENT to
8457 NEW. New third argument SETFLAG. Rewrite.
8458 (delete_window, make_dummy_parent): Call replace_window with
8460 (window_list_1): Move down in code.
8461 (run_window_configuration_change_hook): Move set_buffer part
8462 before select_frame_norecord part in order to unwind correctly.
8463 Rename count1 to count.
8464 (recombine_windows, delete_deletable_window, resize_root_window)
8465 (Fdelete_other_windows_internal)
8466 (Frun_window_configuration_change_hook, make_parent_window)
8467 (resize_window_check, resize_window_apply, Fresize_window_apply)
8468 (resize_frame_windows, Fsplit_window_internal)
8469 (Fdelete_window_internal, Fresize_mini_window_internal):
8471 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8473 2011-06-08 Martin Rudalics <rudalics@gmx.at>
8475 * window.h (window): Add some new members to window structure -
8476 normal_lines, normal_cols, new_total, new_normal, clone_number,
8477 splits, nest, prev_buffers, next_buffers.
8478 (WINDOW_TOTAL_SIZE): Move here from window.c.
8479 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
8481 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8483 (make_dummy_parent): Set new members of windows structure.
8484 (make_window): Move down in code. Handle new members of window
8486 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8487 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8488 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8489 (Fset_window_prev_buffers, Fwindow_next_buffers)
8490 (Fset_window_next_buffers, Fset_window_clone_number):
8492 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8493 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8495 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8496 Argument WINDOW can be now internal window too.
8497 (Fwindow_use_time): Move up in code.
8498 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8500 (Fset_window_configuration, saved_window)
8501 (Fcurrent_window_configuration, save_window_save): Handle new
8502 members of window structure.
8503 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8504 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8505 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8506 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8507 Qget_mru_window, Qresize_root_window,
8508 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8509 Qauto_buffer_name; staticpro them.
8511 2011-06-07 Martin Rudalics <rudalics@gmx.at>
8513 * window.c (Fwindow_total_size, Fwindow_left_column)
8514 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8515 (Fwindow_list_1): New functions.
8516 (window_box_text_cols): Replace with window_body_cols.
8517 (Fwindow_width, Fscroll_left, Fscroll_right):
8518 Use window_body_cols instead of window_box_text_cols.
8519 (delete_window, Fset_window_configuration):
8520 Call delete_all_subwindows with window as argument.
8521 (delete_all_subwindows): Take a window as argument and not a
8523 (window_loop): Remove handling of GET_LRU_WINDOW and
8525 (Fget_lru_window, Fget_largest_window): Move to window.el.
8527 * window.h: Extern window_body_cols instead of
8528 window_box_text_cols. delete_all_subwindows now takes a
8529 Lisp_Object as argument.
8531 * indent.c (compute_motion, Fcompute_motion):
8532 Use window_body_cols instead of window_box_text_cols.
8534 * frame.c (delete_frame): Call delete_all_subwindows with root
8537 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8539 * fns.c (Fputhash): Document return value.
8541 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
8543 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8545 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8547 Cons<->int and similar integer overflow fixes (Bug#8794).
8549 Check for overflow when converting integer to cons and back.
8550 * charset.c (Fdefine_charset_internal, Fdecode_char):
8551 Use cons_to_unsigned to catch overflow.
8552 (Fencode_char): Use INTEGER_TO_CONS.
8553 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8554 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8555 * data.c (long_to_cons, cons_to_long): Remove.
8556 (cons_to_unsigned, cons_to_signed): New functions.
8557 These signal an error for invalid or out-of-range values.
8558 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8559 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8560 * font.c (Ffont_variation_glyphs):
8561 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8562 * lisp.h: Include <intprops.h>.
8563 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8564 (cons_to_signed, cons_to_unsigned): New decls.
8565 (long_to_cons, cons_to_long): Remove decls.
8566 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8567 (Fprimitive_undo): Use CONS_TO_INTEGER.
8568 * xfns.c (Fx_window_property): Likewise.
8569 * xselect.c: Include <limits.h>.
8570 (x_own_selection, selection_data_to_lisp_data):
8571 Use INTEGER_TO_CONS.
8572 (x_handle_selection_request, x_handle_selection_clear)
8573 (x_get_foreign_selection, Fx_disown_selection_internal)
8574 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8575 (lisp_data_to_selection_data): Use cons_to_unsigned.
8576 (x_fill_property_data): Use cons_to_signed.
8577 Report values out of range.
8579 Check for buffer and string overflow more precisely.
8580 * buffer.h (BUF_BYTES_MAX): New macro.
8581 * lisp.h (STRING_BYTES_MAX): New macro.
8582 * alloc.c (Fmake_string):
8583 * character.c (string_escape_byte8):
8584 * coding.c (coding_alloc_by_realloc):
8585 * doprnt.c (doprnt):
8586 * editfns.c (Fformat):
8588 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8589 since they may not be the same number.
8590 * editfns.c (Finsert_char):
8591 * fileio.c (Finsert_file_contents):
8592 Likewise for BUF_BYTES_MAX.
8594 * image.c: Use ptrdiff_t, not int, for sizes.
8595 (slurp_file): Switch from int to ptrdiff_t.
8597 (slurp_file): Check that file size fits in both size_t (for
8598 malloc) and ptrdiff_t (for sanity and safety).
8600 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8601 if b->modtime has its maximal value.
8603 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8605 Don't assume time_t can fit into int.
8606 * buffer.h (struct buffer.modtime): Now time_t, not int.
8607 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8608 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8610 Minor fixes for signed vs unsigned integers.
8611 * character.h (MAYBE_UNIFY_CHAR):
8612 * charset.c (maybe_unify_char):
8613 * keyboard.c (read_char, reorder_modifiers):
8614 XINT -> XFASTINT, since the integer must be nonnegative.
8615 * ftfont.c (ftfont_spec_pattern):
8616 * keymap.c (access_keymap, silly_event_symbol_error):
8617 XUINT -> XFASTINT, since the integer must be nonnegative.
8618 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8619 since it makes no difference and we prefer signed.
8620 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8621 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8624 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8626 * window.h (Fwindow_frame): Declare.
8628 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8630 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8631 (SPARE_MEMORY): Always define.
8632 (LARGE_REQUEST): Remove.
8633 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8635 2011-06-06 Martin Rudalics <rudalics@gmx.at>
8637 * lisp.h: Move EXFUNS for Fframe_root_window,
8638 Fframe_first_window and Fset_frame_selected_window to window.h.
8640 * window.h: Move EXFUNS for Fframe_root_window,
8641 Fframe_first_window and Fset_frame_selected_window here from
8644 * frame.c (Fwindow_frame, Fframe_first_window)
8645 (Fframe_root_window, Fframe_selected_window)
8646 (Fset_frame_selected_window): Move to window.c.
8647 (Factive_minibuffer_window): Move to minibuf.c.
8648 (Fother_visible_frames_p): New function.
8650 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8652 * window.c (decode_window, decode_any_window): Move up in code.
8653 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8654 (inhibit_frame_unsplittable): Remove unused variable.
8655 (Fwindow_buffer): Move up and rewrite doc-string.
8656 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8657 (Fwindow_prev): New functions.
8658 (Fwindow_frame): Move here from frame.c. Accept any window as
8660 (Fframe_root_window, Fframe_first_window)
8661 (Fframe_selected_window): Move here from frame.c. Accept frame
8662 or arbitrary window as argument. Update doc-strings.
8663 (Fminibuffer_window): Move up in code.
8664 (Fwindow_minibuffer_p): Move up in code and simplify.
8665 (Fset_frame_selected_window): Move here from frame.c.
8667 (Fselected_window, select_window, Fselect_window): Move up in
8668 code. Minor doc-string fixes.
8670 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8672 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8673 Do not assume that spare memory exists; that assumption is valid
8674 only if SYSTEM_MALLOC.
8675 (LARGE_REQUEST): New macro, so that the issue of large requests
8676 is separated from the issue of spare memory.
8678 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8680 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8683 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8685 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8688 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8690 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8692 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8694 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8695 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8697 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
8699 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8701 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
8703 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8704 (x_clipboard_manager_save): Add return value.
8705 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8707 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8708 Obey Vx_select_enable_clipboard_manager. Catch errors in
8709 x_clipboard_manager_save (Bug#8779).
8710 (Vx_select_enable_clipboard_manager): New variable.
8711 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
8713 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8715 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8717 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8719 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8720 in the current matrix if keep_current_p is non-zero.
8722 2011-06-04 Eli Zaretskii <eliz@gnu.org>
8724 * bidi.c (bidi_level_of_next_char): Fix last change.
8726 2011-06-03 Eli Zaretskii <eliz@gnu.org>
8728 Support bidi reordering of text covered by display properties.
8730 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8731 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8732 (bidi_cache_search, bidi_cache_iterator_state)
8733 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
8734 (bidi_level_of_next_char, bidi_move_to_visually_next):
8735 Support character positions inside a run of characters covered by a
8737 (bidi_paragraph_init, bidi_resolve_explicit_1)
8738 (bidi_level_of_next_char): Call bidi_fetch_char and
8739 bidi_fetch_char_advance instead of FETCH_CHAR and
8741 (bidi_init_it): Initialize new members.
8742 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8744 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8745 instead of using explicit *_CHAR codes.
8746 (bidi_resolve_explicit, bidi_resolve_weak):
8747 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
8748 bidirectional text is supported only in multibyte buffers.
8749 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8750 it to initialize the frame_window_p member of struct bidi_it.
8751 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8752 (bidi_resolve_explicit, bidi_resolve_weak)
8753 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8754 bidi_it->nchars is non-positive.
8755 (bidi_level_of_next_char): Don't try to lookup the cache for the
8756 next/previous character if nothing is cached there yet, or if we
8757 were just reseat()'ed to a new position.
8759 * xdisp.c (set_cursor_from_row): Set start and stop points
8760 according to the row's direction when priming the loop that looks
8761 for the glyph on which to display cursor.
8762 (single_display_spec_intangible_p): Function deleted.
8763 (display_prop_intangible_p): Reimplement to call
8764 handle_display_spec instead of single_display_spec_intangible_p.
8765 Accept 3 additional arguments needed by handle_display_spec.
8766 This fixes incorrect cursor motion across display property with complex
8767 values: lists, `(when COND...)' forms, etc.
8768 (single_display_spec_string_p): Support property values that are
8769 lists with the argument STRING its top-level element.
8770 (display_prop_string_p): Fix the condition for processing a
8771 property that is a list to be consistent with handle_display_spec.
8772 (handle_display_spec): New function, refactored from the
8773 last portion of handle_display_prop.
8774 (compute_display_string_pos): Accept additional argument
8775 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8776 value of a `display' property is a "replacing spec".
8777 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8778 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8779 the display property, but just return a value indicating whether
8780 the display property will replace the characters it covers.
8781 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8782 frame_window_p members of struct bidi_it.
8783 (compute_display_string_pos, compute_display_string_end):
8785 (push_it): Accept second argument POSITION, where pop_it should
8786 jump to continue iteration.
8787 (reseat_1): Initialize bidi_it.disp_pos.
8789 * keyboard.c (adjust_point_for_property): Adjust the call to
8790 display_prop_intangible_p to its new signature.
8792 * dispextern.h (struct bidi_it): New member frame_window_p.
8793 (bidi_init_it): Update prototypes.
8794 (display_prop_intangible_p): Update prototype.
8795 (compute_display_string_pos, compute_display_string_end):
8797 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8800 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
8802 Malloc failure behavior now depends on size of allocation.
8803 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8804 * lisp.h: Change signatures accordingly.
8805 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8806 All callers changed. (Bug#8762)
8808 * gnutls.c: Use Emacs's memory allocators.
8809 Without this change, the gnutls library would invoke malloc etc.
8810 directly, which causes problems on non-SYNC_INPUT hosts, and which
8811 runs afoul of improving memory_full behavior. (Bug#8761)
8812 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8813 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8814 xfree instead of the default malloc, realloc, free.
8815 (Fgnutls_boot): No need to check for memory allocation failure,
8816 since xmalloc does that for us.
8818 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
8819 * category.c (hash_get_category_set):
8820 * ccl.c (ccl_driver):
8821 * charset.c (Fdefine_charset_internal):
8822 * charset.h (struct charset.hash_index):
8823 * composite.c (get_composition_id, gstring_lookup_cache)
8824 (composition_gstring_put_cache):
8825 * composite.h (struct composition.hash_index):
8826 * dispextern.h (struct image.hash):
8827 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8828 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8829 (hashfn_equal, hashfn_user_defined, make_hash_table)
8830 (maybe_resize_hash_table, hash_lookup, hash_put)
8831 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8832 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8833 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8834 * image.c (make_image, search_image_cache, lookup_image)
8835 (xpm_put_color_table_h):
8836 * lisp.h (struct Lisp_Hash_Table):
8837 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
8838 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
8839 for hashes and hash indexes, instead of 'unsigned' and 'int'.
8840 * alloc.c (allocate_vectorlike):
8841 Check for overflow in vector size calculations.
8842 * ccl.c (ccl_driver):
8843 Check for overflow when converting EMACS_INT to int.
8844 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8845 need to be updated by these changes.
8846 * fns.c (make_hash_table, maybe_resize_hash_table):
8847 Check for integer overflow with large hash tables.
8848 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8849 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8850 (SXHASH_REDUCE): New macro.
8851 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8852 Use it instead of discarding useful hash info with large hash values.
8853 (sxhash_float): New function.
8854 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8855 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
8856 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8857 Rewrite to use FIXNUM_BITS, as this simplifies things.
8858 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8859 Adjust signatures to match updated version of code.
8860 (consing_since_gc): Now EMACS_INT, since a single hash table can
8861 use more than INT_MAX bytes.
8863 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8865 Make it possible to build with GCC-4.6+ -O2 -flto.
8867 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8869 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8871 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8872 Call minibuffer-inactive-mode.
8874 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
8876 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8877 Update dependencies.
8879 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8881 * data.c (init_data): Remove code for UTS, this system is not
8884 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8886 Don't force ./temacs to start in terminal mode.
8888 * frame.c (make_initial_frame): Initialize faces in all cases, not
8889 only when CANNOT_DUMP is defined.
8890 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8892 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8894 * dispnew.c (add_window_display_history): Use const for the string
8895 pointer. Remove declaration, not needed.
8897 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8899 Use 'inline', not 'INLINE'.
8900 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
8901 * alloc.c, fontset.c (INLINE): Remove.
8902 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8903 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8904 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8905 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8906 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8908 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8910 Make it possible to run ./temacs.
8912 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8913 syms_of_callproc does the same thing. Remove test for
8914 "initialized", do it in the caller.
8915 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8917 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8919 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8920 (read_minibuf): Use get_minibuffer.
8921 (syms_of_minibuf): Use DEFSYM.
8922 (Qmetadata): New var.
8923 * data.c (Qbuffer): Don't make it static.
8924 (syms_of_data): Use DEFSYM.
8926 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8928 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8929 (CCL_CODE_MIN): New macro.
8931 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8933 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8935 * eval.c (Qdebug): Now static.
8936 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8937 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8938 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8940 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8942 * image.c: Various fixes to ImageMagick code comments.
8943 (Fimagemagick_types): Doc fix.
8945 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8947 Minor fixes prompted by GCC 4.6.0 warnings.
8949 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8951 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8952 (x_clipboard_manager_save_all): Move extern decl to ...
8953 * xterm.h: ... here, so that it can be checked for consistency.
8955 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8957 * xselect.c (x_clipboard_manager_save_frame)
8958 (x_clipboard_manager_save_all): New functions.
8959 (Fx_clipboard_manager_save): Lisp function deleted.
8961 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8962 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8964 * xterm.h: Update prototype.
8966 2011-05-28 William Xu <william.xwl@gmail.com>
8968 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8971 2011-05-28 Jim Meyering <meyering@redhat.com>
8973 Avoid a sign-extension bug in crypto_hash_function.
8974 * fns.c (to_uchar): Define.
8975 (crypto_hash_function): Use it to convert some newly-signed
8976 variables to unsigned, to avoid sign-extension bugs. For example,
8977 without this change, (md5 "truc") would evaluate to
8978 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8979 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
8980 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
8982 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8984 Integer overflow fixes.
8986 * dbusbind.c: Serial number integer overflow fixes.
8987 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
8988 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8989 to hold a serial number that is too large for a fixnum.
8990 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8991 Check for serial numbers out of range. Decode any serial number
8992 that was so large that it became a float. (Bug#8722)
8994 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8995 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8996 Use XFASTINT rather than XUINT when numbers are nonnegative.
8997 (xd_append_arg, Fdbus_method_return_internal):
8998 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8999 arguments, check that Lisp number is nonnegative, rather than
9000 silently wrapping negative numbers around. (Bug#8722)
9001 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
9004 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9006 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9008 ccl: Add integer overflow checks.
9009 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9010 (IN_INT_RANGE): New macros.
9011 (ccl_driver): Use them to check for integer overflow when
9012 decoding a CCL program. Many of the new checks are whether XINT (x)
9013 fits in int; it doesn't always, on 64-bit hosts. The new version
9014 doesn't catch all possible integer overflows, but it's an
9015 improvement. (Bug#8719)
9017 * alloc.c (make_event_array): Use XINT, not XUINT.
9018 There's no need for unsigned here.
9020 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9021 This follows up to the 2011-05-06 change that substituted uintptr_t
9022 for EMACS_INT. This case wasn't caught back then.
9024 Rework Fformat to avoid integer overflow issues.
9025 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9026 now (part of C89). Include <verify.h>.
9027 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9028 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9029 (Fformat): Avoid the prepass trying to compute sizes; it was only
9030 approximate and thus did not catch overflow reliably. Instead, walk
9031 through the format just once, formatting and computing sizes as we go,
9032 checking for integer overflow at every step, and allocating a larger
9033 buffer as needed. Keep track separately whether the format is
9034 multibyte. Keep only the most-recently calculated precision, rather
9035 than them all. Record whether each argument has been converted to
9036 string. Use EMACS_INT, not int, for byte and char and arg counts.
9037 Support field widths and precisions larger than INT_MAX. Avoid
9038 sprintf's undefined behavior with conversion specifications such as %#d
9039 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9040 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9041 formatting out-of-range floating point numbers with int
9044 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9046 * data.c: Avoid integer truncation in expressions involving floats.
9047 * data.c: Include <intprops.h>.
9048 (arith_driver): When there's an integer overflow in an expression
9049 involving floating point, convert the integers to floating point
9050 so that the resulting value does not suffer from catastrophic
9051 integer truncation. For example, on a 64-bit host (* 4
9052 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9053 Do not rely on undefined behavior after integer overflow.
9055 merge count_size_as_multibyte, parse_str_to_multibyte
9056 * character.c, character.h (count_size_as_multibyte):
9057 Rename from parse_str_to_multibyte; all uses changed.
9058 Check for integer overflow.
9059 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9060 since it's now a duplicate of the other. This is more of
9061 a character than a buffer op, so better that it's in character.c.
9062 * fns.c, print.c: Adjust to above changes.
9064 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9066 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9068 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9070 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9071 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9072 (x_clipboard_manager_save): Now static.
9073 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9075 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9076 (crypto_hash_function): Now static.
9077 Fix pointer signedness problems. Avoid unnecessary initializations.
9079 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
9081 * termhooks.h (Vselection_alist): Make it terminal-local.
9083 * terminal.c (create_terminal): Initialize it.
9085 * xselect.c: Support for clipboard managers.
9086 (Vselection_alist): Move to termhooks.h as terminal-local var.
9087 (LOCAL_SELECTION): New macro.
9088 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9089 (symbol_to_x_atom): Remove gratuitous arg.
9090 (x_handle_selection_request, lisp_data_to_selection_data)
9091 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
9092 (x_own_selection, x_get_local_selection, x_convert_selection):
9093 New arg, specifying work frame. Use terminal-local Vselection_alist.
9094 (some_frame_on_display): Delete unused function.
9095 (Fx_own_selection_internal, Fx_get_selection_internal)
9096 (Fx_disown_selection_internal, Fx_selection_owner_p)
9097 (Fx_selection_exists_p): New optional frame arg.
9098 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9099 (x_handle_selection_clear): Don't treat other terminals with the
9100 same keyboard specially. Use the terminal-local Vselection_alist.
9101 (x_clear_frame_selections): Use Frun_hook_with_args.
9103 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9105 * xterm.h: Add support for those atoms.
9107 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
9109 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9110 (converted_selections, conversion_fail_tag): New global variables.
9111 (x_selection_request_lisp_error): Free the above.
9112 (x_get_local_selection): Remove unnecessary code.
9113 (x_reply_selection_request): Args changed; handle arbitrary array
9114 of converted selections stored in converted_selections.
9115 Separate the XChangeProperty and SelectionNotify steps.
9116 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9117 (x_convert_selection): New function.
9118 (x_handle_selection_event): Simplify.
9119 (x_get_foreign_selection): Don't ignore incoming requests while
9120 waiting for an answer; this will fail when we implement
9121 SAVE_TARGETS, and seems unnecessary anyway.
9122 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9123 (Vx_sent_selection_functions): Doc fix.
9125 2011-05-26 Leo Liu <sdl.web@gmail.com>
9127 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9129 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9131 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9133 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9134 for fringe update if it has periodic bitmap.
9135 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
9136 and fringe_bitmap_periodic_p.
9138 * fringe.c (get_fringe_bitmap_data): New function.
9139 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9140 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9141 row. Mark glyph row for fringe update if periodicity changed.
9143 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9144 for fringe update unless it has periodic bitmap.
9146 2011-05-25 Kenichi Handa <handa@m17n.org>
9148 * xdisp.c (get_next_display_element): Set correct it->face_id for
9149 a static composition.
9151 2011-05-24 Leo Liu <sdl.web@gmail.com>
9154 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9156 * fns.c (crypto_hash_function, Fsha1): New function.
9157 (Fmd5): Use crypto_hash_function.
9158 (syms_of_fns): Add Ssha1.
9160 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9162 * gnutls.c: Remove unused macros.
9163 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9164 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9165 Remove macros that are defined and never used.
9166 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9168 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9170 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9171 (Fx_get_selection_internal): Minor cleanup.
9172 (Fx_own_selection_internal): Rename arguments for consistency with
9175 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9177 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9179 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9181 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9183 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9185 * dispnew.c (scrolling_window): Don't exclude the case that the
9186 last enabled row in the desired matrix touches the bottom boundary.
9188 2011-05-21 Glenn Morris <rgm@gnu.org>
9190 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
9191 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9192 and add some more files.
9194 2011-05-20 Eli Zaretskii <eliz@gnu.org>
9196 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9197 report_file_error introduced by the change from 2011-05-07.
9199 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9201 * systime.h (Time): Define only if emacs is defined.
9202 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9203 where the include path doesn't have X11/X.h by default. See
9204 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9206 2011-05-20 Kenichi Handa <handa@m17n.org>
9208 * composite.c (find_automatic_composition): Fix previous change.
9210 2011-05-20 Glenn Morris <rgm@gnu.org>
9212 * lisp.mk: New file, split from Makefile.in.
9213 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9214 (shortlisp): Remove.
9215 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9217 2011-05-19 Glenn Morris <rgm@gnu.org>
9219 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9220 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9221 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9222 (lisp): Set the order to that of loadup.el.
9223 (shortlisp): Make it a copy of $lisp.
9224 (SOME_MACHINE_LISP): Remove.
9225 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9226 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9228 2011-05-18 Kenichi Handa <handa@m17n.org>
9230 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9231 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9232 (find_automatic_composition): Mostly rewrite for efficiency.
9234 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
9236 * makefile.w32-in: Update dependencies.
9238 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9240 * menu.c: Include limits.h (fixes the MS-Windows build broken by
9241 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
9243 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
9245 Fix some integer overflow issues, such as string length overflow.
9247 * insdel.c (count_size_as_multibyte): Check for string overflow.
9249 * character.c (lisp_string_width): Check for string overflow.
9250 Use EMACS_INT, not int, for string indexes and lengths; in
9251 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9252 the resulting string length overflows an EMACS_INT; instead,
9253 report a string overflow if no precision given. When checking for
9254 precision exhaustion, use a check that cannot possibly have
9255 integer overflow. (Bug#8675)
9256 * character.h (lisp_string_width): Adjust to new signature.
9258 * alloc.c (string_overflow): New function.
9259 (Fmake_string): Use it. This doesn't change behavior, but saves
9260 a few bytes and will simplify future changes.
9261 * character.c (string_escape_byte8): Likewise.
9262 * lisp.h (string_overflow): New decl.
9264 Fixups, following up to the user-interface timestamp change.
9265 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9266 for UI timestamps, instead of unsigned long.
9267 * msdos.c (mouse_get_pos): Likewise.
9268 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
9269 * w32gui.h (Time): Define by including "systime.h" rather than by
9270 declaring it ourselves. (Bug#8664)
9272 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9273 * image.c (clear_image_cache): Likewise.
9275 * term.c (term_mouse_position): Don't assume time_t wraparound.
9277 Be more systematic about user-interface timestamps.
9278 Before, the code sometimes used 'Time', sometimes 'unsigned long',
9279 and sometimes 'EMACS_UINT', to represent these timestamps.
9280 This change causes it to use 'Time' uniformly, as that's what X uses.
9281 This makes the code easier to follow, and makes it easier to catch
9282 integer overflow bugs such as Bug#8664.
9283 * frame.c (Fmouse_position, Fmouse_pixel_position):
9284 Use Time, not unsigned long, for user-interface timestamps.
9285 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9286 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9287 * keyboard.h (last_event_timestamp): Likewise.
9288 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9289 * menu.h (xmenu_show): Likewise.
9290 * term.c (term_mouse_position): Likewise.
9291 * termhooks.h (struct input_event.timestamp): Likewise.
9292 (struct terminal.mouse_position_hook): Likewise.
9293 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9294 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9295 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9296 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9298 * menu.h, termhooks.h: Include "systime.h", for Time.
9300 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9301 Don't assume that the difference between two unsigned long values
9302 can fit into an integer. At this point, we know button_down_time
9303 <= event->timestamp, so the difference must be nonnegative, so
9304 there's no need to cast the result if double-click-time is
9305 nonnegative, as it should be; check that it's nonnegative, just in
9306 case. This bug is triggered when events are more than 2**31 ms
9307 apart (about 25 days). (Bug#8664)
9309 * xselect.c (last_event_timestamp): Remove duplicate decl.
9310 (x_own_selection): Remove needless cast to unsigned long.
9312 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9313 that always fit in int. Use a sentinel instead of a counter, to
9314 avoid a temp and to allay GCC's concerns about possible int overflow.
9315 * frame.h (struct frame): Use int for menu_bar_items_used
9316 instead of EMACS_INT, since it always fits in int.
9318 * menu.c (grow_menu_items): Check for int overflow.
9320 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9322 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9323 Before, the code was not consistent. These values cannot exceed
9324 2**31 - 1 so there's no need to make them unsigned.
9325 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9326 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9327 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9329 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9331 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9332 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9333 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9334 presumably because the widths might not match.
9336 * window.c (size_window): Avoid needless test at loop start.
9338 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9340 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9342 2011-05-12 Drew Adams <drew.adams@oracle.com>
9344 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9346 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9348 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9349 `width' to `bar_area_x' and `bar_area_width', respectively.
9350 (x_scroll_run): Take account of fringe background extension.
9352 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9353 Rename local vars `left' and `width' to `bar_area_x' and
9354 `bar_area_width', respectively.
9355 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9356 background extension.
9358 2011-05-10 Jim Meyering <meyering@redhat.com>
9360 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9362 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
9364 * image.c (Finit_image_library): Return t for built-in image types,
9365 like pbm and xbm. (Bug#8640)
9367 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9369 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9371 2011-05-07 Eli Zaretskii <eliz@gnu.org>
9373 * w32console.c (Fset_screen_color): Doc fix.
9374 (Fget_screen_color): New function.
9375 (syms_of_ntterm): Defsubr it.
9377 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9378 unlink the temporary file if Fcall_process didn't create it in the
9380 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9381 child process will be redirected to a file specified with `:file'.
9382 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9383 cue to call_process_cleanup not to close that handle.
9385 2011-05-07 Ben Key <bkey76@gmail.com>
9387 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9388 one of two shell specific rules, either bootstrap-temacs-CMD or
9389 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9390 to the previous implementation of the bootstrap-temacs rule.
9391 The bootstrap-temacs-CMD rule is similar to the previous
9392 implementation of the bootstrap-temacs rule except that it
9393 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9396 These changes, along with some changes to nt/configure.bat,
9397 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9398 earlier fix to add support for --cflags and --ldflags options
9399 that include quotes so that it works whether make uses cmd or
9402 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
9404 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9405 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9407 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9408 a string. Handle both cases.
9409 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9410 (Fdbus_register_method): Use Qinvalid_function.
9412 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
9414 * makefile.w32-in: Update dependencies.
9415 (LISP_H): Add inttypes.h and stdin.h.
9416 (PROCESS_H): Add unistd.h.
9418 2011-05-06 Eli Zaretskii <eliz@gnu.org>
9420 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9421 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9423 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
9425 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9427 * term.c (vfatal): Remove stray call to va_end.
9428 It's not needed and the C Standard doesn't allow it here anyway.
9430 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9431 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9433 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9436 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9438 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9440 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9442 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9444 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9446 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9447 * charset.c (Fdefine_charset_internal): Don't initialize
9448 charset.code_space[15]. The value was garbage, on hosts with
9449 32-bit int (Bug#8600).
9451 * lread.c (read_integer): Be more consistent with string-to-number.
9452 Use string_to_number to do the actual conversion; this avoids
9453 rounding errors and fixes some other screwups. Without this fix,
9454 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9455 (digit_to_number): Move earlier, for benefit of read_integer.
9456 Return -1 if the digit is out of range for the base, -2 if it is
9457 not a digit in any supported base. (Bug#8602)
9459 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9461 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9462 to match comment at start of function. This also removes a
9463 GCC warning about overflow in a 32+64-bit port.
9465 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9467 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9468 Reported by Stefan Monnier in
9469 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
9470 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9471 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
9473 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9474 (EMACS_UINTPTR): Likewise, with uintptr_t.
9476 * lisp.h: Prefer 64-bit EMACS_INT if available.
9477 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9478 on 32-bit hosts that have 64-bit int, so that they can access
9480 However, temporarily disable this change unless the temporary
9481 symbol WIDE_EMACS_INT is defined.
9483 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9485 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9486 This removes an assumption that EMACS_INT and long are the same
9487 width as pointers. The assumption is true for Emacs porting targets
9488 now, but we want to make other targets possible.
9489 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9490 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9491 In the rest of the code, change types of integers that hold casted
9492 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9493 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9494 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9495 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9496 No need to cast type when ORing.
9497 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9498 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9499 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9500 assume EMACS_INT is the same width as char *.
9501 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9502 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9503 Remove no-longer-needed casts.
9504 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9505 (xg_tool_bar_help_callback, xg_make_tool_item):
9506 Use EMACS_INTPTR to hold an integer
9507 that will be cast to void *; this can avoid a GCC warning
9508 if EMACS_INT is not the same width as void *.
9509 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9510 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9511 (current_message_1, set_message_1):
9512 Use a local to convert to proper width without a cast.
9513 * xmenu.c (dialog_selection_callback): Likewise.
9515 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9516 Also, don't assume VALBITS / RAND_BITS is less than 5,
9517 and don't rely on undefined behavior when shifting a 1 left into
9519 * lisp.h (get_random): Change signature to match.
9521 * lread.c (hash_string): Use size_t, not int, for hash computation.
9522 Normally we prefer signed values; but hashing is special, because
9523 it's better to use unsigned division on hash table sizes so that
9524 the remainder is nonnegative. Also, size_t is the natural width
9525 for hashing into memory. The previous code used 'int', which doesn't
9526 retain enough info to hash well into very large tables.
9527 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9529 * dbusbind.c: Don't possibly lose pointer info when converting.
9530 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9531 Use XPNTR rather than XHASH, so that the high-order bits of
9532 the pointer aren't lost when converting through void *.
9534 * eval.c (Fautoload): Don't double-shift a pointer.
9536 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9538 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
9540 * gnutls.c (DEF_GNUTLS_FN):
9541 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9543 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9545 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9548 2011-05-05 Eli Zaretskii <eliz@gnu.org>
9550 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9551 New version that can reserve upto 2GB of heap space.
9553 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
9555 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9557 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9559 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9560 `gnutls_certificate_set_x509_key_file'.
9562 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
9564 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9565 Update dependencies.
9567 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9569 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9570 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9571 Remove unused parameter `fildes'.
9572 * process.c (read_process_output, send_process): Don't pass it.
9574 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9576 Fix previous change: the library cache is defined in w32.c.
9577 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9578 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9580 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9582 Implement dynamic loading of GnuTLS on Windows.
9584 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9585 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9586 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9589 * gnutls.c (Qgnutls_dll): Define.
9590 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9591 (gnutls_*): Declare function pointers.
9592 (init_gnutls_functions): New function to initialize function pointers.
9593 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9594 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9595 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9596 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9597 (emacs_gnutls_write, emacs_gnutls_read)
9598 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9599 (Fgnutls_available_p): New function.
9600 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9601 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9602 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9604 * image.c: Include w32.h.
9605 (Vimage_type_cache): Delete.
9606 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9607 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9608 (w32_delayed_load): Move to w32.c.
9610 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9612 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9613 (w32_delayed_load): Move from image.c. When loading a library, record
9614 its filename in the :loaded-from property of the library id.
9615 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9616 Initialize and staticpro them.
9617 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9619 * process.c: Include lisp.h before w32.h, not after.
9620 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9621 instead of gnutls_record_check_pending.
9623 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9625 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9627 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9628 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9631 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9633 * xterm.c (x_set_frame_alpha): Do not set property on anything
9634 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9636 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
9638 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9640 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
9642 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9643 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9644 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9645 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9646 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9647 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9648 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9649 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9650 (Qgnutls_bootprop_callbacks_verify): Make static.
9652 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9654 * callproc.c: Indentation fixup.
9656 * sysdep.c (wait_for_termination_1): Make static.
9657 (wait_for_termination, interruptible_wait_for_termination):
9658 Move after wait_for_termination_1.
9660 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9662 * sysdep.c (interruptible_wait_for_termination): New function
9663 which is like wait_for_termination, but allows keyboard
9666 * callproc.c (Fcall_process): Add (:file "file") as an option for
9668 (Fcall_process_region): Ditto.
9670 2011-04-30 Eli Zaretskii <eliz@gnu.org>
9672 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9673 rather than `XVECTOR (FOO)->size'.
9675 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9676 inttypes.h, as a gnulib replacement is used if it not available in
9679 2011-04-21 Eli Zaretskii <eliz@gnu.org>
9681 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9682 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9683 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9685 * coding.c (coding_alloc_by_realloc): Error out if destination
9686 will grow beyond MOST_POSITIVE_FIXNUM.
9687 (decode_coding_emacs_mule): Abort if there isn't enough place in
9688 charbuf for the composition carryover bytes. Reserve an extra
9689 space for up to 2 characters produced in a loop.
9690 (decode_coding_iso_2022): Abort if there isn't enough place in
9691 charbuf for the composition carryover bytes.
9693 2011-04-21 Eli Zaretskii <eliz@gnu.org>
9695 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9696 aborting when %lld or %lll format is passed.
9697 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9698 %llo or %llx format is passed. (Bug#8545)
9700 * window.c (window_scroll_line_based): Use a marker instead of
9701 simple variables to record original value of point. (Bug#7952)
9703 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9704 produced by %s or %c overflows available buffer space. (Bug#8545)
9706 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9708 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
9709 (SIZE_MAX): Move defn after all includes, as they might #define it.
9711 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9713 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9715 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9717 * keyboard.c (Qdelayed_warnings_hook): Define.
9718 (command_loop_1): Run `delayed-warnings-hook'
9719 if Vdelayed_warnings_list is non-nil.
9720 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9721 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9723 2011-04-28 Eli Zaretskii <eliz@gnu.org>
9725 * doprnt.c (doprnt): Don't return value smaller than the buffer
9726 size if the message was truncated. (Bug#8545).
9728 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9730 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9731 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9733 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9735 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9737 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
9739 * makefile.w32-in: Update dependencies.
9741 2011-04-27 Eli Zaretskii <eliz@gnu.org>
9743 Improve `doprnt' and its usage. (Bug#8545)
9744 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9745 `format_end'. Remove support for %l as a conversion specifier.
9746 Don't use xrealloc. Improve diagnostics when the %l size modifier
9747 is used. Update the commentary.
9749 * eval.c (verror): Simplify calculation of size_t.
9751 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9754 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9756 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9759 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9761 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9762 This makes this file independent of the recent pseudovector change.
9764 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
9766 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9768 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
9769 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
9770 Remove unused local.
9771 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
9773 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
9774 GCC 4.6.0 optimizes based on type-based alias analysis.
9775 For example, if b is of type struct buffer * and v of type struct
9776 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9777 != &v->size, and therefore "v->size = 1; b->size = 2; return
9778 v->size;" must therefore return 1. This assumption is incorrect
9779 for Emacs, since it type-puns struct Lisp_Vector * with many other
9780 types. To fix this problem, this patch adds a new type struct
9781 vectorlike_header that documents the constraints on layout of vectors
9782 and pseudovectors, and helps optimizing compilers not get fooled
9783 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9784 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
9785 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9787 (XSETPVECTYPE): Rewrite in terms of new macro.
9788 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9789 This is a bit clearer, and further avoids the possibility of
9790 undesirable aliasing.
9791 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
9792 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
9793 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9794 since Lisp_Subr is a special case (no "next" field).
9795 (ASIZE): Now uses header.size rather than size.
9796 All previous uses of XVECTOR (foo)->size replaced to use this macro,
9797 to avoid the hassle of writing XVECTOR (foo)->header.size.
9798 (struct vectorlike_header): New type.
9799 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9800 object, to help avoid aliasing.
9801 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9802 (SUBRP): Likewise, since Lisp_Subr is a special case.
9803 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9804 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9805 (struct Lisp_Hash_Table): Combine first two members into a single
9806 struct vectorlike_header member. All uses of "size" and "next" members
9807 changed to be "header.size" and "header.next".
9808 * buffer.h (struct buffer): Likewise.
9809 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9810 * frame.h (struct frame): Likewise.
9811 * process.h (struct Lisp_Process): Likewise.
9812 * termhooks.h (struct terminal): Likewise.
9813 * window.c (struct save_window_data, struct saved_window): Likewise.
9814 * window.h (struct window): Likewise.
9815 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9816 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9817 * buffer.c (init_buffer_once): Likewise.
9818 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9820 * process.c (Fformat_network_address): Use local var for size,
9823 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9825 Make the Lisp reader and string-to-float more consistent (Bug#8525)
9826 * data.c (atof): Remove decl; no longer used or needed.
9827 (digit_to_number): Move to lread.c.
9828 (Fstring_to_number): Use new string_to_number function, to be
9829 consistent with how the Lisp reader treats infinities and NaNs.
9830 Do not assume that floating-point numbers represent EMACS_INT
9831 without losing information; this is not true on most 64-bit hosts.
9832 Avoid double-rounding errors, by insisting on integers when
9833 parsing non-base-10 numbers, as the documentation specifies.
9834 * lisp.h (string_to_number): New decl, replacing ...
9835 (isfloat_string): Remove.
9836 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
9837 (read1): Do not accept +. and -. as integers; this
9838 appears to have been a coding error. Similarly, do not accept
9839 strings like +-1e0 as floating point numbers. Do not report
9840 overflow for integer overflows unless the base is not 10 which
9841 means we have no simple and reliable way to continue.
9842 Break out the floating-point parsing into a new
9843 function string_to_number, so that Fstring_to_number parses
9844 floating point numbers consistently with the Lisp reader.
9845 (digit_to_number): Move here from data.c. Make it static inline.
9846 (E_CHAR, EXP_INT): Remove, replacing with ...
9847 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9848 (string_to_number): New function, replacing isfloat_string.
9849 This function checks for valid syntax and produces the resulting
9850 Lisp float number too. Rework it so that string-to-number
9851 no longer mishandles examples like "1.0e+". Use strtoumax,
9852 so that overflow for non-base-10 numbers is reported only when
9853 there's no portable and simple way to convert to floating point.
9855 * textprop.c (set_text_properties_1): Rewrite for clarity,
9856 and to avoid GCC warning about integer overflow.
9858 * intervals.h (struct interval): Use EMACS_INT for members
9859 where EMACS_UINT might cause problems. See
9860 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9861 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9862 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9864 (offset_intervals): Tell GCC not to worry about length overflow
9865 when negating a negative length.
9867 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9868 (overrun_check_free): Likewise.
9870 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9871 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9874 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9875 (gnutls_make_error): Rename local to avoid shadowing.
9876 (gnutls_emacs_global_deinit): ifdef out; not used.
9877 (Fgnutls_boot): Use const for pointer to readonly storage.
9878 Comment out unused local. Fix pointer signedness problems.
9880 * lread.c (openp): Don't stuff size_t into an 'int'.
9881 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9882 about possible signed overflow.
9884 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9885 (GDK_KEY_g): Don't define if already defined.
9886 (xg_prepare_tooltip): Avoid pointer signedness problem.
9887 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9889 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9890 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9892 * xfns.c (Fx_window_property): Simplify a bit,
9893 to make a bit faster and to avoid GCC 4.6.0 warning.
9894 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9896 * fns.c (internal_equal): Don't assume size_t fits in int.
9898 * alloc.c (compact_small_strings): Tighten assertion a little.
9900 Replace pEd with more-general pI, and fix some printf arg casts.
9901 * lisp.h (pI): New macro, generalizing old pEd macro to other
9902 conversion specifiers. For example, use "...%"pI"d..." rather
9903 than "...%"pEd"...".
9904 (pEd): Remove. All uses replaced with similar uses of pI.
9905 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
9906 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9907 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9908 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9909 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9910 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9911 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9913 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9914 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9915 * print.c (safe_debug_print, print_object): Likewise.
9916 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9918 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9919 avoiding the 0 flag, which is not portable.
9920 * process.c (Fmake_network_process): Use pI to avoid cast.
9921 * region-cache.c (pp_cache): Likewise.
9922 * xdisp.c (decode_mode_spec): Likewise.
9923 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9924 behavior on 64-bit hosts with printf arg.
9925 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
9926 (x_stop_queuing_selection_requests): Likewise.
9927 (x_get_window_property): Don't truncate byte count to an 'int'
9930 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9931 here, since it parses constructs like leading '-' and spaces,
9932 which are not wanted; and it overflows with large numbers.
9933 Instead, simply match F[0-9]+, which is what is wanted anyway.
9935 * alloc.c: Remove unportable assumptions about struct layout.
9936 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9937 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9938 (allocate_vectorlike, make_pure_vector): Use the new macros,
9939 plus offsetof, to remove unportable assumptions about struct layout.
9940 These assumptions hold on all porting targets that I know of, but
9941 they are not guaranteed, they're easy to remove, and removing them
9942 makes further changes easier.
9944 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9945 This doesn't fix a bug but makes the code clearer.
9946 (string_overrun_cookie): Now const. Use initializers that
9947 don't formally overflow signed char, to avoid warnings.
9948 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9949 can cause Emacs to crash when string overrun checking is enabled.
9950 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9951 multiple of sizeof (EMACS_INT); it need not be, if
9952 alignof(EMACS_INT) < sizeof (EMACS_INT).
9953 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
9955 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
9957 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9959 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9961 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
9962 supposed to be handshaking. (Bug#8556)
9963 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9965 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
9967 * lisp.h (Qdebug): List symbol.
9968 * eval.c (Qdebug): Restore global linkage.
9969 * keyboard.c (debug-on-event): New variable.
9970 (handle_user_signal): Break into debugger when debug-on-event
9971 matches the current signal symbol.
9973 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9975 * alloc.c (check_sblock, check_string_bytes)
9976 (check_string_free_list): Convert to standard C.
9978 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9980 * w32.c (emacs_gnutls_push): Fix typo.
9982 2011-04-25 Eli Zaretskii <eliz@gnu.org>
9984 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9985 "cast to pointer from integer of different size".
9987 Improve doprnt and its use in verror. (Bug#8545)
9988 * doprnt.c (doprnt): Document the set of format control sequences
9989 supported by the function. Use SAFE_ALLOCA instead of always
9992 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9993 is one byte too soon. Don't use xrealloc; instead xfree and
9996 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9998 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10001 * gnutls.c: Renamed global_initialized to
10002 gnutls_global_initialized. Added internals for the
10003 :verify-hostname-error, :verify-error, and :verify-flags
10004 parameters of `gnutls-boot' and documented those parameters in the
10005 docstring. Start callback support.
10006 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10007 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10008 on error. Return error code.
10009 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10010 (emacs_gnutls_read): Likewise.
10011 (Fgnutls_boot): Return handshake error code.
10012 (emacs_gnutls_handle_error): New function.
10013 (wsaerror_to_errno): Likewise.
10015 * w32.h (emacs_gnutls_pull): Add prototype.
10016 (emacs_gnutls_push): Likewise.
10018 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10019 (emacs_gnutls_push): Likewise.
10021 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10023 * process.c (wait_reading_process_output): Check if GnuTLS
10024 buffered some data internally if no FDs are set for TLS
10027 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10028 (LIBS): Link to USER_LIBS.
10029 ($(BLD)/gnutls.$(0)): New target.
10031 2011-04-24 Eli Zaretskii <eliz@gnu.org>
10033 * xdisp.c (handle_single_display_spec): Rename the
10034 display_replaced_before_p argument into display_replaced_p, to
10035 make it consistent with the commentary. Fix typos in the
10038 * textprop.c (syms_of_textprop): Remove dead code.
10039 (copy_text_properties): Delete obsolete commentary about an
10040 interface that was deleted long ago. Fix typos in the description
10043 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10044 to changes in oldXMenu/XMenu.h from 2011-04-16.
10045 <menu_help_message, prev_menu_help_message>: Constify.
10046 (IT_menu_make_room): menu->help_text is now `const char **';
10049 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10050 to changes in oldXMenu/XMenu.h from 2011-04-16.
10051 (struct XMenu): Declare `help_text' `const char **'.
10053 * xfaces.c <Qunspecified>: Make extern again.
10055 * syntax.c: Include sys/types.h before including regex.h, as
10058 * doc.c (get_doc_string): Improve the format passed to `error'.
10060 * doprnt.c (doprnt): Improve commentary.
10062 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10064 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10067 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10068 changes in globals.h immediately force recompilation.
10069 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10070 $(CURDIR)/s/ms-w32.h.
10071 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
10073 * character.c (Fchar_direction): Function deleted.
10074 (syms_of_character): Don't defsubr it.
10075 <char-direction-table>: Deleted.
10077 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10079 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10080 * doprnt.c: Include limits.h.
10081 (SIZE_MAX): New macro.
10082 (doprnt): Return a size_t value. 2nd arg is now size_t.
10083 Many local variables are now size_t instead of int or unsigned.
10084 Improve overflow protection. Support `l' modifier for integer
10085 conversions. Support %l conversion. Don't assume an EMACS_INT
10086 argument for integer conversions and for %c.
10088 * lisp.h (doprnt): Restore prototype.
10090 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10091 $(SRC)/character.h.
10093 * Makefile.in (base_obj): Add back doprnt.o.
10095 * deps.mk (doprnt.o): Add back prerequisites.
10096 (callint.o): Depend on character.h.
10098 * eval.c (internal_lisp_condition_case): Include the handler
10099 representation in the error message.
10100 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10101 when breaking from the loop.
10103 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10105 * callint.c (Fcall_interactively): When displaying error message
10106 about invalid control letter, pass the character's codepoint, not
10107 a pointer to its multibyte form. Improve display of the character
10108 in octal and display also its hex code.
10110 * character.c (char_string): Use %x to display the (unsigned)
10111 codepoint of an invalid character, to avoid displaying a bogus
10114 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10115 `error', not SYMBOL_NAME itself.
10117 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10118 character arguments to `error'.
10120 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10121 to `error' in error message about FINAL_CHAR argument. Make sure
10122 FINAL_CHAR is a character, and use %c when it is passed as
10123 argument to `error'.
10125 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10127 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10129 * w32.c: Include <time.h>.
10130 (sys_localtime): New function.
10132 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
10134 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10136 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
10138 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
10140 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10141 zombies (Bug#8467).
10143 2011-04-19 Eli Zaretskii <eliz@gnu.org>
10145 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10146 gl_state.e_property when gl_state.object is Qt.
10148 * insdel.c (make_gap_larger): Remove limitation of buffer size
10151 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
10153 * xdisp.c (lookup_glyphless_char_display)
10154 (produce_glyphless_glyph): Handle cons cell entry in
10155 glyphless-char-display.
10156 (Vglyphless_char_display): Document it.
10158 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10159 glyphless-char-display.
10161 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
10163 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10165 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10167 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10168 definition for no-X builds.
10170 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
10172 Static checks with GCC 4.6.0 and non-default toolkits.
10174 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10176 * process.c (keyboard_bit_set): Define only if SIGIO.
10177 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10178 (send_process): Repair possible setjmp clobbering.
10180 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10182 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10184 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10186 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10187 Define only if needed.
10189 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10190 by pacifying GCC about it. Maybe it's time to retire it?
10191 * xfaces.c (USG, __TIMEVAL__): Likewise.
10193 * dispextern.h (struct redisplay_interface): Rename param
10194 to avoid shadowing.
10195 * termhooks.h (struct terminal): Likewise.
10196 * xterm.c (xembed_send_message): Likewise.
10198 * insdel.c (make_gap_smaller): Define only if
10199 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10201 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10204 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10205 so that we aren't warned about unused symbols.
10207 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10209 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
10211 * xfns.c (x_real_positions): Mark locals as initialized.
10213 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10215 * xterm.c: Fix problems found by static analysis with other toolkits.
10216 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
10217 (x_dispatch_event): Declare static if USE_GTK, and
10218 define if USE_GTK || USE_X_TOOLKIT.
10219 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
10220 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
10221 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10222 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
10224 * xmenu.c (menu_help_callback): Pointer type fixes.
10225 Use const pointers when pointing at readonly data. Avoid pointer
10226 signedness clashes.
10227 (FALSE): Remove unused macro.
10228 (update_frame_menubar): Remove unused decl.
10230 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10232 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10233 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10234 (single_menu_item): Rename local to avoid shadowing.
10236 * keyboard.c (make_lispy_event): Remove unused local var.
10238 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10239 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10241 * bitmaps: Change bitmaps from unsigned char back to the X11
10242 compatible char. Avoid the old compiler warnings about
10243 out-of-range initializers by using, for example, '\xab' rather
10246 * xgselect.c (xgselect_initialize): Check vs interface
10247 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10249 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10251 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10252 to read-only memory.
10254 * fns.c (vector): Remove; this old hack is no longer needed.
10256 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
10258 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
10260 * xrdb.c (x_load_resources): Omit unused local.
10262 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
10263 (x_window): Rename locals to avoid shadowing.
10264 (USG): Use the kludged USG macro, to pacify gcc.
10266 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
10267 (x_term_init): Remove local to avoid shadowing.
10269 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
10271 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10272 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10274 2011-04-16 Eli Zaretskii <eliz@gnu.org>
10276 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10278 Fix regex.c, syntax.c and friends for buffers > 2GB.
10279 * syntax.h (struct gl_state_s): Declare character position members
10282 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10284 * textprop.c (verify_interval_modification, interval_of):
10285 Declare arguments EMACS_INT.
10287 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10290 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10292 * indent.c (Fvertical_motion): Local variable it_start is now
10295 * regex.c (re_match, re_match_2, re_match_2_internal)
10296 (bcmp_translate, regcomp, regexec, print_double_string)
10297 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10298 (re_compile_pattern, re_exec): Declare arguments and local
10299 variables `size_t' and `ssize_t' and return values `regoff_t', as
10301 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10302 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10303 <compile_stack_type>: `size' and `avail' are now `size_t'.
10305 * regex.h <regoff_t>: Use ssize_t, not int.
10306 (re_search, re_search_2, re_match, re_match_2): Arguments that
10307 specify buffer/string position and length are now ssize_t and
10308 size_t. Return type is regoff_t.
10310 2011-04-16 Ben Key <bkey76@gmail.com>
10312 * nsfont.m: Fixed bugs in ns_get_family and
10313 ns_descriptor_to_entity that were caused by using free to
10314 deallocate memory blocks that were allocated by xmalloc (via
10315 xstrdup). This caused Emacs to crash when compiled with
10316 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10317 --enable-checking=xmallocoverrun). xfree is now used to
10318 deallocate these memory blocks.
10320 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
10322 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10324 emacs_write: Accept and return EMACS_INT for sizes.
10325 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10327 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10328 Accept and return EMACS_INT.
10329 (emacs_gnutls_write): Return the number of bytes written on
10331 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
10332 (emacs_read, emacs_write): Remove check for negative size, as the
10333 Emacs source code has been audited now.
10334 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10335 (emacs_read, emacs_write): Use it.
10336 * process.c (send_process): Adjust to the new signatures of
10337 emacs_write and emacs_gnutls_write. Do not attempt to store
10338 a byte offset into an 'int'; it might overflow.
10339 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
10341 * sound.c: Don't assume sizes fit in 'int'.
10342 (struct sound_device.period_size, alsa_period_size):
10343 Return EMACS_INT, not int.
10344 (struct sound_device.write, vox_write, alsa_write):
10345 Accept EMACS_INT, not int.
10346 (wav_play, au_play): Use EMACS_INT to store sizes and to
10347 record read return values.
10349 2011-04-15 Ben Key <bkey76@gmail.com>
10351 * keyboard.c (Qundefined): Don't declare static since it is used
10353 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10354 static since they are used in nsfont.m.
10356 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10358 * process.c (Qprocessp): Don't declare static.
10359 * lisp.h (Qprocessp): Declare again.
10361 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
10363 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10365 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10367 Improve C-level modularity by making more things 'static'.
10369 Don't publish debugger-only interfaces to other modules.
10370 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10371 (verify_bytepos, count_markers): Move decls to the only modules
10373 * region-cache.h (pp_cache): Likewise.
10374 * window.h (check_all_windows): Likewise.
10375 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10377 * sysdep.c (croak): Now static, if
10378 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10379 * syssignal.h (croak): Declare only if not static.
10381 * alloc.c (refill_memory_reserve): Now static if
10382 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10383 * lisp.h (refill_memory_reserve): Declare only if not static.
10385 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10386 Define only if USE_LUCID.
10388 * xrdb.c (x_customization_string, x_rm_string): Now static.
10390 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10391 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10393 * xdisp.c (draw_row_with_mouse_face): Now static.
10394 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10396 * window.h (check_all_windows): Mark externally visible.
10398 * window.c (window_deletion_count): Now static.
10400 * undo.c: Make symbols static if they're not exported.
10401 (last_undo_buffer, last_boundary_position, pending_boundary):
10404 * textprop.c (interval_insert_behind_hooks): Now static.
10405 (interval_insert_in_front_hooks): Likewise.
10407 * term.c: Make symbols static if they're not exported.
10408 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10409 (max_frame_lines, tty_set_terminal_modes):
10410 (tty_reset_terminal_modes, tty_turn_off_highlight):
10411 (get_tty_terminal): Now static.
10412 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10413 * termhooks.h (term_mouse_moveto): Do not declare if
10414 HAVE_WINDOW_SYSTEM.
10415 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10416 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10418 * sysdep.c: Make symbols static if they're not exported.
10419 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10421 (sigprocmask_set, full_mask): Remove; unused.
10422 (wait_debugging): Mark as visible.
10423 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10424 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10426 * syntax.c (syntax_temp): Define only if !__GNUC__.
10428 * sound.c (current_sound_device, current_sound): Now static.
10430 * search.c (searchbufs, searchbuf_head): Now static.
10432 * scroll.c (scroll_cost): Remove; unused.
10433 * dispextern.h (scroll_cost): Remove decl.
10435 * region-cache.h (pp_cache): Mark as externally visible.
10437 * process.c: Make symbols static if they're not exported.
10438 (process_tick, update_tick, create_process, chan_process):
10439 (Vprocess_alist, proc_buffered_char, datagram_access):
10440 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10441 (deactivate_process): Mark defn as static, as well as decl.
10442 * lisp.h (create_process): Remove decl.
10443 * process.h (chan_process, Vprocess_alist): Remove decls.
10445 * print.c: Make symbols static if they're not exported.
10446 (print_depth, new_backquote_output, being_printed, print_buffer):
10447 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10448 (print_interval, print_number_index, initial_stderr_stream):
10450 * lisp.h (Fprinc): Remove decl.
10451 (debug_output_compilation_hack): Mark as externally visible.
10453 * sysdep.c (croak): Move decl from here to syssignal.h.
10454 * syssignal.h (croak): Put it here, so the API can be checked when
10455 'croak' is called from dissociate_if_controlling_tty.
10457 * minibuf.c: Make symbols static if they're not exported.
10458 (minibuf_save_list, choose_minibuf_frame): Now static.
10459 * lisp.h (choose_minibuf_frame): Remove decl.
10461 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10463 * lread.c: Make symbols static if they're not exported.
10464 (read_objects, initial_obarray, oblookup_last_bucket_number):
10466 (make_symbol): Remove; unused.
10467 * lisp.h (initial_obarray, make_symbol): Remove decls.
10469 * keyboard.c: Make symbols static if they're not exported.
10470 (single_kboard, recent_keys_index, total_keys, recent_keys):
10471 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10472 (this_single_command_key_start, echoing, last_auto_save):
10473 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10474 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10475 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10476 (Vlispy_mouse_stem, double_click_count):
10478 (force_auto_save_soon): Define only if SIGDANGER.
10479 (ignore_mouse_drag_p): Now static if
10480 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10481 (print_help): Remove; unused.
10482 (stop_character, last_timer_event): Mark as externally visible.
10483 * keyboard.h (ignore_mouse_drag_p): Declare only if
10484 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10485 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10486 * lisp.h (echoing): Remove decl.
10487 (force_auto_save_soon): Declare only if SIGDANGER.
10488 * xdisp.c (redisplay_window): Simplify code, to make it more
10489 obvious that ignore_mouse_drag_p is not accessed if !defined
10490 USE_GTK && !defined HAVE_NS.
10492 * intervals.c: Make symbols static if they're not exported.
10493 (merge_properties_sticky, merge_interval_right, delete_interval):
10495 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10497 * insdel.c: Make symbols static if they're not exported.
10498 However, leave prepare_to_modify_buffer alone. It's never
10499 called from outside this function, but that appears to be a bug.
10500 (combine_after_change_list, combine_after_change_buffer):
10501 (adjust_after_replace, signal_before_change): Now static.
10502 (adjust_after_replace_noundo): Remove; unused.
10503 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
10504 (signal_before_change): Remove decls.
10506 * indent.c (val_compute_motion, val_vmotion): Now static.
10508 * image.c: Make symbols static if they're not exported.
10509 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10511 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10512 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10514 * fringe.c (standard_bitmaps): Now static.
10515 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10517 * frame.c: Make symbols static if they're not exported.
10518 (x_report_frame_params, make_terminal_frame): Now static.
10519 (get_frame_param): Now static, unless HAVE_NS.
10520 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10521 (x_get_resource_string): Remove; not used.
10522 * frame.h (make_terminal_frame, x_report_frame_params):
10523 (x_get_resource_string); Remove decls.
10524 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10525 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10527 * font.c, fontset.c: Make symbols static if they're not exported.
10528 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10529 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10530 * font.c (font_close_object): Now static.
10531 * font.h (font_close_object): Remove.
10532 * fontset.c (FONTSET_OBJLIST): Remove.
10533 (free_realized_fontset) #if-0 the body, which does nothing.
10534 (face_suitable_for_char_p): #if-0, as it's never called.
10535 * fontset.h (face_suitable_for_char_p): Remove decl.
10536 * xfaces.c (face_at_string_position):
10537 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
10538 since 0 is always ASCII.
10540 * fns.c (weak_hash_tables): Now static.
10542 * fileio.c: Make symbols static if they're not exported.
10543 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10544 (Vwrite_region_annotation_buffers): Now static.
10546 * eval.c: Make symbols static if they're not exported.
10547 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10548 * lisp.h (backtrace_list): Remove decl.
10550 * emacs.c: Make symbols static if they're not exported.
10551 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10552 (fatal_error_code, fatal_error_signal_hook, standard_args):
10554 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10555 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10556 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10557 * lisp.h (fatal_error_signal_hook): Remove decl.
10558 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10560 * editfns.c: Move a (normally-unused) function to its only use.
10561 * editfns.c, lisp.h (get_operating_system_release): Remove.
10562 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10563 worth the hassle of breaking this out.
10565 * xterm.c: Make symbols static if they're not exported.
10566 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10567 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10568 (x_destroy_window, x_delete_display):
10570 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10571 (x_mouse_leave): Remove; unused.
10572 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10573 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10574 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10576 (x_mouse_leave): Declare only if WINDOWSNT.
10577 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10578 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10581 * ftxfont.c: Make symbols static if they're not exported.
10582 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10584 * font.h (ftxfont_driver): Likewise.
10586 * xfns.c: Make symbols static if they're not exported.
10587 (x_last_font_name, x_display_info_for_name):
10588 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10589 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10590 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10591 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10592 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10593 (last_show_tip_args): Now static.
10594 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10595 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10596 (x_screen_planes): Remove; unused.
10597 * dispextern.h (x_screen_planes): Remove decl.
10599 * dispnew.c: Make symbols static if they're not exported.
10600 * dispextern.h (redraw_garbaged_frames, scrolling):
10601 (increment_row_positions): Remove.
10602 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10603 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10605 (redraw_garbaged_frames): Remove; unused.
10607 * xfaces.c: Make symbols static if they're not exported.
10608 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10610 * xterm.h (defined_color): Remove decls.
10611 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10612 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10613 (menu_face_changed_default, defined_color, free_realized_face):
10614 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10615 (ascii_face_of_lisp_face): Remove; unused.
10617 * xdisp.c: Make symbols static if they're not exported.
10618 * dispextern.h (scratch_glyph_row, window_box_edges):
10619 (glyph_to_pixel_coords, set_cursor_from_row):
10620 (get_next_display_element, set_iterator_to_next):
10621 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10622 (show_mouse_face): Remove decls
10623 * frame.h (message_buf_print): Likewise.
10624 * lisp.h (pop_message, set_message, check_point_in_composition):
10626 * xterm.h (set_vertical_scroll_bar): Likewise.
10627 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10628 (message_buf_print, scratch_glyph_row, displayed_buffer):
10629 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10630 (get_next_display_element, show_mouse_face, window_box_edges):
10631 (frame_to_window_pixel_xy, check_point_in_composition):
10632 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10633 (glyph_to_pixel_coords): Remove; unused.
10635 * dired.c (file_name_completion): Now static.
10637 * dbusbind.c (xd_in_read_queued_messages): Now static.
10639 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10640 * data.c (circular_list_error): Remove.
10642 * commands.h (last_point_position, last_point_position_buffer):
10643 (last_point_position_window): Remove decls.
10644 * keyboard.c: Make these variables static.
10646 * coding.h (coding, code_convert_region, encode_coding_gap):
10648 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10649 (iso_code_class, detect_coding, code_convert_region): Now static.
10650 (encode_coding_gap): Remove; unused.
10652 * chartab.c (chartab_chars, chartab_bits): Now static.
10654 * charset.h (charset_iso_8859_1): Remove decl.
10655 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10658 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10659 * ccl.c (Vccl_program_table): Now static.
10660 (check_ccl_update): Remove; unused.
10662 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10663 * category.h: ... from here.
10664 * category.c (check_category_table, set_category_set): Now static.
10666 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10667 * lisp.h: Remove these decls.
10669 * buffer.c (buffer_count): Remove unused var.
10671 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10672 so that it's not optimized away.
10673 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10674 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10675 exported only to the debugger.
10677 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
10678 * atimer.h (run_all_atimers): Remove; not exported.
10680 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10681 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10682 was inaccessible from Lisp.
10683 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10684 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10686 alloc.c: Import and export fewer symbols, and remove unused items.
10687 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10689 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10690 it's not optimized away by whole-program optimization.
10691 (message_enable_multibyte, free_misc): Remove.
10692 (catchlist, handlerlist, mark_backtrace):
10693 Declare only if BYTE_MARK_STACK.
10694 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10695 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10696 (message_enable_multibyte): Remove decl.
10697 (free_misc, interval_free_list, float_block, float_block_index):
10698 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10699 (cons_free_list, last_marked_index):
10701 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10702 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10703 (mark_backtrace): Define only if BYTE_MARK_STACK.
10704 * xdisp.c (message_enable_multibyte): Now static.
10706 Declare Lisp_Object Q* variables to be 'static' if not exported.
10707 This makes it easier for human readers (and static analyzers)
10708 to see whether these variables are used from other modules.
10709 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10710 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10711 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10712 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10713 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10714 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10715 * xmenu.c, xselect.c:
10716 Declare Q* vars static if they are not used in other modules.
10717 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10718 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10719 Remove decls of unexported vars.
10720 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10722 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10724 Make Emacs functions such as Fatom 'static' by default.
10725 This makes it easier for human readers (and static analyzers)
10726 to see whether these functions can be called from other modules.
10727 DEFUN now defines a static function. To make the function external
10728 so that it can be used in other C modules, use the new macro DEFUE.
10729 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10730 (Finit_image_library):
10731 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10732 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10733 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10734 Remove decls, since these functions are now static.
10735 (Funintern, Fget_internal_run_time): New decls, since these functions
10736 were already external.
10738 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10739 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10740 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10741 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10742 * keyboard.c, keymap.c, lread.c:
10743 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10744 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10745 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10746 Mark functions with DEFUE instead of DEFUN,
10747 if they are used in other modules.
10748 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10749 decls for now-static functions.
10750 * buffer.h (Fdelete_overlay): Remove decl.
10751 * callproc.c (Fgetenv_internal): Mark as internal.
10752 * composite.c (Fremove_list_of_text_properties): Remove decl.
10753 (Fcomposition_get_gstring): New forward static decl.
10754 * composite.h (Fcomposite_get_gstring): Remove decl.
10755 * dired.c (Ffile_attributes): New forward static decl.
10756 * doc.c (Fdocumntation_property): New forward static decl.
10757 * eval.c (Ffetch_bytecode): New forward static decl.
10758 (Funintern): Remove extern decl; now in .h file where it belongs.
10759 * fileio.c (Fmake_symbolic_link): New forward static decl.
10760 * image.c (Finit_image_library): New forward static decl.
10761 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10762 * intervals.h (Fprevious_property_change):
10763 (Fremove_list_of_text_properties): Remove decls.
10764 * keyboard.c (Fthis_command_keys): Remove decl.
10765 (Fcommand_execute): New forward static decl.
10766 * keymap.c (Flookup_key): New forward static decl.
10767 (Fcopy_keymap): Now static.
10768 * keymap.h (Flookup_key): Remove decl.
10769 * process.c (Fget_process): New forward static decl.
10770 (Fprocess_datagram_address): Mark as internal.
10771 * syntax.c (Fsyntax_table_p): New forward static decl.
10772 (skip_chars): Remove duplicate decl.
10773 * textprop.c (Fprevious_property_change): New forward static decl.
10774 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10776 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10777 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10779 * editfns.c (Fformat): Remove unreachable code.
10781 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10783 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10786 2011-04-13 Eli Zaretskii <eliz@gnu.org>
10788 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10789 when at ZV. (Bug#8487)
10791 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10793 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10795 * keyboard.c (parse_tool_bar_item): Likewise.
10796 * sound.c (sound_cleanup, alsa_close): Likewise.
10797 * termcap.c (tgetent): Likewise.
10798 * xfns.c (x_default_font_parameter): Likewise.
10799 * xsettings.c (read_and_apply_settings): Likewise.
10801 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10802 (overrun_check_free): Protoize.
10804 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10806 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10807 since callers should never pass a negative size.
10808 Change the signature to match that of plain 'read' and 'write'; see
10809 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10810 * lisp.h: Update prototypes of emacs_write and emacs_read.
10812 2011-04-11 Eli Zaretskii <eliz@gnu.org>
10814 * xdisp.c (redisplay_window): Don't try to determine the character
10815 position of the scroll margin if the window start point w->startp
10816 is outside the buffer's accessible region. (Bug#8468)
10818 2011-04-10 Eli Zaretskii <eliz@gnu.org>
10820 Fix write-region and its subroutines for buffers > 2GB.
10821 * fileio.c (a_write, e_write): Modify declaration of arguments and
10822 local variables to support buffers larger than 2GB.
10823 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10825 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10826 argument, local variables, and return value.
10828 * lisp.h: Update prototypes of emacs_write and emacs_read.
10830 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10832 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
10834 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10836 Fix more problems found by GCC 4.6.0's static checks.
10838 * xdisp.c (vmessage): Use a better test for character truncation.
10840 * charset.c (load_charset_map): <, not <=, for optimization,
10841 and to avoid potential problems with integer overflow.
10842 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
10843 * casetab.c (set_identity, shuffle): Likewise.
10844 * editfns.c (Fformat): Likewise.
10845 * syntax.c (skip_chars): Likewise.
10847 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10848 This also lets GCC 4.6.0 generate slightly better loop code.
10850 * callint.c (Fcall_interactively): <, not <=, for optimization.
10851 (Fcall_interactively): Count the number of arguments produced,
10852 not the number of arguments given. This is simpler and lets GCC
10853 4.6.0 generate slightly better code.
10855 * ftfont.c: Distingish more carefully between FcChar8 and char.
10856 The previous code passed unsigned char * to a functions like
10857 strlen and xstrcasecmp that expect char *, which does not
10858 conform to the C standard.
10859 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10860 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10861 char * when the C standard requires it.
10863 * keyboard.c (read_char): Remove unused var.
10865 * eval.c: Port to Windows vsnprintf (Bug#8435).
10866 Include <limits.h>.
10867 (SIZE_MAX): Define if the headers do not.
10868 (verror): Do not give up if vsnprintf returns a negative count.
10869 Instead, grow the buffer. This ports to Windows vsnprintf, which
10870 does not conform to C99. Problem reported by Eli Zaretskii.
10871 Also, simplify the allocation scheme, by avoiding the need for
10872 calling realloc, and removing the ALLOCATED variable.
10874 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10876 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10877 But keep the doprint source code for now, as we might revamp it
10878 and use it again (Bug#8435).
10879 * lisp.h (doprnt): Remove.
10880 * Makefile.in (base_obj): Remove doprnt.o.
10881 * deps.mk (doprnt.o): Remove.
10883 error: Print 32- and 64-bit integers portably (Bug#8435).
10884 Without this change, on typical 64-bit hosts error ("...%d...", N)
10885 was used to print both 32- and 64-bit integers N, which relied on
10886 undefined behavior.
10887 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
10888 * lisp.h (error, verror): Mark as printf-like functions.
10889 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10890 Report overflow in size calculations when allocating printf buffer.
10891 Do not truncate output string at its first null byte.
10892 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10893 Truncate the output at a character boundary, since vsnprintf does not
10895 * charset.c (check_iso_charset_parameter): Convert internal
10896 character to string before calling 'error', since %c now has the
10898 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10899 overflow when computing char to be passed to 'error'. Do not
10900 pass Lisp_Object to 'error'; pass the integer instead.
10901 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10902 formatted with plain %d.
10904 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10906 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10908 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10910 * xterm.c (x_catch_errors): Remove duplicate declaration.
10912 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10914 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10916 2011-04-10 Jim Meyering <meyering@redhat.com>
10918 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10919 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10920 return ssize_t not "int", and use size_t as the buffer length.
10921 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10922 * gnutls.h: Update declarations.
10923 * process.c (read_process_output): Use ssize_t, to match.
10924 (send_process): Likewise.
10926 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10928 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10930 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10932 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10933 Use unsigned char, to match FcChar8 type definition.
10935 * xterm.c (handle_one_xevent):
10936 * xmenu.c (create_and_show_popup_menu):
10937 * xselect.c (x_decline_selection_request)
10938 (x_reply_selection_request): Avoid type-punned deref of X events.
10940 2011-04-09 Eli Zaretskii <eliz@gnu.org>
10942 Fix some uses of `int' instead of EMACS_INT.
10943 * search.c (string_match_1, fast_string_match)
10944 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10945 (scan_buffer, find_next_newline_no_quit)
10946 (find_before_next_newline, search_command, Freplace_match)
10947 (Fmatch_data): Make some `int' variables be EMACS_INT.
10949 * xdisp.c (display_count_lines): 3rd argument and return value now
10950 EMACS_INT. All callers changed.
10951 (pint2hrstr): Last argument is now EMACS_INT.
10953 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10954 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10955 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10956 (decode_coding_utf_16, decode_coding_emacs_mule)
10957 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10958 (decode_coding_ccl, decode_coding_charset)
10959 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10960 (decode_coding_iso_2022, decode_coding_emacs_mule)
10961 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10962 <char_offset, last_offset>: Declare EMACS_INT.
10963 (encode_coding_utf_8, encode_coding_utf_16)
10964 (encode_coding_emacs_mule, encode_invocation_designation)
10965 (encode_designation_at_bol, encode_coding_iso_2022)
10966 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10967 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10969 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10970 (encode_invocation_designation): Last argument P_NCHARS is now
10972 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10973 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10975 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10978 * ccl.c (Fccl_execute_on_string): Declare some variables
10981 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
10983 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10985 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10987 * process.c (Fformat_network_address): Doc fix.
10989 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10991 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
10993 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
10995 * keyboard.c (read_char): Call Lisp function help-form-show,
10996 instead of using internal_with_output_to_temp_buffer.
10997 (Qhelp_form_show): New var.
10998 (syms_of_keyboard): Use DEFSYM macro.
11000 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11002 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11004 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
11006 * process.c (Flist_processes): Remove to Lisp.
11007 (list_processes_1): Delete.
11009 2011-04-06 Eli Zaretskii <eliz@gnu.org>
11011 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11013 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11015 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
11017 Fix more problems found by GCC 4.6.0's static checks.
11019 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11021 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11023 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
11025 * xdisp.c (vmessage): Mark as a printf-like function.
11027 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11029 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11031 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11032 printf-like functions.
11033 (tiff_load): Add casts to remove these marks before passing them
11034 to system-supplied API.
11036 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11038 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11039 This avoids several warnings with gcc -Wstrict-overflow.
11040 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11041 directly, rather than having caller test rule sign. This avoids
11042 some unnecessary tests.
11043 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11044 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11045 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
11047 * xfont.c (xfont_text_extents): Remove var that was set but not used.
11048 (xfont_open): Avoid unnecessary tests.
11050 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11052 * composite.h, composite.c (composition_gstring_put_cache):
11053 Use EMACS_INT, not int, for length.
11055 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11056 breaking out part of COMPOSITION_DECODE_RULE.
11057 (COMPOSITION_DECODE_RULE): Use it.
11058 * composite.c (get_composition_id): Remove unused local vars,
11059 by using the new macro.
11061 * textprop.c (set_text_properties_1): Change while to do-while,
11062 since the condition is always true at first.
11064 * intervals.c (graft_intervals_into_buffer): Mark var as used.
11065 (interval_deletion_adjustment): Return unsigned value.
11068 * process.c (list_processes_1, create_pty, read_process_output):
11069 (exec_sentinel): Remove vars that were set but not used.
11070 (create_pty): Remove unnecessary "volatile"s.
11071 (Fnetwork_interface_info): Avoid possibility of int overflow.
11072 (read_process_output): Do adaptive read buffering even if carryover.
11073 (read_process_output): Simplify nbytes computation if buffered.
11075 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11077 * syntax.c (scan_words): Remove var that was set but not used.
11078 (update_syntax_table): Use unsigned instead of int.
11080 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
11081 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
11082 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
11084 * print.c (print_error_message): Avoid int overflow.
11086 * font.c (font_list_entities): Redo for clarity,
11087 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11089 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
11090 (font_score): Avoid potential overflow in diff calculation.
11092 * fns.c (substring_both): Remove var that is set but not used.
11093 (sxhash): Redo loop for clarity and to avoid wraparound warning.
11095 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11097 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11098 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11099 can always succeed if overflow has undefined behavior.
11101 * search.c (boyer_moore, wordify): Remove vars set but not used.
11102 (wordify): Omit three unnecessary tests.
11104 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11105 All callers changed. This avoids the need for an unused var.
11107 * casefiddle.c (casify_region): Remove var that is set but not used.
11109 * dired.c (file_name_completion): Remove var that is set but not used.
11111 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11113 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
11114 (Finsert_file_contents): Remove unnecessary code checking fd.
11116 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11117 Check for integer overflow on size calculations.
11119 * buffer.c (Fprevious_overlay_change): Remove var that is set
11122 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11123 Remove vars that are set but not used.
11124 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
11125 (timer_check_2): Mark vars as initialized.
11127 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11129 * image.c (lookup_image): Remove var that is set but not used.
11130 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
11132 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11133 that are set but not used.
11135 * xfns.c (make_invisible_cursor): Don't return garbage
11136 if XCreateBitmapFromData fails (Bug#8410).
11138 * xselect.c (x_get_local_selection, x_handle_property_notify):
11139 Remove vars that are set but not used.
11141 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
11142 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
11144 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11145 Remove var that is set but not used.
11146 (scroll_bar_windows_size): Now size_t, not int.
11147 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11148 Check for overflow.
11150 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11151 (map_tty_color) [!defined MSDOS]: Likewise.
11153 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11155 * coding.c: Remove vars that are set but not used.
11156 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11157 All callers changed.
11158 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11159 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11160 (decode_coding_charset): Remove vars that are set but not used.
11162 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11163 that is set but not used.
11165 * print.c (print_object): Remove var that is set but not used.
11167 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
11168 The gnulib version avoids calling malloc in the usual case,
11169 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11170 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11171 * filelock.c (current_lock_owner): Likewise.
11172 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11173 * sysdep.c: Include allocator.h, careadlinkat.h.
11174 (emacs_no_realloc_allocator): New static constant.
11175 (emacs_readlink): New function.
11176 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11177 ../lib/careadlinkat.h.
11179 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11181 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11182 first non-nil return value).
11184 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11186 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11187 if not defined (Bug#8403).
11189 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11191 * xdisp.c (display_count_lines): Remove parameter `start',
11192 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11193 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11194 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11195 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11196 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11197 and thereabouts. All callers changed.
11198 (get_per_char_metric): Remove parameter `f', unused since
11199 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11201 2011-04-02 Jim Meyering <meyering@redhat.com>
11203 do not dereference NULL upon failed strdup
11204 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11205 (ns_get_family): Likewise.
11207 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11209 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11211 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11213 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11216 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11218 Add lexical binding.
11220 * window.c (Ftemp_output_buffer_show): New fun.
11221 (Fsave_window_excursion):
11222 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11224 * lread.c (lisp_file_lexically_bound_p): New function.
11225 (Fload): Bind Qlexical_binding.
11226 (readevalloop): Remove `evalfun' arg.
11227 Bind Qinternal_interpreter_environment.
11228 (Feval_buffer): Bind Qlexical_binding.
11229 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11231 (syms_of_lread): Declare `lexical-binding'.
11233 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11235 * keyboard.c (eval_dyn): New fun.
11236 (menu_item_eval_property): Use it.
11238 * image.c (parse_image_spec): Use Ffunctionp.
11240 * fns.c (concat, mapcar1): Accept byte-code-functions.
11242 * eval.c (Fsetq): Handle lexical vars.
11243 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11244 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11245 (FletX, Flet): Obey lexical binding.
11246 (Fcommandp): Handle closures.
11247 (Feval): New `lexical' arg.
11248 (eval_sub): New function extracted from Feval. Use it almost
11249 everywhere where Feval was used. Look up vars in lexical env.
11251 (Ffunctionp): Move from subr.el.
11252 (Ffuncall): Handle closures.
11253 (apply_lambda): Remove `eval_flags'.
11254 (funcall_lambda): Handle closures and new byte-code-functions.
11255 (Fspecial_variable_p): New function.
11256 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11257 but without exporting it to Lisp.
11259 * doc.c (Fdocumentation, store_function_docstring):
11260 * data.c (Finteractive_form): Handle closures.
11262 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11265 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11267 (exec_byte_code): New function extracted from Fbyte_code to handle new
11268 calling convention for byte-code-functions. Add new byte-codes.
11270 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
11272 * alloc.c (Fmake_symbol): Init new `declared_special' field.
11274 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
11276 * xdisp.c (redisplay_internal): Fix prototype.
11278 2011-03-31 Eli Zaretskii <eliz@gnu.org>
11280 * xdisp.c (SCROLL_LIMIT): New macro.
11281 (try_scrolling): Use it when setting scroll_limit.
11282 Limit scrolling to 100 screen lines.
11283 (redisplay_window): Even when falling back on "recentering",
11284 position point in the window according to scroll-conservatively,
11285 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11287 (try_scrolling): When point is above the window, allow searching
11288 as far as scroll_max, or one screenful, to compute vertical
11289 distance from PT to the scroll margin position. This prevents
11290 try_scrolling from unnecessarily failing when
11291 scroll-conservatively is set to a value slightly larger than the
11292 window height. Clean up the case of PT below the margin at bottom
11293 of window: scroll_max can no longer be INT_MAX. When aggressive
11294 scrolling is in use, don't let point enter the opposite scroll
11295 margin as result of the scroll.
11296 (syms_of_xdisp) <scroll-conservatively>: Document the
11297 threshold of 100 lines for never-recentering scrolling.
11299 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
11301 * dispextern.h (move_it_by_lines):
11302 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11303 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11304 (message_log_check_duplicate): Remove parameters `prev_bol' and
11305 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11306 (redisplay_internal): Remove parameter `preserve_echo_area',
11307 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11309 * indent.c (Fvertical_motion):
11310 * window.c (window_scroll_pixel_based, Frecenter):
11311 Don't pass `need_y_p' to `move_it_by_lines'.
11313 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11315 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11316 steal a few bits to be more compact.
11317 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11318 Remove unneeded casts.
11320 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11322 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11324 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11325 binding" message (bug#7967).
11327 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11329 Fix more problems found by GCC 4.6.0's static checks.
11331 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11332 Remove unused local var.
11334 * editfns.c (Fmessage_box): Remove unused local var.
11336 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11337 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11338 Omit unused local vars.
11339 * window.c (shrink_windows): Omit unused local var.
11340 * menu.c (digest_single_submenu): Omit unused local var.
11341 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11342 Omit unused local var.
11344 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11345 Don't assume string length fits in int.
11346 (keyremap_step, read_key_sequence): Use size_t for sizes.
11347 (read_key_sequence): Don't check last_real_key_start redundantly.
11349 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11350 instead of alloca (Bug#8344).
11352 * eval.c (Fbacktrace): Don't assume nargs fits in int.
11353 (Fbacktrace_frame): Don't assume nframes fits in int.
11355 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11357 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11360 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11362 * cm.c (calccost): Turn while-do into do-while, for clarity.
11364 * keyboard.c (syms_of_keyboard): Use the same style as later
11365 in this function when indexing through an array. This also
11366 works around GCC bug 48267.
11368 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11370 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11372 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11373 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11375 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11376 This avoids undefined behavior on integer overflow, and is a bit
11377 more convenient anyway since it is compared to a size_t variable.
11379 Variadic C functions now count arguments with size_t, not int.
11380 This avoids an unnecessary limitation on 64-bit machines, which
11381 caused (substring ...) to crash on large vectors (Bug#8344).
11382 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11383 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
11384 All variadic functions and their callers changed accordingly.
11385 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11386 * data.c (arith_driver, float_arith_driver): Likewise.
11387 * editfns.c (general_insert_function): Likewise.
11388 * eval.c (struct backtrace.nargs, interactive_p)
11389 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11390 (funcall_lambda, mark_backtrace): Likewise.
11391 * fns.c (concat): Likewise.
11392 * frame.c (x_set_frame_parameters): Likewise.
11393 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11394 0 if not found, not -1. All callers changed.
11396 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11397 (stack_copy_size): Now size_t, not int.
11398 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11400 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
11402 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11403 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11404 All callers changed.
11406 * lisp.h (multibyte_char_to_unibyte):
11407 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11408 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11409 * character.h (CHAR_TO_BYTE8):
11410 * cmds.c (internal_self_insert):
11411 * editfns.c (general_insert_function):
11412 * keymap.c (push_key_description):
11413 * search.c (Freplace_match):
11414 * xdisp.c (message_dolog, set_message_1): All callers changed.
11416 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11418 * keyboard.c (safe_run_hook_funcall): New function.
11419 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11420 don't set the hook to nil, but remove the offending function instead.
11421 (Qcommand_hook_internal): Remove, unused.
11422 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11423 Vcommand_hook_internal.
11425 * eval.c (enum run_hooks_condition): Remove.
11426 (funcall_nil, funcall_not): New functions.
11427 (run_hook_with_args): Call each function through a `funcall' argument.
11428 Remove `cond' argument, now redundant.
11429 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11430 (Frun_hook_with_args_until_failure): Adjust accordingly.
11431 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11433 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
11435 * dispextern.h (string_buffer_position): Remove declaration.
11437 * print.c (strout): Remove parameter `multibyte', unused since
11438 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11440 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11441 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11442 All callers changed.
11444 * w32.c (_wsa_errlist): Use braces for struct initializers.
11446 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11447 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11448 All callers changed.
11449 (string_buffer_position): Likewise. Also, make static (it's never
11450 used outside xdisp.c).
11451 (cursor_row_p): Remove parameter `w', unused since
11452 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11453 (decode_mode_spec): Remove parameter `precision', introduced during
11454 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11455 All callers changed.
11457 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11459 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11461 2011-03-27 Anders Lindgren <andlind@gmail.com>
11463 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11464 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11465 (ns_update_auto_hide_menu_bar): New functions.
11466 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11467 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11468 ns_constrain_all_frames.
11469 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11470 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11472 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11474 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11476 2011-03-27 Glenn Morris <rgm@gnu.org>
11478 * syssignal.h: Replace RETSIGTYPE with void.
11479 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11480 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11481 Replace SIGTYPE with void everywhere.
11482 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11483 * s/template.h (SIGTYPE): Remove commented out definition.
11485 2011-03-26 Eli Zaretskii <eliz@gnu.org>
11487 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11488 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11490 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
11492 * w32.c (read_unc_volume): Use parameter `henum', instead of
11493 global variable `wget_enum_handle'.
11495 * keymap.c (describe_vector): Remove parameters `indices' and
11496 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11497 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11499 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11501 * keyboard.c (timer_check): Remove parameter `do_it_now',
11502 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11503 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11504 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11506 * keyboard.c (read_char):
11507 * w32menu.c (w32_menu_display_help):
11508 * xmenu.c (show_help_event, menu_help_callback):
11509 Adjust calls to `show_help_echo'.
11511 * gtkutil.c (xg_maybe_add_timer):
11512 * keyboard.c (readable_events):
11513 * process.c (wait_reading_process_output):
11514 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11516 * insdel.c (adjust_markers_gap_motion):
11517 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11518 (gap_left, gap_right): Don't call it.
11520 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
11522 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11523 incurred during fontification.
11525 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
11527 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11528 (DEFVAR_PER_BUFFER): Don't pass it.
11530 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11531 (scrolling_window): Don't pass it.
11533 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
11535 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11537 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11539 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11540 of variables specific to SELinux and computation of `encoded_absname'.
11542 * image.c (XPutPixel): Remove unused variable `height'.
11544 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11546 * unexw32.c (get_section_info): Remove unused variable `section'.
11548 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11549 (system_process_attributes): Remove unused variable `sess'.
11550 (sys_read): Remove unused variable `err'.
11552 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11553 (w32_wnd_proc): Remove unused variable `isdead'.
11554 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11555 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11556 (x_create_tip_frame): Remove unused variable `tem'.
11558 * w32inevt.c (w32_console_read_socket):
11559 Remove unused variable `no_events'.
11561 * w32term.c (x_draw_composite_glyph_string_foreground):
11562 Remove unused variable `width'.
11564 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
11566 * w32term.c (x_set_glyph_string_clipping):
11567 Don't pass uninitialized region to CombineRgn.
11569 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
11571 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11572 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11573 (Fx_close_connection): Remove unused variable `i'.
11575 * w32font.c (w32font_draw): Return number of glyphs.
11576 (w32font_open_internal): Remove unused variable `i'.
11577 (w32font_driver): Add missing initializer.
11579 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11580 (fill_in_menu): Remove unused variable `items_added'.
11582 * w32term.c (last_mouse_press_frame): Remove static global variable.
11583 (w32_clip_to_row): Remove unused variable `f'.
11584 (x_delete_terminal): Remove unused variable `i'.
11586 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11587 (NOTHING): Remove unused static global variable.
11588 (uniscribe_check_otf): Remove unused variable `table'.
11589 (uniscribe_font_driver): Add missing initializers.
11591 2011-03-23 Julien Danjou <julien@danjou.info>
11593 * term.c (Fsuspend_tty, Fresume_tty):
11594 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11595 * window.c (temp_output_buffer_show):
11596 * insdel.c (signal_before_change):
11597 * frame.c (Fhandle_switch_frame):
11598 * fileio.c (Fdo_auto_save):
11599 * emacs.c (Fkill_emacs):
11600 * editfns.c (save_excursion_restore):
11601 * cmds.c (internal_self_insert):
11602 * callint.c (Fcall_interactively):
11603 * buffer.c (Fkill_all_local_variables):
11604 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11606 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
11607 unconditionally since it does the check itself.
11609 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
11611 Fix more problems found by GCC 4.5.2's static checks.
11613 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11614 the first time through the loop, since we know p0 < p1 then.
11615 This also avoids a gcc -Wstrict-overflow warning.
11617 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11618 leading to a memory leak, possible in functions like
11619 load_charset_map_from_file that can allocate an unbounded number
11620 of objects (Bug#8318).
11622 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11623 that could (at least in theory) be that large.
11625 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11626 This is less likely to overflow, and avoids undefined behavior if
11627 overflow does occur. All callers changed. Use strtoul to scan
11628 for the unsigned long integer.
11629 (pint2hrstr): Simplify and tune code slightly.
11630 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
11632 * scroll.c (do_scrolling): Work around GCC bug 48228.
11633 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11635 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11636 This also avoids a warning with gcc -Wstrict-overflow.
11637 (validate_x_resource_name): Simplify count usage.
11638 This also avoids a warning with gcc -Wstrict-overflow.
11640 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11643 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
11645 * process.c (Fmake_network_process): Use socklen_t, not int,
11646 where POSIX says socklen_t is required in portable programs.
11647 This fixes a porting bug on hosts like 64-bit HP-UX, where
11648 socklen_t is wider than int (Bug#8277).
11649 (Fmake_network_process, server_accept_connection):
11650 (wait_reading_process_output, read_process_output):
11653 * process.c: Rename or move locals to avoid shadowing.
11654 (list_processes_1, Fmake_network_process):
11655 (read_process_output_error_handler, exec_sentinel_error_handler):
11656 Rename or move locals.
11657 (Fmake_network_process): Define label "retry_connect" only if needed.
11658 (Fnetwork_interface_info): Fix pointer signedness.
11659 (process_send_signal): Add cast to avoid pointer signedness problem.
11660 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
11661 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
11663 Make tparam.h and terminfo.c consistent.
11664 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11665 Include tparam.h instead, since it declares them.
11666 * cm.h (PC): Remove extern decl; tparam.h now does this.
11667 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11668 * terminfo.c: Include tparam.h, to check interfaces.
11669 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11670 (tparam): Adjust signature to match interface in tparam.h;
11671 this removes some undefined behavior. Check that outstring and len
11672 are zero, which they always are with Emacs.
11673 * tparam.h (PC, BC, UP): New extern decls.
11675 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
11676 (xftfont_open): Rename locals to avoid shadowing.
11678 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
11679 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11680 (OTF_TAG_SYM): Omit macro if not needed.
11681 (ftfont_list): Remove unused local.
11682 (get_adstyle_property, ftfont_pattern_entity):
11683 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11684 Rename locals to avoid shadowing.
11686 * xfont.c (xfont_list_family): Mark var as initialized.
11688 * xml.c (make_dom): Now static.
11690 * composite.c (composition_compute_stop_pos): Rename local to
11692 (composition_reseat_it): Remove unused locals.
11693 (find_automatic_composition, composition_adjust_point): Likewise.
11694 (composition_update_it): Mark var as initialized.
11695 (find_automatic_composition): Mark vars as initialized,
11696 with a FIXME (Bug#8290).
11698 character.h: Rename locals to avoid shadowing.
11699 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11700 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11701 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11702 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11703 to avoid shadowing.
11705 * textprop.c (property_change_between_p): Remove; unused.
11707 * intervals.c (interval_start_pos): Now static.
11709 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11711 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11712 Rename locals to avoid shadowing.
11714 * sound.c (wav_play, au_play, Fplay_sound_internal):
11715 Fix pointer signedness.
11716 (alsa_choose_format): Remove unused local var.
11717 (wav_play): Initialize a variable to 0, to prevent undefined
11718 behavior (Bug#8278).
11720 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11722 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11724 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11725 clobbering (Bug#8298).
11726 * sysdep.c (sys_subshell): Likewise.
11727 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
11729 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11730 This should get cleaned up, so that child_setup has the
11731 same signature on all platforms.
11733 * callproc.c (call_process_cleanup): Now static.
11734 (relocate_fd): Rename locals to avoid shadowing.
11736 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
11738 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11739 not to be necessary, and produces flickering.
11741 2011-03-20 Glenn Morris <rgm@gnu.org>
11743 * config.in: Remove file.
11745 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
11747 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11748 are now in src/globals.h.
11749 (syms_of_minibuf): Remove spurious & from previous change.
11751 2011-03-20 Leo Liu <sdl.web@gmail.com>
11753 * minibuf.c (completing-read-function): New variable.
11754 (completing-read-default): Rename from completing-read.
11755 (completing-read): Call completing-read-function.
11757 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
11759 * xfaces.c (Fx_load_color_file):
11760 Read color file from absolute filename (bug#8250).
11762 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
11764 * makefile.w32-in: Update dependencies.
11766 2011-03-17 Eli Zaretskii <eliz@gnu.org>
11768 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11770 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11772 Fix more problems found by GCC 4.5.2's static checks.
11774 * process.c (make_serial_process_unwind, send_process_trap):
11775 (sigchld_handler): Now static.
11777 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11778 That way, the code declares only the vars that it needs.
11779 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11780 * s/cygwin.h (PTY_ITERATION): Likewise.
11781 * s/darwin.h (PTY_ITERATION): Likewise.
11782 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11784 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11785 * process.c (allocate_pty): Don't declare stb unless it's needed.
11787 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
11788 (CONSTANTLIM): Remove; unused.
11789 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11790 Define only if needed.
11792 * unexelf.c (unexec): Name an expression,
11793 to avoid gcc -Wbad-function-cast warning.
11794 Use a different way to cause a compilation error if anyone uses
11795 n rather than nn, a way that does not involve shadowing.
11796 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
11798 * deps.mk (unexalpha.o): Remove; unused.
11800 New file unexec.h, the (simple) interface for unexec (Bug#8267).
11801 * unexec.h: New file.
11802 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11803 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11804 Depend on unexec.h.
11805 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11806 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11807 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
11808 Change as necessary to match prototype in unexec.h.
11810 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11812 (back_comment, skip_chars): Mark vars as initialized.
11814 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11815 Rename locals to avoid shadowing.
11817 * lread.c (read1): Rewrite so as not to use empty "else".
11818 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
11820 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11822 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11823 warning when compiling print.c.
11825 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11826 instead of using an uninitialized var.
11827 (font_sort_entities): Mark var as initialized.
11829 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11831 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11832 pointers to constants.
11833 (font_parse_fcname): Remove unused vars.
11834 (font_delete_unmatched): Now static.
11835 (font_get_spec): Remove; unused.
11836 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11837 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11838 Rename or move locals to avoid shadowing.
11840 * fns.c (require_nesting_list, require_unwind): Now static.
11841 (Ffillarray): Rename locals to avoid shadowing.
11843 * floatfns.c (domain_error2): Define only if needed.
11844 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
11846 * alloc.c (mark_backtrace): Move decl from here ...
11847 * lisp.h: ... to here, so that it can be checked.
11849 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
11850 (Fdefvar): Rewrite so as not to use empty "else".
11851 (lisp_indirect_variable): Name an expression,
11852 to avoid gcc -Wbad-function-cast warning.
11853 (Fdefvar): Rename locals to avoid shadowing.
11855 * callint.c (quotify_arg, quotify_args): Now static.
11856 (Fcall_interactively): Rename locals to avoid shadowing.
11857 Use const pointer when appropriate.
11859 * lisp.h (get_system_name, get_operating_system_release):
11860 Move decls here, to check interfaces.
11861 * process.c (get_operating_system_release): Move decl to lisp.h.
11862 * xrdb.c (get_system_name): Likewise.
11863 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11864 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11865 some of which prompt warnings from gcc -Wbad-function-cast.
11866 (Fformat_time_string, Fencode_time, Finsert_char):
11867 (Ftranslate_region_internal, Fformat):
11868 Rename or remove local vars to avoid shadowing.
11869 (Ftranslate_region_internal): Mark var as initialized.
11871 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11874 * lisp.h (eassert): Check that the argument compiles, even if
11875 ENABLE_CHECKING is not defined.
11877 * data.c (Findirect_variable): Name an expression, to avoid
11878 gcc -Wbad-function-cast warning.
11879 (default_value, arithcompare, arith_driver, arith_error): Now static.
11880 (store_symval_forwarding): Rename local to avoid shadowing.
11881 (Fmake_variable_buffer_local, Fmake_local_variable):
11882 Mark variables as initialized.
11883 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
11885 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
11886 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11887 Rename locals to avoid shadowing.
11888 (mark_stack): Move local variables into the #ifdef region where
11890 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11891 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11893 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11894 (GC_STRING_CHARS): Remove; not used.
11895 (Fmemory_limit): Cast sbrk's returned value to char *.
11897 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11898 avoids undefined behavior in theory.
11900 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11902 Use functions, not macros, for up- and down-casing (Bug#8254).
11903 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11904 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11905 to use the following functions instead of these macros.
11906 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11907 EMACS_INT, since callers assume the returned value fits in int.
11908 (upcase1): Likewise, for UPCASE_TABLE.
11909 (uppercasep, lowercasep, upcase): New static inline functions.
11910 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
11911 the race-condition problem in the old DOWNCASE.
11913 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11914 Rename locals to avoid shadowing.
11915 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
11916 (regex_compile, re_search_2, re_match_2_internal):
11917 Remove unused local vars.
11918 (FREE_VAR): Rewrite so as not to use empty "else",
11919 which gcc can warn about.
11920 (regex_compile, re_match_2_internal): Mark locals as initialized.
11921 (RETALLOC_IF): Define only if needed.
11922 (WORDCHAR_P): Likewise. This one is never needed, but is used
11923 only in a comment talking about a compiler bug, so put inside
11924 the #if 0 of that comment.
11925 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11926 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11929 * search.c (boyer_moore): Rename locals to avoid shadowing.
11930 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11931 (PREV_CHAR_BOUNDARY): Likewise.
11933 * search.c (simple_search): Remove unused var.
11935 * dired.c (compile_pattern): Move decl from here ...
11936 * lisp.h: ... to here, so that it can be checked.
11937 (struct re_registers): New forward decl.
11939 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11941 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11943 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11944 Rename locals to avoid shadowing.
11945 (Fvertical_motion): Mark locals as initialized.
11947 * casefiddle.c (casify_object, casify_region): Now static.
11948 (casify_region): Mark local as initialized.
11950 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11952 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11953 New macros, so that the caller can use some names other than
11954 gcpro1, gcpro2, etc.
11955 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11957 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11958 argument, for consistency with GCPRO2_VAR, etc: it is now the
11959 prefix of the variable, not the variable itself. All uses
11961 * dired.c (directory_files_internal, file_name_completion):
11962 Rename locals to avoid shadowing.
11964 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11965 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11966 dired.c's scmp function, had undefined behavior.
11967 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11968 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11969 * buffer.h: ... to here, because these macros use current_buffer,
11970 and the new implementation with inline functions needs to have
11971 current_buffer in scope now, rather than later when the macros
11973 (downcase, upcase1): New static inline functions.
11974 (DOWNCASE, UPCASE1): Reimplement using these functions.
11975 This avoids undefined behavior in expressions like
11976 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11977 from race conditions in accessing the global variables
11978 case_temp1 and case_temp2.
11979 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11980 * lisp.h (case_temp1, case_temp2): Remove their decls.
11981 * character.h (ASCII_CHAR_P): Move from here ...
11982 * lisp.h: ... to here, so that the inline functions mentioned
11983 above can use them.
11985 * dired.c (directory_files_internal_unwind): Now static.
11987 * fileio.c (file_name_as_directory, directory_file_name):
11988 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11990 (file_name_as_directory): Use const pointers when appropriate.
11991 (Fexpand_file_name): Likewise. In particular, newdir might
11992 point at constant storage, so make it a const pointer.
11993 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
11994 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11996 (Fset_file_times, Finsert_file_contents, auto_save_error):
11997 Rename locals to avoid shadowing.
11999 * minibuf.c (choose_minibuf_frame_1): Now static.
12000 (Ftry_completion, Fall_completions): Rename or remove locals
12001 to avoid shadowing.
12003 * marker.c (bytepos_to_charpos): Remove; unused.
12005 * lisp.h (verify_bytepos, count_markers): New decls,
12006 so that gcc does not warn that these functions aren't declared.
12008 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12009 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
12010 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
12011 (copy_text): Remove unused local var.
12013 * filelock.c (within_one_second): Now static.
12014 (lock_file_1): Rename local to avoid shadowing.
12016 * buffer.c (fix_overlays_before): Mark locals as initialized.
12017 (fix_start_end_in_overlays): Likewise. This function should be
12018 simplified by using pointers-to-pointers, but that's a different
12020 (switch_to_buffer_1): Now static.
12021 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12022 (report_overlay_modification): Rename locals to avoid shadowing.
12024 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
12025 Fix pointer signedness issue.
12026 (sys_subshell): Mark local as volatile if checking for lint,
12027 to suppress a gcc -Wclobbered warning that does not seem to be right.
12028 (MAXPATHLEN): Define only if needed.
12030 * process.c (serial_open, serial_configure): Move decls from here ...
12031 * systty.h: ... to here, so that they can be checked.
12033 * fns.c (get_random, seed_random): Move extern decls from here ...
12034 * lisp.h: ... to here, so that they can be checked.
12036 * sysdep.c (reset_io): Now static.
12037 (wait_for_termination_signal): Remove; unused.
12039 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12040 (copy_keymap_item, append_key, push_text_char_description):
12042 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
12043 (DENSE_TABLE_SIZE): Remove; unused.
12044 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12045 (describe_map_tree):
12046 Rename locals to avoid shadowing.
12048 * keyboard.c: Declare functions static if they are not used elsewhere.
12049 (echo_char, echo_dash, cmd_error, top_level_2):
12050 (poll_for_input, handle_async_input): Now static.
12051 (read_char, kbd_buffer_get_event, make_lispy_position):
12052 (make_lispy_event, make_lispy_movement, apply_modifiers):
12053 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12054 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12055 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
12056 (read_key_sequence, read_char): Mark locals as initialized.
12057 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
12059 * keyboard.h (make_ctrl_char): New decl.
12060 (mark_kboards): Move decl here ...
12061 * alloc.c (mark_kboards): ... from here.
12063 * lisp.h (force_auto_save_soon): New decl.
12065 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
12066 (DEFINE_DUMMY_FUNCTION): New macro.
12067 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12069 (main): Add casts to avoid warnings
12070 if GCC considers string literals to be constants.
12072 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12074 * dbusbind.c: Pointer signedness fixes.
12075 (xd_signature, xd_append_arg, xd_initialize):
12076 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12077 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12078 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12079 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12081 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12082 if GCC considers string literals to be constants.
12083 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
12085 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12087 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12088 (print_preprocess, print_object): New macro to fix last change.
12090 * print.c (print_preprocess): Don't forget font objects.
12092 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
12094 * emacs.c (USAGE3): Doc fixes.
12096 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12098 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12101 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
12103 * lisp.h (VWindow_system, Qfile_name_history):
12104 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12105 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12106 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12108 * w32select.c: Don't #include "keyboard.h".
12109 (run_protected): Add extern declaration for waiting_for_input.
12111 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12112 * w32console.c (detect_input_pending, read_input_pending)
12113 (encode_terminal_code):
12114 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12115 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12116 (w32_system_caret_y, Qfile_name_history):
12117 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12118 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12119 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12120 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12121 * w32proc.c (Qlocal, report_file_error):
12122 * w32term.c (Vwindow_system, updating_frame):
12123 * w32uniscribe.c (initialized, uniscribe_font_driver):
12124 Remove unneeded extern declarations.
12126 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
12128 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
12130 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
12132 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12133 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12134 These macros can no longer be used for assignment.
12136 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12137 Assign struct members directly, instead of using BUF_BEGV etc.
12138 (record_buffer_markers, fetch_buffer_markers): New functions for
12139 recording and fetching special buffer markers.
12140 (set_buffer_internal_1, set_buffer_temp): Use them.
12142 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12144 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12146 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12147 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12149 * xdisp.c (hscroll_window_tree):
12150 (reconsider_clip_changes): Use PT instead of BUF_PT.
12152 2011-03-13 Eli Zaretskii <eliz@gnu.org>
12154 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12155 $(EMACS_ROOT)/lib/intprops.h.
12157 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12159 Fix more problems found by GCC 4.5.2's static checks.
12161 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12162 to unsigned char * to avoid compiler diagnostic.
12163 (xg_free_frame_widgets): Make it clear that a local variable is
12164 needed only if USE_GTK_TOOLTIP.
12165 (gdk_window_get_screen): Make it clear that this macro is needed
12166 only if USE_GTK_TOOLTIP.
12167 (int_gtk_range_get_value): New function, which avoids a diagnostic
12168 from gcc -Wbad-function-cast.
12169 (xg_set_toolkit_scroll_bar_thumb): Use it.
12170 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12171 diagnostic from gcc -Wbad-function-cast.
12172 (get_utf8_string, xg_get_file_with_chooser):
12173 Rename locals to avoid shadowing.
12174 (create_dialog): Move locals to avoid shadowing.
12176 * xgselect.c (xg_select): Remove unused var.
12178 * image.c (four_corners_best): Mark locals as initialized.
12179 (gif_load): Initialize transparent_p to zero (Bug#8238).
12180 Mark another local as initialized.
12181 (my_png_error, my_error_exit): Mark with NO_RETURN.
12183 * image.c (clear_image_cache): Now static.
12184 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
12185 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
12186 (x_edge_detection): Remove unnecessary cast that
12187 gcc -Wbad-function-cast diagnoses.
12188 (gif_load): Fix pointer signedness.
12189 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12190 (jpeg_load, gif_load): Rename locals to avoid shadowing.
12192 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
12194 Improve quality of tests for time stamp overflow.
12195 For example, without this patch (encode-time 0 0 0 1 1
12196 1152921504606846976) returns the obviously-bogus value (-948597
12197 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12198 reports time overflow. See
12199 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
12200 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12201 * editfns.c: Include limits.h and intprops.h.
12202 (TIME_T_MIN, TIME_T_MAX): New macros.
12203 (time_overflow): Move earlier, to before first use.
12204 (hi_time, lo_time): New functions, for an accurate test for
12205 out-of-range times.
12206 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12207 (Fget_internal_run_time): Don't assume time_t fits in int.
12208 (make_time): Use list2 instead of Fcons twice.
12209 (Fdecode_time): More accurate test for out-of-range times.
12210 (check_tm_member): New function.
12211 (Fencode_time): Use it, to test for out-of-range times.
12212 (lisp_time_argument): Don't rely on undefined left-shift and
12213 right-shift behavior when checking for time stamp overflow.
12215 * editfns.c (time_overflow): New function, refactoring common code.
12216 (Fformat_time_string, Fdecode_time, Fencode_time):
12217 (Fcurrent_time_string): Use it.
12219 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12220 * dired.c (make_time): Move to ...
12221 * editfns.c (make_time): ... here.
12222 * systime.h: Note the move.
12224 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12226 * fringe.c (update_window_fringes): Remove unused variables.
12228 * unexmacosx.c (copy_data_segment): Also copy __got section.
12231 2011-03-12 Eli Zaretskii <eliz@gnu.org>
12233 * termcap.c [MSDOS]: Include "msdos.h".
12234 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12235 Constify `char *' arguments and their references according to
12236 prototypes in tparam.h.
12238 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
12240 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12241 Adapt all references accordingly.
12243 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12245 2011-03-11 Tom Tromey <tromey@redhat.com>
12247 * buffer.c (syms_of_buffer): Remove obsolete comment.
12249 2011-03-11 Eli Zaretskii <eliz@gnu.org>
12251 * termhooks.h (encode_terminal_code): Declare prototype.
12253 * msdos.c (encode_terminal_code): Don't declare prototype.
12255 * term.c (encode_terminal_code): Now external again, used by
12256 w32console.c and msdos.c.
12258 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12259 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
12261 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
12263 Fix some minor problems found by GCC 4.5.2's static checks.
12265 * fringe.c (update_window_fringes): Mark locals as initialized
12267 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
12269 * alloc.c (mark_fringe_data): Move decl from here ...
12270 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12271 to check its interface.
12272 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12274 * fontset.c (free_realized_fontset): Now static.
12275 (Fset_fontset_font): Rename local to avoid shadowing.
12276 (fontset_font): Mark local as initialized.
12277 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
12279 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12281 * xselect.c (x_disown_buffer_selections): Remove; not used.
12282 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
12283 (x_own_selection, Fx_disown_selection_internal): Rename locals
12284 to avoid shadowing.
12285 (x_handle_dnd_message): Remove local to avoid shadowing.
12287 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12288 so that the caller can use some name other than gcpro1.
12289 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
12290 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12291 (Fx_backspace_delete_keys_p):
12292 Use them to avoid shadowing, and rename vars to avoid shadowing.
12293 (x_decode_color, x_set_name, x_window): Now static.
12294 (Fx_create_frame): Add braces to silence GCC warning.
12295 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
12296 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12297 Remove unused locals.
12298 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12299 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12300 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12303 * xterm.h (x_mouse_leave): New decl.
12305 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12306 Remove unused functions.
12307 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12308 (x_calc_absolute_position): Now static.
12309 (XTread_socket): Don't define label "out" unless it's used.
12310 Don't declare local "event" unless it's used.
12311 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12312 unless they are used.
12313 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12314 (x_fatal_error_signal): Remove; not used.
12315 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12316 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12317 (x_error_catcher, x_connection_closed, x_error_handler):
12318 (x_error_quitter, xembed_send_message, x_iconify_frame):
12319 (my_log_handler): Rename locals to avoid shadowing.
12320 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
12321 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
12323 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12324 Rename or move locals to avoid shadowing.
12325 (tty_defined_color, merge_face_heights): Now static.
12326 (free_realized_faces_for_fontset): Remove; not used.
12327 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12328 does not deduce is never used uninitialized.
12329 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12330 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
12332 * terminal.c (store_terminal_param): Now static.
12334 * xmenu.c (menu_highlight_callback): Now static.
12335 (set_frame_menubar): Remove unused local.
12336 (xmenu_show): Rename parameter to avoid shadowing.
12337 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12338 since they might point to immutable storage.
12339 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12340 since it's unused otherwise.
12342 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
12343 Add a FIXME, since the code still doesn't look right. (Bug#8215)
12344 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12345 avoids a gcc -Wuninitialized diagnostic.
12346 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
12347 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12348 does not deduce are never used uninitialized.
12350 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12352 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
12353 * window.c (window_loop, size_window):
12354 (run_window_configuration_change_hook, enlarge_window): Likewise.
12356 * window.c (display_buffer): Now static.
12357 (size_window): Mark variables that gcc -Wuninitialized
12358 does not deduce are never used uninitialized.
12359 * window.h (check_all_windows): New decl, to forestall
12360 gcc -Wmissing-prototypes diagnostic.
12361 * dispextern.h (bidi_dump_cached_states): Likewise.
12363 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12365 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
12366 Include <limits.h>.
12367 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12368 and to avoid gcc -Wuninitialized warning.
12369 (load_charset_map): Mark variables that gcc -Wuninitialized
12370 does not deduce are never used uninitialized.
12371 (load_charset): Abort instead of using uninitialized var (Bug#8229).
12373 * coding.c (coding_set_source, coding_set_destination):
12374 Use "else { /* comment */ }" rather than "else /* comment */;"
12375 for clarity, and to avoid gcc -Wempty-body warning.
12376 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12377 a block, when the outer 'i' will do.
12378 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12379 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12380 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12381 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12382 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12383 Rename locals to avoid shadowing.
12384 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
12385 * coding.c (emacs_mule_char, encode_invocation_designation):
12386 Now static, since they're not used elsewhere.
12387 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
12388 (decode_coding_object, encode_coding_object, detect_coding_system):
12389 (decode_coding_emacs_mule): Mark variables that gcc
12390 -Wuninitialized does not deduce are never used uninitialized.
12391 (detect_coding_iso_2022): Initialize a local variable that might
12392 be used uninitialized. Leave a FIXME because it's not clear that
12393 this initialization is needed. (Bug#8211)
12394 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12395 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12396 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12397 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12398 Remove unused macros.
12400 * category.c (hash_get_category_set): Remove unused local var.
12401 (copy_category_table): Now static, since it's not used elsewhere.
12402 * character.c (string_count_byte8): Likewise.
12404 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12405 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12407 * chartab.c (copy_sub_char_table): Now static, since it's not used
12409 (sub_char_table_ref_and_range, char_table_ref_and_range):
12410 Rename locals to avoid shadowing.
12411 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
12413 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
12414 (BIDI_BOB): Remove unused macro.
12416 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12417 deduce are never used uninitialized.
12418 * term.c (encode_terminal_code): Likewise.
12420 * term.c (encode_terminal_code): Now static. Remove unused local.
12422 * tparam.h: New file.
12423 * term.c, tparam.h: Include it.
12424 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12425 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12426 Move these decls to tparam.h, and make them agree with what
12427 is actually in tparam.c. The previous trick of using incompatible
12428 decls in different modules does not conform to the C standard.
12429 All callers of tparam changed to use tparam's actual API.
12430 * tparam.c (tparam1, tparam, tgoto):
12431 Use const pointers where appropriate.
12433 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12434 * cm.h (struct cm): Likewise.
12435 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12436 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12437 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12438 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12439 (turn_on_face, init_tty): Likewise.
12440 * termchar.h (struct tty_display_info): Likewise.
12442 * term.c (term_mouse_position): Rename local to avoid shadowing.
12444 * alloc.c (mark_ttys): Move decl from here ...
12445 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12447 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12449 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12451 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
12453 * search.c (compile_pattern_1): Remove argument regp, unused since
12454 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12455 (compile_pattern): Don't pass it.
12457 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12459 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12460 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12462 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12464 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12466 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12467 gdk_window_get_screen, gdk_window_get_geometry,
12468 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12469 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12470 (xg_get_pixbuf_from_pixmap): New function.
12471 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12472 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12473 Call xg_get_pixbuf_from_pixmap instead of
12474 gdk_pixbuf_get_from_drawable.
12475 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12476 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12477 (xg_check_special_colors): Use GtkStyleContext and its functions
12479 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12480 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12481 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
12482 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12483 Call gtk_widget_get_preferred_size.
12484 (xg_frame_resized): gdk_window_get_geometry only takes 5
12486 (xg_win_to_widget, xg_event_is_for_menubar):
12487 Call gdk_x11_window_lookup_for_display.
12488 (xg_set_widget_bg): New function.
12489 (delete_cb): New function.
12490 (xg_create_frame_widgets): Connect delete-event to delete_cb.
12491 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
12492 (xg_set_background_color): Call xg_set_widget_bg.
12493 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12494 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12495 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12496 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12498 (update_frame_tool_bar): Call gtk_widget_hide.
12499 (xg_initialize): Use GDK_KEY_g.
12501 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12503 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12505 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12506 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12507 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12509 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
12511 * w32xfns.c (select_palette): Check success of RealizePalette against
12512 GDI_ERROR, not zero.
12514 See ChangeLog.11 for earlier changes.
12516 ;; Local Variables:
12520 Copyright (C) 2011-2012 Free Software Foundation, Inc.
12522 This file is part of GNU Emacs.
12524 GNU Emacs is free software: you can redistribute it and/or modify
12525 it under the terms of the GNU General Public License as published by
12526 the Free Software Foundation, either version 3 of the License, or
12527 (at your option) any later version.
12529 GNU Emacs is distributed in the hope that it will be useful,
12530 but WITHOUT ANY WARRANTY; without even the implied warranty of
12531 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12532 GNU General Public License for more details.
12534 You should have received a copy of the GNU General Public License
12535 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.