Spelling fixes.
[bpt/emacs.git] / src / ChangeLog
1 2011-11-23 Chong Yidong <cyd@gnu.org>
2
3 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4 using it (Bug#5984).
5
6 2011-11-22 Eli Zaretskii <eliz@gnu.org>
7
8 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
9 and header-lines, as they don't have one computed for them.
10 (Bug#10098)
11
12 * .gdbinit (prow): Make displayed values more self-explaining.
13 Add row's hash code.
14
15 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
16
17 * process.c (wait_reading_process_output): Fix asynchrounous
18 GnuTLS socket handling on some versions of the GnuTLS library.
19 (wait_reading_process_output): Add comment and URL.
20
21 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
22
23 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
24
25 2011-11-21 Chong Yidong <cyd@gnu.org>
26
27 * window.c (Fnext_window, Fprevious_window): Doc fix.
28
29 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
30
31 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
32
33 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
34
35 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
36
37 2011-11-20 Martin Rudalics <rudalics@gmx.at>
38
39 * window.c (Fset_window_combination_limit): Rename argument
40 STATUS to LIMIT.
41 (Vwindow_combination_limit): Remove "status" from doc-string.
42
43 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
44
45 * m/ibms390.h: Remove.
46 * m/ibms390x.h: Don't include "ibms390.h".
47
48 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
49
50 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
51 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
52
53 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
54
55 * casetab.c (Fset_case_table):
56 * charset.c (Fcharset_after): Fix typos.
57
58 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
59
60 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
61 Otherwise, valgrind does not work on some platforms.
62 Problem reported by Andreas Schwab in
63 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
64 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
65 is set, removing the need for VIRT_ADDRESS_VARIES.
66 (PURE_P): Use a more-efficient implementation that needs just one
67 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
68 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
69 to 4 (xorl, subq, cmpq, setbe).
70 * alloc.c (pure): Always extern now, since that's the
71 VIRT_ADDR_VARIES behavior.
72 (PURE_POINTER_P): Use a single comparison, not two, for
73 consistency with the new puresize.h.
74 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
75 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
76 Remove VIRT_ADDR_VARIES no longer needed.
77
78 2011-11-19 Eli Zaretskii <eliz@gnu.org>
79
80 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
81 (erase_phys_cursor, update_window_cursor, show_mouse_face)
82 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
83 behave as if the cursor position were at the window margin.
84
85 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
86 and the cursor position is out of bounds, behave as if the cursor
87 position were at the window margin. (Bug#10075)
88
89 2011-11-18 Chong Yidong <cyd@gnu.org>
90
91 * window.c (Fwindow_combination_limit): Make first argument
92 non-optional, since it is meaningless for live windows like the
93 selected window.
94
95 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
96
97 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
98
99 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
100
101 * intervals.c: Fix grafting over the whole buffer (bug#10071).
102 (graft_intervals_into_buffer): Simplify.
103
104 2011-11-18 Eli Zaretskii <eliz@gnu.org>
105
106 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
107 hash values of the two rows.
108 (copy_row_except_pointers): Preserve the used[] arrays and the
109 hash values of the two rows. (Bug#10035)
110 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
111
112 * xdisp.c (row_hash): New function, body extracted from
113 compute_line_metrics.
114 (compute_line_metrics): Call row_hash, instead of computing the
115 hash code inline.
116
117 * dispnew.c (verify_row_hash): Call row_hash for computing the
118 hash code of a row, instead of duplicating code from xdisp.c.
119
120 * dispextern.h (row_hash): Add prototype.
121
122 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
123
124 * frame.c (delete_frame): Don't delete the terminal when the last
125 X frame is closed if emacs is built with GTK toolkit.
126
127 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
128
129 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
130
131 2011-11-17 Martin Rudalics <rudalics@gmx.at>
132
133 * window.c (Vwindow_splits): Rename to
134 Vwindow_combination_resize. Suggested by Juri Linkov.
135 (Fsplit_window_internal): Use Vwindow_combination_resize instead
136 of Vwindow_splits.
137
138 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
139
140 * nsfns.m (Fns_font_name):
141 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
142
143 2011-11-16 Martin Rudalics <rudalics@gmx.at>
144
145 * window.h (window): Rename slot "nest" to "combination_limit".
146 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
147 (Fset_window_nest): Rename to Fset_window_combination_limit.
148 (Vwindow_nest): Rename to Vwindow_combination_limit.
149 (recombine_windows, make_parent_window, make_window)
150 (Fsplit_window_internal, saved_window)
151 (Fset_window_configuration, save_window_save): Rename all
152 occurrences of window_nest to window_combination_limit.
153
154 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
155
156 * image.c (imagemagick_load_image): Fix typo.
157
158 2011-11-14 Eli Zaretskii <eliz@gnu.org>
159
160 * xdisp.c (display_line): Move the call to
161 highlight_trailing_whitespace before the call to
162 compute_line_metrics, since the latter needs to see the final
163 faces of all the glyphs to compute ROW's hash value. Fixes
164 assertion violations in row_equal_p. (Bug#10035)
165
166 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
167
168 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
169 just return (bug#10044).
170
171 2011-11-12 Eli Zaretskii <eliz@gnu.org>
172
173 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
174 with user-defined heap size. Bump the default size of the temacs
175 heap to 27MB, to avoid memory warning when running temacs.
176 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
177
178 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
179 current_matrix and desired_matrix. (Bug#9990)
180 (verify_row_hash) [XASSERTS]: New function.
181 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
182 that the hash value of glyph rows is correct.
183
184 2011-11-12 Martin Rudalics <rudalics@gmx.at>
185
186 * window.h (window): Remove splits slot.
187 * window.c (Fwindow_splits, Fset_window_splits): Remove.
188 (Fdelete_other_windows_internal, make_parent_window)
189 (make_window, Fsplit_window_internal, Fdelete_window_internal)
190 (Fset_window_configuration, save_window_save): Don't deal with
191 split status of windows.
192 (saved_window): Remove splits slot.
193 (Vwindow_splits): Rewrite doc-string.
194
195 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
196
197 * xfns.c (unwind_create_frame):
198 * nsfns.m (unwind_create_frame):
199 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
200 Vframe_list (Bug#9999).
201
202 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
203
204 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
205
206 2011-11-11 Kenichi Handa <handa@m17n.org>
207
208 * callproc.c (Fcall_process): Set the member dst_multibyte of
209 process_coding.
210
211 2011-11-11 Johan Bockgård <bojohan@gnu.org>
212
213 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
214 avoid a crash (bug#9496).
215
216 2011-11-09 Chong Yidong <cyd@gnu.org>
217
218 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
219 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
220
221 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
222
223 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
224
225 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
226
227 Avoid some portability problems by eschewing 'extern inline' functions.
228 The trivial performance wins aren't worth the portability hassles; see
229 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
230 et seq.
231 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
232 (window_box_width, window_box_left, window_box_left_offset)
233 (window_box_right, window_box_right_offset): Undo previous change,
234 by removing the "extern"s.
235 * intervals.c (adjust_intervals_for_insertion)
236 (adjust_intervals_for_deletion): Undo previous change,
237 making these static again.
238 (offset_intervals, temp_set_point_both, temp_set_point)
239 (copy_intervals_to_string): No longer inline.
240 * xdisp.c (window_text_bottom_y, window_box_width)
241 (window_box_height, window_box_left_offset)
242 (window_box_right_offset, window_box_left, window_box_right)
243 (window_box): No longer inline.
244
245 2011-11-08 Chong Yidong <cyd@gnu.org>
246
247 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
248 (Fwindow_body_height, Fwindow_body_width): Move from Lisp. Signal
249 an error if not a live window.
250 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
251 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
252
253 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
254
255 * lisp.h (syms_of_abbrev): Remove declaration.
256 Reported by CHENG Gao <chenggao@royau.me>.
257
258 2011-11-07 Eli Zaretskii <eliz@gnu.org>
259
260 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
261 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
262 of temacs in GUI mode.
263
264 2011-11-07 Martin Rudalics <rudalics@gmx.at>
265
266 * window.h: Declare delete_all_child_windows instead of
267 delete_all_subwindows.
268 * window.c (Fwindow_nest, Fset_window_nest)
269 (Fset_window_new_total, Fset_window_new_normal)
270 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
271 (delete_all_subwindows): Rename to delete_all_child_windows.
272 (Fdelete_other_windows_internal, Fset_window_configuration):
273 Call delete_all_child_windows instead of delete_all_subwindows.
274 * frame.c (delete_frame): Call delete_all_child_windows instead
275 of delete_all_subwindows.
276
277 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
278
279 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
280 This is also needed for porting to any host where GC_MARK_STACK is
281 not GC_MAKE_GCPROS_NOOPS.
282 (which_symbols): Use it.
283
284 2011-11-07 Kenichi Handa <handa@m17n.org>
285
286 * coding.c (coding_set_destination): Check coding->src_pos only
287 when coding->src_object is a buffer (bug#9910).
288
289 * process.c (send_process): Set the member src_multibyte of coding
290 to 0 (bug#9911) when sending a unibyte text.
291
292 * callproc.c (Fcall_process): Set the member src_multibyte of
293 process_coding to 0 (bug#9912).
294
295 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
296
297 * xmenu.c (cleanup_widget_value_tree): New function.
298 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
299 calling free_menubar_widget_value_tree directly (Bug#9830).
300
301 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
302
303 Fix some portability problems with 'inline'.
304 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
305 (window_box_width, window_box_left, window_box_left_offset)
306 (window_box_right, window_box_right_offset): Declare extern.
307 Otherwise, these inline functions do not conform to C99 and
308 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
309 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
310 * intervals.c (adjust_intervals_for_insertion)
311 (adjust_intervals_for_deletion): Now extern, because otherwise the
312 extern inline functions 'offset_intervals' couldn't refer to it.
313 (static_offset_intervals): Remove.
314 (offset_intervals): Rewrite using the old contents of
315 static_offset_intervals. The old version didn't conform to C99
316 because an extern inline function contained a reference to an
317 identifier with static linkage.
318
319 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
320
321 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
322 GC.
323
324 2011-11-06 Eli Zaretskii <eliz@gnu.org>
325
326 * xdisp.c (init_iterator, reseat_to_string): Don't set the
327 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
328 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
329 return Qleft_to_right.
330
331 2011-11-06 Chong Yidong <cyd@gnu.org>
332
333 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
334 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
335 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
336 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
337 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
338 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
339 (Fwindow_vscroll): Doc fix.
340 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
341 argument, since it makes no sense to pass a live window and for
342 consistency with window-child.
343
344 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
345
346 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
347 support MSVC.
348
349 2011-11-05 Jason Rumney <jasonr@gnu.org>
350
351 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
352 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
353 fonts (Bug#6029).
354 (add_font_entity_to_list): Fix logic errors in mixed boolean and
355 bitwise arithmetic preventing use of unicode-sip and non-truetype
356 opentype fonts.
357
358 2011-11-05 Eli Zaretskii <eliz@gnu.org>
359
360 * s/ms-w32.h (fstat, stat, utime): Move redirections to
361 "emacs"-only part.
362
363 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
364 initialization code to keep similarity to xfns.c after changes
365 from 2011-11-05.
366
367 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
368
369 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
370 (unwind_create_frame): New function (Bug#9943).
371 (Fx_create_frame): Restructure code to be more similar to the one in
372 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
373 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
374 Move terminal->reference_count++ just before making the frame official
375 (Bug#9943).
376
377 * nsterm.m (x_free_frame_resources): New function.
378 (x_destroy_window): Move code to x_free_frame_resources.
379
380 * xfns.c (unwind_create_frame): Fix comment.
381 (Fx_create_frame, x_create_tip_frame): Move
382 terminal->reference_count++ just before making the frame
383 official. Move initialization of image_cache_refcount and
384 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
385
386 2011-11-05 Eli Zaretskii <eliz@gnu.org>
387
388 Support MSVC build with newer versions of Visual Studio.
389 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
390 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
391 nt/gmake.defs.
392
393 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
394 which are not supported by MSVC.
395 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
396 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
397 bitfields.
398 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
399 types in bitfields.
400 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
401
402 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
403
404 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
405
406 Support MSVC build with newer versions of Visual Studio.
407 * w32.c: Don't include w32api.h for MSVC.
408 (init_environment) [_MSC_VER]: Call sys_access, not _access.
409
410 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
411 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
412 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
413 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
414 e_* cousins.
415 (alloca) [_MSC_VER]: Define to _alloca.
416
417 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
418
419 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
420
421 2011-11-04 Eli Zaretskii <eliz@gnu.org>
422
423 * xdisp.c (note_mouse_highlight): If either of
424 previous/next-single-property-change returns nil, treat that as
425 the beginning or the end of the buffer. (Bug#9955)
426
427 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
428
429 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
430 label is not null (Bug#9951).
431 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
432 may be NULL.
433
434 2011-11-04 Eli Zaretskii <eliz@gnu.org>
435
436 * window.c (Fwindow_body_size): Mention in the doc string that the
437 return value is in frame's canonical units. (Bug#9949)
438
439 2011-11-03 Eli Zaretskii <eliz@gnu.org>
440
441 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
442
443 * w32fns.c (unwind_create_frame): If needed, free the glyph
444 matrices of the partially constructed frame. (Bug#9943)
445 * xfns.c (unwind_create_frame): Likewise.
446
447 2011-11-01 Eli Zaretskii <eliz@gnu.org>
448
449 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
450 Don't stop backward scan on the continuation glyph, even though
451 its CHARPOS is positive.
452 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
453 cover_string to disp_string.
454
455 2011-11-01 Martin Rudalics <rudalics@gmx.at>
456
457 * window.c (temp_output_buffer_show): Don't use
458 Vtemp_buffer_show_specifiers.
459 (Vtemp_buffer_show_specifiers): Remove unused variable.
460
461 2011-10-30 Eli Zaretskii <eliz@gnu.org>
462
463 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
464 past the beginning of the current glyph matrix.
465
466 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
467
468 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
469 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
470 HAVE_GTK3 (Bug#9869).
471
472 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
473 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
474
475 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
476
477 * xterm.c: Declare x_handle_net_wm_state to return int.
478 (handle_one_xevent): Check if we are iconified but don't have
479 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
480 (get_current_wm_state): Return non-zero if not hidden,
481 check for _NET_WM_STATE_HIDDEN (Bug#9893).
482 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
483 (x_handle_net_wm_state): Return what get_current_wm_state returns.
484 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
485
486 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
487
488 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
489 so that this new function doesn't get optimized away by a
490 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
491
492 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
493
494 * frame.h (MOUSE_HL_INFO): Remove excess parens.
495
496 2011-10-29 Eli Zaretskii <eliz@gnu.org>
497
498 Fix the `xbytecode' command.
499 * .gdbinit (xprintbytestr): New command.
500 (xwhichsymbols): Rename from `which'; all callers changed.
501 (xbytecode): Print the byte-code string as well.
502
503 2011-10-29 Kim Storm <storm@cua.dk>
504
505 * alloc.c (which_symbols): New function.
506
507 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
508
509 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
510 line. (Bug#9903)
511
512 2011-10-29 Glenn Morris <rgm@gnu.org>
513
514 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
515 Not clear what it was for, and it causes various bugs. (Bug#9839)
516
517 2011-10-28 Eli Zaretskii <eliz@gnu.org>
518
519 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
520 possible random value that matches one of those tested as
521 condition to clear the mouse face.
522
523 2011-10-28 Chong Yidong <cyd@gnu.org>
524
525 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
526
527 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
528
529 * window.c (make_window): Initialize phys_cursor_on_p.
530
531 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
532
533 * lisp.h (struct Lisp_Symbol): Update comments.
534
535 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
536
537 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
538
539 2011-10-28 Eli Zaretskii <eliz@gnu.org>
540
541 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
542 <oslsachem@gmail.com> for helping to debug this.
543
544 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
545 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
546 (g_b_init_get_glyph_outline_w): New static variables.
547 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
548 (GetGlyphOutlineW_Proc): New typedefs.
549 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
550 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
551 New functions.
552 (w32font_open_internal, compute_metrics):
553 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
554 instead of calling the "wide" APIs directly.
555
556 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
557
558 * w32.h (syms_of_w32font): Add prototype.
559
560 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
561
562 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
563 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
564 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
565 (Fmove_to_window_line): Doc fix.
566
567 2011-10-27 Chong Yidong <cyd@gnu.org>
568
569 * process.c (make_process): Set gnutls_state to NULL.
570
571 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
572 non-NULL, regardless of GNUTLS_INITSTAGE.
573 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
574 an error. Set process slots as soon as we allocate them.
575
576 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
577
578 2011-10-27 Chong Yidong <cyd@gnu.org>
579
580 * gnutls.c (emacs_gnutls_deinit): New function.
581 Deallocate credentials structures as well as calling gnutls_deinit.
582 (Fgnutls_deinit, Fgnutls_boot): Use it.
583
584 * process.c (make_process): Initialize GnuTLS credentials to NULL.
585 (deactivate_process): Call emacs_gnutls_deinit.
586
587 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
588
589 * image.c (x_create_x_image_and_pixmap):
590 * w32.c (sys_rename, w32_delayed_load):
591 * w32font.c (fill_in_logfont):
592 * w32reg.c (x_get_string_resource): Silence compiler warnings.
593
594 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
595
596 * w32fns.c (w32_default_color_map): New function,
597 extracted from Fw32_default_color_map.
598 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
599
600 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
601
602 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
603
604 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
605
606 * keyboard.c (test_undefined): New function (bug#9751).
607 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
608
609 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
610
611 * sysdep.c (init_sys_modes): Fix the check for the controlling
612 terminal (Bug#6649).
613
614 2011-10-20 Eli Zaretskii <eliz@gnu.org>
615
616 * dispextern.h (struct bidi_it): New member next_en_type.
617
618 * bidi.c (bidi_line_init): Initialize the next_en_type member.
619 (bidi_resolve_explicit_1): When next_en_pos is valid for the
620 current character, check also for next_en_type being WEAK_EN.
621 (bidi_resolve_weak): Don't enter the expensive loop if the current
622 position is before next_en_pos. Record the bidi type of the first
623 non-ET, non-BN character we find, in addition to its position.
624 (bidi_level_of_next_char): Invalidate next_en_type when
625 next_en_pos is over-stepped.
626
627 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
628
629 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
630 * editfns.c: Rewrite current-time-zone so that it invokes
631 the equivalent of (format-time-string "%Z") to get the time zone name.
632 This fixes a bug when the time zone name contains characters that
633 need converting from the system time locale to Emacs internal format.
634 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
635 that patch fixed format-time-string to do the conversion, but
636 I forgot to fix current-time-zone.
637 (format_time_string): New function, containing most of
638 what Fformat_time_string used to contain.
639 (Fformat_time_string): Rewrite in terms of format_time_string.
640 This doesn't change this function's behavior.
641 (current-time-zone): Rewrite to use format_time_string.
642 This fixes the bug reported by Michael Schierl in
643 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
644 Jason Rumney's 2007-06-07 change worked around this bug, but
645 didn't fix it.
646 * systime.h (tzname, timezone): Remove no-longer-used declarations.
647
648 2011-10-19 Eli Zaretskii <eliz@gnu.org>
649
650 * xdisp.c (start_display): If the character at POS is displayed
651 via a display vector, reset IT->current.dpvec_index to zero.
652 (try_window_reusing_current_matrix): If a line ends in a display
653 vector or the next line starts in a display vector, continue
654 redrawing the window even though the character position of
655 start_row was reached.
656 (Bug#9771, part 2)
657
658 2011-10-18 Chong Yidong <cyd@gnu.org>
659
660 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
661 with nobreak-char-display too.
662
663 2011-10-18 Eli Zaretskii <eliz@gnu.org>
664
665 Fix part 3 of bug#9771.
666 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
667 (bidi_resolve_neutral): Don't enter the expensive loop looking for
668 non-neutral characters if the current character is a paragraph
669 separator (a.k.a. Newline). This avoids running the same
670 expensive loop twice, once when we consume the preceding newline
671 and the other time when the line actually needs to be displayed.
672 Avoid the loop when we see neutrals on the base embedding level
673 following a character whose directionality is the same as the
674 paragraph's. This avoids running the expensive loop when a line
675 ends in a long sequence of neutrals, like control characters.
676 Add assertion against STRONG_AL type. Slightly rearrange code
677 that determines the type of a neutral given the first non-neutral
678 that follows it.
679 (bidi_level_of_next_char): Set next_en_pos to zero when
680 invalidating its info.
681
682 2011-10-17 Eli Zaretskii <eliz@gnu.org>
683
684 * xdisp.c (push_display_prop): Determine whether to record string
685 or buffer position by IT->string, not by IT->method. Allow
686 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
687 (move_it_vertically_backward): Don't look for character position
688 immediately after the newline when in a continuation line.
689 (Bug#9771, part 1)
690
691 2011-10-15 Martin Rudalics <rudalics@gmx.at>
692
693 * window.c (coordinates_in_window): Rewrite and delabelize
694 vertical border check. (Bug#5357) (Bug#9618)
695
696 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
697
698 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
699 errors in XSetWindowBorder (bug#9310).
700
701 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
702
703 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
704 avoid crash when xmalloc overrun checking is enabled.
705
706 2011-10-13 Eli Zaretskii <eliz@gnu.org>
707
708 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
709 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
710 cursor motion with <left> and <right> arrow keys.
711
712 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
713 some callers set that themselves.
714
715 2011-10-12 Eli Zaretskii <eliz@gnu.org>
716
717 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
718 display string and the previous row comes from the same string and
719 is empty. (Bug#9739) (Bug#9738)
720
721 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
722
723 * doc.c (get_doc_string): Encode file name (bug#9735).
724
725 2011-10-12 Eli Zaretskii <eliz@gnu.org>
726
727 * bidi.c (bidi_level_of_next_char):
728 * xdisp.c (get_visually_first_element): Remove old incorrect
729 comments regarding the Unicode Line Separator character.
730
731 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
732
733 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
734
735 * alloc.c (Fgc_status): Do not access beyond zombies array
736 boundary if nzombies > MAX_ZOMBIES.
737 * alloc.c (dump_zombies): Add missing format specifier.
738
739 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
740
741 * xdisp.c (set_cursor_from_row): Simplify conditionals,
742 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
743
744 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
745 Some packages use them to denote characters with modifiers.
746
747 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
748
749 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
750 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
751 matching a pp-number. Rename parameter var to var1.
752
753 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
754
755 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
756
757 2011-10-08 Glenn Morris <rgm@gnu.org>
758
759 * callint.c (Fcall_interactively): Give a more explicit error for the
760 'c' case with a non-character input. (Bug#8479)
761
762 2011-10-08 Eli Zaretskii <eliz@gnu.org>
763
764 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
765 lines.
766 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
767 lines that are hscrolled on the left.
768
769 * dispnew.c (buffer_posn_from_coords): Account for a possible
770 presence of header-line. (Bug#4426)
771
772 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
773
774 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
775 Don't advertise functionality which we discourage or doesn't work.
776
777 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
778
779 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
780 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
781 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
782 this makes Emacs dump core during garbage collection on rare
783 occasions. sizeof is obviously inferior to offsetof here, so
784 stick with offsetof.
785 (GC_POINTER_ALIGNMENT): New macro.
786 (mark_memory): Omit 3rd (offset) arg; caller changed.
787 Don't assume EMACS_INT alignment is the same as pointer alignment.
788
789 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
790
791 * keyboard.c (read_key_sequence_remapped): New var.
792 (read_key_sequence): Compute remapping in the right buffer.
793 (command_loop_1): Use read_key_sequence's remapping directly.
794
795 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
796
797 * dired.c (file_name_completion): Don't expand file name.
798 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
799 before checking file name handler.
800
801 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
802 they've been requested explicitly (bug#9591).
803
804 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
805
806 * keymap.c (Fsingle_key_description): Use make_specified_string
807 instead of build_string to build string from push_key_description.
808 (Bug#5193)
809
810 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
811
812 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
813 This fixes a Y2038 bug on 64-bit hosts.
814 * buffer.c (reset_buffer):
815 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
816 (Fclear_buffer_auto_save_failure):
817 Use 0, not -1, to represent an unset failure time, since time_t
818 might not be signed.
819
820 Remove dependency on glibc malloc internals.
821 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
822 Move back here from lisp.h, but with their new implementations.
823 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
824 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
825 * charset.c (charset_table_init): New static var.
826 (syms_of_charset): Use it instead of xmalloc. This removes a
827 dependency on glibc malloc internals. See Eli Zaretskii's comment in
828 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
829 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
830 Move back to alloc.c.
831 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
832 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
833
834 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
835
836 * nsterm.m (windowDidResize): Call x_set_window_size only when
837 ns_in_resize is true. Otherwise set pixelwidth/height and
838 call change_frame_size (Bug#9628).
839
840 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
841
842 Port --enable-checking=all to Fedora 14 x86-64.
843 * charset.c (syms_of_charset): Also account for glibc malloc's
844 internal overhead when calculating the initial malloc maximum.
845
846 Port --enable-checking=all to Fedora 14 x86.
847 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
848 Move to lisp.h.
849 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
850 (overrun_check_realloc, overrun_check_free):
851 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
852 That way, xmalloc returns a properly-aligned pointer even if
853 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
854 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
855 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
856 into account when calculating the initial malloc maximum.
857 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
858 Move here from alloc.c, so that charset.c can use it too.
859 Properly align; the old code wasn't right for common 32-bit hosts
860 when configured with --enable-checking=all.
861 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
862 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
863
864 2011-09-29 Eli Zaretskii <eliz@gnu.org>
865
866 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
867 use EDOM.
868
869 2011-09-28 Eli Zaretskii <eliz@gnu.org>
870
871 * xdisp.c (compute_display_string_end): If there's no display
872 string at CHARPOS, return -1.
873
874 * bidi.c (bidi_fetch_char): When compute_display_string_end
875 returns a negative value, treat the character as a normal
876 character not covered by a display string. (Bug#9624)
877
878 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
879
880 * lread.c (Fread_from_string): Fix typo in docstring.
881
882 2011-09-27 Eli Zaretskii <eliz@gnu.org>
883
884 * xdisp.c (handle_invisible_prop): If invisible text ends on a
885 newline, reseat the iterator instead of bidi-iterating there one
886 character at a time. (Bug#9610)
887 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
888 TO_CHARPOS if the bidi iterator is at base embedding level.
889
890 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
891
892 * lread.c (readevalloop): Use correct code for NBSP.
893 (read1): Likewise. (Bug#9608)
894
895 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
896
897 * dbusbind.c (Fdbus_register_signal): When service is not
898 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
899
900 2011-09-25 Glenn Morris <rgm@gnu.org>
901
902 * buffer.c (truncate-lines): Doc fix.
903
904 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
905
906 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
907 (Fset_window_next_buffers): Doc fix.
908
909 2011-09-24 Glenn Morris <rgm@gnu.org>
910
911 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
912
913 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
914
915 Fix minor problems found by static checking.
916 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
917 * indent.c (Fvertical_motion): Fix == vs = typo.
918
919 2011-09-24 Eli Zaretskii <eliz@gnu.org>
920
921 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
922 Default value is now t. Doc fix.
923
924 * indent.c (Fvertical_motion): Compute and apply the overshoot
925 logic when moving up, not only when moving down. Fix the
926 confusing name and values of the it_overshoot_expected variable;
927 logic changes accordingly. (Bug#9254) (Bug#9549)
928
929 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
930 CHARPOS is covered by a display string which includes newlines.
931 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
932 is covered by a display string with embedded newlines.
933
934 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
935
936 * dbusbind.c (Fdbus_register_signal): Add match rule to
937 Vdbus_registered_objects_table. (Bug#9581)
938 (Fdbus_register_method, Vdbus_registered_objects_table):
939 Fix docstring.
940
941 2011-09-24 Jim Meyering <meyering@redhat.com>
942
943 do not ignore write error for any output size
944 The previous change was incomplete.
945 While it makes emacs --batch detect the vast majority of stdout
946 write failures, errors were still ignored whenever the output size is
947 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
948 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
949 && echo FAIL: ignored write error
950 FAIL: ignored write error
951 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
952 && echo FAIL: ignored write error
953 FAIL: ignored write error
954 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
955
956 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
957
958 * emacs.c (Fkill_emacs): In noninteractive mode exit
959 non-successfully if a write error occurred on stdout. (Bug#9574)
960
961 2011-09-21 Eli Zaretskii <eliz@gnu.org>
962
963 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
964 the xassert test.
965
966 * dispextern.h (struct it): Update the comment documenting what
967 can it->OBJECT be.
968
969 2011-09-20 Eli Zaretskii <eliz@gnu.org>
970
971 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
972 a display string, extend search for cursor position to end of row.
973 (find_row_edges): If the row ends in a newline from a display
974 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
975 Handle the case of a display string with multiple newlines.
976 (Fcurrent_bidi_paragraph_direction): Fix search for previous
977 non-empty line. Fixes confusing cursor motion with arrow keys at
978 the beginning of a line that starts with whitespace.
979
980 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
981
982 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
983 (bug#9493).
984
985 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
986
987 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
988 boolean (Bug#9154).
989
990 2011-09-18 Eli Zaretskii <eliz@gnu.org>
991
992 * xdisp.c (display_line): Record maximum and minimum buffer
993 positions even if no glyphs were produced (e.g., by a zero-width
994 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
995 buffer positions that will be removed from the glyph row because
996 they don't fit.
997 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
998 column is beyond frame width: don't subtract 1 "pixel" when
999 computing width of the stretch.
1000 (reseat_at_next_visible_line_start): Undo the change made on
1001 2011-09-17 that saved paragraph information and restored it after
1002 the call to `reseat'. (Bug#9545)
1003
1004 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1005
1006 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1007 and turn window cursor on if cleared (Bug#9415).
1008
1009 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1010
1011 * search.c (boyer_moore): Take unibyte characters from pattern
1012 literally. (Bug#9458)
1013
1014 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1015
1016 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1017
1018 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1019
1020 Fix minor problem found by static checking.
1021 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1022 initialized, to pacify gcc -Wuninitialized.
1023
1024 * fileio.c: Report proper errno when syscall falls.
1025 (Finsert_file_contents): Save and restore errno,
1026 so that report_file_error outputs the correct diagnostic.
1027 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1028
1029 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1030
1031 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1032
1033 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1034
1035 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1036 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1037
1038 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1039
1040 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1041 about the current paragraph and restore it after the call to reseat.
1042
1043 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1044 (bidi_find_paragraph_start): Search back for paragraph beginning
1045 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1046 (bidi_move_to_visually_next): Only trigger paragraph-related
1047 computations when the last character is a newline or at EOB, not
1048 just any NEUTRAL_B. (Bug#9470)
1049
1050 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1051 truncated lines if point is covered by a display string. (Bug#9524)
1052
1053 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1054
1055 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1056 (cons_to_x_long): New function.
1057 (lisp_data_to_selection_data): Use it. Correct the test for
1058 short-versus-long data; it was negated. Break out of vector
1059 loop, for efficiency, when a long datum is discovered.
1060
1061 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1062
1063 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1064
1065 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1066
1067 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1068 GCC PR/17406) by declaring this function with external scope.
1069
1070 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1071
1072 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1073 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1074
1075 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1076
1077 * editfns.c (Fformat): Correctly handle text properties on "%%".
1078
1079 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1080
1081 * xterm.c (x_draw_composite_glyph_string_foreground):
1082 * w32term.c (x_draw_composite_glyph_string_foreground):
1083 * term.c (encode_terminal_code):
1084 * composite.c (composition_update_it, get_composition_id):
1085 * xdisp.c (get_next_display_element)
1086 (fill_composite_glyph_string): Add comments about special meaning
1087 of TAB characters in a composition.
1088
1089 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1090
1091 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1092 This occurs when processing a multibyte format.
1093 Problem reported by Wolfgang Jenker.
1094
1095 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1096
1097 * xdisp.c (try_cursor_movement): Only check for exact match if
1098 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1099
1100 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1101
1102 Remove unused external symbols.
1103 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1104 * xdisp.c (calc_pixel_width_or_height): Now static.
1105 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1106 * indent.c (check_display_width):
1107 * w32term.c: Fix comment to match code.
1108 * xterm.c, xterm.h (x_catching_errors): Remove.
1109
1110 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1111
1112 * xselect.c: Use signed conversions more consistently (Bug#9498).
1113 (selection_data_to_lisp_data): Assume incoming selection data are
1114 signed integers, not unsigned. This is to be consistent with
1115 outgoing selection data, which was modified to use signed integers
1116 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1117 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1118 expects long, not unsigned long.
1119
1120 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1121
1122 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1123 computation of loop end. Reported by Johan Bockgård
1124 <bojohan@gnu.org>.
1125
1126 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1127
1128 * frame.c (Fother_visible_frames_p): Function deleted.
1129
1130 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1131
1132 * indent.c (compute_motion): Process display vector front to back
1133 rather than the other way around. (Bug#2496)
1134
1135 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1136
1137 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1138
1139 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1140
1141 * minibuf.c (Fread_from_minibuffer): Doc fix.
1142
1143 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1144
1145 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1146 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1147
1148 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1149
1150 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1151 value for non-existent files.
1152
1153 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1154
1155 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1156 set its "size" to -1. This will set the modtime_size field of
1157 the corresponding buffer to -1, which is what
1158 verify-visited-file-modtime expects for files that do not exist.
1159 (Bug#9139)
1160
1161 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1162
1163 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1164 here ...
1165 * lisp.h: ... from here. push_key_description is no longer
1166 defined in keyboard.c, so its declaration should not be in
1167 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1168 logically belongs with push_key_description.
1169
1170 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1171
1172 * buffer.h: Include <sys/types.h> instead of <time.h>.
1173 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1174 Problem reported by Herbert J. Skuhra.
1175
1176 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1177
1178 * xml.c (parse_region): Make the parsing work for
1179 non-comment-starting XML files again (bug#9144).
1180
1181 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1182
1183 * image.c (gif_load): Fix calculation of bottom and right corner.
1184 (Bug#9468)
1185
1186 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1187
1188 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1189 redisplay in small windows.
1190
1191 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1192
1193 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1194
1195 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1196
1197 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1198 Operate on live windows only.
1199
1200 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1201
1202 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1203
1204 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1205
1206 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1207 only under bidi iteration.
1208
1209 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1210
1211 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1212
1213 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1214
1215 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1216 Without this fix, the command to link temacs failed due to an
1217 undefined symbol __builtin_isnan. This is because
1218 /usr/include/iso/math_c99.h #defines isnan(x) to
1219 __builtin_isnan(x), but the bundled gcc, which identifies itself
1220 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1221 a __builtin_isnan.
1222 * floatfns.c (isnan): #undef, and then #define to a clone of
1223 what's in data.c.
1224 (Fisnan): Always define, since it's always available now.
1225 (syms_of_floatfns): Always define isnan at the Lisp level.
1226
1227 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1228
1229 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1230
1231 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1232
1233 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1234 The previous code assumed that file offsets (off_t values) fit in
1235 EMACS_INT variables, which is not true on typical 32-bit hosts.
1236 The code messed up by falsely reporting buffer overflow in cases
1237 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1238 when "big" contains more than 2**29 bytes, even though this
1239 inserts just one byte and does not overflow the buffer.
1240 (Finsert_file_contents): Store file offsets as off_t
1241 values, not as EMACS_INT values. Check for overflow when
1242 converting between EMACS_INT and off_t. When checking for
1243 buffer overflow or for overlap, take the offsets into account.
1244 Don't use EMACS_INT for small values where int suffices.
1245 When checking for overlap, fix a typo: ZV was used where
1246 ZV_BYTE was intended.
1247 (Fwrite_region): Don't assume off_t fits into 'long'.
1248 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1249
1250 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1251
1252 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1253
1254 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1255
1256 sprintf-related integer and memory overflow issues (Bug#9412).
1257
1258 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1259 (esprintf, exprintf, evxprintf): New functions.
1260 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1261 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
1262 (modify_event_symbol): Do not assume that the length of
1263 name_alist_or_stem is safe to alloca and fits in int.
1264 (Fexecute_extended_command): Likewise for function name and binding.
1265 (Frecursion_depth): Wrap around reliably on integer overflow.
1266 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1267 since some callers pass EMACS_INT values.
1268 (Fsingle_key_description): Don't crash if symbol name contains more
1269 than MAX_ALLOCA bytes.
1270 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1271 (get_minibuffer): Arg is now EMACS_INT, not int.
1272 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
1273 (esprintf, exprintf, evxprintf): New decls.
1274 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1275
1276 * dbusbind.c (signature_cat): New function.
1277 (xd_signature, Fdbus_register_signal):
1278 Do not overrun buffer; instead, report string overflow.
1279
1280 * dispnew.c (add_window_display_history): Don't overrun buffer.
1281 Truncate instead; this is OK since it's just a log.
1282
1283 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1284 even if the time zone offset is outlandishly large.
1285 Don't mishandle offset == INT_MIN.
1286
1287 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1288 when creating daemon; the previous buffer-overflow check was incorrect.
1289
1290 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1291 which has the guts of the old verror function.
1292
1293 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1294 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1295
1296 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1297 (font_unparse_xlfd): Don't blindly alloca long strings.
1298 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
1299 fits in int, when using sprintf. Use single snprintf to count
1300 length of string rather than counting it via multiple sprintfs;
1301 that's simpler and more reliable.
1302 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1303 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1304 sprintf, in case result does not fit in int.
1305
1306 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1307 (fontset_from_font): Print it.
1308
1309 * frame.c (tty_frame_count): Now printmax_t, not int.
1310 (make_terminal_frame, set_term_frame_name): Print it.
1311 (x_report_frame_params): In X, window IDs are unsigned long,
1312 not signed long, so print them as unsigned.
1313 (validate_x_resource_name): Check for implausibly long names,
1314 and don't assume name length fits in 'int'.
1315 (x_get_resource_string): Don't blindly alloca invocation name;
1316 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1317 not fit in int.
1318
1319 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1320 (xg_check_special_colors, xg_set_geometry):
1321 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1322
1323 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1324 Use esprintf, not sprintf, in case result does not fit in int.
1325
1326 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1327 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1328 it as a large positive number.
1329 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1330 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1331
1332 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1333 in case result does not fit in int.
1334
1335 * print.c (float_to_string): Detect width overflow more reliably.
1336 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1337 buffer overrun. Don't assume list length fits in 'int'. Treat
1338 print length of 0 as 0, not as infinity; to be consistent with other
1339 uses of print length in this function. Don't overflow print length
1340 index. Don't assume hash table size fits in 'long', or that
1341 vectorlike size fits in 'unsigned long'.
1342
1343 * process.c (make_process): Use printmax_t, not int, to format
1344 process-name gensyms.
1345
1346 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1347
1348 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1349 to avoid potential buffer overrun.
1350
1351 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1352 if X resource line is longer than 512 bytes.
1353
1354 * xfns.c (x_window): Make sprintf buffer a bit bigger
1355 to avoid potential buffer overrun.
1356
1357 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1358
1359 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1360
1361 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1362
1363 Integer overflow fixes for scrolling, etc.
1364 Without these, Emacs silently mishandles large integers sometimes.
1365 For example, "C-u 4294967297 M-x recenter" was treated as if
1366 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1367
1368 * xdisp.c (try_window_id): Check Emacs fixnum range before
1369 converting to 'int'.
1370
1371 * window.c (window_scroll_line_based, Frecenter):
1372 Check that an Emacs fixnum is in range before assigning it to 'int'.
1373 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1374 values converted from Emacs fixnums.
1375 (Frecenter): Don't wrap around a line count if it is out of 'int'
1376 range; instead, treat it as an extreme value.
1377 (Fset_window_configuration, compare_window_configurations):
1378 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1379
1380 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1381 that can exceed INT_MAX. Check that EMACS_INT value is in range
1382 before assigning it to the (possibly-narrower) index.
1383 (match_limit): Don't assume that a fixnum can fit in 'int'.
1384
1385 * print.c (print_object): Use ptrdiff_t, not int, for index that can
1386 exceed INT_MAX.
1387
1388 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
1389 (Fvertical_motion): Don't wrap around LINES values that don't fit
1390 in 'int'. Instead, treat them as extreme values. This is good
1391 enough for windows, which can't have more than INT_MAX lines anyway.
1392
1393 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1394
1395 * Require libxml/parser.h to avoid compilation warning.
1396
1397 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1398
1399 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1400 since this reportedly can destroy thread storage.
1401
1402 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
1403
1404 * syntax.c (find_defun_start): Update all cache variables if
1405 exiting early (Bug#9401).
1406
1407 2011-08-30 Eli Zaretskii <eliz@gnu.org>
1408
1409 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1410
1411 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1412 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1413 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1414
1415 * term.c (tty_append_glyph): New function.
1416 (produce_stretch_glyph): Static function and its prototype deleted.
1417
1418 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1419 Add prototypes.
1420
1421 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1422
1423 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1424 when checking :margin (Bug#9390).
1425 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
1426 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
1427 so that the name doesn't mislead. All uses changed.
1428
1429 2011-08-28 Johan Bockgård <bojohan@gnu.org>
1430
1431 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1432 set_tty_hooks.
1433
1434 2011-08-27 Eli Zaretskii <eliz@gnu.org>
1435
1436 * xdisp.c (move_it_to): Don't bail out early when reaching
1437 position beyond to_charpos, if we are scanning backwards.
1438 (move_it_vertically_backward): When DY == 0, make sure we get to
1439 the first character in the line after the newline.
1440
1441 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1442
1443 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1444 (ccl_driver): Do not generate an out-of-range pointer.
1445 (Fccl_execute_on_string): Remove unnecessary check for
1446 integer overflow, noted by Stefan Monnier in
1447 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1448 Remove a FIXME that didn't need fixing.
1449 Simplify the newly-introduced buffer reallocation code.
1450
1451 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
1452
1453 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1454
1455 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
1456
1457 Integer and memory overflow issues (Bug#9196).
1458
1459 * doc.c (get_doc_string): Rework so that
1460 get_doc_string_buffer_size is the actual buffer size, rather than
1461 being 1 less than the actual buffer size; this makes xpalloc more
1462 convenient.
1463
1464 * image.c (x_allocate_bitmap_record, cache_image):
1465 * xselect.c (Fx_register_dnd_atom):
1466 Simplify previous changes by using xpalloc.
1467
1468 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1469 since either will do and ptrdiff_t is convenient with xpalloc.
1470
1471 * charset.c (charset_table_size)
1472 (struct charset_sort_data.priority): Now ptrdiff_t.
1473 (charset_compare): Don't overflow if priorities differ greatly.
1474 (Fsort_charsets): Don't assume list length fits in int.
1475 Check for size-calculation overflow when allocating sort data.
1476 (syms_of_charset): Allocate an initial charset table that is
1477 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1478
1479 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1480
1481 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1482 The actual value is always <= INT_MAX, and leaving it unsigned made
1483 overflow checking harder.
1484
1485 * dispextern.h (struct glyph_matrix.rows_allocated)
1486 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1487 with xpalloc. The values are still always <= INT_MAX.
1488
1489 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1490
1491 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1492 (SAFE_NALLOCA): New macro.
1493
1494 * region-cache.c (struct boundary.pos, find_cache_boundary)
1495 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1496 (set_cache_region, invalidate_region_cache)
1497 (revalidate_region_cache, know_region_cache, region_cache_forward)
1498 (region_cache_backward, pp_cache):
1499 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1500 so that ptrdiff_t * can be passed to xpalloc.
1501 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1502 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1503 (pp_cache): Don't assume cache_len fits in int.
1504 * region-cache.h: Adjust extern decls to match.
1505
1506 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1507 EMACS_INT, since either will do, for xpalloc.
1508
1509 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1510 (xnmalloc, xnrealloc, xpalloc): New functions.
1511
1512 * bidi.c (bidi_shelve_header_size): New constant.
1513 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1514 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1515
1516 * bidi.c (bidi_cache_shrink):
1517 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1518 (overlay_strings):
1519 Don't update size of array until after memory allocation succeeds,
1520 because xmalloc/xrealloc may not return.
1521 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1522 now that we have proper integer overflow checking.
1523 (record_overlay_string, overlay_strings): Catch overflows when
1524 calculating size of overlay_str_buf.
1525
1526 * callproc.c (Fcall_process): Check for size overflow when
1527 calculating size of args2.
1528 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1529 Normally we prefer signed values, but sticking with ptrdiff_t would
1530 require adding more-complicated checks.
1531
1532 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1533 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1534 Redo buffer-overflow calculations to avoid integer overflow.
1535 Add a FIXME comment where memory seems to be over-allocated.
1536
1537 * character.c (Fstring): Check for size-calculation overflow.
1538
1539 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1540 unnecessary integer overflow. Check for size overflow.
1541 (encode_coding_object): Don't update size until xmalloc succeeds.
1542
1543 * composite.c (get_composition_id): Check for overflow in glyph
1544 length calculations.
1545
1546 Integer and memory overflow fixes for display code.
1547 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1548 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1549 (scrolling_window): Check for overflow in size calculations.
1550 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1551 Don't assume glyph table len fits in int.
1552 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1553 (row_table_size): Now ptrdiff_t, not int.
1554 (scrolling_window): Avoid overflow in size calculations.
1555 Don't update size until allocation succeeds.
1556 * fns.c (concat): Check for overflow in size calculations.
1557 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1558 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1559 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1560
1561 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1562 (get_doc_string): Check for size calculation overflow.
1563 Don't update size until allocation succeeds.
1564 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1565 EMACS_INT, where ptrdiff_t will do.
1566 (Fsubstitute_command_keys): Check for string overflow.
1567
1568 * editfns.c (set_time_zone_rule): Don't assume environment length
1569 fits in int.
1570 (message_length): Now ptrdiff_t, not int.
1571 (Fmessage_box): Don't update size until allocation succeeds.
1572 Don't assume message length fits in int.
1573 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1574
1575 * emacs.c (main): Do not reallocate argv, since there is a null at
1576 the end that can be overwritten, and this way there's no need to
1577 worry about size-calculation overflow.
1578 (sort_args): Check for size-calculation overflow.
1579
1580 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1581 alloc succeeds.
1582 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1583
1584 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1585 (x_set_scroll_bar_width, x_figure_window_size):
1586 Check for integer overflow.
1587 (x_set_alpha): Do not assume XINT fits in int.
1588
1589 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1590 This is for the members text_lines, text_cols, total_lines, total_cols,
1591 where the system imposes an 'int' limit.
1592
1593 * fringe.c (Fdefine_fringe_bitmap):
1594 Don't update size until alloc works.
1595
1596 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1597 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1598
1599 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1600 Check for size-calculation overflow.
1601 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1602 do, as we prefer signed integers.
1603 (id_to_widget.max_size, id_to_widget.used)
1604 (xg_store_widget_in_map, xg_remove_widget_from_map)
1605 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1606 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1607 Use and return ptrdiff_t, not int.
1608 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1609 * gtkutil.h: Change prototypes to match the above.
1610
1611 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1612 are duplicate now that they've been promoted to lisp.h.
1613 (x_allocate_bitmap_record, x_alloc_image_color)
1614 (make_image_cache, cache_image, xpm_load):
1615 Don't update size until alloc is done.
1616 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1617 (x_detect_edges):
1618 Check for size calculation overflow.
1619 (ct_colors_allocated_max): New constant.
1620 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1621 overflow.
1622
1623 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1624 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1625 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1626 Use ptrdiff_t, not int, to count maps.
1627 (read_char_minibuf_menu_prompt): Check for overflow in size
1628 calculations. Don't update size until allocation succeeds.
1629 Redo calculations to avoid overflow.
1630 * keyboard.h: Change prototypes to match the above.
1631
1632 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1633 to count maps.
1634 (current_minor_maps): Check for size calculation overflow.
1635 * keymap.h: Change prototypes to match the above.
1636
1637 * lread.c (read1, init_obarray): Don't update size until alloc done.
1638
1639 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1640 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1641
1642 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1643 Now ptrdiff_t, not int.
1644 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1645 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1646
1647 * process.c (Fnetwork_interface_list): Check for overflow
1648 in size calculation.
1649
1650 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1651
1652 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1653 overflow. Don't bother calling xmalloc when xrealloc will do.
1654
1655 * search.c (Freplace_match): Check for size calculation overflow.
1656 (Fset_match_data): Don't assume list lengths fit in 'int'.
1657
1658 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1659 for command line length. Do not attempt to address one before the
1660 beginning of an array, as that's not portable.
1661
1662 * term.c (max_frame_lines): Remove; unused.
1663 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1664 not int.
1665 (encode_terminal_code, calculate_costs): Check for size
1666 calculation overflow.
1667 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1668 table lengths and related sizes. Don't update size until alloc
1669 done. Redo calculations to avoid overflow.
1670 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1671
1672 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1673 subtracting pointers.
1674 (gobble_line): Check for overflow more carefully. Don't update size
1675 until alloc done.
1676
1677 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1678 Don't update size until alloc done.
1679 Redo size calculations to avoid overflow.
1680 Check for size calculation overflow.
1681 (main) [DEBUG]: Fix typo in invoking tparam1.
1682
1683 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1684 Use ptrdiff_t, not int, for sizes.
1685 (store_mode_line_noprop_char): Don't update size until alloc done.
1686
1687 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1688 Use ptrdiff_t, not int, for sizes.
1689 (Finternal_make_lisp_face, cache_face):
1690 Check for size calculation overflow.
1691 (cache_face): Treat size calculation overflows as if they were
1692 memory exhaustion (the usual treatment), rather than aborting.
1693
1694 * xfns.c (x_encode_text, x_set_name_internal)
1695 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1696 sizes, since they can exceed INT_MAX in size. Check for size
1697 calculation overflow.
1698
1699 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1700 (xg_select): Check for size calculation overflow.
1701 Don't update size until alloc done.
1702
1703 * xrdb.c (get_environ_db): Don't assume path length fits in int,
1704 as sprintf is limited to int lengths.
1705
1706 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1707 (X_LONG_MIN): New macros.
1708 Use them to make the following changes clearer.
1709 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1710 This change doesn't affect the value now, but it may help remind
1711 future maintainers not to raise the value too much later.
1712 (SELECTION_QUANTUM): Remove, replacing with ...
1713 (selection_quantum): ... new function, which avoids overflow.
1714 All uses changed.
1715 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1716 assumption that selection length fits in 'int'.
1717 (x_reply_selection_request, x_handle_selection_request)
1718 (x_get_window_property, receive_incremental_selection)
1719 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1720 (lisp_data_to_selection_data, clean_local_selection_data):
1721 Use ptrdiff_t, not int, to record length of selection.
1722 (x_reply_selection_request, x_get_window_property)
1723 (receive_incremental_selection, x_property_data_to_lisp):
1724 Redo calculations to avoid overflow.
1725 (x_reply_selection_request): When sending hint, ceiling it at
1726 X_LONG_MAX rather than relying on wraparound overflow to send
1727 something.
1728 (x_get_window_property, receive_incremental_selection)
1729 (lisp_data_to_selection_data, x_property_data_to_lisp):
1730 Check for size-calculation overflow.
1731 (x_get_window_property, receive_incremental_selection)
1732 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1733 Don't store size until memory allocation succeeds.
1734 (x_get_window_property): Plug memory leak on memory exhaustion.
1735 Don't double-block input; malloc is safe here. Don't assume 2**34
1736 - 4 fits in unsigned long. Add an xassert to check
1737 XGetWindowProperty overflow. Be more careful about overflow
1738 calculations, and distinguish size from memory overflow better.
1739 (receive_incremental_selection): When tracing, don't assume
1740 unsigned int is less than INT_MAX.
1741 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1742 harmful) conversions of unsigned short to int.
1743 (lisp_data_to_selection_data): Don't assume that integers
1744 in the range -65535 through -1 fit in an X unsigned short.
1745 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1746 result parameters unless successful. Rely on cons_to_unsigned
1747 to report problems with elements; the old code wasn't right anyway.
1748 (x_check_property_data): Check for int overflow; we cannot use
1749 a wider type due to X limits.
1750 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1751
1752 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
1753
1754 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1755 (x_term_init): Check for size calculation overflow.
1756 (x_color_cells): Don't store size until memory allocation succeeds.
1757 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
1758 Don't assume alloca size is less than MAX_ALLOCA.
1759 (x_term_init): Don't assume length fits in int (sprintf is limited
1760 to int size).
1761
1762 Use ptrdiff_t for composition IDs.
1763 * character.c (lisp_string_width):
1764 * composite.c (composition_table_size, n_compositions)
1765 (get_composition_id, composition_gstring_from_id):
1766 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1767 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1768 * window.c (Frecenter):
1769 Use ptrdiff_t, not int, for composition IDs.
1770 * composite.c (get_composition_id): Check for integer overflow.
1771 * composite.h: Adjust prototypes to match the above changes.
1772
1773 Use ptrdiff_t for hash table indexes.
1774 * category.c (hash_get_category_set):
1775 * ccl.c (ccl_driver):
1776 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1777 * coding.c (coding_system_charset_list, detect_coding_system):
1778 * coding.h (struct coding_system.id):
1779 * composite.c (get_composition_id, gstring_lookup_cache):
1780 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1781 * image.c (xpm_get_color_table_h):
1782 * lisp.h (hash_lookup, hash_put):
1783 * minibuf.c (Ftest_completion):
1784 Use ptrdiff_t for hash table indexes, not int (which is too
1785 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1786 32-bit --with-wide-int hosts).
1787
1788 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1789 Add a FIXME comment about memory leaks.
1790 (syms_of_charset): Don't assume xmalloc returns.
1791
1792 Don't assume that stated character widths fit in int.
1793 * character.c (Fchar_width, c_string_width, lisp_string_width):
1794 * character.h (CHAR_WIDTH):
1795 * indent.c (MULTIBYTE_BYTES_WIDTH):
1796 Use sanitize_char_width to avoid undefined and/or bad behavior
1797 with outlandish widths.
1798 * character.h (sanitize_tab_width): Rename from sanitize_width,
1799 now that we have two such functions. All uses changed.
1800 (sanitize_char_width): New inline function.
1801
1802 Don't assume that tab-width fits in int.
1803 * character.h (sanitize_width): New inline function.
1804 (SANE_TAB_WIDTH): New macro.
1805 (ASCII_CHAR_WIDTH): Use it.
1806 * indent.c (sane_tab_width): Remove. All uses replaced by
1807 SANE_TAB_WIDTH (current_buffer).
1808 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1809
1810 * fileio.c: Integer overflow issues with file modes.
1811 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1812
1813 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1814 Remove unreachable code.
1815 (read_hex, load_charset_map_from_file): Check for integer overflow.
1816
1817 * xterm.c: don't go over XClientMessageEvent limit
1818 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1819 (x_send_scroll_bar_event): Likewise. Check that the size does not
1820 exceed limits imposed by XClientMessageEvent, as well as the usual
1821 ptrdiff_t and size_t limits.
1822
1823 * keyboard.c: Overflow, signedness and related fixes.
1824 (make_lispy_movement): Use same integer type in forward decl
1825 that is used in the definition.
1826 (read_key_sequence, keyremap_step):
1827 Change bufsize argument back to int, undoing my 2011-03-30 change.
1828 We prefer signed types, and int is wide enough here.
1829 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1830 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1831 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1832 length, not size_t. Use ptrdiff_t for index, not int.
1833 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1834 possibility of integer overflow.
1835
1836 Overflow, signedness and related fixes for images.
1837
1838 * dispextern.h (struct it.stack[0].u.image.image_id)
1839 (struct_it.image_id, struct image.id, struct image_cache.size)
1840 (struct image_cache.used, struct image_cache.ref_count):
1841 * gtkutil.c (update_frame_tool_bar):
1842 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1843 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1844 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1845 * nsmenu.m (update_frame_tool_bar):
1846 * xdisp.c (calc_pixel_width_or_height):
1847 * xfns.c (image_cache_refcount):
1848 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1849 on typical 64-bit hosts.
1850
1851 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1852 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1853 Omit unnecessary casts to int.
1854 (parse_image_spec): Check that integers fall into 'int' range
1855 when the callers expect that.
1856 (image_ascent): Redo ascent calculation to avoid int overflow.
1857 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1858 (lookup_image): Remove unnecessary tests.
1859 (xbm_image_p): Locals are now of int, not EMACS_INT,
1860 since parse_image_check makes sure they fit into int.
1861 (png_load, gif_load, svg_load_image):
1862 Prefer int to unsigned where either will do.
1863 (tiff_handler): New function, combining the cores of the
1864 old tiff_error_handler and tiff_warning_handler.
1865 This function is rewritten to use vsnprintf and thereby avoid
1866 stack buffer overflows. It uses only the features of vsnprintf
1867 that are common to both POSIX and native Microsoft.
1868 (tiff_error_handler, tiff_warning_handler): Use it.
1869 (tiff_load, gif_load, imagemagick_load_image):
1870 Don't assume :index value fits in 'int'.
1871 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1872 (imagemagick_load_image): Check that crop parameters fit into
1873 the integer types that MagickCropImage accepts. Don't assume
1874 Vimagemagick_render_type has a nonnegative value. Don't assume
1875 size_t fits in 'long'.
1876 (gs_load): Use printmax_t to print the widest integers possible.
1877 Check for integer overflow when computing image height and width.
1878
1879 2011-08-26 Eli Zaretskii <eliz@gnu.org>
1880
1881 * xdisp.c (redisplay_window): Don't force window start if point
1882 will be invisible in the resulting window. (Bug#9324)
1883
1884 2011-08-25 Eli Zaretskii <eliz@gnu.org>
1885
1886 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1887 the display spec is of the form `(space ...)'.
1888 (handle_display_spec): Return the value returned by
1889 handle_single_display_spec, not just 1 or zero.
1890 (handle_single_display_spec): If the display spec is of the form
1891 `(space ...)', and specifies display in the text area, return 2
1892 rather than 1.
1893 (try_cursor_movement): Check for the need to scroll more
1894 accurately, and prefer exact match for point under bidi.
1895 Don't advance `row' beyond the last row of the window.
1896
1897 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1898 into disp_prop; all users changed.
1899
1900 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1901 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1902 for the text covered by the display property.
1903
1904 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
1905
1906 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1907 Change return value to nil.
1908 (Frecord_buffer): Delete unused function.
1909
1910 2011-08-24 Eli Zaretskii <eliz@gnu.org>
1911
1912 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1913 buffers, return left-to-right.
1914 (set_cursor_from_row): Consider candidate row a win if its glyph
1915 represents a newline and point is on that newline. Fixes cursor
1916 positioning on the newline at EOL of R2L text within L2R
1917 paragraph, and vice versa.
1918 (try_cursor_movement): Check continued rows, in addition to
1919 continuation rows. Fixes unwarranted scroll when point enters a
1920 continued line of R2L text within an L2R paragraph, or vice versa.
1921 (cursor_row_p): Consider the case of point being equal to
1922 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1923 from the end of a short line to the beginning of a continued line
1924 of R2L text within L2R paragraph.
1925 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1926 composed characters.
1927
1928 * bidi.c (bidi_check_type): Use xassert.
1929 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1930 members.
1931
1932 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1933
1934 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1935 a character.
1936
1937 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
1938
1939 * nsfont.m (ns_otf_to_script): Fix typo.
1940
1941 2011-08-22 Kenichi Handa <handa@m17n.org>
1942
1943 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1944 extra slot even if the purpose is char-code-property-table.
1945
1946 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1947
1948 * xdisp.c (redisplay_window): When computing centering_position,
1949 account for the height of the header line. (Bug#8874)
1950
1951 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1952 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1953 candidate is selected by the mouse, and that candidate has a
1954 composed character under the mouse.
1955
1956 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1957 coordinates reported by pos-visible-in-window-p for a composed
1958 character in column zero.
1959
1960 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1961
1962 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1963
1964 2011-08-22 Eli Zaretskii <eliz@gnu.org>
1965
1966 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1967 consider it a hit if to_charpos is anywhere in the range of the
1968 composed buffer positions.
1969
1970 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
1971
1972 * image.c (gif_load): Don't assume that each subimage has the same
1973 dimensions as the base image. Handle disposal method that is
1974 "undefined" by the gif spec (Bug#9335).
1975
1976 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
1977
1978 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
1979 (Fcondition_case): Document `debug' symbol in error handler.
1980
1981 2011-08-19 Eli Zaretskii <eliz@gnu.org>
1982
1983 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1984 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1985 from an Org mode buffer to a Speedbar frame.
1986
1987 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1988 a composition, take its buffer position from IT->cmp_it.charpos.
1989 Fixes cursor positioning at the beginning of a line that begins
1990 with a composed character.
1991
1992 2011-08-18 Eli Zaretskii <eliz@gnu.org>
1993
1994 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1995 character bidirectional type, use STRONG_L instead. Fixes crashes
1996 in a buffer produced by `describe-categories'.
1997
1998 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1999 members before the level stack, so they would be saved and
2000 restored when copying iterator state. Fixes incorrect reordering
2001 around TABs covered by display properties.
2002
2003 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2004
2005 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2006
2007 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2008
2009 * eval.c (internal_condition_case, internal_condition_case_1)
2010 (internal_condition_case_2, internal_condition_case_n):
2011 Remove unnecessary aborts (Bug#9081).
2012
2013 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2014
2015 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2016 has no `load' handler, try opening the file locally. (Bug#9311)
2017
2018 2011-08-16 Ken Brown <kbrown@cornell.edu>
2019
2020 * gmalloc.c: Expand comment.
2021
2022 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2023
2024 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2025 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2026
2027 2011-08-16 Ken Brown <kbrown@cornell.edu>
2028
2029 Fix memory allocation problems in Cygwin build (Bug#9273).
2030
2031 * unexcw.c ( __malloc_initialized): Declare external variable.
2032 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2033
2034 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2035 New variables.
2036 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2037 dumped emacs.
2038 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2039 in the static heap.
2040 [CYGWIN] (special_realloc): New function.
2041 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2042 requests to realloc storage in the static heap.
2043
2044 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2045
2046 * bidi.c (bidi_initialize): Remove unused local.
2047
2048 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2049
2050 * bidimirror.h:
2051 * biditype.h: Remove file.
2052 * makefile.w32-in ($(BLD)/bidi.$(O)):
2053 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2054
2055 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2056
2057 * chartab.c: Improve commentary for the uniprop_table API.
2058
2059 * bidi.c (bidi_paragraph_init): Support zero value of
2060 bidi_ignore_explicit_marks_for_paragraph_level.
2061 (bidi_initialize): Use uniprop_table instead of including
2062 biditype.h and bidimirror.h.
2063
2064 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2065 coordinates of the iterator when restoring from ppos_it.
2066 (Bug#9296)
2067
2068 2011-08-14 Kenichi Handa <handa@m17n.org>
2069
2070 * process.c (create_process): Call setup_process_coding_systems
2071 after the pid of the process is set to -1 (Bug#8162).
2072
2073 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2074
2075 * xdisp.c (move_it_in_display_line_to): Don't invoke
2076 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2077 ppos_it. Fixes vertical cursor motion when line beginning is
2078 covered by an image. (Bug#9296)
2079
2080 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2081
2082 * nsterm.h (ns_run_ascript): Declare.
2083 (NSAPP_DATA2_RUNASSCRIPT): Define.
2084
2085 * nsfns.m (as_script, as_result, as_status): New static variables.
2086 (ns_run_ascript): New function.
2087 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2088 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2089 the event loop. Get status from as_status (Bug#7276).
2090
2091 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2092 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2093 the event loop (Bug#7276).
2094
2095 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2096
2097 * gnutls.c (QCgnutls_bootprop_priority)
2098 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2099 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2100 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2101 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2102 (QCgnutls_bootprop_verify_hostname_error)
2103 (QCgnutls_bootprop_callbacks_verify): Rename from
2104 Qgnutls_bootprop_..., all uses changed.
2105
2106 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2107 uses changed.
2108
2109 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2110
2111 * xfaces.c (Qframe_set_background_mode): Now static.
2112 * dispextern.h (Qframe_set_background_mode): Remove decl.
2113
2114 * process.c (Fnetwork_interface_info): Declare local only if needed.
2115
2116 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2117
2118 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2119 (Fnetwork_interface_list): Allocate in increments of bytes instead
2120 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2121 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2122 sockaddr.
2123 (struct ifflag_def): notrailers is smart on OSX.
2124 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2125 Get hardware address with getifaddrs if available.
2126
2127 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2128
2129 * xdisp.c (iterate_out_of_display_property): xassert that
2130 IT->position is set to within IT->object's boundaries. Break from
2131 the loop as soon as EOB is reached; avoids infloops in redisplay
2132 when IT->position is set up wrongly due to some bug.
2133 Set IT->current to match the bidi iterator unconditionally.
2134 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2135 entry. Force push_it to save on the stack the current
2136 buffer/string position, to be restored by pop_it. Fix flags in
2137 the iterator structure wrt the object coming from a display
2138 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2139 properties. (Bug#9284)
2140
2141 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2142
2143 * fontset.c (fontset_get_font_group): Add proper type checks.
2144 (Bug#9172)
2145
2146 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2147
2148 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2149 and LC_VERSION_MIN_MACOSX.
2150 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2151 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2152
2153 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2154
2155 * xdisp.c (forward_to_next_line_start): Allow to use the
2156 no-display-properties-and-no-overlays under bidi display.
2157 Set disp_pos in the bidi iterator to avoid searches for display
2158 properties and overlays.
2159
2160 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2161
2162 * editfns.c (Fset_time_zone_rule): Document relationship with the
2163 setenv function.
2164
2165 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2166 the font entity extracted from the cache (Bug#8109).
2167
2168 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2169
2170 * composite.c (autocmp_chars): Don't reset point. That is done by
2171 restore_point_unwind (Bug#5984).
2172
2173 2011-08-07 Juri Linkov <juri@jurta.org>
2174
2175 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2176 to show the arg `TIME' instead of `TIMEVAL'.
2177
2178 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2179
2180 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2181 display property strides EOL and includes a newline, as in
2182 longlines-mode. (Bug#9254)
2183 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2184 word-wrap under bidirectional display. (Bug#9224)
2185
2186 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2187 is non-zero, even if the data buffer is NULL. Fixes a crash in
2188 vertical-motion with longlines-mode. (Bug#9254)
2189
2190 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2191
2192 * bidi.c <bidi_cache_total_alloc>: Now static.
2193 (bidi_initialize): Initialize bidi_cache_total_alloc.
2194
2195 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2196 cache. (Bug#9221)
2197
2198 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2199 amount allocated this far in `bidi_cache_total_alloc'.
2200 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2201 non-zero, only free the data buffer without restoring the cache
2202 contents. All callers changed.
2203
2204 * dispextern.h (bidi_unshelve_cache): Update prototype.
2205
2206 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2207 (move_it_in_display_line, move_it_to)
2208 (move_it_vertically_backward, move_it_by_lines): Replace the call
2209 to xfree to an equivalent call to bidi_unshelve_cache.
2210 (move_it_in_display_line_to): Fix logic of returning
2211 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2212
2213 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2214
2215 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2216 came from a string character with a `cursor' property. (Bug#9229)
2217
2218 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2219
2220 * Makefile.in (LIB_PTHREAD): New variable.
2221 (LIBES): Add LIB_PTHREAD (Bug#9216).
2222
2223 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2224 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2225
2226 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2227
2228 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2229
2230 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2231
2232 * xterm.c (x_find_topmost_parent): New function.
2233 (x_set_frame_alpha): Find topmost parent window with
2234 x_find_topmost_parent and set the property there also (bug#9181).
2235 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2236
2237 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2238
2239 * callproc.c (Fcall_process): Avoid vfork clobbering
2240 the local vars buffer, coding_systems, current_dir.
2241
2242 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2243
2244 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2245
2246 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2247
2248 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2249 so that it is not optimized away.
2250
2251 * xdisp.c (compute_display_string_pos): Remove unused local.
2252
2253 2011-08-02 Eli Zaretskii <eliz@gnu.org>
2254
2255 Fix slow cursor motion and scrolling in large buffers with
2256 selective display, like Org Mode buffers. (Bug#9218)
2257
2258 * dispextern.h (struct bidi_it): New member disp_prop_p.
2259
2260 * xdisp.c: Remove one-slot cache of display string positions.
2261 (compute_display_string_pos): Accept an additional argument
2262 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2263 for a display string or property. If found, set DISP_PROP_P
2264 non-zero.
2265
2266 * bidi.c (bidi_fetch_char): Accept an additional argument
2267 DISP_PROP_P, and pass it to compute_display_string_pos.
2268 Only handle text covered by a display string if DISP_PROP_P is returned
2269 non-zero. All callers of bidi_fetch_char changed.
2270
2271 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2272
2273 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2274
2275 2010-12-03 Don March <don@ohspite.net>
2276
2277 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2278 last character M-[char] is translated to ESC [char] (bug#7541).
2279
2280 2011-08-02 Kenichi Handa <handa@m17n.org>
2281
2282 * lisp.h (uniprop_table): Extern it.
2283
2284 * chartab.c (uniprop_table): Make it non-static.
2285
2286 2011-08-01 Eli Zaretskii <eliz@gnu.org>
2287
2288 * xdisp.c (forward_to_next_line_start): Accept additional argument
2289 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2290 on the newline.
2291 (reseat_at_next_visible_line_start): Use the bidi iterator state
2292 returned by forward_to_next_line_start to restore the state of
2293 it->bidi_it after backing up to previous newline. (Bug#9212)
2294
2295 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2296
2297 * regex.c (re_comp): Protoize.
2298 (re_exec): Fix return type.
2299 (regexec): Fix type of `ret'. (Bug#9203)
2300
2301 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2302
2303 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2304 This is needed if max-image-size is a floating-point number.
2305
2306 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2307
2308 * print.c (print_object): Print empty symbol as ##.
2309
2310 * lread.c (read1): Read ## as empty symbol.
2311
2312 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2313
2314 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2315 setting frame foreground color (Bug#9175).
2316 (x_set_background_color): Likewise.
2317
2318 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2319 contents (Bug#9176).
2320 (EmacsTooltip -init): Remove bezels and add shadows to
2321 tooltip windows.
2322
2323 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2324 or scroll bar (Bug#8470).
2325
2326 * nsfont.m (nsfont_open): Remove assignment to voffset and
2327 unnecessary vars hshink, expand, hd, full_height, min_height.
2328 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2329
2330 * nsterm.h (nsfont_info): Remove voffset field.
2331
2332 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2333
2334 Implement strike-through and overline on NextStep (Bug#8863).
2335
2336 * nsfont.m (nsfont_open): Use underline position provided by font,
2337 instead of hard-coded value of 2.
2338 (nsfont_draw): Call ns_draw_text_decoration instead.
2339
2340 * nsterm.h: Add declaration for ns_draw_text_decoration.
2341
2342 * nsterm.m (ns_draw_text_decoration): New function for drawing
2343 underline, overline, and strike-through.
2344 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2345 ns_draw_text_decoration. Change treatment of cursor drawing to
2346 accommodate underlining, etc.
2347
2348 2011-07-28 Eli Zaretskii <eliz@gnu.org>
2349
2350 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2351 default.
2352
2353 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2354
2355 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2356 Without this fix, if a signal arrives just after memory fills up,
2357 'malloc' might be invoked reentrantly.
2358
2359 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2360 In other words, assume that every image size is allowed, on non-X
2361 hosts. This assumption is probably wrong, but it lets Emacs compile.
2362
2363 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2364
2365 * regex.c (re_iswctype): Convert return values to boolean.
2366
2367 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2368
2369 * xdisp.c (compute_display_string_pos): Don't use cached display
2370 string position if the buffer had its restriction changed.
2371 (Bug#9184)
2372
2373 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2374
2375 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2376
2377 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2378
2379 Integer signedness and overflow and related fixes. (Bug#9079)
2380
2381 * bidi.c: Integer size and overflow fixes.
2382 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2383 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2384 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2385 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2386 (bidi_find_other_level_edge):
2387 Use ptrdiff_t instead of EMACS_INT where either will do.
2388 This works better on 32-bit hosts configured --with-wide-int.
2389 (bidi_cache_ensure_space): Check for size-calculation overflow.
2390 Use % rather than repeated addition, for better worst-case speed.
2391 Don't set bidi_cache_size until after xrealloc returns, because it
2392 might not return.
2393 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
2394 (bidi_cache_ensure_space): Also check that the bidi cache size
2395 does not exceed that of the largest Lisp string or buffer. See Eli
2396 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
2397
2398 * alloc.c (__malloc_size_t): Remove.
2399 All uses replaced by size_t. See Andreas Schwab's note
2400 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2401
2402 * image.c: Improve checking for integer overflow.
2403 (check_image_size): Assume that f is nonnull, since
2404 it is always nonnull in practice. This is one less thing to
2405 worry about when checking for integer overflow later.
2406 (x_check_image_size): New function, which checks for integer
2407 overflow issues inside X.
2408 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2409 This removes the need for a memory_full check.
2410 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2411 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2412 (xbm_read_bitmap_data): Change locals back to 'int', since
2413 their values must fit in 'int'.
2414 (xpm_load_image, png_load, tiff_load):
2415 Invoke x_create_x_image_and_pixmap earlier,
2416 to avoid much needless work if the image is too large.
2417 (tiff_load): Treat overly large images as if
2418 x_create_x_image_and_pixmap failed, not as malloc failures.
2419 (gs_load): Use x_check_image_size.
2420
2421 * gtkutil.c: Omit integer casts.
2422 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2423 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2424
2425 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2426
2427 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2428 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2429 would wrongly return t on a 64-bit host.
2430
2431 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2432 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2433 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2434 and therefore cause GCC to emit a bogus diagnostic in some cases.
2435
2436 * image.c: Integer signedness and overflow and related fixes.
2437 This is not an exhaustive set of fixes, but it's time to
2438 record what I've got.
2439 (lookup_pixel_color, check_image_size): Remove redundant decls.
2440 (check_image_size): Don't assume that arbitrary EMACS_INT values
2441 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2442 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2443 (tiff_load, imagemagick_load_image):
2444 Check for overflow in size calculations.
2445 (x_create_x_image_and_pixmap): Remove unnecessary test for
2446 xmalloc returning NULL; that can't happen.
2447 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2448 (xpm_color_bucket): Use better integer hashing function.
2449 (xpm_cache_color): Don't possibly over-allocate memory.
2450 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2451 (gif_memory_source):
2452 Use ptrdiff_t, not int or size_t, to record sizes.
2453 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2454 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2455 either works, as we prefer signed integers.
2456 (tiff_read_from_memory, tiff_write_from_memory):
2457 Return tsize_t, not size_t, since that's what the TIFF API wants.
2458 (tiff_read_from_memory): Don't fail simply because the read would
2459 go past EOF; instead, return a short read.
2460 (tiff_load): Omit no-longer-needed casts.
2461 (Fimagemagick_types): Don't assume size fits into 'int'.
2462
2463 Improve hashing quality when configured --with-wide-int.
2464 * fns.c (hash_string): New function, taken from sxhash_string.
2465 Do not discard information about ASCII character case; this
2466 discarding is no longer needed.
2467 (sxhash-string): Use it. Change sig to match it. Caller changed.
2468 * lisp.h: Declare it.
2469 * lread.c (hash_string): Remove, since we now use fns.c's version.
2470 The fns.c version returns a wider integer if --with-wide-int is
2471 specified, so this should help the quality of the hashing a bit.
2472
2473 * emacs.c: Integer overflow minor fix.
2474 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2475 Define only if GNU_LINUX.
2476 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2477
2478 * dispnew.c: Integer signedness and overflow fixes.
2479 Remove unnecessary forward decls, that were a maintenance hassle.
2480 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2481 All uses changed.
2482 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2483 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2484 (prepare_desired_row, line_draw_cost):
2485 Use int, not unsigned, where either works.
2486 (save_current_matrix, restore_current_matrix):
2487 Use ptrdiff_t, not size_t, where either works.
2488 (init_display): Check for overflow more accurately, and without
2489 relying on undefined behavior.
2490
2491 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2492 Remove, replacing with the new symbols in lisp.h. All uses changed.
2493 * fileio.c (make_temp_name):
2494 * filelock.c (lock_file_1, lock_file):
2495 * xdisp.c (message_dolog):
2496 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2497 Use pMd etc. instead.
2498 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2499 replacing the pWIDE etc. symbols removed from editfns.c.
2500
2501 * keyboard.h (num_input_events): Now uintmax_t.
2502 This is (very slightly) less likely to mess up due to wraparound.
2503 All uses changed.
2504
2505 * buffer.c: Integer signedness fixes.
2506 (alloc_buffer_text, enlarge_buffer_text):
2507 Use ptrdiff_t rather than size_t when either will do, as we prefer
2508 signed integers.
2509
2510 * alloc.c: Integer signedness and overflow fixes.
2511 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2512 (__malloc_size_t): Default to size_t, not to int.
2513 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2514 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2515 Prefer ptrdiff_t to size_t when either would do, as we prefer
2516 signed integers.
2517 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2518 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2519 Now const. Initialize with values that are in range even if char
2520 is signed.
2521 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2522 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2523 These functions do the right thing with sizes > 2**32.
2524 (check_depth): Now ptrdiff_t, not int.
2525 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2526 Adjust to new way of storing sizes. Check for size overflow bugs
2527 in rest of code.
2528 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2529 slightly wrong anyway, as it missed one instance of
2530 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2531 (refill_memory_reserve): Omit needless cast to size_t.
2532 (mark_object_loop_halt): Mark as externally visible.
2533
2534 * xselect.c: Integer signedness and overflow fixes.
2535 (Fx_register_dnd_atom, x_handle_dnd_message):
2536 Use ptrdiff_t, not size_t, since we prefer signed.
2537 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2538 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2539 x_dnd_atoms_size and x_dnd_atoms_length.
2540
2541 * doprnt.c: Prefer signed to unsigned when either works.
2542 * eval.c (verror):
2543 * doprnt.c (doprnt):
2544 * lisp.h (doprnt):
2545 * xdisp.c (vmessage):
2546 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2547 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2548 prefer signed arithmetic to avoid comparison confusion.
2549 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2550 but is a bit tricky.
2551
2552 Assume freestanding C89 headers, string.h, stdlib.h.
2553 * data.c, doprnt.c, floatfns.c, print.c:
2554 Include float.h unconditionally.
2555 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2556 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2557 * regex.c: Likewise for stddef.h, string.h.
2558 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2559 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2560 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2561 (STDC_HEADERS): Remove obsolete defines.
2562 * sysdep.c: Include limits.h unconditionally.
2563
2564 Assume support for memcmp, memcpy, memmove, memset.
2565 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2566 * regex.c (memcmp, memcpy):
2567 Remove; we assume C89 now.
2568
2569 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2570 (__malloc_safe_bcopy): Remove; no longer needed.
2571
2572 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
2573 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2574 well either way, and we prefer signed to unsigned.
2575
2576 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2577
2578 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2579 closes the connection while we're reading (bug#9182).
2580
2581 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
2582
2583 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2584 are specified (Bug#9168).
2585
2586 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2587
2588 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2589 Found by GCC static checking and --with-wide-int on a 32-bit host.
2590
2591 2011-07-25 Eli Zaretskii <eliz@gnu.org>
2592
2593 * xdisp.c (compute_display_string_pos): Fix logic of caching
2594 previous display string position. Initialize cached_prev_pos to
2595 -1. Fixes slow-down at the beginning of a buffer.
2596
2597 2011-07-24 Eli Zaretskii <eliz@gnu.org>
2598
2599 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2600 for attrs[LFACE_FONTSET_INDEX].
2601
2602 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2603
2604 * xml.c (parse_region): Remove unused local
2605 that was recently introduced.
2606
2607 2011-07-23 Eli Zaretskii <eliz@gnu.org>
2608
2609 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2610 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2611
2612 * xdisp.c (move_it_in_display_line_to): Record the best matching
2613 position for TO_CHARPOS while scanning the line, and restore it on
2614 exit if none of the characters scanned was an exact match.
2615 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
2616 when exact match is impossible due to invisible text, and the
2617 lines are truncated.
2618
2619 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2620
2621 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2622 for OSX >= 10.7.
2623
2624 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2625
2626 Fix a significant slow-down of cursor motion with C-n, C-p,
2627 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2628 auto-repeat under bidi redisplay in fontified buffers.
2629 * xdisp.c (compute_stop_pos_backwards): New function.
2630 (next_element_from_buffer): Call compute_stop_pos_backwards to
2631 find a suitable prev_stop when we find ourselves before
2632 base_level_stop.
2633 (reseat): Don't look for prev_stop, as that could mean a very long
2634 run.
2635 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2636 <cached_disp_overlay_modiff>: Cache for last found display string
2637 position.
2638 (compute_display_string_pos): Return the cached position if asked
2639 about the same buffer in the same area of character positions, and
2640 the buffer wasn't changed since the time the display string
2641 position was cached.
2642
2643 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2644
2645 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2646 is an integer, which is important for empty lines. (Bug#9149)
2647
2648 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
2649
2650 * frame.c (Fmodify_frame_parameters): In tty case, update the
2651 default face if necessary (Bug#4238).
2652
2653 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
2654
2655 * editfns.c (Fstring_to_char): No need to explain what a character
2656 is in the docstring (Bug#6576).
2657
2658 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2659
2660 * xml.c (parse_region): Make sure we always return a tree.
2661
2662 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2663
2664 * xml.c (parse_region): If a document contains only comments,
2665 return that, too.
2666
2667 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2668
2669 * xml.c (make_dom): Return comments, too.
2670
2671 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2672
2673 Port to OpenBSD.
2674 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2675 and the surrounding thread.
2676 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2677 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2678 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2679 timer goes off.
2680 * s/openbsd.h (BROKEN_SIGIO): Define.
2681 * unexelf.c (unexec) [__OpenBSD__]:
2682 Don't update the .mdebug section of the Alpha COFF symbol table.
2683
2684 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2685
2686 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2687 (bug#8460).
2688
2689 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2690
2691 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2692 This fixes some race conditions on the permissions of any newly
2693 created file.
2694
2695 * alloc.c (valid_pointer_p): Use pipe, not open.
2696 This fixes some permissions issues when debugging.
2697
2698 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2699 If fchown fails to set both uid and gid, try to set just gid,
2700 as that is sometimes allowed. Adjust the file's mode to eliminate
2701 setuid or setgid bits that are inappropriate if fchown fails.
2702
2703 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2704
2705 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2706 to compare Lisp_Objects.
2707 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2708 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2709 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2710
2711 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2712
2713 * lread.c (read_integer): Unread even EOF character.
2714 (read1): Likewise. Properly record start position of symbol.
2715
2716 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2717 symbol character follows.
2718
2719 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2720
2721 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2722 This works around a problem with the previous change to Fcopy_file.
2723 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2724 and without this change, GCC might complain about discarding
2725 fchown's return value.
2726
2727 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
2728
2729 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2730
2731 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2732
2733 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2734
2735 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2736
2737 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2738 it's used from the C level.
2739
2740 * process.c: Use the same condition for POLL_FOR_INPUT in both
2741 keyboard.c and process.c (bug#1858).
2742
2743 2011-07-09 Lawrence Mitchell <wence@gmx.li>
2744
2745 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2746 (Fgnutls_boot): Use it.
2747
2748 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2749
2750 * doc.c (Fsubstitute_command_keys): Revert last change.
2751
2752 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2753
2754 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2755 quotes the next character, and doesn't affect other longer
2756 sequences (bug#8935).
2757
2758 * lread.c (syms_of_lread): Clarify that is isn't only
2759 `eval-buffer' and `eval-defun' that's affected by
2760 `lexical-binding' (bug#8460).
2761
2762 2011-07-15 Eli Zaretskii <eliz@gnu.org>
2763
2764 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2765 bidi redisplay when a line includes both an image and is truncated.
2766
2767 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2768
2769 Fix minor problems found by static checking.
2770 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2771 (elsz): Now a signed constant, not a size_t var. We prefer signed
2772 types to unsigned, to avoid integer comparison confusion. Without
2773 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2774 "cannot optimize loop, the loop counter may overflow", a symptom
2775 of the confusion.
2776 * indent.c (Fvertical_motion): Mark locals as initialized.
2777 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2778
2779 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2780
2781 * search.c (Fre_search_backward): Mention `case-fold-search' in
2782 all the re_search_* functions (bug#8138).
2783
2784 * keyboard.c (Fopen_dribble_file): Document when the file is
2785 closed (bug#8056).
2786
2787 2011-07-14 Eli Zaretskii <eliz@gnu.org>
2788
2789 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2790 bidi_cache_idx.
2791
2792 Support bidi reordering of display and overlay strings.
2793 * xdisp.c (compute_display_string_pos)
2794 (compute_display_string_end): Accept additional argument STRING.
2795 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2796 (reseat_to_string): Initialize bidi_it->string.s and
2797 bidi_it->string.schars.
2798 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
2799 NULL (avoids a crash in bidi_paragraph_init).
2800 Initialize itb.string.lstring.
2801 (init_iterator): Call bidi_init_it only of a valid
2802 buffer position was specified. Initialize paragraph_embedding to
2803 L2R.
2804 (reseat_to_string): Initialize the bidi iterator.
2805 (display_string): If we need to ignore text properties of
2806 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2807 original value of -1 will not work with bidi.)
2808 (compute_display_string_pos): First arg is now struct
2809 `text_pos *'; all callers changed. Support display properties on
2810 Lisp strings.
2811 (compute_display_string_end): Support display properties on Lisp
2812 strings.
2813 (init_iterator, reseat_1, reseat_to_string): Initialize the
2814 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2815 when iterating on a string not from display properties).
2816 (compute_display_string_pos, compute_display_string_end):
2817 Fix calculation of the object to scan. Fixes an error when using
2818 arrow keys.
2819 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
2820 base_level_stop; instead, set base_level_stop to BEGV.
2821 Fixes crashes in vertical-motion.
2822 (next_element_from_buffer): Improve commentary for when
2823 the iterator is before prev_stop.
2824 (init_iterator): Initialize bidi_p from the default value of
2825 bidi-display-reordering, not from buffer-local value. Use the
2826 buffer-local value only if initializing for buffer iteration.
2827 (handle_invisible_prop): Support invisible properties on strings
2828 that are being bidi-reordered.
2829 (set_iterator_to_next): Support bidi reordering of C strings and
2830 Lisp strings.
2831 (next_element_from_string): Support bidi reordering of Lisp
2832 strings.
2833 (handle_stop_backwards): Support Lisp strings as well.
2834 (display_string): Support display of R2L glyph rows.
2835 Use IT_STRING_CHARPOS when displaying from a Lisp string.
2836 (init_iterator): Don't initialize it->bidi_p for strings
2837 here.
2838 (reseat_to_string): Initialize it->bidi_p for strings here.
2839 (next_element_from_string, next_element_from_c_string)
2840 (next_element_from_buffer): Add xassert's for correspondence
2841 between IT's object being iterated and it->bidi_it.string
2842 structure.
2843 (face_before_or_after_it_pos): Support bidi iteration.
2844 (next_element_from_c_string): Handle the case of the first string
2845 character that is not the first one in the visual order.
2846 (get_visually_first_element): New function, refactored from common
2847 parts of next_element_from_buffer, next_element_from_string, and
2848 next_element_from_c_string.
2849 (tool_bar_lines_needed, redisplay_tool_bar)
2850 (display_menu_bar): Force left-to-right direction. Add a FIXME
2851 comment for making that be controlled by a user option.
2852 (push_it, pop_it): Save and restore the state of the
2853 bidi iterator. Save and restore the bidi_p flag.
2854 (pop_it): Iterate out of display property for string iteration as
2855 well.
2856 (iterate_out_of_display_property): Support iteration over strings.
2857 (handle_single_display_spec): Set up it->bidi_it for iteration
2858 over a display string, and call bidi_init_it.
2859 (handle_single_display_spec, next_overlay_string)
2860 (get_overlay_strings_1, push_display_prop): Set up the bidi
2861 iterator for displaying display or overlay strings.
2862 (forward_to_next_line_start): Don't use the shortcut if
2863 bidi-iterating.
2864 (back_to_previous_visible_line_start): If handle_display_prop
2865 pushed the iterator stack, restore the internal state of the bidi
2866 iterator by calling bidi_pop_it same number of times.
2867 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2868 and we are bidi-iterating, don't decrement the iterator position;
2869 instead, set the first_elt flag in the bidi iterator, to produce
2870 the same effect.
2871 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2872 (push_display_prop): xassert that we are iterating a buffer.
2873 (push_it, pop_it): Save and restore paragraph_embedding member.
2874 (handle_single_display_spec, next_overlay_string)
2875 (get_overlay_strings_1, reseat_1, reseat_to_string)
2876 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2877 correctly. Don't assume unibyte strings are not bidi-reordered.
2878 (compute_display_string_pos)
2879 (compute_display_string_end): Fix handling the case of C string.
2880 (push_it, pop_it): Save and restore from_disp_prop_p.
2881 (handle_single_display_spec, push_display_prop): Set the
2882 from_disp_prop_p flag.
2883 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2884 (pop_it): Call iterate_out_of_display_property only if we are
2885 popping after iteration over a string that came from a display
2886 property. Fix a typo in popping stretch info. Add an assertion
2887 for verifying that the iterator position is in sync with the bidi
2888 iterator.
2889 (handle_single_display_spec, get_overlay_strings_1)
2890 (push_display_prop): Fix initialization of paragraph direction for
2891 string when that of the parent object is not yet determined.
2892 (reseat_1): Call bidi_init_it to resync the bidi
2893 iterator with IT's position. (Bug#7616)
2894 (find_row_edges): If ROW->start.pos gives position
2895 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2896 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2897 Reset the from_disp_prop_p flag.
2898 (SAVE_IT, RESTORE_IT): New macros.
2899 (pos_visible_p, face_before_or_after_it_pos)
2900 (back_to_previous_visible_line_start)
2901 (move_it_in_display_line_to, move_it_in_display_line)
2902 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2903 (try_scrolling, redisplay_window, display_line): Use them when
2904 saving a temporary copy of the iterator and restoring it back.
2905 (back_to_previous_visible_line_start, reseat_1)
2906 (init_iterator): Empty the bidi cache "stack".
2907 (move_it_in_display_line_to): If iterator ended up at
2908 EOL, but we never saw any buffer positions smaller than
2909 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2910 motion in bidi-reordered lines.
2911 (move_it_in_display_line_to): Record prev_method and prev_pos
2912 immediately before the call to set_iterator_to_next. Fixes cursor
2913 motion in bidi-reordered lines with stretch glyphs and strings
2914 displayed in margins. (Bug#8133) (Bug#8867)
2915 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2916 TO_CHARPOS.
2917 (pos_visible_p): Support positions in bidi-reordered lines.
2918 Save and restore bidi cache.
2919
2920 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2921 (bidi_paragraph_info): Delete unused struct.
2922 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2923 (bidi_cache_start): New variable.
2924 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2925 to zero.
2926 (bidi_cache_fetch_state, bidi_cache_search)
2927 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2928 (bidi_cache_find, bidi_peek_at_next_level)
2929 (bidi_level_of_next_char, bidi_find_other_level_edge)
2930 (bidi_move_to_visually_next): Compare cache index with
2931 bidi_cache_start rather than with zero.
2932 (bidi_fetch_char): Accept new argument STRING; all callers
2933 changed. Support iteration over a string. Support strings with
2934 display properties. Support unibyte strings. Fix the type of
2935 `len' according to what STRING_CHAR_AND_LENGTH expects.
2936 (bidi_paragraph_init, bidi_resolve_explicit_1)
2937 (bidi_resolve_explicit, bidi_resolve_weak)
2938 (bidi_level_of_next_char, bidi_move_to_visually_next):
2939 Support iteration over a string.
2940 (bidi_set_sor_type, bidi_resolve_explicit_1)
2941 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2942 can now be zero (for strings); special values 0 and -1 were
2943 changed to -1 and -2, respectively.
2944 (bidi_char_at_pos): New function.
2945 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2946 Call it instead of FETCH_MULTIBYTE_CHAR.
2947 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2948 initialized to valid values.
2949 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2950 values.
2951 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2952 the test for valid cached positions. Fix the logic for looking up
2953 the sentinel state in the cache. GCPRO the Lisp string we are
2954 iterating.
2955 (bidi_push_it, bidi_pop_it): New functions.
2956 (bidi_initialize): Initialize the bidi cache start stack pointer.
2957 (bidi_cache_ensure_space): New function, refactored from part of
2958 bidi_cache_iterator_state. Don't assume the required size is just
2959 one BIDI_CACHE_CHUNK away.
2960 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2961 (bidi_count_bytes, bidi_char_at_pos): New functions.
2962 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2963 always valid if bidi_cache_idx is valid.
2964 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2965 is valid if it's going to be used.
2966 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2967 (bidi_cache_fetch_state, bidi_cache_search)
2968 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2969 (bidi_cache_iterator_state, bidi_cache_find)
2970 (bidi_find_other_level_edge, bidi_cache_start_stack):
2971 All variables related to cache indices are now EMACS_INT.
2972
2973 * dispextern.h (struct bidi_string_data): New structure.
2974 (struct bidi_it): New member `string'. Make flag members be 1-bit
2975 fields, and put them last in the struct.
2976 (compute_display_string_pos, compute_display_string_end):
2977 Update prototypes.
2978 (bidi_push_it, bidi_pop_it): Add prototypes.
2979 (struct iterator_stack_entry): New members bidi_p,
2980 paragraph_embedding, and from_disp_prop_p.
2981 (struct it): Member bidi_p is now a bit field 1 bit wide.
2982 (bidi_shelve_cache, bidi_unshelve_cache):
2983 Declare prototypes.
2984
2985 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2986 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2987 and vector-like objects.
2988
2989 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2990 cache around display iteration.
2991
2992 * window.c (Fwindow_end, window_scroll_pixel_based)
2993 (displayed_window_lines, Frecenter): Save and restore the bidi
2994 cache around display iteration.
2995
2996 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2997
2998 * editfns.c (Fdelete_region): Clarify the use of the named
2999 parameters (bug#6788).
3000
3001 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3002
3003 * indent.c (Fvertical_motion): Set and restore w->pointm when
3004 saving and restoring the window's buffer (Bug#9006).
3005
3006 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3007
3008 * editfns.c (Fstring_to_char): Clarify just what is returned
3009 (bug#6576). Text by Eli Zaretskii.
3010
3011 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3012
3013 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3014
3015 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3016
3017 * buffer.c (mmap_find): Fix a typo.
3018
3019 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3020
3021 Fix execution of x selection hooks.
3022 * xselect.c (Qx_lost_selection_functions)
3023 (Qx_sent_selection_functions): New vars.
3024 (syms_of_xselect): DEFSYM them.
3025 (x_handle_selection_request): Pass Qx_sent_selection_functions
3026 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3027 (x_handle_selection_clear,x_clear_frame_selections):
3028 Pass Qx_lost_selection_functions rather than
3029 Vx_lost_selection_functions to Frun_hook_with_args.
3030
3031 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3032
3033 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3034 The old code sometimes used this field without initializing it.
3035
3036 * alloc.c (gc_sweep): Don't read past end of array.
3037 In theory, the old code could also have corrupted Emacs internals,
3038 though it'd be very unlikely.
3039
3040 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3041
3042 * character.c (Fcharacterp): Don't advertise optional ignored
3043 argument. (Bug#4026)
3044
3045 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3046
3047 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3048 key" (bug#4257).
3049
3050 * window.c (Fset_window_start): Doc fix (bug#4199).
3051 (Fset_window_hscroll): Ditto.
3052
3053 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3054
3055 Fix minor new problems caught by GCC 4.6.1.
3056 * term.c (init_tty): Remove unused local.
3057 * xsettings.c (store_monospaced_changed): Define this function only
3058 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3059 not used otherwise.
3060
3061 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3062
3063 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3064
3065 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3066
3067 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3068 are the mini-buffer and the echo area (bug#3320).
3069
3070 * term.c (init_tty): Remove support for supdup, c10 and perq
3071 terminals, which are no longer supported (bug#1482).
3072
3073 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3074
3075 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3076
3077 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3078
3079 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3080 for non-popups (Bug#3642).
3081
3082 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3083
3084 * alloc.c (reset_malloc_hooks): Protoize.
3085 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3086 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3087 * cm.c (losecursor): Likewise.
3088 * data.c (fmod): Likewise.
3089 * dispnew.c (swap_glyphs_in_rows): Likewise.
3090 * emacs.c (memory_warning_signal): Likewise.
3091 * floatfns.c (float_error): Likewise.
3092 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3093 (otf_open, font_otf_capability, generate_otf_features)
3094 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3095 Likewise.
3096 * image.c (pbm_read_file): Likewise.
3097 * indent.c (string_display_width): Likewise.
3098 * intervals.c (check_for_interval, search_for_interval)
3099 (inc_interval_count, count_intervals, root_interval)
3100 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3101 * lread.c (defalias): Likewise.
3102 * ralloc.c (r_alloc_check): Likewise.
3103 * regex.c (set_image_of_range_1, set_image_of_range)
3104 (regex_grow_registers): Likewise.
3105 * sysdep.c (strerror): Likewise.
3106 * termcap.c (valid_filename_p, tprint, main): Likewise.
3107 * tparam.c (main): Likewise.
3108 * unexhp9k800.c (run_time_remap, save_data_space)
3109 (update_file_ptrs, read_header, write_header, calculate_checksum)
3110 (copy_file, copy_rest, display_header): Likewise.
3111 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3112 Likewise.
3113 * xdisp.c (check_it): Likewise.
3114 * xfaces.c (register_color, unregister_color, unregister_colors):
3115 Likewise.
3116 * xfns.c (print_fontset_result): Likewise.
3117 * xrdb.c (member, fatal, main): Likewise.
3118
3119 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3120
3121 Fix minor problems found by static checking (Bug#9031).
3122 * chartab.c (char_table_set_range, map_sub_char_table):
3123 Remove unused locals.
3124 (uniprop_table): Now static.
3125 * composite.c (_work_char): Remove unused static var.
3126
3127 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3128
3129 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3130
3131 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3132
3133 * gtkutil.c (qttip_cb): Remove code without function.
3134
3135 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3136
3137 * w32.c (pthread_sigmask): New stub.
3138
3139 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3140
3141 Use pthread_sigmask, not sigprocmask (Bug#9010).
3142 sigprocmask is portable only for single-threaded applications, and
3143 Emacs can be multi-threaded when it uses GTK.
3144 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3145 (LIBES): Use it.
3146 * callproc.c (Fcall_process):
3147 * process.c (create_process):
3148 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3149 Use pthread_sigmask, not sigprocmask.
3150
3151 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3152
3153 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3154 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3155 wrong (Bug#8591).
3156
3157 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3158
3159 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3160 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3161 (xg_hide_tooltip): Fix comment.
3162
3163 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3164 in registerServicesMenuSendTypes.
3165 (validRequestorForSendType): Don't check ns_return_types.
3166
3167 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3168 ns_return_type.
3169
3170 2011-07-08 Jason Rumney <jasonr@gnu.org>
3171
3172 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3173 SH_SHOW for hidden windows (Bug#5482).
3174
3175 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3176 frame struct members of non-existent frames (Bug#6284).
3177
3178 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3179
3180 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3181 variable firstTime not needed on OSX >= 10.6.
3182 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3183 >= 10.5. Use setKnobProportion, setDoubleValue.
3184
3185 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3186 (MAC_OS_X_VERSION_10_5): Define if not defined.
3187 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3188 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3189 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3190
3191 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3192 cString and lossyCString on OSX >= 10.4
3193
3194 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3195 sizeToFit on OSX >= 10.2.
3196
3197 * nsimage.m (allocInitFromFile): Don't use deprecated method
3198 bestRepresentationForDevice on OSX >= 10.6.
3199
3200 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3201 to avoid warning.
3202
3203 * emacs.c: Declare unexec_init_emacs_zone.
3204
3205 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3206
3207 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3208
3209 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3210 on svcsMenu (Bug#8842).
3211
3212 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3213 ns_return_types.
3214 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3215
3216 * nsterm.m (QUTF8_STRING): Declare.
3217 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3218 (validRequestorForSendType): Return type is (id).
3219 Change indexOfObjectIdenticalTo to indexOfObject.
3220 Check if we have local selection before returning self (Bug#8842).
3221 (writeSelectionToPasteboard): Put local selection into paste board
3222 if we have a local selection (Bug#8842).
3223 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3224
3225 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3226 (ns_get_local_selection): Declare.
3227
3228 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3229
3230 * keymap.c (describe_map_tree): Don't insert a double newline at
3231 the end of the buffer (bug#1169) and return whether we inserted
3232 something.
3233
3234 * callint.c (Fcall_interactively): Change "reading args" to
3235 "providing args" to try to clarify what it does (bug#1010).
3236
3237 2011-07-07 Kenichi Handa <handa@m17n.org>
3238
3239 * composite.c (composition_compute_stop_pos): Ignore a static
3240 composition starting before CHARPOS (Bug#8915).
3241
3242 * xdisp.c (handle_composition_prop): Likewise.
3243
3244 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3245
3246 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3247 (Bug#9015)
3248
3249 2011-07-07 Kenichi Handa <handa@m17n.org>
3250
3251 * character.h (unicode_category_t): New enum type.
3252
3253 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3254 (Qchar_code_property_table): New variable.
3255 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3256 (UNIPROP_COMPRESSED_FORM_P): New macros.
3257 (char_table_ascii): Uncompress the compressed values.
3258 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3259 Uncompress the compressed values.
3260 (sub_char_table_ref_and_range): Likewise.
3261 (char_table_ref_and_range): Uncompress the compressed values.
3262 (sub_char_table_set): New arg is_uniprop. Callers changed.
3263 Uncompress the compressed values.
3264 (sub_char_table_set_range): Args changed. Callers changed.
3265 (char_table_set_range): Adjuted for the above change.
3266 (map_sub_char_table): Delete args default_val and parent. Add arg
3267 top. Give decoded values to a Lisp function.
3268 (map_char_table): Adjust for the above change. Give decoded
3269 values to a Lisp function. Gcpro more variables.
3270 (uniprop_table_uncompress)
3271 (uniprop_decode_value_run_length): New functions.
3272 (uniprop_decoder, uniprop_decoder_count): New variables.
3273 (uniprop_get_decoder, uniprop_encode_value_character)
3274 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3275 New functions.
3276 (uniprop_encoder, uniprop_encoder_count): New variables.
3277 (uniprop_get_encoder, uniprop_table)
3278 (Funicode_property_table_internal, Fget_unicode_property_internal)
3279 (Fput_unicode_property_internal): New functions.
3280 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3281 Sunicode_property_table_internal, Sget_unicode_property_internal,
3282 and Sput_unicode_property_internal. Defvar_lisp
3283 char-code-property-alist.
3284
3285 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
3286 Vunicode_category_table.
3287
3288 * font.c (font_range): Adjust for the change of
3289 Vunicode_category_table.
3290
3291 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3292
3293 * m/iris4d.h: Remove file, move contents ...
3294 * s/irix6-5.h: ... here.
3295
3296 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3297
3298 Remove unportable assumption about struct layout (Bug#8884).
3299 * alloc.c (mark_buffer):
3300 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3301 (clone_per_buffer_values): Don't assume that
3302 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3303 This isn't true in general, and it's particularly not true
3304 if Emacs is configured with --with-wide-int.
3305 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3306 New macros, used in the buffer.c change.
3307
3308 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3309
3310 * xsettings.c: Use both GConf and GSettings if both are available.
3311 (store_config_changed_event): Add comment.
3312 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3313 (store_tool_bar_style_changed): New functions.
3314 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
3315 (struct xsettings): Move font inside HAVE_XFT.
3316 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
3317 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
3318 Move inside HAVE_XFT.
3319 (something_changed_gsettingsCB): Rename from something_changedCB.
3320 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3321 also.
3322 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
3323 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
3324 (something_changed_gconfCB): Rename from something_changedCB.
3325 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3326 (parse_settings): Move check for font inside HAVE_XFT.
3327 (read_settings, apply_xft_settings): Add comment.
3328 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3329 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3330 call store_font_name_changed.
3331 (xft_settings_event): Add comment.
3332 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3333 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3334 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3335 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3336 (xsettings_initialize): Call init_gsettings last.
3337 (xsettings_get_system_font, xsettings_get_system_normal_font):
3338 Add comment.
3339
3340 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3341
3342 Random fixes. E.g., (random) never returned negative values.
3343 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3344 subseconds part to the entropy, as that's a bit more random.
3345 Prefer signed to unsigned, since the signedness doesn't matter and
3346 in general we prefer signed. When given a limit, use a
3347 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3348 latter isn't right if USE_2_TAGS_FOR_INTS.
3349 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3350 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3351
3352 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3353
3354 * textprop.c (text_property_stickiness):
3355 Obey Vtext_property_default_nonsticky.
3356 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3357 * w32fns.c (syms_of_w32fns):
3358 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3359
3360 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3361
3362 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3363 This is more efficient than Ffile_directory_p and avoids a minor race.
3364
3365 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3366
3367 * buffer.c (Foverlay_put): Say what the return value is
3368 (bug#7835).
3369
3370 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3371 is a directory before asking whether to use the file name
3372 (bug#7564).
3373 (barf_or_query_if_file_exists): Make the "File is a directory"
3374 error be more correct.
3375
3376 * fns.c (Frequire): Remove the mention of the .gz files, since
3377 that's installation-specific, but keep the mention of
3378 `get-load-suffixes'.
3379
3380 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3381
3382 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3383 Report string overflow if the output is too long.
3384
3385 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
3386
3387 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3388 (syms_of_gnutls): Remove duplicate DEFSYM for
3389 Qgnutls_bootprop_verify_hostname_error, an error for
3390 Qgnutls_bootprop_verify_error (which is no longer used).
3391
3392 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3393 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3394 Also (re)move comments that are misplaced or no longer relevant.
3395
3396 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3397
3398 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3399
3400 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
3401
3402 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3403 and background color parameters if they have been changed.
3404
3405 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3406
3407 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3408
3409 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3410
3411 * xsettings.c (SYSTEM_FONT): Define only when used.
3412 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3413
3414 * keymap.c (access_keymap_1): Now static.
3415
3416 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
3417
3418 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3419 leave any prefix arg for the up event (Bug#1586).
3420
3421 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3422
3423 * lread.c (syms_of_lread): Mention single symbols defined by
3424 `defvar' or `defconst' (bug#7154).
3425
3426 * fns.c (Frequire): Mention .el.gz files (bug#7314).
3427 (Frequire): Mention get-load-suffixes.
3428
3429 2011-07-02 Martin Rudalics <rudalics@gmx.at>
3430
3431 * window.h (window): Remove clone_number slot.
3432 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3433 Remove.
3434 (make_parent_window, make_window, saved_window)
3435 (Fset_window_configuration, save_window_save): Don't deal with
3436 clone numbers.
3437 * buffer.c (Qclone_number): Remove declaration.
3438 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3439
3440 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3441
3442 Add multiple inheritance to keymaps.
3443 * keymap.c (Fmake_composed_keymap): New function.
3444 (Fset_keymap_parent): Simplify.
3445 (fix_submap_inheritance): Remove.
3446 (access_keymap_1): New function extracted from access_keymap to handle
3447 embedded parents and handle lists of maps.
3448 (access_keymap): Use it.
3449 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3450 (Fcopy_keymap): Handle embedded parents.
3451 (Fcommand_remapping, define_as_prefix): Simplify.
3452 (Fkey_binding): Simplify.
3453 (syms_of_keymap): Move minibuffer-local-completion-map,
3454 minibuffer-local-filename-completion-map,
3455 minibuffer-local-must-match-map, and
3456 minibuffer-local-filename-must-match-map to Elisp.
3457 (syms_of_keymap): Defsubr make-composed-keymap.
3458 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3459 (parse_menu_item): Trivial simplification.
3460
3461 2011-07-01 Glenn Morris <rgm@gnu.org>
3462
3463 * Makefile.in (SETTINGS_LIBS): Fix typo.
3464
3465 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3466
3467 * coding.c (Fencode_coding_string): Record the last coding system
3468 used, as the function doc string says (bug#8738).
3469
3470 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3471
3472 * xsettings.c (store_monospaced_changed): Take new font as arg and
3473 check for change against current_mono_font.
3474 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3475 (emacs_settings_constructor, emacs_settings_get_property)
3476 (emacs_settings_set_property, emacs_settings_class_init)
3477 (emacs_settings_init, gsettings_obj): Remove.
3478 (something_changedCB): New function for HAVE_GSETTINGS.
3479 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3480 with value as argument.
3481 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3482 g_settings_new (Bug#8967). Do not create gsettings_obj.
3483 Remove calls to g_settings_bind. Connect something_changedCB to
3484 "changed".
3485
3486 * xgselect.c: Add defined (HAVE_GSETTINGS).
3487 (xgselect_initialize): Ditto.
3488
3489 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3490 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3491 xg_select.
3492
3493 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3494
3495 * eval.c (struct backtrace): Simplify and port the data structure.
3496 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3497 signed bit field, as this assumption is not portable and it makes
3498 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3499 "char debug_on_exit : 1" as this is not portable either; instead,
3500 use the portable "unsigned int debug_on_exit : 1". Remove unused
3501 member evalargs. Remove obsolete comments about cc bombing out.
3502
3503 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3504
3505 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
3506 Let HAVE_GSETTINGS override HAVE_GCONF.
3507 (store_monospaced_changed): New function.
3508 (EMACS_SETTINGS): A new type derived from GObject to handle
3509 GSettings notifications.
3510 (emacs_settings_constructor, emacs_settings_get_property)
3511 (emacs_settings_set_property, emacs_settings_class_init):
3512 New functions.
3513 (gsettings_client, gsettings_obj): New variables.
3514 (GSETTINGS_SCHEMA): New define.
3515 (something_changedCB): Call store_monospaced_changed.
3516 (init_gsettings): New function.
3517 (xsettings_initialize): Call init_gsettings.
3518 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3519 to NULL.
3520
3521 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
3522 GCONF_CFLAGS/LIBS.
3523
3524 2011-06-29 Martin Rudalics <rudalics@gmx.at>
3525
3526 * window.c (resize_root_window, grow_mini_window)
3527 (shrink_mini_window): Rename Qresize_root_window to
3528 Qwindow_resize_root_window and Qresize_root_window_vertically to
3529 Qwindow_resize_root_window_vertically.
3530
3531 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3532
3533 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3534
3535 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
3536
3537 * makefile.w32-in: Redesign dependencies so they reflect more
3538 clearly which files are directly included by each source file,
3539 and not through other includes.
3540
3541 2011-06-27 Martin Rudalics <rudalics@gmx.at>
3542
3543 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3544 (sort_overlays, overlay_strings): When an overlay's clone number
3545 matches the window's clone number process the overlay even if
3546 the overlay's window property doesn't match the current window.
3547
3548 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3549 (Fwindow_hchild): Rename to Fwindow_left_child.
3550 (Fwindow_next): Rename to Fwindow_next_sibling.
3551 (Fwindow_prev): Rename to Fwindow_prev_sibling.
3552 (resize_window_check): Rename to window_resize_check.
3553 (resize_window_apply): Rename to window_resize_apply.
3554 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3555 (Fdelete_other_windows_internal, resize_frame_windows)
3556 (Fsplit_window_internal, Fdelete_window_internal)
3557 (grow_mini_window, shrink_mini_window)
3558 (Fresize_mini_window_internal): Fix callers accordingly.
3559
3560 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3561
3562 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3563 (emacs_fixed_set_min_size): Remove.
3564 (emacs_fixed_new): Take frame as argument.
3565
3566 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3567 (_EmacsFixedPrivate): Remove minwidth/height.
3568 Add struct frame *f.
3569 (emacs_fixed_init): Initialize priv->f.
3570 (get_parent_class, emacs_fixed_set_min_size): Remove.
3571 (emacs_fixed_new): Set priv->f to argument.
3572 (emacs_fixed_get_preferred_width)
3573 (emacs_fixed_get_preferred_height): Use min_width/height from
3574 frames size_hint to set minimum and natural (Bug#8919).
3575 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3576 and use min_width/height from frames size_hint to set
3577 min_width/height (Bug#8919).
3578
3579 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
3580 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3581 Fix indentation.
3582
3583 2011-06-26 Eli Zaretskii <eliz@gnu.org>
3584
3585 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3586 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3587 called at ZV.
3588
3589 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
3590
3591 * process.c (wait_reading_process_output): Bypass select if
3592 waiting for a cell while ignoring keyboard input, and input is
3593 pending. Suggested by Jan Djärv (Bug#8869).
3594
3595 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3596
3597 Use gnulib's dup2 module instead of rolling our own.
3598 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3599
3600 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3601
3602 * dispnew.c (scrolling_window): Before scrolling, turn off a
3603 mouse-highlight in the window being scrolled.
3604
3605 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
3606
3607 Move DEFSYM to lisp.h and use everywhere.
3608
3609 * character.h (DEFSYM): Move declaration...
3610 * lisp.h (DEFSYM): ...here.
3611
3612 * gnutls.c:
3613 * minibuf.c:
3614 * w32menu.c:
3615 * w32proc.c:
3616 * w32select.c: Don't include character.h.
3617
3618 * alloc.c (syms_of_alloc):
3619 * buffer.c (syms_of_buffer):
3620 * bytecode.c (syms_of_bytecode):
3621 * callint.c (syms_of_callint):
3622 * casefiddle.c (syms_of_casefiddle):
3623 * casetab.c (init_casetab_once):
3624 * category.c (init_category_once, syms_of_category):
3625 * ccl.c (syms_of_ccl):
3626 * cmds.c (syms_of_cmds):
3627 * composite.c (syms_of_composite):
3628 * dbusbind.c (syms_of_dbusbind):
3629 * dired.c (syms_of_dired):
3630 * dispnew.c (syms_of_display):
3631 * doc.c (syms_of_doc):
3632 * editfns.c (syms_of_editfns):
3633 * emacs.c (syms_of_emacs):
3634 * eval.c (syms_of_eval):
3635 * fileio.c (syms_of_fileio):
3636 * fns.c (syms_of_fns):
3637 * frame.c (syms_of_frame):
3638 * fringe.c (syms_of_fringe):
3639 * insdel.c (syms_of_insdel):
3640 * keymap.c (syms_of_keymap):
3641 * lread.c (init_obarray, syms_of_lread):
3642 * macros.c (syms_of_macros):
3643 * msdos.c (syms_of_msdos):
3644 * print.c (syms_of_print):
3645 * process.c (syms_of_process):
3646 * search.c (syms_of_search):
3647 * sound.c (syms_of_sound):
3648 * syntax.c (init_syntax_once, syms_of_syntax):
3649 * terminal.c (syms_of_terminal):
3650 * textprop.c (syms_of_textprop):
3651 * undo.c (syms_of_undo):
3652 * w32.c (globals_of_w32):
3653 * window.c (syms_of_window):
3654 * xdisp.c (syms_of_xdisp):
3655 * xfaces.c (syms_of_xfaces):
3656 * xfns.c (syms_of_xfns):
3657 * xmenu.c (syms_of_xmenu):
3658 * xsettings.c (syms_of_xsettings):
3659 * xterm.c (syms_of_xterm): Use DEFSYM.
3660
3661 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3662
3663 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
3664
3665 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3666
3667 Integer and buffer overflow fixes (Bug#8873).
3668
3669 * print.c (printchar, strout): Check for string overflow.
3670 (PRINTPREPARE, printchar, strout):
3671 Don't set size unless allocation succeeds.
3672
3673 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3674 for sizes. Check for string overflow more accurately.
3675 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3676
3677 * macros.c: Integer and buffer overflow fixes.
3678 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3679 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3680 Use ptrdiff_t, not int, for sizes.
3681 Don't increment bufsize until after realloc succeeds.
3682 Check for size-calculation overflow.
3683 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3684
3685 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3686
3687 * lread.c: Integer overflow fixes.
3688 (read_integer): Radix is now EMACS_INT, not int,
3689 to improve quality of diagnostics for out-of-range radices.
3690 Calculate buffer size correctly for out-of-range radices.
3691 (read1): Check for integer overflow in radices, and in
3692 read-circle numbers.
3693 (read_escape): Avoid int overflow.
3694 (Fload, openp, read_buffer_size, read1)
3695 (substitute_object_recurse, read_vector, read_list, map_obarray):
3696 Use ptrdiff_t, not int, for sizes.
3697 (read1): Use EMACS_INT, not int, for sizes.
3698 Check for size overflow.
3699
3700 * image.c (cache_image): Check for size arithmetic overflow.
3701
3702 * lread.c: Integer overflow issues.
3703 (saved_doc_string_size, saved_doc_string_length)
3704 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3705 Now ptrdiff_t, not int.
3706 (read1): Don't assume doc string length fits in int. Check for
3707 out-of-range doc string lengths.
3708 (read_list): Don't assume file position fits in int.
3709 (read_escape): Check for hex character overflow.
3710
3711 2011-06-22 Leo Liu <sdl.web@gmail.com>
3712
3713 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3714 Move to minibuffer.el.
3715
3716 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3717
3718 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
3719 The following patches are for when GLYPH_DEBUG && !XASSERT.
3720 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3721 * dispnew.c (flush_stdout):
3722 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3723 Mark as externally visible.
3724 * dispnew.c (check_window_matrix_pointers): Now static.
3725 * dispnew.c (window_to_frame_vpos):
3726 * xfns.c (unwind_create_frame):
3727 * xterm.c (x_check_font): Remove unused local.
3728 * scroll.c (CHECK_BOUNDS):
3729 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3730 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3731 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3732 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3733 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3734 Now static.
3735 (debug_method_add): Use va_list and vsprintf rather than relying
3736 on undefined behavior with wrong number of arguments.
3737 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3738 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3739 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3740 since we're not interested in debugging glyphs with old libraries.
3741 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3742 GCC 4.6.0's static checking.
3743
3744 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3745
3746 Integer overflow and signedness fixes (Bug#8873).
3747 A few related buffer overrun fixes, too.
3748
3749 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3750
3751 * dispextern.h (struct face.stipple):
3752 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3753 (x_bitmap_mask, x_allocate_bitmap_record)
3754 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3755 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3756 (x_create_bitmap_from_xpm_data):
3757 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3758 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3759 (.bitmaps_last):
3760 * xfaces.c (load_pixmap):
3761 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3762 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3763 (.bitmaps_last, struct x_output.icon_bitmap):
3764 Use ptrdiff_t, not int, for bitmap indexes.
3765 (x_allocate_bitmap_record): Check for size overflow.
3766 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3767
3768 Use ptrdiff_t, not int, for overlay counts.
3769 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3770 * editfns.c (overlays_around, get_pos_property):
3771 * textprop.c (get_char_property_and_overlay):
3772 * xdisp.c (next_overlay_change, note_mouse_highlight):
3773 * xfaces.c (face_at_buffer_position):
3774 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3775 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3776 (Fnext_overlay_change, Fprevious_overlay_change)
3777 (mouse_face_overlay_overlaps, Foverlays_in):
3778 Use ptrdiff_t, not int, for sizes.
3779 (overlays_at, overlays_in): Check for size-calculation overflow.
3780
3781 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3782
3783 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3784 (x_session_initialize): Do not assume string length fits in int.
3785
3786 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3787 This is unlikely, but can occur if DPI is outlandish.
3788
3789 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3790 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3791
3792 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3793 * xrdb.c (magic_file_p, search_magic_path):
3794 Omit last arg SUFFIX; it was always 0. All callers changed.
3795 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3796
3797 * xfont.c (xfont_match): Avoid need for strlen.
3798
3799 * xfns.c: Don't assume strlen fits in int.
3800 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3801
3802 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3803 not unsigned long, as we prefer signed integers. All callers changed.
3804 Detect integer overflow in repeat count.
3805 (message_dolog): Don't assume print length fits in 39 bytes.
3806 (display_mode_element): Don't assume strlen fits in int.
3807
3808 * termcap.c: Don't assume sizes fit in int and never overflow.
3809 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3810 (gobble_line): Check for size-calculation overflow.
3811
3812 * minibuf.c (Fread_buffer):
3813 * lread.c (intern, intern_c_string):
3814 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3815 Don't assume string length fits in int.
3816
3817 * keyboard.c (parse_tool_bar_item):
3818 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3819
3820 * font.c: Don't assume string length fits in int.
3821 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3822 Use ptrdiff_t, not int.
3823 (font_intern_prop): Don't assume string length fits in int.
3824 Don't assume integer property fits in fixnum.
3825 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
3826
3827 * filelock.c: Fix some buffer overrun and integer overflow issues.
3828 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
3829 Reformulate so as not to need the command string.
3830 Invoke gzip -cd rather than gunzip, as it's more portable.
3831 (lock_info_type, lock_file_1, lock_file):
3832 Don't assume pid_t and time_t fit in unsigned long.
3833 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3834 (current_lock_owner): Prefer signed type for sizes.
3835 Use memcpy, not strncpy, where memcpy is what is really wanted.
3836 Don't assume (via atoi) that time_t and pid_t fit in int.
3837 Check for time_t and/or pid_t out of range, e.g., via a network share.
3838 Don't alloca where an auto var works fine.
3839
3840 * fileio.c: Fix some integer overflow issues.
3841 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3842 Don't assume string length fits in int.
3843 (directory_file_name): Don't assume string length fits in long.
3844 (make_temp_name): Don't assume pid fits in int, or that its print
3845 length is less than 20.
3846
3847 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3848
3849 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3850
3851 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3852
3853 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3854 We prefer signed integers, even for size calculations.
3855
3856 * emacs.c: Don't assume string length fits in 'int'.
3857 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3858 (main): Don't invoke strlen when not needed.
3859
3860 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3861 (XD_DEBUG_MESSAGE): Don't waste a byte.
3862
3863 * callproc.c (getenv_internal_1, getenv_internal)
3864 (Fgetenv_internal):
3865 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3866
3867 * lread.c (invalid_syntax): Omit length argument.
3868 All uses changed. This doesn't fix a bug, but it simplifies the
3869 code away from its former Hollerith-constant appearance, and it's
3870 one less 'int' to worry about when looking at integer-overflow issues.
3871 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
3872
3873 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3874 This didn't break anything, but it didn't help either.
3875 It's confusing to put a bogus integer in a place where the actual
3876 value does not matter.
3877 (LIST_END_P): Remove unused macro and its bogus comment.
3878 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
3879
3880 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3881 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3882 implementation.
3883 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3884 We prefer signed types, and the value cannot exceed the EMACS_INT
3885 range anyway (because otherwise the length would not be representable).
3886 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3887 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3888 This avoids a GCC warning when WIDE_EMACS_INT.
3889
3890 * indent.c (sane_tab_width): New function.
3891 (current_column, scan_for_column, Findent_to, position_indentation)
3892 (compute_motion): Use it. This is just for clarity.
3893 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
3894
3895 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
3896
3897 * lisp.h (lint_assume): New macro.
3898 * composite.c (composition_gstring_put_cache):
3899 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3900
3901 * editfns.c, insdel.c:
3902 Omit unnecessary forward decls, to simplify future changes.
3903
3904 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3905
3906 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3907
3908 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
3909 Use much-faster test for byte-length change.
3910 Don't assume string byte-length fits in 'int'.
3911 Check that character arg fits in 'int'.
3912 (mapcar1): Declare byte as byte, for clarity.
3913
3914 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3915
3916 * fns.c (concat): Catch string overflow earlier.
3917 Do not rely on integer wraparound.
3918
3919 * dispextern.h (struct it.overlay_strings_charpos)
3920 (struct it.selective): Now EMACS_INT, not int.
3921 * xdisp.c (forward_to_next_line_start)
3922 (back_to_previous_visible_line_start)
3923 (reseat_at_next_visible_line_start, next_element_from_buffer):
3924 Don't arbitrarily truncate the value of 'selective' to int.
3925
3926 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3927
3928 * composite.c: Don't truncate sizes to 'int'.
3929 (composition_gstring_p, composition_reseat_it)
3930 (composition_adjust_point): Use EMACS_INT, not int.
3931 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3932 not EMACS_UINT, for indexes.
3933
3934 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3935
3936 * buffer.c: Include <verify.h>.
3937 (struct sortvec.priority, struct sortstr.priority):
3938 Now EMACS_INT, not int.
3939 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
3940 (struct sortstr.size, record_overlay_string)
3941 (struct sortstrlist.size, struct sortlist.used):
3942 Don't truncate size to int.
3943 (record_overlay_string): Check for size-calculation overflow.
3944 (init_buffer_once): Check at compile-time, not run-time.
3945
3946 2011-06-22 Jim Meyering <meyering@redhat.com>
3947
3948 Don't leak an XBM-image-sized buffer
3949 * image.c (xbm_load): Free the image buffer after using it.
3950
3951 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3952
3953 Port to Sun C.
3954 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3955 that Sun C diagnosed.
3956 * fns.c (secure_hash): Fix pointer signedness issue.
3957 * intervals.c (static_offset_intervals): New function.
3958 (offset_intervals): Use it.
3959
3960 2011-06-21 Leo Liu <sdl.web@gmail.com>
3961
3962 * deps.mk (fns.o):
3963 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3964 sha512.h.
3965
3966 * fns.c (secure_hash): Rename from crypto_hash_function and change
3967 the first arg to accept symbols.
3968 (Fsecure_hash): New primitive.
3969 (syms_of_fns): New symbols.
3970
3971 2011-06-20 Deniz Dogan <deniz@dogan.se>
3972
3973 * process.c (Fset_process_buffer): Clarify return value in
3974 docstring.
3975
3976 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
3977
3978 * dispnew.c (add_window_display_history): Use BVAR.
3979
3980 * xdisp.c (debug_method_add): Use BVAR.
3981 (check_window_end, dump_glyph_matrix, dump_glyph)
3982 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3983
3984 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3985 Likewise.
3986
3987 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3988 check till after the cache is created in init_frame_faces.
3989
3990 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3991
3992 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3993
3994 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3995
3996 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3997 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3998 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3999
4000 Improve buffer-overflow checking (Bug#8873).
4001 * fileio.c (Finsert_file_contents):
4002 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4003 Remove the old (too-loose) buffer overflow checks.
4004 They weren't needed, since make_gap checks for buffer overflow.
4005 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4006 The old code merely checked for Emacs fixnum overflow, and relied
4007 on undefined (wraparound) behavior. The new code avoids undefined
4008 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4009
4010 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4011 Tune. Don't use wider integers than needed. Don't use alloca.
4012 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4013
4014 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4015
4016 * insdel.c, lisp.h (buffer_overflow): New function.
4017 (insert_from_buffer_1, replace_range, replace_range_2):
4018 * insdel.c (make_gap_larger):
4019 * editfns.c (Finsert_char):
4020 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4021
4022 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4023
4024 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4025
4026 Integer overflow and signedness fixes (Bug#8873).
4027
4028 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4029 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4030
4031 * fileio.c: Don't assume EMACS_INT fits in off_t.
4032 (emacs_lseek): New static function.
4033 (Finsert_file_contents, Fwrite_region): Use it.
4034 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4035
4036 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4037
4038 * fns.c: Don't overflow int when computing a list length.
4039 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4040 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4041 truncation on 64-bit hosts. Check for QUIT every
4042 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4043 faster and is responsive enough.
4044 (Flength): Report an error instead of overflowing an integer.
4045 (Fsafe_length): Return a float if the value is not representable
4046 as a fixnum. This shouldn't happen except in contrived situations.
4047 (Fnthcdr, Fsort): Don't assume list length fits in int.
4048 (Fcopy_sequence): Don't assume vector length fits in int.
4049
4050 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4051 (header_size, word_size): New constants.
4052 (allocate_vectorlike): Don't check size overflow here.
4053 (allocate_vector): Check it here instead, since this is the only
4054 caller of allocate_vectorlike that could cause overflow.
4055 Check that the new vector's length is representable as a fixnum.
4056
4057 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4058 The previous code was bogus. For example, next_almost_prime (32)
4059 returned 39, which is undesirable as it is a multiple of 3; and
4060 next_almost_prime (24) returned 25, which is a multiple of 5 so
4061 why was the code bothering to check for multiples of 7?
4062
4063 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4064
4065 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4066
4067 Variadic C functions now count arguments with ptrdiff_t.
4068 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4069 Back then I didn't know that the Emacs coding style prefers signed int.
4070 Also, in the meantime I found a few more instances where arguments
4071 were being counted with int, which may truncate counts on 64-bit
4072 machines, or EMACS_INT, which may be unnecessarily wide.
4073 * lisp.h (struct Lisp_Subr.function.aMANY)
4074 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4075 Arg counts are now ptrdiff_t, not size_t.
4076 All variadic functions and their callers changed accordingly.
4077 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4078 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4079 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4080 * callint.c (Fcall_interactively): Check arg count for overflow,
4081 to avoid potential buffer overrun. Use signed char, not 'int',
4082 for 'varies' array, so that we needn't bother to check its size
4083 calculation for overflow.
4084 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4085 * eval.c (apply_lambda):
4086 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4087 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4088 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4089
4090 * callint.c (Fcall_interactively): Don't use index var as event count.
4091
4092 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4093 * mem-limits.h (SIZE): Remove; no longer used.
4094
4095 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4096
4097 Remove unnecessary casts.
4098 * xterm.c (x_term_init):
4099 * xfns.c (x_set_border_pixel):
4100 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4101 These aren't needed now that we assume ANSI C.
4102
4103 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4104 It's more likely to cause problems (due to unsigned overflow)
4105 than to cure them.
4106
4107 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4108
4109 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4110
4111 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4112
4113 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4114
4115 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4116
4117 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4118
4119 GLYPH_CODE_FACE returns EMACS_INT, not int.
4120 * dispextern.h (merge_faces):
4121 * xfaces.c (merge_faces):
4122 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4123 Don't assume EMACS_INT fits in int.
4124
4125 * character.h (CHAR_VALID_P): Remove unused parameter.
4126 * fontset.c, lisp.h, xdisp.c: All uses changed.
4127
4128 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4129
4130 * fns.c (concat): Minor tuning based on overflow analysis.
4131 This doesn't fix any bugs. Use int to hold character, instead
4132 of constantly refetching from Emacs object. Use XFASTINT, not
4133 XINT, for value known to be a character. Don't bother comparing
4134 a single byte to 0400, as it's always less.
4135
4136 * floatfns.c (Fexpt):
4137 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4138
4139 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4140 for characters.
4141
4142 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4143
4144 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4145 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4146 incorrectly succeed when S was a string, because 4294967386 was
4147 truncated before it was used.
4148
4149 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4150 Otherwise, an out-of-range integer could cause undefined behavior
4151 on a 64-bit host.
4152
4153 * composite.c: Use int, not EMACS_INT, for characters.
4154 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4155 EMACS_INT, for values that are known to be in character range.
4156 This doesn't fix any bugs but is the usual style inside Emacs and
4157 may generate better code on 32-bit machines.
4158
4159 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4160 This is for reasons similar to the recent CHAR_STRING fix.
4161 * charset.c (Fencode_char): Check that character arg is actually
4162 a character. Pass an int to ENCODE_CHAR.
4163 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4164 wider than 'int', as a compile-time check to prevent future regressions
4165 in this area.
4166
4167 * character.c (char_string): Remove unnecessary casts.
4168
4169 Make sure a 64-bit char is never passed to CHAR_STRING.
4170 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4171 by silently ignoring the top 32 bits, allowing some values
4172 that were far too large to be valid characters.
4173 * character.h: Include <verify.h>.
4174 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4175 arguments are no wider than unsigned, as a compile-time check
4176 to prevent future regressions in this area.
4177 * data.c (Faset):
4178 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4179 (Fsubst_char_in_region):
4180 * fns.c (concat):
4181 * xdisp.c (decode_mode_spec_coding):
4182 Adjust to CHAR_STRING's new requirement.
4183 * editfns.c (Finsert_char, Fsubst_char_in_region):
4184 * fns.c (concat): Check that character args are actually
4185 characters. Without this test, these functions did the wrong
4186 thing with wildly out-of-range values on 64-bit hosts.
4187
4188 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4189 These casts should not be needed on 32-bit hosts, either.
4190 * keyboard.c (read_char):
4191 * lread.c (Fload): Remove casts to unsigned.
4192
4193 * lisp.h (UNSIGNED_CMP): New macro.
4194 This fixes comparison bugs on 64-bit hosts.
4195 (ASCII_CHAR_P): Use it.
4196 * casefiddle.c (casify_object):
4197 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4198 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4199 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4200 * dispextern.h (FACE_FROM_ID):
4201 * keyboard.c (read_char): Use UNSIGNED_CMP.
4202
4203 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4204 not to EMACS_INT, to avoid GCC warning.
4205
4206 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4207
4208 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4209 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4210 isn't needed on 32-bit machines.
4211
4212 * buffer.c (Fgenerate_new_buffer_name):
4213 Use EMACS_INT for count, not int.
4214 (advance_to_char_boundary): Return EMACS_INT, not int.
4215
4216 * data.c (Qcompiled_function): Now static.
4217
4218 * window.c (window_body_lines): Now static.
4219
4220 * image.c (gif_load): Rename local to avoid shadowing.
4221
4222 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4223 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4224 * alloc.c (make_save_value): Integer argument is now of type
4225 ptrdiff_t, not int.
4226 (mark_object): Use ptrdiff_t, not int.
4227 * lisp.h (pD): New macro.
4228 * print.c (print_object): Use it.
4229
4230 * alloc.c: Use EMACS_INT, not int, to count objects.
4231 (total_conses, total_markers, total_symbols, total_vector_size)
4232 (total_free_conses, total_free_markers, total_free_symbols)
4233 (total_free_floats, total_floats, total_free_intervals)
4234 (total_intervals, total_strings, total_free_strings):
4235 Now EMACS_INT, not int. All uses changed.
4236 (Fgarbage_collect): Compute overall total using a double, so that
4237 integer overflow is less likely to be a problem. Check for overflow
4238 when converting back to an integer.
4239 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4240 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4241 These were 'int' variables that could overflow on 64-bit hosts;
4242 they were never used, so remove them instead of repairing them.
4243 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4244 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4245 Previously, this ceilinged at INT_MAX, but that doesn't work on
4246 64-bit machines.
4247 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4248
4249 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4250 (allocate_vectorlike): Check for ptrdiff_t overflow.
4251 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4252 when a (possibly-narrower) signed value would do just as well.
4253 We prefer using signed arithmetic, to avoid comparison confusion.
4254
4255 * alloc.c: Catch some string size overflows that we were missing.
4256 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4257 for convenience in STRING_BYTES_MAX.
4258 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4259 The definition here is exact; the one in lisp.h was approximate.
4260 (allocate_string_data): Check for string overflow. This catches
4261 some instances we weren't catching before. Also, it catches
4262 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4263 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4264 and ptrdiff_t and EMACS_INT are both 64 bits.
4265
4266 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4267 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
4268 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
4269
4270 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4271
4272 * alloc.c (Fmake_string): Check for out-of-range init.
4273
4274 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4275
4276 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4277
4278 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4279
4280 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4281 xg_get_default_scrollbar_width.
4282
4283 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4284 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4285 (style_changed_cb): Call update_theme_scrollbar_width and call
4286 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4287 all frames (Bug#8505).
4288 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4289 Call gtk_window_set_resizable if HAVE_GTK3.
4290 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4291 and height if HAVE_GTK3 (Bug#8505).
4292 (scroll_bar_width_for_theme): New variable.
4293 (update_theme_scrollbar_width): New function.
4294 (xg_get_default_scrollbar_width): Move code to
4295 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4296 (xg_initialize): Call update_theme_scrollbar_width.
4297
4298 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4299
4300 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4301
4302 2011-06-12 Martin Rudalics <rudalics@gmx.at>
4303
4304 * frame.c (make_frame): Call other_buffer_safely instead of
4305 other_buffer.
4306
4307 * window.c (temp_output_buffer_show): Call display_buffer with
4308 second argument Vtemp_buffer_show_specifiers and reset latter
4309 immediately after the call.
4310 (Vtemp_buffer_show_specifiers): New variable.
4311 (auto_window_vscroll_p, next_screen_context_lines)
4312 (Vscroll_preserve_screen_position): Remove leading asterisks from
4313 doc-strings.
4314
4315 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4316
4317 Fix minor problems found by GCC 4.6.0 static checking.
4318 * buffer.c (Qclone_number): Remove for now, as it's unused.
4319 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4320 (record_buffer): Remove unused local.
4321 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4322 (set_frame_buffer_list): Remove; unused.
4323 * frame.h (other_visible_frames): Remove decl.
4324 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4325 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4326 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4327 if HAVE_GPM.
4328 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4329 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4330 Define only if HAVE_GPM.
4331 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4332 (update_hints_inhibit): Remove; never set. All uses removed.
4333 * widgetprv.h (emacsFrameClassRec): Remove decl.
4334 * window.c (delete_deletable_window): Now returns void, since it
4335 wasn't returning anything.
4336 (compare_window_configurations): Remove unused locals.
4337 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4338 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4339 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4340 the same widths as pointers. This follows up on the 2011-05-06 patch.
4341 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4342 * xterm.h: Likewise.
4343 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4344
4345 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
4346
4347 * makefile.w32-in: Update dependencies.
4348 (LISP_H): Add lib/intprops.h.
4349
4350 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4351
4352 * image.c (gif_load): Add animation frame delay to the metadata.
4353 (syms_of_image): Use DEFSYM. New symbol `delay'.
4354
4355 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4356
4357 * window.c (delete_deletable_window): Re-add.
4358 (Fset_window_configuration): Rewrite to handle dead buffers and
4359 consequently deletable windows.
4360 (window_tree, Fwindow_tree): Remove. Supply functionality in
4361 window.el.
4362 (compare_window_configurations): Simplify code.
4363
4364 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4365
4366 * image.c (imagemagick_load_image): Fix type mismatch.
4367 (Fimagemagick_types): Likewise.
4368
4369 * window.h (replace_buffer_in_windows): Declare.
4370
4371 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4372
4373 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4374 Qclone_number. Remove external declaration of Qdelete_window.
4375 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4376 code.
4377 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4378 Run Qbuffer_list_update_hook if allowed.
4379 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4380 buffer list implementation.
4381 (other_buffer_safely): New function.
4382 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4383 calls to replace_buffer_in_windows and
4384 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4385 if allowed.
4386 (record_buffer): Inhibit quitting and rewrite using quittable
4387 functions. Run Qbuffer_list_update_hook if allowed.
4388 (Frecord_buffer, Funrecord_buffer): New functions.
4389 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4390 Move switch-to-buffer to window.el.
4391 (bury-buffer): Move to window.el.
4392 (Vbuffer_list_update_hook): New variable.
4393
4394 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4395 section.
4396
4397 * window.h (resize_frame_windows): Move up in code.
4398 (Fwindow_frame): Remove EXFUN.
4399 (replace_buffer_in_all_windows): Remove prototype.
4400 (replace_buffer_in_windows_safely): Add prototype.
4401
4402 * window.c: Declare Qdelete_window static again. Move down
4403 declaration of select_count.
4404 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4405 (Fother_window): Move to window.el.
4406 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4407 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4408 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4409 window.el.
4410 (replace_buffer_in_windows): Implement by calling
4411 Qreplace_buffer_in_windows.
4412 (replace_buffer_in_all_windows): Remove with some functionality
4413 moved into replace_buffer_in_windows_safely.
4414 (replace_buffer_in_windows_safely): New function.
4415 (select_window_norecord, select_frame_norecord): Move in front
4416 of run_window_configuration_change_hook. Remove now obsolete
4417 declarations.
4418 (Fset_window_buffer): Rewrite doc-string.
4419 Call Qrecord_window_buffer.
4420 (keys_of_window): Move binding for other-window to window.el.
4421
4422 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4423
4424 * dispextern.h (struct image): Replace data member, whose int_val
4425 and ptr_val fields were not used by anything, with a single
4426 lisp_val object.
4427
4428 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4429 (gif_clear_image, gif_load, imagemagick_load_image)
4430 (gs_clear_image, gs_load): Callers changed.
4431
4432 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4433
4434 * buffer.h: Include <time.h>, for time_t.
4435 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4436
4437 Fix minor problems found by static checking.
4438
4439 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4440
4441 Make identifiers static if they are not used in other modules.
4442 * data.c (Qcompiled_function, Qframe, Qvector):
4443 * image.c (QimageMagick, Qsvg):
4444 * minibuf.c (Qmetadata):
4445 * window.c (resize_window_check, resize_root_window): Now static.
4446 * window.h (resize_window_check, resize_root_window): Remove decls.
4447
4448 * window.c (window_deletion_count, delete_deletable_window):
4449 Remove; unused.
4450 (window_body_lines): Now static.
4451 (Fdelete_other_windows_internal): Mark vars as initialized.
4452 Make sure 'resize_failed' is initialized.
4453 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4454 (resize_window_apply): Remove unused local.
4455 * window.h (delete_deletable_window): Remove decl.
4456
4457 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
4458 (imagemagick_load_image): Fix pointer signedness problem by changing
4459 last arg from unsigned char * to char *. All uses changed.
4460 Also, fix a local for similar reasons.
4461 Remove unused locals. Remove locals to avoid shadowing.
4462 (fn_rsvg_handle_free): Remove; unused.
4463 (svg_load, svg_load_image): Fix pointer signedness problem.
4464 (imagemagick_load_image): Don't use garbage pointer image_wand.
4465
4466 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4467
4468 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
4469
4470 * image.c (gif_load): Fix omitted cast error introduced by
4471 2011-06-06 change.
4472
4473 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4474
4475 * window.h (resize_proportionally, orig_total_lines)
4476 (orig_top_line): Remove from window structure.
4477 (set_window_height, set_window_width, change_window_heights)
4478 (Fdelete_window): Remove prototypes.
4479 (resize_frame_windows): Remove duplicate declaration.
4480
4481 2011-06-10 Eli Zaretskii <eliz@gnu.org>
4482
4483 * window.h (resize_frame_windows, resize_window_check)
4484 (delete_deletable_window, resize_root_window)
4485 (resize_frame_windows): Declare prototypes.
4486
4487 * window.c (resize_window_apply): Make definition be "static" to
4488 match the prototype.
4489
4490 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4491
4492 * window.c: Remove declarations of Qwindow_size_fixed,
4493 window_min_size_1, window_min_size_2, window_min_size,
4494 size_window, window_fixed_size_p, enlarge_window, delete_window.
4495 Remove static from declaration of Qdelete_window, it's
4496 temporarily needed by Fbury_buffer.
4497 (replace_window): Don't assign orig_top_line and
4498 orig_total_lines.
4499 (Fdelete_window, delete_window): Remove. Window deletion is
4500 handled by window.el.
4501 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4502 Replace Fdelete_window calls with calls to Qdelete_window.
4503 (Fdelete_other_windows): Remove. Deleting other windows is
4504 handled by window.el.
4505 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4506 handled in window.el.
4507 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4508 Window minimum sizes are handled in window.el.
4509 (shrink_windows, size_window, set_window_height)
4510 (set_window_width, change_window_heights, window_height)
4511 (window_width, CURBEG, CURSIZE, enlarge_window)
4512 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4513 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4514 handled in window.el.
4515 (make_dummy_parent): Rename to make_parent_window and give it a
4516 second argument horflag.
4517 (make_window): Don't set resize_proportionally any more.
4518 (Fsplit_window): Remove. Windows are split in window.el.
4519 (save_restore_action, save_restore_orig_size)
4520 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4521 Resize mini windows in window.el.
4522 (grow_mini_window, shrink_mini_window): Implement by calling
4523 Qresize_root_window_vertically, resize_window_check and
4524 resize_window_apply.
4525 (saved_window, Fset_window_configuration, save_window_save):
4526 Do not handle orig_top_line, orig_total_lines, and
4527 resize_proportionally.
4528 (window_min_height, window_min_width): Move to window.el.
4529 (keys_of_window): Move bindings for delete-other-windows,
4530 split-window, delete-window and enlarge-window to window.el.
4531
4532 * buffer.c: Temporarily extern Qdelete_window.
4533 (Fbury_buffer): Temporarily call Qdelete_window instead of
4534 Fdelete_window (Fbury_buffer will move to window.el soon).
4535
4536 * frame.c (set_menu_bar_lines_1): Remove code handling
4537 orig_top_line and orig_total_lines.
4538
4539 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4540 set_window_height but set heights directly.
4541 (change_frame_size_1): Use resize_frame_windows.
4542
4543 * xdisp.c (init_xdisp): Don't use set_window_height but set
4544 heights directly.
4545
4546 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4547 Use resize_frame_windows instead of change_window_heights and run
4548 run_window_configuration_change_hook.
4549
4550 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4551 instead of change_window_heights and run
4552 run_window_configuration_change_hook.
4553
4554 2011-06-09 Martin Rudalics <rudalics@gmx.at>
4555
4556 * window.c (replace_window): Rename second argument REPLACEMENT to
4557 NEW. New third argument SETFLAG. Rewrite.
4558 (delete_window, make_dummy_parent): Call replace_window with
4559 third argument 1.
4560 (window_list_1): Move down in code.
4561 (run_window_configuration_change_hook): Move set_buffer part
4562 before select_frame_norecord part in order to unwind correctly.
4563 Rename count1 to count.
4564 (recombine_windows, delete_deletable_window, resize_root_window)
4565 (Fdelete_other_windows_internal)
4566 (Frun_window_configuration_change_hook, make_parent_window)
4567 (resize_window_check, resize_window_apply, Fresize_window_apply)
4568 (resize_frame_windows, Fsplit_window_internal)
4569 (Fdelete_window_internal, Fresize_mini_window_internal):
4570 New functions.
4571 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4572
4573 2011-06-08 Martin Rudalics <rudalics@gmx.at>
4574
4575 * window.h (window): Add some new members to window structure -
4576 normal_lines, normal_cols, new_total, new_normal, clone_number,
4577 splits, nest, prev_buffers, next_buffers.
4578 (WINDOW_TOTAL_SIZE): Move here from window.c.
4579 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
4580
4581 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4582 Remove.
4583 (make_dummy_parent): Set new members of windows structure.
4584 (make_window): Move down in code. Handle new members of window
4585 structure.
4586 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4587 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4588 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4589 (Fset_window_prev_buffers, Fwindow_next_buffers)
4590 (Fset_window_next_buffers, Fset_window_clone_number):
4591 New functions.
4592 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4593 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4594 Doc-string fixes.
4595 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4596 Argument WINDOW can be now internal window too.
4597 (Fwindow_use_time): Move up in code.
4598 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4599 Rewrite doc-string.
4600 (Fset_window_configuration, saved_window)
4601 (Fcurrent_window_configuration, save_window_save): Handle new
4602 members of window structure.
4603 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4604 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4605 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4606 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4607 Qget_mru_window, Qresize_root_window,
4608 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4609 Qauto_buffer_name; staticpro them.
4610
4611 2011-06-07 Martin Rudalics <rudalics@gmx.at>
4612
4613 * window.c (Fwindow_total_size, Fwindow_left_column)
4614 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4615 (Fwindow_list_1): New functions.
4616 (window_box_text_cols): Replace with window_body_cols.
4617 (Fwindow_width, Fscroll_left, Fscroll_right):
4618 Use window_body_cols instead of window_box_text_cols.
4619 (delete_window, Fset_window_configuration):
4620 Call delete_all_subwindows with window as argument.
4621 (delete_all_subwindows): Take a window as argument and not a
4622 structure. Rewrite.
4623 (window_loop): Remove handling of GET_LRU_WINDOW and
4624 GET_LARGEST_WINDOW.
4625 (Fget_lru_window, Fget_largest_window): Move to window.el.
4626
4627 * window.h: Extern window_body_cols instead of
4628 window_box_text_cols. delete_all_subwindows now takes a
4629 Lisp_Object as argument.
4630
4631 * indent.c (compute_motion, Fcompute_motion):
4632 Use window_body_cols instead of window_box_text_cols.
4633
4634 * frame.c (delete_frame): Call delete_all_subwindows with root
4635 window as argument.
4636
4637 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4638
4639 * fns.c (Fputhash): Document return value.
4640
4641 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
4642
4643 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4644
4645 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4646
4647 Cons<->int and similar integer overflow fixes (Bug#8794).
4648
4649 Check for overflow when converting integer to cons and back.
4650 * charset.c (Fdefine_charset_internal, Fdecode_char):
4651 Use cons_to_unsigned to catch overflow.
4652 (Fencode_char): Use INTEGER_TO_CONS.
4653 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4654 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4655 * data.c (long_to_cons, cons_to_long): Remove.
4656 (cons_to_unsigned, cons_to_signed): New functions.
4657 These signal an error for invalid or out-of-range values.
4658 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4659 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4660 * font.c (Ffont_variation_glyphs):
4661 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4662 * lisp.h: Include <intprops.h>.
4663 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4664 (cons_to_signed, cons_to_unsigned): New decls.
4665 (long_to_cons, cons_to_long): Remove decls.
4666 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4667 (Fprimitive_undo): Use CONS_TO_INTEGER.
4668 * xfns.c (Fx_window_property): Likewise.
4669 * xselect.c: Include <limits.h>.
4670 (x_own_selection, selection_data_to_lisp_data):
4671 Use INTEGER_TO_CONS.
4672 (x_handle_selection_request, x_handle_selection_clear)
4673 (x_get_foreign_selection, Fx_disown_selection_internal)
4674 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4675 (lisp_data_to_selection_data): Use cons_to_unsigned.
4676 (x_fill_property_data): Use cons_to_signed.
4677 Report values out of range.
4678
4679 Check for buffer and string overflow more precisely.
4680 * buffer.h (BUF_BYTES_MAX): New macro.
4681 * lisp.h (STRING_BYTES_MAX): New macro.
4682 * alloc.c (Fmake_string):
4683 * character.c (string_escape_byte8):
4684 * coding.c (coding_alloc_by_realloc):
4685 * doprnt.c (doprnt):
4686 * editfns.c (Fformat):
4687 * eval.c (verror):
4688 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4689 since they may not be the same number.
4690 * editfns.c (Finsert_char):
4691 * fileio.c (Finsert_file_contents):
4692 Likewise for BUF_BYTES_MAX.
4693
4694 * image.c: Use ptrdiff_t, not int, for sizes.
4695 (slurp_file): Switch from int to ptrdiff_t.
4696 All uses changed.
4697 (slurp_file): Check that file size fits in both size_t (for
4698 malloc) and ptrdiff_t (for sanity and safety).
4699
4700 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4701 if b->modtime has its maximal value.
4702
4703 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4704
4705 Don't assume time_t can fit into int.
4706 * buffer.h (struct buffer.modtime): Now time_t, not int.
4707 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4708 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4709
4710 Minor fixes for signed vs unsigned integers.
4711 * character.h (MAYBE_UNIFY_CHAR):
4712 * charset.c (maybe_unify_char):
4713 * keyboard.c (read_char, reorder_modifiers):
4714 XINT -> XFASTINT, since the integer must be nonnegative.
4715 * ftfont.c (ftfont_spec_pattern):
4716 * keymap.c (access_keymap, silly_event_symbol_error):
4717 XUINT -> XFASTINT, since the integer must be nonnegative.
4718 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4719 since it makes no difference and we prefer signed.
4720 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4721 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4722 nonnegative.
4723
4724 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4725
4726 * window.h (Fwindow_frame): Declare.
4727
4728 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4729
4730 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4731 (SPARE_MEMORY): Always define.
4732 (LARGE_REQUEST): Remove.
4733 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4734
4735 2011-06-06 Martin Rudalics <rudalics@gmx.at>
4736
4737 * lisp.h: Move EXFUNS for Fframe_root_window,
4738 Fframe_first_window and Fset_frame_selected_window to window.h.
4739
4740 * window.h: Move EXFUNS for Fframe_root_window,
4741 Fframe_first_window and Fset_frame_selected_window here from
4742 lisp.h.
4743
4744 * frame.c (Fwindow_frame, Fframe_first_window)
4745 (Fframe_root_window, Fframe_selected_window)
4746 (Fset_frame_selected_window): Move to window.c.
4747 (Factive_minibuffer_window): Move to minibuf.c.
4748 (Fother_visible_frames_p): New function.
4749
4750 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4751
4752 * window.c (decode_window, decode_any_window): Move up in code.
4753 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4754 (inhibit_frame_unsplittable): Remove unused variable.
4755 (Fwindow_buffer): Move up and rewrite doc-string.
4756 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4757 (Fwindow_prev): New functions.
4758 (Fwindow_frame): Move here from frame.c. Accept any window as
4759 argument.
4760 (Fframe_root_window, Fframe_first_window)
4761 (Fframe_selected_window): Move here from frame.c. Accept frame
4762 or arbitrary window as argument. Update doc-strings.
4763 (Fminibuffer_window): Move up in code.
4764 (Fwindow_minibuffer_p): Move up in code and simplify.
4765 (Fset_frame_selected_window): Move here from frame.c.
4766 Marginal rewrite.
4767 (Fselected_window, select_window, Fselect_window): Move up in
4768 code. Minor doc-string fixes.
4769
4770 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4771
4772 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4773 Do not assume that spare memory exists; that assumption is valid
4774 only if SYSTEM_MALLOC.
4775 (LARGE_REQUEST): New macro, so that the issue of large requests
4776 is separated from the issue of spare memory.
4777
4778 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4779
4780 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4781 format. (Bug#8806)
4782
4783 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4784
4785 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4786 before statements.
4787
4788 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4789
4790 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4791
4792 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4793
4794 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4795 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4796
4797 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
4798
4799 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4800
4801 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
4802
4803 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4804 (x_clipboard_manager_save): Add return value.
4805 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4806 New error handlers.
4807 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4808 Obey Vx_select_enable_clipboard_manager. Catch errors in
4809 x_clipboard_manager_save (Bug#8779).
4810 (Vx_select_enable_clipboard_manager): New variable.
4811 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4812
4813 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
4814
4815 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4816
4817 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4818
4819 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4820 in the current matrix if keep_current_p is non-zero.
4821
4822 2011-06-04 Eli Zaretskii <eliz@gnu.org>
4823
4824 * bidi.c (bidi_level_of_next_char): Fix last change.
4825
4826 2011-06-03 Eli Zaretskii <eliz@gnu.org>
4827
4828 Support bidi reordering of text covered by display properties.
4829
4830 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4831 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4832 (bidi_cache_search, bidi_cache_iterator_state)
4833 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4834 (bidi_level_of_next_char, bidi_move_to_visually_next):
4835 Support character positions inside a run of characters covered by a
4836 display string.
4837 (bidi_paragraph_init, bidi_resolve_explicit_1)
4838 (bidi_level_of_next_char): Call bidi_fetch_char and
4839 bidi_fetch_char_advance instead of FETCH_CHAR and
4840 FETCH_CHAR_ADVANCE.
4841 (bidi_init_it): Initialize new members.
4842 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4843 definitions.
4844 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4845 instead of using explicit *_CHAR codes.
4846 (bidi_resolve_explicit, bidi_resolve_weak):
4847 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
4848 bidirectional text is supported only in multibyte buffers.
4849 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4850 it to initialize the frame_window_p member of struct bidi_it.
4851 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4852 (bidi_resolve_explicit, bidi_resolve_weak)
4853 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4854 bidi_it->nchars is non-positive.
4855 (bidi_level_of_next_char): Don't try to lookup the cache for the
4856 next/previous character if nothing is cached there yet, or if we
4857 were just reseat()'ed to a new position.
4858
4859 * xdisp.c (set_cursor_from_row): Set start and stop points
4860 according to the row's direction when priming the loop that looks
4861 for the glyph on which to display cursor.
4862 (single_display_spec_intangible_p): Function deleted.
4863 (display_prop_intangible_p): Reimplement to call
4864 handle_display_spec instead of single_display_spec_intangible_p.
4865 Accept 3 additional arguments needed by handle_display_spec.
4866 This fixes incorrect cursor motion across display property with complex
4867 values: lists, `(when COND...)' forms, etc.
4868 (single_display_spec_string_p): Support property values that are
4869 lists with the argument STRING its top-level element.
4870 (display_prop_string_p): Fix the condition for processing a
4871 property that is a list to be consistent with handle_display_spec.
4872 (handle_display_spec): New function, refactored from the
4873 last portion of handle_display_prop.
4874 (compute_display_string_pos): Accept additional argument
4875 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4876 value of a `display' property is a "replacing spec".
4877 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4878 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4879 the display property, but just return a value indicating whether
4880 the display property will replace the characters it covers.
4881 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4882 frame_window_p members of struct bidi_it.
4883 (compute_display_string_pos, compute_display_string_end):
4884 New functions.
4885 (push_it): Accept second argument POSITION, where pop_it should
4886 jump to continue iteration.
4887 (reseat_1): Initialize bidi_it.disp_pos.
4888
4889 * keyboard.c (adjust_point_for_property): Adjust the call to
4890 display_prop_intangible_p to its new signature.
4891
4892 * dispextern.h (struct bidi_it): New member frame_window_p.
4893 (bidi_init_it): Update prototypes.
4894 (display_prop_intangible_p): Update prototype.
4895 (compute_display_string_pos, compute_display_string_end):
4896 Declare prototypes.
4897 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4898 EMACS_INT.
4899
4900 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
4901
4902 Malloc failure behavior now depends on size of allocation.
4903 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4904 * lisp.h: Change signatures accordingly.
4905 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4906 All callers changed. (Bug#8762)
4907
4908 * gnutls.c: Use Emacs's memory allocators.
4909 Without this change, the gnutls library would invoke malloc etc.
4910 directly, which causes problems on non-SYNC_INPUT hosts, and which
4911 runs afoul of improving memory_full behavior. (Bug#8761)
4912 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4913 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4914 xfree instead of the default malloc, realloc, free.
4915 (Fgnutls_boot): No need to check for memory allocation failure,
4916 since xmalloc does that for us.
4917
4918 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
4919 * category.c (hash_get_category_set):
4920 * ccl.c (ccl_driver):
4921 * charset.c (Fdefine_charset_internal):
4922 * charset.h (struct charset.hash_index):
4923 * composite.c (get_composition_id, gstring_lookup_cache)
4924 (composition_gstring_put_cache):
4925 * composite.h (struct composition.hash_index):
4926 * dispextern.h (struct image.hash):
4927 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4928 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4929 (hashfn_equal, hashfn_user_defined, make_hash_table)
4930 (maybe_resize_hash_table, hash_lookup, hash_put)
4931 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4932 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4933 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4934 * image.c (make_image, search_image_cache, lookup_image)
4935 (xpm_put_color_table_h):
4936 * lisp.h (struct Lisp_Hash_Table):
4937 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
4938 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
4939 for hashes and hash indexes, instead of 'unsigned' and 'int'.
4940 * alloc.c (allocate_vectorlike):
4941 Check for overflow in vector size calculations.
4942 * ccl.c (ccl_driver):
4943 Check for overflow when converting EMACS_INT to int.
4944 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4945 need to be updated by these changes.
4946 * fns.c (make_hash_table, maybe_resize_hash_table):
4947 Check for integer overflow with large hash tables.
4948 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4949 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4950 (SXHASH_REDUCE): New macro.
4951 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4952 Use it instead of discarding useful hash info with large hash values.
4953 (sxhash_float): New function.
4954 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4955 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
4956 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4957 Rewrite to use FIXNUM_BITS, as this simplifies things.
4958 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4959 Adjust signatures to match updated version of code.
4960 (consing_since_gc): Now EMACS_INT, since a single hash table can
4961 use more than INT_MAX bytes.
4962
4963 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4964
4965 Make it possible to build with GCC-4.6+ -O2 -flto.
4966
4967 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4968
4969 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4970
4971 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4972 Call minibuffer-inactive-mode.
4973
4974 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
4975
4976 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4977 Update dependencies.
4978
4979 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4980
4981 * data.c (init_data): Remove code for UTS, this system is not
4982 supported anymore.
4983
4984 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4985
4986 Don't force ./temacs to start in terminal mode.
4987
4988 * frame.c (make_initial_frame): Initialize faces in all cases, not
4989 only when CANNOT_DUMP is defined.
4990 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4991
4992 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4993
4994 * dispnew.c (add_window_display_history): Use const for the string
4995 pointer. Remove declaration, not needed.
4996
4997 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4998
4999 Use 'inline', not 'INLINE'.
5000 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5001 * alloc.c, fontset.c (INLINE): Remove.
5002 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5003 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5004 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5005 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5006 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5007
5008 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5009
5010 Make it possible to run ./temacs.
5011
5012 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5013 syms_of_callproc does the same thing. Remove test for
5014 "initialized", do it in the caller.
5015 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5016
5017 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5018
5019 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5020 (read_minibuf): Use get_minibuffer.
5021 (syms_of_minibuf): Use DEFSYM.
5022 (Qmetadata): New var.
5023 * data.c (Qbuffer): Don't make it static.
5024 (syms_of_data): Use DEFSYM.
5025
5026 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5027
5028 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5029 (CCL_CODE_MIN): New macro.
5030
5031 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5032
5033 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5034
5035 * eval.c (Qdebug): Now static.
5036 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5037 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5038 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5039
5040 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5041
5042 * image.c: Various fixes to ImageMagick code comments.
5043 (Fimagemagick_types): Doc fix.
5044
5045 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5046
5047 Minor fixes prompted by GCC 4.6.0 warnings.
5048
5049 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5050
5051 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5052 (x_clipboard_manager_save_all): Move extern decl to ...
5053 * xterm.h: ... here, so that it can be checked for consistency.
5054
5055 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5056
5057 * xselect.c (x_clipboard_manager_save_frame)
5058 (x_clipboard_manager_save_all): New functions.
5059 (Fx_clipboard_manager_save): Lisp function deleted.
5060
5061 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5062 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5063
5064 * xterm.h: Update prototype.
5065
5066 2011-05-28 William Xu <william.xwl@gmail.com>
5067
5068 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5069 exiting (Bug#8239).
5070
5071 2011-05-28 Jim Meyering <meyering@redhat.com>
5072
5073 Avoid a sign-extension bug in crypto_hash_function.
5074 * fns.c (to_uchar): Define.
5075 (crypto_hash_function): Use it to convert some newly-signed
5076 variables to unsigned, to avoid sign-extension bugs. For example,
5077 without this change, (md5 "truc") would evaluate to
5078 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5079 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5080 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5081
5082 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5083
5084 Integer overflow fixes.
5085
5086 * dbusbind.c: Serial number integer overflow fixes.
5087 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5088 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5089 to hold a serial number that is too large for a fixnum.
5090 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5091 Check for serial numbers out of range. Decode any serial number
5092 that was so large that it became a float. (Bug#8722)
5093
5094 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5095 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5096 Use XFASTINT rather than XUINT when numbers are nonnegative.
5097 (xd_append_arg, Fdbus_method_return_internal):
5098 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5099 arguments, check that Lisp number is nonnegative, rather than
5100 silently wrapping negative numbers around. (Bug#8722)
5101 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5102 (Bug#8722)
5103
5104 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5105
5106 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5107
5108 ccl: add integer overflow checks
5109 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5110 (IN_INT_RANGE): New macros.
5111 (ccl_driver): Use them to check for integer overflow when
5112 decoding a CCL program. Many of the new checks are whether XINT (x)
5113 fits in int; it doesn't always, on 64-bit hosts. The new version
5114 doesn't catch all possible integer overflows, but it's an
5115 improvement. (Bug#8719)
5116
5117 * alloc.c (make_event_array): Use XINT, not XUINT.
5118 There's no need for unsigned here.
5119
5120 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5121 This follows up to the 2011-05-06 change that substituted uintptr_t
5122 for EMACS_INT. This case wasn't caught back then.
5123
5124 Rework Fformat to avoid integer overflow issues.
5125 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5126 now (part of C89). Include <verify.h>.
5127 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5128 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5129 (Fformat): Avoid the prepass trying to compute sizes; it was only
5130 approximate and thus did not catch overflow reliably. Instead, walk
5131 through the format just once, formatting and computing sizes as we go,
5132 checking for integer overflow at every step, and allocating a larger
5133 buffer as needed. Keep track separately whether the format is
5134 multibyte. Keep only the most-recently calculated precision, rather
5135 than them all. Record whether each argument has been converted to
5136 string. Use EMACS_INT, not int, for byte and char and arg counts.
5137 Support field widths and precisions larger than INT_MAX. Avoid
5138 sprintf's undefined behavior with conversion specifications such as %#d
5139 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5140 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5141 formatting out-of-range floating point numbers with int
5142 formats. (Bug#8668)
5143
5144 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5145
5146 * data.c: Avoid integer truncation in expressions involving floats.
5147 * data.c: Include <intprops.h>.
5148 (arith_driver): When there's an integer overflow in an expression
5149 involving floating point, convert the integers to floating point
5150 so that the resulting value does not suffer from catastrophic
5151 integer truncation. For example, on a 64-bit host (* 4
5152 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5153 Do not rely on undefined behavior after integer overflow.
5154
5155 merge count_size_as_multibyte, parse_str_to_multibyte
5156 * character.c, character.h (count_size_as_multibyte):
5157 Rename from parse_str_to_multibyte; all uses changed.
5158 Check for integer overflow.
5159 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5160 since it's now a duplicate of the other. This is more of
5161 a character than a buffer op, so better that it's in character.c.
5162 * fns.c, print.c: Adjust to above changes.
5163
5164 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5165
5166 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5167
5168 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5169
5170 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5171 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5172 (x_clipboard_manager_save): Now static.
5173 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5174
5175 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5176 (crypto_hash_function): Now static.
5177 Fix pointer signedness problems. Avoid unnecessary initializations.
5178
5179 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5180
5181 * termhooks.h (Vselection_alist): Make it terminal-local.
5182
5183 * terminal.c (create_terminal): Initialize it.
5184
5185 * xselect.c: Support for clipboard managers.
5186 (Vselection_alist): Move to termhooks.h as terminal-local var.
5187 (LOCAL_SELECTION): New macro.
5188 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5189 (symbol_to_x_atom): Remove gratuitous arg.
5190 (x_handle_selection_request, lisp_data_to_selection_data)
5191 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5192 (x_own_selection, x_get_local_selection, x_convert_selection):
5193 New arg, specifying work frame. Use terminal-local Vselection_alist.
5194 (some_frame_on_display): Delete unused function.
5195 (Fx_own_selection_internal, Fx_get_selection_internal)
5196 (Fx_disown_selection_internal, Fx_selection_owner_p)
5197 (Fx_selection_exists_p): New optional frame arg.
5198 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5199 (x_handle_selection_clear): Don't treat other terminals with the
5200 same keyboard specially. Use the terminal-local Vselection_alist.
5201 (x_clear_frame_selections): Use Frun_hook_with_args.
5202
5203 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5204
5205 * xterm.h: Add support for those atoms.
5206
5207 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5208
5209 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5210 (converted_selections, conversion_fail_tag): New global variables.
5211 (x_selection_request_lisp_error): Free the above.
5212 (x_get_local_selection): Remove unnecessary code.
5213 (x_reply_selection_request): Args changed; handle arbitrary array
5214 of converted selections stored in converted_selections.
5215 Separate the XChangeProperty and SelectionNotify steps.
5216 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5217 (x_convert_selection): New function.
5218 (x_handle_selection_event): Simplify.
5219 (x_get_foreign_selection): Don't ignore incoming requests while
5220 waiting for an answer; this will fail when we implement
5221 SAVE_TARGETS, and seems unnecessary anyway.
5222 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5223 (Vx_sent_selection_functions): Doc fix.
5224
5225 2011-05-26 Leo Liu <sdl.web@gmail.com>
5226
5227 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5228
5229 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5230
5231 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5232
5233 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5234 for fringe update if it has periodic bitmap.
5235 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5236 and fringe_bitmap_periodic_p.
5237
5238 * fringe.c (get_fringe_bitmap_data): New function.
5239 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5240 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5241 row. Mark glyph row for fringe update if periodicity changed.
5242
5243 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5244 for fringe update unless it has periodic bitmap.
5245
5246 2011-05-25 Kenichi Handa <handa@m17n.org>
5247
5248 * xdisp.c (get_next_display_element): Set correct it->face_id for
5249 a static composition.
5250
5251 2011-05-24 Leo Liu <sdl.web@gmail.com>
5252
5253 * deps.mk (fns.o):
5254 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5255
5256 * fns.c (crypto_hash_function, Fsha1): New function.
5257 (Fmd5): Use crypto_hash_function.
5258 (syms_of_fns): Add Ssha1.
5259
5260 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5261
5262 * gnutls.c: Remove unused macros.
5263 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5264 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5265 Remove macros that are defined and never used.
5266 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5267
5268 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5269
5270 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5271 (Fx_get_selection_internal): Minor cleanup.
5272 (Fx_own_selection_internal): Rename arguments for consistency with
5273 select.el.
5274
5275 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5276
5277 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5278
5279 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5280
5281 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5282
5283 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5284
5285 * dispnew.c (scrolling_window): Don't exclude the case that the
5286 last enabled row in the desired matrix touches the bottom boundary.
5287
5288 2011-05-21 Glenn Morris <rgm@gnu.org>
5289
5290 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
5291 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5292 and add some more files.
5293
5294 2011-05-20 Eli Zaretskii <eliz@gnu.org>
5295
5296 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5297 report_file_error introduced by the change from 2011-05-07.
5298
5299 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5300
5301 * systime.h (Time): Define only if emacs is defined.
5302 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5303 where the include path doesn't have X11/X.h by default. See
5304 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5305
5306 2011-05-20 Kenichi Handa <handa@m17n.org>
5307
5308 * composite.c (find_automatic_composition): Fix previous change.
5309
5310 2011-05-20 Glenn Morris <rgm@gnu.org>
5311
5312 * lisp.mk: New file, split from Makefile.in.
5313 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5314 (shortlisp): Remove.
5315 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5316
5317 2011-05-19 Glenn Morris <rgm@gnu.org>
5318
5319 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5320 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5321 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5322 (lisp): Set the order to that of loadup.el.
5323 (shortlisp): Make it a copy of $lisp.
5324 (SOME_MACHINE_LISP): Remove.
5325 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5326 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5327
5328 2011-05-18 Kenichi Handa <handa@m17n.org>
5329
5330 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5331 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5332 (find_automatic_composition): Mostly rewrite for efficiency.
5333
5334 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
5335
5336 * makefile.w32-in: Update dependencies.
5337
5338 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5339
5340 * menu.c: Include limits.h (fixes the MS-Windows build broken by
5341 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
5342
5343 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
5344
5345 Fix some integer overflow issues, such as string length overflow.
5346
5347 * insdel.c (count_size_as_multibyte): Check for string overflow.
5348
5349 * character.c (lisp_string_width): Check for string overflow.
5350 Use EMACS_INT, not int, for string indexes and lengths; in
5351 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5352 the resulting string length overflows an EMACS_INT; instead,
5353 report a string overflow if no precision given. When checking for
5354 precision exhaustion, use a check that cannot possibly have
5355 integer overflow. (Bug#8675)
5356 * character.h (lisp_string_width): Adjust to new signature.
5357
5358 * alloc.c (string_overflow): New function.
5359 (Fmake_string): Use it. This doesn't change behavior, but saves
5360 a few bytes and will simplify future changes.
5361 * character.c (string_escape_byte8): Likewise.
5362 * lisp.h (string_overflow): New decl.
5363
5364 Fixups, following up to the user-interface timestamp change.
5365 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5366 for UI timestamps, instead of unsigned long.
5367 * msdos.c (mouse_get_pos): Likewise.
5368 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
5369 * w32gui.h (Time): Define by including "systime.h" rather than by
5370 declaring it ourselves. (Bug#8664)
5371
5372 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5373 * image.c (clear_image_cache): Likewise.
5374
5375 * term.c (term_mouse_position): Don't assume time_t wraparound.
5376
5377 Be more systematic about user-interface timestamps.
5378 Before, the code sometimes used 'Time', sometimes 'unsigned long',
5379 and sometimes 'EMACS_UINT', to represent these timestamps.
5380 This change causes it to use 'Time' uniformly, as that's what X uses.
5381 This makes the code easier to follow, and makes it easier to catch
5382 integer overflow bugs such as Bug#8664.
5383 * frame.c (Fmouse_position, Fmouse_pixel_position):
5384 Use Time, not unsigned long, for user-interface timestamps.
5385 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5386 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5387 * keyboard.h (last_event_timestamp): Likewise.
5388 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5389 * menu.h (xmenu_show): Likewise.
5390 * term.c (term_mouse_position): Likewise.
5391 * termhooks.h (struct input_event.timestamp): Likewise.
5392 (struct terminal.mouse_position_hook): Likewise.
5393 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5394 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5395 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5396 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5397 what it was before.
5398 * menu.h, termhooks.h: Include "systime.h", for Time.
5399
5400 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5401 Don't assume that the difference between two unsigned long values
5402 can fit into an integer. At this point, we know button_down_time
5403 <= event->timestamp, so the difference must be nonnegative, so
5404 there's no need to cast the result if double-click-time is
5405 nonnegative, as it should be; check that it's nonnegative, just in
5406 case. This bug is triggered when events are more than 2**31 ms
5407 apart (about 25 days). (Bug#8664)
5408
5409 * xselect.c (last_event_timestamp): Remove duplicate decl.
5410 (x_own_selection): Remove needless cast to unsigned long.
5411
5412 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5413 that always fit in int. Use a sentinel instead of a counter, to
5414 avoid a temp and to allay GCC's concerns about possible int overflow.
5415 * frame.h (struct frame): Use int for menu_bar_items_used
5416 instead of EMACS_INT, since it always fits in int.
5417
5418 * menu.c (grow_menu_items): Check for int overflow.
5419
5420 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5421
5422 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5423 Before, the code was not consistent. These values cannot exceed
5424 2**31 - 1 so there's no need to make them unsigned.
5425 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5426 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5427 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5428 as modifiers.
5429 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5430
5431 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5432 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5433 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5434 presumably because the widths might not match.
5435
5436 * window.c (size_window): Avoid needless test at loop start.
5437
5438 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5439
5440 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5441
5442 2011-05-12 Drew Adams <drew.adams@oracle.com>
5443
5444 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5445
5446 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5447
5448 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5449 `width' to `bar_area_x' and `bar_area_width', respectively.
5450 (x_scroll_run): Take account of fringe background extension.
5451
5452 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5453 Rename local vars `left' and `width' to `bar_area_x' and
5454 `bar_area_width', respectively.
5455 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5456 background extension.
5457
5458 2011-05-10 Jim Meyering <meyering@redhat.com>
5459
5460 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5461
5462 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
5463
5464 * image.c (Finit_image_library): Return t for built-in image types,
5465 like pbm and xbm. (Bug#8640)
5466
5467 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5468
5469 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5470
5471 2011-05-07 Eli Zaretskii <eliz@gnu.org>
5472
5473 * w32console.c (Fset_screen_color): Doc fix.
5474 (Fget_screen_color): New function.
5475 (syms_of_ntterm): Defsubr it.
5476
5477 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5478 unlink the temporary file if Fcall_process didn't create it in the
5479 first place.
5480 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5481 child process will be redirected to a file specified with `:file'.
5482 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5483 cue to call_process_cleanup not to close that handle.
5484
5485 2011-05-07 Ben Key <bkey76@gmail.com>
5486
5487 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5488 one of two shell specific rules, either bootstrap-temacs-CMD or
5489 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5490 to the previous implementation of the bootstrap-temacs rule.
5491 The bootstrap-temacs-CMD rule is similar to the previous
5492 implementation of the bootstrap-temacs rule except that it
5493 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5494 variable.
5495
5496 These changes, along with some changes to nt/configure.bat,
5497 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5498 earlier fix to add support for --cflags and --ldflags options
5499 that include quotes so that it works whether make uses cmd or
5500 sh as the shell.
5501
5502 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
5503
5504 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5505 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5506 is a constant.
5507 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5508 a string. Handle both cases.
5509 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5510 (Fdbus_register_method): Use Qinvalid_function.
5511
5512 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5513
5514 * makefile.w32-in: Update dependencies.
5515 (LISP_H): Add inttypes.h and stdin.h.
5516 (PROCESS_H): Add unistd.h.
5517
5518 2011-05-06 Eli Zaretskii <eliz@gnu.org>
5519
5520 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5521 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5522
5523 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
5524
5525 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5526
5527 * term.c (vfatal): Remove stray call to va_end.
5528 It's not needed and the C Standard doesn't allow it here anyway.
5529
5530 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5531 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5532
5533 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5534 bytes.
5535
5536 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5537
5538 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5539
5540 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5541
5542 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5543
5544 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5545
5546 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5547 * charset.c (Fdefine_charset_internal): Don't initialize
5548 charset.code_space[15]. The value was garbage, on hosts with
5549 32-bit int (Bug#8600).
5550
5551 * lread.c (read_integer): Be more consistent with string-to-number.
5552 Use string_to_number to do the actual conversion; this avoids
5553 rounding errors and fixes some other screwups. Without this fix,
5554 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5555 (digit_to_number): Move earlier, for benefit of read_integer.
5556 Return -1 if the digit is out of range for the base, -2 if it is
5557 not a digit in any supported base. (Bug#8602)
5558
5559 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5560
5561 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5562 to match comment at start of function. This also removes a
5563 GCC warning about overflow in a 32+64-bit port.
5564
5565 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5566
5567 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5568 Reported by Stefan Monnier in
5569 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
5570 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5571 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
5572
5573 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5574 (EMACS_UINTPTR): Likewise, with uintptr_t.
5575
5576 * lisp.h: Prefer 64-bit EMACS_INT if available.
5577 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5578 on 32-bit hosts that have 64-bit int, so that they can access
5579 large files.
5580 However, temporarily disable this change unless the temporary
5581 symbol WIDE_EMACS_INT is defined.
5582
5583 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5584
5585 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5586 This removes an assumption that EMACS_INT and long are the same
5587 width as pointers. The assumption is true for Emacs porting targets
5588 now, but we want to make other targets possible.
5589 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5590 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5591 In the rest of the code, change types of integers that hold casted
5592 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5593 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5594 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5595 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5596 No need to cast type when ORing.
5597 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5598 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5599 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5600 assume EMACS_INT is the same width as char *.
5601 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5602 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5603 Remove no-longer-needed casts.
5604 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5605 (xg_tool_bar_help_callback, xg_make_tool_item):
5606 Use EMACS_INTPTR to hold an integer
5607 that will be cast to void *; this can avoid a GCC warning
5608 if EMACS_INT is not the same width as void *.
5609 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5610 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5611 (current_message_1, set_message_1):
5612 Use a local to convert to proper width without a cast.
5613 * xmenu.c (dialog_selection_callback): Likewise.
5614
5615 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5616 Also, don't assume VALBITS / RAND_BITS is less than 5,
5617 and don't rely on undefined behavior when shifting a 1 left into
5618 the sign bit.
5619 * lisp.h (get_random): Change signature to match.
5620
5621 * lread.c (hash_string): Use size_t, not int, for hash computation.
5622 Normally we prefer signed values; but hashing is special, because
5623 it's better to use unsigned division on hash table sizes so that
5624 the remainder is nonnegative. Also, size_t is the natural width
5625 for hashing into memory. The previous code used 'int', which doesn't
5626 retain enough info to hash well into very large tables.
5627 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5628
5629 * dbusbind.c: Don't possibly lose pointer info when converting.
5630 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5631 Use XPNTR rather than XHASH, so that the high-order bits of
5632 the pointer aren't lost when converting through void *.
5633
5634 * eval.c (Fautoload): Don't double-shift a pointer.
5635
5636 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5637
5638 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5639
5640 * gnutls.c (DEF_GNUTLS_FN):
5641 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5642
5643 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5644
5645 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5646 marker. (Bug#8610)
5647
5648 2011-05-05 Eli Zaretskii <eliz@gnu.org>
5649
5650 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5651 New version that can reserve upto 2GB of heap space.
5652
5653 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
5654
5655 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5656
5657 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5658
5659 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5660 `gnutls_certificate_set_x509_key_file'.
5661
5662 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
5663
5664 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5665 Update dependencies.
5666
5667 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5668
5669 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5670 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5671 Remove unused parameter `fildes'.
5672 * process.c (read_process_output, send_process): Don't pass it.
5673
5674 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5675
5676 Fix previous change: the library cache is defined in w32.c.
5677 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5678 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5679
5680 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5681
5682 Implement dynamic loading of GnuTLS on Windows.
5683
5684 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5685 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5686 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5687 Declare.
5688
5689 * gnutls.c (Qgnutls_dll): Define.
5690 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5691 (gnutls_*): Declare function pointers.
5692 (init_gnutls_functions): New function to initialize function pointers.
5693 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5694 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5695 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5696 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5697 (emacs_gnutls_write, emacs_gnutls_read)
5698 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5699 (Fgnutls_available_p): New function.
5700 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5701 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5702 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5703
5704 * image.c: Include w32.h.
5705 (Vimage_type_cache): Delete.
5706 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5707 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5708 (w32_delayed_load): Move to w32.c.
5709
5710 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5711
5712 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5713 (w32_delayed_load): Move from image.c. When loading a library, record
5714 its filename in the :loaded-from property of the library id.
5715 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5716 Initialize and staticpro them.
5717 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5718
5719 * process.c: Include lisp.h before w32.h, not after.
5720 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5721 instead of gnutls_record_check_pending.
5722
5723 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5724
5725 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5726
5727 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5728 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5729 as passed in.
5730
5731 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5732
5733 * xterm.c (x_set_frame_alpha): Do not set property on anything
5734 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5735
5736 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5737
5738 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5739
5740 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5741
5742 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5743 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5744 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5745 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5746 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5747 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5748 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5749 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5750 (Qgnutls_bootprop_callbacks_verify): Make static.
5751
5752 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5753
5754 * callproc.c: Indentation fixup.
5755
5756 * sysdep.c (wait_for_termination_1): Make static.
5757 (wait_for_termination, interruptible_wait_for_termination):
5758 Move after wait_for_termination_1.
5759
5760 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5761
5762 * sysdep.c (interruptible_wait_for_termination): New function
5763 which is like wait_for_termination, but allows keyboard
5764 interruptions.
5765
5766 * callproc.c (Fcall_process): Add (:file "file") as an option for
5767 the STDOUT buffer.
5768 (Fcall_process_region): Ditto.
5769
5770 2011-04-30 Eli Zaretskii <eliz@gnu.org>
5771
5772 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5773 rather than `XVECTOR (FOO)->size'.
5774
5775 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5776 inttypes.h, as a gnulib replacement is used if it not available in
5777 system headers.
5778
5779 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5780
5781 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5782 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5783 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5784
5785 * coding.c (coding_alloc_by_realloc): Error out if destination
5786 will grow beyond MOST_POSITIVE_FIXNUM.
5787 (decode_coding_emacs_mule): Abort if there isn't enough place in
5788 charbuf for the composition carryover bytes. Reserve an extra
5789 space for up to 2 characters produced in a loop.
5790 (decode_coding_iso_2022): Abort if there isn't enough place in
5791 charbuf for the composition carryover bytes.
5792
5793 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5794
5795 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5796 aborting when %lld or %lll format is passed.
5797 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5798 %llo or %llx format is passed. (Bug#8545)
5799
5800 * window.c (window_scroll_line_based): Use a marker instead of
5801 simple variables to record original value of point. (Bug#7952)
5802
5803 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5804 produced by %s or %c overflows available buffer space. (Bug#8545)
5805
5806 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5807
5808 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
5809 (SIZE_MAX): Move defn after all includes, as they might #define it.
5810
5811 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5812
5813 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5814
5815 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5816
5817 * keyboard.c (Qdelayed_warnings_hook): Define.
5818 (command_loop_1): Run `delayed-warnings-hook'
5819 if Vdelayed_warnings_list is non-nil.
5820 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5821 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5822
5823 2011-04-28 Eli Zaretskii <eliz@gnu.org>
5824
5825 * doprnt.c (doprnt): Don't return value smaller than the buffer
5826 size if the message was truncated. (Bug#8545).
5827
5828 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5829
5830 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5831 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5832
5833 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5834
5835 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5836
5837 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
5838
5839 * makefile.w32-in: Update dependencies.
5840
5841 2011-04-27 Eli Zaretskii <eliz@gnu.org>
5842
5843 Improve `doprnt' and its usage. (Bug#8545)
5844 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5845 `format_end'. Remove support for %l as a conversion specifier.
5846 Don't use xrealloc. Improve diagnostics when the %l size modifier
5847 is used. Update the commentary.
5848
5849 * eval.c (verror): Simplify calculation of size_t.
5850
5851 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5852 messages.
5853
5854 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5855
5856 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5857 change.
5858
5859 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5860
5861 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5862 This makes this file independent of the recent pseudovector change.
5863
5864 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
5865
5866 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5867
5868 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
5869 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
5870 Remove unused local.
5871 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
5872
5873 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
5874 GCC 4.6.0 optimizes based on type-based alias analysis.
5875 For example, if b is of type struct buffer * and v of type struct
5876 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5877 != &v->size, and therefore "v->size = 1; b->size = 2; return
5878 v->size;" must therefore return 1. This assumption is incorrect
5879 for Emacs, since it type-puns struct Lisp_Vector * with many other
5880 types. To fix this problem, this patch adds a new type struct
5881 vectorlike_header that documents the constraints on layout of vectors
5882 and pseudovectors, and helps optimizing compilers not get fooled
5883 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5884 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
5885 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5886 the size member.
5887 (XSETPVECTYPE): Rewrite in terms of new macro.
5888 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5889 This is a bit clearer, and further avoids the possibility of
5890 undesirable aliasing.
5891 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
5892 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
5893 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5894 since Lisp_Subr is a special case (no "next" field).
5895 (ASIZE): Now uses header.size rather than size.
5896 All previous uses of XVECTOR (foo)->size replaced to use this macro,
5897 to avoid the hassle of writing XVECTOR (foo)->header.size.
5898 (struct vectorlike_header): New type.
5899 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5900 object, to help avoid aliasing.
5901 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5902 (SUBRP): Likewise, since Lisp_Subr is a special case.
5903 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5904 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5905 (struct Lisp_Hash_Table): Combine first two members into a single
5906 struct vectorlike_header member. All uses of "size" and "next" members
5907 changed to be "header.size" and "header.next".
5908 * buffer.h (struct buffer): Likewise.
5909 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5910 * frame.h (struct frame): Likewise.
5911 * process.h (struct Lisp_Process): Likewise.
5912 * termhooks.h (struct terminal): Likewise.
5913 * window.c (struct save_window_data, struct saved_window): Likewise.
5914 * window.h (struct window): Likewise.
5915 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5916 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5917 * buffer.c (init_buffer_once): Likewise.
5918 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5919 special case.
5920 * process.c (Fformat_network_address): Use local var for size,
5921 for brevity.
5922
5923 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5924
5925 Make the Lisp reader and string-to-float more consistent (Bug#8525)
5926 * data.c (atof): Remove decl; no longer used or needed.
5927 (digit_to_number): Move to lread.c.
5928 (Fstring_to_number): Use new string_to_number function, to be
5929 consistent with how the Lisp reader treats infinities and NaNs.
5930 Do not assume that floating-point numbers represent EMACS_INT
5931 without losing information; this is not true on most 64-bit hosts.
5932 Avoid double-rounding errors, by insisting on integers when
5933 parsing non-base-10 numbers, as the documentation specifies.
5934 * lisp.h (string_to_number): New decl, replacing ...
5935 (isfloat_string): Remove.
5936 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
5937 (read1): Do not accept +. and -. as integers; this
5938 appears to have been a coding error. Similarly, do not accept
5939 strings like +-1e0 as floating point numbers. Do not report
5940 overflow for integer overflows unless the base is not 10 which
5941 means we have no simple and reliable way to continue.
5942 Break out the floating-point parsing into a new
5943 function string_to_number, so that Fstring_to_number parses
5944 floating point numbers consistently with the Lisp reader.
5945 (digit_to_number): Move here from data.c. Make it static inline.
5946 (E_CHAR, EXP_INT): Remove, replacing with ...
5947 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5948 (string_to_number): New function, replacing isfloat_string.
5949 This function checks for valid syntax and produces the resulting
5950 Lisp float number too. Rework it so that string-to-number
5951 no longer mishandles examples like "1.0e+". Use strtoumax,
5952 so that overflow for non-base-10 numbers is reported only when
5953 there's no portable and simple way to convert to floating point.
5954
5955 * textprop.c (set_text_properties_1): Rewrite for clarity,
5956 and to avoid GCC warning about integer overflow.
5957
5958 * intervals.h (struct interval): Use EMACS_INT for members
5959 where EMACS_UINT might cause problems. See
5960 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5961 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5962 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5963 All uses changed.
5964 (offset_intervals): Tell GCC not to worry about length overflow
5965 when negating a negative length.
5966
5967 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5968 (overrun_check_free): Likewise.
5969
5970 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5971 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5972 word size.
5973
5974 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5975 (gnutls_make_error): Rename local to avoid shadowing.
5976 (gnutls_emacs_global_deinit): ifdef out; not used.
5977 (Fgnutls_boot): Use const for pointer to readonly storage.
5978 Comment out unused local. Fix pointer signedness problems.
5979
5980 * lread.c (openp): Don't stuff size_t into an 'int'.
5981 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5982 about possible signed overflow.
5983
5984 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5985 (GDK_KEY_g): Don't define if already defined.
5986 (xg_prepare_tooltip): Avoid pointer signedness problem.
5987 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5988
5989 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5990 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5991
5992 * xfns.c (Fx_window_property): Simplify a bit,
5993 to make a bit faster and to avoid GCC 4.6.0 warning.
5994 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5995
5996 * fns.c (internal_equal): Don't assume size_t fits in int.
5997
5998 * alloc.c (compact_small_strings): Tighten assertion a little.
5999
6000 Replace pEd with more-general pI, and fix some printf arg casts.
6001 * lisp.h (pI): New macro, generalizing old pEd macro to other
6002 conversion specifiers. For example, use "...%"pI"d..." rather
6003 than "...%"pEd"...".
6004 (pEd): Remove. All uses replaced with similar uses of pI.
6005 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6006 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6007 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6008 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6009 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6010 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6011 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6012 64-bit hosts.
6013 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6014 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6015 * print.c (safe_debug_print, print_object): Likewise.
6016 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6017 to int.
6018 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6019 avoiding the 0 flag, which is not portable.
6020 * process.c (Fmake_network_process): Use pI to avoid cast.
6021 * region-cache.c (pp_cache): Likewise.
6022 * xdisp.c (decode_mode_spec): Likewise.
6023 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6024 behavior on 64-bit hosts with printf arg.
6025 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6026 (x_stop_queuing_selection_requests): Likewise.
6027 (x_get_window_property): Don't truncate byte count to an 'int'
6028 when tracing.
6029
6030 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6031 here, since it parses constructs like leading '-' and spaces,
6032 which are not wanted; and it overflows with large numbers.
6033 Instead, simply match F[0-9]+, which is what is wanted anyway.
6034
6035 * alloc.c: Remove unportable assumptions about struct layout.
6036 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6037 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6038 (allocate_vectorlike, make_pure_vector): Use the new macros,
6039 plus offsetof, to remove unportable assumptions about struct layout.
6040 These assumptions hold on all porting targets that I know of, but
6041 they are not guaranteed, they're easy to remove, and removing them
6042 makes further changes easier.
6043
6044 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6045 This doesn't fix a bug but makes the code clearer.
6046 (string_overrun_cookie): Now const. Use initializers that
6047 don't formally overflow signed char, to avoid warnings.
6048 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6049 can cause Emacs to crash when string overrun checking is enabled.
6050 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6051 multiple of sizeof (EMACS_INT); it need not be, if
6052 alignof(EMACS_INT) < sizeof (EMACS_INT).
6053 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6054
6055 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6056
6057 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6058
6059 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6060
6061 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6062 supposed to be handshaking. (Bug#8556)
6063 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6064
6065 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6066
6067 * lisp.h (Qdebug): List symbol.
6068 * eval.c (Qdebug): Restore global linkage.
6069 * keyboard.c (debug-on-event): New variable.
6070 (handle_user_signal): Break into debugger when debug-on-event
6071 matches the current signal symbol.
6072
6073 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6074
6075 * alloc.c (check_sblock, check_string_bytes)
6076 (check_string_free_list): Convert to standard C.
6077
6078 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6079
6080 * w32.c (emacs_gnutls_push): Fix typo.
6081
6082 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6083
6084 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6085 "cast to pointer from integer of different size".
6086
6087 Improve doprnt and its use in verror. (Bug#8545)
6088 * doprnt.c (doprnt): Document the set of format control sequences
6089 supported by the function. Use SAFE_ALLOCA instead of always
6090 using `alloca'.
6091
6092 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6093 is one byte too soon. Don't use xrealloc; instead xfree and
6094 xmalloc anew.
6095
6096 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6097
6098 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6099 callbacks stage.
6100
6101 * gnutls.c: Renamed global_initialized to
6102 gnutls_global_initialized. Added internals for the
6103 :verify-hostname-error, :verify-error, and :verify-flags
6104 parameters of `gnutls-boot' and documented those parameters in the
6105 docstring. Start callback support.
6106 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6107 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6108 on error. Return error code.
6109 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6110 (emacs_gnutls_read): Likewise.
6111 (Fgnutls_boot): Return handshake error code.
6112 (emacs_gnutls_handle_error): New function.
6113 (wsaerror_to_errno): Likewise.
6114
6115 * w32.h (emacs_gnutls_pull): Add prototype.
6116 (emacs_gnutls_push): Likewise.
6117
6118 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6119 (emacs_gnutls_push): Likewise.
6120
6121 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6122
6123 * process.c (wait_reading_process_output): Check if GnuTLS
6124 buffered some data internally if no FDs are set for TLS
6125 connections.
6126
6127 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6128 (LIBS): Link to USER_LIBS.
6129 ($(BLD)/gnutls.$(0)): New target.
6130
6131 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6132
6133 * xdisp.c (handle_single_display_spec): Rename the
6134 display_replaced_before_p argument into display_replaced_p, to
6135 make it consistent with the commentary. Fix typos in the
6136 commentary.
6137
6138 * textprop.c (syms_of_textprop): Remove dead code.
6139 (copy_text_properties): Delete obsolete commentary about an
6140 interface that was deleted long ago. Fix typos in the description
6141 of arguments.
6142
6143 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6144 to changes in oldXMenu/XMenu.h from 2011-04-16.
6145 <menu_help_message, prev_menu_help_message>: Constify.
6146 (IT_menu_make_room): menu->help_text is now `const char **';
6147 adjust.
6148
6149 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6150 to changes in oldXMenu/XMenu.h from 2011-04-16.
6151 (struct XMenu): Declare `help_text' `const char **'.
6152
6153 * xfaces.c <Qunspecified>: Make extern again.
6154
6155 * syntax.c: Include sys/types.h before including regex.h, as
6156 required by Posix.
6157
6158 * doc.c (get_doc_string): Improve the format passed to `error'.
6159
6160 * doprnt.c (doprnt): Improve commentary.
6161
6162 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6163
6164 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6165 them with etags.
6166
6167 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6168 changes in globals.h immediately force recompilation.
6169 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6170 $(CURDIR)/s/ms-w32.h.
6171 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6172
6173 * character.c (Fchar_direction): Function deleted.
6174 (syms_of_character): Don't defsubr it.
6175 <char-direction-table>: Deleted.
6176
6177 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6178
6179 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6180 * doprnt.c: Include limits.h.
6181 (SIZE_MAX): New macro.
6182 (doprnt): Return a size_t value. 2nd arg is now size_t.
6183 Many local variables are now size_t instead of int or unsigned.
6184 Improve overflow protection. Support `l' modifier for integer
6185 conversions. Support %l conversion. Don't assume an EMACS_INT
6186 argument for integer conversions and for %c.
6187
6188 * lisp.h (doprnt): Restore prototype.
6189
6190 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6191 $(SRC)/character.h.
6192
6193 * Makefile.in (base_obj): Add back doprnt.o.
6194
6195 * deps.mk (doprnt.o): Add back prerequisites.
6196 (callint.o): Depend on character.h.
6197
6198 * eval.c (internal_lisp_condition_case): Include the handler
6199 representation in the error message.
6200 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6201 when breaking from the loop.
6202
6203 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6204
6205 * callint.c (Fcall_interactively): When displaying error message
6206 about invalid control letter, pass the character's codepoint, not
6207 a pointer to its multibyte form. Improve display of the character
6208 in octal and display also its hex code.
6209
6210 * character.c (char_string): Use %x to display the (unsigned)
6211 codepoint of an invalid character, to avoid displaying a bogus
6212 negative value.
6213
6214 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6215 `error', not SYMBOL_NAME itself.
6216
6217 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6218 character arguments to `error'.
6219
6220 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6221 to `error' in error message about FINAL_CHAR argument. Make sure
6222 FINAL_CHAR is a character, and use %c when it is passed as
6223 argument to `error'.
6224
6225 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6226
6227 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6228
6229 * w32.c: Include <time.h>.
6230 (sys_localtime): New function.
6231
6232 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6233
6234 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6235
6236 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6237
6238 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6239
6240 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6241 zombies (Bug#8467).
6242
6243 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6244
6245 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6246 gl_state.e_property when gl_state.object is Qt.
6247
6248 * insdel.c (make_gap_larger): Remove limitation of buffer size
6249 to <= INT_MAX.
6250
6251 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
6252
6253 * xdisp.c (lookup_glyphless_char_display)
6254 (produce_glyphless_glyph): Handle cons cell entry in
6255 glyphless-char-display.
6256 (Vglyphless_char_display): Document it.
6257
6258 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6259 glyphless-char-display.
6260
6261 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
6262
6263 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6264
6265 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6266
6267 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6268 definition for no-X builds.
6269
6270 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
6271
6272 Static checks with GCC 4.6.0 and non-default toolkits.
6273
6274 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6275
6276 * process.c (keyboard_bit_set): Define only if SIGIO.
6277 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6278 (send_process): Repair possible setjmp clobbering.
6279
6280 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6281
6282 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6283
6284 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6285
6286 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6287 Define only if needed.
6288
6289 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6290 by pacifying GCC about it. Maybe it's time to retire it?
6291 * xfaces.c (USG, __TIMEVAL__): Likewise.
6292
6293 * dispextern.h (struct redisplay_interface): Rename param
6294 to avoid shadowing.
6295 * termhooks.h (struct terminal): Likewise.
6296 * xterm.c (xembed_send_message): Likewise.
6297
6298 * insdel.c (make_gap_smaller): Define only if
6299 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6300
6301 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6302 it.
6303
6304 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6305 so that we aren't warned about unused symbols.
6306
6307 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6308
6309 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
6310
6311 * xfns.c (x_real_positions): Mark locals as initialized.
6312
6313 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6314
6315 * xterm.c: Fix problems found by static analysis with other toolkits.
6316 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
6317 (x_dispatch_event): Declare static if USE_GTK, and
6318 define if USE_GTK || USE_X_TOOLKIT.
6319 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
6320 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
6321 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6322 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
6323
6324 * xmenu.c (menu_help_callback): Pointer type fixes.
6325 Use const pointers when pointing at readonly data. Avoid pointer
6326 signedness clashes.
6327 (FALSE): Remove unused macro.
6328 (update_frame_menubar): Remove unused decl.
6329
6330 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6331
6332 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6333 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6334 (single_menu_item): Rename local to avoid shadowing.
6335
6336 * keyboard.c (make_lispy_event): Remove unused local var.
6337
6338 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6339 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6340
6341 * bitmaps: Change bitmaps from unsigned char back to the X11
6342 compatible char. Avoid the old compiler warnings about
6343 out-of-range initializers by using, for example, '\xab' rather
6344 than 0xab.
6345
6346 * xgselect.c (xgselect_initialize): Check vs interface
6347 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6348
6349 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6350
6351 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6352 to read-only memory.
6353
6354 * fns.c (vector): Remove; this old hack is no longer needed.
6355
6356 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
6357 Remove unused var.
6358 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
6359
6360 * xrdb.c (x_load_resources): Omit unused local.
6361
6362 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
6363 (x_window): Rename locals to avoid shadowing.
6364 (USG): Use the kludged USG macro, to pacify gcc.
6365
6366 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
6367 (x_term_init): Remove local to avoid shadowing.
6368
6369 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
6370
6371 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6372 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6373
6374 2011-04-16 Eli Zaretskii <eliz@gnu.org>
6375
6376 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6377
6378 Fix regex.c, syntax.c and friends for buffers > 2GB.
6379 * syntax.h (struct gl_state_s): Declare character position members
6380 EMACS_INT.
6381
6382 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6383
6384 * textprop.c (verify_interval_modification, interval_of):
6385 Declare arguments EMACS_INT.
6386
6387 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6388 EMACS_INT.
6389
6390 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6391
6392 * indent.c (Fvertical_motion): Local variable it_start is now
6393 EMACS_INT.
6394
6395 * regex.c (re_match, re_match_2, re_match_2_internal)
6396 (bcmp_translate, regcomp, regexec, print_double_string)
6397 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6398 (re_compile_pattern, re_exec): Declare arguments and local
6399 variables `size_t' and `ssize_t' and return values `regoff_t', as
6400 appropriate.
6401 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6402 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6403 <compile_stack_type>: `size' and `avail' are now `size_t'.
6404
6405 * regex.h <regoff_t>: Use ssize_t, not int.
6406 (re_search, re_search_2, re_match, re_match_2): Arguments that
6407 specify buffer/string position and length are now ssize_t and
6408 size_t. Return type is regoff_t.
6409
6410 2011-04-16 Ben Key <bkey76@gmail.com>
6411
6412 * nsfont.m: Fixed bugs in ns_get_family and
6413 ns_descriptor_to_entity that were caused by using free to
6414 deallocate memory blocks that were allocated by xmalloc (via
6415 xstrdup). This caused Emacs to crash when compiled with
6416 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6417 --enable-checking=xmallocoverrun). xfree is now used to
6418 deallocate these memory blocks.
6419
6420 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
6421
6422 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6423
6424 emacs_write: Accept and return EMACS_INT for sizes.
6425 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6426 et seq.
6427 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6428 Accept and return EMACS_INT.
6429 (emacs_gnutls_write): Return the number of bytes written on
6430 partial writes.
6431 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
6432 (emacs_read, emacs_write): Remove check for negative size, as the
6433 Emacs source code has been audited now.
6434 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6435 (emacs_read, emacs_write): Use it.
6436 * process.c (send_process): Adjust to the new signatures of
6437 emacs_write and emacs_gnutls_write. Do not attempt to store
6438 a byte offset into an 'int'; it might overflow.
6439 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
6440
6441 * sound.c: Don't assume sizes fit in 'int'.
6442 (struct sound_device.period_size, alsa_period_size):
6443 Return EMACS_INT, not int.
6444 (struct sound_device.write, vox_write, alsa_write):
6445 Accept EMACS_INT, not int.
6446 (wav_play, au_play): Use EMACS_INT to store sizes and to
6447 record read return values.
6448
6449 2011-04-15 Ben Key <bkey76@gmail.com>
6450
6451 * keyboard.c (Qundefined): Don't declare static since it is used
6452 in nsfns.m.
6453 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6454 static since they are used in nsfont.m.
6455
6456 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6457
6458 * process.c (Qprocessp): Don't declare static.
6459 * lisp.h (Qprocessp): Declare again.
6460
6461 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
6462
6463 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6464
6465 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6466
6467 Improve C-level modularity by making more things 'static'.
6468
6469 Don't publish debugger-only interfaces to other modules.
6470 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6471 (verify_bytepos, count_markers): Move decls to the only modules
6472 that need them.
6473 * region-cache.h (pp_cache): Likewise.
6474 * window.h (check_all_windows): Likewise.
6475 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6476
6477 * sysdep.c (croak): Now static, if
6478 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6479 * syssignal.h (croak): Declare only if not static.
6480
6481 * alloc.c (refill_memory_reserve): Now static if
6482 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6483 * lisp.h (refill_memory_reserve): Declare only if not static.
6484
6485 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6486 Define only if USE_LUCID.
6487
6488 * xrdb.c (x_customization_string, x_rm_string): Now static.
6489
6490 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6491 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6492
6493 * xdisp.c (draw_row_with_mouse_face): Now static.
6494 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6495
6496 * window.h (check_all_windows): Mark externally visible.
6497
6498 * window.c (window_deletion_count): Now static.
6499
6500 * undo.c: Make symbols static if they're not exported.
6501 (last_undo_buffer, last_boundary_position, pending_boundary):
6502 Now static.
6503
6504 * textprop.c (interval_insert_behind_hooks): Now static.
6505 (interval_insert_in_front_hooks): Likewise.
6506
6507 * term.c: Make symbols static if they're not exported.
6508 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6509 (max_frame_lines, tty_set_terminal_modes):
6510 (tty_reset_terminal_modes, tty_turn_off_highlight):
6511 (get_tty_terminal): Now static.
6512 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6513 * termhooks.h (term_mouse_moveto): Do not declare if
6514 HAVE_WINDOW_SYSTEM.
6515 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6516 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6517
6518 * sysdep.c: Make symbols static if they're not exported.
6519 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6520 Now static.
6521 (sigprocmask_set, full_mask): Remove; unused.
6522 (wait_debugging): Mark as visible.
6523 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6524 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6525
6526 * syntax.c (syntax_temp): Define only if !__GNUC__.
6527
6528 * sound.c (current_sound_device, current_sound): Now static.
6529
6530 * search.c (searchbufs, searchbuf_head): Now static.
6531
6532 * scroll.c (scroll_cost): Remove; unused.
6533 * dispextern.h (scroll_cost): Remove decl.
6534
6535 * region-cache.h (pp_cache): Mark as externally visible.
6536
6537 * process.c: Make symbols static if they're not exported.
6538 (process_tick, update_tick, create_process, chan_process):
6539 (Vprocess_alist, proc_buffered_char, datagram_access):
6540 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6541 (deactivate_process): Mark defn as static, as well as decl.
6542 * lisp.h (create_process): Remove decl.
6543 * process.h (chan_process, Vprocess_alist): Remove decls.
6544
6545 * print.c: Make symbols static if they're not exported.
6546 (print_depth, new_backquote_output, being_printed, print_buffer):
6547 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6548 (print_interval, print_number_index, initial_stderr_stream):
6549 Now static.
6550 * lisp.h (Fprinc): Remove decl.
6551 (debug_output_compilation_hack): Mark as externally visible.
6552
6553 * sysdep.c (croak): Move decl from here to syssignal.h.
6554 * syssignal.h (croak): Put it here, so the API can be checked when
6555 'croak' is called from dissociate_if_controlling_tty.
6556
6557 * minibuf.c: Make symbols static if they're not exported.
6558 (minibuf_save_list, choose_minibuf_frame): Now static.
6559 * lisp.h (choose_minibuf_frame): Remove decl.
6560
6561 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6562
6563 * lread.c: Make symbols static if they're not exported.
6564 (read_objects, initial_obarray, oblookup_last_bucket_number):
6565 Now static.
6566 (make_symbol): Remove; unused.
6567 * lisp.h (initial_obarray, make_symbol): Remove decls.
6568
6569 * keyboard.c: Make symbols static if they're not exported.
6570 (single_kboard, recent_keys_index, total_keys, recent_keys):
6571 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6572 (this_single_command_key_start, echoing, last_auto_save):
6573 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6574 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6575 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6576 (Vlispy_mouse_stem, double_click_count):
6577 Now static.
6578 (force_auto_save_soon): Define only if SIGDANGER.
6579 (ignore_mouse_drag_p): Now static if
6580 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6581 (print_help): Remove; unused.
6582 (stop_character, last_timer_event): Mark as externally visible.
6583 * keyboard.h (ignore_mouse_drag_p): Declare only if
6584 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6585 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6586 * lisp.h (echoing): Remove decl.
6587 (force_auto_save_soon): Declare only if SIGDANGER.
6588 * xdisp.c (redisplay_window): Simplify code, to make it more
6589 obvious that ignore_mouse_drag_p is not accessed if !defined
6590 USE_GTK && !defined HAVE_NS.
6591
6592 * intervals.c: Make symbols static if they're not exported.
6593 (merge_properties_sticky, merge_interval_right, delete_interval):
6594 Now static.
6595 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6596
6597 * insdel.c: Make symbols static if they're not exported.
6598 However, leave prepare_to_modify_buffer alone. It's never
6599 called from outside this function, but that appears to be a bug.
6600 (combine_after_change_list, combine_after_change_buffer):
6601 (adjust_after_replace, signal_before_change): Now static.
6602 (adjust_after_replace_noundo): Remove; unused.
6603 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
6604 (signal_before_change): Remove decls.
6605
6606 * indent.c (val_compute_motion, val_vmotion): Now static.
6607
6608 * image.c: Make symbols static if they're not exported.
6609 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6610 if USE_GTK.
6611 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6612 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6613
6614 * fringe.c (standard_bitmaps): Now static.
6615 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6616
6617 * frame.c: Make symbols static if they're not exported.
6618 (x_report_frame_params, make_terminal_frame): Now static.
6619 (get_frame_param): Now static, unless HAVE_NS.
6620 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6621 (x_get_resource_string): Remove; not used.
6622 * frame.h (make_terminal_frame, x_report_frame_params):
6623 (x_get_resource_string); Remove decls.
6624 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6625 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6626
6627 * font.c, fontset.c: Make symbols static if they're not exported.
6628 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6629 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6630 * font.c (font_close_object): Now static.
6631 * font.h (font_close_object): Remove.
6632 * fontset.c (FONTSET_OBJLIST): Remove.
6633 (free_realized_fontset) #if-0 the body, which does nothing.
6634 (face_suitable_for_char_p): #if-0, as it's never called.
6635 * fontset.h (face_suitable_for_char_p): Remove decl.
6636 * xfaces.c (face_at_string_position):
6637 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
6638 since 0 is always ASCII.
6639
6640 * fns.c (weak_hash_tables): Now static.
6641
6642 * fileio.c: Make symbols static if they're not exported.
6643 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6644 (Vwrite_region_annotation_buffers): Now static.
6645
6646 * eval.c: Make symbols static if they're not exported.
6647 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6648 * lisp.h (backtrace_list): Remove decl.
6649
6650 * emacs.c: Make symbols static if they're not exported.
6651 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6652 (fatal_error_code, fatal_error_signal_hook, standard_args):
6653 Now static.
6654 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6655 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6656 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6657 * lisp.h (fatal_error_signal_hook): Remove decl.
6658 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6659
6660 * editfns.c: Move a (normally-unused) function to its only use.
6661 * editfns.c, lisp.h (get_operating_system_release): Remove.
6662 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6663 worth the hassle of breaking this out.
6664
6665 * xterm.c: Make symbols static if they're not exported.
6666 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6667 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6668 (x_destroy_window, x_delete_display):
6669 Now static.
6670 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6671 (x_mouse_leave): Remove; unused.
6672 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6673 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6674 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6675 Remove decls.
6676 (x_mouse_leave): Declare only if WINDOWSNT.
6677 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6678 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6679 USE_X_TOOLKIT.
6680
6681 * ftxfont.c: Make symbols static if they're not exported.
6682 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6683 HAVE_FREETYPE.
6684 * font.h (ftxfont_driver): Likewise.
6685
6686 * xfns.c: Make symbols static if they're not exported.
6687 (x_last_font_name, x_display_info_for_name):
6688 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6689 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6690 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6691 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6692 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6693 (last_show_tip_args): Now static.
6694 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6695 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6696 (x_screen_planes): Remove; unused.
6697 * dispextern.h (x_screen_planes): Remove decl.
6698
6699 * dispnew.c: Make symbols static if they're not exported.
6700 * dispextern.h (redraw_garbaged_frames, scrolling):
6701 (increment_row_positions): Remove.
6702 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6703 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6704 Now static.
6705 (redraw_garbaged_frames): Remove; unused.
6706
6707 * xfaces.c: Make symbols static if they're not exported.
6708 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6709 Remove decls.
6710 * xterm.h (defined_color): Remove decls.
6711 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6712 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6713 (menu_face_changed_default, defined_color, free_realized_face):
6714 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6715 (ascii_face_of_lisp_face): Remove; unused.
6716
6717 * xdisp.c: Make symbols static if they're not exported.
6718 * dispextern.h (scratch_glyph_row, window_box_edges):
6719 (glyph_to_pixel_coords, set_cursor_from_row):
6720 (get_next_display_element, set_iterator_to_next):
6721 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6722 (show_mouse_face): Remove decls
6723 * frame.h (message_buf_print): Likewise.
6724 * lisp.h (pop_message, set_message, check_point_in_composition):
6725 Likewise.
6726 * xterm.h (set_vertical_scroll_bar): Likewise.
6727 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6728 (message_buf_print, scratch_glyph_row, displayed_buffer):
6729 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6730 (get_next_display_element, show_mouse_face, window_box_edges):
6731 (frame_to_window_pixel_xy, check_point_in_composition):
6732 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6733 (glyph_to_pixel_coords): Remove; unused.
6734
6735 * dired.c (file_name_completion): Now static.
6736
6737 * dbusbind.c (xd_in_read_queued_messages): Now static.
6738
6739 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6740 * data.c (circular_list_error): Remove.
6741
6742 * commands.h (last_point_position, last_point_position_buffer):
6743 (last_point_position_window): Remove decls.
6744 * keyboard.c: Make these variables static.
6745
6746 * coding.h (coding, code_convert_region, encode_coding_gap):
6747 Remove decls.
6748 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6749 (iso_code_class, detect_coding, code_convert_region): Now static.
6750 (encode_coding_gap): Remove; unused.
6751
6752 * chartab.c (chartab_chars, chartab_bits): Now static.
6753
6754 * charset.h (charset_iso_8859_1): Remove decl.
6755 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6756 Now static.
6757
6758 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6759 * ccl.c (Vccl_program_table): Now static.
6760 (check_ccl_update): Remove; unused.
6761
6762 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6763 * category.h: ... from here.
6764 * category.c (check_category_table, set_category_set): Now static.
6765
6766 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6767 * lisp.h: Remove these decls.
6768
6769 * buffer.c (buffer_count): Remove unused var.
6770
6771 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6772 so that it's not optimized away.
6773 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6774 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6775 exported only to the debugger.
6776
6777 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
6778 * atimer.h (run_all_atimers): Remove; not exported.
6779
6780 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6781 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6782 was inaccessible from Lisp.
6783 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6784 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6785
6786 alloc.c: Import and export fewer symbols, and remove unused items.
6787 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6788 is defined.
6789 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6790 it's not optimized away by whole-program optimization.
6791 (message_enable_multibyte, free_misc): Remove.
6792 (catchlist, handlerlist, mark_backtrace):
6793 Declare only if BYTE_MARK_STACK.
6794 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6795 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6796 (message_enable_multibyte): Remove decl.
6797 (free_misc, interval_free_list, float_block, float_block_index):
6798 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6799 (cons_free_list, last_marked_index):
6800 Now static.
6801 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6802 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6803 (mark_backtrace): Define only if BYTE_MARK_STACK.
6804 * xdisp.c (message_enable_multibyte): Now static.
6805
6806 Declare Lisp_Object Q* variables to be 'static' if not exported.
6807 This makes it easier for human readers (and static analyzers)
6808 to see whether these variables are used from other modules.
6809 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6810 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6811 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6812 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6813 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6814 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6815 * xmenu.c, xselect.c:
6816 Declare Q* vars static if they are not used in other modules.
6817 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6818 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6819 Remove decls of unexported vars.
6820 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6821
6822 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6823
6824 Make Emacs functions such as Fatom 'static' by default.
6825 This makes it easier for human readers (and static analyzers)
6826 to see whether these functions can be called from other modules.
6827 DEFUN now defines a static function. To make the function external
6828 so that it can be used in other C modules, use the new macro DEFUE.
6829 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6830 (Finit_image_library):
6831 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6832 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6833 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6834 Remove decls, since these functions are now static.
6835 (Funintern, Fget_internal_run_time): New decls, since these functions
6836 were already external.
6837
6838 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6839 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6840 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6841 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6842 * keyboard.c, keymap.c, lread.c:
6843 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6844 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6845 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6846 Mark functions with DEFUE instead of DEFUN,
6847 if they are used in other modules.
6848 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6849 decls for now-static functions.
6850 * buffer.h (Fdelete_overlay): Remove decl.
6851 * callproc.c (Fgetenv_internal): Mark as internal.
6852 * composite.c (Fremove_list_of_text_properties): Remove decl.
6853 (Fcomposition_get_gstring): New forward static decl.
6854 * composite.h (Fcomposite_get_gstring): Remove decl.
6855 * dired.c (Ffile_attributes): New forward static decl.
6856 * doc.c (Fdocumntation_property): New forward static decl.
6857 * eval.c (Ffetch_bytecode): New forward static decl.
6858 (Funintern): Remove extern decl; now in .h file where it belongs.
6859 * fileio.c (Fmake_symbolic_link): New forward static decl.
6860 * image.c (Finit_image_library): New forward static decl.
6861 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6862 * intervals.h (Fprevious_property_change):
6863 (Fremove_list_of_text_properties): Remove decls.
6864 * keyboard.c (Fthis_command_keys): Remove decl.
6865 (Fcommand_execute): New forward static decl.
6866 * keymap.c (Flookup_key): New forward static decl.
6867 (Fcopy_keymap): Now static.
6868 * keymap.h (Flookup_key): Remove decl.
6869 * process.c (Fget_process): New forward static decl.
6870 (Fprocess_datagram_address): Mark as internal.
6871 * syntax.c (Fsyntax_table_p): New forward static decl.
6872 (skip_chars): Remove duplicate decl.
6873 * textprop.c (Fprevious_property_change): New forward static decl.
6874 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6875 Now internal.
6876 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6877 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6878
6879 * editfns.c (Fformat): Remove unreachable code.
6880
6881 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6882
6883 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6884 change. (Bug#8496)
6885
6886 2011-04-13 Eli Zaretskii <eliz@gnu.org>
6887
6888 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6889 when at ZV. (Bug#8487)
6890
6891 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6892
6893 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6894 (Bug#8437)
6895 * keyboard.c (parse_tool_bar_item): Likewise.
6896 * sound.c (sound_cleanup, alsa_close): Likewise.
6897 * termcap.c (tgetent): Likewise.
6898 * xfns.c (x_default_font_parameter): Likewise.
6899 * xsettings.c (read_and_apply_settings): Likewise.
6900
6901 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6902 (overrun_check_free): Protoize.
6903
6904 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6905
6906 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6907 since callers should never pass a negative size.
6908 Change the signature to match that of plain 'read' and 'write'; see
6909 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6910 * lisp.h: Update prototypes of emacs_write and emacs_read.
6911
6912 2011-04-11 Eli Zaretskii <eliz@gnu.org>
6913
6914 * xdisp.c (redisplay_window): Don't try to determine the character
6915 position of the scroll margin if the window start point w->startp
6916 is outside the buffer's accessible region. (Bug#8468)
6917
6918 2011-04-10 Eli Zaretskii <eliz@gnu.org>
6919
6920 Fix write-region and its subroutines for buffers > 2GB.
6921 * fileio.c (a_write, e_write): Modify declaration of arguments and
6922 local variables to support buffers larger than 2GB.
6923 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6924
6925 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6926 argument, local variables, and return value.
6927
6928 * lisp.h: Update prototypes of emacs_write and emacs_read.
6929
6930 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6931
6932 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
6933
6934 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6935
6936 Fix more problems found by GCC 4.6.0's static checks.
6937
6938 * xdisp.c (vmessage): Use a better test for character truncation.
6939
6940 * charset.c (load_charset_map): <, not <=, for optimization,
6941 and to avoid potential problems with integer overflow.
6942 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
6943 * casetab.c (set_identity, shuffle): Likewise.
6944 * editfns.c (Fformat): Likewise.
6945 * syntax.c (skip_chars): Likewise.
6946
6947 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6948 This also lets GCC 4.6.0 generate slightly better loop code.
6949
6950 * callint.c (Fcall_interactively): <, not <=, for optimization.
6951 (Fcall_interactively): Count the number of arguments produced,
6952 not the number of arguments given. This is simpler and lets GCC
6953 4.6.0 generate slightly better code.
6954
6955 * ftfont.c: Distingish more carefully between FcChar8 and char.
6956 The previous code passed unsigned char * to a functions like
6957 strlen and xstrcasecmp that expect char *, which does not
6958 conform to the C standard.
6959 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6960 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6961 char * when the C standard requires it.
6962
6963 * keyboard.c (read_char): Remove unused var.
6964
6965 * eval.c: Port to Windows vsnprintf (Bug#8435).
6966 Include <limits.h>.
6967 (SIZE_MAX): Define if the headers do not.
6968 (verror): Do not give up if vsnprintf returns a negative count.
6969 Instead, grow the buffer. This ports to Windows vsnprintf, which
6970 does not conform to C99. Problem reported by Eli Zaretskii.
6971 Also, simplify the allocation scheme, by avoiding the need for
6972 calling realloc, and removing the ALLOCATED variable.
6973
6974 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6975
6976 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6977 But keep the doprint source code for now, as we might revamp it
6978 and use it again (Bug#8435).
6979 * lisp.h (doprnt): Remove.
6980 * Makefile.in (base_obj): Remove doprnt.o.
6981 * deps.mk (doprnt.o): Remove.
6982
6983 error: Print 32- and 64-bit integers portably (Bug#8435).
6984 Without this change, on typical 64-bit hosts error ("...%d...", N)
6985 was used to print both 32- and 64-bit integers N, which relied on
6986 undefined behavior.
6987 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6988 New macro.
6989 * lisp.h (error, verror): Mark as printf-like functions.
6990 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6991 Report overflow in size calculations when allocating printf buffer.
6992 Do not truncate output string at its first null byte.
6993 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6994 Truncate the output at a character boundary, since vsnprintf does not
6995 do that.
6996 * charset.c (check_iso_charset_parameter): Convert internal
6997 character to string before calling 'error', since %c now has the
6998 printf meaning.
6999 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7000 overflow when computing char to be passed to 'error'. Do not
7001 pass Lisp_Object to 'error'; pass the integer instead.
7002 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7003 formatted with plain %d.
7004
7005 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7006
7007 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7008
7009 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7010
7011 * xterm.c (x_catch_errors): Remove duplicate declaration.
7012
7013 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7014
7015 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7016
7017 2011-04-10 Jim Meyering <meyering@redhat.com>
7018
7019 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7020 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7021 return ssize_t not "int", and use size_t as the buffer length.
7022 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7023 * gnutls.h: Update declarations.
7024 * process.c (read_process_output): Use ssize_t, to match.
7025 (send_process): Likewise.
7026
7027 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7028
7029 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7030
7031 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7032
7033 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7034 Use unsigned char, to match FcChar8 type definition.
7035
7036 * xterm.c (handle_one_xevent):
7037 * xmenu.c (create_and_show_popup_menu):
7038 * xselect.c (x_decline_selection_request)
7039 (x_reply_selection_request): Avoid type-punned deref of X events.
7040
7041 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7042
7043 Fix some uses of `int' instead of EMACS_INT.
7044 * search.c (string_match_1, fast_string_match)
7045 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7046 (scan_buffer, find_next_newline_no_quit)
7047 (find_before_next_newline, search_command, Freplace_match)
7048 (Fmatch_data): Make some `int' variables be EMACS_INT.
7049
7050 * xdisp.c (display_count_lines): 3rd argument and return value now
7051 EMACS_INT. All callers changed.
7052 (pint2hrstr): Last argument is now EMACS_INT.
7053
7054 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7055 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7056 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7057 (decode_coding_utf_16, decode_coding_emacs_mule)
7058 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7059 (decode_coding_ccl, decode_coding_charset)
7060 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7061 (decode_coding_iso_2022, decode_coding_emacs_mule)
7062 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7063 <char_offset, last_offset>: Declare EMACS_INT.
7064 (encode_coding_utf_8, encode_coding_utf_16)
7065 (encode_coding_emacs_mule, encode_invocation_designation)
7066 (encode_designation_at_bol, encode_coding_iso_2022)
7067 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7068 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7069 Declare EMACS_INT.
7070 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7071 (encode_invocation_designation): Last argument P_NCHARS is now
7072 EMACS_INT.
7073 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7074 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7075
7076 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7077 All users changed.
7078
7079 * ccl.c (Fccl_execute_on_string): Declare some variables
7080 EMACS_INT.
7081
7082 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7083
7084 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7085
7086 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7087
7088 * process.c (Fformat_network_address): Doc fix.
7089
7090 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7091
7092 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7093
7094 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7095
7096 * keyboard.c (read_char): Call Lisp function help-form-show,
7097 instead of using internal_with_output_to_temp_buffer.
7098 (Qhelp_form_show): New var.
7099 (syms_of_keyboard): Use DEFSYM macro.
7100
7101 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7102
7103 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7104
7105 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7106
7107 * process.c (Flist_processes): Remove to Lisp.
7108 (list_processes_1): Delete.
7109
7110 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7111
7112 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7113
7114 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7115
7116 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7117
7118 Fix more problems found by GCC 4.6.0's static checks.
7119
7120 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7121
7122 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7123
7124 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7125
7126 * xdisp.c (vmessage): Mark as a printf-like function.
7127
7128 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7129
7130 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7131
7132 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7133 printf-like functions.
7134 (tiff_load): Add casts to remove these marks before passing them
7135 to system-supplied API.
7136
7137 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7138
7139 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7140 This avoids several warnings with gcc -Wstrict-overflow.
7141 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7142 directly, rather than having caller test rule sign. This avoids
7143 some unnecessary tests.
7144 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7145 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7146 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7147
7148 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7149 (xfont_open): Avoid unnecessary tests.
7150
7151 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7152
7153 * composite.h, composite.c (composition_gstring_put_cache):
7154 Use EMACS_INT, not int, for length.
7155
7156 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7157 breaking out part of COMPOSITION_DECODE_RULE.
7158 (COMPOSITION_DECODE_RULE): Use it.
7159 * composite.c (get_composition_id): Remove unused local vars,
7160 by using the new macro.
7161
7162 * textprop.c (set_text_properties_1): Change while to do-while,
7163 since the condition is always true at first.
7164
7165 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7166 (interval_deletion_adjustment): Return unsigned value.
7167 All uses changed.
7168
7169 * process.c (list_processes_1, create_pty, read_process_output):
7170 (exec_sentinel): Remove vars that were set but not used.
7171 (create_pty): Remove unnecessary "volatile"s.
7172 (Fnetwork_interface_info): Avoid possibility of int overflow.
7173 (read_process_output): Do adaptive read buffering even if carryover.
7174 (read_process_output): Simplify nbytes computation if buffered.
7175
7176 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7177
7178 * syntax.c (scan_words): Remove var that was set but not used.
7179 (update_syntax_table): Use unsigned instead of int.
7180
7181 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7182 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7183 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7184
7185 * print.c (print_error_message): Avoid int overflow.
7186
7187 * font.c (font_list_entities): Redo for clarity,
7188 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7189
7190 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7191 (font_score): Avoid potential overflow in diff calculation.
7192
7193 * fns.c (substring_both): Remove var that is set but not used.
7194 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7195
7196 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7197
7198 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7199 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7200 can always succeed if overflow has undefined behavior.
7201
7202 * search.c (boyer_moore, wordify): Remove vars set but not used.
7203 (wordify): Omit three unnecessary tests.
7204
7205 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7206 All callers changed. This avoids the need for an unused var.
7207
7208 * casefiddle.c (casify_region): Remove var that is set but not used.
7209
7210 * dired.c (file_name_completion): Remove var that is set but not used.
7211
7212 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7213
7214 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7215 (Finsert_file_contents): Remove unnecessary code checking fd.
7216
7217 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7218 Check for integer overflow on size calculations.
7219
7220 * buffer.c (Fprevious_overlay_change): Remove var that is set
7221 but not used.
7222
7223 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7224 Remove vars that are set but not used.
7225 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7226 (timer_check_2): Mark vars as initialized.
7227
7228 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7229
7230 * image.c (lookup_image): Remove var that is set but not used.
7231 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7232
7233 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7234 that are set but not used.
7235
7236 * xfns.c (make_invisible_cursor): Don't return garbage
7237 if XCreateBitmapFromData fails (Bug#8410).
7238
7239 * xselect.c (x_get_local_selection, x_handle_property_notify):
7240 Remove vars that are set but not used.
7241
7242 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7243 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7244
7245 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7246 Remove var that is set but not used.
7247 (scroll_bar_windows_size): Now size_t, not int.
7248 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7249 Check for overflow.
7250
7251 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7252 (map_tty_color) [!defined MSDOS]: Likewise.
7253
7254 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7255
7256 * coding.c: Remove vars that are set but not used.
7257 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7258 All callers changed.
7259 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7260 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7261 (decode_coding_charset): Remove vars that are set but not used.
7262
7263 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7264 that is set but not used.
7265
7266 * print.c (print_object): Remove var that is set but not used.
7267
7268 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
7269 The gnulib version avoids calling malloc in the usual case,
7270 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7271 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7272 * filelock.c (current_lock_owner): Likewise.
7273 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7274 * sysdep.c: Include allocator.h, careadlinkat.h.
7275 (emacs_no_realloc_allocator): New static constant.
7276 (emacs_readlink): New function.
7277 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7278 ../lib/careadlinkat.h.
7279
7280 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7281
7282 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7283 first non-nil return value).
7284
7285 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7286
7287 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7288 if not defined (Bug#8403).
7289
7290 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7291
7292 * xdisp.c (display_count_lines): Remove parameter `start',
7293 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7294 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7295 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7296 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7297 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7298 and thereabouts. All callers changed.
7299 (get_per_char_metric): Remove parameter `f', unused since
7300 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7301
7302 2011-04-02 Jim Meyering <meyering@redhat.com>
7303
7304 do not dereference NULL upon failed strdup
7305 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7306 (ns_get_family): Likewise.
7307
7308 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7309
7310 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7311
7312 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7313
7314 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7315 later (Bug#8403).
7316
7317 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7318
7319 Add lexical binding.
7320
7321 * window.c (Ftemp_output_buffer_show): New fun.
7322 (Fsave_window_excursion):
7323 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7324
7325 * lread.c (lisp_file_lexically_bound_p): New function.
7326 (Fload): Bind Qlexical_binding.
7327 (readevalloop): Remove `evalfun' arg.
7328 Bind Qinternal_interpreter_environment.
7329 (Feval_buffer): Bind Qlexical_binding.
7330 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7331 Mark as dynamic.
7332 (syms_of_lread): Declare `lexical-binding'.
7333
7334 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7335
7336 * keyboard.c (eval_dyn): New fun.
7337 (menu_item_eval_property): Use it.
7338
7339 * image.c (parse_image_spec): Use Ffunctionp.
7340
7341 * fns.c (concat, mapcar1): Accept byte-code-functions.
7342
7343 * eval.c (Fsetq): Handle lexical vars.
7344 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7345 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7346 (FletX, Flet): Obey lexical binding.
7347 (Fcommandp): Handle closures.
7348 (Feval): New `lexical' arg.
7349 (eval_sub): New function extracted from Feval. Use it almost
7350 everywhere where Feval was used. Look up vars in lexical env.
7351 Handle closures.
7352 (Ffunctionp): Move from subr.el.
7353 (Ffuncall): Handle closures.
7354 (apply_lambda): Remove `eval_flags'.
7355 (funcall_lambda): Handle closures and new byte-code-functions.
7356 (Fspecial_variable_p): New function.
7357 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7358 but without exporting it to Lisp.
7359
7360 * doc.c (Fdocumentation, store_function_docstring):
7361 * data.c (Finteractive_form): Handle closures.
7362
7363 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7364 interactive spec.
7365
7366 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7367 New byte-codes.
7368 (exec_byte_code): New function extracted from Fbyte_code to handle new
7369 calling convention for byte-code-functions. Add new byte-codes.
7370
7371 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
7372
7373 * alloc.c (Fmake_symbol): Init new `declared_special' field.
7374
7375 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7376
7377 * xdisp.c (redisplay_internal): Fix prototype.
7378
7379 2011-03-31 Eli Zaretskii <eliz@gnu.org>
7380
7381 * xdisp.c (SCROLL_LIMIT): New macro.
7382 (try_scrolling): Use it when setting scroll_limit.
7383 Limit scrolling to 100 screen lines.
7384 (redisplay_window): Even when falling back on "recentering",
7385 position point in the window according to scroll-conservatively,
7386 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7387
7388 (try_scrolling): When point is above the window, allow searching
7389 as far as scroll_max, or one screenful, to compute vertical
7390 distance from PT to the scroll margin position. This prevents
7391 try_scrolling from unnecessarily failing when
7392 scroll-conservatively is set to a value slightly larger than the
7393 window height. Clean up the case of PT below the margin at bottom
7394 of window: scroll_max can no longer be INT_MAX. When aggressive
7395 scrolling is in use, don't let point enter the opposite scroll
7396 margin as result of the scroll.
7397 (syms_of_xdisp) <scroll-conservatively>: Document the
7398 threshold of 100 lines for never-recentering scrolling.
7399
7400 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7401
7402 * dispextern.h (move_it_by_lines):
7403 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7404 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7405 (message_log_check_duplicate): Remove parameters `prev_bol' and
7406 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7407 (redisplay_internal): Remove parameter `preserve_echo_area',
7408 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7409
7410 * indent.c (Fvertical_motion):
7411 * window.c (window_scroll_pixel_based, Frecenter):
7412 Don't pass `need_y_p' to `move_it_by_lines'.
7413
7414 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7415
7416 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7417 steal a few bits to be more compact.
7418 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7419 Remove unneeded casts.
7420
7421 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7422
7423 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7424
7425 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7426 binding" message (bug#7967).
7427
7428 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7429
7430 Fix more problems found by GCC 4.6.0's static checks.
7431
7432 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7433 Remove unused local var.
7434
7435 * editfns.c (Fmessage_box): Remove unused local var.
7436
7437 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7438 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7439 Omit unused local vars.
7440 * window.c (shrink_windows): Omit unused local var.
7441 * menu.c (digest_single_submenu): Omit unused local var.
7442 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7443 Omit unused local var.
7444
7445 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7446 Don't assume string length fits in int.
7447 (keyremap_step, read_key_sequence): Use size_t for sizes.
7448 (read_key_sequence): Don't check last_real_key_start redundantly.
7449
7450 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7451 instead of alloca (Bug#8344).
7452
7453 * eval.c (Fbacktrace): Don't assume nargs fits in int.
7454 (Fbacktrace_frame): Don't assume nframes fits in int.
7455
7456 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7457
7458 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7459 concerns.
7460
7461 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7462
7463 * cm.c (calccost): Turn while-do into do-while, for clarity.
7464
7465 * keyboard.c (syms_of_keyboard): Use the same style as later
7466 in this function when indexing through an array. This also
7467 works around GCC bug 48267.
7468
7469 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7470
7471 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7472
7473 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7474 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7475
7476 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7477 This avoids undefined behavior on integer overflow, and is a bit
7478 more convenient anyway since it is compared to a size_t variable.
7479
7480 Variadic C functions now count arguments with size_t, not int.
7481 This avoids an unnecessary limitation on 64-bit machines, which
7482 caused (substring ...) to crash on large vectors (Bug#8344).
7483 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7484 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
7485 All variadic functions and their callers changed accordingly.
7486 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7487 * data.c (arith_driver, float_arith_driver): Likewise.
7488 * editfns.c (general_insert_function): Likewise.
7489 * eval.c (struct backtrace.nargs, interactive_p)
7490 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7491 (funcall_lambda, mark_backtrace): Likewise.
7492 * fns.c (concat): Likewise.
7493 * frame.c (x_set_frame_parameters): Likewise.
7494 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7495 0 if not found, not -1. All callers changed.
7496
7497 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7498 (stack_copy_size): Now size_t, not int.
7499 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7500
7501 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7502
7503 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7504 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7505 All callers changed.
7506
7507 * lisp.h (multibyte_char_to_unibyte):
7508 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7509 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7510 * character.h (CHAR_TO_BYTE8):
7511 * cmds.c (internal_self_insert):
7512 * editfns.c (general_insert_function):
7513 * keymap.c (push_key_description):
7514 * search.c (Freplace_match):
7515 * xdisp.c (message_dolog, set_message_1): All callers changed.
7516
7517 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7518
7519 * keyboard.c (safe_run_hook_funcall): New function.
7520 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7521 don't set the hook to nil, but remove the offending function instead.
7522 (Qcommand_hook_internal): Remove, unused.
7523 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7524 Vcommand_hook_internal.
7525
7526 * eval.c (enum run_hooks_condition): Remove.
7527 (funcall_nil, funcall_not): New functions.
7528 (run_hook_with_args): Call each function through a `funcall' argument.
7529 Remove `cond' argument, now redundant.
7530 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7531 (Frun_hook_with_args_until_failure): Adjust accordingly.
7532 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7533
7534 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7535
7536 * dispextern.h (string_buffer_position): Remove declaration.
7537
7538 * print.c (strout): Remove parameter `multibyte', unused since
7539 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7540
7541 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7542 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7543 All callers changed.
7544
7545 * w32.c (_wsa_errlist): Use braces for struct initializers.
7546
7547 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7548 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7549 All callers changed.
7550 (string_buffer_position): Likewise. Also, make static (it's never
7551 used outside xdisp.c).
7552 (cursor_row_p): Remove parameter `w', unused since
7553 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7554 (decode_mode_spec): Remove parameter `precision', introduced during
7555 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7556 All callers changed.
7557
7558 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7559
7560 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7561
7562 2011-03-27 Anders Lindgren <andlind@gmail.com>
7563
7564 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7565 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7566 (ns_update_auto_hide_menu_bar): New functions.
7567 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7568 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7569 ns_constrain_all_frames.
7570 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7571 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7572
7573 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7574
7575 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7576
7577 2011-03-27 Glenn Morris <rgm@gnu.org>
7578
7579 * syssignal.h: Replace RETSIGTYPE with void.
7580 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7581 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7582 Replace SIGTYPE with void everywhere.
7583 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7584 * s/template.h (SIGTYPE): Remove commented out definition.
7585
7586 2011-03-26 Eli Zaretskii <eliz@gnu.org>
7587
7588 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7589 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7590
7591 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
7592
7593 * w32.c (read_unc_volume): Use parameter `henum', instead of
7594 global variable `wget_enum_handle'.
7595
7596 * keymap.c (describe_vector): Remove parameters `indices' and
7597 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7598 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7599
7600 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7601
7602 * keyboard.c (timer_check): Remove parameter `do_it_now',
7603 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7604 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7605 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7606
7607 * keyboard.c (read_char):
7608 * w32menu.c (w32_menu_display_help):
7609 * xmenu.c (show_help_event, menu_help_callback):
7610 Adjust calls to `show_help_echo'.
7611
7612 * gtkutil.c (xg_maybe_add_timer):
7613 * keyboard.c (readable_events):
7614 * process.c (wait_reading_process_output):
7615 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7616
7617 * insdel.c (adjust_markers_gap_motion):
7618 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7619 (gap_left, gap_right): Don't call it.
7620
7621 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
7622
7623 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7624 incurred during fontification.
7625
7626 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7627
7628 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7629 (DEFVAR_PER_BUFFER): Don't pass it.
7630
7631 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7632 (scrolling_window): Don't pass it.
7633
7634 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7635
7636 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7637
7638 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7639 and `suffix'.
7640 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7641 of variables specific to SELinux and computation of `encoded_absname'.
7642
7643 * image.c (XPutPixel): Remove unused variable `height'.
7644
7645 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7646
7647 * unexw32.c (get_section_info): Remove unused variable `section'.
7648
7649 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7650 (system_process_attributes): Remove unused variable `sess'.
7651 (sys_read): Remove unused variable `err'.
7652
7653 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7654 (w32_wnd_proc): Remove unused variable `isdead'.
7655 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7656 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7657 (x_create_tip_frame): Remove unused variable `tem'.
7658
7659 * w32inevt.c (w32_console_read_socket):
7660 Remove unused variable `no_events'.
7661
7662 * w32term.c (x_draw_composite_glyph_string_foreground):
7663 Remove unused variable `width'.
7664
7665 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
7666
7667 * w32term.c (x_set_glyph_string_clipping):
7668 Don't pass uninitialized region to CombineRgn.
7669
7670 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
7671
7672 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7673 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7674 (Fx_close_connection): Remove unused variable `i'.
7675
7676 * w32font.c (w32font_draw): Return number of glyphs.
7677 (w32font_open_internal): Remove unused variable `i'.
7678 (w32font_driver): Add missing initializer.
7679
7680 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7681 (fill_in_menu): Remove unused variable `items_added'.
7682
7683 * w32term.c (last_mouse_press_frame): Remove static global variable.
7684 (w32_clip_to_row): Remove unused variable `f'.
7685 (x_delete_terminal): Remove unused variable `i'.
7686
7687 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7688 (NOTHING): Remove unused static global variable.
7689 (uniscribe_check_otf): Remove unused variable `table'.
7690 (uniscribe_font_driver): Add missing initializers.
7691
7692 2011-03-23 Julien Danjou <julien@danjou.info>
7693
7694 * term.c (Fsuspend_tty, Fresume_tty):
7695 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7696 * window.c (temp_output_buffer_show):
7697 * insdel.c (signal_before_change):
7698 * frame.c (Fhandle_switch_frame):
7699 * fileio.c (Fdo_auto_save):
7700 * emacs.c (Fkill_emacs):
7701 * editfns.c (save_excursion_restore):
7702 * cmds.c (internal_self_insert):
7703 * callint.c (Fcall_interactively):
7704 * buffer.c (Fkill_all_local_variables):
7705 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7706 Use Frun_hooks.
7707 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
7708 unconditionnaly since it does the check itself.
7709
7710 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
7711
7712 Fix more problems found by GCC 4.5.2's static checks.
7713
7714 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7715 the first time through the loop, since we know p0 < p1 then.
7716 This also avoids a gcc -Wstrict-overflow warning.
7717
7718 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7719 leading to a memory leak, possible in functions like
7720 load_charset_map_from_file that can allocate an unbounded number
7721 of objects (Bug#8318).
7722
7723 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7724 that could (at least in theory) be that large.
7725
7726 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7727 This is less likely to overflow, and avoids undefined behavior if
7728 overflow does occur. All callers changed. Use strtoul to scan
7729 for the unsigned long integer.
7730 (pint2hrstr): Simplify and tune code slightly.
7731 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
7732
7733 * scroll.c (do_scrolling): Work around GCC bug 48228.
7734 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7735
7736 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7737 This also avoids a warning with gcc -Wstrict-overflow.
7738 (validate_x_resource_name): Simplify count usage.
7739 This also avoids a warning with gcc -Wstrict-overflow.
7740
7741 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7742 fail (Bug#8306).
7743
7744 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
7745
7746 * process.c (Fmake_network_process): Use socklen_t, not int,
7747 where POSIX says socklen_t is required in portable programs.
7748 This fixes a porting bug on hosts like 64-bit HP-UX, where
7749 socklen_t is wider than int (Bug#8277).
7750 (Fmake_network_process, server_accept_connection):
7751 (wait_reading_process_output, read_process_output):
7752 Likewise.
7753
7754 * process.c: Rename or move locals to avoid shadowing.
7755 (list_processes_1, Fmake_network_process):
7756 (read_process_output_error_handler, exec_sentinel_error_handler):
7757 Rename or move locals.
7758 (Fmake_network_process): Define label "retry_connect" only if needed.
7759 (Fnetwork_interface_info): Fix pointer signedness.
7760 (process_send_signal): Add cast to avoid pointer signedness problem.
7761 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
7762 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
7763
7764 Make tparam.h and terminfo.c consistent.
7765 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7766 Include tparam.h instead, since it declares them.
7767 * cm.h (PC): Remove extern decl; tparam.h now does this.
7768 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7769 * terminfo.c: Include tparam.h, to check interfaces.
7770 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7771 (tparam): Adjust signature to match interface in tparam.h;
7772 this removes some undefined behavior. Check that outstring and len
7773 are zero, which they always are with Emacs.
7774 * tparam.h (PC, BC, UP): New extern decls.
7775
7776 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
7777 (xftfont_open): Rename locals to avoid shadowing.
7778
7779 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
7780 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7781 (OTF_TAG_SYM): Omit macro if not needed.
7782 (ftfont_list): Remove unused local.
7783 (get_adstyle_property, ftfont_pattern_entity):
7784 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7785 Rename locals to avoid shadowing.
7786
7787 * xfont.c (xfont_list_family): Mark var as initialized.
7788
7789 * xml.c (make_dom): Now static.
7790
7791 * composite.c (composition_compute_stop_pos): Rename local to
7792 avoid shadowing.
7793 (composition_reseat_it): Remove unused locals.
7794 (find_automatic_composition, composition_adjust_point): Likewise.
7795 (composition_update_it): Mark var as initialized.
7796 (find_automatic_composition): Mark vars as initialized,
7797 with a FIXME (Bug#8290).
7798
7799 character.h: Rename locals to avoid shadowing.
7800 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7801 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7802 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7803 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7804 to avoid shadowing.
7805
7806 * textprop.c (property_change_between_p): Remove; unused.
7807
7808 * intervals.c (interval_start_pos): Now static.
7809
7810 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7811
7812 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7813 Rename locals to avoid shadowing.
7814
7815 * sound.c (wav_play, au_play, Fplay_sound_internal):
7816 Fix pointer signedness.
7817 (alsa_choose_format): Remove unused local var.
7818 (wav_play): Initialize a variable to 0, to prevent undefined
7819 behavior (Bug#8278).
7820
7821 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7822
7823 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7824
7825 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7826 clobbering (Bug#8298).
7827 * sysdep.c (sys_subshell): Likewise.
7828 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7829
7830 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7831 This should get cleaned up, so that child_setup has the
7832 same signature on all platforms.
7833
7834 * callproc.c (call_process_cleanup): Now static.
7835 (relocate_fd): Rename locals to avoid shadowing.
7836
7837 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
7838
7839 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7840 not to be necessary, and produces flickering.
7841
7842 2011-03-20 Glenn Morris <rgm@gnu.org>
7843
7844 * config.in: Remove file.
7845
7846 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
7847
7848 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7849 are now in src/globals.h.
7850 (syms_of_minibuf): Remove spurious & from previous change.
7851
7852 2011-03-20 Leo <sdl.web@gmail.com>
7853
7854 * minibuf.c (completing-read-function): New variable.
7855 (completing-read-default): Rename from completing-read.
7856 (completing-read): Call completing-read-function.
7857
7858 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7859
7860 * xfaces.c (Fx_load_color_file):
7861 Read color file from absolute filename (bug#8250).
7862
7863 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7864
7865 * makefile.w32-in: Update dependencies.
7866
7867 2011-03-17 Eli Zaretskii <eliz@gnu.org>
7868
7869 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7870
7871 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7872
7873 Fix more problems found by GCC 4.5.2's static checks.
7874
7875 * process.c (make_serial_process_unwind, send_process_trap):
7876 (sigchld_handler): Now static.
7877
7878 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7879 That way, the code declares only the vars that it needs.
7880 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7881 * s/cygwin.h (PTY_ITERATION): Likewise.
7882 * s/darwin.h (PTY_ITERATION): Likewise.
7883 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7884
7885 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7886 * process.c (allocate_pty): Don't declare stb unless it's needed.
7887
7888 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
7889 (CONSTANTLIM): Remove; unused.
7890 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7891 Define only if needed.
7892
7893 * unexelf.c (unexec): Name an expression,
7894 to avoid gcc -Wbad-function-cast warning.
7895 Use a different way to cause a compilation error if anyone uses
7896 n rather than nn, a way that does not involve shadowing.
7897 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
7898
7899 * deps.mk (unexalpha.o): Remove; unused.
7900
7901 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7902 * unexec.h: New file.
7903 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7904 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7905 Depend on unexec.h.
7906 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7907 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7908 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
7909 Change as necessary to match prototype in unexec.h.
7910
7911 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7912 shadowing.
7913 (back_comment, skip_chars): Mark vars as initialized.
7914
7915 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7916 Rename locals to avoid shadowing.
7917
7918 * lread.c (read1): Rewrite so as not to use empty "else".
7919 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
7920
7921 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7922
7923 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7924 warning when compiling print.c.
7925
7926 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7927 instead of using an uninitialized var.
7928 (font_sort_entities): Mark var as initialized.
7929
7930 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7931
7932 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7933 pointers to constants.
7934 (font_parse_fcname): Remove unused vars.
7935 (font_delete_unmatched): Now static.
7936 (font_get_spec): Remove; unused.
7937 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7938 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7939 Rename or move locals to avoid shadowing.
7940
7941 * fns.c (require_nesting_list, require_unwind): Now static.
7942 (Ffillarray): Rename locals to avoid shadowing.
7943
7944 * floatfns.c (domain_error2): Define only if needed.
7945 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
7946
7947 * alloc.c (mark_backtrace): Move decl from here ...
7948 * lisp.h: ... to here, so that it can be checked.
7949
7950 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
7951 (Fdefvar): Rewrite so as not to use empty "else".
7952 (lisp_indirect_variable): Name an expression,
7953 to avoid gcc -Wbad-function-cast warning.
7954 (Fdefvar): Rename locals to avoid shadowing.
7955
7956 * callint.c (quotify_arg, quotify_args): Now static.
7957 (Fcall_interactively): Rename locals to avoid shadowing.
7958 Use const pointer when appropriate.
7959
7960 * lisp.h (get_system_name, get_operating_system_release):
7961 Move decls here, to check interfaces.
7962 * process.c (get_operating_system_release): Move decl to lisp.h.
7963 * xrdb.c (get_system_name): Likewise.
7964 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7965 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7966 some of which prompt warnings from gcc -Wbad-function-cast.
7967 (Fformat_time_string, Fencode_time, Finsert_char):
7968 (Ftranslate_region_internal, Fformat):
7969 Rename or remove local vars to avoid shadowing.
7970 (Ftranslate_region_internal): Mark var as initialized.
7971
7972 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7973 avoid shadowing.
7974
7975 * lisp.h (eassert): Check that the argument compiles, even if
7976 ENABLE_CHECKING is not defined.
7977
7978 * data.c (Findirect_variable): Name an expression, to avoid
7979 gcc -Wbad-function-cast warning.
7980 (default_value, arithcompare, arith_driver, arith_error): Now static.
7981 (store_symval_forwarding): Rename local to avoid shadowing.
7982 (Fmake_variable_buffer_local, Fmake_local_variable):
7983 Mark variables as initialized.
7984 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
7985
7986 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
7987 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7988 Rename locals to avoid shadowing.
7989 (mark_stack): Move local variables into the #ifdef region where
7990 they're used.
7991 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7992 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7993 needed otherwise.
7994 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7995 (GC_STRING_CHARS): Remove; not used.
7996 (Fmemory_limit): Cast sbrk's returned value to char *.
7997
7998 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7999 avoids undefined behavior in theory.
8000
8001 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8002
8003 Use functions, not macros, for up- and down-casing (Bug#8254).
8004 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8005 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8006 to use the following functions instead of these macros.
8007 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8008 EMACS_INT, since callers assume the returned value fits in int.
8009 (upcase1): Likewise, for UPCASE_TABLE.
8010 (uppercasep, lowercasep, upcase): New static inline functions.
8011 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8012 the race-condition problem in the old DOWNCASE.
8013
8014 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8015 Rename locals to avoid shadowing.
8016 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8017 (regex_compile, re_search_2, re_match_2_internal):
8018 Remove unused local vars.
8019 (FREE_VAR): Rewrite so as not to use empty "else",
8020 which gcc can warn about.
8021 (regex_compile, re_match_2_internal): Mark locals as initialized.
8022 (RETALLOC_IF): Define only if needed.
8023 (WORDCHAR_P): Likewise. This one is never needed, but is used
8024 only in a comment talking about a compiler bug, so put inside
8025 the #if 0 of that comment.
8026 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8027 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8028 Remove; unused.
8029
8030 * search.c (boyer_moore): Rename locals to avoid shadowing.
8031 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8032 (PREV_CHAR_BOUNDARY): Likewise.
8033
8034 * search.c (simple_search): Remove unused var.
8035
8036 * dired.c (compile_pattern): Move decl from here ...
8037 * lisp.h: ... to here, so that it can be checked.
8038 (struct re_registers): New forward decl.
8039
8040 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8041
8042 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8043 All uses changed.
8044 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8045 Rename locals to avoid shadowing.
8046 (Fvertical_motion): Mark locals as initialized.
8047
8048 * casefiddle.c (casify_object, casify_region): Now static.
8049 (casify_region): Mark local as initialized.
8050
8051 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8052
8053 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8054 New macros, so that the caller can use some names other than
8055 gcpro1, gcpro2, etc.
8056 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8057 of the new macros.
8058 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8059 argument, for consistency with GCPRO2_VAR, etc: it is now the
8060 prefix of the variable, not the variable itself. All uses
8061 changed.
8062 * dired.c (directory_files_internal, file_name_completion):
8063 Rename locals to avoid shadowing.
8064
8065 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8066 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8067 dired.c's scmp function, had undefined behavior.
8068 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8069 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8070 * buffer.h: ... to here, because these macros use current_buffer,
8071 and the new implementation with inline functions needs to have
8072 current_buffer in scope now, rather than later when the macros
8073 are used.
8074 (downcase, upcase1): New static inline functions.
8075 (DOWNCASE, UPCASE1): Reimplement using these functions.
8076 This avoids undefined behavior in expressions like
8077 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8078 from race conditions in accessing the global variables
8079 case_temp1 and case_temp2.
8080 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8081 * lisp.h (case_temp1, case_temp2): Remove their decls.
8082 * character.h (ASCII_CHAR_P): Move from here ...
8083 * lisp.h: ... to here, so that the inline functions mentioned
8084 above can use them.
8085
8086 * dired.c (directory_files_internal_unwind): Now static.
8087
8088 * fileio.c (file_name_as_directory, directory_file_name):
8089 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8090 Now static.
8091 (file_name_as_directory): Use const pointers when appropriate.
8092 (Fexpand_file_name): Likewise. In particular, newdir might
8093 point at constant storage, so make it a const pointer.
8094 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8095 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8096 signedness issues.
8097 (Fset_file_times, Finsert_file_contents, auto_save_error):
8098 Rename locals to avoid shadowing.
8099
8100 * minibuf.c (choose_minibuf_frame_1): Now static.
8101 (Ftry_completion, Fall_completions): Rename or remove locals
8102 to avoid shadowing.
8103
8104 * marker.c (bytepos_to_charpos): Remove; unused.
8105
8106 * lisp.h (verify_bytepos, count_markers): New decls,
8107 so that gcc does not warn that these functions aren't declared.
8108
8109 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8110 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8111 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8112 (copy_text): Remove unused local var.
8113
8114 * filelock.c (within_one_second): Now static.
8115 (lock_file_1): Rename local to avoid shadowing.
8116
8117 * buffer.c (fix_overlays_before): Mark locals as initialized.
8118 (fix_start_end_in_overlays): Likewise. This function should be
8119 simplified by using pointers-to-pointers, but that's a different
8120 matter.
8121 (switch_to_buffer_1): Now static.
8122 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8123 (report_overlay_modification): Rename locals to avoid shadowing.
8124
8125 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8126 Fix pointer signedness issue.
8127 (sys_subshell): Mark local as volatile if checking for lint,
8128 to suppress a gcc -Wclobbered warning that does not seem to be right.
8129 (MAXPATHLEN): Define only if needed.
8130
8131 * process.c (serial_open, serial_configure): Move decls from here ...
8132 * systty.h: ... to here, so that they can be checked.
8133
8134 * fns.c (get_random, seed_random): Move extern decls from here ...
8135 * lisp.h: ... to here, so that they can be checked.
8136
8137 * sysdep.c (reset_io): Now static.
8138 (wait_for_termination_signal): Remove; unused.
8139
8140 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8141 (copy_keymap_item, append_key, push_text_char_description):
8142 Now static.
8143 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8144 (DENSE_TABLE_SIZE): Remove; unused.
8145 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8146 (describe_map_tree):
8147 Rename locals to avoid shadowing.
8148
8149 * keyboard.c: Declare functions static if they are not used elsewhere.
8150 (echo_char, echo_dash, cmd_error, top_level_2):
8151 (poll_for_input, handle_async_input): Now static.
8152 (read_char, kbd_buffer_get_event, make_lispy_position):
8153 (make_lispy_event, make_lispy_movement, apply_modifiers):
8154 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8155 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8156 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8157 (read_key_sequence, read_char): Mark locals as initialized.
8158 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8159
8160 * keyboard.h (make_ctrl_char): New decl.
8161 (mark_kboards): Move decl here ...
8162 * alloc.c (mark_kboards): ... from here.
8163
8164 * lisp.h (force_auto_save_soon): New decl.
8165
8166 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8167 (DEFINE_DUMMY_FUNCTION): New macro.
8168 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8169 Use it.
8170 (main): Add casts to avoid warnings
8171 if GCC considers string literals to be constants.
8172
8173 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8174
8175 * dbusbind.c: Pointer signedness fixes.
8176 (xd_signature, xd_append_arg, xd_initialize):
8177 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8178 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8179 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8180 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8181
8182 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8183 if GCC considers string literals to be constants.
8184 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8185
8186 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8187
8188 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8189 (print_preprocess, print_object): New macro to fix last change.
8190
8191 * print.c (print_preprocess): Don't forget font objects.
8192
8193 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8194
8195 * emacs.c (USAGE3): Doc fixes.
8196
8197 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8198
8199 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8200 structure.
8201
8202 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8203
8204 * lisp.h (VWindow_system, Qfile_name_history):
8205 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8206 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8207 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8208
8209 * w32select.c: Don't #include "keyboard.h".
8210 (run_protected): Add extern declaration for waiting_for_input.
8211
8212 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8213 * w32console.c (detect_input_pending, read_input_pending)
8214 (encode_terminal_code):
8215 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8216 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8217 (w32_system_caret_y, Qfile_name_history):
8218 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8219 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8220 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8221 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8222 * w32proc.c (Qlocal, report_file_error):
8223 * w32term.c (Vwindow_system, updating_frame):
8224 * w32uniscribe.c (initialized, uniscribe_font_driver):
8225 Remove unneeded extern declarations.
8226
8227 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8228
8229 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8230
8231 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8232
8233 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8234 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8235 These macros can no longer be used for assignment.
8236
8237 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8238 Assign struct members directly, instead of using BUF_BEGV etc.
8239 (record_buffer_markers, fetch_buffer_markers): New functions for
8240 recording and fetching special buffer markers.
8241 (set_buffer_internal_1, set_buffer_temp): Use them.
8242
8243 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8244
8245 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8246
8247 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8248 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8249
8250 * xdisp.c (hscroll_window_tree):
8251 (reconsider_clip_changes): Use PT instead of BUF_PT.
8252
8253 2011-03-13 Eli Zaretskii <eliz@gnu.org>
8254
8255 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8256 $(EMACS_ROOT)/lib/intprops.h.
8257
8258 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8259
8260 Fix more problems found by GCC 4.5.2's static checks.
8261
8262 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8263 to unsigned char * to avoid compiler diagnostic.
8264 (xg_free_frame_widgets): Make it clear that a local variable is
8265 needed only if USE_GTK_TOOLTIP.
8266 (gdk_window_get_screen): Make it clear that this macro is needed
8267 only if USE_GTK_TOOLTIP.
8268 (int_gtk_range_get_value): New function, which avoids a diagnostic
8269 from gcc -Wbad-function-cast.
8270 (xg_set_toolkit_scroll_bar_thumb): Use it.
8271 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8272 diagnostic from gcc -Wbad-function-cast.
8273 (get_utf8_string, xg_get_file_with_chooser):
8274 Rename locals to avoid shadowing.
8275 (create_dialog): Move locals to avoid shadowing.
8276
8277 * xgselect.c (xg_select): Remove unused var.
8278
8279 * image.c (four_corners_best): Mark locals as initialized.
8280 (gif_load): Initialize transparent_p to zero (Bug#8238).
8281 Mark another local as initialized.
8282 (my_png_error, my_error_exit): Mark with NO_RETURN.
8283
8284 * image.c (clear_image_cache): Now static.
8285 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
8286 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
8287 (x_edge_detection): Remove unnecessary cast that
8288 gcc -Wbad-function-cast diagnoses.
8289 (gif_load): Fix pointer signedness.
8290 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8291 (jpeg_load, gif_load): Rename locals to avoid shadowing.
8292
8293 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
8294
8295 Improve quality of tests for time stamp overflow.
8296 For example, without this patch (encode-time 0 0 0 1 1
8297 1152921504606846976) returns the obviously-bogus value (-948597
8298 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8299 reports time overflow. See
8300 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
8301 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8302 * editfns.c: Include limits.h and intprops.h.
8303 (TIME_T_MIN, TIME_T_MAX): New macros.
8304 (time_overflow): Move earlier, to before first use.
8305 (hi_time, lo_time): New functions, for an accurate test for
8306 out-of-range times.
8307 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8308 (Fget_internal_run_time): Don't assume time_t fits in int.
8309 (make_time): Use list2 instead of Fcons twice.
8310 (Fdecode_time): More accurate test for out-of-range times.
8311 (check_tm_member): New function.
8312 (Fencode_time): Use it, to test for out-of-range times.
8313 (lisp_time_argument): Don't rely on undefined left-shift and
8314 right-shift behavior when checking for time stamp overflow.
8315
8316 * editfns.c (time_overflow): New function, refactoring common code.
8317 (Fformat_time_string, Fdecode_time, Fencode_time):
8318 (Fcurrent_time_string): Use it.
8319
8320 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8321 * dired.c (make_time): Move to ...
8322 * editfns.c (make_time): ... here.
8323 * systime.h: Note the move.
8324
8325 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8326
8327 * fringe.c (update_window_fringes): Remove unused variables.
8328
8329 * unexmacosx.c (copy_data_segment): Also copy __got section.
8330 (Bug#8223)
8331
8332 2011-03-12 Eli Zaretskii <eliz@gnu.org>
8333
8334 * termcap.c [MSDOS]: Include "msdos.h".
8335 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8336 Constify `char *' arguments and their references according to
8337 prototypes in tparam.h.
8338
8339 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
8340
8341 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8342 Adapt all references accordingly.
8343
8344 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8345
8346 2011-03-11 Tom Tromey <tromey@redhat.com>
8347
8348 * buffer.c (syms_of_buffer): Remove obsolete comment.
8349
8350 2011-03-11 Eli Zaretskii <eliz@gnu.org>
8351
8352 * termhooks.h (encode_terminal_code): Declare prototype.
8353
8354 * msdos.c (encode_terminal_code): Don't declare prototype.
8355
8356 * term.c (encode_terminal_code): Now external again, used by
8357 w32console.c and msdos.c.
8358
8359 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8360 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
8361
8362 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
8363
8364 Fix some minor problems found by GCC 4.5.2's static checks.
8365
8366 * fringe.c (update_window_fringes): Mark locals as initialized
8367 (Bug#8227).
8368 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
8369
8370 * alloc.c (mark_fringe_data): Move decl from here ...
8371 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8372 to check its interface.
8373 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8374
8375 * fontset.c (free_realized_fontset): Now static.
8376 (Fset_fontset_font): Rename local to avoid shadowing.
8377 (fontset_font): Mark local as initialized.
8378 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
8379
8380 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8381
8382 * xselect.c (x_disown_buffer_selections): Remove; not used.
8383 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
8384 (x_own_selection, Fx_disown_selection_internal): Rename locals
8385 to avoid shadowing.
8386 (x_handle_dnd_message): Remove local to avoid shadowing.
8387
8388 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8389 so that the caller can use some name other than gcpro1.
8390 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
8391 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8392 (Fx_backspace_delete_keys_p):
8393 Use them to avoid shadowing, and rename vars to avoid shadowing.
8394 (x_decode_color, x_set_name, x_window): Now static.
8395 (Fx_create_frame): Add braces to silence GCC warning.
8396 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
8397 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8398 Remove unused locals.
8399 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8400 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8401 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8402 macros.
8403
8404 * xterm.h (x_mouse_leave): New decl.
8405
8406 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8407 Remove unused functions.
8408 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8409 (x_calc_absolute_position): Now static.
8410 (XTread_socket): Don't define label "out" unless it's used.
8411 Don't declare local "event" unless it's used.
8412 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8413 unless they are used.
8414 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8415 (x_fatal_error_signal): Remove; not used.
8416 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8417 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8418 (x_error_catcher, x_connection_closed, x_error_handler):
8419 (x_error_quitter, xembed_send_message, x_iconify_frame):
8420 (my_log_handler): Rename locals to avoid shadowing.
8421 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
8422 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
8423
8424 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8425 Rename or move locals to avoid shadowing.
8426 (tty_defined_color, merge_face_heights): Now static.
8427 (free_realized_faces_for_fontset): Remove; not used.
8428 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8429 does not deduce is never used uninitialized.
8430 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8431 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
8432
8433 * terminal.c (store_terminal_param): Now static.
8434
8435 * xmenu.c (menu_highlight_callback): Now static.
8436 (set_frame_menubar): Remove unused local.
8437 (xmenu_show): Rename parameter to avoid shadowing.
8438 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8439 since they might point to immutable storage.
8440 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8441 since it's unused otherwise.
8442
8443 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
8444 Add a FIXME, since the code still doesn't look right. (Bug#8215)
8445 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8446 avoids a gcc -Wuninitialized diagnostic.
8447 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
8448 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8449 does not deduce are never used uninitialized.
8450
8451 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8452
8453 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
8454 * window.c (window_loop, size_window):
8455 (run_window_configuration_change_hook, enlarge_window): Likewise.
8456
8457 * window.c (display_buffer): Now static.
8458 (size_window): Mark variables that gcc -Wuninitialized
8459 does not deduce are never used uninitialized.
8460 * window.h (check_all_windows): New decl, to forestall
8461 gcc -Wmissing-prototypes diagnostic.
8462 * dispextern.h (bidi_dump_cached_states): Likewise.
8463
8464 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8465 shadowing.
8466 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
8467 Include <limits.h>.
8468 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8469 and to avoid gcc -Wuninitialized warning.
8470 (load_charset_map): Mark variables that gcc -Wuninitialized
8471 does not deduce are never used uninitialized.
8472 (load_charset): Abort instead of using uninitialized var (Bug#8229).
8473
8474 * coding.c (coding_set_source, coding_set_destination):
8475 Use "else { /* comment */ }" rather than "else /* comment */;"
8476 for clarity, and to avoid gcc -Wempty-body warning.
8477 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8478 a block, when the outer 'i' will do.
8479 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8480 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8481 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8482 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8483 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8484 Rename locals to avoid shadowing.
8485 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
8486 * coding.c (emacs_mule_char, encode_invocation_designation):
8487 Now static, since they're not used elsewhere.
8488 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
8489 (decode_coding_object, encode_coding_object, detect_coding_system):
8490 (decode_coding_emacs_mule): Mark variables that gcc
8491 -Wuninitialized does not deduce are never used uninitialized.
8492 (detect_coding_iso_2022): Initialize a local variable that might
8493 be used uninitialized. Leave a FIXME because it's not clear that
8494 this initialization is needed. (Bug#8211)
8495 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8496 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8497 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8498 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8499 Remove unused macros.
8500
8501 * category.c (hash_get_category_set): Remove unused local var.
8502 (copy_category_table): Now static, since it's not used elsewhere.
8503 * character.c (string_count_byte8): Likewise.
8504
8505 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8506 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8507
8508 * chartab.c (copy_sub_char_table): Now static, since it's not used
8509 elsewhere.
8510 (sub_char_table_ref_and_range, char_table_ref_and_range):
8511 Rename locals to avoid shadowing.
8512 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
8513
8514 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
8515 (BIDI_BOB): Remove unused macro.
8516
8517 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8518 deduce are never used uninitialized.
8519 * term.c (encode_terminal_code): Likewise.
8520
8521 * term.c (encode_terminal_code): Now static. Remove unused local.
8522
8523 * tparam.h: New file.
8524 * term.c, tparam.h: Include it.
8525 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8526 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8527 Move these decls to tparam.h, and make them agree with what
8528 is actually in tparam.c. The previous trick of using incompatible
8529 decls in different modules does not conform to the C standard.
8530 All callers of tparam changed to use tparam's actual API.
8531 * tparam.c (tparam1, tparam, tgoto):
8532 Use const pointers where appropriate.
8533
8534 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8535 * cm.h (struct cm): Likewise.
8536 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8537 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8538 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8539 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8540 (turn_on_face, init_tty): Likewise.
8541 * termchar.h (struct tty_display_info): Likewise.
8542
8543 * term.c (term_mouse_position): Rename local to avoid shadowing.
8544
8545 * alloc.c (mark_ttys): Move decl from here ...
8546 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8547
8548 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8549
8550 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8551
8552 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
8553
8554 * search.c (compile_pattern_1): Remove argument regp, unused since
8555 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8556 (compile_pattern): Don't pass it.
8557
8558 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8559
8560 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8561 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8562 for ! HAVE_GTK3.
8563 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8564
8565 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8566
8567 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8568 gdk_window_get_screen, gdk_window_get_geometry,
8569 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8570 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8571 (xg_get_pixbuf_from_pixmap): New function.
8572 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8573 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8574 Call xg_get_pixbuf_from_pixmap instead of
8575 gdk_pixbuf_get_from_drawable.
8576 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8577 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8578 (xg_check_special_colors): Use GtkStyleContext and its functions
8579 for HAVE_GTK3.
8580 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8581 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8582 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
8583 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8584 Call gtk_widget_get_preferred_size.
8585 (xg_frame_resized): gdk_window_get_geometry only takes 5
8586 parameters.
8587 (xg_win_to_widget, xg_event_is_for_menubar):
8588 Call gdk_x11_window_lookup_for_display.
8589 (xg_set_widget_bg): New function.
8590 (delete_cb): New function.
8591 (xg_create_frame_widgets): Connect delete-event to delete_cb.
8592 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8593 (xg_set_background_color): Call xg_set_widget_bg.
8594 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8595 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8596 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8597 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8598 if ! HAVE_GTK3.
8599 (update_frame_tool_bar): Call gtk_widget_hide.
8600 (xg_initialize): Use GDK_KEY_g.
8601
8602 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8603 if ! HAVE_GTK3
8604 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8605
8606 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8607 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8608 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8609
8610 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
8611
8612 * w32xfns.c (select_palette): Check success of RealizePalette against
8613 GDI_ERROR, not zero.
8614
8615 See ChangeLog.11 for earlier changes.
8616
8617 ;; Local Variables:
8618 ;; coding: utf-8
8619 ;; End:
8620
8621 Copyright (C) 2011 Free Software Foundation, Inc.
8622
8623 This file is part of GNU Emacs.
8624
8625 GNU Emacs is free software: you can redistribute it and/or modify
8626 it under the terms of the GNU General Public License as published by
8627 the Free Software Foundation, either version 3 of the License, or
8628 (at your option) any later version.
8629
8630 GNU Emacs is distributed in the hope that it will be useful,
8631 but WITHOUT ANY WARRANTY; without even the implied warranty of
8632 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8633 GNU General Public License for more details.
8634
8635 You should have received a copy of the GNU General Public License
8636 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.