* lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
[bpt/emacs.git] / src / ChangeLog
1 2011-06-19 Paul Eggert <eggert@cs.ucla.edu>
2
3 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4 This didn't break anything, but it didn't help either.
5 It's confusing to put a bogus integer in a place where the actual
6 value does not matter.
7
8 2011-06-18 Paul Eggert <eggert@cs.ucla.edu>
9
10 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
11 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
12 implementation.
13 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
14 We prefer signed types, and the value cannot exceed the EMACS_INT
15 range anyway (because otherwise the length would not be representable).
16 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
17 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
18 This avoids a GCC warning when WIDE_EMACS_INT.
19
20 * indent.c (sane_tab_width): New function.
21 (current_column, scan_for_column, Findent_to, position_indentation)
22 (compute_motion): Use it. This is just for clarity.
23 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
24
25 * image.c (xbm_image_p): Don't assume stated width and height fit in int.
26
27 * lisp.h (lint_assume): New macro.
28 * composite.c (composition_gstring_put_cache):
29 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
30
31 * editfns.c, insdel.c:
32 Omit unnecessary forward decls, to simplify future changes.
33
34 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
35
36 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
37
38 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
39 Use much-faster test for byte-length change.
40 Don't assume string byte-length fits in 'int'.
41 Check that character arg fits in 'int'.
42 (mapcar1): Declare byte as byte, for clarity.
43
44 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
45
46 * fns.c (concat): Catch string overflow earlier.
47 Do not rely on integer wraparound.
48
49 * dispextern.h (struct it.overlay_strings_charpos): EMACS_INT, not int.
50
51 2011-06-17 Paul Eggert <eggert@cs.ucla.edu>
52
53 * dispextern.h (struct it.selective): Now EMACS_INT, not int.
54 * xdisp.c (forward_to_next_line_start)
55 (back_to_previous_visible_line_start)
56 (reseat_at_next_visible_line_start, next_element_from_buffer):
57 Don't arbitrarily truncate the value of 'selective' to int.
58
59 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
60
61 * composite.c: Don't truncate sizes to 'int'.
62 (composition_gstring_p, composition_reseat_it)
63 (composition_adjust_point): Use EMACS_INT, not int.
64 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
65 not EMACS_UINT, for indexes.
66
67 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
68
69 * buffer.c: Include <verify.h>.
70 (struct sortvec.priority, struct sortstr.priority):
71 Now EMACS_INT, not int.
72 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
73 (struct sortstr.size, record_overlay_string)
74 (struct sortstrlist.size, struct sortlist.used):
75 Don't truncate size to int.
76 (record_overlay_string): Check for size-calculation overflow.
77 (init_buffer_once): Check at compile-time, not run-time.
78
79 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
80
81 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
82 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
83 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
84
85 Improve buffer-overflow checking (Bug#8873).
86 * fileio.c (Finsert_file_contents):
87 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
88 Remove the old (too-loose) buffer overflow checks.
89 They weren't needed, since make_gap checks for buffer overflow.
90 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
91 The old code merely checked for Emacs fixnum overflow, and relied
92 on undefined (wraparound) behavior. The new code avoids undefined
93 behavior, and also checks for ptrdiff_t and/or size_t overflow.
94
95 * editfns.c (Finsert_char): Don't dump core with very negative counts.
96 Tune. Don't use wider integers than needed. Don't use alloca.
97 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
98
99 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
100
101 * insdel.c, lisp.h (buffer_overflow): New function.
102 (insert_from_buffer_1, replace_range, replace_range_2):
103 * insdel.c (make_gap_larger):
104 * editfns.c (Finsert_char):
105 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
106
107 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
108
109 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
110
111 Integer overflow and signedness fixes (Bug#8873).
112
113 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
114 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
115
116 * fileio.c: Don't assume EMACS_INT fits in off_t.
117 (emacs_lseek): New static function.
118 (Finsert_file_contents, Fwrite_region): Use it.
119 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
120
121 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
122
123 * fns.c: Don't overflow int when computing a list length.
124 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
125 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
126 truncation on 64-bit hosts. Check for QUIT every
127 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
128 faster and is responsive enough.
129 (Flength): Report an error instead of overflowing an integer.
130 (Fsafe_length): Return a float if the value is not representable
131 as a fixnum. This shouldn't happen except in contrived situations.
132 (Fnthcdr, Fsort): Don't assume list length fits in int.
133 (Fcopy_sequence): Don't assume vector length fits in int.
134
135 * alloc.c: Check that resized vectors' lengths fit in fixnums.
136 (header_size, word_size): New constants.
137 (allocate_vectorlike): Don't check size overflow here.
138 (allocate_vector): Check it here instead, since this is the only
139 caller of allocate_vectorlike that could cause overflow.
140 Check that the new vector's length is representable as a fixnum.
141
142 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
143 The previous code was bogus. For example, next_almost_prime (32)
144 returned 39, which is undesirable as it is a multiple of 3; and
145 next_almost_prime (24) returned 25, which is a multiple of 5 so
146 why was the code bothering to check for multiples of 7?
147
148 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
149
150 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
151
152 Variadic C functions now count arguments with ptrdiff_t.
153 This partly undoes my 2011-03-30 change, which replaced int with size_t.
154 Back then I didn't know that the Emacs coding style prefers signed int.
155 Also, in the meantime I found a few more instances where arguments
156 were being counted with int, which may truncate counts on 64-bit
157 machines, or EMACS_INT, which may be unnecessarily wide.
158 * lisp.h (struct Lisp_Subr.function.aMANY)
159 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
160 Arg counts are now ptrdiff_t, not size_t.
161 All variadic functions and their callers changed accordingly.
162 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
163 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
164 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
165 * callint.c (Fcall_interactively): Check arg count for overflow,
166 to avoid potential buffer overrun. Use signed char, not 'int',
167 for 'varies' array, so that we needn't bother to check its size
168 calculation for overflow.
169 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
170 * eval.c (apply_lambda):
171 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
172 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
173 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
174
175 * callint.c (Fcall_interactively): Don't use index var as event count.
176
177 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
178 * mem-limits.h (SIZE): Remove; no longer used.
179
180 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
181
182 Remove unnecessary casts.
183 * xterm.c (x_term_init):
184 * xfns.c (x_set_border_pixel):
185 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
186 These aren't needed now that we assume ANSI C.
187
188 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
189 It's more likely to cause problems (due to unsigned overflow)
190 than to cure them.
191
192 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
193
194 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
195
196 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
197
198 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
199
200 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
201
202 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
203
204 GLYPH_CODE_FACE returns EMACS_INT, not int.
205 * dispextern.h (merge_faces):
206 * xfaces.c (merge_faces):
207 * xdisp.c (get_next_display_element, next_element_from_display_vector):
208 Don't assume EMACS_INT fits in int.
209
210 * character.h (CHAR_VALID_P): Remove unused parameter.
211 * fontset.c, lisp.h, xdisp.c: All uses changed.
212
213 * editfns.c (Ftranslate_region_internal): Omit redundant test.
214
215 * fns.c (concat): Minor tuning based on overflow analysis.
216 This doesn't fix any bugs. Use int to hold character, instead
217 of constantly refetching from Emacs object. Use XFASTINT, not
218 XINT, for value known to be a character. Don't bother comparing
219 a single byte to 0400, as it's always less.
220
221 * floatfns.c (Fexpt):
222 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
223
224 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
225 for characters.
226
227 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
228
229 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
230 Without this fix, on a 64-bit host (aset S 0 4294967386) would
231 incorrectly succeed when S was a string, because 4294967386 was
232 truncated before it was used.
233
234 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
235 Otherwise, an out-of-range integer could cause undefined behavior
236 on a 64-bit host.
237
238 * composite.c: Use int, not EMACS_INT, for characters.
239 (fill_gstring_body, composition_compute_stop_pos): Use int, not
240 EMACS_INT, for values that are known to be in character range.
241 This doesn't fix any bugs but is the usual style inside Emacs and
242 may generate better code on 32-bit machines.
243
244 Make sure a 64-bit char is never passed to ENCODE_CHAR.
245 This is for reasons similar to the recent CHAR_STRING fix.
246 * charset.c (Fencode_char): Check that character arg is actually
247 a character. Pass an int to ENCODE_CHAR.
248 * charset.h (ENCODE_CHAR): Verify that the character argument is no
249 wider than 'int', as a compile-time check to prevent future regressions
250 in this area.
251
252 * character.c (char_string): Remove unnecessary casts.
253
254 Make sure a 64-bit char is never passed to CHAR_STRING.
255 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
256 by silently ignoring the top 32 bits, allowing some values
257 that were far too large to be valid characters.
258 * character.h: Include <verify.h>.
259 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
260 arguments are no wider than unsigned, as a compile-time check
261 to prevent future regressions in this area.
262 * data.c (Faset):
263 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
264 (Fsubst_char_in_region):
265 * fns.c (concat):
266 * xdisp.c (decode_mode_spec_coding):
267 Adjust to CHAR_STRING's new requirement.
268 * editfns.c (Finsert_char, Fsubst_char_in_region):
269 * fns.c (concat): Check that character args are actually
270 characters. Without this test, these functions did the wrong
271 thing with wildly out-of-range values on 64-bit hosts.
272
273 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
274 These casts should not be needed on 32-bit hosts, either.
275 * keyboard.c (read_char):
276 * lread.c (Fload): Remove casts to unsigned.
277
278 * lisp.h (UNSIGNED_CMP): New macro.
279 This fixes comparison bugs on 64-bit hosts.
280 (ASCII_CHAR_P): Use it.
281 * casefiddle.c (casify_object):
282 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
283 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
284 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
285 * dispextern.h (FACE_FROM_ID):
286 * keyboard.c (read_char): Use UNSIGNED_CMP.
287
288 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
289 not to EMACS_INT, to avoid GCC warning.
290
291 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
292
293 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
294 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
295 isn't needed on 32-bit machines.
296
297 * buffer.c (Fgenerate_new_buffer_name):
298 Use EMACS_INT for count, not int.
299 (advance_to_char_boundary): Return EMACS_INT, not int.
300
301 * data.c (Qcompiled_function): Now static.
302
303 * window.c (window_body_lines): Now static.
304
305 * image.c (gif_load): Rename local to avoid shadowing.
306
307 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
308 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
309 * alloc.c (make_save_value): Integer argument is now of type
310 ptrdiff_t, not int.
311 (mark_object): Use ptrdiff_t, not int.
312 * lisp.h (pD): New macro.
313 * print.c (print_object): Use it.
314
315 * alloc.c: Use EMACS_INT, not int, to count objects.
316 (total_conses, total_markers, total_symbols, total_vector_size)
317 (total_free_conses, total_free_markers, total_free_symbols)
318 (total_free_floats, total_floats, total_free_intervals)
319 (total_intervals, total_strings, total_free_strings):
320 Now EMACS_INT, not int. All uses changed.
321 (Fgarbage_collect): Compute overall total using a double, so that
322 integer overflow is less likely to be a problem. Check for overflow
323 when converting back to an integer.
324 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
325 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
326 These were 'int' variables that could overflow on 64-bit hosts;
327 they were never used, so remove them instead of repairing them.
328 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
329 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
330 Previously, this ceilinged at INT_MAX, but that doesn't work on
331 64-bit machines.
332 (allocate_pseudovector): Don't use EMACS_INT when int would do.
333
334 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
335 (allocate_vectorlike): Check for ptrdiff_t overflow.
336 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
337 when a (possibly-narrower) signed value would do just as well.
338 We prefer using signed arithmetic, to avoid comparison confusion.
339
340 * alloc.c: Catch some string size overflows that we were missing.
341 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
342 for convenience in STRING_BYTES_MAX.
343 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
344 The definition here is exact; the one in lisp.h was approximate.
345 (allocate_string_data): Check for string overflow. This catches
346 some instances we weren't catching before. Also, it catches
347 size_t overflow on (unusual) hosts where SIZE_MAX <= min
348 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
349 and ptrdiff_t and EMACS_INT are both 64 bits.
350
351 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
352 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
353 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
354
355 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
356
357 * alloc.c (Fmake_string): Check for out-of-range init.
358
359 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
360
361 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
362
363 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
364
365 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
366 xg_get_default_scrollbar_width.
367
368 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
369 (int_gtk_range_get_value): Move to the scroll bar part of the file.
370 (style_changed_cb): Call update_theme_scrollbar_width and call
371 x_set_scroll_bar_default_width and xg_frame_set_char_size for
372 all frames (Bug#8505).
373 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
374 Call gtk_window_set_resizable if HAVE_GTK3.
375 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
376 and height if HAVE_GTK3 (Bug#8505).
377 (scroll_bar_width_for_theme): New variable.
378 (update_theme_scrollbar_width): New function.
379 (xg_get_default_scrollbar_width): Move code to
380 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
381 (xg_initialize): Call update_theme_scrollbar_width.
382
383 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
384
385 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
386
387 2011-06-12 Martin Rudalics <rudalics@gmx.at>
388
389 * frame.c (make_frame): Call other_buffer_safely instead of
390 other_buffer.
391
392 * window.c (temp_output_buffer_show): Call display_buffer with
393 second argument Vtemp_buffer_show_specifiers and reset latter
394 immediately after the call.
395 (Vtemp_buffer_show_specifiers): New variable.
396 (auto_window_vscroll_p, next_screen_context_lines)
397 (Vscroll_preserve_screen_position): Remove leading asterisks from
398 doc-strings.
399
400 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
401
402 Fix minor problems found by GCC 4.6.0 static checking.
403 * buffer.c (Qclone_number): Remove for now, as it's unused.
404 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
405 (record_buffer): Remove unused local.
406 * frame.c (other_visible_frames, frame_buffer_list): Now static.
407 (set_frame_buffer_list): Remove; unused.
408 * frame.h (other_visible_frames): Remove decl.
409 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
410 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
411 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
412 if HAVE_GPM.
413 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
414 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
415 Define only if HAVE_GPM.
416 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
417 (update_hints_inhibit): Remove; never set. All uses removed.
418 * widgetprv.h (emacsFrameClassRec): Remove decl.
419 * window.c (delete_deletable_window): Now returns void, since it
420 wasn't returning anything.
421 (compare_window_configurations): Remove unused locals.
422 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
423 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
424 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
425 the same widths as pointers. This follows up on the 2011-05-06 patch.
426 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
427 * xterm.h: Likewise.
428 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
429
430 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
431
432 * makefile.w32-in: Update dependencies.
433 (LISP_H): Add lib/intprops.h.
434
435 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
436
437 * image.c (gif_load): Add animation frame delay to the metadata.
438 (syms_of_image): Use DEFSYM. New symbol `delay'.
439
440 2011-06-11 Martin Rudalics <rudalics@gmx.at>
441
442 * window.c (delete_deletable_window): Re-add.
443 (Fset_window_configuration): Rewrite to handle dead buffers and
444 consequently deletable windows.
445 (window_tree, Fwindow_tree): Remove. Supply functionality in
446 window.el.
447 (compare_window_configurations): Simplify code.
448
449 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
450
451 * image.c (imagemagick_load_image): Fix type mismatch.
452 (Fimagemagick_types): Likewise.
453
454 * window.h (replace_buffer_in_windows): Declare.
455
456 2011-06-11 Martin Rudalics <rudalics@gmx.at>
457
458 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
459 Qclone_number. Remove external declaration of Qdelete_window.
460 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
461 code.
462 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
463 Qbuffer_list_update_hook if allowed.
464 (Fother_buffer): Rewrite doc-string. Major rewrite for new
465 buffer list implementation.
466 (other_buffer_safely): New function.
467 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
468 calls to replace_buffer_in_windows and
469 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
470 if allowed.
471 (record_buffer): Inhibit quitting and rewrite using quittable
472 functions. Run Qbuffer_list_update_hook if allowed.
473 (Frecord_buffer, Funrecord_buffer): New functions.
474 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
475 switch-to-buffer to window.el.
476 (bury-buffer): Move to window.el.
477 (Vbuffer_list_update_hook): New variable.
478
479 * lisp.h (other_buffer_safely): Add prototype in buffer.c
480 section.
481
482 * window.h (resize_frame_windows): Move up in code.
483 (Fwindow_frame): Remove EXFUN.
484 (replace_buffer_in_all_windows): Remove prototype.
485 (replace_buffer_in_windows_safely): Add prototype.
486
487 * window.c: Declare Qdelete_window static again. Move down
488 declaration of select_count.
489 (Fnext_window, Fprevious_window): Rewrite doc-strings.
490 (Fother_window): Move to window.el.
491 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
492 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
493 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
494 window.el.
495 (replace_buffer_in_windows): Implement by calling
496 Qreplace_buffer_in_windows.
497 (replace_buffer_in_all_windows): Remove with some functionality
498 moved into replace_buffer_in_windows_safely.
499 (replace_buffer_in_windows_safely): New function.
500 (select_window_norecord, select_frame_norecord): Move in front
501 of run_window_configuration_change_hook. Remove now obsolete
502 declarations.
503 (Fset_window_buffer): Rewrite doc-string. Call
504 Qrecord_window_buffer.
505 (keys_of_window): Move binding for other-window to window.el.
506
507 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
508
509 * dispextern.h (struct image): Replace data member, whose int_val
510 and ptr_val fields were not used by anything, with a single
511 lisp_val object.
512
513 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
514 (gif_clear_image, gif_load, imagemagick_load_image)
515 (gs_clear_image, gs_load): Callers changed.
516
517 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
518
519 * buffer.h: Include <time.h>, for time_t.
520 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
521
522 Fix minor problems found by static checking.
523
524 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
525
526 Make identifiers static if they are not used in other modules.
527 * data.c (Qcompiled_function, Qframe, Qvector):
528 * image.c (QimageMagick, Qsvg):
529 * minibuf.c (Qmetadata):
530 * window.c (resize_window_check, resize_root_window): Now static.
531 * window.h (resize_window_check, resize_root_window): Remove decls.
532
533 * window.c (window_deletion_count, delete_deletable_window):
534 Remove; unused.
535 (window_body_lines): Now static.
536 (Fdelete_other_windows_internal): Mark vars as initialized.
537 Make sure 'resize_failed' is initialized.
538 (run_window_configuration_change_hook): Rename local to avoid shadowing.
539 (resize_window_apply): Remove unused local.
540 * window.h (delete_deletable_window): Remove decl.
541
542 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
543 (imagemagick_load_image): Fix pointer signedness problem by changing
544 last arg from unsigned char * to char *. All uses changed.
545 Also, fix a local for similar reasons.
546 Remove unused locals. Remove locals to avoid shadowing.
547 (fn_rsvg_handle_free): Remove; unused.
548 (svg_load, svg_load_image): Fix pointer signedness problem.
549 (imagemagick_load_image): Don't use garbage pointer image_wand.
550
551 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
552
553 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
554
555 * image.c (gif_load): Fix omitted cast error introduced by
556 2011-06-06 change.
557
558 2011-06-10 Martin Rudalics <rudalics@gmx.at>
559
560 * window.h (resize_proportionally, orig_total_lines)
561 (orig_top_line): Remove from window structure.
562 (set_window_height, set_window_width, change_window_heights)
563 (Fdelete_window): Remove prototypes.
564 (resize_frame_windows): Remove duplicate declaration.
565
566 2011-06-10 Eli Zaretskii <eliz@gnu.org>
567
568 * window.h (resize_frame_windows, resize_window_check)
569 (delete_deletable_window, resize_root_window)
570 (resize_frame_windows): Declare prototypes.
571
572 * window.c (resize_window_apply): Make definition be "static" to
573 match the prototype.
574
575 2011-06-10 Martin Rudalics <rudalics@gmx.at>
576
577 * window.c: Remove declarations of Qwindow_size_fixed,
578 window_min_size_1, window_min_size_2, window_min_size,
579 size_window, window_fixed_size_p, enlarge_window, delete_window.
580 Remove static from declaration of Qdelete_window, it's
581 temporarily needed by Fbury_buffer.
582 (replace_window): Don't assign orig_top_line and
583 orig_total_lines.
584 (Fdelete_window, delete_window): Remove. Window deletion is
585 handled by window.el.
586 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
587 Fdelete_window calls with calls to Qdelete_window.
588 (Fdelete_other_windows): Remove. Deleting other windows is
589 handled by window.el.
590 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
591 handled in window.el.
592 (window_min_size_2, window_min_size_1, window_min_size): Remove.
593 Window minimum sizes are handled in window.el.
594 (shrink_windows, size_window, set_window_height)
595 (set_window_width, change_window_heights, window_height)
596 (window_width, CURBEG, CURSIZE, enlarge_window)
597 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
598 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
599 handled in window.el.
600 (make_dummy_parent): Rename to make_parent_window and give it a
601 second argument horflag.
602 (make_window): Don't set resize_proportionally any more.
603 (Fsplit_window): Remove. Windows are split in window.el.
604 (save_restore_action, save_restore_orig_size)
605 (shrink_window_lowest_first, save_restore_orig_size): Remove.
606 Resize mini windows in window.el.
607 (grow_mini_window, shrink_mini_window): Implement by calling
608 Qresize_root_window_vertically, resize_window_check and
609 resize_window_apply.
610 (saved_window, Fset_window_configuration, save_window_save): Do
611 not handle orig_top_line, orig_total_lines, and
612 resize_proportionally.
613 (window_min_height, window_min_width): Move to window.el.
614 (keys_of_window): Move bindings for delete-other-windows,
615 split-window, delete-window and enlarge-window to window.el.
616
617 * buffer.c: Temporarily extern Qdelete_window.
618 (Fbury_buffer): Temporarily call Qdelete_window instead of
619 Fdelete_window (Fbury_buffer will move to window.el soon).
620
621 * frame.c (set_menu_bar_lines_1): Remove code handling
622 orig_top_line and orig_total_lines.
623
624 * dispnew.c (adjust_frame_glyphs_initially): Don't use
625 set_window_height but set heights directly.
626 (change_frame_size_1): Use resize_frame_windows.
627
628 * xdisp.c (init_xdisp): Don't use set_window_height but set
629 heights directly.
630
631 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
632 resize_frame_windows instead of change_window_heights and run
633 run_window_configuration_change_hook.
634
635 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
636 instead of change_window_heights and run
637 run_window_configuration_change_hook.
638
639 2011-06-09 Martin Rudalics <rudalics@gmx.at>
640
641 * window.c (replace_window): Rename second argument REPLACEMENT to
642 NEW. New third argument SETFLAG. Rewrite.
643 (delete_window, make_dummy_parent): Call replace_window with
644 third argument 1.
645 (window_list_1): Move down in code.
646 (run_window_configuration_change_hook): Move set_buffer part
647 before select_frame_norecord part in order to unwind correctly.
648 Rename count1 to count.
649 (recombine_windows, delete_deletable_window, resize_root_window)
650 (Fdelete_other_windows_internal)
651 (Frun_window_configuration_change_hook, make_parent_window)
652 (resize_window_check, resize_window_apply, Fresize_window_apply)
653 (resize_frame_windows, Fsplit_window_internal)
654 (Fdelete_window_internal, Fresize_mini_window_internal): New
655 functions.
656 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
657
658 2011-06-08 Martin Rudalics <rudalics@gmx.at>
659
660 * window.h (window): Add some new members to window structure -
661 normal_lines, normal_cols, new_total, new_normal, clone_number,
662 splits, nest, prev_buffers, next_buffers.
663 (WINDOW_TOTAL_SIZE): Move here from window.c.
664 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
665
666 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
667 Remove.
668 (make_dummy_parent): Set new members of windows structure.
669 (make_window): Move down in code. Handle new members of window
670 structure.
671 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
672 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
673 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
674 (Fset_window_prev_buffers, Fwindow_next_buffers)
675 (Fset_window_next_buffers, Fset_window_clone_number): New
676 functions.
677 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
678 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
679 Doc-string fixes.
680 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
681 Argument WINDOW can be now internal window too.
682 (Fwindow_use_time): Move up in code.
683 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
684 Rewrite doc-string.
685 (Fset_window_configuration, saved_window)
686 (Fcurrent_window_configuration, save_window_save): Handle new
687 members of window structure.
688 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
689 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
690 (syms_of_window): New Lisp objects Qrecord_window_buffer,
691 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
692 Qget_mru_window, Qresize_root_window,
693 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
694 Qauto_buffer_name; staticpro them.
695
696 2011-06-07 Martin Rudalics <rudalics@gmx.at>
697
698 * window.c (Fwindow_total_size, Fwindow_left_column)
699 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
700 (Fwindow_list_1): New functions.
701 (window_box_text_cols): Replace with window_body_cols.
702 (Fwindow_width, Fscroll_left, Fscroll_right): Use
703 window_body_cols instead of window_box_text_cols.
704 (delete_window, Fset_window_configuration): Call
705 delete_all_subwindows with window as argument.
706 (delete_all_subwindows): Take a window as argument and not a
707 structure. Rewrite.
708 (window_loop): Remove handling of GET_LRU_WINDOW and
709 GET_LARGEST_WINDOW.
710 (Fget_lru_window, Fget_largest_window): Move to window.el.
711
712 * window.h: Extern window_body_cols instead of
713 window_box_text_cols. delete_all_subwindows now takes a
714 Lisp_Object as argument.
715
716 * indent.c (compute_motion, Fcompute_motion): Use
717 window_body_cols instead of window_box_text_cols.
718
719 * frame.c (delete_frame): Call delete_all_subwindows with root
720 window as argument.
721
722 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
723
724 * fns.c (Fputhash): Document return value.
725
726 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
727
728 * image.c (gif_load): Implement gif89a spec "no disposal" method.
729
730 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
731
732 Cons<->int and similar integer overflow fixes (Bug#8794).
733
734 Check for overflow when converting integer to cons and back.
735 * charset.c (Fdefine_charset_internal, Fdecode_char):
736 Use cons_to_unsigned to catch overflow.
737 (Fencode_char): Use INTEGER_TO_CONS.
738 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
739 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
740 * data.c (long_to_cons, cons_to_long): Remove.
741 (cons_to_unsigned, cons_to_signed): New functions.
742 These signal an error for invalid or out-of-range values.
743 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
744 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
745 * font.c (Ffont_variation_glyphs):
746 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
747 * lisp.h: Include <intprops.h>.
748 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
749 (cons_to_signed, cons_to_unsigned): New decls.
750 (long_to_cons, cons_to_long): Remove decls.
751 * undo.c (record_first_change): Use INTEGER_TO_CONS.
752 (Fprimitive_undo): Use CONS_TO_INTEGER.
753 * xfns.c (Fx_window_property): Likewise.
754 * xselect.c: Include <limits.h>.
755 (x_own_selection, selection_data_to_lisp_data):
756 Use INTEGER_TO_CONS.
757 (x_handle_selection_request, x_handle_selection_clear)
758 (x_get_foreign_selection, Fx_disown_selection_internal)
759 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
760 (lisp_data_to_selection_data): Use cons_to_unsigned.
761 (x_fill_property_data): Use cons_to_signed.
762 Report values out of range.
763
764 Check for buffer and string overflow more precisely.
765 * buffer.h (BUF_BYTES_MAX): New macro.
766 * lisp.h (STRING_BYTES_MAX): New macro.
767 * alloc.c (Fmake_string):
768 * character.c (string_escape_byte8):
769 * coding.c (coding_alloc_by_realloc):
770 * doprnt.c (doprnt):
771 * editfns.c (Fformat):
772 * eval.c (verror):
773 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
774 since they may not be the same number.
775 * editfns.c (Finsert_char):
776 * fileio.c (Finsert_file_contents):
777 Likewise for BUF_BYTES_MAX.
778
779 * image.c: Use ptrdiff_t, not int, for sizes.
780 (slurp_file): Switch from int to ptrdiff_t.
781 All uses changed.
782 (slurp_file): Check that file size fits in both size_t (for
783 malloc) and ptrdiff_t (for sanity and safety).
784
785 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
786 if b->modtime has its maximal value.
787
788 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
789
790 Don't assume time_t can fit into int.
791 * buffer.h (struct buffer.modtime): Now time_t, not int.
792 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
793 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
794
795 Minor fixes for signed vs unsigned integers.
796 * character.h (MAYBE_UNIFY_CHAR):
797 * charset.c (maybe_unify_char):
798 * keyboard.c (read_char, reorder_modifiers):
799 XINT -> XFASTINT, since the integer must be nonnegative.
800 * ftfont.c (ftfont_spec_pattern):
801 * keymap.c (access_keymap, silly_event_symbol_error):
802 XUINT -> XFASTINT, since the integer must be nonnegative.
803 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
804 since it makes no difference and we prefer signed.
805 * keyboard.c (record_char): Use XUINT when all the neighbors do.
806 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
807 nonnegative.
808
809 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
810
811 * window.h (Fwindow_frame): Declare.
812
813 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
814
815 * alloc.c: Simplify handling of large-request failures (Bug#8800).
816 (SPARE_MEMORY): Always define.
817 (LARGE_REQUEST): Remove.
818 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
819
820 2011-06-06 Martin Rudalics <rudalics@gmx.at>
821
822 * lisp.h: Move EXFUNS for Fframe_root_window,
823 Fframe_first_window and Fset_frame_selected_window to window.h.
824
825 * window.h: Move EXFUNS for Fframe_root_window,
826 Fframe_first_window and Fset_frame_selected_window here from
827 lisp.h.
828
829 * frame.c (Fwindow_frame, Fframe_first_window)
830 (Fframe_root_window, Fframe_selected_window)
831 (Fset_frame_selected_window): Move to window.c.
832 (Factive_minibuffer_window): Move to minibuf.c.
833 (Fother_visible_frames_p): New function.
834
835 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
836
837 * window.c (decode_window, decode_any_window): Move up in code.
838 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
839 (inhibit_frame_unsplittable): Remove unused variable.
840 (Fwindow_buffer): Move up and rewrite doc-string.
841 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
842 (Fwindow_prev): New functions.
843 (Fwindow_frame): Move here from frame.c. Accept any window as
844 argument.
845 (Fframe_root_window, Fframe_first_window)
846 (Fframe_selected_window): Move here from frame.c. Accept frame
847 or arbitrary window as argument. Update doc-strings.
848 (Fminibuffer_window): Move up in code.
849 (Fwindow_minibuffer_p): Move up in code and simplify.
850 (Fset_frame_selected_window): Move here from frame.c.
851 Marginal rewrite.
852 (Fselected_window, select_window, Fselect_window): Move up in
853 code. Minor doc-string fixes.
854
855 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
856
857 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
858 Do not assume that spare memory exists; that assumption is valid
859 only if SYSTEM_MALLOC.
860 (LARGE_REQUEST): New macro, so that the issue of large requests
861 is separated from the issue of spare memory.
862
863 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
864
865 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
866 format. (Bug#8806)
867
868 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
869
870 * xfns.c (x_set_scroll_bar_default_width): Move declarations
871 before statements.
872
873 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
874
875 * gtkutil.c (xg_get_default_scrollbar_width): New function.
876
877 * gtkutil.h: Declare xg_get_default_scrollbar_width.
878
879 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
880 min width by calling x_set_scroll_bar_default_width (Bug#8505).
881
882 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
883
884 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
885
886 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
887
888 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
889 (x_clipboard_manager_save): Add return value.
890 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
891 New error handlers.
892 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
893 Obey Vx_select_enable_clipboard_manager. Catch errors in
894 x_clipboard_manager_save (Bug#8779).
895 (Vx_select_enable_clipboard_manager): New variable.
896 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
897
898 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
899
900 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
901
902 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
903
904 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
905 in the current matrix if keep_current_p is non-zero.
906
907 2011-06-04 Eli Zaretskii <eliz@gnu.org>
908
909 * bidi.c (bidi_level_of_next_char): Fix last change.
910
911 2011-06-03 Eli Zaretskii <eliz@gnu.org>
912
913 Support bidi reordering of text covered by display properties.
914
915 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
916 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
917 (bidi_cache_search, bidi_cache_iterator_state)
918 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
919 (bidi_level_of_next_char, bidi_move_to_visually_next):
920 Support character positions inside a run of characters covered by a
921 display string.
922 (bidi_paragraph_init, bidi_resolve_explicit_1)
923 (bidi_level_of_next_char): Call bidi_fetch_char and
924 bidi_fetch_char_advance instead of FETCH_CHAR and
925 FETCH_CHAR_ADVANCE.
926 (bidi_init_it): Initialize new members.
927 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
928 definitions.
929 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
930 instead of using explicit *_CHAR codes.
931 (bidi_resolve_explicit, bidi_resolve_weak):
932 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
933 bidirectional text is supported only in multibyte buffers.
934 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
935 it to initialize the frame_window_p member of struct bidi_it.
936 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
937 (bidi_resolve_explicit, bidi_resolve_weak)
938 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
939 bidi_it->nchars is non-positive.
940 (bidi_level_of_next_char): Don't try to lookup the cache for the
941 next/previous character if nothing is cached there yet, or if we
942 were just reseat()'ed to a new position.
943
944 * xdisp.c (set_cursor_from_row): Set start and stop points
945 according to the row's direction when priming the loop that looks
946 for the glyph on which to display cursor.
947 (single_display_spec_intangible_p): Function deleted.
948 (display_prop_intangible_p): Reimplement to call
949 handle_display_spec instead of single_display_spec_intangible_p.
950 Accept 3 additional arguments needed by handle_display_spec.
951 This fixes incorrect cursor motion across display property with complex
952 values: lists, `(when COND...)' forms, etc.
953 (single_display_spec_string_p): Support property values that are
954 lists with the argument STRING its top-level element.
955 (display_prop_string_p): Fix the condition for processing a
956 property that is a list to be consistent with handle_display_spec.
957 (handle_display_spec): New function, refactored from the
958 last portion of handle_display_prop.
959 (compute_display_string_pos): Accept additional argument
960 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
961 value of a `display' property is a "replacing spec".
962 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
963 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
964 the display property, but just return a value indicating whether
965 the display property will replace the characters it covers.
966 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
967 frame_window_p members of struct bidi_it.
968 (compute_display_string_pos, compute_display_string_end):
969 New functions.
970 (push_it): Accept second argument POSITION, where pop_it should
971 jump to continue iteration.
972 (reseat_1): Initialize bidi_it.disp_pos.
973
974 * keyboard.c (adjust_point_for_property): Adjust the call to
975 display_prop_intangible_p to its new signature.
976
977 * dispextern.h (struct bidi_it): New member frame_window_p.
978 (bidi_init_it): Update prototypes.
979 (display_prop_intangible_p): Update prototype.
980 (compute_display_string_pos, compute_display_string_end):
981 Declare prototypes.
982 (struct bidi_it): New members nchars and disp_pos. ch_len is now
983 EMACS_INT.
984
985 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
986
987 Malloc failure behavior now depends on size of allocation.
988 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
989 * lisp.h: Change signatures accordingly.
990 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
991 All callers changed. (Bug#8762)
992
993 * gnutls.c: Use Emacs's memory allocators.
994 Without this change, the gnutls library would invoke malloc etc.
995 directly, which causes problems on non-SYNC_INPUT hosts, and which
996 runs afoul of improving memory_full behavior. (Bug#8761)
997 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
998 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
999 xfree instead of the default malloc, realloc, free.
1000 (Fgnutls_boot): No need to check for memory allocation failure,
1001 since xmalloc does that for us.
1002
1003 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
1004 * category.c (hash_get_category_set):
1005 * ccl.c (ccl_driver):
1006 * charset.c (Fdefine_charset_internal):
1007 * charset.h (struct charset.hash_index):
1008 * composite.c (get_composition_id, gstring_lookup_cache)
1009 (composition_gstring_put_cache):
1010 * composite.h (struct composition.hash_index):
1011 * dispextern.h (struct image.hash):
1012 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1013 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1014 (hashfn_equal, hashfn_user_defined, make_hash_table)
1015 (maybe_resize_hash_table, hash_lookup, hash_put)
1016 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1017 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1018 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1019 * image.c (make_image, search_image_cache, lookup_image)
1020 (xpm_put_color_table_h):
1021 * lisp.h (struct Lisp_Hash_Table):
1022 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
1023 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1024 for hashes and hash indexes, instead of 'unsigned' and 'int'.
1025 * alloc.c (allocate_vectorlike):
1026 Check for overflow in vector size calculations.
1027 * ccl.c (ccl_driver):
1028 Check for overflow when converting EMACS_INT to int.
1029 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1030 need to be updated by these changes.
1031 * fns.c (make_hash_table, maybe_resize_hash_table):
1032 Check for integer overflow with large hash tables.
1033 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1034 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1035 (SXHASH_REDUCE): New macro.
1036 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1037 Use it instead of discarding useful hash info with large hash values.
1038 (sxhash_float): New function.
1039 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1040 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
1041 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1042 Rewrite to use FIXNUM_BITS, as this simplifies things.
1043 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1044 Adjust signatures to match updated version of code.
1045 (consing_since_gc): Now EMACS_INT, since a single hash table can
1046 use more than INT_MAX bytes.
1047
1048 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1049
1050 Make it possible to build with GCC-4.6+ -O2 -flto.
1051
1052 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1053
1054 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1055
1056 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1057 Call minibuffer-inactive-mode.
1058
1059 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
1060
1061 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1062 Update dependencies.
1063
1064 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1065
1066 * data.c (init_data): Remove code for UTS, this system is not
1067 supported anymore.
1068
1069 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1070
1071 Don't force ./temacs to start in terminal mode.
1072
1073 * frame.c (make_initial_frame): Initialize faces in all cases, not
1074 only when CANNOT_DUMP is defined.
1075 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1076
1077 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1078
1079 * dispnew.c (add_window_display_history): Use const for the string
1080 pointer. Remove declaration, not needed.
1081
1082 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1083
1084 Use 'inline', not 'INLINE'.
1085 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1086 * alloc.c, fontset.c (INLINE): Remove.
1087 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1088 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1089 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1090 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1091 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1092
1093 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1094
1095 Make it possible to run ./temacs.
1096
1097 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1098 syms_of_callproc does the same thing. Remove test for
1099 "initialized", do it in the caller.
1100 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1101
1102 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1103
1104 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1105 (read_minibuf): Use get_minibuffer.
1106 (syms_of_minibuf): Use DEFSYM.
1107 (Qmetadata): New var.
1108 * data.c (Qbuffer): Don't make it static.
1109 (syms_of_data): Use DEFSYM.
1110
1111 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1112
1113 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1114 (CCL_CODE_MIN): New macro.
1115
1116 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1117
1118 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1119
1120 * eval.c (Qdebug): Now static.
1121 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1122 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1123 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1124
1125 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1126
1127 * image.c: Various fixes to ImageMagick code comments.
1128 (Fimagemagick_types): Doc fix.
1129
1130 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1131
1132 Minor fixes prompted by GCC 4.6.0 warnings.
1133
1134 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1135
1136 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1137 (x_clipboard_manager_save_all): Move extern decl to ...
1138 * xterm.h: ... here, so that it can be checked for consistency.
1139
1140 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1141
1142 * xselect.c (x_clipboard_manager_save_frame)
1143 (x_clipboard_manager_save_all): New functions.
1144 (Fx_clipboard_manager_save): Lisp function deleted.
1145
1146 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1147 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1148
1149 * xterm.h: Update prototype.
1150
1151 2011-05-28 William Xu <william.xwl@gmail.com>
1152
1153 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1154 exiting (Bug#8239).
1155
1156 2011-05-28 Jim Meyering <meyering@redhat.com>
1157
1158 Avoid a sign-extension bug in crypto_hash_function.
1159 * fns.c (to_uchar): Define.
1160 (crypto_hash_function): Use it to convert some newly-signed
1161 variables to unsigned, to avoid sign-extension bugs. For example,
1162 without this change, (md5 "truc") would evaluate to
1163 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1164 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1165 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1166
1167 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1168
1169 Integer overflow fixes.
1170
1171 * dbusbind.c: Serial number integer overflow fixes.
1172 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1173 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1174 to hold a serial number that is too large for a fixnum.
1175 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1176 Check for serial numbers out of range. Decode any serial number
1177 that was so large that it became a float. (Bug#8722)
1178
1179 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1180 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1181 Use XFASTINT rather than XUINT when numbers are nonnegative.
1182 (xd_append_arg, Fdbus_method_return_internal):
1183 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1184 arguments, check that Lisp number is nonnegative, rather than
1185 silently wrapping negative numbers around. (Bug#8722)
1186 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1187 (Bug#8722)
1188
1189 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1190
1191 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1192
1193 ccl: add integer overflow checks
1194 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1195 (IN_INT_RANGE): New macros.
1196 (ccl_driver): Use them to check for integer overflow when
1197 decoding a CCL program. Many of the new checks are whether XINT (x)
1198 fits in int; it doesn't always, on 64-bit hosts. The new version
1199 doesn't catch all possible integer overflows, but it's an
1200 improvement. (Bug#8719)
1201
1202 * alloc.c (make_event_array): Use XINT, not XUINT.
1203 There's no need for unsigned here.
1204
1205 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1206 This follows up to the 2011-05-06 change that substituted uintptr_t
1207 for EMACS_INT. This case wasn't caught back then.
1208
1209 Rework Fformat to avoid integer overflow issues.
1210 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1211 now (part of C89). Include <verify.h>.
1212 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1213 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1214 (Fformat): Avoid the prepass trying to compute sizes; it was only
1215 approximate and thus did not catch overflow reliably. Instead, walk
1216 through the format just once, formatting and computing sizes as we go,
1217 checking for integer overflow at every step, and allocating a larger
1218 buffer as needed. Keep track separately whether the format is
1219 multibyte. Keep only the most-recently calculated precision, rather
1220 than them all. Record whether each argument has been converted to
1221 string. Use EMACS_INT, not int, for byte and char and arg counts.
1222 Support field widths and precisions larger than INT_MAX. Avoid
1223 sprintf's undefined behavior with conversion specifications such as %#d
1224 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1225 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1226 formatting out-of-range floating point numbers with int
1227 formats. (Bug#8668)
1228
1229 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1230
1231 * data.c: Avoid integer truncation in expressions involving floats.
1232 * data.c: Include <intprops.h>.
1233 (arith_driver): When there's an integer overflow in an expression
1234 involving floating point, convert the integers to floating point
1235 so that the resulting value does not suffer from catastrophic
1236 integer truncation. For example, on a 64-bit host (* 4
1237 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1238 Do not rely on undefined behavior after integer overflow.
1239
1240 merge count_size_as_multibyte, parse_str_to_multibyte
1241 * character.c, character.h (count_size_as_multibyte):
1242 Rename from parse_str_to_multibyte; all uses changed.
1243 Check for integer overflow.
1244 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1245 since it's now a duplicate of the other. This is more of
1246 a character than a buffer op, so better that it's in character.c.
1247 * fns.c, print.c: Adjust to above changes.
1248
1249 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1250
1251 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1252
1253 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1254
1255 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1256 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1257 (x_clipboard_manager_save): Now static.
1258 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1259
1260 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1261 (crypto_hash_function): Now static.
1262 Fix pointer signedness problems. Avoid unnecessary initializations.
1263
1264 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1265
1266 * termhooks.h (Vselection_alist): Make it terminal-local.
1267
1268 * terminal.c (create_terminal): Initialize it.
1269
1270 * xselect.c: Support for clipboard managers.
1271 (Vselection_alist): Move to termhooks.h as terminal-local var.
1272 (LOCAL_SELECTION): New macro.
1273 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1274 (symbol_to_x_atom): Remove gratuitous arg.
1275 (x_handle_selection_request, lisp_data_to_selection_data)
1276 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1277 (x_own_selection, x_get_local_selection, x_convert_selection):
1278 New arg, specifying work frame. Use terminal-local Vselection_alist.
1279 (some_frame_on_display): Delete unused function.
1280 (Fx_own_selection_internal, Fx_get_selection_internal)
1281 (Fx_disown_selection_internal, Fx_selection_owner_p)
1282 (Fx_selection_exists_p): New optional frame arg.
1283 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1284 (x_handle_selection_clear): Don't treat other terminals with the
1285 same keyboard specially. Use the terminal-local Vselection_alist.
1286 (x_clear_frame_selections): Use Frun_hook_with_args.
1287
1288 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1289
1290 * xterm.h: Add support for those atoms.
1291
1292 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
1293
1294 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1295 (converted_selections, conversion_fail_tag): New global variables.
1296 (x_selection_request_lisp_error): Free the above.
1297 (x_get_local_selection): Remove unnecessary code.
1298 (x_reply_selection_request): Args changed; handle arbitrary array
1299 of converted selections stored in converted_selections.
1300 Separate the XChangeProperty and SelectionNotify steps.
1301 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1302 (x_convert_selection): New function.
1303 (x_handle_selection_event): Simplify.
1304 (x_get_foreign_selection): Don't ignore incoming requests while
1305 waiting for an answer; this will fail when we implement
1306 SAVE_TARGETS, and seems unnecessary anyway.
1307 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1308 (Vx_sent_selection_functions): Doc fix.
1309
1310 2011-05-26 Leo Liu <sdl.web@gmail.com>
1311
1312 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1313
1314 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1315
1316 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1317
1318 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1319 for fringe update if it has periodic bitmap.
1320 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1321 and fringe_bitmap_periodic_p.
1322
1323 * fringe.c (get_fringe_bitmap_data): New function.
1324 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1325 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1326 row. Mark glyph row for fringe update if periodicity changed.
1327
1328 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1329 for fringe update unless it has periodic bitmap.
1330
1331 2011-05-25 Kenichi Handa <handa@m17n.org>
1332
1333 * xdisp.c (get_next_display_element): Set correct it->face_id for
1334 a static composition.
1335
1336 2011-05-24 Leo Liu <sdl.web@gmail.com>
1337
1338 * deps.mk (fns.o):
1339 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1340
1341 * fns.c (crypto_hash_function, Fsha1): New function.
1342 (Fmd5): Use crypto_hash_function.
1343 (syms_of_fns): Add Ssha1.
1344
1345 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1346
1347 * gnutls.c: Remove unused macros.
1348 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1349 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1350 Remove macros that are defined and never used.
1351 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1352
1353 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1354
1355 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1356 (Fx_get_selection_internal): Minor cleanup.
1357 (Fx_own_selection_internal): Rename arguments for consistency with
1358 select.el.
1359
1360 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1361
1362 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1363
1364 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1365
1366 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1367
1368 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1369
1370 * dispnew.c (scrolling_window): Don't exclude the case that the
1371 last enabled row in the desired matrix touches the bottom boundary.
1372
1373 2011-05-21 Glenn Morris <rgm@gnu.org>
1374
1375 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
1376 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1377 and add some more files.
1378
1379 2011-05-20 Eli Zaretskii <eliz@gnu.org>
1380
1381 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1382 report_file_error introduced by the change from 2011-05-07.
1383
1384 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1385
1386 * systime.h (Time): Define only if emacs is defined.
1387 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1388 where the include path doesn't have X11/X.h by default. See
1389 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1390
1391 2011-05-20 Kenichi Handa <handa@m17n.org>
1392
1393 * composite.c (find_automatic_composition): Fix previous change.
1394
1395 2011-05-20 Glenn Morris <rgm@gnu.org>
1396
1397 * lisp.mk: New file, split from Makefile.in.
1398 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1399 (shortlisp): Remove.
1400 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1401
1402 2011-05-19 Glenn Morris <rgm@gnu.org>
1403
1404 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1405 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1406 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1407 (lisp): Set the order to that of loadup.el.
1408 (shortlisp): Make it a copy of $lisp.
1409 (SOME_MACHINE_LISP): Remove.
1410 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1411 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1412
1413 2011-05-18 Kenichi Handa <handa@m17n.org>
1414
1415 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1416 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1417 (find_automatic_composition): Mostly rewrite for efficiency.
1418
1419 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
1420
1421 * makefile.w32-in: Update dependencies.
1422
1423 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1424
1425 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1426 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
1427
1428 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
1429
1430 Fix some integer overflow issues, such as string length overflow.
1431
1432 * insdel.c (count_size_as_multibyte): Check for string overflow.
1433
1434 * character.c (lisp_string_width): Check for string overflow.
1435 Use EMACS_INT, not int, for string indexes and lengths; in
1436 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1437 the resulting string length overflows an EMACS_INT; instead,
1438 report a string overflow if no precision given. When checking for
1439 precision exhaustion, use a check that cannot possibly have
1440 integer overflow. (Bug#8675)
1441 * character.h (lisp_string_width): Adjust to new signature.
1442
1443 * alloc.c (string_overflow): New function.
1444 (Fmake_string): Use it. This doesn't change behavior, but saves
1445 a few bytes and will simplify future changes.
1446 * character.c (string_escape_byte8): Likewise.
1447 * lisp.h (string_overflow): New decl.
1448
1449 Fixups, following up to the user-interface timestamp change.
1450 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1451 for UI timestamps, instead of unsigned long.
1452 * msdos.c (mouse_get_pos): Likewise.
1453 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1454 * w32gui.h (Time): Define by including "systime.h" rather than by
1455 declaring it ourselves. (Bug#8664)
1456
1457 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1458 * image.c (clear_image_cache): Likewise.
1459
1460 * term.c (term_mouse_position): Don't assume time_t wraparound.
1461
1462 Be more systematic about user-interface timestamps.
1463 Before, the code sometimes used 'Time', sometimes 'unsigned long',
1464 and sometimes 'EMACS_UINT', to represent these timestamps.
1465 This change causes it to use 'Time' uniformly, as that's what X uses.
1466 This makes the code easier to follow, and makes it easier to catch
1467 integer overflow bugs such as Bug#8664.
1468 * frame.c (Fmouse_position, Fmouse_pixel_position):
1469 Use Time, not unsigned long, for user-interface timestamps.
1470 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1471 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1472 * keyboard.h (last_event_timestamp): Likewise.
1473 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1474 * menu.h (xmenu_show): Likewise.
1475 * term.c (term_mouse_position): Likewise.
1476 * termhooks.h (struct input_event.timestamp): Likewise.
1477 (struct terminal.mouse_position_hook): Likewise.
1478 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1479 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1480 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1481 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1482 what it was before.
1483 * menu.h, termhooks.h: Include "systime.h", for Time.
1484
1485 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1486 Don't assume that the difference between two unsigned long values
1487 can fit into an integer. At this point, we know button_down_time
1488 <= event->timestamp, so the difference must be nonnegative, so
1489 there's no need to cast the result if double-click-time is
1490 nonnegative, as it should be; check that it's nonnegative, just in
1491 case. This bug is triggered when events are more than 2**31 ms
1492 apart (about 25 days). (Bug#8664)
1493
1494 * xselect.c (last_event_timestamp): Remove duplicate decl.
1495 (x_own_selection): Remove needless cast to unsigned long.
1496
1497 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1498 that always fit in int. Use a sentinel instead of a counter, to
1499 avoid a temp and to allay GCC's concerns about possible int overflow.
1500 * frame.h (struct frame): Use int for menu_bar_items_used
1501 instead of EMACS_INT, since it always fits in int.
1502
1503 * menu.c (grow_menu_items): Check for int overflow.
1504
1505 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1506
1507 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1508 Before, the code was not consistent. These values cannot exceed
1509 2**31 - 1 so there's no need to make them unsigned.
1510 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1511 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1512 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1513 as modifiers.
1514 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1515
1516 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1517 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1518 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1519 presumably because the widths might not match.
1520
1521 * window.c (size_window): Avoid needless test at loop start.
1522
1523 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1524
1525 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1526
1527 2011-05-12 Drew Adams <drew.adams@oracle.com>
1528
1529 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1530
1531 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1532
1533 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1534 `width' to `bar_area_x' and `bar_area_width', respectively.
1535 (x_scroll_run): Take account of fringe background extension.
1536
1537 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1538 Rename local vars `left' and `width' to `bar_area_x' and
1539 `bar_area_width', respectively.
1540 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1541 background extension.
1542
1543 2011-05-10 Jim Meyering <meyering@redhat.com>
1544
1545 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1546
1547 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
1548
1549 * image.c (Finit_image_library): Return t for built-in image types,
1550 like pbm and xbm. (Bug#8640)
1551
1552 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1553
1554 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1555
1556 2011-05-07 Eli Zaretskii <eliz@gnu.org>
1557
1558 * w32console.c (Fset_screen_color): Doc fix.
1559 (Fget_screen_color): New function.
1560 (syms_of_ntterm): Defsubr it.
1561
1562 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1563 unlink the temporary file if Fcall_process didn't create it in the
1564 first place.
1565 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1566 child process will be redirected to a file specified with `:file'.
1567 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1568 cue to call_process_cleanup not to close that handle.
1569
1570 2011-05-07 Ben Key <bkey76@gmail.com>
1571
1572 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1573 one of two shell specific rules, either bootstrap-temacs-CMD or
1574 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1575 to the previous implementation of the bootstrap-temacs rule.
1576 The bootstrap-temacs-CMD rule is similar to the previous
1577 implementation of the bootstrap-temacs rule except that it
1578 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1579 variable.
1580
1581 These changes, along with some changes to nt/configure.bat,
1582 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1583 earlier fix to add support for --cflags and --ldflags options
1584 that include quotes so that it works whether make uses cmd or
1585 sh as the shell.
1586
1587 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
1588
1589 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1590 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1591 is a constant.
1592 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1593 a string. Handle both cases.
1594 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1595 (Fdbus_register_method): Use Qinvalid_function.
1596
1597 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1598
1599 * makefile.w32-in: Update dependencies.
1600 (LISP_H): Add inttypes.h and stdin.h.
1601 (PROCESS_H): Add unistd.h.
1602
1603 2011-05-06 Eli Zaretskii <eliz@gnu.org>
1604
1605 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1606 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1607
1608 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
1609
1610 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1611
1612 * term.c (vfatal): Remove stray call to va_end.
1613 It's not needed and the C Standard doesn't allow it here anyway.
1614
1615 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1616 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1617
1618 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1619 bytes.
1620
1621 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1622
1623 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1624
1625 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1626
1627 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1628
1629 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1630
1631 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1632 * charset.c (Fdefine_charset_internal): Don't initialize
1633 charset.code_space[15]. The value was garbage, on hosts with
1634 32-bit int (Bug#8600).
1635
1636 * lread.c (read_integer): Be more consistent with string-to-number.
1637 Use string_to_number to do the actual conversion; this avoids
1638 rounding errors and fixes some other screwups. Without this fix,
1639 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1640 (digit_to_number): Move earlier, for benefit of read_integer.
1641 Return -1 if the digit is out of range for the base, -2 if it is
1642 not a digit in any supported base. (Bug#8602)
1643
1644 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1645
1646 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1647 to match comment at start of function. This also removes a
1648 GCC warning about overflow in a 32+64-bit port.
1649
1650 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1651
1652 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1653 Reported by Stefan Monnier in
1654 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
1655 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1656 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
1657
1658 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1659 (EMACS_UINTPTR): Likewise, with uintptr_t.
1660
1661 * lisp.h: Prefer 64-bit EMACS_INT if available.
1662 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1663 on 32-bit hosts that have 64-bit int, so that they can access
1664 large files.
1665 However, temporarily disable this change unless the temporary
1666 symbol WIDE_EMACS_INT is defined.
1667
1668 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1669
1670 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1671 This removes an assumption that EMACS_INT and long are the same
1672 width as pointers. The assumption is true for Emacs porting targets
1673 now, but we want to make other targets possible.
1674 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1675 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1676 In the rest of the code, change types of integers that hold casted
1677 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1678 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1679 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1680 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1681 No need to cast type when ORing.
1682 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1683 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1684 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1685 assume EMACS_INT is the same width as char *.
1686 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1687 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1688 Remove no-longer-needed casts.
1689 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1690 (xg_tool_bar_help_callback, xg_make_tool_item):
1691 Use EMACS_INTPTR to hold an integer
1692 that will be cast to void *; this can avoid a GCC warning
1693 if EMACS_INT is not the same width as void *.
1694 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1695 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1696 (current_message_1, set_message_1):
1697 Use a local to convert to proper width without a cast.
1698 * xmenu.c (dialog_selection_callback): Likewise.
1699
1700 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1701 Also, don't assume VALBITS / RAND_BITS is less than 5,
1702 and don't rely on undefined behavior when shifting a 1 left into
1703 the sign bit.
1704 * lisp.h (get_random): Change signature to match.
1705
1706 * lread.c (hash_string): Use size_t, not int, for hash computation.
1707 Normally we prefer signed values; but hashing is special, because
1708 it's better to use unsigned division on hash table sizes so that
1709 the remainder is nonnegative. Also, size_t is the natural width
1710 for hashing into memory. The previous code used 'int', which doesn't
1711 retain enough info to hash well into very large tables.
1712 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1713
1714 * dbusbind.c: Don't possibly lose pointer info when converting.
1715 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1716 Use XPNTR rather than XHASH, so that the high-order bits of
1717 the pointer aren't lost when converting through void *.
1718
1719 * eval.c (Fautoload): Don't double-shift a pointer.
1720
1721 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1722
1723 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1724
1725 * gnutls.c (DEF_GNUTLS_FN):
1726 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1727
1728 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1729
1730 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1731 marker. (Bug#8610)
1732
1733 2011-05-05 Eli Zaretskii <eliz@gnu.org>
1734
1735 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1736 New version that can reserve upto 2GB of heap space.
1737
1738 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
1739
1740 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1741
1742 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1743
1744 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1745 `gnutls_certificate_set_x509_key_file'.
1746
1747 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
1748
1749 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1750 Update dependencies.
1751
1752 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1753
1754 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1755 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1756 Remove unused parameter `fildes'.
1757 * process.c (read_process_output, send_process): Don't pass it.
1758
1759 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1760
1761 Fix previous change: the library cache is defined in w32.c.
1762 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1763 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1764
1765 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1766
1767 Implement dynamic loading of GnuTLS on Windows.
1768
1769 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1770 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1771 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1772 Declare.
1773
1774 * gnutls.c (Qgnutls_dll): Define.
1775 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1776 (gnutls_*): Declare function pointers.
1777 (init_gnutls_functions): New function to initialize function pointers.
1778 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1779 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1780 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1781 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1782 (emacs_gnutls_write, emacs_gnutls_read)
1783 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1784 (Fgnutls_available_p): New function.
1785 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1786 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1787 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1788
1789 * image.c: Include w32.h.
1790 (Vimage_type_cache): Delete.
1791 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1792 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1793 (w32_delayed_load): Move to w32.c.
1794
1795 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1796
1797 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1798 (w32_delayed_load): Move from image.c. When loading a library, record
1799 its filename in the :loaded-from property of the library id.
1800 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1801 Initialize and staticpro them.
1802 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1803
1804 * process.c: Include lisp.h before w32.h, not after.
1805 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1806 instead of gnutls_record_check_pending.
1807
1808 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1809
1810 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1811
1812 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1813 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1814 as passed in.
1815
1816 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1817
1818 * xterm.c (x_set_frame_alpha): Do not set property on anything
1819 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1820
1821 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1822
1823 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1824
1825 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1826
1827 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1828 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1829 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1830 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1831 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1832 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1833 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1834 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1835 (Qgnutls_bootprop_callbacks_verify): Make static.
1836
1837 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1838
1839 * callproc.c: Indentation fixup.
1840
1841 * sysdep.c (wait_for_termination_1): Make static.
1842 (wait_for_termination, interruptible_wait_for_termination):
1843 Move after wait_for_termination_1.
1844
1845 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1846
1847 * sysdep.c (interruptible_wait_for_termination): New function
1848 which is like wait_for_termination, but allows keyboard
1849 interruptions.
1850
1851 * callproc.c (Fcall_process): Add (:file "file") as an option for
1852 the STDOUT buffer.
1853 (Fcall_process_region): Ditto.
1854
1855 2011-04-30 Eli Zaretskii <eliz@gnu.org>
1856
1857 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1858 rather than `XVECTOR (FOO)->size'.
1859
1860 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1861 inttypes.h, as a gnulib replacement is used if it not available in
1862 system headers.
1863
1864 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1865
1866 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1867 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1868 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1869
1870 * coding.c (coding_alloc_by_realloc): Error out if destination
1871 will grow beyond MOST_POSITIVE_FIXNUM.
1872 (decode_coding_emacs_mule): Abort if there isn't enough place in
1873 charbuf for the composition carryover bytes. Reserve an extra
1874 space for up to 2 characters produced in a loop.
1875 (decode_coding_iso_2022): Abort if there isn't enough place in
1876 charbuf for the composition carryover bytes.
1877
1878 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1879
1880 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1881 aborting when %lld or %lll format is passed.
1882 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1883 %llo or %llx format is passed. (Bug#8545)
1884
1885 * window.c (window_scroll_line_based): Use a marker instead of
1886 simple variables to record original value of point. (Bug#7952)
1887
1888 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1889 produced by %s or %c overflows available buffer space. (Bug#8545)
1890
1891 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1892
1893 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1894 (SIZE_MAX): Move defn after all includes, as they might #define it.
1895
1896 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1897
1898 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1899
1900 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1901
1902 * keyboard.c (Qdelayed_warnings_hook): Define.
1903 (command_loop_1): Run `delayed-warnings-hook'
1904 if Vdelayed_warnings_list is non-nil.
1905 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1906 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1907
1908 2011-04-28 Eli Zaretskii <eliz@gnu.org>
1909
1910 * doprnt.c (doprnt): Don't return value smaller than the buffer
1911 size if the message was truncated. (Bug#8545).
1912
1913 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1914
1915 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1916 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1917
1918 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1919
1920 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1921
1922 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
1923
1924 * makefile.w32-in: Update dependencies.
1925
1926 2011-04-27 Eli Zaretskii <eliz@gnu.org>
1927
1928 Improve `doprnt' and its usage. (Bug#8545)
1929 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1930 `format_end'. Remove support for %l as a conversion specifier.
1931 Don't use xrealloc. Improve diagnostics when the %l size modifier
1932 is used. Update the commentary.
1933
1934 * eval.c (verror): Simplify calculation of size_t.
1935
1936 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1937 messages.
1938
1939 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1940
1941 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1942 change.
1943
1944 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1945
1946 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1947 This makes this file independent of the recent pseudovector change.
1948
1949 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
1950
1951 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1952
1953 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
1954 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
1955 Remove unused local.
1956 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
1957
1958 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
1959 GCC 4.6.0 optimizes based on type-based alias analysis.
1960 For example, if b is of type struct buffer * and v of type struct
1961 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1962 != &v->size, and therefore "v->size = 1; b->size = 2; return
1963 v->size;" must therefore return 1. This assumption is incorrect
1964 for Emacs, since it type-puns struct Lisp_Vector * with many other
1965 types. To fix this problem, this patch adds a new type struct
1966 vectorlike_header that documents the constraints on layout of vectors
1967 and pseudovectors, and helps optimizing compilers not get fooled
1968 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1969 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
1970 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1971 the size member.
1972 (XSETPVECTYPE): Rewrite in terms of new macro.
1973 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1974 This is a bit clearer, and further avoids the possibility of
1975 undesirable aliasing.
1976 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
1977 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
1978 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1979 since Lisp_Subr is a special case (no "next" field).
1980 (ASIZE): Now uses header.size rather than size.
1981 All previous uses of XVECTOR (foo)->size replaced to use this macro,
1982 to avoid the hassle of writing XVECTOR (foo)->header.size.
1983 (struct vectorlike_header): New type.
1984 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1985 object, to help avoid aliasing.
1986 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1987 (SUBRP): Likewise, since Lisp_Subr is a special case.
1988 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1989 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1990 (struct Lisp_Hash_Table): Combine first two members into a single
1991 struct vectorlike_header member. All uses of "size" and "next" members
1992 changed to be "header.size" and "header.next".
1993 * buffer.h (struct buffer): Likewise.
1994 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1995 * frame.h (struct frame): Likewise.
1996 * process.h (struct Lisp_Process): Likewise.
1997 * termhooks.h (struct terminal): Likewise.
1998 * window.c (struct save_window_data, struct saved_window): Likewise.
1999 * window.h (struct window): Likewise.
2000 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2001 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2002 * buffer.c (init_buffer_once): Likewise.
2003 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2004 special case.
2005 * process.c (Fformat_network_address): Use local var for size,
2006 for brevity.
2007
2008 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2009
2010 Make the Lisp reader and string-to-float more consistent (Bug#8525)
2011 * data.c (atof): Remove decl; no longer used or needed.
2012 (digit_to_number): Move to lread.c.
2013 (Fstring_to_number): Use new string_to_number function, to be
2014 consistent with how the Lisp reader treats infinities and NaNs.
2015 Do not assume that floating-point numbers represent EMACS_INT
2016 without losing information; this is not true on most 64-bit hosts.
2017 Avoid double-rounding errors, by insisting on integers when
2018 parsing non-base-10 numbers, as the documentation specifies.
2019 * lisp.h (string_to_number): New decl, replacing ...
2020 (isfloat_string): Remove.
2021 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
2022 (read1): Do not accept +. and -. as integers; this
2023 appears to have been a coding error. Similarly, do not accept
2024 strings like +-1e0 as floating point numbers. Do not report
2025 overflow for integer overflows unless the base is not 10 which
2026 means we have no simple and reliable way to continue.
2027 Break out the floating-point parsing into a new
2028 function string_to_number, so that Fstring_to_number parses
2029 floating point numbers consistently with the Lisp reader.
2030 (digit_to_number): Move here from data.c. Make it static inline.
2031 (E_CHAR, EXP_INT): Remove, replacing with ...
2032 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2033 (string_to_number): New function, replacing isfloat_string.
2034 This function checks for valid syntax and produces the resulting
2035 Lisp float number too. Rework it so that string-to-number
2036 no longer mishandles examples like "1.0e+". Use strtoumax,
2037 so that overflow for non-base-10 numbers is reported only when
2038 there's no portable and simple way to convert to floating point.
2039
2040 * textprop.c (set_text_properties_1): Rewrite for clarity,
2041 and to avoid GCC warning about integer overflow.
2042
2043 * intervals.h (struct interval): Use EMACS_INT for members
2044 where EMACS_UINT might cause problems. See
2045 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2046 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2047 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2048 All uses changed.
2049 (offset_intervals): Tell GCC not to worry about length overflow
2050 when negating a negative length.
2051
2052 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2053 (overrun_check_free): Likewise.
2054
2055 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2056 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2057 word size.
2058
2059 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2060 (gnutls_make_error): Rename local to avoid shadowing.
2061 (gnutls_emacs_global_deinit): ifdef out; not used.
2062 (Fgnutls_boot): Use const for pointer to readonly storage.
2063 Comment out unused local. Fix pointer signedness problems.
2064
2065 * lread.c (openp): Don't stuff size_t into an 'int'.
2066 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2067 about possible signed overflow.
2068
2069 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2070 (GDK_KEY_g): Don't define if already defined.
2071 (xg_prepare_tooltip): Avoid pointer signedness problem.
2072 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2073
2074 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2075 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2076
2077 * xfns.c (Fx_window_property): Simplify a bit,
2078 to make a bit faster and to avoid GCC 4.6.0 warning.
2079 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2080
2081 * fns.c (internal_equal): Don't assume size_t fits in int.
2082
2083 * alloc.c (compact_small_strings): Tighten assertion a little.
2084
2085 Replace pEd with more-general pI, and fix some printf arg casts.
2086 * lisp.h (pI): New macro, generalizing old pEd macro to other
2087 conversion specifiers. For example, use "...%"pI"d..." rather
2088 than "...%"pEd"...".
2089 (pEd): Remove. All uses replaced with similar uses of pI.
2090 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2091 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2092 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2093 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2094 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2095 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2096 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2097 64-bit hosts.
2098 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2099 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2100 * print.c (safe_debug_print, print_object): Likewise.
2101 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2102 to int.
2103 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2104 avoiding the 0 flag, which is not portable.
2105 * process.c (Fmake_network_process): Use pI to avoid cast.
2106 * region-cache.c (pp_cache): Likewise.
2107 * xdisp.c (decode_mode_spec): Likewise.
2108 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2109 behavior on 64-bit hosts with printf arg.
2110 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2111 (x_stop_queuing_selection_requests): Likewise.
2112 (x_get_window_property): Don't truncate byte count to an 'int'
2113 when tracing.
2114
2115 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2116 here, since it parses constructs like leading '-' and spaces,
2117 which are not wanted; and it overflows with large numbers.
2118 Instead, simply match F[0-9]+, which is what is wanted anyway.
2119
2120 * alloc.c: Remove unportable assumptions about struct layout.
2121 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2122 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2123 (allocate_vectorlike, make_pure_vector): Use the new macros,
2124 plus offsetof, to remove unportable assumptions about struct layout.
2125 These assumptions hold on all porting targets that I know of, but
2126 they are not guaranteed, they're easy to remove, and removing them
2127 makes further changes easier.
2128
2129 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2130 This doesn't fix a bug but makes the code clearer.
2131 (string_overrun_cookie): Now const. Use initializers that
2132 don't formally overflow signed char, to avoid warnings.
2133 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2134 can cause Emacs to crash when string overrun checking is enabled.
2135 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2136 multiple of sizeof (EMACS_INT); it need not be, if
2137 alignof(EMACS_INT) < sizeof (EMACS_INT).
2138 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2139
2140 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2141
2142 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2143
2144 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2145
2146 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2147 supposed to be handshaking. (Bug#8556)
2148 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2149
2150 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2151
2152 * lisp.h (Qdebug): List symbol.
2153 * eval.c (Qdebug): Restore global linkage.
2154 * keyboard.c (debug-on-event): New variable.
2155 (handle_user_signal): Break into debugger when debug-on-event
2156 matches the current signal symbol.
2157
2158 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2159
2160 * alloc.c (check_sblock, check_string_bytes)
2161 (check_string_free_list): Convert to standard C.
2162
2163 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2164
2165 * w32.c (emacs_gnutls_push): Fix typo.
2166
2167 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2168
2169 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2170 "cast to pointer from integer of different size".
2171
2172 Improve doprnt and its use in verror. (Bug#8545)
2173 * doprnt.c (doprnt): Document the set of format control sequences
2174 supported by the function. Use SAFE_ALLOCA instead of always
2175 using `alloca'.
2176
2177 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2178 is one byte too soon. Don't use xrealloc; instead xfree and
2179 xmalloc anew.
2180
2181 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2182
2183 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2184 callbacks stage.
2185
2186 * gnutls.c: Renamed global_initialized to
2187 gnutls_global_initialized. Added internals for the
2188 :verify-hostname-error, :verify-error, and :verify-flags
2189 parameters of `gnutls-boot' and documented those parameters in the
2190 docstring. Start callback support.
2191 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2192 unless a fatal error occured. Call gnutls_alert_send_appropriate
2193 on error. Return error code.
2194 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2195 (emacs_gnutls_read): Likewise.
2196 (Fgnutls_boot): Return handshake error code.
2197 (emacs_gnutls_handle_error): New function.
2198 (wsaerror_to_errno): Likewise.
2199
2200 * w32.h (emacs_gnutls_pull): Add prototype.
2201 (emacs_gnutls_push): Likewise.
2202
2203 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2204 (emacs_gnutls_push): Likewise.
2205
2206 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2207
2208 * process.c (wait_reading_process_output): Check if GnuTLS
2209 buffered some data internally if no FDs are set for TLS
2210 connections.
2211
2212 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2213 (LIBS): Link to USER_LIBS.
2214 ($(BLD)/gnutls.$(0)): New target.
2215
2216 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2217
2218 * xdisp.c (handle_single_display_spec): Rename the
2219 display_replaced_before_p argument into display_replaced_p, to
2220 make it consistent with the commentary. Fix typos in the
2221 commentary.
2222
2223 * textprop.c (syms_of_textprop): Remove dead code.
2224 (copy_text_properties): Delete obsolete commentary about an
2225 interface that was deleted long ago. Fix typos in the description
2226 of arguments.
2227
2228 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2229 to changes in oldXMenu/XMenu.h from 2011-04-16.
2230 <menu_help_message, prev_menu_help_message>: Constify.
2231 (IT_menu_make_room): menu->help_text is now `const char **';
2232 adjust.
2233
2234 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2235 to changes in oldXMenu/XMenu.h from 2011-04-16.
2236 (struct XMenu): Declare `help_text' `const char **'.
2237
2238 * xfaces.c <Qunspecified>: Make extern again.
2239
2240 * syntax.c: Include sys/types.h before including regex.h, as
2241 required by Posix.
2242
2243 * doc.c (get_doc_string): Improve the format passed to `error'.
2244
2245 * doprnt.c (doprnt): Improve commentary.
2246
2247 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2248
2249 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2250 them with etags.
2251
2252 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2253 changes in globals.h immediately force recompilation.
2254 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2255 $(CURDIR)/s/ms-w32.h.
2256 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2257
2258 * character.c (Fchar_direction): Function deleted.
2259 (syms_of_character): Don't defsubr it.
2260 <char-direction-table>: Deleted.
2261
2262 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2263
2264 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2265 * doprnt.c: Include limits.h.
2266 (SIZE_MAX): New macro.
2267 (doprnt): Return a size_t value. 2nd arg is now size_t.
2268 Many local variables are now size_t instead of int or unsigned.
2269 Improve overflow protection. Support `l' modifier for integer
2270 conversions. Support %l conversion. Don't assume an EMACS_INT
2271 argument for integer conversions and for %c.
2272
2273 * lisp.h (doprnt): Restore prototype.
2274
2275 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2276 $(SRC)/character.h.
2277
2278 * Makefile.in (base_obj): Add back doprnt.o.
2279
2280 * deps.mk (doprnt.o): Add back prerequisites.
2281 (callint.o): Depend on character.h.
2282
2283 * eval.c (internal_lisp_condition_case): Include the handler
2284 representation in the error message.
2285 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2286 when breaking from the loop.
2287
2288 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2289
2290 * callint.c (Fcall_interactively): When displaying error message
2291 about invalid control letter, pass the character's codepoint, not
2292 a pointer to its multibyte form. Improve display of the character
2293 in octal and display also its hex code.
2294
2295 * character.c (char_string): Use %x to display the (unsigned)
2296 codepoint of an invalid character, to avoid displaying a bogus
2297 negative value.
2298
2299 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2300 `error', not SYMBOL_NAME itself.
2301
2302 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2303 character arguments to `error'.
2304
2305 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2306 to `error' in error message about FINAL_CHAR argument. Make sure
2307 FINAL_CHAR is a character, and use %c when it is passed as
2308 argument to `error'.
2309
2310 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2311
2312 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2313
2314 * w32.c: Include <time.h>.
2315 (sys_localtime): New function.
2316
2317 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
2318
2319 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2320
2321 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
2322
2323 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
2324
2325 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2326 zombies (Bug#8467).
2327
2328 2011-04-19 Eli Zaretskii <eliz@gnu.org>
2329
2330 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2331 gl_state.e_property when gl_state.object is Qt.
2332
2333 * insdel.c (make_gap_larger): Remove limitation of buffer size
2334 to <= INT_MAX.
2335
2336 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
2337
2338 * xdisp.c (lookup_glyphless_char_display)
2339 (produce_glyphless_glyph): Handle cons cell entry in
2340 glyphless-char-display.
2341 (Vglyphless_char_display): Document it.
2342
2343 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2344 glyphless-char-display.
2345
2346 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
2347
2348 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2349
2350 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2351
2352 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2353 definition for no-X builds.
2354
2355 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
2356
2357 Static checks with GCC 4.6.0 and non-default toolkits.
2358
2359 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2360
2361 * process.c (keyboard_bit_set): Define only if SIGIO.
2362 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2363 (send_process): Repair possible setjmp clobbering.
2364
2365 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2366
2367 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2368
2369 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2370
2371 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2372 Define only if needed.
2373
2374 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2375 by pacifying GCC about it. Maybe it's time to retire it?
2376 * xfaces.c (USG, __TIMEVAL__): Likewise.
2377
2378 * dispextern.h (struct redisplay_interface): Rename param
2379 to avoid shadowing.
2380 * termhooks.h (struct terminal): Likewise.
2381 * xterm.c (xembed_send_message): Likewise.
2382
2383 * insdel.c (make_gap_smaller): Define only if
2384 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2385
2386 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2387 it.
2388
2389 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2390 so that we aren't warned about unused symbols.
2391
2392 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2393
2394 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
2395
2396 * xfns.c (x_real_positions): Mark locals as initialized.
2397
2398 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2399
2400 * xterm.c: Fix problems found by static analysis with other toolkits.
2401 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
2402 (x_dispatch_event): Declare static if USE_GTK, and
2403 define if USE_GTK || USE_X_TOOLKIT.
2404 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
2405 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
2406 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2407 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
2408
2409 * xmenu.c (menu_help_callback): Pointer type fixes.
2410 Use const pointers when pointing at readonly data. Avoid pointer
2411 signedness clashes.
2412 (FALSE): Remove unused macro.
2413 (update_frame_menubar): Remove unused decl.
2414
2415 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2416
2417 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2418 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2419 (single_menu_item): Rename local to avoid shadowing.
2420
2421 * keyboard.c (make_lispy_event): Remove unused local var.
2422
2423 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2424 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2425
2426 * bitmaps: Change bitmaps from unsigned char back to the X11
2427 compatible char. Avoid the old compiler warnings about
2428 out-of-range initializers by using, for example, '\xab' rather
2429 than 0xab.
2430
2431 * xgselect.c (xgselect_initialize): Check vs interface
2432 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2433
2434 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2435
2436 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2437 to read-only memory.
2438
2439 * fns.c (vector): Remove; this old hack is no longer needed.
2440
2441 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
2442 Remove unused var.
2443 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2444
2445 * xrdb.c (x_load_resources): Omit unused local.
2446
2447 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
2448 (x_window): Rename locals to avoid shadowing.
2449 (USG): Use the kludged USG macro, to pacify gcc.
2450
2451 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
2452 (x_term_init): Remove local to avoid shadowing.
2453
2454 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
2455
2456 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2457 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2458
2459 2011-04-16 Eli Zaretskii <eliz@gnu.org>
2460
2461 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2462
2463 Fix regex.c, syntax.c and friends for buffers > 2GB.
2464 * syntax.h (struct gl_state_s): Declare character position members
2465 EMACS_INT.
2466
2467 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2468
2469 * textprop.c (verify_interval_modification, interval_of):
2470 Declare arguments EMACS_INT.
2471
2472 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2473 EMACS_INT.
2474
2475 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2476
2477 * indent.c (Fvertical_motion): Local variable it_start is now
2478 EMACS_INT.
2479
2480 * regex.c (re_match, re_match_2, re_match_2_internal)
2481 (bcmp_translate, regcomp, regexec, print_double_string)
2482 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2483 (re_compile_pattern, re_exec): Declare arguments and local
2484 variables `size_t' and `ssize_t' and return values `regoff_t', as
2485 appropriate.
2486 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2487 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2488 <compile_stack_type>: `size' and `avail' are now `size_t'.
2489
2490 * regex.h <regoff_t>: Use ssize_t, not int.
2491 (re_search, re_search_2, re_match, re_match_2): Arguments that
2492 specify buffer/string position and length are now ssize_t and
2493 size_t. Return type is regoff_t.
2494
2495 2011-04-16 Ben Key <bkey76@gmail.com>
2496
2497 * nsfont.m: Fixed bugs in ns_get_family and
2498 ns_descriptor_to_entity that were caused by using free to
2499 deallocate memory blocks that were allocated by xmalloc (via
2500 xstrdup). This caused Emacs to crash when compiled with
2501 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2502 --enable-checking=xmallocoverrun). xfree is now used to
2503 deallocate these memory blocks.
2504
2505 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
2506
2507 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2508
2509 emacs_write: Accept and return EMACS_INT for sizes.
2510 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2511 et seq.
2512 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2513 Accept and return EMACS_INT.
2514 (emacs_gnutls_write): Return the number of bytes written on
2515 partial writes.
2516 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
2517 (emacs_read, emacs_write): Remove check for negative size, as the
2518 Emacs source code has been audited now.
2519 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2520 (emacs_read, emacs_write): Use it.
2521 * process.c (send_process): Adjust to the new signatures of
2522 emacs_write and emacs_gnutls_write. Do not attempt to store
2523 a byte offset into an 'int'; it might overflow.
2524 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
2525
2526 * sound.c: Don't assume sizes fit in 'int'.
2527 (struct sound_device.period_size, alsa_period_size):
2528 Return EMACS_INT, not int.
2529 (struct sound_device.write, vox_write, alsa_write):
2530 Accept EMACS_INT, not int.
2531 (wav_play, au_play): Use EMACS_INT to store sizes and to
2532 record read return values.
2533
2534 2011-04-15 Ben Key <bkey76@gmail.com>
2535
2536 * keyboard.c (Qundefined): Don't declare static since it is used
2537 in nsfns.m.
2538 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2539 static since they are used in nsfont.m.
2540
2541 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2542
2543 * process.c (Qprocessp): Don't declare static.
2544 * lisp.h (Qprocessp): Declare again.
2545
2546 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
2547
2548 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2549
2550 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2551
2552 Improve C-level modularity by making more things 'static'.
2553
2554 Don't publish debugger-only interfaces to other modules.
2555 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2556 (verify_bytepos, count_markers): Move decls to the only modules
2557 that need them.
2558 * region-cache.h (pp_cache): Likewise.
2559 * window.h (check_all_windows): Likewise.
2560 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2561
2562 * sysdep.c (croak): Now static, if
2563 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2564 * syssignal.h (croak): Declare only if not static.
2565
2566 * alloc.c (refill_memory_reserve): Now static if
2567 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2568 * lisp.h (refill_memory_reserve): Declare only if not static.
2569
2570 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2571 Define only if USE_LUCID.
2572
2573 * xrdb.c (x_customization_string, x_rm_string): Now static.
2574
2575 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2576 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2577
2578 * xdisp.c (draw_row_with_mouse_face): Now static.
2579 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2580
2581 * window.h (check_all_windows): Mark externally visible.
2582
2583 * window.c (window_deletion_count): Now static.
2584
2585 * undo.c: Make symbols static if they're not exported.
2586 (last_undo_buffer, last_boundary_position, pending_boundary):
2587 Now static.
2588
2589 * textprop.c (interval_insert_behind_hooks): Now static.
2590 (interval_insert_in_front_hooks): Likewise.
2591
2592 * term.c: Make symbols static if they're not exported.
2593 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2594 (max_frame_lines, tty_set_terminal_modes):
2595 (tty_reset_terminal_modes, tty_turn_off_highlight):
2596 (get_tty_terminal): Now static.
2597 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2598 * termhooks.h (term_mouse_moveto): Do not declare if
2599 HAVE_WINDOW_SYSTEM.
2600 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2601 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2602
2603 * sysdep.c: Make symbols static if they're not exported.
2604 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2605 Now static.
2606 (sigprocmask_set, full_mask): Remove; unused.
2607 (wait_debugging): Mark as visible.
2608 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2609 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2610
2611 * syntax.c (syntax_temp): Define only if !__GNUC__.
2612
2613 * sound.c (current_sound_device, current_sound): Now static.
2614
2615 * search.c (searchbufs, searchbuf_head): Now static.
2616
2617 * scroll.c (scroll_cost): Remove; unused.
2618 * dispextern.h (scroll_cost): Remove decl.
2619
2620 * region-cache.h (pp_cache): Mark as externally visible.
2621
2622 * process.c: Make symbols static if they're not exported.
2623 (process_tick, update_tick, create_process, chan_process):
2624 (Vprocess_alist, proc_buffered_char, datagram_access):
2625 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2626 (deactivate_process): Mark defn as static, as well as decl.
2627 * lisp.h (create_process): Remove decl.
2628 * process.h (chan_process, Vprocess_alist): Remove decls.
2629
2630 * print.c: Make symbols static if they're not exported.
2631 (print_depth, new_backquote_output, being_printed, print_buffer):
2632 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2633 (print_interval, print_number_index, initial_stderr_stream):
2634 Now static.
2635 * lisp.h (Fprinc): Remove decl.
2636 (debug_output_compilation_hack): Mark as externally visible.
2637
2638 * sysdep.c (croak): Move decl from here to syssignal.h.
2639 * syssignal.h (croak): Put it here, so the API can be checked when
2640 'croak' is called from dissociate_if_controlling_tty.
2641
2642 * minibuf.c: Make symbols static if they're not exported.
2643 (minibuf_save_list, choose_minibuf_frame): Now static.
2644 * lisp.h (choose_minibuf_frame): Remove decl.
2645
2646 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2647
2648 * lread.c: Make symbols static if they're not exported.
2649 (read_objects, initial_obarray, oblookup_last_bucket_number):
2650 Now static.
2651 (make_symbol): Remove; unused.
2652 * lisp.h (initial_obarray, make_symbol): Remove decls.
2653
2654 * keyboard.c: Make symbols static if they're not exported.
2655 (single_kboard, recent_keys_index, total_keys, recent_keys):
2656 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2657 (this_single_command_key_start, echoing, last_auto_save):
2658 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2659 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2660 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2661 (Vlispy_mouse_stem, double_click_count):
2662 Now static.
2663 (force_auto_save_soon): Define only if SIGDANGER.
2664 (ignore_mouse_drag_p): Now static if
2665 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2666 (print_help): Remove; unused.
2667 (stop_character, last_timer_event): Mark as externally visible.
2668 * keyboard.h (ignore_mouse_drag_p): Declare only if
2669 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2670 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2671 * lisp.h (echoing): Remove decl.
2672 (force_auto_save_soon): Declare only if SIGDANGER.
2673 * xdisp.c (redisplay_window): Simplify code, to make it more
2674 obvious that ignore_mouse_drag_p is not accessed if !defined
2675 USE_GTK && !defined HAVE_NS.
2676
2677 * intervals.c: Make symbols static if they're not exported.
2678 (merge_properties_sticky, merge_interval_right, delete_interval):
2679 Now static.
2680 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2681
2682 * insdel.c: Make symbols static if they're not exported.
2683 However, leave prepare_to_modify_buffer alone. It's never
2684 called from outside this function, but that appears to be a bug.
2685 (combine_after_change_list, combine_after_change_buffer):
2686 (adjust_after_replace, signal_before_change): Now static.
2687 (adjust_after_replace_noundo): Remove; unused.
2688 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
2689 (signal_before_change): Remove decls.
2690
2691 * indent.c (val_compute_motion, val_vmotion): Now static.
2692
2693 * image.c: Make symbols static if they're not exported.
2694 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2695 if USE_GTK.
2696 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2697 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2698
2699 * fringe.c (standard_bitmaps): Now static.
2700 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2701
2702 * frame.c: Make symbols static if they're not exported.
2703 (x_report_frame_params, make_terminal_frame): Now static.
2704 (get_frame_param): Now static, unless HAVE_NS.
2705 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2706 (x_get_resource_string): Remove; not used.
2707 * frame.h (make_terminal_frame, x_report_frame_params):
2708 (x_get_resource_string); Remove decls.
2709 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2710 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2711
2712 * font.c, fontset.c: Make symbols static if they're not exported.
2713 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2714 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2715 * font.c (font_close_object): Now static.
2716 * font.h (font_close_object): Remove.
2717 * fontset.c (FONTSET_OBJLIST): Remove.
2718 (free_realized_fontset) #if-0 the body, which does nothing.
2719 (face_suitable_for_char_p): #if-0, as it's never called.
2720 * fontset.h (face_suitable_for_char_p): Remove decl.
2721 * xfaces.c (face_at_string_position):
2722 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
2723 since 0 is always ASCII.
2724
2725 * fns.c (weak_hash_tables): Now static.
2726
2727 * fileio.c: Make symbols static if they're not exported.
2728 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2729 (Vwrite_region_annotation_buffers): Now static.
2730
2731 * eval.c: Make symbols static if they're not exported.
2732 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2733 * lisp.h (backtrace_list): Remove decl.
2734
2735 * emacs.c: Make symbols static if they're not exported.
2736 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2737 (fatal_error_code, fatal_error_signal_hook, standard_args):
2738 Now static.
2739 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2740 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2741 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2742 * lisp.h (fatal_error_signal_hook): Remove decl.
2743 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2744
2745 * editfns.c: Move a (normally-unused) function to its only use.
2746 * editfns.c, lisp.h (get_operating_system_release): Remove.
2747 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2748 worth the hassle of breaking this out.
2749
2750 * xterm.c: Make symbols static if they're not exported.
2751 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2752 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2753 (x_destroy_window, x_delete_display):
2754 Now static.
2755 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2756 (x_mouse_leave): Remove; unused.
2757 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2758 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2759 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2760 Remove decls.
2761 (x_mouse_leave): Declare only if WINDOWSNT.
2762 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2763 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2764 USE_X_TOOLKIT.
2765
2766 * ftxfont.c: Make symbols static if they're not exported.
2767 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2768 HAVE_FREETYPE.
2769 * font.h (ftxfont_driver): Likewise.
2770
2771 * xfns.c: Make symbols static if they're not exported.
2772 (x_last_font_name, x_display_info_for_name):
2773 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2774 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2775 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2776 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2777 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2778 (last_show_tip_args): Now static.
2779 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2780 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2781 (x_screen_planes): Remove; unused.
2782 * dispextern.h (x_screen_planes): Remove decl.
2783
2784 * dispnew.c: Make symbols static if they're not exported.
2785 * dispextern.h (redraw_garbaged_frames, scrolling):
2786 (increment_row_positions): Remove.
2787 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2788 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2789 Now static.
2790 (redraw_garbaged_frames): Remove; unused.
2791
2792 * xfaces.c: Make symbols static if they're not exported.
2793 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2794 Remove decls.
2795 * xterm.h (defined_color): Remove decls.
2796 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2797 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2798 (menu_face_changed_default, defined_color, free_realized_face):
2799 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2800 (ascii_face_of_lisp_face): Remove; unused.
2801
2802 * xdisp.c: Make symbols static if they're not exported.
2803 * dispextern.h (scratch_glyph_row, window_box_edges):
2804 (glyph_to_pixel_coords, set_cursor_from_row):
2805 (get_next_display_element, set_iterator_to_next):
2806 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2807 (show_mouse_face): Remove decls
2808 * frame.h (message_buf_print): Likewise.
2809 * lisp.h (pop_message, set_message, check_point_in_composition):
2810 Likewise.
2811 * xterm.h (set_vertical_scroll_bar): Likewise.
2812 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2813 (message_buf_print, scratch_glyph_row, displayed_buffer):
2814 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2815 (get_next_display_element, show_mouse_face, window_box_edges):
2816 (frame_to_window_pixel_xy, check_point_in_composition):
2817 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2818 (glyph_to_pixel_coords): Remove; unused.
2819
2820 * dired.c (file_name_completion): Now static.
2821
2822 * dbusbind.c (xd_in_read_queued_messages): Now static.
2823
2824 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2825 * data.c (circular_list_error): Remove.
2826
2827 * commands.h (last_point_position, last_point_position_buffer):
2828 (last_point_position_window): Remove decls.
2829 * keyboard.c: Make these variables static.
2830
2831 * coding.h (coding, code_convert_region, encode_coding_gap):
2832 Remove decls.
2833 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2834 (iso_code_class, detect_coding, code_convert_region): Now static.
2835 (encode_coding_gap): Remove; unused.
2836
2837 * chartab.c (chartab_chars, chartab_bits): Now static.
2838
2839 * charset.h (charset_iso_8859_1): Remove decl.
2840 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2841 Now static.
2842
2843 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2844 * ccl.c (Vccl_program_table): Now static.
2845 (check_ccl_update): Remove; unused.
2846
2847 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2848 * category.h: ... from here.
2849 * category.c (check_category_table, set_category_set): Now static.
2850
2851 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2852 * lisp.h: Remove these decls.
2853
2854 * buffer.c (buffer_count): Remove unused var.
2855
2856 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2857 so that it's not optimized away.
2858 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2859 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2860 exported only to the debugger.
2861
2862 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2863 * atimer.h (run_all_atimers): Remove; not exported.
2864
2865 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2866 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2867 was inaccessible from Lisp.
2868 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2869 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2870
2871 alloc.c: Import and export fewer symbols, and remove unused items.
2872 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2873 is defined.
2874 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2875 it's not optimized away by whole-program optimization.
2876 (message_enable_multibyte, free_misc): Remove.
2877 (catchlist, handlerlist, mark_backtrace):
2878 Declare only if BYTE_MARK_STACK.
2879 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2880 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2881 (message_enable_multibyte): Remove decl.
2882 (free_misc, interval_free_list, float_block, float_block_index):
2883 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2884 (cons_free_list, last_marked_index):
2885 Now static.
2886 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2887 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2888 (mark_backtrace): Define only if BYTE_MARK_STACK.
2889 * xdisp.c (message_enable_multibyte): Now static.
2890
2891 Declare Lisp_Object Q* variables to be 'static' if not exported.
2892 This makes it easier for human readers (and static analyzers)
2893 to see whether these variables are used from other modules.
2894 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2895 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2896 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2897 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2898 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2899 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2900 * xmenu.c, xselect.c:
2901 Declare Q* vars static if they are not used in other modules.
2902 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2903 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2904 Remove decls of unexported vars.
2905 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2906
2907 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2908
2909 Make Emacs functions such as Fatom 'static' by default.
2910 This makes it easier for human readers (and static analyzers)
2911 to see whether these functions can be called from other modules.
2912 DEFUN now defines a static function. To make the function external
2913 so that it can be used in other C modules, use the new macro DEFUE.
2914 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2915 (Finit_image_library):
2916 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2917 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2918 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2919 Remove decls, since these functions are now static.
2920 (Funintern, Fget_internal_run_time): New decls, since these functions
2921 were already external.
2922
2923 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2924 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2925 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2926 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2927 * keyboard.c, keymap.c, lread.c:
2928 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2929 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2930 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2931 Mark functions with DEFUE instead of DEFUN,
2932 if they are used in other modules.
2933 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2934 decls for now-static functions.
2935 * buffer.h (Fdelete_overlay): Remove decl.
2936 * callproc.c (Fgetenv_internal): Mark as internal.
2937 * composite.c (Fremove_list_of_text_properties): Remove decl.
2938 (Fcomposition_get_gstring): New forward static decl.
2939 * composite.h (Fcomposite_get_gstring): Remove decl.
2940 * dired.c (Ffile_attributes): New forward static decl.
2941 * doc.c (Fdocumntation_property): New forward static decl.
2942 * eval.c (Ffetch_bytecode): New forward static decl.
2943 (Funintern): Remove extern decl; now in .h file where it belongs.
2944 * fileio.c (Fmake_symbolic_link): New forward static decl.
2945 * image.c (Finit_image_library): New forward static decl.
2946 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2947 * intervals.h (Fprevious_property_change):
2948 (Fremove_list_of_text_properties): Remove decls.
2949 * keyboard.c (Fthis_command_keys): Remove decl.
2950 (Fcommand_execute): New forward static decl.
2951 * keymap.c (Flookup_key): New forward static decl.
2952 (Fcopy_keymap): Now static.
2953 * keymap.h (Flookup_key): Remove decl.
2954 * process.c (Fget_process): New forward static decl.
2955 (Fprocess_datagram_address): Mark as internal.
2956 * syntax.c (Fsyntax_table_p): New forward static decl.
2957 (skip_chars): Remove duplicate decl.
2958 * textprop.c (Fprevious_property_change): New forward static decl.
2959 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2960 Now internal.
2961 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2962 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2963
2964 * editfns.c (Fformat): Remove unreachable code.
2965
2966 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2967
2968 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2969 change. (Bug#8496)
2970
2971 2011-04-13 Eli Zaretskii <eliz@gnu.org>
2972
2973 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2974 when at ZV. (Bug#8487)
2975
2976 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2977
2978 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2979 (Bug#8437)
2980 * keyboard.c (parse_tool_bar_item): Likewise.
2981 * sound.c (sound_cleanup, alsa_close): Likewise.
2982 * termcap.c (tgetent): Likewise.
2983 * xfns.c (x_default_font_parameter): Likewise.
2984 * xsettings.c (read_and_apply_settings): Likewise.
2985
2986 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2987 (overrun_check_free): Protoize.
2988
2989 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2990
2991 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2992 since callers should never pass a negative size.
2993 Change the signature to match that of plain 'read' and 'write'; see
2994 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2995 * lisp.h: Update prototypes of emacs_write and emacs_read.
2996
2997 2011-04-11 Eli Zaretskii <eliz@gnu.org>
2998
2999 * xdisp.c (redisplay_window): Don't try to determine the character
3000 position of the scroll margin if the window start point w->startp
3001 is outside the buffer's accessible region. (Bug#8468)
3002
3003 2011-04-10 Eli Zaretskii <eliz@gnu.org>
3004
3005 Fix write-region and its subroutines for buffers > 2GB.
3006 * fileio.c (a_write, e_write): Modify declaration of arguments and
3007 local variables to support buffers larger than 2GB.
3008 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3009
3010 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3011 argument, local variables, and return value.
3012
3013 * lisp.h: Update prototypes of emacs_write and emacs_read.
3014
3015 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3016
3017 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
3018
3019 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3020
3021 Fix more problems found by GCC 4.6.0's static checks.
3022
3023 * xdisp.c (vmessage): Use a better test for character truncation.
3024
3025 * charset.c (load_charset_map): <, not <=, for optimization,
3026 and to avoid potential problems with integer overflow.
3027 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
3028 * casetab.c (set_identity, shuffle): Likewise.
3029 * editfns.c (Fformat): Likewise.
3030 * syntax.c (skip_chars): Likewise.
3031
3032 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3033 This also lets GCC 4.6.0 generate slightly better loop code.
3034
3035 * callint.c (Fcall_interactively): <, not <=, for optimization.
3036 (Fcall_interactively): Count the number of arguments produced,
3037 not the number of arguments given. This is simpler and lets GCC
3038 4.6.0 generate slightly better code.
3039
3040 * ftfont.c: Distingish more carefully between FcChar8 and char.
3041 The previous code passed unsigned char * to a functions like
3042 strlen and xstrcasecmp that expect char *, which does not
3043 conform to the C standard.
3044 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3045 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3046 char * when the C standard requires it.
3047
3048 * keyboard.c (read_char): Remove unused var.
3049
3050 * eval.c: Port to Windows vsnprintf (Bug#8435).
3051 Include <limits.h>.
3052 (SIZE_MAX): Define if the headers do not.
3053 (verror): Do not give up if vsnprintf returns a negative count.
3054 Instead, grow the buffer. This ports to Windows vsnprintf, which
3055 does not conform to C99. Problem reported by Eli Zaretskii.
3056 Also, simplify the allocation scheme, by avoiding the need for
3057 calling realloc, and removing the ALLOCATED variable.
3058
3059 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3060
3061 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3062 But keep the doprint source code for now, as we might revamp it
3063 and use it again (Bug#8435).
3064 * lisp.h (doprnt): Remove.
3065 * Makefile.in (base_obj): Remove doprnt.o.
3066 * deps.mk (doprnt.o): Remove.
3067
3068 error: Print 32- and 64-bit integers portably (Bug#8435).
3069 Without this change, on typical 64-bit hosts error ("...%d...", N)
3070 was used to print both 32- and 64-bit integers N, which relied on
3071 undefined behavior.
3072 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3073 New macro.
3074 * lisp.h (error, verror): Mark as printf-like functions.
3075 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3076 Report overflow in size calculations when allocating printf buffer.
3077 Do not truncate output string at its first null byte.
3078 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3079 Truncate the output at a character boundary, since vsnprintf does not
3080 do that.
3081 * charset.c (check_iso_charset_parameter): Convert internal
3082 character to string before calling 'error', since %c now has the
3083 printf meaning.
3084 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3085 overflow when computing char to be passed to 'error'. Do not
3086 pass Lisp_Object to 'error'; pass the integer instead.
3087 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3088 formatted with plain %d.
3089
3090 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3091
3092 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3093
3094 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3095
3096 * xterm.c (x_catch_errors): Remove duplicate declaration.
3097
3098 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3099
3100 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3101
3102 2011-04-10 Jim Meyering <meyering@redhat.com>
3103
3104 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3105 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3106 return ssize_t not "int", and use size_t as the buffer length.
3107 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3108 * gnutls.h: Update declarations.
3109 * process.c (read_process_output): Use ssize_t, to match.
3110 (send_process): Likewise.
3111
3112 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3113
3114 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3115
3116 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3117
3118 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3119 Use unsigned char, to match FcChar8 type definition.
3120
3121 * xterm.c (handle_one_xevent):
3122 * xmenu.c (create_and_show_popup_menu):
3123 * xselect.c (x_decline_selection_request)
3124 (x_reply_selection_request): Avoid type-punned deref of X events.
3125
3126 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3127
3128 Fix some uses of `int' instead of EMACS_INT.
3129 * search.c (string_match_1, fast_string_match)
3130 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3131 (scan_buffer, find_next_newline_no_quit)
3132 (find_before_next_newline, search_command, Freplace_match)
3133 (Fmatch_data): Make some `int' variables be EMACS_INT.
3134
3135 * xdisp.c (display_count_lines): 3rd argument and return value now
3136 EMACS_INT. All callers changed.
3137 (pint2hrstr): Last argument is now EMACS_INT.
3138
3139 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3140 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3141 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3142 (decode_coding_utf_16, decode_coding_emacs_mule)
3143 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3144 (decode_coding_ccl, decode_coding_charset)
3145 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3146 (decode_coding_iso_2022, decode_coding_emacs_mule)
3147 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3148 <char_offset, last_offset>: Declare EMACS_INT.
3149 (encode_coding_utf_8, encode_coding_utf_16)
3150 (encode_coding_emacs_mule, encode_invocation_designation)
3151 (encode_designation_at_bol, encode_coding_iso_2022)
3152 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3153 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3154 Declare EMACS_INT.
3155 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3156 (encode_invocation_designation): Last argument P_NCHARS is now
3157 EMACS_INT.
3158 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3159 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3160
3161 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3162 All users changed.
3163
3164 * ccl.c (Fccl_execute_on_string): Declare some variables
3165 EMACS_INT.
3166
3167 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3168
3169 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3170
3171 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3172
3173 * process.c (Fformat_network_address): Doc fix.
3174
3175 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3176
3177 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3178
3179 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3180
3181 * keyboard.c (read_char): Call Lisp function help-form-show,
3182 instead of using internal_with_output_to_temp_buffer.
3183 (Qhelp_form_show): New var.
3184 (syms_of_keyboard): Use DEFSYM macro.
3185
3186 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3187
3188 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3189
3190 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3191
3192 * process.c (Flist_processes): Remove to Lisp.
3193 (list_processes_1): Delete.
3194
3195 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3196
3197 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3198
3199 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3200
3201 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3202
3203 Fix more problems found by GCC 4.6.0's static checks.
3204
3205 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3206
3207 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3208
3209 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3210
3211 * xdisp.c (vmessage): Mark as a printf-like function.
3212
3213 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3214
3215 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3216
3217 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3218 printf-like functions.
3219 (tiff_load): Add casts to remove these marks before passing them
3220 to system-supplied API.
3221
3222 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3223
3224 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3225 This avoids several warnings with gcc -Wstrict-overflow.
3226 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3227 directly, rather than having caller test rule sign. This avoids
3228 some unnecessary tests.
3229 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3230 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3231 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3232
3233 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3234 (xfont_open): Avoid unnecessary tests.
3235
3236 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3237
3238 * composite.h, composite.c (composition_gstring_put_cache):
3239 Use EMACS_INT, not int, for length.
3240
3241 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3242 breaking out part of COMPOSITION_DECODE_RULE.
3243 (COMPOSITION_DECODE_RULE): Use it.
3244 * composite.c (get_composition_id): Remove unused local vars,
3245 by using the new macro.
3246
3247 * textprop.c (set_text_properties_1): Change while to do-while,
3248 since the condition is always true at first.
3249
3250 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3251 (interval_deletion_adjustment): Return unsigned value.
3252 All uses changed.
3253
3254 * process.c (list_processes_1, create_pty, read_process_output):
3255 (exec_sentinel): Remove vars that were set but not used.
3256 (create_pty): Remove unnecessary "volatile"s.
3257 (Fnetwork_interface_info): Avoid possibility of int overflow.
3258 (read_process_output): Do adaptive read buffering even if carryover.
3259 (read_process_output): Simplify nbytes computation if buffered.
3260
3261 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3262
3263 * syntax.c (scan_words): Remove var that was set but not used.
3264 (update_syntax_table): Use unsigned instead of int.
3265
3266 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3267 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3268 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3269
3270 * print.c (print_error_message): Avoid int overflow.
3271
3272 * font.c (font_list_entities): Redo for clarity,
3273 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3274
3275 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3276 (font_score): Avoid potential overflow in diff calculation.
3277
3278 * fns.c (substring_both): Remove var that is set but not used.
3279 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3280
3281 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3282
3283 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3284 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3285 can always succeed if overflow has undefined behavior.
3286
3287 * search.c (boyer_moore, wordify): Remove vars set but not used.
3288 (wordify): Omit three unnecessary tests.
3289
3290 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3291 All callers changed. This avoids the need for an unused var.
3292
3293 * casefiddle.c (casify_region): Remove var that is set but not used.
3294
3295 * dired.c (file_name_completion): Remove var that is set but not used.
3296
3297 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3298
3299 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
3300 (Finsert_file_contents): Remove unnecessary code checking fd.
3301
3302 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3303 Check for integer overflow on size calculations.
3304
3305 * buffer.c (Fprevious_overlay_change): Remove var that is set
3306 but not used.
3307
3308 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3309 Remove vars that are set but not used.
3310 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
3311 (timer_check_2): Mark vars as initialized.
3312
3313 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3314
3315 * image.c (lookup_image): Remove var that is set but not used.
3316 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
3317
3318 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3319 that are set but not used.
3320
3321 * xfns.c (make_invisible_cursor): Don't return garbage
3322 if XCreateBitmapFromData fails (Bug#8410).
3323
3324 * xselect.c (x_get_local_selection, x_handle_property_notify):
3325 Remove vars that are set but not used.
3326
3327 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
3328 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
3329
3330 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3331 Remove var that is set but not used.
3332 (scroll_bar_windows_size): Now size_t, not int.
3333 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3334 Check for overflow.
3335
3336 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3337 (map_tty_color) [!defined MSDOS]: Likewise.
3338
3339 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3340
3341 * coding.c: Remove vars that are set but not used.
3342 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3343 All callers changed.
3344 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3345 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3346 (decode_coding_charset): Remove vars that are set but not used.
3347
3348 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3349 that is set but not used.
3350
3351 * print.c (print_object): Remove var that is set but not used.
3352
3353 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
3354 The gnulib version avoids calling malloc in the usual case,
3355 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3356 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3357 * filelock.c (current_lock_owner): Likewise.
3358 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3359 * sysdep.c: Include allocator.h, careadlinkat.h.
3360 (emacs_no_realloc_allocator): New static constant.
3361 (emacs_readlink): New function.
3362 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3363 ../lib/careadlinkat.h.
3364
3365 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3366
3367 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3368 first non-nil return value).
3369
3370 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3371
3372 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3373 if not defined (Bug#8403).
3374
3375 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3376
3377 * xdisp.c (display_count_lines): Remove parameter `start',
3378 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3379 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3380 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3381 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3382 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3383 and thereabouts. All callers changed.
3384 (get_per_char_metric): Remove parameter `f', unused since
3385 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3386
3387 2011-04-02 Jim Meyering <meyering@redhat.com>
3388
3389 do not dereference NULL upon failed strdup
3390 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3391 (ns_get_family): Likewise.
3392
3393 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3394
3395 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3396
3397 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3398
3399 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3400 later (Bug#8403).
3401
3402 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3403
3404 Add lexical binding.
3405
3406 * window.c (Ftemp_output_buffer_show): New fun.
3407 (Fsave_window_excursion):
3408 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3409
3410 * lread.c (lisp_file_lexically_bound_p): New function.
3411 (Fload): Bind Qlexical_binding.
3412 (readevalloop): Remove `evalfun' arg.
3413 Bind Qinternal_interpreter_environment.
3414 (Feval_buffer): Bind Qlexical_binding.
3415 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3416 Mark as dynamic.
3417 (syms_of_lread): Declare `lexical-binding'.
3418
3419 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3420
3421 * keyboard.c (eval_dyn): New fun.
3422 (menu_item_eval_property): Use it.
3423
3424 * image.c (parse_image_spec): Use Ffunctionp.
3425
3426 * fns.c (concat, mapcar1): Accept byte-code-functions.
3427
3428 * eval.c (Fsetq): Handle lexical vars.
3429 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3430 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3431 (FletX, Flet): Obey lexical binding.
3432 (Fcommandp): Handle closures.
3433 (Feval): New `lexical' arg.
3434 (eval_sub): New function extracted from Feval. Use it almost
3435 everywhere where Feval was used. Look up vars in lexical env.
3436 Handle closures.
3437 (Ffunctionp): Move from subr.el.
3438 (Ffuncall): Handle closures.
3439 (apply_lambda): Remove `eval_flags'.
3440 (funcall_lambda): Handle closures and new byte-code-functions.
3441 (Fspecial_variable_p): New function.
3442 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3443 but without exporting it to Lisp.
3444
3445 * doc.c (Fdocumentation, store_function_docstring):
3446 * data.c (Finteractive_form): Handle closures.
3447
3448 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3449 interactive spec.
3450
3451 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3452 New byte-codes.
3453 (exec_byte_code): New function extracted from Fbyte_code to handle new
3454 calling convention for byte-code-functions. Add new byte-codes.
3455
3456 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
3457
3458 * alloc.c (Fmake_symbol): Init new `declared_special' field.
3459
3460 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3461
3462 * xdisp.c (redisplay_internal): Fix prototype.
3463
3464 2011-03-31 Eli Zaretskii <eliz@gnu.org>
3465
3466 * xdisp.c (SCROLL_LIMIT): New macro.
3467 (try_scrolling): Use it when setting scroll_limit.
3468 Limit scrolling to 100 screen lines.
3469 (redisplay_window): Even when falling back on "recentering",
3470 position point in the window according to scroll-conservatively,
3471 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3472
3473 (try_scrolling): When point is above the window, allow searching
3474 as far as scroll_max, or one screenful, to compute vertical
3475 distance from PT to the scroll margin position. This prevents
3476 try_scrolling from unnecessarily failing when
3477 scroll-conservatively is set to a value slightly larger than the
3478 window height. Clean up the case of PT below the margin at bottom
3479 of window: scroll_max can no longer be INT_MAX. When aggressive
3480 scrolling is in use, don't let point enter the opposite scroll
3481 margin as result of the scroll.
3482 (syms_of_xdisp) <scroll-conservatively>: Document the
3483 threshold of 100 lines for never-recentering scrolling.
3484
3485 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3486
3487 * dispextern.h (move_it_by_lines):
3488 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3489 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3490 (message_log_check_duplicate): Remove parameters `prev_bol' and
3491 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3492 (redisplay_internal): Remove parameter `preserve_echo_area',
3493 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3494
3495 * indent.c (Fvertical_motion):
3496 * window.c (window_scroll_pixel_based, Frecenter):
3497 Don't pass `need_y_p' to `move_it_by_lines'.
3498
3499 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3500
3501 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3502 steal a few bits to be more compact.
3503 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3504 Remove unneeded casts.
3505
3506 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3507
3508 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3509
3510 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3511 binding" message (bug#7967).
3512
3513 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3514
3515 Fix more problems found by GCC 4.6.0's static checks.
3516
3517 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3518 Remove unused local var.
3519
3520 * editfns.c (Fmessage_box): Remove unused local var.
3521
3522 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3523 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3524 Omit unused local vars.
3525 * window.c (shrink_windows): Omit unused local var.
3526 * menu.c (digest_single_submenu): Omit unused local var.
3527 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3528 Omit unused local var.
3529
3530 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3531 Don't assume string length fits in int.
3532 (keyremap_step, read_key_sequence): Use size_t for sizes.
3533 (read_key_sequence): Don't check last_real_key_start redundantly.
3534
3535 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3536 instead of alloca (Bug#8344).
3537
3538 * eval.c (Fbacktrace): Don't assume nargs fits in int.
3539 (Fbacktrace_frame): Don't assume nframes fits in int.
3540
3541 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3542
3543 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3544 concerns.
3545
3546 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3547
3548 * cm.c (calccost): Turn while-do into do-while, for clarity.
3549
3550 * keyboard.c (syms_of_keyboard): Use the same style as later
3551 in this function when indexing through an array. This also
3552 works around GCC bug 48267.
3553
3554 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3555
3556 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3557
3558 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3559 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3560
3561 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3562 This avoids undefined behavior on integer overflow, and is a bit
3563 more convenient anyway since it is compared to a size_t variable.
3564
3565 Variadic C functions now count arguments with size_t, not int.
3566 This avoids an unnecessary limitation on 64-bit machines, which
3567 caused (substring ...) to crash on large vectors (Bug#8344).
3568 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3569 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
3570 All variadic functions and their callers changed accordingly.
3571 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3572 * data.c (arith_driver, float_arith_driver): Likewise.
3573 * editfns.c (general_insert_function): Likewise.
3574 * eval.c (struct backtrace.nargs, interactive_p)
3575 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3576 (funcall_lambda, mark_backtrace): Likewise.
3577 * fns.c (concat): Likewise.
3578 * frame.c (x_set_frame_parameters): Likewise.
3579 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3580 0 if not found, not -1. All callers changed.
3581
3582 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3583 (stack_copy_size): Now size_t, not int.
3584 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3585
3586 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3587
3588 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3589 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3590 All callers changed.
3591
3592 * lisp.h (multibyte_char_to_unibyte):
3593 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3594 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3595 * character.h (CHAR_TO_BYTE8):
3596 * cmds.c (internal_self_insert):
3597 * editfns.c (general_insert_function):
3598 * keymap.c (push_key_description):
3599 * search.c (Freplace_match):
3600 * xdisp.c (message_dolog, set_message_1): All callers changed.
3601
3602 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3603
3604 * keyboard.c (safe_run_hook_funcall): New function.
3605 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3606 don't set the hook to nil, but remove the offending function instead.
3607 (Qcommand_hook_internal): Remove, unused.
3608 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3609 Vcommand_hook_internal.
3610
3611 * eval.c (enum run_hooks_condition): Remove.
3612 (funcall_nil, funcall_not): New functions.
3613 (run_hook_with_args): Call each function through a `funcall' argument.
3614 Remove `cond' argument, now redundant.
3615 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3616 (Frun_hook_with_args_until_failure): Adjust accordingly.
3617 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3618
3619 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3620
3621 * dispextern.h (string_buffer_position): Remove declaration.
3622
3623 * print.c (strout): Remove parameter `multibyte', unused since
3624 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3625
3626 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3627 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3628 All callers changed.
3629
3630 * w32.c (_wsa_errlist): Use braces for struct initializers.
3631
3632 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3633 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3634 All callers changed.
3635 (string_buffer_position): Likewise. Also, make static (it's never
3636 used outside xdisp.c).
3637 (cursor_row_p): Remove parameter `w', unused since
3638 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3639 (decode_mode_spec): Remove parameter `precision', introduced during
3640 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3641 All callers changed.
3642
3643 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3644
3645 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3646
3647 2011-03-27 Anders Lindgren <andlind@gmail.com>
3648
3649 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3650 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3651 (ns_update_auto_hide_menu_bar): New functions.
3652 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3653 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3654 ns_constrain_all_frames.
3655 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3656 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3657
3658 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3659
3660 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3661
3662 2011-03-27 Glenn Morris <rgm@gnu.org>
3663
3664 * syssignal.h: Replace RETSIGTYPE with void.
3665 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3666 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3667 Replace SIGTYPE with void everywhere.
3668 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3669 * s/template.h (SIGTYPE): Remove commented out definition.
3670
3671 2011-03-26 Eli Zaretskii <eliz@gnu.org>
3672
3673 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3674 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3675
3676 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
3677
3678 * w32.c (read_unc_volume): Use parameter `henum', instead of
3679 global variable `wget_enum_handle'.
3680
3681 * keymap.c (describe_vector): Remove parameters `indices' and
3682 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3683 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3684
3685 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3686
3687 * keyboard.c (timer_check): Remove parameter `do_it_now',
3688 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3689 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3690 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3691
3692 * keyboard.c (read_char):
3693 * w32menu.c (w32_menu_display_help):
3694 * xmenu.c (show_help_event, menu_help_callback):
3695 Adjust calls to `show_help_echo'.
3696
3697 * gtkutil.c (xg_maybe_add_timer):
3698 * keyboard.c (readable_events):
3699 * process.c (wait_reading_process_output):
3700 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3701
3702 * insdel.c (adjust_markers_gap_motion):
3703 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3704 (gap_left, gap_right): Don't call it.
3705
3706 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
3707
3708 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3709 incurred during fontification.
3710
3711 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3712
3713 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3714 (DEFVAR_PER_BUFFER): Don't pass it.
3715
3716 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3717 (scrolling_window): Don't pass it.
3718
3719 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3720
3721 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3722
3723 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3724 and `suffix'.
3725 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3726 of variables specific to SELinux and computation of `encoded_absname'.
3727
3728 * image.c (XPutPixel): Remove unused variable `height'.
3729
3730 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3731
3732 * unexw32.c (get_section_info): Remove unused variable `section'.
3733
3734 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3735 (system_process_attributes): Remove unused variable `sess'.
3736 (sys_read): Remove unused variable `err'.
3737
3738 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3739 (w32_wnd_proc): Remove unused variable `isdead'.
3740 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3741 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3742 (x_create_tip_frame): Remove unused variable `tem'.
3743
3744 * w32inevt.c (w32_console_read_socket):
3745 Remove unused variable `no_events'.
3746
3747 * w32term.c (x_draw_composite_glyph_string_foreground):
3748 Remove unused variable `width'.
3749
3750 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
3751
3752 * w32term.c (x_set_glyph_string_clipping):
3753 Don't pass uninitialized region to CombineRgn.
3754
3755 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
3756
3757 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3758 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3759 (Fx_close_connection): Remove unused variable `i'.
3760
3761 * w32font.c (w32font_draw): Return number of glyphs.
3762 (w32font_open_internal): Remove unused variable `i'.
3763 (w32font_driver): Add missing initializer.
3764
3765 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3766 (fill_in_menu): Remove unused variable `items_added'.
3767
3768 * w32term.c (last_mouse_press_frame): Remove static global variable.
3769 (w32_clip_to_row): Remove unused variable `f'.
3770 (x_delete_terminal): Remove unused variable `i'.
3771
3772 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3773 (NOTHING): Remove unused static global variable.
3774 (uniscribe_check_otf): Remove unused variable `table'.
3775 (uniscribe_font_driver): Add missing initializers.
3776
3777 2011-03-23 Julien Danjou <julien@danjou.info>
3778
3779 * term.c (Fsuspend_tty, Fresume_tty):
3780 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3781 * window.c (temp_output_buffer_show):
3782 * insdel.c (signal_before_change):
3783 * frame.c (Fhandle_switch_frame):
3784 * fileio.c (Fdo_auto_save):
3785 * emacs.c (Fkill_emacs):
3786 * editfns.c (save_excursion_restore):
3787 * cmds.c (internal_self_insert):
3788 * callint.c (Fcall_interactively):
3789 * buffer.c (Fkill_all_local_variables):
3790 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3791 Use Frun_hooks.
3792 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
3793 unconditionnaly since it does the check itself.
3794
3795 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
3796
3797 Fix more problems found by GCC 4.5.2's static checks.
3798
3799 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3800 the first time through the loop, since we know p0 < p1 then.
3801 This also avoids a gcc -Wstrict-overflow warning.
3802
3803 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3804 leading to a memory leak, possible in functions like
3805 load_charset_map_from_file that can allocate an unbounded number
3806 of objects (Bug#8318).
3807
3808 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3809 that could (at least in theory) be that large.
3810
3811 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3812 This is less likely to overflow, and avoids undefined behavior if
3813 overflow does occur. All callers changed. Use strtoul to scan
3814 for the unsigned long integer.
3815 (pint2hrstr): Simplify and tune code slightly.
3816 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
3817
3818 * scroll.c (do_scrolling): Work around GCC bug 48228.
3819 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3820
3821 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3822 This also avoids a warning with gcc -Wstrict-overflow.
3823 (validate_x_resource_name): Simplify count usage.
3824 This also avoids a warning with gcc -Wstrict-overflow.
3825
3826 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3827 fail (Bug#8306).
3828
3829 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
3830
3831 * process.c (Fmake_network_process): Use socklen_t, not int,
3832 where POSIX says socklen_t is required in portable programs.
3833 This fixes a porting bug on hosts like 64-bit HP-UX, where
3834 socklen_t is wider than int (Bug#8277).
3835 (Fmake_network_process, server_accept_connection):
3836 (wait_reading_process_output, read_process_output):
3837 Likewise.
3838
3839 * process.c: Rename or move locals to avoid shadowing.
3840 (list_processes_1, Fmake_network_process):
3841 (read_process_output_error_handler, exec_sentinel_error_handler):
3842 Rename or move locals.
3843 (Fmake_network_process): Define label "retry_connect" only if needed.
3844 (Fnetwork_interface_info): Fix pointer signedness.
3845 (process_send_signal): Add cast to avoid pointer signedness problem.
3846 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
3847 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
3848
3849 Make tparam.h and terminfo.c consistent.
3850 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3851 Include tparam.h instead, since it declares them.
3852 * cm.h (PC): Remove extern decl; tparam.h now does this.
3853 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3854 * terminfo.c: Include tparam.h, to check interfaces.
3855 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3856 (tparam): Adjust signature to match interface in tparam.h;
3857 this removes some undefined behavior. Check that outstring and len
3858 are zero, which they always are with Emacs.
3859 * tparam.h (PC, BC, UP): New extern decls.
3860
3861 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3862 (xftfont_open): Rename locals to avoid shadowing.
3863
3864 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3865 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3866 (OTF_TAG_SYM): Omit macro if not needed.
3867 (ftfont_list): Remove unused local.
3868 (get_adstyle_property, ftfont_pattern_entity):
3869 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3870 Rename locals to avoid shadowing.
3871
3872 * xfont.c (xfont_list_family): Mark var as initialized.
3873
3874 * xml.c (make_dom): Now static.
3875
3876 * composite.c (composition_compute_stop_pos): Rename local to
3877 avoid shadowing.
3878 (composition_reseat_it): Remove unused locals.
3879 (find_automatic_composition, composition_adjust_point): Likewise.
3880 (composition_update_it): Mark var as initialized.
3881 (find_automatic_composition): Mark vars as initialized,
3882 with a FIXME (Bug#8290).
3883
3884 character.h: Rename locals to avoid shadowing.
3885 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3886 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3887 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3888 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3889 to avoid shadowing.
3890
3891 * textprop.c (property_change_between_p): Remove; unused.
3892
3893 * intervals.c (interval_start_pos): Now static.
3894
3895 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3896
3897 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3898 Rename locals to avoid shadowing.
3899
3900 * sound.c (wav_play, au_play, Fplay_sound_internal):
3901 Fix pointer signedness.
3902 (alsa_choose_format): Remove unused local var.
3903 (wav_play): Initialize a variable to 0, to prevent undefined
3904 behavior (Bug#8278).
3905
3906 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3907
3908 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3909
3910 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3911 clobbering (Bug#8298).
3912 * sysdep.c (sys_subshell): Likewise.
3913 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
3914
3915 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3916 This should get cleaned up, so that child_setup has the
3917 same signature on all platforms.
3918
3919 * callproc.c (call_process_cleanup): Now static.
3920 (relocate_fd): Rename locals to avoid shadowing.
3921
3922 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
3923
3924 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3925 not to be necessary, and produces flickering.
3926
3927 2011-03-20 Glenn Morris <rgm@gnu.org>
3928
3929 * config.in: Remove file.
3930
3931 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
3932
3933 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3934 are now in src/globals.h.
3935 (syms_of_minibuf): Remove spurious & from previous change.
3936
3937 2011-03-20 Leo <sdl.web@gmail.com>
3938
3939 * minibuf.c (completing-read-function): New variable.
3940 (completing-read-default): Rename from completing-read.
3941 (completing-read): Call completing-read-function.
3942
3943 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3944
3945 * xfaces.c (Fx_load_color_file):
3946 Read color file from absolute filename (bug#8250).
3947
3948 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3949
3950 * makefile.w32-in: Update dependencies.
3951
3952 2011-03-17 Eli Zaretskii <eliz@gnu.org>
3953
3954 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3955
3956 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3957
3958 Fix more problems found by GCC 4.5.2's static checks.
3959
3960 * process.c (make_serial_process_unwind, send_process_trap):
3961 (sigchld_handler): Now static.
3962
3963 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3964 That way, the code declares only the vars that it needs.
3965 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3966 * s/cygwin.h (PTY_ITERATION): Likewise.
3967 * s/darwin.h (PTY_ITERATION): Likewise.
3968 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3969
3970 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3971 * process.c (allocate_pty): Don't declare stb unless it's needed.
3972
3973 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
3974 (CONSTANTLIM): Remove; unused.
3975 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3976 Define only if needed.
3977
3978 * unexelf.c (unexec): Name an expression,
3979 to avoid gcc -Wbad-function-cast warning.
3980 Use a different way to cause a compilation error if anyone uses
3981 n rather than nn, a way that does not involve shadowing.
3982 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
3983
3984 * deps.mk (unexalpha.o): Remove; unused.
3985
3986 New file unexec.h, the (simple) interface for unexec (Bug#8267).
3987 * unexec.h: New file.
3988 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3989 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3990 Depend on unexec.h.
3991 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3992 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3993 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
3994 Change as necessary to match prototype in unexec.h.
3995
3996 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3997 shadowing.
3998 (back_comment, skip_chars): Mark vars as initialized.
3999
4000 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4001 Rename locals to avoid shadowing.
4002
4003 * lread.c (read1): Rewrite so as not to use empty "else".
4004 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
4005
4006 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4007
4008 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4009 warning when compiling print.c.
4010
4011 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4012 instead of using an uninitialized var.
4013 (font_sort_entities): Mark var as initialized.
4014
4015 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4016
4017 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4018 pointers to constants.
4019 (font_parse_fcname): Remove unused vars.
4020 (font_delete_unmatched): Now static.
4021 (font_get_spec): Remove; unused.
4022 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4023 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4024 Rename or move locals to avoid shadowing.
4025
4026 * fns.c (require_nesting_list, require_unwind): Now static.
4027 (Ffillarray): Rename locals to avoid shadowing.
4028
4029 * floatfns.c (domain_error2): Define only if needed.
4030 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
4031
4032 * alloc.c (mark_backtrace): Move decl from here ...
4033 * lisp.h: ... to here, so that it can be checked.
4034
4035 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
4036 (Fdefvar): Rewrite so as not to use empty "else".
4037 (lisp_indirect_variable): Name an expression,
4038 to avoid gcc -Wbad-function-cast warning.
4039 (Fdefvar): Rename locals to avoid shadowing.
4040
4041 * callint.c (quotify_arg, quotify_args): Now static.
4042 (Fcall_interactively): Rename locals to avoid shadowing.
4043 Use const pointer when appropriate.
4044
4045 * lisp.h (get_system_name, get_operating_system_release):
4046 Move decls here, to check interfaces.
4047 * process.c (get_operating_system_release): Move decl to lisp.h.
4048 * xrdb.c (get_system_name): Likewise.
4049 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4050 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4051 some of which prompt warnings from gcc -Wbad-function-cast.
4052 (Fformat_time_string, Fencode_time, Finsert_char):
4053 (Ftranslate_region_internal, Fformat):
4054 Rename or remove local vars to avoid shadowing.
4055 (Ftranslate_region_internal): Mark var as initialized.
4056
4057 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4058 avoid shadowing.
4059
4060 * lisp.h (eassert): Check that the argument compiles, even if
4061 ENABLE_CHECKING is not defined.
4062
4063 * data.c (Findirect_variable): Name an expression, to avoid
4064 gcc -Wbad-function-cast warning.
4065 (default_value, arithcompare, arith_driver, arith_error): Now static.
4066 (store_symval_forwarding): Rename local to avoid shadowing.
4067 (Fmake_variable_buffer_local, Fmake_local_variable):
4068 Mark variables as initialized.
4069 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4070
4071 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4072 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4073 Rename locals to avoid shadowing.
4074 (mark_stack): Move local variables into the #ifdef region where
4075 they're used.
4076 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4077 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4078 needed otherwise.
4079 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4080 (GC_STRING_CHARS): Remove; not used.
4081 (Fmemory_limit): Cast sbrk's returned value to char *.
4082
4083 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4084 avoids undefined behavior in theory.
4085
4086 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4087
4088 Use functions, not macros, for up- and down-casing (Bug#8254).
4089 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4090 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4091 to use the following functions instead of these macros.
4092 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4093 EMACS_INT, since callers assume the returned value fits in int.
4094 (upcase1): Likewise, for UPCASE_TABLE.
4095 (uppercasep, lowercasep, upcase): New static inline functions.
4096 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4097 the race-condition problem in the old DOWNCASE.
4098
4099 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4100 Rename locals to avoid shadowing.
4101 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4102 (regex_compile, re_search_2, re_match_2_internal):
4103 Remove unused local vars.
4104 (FREE_VAR): Rewrite so as not to use empty "else",
4105 which gcc can warn about.
4106 (regex_compile, re_match_2_internal): Mark locals as initialized.
4107 (RETALLOC_IF): Define only if needed.
4108 (WORDCHAR_P): Likewise. This one is never needed, but is used
4109 only in a comment talking about a compiler bug, so put inside
4110 the #if 0 of that comment.
4111 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4112 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4113 Remove; unused.
4114
4115 * search.c (boyer_moore): Rename locals to avoid shadowing.
4116 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4117 (PREV_CHAR_BOUNDARY): Likewise.
4118
4119 * search.c (simple_search): Remove unused var.
4120
4121 * dired.c (compile_pattern): Move decl from here ...
4122 * lisp.h: ... to here, so that it can be checked.
4123 (struct re_registers): New forward decl.
4124
4125 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4126
4127 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4128 All uses changed.
4129 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4130 Rename locals to avoid shadowing.
4131 (Fvertical_motion): Mark locals as initialized.
4132
4133 * casefiddle.c (casify_object, casify_region): Now static.
4134 (casify_region): Mark local as initialized.
4135
4136 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4137
4138 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4139 New macros, so that the caller can use some names other than
4140 gcpro1, gcpro2, etc.
4141 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4142 of the new macros.
4143 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4144 argument, for consistency with GCPRO2_VAR, etc: it is now the
4145 prefix of the variable, not the variable itself. All uses
4146 changed.
4147 * dired.c (directory_files_internal, file_name_completion):
4148 Rename locals to avoid shadowing.
4149
4150 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4151 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4152 dired.c's scmp function, had undefined behavior.
4153 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4154 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4155 * buffer.h: ... to here, because these macros use current_buffer,
4156 and the new implementation with inline functions needs to have
4157 current_buffer in scope now, rather than later when the macros
4158 are used.
4159 (downcase, upcase1): New static inline functions.
4160 (DOWNCASE, UPCASE1): Reimplement using these functions.
4161 This avoids undefined behavior in expressions like
4162 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4163 from race conditions in accessing the global variables
4164 case_temp1 and case_temp2.
4165 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4166 * lisp.h (case_temp1, case_temp2): Remove their decls.
4167 * character.h (ASCII_CHAR_P): Move from here ...
4168 * lisp.h: ... to here, so that the inline functions mentioned
4169 above can use them.
4170
4171 * dired.c (directory_files_internal_unwind): Now static.
4172
4173 * fileio.c (file_name_as_directory, directory_file_name):
4174 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4175 Now static.
4176 (file_name_as_directory): Use const pointers when appropriate.
4177 (Fexpand_file_name): Likewise. In particular, newdir might
4178 point at constant storage, so make it a const pointer.
4179 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4180 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4181 signedness issues.
4182 (Fset_file_times, Finsert_file_contents, auto_save_error):
4183 Rename locals to avoid shadowing.
4184
4185 * minibuf.c (choose_minibuf_frame_1): Now static.
4186 (Ftry_completion, Fall_completions): Rename or remove locals
4187 to avoid shadowing.
4188
4189 * marker.c (bytepos_to_charpos): Remove; unused.
4190
4191 * lisp.h (verify_bytepos, count_markers): New decls,
4192 so that gcc does not warn that these functions aren't declared.
4193
4194 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4195 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4196 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4197 (copy_text): Remove unused local var.
4198
4199 * filelock.c (within_one_second): Now static.
4200 (lock_file_1): Rename local to avoid shadowing.
4201
4202 * buffer.c (fix_overlays_before): Mark locals as initialized.
4203 (fix_start_end_in_overlays): Likewise. This function should be
4204 simplified by using pointers-to-pointers, but that's a different
4205 matter.
4206 (switch_to_buffer_1): Now static.
4207 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4208 (report_overlay_modification): Rename locals to avoid shadowing.
4209
4210 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4211 Fix pointer signedness issue.
4212 (sys_subshell): Mark local as volatile if checking for lint,
4213 to suppress a gcc -Wclobbered warning that does not seem to be right.
4214 (MAXPATHLEN): Define only if needed.
4215
4216 * process.c (serial_open, serial_configure): Move decls from here ...
4217 * systty.h: ... to here, so that they can be checked.
4218
4219 * fns.c (get_random, seed_random): Move extern decls from here ...
4220 * lisp.h: ... to here, so that they can be checked.
4221
4222 * sysdep.c (reset_io): Now static.
4223 (wait_for_termination_signal): Remove; unused.
4224
4225 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4226 (copy_keymap_item, append_key, push_text_char_description):
4227 Now static.
4228 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4229 (DENSE_TABLE_SIZE): Remove; unused.
4230 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4231 (describe_map_tree):
4232 Rename locals to avoid shadowing.
4233
4234 * keyboard.c: Declare functions static if they are not used elsewhere.
4235 (echo_char, echo_dash, cmd_error, top_level_2):
4236 (poll_for_input, handle_async_input): Now static.
4237 (read_char, kbd_buffer_get_event, make_lispy_position):
4238 (make_lispy_event, make_lispy_movement, apply_modifiers):
4239 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4240 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4241 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4242 (read_key_sequence, read_char): Mark locals as initialized.
4243 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4244
4245 * keyboard.h (make_ctrl_char): New decl.
4246 (mark_kboards): Move decl here ...
4247 * alloc.c (mark_kboards): ... from here.
4248
4249 * lisp.h (force_auto_save_soon): New decl.
4250
4251 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4252 (DEFINE_DUMMY_FUNCTION): New macro.
4253 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4254 Use it.
4255 (main): Add casts to avoid warnings
4256 if GCC considers string literals to be constants.
4257
4258 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4259
4260 * dbusbind.c: Pointer signedness fixes.
4261 (xd_signature, xd_append_arg, xd_initialize):
4262 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4263 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4264 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4265 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4266
4267 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4268 if GCC considers string literals to be constants.
4269 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4270
4271 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4272
4273 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4274 (print_preprocess, print_object): New macro to fix last change.
4275
4276 * print.c (print_preprocess): Don't forget font objects.
4277
4278 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
4279
4280 * emacs.c (USAGE3): Doc fixes.
4281
4282 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4283
4284 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4285 structure.
4286
4287 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
4288
4289 * lisp.h (VWindow_system, Qfile_name_history):
4290 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4291 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4292 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4293
4294 * w32select.c: Don't #include "keyboard.h".
4295 (run_protected): Add extern declaration for waiting_for_input.
4296
4297 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4298 * w32console.c (detect_input_pending, read_input_pending)
4299 (encode_terminal_code):
4300 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4301 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4302 (w32_system_caret_y, Qfile_name_history):
4303 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4304 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4305 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4306 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4307 * w32proc.c (Qlocal, report_file_error):
4308 * w32term.c (Vwindow_system, updating_frame):
4309 * w32uniscribe.c (initialized, uniscribe_font_driver):
4310 Remove unneeded extern declarations.
4311
4312 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
4313
4314 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
4315
4316 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
4317
4318 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4319 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4320 These macros can no longer be used for assignment.
4321
4322 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4323 Assign struct members directly, instead of using BUF_BEGV etc.
4324 (record_buffer_markers, fetch_buffer_markers): New functions for
4325 recording and fetching special buffer markers.
4326 (set_buffer_internal_1, set_buffer_temp): Use them.
4327
4328 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4329
4330 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4331
4332 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4333 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4334
4335 * xdisp.c (hscroll_window_tree):
4336 (reconsider_clip_changes): Use PT instead of BUF_PT.
4337
4338 2011-03-13 Eli Zaretskii <eliz@gnu.org>
4339
4340 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4341 $(EMACS_ROOT)/lib/intprops.h.
4342
4343 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4344
4345 Fix more problems found by GCC 4.5.2's static checks.
4346
4347 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4348 to unsigned char * to avoid compiler diagnostic.
4349 (xg_free_frame_widgets): Make it clear that a local variable is
4350 needed only if USE_GTK_TOOLTIP.
4351 (gdk_window_get_screen): Make it clear that this macro is needed
4352 only if USE_GTK_TOOLTIP.
4353 (int_gtk_range_get_value): New function, which avoids a diagnostic
4354 from gcc -Wbad-function-cast.
4355 (xg_set_toolkit_scroll_bar_thumb): Use it.
4356 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4357 diagnostic from gcc -Wbad-function-cast.
4358 (get_utf8_string, xg_get_file_with_chooser):
4359 Rename locals to avoid shadowing.
4360 (create_dialog): Move locals to avoid shadowing.
4361
4362 * xgselect.c (xg_select): Remove unused var.
4363
4364 * image.c (four_corners_best): Mark locals as initialized.
4365 (gif_load): Initialize transparent_p to zero (Bug#8238).
4366 Mark another local as initialized.
4367 (my_png_error, my_error_exit): Mark with NO_RETURN.
4368
4369 * image.c (clear_image_cache): Now static.
4370 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
4371 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
4372 (x_edge_detection): Remove unnecessary cast that
4373 gcc -Wbad-function-cast diagnoses.
4374 (gif_load): Fix pointer signedness.
4375 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4376 (jpeg_load, gif_load): Rename locals to avoid shadowing.
4377
4378 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
4379
4380 Improve quality of tests for time stamp overflow.
4381 For example, without this patch (encode-time 0 0 0 1 1
4382 1152921504606846976) returns the obviously-bogus value (-948597
4383 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4384 reports time overflow. See
4385 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
4386 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4387 * editfns.c: Include limits.h and intprops.h.
4388 (TIME_T_MIN, TIME_T_MAX): New macros.
4389 (time_overflow): Move earlier, to before first use.
4390 (hi_time, lo_time): New functions, for an accurate test for
4391 out-of-range times.
4392 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4393 (Fget_internal_run_time): Don't assume time_t fits in int.
4394 (make_time): Use list2 instead of Fcons twice.
4395 (Fdecode_time): More accurate test for out-of-range times.
4396 (check_tm_member): New function.
4397 (Fencode_time): Use it, to test for out-of-range times.
4398 (lisp_time_argument): Don't rely on undefined left-shift and
4399 right-shift behavior when checking for time stamp overflow.
4400
4401 * editfns.c (time_overflow): New function, refactoring common code.
4402 (Fformat_time_string, Fdecode_time, Fencode_time):
4403 (Fcurrent_time_string): Use it.
4404
4405 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4406 * dired.c (make_time): Move to ...
4407 * editfns.c (make_time): ... here.
4408 * systime.h: Note the move.
4409
4410 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4411
4412 * fringe.c (update_window_fringes): Remove unused variables.
4413
4414 * unexmacosx.c (copy_data_segment): Also copy __got section.
4415 (Bug#8223)
4416
4417 2011-03-12 Eli Zaretskii <eliz@gnu.org>
4418
4419 * termcap.c [MSDOS]: Include "msdos.h".
4420 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4421 Constify `char *' arguments and their references according to
4422 prototypes in tparam.h.
4423
4424 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
4425
4426 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4427 Adapt all references accordingly.
4428
4429 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4430
4431 2011-03-11 Tom Tromey <tromey@redhat.com>
4432
4433 * buffer.c (syms_of_buffer): Remove obsolete comment.
4434
4435 2011-03-11 Eli Zaretskii <eliz@gnu.org>
4436
4437 * termhooks.h (encode_terminal_code): Declare prototype.
4438
4439 * msdos.c (encode_terminal_code): Don't declare prototype.
4440
4441 * term.c (encode_terminal_code): Now external again, used by
4442 w32console.c and msdos.c.
4443
4444 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4445 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
4446
4447 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
4448
4449 Fix some minor problems found by GCC 4.5.2's static checks.
4450
4451 * fringe.c (update_window_fringes): Mark locals as initialized
4452 (Bug#8227).
4453 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
4454
4455 * alloc.c (mark_fringe_data): Move decl from here ...
4456 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4457 to check its interface.
4458 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4459
4460 * fontset.c (free_realized_fontset): Now static.
4461 (Fset_fontset_font): Rename local to avoid shadowing.
4462 (fontset_font): Mark local as initialized.
4463 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
4464
4465 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4466
4467 * xselect.c (x_disown_buffer_selections): Remove; not used.
4468 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
4469 (x_own_selection, Fx_disown_selection_internal): Rename locals
4470 to avoid shadowing.
4471 (x_handle_dnd_message): Remove local to avoid shadowing.
4472
4473 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4474 so that the caller can use some name other than gcpro1.
4475 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
4476 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4477 (Fx_backspace_delete_keys_p):
4478 Use them to avoid shadowing, and rename vars to avoid shadowing.
4479 (x_decode_color, x_set_name, x_window): Now static.
4480 (Fx_create_frame): Add braces to silence GCC warning.
4481 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
4482 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4483 Remove unused locals.
4484 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4485 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4486 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4487 macros.
4488
4489 * xterm.h (x_mouse_leave): New decl.
4490
4491 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4492 Remove unused functions.
4493 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4494 (x_calc_absolute_position): Now static.
4495 (XTread_socket): Don't define label "out" unless it's used.
4496 Don't declare local "event" unless it's used.
4497 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4498 unless they are used.
4499 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4500 (x_fatal_error_signal): Remove; not used.
4501 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4502 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4503 (x_error_catcher, x_connection_closed, x_error_handler):
4504 (x_error_quitter, xembed_send_message, x_iconify_frame):
4505 (my_log_handler): Rename locals to avoid shadowing.
4506 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
4507 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
4508
4509 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4510 Rename or move locals to avoid shadowing.
4511 (tty_defined_color, merge_face_heights): Now static.
4512 (free_realized_faces_for_fontset): Remove; not used.
4513 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4514 does not deduce is never used uninitialized.
4515 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4516 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
4517
4518 * terminal.c (store_terminal_param): Now static.
4519
4520 * xmenu.c (menu_highlight_callback): Now static.
4521 (set_frame_menubar): Remove unused local.
4522 (xmenu_show): Rename parameter to avoid shadowing.
4523 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4524 since they might point to immutable storage.
4525 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4526 since it's unused otherwise.
4527
4528 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
4529 Add a FIXME, since the code still doesn't look right. (Bug#8215)
4530 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4531 avoids a gcc -Wuninitialized diagnostic.
4532 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
4533 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4534 does not deduce are never used uninitialized.
4535
4536 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4537
4538 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4539 * window.c (window_loop, size_window):
4540 (run_window_configuration_change_hook, enlarge_window): Likewise.
4541
4542 * window.c (display_buffer): Now static.
4543 (size_window): Mark variables that gcc -Wuninitialized
4544 does not deduce are never used uninitialized.
4545 * window.h (check_all_windows): New decl, to forestall
4546 gcc -Wmissing-prototypes diagnostic.
4547 * dispextern.h (bidi_dump_cached_states): Likewise.
4548
4549 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4550 shadowing.
4551 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
4552 Include <limits.h>.
4553 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4554 and to avoid gcc -Wuninitialized warning.
4555 (load_charset_map): Mark variables that gcc -Wuninitialized
4556 does not deduce are never used uninitialized.
4557 (load_charset): Abort instead of using uninitialized var (Bug#8229).
4558
4559 * coding.c (coding_set_source, coding_set_destination):
4560 Use "else { /* comment */ }" rather than "else /* comment */;"
4561 for clarity, and to avoid gcc -Wempty-body warning.
4562 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4563 a block, when the outer 'i' will do.
4564 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4565 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4566 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4567 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4568 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4569 Rename locals to avoid shadowing.
4570 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
4571 * coding.c (emacs_mule_char, encode_invocation_designation):
4572 Now static, since they're not used elsewhere.
4573 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
4574 (decode_coding_object, encode_coding_object, detect_coding_system):
4575 (decode_coding_emacs_mule): Mark variables that gcc
4576 -Wuninitialized does not deduce are never used uninitialized.
4577 (detect_coding_iso_2022): Initialize a local variable that might
4578 be used uninitialized. Leave a FIXME because it's not clear that
4579 this initialization is needed. (Bug#8211)
4580 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4581 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4582 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4583 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4584 Remove unused macros.
4585
4586 * category.c (hash_get_category_set): Remove unused local var.
4587 (copy_category_table): Now static, since it's not used elsewhere.
4588 * character.c (string_count_byte8): Likewise.
4589
4590 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4591 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4592
4593 * chartab.c (copy_sub_char_table): Now static, since it's not used
4594 elsewhere.
4595 (sub_char_table_ref_and_range, char_table_ref_and_range):
4596 Rename locals to avoid shadowing.
4597 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
4598
4599 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
4600 (BIDI_BOB): Remove unused macro.
4601
4602 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4603 deduce are never used uninitialized.
4604 * term.c (encode_terminal_code): Likewise.
4605
4606 * term.c (encode_terminal_code): Now static. Remove unused local.
4607
4608 * tparam.h: New file.
4609 * term.c, tparam.h: Include it.
4610 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4611 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4612 Move these decls to tparam.h, and make them agree with what
4613 is actually in tparam.c. The previous trick of using incompatible
4614 decls in different modules does not conform to the C standard.
4615 All callers of tparam changed to use tparam's actual API.
4616 * tparam.c (tparam1, tparam, tgoto):
4617 Use const pointers where appropriate.
4618
4619 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4620 * cm.h (struct cm): Likewise.
4621 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4622 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4623 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4624 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4625 (turn_on_face, init_tty): Likewise.
4626 * termchar.h (struct tty_display_info): Likewise.
4627
4628 * term.c (term_mouse_position): Rename local to avoid shadowing.
4629
4630 * alloc.c (mark_ttys): Move decl from here ...
4631 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4632
4633 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4634
4635 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4636
4637 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
4638
4639 * search.c (compile_pattern_1): Remove argument regp, unused since
4640 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4641 (compile_pattern): Don't pass it.
4642
4643 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4644
4645 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4646 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4647 for ! HAVE_GTK3.
4648 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4649
4650 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4651
4652 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4653 gdk_window_get_screen, gdk_window_get_geometry,
4654 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4655 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4656 (xg_get_pixbuf_from_pixmap): New function.
4657 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4658 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4659 Call xg_get_pixbuf_from_pixmap instead of
4660 gdk_pixbuf_get_from_drawable.
4661 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4662 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4663 (xg_check_special_colors): Use GtkStyleContext and its functions
4664 for HAVE_GTK3.
4665 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4666 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4667 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
4668 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4669 Call gtk_widget_get_preferred_size.
4670 (xg_frame_resized): gdk_window_get_geometry only takes 5
4671 parameters.
4672 (xg_win_to_widget, xg_event_is_for_menubar):
4673 Call gdk_x11_window_lookup_for_display.
4674 (xg_set_widget_bg): New function.
4675 (delete_cb): New function.
4676 (xg_create_frame_widgets): Connect delete-event to delete_cb.
4677 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4678 (xg_set_background_color): Call xg_set_widget_bg.
4679 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4680 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4681 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4682 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4683 if ! HAVE_GTK3.
4684 (update_frame_tool_bar): Call gtk_widget_hide.
4685 (xg_initialize): Use GDK_KEY_g.
4686
4687 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4688 if ! HAVE_GTK3
4689 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4690
4691 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4692 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4693 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4694
4695 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
4696
4697 * w32xfns.c (select_palette): Check success of RealizePalette against
4698 GDI_ERROR, not zero.
4699
4700 See ChangeLog.11 for earlier changes.
4701
4702 ;; Local Variables:
4703 ;; coding: utf-8
4704 ;; End:
4705
4706 Copyright (C) 2011 Free Software Foundation, Inc.
4707
4708 This file is part of GNU Emacs.
4709
4710 GNU Emacs is free software: you can redistribute it and/or modify
4711 it under the terms of the GNU General Public License as published by
4712 the Free Software Foundation, either version 3 of the License, or
4713 (at your option) any later version.
4714
4715 GNU Emacs is distributed in the hope that it will be useful,
4716 but WITHOUT ANY WARRANTY; without even the implied warranty of
4717 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4718 GNU General Public License for more details.
4719
4720 You should have received a copy of the GNU General Public License
4721 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.