* minibuf.c (read_minibuf_noninteractive): Don't leak memory
[bpt/emacs.git] / src / ChangeLog
1 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
2
3 * minibuf.c (read_minibuf_noninteractive): Don't leak memory
4 on memory overflow.
5
6 * macros.c: Integer and memory overflow fixes.
7 (Fstart_kbd_macro): Don't update size until alloc done.
8 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
9
10 * lread.c (read1, init_obarray): Don't update size until alloc done.
11
12 * keymap.c: Integer overflow fixes.
13 (cmm_size, current_minor_maps): Use ptrdiff_t, not int, to count maps.
14 (current_minor_maps): Check for size calculation overflow.
15 * keymap.h: Change prototypes to match the above.
16
17 * keyboard.c: Integer and memory overflow fixes.
18 (read_char, menu_bar_items, tool_bar_items, read_char_x_menu_prompt)
19 (read_char_minibuf_menu_width, read_char_minibuf_menu_prompt)
20 (follow_key, read_key_sequence): Use ptrdiff_t, not int, to count maps.
21 (read_char_minibuf_menu_prompt): Check for overflow in size
22 calculations. Don't update size until allocation succeeds. Redo
23 calculations to avoid overflow.
24 * keyboard.h: Change prototypes to match the above.
25
26 * image.c: Integer and memory overflow fixes.
27 (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these are duplicate
28 now that they've been promoted to lisp.h.
29 (x_allocate_bitmap_record, x_alloc_image_color)
30 (make_image_cache, cache_image, xpm_load):
31 Don't update size until alloc is done.
32 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
33 (x_detect_edges):
34 Check for size calculation overflow.
35 (ct_colors_allocated_max): New constant.
36 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
37 overflow.
38
39 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
40
41 * gtkutil.c: Integer overflow fixes.
42 (get_utf8_string, xg_store_widget_in_map):
43 Check for size-calculation overflow.
44 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
45 do, as we prefer signed integers.
46 (id_to_widget.max_size, id_to_widget.used)
47 (xg_store_widget_in_map, xg_remove_widget_from_map)
48 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
49 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
50 Use and return ptrdiff_t, not int.
51 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
52 * gtkutil.h: Change prototypes to match the above.
53
54 * ftfont.c: Check for size overflow.
55 (ftfont_get_open_type_spec, setup_otf_gstring, ftfont_shape_by_flt):
56 Check for integer overflow in size calculations.
57
58 * fringe.c (Fdefine_fringe_bitmap): Don't update size until alloc works.
59
60 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
61 This is for the members text_lines, text_cols, total_lines, total_cols,
62 where the system imposes an 'int' limit.
63
64 * frame.c: Integer overflow fixes.
65 (set_menu_bar_lines, x_set_frame_parameters, x_set_scroll_bar_width)
66 (x_figure_window_size): Check for integer overflow.
67 (x_set_alpha): Do not assume XINT fits in int.
68
69 * eval.c: Integer and memory overflow fixes.
70 (init_eval_once, grow_specpdl): Don't update size until alloc succeeds.
71 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
72
73 * emacs.c (main, sort_args): Check for size-calculation overflow.
74
75 * editfns.c: Integer and memory overflow fixes.
76 (set_time_zone_rule): Don't assume environment length fits in int.
77 (message_length): Now ptrdiff_t, not int.
78 (Fmessage_box): Don't update size until allocation succeeds.
79 Don't assume message length fits in int.
80 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
81
82 * doc.c: Integer and memory overflow fixes.
83 (get_doc_string_buffer_size): Now ptrdiff_t, not int.
84 (get_doc_string): Check for size calculation overflow.
85 Don't update size until allocation succeeds.
86 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
87 EMACS_INT, where ptrdiff_t will do.
88 (Fsubstitute_command_keys): Check for string overflow.
89
90 Integer and memory overflow fixes for display code.
91 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
92 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool, scrolling_window):
93 Check for overflow in size calculations.
94 (line_draw_cost, realloc_glyph_pool, add_row_entry):
95 Don't assume glyph table len fits in int.
96 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
97 (row_table_size): Now ptrdiff_t, not int.
98 (scrolling_window): Avoid overflow in size calculations.
99 Don't update size until allocation succeeds.
100 * fns.c (concat): Check for overflow in size calculations.
101 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
102 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
103 (NEXT_ALMOST_PRIME_LIMIT): New constant.
104
105 * composite.c: Integer overflow fixes.
106 (get_composition_id): Check for overflow in glyph length calculations.
107
108 * coding.c: Integer and memory overflow fixes.
109 (produce_chars): Redo buffer-overflow calculations to avoid
110 unnecessary integer overflow. Check for size overflow.
111 (encode_coding_object): Don't update size until xmalloc succeeds.
112
113 * character.c (Fstring): Check for size-calculation overflow.
114
115 * ccl.c: Integer and memory overflow fixes.
116 (Fccl_execute_on_string): Check for memory overflow.
117 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
118 Redo buffer-overflow calculations to avoid integer overflow.
119
120 * callproc.c (child_setup): Don't assume strlen fits in int.
121
122 * buffer.c: Memory overflow fixes.
123 (overlays_at, overlays_in, record_overlay_string, overlay_strings):
124 Don't update size of array until after memory allocation succeeds,
125 because xmalloc/xrealloc may not return.
126
127 * bidi.c: Integer overflow fix.
128 (bidi_shelve_header_size): New constant.
129 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
130 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
131
132 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
133
134 Use ptrdiff_t for composition IDs.
135 * character.c (lisp_string_width):
136 * composite.c (composition_table_size, n_compositions)
137 (get_composition_id, composition_gstring_from_id):
138 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
139 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
140 * window.c (Frecenter):
141 Use ptrdiff_t, not int, for composition IDs.
142 * composite.c (get_composition_id): Check for integer overflow.
143 * composite.h: Adjust prototypes to match the above changes.
144
145 Use ptrdiff_t for hash table indexes.
146 * category.c (hash_get_category_set):
147 * ccl.c (ccl_driver):
148 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
149 * coding.c (coding_system_charset_list, detect_coding_system):
150 * coding.h (struct coding_system.id):
151 * composite.c (get_composition_id, gstring_lookup_cache):
152 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
153 * image.c (xpm_get_color_table_h):
154 * lisp.h (hash_lookup, hash_put):
155 * minibuf.c (Ftest_completion):
156 Use ptrdiff_t for hash table indexes, not int (which is too
157 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
158 32-bit --with-wide-int hosts).
159
160 * charset.c (Fdefine_charset_internal): Check for integer overflow.
161 Add a FIXME comment about memory leaks.
162 (syms_of_charset): Don't assume xmalloc returns.
163
164 Don't assume that stated character widths fit in int.
165 * character.c (Fchar_width, c_string_width, lisp_string_width):
166 * character.h (CHAR_WIDTH):
167 * indent.c (MULTIBYTE_BYTES_WIDTH):
168 Use sanitize_char_width to avoid undefined and/or bad behavior
169 with outlandish widths.
170 * character.h (sanitize_tab_width): Renamed from sanitize_width,
171 now that we have two such functions. All uses changed.
172 (sanitize_char_width): New inline function.
173
174 Don't assume that tab-width fits in int.
175 * character.h (sanitize_width): New inline function.
176 (SANE_TAB_WIDTH): New macro.
177 (ASCII_CHAR_WIDTH): Use it.
178 * indent.c (sane_tab_width): Remove. All uses replaced by
179 SANE_TAB_WIDTH (current_buffer).
180 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
181
182 * fileio.c: Integer overflow issues with file modes.
183 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
184
185 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
186 Remove unreachable code.
187 (read_hex, load_charset_map_from_file): Check for integer overflow.
188
189 * xterm.c: don't go over XClientMessageEvent limit
190 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
191 (x_send_scroll_bar_event): Likewise. Check that the size does not
192 exceed limits imposed by XClientMessageEvent, as well as the usual
193 ptrdiff_t and size_t limits.
194
195 * keyboard.c: Overflow, signedness and related fixes.
196 (make_lispy_movement): Use same integer type in forward decl
197 that is used in the definition.
198 (read_key_sequence, keyremap_step):
199 Change bufsize argument back to int, undoing my 2011-03-30 change.
200 We prefer signed types, and int is wide enough here.
201 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
202 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
203 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
204 length, not size_t. Use ptrdiff_t for index, not int.
205 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
206 possibility of integer overflow.
207
208 Overflow, signedness and related fixes for images.
209
210 * dispextern.h (struct it.stack[0].u.image.image_id)
211 (struct_it.image_id, struct image.id, struct image_cache.size)
212 (struct image_cache.used, struct image_cache.ref_count):
213 * gtkutil.c (update_frame_tool_bar):
214 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
215 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
216 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
217 * nsmenu.m (update_frame_tool_bar):
218 * xdisp.c (calc_pixel_width_or_height):
219 * xfns.c (image_cache_refcount):
220 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
221 on typical 64-bit hosts.
222
223 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
224 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
225 Omit unnecessary casts to int.
226 (parse_image_spec): Check that integers fall into 'int' range
227 when the callers expect that.
228 (image_ascent): Redo ascent calculation to avoid int overflow.
229 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
230 (lookup_image): Remove unnecessary tests.
231 (xbm_image_p): Locals are now of int, not EMACS_INT,
232 since parse_image_check makes sure they fit into int.
233 (png_load, gif_load, svg_load_image):
234 Prefer int to unsigned where either will do.
235 (tiff_handler): New function, combining the cores of the
236 old tiff_error_handler and tiff_warning_handler. This
237 function is rewritten to use vsnprintf and thereby avoid
238 stack buffer overflows. It uses only the features of vsnprintf
239 that are common to both POSIX and native Microsoft.
240 (tiff_error_handler, tiff_warning_handler): Use it.
241 (tiff_load, gif_load, imagemagick_load_image):
242 Don't assume :index value fits in 'int'.
243 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
244 (imagemagick_load_image): Check that crop parameters fit into
245 the integer types that MagickCropImage accepts. Don't assume
246 Vimagemagick_render_type has a nonnegative value. Don't assume
247 size_t fits in 'long'.
248 (gs_load): Use printmax_t to print the widest integers possible.
249 Check for integer overflow when computing image height and width.
250
251 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
252
253 Integer signedness and overflow and related fixes. (Bug#9079)
254
255 * bidi.c: Integer size and overflow fixes.
256 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
257 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
258 (bidi_cache_find_level_change, bidi_cache_ensure_space)
259 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
260 (bidi_find_other_level_edge):
261 Use ptrdiff_t instead of EMACS_INT where either will do.
262 This works better on 32-bit hosts configured --with-wide-int.
263 (bidi_cache_ensure_space): Check for size-calculation overflow.
264 Use % rather than repeated addition, for better worst-case speed.
265 Don't set bidi_cache_size until after xrealloc returns, because it
266 might not return.
267 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
268 (bidi_cache_ensure_space): Also check that the bidi cache size
269 does not exceed that of the largest Lisp string or buffer. See Eli
270 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
271
272 * alloc.c (__malloc_size_t): Remove.
273 All uses replaced by size_t. See Andreas Schwab's note
274 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
275
276 * image.c: Improve checking for integer overflow.
277 (check_image_size): Assume that f is nonnull, since
278 it is always nonnull in practice. This is one less thing to
279 worry about when checking for integer overflow later.
280 (x_check_image_size): New function, which checks for integer
281 overflow issues inside X.
282 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
283 This removes the need for a memory_full check.
284 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
285 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
286 (xbm_read_bitmap_data): Change locals back to 'int', since
287 their values must fit in 'int'.
288 (xpm_load_image, png_load, tiff_load):
289 Invoke x_create_x_image_and_pixmap earlier,
290 to avoid much needless work if the image is too large.
291 (tiff_load): Treat overly large images as if
292 x_create_x_image_and_pixmap failed, not as malloc failures.
293 (gs_load): Use x_check_image_size.
294
295 * gtkutil.c: Omit integer casts.
296 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
297 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
298
299 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
300
301 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
302 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
303 would wrongly return t on a 64-bit host.
304
305 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
306 The plain *_OVERFLOW macros run afoul of GCC bug 49705
307 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
308 and therefore cause GCC to emit a bogus diagnostic in some cases.
309
310 * image.c: Integer signedness and overflow and related fixes.
311 This is not an exhaustive set of fixes, but it's time to
312 record what I've got.
313 (lookup_pixel_color, check_image_size): Remove redundant decls.
314 (check_image_size): Don't assume that arbitrary EMACS_INT values
315 fit in 'int', or that arbitrary 'double' values fit in 'int'.
316 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
317 (tiff_load, imagemagick_load_image):
318 Check for overflow in size calculations.
319 (x_create_x_image_and_pixmap): Remove unnecessary test for
320 xmalloc returning NULL; that can't happen.
321 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
322 (xpm_color_bucket): Use better integer hashing function.
323 (xpm_cache_color): Don't possibly over-allocate memory.
324 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
325 (gif_memory_source):
326 Use ptrdiff_t, not int or size_t, to record sizes.
327 (png_load): Don't assume values greater than 2**31 fit in 'int'.
328 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
329 either works, as we prefer signed integers.
330 (tiff_read_from_memory, tiff_write_from_memory):
331 Return tsize_t, not size_t, since that's what the TIFF API wants.
332 (tiff_read_from_memory): Don't fail simply because the read would
333 go past EOF; instead, return a short read.
334 (tiff_load): Omit no-longer-needed casts.
335 (Fimagemagick_types): Don't assume size fits into 'int'.
336
337 Improve hashing quality when configured --with-wide-int.
338 * fns.c (hash_string): New function, taken from sxhash_string.
339 Do not discard information about ASCII character case; this
340 discarding is no longer needed.
341 (sxhash-string): Use it. Change sig to match it. Caller changed.
342 * lisp.h: Declare it.
343 * lread.c (hash_string): Remove, since we now use fns.c's version.
344 The fns.c version returns a wider integer if --with-wide-int is
345 specified, so this should help the quality of the hashing a bit.
346
347 * emacs.c: Integer overflow minor fix.
348 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
349 Define only if GNU_LINUX.
350 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
351
352 * dispnew.c: Integer signedness and overflow fixes.
353 Remove unnecessary forward decls, that were a maintenance hassle.
354 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
355 All uses changed.
356 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
357 (scrolling_window): Use ptrdiff_t, not int, for byte count.
358 (prepare_desired_row, line_draw_cost):
359 Use int, not unsigned, where either works.
360 (save_current_matrix, restore_current_matrix):
361 Use ptrdiff_t, not size_t, where either works.
362 (init_display): Check for overflow more accurately, and without
363 relying on undefined behavior.
364
365 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
366 Remove, replacing with the new symbols in lisp.h. All uses changed.
367 * fileio.c (make_temp_name):
368 * filelock.c (lock_file_1, lock_file):
369 * xdisp.c (message_dolog):
370 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
371 Use pMd etc. instead.
372 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
373 replacing the pWIDE etc. symbols removed from editfns.c.
374
375 * keyboard.h (num_input_events): Now uintmax_t.
376 This is (very slightly) less likely to mess up due to wraparound.
377 All uses changed.
378
379 * buffer.c: Integer signedness fixes.
380 (alloc_buffer_text, enlarge_buffer_text):
381 Use ptrdiff_t rather than size_t when either will do, as we prefer
382 signed integers.
383
384 * alloc.c: Integer signedness and overflow fixes.
385 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
386 (__malloc_size_t): Default to size_t, not to int.
387 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
388 (Fgarbage_collect, mark_object_loop_halt, mark_object):
389 Prefer ptrdiff_t to size_t when either would do, as we prefer
390 signed integers.
391 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
392 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
393 Now const. Initialize with values that are in range even if char
394 is signed.
395 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
396 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
397 These functions do the right thing with sizes > 2**32.
398 (check_depth): Now ptrdiff_t, not int.
399 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
400 Adjust to new way of storing sizes. Check for size overflow bugs
401 in rest of code.
402 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
403 slightly wrong anyway, as it missed one instance of
404 XMALLOC_OVERRUN_CHECK_OVERHEAD.
405 (refill_memory_reserve): Omit needless cast to size_t.
406 (mark_object_loop_halt): Mark as externally visible.
407
408 * xselect.c: Integer signedness and overflow fixes.
409 (Fx_register_dnd_atom, x_handle_dnd_message):
410 Use ptrdiff_t, not size_t, since we prefer signed.
411 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
412 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
413 x_dnd_atoms_size and x_dnd_atoms_length.
414
415 * doprnt.c: Prefer signed to unsigned when either works.
416 * eval.c (verror):
417 * doprnt.c (doprnt):
418 * lisp.h (doprnt):
419 * xdisp.c (vmessage):
420 Use ptrdiff_t, not size_t, when using or implementing doprnt,
421 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
422 prefer signed arithmetic to avoid comparison confusion.
423 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
424 but is a bit tricky.
425
426 Assume freestanding C89 headers, string.h, stdlib.h.
427 * data.c, doprnt.c, floatfns.c, print.c:
428 Include float.h unconditionally.
429 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
430 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
431 * regex.c: Likewise for stddef.h, string.h.
432 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
433 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
434 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
435 (STDC_HEADERS): Remove obsolete defines.
436 * sysdep.c: Include limits.h unconditionally.
437
438 Assume support for memcmp, memcpy, memmove, memset.
439 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
440 * regex.c (memcmp, memcpy):
441 Remove; we assume C89 now.
442
443 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
444 (__malloc_safe_bcopy): Remove; no longer needed.
445
446 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
447 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
448 well either way, and we prefer signed to unsigned.
449
450 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
451
452 Port to OpenBSD.
453 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
454 and the surrounding thread.
455 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
456 rather than fgets, and retry after EINTR. Otherwise, 'emacs
457 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
458 timer goes off.
459 * s/openbsd.h (BROKEN_SIGIO): Define.
460 * unexelf.c (unexec) [__OpenBSD__]:
461 Don't update the .mdebug section of the Alpha COFF symbol table.
462
463 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
464
465 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
466 (bug#8460).
467
468 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
469
470 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
471 This fixes some race conditions on the permissions of any newly
472 created file.
473
474 * alloc.c (valid_pointer_p): Use pipe, not open.
475 This fixes some permissions issues when debugging.
476
477 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
478 If fchown fails to set both uid and gid, try to set just gid,
479 as that is sometimes allowed. Adjust the file's mode to eliminate
480 setuid or setgid bits that are inappropriate if fchown fails.
481
482 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
483
484 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
485 to compare Lisp_Objects.
486 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
487 global_gnutls_log_level, don't mistake it for a Lisp_Object.
488 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
489
490 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
491
492 * lread.c (read_integer): Unread even EOF character.
493 (read1): Likewise. Properly record start position of symbol.
494
495 * lread.c (read1): Read `#:' as empty uninterned symbol if no
496 symbol character follows.
497
498 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
499
500 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
501 This works around a problem with the previous change to Fcopy_file.
502 Recent glibc declares fchown with __attribute__((warn_unused_result)),
503 and without this change, GCC might complain about discarding
504 fchown's return value.
505
506 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
507
508 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
509
510 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
511
512 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
513
514 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
515
516 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
517 it's used from the C level.
518
519 * process.c: Use the same condition for POLL_FOR_INPUT in both
520 keyboard.c and process.c (bug#1858).
521
522 2011-07-09 Lawrence Mitchell <wence@gmx.li>
523
524 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
525 (Fgnutls_boot): Use it.
526
527 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
528
529 * doc.c (Fsubstitute_command_keys): Revert last change.
530
531 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
532
533 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
534 quotes the next character, and doesn't affect other longer
535 sequences (bug#8935).
536
537 * lread.c (syms_of_lread): Clarify that is isn't only
538 `eval-buffer' and `eval-defun' that's affected by
539 `lexical-binding' (bug#8460).
540
541 2011-07-15 Eli Zaretskii <eliz@gnu.org>
542
543 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
544 bidi redisplay when a line includes both an image and is
545 truncated.
546
547 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
548
549 Fix minor problems found by static checking.
550 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
551 (elsz): Now a signed constant, not a size_t var. We prefer signed
552 types to unsigned, to avoid integer comparison confusion. Without
553 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
554 "cannot optimize loop, the loop counter may overflow", a symptom
555 of the confusion.
556 * indent.c (Fvertical_motion): Mark locals as initialized.
557 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
558
559 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
560
561 * search.c (Fre_search_backward): Mention `case-fold-search' in
562 all the re_search_* functions (bug#8138).
563
564 * keyboard.c (Fopen_dribble_file): Document when the file is
565 closed (bug#8056).
566
567 2011-07-14 Eli Zaretskii <eliz@gnu.org>
568
569 * bidi.c (bidi_dump_cached_states): Fix format of displaying
570 bidi_cache_idx.
571
572 Support bidi reordering of display and overlay strings.
573 * xdisp.c (compute_display_string_pos)
574 (compute_display_string_end): Accept additional argument STRING.
575 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
576 (reseat_to_string): Initialize bidi_it->string.s and
577 bidi_it->string.schars.
578 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
579 NULL (avoids a crash in bidi_paragraph_init). Initialize
580 itb.string.lstring.
581 (init_iterator): Call bidi_init_it only of a valid
582 buffer position was specified. Initialize paragraph_embedding to
583 L2R.
584 (reseat_to_string): Initialize the bidi iterator.
585 (display_string): If we need to ignore text properties of
586 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
587 original value of -1 will not work with bidi.)
588 (compute_display_string_pos): First arg is now struct
589 `text_pos *'; all callers changed. Support display properties on
590 Lisp strings.
591 (compute_display_string_end): Support display properties on Lisp
592 strings.
593 (init_iterator, reseat_1, reseat_to_string): Initialize the
594 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
595 when iterating on a string not from display properties).
596 (compute_display_string_pos, compute_display_string_end): Fix
597 calculation of the object to scan. Fixes an error when using
598 arrow keys.
599 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
600 base_level_stop; instead, set base_level_stop to BEGV. Fixes
601 crashes in vertical-motion.
602 (next_element_from_buffer): Improve commentary for when
603 the iterator is before prev_stop.
604 (init_iterator): Initialize bidi_p from the default value of
605 bidi-display-reordering, not from buffer-local value. Use the
606 buffer-local value only if initializing for buffer iteration.
607 (handle_invisible_prop): Support invisible properties on strings
608 that are being bidi-reordered.
609 (set_iterator_to_next): Support bidi reordering of C strings and
610 Lisp strings.
611 (next_element_from_string): Support bidi reordering of Lisp
612 strings.
613 (handle_stop_backwards): Support Lisp strings as well.
614 (display_string): Support display of R2L glyph rows. Use
615 IT_STRING_CHARPOS when displaying from a Lisp string.
616 (init_iterator): Don't initialize it->bidi_p for strings
617 here.
618 (reseat_to_string): Initialize it->bidi_p for strings here.
619 (next_element_from_string, next_element_from_c_string)
620 (next_element_from_buffer): Add xassert's for correspondence
621 between IT's object being iterated and it->bidi_it.string
622 structure.
623 (face_before_or_after_it_pos): Support bidi iteration.
624 (next_element_from_c_string): Handle the case of the first string
625 character that is not the first one in the visual order.
626 (get_visually_first_element): New function, refactored from common
627 parts of next_element_from_buffer, next_element_from_string, and
628 next_element_from_c_string.
629 (tool_bar_lines_needed, redisplay_tool_bar)
630 (display_menu_bar): Force left-to-right direction. Add a FIXME
631 comment for making that be controlled by a user option.
632 (push_it, pop_it): Save and restore the state of the
633 bidi iterator. Save and restore the bidi_p flag.
634 (pop_it): Iterate out of display property for string iteration as
635 well.
636 (iterate_out_of_display_property): Support iteration over strings.
637 (handle_single_display_spec): Set up it->bidi_it for iteration
638 over a display string, and call bidi_init_it.
639 (handle_single_display_spec, next_overlay_string)
640 (get_overlay_strings_1, push_display_prop): Set up the bidi
641 iterator for displaying display or overlay strings.
642 (forward_to_next_line_start): Don't use the shortcut if
643 bidi-iterating.
644 (back_to_previous_visible_line_start): If handle_display_prop
645 pushed the iterator stack, restore the internal state of the bidi
646 iterator by calling bidi_pop_it same number of times.
647 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
648 and we are bidi-iterating, don't decrement the iterator position;
649 instead, set the first_elt flag in the bidi iterator, to produce
650 the same effect.
651 (reseat_1): Remove redundant setting of string_from_display_prop_p.
652 (push_display_prop): xassert that we are iterating a buffer.
653 (push_it, pop_it): Save and restore paragraph_embedding member.
654 (handle_single_display_spec, next_overlay_string)
655 (get_overlay_strings_1, reseat_1, reseat_to_string)
656 (push_display_prop): Set up the `unibyte' member of bidi_it.string
657 correctly. Don't assume unibyte strings are not bidi-reordered.
658 (compute_display_string_pos)
659 (compute_display_string_end): Fix handling the case of C string.
660 (push_it, pop_it): Save and restore from_disp_prop_p.
661 (handle_single_display_spec, push_display_prop): Set the
662 from_disp_prop_p flag.
663 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
664 (pop_it): Call iterate_out_of_display_property only if we are
665 popping after iteration over a string that came from a display
666 property. Fix a typo in popping stretch info. Add an assertion
667 for verifying that the iterator position is in sync with the bidi
668 iterator.
669 (handle_single_display_spec, get_overlay_strings_1)
670 (push_display_prop): Fix initialization of paragraph direction for
671 string when that of the parent object is not yet determined.
672 (reseat_1): Call bidi_init_it to resync the bidi
673 iterator with IT's position. (Bug#7616)
674 (find_row_edges): If ROW->start.pos gives position
675 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
676 (handle_stop, back_to_previous_visible_line_start, reseat_1):
677 Reset the from_disp_prop_p flag.
678 (SAVE_IT, RESTORE_IT): New macros.
679 (pos_visible_p, face_before_or_after_it_pos)
680 (back_to_previous_visible_line_start)
681 (move_it_in_display_line_to, move_it_in_display_line)
682 (move_it_to, move_it_vertically_backward, move_it_by_lines)
683 (try_scrolling, redisplay_window, display_line): Use them when
684 saving a temporary copy of the iterator and restoring it back.
685 (back_to_previous_visible_line_start, reseat_1)
686 (init_iterator): Empty the bidi cache "stack".
687 (move_it_in_display_line_to): If iterator ended up at
688 EOL, but we never saw any buffer positions smaller than
689 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
690 motion in bidi-reordered lines.
691 (move_it_in_display_line_to): Record prev_method and prev_pos
692 immediately before the call to set_iterator_to_next. Fixes cursor
693 motion in bidi-reordered lines with stretch glyphs and strings
694 displayed in margins. (Bug#8133) (Bug#8867)
695 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
696 TO_CHARPOS.
697 (pos_visible_p): Support positions in bidi-reordered lines. Save
698 and restore bidi cache.
699
700 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
701 (bidi_paragraph_info): Delete unused struct.
702 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
703 (bidi_cache_start): New variable.
704 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
705 to zero.
706 (bidi_cache_fetch_state, bidi_cache_search)
707 (bidi_cache_find_level_change, bidi_cache_iterator_state)
708 (bidi_cache_find, bidi_peek_at_next_level)
709 (bidi_level_of_next_char, bidi_find_other_level_edge)
710 (bidi_move_to_visually_next): Compare cache index with
711 bidi_cache_start rather than with zero.
712 (bidi_fetch_char): Accept new argument STRING; all callers
713 changed. Support iteration over a string. Support strings with
714 display properties. Support unibyte strings. Fix the type of
715 `len' according to what STRING_CHAR_AND_LENGTH expects.
716 (bidi_paragraph_init, bidi_resolve_explicit_1)
717 (bidi_resolve_explicit, bidi_resolve_weak)
718 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
719 iteration over a string.
720 (bidi_set_sor_type, bidi_resolve_explicit_1)
721 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
722 can now be zero (for strings); special values 0 and -1 were
723 changed to -1 and -2, respectively.
724 (bidi_char_at_pos): New function.
725 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
726 Call it instead of FETCH_MULTIBYTE_CHAR.
727 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
728 initialized to valid values.
729 (bidi_init_it): Don't initialize charpos and bytepos with invalid
730 values.
731 (bidi_level_of_next_char): Allow the sentinel "position" to pass
732 the test for valid cached positions. Fix the logic for looking up
733 the sentinel state in the cache. GCPRO the Lisp string we are
734 iterating.
735 (bidi_push_it, bidi_pop_it): New functions.
736 (bidi_initialize): Initialize the bidi cache start stack pointer.
737 (bidi_cache_ensure_space): New function, refactored from part of
738 bidi_cache_iterator_state. Don't assume the required size is just
739 one BIDI_CACHE_CHUNK away.
740 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
741 (bidi_count_bytes, bidi_char_at_pos): New functions.
742 (bidi_cache_search): Don't assume bidi_cache_last_idx is
743 always valid if bidi_cache_idx is valid.
744 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
745 is valid if it's going to be used.
746 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
747 (bidi_cache_fetch_state, bidi_cache_search)
748 (bidi_cache_find_level_change, bidi_cache_ensure_space)
749 (bidi_cache_iterator_state, bidi_cache_find)
750 (bidi_find_other_level_edge, bidi_cache_start_stack): All
751 variables related to cache indices are now EMACS_INT.
752
753 * dispextern.h (struct bidi_string_data): New structure.
754 (struct bidi_it): New member `string'. Make flag members be 1-bit
755 fields, and put them last in the struct.
756 (compute_display_string_pos, compute_display_string_end): Update
757 prototypes.
758 (bidi_push_it, bidi_pop_it): Add prototypes.
759 (struct iterator_stack_entry): New members bidi_p,
760 paragraph_embedding, and from_disp_prop_p.
761 (struct it): Member bidi_p is now a bit field 1 bit wide.
762 (bidi_shelve_cache, bidi_unshelve_cache): Declare
763 prototypes.
764
765 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
766 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
767 and vector-like objects.
768
769 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
770 cache around display iteration.
771
772 * window.c (Fwindow_end, window_scroll_pixel_based)
773 (displayed_window_lines, Frecenter): Save and restore the bidi
774 cache around display iteration.
775
776 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
777
778 * editfns.c (Fdelete_region): Clarify the use of the named
779 parameters (bug#6788).
780
781 2011-07-14 Martin Rudalics <rudalics@gmx.at>
782
783 * indent.c (Fvertical_motion): Set and restore w->pointm when
784 saving and restoring the window's buffer (Bug#9006).
785
786 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
787
788 * editfns.c (Fstring_to_char): Clarify just what is returned
789 (bug#6576). Text by Eli Zaretskii.
790
791 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
792
793 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
794
795 2011-07-13 Eli Zaretskii <eliz@gnu.org>
796
797 * buffer.c (mmap_find): Fix a typo.
798
799 2011-07-13 Johan Bockgård <bojohan@gnu.org>
800
801 Fix execution of x selection hooks.
802 * xselect.c (Qx_lost_selection_functions)
803 (Qx_sent_selection_functions): New vars.
804 (syms_of_xselect): DEFSYM them.
805 (x_handle_selection_request): Pass Qx_sent_selection_functions
806 rather than Vx_sent_selection_functions to Frun_hook_with_args.
807 (x_handle_selection_clear,x_clear_frame_selections):
808 Pass Qx_lost_selection_functions rather than
809 Vx_lost_selection_functions to Frun_hook_with_args.
810
811 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
812
813 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
814 The old code sometimes used this field without initializing it.
815
816 * alloc.c (gc_sweep): Don't read past end of array.
817 In theory, the old code could also have corrupted Emacs internals,
818 though it'd be very unlikely.
819
820 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
821
822 * character.c (Fcharacterp): Don't advertise optional ignored
823 argument. (Bug#4026)
824
825 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
826
827 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
828 key" (bug#4257).
829
830 * window.c (Fset_window_start): Doc fix (bug#4199).
831 (Fset_window_hscroll): Ditto.
832
833 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
834
835 Fix minor new problems caught by GCC 4.6.1.
836 * term.c (init_tty): Remove unused local.
837 * xsettings.c (store_monospaced_changed): Define this function only
838 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
839 not used otherwise.
840
841 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
842
843 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
844
845 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
846
847 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
848 are the mini-buffer and the echo area (bug#3320).
849
850 * term.c (init_tty): Remove support for supdup, c10 and perq
851 terminals, which are no longer supported (bug#1482).
852
853 2011-07-10 Johan Bockgård <bojohan@gnu.org>
854
855 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
856
857 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
858
859 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
860 for non-popups (Bug#3642).
861
862 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
863
864 * alloc.c (reset_malloc_hooks): Protoize.
865 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
866 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
867 * cm.c (losecursor): Likewise.
868 * data.c (fmod): Likewise.
869 * dispnew.c (swap_glyphs_in_rows): Likewise.
870 * emacs.c (memory_warning_signal): Likewise.
871 * floatfns.c (float_error): Likewise.
872 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
873 (otf_open, font_otf_capability, generate_otf_features)
874 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
875 Likewise.
876 * image.c (pbm_read_file): Likewise.
877 * indent.c (string_display_width): Likewise.
878 * intervals.c (check_for_interval, search_for_interval)
879 (inc_interval_count, count_intervals, root_interval)
880 (adjust_intervals_for_insertion, make_new_interval): Likewise.
881 * lread.c (defalias): Likewise.
882 * ralloc.c (r_alloc_check): Likewise.
883 * regex.c (set_image_of_range_1, set_image_of_range)
884 (regex_grow_registers): Likewise.
885 * sysdep.c (strerror): Likewise.
886 * termcap.c (valid_filename_p, tprint, main): Likewise.
887 * tparam.c (main): Likewise.
888 * unexhp9k800.c (run_time_remap, save_data_space)
889 (update_file_ptrs, read_header, write_header, calculate_checksum)
890 (copy_file, copy_rest, display_header): Likewise.
891 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
892 Likewise.
893 * xdisp.c (check_it): Likewise.
894 * xfaces.c (register_color, unregister_color, unregister_colors):
895 Likewise.
896 * xfns.c (print_fontset_result): Likewise.
897 * xrdb.c (member, fatal, main): Likewise.
898
899 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
900
901 Fix minor problems found by static checking (Bug#9031).
902 * chartab.c (char_table_set_range, map_sub_char_table):
903 Remove unused locals.
904 (uniprop_table): Now static.
905 * composite.c (_work_char): Remove unused static var.
906
907 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
908
909 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
910
911 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
912
913 * gtkutil.c (qttip_cb): Remove code without function.
914
915 2011-07-09 Eli Zaretskii <eliz@gnu.org>
916
917 * w32.c (pthread_sigmask): New stub.
918
919 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
920
921 Use pthread_sigmask, not sigprocmask (Bug#9010).
922 sigprocmask is portable only for single-threaded applications, and
923 Emacs can be multi-threaded when it uses GTK.
924 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
925 (LIBES): Use it.
926 * callproc.c (Fcall_process):
927 * process.c (create_process):
928 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
929 Use pthread_sigmask, not sigprocmask.
930
931 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
932
933 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
934 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
935 wrong (Bug#8591).
936
937 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
938
939 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
940 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
941 (xg_hide_tooltip): Fix comment.
942
943 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
944 in registerServicesMenuSendTypes.
945 (validRequestorForSendType): Don't check ns_return_types.
946
947 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
948 ns_return_type.
949
950 2011-07-08 Jason Rumney <jasonr@gnu.org>
951
952 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
953 frame struct members of non-existent frames (Bug#6284).
954
955 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
956
957 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
958 variable firstTime not needed on OSX >= 10.6.
959 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
960 >= 10.5. Use setKnobProportion, setDoubleValue.
961
962 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
963 (MAC_OS_X_VERSION_10_5): Define if not defined.
964 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
965 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
966 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
967
968 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
969 cString and lossyCString on OSX >= 10.4
970
971 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
972 sizeToFit on OSX >= 10.2.
973
974 * nsimage.m (allocInitFromFile): Don't use deprecated method
975 bestRepresentationForDevice on OSX >= 10.6.
976
977 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
978 to avoid warning.
979
980 * emacs.c: Declare unexec_init_emacs_zone.
981
982 * nsgui.h: Fix compiler warning about gnulib redefining verify.
983
984 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
985
986 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
987 on svcsMenu (Bug#8842).
988
989 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
990 ns_return_types.
991 (Fns_list_services): Just return Qnil on 10.6, code not working there.
992
993 * nsterm.m (QUTF8_STRING): Declare.
994 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
995 (validRequestorForSendType): Return type is (id).
996 Change indexOfObjectIdenticalTo to indexOfObject.
997 Check if we have local selection before returning self (Bug#8842).
998 (writeSelectionToPasteboard): Put local selection into paste board
999 if we have a local selection (Bug#8842).
1000 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1001
1002 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1003 (ns_get_local_selection): Declare.
1004
1005 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1006
1007 * keymap.c (describe_map_tree): Don't insert a double newline at
1008 the end of the buffer (bug#1169) and return whether we inserted
1009 something.
1010
1011 * callint.c (Fcall_interactively): Change "reading args" to
1012 "providing args" to try to clarify what it does (bug#1010).
1013
1014 2011-07-07 Kenichi Handa <handa@m17n.org>
1015
1016 * composite.c (composition_compute_stop_pos): Ignore a static
1017 composition starting before CHARPOS (Bug#8915).
1018
1019 * xdisp.c (handle_composition_prop): Likewise.
1020
1021 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1022
1023 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1024 (Bug#9015)
1025
1026 2011-07-07 Kenichi Handa <handa@m17n.org>
1027
1028 * character.h (unicode_category_t): New enum type.
1029
1030 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1031 (Qchar_code_property_table): New variable.
1032 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1033 (UNIPROP_COMPRESSED_FORM_P): New macros.
1034 (char_table_ascii): Uncompress the compressed values.
1035 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1036 Uncompress the compressed values.
1037 (sub_char_table_ref_and_range): Likewise.
1038 (char_table_ref_and_range): Uncompress the compressed values.
1039 (sub_char_table_set): New arg is_uniprop. Callers changed.
1040 Uncompress the compressed values.
1041 (sub_char_table_set_range): Args changed. Callers changed.
1042 (char_table_set_range): Adjuted for the above change.
1043 (map_sub_char_table): Delete args default_val and parent. Add arg
1044 top. Give decoded values to a Lisp function.
1045 (map_char_table): Adjusted for the above change. Give decoded
1046 values to a Lisp function. Gcpro more variables.
1047 (uniprop_table_uncompress)
1048 (uniprop_decode_value_run_length): New functions.
1049 (uniprop_decoder, uniprop_decoder_count): New variables.
1050 (uniprop_get_decoder, uniprop_encode_value_character)
1051 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1052 New functions.
1053 (uniprop_encoder, uniprop_encoder_count): New variables.
1054 (uniprop_get_encoder, uniprop_table)
1055 (Funicode_property_table_internal, Fget_unicode_property_internal)
1056 (Fput_unicode_property_internal): New functions.
1057 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1058 Sunicode_property_table_internal, Sget_unicode_property_internal,
1059 and Sput_unicode_property_internal. Defvar_lisp
1060 char-code-property-alist.
1061
1062 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
1063 Vunicode_category_table.
1064
1065 * font.c (font_range): Adjusted for the change of
1066 Vunicode_category_table.
1067
1068 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1069
1070 * m/iris4d.h: Remove file, move contents ...
1071 * s/irix6-5.h: ... here.
1072
1073 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1074
1075 Remove unportable assumption about struct layout (Bug#8884).
1076 * alloc.c (mark_buffer):
1077 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1078 (clone_per_buffer_values): Don't assume that
1079 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1080 This isn't true in general, and it's particularly not true
1081 if Emacs is configured with --with-wide-int.
1082 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1083 New macros, used in the buffer.c change.
1084
1085 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1086
1087 * xsettings.c: Use both GConf and GSettings if both are available.
1088 (store_config_changed_event): Add comment.
1089 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1090 (store_tool_bar_style_changed): New functions.
1091 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1092 (struct xsettings): Move font inside HAVE_XFT.
1093 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1094 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
1095 Move inside HAVE_XFT.
1096 (something_changed_gsettingsCB): Renamed from something_changedCB.
1097 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1098 also.
1099 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1100 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1101 (something_changed_gconfCB): Renamed from something_changedCB.
1102 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1103 (parse_settings): Move check for font inside HAVE_XFT.
1104 (read_settings, apply_xft_settings): Add comment.
1105 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1106 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1107 call store_font_name_changed.
1108 (xft_settings_event): Add comment.
1109 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1110 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1111 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1112 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1113 (xsettings_initialize): Call init_gsettings last.
1114 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
1115 comment.
1116
1117 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1118
1119 Random fixes. E.g., (random) never returned negative values.
1120 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1121 subseconds part to the entropy, as that's a bit more random.
1122 Prefer signed to unsigned, since the signedness doesn't matter and
1123 in general we prefer signed. When given a limit, use a
1124 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1125 latter isn't right if USE_2_TAGS_FOR_INTS.
1126 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1127 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1128
1129 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1130
1131 * textprop.c (text_property_stickiness):
1132 Obey Vtext_property_default_nonsticky.
1133 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1134 * w32fns.c (syms_of_w32fns):
1135 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1136
1137 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1138
1139 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1140 This is more efficient than Ffile_directory_p and avoids a minor race.
1141
1142 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1143
1144 * buffer.c (Foverlay_put): Say what the return value is
1145 (bug#7835).
1146
1147 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1148 is a directory before asking whether to use the file name
1149 (bug#7564).
1150 (barf_or_query_if_file_exists): Make the "File is a directory"
1151 error be more correct.
1152
1153 * fns.c (Frequire): Remove the mention of the .gz files, since
1154 that's installation-specific, but keep the mention of
1155 `get-load-suffixes'.
1156
1157 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1158
1159 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1160 Report string overflow if the output is too long.
1161
1162 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1163
1164 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1165 (syms_of_gnutls): Remove duplicate DEFSYM for
1166 Qgnutls_bootprop_verify_hostname_error, an error for
1167 Qgnutls_bootprop_verify_error (which is no longer used).
1168
1169 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1170 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1171 Also (re)move comments that are misplaced or no longer relevant.
1172
1173 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1174
1175 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1176
1177 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1178
1179 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1180 and background color parameters if they have been changed.
1181
1182 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1183
1184 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1185
1186 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1187
1188 * xsettings.c (SYSTEM_FONT): Define only when used.
1189 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1190
1191 * keymap.c (access_keymap_1): Now static.
1192
1193 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1194
1195 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1196 leave any prefix arg for the up event (Bug#1586).
1197
1198 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1199
1200 * lread.c (syms_of_lread): Mention single symbols defined by
1201 `defvar' or `defconst' (bug#7154).
1202
1203 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1204 (Frequire): Mention get-load-suffixes.
1205
1206 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1207
1208 * window.h (window): Remove clone_number slot.
1209 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1210 Remove.
1211 (make_parent_window, make_window, saved_window)
1212 (Fset_window_configuration, save_window_save): Don't deal with
1213 clone numbers.
1214 * buffer.c (Qclone_number): Remove declaration.
1215 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1216
1217 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1218
1219 Add multiple inheritance to keymaps.
1220 * keymap.c (Fmake_composed_keymap): New function.
1221 (Fset_keymap_parent): Simplify.
1222 (fix_submap_inheritance): Remove.
1223 (access_keymap_1): New function extracted from access_keymap to handle
1224 embedded parents and handle lists of maps.
1225 (access_keymap): Use it.
1226 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1227 (Fcopy_keymap): Handle embedded parents.
1228 (Fcommand_remapping, define_as_prefix): Simplify.
1229 (Fkey_binding): Simplify.
1230 (syms_of_keymap): Move minibuffer-local-completion-map,
1231 minibuffer-local-filename-completion-map,
1232 minibuffer-local-must-match-map, and
1233 minibuffer-local-filename-must-match-map to Elisp.
1234 (syms_of_keymap): Defsubr make-composed-keymap.
1235 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1236 (parse_menu_item): Trivial simplification.
1237
1238 2011-07-01 Glenn Morris <rgm@gnu.org>
1239
1240 * Makefile.in (SETTINGS_LIBS): Fix typo.
1241
1242 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1243
1244 * coding.c (Fencode_coding_string): Record the last coding system
1245 used, as the function doc string says (bug#8738).
1246
1247 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1248
1249 * xsettings.c (store_monospaced_changed): Take new font as arg and
1250 check for change against current_mono_font.
1251 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1252 (emacs_settings_constructor, emacs_settings_get_property)
1253 (emacs_settings_set_property, emacs_settings_class_init)
1254 (emacs_settings_init, gsettings_obj): Remove.
1255 (something_changedCB): New function for HAVE_GSETTINGS.
1256 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1257 with value as argument.
1258 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1259 g_settings_new (Bug#8967). Do not create gsettings_obj.
1260 Remove calls to g_settings_bind. Connect something_changedCB to
1261 "changed".
1262
1263 * xgselect.c: Add defined (HAVE_GSETTINGS).
1264 (xgselect_initialize): Ditto.
1265
1266 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1267 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1268 xg_select.
1269
1270 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1271
1272 * eval.c (struct backtrace): Simplify and port the data structure.
1273 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1274 signed bit field, as this assumption is not portable and it makes
1275 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1276 "char debug_on_exit : 1" as this is not portable either; instead,
1277 use the portable "unsigned int debug_on_exit : 1". Remove unused
1278 member evalargs. Remove obsolete comments about cc bombing out.
1279
1280 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1281
1282 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1283 Let HAVE_GSETTINGS override HAVE_GCONF.
1284 (store_monospaced_changed): New function.
1285 (EMACS_SETTINGS): A new type derived from GObject to handle
1286 GSettings notifications.
1287 (emacs_settings_constructor, emacs_settings_get_property)
1288 (emacs_settings_set_property, emacs_settings_class_init):
1289 New functions.
1290 (gsettings_client, gsettings_obj): New variables.
1291 (GSETTINGS_SCHEMA): New define.
1292 (something_changedCB): Call store_monospaced_changed.
1293 (init_gsettings): New function.
1294 (xsettings_initialize): Call init_gsettings.
1295 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1296 to NULL.
1297
1298 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
1299 GCONF_CFLAGS/LIBS.
1300
1301 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1302
1303 * window.c (resize_root_window, grow_mini_window)
1304 (shrink_mini_window): Rename Qresize_root_window to
1305 Qwindow_resize_root_window and Qresize_root_window_vertically to
1306 Qwindow_resize_root_window_vertically.
1307
1308 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1309
1310 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1311
1312 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1313
1314 * makefile.w32-in: Redesign dependencies so they reflect more
1315 clearly which files are directly included by each source file,
1316 and not through other includes.
1317
1318 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1319
1320 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1321 (sort_overlays, overlay_strings): When an overlay's clone number
1322 matches the window's clone number process the overlay even if
1323 the overlay's window property doesn't match the current window.
1324
1325 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1326 (Fwindow_hchild): Rename to Fwindow_left_child.
1327 (Fwindow_next): Rename to Fwindow_next_sibling.
1328 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1329 (resize_window_check): Rename to window_resize_check.
1330 (resize_window_apply): Rename to window_resize_apply.
1331 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1332 (Fdelete_other_windows_internal, resize_frame_windows)
1333 (Fsplit_window_internal, Fdelete_window_internal)
1334 (grow_mini_window, shrink_mini_window)
1335 (Fresize_mini_window_internal): Fix callers accordingly.
1336
1337 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1338
1339 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1340 (emacs_fixed_set_min_size): Remove.
1341 (emacs_fixed_new): Take frame as argument.
1342
1343 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1344 (_EmacsFixedPrivate): Remove minwidth/height.
1345 Add struct frame *f.
1346 (emacs_fixed_init): Initialize priv->f.
1347 (get_parent_class, emacs_fixed_set_min_size): Remove.
1348 (emacs_fixed_new): Set priv->f to argument.
1349 (emacs_fixed_get_preferred_width)
1350 (emacs_fixed_get_preferred_height): Use min_width/height from
1351 frames size_hint to set minimum and natural (Bug#8919).
1352 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1353 and use min_width/height from frames size_hint to set
1354 min_width/height (Bug#8919).
1355
1356 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1357 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1358 Fix indentation.
1359
1360 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1361
1362 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1363 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1364 called at ZV.
1365
1366 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1367
1368 * process.c (wait_reading_process_output): Bypass select if
1369 waiting for a cell while ignoring keyboard input, and input is
1370 pending. Suggested by Jan Djärv (Bug#8869).
1371
1372 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1373
1374 Use gnulib's dup2 module instead of rolling our own.
1375 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1376
1377 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1378
1379 * dispnew.c (scrolling_window): Before scrolling, turn off a
1380 mouse-highlight in the window being scrolled.
1381
1382 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1383
1384 Move DEFSYM to lisp.h and use everywhere.
1385
1386 * character.h (DEFSYM): Move declaration...
1387 * lisp.h (DEFSYM): ...here.
1388
1389 * gnutls.c:
1390 * minibuf.c:
1391 * w32menu.c:
1392 * w32proc.c:
1393 * w32select.c: Don't include character.h.
1394
1395 * alloc.c (syms_of_alloc):
1396 * buffer.c (syms_of_buffer):
1397 * bytecode.c (syms_of_bytecode):
1398 * callint.c (syms_of_callint):
1399 * casefiddle.c (syms_of_casefiddle):
1400 * casetab.c (init_casetab_once):
1401 * category.c (init_category_once, syms_of_category):
1402 * ccl.c (syms_of_ccl):
1403 * cmds.c (syms_of_cmds):
1404 * composite.c (syms_of_composite):
1405 * dbusbind.c (syms_of_dbusbind):
1406 * dired.c (syms_of_dired):
1407 * dispnew.c (syms_of_display):
1408 * doc.c (syms_of_doc):
1409 * editfns.c (syms_of_editfns):
1410 * emacs.c (syms_of_emacs):
1411 * eval.c (syms_of_eval):
1412 * fileio.c (syms_of_fileio):
1413 * fns.c (syms_of_fns):
1414 * frame.c (syms_of_frame):
1415 * fringe.c (syms_of_fringe):
1416 * insdel.c (syms_of_insdel):
1417 * keymap.c (syms_of_keymap):
1418 * lread.c (init_obarray, syms_of_lread):
1419 * macros.c (syms_of_macros):
1420 * msdos.c (syms_of_msdos):
1421 * print.c (syms_of_print):
1422 * process.c (syms_of_process):
1423 * search.c (syms_of_search):
1424 * sound.c (syms_of_sound):
1425 * syntax.c (init_syntax_once, syms_of_syntax):
1426 * terminal.c (syms_of_terminal):
1427 * textprop.c (syms_of_textprop):
1428 * undo.c (syms_of_undo):
1429 * w32.c (globals_of_w32):
1430 * window.c (syms_of_window):
1431 * xdisp.c (syms_of_xdisp):
1432 * xfaces.c (syms_of_xfaces):
1433 * xfns.c (syms_of_xfns):
1434 * xmenu.c (syms_of_xmenu):
1435 * xsettings.c (syms_of_xsettings):
1436 * xterm.c (syms_of_xterm): Use DEFSYM.
1437
1438 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1439
1440 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1441
1442 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1443
1444 Integer and buffer overflow fixes (Bug#8873).
1445
1446 * print.c (printchar, strout): Check for string overflow.
1447 (PRINTPREPARE, printchar, strout):
1448 Don't set size unless allocation succeeds.
1449
1450 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1451 for sizes. Check for string overflow more accurately.
1452 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1453
1454 * macros.c: Integer and buffer overflow fixes.
1455 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1456 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1457 Use ptrdiff_t, not int, for sizes.
1458 Don't increment bufsize until after realloc succeeds.
1459 Check for size-calculation overflow.
1460 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1461
1462 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1463
1464 * lread.c: Integer overflow fixes.
1465 (read_integer): Radix is now EMACS_INT, not int,
1466 to improve quality of diagnostics for out-of-range radices.
1467 Calculate buffer size correctly for out-of-range radices.
1468 (read1): Check for integer overflow in radices, and in
1469 read-circle numbers.
1470 (read_escape): Avoid int overflow.
1471 (Fload, openp, read_buffer_size, read1)
1472 (substitute_object_recurse, read_vector, read_list, map_obarray):
1473 Use ptrdiff_t, not int, for sizes.
1474 (read1): Use EMACS_INT, not int, for sizes.
1475 Check for size overflow.
1476
1477 * image.c (cache_image): Check for size arithmetic overflow.
1478
1479 * lread.c: Integer overflow issues.
1480 (saved_doc_string_size, saved_doc_string_length)
1481 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1482 Now ptrdiff_t, not int.
1483 (read1): Don't assume doc string length fits in int. Check for
1484 out-of-range doc string lengths.
1485 (read_list): Don't assume file position fits in int.
1486 (read_escape): Check for hex character overflow.
1487
1488 2011-06-22 Leo Liu <sdl.web@gmail.com>
1489
1490 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1491 Move to minibuffer.el.
1492
1493 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1494
1495 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1496 The following patches are for when GLYPH_DEBUG && !XASSERT.
1497 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1498 * dispnew.c (flush_stdout):
1499 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1500 Mark as externally visible.
1501 * dispnew.c (check_window_matrix_pointers): Now static.
1502 * dispnew.c (window_to_frame_vpos):
1503 * xfns.c (unwind_create_frame):
1504 * xterm.c (x_check_font): Remove unused local.
1505 * scroll.c (CHECK_BOUNDS):
1506 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1507 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1508 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1509 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1510 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1511 Now static.
1512 (debug_method_add): Use va_list and vsprintf rather than relying
1513 on undefined behavior with wrong number of arguments.
1514 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1515 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1516 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1517 since we're not interested in debugging glyphs with old libraries.
1518 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1519 GCC 4.6.0's static checking.
1520
1521 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1522
1523 Integer overflow and signedness fixes (Bug#8873).
1524 A few related buffer overrun fixes, too.
1525
1526 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1527
1528 * dispextern.h (struct face.stipple):
1529 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1530 (x_bitmap_mask, x_allocate_bitmap_record)
1531 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1532 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1533 (x_create_bitmap_from_xpm_data):
1534 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1535 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1536 (.bitmaps_last):
1537 * xfaces.c (load_pixmap):
1538 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1539 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1540 (.bitmaps_last, struct x_output.icon_bitmap):
1541 Use ptrdiff_t, not int, for bitmap indexes.
1542 (x_allocate_bitmap_record): Check for size overflow.
1543 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1544
1545 Use ptrdiff_t, not int, for overlay counts.
1546 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1547 * editfns.c (overlays_around, get_pos_property):
1548 * textprop.c (get_char_property_and_overlay):
1549 * xdisp.c (next_overlay_change, note_mouse_highlight):
1550 * xfaces.c (face_at_buffer_position):
1551 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1552 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1553 (Fnext_overlay_change, Fprevious_overlay_change)
1554 (mouse_face_overlay_overlaps, Foverlays_in):
1555 Use ptrdiff_t, not int, for sizes.
1556 (overlays_at, overlays_in): Check for size-calculation overflow.
1557
1558 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1559
1560 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1561 (x_session_initialize): Do not assume string length fits in int.
1562
1563 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1564 This is unlikely, but can occur if DPI is outlandish.
1565
1566 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1567 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1568
1569 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1570 * xrdb.c (magic_file_p, search_magic_path):
1571 Omit last arg SUFFIX; it was always 0. All callers changed.
1572 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1573
1574 * xfont.c (xfont_match): Avoid need for strlen.
1575
1576 * xfns.c: Don't assume strlen fits in int.
1577 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1578
1579 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1580 not unsigned long, as we prefer signed integers. All callers changed.
1581 Detect integer overflow in repeat count.
1582 (message_dolog): Don't assume print length fits in 39 bytes.
1583 (display_mode_element): Don't assume strlen fits in int.
1584
1585 * termcap.c: Don't assume sizes fit in int and never overflow.
1586 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1587 (gobble_line): Check for size-calculation overflow.
1588
1589 * minibuf.c (Fread_buffer):
1590 * lread.c (intern, intern_c_string):
1591 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1592 Don't assume string length fits in int.
1593
1594 * keyboard.c (parse_tool_bar_item):
1595 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1596
1597 * font.c: Don't assume string length fits in int.
1598 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1599 Use ptrdiff_t, not int.
1600 (font_intern_prop): Don't assume string length fits in int.
1601 Don't assume integer property fits in fixnum.
1602 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1603
1604 * filelock.c: Fix some buffer overrun and integer overflow issues.
1605 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1606 Reformulate so as not to need the command string.
1607 Invoke gzip -cd rather than gunzip, as it's more portable.
1608 (lock_info_type, lock_file_1, lock_file):
1609 Don't assume pid_t and time_t fit in unsigned long.
1610 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1611 (current_lock_owner): Prefer signed type for sizes.
1612 Use memcpy, not strncpy, where memcpy is what is really wanted.
1613 Don't assume (via atoi) that time_t and pid_t fit in int.
1614 Check for time_t and/or pid_t out of range, e.g., via a network share.
1615 Don't alloca where an auto var works fine.
1616
1617 * fileio.c: Fix some integer overflow issues.
1618 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1619 Don't assume string length fits in int.
1620 (directory_file_name): Don't assume string length fits in long.
1621 (make_temp_name): Don't assume pid fits in int, or that its print
1622 length is less than 20.
1623
1624 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1625
1626 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1627
1628 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1629
1630 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1631 We prefer signed integers, even for size calculations.
1632
1633 * emacs.c: Don't assume string length fits in 'int'.
1634 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1635 (main): Don't invoke strlen when not needed.
1636
1637 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1638 (XD_DEBUG_MESSAGE): Don't waste a byte.
1639
1640 * callproc.c (getenv_internal_1, getenv_internal)
1641 (Fgetenv_internal):
1642 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1643
1644 * lread.c (invalid_syntax): Omit length argument.
1645 All uses changed. This doesn't fix a bug, but it simplifies the
1646 code away from its former Hollerith-constant appearance, and it's
1647 one less 'int' to worry about when looking at integer-overflow issues.
1648 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1649
1650 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1651 This didn't break anything, but it didn't help either.
1652 It's confusing to put a bogus integer in a place where the actual
1653 value does not matter.
1654 (LIST_END_P): Remove unused macro and its bogus comment.
1655 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1656
1657 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1658 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1659 implementation.
1660 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1661 We prefer signed types, and the value cannot exceed the EMACS_INT
1662 range anyway (because otherwise the length would not be representable).
1663 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1664 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1665 This avoids a GCC warning when WIDE_EMACS_INT.
1666
1667 * indent.c (sane_tab_width): New function.
1668 (current_column, scan_for_column, Findent_to, position_indentation)
1669 (compute_motion): Use it. This is just for clarity.
1670 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1671
1672 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1673
1674 * lisp.h (lint_assume): New macro.
1675 * composite.c (composition_gstring_put_cache):
1676 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1677
1678 * editfns.c, insdel.c:
1679 Omit unnecessary forward decls, to simplify future changes.
1680
1681 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1682
1683 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1684
1685 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1686 Use much-faster test for byte-length change.
1687 Don't assume string byte-length fits in 'int'.
1688 Check that character arg fits in 'int'.
1689 (mapcar1): Declare byte as byte, for clarity.
1690
1691 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1692
1693 * fns.c (concat): Catch string overflow earlier.
1694 Do not rely on integer wraparound.
1695
1696 * dispextern.h (struct it.overlay_strings_charpos)
1697 (struct it.selective): Now EMACS_INT, not int.
1698 * xdisp.c (forward_to_next_line_start)
1699 (back_to_previous_visible_line_start)
1700 (reseat_at_next_visible_line_start, next_element_from_buffer):
1701 Don't arbitrarily truncate the value of 'selective' to int.
1702
1703 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1704
1705 * composite.c: Don't truncate sizes to 'int'.
1706 (composition_gstring_p, composition_reseat_it)
1707 (composition_adjust_point): Use EMACS_INT, not int.
1708 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1709 not EMACS_UINT, for indexes.
1710
1711 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1712
1713 * buffer.c: Include <verify.h>.
1714 (struct sortvec.priority, struct sortstr.priority):
1715 Now EMACS_INT, not int.
1716 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1717 (struct sortstr.size, record_overlay_string)
1718 (struct sortstrlist.size, struct sortlist.used):
1719 Don't truncate size to int.
1720 (record_overlay_string): Check for size-calculation overflow.
1721 (init_buffer_once): Check at compile-time, not run-time.
1722
1723 2011-06-22 Jim Meyering <meyering@redhat.com>
1724
1725 Don't leak an XBM-image-sized buffer
1726 * image.c (xbm_load): Free the image buffer after using it.
1727
1728 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1729
1730 Port to Sun C.
1731 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1732 that Sun C diagnosed.
1733 * fns.c (secure_hash): Fix pointer signedness issue.
1734 * intervals.c (static_offset_intervals): New function.
1735 (offset_intervals): Use it.
1736
1737 2011-06-21 Leo Liu <sdl.web@gmail.com>
1738
1739 * deps.mk (fns.o):
1740 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1741 sha512.h.
1742
1743 * fns.c (secure_hash): Rename from crypto_hash_function and change
1744 the first arg to accept symbols.
1745 (Fsecure_hash): New primitive.
1746 (syms_of_fns): New symbols.
1747
1748 2011-06-20 Deniz Dogan <deniz@dogan.se>
1749
1750 * process.c (Fset_process_buffer): Clarify return value in
1751 docstring.
1752
1753 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1754
1755 * dispnew.c (add_window_display_history): Use BVAR.
1756
1757 * xdisp.c (debug_method_add): Use BVAR.
1758 (check_window_end, dump_glyph_matrix, dump_glyph)
1759 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1760
1761 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1762 Likewise.
1763
1764 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1765 check till after the cache is created in init_frame_faces.
1766
1767 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1768
1769 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1770
1771 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1772
1773 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1774 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1775 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1776
1777 Improve buffer-overflow checking (Bug#8873).
1778 * fileio.c (Finsert_file_contents):
1779 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1780 Remove the old (too-loose) buffer overflow checks.
1781 They weren't needed, since make_gap checks for buffer overflow.
1782 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1783 The old code merely checked for Emacs fixnum overflow, and relied
1784 on undefined (wraparound) behavior. The new code avoids undefined
1785 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1786
1787 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1788 Tune. Don't use wider integers than needed. Don't use alloca.
1789 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1790
1791 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1792
1793 * insdel.c, lisp.h (buffer_overflow): New function.
1794 (insert_from_buffer_1, replace_range, replace_range_2):
1795 * insdel.c (make_gap_larger):
1796 * editfns.c (Finsert_char):
1797 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1798
1799 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1800
1801 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1802
1803 Integer overflow and signedness fixes (Bug#8873).
1804
1805 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1806 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1807
1808 * fileio.c: Don't assume EMACS_INT fits in off_t.
1809 (emacs_lseek): New static function.
1810 (Finsert_file_contents, Fwrite_region): Use it.
1811 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1812
1813 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1814
1815 * fns.c: Don't overflow int when computing a list length.
1816 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1817 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1818 truncation on 64-bit hosts. Check for QUIT every
1819 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1820 faster and is responsive enough.
1821 (Flength): Report an error instead of overflowing an integer.
1822 (Fsafe_length): Return a float if the value is not representable
1823 as a fixnum. This shouldn't happen except in contrived situations.
1824 (Fnthcdr, Fsort): Don't assume list length fits in int.
1825 (Fcopy_sequence): Don't assume vector length fits in int.
1826
1827 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1828 (header_size, word_size): New constants.
1829 (allocate_vectorlike): Don't check size overflow here.
1830 (allocate_vector): Check it here instead, since this is the only
1831 caller of allocate_vectorlike that could cause overflow.
1832 Check that the new vector's length is representable as a fixnum.
1833
1834 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1835 The previous code was bogus. For example, next_almost_prime (32)
1836 returned 39, which is undesirable as it is a multiple of 3; and
1837 next_almost_prime (24) returned 25, which is a multiple of 5 so
1838 why was the code bothering to check for multiples of 7?
1839
1840 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1841
1842 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1843
1844 Variadic C functions now count arguments with ptrdiff_t.
1845 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1846 Back then I didn't know that the Emacs coding style prefers signed int.
1847 Also, in the meantime I found a few more instances where arguments
1848 were being counted with int, which may truncate counts on 64-bit
1849 machines, or EMACS_INT, which may be unnecessarily wide.
1850 * lisp.h (struct Lisp_Subr.function.aMANY)
1851 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1852 Arg counts are now ptrdiff_t, not size_t.
1853 All variadic functions and their callers changed accordingly.
1854 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1855 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1856 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1857 * callint.c (Fcall_interactively): Check arg count for overflow,
1858 to avoid potential buffer overrun. Use signed char, not 'int',
1859 for 'varies' array, so that we needn't bother to check its size
1860 calculation for overflow.
1861 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1862 * eval.c (apply_lambda):
1863 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1864 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1865 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1866
1867 * callint.c (Fcall_interactively): Don't use index var as event count.
1868
1869 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1870 * mem-limits.h (SIZE): Remove; no longer used.
1871
1872 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1873
1874 Remove unnecessary casts.
1875 * xterm.c (x_term_init):
1876 * xfns.c (x_set_border_pixel):
1877 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1878 These aren't needed now that we assume ANSI C.
1879
1880 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1881 It's more likely to cause problems (due to unsigned overflow)
1882 than to cure them.
1883
1884 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1885
1886 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1887
1888 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1889
1890 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1891
1892 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1893
1894 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1895
1896 GLYPH_CODE_FACE returns EMACS_INT, not int.
1897 * dispextern.h (merge_faces):
1898 * xfaces.c (merge_faces):
1899 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1900 Don't assume EMACS_INT fits in int.
1901
1902 * character.h (CHAR_VALID_P): Remove unused parameter.
1903 * fontset.c, lisp.h, xdisp.c: All uses changed.
1904
1905 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1906
1907 * fns.c (concat): Minor tuning based on overflow analysis.
1908 This doesn't fix any bugs. Use int to hold character, instead
1909 of constantly refetching from Emacs object. Use XFASTINT, not
1910 XINT, for value known to be a character. Don't bother comparing
1911 a single byte to 0400, as it's always less.
1912
1913 * floatfns.c (Fexpt):
1914 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1915
1916 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1917 for characters.
1918
1919 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1920
1921 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1922 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1923 incorrectly succeed when S was a string, because 4294967386 was
1924 truncated before it was used.
1925
1926 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1927 Otherwise, an out-of-range integer could cause undefined behavior
1928 on a 64-bit host.
1929
1930 * composite.c: Use int, not EMACS_INT, for characters.
1931 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1932 EMACS_INT, for values that are known to be in character range.
1933 This doesn't fix any bugs but is the usual style inside Emacs and
1934 may generate better code on 32-bit machines.
1935
1936 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1937 This is for reasons similar to the recent CHAR_STRING fix.
1938 * charset.c (Fencode_char): Check that character arg is actually
1939 a character. Pass an int to ENCODE_CHAR.
1940 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1941 wider than 'int', as a compile-time check to prevent future regressions
1942 in this area.
1943
1944 * character.c (char_string): Remove unnecessary casts.
1945
1946 Make sure a 64-bit char is never passed to CHAR_STRING.
1947 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1948 by silently ignoring the top 32 bits, allowing some values
1949 that were far too large to be valid characters.
1950 * character.h: Include <verify.h>.
1951 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1952 arguments are no wider than unsigned, as a compile-time check
1953 to prevent future regressions in this area.
1954 * data.c (Faset):
1955 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1956 (Fsubst_char_in_region):
1957 * fns.c (concat):
1958 * xdisp.c (decode_mode_spec_coding):
1959 Adjust to CHAR_STRING's new requirement.
1960 * editfns.c (Finsert_char, Fsubst_char_in_region):
1961 * fns.c (concat): Check that character args are actually
1962 characters. Without this test, these functions did the wrong
1963 thing with wildly out-of-range values on 64-bit hosts.
1964
1965 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1966 These casts should not be needed on 32-bit hosts, either.
1967 * keyboard.c (read_char):
1968 * lread.c (Fload): Remove casts to unsigned.
1969
1970 * lisp.h (UNSIGNED_CMP): New macro.
1971 This fixes comparison bugs on 64-bit hosts.
1972 (ASCII_CHAR_P): Use it.
1973 * casefiddle.c (casify_object):
1974 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
1975 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1976 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1977 * dispextern.h (FACE_FROM_ID):
1978 * keyboard.c (read_char): Use UNSIGNED_CMP.
1979
1980 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1981 not to EMACS_INT, to avoid GCC warning.
1982
1983 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1984
1985 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1986 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1987 isn't needed on 32-bit machines.
1988
1989 * buffer.c (Fgenerate_new_buffer_name):
1990 Use EMACS_INT for count, not int.
1991 (advance_to_char_boundary): Return EMACS_INT, not int.
1992
1993 * data.c (Qcompiled_function): Now static.
1994
1995 * window.c (window_body_lines): Now static.
1996
1997 * image.c (gif_load): Rename local to avoid shadowing.
1998
1999 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2000 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2001 * alloc.c (make_save_value): Integer argument is now of type
2002 ptrdiff_t, not int.
2003 (mark_object): Use ptrdiff_t, not int.
2004 * lisp.h (pD): New macro.
2005 * print.c (print_object): Use it.
2006
2007 * alloc.c: Use EMACS_INT, not int, to count objects.
2008 (total_conses, total_markers, total_symbols, total_vector_size)
2009 (total_free_conses, total_free_markers, total_free_symbols)
2010 (total_free_floats, total_floats, total_free_intervals)
2011 (total_intervals, total_strings, total_free_strings):
2012 Now EMACS_INT, not int. All uses changed.
2013 (Fgarbage_collect): Compute overall total using a double, so that
2014 integer overflow is less likely to be a problem. Check for overflow
2015 when converting back to an integer.
2016 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2017 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2018 These were 'int' variables that could overflow on 64-bit hosts;
2019 they were never used, so remove them instead of repairing them.
2020 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2021 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2022 Previously, this ceilinged at INT_MAX, but that doesn't work on
2023 64-bit machines.
2024 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2025
2026 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2027 (allocate_vectorlike): Check for ptrdiff_t overflow.
2028 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2029 when a (possibly-narrower) signed value would do just as well.
2030 We prefer using signed arithmetic, to avoid comparison confusion.
2031
2032 * alloc.c: Catch some string size overflows that we were missing.
2033 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2034 for convenience in STRING_BYTES_MAX.
2035 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2036 The definition here is exact; the one in lisp.h was approximate.
2037 (allocate_string_data): Check for string overflow. This catches
2038 some instances we weren't catching before. Also, it catches
2039 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2040 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2041 and ptrdiff_t and EMACS_INT are both 64 bits.
2042
2043 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2044 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2045 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
2046
2047 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2048
2049 * alloc.c (Fmake_string): Check for out-of-range init.
2050
2051 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2052
2053 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2054
2055 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2056
2057 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2058 xg_get_default_scrollbar_width.
2059
2060 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2061 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2062 (style_changed_cb): Call update_theme_scrollbar_width and call
2063 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2064 all frames (Bug#8505).
2065 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2066 Call gtk_window_set_resizable if HAVE_GTK3.
2067 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2068 and height if HAVE_GTK3 (Bug#8505).
2069 (scroll_bar_width_for_theme): New variable.
2070 (update_theme_scrollbar_width): New function.
2071 (xg_get_default_scrollbar_width): Move code to
2072 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2073 (xg_initialize): Call update_theme_scrollbar_width.
2074
2075 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2076
2077 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2078
2079 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2080
2081 * frame.c (make_frame): Call other_buffer_safely instead of
2082 other_buffer.
2083
2084 * window.c (temp_output_buffer_show): Call display_buffer with
2085 second argument Vtemp_buffer_show_specifiers and reset latter
2086 immediately after the call.
2087 (Vtemp_buffer_show_specifiers): New variable.
2088 (auto_window_vscroll_p, next_screen_context_lines)
2089 (Vscroll_preserve_screen_position): Remove leading asterisks from
2090 doc-strings.
2091
2092 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2093
2094 Fix minor problems found by GCC 4.6.0 static checking.
2095 * buffer.c (Qclone_number): Remove for now, as it's unused.
2096 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2097 (record_buffer): Remove unused local.
2098 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2099 (set_frame_buffer_list): Remove; unused.
2100 * frame.h (other_visible_frames): Remove decl.
2101 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2102 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2103 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2104 if HAVE_GPM.
2105 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2106 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2107 Define only if HAVE_GPM.
2108 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2109 (update_hints_inhibit): Remove; never set. All uses removed.
2110 * widgetprv.h (emacsFrameClassRec): Remove decl.
2111 * window.c (delete_deletable_window): Now returns void, since it
2112 wasn't returning anything.
2113 (compare_window_configurations): Remove unused locals.
2114 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2115 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2116 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2117 the same widths as pointers. This follows up on the 2011-05-06 patch.
2118 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2119 * xterm.h: Likewise.
2120 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2121
2122 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2123
2124 * makefile.w32-in: Update dependencies.
2125 (LISP_H): Add lib/intprops.h.
2126
2127 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2128
2129 * image.c (gif_load): Add animation frame delay to the metadata.
2130 (syms_of_image): Use DEFSYM. New symbol `delay'.
2131
2132 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2133
2134 * window.c (delete_deletable_window): Re-add.
2135 (Fset_window_configuration): Rewrite to handle dead buffers and
2136 consequently deletable windows.
2137 (window_tree, Fwindow_tree): Remove. Supply functionality in
2138 window.el.
2139 (compare_window_configurations): Simplify code.
2140
2141 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2142
2143 * image.c (imagemagick_load_image): Fix type mismatch.
2144 (Fimagemagick_types): Likewise.
2145
2146 * window.h (replace_buffer_in_windows): Declare.
2147
2148 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2149
2150 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2151 Qclone_number. Remove external declaration of Qdelete_window.
2152 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2153 code.
2154 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
2155 Qbuffer_list_update_hook if allowed.
2156 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2157 buffer list implementation.
2158 (other_buffer_safely): New function.
2159 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2160 calls to replace_buffer_in_windows and
2161 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2162 if allowed.
2163 (record_buffer): Inhibit quitting and rewrite using quittable
2164 functions. Run Qbuffer_list_update_hook if allowed.
2165 (Frecord_buffer, Funrecord_buffer): New functions.
2166 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
2167 switch-to-buffer to window.el.
2168 (bury-buffer): Move to window.el.
2169 (Vbuffer_list_update_hook): New variable.
2170
2171 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2172 section.
2173
2174 * window.h (resize_frame_windows): Move up in code.
2175 (Fwindow_frame): Remove EXFUN.
2176 (replace_buffer_in_all_windows): Remove prototype.
2177 (replace_buffer_in_windows_safely): Add prototype.
2178
2179 * window.c: Declare Qdelete_window static again. Move down
2180 declaration of select_count.
2181 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2182 (Fother_window): Move to window.el.
2183 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2184 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2185 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2186 window.el.
2187 (replace_buffer_in_windows): Implement by calling
2188 Qreplace_buffer_in_windows.
2189 (replace_buffer_in_all_windows): Remove with some functionality
2190 moved into replace_buffer_in_windows_safely.
2191 (replace_buffer_in_windows_safely): New function.
2192 (select_window_norecord, select_frame_norecord): Move in front
2193 of run_window_configuration_change_hook. Remove now obsolete
2194 declarations.
2195 (Fset_window_buffer): Rewrite doc-string. Call
2196 Qrecord_window_buffer.
2197 (keys_of_window): Move binding for other-window to window.el.
2198
2199 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2200
2201 * dispextern.h (struct image): Replace data member, whose int_val
2202 and ptr_val fields were not used by anything, with a single
2203 lisp_val object.
2204
2205 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2206 (gif_clear_image, gif_load, imagemagick_load_image)
2207 (gs_clear_image, gs_load): Callers changed.
2208
2209 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2210
2211 * buffer.h: Include <time.h>, for time_t.
2212 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2213
2214 Fix minor problems found by static checking.
2215
2216 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2217
2218 Make identifiers static if they are not used in other modules.
2219 * data.c (Qcompiled_function, Qframe, Qvector):
2220 * image.c (QimageMagick, Qsvg):
2221 * minibuf.c (Qmetadata):
2222 * window.c (resize_window_check, resize_root_window): Now static.
2223 * window.h (resize_window_check, resize_root_window): Remove decls.
2224
2225 * window.c (window_deletion_count, delete_deletable_window):
2226 Remove; unused.
2227 (window_body_lines): Now static.
2228 (Fdelete_other_windows_internal): Mark vars as initialized.
2229 Make sure 'resize_failed' is initialized.
2230 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2231 (resize_window_apply): Remove unused local.
2232 * window.h (delete_deletable_window): Remove decl.
2233
2234 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2235 (imagemagick_load_image): Fix pointer signedness problem by changing
2236 last arg from unsigned char * to char *. All uses changed.
2237 Also, fix a local for similar reasons.
2238 Remove unused locals. Remove locals to avoid shadowing.
2239 (fn_rsvg_handle_free): Remove; unused.
2240 (svg_load, svg_load_image): Fix pointer signedness problem.
2241 (imagemagick_load_image): Don't use garbage pointer image_wand.
2242
2243 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2244
2245 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2246
2247 * image.c (gif_load): Fix omitted cast error introduced by
2248 2011-06-06 change.
2249
2250 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2251
2252 * window.h (resize_proportionally, orig_total_lines)
2253 (orig_top_line): Remove from window structure.
2254 (set_window_height, set_window_width, change_window_heights)
2255 (Fdelete_window): Remove prototypes.
2256 (resize_frame_windows): Remove duplicate declaration.
2257
2258 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2259
2260 * window.h (resize_frame_windows, resize_window_check)
2261 (delete_deletable_window, resize_root_window)
2262 (resize_frame_windows): Declare prototypes.
2263
2264 * window.c (resize_window_apply): Make definition be "static" to
2265 match the prototype.
2266
2267 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2268
2269 * window.c: Remove declarations of Qwindow_size_fixed,
2270 window_min_size_1, window_min_size_2, window_min_size,
2271 size_window, window_fixed_size_p, enlarge_window, delete_window.
2272 Remove static from declaration of Qdelete_window, it's
2273 temporarily needed by Fbury_buffer.
2274 (replace_window): Don't assign orig_top_line and
2275 orig_total_lines.
2276 (Fdelete_window, delete_window): Remove. Window deletion is
2277 handled by window.el.
2278 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
2279 Fdelete_window calls with calls to Qdelete_window.
2280 (Fdelete_other_windows): Remove. Deleting other windows is
2281 handled by window.el.
2282 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2283 handled in window.el.
2284 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2285 Window minimum sizes are handled in window.el.
2286 (shrink_windows, size_window, set_window_height)
2287 (set_window_width, change_window_heights, window_height)
2288 (window_width, CURBEG, CURSIZE, enlarge_window)
2289 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2290 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2291 handled in window.el.
2292 (make_dummy_parent): Rename to make_parent_window and give it a
2293 second argument horflag.
2294 (make_window): Don't set resize_proportionally any more.
2295 (Fsplit_window): Remove. Windows are split in window.el.
2296 (save_restore_action, save_restore_orig_size)
2297 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2298 Resize mini windows in window.el.
2299 (grow_mini_window, shrink_mini_window): Implement by calling
2300 Qresize_root_window_vertically, resize_window_check and
2301 resize_window_apply.
2302 (saved_window, Fset_window_configuration, save_window_save): Do
2303 not handle orig_top_line, orig_total_lines, and
2304 resize_proportionally.
2305 (window_min_height, window_min_width): Move to window.el.
2306 (keys_of_window): Move bindings for delete-other-windows,
2307 split-window, delete-window and enlarge-window to window.el.
2308
2309 * buffer.c: Temporarily extern Qdelete_window.
2310 (Fbury_buffer): Temporarily call Qdelete_window instead of
2311 Fdelete_window (Fbury_buffer will move to window.el soon).
2312
2313 * frame.c (set_menu_bar_lines_1): Remove code handling
2314 orig_top_line and orig_total_lines.
2315
2316 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2317 set_window_height but set heights directly.
2318 (change_frame_size_1): Use resize_frame_windows.
2319
2320 * xdisp.c (init_xdisp): Don't use set_window_height but set
2321 heights directly.
2322
2323 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
2324 resize_frame_windows instead of change_window_heights and run
2325 run_window_configuration_change_hook.
2326
2327 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2328 instead of change_window_heights and run
2329 run_window_configuration_change_hook.
2330
2331 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2332
2333 * window.c (replace_window): Rename second argument REPLACEMENT to
2334 NEW. New third argument SETFLAG. Rewrite.
2335 (delete_window, make_dummy_parent): Call replace_window with
2336 third argument 1.
2337 (window_list_1): Move down in code.
2338 (run_window_configuration_change_hook): Move set_buffer part
2339 before select_frame_norecord part in order to unwind correctly.
2340 Rename count1 to count.
2341 (recombine_windows, delete_deletable_window, resize_root_window)
2342 (Fdelete_other_windows_internal)
2343 (Frun_window_configuration_change_hook, make_parent_window)
2344 (resize_window_check, resize_window_apply, Fresize_window_apply)
2345 (resize_frame_windows, Fsplit_window_internal)
2346 (Fdelete_window_internal, Fresize_mini_window_internal): New
2347 functions.
2348 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2349
2350 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2351
2352 * window.h (window): Add some new members to window structure -
2353 normal_lines, normal_cols, new_total, new_normal, clone_number,
2354 splits, nest, prev_buffers, next_buffers.
2355 (WINDOW_TOTAL_SIZE): Move here from window.c.
2356 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2357
2358 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2359 Remove.
2360 (make_dummy_parent): Set new members of windows structure.
2361 (make_window): Move down in code. Handle new members of window
2362 structure.
2363 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2364 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2365 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2366 (Fset_window_prev_buffers, Fwindow_next_buffers)
2367 (Fset_window_next_buffers, Fset_window_clone_number): New
2368 functions.
2369 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2370 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2371 Doc-string fixes.
2372 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2373 Argument WINDOW can be now internal window too.
2374 (Fwindow_use_time): Move up in code.
2375 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2376 Rewrite doc-string.
2377 (Fset_window_configuration, saved_window)
2378 (Fcurrent_window_configuration, save_window_save): Handle new
2379 members of window structure.
2380 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2381 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2382 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2383 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2384 Qget_mru_window, Qresize_root_window,
2385 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2386 Qauto_buffer_name; staticpro them.
2387
2388 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2389
2390 * window.c (Fwindow_total_size, Fwindow_left_column)
2391 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2392 (Fwindow_list_1): New functions.
2393 (window_box_text_cols): Replace with window_body_cols.
2394 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2395 window_body_cols instead of window_box_text_cols.
2396 (delete_window, Fset_window_configuration): Call
2397 delete_all_subwindows with window as argument.
2398 (delete_all_subwindows): Take a window as argument and not a
2399 structure. Rewrite.
2400 (window_loop): Remove handling of GET_LRU_WINDOW and
2401 GET_LARGEST_WINDOW.
2402 (Fget_lru_window, Fget_largest_window): Move to window.el.
2403
2404 * window.h: Extern window_body_cols instead of
2405 window_box_text_cols. delete_all_subwindows now takes a
2406 Lisp_Object as argument.
2407
2408 * indent.c (compute_motion, Fcompute_motion): Use
2409 window_body_cols instead of window_box_text_cols.
2410
2411 * frame.c (delete_frame): Call delete_all_subwindows with root
2412 window as argument.
2413
2414 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2415
2416 * fns.c (Fputhash): Document return value.
2417
2418 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2419
2420 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2421
2422 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2423
2424 Cons<->int and similar integer overflow fixes (Bug#8794).
2425
2426 Check for overflow when converting integer to cons and back.
2427 * charset.c (Fdefine_charset_internal, Fdecode_char):
2428 Use cons_to_unsigned to catch overflow.
2429 (Fencode_char): Use INTEGER_TO_CONS.
2430 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2431 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2432 * data.c (long_to_cons, cons_to_long): Remove.
2433 (cons_to_unsigned, cons_to_signed): New functions.
2434 These signal an error for invalid or out-of-range values.
2435 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2436 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2437 * font.c (Ffont_variation_glyphs):
2438 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2439 * lisp.h: Include <intprops.h>.
2440 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2441 (cons_to_signed, cons_to_unsigned): New decls.
2442 (long_to_cons, cons_to_long): Remove decls.
2443 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2444 (Fprimitive_undo): Use CONS_TO_INTEGER.
2445 * xfns.c (Fx_window_property): Likewise.
2446 * xselect.c: Include <limits.h>.
2447 (x_own_selection, selection_data_to_lisp_data):
2448 Use INTEGER_TO_CONS.
2449 (x_handle_selection_request, x_handle_selection_clear)
2450 (x_get_foreign_selection, Fx_disown_selection_internal)
2451 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2452 (lisp_data_to_selection_data): Use cons_to_unsigned.
2453 (x_fill_property_data): Use cons_to_signed.
2454 Report values out of range.
2455
2456 Check for buffer and string overflow more precisely.
2457 * buffer.h (BUF_BYTES_MAX): New macro.
2458 * lisp.h (STRING_BYTES_MAX): New macro.
2459 * alloc.c (Fmake_string):
2460 * character.c (string_escape_byte8):
2461 * coding.c (coding_alloc_by_realloc):
2462 * doprnt.c (doprnt):
2463 * editfns.c (Fformat):
2464 * eval.c (verror):
2465 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2466 since they may not be the same number.
2467 * editfns.c (Finsert_char):
2468 * fileio.c (Finsert_file_contents):
2469 Likewise for BUF_BYTES_MAX.
2470
2471 * image.c: Use ptrdiff_t, not int, for sizes.
2472 (slurp_file): Switch from int to ptrdiff_t.
2473 All uses changed.
2474 (slurp_file): Check that file size fits in both size_t (for
2475 malloc) and ptrdiff_t (for sanity and safety).
2476
2477 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2478 if b->modtime has its maximal value.
2479
2480 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2481
2482 Don't assume time_t can fit into int.
2483 * buffer.h (struct buffer.modtime): Now time_t, not int.
2484 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2485 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2486
2487 Minor fixes for signed vs unsigned integers.
2488 * character.h (MAYBE_UNIFY_CHAR):
2489 * charset.c (maybe_unify_char):
2490 * keyboard.c (read_char, reorder_modifiers):
2491 XINT -> XFASTINT, since the integer must be nonnegative.
2492 * ftfont.c (ftfont_spec_pattern):
2493 * keymap.c (access_keymap, silly_event_symbol_error):
2494 XUINT -> XFASTINT, since the integer must be nonnegative.
2495 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2496 since it makes no difference and we prefer signed.
2497 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2498 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2499 nonnegative.
2500
2501 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2502
2503 * window.h (Fwindow_frame): Declare.
2504
2505 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2506
2507 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2508 (SPARE_MEMORY): Always define.
2509 (LARGE_REQUEST): Remove.
2510 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2511
2512 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2513
2514 * lisp.h: Move EXFUNS for Fframe_root_window,
2515 Fframe_first_window and Fset_frame_selected_window to window.h.
2516
2517 * window.h: Move EXFUNS for Fframe_root_window,
2518 Fframe_first_window and Fset_frame_selected_window here from
2519 lisp.h.
2520
2521 * frame.c (Fwindow_frame, Fframe_first_window)
2522 (Fframe_root_window, Fframe_selected_window)
2523 (Fset_frame_selected_window): Move to window.c.
2524 (Factive_minibuffer_window): Move to minibuf.c.
2525 (Fother_visible_frames_p): New function.
2526
2527 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2528
2529 * window.c (decode_window, decode_any_window): Move up in code.
2530 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2531 (inhibit_frame_unsplittable): Remove unused variable.
2532 (Fwindow_buffer): Move up and rewrite doc-string.
2533 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2534 (Fwindow_prev): New functions.
2535 (Fwindow_frame): Move here from frame.c. Accept any window as
2536 argument.
2537 (Fframe_root_window, Fframe_first_window)
2538 (Fframe_selected_window): Move here from frame.c. Accept frame
2539 or arbitrary window as argument. Update doc-strings.
2540 (Fminibuffer_window): Move up in code.
2541 (Fwindow_minibuffer_p): Move up in code and simplify.
2542 (Fset_frame_selected_window): Move here from frame.c.
2543 Marginal rewrite.
2544 (Fselected_window, select_window, Fselect_window): Move up in
2545 code. Minor doc-string fixes.
2546
2547 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2548
2549 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2550 Do not assume that spare memory exists; that assumption is valid
2551 only if SYSTEM_MALLOC.
2552 (LARGE_REQUEST): New macro, so that the issue of large requests
2553 is separated from the issue of spare memory.
2554
2555 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2556
2557 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2558 format. (Bug#8806)
2559
2560 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2561
2562 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2563 before statements.
2564
2565 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2566
2567 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2568
2569 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2570
2571 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2572 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2573
2574 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2575
2576 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2577
2578 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2579
2580 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2581 (x_clipboard_manager_save): Add return value.
2582 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2583 New error handlers.
2584 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2585 Obey Vx_select_enable_clipboard_manager. Catch errors in
2586 x_clipboard_manager_save (Bug#8779).
2587 (Vx_select_enable_clipboard_manager): New variable.
2588 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2589
2590 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2591
2592 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2593
2594 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2595
2596 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2597 in the current matrix if keep_current_p is non-zero.
2598
2599 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2600
2601 * bidi.c (bidi_level_of_next_char): Fix last change.
2602
2603 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2604
2605 Support bidi reordering of text covered by display properties.
2606
2607 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2608 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2609 (bidi_cache_search, bidi_cache_iterator_state)
2610 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2611 (bidi_level_of_next_char, bidi_move_to_visually_next):
2612 Support character positions inside a run of characters covered by a
2613 display string.
2614 (bidi_paragraph_init, bidi_resolve_explicit_1)
2615 (bidi_level_of_next_char): Call bidi_fetch_char and
2616 bidi_fetch_char_advance instead of FETCH_CHAR and
2617 FETCH_CHAR_ADVANCE.
2618 (bidi_init_it): Initialize new members.
2619 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2620 definitions.
2621 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2622 instead of using explicit *_CHAR codes.
2623 (bidi_resolve_explicit, bidi_resolve_weak):
2624 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2625 bidirectional text is supported only in multibyte buffers.
2626 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2627 it to initialize the frame_window_p member of struct bidi_it.
2628 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2629 (bidi_resolve_explicit, bidi_resolve_weak)
2630 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2631 bidi_it->nchars is non-positive.
2632 (bidi_level_of_next_char): Don't try to lookup the cache for the
2633 next/previous character if nothing is cached there yet, or if we
2634 were just reseat()'ed to a new position.
2635
2636 * xdisp.c (set_cursor_from_row): Set start and stop points
2637 according to the row's direction when priming the loop that looks
2638 for the glyph on which to display cursor.
2639 (single_display_spec_intangible_p): Function deleted.
2640 (display_prop_intangible_p): Reimplement to call
2641 handle_display_spec instead of single_display_spec_intangible_p.
2642 Accept 3 additional arguments needed by handle_display_spec.
2643 This fixes incorrect cursor motion across display property with complex
2644 values: lists, `(when COND...)' forms, etc.
2645 (single_display_spec_string_p): Support property values that are
2646 lists with the argument STRING its top-level element.
2647 (display_prop_string_p): Fix the condition for processing a
2648 property that is a list to be consistent with handle_display_spec.
2649 (handle_display_spec): New function, refactored from the
2650 last portion of handle_display_prop.
2651 (compute_display_string_pos): Accept additional argument
2652 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2653 value of a `display' property is a "replacing spec".
2654 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2655 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2656 the display property, but just return a value indicating whether
2657 the display property will replace the characters it covers.
2658 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2659 frame_window_p members of struct bidi_it.
2660 (compute_display_string_pos, compute_display_string_end):
2661 New functions.
2662 (push_it): Accept second argument POSITION, where pop_it should
2663 jump to continue iteration.
2664 (reseat_1): Initialize bidi_it.disp_pos.
2665
2666 * keyboard.c (adjust_point_for_property): Adjust the call to
2667 display_prop_intangible_p to its new signature.
2668
2669 * dispextern.h (struct bidi_it): New member frame_window_p.
2670 (bidi_init_it): Update prototypes.
2671 (display_prop_intangible_p): Update prototype.
2672 (compute_display_string_pos, compute_display_string_end):
2673 Declare prototypes.
2674 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2675 EMACS_INT.
2676
2677 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2678
2679 Malloc failure behavior now depends on size of allocation.
2680 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2681 * lisp.h: Change signatures accordingly.
2682 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2683 All callers changed. (Bug#8762)
2684
2685 * gnutls.c: Use Emacs's memory allocators.
2686 Without this change, the gnutls library would invoke malloc etc.
2687 directly, which causes problems on non-SYNC_INPUT hosts, and which
2688 runs afoul of improving memory_full behavior. (Bug#8761)
2689 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2690 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2691 xfree instead of the default malloc, realloc, free.
2692 (Fgnutls_boot): No need to check for memory allocation failure,
2693 since xmalloc does that for us.
2694
2695 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2696 * category.c (hash_get_category_set):
2697 * ccl.c (ccl_driver):
2698 * charset.c (Fdefine_charset_internal):
2699 * charset.h (struct charset.hash_index):
2700 * composite.c (get_composition_id, gstring_lookup_cache)
2701 (composition_gstring_put_cache):
2702 * composite.h (struct composition.hash_index):
2703 * dispextern.h (struct image.hash):
2704 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2705 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2706 (hashfn_equal, hashfn_user_defined, make_hash_table)
2707 (maybe_resize_hash_table, hash_lookup, hash_put)
2708 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2709 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2710 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2711 * image.c (make_image, search_image_cache, lookup_image)
2712 (xpm_put_color_table_h):
2713 * lisp.h (struct Lisp_Hash_Table):
2714 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2715 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2716 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2717 * alloc.c (allocate_vectorlike):
2718 Check for overflow in vector size calculations.
2719 * ccl.c (ccl_driver):
2720 Check for overflow when converting EMACS_INT to int.
2721 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2722 need to be updated by these changes.
2723 * fns.c (make_hash_table, maybe_resize_hash_table):
2724 Check for integer overflow with large hash tables.
2725 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2726 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2727 (SXHASH_REDUCE): New macro.
2728 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2729 Use it instead of discarding useful hash info with large hash values.
2730 (sxhash_float): New function.
2731 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2732 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2733 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2734 Rewrite to use FIXNUM_BITS, as this simplifies things.
2735 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2736 Adjust signatures to match updated version of code.
2737 (consing_since_gc): Now EMACS_INT, since a single hash table can
2738 use more than INT_MAX bytes.
2739
2740 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2741
2742 Make it possible to build with GCC-4.6+ -O2 -flto.
2743
2744 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2745
2746 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2747
2748 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2749 Call minibuffer-inactive-mode.
2750
2751 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2752
2753 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2754 Update dependencies.
2755
2756 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2757
2758 * data.c (init_data): Remove code for UTS, this system is not
2759 supported anymore.
2760
2761 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2762
2763 Don't force ./temacs to start in terminal mode.
2764
2765 * frame.c (make_initial_frame): Initialize faces in all cases, not
2766 only when CANNOT_DUMP is defined.
2767 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2768
2769 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2770
2771 * dispnew.c (add_window_display_history): Use const for the string
2772 pointer. Remove declaration, not needed.
2773
2774 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2775
2776 Use 'inline', not 'INLINE'.
2777 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2778 * alloc.c, fontset.c (INLINE): Remove.
2779 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2780 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2781 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2782 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2783 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2784
2785 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2786
2787 Make it possible to run ./temacs.
2788
2789 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2790 syms_of_callproc does the same thing. Remove test for
2791 "initialized", do it in the caller.
2792 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2793
2794 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2795
2796 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2797 (read_minibuf): Use get_minibuffer.
2798 (syms_of_minibuf): Use DEFSYM.
2799 (Qmetadata): New var.
2800 * data.c (Qbuffer): Don't make it static.
2801 (syms_of_data): Use DEFSYM.
2802
2803 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2804
2805 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2806 (CCL_CODE_MIN): New macro.
2807
2808 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2809
2810 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2811
2812 * eval.c (Qdebug): Now static.
2813 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2814 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2815 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2816
2817 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2818
2819 * image.c: Various fixes to ImageMagick code comments.
2820 (Fimagemagick_types): Doc fix.
2821
2822 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2823
2824 Minor fixes prompted by GCC 4.6.0 warnings.
2825
2826 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2827
2828 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2829 (x_clipboard_manager_save_all): Move extern decl to ...
2830 * xterm.h: ... here, so that it can be checked for consistency.
2831
2832 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2833
2834 * xselect.c (x_clipboard_manager_save_frame)
2835 (x_clipboard_manager_save_all): New functions.
2836 (Fx_clipboard_manager_save): Lisp function deleted.
2837
2838 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2839 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2840
2841 * xterm.h: Update prototype.
2842
2843 2011-05-28 William Xu <william.xwl@gmail.com>
2844
2845 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2846 exiting (Bug#8239).
2847
2848 2011-05-28 Jim Meyering <meyering@redhat.com>
2849
2850 Avoid a sign-extension bug in crypto_hash_function.
2851 * fns.c (to_uchar): Define.
2852 (crypto_hash_function): Use it to convert some newly-signed
2853 variables to unsigned, to avoid sign-extension bugs. For example,
2854 without this change, (md5 "truc") would evaluate to
2855 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2856 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2857 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2858
2859 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2860
2861 Integer overflow fixes.
2862
2863 * dbusbind.c: Serial number integer overflow fixes.
2864 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2865 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2866 to hold a serial number that is too large for a fixnum.
2867 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2868 Check for serial numbers out of range. Decode any serial number
2869 that was so large that it became a float. (Bug#8722)
2870
2871 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2872 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2873 Use XFASTINT rather than XUINT when numbers are nonnegative.
2874 (xd_append_arg, Fdbus_method_return_internal):
2875 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2876 arguments, check that Lisp number is nonnegative, rather than
2877 silently wrapping negative numbers around. (Bug#8722)
2878 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2879 (Bug#8722)
2880
2881 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2882
2883 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2884
2885 ccl: add integer overflow checks
2886 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2887 (IN_INT_RANGE): New macros.
2888 (ccl_driver): Use them to check for integer overflow when
2889 decoding a CCL program. Many of the new checks are whether XINT (x)
2890 fits in int; it doesn't always, on 64-bit hosts. The new version
2891 doesn't catch all possible integer overflows, but it's an
2892 improvement. (Bug#8719)
2893
2894 * alloc.c (make_event_array): Use XINT, not XUINT.
2895 There's no need for unsigned here.
2896
2897 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2898 This follows up to the 2011-05-06 change that substituted uintptr_t
2899 for EMACS_INT. This case wasn't caught back then.
2900
2901 Rework Fformat to avoid integer overflow issues.
2902 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2903 now (part of C89). Include <verify.h>.
2904 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2905 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2906 (Fformat): Avoid the prepass trying to compute sizes; it was only
2907 approximate and thus did not catch overflow reliably. Instead, walk
2908 through the format just once, formatting and computing sizes as we go,
2909 checking for integer overflow at every step, and allocating a larger
2910 buffer as needed. Keep track separately whether the format is
2911 multibyte. Keep only the most-recently calculated precision, rather
2912 than them all. Record whether each argument has been converted to
2913 string. Use EMACS_INT, not int, for byte and char and arg counts.
2914 Support field widths and precisions larger than INT_MAX. Avoid
2915 sprintf's undefined behavior with conversion specifications such as %#d
2916 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2917 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2918 formatting out-of-range floating point numbers with int
2919 formats. (Bug#8668)
2920
2921 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2922
2923 * data.c: Avoid integer truncation in expressions involving floats.
2924 * data.c: Include <intprops.h>.
2925 (arith_driver): When there's an integer overflow in an expression
2926 involving floating point, convert the integers to floating point
2927 so that the resulting value does not suffer from catastrophic
2928 integer truncation. For example, on a 64-bit host (* 4
2929 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2930 Do not rely on undefined behavior after integer overflow.
2931
2932 merge count_size_as_multibyte, parse_str_to_multibyte
2933 * character.c, character.h (count_size_as_multibyte):
2934 Rename from parse_str_to_multibyte; all uses changed.
2935 Check for integer overflow.
2936 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2937 since it's now a duplicate of the other. This is more of
2938 a character than a buffer op, so better that it's in character.c.
2939 * fns.c, print.c: Adjust to above changes.
2940
2941 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2942
2943 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2944
2945 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2946
2947 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2948 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2949 (x_clipboard_manager_save): Now static.
2950 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2951
2952 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2953 (crypto_hash_function): Now static.
2954 Fix pointer signedness problems. Avoid unnecessary initializations.
2955
2956 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2957
2958 * termhooks.h (Vselection_alist): Make it terminal-local.
2959
2960 * terminal.c (create_terminal): Initialize it.
2961
2962 * xselect.c: Support for clipboard managers.
2963 (Vselection_alist): Move to termhooks.h as terminal-local var.
2964 (LOCAL_SELECTION): New macro.
2965 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2966 (symbol_to_x_atom): Remove gratuitous arg.
2967 (x_handle_selection_request, lisp_data_to_selection_data)
2968 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
2969 (x_own_selection, x_get_local_selection, x_convert_selection):
2970 New arg, specifying work frame. Use terminal-local Vselection_alist.
2971 (some_frame_on_display): Delete unused function.
2972 (Fx_own_selection_internal, Fx_get_selection_internal)
2973 (Fx_disown_selection_internal, Fx_selection_owner_p)
2974 (Fx_selection_exists_p): New optional frame arg.
2975 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2976 (x_handle_selection_clear): Don't treat other terminals with the
2977 same keyboard specially. Use the terminal-local Vselection_alist.
2978 (x_clear_frame_selections): Use Frun_hook_with_args.
2979
2980 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2981
2982 * xterm.h: Add support for those atoms.
2983
2984 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
2985
2986 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2987 (converted_selections, conversion_fail_tag): New global variables.
2988 (x_selection_request_lisp_error): Free the above.
2989 (x_get_local_selection): Remove unnecessary code.
2990 (x_reply_selection_request): Args changed; handle arbitrary array
2991 of converted selections stored in converted_selections.
2992 Separate the XChangeProperty and SelectionNotify steps.
2993 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2994 (x_convert_selection): New function.
2995 (x_handle_selection_event): Simplify.
2996 (x_get_foreign_selection): Don't ignore incoming requests while
2997 waiting for an answer; this will fail when we implement
2998 SAVE_TARGETS, and seems unnecessary anyway.
2999 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3000 (Vx_sent_selection_functions): Doc fix.
3001
3002 2011-05-26 Leo Liu <sdl.web@gmail.com>
3003
3004 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3005
3006 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3007
3008 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3009
3010 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3011 for fringe update if it has periodic bitmap.
3012 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3013 and fringe_bitmap_periodic_p.
3014
3015 * fringe.c (get_fringe_bitmap_data): New function.
3016 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3017 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3018 row. Mark glyph row for fringe update if periodicity changed.
3019
3020 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3021 for fringe update unless it has periodic bitmap.
3022
3023 2011-05-25 Kenichi Handa <handa@m17n.org>
3024
3025 * xdisp.c (get_next_display_element): Set correct it->face_id for
3026 a static composition.
3027
3028 2011-05-24 Leo Liu <sdl.web@gmail.com>
3029
3030 * deps.mk (fns.o):
3031 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3032
3033 * fns.c (crypto_hash_function, Fsha1): New function.
3034 (Fmd5): Use crypto_hash_function.
3035 (syms_of_fns): Add Ssha1.
3036
3037 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3038
3039 * gnutls.c: Remove unused macros.
3040 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3041 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3042 Remove macros that are defined and never used.
3043 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3044
3045 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3046
3047 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3048 (Fx_get_selection_internal): Minor cleanup.
3049 (Fx_own_selection_internal): Rename arguments for consistency with
3050 select.el.
3051
3052 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3053
3054 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3055
3056 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3057
3058 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3059
3060 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3061
3062 * dispnew.c (scrolling_window): Don't exclude the case that the
3063 last enabled row in the desired matrix touches the bottom boundary.
3064
3065 2011-05-21 Glenn Morris <rgm@gnu.org>
3066
3067 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3068 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3069 and add some more files.
3070
3071 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3072
3073 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3074 report_file_error introduced by the change from 2011-05-07.
3075
3076 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3077
3078 * systime.h (Time): Define only if emacs is defined.
3079 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3080 where the include path doesn't have X11/X.h by default. See
3081 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3082
3083 2011-05-20 Kenichi Handa <handa@m17n.org>
3084
3085 * composite.c (find_automatic_composition): Fix previous change.
3086
3087 2011-05-20 Glenn Morris <rgm@gnu.org>
3088
3089 * lisp.mk: New file, split from Makefile.in.
3090 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3091 (shortlisp): Remove.
3092 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3093
3094 2011-05-19 Glenn Morris <rgm@gnu.org>
3095
3096 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3097 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3098 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3099 (lisp): Set the order to that of loadup.el.
3100 (shortlisp): Make it a copy of $lisp.
3101 (SOME_MACHINE_LISP): Remove.
3102 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3103 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3104
3105 2011-05-18 Kenichi Handa <handa@m17n.org>
3106
3107 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3108 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3109 (find_automatic_composition): Mostly rewrite for efficiency.
3110
3111 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3112
3113 * makefile.w32-in: Update dependencies.
3114
3115 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3116
3117 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3118 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3119
3120 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3121
3122 Fix some integer overflow issues, such as string length overflow.
3123
3124 * insdel.c (count_size_as_multibyte): Check for string overflow.
3125
3126 * character.c (lisp_string_width): Check for string overflow.
3127 Use EMACS_INT, not int, for string indexes and lengths; in
3128 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3129 the resulting string length overflows an EMACS_INT; instead,
3130 report a string overflow if no precision given. When checking for
3131 precision exhaustion, use a check that cannot possibly have
3132 integer overflow. (Bug#8675)
3133 * character.h (lisp_string_width): Adjust to new signature.
3134
3135 * alloc.c (string_overflow): New function.
3136 (Fmake_string): Use it. This doesn't change behavior, but saves
3137 a few bytes and will simplify future changes.
3138 * character.c (string_escape_byte8): Likewise.
3139 * lisp.h (string_overflow): New decl.
3140
3141 Fixups, following up to the user-interface timestamp change.
3142 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3143 for UI timestamps, instead of unsigned long.
3144 * msdos.c (mouse_get_pos): Likewise.
3145 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3146 * w32gui.h (Time): Define by including "systime.h" rather than by
3147 declaring it ourselves. (Bug#8664)
3148
3149 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3150 * image.c (clear_image_cache): Likewise.
3151
3152 * term.c (term_mouse_position): Don't assume time_t wraparound.
3153
3154 Be more systematic about user-interface timestamps.
3155 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3156 and sometimes 'EMACS_UINT', to represent these timestamps.
3157 This change causes it to use 'Time' uniformly, as that's what X uses.
3158 This makes the code easier to follow, and makes it easier to catch
3159 integer overflow bugs such as Bug#8664.
3160 * frame.c (Fmouse_position, Fmouse_pixel_position):
3161 Use Time, not unsigned long, for user-interface timestamps.
3162 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3163 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3164 * keyboard.h (last_event_timestamp): Likewise.
3165 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3166 * menu.h (xmenu_show): Likewise.
3167 * term.c (term_mouse_position): Likewise.
3168 * termhooks.h (struct input_event.timestamp): Likewise.
3169 (struct terminal.mouse_position_hook): Likewise.
3170 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3171 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3172 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3173 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3174 what it was before.
3175 * menu.h, termhooks.h: Include "systime.h", for Time.
3176
3177 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3178 Don't assume that the difference between two unsigned long values
3179 can fit into an integer. At this point, we know button_down_time
3180 <= event->timestamp, so the difference must be nonnegative, so
3181 there's no need to cast the result if double-click-time is
3182 nonnegative, as it should be; check that it's nonnegative, just in
3183 case. This bug is triggered when events are more than 2**31 ms
3184 apart (about 25 days). (Bug#8664)
3185
3186 * xselect.c (last_event_timestamp): Remove duplicate decl.
3187 (x_own_selection): Remove needless cast to unsigned long.
3188
3189 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3190 that always fit in int. Use a sentinel instead of a counter, to
3191 avoid a temp and to allay GCC's concerns about possible int overflow.
3192 * frame.h (struct frame): Use int for menu_bar_items_used
3193 instead of EMACS_INT, since it always fits in int.
3194
3195 * menu.c (grow_menu_items): Check for int overflow.
3196
3197 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3198
3199 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3200 Before, the code was not consistent. These values cannot exceed
3201 2**31 - 1 so there's no need to make them unsigned.
3202 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3203 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3204 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3205 as modifiers.
3206 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3207
3208 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3209 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3210 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3211 presumably because the widths might not match.
3212
3213 * window.c (size_window): Avoid needless test at loop start.
3214
3215 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3216
3217 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3218
3219 2011-05-12 Drew Adams <drew.adams@oracle.com>
3220
3221 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3222
3223 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3224
3225 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3226 `width' to `bar_area_x' and `bar_area_width', respectively.
3227 (x_scroll_run): Take account of fringe background extension.
3228
3229 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3230 Rename local vars `left' and `width' to `bar_area_x' and
3231 `bar_area_width', respectively.
3232 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3233 background extension.
3234
3235 2011-05-10 Jim Meyering <meyering@redhat.com>
3236
3237 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3238
3239 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3240
3241 * image.c (Finit_image_library): Return t for built-in image types,
3242 like pbm and xbm. (Bug#8640)
3243
3244 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3245
3246 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3247
3248 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3249
3250 * w32console.c (Fset_screen_color): Doc fix.
3251 (Fget_screen_color): New function.
3252 (syms_of_ntterm): Defsubr it.
3253
3254 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3255 unlink the temporary file if Fcall_process didn't create it in the
3256 first place.
3257 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3258 child process will be redirected to a file specified with `:file'.
3259 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3260 cue to call_process_cleanup not to close that handle.
3261
3262 2011-05-07 Ben Key <bkey76@gmail.com>
3263
3264 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3265 one of two shell specific rules, either bootstrap-temacs-CMD or
3266 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3267 to the previous implementation of the bootstrap-temacs rule.
3268 The bootstrap-temacs-CMD rule is similar to the previous
3269 implementation of the bootstrap-temacs rule except that it
3270 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3271 variable.
3272
3273 These changes, along with some changes to nt/configure.bat,
3274 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3275 earlier fix to add support for --cflags and --ldflags options
3276 that include quotes so that it works whether make uses cmd or
3277 sh as the shell.
3278
3279 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3280
3281 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3282 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3283 is a constant.
3284 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3285 a string. Handle both cases.
3286 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3287 (Fdbus_register_method): Use Qinvalid_function.
3288
3289 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3290
3291 * makefile.w32-in: Update dependencies.
3292 (LISP_H): Add inttypes.h and stdin.h.
3293 (PROCESS_H): Add unistd.h.
3294
3295 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3296
3297 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3298 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3299
3300 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3301
3302 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3303
3304 * term.c (vfatal): Remove stray call to va_end.
3305 It's not needed and the C Standard doesn't allow it here anyway.
3306
3307 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3308 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3309
3310 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3311 bytes.
3312
3313 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3314
3315 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3316
3317 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3318
3319 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3320
3321 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3322
3323 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3324 * charset.c (Fdefine_charset_internal): Don't initialize
3325 charset.code_space[15]. The value was garbage, on hosts with
3326 32-bit int (Bug#8600).
3327
3328 * lread.c (read_integer): Be more consistent with string-to-number.
3329 Use string_to_number to do the actual conversion; this avoids
3330 rounding errors and fixes some other screwups. Without this fix,
3331 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3332 (digit_to_number): Move earlier, for benefit of read_integer.
3333 Return -1 if the digit is out of range for the base, -2 if it is
3334 not a digit in any supported base. (Bug#8602)
3335
3336 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3337
3338 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3339 to match comment at start of function. This also removes a
3340 GCC warning about overflow in a 32+64-bit port.
3341
3342 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3343
3344 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3345 Reported by Stefan Monnier in
3346 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3347 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3348 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3349
3350 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3351 (EMACS_UINTPTR): Likewise, with uintptr_t.
3352
3353 * lisp.h: Prefer 64-bit EMACS_INT if available.
3354 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3355 on 32-bit hosts that have 64-bit int, so that they can access
3356 large files.
3357 However, temporarily disable this change unless the temporary
3358 symbol WIDE_EMACS_INT is defined.
3359
3360 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3361
3362 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3363 This removes an assumption that EMACS_INT and long are the same
3364 width as pointers. The assumption is true for Emacs porting targets
3365 now, but we want to make other targets possible.
3366 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3367 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3368 In the rest of the code, change types of integers that hold casted
3369 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3370 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3371 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3372 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3373 No need to cast type when ORing.
3374 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3375 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3376 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3377 assume EMACS_INT is the same width as char *.
3378 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3379 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3380 Remove no-longer-needed casts.
3381 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3382 (xg_tool_bar_help_callback, xg_make_tool_item):
3383 Use EMACS_INTPTR to hold an integer
3384 that will be cast to void *; this can avoid a GCC warning
3385 if EMACS_INT is not the same width as void *.
3386 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3387 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3388 (current_message_1, set_message_1):
3389 Use a local to convert to proper width without a cast.
3390 * xmenu.c (dialog_selection_callback): Likewise.
3391
3392 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3393 Also, don't assume VALBITS / RAND_BITS is less than 5,
3394 and don't rely on undefined behavior when shifting a 1 left into
3395 the sign bit.
3396 * lisp.h (get_random): Change signature to match.
3397
3398 * lread.c (hash_string): Use size_t, not int, for hash computation.
3399 Normally we prefer signed values; but hashing is special, because
3400 it's better to use unsigned division on hash table sizes so that
3401 the remainder is nonnegative. Also, size_t is the natural width
3402 for hashing into memory. The previous code used 'int', which doesn't
3403 retain enough info to hash well into very large tables.
3404 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3405
3406 * dbusbind.c: Don't possibly lose pointer info when converting.
3407 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3408 Use XPNTR rather than XHASH, so that the high-order bits of
3409 the pointer aren't lost when converting through void *.
3410
3411 * eval.c (Fautoload): Don't double-shift a pointer.
3412
3413 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3414
3415 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3416
3417 * gnutls.c (DEF_GNUTLS_FN):
3418 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3419
3420 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3421
3422 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3423 marker. (Bug#8610)
3424
3425 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3426
3427 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3428 New version that can reserve upto 2GB of heap space.
3429
3430 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3431
3432 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3433
3434 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3435
3436 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3437 `gnutls_certificate_set_x509_key_file'.
3438
3439 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3440
3441 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3442 Update dependencies.
3443
3444 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3445
3446 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3447 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3448 Remove unused parameter `fildes'.
3449 * process.c (read_process_output, send_process): Don't pass it.
3450
3451 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3452
3453 Fix previous change: the library cache is defined in w32.c.
3454 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3455 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3456
3457 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3458
3459 Implement dynamic loading of GnuTLS on Windows.
3460
3461 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3462 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3463 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3464 Declare.
3465
3466 * gnutls.c (Qgnutls_dll): Define.
3467 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3468 (gnutls_*): Declare function pointers.
3469 (init_gnutls_functions): New function to initialize function pointers.
3470 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3471 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3472 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3473 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3474 (emacs_gnutls_write, emacs_gnutls_read)
3475 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3476 (Fgnutls_available_p): New function.
3477 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3478 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3479 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3480
3481 * image.c: Include w32.h.
3482 (Vimage_type_cache): Delete.
3483 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3484 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3485 (w32_delayed_load): Move to w32.c.
3486
3487 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3488
3489 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3490 (w32_delayed_load): Move from image.c. When loading a library, record
3491 its filename in the :loaded-from property of the library id.
3492 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3493 Initialize and staticpro them.
3494 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3495
3496 * process.c: Include lisp.h before w32.h, not after.
3497 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3498 instead of gnutls_record_check_pending.
3499
3500 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3501
3502 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3503
3504 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3505 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3506 as passed in.
3507
3508 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3509
3510 * xterm.c (x_set_frame_alpha): Do not set property on anything
3511 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3512
3513 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3514
3515 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3516
3517 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3518
3519 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3520 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3521 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3522 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3523 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3524 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3525 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3526 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3527 (Qgnutls_bootprop_callbacks_verify): Make static.
3528
3529 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3530
3531 * callproc.c: Indentation fixup.
3532
3533 * sysdep.c (wait_for_termination_1): Make static.
3534 (wait_for_termination, interruptible_wait_for_termination):
3535 Move after wait_for_termination_1.
3536
3537 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3538
3539 * sysdep.c (interruptible_wait_for_termination): New function
3540 which is like wait_for_termination, but allows keyboard
3541 interruptions.
3542
3543 * callproc.c (Fcall_process): Add (:file "file") as an option for
3544 the STDOUT buffer.
3545 (Fcall_process_region): Ditto.
3546
3547 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3548
3549 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3550 rather than `XVECTOR (FOO)->size'.
3551
3552 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3553 inttypes.h, as a gnulib replacement is used if it not available in
3554 system headers.
3555
3556 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3557
3558 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3559 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3560 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3561
3562 * coding.c (coding_alloc_by_realloc): Error out if destination
3563 will grow beyond MOST_POSITIVE_FIXNUM.
3564 (decode_coding_emacs_mule): Abort if there isn't enough place in
3565 charbuf for the composition carryover bytes. Reserve an extra
3566 space for up to 2 characters produced in a loop.
3567 (decode_coding_iso_2022): Abort if there isn't enough place in
3568 charbuf for the composition carryover bytes.
3569
3570 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3571
3572 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3573 aborting when %lld or %lll format is passed.
3574 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3575 %llo or %llx format is passed. (Bug#8545)
3576
3577 * window.c (window_scroll_line_based): Use a marker instead of
3578 simple variables to record original value of point. (Bug#7952)
3579
3580 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3581 produced by %s or %c overflows available buffer space. (Bug#8545)
3582
3583 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3584
3585 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3586 (SIZE_MAX): Move defn after all includes, as they might #define it.
3587
3588 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3589
3590 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3591
3592 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3593
3594 * keyboard.c (Qdelayed_warnings_hook): Define.
3595 (command_loop_1): Run `delayed-warnings-hook'
3596 if Vdelayed_warnings_list is non-nil.
3597 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3598 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3599
3600 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3601
3602 * doprnt.c (doprnt): Don't return value smaller than the buffer
3603 size if the message was truncated. (Bug#8545).
3604
3605 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3606
3607 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3608 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3609
3610 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3611
3612 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3613
3614 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3615
3616 * makefile.w32-in: Update dependencies.
3617
3618 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3619
3620 Improve `doprnt' and its usage. (Bug#8545)
3621 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3622 `format_end'. Remove support for %l as a conversion specifier.
3623 Don't use xrealloc. Improve diagnostics when the %l size modifier
3624 is used. Update the commentary.
3625
3626 * eval.c (verror): Simplify calculation of size_t.
3627
3628 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3629 messages.
3630
3631 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3632
3633 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3634 change.
3635
3636 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3637
3638 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3639 This makes this file independent of the recent pseudovector change.
3640
3641 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3642
3643 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3644
3645 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3646 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3647 Remove unused local.
3648 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3649
3650 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3651 GCC 4.6.0 optimizes based on type-based alias analysis.
3652 For example, if b is of type struct buffer * and v of type struct
3653 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3654 != &v->size, and therefore "v->size = 1; b->size = 2; return
3655 v->size;" must therefore return 1. This assumption is incorrect
3656 for Emacs, since it type-puns struct Lisp_Vector * with many other
3657 types. To fix this problem, this patch adds a new type struct
3658 vectorlike_header that documents the constraints on layout of vectors
3659 and pseudovectors, and helps optimizing compilers not get fooled
3660 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3661 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3662 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3663 the size member.
3664 (XSETPVECTYPE): Rewrite in terms of new macro.
3665 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3666 This is a bit clearer, and further avoids the possibility of
3667 undesirable aliasing.
3668 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3669 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3670 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3671 since Lisp_Subr is a special case (no "next" field).
3672 (ASIZE): Now uses header.size rather than size.
3673 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3674 to avoid the hassle of writing XVECTOR (foo)->header.size.
3675 (struct vectorlike_header): New type.
3676 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3677 object, to help avoid aliasing.
3678 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3679 (SUBRP): Likewise, since Lisp_Subr is a special case.
3680 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3681 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3682 (struct Lisp_Hash_Table): Combine first two members into a single
3683 struct vectorlike_header member. All uses of "size" and "next" members
3684 changed to be "header.size" and "header.next".
3685 * buffer.h (struct buffer): Likewise.
3686 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3687 * frame.h (struct frame): Likewise.
3688 * process.h (struct Lisp_Process): Likewise.
3689 * termhooks.h (struct terminal): Likewise.
3690 * window.c (struct save_window_data, struct saved_window): Likewise.
3691 * window.h (struct window): Likewise.
3692 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3693 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3694 * buffer.c (init_buffer_once): Likewise.
3695 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3696 special case.
3697 * process.c (Fformat_network_address): Use local var for size,
3698 for brevity.
3699
3700 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3701
3702 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3703 * data.c (atof): Remove decl; no longer used or needed.
3704 (digit_to_number): Move to lread.c.
3705 (Fstring_to_number): Use new string_to_number function, to be
3706 consistent with how the Lisp reader treats infinities and NaNs.
3707 Do not assume that floating-point numbers represent EMACS_INT
3708 without losing information; this is not true on most 64-bit hosts.
3709 Avoid double-rounding errors, by insisting on integers when
3710 parsing non-base-10 numbers, as the documentation specifies.
3711 * lisp.h (string_to_number): New decl, replacing ...
3712 (isfloat_string): Remove.
3713 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3714 (read1): Do not accept +. and -. as integers; this
3715 appears to have been a coding error. Similarly, do not accept
3716 strings like +-1e0 as floating point numbers. Do not report
3717 overflow for integer overflows unless the base is not 10 which
3718 means we have no simple and reliable way to continue.
3719 Break out the floating-point parsing into a new
3720 function string_to_number, so that Fstring_to_number parses
3721 floating point numbers consistently with the Lisp reader.
3722 (digit_to_number): Move here from data.c. Make it static inline.
3723 (E_CHAR, EXP_INT): Remove, replacing with ...
3724 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3725 (string_to_number): New function, replacing isfloat_string.
3726 This function checks for valid syntax and produces the resulting
3727 Lisp float number too. Rework it so that string-to-number
3728 no longer mishandles examples like "1.0e+". Use strtoumax,
3729 so that overflow for non-base-10 numbers is reported only when
3730 there's no portable and simple way to convert to floating point.
3731
3732 * textprop.c (set_text_properties_1): Rewrite for clarity,
3733 and to avoid GCC warning about integer overflow.
3734
3735 * intervals.h (struct interval): Use EMACS_INT for members
3736 where EMACS_UINT might cause problems. See
3737 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3738 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3739 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3740 All uses changed.
3741 (offset_intervals): Tell GCC not to worry about length overflow
3742 when negating a negative length.
3743
3744 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3745 (overrun_check_free): Likewise.
3746
3747 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3748 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3749 word size.
3750
3751 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3752 (gnutls_make_error): Rename local to avoid shadowing.
3753 (gnutls_emacs_global_deinit): ifdef out; not used.
3754 (Fgnutls_boot): Use const for pointer to readonly storage.
3755 Comment out unused local. Fix pointer signedness problems.
3756
3757 * lread.c (openp): Don't stuff size_t into an 'int'.
3758 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3759 about possible signed overflow.
3760
3761 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3762 (GDK_KEY_g): Don't define if already defined.
3763 (xg_prepare_tooltip): Avoid pointer signedness problem.
3764 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3765
3766 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3767 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3768
3769 * xfns.c (Fx_window_property): Simplify a bit,
3770 to make a bit faster and to avoid GCC 4.6.0 warning.
3771 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3772
3773 * fns.c (internal_equal): Don't assume size_t fits in int.
3774
3775 * alloc.c (compact_small_strings): Tighten assertion a little.
3776
3777 Replace pEd with more-general pI, and fix some printf arg casts.
3778 * lisp.h (pI): New macro, generalizing old pEd macro to other
3779 conversion specifiers. For example, use "...%"pI"d..." rather
3780 than "...%"pEd"...".
3781 (pEd): Remove. All uses replaced with similar uses of pI.
3782 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3783 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3784 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3785 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3786 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3787 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3788 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3789 64-bit hosts.
3790 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3791 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3792 * print.c (safe_debug_print, print_object): Likewise.
3793 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3794 to int.
3795 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3796 avoiding the 0 flag, which is not portable.
3797 * process.c (Fmake_network_process): Use pI to avoid cast.
3798 * region-cache.c (pp_cache): Likewise.
3799 * xdisp.c (decode_mode_spec): Likewise.
3800 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3801 behavior on 64-bit hosts with printf arg.
3802 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3803 (x_stop_queuing_selection_requests): Likewise.
3804 (x_get_window_property): Don't truncate byte count to an 'int'
3805 when tracing.
3806
3807 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3808 here, since it parses constructs like leading '-' and spaces,
3809 which are not wanted; and it overflows with large numbers.
3810 Instead, simply match F[0-9]+, which is what is wanted anyway.
3811
3812 * alloc.c: Remove unportable assumptions about struct layout.
3813 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3814 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3815 (allocate_vectorlike, make_pure_vector): Use the new macros,
3816 plus offsetof, to remove unportable assumptions about struct layout.
3817 These assumptions hold on all porting targets that I know of, but
3818 they are not guaranteed, they're easy to remove, and removing them
3819 makes further changes easier.
3820
3821 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3822 This doesn't fix a bug but makes the code clearer.
3823 (string_overrun_cookie): Now const. Use initializers that
3824 don't formally overflow signed char, to avoid warnings.
3825 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3826 can cause Emacs to crash when string overrun checking is enabled.
3827 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3828 multiple of sizeof (EMACS_INT); it need not be, if
3829 alignof(EMACS_INT) < sizeof (EMACS_INT).
3830 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3831
3832 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3833
3834 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3835
3836 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3837
3838 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3839 supposed to be handshaking. (Bug#8556)
3840 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3841
3842 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3843
3844 * lisp.h (Qdebug): List symbol.
3845 * eval.c (Qdebug): Restore global linkage.
3846 * keyboard.c (debug-on-event): New variable.
3847 (handle_user_signal): Break into debugger when debug-on-event
3848 matches the current signal symbol.
3849
3850 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3851
3852 * alloc.c (check_sblock, check_string_bytes)
3853 (check_string_free_list): Convert to standard C.
3854
3855 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3856
3857 * w32.c (emacs_gnutls_push): Fix typo.
3858
3859 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3860
3861 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3862 "cast to pointer from integer of different size".
3863
3864 Improve doprnt and its use in verror. (Bug#8545)
3865 * doprnt.c (doprnt): Document the set of format control sequences
3866 supported by the function. Use SAFE_ALLOCA instead of always
3867 using `alloca'.
3868
3869 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3870 is one byte too soon. Don't use xrealloc; instead xfree and
3871 xmalloc anew.
3872
3873 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3874
3875 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3876 callbacks stage.
3877
3878 * gnutls.c: Renamed global_initialized to
3879 gnutls_global_initialized. Added internals for the
3880 :verify-hostname-error, :verify-error, and :verify-flags
3881 parameters of `gnutls-boot' and documented those parameters in the
3882 docstring. Start callback support.
3883 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3884 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3885 on error. Return error code.
3886 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3887 (emacs_gnutls_read): Likewise.
3888 (Fgnutls_boot): Return handshake error code.
3889 (emacs_gnutls_handle_error): New function.
3890 (wsaerror_to_errno): Likewise.
3891
3892 * w32.h (emacs_gnutls_pull): Add prototype.
3893 (emacs_gnutls_push): Likewise.
3894
3895 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3896 (emacs_gnutls_push): Likewise.
3897
3898 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3899
3900 * process.c (wait_reading_process_output): Check if GnuTLS
3901 buffered some data internally if no FDs are set for TLS
3902 connections.
3903
3904 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3905 (LIBS): Link to USER_LIBS.
3906 ($(BLD)/gnutls.$(0)): New target.
3907
3908 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3909
3910 * xdisp.c (handle_single_display_spec): Rename the
3911 display_replaced_before_p argument into display_replaced_p, to
3912 make it consistent with the commentary. Fix typos in the
3913 commentary.
3914
3915 * textprop.c (syms_of_textprop): Remove dead code.
3916 (copy_text_properties): Delete obsolete commentary about an
3917 interface that was deleted long ago. Fix typos in the description
3918 of arguments.
3919
3920 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3921 to changes in oldXMenu/XMenu.h from 2011-04-16.
3922 <menu_help_message, prev_menu_help_message>: Constify.
3923 (IT_menu_make_room): menu->help_text is now `const char **';
3924 adjust.
3925
3926 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3927 to changes in oldXMenu/XMenu.h from 2011-04-16.
3928 (struct XMenu): Declare `help_text' `const char **'.
3929
3930 * xfaces.c <Qunspecified>: Make extern again.
3931
3932 * syntax.c: Include sys/types.h before including regex.h, as
3933 required by Posix.
3934
3935 * doc.c (get_doc_string): Improve the format passed to `error'.
3936
3937 * doprnt.c (doprnt): Improve commentary.
3938
3939 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3940
3941 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3942 them with etags.
3943
3944 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3945 changes in globals.h immediately force recompilation.
3946 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3947 $(CURDIR)/s/ms-w32.h.
3948 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3949
3950 * character.c (Fchar_direction): Function deleted.
3951 (syms_of_character): Don't defsubr it.
3952 <char-direction-table>: Deleted.
3953
3954 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3955
3956 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3957 * doprnt.c: Include limits.h.
3958 (SIZE_MAX): New macro.
3959 (doprnt): Return a size_t value. 2nd arg is now size_t.
3960 Many local variables are now size_t instead of int or unsigned.
3961 Improve overflow protection. Support `l' modifier for integer
3962 conversions. Support %l conversion. Don't assume an EMACS_INT
3963 argument for integer conversions and for %c.
3964
3965 * lisp.h (doprnt): Restore prototype.
3966
3967 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3968 $(SRC)/character.h.
3969
3970 * Makefile.in (base_obj): Add back doprnt.o.
3971
3972 * deps.mk (doprnt.o): Add back prerequisites.
3973 (callint.o): Depend on character.h.
3974
3975 * eval.c (internal_lisp_condition_case): Include the handler
3976 representation in the error message.
3977 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3978 when breaking from the loop.
3979
3980 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3981
3982 * callint.c (Fcall_interactively): When displaying error message
3983 about invalid control letter, pass the character's codepoint, not
3984 a pointer to its multibyte form. Improve display of the character
3985 in octal and display also its hex code.
3986
3987 * character.c (char_string): Use %x to display the (unsigned)
3988 codepoint of an invalid character, to avoid displaying a bogus
3989 negative value.
3990
3991 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3992 `error', not SYMBOL_NAME itself.
3993
3994 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3995 character arguments to `error'.
3996
3997 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3998 to `error' in error message about FINAL_CHAR argument. Make sure
3999 FINAL_CHAR is a character, and use %c when it is passed as
4000 argument to `error'.
4001
4002 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4003
4004 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4005
4006 * w32.c: Include <time.h>.
4007 (sys_localtime): New function.
4008
4009 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4010
4011 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4012
4013 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4014
4015 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4016
4017 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4018 zombies (Bug#8467).
4019
4020 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4021
4022 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4023 gl_state.e_property when gl_state.object is Qt.
4024
4025 * insdel.c (make_gap_larger): Remove limitation of buffer size
4026 to <= INT_MAX.
4027
4028 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4029
4030 * xdisp.c (lookup_glyphless_char_display)
4031 (produce_glyphless_glyph): Handle cons cell entry in
4032 glyphless-char-display.
4033 (Vglyphless_char_display): Document it.
4034
4035 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4036 glyphless-char-display.
4037
4038 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4039
4040 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4041
4042 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4043
4044 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4045 definition for no-X builds.
4046
4047 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4048
4049 Static checks with GCC 4.6.0 and non-default toolkits.
4050
4051 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4052
4053 * process.c (keyboard_bit_set): Define only if SIGIO.
4054 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4055 (send_process): Repair possible setjmp clobbering.
4056
4057 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4058
4059 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4060
4061 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4062
4063 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4064 Define only if needed.
4065
4066 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4067 by pacifying GCC about it. Maybe it's time to retire it?
4068 * xfaces.c (USG, __TIMEVAL__): Likewise.
4069
4070 * dispextern.h (struct redisplay_interface): Rename param
4071 to avoid shadowing.
4072 * termhooks.h (struct terminal): Likewise.
4073 * xterm.c (xembed_send_message): Likewise.
4074
4075 * insdel.c (make_gap_smaller): Define only if
4076 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4077
4078 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4079 it.
4080
4081 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4082 so that we aren't warned about unused symbols.
4083
4084 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4085
4086 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4087
4088 * xfns.c (x_real_positions): Mark locals as initialized.
4089
4090 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4091
4092 * xterm.c: Fix problems found by static analysis with other toolkits.
4093 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4094 (x_dispatch_event): Declare static if USE_GTK, and
4095 define if USE_GTK || USE_X_TOOLKIT.
4096 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4097 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4098 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4099 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4100
4101 * xmenu.c (menu_help_callback): Pointer type fixes.
4102 Use const pointers when pointing at readonly data. Avoid pointer
4103 signedness clashes.
4104 (FALSE): Remove unused macro.
4105 (update_frame_menubar): Remove unused decl.
4106
4107 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4108
4109 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4110 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4111 (single_menu_item): Rename local to avoid shadowing.
4112
4113 * keyboard.c (make_lispy_event): Remove unused local var.
4114
4115 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4116 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4117
4118 * bitmaps: Change bitmaps from unsigned char back to the X11
4119 compatible char. Avoid the old compiler warnings about
4120 out-of-range initializers by using, for example, '\xab' rather
4121 than 0xab.
4122
4123 * xgselect.c (xgselect_initialize): Check vs interface
4124 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4125
4126 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4127
4128 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4129 to read-only memory.
4130
4131 * fns.c (vector): Remove; this old hack is no longer needed.
4132
4133 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4134 Remove unused var.
4135 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4136
4137 * xrdb.c (x_load_resources): Omit unused local.
4138
4139 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4140 (x_window): Rename locals to avoid shadowing.
4141 (USG): Use the kludged USG macro, to pacify gcc.
4142
4143 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4144 (x_term_init): Remove local to avoid shadowing.
4145
4146 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4147
4148 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4149 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4150
4151 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4152
4153 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4154
4155 Fix regex.c, syntax.c and friends for buffers > 2GB.
4156 * syntax.h (struct gl_state_s): Declare character position members
4157 EMACS_INT.
4158
4159 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4160
4161 * textprop.c (verify_interval_modification, interval_of):
4162 Declare arguments EMACS_INT.
4163
4164 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4165 EMACS_INT.
4166
4167 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4168
4169 * indent.c (Fvertical_motion): Local variable it_start is now
4170 EMACS_INT.
4171
4172 * regex.c (re_match, re_match_2, re_match_2_internal)
4173 (bcmp_translate, regcomp, regexec, print_double_string)
4174 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4175 (re_compile_pattern, re_exec): Declare arguments and local
4176 variables `size_t' and `ssize_t' and return values `regoff_t', as
4177 appropriate.
4178 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4179 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4180 <compile_stack_type>: `size' and `avail' are now `size_t'.
4181
4182 * regex.h <regoff_t>: Use ssize_t, not int.
4183 (re_search, re_search_2, re_match, re_match_2): Arguments that
4184 specify buffer/string position and length are now ssize_t and
4185 size_t. Return type is regoff_t.
4186
4187 2011-04-16 Ben Key <bkey76@gmail.com>
4188
4189 * nsfont.m: Fixed bugs in ns_get_family and
4190 ns_descriptor_to_entity that were caused by using free to
4191 deallocate memory blocks that were allocated by xmalloc (via
4192 xstrdup). This caused Emacs to crash when compiled with
4193 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4194 --enable-checking=xmallocoverrun). xfree is now used to
4195 deallocate these memory blocks.
4196
4197 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4198
4199 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4200
4201 emacs_write: Accept and return EMACS_INT for sizes.
4202 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4203 et seq.
4204 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4205 Accept and return EMACS_INT.
4206 (emacs_gnutls_write): Return the number of bytes written on
4207 partial writes.
4208 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4209 (emacs_read, emacs_write): Remove check for negative size, as the
4210 Emacs source code has been audited now.
4211 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4212 (emacs_read, emacs_write): Use it.
4213 * process.c (send_process): Adjust to the new signatures of
4214 emacs_write and emacs_gnutls_write. Do not attempt to store
4215 a byte offset into an 'int'; it might overflow.
4216 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4217
4218 * sound.c: Don't assume sizes fit in 'int'.
4219 (struct sound_device.period_size, alsa_period_size):
4220 Return EMACS_INT, not int.
4221 (struct sound_device.write, vox_write, alsa_write):
4222 Accept EMACS_INT, not int.
4223 (wav_play, au_play): Use EMACS_INT to store sizes and to
4224 record read return values.
4225
4226 2011-04-15 Ben Key <bkey76@gmail.com>
4227
4228 * keyboard.c (Qundefined): Don't declare static since it is used
4229 in nsfns.m.
4230 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4231 static since they are used in nsfont.m.
4232
4233 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4234
4235 * process.c (Qprocessp): Don't declare static.
4236 * lisp.h (Qprocessp): Declare again.
4237
4238 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4239
4240 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4241
4242 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4243
4244 Improve C-level modularity by making more things 'static'.
4245
4246 Don't publish debugger-only interfaces to other modules.
4247 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4248 (verify_bytepos, count_markers): Move decls to the only modules
4249 that need them.
4250 * region-cache.h (pp_cache): Likewise.
4251 * window.h (check_all_windows): Likewise.
4252 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4253
4254 * sysdep.c (croak): Now static, if
4255 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4256 * syssignal.h (croak): Declare only if not static.
4257
4258 * alloc.c (refill_memory_reserve): Now static if
4259 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4260 * lisp.h (refill_memory_reserve): Declare only if not static.
4261
4262 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4263 Define only if USE_LUCID.
4264
4265 * xrdb.c (x_customization_string, x_rm_string): Now static.
4266
4267 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4268 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4269
4270 * xdisp.c (draw_row_with_mouse_face): Now static.
4271 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4272
4273 * window.h (check_all_windows): Mark externally visible.
4274
4275 * window.c (window_deletion_count): Now static.
4276
4277 * undo.c: Make symbols static if they're not exported.
4278 (last_undo_buffer, last_boundary_position, pending_boundary):
4279 Now static.
4280
4281 * textprop.c (interval_insert_behind_hooks): Now static.
4282 (interval_insert_in_front_hooks): Likewise.
4283
4284 * term.c: Make symbols static if they're not exported.
4285 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4286 (max_frame_lines, tty_set_terminal_modes):
4287 (tty_reset_terminal_modes, tty_turn_off_highlight):
4288 (get_tty_terminal): Now static.
4289 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4290 * termhooks.h (term_mouse_moveto): Do not declare if
4291 HAVE_WINDOW_SYSTEM.
4292 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4293 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4294
4295 * sysdep.c: Make symbols static if they're not exported.
4296 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4297 Now static.
4298 (sigprocmask_set, full_mask): Remove; unused.
4299 (wait_debugging): Mark as visible.
4300 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4301 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4302
4303 * syntax.c (syntax_temp): Define only if !__GNUC__.
4304
4305 * sound.c (current_sound_device, current_sound): Now static.
4306
4307 * search.c (searchbufs, searchbuf_head): Now static.
4308
4309 * scroll.c (scroll_cost): Remove; unused.
4310 * dispextern.h (scroll_cost): Remove decl.
4311
4312 * region-cache.h (pp_cache): Mark as externally visible.
4313
4314 * process.c: Make symbols static if they're not exported.
4315 (process_tick, update_tick, create_process, chan_process):
4316 (Vprocess_alist, proc_buffered_char, datagram_access):
4317 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4318 (deactivate_process): Mark defn as static, as well as decl.
4319 * lisp.h (create_process): Remove decl.
4320 * process.h (chan_process, Vprocess_alist): Remove decls.
4321
4322 * print.c: Make symbols static if they're not exported.
4323 (print_depth, new_backquote_output, being_printed, print_buffer):
4324 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4325 (print_interval, print_number_index, initial_stderr_stream):
4326 Now static.
4327 * lisp.h (Fprinc): Remove decl.
4328 (debug_output_compilation_hack): Mark as externally visible.
4329
4330 * sysdep.c (croak): Move decl from here to syssignal.h.
4331 * syssignal.h (croak): Put it here, so the API can be checked when
4332 'croak' is called from dissociate_if_controlling_tty.
4333
4334 * minibuf.c: Make symbols static if they're not exported.
4335 (minibuf_save_list, choose_minibuf_frame): Now static.
4336 * lisp.h (choose_minibuf_frame): Remove decl.
4337
4338 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4339
4340 * lread.c: Make symbols static if they're not exported.
4341 (read_objects, initial_obarray, oblookup_last_bucket_number):
4342 Now static.
4343 (make_symbol): Remove; unused.
4344 * lisp.h (initial_obarray, make_symbol): Remove decls.
4345
4346 * keyboard.c: Make symbols static if they're not exported.
4347 (single_kboard, recent_keys_index, total_keys, recent_keys):
4348 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4349 (this_single_command_key_start, echoing, last_auto_save):
4350 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4351 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4352 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4353 (Vlispy_mouse_stem, double_click_count):
4354 Now static.
4355 (force_auto_save_soon): Define only if SIGDANGER.
4356 (ignore_mouse_drag_p): Now static if
4357 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4358 (print_help): Remove; unused.
4359 (stop_character, last_timer_event): Mark as externally visible.
4360 * keyboard.h (ignore_mouse_drag_p): Declare only if
4361 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4362 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4363 * lisp.h (echoing): Remove decl.
4364 (force_auto_save_soon): Declare only if SIGDANGER.
4365 * xdisp.c (redisplay_window): Simplify code, to make it more
4366 obvious that ignore_mouse_drag_p is not accessed if !defined
4367 USE_GTK && !defined HAVE_NS.
4368
4369 * intervals.c: Make symbols static if they're not exported.
4370 (merge_properties_sticky, merge_interval_right, delete_interval):
4371 Now static.
4372 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4373
4374 * insdel.c: Make symbols static if they're not exported.
4375 However, leave prepare_to_modify_buffer alone. It's never
4376 called from outside this function, but that appears to be a bug.
4377 (combine_after_change_list, combine_after_change_buffer):
4378 (adjust_after_replace, signal_before_change): Now static.
4379 (adjust_after_replace_noundo): Remove; unused.
4380 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4381 (signal_before_change): Remove decls.
4382
4383 * indent.c (val_compute_motion, val_vmotion): Now static.
4384
4385 * image.c: Make symbols static if they're not exported.
4386 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4387 if USE_GTK.
4388 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4389 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4390
4391 * fringe.c (standard_bitmaps): Now static.
4392 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4393
4394 * frame.c: Make symbols static if they're not exported.
4395 (x_report_frame_params, make_terminal_frame): Now static.
4396 (get_frame_param): Now static, unless HAVE_NS.
4397 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4398 (x_get_resource_string): Remove; not used.
4399 * frame.h (make_terminal_frame, x_report_frame_params):
4400 (x_get_resource_string); Remove decls.
4401 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4402 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4403
4404 * font.c, fontset.c: Make symbols static if they're not exported.
4405 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4406 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4407 * font.c (font_close_object): Now static.
4408 * font.h (font_close_object): Remove.
4409 * fontset.c (FONTSET_OBJLIST): Remove.
4410 (free_realized_fontset) #if-0 the body, which does nothing.
4411 (face_suitable_for_char_p): #if-0, as it's never called.
4412 * fontset.h (face_suitable_for_char_p): Remove decl.
4413 * xfaces.c (face_at_string_position):
4414 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4415 since 0 is always ASCII.
4416
4417 * fns.c (weak_hash_tables): Now static.
4418
4419 * fileio.c: Make symbols static if they're not exported.
4420 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4421 (Vwrite_region_annotation_buffers): Now static.
4422
4423 * eval.c: Make symbols static if they're not exported.
4424 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4425 * lisp.h (backtrace_list): Remove decl.
4426
4427 * emacs.c: Make symbols static if they're not exported.
4428 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4429 (fatal_error_code, fatal_error_signal_hook, standard_args):
4430 Now static.
4431 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4432 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4433 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4434 * lisp.h (fatal_error_signal_hook): Remove decl.
4435 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4436
4437 * editfns.c: Move a (normally-unused) function to its only use.
4438 * editfns.c, lisp.h (get_operating_system_release): Remove.
4439 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4440 worth the hassle of breaking this out.
4441
4442 * xterm.c: Make symbols static if they're not exported.
4443 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4444 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4445 (x_destroy_window, x_delete_display):
4446 Now static.
4447 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4448 (x_mouse_leave): Remove; unused.
4449 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4450 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4451 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4452 Remove decls.
4453 (x_mouse_leave): Declare only if WINDOWSNT.
4454 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4455 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4456 USE_X_TOOLKIT.
4457
4458 * ftxfont.c: Make symbols static if they're not exported.
4459 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4460 HAVE_FREETYPE.
4461 * font.h (ftxfont_driver): Likewise.
4462
4463 * xfns.c: Make symbols static if they're not exported.
4464 (x_last_font_name, x_display_info_for_name):
4465 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4466 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4467 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4468 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4469 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4470 (last_show_tip_args): Now static.
4471 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4472 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4473 (x_screen_planes): Remove; unused.
4474 * dispextern.h (x_screen_planes): Remove decl.
4475
4476 * dispnew.c: Make symbols static if they're not exported.
4477 * dispextern.h (redraw_garbaged_frames, scrolling):
4478 (increment_row_positions): Remove.
4479 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4480 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4481 Now static.
4482 (redraw_garbaged_frames): Remove; unused.
4483
4484 * xfaces.c: Make symbols static if they're not exported.
4485 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4486 Remove decls.
4487 * xterm.h (defined_color): Remove decls.
4488 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4489 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4490 (menu_face_changed_default, defined_color, free_realized_face):
4491 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4492 (ascii_face_of_lisp_face): Remove; unused.
4493
4494 * xdisp.c: Make symbols static if they're not exported.
4495 * dispextern.h (scratch_glyph_row, window_box_edges):
4496 (glyph_to_pixel_coords, set_cursor_from_row):
4497 (get_next_display_element, set_iterator_to_next):
4498 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4499 (show_mouse_face): Remove decls
4500 * frame.h (message_buf_print): Likewise.
4501 * lisp.h (pop_message, set_message, check_point_in_composition):
4502 Likewise.
4503 * xterm.h (set_vertical_scroll_bar): Likewise.
4504 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4505 (message_buf_print, scratch_glyph_row, displayed_buffer):
4506 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4507 (get_next_display_element, show_mouse_face, window_box_edges):
4508 (frame_to_window_pixel_xy, check_point_in_composition):
4509 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4510 (glyph_to_pixel_coords): Remove; unused.
4511
4512 * dired.c (file_name_completion): Now static.
4513
4514 * dbusbind.c (xd_in_read_queued_messages): Now static.
4515
4516 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4517 * data.c (circular_list_error): Remove.
4518
4519 * commands.h (last_point_position, last_point_position_buffer):
4520 (last_point_position_window): Remove decls.
4521 * keyboard.c: Make these variables static.
4522
4523 * coding.h (coding, code_convert_region, encode_coding_gap):
4524 Remove decls.
4525 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4526 (iso_code_class, detect_coding, code_convert_region): Now static.
4527 (encode_coding_gap): Remove; unused.
4528
4529 * chartab.c (chartab_chars, chartab_bits): Now static.
4530
4531 * charset.h (charset_iso_8859_1): Remove decl.
4532 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4533 Now static.
4534
4535 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4536 * ccl.c (Vccl_program_table): Now static.
4537 (check_ccl_update): Remove; unused.
4538
4539 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4540 * category.h: ... from here.
4541 * category.c (check_category_table, set_category_set): Now static.
4542
4543 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4544 * lisp.h: Remove these decls.
4545
4546 * buffer.c (buffer_count): Remove unused var.
4547
4548 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4549 so that it's not optimized away.
4550 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4551 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4552 exported only to the debugger.
4553
4554 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4555 * atimer.h (run_all_atimers): Remove; not exported.
4556
4557 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4558 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4559 was inaccessible from Lisp.
4560 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4561 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4562
4563 alloc.c: Import and export fewer symbols, and remove unused items.
4564 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4565 is defined.
4566 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4567 it's not optimized away by whole-program optimization.
4568 (message_enable_multibyte, free_misc): Remove.
4569 (catchlist, handlerlist, mark_backtrace):
4570 Declare only if BYTE_MARK_STACK.
4571 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4572 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4573 (message_enable_multibyte): Remove decl.
4574 (free_misc, interval_free_list, float_block, float_block_index):
4575 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4576 (cons_free_list, last_marked_index):
4577 Now static.
4578 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4579 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4580 (mark_backtrace): Define only if BYTE_MARK_STACK.
4581 * xdisp.c (message_enable_multibyte): Now static.
4582
4583 Declare Lisp_Object Q* variables to be 'static' if not exported.
4584 This makes it easier for human readers (and static analyzers)
4585 to see whether these variables are used from other modules.
4586 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4587 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4588 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4589 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4590 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4591 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4592 * xmenu.c, xselect.c:
4593 Declare Q* vars static if they are not used in other modules.
4594 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4595 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4596 Remove decls of unexported vars.
4597 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4598
4599 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4600
4601 Make Emacs functions such as Fatom 'static' by default.
4602 This makes it easier for human readers (and static analyzers)
4603 to see whether these functions can be called from other modules.
4604 DEFUN now defines a static function. To make the function external
4605 so that it can be used in other C modules, use the new macro DEFUE.
4606 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4607 (Finit_image_library):
4608 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4609 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4610 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4611 Remove decls, since these functions are now static.
4612 (Funintern, Fget_internal_run_time): New decls, since these functions
4613 were already external.
4614
4615 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4616 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4617 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4618 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4619 * keyboard.c, keymap.c, lread.c:
4620 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4621 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4622 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4623 Mark functions with DEFUE instead of DEFUN,
4624 if they are used in other modules.
4625 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4626 decls for now-static functions.
4627 * buffer.h (Fdelete_overlay): Remove decl.
4628 * callproc.c (Fgetenv_internal): Mark as internal.
4629 * composite.c (Fremove_list_of_text_properties): Remove decl.
4630 (Fcomposition_get_gstring): New forward static decl.
4631 * composite.h (Fcomposite_get_gstring): Remove decl.
4632 * dired.c (Ffile_attributes): New forward static decl.
4633 * doc.c (Fdocumntation_property): New forward static decl.
4634 * eval.c (Ffetch_bytecode): New forward static decl.
4635 (Funintern): Remove extern decl; now in .h file where it belongs.
4636 * fileio.c (Fmake_symbolic_link): New forward static decl.
4637 * image.c (Finit_image_library): New forward static decl.
4638 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4639 * intervals.h (Fprevious_property_change):
4640 (Fremove_list_of_text_properties): Remove decls.
4641 * keyboard.c (Fthis_command_keys): Remove decl.
4642 (Fcommand_execute): New forward static decl.
4643 * keymap.c (Flookup_key): New forward static decl.
4644 (Fcopy_keymap): Now static.
4645 * keymap.h (Flookup_key): Remove decl.
4646 * process.c (Fget_process): New forward static decl.
4647 (Fprocess_datagram_address): Mark as internal.
4648 * syntax.c (Fsyntax_table_p): New forward static decl.
4649 (skip_chars): Remove duplicate decl.
4650 * textprop.c (Fprevious_property_change): New forward static decl.
4651 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4652 Now internal.
4653 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4654 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4655
4656 * editfns.c (Fformat): Remove unreachable code.
4657
4658 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4659
4660 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4661 change. (Bug#8496)
4662
4663 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4664
4665 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4666 when at ZV. (Bug#8487)
4667
4668 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4669
4670 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4671 (Bug#8437)
4672 * keyboard.c (parse_tool_bar_item): Likewise.
4673 * sound.c (sound_cleanup, alsa_close): Likewise.
4674 * termcap.c (tgetent): Likewise.
4675 * xfns.c (x_default_font_parameter): Likewise.
4676 * xsettings.c (read_and_apply_settings): Likewise.
4677
4678 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4679 (overrun_check_free): Protoize.
4680
4681 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4682
4683 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4684 since callers should never pass a negative size.
4685 Change the signature to match that of plain 'read' and 'write'; see
4686 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4687 * lisp.h: Update prototypes of emacs_write and emacs_read.
4688
4689 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4690
4691 * xdisp.c (redisplay_window): Don't try to determine the character
4692 position of the scroll margin if the window start point w->startp
4693 is outside the buffer's accessible region. (Bug#8468)
4694
4695 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4696
4697 Fix write-region and its subroutines for buffers > 2GB.
4698 * fileio.c (a_write, e_write): Modify declaration of arguments and
4699 local variables to support buffers larger than 2GB.
4700 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4701
4702 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4703 argument, local variables, and return value.
4704
4705 * lisp.h: Update prototypes of emacs_write and emacs_read.
4706
4707 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4708
4709 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4710
4711 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4712
4713 Fix more problems found by GCC 4.6.0's static checks.
4714
4715 * xdisp.c (vmessage): Use a better test for character truncation.
4716
4717 * charset.c (load_charset_map): <, not <=, for optimization,
4718 and to avoid potential problems with integer overflow.
4719 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4720 * casetab.c (set_identity, shuffle): Likewise.
4721 * editfns.c (Fformat): Likewise.
4722 * syntax.c (skip_chars): Likewise.
4723
4724 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4725 This also lets GCC 4.6.0 generate slightly better loop code.
4726
4727 * callint.c (Fcall_interactively): <, not <=, for optimization.
4728 (Fcall_interactively): Count the number of arguments produced,
4729 not the number of arguments given. This is simpler and lets GCC
4730 4.6.0 generate slightly better code.
4731
4732 * ftfont.c: Distingish more carefully between FcChar8 and char.
4733 The previous code passed unsigned char * to a functions like
4734 strlen and xstrcasecmp that expect char *, which does not
4735 conform to the C standard.
4736 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4737 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4738 char * when the C standard requires it.
4739
4740 * keyboard.c (read_char): Remove unused var.
4741
4742 * eval.c: Port to Windows vsnprintf (Bug#8435).
4743 Include <limits.h>.
4744 (SIZE_MAX): Define if the headers do not.
4745 (verror): Do not give up if vsnprintf returns a negative count.
4746 Instead, grow the buffer. This ports to Windows vsnprintf, which
4747 does not conform to C99. Problem reported by Eli Zaretskii.
4748 Also, simplify the allocation scheme, by avoiding the need for
4749 calling realloc, and removing the ALLOCATED variable.
4750
4751 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4752
4753 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4754 But keep the doprint source code for now, as we might revamp it
4755 and use it again (Bug#8435).
4756 * lisp.h (doprnt): Remove.
4757 * Makefile.in (base_obj): Remove doprnt.o.
4758 * deps.mk (doprnt.o): Remove.
4759
4760 error: Print 32- and 64-bit integers portably (Bug#8435).
4761 Without this change, on typical 64-bit hosts error ("...%d...", N)
4762 was used to print both 32- and 64-bit integers N, which relied on
4763 undefined behavior.
4764 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4765 New macro.
4766 * lisp.h (error, verror): Mark as printf-like functions.
4767 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4768 Report overflow in size calculations when allocating printf buffer.
4769 Do not truncate output string at its first null byte.
4770 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4771 Truncate the output at a character boundary, since vsnprintf does not
4772 do that.
4773 * charset.c (check_iso_charset_parameter): Convert internal
4774 character to string before calling 'error', since %c now has the
4775 printf meaning.
4776 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4777 overflow when computing char to be passed to 'error'. Do not
4778 pass Lisp_Object to 'error'; pass the integer instead.
4779 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4780 formatted with plain %d.
4781
4782 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4783
4784 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4785
4786 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4787
4788 * xterm.c (x_catch_errors): Remove duplicate declaration.
4789
4790 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4791
4792 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4793
4794 2011-04-10 Jim Meyering <meyering@redhat.com>
4795
4796 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4797 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4798 return ssize_t not "int", and use size_t as the buffer length.
4799 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4800 * gnutls.h: Update declarations.
4801 * process.c (read_process_output): Use ssize_t, to match.
4802 (send_process): Likewise.
4803
4804 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4805
4806 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4807
4808 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4809
4810 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4811 Use unsigned char, to match FcChar8 type definition.
4812
4813 * xterm.c (handle_one_xevent):
4814 * xmenu.c (create_and_show_popup_menu):
4815 * xselect.c (x_decline_selection_request)
4816 (x_reply_selection_request): Avoid type-punned deref of X events.
4817
4818 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4819
4820 Fix some uses of `int' instead of EMACS_INT.
4821 * search.c (string_match_1, fast_string_match)
4822 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4823 (scan_buffer, find_next_newline_no_quit)
4824 (find_before_next_newline, search_command, Freplace_match)
4825 (Fmatch_data): Make some `int' variables be EMACS_INT.
4826
4827 * xdisp.c (display_count_lines): 3rd argument and return value now
4828 EMACS_INT. All callers changed.
4829 (pint2hrstr): Last argument is now EMACS_INT.
4830
4831 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4832 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4833 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4834 (decode_coding_utf_16, decode_coding_emacs_mule)
4835 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4836 (decode_coding_ccl, decode_coding_charset)
4837 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4838 (decode_coding_iso_2022, decode_coding_emacs_mule)
4839 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4840 <char_offset, last_offset>: Declare EMACS_INT.
4841 (encode_coding_utf_8, encode_coding_utf_16)
4842 (encode_coding_emacs_mule, encode_invocation_designation)
4843 (encode_designation_at_bol, encode_coding_iso_2022)
4844 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4845 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4846 Declare EMACS_INT.
4847 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4848 (encode_invocation_designation): Last argument P_NCHARS is now
4849 EMACS_INT.
4850 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4851 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4852
4853 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4854 All users changed.
4855
4856 * ccl.c (Fccl_execute_on_string): Declare some variables
4857 EMACS_INT.
4858
4859 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4860
4861 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4862
4863 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4864
4865 * process.c (Fformat_network_address): Doc fix.
4866
4867 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4868
4869 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4870
4871 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4872
4873 * keyboard.c (read_char): Call Lisp function help-form-show,
4874 instead of using internal_with_output_to_temp_buffer.
4875 (Qhelp_form_show): New var.
4876 (syms_of_keyboard): Use DEFSYM macro.
4877
4878 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4879
4880 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4881
4882 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4883
4884 * process.c (Flist_processes): Remove to Lisp.
4885 (list_processes_1): Delete.
4886
4887 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4888
4889 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4890
4891 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4892
4893 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4894
4895 Fix more problems found by GCC 4.6.0's static checks.
4896
4897 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4898
4899 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4900
4901 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4902
4903 * xdisp.c (vmessage): Mark as a printf-like function.
4904
4905 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4906
4907 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4908
4909 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4910 printf-like functions.
4911 (tiff_load): Add casts to remove these marks before passing them
4912 to system-supplied API.
4913
4914 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4915
4916 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4917 This avoids several warnings with gcc -Wstrict-overflow.
4918 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4919 directly, rather than having caller test rule sign. This avoids
4920 some unnecessary tests.
4921 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4922 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4923 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4924
4925 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4926 (xfont_open): Avoid unnecessary tests.
4927
4928 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4929
4930 * composite.h, composite.c (composition_gstring_put_cache):
4931 Use EMACS_INT, not int, for length.
4932
4933 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4934 breaking out part of COMPOSITION_DECODE_RULE.
4935 (COMPOSITION_DECODE_RULE): Use it.
4936 * composite.c (get_composition_id): Remove unused local vars,
4937 by using the new macro.
4938
4939 * textprop.c (set_text_properties_1): Change while to do-while,
4940 since the condition is always true at first.
4941
4942 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4943 (interval_deletion_adjustment): Return unsigned value.
4944 All uses changed.
4945
4946 * process.c (list_processes_1, create_pty, read_process_output):
4947 (exec_sentinel): Remove vars that were set but not used.
4948 (create_pty): Remove unnecessary "volatile"s.
4949 (Fnetwork_interface_info): Avoid possibility of int overflow.
4950 (read_process_output): Do adaptive read buffering even if carryover.
4951 (read_process_output): Simplify nbytes computation if buffered.
4952
4953 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4954
4955 * syntax.c (scan_words): Remove var that was set but not used.
4956 (update_syntax_table): Use unsigned instead of int.
4957
4958 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4959 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4960 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4961
4962 * print.c (print_error_message): Avoid int overflow.
4963
4964 * font.c (font_list_entities): Redo for clarity,
4965 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4966
4967 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
4968 (font_score): Avoid potential overflow in diff calculation.
4969
4970 * fns.c (substring_both): Remove var that is set but not used.
4971 (sxhash): Redo loop for clarity and to avoid wraparound warning.
4972
4973 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4974
4975 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4976 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4977 can always succeed if overflow has undefined behavior.
4978
4979 * search.c (boyer_moore, wordify): Remove vars set but not used.
4980 (wordify): Omit three unnecessary tests.
4981
4982 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4983 All callers changed. This avoids the need for an unused var.
4984
4985 * casefiddle.c (casify_region): Remove var that is set but not used.
4986
4987 * dired.c (file_name_completion): Remove var that is set but not used.
4988
4989 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4990
4991 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
4992 (Finsert_file_contents): Remove unnecessary code checking fd.
4993
4994 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4995 Check for integer overflow on size calculations.
4996
4997 * buffer.c (Fprevious_overlay_change): Remove var that is set
4998 but not used.
4999
5000 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5001 Remove vars that are set but not used.
5002 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5003 (timer_check_2): Mark vars as initialized.
5004
5005 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5006
5007 * image.c (lookup_image): Remove var that is set but not used.
5008 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5009
5010 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5011 that are set but not used.
5012
5013 * xfns.c (make_invisible_cursor): Don't return garbage
5014 if XCreateBitmapFromData fails (Bug#8410).
5015
5016 * xselect.c (x_get_local_selection, x_handle_property_notify):
5017 Remove vars that are set but not used.
5018
5019 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5020 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5021
5022 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5023 Remove var that is set but not used.
5024 (scroll_bar_windows_size): Now size_t, not int.
5025 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5026 Check for overflow.
5027
5028 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5029 (map_tty_color) [!defined MSDOS]: Likewise.
5030
5031 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5032
5033 * coding.c: Remove vars that are set but not used.
5034 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5035 All callers changed.
5036 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5037 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5038 (decode_coding_charset): Remove vars that are set but not used.
5039
5040 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5041 that is set but not used.
5042
5043 * print.c (print_object): Remove var that is set but not used.
5044
5045 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5046 The gnulib version avoids calling malloc in the usual case,
5047 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5048 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5049 * filelock.c (current_lock_owner): Likewise.
5050 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5051 * sysdep.c: Include allocator.h, careadlinkat.h.
5052 (emacs_no_realloc_allocator): New static constant.
5053 (emacs_readlink): New function.
5054 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5055 ../lib/careadlinkat.h.
5056
5057 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5058
5059 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5060 first non-nil return value).
5061
5062 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5063
5064 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5065 if not defined (Bug#8403).
5066
5067 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5068
5069 * xdisp.c (display_count_lines): Remove parameter `start',
5070 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5071 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5072 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5073 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5074 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5075 and thereabouts. All callers changed.
5076 (get_per_char_metric): Remove parameter `f', unused since
5077 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5078
5079 2011-04-02 Jim Meyering <meyering@redhat.com>
5080
5081 do not dereference NULL upon failed strdup
5082 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5083 (ns_get_family): Likewise.
5084
5085 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5086
5087 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5088
5089 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5090
5091 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5092 later (Bug#8403).
5093
5094 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5095
5096 Add lexical binding.
5097
5098 * window.c (Ftemp_output_buffer_show): New fun.
5099 (Fsave_window_excursion):
5100 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5101
5102 * lread.c (lisp_file_lexically_bound_p): New function.
5103 (Fload): Bind Qlexical_binding.
5104 (readevalloop): Remove `evalfun' arg.
5105 Bind Qinternal_interpreter_environment.
5106 (Feval_buffer): Bind Qlexical_binding.
5107 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5108 Mark as dynamic.
5109 (syms_of_lread): Declare `lexical-binding'.
5110
5111 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5112
5113 * keyboard.c (eval_dyn): New fun.
5114 (menu_item_eval_property): Use it.
5115
5116 * image.c (parse_image_spec): Use Ffunctionp.
5117
5118 * fns.c (concat, mapcar1): Accept byte-code-functions.
5119
5120 * eval.c (Fsetq): Handle lexical vars.
5121 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5122 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5123 (FletX, Flet): Obey lexical binding.
5124 (Fcommandp): Handle closures.
5125 (Feval): New `lexical' arg.
5126 (eval_sub): New function extracted from Feval. Use it almost
5127 everywhere where Feval was used. Look up vars in lexical env.
5128 Handle closures.
5129 (Ffunctionp): Move from subr.el.
5130 (Ffuncall): Handle closures.
5131 (apply_lambda): Remove `eval_flags'.
5132 (funcall_lambda): Handle closures and new byte-code-functions.
5133 (Fspecial_variable_p): New function.
5134 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5135 but without exporting it to Lisp.
5136
5137 * doc.c (Fdocumentation, store_function_docstring):
5138 * data.c (Finteractive_form): Handle closures.
5139
5140 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5141 interactive spec.
5142
5143 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5144 New byte-codes.
5145 (exec_byte_code): New function extracted from Fbyte_code to handle new
5146 calling convention for byte-code-functions. Add new byte-codes.
5147
5148 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5149
5150 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5151
5152 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5153
5154 * xdisp.c (redisplay_internal): Fix prototype.
5155
5156 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5157
5158 * xdisp.c (SCROLL_LIMIT): New macro.
5159 (try_scrolling): Use it when setting scroll_limit.
5160 Limit scrolling to 100 screen lines.
5161 (redisplay_window): Even when falling back on "recentering",
5162 position point in the window according to scroll-conservatively,
5163 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5164
5165 (try_scrolling): When point is above the window, allow searching
5166 as far as scroll_max, or one screenful, to compute vertical
5167 distance from PT to the scroll margin position. This prevents
5168 try_scrolling from unnecessarily failing when
5169 scroll-conservatively is set to a value slightly larger than the
5170 window height. Clean up the case of PT below the margin at bottom
5171 of window: scroll_max can no longer be INT_MAX. When aggressive
5172 scrolling is in use, don't let point enter the opposite scroll
5173 margin as result of the scroll.
5174 (syms_of_xdisp) <scroll-conservatively>: Document the
5175 threshold of 100 lines for never-recentering scrolling.
5176
5177 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5178
5179 * dispextern.h (move_it_by_lines):
5180 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5181 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5182 (message_log_check_duplicate): Remove parameters `prev_bol' and
5183 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5184 (redisplay_internal): Remove parameter `preserve_echo_area',
5185 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5186
5187 * indent.c (Fvertical_motion):
5188 * window.c (window_scroll_pixel_based, Frecenter):
5189 Don't pass `need_y_p' to `move_it_by_lines'.
5190
5191 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5192
5193 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5194 steal a few bits to be more compact.
5195 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5196 Remove unneeded casts.
5197
5198 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5199
5200 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5201
5202 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5203 binding" message (bug#7967).
5204
5205 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5206
5207 Fix more problems found by GCC 4.6.0's static checks.
5208
5209 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5210 Remove unused local var.
5211
5212 * editfns.c (Fmessage_box): Remove unused local var.
5213
5214 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5215 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5216 Omit unused local vars.
5217 * window.c (shrink_windows): Omit unused local var.
5218 * menu.c (digest_single_submenu): Omit unused local var.
5219 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5220 Omit unused local var.
5221
5222 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5223 Don't assume string length fits in int.
5224 (keyremap_step, read_key_sequence): Use size_t for sizes.
5225 (read_key_sequence): Don't check last_real_key_start redundantly.
5226
5227 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5228 instead of alloca (Bug#8344).
5229
5230 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5231 (Fbacktrace_frame): Don't assume nframes fits in int.
5232
5233 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5234
5235 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5236 concerns.
5237
5238 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5239
5240 * cm.c (calccost): Turn while-do into do-while, for clarity.
5241
5242 * keyboard.c (syms_of_keyboard): Use the same style as later
5243 in this function when indexing through an array. This also
5244 works around GCC bug 48267.
5245
5246 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5247
5248 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5249
5250 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5251 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5252
5253 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5254 This avoids undefined behavior on integer overflow, and is a bit
5255 more convenient anyway since it is compared to a size_t variable.
5256
5257 Variadic C functions now count arguments with size_t, not int.
5258 This avoids an unnecessary limitation on 64-bit machines, which
5259 caused (substring ...) to crash on large vectors (Bug#8344).
5260 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5261 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5262 All variadic functions and their callers changed accordingly.
5263 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5264 * data.c (arith_driver, float_arith_driver): Likewise.
5265 * editfns.c (general_insert_function): Likewise.
5266 * eval.c (struct backtrace.nargs, interactive_p)
5267 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5268 (funcall_lambda, mark_backtrace): Likewise.
5269 * fns.c (concat): Likewise.
5270 * frame.c (x_set_frame_parameters): Likewise.
5271 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5272 0 if not found, not -1. All callers changed.
5273
5274 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5275 (stack_copy_size): Now size_t, not int.
5276 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5277
5278 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5279
5280 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5281 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5282 All callers changed.
5283
5284 * lisp.h (multibyte_char_to_unibyte):
5285 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5286 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5287 * character.h (CHAR_TO_BYTE8):
5288 * cmds.c (internal_self_insert):
5289 * editfns.c (general_insert_function):
5290 * keymap.c (push_key_description):
5291 * search.c (Freplace_match):
5292 * xdisp.c (message_dolog, set_message_1): All callers changed.
5293
5294 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5295
5296 * keyboard.c (safe_run_hook_funcall): New function.
5297 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5298 don't set the hook to nil, but remove the offending function instead.
5299 (Qcommand_hook_internal): Remove, unused.
5300 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5301 Vcommand_hook_internal.
5302
5303 * eval.c (enum run_hooks_condition): Remove.
5304 (funcall_nil, funcall_not): New functions.
5305 (run_hook_with_args): Call each function through a `funcall' argument.
5306 Remove `cond' argument, now redundant.
5307 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5308 (Frun_hook_with_args_until_failure): Adjust accordingly.
5309 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5310
5311 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5312
5313 * dispextern.h (string_buffer_position): Remove declaration.
5314
5315 * print.c (strout): Remove parameter `multibyte', unused since
5316 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5317
5318 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5319 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5320 All callers changed.
5321
5322 * w32.c (_wsa_errlist): Use braces for struct initializers.
5323
5324 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5325 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5326 All callers changed.
5327 (string_buffer_position): Likewise. Also, make static (it's never
5328 used outside xdisp.c).
5329 (cursor_row_p): Remove parameter `w', unused since
5330 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5331 (decode_mode_spec): Remove parameter `precision', introduced during
5332 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5333 All callers changed.
5334
5335 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5336
5337 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5338
5339 2011-03-27 Anders Lindgren <andlind@gmail.com>
5340
5341 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5342 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5343 (ns_update_auto_hide_menu_bar): New functions.
5344 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5345 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5346 ns_constrain_all_frames.
5347 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5348 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5349
5350 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5351
5352 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5353
5354 2011-03-27 Glenn Morris <rgm@gnu.org>
5355
5356 * syssignal.h: Replace RETSIGTYPE with void.
5357 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5358 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5359 Replace SIGTYPE with void everywhere.
5360 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5361 * s/template.h (SIGTYPE): Remove commented out definition.
5362
5363 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5364
5365 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5366 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5367
5368 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5369
5370 * w32.c (read_unc_volume): Use parameter `henum', instead of
5371 global variable `wget_enum_handle'.
5372
5373 * keymap.c (describe_vector): Remove parameters `indices' and
5374 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5375 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5376
5377 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5378
5379 * keyboard.c (timer_check): Remove parameter `do_it_now',
5380 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5381 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5382 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5383
5384 * keyboard.c (read_char):
5385 * w32menu.c (w32_menu_display_help):
5386 * xmenu.c (show_help_event, menu_help_callback):
5387 Adjust calls to `show_help_echo'.
5388
5389 * gtkutil.c (xg_maybe_add_timer):
5390 * keyboard.c (readable_events):
5391 * process.c (wait_reading_process_output):
5392 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5393
5394 * insdel.c (adjust_markers_gap_motion):
5395 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5396 (gap_left, gap_right): Don't call it.
5397
5398 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5399
5400 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5401 incurred during fontification.
5402
5403 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5404
5405 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5406 (DEFVAR_PER_BUFFER): Don't pass it.
5407
5408 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5409 (scrolling_window): Don't pass it.
5410
5411 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5412
5413 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5414
5415 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5416 and `suffix'.
5417 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5418 of variables specific to SELinux and computation of `encoded_absname'.
5419
5420 * image.c (XPutPixel): Remove unused variable `height'.
5421
5422 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5423
5424 * unexw32.c (get_section_info): Remove unused variable `section'.
5425
5426 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5427 (system_process_attributes): Remove unused variable `sess'.
5428 (sys_read): Remove unused variable `err'.
5429
5430 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5431 (w32_wnd_proc): Remove unused variable `isdead'.
5432 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5433 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5434 (x_create_tip_frame): Remove unused variable `tem'.
5435
5436 * w32inevt.c (w32_console_read_socket):
5437 Remove unused variable `no_events'.
5438
5439 * w32term.c (x_draw_composite_glyph_string_foreground):
5440 Remove unused variable `width'.
5441
5442 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5443
5444 * w32term.c (x_set_glyph_string_clipping):
5445 Don't pass uninitialized region to CombineRgn.
5446
5447 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5448
5449 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5450 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5451 (Fx_close_connection): Remove unused variable `i'.
5452
5453 * w32font.c (w32font_draw): Return number of glyphs.
5454 (w32font_open_internal): Remove unused variable `i'.
5455 (w32font_driver): Add missing initializer.
5456
5457 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5458 (fill_in_menu): Remove unused variable `items_added'.
5459
5460 * w32term.c (last_mouse_press_frame): Remove static global variable.
5461 (w32_clip_to_row): Remove unused variable `f'.
5462 (x_delete_terminal): Remove unused variable `i'.
5463
5464 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5465 (NOTHING): Remove unused static global variable.
5466 (uniscribe_check_otf): Remove unused variable `table'.
5467 (uniscribe_font_driver): Add missing initializers.
5468
5469 2011-03-23 Julien Danjou <julien@danjou.info>
5470
5471 * term.c (Fsuspend_tty, Fresume_tty):
5472 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5473 * window.c (temp_output_buffer_show):
5474 * insdel.c (signal_before_change):
5475 * frame.c (Fhandle_switch_frame):
5476 * fileio.c (Fdo_auto_save):
5477 * emacs.c (Fkill_emacs):
5478 * editfns.c (save_excursion_restore):
5479 * cmds.c (internal_self_insert):
5480 * callint.c (Fcall_interactively):
5481 * buffer.c (Fkill_all_local_variables):
5482 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5483 Use Frun_hooks.
5484 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5485 unconditionnaly since it does the check itself.
5486
5487 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5488
5489 Fix more problems found by GCC 4.5.2's static checks.
5490
5491 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5492 the first time through the loop, since we know p0 < p1 then.
5493 This also avoids a gcc -Wstrict-overflow warning.
5494
5495 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5496 leading to a memory leak, possible in functions like
5497 load_charset_map_from_file that can allocate an unbounded number
5498 of objects (Bug#8318).
5499
5500 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5501 that could (at least in theory) be that large.
5502
5503 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5504 This is less likely to overflow, and avoids undefined behavior if
5505 overflow does occur. All callers changed. Use strtoul to scan
5506 for the unsigned long integer.
5507 (pint2hrstr): Simplify and tune code slightly.
5508 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5509
5510 * scroll.c (do_scrolling): Work around GCC bug 48228.
5511 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5512
5513 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5514 This also avoids a warning with gcc -Wstrict-overflow.
5515 (validate_x_resource_name): Simplify count usage.
5516 This also avoids a warning with gcc -Wstrict-overflow.
5517
5518 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5519 fail (Bug#8306).
5520
5521 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5522
5523 * process.c (Fmake_network_process): Use socklen_t, not int,
5524 where POSIX says socklen_t is required in portable programs.
5525 This fixes a porting bug on hosts like 64-bit HP-UX, where
5526 socklen_t is wider than int (Bug#8277).
5527 (Fmake_network_process, server_accept_connection):
5528 (wait_reading_process_output, read_process_output):
5529 Likewise.
5530
5531 * process.c: Rename or move locals to avoid shadowing.
5532 (list_processes_1, Fmake_network_process):
5533 (read_process_output_error_handler, exec_sentinel_error_handler):
5534 Rename or move locals.
5535 (Fmake_network_process): Define label "retry_connect" only if needed.
5536 (Fnetwork_interface_info): Fix pointer signedness.
5537 (process_send_signal): Add cast to avoid pointer signedness problem.
5538 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5539 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5540
5541 Make tparam.h and terminfo.c consistent.
5542 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5543 Include tparam.h instead, since it declares them.
5544 * cm.h (PC): Remove extern decl; tparam.h now does this.
5545 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5546 * terminfo.c: Include tparam.h, to check interfaces.
5547 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5548 (tparam): Adjust signature to match interface in tparam.h;
5549 this removes some undefined behavior. Check that outstring and len
5550 are zero, which they always are with Emacs.
5551 * tparam.h (PC, BC, UP): New extern decls.
5552
5553 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5554 (xftfont_open): Rename locals to avoid shadowing.
5555
5556 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5557 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5558 (OTF_TAG_SYM): Omit macro if not needed.
5559 (ftfont_list): Remove unused local.
5560 (get_adstyle_property, ftfont_pattern_entity):
5561 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5562 Rename locals to avoid shadowing.
5563
5564 * xfont.c (xfont_list_family): Mark var as initialized.
5565
5566 * xml.c (make_dom): Now static.
5567
5568 * composite.c (composition_compute_stop_pos): Rename local to
5569 avoid shadowing.
5570 (composition_reseat_it): Remove unused locals.
5571 (find_automatic_composition, composition_adjust_point): Likewise.
5572 (composition_update_it): Mark var as initialized.
5573 (find_automatic_composition): Mark vars as initialized,
5574 with a FIXME (Bug#8290).
5575
5576 character.h: Rename locals to avoid shadowing.
5577 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5578 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5579 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5580 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5581 to avoid shadowing.
5582
5583 * textprop.c (property_change_between_p): Remove; unused.
5584
5585 * intervals.c (interval_start_pos): Now static.
5586
5587 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5588
5589 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5590 Rename locals to avoid shadowing.
5591
5592 * sound.c (wav_play, au_play, Fplay_sound_internal):
5593 Fix pointer signedness.
5594 (alsa_choose_format): Remove unused local var.
5595 (wav_play): Initialize a variable to 0, to prevent undefined
5596 behavior (Bug#8278).
5597
5598 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5599
5600 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5601
5602 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5603 clobbering (Bug#8298).
5604 * sysdep.c (sys_subshell): Likewise.
5605 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5606
5607 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5608 This should get cleaned up, so that child_setup has the
5609 same signature on all platforms.
5610
5611 * callproc.c (call_process_cleanup): Now static.
5612 (relocate_fd): Rename locals to avoid shadowing.
5613
5614 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5615
5616 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5617 not to be necessary, and produces flickering.
5618
5619 2011-03-20 Glenn Morris <rgm@gnu.org>
5620
5621 * config.in: Remove file.
5622
5623 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5624
5625 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5626 are now in src/globals.h.
5627 (syms_of_minibuf): Remove spurious & from previous change.
5628
5629 2011-03-20 Leo <sdl.web@gmail.com>
5630
5631 * minibuf.c (completing-read-function): New variable.
5632 (completing-read-default): Rename from completing-read.
5633 (completing-read): Call completing-read-function.
5634
5635 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5636
5637 * xfaces.c (Fx_load_color_file):
5638 Read color file from absolute filename (bug#8250).
5639
5640 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5641
5642 * makefile.w32-in: Update dependencies.
5643
5644 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5645
5646 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5647
5648 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5649
5650 Fix more problems found by GCC 4.5.2's static checks.
5651
5652 * process.c (make_serial_process_unwind, send_process_trap):
5653 (sigchld_handler): Now static.
5654
5655 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5656 That way, the code declares only the vars that it needs.
5657 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5658 * s/cygwin.h (PTY_ITERATION): Likewise.
5659 * s/darwin.h (PTY_ITERATION): Likewise.
5660 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5661
5662 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5663 * process.c (allocate_pty): Don't declare stb unless it's needed.
5664
5665 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5666 (CONSTANTLIM): Remove; unused.
5667 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5668 Define only if needed.
5669
5670 * unexelf.c (unexec): Name an expression,
5671 to avoid gcc -Wbad-function-cast warning.
5672 Use a different way to cause a compilation error if anyone uses
5673 n rather than nn, a way that does not involve shadowing.
5674 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5675
5676 * deps.mk (unexalpha.o): Remove; unused.
5677
5678 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5679 * unexec.h: New file.
5680 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5681 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5682 Depend on unexec.h.
5683 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5684 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5685 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5686 Change as necessary to match prototype in unexec.h.
5687
5688 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5689 shadowing.
5690 (back_comment, skip_chars): Mark vars as initialized.
5691
5692 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5693 Rename locals to avoid shadowing.
5694
5695 * lread.c (read1): Rewrite so as not to use empty "else".
5696 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5697
5698 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5699
5700 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5701 warning when compiling print.c.
5702
5703 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5704 instead of using an uninitialized var.
5705 (font_sort_entities): Mark var as initialized.
5706
5707 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5708
5709 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5710 pointers to constants.
5711 (font_parse_fcname): Remove unused vars.
5712 (font_delete_unmatched): Now static.
5713 (font_get_spec): Remove; unused.
5714 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5715 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5716 Rename or move locals to avoid shadowing.
5717
5718 * fns.c (require_nesting_list, require_unwind): Now static.
5719 (Ffillarray): Rename locals to avoid shadowing.
5720
5721 * floatfns.c (domain_error2): Define only if needed.
5722 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5723
5724 * alloc.c (mark_backtrace): Move decl from here ...
5725 * lisp.h: ... to here, so that it can be checked.
5726
5727 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5728 (Fdefvar): Rewrite so as not to use empty "else".
5729 (lisp_indirect_variable): Name an expression,
5730 to avoid gcc -Wbad-function-cast warning.
5731 (Fdefvar): Rename locals to avoid shadowing.
5732
5733 * callint.c (quotify_arg, quotify_args): Now static.
5734 (Fcall_interactively): Rename locals to avoid shadowing.
5735 Use const pointer when appropriate.
5736
5737 * lisp.h (get_system_name, get_operating_system_release):
5738 Move decls here, to check interfaces.
5739 * process.c (get_operating_system_release): Move decl to lisp.h.
5740 * xrdb.c (get_system_name): Likewise.
5741 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5742 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5743 some of which prompt warnings from gcc -Wbad-function-cast.
5744 (Fformat_time_string, Fencode_time, Finsert_char):
5745 (Ftranslate_region_internal, Fformat):
5746 Rename or remove local vars to avoid shadowing.
5747 (Ftranslate_region_internal): Mark var as initialized.
5748
5749 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5750 avoid shadowing.
5751
5752 * lisp.h (eassert): Check that the argument compiles, even if
5753 ENABLE_CHECKING is not defined.
5754
5755 * data.c (Findirect_variable): Name an expression, to avoid
5756 gcc -Wbad-function-cast warning.
5757 (default_value, arithcompare, arith_driver, arith_error): Now static.
5758 (store_symval_forwarding): Rename local to avoid shadowing.
5759 (Fmake_variable_buffer_local, Fmake_local_variable):
5760 Mark variables as initialized.
5761 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5762
5763 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5764 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5765 Rename locals to avoid shadowing.
5766 (mark_stack): Move local variables into the #ifdef region where
5767 they're used.
5768 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5769 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5770 needed otherwise.
5771 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5772 (GC_STRING_CHARS): Remove; not used.
5773 (Fmemory_limit): Cast sbrk's returned value to char *.
5774
5775 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5776 avoids undefined behavior in theory.
5777
5778 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5779
5780 Use functions, not macros, for up- and down-casing (Bug#8254).
5781 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5782 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5783 to use the following functions instead of these macros.
5784 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5785 EMACS_INT, since callers assume the returned value fits in int.
5786 (upcase1): Likewise, for UPCASE_TABLE.
5787 (uppercasep, lowercasep, upcase): New static inline functions.
5788 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5789 the race-condition problem in the old DOWNCASE.
5790
5791 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5792 Rename locals to avoid shadowing.
5793 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5794 (regex_compile, re_search_2, re_match_2_internal):
5795 Remove unused local vars.
5796 (FREE_VAR): Rewrite so as not to use empty "else",
5797 which gcc can warn about.
5798 (regex_compile, re_match_2_internal): Mark locals as initialized.
5799 (RETALLOC_IF): Define only if needed.
5800 (WORDCHAR_P): Likewise. This one is never needed, but is used
5801 only in a comment talking about a compiler bug, so put inside
5802 the #if 0 of that comment.
5803 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5804 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5805 Remove; unused.
5806
5807 * search.c (boyer_moore): Rename locals to avoid shadowing.
5808 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5809 (PREV_CHAR_BOUNDARY): Likewise.
5810
5811 * search.c (simple_search): Remove unused var.
5812
5813 * dired.c (compile_pattern): Move decl from here ...
5814 * lisp.h: ... to here, so that it can be checked.
5815 (struct re_registers): New forward decl.
5816
5817 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5818
5819 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5820 All uses changed.
5821 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5822 Rename locals to avoid shadowing.
5823 (Fvertical_motion): Mark locals as initialized.
5824
5825 * casefiddle.c (casify_object, casify_region): Now static.
5826 (casify_region): Mark local as initialized.
5827
5828 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5829
5830 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5831 New macros, so that the caller can use some names other than
5832 gcpro1, gcpro2, etc.
5833 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5834 of the new macros.
5835 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5836 argument, for consistency with GCPRO2_VAR, etc: it is now the
5837 prefix of the variable, not the variable itself. All uses
5838 changed.
5839 * dired.c (directory_files_internal, file_name_completion):
5840 Rename locals to avoid shadowing.
5841
5842 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5843 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5844 dired.c's scmp function, had undefined behavior.
5845 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5846 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5847 * buffer.h: ... to here, because these macros use current_buffer,
5848 and the new implementation with inline functions needs to have
5849 current_buffer in scope now, rather than later when the macros
5850 are used.
5851 (downcase, upcase1): New static inline functions.
5852 (DOWNCASE, UPCASE1): Reimplement using these functions.
5853 This avoids undefined behavior in expressions like
5854 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5855 from race conditions in accessing the global variables
5856 case_temp1 and case_temp2.
5857 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5858 * lisp.h (case_temp1, case_temp2): Remove their decls.
5859 * character.h (ASCII_CHAR_P): Move from here ...
5860 * lisp.h: ... to here, so that the inline functions mentioned
5861 above can use them.
5862
5863 * dired.c (directory_files_internal_unwind): Now static.
5864
5865 * fileio.c (file_name_as_directory, directory_file_name):
5866 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5867 Now static.
5868 (file_name_as_directory): Use const pointers when appropriate.
5869 (Fexpand_file_name): Likewise. In particular, newdir might
5870 point at constant storage, so make it a const pointer.
5871 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5872 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5873 signedness issues.
5874 (Fset_file_times, Finsert_file_contents, auto_save_error):
5875 Rename locals to avoid shadowing.
5876
5877 * minibuf.c (choose_minibuf_frame_1): Now static.
5878 (Ftry_completion, Fall_completions): Rename or remove locals
5879 to avoid shadowing.
5880
5881 * marker.c (bytepos_to_charpos): Remove; unused.
5882
5883 * lisp.h (verify_bytepos, count_markers): New decls,
5884 so that gcc does not warn that these functions aren't declared.
5885
5886 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5887 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5888 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5889 (copy_text): Remove unused local var.
5890
5891 * filelock.c (within_one_second): Now static.
5892 (lock_file_1): Rename local to avoid shadowing.
5893
5894 * buffer.c (fix_overlays_before): Mark locals as initialized.
5895 (fix_start_end_in_overlays): Likewise. This function should be
5896 simplified by using pointers-to-pointers, but that's a different
5897 matter.
5898 (switch_to_buffer_1): Now static.
5899 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5900 (report_overlay_modification): Rename locals to avoid shadowing.
5901
5902 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5903 Fix pointer signedness issue.
5904 (sys_subshell): Mark local as volatile if checking for lint,
5905 to suppress a gcc -Wclobbered warning that does not seem to be right.
5906 (MAXPATHLEN): Define only if needed.
5907
5908 * process.c (serial_open, serial_configure): Move decls from here ...
5909 * systty.h: ... to here, so that they can be checked.
5910
5911 * fns.c (get_random, seed_random): Move extern decls from here ...
5912 * lisp.h: ... to here, so that they can be checked.
5913
5914 * sysdep.c (reset_io): Now static.
5915 (wait_for_termination_signal): Remove; unused.
5916
5917 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5918 (copy_keymap_item, append_key, push_text_char_description):
5919 Now static.
5920 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5921 (DENSE_TABLE_SIZE): Remove; unused.
5922 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5923 (describe_map_tree):
5924 Rename locals to avoid shadowing.
5925
5926 * keyboard.c: Declare functions static if they are not used elsewhere.
5927 (echo_char, echo_dash, cmd_error, top_level_2):
5928 (poll_for_input, handle_async_input): Now static.
5929 (read_char, kbd_buffer_get_event, make_lispy_position):
5930 (make_lispy_event, make_lispy_movement, apply_modifiers):
5931 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5932 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5933 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5934 (read_key_sequence, read_char): Mark locals as initialized.
5935 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5936
5937 * keyboard.h (make_ctrl_char): New decl.
5938 (mark_kboards): Move decl here ...
5939 * alloc.c (mark_kboards): ... from here.
5940
5941 * lisp.h (force_auto_save_soon): New decl.
5942
5943 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5944 (DEFINE_DUMMY_FUNCTION): New macro.
5945 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5946 Use it.
5947 (main): Add casts to avoid warnings
5948 if GCC considers string literals to be constants.
5949
5950 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5951
5952 * dbusbind.c: Pointer signedness fixes.
5953 (xd_signature, xd_append_arg, xd_initialize):
5954 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5955 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5956 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5957 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5958
5959 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5960 if GCC considers string literals to be constants.
5961 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5962
5963 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5964
5965 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5966 (print_preprocess, print_object): New macro to fix last change.
5967
5968 * print.c (print_preprocess): Don't forget font objects.
5969
5970 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
5971
5972 * emacs.c (USAGE3): Doc fixes.
5973
5974 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5975
5976 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5977 structure.
5978
5979 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
5980
5981 * lisp.h (VWindow_system, Qfile_name_history):
5982 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5983 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5984 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5985
5986 * w32select.c: Don't #include "keyboard.h".
5987 (run_protected): Add extern declaration for waiting_for_input.
5988
5989 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5990 * w32console.c (detect_input_pending, read_input_pending)
5991 (encode_terminal_code):
5992 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5993 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5994 (w32_system_caret_y, Qfile_name_history):
5995 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5996 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5997 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5998 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5999 * w32proc.c (Qlocal, report_file_error):
6000 * w32term.c (Vwindow_system, updating_frame):
6001 * w32uniscribe.c (initialized, uniscribe_font_driver):
6002 Remove unneeded extern declarations.
6003
6004 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6005
6006 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6007
6008 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6009
6010 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6011 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6012 These macros can no longer be used for assignment.
6013
6014 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6015 Assign struct members directly, instead of using BUF_BEGV etc.
6016 (record_buffer_markers, fetch_buffer_markers): New functions for
6017 recording and fetching special buffer markers.
6018 (set_buffer_internal_1, set_buffer_temp): Use them.
6019
6020 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6021
6022 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6023
6024 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6025 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6026
6027 * xdisp.c (hscroll_window_tree):
6028 (reconsider_clip_changes): Use PT instead of BUF_PT.
6029
6030 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6031
6032 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6033 $(EMACS_ROOT)/lib/intprops.h.
6034
6035 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6036
6037 Fix more problems found by GCC 4.5.2's static checks.
6038
6039 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6040 to unsigned char * to avoid compiler diagnostic.
6041 (xg_free_frame_widgets): Make it clear that a local variable is
6042 needed only if USE_GTK_TOOLTIP.
6043 (gdk_window_get_screen): Make it clear that this macro is needed
6044 only if USE_GTK_TOOLTIP.
6045 (int_gtk_range_get_value): New function, which avoids a diagnostic
6046 from gcc -Wbad-function-cast.
6047 (xg_set_toolkit_scroll_bar_thumb): Use it.
6048 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6049 diagnostic from gcc -Wbad-function-cast.
6050 (get_utf8_string, xg_get_file_with_chooser):
6051 Rename locals to avoid shadowing.
6052 (create_dialog): Move locals to avoid shadowing.
6053
6054 * xgselect.c (xg_select): Remove unused var.
6055
6056 * image.c (four_corners_best): Mark locals as initialized.
6057 (gif_load): Initialize transparent_p to zero (Bug#8238).
6058 Mark another local as initialized.
6059 (my_png_error, my_error_exit): Mark with NO_RETURN.
6060
6061 * image.c (clear_image_cache): Now static.
6062 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6063 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6064 (x_edge_detection): Remove unnecessary cast that
6065 gcc -Wbad-function-cast diagnoses.
6066 (gif_load): Fix pointer signedness.
6067 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6068 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6069
6070 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6071
6072 Improve quality of tests for time stamp overflow.
6073 For example, without this patch (encode-time 0 0 0 1 1
6074 1152921504606846976) returns the obviously-bogus value (-948597
6075 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6076 reports time overflow. See
6077 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6078 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6079 * editfns.c: Include limits.h and intprops.h.
6080 (TIME_T_MIN, TIME_T_MAX): New macros.
6081 (time_overflow): Move earlier, to before first use.
6082 (hi_time, lo_time): New functions, for an accurate test for
6083 out-of-range times.
6084 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6085 (Fget_internal_run_time): Don't assume time_t fits in int.
6086 (make_time): Use list2 instead of Fcons twice.
6087 (Fdecode_time): More accurate test for out-of-range times.
6088 (check_tm_member): New function.
6089 (Fencode_time): Use it, to test for out-of-range times.
6090 (lisp_time_argument): Don't rely on undefined left-shift and
6091 right-shift behavior when checking for time stamp overflow.
6092
6093 * editfns.c (time_overflow): New function, refactoring common code.
6094 (Fformat_time_string, Fdecode_time, Fencode_time):
6095 (Fcurrent_time_string): Use it.
6096
6097 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6098 * dired.c (make_time): Move to ...
6099 * editfns.c (make_time): ... here.
6100 * systime.h: Note the move.
6101
6102 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6103
6104 * fringe.c (update_window_fringes): Remove unused variables.
6105
6106 * unexmacosx.c (copy_data_segment): Also copy __got section.
6107 (Bug#8223)
6108
6109 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6110
6111 * termcap.c [MSDOS]: Include "msdos.h".
6112 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6113 Constify `char *' arguments and their references according to
6114 prototypes in tparam.h.
6115
6116 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6117
6118 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6119 Adapt all references accordingly.
6120
6121 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6122
6123 2011-03-11 Tom Tromey <tromey@redhat.com>
6124
6125 * buffer.c (syms_of_buffer): Remove obsolete comment.
6126
6127 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6128
6129 * termhooks.h (encode_terminal_code): Declare prototype.
6130
6131 * msdos.c (encode_terminal_code): Don't declare prototype.
6132
6133 * term.c (encode_terminal_code): Now external again, used by
6134 w32console.c and msdos.c.
6135
6136 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6137 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6138
6139 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6140
6141 Fix some minor problems found by GCC 4.5.2's static checks.
6142
6143 * fringe.c (update_window_fringes): Mark locals as initialized
6144 (Bug#8227).
6145 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6146
6147 * alloc.c (mark_fringe_data): Move decl from here ...
6148 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6149 to check its interface.
6150 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6151
6152 * fontset.c (free_realized_fontset): Now static.
6153 (Fset_fontset_font): Rename local to avoid shadowing.
6154 (fontset_font): Mark local as initialized.
6155 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6156
6157 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6158
6159 * xselect.c (x_disown_buffer_selections): Remove; not used.
6160 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6161 (x_own_selection, Fx_disown_selection_internal): Rename locals
6162 to avoid shadowing.
6163 (x_handle_dnd_message): Remove local to avoid shadowing.
6164
6165 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6166 so that the caller can use some name other than gcpro1.
6167 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6168 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6169 (Fx_backspace_delete_keys_p):
6170 Use them to avoid shadowing, and rename vars to avoid shadowing.
6171 (x_decode_color, x_set_name, x_window): Now static.
6172 (Fx_create_frame): Add braces to silence GCC warning.
6173 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6174 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6175 Remove unused locals.
6176 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6177 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6178 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6179 macros.
6180
6181 * xterm.h (x_mouse_leave): New decl.
6182
6183 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6184 Remove unused functions.
6185 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6186 (x_calc_absolute_position): Now static.
6187 (XTread_socket): Don't define label "out" unless it's used.
6188 Don't declare local "event" unless it's used.
6189 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6190 unless they are used.
6191 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6192 (x_fatal_error_signal): Remove; not used.
6193 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6194 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6195 (x_error_catcher, x_connection_closed, x_error_handler):
6196 (x_error_quitter, xembed_send_message, x_iconify_frame):
6197 (my_log_handler): Rename locals to avoid shadowing.
6198 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6199 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6200
6201 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6202 Rename or move locals to avoid shadowing.
6203 (tty_defined_color, merge_face_heights): Now static.
6204 (free_realized_faces_for_fontset): Remove; not used.
6205 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6206 does not deduce is never used uninitialized.
6207 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6208 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6209
6210 * terminal.c (store_terminal_param): Now static.
6211
6212 * xmenu.c (menu_highlight_callback): Now static.
6213 (set_frame_menubar): Remove unused local.
6214 (xmenu_show): Rename parameter to avoid shadowing.
6215 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6216 since they might point to immutable storage.
6217 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6218 since it's unused otherwise.
6219
6220 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6221 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6222 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6223 avoids a gcc -Wuninitialized diagnostic.
6224 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6225 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6226 does not deduce are never used uninitialized.
6227
6228 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6229
6230 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6231 * window.c (window_loop, size_window):
6232 (run_window_configuration_change_hook, enlarge_window): Likewise.
6233
6234 * window.c (display_buffer): Now static.
6235 (size_window): Mark variables that gcc -Wuninitialized
6236 does not deduce are never used uninitialized.
6237 * window.h (check_all_windows): New decl, to forestall
6238 gcc -Wmissing-prototypes diagnostic.
6239 * dispextern.h (bidi_dump_cached_states): Likewise.
6240
6241 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6242 shadowing.
6243 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6244 Include <limits.h>.
6245 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6246 and to avoid gcc -Wuninitialized warning.
6247 (load_charset_map): Mark variables that gcc -Wuninitialized
6248 does not deduce are never used uninitialized.
6249 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6250
6251 * coding.c (coding_set_source, coding_set_destination):
6252 Use "else { /* comment */ }" rather than "else /* comment */;"
6253 for clarity, and to avoid gcc -Wempty-body warning.
6254 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6255 a block, when the outer 'i' will do.
6256 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6257 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6258 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6259 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6260 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6261 Rename locals to avoid shadowing.
6262 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6263 * coding.c (emacs_mule_char, encode_invocation_designation):
6264 Now static, since they're not used elsewhere.
6265 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6266 (decode_coding_object, encode_coding_object, detect_coding_system):
6267 (decode_coding_emacs_mule): Mark variables that gcc
6268 -Wuninitialized does not deduce are never used uninitialized.
6269 (detect_coding_iso_2022): Initialize a local variable that might
6270 be used uninitialized. Leave a FIXME because it's not clear that
6271 this initialization is needed. (Bug#8211)
6272 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6273 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6274 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6275 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6276 Remove unused macros.
6277
6278 * category.c (hash_get_category_set): Remove unused local var.
6279 (copy_category_table): Now static, since it's not used elsewhere.
6280 * character.c (string_count_byte8): Likewise.
6281
6282 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6283 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6284
6285 * chartab.c (copy_sub_char_table): Now static, since it's not used
6286 elsewhere.
6287 (sub_char_table_ref_and_range, char_table_ref_and_range):
6288 Rename locals to avoid shadowing.
6289 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6290
6291 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6292 (BIDI_BOB): Remove unused macro.
6293
6294 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6295 deduce are never used uninitialized.
6296 * term.c (encode_terminal_code): Likewise.
6297
6298 * term.c (encode_terminal_code): Now static. Remove unused local.
6299
6300 * tparam.h: New file.
6301 * term.c, tparam.h: Include it.
6302 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6303 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6304 Move these decls to tparam.h, and make them agree with what
6305 is actually in tparam.c. The previous trick of using incompatible
6306 decls in different modules does not conform to the C standard.
6307 All callers of tparam changed to use tparam's actual API.
6308 * tparam.c (tparam1, tparam, tgoto):
6309 Use const pointers where appropriate.
6310
6311 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6312 * cm.h (struct cm): Likewise.
6313 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6314 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6315 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6316 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6317 (turn_on_face, init_tty): Likewise.
6318 * termchar.h (struct tty_display_info): Likewise.
6319
6320 * term.c (term_mouse_position): Rename local to avoid shadowing.
6321
6322 * alloc.c (mark_ttys): Move decl from here ...
6323 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6324
6325 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6326
6327 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6328
6329 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6330
6331 * search.c (compile_pattern_1): Remove argument regp, unused since
6332 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6333 (compile_pattern): Don't pass it.
6334
6335 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6336
6337 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6338 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6339 for ! HAVE_GTK3.
6340 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6341
6342 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6343
6344 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6345 gdk_window_get_screen, gdk_window_get_geometry,
6346 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6347 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6348 (xg_get_pixbuf_from_pixmap): New function.
6349 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6350 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6351 Call xg_get_pixbuf_from_pixmap instead of
6352 gdk_pixbuf_get_from_drawable.
6353 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6354 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6355 (xg_check_special_colors): Use GtkStyleContext and its functions
6356 for HAVE_GTK3.
6357 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6358 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6359 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6360 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6361 Call gtk_widget_get_preferred_size.
6362 (xg_frame_resized): gdk_window_get_geometry only takes 5
6363 parameters.
6364 (xg_win_to_widget, xg_event_is_for_menubar):
6365 Call gdk_x11_window_lookup_for_display.
6366 (xg_set_widget_bg): New function.
6367 (delete_cb): New function.
6368 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6369 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6370 (xg_set_background_color): Call xg_set_widget_bg.
6371 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6372 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6373 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6374 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6375 if ! HAVE_GTK3.
6376 (update_frame_tool_bar): Call gtk_widget_hide.
6377 (xg_initialize): Use GDK_KEY_g.
6378
6379 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6380 if ! HAVE_GTK3
6381 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6382
6383 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6384 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6385 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6386
6387 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6388
6389 * w32xfns.c (select_palette): Check success of RealizePalette against
6390 GDI_ERROR, not zero.
6391
6392 See ChangeLog.11 for earlier changes.
6393
6394 ;; Local Variables:
6395 ;; coding: utf-8
6396 ;; End:
6397
6398 Copyright (C) 2011 Free Software Foundation, Inc.
6399
6400 This file is part of GNU Emacs.
6401
6402 GNU Emacs is free software: you can redistribute it and/or modify
6403 it under the terms of the GNU General Public License as published by
6404 the Free Software Foundation, either version 3 of the License, or
6405 (at your option) any later version.
6406
6407 GNU Emacs is distributed in the hope that it will be useful,
6408 but WITHOUT ANY WARRANTY; without even the implied warranty of
6409 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6410 GNU General Public License for more details.
6411
6412 You should have received a copy of the GNU General Public License
6413 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.