1 2012-07-12 Glenn Morris <rgm@gnu.org>
3 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4 (BROKEN_SIGPOLL): Let configure set them.
6 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
8 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
9 * s/template.h: Move NARROWPROTO to configure.
11 2012-07-11 Glenn Morris <rgm@gnu.org>
13 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
14 unused since 2011-01-17 change to systty.h.
16 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
17 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
18 Move HAVE_PTYS and HAVE_SOCKETS to configure.
20 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
22 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
24 2012-07-11 Glenn Morris <rgm@gnu.org>
26 * s/darwin.h, s/gnu-linux.h, s/template.h:
27 Move INTERRUPT_INPUT to configure.
29 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
31 Minor adjustments to interning code.
32 * lisp.h (intern, intern_c_string): Redefine as static inline
33 wrappers for intern_1 and intern_c_string_1, respectively.
34 (intern_1, intern_c_string_1): Rename prototypes.
35 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
37 * font.c (font_intern_prop): Likewise. Adjust comment.
38 * w32font.c (intern_font_name): Likewise.
40 2012-07-11 Andreas Schwab <schwab@linux-m68k.org>
42 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
44 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
45 of Fcar/Fcdr if possible.
46 * font.c (check_otf_features): Likewise.
47 * fontset.c (Fnew_fontset): Likewise.
48 * gnutls.c (Fgnutls_boot): Likewise.
49 * minibuf.c (read_minibuf): Likewise.
50 * msdos.c (IT_set_frame_parameters): Likewise.
51 * xmenu.c (Fx_popup_dialog): Likewise.
52 * w32menu.c (Fx_popup_dialog): Likewise.
54 2012-07-11 Glenn Morris <rgm@gnu.org>
56 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
57 since nothing has defined it on these platforms.
59 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
60 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
62 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
63 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
64 Move CLASH_DETECTION to configure.
66 * s/gnu.h: Remove file, which is now empty.
68 * s/gnu.h, s/gnu-linux.h:
69 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
71 2012-07-11 John Wiegley <johnw@newartisans.com>
73 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
74 function attribute, so we only use it if it exists in the
77 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
79 Avoid call to strlen in fast_c_string_match_ignore_case.
80 * search.c (fast_c_string_match_ignore_case): Change to use
81 length argument. Adjust users accordingly.
82 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
84 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
87 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
88 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
91 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
94 * s/hpux10-20.h (HAVE_PERROR): Remove.
95 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
96 Remove dummy definition, as this problem was obsolete long ago.
99 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
101 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
103 Avoid calls to strlen in font processing functions.
104 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
105 (font_open_by_name): Change to use length argument. Adjust
107 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
109 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
110 Change to return ptrdiff_t.
111 (xfont_list_pattern, xfont_match): Use length returned by
112 xfont_decode_coding_xlfd.
113 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
115 2012-07-11 Glenn Morris <rgm@gnu.org>
117 * s/darwin.h, s/freebsd.h, s/netbsd.h:
118 Move DONT_REOPEN_PTY to configure.
120 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
121 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
123 2012-07-10 Paul Eggert <eggert@cs.ucla.edu>
125 Remove "#define unix" that is no longer needed (Bug#11905).
126 * s/aix4-2.h (unix): Remove; no longer needed.
128 EMACS_TIME simplification (Bug#11875).
129 This replaces macros (which typically do not work in GDB)
130 with functions, typedefs and enums, making the code easier to debug.
131 The functional style also makes code easier to read and maintain.
132 * systime.h: Include <sys/time.h> on all hosts, not just if
133 WINDOWSNT, since 'struct timeval' is needed in general.
134 (EMACS_TIME): Now a typedef, not a macro.
135 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
137 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
138 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
139 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
140 (EMACS_TIME_LE): Now functions, not macros.
141 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
142 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
143 which are not functions. All uses rewritten to use:
144 (make_emacs_time): New function.
145 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
146 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
147 not functions. All uses rewritten to use the following, respectively:
148 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
149 (add_emacs_time, sub_emacs_time): New functions.
150 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
151 * fileio.c (Fcopy_file):
152 * xterm.c (XTflash): Get the current time closer to when it's used.
153 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
155 * bytecode.c (targets): Suppress -Woverride-init warnings.
157 Simplify by avoiding confusing use of strncpy etc.
158 * doc.c (Fsnarf_documentation):
159 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
160 * frame.c (Fmake_terminal_frame):
161 * gtkutil.c (get_utf8_string):
163 * nsmenu.m (ns_update_menubar):
164 * regex.c (regerror):
165 Prefer memcpy to strncpy and strncat when either will do.
166 * fileio.c (Fsubstitute_in_file_name):
167 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
168 (menu_separator_name_p):
169 * nsmenu.m (ns_update_menubar):
170 Prefer memcmp to strncmp when either will do.
171 * nsterm.m: Include <ftoastr.h>.
173 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
174 Prefer snprintf to strncpy.
175 * nsterm.m (ns_term_init):
176 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
177 * nsterm.m (ns_term_init):
178 Avoid the need for strncpy, by using build_string or
179 make_unibyte_string directly. Use dtoastr, not snprintf.
180 * process.c (Fmake_network_process): Diagnose service names that
181 are too long, rather than silently truncating them or creating
182 non-null-terminated names.
183 (Fnetwork_interface_info): Likewise, for interface names.
184 * sysdep.c (system_process_attributes) [GNU_LINUX]:
185 Prefer sprintf to strncat.
186 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
187 Prefer vsnprintf to vsprintf + strncpy.
189 2012-07-10 Glenn Morris <rgm@gnu.org>
191 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
192 Clarify fallback case.
194 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
196 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
197 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
198 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
199 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
200 where argument type is known to be a Lisp_Cons.
202 2012-07-10 Tom Tromey <tromey@redhat.com>
204 * bytecode.c (BYTE_CODE_THREADED): New macro.
205 (BYTE_CODES): New macro. Replaces all old byte-code defines.
206 (enum byte_code_op): New type.
207 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
208 (exec_byte_code): Use them. Use token threading when applicable.
210 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
212 Optimize pure C strings initialization.
213 * lisp.h (make_pure_string): Fix prototype.
214 (build_pure_c_string): New function, defined as static inline. This
215 provides a better opportunity to optimize away calls to strlen when
216 the function is called with compile-time constant argument.
217 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
218 argument, adjust users accordingly. Use build_pure_c_string where
220 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
221 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
222 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
224 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
226 Avoid calls to strlen in miscellaneous functions.
227 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
228 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
229 * lread.c (openp): Likewise.
231 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
233 Avoid calls to strlen in path processing functions.
234 * fileio.c (file_name_as_directory): Add comment. Change to add
235 srclen argument and return the length of result. Adjust users
237 (directory_file_name): Fix comment. Change to add srclen argument,
238 swap 1st and 2nd arguments to obey the common convention. Adjust
240 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
242 2012-07-10 Glenn Morris <rgm@gnu.org>
244 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
245 Move PENDING_OUTPUT_COUNT definition to configure.
247 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
248 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
249 * s/gnu.h (DATA_START): Move definitions to configure.
251 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
252 We include usg5-4-common.h, which defines them both.
254 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
255 O_RDONLY already includes it).
257 Stop ns builds setting the EMACSLOADPATH environment variable.
258 * nsterm.m (ns_load_path): Rename from ns_init_paths.
259 Now it does not set EMACSLOADPATH, just returns the load-path string.
260 * nsterm.h: Update accordingly.
261 * lread.c [HAVE_NS]: Include nsterm.h.
262 (init_lread) [HAVE_NS]: Use ns_load_path.
263 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
265 2012-07-09 Glenn Morris <rgm@gnu.org>
267 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
268 since the included bsd-common.h does so.
270 Stop ns builds setting the EMACSPATH environment variable.
271 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
272 (ns_init_paths): Do not set EMACSPATH.
273 * nsterm.h (ns_exec_path): Add it.
274 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
277 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
279 2012-07-09 Paul Eggert <eggert@cs.ucla.edu>
281 * process.c (wait_reading_process_output): 'waitchannels' was unset
282 when read_kbd || !NILP (wait_for_cell); fix this.
284 Add GCC-style 'const' attribute to functions that can use it.
285 * character.h (char_resolve_modifier_mask):
286 * keyboard.h (make_ctrl_char):
287 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
288 (init_character_once, next_almost_prime, init_fns, init_image)
289 (flush_pending_output, init_sound):
290 * mem-limits.h (start_of_data):
291 * menu.h (finish_menu_items):
293 * emacs.c (DEFINE_DUMMY_FUNCTION):
294 Declare the dummy function with ATTRIBUTE_CONST.
295 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
296 Add decls with ATTRIBUTE_CONST.
298 Minor improvements to make_formatted_string.
299 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
300 where int is good enough, as vsprintf returns an int.
301 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
303 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
305 Use make_formatted_string to avoid double length calculation.
306 * lisp.h (make_formatted_string): New prototype.
307 * alloc.c (make_formatted_string): New function.
308 * buffer.c (Fgenerate_new_buffer_name): Use it.
309 * dbus.c (syms_of_dbusbind): Likewise.
310 * editfns.c (Fcurrent_time_zone): Likewise.
311 * filelock.c (get_boot_time): Likewise.
312 * frame.c (make_terminal_frame, set_term_frame_name)
313 (x_report_frame_params): Likewise.
314 * image.c (gs_load): Likewise.
315 * minibuf.c (get_minibuffer): Likewise.
316 * msdos.c (dos_set_window_size): Likewise.
317 * process.c (make_process): Likewise.
318 * xdisp.c (ensure_echo_area_buffers): Likewise.
319 * xsettings.c (apply_xft_settings): Likewise.
321 2012-07-09 Glenn Morris <rgm@gnu.org>
323 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
324 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
325 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
326 * nsterm.h (ns_etc_directory): Add it.
327 * callproc.c [HAVE_NS]: Include nsterm.h.
328 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
330 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
332 Move marker debugging code under MARKER_DEBUG.
333 * marker.c (MARKER_DEBUG): Move marker debugging code under
334 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
335 for bootstrap with --enable-checking (~3x slowdown reported
336 by Juanma Barranquero <lekktu@gmail.com>).
337 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
339 2012-07-08 Paul Eggert <eggert@cs.ucla.edu>
341 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
342 See <http://bugs.gnu.org/11825#29>.
344 2012-07-08 Eli Zaretskii <eliz@gnu.org>
346 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
347 has no font, use the frame's font. (Bug#11813)
348 (display_line): Add commentary about displaying truncation glyphs
350 (produce_special_glyphs): Move here from term.c.
352 * term.c (produce_special_glyphs): Move to xdisp.c.
354 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
357 2012-07-07 Andreas Schwab <schwab@linux-m68k.org>
359 * xdisp.c (display_line): Avoid warning about implicit declaration
362 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
364 * lisp.h: Remove empty conditional.
366 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
368 * lread.c (load_path_check): Now static.
370 Fix some minor --with-ns problems found by static checking.
371 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
372 (x_set_font) [!HAVE_X_WINDOWS]:
373 * image.c (xpm_load_image) [HAVE_NS]:
374 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
375 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
377 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
378 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
379 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
380 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
381 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
382 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
383 Fix pointer signedness problem.
384 * xfaces.c (FRAME_X_FONT_TABLE):
385 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
387 2012-07-07 Glenn Morris <rgm@gnu.org>
389 * lread.c (load_path_check): New function, split from init_lread.
390 (init_lread): Reorganize. Motivation:
391 If EMACSLOADPATH is set, check/warn about that rather than the
392 defaults, which we are not going to use. Hence we can remove
393 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
394 Don't warn if site-lisp directories are missing.
395 If not installed, start from a blank load-path, since
396 PATH_LOADSEARCH refers to the eventual installation directories.
398 2012-07-07 Eli Zaretskii <eliz@gnu.org>
400 Support truncation and continuation glyphs on GUI frames, when
401 fringes are disabled. (Bug#11832)
402 * xdisp.c (init_iterator): Get dimensions of truncation and
403 continuation glyphs even if on GUI frames. Adjust
404 it->last_visible_x on GUI frames when the left or right fringes,
406 (start_display, move_it_in_display_line_to): Handle the case of a
407 GUI frame without a fringe to display continuation or truncation
409 (insert_left_trunc_glyphs): Support GUI frames: make sure
410 truncation glyphs overwrite enough glyphs from the current line to
411 have sufficient space in pixels.
412 (display_line): Support truncation and continuation glyphs on GUI
413 frames. If some spare pixels are left on the line after inserting
414 the truncation glyphs, fill that space with a stretch glyph of a
415 suitably computed width.
417 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
418 produce_glyphs, to support GUI sessions.
420 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
422 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
424 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
426 Do not require float-time's arg to fit in time_t (Bug#11825).
427 This works better on hosts where time_t is unsigned, and where
428 float-time is applied to the (negative) difference between two times.
429 * editfns.c (decode_time_components): Last arg is now double *,
430 not int *, and means to store all the result as a double, without
431 worrying about whether the seconds part fits in time_t.
433 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
435 (Ffloat_time): Do not fail merely because the specified time falls
436 outside of time_t range.
438 2012-07-07 Glenn Morris <rgm@gnu.org>
440 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
441 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
442 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
444 2012-07-07 Juanma Barranquero <lekktu@gmail.com>
446 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
449 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
451 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
453 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
454 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
455 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
456 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
457 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
458 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
460 * xfont.c (compare_font_names): Redo to omit the need for casts.
462 2012-07-06 Andreas Schwab <schwab@linux-m68k.org>
464 * xfns.c (Fx_change_window_property): Doc fix.
465 * w32fns.c (Fx_change_window_property): Doc fix.
467 * w32fns.c (Fx_window_property): Accept the same arguments as the
468 X Windows version. Doc fix.
469 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
471 2012-07-06 Juanma Barranquero <lekktu@gmail.com>
472 Eli Zaretskii <eliz@gnu.org>
474 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
475 Windows-specific code from nt/config.nt moved here.
476 Obsolete settings removed.
478 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
480 * process.c: Avoid unnecessary calls to gettime.
481 (wait_reading_process_output): Don't get the time of day
482 when gobbling data immediately and not waiting, as there's no need
483 for it in that case. This removes a FIXME.
485 2012-07-06 Jan Djärv <jan.h.d@swipnet.se>
487 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
488 is defined (Bug#11768).
490 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
492 Fix marker debugging code.
493 * marker.c (byte_char_debug_check): Do not perform the check
494 if buffer is not multibyte.
495 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
496 Call byte_char_debug_check with correct arguments.
498 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
500 Compile marker debugging code only if ENABLE_CHECKING is defined.
501 * marker.c (byte_char_debug_check, count_markers):
502 Use only if ENABLE_CHECKING is defined.
503 (byte_debug_flag): Remove.
504 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
505 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
507 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
509 Avoid code repetition in marker-related functions.
510 * marker.c (attach_marker): New function.
511 (Fset_marker, set_marker_restricted, set_marker_both)
512 (set_marker_restricted_both): Use it.
513 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
514 Consistently rename charno to charpos.
515 (marker_position): Add eassert.
516 (marker_byte_position): Convert to eassert.
518 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
520 Simplify list operations in unchain_overlay and unchain_marker.
521 * buffer.c (unchain_overlay): Simplify. Add comment.
522 * marker.c (unchain_marker): Simplify. Fix comments.
524 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
526 Introduce fast path for the widely used marker operation.
527 * alloc.c (build_marker): New function.
528 * lisp.h (build_marker): New prototype.
529 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
530 * composite.c (autocmp_chars): Likewise.
531 * editfns.c (buildmark): Remove.
532 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
533 (save_restriction_save): Use build_marker.
534 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
535 * window.c (save_window_save): Likewise.
537 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
539 Do not use Fdelete_overlay in delete_all_overlays
540 to avoid redundant calls to unchain_overlay.
541 * buffer.c (drop_overlay): New function.
542 (delete_all_overlays, Fdelete_overlay): Use it.
543 * minibuf.c (get_minibuffer): Fix comment.
545 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
547 Port to OpenBSD 5.1 amd64.
548 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
549 This is needed for OpenBSD, and should be harmless on all BSD systems.
550 Also, include <sys/sysctl.h>, as it should be available on all
551 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
552 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
553 use p_pid member, not kp_proc.pid.
555 2012-07-06 Glenn Morris <rgm@gnu.org>
557 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
559 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
561 More xmalloc and related cleanup.
562 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
563 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
564 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
565 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
566 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
567 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
568 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
569 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
570 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
572 Omit needless casts involving void * pointers and allocation.
573 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
574 as the former is more robust if P's type is changed.
575 Prefer xzalloc to xmalloc + memset 0.
576 Simplify malloc-or-realloc to realloc.
577 Don't worry about xmalloc returning a null pointer.
578 Prefer xstrdup to xmalloc + strcpy.
579 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
581 * keyboard.c (apply_modifiers_uncached): Prefer local array to
582 alloca of a constant.
584 2012-07-05 Eli Zaretskii <eliz@gnu.org>
586 * xdisp.c (display_line): Fix horizontal pixel coordinates when
587 hscroll is larger than the line width. Fixes long and futile
588 looping inside extend_face_to_end_of_line (on a TTY) producing
589 glyphs that are not needed and thrown away.
591 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
593 * marker.c (set_marker_restricted_both): Simplify by using
596 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
598 * editfns.c (region_limit): Simplify by using clip_to_bounds.
600 2012-07-05 Jan Djärv <jan.h.d@swipnet.se>
602 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
603 not defined (Bug#11768).
604 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
605 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
606 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
607 followed by gtk_box_set_homogeneous (Bug#11768).
608 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
609 (update_theme_scrollbar_width, xg_create_scroll_bar):
610 Use gtk_scrollbar_new (Bug#11768).
611 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
612 (is_box_type): New function (Bug#11768).
613 (xg_tool_item_stale_p): Call is_box_type.
614 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
615 with default display (Bug#11768).
617 2012-07-05 Eli Zaretskii <eliz@gnu.org>
619 * xdisp.c (window_hscroll_limited): New function.
620 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
621 coordinates when window's hscroll is set to insanely large
624 2012-07-05 Juanma Barranquero <lekktu@gmail.com>
626 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
627 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
629 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
632 * lisp.h (xzalloc): New prototype. Omit needless casts.
633 * alloc.c (xzalloc): New function. Omit needless casts.
634 * charset.c: Omit needless casts. Convert all calls to
635 xmalloc with following memset to xzalloc.
636 * dispnew.c: Likewise.
637 * fringe.c: Likewise.
641 * w32fns.c: Likewise.
642 * w32font.c: Likewise.
643 * w32term.c: Likewise.
644 * xfaces.c: Likewise.
647 * atimer.c: Omit needless casts.
648 * buffer.c: Likewise.
649 * callproc.c: Likewise.
651 * coding.c: Likewise.
652 * composite.c: Likewise.
654 * doprnt.c: Likewise.
655 * editfns.c: Likewise.
658 * filelock.c: Likewise.
660 * gtkutil.c: Likewise.
661 * keyboard.c: Likewise.
664 * minibuf.c: Likewise.
667 * process.c: Likewise.
668 * region-cache.c: Likewise.
669 * search.c: Likewise.
670 * sysdep.c: Likewise.
671 * termcap.c: Likewise.
672 * terminal.c: Likewise.
673 * tparam.c: Likewise.
674 * w16select.c: Likewise.
676 * w32reg.c: Likewise.
677 * w32select.c: Likewise.
678 * w32uniscribe.c: Likewise.
679 * widget.c: Likewise.
683 * xselect.c: Likewise.
685 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
687 * fileio.c (time_error_value): Check the right error number.
688 Problem reported by Troels Nielsen in
689 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
691 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
693 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
694 This should be fixed in a better way; see Eli Zaretskii in
695 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
696 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
698 * fileio.c (time_error_value): Rename from special_mtime.
699 The old name's problems were noted by Eli Zaretskii in
700 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
702 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
703 This variable's comment says Emacs needs at least one GDB-visible
704 symbol of type enum pvec_type, to work around GDB problems.
705 The symbol's value doesn't matter.
707 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
708 that causes compilation to fail on pre-C99 compilers.
710 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
712 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
713 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
715 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
717 * buffer.c (init_buffer_once): Fix initialization of
718 headers for buffer_defaults and buffer_local_symbols.
719 Reported by Juanma Barranquero <lekktu@gmail.com>.
721 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
723 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
724 * lisp.h (enum pvec_type): Use fewer bits.
725 (PSEUDOVECTOR_SIZE_BITS): New constant.
726 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
727 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
729 (PSEUDOVECTOR_TYPEP): New macro.
730 (TYPED_PSEUDOVECTORP): Use it.
731 * fns.c (internal_equal): Adapt code to extract pvectype.
732 * emacs.c (gdb_pvec_type): Update type.
733 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
734 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
735 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
736 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
737 (sweep_vectors): Use it. Use local var `total_bytes' instead of
738 abusing vector->header.next.nbytes.
739 (live_vector_p): Use PVEC_TYPE.
740 (mark_object): Adapt code to extract pvectype. Use switch.
742 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
744 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
745 Tighten new eassert a bit.
747 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
749 Fix compilation with --enable-gcc-warnings and -O1
751 * doprnt.c (doprnt): Change type of tem to int, initialize
752 to avoid compiler warning. Add eassert.
753 * search.c (simple_search): Initialize match_byte to avoid
754 compiler warning. Add eassert.
756 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
758 Avoid weird behavior with large horizontal scrolls.
759 Without this change, for example, large hscroll values would
760 mess up Emacs's display on Fedora 15 x86, presumably due to
761 overflows in int calculations in the display code.
762 Also, if buffers had long lines, Emacs would freeze.
763 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
764 (set_window_hscroll): New function, containing the old guts of
765 Fset_window_hscroll. Return the clipped value.
766 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
767 This avoids the need to check against PTRDIFF_MAX.
769 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
771 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
773 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
775 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
777 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
778 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
779 since GCC 4.4.6 issues a bogus warning for them.
781 Fix bugs in file timestamp newness comparisons.
782 * fileio.c (Ffile_newer_than_file_p):
783 * lread.c (Fload): Use full timestamp resolution of files,
784 not just the 1-second resolution, so that files that are only
785 slightly newer still count as newer.
786 * fileio.c (Ffile_newer_than_file_p): Don't assume file
787 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
789 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
791 * fileio.c: Improve handling of file time marker. (Bug#11852)
792 (special_mtime): New function.
793 (Finsert_file_contents, Fverify_visited_file_modtime):
794 Use it to set special mtime values consistently.
796 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
798 * fileio.c (Finsert_file_contents): Properly handle st_mtime
799 marker for non-existing file. (Bug#11852)
801 2012-07-03 Glenn Morris <rgm@gnu.org>
803 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
804 and did not make it into globals.h).
806 2012-07-03 Tom Tromey <tromey@redhat.com>
808 * window.c (Fset_window_margins, Fset_window_fringes)
809 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
810 * textprop.c (Fprevious_property_change): No longer static.
811 * syntax.c (Fsyntax_table_p): No longer static.
812 * process.c (Fget_process, Fprocess_datagram_address): No longer
814 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
815 * keyboard.c (Fcommand_execute): No longer static.
817 * insdel.c (Fcombine_after_change_execute): No longer static.
818 * image.c (Finit_image_library): No longer static.
819 * fileio.c (Fmake_symbolic_link): No longer static.
820 * eval.c (Ffetch_bytecode): No longer static.
821 * editfns.c (Fuser_full_name): No longer static.
822 * doc.c (Fdocumentation_property, Fsnarf_documentation):
824 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
826 * dired.c (Ffile_attributes): No longer static.
827 * composite.c (Fcomposition_get_gstring): No longer static.
828 * callproc.c (Fgetenv_internal): No longer static.
830 * ccl.h: Remove EXFUNs.
831 * buffer.h: Remove EXFUNs.
832 * dispextern.h: Remove EXFUNs.
833 * intervals.h: Remove EXFUNs.
834 * fontset.h: Remove EXFUN.
835 * font.h: Remove EXFUNs.
836 * dosfns.c (system_process_attributes): Remove EXFUN.
837 * keymap.h: Remove EXFUNs.
838 * lisp.h: Remove EXFUNs.
839 * w32term.h: Remove EXFUNs.
840 * window.h: Remove EXFUNs.
841 * xsettings.h: Remove EXFUN.
842 * xterm.h: Remove EXFUN.
844 2012-07-03 Glenn Morris <rgm@gnu.org>
846 * lisp.h (Frandom): Make it visible to C.
847 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
848 buffer for invisible buffers. (Bug#1229)
850 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
852 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
853 values which aren't power of 2.
854 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
855 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
858 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
860 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
862 * alloc.c (mark_object): Revert part of last patch to use `switch'.
864 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
866 * alloc.c (allocate_vector_block): Remove redundant
867 calls to mallopt if DOUG_LEA_MALLOC is defined.
868 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
869 avoid calls to mallopt if zero_vector is returned.
871 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
873 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
874 is enabled, avoid dereferencing NULL current_sblock if
877 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
879 Cleanup basic buffer management.
880 * buffer.h (struct buffer): Change layout to use generic vector
881 marking code. Fix some comments. Change type of 'clip_changed'
882 to bitfield. Remove unused #ifndef old.
883 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
884 (GET_OVERLAYS_AT): Fix indentation.
885 (for_each_per_buffer_object_at): New macro.
886 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
887 (Fbuffer_local_variables): Use it.
888 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
889 * alloc.c (allocate_buffer): Adjust to match new layout of
890 struct buffer. Fix comment.
891 (mark_overlay): New function.
892 (mark_buffer): Use it. Use mark_vectorlike to mark normal
893 Lisp area of struct buffer.
894 (mark_object): Use it. Adjust marking of misc objects
895 and related comments.
897 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
899 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
900 wrapper that is not needed because the wrapped code is a no-op (zero
901 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
902 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
904 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
906 * alloc.c (mark_buffer): Simplify. Remove prototype.
907 (mark_object): Add comment. Reorganize marking of vector-like
908 objects. Use CHECK_LIVE for all vector-like objects except buffers
909 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
910 redundant calls to mark_vectorlike for bool vectors.
912 2012-06-30 Glenn Morris <rgm@gnu.org>
914 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
916 * epaths.in (PATH_SITELOADSEARCH): New.
917 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
918 This is rather than relying on --enable-locallisppath elements
919 having "site-lisp" in their names. (Bug#10208#25, 11658)
921 2012-06-30 Eli Zaretskii <eliz@gnu.org>
923 * w32proc.c (sys_select): Accept and ignore one more argument.
925 * w32.c (emacs_gnutls_pull): Call select with one more argument.
927 * sysselect.h [DOS_NT]: Don't include sys/select.h.
928 (pselect) [!MS_DOS]: Redirect to sys_select.
930 * sysdep.c: Don't include dos.h and dosfns.h.
932 * process.c (sys_select):
933 * msdos.c (sys_select): Accept one more argument and ignore it.
935 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
936 adapt data types and code to that.
939 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
940 which clashes with the gnulib function of the same name.
942 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
944 * font.c (font_style_to_value, font_style_symbolic)
945 (font_prop_validate_style): Add type checks for values in
948 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
950 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
953 2012-06-29 Eli Zaretskii <eliz@gnu.org>
955 * xdisp.c (try_window_id): Undo last change.
957 * w32.c (getwd): Adjust commentary about startup_dir.
958 (init_environment): Always call sys_access, even in non-MSVC
959 builds. Don't chdir to the directory of the Emacs executable.
960 This undoes code from 1997 which was justified by the need to
961 "avoid conflicts when removing and renaming directories". But its
962 downside was that every relative file name was being interpreted
963 relative to the directory of the Emacs executable, which can never
964 be TRT. In particular, it broke sys_access when called with
966 (sys_access): Map GetLastError to errno.
968 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
970 * window.h (struct window): Change type of 'fringes_outside_margins'
971 to bitfield. Fix comment. Adjust users accordingly.
972 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
974 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
977 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
979 * gnutls.c (emacs_gnutls_handshake):
980 Add QUIT to make the loop interruptible.
982 2012-06-29 Glenn Morris <rgm@gnu.org>
984 * charset.c (init_charset): Make lack of etc/charsets fatal.
986 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
988 * editfns.c (region_limit): Fix type mismatch.
990 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
992 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
993 undefined. Convert from xassert to eassert.
994 * nsmenu.m: Convert from xassert to eassert.
995 * nsterm.m: Likewise.
997 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
999 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1001 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1003 Avoid integer overflow on scroll-left and scroll-right.
1004 * window.c (HSCROLL_MAX): New macro.
1005 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1006 overflow when requested scroll falls outside ptrdiff_t range.
1008 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1010 * window.h (struct window): Change type of 'hscroll',
1011 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1012 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1013 Adjust users accordingly.
1014 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1015 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1016 from EMACS_INT to ptrdiff_t.
1017 (make_window): Omit redundant initialization.
1019 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
1021 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1023 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1025 * window.h (struct window): Change type of 'use_time' and
1026 'sequence_number' from Lisp_Object to int.
1027 * frame.c (make_frame): Adjust users accordingly.
1028 * print.c (print_object): Likewise.
1029 * window.c (select_window, Fwindow_use_time, make_parent_window)
1030 (make_window): Likewise.
1032 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1034 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1035 enabled with --enable-checking=[all,glyphs] configure option.
1036 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1037 adjust comments accordingly.
1038 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1039 undefined, adjust comments accordingly.
1040 * image.c: Likewise.
1041 * scroll.c: Likewise.
1042 * w32fns.c: Likewise.
1043 * w32term.c: Likewise.
1044 * xdisp.c: Likewise.
1045 * xfaces.c: Likewise.
1047 * xterm.c: Likewise.
1049 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1051 Generalize run-time debugging checks.
1052 * dispextern.h (XASSERTS): Remove.
1053 * fontset.c (xassert): Remove.
1054 Convert from xassert to eassert.
1055 * alloc.c: Convert from xassert to eassert.
1057 * dispnew.c: Likewise.
1059 * fringe.c: Likewise.
1060 * ftfont.c: Likewise.
1061 * gtkutil.c: Likewise.
1062 * image.c: Likewise.
1063 * keyboard.c: Likewise.
1065 * process.c: Likewise.
1066 * scroll.c: Likewise.
1067 * sound.c: Likewise.
1069 * w32console.c: Likewise.
1070 * w32fns.c: Likewise.
1071 * w32term.c: Likewise.
1072 * window.c: Likewise.
1073 * xdisp.c: Likewise.
1074 * xfaces.c: Likewise.
1076 * xselect.c: Likewise.
1077 * xterm.c: Likewise.
1079 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1081 * fns.c (maybe_resize_hash_table): Output message when growing the
1084 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1086 * alloc.c (allocate_string_data): Remove dead code.
1087 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1088 avoid GCC warning about unused macro.
1090 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1092 * alloc.c (allocate_string): Omit intervals initialization.
1093 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1094 as in make_pure_string and make_pure_c_string.
1096 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1098 * alloc.c (allocate_string): Fix last change.
1100 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1102 * alloc.c (allocate_string): Remove two redundant calls
1103 to memset, add explicit initialization where appropriate.
1105 2012-06-27 Glenn Morris <rgm@gnu.org>
1107 * lisp.mk (lisp): Remove paths.elc.
1109 2012-06-27 Chong Yidong <cyd@gnu.org>
1111 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1113 2012-06-26 John Wiegley <johnw@newartisans.com>
1115 * unexmacosx.c (copy_data_segment): Add two section names used
1116 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1118 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1119 when building with Clang.
1121 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1123 * eval.c (Fapply): Allow calling it with a single argument.
1125 2012-06-26 Eli Zaretskii <eliz@gnu.org>
1127 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1128 _stricmp and _strnicmp.
1129 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1131 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1133 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1135 (allocate_process): Likewise for new process.
1136 (allocate_terminal): Change to use offsetof.
1137 (allocate_frame): Likewise.
1138 * frame.c (make_frame): Omit redundant initialization.
1139 * window.c (make_parent_window): Use memset.
1140 (make_window): Omit redundant initialization.
1141 * process.c (make_process): Omit redundant initialization.
1142 * terminal.c (create_terminal): Likewise.
1144 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1146 * term.c (delete_tty): Remove redundant call to memset.
1148 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1150 * alloc.c: Remove build_string.
1151 * lisp.h: Define build_string as static inline. This provides
1152 a better opportunity to optimize away calls to strlen when the
1153 function is called with compile-time constant argument.
1154 * image.c (imagemagick_error): Convert to build_string.
1155 * w32proc.c (sys_spawnve): Likewise.
1156 * xterm.c (x_term_init): Likewise.
1158 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1160 Use sprintf return value instead of invoking strlen on result.
1161 In the old days this wasn't portable, since some sprintf
1162 implementations returned char *. But they died out years ago and
1163 Emacs already assumes sprintf returns int.
1164 Similarly for float_to_string.
1165 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1166 * ccl.c (ccl_driver):
1167 * character.c (string_escape_byte8):
1168 * data.c (Fnumber_to_string):
1169 * doprnt.c (doprnt):
1170 * print.c (print_object):
1171 * xdisp.c (message_dolog):
1172 * xfns.c (syms_of_xfns):
1173 Use sprintf or float_to_string result to avoid need to call strlen.
1174 * data.c (Fnumber_to_string):
1175 Use make_unibyte_string, since the string must be ASCII.
1176 * lisp.h, print.c (float_to_string): Now returns int length.
1177 * term.c (produce_glyphless_glyph):
1178 Use sprintf result rather than recomputing it.
1180 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1181 * Makefile.in (ALL_CFLAGS):
1182 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1183 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1185 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1187 * dispextern.h (xstrcasecmp): Define to library function
1188 strcasecmp if available.
1189 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1191 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1193 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1194 Avoid comma operator.
1195 * menu.c (push_submenu_start, push_submenu_end)
1196 (push_left_right_boundary, push_menu_pane): Likewise.
1197 * msdos.c (dos_rawgetc): Likewise.
1199 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1201 * xfns.c (xic_create_fontsetname): Remove redundant calls
1204 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1206 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1207 sprintf already null-terminates its output.
1209 * xfns.c (x_window): Remove redundant cast.
1211 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1213 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1214 `const char *' to `char *' to avoid compiler warning.
1216 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1218 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1219 instead of truncating it to 63 (admittedly a generous limit).
1221 * process.c: Fix spelling and caps in comments.
1223 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1225 * emacs.c (setpgrp): Remove definition, unused.
1226 * sysdep.c (setpgrp): Remove definition, not used in this file.
1228 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
1230 * makefile.w32-in: Update dependencies.
1232 2012-06-24 Eli Zaretskii <eliz@gnu.org>
1234 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1235 (SYSTIME_H): Add nt/inc/sys/time.h.
1237 * systime.h [WINDOWSNT]: Include sys/time.h.
1239 * s/ms-w32.h (struct timespec): Definition moved from
1240 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1242 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1244 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1245 * buffer.h (buffer_slot_type_mismatch):
1246 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1247 * eval.c (unwind_to_catch):
1248 * image.c (my_png_error, my_error_exit):
1249 * keyboard.c (quit_throw_to_read_char, user_error)
1250 (Fexit_recursive_edit, Fabort_recursive_edit):
1251 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1252 (wrong_type_argument, buffer_overflow, __executable_start)
1253 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1254 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1255 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1257 (child_setup) [!DOS_NT]:
1258 * lread.c (end_of_file_error, invalid_syntax):
1259 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1260 * puresize.h (pure_write_error):
1261 * search.c (matcher_overflow):
1262 * sound.c (sound_perror, alsa_sound_perror):
1263 * sysdep.c, syssignal.h (croak):
1264 * term.c (maybe_fatal, vfatal):
1265 * textprop.c (text_read_only):
1266 * undo.c (user_error):
1267 * unexmacosx.c (unexec_error):
1268 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1269 Use _Noreturn rather than NO_RETURN.
1270 No need for separate decl merely because of _Noreturn.
1271 * sound.c (sound_warning, parse_sound):
1272 Remove unnecessary forward decls.
1274 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1276 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1277 * lisp.h (WAIT_READING_MAX): New macro.
1278 * dispnew.c (Fsleep_for, sit_for):
1279 * keyboard.c (kbd_buffer_get_event):
1280 * process.c (Faccept_process_output):
1281 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1282 This improves on the previous patch, which introduced a bug
1283 when time_t is unsigned and as wide as intmax_t.
1284 See <http://bugs.gnu.org/9000#51>.
1286 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1288 * dispnew.c (sit_for, Fsleep_for):
1289 * keyboard.c (kbd_buffer_get_event):
1290 * process.c (Faccept_process_output): Avoid compiler warnings when
1291 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1293 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
1295 * makefile.w32-in: Update dependencies.
1297 * w32.c (ltime): Add return type and declare static.
1298 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1300 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1302 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1303 Privately reported by Herbert J. Skuhra.
1304 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1306 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1307 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1309 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1311 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1312 last argument of make_unibyte_string.
1314 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1315 language ID in the event parameters.
1317 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1318 event.code, not the obscure "character set ID".
1320 2012-06-23 Chong Yidong <cyd@gnu.org>
1322 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1324 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1326 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1327 * w32.c (fdutimens): New function.
1329 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1331 * s/ms-w32.h (pselect): Redirect to sys_select.
1333 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1335 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1336 in the logic of incrementing and decrementing the value of
1337 use_relocatable_buffers.
1339 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1341 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1342 Privately reported by Herbert J. Skuhra.
1343 [__FreeBSD__]: Remove "*/" typo after "#include".
1344 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1345 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1346 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1347 Don't assume EMACS_TIME and struct timeval are the same type.
1349 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1351 Support higher-resolution time stamps (Bug#9000).
1352 The time stamps are only nanosecond-resolution at the C level,
1353 since that's the best that any real-world system supports now.
1354 But they are picosecond-resolution at the Lisp level, as that's
1355 easy, and leaves room for future OS improvements.
1357 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1360 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1361 Don't get current time unless it's needed.
1363 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1364 now provides it if it's absent.
1365 (start_atimer): Port to higher-res time stamps.
1366 Check for time stamp overflow. Don't get current time more
1367 often than is needed.
1369 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1370 Include systime.h, not time.h.
1371 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1373 * dired.c: Include stat-time.h.
1374 (Ffile-attributes): File times now have higher resolution.
1376 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1377 (struct image): Timestamp now has higher resolution.
1379 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1380 has at least microseconds now. All uses removed.
1381 (update_frame, update_single_window, update_window, update_frame_1)
1382 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1384 * editfns.c (time_overflow): Now extern.
1385 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1386 (float-time, Fformat_time_string, Fcurrent_time_string)
1387 (Fcurrent_time_zone): Accept and generate higher-resolution
1389 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1390 (decode_time_components, lisp_seconds_argument): New functions.
1391 (make_time): Now static.
1392 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1393 Report an error if the time is invalid, rather than having the caller
1396 * fileio.c: Include <stat-time.h>
1397 (Fcopy_file): Copy higher-resolution time stamps.
1398 Prefer to set the time stamp via a file descriptor if that works.
1399 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1400 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1401 (Fvisited_file_modtime, Fset_visited_file_modtime):
1402 Support higher-resolution time stamps.
1404 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1406 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1408 * image.c (prepare_image_for_display, clear_image_cache)
1409 (lookup_image): Port to higer-resolution time stamps.
1411 * keyboard.c (start_polling, bind_polling_period):
1412 Check for time stamp overflow.
1413 (read_char, kbd_buffer_get_event, timer_start_idle)
1414 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1415 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1416 Port to higher-resolution time stamps. Do not assume time_t is signed.
1417 (decode_timer): New function. Timers are now vectors of length 9,
1418 not 8, to accommodate the picosecond component.
1419 (timer_check_2): Use it.
1421 * nsterm.m (select_timeout, timeval_subtract): Remove.
1422 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1423 as they're a bit more accurate and handle overflow better.
1424 (ns_select): Change prototype to be compatible with pselect.
1425 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1426 * nsterm.h (ns_select): Adjust prototype.
1428 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1429 us-resolution time stamps.
1430 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1432 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1434 * lisp.h (time_overflow): New decl.
1435 (wait_reading_process_output): First arg is now intmax_t, not int,
1436 to accommodate larger waits.
1438 * process.h (struct Lisp_Process.read_output_delay):
1439 Now counts nanoseconds, not microseconds.
1440 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1442 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1443 (wait_reading_process_output):
1444 Port to ns-resolution time stamps.
1445 (Faccept_process_output, wait_reading_process_output):
1446 Check for time stamp overflow. Do not assume time_t is signed.
1447 (select_wrapper): Remove; we now use pselect.
1448 (Fprocess_attributes): Now generates ns-resolution time stamps.
1450 * sysdep.c: Include utimens.h. Don't include utime.h
1451 or worry about struct utimbuf; gnulib does that for us now.
1452 (gettimeofday): Remove; gnulib provides a substitute.
1453 (make_timeval): New function.
1454 (set_file_times): Now sets ns-resolution time stamps.
1455 New arg FD; all uses changed.
1456 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1457 (system_process_attributes):
1458 Now returns ns-resolution time stamp. All uses changed.
1459 Check for time stamp overflow.
1461 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1462 provides a substitute now.
1464 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1465 since it guarantees struct timespec.
1466 (EMACS_TIME): Now struct timespec, so that we can support
1467 ns-resolution time stamps.
1468 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1469 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1470 (EMACS_USECS): Remove.
1471 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1472 so multiply the arg by 1000 before storing it.
1473 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1475 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1476 Port to ns-resolution time stamps.
1477 (EMACS_TIME_NEG_P): Remove; replaced by....
1478 (EMACS_TIME_SIGN): New macro.
1479 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1480 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1481 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1482 (make_timeval, make_lisp_time, decode_time_components): New decls.
1483 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1484 that it mishandled time_t overflow. You can't compare by subtracting!
1485 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1486 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1488 * term.c: Include <sys/time.h>.
1489 (timeval_to_Time): New function, for proper overflow wraparound.
1490 (term_mouse_position, term_mouse_click): Use it.
1492 * undo.c (record_first_change): Support higher-resolution time stamps
1494 (Fprimitive_undo): Use them when restoring time stamps.
1496 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1497 (w32_get_internal_run_time):
1498 Port to higher-resolution Emacs time stamps.
1499 (ltime): Now accepts single 64-bit integer, as that's more convenient
1502 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1504 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1505 for compatibility with pselect. Support ns-resolution time stamps.
1507 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1509 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1510 Check for time stamp overflow, and support ns-resolution time stamps.
1512 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1513 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1514 (timeval_subtract): Remove; no longer needed.
1515 (XTflash, XTring_bell, x_wait_for_event):
1516 Port to ns-resolution time stamps. Don't assume time_t is signed.
1518 2012-06-22 Chong Yidong <cyd@gnu.org>
1520 * xdisp.c (x_consider_frame_title): Revert last change.
1522 2012-06-22 Eli Zaretskii <eliz@gnu.org>
1524 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1525 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1526 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1527 staticidx goes up to 1597 out of 1600 = 0x640.)
1529 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1531 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1532 Otherwise, the umask might be mistakenly 0 while handling input signals.
1534 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1536 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1538 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1540 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1541 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1542 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1543 access to `contents' member of Lisp_Vector objects with AREF and ASET
1546 2012-06-19 Chong Yidong <cyd@gnu.org>
1548 * frame.c (delete_frame): When selecting a frame on a different
1549 text terminal, do not alter the terminal's top-frame.
1551 * xdisp.c (format_mode_line_unwind_data): Record the target
1552 frame's selected window and its terminal's top-frame.
1553 (unwind_format_mode_line): Restore them.
1554 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1556 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1557 since tty frames can be explicitly named.
1558 (prepare_menu_bars): Likewise.
1560 * term.c (Ftty_top_frame): New function.
1562 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1564 Port byte-code-meter to modern targets.
1565 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1566 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
1567 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
1568 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1569 (METER_1, METER_2): Simplify.
1571 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1573 * data.c (Fdefalias): Return `symbol' (bug#11686).
1575 2012-06-18 Martin Rudalics <rudalics@gmx.at>
1577 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1578 gets killed during executing of this function (Bug#11665).
1579 Try to always return Qt when the buffer has been actually killed.
1580 (Vkill_buffer_query_functions): In doc-string say that functions
1581 run by this hook should not change the current buffer.
1583 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1585 Fix recently-introduced process.c problems found by static checking.
1586 * process.c (write_queue_push, write_queue_pop, send_process):
1587 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1588 (write_queue_pop): Fix pointer signedness problem.
1589 (send_process): Remove unused local.
1591 2012-06-17 Chong Yidong <cyd@gnu.org>
1593 * xdisp.c (redisplay_internal): No need to redisplay terminal
1594 frames that are not on top.
1596 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
1598 * process.c (make_process): Initialize write_queue.
1599 (write_queue_push, write_queue_pop): New functions.
1600 (send_process): Use them to maintain correct ordering of process
1603 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1605 * lisp.h (eassert): Assume C89 or later.
1606 This removes the need for CHECK.
1607 (CHECK): Remove. Its comments about always evaluating its
1608 argument were confusing, as 'eassert' typically does not evaluate
1611 * coding.c (produce_chars): Use ptrdiff_t, not int.
1613 * xterm.c (x_draw_underwave): Check for integer overflow.
1614 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1616 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
1618 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1619 referenced (Bug#11583).
1621 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1623 Implement wave-style variant of underlining.
1624 * dispextern.h (face_underline_type): New enum.
1625 (face): Add field for underline type.
1626 * nsterm.m (ns_draw_underwave): New function.
1627 (ns_draw_text_decoration): Use it.
1628 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1630 (x_draw_glyph_string): Use them.
1631 * xfaces.c (Qline, Qwave): New Lisp objects.
1632 (check_lface_attrs, merge_face_ref)
1633 (Finternal_set_lisp_face_attribute, realize_x_face):
1634 Handle wave-style underline face attributes.
1635 * xterm.c (x_draw_underwave): New function.
1636 (x_draw_glyph_string): Use it.
1638 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
1640 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1641 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1642 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1643 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1644 ($(BLD)/w32select.$(O)): Update dependencies.
1646 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1648 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1649 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1650 * character.c (_fetch_multibyte_char_p): Remove.
1651 * alloc.c: Include "character.h" before "buffer.h".
1653 * buffer.c: Likewise.
1654 * bytecode.c: Likewise.
1655 * callint.c: Likewise.
1656 * callproc.c: Likewise.
1657 * casefiddle.c: Likewise.
1658 * casetab.c: Likewise.
1659 * category.c: Likewise.
1661 * coding.c: Likewise.
1662 * composite.c: Likewise.
1663 * dired.c: Likewise.
1664 * dispnew.c: Likewise.
1666 * dosfns.c: Likewise.
1667 * editfns.c: Likewise.
1668 * emacs.c: Likewise.
1669 * fileio.c: Likewise.
1670 * filelock.c: Likewise.
1672 * fontset.c: Likewise.
1673 * fringe.c: Likewise.
1674 * indent.c: Likewise.
1675 * insdel.c: Likewise.
1676 * intervals.c: Likewise.
1677 * keyboard.c: Likewise.
1678 * keymap.c: Likewise.
1679 * lread.c: Likewise.
1680 * macros.c: Likewise.
1681 * marker.c: Likewise.
1682 * minibuf.c: Likewise.
1683 * nsfns.m: Likewise.
1684 * nsmenu.m: Likewise.
1685 * print.c: Likewise.
1686 * process.c: Likewise.
1687 * regex.c: Likewise.
1688 * region-cache.c: Likewise.
1689 * search.c: Likewise.
1690 * syntax.c: Likewise.
1692 * textprop.c: Likewise.
1694 * unexsol.c: Likewise.
1695 * w16select.c: Likewise.
1696 * w32fns.c: Likewise.
1697 * w32menu.c: Likewise.
1698 * window.c: Likewise.
1699 * xdisp.c: Likewise.
1701 * xmenu.c: Likewise.
1703 * xselect.c: Likewise.
1705 2012-06-16 Eli Zaretskii <eliz@gnu.org>
1707 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1708 If all the glyphs of the glyph row came from strings, and we have no
1709 cursor positioning clues, put the cursor on the first glyph of the
1711 (handle_face_prop): Use chunk-relative overlay string index when
1712 indexing into it->string_overlays array. (Bug#11653)
1713 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1714 the rightmost. (Bug#11720)
1716 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1718 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1719 (CATEGORY_MEMBER): Enforce 1/0 value.
1720 * category.c (_temp_category_set): Remove.
1722 2012-06-16 Eli Zaretskii <eliz@gnu.org>
1724 * window.c (Fdelete_other_windows_internal)
1725 (Fdelete_window_internal): Don't access frame's mouse highlight
1726 info of the initial frame. (Bug#11677)
1728 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1730 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1731 Assume USE_2_TAGS_FOR_INTS.
1732 (xreload): Adjust $tagmask width to match recent lisp.h change.
1734 Simplify lisp.h in minor ways that should not affect code.
1735 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1736 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1737 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1738 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1739 (INTTYPEBITS): New macro, for clarity.
1740 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1741 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1742 Simplify now that USE_LSB_TAG is always defined.
1743 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1744 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1746 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
1748 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1750 2012-06-13 Glenn Morris <rgm@gnu.org>
1752 * s/bsd-common.h (BSD4_3):
1753 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1755 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1757 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1760 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1762 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
1763 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1764 * alloc.c (widen_to_Lisp_Object): Remove.
1765 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1766 * frame.c (delete_frame): Remove outdated comment.
1767 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1768 USE_LISP_UNION_TYPE.
1769 (Fw32_unregister_hot_key): Likewise.
1770 (Fw32_toggle_lock_key): Likewise.
1771 * w32menu.c (add_menu_item): Likewise.
1772 (w32_menu_display_help): Use XIL instead of checking
1773 USE_LISP_UNION_TYPE.
1774 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1775 (init_heap): Likewise.
1776 * w32term.c (w32_read_socket): Update comment.
1778 2012-06-13 Glenn Morris <rgm@gnu.org>
1780 * s/usg5-4-common.h, src/s/unixware.h:
1781 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1783 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1785 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1787 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1788 * alloc.c (make_number) [!defined make_number]:
1789 Remove, as lisp.h always defines this now.
1790 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1791 (roundup_size): Verify that it is a power of 2.
1792 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1793 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1794 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1795 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1796 USE_LSB_TAG now is always defined to be either 0 or 1.
1798 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1799 code works fine either way, and efficiency is not a concern here,
1800 as the union type is for debugging, not for production.
1801 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1802 Use an inline function on all platforms when using the union type,
1803 since this is simpler and 'static inline' can be used portably
1805 (LISP_INITIALLY_ZERO): New macro.
1806 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1807 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1809 2012-06-12 Glenn Morris <rgm@gnu.org>
1811 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1813 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
1815 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1816 Move BROKEN_SIGIO to configure.
1818 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1819 Move NO_TERMIO to configure.
1821 2012-06-12 Chong Yidong <cyd@gnu.org>
1823 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1824 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1825 MagickExportImagePixels is undefined.
1827 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1829 * image.c (imagemagick_load_image): Remove unused label.
1831 2012-06-11 Glenn Morris <rgm@gnu.org>
1833 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1834 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1835 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1836 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1838 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1840 * alloc.c (make_byte_code): New function.
1841 (Fmake_byte_code): Use it. Don't purify here.
1842 * lread.c (read1): Use it as well to avoid extra allocation.
1844 2012-06-11 Chong Yidong <cyd@gnu.org>
1846 * image.c (imagemagick_load_image): Implement transparency.
1848 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1850 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1851 account for preceding backslashes. (Bug#11663)
1853 2012-06-09 Chong Yidong <cyd@gnu.org>
1855 * term.c: Support italics in capable terminals (Bug#9652).
1856 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1857 (turn_on_face): Output using TS_enter_italic_mode if available.
1858 Don't handle unused blinking and alt-charset cases.
1859 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1860 and tty_alt_charset_p cases.
1861 (tty_capable_p, init_tty): Support italics.
1863 * termchar.h (struct tty_display_info): Add field for italics.
1864 Remove unused blink field.
1866 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1869 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1870 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1871 tty_alt_charset_p. Add tty_italic_p.
1873 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
1875 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1876 dbus_type_is_basic if available.
1877 (xd_extract_signed, xd_extract_unsigned): Rename from
1878 extract_signed and extract_unsigned, respectively. Adapt callers.
1880 2012-06-09 Chong Yidong <cyd@gnu.org>
1882 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1884 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1887 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1889 * xdisp.c (vmessage): Treat frame message as multibyte.
1890 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1891 would generate the diagnostic "Making \302\247 buffer-local while
1894 2012-06-08 Eli Zaretskii <eliz@gnu.org>
1896 * dispnew.c (showing_window_margins_p): Undo last change, which
1897 was done due to an inadvertent commit.
1898 (adjust_frame_glyphs_for_frame_redisplay): Do call
1899 showing_window_margins_p.
1901 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1903 * eval.c (Fmake_var_non_special): New primitive.
1904 (syms_of_eval): Defsubr it.
1905 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1907 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
1909 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1910 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1912 2012-06-08 Eli Zaretskii <eliz@gnu.org>
1914 * alloc.c (allocate_vectorlike): Fix last change.
1916 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1918 Block-based vector allocation of small vectors.
1919 * lisp.h (struct vectorlike_header): New field `nbytes',
1920 adjust comment accordingly.
1921 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1922 to denote vector blocks. Adjust users (live_vector_p,
1923 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1924 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1925 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1926 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1927 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1928 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1929 (roundup_size): New constant.
1930 (struct vector_block): New data type.
1931 (vector_blocks, vector_free_lists, zero_vector): New variables.
1932 (all_vectors): Rename to `large_vectors'.
1933 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1934 (sweep_vectors): New functions.
1935 (allocate_vectorlike): Return `zero_vector' as the only vector of
1936 0 items. Allocate new vector from block if vector size is less than
1937 or equal to VBLOCK_BYTES_MAX.
1938 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1939 (init_alloc_once): Add call to init_vectors.
1941 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1943 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1945 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1947 * doprnt.c (doprnt): Truncate multibyte char correctly.
1948 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1949 would mishandle a string argument "Xc" if X was a multibyte
1950 character of length 2: it would truncate after X's first byte
1951 rather than including all of X.
1953 2012-06-06 Chong Yidong <cyd@gnu.org>
1955 * buffer.c (word_wrap): Doc fix.
1957 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1959 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1961 2012-06-03 Glenn Morris <rgm@gnu.org>
1963 * xdisp.c (tool-bar-style): Doc fix.
1965 2012-06-03 Ulrich Müller <ulm@gentoo.org>
1967 * Makefile.in (PAXCTL): Define.
1968 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1969 binary via PaX flags if the paxctl utility is available.
1970 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1971 Restore PaX flags to their default. (Bug#11398)
1973 2012-06-03 Chong Yidong <cyd@gnu.org>
1975 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1978 2012-06-03 Chong Yidong <cyd@gnu.org>
1980 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1981 (note_mode_line_or_margin_highlight): If there is no help echo,
1982 use mode-line-default-help-echo. Handle the case where the mouse
1983 position is past the end of the mode line string.
1985 * buffer.c (buffer_local_value_1): New function, split from
1986 Fbuffer_local_value; can return Qunbound.
1987 (Fbuffer_local_value): Use it.
1988 (Vmode_line_format): Docstring tweaks.
1990 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1992 * sysdep.c (system_process_attributes): Improve comment.
1994 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1996 * keyboard.c: Export real-this-command to Elisp.
1997 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1998 and DEFVAR it. Update all users.
2000 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2002 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2004 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2005 Convert pctcpu and pctmem to Lisp float properly.
2006 Let the compiler fold better, as 100.0/0x8000 is exact.
2008 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2010 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2013 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2015 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2017 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2019 For a 'struct window', replace some Lisp_Object fields to
2020 bitfields where appropriate, remove unused fields.
2021 * window.h (struct window): Remove unused 'last_mark_x' and
2022 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2023 change it's type from Lisp_Object to bitfield.
2024 Change type of 'force_start', 'optional_new_start',
2025 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2026 fields from Lisp_Object to bitfield. Adjust users accordingly.
2028 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2030 Pacify gcc -Wdouble-precision when using Xaw.
2031 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2032 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2033 Use 'float' consistently, rather than 'float' in most places
2034 and 'double' in a couple of places.
2036 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2038 * xdisp.c (handle_stop): Detect whether we have overlay strings
2039 loaded by testing it->current.overlay_string_index to be
2040 non-negative, instead of checking whether n_overlay_strings is
2041 positive. (Bug#11587)
2043 2012-05-31 Chong Yidong <cyd@gnu.org>
2045 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2047 * doc.c (Fsubstitute_command_keys): Doc fix.
2049 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2051 * search.c (search_buffer): Remove calls to
2052 r_alloc_inhibit_buffer_relocation, as it is now called by
2053 maybe_unify_char, which was the cause of relocation of buffer text
2056 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2058 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2059 for the duration of call to load_charset, to avoid problems with
2060 callers of maybe_unify_char that access buffer text through C
2063 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2064 decrement the inhibition flag, instead of just setting or
2067 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2069 Remove obsolete '#define static' cruft.
2070 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2071 This #undef was "temporary" in 2000; it is no longer needed
2072 now that '#define static' has gone away.
2073 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2074 (gray_bitmap_bits): Remove; no longer needed.
2075 All uses replaced with definiens.
2076 * xterm.c: Include "bitmaps/gray.xbm".
2078 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2080 Clean up __executable_start, monstartup when --enable-profiling.
2081 The following changes affect the code only when profiling.
2082 * dispnew.c (__executable_start): Rename from safe_bcopy.
2083 Define only on platforms that need it.
2084 * emacs.c: Include <sys/gmon.h> when profiling.
2085 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2086 (__executable_start): Remove decl, since lisp.h does it now.
2087 (safe_bcopy): Remove decl; no longer has that name.
2088 (main): Coalesce #if into single bit of code, for simplicity.
2089 Cast pointers to uintptr_t, since standard libraries want integers
2091 * lisp.h (__executable_start): New decl.
2093 2012-05-31 Glenn Morris <rgm@gnu.org>
2095 * image.c (Fimagemagick_types): Doc fix.
2097 2012-05-30 Jim Meyering <meyering@redhat.com>
2099 * callproc.c (Fcall_process_region): Include directory component
2100 in mkstemp error message (Bug#11586).
2102 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2104 * alloc.c, lisp.h (make_pure_vector): Now static.
2106 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2108 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2109 Move to byte-run.el.
2110 (Fautoload): Do the hash-doc more carefully.
2111 * data.c (Fdefalias): Purify definition, except for keymaps.
2112 (Qdefun): Move from eval.c.
2113 * lisp.h (Qdefun): Remove.
2114 * lread.c (read1): Tiny simplification.
2116 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
2118 Do not create empty overlays with the evaporate property (Bug#9642).
2119 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2120 Bug#9642, but explicitly check that the buffer the overlay would
2121 be moved to is live and rearrange lines to make sure that errors
2122 will not put the overlay in an inconsistent state.
2123 (Fdelete_overlay): Cosmetics.
2125 2012-05-28 Eli Zaretskii <eliz@gnu.org>
2127 * w32term.c (my_bring_window_to_top): New function.
2128 (x_raise_frame): Use handle returned by DeferWindowPos, which
2129 could be different from the original one.
2130 Call my_bring_window_to_top instead of my_set_foreground_window.
2133 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2134 by calling BringWindowToTop.
2136 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2137 (WM_EMACS_END): Increase by one.
2139 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2141 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2142 This avoids undefined behavior that might cause the eassert
2143 to not catch an out-of-range value.
2145 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
2147 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2148 Update dependencies.
2150 2012-05-27 Eli Zaretskii <eliz@gnu.org>
2152 * bidi.c (bidi_mirror_char): Fix last change.
2154 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2156 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2157 when referring to sectname field in printf format.
2159 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2161 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2162 Only r_alloc_inhibit_buffer_relocation needed to be added;
2163 the others were already declared.
2165 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2166 before checking whether it's out of range. Put the check inside
2168 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2170 2012-05-27 Ken Brown <kbrown@cornell.edu>
2172 * callproc.c (Fcall_process): Restore a line that was accidentally
2173 commented out in the 2011-02-13 change (bug#11547).
2175 2012-05-27 Eli Zaretskii <eliz@gnu.org>
2177 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2178 defined on ralloc.c.
2180 * buffer.c [REL_ALLOC]: Remove prototypes of
2181 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2182 they are now on lisp.h.
2184 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2186 * search.c (search_buffer): Use it to inhibit relocation of buffer
2187 text while re_search_2 is doing its job, because re_search_2 is
2188 passed C pointers to buffer text. (Bug#11519)
2190 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2193 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2194 state after an additional call to move_it_in_display_line_to, keep
2195 the values of it->max_ascent and it->max_descent found for the
2197 (pos_visible_p): Revert the comparison against bottom_y to what it
2198 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2201 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2203 Fix coding-related core dumps with gcc -ftrapv.
2204 The code was computing A - B, where A and B are pointers, and B is
2205 random garbage. This can lead to core dumps on platforms that
2206 have special pointer registers, and it also leads to core dumps on
2207 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2208 A - B only when B is initialized properly.
2209 * coding.c (coding_set_source, coding_set_destination): Return void.
2210 (coding_change_source, coding_change_destinations): New functions,
2211 with the old behaviors of coding_set_source and coding_set_destination.
2212 All callers that need an offset changed to use these new functions.
2214 2012-05-26 Glenn Morris <rgm@gnu.org>
2216 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2218 2012-05-26 Eli Zaretskii <eliz@gnu.org>
2220 Extend mouse support on W32 text-mode console.
2221 * xdisp.c (draw_row_with_mouse_face):
2222 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
2224 * w32console.c: Include window.h.
2225 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2227 (initialize_w32_display): Initialize mouse-highlight data.
2229 * w32inevt.c: Include termchar.h and window.h.
2230 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2231 moves, call note_mouse_highlight. If help_echo changed, call
2232 gen_help_event to produce help-echo message in the echo area.
2233 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2236 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2238 * lread.c (read1): Simplify slightly to avoid an overflow warning
2239 with GCC 4.7.0 on x86-64.
2241 2012-05-26 Eli Zaretskii <eliz@gnu.org>
2243 * bidi.c (bidi_mirror_char): Revert last change: an int is
2244 definitely wide enough here.
2246 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
2248 Fix integer width and related bugs (Bug#9874).
2249 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
2250 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2251 (string_bytes, check_sblock, allocate_string_data):
2252 (compact_small_strings, Fmake_bool_vector, make_string)
2253 (make_unibyte_string, make_multibyte_string)
2254 (make_string_from_bytes, make_specified_string)
2255 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2256 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2258 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2259 (allocate_pseudovector):
2260 Use int, not EMACS_INT, where int is wide enough.
2261 (inhibit_garbage_collection, Fgarbage_collect):
2262 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2263 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2264 int might not be wide enough.
2265 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2266 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2267 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2268 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2269 (bidi_level_of_next_char, bidi_move_to_visually_next):
2270 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2271 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2272 (Fkill_buffer, Fset_buffer_major_mode)
2273 (advance_to_char_boundary, Fbuffer_swap_text)
2274 (Fset_buffer_multibyte, overlays_at, overlays_in)
2275 (overlay_touches_p, struct sortvec, record_overlay_string)
2276 (overlay_strings, recenter_overlay_lists)
2277 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2278 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2279 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2280 (Foverlay_recenter, last_overlay_modification_hooks_used)
2281 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2282 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2283 (validate_region): Omit unnecessary test for b <= e,
2284 since that's guaranteed by the previous test.
2285 (adjust_overlays_for_delete): Avoid pos + length overflow.
2286 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2287 (report_overlay_modification):
2288 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2289 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2290 Omit pointer cast, which isn't needed anyway, and doesn't work
2291 after the EMACS_INT -> ptrdiff_t change.
2292 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
2293 * buffer.h: Adjust decls to match defn changes elsewhere.
2294 (struct buffer_text, struct buffer):
2295 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2296 Use EMACS_INT, not int, where int might not be wide enough.
2297 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2298 not int, to avoid needless 32-bit limit on 64-bit hosts.
2299 (exec_byte_code): Use tighter memory-full test, one that checks
2300 for alloca overflow. Don't compute the address of the object just
2301 before an array, as that's not portable. Use EMACS_INT, not
2302 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
2303 * callint.c (Fcall_interactively):
2304 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2305 * callproc.c (call_process_kill, Fcall_process):
2306 Don't assume pid_t fits into an Emacs fixnum.
2307 (call_process_cleanup, Fcall_process, child_setup):
2308 Don't assume pid_t fits into int.
2309 (call_process_cleanup, Fcall_process, delete_temp_file)
2310 (Fcall_process_region):
2311 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2312 (Fcall_process): Simplify handling of volatile integers.
2313 Use int, not EMACS_INT, where int will do.
2314 * casefiddle.c (casify_object, casify_region, operate_on_word)
2315 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2316 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2317 (casify_object): Avoid integer overflow when overallocating buffer.
2318 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
2319 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
2320 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2321 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2322 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2323 integers are now checked earlier. All uses replaced with XINT.
2325 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2326 For CCL_MapSingle, check that content and value are in int range.
2327 (ccl_driver, Fregister_code_conversion_map):
2328 Check that Vcode_version_map_vector is a vector.
2329 (resolve_symbol_ccl_program): Check that vector header is in range.
2330 Always copy the vector, so that we can check its contents reliably
2331 now rather than having to recheck each instruction as it's being
2332 executed. Check that vector words fit in 'int'.
2333 (ccl_get_compiled_code, Fregister_ccl_program)
2334 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2335 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2336 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2337 contents are in range.
2338 (Fccl_execute_on_string): Check that status is in range.
2339 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2340 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2341 Accept and return EMACS_INT, not int, because callers can pass values
2343 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2344 (multibyte_chars_in_text, parse_str_as_multibyte)
2345 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2346 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2347 (string_escape_byte8, Fget_byte):
2348 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2349 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
2350 avoid mishandling large integers.
2351 * character.h: Adjust decls to match defn changes elsewhere.
2352 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2353 (Ffind_charset_region):
2354 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2355 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2356 (load_charset_map_from_vector, Fdefine_charset_internal):
2357 Don't assume fixnum fits in int.
2358 (load_charset_map_from_vector, Fmap_charset_chars):
2359 Remove now-unnecessary CHECK_NATNUMs.
2360 (Fdefine_charset_internal): Check ranges here, more carefully.
2361 Don't rely on undefined behavior with signed left shift overflow.
2362 Don't assume unsigned int fits into fixnum, or that fixnum fits
2363 into unsigned int. Don't require max_code to be a valid fixnum;
2364 that's not true for gb10830 4-byte on a 32-bit host. Allow
2365 invalid_code to be a cons, for the same reason. Require code_offset
2366 to be a character. Avoid int overflow if max_char is close
2368 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2369 this is intended anyway and avoids some undefined behavior.
2370 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2371 INDEX_TO_CODE_POINT, as that's what it expects.
2372 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
2373 * charset.h (DECODE_CHAR): Return int, not unsigned;
2374 this is what was intended anyway, and it avoids undefined behavior.
2375 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2376 integer-overflow issues.
2377 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2378 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2379 where the argument is EMACS_INT, and this behavior is not intended.
2380 * chartab.c (Fmake_char_table, Fset_char_table_range)
2381 (uniprop_get_decoder, uniprop_get_encoder):
2382 Don't assume fixnum fits in int.
2383 * cmds.c (move_point): New function, that does the gist of
2384 Fforward_char and Fbackward_char, but does so while checking
2385 for integer overflow more accurately.
2386 (Fforward_char, Fbackward_char): Use it.
2387 (Fforward_line, Fend_of_line, internal_self_insert)
2388 (internal_self_insert):
2389 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2390 Fix a FIXME, by checking for integer overflow when calculating
2391 target_clm and actual_clm.
2392 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
2393 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
2394 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2395 (coding_alloc_by_making_gap, alloc_destination)
2396 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2397 (encode_coding_utf_16, detect_coding_emacs_mule)
2398 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2399 (detect_coding_iso_2022, decode_coding_iso_2022)
2400 (encode_invocation_designation, encode_designation_at_bol)
2401 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2402 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2403 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2404 (encode_coding_ccl, encode_coding_raw_text)
2405 (detect_coding_charset, decode_coding_charset)
2406 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2407 (produce_composition, produce_charset, produce_annotation)
2408 (decode_coding, handle_composition_annotation)
2409 (handle_charset_annotation, consume_chars, decode_coding_gap)
2410 (decode_coding_object, encode_coding_object, detect_coding_system)
2411 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2412 (code_convert_region, code_convert_string)
2413 (Fdefine_coding_system_internal)
2414 (coding_set_source, coding_set_destination):
2415 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2416 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2417 (Fdefine_coding_system_internal):
2418 Don't assume fixnums fit in int.
2419 (decode_coding_gap, decode_coding_object, encode_coding_object)
2420 (Fread_coding_system, Fdetect_coding_region)
2421 (Funencodable_char_position, Fcheck_coding_systems_region)
2422 (get_translation, handle_composition_annotation, consume_chars):
2423 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2424 (consume_chars): Rewrite to not calculate an address outside buffer.
2425 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
2426 Don't access memory outside of the args array.
2427 (Fdefine_coding_system_internal): Check for charset-id overflow.
2428 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2429 result of ENCODE_CHAR.
2430 * coding.h: Adjust decls to match defn changes elsewhere.
2431 (struct coding_system):
2432 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2433 * composite.c (get_composition_id, find_composition)
2434 (run_composition_function, update_compositions)
2435 (compose_text, composition_gstring_put_cache)
2436 (composition_gstring_p, composition_gstring_width)
2437 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2438 (composition_compute_stop_pos, composition_reseat_it)
2439 (composition_update_it, struct position_record)
2440 (find_automatic_composition, composition_adjust_point)
2441 (Fcomposition_get_gstring, Ffind_composition_internal):
2442 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2443 (update_compositions):
2444 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2445 * composite.h: Adjust decls to match defn changes elsewhere.
2446 (struct composition):
2447 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2448 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2449 Do not attempt to compute the address of the object just before a
2450 buffer; this is not portable.
2452 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2453 (Faset): Use int, not EMACS_INT, where int is wide enough.
2454 (Fstring_to_number): Don't assume fixnums fit in int.
2455 (Frem): Don't assume arg is nonnegative.
2456 * dbusbind.c (xd_append_arg): Check for integers out of range.
2457 (Fdbus_call_method): Don't overflow the timeout int.
2458 (extract_signed, extract_unsigned): New functions.
2459 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2460 (xd_get_connection_references): Return ptrdiff_t, not int.
2462 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2463 (xd_read_message_1):
2464 Use int, not unsigned, where the dbus API uses int.
2465 (Fdbus_message_internal): Don't overflow mtype.
2466 (syms_of_dbusbind): Allocate right-sized buffer for integers.
2467 * dired.c (directory_files_internal, file_name_completion, scmp)
2468 (file_name_completion_stat):
2469 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2470 (file_name_completion): Don't overflow matchcount.
2471 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2472 * dispextern.h: Adjust decls to match defn changes elsewhere.
2473 (struct text_pos, struct glyph, struct bidi_saved_info)
2474 (struct bidi_string_data, struct bidi_it, struct composition_it)
2476 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2477 (struct display_pos, struct composition_it, struct it):
2478 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2479 * dispnew.c (increment_matrix_positions)
2480 (increment_row_positions, mode_line_string)
2481 (marginal_area_string):
2482 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2483 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
2484 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2485 (duration_to_sec_usec): New function, to check for overflow better.
2486 (Fsleep_for, sit_for): Use it.
2487 * doc.c (get_doc_string, store_function_docstring):
2488 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2489 (get_doc_string, Fsnarf_documentation):
2490 Use int, not EMACS_INT, where int is wide enough.
2492 Use SAFE_ALLOCA, not alloca.
2493 Check for overflow when converting EMACS_INT to off_t.
2494 * doprnt.c (doprnt):
2495 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2496 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2497 Don't assume uid_t fits into fixnum.
2498 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2499 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2500 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2501 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2502 (general_insert_function)
2503 (Finsert_char, make_buffer_string, make_buffer_string_both)
2504 (update_buffer_properties, Fbuffer_substring)
2505 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2506 (Fsubst_char_in_region, check_translation)
2507 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2508 (transpose_markers, Ftranspose_regions):
2509 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2510 (clip_to_bounds): Move to lisp.h as an inline function).
2511 (Fconstrain_to_field): Don't assume integers are nonnegative.
2512 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2513 (Fsubst_char_in_region, Fsave_restriction):
2514 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2515 (Femacs_pid): Don't assume pid_t fits into fixnum.
2516 (lo_time): Use int, not EMACS_INT, when int suffices.
2517 (lisp_time_argument): Check for usec out of range.
2518 (Fencode_time): Don't assume fixnum fits in int.
2519 (Fuser_login_name, Fuser_full_name): Signal an error
2520 if a uid argument is out of range, rather than relying on
2522 (Fformat_time_string): Remove now-unnecessary check.
2523 lisp_time_argument checks for out-of-range usec now.
2524 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
2525 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2526 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2527 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2528 (init_cmdargs, Fdump_emacs):
2529 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2530 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2531 the bottom (typically) 32 bits of the fixnum.
2532 * eval.c (specpdl_size, call_debugger):
2533 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2534 (when_entered_debugger, Fbacktrace_debug):
2535 Don't assume fixnum can fit in int.
2536 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2537 the object just before a buffer; this is not portable.
2538 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2539 (grow_specpdl, unbind_to):
2540 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2541 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2542 (grow_specpdl): Simplify allocation by using xpalloc.
2543 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
2544 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2545 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2546 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2547 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2549 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2550 (Fcopy_file, non_regular_nbytes, read_non_regular)
2551 (Finsert_file_contents):
2552 Use int, not EMACS_INT, where int is wide enough.
2553 (READ_BUF_SIZE): Verify that it fits in int.
2554 (Finsert_file_contents): Check that counts are in proper range,
2555 rather than assuming fixnums fit into ptrdiff_t etc.
2556 Don't assume fixnums fit into int.
2557 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
2558 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2559 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
2560 (string_char_to_byte, string_byte_to_char)
2561 (string_make_multibyte, string_to_multibyte)
2562 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2563 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2564 (substring_both, Fdelete, internal_equal, Ffillarray)
2565 (Fclear_string, mapcar1)
2566 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2567 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2568 (larger_vector, make_hash_table, maybe_resize_hash_table)
2569 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2570 (Fmaphash, secure_hash):
2571 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2572 (concat): Check for string index and length overflow.
2573 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2575 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2576 (larger_vector): New API (vec, incr_min, size_max) replaces old
2577 one (vec, new_size, init). This catches size overflow.
2578 INIT was removed because it was always Qnil.
2579 All callers changed.
2580 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2581 the upper bound on a hash table index size.
2582 (make_hash_table, maybe_resize_hash_table): Use it.
2583 (secure_hash): Computer start_byte and end_byte only after
2584 they're known to be in ptrdiff_t range.
2585 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2586 (Ffont_get_glyphs, Ffont_at):
2587 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2588 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2589 (Flist_fonts, Fopen_font):
2590 Don't assume fixnum can fit in int.
2591 (check_gstring): Don't assume index can fit in int.
2592 (font_match_p): Check that fixnum is a character, not a nonnegative
2593 fixnum, since the later code needs to stuff it into an int.
2594 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2595 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2596 conversion overflow issues.
2597 (Fopen_font): Check for integer out of range.
2598 (Ffont_get_glyphs): Don't assume index can fit in int.
2599 * font.h: Adjust decls to match defn changes elsewhere.
2600 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2602 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2603 printmax_t, where ptrdiff_t is wide enough.
2604 (Finternal_char_font):
2605 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2606 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2607 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2608 (Fset_frame_position, x_set_frame_parameters)
2609 (x_set_line_spacing, x_set_border_width)
2610 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2611 Check that fixnums are in proper range for system types.
2612 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2613 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2614 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2615 Use SAFE_ALLOCA_LISP, not alloca.
2616 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2617 intptr_t is wide enough.
2618 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2619 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2620 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2621 Check for fixnum out of range.
2622 * ftfont.c (ftfont_list): Don't assume index fits in int.
2623 Check that fixnums are in proper range for system types.
2624 (ftfont_shape_by_flt):
2625 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2626 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2627 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2628 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2629 Check that fixnums are in proper range for system types.
2630 * gnutls.h: Adjust decls to match defn changes elsewhere.
2631 * gtkutil.c (xg_dialog_run):
2632 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2633 (update_frame_tool_bar):
2634 Check that fixnums are in proper range for system types.
2635 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
2636 (lookup_image): Check that fixnums are in range for system types.
2637 * indent.c (last_known_column, last_known_column_point):
2638 (current_column_bol_cache):
2639 (skip_invisible, current_column, check_display_width):
2640 (check_display_width, scan_for_column, current_column_1)
2641 (Findent_to, Fcurrent_indentation, position_indentation)
2642 (indented_beyond_p, Fmove_to_column, compute_motion):
2643 (Fcompute_motion, Fvertical_motion):
2644 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2645 (last_known_column_modified): Use EMACS_INT, not int.
2646 (check_display_width):
2648 Check that fixnums and floats are in proper range for system types.
2649 (compute_motion): Don't assume index or fixnum fits in int.
2650 (compute_motion, Fcompute_motion):
2651 Use int, not EMACS_INT, when it is wide enough.
2652 (vmotion): Omit local var start_hpos that is always 0; that way
2653 we don't need to worry about overflow in expressions involving it.
2654 * indent.h: Adjust decls to match defn changes elsewhere.
2656 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2657 Use int, not EMACS_INT, where int is wide enough.
2658 Remove unused members ovstring_chars_done and tab_offset;
2660 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2661 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2662 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2663 (make_gap, copy_text, insert, insert_and_inherit)
2664 (insert_before_markers, insert_before_markers_and_inherit)
2665 (insert_1, count_combining_before, count_combining_after)
2666 (insert_1_both, insert_from_string)
2667 (insert_from_string_before_markers, insert_from_string_1)
2668 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2669 (adjust_after_replace, adjust_after_insert, replace_range)
2670 (replace_range_2, del_range, del_range_1, del_range_byte)
2671 (del_range_both, del_range_2, modify_region)
2672 (prepare_to_modify_buffer, signal_before_change)
2673 (signal_after_change, Fcombine_after_change_execute):
2674 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2675 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2676 (balance_an_interval, split_interval_right, split_interval_left)
2677 (find_interval, next_interval, update_interval)
2678 (adjust_intervals_for_insertion, delete_node, delete_interval)
2679 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2680 (static_offset_intervals, offset_intervals)
2681 (merge_interval_right, merge_interval_left, make_new_interval)
2682 (graft_intervals_into_buffer, temp_set_point_both)
2683 (temp_set_point, set_point, adjust_for_invis_intang)
2684 (set_point_both, move_if_not_intangible, get_property_and_range)
2685 (get_local_map, copy_intervals, copy_intervals_to_string)
2686 (compare_string_intervals, set_intervals_multibyte_1):
2687 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2688 * intervals.h: Adjust decls to match defn changes elsewhere.
2690 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2691 * keyboard.c (this_command_key_count, this_single_command_key_start)
2692 (before_command_key_count, before_command_echo_length, echo_now)
2693 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2694 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2695 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2696 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2697 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2698 (last_non_minibuf_size, last_point_position, echo_truncate)
2699 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2700 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2701 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2702 (stuff_buffered_input):
2703 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2704 (last_auto_save, command_loop_1, read_char):
2705 Use EMACS_INT, not int, to avoid integer overflow.
2706 (record_char): Avoid overflow in total_keys computation.
2707 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2708 * keyboard.h: Adjust decls to match defn changes elsewhere.
2709 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2710 (Fkey_description, Fdescribe_vector, Flookup_key):
2711 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2712 (click_position): New function, to check that positions are in range.
2713 (Fcurrent_active_maps):
2715 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2716 (Faccessible_keymaps, Fkey_description):
2717 (preferred_sequence_p):
2718 Don't assume fixnum can fit into int.
2719 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2720 Check for integer overflow in size calculations.
2721 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2722 avoid mishandling large integers.
2723 * lisp.h: Adjust decls to match defn changes elsewhere.
2724 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2725 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2726 (struct Lisp_Marker):
2727 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2728 (clip_to_bounds): Now an inline function, moved here from editfns.c.
2729 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2730 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2731 All callers changed.
2732 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2733 Assume the arg has valid form, since it always does.
2734 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2735 unsigned integer system type.
2736 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2737 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2738 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2739 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2740 (duration_to_sec_usec): New decl.
2741 * lread.c (read_from_string_index, read_from_string_index_byte)
2742 (read_from_string_limit, readchar, unreadchar, openp)
2743 (read_internal_start, read1, oblookup):
2744 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2745 (Fload, readevalloop, Feval_buffer, Feval_region):
2746 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2747 (openp): Check for out-of-range argument to 'access'.
2748 (read1): Use int, not EMACS_INT, where int is wide enough.
2749 Don't assume fixnum fits into int.
2750 Fix off-by-one error that can read outside a buffer.
2751 (read_filtered_event): Use duration_to_sec_usec
2752 to do proper overflow checking on durations.
2753 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2754 in size calculation.
2755 (Fexecute_kbd_macro):
2756 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2757 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2758 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2759 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2760 (set_marker_both, set_marker_restricted_both, marker_position)
2761 (marker_byte_position, Fbuffer_has_markers_at):
2762 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2763 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
2764 * menu.c (ensure_menu_items): Rename from grow_menu_items.
2765 It now merely ensures that the menu is large enough, without
2766 necessarily growing it, as this avoids some integer overflow issues.
2767 All callers changed.
2768 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2769 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2770 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2771 Use SAFE_ALLOCA_LISP, not alloca.
2772 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2773 to EMACS_INT. Check that fixnums are in proper range for system types.
2774 * minibuf.c (minibuf_prompt_width, string_to_object)
2775 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2776 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2777 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2778 (get_minibuffer, read_minibuf_unwind):
2779 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2780 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2781 this simplifies overflow checking. All callers changed.
2782 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2784 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2785 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2786 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2787 Check that fixnums are in proper range for system types.
2788 (Fx_create_frame, Fx_show_tip):
2789 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2790 * nsfont.m (ns_findfonts, nsfont_list_family):
2791 Don't assume fixnum fits in long.
2792 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2793 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2794 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2796 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
2797 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2798 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2799 (PRINTDECLARE, PRINTPREPARE):
2800 (strout, print_string):
2801 (print, print_preprocess, print_check_string_charset_prop)
2803 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2805 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2806 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2807 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
2808 (printchar, strout): Use xpalloc to catch size calculation overflow.
2809 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
2810 (print_error_message): Use SAFE_ALLOCA, not alloca.
2811 (print_object): Use int, not EMACS_INT, where int is wide enough.
2812 (print_depth, new_backquote_output, print_number_index):
2813 Use ptrdiff_t, not int, where int might not be wide enough.
2814 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2815 (Fset_process_window_size, Fformat_network_address)
2816 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
2818 Check that fixnums are in proper range for system types.
2819 (Fsignal_process): Simplify by avoiding a goto.
2820 Check for process-ids out of pid_t range rather than relying on
2822 (process_tick, update_tick): Use EMACS_INT, not int.
2823 (Fformat_network_address, read_process_output, send_process)
2824 (Fprocess_send_region, status_notify):
2825 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2826 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2827 (wait_reading_process_output, read_process_output, exec_sentinel):
2828 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2829 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2830 (Faccept_process_output): Use duration_to_sec_usec to do proper
2831 overflow checking on durations.
2832 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2833 Don't assume pid_t fits in int.
2834 * process.h (struct Lisp_Process): Members tick and update_tick
2835 are now of type EMACS_INT, not int.
2836 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2837 configured --with-wide-int.
2838 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2839 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2840 * search.c (looking_at_1, string_match_1):
2841 (fast_string_match, fast_c_string_match_ignore_case)
2842 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2843 (scan_newline, find_before_next_newline, search_command)
2844 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2845 (set_search_regs, wordify):
2848 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2849 (string_match_1, search_buffer, set_search_regs):
2851 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2852 (wordify): Check for overflow in size calculation.
2853 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2854 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2855 Check that fixnums are in proper range for system types.
2856 * sound.c (struct sound_device)
2857 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2858 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2859 (Fplay_sound_internal):
2860 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2861 * syntax.c (struct lisp_parse_state, find_start_modiff)
2862 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2863 (Fparse_partial_sexp):
2864 Don't assume fixnums can fit in int.
2865 (struct lisp_parse_state, find_start_pos, find_start_value)
2866 (find_start_value_byte, find_start_begv)
2867 (update_syntax_table, char_quoted, dec_bytepos)
2868 (find_defun_start, prev_char_comend_first, back_comment):
2869 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2870 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2871 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2872 (Finternal_describe_syntax_value): Check that match_lisp is a
2873 character, not an integer, since the code stuffs it into int.
2874 (scan_words, scan_sexps_forward):
2875 Check that fixnums are in proper range for system types.
2877 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2878 (scan_sexps_forward):
2879 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2880 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2881 * syntax.h: Adjust decls to match defn changes elsewhere.
2882 (struct gl_state_s):
2883 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2884 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2885 MOST_POSITIVE_FIXNUM.
2886 * sysdep.c (wait_for_termination_1, wait_for_termination)
2887 (interruptible_wait_for_termination, mkdir):
2888 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2889 (emacs_read, emacs_write):
2890 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2891 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2892 and double all fit in int.
2893 * term.c (set_tty_color_mode):
2894 Check that fixnums are in proper range for system types.
2895 * termhooks.h (struct input_event):
2896 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2897 * textprop.c (validate_interval_range, interval_of)
2898 (Fadd_text_properties, set_text_properties_1)
2899 (Fremove_text_properties, Fremove_list_of_text_properties)
2900 (Ftext_property_any, Ftext_property_not_all)
2901 (copy_text_properties, text_property_list, extend_property_ranges)
2902 (verify_interval_modification):
2903 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2904 (Fnext_single_char_property_change)
2905 (Fprevious_single_char_property_change):
2906 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2907 (copy_text_properties):
2908 Check for integer overflow in index calculation.
2909 * undo.c (last_boundary_position, record_point, record_insert)
2910 (record_delete, record_marker_adjustment, record_change)
2911 (record_property_change):
2912 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2913 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2914 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2915 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2916 (Fx_hide_tip, Fx_file_dialog):
2917 * w32menu.c (set_frame_menubar):
2918 Use ptrdiff_t, not int, for consistency with rest of code.
2919 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2920 (select_window, Fdelete_other_windows_internal)
2921 (window_scroll_pixel_based, window_scroll_line_based)
2922 (Frecenter, Fset_window_configuration):
2923 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2924 (Fset_window_hscroll, run_window_configuration_change_hook)
2925 (set_window_buffer, temp_output_buffer_show, scroll_command)
2926 (Fscroll_other_window, Frecenter):
2927 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2928 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2929 Don't assume fixnum fits in int.
2930 (Fset_window_scroll_bars):
2931 Check that fixnums are in proper range for system types.
2932 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2933 (string_pos, c_string_pos, number_of_chars, init_iterator)
2934 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2935 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2936 (compute_display_string_end, handle_face_prop)
2937 (face_before_or_after_it_pos, handle_invisible_prop)
2938 (handle_display_prop, handle_display_spec, handle_single_display_spec)
2939 (display_prop_intangible_p, string_buffer_position_lim)
2940 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2941 (get_overlay_strings_1, get_overlay_strings)
2942 (iterate_out_of_display_property, forward_to_next_line_start)
2943 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2944 (get_next_display_element, set_iterator_to_next)
2945 (get_visually_first_element, compute_stop_pos_backwards)
2946 (handle_stop_backwards, next_element_from_buffer)
2947 (move_it_in_display_line_to, move_it_in_display_line)
2948 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2949 (add_to_log, message_dolog, message_log_check_duplicate)
2950 (message2, message2_nolog, message3, message3_nolog
2951 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2952 (current_message_1, truncate_echo_area, truncate_message_1)
2953 (set_message, set_message_1, store_mode_line_noprop)
2954 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2955 (text_outside_line_unchanged_p, check_point_in_composition)
2956 (reconsider_clip_changes)
2957 (redisplay_internal, set_cursor_from_row, try_scrolling)
2958 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2959 (redisplay_window, find_last_unchanged_at_beg_row)
2960 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2961 (trailing_whitespace_p, find_row_edges, display_line)
2962 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2963 (display_mode_element, store_mode_line_string)
2964 (pint2str, pint2hrstr, decode_mode_spec)
2965 (display_count_lines, display_string, draw_glyphs)
2966 (x_produce_glyphs, x_insert_glyphs)
2967 (rows_from_pos_range, mouse_face_from_buffer_pos)
2968 (fast_find_string_pos, mouse_face_from_string_pos)
2969 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2970 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2971 (safe_call, init_from_display_pos, handle_fontified_prop)
2972 (handle_single_display_spec, load_overlay_strings)
2973 (with_echo_area_buffer, setup_echo_area_for_printing)
2974 (display_echo_area, echo_area_display)
2975 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2976 (update_tool_bar, hscroll_window_tree, redisplay_internal)
2977 (redisplay_window, dump_glyph_row, display_mode_line)
2978 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
2979 (handle_display_spec, display_prop_string_p):
2980 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2981 (handle_single_display_spec, build_desired_tool_bar_string)
2982 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2983 (get_specified_cursor_type):
2984 Check that fixnums are in proper range for system types.
2985 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2986 (Flookup_image_map):
2987 Don't assume fixnums fit in int.
2988 (compare_overlay_entries):
2989 Avoid mishandling comparisons due to subtraction overflow.
2990 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2991 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2992 (handle_tool_bar_click):
2993 Use int, not unsigned, since we prefer signed and the signedness
2994 doesn't matter here.
2995 (get_next_display_element, next_element_from_display_vector):
2996 Use int, not EMACS_INT, when int is wide enough.
2997 (start_hourglass): Use duration_to_sec_usec to do proper
2998 overflow checking on durations.
2999 * xfaces.c (Fbitmap_spec_p):
3000 Check that fixnums are in proper range for system types.
3001 (compare_fonts_by_sort_order):
3002 Avoid mishandling comparisons due to subtraction overflow.
3003 (Fx_family_fonts, realize_basic_faces):
3004 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3006 Don't assume fixnum fits in int.
3007 Use SAFE_ALLOCA_LISP, not alloca.
3008 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3009 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3010 (face_at_buffer_position, face_for_overlay_string)
3011 (face_at_string_position):
3012 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3013 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3014 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3016 Check that fixnums are in proper range for system types.
3017 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3018 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3019 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3020 (Fx_change_window_property): Don't assume fixnums fit in int.
3021 * xfont.c (xfont_chars_supported):
3022 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3023 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3024 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3025 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3026 * xml.c (parse_region):
3027 * xrdb.c (magic_file_p):
3028 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3029 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3030 (x_get_local_selection, x_reply_selection_request)
3031 (x_handle_selection_request, wait_for_property_change):
3032 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3033 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3034 short is wide enough.
3035 (x_send_client_event): Don't assume fixnum fits in int.
3036 * xterm.c (x_x_to_emacs_modifiers):
3037 Don't assume EMACS_INT overflows nicely into int.
3038 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3040 (handle_one_xevent): NATNUMP can eval its arg twice.
3041 (x_connection_closed):
3042 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3043 * xterm.h: Adjust decls to match defn changes elsewhere.
3044 (struct scroll_bar): Use struct vectorlike_header
3045 rather than rolling our own approximation.
3046 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3048 2012-05-25 Glenn Morris <rgm@gnu.org>
3050 * lisp.mk (lisp): Update for more files being compiled now.
3052 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3054 * lread.c: Remove `read_pure' which makes no difference.
3055 (read_pure): Remove var.
3056 (unreadpure): Remove function.
3057 (readevalloop): Don't call read_list with -1 flag.
3058 (read1, read_vector): Don't test read_pure any more.
3059 (read_list): Simplify.
3061 * fileio.c, character.h: Minor style tweaks.
3063 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3065 * window.h (clip_changed): Remove useless declaration.
3067 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
3069 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3070 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3072 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3075 This directory predates autoconf and is no longer needed nowadays.
3076 Move its few remaining bits of functionality to where they're needed.
3077 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3078 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3079 * m/template.h: Remove.
3080 * Makefile.in (M_FILE): Remove. All uses removed.
3081 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3082 * lisp.h (USE_LSB_TAG):
3083 * mem-limits.h (EXCEEDS_LISP_PTR):
3084 Use VAL_MAX, not VALBITS, in #if.
3085 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3086 (EMACS_UINT): Define unconditionally now.
3087 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3088 (BITS_PER_EMACS_INT): New constants, replacing
3089 what used to be in config.h, but not useful in #if.
3090 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3091 define them any more.
3092 (VAL_MAX): New macro.
3094 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3095 BITS_PER_EMACS_INT, in #if.
3096 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3097 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3098 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3099 * s/ms-w32.h (DATA_START):
3100 Move here from removed file m/intel386.h.
3101 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3102 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3104 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3106 Assume C89 or later.
3107 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3108 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3110 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3111 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3112 * textprop.c, tparam.c (NULL): Remove.
3113 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3114 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3115 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3116 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3117 * xterm.c (input_signal_count): Assume volatile works.
3119 2012-05-21 Ken Brown <kbrown@cornell.edu>
3121 * xgselect.c (xg_select): Fix first argument in call to 'select'
3124 2012-05-20 Ken Brown <kbrown@cornell.edu>
3126 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
3127 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
3129 2012-05-19 Ken Brown <kbrown@cornell.edu>
3131 * xfns.c (x_in_use): Remove `static' qualifier.
3132 * xterm.h (x_in_use): Declare.
3133 * xgselect.c: Include xterm.h.
3134 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3135 and `display_arg' (bug#9754).
3137 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3139 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3141 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3142 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3144 2012-05-18 Eli Zaretskii <eliz@gnu.org>
3146 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3148 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
3149 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
3151 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3152 reference to image_cache->refcount.
3153 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3155 2012-05-17 Juri Linkov <juri@jurta.org>
3157 * search.c (Fword_search_regexp, Fword_search_backward)
3158 (Fword_search_forward, Fword_search_backward_lax)
3159 (Fword_search_forward_lax): Move functions to isearch.el
3160 (bug#10145, bug#11381).
3162 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3164 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3166 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3168 * lread.c (init_obarray): Declare Qt and Qnil as special.
3170 2012-05-14 Glenn Morris <rgm@gnu.org>
3172 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
3173 Put "libexec" before "bin", for the sake of init_callproc_1.
3175 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3177 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3179 * unexaix.c: Port to more-recent AIX compilers.
3180 (report_error, report_error_1, make_hdr, copy_sym)
3181 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3182 Make arguments const char *, not char *, to avoid violations of C
3183 standard and to fix some AIX warnings reported by Gilles Pion.
3185 2012-05-14 Eli Zaretskii <eliz@gnu.org>
3187 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3188 already have overlays loaded.
3189 (handle_single_display_spec): Before returning without displaying
3190 fringe bitmap, synchronize the bidi iterator with the main display
3191 iterator, by calling iterate_out_of_display_property.
3192 (iterate_out_of_display_property): Detect buffer iteration by
3193 testing that it->string is a Lisp string.
3194 (get_next_display_element): When the current object is exhausted,
3195 and there's something on it->stack, call set_iterator_to_next to
3196 proceed with what's on the stack, instead of returning zero.
3197 (set_iterator_to_next): If called at the end of a Lisp string,
3198 proceed to consider_string_end without incrementing string
3199 position. Don't increment display vector index past the end of
3200 the display vector. (Bug#11417)
3201 (pos_visible_p): Don't report a position visible when move_it_to
3202 stopped at the last line of window, which happens to be scanned
3203 backwards by the bidi iteration. (Bug#11464)
3205 2012-05-14 Eli Zaretskii <eliz@gnu.org>
3207 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3208 and right-margin display specs even if the spec is invalid or we
3209 are on a TTY, and thus unable to display on the fringes.
3210 That's because the text with the property will not be displayed anyway,
3211 so we need to signal to the caller that this is a "replacing"
3212 display spec. This fixes display when the spec is invalid or we
3215 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3217 * unexaix.c (make_hdr): Fix typo in prototype.
3218 This bug broke the build on AIX. Problem reported by Gilles Pion.
3220 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
3222 * keyboard.c (kbd_buffer_get_event): Read special events also in
3223 batch mode. (Bug#11415)
3225 2012-05-12 Glenn Morris <rgm@gnu.org>
3227 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3229 2012-05-12 Eli Zaretskii <eliz@gnu.org>
3231 * lisp.mk (lisp): Add newcomment.elc.
3233 2012-05-12 Glenn Morris <rgm@gnu.org>
3235 * Makefile.in (MKDIR_P): New, set by configure.
3236 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3238 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3240 Remove unused function hourglass_started.
3241 * dispextern.h (hourglass_started):
3242 * w32fns.c (hourglass_started):
3243 * xdisp.c (hourglass_started): Remove.
3245 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
3247 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3248 Update dependencies.
3250 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3252 * xgselect.c (xg_select): Put maxfds+1 into a var.
3253 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3255 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3257 2012-05-10 Dave Abrahams <dave@boostpro.com>
3259 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3260 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3262 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
3264 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3265 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3266 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3267 Initialize xd_registered_buses.
3269 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3271 Untag more efficiently if USE_LSB_TAG.
3272 This is based on a proposal by YAMAMOTO Mitsuharu in
3273 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3274 For an admittedly artificial (nth 8000 longlist) benchmark on
3275 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3276 Emacs's overall text size by 1%.
3277 * lisp.h (XUNTAG): New macro.
3278 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3279 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3280 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3281 * eval.c (Fautoload):
3282 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3283 * frame.h (XFRAME): Use XUNTAG.
3285 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3286 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3287 Remove unportable assumptions about print widths of types like
3289 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3290 intptr_t when converting between pointer and integer, to avoid GCC
3291 warnings about wrong width.
3293 2012-05-09 Eli Zaretskii <eliz@gnu.org>
3295 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3296 stack for each reader_thread, instead of defaulting to 8MB
3297 determined by the linker. This avoids failures in creating
3298 subprocesses on Windows 7, see the discussion in this thread:
3299 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3301 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3303 Fix up display of the *Minibuf-0* buffer in the mini window.
3304 * keyboard.c (read_char): Don't clear the echo area if there's no
3306 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
3307 contents of *Minibuf-0*) if there's no message displayed in its stead.
3309 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
3311 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3314 2012-05-06 Chong Yidong <cyd@gnu.org>
3316 * lisp.mk (lisp): Update.
3318 2012-05-05 Jim Meyering <meyering@redhat.com>
3320 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3322 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3324 * data.c (PUT_ERROR): New macro.
3325 (syms_of_data): Use it. Add new error type `user-error'.
3326 * undo.c (user_error): New function.
3327 (Fprimitive_undo): Use it.
3328 * print.c (print_error_message): Adjust print style for `user-error'.
3329 * keyboard.c (user_error): New function.
3330 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3332 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3334 Do not limit current-time-string to years 1000..9999.
3335 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3336 (Fcurrent_time_string): Support any year that is supported by the
3337 underlying localtime representation. Don't use asctime, as it
3338 has undefined behavior for years outside the range -999..9999.
3340 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3342 Fix race conditions involving setenv, gmtime, localtime, asctime.
3343 Without this fix, interrupts could mess up code that uses these
3344 nonreentrant functions, since setting TZ invalidates existing
3345 tm_zone or tzname values, and since most of these functions return
3346 pointers to static storage.
3347 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3348 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3349 Grow the critical sections to include not just invoking
3350 localtime/gmtime, but also accessing these functions' results
3351 including their tm_zone values if any, and any related TZ setting.
3352 (format_time_string): Last arg is now struct tm *, not struct tm **,
3353 so that the struct tm is saved in the critical section.
3354 All callers changed. Simplify allocation of initial buffer, partly
3355 motivated by the fact that memory allocation needs to be outside
3356 the critical section.
3358 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3360 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3361 with RESET_INTERVAL.
3363 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3364 Remove duplicated buffer name initialization.
3366 2012-05-02 Jim Meyering <jim@meyering.net>
3368 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3370 * xfns.c (x_window): Use xstrdup (Bug#11375).
3372 2012-05-02 Eli Zaretskii <eliz@gnu.org>
3374 * xdisp.c (pos_visible_p): If already at a newline from the
3375 display string before the 'while' loop, don't walk back the glyphs
3376 from it3.glyph_row. Solves assertion violation when the display
3377 string begins with a newline (egg.el). (Bug#11367)
3379 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3381 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3384 2012-05-01 Glenn Morris <rgm@gnu.org>
3386 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3387 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3388 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3389 All were removed before 23.1.
3391 * dispnew.c: Remove HAVE_LIBNCURSES test;
3392 it is always true on relevant platforms.
3394 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3395 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3397 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3399 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3401 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3402 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3405 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3407 Do not avoid creating empty evaporating overlays (Bug#9642).
3408 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3409 That is, do not delete an evaporating overlay if it becomes
3410 empty after its bounds are adjusted to fit within its buffer.
3411 This fix caused other problems, and I'm reverting it until we get
3412 to the bottom of them.
3414 2012-04-27 Chong Yidong <cyd@gnu.org>
3416 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3418 2012-04-27 Eli Zaretskii <eliz@gnu.org>
3420 * xdisp.c (pos_visible_p): If the window start position is beyond
3421 ZV, start the display from buffer beginning. Prevents assertion
3422 violation in init_iterator when the minibuffer window is scrolled
3425 * window.c (window_scroll_pixel_based): Likewise.
3427 2012-04-27 Chong Yidong <cyd@gnu.org>
3429 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3431 2012-04-27 Glenn Morris <rgm@gnu.org>
3433 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3434 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3436 2012-04-27 Eli Zaretskii <eliz@gnu.org>
3438 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3439 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
3441 2012-04-26 Eli Zaretskii <eliz@gnu.org>
3443 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3444 display element, check also the underlying string or buffer
3445 character. (Bug#11341)
3447 * w32menu.c: Include w32heap.h.
3448 (add_menu_item): If the call to AppendMenuW (via
3449 unicode_append_menu) fails, disable Unicode menus only if we are
3450 running on Windows 9X/Me.
3452 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3454 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3455 (xgetint): Add missing shift for LSB tags.
3457 2012-04-24 Martin Rudalics <rudalics@gmx.at>
3459 * keyboard.c (read_char): Don't wipe echo area for select window
3460 events: These might get delayed via `mouse-autoselect-window'
3463 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
3465 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3466 manipulation of :loaded-from data.
3468 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
3470 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3471 now a cons (bug#11311).
3473 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3475 Do not create empty overlays with the evaporate property (Bug#9642).
3476 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3477 if it becomes empty after its bounds are adjusted to fit within
3478 its buffer. Without this fix, in a nonempty buffer (let ((o
3479 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3480 yields an empty overlay that has the evaporate property, which is
3481 not supposed to happen.
3483 Fix minor GTK3 problems found by static checking.
3484 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3485 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3486 (struct _EmacsFixedClass, emacs_fixed_get_type):
3487 Move decls here from emacsgtkfixed.h, since they needn't be public.
3488 (emacs_fixed_get_type): Now static.
3489 (emacs_fixed_class_init): Omit unused local.
3490 (emacs_fixed_child_type): Remove; unused.
3491 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3492 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3493 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3494 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3495 (EMACS_FIXED_GET_CLASS): Remove; unused.
3496 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3498 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3499 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3501 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3503 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
3504 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
3505 (__malloc_size_t, __malloc_ptrdiff_t):
3506 Remove. All uses removed, replaced by the definiens if needed,
3507 since we can assume C89 or better now.
3508 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3509 (protect_malloc_state, align, get_contiguous_space)
3510 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3511 (malloc_atfork_handler_child, malloc_enable_thread)
3512 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3513 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3514 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3515 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3516 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3517 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3518 Define using prototypes, not old style.
3519 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3520 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3521 (align): Don't assume that signed integer overflow wraps around.
3522 Omit unused local var.
3523 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3524 (_free_internal_nolock, memalign, mallochook, reallochook):
3525 Omit no-longer-needed casts.
3526 (valloc): Use getpagesize, not __getpagesize.
3527 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3528 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3530 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3532 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
3534 Move functions from C to Lisp. Make non-blocking method calls
3535 the default. Implement further D-Bus standard interfaces.
3537 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3538 (QCdbus_request_name_allow_replacement)
3539 (QCdbus_request_name_replace_existing)
3540 (QCdbus_request_name_do_not_queue)
3541 (QCdbus_request_name_reply_primary_owner)
3542 (QCdbus_request_name_reply_in_queue)
3543 (QCdbus_request_name_reply_exists)
3544 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3545 (QCdbus_registered_serial, QCdbus_registered_method)
3546 (QCdbus_registered_signal): New Lisp objects.
3547 (XD_DEBUG_MESSAGE): Use sizeof.
3548 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3549 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3550 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3551 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3552 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3553 (xd_signature, xd_append_arg): Allow float for integer types.
3554 (xd_get_connection_references): New function.
3555 (xd_get_connection_address): Rename from xd_initialize.
3556 Return cached address.
3557 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3558 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3560 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
3561 Return number of refcounts.
3562 (Fdbus_get_unique_name): Make stronger parameter check.
3563 (Fdbus_message_internal): New defun.
3564 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3565 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3566 (Fdbus_send_signal, Fdbus_register_service)
3567 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3568 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3569 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3570 (Vdbus_compiled_version, Vdbus_runtime_version)
3571 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3572 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3573 (Vdbus_message_type_signal): New defvars.
3574 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3577 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3579 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3580 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3581 Do not assume ptrdiff_t is the same width as 'int'.
3583 * alloc.c: Handle unusual debugging option combinations.
3584 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3585 since the two debugging options are incompatible.
3586 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3588 (mem_init, mem_insert, mem_insert_fixup):
3589 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3590 (NEED_MEM_INSERT): Remove; no longer needed.
3592 2012-04-22 Leo Liu <sdl.web@gmail.com>
3594 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3596 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3598 * sysdep.c [__FreeBSD__]: Minor cleanups.
3599 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3600 Use Emacs indenting style more consistently. Avoid some casts.
3601 Use 'double' consistently rather than mixing 'float' and 'double'.
3603 2012-04-21 Eduard Wiebe <usenet@pusto.de>
3605 * sysdep.c (list_system_processes, system_process_attributes):
3606 Add implementation for FreeBSD (Bug#5243).
3608 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3610 * lisp.mk (lisp): Update.
3612 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3614 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3615 It is never used otherwise.
3617 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3619 * print.c (print_preprocess): Only check print_depth if print-circle
3621 (print_object): Check for cycles even when print-circle is nil and
3622 print-gensym is t, but only check print_depth if print-circle is nil.
3624 2012-04-20 Chong Yidong <cyd@gnu.org>
3626 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3627 set the status to "failed" and ensure that sentinel is run.
3629 2012-04-20 Glenn Morris <rgm@gnu.org>
3631 * process.c (Fset_process_inherit_coding_system_flag)
3632 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
3633 (Fmake_network_process, Fmake_serial_process): Doc fix.
3635 2012-04-20 Eli Zaretskii <eliz@gnu.org>
3637 * xdisp.c (string_buffer_position_lim): Limit starting position to
3639 (set_cursor_from_row): If called for a mode-line or header-line
3640 row, return zero immediately.
3641 (try_cursor_movement): If inside continuation line, don't back up
3642 farther than the first row after the header line, if any.
3643 Don't consider the header-line row as "partially visible", even if
3644 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3646 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
3648 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3651 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
3652 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
3654 configure: new option --enable-gcc-warnings (Bug#11207)
3655 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3656 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3657 (ALL_CFLAGS): Use new macros rather than old.
3658 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3659 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3660 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3661 -Wunused-result, -Wunused-variable. This should go away once
3662 the Emacs and Gnulib regex code is merged.
3663 (xmalloc, xrealloc): Now static.
3665 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3667 * dired.c (Fsystem_groups): Remove unused local.
3669 2012-04-17 Glenn Morris <rgm@gnu.org>
3671 * dired.c (Fsystem_users): Doc fix.
3673 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3675 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3676 (syms_of_dired): Add them.
3678 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3680 Fix minor alloc.c problems found by static checking.
3681 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3682 New extern decls, to avoid calling undeclared functions.
3683 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3684 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3685 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3686 (NEED_MEM_INSERT): New macro.
3687 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
3688 Remove one incorrect comment and fix another.
3690 Fix minor ralloc.c problems found by static checking.
3691 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3692 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3693 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3694 (r_alloc_sbrk): Now static.
3696 Improve ralloc.c interface checking.
3697 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3698 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3699 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3700 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3701 [REL_ALLOC]: ... to here, to check interface.
3702 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3703 Remove decls. This fixes an "It stinks!".
3705 * alloc.c (which_symbols): Fix alignment issue / type clash.
3707 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3709 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3710 (struct Lisp_Misc_Any): Likewise.
3711 (struct Lisp_Free): Likewise.
3712 * alloc.c (union aligned_Lisp_Symbol): Define.
3713 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3714 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3715 (union aligned_Lisp_Misc): Define.
3716 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3717 aligned_Lisp_Misc instead of union Lisp_Misc.
3718 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
3720 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3722 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3723 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3724 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3725 * s/netbsd.h, s/sol2-6.h:
3726 Remove definition of GC_MARK_STACK, since the default now works.
3727 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3728 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3729 no longer the default.
3730 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3732 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
3734 * lread.c (lisp_file_lexically_bound_p):
3735 Fix hang at ";-*-\n" (bug#11238).
3737 2012-04-14 Eli Zaretskii <eliz@gnu.org>
3739 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3740 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3742 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3744 * nsterm.m (constrainFrameRect): Always constrain when there is only
3745 one screen (Bug#10962).
3747 2012-04-13 Ken Brown <kbrown@cornell.edu>
3749 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3751 2012-04-13 Reuben Thomas <rrt@sc3d.org>
3753 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3755 2012-04-11 Daniel Colascione <dancol@dancol.org>
3757 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3758 against is gone. It's better to use vfork now so that when Cygwin
3759 gains a new, working vfork, we use it automatically (bug#10398).
3761 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3763 * window.c (save_window_save): Obey window-point-insertion-type.
3765 2012-04-11 Glenn Morris <rgm@gnu.org>
3767 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3769 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3771 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3773 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
3775 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3776 (force_quit_count): New var.
3777 (handle_interrupt): Use it.
3779 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
3781 * w32.c (w32_delayed_load): Record the full path of the library
3782 being loaded (bug#10424).
3784 2012-04-09 Glenn Morris <rgm@gnu.org>
3786 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3787 not just in the obarray, before snarfing them. (Bug#11036)
3789 * Makefile.in ($(leimdir)/leim-list.el):
3790 Pass EMACS rather than BUILT_EMACS.
3792 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3794 * process.c (make_process):
3795 * process.h: Add integer `gnutls_handshakes_tried' member to
3798 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3799 Add convenience `GNUTLS_LOG2i' macro.
3801 * gnutls.c (gnutls_log_function2i): Convenience log function.
3802 (emacs_gnutls_read): Use new log functions,
3803 `gnutls_handshakes_tried' process member, and
3804 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3805 attempts per process (connection).
3807 2012-04-09 Chong Yidong <cyd@gnu.org>
3809 * eval.c (Fuser_variable_p, user_variable_p_eh)
3810 (lisp_indirect_variable): Functions deleted.
3811 (Fdefvar): Caller changed.
3813 * callint.c (Finteractive, Fcall_interactively):
3814 * minibuf.c (Fread_variable): Callers changed.
3816 2012-04-09 Eli Zaretskii <eliz@gnu.org>
3818 * xdisp.c (set_cursor_from_row): If the display string appears in
3819 the buffer at position that is closer to point than the position
3820 after the display string, display the cursor on the first glyph of
3821 the display string. Fixes cursor display when a 'display' text
3822 property immediately follows invisible text. (Bug#11094)
3824 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3826 composite.c: use 'double' consistently
3827 * composite.c (get_composition_id): Use 'double' consistently
3828 instead of converting 'float' to 'double' and vice versa; this is
3829 easier to understand and avoids a GCC warning.
3831 2012-04-09 Glenn Morris <rgm@gnu.org>
3833 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3834 preparation for dumping it with emacs. (Bug#4789)
3835 (leimdir): New variable.
3836 ($(leimdir)/leim-list.el): New rule.
3837 (emacs$(EXEEXT)): Depend on leim-list.el.
3839 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3840 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3841 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3843 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3845 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3848 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
3850 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3851 Remove unused local variable.
3853 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3855 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3856 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3857 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3858 objects, as mark_maybe_pointer will catch them otherwise.
3859 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3860 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3862 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3864 Fix typo that broke non-Windows builds.
3865 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3867 2012-04-07 Eli Zaretskii <eliz@gnu.org>
3869 Support building on MS-Windows with libxml2.
3871 * makefile.w32-in (OBJ2): Add xml.$(O).
3872 (GLOBAL_SOURCES): Add xml.c.
3873 ($(BLD)/xml.$(O)): New dependency list.
3875 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3876 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3877 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3878 [!WINDOWSNT]: New macros.
3879 (init_libxml2_functions, libxml2_loaded_p): New functions.
3880 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3881 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3882 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3883 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3885 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3886 Call init_libxml2_functions before calling libxml2 functions.
3887 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3889 * emacs.c: Don't include libxml/parser.h.
3890 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3891 xmlCleanupParser directly.
3893 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3895 2012-04-07 Eli Zaretskii <eliz@gnu.org>
3897 * indent.c (Fvertical_motion): If there is a display string at
3898 point, use it.vpos to compute how many lines to backtrack after
3899 move_it_to point. (Bug#11133)
3901 2012-04-06 Eli Zaretskii <eliz@gnu.org>
3903 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3904 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3905 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3906 macros related to unification of CJK characters. For the details,
3907 see the discussion following the message here:
3908 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3910 2012-04-04 Chong Yidong <cyd@gnu.org>
3912 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3914 2012-04-01 Eli Zaretskii <eliz@gnu.org>
3916 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3917 instead of alloca. (Bug#11138)
3919 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3921 * w32menu.c (is_simple_dialog): Properly check lisp types.
3924 2012-03-31 Eli Zaretskii <eliz@gnu.org>
3926 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3927 position we get to after a call to move_it_to fails the
3928 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3929 only if we wind up in a string from display property. (Bug#11063)
3931 * window.c (Fdelete_other_windows_internal): Invalidate the row
3932 and column information about mouse highlight, so that redisplay
3933 restores it after reallocating the glyph matrices. (Bug#7464)
3935 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3936 string comes from a `display' text property, use the buffer
3937 position of that property as if we actually saw that position in
3939 (move_it_by_lines): Remove the assertion that
3940 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3941 violated when there's a before-string at the beginning of a line.
3944 2012-03-30 Eli Zaretskii <eliz@gnu.org>
3946 * xdisp.c (append_space_for_newline): If the default face was
3947 remapped, use the remapped face for the appended newline.
3948 (extend_face_to_end_of_line): Use the remapped default face for
3949 extending the face to the end of the line.
3950 (display_line): Call extend_face_to_end_of_line when the default
3951 face was remapped. (Bug#11068)
3953 2012-03-29 Eli Zaretskii <eliz@gnu.org>
3955 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3957 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3959 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3961 2012-03-27 Glenn Morris <rgm@gnu.org>
3963 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3966 2012-03-26 Kenichi Handa <handa@m17n.org>
3968 * dispextern.h (struct glyph): Fix previous change. Change the
3969 bit length of glyphless.ch to 25 (Bug#11082).
3971 2012-03-26 Chong Yidong <cyd@gnu.org>
3973 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3974 (command_loop_1): Use it; inhibit selection update for
3975 handle-select-window too (Bug#8996).
3977 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3979 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
3981 2012-03-25 Kenichi Handa <handa@m17n.org>
3983 * dispextern.h (struct glyph): Change the bit length of
3984 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3986 2012-03-24 Eli Zaretskii <eliz@gnu.org>
3988 * s/ms-w32.h (tzname): Include time.h before redirecting to
3989 _tzname. Fixes the MSVC build. (Bug#9960)
3991 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3993 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3996 * xterm.c (XTread_socket): Only modify handling_signal if
3997 !SYNC_INPUT. (Bug#11080)
3999 2012-03-23 Eli Zaretskii <eliz@gnu.org>
4001 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4002 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4003 when fetching a multibyte character consumes more bytes than
4004 CHAR_BYTES returns, due to unification of CJK characters in
4005 string_char. (Bug#11073)
4007 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4009 * process.c (wait_reading_process_output): Handle pty disconnect
4010 by refraining from sending oneself a SIGCHLD (bug#10933).
4012 2012-03-22 Chong Yidong <cyd@gnu.org>
4014 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4016 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
4017 Mark string as coming from a prefix property.
4018 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4019 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4021 2012-03-21 Chong Yidong <cyd@gnu.org>
4023 * xfaces.c (Vface_remapping_alist): Doc fix.
4025 2012-03-20 Eli Zaretskii <eliz@gnu.org>
4027 * w32proc.c (Fw32_set_console_codepage)
4028 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4031 2012-03-20 Chong Yidong <cyd@gnu.org>
4033 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4034 to reflect default non-nil value of redisplay-dont-pause.
4036 2012-03-19 Kenichi Handa <handa@m17n.org>
4038 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4039 it fit in a valid range (Bug#11003).
4041 2012-03-18 Eli Zaretskii <eliz@gnu.org>
4043 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4044 that is not from display property, accept the row as a "cursor
4045 row" if one of the string's character has a non-nil `cursor'
4046 property. Fixes cursor positioning when there are newlines in
4047 overlay strings, e.g. in icomplete.el. (Bug#11035)
4049 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4051 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4053 2012-03-12 Chong Yidong <cyd@gnu.org>
4055 * eval.c (inhibit_lisp_code): Rename from
4056 inhibit_window_configuration_change_hook; move from window.c.
4058 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4059 * window.c (run_window_configuration_change_hook)
4060 (syms_of_window): Callers changed.
4062 2012-03-11 Chong Yidong <cyd@gnu.org>
4064 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4066 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4068 2012-03-10 Chong Yidong <cyd@gnu.org>
4070 * frame.c (other_visible_frames): Don't assume the selected frame
4071 is visible (Bug#10955).
4073 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4075 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4077 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4079 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4080 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4083 2012-03-03 Glenn Morris <rgm@gnu.org>
4085 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
4087 2012-03-02 Eli Zaretskii <eliz@gnu.org>
4089 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4090 position past the first glyph_row that ends at ZV. (Bug#10902)
4091 (redisplay_window, next_element_from_string): Fix typos in
4093 (redisplay_window): Pass to move_it_vertically the margin in
4094 pixels, not in screen lines.
4096 2012-03-02 Glenn Morris <rgm@gnu.org>
4098 * buffer.c (buffer-list-update-hook): Doc fix.
4100 2012-02-29 Eli Zaretskii <eliz@gnu.org>
4102 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4103 push_it before setting up the iterator for the first overlay
4104 string, even if we have an empty string loaded.
4105 (next_overlay_string): If there's an empty string on the iterator
4106 stack, pop the stack. (Bug#10903)
4108 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4110 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4111 Suggested by Stefan Monnier in
4112 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4113 * alloc.c (widen_to_Lisp_Object): New static function.
4114 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4115 and widening them to Lisp_Objects. This would work even if
4116 USE_LSB_TAG is defined and wide integers are used, which might
4117 happen in a future version of Emacs.
4119 2012-02-25 Chong Yidong <cyd@gnu.org>
4121 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4124 * xselect.c (Fx_selection_exists_p): Doc fix.
4125 (x_clipboard_manager_save_all): Print an informative message
4126 before saving to clipboard manager.
4128 2012-02-24 Chong Yidong <cyd@gnu.org>
4130 * keyboard.c (process_special_events): Handle all X selection
4131 requests in kbd_buffer, not just the next one (Bug#8869).
4133 2012-02-23 Chong Yidong <cyd@gnu.org>
4135 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4136 call when setting menu-bar-lines and tool-bar-lines parameters.
4137 (unwind_create_frame_1): New helper function.
4139 * window.c (inhibit_window_configuration_change_hook): New var.
4140 (run_window_configuration_change_hook): Obey it.
4141 (syms_of_window): Initialize it.
4143 2012-02-22 Chong Yidong <cyd@gnu.org>
4145 * xterm.c (x_draw_image_relief): Add missing type check for
4146 Vtool_bar_button_margin (Bug#10743).
4148 2012-02-21 Chong Yidong <cyd@gnu.org>
4150 * fileio.c (Vfile_name_handler_alist): Doc fix.
4152 * buffer.c (Fget_file_buffer): Protect against invalid file
4153 handler return value.
4155 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4157 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4158 when computing $valmask.
4160 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4161 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4162 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4163 It's useless in that case, and it can cause problems on hosts
4164 that allocate halves of EMACS_INT values separately.
4165 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4166 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4167 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4168 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4169 it avoids undefined behavior on hosts where shifting right by more
4170 than the word width has undefined behavior.
4172 2012-02-19 Chong Yidong <cyd@gnu.org>
4174 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4175 (Funhandled_file_name_directory, Ffile_name_as_directory)
4176 (Fdirectory_file_name, Fexpand_file_name)
4177 (Fsubstitute_in_file_name): Protect against invalid file handler
4178 return values (Bug#10845).
4180 2012-02-18 Eli Zaretskii <eliz@gnu.org>
4182 * .gdbinit (pitx): Fix incorrect references to fields of the
4185 2012-02-17 Chong Yidong <cyd@gnu.org>
4187 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4189 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4191 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4192 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4194 2012-02-15 Chong Yidong <cyd@gnu.org>
4196 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4197 marked as special. Also, starting docstrings with * is obsolete.
4199 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4201 * gnutls.c (emacs_gnutls_write): Fix last change.
4203 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4205 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4208 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4210 * keymap.c (Fsingle_key_description): Handle char ranges.
4212 2012-02-12 Chong Yidong <cyd@gnu.org>
4214 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4215 as that creates a dangerous corner case.
4217 * window.c (Fdelete_window_internal): Invalidate the mouse
4218 highlight (Bug#9904).
4220 2012-02-12 Glenn Morris <rgm@gnu.org>
4222 * xselect.c (Fx_own_selection_internal)
4223 (Fx_get_selection_internal, Fx_disown_selection_internal)
4224 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4225 * nsselect.m (Fx_own_selection_internal)
4226 (Fx_disown_selection_internal, Fx_selection_exists_p)
4227 (Fx_selection_owner_p, Fx_get_selection_internal):
4228 Sync docs and argument specs with the xselect.c versions.
4230 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4232 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4234 2012-02-11 Eli Zaretskii <eliz@gnu.org>
4236 * w32select.c (Fx_selection_exists_p): Sync doc string and
4237 argument list with xselect.c. (Bug#10783)
4239 * w16select.c (Fx_selection_exists_p): Sync doc string and
4240 argument list with xselect.c. (Bug#10783)
4242 2012-02-10 Glenn Morris <rgm@gnu.org>
4244 * fns.c (Fsecure_hash): Doc fix.
4246 2012-02-09 Kenichi Handa <handa@m17n.org>
4248 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4250 2012-02-07 Chong Yidong <cyd@gnu.org>
4252 * buffer.c (Fbuffer_local_variables)
4253 (buffer_lisp_local_variables): Handle unbound vars correctly;
4254 don't let Qunbound leak into Lisp.
4256 2012-02-07 Glenn Morris <rgm@gnu.org>
4258 * image.c (Fimagemagick_types): Doc fix.
4260 * image.c (imagemagick-render-type): Change it from a lisp object
4261 to an integer. Move the doc here from the lisp manual.
4262 Treat all values not equal to 0 the same.
4264 2012-02-06 Chong Yidong <cyd@gnu.org>
4266 * doc.c (store_function_docstring): Avoid applying docstring of
4267 alias to base function (Bug#2603).
4269 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4271 * .gdbinit (pp1, pv1): Remove redundant defines.
4274 2012-02-04 Chong Yidong <cyd@gnu.org>
4276 * nsterm.m: Declare a global (Bug#10694).
4278 2012-02-04 Eli Zaretskii <eliz@gnu.org>
4280 * w32.c (get_emacs_configuration_options):
4281 Include --enable-checking, if specified, in the return value.
4283 2012-02-04 Martin Rudalics <rudalics@gmx.at>
4285 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4286 after rounding frame sizes. (Bug#9723)
4288 2012-02-04 Eli Zaretskii <eliz@gnu.org>
4290 * keyboard.c (adjust_point_for_property): Don't position point
4291 before BEGV. (Bug#10696)
4293 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4295 Handle overflow when computing char display width (Bug#9496).
4296 * character.c (char_width): Return EMACS_INT, not int.
4297 (char_width, c_string_width): Check for overflow when
4298 computing the width; this is possible now that individual
4299 characters can have unbounded width. Problem introduced
4300 by merge from Emacs 23 on 2012-01-19.
4302 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
4304 * dbusbind.c (Fdbus_register_method): Mention the return value
4305 :ignore in the docstring.
4307 2012-02-02 Glenn Morris <rgm@gnu.org>
4309 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4311 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4312 Unconditionally set to t. (Bug#10673)
4313 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4314 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4315 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4317 2012-02-02 Kenichi Handa <handa@m17n.org>
4319 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4320 0, do not call append_composite_glyph.
4322 2012-02-02 Kenichi Handa <handa@m17n.org>
4324 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4326 (x_produce_glyphs): If the component of a composition is a null
4327 string, set it->pixel_width to 1 to avoid zero-width glyph.
4329 2012-02-01 Eli Zaretskii <eliz@gnu.org>
4331 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4332 first 2 arguments are identical. This makes inserting large
4333 output from a subprocess an order of magnitude faster on
4334 MS-Windows, where all sbrk'ed memory is always contiguous.
4336 2012-01-31 Glenn Morris <rgm@gnu.org>
4338 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4339 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4340 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4342 2012-01-29 Glenn Morris <rgm@gnu.org>
4344 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4346 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4348 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4350 2012-01-28 Chong Yidong <cyd@gnu.org>
4352 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4354 2012-01-26 Chong Yidong <cyd@gnu.org>
4356 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4358 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4359 repeat counts (Bug#10507).
4361 2012-01-26 Glenn Morris <rgm@gnu.org>
4363 * lread.c (syms_of_lread): Doc fix.
4365 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4367 * coding.c (encode_designation_at_bol): Change return value to
4370 2012-01-25 Chong Yidong <cyd@gnu.org>
4372 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4374 2012-01-21 Chong Yidong <cyd@gnu.org>
4376 * floatfns.c (Fcopysign): Make the second argument non-optional,
4377 since nil is not allowed anyway.
4379 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4381 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4382 (send_process): Likewise.
4384 2012-01-19 Martin Rudalics <rudalics@gmx.at>
4386 * window.c (save_window_save, Fcurrent_window_configuration)
4387 (Vwindow_persistent_parameters): Do not use Qstate.
4388 Rewrite doc-strings.
4390 2012-01-19 Kenichi Handa <handa@m17n.org>
4392 * character.c (char_width): New function.
4393 (Fchar_width, c_string_width, lisp_string_width):
4394 Use char_width (Bug#9496).
4396 2012-01-16 Martin Rudalics <rudalics@gmx.at>
4398 * window.c (Vwindow_persistent_parameters): New variable.
4399 (Fset_window_configuration, save_window_save): Handle persistent
4402 2012-01-14 Eli Zaretskii <eliz@gnu.org>
4404 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4405 thrashing the stack of the thread. (Bug#9087)
4407 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4409 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4411 2012-01-11 Eli Zaretskii <eliz@gnu.org>
4413 * xdisp.c (rows_from_pos_range): Handle the case where the
4414 highlight ends on a newline. (Bug#10464)
4415 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4416 he end column for display of highlight that ends on a newline
4419 2012-01-11 Glenn Morris <rgm@gnu.org>
4421 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4422 from load-path also when installation-directory is nil. (Bug#10208)
4424 2012-01-10 Glenn Morris <rgm@gnu.org>
4426 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4428 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4429 Update template values to be closer to their typical values these days.
4431 2012-01-09 Eli Zaretskii <eliz@gnu.org>
4433 * xdisp.c (rows_from_pos_range): Accept additional argument
4434 DISP_STRING, and accept any glyph in a row whose object is that
4435 string as eligible for mouse highlight. Fixes mouse highlight of
4436 display strings from overlays. (Bug#10464)
4438 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
4440 emacs: fix an auto-save permissions race condition (Bug#10400)
4441 * fileio.c (auto_saving_dir_umask): New static var.
4442 (Fmake_directory_internal): Use it.
4443 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4444 creating the directory. The old code temporarily assigns
4445 too-generous permissions to the directory.
4446 (do_auto_save_eh): Clear it.
4447 (Fdo_auto_save): Catch all errors, not just file errors, so
4448 that the var is always cleared.
4450 2012-01-07 Eli Zaretskii <eliz@gnu.org>
4452 * search.c (scan_buffer): Pass character positions to
4453 know_region_cache, not byte positions. (Bug#6540)
4455 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
4457 * w32.c (sys_rename): Report EXDEV when rename of a directory
4458 fails because the target is on another logical disk. (Bug#10284)
4460 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4462 * xterm.c (x_embed_request_focus): New function.
4464 * xterm.h: Add prototype.
4466 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4468 2012-01-05 Glenn Morris <rgm@gnu.org>
4470 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4472 2012-01-01 Eli Zaretskii <eliz@gnu.org>
4474 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4475 Load gnutls_transport_set_lowat only if GnuTLS version is below
4477 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4478 GnuTLS versions below 2.11.1.
4480 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4482 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4483 to the doc string advising against its use for altering the way
4484 windows are scrolled.
4486 2011-12-28 Kenichi Handa <handa@m17n.org>
4488 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4489 coding-system ASCII compatible only when it does not produce BOM
4490 on encoding (Bug#10383).
4492 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4494 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4496 (create_and_show_popup_menu): Always use menu_position_func for
4499 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4501 * callint.c (Fcall_interactively): Don't truncate prompt string.
4503 2011-12-23 Eli Zaretskii <eliz@gnu.org>
4505 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4506 property that ends at ZV, so that the bidi iteration could be
4507 resumed from there (after widening). (Bug#10360)
4509 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4511 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4513 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4515 * nsterm.m (x_free_frame_resources):
4516 Release f->output_data.ns->miniimage.
4517 (ns_index_color): Fix indentation. Do not retain
4518 color_table->colors[i].
4520 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4523 * nsfns.m (x_set_background_color): Assign return value from
4524 ns_index_color to face-background instead of NSColor*.
4525 (ns_implicitly_set_icon_type): Fix indentation.
4526 Change assignment in for loop to comparison.
4528 * emacs.c (ns_pool): New variable.
4529 (main): Assign ns_pool.
4530 (Fkill_emacs): Call ns_release_autorelease_pool.
4532 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4533 autorelease fdesc, release fdAttrs and tdict.
4534 (ns_get_covering_families): Release charset.
4535 (ns_findfonts): Release NSFontDescriptor created with new.
4536 (ns_uni_to_glyphs): Fix indentation.
4537 (setString): Release attrStr before assigning new value.
4539 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4541 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4543 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4544 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4546 2011-12-18 David Reitter <reitter@cmu.edu>
4548 * nsterm.m (ns_term_init): Subscribe for notifications
4549 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4550 to method trackingNotification in EmacsMenu.
4552 * nsmenu.m (trackingMenu): New variable.
4553 (trackingNotification): New method (from Aquamacs).
4554 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
4555 from Aquamacs (Bug#7030).
4557 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4559 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4560 (symbol_to_nsstring): Fix indentation.
4561 (ns_symbol_to_pb): New function.
4562 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4563 (Fns_rotate_cut_buffers_internal): Remove.
4564 (Fns_store_selection_internal): Rename from
4565 Fns_store_cut_buffer_internal.
4566 (ns_get_foreign_selection, Fx_own_selection_internal)
4567 (Fx_disown_selection_internal, Fx_selection_exists_p)
4568 (Fns_get_selection_internal, Fns_store_selection_internal):
4569 Use ns_symbol_to_pb and check if return value is nil.
4570 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4571 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
4572 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4573 renamed to Sns_store_selection_internal.
4574 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4575 and remove this function.
4576 (ns_handle_selection_clear): Remove, never used.
4577 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4580 2011-12-17 Ken Brown <kbrown@cornell.edu>
4582 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4583 GID is unknown (Bug#10257).
4585 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4587 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4588 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4589 which caused a build failure on GNU/Linux IA-64. This problem was
4590 introduced by my 2011-10-07 patch.
4592 2011-12-15 Juri Linkov <juri@jurta.org>
4594 * image.c (imagemagick_error): New function. (Bug#10112)
4595 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4596 Use `imagemagick_error' where ImageMagick functions return
4598 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4601 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4603 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4604 fill background (Bug#8992).
4606 2011-12-13 Martin Rudalics <rudalics@gmx.at>
4608 * window.c (Vwindow_combination_resize)
4609 (Vwindow_combination_limit): Use t instead of non-nil in
4611 (Vrecenter_redisplay): Add first sentence of doc-string on
4613 (Frecenter): Fix doc-string typo.
4615 2011-12-11 Kenichi Handa <handa@m17n.org>
4617 * coding.c (Funencodable_char_position): Pay attention to the
4618 buffer text relocation (Bug#9389).
4620 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4622 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4623 gtk_init (Bug#10100).
4625 2011-12-10 Eli Zaretskii <eliz@gnu.org>
4627 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4628 IT->string is nil. (Bug#10263)
4630 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4632 * nsterm.h (x_free_frame_resources): Declare.
4634 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4635 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4637 * nsterm.h (ns_get_defaults_value): Declare.
4639 * nsterm.m (ns_default): Call ns_get_defaults_value.
4641 2011-12-09 Eli Zaretskii <eliz@gnu.org>
4643 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4646 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4648 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4649 that where the value of an _OBJC_* symbol points to is in the .bss
4650 section (Bug#10240).
4652 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4654 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
4655 after the loop to call ccl_driver at least once (Bug#8619).
4657 2011-12-08 Kenichi Handa <handa@m17n.org>
4659 * ftfont.c (get_adstyle_property): Fix previous change
4662 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
4664 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4665 dirs from the default value of EMACSLOADPATH (bug#10208).
4667 2011-12-07 Glenn Morris <rgm@gnu.org>
4669 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4670 installation and source directories as well. (Bug#10208)
4672 2011-12-06 Chong Yidong <cyd@gnu.org>
4674 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4676 2011-12-06 Glenn Morris <rgm@gnu.org>
4678 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4679 as an error, not just -1. (Bug#10217)
4681 2011-12-05 Chong Yidong <cyd@gnu.org>
4683 * keyboard.c (process_special_events): New function.
4684 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4686 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4688 * coding.c (encode_designation_at_bol): Don't use uninitialized
4689 local variable (Bug#9318).
4691 2011-12-05 Kenichi Handa <handa@m17n.org>
4693 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4694 return Qnil (Bug#8046, Bug#10193).
4696 2011-12-05 Kenichi Handa <handa@m17n.org>
4698 * coding.c (encode_designation_at_bol): New args charbuf_end and
4699 dst. Return the number of produced bytes. Callers changed.
4700 (coding_set_source): Return how many bytes coding->source was
4702 (coding_set_destination): Return how many bytes
4703 coding->destination was relocated.
4704 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
4705 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
4707 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4709 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4710 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4713 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4715 The following changes are to fix Bug#9318.
4717 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
4718 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4719 (encode_coding_iso_2022, encode_coding_sjis)
4720 (encode_coding_big5, encode_coding_charset): Use the above macros.
4722 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
4724 * lisp.h (process_quit_flag): Fix external declaration.
4726 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4728 Don't macro-inline non-performance-critical code.
4729 * eval.c (process_quit_flag): New function.
4730 * lisp.h (QUIT): Use it.
4732 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4734 * nsfns.m (get_geometry_from_preferences): New function.
4735 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4737 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4739 * emacs.c (Qkill_emacs): Define.
4740 (syms_of_emacs): Initialize it.
4741 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4742 Qquit_flag to `kill-emacs' instead.
4743 (quit_throw_to_read_char): Add parameter `from_signal'.
4744 All callers changed. Call Fkill_emacs if requested and safe.
4745 * lisp.h (QUIT): Call Fkill_emacs if requested.
4747 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4749 * widget.c (update_wm_hints): Return if wmshell is null.
4750 (widget_update_wm_size_hints): New function.
4752 * widget.h (widget_update_wm_size_hints): Declare.
4754 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4755 widget_update_wm_size_hints (Bug#10104).
4757 2011-12-03 Eli Zaretskii <eliz@gnu.org>
4759 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4760 before a newline, prepare the bidi iterator for consuming the
4761 newline, and keep the current paragraph direction. (Bug#10183)
4762 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
4764 2011-12-02 Juri Linkov <juri@jurta.org>
4766 * search.c (Fword_search_regexp): New Lisp function created from
4767 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4768 (Fword_search_backward, Fword_search_forward)
4769 (Fword_search_backward_lax, Fword_search_forward_lax):
4770 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4771 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4773 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4775 * fileio.c (Finsert_file_contents): Move after-change-function call
4776 to before the "handled:" label, since all "goto handled" appear in
4777 cases where the *-change-functions have already been properly called
4780 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4782 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4783 waiting for input. (Bug#10169)
4785 2011-11-30 Eli Zaretskii <eliz@gnu.org>
4787 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4788 verifies glyph row's hash code--we have just reallocated the
4789 glyphs, so their contents can be complete garbage. (Bug#10164)
4791 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
4793 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4795 2011-11-30 Eli Zaretskii <eliz@gnu.org>
4797 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4798 attributes are tested _before_ calling verify_row_hash, to protect
4799 against GCC re-ordering of the tests. (Bug#10164)
4801 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4803 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4805 * xterm.c (handle_one_xevent): Only set async_visible and friends
4806 if net_wm_state_hidden_seen is non-zero (Bug#10002)
4807 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
4808 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4810 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4812 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4813 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4814 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4815 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4816 All uses changed to use GCPRO1 etc.
4817 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4818 Revert to old implementation (i.e., before 2011-03-11).
4820 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4822 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4823 of scroll runs so as to avoid assigning disabled bogus rows and
4824 unnecessary graphics copy operations.
4826 2011-11-27 Eli Zaretskii <eliz@gnu.org>
4828 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4829 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4830 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4831 (malloc, free, realloc, calloc): Redirect to e_* only when
4834 * lisp.h (GCTYPEBITS): Move before first use.
4835 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4836 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4837 this macro definition.
4839 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4842 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4844 * gtkutil.c (xg_create_frame_widgets):
4845 Call gtk_window_set_has_resize_grip (FALSE) if that function is
4846 present with Gtk+ 2.0.
4848 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4850 * fileio.c (Finsert_file_contents): Undo previous change; see
4851 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4853 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4855 Rename locals to avoid shadowing.
4856 * fileio.c (Finsert_file_contents):
4857 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4858 * process.c (wait_reading_process_output):
4859 Rename inner 'proc' to 'p' to avoid shadowing.
4860 Indent for consistency with usual Emacs style.
4862 2011-11-25 Eli Zaretskii <eliz@gnu.org>
4864 * xdisp.c (redisplay_window): If cursor row is not fully visible
4865 after recentering, and scroll-conservatively is set to a large
4866 number, scroll window by a few more lines to make the cursor fully
4867 visible and out of scroll-margin. (Bug#10105)
4868 (start_display): Don't move to the next line if the display should
4869 start at a newline that is part of a display vector or an overlay
4872 2011-11-24 Juri Linkov <juri@jurta.org>
4874 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4875 after the `MagickPingImage' call. (Bug#10112)
4877 2011-11-23 Chong Yidong <cyd@gnu.org>
4879 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4881 2011-11-23 Martin Rudalics <rudalics@gmx.at>
4883 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4884 making another buffer current. (Bug#10114)
4886 2011-11-23 Glenn Morris <rgm@gnu.org>
4888 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4890 2011-11-23 Chong Yidong <cyd@gnu.org>
4892 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4893 using it (Bug#5984).
4895 2011-11-22 Eli Zaretskii <eliz@gnu.org>
4897 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4898 and header-lines, as they don't have one computed for them.
4901 * .gdbinit (prow): Make displayed values more self-explaining.
4902 Add row's hash code.
4904 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4906 * process.c (wait_reading_process_output): Fix asynchrounous
4907 GnuTLS socket handling on some versions of the GnuTLS library.
4908 (wait_reading_process_output): Add comment and URL.
4910 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4912 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4914 2011-11-21 Chong Yidong <cyd@gnu.org>
4916 * window.c (Fnext_window, Fprevious_window): Doc fix.
4918 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4920 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4922 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
4924 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4926 2011-11-20 Martin Rudalics <rudalics@gmx.at>
4928 * window.c (Fset_window_combination_limit): Rename argument
4930 (Vwindow_combination_limit): Remove "status" from doc-string.
4932 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4934 * m/ibms390.h: Remove.
4935 * m/ibms390x.h: Don't include "ibms390.h".
4937 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4939 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4940 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4942 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
4944 * casetab.c (Fset_case_table):
4945 * charset.c (Fcharset_after): Fix typos.
4947 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
4949 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4950 Otherwise, valgrind does not work on some platforms.
4951 Problem reported by Andreas Schwab in
4952 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4953 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4954 is set, removing the need for VIRT_ADDRESS_VARIES.
4955 (PURE_P): Use a more-efficient implementation that needs just one
4956 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4957 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4958 to 4 (xorl, subq, cmpq, setbe).
4959 * alloc.c (pure): Always extern now, since that's the
4960 VIRT_ADDR_VARIES behavior.
4961 (PURE_POINTER_P): Use a single comparison, not two, for
4962 consistency with the new puresize.h.
4963 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4964 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4965 Remove VIRT_ADDR_VARIES no longer needed.
4967 2011-11-19 Eli Zaretskii <eliz@gnu.org>
4969 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4970 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4971 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4972 behave as if the cursor position were at the window margin.
4974 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4975 and the cursor position is out of bounds, behave as if the cursor
4976 position were at the window margin. (Bug#10075)
4978 2011-11-18 Chong Yidong <cyd@gnu.org>
4980 * window.c (Fwindow_combination_limit): Make first argument
4981 non-optional, since it is meaningless for live windows like the
4984 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4986 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4988 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4990 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4991 (graft_intervals_into_buffer): Simplify.
4993 2011-11-18 Eli Zaretskii <eliz@gnu.org>
4995 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4996 hash values of the two rows.
4997 (copy_row_except_pointers): Preserve the used[] arrays and the
4998 hash values of the two rows. (Bug#10035)
4999 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
5001 * xdisp.c (row_hash): New function, body extracted from
5002 compute_line_metrics.
5003 (compute_line_metrics): Call row_hash, instead of computing the
5006 * dispnew.c (verify_row_hash): Call row_hash for computing the
5007 hash code of a row, instead of duplicating code from xdisp.c.
5009 * dispextern.h (row_hash): Add prototype.
5011 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5013 * frame.c (delete_frame): Don't delete the terminal when the last
5014 X frame is closed if emacs is built with GTK toolkit.
5016 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
5018 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5020 2011-11-17 Martin Rudalics <rudalics@gmx.at>
5022 * window.c (Vwindow_splits): Rename to
5023 Vwindow_combination_resize. Suggested by Juri Linkov.
5024 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5027 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
5029 * nsfns.m (Fns_font_name):
5030 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
5032 2011-11-16 Martin Rudalics <rudalics@gmx.at>
5034 * window.h (window): Rename slot "nest" to "combination_limit".
5035 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5036 (Fset_window_nest): Rename to Fset_window_combination_limit.
5037 (Vwindow_nest): Rename to Vwindow_combination_limit.
5038 (recombine_windows, make_parent_window, make_window)
5039 (Fsplit_window_internal, saved_window)
5040 (Fset_window_configuration, save_window_save): Rename all
5041 occurrences of window_nest to window_combination_limit.
5043 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
5045 * image.c (imagemagick_load_image): Fix typo.
5047 2011-11-14 Eli Zaretskii <eliz@gnu.org>
5049 * xdisp.c (display_line): Move the call to
5050 highlight_trailing_whitespace before the call to
5051 compute_line_metrics, since the latter needs to see the final
5052 faces of all the glyphs to compute ROW's hash value.
5053 Fixes assertion violations in row_equal_p. (Bug#10035)
5055 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
5057 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5058 just return (bug#10044).
5060 2011-11-12 Eli Zaretskii <eliz@gnu.org>
5062 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5063 with user-defined heap size. Bump the default size of the temacs
5064 heap to 27MB, to avoid memory warning when running temacs.
5065 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5067 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5068 current_matrix and desired_matrix. (Bug#9990)
5069 (verify_row_hash) [XASSERTS]: New function.
5070 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5071 that the hash value of glyph rows is correct.
5073 2011-11-12 Martin Rudalics <rudalics@gmx.at>
5075 * window.h (window): Remove splits slot.
5076 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5077 (Fdelete_other_windows_internal, make_parent_window)
5078 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5079 (Fset_window_configuration, save_window_save): Don't deal with
5080 split status of windows.
5081 (saved_window): Remove splits slot.
5082 (Vwindow_splits): Rewrite doc-string.
5084 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5086 * xfns.c (unwind_create_frame):
5087 * nsfns.m (unwind_create_frame):
5088 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5089 Vframe_list (Bug#9999).
5091 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5093 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
5095 2011-11-11 Kenichi Handa <handa@m17n.org>
5097 * callproc.c (Fcall_process): Set the member dst_multibyte of
5100 2011-11-11 Johan Bockgård <bojohan@gnu.org>
5102 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5103 avoid a crash (bug#9496).
5105 2011-11-09 Chong Yidong <cyd@gnu.org>
5107 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5108 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5110 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5112 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5114 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5116 Avoid some portability problems by eschewing 'extern inline' functions.
5117 The trivial performance wins aren't worth the portability hassles; see
5118 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5120 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5121 (window_box_width, window_box_left, window_box_left_offset)
5122 (window_box_right, window_box_right_offset): Undo previous change,
5123 by removing the "extern"s.
5124 * intervals.c (adjust_intervals_for_insertion)
5125 (adjust_intervals_for_deletion): Undo previous change,
5126 making these static again.
5127 (offset_intervals, temp_set_point_both, temp_set_point)
5128 (copy_intervals_to_string): No longer inline.
5129 * xdisp.c (window_text_bottom_y, window_box_width)
5130 (window_box_height, window_box_left_offset)
5131 (window_box_right_offset, window_box_left, window_box_right)
5132 (window_box): No longer inline.
5134 2011-11-08 Chong Yidong <cyd@gnu.org>
5136 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
5137 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5138 Signal an error if not a live window.
5139 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5140 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5142 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
5144 * lisp.h (syms_of_abbrev): Remove declaration.
5145 Reported by CHENG Gao <chenggao@royau.me>.
5147 2011-11-07 Eli Zaretskii <eliz@gnu.org>
5149 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5150 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5151 of temacs in GUI mode.
5153 2011-11-07 Martin Rudalics <rudalics@gmx.at>
5155 * window.h: Declare delete_all_child_windows instead of
5156 delete_all_subwindows.
5157 * window.c (Fwindow_nest, Fset_window_nest)
5158 (Fset_window_new_total, Fset_window_new_normal)
5159 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5160 (delete_all_subwindows): Rename to delete_all_child_windows.
5161 (Fdelete_other_windows_internal, Fset_window_configuration):
5162 Call delete_all_child_windows instead of delete_all_subwindows.
5163 * frame.c (delete_frame): Call delete_all_child_windows instead
5164 of delete_all_subwindows.
5166 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5168 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5169 This is also needed for porting to any host where GC_MARK_STACK is
5170 not GC_MAKE_GCPROS_NOOPS.
5171 (which_symbols): Use it.
5173 2011-11-07 Kenichi Handa <handa@m17n.org>
5175 * coding.c (coding_set_destination): Check coding->src_pos only
5176 when coding->src_object is a buffer (bug#9910).
5178 * process.c (send_process): Set the member src_multibyte of coding
5179 to 0 (bug#9911) when sending a unibyte text.
5181 * callproc.c (Fcall_process): Set the member src_multibyte of
5182 process_coding to 0 (bug#9912).
5184 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5186 * xmenu.c (cleanup_widget_value_tree): New function.
5187 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5188 calling free_menubar_widget_value_tree directly (Bug#9830).
5190 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5192 Fix some portability problems with 'inline'.
5193 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5194 (window_box_width, window_box_left, window_box_left_offset)
5195 (window_box_right, window_box_right_offset): Declare extern.
5196 Otherwise, these inline functions do not conform to C99 and
5197 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5198 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5199 * intervals.c (adjust_intervals_for_insertion)
5200 (adjust_intervals_for_deletion): Now extern, because otherwise the
5201 extern inline functions 'offset_intervals' couldn't refer to it.
5202 (static_offset_intervals): Remove.
5203 (offset_intervals): Rewrite using the old contents of
5204 static_offset_intervals. The old version didn't conform to C99
5205 because an extern inline function contained a reference to an
5206 identifier with static linkage.
5208 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5210 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5213 2011-11-06 Eli Zaretskii <eliz@gnu.org>
5215 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5216 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5217 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5218 return Qleft_to_right.
5220 2011-11-06 Chong Yidong <cyd@gnu.org>
5222 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5223 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5224 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5225 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5226 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5227 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5228 (Fwindow_vscroll): Doc fix.
5229 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5230 argument, since it makes no sense to pass a live window and for
5231 consistency with window-child.
5233 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5235 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5238 2011-11-05 Jason Rumney <jasonr@gnu.org>
5240 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5241 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5243 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5244 bitwise arithmetic preventing use of unicode-sip and non-truetype
5247 2011-11-05 Eli Zaretskii <eliz@gnu.org>
5249 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5252 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5253 initialization code to keep similarity to xfns.c after changes
5256 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5258 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5259 (unwind_create_frame): New function (Bug#9943).
5260 (Fx_create_frame): Restructure code to be more similar to the one in
5261 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5262 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5263 Move terminal->reference_count++ just before making the frame official
5266 * nsterm.m (x_free_frame_resources): New function.
5267 (x_destroy_window): Move code to x_free_frame_resources.
5269 * xfns.c (unwind_create_frame): Fix comment.
5270 (Fx_create_frame, x_create_tip_frame):
5271 Move terminal->reference_count++ just before making the frame
5272 official. Move initialization of image_cache_refcount and
5273 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5275 2011-11-05 Eli Zaretskii <eliz@gnu.org>
5277 Support MSVC build with newer versions of Visual Studio.
5278 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5279 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5282 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5283 which are not supported by MSVC.
5284 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5285 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5287 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5289 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5291 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5293 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
5295 Support MSVC build with newer versions of Visual Studio.
5296 * w32.c: Don't include w32api.h for MSVC.
5297 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5299 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5300 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5301 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5302 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5304 (alloca) [_MSC_VER]: Define to _alloca.
5306 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5308 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5310 2011-11-04 Eli Zaretskii <eliz@gnu.org>
5312 * xdisp.c (note_mouse_highlight): If either of
5313 previous/next-single-property-change returns nil, treat that as
5314 the beginning or the end of the buffer. (Bug#9955)
5316 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5318 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
5319 label is not null (Bug#9951).
5320 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5323 2011-11-04 Eli Zaretskii <eliz@gnu.org>
5325 * window.c (Fwindow_body_size): Mention in the doc string that the
5326 return value is in frame's canonical units. (Bug#9949)
5328 2011-11-03 Eli Zaretskii <eliz@gnu.org>
5330 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5332 * w32fns.c (unwind_create_frame): If needed, free the glyph
5333 matrices of the partially constructed frame. (Bug#9943)
5334 * xfns.c (unwind_create_frame): Likewise.
5336 2011-11-01 Eli Zaretskii <eliz@gnu.org>
5338 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5339 Don't stop backward scan on the continuation glyph, even though
5340 its CHARPOS is positive.
5341 (mouse_face_from_buffer_pos, note_mouse_highlight):
5342 Rename cover_string to disp_string.
5344 2011-11-01 Martin Rudalics <rudalics@gmx.at>
5346 * window.c (temp_output_buffer_show): Don't use
5347 Vtemp_buffer_show_specifiers.
5348 (Vtemp_buffer_show_specifiers): Remove unused variable.
5350 2011-10-30 Eli Zaretskii <eliz@gnu.org>
5352 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5353 past the beginning of the current glyph matrix.
5355 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
5357 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5358 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5359 HAVE_GTK3 (Bug#9869).
5361 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5362 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5364 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5366 * xterm.c: Declare x_handle_net_wm_state to return int.
5367 (handle_one_xevent): Check if we are iconified but don't have
5368 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5369 (get_current_wm_state): Return non-zero if not hidden,
5370 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5371 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5372 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5373 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5375 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5377 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5378 so that this new function doesn't get optimized away by a
5379 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5381 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5383 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5385 2011-10-29 Eli Zaretskii <eliz@gnu.org>
5387 Fix the `xbytecode' command.
5388 * .gdbinit (xprintbytestr): New command.
5389 (xwhichsymbols): Rename from `which'; all callers changed.
5390 (xbytecode): Print the byte-code string as well.
5392 2011-10-29 Kim Storm <storm@cua.dk>
5394 * alloc.c (which_symbols): New function.
5396 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5398 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5401 2011-10-29 Glenn Morris <rgm@gnu.org>
5403 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5404 Not clear what it was for, and it causes various bugs. (Bug#9839)
5406 2011-10-28 Eli Zaretskii <eliz@gnu.org>
5408 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5409 possible random value that matches one of those tested as
5410 condition to clear the mouse face.
5412 2011-10-28 Chong Yidong <cyd@gnu.org>
5414 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5416 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5418 * window.c (make_window): Initialize phys_cursor_on_p.
5420 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5422 * lisp.h (struct Lisp_Symbol): Update comments.
5424 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
5426 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5428 2011-10-28 Eli Zaretskii <eliz@gnu.org>
5430 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5431 <oslsachem@gmail.com> for helping to debug this.
5433 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5434 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5435 (g_b_init_get_glyph_outline_w): New static variables.
5436 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5437 (GetGlyphOutlineW_Proc): New typedefs.
5438 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
5439 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5441 (w32font_open_internal, compute_metrics):
5442 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
5443 instead of calling the "wide" APIs directly.
5445 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5447 * w32.h (syms_of_w32font): Add prototype.
5449 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
5451 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5452 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5453 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5454 (Fmove_to_window_line): Doc fix.
5456 2011-10-27 Chong Yidong <cyd@gnu.org>
5458 * process.c (make_process): Set gnutls_state to NULL.
5460 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5461 non-NULL, regardless of GNUTLS_INITSTAGE.
5462 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5463 an error. Set process slots as soon as we allocate them.
5465 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5467 2011-10-27 Chong Yidong <cyd@gnu.org>
5469 * gnutls.c (emacs_gnutls_deinit): New function.
5470 Deallocate credentials structures as well as calling gnutls_deinit.
5471 (Fgnutls_deinit, Fgnutls_boot): Use it.
5473 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5474 (deactivate_process): Call emacs_gnutls_deinit.
5476 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
5478 * image.c (x_create_x_image_and_pixmap):
5479 * w32.c (sys_rename, w32_delayed_load):
5480 * w32font.c (fill_in_logfont):
5481 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5483 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
5485 * w32fns.c (w32_default_color_map): New function,
5486 extracted from Fw32_default_color_map.
5487 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5489 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5491 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5493 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5495 * keyboard.c (test_undefined): New function (bug#9751).
5496 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5498 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5500 * sysdep.c (init_sys_modes): Fix the check for the controlling
5501 terminal (Bug#6649).
5503 2011-10-20 Eli Zaretskii <eliz@gnu.org>
5505 * dispextern.h (struct bidi_it): New member next_en_type.
5507 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5508 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5509 current character, check also for next_en_type being WEAK_EN.
5510 (bidi_resolve_weak): Don't enter the expensive loop if the current
5511 position is before next_en_pos. Record the bidi type of the first
5512 non-ET, non-BN character we find, in addition to its position.
5513 (bidi_level_of_next_char): Invalidate next_en_type when
5514 next_en_pos is over-stepped.
5516 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5518 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5519 * editfns.c: Rewrite current-time-zone so that it invokes
5520 the equivalent of (format-time-string "%Z") to get the time zone name.
5521 This fixes a bug when the time zone name contains characters that
5522 need converting from the system time locale to Emacs internal format.
5523 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5524 that patch fixed format-time-string to do the conversion, but
5525 I forgot to fix current-time-zone.
5526 (format_time_string): New function, containing most of
5527 what Fformat_time_string used to contain.
5528 (Fformat_time_string): Rewrite in terms of format_time_string.
5529 This doesn't change this function's behavior.
5530 (current-time-zone): Rewrite to use format_time_string.
5531 This fixes the bug reported by Michael Schierl in
5532 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5533 Jason Rumney's 2007-06-07 change worked around this bug, but
5535 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5537 2011-10-19 Eli Zaretskii <eliz@gnu.org>
5539 * xdisp.c (start_display): If the character at POS is displayed
5540 via a display vector, reset IT->current.dpvec_index to zero.
5541 (try_window_reusing_current_matrix): If a line ends in a display
5542 vector or the next line starts in a display vector, continue
5543 redrawing the window even though the character position of
5544 start_row was reached.
5547 2011-10-18 Chong Yidong <cyd@gnu.org>
5549 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5550 with nobreak-char-display too.
5552 2011-10-18 Eli Zaretskii <eliz@gnu.org>
5554 Fix part 3 of bug#9771.
5555 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5556 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5557 non-neutral characters if the current character is a paragraph
5558 separator (a.k.a. Newline). This avoids running the same
5559 expensive loop twice, once when we consume the preceding newline
5560 and the other time when the line actually needs to be displayed.
5561 Avoid the loop when we see neutrals on the base embedding level
5562 following a character whose directionality is the same as the
5563 paragraph's. This avoids running the expensive loop when a line
5564 ends in a long sequence of neutrals, like control characters.
5565 Add assertion against STRONG_AL type. Slightly rearrange code
5566 that determines the type of a neutral given the first non-neutral
5568 (bidi_level_of_next_char): Set next_en_pos to zero when
5569 invalidating its info.
5571 2011-10-17 Eli Zaretskii <eliz@gnu.org>
5573 * xdisp.c (push_display_prop): Determine whether to record string
5574 or buffer position by IT->string, not by IT->method. Allow
5575 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
5576 (move_it_vertically_backward): Don't look for character position
5577 immediately after the newline when in a continuation line.
5580 2011-10-15 Martin Rudalics <rudalics@gmx.at>
5582 * window.c (coordinates_in_window): Rewrite and delabelize
5583 vertical border check. (Bug#5357) (Bug#9618)
5585 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5587 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5588 errors in XSetWindowBorder (bug#9310).
5590 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5592 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5593 avoid crash when xmalloc overrun checking is enabled.
5595 2011-10-13 Eli Zaretskii <eliz@gnu.org>
5597 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5598 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5599 cursor motion with <left> and <right> arrow keys.
5601 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5602 some callers set that themselves.
5604 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5606 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5607 display string and the previous row comes from the same string and
5608 is empty. (Bug#9739) (Bug#9738)
5610 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5612 * doc.c (get_doc_string): Encode file name (bug#9735).
5614 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5616 * bidi.c (bidi_level_of_next_char):
5617 * xdisp.c (get_visually_first_element): Remove old incorrect
5618 comments regarding the Unicode Line Separator character.
5620 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5622 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5624 * alloc.c (Fgc_status): Do not access beyond zombies array
5625 boundary if nzombies > MAX_ZOMBIES.
5626 * alloc.c (dump_zombies): Add missing format specifier.
5628 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5630 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5631 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5633 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5634 Some packages use them to denote characters with modifiers.
5636 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5638 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5639 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5640 matching a pp-number. Rename parameter var to var1.
5642 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5644 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5646 2011-10-08 Glenn Morris <rgm@gnu.org>
5648 * callint.c (Fcall_interactively): Give a more explicit error for the
5649 'c' case with a non-character input. (Bug#8479)
5651 2011-10-08 Eli Zaretskii <eliz@gnu.org>
5653 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5655 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5656 lines that are hscrolled on the left.
5658 * dispnew.c (buffer_posn_from_coords): Account for a possible
5659 presence of header-line. (Bug#4426)
5661 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5663 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5664 Don't advertise functionality which we discourage or doesn't work.
5666 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5668 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5669 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5670 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5671 this makes Emacs dump core during garbage collection on rare
5672 occasions. sizeof is obviously inferior to offsetof here, so
5673 stick with offsetof.
5674 (GC_POINTER_ALIGNMENT): New macro.
5675 (mark_memory): Omit 3rd (offset) arg; caller changed.
5676 Don't assume EMACS_INT alignment is the same as pointer alignment.
5678 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5680 * keyboard.c (read_key_sequence_remapped): New var.
5681 (read_key_sequence): Compute remapping in the right buffer.
5682 (command_loop_1): Use read_key_sequence's remapping directly.
5684 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5686 * dired.c (file_name_completion): Don't expand file name.
5687 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5688 before checking file name handler.
5690 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5691 they've been requested explicitly (bug#9591).
5693 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
5695 * keymap.c (Fsingle_key_description): Use make_specified_string
5696 instead of build_string to build string from push_key_description.
5699 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5701 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5702 This fixes a Y2038 bug on 64-bit hosts.
5703 * buffer.c (reset_buffer):
5704 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5705 (Fclear_buffer_auto_save_failure):
5706 Use 0, not -1, to represent an unset failure time, since time_t
5707 might not be signed.
5709 Remove dependency on glibc malloc internals.
5710 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5711 Move back here from lisp.h, but with their new implementations.
5712 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5713 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5714 * charset.c (charset_table_init): New static var.
5715 (syms_of_charset): Use it instead of xmalloc. This removes a
5716 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5717 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5718 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5719 Move back to alloc.c.
5720 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5721 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5723 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5725 * nsterm.m (windowDidResize): Call x_set_window_size only when
5726 ns_in_resize is true. Otherwise set pixelwidth/height and
5727 call change_frame_size (Bug#9628).
5729 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5731 Port --enable-checking=all to Fedora 14 x86-64.
5732 * charset.c (syms_of_charset): Also account for glibc malloc's
5733 internal overhead when calculating the initial malloc maximum.
5735 Port --enable-checking=all to Fedora 14 x86.
5736 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5738 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5739 (overrun_check_realloc, overrun_check_free):
5740 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5741 That way, xmalloc returns a properly-aligned pointer even if
5742 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5743 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5744 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5745 into account when calculating the initial malloc maximum.
5746 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5747 Move here from alloc.c, so that charset.c can use it too.
5748 Properly align; the old code wasn't right for common 32-bit hosts
5749 when configured with --enable-checking=all.
5750 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5751 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5753 2011-09-29 Eli Zaretskii <eliz@gnu.org>
5755 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
5758 2011-09-28 Eli Zaretskii <eliz@gnu.org>
5760 * xdisp.c (compute_display_string_end): If there's no display
5761 string at CHARPOS, return -1.
5763 * bidi.c (bidi_fetch_char): When compute_display_string_end
5764 returns a negative value, treat the character as a normal
5765 character not covered by a display string. (Bug#9624)
5767 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
5769 * lread.c (Fread_from_string): Fix typo in docstring.
5771 2011-09-27 Eli Zaretskii <eliz@gnu.org>
5773 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5774 newline, reseat the iterator instead of bidi-iterating there one
5775 character at a time. (Bug#9610)
5776 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5777 TO_CHARPOS if the bidi iterator is at base embedding level.
5779 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5781 * lread.c (readevalloop): Use correct code for NBSP.
5782 (read1): Likewise. (Bug#9608)
5784 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
5786 * dbusbind.c (Fdbus_register_signal): When service is not
5787 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5789 2011-09-25 Glenn Morris <rgm@gnu.org>
5791 * buffer.c (truncate-lines): Doc fix.
5793 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
5795 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5796 (Fset_window_next_buffers): Doc fix.
5798 2011-09-24 Glenn Morris <rgm@gnu.org>
5800 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5802 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5804 Fix minor problems found by static checking.
5805 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
5806 * indent.c (Fvertical_motion): Fix == vs = typo.
5808 2011-09-24 Eli Zaretskii <eliz@gnu.org>
5810 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5811 Default value is now t. Doc fix.
5813 * indent.c (Fvertical_motion): Compute and apply the overshoot
5814 logic when moving up, not only when moving down. Fix the
5815 confusing name and values of the it_overshoot_expected variable;
5816 logic changes accordingly. (Bug#9254) (Bug#9549)
5818 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5819 CHARPOS is covered by a display string which includes newlines.
5820 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5821 is covered by a display string with embedded newlines.
5823 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
5825 * dbusbind.c (Fdbus_register_signal): Add match rule to
5826 Vdbus_registered_objects_table. (Bug#9581)
5827 (Fdbus_register_method, Vdbus_registered_objects_table):
5830 2011-09-24 Jim Meyering <meyering@redhat.com>
5832 do not ignore write error for any output size
5833 The previous change was incomplete.
5834 While it makes emacs --batch detect the vast majority of stdout
5835 write failures, errors were still ignored whenever the output size is
5836 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5837 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5838 && echo FAIL: ignored write error
5839 FAIL: ignored write error
5840 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5841 && echo FAIL: ignored write error
5842 FAIL: ignored write error
5843 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5845 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5847 * emacs.c (Fkill_emacs): In noninteractive mode exit
5848 non-successfully if a write error occurred on stdout. (Bug#9574)
5850 2011-09-21 Eli Zaretskii <eliz@gnu.org>
5852 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5855 * dispextern.h (struct it): Update the comment documenting what
5858 2011-09-20 Eli Zaretskii <eliz@gnu.org>
5860 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5861 a display string, extend search for cursor position to end of row.
5862 (find_row_edges): If the row ends in a newline from a display
5863 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5864 Handle the case of a display string with multiple newlines.
5865 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5866 non-empty line. Fixes confusing cursor motion with arrow keys at
5867 the beginning of a line that starts with whitespace.
5869 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5871 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5874 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
5876 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5879 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5881 * xdisp.c (display_line): Record maximum and minimum buffer
5882 positions even if no glyphs were produced (e.g., by a zero-width
5883 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5884 buffer positions that will be removed from the glyph row because
5886 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5887 column is beyond frame width: don't subtract 1 "pixel" when
5888 computing width of the stretch.
5889 (reseat_at_next_visible_line_start): Undo the change made on
5890 2011-09-17 that saved paragraph information and restored it after
5891 the call to `reseat'. (Bug#9545)
5893 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5895 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5896 and turn window cursor on if cleared (Bug#9415).
5898 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
5900 * search.c (boyer_moore): Take unibyte characters from pattern
5901 literally. (Bug#9458)
5903 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5905 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5907 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5909 Fix minor problem found by static checking.
5910 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5911 initialized, to pacify gcc -Wuninitialized.
5913 * fileio.c: Report proper errno when syscall falls.
5914 (Finsert_file_contents): Save and restore errno,
5915 so that report_file_error outputs the correct diagnostic.
5916 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5918 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5920 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5922 2011-09-17 Eli Zaretskii <eliz@gnu.org>
5924 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5925 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5927 2011-09-17 Eli Zaretskii <eliz@gnu.org>
5929 * xdisp.c (reseat_at_next_visible_line_start): Keep information
5930 about the current paragraph and restore it after the call to reseat.
5932 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5933 (bidi_find_paragraph_start): Search back for paragraph beginning
5934 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5935 (bidi_move_to_visually_next): Only trigger paragraph-related
5936 computations when the last character is a newline or at EOB, not
5937 just any NEUTRAL_B. (Bug#9470)
5939 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5940 truncated lines if point is covered by a display string. (Bug#9524)
5942 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5944 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5945 (cons_to_x_long): New function.
5946 (lisp_data_to_selection_data): Use it. Correct the test for
5947 short-versus-long data; it was negated. Break out of vector
5948 loop, for efficiency, when a long datum is discovered.
5950 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5952 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5954 2011-09-16 Eli Zaretskii <eliz@gnu.org>
5956 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5957 GCC PR/17406) by declaring this function with external scope.
5959 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5961 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5962 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5964 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5966 * editfns.c (Fformat): Correctly handle text properties on "%%".
5968 2011-09-15 Eli Zaretskii <eliz@gnu.org>
5970 * xterm.c (x_draw_composite_glyph_string_foreground):
5971 * w32term.c (x_draw_composite_glyph_string_foreground):
5972 * term.c (encode_terminal_code):
5973 * composite.c (composition_update_it, get_composition_id):
5974 * xdisp.c (get_next_display_element)
5975 (fill_composite_glyph_string): Add comments about special meaning
5976 of TAB characters in a composition.
5978 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5980 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
5981 This occurs when processing a multibyte format.
5982 Problem reported by Wolfgang Jenker.
5984 2011-09-15 Johan Bockgård <bojohan@gnu.org>
5986 * xdisp.c (try_cursor_movement): Only check for exact match if
5987 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5989 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5991 Remove unused external symbols.
5992 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5993 * xdisp.c (calc_pixel_width_or_height): Now static.
5994 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5995 * indent.c (check_display_width):
5996 * w32term.c: Fix comment to match code.
5997 * xterm.c, xterm.h (x_catching_errors): Remove.
5999 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6001 * xselect.c: Use signed conversions more consistently (Bug#9498).
6002 (selection_data_to_lisp_data): Assume incoming selection data are
6003 signed integers, not unsigned. This is to be consistent with
6004 outgoing selection data, which was modified to use signed integers
6005 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6006 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6007 expects long, not unsigned long.
6009 2011-09-14 Eli Zaretskii <eliz@gnu.org>
6011 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6012 computation of loop end. Reported by Johan Bockgård
6015 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
6017 * frame.c (Fother_visible_frames_p): Function deleted.
6019 2011-09-12 Eli Zaretskii <eliz@gnu.org>
6021 * indent.c (compute_motion): Process display vector front to back
6022 rather than the other way around. (Bug#2496)
6024 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6026 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6028 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
6030 * minibuf.c (Fread_from_minibuffer): Doc fix.
6032 2011-09-11 Eli Zaretskii <eliz@gnu.org>
6034 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6035 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6037 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6039 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6040 value for non-existent files.
6042 2011-09-11 Eli Zaretskii <eliz@gnu.org>
6044 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6045 set its "size" to -1. This will set the modtime_size field of
6046 the corresponding buffer to -1, which is what
6047 verify-visited-file-modtime expects for files that do not exist.
6050 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6052 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6054 * lisp.h: ... from here. push_key_description is no longer
6055 defined in keyboard.c, so its declaration should not be in
6056 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6057 logically belongs with push_key_description.
6059 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6061 * buffer.h: Include <sys/types.h> instead of <time.h>.
6062 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6063 Problem reported by Herbert J. Skuhra.
6065 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6067 * xml.c (parse_region): Make the parsing work for
6068 non-comment-starting XML files again (bug#9144).
6070 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6072 * image.c (gif_load): Fix calculation of bottom and right corner.
6075 2011-09-10 Eli Zaretskii <eliz@gnu.org>
6077 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6078 redisplay in small windows.
6080 2011-09-09 Eli Zaretskii <eliz@gnu.org>
6082 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6084 2011-09-08 Martin Rudalics <rudalics@gmx.at>
6086 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6087 Operate on live windows only.
6089 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
6091 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6093 2011-09-07 Eli Zaretskii <eliz@gnu.org>
6095 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6096 only under bidi iteration.
6098 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6100 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6102 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6104 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6105 Without this fix, the command to link temacs failed due to an
6106 undefined symbol __builtin_isnan. This is because
6107 /usr/include/iso/math_c99.h #defines isnan(x) to
6108 __builtin_isnan(x), but the bundled gcc, which identifies itself
6109 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6111 * floatfns.c (isnan): #undef, and then #define to a clone of
6113 (Fisnan): Always define, since it's always available now.
6114 (syms_of_floatfns): Always define isnan at the Lisp level.
6116 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6118 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6120 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6122 * fileio.c: Fix bugs with large file offsets (Bug#9428).
6123 The previous code assumed that file offsets (off_t values) fit in
6124 EMACS_INT variables, which is not true on typical 32-bit hosts.
6125 The code messed up by falsely reporting buffer overflow in cases
6126 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6127 when "big" contains more than 2**29 bytes, even though this
6128 inserts just one byte and does not overflow the buffer.
6129 (Finsert_file_contents): Store file offsets as off_t
6130 values, not as EMACS_INT values. Check for overflow when
6131 converting between EMACS_INT and off_t. When checking for
6132 buffer overflow or for overlap, take the offsets into account.
6133 Don't use EMACS_INT for small values where int suffices.
6134 When checking for overlap, fix a typo: ZV was used where
6135 ZV_BYTE was intended.
6136 (Fwrite_region): Don't assume off_t fits into 'long'.
6137 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6139 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
6141 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6143 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6145 sprintf-related integer and memory overflow issues (Bug#9412).
6147 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
6148 (esprintf, exprintf, evxprintf): New functions.
6149 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6150 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
6151 (modify_event_symbol): Do not assume that the length of
6152 name_alist_or_stem is safe to alloca and fits in int.
6153 (Fexecute_extended_command): Likewise for function name and binding.
6154 (Frecursion_depth): Wrap around reliably on integer overflow.
6155 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6156 since some callers pass EMACS_INT values.
6157 (Fsingle_key_description): Don't crash if symbol name contains more
6158 than MAX_ALLOCA bytes.
6159 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6160 (get_minibuffer): Arg is now EMACS_INT, not int.
6161 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
6162 (esprintf, exprintf, evxprintf): New decls.
6163 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6165 * dbusbind.c (signature_cat): New function.
6166 (xd_signature, Fdbus_register_signal):
6167 Do not overrun buffer; instead, report string overflow.
6169 * dispnew.c (add_window_display_history): Don't overrun buffer.
6170 Truncate instead; this is OK since it's just a log.
6172 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6173 even if the time zone offset is outlandishly large.
6174 Don't mishandle offset == INT_MIN.
6176 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6177 when creating daemon; the previous buffer-overflow check was incorrect.
6179 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6180 which has the guts of the old verror function.
6182 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6183 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6185 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6186 (font_unparse_xlfd): Don't blindly alloca long strings.
6187 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
6188 fits in int, when using sprintf. Use single snprintf to count
6189 length of string rather than counting it via multiple sprintfs;
6190 that's simpler and more reliable.
6191 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6192 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6193 sprintf, in case result does not fit in int.
6195 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6196 (fontset_from_font): Print it.
6198 * frame.c (tty_frame_count): Now printmax_t, not int.
6199 (make_terminal_frame, set_term_frame_name): Print it.
6200 (x_report_frame_params): In X, window IDs are unsigned long,
6201 not signed long, so print them as unsigned.
6202 (validate_x_resource_name): Check for implausibly long names,
6203 and don't assume name length fits in 'int'.
6204 (x_get_resource_string): Don't blindly alloca invocation name;
6205 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6208 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6209 (xg_check_special_colors, xg_set_geometry):
6210 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6212 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6213 Use esprintf, not sprintf, in case result does not fit in int.
6215 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6216 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6217 it as a large positive number.
6218 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6219 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6221 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6222 in case result does not fit in int.
6224 * print.c (float_to_string): Detect width overflow more reliably.
6225 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6226 buffer overrun. Don't assume list length fits in 'int'. Treat
6227 print length of 0 as 0, not as infinity; to be consistent with other
6228 uses of print length in this function. Don't overflow print length
6229 index. Don't assume hash table size fits in 'long', or that
6230 vectorlike size fits in 'unsigned long'.
6232 * process.c (make_process): Use printmax_t, not int, to format
6233 process-name gensyms.
6235 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6237 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6238 to avoid potential buffer overrun.
6240 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6241 if X resource line is longer than 512 bytes.
6243 * xfns.c (x_window): Make sprintf buffer a bit bigger
6244 to avoid potential buffer overrun.
6246 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6248 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6250 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6252 Integer overflow fixes for scrolling, etc.
6253 Without these, Emacs silently mishandles large integers sometimes.
6254 For example, "C-u 4294967297 M-x recenter" was treated as if
6255 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6257 * xdisp.c (try_window_id): Check Emacs fixnum range before
6258 converting to 'int'.
6260 * window.c (window_scroll_line_based, Frecenter):
6261 Check that an Emacs fixnum is in range before assigning it to 'int'.
6262 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6263 values converted from Emacs fixnums.
6264 (Frecenter): Don't wrap around a line count if it is out of 'int'
6265 range; instead, treat it as an extreme value.
6266 (Fset_window_configuration, compare_window_configurations):
6267 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6269 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6270 that can exceed INT_MAX. Check that EMACS_INT value is in range
6271 before assigning it to the (possibly-narrower) index.
6272 (match_limit): Don't assume that a fixnum can fit in 'int'.
6274 * print.c (print_object): Use ptrdiff_t, not int, for index that can
6277 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
6278 (Fvertical_motion): Don't wrap around LINES values that don't fit
6279 in 'int'. Instead, treat them as extreme values. This is good
6280 enough for windows, which can't have more than INT_MAX lines anyway.
6282 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6284 * Require libxml/parser.h to avoid compilation warning.
6286 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6288 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6289 since this reportedly can destroy thread storage.
6291 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
6293 * syntax.c (find_defun_start): Update all cache variables if
6294 exiting early (Bug#9401).
6296 2011-08-30 Eli Zaretskii <eliz@gnu.org>
6298 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6300 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6301 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6302 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6304 * term.c (tty_append_glyph): New function.
6305 (produce_stretch_glyph): Static function and its prototype deleted.
6307 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6310 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6312 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6313 when checking :margin (Bug#9390).
6314 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
6315 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
6316 so that the name doesn't mislead. All uses changed.
6318 2011-08-28 Johan Bockgård <bojohan@gnu.org>
6320 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6323 2011-08-27 Eli Zaretskii <eliz@gnu.org>
6325 * xdisp.c (move_it_to): Don't bail out early when reaching
6326 position beyond to_charpos, if we are scanning backwards.
6327 (move_it_vertically_backward): When DY == 0, make sure we get to
6328 the first character in the line after the newline.
6330 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6332 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6333 (ccl_driver): Do not generate an out-of-range pointer.
6334 (Fccl_execute_on_string): Remove unnecessary check for
6335 integer overflow, noted by Stefan Monnier in
6336 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6337 Remove a FIXME that didn't need fixing.
6338 Simplify the newly-introduced buffer reallocation code.
6340 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
6342 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6344 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
6346 Integer and memory overflow issues (Bug#9196).
6348 * doc.c (get_doc_string): Rework so that
6349 get_doc_string_buffer_size is the actual buffer size, rather than
6350 being 1 less than the actual buffer size; this makes xpalloc more
6353 * image.c (x_allocate_bitmap_record, cache_image):
6354 * xselect.c (Fx_register_dnd_atom):
6355 Simplify previous changes by using xpalloc.
6357 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6358 since either will do and ptrdiff_t is convenient with xpalloc.
6360 * charset.c (charset_table_size)
6361 (struct charset_sort_data.priority): Now ptrdiff_t.
6362 (charset_compare): Don't overflow if priorities differ greatly.
6363 (Fsort_charsets): Don't assume list length fits in int.
6364 Check for size-calculation overflow when allocating sort data.
6365 (syms_of_charset): Allocate an initial charset table that is
6366 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6368 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6370 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6371 The actual value is always <= INT_MAX, and leaving it unsigned made
6372 overflow checking harder.
6374 * dispextern.h (struct glyph_matrix.rows_allocated)
6375 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6376 with xpalloc. The values are still always <= INT_MAX.
6378 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6380 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6381 (SAFE_NALLOCA): New macro.
6383 * region-cache.c (struct boundary.pos, find_cache_boundary)
6384 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6385 (set_cache_region, invalidate_region_cache)
6386 (revalidate_region_cache, know_region_cache, region_cache_forward)
6387 (region_cache_backward, pp_cache):
6388 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6389 so that ptrdiff_t * can be passed to xpalloc.
6390 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6391 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6392 (pp_cache): Don't assume cache_len fits in int.
6393 * region-cache.h: Adjust extern decls to match.
6395 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6396 EMACS_INT, since either will do, for xpalloc.
6398 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6399 (xnmalloc, xnrealloc, xpalloc): New functions.
6401 * bidi.c (bidi_shelve_header_size): New constant.
6402 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6403 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6405 * bidi.c (bidi_cache_shrink):
6406 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6408 Don't update size of array until after memory allocation succeeds,
6409 because xmalloc/xrealloc may not return.
6410 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6411 now that we have proper integer overflow checking.
6412 (record_overlay_string, overlay_strings): Catch overflows when
6413 calculating size of overlay_str_buf.
6415 * callproc.c (Fcall_process): Check for size overflow when
6416 calculating size of args2.
6417 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6418 Normally we prefer signed values, but sticking with ptrdiff_t would
6419 require adding more-complicated checks.
6421 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6422 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6423 Redo buffer-overflow calculations to avoid integer overflow.
6424 Add a FIXME comment where memory seems to be over-allocated.
6426 * character.c (Fstring): Check for size-calculation overflow.
6428 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6429 unnecessary integer overflow. Check for size overflow.
6430 (encode_coding_object): Don't update size until xmalloc succeeds.
6432 * composite.c (get_composition_id): Check for overflow in glyph
6433 length calculations.
6435 Integer and memory overflow fixes for display code.
6436 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6437 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6438 (scrolling_window): Check for overflow in size calculations.
6439 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6440 Don't assume glyph table len fits in int.
6441 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6442 (row_table_size): Now ptrdiff_t, not int.
6443 (scrolling_window): Avoid overflow in size calculations.
6444 Don't update size until allocation succeeds.
6445 * fns.c (concat): Check for overflow in size calculations.
6446 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6447 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6448 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6450 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6451 (get_doc_string): Check for size calculation overflow.
6452 Don't update size until allocation succeeds.
6453 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6454 EMACS_INT, where ptrdiff_t will do.
6455 (Fsubstitute_command_keys): Check for string overflow.
6457 * editfns.c (set_time_zone_rule): Don't assume environment length
6459 (message_length): Now ptrdiff_t, not int.
6460 (Fmessage_box): Don't update size until allocation succeeds.
6461 Don't assume message length fits in int.
6462 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6464 * emacs.c (main): Do not reallocate argv, since there is a null at
6465 the end that can be overwritten, and this way there's no need to
6466 worry about size-calculation overflow.
6467 (sort_args): Check for size-calculation overflow.
6469 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6471 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6473 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6474 (x_set_scroll_bar_width, x_figure_window_size):
6475 Check for integer overflow.
6476 (x_set_alpha): Do not assume XINT fits in int.
6478 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6479 This is for the members text_lines, text_cols, total_lines, total_cols,
6480 where the system imposes an 'int' limit.
6482 * fringe.c (Fdefine_fringe_bitmap):
6483 Don't update size until alloc works.
6485 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6486 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6488 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6489 Check for size-calculation overflow.
6490 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6491 do, as we prefer signed integers.
6492 (id_to_widget.max_size, id_to_widget.used)
6493 (xg_store_widget_in_map, xg_remove_widget_from_map)
6494 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6495 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6496 Use and return ptrdiff_t, not int.
6497 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6498 * gtkutil.h: Change prototypes to match the above.
6500 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6501 are duplicate now that they've been promoted to lisp.h.
6502 (x_allocate_bitmap_record, x_alloc_image_color)
6503 (make_image_cache, cache_image, xpm_load):
6504 Don't update size until alloc is done.
6505 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6507 Check for size calculation overflow.
6508 (ct_colors_allocated_max): New constant.
6509 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6512 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6513 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6514 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6515 Use ptrdiff_t, not int, to count maps.
6516 (read_char_minibuf_menu_prompt): Check for overflow in size
6517 calculations. Don't update size until allocation succeeds.
6518 Redo calculations to avoid overflow.
6519 * keyboard.h: Change prototypes to match the above.
6521 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6523 (current_minor_maps): Check for size calculation overflow.
6524 * keymap.h: Change prototypes to match the above.
6526 * lread.c (read1, init_obarray): Don't update size until alloc done.
6528 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6529 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6531 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6532 Now ptrdiff_t, not int.
6533 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6534 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6536 * process.c (Fnetwork_interface_list): Check for overflow
6537 in size calculation.
6539 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6541 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6542 overflow. Don't bother calling xmalloc when xrealloc will do.
6544 * search.c (Freplace_match): Check for size calculation overflow.
6545 (Fset_match_data): Don't assume list lengths fit in 'int'.
6547 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6548 for command line length. Do not attempt to address one before the
6549 beginning of an array, as that's not portable.
6551 * term.c (max_frame_lines): Remove; unused.
6552 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6554 (encode_terminal_code, calculate_costs): Check for size
6555 calculation overflow.
6556 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6557 table lengths and related sizes. Don't update size until alloc
6558 done. Redo calculations to avoid overflow.
6559 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6561 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6562 subtracting pointers.
6563 (gobble_line): Check for overflow more carefully. Don't update size
6566 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6567 Don't update size until alloc done.
6568 Redo size calculations to avoid overflow.
6569 Check for size calculation overflow.
6570 (main) [DEBUG]: Fix typo in invoking tparam1.
6572 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6573 Use ptrdiff_t, not int, for sizes.
6574 (store_mode_line_noprop_char): Don't update size until alloc done.
6576 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6577 Use ptrdiff_t, not int, for sizes.
6578 (Finternal_make_lisp_face, cache_face):
6579 Check for size calculation overflow.
6580 (cache_face): Treat size calculation overflows as if they were
6581 memory exhaustion (the usual treatment), rather than aborting.
6583 * xfns.c (x_encode_text, x_set_name_internal)
6584 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6585 sizes, since they can exceed INT_MAX in size. Check for size
6586 calculation overflow.
6588 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6589 (xg_select): Check for size calculation overflow.
6590 Don't update size until alloc done.
6592 * xrdb.c (get_environ_db): Don't assume path length fits in int,
6593 as sprintf is limited to int lengths.
6595 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6596 (X_LONG_MIN): New macros.
6597 Use them to make the following changes clearer.
6598 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6599 This change doesn't affect the value now, but it may help remind
6600 future maintainers not to raise the value too much later.
6601 (SELECTION_QUANTUM): Remove, replacing with ...
6602 (selection_quantum): ... new function, which avoids overflow.
6604 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6605 assumption that selection length fits in 'int'.
6606 (x_reply_selection_request, x_handle_selection_request)
6607 (x_get_window_property, receive_incremental_selection)
6608 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6609 (lisp_data_to_selection_data, clean_local_selection_data):
6610 Use ptrdiff_t, not int, to record length of selection.
6611 (x_reply_selection_request, x_get_window_property)
6612 (receive_incremental_selection, x_property_data_to_lisp):
6613 Redo calculations to avoid overflow.
6614 (x_reply_selection_request): When sending hint, ceiling it at
6615 X_LONG_MAX rather than relying on wraparound overflow to send
6617 (x_get_window_property, receive_incremental_selection)
6618 (lisp_data_to_selection_data, x_property_data_to_lisp):
6619 Check for size-calculation overflow.
6620 (x_get_window_property, receive_incremental_selection)
6621 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6622 Don't store size until memory allocation succeeds.
6623 (x_get_window_property): Plug memory leak on memory exhaustion.
6624 Don't double-block input; malloc is safe here. Don't assume 2**34
6625 - 4 fits in unsigned long. Add an xassert to check
6626 XGetWindowProperty overflow. Be more careful about overflow
6627 calculations, and distinguish size from memory overflow better.
6628 (receive_incremental_selection): When tracing, don't assume
6629 unsigned int is less than INT_MAX.
6630 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6631 harmful) conversions of unsigned short to int.
6632 (lisp_data_to_selection_data): Don't assume that integers
6633 in the range -65535 through -1 fit in an X unsigned short.
6634 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6635 result parameters unless successful. Rely on cons_to_unsigned
6636 to report problems with elements; the old code wasn't right anyway.
6637 (x_check_property_data): Check for int overflow; we cannot use
6638 a wider type due to X limits.
6639 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6641 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
6643 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6644 (x_term_init): Check for size calculation overflow.
6645 (x_color_cells): Don't store size until memory allocation succeeds.
6646 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
6647 Don't assume alloca size is less than MAX_ALLOCA.
6648 (x_term_init): Don't assume length fits in int (sprintf is limited
6651 Use ptrdiff_t for composition IDs.
6652 * character.c (lisp_string_width):
6653 * composite.c (composition_table_size, n_compositions)
6654 (get_composition_id, composition_gstring_from_id):
6655 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6656 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6657 * window.c (Frecenter):
6658 Use ptrdiff_t, not int, for composition IDs.
6659 * composite.c (get_composition_id): Check for integer overflow.
6660 * composite.h: Adjust prototypes to match the above changes.
6662 Use ptrdiff_t for hash table indexes.
6663 * category.c (hash_get_category_set):
6664 * ccl.c (ccl_driver):
6665 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6666 * coding.c (coding_system_charset_list, detect_coding_system):
6667 * coding.h (struct coding_system.id):
6668 * composite.c (get_composition_id, gstring_lookup_cache):
6669 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6670 * image.c (xpm_get_color_table_h):
6671 * lisp.h (hash_lookup, hash_put):
6672 * minibuf.c (Ftest_completion):
6673 Use ptrdiff_t for hash table indexes, not int (which is too
6674 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6675 32-bit --with-wide-int hosts).
6677 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6678 Add a FIXME comment about memory leaks.
6679 (syms_of_charset): Don't assume xmalloc returns.
6681 Don't assume that stated character widths fit in int.
6682 * character.c (Fchar_width, c_string_width, lisp_string_width):
6683 * character.h (CHAR_WIDTH):
6684 * indent.c (MULTIBYTE_BYTES_WIDTH):
6685 Use sanitize_char_width to avoid undefined and/or bad behavior
6686 with outlandish widths.
6687 * character.h (sanitize_tab_width): Rename from sanitize_width,
6688 now that we have two such functions. All uses changed.
6689 (sanitize_char_width): New inline function.
6691 Don't assume that tab-width fits in int.
6692 * character.h (sanitize_width): New inline function.
6693 (SANE_TAB_WIDTH): New macro.
6694 (ASCII_CHAR_WIDTH): Use it.
6695 * indent.c (sane_tab_width): Remove. All uses replaced by
6696 SANE_TAB_WIDTH (current_buffer).
6697 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6699 * fileio.c: Integer overflow issues with file modes.
6700 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6702 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6703 Remove unreachable code.
6704 (read_hex, load_charset_map_from_file): Check for integer overflow.
6706 * xterm.c: Don't go over XClientMessageEvent limit.
6707 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6708 (x_send_scroll_bar_event): Likewise. Check that the size does not
6709 exceed limits imposed by XClientMessageEvent, as well as the usual
6710 ptrdiff_t and size_t limits.
6712 * keyboard.c: Overflow, signedness and related fixes.
6713 (make_lispy_movement): Use same integer type in forward decl
6714 that is used in the definition.
6715 (read_key_sequence, keyremap_step):
6716 Change bufsize argument back to int, undoing my 2011-03-30 change.
6717 We prefer signed types, and int is wide enough here.
6718 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6719 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6720 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6721 length, not size_t. Use ptrdiff_t for index, not int.
6722 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6723 possibility of integer overflow.
6725 Overflow, signedness and related fixes for images.
6727 * dispextern.h (struct it.stack[0].u.image.image_id)
6728 (struct_it.image_id, struct image.id, struct image_cache.size)
6729 (struct image_cache.used, struct image_cache.ref_count):
6730 * gtkutil.c (update_frame_tool_bar):
6731 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6732 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6733 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6734 * nsmenu.m (update_frame_tool_bar):
6735 * xdisp.c (calc_pixel_width_or_height):
6736 * xfns.c (image_cache_refcount):
6737 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6738 on typical 64-bit hosts.
6740 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6741 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6742 Omit unnecessary casts to int.
6743 (parse_image_spec): Check that integers fall into 'int' range
6744 when the callers expect that.
6745 (image_ascent): Redo ascent calculation to avoid int overflow.
6746 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6747 (lookup_image): Remove unnecessary tests.
6748 (xbm_image_p): Locals are now of int, not EMACS_INT,
6749 since parse_image_check makes sure they fit into int.
6750 (png_load, gif_load, svg_load_image):
6751 Prefer int to unsigned where either will do.
6752 (tiff_handler): New function, combining the cores of the
6753 old tiff_error_handler and tiff_warning_handler.
6754 This function is rewritten to use vsnprintf and thereby avoid
6755 stack buffer overflows. It uses only the features of vsnprintf
6756 that are common to both POSIX and native Microsoft.
6757 (tiff_error_handler, tiff_warning_handler): Use it.
6758 (tiff_load, gif_load, imagemagick_load_image):
6759 Don't assume :index value fits in 'int'.
6760 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6761 (imagemagick_load_image): Check that crop parameters fit into
6762 the integer types that MagickCropImage accepts. Don't assume
6763 Vimagemagick_render_type has a nonnegative value. Don't assume
6764 size_t fits in 'long'.
6765 (gs_load): Use printmax_t to print the widest integers possible.
6766 Check for integer overflow when computing image height and width.
6768 2011-08-26 Eli Zaretskii <eliz@gnu.org>
6770 * xdisp.c (redisplay_window): Don't force window start if point
6771 will be invisible in the resulting window. (Bug#9324)
6773 2011-08-25 Eli Zaretskii <eliz@gnu.org>
6775 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6776 the display spec is of the form `(space ...)'.
6777 (handle_display_spec): Return the value returned by
6778 handle_single_display_spec, not just 1 or zero.
6779 (handle_single_display_spec): If the display spec is of the form
6780 `(space ...)', and specifies display in the text area, return 2
6782 (try_cursor_movement): Check for the need to scroll more
6783 accurately, and prefer exact match for point under bidi.
6784 Don't advance `row' beyond the last row of the window.
6786 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6787 into disp_prop; all users changed.
6789 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6790 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6791 for the text covered by the display property.
6793 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
6795 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6796 Change return value to nil.
6797 (Frecord_buffer): Delete unused function.
6799 2011-08-24 Eli Zaretskii <eliz@gnu.org>
6801 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6802 buffers, return left-to-right.
6803 (set_cursor_from_row): Consider candidate row a win if its glyph
6804 represents a newline and point is on that newline. Fixes cursor
6805 positioning on the newline at EOL of R2L text within L2R
6806 paragraph, and vice versa.
6807 (try_cursor_movement): Check continued rows, in addition to
6808 continuation rows. Fixes unwarranted scroll when point enters a
6809 continued line of R2L text within an L2R paragraph, or vice versa.
6810 (cursor_row_p): Consider the case of point being equal to
6811 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6812 from the end of a short line to the beginning of a continued line
6813 of R2L text within L2R paragraph.
6814 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6815 composed characters.
6817 * bidi.c (bidi_check_type): Use xassert.
6818 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6821 2011-08-23 Eli Zaretskii <eliz@gnu.org>
6823 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6826 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
6828 * nsfont.m (ns_otf_to_script): Fix typo.
6830 2011-08-22 Kenichi Handa <handa@m17n.org>
6832 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6833 extra slot even if the purpose is char-code-property-table.
6835 2011-08-23 Eli Zaretskii <eliz@gnu.org>
6837 * xdisp.c (redisplay_window): When computing centering_position,
6838 account for the height of the header line. (Bug#8874)
6840 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6841 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6842 candidate is selected by the mouse, and that candidate has a
6843 composed character under the mouse.
6845 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6846 coordinates reported by pos-visible-in-window-p for a composed
6847 character in column zero.
6849 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6851 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6853 2011-08-22 Eli Zaretskii <eliz@gnu.org>
6855 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6856 consider it a hit if to_charpos is anywhere in the range of the
6857 composed buffer positions.
6859 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
6861 * image.c (gif_load): Don't assume that each subimage has the same
6862 dimensions as the base image. Handle disposal method that is
6863 "undefined" by the gif spec (Bug#9335).
6865 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
6867 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
6868 (Fcondition_case): Document `debug' symbol in error handler.
6870 2011-08-19 Eli Zaretskii <eliz@gnu.org>
6872 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6873 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6874 from an Org mode buffer to a Speedbar frame.
6876 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6877 a composition, take its buffer position from IT->cmp_it.charpos.
6878 Fixes cursor positioning at the beginning of a line that begins
6879 with a composed character.
6881 2011-08-18 Eli Zaretskii <eliz@gnu.org>
6883 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6884 character bidirectional type, use STRONG_L instead. Fixes crashes
6885 in a buffer produced by `describe-categories'.
6887 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6888 members before the level stack, so they would be saved and
6889 restored when copying iterator state. Fixes incorrect reordering
6890 around TABs covered by display properties.
6892 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6894 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
6896 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
6898 * eval.c (internal_condition_case, internal_condition_case_1)
6899 (internal_condition_case_2, internal_condition_case_n):
6900 Remove unnecessary aborts (Bug#9081).
6902 2011-08-17 Eli Zaretskii <eliz@gnu.org>
6904 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6905 has no `load' handler, try opening the file locally. (Bug#9311)
6907 2011-08-16 Ken Brown <kbrown@cornell.edu>
6909 * gmalloc.c: Expand comment.
6911 2011-08-16 Eli Zaretskii <eliz@gnu.org>
6913 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6914 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6916 2011-08-16 Ken Brown <kbrown@cornell.edu>
6918 Fix memory allocation problems in Cygwin build (Bug#9273).
6920 * unexcw.c ( __malloc_initialized): Declare external variable.
6921 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6923 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6925 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6927 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6929 [CYGWIN] (special_realloc): New function.
6930 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6931 requests to realloc storage in the static heap.
6933 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6935 * bidi.c (bidi_initialize): Remove unused local.
6937 2011-08-15 Eli Zaretskii <eliz@gnu.org>
6940 * biditype.h: Remove file.
6941 * makefile.w32-in ($(BLD)/bidi.$(O)):
6942 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
6944 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6946 * chartab.c: Improve commentary for the uniprop_table API.
6948 * bidi.c (bidi_paragraph_init): Support zero value of
6949 bidi_ignore_explicit_marks_for_paragraph_level.
6950 (bidi_initialize): Use uniprop_table instead of including
6951 biditype.h and bidimirror.h.
6953 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6954 coordinates of the iterator when restoring from ppos_it.
6957 2011-08-14 Kenichi Handa <handa@m17n.org>
6959 * process.c (create_process): Call setup_process_coding_systems
6960 after the pid of the process is set to -1 (Bug#8162).
6962 2011-08-14 Eli Zaretskii <eliz@gnu.org>
6964 * xdisp.c (move_it_in_display_line_to): Don't invoke
6965 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6966 ppos_it. Fixes vertical cursor motion when line beginning is
6967 covered by an image. (Bug#9296)
6969 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6971 * nsterm.h (ns_run_ascript): Declare.
6972 (NSAPP_DATA2_RUNASSCRIPT): Define.
6974 * nsfns.m (as_script, as_result, as_status): New static variables.
6975 (ns_run_ascript): New function.
6976 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
6977 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6978 the event loop. Get status from as_status (Bug#7276).
6980 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6981 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6982 the event loop (Bug#7276).
6984 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6986 * gnutls.c (QCgnutls_bootprop_priority)
6987 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6988 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6989 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6990 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6991 (QCgnutls_bootprop_verify_hostname_error)
6992 (QCgnutls_bootprop_callbacks_verify): Rename from
6993 Qgnutls_bootprop_..., all uses changed.
6995 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6998 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7000 * xfaces.c (Qframe_set_background_mode): Now static.
7001 * dispextern.h (Qframe_set_background_mode): Remove decl.
7003 * process.c (Fnetwork_interface_info): Declare local only if needed.
7005 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7007 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7008 (Fnetwork_interface_list): Allocate in increments of bytes instead
7009 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7010 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7012 (struct ifflag_def): notrailers is smart on OSX.
7013 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7014 Get hardware address with getifaddrs if available.
7016 2011-08-12 Eli Zaretskii <eliz@gnu.org>
7018 * xdisp.c (iterate_out_of_display_property): xassert that
7019 IT->position is set to within IT->object's boundaries. Break from
7020 the loop as soon as EOB is reached; avoids infloops in redisplay
7021 when IT->position is set up wrongly due to some bug.
7022 Set IT->current to match the bidi iterator unconditionally.
7023 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7024 entry. Force push_it to save on the stack the current
7025 buffer/string position, to be restored by pop_it. Fix flags in
7026 the iterator structure wrt the object coming from a display
7027 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7028 properties. (Bug#9284)
7030 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
7032 * fontset.c (fontset_get_font_group): Add proper type checks.
7035 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7037 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7038 and LC_VERSION_MIN_MACOSX.
7039 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7040 (dump_it) [LC_FUNCTION_STARTS]: Use it.
7042 2011-08-08 Eli Zaretskii <eliz@gnu.org>
7044 * xdisp.c (forward_to_next_line_start): Allow to use the
7045 no-display-properties-and-no-overlays under bidi display.
7046 Set disp_pos in the bidi iterator to avoid searches for display
7047 properties and overlays.
7049 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
7051 * editfns.c (Fset_time_zone_rule): Document relationship with the
7054 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7055 the font entity extracted from the cache (Bug#8109).
7057 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
7059 * composite.c (autocmp_chars): Don't reset point. That is done by
7060 restore_point_unwind (Bug#5984).
7062 2011-08-07 Juri Linkov <juri@jurta.org>
7064 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7065 to show the arg `TIME' instead of `TIMEVAL'.
7067 2011-08-06 Eli Zaretskii <eliz@gnu.org>
7069 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7070 display property strides EOL and includes a newline, as in
7071 longlines-mode. (Bug#9254)
7072 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7073 word-wrap under bidirectional display. (Bug#9224)
7075 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7076 is non-zero, even if the data buffer is NULL. Fixes a crash in
7077 vertical-motion with longlines-mode. (Bug#9254)
7079 2011-08-05 Eli Zaretskii <eliz@gnu.org>
7081 * bidi.c <bidi_cache_total_alloc>: Now static.
7082 (bidi_initialize): Initialize bidi_cache_total_alloc.
7084 * xdisp.c (display_line): Release buffer allocated for shelved bidi
7087 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7088 amount allocated this far in `bidi_cache_total_alloc'.
7089 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7090 non-zero, only free the data buffer without restoring the cache
7091 contents. All callers changed.
7093 * dispextern.h (bidi_unshelve_cache): Update prototype.
7095 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7096 (move_it_in_display_line, move_it_to)
7097 (move_it_vertically_backward, move_it_by_lines): Replace the call
7098 to xfree to an equivalent call to bidi_unshelve_cache.
7099 (move_it_in_display_line_to): Fix logic of returning
7100 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
7102 2011-08-05 Eli Zaretskii <eliz@gnu.org>
7104 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7105 came from a string character with a `cursor' property. (Bug#9229)
7107 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7109 * Makefile.in (LIB_PTHREAD): New variable.
7110 (LIBES): Add LIB_PTHREAD (Bug#9216).
7112 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7113 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7115 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7117 * regex.c (re_iswctype): Remove some redundant boolean conversions.
7119 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7121 * xterm.c (x_find_topmost_parent): New function.
7122 (x_set_frame_alpha): Find topmost parent window with
7123 x_find_topmost_parent and set the property there also (bug#9181).
7124 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7126 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7128 * callproc.c (Fcall_process): Avoid vfork clobbering
7129 the local vars buffer, coding_systems, current_dir.
7131 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7133 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7135 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7137 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7138 so that it is not optimized away.
7140 * xdisp.c (compute_display_string_pos): Remove unused local.
7142 2011-08-02 Eli Zaretskii <eliz@gnu.org>
7144 Fix slow cursor motion and scrolling in large buffers with
7145 selective display, like Org Mode buffers. (Bug#9218)
7147 * dispextern.h (struct bidi_it): New member disp_prop_p.
7149 * xdisp.c: Remove one-slot cache of display string positions.
7150 (compute_display_string_pos): Accept an additional argument
7151 DISP_PROP_P; callers changed. Scan at most 5K characters forward
7152 for a display string or property. If found, set DISP_PROP_P
7155 * bidi.c (bidi_fetch_char): Accept an additional argument
7156 DISP_PROP_P, and pass it to compute_display_string_pos.
7157 Only handle text covered by a display string if DISP_PROP_P is returned
7158 non-zero. All callers of bidi_fetch_char changed.
7160 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7162 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7164 2010-12-03 Don March <don@ohspite.net>
7166 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7167 last character M-[char] is translated to ESC [char] (bug#7541).
7169 2011-08-02 Kenichi Handa <handa@m17n.org>
7171 * lisp.h (uniprop_table): Extern it.
7173 * chartab.c (uniprop_table): Make it non-static.
7175 2011-08-01 Eli Zaretskii <eliz@gnu.org>
7177 * xdisp.c (forward_to_next_line_start): Accept additional argument
7178 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7180 (reseat_at_next_visible_line_start): Use the bidi iterator state
7181 returned by forward_to_next_line_start to restore the state of
7182 it->bidi_it after backing up to previous newline. (Bug#9212)
7184 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7186 * regex.c (re_comp): Protoize.
7187 (re_exec): Fix return type.
7188 (regexec): Fix type of `ret'. (Bug#9203)
7190 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7192 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7193 This is needed if max-image-size is a floating-point number.
7195 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7197 * print.c (print_object): Print empty symbol as ##.
7199 * lread.c (read1): Read ## as empty symbol.
7201 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7203 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7204 setting frame foreground color (Bug#9175).
7205 (x_set_background_color): Likewise.
7207 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7208 contents (Bug#9176).
7209 (EmacsTooltip -init): Remove bezels and add shadows to
7212 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7213 or scroll bar (Bug#8470).
7215 * nsfont.m (nsfont_open): Remove assignment to voffset and
7216 unnecessary vars hshink, expand, hd, full_height, min_height.
7217 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7219 * nsterm.h (nsfont_info): Remove voffset field.
7221 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7223 Implement strike-through and overline on NextStep (Bug#8863).
7225 * nsfont.m (nsfont_open): Use underline position provided by font,
7226 instead of hard-coded value of 2.
7227 (nsfont_draw): Call ns_draw_text_decoration instead.
7229 * nsterm.h: Add declaration for ns_draw_text_decoration.
7231 * nsterm.m (ns_draw_text_decoration): New function for drawing
7232 underline, overline, and strike-through.
7233 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7234 ns_draw_text_decoration. Change treatment of cursor drawing to
7235 accommodate underlining, etc.
7237 2011-07-28 Eli Zaretskii <eliz@gnu.org>
7239 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7242 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7244 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7245 Without this fix, if a signal arrives just after memory fills up,
7246 'malloc' might be invoked reentrantly.
7248 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7249 In other words, assume that every image size is allowed, on non-X
7250 hosts. This assumption is probably wrong, but it lets Emacs compile.
7252 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7254 * regex.c (re_iswctype): Convert return values to boolean.
7256 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7258 * xdisp.c (compute_display_string_pos): Don't use cached display
7259 string position if the buffer had its restriction changed.
7262 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7264 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7266 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7268 Integer signedness and overflow and related fixes. (Bug#9079)
7270 * bidi.c: Integer size and overflow fixes.
7271 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7272 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7273 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7274 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7275 (bidi_find_other_level_edge):
7276 Use ptrdiff_t instead of EMACS_INT where either will do.
7277 This works better on 32-bit hosts configured --with-wide-int.
7278 (bidi_cache_ensure_space): Check for size-calculation overflow.
7279 Use % rather than repeated addition, for better worst-case speed.
7280 Don't set bidi_cache_size until after xrealloc returns, because it
7282 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
7283 (bidi_cache_ensure_space): Also check that the bidi cache size
7284 does not exceed that of the largest Lisp string or buffer. See Eli
7285 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
7287 * alloc.c (__malloc_size_t): Remove.
7288 All uses replaced by size_t. See Andreas Schwab's note
7289 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7291 * image.c: Improve checking for integer overflow.
7292 (check_image_size): Assume that f is nonnull, since
7293 it is always nonnull in practice. This is one less thing to
7294 worry about when checking for integer overflow later.
7295 (x_check_image_size): New function, which checks for integer
7296 overflow issues inside X.
7297 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7298 This removes the need for a memory_full check.
7299 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7300 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7301 (xbm_read_bitmap_data): Change locals back to 'int', since
7302 their values must fit in 'int'.
7303 (xpm_load_image, png_load, tiff_load):
7304 Invoke x_create_x_image_and_pixmap earlier,
7305 to avoid much needless work if the image is too large.
7306 (tiff_load): Treat overly large images as if
7307 x_create_x_image_and_pixmap failed, not as malloc failures.
7308 (gs_load): Use x_check_image_size.
7310 * gtkutil.c: Omit integer casts.
7311 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7312 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7314 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7316 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7317 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7318 would wrongly return t on a 64-bit host.
7320 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7321 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7322 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7323 and therefore cause GCC to emit a bogus diagnostic in some cases.
7325 * image.c: Integer signedness and overflow and related fixes.
7326 This is not an exhaustive set of fixes, but it's time to
7327 record what I've got.
7328 (lookup_pixel_color, check_image_size): Remove redundant decls.
7329 (check_image_size): Don't assume that arbitrary EMACS_INT values
7330 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7331 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7332 (tiff_load, imagemagick_load_image):
7333 Check for overflow in size calculations.
7334 (x_create_x_image_and_pixmap): Remove unnecessary test for
7335 xmalloc returning NULL; that can't happen.
7336 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7337 (xpm_color_bucket): Use better integer hashing function.
7338 (xpm_cache_color): Don't possibly over-allocate memory.
7339 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7340 (gif_memory_source):
7341 Use ptrdiff_t, not int or size_t, to record sizes.
7342 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7343 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7344 either works, as we prefer signed integers.
7345 (tiff_read_from_memory, tiff_write_from_memory):
7346 Return tsize_t, not size_t, since that's what the TIFF API wants.
7347 (tiff_read_from_memory): Don't fail simply because the read would
7348 go past EOF; instead, return a short read.
7349 (tiff_load): Omit no-longer-needed casts.
7350 (Fimagemagick_types): Don't assume size fits into 'int'.
7352 Improve hashing quality when configured --with-wide-int.
7353 * fns.c (hash_string): New function, taken from sxhash_string.
7354 Do not discard information about ASCII character case; this
7355 discarding is no longer needed.
7356 (sxhash-string): Use it. Change sig to match it. Caller changed.
7357 * lisp.h: Declare it.
7358 * lread.c (hash_string): Remove, since we now use fns.c's version.
7359 The fns.c version returns a wider integer if --with-wide-int is
7360 specified, so this should help the quality of the hashing a bit.
7362 * emacs.c: Integer overflow minor fix.
7363 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7364 Define only if GNU_LINUX.
7365 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7367 * dispnew.c: Integer signedness and overflow fixes.
7368 Remove unnecessary forward decls, that were a maintenance hassle.
7369 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7371 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7372 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7373 (prepare_desired_row, line_draw_cost):
7374 Use int, not unsigned, where either works.
7375 (save_current_matrix, restore_current_matrix):
7376 Use ptrdiff_t, not size_t, where either works.
7377 (init_display): Check for overflow more accurately, and without
7378 relying on undefined behavior.
7380 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7381 Remove, replacing with the new symbols in lisp.h. All uses changed.
7382 * fileio.c (make_temp_name):
7383 * filelock.c (lock_file_1, lock_file):
7384 * xdisp.c (message_dolog):
7385 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7386 Use pMd etc. instead.
7387 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7388 replacing the pWIDE etc. symbols removed from editfns.c.
7390 * keyboard.h (num_input_events): Now uintmax_t.
7391 This is (very slightly) less likely to mess up due to wraparound.
7394 * buffer.c: Integer signedness fixes.
7395 (alloc_buffer_text, enlarge_buffer_text):
7396 Use ptrdiff_t rather than size_t when either will do, as we prefer
7399 * alloc.c: Integer signedness and overflow fixes.
7400 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7401 (__malloc_size_t): Default to size_t, not to int.
7402 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7403 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7404 Prefer ptrdiff_t to size_t when either would do, as we prefer
7406 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7407 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7408 Now const. Initialize with values that are in range even if char
7410 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7411 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7412 These functions do the right thing with sizes > 2**32.
7413 (check_depth): Now ptrdiff_t, not int.
7414 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7415 Adjust to new way of storing sizes. Check for size overflow bugs
7417 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7418 slightly wrong anyway, as it missed one instance of
7419 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7420 (refill_memory_reserve): Omit needless cast to size_t.
7421 (mark_object_loop_halt): Mark as externally visible.
7423 * xselect.c: Integer signedness and overflow fixes.
7424 (Fx_register_dnd_atom, x_handle_dnd_message):
7425 Use ptrdiff_t, not size_t, since we prefer signed.
7426 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7427 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7428 x_dnd_atoms_size and x_dnd_atoms_length.
7430 * doprnt.c: Prefer signed to unsigned when either works.
7432 * doprnt.c (doprnt):
7434 * xdisp.c (vmessage):
7435 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7436 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7437 prefer signed arithmetic to avoid comparison confusion.
7438 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7439 but is a bit tricky.
7441 Assume freestanding C89 headers, string.h, stdlib.h.
7442 * data.c, doprnt.c, floatfns.c, print.c:
7443 Include float.h unconditionally.
7444 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7445 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7446 * regex.c: Likewise for stddef.h, string.h.
7447 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7448 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7449 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7450 (STDC_HEADERS): Remove obsolete defines.
7451 * sysdep.c: Include limits.h unconditionally.
7453 Assume support for memcmp, memcpy, memmove, memset.
7454 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7455 * regex.c (memcmp, memcpy):
7456 Remove; we assume C89 now.
7458 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7459 (__malloc_safe_bcopy): Remove; no longer needed.
7461 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
7462 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7463 well either way, and we prefer signed to unsigned.
7465 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7467 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7468 closes the connection while we're reading (bug#9182).
7470 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
7472 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7473 are specified (Bug#9168).
7475 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7477 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7478 Found by GCC static checking and --with-wide-int on a 32-bit host.
7480 2011-07-25 Eli Zaretskii <eliz@gnu.org>
7482 * xdisp.c (compute_display_string_pos): Fix logic of caching
7483 previous display string position. Initialize cached_prev_pos to
7484 -1. Fixes slow-down at the beginning of a buffer.
7486 2011-07-24 Eli Zaretskii <eliz@gnu.org>
7488 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7489 for attrs[LFACE_FONTSET_INDEX].
7491 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7493 * xml.c (parse_region): Remove unused local
7494 that was recently introduced.
7496 2011-07-23 Eli Zaretskii <eliz@gnu.org>
7498 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7499 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7501 * xdisp.c (move_it_in_display_line_to): Record the best matching
7502 position for TO_CHARPOS while scanning the line, and restore it on
7503 exit if none of the characters scanned was an exact match.
7504 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
7505 when exact match is impossible due to invisible text, and the
7506 lines are truncated.
7508 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7510 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7513 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7515 Fix a significant slow-down of cursor motion with C-n, C-p,
7516 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7517 auto-repeat under bidi redisplay in fontified buffers.
7518 * xdisp.c (compute_stop_pos_backwards): New function.
7519 (next_element_from_buffer): Call compute_stop_pos_backwards to
7520 find a suitable prev_stop when we find ourselves before
7522 (reseat): Don't look for prev_stop, as that could mean a very long
7524 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7525 <cached_disp_overlay_modiff>: Cache for last found display string
7527 (compute_display_string_pos): Return the cached position if asked
7528 about the same buffer in the same area of character positions, and
7529 the buffer wasn't changed since the time the display string
7530 position was cached.
7532 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7534 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7535 is an integer, which is important for empty lines. (Bug#9149)
7537 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
7539 * frame.c (Fmodify_frame_parameters): In tty case, update the
7540 default face if necessary (Bug#4238).
7542 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
7544 * editfns.c (Fstring_to_char): No need to explain what a character
7545 is in the docstring (Bug#6576).
7547 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7549 * xml.c (parse_region): Make sure we always return a tree.
7551 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7553 * xml.c (parse_region): If a document contains only comments,
7556 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7558 * xml.c (make_dom): Return comments, too.
7560 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7563 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7564 and the surrounding thread.
7565 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7566 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7567 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7569 * s/openbsd.h (BROKEN_SIGIO): Define.
7570 * unexelf.c (unexec) [__OpenBSD__]:
7571 Don't update the .mdebug section of the Alpha COFF symbol table.
7573 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7575 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7578 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7580 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7581 This fixes some race conditions on the permissions of any newly
7584 * alloc.c (valid_pointer_p): Use pipe, not open.
7585 This fixes some permissions issues when debugging.
7587 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7588 If fchown fails to set both uid and gid, try to set just gid,
7589 as that is sometimes allowed. Adjust the file's mode to eliminate
7590 setuid or setgid bits that are inappropriate if fchown fails.
7592 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7594 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7595 to compare Lisp_Objects.
7596 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7597 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7598 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7600 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7602 * lread.c (read_integer): Unread even EOF character.
7603 (read1): Likewise. Properly record start position of symbol.
7605 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7606 symbol character follows.
7608 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7610 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7611 This works around a problem with the previous change to Fcopy_file.
7612 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7613 and without this change, GCC might complain about discarding
7614 fchown's return value.
7616 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
7618 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7620 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7622 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7624 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7626 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7627 it's used from the C level.
7629 * process.c: Use the same condition for POLL_FOR_INPUT in both
7630 keyboard.c and process.c (bug#1858).
7632 2011-07-09 Lawrence Mitchell <wence@gmx.li>
7634 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7635 (Fgnutls_boot): Use it.
7637 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7639 * doc.c (Fsubstitute_command_keys): Revert last change.
7641 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7643 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7644 quotes the next character, and doesn't affect other longer
7645 sequences (bug#8935).
7647 * lread.c (syms_of_lread): Clarify that is isn't only
7648 `eval-buffer' and `eval-defun' that's affected by
7649 `lexical-binding' (bug#8460).
7651 2011-07-15 Eli Zaretskii <eliz@gnu.org>
7653 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
7654 bidi redisplay when a line includes both an image and is truncated.
7656 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7658 Fix minor problems found by static checking.
7659 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7660 (elsz): Now a signed constant, not a size_t var. We prefer signed
7661 types to unsigned, to avoid integer comparison confusion. Without
7662 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7663 "cannot optimize loop, the loop counter may overflow", a symptom
7665 * indent.c (Fvertical_motion): Mark locals as initialized.
7666 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7668 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7670 * search.c (Fre_search_backward): Mention `case-fold-search' in
7671 all the re_search_* functions (bug#8138).
7673 * keyboard.c (Fopen_dribble_file): Document when the file is
7676 2011-07-14 Eli Zaretskii <eliz@gnu.org>
7678 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7681 Support bidi reordering of display and overlay strings.
7682 * xdisp.c (compute_display_string_pos)
7683 (compute_display_string_end): Accept additional argument STRING.
7684 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7685 (reseat_to_string): Initialize bidi_it->string.s and
7686 bidi_it->string.schars.
7687 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
7688 NULL (avoids a crash in bidi_paragraph_init).
7689 Initialize itb.string.lstring.
7690 (init_iterator): Call bidi_init_it only of a valid
7691 buffer position was specified. Initialize paragraph_embedding to
7693 (reseat_to_string): Initialize the bidi iterator.
7694 (display_string): If we need to ignore text properties of
7695 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7696 original value of -1 will not work with bidi.)
7697 (compute_display_string_pos): First arg is now struct
7698 `text_pos *'; all callers changed. Support display properties on
7700 (compute_display_string_end): Support display properties on Lisp
7702 (init_iterator, reseat_1, reseat_to_string): Initialize the
7703 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7704 when iterating on a string not from display properties).
7705 (compute_display_string_pos, compute_display_string_end):
7706 Fix calculation of the object to scan. Fixes an error when using
7708 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
7709 base_level_stop; instead, set base_level_stop to BEGV.
7710 Fixes crashes in vertical-motion.
7711 (next_element_from_buffer): Improve commentary for when
7712 the iterator is before prev_stop.
7713 (init_iterator): Initialize bidi_p from the default value of
7714 bidi-display-reordering, not from buffer-local value. Use the
7715 buffer-local value only if initializing for buffer iteration.
7716 (handle_invisible_prop): Support invisible properties on strings
7717 that are being bidi-reordered.
7718 (set_iterator_to_next): Support bidi reordering of C strings and
7720 (next_element_from_string): Support bidi reordering of Lisp
7722 (handle_stop_backwards): Support Lisp strings as well.
7723 (display_string): Support display of R2L glyph rows.
7724 Use IT_STRING_CHARPOS when displaying from a Lisp string.
7725 (init_iterator): Don't initialize it->bidi_p for strings
7727 (reseat_to_string): Initialize it->bidi_p for strings here.
7728 (next_element_from_string, next_element_from_c_string)
7729 (next_element_from_buffer): Add xassert's for correspondence
7730 between IT's object being iterated and it->bidi_it.string
7732 (face_before_or_after_it_pos): Support bidi iteration.
7733 (next_element_from_c_string): Handle the case of the first string
7734 character that is not the first one in the visual order.
7735 (get_visually_first_element): New function, refactored from common
7736 parts of next_element_from_buffer, next_element_from_string, and
7737 next_element_from_c_string.
7738 (tool_bar_lines_needed, redisplay_tool_bar)
7739 (display_menu_bar): Force left-to-right direction. Add a FIXME
7740 comment for making that be controlled by a user option.
7741 (push_it, pop_it): Save and restore the state of the
7742 bidi iterator. Save and restore the bidi_p flag.
7743 (pop_it): Iterate out of display property for string iteration as
7745 (iterate_out_of_display_property): Support iteration over strings.
7746 (handle_single_display_spec): Set up it->bidi_it for iteration
7747 over a display string, and call bidi_init_it.
7748 (handle_single_display_spec, next_overlay_string)
7749 (get_overlay_strings_1, push_display_prop): Set up the bidi
7750 iterator for displaying display or overlay strings.
7751 (forward_to_next_line_start): Don't use the shortcut if
7753 (back_to_previous_visible_line_start): If handle_display_prop
7754 pushed the iterator stack, restore the internal state of the bidi
7755 iterator by calling bidi_pop_it same number of times.
7756 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7757 and we are bidi-iterating, don't decrement the iterator position;
7758 instead, set the first_elt flag in the bidi iterator, to produce
7760 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7761 (push_display_prop): xassert that we are iterating a buffer.
7762 (push_it, pop_it): Save and restore paragraph_embedding member.
7763 (handle_single_display_spec, next_overlay_string)
7764 (get_overlay_strings_1, reseat_1, reseat_to_string)
7765 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7766 correctly. Don't assume unibyte strings are not bidi-reordered.
7767 (compute_display_string_pos)
7768 (compute_display_string_end): Fix handling the case of C string.
7769 (push_it, pop_it): Save and restore from_disp_prop_p.
7770 (handle_single_display_spec, push_display_prop): Set the
7771 from_disp_prop_p flag.
7772 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7773 (pop_it): Call iterate_out_of_display_property only if we are
7774 popping after iteration over a string that came from a display
7775 property. Fix a typo in popping stretch info. Add an assertion
7776 for verifying that the iterator position is in sync with the bidi
7778 (handle_single_display_spec, get_overlay_strings_1)
7779 (push_display_prop): Fix initialization of paragraph direction for
7780 string when that of the parent object is not yet determined.
7781 (reseat_1): Call bidi_init_it to resync the bidi
7782 iterator with IT's position. (Bug#7616)
7783 (find_row_edges): If ROW->start.pos gives position
7784 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7785 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7786 Reset the from_disp_prop_p flag.
7787 (SAVE_IT, RESTORE_IT): New macros.
7788 (pos_visible_p, face_before_or_after_it_pos)
7789 (back_to_previous_visible_line_start)
7790 (move_it_in_display_line_to, move_it_in_display_line)
7791 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7792 (try_scrolling, redisplay_window, display_line): Use them when
7793 saving a temporary copy of the iterator and restoring it back.
7794 (back_to_previous_visible_line_start, reseat_1)
7795 (init_iterator): Empty the bidi cache "stack".
7796 (move_it_in_display_line_to): If iterator ended up at
7797 EOL, but we never saw any buffer positions smaller than
7798 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7799 motion in bidi-reordered lines.
7800 (move_it_in_display_line_to): Record prev_method and prev_pos
7801 immediately before the call to set_iterator_to_next. Fixes cursor
7802 motion in bidi-reordered lines with stretch glyphs and strings
7803 displayed in margins. (Bug#8133) (Bug#8867)
7804 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7806 (pos_visible_p): Support positions in bidi-reordered lines.
7807 Save and restore bidi cache.
7809 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7810 (bidi_paragraph_info): Delete unused struct.
7811 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7812 (bidi_cache_start): New variable.
7813 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7815 (bidi_cache_fetch_state, bidi_cache_search)
7816 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7817 (bidi_cache_find, bidi_peek_at_next_level)
7818 (bidi_level_of_next_char, bidi_find_other_level_edge)
7819 (bidi_move_to_visually_next): Compare cache index with
7820 bidi_cache_start rather than with zero.
7821 (bidi_fetch_char): Accept new argument STRING; all callers
7822 changed. Support iteration over a string. Support strings with
7823 display properties. Support unibyte strings. Fix the type of
7824 `len' according to what STRING_CHAR_AND_LENGTH expects.
7825 (bidi_paragraph_init, bidi_resolve_explicit_1)
7826 (bidi_resolve_explicit, bidi_resolve_weak)
7827 (bidi_level_of_next_char, bidi_move_to_visually_next):
7828 Support iteration over a string.
7829 (bidi_set_sor_type, bidi_resolve_explicit_1)
7830 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7831 can now be zero (for strings); special values 0 and -1 were
7832 changed to -1 and -2, respectively.
7833 (bidi_char_at_pos): New function.
7834 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7835 Call it instead of FETCH_MULTIBYTE_CHAR.
7836 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7837 initialized to valid values.
7838 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7840 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7841 the test for valid cached positions. Fix the logic for looking up
7842 the sentinel state in the cache. GCPRO the Lisp string we are
7844 (bidi_push_it, bidi_pop_it): New functions.
7845 (bidi_initialize): Initialize the bidi cache start stack pointer.
7846 (bidi_cache_ensure_space): New function, refactored from part of
7847 bidi_cache_iterator_state. Don't assume the required size is just
7848 one BIDI_CACHE_CHUNK away.
7849 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7850 (bidi_count_bytes, bidi_char_at_pos): New functions.
7851 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7852 always valid if bidi_cache_idx is valid.
7853 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7854 is valid if it's going to be used.
7855 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7856 (bidi_cache_fetch_state, bidi_cache_search)
7857 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7858 (bidi_cache_iterator_state, bidi_cache_find)
7859 (bidi_find_other_level_edge, bidi_cache_start_stack):
7860 All variables related to cache indices are now EMACS_INT.
7862 * dispextern.h (struct bidi_string_data): New structure.
7863 (struct bidi_it): New member `string'. Make flag members be 1-bit
7864 fields, and put them last in the struct.
7865 (compute_display_string_pos, compute_display_string_end):
7867 (bidi_push_it, bidi_pop_it): Add prototypes.
7868 (struct iterator_stack_entry): New members bidi_p,
7869 paragraph_embedding, and from_disp_prop_p.
7870 (struct it): Member bidi_p is now a bit field 1 bit wide.
7871 (bidi_shelve_cache, bidi_unshelve_cache):
7874 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7875 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7876 and vector-like objects.
7878 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7879 cache around display iteration.
7881 * window.c (Fwindow_end, window_scroll_pixel_based)
7882 (displayed_window_lines, Frecenter): Save and restore the bidi
7883 cache around display iteration.
7885 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7887 * editfns.c (Fdelete_region): Clarify the use of the named
7888 parameters (bug#6788).
7890 2011-07-14 Martin Rudalics <rudalics@gmx.at>
7892 * indent.c (Fvertical_motion): Set and restore w->pointm when
7893 saving and restoring the window's buffer (Bug#9006).
7895 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7897 * editfns.c (Fstring_to_char): Clarify just what is returned
7898 (bug#6576). Text by Eli Zaretskii.
7900 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
7902 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7904 2011-07-13 Eli Zaretskii <eliz@gnu.org>
7906 * buffer.c (mmap_find): Fix a typo.
7908 2011-07-13 Johan Bockgård <bojohan@gnu.org>
7910 Fix execution of x selection hooks.
7911 * xselect.c (Qx_lost_selection_functions)
7912 (Qx_sent_selection_functions): New vars.
7913 (syms_of_xselect): DEFSYM them.
7914 (x_handle_selection_request): Pass Qx_sent_selection_functions
7915 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7916 (x_handle_selection_clear,x_clear_frame_selections):
7917 Pass Qx_lost_selection_functions rather than
7918 Vx_lost_selection_functions to Frun_hook_with_args.
7920 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7922 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
7923 The old code sometimes used this field without initializing it.
7925 * alloc.c (gc_sweep): Don't read past end of array.
7926 In theory, the old code could also have corrupted Emacs internals,
7927 though it'd be very unlikely.
7929 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7931 * character.c (Fcharacterp): Don't advertise optional ignored
7932 argument. (Bug#4026)
7934 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7936 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7939 * window.c (Fset_window_start): Doc fix (bug#4199).
7940 (Fset_window_hscroll): Ditto.
7942 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7944 Fix minor new problems caught by GCC 4.6.1.
7945 * term.c (init_tty): Remove unused local.
7946 * xsettings.c (store_monospaced_changed): Define this function only
7947 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
7950 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
7952 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7954 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7956 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7957 are the mini-buffer and the echo area (bug#3320).
7959 * term.c (init_tty): Remove support for supdup, c10 and perq
7960 terminals, which are no longer supported (bug#1482).
7962 2011-07-10 Johan Bockgård <bojohan@gnu.org>
7964 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7966 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7968 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7969 for non-popups (Bug#3642).
7971 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7973 * alloc.c (reset_malloc_hooks): Protoize.
7974 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
7975 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7976 * cm.c (losecursor): Likewise.
7977 * data.c (fmod): Likewise.
7978 * dispnew.c (swap_glyphs_in_rows): Likewise.
7979 * emacs.c (memory_warning_signal): Likewise.
7980 * floatfns.c (float_error): Likewise.
7981 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7982 (otf_open, font_otf_capability, generate_otf_features)
7983 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7985 * image.c (pbm_read_file): Likewise.
7986 * indent.c (string_display_width): Likewise.
7987 * intervals.c (check_for_interval, search_for_interval)
7988 (inc_interval_count, count_intervals, root_interval)
7989 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7990 * lread.c (defalias): Likewise.
7991 * ralloc.c (r_alloc_check): Likewise.
7992 * regex.c (set_image_of_range_1, set_image_of_range)
7993 (regex_grow_registers): Likewise.
7994 * sysdep.c (strerror): Likewise.
7995 * termcap.c (valid_filename_p, tprint, main): Likewise.
7996 * tparam.c (main): Likewise.
7997 * unexhp9k800.c (run_time_remap, save_data_space)
7998 (update_file_ptrs, read_header, write_header, calculate_checksum)
7999 (copy_file, copy_rest, display_header): Likewise.
8000 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8002 * xdisp.c (check_it): Likewise.
8003 * xfaces.c (register_color, unregister_color, unregister_colors):
8005 * xfns.c (print_fontset_result): Likewise.
8006 * xrdb.c (member, fatal, main): Likewise.
8008 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8010 Fix minor problems found by static checking (Bug#9031).
8011 * chartab.c (char_table_set_range, map_sub_char_table):
8012 Remove unused locals.
8013 (uniprop_table): Now static.
8014 * composite.c (_work_char): Remove unused static var.
8016 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
8018 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8020 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8022 * gtkutil.c (qttip_cb): Remove code without function.
8024 2011-07-09 Eli Zaretskii <eliz@gnu.org>
8026 * w32.c (pthread_sigmask): New stub.
8028 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
8030 Use pthread_sigmask, not sigprocmask (Bug#9010).
8031 sigprocmask is portable only for single-threaded applications, and
8032 Emacs can be multi-threaded when it uses GTK.
8033 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8035 * callproc.c (Fcall_process):
8036 * process.c (create_process):
8037 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8038 Use pthread_sigmask, not sigprocmask.
8040 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8042 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8043 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8046 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8048 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8049 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8050 (xg_hide_tooltip): Fix comment.
8052 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8053 in registerServicesMenuSendTypes.
8054 (validRequestorForSendType): Don't check ns_return_types.
8056 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8059 2011-07-08 Jason Rumney <jasonr@gnu.org>
8061 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8062 SH_SHOW for hidden windows (Bug#5482).
8064 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8065 frame struct members of non-existent frames (Bug#6284).
8067 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8069 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8070 variable firstTime not needed on OSX >= 10.6.
8071 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8072 >= 10.5. Use setKnobProportion, setDoubleValue.
8074 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8075 (MAC_OS_X_VERSION_10_5): Define if not defined.
8076 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8077 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8078 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8080 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
8081 cString and lossyCString on OSX >= 10.4.
8083 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
8084 sizeToFit on OSX >= 10.2.
8086 * nsimage.m (allocInitFromFile): Don't use deprecated method
8087 bestRepresentationForDevice on OSX >= 10.6.
8089 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8092 * emacs.c: Declare unexec_init_emacs_zone.
8094 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8096 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8098 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8099 on svcsMenu (Bug#8842).
8101 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8103 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8105 * nsterm.m (QUTF8_STRING): Declare.
8106 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8107 (validRequestorForSendType): Return type is (id).
8108 Change indexOfObjectIdenticalTo to indexOfObject.
8109 Check if we have local selection before returning self (Bug#8842).
8110 (writeSelectionToPasteboard): Put local selection into paste board
8111 if we have a local selection (Bug#8842).
8112 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8114 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8115 (ns_get_local_selection): Declare.
8117 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8119 * keymap.c (describe_map_tree): Don't insert a double newline at
8120 the end of the buffer (bug#1169) and return whether we inserted
8123 * callint.c (Fcall_interactively): Change "reading args" to
8124 "providing args" to try to clarify what it does (bug#1010).
8126 2011-07-07 Kenichi Handa <handa@m17n.org>
8128 * composite.c (composition_compute_stop_pos): Ignore a static
8129 composition starting before CHARPOS (Bug#8915).
8131 * xdisp.c (handle_composition_prop): Likewise.
8133 2011-07-07 Eli Zaretskii <eliz@gnu.org>
8135 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8138 2011-07-07 Kenichi Handa <handa@m17n.org>
8140 * character.h (unicode_category_t): New enum type.
8142 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8143 (Qchar_code_property_table): New variable.
8144 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8145 (UNIPROP_COMPRESSED_FORM_P): New macros.
8146 (char_table_ascii): Uncompress the compressed values.
8147 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8148 Uncompress the compressed values.
8149 (sub_char_table_ref_and_range): Likewise.
8150 (char_table_ref_and_range): Uncompress the compressed values.
8151 (sub_char_table_set): New arg is_uniprop. Callers changed.
8152 Uncompress the compressed values.
8153 (sub_char_table_set_range): Args changed. Callers changed.
8154 (char_table_set_range): Adjuted for the above change.
8155 (map_sub_char_table): Delete args default_val and parent. Add arg
8156 top. Give decoded values to a Lisp function.
8157 (map_char_table): Adjust for the above change. Give decoded
8158 values to a Lisp function. Gcpro more variables.
8159 (uniprop_table_uncompress)
8160 (uniprop_decode_value_run_length): New functions.
8161 (uniprop_decoder, uniprop_decoder_count): New variables.
8162 (uniprop_get_decoder, uniprop_encode_value_character)
8163 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8165 (uniprop_encoder, uniprop_encoder_count): New variables.
8166 (uniprop_get_encoder, uniprop_table)
8167 (Funicode_property_table_internal, Fget_unicode_property_internal)
8168 (Fput_unicode_property_internal): New functions.
8169 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8170 Sunicode_property_table_internal, Sget_unicode_property_internal,
8171 and Sput_unicode_property_internal. Defvar_lisp
8172 char-code-property-alist.
8174 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
8175 Vunicode_category_table.
8177 * font.c (font_range): Adjust for the change of
8178 Vunicode_category_table.
8180 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8182 * m/iris4d.h: Remove file, move contents ...
8183 * s/irix6-5.h: ... here.
8185 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8187 Remove unportable assumption about struct layout (Bug#8884).
8188 * alloc.c (mark_buffer):
8189 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8190 (clone_per_buffer_values): Don't assume that
8191 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8192 This isn't true in general, and it's particularly not true
8193 if Emacs is configured with --with-wide-int.
8194 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8195 New macros, used in the buffer.c change.
8197 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8199 * xsettings.c: Use both GConf and GSettings if both are available.
8200 (store_config_changed_event): Add comment.
8201 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8202 (store_tool_bar_style_changed): New functions.
8203 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
8204 (struct xsettings): Move font inside HAVE_XFT.
8205 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
8206 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
8207 Move inside HAVE_XFT.
8208 (something_changed_gsettingsCB): Rename from something_changedCB.
8209 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8211 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
8212 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
8213 (something_changed_gconfCB): Rename from something_changedCB.
8214 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8215 (parse_settings): Move check for font inside HAVE_XFT.
8216 (read_settings, apply_xft_settings): Add comment.
8217 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8218 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8219 call store_font_name_changed.
8220 (xft_settings_event): Add comment.
8221 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8222 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8223 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8224 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8225 (xsettings_initialize): Call init_gsettings last.
8226 (xsettings_get_system_font, xsettings_get_system_normal_font):
8229 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8231 Random fixes. E.g., (random) never returned negative values.
8232 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8233 subseconds part to the entropy, as that's a bit more random.
8234 Prefer signed to unsigned, since the signedness doesn't matter and
8235 in general we prefer signed. When given a limit, use a
8236 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8237 latter isn't right if USE_2_TAGS_FOR_INTS.
8238 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8239 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8241 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8243 * textprop.c (text_property_stickiness):
8244 Obey Vtext_property_default_nonsticky.
8245 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8246 * w32fns.c (syms_of_w32fns):
8247 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8249 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8251 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8252 This is more efficient than Ffile_directory_p and avoids a minor race.
8254 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8256 * buffer.c (Foverlay_put): Say what the return value is
8259 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8260 is a directory before asking whether to use the file name
8262 (barf_or_query_if_file_exists): Make the "File is a directory"
8263 error be more correct.
8265 * fns.c (Frequire): Remove the mention of the .gz files, since
8266 that's installation-specific, but keep the mention of
8267 `get-load-suffixes'.
8269 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8271 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8272 Report string overflow if the output is too long.
8274 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
8276 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8277 (syms_of_gnutls): Remove duplicate DEFSYM for
8278 Qgnutls_bootprop_verify_hostname_error, an error for
8279 Qgnutls_bootprop_verify_error (which is no longer used).
8281 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8282 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8283 Also (re)move comments that are misplaced or no longer relevant.
8285 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8287 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8289 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
8291 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8292 and background color parameters if they have been changed.
8294 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8296 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8298 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8300 * xsettings.c (SYSTEM_FONT): Define only when used.
8301 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8303 * keymap.c (access_keymap_1): Now static.
8305 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
8307 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8308 leave any prefix arg for the up event (Bug#1586).
8310 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8312 * lread.c (syms_of_lread): Mention single symbols defined by
8313 `defvar' or `defconst' (bug#7154).
8315 * fns.c (Frequire): Mention .el.gz files (bug#7314).
8316 (Frequire): Mention get-load-suffixes.
8318 2011-07-02 Martin Rudalics <rudalics@gmx.at>
8320 * window.h (window): Remove clone_number slot.
8321 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8323 (make_parent_window, make_window, saved_window)
8324 (Fset_window_configuration, save_window_save): Don't deal with
8326 * buffer.c (Qclone_number): Remove declaration.
8327 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8329 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8331 Add multiple inheritance to keymaps.
8332 * keymap.c (Fmake_composed_keymap): New function.
8333 (Fset_keymap_parent): Simplify.
8334 (fix_submap_inheritance): Remove.
8335 (access_keymap_1): New function extracted from access_keymap to handle
8336 embedded parents and handle lists of maps.
8337 (access_keymap): Use it.
8338 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8339 (Fcopy_keymap): Handle embedded parents.
8340 (Fcommand_remapping, define_as_prefix): Simplify.
8341 (Fkey_binding): Simplify.
8342 (syms_of_keymap): Move minibuffer-local-completion-map,
8343 minibuffer-local-filename-completion-map,
8344 minibuffer-local-must-match-map, and
8345 minibuffer-local-filename-must-match-map to Elisp.
8346 (syms_of_keymap): Defsubr make-composed-keymap.
8347 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8348 (parse_menu_item): Trivial simplification.
8350 2011-07-01 Glenn Morris <rgm@gnu.org>
8352 * Makefile.in (SETTINGS_LIBS): Fix typo.
8354 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8356 * coding.c (Fencode_coding_string): Record the last coding system
8357 used, as the function doc string says (bug#8738).
8359 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8361 * xsettings.c (store_monospaced_changed): Take new font as arg and
8362 check for change against current_mono_font.
8363 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8364 (emacs_settings_constructor, emacs_settings_get_property)
8365 (emacs_settings_set_property, emacs_settings_class_init)
8366 (emacs_settings_init, gsettings_obj): Remove.
8367 (something_changedCB): New function for HAVE_GSETTINGS.
8368 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8369 with value as argument.
8370 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8371 g_settings_new (Bug#8967). Do not create gsettings_obj.
8372 Remove calls to g_settings_bind. Connect something_changedCB to
8375 * xgselect.c: Add defined (HAVE_GSETTINGS).
8376 (xgselect_initialize): Ditto.
8378 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8379 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8382 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8384 * eval.c (struct backtrace): Simplify and port the data structure.
8385 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8386 signed bit field, as this assumption is not portable and it makes
8387 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8388 "char debug_on_exit : 1" as this is not portable either; instead,
8389 use the portable "unsigned int debug_on_exit : 1". Remove unused
8390 member evalargs. Remove obsolete comments about cc bombing out.
8392 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8394 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
8395 Let HAVE_GSETTINGS override HAVE_GCONF.
8396 (store_monospaced_changed): New function.
8397 (EMACS_SETTINGS): A new type derived from GObject to handle
8398 GSettings notifications.
8399 (emacs_settings_constructor, emacs_settings_get_property)
8400 (emacs_settings_set_property, emacs_settings_class_init):
8402 (gsettings_client, gsettings_obj): New variables.
8403 (GSETTINGS_SCHEMA): New define.
8404 (something_changedCB): Call store_monospaced_changed.
8405 (init_gsettings): New function.
8406 (xsettings_initialize): Call init_gsettings.
8407 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8410 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
8413 2011-06-29 Martin Rudalics <rudalics@gmx.at>
8415 * window.c (resize_root_window, grow_mini_window)
8416 (shrink_mini_window): Rename Qresize_root_window to
8417 Qwindow_resize_root_window and Qresize_root_window_vertically to
8418 Qwindow_resize_root_window_vertically.
8420 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8422 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8424 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
8426 * makefile.w32-in: Redesign dependencies so they reflect more
8427 clearly which files are directly included by each source file,
8428 and not through other includes.
8430 2011-06-27 Martin Rudalics <rudalics@gmx.at>
8432 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8433 (sort_overlays, overlay_strings): When an overlay's clone number
8434 matches the window's clone number process the overlay even if
8435 the overlay's window property doesn't match the current window.
8437 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8438 (Fwindow_hchild): Rename to Fwindow_left_child.
8439 (Fwindow_next): Rename to Fwindow_next_sibling.
8440 (Fwindow_prev): Rename to Fwindow_prev_sibling.
8441 (resize_window_check): Rename to window_resize_check.
8442 (resize_window_apply): Rename to window_resize_apply.
8443 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8444 (Fdelete_other_windows_internal, resize_frame_windows)
8445 (Fsplit_window_internal, Fdelete_window_internal)
8446 (grow_mini_window, shrink_mini_window)
8447 (Fresize_mini_window_internal): Fix callers accordingly.
8449 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8451 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8452 (emacs_fixed_set_min_size): Remove.
8453 (emacs_fixed_new): Take frame as argument.
8455 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8456 (_EmacsFixedPrivate): Remove minwidth/height.
8457 Add struct frame *f.
8458 (emacs_fixed_init): Initialize priv->f.
8459 (get_parent_class, emacs_fixed_set_min_size): Remove.
8460 (emacs_fixed_new): Set priv->f to argument.
8461 (emacs_fixed_get_preferred_width)
8462 (emacs_fixed_get_preferred_height): Use min_width/height from
8463 frames size_hint to set minimum and natural (Bug#8919).
8464 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8465 and use min_width/height from frames size_hint to set
8466 min_width/height (Bug#8919).
8468 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
8469 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8472 2011-06-26 Eli Zaretskii <eliz@gnu.org>
8474 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8475 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8478 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
8480 * process.c (wait_reading_process_output): Bypass select if
8481 waiting for a cell while ignoring keyboard input, and input is
8482 pending. Suggested by Jan Djärv (Bug#8869).
8484 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8486 Use gnulib's dup2 module instead of rolling our own.
8487 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8489 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8491 * dispnew.c (scrolling_window): Before scrolling, turn off a
8492 mouse-highlight in the window being scrolled.
8494 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
8496 Move DEFSYM to lisp.h and use everywhere.
8498 * character.h (DEFSYM): Move declaration...
8499 * lisp.h (DEFSYM): ...here.
8505 * w32select.c: Don't include character.h.
8507 * alloc.c (syms_of_alloc):
8508 * buffer.c (syms_of_buffer):
8509 * bytecode.c (syms_of_bytecode):
8510 * callint.c (syms_of_callint):
8511 * casefiddle.c (syms_of_casefiddle):
8512 * casetab.c (init_casetab_once):
8513 * category.c (init_category_once, syms_of_category):
8514 * ccl.c (syms_of_ccl):
8515 * cmds.c (syms_of_cmds):
8516 * composite.c (syms_of_composite):
8517 * dbusbind.c (syms_of_dbusbind):
8518 * dired.c (syms_of_dired):
8519 * dispnew.c (syms_of_display):
8520 * doc.c (syms_of_doc):
8521 * editfns.c (syms_of_editfns):
8522 * emacs.c (syms_of_emacs):
8523 * eval.c (syms_of_eval):
8524 * fileio.c (syms_of_fileio):
8525 * fns.c (syms_of_fns):
8526 * frame.c (syms_of_frame):
8527 * fringe.c (syms_of_fringe):
8528 * insdel.c (syms_of_insdel):
8529 * keymap.c (syms_of_keymap):
8530 * lread.c (init_obarray, syms_of_lread):
8531 * macros.c (syms_of_macros):
8532 * msdos.c (syms_of_msdos):
8533 * print.c (syms_of_print):
8534 * process.c (syms_of_process):
8535 * search.c (syms_of_search):
8536 * sound.c (syms_of_sound):
8537 * syntax.c (init_syntax_once, syms_of_syntax):
8538 * terminal.c (syms_of_terminal):
8539 * textprop.c (syms_of_textprop):
8540 * undo.c (syms_of_undo):
8541 * w32.c (globals_of_w32):
8542 * window.c (syms_of_window):
8543 * xdisp.c (syms_of_xdisp):
8544 * xfaces.c (syms_of_xfaces):
8545 * xfns.c (syms_of_xfns):
8546 * xmenu.c (syms_of_xmenu):
8547 * xsettings.c (syms_of_xsettings):
8548 * xterm.c (syms_of_xterm): Use DEFSYM.
8550 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8552 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
8554 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8556 Integer and buffer overflow fixes (Bug#8873).
8558 * print.c (printchar, strout): Check for string overflow.
8559 (PRINTPREPARE, printchar, strout):
8560 Don't set size unless allocation succeeds.
8562 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8563 for sizes. Check for string overflow more accurately.
8564 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8566 * macros.c: Integer and buffer overflow fixes.
8567 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8568 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8569 Use ptrdiff_t, not int, for sizes.
8570 Don't increment bufsize until after realloc succeeds.
8571 Check for size-calculation overflow.
8572 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8574 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8576 * lread.c: Integer overflow fixes.
8577 (read_integer): Radix is now EMACS_INT, not int,
8578 to improve quality of diagnostics for out-of-range radices.
8579 Calculate buffer size correctly for out-of-range radices.
8580 (read1): Check for integer overflow in radices, and in
8581 read-circle numbers.
8582 (read_escape): Avoid int overflow.
8583 (Fload, openp, read_buffer_size, read1)
8584 (substitute_object_recurse, read_vector, read_list, map_obarray):
8585 Use ptrdiff_t, not int, for sizes.
8586 (read1): Use EMACS_INT, not int, for sizes.
8587 Check for size overflow.
8589 * image.c (cache_image): Check for size arithmetic overflow.
8591 * lread.c: Integer overflow issues.
8592 (saved_doc_string_size, saved_doc_string_length)
8593 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8594 Now ptrdiff_t, not int.
8595 (read1): Don't assume doc string length fits in int. Check for
8596 out-of-range doc string lengths.
8597 (read_list): Don't assume file position fits in int.
8598 (read_escape): Check for hex character overflow.
8600 2011-06-22 Leo Liu <sdl.web@gmail.com>
8602 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8603 Move to minibuffer.el.
8605 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8607 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
8608 The following patches are for when GLYPH_DEBUG && !XASSERT.
8609 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8610 * dispnew.c (flush_stdout):
8611 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8612 Mark as externally visible.
8613 * dispnew.c (check_window_matrix_pointers): Now static.
8614 * dispnew.c (window_to_frame_vpos):
8615 * xfns.c (unwind_create_frame):
8616 * xterm.c (x_check_font): Remove unused local.
8617 * scroll.c (CHECK_BOUNDS):
8618 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8619 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8620 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8621 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8622 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8624 (debug_method_add): Use va_list and vsprintf rather than relying
8625 on undefined behavior with wrong number of arguments.
8626 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8627 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8628 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8629 since we're not interested in debugging glyphs with old libraries.
8630 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8631 GCC 4.6.0's static checking.
8633 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8635 Integer overflow and signedness fixes (Bug#8873).
8636 A few related buffer overrun fixes, too.
8638 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8640 * dispextern.h (struct face.stipple):
8641 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8642 (x_bitmap_mask, x_allocate_bitmap_record)
8643 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8644 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8645 (x_create_bitmap_from_xpm_data):
8646 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8647 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8649 * xfaces.c (load_pixmap):
8650 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8651 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8652 (.bitmaps_last, struct x_output.icon_bitmap):
8653 Use ptrdiff_t, not int, for bitmap indexes.
8654 (x_allocate_bitmap_record): Check for size overflow.
8655 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8657 Use ptrdiff_t, not int, for overlay counts.
8658 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8659 * editfns.c (overlays_around, get_pos_property):
8660 * textprop.c (get_char_property_and_overlay):
8661 * xdisp.c (next_overlay_change, note_mouse_highlight):
8662 * xfaces.c (face_at_buffer_position):
8663 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8664 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8665 (Fnext_overlay_change, Fprevious_overlay_change)
8666 (mouse_face_overlay_overlaps, Foverlays_in):
8667 Use ptrdiff_t, not int, for sizes.
8668 (overlays_at, overlays_in): Check for size-calculation overflow.
8670 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8672 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8673 (x_session_initialize): Do not assume string length fits in int.
8675 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8676 This is unlikely, but can occur if DPI is outlandish.
8678 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
8679 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8681 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8682 * xrdb.c (magic_file_p, search_magic_path):
8683 Omit last arg SUFFIX; it was always 0. All callers changed.
8684 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8686 * xfont.c (xfont_match): Avoid need for strlen.
8688 * xfns.c: Don't assume strlen fits in int.
8689 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8691 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8692 not unsigned long, as we prefer signed integers. All callers changed.
8693 Detect integer overflow in repeat count.
8694 (message_dolog): Don't assume print length fits in 39 bytes.
8695 (display_mode_element): Don't assume strlen fits in int.
8697 * termcap.c: Don't assume sizes fit in int and never overflow.
8698 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8699 (gobble_line): Check for size-calculation overflow.
8701 * minibuf.c (Fread_buffer):
8702 * lread.c (intern, intern_c_string):
8703 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8704 Don't assume string length fits in int.
8706 * keyboard.c (parse_tool_bar_item):
8707 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8709 * font.c: Don't assume string length fits in int.
8710 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8711 Use ptrdiff_t, not int.
8712 (font_intern_prop): Don't assume string length fits in int.
8713 Don't assume integer property fits in fixnum.
8714 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
8716 * filelock.c: Fix some buffer overrun and integer overflow issues.
8717 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
8718 Reformulate so as not to need the command string.
8719 Invoke gzip -cd rather than gunzip, as it's more portable.
8720 (lock_info_type, lock_file_1, lock_file):
8721 Don't assume pid_t and time_t fit in unsigned long.
8722 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8723 (current_lock_owner): Prefer signed type for sizes.
8724 Use memcpy, not strncpy, where memcpy is what is really wanted.
8725 Don't assume (via atoi) that time_t and pid_t fit in int.
8726 Check for time_t and/or pid_t out of range, e.g., via a network share.
8727 Don't alloca where an auto var works fine.
8729 * fileio.c: Fix some integer overflow issues.
8730 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8731 Don't assume string length fits in int.
8732 (directory_file_name): Don't assume string length fits in long.
8733 (make_temp_name): Don't assume pid fits in int, or that its print
8734 length is less than 20.
8736 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8738 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8740 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8742 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8743 We prefer signed integers, even for size calculations.
8745 * emacs.c: Don't assume string length fits in 'int'.
8746 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8747 (main): Don't invoke strlen when not needed.
8749 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8750 (XD_DEBUG_MESSAGE): Don't waste a byte.
8752 * callproc.c (getenv_internal_1, getenv_internal)
8754 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8756 * lread.c (invalid_syntax): Omit length argument.
8757 All uses changed. This doesn't fix a bug, but it simplifies the
8758 code away from its former Hollerith-constant appearance, and it's
8759 one less 'int' to worry about when looking at integer-overflow issues.
8760 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
8762 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8763 This didn't break anything, but it didn't help either.
8764 It's confusing to put a bogus integer in a place where the actual
8765 value does not matter.
8766 (LIST_END_P): Remove unused macro and its bogus comment.
8767 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
8769 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8770 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8772 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8773 We prefer signed types, and the value cannot exceed the EMACS_INT
8774 range anyway (because otherwise the length would not be representable).
8775 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8776 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8777 This avoids a GCC warning when WIDE_EMACS_INT.
8779 * indent.c (sane_tab_width): New function.
8780 (current_column, scan_for_column, Findent_to, position_indentation)
8781 (compute_motion): Use it. This is just for clarity.
8782 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
8784 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
8786 * lisp.h (lint_assume): New macro.
8787 * composite.c (composition_gstring_put_cache):
8788 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8790 * editfns.c, insdel.c:
8791 Omit unnecessary forward decls, to simplify future changes.
8793 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8795 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8797 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
8798 Use much-faster test for byte-length change.
8799 Don't assume string byte-length fits in 'int'.
8800 Check that character arg fits in 'int'.
8801 (mapcar1): Declare byte as byte, for clarity.
8803 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8805 * fns.c (concat): Catch string overflow earlier.
8806 Do not rely on integer wraparound.
8808 * dispextern.h (struct it.overlay_strings_charpos)
8809 (struct it.selective): Now EMACS_INT, not int.
8810 * xdisp.c (forward_to_next_line_start)
8811 (back_to_previous_visible_line_start)
8812 (reseat_at_next_visible_line_start, next_element_from_buffer):
8813 Don't arbitrarily truncate the value of 'selective' to int.
8815 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8817 * composite.c: Don't truncate sizes to 'int'.
8818 (composition_gstring_p, composition_reseat_it)
8819 (composition_adjust_point): Use EMACS_INT, not int.
8820 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8821 not EMACS_UINT, for indexes.
8823 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8825 * buffer.c: Include <verify.h>.
8826 (struct sortvec.priority, struct sortstr.priority):
8827 Now EMACS_INT, not int.
8828 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
8829 (struct sortstr.size, record_overlay_string)
8830 (struct sortstrlist.size, struct sortlist.used):
8831 Don't truncate size to int.
8832 (record_overlay_string): Check for size-calculation overflow.
8833 (init_buffer_once): Check at compile-time, not run-time.
8835 2011-06-22 Jim Meyering <meyering@redhat.com>
8837 Don't leak an XBM-image-sized buffer
8838 * image.c (xbm_load): Free the image buffer after using it.
8840 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8843 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8844 that Sun C diagnosed.
8845 * fns.c (secure_hash): Fix pointer signedness issue.
8846 * intervals.c (static_offset_intervals): New function.
8847 (offset_intervals): Use it.
8849 2011-06-21 Leo Liu <sdl.web@gmail.com>
8852 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8855 * fns.c (secure_hash): Rename from crypto_hash_function and change
8856 the first arg to accept symbols.
8857 (Fsecure_hash): New primitive.
8858 (syms_of_fns): New symbols.
8860 2011-06-20 Deniz Dogan <deniz@dogan.se>
8862 * process.c (Fset_process_buffer): Clarify return value in
8865 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
8867 * dispnew.c (add_window_display_history): Use BVAR.
8869 * xdisp.c (debug_method_add): Use BVAR.
8870 (check_window_end, dump_glyph_matrix, dump_glyph)
8871 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8873 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8876 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8877 check till after the cache is created in init_frame_faces.
8879 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8881 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8883 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8885 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8886 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8887 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8889 Improve buffer-overflow checking (Bug#8873).
8890 * fileio.c (Finsert_file_contents):
8891 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8892 Remove the old (too-loose) buffer overflow checks.
8893 They weren't needed, since make_gap checks for buffer overflow.
8894 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8895 The old code merely checked for Emacs fixnum overflow, and relied
8896 on undefined (wraparound) behavior. The new code avoids undefined
8897 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8899 * editfns.c (Finsert_char): Don't dump core with very negative counts.
8900 Tune. Don't use wider integers than needed. Don't use alloca.
8901 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
8903 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8905 * insdel.c, lisp.h (buffer_overflow): New function.
8906 (insert_from_buffer_1, replace_range, replace_range_2):
8907 * insdel.c (make_gap_larger):
8908 * editfns.c (Finsert_char):
8909 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8911 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8913 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8915 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
8917 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8918 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8920 * fileio.c: Don't assume EMACS_INT fits in off_t.
8921 (emacs_lseek): New static function.
8922 (Finsert_file_contents, Fwrite_region): Use it.
8923 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8925 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8927 * fns.c: Don't overflow int when computing a list length.
8928 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8929 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8930 truncation on 64-bit hosts. Check for QUIT every
8931 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8932 faster and is responsive enough.
8933 (Flength): Report an error instead of overflowing an integer.
8934 (Fsafe_length): Return a float if the value is not representable
8935 as a fixnum. This shouldn't happen except in contrived situations.
8936 (Fnthcdr, Fsort): Don't assume list length fits in int.
8937 (Fcopy_sequence): Don't assume vector length fits in int.
8939 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8940 (header_size, word_size): New constants.
8941 (allocate_vectorlike): Don't check size overflow here.
8942 (allocate_vector): Check it here instead, since this is the only
8943 caller of allocate_vectorlike that could cause overflow.
8944 Check that the new vector's length is representable as a fixnum.
8946 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8947 The previous code was bogus. For example, next_almost_prime (32)
8948 returned 39, which is undesirable as it is a multiple of 3; and
8949 next_almost_prime (24) returned 25, which is a multiple of 5 so
8950 why was the code bothering to check for multiples of 7?
8952 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8954 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8956 Variadic C functions now count arguments with ptrdiff_t.
8957 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8958 Back then I didn't know that the Emacs coding style prefers signed int.
8959 Also, in the meantime I found a few more instances where arguments
8960 were being counted with int, which may truncate counts on 64-bit
8961 machines, or EMACS_INT, which may be unnecessarily wide.
8962 * lisp.h (struct Lisp_Subr.function.aMANY)
8963 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8964 Arg counts are now ptrdiff_t, not size_t.
8965 All variadic functions and their callers changed accordingly.
8966 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8967 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8968 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8969 * callint.c (Fcall_interactively): Check arg count for overflow,
8970 to avoid potential buffer overrun. Use signed char, not 'int',
8971 for 'varies' array, so that we needn't bother to check its size
8972 calculation for overflow.
8973 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8974 * eval.c (apply_lambda):
8975 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8976 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8977 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8979 * callint.c (Fcall_interactively): Don't use index var as event count.
8981 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8982 * mem-limits.h (SIZE): Remove; no longer used.
8984 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
8986 Remove unnecessary casts.
8987 * xterm.c (x_term_init):
8988 * xfns.c (x_set_border_pixel):
8989 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8990 These aren't needed now that we assume ANSI C.
8992 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8993 It's more likely to cause problems (due to unsigned overflow)
8996 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8998 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9000 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9002 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9004 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9006 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9008 GLYPH_CODE_FACE returns EMACS_INT, not int.
9009 * dispextern.h (merge_faces):
9010 * xfaces.c (merge_faces):
9011 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9012 Don't assume EMACS_INT fits in int.
9014 * character.h (CHAR_VALID_P): Remove unused parameter.
9015 * fontset.c, lisp.h, xdisp.c: All uses changed.
9017 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9019 * fns.c (concat): Minor tuning based on overflow analysis.
9020 This doesn't fix any bugs. Use int to hold character, instead
9021 of constantly refetching from Emacs object. Use XFASTINT, not
9022 XINT, for value known to be a character. Don't bother comparing
9023 a single byte to 0400, as it's always less.
9025 * floatfns.c (Fexpt):
9026 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9028 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9031 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9033 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9034 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9035 incorrectly succeed when S was a string, because 4294967386 was
9036 truncated before it was used.
9038 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9039 Otherwise, an out-of-range integer could cause undefined behavior
9042 * composite.c: Use int, not EMACS_INT, for characters.
9043 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9044 EMACS_INT, for values that are known to be in character range.
9045 This doesn't fix any bugs but is the usual style inside Emacs and
9046 may generate better code on 32-bit machines.
9048 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9049 This is for reasons similar to the recent CHAR_STRING fix.
9050 * charset.c (Fencode_char): Check that character arg is actually
9051 a character. Pass an int to ENCODE_CHAR.
9052 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9053 wider than 'int', as a compile-time check to prevent future regressions
9056 * character.c (char_string): Remove unnecessary casts.
9058 Make sure a 64-bit char is never passed to CHAR_STRING.
9059 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9060 by silently ignoring the top 32 bits, allowing some values
9061 that were far too large to be valid characters.
9062 * character.h: Include <verify.h>.
9063 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9064 arguments are no wider than unsigned, as a compile-time check
9065 to prevent future regressions in this area.
9067 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
9068 (Fsubst_char_in_region):
9070 * xdisp.c (decode_mode_spec_coding):
9071 Adjust to CHAR_STRING's new requirement.
9072 * editfns.c (Finsert_char, Fsubst_char_in_region):
9073 * fns.c (concat): Check that character args are actually
9074 characters. Without this test, these functions did the wrong
9075 thing with wildly out-of-range values on 64-bit hosts.
9077 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9078 These casts should not be needed on 32-bit hosts, either.
9079 * keyboard.c (read_char):
9080 * lread.c (Fload): Remove casts to unsigned.
9082 * lisp.h (UNSIGNED_CMP): New macro.
9083 This fixes comparison bugs on 64-bit hosts.
9084 (ASCII_CHAR_P): Use it.
9085 * casefiddle.c (casify_object):
9086 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
9087 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9088 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9089 * dispextern.h (FACE_FROM_ID):
9090 * keyboard.c (read_char): Use UNSIGNED_CMP.
9092 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9093 not to EMACS_INT, to avoid GCC warning.
9095 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9097 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9098 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9099 isn't needed on 32-bit machines.
9101 * buffer.c (Fgenerate_new_buffer_name):
9102 Use EMACS_INT for count, not int.
9103 (advance_to_char_boundary): Return EMACS_INT, not int.
9105 * data.c (Qcompiled_function): Now static.
9107 * window.c (window_body_lines): Now static.
9109 * image.c (gif_load): Rename local to avoid shadowing.
9111 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9112 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9113 * alloc.c (make_save_value): Integer argument is now of type
9115 (mark_object): Use ptrdiff_t, not int.
9116 * lisp.h (pD): New macro.
9117 * print.c (print_object): Use it.
9119 * alloc.c: Use EMACS_INT, not int, to count objects.
9120 (total_conses, total_markers, total_symbols, total_vector_size)
9121 (total_free_conses, total_free_markers, total_free_symbols)
9122 (total_free_floats, total_floats, total_free_intervals)
9123 (total_intervals, total_strings, total_free_strings):
9124 Now EMACS_INT, not int. All uses changed.
9125 (Fgarbage_collect): Compute overall total using a double, so that
9126 integer overflow is less likely to be a problem. Check for overflow
9127 when converting back to an integer.
9128 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9129 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9130 These were 'int' variables that could overflow on 64-bit hosts;
9131 they were never used, so remove them instead of repairing them.
9132 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
9133 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9134 Previously, this ceilinged at INT_MAX, but that doesn't work on
9136 (allocate_pseudovector): Don't use EMACS_INT when int would do.
9138 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
9139 (allocate_vectorlike): Check for ptrdiff_t overflow.
9140 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9141 when a (possibly-narrower) signed value would do just as well.
9142 We prefer using signed arithmetic, to avoid comparison confusion.
9144 * alloc.c: Catch some string size overflows that we were missing.
9145 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9146 for convenience in STRING_BYTES_MAX.
9147 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9148 The definition here is exact; the one in lisp.h was approximate.
9149 (allocate_string_data): Check for string overflow. This catches
9150 some instances we weren't catching before. Also, it catches
9151 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9152 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9153 and ptrdiff_t and EMACS_INT are both 64 bits.
9155 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9156 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
9157 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
9159 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9161 * alloc.c (Fmake_string): Check for out-of-range init.
9163 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9165 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9167 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9169 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9170 xg_get_default_scrollbar_width.
9172 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9173 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9174 (style_changed_cb): Call update_theme_scrollbar_width and call
9175 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9176 all frames (Bug#8505).
9177 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9178 Call gtk_window_set_resizable if HAVE_GTK3.
9179 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9180 and height if HAVE_GTK3 (Bug#8505).
9181 (scroll_bar_width_for_theme): New variable.
9182 (update_theme_scrollbar_width): New function.
9183 (xg_get_default_scrollbar_width): Move code to
9184 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9185 (xg_initialize): Call update_theme_scrollbar_width.
9187 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9189 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9191 2011-06-12 Martin Rudalics <rudalics@gmx.at>
9193 * frame.c (make_frame): Call other_buffer_safely instead of
9196 * window.c (temp_output_buffer_show): Call display_buffer with
9197 second argument Vtemp_buffer_show_specifiers and reset latter
9198 immediately after the call.
9199 (Vtemp_buffer_show_specifiers): New variable.
9200 (auto_window_vscroll_p, next_screen_context_lines)
9201 (Vscroll_preserve_screen_position): Remove leading asterisks from
9204 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
9206 Fix minor problems found by GCC 4.6.0 static checking.
9207 * buffer.c (Qclone_number): Remove for now, as it's unused.
9208 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9209 (record_buffer): Remove unused local.
9210 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9211 (set_frame_buffer_list): Remove; unused.
9212 * frame.h (other_visible_frames): Remove decl.
9213 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9214 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9215 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9217 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9218 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9219 Define only if HAVE_GPM.
9220 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9221 (update_hints_inhibit): Remove; never set. All uses removed.
9222 * widgetprv.h (emacsFrameClassRec): Remove decl.
9223 * window.c (delete_deletable_window): Now returns void, since it
9224 wasn't returning anything.
9225 (compare_window_configurations): Remove unused locals.
9226 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9227 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
9228 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9229 the same widths as pointers. This follows up on the 2011-05-06 patch.
9230 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9231 * xterm.h: Likewise.
9232 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9234 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
9236 * makefile.w32-in: Update dependencies.
9237 (LISP_H): Add lib/intprops.h.
9239 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
9241 * image.c (gif_load): Add animation frame delay to the metadata.
9242 (syms_of_image): Use DEFSYM. New symbol `delay'.
9244 2011-06-11 Martin Rudalics <rudalics@gmx.at>
9246 * window.c (delete_deletable_window): Re-add.
9247 (Fset_window_configuration): Rewrite to handle dead buffers and
9248 consequently deletable windows.
9249 (window_tree, Fwindow_tree): Remove. Supply functionality in
9251 (compare_window_configurations): Simplify code.
9253 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9255 * image.c (imagemagick_load_image): Fix type mismatch.
9256 (Fimagemagick_types): Likewise.
9258 * window.h (replace_buffer_in_windows): Declare.
9260 2011-06-11 Martin Rudalics <rudalics@gmx.at>
9262 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9263 Qclone_number. Remove external declaration of Qdelete_window.
9264 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9266 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9267 Run Qbuffer_list_update_hook if allowed.
9268 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9269 buffer list implementation.
9270 (other_buffer_safely): New function.
9271 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9272 calls to replace_buffer_in_windows and
9273 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9275 (record_buffer): Inhibit quitting and rewrite using quittable
9276 functions. Run Qbuffer_list_update_hook if allowed.
9277 (Frecord_buffer, Funrecord_buffer): New functions.
9278 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9279 Move switch-to-buffer to window.el.
9280 (bury-buffer): Move to window.el.
9281 (Vbuffer_list_update_hook): New variable.
9283 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9286 * window.h (resize_frame_windows): Move up in code.
9287 (Fwindow_frame): Remove EXFUN.
9288 (replace_buffer_in_all_windows): Remove prototype.
9289 (replace_buffer_in_windows_safely): Add prototype.
9291 * window.c: Declare Qdelete_window static again. Move down
9292 declaration of select_count.
9293 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9294 (Fother_window): Move to window.el.
9295 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9296 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9297 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9299 (replace_buffer_in_windows): Implement by calling
9300 Qreplace_buffer_in_windows.
9301 (replace_buffer_in_all_windows): Remove with some functionality
9302 moved into replace_buffer_in_windows_safely.
9303 (replace_buffer_in_windows_safely): New function.
9304 (select_window_norecord, select_frame_norecord): Move in front
9305 of run_window_configuration_change_hook. Remove now obsolete
9307 (Fset_window_buffer): Rewrite doc-string.
9308 Call Qrecord_window_buffer.
9309 (keys_of_window): Move binding for other-window to window.el.
9311 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
9313 * dispextern.h (struct image): Replace data member, whose int_val
9314 and ptr_val fields were not used by anything, with a single
9317 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9318 (gif_clear_image, gif_load, imagemagick_load_image)
9319 (gs_clear_image, gs_load): Callers changed.
9321 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9323 * buffer.h: Include <time.h>, for time_t.
9324 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9326 Fix minor problems found by static checking.
9328 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9330 Make identifiers static if they are not used in other modules.
9331 * data.c (Qcompiled_function, Qframe, Qvector):
9332 * image.c (QimageMagick, Qsvg):
9333 * minibuf.c (Qmetadata):
9334 * window.c (resize_window_check, resize_root_window): Now static.
9335 * window.h (resize_window_check, resize_root_window): Remove decls.
9337 * window.c (window_deletion_count, delete_deletable_window):
9339 (window_body_lines): Now static.
9340 (Fdelete_other_windows_internal): Mark vars as initialized.
9341 Make sure 'resize_failed' is initialized.
9342 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9343 (resize_window_apply): Remove unused local.
9344 * window.h (delete_deletable_window): Remove decl.
9346 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
9347 (imagemagick_load_image): Fix pointer signedness problem by changing
9348 last arg from unsigned char * to char *. All uses changed.
9349 Also, fix a local for similar reasons.
9350 Remove unused locals. Remove locals to avoid shadowing.
9351 (fn_rsvg_handle_free): Remove; unused.
9352 (svg_load, svg_load_image): Fix pointer signedness problem.
9353 (imagemagick_load_image): Don't use garbage pointer image_wand.
9355 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9357 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
9359 * image.c (gif_load): Fix omitted cast error introduced by
9362 2011-06-10 Martin Rudalics <rudalics@gmx.at>
9364 * window.h (resize_proportionally, orig_total_lines)
9365 (orig_top_line): Remove from window structure.
9366 (set_window_height, set_window_width, change_window_heights)
9367 (Fdelete_window): Remove prototypes.
9368 (resize_frame_windows): Remove duplicate declaration.
9370 2011-06-10 Eli Zaretskii <eliz@gnu.org>
9372 * window.h (resize_frame_windows, resize_window_check)
9373 (delete_deletable_window, resize_root_window)
9374 (resize_frame_windows): Declare prototypes.
9376 * window.c (resize_window_apply): Make definition be "static" to
9377 match the prototype.
9379 2011-06-10 Martin Rudalics <rudalics@gmx.at>
9381 * window.c: Remove declarations of Qwindow_size_fixed,
9382 window_min_size_1, window_min_size_2, window_min_size,
9383 size_window, window_fixed_size_p, enlarge_window, delete_window.
9384 Remove static from declaration of Qdelete_window, it's
9385 temporarily needed by Fbury_buffer.
9386 (replace_window): Don't assign orig_top_line and
9388 (Fdelete_window, delete_window): Remove. Window deletion is
9389 handled by window.el.
9390 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9391 Replace Fdelete_window calls with calls to Qdelete_window.
9392 (Fdelete_other_windows): Remove. Deleting other windows is
9393 handled by window.el.
9394 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9395 handled in window.el.
9396 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9397 Window minimum sizes are handled in window.el.
9398 (shrink_windows, size_window, set_window_height)
9399 (set_window_width, change_window_heights, window_height)
9400 (window_width, CURBEG, CURSIZE, enlarge_window)
9401 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9402 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9403 handled in window.el.
9404 (make_dummy_parent): Rename to make_parent_window and give it a
9405 second argument horflag.
9406 (make_window): Don't set resize_proportionally any more.
9407 (Fsplit_window): Remove. Windows are split in window.el.
9408 (save_restore_action, save_restore_orig_size)
9409 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9410 Resize mini windows in window.el.
9411 (grow_mini_window, shrink_mini_window): Implement by calling
9412 Qresize_root_window_vertically, resize_window_check and
9413 resize_window_apply.
9414 (saved_window, Fset_window_configuration, save_window_save):
9415 Do not handle orig_top_line, orig_total_lines, and
9416 resize_proportionally.
9417 (window_min_height, window_min_width): Move to window.el.
9418 (keys_of_window): Move bindings for delete-other-windows,
9419 split-window, delete-window and enlarge-window to window.el.
9421 * buffer.c: Temporarily extern Qdelete_window.
9422 (Fbury_buffer): Temporarily call Qdelete_window instead of
9423 Fdelete_window (Fbury_buffer will move to window.el soon).
9425 * frame.c (set_menu_bar_lines_1): Remove code handling
9426 orig_top_line and orig_total_lines.
9428 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9429 set_window_height but set heights directly.
9430 (change_frame_size_1): Use resize_frame_windows.
9432 * xdisp.c (init_xdisp): Don't use set_window_height but set
9435 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9436 Use resize_frame_windows instead of change_window_heights and run
9437 run_window_configuration_change_hook.
9439 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9440 instead of change_window_heights and run
9441 run_window_configuration_change_hook.
9443 2011-06-09 Martin Rudalics <rudalics@gmx.at>
9445 * window.c (replace_window): Rename second argument REPLACEMENT to
9446 NEW. New third argument SETFLAG. Rewrite.
9447 (delete_window, make_dummy_parent): Call replace_window with
9449 (window_list_1): Move down in code.
9450 (run_window_configuration_change_hook): Move set_buffer part
9451 before select_frame_norecord part in order to unwind correctly.
9452 Rename count1 to count.
9453 (recombine_windows, delete_deletable_window, resize_root_window)
9454 (Fdelete_other_windows_internal)
9455 (Frun_window_configuration_change_hook, make_parent_window)
9456 (resize_window_check, resize_window_apply, Fresize_window_apply)
9457 (resize_frame_windows, Fsplit_window_internal)
9458 (Fdelete_window_internal, Fresize_mini_window_internal):
9460 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9462 2011-06-08 Martin Rudalics <rudalics@gmx.at>
9464 * window.h (window): Add some new members to window structure -
9465 normal_lines, normal_cols, new_total, new_normal, clone_number,
9466 splits, nest, prev_buffers, next_buffers.
9467 (WINDOW_TOTAL_SIZE): Move here from window.c.
9468 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
9470 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9472 (make_dummy_parent): Set new members of windows structure.
9473 (make_window): Move down in code. Handle new members of window
9475 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9476 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9477 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9478 (Fset_window_prev_buffers, Fwindow_next_buffers)
9479 (Fset_window_next_buffers, Fset_window_clone_number):
9481 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9482 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9484 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9485 Argument WINDOW can be now internal window too.
9486 (Fwindow_use_time): Move up in code.
9487 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9489 (Fset_window_configuration, saved_window)
9490 (Fcurrent_window_configuration, save_window_save): Handle new
9491 members of window structure.
9492 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9493 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9494 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9495 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9496 Qget_mru_window, Qresize_root_window,
9497 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9498 Qauto_buffer_name; staticpro them.
9500 2011-06-07 Martin Rudalics <rudalics@gmx.at>
9502 * window.c (Fwindow_total_size, Fwindow_left_column)
9503 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9504 (Fwindow_list_1): New functions.
9505 (window_box_text_cols): Replace with window_body_cols.
9506 (Fwindow_width, Fscroll_left, Fscroll_right):
9507 Use window_body_cols instead of window_box_text_cols.
9508 (delete_window, Fset_window_configuration):
9509 Call delete_all_subwindows with window as argument.
9510 (delete_all_subwindows): Take a window as argument and not a
9512 (window_loop): Remove handling of GET_LRU_WINDOW and
9514 (Fget_lru_window, Fget_largest_window): Move to window.el.
9516 * window.h: Extern window_body_cols instead of
9517 window_box_text_cols. delete_all_subwindows now takes a
9518 Lisp_Object as argument.
9520 * indent.c (compute_motion, Fcompute_motion):
9521 Use window_body_cols instead of window_box_text_cols.
9523 * frame.c (delete_frame): Call delete_all_subwindows with root
9526 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9528 * fns.c (Fputhash): Document return value.
9530 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
9532 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9534 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9536 Cons<->int and similar integer overflow fixes (Bug#8794).
9538 Check for overflow when converting integer to cons and back.
9539 * charset.c (Fdefine_charset_internal, Fdecode_char):
9540 Use cons_to_unsigned to catch overflow.
9541 (Fencode_char): Use INTEGER_TO_CONS.
9542 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9543 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9544 * data.c (long_to_cons, cons_to_long): Remove.
9545 (cons_to_unsigned, cons_to_signed): New functions.
9546 These signal an error for invalid or out-of-range values.
9547 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9548 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9549 * font.c (Ffont_variation_glyphs):
9550 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9551 * lisp.h: Include <intprops.h>.
9552 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9553 (cons_to_signed, cons_to_unsigned): New decls.
9554 (long_to_cons, cons_to_long): Remove decls.
9555 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9556 (Fprimitive_undo): Use CONS_TO_INTEGER.
9557 * xfns.c (Fx_window_property): Likewise.
9558 * xselect.c: Include <limits.h>.
9559 (x_own_selection, selection_data_to_lisp_data):
9560 Use INTEGER_TO_CONS.
9561 (x_handle_selection_request, x_handle_selection_clear)
9562 (x_get_foreign_selection, Fx_disown_selection_internal)
9563 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9564 (lisp_data_to_selection_data): Use cons_to_unsigned.
9565 (x_fill_property_data): Use cons_to_signed.
9566 Report values out of range.
9568 Check for buffer and string overflow more precisely.
9569 * buffer.h (BUF_BYTES_MAX): New macro.
9570 * lisp.h (STRING_BYTES_MAX): New macro.
9571 * alloc.c (Fmake_string):
9572 * character.c (string_escape_byte8):
9573 * coding.c (coding_alloc_by_realloc):
9574 * doprnt.c (doprnt):
9575 * editfns.c (Fformat):
9577 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9578 since they may not be the same number.
9579 * editfns.c (Finsert_char):
9580 * fileio.c (Finsert_file_contents):
9581 Likewise for BUF_BYTES_MAX.
9583 * image.c: Use ptrdiff_t, not int, for sizes.
9584 (slurp_file): Switch from int to ptrdiff_t.
9586 (slurp_file): Check that file size fits in both size_t (for
9587 malloc) and ptrdiff_t (for sanity and safety).
9589 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9590 if b->modtime has its maximal value.
9592 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9594 Don't assume time_t can fit into int.
9595 * buffer.h (struct buffer.modtime): Now time_t, not int.
9596 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9597 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9599 Minor fixes for signed vs unsigned integers.
9600 * character.h (MAYBE_UNIFY_CHAR):
9601 * charset.c (maybe_unify_char):
9602 * keyboard.c (read_char, reorder_modifiers):
9603 XINT -> XFASTINT, since the integer must be nonnegative.
9604 * ftfont.c (ftfont_spec_pattern):
9605 * keymap.c (access_keymap, silly_event_symbol_error):
9606 XUINT -> XFASTINT, since the integer must be nonnegative.
9607 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9608 since it makes no difference and we prefer signed.
9609 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9610 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9613 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9615 * window.h (Fwindow_frame): Declare.
9617 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9619 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9620 (SPARE_MEMORY): Always define.
9621 (LARGE_REQUEST): Remove.
9622 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9624 2011-06-06 Martin Rudalics <rudalics@gmx.at>
9626 * lisp.h: Move EXFUNS for Fframe_root_window,
9627 Fframe_first_window and Fset_frame_selected_window to window.h.
9629 * window.h: Move EXFUNS for Fframe_root_window,
9630 Fframe_first_window and Fset_frame_selected_window here from
9633 * frame.c (Fwindow_frame, Fframe_first_window)
9634 (Fframe_root_window, Fframe_selected_window)
9635 (Fset_frame_selected_window): Move to window.c.
9636 (Factive_minibuffer_window): Move to minibuf.c.
9637 (Fother_visible_frames_p): New function.
9639 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9641 * window.c (decode_window, decode_any_window): Move up in code.
9642 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9643 (inhibit_frame_unsplittable): Remove unused variable.
9644 (Fwindow_buffer): Move up and rewrite doc-string.
9645 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9646 (Fwindow_prev): New functions.
9647 (Fwindow_frame): Move here from frame.c. Accept any window as
9649 (Fframe_root_window, Fframe_first_window)
9650 (Fframe_selected_window): Move here from frame.c. Accept frame
9651 or arbitrary window as argument. Update doc-strings.
9652 (Fminibuffer_window): Move up in code.
9653 (Fwindow_minibuffer_p): Move up in code and simplify.
9654 (Fset_frame_selected_window): Move here from frame.c.
9656 (Fselected_window, select_window, Fselect_window): Move up in
9657 code. Minor doc-string fixes.
9659 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9661 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9662 Do not assume that spare memory exists; that assumption is valid
9663 only if SYSTEM_MALLOC.
9664 (LARGE_REQUEST): New macro, so that the issue of large requests
9665 is separated from the issue of spare memory.
9667 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9669 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9672 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9674 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9677 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9679 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9681 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9683 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9684 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9686 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
9688 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9690 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
9692 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9693 (x_clipboard_manager_save): Add return value.
9694 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9696 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9697 Obey Vx_select_enable_clipboard_manager. Catch errors in
9698 x_clipboard_manager_save (Bug#8779).
9699 (Vx_select_enable_clipboard_manager): New variable.
9700 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
9702 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
9704 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9706 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9708 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9709 in the current matrix if keep_current_p is non-zero.
9711 2011-06-04 Eli Zaretskii <eliz@gnu.org>
9713 * bidi.c (bidi_level_of_next_char): Fix last change.
9715 2011-06-03 Eli Zaretskii <eliz@gnu.org>
9717 Support bidi reordering of text covered by display properties.
9719 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9720 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9721 (bidi_cache_search, bidi_cache_iterator_state)
9722 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
9723 (bidi_level_of_next_char, bidi_move_to_visually_next):
9724 Support character positions inside a run of characters covered by a
9726 (bidi_paragraph_init, bidi_resolve_explicit_1)
9727 (bidi_level_of_next_char): Call bidi_fetch_char and
9728 bidi_fetch_char_advance instead of FETCH_CHAR and
9730 (bidi_init_it): Initialize new members.
9731 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9733 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9734 instead of using explicit *_CHAR codes.
9735 (bidi_resolve_explicit, bidi_resolve_weak):
9736 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
9737 bidirectional text is supported only in multibyte buffers.
9738 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9739 it to initialize the frame_window_p member of struct bidi_it.
9740 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9741 (bidi_resolve_explicit, bidi_resolve_weak)
9742 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9743 bidi_it->nchars is non-positive.
9744 (bidi_level_of_next_char): Don't try to lookup the cache for the
9745 next/previous character if nothing is cached there yet, or if we
9746 were just reseat()'ed to a new position.
9748 * xdisp.c (set_cursor_from_row): Set start and stop points
9749 according to the row's direction when priming the loop that looks
9750 for the glyph on which to display cursor.
9751 (single_display_spec_intangible_p): Function deleted.
9752 (display_prop_intangible_p): Reimplement to call
9753 handle_display_spec instead of single_display_spec_intangible_p.
9754 Accept 3 additional arguments needed by handle_display_spec.
9755 This fixes incorrect cursor motion across display property with complex
9756 values: lists, `(when COND...)' forms, etc.
9757 (single_display_spec_string_p): Support property values that are
9758 lists with the argument STRING its top-level element.
9759 (display_prop_string_p): Fix the condition for processing a
9760 property that is a list to be consistent with handle_display_spec.
9761 (handle_display_spec): New function, refactored from the
9762 last portion of handle_display_prop.
9763 (compute_display_string_pos): Accept additional argument
9764 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9765 value of a `display' property is a "replacing spec".
9766 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9767 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9768 the display property, but just return a value indicating whether
9769 the display property will replace the characters it covers.
9770 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9771 frame_window_p members of struct bidi_it.
9772 (compute_display_string_pos, compute_display_string_end):
9774 (push_it): Accept second argument POSITION, where pop_it should
9775 jump to continue iteration.
9776 (reseat_1): Initialize bidi_it.disp_pos.
9778 * keyboard.c (adjust_point_for_property): Adjust the call to
9779 display_prop_intangible_p to its new signature.
9781 * dispextern.h (struct bidi_it): New member frame_window_p.
9782 (bidi_init_it): Update prototypes.
9783 (display_prop_intangible_p): Update prototype.
9784 (compute_display_string_pos, compute_display_string_end):
9786 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9789 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
9791 Malloc failure behavior now depends on size of allocation.
9792 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9793 * lisp.h: Change signatures accordingly.
9794 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9795 All callers changed. (Bug#8762)
9797 * gnutls.c: Use Emacs's memory allocators.
9798 Without this change, the gnutls library would invoke malloc etc.
9799 directly, which causes problems on non-SYNC_INPUT hosts, and which
9800 runs afoul of improving memory_full behavior. (Bug#8761)
9801 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9802 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9803 xfree instead of the default malloc, realloc, free.
9804 (Fgnutls_boot): No need to check for memory allocation failure,
9805 since xmalloc does that for us.
9807 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
9808 * category.c (hash_get_category_set):
9809 * ccl.c (ccl_driver):
9810 * charset.c (Fdefine_charset_internal):
9811 * charset.h (struct charset.hash_index):
9812 * composite.c (get_composition_id, gstring_lookup_cache)
9813 (composition_gstring_put_cache):
9814 * composite.h (struct composition.hash_index):
9815 * dispextern.h (struct image.hash):
9816 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9817 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9818 (hashfn_equal, hashfn_user_defined, make_hash_table)
9819 (maybe_resize_hash_table, hash_lookup, hash_put)
9820 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9821 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9822 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9823 * image.c (make_image, search_image_cache, lookup_image)
9824 (xpm_put_color_table_h):
9825 * lisp.h (struct Lisp_Hash_Table):
9826 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
9827 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
9828 for hashes and hash indexes, instead of 'unsigned' and 'int'.
9829 * alloc.c (allocate_vectorlike):
9830 Check for overflow in vector size calculations.
9831 * ccl.c (ccl_driver):
9832 Check for overflow when converting EMACS_INT to int.
9833 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9834 need to be updated by these changes.
9835 * fns.c (make_hash_table, maybe_resize_hash_table):
9836 Check for integer overflow with large hash tables.
9837 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9838 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9839 (SXHASH_REDUCE): New macro.
9840 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9841 Use it instead of discarding useful hash info with large hash values.
9842 (sxhash_float): New function.
9843 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9844 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
9845 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9846 Rewrite to use FIXNUM_BITS, as this simplifies things.
9847 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9848 Adjust signatures to match updated version of code.
9849 (consing_since_gc): Now EMACS_INT, since a single hash table can
9850 use more than INT_MAX bytes.
9852 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9854 Make it possible to build with GCC-4.6+ -O2 -flto.
9856 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9858 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9860 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9861 Call minibuffer-inactive-mode.
9863 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
9865 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9866 Update dependencies.
9868 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9870 * data.c (init_data): Remove code for UTS, this system is not
9873 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9875 Don't force ./temacs to start in terminal mode.
9877 * frame.c (make_initial_frame): Initialize faces in all cases, not
9878 only when CANNOT_DUMP is defined.
9879 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9881 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9883 * dispnew.c (add_window_display_history): Use const for the string
9884 pointer. Remove declaration, not needed.
9886 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9888 Use 'inline', not 'INLINE'.
9889 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
9890 * alloc.c, fontset.c (INLINE): Remove.
9891 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9892 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9893 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9894 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9895 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9897 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9899 Make it possible to run ./temacs.
9901 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9902 syms_of_callproc does the same thing. Remove test for
9903 "initialized", do it in the caller.
9904 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9906 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9908 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9909 (read_minibuf): Use get_minibuffer.
9910 (syms_of_minibuf): Use DEFSYM.
9911 (Qmetadata): New var.
9912 * data.c (Qbuffer): Don't make it static.
9913 (syms_of_data): Use DEFSYM.
9915 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9917 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9918 (CCL_CODE_MIN): New macro.
9920 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9922 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9924 * eval.c (Qdebug): Now static.
9925 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9926 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9927 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9929 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
9931 * image.c: Various fixes to ImageMagick code comments.
9932 (Fimagemagick_types): Doc fix.
9934 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9936 Minor fixes prompted by GCC 4.6.0 warnings.
9938 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9940 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9941 (x_clipboard_manager_save_all): Move extern decl to ...
9942 * xterm.h: ... here, so that it can be checked for consistency.
9944 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
9946 * xselect.c (x_clipboard_manager_save_frame)
9947 (x_clipboard_manager_save_all): New functions.
9948 (Fx_clipboard_manager_save): Lisp function deleted.
9950 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9951 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9953 * xterm.h: Update prototype.
9955 2011-05-28 William Xu <william.xwl@gmail.com>
9957 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9960 2011-05-28 Jim Meyering <meyering@redhat.com>
9962 Avoid a sign-extension bug in crypto_hash_function.
9963 * fns.c (to_uchar): Define.
9964 (crypto_hash_function): Use it to convert some newly-signed
9965 variables to unsigned, to avoid sign-extension bugs. For example,
9966 without this change, (md5 "truc") would evaluate to
9967 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9968 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
9969 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
9971 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9973 Integer overflow fixes.
9975 * dbusbind.c: Serial number integer overflow fixes.
9976 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
9977 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9978 to hold a serial number that is too large for a fixnum.
9979 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9980 Check for serial numbers out of range. Decode any serial number
9981 that was so large that it became a float. (Bug#8722)
9983 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9984 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9985 Use XFASTINT rather than XUINT when numbers are nonnegative.
9986 (xd_append_arg, Fdbus_method_return_internal):
9987 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9988 arguments, check that Lisp number is nonnegative, rather than
9989 silently wrapping negative numbers around. (Bug#8722)
9990 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
9993 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9995 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9997 ccl: Add integer overflow checks.
9998 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9999 (IN_INT_RANGE): New macros.
10000 (ccl_driver): Use them to check for integer overflow when
10001 decoding a CCL program. Many of the new checks are whether XINT (x)
10002 fits in int; it doesn't always, on 64-bit hosts. The new version
10003 doesn't catch all possible integer overflows, but it's an
10004 improvement. (Bug#8719)
10006 * alloc.c (make_event_array): Use XINT, not XUINT.
10007 There's no need for unsigned here.
10009 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10010 This follows up to the 2011-05-06 change that substituted uintptr_t
10011 for EMACS_INT. This case wasn't caught back then.
10013 Rework Fformat to avoid integer overflow issues.
10014 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10015 now (part of C89). Include <verify.h>.
10016 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10017 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10018 (Fformat): Avoid the prepass trying to compute sizes; it was only
10019 approximate and thus did not catch overflow reliably. Instead, walk
10020 through the format just once, formatting and computing sizes as we go,
10021 checking for integer overflow at every step, and allocating a larger
10022 buffer as needed. Keep track separately whether the format is
10023 multibyte. Keep only the most-recently calculated precision, rather
10024 than them all. Record whether each argument has been converted to
10025 string. Use EMACS_INT, not int, for byte and char and arg counts.
10026 Support field widths and precisions larger than INT_MAX. Avoid
10027 sprintf's undefined behavior with conversion specifications such as %#d
10028 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10029 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10030 formatting out-of-range floating point numbers with int
10031 formats. (Bug#8668)
10033 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10035 * data.c: Avoid integer truncation in expressions involving floats.
10036 * data.c: Include <intprops.h>.
10037 (arith_driver): When there's an integer overflow in an expression
10038 involving floating point, convert the integers to floating point
10039 so that the resulting value does not suffer from catastrophic
10040 integer truncation. For example, on a 64-bit host (* 4
10041 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10042 Do not rely on undefined behavior after integer overflow.
10044 merge count_size_as_multibyte, parse_str_to_multibyte
10045 * character.c, character.h (count_size_as_multibyte):
10046 Rename from parse_str_to_multibyte; all uses changed.
10047 Check for integer overflow.
10048 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10049 since it's now a duplicate of the other. This is more of
10050 a character than a buffer op, so better that it's in character.c.
10051 * fns.c, print.c: Adjust to above changes.
10053 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10055 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10057 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10059 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10060 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10061 (x_clipboard_manager_save): Now static.
10062 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10064 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10065 (crypto_hash_function): Now static.
10066 Fix pointer signedness problems. Avoid unnecessary initializations.
10068 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
10070 * termhooks.h (Vselection_alist): Make it terminal-local.
10072 * terminal.c (create_terminal): Initialize it.
10074 * xselect.c: Support for clipboard managers.
10075 (Vselection_alist): Move to termhooks.h as terminal-local var.
10076 (LOCAL_SELECTION): New macro.
10077 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10078 (symbol_to_x_atom): Remove gratuitous arg.
10079 (x_handle_selection_request, lisp_data_to_selection_data)
10080 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
10081 (x_own_selection, x_get_local_selection, x_convert_selection):
10082 New arg, specifying work frame. Use terminal-local Vselection_alist.
10083 (some_frame_on_display): Delete unused function.
10084 (Fx_own_selection_internal, Fx_get_selection_internal)
10085 (Fx_disown_selection_internal, Fx_selection_owner_p)
10086 (Fx_selection_exists_p): New optional frame arg.
10087 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10088 (x_handle_selection_clear): Don't treat other terminals with the
10089 same keyboard specially. Use the terminal-local Vselection_alist.
10090 (x_clear_frame_selections): Use Frun_hook_with_args.
10092 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10094 * xterm.h: Add support for those atoms.
10096 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
10098 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10099 (converted_selections, conversion_fail_tag): New global variables.
10100 (x_selection_request_lisp_error): Free the above.
10101 (x_get_local_selection): Remove unnecessary code.
10102 (x_reply_selection_request): Args changed; handle arbitrary array
10103 of converted selections stored in converted_selections.
10104 Separate the XChangeProperty and SelectionNotify steps.
10105 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10106 (x_convert_selection): New function.
10107 (x_handle_selection_event): Simplify.
10108 (x_get_foreign_selection): Don't ignore incoming requests while
10109 waiting for an answer; this will fail when we implement
10110 SAVE_TARGETS, and seems unnecessary anyway.
10111 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10112 (Vx_sent_selection_functions): Doc fix.
10114 2011-05-26 Leo Liu <sdl.web@gmail.com>
10116 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10118 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10120 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10122 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10123 for fringe update if it has periodic bitmap.
10124 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
10125 and fringe_bitmap_periodic_p.
10127 * fringe.c (get_fringe_bitmap_data): New function.
10128 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10129 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10130 row. Mark glyph row for fringe update if periodicity changed.
10132 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10133 for fringe update unless it has periodic bitmap.
10135 2011-05-25 Kenichi Handa <handa@m17n.org>
10137 * xdisp.c (get_next_display_element): Set correct it->face_id for
10138 a static composition.
10140 2011-05-24 Leo Liu <sdl.web@gmail.com>
10143 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10145 * fns.c (crypto_hash_function, Fsha1): New function.
10146 (Fmd5): Use crypto_hash_function.
10147 (syms_of_fns): Add Ssha1.
10149 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10151 * gnutls.c: Remove unused macros.
10152 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10153 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10154 Remove macros that are defined and never used.
10155 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10157 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
10159 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10160 (Fx_get_selection_internal): Minor cleanup.
10161 (Fx_own_selection_internal): Rename arguments for consistency with
10164 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10166 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10168 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
10170 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10172 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10174 * dispnew.c (scrolling_window): Don't exclude the case that the
10175 last enabled row in the desired matrix touches the bottom boundary.
10177 2011-05-21 Glenn Morris <rgm@gnu.org>
10179 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
10180 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10181 and add some more files.
10183 2011-05-20 Eli Zaretskii <eliz@gnu.org>
10185 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10186 report_file_error introduced by the change from 2011-05-07.
10188 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10190 * systime.h (Time): Define only if emacs is defined.
10191 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10192 where the include path doesn't have X11/X.h by default. See
10193 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10195 2011-05-20 Kenichi Handa <handa@m17n.org>
10197 * composite.c (find_automatic_composition): Fix previous change.
10199 2011-05-20 Glenn Morris <rgm@gnu.org>
10201 * lisp.mk: New file, split from Makefile.in.
10202 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10203 (shortlisp): Remove.
10204 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10206 2011-05-19 Glenn Morris <rgm@gnu.org>
10208 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10209 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10210 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10211 (lisp): Set the order to that of loadup.el.
10212 (shortlisp): Make it a copy of $lisp.
10213 (SOME_MACHINE_LISP): Remove.
10214 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10215 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10217 2011-05-18 Kenichi Handa <handa@m17n.org>
10219 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10220 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10221 (find_automatic_composition): Mostly rewrite for efficiency.
10223 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
10225 * makefile.w32-in: Update dependencies.
10227 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10229 * menu.c: Include limits.h (fixes the MS-Windows build broken by
10230 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
10232 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
10234 Fix some integer overflow issues, such as string length overflow.
10236 * insdel.c (count_size_as_multibyte): Check for string overflow.
10238 * character.c (lisp_string_width): Check for string overflow.
10239 Use EMACS_INT, not int, for string indexes and lengths; in
10240 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10241 the resulting string length overflows an EMACS_INT; instead,
10242 report a string overflow if no precision given. When checking for
10243 precision exhaustion, use a check that cannot possibly have
10244 integer overflow. (Bug#8675)
10245 * character.h (lisp_string_width): Adjust to new signature.
10247 * alloc.c (string_overflow): New function.
10248 (Fmake_string): Use it. This doesn't change behavior, but saves
10249 a few bytes and will simplify future changes.
10250 * character.c (string_escape_byte8): Likewise.
10251 * lisp.h (string_overflow): New decl.
10253 Fixups, following up to the user-interface timestamp change.
10254 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10255 for UI timestamps, instead of unsigned long.
10256 * msdos.c (mouse_get_pos): Likewise.
10257 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
10258 * w32gui.h (Time): Define by including "systime.h" rather than by
10259 declaring it ourselves. (Bug#8664)
10261 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10262 * image.c (clear_image_cache): Likewise.
10264 * term.c (term_mouse_position): Don't assume time_t wraparound.
10266 Be more systematic about user-interface timestamps.
10267 Before, the code sometimes used 'Time', sometimes 'unsigned long',
10268 and sometimes 'EMACS_UINT', to represent these timestamps.
10269 This change causes it to use 'Time' uniformly, as that's what X uses.
10270 This makes the code easier to follow, and makes it easier to catch
10271 integer overflow bugs such as Bug#8664.
10272 * frame.c (Fmouse_position, Fmouse_pixel_position):
10273 Use Time, not unsigned long, for user-interface timestamps.
10274 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10275 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10276 * keyboard.h (last_event_timestamp): Likewise.
10277 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10278 * menu.h (xmenu_show): Likewise.
10279 * term.c (term_mouse_position): Likewise.
10280 * termhooks.h (struct input_event.timestamp): Likewise.
10281 (struct terminal.mouse_position_hook): Likewise.
10282 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10283 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10284 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10285 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10286 what it was before.
10287 * menu.h, termhooks.h: Include "systime.h", for Time.
10289 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10290 Don't assume that the difference between two unsigned long values
10291 can fit into an integer. At this point, we know button_down_time
10292 <= event->timestamp, so the difference must be nonnegative, so
10293 there's no need to cast the result if double-click-time is
10294 nonnegative, as it should be; check that it's nonnegative, just in
10295 case. This bug is triggered when events are more than 2**31 ms
10296 apart (about 25 days). (Bug#8664)
10298 * xselect.c (last_event_timestamp): Remove duplicate decl.
10299 (x_own_selection): Remove needless cast to unsigned long.
10301 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10302 that always fit in int. Use a sentinel instead of a counter, to
10303 avoid a temp and to allay GCC's concerns about possible int overflow.
10304 * frame.h (struct frame): Use int for menu_bar_items_used
10305 instead of EMACS_INT, since it always fits in int.
10307 * menu.c (grow_menu_items): Check for int overflow.
10309 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10311 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10312 Before, the code was not consistent. These values cannot exceed
10313 2**31 - 1 so there's no need to make them unsigned.
10314 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10315 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10316 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10318 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10320 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10321 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10322 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10323 presumably because the widths might not match.
10325 * window.c (size_window): Avoid needless test at loop start.
10327 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10329 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10331 2011-05-12 Drew Adams <drew.adams@oracle.com>
10333 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10335 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10337 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10338 `width' to `bar_area_x' and `bar_area_width', respectively.
10339 (x_scroll_run): Take account of fringe background extension.
10341 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10342 Rename local vars `left' and `width' to `bar_area_x' and
10343 `bar_area_width', respectively.
10344 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10345 background extension.
10347 2011-05-10 Jim Meyering <meyering@redhat.com>
10349 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10351 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
10353 * image.c (Finit_image_library): Return t for built-in image types,
10354 like pbm and xbm. (Bug#8640)
10356 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10358 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10360 2011-05-07 Eli Zaretskii <eliz@gnu.org>
10362 * w32console.c (Fset_screen_color): Doc fix.
10363 (Fget_screen_color): New function.
10364 (syms_of_ntterm): Defsubr it.
10366 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10367 unlink the temporary file if Fcall_process didn't create it in the
10369 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10370 child process will be redirected to a file specified with `:file'.
10371 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10372 cue to call_process_cleanup not to close that handle.
10374 2011-05-07 Ben Key <bkey76@gmail.com>
10376 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10377 one of two shell specific rules, either bootstrap-temacs-CMD or
10378 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10379 to the previous implementation of the bootstrap-temacs rule.
10380 The bootstrap-temacs-CMD rule is similar to the previous
10381 implementation of the bootstrap-temacs rule except that it
10382 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10385 These changes, along with some changes to nt/configure.bat,
10386 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10387 earlier fix to add support for --cflags and --ldflags options
10388 that include quotes so that it works whether make uses cmd or
10391 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
10393 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10394 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10396 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10397 a string. Handle both cases.
10398 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10399 (Fdbus_register_method): Use Qinvalid_function.
10401 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
10403 * makefile.w32-in: Update dependencies.
10404 (LISP_H): Add inttypes.h and stdin.h.
10405 (PROCESS_H): Add unistd.h.
10407 2011-05-06 Eli Zaretskii <eliz@gnu.org>
10409 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10410 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10412 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
10414 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10416 * term.c (vfatal): Remove stray call to va_end.
10417 It's not needed and the C Standard doesn't allow it here anyway.
10419 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10420 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10422 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10425 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10427 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10429 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10431 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10433 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10435 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10436 * charset.c (Fdefine_charset_internal): Don't initialize
10437 charset.code_space[15]. The value was garbage, on hosts with
10438 32-bit int (Bug#8600).
10440 * lread.c (read_integer): Be more consistent with string-to-number.
10441 Use string_to_number to do the actual conversion; this avoids
10442 rounding errors and fixes some other screwups. Without this fix,
10443 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10444 (digit_to_number): Move earlier, for benefit of read_integer.
10445 Return -1 if the digit is out of range for the base, -2 if it is
10446 not a digit in any supported base. (Bug#8602)
10448 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10450 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10451 to match comment at start of function. This also removes a
10452 GCC warning about overflow in a 32+64-bit port.
10454 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10456 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10457 Reported by Stefan Monnier in
10458 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
10459 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10460 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
10462 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10463 (EMACS_UINTPTR): Likewise, with uintptr_t.
10465 * lisp.h: Prefer 64-bit EMACS_INT if available.
10466 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10467 on 32-bit hosts that have 64-bit int, so that they can access
10469 However, temporarily disable this change unless the temporary
10470 symbol WIDE_EMACS_INT is defined.
10472 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10474 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10475 This removes an assumption that EMACS_INT and long are the same
10476 width as pointers. The assumption is true for Emacs porting targets
10477 now, but we want to make other targets possible.
10478 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10479 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10480 In the rest of the code, change types of integers that hold casted
10481 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10482 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10483 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10484 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10485 No need to cast type when ORing.
10486 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10487 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10488 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10489 assume EMACS_INT is the same width as char *.
10490 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10491 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10492 Remove no-longer-needed casts.
10493 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10494 (xg_tool_bar_help_callback, xg_make_tool_item):
10495 Use EMACS_INTPTR to hold an integer
10496 that will be cast to void *; this can avoid a GCC warning
10497 if EMACS_INT is not the same width as void *.
10498 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10499 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10500 (current_message_1, set_message_1):
10501 Use a local to convert to proper width without a cast.
10502 * xmenu.c (dialog_selection_callback): Likewise.
10504 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10505 Also, don't assume VALBITS / RAND_BITS is less than 5,
10506 and don't rely on undefined behavior when shifting a 1 left into
10508 * lisp.h (get_random): Change signature to match.
10510 * lread.c (hash_string): Use size_t, not int, for hash computation.
10511 Normally we prefer signed values; but hashing is special, because
10512 it's better to use unsigned division on hash table sizes so that
10513 the remainder is nonnegative. Also, size_t is the natural width
10514 for hashing into memory. The previous code used 'int', which doesn't
10515 retain enough info to hash well into very large tables.
10516 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10518 * dbusbind.c: Don't possibly lose pointer info when converting.
10519 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10520 Use XPNTR rather than XHASH, so that the high-order bits of
10521 the pointer aren't lost when converting through void *.
10523 * eval.c (Fautoload): Don't double-shift a pointer.
10525 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10527 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
10529 * gnutls.c (DEF_GNUTLS_FN):
10530 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10532 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10534 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10537 2011-05-05 Eli Zaretskii <eliz@gnu.org>
10539 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10540 New version that can reserve upto 2GB of heap space.
10542 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
10544 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10546 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10548 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10549 `gnutls_certificate_set_x509_key_file'.
10551 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
10553 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10554 Update dependencies.
10556 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10558 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10559 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10560 Remove unused parameter `fildes'.
10561 * process.c (read_process_output, send_process): Don't pass it.
10563 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10565 Fix previous change: the library cache is defined in w32.c.
10566 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10567 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10569 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10571 Implement dynamic loading of GnuTLS on Windows.
10573 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10574 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10575 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10578 * gnutls.c (Qgnutls_dll): Define.
10579 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10580 (gnutls_*): Declare function pointers.
10581 (init_gnutls_functions): New function to initialize function pointers.
10582 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10583 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10584 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10585 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10586 (emacs_gnutls_write, emacs_gnutls_read)
10587 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10588 (Fgnutls_available_p): New function.
10589 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10590 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10591 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10593 * image.c: Include w32.h.
10594 (Vimage_type_cache): Delete.
10595 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10596 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10597 (w32_delayed_load): Move to w32.c.
10599 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10601 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10602 (w32_delayed_load): Move from image.c. When loading a library, record
10603 its filename in the :loaded-from property of the library id.
10604 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10605 Initialize and staticpro them.
10606 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10608 * process.c: Include lisp.h before w32.h, not after.
10609 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10610 instead of gnutls_record_check_pending.
10612 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10614 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10616 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10617 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10620 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10622 * xterm.c (x_set_frame_alpha): Do not set property on anything
10623 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10625 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
10627 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10629 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
10631 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10632 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10633 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10634 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10635 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10636 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10637 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10638 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10639 (Qgnutls_bootprop_callbacks_verify): Make static.
10641 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10643 * callproc.c: Indentation fixup.
10645 * sysdep.c (wait_for_termination_1): Make static.
10646 (wait_for_termination, interruptible_wait_for_termination):
10647 Move after wait_for_termination_1.
10649 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10651 * sysdep.c (interruptible_wait_for_termination): New function
10652 which is like wait_for_termination, but allows keyboard
10655 * callproc.c (Fcall_process): Add (:file "file") as an option for
10657 (Fcall_process_region): Ditto.
10659 2011-04-30 Eli Zaretskii <eliz@gnu.org>
10661 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10662 rather than `XVECTOR (FOO)->size'.
10664 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10665 inttypes.h, as a gnulib replacement is used if it not available in
10668 2011-04-21 Eli Zaretskii <eliz@gnu.org>
10670 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10671 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10672 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10674 * coding.c (coding_alloc_by_realloc): Error out if destination
10675 will grow beyond MOST_POSITIVE_FIXNUM.
10676 (decode_coding_emacs_mule): Abort if there isn't enough place in
10677 charbuf for the composition carryover bytes. Reserve an extra
10678 space for up to 2 characters produced in a loop.
10679 (decode_coding_iso_2022): Abort if there isn't enough place in
10680 charbuf for the composition carryover bytes.
10682 2011-04-21 Eli Zaretskii <eliz@gnu.org>
10684 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10685 aborting when %lld or %lll format is passed.
10686 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10687 %llo or %llx format is passed. (Bug#8545)
10689 * window.c (window_scroll_line_based): Use a marker instead of
10690 simple variables to record original value of point. (Bug#7952)
10692 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10693 produced by %s or %c overflows available buffer space. (Bug#8545)
10695 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10697 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
10698 (SIZE_MAX): Move defn after all includes, as they might #define it.
10700 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10702 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10704 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10706 * keyboard.c (Qdelayed_warnings_hook): Define.
10707 (command_loop_1): Run `delayed-warnings-hook'
10708 if Vdelayed_warnings_list is non-nil.
10709 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10710 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10712 2011-04-28 Eli Zaretskii <eliz@gnu.org>
10714 * doprnt.c (doprnt): Don't return value smaller than the buffer
10715 size if the message was truncated. (Bug#8545).
10717 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10719 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10720 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10722 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10724 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10726 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
10728 * makefile.w32-in: Update dependencies.
10730 2011-04-27 Eli Zaretskii <eliz@gnu.org>
10732 Improve `doprnt' and its usage. (Bug#8545)
10733 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10734 `format_end'. Remove support for %l as a conversion specifier.
10735 Don't use xrealloc. Improve diagnostics when the %l size modifier
10736 is used. Update the commentary.
10738 * eval.c (verror): Simplify calculation of size_t.
10740 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10743 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10745 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10748 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10750 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10751 This makes this file independent of the recent pseudovector change.
10753 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
10755 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10757 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
10758 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
10759 Remove unused local.
10760 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
10762 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
10763 GCC 4.6.0 optimizes based on type-based alias analysis.
10764 For example, if b is of type struct buffer * and v of type struct
10765 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10766 != &v->size, and therefore "v->size = 1; b->size = 2; return
10767 v->size;" must therefore return 1. This assumption is incorrect
10768 for Emacs, since it type-puns struct Lisp_Vector * with many other
10769 types. To fix this problem, this patch adds a new type struct
10770 vectorlike_header that documents the constraints on layout of vectors
10771 and pseudovectors, and helps optimizing compilers not get fooled
10772 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10773 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
10774 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10776 (XSETPVECTYPE): Rewrite in terms of new macro.
10777 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10778 This is a bit clearer, and further avoids the possibility of
10779 undesirable aliasing.
10780 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
10781 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
10782 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10783 since Lisp_Subr is a special case (no "next" field).
10784 (ASIZE): Now uses header.size rather than size.
10785 All previous uses of XVECTOR (foo)->size replaced to use this macro,
10786 to avoid the hassle of writing XVECTOR (foo)->header.size.
10787 (struct vectorlike_header): New type.
10788 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10789 object, to help avoid aliasing.
10790 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10791 (SUBRP): Likewise, since Lisp_Subr is a special case.
10792 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10793 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10794 (struct Lisp_Hash_Table): Combine first two members into a single
10795 struct vectorlike_header member. All uses of "size" and "next" members
10796 changed to be "header.size" and "header.next".
10797 * buffer.h (struct buffer): Likewise.
10798 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10799 * frame.h (struct frame): Likewise.
10800 * process.h (struct Lisp_Process): Likewise.
10801 * termhooks.h (struct terminal): Likewise.
10802 * window.c (struct save_window_data, struct saved_window): Likewise.
10803 * window.h (struct window): Likewise.
10804 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10805 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10806 * buffer.c (init_buffer_once): Likewise.
10807 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10809 * process.c (Fformat_network_address): Use local var for size,
10812 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10814 Make the Lisp reader and string-to-float more consistent (Bug#8525)
10815 * data.c (atof): Remove decl; no longer used or needed.
10816 (digit_to_number): Move to lread.c.
10817 (Fstring_to_number): Use new string_to_number function, to be
10818 consistent with how the Lisp reader treats infinities and NaNs.
10819 Do not assume that floating-point numbers represent EMACS_INT
10820 without losing information; this is not true on most 64-bit hosts.
10821 Avoid double-rounding errors, by insisting on integers when
10822 parsing non-base-10 numbers, as the documentation specifies.
10823 * lisp.h (string_to_number): New decl, replacing ...
10824 (isfloat_string): Remove.
10825 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
10826 (read1): Do not accept +. and -. as integers; this
10827 appears to have been a coding error. Similarly, do not accept
10828 strings like +-1e0 as floating point numbers. Do not report
10829 overflow for integer overflows unless the base is not 10 which
10830 means we have no simple and reliable way to continue.
10831 Break out the floating-point parsing into a new
10832 function string_to_number, so that Fstring_to_number parses
10833 floating point numbers consistently with the Lisp reader.
10834 (digit_to_number): Move here from data.c. Make it static inline.
10835 (E_CHAR, EXP_INT): Remove, replacing with ...
10836 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10837 (string_to_number): New function, replacing isfloat_string.
10838 This function checks for valid syntax and produces the resulting
10839 Lisp float number too. Rework it so that string-to-number
10840 no longer mishandles examples like "1.0e+". Use strtoumax,
10841 so that overflow for non-base-10 numbers is reported only when
10842 there's no portable and simple way to convert to floating point.
10844 * textprop.c (set_text_properties_1): Rewrite for clarity,
10845 and to avoid GCC warning about integer overflow.
10847 * intervals.h (struct interval): Use EMACS_INT for members
10848 where EMACS_UINT might cause problems. See
10849 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10850 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10851 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10853 (offset_intervals): Tell GCC not to worry about length overflow
10854 when negating a negative length.
10856 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10857 (overrun_check_free): Likewise.
10859 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10860 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10863 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10864 (gnutls_make_error): Rename local to avoid shadowing.
10865 (gnutls_emacs_global_deinit): ifdef out; not used.
10866 (Fgnutls_boot): Use const for pointer to readonly storage.
10867 Comment out unused local. Fix pointer signedness problems.
10869 * lread.c (openp): Don't stuff size_t into an 'int'.
10870 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10871 about possible signed overflow.
10873 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10874 (GDK_KEY_g): Don't define if already defined.
10875 (xg_prepare_tooltip): Avoid pointer signedness problem.
10876 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10878 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10879 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10881 * xfns.c (Fx_window_property): Simplify a bit,
10882 to make a bit faster and to avoid GCC 4.6.0 warning.
10883 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10885 * fns.c (internal_equal): Don't assume size_t fits in int.
10887 * alloc.c (compact_small_strings): Tighten assertion a little.
10889 Replace pEd with more-general pI, and fix some printf arg casts.
10890 * lisp.h (pI): New macro, generalizing old pEd macro to other
10891 conversion specifiers. For example, use "...%"pI"d..." rather
10892 than "...%"pEd"...".
10893 (pEd): Remove. All uses replaced with similar uses of pI.
10894 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
10895 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10896 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10897 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10898 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10899 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10900 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10902 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10903 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10904 * print.c (safe_debug_print, print_object): Likewise.
10905 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10907 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10908 avoiding the 0 flag, which is not portable.
10909 * process.c (Fmake_network_process): Use pI to avoid cast.
10910 * region-cache.c (pp_cache): Likewise.
10911 * xdisp.c (decode_mode_spec): Likewise.
10912 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10913 behavior on 64-bit hosts with printf arg.
10914 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
10915 (x_stop_queuing_selection_requests): Likewise.
10916 (x_get_window_property): Don't truncate byte count to an 'int'
10919 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10920 here, since it parses constructs like leading '-' and spaces,
10921 which are not wanted; and it overflows with large numbers.
10922 Instead, simply match F[0-9]+, which is what is wanted anyway.
10924 * alloc.c: Remove unportable assumptions about struct layout.
10925 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10926 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10927 (allocate_vectorlike, make_pure_vector): Use the new macros,
10928 plus offsetof, to remove unportable assumptions about struct layout.
10929 These assumptions hold on all porting targets that I know of, but
10930 they are not guaranteed, they're easy to remove, and removing them
10931 makes further changes easier.
10933 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10934 This doesn't fix a bug but makes the code clearer.
10935 (string_overrun_cookie): Now const. Use initializers that
10936 don't formally overflow signed char, to avoid warnings.
10937 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10938 can cause Emacs to crash when string overrun checking is enabled.
10939 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10940 multiple of sizeof (EMACS_INT); it need not be, if
10941 alignof(EMACS_INT) < sizeof (EMACS_INT).
10942 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
10944 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
10946 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10948 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10950 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
10951 supposed to be handshaking. (Bug#8556)
10952 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10954 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
10956 * lisp.h (Qdebug): List symbol.
10957 * eval.c (Qdebug): Restore global linkage.
10958 * keyboard.c (debug-on-event): New variable.
10959 (handle_user_signal): Break into debugger when debug-on-event
10960 matches the current signal symbol.
10962 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10964 * alloc.c (check_sblock, check_string_bytes)
10965 (check_string_free_list): Convert to standard C.
10967 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10969 * w32.c (emacs_gnutls_push): Fix typo.
10971 2011-04-25 Eli Zaretskii <eliz@gnu.org>
10973 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10974 "cast to pointer from integer of different size".
10976 Improve doprnt and its use in verror. (Bug#8545)
10977 * doprnt.c (doprnt): Document the set of format control sequences
10978 supported by the function. Use SAFE_ALLOCA instead of always
10981 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10982 is one byte too soon. Don't use xrealloc; instead xfree and
10985 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10987 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10990 * gnutls.c: Renamed global_initialized to
10991 gnutls_global_initialized. Added internals for the
10992 :verify-hostname-error, :verify-error, and :verify-flags
10993 parameters of `gnutls-boot' and documented those parameters in the
10994 docstring. Start callback support.
10995 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10996 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10997 on error. Return error code.
10998 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10999 (emacs_gnutls_read): Likewise.
11000 (Fgnutls_boot): Return handshake error code.
11001 (emacs_gnutls_handle_error): New function.
11002 (wsaerror_to_errno): Likewise.
11004 * w32.h (emacs_gnutls_pull): Add prototype.
11005 (emacs_gnutls_push): Likewise.
11007 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11008 (emacs_gnutls_push): Likewise.
11010 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11012 * process.c (wait_reading_process_output): Check if GnuTLS
11013 buffered some data internally if no FDs are set for TLS
11016 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11017 (LIBS): Link to USER_LIBS.
11018 ($(BLD)/gnutls.$(0)): New target.
11020 2011-04-24 Eli Zaretskii <eliz@gnu.org>
11022 * xdisp.c (handle_single_display_spec): Rename the
11023 display_replaced_before_p argument into display_replaced_p, to
11024 make it consistent with the commentary. Fix typos in the
11027 * textprop.c (syms_of_textprop): Remove dead code.
11028 (copy_text_properties): Delete obsolete commentary about an
11029 interface that was deleted long ago. Fix typos in the description
11032 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11033 to changes in oldXMenu/XMenu.h from 2011-04-16.
11034 <menu_help_message, prev_menu_help_message>: Constify.
11035 (IT_menu_make_room): menu->help_text is now `const char **';
11038 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11039 to changes in oldXMenu/XMenu.h from 2011-04-16.
11040 (struct XMenu): Declare `help_text' `const char **'.
11042 * xfaces.c <Qunspecified>: Make extern again.
11044 * syntax.c: Include sys/types.h before including regex.h, as
11047 * doc.c (get_doc_string): Improve the format passed to `error'.
11049 * doprnt.c (doprnt): Improve commentary.
11051 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11053 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11056 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11057 changes in globals.h immediately force recompilation.
11058 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11059 $(CURDIR)/s/ms-w32.h.
11060 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
11062 * character.c (Fchar_direction): Function deleted.
11063 (syms_of_character): Don't defsubr it.
11064 <char-direction-table>: Deleted.
11066 2011-04-23 Eli Zaretskii <eliz@gnu.org>
11068 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11069 * doprnt.c: Include limits.h.
11070 (SIZE_MAX): New macro.
11071 (doprnt): Return a size_t value. 2nd arg is now size_t.
11072 Many local variables are now size_t instead of int or unsigned.
11073 Improve overflow protection. Support `l' modifier for integer
11074 conversions. Support %l conversion. Don't assume an EMACS_INT
11075 argument for integer conversions and for %c.
11077 * lisp.h (doprnt): Restore prototype.
11079 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11080 $(SRC)/character.h.
11082 * Makefile.in (base_obj): Add back doprnt.o.
11084 * deps.mk (doprnt.o): Add back prerequisites.
11085 (callint.o): Depend on character.h.
11087 * eval.c (internal_lisp_condition_case): Include the handler
11088 representation in the error message.
11089 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11090 when breaking from the loop.
11092 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11094 * callint.c (Fcall_interactively): When displaying error message
11095 about invalid control letter, pass the character's codepoint, not
11096 a pointer to its multibyte form. Improve display of the character
11097 in octal and display also its hex code.
11099 * character.c (char_string): Use %x to display the (unsigned)
11100 codepoint of an invalid character, to avoid displaying a bogus
11103 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11104 `error', not SYMBOL_NAME itself.
11106 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11107 character arguments to `error'.
11109 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11110 to `error' in error message about FINAL_CHAR argument. Make sure
11111 FINAL_CHAR is a character, and use %c when it is passed as
11112 argument to `error'.
11114 2011-04-23 Eli Zaretskii <eliz@gnu.org>
11116 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11118 * w32.c: Include <time.h>.
11119 (sys_localtime): New function.
11121 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
11123 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11125 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
11127 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
11129 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11130 zombies (Bug#8467).
11132 2011-04-19 Eli Zaretskii <eliz@gnu.org>
11134 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11135 gl_state.e_property when gl_state.object is Qt.
11137 * insdel.c (make_gap_larger): Remove limitation of buffer size
11140 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
11142 * xdisp.c (lookup_glyphless_char_display)
11143 (produce_glyphless_glyph): Handle cons cell entry in
11144 glyphless-char-display.
11145 (Vglyphless_char_display): Document it.
11147 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11148 glyphless-char-display.
11150 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
11152 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11154 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11156 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11157 definition for no-X builds.
11159 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
11161 Static checks with GCC 4.6.0 and non-default toolkits.
11163 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11165 * process.c (keyboard_bit_set): Define only if SIGIO.
11166 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11167 (send_process): Repair possible setjmp clobbering.
11169 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11171 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11173 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11175 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11176 Define only if needed.
11178 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11179 by pacifying GCC about it. Maybe it's time to retire it?
11180 * xfaces.c (USG, __TIMEVAL__): Likewise.
11182 * dispextern.h (struct redisplay_interface): Rename param
11183 to avoid shadowing.
11184 * termhooks.h (struct terminal): Likewise.
11185 * xterm.c (xembed_send_message): Likewise.
11187 * insdel.c (make_gap_smaller): Define only if
11188 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11190 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11193 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11194 so that we aren't warned about unused symbols.
11196 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11198 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
11200 * xfns.c (x_real_positions): Mark locals as initialized.
11202 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11204 * xterm.c: Fix problems found by static analysis with other toolkits.
11205 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
11206 (x_dispatch_event): Declare static if USE_GTK, and
11207 define if USE_GTK || USE_X_TOOLKIT.
11208 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
11209 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
11210 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11211 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
11213 * xmenu.c (menu_help_callback): Pointer type fixes.
11214 Use const pointers when pointing at readonly data. Avoid pointer
11215 signedness clashes.
11216 (FALSE): Remove unused macro.
11217 (update_frame_menubar): Remove unused decl.
11219 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11221 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11222 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11223 (single_menu_item): Rename local to avoid shadowing.
11225 * keyboard.c (make_lispy_event): Remove unused local var.
11227 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11228 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11230 * bitmaps: Change bitmaps from unsigned char back to the X11
11231 compatible char. Avoid the old compiler warnings about
11232 out-of-range initializers by using, for example, '\xab' rather
11235 * xgselect.c (xgselect_initialize): Check vs interface
11236 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11238 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11240 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11241 to read-only memory.
11243 * fns.c (vector): Remove; this old hack is no longer needed.
11245 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
11247 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
11249 * xrdb.c (x_load_resources): Omit unused local.
11251 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
11252 (x_window): Rename locals to avoid shadowing.
11253 (USG): Use the kludged USG macro, to pacify gcc.
11255 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
11256 (x_term_init): Remove local to avoid shadowing.
11258 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
11260 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11261 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11263 2011-04-16 Eli Zaretskii <eliz@gnu.org>
11265 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11267 Fix regex.c, syntax.c and friends for buffers > 2GB.
11268 * syntax.h (struct gl_state_s): Declare character position members
11271 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11273 * textprop.c (verify_interval_modification, interval_of):
11274 Declare arguments EMACS_INT.
11276 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11279 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11281 * indent.c (Fvertical_motion): Local variable it_start is now
11284 * regex.c (re_match, re_match_2, re_match_2_internal)
11285 (bcmp_translate, regcomp, regexec, print_double_string)
11286 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11287 (re_compile_pattern, re_exec): Declare arguments and local
11288 variables `size_t' and `ssize_t' and return values `regoff_t', as
11290 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11291 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11292 <compile_stack_type>: `size' and `avail' are now `size_t'.
11294 * regex.h <regoff_t>: Use ssize_t, not int.
11295 (re_search, re_search_2, re_match, re_match_2): Arguments that
11296 specify buffer/string position and length are now ssize_t and
11297 size_t. Return type is regoff_t.
11299 2011-04-16 Ben Key <bkey76@gmail.com>
11301 * nsfont.m: Fixed bugs in ns_get_family and
11302 ns_descriptor_to_entity that were caused by using free to
11303 deallocate memory blocks that were allocated by xmalloc (via
11304 xstrdup). This caused Emacs to crash when compiled with
11305 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11306 --enable-checking=xmallocoverrun). xfree is now used to
11307 deallocate these memory blocks.
11309 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
11311 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11313 emacs_write: Accept and return EMACS_INT for sizes.
11314 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11316 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11317 Accept and return EMACS_INT.
11318 (emacs_gnutls_write): Return the number of bytes written on
11320 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
11321 (emacs_read, emacs_write): Remove check for negative size, as the
11322 Emacs source code has been audited now.
11323 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11324 (emacs_read, emacs_write): Use it.
11325 * process.c (send_process): Adjust to the new signatures of
11326 emacs_write and emacs_gnutls_write. Do not attempt to store
11327 a byte offset into an 'int'; it might overflow.
11328 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
11330 * sound.c: Don't assume sizes fit in 'int'.
11331 (struct sound_device.period_size, alsa_period_size):
11332 Return EMACS_INT, not int.
11333 (struct sound_device.write, vox_write, alsa_write):
11334 Accept EMACS_INT, not int.
11335 (wav_play, au_play): Use EMACS_INT to store sizes and to
11336 record read return values.
11338 2011-04-15 Ben Key <bkey76@gmail.com>
11340 * keyboard.c (Qundefined): Don't declare static since it is used
11342 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11343 static since they are used in nsfont.m.
11345 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11347 * process.c (Qprocessp): Don't declare static.
11348 * lisp.h (Qprocessp): Declare again.
11350 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
11352 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11354 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11356 Improve C-level modularity by making more things 'static'.
11358 Don't publish debugger-only interfaces to other modules.
11359 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11360 (verify_bytepos, count_markers): Move decls to the only modules
11362 * region-cache.h (pp_cache): Likewise.
11363 * window.h (check_all_windows): Likewise.
11364 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11366 * sysdep.c (croak): Now static, if
11367 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11368 * syssignal.h (croak): Declare only if not static.
11370 * alloc.c (refill_memory_reserve): Now static if
11371 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11372 * lisp.h (refill_memory_reserve): Declare only if not static.
11374 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11375 Define only if USE_LUCID.
11377 * xrdb.c (x_customization_string, x_rm_string): Now static.
11379 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11380 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11382 * xdisp.c (draw_row_with_mouse_face): Now static.
11383 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11385 * window.h (check_all_windows): Mark externally visible.
11387 * window.c (window_deletion_count): Now static.
11389 * undo.c: Make symbols static if they're not exported.
11390 (last_undo_buffer, last_boundary_position, pending_boundary):
11393 * textprop.c (interval_insert_behind_hooks): Now static.
11394 (interval_insert_in_front_hooks): Likewise.
11396 * term.c: Make symbols static if they're not exported.
11397 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11398 (max_frame_lines, tty_set_terminal_modes):
11399 (tty_reset_terminal_modes, tty_turn_off_highlight):
11400 (get_tty_terminal): Now static.
11401 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11402 * termhooks.h (term_mouse_moveto): Do not declare if
11403 HAVE_WINDOW_SYSTEM.
11404 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11405 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11407 * sysdep.c: Make symbols static if they're not exported.
11408 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11410 (sigprocmask_set, full_mask): Remove; unused.
11411 (wait_debugging): Mark as visible.
11412 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11413 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11415 * syntax.c (syntax_temp): Define only if !__GNUC__.
11417 * sound.c (current_sound_device, current_sound): Now static.
11419 * search.c (searchbufs, searchbuf_head): Now static.
11421 * scroll.c (scroll_cost): Remove; unused.
11422 * dispextern.h (scroll_cost): Remove decl.
11424 * region-cache.h (pp_cache): Mark as externally visible.
11426 * process.c: Make symbols static if they're not exported.
11427 (process_tick, update_tick, create_process, chan_process):
11428 (Vprocess_alist, proc_buffered_char, datagram_access):
11429 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11430 (deactivate_process): Mark defn as static, as well as decl.
11431 * lisp.h (create_process): Remove decl.
11432 * process.h (chan_process, Vprocess_alist): Remove decls.
11434 * print.c: Make symbols static if they're not exported.
11435 (print_depth, new_backquote_output, being_printed, print_buffer):
11436 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11437 (print_interval, print_number_index, initial_stderr_stream):
11439 * lisp.h (Fprinc): Remove decl.
11440 (debug_output_compilation_hack): Mark as externally visible.
11442 * sysdep.c (croak): Move decl from here to syssignal.h.
11443 * syssignal.h (croak): Put it here, so the API can be checked when
11444 'croak' is called from dissociate_if_controlling_tty.
11446 * minibuf.c: Make symbols static if they're not exported.
11447 (minibuf_save_list, choose_minibuf_frame): Now static.
11448 * lisp.h (choose_minibuf_frame): Remove decl.
11450 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11452 * lread.c: Make symbols static if they're not exported.
11453 (read_objects, initial_obarray, oblookup_last_bucket_number):
11455 (make_symbol): Remove; unused.
11456 * lisp.h (initial_obarray, make_symbol): Remove decls.
11458 * keyboard.c: Make symbols static if they're not exported.
11459 (single_kboard, recent_keys_index, total_keys, recent_keys):
11460 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11461 (this_single_command_key_start, echoing, last_auto_save):
11462 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11463 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11464 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11465 (Vlispy_mouse_stem, double_click_count):
11467 (force_auto_save_soon): Define only if SIGDANGER.
11468 (ignore_mouse_drag_p): Now static if
11469 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11470 (print_help): Remove; unused.
11471 (stop_character, last_timer_event): Mark as externally visible.
11472 * keyboard.h (ignore_mouse_drag_p): Declare only if
11473 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11474 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11475 * lisp.h (echoing): Remove decl.
11476 (force_auto_save_soon): Declare only if SIGDANGER.
11477 * xdisp.c (redisplay_window): Simplify code, to make it more
11478 obvious that ignore_mouse_drag_p is not accessed if !defined
11479 USE_GTK && !defined HAVE_NS.
11481 * intervals.c: Make symbols static if they're not exported.
11482 (merge_properties_sticky, merge_interval_right, delete_interval):
11484 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11486 * insdel.c: Make symbols static if they're not exported.
11487 However, leave prepare_to_modify_buffer alone. It's never
11488 called from outside this function, but that appears to be a bug.
11489 (combine_after_change_list, combine_after_change_buffer):
11490 (adjust_after_replace, signal_before_change): Now static.
11491 (adjust_after_replace_noundo): Remove; unused.
11492 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
11493 (signal_before_change): Remove decls.
11495 * indent.c (val_compute_motion, val_vmotion): Now static.
11497 * image.c: Make symbols static if they're not exported.
11498 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11500 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11501 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11503 * fringe.c (standard_bitmaps): Now static.
11504 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11506 * frame.c: Make symbols static if they're not exported.
11507 (x_report_frame_params, make_terminal_frame): Now static.
11508 (get_frame_param): Now static, unless HAVE_NS.
11509 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11510 (x_get_resource_string): Remove; not used.
11511 * frame.h (make_terminal_frame, x_report_frame_params):
11512 (x_get_resource_string); Remove decls.
11513 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11514 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11516 * font.c, fontset.c: Make symbols static if they're not exported.
11517 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11518 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11519 * font.c (font_close_object): Now static.
11520 * font.h (font_close_object): Remove.
11521 * fontset.c (FONTSET_OBJLIST): Remove.
11522 (free_realized_fontset) #if-0 the body, which does nothing.
11523 (face_suitable_for_char_p): #if-0, as it's never called.
11524 * fontset.h (face_suitable_for_char_p): Remove decl.
11525 * xfaces.c (face_at_string_position):
11526 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
11527 since 0 is always ASCII.
11529 * fns.c (weak_hash_tables): Now static.
11531 * fileio.c: Make symbols static if they're not exported.
11532 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11533 (Vwrite_region_annotation_buffers): Now static.
11535 * eval.c: Make symbols static if they're not exported.
11536 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11537 * lisp.h (backtrace_list): Remove decl.
11539 * emacs.c: Make symbols static if they're not exported.
11540 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11541 (fatal_error_code, fatal_error_signal_hook, standard_args):
11543 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11544 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11545 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11546 * lisp.h (fatal_error_signal_hook): Remove decl.
11547 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11549 * editfns.c: Move a (normally-unused) function to its only use.
11550 * editfns.c, lisp.h (get_operating_system_release): Remove.
11551 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11552 worth the hassle of breaking this out.
11554 * xterm.c: Make symbols static if they're not exported.
11555 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11556 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11557 (x_destroy_window, x_delete_display):
11559 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11560 (x_mouse_leave): Remove; unused.
11561 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11562 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11563 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11565 (x_mouse_leave): Declare only if WINDOWSNT.
11566 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11567 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11570 * ftxfont.c: Make symbols static if they're not exported.
11571 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11573 * font.h (ftxfont_driver): Likewise.
11575 * xfns.c: Make symbols static if they're not exported.
11576 (x_last_font_name, x_display_info_for_name):
11577 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11578 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11579 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11580 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11581 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11582 (last_show_tip_args): Now static.
11583 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11584 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11585 (x_screen_planes): Remove; unused.
11586 * dispextern.h (x_screen_planes): Remove decl.
11588 * dispnew.c: Make symbols static if they're not exported.
11589 * dispextern.h (redraw_garbaged_frames, scrolling):
11590 (increment_row_positions): Remove.
11591 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11592 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11594 (redraw_garbaged_frames): Remove; unused.
11596 * xfaces.c: Make symbols static if they're not exported.
11597 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11599 * xterm.h (defined_color): Remove decls.
11600 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11601 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11602 (menu_face_changed_default, defined_color, free_realized_face):
11603 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11604 (ascii_face_of_lisp_face): Remove; unused.
11606 * xdisp.c: Make symbols static if they're not exported.
11607 * dispextern.h (scratch_glyph_row, window_box_edges):
11608 (glyph_to_pixel_coords, set_cursor_from_row):
11609 (get_next_display_element, set_iterator_to_next):
11610 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11611 (show_mouse_face): Remove decls
11612 * frame.h (message_buf_print): Likewise.
11613 * lisp.h (pop_message, set_message, check_point_in_composition):
11615 * xterm.h (set_vertical_scroll_bar): Likewise.
11616 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11617 (message_buf_print, scratch_glyph_row, displayed_buffer):
11618 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11619 (get_next_display_element, show_mouse_face, window_box_edges):
11620 (frame_to_window_pixel_xy, check_point_in_composition):
11621 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11622 (glyph_to_pixel_coords): Remove; unused.
11624 * dired.c (file_name_completion): Now static.
11626 * dbusbind.c (xd_in_read_queued_messages): Now static.
11628 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11629 * data.c (circular_list_error): Remove.
11631 * commands.h (last_point_position, last_point_position_buffer):
11632 (last_point_position_window): Remove decls.
11633 * keyboard.c: Make these variables static.
11635 * coding.h (coding, code_convert_region, encode_coding_gap):
11637 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11638 (iso_code_class, detect_coding, code_convert_region): Now static.
11639 (encode_coding_gap): Remove; unused.
11641 * chartab.c (chartab_chars, chartab_bits): Now static.
11643 * charset.h (charset_iso_8859_1): Remove decl.
11644 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11647 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11648 * ccl.c (Vccl_program_table): Now static.
11649 (check_ccl_update): Remove; unused.
11651 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11652 * category.h: ... from here.
11653 * category.c (check_category_table, set_category_set): Now static.
11655 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11656 * lisp.h: Remove these decls.
11658 * buffer.c (buffer_count): Remove unused var.
11660 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11661 so that it's not optimized away.
11662 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11663 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11664 exported only to the debugger.
11666 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
11667 * atimer.h (run_all_atimers): Remove; not exported.
11669 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11670 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11671 was inaccessible from Lisp.
11672 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11673 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11675 alloc.c: Import and export fewer symbols, and remove unused items.
11676 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11678 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11679 it's not optimized away by whole-program optimization.
11680 (message_enable_multibyte, free_misc): Remove.
11681 (catchlist, handlerlist, mark_backtrace):
11682 Declare only if BYTE_MARK_STACK.
11683 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11684 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11685 (message_enable_multibyte): Remove decl.
11686 (free_misc, interval_free_list, float_block, float_block_index):
11687 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11688 (cons_free_list, last_marked_index):
11690 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11691 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11692 (mark_backtrace): Define only if BYTE_MARK_STACK.
11693 * xdisp.c (message_enable_multibyte): Now static.
11695 Declare Lisp_Object Q* variables to be 'static' if not exported.
11696 This makes it easier for human readers (and static analyzers)
11697 to see whether these variables are used from other modules.
11698 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11699 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11700 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11701 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11702 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11703 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11704 * xmenu.c, xselect.c:
11705 Declare Q* vars static if they are not used in other modules.
11706 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11707 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11708 Remove decls of unexported vars.
11709 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11711 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11713 Make Emacs functions such as Fatom 'static' by default.
11714 This makes it easier for human readers (and static analyzers)
11715 to see whether these functions can be called from other modules.
11716 DEFUN now defines a static function. To make the function external
11717 so that it can be used in other C modules, use the new macro DEFUE.
11718 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11719 (Finit_image_library):
11720 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11721 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11722 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11723 Remove decls, since these functions are now static.
11724 (Funintern, Fget_internal_run_time): New decls, since these functions
11725 were already external.
11727 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11728 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11729 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11730 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11731 * keyboard.c, keymap.c, lread.c:
11732 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11733 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11734 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11735 Mark functions with DEFUE instead of DEFUN,
11736 if they are used in other modules.
11737 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11738 decls for now-static functions.
11739 * buffer.h (Fdelete_overlay): Remove decl.
11740 * callproc.c (Fgetenv_internal): Mark as internal.
11741 * composite.c (Fremove_list_of_text_properties): Remove decl.
11742 (Fcomposition_get_gstring): New forward static decl.
11743 * composite.h (Fcomposite_get_gstring): Remove decl.
11744 * dired.c (Ffile_attributes): New forward static decl.
11745 * doc.c (Fdocumntation_property): New forward static decl.
11746 * eval.c (Ffetch_bytecode): New forward static decl.
11747 (Funintern): Remove extern decl; now in .h file where it belongs.
11748 * fileio.c (Fmake_symbolic_link): New forward static decl.
11749 * image.c (Finit_image_library): New forward static decl.
11750 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11751 * intervals.h (Fprevious_property_change):
11752 (Fremove_list_of_text_properties): Remove decls.
11753 * keyboard.c (Fthis_command_keys): Remove decl.
11754 (Fcommand_execute): New forward static decl.
11755 * keymap.c (Flookup_key): New forward static decl.
11756 (Fcopy_keymap): Now static.
11757 * keymap.h (Flookup_key): Remove decl.
11758 * process.c (Fget_process): New forward static decl.
11759 (Fprocess_datagram_address): Mark as internal.
11760 * syntax.c (Fsyntax_table_p): New forward static decl.
11761 (skip_chars): Remove duplicate decl.
11762 * textprop.c (Fprevious_property_change): New forward static decl.
11763 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11765 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11766 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11768 * editfns.c (Fformat): Remove unreachable code.
11770 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11772 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11775 2011-04-13 Eli Zaretskii <eliz@gnu.org>
11777 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11778 when at ZV. (Bug#8487)
11780 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11782 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11784 * keyboard.c (parse_tool_bar_item): Likewise.
11785 * sound.c (sound_cleanup, alsa_close): Likewise.
11786 * termcap.c (tgetent): Likewise.
11787 * xfns.c (x_default_font_parameter): Likewise.
11788 * xsettings.c (read_and_apply_settings): Likewise.
11790 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11791 (overrun_check_free): Protoize.
11793 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11795 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11796 since callers should never pass a negative size.
11797 Change the signature to match that of plain 'read' and 'write'; see
11798 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11799 * lisp.h: Update prototypes of emacs_write and emacs_read.
11801 2011-04-11 Eli Zaretskii <eliz@gnu.org>
11803 * xdisp.c (redisplay_window): Don't try to determine the character
11804 position of the scroll margin if the window start point w->startp
11805 is outside the buffer's accessible region. (Bug#8468)
11807 2011-04-10 Eli Zaretskii <eliz@gnu.org>
11809 Fix write-region and its subroutines for buffers > 2GB.
11810 * fileio.c (a_write, e_write): Modify declaration of arguments and
11811 local variables to support buffers larger than 2GB.
11812 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11814 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11815 argument, local variables, and return value.
11817 * lisp.h: Update prototypes of emacs_write and emacs_read.
11819 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11821 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
11823 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11825 Fix more problems found by GCC 4.6.0's static checks.
11827 * xdisp.c (vmessage): Use a better test for character truncation.
11829 * charset.c (load_charset_map): <, not <=, for optimization,
11830 and to avoid potential problems with integer overflow.
11831 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
11832 * casetab.c (set_identity, shuffle): Likewise.
11833 * editfns.c (Fformat): Likewise.
11834 * syntax.c (skip_chars): Likewise.
11836 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11837 This also lets GCC 4.6.0 generate slightly better loop code.
11839 * callint.c (Fcall_interactively): <, not <=, for optimization.
11840 (Fcall_interactively): Count the number of arguments produced,
11841 not the number of arguments given. This is simpler and lets GCC
11842 4.6.0 generate slightly better code.
11844 * ftfont.c: Distingish more carefully between FcChar8 and char.
11845 The previous code passed unsigned char * to a functions like
11846 strlen and xstrcasecmp that expect char *, which does not
11847 conform to the C standard.
11848 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11849 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11850 char * when the C standard requires it.
11852 * keyboard.c (read_char): Remove unused var.
11854 * eval.c: Port to Windows vsnprintf (Bug#8435).
11855 Include <limits.h>.
11856 (SIZE_MAX): Define if the headers do not.
11857 (verror): Do not give up if vsnprintf returns a negative count.
11858 Instead, grow the buffer. This ports to Windows vsnprintf, which
11859 does not conform to C99. Problem reported by Eli Zaretskii.
11860 Also, simplify the allocation scheme, by avoiding the need for
11861 calling realloc, and removing the ALLOCATED variable.
11863 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11865 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11866 But keep the doprint source code for now, as we might revamp it
11867 and use it again (Bug#8435).
11868 * lisp.h (doprnt): Remove.
11869 * Makefile.in (base_obj): Remove doprnt.o.
11870 * deps.mk (doprnt.o): Remove.
11872 error: Print 32- and 64-bit integers portably (Bug#8435).
11873 Without this change, on typical 64-bit hosts error ("...%d...", N)
11874 was used to print both 32- and 64-bit integers N, which relied on
11875 undefined behavior.
11876 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
11877 * lisp.h (error, verror): Mark as printf-like functions.
11878 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11879 Report overflow in size calculations when allocating printf buffer.
11880 Do not truncate output string at its first null byte.
11881 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11882 Truncate the output at a character boundary, since vsnprintf does not
11884 * charset.c (check_iso_charset_parameter): Convert internal
11885 character to string before calling 'error', since %c now has the
11887 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11888 overflow when computing char to be passed to 'error'. Do not
11889 pass Lisp_Object to 'error'; pass the integer instead.
11890 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11891 formatted with plain %d.
11893 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11895 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11897 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11899 * xterm.c (x_catch_errors): Remove duplicate declaration.
11901 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11903 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11905 2011-04-10 Jim Meyering <meyering@redhat.com>
11907 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11908 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11909 return ssize_t not "int", and use size_t as the buffer length.
11910 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11911 * gnutls.h: Update declarations.
11912 * process.c (read_process_output): Use ssize_t, to match.
11913 (send_process): Likewise.
11915 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
11917 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11919 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
11921 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11922 Use unsigned char, to match FcChar8 type definition.
11924 * xterm.c (handle_one_xevent):
11925 * xmenu.c (create_and_show_popup_menu):
11926 * xselect.c (x_decline_selection_request)
11927 (x_reply_selection_request): Avoid type-punned deref of X events.
11929 2011-04-09 Eli Zaretskii <eliz@gnu.org>
11931 Fix some uses of `int' instead of EMACS_INT.
11932 * search.c (string_match_1, fast_string_match)
11933 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11934 (scan_buffer, find_next_newline_no_quit)
11935 (find_before_next_newline, search_command, Freplace_match)
11936 (Fmatch_data): Make some `int' variables be EMACS_INT.
11938 * xdisp.c (display_count_lines): 3rd argument and return value now
11939 EMACS_INT. All callers changed.
11940 (pint2hrstr): Last argument is now EMACS_INT.
11942 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11943 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11944 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11945 (decode_coding_utf_16, decode_coding_emacs_mule)
11946 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11947 (decode_coding_ccl, decode_coding_charset)
11948 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11949 (decode_coding_iso_2022, decode_coding_emacs_mule)
11950 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11951 <char_offset, last_offset>: Declare EMACS_INT.
11952 (encode_coding_utf_8, encode_coding_utf_16)
11953 (encode_coding_emacs_mule, encode_invocation_designation)
11954 (encode_designation_at_bol, encode_coding_iso_2022)
11955 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11956 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11958 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11959 (encode_invocation_designation): Last argument P_NCHARS is now
11961 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11962 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11964 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11967 * ccl.c (Fccl_execute_on_string): Declare some variables
11970 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
11972 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11974 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11976 * process.c (Fformat_network_address): Doc fix.
11978 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11980 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
11982 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
11984 * keyboard.c (read_char): Call Lisp function help-form-show,
11985 instead of using internal_with_output_to_temp_buffer.
11986 (Qhelp_form_show): New var.
11987 (syms_of_keyboard): Use DEFSYM macro.
11989 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11991 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11993 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
11995 * process.c (Flist_processes): Remove to Lisp.
11996 (list_processes_1): Delete.
11998 2011-04-06 Eli Zaretskii <eliz@gnu.org>
12000 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12002 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12004 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
12006 Fix more problems found by GCC 4.6.0's static checks.
12008 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12010 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12012 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
12014 * xdisp.c (vmessage): Mark as a printf-like function.
12016 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12018 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12020 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12021 printf-like functions.
12022 (tiff_load): Add casts to remove these marks before passing them
12023 to system-supplied API.
12025 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12027 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12028 This avoids several warnings with gcc -Wstrict-overflow.
12029 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12030 directly, rather than having caller test rule sign. This avoids
12031 some unnecessary tests.
12032 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12033 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12034 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
12036 * xfont.c (xfont_text_extents): Remove var that was set but not used.
12037 (xfont_open): Avoid unnecessary tests.
12039 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12041 * composite.h, composite.c (composition_gstring_put_cache):
12042 Use EMACS_INT, not int, for length.
12044 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12045 breaking out part of COMPOSITION_DECODE_RULE.
12046 (COMPOSITION_DECODE_RULE): Use it.
12047 * composite.c (get_composition_id): Remove unused local vars,
12048 by using the new macro.
12050 * textprop.c (set_text_properties_1): Change while to do-while,
12051 since the condition is always true at first.
12053 * intervals.c (graft_intervals_into_buffer): Mark var as used.
12054 (interval_deletion_adjustment): Return unsigned value.
12057 * process.c (list_processes_1, create_pty, read_process_output):
12058 (exec_sentinel): Remove vars that were set but not used.
12059 (create_pty): Remove unnecessary "volatile"s.
12060 (Fnetwork_interface_info): Avoid possibility of int overflow.
12061 (read_process_output): Do adaptive read buffering even if carryover.
12062 (read_process_output): Simplify nbytes computation if buffered.
12064 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12066 * syntax.c (scan_words): Remove var that was set but not used.
12067 (update_syntax_table): Use unsigned instead of int.
12069 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
12070 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
12071 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
12073 * print.c (print_error_message): Avoid int overflow.
12075 * font.c (font_list_entities): Redo for clarity,
12076 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12078 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
12079 (font_score): Avoid potential overflow in diff calculation.
12081 * fns.c (substring_both): Remove var that is set but not used.
12082 (sxhash): Redo loop for clarity and to avoid wraparound warning.
12084 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12086 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12087 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12088 can always succeed if overflow has undefined behavior.
12090 * search.c (boyer_moore, wordify): Remove vars set but not used.
12091 (wordify): Omit three unnecessary tests.
12093 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12094 All callers changed. This avoids the need for an unused var.
12096 * casefiddle.c (casify_region): Remove var that is set but not used.
12098 * dired.c (file_name_completion): Remove var that is set but not used.
12100 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12102 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
12103 (Finsert_file_contents): Remove unnecessary code checking fd.
12105 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12106 Check for integer overflow on size calculations.
12108 * buffer.c (Fprevious_overlay_change): Remove var that is set
12111 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12112 Remove vars that are set but not used.
12113 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
12114 (timer_check_2): Mark vars as initialized.
12116 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12118 * image.c (lookup_image): Remove var that is set but not used.
12119 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
12121 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12122 that are set but not used.
12124 * xfns.c (make_invisible_cursor): Don't return garbage
12125 if XCreateBitmapFromData fails (Bug#8410).
12127 * xselect.c (x_get_local_selection, x_handle_property_notify):
12128 Remove vars that are set but not used.
12130 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
12131 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
12133 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12134 Remove var that is set but not used.
12135 (scroll_bar_windows_size): Now size_t, not int.
12136 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12137 Check for overflow.
12139 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12140 (map_tty_color) [!defined MSDOS]: Likewise.
12142 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12144 * coding.c: Remove vars that are set but not used.
12145 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12146 All callers changed.
12147 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12148 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12149 (decode_coding_charset): Remove vars that are set but not used.
12151 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12152 that is set but not used.
12154 * print.c (print_object): Remove var that is set but not used.
12156 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
12157 The gnulib version avoids calling malloc in the usual case,
12158 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12159 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12160 * filelock.c (current_lock_owner): Likewise.
12161 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12162 * sysdep.c: Include allocator.h, careadlinkat.h.
12163 (emacs_no_realloc_allocator): New static constant.
12164 (emacs_readlink): New function.
12165 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12166 ../lib/careadlinkat.h.
12168 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12170 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12171 first non-nil return value).
12173 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12175 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12176 if not defined (Bug#8403).
12178 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
12180 * xdisp.c (display_count_lines): Remove parameter `start',
12181 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12182 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12183 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12184 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12185 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12186 and thereabouts. All callers changed.
12187 (get_per_char_metric): Remove parameter `f', unused since
12188 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12190 2011-04-02 Jim Meyering <meyering@redhat.com>
12192 do not dereference NULL upon failed strdup
12193 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12194 (ns_get_family): Likewise.
12196 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
12198 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12200 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12202 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12205 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12207 Add lexical binding.
12209 * window.c (Ftemp_output_buffer_show): New fun.
12210 (Fsave_window_excursion):
12211 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12213 * lread.c (lisp_file_lexically_bound_p): New function.
12214 (Fload): Bind Qlexical_binding.
12215 (readevalloop): Remove `evalfun' arg.
12216 Bind Qinternal_interpreter_environment.
12217 (Feval_buffer): Bind Qlexical_binding.
12218 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12220 (syms_of_lread): Declare `lexical-binding'.
12222 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12224 * keyboard.c (eval_dyn): New fun.
12225 (menu_item_eval_property): Use it.
12227 * image.c (parse_image_spec): Use Ffunctionp.
12229 * fns.c (concat, mapcar1): Accept byte-code-functions.
12231 * eval.c (Fsetq): Handle lexical vars.
12232 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12233 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12234 (FletX, Flet): Obey lexical binding.
12235 (Fcommandp): Handle closures.
12236 (Feval): New `lexical' arg.
12237 (eval_sub): New function extracted from Feval. Use it almost
12238 everywhere where Feval was used. Look up vars in lexical env.
12240 (Ffunctionp): Move from subr.el.
12241 (Ffuncall): Handle closures.
12242 (apply_lambda): Remove `eval_flags'.
12243 (funcall_lambda): Handle closures and new byte-code-functions.
12244 (Fspecial_variable_p): New function.
12245 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12246 but without exporting it to Lisp.
12248 * doc.c (Fdocumentation, store_function_docstring):
12249 * data.c (Finteractive_form): Handle closures.
12251 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12254 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12256 (exec_byte_code): New function extracted from Fbyte_code to handle new
12257 calling convention for byte-code-functions. Add new byte-codes.
12259 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
12261 * alloc.c (Fmake_symbol): Init new `declared_special' field.
12263 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
12265 * xdisp.c (redisplay_internal): Fix prototype.
12267 2011-03-31 Eli Zaretskii <eliz@gnu.org>
12269 * xdisp.c (SCROLL_LIMIT): New macro.
12270 (try_scrolling): Use it when setting scroll_limit.
12271 Limit scrolling to 100 screen lines.
12272 (redisplay_window): Even when falling back on "recentering",
12273 position point in the window according to scroll-conservatively,
12274 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12276 (try_scrolling): When point is above the window, allow searching
12277 as far as scroll_max, or one screenful, to compute vertical
12278 distance from PT to the scroll margin position. This prevents
12279 try_scrolling from unnecessarily failing when
12280 scroll-conservatively is set to a value slightly larger than the
12281 window height. Clean up the case of PT below the margin at bottom
12282 of window: scroll_max can no longer be INT_MAX. When aggressive
12283 scrolling is in use, don't let point enter the opposite scroll
12284 margin as result of the scroll.
12285 (syms_of_xdisp) <scroll-conservatively>: Document the
12286 threshold of 100 lines for never-recentering scrolling.
12288 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
12290 * dispextern.h (move_it_by_lines):
12291 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12292 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12293 (message_log_check_duplicate): Remove parameters `prev_bol' and
12294 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12295 (redisplay_internal): Remove parameter `preserve_echo_area',
12296 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12298 * indent.c (Fvertical_motion):
12299 * window.c (window_scroll_pixel_based, Frecenter):
12300 Don't pass `need_y_p' to `move_it_by_lines'.
12302 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12304 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12305 steal a few bits to be more compact.
12306 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12307 Remove unneeded casts.
12309 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12311 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12313 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12314 binding" message (bug#7967).
12316 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12318 Fix more problems found by GCC 4.6.0's static checks.
12320 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12321 Remove unused local var.
12323 * editfns.c (Fmessage_box): Remove unused local var.
12325 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12326 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12327 Omit unused local vars.
12328 * window.c (shrink_windows): Omit unused local var.
12329 * menu.c (digest_single_submenu): Omit unused local var.
12330 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12331 Omit unused local var.
12333 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12334 Don't assume string length fits in int.
12335 (keyremap_step, read_key_sequence): Use size_t for sizes.
12336 (read_key_sequence): Don't check last_real_key_start redundantly.
12338 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12339 instead of alloca (Bug#8344).
12341 * eval.c (Fbacktrace): Don't assume nargs fits in int.
12342 (Fbacktrace_frame): Don't assume nframes fits in int.
12344 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12346 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12349 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12351 * cm.c (calccost): Turn while-do into do-while, for clarity.
12353 * keyboard.c (syms_of_keyboard): Use the same style as later
12354 in this function when indexing through an array. This also
12355 works around GCC bug 48267.
12357 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12359 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12361 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12362 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12364 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12365 This avoids undefined behavior on integer overflow, and is a bit
12366 more convenient anyway since it is compared to a size_t variable.
12368 Variadic C functions now count arguments with size_t, not int.
12369 This avoids an unnecessary limitation on 64-bit machines, which
12370 caused (substring ...) to crash on large vectors (Bug#8344).
12371 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12372 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
12373 All variadic functions and their callers changed accordingly.
12374 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12375 * data.c (arith_driver, float_arith_driver): Likewise.
12376 * editfns.c (general_insert_function): Likewise.
12377 * eval.c (struct backtrace.nargs, interactive_p)
12378 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12379 (funcall_lambda, mark_backtrace): Likewise.
12380 * fns.c (concat): Likewise.
12381 * frame.c (x_set_frame_parameters): Likewise.
12382 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12383 0 if not found, not -1. All callers changed.
12385 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12386 (stack_copy_size): Now size_t, not int.
12387 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12389 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
12391 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12392 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12393 All callers changed.
12395 * lisp.h (multibyte_char_to_unibyte):
12396 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12397 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12398 * character.h (CHAR_TO_BYTE8):
12399 * cmds.c (internal_self_insert):
12400 * editfns.c (general_insert_function):
12401 * keymap.c (push_key_description):
12402 * search.c (Freplace_match):
12403 * xdisp.c (message_dolog, set_message_1): All callers changed.
12405 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12407 * keyboard.c (safe_run_hook_funcall): New function.
12408 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12409 don't set the hook to nil, but remove the offending function instead.
12410 (Qcommand_hook_internal): Remove, unused.
12411 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12412 Vcommand_hook_internal.
12414 * eval.c (enum run_hooks_condition): Remove.
12415 (funcall_nil, funcall_not): New functions.
12416 (run_hook_with_args): Call each function through a `funcall' argument.
12417 Remove `cond' argument, now redundant.
12418 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12419 (Frun_hook_with_args_until_failure): Adjust accordingly.
12420 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12422 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
12424 * dispextern.h (string_buffer_position): Remove declaration.
12426 * print.c (strout): Remove parameter `multibyte', unused since
12427 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12429 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12430 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12431 All callers changed.
12433 * w32.c (_wsa_errlist): Use braces for struct initializers.
12435 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12436 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12437 All callers changed.
12438 (string_buffer_position): Likewise. Also, make static (it's never
12439 used outside xdisp.c).
12440 (cursor_row_p): Remove parameter `w', unused since
12441 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12442 (decode_mode_spec): Remove parameter `precision', introduced during
12443 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12444 All callers changed.
12446 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12448 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12450 2011-03-27 Anders Lindgren <andlind@gmail.com>
12452 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12453 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12454 (ns_update_auto_hide_menu_bar): New functions.
12455 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12456 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12457 ns_constrain_all_frames.
12458 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12459 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12461 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12463 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12465 2011-03-27 Glenn Morris <rgm@gnu.org>
12467 * syssignal.h: Replace RETSIGTYPE with void.
12468 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12469 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12470 Replace SIGTYPE with void everywhere.
12471 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12472 * s/template.h (SIGTYPE): Remove commented out definition.
12474 2011-03-26 Eli Zaretskii <eliz@gnu.org>
12476 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12477 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12479 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
12481 * w32.c (read_unc_volume): Use parameter `henum', instead of
12482 global variable `wget_enum_handle'.
12484 * keymap.c (describe_vector): Remove parameters `indices' and
12485 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12486 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12488 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12490 * keyboard.c (timer_check): Remove parameter `do_it_now',
12491 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12492 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12493 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12495 * keyboard.c (read_char):
12496 * w32menu.c (w32_menu_display_help):
12497 * xmenu.c (show_help_event, menu_help_callback):
12498 Adjust calls to `show_help_echo'.
12500 * gtkutil.c (xg_maybe_add_timer):
12501 * keyboard.c (readable_events):
12502 * process.c (wait_reading_process_output):
12503 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12505 * insdel.c (adjust_markers_gap_motion):
12506 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12507 (gap_left, gap_right): Don't call it.
12509 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
12511 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12512 incurred during fontification.
12514 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12516 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12517 (DEFVAR_PER_BUFFER): Don't pass it.
12519 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12520 (scrolling_window): Don't pass it.
12522 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12524 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12526 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12528 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12529 of variables specific to SELinux and computation of `encoded_absname'.
12531 * image.c (XPutPixel): Remove unused variable `height'.
12533 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12535 * unexw32.c (get_section_info): Remove unused variable `section'.
12537 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12538 (system_process_attributes): Remove unused variable `sess'.
12539 (sys_read): Remove unused variable `err'.
12541 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12542 (w32_wnd_proc): Remove unused variable `isdead'.
12543 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12544 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12545 (x_create_tip_frame): Remove unused variable `tem'.
12547 * w32inevt.c (w32_console_read_socket):
12548 Remove unused variable `no_events'.
12550 * w32term.c (x_draw_composite_glyph_string_foreground):
12551 Remove unused variable `width'.
12553 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
12555 * w32term.c (x_set_glyph_string_clipping):
12556 Don't pass uninitialized region to CombineRgn.
12558 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
12560 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12561 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12562 (Fx_close_connection): Remove unused variable `i'.
12564 * w32font.c (w32font_draw): Return number of glyphs.
12565 (w32font_open_internal): Remove unused variable `i'.
12566 (w32font_driver): Add missing initializer.
12568 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12569 (fill_in_menu): Remove unused variable `items_added'.
12571 * w32term.c (last_mouse_press_frame): Remove static global variable.
12572 (w32_clip_to_row): Remove unused variable `f'.
12573 (x_delete_terminal): Remove unused variable `i'.
12575 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12576 (NOTHING): Remove unused static global variable.
12577 (uniscribe_check_otf): Remove unused variable `table'.
12578 (uniscribe_font_driver): Add missing initializers.
12580 2011-03-23 Julien Danjou <julien@danjou.info>
12582 * term.c (Fsuspend_tty, Fresume_tty):
12583 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12584 * window.c (temp_output_buffer_show):
12585 * insdel.c (signal_before_change):
12586 * frame.c (Fhandle_switch_frame):
12587 * fileio.c (Fdo_auto_save):
12588 * emacs.c (Fkill_emacs):
12589 * editfns.c (save_excursion_restore):
12590 * cmds.c (internal_self_insert):
12591 * callint.c (Fcall_interactively):
12592 * buffer.c (Fkill_all_local_variables):
12593 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12595 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
12596 unconditionally since it does the check itself.
12598 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
12600 Fix more problems found by GCC 4.5.2's static checks.
12602 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12603 the first time through the loop, since we know p0 < p1 then.
12604 This also avoids a gcc -Wstrict-overflow warning.
12606 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12607 leading to a memory leak, possible in functions like
12608 load_charset_map_from_file that can allocate an unbounded number
12609 of objects (Bug#8318).
12611 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12612 that could (at least in theory) be that large.
12614 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12615 This is less likely to overflow, and avoids undefined behavior if
12616 overflow does occur. All callers changed. Use strtoul to scan
12617 for the unsigned long integer.
12618 (pint2hrstr): Simplify and tune code slightly.
12619 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
12621 * scroll.c (do_scrolling): Work around GCC bug 48228.
12622 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12624 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12625 This also avoids a warning with gcc -Wstrict-overflow.
12626 (validate_x_resource_name): Simplify count usage.
12627 This also avoids a warning with gcc -Wstrict-overflow.
12629 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12632 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
12634 * process.c (Fmake_network_process): Use socklen_t, not int,
12635 where POSIX says socklen_t is required in portable programs.
12636 This fixes a porting bug on hosts like 64-bit HP-UX, where
12637 socklen_t is wider than int (Bug#8277).
12638 (Fmake_network_process, server_accept_connection):
12639 (wait_reading_process_output, read_process_output):
12642 * process.c: Rename or move locals to avoid shadowing.
12643 (list_processes_1, Fmake_network_process):
12644 (read_process_output_error_handler, exec_sentinel_error_handler):
12645 Rename or move locals.
12646 (Fmake_network_process): Define label "retry_connect" only if needed.
12647 (Fnetwork_interface_info): Fix pointer signedness.
12648 (process_send_signal): Add cast to avoid pointer signedness problem.
12649 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
12650 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
12652 Make tparam.h and terminfo.c consistent.
12653 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12654 Include tparam.h instead, since it declares them.
12655 * cm.h (PC): Remove extern decl; tparam.h now does this.
12656 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12657 * terminfo.c: Include tparam.h, to check interfaces.
12658 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12659 (tparam): Adjust signature to match interface in tparam.h;
12660 this removes some undefined behavior. Check that outstring and len
12661 are zero, which they always are with Emacs.
12662 * tparam.h (PC, BC, UP): New extern decls.
12664 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
12665 (xftfont_open): Rename locals to avoid shadowing.
12667 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
12668 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12669 (OTF_TAG_SYM): Omit macro if not needed.
12670 (ftfont_list): Remove unused local.
12671 (get_adstyle_property, ftfont_pattern_entity):
12672 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12673 Rename locals to avoid shadowing.
12675 * xfont.c (xfont_list_family): Mark var as initialized.
12677 * xml.c (make_dom): Now static.
12679 * composite.c (composition_compute_stop_pos): Rename local to
12681 (composition_reseat_it): Remove unused locals.
12682 (find_automatic_composition, composition_adjust_point): Likewise.
12683 (composition_update_it): Mark var as initialized.
12684 (find_automatic_composition): Mark vars as initialized,
12685 with a FIXME (Bug#8290).
12687 character.h: Rename locals to avoid shadowing.
12688 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12689 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12690 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12691 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12692 to avoid shadowing.
12694 * textprop.c (property_change_between_p): Remove; unused.
12696 * intervals.c (interval_start_pos): Now static.
12698 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12700 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12701 Rename locals to avoid shadowing.
12703 * sound.c (wav_play, au_play, Fplay_sound_internal):
12704 Fix pointer signedness.
12705 (alsa_choose_format): Remove unused local var.
12706 (wav_play): Initialize a variable to 0, to prevent undefined
12707 behavior (Bug#8278).
12709 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12711 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12713 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12714 clobbering (Bug#8298).
12715 * sysdep.c (sys_subshell): Likewise.
12716 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
12718 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12719 This should get cleaned up, so that child_setup has the
12720 same signature on all platforms.
12722 * callproc.c (call_process_cleanup): Now static.
12723 (relocate_fd): Rename locals to avoid shadowing.
12725 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
12727 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12728 not to be necessary, and produces flickering.
12730 2011-03-20 Glenn Morris <rgm@gnu.org>
12732 * config.in: Remove file.
12734 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
12736 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12737 are now in src/globals.h.
12738 (syms_of_minibuf): Remove spurious & from previous change.
12740 2011-03-20 Leo Liu <sdl.web@gmail.com>
12742 * minibuf.c (completing-read-function): New variable.
12743 (completing-read-default): Rename from completing-read.
12744 (completing-read): Call completing-read-function.
12746 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
12748 * xfaces.c (Fx_load_color_file):
12749 Read color file from absolute filename (bug#8250).
12751 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
12753 * makefile.w32-in: Update dependencies.
12755 2011-03-17 Eli Zaretskii <eliz@gnu.org>
12757 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12759 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12761 Fix more problems found by GCC 4.5.2's static checks.
12763 * process.c (make_serial_process_unwind, send_process_trap):
12764 (sigchld_handler): Now static.
12766 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12767 That way, the code declares only the vars that it needs.
12768 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12769 * s/cygwin.h (PTY_ITERATION): Likewise.
12770 * s/darwin.h (PTY_ITERATION): Likewise.
12771 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12773 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12774 * process.c (allocate_pty): Don't declare stb unless it's needed.
12776 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
12777 (CONSTANTLIM): Remove; unused.
12778 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12779 Define only if needed.
12781 * unexelf.c (unexec): Name an expression,
12782 to avoid gcc -Wbad-function-cast warning.
12783 Use a different way to cause a compilation error if anyone uses
12784 n rather than nn, a way that does not involve shadowing.
12785 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
12787 * deps.mk (unexalpha.o): Remove; unused.
12789 New file unexec.h, the (simple) interface for unexec (Bug#8267).
12790 * unexec.h: New file.
12791 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12792 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12793 Depend on unexec.h.
12794 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12795 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12796 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
12797 Change as necessary to match prototype in unexec.h.
12799 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12801 (back_comment, skip_chars): Mark vars as initialized.
12803 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12804 Rename locals to avoid shadowing.
12806 * lread.c (read1): Rewrite so as not to use empty "else".
12807 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
12809 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12811 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12812 warning when compiling print.c.
12814 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12815 instead of using an uninitialized var.
12816 (font_sort_entities): Mark var as initialized.
12818 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12820 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12821 pointers to constants.
12822 (font_parse_fcname): Remove unused vars.
12823 (font_delete_unmatched): Now static.
12824 (font_get_spec): Remove; unused.
12825 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12826 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12827 Rename or move locals to avoid shadowing.
12829 * fns.c (require_nesting_list, require_unwind): Now static.
12830 (Ffillarray): Rename locals to avoid shadowing.
12832 * floatfns.c (domain_error2): Define only if needed.
12833 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
12835 * alloc.c (mark_backtrace): Move decl from here ...
12836 * lisp.h: ... to here, so that it can be checked.
12838 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
12839 (Fdefvar): Rewrite so as not to use empty "else".
12840 (lisp_indirect_variable): Name an expression,
12841 to avoid gcc -Wbad-function-cast warning.
12842 (Fdefvar): Rename locals to avoid shadowing.
12844 * callint.c (quotify_arg, quotify_args): Now static.
12845 (Fcall_interactively): Rename locals to avoid shadowing.
12846 Use const pointer when appropriate.
12848 * lisp.h (get_system_name, get_operating_system_release):
12849 Move decls here, to check interfaces.
12850 * process.c (get_operating_system_release): Move decl to lisp.h.
12851 * xrdb.c (get_system_name): Likewise.
12852 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12853 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12854 some of which prompt warnings from gcc -Wbad-function-cast.
12855 (Fformat_time_string, Fencode_time, Finsert_char):
12856 (Ftranslate_region_internal, Fformat):
12857 Rename or remove local vars to avoid shadowing.
12858 (Ftranslate_region_internal): Mark var as initialized.
12860 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12863 * lisp.h (eassert): Check that the argument compiles, even if
12864 ENABLE_CHECKING is not defined.
12866 * data.c (Findirect_variable): Name an expression, to avoid
12867 gcc -Wbad-function-cast warning.
12868 (default_value, arithcompare, arith_driver, arith_error): Now static.
12869 (store_symval_forwarding): Rename local to avoid shadowing.
12870 (Fmake_variable_buffer_local, Fmake_local_variable):
12871 Mark variables as initialized.
12872 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
12874 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
12875 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12876 Rename locals to avoid shadowing.
12877 (mark_stack): Move local variables into the #ifdef region where
12879 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12880 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12882 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12883 (GC_STRING_CHARS): Remove; not used.
12884 (Fmemory_limit): Cast sbrk's returned value to char *.
12886 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12887 avoids undefined behavior in theory.
12889 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12891 Use functions, not macros, for up- and down-casing (Bug#8254).
12892 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12893 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12894 to use the following functions instead of these macros.
12895 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12896 EMACS_INT, since callers assume the returned value fits in int.
12897 (upcase1): Likewise, for UPCASE_TABLE.
12898 (uppercasep, lowercasep, upcase): New static inline functions.
12899 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
12900 the race-condition problem in the old DOWNCASE.
12902 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12903 Rename locals to avoid shadowing.
12904 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
12905 (regex_compile, re_search_2, re_match_2_internal):
12906 Remove unused local vars.
12907 (FREE_VAR): Rewrite so as not to use empty "else",
12908 which gcc can warn about.
12909 (regex_compile, re_match_2_internal): Mark locals as initialized.
12910 (RETALLOC_IF): Define only if needed.
12911 (WORDCHAR_P): Likewise. This one is never needed, but is used
12912 only in a comment talking about a compiler bug, so put inside
12913 the #if 0 of that comment.
12914 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12915 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12918 * search.c (boyer_moore): Rename locals to avoid shadowing.
12919 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12920 (PREV_CHAR_BOUNDARY): Likewise.
12922 * search.c (simple_search): Remove unused var.
12924 * dired.c (compile_pattern): Move decl from here ...
12925 * lisp.h: ... to here, so that it can be checked.
12926 (struct re_registers): New forward decl.
12928 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12930 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12932 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12933 Rename locals to avoid shadowing.
12934 (Fvertical_motion): Mark locals as initialized.
12936 * casefiddle.c (casify_object, casify_region): Now static.
12937 (casify_region): Mark local as initialized.
12939 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12941 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12942 New macros, so that the caller can use some names other than
12943 gcpro1, gcpro2, etc.
12944 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12946 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12947 argument, for consistency with GCPRO2_VAR, etc: it is now the
12948 prefix of the variable, not the variable itself. All uses
12950 * dired.c (directory_files_internal, file_name_completion):
12951 Rename locals to avoid shadowing.
12953 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12954 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12955 dired.c's scmp function, had undefined behavior.
12956 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12957 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12958 * buffer.h: ... to here, because these macros use current_buffer,
12959 and the new implementation with inline functions needs to have
12960 current_buffer in scope now, rather than later when the macros
12962 (downcase, upcase1): New static inline functions.
12963 (DOWNCASE, UPCASE1): Reimplement using these functions.
12964 This avoids undefined behavior in expressions like
12965 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12966 from race conditions in accessing the global variables
12967 case_temp1 and case_temp2.
12968 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12969 * lisp.h (case_temp1, case_temp2): Remove their decls.
12970 * character.h (ASCII_CHAR_P): Move from here ...
12971 * lisp.h: ... to here, so that the inline functions mentioned
12972 above can use them.
12974 * dired.c (directory_files_internal_unwind): Now static.
12976 * fileio.c (file_name_as_directory, directory_file_name):
12977 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12979 (file_name_as_directory): Use const pointers when appropriate.
12980 (Fexpand_file_name): Likewise. In particular, newdir might
12981 point at constant storage, so make it a const pointer.
12982 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
12983 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12985 (Fset_file_times, Finsert_file_contents, auto_save_error):
12986 Rename locals to avoid shadowing.
12988 * minibuf.c (choose_minibuf_frame_1): Now static.
12989 (Ftry_completion, Fall_completions): Rename or remove locals
12990 to avoid shadowing.
12992 * marker.c (bytepos_to_charpos): Remove; unused.
12994 * lisp.h (verify_bytepos, count_markers): New decls,
12995 so that gcc does not warn that these functions aren't declared.
12997 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12998 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
12999 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
13000 (copy_text): Remove unused local var.
13002 * filelock.c (within_one_second): Now static.
13003 (lock_file_1): Rename local to avoid shadowing.
13005 * buffer.c (fix_overlays_before): Mark locals as initialized.
13006 (fix_start_end_in_overlays): Likewise. This function should be
13007 simplified by using pointers-to-pointers, but that's a different
13009 (switch_to_buffer_1): Now static.
13010 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13011 (report_overlay_modification): Rename locals to avoid shadowing.
13013 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
13014 Fix pointer signedness issue.
13015 (sys_subshell): Mark local as volatile if checking for lint,
13016 to suppress a gcc -Wclobbered warning that does not seem to be right.
13017 (MAXPATHLEN): Define only if needed.
13019 * process.c (serial_open, serial_configure): Move decls from here ...
13020 * systty.h: ... to here, so that they can be checked.
13022 * fns.c (get_random, seed_random): Move extern decls from here ...
13023 * lisp.h: ... to here, so that they can be checked.
13025 * sysdep.c (reset_io): Now static.
13026 (wait_for_termination_signal): Remove; unused.
13028 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13029 (copy_keymap_item, append_key, push_text_char_description):
13031 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
13032 (DENSE_TABLE_SIZE): Remove; unused.
13033 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13034 (describe_map_tree):
13035 Rename locals to avoid shadowing.
13037 * keyboard.c: Declare functions static if they are not used elsewhere.
13038 (echo_char, echo_dash, cmd_error, top_level_2):
13039 (poll_for_input, handle_async_input): Now static.
13040 (read_char, kbd_buffer_get_event, make_lispy_position):
13041 (make_lispy_event, make_lispy_movement, apply_modifiers):
13042 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13043 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13044 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
13045 (read_key_sequence, read_char): Mark locals as initialized.
13046 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
13048 * keyboard.h (make_ctrl_char): New decl.
13049 (mark_kboards): Move decl here ...
13050 * alloc.c (mark_kboards): ... from here.
13052 * lisp.h (force_auto_save_soon): New decl.
13054 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
13055 (DEFINE_DUMMY_FUNCTION): New macro.
13056 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13058 (main): Add casts to avoid warnings
13059 if GCC considers string literals to be constants.
13061 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13063 * dbusbind.c: Pointer signedness fixes.
13064 (xd_signature, xd_append_arg, xd_initialize):
13065 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13066 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13067 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13068 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13070 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13071 if GCC considers string literals to be constants.
13072 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
13074 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13076 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13077 (print_preprocess, print_object): New macro to fix last change.
13079 * print.c (print_preprocess): Don't forget font objects.
13081 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
13083 * emacs.c (USAGE3): Doc fixes.
13085 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13087 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13090 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
13092 * lisp.h (VWindow_system, Qfile_name_history):
13093 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13094 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13095 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13097 * w32select.c: Don't #include "keyboard.h".
13098 (run_protected): Add extern declaration for waiting_for_input.
13100 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13101 * w32console.c (detect_input_pending, read_input_pending)
13102 (encode_terminal_code):
13103 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13104 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13105 (w32_system_caret_y, Qfile_name_history):
13106 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13107 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13108 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13109 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13110 * w32proc.c (Qlocal, report_file_error):
13111 * w32term.c (Vwindow_system, updating_frame):
13112 * w32uniscribe.c (initialized, uniscribe_font_driver):
13113 Remove unneeded extern declarations.
13115 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
13117 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
13119 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
13121 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13122 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13123 These macros can no longer be used for assignment.
13125 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13126 Assign struct members directly, instead of using BUF_BEGV etc.
13127 (record_buffer_markers, fetch_buffer_markers): New functions for
13128 recording and fetching special buffer markers.
13129 (set_buffer_internal_1, set_buffer_temp): Use them.
13131 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13133 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13135 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13136 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13138 * xdisp.c (hscroll_window_tree):
13139 (reconsider_clip_changes): Use PT instead of BUF_PT.
13141 2011-03-13 Eli Zaretskii <eliz@gnu.org>
13143 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13144 $(EMACS_ROOT)/lib/intprops.h.
13146 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13148 Fix more problems found by GCC 4.5.2's static checks.
13150 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13151 to unsigned char * to avoid compiler diagnostic.
13152 (xg_free_frame_widgets): Make it clear that a local variable is
13153 needed only if USE_GTK_TOOLTIP.
13154 (gdk_window_get_screen): Make it clear that this macro is needed
13155 only if USE_GTK_TOOLTIP.
13156 (int_gtk_range_get_value): New function, which avoids a diagnostic
13157 from gcc -Wbad-function-cast.
13158 (xg_set_toolkit_scroll_bar_thumb): Use it.
13159 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13160 diagnostic from gcc -Wbad-function-cast.
13161 (get_utf8_string, xg_get_file_with_chooser):
13162 Rename locals to avoid shadowing.
13163 (create_dialog): Move locals to avoid shadowing.
13165 * xgselect.c (xg_select): Remove unused var.
13167 * image.c (four_corners_best): Mark locals as initialized.
13168 (gif_load): Initialize transparent_p to zero (Bug#8238).
13169 Mark another local as initialized.
13170 (my_png_error, my_error_exit): Mark with NO_RETURN.
13172 * image.c (clear_image_cache): Now static.
13173 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
13174 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
13175 (x_edge_detection): Remove unnecessary cast that
13176 gcc -Wbad-function-cast diagnoses.
13177 (gif_load): Fix pointer signedness.
13178 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13179 (jpeg_load, gif_load): Rename locals to avoid shadowing.
13181 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
13183 Improve quality of tests for time stamp overflow.
13184 For example, without this patch (encode-time 0 0 0 1 1
13185 1152921504606846976) returns the obviously-bogus value (-948597
13186 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13187 reports time overflow. See
13188 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
13189 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13190 * editfns.c: Include limits.h and intprops.h.
13191 (TIME_T_MIN, TIME_T_MAX): New macros.
13192 (time_overflow): Move earlier, to before first use.
13193 (hi_time, lo_time): New functions, for an accurate test for
13194 out-of-range times.
13195 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13196 (Fget_internal_run_time): Don't assume time_t fits in int.
13197 (make_time): Use list2 instead of Fcons twice.
13198 (Fdecode_time): More accurate test for out-of-range times.
13199 (check_tm_member): New function.
13200 (Fencode_time): Use it, to test for out-of-range times.
13201 (lisp_time_argument): Don't rely on undefined left-shift and
13202 right-shift behavior when checking for time stamp overflow.
13204 * editfns.c (time_overflow): New function, refactoring common code.
13205 (Fformat_time_string, Fdecode_time, Fencode_time):
13206 (Fcurrent_time_string): Use it.
13208 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13209 * dired.c (make_time): Move to ...
13210 * editfns.c (make_time): ... here.
13211 * systime.h: Note the move.
13213 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
13215 * fringe.c (update_window_fringes): Remove unused variables.
13217 * unexmacosx.c (copy_data_segment): Also copy __got section.
13220 2011-03-12 Eli Zaretskii <eliz@gnu.org>
13222 * termcap.c [MSDOS]: Include "msdos.h".
13223 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13224 Constify `char *' arguments and their references according to
13225 prototypes in tparam.h.
13227 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
13229 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13230 Adapt all references accordingly.
13232 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13234 2011-03-11 Tom Tromey <tromey@redhat.com>
13236 * buffer.c (syms_of_buffer): Remove obsolete comment.
13238 2011-03-11 Eli Zaretskii <eliz@gnu.org>
13240 * termhooks.h (encode_terminal_code): Declare prototype.
13242 * msdos.c (encode_terminal_code): Don't declare prototype.
13244 * term.c (encode_terminal_code): Now external again, used by
13245 w32console.c and msdos.c.
13247 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13248 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
13250 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
13252 Fix some minor problems found by GCC 4.5.2's static checks.
13254 * fringe.c (update_window_fringes): Mark locals as initialized
13256 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
13258 * alloc.c (mark_fringe_data): Move decl from here ...
13259 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13260 to check its interface.
13261 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13263 * fontset.c (free_realized_fontset): Now static.
13264 (Fset_fontset_font): Rename local to avoid shadowing.
13265 (fontset_font): Mark local as initialized.
13266 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
13268 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13270 * xselect.c (x_disown_buffer_selections): Remove; not used.
13271 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
13272 (x_own_selection, Fx_disown_selection_internal): Rename locals
13273 to avoid shadowing.
13274 (x_handle_dnd_message): Remove local to avoid shadowing.
13276 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13277 so that the caller can use some name other than gcpro1.
13278 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
13279 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13280 (Fx_backspace_delete_keys_p):
13281 Use them to avoid shadowing, and rename vars to avoid shadowing.
13282 (x_decode_color, x_set_name, x_window): Now static.
13283 (Fx_create_frame): Add braces to silence GCC warning.
13284 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
13285 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13286 Remove unused locals.
13287 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13288 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13289 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13292 * xterm.h (x_mouse_leave): New decl.
13294 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13295 Remove unused functions.
13296 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13297 (x_calc_absolute_position): Now static.
13298 (XTread_socket): Don't define label "out" unless it's used.
13299 Don't declare local "event" unless it's used.
13300 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13301 unless they are used.
13302 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13303 (x_fatal_error_signal): Remove; not used.
13304 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13305 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13306 (x_error_catcher, x_connection_closed, x_error_handler):
13307 (x_error_quitter, xembed_send_message, x_iconify_frame):
13308 (my_log_handler): Rename locals to avoid shadowing.
13309 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
13310 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
13312 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13313 Rename or move locals to avoid shadowing.
13314 (tty_defined_color, merge_face_heights): Now static.
13315 (free_realized_faces_for_fontset): Remove; not used.
13316 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13317 does not deduce is never used uninitialized.
13318 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13319 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
13321 * terminal.c (store_terminal_param): Now static.
13323 * xmenu.c (menu_highlight_callback): Now static.
13324 (set_frame_menubar): Remove unused local.
13325 (xmenu_show): Rename parameter to avoid shadowing.
13326 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13327 since they might point to immutable storage.
13328 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13329 since it's unused otherwise.
13331 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
13332 Add a FIXME, since the code still doesn't look right. (Bug#8215)
13333 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13334 avoids a gcc -Wuninitialized diagnostic.
13335 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
13336 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13337 does not deduce are never used uninitialized.
13339 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13341 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
13342 * window.c (window_loop, size_window):
13343 (run_window_configuration_change_hook, enlarge_window): Likewise.
13345 * window.c (display_buffer): Now static.
13346 (size_window): Mark variables that gcc -Wuninitialized
13347 does not deduce are never used uninitialized.
13348 * window.h (check_all_windows): New decl, to forestall
13349 gcc -Wmissing-prototypes diagnostic.
13350 * dispextern.h (bidi_dump_cached_states): Likewise.
13352 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13354 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
13355 Include <limits.h>.
13356 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13357 and to avoid gcc -Wuninitialized warning.
13358 (load_charset_map): Mark variables that gcc -Wuninitialized
13359 does not deduce are never used uninitialized.
13360 (load_charset): Abort instead of using uninitialized var (Bug#8229).
13362 * coding.c (coding_set_source, coding_set_destination):
13363 Use "else { /* comment */ }" rather than "else /* comment */;"
13364 for clarity, and to avoid gcc -Wempty-body warning.
13365 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13366 a block, when the outer 'i' will do.
13367 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13368 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13369 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13370 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13371 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13372 Rename locals to avoid shadowing.
13373 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
13374 * coding.c (emacs_mule_char, encode_invocation_designation):
13375 Now static, since they're not used elsewhere.
13376 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
13377 (decode_coding_object, encode_coding_object, detect_coding_system):
13378 (decode_coding_emacs_mule): Mark variables that gcc
13379 -Wuninitialized does not deduce are never used uninitialized.
13380 (detect_coding_iso_2022): Initialize a local variable that might
13381 be used uninitialized. Leave a FIXME because it's not clear that
13382 this initialization is needed. (Bug#8211)
13383 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13384 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13385 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13386 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13387 Remove unused macros.
13389 * category.c (hash_get_category_set): Remove unused local var.
13390 (copy_category_table): Now static, since it's not used elsewhere.
13391 * character.c (string_count_byte8): Likewise.
13393 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13394 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13396 * chartab.c (copy_sub_char_table): Now static, since it's not used
13398 (sub_char_table_ref_and_range, char_table_ref_and_range):
13399 Rename locals to avoid shadowing.
13400 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
13402 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
13403 (BIDI_BOB): Remove unused macro.
13405 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13406 deduce are never used uninitialized.
13407 * term.c (encode_terminal_code): Likewise.
13409 * term.c (encode_terminal_code): Now static. Remove unused local.
13411 * tparam.h: New file.
13412 * term.c, tparam.h: Include it.
13413 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13414 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13415 Move these decls to tparam.h, and make them agree with what
13416 is actually in tparam.c. The previous trick of using incompatible
13417 decls in different modules does not conform to the C standard.
13418 All callers of tparam changed to use tparam's actual API.
13419 * tparam.c (tparam1, tparam, tgoto):
13420 Use const pointers where appropriate.
13422 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13423 * cm.h (struct cm): Likewise.
13424 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13425 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13426 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13427 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13428 (turn_on_face, init_tty): Likewise.
13429 * termchar.h (struct tty_display_info): Likewise.
13431 * term.c (term_mouse_position): Rename local to avoid shadowing.
13433 * alloc.c (mark_ttys): Move decl from here ...
13434 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13436 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13438 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13440 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
13442 * search.c (compile_pattern_1): Remove argument regp, unused since
13443 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13444 (compile_pattern): Don't pass it.
13446 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13448 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13449 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13451 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13453 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13455 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13456 gdk_window_get_screen, gdk_window_get_geometry,
13457 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13458 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13459 (xg_get_pixbuf_from_pixmap): New function.
13460 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13461 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13462 Call xg_get_pixbuf_from_pixmap instead of
13463 gdk_pixbuf_get_from_drawable.
13464 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13465 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13466 (xg_check_special_colors): Use GtkStyleContext and its functions
13468 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13469 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13470 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
13471 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13472 Call gtk_widget_get_preferred_size.
13473 (xg_frame_resized): gdk_window_get_geometry only takes 5
13475 (xg_win_to_widget, xg_event_is_for_menubar):
13476 Call gdk_x11_window_lookup_for_display.
13477 (xg_set_widget_bg): New function.
13478 (delete_cb): New function.
13479 (xg_create_frame_widgets): Connect delete-event to delete_cb.
13480 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
13481 (xg_set_background_color): Call xg_set_widget_bg.
13482 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13483 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13484 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13485 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13487 (update_frame_tool_bar): Call gtk_widget_hide.
13488 (xg_initialize): Use GDK_KEY_g.
13490 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13492 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13494 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13495 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13496 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13498 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
13500 * w32xfns.c (select_palette): Check success of RealizePalette against
13501 GDI_ERROR, not zero.
13503 See ChangeLog.11 for earlier changes.
13505 ;; Local Variables:
13509 Copyright (C) 2011-2012 Free Software Foundation, Inc.
13511 This file is part of GNU Emacs.
13513 GNU Emacs is free software: you can redistribute it and/or modify
13514 it under the terms of the GNU General Public License as published by
13515 the Free Software Foundation, either version 3 of the License, or
13516 (at your option) any later version.
13518 GNU Emacs is distributed in the hope that it will be useful,
13519 but WITHOUT ANY WARRANTY; without even the implied warranty of
13520 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13521 GNU General Public License for more details.
13523 You should have received a copy of the GNU General Public License
13524 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.