1 2012-07-10 Paul Eggert <eggert@cs.ucla.edu>
3 Simplify by avoiding confusing use of strncpy etc.
4 * doc.c (Fsnarf_documentation):
5 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
6 * frame.c (Fmake_terminal_frame):
7 * gtkutil.c (get_utf8_string):
9 * nsmenu.m (ns_update_menubar):
11 Prefer memcpy to strncpy and strncat when either will do.
12 * fileio.c (Fsubstitute_in_file_name):
13 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
14 (menu_separator_name_p):
15 * nsmenu.m (ns_update_menubar):
16 Prefer memcmp to strncmp when either will do.
17 * nsterm.m: Include <ftoastr.h>.
19 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
20 Prefer snprintf to strncpy.
21 * nsterm.m (ns_term_init):
22 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
23 * nsterm.m (ns_term_init):
24 Avoid the need for strncpy, by using build_string or
25 make_unibyte_string directly. Use dtoastr, not snprintf.
26 * process.c (Fmake_network_process): Diagnose service names that
27 are too long, rather than silently truncating them or creating
28 non-null-terminated names.
29 (Fnetwork_interface_info): Likewise, for interface names.
30 * sysdep.c (system_process_attributes) [GNU_LINUX]:
31 Prefer sprintf to strncat.
32 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
33 Prefer vsnprintf to vsprintf + strncpy.
35 2012-07-10 Glenn Morris <rgm@gnu.org>
37 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
38 Clarify fallback case.
40 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
42 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
43 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
44 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
45 * w32menu.c, window.c, xmenu.c: Changed to use XCAR and XCDR
46 where argument type is known to be a Lisp_Cons.
48 2012-07-10 Tom Tromey <tromey@redhat.com>
50 * bytecode.c (BYTE_CODE_THREADED): New macro.
51 (BYTE_CODES): New macro. Replaces all old byte-code defines.
52 (enum byte_code_op): New type.
53 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
54 (exec_byte_code): Use them. Use token threading when applicable.
56 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
58 Optimize pure C strings initialization.
59 * lisp.h (make_pure_string): Fix prototype.
60 (build_pure_c_string): New function, defined as static inline. This
61 provides a better opportunity to optimize away calls to strlen when
62 the function is called with compile-time constant argument.
63 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
64 argument, adjust users accordingly. Use build_pure_c_string where
66 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
67 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
68 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
70 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
72 Avoid calls to strlen in miscellaneous functions.
73 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
74 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
75 * lread.c (openp): Likewise.
77 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
79 Avoid calls to strlen in path processing functions.
80 * fileio.c (file_name_as_directory): Add comment. Change to add
81 srclen argument and return the length of result. Adjust users
83 (directory_file_name): Fix comment. Change to add srclen argument,
84 swap 1st and 2nd arguments to obey the common convention. Adjust
86 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
88 2012-07-10 Glenn Morris <rgm@gnu.org>
90 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
91 Move PENDING_OUTPUT_COUNT definition to configure.
93 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
94 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
95 * s/gnu.h (DATA_START): Move definitions to configure.
97 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
98 We include usg5-4-common.h, which defines them both.
100 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
101 O_RDONLY already includes it).
103 Stop ns builds setting the EMACSLOADPATH environment variable.
104 * nsterm.m (ns_load_path): Rename from ns_init_paths.
105 Now it does not set EMACSLOADPATH, just returns the load-path string.
106 * nsterm.h: Update accordingly.
107 * lread.c [HAVE_NS]: Include nsterm.h.
108 (init_lread) [HAVE_NS]: Use ns_load_path.
109 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
111 2012-07-09 Glenn Morris <rgm@gnu.org>
113 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
114 since the included bsd-common.h does so.
116 Stop ns builds setting the EMACSPATH environment variable.
117 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
118 (ns_init_paths): Do not set EMACSPATH.
119 * nsterm.h (ns_exec_path): Add it.
120 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
123 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
125 2012-07-09 Paul Eggert <eggert@cs.ucla.edu>
127 * process.c (wait_reading_process_output): 'waitchannels' was unset
128 when read_kbd || !NILP (wait_for_cell); fix this.
130 Add GCC-style 'const' attribute to functions that can use it.
131 * character.h (char_resolve_modifier_mask):
132 * keyboard.h (make_ctrl_char):
133 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
134 (init_character_once, next_almost_prime, init_fns, init_image)
135 (flush_pending_output, init_sound):
136 * mem-limits.h (start_of_data):
137 * menu.h (finish_menu_items):
139 * emacs.c (DEFINE_DUMMY_FUNCTION):
140 Declare the dummy function with ATTRIBUTE_CONST.
141 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
142 Add decls with ATTRIBUTE_CONST.
144 Minor improvements to make_formatted_string.
145 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
146 where int is good enough, as vsprintf returns an int.
147 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
149 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
151 Use make_formatted_string to avoid double length calculation.
152 * lisp.h (make_formatted_string): New prototype.
153 * alloc.c (make_formatted_string): New function.
154 * buffer.c (Fgenerate_new_buffer_name): Use it.
155 * dbus.c (syms_of_dbusbind): Likewise.
156 * editfns.c (Fcurrent_time_zone): Likewise.
157 * filelock.c (get_boot_time): Likewise.
158 * frame.c (make_terminal_frame, set_term_frame_name)
159 (x_report_frame_params): Likewise.
160 * image.c (gs_load): Likewise.
161 * minibuf.c (get_minibuffer): Likewise.
162 * msdos.c (dos_set_window_size): Likewise.
163 * process.c (make_process): Likewise.
164 * xdisp.c (ensure_echo_area_buffers): Likewise.
165 * xsettings.c (apply_xft_settings): Likewise.
167 2012-07-09 Glenn Morris <rgm@gnu.org>
169 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
170 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
171 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
172 * nsterm.h (ns_etc_directory): Add it.
173 * callproc.c [HAVE_NS]: Include nsterm.h.
174 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
176 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
178 Move marker debugging code under MARKER_DEBUG.
179 * marker.c (MARKER_DEBUG): Move marker debugging code under
180 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
181 for bootstrap with --enable-checking (~3x slowdown reported
182 by Juanma Barranquero <lekktu@gmail.com>).
183 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
185 2012-07-08 Paul Eggert <eggert@cs.ucla.edu>
187 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
188 See <http://bugs.gnu.org/11825#29>.
190 2012-07-08 Eli Zaretskii <eliz@gnu.org>
192 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
193 has no font, use the frame's font. (Bug#11813)
194 (display_line): Add commentary about displaying truncation glyphs
196 (produce_special_glyphs): Move here from term.c.
198 * term.c (produce_special_glyphs): Move to xdisp.c.
200 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
203 2012-07-07 Andreas Schwab <schwab@linux-m68k.org>
205 * xdisp.c (display_line): Avoid warning about implicit declaration
208 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
210 * lisp.h: Remove empty conditional.
212 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
214 * lread.c (load_path_check): Now static.
216 Fix some minor --with-ns problems found by static checking.
217 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
218 (x_set_font) [!HAVE_X_WINDOWS]:
219 * image.c (xpm_load_image) [HAVE_NS]:
220 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
221 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
223 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
224 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
225 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
226 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
227 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
228 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
229 Fix pointer signedness problem.
230 * xfaces.c (FRAME_X_FONT_TABLE):
231 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
233 2012-07-07 Glenn Morris <rgm@gnu.org>
235 * lread.c (load_path_check): New function, split from init_lread.
236 (init_lread): Reorganize. Motivation:
237 If EMACSLOADPATH is set, check/warn about that rather than the
238 defaults, which we are not going to use. Hence we can remove
239 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
240 Don't warn if site-lisp directories are missing.
241 If not installed, start from a blank load-path, since
242 PATH_LOADSEARCH refers to the eventual installation directories.
244 2012-07-07 Eli Zaretskii <eliz@gnu.org>
246 Support truncation and continuation glyphs on GUI frames, when
247 fringes are disabled. (Bug#11832)
248 * xdisp.c (init_iterator): Get dimensions of truncation and
249 continuation glyphs even if on GUI frames. Adjust
250 it->last_visible_x on GUI frames when the left or right fringes,
252 (start_display, move_it_in_display_line_to): Handle the case of a
253 GUI frame without a fringe to display continuation or truncation
255 (insert_left_trunc_glyphs): Support GUI frames: make sure
256 truncation glyphs overwrite enough glyphs from the current line to
257 have sufficient space in pixels.
258 (display_line): Support truncation and continuation glyphs on GUI
259 frames. If some spare pixels are left on the line after inserting
260 the truncation glyphs, fill that space with a stretch glyph of a
261 suitably computed width.
263 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
264 produce_glyphs, to support GUI sessions.
266 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
268 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
270 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
272 Do not require float-time's arg to fit in time_t (Bug#11825).
273 This works better on hosts where time_t is unsigned, and where
274 float-time is applied to the (negative) difference between two times.
275 * editfns.c (decode_time_components): Last arg is now double *,
276 not int *, and means to store all the result as a double, without
277 worrying about whether the seconds part fits in time_t.
279 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
281 (Ffloat_time): Do not fail merely because the specified time falls
282 outside of time_t range.
284 2012-07-07 Glenn Morris <rgm@gnu.org>
286 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
287 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
288 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
290 2012-07-07 Juanma Barranquero <lekktu@gmail.com>
292 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
295 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
297 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
299 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
300 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
301 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
302 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
303 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
304 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
306 * xfont.c (compare_font_names): Redo to omit the need for casts.
308 2012-07-06 Andreas Schwab <schwab@linux-m68k.org>
310 * xfns.c (Fx_change_window_property): Doc fix.
311 * w32fns.c (Fx_change_window_property): Doc fix.
313 * w32fns.c (Fx_window_property): Accept the same arguments as the
314 X Windows version. Doc fix.
315 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
317 2012-07-06 Juanma Barranquero <lekktu@gmail.com>
318 Eli Zaretskii <eliz@gnu.org>
320 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
321 Windows-specific code from nt/config.nt moved here.
322 Obsolete settings removed.
324 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
326 * process.c: Avoid unnecessary calls to gettime.
327 (wait_reading_process_output): Don't get the time of day
328 when gobbling data immediately and not waiting, as there's no need
329 for it in that case. This removes a FIXME.
331 2012-07-06 Jan Djärv <jan.h.d@swipnet.se>
333 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
334 is defined (Bug#11768).
336 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
338 Fix marker debugging code.
339 * marker.c (byte_char_debug_check): Do not perform the check
340 if buffer is not multibyte.
341 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
342 Call byte_char_debug_check with correct arguments.
344 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
346 Compile marker debugging code only if ENABLE_CHECKING is defined.
347 * marker.c (byte_char_debug_check, count_markers):
348 Use only if ENABLE_CHECKING is defined.
349 (byte_debug_flag): Remove.
350 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
351 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
353 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
355 Avoid code repetition in marker-related functions.
356 * marker.c (attach_marker): New function.
357 (Fset_marker, set_marker_restricted, set_marker_both)
358 (set_marker_restricted_both): Use it.
359 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
360 Consistently rename charno to charpos.
361 (marker_position): Add eassert.
362 (marker_byte_position): Convert to eassert.
364 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
366 Simplify list operations in unchain_overlay and unchain_marker.
367 * buffer.c (unchain_overlay): Simplify. Add comment.
368 * marker.c (unchain_marker): Simplify. Fix comments.
370 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
372 Introduce fast path for the widely used marker operation.
373 * alloc.c (build_marker): New function.
374 * lisp.h (build_marker): New prototype.
375 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
376 * composite.c (autocmp_chars): Likewise.
377 * editfns.c (buildmark): Remove.
378 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
379 (save_restriction_save): Use build_marker.
380 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
381 * window.c (save_window_save): Likewise.
383 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
385 Do not use Fdelete_overlay in delete_all_overlays
386 to avoid redundant calls to unchain_overlay.
387 * buffer.c (drop_overlay): New function.
388 (delete_all_overlays, Fdelete_overlay): Use it.
389 * minibuf.c (get_minibuffer): Fix comment.
391 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
393 Port to OpenBSD 5.1 amd64.
394 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
395 This is needed for OpenBSD, and should be harmless on all BSD systems.
396 Also, include <sys/sysctl.h>, as it should be available on all
397 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
398 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
399 use p_pid member, not kp_proc.pid.
401 2012-07-06 Glenn Morris <rgm@gnu.org>
403 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
405 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
407 More xmalloc and related cleanup.
408 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
409 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
410 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
411 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
412 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
413 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
414 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
415 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
416 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
418 Omit needless casts involving void * pointers and allocation.
419 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
420 as the former is more robust if P's type is changed.
421 Prefer xzalloc to xmalloc + memset 0.
422 Simplify malloc-or-realloc to realloc.
423 Don't worry about xmalloc returning a null pointer.
424 Prefer xstrdup to xmalloc + strcpy.
425 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
427 * keyboard.c (apply_modifiers_uncached): Prefer local array to
428 alloca of a constant.
430 2012-07-05 Eli Zaretskii <eliz@gnu.org>
432 * xdisp.c (display_line): Fix horizontal pixel coordinates when
433 hscroll is larger than the line width. Fixes long and futile
434 looping inside extend_face_to_end_of_line (on a TTY) producing
435 glyphs that are not needed and thrown away.
437 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
439 * marker.c (set_marker_restricted_both): Simplify by using
442 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
444 * editfns.c (region_limit): Simplify by using clip_to_bounds.
446 2012-07-05 Jan Djärv <jan.h.d@swipnet.se>
448 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
449 not defined (Bug#11768).
450 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
451 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
452 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
453 followed by gtk_box_set_homogeneous (Bug#11768).
454 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
455 (update_theme_scrollbar_width, xg_create_scroll_bar):
456 Use gtk_scrollbar_new (Bug#11768).
457 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
458 (is_box_type): New function (Bug#11768).
459 (xg_tool_item_stale_p): Call is_box_type.
460 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
461 with default display (Bug#11768).
463 2012-07-05 Eli Zaretskii <eliz@gnu.org>
465 * xdisp.c (window_hscroll_limited): New function.
466 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
467 coordinates when window's hscroll is set to insanely large
470 2012-07-05 Juanma Barranquero <lekktu@gmail.com>
472 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
473 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
475 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
478 * lisp.h (xzalloc): New prototype. Omit needless casts.
479 * alloc.c (xzalloc): New function. Omit needless casts.
480 * charset.c: Omit needless casts. Convert all calls to
481 xmalloc with following memset to xzalloc.
482 * dispnew.c: Likewise.
483 * fringe.c: Likewise.
487 * w32fns.c: Likewise.
488 * w32font.c: Likewise.
489 * w32term.c: Likewise.
490 * xfaces.c: Likewise.
493 * atimer.c: Omit needless casts.
494 * buffer.c: Likewise.
495 * callproc.c: Likewise.
497 * coding.c: Likewise.
498 * composite.c: Likewise.
500 * doprnt.c: Likewise.
501 * editfns.c: Likewise.
504 * filelock.c: Likewise.
506 * gtkutil.c: Likewise.
507 * keyboard.c: Likewise.
510 * minibuf.c: Likewise.
513 * process.c: Likewise.
514 * region-cache.c: Likewise.
515 * search.c: Likewise.
516 * sysdep.c: Likewise.
517 * termcap.c: Likewise.
518 * terminal.c: Likewise.
519 * tparam.c: Likewise.
520 * w16select.c: Likewise.
522 * w32reg.c: Likewise.
523 * w32select.c: Likewise.
524 * w32uniscribe.c: Likewise.
525 * widget.c: Likewise.
529 * xselect.c: Likewise.
531 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
533 * fileio.c (time_error_value): Check the right error number.
534 Problem reported by Troels Nielsen in
535 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
537 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
539 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
540 This should be fixed in a better way; see Eli Zaretskii in
541 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
542 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
544 * fileio.c (time_error_value): Rename from special_mtime.
545 The old name's problems were noted by Eli Zaretskii in
546 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
548 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
549 This variable's comment says Emacs needs at least one GDB-visible
550 symbol of type enum pvec_type, to work around GDB problems.
551 The symbol's value doesn't matter.
553 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
554 that causes compilation to fail on pre-C99 compilers.
556 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
558 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
559 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
561 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
563 * buffer.c (init_buffer_once): Fix initialization of
564 headers for buffer_defaults and buffer_local_symbols.
565 Reported by Juanma Barranquero <lekktu@gmail.com>.
567 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
569 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
570 * lisp.h (enum pvec_type): Use fewer bits.
571 (PSEUDOVECTOR_SIZE_BITS): New constant.
572 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
573 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
575 (PSEUDOVECTOR_TYPEP): New macro.
576 (TYPED_PSEUDOVECTORP): Use it.
577 * fns.c (internal_equal): Adapt code to extract pvectype.
578 * emacs.c (gdb_pvec_type): Update type.
579 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
580 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
581 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
582 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
583 (sweep_vectors): Use it. Use local var `total_bytes' instead of
584 abusing vector->header.next.nbytes.
585 (live_vector_p): Use PVEC_TYPE.
586 (mark_object): Adapt code to extract pvectype. Use switch.
588 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
590 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
591 Tighten new eassert a bit.
593 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
595 Fix compilation with --enable-gcc-warnings and -O1
597 * doprnt.c (doprnt): Change type of tem to int, initialize
598 to avoid compiler warning. Add eassert.
599 * search.c (simple_search): Initialize match_byte to avoid
600 compiler warning. Add eassert.
602 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
604 Avoid weird behavior with large horizontal scrolls.
605 Without this change, for example, large hscroll values would
606 mess up Emacs's display on Fedora 15 x86, presumably due to
607 overflows in int calculations in the display code.
608 Also, if buffers had long lines, Emacs would freeze.
609 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
610 (set_window_hscroll): New function, containing the old guts of
611 Fset_window_hscroll. Return the clipped value.
612 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
613 This avoids the need to check against PTRDIFF_MAX.
615 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
617 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
619 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
621 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
623 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
624 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
625 since GCC 4.4.6 issues a bogus warning for them.
627 Fix bugs in file timestamp newness comparisons.
628 * fileio.c (Ffile_newer_than_file_p):
629 * lread.c (Fload): Use full timestamp resolution of files,
630 not just the 1-second resolution, so that files that are only
631 slightly newer still count as newer.
632 * fileio.c (Ffile_newer_than_file_p): Don't assume file
633 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
635 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
637 * fileio.c: Improve handling of file time marker. (Bug#11852)
638 (special_mtime): New function.
639 (Finsert_file_contents, Fverify_visited_file_modtime):
640 Use it to set special mtime values consistently.
642 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
644 * fileio.c (Finsert_file_contents): Properly handle st_mtime
645 marker for non-existing file. (Bug#11852)
647 2012-07-03 Glenn Morris <rgm@gnu.org>
649 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
650 and did not make it into globals.h).
652 2012-07-03 Tom Tromey <tromey@redhat.com>
654 * window.c (Fset_window_margins, Fset_window_fringes)
655 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
656 * textprop.c (Fprevious_property_change): No longer static.
657 * syntax.c (Fsyntax_table_p): No longer static.
658 * process.c (Fget_process, Fprocess_datagram_address): No longer
660 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
661 * keyboard.c (Fcommand_execute): No longer static.
663 * insdel.c (Fcombine_after_change_execute): No longer static.
664 * image.c (Finit_image_library): No longer static.
665 * fileio.c (Fmake_symbolic_link): No longer static.
666 * eval.c (Ffetch_bytecode): No longer static.
667 * editfns.c (Fuser_full_name): No longer static.
668 * doc.c (Fdocumentation_property, Fsnarf_documentation):
670 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
672 * dired.c (Ffile_attributes): No longer static.
673 * composite.c (Fcomposition_get_gstring): No longer static.
674 * callproc.c (Fgetenv_internal): No longer static.
676 * ccl.h: Remove EXFUNs.
677 * buffer.h: Remove EXFUNs.
678 * dispextern.h: Remove EXFUNs.
679 * intervals.h: Remove EXFUNs.
680 * fontset.h: Remove EXFUN.
681 * font.h: Remove EXFUNs.
682 * dosfns.c (system_process_attributes): Remove EXFUN.
683 * keymap.h: Remove EXFUNs.
684 * lisp.h: Remove EXFUNs.
685 * w32term.h: Remove EXFUNs.
686 * window.h: Remove EXFUNs.
687 * xsettings.h: Remove EXFUN.
688 * xterm.h: Remove EXFUN.
690 2012-07-03 Glenn Morris <rgm@gnu.org>
692 * lisp.h (Frandom): Make it visible to C.
693 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
694 buffer for invisible buffers. (Bug#1229)
696 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
698 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
699 values which aren't power of 2.
700 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
701 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
704 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
706 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
708 * alloc.c (mark_object): Revert part of last patch to use `switch'.
710 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
712 * alloc.c (allocate_vector_block): Remove redundant
713 calls to mallopt if DOUG_LEA_MALLOC is defined.
714 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
715 avoid calls to mallopt if zero_vector is returned.
717 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
719 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
720 is enabled, avoid dereferencing NULL current_sblock if
723 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
725 Cleanup basic buffer management.
726 * buffer.h (struct buffer): Change layout to use generic vector
727 marking code. Fix some comments. Change type of 'clip_changed'
728 to bitfield. Remove unused #ifndef old.
729 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
730 (GET_OVERLAYS_AT): Fix indentation.
731 (for_each_per_buffer_object_at): New macro.
732 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
733 (Fbuffer_local_variables): Use it.
734 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
735 * alloc.c (allocate_buffer): Adjust to match new layout of
736 struct buffer. Fix comment.
737 (mark_overlay): New function.
738 (mark_buffer): Use it. Use mark_vectorlike to mark normal
739 Lisp area of struct buffer.
740 (mark_object): Use it. Adjust marking of misc objects
741 and related comments.
743 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
745 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
746 wrapper that is not needed because the wrapped code is a no-op (zero
747 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
748 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
750 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
752 * alloc.c (mark_buffer): Simplify. Remove prototype.
753 (mark_object): Add comment. Reorganize marking of vector-like
754 objects. Use CHECK_LIVE for all vector-like objects except buffers
755 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
756 redundant calls to mark_vectorlike for bool vectors.
758 2012-06-30 Glenn Morris <rgm@gnu.org>
760 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
762 * epaths.in (PATH_SITELOADSEARCH): New.
763 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
764 This is rather than relying on --enable-locallisppath elements
765 having "site-lisp" in their names. (Bug#10208#25, 11658)
767 2012-06-30 Eli Zaretskii <eliz@gnu.org>
769 * w32proc.c (sys_select): Accept and ignore one more argument.
771 * w32.c (emacs_gnutls_pull): Call select with one more argument.
773 * sysselect.h [DOS_NT]: Don't include sys/select.h.
774 (pselect) [!MS_DOS]: Redirect to sys_select.
776 * sysdep.c: Don't include dos.h and dosfns.h.
778 * process.c (sys_select):
779 * msdos.c (sys_select): Accept one more argument and ignore it.
781 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
782 adapt data types and code to that.
785 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
786 which clashes with the gnulib function of the same name.
788 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
790 * font.c (font_style_to_value, font_style_symbolic)
791 (font_prop_validate_style): Add type checks for values in
794 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
796 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
799 2012-06-29 Eli Zaretskii <eliz@gnu.org>
801 * xdisp.c (try_window_id): Undo last change.
803 * w32.c (getwd): Adjust commentary about startup_dir.
804 (init_environment): Always call sys_access, even in non-MSVC
805 builds. Don't chdir to the directory of the Emacs executable.
806 This undoes code from 1997 which was justified by the need to
807 "avoid conflicts when removing and renaming directories". But its
808 downside was that every relative file name was being interpreted
809 relative to the directory of the Emacs executable, which can never
810 be TRT. In particular, it broke sys_access when called with
812 (sys_access): Map GetLastError to errno.
814 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
816 * window.h (struct window): Change type of 'fringes_outside_margins'
817 to bitfield. Fix comment. Adjust users accordingly.
818 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
820 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
823 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
825 * gnutls.c (emacs_gnutls_handshake):
826 Add QUIT to make the loop interruptible.
828 2012-06-29 Glenn Morris <rgm@gnu.org>
830 * charset.c (init_charset): Make lack of etc/charsets fatal.
832 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
834 * editfns.c (region_limit): Fix type mismatch.
836 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
838 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
839 undefined. Convert from xassert to eassert.
840 * nsmenu.m: Convert from xassert to eassert.
841 * nsterm.m: Likewise.
843 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
845 * editfns.c (region_limit): Clip to narrowing (bug#11770).
847 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
849 Avoid integer overflow on scroll-left and scroll-right.
850 * window.c (HSCROLL_MAX): New macro.
851 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
852 overflow when requested scroll falls outside ptrdiff_t range.
854 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
856 * window.h (struct window): Change type of 'hscroll',
857 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
858 'last_modified' and 'last_overlay_modified' to EMACS_INT.
859 Adjust users accordingly.
860 * xdisp.c (try_cursor_movement): Replace type check with eassert.
861 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
862 from EMACS_INT to ptrdiff_t.
863 (make_window): Omit redundant initialization.
865 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
867 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
869 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
871 * window.h (struct window): Change type of 'use_time' and
872 'sequence_number' from Lisp_Object to int.
873 * frame.c (make_frame): Adjust users accordingly.
874 * print.c (print_object): Likewise.
875 * window.c (select_window, Fwindow_use_time, make_parent_window)
876 (make_window): Likewise.
878 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
880 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
881 enabled with --enable-checking=[all,glyphs] configure option.
882 Fix GLYPH_DEBUG usage assuming that it may be undefined,
883 adjust comments accordingly.
884 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
885 undefined, adjust comments accordingly.
887 * scroll.c: Likewise.
888 * w32fns.c: Likewise.
889 * w32term.c: Likewise.
891 * xfaces.c: Likewise.
895 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
897 Generalize run-time debugging checks.
898 * dispextern.h (XASSERTS): Remove.
899 * fontset.c (xassert): Remove.
900 Convert from xassert to eassert.
901 * alloc.c: Convert from xassert to eassert.
903 * dispnew.c: Likewise.
905 * fringe.c: Likewise.
906 * ftfont.c: Likewise.
907 * gtkutil.c: Likewise.
909 * keyboard.c: Likewise.
911 * process.c: Likewise.
912 * scroll.c: Likewise.
915 * w32console.c: Likewise.
916 * w32fns.c: Likewise.
917 * w32term.c: Likewise.
918 * window.c: Likewise.
920 * xfaces.c: Likewise.
922 * xselect.c: Likewise.
925 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
927 * fns.c (maybe_resize_hash_table): Output message when growing the
930 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
932 * alloc.c (allocate_string_data): Remove dead code.
933 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
934 avoid GCC warning about unused macro.
936 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
938 * alloc.c (allocate_string): Omit intervals initialization.
939 * alloc.c (make_uninit_multibyte_string): Initialize intervals
940 as in make_pure_string and make_pure_c_string.
942 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
944 * alloc.c (allocate_string): Fix last change.
946 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
948 * alloc.c (allocate_string): Remove two redundant calls
949 to memset, add explicit initialization where appropriate.
951 2012-06-27 Glenn Morris <rgm@gnu.org>
953 * lisp.mk (lisp): Remove paths.elc.
955 2012-06-27 Chong Yidong <cyd@gnu.org>
957 * doc.c (Fsubstitute_command_keys): Fix punctuation.
959 2012-06-26 John Wiegley <johnw@newartisans.com>
961 * unexmacosx.c (copy_data_segment): Add two section names used
962 on Mac OS X Lion: __mod_init_func and __mod_term_func.
964 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
965 when building with Clang.
967 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
969 * eval.c (Fapply): Allow calling it with a single argument.
971 2012-06-26 Eli Zaretskii <eliz@gnu.org>
973 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
974 _stricmp and _strnicmp.
975 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
977 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
979 * alloc.c (allocate_window): Zero out non-Lisp part of newly
981 (allocate_process): Likewise for new process.
982 (allocate_terminal): Change to use offsetof.
983 (allocate_frame): Likewise.
984 * frame.c (make_frame): Omit redundant initialization.
985 * window.c (make_parent_window): Use memset.
986 (make_window): Omit redundant initialization.
987 * process.c (make_process): Omit redundant initialization.
988 * terminal.c (create_terminal): Likewise.
990 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
992 * term.c (delete_tty): Remove redundant call to memset.
994 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
996 * alloc.c: Remove build_string.
997 * lisp.h: Define build_string as static inline. This provides
998 a better opportunity to optimize away calls to strlen when the
999 function is called with compile-time constant argument.
1000 * image.c (imagemagick_error): Convert to build_string.
1001 * w32proc.c (sys_spawnve): Likewise.
1002 * xterm.c (x_term_init): Likewise.
1004 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1006 Use sprintf return value instead of invoking strlen on result.
1007 In the old days this wasn't portable, since some sprintf
1008 implementations returned char *. But they died out years ago and
1009 Emacs already assumes sprintf returns int.
1010 Similarly for float_to_string.
1011 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1012 * ccl.c (ccl_driver):
1013 * character.c (string_escape_byte8):
1014 * data.c (Fnumber_to_string):
1015 * doprnt.c (doprnt):
1016 * print.c (print_object):
1017 * xdisp.c (message_dolog):
1018 * xfns.c (syms_of_xfns):
1019 Use sprintf or float_to_string result to avoid need to call strlen.
1020 * data.c (Fnumber_to_string):
1021 Use make_unibyte_string, since the string must be ASCII.
1022 * lisp.h, print.c (float_to_string): Now returns int length.
1023 * term.c (produce_glyphless_glyph):
1024 Use sprintf result rather than recomputing it.
1026 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1027 * Makefile.in (ALL_CFLAGS):
1028 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1029 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1031 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1033 * dispextern.h (xstrcasecmp): Define to library function
1034 strcasecmp if available.
1035 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1037 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1039 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1040 Avoid comma operator.
1041 * menu.c (push_submenu_start, push_submenu_end)
1042 (push_left_right_boundary, push_menu_pane): Likewise.
1043 * msdos.c (dos_rawgetc): Likewise.
1045 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1047 * xfns.c (xic_create_fontsetname): Remove redundant calls
1050 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1052 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1053 sprintf already null-terminates its output.
1055 * xfns.c (x_window): Remove redundant cast.
1057 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1059 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1060 `const char *' to `char *' to avoid compiler warning.
1062 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1064 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1065 instead of truncating it to 63 (admittedly a generous limit).
1067 * process.c: Fix spelling and caps in comments.
1069 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1071 * emacs.c (setpgrp): Remove definition, unused.
1072 * sysdep.c (setpgrp): Remove definition, not used in this file.
1074 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
1076 * makefile.w32-in: Update dependencies.
1078 2012-06-24 Eli Zaretskii <eliz@gnu.org>
1080 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1081 (SYSTIME_H): Add nt/inc/sys/time.h.
1083 * systime.h [WINDOWSNT]: Include sys/time.h.
1085 * s/ms-w32.h (struct timespec): Definition moved from
1086 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1088 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1090 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1091 * buffer.h (buffer_slot_type_mismatch):
1092 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1093 * eval.c (unwind_to_catch):
1094 * image.c (my_png_error, my_error_exit):
1095 * keyboard.c (quit_throw_to_read_char, user_error)
1096 (Fexit_recursive_edit, Fabort_recursive_edit):
1097 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1098 (wrong_type_argument, buffer_overflow, __executable_start)
1099 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1100 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1101 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1103 (child_setup) [!DOS_NT]:
1104 * lread.c (end_of_file_error, invalid_syntax):
1105 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1106 * puresize.h (pure_write_error):
1107 * search.c (matcher_overflow):
1108 * sound.c (sound_perror, alsa_sound_perror):
1109 * sysdep.c, syssignal.h (croak):
1110 * term.c (maybe_fatal, vfatal):
1111 * textprop.c (text_read_only):
1112 * undo.c (user_error):
1113 * unexmacosx.c (unexec_error):
1114 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1115 Use _Noreturn rather than NO_RETURN.
1116 No need for separate decl merely because of _Noreturn.
1117 * sound.c (sound_warning, parse_sound):
1118 Remove unnecessary forward decls.
1120 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1122 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1123 * lisp.h (WAIT_READING_MAX): New macro.
1124 * dispnew.c (Fsleep_for, sit_for):
1125 * keyboard.c (kbd_buffer_get_event):
1126 * process.c (Faccept_process_output):
1127 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1128 This improves on the previous patch, which introduced a bug
1129 when time_t is unsigned and as wide as intmax_t.
1130 See <http://bugs.gnu.org/9000#51>.
1132 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1134 * dispnew.c (sit_for, Fsleep_for):
1135 * keyboard.c (kbd_buffer_get_event):
1136 * process.c (Faccept_process_output): Avoid compiler warnings when
1137 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1139 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
1141 * makefile.w32-in: Update dependencies.
1143 * w32.c (ltime): Add return type and declare static.
1144 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1146 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1148 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1149 Privately reported by Herbert J. Skuhra.
1150 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1152 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1153 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1155 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1157 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1158 last argument of make_unibyte_string.
1160 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1161 language ID in the event parameters.
1163 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1164 event.code, not the obscure "character set ID".
1166 2012-06-23 Chong Yidong <cyd@gnu.org>
1168 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1170 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1172 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1173 * w32.c (fdutimens): New function.
1175 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1177 * s/ms-w32.h (pselect): Redirect to sys_select.
1179 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1181 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1182 in the logic of incrementing and decrementing the value of
1183 use_relocatable_buffers.
1185 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1187 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1188 Privately reported by Herbert J. Skuhra.
1189 [__FreeBSD__]: Remove "*/" typo after "#include".
1190 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1191 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1192 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1193 Don't assume EMACS_TIME and struct timeval are the same type.
1195 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1197 Support higher-resolution time stamps (Bug#9000).
1198 The time stamps are only nanosecond-resolution at the C level,
1199 since that's the best that any real-world system supports now.
1200 But they are picosecond-resolution at the Lisp level, as that's
1201 easy, and leaves room for future OS improvements.
1203 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1206 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1207 Don't get current time unless it's needed.
1209 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1210 now provides it if it's absent.
1211 (start_atimer): Port to higher-res time stamps.
1212 Check for time stamp overflow. Don't get current time more
1213 often than is needed.
1215 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1216 Include systime.h, not time.h.
1217 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1219 * dired.c: Include stat-time.h.
1220 (Ffile-attributes): File times now have higher resolution.
1222 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1223 (struct image): Timestamp now has higher resolution.
1225 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1226 has at least microseconds now. All uses removed.
1227 (update_frame, update_single_window, update_window, update_frame_1)
1228 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1230 * editfns.c (time_overflow): Now extern.
1231 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1232 (float-time, Fformat_time_string, Fcurrent_time_string)
1233 (Fcurrent_time_zone): Accept and generate higher-resolution
1235 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1236 (decode_time_components, lisp_seconds_argument): New functions.
1237 (make_time): Now static.
1238 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1239 Report an error if the time is invalid, rather than having the caller
1242 * fileio.c: Include <stat-time.h>
1243 (Fcopy_file): Copy higher-resolution time stamps.
1244 Prefer to set the time stamp via a file descriptor if that works.
1245 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1246 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1247 (Fvisited_file_modtime, Fset_visited_file_modtime):
1248 Support higher-resolution time stamps.
1250 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1252 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1254 * image.c (prepare_image_for_display, clear_image_cache)
1255 (lookup_image): Port to higer-resolution time stamps.
1257 * keyboard.c (start_polling, bind_polling_period):
1258 Check for time stamp overflow.
1259 (read_char, kbd_buffer_get_event, timer_start_idle)
1260 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1261 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1262 Port to higher-resolution time stamps. Do not assume time_t is signed.
1263 (decode_timer): New function. Timers are now vectors of length 9,
1264 not 8, to accommodate the picosecond component.
1265 (timer_check_2): Use it.
1267 * nsterm.m (select_timeout, timeval_subtract): Remove.
1268 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1269 as they're a bit more accurate and handle overflow better.
1270 (ns_select): Change prototype to be compatible with pselect.
1271 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1272 * nsterm.h (ns_select): Adjust prototype.
1274 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1275 us-resolution time stamps.
1276 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1278 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1280 * lisp.h (time_overflow): New decl.
1281 (wait_reading_process_output): First arg is now intmax_t, not int,
1282 to accommodate larger waits.
1284 * process.h (struct Lisp_Process.read_output_delay):
1285 Now counts nanoseconds, not microseconds.
1286 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1288 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1289 (wait_reading_process_output):
1290 Port to ns-resolution time stamps.
1291 (Faccept_process_output, wait_reading_process_output):
1292 Check for time stamp overflow. Do not assume time_t is signed.
1293 (select_wrapper): Remove; we now use pselect.
1294 (Fprocess_attributes): Now generates ns-resolution time stamps.
1296 * sysdep.c: Include utimens.h. Don't include utime.h
1297 or worry about struct utimbuf; gnulib does that for us now.
1298 (gettimeofday): Remove; gnulib provides a substitute.
1299 (make_timeval): New function.
1300 (set_file_times): Now sets ns-resolution time stamps.
1301 New arg FD; all uses changed.
1302 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1303 (system_process_attributes):
1304 Now returns ns-resolution time stamp. All uses changed.
1305 Check for time stamp overflow.
1307 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1308 provides a substitute now.
1310 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1311 since it guarantees struct timespec.
1312 (EMACS_TIME): Now struct timespec, so that we can support
1313 ns-resolution time stamps.
1314 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1315 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1316 (EMACS_USECS): Remove.
1317 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1318 so multiply the arg by 1000 before storing it.
1319 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1321 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1322 Port to ns-resolution time stamps.
1323 (EMACS_TIME_NEG_P): Remove; replaced by....
1324 (EMACS_TIME_SIGN): New macro.
1325 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1326 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1327 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1328 (make_timeval, make_lisp_time, decode_time_components): New decls.
1329 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1330 that it mishandled time_t overflow. You can't compare by subtracting!
1331 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1332 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1334 * term.c: Include <sys/time.h>.
1335 (timeval_to_Time): New function, for proper overflow wraparound.
1336 (term_mouse_position, term_mouse_click): Use it.
1338 * undo.c (record_first_change): Support higher-resolution time stamps
1340 (Fprimitive_undo): Use them when restoring time stamps.
1342 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1343 (w32_get_internal_run_time):
1344 Port to higher-resolution Emacs time stamps.
1345 (ltime): Now accepts single 64-bit integer, as that's more convenient
1348 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1350 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1351 for compatibility with pselect. Support ns-resolution time stamps.
1353 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1355 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1356 Check for time stamp overflow, and support ns-resolution time stamps.
1358 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1359 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1360 (timeval_subtract): Remove; no longer needed.
1361 (XTflash, XTring_bell, x_wait_for_event):
1362 Port to ns-resolution time stamps. Don't assume time_t is signed.
1364 2012-06-22 Chong Yidong <cyd@gnu.org>
1366 * xdisp.c (x_consider_frame_title): Revert last change.
1368 2012-06-22 Eli Zaretskii <eliz@gnu.org>
1370 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1371 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1372 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1373 staticidx goes up to 1597 out of 1600 = 0x640.)
1375 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1377 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1378 Otherwise, the umask might be mistakenly 0 while handling input signals.
1380 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1382 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1384 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1386 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1387 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1388 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1389 access to `contents' member of Lisp_Vector objects with AREF and ASET
1392 2012-06-19 Chong Yidong <cyd@gnu.org>
1394 * frame.c (delete_frame): When selecting a frame on a different
1395 text terminal, do not alter the terminal's top-frame.
1397 * xdisp.c (format_mode_line_unwind_data): Record the target
1398 frame's selected window and its terminal's top-frame.
1399 (unwind_format_mode_line): Restore them.
1400 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1402 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1403 since tty frames can be explicitly named.
1404 (prepare_menu_bars): Likewise.
1406 * term.c (Ftty_top_frame): New function.
1408 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1410 Port byte-code-meter to modern targets.
1411 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1412 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
1413 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
1414 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1415 (METER_1, METER_2): Simplify.
1417 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1419 * data.c (Fdefalias): Return `symbol' (bug#11686).
1421 2012-06-18 Martin Rudalics <rudalics@gmx.at>
1423 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1424 gets killed during executing of this function (Bug#11665).
1425 Try to always return Qt when the buffer has been actually killed.
1426 (Vkill_buffer_query_functions): In doc-string say that functions
1427 run by this hook should not change the current buffer.
1429 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1431 Fix recently-introduced process.c problems found by static checking.
1432 * process.c (write_queue_push, write_queue_pop, send_process):
1433 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1434 (write_queue_pop): Fix pointer signedness problem.
1435 (send_process): Remove unused local.
1437 2012-06-17 Chong Yidong <cyd@gnu.org>
1439 * xdisp.c (redisplay_internal): No need to redisplay terminal
1440 frames that are not on top.
1442 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
1444 * process.c (make_process): Initialize write_queue.
1445 (write_queue_push, write_queue_pop): New functions.
1446 (send_process): Use them to maintain correct ordering of process
1449 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1451 * lisp.h (eassert): Assume C89 or later.
1452 This removes the need for CHECK.
1453 (CHECK): Remove. Its comments about always evaluating its
1454 argument were confusing, as 'eassert' typically does not evaluate
1457 * coding.c (produce_chars): Use ptrdiff_t, not int.
1459 * xterm.c (x_draw_underwave): Check for integer overflow.
1460 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1462 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
1464 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1465 referenced (Bug#11583).
1467 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1469 Implement wave-style variant of underlining.
1470 * dispextern.h (face_underline_type): New enum.
1471 (face): Add field for underline type.
1472 * nsterm.m (ns_draw_underwave): New function.
1473 (ns_draw_text_decoration): Use it.
1474 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1476 (x_draw_glyph_string): Use them.
1477 * xfaces.c (Qline, Qwave): New Lisp objects.
1478 (check_lface_attrs, merge_face_ref)
1479 (Finternal_set_lisp_face_attribute, realize_x_face):
1480 Handle wave-style underline face attributes.
1481 * xterm.c (x_draw_underwave): New function.
1482 (x_draw_glyph_string): Use it.
1484 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
1486 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1487 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1488 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1489 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1490 ($(BLD)/w32select.$(O)): Update dependencies.
1492 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1494 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1495 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1496 * character.c (_fetch_multibyte_char_p): Remove.
1497 * alloc.c: Include "character.h" before "buffer.h".
1499 * buffer.c: Likewise.
1500 * bytecode.c: Likewise.
1501 * callint.c: Likewise.
1502 * callproc.c: Likewise.
1503 * casefiddle.c: Likewise.
1504 * casetab.c: Likewise.
1505 * category.c: Likewise.
1507 * coding.c: Likewise.
1508 * composite.c: Likewise.
1509 * dired.c: Likewise.
1510 * dispnew.c: Likewise.
1512 * dosfns.c: Likewise.
1513 * editfns.c: Likewise.
1514 * emacs.c: Likewise.
1515 * fileio.c: Likewise.
1516 * filelock.c: Likewise.
1518 * fontset.c: Likewise.
1519 * fringe.c: Likewise.
1520 * indent.c: Likewise.
1521 * insdel.c: Likewise.
1522 * intervals.c: Likewise.
1523 * keyboard.c: Likewise.
1524 * keymap.c: Likewise.
1525 * lread.c: Likewise.
1526 * macros.c: Likewise.
1527 * marker.c: Likewise.
1528 * minibuf.c: Likewise.
1529 * nsfns.m: Likewise.
1530 * nsmenu.m: Likewise.
1531 * print.c: Likewise.
1532 * process.c: Likewise.
1533 * regex.c: Likewise.
1534 * region-cache.c: Likewise.
1535 * search.c: Likewise.
1536 * syntax.c: Likewise.
1538 * textprop.c: Likewise.
1540 * unexsol.c: Likewise.
1541 * w16select.c: Likewise.
1542 * w32fns.c: Likewise.
1543 * w32menu.c: Likewise.
1544 * window.c: Likewise.
1545 * xdisp.c: Likewise.
1547 * xmenu.c: Likewise.
1549 * xselect.c: Likewise.
1551 2012-06-16 Eli Zaretskii <eliz@gnu.org>
1553 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1554 If all the glyphs of the glyph row came from strings, and we have no
1555 cursor positioning clues, put the cursor on the first glyph of the
1557 (handle_face_prop): Use chunk-relative overlay string index when
1558 indexing into it->string_overlays array. (Bug#11653)
1559 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1560 the rightmost. (Bug#11720)
1562 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1564 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1565 (CATEGORY_MEMBER): Enforce 1/0 value.
1566 * category.c (_temp_category_set): Remove.
1568 2012-06-16 Eli Zaretskii <eliz@gnu.org>
1570 * window.c (Fdelete_other_windows_internal)
1571 (Fdelete_window_internal): Don't access frame's mouse highlight
1572 info of the initial frame. (Bug#11677)
1574 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1576 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1577 Assume USE_2_TAGS_FOR_INTS.
1578 (xreload): Adjust $tagmask width to match recent lisp.h change.
1580 Simplify lisp.h in minor ways that should not affect code.
1581 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1582 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1583 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1584 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1585 (INTTYPEBITS): New macro, for clarity.
1586 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1587 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1588 Simplify now that USE_LSB_TAG is always defined.
1589 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1590 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1592 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
1594 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1596 2012-06-13 Glenn Morris <rgm@gnu.org>
1598 * s/bsd-common.h (BSD4_3):
1599 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1601 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1603 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1606 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1608 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
1609 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1610 * alloc.c (widen_to_Lisp_Object): Remove.
1611 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1612 * frame.c (delete_frame): Remove outdated comment.
1613 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1614 USE_LISP_UNION_TYPE.
1615 (Fw32_unregister_hot_key): Likewise.
1616 (Fw32_toggle_lock_key): Likewise.
1617 * w32menu.c (add_menu_item): Likewise.
1618 (w32_menu_display_help): Use XIL instead of checking
1619 USE_LISP_UNION_TYPE.
1620 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1621 (init_heap): Likewise.
1622 * w32term.c (w32_read_socket): Update comment.
1624 2012-06-13 Glenn Morris <rgm@gnu.org>
1626 * s/usg5-4-common.h, src/s/unixware.h:
1627 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1629 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1631 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1633 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1634 * alloc.c (make_number) [!defined make_number]:
1635 Remove, as lisp.h always defines this now.
1636 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1637 (roundup_size): Verify that it is a power of 2.
1638 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1639 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1640 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1641 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1642 USE_LSB_TAG now is always defined to be either 0 or 1.
1644 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1645 code works fine either way, and efficiency is not a concern here,
1646 as the union type is for debugging, not for production.
1647 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1648 Use an inline function on all platforms when using the union type,
1649 since this is simpler and 'static inline' can be used portably
1651 (LISP_INITIALLY_ZERO): New macro.
1652 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1653 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1655 2012-06-12 Glenn Morris <rgm@gnu.org>
1657 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1659 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
1661 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1662 Move BROKEN_SIGIO to configure.
1664 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1665 Move NO_TERMIO to configure.
1667 2012-06-12 Chong Yidong <cyd@gnu.org>
1669 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1670 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1671 MagickExportImagePixels is undefined.
1673 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1675 * image.c (imagemagick_load_image): Remove unused label.
1677 2012-06-11 Glenn Morris <rgm@gnu.org>
1679 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1680 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1681 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1682 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1684 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1686 * alloc.c (make_byte_code): New function.
1687 (Fmake_byte_code): Use it. Don't purify here.
1688 * lread.c (read1): Use it as well to avoid extra allocation.
1690 2012-06-11 Chong Yidong <cyd@gnu.org>
1692 * image.c (imagemagick_load_image): Implement transparency.
1694 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1696 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1697 account for preceding backslashes. (Bug#11663)
1699 2012-06-09 Chong Yidong <cyd@gnu.org>
1701 * term.c: Support italics in capable terminals (Bug#9652).
1702 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1703 (turn_on_face): Output using TS_enter_italic_mode if available.
1704 Don't handle unused blinking and alt-charset cases.
1705 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1706 and tty_alt_charset_p cases.
1707 (tty_capable_p, init_tty): Support italics.
1709 * termchar.h (struct tty_display_info): Add field for italics.
1710 Remove unused blink field.
1712 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1715 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1716 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1717 tty_alt_charset_p. Add tty_italic_p.
1719 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
1721 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1722 dbus_type_is_basic if available.
1723 (xd_extract_signed, xd_extract_unsigned): Rename from
1724 extract_signed and extract_unsigned, respectively. Adapt callers.
1726 2012-06-09 Chong Yidong <cyd@gnu.org>
1728 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1730 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1733 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1735 * xdisp.c (vmessage): Treat frame message as multibyte.
1736 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1737 would generate the diagnostic "Making \302\247 buffer-local while
1740 2012-06-08 Eli Zaretskii <eliz@gnu.org>
1742 * dispnew.c (showing_window_margins_p): Undo last change, which
1743 was done due to an inadvertent commit.
1744 (adjust_frame_glyphs_for_frame_redisplay): Do call
1745 showing_window_margins_p.
1747 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1749 * eval.c (Fmake_var_non_special): New primitive.
1750 (syms_of_eval): Defsubr it.
1751 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1753 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
1755 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1756 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1758 2012-06-08 Eli Zaretskii <eliz@gnu.org>
1760 * alloc.c (allocate_vectorlike): Fix last change.
1762 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1764 Block-based vector allocation of small vectors.
1765 * lisp.h (struct vectorlike_header): New field `nbytes',
1766 adjust comment accordingly.
1767 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1768 to denote vector blocks. Adjust users (live_vector_p,
1769 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1770 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1771 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1772 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1773 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1774 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1775 (roundup_size): New constant.
1776 (struct vector_block): New data type.
1777 (vector_blocks, vector_free_lists, zero_vector): New variables.
1778 (all_vectors): Rename to `large_vectors'.
1779 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1780 (sweep_vectors): New functions.
1781 (allocate_vectorlike): Return `zero_vector' as the only vector of
1782 0 items. Allocate new vector from block if vector size is less than
1783 or equal to VBLOCK_BYTES_MAX.
1784 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1785 (init_alloc_once): Add call to init_vectors.
1787 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1789 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1791 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1793 * doprnt.c (doprnt): Truncate multibyte char correctly.
1794 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1795 would mishandle a string argument "Xc" if X was a multibyte
1796 character of length 2: it would truncate after X's first byte
1797 rather than including all of X.
1799 2012-06-06 Chong Yidong <cyd@gnu.org>
1801 * buffer.c (word_wrap): Doc fix.
1803 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1805 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1807 2012-06-03 Glenn Morris <rgm@gnu.org>
1809 * xdisp.c (tool-bar-style): Doc fix.
1811 2012-06-03 Ulrich Müller <ulm@gentoo.org>
1813 * Makefile.in (PAXCTL): Define.
1814 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1815 binary via PaX flags if the paxctl utility is available.
1816 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1817 Restore PaX flags to their default. (Bug#11398)
1819 2012-06-03 Chong Yidong <cyd@gnu.org>
1821 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1824 2012-06-03 Chong Yidong <cyd@gnu.org>
1826 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1827 (note_mode_line_or_margin_highlight): If there is no help echo,
1828 use mode-line-default-help-echo. Handle the case where the mouse
1829 position is past the end of the mode line string.
1831 * buffer.c (buffer_local_value_1): New function, split from
1832 Fbuffer_local_value; can return Qunbound.
1833 (Fbuffer_local_value): Use it.
1834 (Vmode_line_format): Docstring tweaks.
1836 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1838 * sysdep.c (system_process_attributes): Improve comment.
1840 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1842 * keyboard.c: Export real-this-command to Elisp.
1843 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1844 and DEFVAR it. Update all users.
1846 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1848 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1850 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1851 Convert pctcpu and pctmem to Lisp float properly.
1852 Let the compiler fold better, as 100.0/0x8000 is exact.
1854 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1856 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1859 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1861 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1863 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1865 For a 'struct window', replace some Lisp_Object fields to
1866 bitfields where appropriate, remove unused fields.
1867 * window.h (struct window): Remove unused 'last_mark_x' and
1868 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1869 change it's type from Lisp_Object to bitfield.
1870 Change type of 'force_start', 'optional_new_start',
1871 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1872 fields from Lisp_Object to bitfield. Adjust users accordingly.
1874 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1876 Pacify gcc -Wdouble-precision when using Xaw.
1877 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1878 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1879 Use 'float' consistently, rather than 'float' in most places
1880 and 'double' in a couple of places.
1882 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1884 * xdisp.c (handle_stop): Detect whether we have overlay strings
1885 loaded by testing it->current.overlay_string_index to be
1886 non-negative, instead of checking whether n_overlay_strings is
1887 positive. (Bug#11587)
1889 2012-05-31 Chong Yidong <cyd@gnu.org>
1891 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1893 * doc.c (Fsubstitute_command_keys): Doc fix.
1895 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1897 * search.c (search_buffer): Remove calls to
1898 r_alloc_inhibit_buffer_relocation, as it is now called by
1899 maybe_unify_char, which was the cause of relocation of buffer text
1902 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1904 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1905 for the duration of call to load_charset, to avoid problems with
1906 callers of maybe_unify_char that access buffer text through C
1909 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1910 decrement the inhibition flag, instead of just setting or
1913 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1915 Remove obsolete '#define static' cruft.
1916 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1917 This #undef was "temporary" in 2000; it is no longer needed
1918 now that '#define static' has gone away.
1919 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1920 (gray_bitmap_bits): Remove; no longer needed.
1921 All uses replaced with definiens.
1922 * xterm.c: Include "bitmaps/gray.xbm".
1924 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1926 Clean up __executable_start, monstartup when --enable-profiling.
1927 The following changes affect the code only when profiling.
1928 * dispnew.c (__executable_start): Rename from safe_bcopy.
1929 Define only on platforms that need it.
1930 * emacs.c: Include <sys/gmon.h> when profiling.
1931 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1932 (__executable_start): Remove decl, since lisp.h does it now.
1933 (safe_bcopy): Remove decl; no longer has that name.
1934 (main): Coalesce #if into single bit of code, for simplicity.
1935 Cast pointers to uintptr_t, since standard libraries want integers
1937 * lisp.h (__executable_start): New decl.
1939 2012-05-31 Glenn Morris <rgm@gnu.org>
1941 * image.c (Fimagemagick_types): Doc fix.
1943 2012-05-30 Jim Meyering <meyering@redhat.com>
1945 * callproc.c (Fcall_process_region): Include directory component
1946 in mkstemp error message (Bug#11586).
1948 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1950 * alloc.c, lisp.h (make_pure_vector): Now static.
1952 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1954 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1955 Move to byte-run.el.
1956 (Fautoload): Do the hash-doc more carefully.
1957 * data.c (Fdefalias): Purify definition, except for keymaps.
1958 (Qdefun): Move from eval.c.
1959 * lisp.h (Qdefun): Remove.
1960 * lread.c (read1): Tiny simplification.
1962 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
1964 Do not create empty overlays with the evaporate property (Bug#9642).
1965 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1966 Bug#9642, but explicitly check that the buffer the overlay would
1967 be moved to is live and rearrange lines to make sure that errors
1968 will not put the overlay in an inconsistent state.
1969 (Fdelete_overlay): Cosmetics.
1971 2012-05-28 Eli Zaretskii <eliz@gnu.org>
1973 * w32term.c (my_bring_window_to_top): New function.
1974 (x_raise_frame): Use handle returned by DeferWindowPos, which
1975 could be different from the original one.
1976 Call my_bring_window_to_top instead of my_set_foreground_window.
1979 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1980 by calling BringWindowToTop.
1982 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1983 (WM_EMACS_END): Increase by one.
1985 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1987 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1988 This avoids undefined behavior that might cause the eassert
1989 to not catch an out-of-range value.
1991 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
1993 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1994 Update dependencies.
1996 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1998 * bidi.c (bidi_mirror_char): Fix last change.
2000 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2002 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2003 when referring to sectname field in printf format.
2005 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2007 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2008 Only r_alloc_inhibit_buffer_relocation needed to be added;
2009 the others were already declared.
2011 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2012 before checking whether it's out of range. Put the check inside
2014 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2016 2012-05-27 Ken Brown <kbrown@cornell.edu>
2018 * callproc.c (Fcall_process): Restore a line that was accidentally
2019 commented out in the 2011-02-13 change (bug#11547).
2021 2012-05-27 Eli Zaretskii <eliz@gnu.org>
2023 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2024 defined on ralloc.c.
2026 * buffer.c [REL_ALLOC]: Remove prototypes of
2027 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2028 they are now on lisp.h.
2030 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2032 * search.c (search_buffer): Use it to inhibit relocation of buffer
2033 text while re_search_2 is doing its job, because re_search_2 is
2034 passed C pointers to buffer text. (Bug#11519)
2036 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2039 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2040 state after an additional call to move_it_in_display_line_to, keep
2041 the values of it->max_ascent and it->max_descent found for the
2043 (pos_visible_p): Revert the comparison against bottom_y to what it
2044 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2047 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2049 Fix coding-related core dumps with gcc -ftrapv.
2050 The code was computing A - B, where A and B are pointers, and B is
2051 random garbage. This can lead to core dumps on platforms that
2052 have special pointer registers, and it also leads to core dumps on
2053 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2054 A - B only when B is initialized properly.
2055 * coding.c (coding_set_source, coding_set_destination): Return void.
2056 (coding_change_source, coding_change_destinations): New functions,
2057 with the old behaviors of coding_set_source and coding_set_destination.
2058 All callers that need an offset changed to use these new functions.
2060 2012-05-26 Glenn Morris <rgm@gnu.org>
2062 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2064 2012-05-26 Eli Zaretskii <eliz@gnu.org>
2066 Extend mouse support on W32 text-mode console.
2067 * xdisp.c (draw_row_with_mouse_face):
2068 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
2070 * w32console.c: Include window.h.
2071 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2073 (initialize_w32_display): Initialize mouse-highlight data.
2075 * w32inevt.c: Include termchar.h and window.h.
2076 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2077 moves, call note_mouse_highlight. If help_echo changed, call
2078 gen_help_event to produce help-echo message in the echo area.
2079 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2082 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2084 * lread.c (read1): Simplify slightly to avoid an overflow warning
2085 with GCC 4.7.0 on x86-64.
2087 2012-05-26 Eli Zaretskii <eliz@gnu.org>
2089 * bidi.c (bidi_mirror_char): Revert last change: an int is
2090 definitely wide enough here.
2092 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
2094 Fix integer width and related bugs (Bug#9874).
2095 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
2096 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2097 (string_bytes, check_sblock, allocate_string_data):
2098 (compact_small_strings, Fmake_bool_vector, make_string)
2099 (make_unibyte_string, make_multibyte_string)
2100 (make_string_from_bytes, make_specified_string)
2101 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2102 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2104 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2105 (allocate_pseudovector):
2106 Use int, not EMACS_INT, where int is wide enough.
2107 (inhibit_garbage_collection, Fgarbage_collect):
2108 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2109 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2110 int might not be wide enough.
2111 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2112 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2113 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2114 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2115 (bidi_level_of_next_char, bidi_move_to_visually_next):
2116 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2117 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2118 (Fkill_buffer, Fset_buffer_major_mode)
2119 (advance_to_char_boundary, Fbuffer_swap_text)
2120 (Fset_buffer_multibyte, overlays_at, overlays_in)
2121 (overlay_touches_p, struct sortvec, record_overlay_string)
2122 (overlay_strings, recenter_overlay_lists)
2123 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2124 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2125 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2126 (Foverlay_recenter, last_overlay_modification_hooks_used)
2127 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2128 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2129 (validate_region): Omit unnecessary test for b <= e,
2130 since that's guaranteed by the previous test.
2131 (adjust_overlays_for_delete): Avoid pos + length overflow.
2132 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2133 (report_overlay_modification):
2134 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2135 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2136 Omit pointer cast, which isn't needed anyway, and doesn't work
2137 after the EMACS_INT -> ptrdiff_t change.
2138 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
2139 * buffer.h: Adjust decls to match defn changes elsewhere.
2140 (struct buffer_text, struct buffer):
2141 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2142 Use EMACS_INT, not int, where int might not be wide enough.
2143 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2144 not int, to avoid needless 32-bit limit on 64-bit hosts.
2145 (exec_byte_code): Use tighter memory-full test, one that checks
2146 for alloca overflow. Don't compute the address of the object just
2147 before an array, as that's not portable. Use EMACS_INT, not
2148 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
2149 * callint.c (Fcall_interactively):
2150 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2151 * callproc.c (call_process_kill, Fcall_process):
2152 Don't assume pid_t fits into an Emacs fixnum.
2153 (call_process_cleanup, Fcall_process, child_setup):
2154 Don't assume pid_t fits into int.
2155 (call_process_cleanup, Fcall_process, delete_temp_file)
2156 (Fcall_process_region):
2157 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2158 (Fcall_process): Simplify handling of volatile integers.
2159 Use int, not EMACS_INT, where int will do.
2160 * casefiddle.c (casify_object, casify_region, operate_on_word)
2161 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2162 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2163 (casify_object): Avoid integer overflow when overallocating buffer.
2164 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
2165 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
2166 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2167 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2168 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2169 integers are now checked earlier. All uses replaced with XINT.
2171 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2172 For CCL_MapSingle, check that content and value are in int range.
2173 (ccl_driver, Fregister_code_conversion_map):
2174 Check that Vcode_version_map_vector is a vector.
2175 (resolve_symbol_ccl_program): Check that vector header is in range.
2176 Always copy the vector, so that we can check its contents reliably
2177 now rather than having to recheck each instruction as it's being
2178 executed. Check that vector words fit in 'int'.
2179 (ccl_get_compiled_code, Fregister_ccl_program)
2180 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2181 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2182 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2183 contents are in range.
2184 (Fccl_execute_on_string): Check that status is in range.
2185 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2186 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2187 Accept and return EMACS_INT, not int, because callers can pass values
2189 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2190 (multibyte_chars_in_text, parse_str_as_multibyte)
2191 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2192 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2193 (string_escape_byte8, Fget_byte):
2194 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2195 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
2196 avoid mishandling large integers.
2197 * character.h: Adjust decls to match defn changes elsewhere.
2198 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2199 (Ffind_charset_region):
2200 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2201 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2202 (load_charset_map_from_vector, Fdefine_charset_internal):
2203 Don't assume fixnum fits in int.
2204 (load_charset_map_from_vector, Fmap_charset_chars):
2205 Remove now-unnecessary CHECK_NATNUMs.
2206 (Fdefine_charset_internal): Check ranges here, more carefully.
2207 Don't rely on undefined behavior with signed left shift overflow.
2208 Don't assume unsigned int fits into fixnum, or that fixnum fits
2209 into unsigned int. Don't require max_code to be a valid fixnum;
2210 that's not true for gb10830 4-byte on a 32-bit host. Allow
2211 invalid_code to be a cons, for the same reason. Require code_offset
2212 to be a character. Avoid int overflow if max_char is close
2214 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2215 this is intended anyway and avoids some undefined behavior.
2216 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2217 INDEX_TO_CODE_POINT, as that's what it expects.
2218 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
2219 * charset.h (DECODE_CHAR): Return int, not unsigned;
2220 this is what was intended anyway, and it avoids undefined behavior.
2221 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2222 integer-overflow issues.
2223 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2224 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2225 where the argument is EMACS_INT, and this behavior is not intended.
2226 * chartab.c (Fmake_char_table, Fset_char_table_range)
2227 (uniprop_get_decoder, uniprop_get_encoder):
2228 Don't assume fixnum fits in int.
2229 * cmds.c (move_point): New function, that does the gist of
2230 Fforward_char and Fbackward_char, but does so while checking
2231 for integer overflow more accurately.
2232 (Fforward_char, Fbackward_char): Use it.
2233 (Fforward_line, Fend_of_line, internal_self_insert)
2234 (internal_self_insert):
2235 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2236 Fix a FIXME, by checking for integer overflow when calculating
2237 target_clm and actual_clm.
2238 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
2239 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
2240 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2241 (coding_alloc_by_making_gap, alloc_destination)
2242 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2243 (encode_coding_utf_16, detect_coding_emacs_mule)
2244 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2245 (detect_coding_iso_2022, decode_coding_iso_2022)
2246 (encode_invocation_designation, encode_designation_at_bol)
2247 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2248 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2249 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2250 (encode_coding_ccl, encode_coding_raw_text)
2251 (detect_coding_charset, decode_coding_charset)
2252 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2253 (produce_composition, produce_charset, produce_annotation)
2254 (decode_coding, handle_composition_annotation)
2255 (handle_charset_annotation, consume_chars, decode_coding_gap)
2256 (decode_coding_object, encode_coding_object, detect_coding_system)
2257 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2258 (code_convert_region, code_convert_string)
2259 (Fdefine_coding_system_internal)
2260 (coding_set_source, coding_set_destination):
2261 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2262 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2263 (Fdefine_coding_system_internal):
2264 Don't assume fixnums fit in int.
2265 (decode_coding_gap, decode_coding_object, encode_coding_object)
2266 (Fread_coding_system, Fdetect_coding_region)
2267 (Funencodable_char_position, Fcheck_coding_systems_region)
2268 (get_translation, handle_composition_annotation, consume_chars):
2269 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2270 (consume_chars): Rewrite to not calculate an address outside buffer.
2271 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
2272 Don't access memory outside of the args array.
2273 (Fdefine_coding_system_internal): Check for charset-id overflow.
2274 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2275 result of ENCODE_CHAR.
2276 * coding.h: Adjust decls to match defn changes elsewhere.
2277 (struct coding_system):
2278 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2279 * composite.c (get_composition_id, find_composition)
2280 (run_composition_function, update_compositions)
2281 (compose_text, composition_gstring_put_cache)
2282 (composition_gstring_p, composition_gstring_width)
2283 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2284 (composition_compute_stop_pos, composition_reseat_it)
2285 (composition_update_it, struct position_record)
2286 (find_automatic_composition, composition_adjust_point)
2287 (Fcomposition_get_gstring, Ffind_composition_internal):
2288 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2289 (update_compositions):
2290 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2291 * composite.h: Adjust decls to match defn changes elsewhere.
2292 (struct composition):
2293 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2294 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2295 Do not attempt to compute the address of the object just before a
2296 buffer; this is not portable.
2298 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2299 (Faset): Use int, not EMACS_INT, where int is wide enough.
2300 (Fstring_to_number): Don't assume fixnums fit in int.
2301 (Frem): Don't assume arg is nonnegative.
2302 * dbusbind.c (xd_append_arg): Check for integers out of range.
2303 (Fdbus_call_method): Don't overflow the timeout int.
2304 (extract_signed, extract_unsigned): New functions.
2305 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2306 (xd_get_connection_references): Return ptrdiff_t, not int.
2308 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2309 (xd_read_message_1):
2310 Use int, not unsigned, where the dbus API uses int.
2311 (Fdbus_message_internal): Don't overflow mtype.
2312 (syms_of_dbusbind): Allocate right-sized buffer for integers.
2313 * dired.c (directory_files_internal, file_name_completion, scmp)
2314 (file_name_completion_stat):
2315 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2316 (file_name_completion): Don't overflow matchcount.
2317 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2318 * dispextern.h: Adjust decls to match defn changes elsewhere.
2319 (struct text_pos, struct glyph, struct bidi_saved_info)
2320 (struct bidi_string_data, struct bidi_it, struct composition_it)
2322 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2323 (struct display_pos, struct composition_it, struct it):
2324 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2325 * dispnew.c (increment_matrix_positions)
2326 (increment_row_positions, mode_line_string)
2327 (marginal_area_string):
2328 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2329 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
2330 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2331 (duration_to_sec_usec): New function, to check for overflow better.
2332 (Fsleep_for, sit_for): Use it.
2333 * doc.c (get_doc_string, store_function_docstring):
2334 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2335 (get_doc_string, Fsnarf_documentation):
2336 Use int, not EMACS_INT, where int is wide enough.
2338 Use SAFE_ALLOCA, not alloca.
2339 Check for overflow when converting EMACS_INT to off_t.
2340 * doprnt.c (doprnt):
2341 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2342 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2343 Don't assume uid_t fits into fixnum.
2344 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2345 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2346 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2347 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2348 (general_insert_function)
2349 (Finsert_char, make_buffer_string, make_buffer_string_both)
2350 (update_buffer_properties, Fbuffer_substring)
2351 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2352 (Fsubst_char_in_region, check_translation)
2353 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2354 (transpose_markers, Ftranspose_regions):
2355 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2356 (clip_to_bounds): Move to lisp.h as an inline function).
2357 (Fconstrain_to_field): Don't assume integers are nonnegative.
2358 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2359 (Fsubst_char_in_region, Fsave_restriction):
2360 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2361 (Femacs_pid): Don't assume pid_t fits into fixnum.
2362 (lo_time): Use int, not EMACS_INT, when int suffices.
2363 (lisp_time_argument): Check for usec out of range.
2364 (Fencode_time): Don't assume fixnum fits in int.
2365 (Fuser_login_name, Fuser_full_name): Signal an error
2366 if a uid argument is out of range, rather than relying on
2368 (Fformat_time_string): Remove now-unnecessary check.
2369 lisp_time_argument checks for out-of-range usec now.
2370 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
2371 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2372 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2373 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2374 (init_cmdargs, Fdump_emacs):
2375 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2376 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2377 the bottom (typically) 32 bits of the fixnum.
2378 * eval.c (specpdl_size, call_debugger):
2379 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2380 (when_entered_debugger, Fbacktrace_debug):
2381 Don't assume fixnum can fit in int.
2382 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2383 the object just before a buffer; this is not portable.
2384 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2385 (grow_specpdl, unbind_to):
2386 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2387 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2388 (grow_specpdl): Simplify allocation by using xpalloc.
2389 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
2390 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2391 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2392 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2393 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2395 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2396 (Fcopy_file, non_regular_nbytes, read_non_regular)
2397 (Finsert_file_contents):
2398 Use int, not EMACS_INT, where int is wide enough.
2399 (READ_BUF_SIZE): Verify that it fits in int.
2400 (Finsert_file_contents): Check that counts are in proper range,
2401 rather than assuming fixnums fit into ptrdiff_t etc.
2402 Don't assume fixnums fit into int.
2403 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
2404 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2405 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
2406 (string_char_to_byte, string_byte_to_char)
2407 (string_make_multibyte, string_to_multibyte)
2408 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2409 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2410 (substring_both, Fdelete, internal_equal, Ffillarray)
2411 (Fclear_string, mapcar1)
2412 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2413 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2414 (larger_vector, make_hash_table, maybe_resize_hash_table)
2415 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2416 (Fmaphash, secure_hash):
2417 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2418 (concat): Check for string index and length overflow.
2419 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2421 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2422 (larger_vector): New API (vec, incr_min, size_max) replaces old
2423 one (vec, new_size, init). This catches size overflow.
2424 INIT was removed because it was always Qnil.
2425 All callers changed.
2426 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2427 the upper bound on a hash table index size.
2428 (make_hash_table, maybe_resize_hash_table): Use it.
2429 (secure_hash): Computer start_byte and end_byte only after
2430 they're known to be in ptrdiff_t range.
2431 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2432 (Ffont_get_glyphs, Ffont_at):
2433 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2434 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2435 (Flist_fonts, Fopen_font):
2436 Don't assume fixnum can fit in int.
2437 (check_gstring): Don't assume index can fit in int.
2438 (font_match_p): Check that fixnum is a character, not a nonnegative
2439 fixnum, since the later code needs to stuff it into an int.
2440 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2441 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2442 conversion overflow issues.
2443 (Fopen_font): Check for integer out of range.
2444 (Ffont_get_glyphs): Don't assume index can fit in int.
2445 * font.h: Adjust decls to match defn changes elsewhere.
2446 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2448 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2449 printmax_t, where ptrdiff_t is wide enough.
2450 (Finternal_char_font):
2451 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2452 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2453 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2454 (Fset_frame_position, x_set_frame_parameters)
2455 (x_set_line_spacing, x_set_border_width)
2456 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2457 Check that fixnums are in proper range for system types.
2458 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2459 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2460 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2461 Use SAFE_ALLOCA_LISP, not alloca.
2462 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2463 intptr_t is wide enough.
2464 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2465 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2466 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2467 Check for fixnum out of range.
2468 * ftfont.c (ftfont_list): Don't assume index fits in int.
2469 Check that fixnums are in proper range for system types.
2470 (ftfont_shape_by_flt):
2471 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2472 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2473 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2474 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2475 Check that fixnums are in proper range for system types.
2476 * gnutls.h: Adjust decls to match defn changes elsewhere.
2477 * gtkutil.c (xg_dialog_run):
2478 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2479 (update_frame_tool_bar):
2480 Check that fixnums are in proper range for system types.
2481 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
2482 (lookup_image): Check that fixnums are in range for system types.
2483 * indent.c (last_known_column, last_known_column_point):
2484 (current_column_bol_cache):
2485 (skip_invisible, current_column, check_display_width):
2486 (check_display_width, scan_for_column, current_column_1)
2487 (Findent_to, Fcurrent_indentation, position_indentation)
2488 (indented_beyond_p, Fmove_to_column, compute_motion):
2489 (Fcompute_motion, Fvertical_motion):
2490 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2491 (last_known_column_modified): Use EMACS_INT, not int.
2492 (check_display_width):
2494 Check that fixnums and floats are in proper range for system types.
2495 (compute_motion): Don't assume index or fixnum fits in int.
2496 (compute_motion, Fcompute_motion):
2497 Use int, not EMACS_INT, when it is wide enough.
2498 (vmotion): Omit local var start_hpos that is always 0; that way
2499 we don't need to worry about overflow in expressions involving it.
2500 * indent.h: Adjust decls to match defn changes elsewhere.
2502 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2503 Use int, not EMACS_INT, where int is wide enough.
2504 Remove unused members ovstring_chars_done and tab_offset;
2506 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2507 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2508 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2509 (make_gap, copy_text, insert, insert_and_inherit)
2510 (insert_before_markers, insert_before_markers_and_inherit)
2511 (insert_1, count_combining_before, count_combining_after)
2512 (insert_1_both, insert_from_string)
2513 (insert_from_string_before_markers, insert_from_string_1)
2514 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2515 (adjust_after_replace, adjust_after_insert, replace_range)
2516 (replace_range_2, del_range, del_range_1, del_range_byte)
2517 (del_range_both, del_range_2, modify_region)
2518 (prepare_to_modify_buffer, signal_before_change)
2519 (signal_after_change, Fcombine_after_change_execute):
2520 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2521 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2522 (balance_an_interval, split_interval_right, split_interval_left)
2523 (find_interval, next_interval, update_interval)
2524 (adjust_intervals_for_insertion, delete_node, delete_interval)
2525 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2526 (static_offset_intervals, offset_intervals)
2527 (merge_interval_right, merge_interval_left, make_new_interval)
2528 (graft_intervals_into_buffer, temp_set_point_both)
2529 (temp_set_point, set_point, adjust_for_invis_intang)
2530 (set_point_both, move_if_not_intangible, get_property_and_range)
2531 (get_local_map, copy_intervals, copy_intervals_to_string)
2532 (compare_string_intervals, set_intervals_multibyte_1):
2533 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2534 * intervals.h: Adjust decls to match defn changes elsewhere.
2536 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2537 * keyboard.c (this_command_key_count, this_single_command_key_start)
2538 (before_command_key_count, before_command_echo_length, echo_now)
2539 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2540 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2541 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2542 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2543 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2544 (last_non_minibuf_size, last_point_position, echo_truncate)
2545 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2546 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2547 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2548 (stuff_buffered_input):
2549 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2550 (last_auto_save, command_loop_1, read_char):
2551 Use EMACS_INT, not int, to avoid integer overflow.
2552 (record_char): Avoid overflow in total_keys computation.
2553 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2554 * keyboard.h: Adjust decls to match defn changes elsewhere.
2555 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2556 (Fkey_description, Fdescribe_vector, Flookup_key):
2557 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2558 (click_position): New function, to check that positions are in range.
2559 (Fcurrent_active_maps):
2561 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2562 (Faccessible_keymaps, Fkey_description):
2563 (preferred_sequence_p):
2564 Don't assume fixnum can fit into int.
2565 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2566 Check for integer overflow in size calculations.
2567 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2568 avoid mishandling large integers.
2569 * lisp.h: Adjust decls to match defn changes elsewhere.
2570 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2571 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2572 (struct Lisp_Marker):
2573 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2574 (clip_to_bounds): Now an inline function, moved here from editfns.c.
2575 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2576 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2577 All callers changed.
2578 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2579 Assume the arg has valid form, since it always does.
2580 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2581 unsigned integer system type.
2582 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2583 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2584 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2585 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2586 (duration_to_sec_usec): New decl.
2587 * lread.c (read_from_string_index, read_from_string_index_byte)
2588 (read_from_string_limit, readchar, unreadchar, openp)
2589 (read_internal_start, read1, oblookup):
2590 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2591 (Fload, readevalloop, Feval_buffer, Feval_region):
2592 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2593 (openp): Check for out-of-range argument to 'access'.
2594 (read1): Use int, not EMACS_INT, where int is wide enough.
2595 Don't assume fixnum fits into int.
2596 Fix off-by-one error that can read outside a buffer.
2597 (read_filtered_event): Use duration_to_sec_usec
2598 to do proper overflow checking on durations.
2599 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2600 in size calculation.
2601 (Fexecute_kbd_macro):
2602 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2603 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2604 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2605 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2606 (set_marker_both, set_marker_restricted_both, marker_position)
2607 (marker_byte_position, Fbuffer_has_markers_at):
2608 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2609 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
2610 * menu.c (ensure_menu_items): Rename from grow_menu_items.
2611 It now merely ensures that the menu is large enough, without
2612 necessarily growing it, as this avoids some integer overflow issues.
2613 All callers changed.
2614 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2615 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2616 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2617 Use SAFE_ALLOCA_LISP, not alloca.
2618 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2619 to EMACS_INT. Check that fixnums are in proper range for system types.
2620 * minibuf.c (minibuf_prompt_width, string_to_object)
2621 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2622 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2623 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2624 (get_minibuffer, read_minibuf_unwind):
2625 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2626 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2627 this simplifies overflow checking. All callers changed.
2628 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2630 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2631 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2632 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2633 Check that fixnums are in proper range for system types.
2634 (Fx_create_frame, Fx_show_tip):
2635 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2636 * nsfont.m (ns_findfonts, nsfont_list_family):
2637 Don't assume fixnum fits in long.
2638 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2639 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2640 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2642 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
2643 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2644 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2645 (PRINTDECLARE, PRINTPREPARE):
2646 (strout, print_string):
2647 (print, print_preprocess, print_check_string_charset_prop)
2649 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2651 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2652 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2653 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
2654 (printchar, strout): Use xpalloc to catch size calculation overflow.
2655 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
2656 (print_error_message): Use SAFE_ALLOCA, not alloca.
2657 (print_object): Use int, not EMACS_INT, where int is wide enough.
2658 (print_depth, new_backquote_output, print_number_index):
2659 Use ptrdiff_t, not int, where int might not be wide enough.
2660 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2661 (Fset_process_window_size, Fformat_network_address)
2662 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
2664 Check that fixnums are in proper range for system types.
2665 (Fsignal_process): Simplify by avoiding a goto.
2666 Check for process-ids out of pid_t range rather than relying on
2668 (process_tick, update_tick): Use EMACS_INT, not int.
2669 (Fformat_network_address, read_process_output, send_process)
2670 (Fprocess_send_region, status_notify):
2671 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2672 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2673 (wait_reading_process_output, read_process_output, exec_sentinel):
2674 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2675 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2676 (Faccept_process_output): Use duration_to_sec_usec to do proper
2677 overflow checking on durations.
2678 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2679 Don't assume pid_t fits in int.
2680 * process.h (struct Lisp_Process): Members tick and update_tick
2681 are now of type EMACS_INT, not int.
2682 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2683 configured --with-wide-int.
2684 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2685 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2686 * search.c (looking_at_1, string_match_1):
2687 (fast_string_match, fast_c_string_match_ignore_case)
2688 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2689 (scan_newline, find_before_next_newline, search_command)
2690 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2691 (set_search_regs, wordify):
2694 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2695 (string_match_1, search_buffer, set_search_regs):
2697 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2698 (wordify): Check for overflow in size calculation.
2699 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2700 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2701 Check that fixnums are in proper range for system types.
2702 * sound.c (struct sound_device)
2703 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2704 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2705 (Fplay_sound_internal):
2706 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2707 * syntax.c (struct lisp_parse_state, find_start_modiff)
2708 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2709 (Fparse_partial_sexp):
2710 Don't assume fixnums can fit in int.
2711 (struct lisp_parse_state, find_start_pos, find_start_value)
2712 (find_start_value_byte, find_start_begv)
2713 (update_syntax_table, char_quoted, dec_bytepos)
2714 (find_defun_start, prev_char_comend_first, back_comment):
2715 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2716 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2717 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2718 (Finternal_describe_syntax_value): Check that match_lisp is a
2719 character, not an integer, since the code stuffs it into int.
2720 (scan_words, scan_sexps_forward):
2721 Check that fixnums are in proper range for system types.
2723 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2724 (scan_sexps_forward):
2725 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2726 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2727 * syntax.h: Adjust decls to match defn changes elsewhere.
2728 (struct gl_state_s):
2729 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2730 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2731 MOST_POSITIVE_FIXNUM.
2732 * sysdep.c (wait_for_termination_1, wait_for_termination)
2733 (interruptible_wait_for_termination, mkdir):
2734 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2735 (emacs_read, emacs_write):
2736 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2737 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2738 and double all fit in int.
2739 * term.c (set_tty_color_mode):
2740 Check that fixnums are in proper range for system types.
2741 * termhooks.h (struct input_event):
2742 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2743 * textprop.c (validate_interval_range, interval_of)
2744 (Fadd_text_properties, set_text_properties_1)
2745 (Fremove_text_properties, Fremove_list_of_text_properties)
2746 (Ftext_property_any, Ftext_property_not_all)
2747 (copy_text_properties, text_property_list, extend_property_ranges)
2748 (verify_interval_modification):
2749 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2750 (Fnext_single_char_property_change)
2751 (Fprevious_single_char_property_change):
2752 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2753 (copy_text_properties):
2754 Check for integer overflow in index calculation.
2755 * undo.c (last_boundary_position, record_point, record_insert)
2756 (record_delete, record_marker_adjustment, record_change)
2757 (record_property_change):
2758 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2759 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2760 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2761 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2762 (Fx_hide_tip, Fx_file_dialog):
2763 * w32menu.c (set_frame_menubar):
2764 Use ptrdiff_t, not int, for consistency with rest of code.
2765 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2766 (select_window, Fdelete_other_windows_internal)
2767 (window_scroll_pixel_based, window_scroll_line_based)
2768 (Frecenter, Fset_window_configuration):
2769 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2770 (Fset_window_hscroll, run_window_configuration_change_hook)
2771 (set_window_buffer, temp_output_buffer_show, scroll_command)
2772 (Fscroll_other_window, Frecenter):
2773 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2774 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2775 Don't assume fixnum fits in int.
2776 (Fset_window_scroll_bars):
2777 Check that fixnums are in proper range for system types.
2778 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2779 (string_pos, c_string_pos, number_of_chars, init_iterator)
2780 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2781 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2782 (compute_display_string_end, handle_face_prop)
2783 (face_before_or_after_it_pos, handle_invisible_prop)
2784 (handle_display_prop, handle_display_spec, handle_single_display_spec)
2785 (display_prop_intangible_p, string_buffer_position_lim)
2786 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2787 (get_overlay_strings_1, get_overlay_strings)
2788 (iterate_out_of_display_property, forward_to_next_line_start)
2789 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2790 (get_next_display_element, set_iterator_to_next)
2791 (get_visually_first_element, compute_stop_pos_backwards)
2792 (handle_stop_backwards, next_element_from_buffer)
2793 (move_it_in_display_line_to, move_it_in_display_line)
2794 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2795 (add_to_log, message_dolog, message_log_check_duplicate)
2796 (message2, message2_nolog, message3, message3_nolog
2797 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2798 (current_message_1, truncate_echo_area, truncate_message_1)
2799 (set_message, set_message_1, store_mode_line_noprop)
2800 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2801 (text_outside_line_unchanged_p, check_point_in_composition)
2802 (reconsider_clip_changes)
2803 (redisplay_internal, set_cursor_from_row, try_scrolling)
2804 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2805 (redisplay_window, find_last_unchanged_at_beg_row)
2806 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2807 (trailing_whitespace_p, find_row_edges, display_line)
2808 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2809 (display_mode_element, store_mode_line_string)
2810 (pint2str, pint2hrstr, decode_mode_spec)
2811 (display_count_lines, display_string, draw_glyphs)
2812 (x_produce_glyphs, x_insert_glyphs)
2813 (rows_from_pos_range, mouse_face_from_buffer_pos)
2814 (fast_find_string_pos, mouse_face_from_string_pos)
2815 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2816 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2817 (safe_call, init_from_display_pos, handle_fontified_prop)
2818 (handle_single_display_spec, load_overlay_strings)
2819 (with_echo_area_buffer, setup_echo_area_for_printing)
2820 (display_echo_area, echo_area_display)
2821 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2822 (update_tool_bar, hscroll_window_tree, redisplay_internal)
2823 (redisplay_window, dump_glyph_row, display_mode_line)
2824 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
2825 (handle_display_spec, display_prop_string_p):
2826 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2827 (handle_single_display_spec, build_desired_tool_bar_string)
2828 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2829 (get_specified_cursor_type):
2830 Check that fixnums are in proper range for system types.
2831 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2832 (Flookup_image_map):
2833 Don't assume fixnums fit in int.
2834 (compare_overlay_entries):
2835 Avoid mishandling comparisons due to subtraction overflow.
2836 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2837 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2838 (handle_tool_bar_click):
2839 Use int, not unsigned, since we prefer signed and the signedness
2840 doesn't matter here.
2841 (get_next_display_element, next_element_from_display_vector):
2842 Use int, not EMACS_INT, when int is wide enough.
2843 (start_hourglass): Use duration_to_sec_usec to do proper
2844 overflow checking on durations.
2845 * xfaces.c (Fbitmap_spec_p):
2846 Check that fixnums are in proper range for system types.
2847 (compare_fonts_by_sort_order):
2848 Avoid mishandling comparisons due to subtraction overflow.
2849 (Fx_family_fonts, realize_basic_faces):
2850 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2852 Don't assume fixnum fits in int.
2853 Use SAFE_ALLOCA_LISP, not alloca.
2854 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2855 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2856 (face_at_buffer_position, face_for_overlay_string)
2857 (face_at_string_position):
2858 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2859 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2860 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2862 Check that fixnums are in proper range for system types.
2863 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2864 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2865 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2866 (Fx_change_window_property): Don't assume fixnums fit in int.
2867 * xfont.c (xfont_chars_supported):
2868 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2869 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2870 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2871 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2872 * xml.c (parse_region):
2873 * xrdb.c (magic_file_p):
2874 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2875 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2876 (x_get_local_selection, x_reply_selection_request)
2877 (x_handle_selection_request, wait_for_property_change):
2878 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2879 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2880 short is wide enough.
2881 (x_send_client_event): Don't assume fixnum fits in int.
2882 * xterm.c (x_x_to_emacs_modifiers):
2883 Don't assume EMACS_INT overflows nicely into int.
2884 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2886 (handle_one_xevent): NATNUMP can eval its arg twice.
2887 (x_connection_closed):
2888 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2889 * xterm.h: Adjust decls to match defn changes elsewhere.
2890 (struct scroll_bar): Use struct vectorlike_header
2891 rather than rolling our own approximation.
2892 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2894 2012-05-25 Glenn Morris <rgm@gnu.org>
2896 * lisp.mk (lisp): Update for more files being compiled now.
2898 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2900 * lread.c: Remove `read_pure' which makes no difference.
2901 (read_pure): Remove var.
2902 (unreadpure): Remove function.
2903 (readevalloop): Don't call read_list with -1 flag.
2904 (read1, read_vector): Don't test read_pure any more.
2905 (read_list): Simplify.
2907 * fileio.c, character.h: Minor style tweaks.
2909 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2911 * window.h (clip_changed): Remove useless declaration.
2913 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
2915 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2916 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2918 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2921 This directory predates autoconf and is no longer needed nowadays.
2922 Move its few remaining bits of functionality to where they're needed.
2923 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2924 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2925 * m/template.h: Remove.
2926 * Makefile.in (M_FILE): Remove. All uses removed.
2927 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2928 * lisp.h (USE_LSB_TAG):
2929 * mem-limits.h (EXCEEDS_LISP_PTR):
2930 Use VAL_MAX, not VALBITS, in #if.
2931 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2932 (EMACS_UINT): Define unconditionally now.
2933 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2934 (BITS_PER_EMACS_INT): New constants, replacing
2935 what used to be in config.h, but not useful in #if.
2936 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2937 define them any more.
2938 (VAL_MAX): New macro.
2940 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2941 BITS_PER_EMACS_INT, in #if.
2942 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2943 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2944 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2945 * s/ms-w32.h (DATA_START):
2946 Move here from removed file m/intel386.h.
2947 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2948 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2950 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2952 Assume C89 or later.
2953 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2954 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2956 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2957 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2958 * textprop.c, tparam.c (NULL): Remove.
2959 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2960 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2961 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2962 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2963 * xterm.c (input_signal_count): Assume volatile works.
2965 2012-05-21 Ken Brown <kbrown@cornell.edu>
2967 * xgselect.c (xg_select): Fix first argument in call to 'select'
2970 2012-05-20 Ken Brown <kbrown@cornell.edu>
2972 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
2973 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
2975 2012-05-19 Ken Brown <kbrown@cornell.edu>
2977 * xfns.c (x_in_use): Remove `static' qualifier.
2978 * xterm.h (x_in_use): Declare.
2979 * xgselect.c: Include xterm.h.
2980 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2981 and `display_arg' (bug#9754).
2983 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2985 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2987 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2988 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2990 2012-05-18 Eli Zaretskii <eliz@gnu.org>
2992 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2994 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2995 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
2997 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2998 reference to image_cache->refcount.
2999 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3001 2012-05-17 Juri Linkov <juri@jurta.org>
3003 * search.c (Fword_search_regexp, Fword_search_backward)
3004 (Fword_search_forward, Fword_search_backward_lax)
3005 (Fword_search_forward_lax): Move functions to isearch.el
3006 (bug#10145, bug#11381).
3008 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3010 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3012 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3014 * lread.c (init_obarray): Declare Qt and Qnil as special.
3016 2012-05-14 Glenn Morris <rgm@gnu.org>
3018 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
3019 Put "libexec" before "bin", for the sake of init_callproc_1.
3021 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3023 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3025 * unexaix.c: Port to more-recent AIX compilers.
3026 (report_error, report_error_1, make_hdr, copy_sym)
3027 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3028 Make arguments const char *, not char *, to avoid violations of C
3029 standard and to fix some AIX warnings reported by Gilles Pion.
3031 2012-05-14 Eli Zaretskii <eliz@gnu.org>
3033 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3034 already have overlays loaded.
3035 (handle_single_display_spec): Before returning without displaying
3036 fringe bitmap, synchronize the bidi iterator with the main display
3037 iterator, by calling iterate_out_of_display_property.
3038 (iterate_out_of_display_property): Detect buffer iteration by
3039 testing that it->string is a Lisp string.
3040 (get_next_display_element): When the current object is exhausted,
3041 and there's something on it->stack, call set_iterator_to_next to
3042 proceed with what's on the stack, instead of returning zero.
3043 (set_iterator_to_next): If called at the end of a Lisp string,
3044 proceed to consider_string_end without incrementing string
3045 position. Don't increment display vector index past the end of
3046 the display vector. (Bug#11417)
3047 (pos_visible_p): Don't report a position visible when move_it_to
3048 stopped at the last line of window, which happens to be scanned
3049 backwards by the bidi iteration. (Bug#11464)
3051 2012-05-14 Eli Zaretskii <eliz@gnu.org>
3053 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3054 and right-margin display specs even if the spec is invalid or we
3055 are on a TTY, and thus unable to display on the fringes.
3056 That's because the text with the property will not be displayed anyway,
3057 so we need to signal to the caller that this is a "replacing"
3058 display spec. This fixes display when the spec is invalid or we
3061 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3063 * unexaix.c (make_hdr): Fix typo in prototype.
3064 This bug broke the build on AIX. Problem reported by Gilles Pion.
3066 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
3068 * keyboard.c (kbd_buffer_get_event): Read special events also in
3069 batch mode. (Bug#11415)
3071 2012-05-12 Glenn Morris <rgm@gnu.org>
3073 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3075 2012-05-12 Eli Zaretskii <eliz@gnu.org>
3077 * lisp.mk (lisp): Add newcomment.elc.
3079 2012-05-12 Glenn Morris <rgm@gnu.org>
3081 * Makefile.in (MKDIR_P): New, set by configure.
3082 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3084 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3086 Remove unused function hourglass_started.
3087 * dispextern.h (hourglass_started):
3088 * w32fns.c (hourglass_started):
3089 * xdisp.c (hourglass_started): Remove.
3091 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
3093 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3094 Update dependencies.
3096 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3098 * xgselect.c (xg_select): Put maxfds+1 into a var.
3099 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3101 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3103 2012-05-10 Dave Abrahams <dave@boostpro.com>
3105 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3106 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3108 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
3110 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3111 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3112 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3113 Initialize xd_registered_buses.
3115 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3117 Untag more efficiently if USE_LSB_TAG.
3118 This is based on a proposal by YAMAMOTO Mitsuharu in
3119 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3120 For an admittedly artificial (nth 8000 longlist) benchmark on
3121 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3122 Emacs's overall text size by 1%.
3123 * lisp.h (XUNTAG): New macro.
3124 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3125 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3126 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3127 * eval.c (Fautoload):
3128 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3129 * frame.h (XFRAME): Use XUNTAG.
3131 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3132 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3133 Remove unportable assumptions about print widths of types like
3135 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3136 intptr_t when converting between pointer and integer, to avoid GCC
3137 warnings about wrong width.
3139 2012-05-09 Eli Zaretskii <eliz@gnu.org>
3141 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3142 stack for each reader_thread, instead of defaulting to 8MB
3143 determined by the linker. This avoids failures in creating
3144 subprocesses on Windows 7, see the discussion in this thread:
3145 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3147 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3149 Fix up display of the *Minibuf-0* buffer in the mini window.
3150 * keyboard.c (read_char): Don't clear the echo area if there's no
3152 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
3153 contents of *Minibuf-0*) if there's no message displayed in its stead.
3155 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
3157 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3160 2012-05-06 Chong Yidong <cyd@gnu.org>
3162 * lisp.mk (lisp): Update.
3164 2012-05-05 Jim Meyering <meyering@redhat.com>
3166 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3168 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3170 * data.c (PUT_ERROR): New macro.
3171 (syms_of_data): Use it. Add new error type `user-error'.
3172 * undo.c (user_error): New function.
3173 (Fprimitive_undo): Use it.
3174 * print.c (print_error_message): Adjust print style for `user-error'.
3175 * keyboard.c (user_error): New function.
3176 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3178 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3180 Do not limit current-time-string to years 1000..9999.
3181 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3182 (Fcurrent_time_string): Support any year that is supported by the
3183 underlying localtime representation. Don't use asctime, as it
3184 has undefined behavior for years outside the range -999..9999.
3186 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3188 Fix race conditions involving setenv, gmtime, localtime, asctime.
3189 Without this fix, interrupts could mess up code that uses these
3190 nonreentrant functions, since setting TZ invalidates existing
3191 tm_zone or tzname values, and since most of these functions return
3192 pointers to static storage.
3193 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3194 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3195 Grow the critical sections to include not just invoking
3196 localtime/gmtime, but also accessing these functions' results
3197 including their tm_zone values if any, and any related TZ setting.
3198 (format_time_string): Last arg is now struct tm *, not struct tm **,
3199 so that the struct tm is saved in the critical section.
3200 All callers changed. Simplify allocation of initial buffer, partly
3201 motivated by the fact that memory allocation needs to be outside
3202 the critical section.
3204 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3206 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3207 with RESET_INTERVAL.
3209 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3210 Remove duplicated buffer name initialization.
3212 2012-05-02 Jim Meyering <jim@meyering.net>
3214 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3216 * xfns.c (x_window): Use xstrdup (Bug#11375).
3218 2012-05-02 Eli Zaretskii <eliz@gnu.org>
3220 * xdisp.c (pos_visible_p): If already at a newline from the
3221 display string before the 'while' loop, don't walk back the glyphs
3222 from it3.glyph_row. Solves assertion violation when the display
3223 string begins with a newline (egg.el). (Bug#11367)
3225 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3227 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3230 2012-05-01 Glenn Morris <rgm@gnu.org>
3232 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3233 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3234 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3235 All were removed before 23.1.
3237 * dispnew.c: Remove HAVE_LIBNCURSES test;
3238 it is always true on relevant platforms.
3240 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3241 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3243 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3245 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3247 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3248 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3251 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3253 Do not avoid creating empty evaporating overlays (Bug#9642).
3254 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3255 That is, do not delete an evaporating overlay if it becomes
3256 empty after its bounds are adjusted to fit within its buffer.
3257 This fix caused other problems, and I'm reverting it until we get
3258 to the bottom of them.
3260 2012-04-27 Chong Yidong <cyd@gnu.org>
3262 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3264 2012-04-27 Eli Zaretskii <eliz@gnu.org>
3266 * xdisp.c (pos_visible_p): If the window start position is beyond
3267 ZV, start the display from buffer beginning. Prevents assertion
3268 violation in init_iterator when the minibuffer window is scrolled
3271 * window.c (window_scroll_pixel_based): Likewise.
3273 2012-04-27 Chong Yidong <cyd@gnu.org>
3275 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3277 2012-04-27 Glenn Morris <rgm@gnu.org>
3279 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3280 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3282 2012-04-27 Eli Zaretskii <eliz@gnu.org>
3284 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3285 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
3287 2012-04-26 Eli Zaretskii <eliz@gnu.org>
3289 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3290 display element, check also the underlying string or buffer
3291 character. (Bug#11341)
3293 * w32menu.c: Include w32heap.h.
3294 (add_menu_item): If the call to AppendMenuW (via
3295 unicode_append_menu) fails, disable Unicode menus only if we are
3296 running on Windows 9X/Me.
3298 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3300 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3301 (xgetint): Add missing shift for LSB tags.
3303 2012-04-24 Martin Rudalics <rudalics@gmx.at>
3305 * keyboard.c (read_char): Don't wipe echo area for select window
3306 events: These might get delayed via `mouse-autoselect-window'
3309 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
3311 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3312 manipulation of :loaded-from data.
3314 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
3316 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3317 now a cons (bug#11311).
3319 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3321 Do not create empty overlays with the evaporate property (Bug#9642).
3322 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3323 if it becomes empty after its bounds are adjusted to fit within
3324 its buffer. Without this fix, in a nonempty buffer (let ((o
3325 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3326 yields an empty overlay that has the evaporate property, which is
3327 not supposed to happen.
3329 Fix minor GTK3 problems found by static checking.
3330 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3331 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3332 (struct _EmacsFixedClass, emacs_fixed_get_type):
3333 Move decls here from emacsgtkfixed.h, since they needn't be public.
3334 (emacs_fixed_get_type): Now static.
3335 (emacs_fixed_class_init): Omit unused local.
3336 (emacs_fixed_child_type): Remove; unused.
3337 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3338 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3339 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3340 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3341 (EMACS_FIXED_GET_CLASS): Remove; unused.
3342 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3344 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3345 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3347 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3349 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
3350 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
3351 (__malloc_size_t, __malloc_ptrdiff_t):
3352 Remove. All uses removed, replaced by the definiens if needed,
3353 since we can assume C89 or better now.
3354 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3355 (protect_malloc_state, align, get_contiguous_space)
3356 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3357 (malloc_atfork_handler_child, malloc_enable_thread)
3358 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3359 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3360 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3361 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3362 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3363 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3364 Define using prototypes, not old style.
3365 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3366 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3367 (align): Don't assume that signed integer overflow wraps around.
3368 Omit unused local var.
3369 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3370 (_free_internal_nolock, memalign, mallochook, reallochook):
3371 Omit no-longer-needed casts.
3372 (valloc): Use getpagesize, not __getpagesize.
3373 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3374 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3376 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3378 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
3380 Move functions from C to Lisp. Make non-blocking method calls
3381 the default. Implement further D-Bus standard interfaces.
3383 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3384 (QCdbus_request_name_allow_replacement)
3385 (QCdbus_request_name_replace_existing)
3386 (QCdbus_request_name_do_not_queue)
3387 (QCdbus_request_name_reply_primary_owner)
3388 (QCdbus_request_name_reply_in_queue)
3389 (QCdbus_request_name_reply_exists)
3390 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3391 (QCdbus_registered_serial, QCdbus_registered_method)
3392 (QCdbus_registered_signal): New Lisp objects.
3393 (XD_DEBUG_MESSAGE): Use sizeof.
3394 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3395 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3396 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3397 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3398 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3399 (xd_signature, xd_append_arg): Allow float for integer types.
3400 (xd_get_connection_references): New function.
3401 (xd_get_connection_address): Rename from xd_initialize.
3402 Return cached address.
3403 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3404 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3406 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
3407 Return number of refcounts.
3408 (Fdbus_get_unique_name): Make stronger parameter check.
3409 (Fdbus_message_internal): New defun.
3410 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3411 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3412 (Fdbus_send_signal, Fdbus_register_service)
3413 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3414 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3415 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3416 (Vdbus_compiled_version, Vdbus_runtime_version)
3417 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3418 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3419 (Vdbus_message_type_signal): New defvars.
3420 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3423 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3425 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3426 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3427 Do not assume ptrdiff_t is the same width as 'int'.
3429 * alloc.c: Handle unusual debugging option combinations.
3430 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3431 since the two debugging options are incompatible.
3432 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3434 (mem_init, mem_insert, mem_insert_fixup):
3435 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3436 (NEED_MEM_INSERT): Remove; no longer needed.
3438 2012-04-22 Leo Liu <sdl.web@gmail.com>
3440 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3442 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3444 * sysdep.c [__FreeBSD__]: Minor cleanups.
3445 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3446 Use Emacs indenting style more consistently. Avoid some casts.
3447 Use 'double' consistently rather than mixing 'float' and 'double'.
3449 2012-04-21 Eduard Wiebe <usenet@pusto.de>
3451 * sysdep.c (list_system_processes, system_process_attributes):
3452 Add implementation for FreeBSD (Bug#5243).
3454 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3456 * lisp.mk (lisp): Update.
3458 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3460 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3461 It is never used otherwise.
3463 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3465 * print.c (print_preprocess): Only check print_depth if print-circle
3467 (print_object): Check for cycles even when print-circle is nil and
3468 print-gensym is t, but only check print_depth if print-circle is nil.
3470 2012-04-20 Chong Yidong <cyd@gnu.org>
3472 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3473 set the status to "failed" and ensure that sentinel is run.
3475 2012-04-20 Glenn Morris <rgm@gnu.org>
3477 * process.c (Fset_process_inherit_coding_system_flag)
3478 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
3479 (Fmake_network_process, Fmake_serial_process): Doc fix.
3481 2012-04-20 Eli Zaretskii <eliz@gnu.org>
3483 * xdisp.c (string_buffer_position_lim): Limit starting position to
3485 (set_cursor_from_row): If called for a mode-line or header-line
3486 row, return zero immediately.
3487 (try_cursor_movement): If inside continuation line, don't back up
3488 farther than the first row after the header line, if any.
3489 Don't consider the header-line row as "partially visible", even if
3490 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3492 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
3494 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3497 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
3498 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
3500 configure: new option --enable-gcc-warnings (Bug#11207)
3501 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3502 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3503 (ALL_CFLAGS): Use new macros rather than old.
3504 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3505 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3506 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3507 -Wunused-result, -Wunused-variable. This should go away once
3508 the Emacs and Gnulib regex code is merged.
3509 (xmalloc, xrealloc): Now static.
3511 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3513 * dired.c (Fsystem_groups): Remove unused local.
3515 2012-04-17 Glenn Morris <rgm@gnu.org>
3517 * dired.c (Fsystem_users): Doc fix.
3519 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3521 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3522 (syms_of_dired): Add them.
3524 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3526 Fix minor alloc.c problems found by static checking.
3527 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3528 New extern decls, to avoid calling undeclared functions.
3529 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3530 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3531 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3532 (NEED_MEM_INSERT): New macro.
3533 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
3534 Remove one incorrect comment and fix another.
3536 Fix minor ralloc.c problems found by static checking.
3537 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3538 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3539 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3540 (r_alloc_sbrk): Now static.
3542 Improve ralloc.c interface checking.
3543 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3544 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3545 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3546 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3547 [REL_ALLOC]: ... to here, to check interface.
3548 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3549 Remove decls. This fixes an "It stinks!".
3551 * alloc.c (which_symbols): Fix alignment issue / type clash.
3553 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3555 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3556 (struct Lisp_Misc_Any): Likewise.
3557 (struct Lisp_Free): Likewise.
3558 * alloc.c (union aligned_Lisp_Symbol): Define.
3559 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3560 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3561 (union aligned_Lisp_Misc): Define.
3562 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3563 aligned_Lisp_Misc instead of union Lisp_Misc.
3564 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
3566 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3568 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3569 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3570 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3571 * s/netbsd.h, s/sol2-6.h:
3572 Remove definition of GC_MARK_STACK, since the default now works.
3573 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3574 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3575 no longer the default.
3576 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3578 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
3580 * lread.c (lisp_file_lexically_bound_p):
3581 Fix hang at ";-*-\n" (bug#11238).
3583 2012-04-14 Eli Zaretskii <eliz@gnu.org>
3585 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3586 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3588 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3590 * nsterm.m (constrainFrameRect): Always constrain when there is only
3591 one screen (Bug#10962).
3593 2012-04-13 Ken Brown <kbrown@cornell.edu>
3595 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3597 2012-04-13 Reuben Thomas <rrt@sc3d.org>
3599 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3601 2012-04-11 Daniel Colascione <dancol@dancol.org>
3603 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3604 against is gone. It's better to use vfork now so that when Cygwin
3605 gains a new, working vfork, we use it automatically (bug#10398).
3607 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3609 * window.c (save_window_save): Obey window-point-insertion-type.
3611 2012-04-11 Glenn Morris <rgm@gnu.org>
3613 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3615 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3617 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3619 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
3621 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3622 (force_quit_count): New var.
3623 (handle_interrupt): Use it.
3625 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
3627 * w32.c (w32_delayed_load): Record the full path of the library
3628 being loaded (bug#10424).
3630 2012-04-09 Glenn Morris <rgm@gnu.org>
3632 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3633 not just in the obarray, before snarfing them. (Bug#11036)
3635 * Makefile.in ($(leimdir)/leim-list.el):
3636 Pass EMACS rather than BUILT_EMACS.
3638 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3640 * process.c (make_process):
3641 * process.h: Add integer `gnutls_handshakes_tried' member to
3644 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3645 Add convenience `GNUTLS_LOG2i' macro.
3647 * gnutls.c (gnutls_log_function2i): Convenience log function.
3648 (emacs_gnutls_read): Use new log functions,
3649 `gnutls_handshakes_tried' process member, and
3650 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3651 attempts per process (connection).
3653 2012-04-09 Chong Yidong <cyd@gnu.org>
3655 * eval.c (Fuser_variable_p, user_variable_p_eh)
3656 (lisp_indirect_variable): Functions deleted.
3657 (Fdefvar): Caller changed.
3659 * callint.c (Finteractive, Fcall_interactively):
3660 * minibuf.c (Fread_variable): Callers changed.
3662 2012-04-09 Eli Zaretskii <eliz@gnu.org>
3664 * xdisp.c (set_cursor_from_row): If the display string appears in
3665 the buffer at position that is closer to point than the position
3666 after the display string, display the cursor on the first glyph of
3667 the display string. Fixes cursor display when a 'display' text
3668 property immediately follows invisible text. (Bug#11094)
3670 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3672 composite.c: use 'double' consistently
3673 * composite.c (get_composition_id): Use 'double' consistently
3674 instead of converting 'float' to 'double' and vice versa; this is
3675 easier to understand and avoids a GCC warning.
3677 2012-04-09 Glenn Morris <rgm@gnu.org>
3679 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3680 preparation for dumping it with emacs. (Bug#4789)
3681 (leimdir): New variable.
3682 ($(leimdir)/leim-list.el): New rule.
3683 (emacs$(EXEEXT)): Depend on leim-list.el.
3685 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3686 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3687 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3689 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3691 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3694 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
3696 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3697 Remove unused local variable.
3699 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3701 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3702 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3703 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3704 objects, as mark_maybe_pointer will catch them otherwise.
3705 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3706 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3708 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3710 Fix typo that broke non-Windows builds.
3711 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3713 2012-04-07 Eli Zaretskii <eliz@gnu.org>
3715 Support building on MS-Windows with libxml2.
3717 * makefile.w32-in (OBJ2): Add xml.$(O).
3718 (GLOBAL_SOURCES): Add xml.c.
3719 ($(BLD)/xml.$(O)): New dependency list.
3721 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3722 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3723 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3724 [!WINDOWSNT]: New macros.
3725 (init_libxml2_functions, libxml2_loaded_p): New functions.
3726 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3727 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3728 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3729 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3731 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3732 Call init_libxml2_functions before calling libxml2 functions.
3733 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3735 * emacs.c: Don't include libxml/parser.h.
3736 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3737 xmlCleanupParser directly.
3739 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3741 2012-04-07 Eli Zaretskii <eliz@gnu.org>
3743 * indent.c (Fvertical_motion): If there is a display string at
3744 point, use it.vpos to compute how many lines to backtrack after
3745 move_it_to point. (Bug#11133)
3747 2012-04-06 Eli Zaretskii <eliz@gnu.org>
3749 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3750 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3751 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3752 macros related to unification of CJK characters. For the details,
3753 see the discussion following the message here:
3754 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3756 2012-04-04 Chong Yidong <cyd@gnu.org>
3758 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3760 2012-04-01 Eli Zaretskii <eliz@gnu.org>
3762 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3763 instead of alloca. (Bug#11138)
3765 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3767 * w32menu.c (is_simple_dialog): Properly check lisp types.
3770 2012-03-31 Eli Zaretskii <eliz@gnu.org>
3772 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3773 position we get to after a call to move_it_to fails the
3774 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3775 only if we wind up in a string from display property. (Bug#11063)
3777 * window.c (Fdelete_other_windows_internal): Invalidate the row
3778 and column information about mouse highlight, so that redisplay
3779 restores it after reallocating the glyph matrices. (Bug#7464)
3781 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3782 string comes from a `display' text property, use the buffer
3783 position of that property as if we actually saw that position in
3785 (move_it_by_lines): Remove the assertion that
3786 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3787 violated when there's a before-string at the beginning of a line.
3790 2012-03-30 Eli Zaretskii <eliz@gnu.org>
3792 * xdisp.c (append_space_for_newline): If the default face was
3793 remapped, use the remapped face for the appended newline.
3794 (extend_face_to_end_of_line): Use the remapped default face for
3795 extending the face to the end of the line.
3796 (display_line): Call extend_face_to_end_of_line when the default
3797 face was remapped. (Bug#11068)
3799 2012-03-29 Eli Zaretskii <eliz@gnu.org>
3801 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3803 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3805 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3807 2012-03-27 Glenn Morris <rgm@gnu.org>
3809 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3812 2012-03-26 Kenichi Handa <handa@m17n.org>
3814 * dispextern.h (struct glyph): Fix previous change. Change the
3815 bit length of glyphless.ch to 25 (Bug#11082).
3817 2012-03-26 Chong Yidong <cyd@gnu.org>
3819 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3820 (command_loop_1): Use it; inhibit selection update for
3821 handle-select-window too (Bug#8996).
3823 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3825 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
3827 2012-03-25 Kenichi Handa <handa@m17n.org>
3829 * dispextern.h (struct glyph): Change the bit length of
3830 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3832 2012-03-24 Eli Zaretskii <eliz@gnu.org>
3834 * s/ms-w32.h (tzname): Include time.h before redirecting to
3835 _tzname. Fixes the MSVC build. (Bug#9960)
3837 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3839 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3842 * xterm.c (XTread_socket): Only modify handling_signal if
3843 !SYNC_INPUT. (Bug#11080)
3845 2012-03-23 Eli Zaretskii <eliz@gnu.org>
3847 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3848 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3849 when fetching a multibyte character consumes more bytes than
3850 CHAR_BYTES returns, due to unification of CJK characters in
3851 string_char. (Bug#11073)
3853 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3855 * process.c (wait_reading_process_output): Handle pty disconnect
3856 by refraining from sending oneself a SIGCHLD (bug#10933).
3858 2012-03-22 Chong Yidong <cyd@gnu.org>
3860 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3862 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
3863 Mark string as coming from a prefix property.
3864 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3865 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3867 2012-03-21 Chong Yidong <cyd@gnu.org>
3869 * xfaces.c (Vface_remapping_alist): Doc fix.
3871 2012-03-20 Eli Zaretskii <eliz@gnu.org>
3873 * w32proc.c (Fw32_set_console_codepage)
3874 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3877 2012-03-20 Chong Yidong <cyd@gnu.org>
3879 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3880 to reflect default non-nil value of redisplay-dont-pause.
3882 2012-03-19 Kenichi Handa <handa@m17n.org>
3884 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3885 it fit in a valid range (Bug#11003).
3887 2012-03-18 Eli Zaretskii <eliz@gnu.org>
3889 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3890 that is not from display property, accept the row as a "cursor
3891 row" if one of the string's character has a non-nil `cursor'
3892 property. Fixes cursor positioning when there are newlines in
3893 overlay strings, e.g. in icomplete.el. (Bug#11035)
3895 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3897 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3899 2012-03-12 Chong Yidong <cyd@gnu.org>
3901 * eval.c (inhibit_lisp_code): Rename from
3902 inhibit_window_configuration_change_hook; move from window.c.
3904 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3905 * window.c (run_window_configuration_change_hook)
3906 (syms_of_window): Callers changed.
3908 2012-03-11 Chong Yidong <cyd@gnu.org>
3910 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3912 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3914 2012-03-10 Chong Yidong <cyd@gnu.org>
3916 * frame.c (other_visible_frames): Don't assume the selected frame
3917 is visible (Bug#10955).
3919 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3921 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3923 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3925 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3926 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3929 2012-03-03 Glenn Morris <rgm@gnu.org>
3931 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
3933 2012-03-02 Eli Zaretskii <eliz@gnu.org>
3935 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3936 position past the first glyph_row that ends at ZV. (Bug#10902)
3937 (redisplay_window, next_element_from_string): Fix typos in
3939 (redisplay_window): Pass to move_it_vertically the margin in
3940 pixels, not in screen lines.
3942 2012-03-02 Glenn Morris <rgm@gnu.org>
3944 * buffer.c (buffer-list-update-hook): Doc fix.
3946 2012-02-29 Eli Zaretskii <eliz@gnu.org>
3948 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3949 push_it before setting up the iterator for the first overlay
3950 string, even if we have an empty string loaded.
3951 (next_overlay_string): If there's an empty string on the iterator
3952 stack, pop the stack. (Bug#10903)
3954 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3956 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3957 Suggested by Stefan Monnier in
3958 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3959 * alloc.c (widen_to_Lisp_Object): New static function.
3960 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3961 and widening them to Lisp_Objects. This would work even if
3962 USE_LSB_TAG is defined and wide integers are used, which might
3963 happen in a future version of Emacs.
3965 2012-02-25 Chong Yidong <cyd@gnu.org>
3967 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3970 * xselect.c (Fx_selection_exists_p): Doc fix.
3971 (x_clipboard_manager_save_all): Print an informative message
3972 before saving to clipboard manager.
3974 2012-02-24 Chong Yidong <cyd@gnu.org>
3976 * keyboard.c (process_special_events): Handle all X selection
3977 requests in kbd_buffer, not just the next one (Bug#8869).
3979 2012-02-23 Chong Yidong <cyd@gnu.org>
3981 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3982 call when setting menu-bar-lines and tool-bar-lines parameters.
3983 (unwind_create_frame_1): New helper function.
3985 * window.c (inhibit_window_configuration_change_hook): New var.
3986 (run_window_configuration_change_hook): Obey it.
3987 (syms_of_window): Initialize it.
3989 2012-02-22 Chong Yidong <cyd@gnu.org>
3991 * xterm.c (x_draw_image_relief): Add missing type check for
3992 Vtool_bar_button_margin (Bug#10743).
3994 2012-02-21 Chong Yidong <cyd@gnu.org>
3996 * fileio.c (Vfile_name_handler_alist): Doc fix.
3998 * buffer.c (Fget_file_buffer): Protect against invalid file
3999 handler return value.
4001 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4003 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4004 when computing $valmask.
4006 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4007 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4008 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4009 It's useless in that case, and it can cause problems on hosts
4010 that allocate halves of EMACS_INT values separately.
4011 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4012 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4013 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4014 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4015 it avoids undefined behavior on hosts where shifting right by more
4016 than the word width has undefined behavior.
4018 2012-02-19 Chong Yidong <cyd@gnu.org>
4020 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4021 (Funhandled_file_name_directory, Ffile_name_as_directory)
4022 (Fdirectory_file_name, Fexpand_file_name)
4023 (Fsubstitute_in_file_name): Protect against invalid file handler
4024 return values (Bug#10845).
4026 2012-02-18 Eli Zaretskii <eliz@gnu.org>
4028 * .gdbinit (pitx): Fix incorrect references to fields of the
4031 2012-02-17 Chong Yidong <cyd@gnu.org>
4033 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4035 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4037 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4038 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4040 2012-02-15 Chong Yidong <cyd@gnu.org>
4042 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4043 marked as special. Also, starting docstrings with * is obsolete.
4045 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4047 * gnutls.c (emacs_gnutls_write): Fix last change.
4049 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4051 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4054 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4056 * keymap.c (Fsingle_key_description): Handle char ranges.
4058 2012-02-12 Chong Yidong <cyd@gnu.org>
4060 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4061 as that creates a dangerous corner case.
4063 * window.c (Fdelete_window_internal): Invalidate the mouse
4064 highlight (Bug#9904).
4066 2012-02-12 Glenn Morris <rgm@gnu.org>
4068 * xselect.c (Fx_own_selection_internal)
4069 (Fx_get_selection_internal, Fx_disown_selection_internal)
4070 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4071 * nsselect.m (Fx_own_selection_internal)
4072 (Fx_disown_selection_internal, Fx_selection_exists_p)
4073 (Fx_selection_owner_p, Fx_get_selection_internal):
4074 Sync docs and argument specs with the xselect.c versions.
4076 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4078 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4080 2012-02-11 Eli Zaretskii <eliz@gnu.org>
4082 * w32select.c (Fx_selection_exists_p): Sync doc string and
4083 argument list with xselect.c. (Bug#10783)
4085 * w16select.c (Fx_selection_exists_p): Sync doc string and
4086 argument list with xselect.c. (Bug#10783)
4088 2012-02-10 Glenn Morris <rgm@gnu.org>
4090 * fns.c (Fsecure_hash): Doc fix.
4092 2012-02-09 Kenichi Handa <handa@m17n.org>
4094 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4096 2012-02-07 Chong Yidong <cyd@gnu.org>
4098 * buffer.c (Fbuffer_local_variables)
4099 (buffer_lisp_local_variables): Handle unbound vars correctly;
4100 don't let Qunbound leak into Lisp.
4102 2012-02-07 Glenn Morris <rgm@gnu.org>
4104 * image.c (Fimagemagick_types): Doc fix.
4106 * image.c (imagemagick-render-type): Change it from a lisp object
4107 to an integer. Move the doc here from the lisp manual.
4108 Treat all values not equal to 0 the same.
4110 2012-02-06 Chong Yidong <cyd@gnu.org>
4112 * doc.c (store_function_docstring): Avoid applying docstring of
4113 alias to base function (Bug#2603).
4115 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4117 * .gdbinit (pp1, pv1): Remove redundant defines.
4120 2012-02-04 Chong Yidong <cyd@gnu.org>
4122 * nsterm.m: Declare a global (Bug#10694).
4124 2012-02-04 Eli Zaretskii <eliz@gnu.org>
4126 * w32.c (get_emacs_configuration_options):
4127 Include --enable-checking, if specified, in the return value.
4129 2012-02-04 Martin Rudalics <rudalics@gmx.at>
4131 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4132 after rounding frame sizes. (Bug#9723)
4134 2012-02-04 Eli Zaretskii <eliz@gnu.org>
4136 * keyboard.c (adjust_point_for_property): Don't position point
4137 before BEGV. (Bug#10696)
4139 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4141 Handle overflow when computing char display width (Bug#9496).
4142 * character.c (char_width): Return EMACS_INT, not int.
4143 (char_width, c_string_width): Check for overflow when
4144 computing the width; this is possible now that individual
4145 characters can have unbounded width. Problem introduced
4146 by merge from Emacs 23 on 2012-01-19.
4148 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
4150 * dbusbind.c (Fdbus_register_method): Mention the return value
4151 :ignore in the docstring.
4153 2012-02-02 Glenn Morris <rgm@gnu.org>
4155 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4157 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4158 Unconditionally set to t. (Bug#10673)
4159 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4160 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4161 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4163 2012-02-02 Kenichi Handa <handa@m17n.org>
4165 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4166 0, do not call append_composite_glyph.
4168 2012-02-02 Kenichi Handa <handa@m17n.org>
4170 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4172 (x_produce_glyphs): If the component of a composition is a null
4173 string, set it->pixel_width to 1 to avoid zero-width glyph.
4175 2012-02-01 Eli Zaretskii <eliz@gnu.org>
4177 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4178 first 2 arguments are identical. This makes inserting large
4179 output from a subprocess an order of magnitude faster on
4180 MS-Windows, where all sbrk'ed memory is always contiguous.
4182 2012-01-31 Glenn Morris <rgm@gnu.org>
4184 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4185 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4186 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4188 2012-01-29 Glenn Morris <rgm@gnu.org>
4190 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4192 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4194 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4196 2012-01-28 Chong Yidong <cyd@gnu.org>
4198 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4200 2012-01-26 Chong Yidong <cyd@gnu.org>
4202 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4204 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4205 repeat counts (Bug#10507).
4207 2012-01-26 Glenn Morris <rgm@gnu.org>
4209 * lread.c (syms_of_lread): Doc fix.
4211 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4213 * coding.c (encode_designation_at_bol): Change return value to
4216 2012-01-25 Chong Yidong <cyd@gnu.org>
4218 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4220 2012-01-21 Chong Yidong <cyd@gnu.org>
4222 * floatfns.c (Fcopysign): Make the second argument non-optional,
4223 since nil is not allowed anyway.
4225 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4227 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4228 (send_process): Likewise.
4230 2012-01-19 Martin Rudalics <rudalics@gmx.at>
4232 * window.c (save_window_save, Fcurrent_window_configuration)
4233 (Vwindow_persistent_parameters): Do not use Qstate.
4234 Rewrite doc-strings.
4236 2012-01-19 Kenichi Handa <handa@m17n.org>
4238 * character.c (char_width): New function.
4239 (Fchar_width, c_string_width, lisp_string_width):
4240 Use char_width (Bug#9496).
4242 2012-01-16 Martin Rudalics <rudalics@gmx.at>
4244 * window.c (Vwindow_persistent_parameters): New variable.
4245 (Fset_window_configuration, save_window_save): Handle persistent
4248 2012-01-14 Eli Zaretskii <eliz@gnu.org>
4250 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4251 thrashing the stack of the thread. (Bug#9087)
4253 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4255 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4257 2012-01-11 Eli Zaretskii <eliz@gnu.org>
4259 * xdisp.c (rows_from_pos_range): Handle the case where the
4260 highlight ends on a newline. (Bug#10464)
4261 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4262 he end column for display of highlight that ends on a newline
4265 2012-01-11 Glenn Morris <rgm@gnu.org>
4267 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4268 from load-path also when installation-directory is nil. (Bug#10208)
4270 2012-01-10 Glenn Morris <rgm@gnu.org>
4272 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4274 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4275 Update template values to be closer to their typical values these days.
4277 2012-01-09 Eli Zaretskii <eliz@gnu.org>
4279 * xdisp.c (rows_from_pos_range): Accept additional argument
4280 DISP_STRING, and accept any glyph in a row whose object is that
4281 string as eligible for mouse highlight. Fixes mouse highlight of
4282 display strings from overlays. (Bug#10464)
4284 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
4286 emacs: fix an auto-save permissions race condition (Bug#10400)
4287 * fileio.c (auto_saving_dir_umask): New static var.
4288 (Fmake_directory_internal): Use it.
4289 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4290 creating the directory. The old code temporarily assigns
4291 too-generous permissions to the directory.
4292 (do_auto_save_eh): Clear it.
4293 (Fdo_auto_save): Catch all errors, not just file errors, so
4294 that the var is always cleared.
4296 2012-01-07 Eli Zaretskii <eliz@gnu.org>
4298 * search.c (scan_buffer): Pass character positions to
4299 know_region_cache, not byte positions. (Bug#6540)
4301 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
4303 * w32.c (sys_rename): Report EXDEV when rename of a directory
4304 fails because the target is on another logical disk. (Bug#10284)
4306 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4308 * xterm.c (x_embed_request_focus): New function.
4310 * xterm.h: Add prototype.
4312 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4314 2012-01-05 Glenn Morris <rgm@gnu.org>
4316 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4318 2012-01-01 Eli Zaretskii <eliz@gnu.org>
4320 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4321 Load gnutls_transport_set_lowat only if GnuTLS version is below
4323 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4324 GnuTLS versions below 2.11.1.
4326 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4328 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4329 to the doc string advising against its use for altering the way
4330 windows are scrolled.
4332 2011-12-28 Kenichi Handa <handa@m17n.org>
4334 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4335 coding-system ASCII compatible only when it does not produce BOM
4336 on encoding (Bug#10383).
4338 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4340 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4342 (create_and_show_popup_menu): Always use menu_position_func for
4345 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4347 * callint.c (Fcall_interactively): Don't truncate prompt string.
4349 2011-12-23 Eli Zaretskii <eliz@gnu.org>
4351 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4352 property that ends at ZV, so that the bidi iteration could be
4353 resumed from there (after widening). (Bug#10360)
4355 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4357 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4359 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4361 * nsterm.m (x_free_frame_resources):
4362 Release f->output_data.ns->miniimage.
4363 (ns_index_color): Fix indentation. Do not retain
4364 color_table->colors[i].
4366 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4369 * nsfns.m (x_set_background_color): Assign return value from
4370 ns_index_color to face-background instead of NSColor*.
4371 (ns_implicitly_set_icon_type): Fix indentation.
4372 Change assignment in for loop to comparison.
4374 * emacs.c (ns_pool): New variable.
4375 (main): Assign ns_pool.
4376 (Fkill_emacs): Call ns_release_autorelease_pool.
4378 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4379 autorelease fdesc, release fdAttrs and tdict.
4380 (ns_get_covering_families): Release charset.
4381 (ns_findfonts): Release NSFontDescriptor created with new.
4382 (ns_uni_to_glyphs): Fix indentation.
4383 (setString): Release attrStr before assigning new value.
4385 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4387 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4389 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4390 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4392 2011-12-18 David Reitter <reitter@cmu.edu>
4394 * nsterm.m (ns_term_init): Subscribe for notifications
4395 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4396 to method trackingNotification in EmacsMenu.
4398 * nsmenu.m (trackingMenu): New variable.
4399 (trackingNotification): New method (from Aquamacs).
4400 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
4401 from Aquamacs (Bug#7030).
4403 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4405 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4406 (symbol_to_nsstring): Fix indentation.
4407 (ns_symbol_to_pb): New function.
4408 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4409 (Fns_rotate_cut_buffers_internal): Remove.
4410 (Fns_store_selection_internal): Rename from
4411 Fns_store_cut_buffer_internal.
4412 (ns_get_foreign_selection, Fx_own_selection_internal)
4413 (Fx_disown_selection_internal, Fx_selection_exists_p)
4414 (Fns_get_selection_internal, Fns_store_selection_internal):
4415 Use ns_symbol_to_pb and check if return value is nil.
4416 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4417 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
4418 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4419 renamed to Sns_store_selection_internal.
4420 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4421 and remove this function.
4422 (ns_handle_selection_clear): Remove, never used.
4423 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4426 2011-12-17 Ken Brown <kbrown@cornell.edu>
4428 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4429 GID is unknown (Bug#10257).
4431 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4433 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4434 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4435 which caused a build failure on GNU/Linux IA-64. This problem was
4436 introduced by my 2011-10-07 patch.
4438 2011-12-15 Juri Linkov <juri@jurta.org>
4440 * image.c (imagemagick_error): New function. (Bug#10112)
4441 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4442 Use `imagemagick_error' where ImageMagick functions return
4444 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4447 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4449 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4450 fill background (Bug#8992).
4452 2011-12-13 Martin Rudalics <rudalics@gmx.at>
4454 * window.c (Vwindow_combination_resize)
4455 (Vwindow_combination_limit): Use t instead of non-nil in
4457 (Vrecenter_redisplay): Add first sentence of doc-string on
4459 (Frecenter): Fix doc-string typo.
4461 2011-12-11 Kenichi Handa <handa@m17n.org>
4463 * coding.c (Funencodable_char_position): Pay attention to the
4464 buffer text relocation (Bug#9389).
4466 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4468 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4469 gtk_init (Bug#10100).
4471 2011-12-10 Eli Zaretskii <eliz@gnu.org>
4473 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4474 IT->string is nil. (Bug#10263)
4476 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4478 * nsterm.h (x_free_frame_resources): Declare.
4480 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4481 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4483 * nsterm.h (ns_get_defaults_value): Declare.
4485 * nsterm.m (ns_default): Call ns_get_defaults_value.
4487 2011-12-09 Eli Zaretskii <eliz@gnu.org>
4489 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4492 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4494 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4495 that where the value of an _OBJC_* symbol points to is in the .bss
4496 section (Bug#10240).
4498 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4500 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
4501 after the loop to call ccl_driver at least once (Bug#8619).
4503 2011-12-08 Kenichi Handa <handa@m17n.org>
4505 * ftfont.c (get_adstyle_property): Fix previous change
4508 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
4510 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4511 dirs from the default value of EMACSLOADPATH (bug#10208).
4513 2011-12-07 Glenn Morris <rgm@gnu.org>
4515 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4516 installation and source directories as well. (Bug#10208)
4518 2011-12-06 Chong Yidong <cyd@gnu.org>
4520 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4522 2011-12-06 Glenn Morris <rgm@gnu.org>
4524 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4525 as an error, not just -1. (Bug#10217)
4527 2011-12-05 Chong Yidong <cyd@gnu.org>
4529 * keyboard.c (process_special_events): New function.
4530 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4532 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4534 * coding.c (encode_designation_at_bol): Don't use uninitialized
4535 local variable (Bug#9318).
4537 2011-12-05 Kenichi Handa <handa@m17n.org>
4539 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4540 return Qnil (Bug#8046, Bug#10193).
4542 2011-12-05 Kenichi Handa <handa@m17n.org>
4544 * coding.c (encode_designation_at_bol): New args charbuf_end and
4545 dst. Return the number of produced bytes. Callers changed.
4546 (coding_set_source): Return how many bytes coding->source was
4548 (coding_set_destination): Return how many bytes
4549 coding->destination was relocated.
4550 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
4551 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
4553 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4555 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4556 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4559 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4561 The following changes are to fix Bug#9318.
4563 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
4564 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4565 (encode_coding_iso_2022, encode_coding_sjis)
4566 (encode_coding_big5, encode_coding_charset): Use the above macros.
4568 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
4570 * lisp.h (process_quit_flag): Fix external declaration.
4572 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4574 Don't macro-inline non-performance-critical code.
4575 * eval.c (process_quit_flag): New function.
4576 * lisp.h (QUIT): Use it.
4578 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4580 * nsfns.m (get_geometry_from_preferences): New function.
4581 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4583 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4585 * emacs.c (Qkill_emacs): Define.
4586 (syms_of_emacs): Initialize it.
4587 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4588 Qquit_flag to `kill-emacs' instead.
4589 (quit_throw_to_read_char): Add parameter `from_signal'.
4590 All callers changed. Call Fkill_emacs if requested and safe.
4591 * lisp.h (QUIT): Call Fkill_emacs if requested.
4593 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4595 * widget.c (update_wm_hints): Return if wmshell is null.
4596 (widget_update_wm_size_hints): New function.
4598 * widget.h (widget_update_wm_size_hints): Declare.
4600 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4601 widget_update_wm_size_hints (Bug#10104).
4603 2011-12-03 Eli Zaretskii <eliz@gnu.org>
4605 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4606 before a newline, prepare the bidi iterator for consuming the
4607 newline, and keep the current paragraph direction. (Bug#10183)
4608 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
4610 2011-12-02 Juri Linkov <juri@jurta.org>
4612 * search.c (Fword_search_regexp): New Lisp function created from
4613 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4614 (Fword_search_backward, Fword_search_forward)
4615 (Fword_search_backward_lax, Fword_search_forward_lax):
4616 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4617 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4619 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4621 * fileio.c (Finsert_file_contents): Move after-change-function call
4622 to before the "handled:" label, since all "goto handled" appear in
4623 cases where the *-change-functions have already been properly called
4626 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4628 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4629 waiting for input. (Bug#10169)
4631 2011-11-30 Eli Zaretskii <eliz@gnu.org>
4633 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4634 verifies glyph row's hash code--we have just reallocated the
4635 glyphs, so their contents can be complete garbage. (Bug#10164)
4637 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
4639 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4641 2011-11-30 Eli Zaretskii <eliz@gnu.org>
4643 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4644 attributes are tested _before_ calling verify_row_hash, to protect
4645 against GCC re-ordering of the tests. (Bug#10164)
4647 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4649 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4651 * xterm.c (handle_one_xevent): Only set async_visible and friends
4652 if net_wm_state_hidden_seen is non-zero (Bug#10002)
4653 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
4654 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4656 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4658 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4659 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4660 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4661 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4662 All uses changed to use GCPRO1 etc.
4663 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4664 Revert to old implementation (i.e., before 2011-03-11).
4666 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4668 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4669 of scroll runs so as to avoid assigning disabled bogus rows and
4670 unnecessary graphics copy operations.
4672 2011-11-27 Eli Zaretskii <eliz@gnu.org>
4674 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4675 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4676 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4677 (malloc, free, realloc, calloc): Redirect to e_* only when
4680 * lisp.h (GCTYPEBITS): Move before first use.
4681 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4682 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4683 this macro definition.
4685 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4688 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4690 * gtkutil.c (xg_create_frame_widgets):
4691 Call gtk_window_set_has_resize_grip (FALSE) if that function is
4692 present with Gtk+ 2.0.
4694 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4696 * fileio.c (Finsert_file_contents): Undo previous change; see
4697 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4699 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4701 Rename locals to avoid shadowing.
4702 * fileio.c (Finsert_file_contents):
4703 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4704 * process.c (wait_reading_process_output):
4705 Rename inner 'proc' to 'p' to avoid shadowing.
4706 Indent for consistency with usual Emacs style.
4708 2011-11-25 Eli Zaretskii <eliz@gnu.org>
4710 * xdisp.c (redisplay_window): If cursor row is not fully visible
4711 after recentering, and scroll-conservatively is set to a large
4712 number, scroll window by a few more lines to make the cursor fully
4713 visible and out of scroll-margin. (Bug#10105)
4714 (start_display): Don't move to the next line if the display should
4715 start at a newline that is part of a display vector or an overlay
4718 2011-11-24 Juri Linkov <juri@jurta.org>
4720 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4721 after the `MagickPingImage' call. (Bug#10112)
4723 2011-11-23 Chong Yidong <cyd@gnu.org>
4725 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4727 2011-11-23 Martin Rudalics <rudalics@gmx.at>
4729 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4730 making another buffer current. (Bug#10114)
4732 2011-11-23 Glenn Morris <rgm@gnu.org>
4734 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4736 2011-11-23 Chong Yidong <cyd@gnu.org>
4738 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4739 using it (Bug#5984).
4741 2011-11-22 Eli Zaretskii <eliz@gnu.org>
4743 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4744 and header-lines, as they don't have one computed for them.
4747 * .gdbinit (prow): Make displayed values more self-explaining.
4748 Add row's hash code.
4750 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4752 * process.c (wait_reading_process_output): Fix asynchrounous
4753 GnuTLS socket handling on some versions of the GnuTLS library.
4754 (wait_reading_process_output): Add comment and URL.
4756 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4758 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4760 2011-11-21 Chong Yidong <cyd@gnu.org>
4762 * window.c (Fnext_window, Fprevious_window): Doc fix.
4764 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4766 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4768 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
4770 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4772 2011-11-20 Martin Rudalics <rudalics@gmx.at>
4774 * window.c (Fset_window_combination_limit): Rename argument
4776 (Vwindow_combination_limit): Remove "status" from doc-string.
4778 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4780 * m/ibms390.h: Remove.
4781 * m/ibms390x.h: Don't include "ibms390.h".
4783 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4785 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4786 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4788 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
4790 * casetab.c (Fset_case_table):
4791 * charset.c (Fcharset_after): Fix typos.
4793 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
4795 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4796 Otherwise, valgrind does not work on some platforms.
4797 Problem reported by Andreas Schwab in
4798 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4799 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4800 is set, removing the need for VIRT_ADDRESS_VARIES.
4801 (PURE_P): Use a more-efficient implementation that needs just one
4802 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4803 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4804 to 4 (xorl, subq, cmpq, setbe).
4805 * alloc.c (pure): Always extern now, since that's the
4806 VIRT_ADDR_VARIES behavior.
4807 (PURE_POINTER_P): Use a single comparison, not two, for
4808 consistency with the new puresize.h.
4809 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4810 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4811 Remove VIRT_ADDR_VARIES no longer needed.
4813 2011-11-19 Eli Zaretskii <eliz@gnu.org>
4815 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4816 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4817 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4818 behave as if the cursor position were at the window margin.
4820 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4821 and the cursor position is out of bounds, behave as if the cursor
4822 position were at the window margin. (Bug#10075)
4824 2011-11-18 Chong Yidong <cyd@gnu.org>
4826 * window.c (Fwindow_combination_limit): Make first argument
4827 non-optional, since it is meaningless for live windows like the
4830 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4832 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4834 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4836 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4837 (graft_intervals_into_buffer): Simplify.
4839 2011-11-18 Eli Zaretskii <eliz@gnu.org>
4841 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4842 hash values of the two rows.
4843 (copy_row_except_pointers): Preserve the used[] arrays and the
4844 hash values of the two rows. (Bug#10035)
4845 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
4847 * xdisp.c (row_hash): New function, body extracted from
4848 compute_line_metrics.
4849 (compute_line_metrics): Call row_hash, instead of computing the
4852 * dispnew.c (verify_row_hash): Call row_hash for computing the
4853 hash code of a row, instead of duplicating code from xdisp.c.
4855 * dispextern.h (row_hash): Add prototype.
4857 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4859 * frame.c (delete_frame): Don't delete the terminal when the last
4860 X frame is closed if emacs is built with GTK toolkit.
4862 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
4864 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4866 2011-11-17 Martin Rudalics <rudalics@gmx.at>
4868 * window.c (Vwindow_splits): Rename to
4869 Vwindow_combination_resize. Suggested by Juri Linkov.
4870 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4873 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
4875 * nsfns.m (Fns_font_name):
4876 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
4878 2011-11-16 Martin Rudalics <rudalics@gmx.at>
4880 * window.h (window): Rename slot "nest" to "combination_limit".
4881 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4882 (Fset_window_nest): Rename to Fset_window_combination_limit.
4883 (Vwindow_nest): Rename to Vwindow_combination_limit.
4884 (recombine_windows, make_parent_window, make_window)
4885 (Fsplit_window_internal, saved_window)
4886 (Fset_window_configuration, save_window_save): Rename all
4887 occurrences of window_nest to window_combination_limit.
4889 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
4891 * image.c (imagemagick_load_image): Fix typo.
4893 2011-11-14 Eli Zaretskii <eliz@gnu.org>
4895 * xdisp.c (display_line): Move the call to
4896 highlight_trailing_whitespace before the call to
4897 compute_line_metrics, since the latter needs to see the final
4898 faces of all the glyphs to compute ROW's hash value.
4899 Fixes assertion violations in row_equal_p. (Bug#10035)
4901 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
4903 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4904 just return (bug#10044).
4906 2011-11-12 Eli Zaretskii <eliz@gnu.org>
4908 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4909 with user-defined heap size. Bump the default size of the temacs
4910 heap to 27MB, to avoid memory warning when running temacs.
4911 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4913 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4914 current_matrix and desired_matrix. (Bug#9990)
4915 (verify_row_hash) [XASSERTS]: New function.
4916 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4917 that the hash value of glyph rows is correct.
4919 2011-11-12 Martin Rudalics <rudalics@gmx.at>
4921 * window.h (window): Remove splits slot.
4922 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4923 (Fdelete_other_windows_internal, make_parent_window)
4924 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4925 (Fset_window_configuration, save_window_save): Don't deal with
4926 split status of windows.
4927 (saved_window): Remove splits slot.
4928 (Vwindow_splits): Rewrite doc-string.
4930 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4932 * xfns.c (unwind_create_frame):
4933 * nsfns.m (unwind_create_frame):
4934 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4935 Vframe_list (Bug#9999).
4937 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4939 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
4941 2011-11-11 Kenichi Handa <handa@m17n.org>
4943 * callproc.c (Fcall_process): Set the member dst_multibyte of
4946 2011-11-11 Johan Bockgård <bojohan@gnu.org>
4948 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4949 avoid a crash (bug#9496).
4951 2011-11-09 Chong Yidong <cyd@gnu.org>
4953 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4954 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4956 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4958 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4960 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4962 Avoid some portability problems by eschewing 'extern inline' functions.
4963 The trivial performance wins aren't worth the portability hassles; see
4964 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4966 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4967 (window_box_width, window_box_left, window_box_left_offset)
4968 (window_box_right, window_box_right_offset): Undo previous change,
4969 by removing the "extern"s.
4970 * intervals.c (adjust_intervals_for_insertion)
4971 (adjust_intervals_for_deletion): Undo previous change,
4972 making these static again.
4973 (offset_intervals, temp_set_point_both, temp_set_point)
4974 (copy_intervals_to_string): No longer inline.
4975 * xdisp.c (window_text_bottom_y, window_box_width)
4976 (window_box_height, window_box_left_offset)
4977 (window_box_right_offset, window_box_left, window_box_right)
4978 (window_box): No longer inline.
4980 2011-11-08 Chong Yidong <cyd@gnu.org>
4982 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
4983 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4984 Signal an error if not a live window.
4985 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4986 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4988 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
4990 * lisp.h (syms_of_abbrev): Remove declaration.
4991 Reported by CHENG Gao <chenggao@royau.me>.
4993 2011-11-07 Eli Zaretskii <eliz@gnu.org>
4995 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4996 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4997 of temacs in GUI mode.
4999 2011-11-07 Martin Rudalics <rudalics@gmx.at>
5001 * window.h: Declare delete_all_child_windows instead of
5002 delete_all_subwindows.
5003 * window.c (Fwindow_nest, Fset_window_nest)
5004 (Fset_window_new_total, Fset_window_new_normal)
5005 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5006 (delete_all_subwindows): Rename to delete_all_child_windows.
5007 (Fdelete_other_windows_internal, Fset_window_configuration):
5008 Call delete_all_child_windows instead of delete_all_subwindows.
5009 * frame.c (delete_frame): Call delete_all_child_windows instead
5010 of delete_all_subwindows.
5012 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5014 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5015 This is also needed for porting to any host where GC_MARK_STACK is
5016 not GC_MAKE_GCPROS_NOOPS.
5017 (which_symbols): Use it.
5019 2011-11-07 Kenichi Handa <handa@m17n.org>
5021 * coding.c (coding_set_destination): Check coding->src_pos only
5022 when coding->src_object is a buffer (bug#9910).
5024 * process.c (send_process): Set the member src_multibyte of coding
5025 to 0 (bug#9911) when sending a unibyte text.
5027 * callproc.c (Fcall_process): Set the member src_multibyte of
5028 process_coding to 0 (bug#9912).
5030 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5032 * xmenu.c (cleanup_widget_value_tree): New function.
5033 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5034 calling free_menubar_widget_value_tree directly (Bug#9830).
5036 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5038 Fix some portability problems with 'inline'.
5039 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5040 (window_box_width, window_box_left, window_box_left_offset)
5041 (window_box_right, window_box_right_offset): Declare extern.
5042 Otherwise, these inline functions do not conform to C99 and
5043 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5044 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5045 * intervals.c (adjust_intervals_for_insertion)
5046 (adjust_intervals_for_deletion): Now extern, because otherwise the
5047 extern inline functions 'offset_intervals' couldn't refer to it.
5048 (static_offset_intervals): Remove.
5049 (offset_intervals): Rewrite using the old contents of
5050 static_offset_intervals. The old version didn't conform to C99
5051 because an extern inline function contained a reference to an
5052 identifier with static linkage.
5054 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5056 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5059 2011-11-06 Eli Zaretskii <eliz@gnu.org>
5061 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5062 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5063 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5064 return Qleft_to_right.
5066 2011-11-06 Chong Yidong <cyd@gnu.org>
5068 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5069 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5070 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5071 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5072 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5073 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5074 (Fwindow_vscroll): Doc fix.
5075 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5076 argument, since it makes no sense to pass a live window and for
5077 consistency with window-child.
5079 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5081 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5084 2011-11-05 Jason Rumney <jasonr@gnu.org>
5086 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5087 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5089 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5090 bitwise arithmetic preventing use of unicode-sip and non-truetype
5093 2011-11-05 Eli Zaretskii <eliz@gnu.org>
5095 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5098 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5099 initialization code to keep similarity to xfns.c after changes
5102 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5104 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5105 (unwind_create_frame): New function (Bug#9943).
5106 (Fx_create_frame): Restructure code to be more similar to the one in
5107 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5108 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5109 Move terminal->reference_count++ just before making the frame official
5112 * nsterm.m (x_free_frame_resources): New function.
5113 (x_destroy_window): Move code to x_free_frame_resources.
5115 * xfns.c (unwind_create_frame): Fix comment.
5116 (Fx_create_frame, x_create_tip_frame):
5117 Move terminal->reference_count++ just before making the frame
5118 official. Move initialization of image_cache_refcount and
5119 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5121 2011-11-05 Eli Zaretskii <eliz@gnu.org>
5123 Support MSVC build with newer versions of Visual Studio.
5124 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5125 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5128 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5129 which are not supported by MSVC.
5130 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5131 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5133 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5135 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5137 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5139 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
5141 Support MSVC build with newer versions of Visual Studio.
5142 * w32.c: Don't include w32api.h for MSVC.
5143 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5145 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5146 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5147 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5148 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5150 (alloca) [_MSC_VER]: Define to _alloca.
5152 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5154 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5156 2011-11-04 Eli Zaretskii <eliz@gnu.org>
5158 * xdisp.c (note_mouse_highlight): If either of
5159 previous/next-single-property-change returns nil, treat that as
5160 the beginning or the end of the buffer. (Bug#9955)
5162 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5164 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
5165 label is not null (Bug#9951).
5166 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5169 2011-11-04 Eli Zaretskii <eliz@gnu.org>
5171 * window.c (Fwindow_body_size): Mention in the doc string that the
5172 return value is in frame's canonical units. (Bug#9949)
5174 2011-11-03 Eli Zaretskii <eliz@gnu.org>
5176 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5178 * w32fns.c (unwind_create_frame): If needed, free the glyph
5179 matrices of the partially constructed frame. (Bug#9943)
5180 * xfns.c (unwind_create_frame): Likewise.
5182 2011-11-01 Eli Zaretskii <eliz@gnu.org>
5184 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5185 Don't stop backward scan on the continuation glyph, even though
5186 its CHARPOS is positive.
5187 (mouse_face_from_buffer_pos, note_mouse_highlight):
5188 Rename cover_string to disp_string.
5190 2011-11-01 Martin Rudalics <rudalics@gmx.at>
5192 * window.c (temp_output_buffer_show): Don't use
5193 Vtemp_buffer_show_specifiers.
5194 (Vtemp_buffer_show_specifiers): Remove unused variable.
5196 2011-10-30 Eli Zaretskii <eliz@gnu.org>
5198 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5199 past the beginning of the current glyph matrix.
5201 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
5203 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5204 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5205 HAVE_GTK3 (Bug#9869).
5207 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5208 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5210 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5212 * xterm.c: Declare x_handle_net_wm_state to return int.
5213 (handle_one_xevent): Check if we are iconified but don't have
5214 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5215 (get_current_wm_state): Return non-zero if not hidden,
5216 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5217 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5218 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5219 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5221 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5223 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5224 so that this new function doesn't get optimized away by a
5225 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5227 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5229 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5231 2011-10-29 Eli Zaretskii <eliz@gnu.org>
5233 Fix the `xbytecode' command.
5234 * .gdbinit (xprintbytestr): New command.
5235 (xwhichsymbols): Rename from `which'; all callers changed.
5236 (xbytecode): Print the byte-code string as well.
5238 2011-10-29 Kim Storm <storm@cua.dk>
5240 * alloc.c (which_symbols): New function.
5242 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5244 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5247 2011-10-29 Glenn Morris <rgm@gnu.org>
5249 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5250 Not clear what it was for, and it causes various bugs. (Bug#9839)
5252 2011-10-28 Eli Zaretskii <eliz@gnu.org>
5254 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5255 possible random value that matches one of those tested as
5256 condition to clear the mouse face.
5258 2011-10-28 Chong Yidong <cyd@gnu.org>
5260 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5262 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5264 * window.c (make_window): Initialize phys_cursor_on_p.
5266 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5268 * lisp.h (struct Lisp_Symbol): Update comments.
5270 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
5272 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5274 2011-10-28 Eli Zaretskii <eliz@gnu.org>
5276 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5277 <oslsachem@gmail.com> for helping to debug this.
5279 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5280 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5281 (g_b_init_get_glyph_outline_w): New static variables.
5282 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5283 (GetGlyphOutlineW_Proc): New typedefs.
5284 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
5285 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5287 (w32font_open_internal, compute_metrics):
5288 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
5289 instead of calling the "wide" APIs directly.
5291 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5293 * w32.h (syms_of_w32font): Add prototype.
5295 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
5297 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5298 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5299 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5300 (Fmove_to_window_line): Doc fix.
5302 2011-10-27 Chong Yidong <cyd@gnu.org>
5304 * process.c (make_process): Set gnutls_state to NULL.
5306 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5307 non-NULL, regardless of GNUTLS_INITSTAGE.
5308 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5309 an error. Set process slots as soon as we allocate them.
5311 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5313 2011-10-27 Chong Yidong <cyd@gnu.org>
5315 * gnutls.c (emacs_gnutls_deinit): New function.
5316 Deallocate credentials structures as well as calling gnutls_deinit.
5317 (Fgnutls_deinit, Fgnutls_boot): Use it.
5319 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5320 (deactivate_process): Call emacs_gnutls_deinit.
5322 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
5324 * image.c (x_create_x_image_and_pixmap):
5325 * w32.c (sys_rename, w32_delayed_load):
5326 * w32font.c (fill_in_logfont):
5327 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5329 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
5331 * w32fns.c (w32_default_color_map): New function,
5332 extracted from Fw32_default_color_map.
5333 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5335 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5337 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5339 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5341 * keyboard.c (test_undefined): New function (bug#9751).
5342 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5344 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5346 * sysdep.c (init_sys_modes): Fix the check for the controlling
5347 terminal (Bug#6649).
5349 2011-10-20 Eli Zaretskii <eliz@gnu.org>
5351 * dispextern.h (struct bidi_it): New member next_en_type.
5353 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5354 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5355 current character, check also for next_en_type being WEAK_EN.
5356 (bidi_resolve_weak): Don't enter the expensive loop if the current
5357 position is before next_en_pos. Record the bidi type of the first
5358 non-ET, non-BN character we find, in addition to its position.
5359 (bidi_level_of_next_char): Invalidate next_en_type when
5360 next_en_pos is over-stepped.
5362 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5364 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5365 * editfns.c: Rewrite current-time-zone so that it invokes
5366 the equivalent of (format-time-string "%Z") to get the time zone name.
5367 This fixes a bug when the time zone name contains characters that
5368 need converting from the system time locale to Emacs internal format.
5369 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5370 that patch fixed format-time-string to do the conversion, but
5371 I forgot to fix current-time-zone.
5372 (format_time_string): New function, containing most of
5373 what Fformat_time_string used to contain.
5374 (Fformat_time_string): Rewrite in terms of format_time_string.
5375 This doesn't change this function's behavior.
5376 (current-time-zone): Rewrite to use format_time_string.
5377 This fixes the bug reported by Michael Schierl in
5378 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5379 Jason Rumney's 2007-06-07 change worked around this bug, but
5381 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5383 2011-10-19 Eli Zaretskii <eliz@gnu.org>
5385 * xdisp.c (start_display): If the character at POS is displayed
5386 via a display vector, reset IT->current.dpvec_index to zero.
5387 (try_window_reusing_current_matrix): If a line ends in a display
5388 vector or the next line starts in a display vector, continue
5389 redrawing the window even though the character position of
5390 start_row was reached.
5393 2011-10-18 Chong Yidong <cyd@gnu.org>
5395 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5396 with nobreak-char-display too.
5398 2011-10-18 Eli Zaretskii <eliz@gnu.org>
5400 Fix part 3 of bug#9771.
5401 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5402 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5403 non-neutral characters if the current character is a paragraph
5404 separator (a.k.a. Newline). This avoids running the same
5405 expensive loop twice, once when we consume the preceding newline
5406 and the other time when the line actually needs to be displayed.
5407 Avoid the loop when we see neutrals on the base embedding level
5408 following a character whose directionality is the same as the
5409 paragraph's. This avoids running the expensive loop when a line
5410 ends in a long sequence of neutrals, like control characters.
5411 Add assertion against STRONG_AL type. Slightly rearrange code
5412 that determines the type of a neutral given the first non-neutral
5414 (bidi_level_of_next_char): Set next_en_pos to zero when
5415 invalidating its info.
5417 2011-10-17 Eli Zaretskii <eliz@gnu.org>
5419 * xdisp.c (push_display_prop): Determine whether to record string
5420 or buffer position by IT->string, not by IT->method. Allow
5421 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
5422 (move_it_vertically_backward): Don't look for character position
5423 immediately after the newline when in a continuation line.
5426 2011-10-15 Martin Rudalics <rudalics@gmx.at>
5428 * window.c (coordinates_in_window): Rewrite and delabelize
5429 vertical border check. (Bug#5357) (Bug#9618)
5431 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5433 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5434 errors in XSetWindowBorder (bug#9310).
5436 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5438 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5439 avoid crash when xmalloc overrun checking is enabled.
5441 2011-10-13 Eli Zaretskii <eliz@gnu.org>
5443 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5444 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5445 cursor motion with <left> and <right> arrow keys.
5447 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5448 some callers set that themselves.
5450 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5452 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5453 display string and the previous row comes from the same string and
5454 is empty. (Bug#9739) (Bug#9738)
5456 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5458 * doc.c (get_doc_string): Encode file name (bug#9735).
5460 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5462 * bidi.c (bidi_level_of_next_char):
5463 * xdisp.c (get_visually_first_element): Remove old incorrect
5464 comments regarding the Unicode Line Separator character.
5466 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5468 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5470 * alloc.c (Fgc_status): Do not access beyond zombies array
5471 boundary if nzombies > MAX_ZOMBIES.
5472 * alloc.c (dump_zombies): Add missing format specifier.
5474 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5476 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5477 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5479 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5480 Some packages use them to denote characters with modifiers.
5482 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5484 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5485 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5486 matching a pp-number. Rename parameter var to var1.
5488 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5490 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5492 2011-10-08 Glenn Morris <rgm@gnu.org>
5494 * callint.c (Fcall_interactively): Give a more explicit error for the
5495 'c' case with a non-character input. (Bug#8479)
5497 2011-10-08 Eli Zaretskii <eliz@gnu.org>
5499 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5501 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5502 lines that are hscrolled on the left.
5504 * dispnew.c (buffer_posn_from_coords): Account for a possible
5505 presence of header-line. (Bug#4426)
5507 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5509 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5510 Don't advertise functionality which we discourage or doesn't work.
5512 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5514 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5515 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5516 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5517 this makes Emacs dump core during garbage collection on rare
5518 occasions. sizeof is obviously inferior to offsetof here, so
5519 stick with offsetof.
5520 (GC_POINTER_ALIGNMENT): New macro.
5521 (mark_memory): Omit 3rd (offset) arg; caller changed.
5522 Don't assume EMACS_INT alignment is the same as pointer alignment.
5524 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5526 * keyboard.c (read_key_sequence_remapped): New var.
5527 (read_key_sequence): Compute remapping in the right buffer.
5528 (command_loop_1): Use read_key_sequence's remapping directly.
5530 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5532 * dired.c (file_name_completion): Don't expand file name.
5533 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5534 before checking file name handler.
5536 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5537 they've been requested explicitly (bug#9591).
5539 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
5541 * keymap.c (Fsingle_key_description): Use make_specified_string
5542 instead of build_string to build string from push_key_description.
5545 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5547 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5548 This fixes a Y2038 bug on 64-bit hosts.
5549 * buffer.c (reset_buffer):
5550 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5551 (Fclear_buffer_auto_save_failure):
5552 Use 0, not -1, to represent an unset failure time, since time_t
5553 might not be signed.
5555 Remove dependency on glibc malloc internals.
5556 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5557 Move back here from lisp.h, but with their new implementations.
5558 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5559 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5560 * charset.c (charset_table_init): New static var.
5561 (syms_of_charset): Use it instead of xmalloc. This removes a
5562 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5563 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5564 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5565 Move back to alloc.c.
5566 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5567 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5569 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5571 * nsterm.m (windowDidResize): Call x_set_window_size only when
5572 ns_in_resize is true. Otherwise set pixelwidth/height and
5573 call change_frame_size (Bug#9628).
5575 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5577 Port --enable-checking=all to Fedora 14 x86-64.
5578 * charset.c (syms_of_charset): Also account for glibc malloc's
5579 internal overhead when calculating the initial malloc maximum.
5581 Port --enable-checking=all to Fedora 14 x86.
5582 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5584 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5585 (overrun_check_realloc, overrun_check_free):
5586 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5587 That way, xmalloc returns a properly-aligned pointer even if
5588 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5589 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5590 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5591 into account when calculating the initial malloc maximum.
5592 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5593 Move here from alloc.c, so that charset.c can use it too.
5594 Properly align; the old code wasn't right for common 32-bit hosts
5595 when configured with --enable-checking=all.
5596 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5597 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5599 2011-09-29 Eli Zaretskii <eliz@gnu.org>
5601 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
5604 2011-09-28 Eli Zaretskii <eliz@gnu.org>
5606 * xdisp.c (compute_display_string_end): If there's no display
5607 string at CHARPOS, return -1.
5609 * bidi.c (bidi_fetch_char): When compute_display_string_end
5610 returns a negative value, treat the character as a normal
5611 character not covered by a display string. (Bug#9624)
5613 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
5615 * lread.c (Fread_from_string): Fix typo in docstring.
5617 2011-09-27 Eli Zaretskii <eliz@gnu.org>
5619 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5620 newline, reseat the iterator instead of bidi-iterating there one
5621 character at a time. (Bug#9610)
5622 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5623 TO_CHARPOS if the bidi iterator is at base embedding level.
5625 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5627 * lread.c (readevalloop): Use correct code for NBSP.
5628 (read1): Likewise. (Bug#9608)
5630 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
5632 * dbusbind.c (Fdbus_register_signal): When service is not
5633 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5635 2011-09-25 Glenn Morris <rgm@gnu.org>
5637 * buffer.c (truncate-lines): Doc fix.
5639 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
5641 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5642 (Fset_window_next_buffers): Doc fix.
5644 2011-09-24 Glenn Morris <rgm@gnu.org>
5646 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5648 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5650 Fix minor problems found by static checking.
5651 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
5652 * indent.c (Fvertical_motion): Fix == vs = typo.
5654 2011-09-24 Eli Zaretskii <eliz@gnu.org>
5656 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5657 Default value is now t. Doc fix.
5659 * indent.c (Fvertical_motion): Compute and apply the overshoot
5660 logic when moving up, not only when moving down. Fix the
5661 confusing name and values of the it_overshoot_expected variable;
5662 logic changes accordingly. (Bug#9254) (Bug#9549)
5664 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5665 CHARPOS is covered by a display string which includes newlines.
5666 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5667 is covered by a display string with embedded newlines.
5669 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
5671 * dbusbind.c (Fdbus_register_signal): Add match rule to
5672 Vdbus_registered_objects_table. (Bug#9581)
5673 (Fdbus_register_method, Vdbus_registered_objects_table):
5676 2011-09-24 Jim Meyering <meyering@redhat.com>
5678 do not ignore write error for any output size
5679 The previous change was incomplete.
5680 While it makes emacs --batch detect the vast majority of stdout
5681 write failures, errors were still ignored whenever the output size is
5682 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5683 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5684 && echo FAIL: ignored write error
5685 FAIL: ignored write error
5686 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5687 && echo FAIL: ignored write error
5688 FAIL: ignored write error
5689 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5691 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5693 * emacs.c (Fkill_emacs): In noninteractive mode exit
5694 non-successfully if a write error occurred on stdout. (Bug#9574)
5696 2011-09-21 Eli Zaretskii <eliz@gnu.org>
5698 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5701 * dispextern.h (struct it): Update the comment documenting what
5704 2011-09-20 Eli Zaretskii <eliz@gnu.org>
5706 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5707 a display string, extend search for cursor position to end of row.
5708 (find_row_edges): If the row ends in a newline from a display
5709 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5710 Handle the case of a display string with multiple newlines.
5711 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5712 non-empty line. Fixes confusing cursor motion with arrow keys at
5713 the beginning of a line that starts with whitespace.
5715 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5717 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5720 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
5722 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5725 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5727 * xdisp.c (display_line): Record maximum and minimum buffer
5728 positions even if no glyphs were produced (e.g., by a zero-width
5729 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5730 buffer positions that will be removed from the glyph row because
5732 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5733 column is beyond frame width: don't subtract 1 "pixel" when
5734 computing width of the stretch.
5735 (reseat_at_next_visible_line_start): Undo the change made on
5736 2011-09-17 that saved paragraph information and restored it after
5737 the call to `reseat'. (Bug#9545)
5739 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5741 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5742 and turn window cursor on if cleared (Bug#9415).
5744 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
5746 * search.c (boyer_moore): Take unibyte characters from pattern
5747 literally. (Bug#9458)
5749 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5751 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5753 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5755 Fix minor problem found by static checking.
5756 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5757 initialized, to pacify gcc -Wuninitialized.
5759 * fileio.c: Report proper errno when syscall falls.
5760 (Finsert_file_contents): Save and restore errno,
5761 so that report_file_error outputs the correct diagnostic.
5762 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5764 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5766 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5768 2011-09-17 Eli Zaretskii <eliz@gnu.org>
5770 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5771 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5773 2011-09-17 Eli Zaretskii <eliz@gnu.org>
5775 * xdisp.c (reseat_at_next_visible_line_start): Keep information
5776 about the current paragraph and restore it after the call to reseat.
5778 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5779 (bidi_find_paragraph_start): Search back for paragraph beginning
5780 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5781 (bidi_move_to_visually_next): Only trigger paragraph-related
5782 computations when the last character is a newline or at EOB, not
5783 just any NEUTRAL_B. (Bug#9470)
5785 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5786 truncated lines if point is covered by a display string. (Bug#9524)
5788 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5790 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5791 (cons_to_x_long): New function.
5792 (lisp_data_to_selection_data): Use it. Correct the test for
5793 short-versus-long data; it was negated. Break out of vector
5794 loop, for efficiency, when a long datum is discovered.
5796 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5798 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5800 2011-09-16 Eli Zaretskii <eliz@gnu.org>
5802 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5803 GCC PR/17406) by declaring this function with external scope.
5805 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5807 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5808 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5810 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5812 * editfns.c (Fformat): Correctly handle text properties on "%%".
5814 2011-09-15 Eli Zaretskii <eliz@gnu.org>
5816 * xterm.c (x_draw_composite_glyph_string_foreground):
5817 * w32term.c (x_draw_composite_glyph_string_foreground):
5818 * term.c (encode_terminal_code):
5819 * composite.c (composition_update_it, get_composition_id):
5820 * xdisp.c (get_next_display_element)
5821 (fill_composite_glyph_string): Add comments about special meaning
5822 of TAB characters in a composition.
5824 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5826 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
5827 This occurs when processing a multibyte format.
5828 Problem reported by Wolfgang Jenker.
5830 2011-09-15 Johan Bockgård <bojohan@gnu.org>
5832 * xdisp.c (try_cursor_movement): Only check for exact match if
5833 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5835 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5837 Remove unused external symbols.
5838 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5839 * xdisp.c (calc_pixel_width_or_height): Now static.
5840 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5841 * indent.c (check_display_width):
5842 * w32term.c: Fix comment to match code.
5843 * xterm.c, xterm.h (x_catching_errors): Remove.
5845 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5847 * xselect.c: Use signed conversions more consistently (Bug#9498).
5848 (selection_data_to_lisp_data): Assume incoming selection data are
5849 signed integers, not unsigned. This is to be consistent with
5850 outgoing selection data, which was modified to use signed integers
5851 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5852 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5853 expects long, not unsigned long.
5855 2011-09-14 Eli Zaretskii <eliz@gnu.org>
5857 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5858 computation of loop end. Reported by Johan Bockgård
5861 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
5863 * frame.c (Fother_visible_frames_p): Function deleted.
5865 2011-09-12 Eli Zaretskii <eliz@gnu.org>
5867 * indent.c (compute_motion): Process display vector front to back
5868 rather than the other way around. (Bug#2496)
5870 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5872 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5874 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
5876 * minibuf.c (Fread_from_minibuffer): Doc fix.
5878 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5880 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5881 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5883 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5885 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5886 value for non-existent files.
5888 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5890 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5891 set its "size" to -1. This will set the modtime_size field of
5892 the corresponding buffer to -1, which is what
5893 verify-visited-file-modtime expects for files that do not exist.
5896 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5898 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5900 * lisp.h: ... from here. push_key_description is no longer
5901 defined in keyboard.c, so its declaration should not be in
5902 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5903 logically belongs with push_key_description.
5905 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5907 * buffer.h: Include <sys/types.h> instead of <time.h>.
5908 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5909 Problem reported by Herbert J. Skuhra.
5911 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5913 * xml.c (parse_region): Make the parsing work for
5914 non-comment-starting XML files again (bug#9144).
5916 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5918 * image.c (gif_load): Fix calculation of bottom and right corner.
5921 2011-09-10 Eli Zaretskii <eliz@gnu.org>
5923 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5924 redisplay in small windows.
5926 2011-09-09 Eli Zaretskii <eliz@gnu.org>
5928 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5930 2011-09-08 Martin Rudalics <rudalics@gmx.at>
5932 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5933 Operate on live windows only.
5935 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
5937 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5939 2011-09-07 Eli Zaretskii <eliz@gnu.org>
5941 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5942 only under bidi iteration.
5944 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5946 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5948 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5950 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5951 Without this fix, the command to link temacs failed due to an
5952 undefined symbol __builtin_isnan. This is because
5953 /usr/include/iso/math_c99.h #defines isnan(x) to
5954 __builtin_isnan(x), but the bundled gcc, which identifies itself
5955 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5957 * floatfns.c (isnan): #undef, and then #define to a clone of
5959 (Fisnan): Always define, since it's always available now.
5960 (syms_of_floatfns): Always define isnan at the Lisp level.
5962 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5964 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5966 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5968 * fileio.c: Fix bugs with large file offsets (Bug#9428).
5969 The previous code assumed that file offsets (off_t values) fit in
5970 EMACS_INT variables, which is not true on typical 32-bit hosts.
5971 The code messed up by falsely reporting buffer overflow in cases
5972 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5973 when "big" contains more than 2**29 bytes, even though this
5974 inserts just one byte and does not overflow the buffer.
5975 (Finsert_file_contents): Store file offsets as off_t
5976 values, not as EMACS_INT values. Check for overflow when
5977 converting between EMACS_INT and off_t. When checking for
5978 buffer overflow or for overlap, take the offsets into account.
5979 Don't use EMACS_INT for small values where int suffices.
5980 When checking for overlap, fix a typo: ZV was used where
5981 ZV_BYTE was intended.
5982 (Fwrite_region): Don't assume off_t fits into 'long'.
5983 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5985 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
5987 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5989 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5991 sprintf-related integer and memory overflow issues (Bug#9412).
5993 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
5994 (esprintf, exprintf, evxprintf): New functions.
5995 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
5996 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
5997 (modify_event_symbol): Do not assume that the length of
5998 name_alist_or_stem is safe to alloca and fits in int.
5999 (Fexecute_extended_command): Likewise for function name and binding.
6000 (Frecursion_depth): Wrap around reliably on integer overflow.
6001 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6002 since some callers pass EMACS_INT values.
6003 (Fsingle_key_description): Don't crash if symbol name contains more
6004 than MAX_ALLOCA bytes.
6005 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6006 (get_minibuffer): Arg is now EMACS_INT, not int.
6007 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
6008 (esprintf, exprintf, evxprintf): New decls.
6009 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6011 * dbusbind.c (signature_cat): New function.
6012 (xd_signature, Fdbus_register_signal):
6013 Do not overrun buffer; instead, report string overflow.
6015 * dispnew.c (add_window_display_history): Don't overrun buffer.
6016 Truncate instead; this is OK since it's just a log.
6018 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6019 even if the time zone offset is outlandishly large.
6020 Don't mishandle offset == INT_MIN.
6022 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6023 when creating daemon; the previous buffer-overflow check was incorrect.
6025 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6026 which has the guts of the old verror function.
6028 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6029 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6031 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6032 (font_unparse_xlfd): Don't blindly alloca long strings.
6033 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
6034 fits in int, when using sprintf. Use single snprintf to count
6035 length of string rather than counting it via multiple sprintfs;
6036 that's simpler and more reliable.
6037 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6038 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6039 sprintf, in case result does not fit in int.
6041 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6042 (fontset_from_font): Print it.
6044 * frame.c (tty_frame_count): Now printmax_t, not int.
6045 (make_terminal_frame, set_term_frame_name): Print it.
6046 (x_report_frame_params): In X, window IDs are unsigned long,
6047 not signed long, so print them as unsigned.
6048 (validate_x_resource_name): Check for implausibly long names,
6049 and don't assume name length fits in 'int'.
6050 (x_get_resource_string): Don't blindly alloca invocation name;
6051 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6054 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6055 (xg_check_special_colors, xg_set_geometry):
6056 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6058 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6059 Use esprintf, not sprintf, in case result does not fit in int.
6061 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6062 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6063 it as a large positive number.
6064 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6065 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6067 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6068 in case result does not fit in int.
6070 * print.c (float_to_string): Detect width overflow more reliably.
6071 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6072 buffer overrun. Don't assume list length fits in 'int'. Treat
6073 print length of 0 as 0, not as infinity; to be consistent with other
6074 uses of print length in this function. Don't overflow print length
6075 index. Don't assume hash table size fits in 'long', or that
6076 vectorlike size fits in 'unsigned long'.
6078 * process.c (make_process): Use printmax_t, not int, to format
6079 process-name gensyms.
6081 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6083 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6084 to avoid potential buffer overrun.
6086 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6087 if X resource line is longer than 512 bytes.
6089 * xfns.c (x_window): Make sprintf buffer a bit bigger
6090 to avoid potential buffer overrun.
6092 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6094 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6096 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6098 Integer overflow fixes for scrolling, etc.
6099 Without these, Emacs silently mishandles large integers sometimes.
6100 For example, "C-u 4294967297 M-x recenter" was treated as if
6101 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6103 * xdisp.c (try_window_id): Check Emacs fixnum range before
6104 converting to 'int'.
6106 * window.c (window_scroll_line_based, Frecenter):
6107 Check that an Emacs fixnum is in range before assigning it to 'int'.
6108 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6109 values converted from Emacs fixnums.
6110 (Frecenter): Don't wrap around a line count if it is out of 'int'
6111 range; instead, treat it as an extreme value.
6112 (Fset_window_configuration, compare_window_configurations):
6113 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6115 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6116 that can exceed INT_MAX. Check that EMACS_INT value is in range
6117 before assigning it to the (possibly-narrower) index.
6118 (match_limit): Don't assume that a fixnum can fit in 'int'.
6120 * print.c (print_object): Use ptrdiff_t, not int, for index that can
6123 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
6124 (Fvertical_motion): Don't wrap around LINES values that don't fit
6125 in 'int'. Instead, treat them as extreme values. This is good
6126 enough for windows, which can't have more than INT_MAX lines anyway.
6128 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6130 * Require libxml/parser.h to avoid compilation warning.
6132 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6134 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6135 since this reportedly can destroy thread storage.
6137 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
6139 * syntax.c (find_defun_start): Update all cache variables if
6140 exiting early (Bug#9401).
6142 2011-08-30 Eli Zaretskii <eliz@gnu.org>
6144 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6146 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6147 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6148 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6150 * term.c (tty_append_glyph): New function.
6151 (produce_stretch_glyph): Static function and its prototype deleted.
6153 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6156 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6158 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6159 when checking :margin (Bug#9390).
6160 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
6161 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
6162 so that the name doesn't mislead. All uses changed.
6164 2011-08-28 Johan Bockgård <bojohan@gnu.org>
6166 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6169 2011-08-27 Eli Zaretskii <eliz@gnu.org>
6171 * xdisp.c (move_it_to): Don't bail out early when reaching
6172 position beyond to_charpos, if we are scanning backwards.
6173 (move_it_vertically_backward): When DY == 0, make sure we get to
6174 the first character in the line after the newline.
6176 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6178 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6179 (ccl_driver): Do not generate an out-of-range pointer.
6180 (Fccl_execute_on_string): Remove unnecessary check for
6181 integer overflow, noted by Stefan Monnier in
6182 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6183 Remove a FIXME that didn't need fixing.
6184 Simplify the newly-introduced buffer reallocation code.
6186 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
6188 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6190 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
6192 Integer and memory overflow issues (Bug#9196).
6194 * doc.c (get_doc_string): Rework so that
6195 get_doc_string_buffer_size is the actual buffer size, rather than
6196 being 1 less than the actual buffer size; this makes xpalloc more
6199 * image.c (x_allocate_bitmap_record, cache_image):
6200 * xselect.c (Fx_register_dnd_atom):
6201 Simplify previous changes by using xpalloc.
6203 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6204 since either will do and ptrdiff_t is convenient with xpalloc.
6206 * charset.c (charset_table_size)
6207 (struct charset_sort_data.priority): Now ptrdiff_t.
6208 (charset_compare): Don't overflow if priorities differ greatly.
6209 (Fsort_charsets): Don't assume list length fits in int.
6210 Check for size-calculation overflow when allocating sort data.
6211 (syms_of_charset): Allocate an initial charset table that is
6212 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6214 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6216 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6217 The actual value is always <= INT_MAX, and leaving it unsigned made
6218 overflow checking harder.
6220 * dispextern.h (struct glyph_matrix.rows_allocated)
6221 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6222 with xpalloc. The values are still always <= INT_MAX.
6224 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6226 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6227 (SAFE_NALLOCA): New macro.
6229 * region-cache.c (struct boundary.pos, find_cache_boundary)
6230 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6231 (set_cache_region, invalidate_region_cache)
6232 (revalidate_region_cache, know_region_cache, region_cache_forward)
6233 (region_cache_backward, pp_cache):
6234 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6235 so that ptrdiff_t * can be passed to xpalloc.
6236 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6237 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6238 (pp_cache): Don't assume cache_len fits in int.
6239 * region-cache.h: Adjust extern decls to match.
6241 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6242 EMACS_INT, since either will do, for xpalloc.
6244 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6245 (xnmalloc, xnrealloc, xpalloc): New functions.
6247 * bidi.c (bidi_shelve_header_size): New constant.
6248 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6249 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6251 * bidi.c (bidi_cache_shrink):
6252 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6254 Don't update size of array until after memory allocation succeeds,
6255 because xmalloc/xrealloc may not return.
6256 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6257 now that we have proper integer overflow checking.
6258 (record_overlay_string, overlay_strings): Catch overflows when
6259 calculating size of overlay_str_buf.
6261 * callproc.c (Fcall_process): Check for size overflow when
6262 calculating size of args2.
6263 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6264 Normally we prefer signed values, but sticking with ptrdiff_t would
6265 require adding more-complicated checks.
6267 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6268 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6269 Redo buffer-overflow calculations to avoid integer overflow.
6270 Add a FIXME comment where memory seems to be over-allocated.
6272 * character.c (Fstring): Check for size-calculation overflow.
6274 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6275 unnecessary integer overflow. Check for size overflow.
6276 (encode_coding_object): Don't update size until xmalloc succeeds.
6278 * composite.c (get_composition_id): Check for overflow in glyph
6279 length calculations.
6281 Integer and memory overflow fixes for display code.
6282 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6283 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6284 (scrolling_window): Check for overflow in size calculations.
6285 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6286 Don't assume glyph table len fits in int.
6287 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6288 (row_table_size): Now ptrdiff_t, not int.
6289 (scrolling_window): Avoid overflow in size calculations.
6290 Don't update size until allocation succeeds.
6291 * fns.c (concat): Check for overflow in size calculations.
6292 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6293 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6294 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6296 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6297 (get_doc_string): Check for size calculation overflow.
6298 Don't update size until allocation succeeds.
6299 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6300 EMACS_INT, where ptrdiff_t will do.
6301 (Fsubstitute_command_keys): Check for string overflow.
6303 * editfns.c (set_time_zone_rule): Don't assume environment length
6305 (message_length): Now ptrdiff_t, not int.
6306 (Fmessage_box): Don't update size until allocation succeeds.
6307 Don't assume message length fits in int.
6308 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6310 * emacs.c (main): Do not reallocate argv, since there is a null at
6311 the end that can be overwritten, and this way there's no need to
6312 worry about size-calculation overflow.
6313 (sort_args): Check for size-calculation overflow.
6315 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6317 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6319 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6320 (x_set_scroll_bar_width, x_figure_window_size):
6321 Check for integer overflow.
6322 (x_set_alpha): Do not assume XINT fits in int.
6324 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6325 This is for the members text_lines, text_cols, total_lines, total_cols,
6326 where the system imposes an 'int' limit.
6328 * fringe.c (Fdefine_fringe_bitmap):
6329 Don't update size until alloc works.
6331 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6332 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6334 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6335 Check for size-calculation overflow.
6336 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6337 do, as we prefer signed integers.
6338 (id_to_widget.max_size, id_to_widget.used)
6339 (xg_store_widget_in_map, xg_remove_widget_from_map)
6340 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6341 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6342 Use and return ptrdiff_t, not int.
6343 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6344 * gtkutil.h: Change prototypes to match the above.
6346 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6347 are duplicate now that they've been promoted to lisp.h.
6348 (x_allocate_bitmap_record, x_alloc_image_color)
6349 (make_image_cache, cache_image, xpm_load):
6350 Don't update size until alloc is done.
6351 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6353 Check for size calculation overflow.
6354 (ct_colors_allocated_max): New constant.
6355 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6358 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6359 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6360 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6361 Use ptrdiff_t, not int, to count maps.
6362 (read_char_minibuf_menu_prompt): Check for overflow in size
6363 calculations. Don't update size until allocation succeeds.
6364 Redo calculations to avoid overflow.
6365 * keyboard.h: Change prototypes to match the above.
6367 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6369 (current_minor_maps): Check for size calculation overflow.
6370 * keymap.h: Change prototypes to match the above.
6372 * lread.c (read1, init_obarray): Don't update size until alloc done.
6374 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6375 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6377 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6378 Now ptrdiff_t, not int.
6379 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6380 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6382 * process.c (Fnetwork_interface_list): Check for overflow
6383 in size calculation.
6385 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6387 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6388 overflow. Don't bother calling xmalloc when xrealloc will do.
6390 * search.c (Freplace_match): Check for size calculation overflow.
6391 (Fset_match_data): Don't assume list lengths fit in 'int'.
6393 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6394 for command line length. Do not attempt to address one before the
6395 beginning of an array, as that's not portable.
6397 * term.c (max_frame_lines): Remove; unused.
6398 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6400 (encode_terminal_code, calculate_costs): Check for size
6401 calculation overflow.
6402 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6403 table lengths and related sizes. Don't update size until alloc
6404 done. Redo calculations to avoid overflow.
6405 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6407 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6408 subtracting pointers.
6409 (gobble_line): Check for overflow more carefully. Don't update size
6412 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6413 Don't update size until alloc done.
6414 Redo size calculations to avoid overflow.
6415 Check for size calculation overflow.
6416 (main) [DEBUG]: Fix typo in invoking tparam1.
6418 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6419 Use ptrdiff_t, not int, for sizes.
6420 (store_mode_line_noprop_char): Don't update size until alloc done.
6422 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6423 Use ptrdiff_t, not int, for sizes.
6424 (Finternal_make_lisp_face, cache_face):
6425 Check for size calculation overflow.
6426 (cache_face): Treat size calculation overflows as if they were
6427 memory exhaustion (the usual treatment), rather than aborting.
6429 * xfns.c (x_encode_text, x_set_name_internal)
6430 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6431 sizes, since they can exceed INT_MAX in size. Check for size
6432 calculation overflow.
6434 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6435 (xg_select): Check for size calculation overflow.
6436 Don't update size until alloc done.
6438 * xrdb.c (get_environ_db): Don't assume path length fits in int,
6439 as sprintf is limited to int lengths.
6441 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6442 (X_LONG_MIN): New macros.
6443 Use them to make the following changes clearer.
6444 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6445 This change doesn't affect the value now, but it may help remind
6446 future maintainers not to raise the value too much later.
6447 (SELECTION_QUANTUM): Remove, replacing with ...
6448 (selection_quantum): ... new function, which avoids overflow.
6450 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6451 assumption that selection length fits in 'int'.
6452 (x_reply_selection_request, x_handle_selection_request)
6453 (x_get_window_property, receive_incremental_selection)
6454 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6455 (lisp_data_to_selection_data, clean_local_selection_data):
6456 Use ptrdiff_t, not int, to record length of selection.
6457 (x_reply_selection_request, x_get_window_property)
6458 (receive_incremental_selection, x_property_data_to_lisp):
6459 Redo calculations to avoid overflow.
6460 (x_reply_selection_request): When sending hint, ceiling it at
6461 X_LONG_MAX rather than relying on wraparound overflow to send
6463 (x_get_window_property, receive_incremental_selection)
6464 (lisp_data_to_selection_data, x_property_data_to_lisp):
6465 Check for size-calculation overflow.
6466 (x_get_window_property, receive_incremental_selection)
6467 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6468 Don't store size until memory allocation succeeds.
6469 (x_get_window_property): Plug memory leak on memory exhaustion.
6470 Don't double-block input; malloc is safe here. Don't assume 2**34
6471 - 4 fits in unsigned long. Add an xassert to check
6472 XGetWindowProperty overflow. Be more careful about overflow
6473 calculations, and distinguish size from memory overflow better.
6474 (receive_incremental_selection): When tracing, don't assume
6475 unsigned int is less than INT_MAX.
6476 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6477 harmful) conversions of unsigned short to int.
6478 (lisp_data_to_selection_data): Don't assume that integers
6479 in the range -65535 through -1 fit in an X unsigned short.
6480 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6481 result parameters unless successful. Rely on cons_to_unsigned
6482 to report problems with elements; the old code wasn't right anyway.
6483 (x_check_property_data): Check for int overflow; we cannot use
6484 a wider type due to X limits.
6485 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6487 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
6489 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6490 (x_term_init): Check for size calculation overflow.
6491 (x_color_cells): Don't store size until memory allocation succeeds.
6492 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
6493 Don't assume alloca size is less than MAX_ALLOCA.
6494 (x_term_init): Don't assume length fits in int (sprintf is limited
6497 Use ptrdiff_t for composition IDs.
6498 * character.c (lisp_string_width):
6499 * composite.c (composition_table_size, n_compositions)
6500 (get_composition_id, composition_gstring_from_id):
6501 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6502 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6503 * window.c (Frecenter):
6504 Use ptrdiff_t, not int, for composition IDs.
6505 * composite.c (get_composition_id): Check for integer overflow.
6506 * composite.h: Adjust prototypes to match the above changes.
6508 Use ptrdiff_t for hash table indexes.
6509 * category.c (hash_get_category_set):
6510 * ccl.c (ccl_driver):
6511 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6512 * coding.c (coding_system_charset_list, detect_coding_system):
6513 * coding.h (struct coding_system.id):
6514 * composite.c (get_composition_id, gstring_lookup_cache):
6515 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6516 * image.c (xpm_get_color_table_h):
6517 * lisp.h (hash_lookup, hash_put):
6518 * minibuf.c (Ftest_completion):
6519 Use ptrdiff_t for hash table indexes, not int (which is too
6520 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6521 32-bit --with-wide-int hosts).
6523 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6524 Add a FIXME comment about memory leaks.
6525 (syms_of_charset): Don't assume xmalloc returns.
6527 Don't assume that stated character widths fit in int.
6528 * character.c (Fchar_width, c_string_width, lisp_string_width):
6529 * character.h (CHAR_WIDTH):
6530 * indent.c (MULTIBYTE_BYTES_WIDTH):
6531 Use sanitize_char_width to avoid undefined and/or bad behavior
6532 with outlandish widths.
6533 * character.h (sanitize_tab_width): Rename from sanitize_width,
6534 now that we have two such functions. All uses changed.
6535 (sanitize_char_width): New inline function.
6537 Don't assume that tab-width fits in int.
6538 * character.h (sanitize_width): New inline function.
6539 (SANE_TAB_WIDTH): New macro.
6540 (ASCII_CHAR_WIDTH): Use it.
6541 * indent.c (sane_tab_width): Remove. All uses replaced by
6542 SANE_TAB_WIDTH (current_buffer).
6543 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6545 * fileio.c: Integer overflow issues with file modes.
6546 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6548 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6549 Remove unreachable code.
6550 (read_hex, load_charset_map_from_file): Check for integer overflow.
6552 * xterm.c: Don't go over XClientMessageEvent limit.
6553 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6554 (x_send_scroll_bar_event): Likewise. Check that the size does not
6555 exceed limits imposed by XClientMessageEvent, as well as the usual
6556 ptrdiff_t and size_t limits.
6558 * keyboard.c: Overflow, signedness and related fixes.
6559 (make_lispy_movement): Use same integer type in forward decl
6560 that is used in the definition.
6561 (read_key_sequence, keyremap_step):
6562 Change bufsize argument back to int, undoing my 2011-03-30 change.
6563 We prefer signed types, and int is wide enough here.
6564 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6565 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6566 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6567 length, not size_t. Use ptrdiff_t for index, not int.
6568 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6569 possibility of integer overflow.
6571 Overflow, signedness and related fixes for images.
6573 * dispextern.h (struct it.stack[0].u.image.image_id)
6574 (struct_it.image_id, struct image.id, struct image_cache.size)
6575 (struct image_cache.used, struct image_cache.ref_count):
6576 * gtkutil.c (update_frame_tool_bar):
6577 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6578 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6579 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6580 * nsmenu.m (update_frame_tool_bar):
6581 * xdisp.c (calc_pixel_width_or_height):
6582 * xfns.c (image_cache_refcount):
6583 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6584 on typical 64-bit hosts.
6586 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6587 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6588 Omit unnecessary casts to int.
6589 (parse_image_spec): Check that integers fall into 'int' range
6590 when the callers expect that.
6591 (image_ascent): Redo ascent calculation to avoid int overflow.
6592 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6593 (lookup_image): Remove unnecessary tests.
6594 (xbm_image_p): Locals are now of int, not EMACS_INT,
6595 since parse_image_check makes sure they fit into int.
6596 (png_load, gif_load, svg_load_image):
6597 Prefer int to unsigned where either will do.
6598 (tiff_handler): New function, combining the cores of the
6599 old tiff_error_handler and tiff_warning_handler.
6600 This function is rewritten to use vsnprintf and thereby avoid
6601 stack buffer overflows. It uses only the features of vsnprintf
6602 that are common to both POSIX and native Microsoft.
6603 (tiff_error_handler, tiff_warning_handler): Use it.
6604 (tiff_load, gif_load, imagemagick_load_image):
6605 Don't assume :index value fits in 'int'.
6606 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6607 (imagemagick_load_image): Check that crop parameters fit into
6608 the integer types that MagickCropImage accepts. Don't assume
6609 Vimagemagick_render_type has a nonnegative value. Don't assume
6610 size_t fits in 'long'.
6611 (gs_load): Use printmax_t to print the widest integers possible.
6612 Check for integer overflow when computing image height and width.
6614 2011-08-26 Eli Zaretskii <eliz@gnu.org>
6616 * xdisp.c (redisplay_window): Don't force window start if point
6617 will be invisible in the resulting window. (Bug#9324)
6619 2011-08-25 Eli Zaretskii <eliz@gnu.org>
6621 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6622 the display spec is of the form `(space ...)'.
6623 (handle_display_spec): Return the value returned by
6624 handle_single_display_spec, not just 1 or zero.
6625 (handle_single_display_spec): If the display spec is of the form
6626 `(space ...)', and specifies display in the text area, return 2
6628 (try_cursor_movement): Check for the need to scroll more
6629 accurately, and prefer exact match for point under bidi.
6630 Don't advance `row' beyond the last row of the window.
6632 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6633 into disp_prop; all users changed.
6635 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6636 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6637 for the text covered by the display property.
6639 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
6641 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6642 Change return value to nil.
6643 (Frecord_buffer): Delete unused function.
6645 2011-08-24 Eli Zaretskii <eliz@gnu.org>
6647 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6648 buffers, return left-to-right.
6649 (set_cursor_from_row): Consider candidate row a win if its glyph
6650 represents a newline and point is on that newline. Fixes cursor
6651 positioning on the newline at EOL of R2L text within L2R
6652 paragraph, and vice versa.
6653 (try_cursor_movement): Check continued rows, in addition to
6654 continuation rows. Fixes unwarranted scroll when point enters a
6655 continued line of R2L text within an L2R paragraph, or vice versa.
6656 (cursor_row_p): Consider the case of point being equal to
6657 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6658 from the end of a short line to the beginning of a continued line
6659 of R2L text within L2R paragraph.
6660 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6661 composed characters.
6663 * bidi.c (bidi_check_type): Use xassert.
6664 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6667 2011-08-23 Eli Zaretskii <eliz@gnu.org>
6669 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6672 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
6674 * nsfont.m (ns_otf_to_script): Fix typo.
6676 2011-08-22 Kenichi Handa <handa@m17n.org>
6678 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6679 extra slot even if the purpose is char-code-property-table.
6681 2011-08-23 Eli Zaretskii <eliz@gnu.org>
6683 * xdisp.c (redisplay_window): When computing centering_position,
6684 account for the height of the header line. (Bug#8874)
6686 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6687 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6688 candidate is selected by the mouse, and that candidate has a
6689 composed character under the mouse.
6691 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6692 coordinates reported by pos-visible-in-window-p for a composed
6693 character in column zero.
6695 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6697 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6699 2011-08-22 Eli Zaretskii <eliz@gnu.org>
6701 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6702 consider it a hit if to_charpos is anywhere in the range of the
6703 composed buffer positions.
6705 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
6707 * image.c (gif_load): Don't assume that each subimage has the same
6708 dimensions as the base image. Handle disposal method that is
6709 "undefined" by the gif spec (Bug#9335).
6711 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
6713 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
6714 (Fcondition_case): Document `debug' symbol in error handler.
6716 2011-08-19 Eli Zaretskii <eliz@gnu.org>
6718 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6719 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6720 from an Org mode buffer to a Speedbar frame.
6722 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6723 a composition, take its buffer position from IT->cmp_it.charpos.
6724 Fixes cursor positioning at the beginning of a line that begins
6725 with a composed character.
6727 2011-08-18 Eli Zaretskii <eliz@gnu.org>
6729 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6730 character bidirectional type, use STRONG_L instead. Fixes crashes
6731 in a buffer produced by `describe-categories'.
6733 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6734 members before the level stack, so they would be saved and
6735 restored when copying iterator state. Fixes incorrect reordering
6736 around TABs covered by display properties.
6738 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6740 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
6742 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
6744 * eval.c (internal_condition_case, internal_condition_case_1)
6745 (internal_condition_case_2, internal_condition_case_n):
6746 Remove unnecessary aborts (Bug#9081).
6748 2011-08-17 Eli Zaretskii <eliz@gnu.org>
6750 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6751 has no `load' handler, try opening the file locally. (Bug#9311)
6753 2011-08-16 Ken Brown <kbrown@cornell.edu>
6755 * gmalloc.c: Expand comment.
6757 2011-08-16 Eli Zaretskii <eliz@gnu.org>
6759 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6760 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6762 2011-08-16 Ken Brown <kbrown@cornell.edu>
6764 Fix memory allocation problems in Cygwin build (Bug#9273).
6766 * unexcw.c ( __malloc_initialized): Declare external variable.
6767 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6769 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6771 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6773 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6775 [CYGWIN] (special_realloc): New function.
6776 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6777 requests to realloc storage in the static heap.
6779 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6781 * bidi.c (bidi_initialize): Remove unused local.
6783 2011-08-15 Eli Zaretskii <eliz@gnu.org>
6786 * biditype.h: Remove file.
6787 * makefile.w32-in ($(BLD)/bidi.$(O)):
6788 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
6790 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6792 * chartab.c: Improve commentary for the uniprop_table API.
6794 * bidi.c (bidi_paragraph_init): Support zero value of
6795 bidi_ignore_explicit_marks_for_paragraph_level.
6796 (bidi_initialize): Use uniprop_table instead of including
6797 biditype.h and bidimirror.h.
6799 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6800 coordinates of the iterator when restoring from ppos_it.
6803 2011-08-14 Kenichi Handa <handa@m17n.org>
6805 * process.c (create_process): Call setup_process_coding_systems
6806 after the pid of the process is set to -1 (Bug#8162).
6808 2011-08-14 Eli Zaretskii <eliz@gnu.org>
6810 * xdisp.c (move_it_in_display_line_to): Don't invoke
6811 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6812 ppos_it. Fixes vertical cursor motion when line beginning is
6813 covered by an image. (Bug#9296)
6815 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6817 * nsterm.h (ns_run_ascript): Declare.
6818 (NSAPP_DATA2_RUNASSCRIPT): Define.
6820 * nsfns.m (as_script, as_result, as_status): New static variables.
6821 (ns_run_ascript): New function.
6822 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
6823 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6824 the event loop. Get status from as_status (Bug#7276).
6826 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6827 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6828 the event loop (Bug#7276).
6830 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6832 * gnutls.c (QCgnutls_bootprop_priority)
6833 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6834 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6835 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6836 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6837 (QCgnutls_bootprop_verify_hostname_error)
6838 (QCgnutls_bootprop_callbacks_verify): Rename from
6839 Qgnutls_bootprop_..., all uses changed.
6841 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6844 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6846 * xfaces.c (Qframe_set_background_mode): Now static.
6847 * dispextern.h (Qframe_set_background_mode): Remove decl.
6849 * process.c (Fnetwork_interface_info): Declare local only if needed.
6851 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6853 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6854 (Fnetwork_interface_list): Allocate in increments of bytes instead
6855 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6856 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6858 (struct ifflag_def): notrailers is smart on OSX.
6859 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6860 Get hardware address with getifaddrs if available.
6862 2011-08-12 Eli Zaretskii <eliz@gnu.org>
6864 * xdisp.c (iterate_out_of_display_property): xassert that
6865 IT->position is set to within IT->object's boundaries. Break from
6866 the loop as soon as EOB is reached; avoids infloops in redisplay
6867 when IT->position is set up wrongly due to some bug.
6868 Set IT->current to match the bidi iterator unconditionally.
6869 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6870 entry. Force push_it to save on the stack the current
6871 buffer/string position, to be restored by pop_it. Fix flags in
6872 the iterator structure wrt the object coming from a display
6873 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6874 properties. (Bug#9284)
6876 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
6878 * fontset.c (fontset_get_font_group): Add proper type checks.
6881 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6883 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6884 and LC_VERSION_MIN_MACOSX.
6885 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6886 (dump_it) [LC_FUNCTION_STARTS]: Use it.
6888 2011-08-08 Eli Zaretskii <eliz@gnu.org>
6890 * xdisp.c (forward_to_next_line_start): Allow to use the
6891 no-display-properties-and-no-overlays under bidi display.
6892 Set disp_pos in the bidi iterator to avoid searches for display
6893 properties and overlays.
6895 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
6897 * editfns.c (Fset_time_zone_rule): Document relationship with the
6900 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6901 the font entity extracted from the cache (Bug#8109).
6903 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
6905 * composite.c (autocmp_chars): Don't reset point. That is done by
6906 restore_point_unwind (Bug#5984).
6908 2011-08-07 Juri Linkov <juri@jurta.org>
6910 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6911 to show the arg `TIME' instead of `TIMEVAL'.
6913 2011-08-06 Eli Zaretskii <eliz@gnu.org>
6915 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6916 display property strides EOL and includes a newline, as in
6917 longlines-mode. (Bug#9254)
6918 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6919 word-wrap under bidirectional display. (Bug#9224)
6921 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6922 is non-zero, even if the data buffer is NULL. Fixes a crash in
6923 vertical-motion with longlines-mode. (Bug#9254)
6925 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6927 * bidi.c <bidi_cache_total_alloc>: Now static.
6928 (bidi_initialize): Initialize bidi_cache_total_alloc.
6930 * xdisp.c (display_line): Release buffer allocated for shelved bidi
6933 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6934 amount allocated this far in `bidi_cache_total_alloc'.
6935 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6936 non-zero, only free the data buffer without restoring the cache
6937 contents. All callers changed.
6939 * dispextern.h (bidi_unshelve_cache): Update prototype.
6941 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6942 (move_it_in_display_line, move_it_to)
6943 (move_it_vertically_backward, move_it_by_lines): Replace the call
6944 to xfree to an equivalent call to bidi_unshelve_cache.
6945 (move_it_in_display_line_to): Fix logic of returning
6946 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
6948 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6950 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6951 came from a string character with a `cursor' property. (Bug#9229)
6953 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6955 * Makefile.in (LIB_PTHREAD): New variable.
6956 (LIBES): Add LIB_PTHREAD (Bug#9216).
6958 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6959 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6961 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6963 * regex.c (re_iswctype): Remove some redundant boolean conversions.
6965 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6967 * xterm.c (x_find_topmost_parent): New function.
6968 (x_set_frame_alpha): Find topmost parent window with
6969 x_find_topmost_parent and set the property there also (bug#9181).
6970 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6972 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6974 * callproc.c (Fcall_process): Avoid vfork clobbering
6975 the local vars buffer, coding_systems, current_dir.
6977 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6979 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6981 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6983 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6984 so that it is not optimized away.
6986 * xdisp.c (compute_display_string_pos): Remove unused local.
6988 2011-08-02 Eli Zaretskii <eliz@gnu.org>
6990 Fix slow cursor motion and scrolling in large buffers with
6991 selective display, like Org Mode buffers. (Bug#9218)
6993 * dispextern.h (struct bidi_it): New member disp_prop_p.
6995 * xdisp.c: Remove one-slot cache of display string positions.
6996 (compute_display_string_pos): Accept an additional argument
6997 DISP_PROP_P; callers changed. Scan at most 5K characters forward
6998 for a display string or property. If found, set DISP_PROP_P
7001 * bidi.c (bidi_fetch_char): Accept an additional argument
7002 DISP_PROP_P, and pass it to compute_display_string_pos.
7003 Only handle text covered by a display string if DISP_PROP_P is returned
7004 non-zero. All callers of bidi_fetch_char changed.
7006 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7008 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7010 2010-12-03 Don March <don@ohspite.net>
7012 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7013 last character M-[char] is translated to ESC [char] (bug#7541).
7015 2011-08-02 Kenichi Handa <handa@m17n.org>
7017 * lisp.h (uniprop_table): Extern it.
7019 * chartab.c (uniprop_table): Make it non-static.
7021 2011-08-01 Eli Zaretskii <eliz@gnu.org>
7023 * xdisp.c (forward_to_next_line_start): Accept additional argument
7024 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7026 (reseat_at_next_visible_line_start): Use the bidi iterator state
7027 returned by forward_to_next_line_start to restore the state of
7028 it->bidi_it after backing up to previous newline. (Bug#9212)
7030 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7032 * regex.c (re_comp): Protoize.
7033 (re_exec): Fix return type.
7034 (regexec): Fix type of `ret'. (Bug#9203)
7036 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7038 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7039 This is needed if max-image-size is a floating-point number.
7041 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7043 * print.c (print_object): Print empty symbol as ##.
7045 * lread.c (read1): Read ## as empty symbol.
7047 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7049 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7050 setting frame foreground color (Bug#9175).
7051 (x_set_background_color): Likewise.
7053 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7054 contents (Bug#9176).
7055 (EmacsTooltip -init): Remove bezels and add shadows to
7058 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7059 or scroll bar (Bug#8470).
7061 * nsfont.m (nsfont_open): Remove assignment to voffset and
7062 unnecessary vars hshink, expand, hd, full_height, min_height.
7063 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7065 * nsterm.h (nsfont_info): Remove voffset field.
7067 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7069 Implement strike-through and overline on NextStep (Bug#8863).
7071 * nsfont.m (nsfont_open): Use underline position provided by font,
7072 instead of hard-coded value of 2.
7073 (nsfont_draw): Call ns_draw_text_decoration instead.
7075 * nsterm.h: Add declaration for ns_draw_text_decoration.
7077 * nsterm.m (ns_draw_text_decoration): New function for drawing
7078 underline, overline, and strike-through.
7079 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7080 ns_draw_text_decoration. Change treatment of cursor drawing to
7081 accommodate underlining, etc.
7083 2011-07-28 Eli Zaretskii <eliz@gnu.org>
7085 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7088 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7090 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7091 Without this fix, if a signal arrives just after memory fills up,
7092 'malloc' might be invoked reentrantly.
7094 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7095 In other words, assume that every image size is allowed, on non-X
7096 hosts. This assumption is probably wrong, but it lets Emacs compile.
7098 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7100 * regex.c (re_iswctype): Convert return values to boolean.
7102 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7104 * xdisp.c (compute_display_string_pos): Don't use cached display
7105 string position if the buffer had its restriction changed.
7108 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7110 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7112 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7114 Integer signedness and overflow and related fixes. (Bug#9079)
7116 * bidi.c: Integer size and overflow fixes.
7117 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7118 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7119 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7120 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7121 (bidi_find_other_level_edge):
7122 Use ptrdiff_t instead of EMACS_INT where either will do.
7123 This works better on 32-bit hosts configured --with-wide-int.
7124 (bidi_cache_ensure_space): Check for size-calculation overflow.
7125 Use % rather than repeated addition, for better worst-case speed.
7126 Don't set bidi_cache_size until after xrealloc returns, because it
7128 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
7129 (bidi_cache_ensure_space): Also check that the bidi cache size
7130 does not exceed that of the largest Lisp string or buffer. See Eli
7131 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
7133 * alloc.c (__malloc_size_t): Remove.
7134 All uses replaced by size_t. See Andreas Schwab's note
7135 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7137 * image.c: Improve checking for integer overflow.
7138 (check_image_size): Assume that f is nonnull, since
7139 it is always nonnull in practice. This is one less thing to
7140 worry about when checking for integer overflow later.
7141 (x_check_image_size): New function, which checks for integer
7142 overflow issues inside X.
7143 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7144 This removes the need for a memory_full check.
7145 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7146 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7147 (xbm_read_bitmap_data): Change locals back to 'int', since
7148 their values must fit in 'int'.
7149 (xpm_load_image, png_load, tiff_load):
7150 Invoke x_create_x_image_and_pixmap earlier,
7151 to avoid much needless work if the image is too large.
7152 (tiff_load): Treat overly large images as if
7153 x_create_x_image_and_pixmap failed, not as malloc failures.
7154 (gs_load): Use x_check_image_size.
7156 * gtkutil.c: Omit integer casts.
7157 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7158 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7160 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7162 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7163 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7164 would wrongly return t on a 64-bit host.
7166 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7167 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7168 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7169 and therefore cause GCC to emit a bogus diagnostic in some cases.
7171 * image.c: Integer signedness and overflow and related fixes.
7172 This is not an exhaustive set of fixes, but it's time to
7173 record what I've got.
7174 (lookup_pixel_color, check_image_size): Remove redundant decls.
7175 (check_image_size): Don't assume that arbitrary EMACS_INT values
7176 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7177 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7178 (tiff_load, imagemagick_load_image):
7179 Check for overflow in size calculations.
7180 (x_create_x_image_and_pixmap): Remove unnecessary test for
7181 xmalloc returning NULL; that can't happen.
7182 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7183 (xpm_color_bucket): Use better integer hashing function.
7184 (xpm_cache_color): Don't possibly over-allocate memory.
7185 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7186 (gif_memory_source):
7187 Use ptrdiff_t, not int or size_t, to record sizes.
7188 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7189 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7190 either works, as we prefer signed integers.
7191 (tiff_read_from_memory, tiff_write_from_memory):
7192 Return tsize_t, not size_t, since that's what the TIFF API wants.
7193 (tiff_read_from_memory): Don't fail simply because the read would
7194 go past EOF; instead, return a short read.
7195 (tiff_load): Omit no-longer-needed casts.
7196 (Fimagemagick_types): Don't assume size fits into 'int'.
7198 Improve hashing quality when configured --with-wide-int.
7199 * fns.c (hash_string): New function, taken from sxhash_string.
7200 Do not discard information about ASCII character case; this
7201 discarding is no longer needed.
7202 (sxhash-string): Use it. Change sig to match it. Caller changed.
7203 * lisp.h: Declare it.
7204 * lread.c (hash_string): Remove, since we now use fns.c's version.
7205 The fns.c version returns a wider integer if --with-wide-int is
7206 specified, so this should help the quality of the hashing a bit.
7208 * emacs.c: Integer overflow minor fix.
7209 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7210 Define only if GNU_LINUX.
7211 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7213 * dispnew.c: Integer signedness and overflow fixes.
7214 Remove unnecessary forward decls, that were a maintenance hassle.
7215 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7217 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7218 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7219 (prepare_desired_row, line_draw_cost):
7220 Use int, not unsigned, where either works.
7221 (save_current_matrix, restore_current_matrix):
7222 Use ptrdiff_t, not size_t, where either works.
7223 (init_display): Check for overflow more accurately, and without
7224 relying on undefined behavior.
7226 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7227 Remove, replacing with the new symbols in lisp.h. All uses changed.
7228 * fileio.c (make_temp_name):
7229 * filelock.c (lock_file_1, lock_file):
7230 * xdisp.c (message_dolog):
7231 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7232 Use pMd etc. instead.
7233 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7234 replacing the pWIDE etc. symbols removed from editfns.c.
7236 * keyboard.h (num_input_events): Now uintmax_t.
7237 This is (very slightly) less likely to mess up due to wraparound.
7240 * buffer.c: Integer signedness fixes.
7241 (alloc_buffer_text, enlarge_buffer_text):
7242 Use ptrdiff_t rather than size_t when either will do, as we prefer
7245 * alloc.c: Integer signedness and overflow fixes.
7246 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7247 (__malloc_size_t): Default to size_t, not to int.
7248 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7249 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7250 Prefer ptrdiff_t to size_t when either would do, as we prefer
7252 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7253 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7254 Now const. Initialize with values that are in range even if char
7256 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7257 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7258 These functions do the right thing with sizes > 2**32.
7259 (check_depth): Now ptrdiff_t, not int.
7260 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7261 Adjust to new way of storing sizes. Check for size overflow bugs
7263 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7264 slightly wrong anyway, as it missed one instance of
7265 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7266 (refill_memory_reserve): Omit needless cast to size_t.
7267 (mark_object_loop_halt): Mark as externally visible.
7269 * xselect.c: Integer signedness and overflow fixes.
7270 (Fx_register_dnd_atom, x_handle_dnd_message):
7271 Use ptrdiff_t, not size_t, since we prefer signed.
7272 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7273 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7274 x_dnd_atoms_size and x_dnd_atoms_length.
7276 * doprnt.c: Prefer signed to unsigned when either works.
7278 * doprnt.c (doprnt):
7280 * xdisp.c (vmessage):
7281 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7282 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7283 prefer signed arithmetic to avoid comparison confusion.
7284 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7285 but is a bit tricky.
7287 Assume freestanding C89 headers, string.h, stdlib.h.
7288 * data.c, doprnt.c, floatfns.c, print.c:
7289 Include float.h unconditionally.
7290 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7291 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7292 * regex.c: Likewise for stddef.h, string.h.
7293 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7294 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7295 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7296 (STDC_HEADERS): Remove obsolete defines.
7297 * sysdep.c: Include limits.h unconditionally.
7299 Assume support for memcmp, memcpy, memmove, memset.
7300 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7301 * regex.c (memcmp, memcpy):
7302 Remove; we assume C89 now.
7304 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7305 (__malloc_safe_bcopy): Remove; no longer needed.
7307 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
7308 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7309 well either way, and we prefer signed to unsigned.
7311 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7313 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7314 closes the connection while we're reading (bug#9182).
7316 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
7318 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7319 are specified (Bug#9168).
7321 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7323 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7324 Found by GCC static checking and --with-wide-int on a 32-bit host.
7326 2011-07-25 Eli Zaretskii <eliz@gnu.org>
7328 * xdisp.c (compute_display_string_pos): Fix logic of caching
7329 previous display string position. Initialize cached_prev_pos to
7330 -1. Fixes slow-down at the beginning of a buffer.
7332 2011-07-24 Eli Zaretskii <eliz@gnu.org>
7334 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7335 for attrs[LFACE_FONTSET_INDEX].
7337 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7339 * xml.c (parse_region): Remove unused local
7340 that was recently introduced.
7342 2011-07-23 Eli Zaretskii <eliz@gnu.org>
7344 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7345 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7347 * xdisp.c (move_it_in_display_line_to): Record the best matching
7348 position for TO_CHARPOS while scanning the line, and restore it on
7349 exit if none of the characters scanned was an exact match.
7350 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
7351 when exact match is impossible due to invisible text, and the
7352 lines are truncated.
7354 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7356 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7359 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7361 Fix a significant slow-down of cursor motion with C-n, C-p,
7362 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7363 auto-repeat under bidi redisplay in fontified buffers.
7364 * xdisp.c (compute_stop_pos_backwards): New function.
7365 (next_element_from_buffer): Call compute_stop_pos_backwards to
7366 find a suitable prev_stop when we find ourselves before
7368 (reseat): Don't look for prev_stop, as that could mean a very long
7370 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7371 <cached_disp_overlay_modiff>: Cache for last found display string
7373 (compute_display_string_pos): Return the cached position if asked
7374 about the same buffer in the same area of character positions, and
7375 the buffer wasn't changed since the time the display string
7376 position was cached.
7378 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7380 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7381 is an integer, which is important for empty lines. (Bug#9149)
7383 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
7385 * frame.c (Fmodify_frame_parameters): In tty case, update the
7386 default face if necessary (Bug#4238).
7388 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
7390 * editfns.c (Fstring_to_char): No need to explain what a character
7391 is in the docstring (Bug#6576).
7393 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7395 * xml.c (parse_region): Make sure we always return a tree.
7397 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7399 * xml.c (parse_region): If a document contains only comments,
7402 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7404 * xml.c (make_dom): Return comments, too.
7406 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7409 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7410 and the surrounding thread.
7411 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7412 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7413 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7415 * s/openbsd.h (BROKEN_SIGIO): Define.
7416 * unexelf.c (unexec) [__OpenBSD__]:
7417 Don't update the .mdebug section of the Alpha COFF symbol table.
7419 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7421 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7424 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7426 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7427 This fixes some race conditions on the permissions of any newly
7430 * alloc.c (valid_pointer_p): Use pipe, not open.
7431 This fixes some permissions issues when debugging.
7433 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7434 If fchown fails to set both uid and gid, try to set just gid,
7435 as that is sometimes allowed. Adjust the file's mode to eliminate
7436 setuid or setgid bits that are inappropriate if fchown fails.
7438 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7440 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7441 to compare Lisp_Objects.
7442 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7443 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7444 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7446 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7448 * lread.c (read_integer): Unread even EOF character.
7449 (read1): Likewise. Properly record start position of symbol.
7451 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7452 symbol character follows.
7454 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7456 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7457 This works around a problem with the previous change to Fcopy_file.
7458 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7459 and without this change, GCC might complain about discarding
7460 fchown's return value.
7462 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
7464 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7466 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7468 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7470 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7472 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7473 it's used from the C level.
7475 * process.c: Use the same condition for POLL_FOR_INPUT in both
7476 keyboard.c and process.c (bug#1858).
7478 2011-07-09 Lawrence Mitchell <wence@gmx.li>
7480 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7481 (Fgnutls_boot): Use it.
7483 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7485 * doc.c (Fsubstitute_command_keys): Revert last change.
7487 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7489 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7490 quotes the next character, and doesn't affect other longer
7491 sequences (bug#8935).
7493 * lread.c (syms_of_lread): Clarify that is isn't only
7494 `eval-buffer' and `eval-defun' that's affected by
7495 `lexical-binding' (bug#8460).
7497 2011-07-15 Eli Zaretskii <eliz@gnu.org>
7499 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
7500 bidi redisplay when a line includes both an image and is truncated.
7502 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7504 Fix minor problems found by static checking.
7505 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7506 (elsz): Now a signed constant, not a size_t var. We prefer signed
7507 types to unsigned, to avoid integer comparison confusion. Without
7508 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7509 "cannot optimize loop, the loop counter may overflow", a symptom
7511 * indent.c (Fvertical_motion): Mark locals as initialized.
7512 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7514 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7516 * search.c (Fre_search_backward): Mention `case-fold-search' in
7517 all the re_search_* functions (bug#8138).
7519 * keyboard.c (Fopen_dribble_file): Document when the file is
7522 2011-07-14 Eli Zaretskii <eliz@gnu.org>
7524 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7527 Support bidi reordering of display and overlay strings.
7528 * xdisp.c (compute_display_string_pos)
7529 (compute_display_string_end): Accept additional argument STRING.
7530 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7531 (reseat_to_string): Initialize bidi_it->string.s and
7532 bidi_it->string.schars.
7533 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
7534 NULL (avoids a crash in bidi_paragraph_init).
7535 Initialize itb.string.lstring.
7536 (init_iterator): Call bidi_init_it only of a valid
7537 buffer position was specified. Initialize paragraph_embedding to
7539 (reseat_to_string): Initialize the bidi iterator.
7540 (display_string): If we need to ignore text properties of
7541 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7542 original value of -1 will not work with bidi.)
7543 (compute_display_string_pos): First arg is now struct
7544 `text_pos *'; all callers changed. Support display properties on
7546 (compute_display_string_end): Support display properties on Lisp
7548 (init_iterator, reseat_1, reseat_to_string): Initialize the
7549 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7550 when iterating on a string not from display properties).
7551 (compute_display_string_pos, compute_display_string_end):
7552 Fix calculation of the object to scan. Fixes an error when using
7554 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
7555 base_level_stop; instead, set base_level_stop to BEGV.
7556 Fixes crashes in vertical-motion.
7557 (next_element_from_buffer): Improve commentary for when
7558 the iterator is before prev_stop.
7559 (init_iterator): Initialize bidi_p from the default value of
7560 bidi-display-reordering, not from buffer-local value. Use the
7561 buffer-local value only if initializing for buffer iteration.
7562 (handle_invisible_prop): Support invisible properties on strings
7563 that are being bidi-reordered.
7564 (set_iterator_to_next): Support bidi reordering of C strings and
7566 (next_element_from_string): Support bidi reordering of Lisp
7568 (handle_stop_backwards): Support Lisp strings as well.
7569 (display_string): Support display of R2L glyph rows.
7570 Use IT_STRING_CHARPOS when displaying from a Lisp string.
7571 (init_iterator): Don't initialize it->bidi_p for strings
7573 (reseat_to_string): Initialize it->bidi_p for strings here.
7574 (next_element_from_string, next_element_from_c_string)
7575 (next_element_from_buffer): Add xassert's for correspondence
7576 between IT's object being iterated and it->bidi_it.string
7578 (face_before_or_after_it_pos): Support bidi iteration.
7579 (next_element_from_c_string): Handle the case of the first string
7580 character that is not the first one in the visual order.
7581 (get_visually_first_element): New function, refactored from common
7582 parts of next_element_from_buffer, next_element_from_string, and
7583 next_element_from_c_string.
7584 (tool_bar_lines_needed, redisplay_tool_bar)
7585 (display_menu_bar): Force left-to-right direction. Add a FIXME
7586 comment for making that be controlled by a user option.
7587 (push_it, pop_it): Save and restore the state of the
7588 bidi iterator. Save and restore the bidi_p flag.
7589 (pop_it): Iterate out of display property for string iteration as
7591 (iterate_out_of_display_property): Support iteration over strings.
7592 (handle_single_display_spec): Set up it->bidi_it for iteration
7593 over a display string, and call bidi_init_it.
7594 (handle_single_display_spec, next_overlay_string)
7595 (get_overlay_strings_1, push_display_prop): Set up the bidi
7596 iterator for displaying display or overlay strings.
7597 (forward_to_next_line_start): Don't use the shortcut if
7599 (back_to_previous_visible_line_start): If handle_display_prop
7600 pushed the iterator stack, restore the internal state of the bidi
7601 iterator by calling bidi_pop_it same number of times.
7602 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7603 and we are bidi-iterating, don't decrement the iterator position;
7604 instead, set the first_elt flag in the bidi iterator, to produce
7606 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7607 (push_display_prop): xassert that we are iterating a buffer.
7608 (push_it, pop_it): Save and restore paragraph_embedding member.
7609 (handle_single_display_spec, next_overlay_string)
7610 (get_overlay_strings_1, reseat_1, reseat_to_string)
7611 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7612 correctly. Don't assume unibyte strings are not bidi-reordered.
7613 (compute_display_string_pos)
7614 (compute_display_string_end): Fix handling the case of C string.
7615 (push_it, pop_it): Save and restore from_disp_prop_p.
7616 (handle_single_display_spec, push_display_prop): Set the
7617 from_disp_prop_p flag.
7618 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7619 (pop_it): Call iterate_out_of_display_property only if we are
7620 popping after iteration over a string that came from a display
7621 property. Fix a typo in popping stretch info. Add an assertion
7622 for verifying that the iterator position is in sync with the bidi
7624 (handle_single_display_spec, get_overlay_strings_1)
7625 (push_display_prop): Fix initialization of paragraph direction for
7626 string when that of the parent object is not yet determined.
7627 (reseat_1): Call bidi_init_it to resync the bidi
7628 iterator with IT's position. (Bug#7616)
7629 (find_row_edges): If ROW->start.pos gives position
7630 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7631 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7632 Reset the from_disp_prop_p flag.
7633 (SAVE_IT, RESTORE_IT): New macros.
7634 (pos_visible_p, face_before_or_after_it_pos)
7635 (back_to_previous_visible_line_start)
7636 (move_it_in_display_line_to, move_it_in_display_line)
7637 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7638 (try_scrolling, redisplay_window, display_line): Use them when
7639 saving a temporary copy of the iterator and restoring it back.
7640 (back_to_previous_visible_line_start, reseat_1)
7641 (init_iterator): Empty the bidi cache "stack".
7642 (move_it_in_display_line_to): If iterator ended up at
7643 EOL, but we never saw any buffer positions smaller than
7644 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7645 motion in bidi-reordered lines.
7646 (move_it_in_display_line_to): Record prev_method and prev_pos
7647 immediately before the call to set_iterator_to_next. Fixes cursor
7648 motion in bidi-reordered lines with stretch glyphs and strings
7649 displayed in margins. (Bug#8133) (Bug#8867)
7650 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7652 (pos_visible_p): Support positions in bidi-reordered lines.
7653 Save and restore bidi cache.
7655 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7656 (bidi_paragraph_info): Delete unused struct.
7657 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7658 (bidi_cache_start): New variable.
7659 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7661 (bidi_cache_fetch_state, bidi_cache_search)
7662 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7663 (bidi_cache_find, bidi_peek_at_next_level)
7664 (bidi_level_of_next_char, bidi_find_other_level_edge)
7665 (bidi_move_to_visually_next): Compare cache index with
7666 bidi_cache_start rather than with zero.
7667 (bidi_fetch_char): Accept new argument STRING; all callers
7668 changed. Support iteration over a string. Support strings with
7669 display properties. Support unibyte strings. Fix the type of
7670 `len' according to what STRING_CHAR_AND_LENGTH expects.
7671 (bidi_paragraph_init, bidi_resolve_explicit_1)
7672 (bidi_resolve_explicit, bidi_resolve_weak)
7673 (bidi_level_of_next_char, bidi_move_to_visually_next):
7674 Support iteration over a string.
7675 (bidi_set_sor_type, bidi_resolve_explicit_1)
7676 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7677 can now be zero (for strings); special values 0 and -1 were
7678 changed to -1 and -2, respectively.
7679 (bidi_char_at_pos): New function.
7680 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7681 Call it instead of FETCH_MULTIBYTE_CHAR.
7682 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7683 initialized to valid values.
7684 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7686 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7687 the test for valid cached positions. Fix the logic for looking up
7688 the sentinel state in the cache. GCPRO the Lisp string we are
7690 (bidi_push_it, bidi_pop_it): New functions.
7691 (bidi_initialize): Initialize the bidi cache start stack pointer.
7692 (bidi_cache_ensure_space): New function, refactored from part of
7693 bidi_cache_iterator_state. Don't assume the required size is just
7694 one BIDI_CACHE_CHUNK away.
7695 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7696 (bidi_count_bytes, bidi_char_at_pos): New functions.
7697 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7698 always valid if bidi_cache_idx is valid.
7699 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7700 is valid if it's going to be used.
7701 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7702 (bidi_cache_fetch_state, bidi_cache_search)
7703 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7704 (bidi_cache_iterator_state, bidi_cache_find)
7705 (bidi_find_other_level_edge, bidi_cache_start_stack):
7706 All variables related to cache indices are now EMACS_INT.
7708 * dispextern.h (struct bidi_string_data): New structure.
7709 (struct bidi_it): New member `string'. Make flag members be 1-bit
7710 fields, and put them last in the struct.
7711 (compute_display_string_pos, compute_display_string_end):
7713 (bidi_push_it, bidi_pop_it): Add prototypes.
7714 (struct iterator_stack_entry): New members bidi_p,
7715 paragraph_embedding, and from_disp_prop_p.
7716 (struct it): Member bidi_p is now a bit field 1 bit wide.
7717 (bidi_shelve_cache, bidi_unshelve_cache):
7720 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7721 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7722 and vector-like objects.
7724 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7725 cache around display iteration.
7727 * window.c (Fwindow_end, window_scroll_pixel_based)
7728 (displayed_window_lines, Frecenter): Save and restore the bidi
7729 cache around display iteration.
7731 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7733 * editfns.c (Fdelete_region): Clarify the use of the named
7734 parameters (bug#6788).
7736 2011-07-14 Martin Rudalics <rudalics@gmx.at>
7738 * indent.c (Fvertical_motion): Set and restore w->pointm when
7739 saving and restoring the window's buffer (Bug#9006).
7741 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7743 * editfns.c (Fstring_to_char): Clarify just what is returned
7744 (bug#6576). Text by Eli Zaretskii.
7746 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
7748 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7750 2011-07-13 Eli Zaretskii <eliz@gnu.org>
7752 * buffer.c (mmap_find): Fix a typo.
7754 2011-07-13 Johan Bockgård <bojohan@gnu.org>
7756 Fix execution of x selection hooks.
7757 * xselect.c (Qx_lost_selection_functions)
7758 (Qx_sent_selection_functions): New vars.
7759 (syms_of_xselect): DEFSYM them.
7760 (x_handle_selection_request): Pass Qx_sent_selection_functions
7761 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7762 (x_handle_selection_clear,x_clear_frame_selections):
7763 Pass Qx_lost_selection_functions rather than
7764 Vx_lost_selection_functions to Frun_hook_with_args.
7766 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7768 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
7769 The old code sometimes used this field without initializing it.
7771 * alloc.c (gc_sweep): Don't read past end of array.
7772 In theory, the old code could also have corrupted Emacs internals,
7773 though it'd be very unlikely.
7775 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7777 * character.c (Fcharacterp): Don't advertise optional ignored
7778 argument. (Bug#4026)
7780 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7782 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7785 * window.c (Fset_window_start): Doc fix (bug#4199).
7786 (Fset_window_hscroll): Ditto.
7788 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7790 Fix minor new problems caught by GCC 4.6.1.
7791 * term.c (init_tty): Remove unused local.
7792 * xsettings.c (store_monospaced_changed): Define this function only
7793 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
7796 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
7798 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7800 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7802 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7803 are the mini-buffer and the echo area (bug#3320).
7805 * term.c (init_tty): Remove support for supdup, c10 and perq
7806 terminals, which are no longer supported (bug#1482).
7808 2011-07-10 Johan Bockgård <bojohan@gnu.org>
7810 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7812 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7814 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7815 for non-popups (Bug#3642).
7817 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7819 * alloc.c (reset_malloc_hooks): Protoize.
7820 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
7821 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7822 * cm.c (losecursor): Likewise.
7823 * data.c (fmod): Likewise.
7824 * dispnew.c (swap_glyphs_in_rows): Likewise.
7825 * emacs.c (memory_warning_signal): Likewise.
7826 * floatfns.c (float_error): Likewise.
7827 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7828 (otf_open, font_otf_capability, generate_otf_features)
7829 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7831 * image.c (pbm_read_file): Likewise.
7832 * indent.c (string_display_width): Likewise.
7833 * intervals.c (check_for_interval, search_for_interval)
7834 (inc_interval_count, count_intervals, root_interval)
7835 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7836 * lread.c (defalias): Likewise.
7837 * ralloc.c (r_alloc_check): Likewise.
7838 * regex.c (set_image_of_range_1, set_image_of_range)
7839 (regex_grow_registers): Likewise.
7840 * sysdep.c (strerror): Likewise.
7841 * termcap.c (valid_filename_p, tprint, main): Likewise.
7842 * tparam.c (main): Likewise.
7843 * unexhp9k800.c (run_time_remap, save_data_space)
7844 (update_file_ptrs, read_header, write_header, calculate_checksum)
7845 (copy_file, copy_rest, display_header): Likewise.
7846 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7848 * xdisp.c (check_it): Likewise.
7849 * xfaces.c (register_color, unregister_color, unregister_colors):
7851 * xfns.c (print_fontset_result): Likewise.
7852 * xrdb.c (member, fatal, main): Likewise.
7854 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7856 Fix minor problems found by static checking (Bug#9031).
7857 * chartab.c (char_table_set_range, map_sub_char_table):
7858 Remove unused locals.
7859 (uniprop_table): Now static.
7860 * composite.c (_work_char): Remove unused static var.
7862 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
7864 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7866 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7868 * gtkutil.c (qttip_cb): Remove code without function.
7870 2011-07-09 Eli Zaretskii <eliz@gnu.org>
7872 * w32.c (pthread_sigmask): New stub.
7874 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
7876 Use pthread_sigmask, not sigprocmask (Bug#9010).
7877 sigprocmask is portable only for single-threaded applications, and
7878 Emacs can be multi-threaded when it uses GTK.
7879 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7881 * callproc.c (Fcall_process):
7882 * process.c (create_process):
7883 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7884 Use pthread_sigmask, not sigprocmask.
7886 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7888 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7889 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7892 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7894 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7895 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7896 (xg_hide_tooltip): Fix comment.
7898 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7899 in registerServicesMenuSendTypes.
7900 (validRequestorForSendType): Don't check ns_return_types.
7902 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7905 2011-07-08 Jason Rumney <jasonr@gnu.org>
7907 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7908 SH_SHOW for hidden windows (Bug#5482).
7910 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7911 frame struct members of non-existent frames (Bug#6284).
7913 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7915 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7916 variable firstTime not needed on OSX >= 10.6.
7917 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7918 >= 10.5. Use setKnobProportion, setDoubleValue.
7920 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7921 (MAC_OS_X_VERSION_10_5): Define if not defined.
7922 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7923 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7924 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7926 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7927 cString and lossyCString on OSX >= 10.4.
7929 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
7930 sizeToFit on OSX >= 10.2.
7932 * nsimage.m (allocInitFromFile): Don't use deprecated method
7933 bestRepresentationForDevice on OSX >= 10.6.
7935 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7938 * emacs.c: Declare unexec_init_emacs_zone.
7940 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7942 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7944 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7945 on svcsMenu (Bug#8842).
7947 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7949 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7951 * nsterm.m (QUTF8_STRING): Declare.
7952 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7953 (validRequestorForSendType): Return type is (id).
7954 Change indexOfObjectIdenticalTo to indexOfObject.
7955 Check if we have local selection before returning self (Bug#8842).
7956 (writeSelectionToPasteboard): Put local selection into paste board
7957 if we have a local selection (Bug#8842).
7958 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7960 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7961 (ns_get_local_selection): Declare.
7963 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7965 * keymap.c (describe_map_tree): Don't insert a double newline at
7966 the end of the buffer (bug#1169) and return whether we inserted
7969 * callint.c (Fcall_interactively): Change "reading args" to
7970 "providing args" to try to clarify what it does (bug#1010).
7972 2011-07-07 Kenichi Handa <handa@m17n.org>
7974 * composite.c (composition_compute_stop_pos): Ignore a static
7975 composition starting before CHARPOS (Bug#8915).
7977 * xdisp.c (handle_composition_prop): Likewise.
7979 2011-07-07 Eli Zaretskii <eliz@gnu.org>
7981 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7984 2011-07-07 Kenichi Handa <handa@m17n.org>
7986 * character.h (unicode_category_t): New enum type.
7988 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7989 (Qchar_code_property_table): New variable.
7990 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7991 (UNIPROP_COMPRESSED_FORM_P): New macros.
7992 (char_table_ascii): Uncompress the compressed values.
7993 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7994 Uncompress the compressed values.
7995 (sub_char_table_ref_and_range): Likewise.
7996 (char_table_ref_and_range): Uncompress the compressed values.
7997 (sub_char_table_set): New arg is_uniprop. Callers changed.
7998 Uncompress the compressed values.
7999 (sub_char_table_set_range): Args changed. Callers changed.
8000 (char_table_set_range): Adjuted for the above change.
8001 (map_sub_char_table): Delete args default_val and parent. Add arg
8002 top. Give decoded values to a Lisp function.
8003 (map_char_table): Adjust for the above change. Give decoded
8004 values to a Lisp function. Gcpro more variables.
8005 (uniprop_table_uncompress)
8006 (uniprop_decode_value_run_length): New functions.
8007 (uniprop_decoder, uniprop_decoder_count): New variables.
8008 (uniprop_get_decoder, uniprop_encode_value_character)
8009 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8011 (uniprop_encoder, uniprop_encoder_count): New variables.
8012 (uniprop_get_encoder, uniprop_table)
8013 (Funicode_property_table_internal, Fget_unicode_property_internal)
8014 (Fput_unicode_property_internal): New functions.
8015 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8016 Sunicode_property_table_internal, Sget_unicode_property_internal,
8017 and Sput_unicode_property_internal. Defvar_lisp
8018 char-code-property-alist.
8020 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
8021 Vunicode_category_table.
8023 * font.c (font_range): Adjust for the change of
8024 Vunicode_category_table.
8026 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8028 * m/iris4d.h: Remove file, move contents ...
8029 * s/irix6-5.h: ... here.
8031 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8033 Remove unportable assumption about struct layout (Bug#8884).
8034 * alloc.c (mark_buffer):
8035 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8036 (clone_per_buffer_values): Don't assume that
8037 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8038 This isn't true in general, and it's particularly not true
8039 if Emacs is configured with --with-wide-int.
8040 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8041 New macros, used in the buffer.c change.
8043 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8045 * xsettings.c: Use both GConf and GSettings if both are available.
8046 (store_config_changed_event): Add comment.
8047 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8048 (store_tool_bar_style_changed): New functions.
8049 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
8050 (struct xsettings): Move font inside HAVE_XFT.
8051 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
8052 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
8053 Move inside HAVE_XFT.
8054 (something_changed_gsettingsCB): Rename from something_changedCB.
8055 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8057 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
8058 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
8059 (something_changed_gconfCB): Rename from something_changedCB.
8060 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8061 (parse_settings): Move check for font inside HAVE_XFT.
8062 (read_settings, apply_xft_settings): Add comment.
8063 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8064 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8065 call store_font_name_changed.
8066 (xft_settings_event): Add comment.
8067 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8068 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8069 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8070 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8071 (xsettings_initialize): Call init_gsettings last.
8072 (xsettings_get_system_font, xsettings_get_system_normal_font):
8075 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8077 Random fixes. E.g., (random) never returned negative values.
8078 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8079 subseconds part to the entropy, as that's a bit more random.
8080 Prefer signed to unsigned, since the signedness doesn't matter and
8081 in general we prefer signed. When given a limit, use a
8082 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8083 latter isn't right if USE_2_TAGS_FOR_INTS.
8084 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8085 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8087 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8089 * textprop.c (text_property_stickiness):
8090 Obey Vtext_property_default_nonsticky.
8091 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8092 * w32fns.c (syms_of_w32fns):
8093 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8095 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8097 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8098 This is more efficient than Ffile_directory_p and avoids a minor race.
8100 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8102 * buffer.c (Foverlay_put): Say what the return value is
8105 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8106 is a directory before asking whether to use the file name
8108 (barf_or_query_if_file_exists): Make the "File is a directory"
8109 error be more correct.
8111 * fns.c (Frequire): Remove the mention of the .gz files, since
8112 that's installation-specific, but keep the mention of
8113 `get-load-suffixes'.
8115 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8117 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8118 Report string overflow if the output is too long.
8120 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
8122 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8123 (syms_of_gnutls): Remove duplicate DEFSYM for
8124 Qgnutls_bootprop_verify_hostname_error, an error for
8125 Qgnutls_bootprop_verify_error (which is no longer used).
8127 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8128 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8129 Also (re)move comments that are misplaced or no longer relevant.
8131 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8133 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8135 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
8137 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8138 and background color parameters if they have been changed.
8140 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8142 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8144 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8146 * xsettings.c (SYSTEM_FONT): Define only when used.
8147 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8149 * keymap.c (access_keymap_1): Now static.
8151 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
8153 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8154 leave any prefix arg for the up event (Bug#1586).
8156 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8158 * lread.c (syms_of_lread): Mention single symbols defined by
8159 `defvar' or `defconst' (bug#7154).
8161 * fns.c (Frequire): Mention .el.gz files (bug#7314).
8162 (Frequire): Mention get-load-suffixes.
8164 2011-07-02 Martin Rudalics <rudalics@gmx.at>
8166 * window.h (window): Remove clone_number slot.
8167 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8169 (make_parent_window, make_window, saved_window)
8170 (Fset_window_configuration, save_window_save): Don't deal with
8172 * buffer.c (Qclone_number): Remove declaration.
8173 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8175 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8177 Add multiple inheritance to keymaps.
8178 * keymap.c (Fmake_composed_keymap): New function.
8179 (Fset_keymap_parent): Simplify.
8180 (fix_submap_inheritance): Remove.
8181 (access_keymap_1): New function extracted from access_keymap to handle
8182 embedded parents and handle lists of maps.
8183 (access_keymap): Use it.
8184 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8185 (Fcopy_keymap): Handle embedded parents.
8186 (Fcommand_remapping, define_as_prefix): Simplify.
8187 (Fkey_binding): Simplify.
8188 (syms_of_keymap): Move minibuffer-local-completion-map,
8189 minibuffer-local-filename-completion-map,
8190 minibuffer-local-must-match-map, and
8191 minibuffer-local-filename-must-match-map to Elisp.
8192 (syms_of_keymap): Defsubr make-composed-keymap.
8193 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8194 (parse_menu_item): Trivial simplification.
8196 2011-07-01 Glenn Morris <rgm@gnu.org>
8198 * Makefile.in (SETTINGS_LIBS): Fix typo.
8200 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8202 * coding.c (Fencode_coding_string): Record the last coding system
8203 used, as the function doc string says (bug#8738).
8205 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8207 * xsettings.c (store_monospaced_changed): Take new font as arg and
8208 check for change against current_mono_font.
8209 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8210 (emacs_settings_constructor, emacs_settings_get_property)
8211 (emacs_settings_set_property, emacs_settings_class_init)
8212 (emacs_settings_init, gsettings_obj): Remove.
8213 (something_changedCB): New function for HAVE_GSETTINGS.
8214 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8215 with value as argument.
8216 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8217 g_settings_new (Bug#8967). Do not create gsettings_obj.
8218 Remove calls to g_settings_bind. Connect something_changedCB to
8221 * xgselect.c: Add defined (HAVE_GSETTINGS).
8222 (xgselect_initialize): Ditto.
8224 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8225 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8228 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8230 * eval.c (struct backtrace): Simplify and port the data structure.
8231 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8232 signed bit field, as this assumption is not portable and it makes
8233 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8234 "char debug_on_exit : 1" as this is not portable either; instead,
8235 use the portable "unsigned int debug_on_exit : 1". Remove unused
8236 member evalargs. Remove obsolete comments about cc bombing out.
8238 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8240 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
8241 Let HAVE_GSETTINGS override HAVE_GCONF.
8242 (store_monospaced_changed): New function.
8243 (EMACS_SETTINGS): A new type derived from GObject to handle
8244 GSettings notifications.
8245 (emacs_settings_constructor, emacs_settings_get_property)
8246 (emacs_settings_set_property, emacs_settings_class_init):
8248 (gsettings_client, gsettings_obj): New variables.
8249 (GSETTINGS_SCHEMA): New define.
8250 (something_changedCB): Call store_monospaced_changed.
8251 (init_gsettings): New function.
8252 (xsettings_initialize): Call init_gsettings.
8253 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8256 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
8259 2011-06-29 Martin Rudalics <rudalics@gmx.at>
8261 * window.c (resize_root_window, grow_mini_window)
8262 (shrink_mini_window): Rename Qresize_root_window to
8263 Qwindow_resize_root_window and Qresize_root_window_vertically to
8264 Qwindow_resize_root_window_vertically.
8266 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8268 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8270 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
8272 * makefile.w32-in: Redesign dependencies so they reflect more
8273 clearly which files are directly included by each source file,
8274 and not through other includes.
8276 2011-06-27 Martin Rudalics <rudalics@gmx.at>
8278 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8279 (sort_overlays, overlay_strings): When an overlay's clone number
8280 matches the window's clone number process the overlay even if
8281 the overlay's window property doesn't match the current window.
8283 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8284 (Fwindow_hchild): Rename to Fwindow_left_child.
8285 (Fwindow_next): Rename to Fwindow_next_sibling.
8286 (Fwindow_prev): Rename to Fwindow_prev_sibling.
8287 (resize_window_check): Rename to window_resize_check.
8288 (resize_window_apply): Rename to window_resize_apply.
8289 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8290 (Fdelete_other_windows_internal, resize_frame_windows)
8291 (Fsplit_window_internal, Fdelete_window_internal)
8292 (grow_mini_window, shrink_mini_window)
8293 (Fresize_mini_window_internal): Fix callers accordingly.
8295 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8297 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8298 (emacs_fixed_set_min_size): Remove.
8299 (emacs_fixed_new): Take frame as argument.
8301 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8302 (_EmacsFixedPrivate): Remove minwidth/height.
8303 Add struct frame *f.
8304 (emacs_fixed_init): Initialize priv->f.
8305 (get_parent_class, emacs_fixed_set_min_size): Remove.
8306 (emacs_fixed_new): Set priv->f to argument.
8307 (emacs_fixed_get_preferred_width)
8308 (emacs_fixed_get_preferred_height): Use min_width/height from
8309 frames size_hint to set minimum and natural (Bug#8919).
8310 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8311 and use min_width/height from frames size_hint to set
8312 min_width/height (Bug#8919).
8314 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
8315 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8318 2011-06-26 Eli Zaretskii <eliz@gnu.org>
8320 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8321 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8324 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
8326 * process.c (wait_reading_process_output): Bypass select if
8327 waiting for a cell while ignoring keyboard input, and input is
8328 pending. Suggested by Jan Djärv (Bug#8869).
8330 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8332 Use gnulib's dup2 module instead of rolling our own.
8333 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8335 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8337 * dispnew.c (scrolling_window): Before scrolling, turn off a
8338 mouse-highlight in the window being scrolled.
8340 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
8342 Move DEFSYM to lisp.h and use everywhere.
8344 * character.h (DEFSYM): Move declaration...
8345 * lisp.h (DEFSYM): ...here.
8351 * w32select.c: Don't include character.h.
8353 * alloc.c (syms_of_alloc):
8354 * buffer.c (syms_of_buffer):
8355 * bytecode.c (syms_of_bytecode):
8356 * callint.c (syms_of_callint):
8357 * casefiddle.c (syms_of_casefiddle):
8358 * casetab.c (init_casetab_once):
8359 * category.c (init_category_once, syms_of_category):
8360 * ccl.c (syms_of_ccl):
8361 * cmds.c (syms_of_cmds):
8362 * composite.c (syms_of_composite):
8363 * dbusbind.c (syms_of_dbusbind):
8364 * dired.c (syms_of_dired):
8365 * dispnew.c (syms_of_display):
8366 * doc.c (syms_of_doc):
8367 * editfns.c (syms_of_editfns):
8368 * emacs.c (syms_of_emacs):
8369 * eval.c (syms_of_eval):
8370 * fileio.c (syms_of_fileio):
8371 * fns.c (syms_of_fns):
8372 * frame.c (syms_of_frame):
8373 * fringe.c (syms_of_fringe):
8374 * insdel.c (syms_of_insdel):
8375 * keymap.c (syms_of_keymap):
8376 * lread.c (init_obarray, syms_of_lread):
8377 * macros.c (syms_of_macros):
8378 * msdos.c (syms_of_msdos):
8379 * print.c (syms_of_print):
8380 * process.c (syms_of_process):
8381 * search.c (syms_of_search):
8382 * sound.c (syms_of_sound):
8383 * syntax.c (init_syntax_once, syms_of_syntax):
8384 * terminal.c (syms_of_terminal):
8385 * textprop.c (syms_of_textprop):
8386 * undo.c (syms_of_undo):
8387 * w32.c (globals_of_w32):
8388 * window.c (syms_of_window):
8389 * xdisp.c (syms_of_xdisp):
8390 * xfaces.c (syms_of_xfaces):
8391 * xfns.c (syms_of_xfns):
8392 * xmenu.c (syms_of_xmenu):
8393 * xsettings.c (syms_of_xsettings):
8394 * xterm.c (syms_of_xterm): Use DEFSYM.
8396 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8398 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
8400 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8402 Integer and buffer overflow fixes (Bug#8873).
8404 * print.c (printchar, strout): Check for string overflow.
8405 (PRINTPREPARE, printchar, strout):
8406 Don't set size unless allocation succeeds.
8408 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8409 for sizes. Check for string overflow more accurately.
8410 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8412 * macros.c: Integer and buffer overflow fixes.
8413 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8414 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8415 Use ptrdiff_t, not int, for sizes.
8416 Don't increment bufsize until after realloc succeeds.
8417 Check for size-calculation overflow.
8418 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8420 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8422 * lread.c: Integer overflow fixes.
8423 (read_integer): Radix is now EMACS_INT, not int,
8424 to improve quality of diagnostics for out-of-range radices.
8425 Calculate buffer size correctly for out-of-range radices.
8426 (read1): Check for integer overflow in radices, and in
8427 read-circle numbers.
8428 (read_escape): Avoid int overflow.
8429 (Fload, openp, read_buffer_size, read1)
8430 (substitute_object_recurse, read_vector, read_list, map_obarray):
8431 Use ptrdiff_t, not int, for sizes.
8432 (read1): Use EMACS_INT, not int, for sizes.
8433 Check for size overflow.
8435 * image.c (cache_image): Check for size arithmetic overflow.
8437 * lread.c: Integer overflow issues.
8438 (saved_doc_string_size, saved_doc_string_length)
8439 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8440 Now ptrdiff_t, not int.
8441 (read1): Don't assume doc string length fits in int. Check for
8442 out-of-range doc string lengths.
8443 (read_list): Don't assume file position fits in int.
8444 (read_escape): Check for hex character overflow.
8446 2011-06-22 Leo Liu <sdl.web@gmail.com>
8448 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8449 Move to minibuffer.el.
8451 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8453 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
8454 The following patches are for when GLYPH_DEBUG && !XASSERT.
8455 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8456 * dispnew.c (flush_stdout):
8457 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8458 Mark as externally visible.
8459 * dispnew.c (check_window_matrix_pointers): Now static.
8460 * dispnew.c (window_to_frame_vpos):
8461 * xfns.c (unwind_create_frame):
8462 * xterm.c (x_check_font): Remove unused local.
8463 * scroll.c (CHECK_BOUNDS):
8464 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8465 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8466 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8467 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8468 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8470 (debug_method_add): Use va_list and vsprintf rather than relying
8471 on undefined behavior with wrong number of arguments.
8472 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8473 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8474 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8475 since we're not interested in debugging glyphs with old libraries.
8476 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8477 GCC 4.6.0's static checking.
8479 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8481 Integer overflow and signedness fixes (Bug#8873).
8482 A few related buffer overrun fixes, too.
8484 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8486 * dispextern.h (struct face.stipple):
8487 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8488 (x_bitmap_mask, x_allocate_bitmap_record)
8489 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8490 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8491 (x_create_bitmap_from_xpm_data):
8492 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8493 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8495 * xfaces.c (load_pixmap):
8496 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8497 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8498 (.bitmaps_last, struct x_output.icon_bitmap):
8499 Use ptrdiff_t, not int, for bitmap indexes.
8500 (x_allocate_bitmap_record): Check for size overflow.
8501 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8503 Use ptrdiff_t, not int, for overlay counts.
8504 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8505 * editfns.c (overlays_around, get_pos_property):
8506 * textprop.c (get_char_property_and_overlay):
8507 * xdisp.c (next_overlay_change, note_mouse_highlight):
8508 * xfaces.c (face_at_buffer_position):
8509 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8510 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8511 (Fnext_overlay_change, Fprevious_overlay_change)
8512 (mouse_face_overlay_overlaps, Foverlays_in):
8513 Use ptrdiff_t, not int, for sizes.
8514 (overlays_at, overlays_in): Check for size-calculation overflow.
8516 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8518 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8519 (x_session_initialize): Do not assume string length fits in int.
8521 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8522 This is unlikely, but can occur if DPI is outlandish.
8524 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
8525 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8527 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8528 * xrdb.c (magic_file_p, search_magic_path):
8529 Omit last arg SUFFIX; it was always 0. All callers changed.
8530 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8532 * xfont.c (xfont_match): Avoid need for strlen.
8534 * xfns.c: Don't assume strlen fits in int.
8535 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8537 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8538 not unsigned long, as we prefer signed integers. All callers changed.
8539 Detect integer overflow in repeat count.
8540 (message_dolog): Don't assume print length fits in 39 bytes.
8541 (display_mode_element): Don't assume strlen fits in int.
8543 * termcap.c: Don't assume sizes fit in int and never overflow.
8544 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8545 (gobble_line): Check for size-calculation overflow.
8547 * minibuf.c (Fread_buffer):
8548 * lread.c (intern, intern_c_string):
8549 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8550 Don't assume string length fits in int.
8552 * keyboard.c (parse_tool_bar_item):
8553 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8555 * font.c: Don't assume string length fits in int.
8556 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8557 Use ptrdiff_t, not int.
8558 (font_intern_prop): Don't assume string length fits in int.
8559 Don't assume integer property fits in fixnum.
8560 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
8562 * filelock.c: Fix some buffer overrun and integer overflow issues.
8563 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
8564 Reformulate so as not to need the command string.
8565 Invoke gzip -cd rather than gunzip, as it's more portable.
8566 (lock_info_type, lock_file_1, lock_file):
8567 Don't assume pid_t and time_t fit in unsigned long.
8568 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8569 (current_lock_owner): Prefer signed type for sizes.
8570 Use memcpy, not strncpy, where memcpy is what is really wanted.
8571 Don't assume (via atoi) that time_t and pid_t fit in int.
8572 Check for time_t and/or pid_t out of range, e.g., via a network share.
8573 Don't alloca where an auto var works fine.
8575 * fileio.c: Fix some integer overflow issues.
8576 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8577 Don't assume string length fits in int.
8578 (directory_file_name): Don't assume string length fits in long.
8579 (make_temp_name): Don't assume pid fits in int, or that its print
8580 length is less than 20.
8582 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8584 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8586 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8588 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8589 We prefer signed integers, even for size calculations.
8591 * emacs.c: Don't assume string length fits in 'int'.
8592 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8593 (main): Don't invoke strlen when not needed.
8595 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8596 (XD_DEBUG_MESSAGE): Don't waste a byte.
8598 * callproc.c (getenv_internal_1, getenv_internal)
8600 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8602 * lread.c (invalid_syntax): Omit length argument.
8603 All uses changed. This doesn't fix a bug, but it simplifies the
8604 code away from its former Hollerith-constant appearance, and it's
8605 one less 'int' to worry about when looking at integer-overflow issues.
8606 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
8608 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8609 This didn't break anything, but it didn't help either.
8610 It's confusing to put a bogus integer in a place where the actual
8611 value does not matter.
8612 (LIST_END_P): Remove unused macro and its bogus comment.
8613 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
8615 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8616 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8618 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8619 We prefer signed types, and the value cannot exceed the EMACS_INT
8620 range anyway (because otherwise the length would not be representable).
8621 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8622 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8623 This avoids a GCC warning when WIDE_EMACS_INT.
8625 * indent.c (sane_tab_width): New function.
8626 (current_column, scan_for_column, Findent_to, position_indentation)
8627 (compute_motion): Use it. This is just for clarity.
8628 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
8630 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
8632 * lisp.h (lint_assume): New macro.
8633 * composite.c (composition_gstring_put_cache):
8634 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8636 * editfns.c, insdel.c:
8637 Omit unnecessary forward decls, to simplify future changes.
8639 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8641 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8643 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
8644 Use much-faster test for byte-length change.
8645 Don't assume string byte-length fits in 'int'.
8646 Check that character arg fits in 'int'.
8647 (mapcar1): Declare byte as byte, for clarity.
8649 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8651 * fns.c (concat): Catch string overflow earlier.
8652 Do not rely on integer wraparound.
8654 * dispextern.h (struct it.overlay_strings_charpos)
8655 (struct it.selective): Now EMACS_INT, not int.
8656 * xdisp.c (forward_to_next_line_start)
8657 (back_to_previous_visible_line_start)
8658 (reseat_at_next_visible_line_start, next_element_from_buffer):
8659 Don't arbitrarily truncate the value of 'selective' to int.
8661 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8663 * composite.c: Don't truncate sizes to 'int'.
8664 (composition_gstring_p, composition_reseat_it)
8665 (composition_adjust_point): Use EMACS_INT, not int.
8666 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8667 not EMACS_UINT, for indexes.
8669 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8671 * buffer.c: Include <verify.h>.
8672 (struct sortvec.priority, struct sortstr.priority):
8673 Now EMACS_INT, not int.
8674 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
8675 (struct sortstr.size, record_overlay_string)
8676 (struct sortstrlist.size, struct sortlist.used):
8677 Don't truncate size to int.
8678 (record_overlay_string): Check for size-calculation overflow.
8679 (init_buffer_once): Check at compile-time, not run-time.
8681 2011-06-22 Jim Meyering <meyering@redhat.com>
8683 Don't leak an XBM-image-sized buffer
8684 * image.c (xbm_load): Free the image buffer after using it.
8686 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8689 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8690 that Sun C diagnosed.
8691 * fns.c (secure_hash): Fix pointer signedness issue.
8692 * intervals.c (static_offset_intervals): New function.
8693 (offset_intervals): Use it.
8695 2011-06-21 Leo Liu <sdl.web@gmail.com>
8698 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8701 * fns.c (secure_hash): Rename from crypto_hash_function and change
8702 the first arg to accept symbols.
8703 (Fsecure_hash): New primitive.
8704 (syms_of_fns): New symbols.
8706 2011-06-20 Deniz Dogan <deniz@dogan.se>
8708 * process.c (Fset_process_buffer): Clarify return value in
8711 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
8713 * dispnew.c (add_window_display_history): Use BVAR.
8715 * xdisp.c (debug_method_add): Use BVAR.
8716 (check_window_end, dump_glyph_matrix, dump_glyph)
8717 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8719 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8722 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8723 check till after the cache is created in init_frame_faces.
8725 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8727 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8729 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8731 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8732 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8733 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8735 Improve buffer-overflow checking (Bug#8873).
8736 * fileio.c (Finsert_file_contents):
8737 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8738 Remove the old (too-loose) buffer overflow checks.
8739 They weren't needed, since make_gap checks for buffer overflow.
8740 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8741 The old code merely checked for Emacs fixnum overflow, and relied
8742 on undefined (wraparound) behavior. The new code avoids undefined
8743 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8745 * editfns.c (Finsert_char): Don't dump core with very negative counts.
8746 Tune. Don't use wider integers than needed. Don't use alloca.
8747 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
8749 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8751 * insdel.c, lisp.h (buffer_overflow): New function.
8752 (insert_from_buffer_1, replace_range, replace_range_2):
8753 * insdel.c (make_gap_larger):
8754 * editfns.c (Finsert_char):
8755 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8757 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8759 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8761 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
8763 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8764 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8766 * fileio.c: Don't assume EMACS_INT fits in off_t.
8767 (emacs_lseek): New static function.
8768 (Finsert_file_contents, Fwrite_region): Use it.
8769 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8771 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8773 * fns.c: Don't overflow int when computing a list length.
8774 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8775 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8776 truncation on 64-bit hosts. Check for QUIT every
8777 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8778 faster and is responsive enough.
8779 (Flength): Report an error instead of overflowing an integer.
8780 (Fsafe_length): Return a float if the value is not representable
8781 as a fixnum. This shouldn't happen except in contrived situations.
8782 (Fnthcdr, Fsort): Don't assume list length fits in int.
8783 (Fcopy_sequence): Don't assume vector length fits in int.
8785 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8786 (header_size, word_size): New constants.
8787 (allocate_vectorlike): Don't check size overflow here.
8788 (allocate_vector): Check it here instead, since this is the only
8789 caller of allocate_vectorlike that could cause overflow.
8790 Check that the new vector's length is representable as a fixnum.
8792 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8793 The previous code was bogus. For example, next_almost_prime (32)
8794 returned 39, which is undesirable as it is a multiple of 3; and
8795 next_almost_prime (24) returned 25, which is a multiple of 5 so
8796 why was the code bothering to check for multiples of 7?
8798 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8800 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8802 Variadic C functions now count arguments with ptrdiff_t.
8803 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8804 Back then I didn't know that the Emacs coding style prefers signed int.
8805 Also, in the meantime I found a few more instances where arguments
8806 were being counted with int, which may truncate counts on 64-bit
8807 machines, or EMACS_INT, which may be unnecessarily wide.
8808 * lisp.h (struct Lisp_Subr.function.aMANY)
8809 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8810 Arg counts are now ptrdiff_t, not size_t.
8811 All variadic functions and their callers changed accordingly.
8812 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8813 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8814 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8815 * callint.c (Fcall_interactively): Check arg count for overflow,
8816 to avoid potential buffer overrun. Use signed char, not 'int',
8817 for 'varies' array, so that we needn't bother to check its size
8818 calculation for overflow.
8819 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8820 * eval.c (apply_lambda):
8821 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8822 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8823 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8825 * callint.c (Fcall_interactively): Don't use index var as event count.
8827 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8828 * mem-limits.h (SIZE): Remove; no longer used.
8830 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
8832 Remove unnecessary casts.
8833 * xterm.c (x_term_init):
8834 * xfns.c (x_set_border_pixel):
8835 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8836 These aren't needed now that we assume ANSI C.
8838 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8839 It's more likely to cause problems (due to unsigned overflow)
8842 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8844 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8846 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8848 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8850 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8852 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8854 GLYPH_CODE_FACE returns EMACS_INT, not int.
8855 * dispextern.h (merge_faces):
8856 * xfaces.c (merge_faces):
8857 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8858 Don't assume EMACS_INT fits in int.
8860 * character.h (CHAR_VALID_P): Remove unused parameter.
8861 * fontset.c, lisp.h, xdisp.c: All uses changed.
8863 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8865 * fns.c (concat): Minor tuning based on overflow analysis.
8866 This doesn't fix any bugs. Use int to hold character, instead
8867 of constantly refetching from Emacs object. Use XFASTINT, not
8868 XINT, for value known to be a character. Don't bother comparing
8869 a single byte to 0400, as it's always less.
8871 * floatfns.c (Fexpt):
8872 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8874 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8877 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8879 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8880 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8881 incorrectly succeed when S was a string, because 4294967386 was
8882 truncated before it was used.
8884 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8885 Otherwise, an out-of-range integer could cause undefined behavior
8888 * composite.c: Use int, not EMACS_INT, for characters.
8889 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8890 EMACS_INT, for values that are known to be in character range.
8891 This doesn't fix any bugs but is the usual style inside Emacs and
8892 may generate better code on 32-bit machines.
8894 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8895 This is for reasons similar to the recent CHAR_STRING fix.
8896 * charset.c (Fencode_char): Check that character arg is actually
8897 a character. Pass an int to ENCODE_CHAR.
8898 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8899 wider than 'int', as a compile-time check to prevent future regressions
8902 * character.c (char_string): Remove unnecessary casts.
8904 Make sure a 64-bit char is never passed to CHAR_STRING.
8905 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8906 by silently ignoring the top 32 bits, allowing some values
8907 that were far too large to be valid characters.
8908 * character.h: Include <verify.h>.
8909 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8910 arguments are no wider than unsigned, as a compile-time check
8911 to prevent future regressions in this area.
8913 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
8914 (Fsubst_char_in_region):
8916 * xdisp.c (decode_mode_spec_coding):
8917 Adjust to CHAR_STRING's new requirement.
8918 * editfns.c (Finsert_char, Fsubst_char_in_region):
8919 * fns.c (concat): Check that character args are actually
8920 characters. Without this test, these functions did the wrong
8921 thing with wildly out-of-range values on 64-bit hosts.
8923 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8924 These casts should not be needed on 32-bit hosts, either.
8925 * keyboard.c (read_char):
8926 * lread.c (Fload): Remove casts to unsigned.
8928 * lisp.h (UNSIGNED_CMP): New macro.
8929 This fixes comparison bugs on 64-bit hosts.
8930 (ASCII_CHAR_P): Use it.
8931 * casefiddle.c (casify_object):
8932 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
8933 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8934 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8935 * dispextern.h (FACE_FROM_ID):
8936 * keyboard.c (read_char): Use UNSIGNED_CMP.
8938 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8939 not to EMACS_INT, to avoid GCC warning.
8941 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8943 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8944 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8945 isn't needed on 32-bit machines.
8947 * buffer.c (Fgenerate_new_buffer_name):
8948 Use EMACS_INT for count, not int.
8949 (advance_to_char_boundary): Return EMACS_INT, not int.
8951 * data.c (Qcompiled_function): Now static.
8953 * window.c (window_body_lines): Now static.
8955 * image.c (gif_load): Rename local to avoid shadowing.
8957 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8958 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8959 * alloc.c (make_save_value): Integer argument is now of type
8961 (mark_object): Use ptrdiff_t, not int.
8962 * lisp.h (pD): New macro.
8963 * print.c (print_object): Use it.
8965 * alloc.c: Use EMACS_INT, not int, to count objects.
8966 (total_conses, total_markers, total_symbols, total_vector_size)
8967 (total_free_conses, total_free_markers, total_free_symbols)
8968 (total_free_floats, total_floats, total_free_intervals)
8969 (total_intervals, total_strings, total_free_strings):
8970 Now EMACS_INT, not int. All uses changed.
8971 (Fgarbage_collect): Compute overall total using a double, so that
8972 integer overflow is less likely to be a problem. Check for overflow
8973 when converting back to an integer.
8974 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8975 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8976 These were 'int' variables that could overflow on 64-bit hosts;
8977 they were never used, so remove them instead of repairing them.
8978 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
8979 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8980 Previously, this ceilinged at INT_MAX, but that doesn't work on
8982 (allocate_pseudovector): Don't use EMACS_INT when int would do.
8984 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
8985 (allocate_vectorlike): Check for ptrdiff_t overflow.
8986 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8987 when a (possibly-narrower) signed value would do just as well.
8988 We prefer using signed arithmetic, to avoid comparison confusion.
8990 * alloc.c: Catch some string size overflows that we were missing.
8991 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8992 for convenience in STRING_BYTES_MAX.
8993 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8994 The definition here is exact; the one in lisp.h was approximate.
8995 (allocate_string_data): Check for string overflow. This catches
8996 some instances we weren't catching before. Also, it catches
8997 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8998 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8999 and ptrdiff_t and EMACS_INT are both 64 bits.
9001 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9002 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
9003 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
9005 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9007 * alloc.c (Fmake_string): Check for out-of-range init.
9009 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9011 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9013 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9015 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9016 xg_get_default_scrollbar_width.
9018 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9019 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9020 (style_changed_cb): Call update_theme_scrollbar_width and call
9021 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9022 all frames (Bug#8505).
9023 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9024 Call gtk_window_set_resizable if HAVE_GTK3.
9025 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9026 and height if HAVE_GTK3 (Bug#8505).
9027 (scroll_bar_width_for_theme): New variable.
9028 (update_theme_scrollbar_width): New function.
9029 (xg_get_default_scrollbar_width): Move code to
9030 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9031 (xg_initialize): Call update_theme_scrollbar_width.
9033 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9035 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9037 2011-06-12 Martin Rudalics <rudalics@gmx.at>
9039 * frame.c (make_frame): Call other_buffer_safely instead of
9042 * window.c (temp_output_buffer_show): Call display_buffer with
9043 second argument Vtemp_buffer_show_specifiers and reset latter
9044 immediately after the call.
9045 (Vtemp_buffer_show_specifiers): New variable.
9046 (auto_window_vscroll_p, next_screen_context_lines)
9047 (Vscroll_preserve_screen_position): Remove leading asterisks from
9050 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
9052 Fix minor problems found by GCC 4.6.0 static checking.
9053 * buffer.c (Qclone_number): Remove for now, as it's unused.
9054 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9055 (record_buffer): Remove unused local.
9056 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9057 (set_frame_buffer_list): Remove; unused.
9058 * frame.h (other_visible_frames): Remove decl.
9059 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9060 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9061 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9063 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9064 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9065 Define only if HAVE_GPM.
9066 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9067 (update_hints_inhibit): Remove; never set. All uses removed.
9068 * widgetprv.h (emacsFrameClassRec): Remove decl.
9069 * window.c (delete_deletable_window): Now returns void, since it
9070 wasn't returning anything.
9071 (compare_window_configurations): Remove unused locals.
9072 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9073 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
9074 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9075 the same widths as pointers. This follows up on the 2011-05-06 patch.
9076 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9077 * xterm.h: Likewise.
9078 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9080 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
9082 * makefile.w32-in: Update dependencies.
9083 (LISP_H): Add lib/intprops.h.
9085 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
9087 * image.c (gif_load): Add animation frame delay to the metadata.
9088 (syms_of_image): Use DEFSYM. New symbol `delay'.
9090 2011-06-11 Martin Rudalics <rudalics@gmx.at>
9092 * window.c (delete_deletable_window): Re-add.
9093 (Fset_window_configuration): Rewrite to handle dead buffers and
9094 consequently deletable windows.
9095 (window_tree, Fwindow_tree): Remove. Supply functionality in
9097 (compare_window_configurations): Simplify code.
9099 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9101 * image.c (imagemagick_load_image): Fix type mismatch.
9102 (Fimagemagick_types): Likewise.
9104 * window.h (replace_buffer_in_windows): Declare.
9106 2011-06-11 Martin Rudalics <rudalics@gmx.at>
9108 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9109 Qclone_number. Remove external declaration of Qdelete_window.
9110 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9112 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9113 Run Qbuffer_list_update_hook if allowed.
9114 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9115 buffer list implementation.
9116 (other_buffer_safely): New function.
9117 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9118 calls to replace_buffer_in_windows and
9119 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9121 (record_buffer): Inhibit quitting and rewrite using quittable
9122 functions. Run Qbuffer_list_update_hook if allowed.
9123 (Frecord_buffer, Funrecord_buffer): New functions.
9124 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9125 Move switch-to-buffer to window.el.
9126 (bury-buffer): Move to window.el.
9127 (Vbuffer_list_update_hook): New variable.
9129 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9132 * window.h (resize_frame_windows): Move up in code.
9133 (Fwindow_frame): Remove EXFUN.
9134 (replace_buffer_in_all_windows): Remove prototype.
9135 (replace_buffer_in_windows_safely): Add prototype.
9137 * window.c: Declare Qdelete_window static again. Move down
9138 declaration of select_count.
9139 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9140 (Fother_window): Move to window.el.
9141 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9142 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9143 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9145 (replace_buffer_in_windows): Implement by calling
9146 Qreplace_buffer_in_windows.
9147 (replace_buffer_in_all_windows): Remove with some functionality
9148 moved into replace_buffer_in_windows_safely.
9149 (replace_buffer_in_windows_safely): New function.
9150 (select_window_norecord, select_frame_norecord): Move in front
9151 of run_window_configuration_change_hook. Remove now obsolete
9153 (Fset_window_buffer): Rewrite doc-string.
9154 Call Qrecord_window_buffer.
9155 (keys_of_window): Move binding for other-window to window.el.
9157 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
9159 * dispextern.h (struct image): Replace data member, whose int_val
9160 and ptr_val fields were not used by anything, with a single
9163 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9164 (gif_clear_image, gif_load, imagemagick_load_image)
9165 (gs_clear_image, gs_load): Callers changed.
9167 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9169 * buffer.h: Include <time.h>, for time_t.
9170 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9172 Fix minor problems found by static checking.
9174 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9176 Make identifiers static if they are not used in other modules.
9177 * data.c (Qcompiled_function, Qframe, Qvector):
9178 * image.c (QimageMagick, Qsvg):
9179 * minibuf.c (Qmetadata):
9180 * window.c (resize_window_check, resize_root_window): Now static.
9181 * window.h (resize_window_check, resize_root_window): Remove decls.
9183 * window.c (window_deletion_count, delete_deletable_window):
9185 (window_body_lines): Now static.
9186 (Fdelete_other_windows_internal): Mark vars as initialized.
9187 Make sure 'resize_failed' is initialized.
9188 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9189 (resize_window_apply): Remove unused local.
9190 * window.h (delete_deletable_window): Remove decl.
9192 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
9193 (imagemagick_load_image): Fix pointer signedness problem by changing
9194 last arg from unsigned char * to char *. All uses changed.
9195 Also, fix a local for similar reasons.
9196 Remove unused locals. Remove locals to avoid shadowing.
9197 (fn_rsvg_handle_free): Remove; unused.
9198 (svg_load, svg_load_image): Fix pointer signedness problem.
9199 (imagemagick_load_image): Don't use garbage pointer image_wand.
9201 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9203 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
9205 * image.c (gif_load): Fix omitted cast error introduced by
9208 2011-06-10 Martin Rudalics <rudalics@gmx.at>
9210 * window.h (resize_proportionally, orig_total_lines)
9211 (orig_top_line): Remove from window structure.
9212 (set_window_height, set_window_width, change_window_heights)
9213 (Fdelete_window): Remove prototypes.
9214 (resize_frame_windows): Remove duplicate declaration.
9216 2011-06-10 Eli Zaretskii <eliz@gnu.org>
9218 * window.h (resize_frame_windows, resize_window_check)
9219 (delete_deletable_window, resize_root_window)
9220 (resize_frame_windows): Declare prototypes.
9222 * window.c (resize_window_apply): Make definition be "static" to
9223 match the prototype.
9225 2011-06-10 Martin Rudalics <rudalics@gmx.at>
9227 * window.c: Remove declarations of Qwindow_size_fixed,
9228 window_min_size_1, window_min_size_2, window_min_size,
9229 size_window, window_fixed_size_p, enlarge_window, delete_window.
9230 Remove static from declaration of Qdelete_window, it's
9231 temporarily needed by Fbury_buffer.
9232 (replace_window): Don't assign orig_top_line and
9234 (Fdelete_window, delete_window): Remove. Window deletion is
9235 handled by window.el.
9236 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9237 Replace Fdelete_window calls with calls to Qdelete_window.
9238 (Fdelete_other_windows): Remove. Deleting other windows is
9239 handled by window.el.
9240 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9241 handled in window.el.
9242 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9243 Window minimum sizes are handled in window.el.
9244 (shrink_windows, size_window, set_window_height)
9245 (set_window_width, change_window_heights, window_height)
9246 (window_width, CURBEG, CURSIZE, enlarge_window)
9247 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9248 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9249 handled in window.el.
9250 (make_dummy_parent): Rename to make_parent_window and give it a
9251 second argument horflag.
9252 (make_window): Don't set resize_proportionally any more.
9253 (Fsplit_window): Remove. Windows are split in window.el.
9254 (save_restore_action, save_restore_orig_size)
9255 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9256 Resize mini windows in window.el.
9257 (grow_mini_window, shrink_mini_window): Implement by calling
9258 Qresize_root_window_vertically, resize_window_check and
9259 resize_window_apply.
9260 (saved_window, Fset_window_configuration, save_window_save):
9261 Do not handle orig_top_line, orig_total_lines, and
9262 resize_proportionally.
9263 (window_min_height, window_min_width): Move to window.el.
9264 (keys_of_window): Move bindings for delete-other-windows,
9265 split-window, delete-window and enlarge-window to window.el.
9267 * buffer.c: Temporarily extern Qdelete_window.
9268 (Fbury_buffer): Temporarily call Qdelete_window instead of
9269 Fdelete_window (Fbury_buffer will move to window.el soon).
9271 * frame.c (set_menu_bar_lines_1): Remove code handling
9272 orig_top_line and orig_total_lines.
9274 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9275 set_window_height but set heights directly.
9276 (change_frame_size_1): Use resize_frame_windows.
9278 * xdisp.c (init_xdisp): Don't use set_window_height but set
9281 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9282 Use resize_frame_windows instead of change_window_heights and run
9283 run_window_configuration_change_hook.
9285 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9286 instead of change_window_heights and run
9287 run_window_configuration_change_hook.
9289 2011-06-09 Martin Rudalics <rudalics@gmx.at>
9291 * window.c (replace_window): Rename second argument REPLACEMENT to
9292 NEW. New third argument SETFLAG. Rewrite.
9293 (delete_window, make_dummy_parent): Call replace_window with
9295 (window_list_1): Move down in code.
9296 (run_window_configuration_change_hook): Move set_buffer part
9297 before select_frame_norecord part in order to unwind correctly.
9298 Rename count1 to count.
9299 (recombine_windows, delete_deletable_window, resize_root_window)
9300 (Fdelete_other_windows_internal)
9301 (Frun_window_configuration_change_hook, make_parent_window)
9302 (resize_window_check, resize_window_apply, Fresize_window_apply)
9303 (resize_frame_windows, Fsplit_window_internal)
9304 (Fdelete_window_internal, Fresize_mini_window_internal):
9306 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9308 2011-06-08 Martin Rudalics <rudalics@gmx.at>
9310 * window.h (window): Add some new members to window structure -
9311 normal_lines, normal_cols, new_total, new_normal, clone_number,
9312 splits, nest, prev_buffers, next_buffers.
9313 (WINDOW_TOTAL_SIZE): Move here from window.c.
9314 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
9316 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9318 (make_dummy_parent): Set new members of windows structure.
9319 (make_window): Move down in code. Handle new members of window
9321 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9322 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9323 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9324 (Fset_window_prev_buffers, Fwindow_next_buffers)
9325 (Fset_window_next_buffers, Fset_window_clone_number):
9327 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9328 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9330 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9331 Argument WINDOW can be now internal window too.
9332 (Fwindow_use_time): Move up in code.
9333 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9335 (Fset_window_configuration, saved_window)
9336 (Fcurrent_window_configuration, save_window_save): Handle new
9337 members of window structure.
9338 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9339 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9340 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9341 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9342 Qget_mru_window, Qresize_root_window,
9343 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9344 Qauto_buffer_name; staticpro them.
9346 2011-06-07 Martin Rudalics <rudalics@gmx.at>
9348 * window.c (Fwindow_total_size, Fwindow_left_column)
9349 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9350 (Fwindow_list_1): New functions.
9351 (window_box_text_cols): Replace with window_body_cols.
9352 (Fwindow_width, Fscroll_left, Fscroll_right):
9353 Use window_body_cols instead of window_box_text_cols.
9354 (delete_window, Fset_window_configuration):
9355 Call delete_all_subwindows with window as argument.
9356 (delete_all_subwindows): Take a window as argument and not a
9358 (window_loop): Remove handling of GET_LRU_WINDOW and
9360 (Fget_lru_window, Fget_largest_window): Move to window.el.
9362 * window.h: Extern window_body_cols instead of
9363 window_box_text_cols. delete_all_subwindows now takes a
9364 Lisp_Object as argument.
9366 * indent.c (compute_motion, Fcompute_motion):
9367 Use window_body_cols instead of window_box_text_cols.
9369 * frame.c (delete_frame): Call delete_all_subwindows with root
9372 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9374 * fns.c (Fputhash): Document return value.
9376 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
9378 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9380 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9382 Cons<->int and similar integer overflow fixes (Bug#8794).
9384 Check for overflow when converting integer to cons and back.
9385 * charset.c (Fdefine_charset_internal, Fdecode_char):
9386 Use cons_to_unsigned to catch overflow.
9387 (Fencode_char): Use INTEGER_TO_CONS.
9388 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9389 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9390 * data.c (long_to_cons, cons_to_long): Remove.
9391 (cons_to_unsigned, cons_to_signed): New functions.
9392 These signal an error for invalid or out-of-range values.
9393 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9394 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9395 * font.c (Ffont_variation_glyphs):
9396 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9397 * lisp.h: Include <intprops.h>.
9398 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9399 (cons_to_signed, cons_to_unsigned): New decls.
9400 (long_to_cons, cons_to_long): Remove decls.
9401 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9402 (Fprimitive_undo): Use CONS_TO_INTEGER.
9403 * xfns.c (Fx_window_property): Likewise.
9404 * xselect.c: Include <limits.h>.
9405 (x_own_selection, selection_data_to_lisp_data):
9406 Use INTEGER_TO_CONS.
9407 (x_handle_selection_request, x_handle_selection_clear)
9408 (x_get_foreign_selection, Fx_disown_selection_internal)
9409 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9410 (lisp_data_to_selection_data): Use cons_to_unsigned.
9411 (x_fill_property_data): Use cons_to_signed.
9412 Report values out of range.
9414 Check for buffer and string overflow more precisely.
9415 * buffer.h (BUF_BYTES_MAX): New macro.
9416 * lisp.h (STRING_BYTES_MAX): New macro.
9417 * alloc.c (Fmake_string):
9418 * character.c (string_escape_byte8):
9419 * coding.c (coding_alloc_by_realloc):
9420 * doprnt.c (doprnt):
9421 * editfns.c (Fformat):
9423 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9424 since they may not be the same number.
9425 * editfns.c (Finsert_char):
9426 * fileio.c (Finsert_file_contents):
9427 Likewise for BUF_BYTES_MAX.
9429 * image.c: Use ptrdiff_t, not int, for sizes.
9430 (slurp_file): Switch from int to ptrdiff_t.
9432 (slurp_file): Check that file size fits in both size_t (for
9433 malloc) and ptrdiff_t (for sanity and safety).
9435 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9436 if b->modtime has its maximal value.
9438 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9440 Don't assume time_t can fit into int.
9441 * buffer.h (struct buffer.modtime): Now time_t, not int.
9442 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9443 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9445 Minor fixes for signed vs unsigned integers.
9446 * character.h (MAYBE_UNIFY_CHAR):
9447 * charset.c (maybe_unify_char):
9448 * keyboard.c (read_char, reorder_modifiers):
9449 XINT -> XFASTINT, since the integer must be nonnegative.
9450 * ftfont.c (ftfont_spec_pattern):
9451 * keymap.c (access_keymap, silly_event_symbol_error):
9452 XUINT -> XFASTINT, since the integer must be nonnegative.
9453 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9454 since it makes no difference and we prefer signed.
9455 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9456 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9459 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9461 * window.h (Fwindow_frame): Declare.
9463 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9465 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9466 (SPARE_MEMORY): Always define.
9467 (LARGE_REQUEST): Remove.
9468 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9470 2011-06-06 Martin Rudalics <rudalics@gmx.at>
9472 * lisp.h: Move EXFUNS for Fframe_root_window,
9473 Fframe_first_window and Fset_frame_selected_window to window.h.
9475 * window.h: Move EXFUNS for Fframe_root_window,
9476 Fframe_first_window and Fset_frame_selected_window here from
9479 * frame.c (Fwindow_frame, Fframe_first_window)
9480 (Fframe_root_window, Fframe_selected_window)
9481 (Fset_frame_selected_window): Move to window.c.
9482 (Factive_minibuffer_window): Move to minibuf.c.
9483 (Fother_visible_frames_p): New function.
9485 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9487 * window.c (decode_window, decode_any_window): Move up in code.
9488 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9489 (inhibit_frame_unsplittable): Remove unused variable.
9490 (Fwindow_buffer): Move up and rewrite doc-string.
9491 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9492 (Fwindow_prev): New functions.
9493 (Fwindow_frame): Move here from frame.c. Accept any window as
9495 (Fframe_root_window, Fframe_first_window)
9496 (Fframe_selected_window): Move here from frame.c. Accept frame
9497 or arbitrary window as argument. Update doc-strings.
9498 (Fminibuffer_window): Move up in code.
9499 (Fwindow_minibuffer_p): Move up in code and simplify.
9500 (Fset_frame_selected_window): Move here from frame.c.
9502 (Fselected_window, select_window, Fselect_window): Move up in
9503 code. Minor doc-string fixes.
9505 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9507 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9508 Do not assume that spare memory exists; that assumption is valid
9509 only if SYSTEM_MALLOC.
9510 (LARGE_REQUEST): New macro, so that the issue of large requests
9511 is separated from the issue of spare memory.
9513 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9515 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9518 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9520 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9523 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9525 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9527 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9529 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9530 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9532 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
9534 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9536 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
9538 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9539 (x_clipboard_manager_save): Add return value.
9540 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9542 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9543 Obey Vx_select_enable_clipboard_manager. Catch errors in
9544 x_clipboard_manager_save (Bug#8779).
9545 (Vx_select_enable_clipboard_manager): New variable.
9546 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
9548 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
9550 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9552 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9554 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9555 in the current matrix if keep_current_p is non-zero.
9557 2011-06-04 Eli Zaretskii <eliz@gnu.org>
9559 * bidi.c (bidi_level_of_next_char): Fix last change.
9561 2011-06-03 Eli Zaretskii <eliz@gnu.org>
9563 Support bidi reordering of text covered by display properties.
9565 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9566 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9567 (bidi_cache_search, bidi_cache_iterator_state)
9568 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
9569 (bidi_level_of_next_char, bidi_move_to_visually_next):
9570 Support character positions inside a run of characters covered by a
9572 (bidi_paragraph_init, bidi_resolve_explicit_1)
9573 (bidi_level_of_next_char): Call bidi_fetch_char and
9574 bidi_fetch_char_advance instead of FETCH_CHAR and
9576 (bidi_init_it): Initialize new members.
9577 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9579 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9580 instead of using explicit *_CHAR codes.
9581 (bidi_resolve_explicit, bidi_resolve_weak):
9582 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
9583 bidirectional text is supported only in multibyte buffers.
9584 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9585 it to initialize the frame_window_p member of struct bidi_it.
9586 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9587 (bidi_resolve_explicit, bidi_resolve_weak)
9588 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9589 bidi_it->nchars is non-positive.
9590 (bidi_level_of_next_char): Don't try to lookup the cache for the
9591 next/previous character if nothing is cached there yet, or if we
9592 were just reseat()'ed to a new position.
9594 * xdisp.c (set_cursor_from_row): Set start and stop points
9595 according to the row's direction when priming the loop that looks
9596 for the glyph on which to display cursor.
9597 (single_display_spec_intangible_p): Function deleted.
9598 (display_prop_intangible_p): Reimplement to call
9599 handle_display_spec instead of single_display_spec_intangible_p.
9600 Accept 3 additional arguments needed by handle_display_spec.
9601 This fixes incorrect cursor motion across display property with complex
9602 values: lists, `(when COND...)' forms, etc.
9603 (single_display_spec_string_p): Support property values that are
9604 lists with the argument STRING its top-level element.
9605 (display_prop_string_p): Fix the condition for processing a
9606 property that is a list to be consistent with handle_display_spec.
9607 (handle_display_spec): New function, refactored from the
9608 last portion of handle_display_prop.
9609 (compute_display_string_pos): Accept additional argument
9610 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9611 value of a `display' property is a "replacing spec".
9612 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9613 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9614 the display property, but just return a value indicating whether
9615 the display property will replace the characters it covers.
9616 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9617 frame_window_p members of struct bidi_it.
9618 (compute_display_string_pos, compute_display_string_end):
9620 (push_it): Accept second argument POSITION, where pop_it should
9621 jump to continue iteration.
9622 (reseat_1): Initialize bidi_it.disp_pos.
9624 * keyboard.c (adjust_point_for_property): Adjust the call to
9625 display_prop_intangible_p to its new signature.
9627 * dispextern.h (struct bidi_it): New member frame_window_p.
9628 (bidi_init_it): Update prototypes.
9629 (display_prop_intangible_p): Update prototype.
9630 (compute_display_string_pos, compute_display_string_end):
9632 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9635 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
9637 Malloc failure behavior now depends on size of allocation.
9638 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9639 * lisp.h: Change signatures accordingly.
9640 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9641 All callers changed. (Bug#8762)
9643 * gnutls.c: Use Emacs's memory allocators.
9644 Without this change, the gnutls library would invoke malloc etc.
9645 directly, which causes problems on non-SYNC_INPUT hosts, and which
9646 runs afoul of improving memory_full behavior. (Bug#8761)
9647 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9648 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9649 xfree instead of the default malloc, realloc, free.
9650 (Fgnutls_boot): No need to check for memory allocation failure,
9651 since xmalloc does that for us.
9653 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
9654 * category.c (hash_get_category_set):
9655 * ccl.c (ccl_driver):
9656 * charset.c (Fdefine_charset_internal):
9657 * charset.h (struct charset.hash_index):
9658 * composite.c (get_composition_id, gstring_lookup_cache)
9659 (composition_gstring_put_cache):
9660 * composite.h (struct composition.hash_index):
9661 * dispextern.h (struct image.hash):
9662 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9663 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9664 (hashfn_equal, hashfn_user_defined, make_hash_table)
9665 (maybe_resize_hash_table, hash_lookup, hash_put)
9666 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9667 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9668 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9669 * image.c (make_image, search_image_cache, lookup_image)
9670 (xpm_put_color_table_h):
9671 * lisp.h (struct Lisp_Hash_Table):
9672 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
9673 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
9674 for hashes and hash indexes, instead of 'unsigned' and 'int'.
9675 * alloc.c (allocate_vectorlike):
9676 Check for overflow in vector size calculations.
9677 * ccl.c (ccl_driver):
9678 Check for overflow when converting EMACS_INT to int.
9679 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9680 need to be updated by these changes.
9681 * fns.c (make_hash_table, maybe_resize_hash_table):
9682 Check for integer overflow with large hash tables.
9683 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9684 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9685 (SXHASH_REDUCE): New macro.
9686 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9687 Use it instead of discarding useful hash info with large hash values.
9688 (sxhash_float): New function.
9689 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9690 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
9691 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9692 Rewrite to use FIXNUM_BITS, as this simplifies things.
9693 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9694 Adjust signatures to match updated version of code.
9695 (consing_since_gc): Now EMACS_INT, since a single hash table can
9696 use more than INT_MAX bytes.
9698 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9700 Make it possible to build with GCC-4.6+ -O2 -flto.
9702 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9704 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9706 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9707 Call minibuffer-inactive-mode.
9709 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
9711 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9712 Update dependencies.
9714 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9716 * data.c (init_data): Remove code for UTS, this system is not
9719 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9721 Don't force ./temacs to start in terminal mode.
9723 * frame.c (make_initial_frame): Initialize faces in all cases, not
9724 only when CANNOT_DUMP is defined.
9725 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9727 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9729 * dispnew.c (add_window_display_history): Use const for the string
9730 pointer. Remove declaration, not needed.
9732 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9734 Use 'inline', not 'INLINE'.
9735 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
9736 * alloc.c, fontset.c (INLINE): Remove.
9737 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9738 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9739 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9740 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9741 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9743 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9745 Make it possible to run ./temacs.
9747 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9748 syms_of_callproc does the same thing. Remove test for
9749 "initialized", do it in the caller.
9750 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9752 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9754 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9755 (read_minibuf): Use get_minibuffer.
9756 (syms_of_minibuf): Use DEFSYM.
9757 (Qmetadata): New var.
9758 * data.c (Qbuffer): Don't make it static.
9759 (syms_of_data): Use DEFSYM.
9761 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9763 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9764 (CCL_CODE_MIN): New macro.
9766 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9768 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9770 * eval.c (Qdebug): Now static.
9771 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9772 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9773 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9775 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
9777 * image.c: Various fixes to ImageMagick code comments.
9778 (Fimagemagick_types): Doc fix.
9780 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9782 Minor fixes prompted by GCC 4.6.0 warnings.
9784 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9786 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9787 (x_clipboard_manager_save_all): Move extern decl to ...
9788 * xterm.h: ... here, so that it can be checked for consistency.
9790 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
9792 * xselect.c (x_clipboard_manager_save_frame)
9793 (x_clipboard_manager_save_all): New functions.
9794 (Fx_clipboard_manager_save): Lisp function deleted.
9796 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9797 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9799 * xterm.h: Update prototype.
9801 2011-05-28 William Xu <william.xwl@gmail.com>
9803 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9806 2011-05-28 Jim Meyering <meyering@redhat.com>
9808 Avoid a sign-extension bug in crypto_hash_function.
9809 * fns.c (to_uchar): Define.
9810 (crypto_hash_function): Use it to convert some newly-signed
9811 variables to unsigned, to avoid sign-extension bugs. For example,
9812 without this change, (md5 "truc") would evaluate to
9813 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9814 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
9815 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
9817 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9819 Integer overflow fixes.
9821 * dbusbind.c: Serial number integer overflow fixes.
9822 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
9823 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9824 to hold a serial number that is too large for a fixnum.
9825 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9826 Check for serial numbers out of range. Decode any serial number
9827 that was so large that it became a float. (Bug#8722)
9829 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9830 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9831 Use XFASTINT rather than XUINT when numbers are nonnegative.
9832 (xd_append_arg, Fdbus_method_return_internal):
9833 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9834 arguments, check that Lisp number is nonnegative, rather than
9835 silently wrapping negative numbers around. (Bug#8722)
9836 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
9839 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9841 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9843 ccl: Add integer overflow checks.
9844 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9845 (IN_INT_RANGE): New macros.
9846 (ccl_driver): Use them to check for integer overflow when
9847 decoding a CCL program. Many of the new checks are whether XINT (x)
9848 fits in int; it doesn't always, on 64-bit hosts. The new version
9849 doesn't catch all possible integer overflows, but it's an
9850 improvement. (Bug#8719)
9852 * alloc.c (make_event_array): Use XINT, not XUINT.
9853 There's no need for unsigned here.
9855 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9856 This follows up to the 2011-05-06 change that substituted uintptr_t
9857 for EMACS_INT. This case wasn't caught back then.
9859 Rework Fformat to avoid integer overflow issues.
9860 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9861 now (part of C89). Include <verify.h>.
9862 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9863 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9864 (Fformat): Avoid the prepass trying to compute sizes; it was only
9865 approximate and thus did not catch overflow reliably. Instead, walk
9866 through the format just once, formatting and computing sizes as we go,
9867 checking for integer overflow at every step, and allocating a larger
9868 buffer as needed. Keep track separately whether the format is
9869 multibyte. Keep only the most-recently calculated precision, rather
9870 than them all. Record whether each argument has been converted to
9871 string. Use EMACS_INT, not int, for byte and char and arg counts.
9872 Support field widths and precisions larger than INT_MAX. Avoid
9873 sprintf's undefined behavior with conversion specifications such as %#d
9874 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9875 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9876 formatting out-of-range floating point numbers with int
9879 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9881 * data.c: Avoid integer truncation in expressions involving floats.
9882 * data.c: Include <intprops.h>.
9883 (arith_driver): When there's an integer overflow in an expression
9884 involving floating point, convert the integers to floating point
9885 so that the resulting value does not suffer from catastrophic
9886 integer truncation. For example, on a 64-bit host (* 4
9887 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9888 Do not rely on undefined behavior after integer overflow.
9890 merge count_size_as_multibyte, parse_str_to_multibyte
9891 * character.c, character.h (count_size_as_multibyte):
9892 Rename from parse_str_to_multibyte; all uses changed.
9893 Check for integer overflow.
9894 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9895 since it's now a duplicate of the other. This is more of
9896 a character than a buffer op, so better that it's in character.c.
9897 * fns.c, print.c: Adjust to above changes.
9899 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9901 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9903 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9905 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9906 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9907 (x_clipboard_manager_save): Now static.
9908 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9910 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9911 (crypto_hash_function): Now static.
9912 Fix pointer signedness problems. Avoid unnecessary initializations.
9914 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
9916 * termhooks.h (Vselection_alist): Make it terminal-local.
9918 * terminal.c (create_terminal): Initialize it.
9920 * xselect.c: Support for clipboard managers.
9921 (Vselection_alist): Move to termhooks.h as terminal-local var.
9922 (LOCAL_SELECTION): New macro.
9923 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9924 (symbol_to_x_atom): Remove gratuitous arg.
9925 (x_handle_selection_request, lisp_data_to_selection_data)
9926 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
9927 (x_own_selection, x_get_local_selection, x_convert_selection):
9928 New arg, specifying work frame. Use terminal-local Vselection_alist.
9929 (some_frame_on_display): Delete unused function.
9930 (Fx_own_selection_internal, Fx_get_selection_internal)
9931 (Fx_disown_selection_internal, Fx_selection_owner_p)
9932 (Fx_selection_exists_p): New optional frame arg.
9933 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9934 (x_handle_selection_clear): Don't treat other terminals with the
9935 same keyboard specially. Use the terminal-local Vselection_alist.
9936 (x_clear_frame_selections): Use Frun_hook_with_args.
9938 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9940 * xterm.h: Add support for those atoms.
9942 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
9944 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9945 (converted_selections, conversion_fail_tag): New global variables.
9946 (x_selection_request_lisp_error): Free the above.
9947 (x_get_local_selection): Remove unnecessary code.
9948 (x_reply_selection_request): Args changed; handle arbitrary array
9949 of converted selections stored in converted_selections.
9950 Separate the XChangeProperty and SelectionNotify steps.
9951 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9952 (x_convert_selection): New function.
9953 (x_handle_selection_event): Simplify.
9954 (x_get_foreign_selection): Don't ignore incoming requests while
9955 waiting for an answer; this will fail when we implement
9956 SAVE_TARGETS, and seems unnecessary anyway.
9957 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9958 (Vx_sent_selection_functions): Doc fix.
9960 2011-05-26 Leo Liu <sdl.web@gmail.com>
9962 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9964 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9966 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9968 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9969 for fringe update if it has periodic bitmap.
9970 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
9971 and fringe_bitmap_periodic_p.
9973 * fringe.c (get_fringe_bitmap_data): New function.
9974 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9975 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9976 row. Mark glyph row for fringe update if periodicity changed.
9978 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9979 for fringe update unless it has periodic bitmap.
9981 2011-05-25 Kenichi Handa <handa@m17n.org>
9983 * xdisp.c (get_next_display_element): Set correct it->face_id for
9984 a static composition.
9986 2011-05-24 Leo Liu <sdl.web@gmail.com>
9989 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9991 * fns.c (crypto_hash_function, Fsha1): New function.
9992 (Fmd5): Use crypto_hash_function.
9993 (syms_of_fns): Add Ssha1.
9995 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9997 * gnutls.c: Remove unused macros.
9998 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9999 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10000 Remove macros that are defined and never used.
10001 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10003 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
10005 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10006 (Fx_get_selection_internal): Minor cleanup.
10007 (Fx_own_selection_internal): Rename arguments for consistency with
10010 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10012 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10014 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
10016 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10018 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10020 * dispnew.c (scrolling_window): Don't exclude the case that the
10021 last enabled row in the desired matrix touches the bottom boundary.
10023 2011-05-21 Glenn Morris <rgm@gnu.org>
10025 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
10026 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10027 and add some more files.
10029 2011-05-20 Eli Zaretskii <eliz@gnu.org>
10031 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10032 report_file_error introduced by the change from 2011-05-07.
10034 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10036 * systime.h (Time): Define only if emacs is defined.
10037 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10038 where the include path doesn't have X11/X.h by default. See
10039 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10041 2011-05-20 Kenichi Handa <handa@m17n.org>
10043 * composite.c (find_automatic_composition): Fix previous change.
10045 2011-05-20 Glenn Morris <rgm@gnu.org>
10047 * lisp.mk: New file, split from Makefile.in.
10048 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10049 (shortlisp): Remove.
10050 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10052 2011-05-19 Glenn Morris <rgm@gnu.org>
10054 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10055 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10056 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10057 (lisp): Set the order to that of loadup.el.
10058 (shortlisp): Make it a copy of $lisp.
10059 (SOME_MACHINE_LISP): Remove.
10060 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10061 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10063 2011-05-18 Kenichi Handa <handa@m17n.org>
10065 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10066 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10067 (find_automatic_composition): Mostly rewrite for efficiency.
10069 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
10071 * makefile.w32-in: Update dependencies.
10073 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10075 * menu.c: Include limits.h (fixes the MS-Windows build broken by
10076 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
10078 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
10080 Fix some integer overflow issues, such as string length overflow.
10082 * insdel.c (count_size_as_multibyte): Check for string overflow.
10084 * character.c (lisp_string_width): Check for string overflow.
10085 Use EMACS_INT, not int, for string indexes and lengths; in
10086 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10087 the resulting string length overflows an EMACS_INT; instead,
10088 report a string overflow if no precision given. When checking for
10089 precision exhaustion, use a check that cannot possibly have
10090 integer overflow. (Bug#8675)
10091 * character.h (lisp_string_width): Adjust to new signature.
10093 * alloc.c (string_overflow): New function.
10094 (Fmake_string): Use it. This doesn't change behavior, but saves
10095 a few bytes and will simplify future changes.
10096 * character.c (string_escape_byte8): Likewise.
10097 * lisp.h (string_overflow): New decl.
10099 Fixups, following up to the user-interface timestamp change.
10100 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10101 for UI timestamps, instead of unsigned long.
10102 * msdos.c (mouse_get_pos): Likewise.
10103 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
10104 * w32gui.h (Time): Define by including "systime.h" rather than by
10105 declaring it ourselves. (Bug#8664)
10107 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10108 * image.c (clear_image_cache): Likewise.
10110 * term.c (term_mouse_position): Don't assume time_t wraparound.
10112 Be more systematic about user-interface timestamps.
10113 Before, the code sometimes used 'Time', sometimes 'unsigned long',
10114 and sometimes 'EMACS_UINT', to represent these timestamps.
10115 This change causes it to use 'Time' uniformly, as that's what X uses.
10116 This makes the code easier to follow, and makes it easier to catch
10117 integer overflow bugs such as Bug#8664.
10118 * frame.c (Fmouse_position, Fmouse_pixel_position):
10119 Use Time, not unsigned long, for user-interface timestamps.
10120 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10121 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10122 * keyboard.h (last_event_timestamp): Likewise.
10123 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10124 * menu.h (xmenu_show): Likewise.
10125 * term.c (term_mouse_position): Likewise.
10126 * termhooks.h (struct input_event.timestamp): Likewise.
10127 (struct terminal.mouse_position_hook): Likewise.
10128 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10129 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10130 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10131 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10132 what it was before.
10133 * menu.h, termhooks.h: Include "systime.h", for Time.
10135 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10136 Don't assume that the difference between two unsigned long values
10137 can fit into an integer. At this point, we know button_down_time
10138 <= event->timestamp, so the difference must be nonnegative, so
10139 there's no need to cast the result if double-click-time is
10140 nonnegative, as it should be; check that it's nonnegative, just in
10141 case. This bug is triggered when events are more than 2**31 ms
10142 apart (about 25 days). (Bug#8664)
10144 * xselect.c (last_event_timestamp): Remove duplicate decl.
10145 (x_own_selection): Remove needless cast to unsigned long.
10147 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10148 that always fit in int. Use a sentinel instead of a counter, to
10149 avoid a temp and to allay GCC's concerns about possible int overflow.
10150 * frame.h (struct frame): Use int for menu_bar_items_used
10151 instead of EMACS_INT, since it always fits in int.
10153 * menu.c (grow_menu_items): Check for int overflow.
10155 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10157 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10158 Before, the code was not consistent. These values cannot exceed
10159 2**31 - 1 so there's no need to make them unsigned.
10160 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10161 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10162 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10164 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10166 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10167 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10168 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10169 presumably because the widths might not match.
10171 * window.c (size_window): Avoid needless test at loop start.
10173 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10175 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10177 2011-05-12 Drew Adams <drew.adams@oracle.com>
10179 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10181 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10183 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10184 `width' to `bar_area_x' and `bar_area_width', respectively.
10185 (x_scroll_run): Take account of fringe background extension.
10187 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10188 Rename local vars `left' and `width' to `bar_area_x' and
10189 `bar_area_width', respectively.
10190 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10191 background extension.
10193 2011-05-10 Jim Meyering <meyering@redhat.com>
10195 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10197 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
10199 * image.c (Finit_image_library): Return t for built-in image types,
10200 like pbm and xbm. (Bug#8640)
10202 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10204 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10206 2011-05-07 Eli Zaretskii <eliz@gnu.org>
10208 * w32console.c (Fset_screen_color): Doc fix.
10209 (Fget_screen_color): New function.
10210 (syms_of_ntterm): Defsubr it.
10212 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10213 unlink the temporary file if Fcall_process didn't create it in the
10215 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10216 child process will be redirected to a file specified with `:file'.
10217 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10218 cue to call_process_cleanup not to close that handle.
10220 2011-05-07 Ben Key <bkey76@gmail.com>
10222 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10223 one of two shell specific rules, either bootstrap-temacs-CMD or
10224 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10225 to the previous implementation of the bootstrap-temacs rule.
10226 The bootstrap-temacs-CMD rule is similar to the previous
10227 implementation of the bootstrap-temacs rule except that it
10228 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10231 These changes, along with some changes to nt/configure.bat,
10232 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10233 earlier fix to add support for --cflags and --ldflags options
10234 that include quotes so that it works whether make uses cmd or
10237 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
10239 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10240 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10242 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10243 a string. Handle both cases.
10244 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10245 (Fdbus_register_method): Use Qinvalid_function.
10247 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
10249 * makefile.w32-in: Update dependencies.
10250 (LISP_H): Add inttypes.h and stdin.h.
10251 (PROCESS_H): Add unistd.h.
10253 2011-05-06 Eli Zaretskii <eliz@gnu.org>
10255 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10256 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10258 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
10260 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10262 * term.c (vfatal): Remove stray call to va_end.
10263 It's not needed and the C Standard doesn't allow it here anyway.
10265 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10266 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10268 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10271 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10273 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10275 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10277 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10279 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10281 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10282 * charset.c (Fdefine_charset_internal): Don't initialize
10283 charset.code_space[15]. The value was garbage, on hosts with
10284 32-bit int (Bug#8600).
10286 * lread.c (read_integer): Be more consistent with string-to-number.
10287 Use string_to_number to do the actual conversion; this avoids
10288 rounding errors and fixes some other screwups. Without this fix,
10289 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10290 (digit_to_number): Move earlier, for benefit of read_integer.
10291 Return -1 if the digit is out of range for the base, -2 if it is
10292 not a digit in any supported base. (Bug#8602)
10294 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10296 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10297 to match comment at start of function. This also removes a
10298 GCC warning about overflow in a 32+64-bit port.
10300 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10302 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10303 Reported by Stefan Monnier in
10304 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
10305 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10306 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
10308 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10309 (EMACS_UINTPTR): Likewise, with uintptr_t.
10311 * lisp.h: Prefer 64-bit EMACS_INT if available.
10312 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10313 on 32-bit hosts that have 64-bit int, so that they can access
10315 However, temporarily disable this change unless the temporary
10316 symbol WIDE_EMACS_INT is defined.
10318 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10320 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10321 This removes an assumption that EMACS_INT and long are the same
10322 width as pointers. The assumption is true for Emacs porting targets
10323 now, but we want to make other targets possible.
10324 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10325 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10326 In the rest of the code, change types of integers that hold casted
10327 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10328 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10329 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10330 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10331 No need to cast type when ORing.
10332 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10333 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10334 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10335 assume EMACS_INT is the same width as char *.
10336 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10337 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10338 Remove no-longer-needed casts.
10339 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10340 (xg_tool_bar_help_callback, xg_make_tool_item):
10341 Use EMACS_INTPTR to hold an integer
10342 that will be cast to void *; this can avoid a GCC warning
10343 if EMACS_INT is not the same width as void *.
10344 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10345 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10346 (current_message_1, set_message_1):
10347 Use a local to convert to proper width without a cast.
10348 * xmenu.c (dialog_selection_callback): Likewise.
10350 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10351 Also, don't assume VALBITS / RAND_BITS is less than 5,
10352 and don't rely on undefined behavior when shifting a 1 left into
10354 * lisp.h (get_random): Change signature to match.
10356 * lread.c (hash_string): Use size_t, not int, for hash computation.
10357 Normally we prefer signed values; but hashing is special, because
10358 it's better to use unsigned division on hash table sizes so that
10359 the remainder is nonnegative. Also, size_t is the natural width
10360 for hashing into memory. The previous code used 'int', which doesn't
10361 retain enough info to hash well into very large tables.
10362 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10364 * dbusbind.c: Don't possibly lose pointer info when converting.
10365 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10366 Use XPNTR rather than XHASH, so that the high-order bits of
10367 the pointer aren't lost when converting through void *.
10369 * eval.c (Fautoload): Don't double-shift a pointer.
10371 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10373 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
10375 * gnutls.c (DEF_GNUTLS_FN):
10376 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10378 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10380 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10383 2011-05-05 Eli Zaretskii <eliz@gnu.org>
10385 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10386 New version that can reserve upto 2GB of heap space.
10388 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
10390 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10392 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10394 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10395 `gnutls_certificate_set_x509_key_file'.
10397 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
10399 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10400 Update dependencies.
10402 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10404 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10405 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10406 Remove unused parameter `fildes'.
10407 * process.c (read_process_output, send_process): Don't pass it.
10409 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10411 Fix previous change: the library cache is defined in w32.c.
10412 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10413 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10415 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10417 Implement dynamic loading of GnuTLS on Windows.
10419 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10420 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10421 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10424 * gnutls.c (Qgnutls_dll): Define.
10425 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10426 (gnutls_*): Declare function pointers.
10427 (init_gnutls_functions): New function to initialize function pointers.
10428 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10429 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10430 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10431 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10432 (emacs_gnutls_write, emacs_gnutls_read)
10433 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10434 (Fgnutls_available_p): New function.
10435 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10436 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10437 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10439 * image.c: Include w32.h.
10440 (Vimage_type_cache): Delete.
10441 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10442 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10443 (w32_delayed_load): Move to w32.c.
10445 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10447 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10448 (w32_delayed_load): Move from image.c. When loading a library, record
10449 its filename in the :loaded-from property of the library id.
10450 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10451 Initialize and staticpro them.
10452 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10454 * process.c: Include lisp.h before w32.h, not after.
10455 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10456 instead of gnutls_record_check_pending.
10458 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10460 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10462 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10463 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10466 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10468 * xterm.c (x_set_frame_alpha): Do not set property on anything
10469 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10471 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
10473 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10475 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
10477 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10478 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10479 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10480 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10481 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10482 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10483 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10484 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10485 (Qgnutls_bootprop_callbacks_verify): Make static.
10487 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10489 * callproc.c: Indentation fixup.
10491 * sysdep.c (wait_for_termination_1): Make static.
10492 (wait_for_termination, interruptible_wait_for_termination):
10493 Move after wait_for_termination_1.
10495 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10497 * sysdep.c (interruptible_wait_for_termination): New function
10498 which is like wait_for_termination, but allows keyboard
10501 * callproc.c (Fcall_process): Add (:file "file") as an option for
10503 (Fcall_process_region): Ditto.
10505 2011-04-30 Eli Zaretskii <eliz@gnu.org>
10507 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10508 rather than `XVECTOR (FOO)->size'.
10510 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10511 inttypes.h, as a gnulib replacement is used if it not available in
10514 2011-04-21 Eli Zaretskii <eliz@gnu.org>
10516 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10517 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10518 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10520 * coding.c (coding_alloc_by_realloc): Error out if destination
10521 will grow beyond MOST_POSITIVE_FIXNUM.
10522 (decode_coding_emacs_mule): Abort if there isn't enough place in
10523 charbuf for the composition carryover bytes. Reserve an extra
10524 space for up to 2 characters produced in a loop.
10525 (decode_coding_iso_2022): Abort if there isn't enough place in
10526 charbuf for the composition carryover bytes.
10528 2011-04-21 Eli Zaretskii <eliz@gnu.org>
10530 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10531 aborting when %lld or %lll format is passed.
10532 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10533 %llo or %llx format is passed. (Bug#8545)
10535 * window.c (window_scroll_line_based): Use a marker instead of
10536 simple variables to record original value of point. (Bug#7952)
10538 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10539 produced by %s or %c overflows available buffer space. (Bug#8545)
10541 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10543 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
10544 (SIZE_MAX): Move defn after all includes, as they might #define it.
10546 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10548 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10550 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10552 * keyboard.c (Qdelayed_warnings_hook): Define.
10553 (command_loop_1): Run `delayed-warnings-hook'
10554 if Vdelayed_warnings_list is non-nil.
10555 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10556 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10558 2011-04-28 Eli Zaretskii <eliz@gnu.org>
10560 * doprnt.c (doprnt): Don't return value smaller than the buffer
10561 size if the message was truncated. (Bug#8545).
10563 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10565 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10566 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10568 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10570 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10572 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
10574 * makefile.w32-in: Update dependencies.
10576 2011-04-27 Eli Zaretskii <eliz@gnu.org>
10578 Improve `doprnt' and its usage. (Bug#8545)
10579 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10580 `format_end'. Remove support for %l as a conversion specifier.
10581 Don't use xrealloc. Improve diagnostics when the %l size modifier
10582 is used. Update the commentary.
10584 * eval.c (verror): Simplify calculation of size_t.
10586 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10589 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10591 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10594 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10596 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10597 This makes this file independent of the recent pseudovector change.
10599 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
10601 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10603 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
10604 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
10605 Remove unused local.
10606 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
10608 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
10609 GCC 4.6.0 optimizes based on type-based alias analysis.
10610 For example, if b is of type struct buffer * and v of type struct
10611 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10612 != &v->size, and therefore "v->size = 1; b->size = 2; return
10613 v->size;" must therefore return 1. This assumption is incorrect
10614 for Emacs, since it type-puns struct Lisp_Vector * with many other
10615 types. To fix this problem, this patch adds a new type struct
10616 vectorlike_header that documents the constraints on layout of vectors
10617 and pseudovectors, and helps optimizing compilers not get fooled
10618 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10619 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
10620 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10622 (XSETPVECTYPE): Rewrite in terms of new macro.
10623 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10624 This is a bit clearer, and further avoids the possibility of
10625 undesirable aliasing.
10626 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
10627 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
10628 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10629 since Lisp_Subr is a special case (no "next" field).
10630 (ASIZE): Now uses header.size rather than size.
10631 All previous uses of XVECTOR (foo)->size replaced to use this macro,
10632 to avoid the hassle of writing XVECTOR (foo)->header.size.
10633 (struct vectorlike_header): New type.
10634 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10635 object, to help avoid aliasing.
10636 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10637 (SUBRP): Likewise, since Lisp_Subr is a special case.
10638 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10639 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10640 (struct Lisp_Hash_Table): Combine first two members into a single
10641 struct vectorlike_header member. All uses of "size" and "next" members
10642 changed to be "header.size" and "header.next".
10643 * buffer.h (struct buffer): Likewise.
10644 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10645 * frame.h (struct frame): Likewise.
10646 * process.h (struct Lisp_Process): Likewise.
10647 * termhooks.h (struct terminal): Likewise.
10648 * window.c (struct save_window_data, struct saved_window): Likewise.
10649 * window.h (struct window): Likewise.
10650 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10651 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10652 * buffer.c (init_buffer_once): Likewise.
10653 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10655 * process.c (Fformat_network_address): Use local var for size,
10658 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10660 Make the Lisp reader and string-to-float more consistent (Bug#8525)
10661 * data.c (atof): Remove decl; no longer used or needed.
10662 (digit_to_number): Move to lread.c.
10663 (Fstring_to_number): Use new string_to_number function, to be
10664 consistent with how the Lisp reader treats infinities and NaNs.
10665 Do not assume that floating-point numbers represent EMACS_INT
10666 without losing information; this is not true on most 64-bit hosts.
10667 Avoid double-rounding errors, by insisting on integers when
10668 parsing non-base-10 numbers, as the documentation specifies.
10669 * lisp.h (string_to_number): New decl, replacing ...
10670 (isfloat_string): Remove.
10671 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
10672 (read1): Do not accept +. and -. as integers; this
10673 appears to have been a coding error. Similarly, do not accept
10674 strings like +-1e0 as floating point numbers. Do not report
10675 overflow for integer overflows unless the base is not 10 which
10676 means we have no simple and reliable way to continue.
10677 Break out the floating-point parsing into a new
10678 function string_to_number, so that Fstring_to_number parses
10679 floating point numbers consistently with the Lisp reader.
10680 (digit_to_number): Move here from data.c. Make it static inline.
10681 (E_CHAR, EXP_INT): Remove, replacing with ...
10682 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10683 (string_to_number): New function, replacing isfloat_string.
10684 This function checks for valid syntax and produces the resulting
10685 Lisp float number too. Rework it so that string-to-number
10686 no longer mishandles examples like "1.0e+". Use strtoumax,
10687 so that overflow for non-base-10 numbers is reported only when
10688 there's no portable and simple way to convert to floating point.
10690 * textprop.c (set_text_properties_1): Rewrite for clarity,
10691 and to avoid GCC warning about integer overflow.
10693 * intervals.h (struct interval): Use EMACS_INT for members
10694 where EMACS_UINT might cause problems. See
10695 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10696 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10697 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10699 (offset_intervals): Tell GCC not to worry about length overflow
10700 when negating a negative length.
10702 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10703 (overrun_check_free): Likewise.
10705 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10706 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10709 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10710 (gnutls_make_error): Rename local to avoid shadowing.
10711 (gnutls_emacs_global_deinit): ifdef out; not used.
10712 (Fgnutls_boot): Use const for pointer to readonly storage.
10713 Comment out unused local. Fix pointer signedness problems.
10715 * lread.c (openp): Don't stuff size_t into an 'int'.
10716 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10717 about possible signed overflow.
10719 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10720 (GDK_KEY_g): Don't define if already defined.
10721 (xg_prepare_tooltip): Avoid pointer signedness problem.
10722 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10724 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10725 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10727 * xfns.c (Fx_window_property): Simplify a bit,
10728 to make a bit faster and to avoid GCC 4.6.0 warning.
10729 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10731 * fns.c (internal_equal): Don't assume size_t fits in int.
10733 * alloc.c (compact_small_strings): Tighten assertion a little.
10735 Replace pEd with more-general pI, and fix some printf arg casts.
10736 * lisp.h (pI): New macro, generalizing old pEd macro to other
10737 conversion specifiers. For example, use "...%"pI"d..." rather
10738 than "...%"pEd"...".
10739 (pEd): Remove. All uses replaced with similar uses of pI.
10740 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
10741 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10742 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10743 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10744 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10745 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10746 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10748 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10749 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10750 * print.c (safe_debug_print, print_object): Likewise.
10751 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10753 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10754 avoiding the 0 flag, which is not portable.
10755 * process.c (Fmake_network_process): Use pI to avoid cast.
10756 * region-cache.c (pp_cache): Likewise.
10757 * xdisp.c (decode_mode_spec): Likewise.
10758 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10759 behavior on 64-bit hosts with printf arg.
10760 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
10761 (x_stop_queuing_selection_requests): Likewise.
10762 (x_get_window_property): Don't truncate byte count to an 'int'
10765 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10766 here, since it parses constructs like leading '-' and spaces,
10767 which are not wanted; and it overflows with large numbers.
10768 Instead, simply match F[0-9]+, which is what is wanted anyway.
10770 * alloc.c: Remove unportable assumptions about struct layout.
10771 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10772 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10773 (allocate_vectorlike, make_pure_vector): Use the new macros,
10774 plus offsetof, to remove unportable assumptions about struct layout.
10775 These assumptions hold on all porting targets that I know of, but
10776 they are not guaranteed, they're easy to remove, and removing them
10777 makes further changes easier.
10779 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10780 This doesn't fix a bug but makes the code clearer.
10781 (string_overrun_cookie): Now const. Use initializers that
10782 don't formally overflow signed char, to avoid warnings.
10783 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10784 can cause Emacs to crash when string overrun checking is enabled.
10785 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10786 multiple of sizeof (EMACS_INT); it need not be, if
10787 alignof(EMACS_INT) < sizeof (EMACS_INT).
10788 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
10790 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
10792 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10794 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10796 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
10797 supposed to be handshaking. (Bug#8556)
10798 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10800 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
10802 * lisp.h (Qdebug): List symbol.
10803 * eval.c (Qdebug): Restore global linkage.
10804 * keyboard.c (debug-on-event): New variable.
10805 (handle_user_signal): Break into debugger when debug-on-event
10806 matches the current signal symbol.
10808 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10810 * alloc.c (check_sblock, check_string_bytes)
10811 (check_string_free_list): Convert to standard C.
10813 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10815 * w32.c (emacs_gnutls_push): Fix typo.
10817 2011-04-25 Eli Zaretskii <eliz@gnu.org>
10819 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10820 "cast to pointer from integer of different size".
10822 Improve doprnt and its use in verror. (Bug#8545)
10823 * doprnt.c (doprnt): Document the set of format control sequences
10824 supported by the function. Use SAFE_ALLOCA instead of always
10827 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10828 is one byte too soon. Don't use xrealloc; instead xfree and
10831 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10833 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10836 * gnutls.c: Renamed global_initialized to
10837 gnutls_global_initialized. Added internals for the
10838 :verify-hostname-error, :verify-error, and :verify-flags
10839 parameters of `gnutls-boot' and documented those parameters in the
10840 docstring. Start callback support.
10841 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10842 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10843 on error. Return error code.
10844 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10845 (emacs_gnutls_read): Likewise.
10846 (Fgnutls_boot): Return handshake error code.
10847 (emacs_gnutls_handle_error): New function.
10848 (wsaerror_to_errno): Likewise.
10850 * w32.h (emacs_gnutls_pull): Add prototype.
10851 (emacs_gnutls_push): Likewise.
10853 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10854 (emacs_gnutls_push): Likewise.
10856 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10858 * process.c (wait_reading_process_output): Check if GnuTLS
10859 buffered some data internally if no FDs are set for TLS
10862 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10863 (LIBS): Link to USER_LIBS.
10864 ($(BLD)/gnutls.$(0)): New target.
10866 2011-04-24 Eli Zaretskii <eliz@gnu.org>
10868 * xdisp.c (handle_single_display_spec): Rename the
10869 display_replaced_before_p argument into display_replaced_p, to
10870 make it consistent with the commentary. Fix typos in the
10873 * textprop.c (syms_of_textprop): Remove dead code.
10874 (copy_text_properties): Delete obsolete commentary about an
10875 interface that was deleted long ago. Fix typos in the description
10878 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10879 to changes in oldXMenu/XMenu.h from 2011-04-16.
10880 <menu_help_message, prev_menu_help_message>: Constify.
10881 (IT_menu_make_room): menu->help_text is now `const char **';
10884 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10885 to changes in oldXMenu/XMenu.h from 2011-04-16.
10886 (struct XMenu): Declare `help_text' `const char **'.
10888 * xfaces.c <Qunspecified>: Make extern again.
10890 * syntax.c: Include sys/types.h before including regex.h, as
10893 * doc.c (get_doc_string): Improve the format passed to `error'.
10895 * doprnt.c (doprnt): Improve commentary.
10897 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10899 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10902 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10903 changes in globals.h immediately force recompilation.
10904 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10905 $(CURDIR)/s/ms-w32.h.
10906 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
10908 * character.c (Fchar_direction): Function deleted.
10909 (syms_of_character): Don't defsubr it.
10910 <char-direction-table>: Deleted.
10912 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10914 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10915 * doprnt.c: Include limits.h.
10916 (SIZE_MAX): New macro.
10917 (doprnt): Return a size_t value. 2nd arg is now size_t.
10918 Many local variables are now size_t instead of int or unsigned.
10919 Improve overflow protection. Support `l' modifier for integer
10920 conversions. Support %l conversion. Don't assume an EMACS_INT
10921 argument for integer conversions and for %c.
10923 * lisp.h (doprnt): Restore prototype.
10925 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10926 $(SRC)/character.h.
10928 * Makefile.in (base_obj): Add back doprnt.o.
10930 * deps.mk (doprnt.o): Add back prerequisites.
10931 (callint.o): Depend on character.h.
10933 * eval.c (internal_lisp_condition_case): Include the handler
10934 representation in the error message.
10935 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10936 when breaking from the loop.
10938 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10940 * callint.c (Fcall_interactively): When displaying error message
10941 about invalid control letter, pass the character's codepoint, not
10942 a pointer to its multibyte form. Improve display of the character
10943 in octal and display also its hex code.
10945 * character.c (char_string): Use %x to display the (unsigned)
10946 codepoint of an invalid character, to avoid displaying a bogus
10949 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10950 `error', not SYMBOL_NAME itself.
10952 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10953 character arguments to `error'.
10955 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10956 to `error' in error message about FINAL_CHAR argument. Make sure
10957 FINAL_CHAR is a character, and use %c when it is passed as
10958 argument to `error'.
10960 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10962 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10964 * w32.c: Include <time.h>.
10965 (sys_localtime): New function.
10967 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
10969 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10971 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
10973 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
10975 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10976 zombies (Bug#8467).
10978 2011-04-19 Eli Zaretskii <eliz@gnu.org>
10980 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10981 gl_state.e_property when gl_state.object is Qt.
10983 * insdel.c (make_gap_larger): Remove limitation of buffer size
10986 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
10988 * xdisp.c (lookup_glyphless_char_display)
10989 (produce_glyphless_glyph): Handle cons cell entry in
10990 glyphless-char-display.
10991 (Vglyphless_char_display): Document it.
10993 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10994 glyphless-char-display.
10996 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
10998 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11000 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11002 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11003 definition for no-X builds.
11005 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
11007 Static checks with GCC 4.6.0 and non-default toolkits.
11009 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11011 * process.c (keyboard_bit_set): Define only if SIGIO.
11012 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11013 (send_process): Repair possible setjmp clobbering.
11015 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11017 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11019 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11021 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11022 Define only if needed.
11024 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11025 by pacifying GCC about it. Maybe it's time to retire it?
11026 * xfaces.c (USG, __TIMEVAL__): Likewise.
11028 * dispextern.h (struct redisplay_interface): Rename param
11029 to avoid shadowing.
11030 * termhooks.h (struct terminal): Likewise.
11031 * xterm.c (xembed_send_message): Likewise.
11033 * insdel.c (make_gap_smaller): Define only if
11034 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11036 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11039 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11040 so that we aren't warned about unused symbols.
11042 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11044 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
11046 * xfns.c (x_real_positions): Mark locals as initialized.
11048 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11050 * xterm.c: Fix problems found by static analysis with other toolkits.
11051 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
11052 (x_dispatch_event): Declare static if USE_GTK, and
11053 define if USE_GTK || USE_X_TOOLKIT.
11054 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
11055 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
11056 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11057 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
11059 * xmenu.c (menu_help_callback): Pointer type fixes.
11060 Use const pointers when pointing at readonly data. Avoid pointer
11061 signedness clashes.
11062 (FALSE): Remove unused macro.
11063 (update_frame_menubar): Remove unused decl.
11065 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11067 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11068 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11069 (single_menu_item): Rename local to avoid shadowing.
11071 * keyboard.c (make_lispy_event): Remove unused local var.
11073 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11074 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11076 * bitmaps: Change bitmaps from unsigned char back to the X11
11077 compatible char. Avoid the old compiler warnings about
11078 out-of-range initializers by using, for example, '\xab' rather
11081 * xgselect.c (xgselect_initialize): Check vs interface
11082 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11084 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11086 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11087 to read-only memory.
11089 * fns.c (vector): Remove; this old hack is no longer needed.
11091 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
11093 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
11095 * xrdb.c (x_load_resources): Omit unused local.
11097 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
11098 (x_window): Rename locals to avoid shadowing.
11099 (USG): Use the kludged USG macro, to pacify gcc.
11101 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
11102 (x_term_init): Remove local to avoid shadowing.
11104 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
11106 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11107 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11109 2011-04-16 Eli Zaretskii <eliz@gnu.org>
11111 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11113 Fix regex.c, syntax.c and friends for buffers > 2GB.
11114 * syntax.h (struct gl_state_s): Declare character position members
11117 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11119 * textprop.c (verify_interval_modification, interval_of):
11120 Declare arguments EMACS_INT.
11122 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11125 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11127 * indent.c (Fvertical_motion): Local variable it_start is now
11130 * regex.c (re_match, re_match_2, re_match_2_internal)
11131 (bcmp_translate, regcomp, regexec, print_double_string)
11132 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11133 (re_compile_pattern, re_exec): Declare arguments and local
11134 variables `size_t' and `ssize_t' and return values `regoff_t', as
11136 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11137 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11138 <compile_stack_type>: `size' and `avail' are now `size_t'.
11140 * regex.h <regoff_t>: Use ssize_t, not int.
11141 (re_search, re_search_2, re_match, re_match_2): Arguments that
11142 specify buffer/string position and length are now ssize_t and
11143 size_t. Return type is regoff_t.
11145 2011-04-16 Ben Key <bkey76@gmail.com>
11147 * nsfont.m: Fixed bugs in ns_get_family and
11148 ns_descriptor_to_entity that were caused by using free to
11149 deallocate memory blocks that were allocated by xmalloc (via
11150 xstrdup). This caused Emacs to crash when compiled with
11151 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11152 --enable-checking=xmallocoverrun). xfree is now used to
11153 deallocate these memory blocks.
11155 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
11157 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11159 emacs_write: Accept and return EMACS_INT for sizes.
11160 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11162 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11163 Accept and return EMACS_INT.
11164 (emacs_gnutls_write): Return the number of bytes written on
11166 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
11167 (emacs_read, emacs_write): Remove check for negative size, as the
11168 Emacs source code has been audited now.
11169 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11170 (emacs_read, emacs_write): Use it.
11171 * process.c (send_process): Adjust to the new signatures of
11172 emacs_write and emacs_gnutls_write. Do not attempt to store
11173 a byte offset into an 'int'; it might overflow.
11174 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
11176 * sound.c: Don't assume sizes fit in 'int'.
11177 (struct sound_device.period_size, alsa_period_size):
11178 Return EMACS_INT, not int.
11179 (struct sound_device.write, vox_write, alsa_write):
11180 Accept EMACS_INT, not int.
11181 (wav_play, au_play): Use EMACS_INT to store sizes and to
11182 record read return values.
11184 2011-04-15 Ben Key <bkey76@gmail.com>
11186 * keyboard.c (Qundefined): Don't declare static since it is used
11188 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11189 static since they are used in nsfont.m.
11191 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11193 * process.c (Qprocessp): Don't declare static.
11194 * lisp.h (Qprocessp): Declare again.
11196 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
11198 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11200 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11202 Improve C-level modularity by making more things 'static'.
11204 Don't publish debugger-only interfaces to other modules.
11205 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11206 (verify_bytepos, count_markers): Move decls to the only modules
11208 * region-cache.h (pp_cache): Likewise.
11209 * window.h (check_all_windows): Likewise.
11210 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11212 * sysdep.c (croak): Now static, if
11213 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11214 * syssignal.h (croak): Declare only if not static.
11216 * alloc.c (refill_memory_reserve): Now static if
11217 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11218 * lisp.h (refill_memory_reserve): Declare only if not static.
11220 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11221 Define only if USE_LUCID.
11223 * xrdb.c (x_customization_string, x_rm_string): Now static.
11225 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11226 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11228 * xdisp.c (draw_row_with_mouse_face): Now static.
11229 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11231 * window.h (check_all_windows): Mark externally visible.
11233 * window.c (window_deletion_count): Now static.
11235 * undo.c: Make symbols static if they're not exported.
11236 (last_undo_buffer, last_boundary_position, pending_boundary):
11239 * textprop.c (interval_insert_behind_hooks): Now static.
11240 (interval_insert_in_front_hooks): Likewise.
11242 * term.c: Make symbols static if they're not exported.
11243 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11244 (max_frame_lines, tty_set_terminal_modes):
11245 (tty_reset_terminal_modes, tty_turn_off_highlight):
11246 (get_tty_terminal): Now static.
11247 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11248 * termhooks.h (term_mouse_moveto): Do not declare if
11249 HAVE_WINDOW_SYSTEM.
11250 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11251 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11253 * sysdep.c: Make symbols static if they're not exported.
11254 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11256 (sigprocmask_set, full_mask): Remove; unused.
11257 (wait_debugging): Mark as visible.
11258 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11259 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11261 * syntax.c (syntax_temp): Define only if !__GNUC__.
11263 * sound.c (current_sound_device, current_sound): Now static.
11265 * search.c (searchbufs, searchbuf_head): Now static.
11267 * scroll.c (scroll_cost): Remove; unused.
11268 * dispextern.h (scroll_cost): Remove decl.
11270 * region-cache.h (pp_cache): Mark as externally visible.
11272 * process.c: Make symbols static if they're not exported.
11273 (process_tick, update_tick, create_process, chan_process):
11274 (Vprocess_alist, proc_buffered_char, datagram_access):
11275 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11276 (deactivate_process): Mark defn as static, as well as decl.
11277 * lisp.h (create_process): Remove decl.
11278 * process.h (chan_process, Vprocess_alist): Remove decls.
11280 * print.c: Make symbols static if they're not exported.
11281 (print_depth, new_backquote_output, being_printed, print_buffer):
11282 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11283 (print_interval, print_number_index, initial_stderr_stream):
11285 * lisp.h (Fprinc): Remove decl.
11286 (debug_output_compilation_hack): Mark as externally visible.
11288 * sysdep.c (croak): Move decl from here to syssignal.h.
11289 * syssignal.h (croak): Put it here, so the API can be checked when
11290 'croak' is called from dissociate_if_controlling_tty.
11292 * minibuf.c: Make symbols static if they're not exported.
11293 (minibuf_save_list, choose_minibuf_frame): Now static.
11294 * lisp.h (choose_minibuf_frame): Remove decl.
11296 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11298 * lread.c: Make symbols static if they're not exported.
11299 (read_objects, initial_obarray, oblookup_last_bucket_number):
11301 (make_symbol): Remove; unused.
11302 * lisp.h (initial_obarray, make_symbol): Remove decls.
11304 * keyboard.c: Make symbols static if they're not exported.
11305 (single_kboard, recent_keys_index, total_keys, recent_keys):
11306 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11307 (this_single_command_key_start, echoing, last_auto_save):
11308 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11309 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11310 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11311 (Vlispy_mouse_stem, double_click_count):
11313 (force_auto_save_soon): Define only if SIGDANGER.
11314 (ignore_mouse_drag_p): Now static if
11315 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11316 (print_help): Remove; unused.
11317 (stop_character, last_timer_event): Mark as externally visible.
11318 * keyboard.h (ignore_mouse_drag_p): Declare only if
11319 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11320 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11321 * lisp.h (echoing): Remove decl.
11322 (force_auto_save_soon): Declare only if SIGDANGER.
11323 * xdisp.c (redisplay_window): Simplify code, to make it more
11324 obvious that ignore_mouse_drag_p is not accessed if !defined
11325 USE_GTK && !defined HAVE_NS.
11327 * intervals.c: Make symbols static if they're not exported.
11328 (merge_properties_sticky, merge_interval_right, delete_interval):
11330 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11332 * insdel.c: Make symbols static if they're not exported.
11333 However, leave prepare_to_modify_buffer alone. It's never
11334 called from outside this function, but that appears to be a bug.
11335 (combine_after_change_list, combine_after_change_buffer):
11336 (adjust_after_replace, signal_before_change): Now static.
11337 (adjust_after_replace_noundo): Remove; unused.
11338 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
11339 (signal_before_change): Remove decls.
11341 * indent.c (val_compute_motion, val_vmotion): Now static.
11343 * image.c: Make symbols static if they're not exported.
11344 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11346 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11347 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11349 * fringe.c (standard_bitmaps): Now static.
11350 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11352 * frame.c: Make symbols static if they're not exported.
11353 (x_report_frame_params, make_terminal_frame): Now static.
11354 (get_frame_param): Now static, unless HAVE_NS.
11355 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11356 (x_get_resource_string): Remove; not used.
11357 * frame.h (make_terminal_frame, x_report_frame_params):
11358 (x_get_resource_string); Remove decls.
11359 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11360 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11362 * font.c, fontset.c: Make symbols static if they're not exported.
11363 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11364 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11365 * font.c (font_close_object): Now static.
11366 * font.h (font_close_object): Remove.
11367 * fontset.c (FONTSET_OBJLIST): Remove.
11368 (free_realized_fontset) #if-0 the body, which does nothing.
11369 (face_suitable_for_char_p): #if-0, as it's never called.
11370 * fontset.h (face_suitable_for_char_p): Remove decl.
11371 * xfaces.c (face_at_string_position):
11372 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
11373 since 0 is always ASCII.
11375 * fns.c (weak_hash_tables): Now static.
11377 * fileio.c: Make symbols static if they're not exported.
11378 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11379 (Vwrite_region_annotation_buffers): Now static.
11381 * eval.c: Make symbols static if they're not exported.
11382 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11383 * lisp.h (backtrace_list): Remove decl.
11385 * emacs.c: Make symbols static if they're not exported.
11386 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11387 (fatal_error_code, fatal_error_signal_hook, standard_args):
11389 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11390 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11391 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11392 * lisp.h (fatal_error_signal_hook): Remove decl.
11393 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11395 * editfns.c: Move a (normally-unused) function to its only use.
11396 * editfns.c, lisp.h (get_operating_system_release): Remove.
11397 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11398 worth the hassle of breaking this out.
11400 * xterm.c: Make symbols static if they're not exported.
11401 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11402 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11403 (x_destroy_window, x_delete_display):
11405 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11406 (x_mouse_leave): Remove; unused.
11407 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11408 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11409 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11411 (x_mouse_leave): Declare only if WINDOWSNT.
11412 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11413 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11416 * ftxfont.c: Make symbols static if they're not exported.
11417 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11419 * font.h (ftxfont_driver): Likewise.
11421 * xfns.c: Make symbols static if they're not exported.
11422 (x_last_font_name, x_display_info_for_name):
11423 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11424 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11425 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11426 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11427 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11428 (last_show_tip_args): Now static.
11429 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11430 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11431 (x_screen_planes): Remove; unused.
11432 * dispextern.h (x_screen_planes): Remove decl.
11434 * dispnew.c: Make symbols static if they're not exported.
11435 * dispextern.h (redraw_garbaged_frames, scrolling):
11436 (increment_row_positions): Remove.
11437 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11438 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11440 (redraw_garbaged_frames): Remove; unused.
11442 * xfaces.c: Make symbols static if they're not exported.
11443 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11445 * xterm.h (defined_color): Remove decls.
11446 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11447 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11448 (menu_face_changed_default, defined_color, free_realized_face):
11449 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11450 (ascii_face_of_lisp_face): Remove; unused.
11452 * xdisp.c: Make symbols static if they're not exported.
11453 * dispextern.h (scratch_glyph_row, window_box_edges):
11454 (glyph_to_pixel_coords, set_cursor_from_row):
11455 (get_next_display_element, set_iterator_to_next):
11456 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11457 (show_mouse_face): Remove decls
11458 * frame.h (message_buf_print): Likewise.
11459 * lisp.h (pop_message, set_message, check_point_in_composition):
11461 * xterm.h (set_vertical_scroll_bar): Likewise.
11462 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11463 (message_buf_print, scratch_glyph_row, displayed_buffer):
11464 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11465 (get_next_display_element, show_mouse_face, window_box_edges):
11466 (frame_to_window_pixel_xy, check_point_in_composition):
11467 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11468 (glyph_to_pixel_coords): Remove; unused.
11470 * dired.c (file_name_completion): Now static.
11472 * dbusbind.c (xd_in_read_queued_messages): Now static.
11474 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11475 * data.c (circular_list_error): Remove.
11477 * commands.h (last_point_position, last_point_position_buffer):
11478 (last_point_position_window): Remove decls.
11479 * keyboard.c: Make these variables static.
11481 * coding.h (coding, code_convert_region, encode_coding_gap):
11483 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11484 (iso_code_class, detect_coding, code_convert_region): Now static.
11485 (encode_coding_gap): Remove; unused.
11487 * chartab.c (chartab_chars, chartab_bits): Now static.
11489 * charset.h (charset_iso_8859_1): Remove decl.
11490 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11493 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11494 * ccl.c (Vccl_program_table): Now static.
11495 (check_ccl_update): Remove; unused.
11497 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11498 * category.h: ... from here.
11499 * category.c (check_category_table, set_category_set): Now static.
11501 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11502 * lisp.h: Remove these decls.
11504 * buffer.c (buffer_count): Remove unused var.
11506 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11507 so that it's not optimized away.
11508 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11509 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11510 exported only to the debugger.
11512 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
11513 * atimer.h (run_all_atimers): Remove; not exported.
11515 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11516 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11517 was inaccessible from Lisp.
11518 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11519 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11521 alloc.c: Import and export fewer symbols, and remove unused items.
11522 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11524 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11525 it's not optimized away by whole-program optimization.
11526 (message_enable_multibyte, free_misc): Remove.
11527 (catchlist, handlerlist, mark_backtrace):
11528 Declare only if BYTE_MARK_STACK.
11529 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11530 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11531 (message_enable_multibyte): Remove decl.
11532 (free_misc, interval_free_list, float_block, float_block_index):
11533 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11534 (cons_free_list, last_marked_index):
11536 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11537 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11538 (mark_backtrace): Define only if BYTE_MARK_STACK.
11539 * xdisp.c (message_enable_multibyte): Now static.
11541 Declare Lisp_Object Q* variables to be 'static' if not exported.
11542 This makes it easier for human readers (and static analyzers)
11543 to see whether these variables are used from other modules.
11544 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11545 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11546 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11547 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11548 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11549 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11550 * xmenu.c, xselect.c:
11551 Declare Q* vars static if they are not used in other modules.
11552 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11553 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11554 Remove decls of unexported vars.
11555 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11557 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11559 Make Emacs functions such as Fatom 'static' by default.
11560 This makes it easier for human readers (and static analyzers)
11561 to see whether these functions can be called from other modules.
11562 DEFUN now defines a static function. To make the function external
11563 so that it can be used in other C modules, use the new macro DEFUE.
11564 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11565 (Finit_image_library):
11566 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11567 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11568 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11569 Remove decls, since these functions are now static.
11570 (Funintern, Fget_internal_run_time): New decls, since these functions
11571 were already external.
11573 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11574 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11575 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11576 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11577 * keyboard.c, keymap.c, lread.c:
11578 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11579 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11580 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11581 Mark functions with DEFUE instead of DEFUN,
11582 if they are used in other modules.
11583 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11584 decls for now-static functions.
11585 * buffer.h (Fdelete_overlay): Remove decl.
11586 * callproc.c (Fgetenv_internal): Mark as internal.
11587 * composite.c (Fremove_list_of_text_properties): Remove decl.
11588 (Fcomposition_get_gstring): New forward static decl.
11589 * composite.h (Fcomposite_get_gstring): Remove decl.
11590 * dired.c (Ffile_attributes): New forward static decl.
11591 * doc.c (Fdocumntation_property): New forward static decl.
11592 * eval.c (Ffetch_bytecode): New forward static decl.
11593 (Funintern): Remove extern decl; now in .h file where it belongs.
11594 * fileio.c (Fmake_symbolic_link): New forward static decl.
11595 * image.c (Finit_image_library): New forward static decl.
11596 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11597 * intervals.h (Fprevious_property_change):
11598 (Fremove_list_of_text_properties): Remove decls.
11599 * keyboard.c (Fthis_command_keys): Remove decl.
11600 (Fcommand_execute): New forward static decl.
11601 * keymap.c (Flookup_key): New forward static decl.
11602 (Fcopy_keymap): Now static.
11603 * keymap.h (Flookup_key): Remove decl.
11604 * process.c (Fget_process): New forward static decl.
11605 (Fprocess_datagram_address): Mark as internal.
11606 * syntax.c (Fsyntax_table_p): New forward static decl.
11607 (skip_chars): Remove duplicate decl.
11608 * textprop.c (Fprevious_property_change): New forward static decl.
11609 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11611 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11612 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11614 * editfns.c (Fformat): Remove unreachable code.
11616 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11618 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11621 2011-04-13 Eli Zaretskii <eliz@gnu.org>
11623 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11624 when at ZV. (Bug#8487)
11626 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11628 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11630 * keyboard.c (parse_tool_bar_item): Likewise.
11631 * sound.c (sound_cleanup, alsa_close): Likewise.
11632 * termcap.c (tgetent): Likewise.
11633 * xfns.c (x_default_font_parameter): Likewise.
11634 * xsettings.c (read_and_apply_settings): Likewise.
11636 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11637 (overrun_check_free): Protoize.
11639 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11641 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11642 since callers should never pass a negative size.
11643 Change the signature to match that of plain 'read' and 'write'; see
11644 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11645 * lisp.h: Update prototypes of emacs_write and emacs_read.
11647 2011-04-11 Eli Zaretskii <eliz@gnu.org>
11649 * xdisp.c (redisplay_window): Don't try to determine the character
11650 position of the scroll margin if the window start point w->startp
11651 is outside the buffer's accessible region. (Bug#8468)
11653 2011-04-10 Eli Zaretskii <eliz@gnu.org>
11655 Fix write-region and its subroutines for buffers > 2GB.
11656 * fileio.c (a_write, e_write): Modify declaration of arguments and
11657 local variables to support buffers larger than 2GB.
11658 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11660 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11661 argument, local variables, and return value.
11663 * lisp.h: Update prototypes of emacs_write and emacs_read.
11665 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11667 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
11669 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11671 Fix more problems found by GCC 4.6.0's static checks.
11673 * xdisp.c (vmessage): Use a better test for character truncation.
11675 * charset.c (load_charset_map): <, not <=, for optimization,
11676 and to avoid potential problems with integer overflow.
11677 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
11678 * casetab.c (set_identity, shuffle): Likewise.
11679 * editfns.c (Fformat): Likewise.
11680 * syntax.c (skip_chars): Likewise.
11682 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11683 This also lets GCC 4.6.0 generate slightly better loop code.
11685 * callint.c (Fcall_interactively): <, not <=, for optimization.
11686 (Fcall_interactively): Count the number of arguments produced,
11687 not the number of arguments given. This is simpler and lets GCC
11688 4.6.0 generate slightly better code.
11690 * ftfont.c: Distingish more carefully between FcChar8 and char.
11691 The previous code passed unsigned char * to a functions like
11692 strlen and xstrcasecmp that expect char *, which does not
11693 conform to the C standard.
11694 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11695 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11696 char * when the C standard requires it.
11698 * keyboard.c (read_char): Remove unused var.
11700 * eval.c: Port to Windows vsnprintf (Bug#8435).
11701 Include <limits.h>.
11702 (SIZE_MAX): Define if the headers do not.
11703 (verror): Do not give up if vsnprintf returns a negative count.
11704 Instead, grow the buffer. This ports to Windows vsnprintf, which
11705 does not conform to C99. Problem reported by Eli Zaretskii.
11706 Also, simplify the allocation scheme, by avoiding the need for
11707 calling realloc, and removing the ALLOCATED variable.
11709 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11711 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11712 But keep the doprint source code for now, as we might revamp it
11713 and use it again (Bug#8435).
11714 * lisp.h (doprnt): Remove.
11715 * Makefile.in (base_obj): Remove doprnt.o.
11716 * deps.mk (doprnt.o): Remove.
11718 error: Print 32- and 64-bit integers portably (Bug#8435).
11719 Without this change, on typical 64-bit hosts error ("...%d...", N)
11720 was used to print both 32- and 64-bit integers N, which relied on
11721 undefined behavior.
11722 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
11723 * lisp.h (error, verror): Mark as printf-like functions.
11724 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11725 Report overflow in size calculations when allocating printf buffer.
11726 Do not truncate output string at its first null byte.
11727 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11728 Truncate the output at a character boundary, since vsnprintf does not
11730 * charset.c (check_iso_charset_parameter): Convert internal
11731 character to string before calling 'error', since %c now has the
11733 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11734 overflow when computing char to be passed to 'error'. Do not
11735 pass Lisp_Object to 'error'; pass the integer instead.
11736 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11737 formatted with plain %d.
11739 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11741 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11743 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11745 * xterm.c (x_catch_errors): Remove duplicate declaration.
11747 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11749 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11751 2011-04-10 Jim Meyering <meyering@redhat.com>
11753 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11754 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11755 return ssize_t not "int", and use size_t as the buffer length.
11756 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11757 * gnutls.h: Update declarations.
11758 * process.c (read_process_output): Use ssize_t, to match.
11759 (send_process): Likewise.
11761 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
11763 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11765 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
11767 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11768 Use unsigned char, to match FcChar8 type definition.
11770 * xterm.c (handle_one_xevent):
11771 * xmenu.c (create_and_show_popup_menu):
11772 * xselect.c (x_decline_selection_request)
11773 (x_reply_selection_request): Avoid type-punned deref of X events.
11775 2011-04-09 Eli Zaretskii <eliz@gnu.org>
11777 Fix some uses of `int' instead of EMACS_INT.
11778 * search.c (string_match_1, fast_string_match)
11779 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11780 (scan_buffer, find_next_newline_no_quit)
11781 (find_before_next_newline, search_command, Freplace_match)
11782 (Fmatch_data): Make some `int' variables be EMACS_INT.
11784 * xdisp.c (display_count_lines): 3rd argument and return value now
11785 EMACS_INT. All callers changed.
11786 (pint2hrstr): Last argument is now EMACS_INT.
11788 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11789 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11790 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11791 (decode_coding_utf_16, decode_coding_emacs_mule)
11792 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11793 (decode_coding_ccl, decode_coding_charset)
11794 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11795 (decode_coding_iso_2022, decode_coding_emacs_mule)
11796 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11797 <char_offset, last_offset>: Declare EMACS_INT.
11798 (encode_coding_utf_8, encode_coding_utf_16)
11799 (encode_coding_emacs_mule, encode_invocation_designation)
11800 (encode_designation_at_bol, encode_coding_iso_2022)
11801 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11802 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11804 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11805 (encode_invocation_designation): Last argument P_NCHARS is now
11807 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11808 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11810 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11813 * ccl.c (Fccl_execute_on_string): Declare some variables
11816 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
11818 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11820 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11822 * process.c (Fformat_network_address): Doc fix.
11824 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11826 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
11828 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
11830 * keyboard.c (read_char): Call Lisp function help-form-show,
11831 instead of using internal_with_output_to_temp_buffer.
11832 (Qhelp_form_show): New var.
11833 (syms_of_keyboard): Use DEFSYM macro.
11835 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11837 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11839 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
11841 * process.c (Flist_processes): Remove to Lisp.
11842 (list_processes_1): Delete.
11844 2011-04-06 Eli Zaretskii <eliz@gnu.org>
11846 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11848 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11850 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
11852 Fix more problems found by GCC 4.6.0's static checks.
11854 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11856 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11858 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
11860 * xdisp.c (vmessage): Mark as a printf-like function.
11862 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11864 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11866 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11867 printf-like functions.
11868 (tiff_load): Add casts to remove these marks before passing them
11869 to system-supplied API.
11871 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11873 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11874 This avoids several warnings with gcc -Wstrict-overflow.
11875 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11876 directly, rather than having caller test rule sign. This avoids
11877 some unnecessary tests.
11878 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11879 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11880 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
11882 * xfont.c (xfont_text_extents): Remove var that was set but not used.
11883 (xfont_open): Avoid unnecessary tests.
11885 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11887 * composite.h, composite.c (composition_gstring_put_cache):
11888 Use EMACS_INT, not int, for length.
11890 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11891 breaking out part of COMPOSITION_DECODE_RULE.
11892 (COMPOSITION_DECODE_RULE): Use it.
11893 * composite.c (get_composition_id): Remove unused local vars,
11894 by using the new macro.
11896 * textprop.c (set_text_properties_1): Change while to do-while,
11897 since the condition is always true at first.
11899 * intervals.c (graft_intervals_into_buffer): Mark var as used.
11900 (interval_deletion_adjustment): Return unsigned value.
11903 * process.c (list_processes_1, create_pty, read_process_output):
11904 (exec_sentinel): Remove vars that were set but not used.
11905 (create_pty): Remove unnecessary "volatile"s.
11906 (Fnetwork_interface_info): Avoid possibility of int overflow.
11907 (read_process_output): Do adaptive read buffering even if carryover.
11908 (read_process_output): Simplify nbytes computation if buffered.
11910 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11912 * syntax.c (scan_words): Remove var that was set but not used.
11913 (update_syntax_table): Use unsigned instead of int.
11915 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
11916 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
11917 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
11919 * print.c (print_error_message): Avoid int overflow.
11921 * font.c (font_list_entities): Redo for clarity,
11922 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11924 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
11925 (font_score): Avoid potential overflow in diff calculation.
11927 * fns.c (substring_both): Remove var that is set but not used.
11928 (sxhash): Redo loop for clarity and to avoid wraparound warning.
11930 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11932 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11933 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11934 can always succeed if overflow has undefined behavior.
11936 * search.c (boyer_moore, wordify): Remove vars set but not used.
11937 (wordify): Omit three unnecessary tests.
11939 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11940 All callers changed. This avoids the need for an unused var.
11942 * casefiddle.c (casify_region): Remove var that is set but not used.
11944 * dired.c (file_name_completion): Remove var that is set but not used.
11946 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11948 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
11949 (Finsert_file_contents): Remove unnecessary code checking fd.
11951 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11952 Check for integer overflow on size calculations.
11954 * buffer.c (Fprevious_overlay_change): Remove var that is set
11957 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11958 Remove vars that are set but not used.
11959 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
11960 (timer_check_2): Mark vars as initialized.
11962 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11964 * image.c (lookup_image): Remove var that is set but not used.
11965 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
11967 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11968 that are set but not used.
11970 * xfns.c (make_invisible_cursor): Don't return garbage
11971 if XCreateBitmapFromData fails (Bug#8410).
11973 * xselect.c (x_get_local_selection, x_handle_property_notify):
11974 Remove vars that are set but not used.
11976 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
11977 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
11979 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11980 Remove var that is set but not used.
11981 (scroll_bar_windows_size): Now size_t, not int.
11982 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11983 Check for overflow.
11985 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11986 (map_tty_color) [!defined MSDOS]: Likewise.
11988 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11990 * coding.c: Remove vars that are set but not used.
11991 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11992 All callers changed.
11993 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11994 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11995 (decode_coding_charset): Remove vars that are set but not used.
11997 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11998 that is set but not used.
12000 * print.c (print_object): Remove var that is set but not used.
12002 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
12003 The gnulib version avoids calling malloc in the usual case,
12004 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12005 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12006 * filelock.c (current_lock_owner): Likewise.
12007 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12008 * sysdep.c: Include allocator.h, careadlinkat.h.
12009 (emacs_no_realloc_allocator): New static constant.
12010 (emacs_readlink): New function.
12011 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12012 ../lib/careadlinkat.h.
12014 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12016 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12017 first non-nil return value).
12019 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12021 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12022 if not defined (Bug#8403).
12024 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
12026 * xdisp.c (display_count_lines): Remove parameter `start',
12027 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12028 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12029 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12030 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12031 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12032 and thereabouts. All callers changed.
12033 (get_per_char_metric): Remove parameter `f', unused since
12034 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12036 2011-04-02 Jim Meyering <meyering@redhat.com>
12038 do not dereference NULL upon failed strdup
12039 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12040 (ns_get_family): Likewise.
12042 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
12044 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12046 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12048 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12051 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12053 Add lexical binding.
12055 * window.c (Ftemp_output_buffer_show): New fun.
12056 (Fsave_window_excursion):
12057 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12059 * lread.c (lisp_file_lexically_bound_p): New function.
12060 (Fload): Bind Qlexical_binding.
12061 (readevalloop): Remove `evalfun' arg.
12062 Bind Qinternal_interpreter_environment.
12063 (Feval_buffer): Bind Qlexical_binding.
12064 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12066 (syms_of_lread): Declare `lexical-binding'.
12068 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12070 * keyboard.c (eval_dyn): New fun.
12071 (menu_item_eval_property): Use it.
12073 * image.c (parse_image_spec): Use Ffunctionp.
12075 * fns.c (concat, mapcar1): Accept byte-code-functions.
12077 * eval.c (Fsetq): Handle lexical vars.
12078 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12079 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12080 (FletX, Flet): Obey lexical binding.
12081 (Fcommandp): Handle closures.
12082 (Feval): New `lexical' arg.
12083 (eval_sub): New function extracted from Feval. Use it almost
12084 everywhere where Feval was used. Look up vars in lexical env.
12086 (Ffunctionp): Move from subr.el.
12087 (Ffuncall): Handle closures.
12088 (apply_lambda): Remove `eval_flags'.
12089 (funcall_lambda): Handle closures and new byte-code-functions.
12090 (Fspecial_variable_p): New function.
12091 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12092 but without exporting it to Lisp.
12094 * doc.c (Fdocumentation, store_function_docstring):
12095 * data.c (Finteractive_form): Handle closures.
12097 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12100 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12102 (exec_byte_code): New function extracted from Fbyte_code to handle new
12103 calling convention for byte-code-functions. Add new byte-codes.
12105 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
12107 * alloc.c (Fmake_symbol): Init new `declared_special' field.
12109 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
12111 * xdisp.c (redisplay_internal): Fix prototype.
12113 2011-03-31 Eli Zaretskii <eliz@gnu.org>
12115 * xdisp.c (SCROLL_LIMIT): New macro.
12116 (try_scrolling): Use it when setting scroll_limit.
12117 Limit scrolling to 100 screen lines.
12118 (redisplay_window): Even when falling back on "recentering",
12119 position point in the window according to scroll-conservatively,
12120 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12122 (try_scrolling): When point is above the window, allow searching
12123 as far as scroll_max, or one screenful, to compute vertical
12124 distance from PT to the scroll margin position. This prevents
12125 try_scrolling from unnecessarily failing when
12126 scroll-conservatively is set to a value slightly larger than the
12127 window height. Clean up the case of PT below the margin at bottom
12128 of window: scroll_max can no longer be INT_MAX. When aggressive
12129 scrolling is in use, don't let point enter the opposite scroll
12130 margin as result of the scroll.
12131 (syms_of_xdisp) <scroll-conservatively>: Document the
12132 threshold of 100 lines for never-recentering scrolling.
12134 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
12136 * dispextern.h (move_it_by_lines):
12137 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12138 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12139 (message_log_check_duplicate): Remove parameters `prev_bol' and
12140 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12141 (redisplay_internal): Remove parameter `preserve_echo_area',
12142 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12144 * indent.c (Fvertical_motion):
12145 * window.c (window_scroll_pixel_based, Frecenter):
12146 Don't pass `need_y_p' to `move_it_by_lines'.
12148 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12150 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12151 steal a few bits to be more compact.
12152 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12153 Remove unneeded casts.
12155 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12157 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12159 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12160 binding" message (bug#7967).
12162 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12164 Fix more problems found by GCC 4.6.0's static checks.
12166 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12167 Remove unused local var.
12169 * editfns.c (Fmessage_box): Remove unused local var.
12171 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12172 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12173 Omit unused local vars.
12174 * window.c (shrink_windows): Omit unused local var.
12175 * menu.c (digest_single_submenu): Omit unused local var.
12176 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12177 Omit unused local var.
12179 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12180 Don't assume string length fits in int.
12181 (keyremap_step, read_key_sequence): Use size_t for sizes.
12182 (read_key_sequence): Don't check last_real_key_start redundantly.
12184 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12185 instead of alloca (Bug#8344).
12187 * eval.c (Fbacktrace): Don't assume nargs fits in int.
12188 (Fbacktrace_frame): Don't assume nframes fits in int.
12190 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12192 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12195 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12197 * cm.c (calccost): Turn while-do into do-while, for clarity.
12199 * keyboard.c (syms_of_keyboard): Use the same style as later
12200 in this function when indexing through an array. This also
12201 works around GCC bug 48267.
12203 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12205 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12207 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12208 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12210 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12211 This avoids undefined behavior on integer overflow, and is a bit
12212 more convenient anyway since it is compared to a size_t variable.
12214 Variadic C functions now count arguments with size_t, not int.
12215 This avoids an unnecessary limitation on 64-bit machines, which
12216 caused (substring ...) to crash on large vectors (Bug#8344).
12217 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12218 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
12219 All variadic functions and their callers changed accordingly.
12220 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12221 * data.c (arith_driver, float_arith_driver): Likewise.
12222 * editfns.c (general_insert_function): Likewise.
12223 * eval.c (struct backtrace.nargs, interactive_p)
12224 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12225 (funcall_lambda, mark_backtrace): Likewise.
12226 * fns.c (concat): Likewise.
12227 * frame.c (x_set_frame_parameters): Likewise.
12228 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12229 0 if not found, not -1. All callers changed.
12231 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12232 (stack_copy_size): Now size_t, not int.
12233 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12235 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
12237 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12238 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12239 All callers changed.
12241 * lisp.h (multibyte_char_to_unibyte):
12242 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12243 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12244 * character.h (CHAR_TO_BYTE8):
12245 * cmds.c (internal_self_insert):
12246 * editfns.c (general_insert_function):
12247 * keymap.c (push_key_description):
12248 * search.c (Freplace_match):
12249 * xdisp.c (message_dolog, set_message_1): All callers changed.
12251 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12253 * keyboard.c (safe_run_hook_funcall): New function.
12254 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12255 don't set the hook to nil, but remove the offending function instead.
12256 (Qcommand_hook_internal): Remove, unused.
12257 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12258 Vcommand_hook_internal.
12260 * eval.c (enum run_hooks_condition): Remove.
12261 (funcall_nil, funcall_not): New functions.
12262 (run_hook_with_args): Call each function through a `funcall' argument.
12263 Remove `cond' argument, now redundant.
12264 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12265 (Frun_hook_with_args_until_failure): Adjust accordingly.
12266 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12268 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
12270 * dispextern.h (string_buffer_position): Remove declaration.
12272 * print.c (strout): Remove parameter `multibyte', unused since
12273 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12275 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12276 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12277 All callers changed.
12279 * w32.c (_wsa_errlist): Use braces for struct initializers.
12281 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12282 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12283 All callers changed.
12284 (string_buffer_position): Likewise. Also, make static (it's never
12285 used outside xdisp.c).
12286 (cursor_row_p): Remove parameter `w', unused since
12287 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12288 (decode_mode_spec): Remove parameter `precision', introduced during
12289 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12290 All callers changed.
12292 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12294 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12296 2011-03-27 Anders Lindgren <andlind@gmail.com>
12298 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12299 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12300 (ns_update_auto_hide_menu_bar): New functions.
12301 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12302 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12303 ns_constrain_all_frames.
12304 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12305 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12307 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12309 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12311 2011-03-27 Glenn Morris <rgm@gnu.org>
12313 * syssignal.h: Replace RETSIGTYPE with void.
12314 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12315 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12316 Replace SIGTYPE with void everywhere.
12317 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12318 * s/template.h (SIGTYPE): Remove commented out definition.
12320 2011-03-26 Eli Zaretskii <eliz@gnu.org>
12322 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12323 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12325 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
12327 * w32.c (read_unc_volume): Use parameter `henum', instead of
12328 global variable `wget_enum_handle'.
12330 * keymap.c (describe_vector): Remove parameters `indices' and
12331 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12332 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12334 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12336 * keyboard.c (timer_check): Remove parameter `do_it_now',
12337 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12338 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12339 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12341 * keyboard.c (read_char):
12342 * w32menu.c (w32_menu_display_help):
12343 * xmenu.c (show_help_event, menu_help_callback):
12344 Adjust calls to `show_help_echo'.
12346 * gtkutil.c (xg_maybe_add_timer):
12347 * keyboard.c (readable_events):
12348 * process.c (wait_reading_process_output):
12349 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12351 * insdel.c (adjust_markers_gap_motion):
12352 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12353 (gap_left, gap_right): Don't call it.
12355 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
12357 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12358 incurred during fontification.
12360 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12362 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12363 (DEFVAR_PER_BUFFER): Don't pass it.
12365 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12366 (scrolling_window): Don't pass it.
12368 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12370 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12372 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12374 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12375 of variables specific to SELinux and computation of `encoded_absname'.
12377 * image.c (XPutPixel): Remove unused variable `height'.
12379 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12381 * unexw32.c (get_section_info): Remove unused variable `section'.
12383 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12384 (system_process_attributes): Remove unused variable `sess'.
12385 (sys_read): Remove unused variable `err'.
12387 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12388 (w32_wnd_proc): Remove unused variable `isdead'.
12389 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12390 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12391 (x_create_tip_frame): Remove unused variable `tem'.
12393 * w32inevt.c (w32_console_read_socket):
12394 Remove unused variable `no_events'.
12396 * w32term.c (x_draw_composite_glyph_string_foreground):
12397 Remove unused variable `width'.
12399 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
12401 * w32term.c (x_set_glyph_string_clipping):
12402 Don't pass uninitialized region to CombineRgn.
12404 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
12406 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12407 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12408 (Fx_close_connection): Remove unused variable `i'.
12410 * w32font.c (w32font_draw): Return number of glyphs.
12411 (w32font_open_internal): Remove unused variable `i'.
12412 (w32font_driver): Add missing initializer.
12414 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12415 (fill_in_menu): Remove unused variable `items_added'.
12417 * w32term.c (last_mouse_press_frame): Remove static global variable.
12418 (w32_clip_to_row): Remove unused variable `f'.
12419 (x_delete_terminal): Remove unused variable `i'.
12421 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12422 (NOTHING): Remove unused static global variable.
12423 (uniscribe_check_otf): Remove unused variable `table'.
12424 (uniscribe_font_driver): Add missing initializers.
12426 2011-03-23 Julien Danjou <julien@danjou.info>
12428 * term.c (Fsuspend_tty, Fresume_tty):
12429 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12430 * window.c (temp_output_buffer_show):
12431 * insdel.c (signal_before_change):
12432 * frame.c (Fhandle_switch_frame):
12433 * fileio.c (Fdo_auto_save):
12434 * emacs.c (Fkill_emacs):
12435 * editfns.c (save_excursion_restore):
12436 * cmds.c (internal_self_insert):
12437 * callint.c (Fcall_interactively):
12438 * buffer.c (Fkill_all_local_variables):
12439 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12441 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
12442 unconditionally since it does the check itself.
12444 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
12446 Fix more problems found by GCC 4.5.2's static checks.
12448 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12449 the first time through the loop, since we know p0 < p1 then.
12450 This also avoids a gcc -Wstrict-overflow warning.
12452 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12453 leading to a memory leak, possible in functions like
12454 load_charset_map_from_file that can allocate an unbounded number
12455 of objects (Bug#8318).
12457 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12458 that could (at least in theory) be that large.
12460 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12461 This is less likely to overflow, and avoids undefined behavior if
12462 overflow does occur. All callers changed. Use strtoul to scan
12463 for the unsigned long integer.
12464 (pint2hrstr): Simplify and tune code slightly.
12465 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
12467 * scroll.c (do_scrolling): Work around GCC bug 48228.
12468 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12470 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12471 This also avoids a warning with gcc -Wstrict-overflow.
12472 (validate_x_resource_name): Simplify count usage.
12473 This also avoids a warning with gcc -Wstrict-overflow.
12475 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12478 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
12480 * process.c (Fmake_network_process): Use socklen_t, not int,
12481 where POSIX says socklen_t is required in portable programs.
12482 This fixes a porting bug on hosts like 64-bit HP-UX, where
12483 socklen_t is wider than int (Bug#8277).
12484 (Fmake_network_process, server_accept_connection):
12485 (wait_reading_process_output, read_process_output):
12488 * process.c: Rename or move locals to avoid shadowing.
12489 (list_processes_1, Fmake_network_process):
12490 (read_process_output_error_handler, exec_sentinel_error_handler):
12491 Rename or move locals.
12492 (Fmake_network_process): Define label "retry_connect" only if needed.
12493 (Fnetwork_interface_info): Fix pointer signedness.
12494 (process_send_signal): Add cast to avoid pointer signedness problem.
12495 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
12496 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
12498 Make tparam.h and terminfo.c consistent.
12499 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12500 Include tparam.h instead, since it declares them.
12501 * cm.h (PC): Remove extern decl; tparam.h now does this.
12502 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12503 * terminfo.c: Include tparam.h, to check interfaces.
12504 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12505 (tparam): Adjust signature to match interface in tparam.h;
12506 this removes some undefined behavior. Check that outstring and len
12507 are zero, which they always are with Emacs.
12508 * tparam.h (PC, BC, UP): New extern decls.
12510 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
12511 (xftfont_open): Rename locals to avoid shadowing.
12513 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
12514 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12515 (OTF_TAG_SYM): Omit macro if not needed.
12516 (ftfont_list): Remove unused local.
12517 (get_adstyle_property, ftfont_pattern_entity):
12518 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12519 Rename locals to avoid shadowing.
12521 * xfont.c (xfont_list_family): Mark var as initialized.
12523 * xml.c (make_dom): Now static.
12525 * composite.c (composition_compute_stop_pos): Rename local to
12527 (composition_reseat_it): Remove unused locals.
12528 (find_automatic_composition, composition_adjust_point): Likewise.
12529 (composition_update_it): Mark var as initialized.
12530 (find_automatic_composition): Mark vars as initialized,
12531 with a FIXME (Bug#8290).
12533 character.h: Rename locals to avoid shadowing.
12534 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12535 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12536 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12537 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12538 to avoid shadowing.
12540 * textprop.c (property_change_between_p): Remove; unused.
12542 * intervals.c (interval_start_pos): Now static.
12544 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12546 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12547 Rename locals to avoid shadowing.
12549 * sound.c (wav_play, au_play, Fplay_sound_internal):
12550 Fix pointer signedness.
12551 (alsa_choose_format): Remove unused local var.
12552 (wav_play): Initialize a variable to 0, to prevent undefined
12553 behavior (Bug#8278).
12555 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12557 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12559 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12560 clobbering (Bug#8298).
12561 * sysdep.c (sys_subshell): Likewise.
12562 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
12564 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12565 This should get cleaned up, so that child_setup has the
12566 same signature on all platforms.
12568 * callproc.c (call_process_cleanup): Now static.
12569 (relocate_fd): Rename locals to avoid shadowing.
12571 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
12573 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12574 not to be necessary, and produces flickering.
12576 2011-03-20 Glenn Morris <rgm@gnu.org>
12578 * config.in: Remove file.
12580 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
12582 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12583 are now in src/globals.h.
12584 (syms_of_minibuf): Remove spurious & from previous change.
12586 2011-03-20 Leo Liu <sdl.web@gmail.com>
12588 * minibuf.c (completing-read-function): New variable.
12589 (completing-read-default): Rename from completing-read.
12590 (completing-read): Call completing-read-function.
12592 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
12594 * xfaces.c (Fx_load_color_file):
12595 Read color file from absolute filename (bug#8250).
12597 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
12599 * makefile.w32-in: Update dependencies.
12601 2011-03-17 Eli Zaretskii <eliz@gnu.org>
12603 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12605 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12607 Fix more problems found by GCC 4.5.2's static checks.
12609 * process.c (make_serial_process_unwind, send_process_trap):
12610 (sigchld_handler): Now static.
12612 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12613 That way, the code declares only the vars that it needs.
12614 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12615 * s/cygwin.h (PTY_ITERATION): Likewise.
12616 * s/darwin.h (PTY_ITERATION): Likewise.
12617 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12619 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12620 * process.c (allocate_pty): Don't declare stb unless it's needed.
12622 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
12623 (CONSTANTLIM): Remove; unused.
12624 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12625 Define only if needed.
12627 * unexelf.c (unexec): Name an expression,
12628 to avoid gcc -Wbad-function-cast warning.
12629 Use a different way to cause a compilation error if anyone uses
12630 n rather than nn, a way that does not involve shadowing.
12631 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
12633 * deps.mk (unexalpha.o): Remove; unused.
12635 New file unexec.h, the (simple) interface for unexec (Bug#8267).
12636 * unexec.h: New file.
12637 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12638 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12639 Depend on unexec.h.
12640 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12641 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12642 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
12643 Change as necessary to match prototype in unexec.h.
12645 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12647 (back_comment, skip_chars): Mark vars as initialized.
12649 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12650 Rename locals to avoid shadowing.
12652 * lread.c (read1): Rewrite so as not to use empty "else".
12653 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
12655 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12657 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12658 warning when compiling print.c.
12660 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12661 instead of using an uninitialized var.
12662 (font_sort_entities): Mark var as initialized.
12664 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12666 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12667 pointers to constants.
12668 (font_parse_fcname): Remove unused vars.
12669 (font_delete_unmatched): Now static.
12670 (font_get_spec): Remove; unused.
12671 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12672 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12673 Rename or move locals to avoid shadowing.
12675 * fns.c (require_nesting_list, require_unwind): Now static.
12676 (Ffillarray): Rename locals to avoid shadowing.
12678 * floatfns.c (domain_error2): Define only if needed.
12679 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
12681 * alloc.c (mark_backtrace): Move decl from here ...
12682 * lisp.h: ... to here, so that it can be checked.
12684 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
12685 (Fdefvar): Rewrite so as not to use empty "else".
12686 (lisp_indirect_variable): Name an expression,
12687 to avoid gcc -Wbad-function-cast warning.
12688 (Fdefvar): Rename locals to avoid shadowing.
12690 * callint.c (quotify_arg, quotify_args): Now static.
12691 (Fcall_interactively): Rename locals to avoid shadowing.
12692 Use const pointer when appropriate.
12694 * lisp.h (get_system_name, get_operating_system_release):
12695 Move decls here, to check interfaces.
12696 * process.c (get_operating_system_release): Move decl to lisp.h.
12697 * xrdb.c (get_system_name): Likewise.
12698 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12699 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12700 some of which prompt warnings from gcc -Wbad-function-cast.
12701 (Fformat_time_string, Fencode_time, Finsert_char):
12702 (Ftranslate_region_internal, Fformat):
12703 Rename or remove local vars to avoid shadowing.
12704 (Ftranslate_region_internal): Mark var as initialized.
12706 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12709 * lisp.h (eassert): Check that the argument compiles, even if
12710 ENABLE_CHECKING is not defined.
12712 * data.c (Findirect_variable): Name an expression, to avoid
12713 gcc -Wbad-function-cast warning.
12714 (default_value, arithcompare, arith_driver, arith_error): Now static.
12715 (store_symval_forwarding): Rename local to avoid shadowing.
12716 (Fmake_variable_buffer_local, Fmake_local_variable):
12717 Mark variables as initialized.
12718 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
12720 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
12721 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12722 Rename locals to avoid shadowing.
12723 (mark_stack): Move local variables into the #ifdef region where
12725 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12726 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12728 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12729 (GC_STRING_CHARS): Remove; not used.
12730 (Fmemory_limit): Cast sbrk's returned value to char *.
12732 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12733 avoids undefined behavior in theory.
12735 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12737 Use functions, not macros, for up- and down-casing (Bug#8254).
12738 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12739 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12740 to use the following functions instead of these macros.
12741 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12742 EMACS_INT, since callers assume the returned value fits in int.
12743 (upcase1): Likewise, for UPCASE_TABLE.
12744 (uppercasep, lowercasep, upcase): New static inline functions.
12745 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
12746 the race-condition problem in the old DOWNCASE.
12748 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12749 Rename locals to avoid shadowing.
12750 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
12751 (regex_compile, re_search_2, re_match_2_internal):
12752 Remove unused local vars.
12753 (FREE_VAR): Rewrite so as not to use empty "else",
12754 which gcc can warn about.
12755 (regex_compile, re_match_2_internal): Mark locals as initialized.
12756 (RETALLOC_IF): Define only if needed.
12757 (WORDCHAR_P): Likewise. This one is never needed, but is used
12758 only in a comment talking about a compiler bug, so put inside
12759 the #if 0 of that comment.
12760 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12761 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12764 * search.c (boyer_moore): Rename locals to avoid shadowing.
12765 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12766 (PREV_CHAR_BOUNDARY): Likewise.
12768 * search.c (simple_search): Remove unused var.
12770 * dired.c (compile_pattern): Move decl from here ...
12771 * lisp.h: ... to here, so that it can be checked.
12772 (struct re_registers): New forward decl.
12774 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12776 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12778 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12779 Rename locals to avoid shadowing.
12780 (Fvertical_motion): Mark locals as initialized.
12782 * casefiddle.c (casify_object, casify_region): Now static.
12783 (casify_region): Mark local as initialized.
12785 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12787 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12788 New macros, so that the caller can use some names other than
12789 gcpro1, gcpro2, etc.
12790 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12792 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12793 argument, for consistency with GCPRO2_VAR, etc: it is now the
12794 prefix of the variable, not the variable itself. All uses
12796 * dired.c (directory_files_internal, file_name_completion):
12797 Rename locals to avoid shadowing.
12799 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12800 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12801 dired.c's scmp function, had undefined behavior.
12802 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12803 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12804 * buffer.h: ... to here, because these macros use current_buffer,
12805 and the new implementation with inline functions needs to have
12806 current_buffer in scope now, rather than later when the macros
12808 (downcase, upcase1): New static inline functions.
12809 (DOWNCASE, UPCASE1): Reimplement using these functions.
12810 This avoids undefined behavior in expressions like
12811 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12812 from race conditions in accessing the global variables
12813 case_temp1 and case_temp2.
12814 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12815 * lisp.h (case_temp1, case_temp2): Remove their decls.
12816 * character.h (ASCII_CHAR_P): Move from here ...
12817 * lisp.h: ... to here, so that the inline functions mentioned
12818 above can use them.
12820 * dired.c (directory_files_internal_unwind): Now static.
12822 * fileio.c (file_name_as_directory, directory_file_name):
12823 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12825 (file_name_as_directory): Use const pointers when appropriate.
12826 (Fexpand_file_name): Likewise. In particular, newdir might
12827 point at constant storage, so make it a const pointer.
12828 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
12829 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12831 (Fset_file_times, Finsert_file_contents, auto_save_error):
12832 Rename locals to avoid shadowing.
12834 * minibuf.c (choose_minibuf_frame_1): Now static.
12835 (Ftry_completion, Fall_completions): Rename or remove locals
12836 to avoid shadowing.
12838 * marker.c (bytepos_to_charpos): Remove; unused.
12840 * lisp.h (verify_bytepos, count_markers): New decls,
12841 so that gcc does not warn that these functions aren't declared.
12843 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12844 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
12845 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
12846 (copy_text): Remove unused local var.
12848 * filelock.c (within_one_second): Now static.
12849 (lock_file_1): Rename local to avoid shadowing.
12851 * buffer.c (fix_overlays_before): Mark locals as initialized.
12852 (fix_start_end_in_overlays): Likewise. This function should be
12853 simplified by using pointers-to-pointers, but that's a different
12855 (switch_to_buffer_1): Now static.
12856 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12857 (report_overlay_modification): Rename locals to avoid shadowing.
12859 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
12860 Fix pointer signedness issue.
12861 (sys_subshell): Mark local as volatile if checking for lint,
12862 to suppress a gcc -Wclobbered warning that does not seem to be right.
12863 (MAXPATHLEN): Define only if needed.
12865 * process.c (serial_open, serial_configure): Move decls from here ...
12866 * systty.h: ... to here, so that they can be checked.
12868 * fns.c (get_random, seed_random): Move extern decls from here ...
12869 * lisp.h: ... to here, so that they can be checked.
12871 * sysdep.c (reset_io): Now static.
12872 (wait_for_termination_signal): Remove; unused.
12874 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12875 (copy_keymap_item, append_key, push_text_char_description):
12877 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
12878 (DENSE_TABLE_SIZE): Remove; unused.
12879 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12880 (describe_map_tree):
12881 Rename locals to avoid shadowing.
12883 * keyboard.c: Declare functions static if they are not used elsewhere.
12884 (echo_char, echo_dash, cmd_error, top_level_2):
12885 (poll_for_input, handle_async_input): Now static.
12886 (read_char, kbd_buffer_get_event, make_lispy_position):
12887 (make_lispy_event, make_lispy_movement, apply_modifiers):
12888 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12889 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12890 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
12891 (read_key_sequence, read_char): Mark locals as initialized.
12892 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
12894 * keyboard.h (make_ctrl_char): New decl.
12895 (mark_kboards): Move decl here ...
12896 * alloc.c (mark_kboards): ... from here.
12898 * lisp.h (force_auto_save_soon): New decl.
12900 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
12901 (DEFINE_DUMMY_FUNCTION): New macro.
12902 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12904 (main): Add casts to avoid warnings
12905 if GCC considers string literals to be constants.
12907 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12909 * dbusbind.c: Pointer signedness fixes.
12910 (xd_signature, xd_append_arg, xd_initialize):
12911 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12912 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12913 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12914 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12916 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12917 if GCC considers string literals to be constants.
12918 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
12920 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12922 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12923 (print_preprocess, print_object): New macro to fix last change.
12925 * print.c (print_preprocess): Don't forget font objects.
12927 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
12929 * emacs.c (USAGE3): Doc fixes.
12931 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12933 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12936 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
12938 * lisp.h (VWindow_system, Qfile_name_history):
12939 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12940 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12941 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12943 * w32select.c: Don't #include "keyboard.h".
12944 (run_protected): Add extern declaration for waiting_for_input.
12946 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12947 * w32console.c (detect_input_pending, read_input_pending)
12948 (encode_terminal_code):
12949 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12950 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12951 (w32_system_caret_y, Qfile_name_history):
12952 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12953 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12954 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12955 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12956 * w32proc.c (Qlocal, report_file_error):
12957 * w32term.c (Vwindow_system, updating_frame):
12958 * w32uniscribe.c (initialized, uniscribe_font_driver):
12959 Remove unneeded extern declarations.
12961 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
12963 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
12965 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
12967 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12968 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12969 These macros can no longer be used for assignment.
12971 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12972 Assign struct members directly, instead of using BUF_BEGV etc.
12973 (record_buffer_markers, fetch_buffer_markers): New functions for
12974 recording and fetching special buffer markers.
12975 (set_buffer_internal_1, set_buffer_temp): Use them.
12977 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12979 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12981 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12982 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12984 * xdisp.c (hscroll_window_tree):
12985 (reconsider_clip_changes): Use PT instead of BUF_PT.
12987 2011-03-13 Eli Zaretskii <eliz@gnu.org>
12989 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12990 $(EMACS_ROOT)/lib/intprops.h.
12992 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12994 Fix more problems found by GCC 4.5.2's static checks.
12996 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12997 to unsigned char * to avoid compiler diagnostic.
12998 (xg_free_frame_widgets): Make it clear that a local variable is
12999 needed only if USE_GTK_TOOLTIP.
13000 (gdk_window_get_screen): Make it clear that this macro is needed
13001 only if USE_GTK_TOOLTIP.
13002 (int_gtk_range_get_value): New function, which avoids a diagnostic
13003 from gcc -Wbad-function-cast.
13004 (xg_set_toolkit_scroll_bar_thumb): Use it.
13005 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13006 diagnostic from gcc -Wbad-function-cast.
13007 (get_utf8_string, xg_get_file_with_chooser):
13008 Rename locals to avoid shadowing.
13009 (create_dialog): Move locals to avoid shadowing.
13011 * xgselect.c (xg_select): Remove unused var.
13013 * image.c (four_corners_best): Mark locals as initialized.
13014 (gif_load): Initialize transparent_p to zero (Bug#8238).
13015 Mark another local as initialized.
13016 (my_png_error, my_error_exit): Mark with NO_RETURN.
13018 * image.c (clear_image_cache): Now static.
13019 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
13020 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
13021 (x_edge_detection): Remove unnecessary cast that
13022 gcc -Wbad-function-cast diagnoses.
13023 (gif_load): Fix pointer signedness.
13024 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13025 (jpeg_load, gif_load): Rename locals to avoid shadowing.
13027 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
13029 Improve quality of tests for time stamp overflow.
13030 For example, without this patch (encode-time 0 0 0 1 1
13031 1152921504606846976) returns the obviously-bogus value (-948597
13032 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13033 reports time overflow. See
13034 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
13035 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13036 * editfns.c: Include limits.h and intprops.h.
13037 (TIME_T_MIN, TIME_T_MAX): New macros.
13038 (time_overflow): Move earlier, to before first use.
13039 (hi_time, lo_time): New functions, for an accurate test for
13040 out-of-range times.
13041 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13042 (Fget_internal_run_time): Don't assume time_t fits in int.
13043 (make_time): Use list2 instead of Fcons twice.
13044 (Fdecode_time): More accurate test for out-of-range times.
13045 (check_tm_member): New function.
13046 (Fencode_time): Use it, to test for out-of-range times.
13047 (lisp_time_argument): Don't rely on undefined left-shift and
13048 right-shift behavior when checking for time stamp overflow.
13050 * editfns.c (time_overflow): New function, refactoring common code.
13051 (Fformat_time_string, Fdecode_time, Fencode_time):
13052 (Fcurrent_time_string): Use it.
13054 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13055 * dired.c (make_time): Move to ...
13056 * editfns.c (make_time): ... here.
13057 * systime.h: Note the move.
13059 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
13061 * fringe.c (update_window_fringes): Remove unused variables.
13063 * unexmacosx.c (copy_data_segment): Also copy __got section.
13066 2011-03-12 Eli Zaretskii <eliz@gnu.org>
13068 * termcap.c [MSDOS]: Include "msdos.h".
13069 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13070 Constify `char *' arguments and their references according to
13071 prototypes in tparam.h.
13073 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
13075 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13076 Adapt all references accordingly.
13078 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13080 2011-03-11 Tom Tromey <tromey@redhat.com>
13082 * buffer.c (syms_of_buffer): Remove obsolete comment.
13084 2011-03-11 Eli Zaretskii <eliz@gnu.org>
13086 * termhooks.h (encode_terminal_code): Declare prototype.
13088 * msdos.c (encode_terminal_code): Don't declare prototype.
13090 * term.c (encode_terminal_code): Now external again, used by
13091 w32console.c and msdos.c.
13093 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13094 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
13096 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
13098 Fix some minor problems found by GCC 4.5.2's static checks.
13100 * fringe.c (update_window_fringes): Mark locals as initialized
13102 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
13104 * alloc.c (mark_fringe_data): Move decl from here ...
13105 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13106 to check its interface.
13107 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13109 * fontset.c (free_realized_fontset): Now static.
13110 (Fset_fontset_font): Rename local to avoid shadowing.
13111 (fontset_font): Mark local as initialized.
13112 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
13114 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13116 * xselect.c (x_disown_buffer_selections): Remove; not used.
13117 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
13118 (x_own_selection, Fx_disown_selection_internal): Rename locals
13119 to avoid shadowing.
13120 (x_handle_dnd_message): Remove local to avoid shadowing.
13122 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13123 so that the caller can use some name other than gcpro1.
13124 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
13125 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13126 (Fx_backspace_delete_keys_p):
13127 Use them to avoid shadowing, and rename vars to avoid shadowing.
13128 (x_decode_color, x_set_name, x_window): Now static.
13129 (Fx_create_frame): Add braces to silence GCC warning.
13130 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
13131 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13132 Remove unused locals.
13133 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13134 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13135 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13138 * xterm.h (x_mouse_leave): New decl.
13140 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13141 Remove unused functions.
13142 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13143 (x_calc_absolute_position): Now static.
13144 (XTread_socket): Don't define label "out" unless it's used.
13145 Don't declare local "event" unless it's used.
13146 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13147 unless they are used.
13148 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13149 (x_fatal_error_signal): Remove; not used.
13150 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13151 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13152 (x_error_catcher, x_connection_closed, x_error_handler):
13153 (x_error_quitter, xembed_send_message, x_iconify_frame):
13154 (my_log_handler): Rename locals to avoid shadowing.
13155 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
13156 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
13158 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13159 Rename or move locals to avoid shadowing.
13160 (tty_defined_color, merge_face_heights): Now static.
13161 (free_realized_faces_for_fontset): Remove; not used.
13162 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13163 does not deduce is never used uninitialized.
13164 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13165 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
13167 * terminal.c (store_terminal_param): Now static.
13169 * xmenu.c (menu_highlight_callback): Now static.
13170 (set_frame_menubar): Remove unused local.
13171 (xmenu_show): Rename parameter to avoid shadowing.
13172 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13173 since they might point to immutable storage.
13174 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13175 since it's unused otherwise.
13177 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
13178 Add a FIXME, since the code still doesn't look right. (Bug#8215)
13179 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13180 avoids a gcc -Wuninitialized diagnostic.
13181 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
13182 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13183 does not deduce are never used uninitialized.
13185 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13187 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
13188 * window.c (window_loop, size_window):
13189 (run_window_configuration_change_hook, enlarge_window): Likewise.
13191 * window.c (display_buffer): Now static.
13192 (size_window): Mark variables that gcc -Wuninitialized
13193 does not deduce are never used uninitialized.
13194 * window.h (check_all_windows): New decl, to forestall
13195 gcc -Wmissing-prototypes diagnostic.
13196 * dispextern.h (bidi_dump_cached_states): Likewise.
13198 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13200 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
13201 Include <limits.h>.
13202 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13203 and to avoid gcc -Wuninitialized warning.
13204 (load_charset_map): Mark variables that gcc -Wuninitialized
13205 does not deduce are never used uninitialized.
13206 (load_charset): Abort instead of using uninitialized var (Bug#8229).
13208 * coding.c (coding_set_source, coding_set_destination):
13209 Use "else { /* comment */ }" rather than "else /* comment */;"
13210 for clarity, and to avoid gcc -Wempty-body warning.
13211 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13212 a block, when the outer 'i' will do.
13213 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13214 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13215 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13216 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13217 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13218 Rename locals to avoid shadowing.
13219 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
13220 * coding.c (emacs_mule_char, encode_invocation_designation):
13221 Now static, since they're not used elsewhere.
13222 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
13223 (decode_coding_object, encode_coding_object, detect_coding_system):
13224 (decode_coding_emacs_mule): Mark variables that gcc
13225 -Wuninitialized does not deduce are never used uninitialized.
13226 (detect_coding_iso_2022): Initialize a local variable that might
13227 be used uninitialized. Leave a FIXME because it's not clear that
13228 this initialization is needed. (Bug#8211)
13229 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13230 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13231 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13232 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13233 Remove unused macros.
13235 * category.c (hash_get_category_set): Remove unused local var.
13236 (copy_category_table): Now static, since it's not used elsewhere.
13237 * character.c (string_count_byte8): Likewise.
13239 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13240 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13242 * chartab.c (copy_sub_char_table): Now static, since it's not used
13244 (sub_char_table_ref_and_range, char_table_ref_and_range):
13245 Rename locals to avoid shadowing.
13246 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
13248 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
13249 (BIDI_BOB): Remove unused macro.
13251 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13252 deduce are never used uninitialized.
13253 * term.c (encode_terminal_code): Likewise.
13255 * term.c (encode_terminal_code): Now static. Remove unused local.
13257 * tparam.h: New file.
13258 * term.c, tparam.h: Include it.
13259 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13260 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13261 Move these decls to tparam.h, and make them agree with what
13262 is actually in tparam.c. The previous trick of using incompatible
13263 decls in different modules does not conform to the C standard.
13264 All callers of tparam changed to use tparam's actual API.
13265 * tparam.c (tparam1, tparam, tgoto):
13266 Use const pointers where appropriate.
13268 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13269 * cm.h (struct cm): Likewise.
13270 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13271 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13272 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13273 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13274 (turn_on_face, init_tty): Likewise.
13275 * termchar.h (struct tty_display_info): Likewise.
13277 * term.c (term_mouse_position): Rename local to avoid shadowing.
13279 * alloc.c (mark_ttys): Move decl from here ...
13280 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13282 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13284 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13286 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
13288 * search.c (compile_pattern_1): Remove argument regp, unused since
13289 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13290 (compile_pattern): Don't pass it.
13292 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13294 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13295 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13297 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13299 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13301 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13302 gdk_window_get_screen, gdk_window_get_geometry,
13303 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13304 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13305 (xg_get_pixbuf_from_pixmap): New function.
13306 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13307 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13308 Call xg_get_pixbuf_from_pixmap instead of
13309 gdk_pixbuf_get_from_drawable.
13310 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13311 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13312 (xg_check_special_colors): Use GtkStyleContext and its functions
13314 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13315 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13316 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
13317 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13318 Call gtk_widget_get_preferred_size.
13319 (xg_frame_resized): gdk_window_get_geometry only takes 5
13321 (xg_win_to_widget, xg_event_is_for_menubar):
13322 Call gdk_x11_window_lookup_for_display.
13323 (xg_set_widget_bg): New function.
13324 (delete_cb): New function.
13325 (xg_create_frame_widgets): Connect delete-event to delete_cb.
13326 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
13327 (xg_set_background_color): Call xg_set_widget_bg.
13328 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13329 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13330 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13331 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13333 (update_frame_tool_bar): Call gtk_widget_hide.
13334 (xg_initialize): Use GDK_KEY_g.
13336 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13338 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13340 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13341 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13342 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13344 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
13346 * w32xfns.c (select_palette): Check success of RealizePalette against
13347 GDI_ERROR, not zero.
13349 See ChangeLog.11 for earlier changes.
13351 ;; Local Variables:
13355 Copyright (C) 2011-2012 Free Software Foundation, Inc.
13357 This file is part of GNU Emacs.
13359 GNU Emacs is free software: you can redistribute it and/or modify
13360 it under the terms of the GNU General Public License as published by
13361 the Free Software Foundation, either version 3 of the License, or
13362 (at your option) any later version.
13364 GNU Emacs is distributed in the hope that it will be useful,
13365 but WITHOUT ANY WARRANTY; without even the implied warranty of
13366 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13367 GNU General Public License for more details.
13369 You should have received a copy of the GNU General Public License
13370 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.
HCoop / bpt / emacs.git / blob