1 2012-06-23 Eli Zaretskii <eliz@gnu.org>
3 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
4 in the logic of incrementing and decrementing the value of
5 use_relocatable_buffers.
7 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
9 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
10 Privately reported by Herbert J. Skuhra.
11 [__FreeBSD__]: Remove "*/" typo after "#include".
12 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
13 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
14 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
15 Don't assume EMACS_TIME and struct timeval are the same type.
17 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
19 Support higher-resolution time stamps (Bug#9000).
20 The time stamps are only nanosecond-resolution at the C level,
21 since that's the best that any real-world system supports now.
22 But they are picosecond-resolution at the Lisp level, as that's
23 easy, and leaves room for future OS improvements.
25 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
28 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
29 Don't get current time unless it's needed.
31 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
32 now provides it if it's absent.
33 (start_atimer): Port to higher-res time stamps.
34 Check for time stamp overflow. Don't get current time more
37 * buffer.h (struct buffer): Buffer modtime now has high resolution.
38 Include systime.h, not time.h.
39 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
41 * dired.c: Include stat-time.h.
42 (Ffile-attributes): File times now have higher resolution.
44 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
45 (struct image): Timestamp now has higher resolution.
47 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
48 has at least microseconds now. All uses removed.
49 (update_frame, update_single_window, update_window, update_frame_1)
50 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
52 * editfns.c (time_overflow): Now extern.
53 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
54 (float-time, Fformat_time_string, Fcurrent_time_string)
55 (Fcurrent_time_zone): Accept and generate higher-resolution
57 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
58 (decode_time_components, lisp_seconds_argument): New functions.
59 (make_time): Now static.
60 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
61 Report an error if the time is invalid, rather than having the caller
64 * fileio.c: Include <stat-time.h>
65 (Fcopy_file): Copy higher-resolution time stamps.
66 Prefer to set the time stamp via a file descriptor if that works.
67 (Fset_file_times, Finsert_file_contents, Fwrite_region)
68 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
69 (Fvisited_file_modtime, Fset_visited_file_modtime):
70 Support higher-resolution time stamps.
72 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
74 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
76 * image.c (prepare_image_for_display, clear_image_cache)
77 (lookup_image): Port to higer-resolution time stamps.
79 * keyboard.c (start_polling, bind_polling_period):
80 Check for time stamp overflow.
81 (read_char, kbd_buffer_get_event, timer_start_idle)
82 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
83 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
84 Port to higher-resolution time stamps. Do not assume time_t is signed.
85 (decode_timer): New function. Timers are now vectors of length 9,
86 not 8, to accommodate the picosecond component.
87 (timer_check_2): Use it.
89 * nsterm.m (select_timeout, timeval_subtract): Remove.
90 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
91 as they're a bit more accurate and handle overflow better.
92 (ns_select): Change prototype to be compatible with pselect.
93 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
94 * nsterm.h (ns_select): Adjust prototype.
96 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
97 us-resolution time stamps.
98 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
100 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
102 * lisp.h (time_overflow): New decl.
103 (wait_reading_process_output): First arg is now intmax_t, not int,
104 to accommodate larger waits.
106 * process.h (struct Lisp_Process.read_output_delay):
107 Now counts nanoseconds, not microseconds.
108 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
110 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
111 (wait_reading_process_output):
112 Port to ns-resolution time stamps.
113 (Faccept_process_output, wait_reading_process_output):
114 Check for time stamp overflow. Do not assume time_t is signed.
115 (select_wrapper): Remove; we now use pselect.
116 (Fprocess_attributes): Now generates ns-resolution time stamps.
118 * sysdep.c: Include utimens.h. Don't include utime.h
119 or worry about struct utimbuf; gnulib does that for us now.
120 (gettimeofday): Remove; gnulib provides a substitute.
121 (make_timeval): New function.
122 (set_file_times): Now sets ns-resolution time stamps.
123 New arg FD; all uses changed.
124 (time_from_jiffies, ltime_from_jiffies, get_up_time)
125 (system_process_attributes):
126 Now returns ns-resolution time stamp. All uses changed.
127 Check for time stamp overflow.
129 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
130 provides a substitute now.
132 * systime.h: Include timespec.h rather than sys/time.h and time.h,
133 since it guarantees struct timespec.
134 (EMACS_TIME): Now struct timespec, so that we can support
135 ns-resolution time stamps.
136 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
137 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
138 (EMACS_USECS): Remove.
139 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
140 so multiply the arg by 1000 before storing it.
141 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
143 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
144 Port to ns-resolution time stamps.
145 (EMACS_TIME_NEG_P): Remove; replaced by....
146 (EMACS_TIME_SIGN): New macro.
147 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
148 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
149 (set_file_times, make_time, lisp_time_argument): Adjust signature.
150 (make_timeval, make_lisp_time, decode_time_components): New decls.
151 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
152 that it mishandled time_t overflow. You can't compare by subtracting!
153 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
154 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
156 * term.c: Include <sys/time.h>.
157 (timeval_to_Time): New function, for proper overflow wraparound.
158 (term_mouse_position, term_mouse_click): Use it.
160 * undo.c (record_first_change): Support higher-resolution time stamps
162 (Fprimitive_undo): Use them when restoring time stamps.
164 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
165 (w32_get_internal_run_time):
166 Port to higher-resolution Emacs time stamps.
167 (ltime): Now accepts single 64-bit integer, as that's more convenient
170 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
172 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
173 for compatibility with pselect. Support ns-resolution time stamps.
175 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
177 * xselect.c (wait_for_property_change, x_get_foreign_selection):
178 Check for time stamp overflow, and support ns-resolution time stamps.
180 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
181 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
182 (timeval_subtract): Remove; no longer needed.
183 (XTflash, XTring_bell, x_wait_for_event):
184 Port to ns-resolution time stamps. Don't assume time_t is signed.
186 2012-06-22 Chong Yidong <cyd@gnu.org>
188 * xdisp.c (x_consider_frame_title): Revert last change.
190 2012-06-22 Eli Zaretskii <eliz@gnu.org>
192 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
193 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
194 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
195 staticidx goes up to 1597 out of 1600 = 0x640.)
197 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
199 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
200 Otherwise, the umask might be mistakenly 0 while handling input signals.
202 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
204 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
206 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
208 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
209 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
210 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
211 access to `contents' member of Lisp_Vector objects with AREF and ASET
214 2012-06-19 Chong Yidong <cyd@gnu.org>
216 * frame.c (delete_frame): When selecting a frame on a different
217 text terminal, do not alter the terminal's top-frame.
219 * xdisp.c (format_mode_line_unwind_data): Record the target
220 frame's selected window and its terminal's top-frame.
221 (unwind_format_mode_line): Restore them.
222 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
224 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
225 since tty frames can be explicitly named.
226 (prepare_menu_bars): Likewise.
228 * term.c (Ftty_top_frame): New function.
230 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
232 Port byte-code-meter to modern targets.
233 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
234 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
235 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
236 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
237 (METER_1, METER_2): Simplify.
239 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
241 * data.c (Fdefalias): Return `symbol' (bug#11686).
243 2012-06-18 Martin Rudalics <rudalics@gmx.at>
245 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
246 gets killed during executing of this function (Bug#11665).
247 Try to always return Qt when the buffer has been actually killed.
248 (Vkill_buffer_query_functions): In doc-string say that functions
249 run by this hook should not change the current buffer.
251 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
253 Fix recently-introduced process.c problems found by static checking.
254 * process.c (write_queue_push, write_queue_pop, send_process):
255 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
256 (write_queue_pop): Fix pointer signedness problem.
257 (send_process): Remove unused local.
259 2012-06-17 Chong Yidong <cyd@gnu.org>
261 * xdisp.c (redisplay_internal): No need to redisplay terminal
262 frames that are not on top.
264 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
266 * process.c (make_process): Initialize write_queue.
267 (write_queue_push, write_queue_pop): New functions.
268 (send_process): Use them to maintain correct ordering of process
271 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
273 * lisp.h (eassert): Assume C89 or later.
274 This removes the need for CHECK.
275 (CHECK): Remove. Its comments about always evaluating its
276 argument were confusing, as 'eassert' typically does not evaluate
279 * coding.c (produce_chars): Use ptrdiff_t, not int.
281 * xterm.c (x_draw_underwave): Check for integer overflow.
282 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
284 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
286 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
287 referenced (Bug#11583).
289 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
291 Implement wave-style variant of underlining.
292 * dispextern.h (face_underline_type): New enum.
293 (face): Add field for underline type.
294 * nsterm.m (ns_draw_underwave): New function.
295 (ns_draw_text_decoration): Use it.
296 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
298 (x_draw_glyph_string): Use them.
299 * xfaces.c (Qline, Qwave): New Lisp objects.
300 (check_lface_attrs, merge_face_ref)
301 (Finternal_set_lisp_face_attribute, realize_x_face):
302 Handle wave-style underline face attributes.
303 * xterm.c (x_draw_underwave): New function.
304 (x_draw_glyph_string): Use it.
306 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
308 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
309 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
310 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
311 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
312 ($(BLD)/w32select.$(O)): Update dependencies.
314 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
316 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
317 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
318 * character.c (_fetch_multibyte_char_p): Remove.
319 * alloc.c: Include "character.h" before "buffer.h".
321 * buffer.c: Likewise.
322 * bytecode.c: Likewise.
323 * callint.c: Likewise.
324 * callproc.c: Likewise.
325 * casefiddle.c: Likewise.
326 * casetab.c: Likewise.
327 * category.c: Likewise.
329 * coding.c: Likewise.
330 * composite.c: Likewise.
332 * dispnew.c: Likewise.
334 * dosfns.c: Likewise.
335 * editfns.c: Likewise.
337 * fileio.c: Likewise.
338 * filelock.c: Likewise.
340 * fontset.c: Likewise.
341 * fringe.c: Likewise.
342 * indent.c: Likewise.
343 * insdel.c: Likewise.
344 * intervals.c: Likewise.
345 * keyboard.c: Likewise.
346 * keymap.c: Likewise.
348 * macros.c: Likewise.
349 * marker.c: Likewise.
350 * minibuf.c: Likewise.
352 * nsmenu.m: Likewise.
354 * process.c: Likewise.
356 * region-cache.c: Likewise.
357 * search.c: Likewise.
358 * syntax.c: Likewise.
360 * textprop.c: Likewise.
362 * unexsol.c: Likewise.
363 * w16select.c: Likewise.
364 * w32fns.c: Likewise.
365 * w32menu.c: Likewise.
366 * window.c: Likewise.
371 * xselect.c: Likewise.
373 2012-06-16 Eli Zaretskii <eliz@gnu.org>
375 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
376 If all the glyphs of the glyph row came from strings, and we have no
377 cursor positioning clues, put the cursor on the first glyph of the
379 (handle_face_prop): Use chunk-relative overlay string index when
380 indexing into it->string_overlays array. (Bug#11653)
381 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
382 the rightmost. (Bug#11720)
384 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
386 * category.h (CHAR_HAS_CATEGORY): Define as inline.
387 (CATEGORY_MEMBER): Enforce 1/0 value.
388 * category.c (_temp_category_set): Remove.
390 2012-06-16 Eli Zaretskii <eliz@gnu.org>
392 * window.c (Fdelete_other_windows_internal)
393 (Fdelete_window_internal): Don't access frame's mouse highlight
394 info of the initial frame. (Bug#11677)
396 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
398 * .gdbinit (xgetint): Fix recently-introduced paren typo.
399 Assume USE_2_TAGS_FOR_INTS.
400 (xreload): Adjust $tagmask width to match recent lisp.h change.
402 Simplify lisp.h in minor ways that should not affect code.
403 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
404 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
405 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
406 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
407 (INTTYPEBITS): New macro, for clarity.
408 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
409 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
410 Simplify now that USE_LSB_TAG is always defined.
411 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
412 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
414 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
416 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
418 2012-06-13 Glenn Morris <rgm@gnu.org>
420 * s/bsd-common.h (BSD4_3):
421 * s/usg5-4-common.h (USG5_4): No longer define; unused.
423 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
425 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
428 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
430 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
431 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
432 * alloc.c (widen_to_Lisp_Object): Remove.
433 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
434 * frame.c (delete_frame): Remove outdated comment.
435 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
437 (Fw32_unregister_hot_key): Likewise.
438 (Fw32_toggle_lock_key): Likewise.
439 * w32menu.c (add_menu_item): Likewise.
440 (w32_menu_display_help): Use XIL instead of checking
442 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
443 (init_heap): Likewise.
444 * w32term.c (w32_read_socket): Update comment.
446 2012-06-13 Glenn Morris <rgm@gnu.org>
448 * s/usg5-4-common.h, src/s/unixware.h:
449 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
451 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
453 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
455 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
456 * alloc.c (make_number) [!defined make_number]:
457 Remove, as lisp.h always defines this now.
458 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
459 (roundup_size): Verify that it is a power of 2.
460 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
461 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
462 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
463 -DUSE_LSB_TAG=0, to override the automatically-selected default.
464 USE_LSB_TAG now is always defined to be either 0 or 1.
466 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
467 code works fine either way, and efficiency is not a concern here,
468 as the union type is for debugging, not for production.
469 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
470 Use an inline function on all platforms when using the union type,
471 since this is simpler and 'static inline' can be used portably
473 (LISP_INITIALLY_ZERO): New macro.
474 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
475 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
477 2012-06-12 Glenn Morris <rgm@gnu.org>
479 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
481 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
483 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
484 Move BROKEN_SIGIO to configure.
486 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
487 Move NO_TERMIO to configure.
489 2012-06-12 Chong Yidong <cyd@gnu.org>
491 * image.c (imagemagick_load_image): Use MagickFlattenImage if
492 MagickMergeImageLayers is undefined. Use pixel pusher loop if
493 MagickExportImagePixels is undefined.
495 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
497 * image.c (imagemagick_load_image): Remove unused label.
499 2012-06-11 Glenn Morris <rgm@gnu.org>
501 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
502 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
503 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
504 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
506 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
508 * alloc.c (make_byte_code): New function.
509 (Fmake_byte_code): Use it. Don't purify here.
510 * lread.c (read1): Use it as well to avoid extra allocation.
512 2012-06-11 Chong Yidong <cyd@gnu.org>
514 * image.c (imagemagick_load_image): Implement transparency.
516 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
518 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
519 account for preceding backslashes. (Bug#11663)
521 2012-06-09 Chong Yidong <cyd@gnu.org>
523 * term.c: Support italics in capable terminals (Bug#9652).
524 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
525 (turn_on_face): Output using TS_enter_italic_mode if available.
526 Don't handle unused blinking and alt-charset cases.
527 (turn_off_face): Handle italic case; discard unused tty_blinking_p
528 and tty_alt_charset_p cases.
529 (tty_capable_p, init_tty): Support italics.
531 * termchar.h (struct tty_display_info): Add field for italics.
532 Remove unused blink field.
534 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
537 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
538 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
539 tty_alt_charset_p. Add tty_italic_p.
541 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
543 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
544 dbus_type_is_basic if available.
545 (xd_extract_signed, xd_extract_unsigned): Rename from
546 extract_signed and extract_unsigned, respectively. Adapt callers.
548 2012-06-09 Chong Yidong <cyd@gnu.org>
550 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
552 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
555 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
557 * xdisp.c (vmessage): Treat frame message as multibyte.
558 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
559 would generate the diagnostic "Making \302\247 buffer-local while
562 2012-06-08 Eli Zaretskii <eliz@gnu.org>
564 * dispnew.c (showing_window_margins_p): Undo last change, which
565 was done due to an inadvertent commit.
566 (adjust_frame_glyphs_for_frame_redisplay): Do call
567 showing_window_margins_p.
569 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
571 * eval.c (Fmake_var_non_special): New primitive.
572 (syms_of_eval): Defsubr it.
573 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
575 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
577 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
578 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
580 2012-06-08 Eli Zaretskii <eliz@gnu.org>
582 * alloc.c (allocate_vectorlike): Fix last change.
584 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
586 Block-based vector allocation of small vectors.
587 * lisp.h (struct vectorlike_header): New field `nbytes',
588 adjust comment accordingly.
589 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
590 to denote vector blocks. Adjust users (live_vector_p,
591 mark_maybe_pointer, valid_lisp_object_p) accordingly.
592 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
593 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
594 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
595 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
596 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
597 (roundup_size): New constant.
598 (struct vector_block): New data type.
599 (vector_blocks, vector_free_lists, zero_vector): New variables.
600 (all_vectors): Rename to `large_vectors'.
601 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
602 (sweep_vectors): New functions.
603 (allocate_vectorlike): Return `zero_vector' as the only vector of
604 0 items. Allocate new vector from block if vector size is less than
605 or equal to VBLOCK_BYTES_MAX.
606 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
607 (init_alloc_once): Add call to init_vectors.
609 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
611 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
613 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
615 * doprnt.c (doprnt): Truncate multibyte char correctly.
616 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
617 would mishandle a string argument "Xc" if X was a multibyte
618 character of length 2: it would truncate after X's first byte
619 rather than including all of X.
621 2012-06-06 Chong Yidong <cyd@gnu.org>
623 * buffer.c (word_wrap): Doc fix.
625 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
627 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
629 2012-06-03 Glenn Morris <rgm@gnu.org>
631 * xdisp.c (tool-bar-style): Doc fix.
633 2012-06-03 Ulrich Müller <ulm@gentoo.org>
635 * Makefile.in (PAXCTL): Define.
636 (temacs$(EXEEXT)): Disable memory randomization for the temacs
637 binary via PaX flags if the paxctl utility is available.
638 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
639 Restore PaX flags to their default. (Bug#11398)
641 2012-06-03 Chong Yidong <cyd@gnu.org>
643 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
646 2012-06-03 Chong Yidong <cyd@gnu.org>
648 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
649 (note_mode_line_or_margin_highlight): If there is no help echo,
650 use mode-line-default-help-echo. Handle the case where the mouse
651 position is past the end of the mode line string.
653 * buffer.c (buffer_local_value_1): New function, split from
654 Fbuffer_local_value; can return Qunbound.
655 (Fbuffer_local_value): Use it.
656 (Vmode_line_format): Docstring tweaks.
658 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
660 * sysdep.c (system_process_attributes): Improve comment.
662 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
664 * keyboard.c: Export real-this-command to Elisp.
665 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
666 and DEFVAR it. Update all users.
668 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
670 * minibuf.c (Fassoc_string): Remove duplicate declaration.
672 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
673 Convert pctcpu and pctmem to Lisp float properly.
674 Let the compiler fold better, as 100.0/0x8000 is exact.
676 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
678 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
681 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
683 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
685 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
687 For a 'struct window', replace some Lisp_Object fields to
688 bitfields where appropriate, remove unused fields.
689 * window.h (struct window): Remove unused 'last_mark_x' and
690 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
691 change it's type from Lisp_Object to bitfield.
692 Change type of 'force_start', 'optional_new_start',
693 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
694 fields from Lisp_Object to bitfield. Adjust users accordingly.
696 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
698 Pacify gcc -Wdouble-precision when using Xaw.
699 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
700 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
701 Use 'float' consistently, rather than 'float' in most places
702 and 'double' in a couple of places.
704 2012-05-31 Eli Zaretskii <eliz@gnu.org>
706 * xdisp.c (handle_stop): Detect whether we have overlay strings
707 loaded by testing it->current.overlay_string_index to be
708 non-negative, instead of checking whether n_overlay_strings is
709 positive. (Bug#11587)
711 2012-05-31 Chong Yidong <cyd@gnu.org>
713 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
715 * doc.c (Fsubstitute_command_keys): Doc fix.
717 2012-05-31 Eli Zaretskii <eliz@gnu.org>
719 * search.c (search_buffer): Remove calls to
720 r_alloc_inhibit_buffer_relocation, as it is now called by
721 maybe_unify_char, which was the cause of relocation of buffer text
724 2012-05-31 Eli Zaretskii <eliz@gnu.org>
726 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
727 for the duration of call to load_charset, to avoid problems with
728 callers of maybe_unify_char that access buffer text through C
731 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
732 decrement the inhibition flag, instead of just setting or
735 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
737 Remove obsolete '#define static' cruft.
738 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
739 This #undef was "temporary" in 2000; it is no longer needed
740 now that '#define static' has gone away.
741 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
742 (gray_bitmap_bits): Remove; no longer needed.
743 All uses replaced with definiens.
744 * xterm.c: Include "bitmaps/gray.xbm".
746 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
748 Clean up __executable_start, monstartup when --enable-profiling.
749 The following changes affect the code only when profiling.
750 * dispnew.c (__executable_start): Rename from safe_bcopy.
751 Define only on platforms that need it.
752 * emacs.c: Include <sys/gmon.h> when profiling.
753 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
754 (__executable_start): Remove decl, since lisp.h does it now.
755 (safe_bcopy): Remove decl; no longer has that name.
756 (main): Coalesce #if into single bit of code, for simplicity.
757 Cast pointers to uintptr_t, since standard libraries want integers
759 * lisp.h (__executable_start): New decl.
761 2012-05-31 Glenn Morris <rgm@gnu.org>
763 * image.c (Fimagemagick_types): Doc fix.
765 2012-05-30 Jim Meyering <meyering@redhat.com>
767 * callproc.c (Fcall_process_region): Include directory component
768 in mkstemp error message (Bug#11586).
770 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
772 * alloc.c, lisp.h (make_pure_vector): Now static.
774 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
776 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
778 (Fautoload): Do the hash-doc more carefully.
779 * data.c (Fdefalias): Purify definition, except for keymaps.
780 (Qdefun): Move from eval.c.
781 * lisp.h (Qdefun): Remove.
782 * lread.c (read1): Tiny simplification.
784 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
786 Do not create empty overlays with the evaporate property (Bug#9642).
787 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
788 Bug#9642, but explicitly check that the buffer the overlay would
789 be moved to is live and rearrange lines to make sure that errors
790 will not put the overlay in an inconsistent state.
791 (Fdelete_overlay): Cosmetics.
793 2012-05-28 Eli Zaretskii <eliz@gnu.org>
795 * w32term.c (my_bring_window_to_top): New function.
796 (x_raise_frame): Use handle returned by DeferWindowPos, which
797 could be different from the original one.
798 Call my_bring_window_to_top instead of my_set_foreground_window.
801 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
802 by calling BringWindowToTop.
804 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
805 (WM_EMACS_END): Increase by one.
807 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
809 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
810 This avoids undefined behavior that might cause the eassert
811 to not catch an out-of-range value.
813 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
815 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
818 2012-05-27 Eli Zaretskii <eliz@gnu.org>
820 * bidi.c (bidi_mirror_char): Fix last change.
822 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
824 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
825 when referring to sectname field in printf format.
827 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
829 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
830 Only r_alloc_inhibit_buffer_relocation needed to be added;
831 the others were already declared.
833 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
834 before checking whether it's out of range. Put the check inside
836 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
838 2012-05-27 Ken Brown <kbrown@cornell.edu>
840 * callproc.c (Fcall_process): Restore a line that was accidentally
841 commented out in the 2011-02-13 change (bug#11547).
843 2012-05-27 Eli Zaretskii <eliz@gnu.org>
845 * lisp.h [REL_ALLOC]: Add prototypes for external functions
848 * buffer.c [REL_ALLOC]: Remove prototypes of
849 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
850 they are now on lisp.h.
852 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
854 * search.c (search_buffer): Use it to inhibit relocation of buffer
855 text while re_search_2 is doing its job, because re_search_2 is
856 passed C pointers to buffer text. (Bug#11519)
858 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
861 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
862 state after an additional call to move_it_in_display_line_to, keep
863 the values of it->max_ascent and it->max_descent found for the
865 (pos_visible_p): Revert the comparison against bottom_y to what it
866 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
869 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
871 Fix coding-related core dumps with gcc -ftrapv.
872 The code was computing A - B, where A and B are pointers, and B is
873 random garbage. This can lead to core dumps on platforms that
874 have special pointer registers, and it also leads to core dumps on
875 x86-64 when compiled with gcc -ftrapv. The fix is to compute
876 A - B only when B is initialized properly.
877 * coding.c (coding_set_source, coding_set_destination): Return void.
878 (coding_change_source, coding_change_destinations): New functions,
879 with the old behaviors of coding_set_source and coding_set_destination.
880 All callers that need an offset changed to use these new functions.
882 2012-05-26 Glenn Morris <rgm@gnu.org>
884 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
886 2012-05-26 Eli Zaretskii <eliz@gnu.org>
888 Extend mouse support on W32 text-mode console.
889 * xdisp.c (draw_row_with_mouse_face):
890 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
892 * w32console.c: Include window.h.
893 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
895 (initialize_w32_display): Initialize mouse-highlight data.
897 * w32inevt.c: Include termchar.h and window.h.
898 (do_mouse_event): Support mouse-autoselect-window. When the mouse
899 moves, call note_mouse_highlight. If help_echo changed, call
900 gen_help_event to produce help-echo message in the echo area.
901 Call clear_mouse_face if mouse_face_hidden is set in the mouse
904 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
906 * lread.c (read1): Simplify slightly to avoid an overflow warning
907 with GCC 4.7.0 on x86-64.
909 2012-05-26 Eli Zaretskii <eliz@gnu.org>
911 * bidi.c (bidi_mirror_char): Revert last change: an int is
912 definitely wide enough here.
914 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
916 Fix integer width and related bugs (Bug#9874).
917 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
918 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
919 (string_bytes, check_sblock, allocate_string_data):
920 (compact_small_strings, Fmake_bool_vector, make_string)
921 (make_unibyte_string, make_multibyte_string)
922 (make_string_from_bytes, make_specified_string)
923 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
924 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
926 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
927 (allocate_pseudovector):
928 Use int, not EMACS_INT, where int is wide enough.
929 (inhibit_garbage_collection, Fgarbage_collect):
930 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
931 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
932 int might not be wide enough.
933 (bidi_cache_search, bidi_cache_find, bidi_init_it)
934 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
935 (bidi_at_paragraph_end, bidi_find_paragraph_start)
936 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
937 (bidi_level_of_next_char, bidi_move_to_visually_next):
938 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
939 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
940 (Fkill_buffer, Fset_buffer_major_mode)
941 (advance_to_char_boundary, Fbuffer_swap_text)
942 (Fset_buffer_multibyte, overlays_at, overlays_in)
943 (overlay_touches_p, struct sortvec, record_overlay_string)
944 (overlay_strings, recenter_overlay_lists)
945 (adjust_overlays_for_insert, adjust_overlays_for_delete)
946 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
947 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
948 (Foverlay_recenter, last_overlay_modification_hooks_used)
949 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
950 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
951 (validate_region): Omit unnecessary test for b <= e,
952 since that's guaranteed by the previous test.
953 (adjust_overlays_for_delete): Avoid pos + length overflow.
954 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
955 (report_overlay_modification):
956 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
957 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
958 Omit pointer cast, which isn't needed anyway, and doesn't work
959 after the EMACS_INT -> ptrdiff_t change.
960 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
961 * buffer.h: Adjust decls to match defn changes elsewhere.
962 (struct buffer_text, struct buffer):
963 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
964 Use EMACS_INT, not int, where int might not be wide enough.
965 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
966 not int, to avoid needless 32-bit limit on 64-bit hosts.
967 (exec_byte_code): Use tighter memory-full test, one that checks
968 for alloca overflow. Don't compute the address of the object just
969 before an array, as that's not portable. Use EMACS_INT, not
970 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
971 * callint.c (Fcall_interactively):
972 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
973 * callproc.c (call_process_kill, Fcall_process):
974 Don't assume pid_t fits into an Emacs fixnum.
975 (call_process_cleanup, Fcall_process, child_setup):
976 Don't assume pid_t fits into int.
977 (call_process_cleanup, Fcall_process, delete_temp_file)
978 (Fcall_process_region):
979 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
980 (Fcall_process): Simplify handling of volatile integers.
981 Use int, not EMACS_INT, where int will do.
982 * casefiddle.c (casify_object, casify_region, operate_on_word)
983 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
984 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
985 (casify_object): Avoid integer overflow when overallocating buffer.
986 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
987 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
988 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
989 * category.h (CATEGORYP): Don't assume arg is nonnegative.
990 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
991 integers are now checked earlier. All uses replaced with XINT.
993 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
994 For CCL_MapSingle, check that content and value are in int range.
995 (ccl_driver, Fregister_code_conversion_map):
996 Check that Vcode_version_map_vector is a vector.
997 (resolve_symbol_ccl_program): Check that vector header is in range.
998 Always copy the vector, so that we can check its contents reliably
999 now rather than having to recheck each instruction as it's being
1000 executed. Check that vector words fit in 'int'.
1001 (ccl_get_compiled_code, Fregister_ccl_program)
1002 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1003 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1004 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1005 contents are in range.
1006 (Fccl_execute_on_string): Check that status is in range.
1007 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1008 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1009 Accept and return EMACS_INT, not int, because callers can pass values
1011 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1012 (multibyte_chars_in_text, parse_str_as_multibyte)
1013 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1014 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1015 (string_escape_byte8, Fget_byte):
1016 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1017 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
1018 avoid mishandling large integers.
1019 * character.h: Adjust decls to match defn changes elsewhere.
1020 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1021 (Ffind_charset_region):
1022 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1023 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1024 (load_charset_map_from_vector, Fdefine_charset_internal):
1025 Don't assume fixnum fits in int.
1026 (load_charset_map_from_vector, Fmap_charset_chars):
1027 Remove now-unnecessary CHECK_NATNUMs.
1028 (Fdefine_charset_internal): Check ranges here, more carefully.
1029 Don't rely on undefined behavior with signed left shift overflow.
1030 Don't assume unsigned int fits into fixnum, or that fixnum fits
1031 into unsigned int. Don't require max_code to be a valid fixnum;
1032 that's not true for gb10830 4-byte on a 32-bit host. Allow
1033 invalid_code to be a cons, for the same reason. Require code_offset
1034 to be a character. Avoid int overflow if max_char is close
1036 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1037 this is intended anyway and avoids some undefined behavior.
1038 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1039 INDEX_TO_CODE_POINT, as that's what it expects.
1040 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
1041 * charset.h (DECODE_CHAR): Return int, not unsigned;
1042 this is what was intended anyway, and it avoids undefined behavior.
1043 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1044 integer-overflow issues.
1045 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1046 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1047 where the argument is EMACS_INT, and this behavior is not intended.
1048 * chartab.c (Fmake_char_table, Fset_char_table_range)
1049 (uniprop_get_decoder, uniprop_get_encoder):
1050 Don't assume fixnum fits in int.
1051 * cmds.c (move_point): New function, that does the gist of
1052 Fforward_char and Fbackward_char, but does so while checking
1053 for integer overflow more accurately.
1054 (Fforward_char, Fbackward_char): Use it.
1055 (Fforward_line, Fend_of_line, internal_self_insert)
1056 (internal_self_insert):
1057 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1058 Fix a FIXME, by checking for integer overflow when calculating
1059 target_clm and actual_clm.
1060 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
1061 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
1062 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1063 (coding_alloc_by_making_gap, alloc_destination)
1064 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1065 (encode_coding_utf_16, detect_coding_emacs_mule)
1066 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1067 (detect_coding_iso_2022, decode_coding_iso_2022)
1068 (encode_invocation_designation, encode_designation_at_bol)
1069 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1070 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1071 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1072 (encode_coding_ccl, encode_coding_raw_text)
1073 (detect_coding_charset, decode_coding_charset)
1074 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1075 (produce_composition, produce_charset, produce_annotation)
1076 (decode_coding, handle_composition_annotation)
1077 (handle_charset_annotation, consume_chars, decode_coding_gap)
1078 (decode_coding_object, encode_coding_object, detect_coding_system)
1079 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1080 (code_convert_region, code_convert_string)
1081 (Fdefine_coding_system_internal)
1082 (coding_set_source, coding_set_destination):
1083 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1084 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1085 (Fdefine_coding_system_internal):
1086 Don't assume fixnums fit in int.
1087 (decode_coding_gap, decode_coding_object, encode_coding_object)
1088 (Fread_coding_system, Fdetect_coding_region)
1089 (Funencodable_char_position, Fcheck_coding_systems_region)
1090 (get_translation, handle_composition_annotation, consume_chars):
1091 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1092 (consume_chars): Rewrite to not calculate an address outside buffer.
1093 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
1094 Don't access memory outside of the args array.
1095 (Fdefine_coding_system_internal): Check for charset-id overflow.
1096 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1097 result of ENCODE_CHAR.
1098 * coding.h: Adjust decls to match defn changes elsewhere.
1099 (struct coding_system):
1100 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1101 * composite.c (get_composition_id, find_composition)
1102 (run_composition_function, update_compositions)
1103 (compose_text, composition_gstring_put_cache)
1104 (composition_gstring_p, composition_gstring_width)
1105 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1106 (composition_compute_stop_pos, composition_reseat_it)
1107 (composition_update_it, struct position_record)
1108 (find_automatic_composition, composition_adjust_point)
1109 (Fcomposition_get_gstring, Ffind_composition_internal):
1110 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1111 (update_compositions):
1112 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1113 * composite.h: Adjust decls to match defn changes elsewhere.
1114 (struct composition):
1115 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1116 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1117 Do not attempt to compute the address of the object just before a
1118 buffer; this is not portable.
1120 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1121 (Faset): Use int, not EMACS_INT, where int is wide enough.
1122 (Fstring_to_number): Don't assume fixnums fit in int.
1123 (Frem): Don't assume arg is nonnegative.
1124 * dbusbind.c (xd_append_arg): Check for integers out of range.
1125 (Fdbus_call_method): Don't overflow the timeout int.
1126 (extract_signed, extract_unsigned): New functions.
1127 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1128 (xd_get_connection_references): Return ptrdiff_t, not int.
1130 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1131 (xd_read_message_1):
1132 Use int, not unsigned, where the dbus API uses int.
1133 (Fdbus_message_internal): Don't overflow mtype.
1134 (syms_of_dbusbind): Allocate right-sized buffer for integers.
1135 * dired.c (directory_files_internal, file_name_completion, scmp)
1136 (file_name_completion_stat):
1137 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1138 (file_name_completion): Don't overflow matchcount.
1139 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1140 * dispextern.h: Adjust decls to match defn changes elsewhere.
1141 (struct text_pos, struct glyph, struct bidi_saved_info)
1142 (struct bidi_string_data, struct bidi_it, struct composition_it)
1144 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1145 (struct display_pos, struct composition_it, struct it):
1146 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1147 * dispnew.c (increment_matrix_positions)
1148 (increment_row_positions, mode_line_string)
1149 (marginal_area_string):
1150 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1151 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
1152 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1153 (duration_to_sec_usec): New function, to check for overflow better.
1154 (Fsleep_for, sit_for): Use it.
1155 * doc.c (get_doc_string, store_function_docstring):
1156 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1157 (get_doc_string, Fsnarf_documentation):
1158 Use int, not EMACS_INT, where int is wide enough.
1160 Use SAFE_ALLOCA, not alloca.
1161 Check for overflow when converting EMACS_INT to off_t.
1162 * doprnt.c (doprnt):
1163 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1164 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1165 Don't assume uid_t fits into fixnum.
1166 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1167 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1168 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1169 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1170 (general_insert_function)
1171 (Finsert_char, make_buffer_string, make_buffer_string_both)
1172 (update_buffer_properties, Fbuffer_substring)
1173 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1174 (Fsubst_char_in_region, check_translation)
1175 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1176 (transpose_markers, Ftranspose_regions):
1177 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1178 (clip_to_bounds): Move to lisp.h as an inline function).
1179 (Fconstrain_to_field): Don't assume integers are nonnegative.
1180 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1181 (Fsubst_char_in_region, Fsave_restriction):
1182 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1183 (Femacs_pid): Don't assume pid_t fits into fixnum.
1184 (lo_time): Use int, not EMACS_INT, when int suffices.
1185 (lisp_time_argument): Check for usec out of range.
1186 (Fencode_time): Don't assume fixnum fits in int.
1187 (Fuser_login_name, Fuser_full_name): Signal an error
1188 if a uid argument is out of range, rather than relying on
1190 (Fformat_time_string): Remove now-unnecessary check.
1191 lisp_time_argument checks for out-of-range usec now.
1192 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
1193 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1194 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1195 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1196 (init_cmdargs, Fdump_emacs):
1197 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1198 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1199 the bottom (typically) 32 bits of the fixnum.
1200 * eval.c (specpdl_size, call_debugger):
1201 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1202 (when_entered_debugger, Fbacktrace_debug):
1203 Don't assume fixnum can fit in int.
1204 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1205 the object just before a buffer; this is not portable.
1206 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1207 (grow_specpdl, unbind_to):
1208 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1209 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1210 (grow_specpdl): Simplify allocation by using xpalloc.
1211 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
1212 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1213 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1214 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1215 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1217 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1218 (Fcopy_file, non_regular_nbytes, read_non_regular)
1219 (Finsert_file_contents):
1220 Use int, not EMACS_INT, where int is wide enough.
1221 (READ_BUF_SIZE): Verify that it fits in int.
1222 (Finsert_file_contents): Check that counts are in proper range,
1223 rather than assuming fixnums fit into ptrdiff_t etc.
1224 Don't assume fixnums fit into int.
1225 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
1226 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1227 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
1228 (string_char_to_byte, string_byte_to_char)
1229 (string_make_multibyte, string_to_multibyte)
1230 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1231 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1232 (substring_both, Fdelete, internal_equal, Ffillarray)
1233 (Fclear_string, mapcar1)
1234 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1235 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1236 (larger_vector, make_hash_table, maybe_resize_hash_table)
1237 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1238 (Fmaphash, secure_hash):
1239 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1240 (concat): Check for string index and length overflow.
1241 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1243 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1244 (larger_vector): New API (vec, incr_min, size_max) replaces old
1245 one (vec, new_size, init). This catches size overflow.
1246 INIT was removed because it was always Qnil.
1247 All callers changed.
1248 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1249 the upper bound on a hash table index size.
1250 (make_hash_table, maybe_resize_hash_table): Use it.
1251 (secure_hash): Computer start_byte and end_byte only after
1252 they're known to be in ptrdiff_t range.
1253 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1254 (Ffont_get_glyphs, Ffont_at):
1255 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1256 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1257 (Flist_fonts, Fopen_font):
1258 Don't assume fixnum can fit in int.
1259 (check_gstring): Don't assume index can fit in int.
1260 (font_match_p): Check that fixnum is a character, not a nonnegative
1261 fixnum, since the later code needs to stuff it into an int.
1262 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1263 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1264 conversion overflow issues.
1265 (Fopen_font): Check for integer out of range.
1266 (Ffont_get_glyphs): Don't assume index can fit in int.
1267 * font.h: Adjust decls to match defn changes elsewhere.
1268 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1270 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1271 printmax_t, where ptrdiff_t is wide enough.
1272 (Finternal_char_font):
1273 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1274 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1275 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1276 (Fset_frame_position, x_set_frame_parameters)
1277 (x_set_line_spacing, x_set_border_width)
1278 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1279 Check that fixnums are in proper range for system types.
1280 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1281 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1282 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1283 Use SAFE_ALLOCA_LISP, not alloca.
1284 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1285 intptr_t is wide enough.
1286 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1287 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1288 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1289 Check for fixnum out of range.
1290 * ftfont.c (ftfont_list): Don't assume index fits in int.
1291 Check that fixnums are in proper range for system types.
1292 (ftfont_shape_by_flt):
1293 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1294 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1295 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1296 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1297 Check that fixnums are in proper range for system types.
1298 * gnutls.h: Adjust decls to match defn changes elsewhere.
1299 * gtkutil.c (xg_dialog_run):
1300 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1301 (update_frame_tool_bar):
1302 Check that fixnums are in proper range for system types.
1303 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
1304 (lookup_image): Check that fixnums are in range for system types.
1305 * indent.c (last_known_column, last_known_column_point):
1306 (current_column_bol_cache):
1307 (skip_invisible, current_column, check_display_width):
1308 (check_display_width, scan_for_column, current_column_1)
1309 (Findent_to, Fcurrent_indentation, position_indentation)
1310 (indented_beyond_p, Fmove_to_column, compute_motion):
1311 (Fcompute_motion, Fvertical_motion):
1312 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1313 (last_known_column_modified): Use EMACS_INT, not int.
1314 (check_display_width):
1316 Check that fixnums and floats are in proper range for system types.
1317 (compute_motion): Don't assume index or fixnum fits in int.
1318 (compute_motion, Fcompute_motion):
1319 Use int, not EMACS_INT, when it is wide enough.
1320 (vmotion): Omit local var start_hpos that is always 0; that way
1321 we don't need to worry about overflow in expressions involving it.
1322 * indent.h: Adjust decls to match defn changes elsewhere.
1324 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1325 Use int, not EMACS_INT, where int is wide enough.
1326 Remove unused members ovstring_chars_done and tab_offset;
1328 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1329 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1330 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1331 (make_gap, copy_text, insert, insert_and_inherit)
1332 (insert_before_markers, insert_before_markers_and_inherit)
1333 (insert_1, count_combining_before, count_combining_after)
1334 (insert_1_both, insert_from_string)
1335 (insert_from_string_before_markers, insert_from_string_1)
1336 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1337 (adjust_after_replace, adjust_after_insert, replace_range)
1338 (replace_range_2, del_range, del_range_1, del_range_byte)
1339 (del_range_both, del_range_2, modify_region)
1340 (prepare_to_modify_buffer, signal_before_change)
1341 (signal_after_change, Fcombine_after_change_execute):
1342 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1343 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1344 (balance_an_interval, split_interval_right, split_interval_left)
1345 (find_interval, next_interval, update_interval)
1346 (adjust_intervals_for_insertion, delete_node, delete_interval)
1347 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1348 (static_offset_intervals, offset_intervals)
1349 (merge_interval_right, merge_interval_left, make_new_interval)
1350 (graft_intervals_into_buffer, temp_set_point_both)
1351 (temp_set_point, set_point, adjust_for_invis_intang)
1352 (set_point_both, move_if_not_intangible, get_property_and_range)
1353 (get_local_map, copy_intervals, copy_intervals_to_string)
1354 (compare_string_intervals, set_intervals_multibyte_1):
1355 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1356 * intervals.h: Adjust decls to match defn changes elsewhere.
1358 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1359 * keyboard.c (this_command_key_count, this_single_command_key_start)
1360 (before_command_key_count, before_command_echo_length, echo_now)
1361 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1362 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1363 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1364 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1365 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1366 (last_non_minibuf_size, last_point_position, echo_truncate)
1367 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1368 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1369 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1370 (stuff_buffered_input):
1371 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1372 (last_auto_save, command_loop_1, read_char):
1373 Use EMACS_INT, not int, to avoid integer overflow.
1374 (record_char): Avoid overflow in total_keys computation.
1375 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1376 * keyboard.h: Adjust decls to match defn changes elsewhere.
1377 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1378 (Fkey_description, Fdescribe_vector, Flookup_key):
1379 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1380 (click_position): New function, to check that positions are in range.
1381 (Fcurrent_active_maps):
1383 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1384 (Faccessible_keymaps, Fkey_description):
1385 (preferred_sequence_p):
1386 Don't assume fixnum can fit into int.
1387 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1388 Check for integer overflow in size calculations.
1389 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1390 avoid mishandling large integers.
1391 * lisp.h: Adjust decls to match defn changes elsewhere.
1392 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1393 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1394 (struct Lisp_Marker):
1395 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1396 (clip_to_bounds): Now an inline function, moved here from editfns.c.
1397 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1398 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1399 All callers changed.
1400 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1401 Assume the arg has valid form, since it always does.
1402 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1403 unsigned integer system type.
1404 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1405 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1406 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1407 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1408 (duration_to_sec_usec): New decl.
1409 * lread.c (read_from_string_index, read_from_string_index_byte)
1410 (read_from_string_limit, readchar, unreadchar, openp)
1411 (read_internal_start, read1, oblookup):
1412 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1413 (Fload, readevalloop, Feval_buffer, Feval_region):
1414 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1415 (openp): Check for out-of-range argument to 'access'.
1416 (read1): Use int, not EMACS_INT, where int is wide enough.
1417 Don't assume fixnum fits into int.
1418 Fix off-by-one error that can read outside a buffer.
1419 (read_filtered_event): Use duration_to_sec_usec
1420 to do proper overflow checking on durations.
1421 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1422 in size calculation.
1423 (Fexecute_kbd_macro):
1424 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1425 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1426 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1427 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1428 (set_marker_both, set_marker_restricted_both, marker_position)
1429 (marker_byte_position, Fbuffer_has_markers_at):
1430 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1431 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
1432 * menu.c (ensure_menu_items): Rename from grow_menu_items.
1433 It now merely ensures that the menu is large enough, without
1434 necessarily growing it, as this avoids some integer overflow issues.
1435 All callers changed.
1436 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1437 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1438 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1439 Use SAFE_ALLOCA_LISP, not alloca.
1440 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1441 to EMACS_INT. Check that fixnums are in proper range for system types.
1442 * minibuf.c (minibuf_prompt_width, string_to_object)
1443 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1444 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1445 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1446 (get_minibuffer, read_minibuf_unwind):
1447 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1448 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1449 this simplifies overflow checking. All callers changed.
1450 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1452 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1453 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1454 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1455 Check that fixnums are in proper range for system types.
1456 (Fx_create_frame, Fx_show_tip):
1457 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1458 * nsfont.m (ns_findfonts, nsfont_list_family):
1459 Don't assume fixnum fits in long.
1460 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1461 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1462 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1464 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
1465 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1466 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1467 (PRINTDECLARE, PRINTPREPARE):
1468 (strout, print_string):
1469 (print, print_preprocess, print_check_string_charset_prop)
1471 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1473 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1474 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1475 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
1476 (printchar, strout): Use xpalloc to catch size calculation overflow.
1477 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
1478 (print_error_message): Use SAFE_ALLOCA, not alloca.
1479 (print_object): Use int, not EMACS_INT, where int is wide enough.
1480 (print_depth, new_backquote_output, print_number_index):
1481 Use ptrdiff_t, not int, where int might not be wide enough.
1482 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1483 (Fset_process_window_size, Fformat_network_address)
1484 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
1486 Check that fixnums are in proper range for system types.
1487 (Fsignal_process): Simplify by avoiding a goto.
1488 Check for process-ids out of pid_t range rather than relying on
1490 (process_tick, update_tick): Use EMACS_INT, not int.
1491 (Fformat_network_address, read_process_output, send_process)
1492 (Fprocess_send_region, status_notify):
1493 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1494 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1495 (wait_reading_process_output, read_process_output, exec_sentinel):
1496 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1497 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1498 (Faccept_process_output): Use duration_to_sec_usec to do proper
1499 overflow checking on durations.
1500 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1501 Don't assume pid_t fits in int.
1502 * process.h (struct Lisp_Process): Members tick and update_tick
1503 are now of type EMACS_INT, not int.
1504 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1505 configured --with-wide-int.
1506 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1507 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1508 * search.c (looking_at_1, string_match_1):
1509 (fast_string_match, fast_c_string_match_ignore_case)
1510 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1511 (scan_newline, find_before_next_newline, search_command)
1512 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1513 (set_search_regs, wordify):
1516 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1517 (string_match_1, search_buffer, set_search_regs):
1519 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1520 (wordify): Check for overflow in size calculation.
1521 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1522 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1523 Check that fixnums are in proper range for system types.
1524 * sound.c (struct sound_device)
1525 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1526 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1527 (Fplay_sound_internal):
1528 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1529 * syntax.c (struct lisp_parse_state, find_start_modiff)
1530 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1531 (Fparse_partial_sexp):
1532 Don't assume fixnums can fit in int.
1533 (struct lisp_parse_state, find_start_pos, find_start_value)
1534 (find_start_value_byte, find_start_begv)
1535 (update_syntax_table, char_quoted, dec_bytepos)
1536 (find_defun_start, prev_char_comend_first, back_comment):
1537 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1538 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1539 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1540 (Finternal_describe_syntax_value): Check that match_lisp is a
1541 character, not an integer, since the code stuffs it into int.
1542 (scan_words, scan_sexps_forward):
1543 Check that fixnums are in proper range for system types.
1545 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1546 (scan_sexps_forward):
1547 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1548 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1549 * syntax.h: Adjust decls to match defn changes elsewhere.
1550 (struct gl_state_s):
1551 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1552 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1553 MOST_POSITIVE_FIXNUM.
1554 * sysdep.c (wait_for_termination_1, wait_for_termination)
1555 (interruptible_wait_for_termination, mkdir):
1556 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1557 (emacs_read, emacs_write):
1558 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1559 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1560 and double all fit in int.
1561 * term.c (set_tty_color_mode):
1562 Check that fixnums are in proper range for system types.
1563 * termhooks.h (struct input_event):
1564 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1565 * textprop.c (validate_interval_range, interval_of)
1566 (Fadd_text_properties, set_text_properties_1)
1567 (Fremove_text_properties, Fremove_list_of_text_properties)
1568 (Ftext_property_any, Ftext_property_not_all)
1569 (copy_text_properties, text_property_list, extend_property_ranges)
1570 (verify_interval_modification):
1571 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1572 (Fnext_single_char_property_change)
1573 (Fprevious_single_char_property_change):
1574 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1575 (copy_text_properties):
1576 Check for integer overflow in index calculation.
1577 * undo.c (last_boundary_position, record_point, record_insert)
1578 (record_delete, record_marker_adjustment, record_change)
1579 (record_property_change):
1580 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1581 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1582 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1583 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1584 (Fx_hide_tip, Fx_file_dialog):
1585 * w32menu.c (set_frame_menubar):
1586 Use ptrdiff_t, not int, for consistency with rest of code.
1587 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1588 (select_window, Fdelete_other_windows_internal)
1589 (window_scroll_pixel_based, window_scroll_line_based)
1590 (Frecenter, Fset_window_configuration):
1591 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1592 (Fset_window_hscroll, run_window_configuration_change_hook)
1593 (set_window_buffer, temp_output_buffer_show, scroll_command)
1594 (Fscroll_other_window, Frecenter):
1595 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1596 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1597 Don't assume fixnum fits in int.
1598 (Fset_window_scroll_bars):
1599 Check that fixnums are in proper range for system types.
1600 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1601 (string_pos, c_string_pos, number_of_chars, init_iterator)
1602 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1603 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1604 (compute_display_string_end, handle_face_prop)
1605 (face_before_or_after_it_pos, handle_invisible_prop)
1606 (handle_display_prop, handle_display_spec, handle_single_display_spec)
1607 (display_prop_intangible_p, string_buffer_position_lim)
1608 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1609 (get_overlay_strings_1, get_overlay_strings)
1610 (iterate_out_of_display_property, forward_to_next_line_start)
1611 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1612 (get_next_display_element, set_iterator_to_next)
1613 (get_visually_first_element, compute_stop_pos_backwards)
1614 (handle_stop_backwards, next_element_from_buffer)
1615 (move_it_in_display_line_to, move_it_in_display_line)
1616 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1617 (add_to_log, message_dolog, message_log_check_duplicate)
1618 (message2, message2_nolog, message3, message3_nolog
1619 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1620 (current_message_1, truncate_echo_area, truncate_message_1)
1621 (set_message, set_message_1, store_mode_line_noprop)
1622 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1623 (text_outside_line_unchanged_p, check_point_in_composition)
1624 (reconsider_clip_changes)
1625 (redisplay_internal, set_cursor_from_row, try_scrolling)
1626 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1627 (redisplay_window, find_last_unchanged_at_beg_row)
1628 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1629 (trailing_whitespace_p, find_row_edges, display_line)
1630 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1631 (display_mode_element, store_mode_line_string)
1632 (pint2str, pint2hrstr, decode_mode_spec)
1633 (display_count_lines, display_string, draw_glyphs)
1634 (x_produce_glyphs, x_insert_glyphs)
1635 (rows_from_pos_range, mouse_face_from_buffer_pos)
1636 (fast_find_string_pos, mouse_face_from_string_pos)
1637 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1638 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1639 (safe_call, init_from_display_pos, handle_fontified_prop)
1640 (handle_single_display_spec, load_overlay_strings)
1641 (with_echo_area_buffer, setup_echo_area_for_printing)
1642 (display_echo_area, echo_area_display)
1643 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1644 (update_tool_bar, hscroll_window_tree, redisplay_internal)
1645 (redisplay_window, dump_glyph_row, display_mode_line)
1646 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
1647 (handle_display_spec, display_prop_string_p):
1648 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1649 (handle_single_display_spec, build_desired_tool_bar_string)
1650 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1651 (get_specified_cursor_type):
1652 Check that fixnums are in proper range for system types.
1653 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1654 (Flookup_image_map):
1655 Don't assume fixnums fit in int.
1656 (compare_overlay_entries):
1657 Avoid mishandling comparisons due to subtraction overflow.
1658 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1659 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1660 (handle_tool_bar_click):
1661 Use int, not unsigned, since we prefer signed and the signedness
1662 doesn't matter here.
1663 (get_next_display_element, next_element_from_display_vector):
1664 Use int, not EMACS_INT, when int is wide enough.
1665 (start_hourglass): Use duration_to_sec_usec to do proper
1666 overflow checking on durations.
1667 * xfaces.c (Fbitmap_spec_p):
1668 Check that fixnums are in proper range for system types.
1669 (compare_fonts_by_sort_order):
1670 Avoid mishandling comparisons due to subtraction overflow.
1671 (Fx_family_fonts, realize_basic_faces):
1672 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1674 Don't assume fixnum fits in int.
1675 Use SAFE_ALLOCA_LISP, not alloca.
1676 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1677 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1678 (face_at_buffer_position, face_for_overlay_string)
1679 (face_at_string_position):
1680 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1681 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1682 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1684 Check that fixnums are in proper range for system types.
1685 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1686 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1687 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1688 (Fx_change_window_property): Don't assume fixnums fit in int.
1689 * xfont.c (xfont_chars_supported):
1690 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1691 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1692 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1693 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1694 * xml.c (parse_region):
1695 * xrdb.c (magic_file_p):
1696 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1697 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1698 (x_get_local_selection, x_reply_selection_request)
1699 (x_handle_selection_request, wait_for_property_change):
1700 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1701 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1702 short is wide enough.
1703 (x_send_client_event): Don't assume fixnum fits in int.
1704 * xterm.c (x_x_to_emacs_modifiers):
1705 Don't assume EMACS_INT overflows nicely into int.
1706 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1708 (handle_one_xevent): NATNUMP can eval its arg twice.
1709 (x_connection_closed):
1710 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1711 * xterm.h: Adjust decls to match defn changes elsewhere.
1712 (struct scroll_bar): Use struct vectorlike_header
1713 rather than rolling our own approximation.
1714 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1716 2012-05-25 Glenn Morris <rgm@gnu.org>
1718 * lisp.mk (lisp): Update for more files being compiled now.
1720 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1722 * lread.c: Remove `read_pure' which makes no difference.
1723 (read_pure): Remove var.
1724 (unreadpure): Remove function.
1725 (readevalloop): Don't call read_list with -1 flag.
1726 (read1, read_vector): Don't test read_pure any more.
1727 (read_list): Simplify.
1729 * fileio.c, character.h: Minor style tweaks.
1731 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1733 * window.h (clip_changed): Remove useless declaration.
1735 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
1737 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1738 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1740 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1743 This directory predates autoconf and is no longer needed nowadays.
1744 Move its few remaining bits of functionality to where they're needed.
1745 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1746 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1747 * m/template.h: Remove.
1748 * Makefile.in (M_FILE): Remove. All uses removed.
1749 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1750 * lisp.h (USE_LSB_TAG):
1751 * mem-limits.h (EXCEEDS_LISP_PTR):
1752 Use VAL_MAX, not VALBITS, in #if.
1753 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1754 (EMACS_UINT): Define unconditionally now.
1755 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1756 (BITS_PER_EMACS_INT): New constants, replacing
1757 what used to be in config.h, but not useful in #if.
1758 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1759 define them any more.
1760 (VAL_MAX): New macro.
1762 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1763 BITS_PER_EMACS_INT, in #if.
1764 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1765 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1766 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1767 * s/ms-w32.h (DATA_START):
1768 Move here from removed file m/intel386.h.
1769 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1770 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1772 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1774 Assume C89 or later.
1775 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1776 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1778 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1779 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1780 * textprop.c, tparam.c (NULL): Remove.
1781 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1782 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1783 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1784 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1785 * xterm.c (input_signal_count): Assume volatile works.
1787 2012-05-21 Ken Brown <kbrown@cornell.edu>
1789 * xgselect.c (xg_select): Fix first argument in call to 'select'
1792 2012-05-20 Ken Brown <kbrown@cornell.edu>
1794 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
1795 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1797 2012-05-19 Ken Brown <kbrown@cornell.edu>
1799 * xfns.c (x_in_use): Remove `static' qualifier.
1800 * xterm.h (x_in_use): Declare.
1801 * xgselect.c: Include xterm.h.
1802 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1803 and `display_arg' (bug#9754).
1805 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1807 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1809 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1810 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1812 2012-05-18 Eli Zaretskii <eliz@gnu.org>
1814 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1816 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1817 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1819 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1820 reference to image_cache->refcount.
1821 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1823 2012-05-17 Juri Linkov <juri@jurta.org>
1825 * search.c (Fword_search_regexp, Fword_search_backward)
1826 (Fword_search_forward, Fword_search_backward_lax)
1827 (Fword_search_forward_lax): Move functions to isearch.el
1828 (bug#10145, bug#11381).
1830 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1832 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1834 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1836 * lread.c (init_obarray): Declare Qt and Qnil as special.
1838 2012-05-14 Glenn Morris <rgm@gnu.org>
1840 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
1841 Put "libexec" before "bin", for the sake of init_callproc_1.
1843 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1845 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1847 * unexaix.c: Port to more-recent AIX compilers.
1848 (report_error, report_error_1, make_hdr, copy_sym)
1849 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1850 Make arguments const char *, not char *, to avoid violations of C
1851 standard and to fix some AIX warnings reported by Gilles Pion.
1853 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1855 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1856 already have overlays loaded.
1857 (handle_single_display_spec): Before returning without displaying
1858 fringe bitmap, synchronize the bidi iterator with the main display
1859 iterator, by calling iterate_out_of_display_property.
1860 (iterate_out_of_display_property): Detect buffer iteration by
1861 testing that it->string is a Lisp string.
1862 (get_next_display_element): When the current object is exhausted,
1863 and there's something on it->stack, call set_iterator_to_next to
1864 proceed with what's on the stack, instead of returning zero.
1865 (set_iterator_to_next): If called at the end of a Lisp string,
1866 proceed to consider_string_end without incrementing string
1867 position. Don't increment display vector index past the end of
1868 the display vector. (Bug#11417)
1869 (pos_visible_p): Don't report a position visible when move_it_to
1870 stopped at the last line of window, which happens to be scanned
1871 backwards by the bidi iteration. (Bug#11464)
1873 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1875 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1876 and right-margin display specs even if the spec is invalid or we
1877 are on a TTY, and thus unable to display on the fringes.
1878 That's because the text with the property will not be displayed anyway,
1879 so we need to signal to the caller that this is a "replacing"
1880 display spec. This fixes display when the spec is invalid or we
1883 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1885 * unexaix.c (make_hdr): Fix typo in prototype.
1886 This bug broke the build on AIX. Problem reported by Gilles Pion.
1888 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
1890 * keyboard.c (kbd_buffer_get_event): Read special events also in
1891 batch mode. (Bug#11415)
1893 2012-05-12 Glenn Morris <rgm@gnu.org>
1895 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1897 2012-05-12 Eli Zaretskii <eliz@gnu.org>
1899 * lisp.mk (lisp): Add newcomment.elc.
1901 2012-05-12 Glenn Morris <rgm@gnu.org>
1903 * Makefile.in (MKDIR_P): New, set by configure.
1904 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1906 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1908 Remove unused function hourglass_started.
1909 * dispextern.h (hourglass_started):
1910 * w32fns.c (hourglass_started):
1911 * xdisp.c (hourglass_started): Remove.
1913 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
1915 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1916 Update dependencies.
1918 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1920 * xgselect.c (xg_select): Put maxfds+1 into a var.
1921 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1923 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1925 2012-05-10 Dave Abrahams <dave@boostpro.com>
1927 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1928 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1930 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
1932 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1933 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1934 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1935 Initialize xd_registered_buses.
1937 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1939 Untag more efficiently if USE_LSB_TAG.
1940 This is based on a proposal by YAMAMOTO Mitsuharu in
1941 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1942 For an admittedly artificial (nth 8000 longlist) benchmark on
1943 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1944 Emacs's overall text size by 1%.
1945 * lisp.h (XUNTAG): New macro.
1946 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1947 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1948 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1949 * eval.c (Fautoload):
1950 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1951 * frame.h (XFRAME): Use XUNTAG.
1953 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1954 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1955 Remove unportable assumptions about print widths of types like
1957 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1958 intptr_t when converting between pointer and integer, to avoid GCC
1959 warnings about wrong width.
1961 2012-05-09 Eli Zaretskii <eliz@gnu.org>
1963 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1964 stack for each reader_thread, instead of defaulting to 8MB
1965 determined by the linker. This avoids failures in creating
1966 subprocesses on Windows 7, see the discussion in this thread:
1967 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1969 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1971 Fix up display of the *Minibuf-0* buffer in the mini window.
1972 * keyboard.c (read_char): Don't clear the echo area if there's no
1974 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
1975 contents of *Minibuf-0*) if there's no message displayed in its stead.
1977 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
1979 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1982 2012-05-06 Chong Yidong <cyd@gnu.org>
1984 * lisp.mk (lisp): Update.
1986 2012-05-05 Jim Meyering <meyering@redhat.com>
1988 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1990 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1992 * data.c (PUT_ERROR): New macro.
1993 (syms_of_data): Use it. Add new error type `user-error'.
1994 * undo.c (user_error): New function.
1995 (Fprimitive_undo): Use it.
1996 * print.c (print_error_message): Adjust print style for `user-error'.
1997 * keyboard.c (user_error): New function.
1998 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2000 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2002 Do not limit current-time-string to years 1000..9999.
2003 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2004 (Fcurrent_time_string): Support any year that is supported by the
2005 underlying localtime representation. Don't use asctime, as it
2006 has undefined behavior for years outside the range -999..9999.
2008 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2010 Fix race conditions involving setenv, gmtime, localtime, asctime.
2011 Without this fix, interrupts could mess up code that uses these
2012 nonreentrant functions, since setting TZ invalidates existing
2013 tm_zone or tzname values, and since most of these functions return
2014 pointers to static storage.
2015 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2016 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2017 Grow the critical sections to include not just invoking
2018 localtime/gmtime, but also accessing these functions' results
2019 including their tm_zone values if any, and any related TZ setting.
2020 (format_time_string): Last arg is now struct tm *, not struct tm **,
2021 so that the struct tm is saved in the critical section.
2022 All callers changed. Simplify allocation of initial buffer, partly
2023 motivated by the fact that memory allocation needs to be outside
2024 the critical section.
2026 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2028 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2029 with RESET_INTERVAL.
2031 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2032 Remove duplicated buffer name initialization.
2034 2012-05-02 Jim Meyering <jim@meyering.net>
2036 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2038 * xfns.c (x_window): Use xstrdup (Bug#11375).
2040 2012-05-02 Eli Zaretskii <eliz@gnu.org>
2042 * xdisp.c (pos_visible_p): If already at a newline from the
2043 display string before the 'while' loop, don't walk back the glyphs
2044 from it3.glyph_row. Solves assertion violation when the display
2045 string begins with a newline (egg.el). (Bug#11367)
2047 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2049 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2052 2012-05-01 Glenn Morris <rgm@gnu.org>
2054 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2055 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2056 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2057 All were removed before 23.1.
2059 * dispnew.c: Remove HAVE_LIBNCURSES test;
2060 it is always true on relevant platforms.
2062 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2063 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2065 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2067 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2069 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2070 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2073 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2075 Do not avoid creating empty evaporating overlays (Bug#9642).
2076 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2077 That is, do not delete an evaporating overlay if it becomes
2078 empty after its bounds are adjusted to fit within its buffer.
2079 This fix caused other problems, and I'm reverting it until we get
2080 to the bottom of them.
2082 2012-04-27 Chong Yidong <cyd@gnu.org>
2084 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2086 2012-04-27 Eli Zaretskii <eliz@gnu.org>
2088 * xdisp.c (pos_visible_p): If the window start position is beyond
2089 ZV, start the display from buffer beginning. Prevents assertion
2090 violation in init_iterator when the minibuffer window is scrolled
2093 * window.c (window_scroll_pixel_based): Likewise.
2095 2012-04-27 Chong Yidong <cyd@gnu.org>
2097 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2099 2012-04-27 Glenn Morris <rgm@gnu.org>
2101 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2102 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2104 2012-04-27 Eli Zaretskii <eliz@gnu.org>
2106 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2107 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
2109 2012-04-26 Eli Zaretskii <eliz@gnu.org>
2111 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2112 display element, check also the underlying string or buffer
2113 character. (Bug#11341)
2115 * w32menu.c: Include w32heap.h.
2116 (add_menu_item): If the call to AppendMenuW (via
2117 unicode_append_menu) fails, disable Unicode menus only if we are
2118 running on Windows 9X/Me.
2120 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2122 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2123 (xgetint): Add missing shift for LSB tags.
2125 2012-04-24 Martin Rudalics <rudalics@gmx.at>
2127 * keyboard.c (read_char): Don't wipe echo area for select window
2128 events: These might get delayed via `mouse-autoselect-window'
2131 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
2133 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2134 manipulation of :loaded-from data.
2136 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
2138 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2139 now a cons (bug#11311).
2141 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2143 Do not create empty overlays with the evaporate property (Bug#9642).
2144 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2145 if it becomes empty after its bounds are adjusted to fit within
2146 its buffer. Without this fix, in a nonempty buffer (let ((o
2147 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2148 yields an empty overlay that has the evaporate property, which is
2149 not supposed to happen.
2151 Fix minor GTK3 problems found by static checking.
2152 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2153 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2154 (struct _EmacsFixedClass, emacs_fixed_get_type):
2155 Move decls here from emacsgtkfixed.h, since they needn't be public.
2156 (emacs_fixed_get_type): Now static.
2157 (emacs_fixed_class_init): Omit unused local.
2158 (emacs_fixed_child_type): Remove; unused.
2159 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2160 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2161 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2162 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2163 (EMACS_FIXED_GET_CLASS): Remove; unused.
2164 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2166 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2167 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2169 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2171 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
2172 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
2173 (__malloc_size_t, __malloc_ptrdiff_t):
2174 Remove. All uses removed, replaced by the definiens if needed,
2175 since we can assume C89 or better now.
2176 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2177 (protect_malloc_state, align, get_contiguous_space)
2178 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2179 (malloc_atfork_handler_child, malloc_enable_thread)
2180 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2181 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2182 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2183 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2184 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2185 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2186 Define using prototypes, not old style.
2187 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2188 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2189 (align): Don't assume that signed integer overflow wraps around.
2190 Omit unused local var.
2191 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2192 (_free_internal_nolock, memalign, mallochook, reallochook):
2193 Omit no-longer-needed casts.
2194 (valloc): Use getpagesize, not __getpagesize.
2195 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2196 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2198 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2200 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
2202 Move functions from C to Lisp. Make non-blocking method calls
2203 the default. Implement further D-Bus standard interfaces.
2205 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2206 (QCdbus_request_name_allow_replacement)
2207 (QCdbus_request_name_replace_existing)
2208 (QCdbus_request_name_do_not_queue)
2209 (QCdbus_request_name_reply_primary_owner)
2210 (QCdbus_request_name_reply_in_queue)
2211 (QCdbus_request_name_reply_exists)
2212 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2213 (QCdbus_registered_serial, QCdbus_registered_method)
2214 (QCdbus_registered_signal): New Lisp objects.
2215 (XD_DEBUG_MESSAGE): Use sizeof.
2216 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2217 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2218 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2219 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2220 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2221 (xd_signature, xd_append_arg): Allow float for integer types.
2222 (xd_get_connection_references): New function.
2223 (xd_get_connection_address): Rename from xd_initialize.
2224 Return cached address.
2225 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2226 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2228 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
2229 Return number of refcounts.
2230 (Fdbus_get_unique_name): Make stronger parameter check.
2231 (Fdbus_message_internal): New defun.
2232 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2233 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2234 (Fdbus_send_signal, Fdbus_register_service)
2235 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2236 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2237 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2238 (Vdbus_compiled_version, Vdbus_runtime_version)
2239 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2240 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2241 (Vdbus_message_type_signal): New defvars.
2242 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2245 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2247 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2248 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2249 Do not assume ptrdiff_t is the same width as 'int'.
2251 * alloc.c: Handle unusual debugging option combinations.
2252 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2253 since the two debugging options are incompatible.
2254 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2256 (mem_init, mem_insert, mem_insert_fixup):
2257 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2258 (NEED_MEM_INSERT): Remove; no longer needed.
2260 2012-04-22 Leo Liu <sdl.web@gmail.com>
2262 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2264 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2266 * sysdep.c [__FreeBSD__]: Minor cleanups.
2267 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2268 Use Emacs indenting style more consistently. Avoid some casts.
2269 Use 'double' consistently rather than mixing 'float' and 'double'.
2271 2012-04-21 Eduard Wiebe <usenet@pusto.de>
2273 * sysdep.c (list_system_processes, system_process_attributes):
2274 Add implementation for FreeBSD (Bug#5243).
2276 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2278 * lisp.mk (lisp): Update.
2280 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2282 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2283 It is never used otherwise.
2285 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2287 * print.c (print_preprocess): Only check print_depth if print-circle
2289 (print_object): Check for cycles even when print-circle is nil and
2290 print-gensym is t, but only check print_depth if print-circle is nil.
2292 2012-04-20 Chong Yidong <cyd@gnu.org>
2294 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2295 set the status to "failed" and ensure that sentinel is run.
2297 2012-04-20 Glenn Morris <rgm@gnu.org>
2299 * process.c (Fset_process_inherit_coding_system_flag)
2300 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
2301 (Fmake_network_process, Fmake_serial_process): Doc fix.
2303 2012-04-20 Eli Zaretskii <eliz@gnu.org>
2305 * xdisp.c (string_buffer_position_lim): Limit starting position to
2307 (set_cursor_from_row): If called for a mode-line or header-line
2308 row, return zero immediately.
2309 (try_cursor_movement): If inside continuation line, don't back up
2310 farther than the first row after the header line, if any.
2311 Don't consider the header-line row as "partially visible", even if
2312 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2314 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
2316 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2319 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
2320 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
2322 configure: new option --enable-gcc-warnings (Bug#11207)
2323 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2324 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2325 (ALL_CFLAGS): Use new macros rather than old.
2326 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2327 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2328 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2329 -Wunused-result, -Wunused-variable. This should go away once
2330 the Emacs and Gnulib regex code is merged.
2331 (xmalloc, xrealloc): Now static.
2333 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2335 * dired.c (Fsystem_groups): Remove unused local.
2337 2012-04-17 Glenn Morris <rgm@gnu.org>
2339 * dired.c (Fsystem_users): Doc fix.
2341 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2343 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2344 (syms_of_dired): Add them.
2346 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2348 Fix minor alloc.c problems found by static checking.
2349 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2350 New extern decls, to avoid calling undeclared functions.
2351 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2352 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2353 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2354 (NEED_MEM_INSERT): New macro.
2355 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
2356 Remove one incorrect comment and fix another.
2358 Fix minor ralloc.c problems found by static checking.
2359 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2360 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2361 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2362 (r_alloc_sbrk): Now static.
2364 Improve ralloc.c interface checking.
2365 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2366 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2367 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2368 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2369 [REL_ALLOC]: ... to here, to check interface.
2370 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2371 Remove decls. This fixes an "It stinks!".
2373 * alloc.c (which_symbols): Fix alignment issue / type clash.
2375 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2377 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2378 (struct Lisp_Misc_Any): Likewise.
2379 (struct Lisp_Free): Likewise.
2380 * alloc.c (union aligned_Lisp_Symbol): Define.
2381 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2382 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2383 (union aligned_Lisp_Misc): Define.
2384 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2385 aligned_Lisp_Misc instead of union Lisp_Misc.
2386 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
2388 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2390 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2391 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2392 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2393 * s/netbsd.h, s/sol2-6.h:
2394 Remove definition of GC_MARK_STACK, since the default now works.
2395 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2396 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2397 no longer the default.
2398 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2400 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
2402 * lread.c (lisp_file_lexically_bound_p):
2403 Fix hang at ";-*-\n" (bug#11238).
2405 2012-04-14 Eli Zaretskii <eliz@gnu.org>
2407 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2408 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2410 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2412 * nsterm.m (constrainFrameRect): Always constrain when there is only
2413 one screen (Bug#10962).
2415 2012-04-13 Ken Brown <kbrown@cornell.edu>
2417 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2419 2012-04-13 Reuben Thomas <rrt@sc3d.org>
2421 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2423 2012-04-11 Daniel Colascione <dancol@dancol.org>
2425 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2426 against is gone. It's better to use vfork now so that when Cygwin
2427 gains a new, working vfork, we use it automatically (bug#10398).
2429 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2431 * window.c (save_window_save): Obey window-point-insertion-type.
2433 2012-04-11 Glenn Morris <rgm@gnu.org>
2435 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2437 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2439 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2441 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
2443 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2444 (force_quit_count): New var.
2445 (handle_interrupt): Use it.
2447 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
2449 * w32.c (w32_delayed_load): Record the full path of the library
2450 being loaded (bug#10424).
2452 2012-04-09 Glenn Morris <rgm@gnu.org>
2454 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2455 not just in the obarray, before snarfing them. (Bug#11036)
2457 * Makefile.in ($(leimdir)/leim-list.el):
2458 Pass EMACS rather than BUILT_EMACS.
2460 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2462 * process.c (make_process):
2463 * process.h: Add integer `gnutls_handshakes_tried' member to
2466 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2467 Add convenience `GNUTLS_LOG2i' macro.
2469 * gnutls.c (gnutls_log_function2i): Convenience log function.
2470 (emacs_gnutls_read): Use new log functions,
2471 `gnutls_handshakes_tried' process member, and
2472 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2473 attempts per process (connection).
2475 2012-04-09 Chong Yidong <cyd@gnu.org>
2477 * eval.c (Fuser_variable_p, user_variable_p_eh)
2478 (lisp_indirect_variable): Functions deleted.
2479 (Fdefvar): Caller changed.
2481 * callint.c (Finteractive, Fcall_interactively):
2482 * minibuf.c (Fread_variable): Callers changed.
2484 2012-04-09 Eli Zaretskii <eliz@gnu.org>
2486 * xdisp.c (set_cursor_from_row): If the display string appears in
2487 the buffer at position that is closer to point than the position
2488 after the display string, display the cursor on the first glyph of
2489 the display string. Fixes cursor display when a 'display' text
2490 property immediately follows invisible text. (Bug#11094)
2492 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2494 composite.c: use 'double' consistently
2495 * composite.c (get_composition_id): Use 'double' consistently
2496 instead of converting 'float' to 'double' and vice versa; this is
2497 easier to understand and avoids a GCC warning.
2499 2012-04-09 Glenn Morris <rgm@gnu.org>
2501 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2502 preparation for dumping it with emacs. (Bug#4789)
2503 (leimdir): New variable.
2504 ($(leimdir)/leim-list.el): New rule.
2505 (emacs$(EXEEXT)): Depend on leim-list.el.
2507 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2508 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2509 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2511 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2513 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2516 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
2518 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2519 Remove unused local variable.
2521 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2523 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2524 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2525 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2526 objects, as mark_maybe_pointer will catch them otherwise.
2527 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2528 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2530 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2532 Fix typo that broke non-Windows builds.
2533 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2535 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2537 Support building on MS-Windows with libxml2.
2539 * makefile.w32-in (OBJ2): Add xml.$(O).
2540 (GLOBAL_SOURCES): Add xml.c.
2541 ($(BLD)/xml.$(O)): New dependency list.
2543 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2544 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2545 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2546 [!WINDOWSNT]: New macros.
2547 (init_libxml2_functions, libxml2_loaded_p): New functions.
2548 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2549 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2550 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2551 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2553 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2554 Call init_libxml2_functions before calling libxml2 functions.
2555 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2557 * emacs.c: Don't include libxml/parser.h.
2558 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2559 xmlCleanupParser directly.
2561 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2563 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2565 * indent.c (Fvertical_motion): If there is a display string at
2566 point, use it.vpos to compute how many lines to backtrack after
2567 move_it_to point. (Bug#11133)
2569 2012-04-06 Eli Zaretskii <eliz@gnu.org>
2571 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2572 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2573 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2574 macros related to unification of CJK characters. For the details,
2575 see the discussion following the message here:
2576 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2578 2012-04-04 Chong Yidong <cyd@gnu.org>
2580 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2582 2012-04-01 Eli Zaretskii <eliz@gnu.org>
2584 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2585 instead of alloca. (Bug#11138)
2587 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2589 * w32menu.c (is_simple_dialog): Properly check lisp types.
2592 2012-03-31 Eli Zaretskii <eliz@gnu.org>
2594 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2595 position we get to after a call to move_it_to fails the
2596 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2597 only if we wind up in a string from display property. (Bug#11063)
2599 * window.c (Fdelete_other_windows_internal): Invalidate the row
2600 and column information about mouse highlight, so that redisplay
2601 restores it after reallocating the glyph matrices. (Bug#7464)
2603 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2604 string comes from a `display' text property, use the buffer
2605 position of that property as if we actually saw that position in
2607 (move_it_by_lines): Remove the assertion that
2608 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2609 violated when there's a before-string at the beginning of a line.
2612 2012-03-30 Eli Zaretskii <eliz@gnu.org>
2614 * xdisp.c (append_space_for_newline): If the default face was
2615 remapped, use the remapped face for the appended newline.
2616 (extend_face_to_end_of_line): Use the remapped default face for
2617 extending the face to the end of the line.
2618 (display_line): Call extend_face_to_end_of_line when the default
2619 face was remapped. (Bug#11068)
2621 2012-03-29 Eli Zaretskii <eliz@gnu.org>
2623 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2625 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2627 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2629 2012-03-27 Glenn Morris <rgm@gnu.org>
2631 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2634 2012-03-26 Kenichi Handa <handa@m17n.org>
2636 * dispextern.h (struct glyph): Fix previous change. Change the
2637 bit length of glyphless.ch to 25 (Bug#11082).
2639 2012-03-26 Chong Yidong <cyd@gnu.org>
2641 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2642 (command_loop_1): Use it; inhibit selection update for
2643 handle-select-window too (Bug#8996).
2645 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2647 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
2649 2012-03-25 Kenichi Handa <handa@m17n.org>
2651 * dispextern.h (struct glyph): Change the bit length of
2652 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2654 2012-03-24 Eli Zaretskii <eliz@gnu.org>
2656 * s/ms-w32.h (tzname): Include time.h before redirecting to
2657 _tzname. Fixes the MSVC build. (Bug#9960)
2659 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2661 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2664 * xterm.c (XTread_socket): Only modify handling_signal if
2665 !SYNC_INPUT. (Bug#11080)
2667 2012-03-23 Eli Zaretskii <eliz@gnu.org>
2669 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2670 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2671 when fetching a multibyte character consumes more bytes than
2672 CHAR_BYTES returns, due to unification of CJK characters in
2673 string_char. (Bug#11073)
2675 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2677 * process.c (wait_reading_process_output): Handle pty disconnect
2678 by refraining from sending oneself a SIGCHLD (bug#10933).
2680 2012-03-22 Chong Yidong <cyd@gnu.org>
2682 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2684 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
2685 Mark string as coming from a prefix property.
2686 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2687 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2689 2012-03-21 Chong Yidong <cyd@gnu.org>
2691 * xfaces.c (Vface_remapping_alist): Doc fix.
2693 2012-03-20 Eli Zaretskii <eliz@gnu.org>
2695 * w32proc.c (Fw32_set_console_codepage)
2696 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2699 2012-03-20 Chong Yidong <cyd@gnu.org>
2701 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2702 to reflect default non-nil value of redisplay-dont-pause.
2704 2012-03-19 Kenichi Handa <handa@m17n.org>
2706 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2707 it fit in a valid range (Bug#11003).
2709 2012-03-18 Eli Zaretskii <eliz@gnu.org>
2711 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2712 that is not from display property, accept the row as a "cursor
2713 row" if one of the string's character has a non-nil `cursor'
2714 property. Fixes cursor positioning when there are newlines in
2715 overlay strings, e.g. in icomplete.el. (Bug#11035)
2717 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2719 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2721 2012-03-12 Chong Yidong <cyd@gnu.org>
2723 * eval.c (inhibit_lisp_code): Rename from
2724 inhibit_window_configuration_change_hook; move from window.c.
2726 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2727 * window.c (run_window_configuration_change_hook)
2728 (syms_of_window): Callers changed.
2730 2012-03-11 Chong Yidong <cyd@gnu.org>
2732 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2734 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2736 2012-03-10 Chong Yidong <cyd@gnu.org>
2738 * frame.c (other_visible_frames): Don't assume the selected frame
2739 is visible (Bug#10955).
2741 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2743 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2745 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2747 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2748 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2751 2012-03-03 Glenn Morris <rgm@gnu.org>
2753 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
2755 2012-03-02 Eli Zaretskii <eliz@gnu.org>
2757 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2758 position past the first glyph_row that ends at ZV. (Bug#10902)
2759 (redisplay_window, next_element_from_string): Fix typos in
2761 (redisplay_window): Pass to move_it_vertically the margin in
2762 pixels, not in screen lines.
2764 2012-03-02 Glenn Morris <rgm@gnu.org>
2766 * buffer.c (buffer-list-update-hook): Doc fix.
2768 2012-02-29 Eli Zaretskii <eliz@gnu.org>
2770 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2771 push_it before setting up the iterator for the first overlay
2772 string, even if we have an empty string loaded.
2773 (next_overlay_string): If there's an empty string on the iterator
2774 stack, pop the stack. (Bug#10903)
2776 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2778 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2779 Suggested by Stefan Monnier in
2780 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2781 * alloc.c (widen_to_Lisp_Object): New static function.
2782 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2783 and widening them to Lisp_Objects. This would work even if
2784 USE_LSB_TAG is defined and wide integers are used, which might
2785 happen in a future version of Emacs.
2787 2012-02-25 Chong Yidong <cyd@gnu.org>
2789 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2792 * xselect.c (Fx_selection_exists_p): Doc fix.
2793 (x_clipboard_manager_save_all): Print an informative message
2794 before saving to clipboard manager.
2796 2012-02-24 Chong Yidong <cyd@gnu.org>
2798 * keyboard.c (process_special_events): Handle all X selection
2799 requests in kbd_buffer, not just the next one (Bug#8869).
2801 2012-02-23 Chong Yidong <cyd@gnu.org>
2803 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2804 call when setting menu-bar-lines and tool-bar-lines parameters.
2805 (unwind_create_frame_1): New helper function.
2807 * window.c (inhibit_window_configuration_change_hook): New var.
2808 (run_window_configuration_change_hook): Obey it.
2809 (syms_of_window): Initialize it.
2811 2012-02-22 Chong Yidong <cyd@gnu.org>
2813 * xterm.c (x_draw_image_relief): Add missing type check for
2814 Vtool_bar_button_margin (Bug#10743).
2816 2012-02-21 Chong Yidong <cyd@gnu.org>
2818 * fileio.c (Vfile_name_handler_alist): Doc fix.
2820 * buffer.c (Fget_file_buffer): Protect against invalid file
2821 handler return value.
2823 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2825 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2826 when computing $valmask.
2828 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2829 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2830 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2831 It's useless in that case, and it can cause problems on hosts
2832 that allocate halves of EMACS_INT values separately.
2833 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2834 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2835 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2836 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2837 it avoids undefined behavior on hosts where shifting right by more
2838 than the word width has undefined behavior.
2840 2012-02-19 Chong Yidong <cyd@gnu.org>
2842 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2843 (Funhandled_file_name_directory, Ffile_name_as_directory)
2844 (Fdirectory_file_name, Fexpand_file_name)
2845 (Fsubstitute_in_file_name): Protect against invalid file handler
2846 return values (Bug#10845).
2848 2012-02-18 Eli Zaretskii <eliz@gnu.org>
2850 * .gdbinit (pitx): Fix incorrect references to fields of the
2853 2012-02-17 Chong Yidong <cyd@gnu.org>
2855 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2857 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2859 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2860 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2862 2012-02-15 Chong Yidong <cyd@gnu.org>
2864 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2865 marked as special. Also, starting docstrings with * is obsolete.
2867 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2869 * gnutls.c (emacs_gnutls_write): Fix last change.
2871 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2873 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2876 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2878 * keymap.c (Fsingle_key_description): Handle char ranges.
2880 2012-02-12 Chong Yidong <cyd@gnu.org>
2882 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2883 as that creates a dangerous corner case.
2885 * window.c (Fdelete_window_internal): Invalidate the mouse
2886 highlight (Bug#9904).
2888 2012-02-12 Glenn Morris <rgm@gnu.org>
2890 * xselect.c (Fx_own_selection_internal)
2891 (Fx_get_selection_internal, Fx_disown_selection_internal)
2892 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2893 * nsselect.m (Fx_own_selection_internal)
2894 (Fx_disown_selection_internal, Fx_selection_exists_p)
2895 (Fx_selection_owner_p, Fx_get_selection_internal):
2896 Sync docs and argument specs with the xselect.c versions.
2898 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2900 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2902 2012-02-11 Eli Zaretskii <eliz@gnu.org>
2904 * w32select.c (Fx_selection_exists_p): Sync doc string and
2905 argument list with xselect.c. (Bug#10783)
2907 * w16select.c (Fx_selection_exists_p): Sync doc string and
2908 argument list with xselect.c. (Bug#10783)
2910 2012-02-10 Glenn Morris <rgm@gnu.org>
2912 * fns.c (Fsecure_hash): Doc fix.
2914 2012-02-09 Kenichi Handa <handa@m17n.org>
2916 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2918 2012-02-07 Chong Yidong <cyd@gnu.org>
2920 * buffer.c (Fbuffer_local_variables)
2921 (buffer_lisp_local_variables): Handle unbound vars correctly;
2922 don't let Qunbound leak into Lisp.
2924 2012-02-07 Glenn Morris <rgm@gnu.org>
2926 * image.c (Fimagemagick_types): Doc fix.
2928 * image.c (imagemagick-render-type): Change it from a lisp object
2929 to an integer. Move the doc here from the lisp manual.
2930 Treat all values not equal to 0 the same.
2932 2012-02-06 Chong Yidong <cyd@gnu.org>
2934 * doc.c (store_function_docstring): Avoid applying docstring of
2935 alias to base function (Bug#2603).
2937 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2939 * .gdbinit (pp1, pv1): Remove redundant defines.
2942 2012-02-04 Chong Yidong <cyd@gnu.org>
2944 * nsterm.m: Declare a global (Bug#10694).
2946 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2948 * w32.c (get_emacs_configuration_options):
2949 Include --enable-checking, if specified, in the return value.
2951 2012-02-04 Martin Rudalics <rudalics@gmx.at>
2953 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2954 after rounding frame sizes. (Bug#9723)
2956 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2958 * keyboard.c (adjust_point_for_property): Don't position point
2959 before BEGV. (Bug#10696)
2961 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2963 Handle overflow when computing char display width (Bug#9496).
2964 * character.c (char_width): Return EMACS_INT, not int.
2965 (char_width, c_string_width): Check for overflow when
2966 computing the width; this is possible now that individual
2967 characters can have unbounded width. Problem introduced
2968 by merge from Emacs 23 on 2012-01-19.
2970 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
2972 * dbusbind.c (Fdbus_register_method): Mention the return value
2973 :ignore in the docstring.
2975 2012-02-02 Glenn Morris <rgm@gnu.org>
2977 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2979 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2980 Unconditionally set to t. (Bug#10673)
2981 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2982 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2983 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2985 2012-02-02 Kenichi Handa <handa@m17n.org>
2987 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2988 0, do not call append_composite_glyph.
2990 2012-02-02 Kenichi Handa <handa@m17n.org>
2992 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2994 (x_produce_glyphs): If the component of a composition is a null
2995 string, set it->pixel_width to 1 to avoid zero-width glyph.
2997 2012-02-01 Eli Zaretskii <eliz@gnu.org>
2999 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3000 first 2 arguments are identical. This makes inserting large
3001 output from a subprocess an order of magnitude faster on
3002 MS-Windows, where all sbrk'ed memory is always contiguous.
3004 2012-01-31 Glenn Morris <rgm@gnu.org>
3006 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3007 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3008 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3010 2012-01-29 Glenn Morris <rgm@gnu.org>
3012 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3014 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3016 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3018 2012-01-28 Chong Yidong <cyd@gnu.org>
3020 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3022 2012-01-26 Chong Yidong <cyd@gnu.org>
3024 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3026 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3027 repeat counts (Bug#10507).
3029 2012-01-26 Glenn Morris <rgm@gnu.org>
3031 * lread.c (syms_of_lread): Doc fix.
3033 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3035 * coding.c (encode_designation_at_bol): Change return value to
3038 2012-01-25 Chong Yidong <cyd@gnu.org>
3040 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3042 2012-01-21 Chong Yidong <cyd@gnu.org>
3044 * floatfns.c (Fcopysign): Make the second argument non-optional,
3045 since nil is not allowed anyway.
3047 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3049 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3050 (send_process): Likewise.
3052 2012-01-19 Martin Rudalics <rudalics@gmx.at>
3054 * window.c (save_window_save, Fcurrent_window_configuration)
3055 (Vwindow_persistent_parameters): Do not use Qstate.
3056 Rewrite doc-strings.
3058 2012-01-19 Kenichi Handa <handa@m17n.org>
3060 * character.c (char_width): New function.
3061 (Fchar_width, c_string_width, lisp_string_width):
3062 Use char_width (Bug#9496).
3064 2012-01-16 Martin Rudalics <rudalics@gmx.at>
3066 * window.c (Vwindow_persistent_parameters): New variable.
3067 (Fset_window_configuration, save_window_save): Handle persistent
3070 2012-01-14 Eli Zaretskii <eliz@gnu.org>
3072 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3073 thrashing the stack of the thread. (Bug#9087)
3075 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3077 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3079 2012-01-11 Eli Zaretskii <eliz@gnu.org>
3081 * xdisp.c (rows_from_pos_range): Handle the case where the
3082 highlight ends on a newline. (Bug#10464)
3083 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3084 he end column for display of highlight that ends on a newline
3087 2012-01-11 Glenn Morris <rgm@gnu.org>
3089 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3090 from load-path also when installation-directory is nil. (Bug#10208)
3092 2012-01-10 Glenn Morris <rgm@gnu.org>
3094 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3096 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3097 Update template values to be closer to their typical values these days.
3099 2012-01-09 Eli Zaretskii <eliz@gnu.org>
3101 * xdisp.c (rows_from_pos_range): Accept additional argument
3102 DISP_STRING, and accept any glyph in a row whose object is that
3103 string as eligible for mouse highlight. Fixes mouse highlight of
3104 display strings from overlays. (Bug#10464)
3106 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
3108 emacs: fix an auto-save permissions race condition (Bug#10400)
3109 * fileio.c (auto_saving_dir_umask): New static var.
3110 (Fmake_directory_internal): Use it.
3111 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3112 creating the directory. The old code temporarily assigns
3113 too-generous permissions to the directory.
3114 (do_auto_save_eh): Clear it.
3115 (Fdo_auto_save): Catch all errors, not just file errors, so
3116 that the var is always cleared.
3118 2012-01-07 Eli Zaretskii <eliz@gnu.org>
3120 * search.c (scan_buffer): Pass character positions to
3121 know_region_cache, not byte positions. (Bug#6540)
3123 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
3125 * w32.c (sys_rename): Report EXDEV when rename of a directory
3126 fails because the target is on another logical disk. (Bug#10284)
3128 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3130 * xterm.c (x_embed_request_focus): New function.
3132 * xterm.h: Add prototype.
3134 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3136 2012-01-05 Glenn Morris <rgm@gnu.org>
3138 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3140 2012-01-01 Eli Zaretskii <eliz@gnu.org>
3142 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3143 Load gnutls_transport_set_lowat only if GnuTLS version is below
3145 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3146 GnuTLS versions below 2.11.1.
3148 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3150 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3151 to the doc string advising against its use for altering the way
3152 windows are scrolled.
3154 2011-12-28 Kenichi Handa <handa@m17n.org>
3156 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3157 coding-system ASCII compatible only when it does not produce BOM
3158 on encoding (Bug#10383).
3160 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3162 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3164 (create_and_show_popup_menu): Always use menu_position_func for
3167 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3169 * callint.c (Fcall_interactively): Don't truncate prompt string.
3171 2011-12-23 Eli Zaretskii <eliz@gnu.org>
3173 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3174 property that ends at ZV, so that the bidi iteration could be
3175 resumed from there (after widening). (Bug#10360)
3177 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3179 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3181 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3183 * nsterm.m (x_free_frame_resources):
3184 Release f->output_data.ns->miniimage.
3185 (ns_index_color): Fix indentation. Do not retain
3186 color_table->colors[i].
3188 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3191 * nsfns.m (x_set_background_color): Assign return value from
3192 ns_index_color to face-background instead of NSColor*.
3193 (ns_implicitly_set_icon_type): Fix indentation.
3194 Change assignment in for loop to comparison.
3196 * emacs.c (ns_pool): New variable.
3197 (main): Assign ns_pool.
3198 (Fkill_emacs): Call ns_release_autorelease_pool.
3200 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3201 autorelease fdesc, release fdAttrs and tdict.
3202 (ns_get_covering_families): Release charset.
3203 (ns_findfonts): Release NSFontDescriptor created with new.
3204 (ns_uni_to_glyphs): Fix indentation.
3205 (setString): Release attrStr before assigning new value.
3207 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3209 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3211 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3212 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3214 2011-12-18 David Reitter <reitter@cmu.edu>
3216 * nsterm.m (ns_term_init): Subscribe for notifications
3217 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3218 to method trackingNotification in EmacsMenu.
3220 * nsmenu.m (trackingMenu): New variable.
3221 (trackingNotification): New method (from Aquamacs).
3222 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3223 from Aquamacs (Bug#7030).
3225 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3227 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3228 (symbol_to_nsstring): Fix indentation.
3229 (ns_symbol_to_pb): New function.
3230 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3231 (Fns_rotate_cut_buffers_internal): Remove.
3232 (Fns_store_selection_internal): Rename from
3233 Fns_store_cut_buffer_internal.
3234 (ns_get_foreign_selection, Fx_own_selection_internal)
3235 (Fx_disown_selection_internal, Fx_selection_exists_p)
3236 (Fns_get_selection_internal, Fns_store_selection_internal):
3237 Use ns_symbol_to_pb and check if return value is nil.
3238 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3239 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
3240 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3241 renamed to Sns_store_selection_internal.
3242 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3243 and remove this function.
3244 (ns_handle_selection_clear): Remove, never used.
3245 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3248 2011-12-17 Ken Brown <kbrown@cornell.edu>
3250 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3251 GID is unknown (Bug#10257).
3253 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3255 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3256 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3257 which caused a build failure on GNU/Linux IA-64. This problem was
3258 introduced by my 2011-10-07 patch.
3260 2011-12-15 Juri Linkov <juri@jurta.org>
3262 * image.c (imagemagick_error): New function. (Bug#10112)
3263 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3264 Use `imagemagick_error' where ImageMagick functions return
3266 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3269 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3271 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3272 fill background (Bug#8992).
3274 2011-12-13 Martin Rudalics <rudalics@gmx.at>
3276 * window.c (Vwindow_combination_resize)
3277 (Vwindow_combination_limit): Use t instead of non-nil in
3279 (Vrecenter_redisplay): Add first sentence of doc-string on
3281 (Frecenter): Fix doc-string typo.
3283 2011-12-11 Kenichi Handa <handa@m17n.org>
3285 * coding.c (Funencodable_char_position): Pay attention to the
3286 buffer text relocation (Bug#9389).
3288 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3290 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3291 gtk_init (Bug#10100).
3293 2011-12-10 Eli Zaretskii <eliz@gnu.org>
3295 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3296 IT->string is nil. (Bug#10263)
3298 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3300 * nsterm.h (x_free_frame_resources): Declare.
3302 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3303 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3305 * nsterm.h (ns_get_defaults_value): Declare.
3307 * nsterm.m (ns_default): Call ns_get_defaults_value.
3309 2011-12-09 Eli Zaretskii <eliz@gnu.org>
3311 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3314 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3316 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3317 that where the value of an _OBJC_* symbol points to is in the .bss
3318 section (Bug#10240).
3320 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3322 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
3323 after the loop to call ccl_driver at least once (Bug#8619).
3325 2011-12-08 Kenichi Handa <handa@m17n.org>
3327 * ftfont.c (get_adstyle_property): Fix previous change
3330 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
3332 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3333 dirs from the default value of EMACSLOADPATH (bug#10208).
3335 2011-12-07 Glenn Morris <rgm@gnu.org>
3337 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3338 installation and source directories as well. (Bug#10208)
3340 2011-12-06 Chong Yidong <cyd@gnu.org>
3342 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3344 2011-12-06 Glenn Morris <rgm@gnu.org>
3346 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3347 as an error, not just -1. (Bug#10217)
3349 2011-12-05 Chong Yidong <cyd@gnu.org>
3351 * keyboard.c (process_special_events): New function.
3352 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3354 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3356 * coding.c (encode_designation_at_bol): Don't use uninitialized
3357 local variable (Bug#9318).
3359 2011-12-05 Kenichi Handa <handa@m17n.org>
3361 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3362 return Qnil (Bug#8046, Bug#10193).
3364 2011-12-05 Kenichi Handa <handa@m17n.org>
3366 * coding.c (encode_designation_at_bol): New args charbuf_end and
3367 dst. Return the number of produced bytes. Callers changed.
3368 (coding_set_source): Return how many bytes coding->source was
3370 (coding_set_destination): Return how many bytes
3371 coding->destination was relocated.
3372 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
3373 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
3375 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3377 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3378 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3381 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3383 The following changes are to fix Bug#9318.
3385 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
3386 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3387 (encode_coding_iso_2022, encode_coding_sjis)
3388 (encode_coding_big5, encode_coding_charset): Use the above macros.
3390 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
3392 * lisp.h (process_quit_flag): Fix external declaration.
3394 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3396 Don't macro-inline non-performance-critical code.
3397 * eval.c (process_quit_flag): New function.
3398 * lisp.h (QUIT): Use it.
3400 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3402 * nsfns.m (get_geometry_from_preferences): New function.
3403 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3405 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3407 * emacs.c (Qkill_emacs): Define.
3408 (syms_of_emacs): Initialize it.
3409 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3410 Qquit_flag to `kill-emacs' instead.
3411 (quit_throw_to_read_char): Add parameter `from_signal'.
3412 All callers changed. Call Fkill_emacs if requested and safe.
3413 * lisp.h (QUIT): Call Fkill_emacs if requested.
3415 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3417 * widget.c (update_wm_hints): Return if wmshell is null.
3418 (widget_update_wm_size_hints): New function.
3420 * widget.h (widget_update_wm_size_hints): Declare.
3422 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3423 widget_update_wm_size_hints (Bug#10104).
3425 2011-12-03 Eli Zaretskii <eliz@gnu.org>
3427 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3428 before a newline, prepare the bidi iterator for consuming the
3429 newline, and keep the current paragraph direction. (Bug#10183)
3430 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
3432 2011-12-02 Juri Linkov <juri@jurta.org>
3434 * search.c (Fword_search_regexp): New Lisp function created from
3435 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3436 (Fword_search_backward, Fword_search_forward)
3437 (Fword_search_backward_lax, Fword_search_forward_lax):
3438 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3439 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3441 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3443 * fileio.c (Finsert_file_contents): Move after-change-function call
3444 to before the "handled:" label, since all "goto handled" appear in
3445 cases where the *-change-functions have already been properly called
3448 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3450 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3451 waiting for input. (Bug#10169)
3453 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3455 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3456 verifies glyph row's hash code--we have just reallocated the
3457 glyphs, so their contents can be complete garbage. (Bug#10164)
3459 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
3461 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3463 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3465 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3466 attributes are tested _before_ calling verify_row_hash, to protect
3467 against GCC re-ordering of the tests. (Bug#10164)
3469 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3471 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3473 * xterm.c (handle_one_xevent): Only set async_visible and friends
3474 if net_wm_state_hidden_seen is non-zero (Bug#10002)
3475 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
3476 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3478 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3480 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3481 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3482 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3483 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3484 All uses changed to use GCPRO1 etc.
3485 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3486 Revert to old implementation (i.e., before 2011-03-11).
3488 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3490 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3491 of scroll runs so as to avoid assigning disabled bogus rows and
3492 unnecessary graphics copy operations.
3494 2011-11-27 Eli Zaretskii <eliz@gnu.org>
3496 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3497 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3498 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3499 (malloc, free, realloc, calloc): Redirect to e_* only when
3502 * lisp.h (GCTYPEBITS): Move before first use.
3503 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3504 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3505 this macro definition.
3507 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3510 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3512 * gtkutil.c (xg_create_frame_widgets):
3513 Call gtk_window_set_has_resize_grip (FALSE) if that function is
3514 present with Gtk+ 2.0.
3516 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3518 * fileio.c (Finsert_file_contents): Undo previous change; see
3519 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3521 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3523 Rename locals to avoid shadowing.
3524 * fileio.c (Finsert_file_contents):
3525 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3526 * process.c (wait_reading_process_output):
3527 Rename inner 'proc' to 'p' to avoid shadowing.
3528 Indent for consistency with usual Emacs style.
3530 2011-11-25 Eli Zaretskii <eliz@gnu.org>
3532 * xdisp.c (redisplay_window): If cursor row is not fully visible
3533 after recentering, and scroll-conservatively is set to a large
3534 number, scroll window by a few more lines to make the cursor fully
3535 visible and out of scroll-margin. (Bug#10105)
3536 (start_display): Don't move to the next line if the display should
3537 start at a newline that is part of a display vector or an overlay
3540 2011-11-24 Juri Linkov <juri@jurta.org>
3542 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3543 after the `MagickPingImage' call. (Bug#10112)
3545 2011-11-23 Chong Yidong <cyd@gnu.org>
3547 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3549 2011-11-23 Martin Rudalics <rudalics@gmx.at>
3551 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3552 making another buffer current. (Bug#10114)
3554 2011-11-23 Glenn Morris <rgm@gnu.org>
3556 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3558 2011-11-23 Chong Yidong <cyd@gnu.org>
3560 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3561 using it (Bug#5984).
3563 2011-11-22 Eli Zaretskii <eliz@gnu.org>
3565 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3566 and header-lines, as they don't have one computed for them.
3569 * .gdbinit (prow): Make displayed values more self-explaining.
3570 Add row's hash code.
3572 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3574 * process.c (wait_reading_process_output): Fix asynchrounous
3575 GnuTLS socket handling on some versions of the GnuTLS library.
3576 (wait_reading_process_output): Add comment and URL.
3578 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3580 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3582 2011-11-21 Chong Yidong <cyd@gnu.org>
3584 * window.c (Fnext_window, Fprevious_window): Doc fix.
3586 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3588 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3590 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3592 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3594 2011-11-20 Martin Rudalics <rudalics@gmx.at>
3596 * window.c (Fset_window_combination_limit): Rename argument
3598 (Vwindow_combination_limit): Remove "status" from doc-string.
3600 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3602 * m/ibms390.h: Remove.
3603 * m/ibms390x.h: Don't include "ibms390.h".
3605 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3607 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3608 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3610 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3612 * casetab.c (Fset_case_table):
3613 * charset.c (Fcharset_after): Fix typos.
3615 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
3617 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3618 Otherwise, valgrind does not work on some platforms.
3619 Problem reported by Andreas Schwab in
3620 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3621 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3622 is set, removing the need for VIRT_ADDRESS_VARIES.
3623 (PURE_P): Use a more-efficient implementation that needs just one
3624 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3625 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3626 to 4 (xorl, subq, cmpq, setbe).
3627 * alloc.c (pure): Always extern now, since that's the
3628 VIRT_ADDR_VARIES behavior.
3629 (PURE_POINTER_P): Use a single comparison, not two, for
3630 consistency with the new puresize.h.
3631 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3632 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3633 Remove VIRT_ADDR_VARIES no longer needed.
3635 2011-11-19 Eli Zaretskii <eliz@gnu.org>
3637 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3638 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3639 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3640 behave as if the cursor position were at the window margin.
3642 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3643 and the cursor position is out of bounds, behave as if the cursor
3644 position were at the window margin. (Bug#10075)
3646 2011-11-18 Chong Yidong <cyd@gnu.org>
3648 * window.c (Fwindow_combination_limit): Make first argument
3649 non-optional, since it is meaningless for live windows like the
3652 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3654 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3656 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3658 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3659 (graft_intervals_into_buffer): Simplify.
3661 2011-11-18 Eli Zaretskii <eliz@gnu.org>
3663 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3664 hash values of the two rows.
3665 (copy_row_except_pointers): Preserve the used[] arrays and the
3666 hash values of the two rows. (Bug#10035)
3667 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
3669 * xdisp.c (row_hash): New function, body extracted from
3670 compute_line_metrics.
3671 (compute_line_metrics): Call row_hash, instead of computing the
3674 * dispnew.c (verify_row_hash): Call row_hash for computing the
3675 hash code of a row, instead of duplicating code from xdisp.c.
3677 * dispextern.h (row_hash): Add prototype.
3679 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3681 * frame.c (delete_frame): Don't delete the terminal when the last
3682 X frame is closed if emacs is built with GTK toolkit.
3684 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
3686 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3688 2011-11-17 Martin Rudalics <rudalics@gmx.at>
3690 * window.c (Vwindow_splits): Rename to
3691 Vwindow_combination_resize. Suggested by Juri Linkov.
3692 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3695 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
3697 * nsfns.m (Fns_font_name):
3698 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
3700 2011-11-16 Martin Rudalics <rudalics@gmx.at>
3702 * window.h (window): Rename slot "nest" to "combination_limit".
3703 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3704 (Fset_window_nest): Rename to Fset_window_combination_limit.
3705 (Vwindow_nest): Rename to Vwindow_combination_limit.
3706 (recombine_windows, make_parent_window, make_window)
3707 (Fsplit_window_internal, saved_window)
3708 (Fset_window_configuration, save_window_save): Rename all
3709 occurrences of window_nest to window_combination_limit.
3711 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
3713 * image.c (imagemagick_load_image): Fix typo.
3715 2011-11-14 Eli Zaretskii <eliz@gnu.org>
3717 * xdisp.c (display_line): Move the call to
3718 highlight_trailing_whitespace before the call to
3719 compute_line_metrics, since the latter needs to see the final
3720 faces of all the glyphs to compute ROW's hash value.
3721 Fixes assertion violations in row_equal_p. (Bug#10035)
3723 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
3725 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3726 just return (bug#10044).
3728 2011-11-12 Eli Zaretskii <eliz@gnu.org>
3730 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3731 with user-defined heap size. Bump the default size of the temacs
3732 heap to 27MB, to avoid memory warning when running temacs.
3733 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3735 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3736 current_matrix and desired_matrix. (Bug#9990)
3737 (verify_row_hash) [XASSERTS]: New function.
3738 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3739 that the hash value of glyph rows is correct.
3741 2011-11-12 Martin Rudalics <rudalics@gmx.at>
3743 * window.h (window): Remove splits slot.
3744 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3745 (Fdelete_other_windows_internal, make_parent_window)
3746 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3747 (Fset_window_configuration, save_window_save): Don't deal with
3748 split status of windows.
3749 (saved_window): Remove splits slot.
3750 (Vwindow_splits): Rewrite doc-string.
3752 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3754 * xfns.c (unwind_create_frame):
3755 * nsfns.m (unwind_create_frame):
3756 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3757 Vframe_list (Bug#9999).
3759 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3761 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
3763 2011-11-11 Kenichi Handa <handa@m17n.org>
3765 * callproc.c (Fcall_process): Set the member dst_multibyte of
3768 2011-11-11 Johan Bockgård <bojohan@gnu.org>
3770 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3771 avoid a crash (bug#9496).
3773 2011-11-09 Chong Yidong <cyd@gnu.org>
3775 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3776 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3778 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3780 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3782 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3784 Avoid some portability problems by eschewing 'extern inline' functions.
3785 The trivial performance wins aren't worth the portability hassles; see
3786 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3788 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3789 (window_box_width, window_box_left, window_box_left_offset)
3790 (window_box_right, window_box_right_offset): Undo previous change,
3791 by removing the "extern"s.
3792 * intervals.c (adjust_intervals_for_insertion)
3793 (adjust_intervals_for_deletion): Undo previous change,
3794 making these static again.
3795 (offset_intervals, temp_set_point_both, temp_set_point)
3796 (copy_intervals_to_string): No longer inline.
3797 * xdisp.c (window_text_bottom_y, window_box_width)
3798 (window_box_height, window_box_left_offset)
3799 (window_box_right_offset, window_box_left, window_box_right)
3800 (window_box): No longer inline.
3802 2011-11-08 Chong Yidong <cyd@gnu.org>
3804 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
3805 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3806 Signal an error if not a live window.
3807 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3808 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3810 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
3812 * lisp.h (syms_of_abbrev): Remove declaration.
3813 Reported by CHENG Gao <chenggao@royau.me>.
3815 2011-11-07 Eli Zaretskii <eliz@gnu.org>
3817 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3818 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3819 of temacs in GUI mode.
3821 2011-11-07 Martin Rudalics <rudalics@gmx.at>
3823 * window.h: Declare delete_all_child_windows instead of
3824 delete_all_subwindows.
3825 * window.c (Fwindow_nest, Fset_window_nest)
3826 (Fset_window_new_total, Fset_window_new_normal)
3827 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3828 (delete_all_subwindows): Rename to delete_all_child_windows.
3829 (Fdelete_other_windows_internal, Fset_window_configuration):
3830 Call delete_all_child_windows instead of delete_all_subwindows.
3831 * frame.c (delete_frame): Call delete_all_child_windows instead
3832 of delete_all_subwindows.
3834 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3836 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3837 This is also needed for porting to any host where GC_MARK_STACK is
3838 not GC_MAKE_GCPROS_NOOPS.
3839 (which_symbols): Use it.
3841 2011-11-07 Kenichi Handa <handa@m17n.org>
3843 * coding.c (coding_set_destination): Check coding->src_pos only
3844 when coding->src_object is a buffer (bug#9910).
3846 * process.c (send_process): Set the member src_multibyte of coding
3847 to 0 (bug#9911) when sending a unibyte text.
3849 * callproc.c (Fcall_process): Set the member src_multibyte of
3850 process_coding to 0 (bug#9912).
3852 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3854 * xmenu.c (cleanup_widget_value_tree): New function.
3855 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3856 calling free_menubar_widget_value_tree directly (Bug#9830).
3858 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3860 Fix some portability problems with 'inline'.
3861 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3862 (window_box_width, window_box_left, window_box_left_offset)
3863 (window_box_right, window_box_right_offset): Declare extern.
3864 Otherwise, these inline functions do not conform to C99 and
3865 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3866 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3867 * intervals.c (adjust_intervals_for_insertion)
3868 (adjust_intervals_for_deletion): Now extern, because otherwise the
3869 extern inline functions 'offset_intervals' couldn't refer to it.
3870 (static_offset_intervals): Remove.
3871 (offset_intervals): Rewrite using the old contents of
3872 static_offset_intervals. The old version didn't conform to C99
3873 because an extern inline function contained a reference to an
3874 identifier with static linkage.
3876 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3878 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3881 2011-11-06 Eli Zaretskii <eliz@gnu.org>
3883 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3884 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3885 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3886 return Qleft_to_right.
3888 2011-11-06 Chong Yidong <cyd@gnu.org>
3890 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3891 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3892 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3893 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3894 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3895 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3896 (Fwindow_vscroll): Doc fix.
3897 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3898 argument, since it makes no sense to pass a live window and for
3899 consistency with window-child.
3901 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3903 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3906 2011-11-05 Jason Rumney <jasonr@gnu.org>
3908 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3909 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3911 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3912 bitwise arithmetic preventing use of unicode-sip and non-truetype
3915 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3917 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3920 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3921 initialization code to keep similarity to xfns.c after changes
3924 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3926 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3927 (unwind_create_frame): New function (Bug#9943).
3928 (Fx_create_frame): Restructure code to be more similar to the one in
3929 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3930 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3931 Move terminal->reference_count++ just before making the frame official
3934 * nsterm.m (x_free_frame_resources): New function.
3935 (x_destroy_window): Move code to x_free_frame_resources.
3937 * xfns.c (unwind_create_frame): Fix comment.
3938 (Fx_create_frame, x_create_tip_frame):
3939 Move terminal->reference_count++ just before making the frame
3940 official. Move initialization of image_cache_refcount and
3941 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3943 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3945 Support MSVC build with newer versions of Visual Studio.
3946 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3947 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3950 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3951 which are not supported by MSVC.
3952 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3953 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3955 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3957 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3959 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3961 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
3963 Support MSVC build with newer versions of Visual Studio.
3964 * w32.c: Don't include w32api.h for MSVC.
3965 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3967 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3968 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3969 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3970 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3972 (alloca) [_MSC_VER]: Define to _alloca.
3974 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3976 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3978 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3980 * xdisp.c (note_mouse_highlight): If either of
3981 previous/next-single-property-change returns nil, treat that as
3982 the beginning or the end of the buffer. (Bug#9955)
3984 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3986 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
3987 label is not null (Bug#9951).
3988 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3991 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3993 * window.c (Fwindow_body_size): Mention in the doc string that the
3994 return value is in frame's canonical units. (Bug#9949)
3996 2011-11-03 Eli Zaretskii <eliz@gnu.org>
3998 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4000 * w32fns.c (unwind_create_frame): If needed, free the glyph
4001 matrices of the partially constructed frame. (Bug#9943)
4002 * xfns.c (unwind_create_frame): Likewise.
4004 2011-11-01 Eli Zaretskii <eliz@gnu.org>
4006 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4007 Don't stop backward scan on the continuation glyph, even though
4008 its CHARPOS is positive.
4009 (mouse_face_from_buffer_pos, note_mouse_highlight):
4010 Rename cover_string to disp_string.
4012 2011-11-01 Martin Rudalics <rudalics@gmx.at>
4014 * window.c (temp_output_buffer_show): Don't use
4015 Vtemp_buffer_show_specifiers.
4016 (Vtemp_buffer_show_specifiers): Remove unused variable.
4018 2011-10-30 Eli Zaretskii <eliz@gnu.org>
4020 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4021 past the beginning of the current glyph matrix.
4023 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
4025 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4026 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4027 HAVE_GTK3 (Bug#9869).
4029 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4030 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4032 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4034 * xterm.c: Declare x_handle_net_wm_state to return int.
4035 (handle_one_xevent): Check if we are iconified but don't have
4036 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4037 (get_current_wm_state): Return non-zero if not hidden,
4038 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4039 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4040 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4041 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4043 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4045 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4046 so that this new function doesn't get optimized away by a
4047 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4049 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4051 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4053 2011-10-29 Eli Zaretskii <eliz@gnu.org>
4055 Fix the `xbytecode' command.
4056 * .gdbinit (xprintbytestr): New command.
4057 (xwhichsymbols): Rename from `which'; all callers changed.
4058 (xbytecode): Print the byte-code string as well.
4060 2011-10-29 Kim Storm <storm@cua.dk>
4062 * alloc.c (which_symbols): New function.
4064 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4066 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4069 2011-10-29 Glenn Morris <rgm@gnu.org>
4071 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4072 Not clear what it was for, and it causes various bugs. (Bug#9839)
4074 2011-10-28 Eli Zaretskii <eliz@gnu.org>
4076 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4077 possible random value that matches one of those tested as
4078 condition to clear the mouse face.
4080 2011-10-28 Chong Yidong <cyd@gnu.org>
4082 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4084 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4086 * window.c (make_window): Initialize phys_cursor_on_p.
4088 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4090 * lisp.h (struct Lisp_Symbol): Update comments.
4092 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
4094 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4096 2011-10-28 Eli Zaretskii <eliz@gnu.org>
4098 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4099 <oslsachem@gmail.com> for helping to debug this.
4101 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4102 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4103 (g_b_init_get_glyph_outline_w): New static variables.
4104 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4105 (GetGlyphOutlineW_Proc): New typedefs.
4106 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
4107 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4109 (w32font_open_internal, compute_metrics):
4110 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
4111 instead of calling the "wide" APIs directly.
4113 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4115 * w32.h (syms_of_w32font): Add prototype.
4117 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
4119 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4120 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4121 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4122 (Fmove_to_window_line): Doc fix.
4124 2011-10-27 Chong Yidong <cyd@gnu.org>
4126 * process.c (make_process): Set gnutls_state to NULL.
4128 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4129 non-NULL, regardless of GNUTLS_INITSTAGE.
4130 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4131 an error. Set process slots as soon as we allocate them.
4133 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4135 2011-10-27 Chong Yidong <cyd@gnu.org>
4137 * gnutls.c (emacs_gnutls_deinit): New function.
4138 Deallocate credentials structures as well as calling gnutls_deinit.
4139 (Fgnutls_deinit, Fgnutls_boot): Use it.
4141 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4142 (deactivate_process): Call emacs_gnutls_deinit.
4144 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
4146 * image.c (x_create_x_image_and_pixmap):
4147 * w32.c (sys_rename, w32_delayed_load):
4148 * w32font.c (fill_in_logfont):
4149 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4151 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
4153 * w32fns.c (w32_default_color_map): New function,
4154 extracted from Fw32_default_color_map.
4155 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
4157 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4159 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4161 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4163 * keyboard.c (test_undefined): New function (bug#9751).
4164 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4166 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4168 * sysdep.c (init_sys_modes): Fix the check for the controlling
4169 terminal (Bug#6649).
4171 2011-10-20 Eli Zaretskii <eliz@gnu.org>
4173 * dispextern.h (struct bidi_it): New member next_en_type.
4175 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4176 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4177 current character, check also for next_en_type being WEAK_EN.
4178 (bidi_resolve_weak): Don't enter the expensive loop if the current
4179 position is before next_en_pos. Record the bidi type of the first
4180 non-ET, non-BN character we find, in addition to its position.
4181 (bidi_level_of_next_char): Invalidate next_en_type when
4182 next_en_pos is over-stepped.
4184 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4186 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4187 * editfns.c: Rewrite current-time-zone so that it invokes
4188 the equivalent of (format-time-string "%Z") to get the time zone name.
4189 This fixes a bug when the time zone name contains characters that
4190 need converting from the system time locale to Emacs internal format.
4191 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4192 that patch fixed format-time-string to do the conversion, but
4193 I forgot to fix current-time-zone.
4194 (format_time_string): New function, containing most of
4195 what Fformat_time_string used to contain.
4196 (Fformat_time_string): Rewrite in terms of format_time_string.
4197 This doesn't change this function's behavior.
4198 (current-time-zone): Rewrite to use format_time_string.
4199 This fixes the bug reported by Michael Schierl in
4200 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4201 Jason Rumney's 2007-06-07 change worked around this bug, but
4203 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4205 2011-10-19 Eli Zaretskii <eliz@gnu.org>
4207 * xdisp.c (start_display): If the character at POS is displayed
4208 via a display vector, reset IT->current.dpvec_index to zero.
4209 (try_window_reusing_current_matrix): If a line ends in a display
4210 vector or the next line starts in a display vector, continue
4211 redrawing the window even though the character position of
4212 start_row was reached.
4215 2011-10-18 Chong Yidong <cyd@gnu.org>
4217 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4218 with nobreak-char-display too.
4220 2011-10-18 Eli Zaretskii <eliz@gnu.org>
4222 Fix part 3 of bug#9771.
4223 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4224 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4225 non-neutral characters if the current character is a paragraph
4226 separator (a.k.a. Newline). This avoids running the same
4227 expensive loop twice, once when we consume the preceding newline
4228 and the other time when the line actually needs to be displayed.
4229 Avoid the loop when we see neutrals on the base embedding level
4230 following a character whose directionality is the same as the
4231 paragraph's. This avoids running the expensive loop when a line
4232 ends in a long sequence of neutrals, like control characters.
4233 Add assertion against STRONG_AL type. Slightly rearrange code
4234 that determines the type of a neutral given the first non-neutral
4236 (bidi_level_of_next_char): Set next_en_pos to zero when
4237 invalidating its info.
4239 2011-10-17 Eli Zaretskii <eliz@gnu.org>
4241 * xdisp.c (push_display_prop): Determine whether to record string
4242 or buffer position by IT->string, not by IT->method. Allow
4243 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
4244 (move_it_vertically_backward): Don't look for character position
4245 immediately after the newline when in a continuation line.
4248 2011-10-15 Martin Rudalics <rudalics@gmx.at>
4250 * window.c (coordinates_in_window): Rewrite and delabelize
4251 vertical border check. (Bug#5357) (Bug#9618)
4253 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4255 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4256 errors in XSetWindowBorder (bug#9310).
4258 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4260 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4261 avoid crash when xmalloc overrun checking is enabled.
4263 2011-10-13 Eli Zaretskii <eliz@gnu.org>
4265 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4266 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4267 cursor motion with <left> and <right> arrow keys.
4269 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4270 some callers set that themselves.
4272 2011-10-12 Eli Zaretskii <eliz@gnu.org>
4274 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4275 display string and the previous row comes from the same string and
4276 is empty. (Bug#9739) (Bug#9738)
4278 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4280 * doc.c (get_doc_string): Encode file name (bug#9735).
4282 2011-10-12 Eli Zaretskii <eliz@gnu.org>
4284 * bidi.c (bidi_level_of_next_char):
4285 * xdisp.c (get_visually_first_element): Remove old incorrect
4286 comments regarding the Unicode Line Separator character.
4288 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4290 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4292 * alloc.c (Fgc_status): Do not access beyond zombies array
4293 boundary if nzombies > MAX_ZOMBIES.
4294 * alloc.c (dump_zombies): Add missing format specifier.
4296 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4298 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4299 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4301 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4302 Some packages use them to denote characters with modifiers.
4304 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4306 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4307 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4308 matching a pp-number. Rename parameter var to var1.
4310 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4312 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4314 2011-10-08 Glenn Morris <rgm@gnu.org>
4316 * callint.c (Fcall_interactively): Give a more explicit error for the
4317 'c' case with a non-character input. (Bug#8479)
4319 2011-10-08 Eli Zaretskii <eliz@gnu.org>
4321 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4323 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4324 lines that are hscrolled on the left.
4326 * dispnew.c (buffer_posn_from_coords): Account for a possible
4327 presence of header-line. (Bug#4426)
4329 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4331 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4332 Don't advertise functionality which we discourage or doesn't work.
4334 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4336 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4337 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4338 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4339 this makes Emacs dump core during garbage collection on rare
4340 occasions. sizeof is obviously inferior to offsetof here, so
4341 stick with offsetof.
4342 (GC_POINTER_ALIGNMENT): New macro.
4343 (mark_memory): Omit 3rd (offset) arg; caller changed.
4344 Don't assume EMACS_INT alignment is the same as pointer alignment.
4346 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4348 * keyboard.c (read_key_sequence_remapped): New var.
4349 (read_key_sequence): Compute remapping in the right buffer.
4350 (command_loop_1): Use read_key_sequence's remapping directly.
4352 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4354 * dired.c (file_name_completion): Don't expand file name.
4355 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4356 before checking file name handler.
4358 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4359 they've been requested explicitly (bug#9591).
4361 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
4363 * keymap.c (Fsingle_key_description): Use make_specified_string
4364 instead of build_string to build string from push_key_description.
4367 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4369 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4370 This fixes a Y2038 bug on 64-bit hosts.
4371 * buffer.c (reset_buffer):
4372 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4373 (Fclear_buffer_auto_save_failure):
4374 Use 0, not -1, to represent an unset failure time, since time_t
4375 might not be signed.
4377 Remove dependency on glibc malloc internals.
4378 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4379 Move back here from lisp.h, but with their new implementations.
4380 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4381 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4382 * charset.c (charset_table_init): New static var.
4383 (syms_of_charset): Use it instead of xmalloc. This removes a
4384 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4385 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4386 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4387 Move back to alloc.c.
4388 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4389 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4391 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4393 * nsterm.m (windowDidResize): Call x_set_window_size only when
4394 ns_in_resize is true. Otherwise set pixelwidth/height and
4395 call change_frame_size (Bug#9628).
4397 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4399 Port --enable-checking=all to Fedora 14 x86-64.
4400 * charset.c (syms_of_charset): Also account for glibc malloc's
4401 internal overhead when calculating the initial malloc maximum.
4403 Port --enable-checking=all to Fedora 14 x86.
4404 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4406 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4407 (overrun_check_realloc, overrun_check_free):
4408 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4409 That way, xmalloc returns a properly-aligned pointer even if
4410 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4411 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4412 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4413 into account when calculating the initial malloc maximum.
4414 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4415 Move here from alloc.c, so that charset.c can use it too.
4416 Properly align; the old code wasn't right for common 32-bit hosts
4417 when configured with --enable-checking=all.
4418 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4419 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4421 2011-09-29 Eli Zaretskii <eliz@gnu.org>
4423 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
4426 2011-09-28 Eli Zaretskii <eliz@gnu.org>
4428 * xdisp.c (compute_display_string_end): If there's no display
4429 string at CHARPOS, return -1.
4431 * bidi.c (bidi_fetch_char): When compute_display_string_end
4432 returns a negative value, treat the character as a normal
4433 character not covered by a display string. (Bug#9624)
4435 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
4437 * lread.c (Fread_from_string): Fix typo in docstring.
4439 2011-09-27 Eli Zaretskii <eliz@gnu.org>
4441 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4442 newline, reseat the iterator instead of bidi-iterating there one
4443 character at a time. (Bug#9610)
4444 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4445 TO_CHARPOS if the bidi iterator is at base embedding level.
4447 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4449 * lread.c (readevalloop): Use correct code for NBSP.
4450 (read1): Likewise. (Bug#9608)
4452 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
4454 * dbusbind.c (Fdbus_register_signal): When service is not
4455 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4457 2011-09-25 Glenn Morris <rgm@gnu.org>
4459 * buffer.c (truncate-lines): Doc fix.
4461 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
4463 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4464 (Fset_window_next_buffers): Doc fix.
4466 2011-09-24 Glenn Morris <rgm@gnu.org>
4468 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4470 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4472 Fix minor problems found by static checking.
4473 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
4474 * indent.c (Fvertical_motion): Fix == vs = typo.
4476 2011-09-24 Eli Zaretskii <eliz@gnu.org>
4478 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4479 Default value is now t. Doc fix.
4481 * indent.c (Fvertical_motion): Compute and apply the overshoot
4482 logic when moving up, not only when moving down. Fix the
4483 confusing name and values of the it_overshoot_expected variable;
4484 logic changes accordingly. (Bug#9254) (Bug#9549)
4486 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4487 CHARPOS is covered by a display string which includes newlines.
4488 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4489 is covered by a display string with embedded newlines.
4491 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
4493 * dbusbind.c (Fdbus_register_signal): Add match rule to
4494 Vdbus_registered_objects_table. (Bug#9581)
4495 (Fdbus_register_method, Vdbus_registered_objects_table):
4498 2011-09-24 Jim Meyering <meyering@redhat.com>
4500 do not ignore write error for any output size
4501 The previous change was incomplete.
4502 While it makes emacs --batch detect the vast majority of stdout
4503 write failures, errors were still ignored whenever the output size is
4504 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4505 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4506 && echo FAIL: ignored write error
4507 FAIL: ignored write error
4508 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4509 && echo FAIL: ignored write error
4510 FAIL: ignored write error
4511 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4513 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4515 * emacs.c (Fkill_emacs): In noninteractive mode exit
4516 non-successfully if a write error occurred on stdout. (Bug#9574)
4518 2011-09-21 Eli Zaretskii <eliz@gnu.org>
4520 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4523 * dispextern.h (struct it): Update the comment documenting what
4526 2011-09-20 Eli Zaretskii <eliz@gnu.org>
4528 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4529 a display string, extend search for cursor position to end of row.
4530 (find_row_edges): If the row ends in a newline from a display
4531 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4532 Handle the case of a display string with multiple newlines.
4533 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4534 non-empty line. Fixes confusing cursor motion with arrow keys at
4535 the beginning of a line that starts with whitespace.
4537 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4539 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4542 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
4544 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4547 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4549 * xdisp.c (display_line): Record maximum and minimum buffer
4550 positions even if no glyphs were produced (e.g., by a zero-width
4551 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4552 buffer positions that will be removed from the glyph row because
4554 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4555 column is beyond frame width: don't subtract 1 "pixel" when
4556 computing width of the stretch.
4557 (reseat_at_next_visible_line_start): Undo the change made on
4558 2011-09-17 that saved paragraph information and restored it after
4559 the call to `reseat'. (Bug#9545)
4561 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4563 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4564 and turn window cursor on if cleared (Bug#9415).
4566 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
4568 * search.c (boyer_moore): Take unibyte characters from pattern
4569 literally. (Bug#9458)
4571 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4573 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4575 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4577 Fix minor problem found by static checking.
4578 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4579 initialized, to pacify gcc -Wuninitialized.
4581 * fileio.c: Report proper errno when syscall falls.
4582 (Finsert_file_contents): Save and restore errno,
4583 so that report_file_error outputs the correct diagnostic.
4584 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4586 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4588 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4590 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4592 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4593 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4595 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4597 * xdisp.c (reseat_at_next_visible_line_start): Keep information
4598 about the current paragraph and restore it after the call to reseat.
4600 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4601 (bidi_find_paragraph_start): Search back for paragraph beginning
4602 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4603 (bidi_move_to_visually_next): Only trigger paragraph-related
4604 computations when the last character is a newline or at EOB, not
4605 just any NEUTRAL_B. (Bug#9470)
4607 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4608 truncated lines if point is covered by a display string. (Bug#9524)
4610 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4612 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4613 (cons_to_x_long): New function.
4614 (lisp_data_to_selection_data): Use it. Correct the test for
4615 short-versus-long data; it was negated. Break out of vector
4616 loop, for efficiency, when a long datum is discovered.
4618 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4620 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4622 2011-09-16 Eli Zaretskii <eliz@gnu.org>
4624 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4625 GCC PR/17406) by declaring this function with external scope.
4627 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4629 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4630 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4632 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4634 * editfns.c (Fformat): Correctly handle text properties on "%%".
4636 2011-09-15 Eli Zaretskii <eliz@gnu.org>
4638 * xterm.c (x_draw_composite_glyph_string_foreground):
4639 * w32term.c (x_draw_composite_glyph_string_foreground):
4640 * term.c (encode_terminal_code):
4641 * composite.c (composition_update_it, get_composition_id):
4642 * xdisp.c (get_next_display_element)
4643 (fill_composite_glyph_string): Add comments about special meaning
4644 of TAB characters in a composition.
4646 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4648 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4649 This occurs when processing a multibyte format.
4650 Problem reported by Wolfgang Jenker.
4652 2011-09-15 Johan Bockgård <bojohan@gnu.org>
4654 * xdisp.c (try_cursor_movement): Only check for exact match if
4655 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4657 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4659 Remove unused external symbols.
4660 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4661 * xdisp.c (calc_pixel_width_or_height): Now static.
4662 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4663 * indent.c (check_display_width):
4664 * w32term.c: Fix comment to match code.
4665 * xterm.c, xterm.h (x_catching_errors): Remove.
4667 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4669 * xselect.c: Use signed conversions more consistently (Bug#9498).
4670 (selection_data_to_lisp_data): Assume incoming selection data are
4671 signed integers, not unsigned. This is to be consistent with
4672 outgoing selection data, which was modified to use signed integers
4673 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4674 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4675 expects long, not unsigned long.
4677 2011-09-14 Eli Zaretskii <eliz@gnu.org>
4679 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4680 computation of loop end. Reported by Johan Bockgård
4683 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
4685 * frame.c (Fother_visible_frames_p): Function deleted.
4687 2011-09-12 Eli Zaretskii <eliz@gnu.org>
4689 * indent.c (compute_motion): Process display vector front to back
4690 rather than the other way around. (Bug#2496)
4692 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4694 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4696 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
4698 * minibuf.c (Fread_from_minibuffer): Doc fix.
4700 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4702 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4703 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4705 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4707 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4708 value for non-existent files.
4710 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4712 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4713 set its "size" to -1. This will set the modtime_size field of
4714 the corresponding buffer to -1, which is what
4715 verify-visited-file-modtime expects for files that do not exist.
4718 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4720 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4722 * lisp.h: ... from here. push_key_description is no longer
4723 defined in keyboard.c, so its declaration should not be in
4724 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4725 logically belongs with push_key_description.
4727 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4729 * buffer.h: Include <sys/types.h> instead of <time.h>.
4730 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4731 Problem reported by Herbert J. Skuhra.
4733 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4735 * xml.c (parse_region): Make the parsing work for
4736 non-comment-starting XML files again (bug#9144).
4738 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4740 * image.c (gif_load): Fix calculation of bottom and right corner.
4743 2011-09-10 Eli Zaretskii <eliz@gnu.org>
4745 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4746 redisplay in small windows.
4748 2011-09-09 Eli Zaretskii <eliz@gnu.org>
4750 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4752 2011-09-08 Martin Rudalics <rudalics@gmx.at>
4754 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4755 Operate on live windows only.
4757 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
4759 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4761 2011-09-07 Eli Zaretskii <eliz@gnu.org>
4763 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4764 only under bidi iteration.
4766 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4768 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4770 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4772 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4773 Without this fix, the command to link temacs failed due to an
4774 undefined symbol __builtin_isnan. This is because
4775 /usr/include/iso/math_c99.h #defines isnan(x) to
4776 __builtin_isnan(x), but the bundled gcc, which identifies itself
4777 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4779 * floatfns.c (isnan): #undef, and then #define to a clone of
4781 (Fisnan): Always define, since it's always available now.
4782 (syms_of_floatfns): Always define isnan at the Lisp level.
4784 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4786 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4788 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4790 * fileio.c: Fix bugs with large file offsets (Bug#9428).
4791 The previous code assumed that file offsets (off_t values) fit in
4792 EMACS_INT variables, which is not true on typical 32-bit hosts.
4793 The code messed up by falsely reporting buffer overflow in cases
4794 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4795 when "big" contains more than 2**29 bytes, even though this
4796 inserts just one byte and does not overflow the buffer.
4797 (Finsert_file_contents): Store file offsets as off_t
4798 values, not as EMACS_INT values. Check for overflow when
4799 converting between EMACS_INT and off_t. When checking for
4800 buffer overflow or for overlap, take the offsets into account.
4801 Don't use EMACS_INT for small values where int suffices.
4802 When checking for overlap, fix a typo: ZV was used where
4803 ZV_BYTE was intended.
4804 (Fwrite_region): Don't assume off_t fits into 'long'.
4805 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4807 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
4809 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4811 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4813 sprintf-related integer and memory overflow issues (Bug#9412).
4815 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
4816 (esprintf, exprintf, evxprintf): New functions.
4817 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
4818 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
4819 (modify_event_symbol): Do not assume that the length of
4820 name_alist_or_stem is safe to alloca and fits in int.
4821 (Fexecute_extended_command): Likewise for function name and binding.
4822 (Frecursion_depth): Wrap around reliably on integer overflow.
4823 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4824 since some callers pass EMACS_INT values.
4825 (Fsingle_key_description): Don't crash if symbol name contains more
4826 than MAX_ALLOCA bytes.
4827 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4828 (get_minibuffer): Arg is now EMACS_INT, not int.
4829 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
4830 (esprintf, exprintf, evxprintf): New decls.
4831 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4833 * dbusbind.c (signature_cat): New function.
4834 (xd_signature, Fdbus_register_signal):
4835 Do not overrun buffer; instead, report string overflow.
4837 * dispnew.c (add_window_display_history): Don't overrun buffer.
4838 Truncate instead; this is OK since it's just a log.
4840 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4841 even if the time zone offset is outlandishly large.
4842 Don't mishandle offset == INT_MIN.
4844 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4845 when creating daemon; the previous buffer-overflow check was incorrect.
4847 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4848 which has the guts of the old verror function.
4850 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4851 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4853 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4854 (font_unparse_xlfd): Don't blindly alloca long strings.
4855 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
4856 fits in int, when using sprintf. Use single snprintf to count
4857 length of string rather than counting it via multiple sprintfs;
4858 that's simpler and more reliable.
4859 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4860 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4861 sprintf, in case result does not fit in int.
4863 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4864 (fontset_from_font): Print it.
4866 * frame.c (tty_frame_count): Now printmax_t, not int.
4867 (make_terminal_frame, set_term_frame_name): Print it.
4868 (x_report_frame_params): In X, window IDs are unsigned long,
4869 not signed long, so print them as unsigned.
4870 (validate_x_resource_name): Check for implausibly long names,
4871 and don't assume name length fits in 'int'.
4872 (x_get_resource_string): Don't blindly alloca invocation name;
4873 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4876 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4877 (xg_check_special_colors, xg_set_geometry):
4878 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4880 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4881 Use esprintf, not sprintf, in case result does not fit in int.
4883 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4884 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4885 it as a large positive number.
4886 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4887 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4889 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4890 in case result does not fit in int.
4892 * print.c (float_to_string): Detect width overflow more reliably.
4893 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4894 buffer overrun. Don't assume list length fits in 'int'. Treat
4895 print length of 0 as 0, not as infinity; to be consistent with other
4896 uses of print length in this function. Don't overflow print length
4897 index. Don't assume hash table size fits in 'long', or that
4898 vectorlike size fits in 'unsigned long'.
4900 * process.c (make_process): Use printmax_t, not int, to format
4901 process-name gensyms.
4903 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4905 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4906 to avoid potential buffer overrun.
4908 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4909 if X resource line is longer than 512 bytes.
4911 * xfns.c (x_window): Make sprintf buffer a bit bigger
4912 to avoid potential buffer overrun.
4914 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4916 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4918 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4920 Integer overflow fixes for scrolling, etc.
4921 Without these, Emacs silently mishandles large integers sometimes.
4922 For example, "C-u 4294967297 M-x recenter" was treated as if
4923 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4925 * xdisp.c (try_window_id): Check Emacs fixnum range before
4926 converting to 'int'.
4928 * window.c (window_scroll_line_based, Frecenter):
4929 Check that an Emacs fixnum is in range before assigning it to 'int'.
4930 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4931 values converted from Emacs fixnums.
4932 (Frecenter): Don't wrap around a line count if it is out of 'int'
4933 range; instead, treat it as an extreme value.
4934 (Fset_window_configuration, compare_window_configurations):
4935 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4937 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4938 that can exceed INT_MAX. Check that EMACS_INT value is in range
4939 before assigning it to the (possibly-narrower) index.
4940 (match_limit): Don't assume that a fixnum can fit in 'int'.
4942 * print.c (print_object): Use ptrdiff_t, not int, for index that can
4945 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
4946 (Fvertical_motion): Don't wrap around LINES values that don't fit
4947 in 'int'. Instead, treat them as extreme values. This is good
4948 enough for windows, which can't have more than INT_MAX lines anyway.
4950 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4952 * Require libxml/parser.h to avoid compilation warning.
4954 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4956 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4957 since this reportedly can destroy thread storage.
4959 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
4961 * syntax.c (find_defun_start): Update all cache variables if
4962 exiting early (Bug#9401).
4964 2011-08-30 Eli Zaretskii <eliz@gnu.org>
4966 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4968 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4969 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4970 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4972 * term.c (tty_append_glyph): New function.
4973 (produce_stretch_glyph): Static function and its prototype deleted.
4975 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4978 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4980 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4981 when checking :margin (Bug#9390).
4982 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
4983 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
4984 so that the name doesn't mislead. All uses changed.
4986 2011-08-28 Johan Bockgård <bojohan@gnu.org>
4988 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4991 2011-08-27 Eli Zaretskii <eliz@gnu.org>
4993 * xdisp.c (move_it_to): Don't bail out early when reaching
4994 position beyond to_charpos, if we are scanning backwards.
4995 (move_it_vertically_backward): When DY == 0, make sure we get to
4996 the first character in the line after the newline.
4998 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5000 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5001 (ccl_driver): Do not generate an out-of-range pointer.
5002 (Fccl_execute_on_string): Remove unnecessary check for
5003 integer overflow, noted by Stefan Monnier in
5004 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5005 Remove a FIXME that didn't need fixing.
5006 Simplify the newly-introduced buffer reallocation code.
5008 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
5010 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5012 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
5014 Integer and memory overflow issues (Bug#9196).
5016 * doc.c (get_doc_string): Rework so that
5017 get_doc_string_buffer_size is the actual buffer size, rather than
5018 being 1 less than the actual buffer size; this makes xpalloc more
5021 * image.c (x_allocate_bitmap_record, cache_image):
5022 * xselect.c (Fx_register_dnd_atom):
5023 Simplify previous changes by using xpalloc.
5025 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5026 since either will do and ptrdiff_t is convenient with xpalloc.
5028 * charset.c (charset_table_size)
5029 (struct charset_sort_data.priority): Now ptrdiff_t.
5030 (charset_compare): Don't overflow if priorities differ greatly.
5031 (Fsort_charsets): Don't assume list length fits in int.
5032 Check for size-calculation overflow when allocating sort data.
5033 (syms_of_charset): Allocate an initial charset table that is
5034 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5036 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5038 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5039 The actual value is always <= INT_MAX, and leaving it unsigned made
5040 overflow checking harder.
5042 * dispextern.h (struct glyph_matrix.rows_allocated)
5043 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5044 with xpalloc. The values are still always <= INT_MAX.
5046 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5048 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5049 (SAFE_NALLOCA): New macro.
5051 * region-cache.c (struct boundary.pos, find_cache_boundary)
5052 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5053 (set_cache_region, invalidate_region_cache)
5054 (revalidate_region_cache, know_region_cache, region_cache_forward)
5055 (region_cache_backward, pp_cache):
5056 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5057 so that ptrdiff_t * can be passed to xpalloc.
5058 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5059 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5060 (pp_cache): Don't assume cache_len fits in int.
5061 * region-cache.h: Adjust extern decls to match.
5063 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5064 EMACS_INT, since either will do, for xpalloc.
5066 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5067 (xnmalloc, xnrealloc, xpalloc): New functions.
5069 * bidi.c (bidi_shelve_header_size): New constant.
5070 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5071 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5073 * bidi.c (bidi_cache_shrink):
5074 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5076 Don't update size of array until after memory allocation succeeds,
5077 because xmalloc/xrealloc may not return.
5078 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5079 now that we have proper integer overflow checking.
5080 (record_overlay_string, overlay_strings): Catch overflows when
5081 calculating size of overlay_str_buf.
5083 * callproc.c (Fcall_process): Check for size overflow when
5084 calculating size of args2.
5085 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5086 Normally we prefer signed values, but sticking with ptrdiff_t would
5087 require adding more-complicated checks.
5089 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5090 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5091 Redo buffer-overflow calculations to avoid integer overflow.
5092 Add a FIXME comment where memory seems to be over-allocated.
5094 * character.c (Fstring): Check for size-calculation overflow.
5096 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5097 unnecessary integer overflow. Check for size overflow.
5098 (encode_coding_object): Don't update size until xmalloc succeeds.
5100 * composite.c (get_composition_id): Check for overflow in glyph
5101 length calculations.
5103 Integer and memory overflow fixes for display code.
5104 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5105 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5106 (scrolling_window): Check for overflow in size calculations.
5107 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5108 Don't assume glyph table len fits in int.
5109 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5110 (row_table_size): Now ptrdiff_t, not int.
5111 (scrolling_window): Avoid overflow in size calculations.
5112 Don't update size until allocation succeeds.
5113 * fns.c (concat): Check for overflow in size calculations.
5114 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5115 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5116 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5118 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5119 (get_doc_string): Check for size calculation overflow.
5120 Don't update size until allocation succeeds.
5121 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5122 EMACS_INT, where ptrdiff_t will do.
5123 (Fsubstitute_command_keys): Check for string overflow.
5125 * editfns.c (set_time_zone_rule): Don't assume environment length
5127 (message_length): Now ptrdiff_t, not int.
5128 (Fmessage_box): Don't update size until allocation succeeds.
5129 Don't assume message length fits in int.
5130 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5132 * emacs.c (main): Do not reallocate argv, since there is a null at
5133 the end that can be overwritten, and this way there's no need to
5134 worry about size-calculation overflow.
5135 (sort_args): Check for size-calculation overflow.
5137 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5139 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5141 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5142 (x_set_scroll_bar_width, x_figure_window_size):
5143 Check for integer overflow.
5144 (x_set_alpha): Do not assume XINT fits in int.
5146 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5147 This is for the members text_lines, text_cols, total_lines, total_cols,
5148 where the system imposes an 'int' limit.
5150 * fringe.c (Fdefine_fringe_bitmap):
5151 Don't update size until alloc works.
5153 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5154 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5156 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5157 Check for size-calculation overflow.
5158 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5159 do, as we prefer signed integers.
5160 (id_to_widget.max_size, id_to_widget.used)
5161 (xg_store_widget_in_map, xg_remove_widget_from_map)
5162 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5163 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5164 Use and return ptrdiff_t, not int.
5165 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5166 * gtkutil.h: Change prototypes to match the above.
5168 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5169 are duplicate now that they've been promoted to lisp.h.
5170 (x_allocate_bitmap_record, x_alloc_image_color)
5171 (make_image_cache, cache_image, xpm_load):
5172 Don't update size until alloc is done.
5173 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5175 Check for size calculation overflow.
5176 (ct_colors_allocated_max): New constant.
5177 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5180 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5181 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5182 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5183 Use ptrdiff_t, not int, to count maps.
5184 (read_char_minibuf_menu_prompt): Check for overflow in size
5185 calculations. Don't update size until allocation succeeds.
5186 Redo calculations to avoid overflow.
5187 * keyboard.h: Change prototypes to match the above.
5189 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5191 (current_minor_maps): Check for size calculation overflow.
5192 * keymap.h: Change prototypes to match the above.
5194 * lread.c (read1, init_obarray): Don't update size until alloc done.
5196 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5197 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5199 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5200 Now ptrdiff_t, not int.
5201 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5202 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5204 * process.c (Fnetwork_interface_list): Check for overflow
5205 in size calculation.
5207 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5209 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5210 overflow. Don't bother calling xmalloc when xrealloc will do.
5212 * search.c (Freplace_match): Check for size calculation overflow.
5213 (Fset_match_data): Don't assume list lengths fit in 'int'.
5215 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5216 for command line length. Do not attempt to address one before the
5217 beginning of an array, as that's not portable.
5219 * term.c (max_frame_lines): Remove; unused.
5220 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5222 (encode_terminal_code, calculate_costs): Check for size
5223 calculation overflow.
5224 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5225 table lengths and related sizes. Don't update size until alloc
5226 done. Redo calculations to avoid overflow.
5227 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5229 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5230 subtracting pointers.
5231 (gobble_line): Check for overflow more carefully. Don't update size
5234 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5235 Don't update size until alloc done.
5236 Redo size calculations to avoid overflow.
5237 Check for size calculation overflow.
5238 (main) [DEBUG]: Fix typo in invoking tparam1.
5240 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5241 Use ptrdiff_t, not int, for sizes.
5242 (store_mode_line_noprop_char): Don't update size until alloc done.
5244 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5245 Use ptrdiff_t, not int, for sizes.
5246 (Finternal_make_lisp_face, cache_face):
5247 Check for size calculation overflow.
5248 (cache_face): Treat size calculation overflows as if they were
5249 memory exhaustion (the usual treatment), rather than aborting.
5251 * xfns.c (x_encode_text, x_set_name_internal)
5252 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5253 sizes, since they can exceed INT_MAX in size. Check for size
5254 calculation overflow.
5256 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5257 (xg_select): Check for size calculation overflow.
5258 Don't update size until alloc done.
5260 * xrdb.c (get_environ_db): Don't assume path length fits in int,
5261 as sprintf is limited to int lengths.
5263 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5264 (X_LONG_MIN): New macros.
5265 Use them to make the following changes clearer.
5266 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5267 This change doesn't affect the value now, but it may help remind
5268 future maintainers not to raise the value too much later.
5269 (SELECTION_QUANTUM): Remove, replacing with ...
5270 (selection_quantum): ... new function, which avoids overflow.
5272 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5273 assumption that selection length fits in 'int'.
5274 (x_reply_selection_request, x_handle_selection_request)
5275 (x_get_window_property, receive_incremental_selection)
5276 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5277 (lisp_data_to_selection_data, clean_local_selection_data):
5278 Use ptrdiff_t, not int, to record length of selection.
5279 (x_reply_selection_request, x_get_window_property)
5280 (receive_incremental_selection, x_property_data_to_lisp):
5281 Redo calculations to avoid overflow.
5282 (x_reply_selection_request): When sending hint, ceiling it at
5283 X_LONG_MAX rather than relying on wraparound overflow to send
5285 (x_get_window_property, receive_incremental_selection)
5286 (lisp_data_to_selection_data, x_property_data_to_lisp):
5287 Check for size-calculation overflow.
5288 (x_get_window_property, receive_incremental_selection)
5289 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5290 Don't store size until memory allocation succeeds.
5291 (x_get_window_property): Plug memory leak on memory exhaustion.
5292 Don't double-block input; malloc is safe here. Don't assume 2**34
5293 - 4 fits in unsigned long. Add an xassert to check
5294 XGetWindowProperty overflow. Be more careful about overflow
5295 calculations, and distinguish size from memory overflow better.
5296 (receive_incremental_selection): When tracing, don't assume
5297 unsigned int is less than INT_MAX.
5298 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5299 harmful) conversions of unsigned short to int.
5300 (lisp_data_to_selection_data): Don't assume that integers
5301 in the range -65535 through -1 fit in an X unsigned short.
5302 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5303 result parameters unless successful. Rely on cons_to_unsigned
5304 to report problems with elements; the old code wasn't right anyway.
5305 (x_check_property_data): Check for int overflow; we cannot use
5306 a wider type due to X limits.
5307 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5309 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
5311 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5312 (x_term_init): Check for size calculation overflow.
5313 (x_color_cells): Don't store size until memory allocation succeeds.
5314 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
5315 Don't assume alloca size is less than MAX_ALLOCA.
5316 (x_term_init): Don't assume length fits in int (sprintf is limited
5319 Use ptrdiff_t for composition IDs.
5320 * character.c (lisp_string_width):
5321 * composite.c (composition_table_size, n_compositions)
5322 (get_composition_id, composition_gstring_from_id):
5323 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5324 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5325 * window.c (Frecenter):
5326 Use ptrdiff_t, not int, for composition IDs.
5327 * composite.c (get_composition_id): Check for integer overflow.
5328 * composite.h: Adjust prototypes to match the above changes.
5330 Use ptrdiff_t for hash table indexes.
5331 * category.c (hash_get_category_set):
5332 * ccl.c (ccl_driver):
5333 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5334 * coding.c (coding_system_charset_list, detect_coding_system):
5335 * coding.h (struct coding_system.id):
5336 * composite.c (get_composition_id, gstring_lookup_cache):
5337 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5338 * image.c (xpm_get_color_table_h):
5339 * lisp.h (hash_lookup, hash_put):
5340 * minibuf.c (Ftest_completion):
5341 Use ptrdiff_t for hash table indexes, not int (which is too
5342 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5343 32-bit --with-wide-int hosts).
5345 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5346 Add a FIXME comment about memory leaks.
5347 (syms_of_charset): Don't assume xmalloc returns.
5349 Don't assume that stated character widths fit in int.
5350 * character.c (Fchar_width, c_string_width, lisp_string_width):
5351 * character.h (CHAR_WIDTH):
5352 * indent.c (MULTIBYTE_BYTES_WIDTH):
5353 Use sanitize_char_width to avoid undefined and/or bad behavior
5354 with outlandish widths.
5355 * character.h (sanitize_tab_width): Rename from sanitize_width,
5356 now that we have two such functions. All uses changed.
5357 (sanitize_char_width): New inline function.
5359 Don't assume that tab-width fits in int.
5360 * character.h (sanitize_width): New inline function.
5361 (SANE_TAB_WIDTH): New macro.
5362 (ASCII_CHAR_WIDTH): Use it.
5363 * indent.c (sane_tab_width): Remove. All uses replaced by
5364 SANE_TAB_WIDTH (current_buffer).
5365 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5367 * fileio.c: Integer overflow issues with file modes.
5368 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5370 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5371 Remove unreachable code.
5372 (read_hex, load_charset_map_from_file): Check for integer overflow.
5374 * xterm.c: Don't go over XClientMessageEvent limit.
5375 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5376 (x_send_scroll_bar_event): Likewise. Check that the size does not
5377 exceed limits imposed by XClientMessageEvent, as well as the usual
5378 ptrdiff_t and size_t limits.
5380 * keyboard.c: Overflow, signedness and related fixes.
5381 (make_lispy_movement): Use same integer type in forward decl
5382 that is used in the definition.
5383 (read_key_sequence, keyremap_step):
5384 Change bufsize argument back to int, undoing my 2011-03-30 change.
5385 We prefer signed types, and int is wide enough here.
5386 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5387 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5388 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5389 length, not size_t. Use ptrdiff_t for index, not int.
5390 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5391 possibility of integer overflow.
5393 Overflow, signedness and related fixes for images.
5395 * dispextern.h (struct it.stack[0].u.image.image_id)
5396 (struct_it.image_id, struct image.id, struct image_cache.size)
5397 (struct image_cache.used, struct image_cache.ref_count):
5398 * gtkutil.c (update_frame_tool_bar):
5399 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5400 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5401 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5402 * nsmenu.m (update_frame_tool_bar):
5403 * xdisp.c (calc_pixel_width_or_height):
5404 * xfns.c (image_cache_refcount):
5405 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5406 on typical 64-bit hosts.
5408 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5409 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5410 Omit unnecessary casts to int.
5411 (parse_image_spec): Check that integers fall into 'int' range
5412 when the callers expect that.
5413 (image_ascent): Redo ascent calculation to avoid int overflow.
5414 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5415 (lookup_image): Remove unnecessary tests.
5416 (xbm_image_p): Locals are now of int, not EMACS_INT,
5417 since parse_image_check makes sure they fit into int.
5418 (png_load, gif_load, svg_load_image):
5419 Prefer int to unsigned where either will do.
5420 (tiff_handler): New function, combining the cores of the
5421 old tiff_error_handler and tiff_warning_handler.
5422 This function is rewritten to use vsnprintf and thereby avoid
5423 stack buffer overflows. It uses only the features of vsnprintf
5424 that are common to both POSIX and native Microsoft.
5425 (tiff_error_handler, tiff_warning_handler): Use it.
5426 (tiff_load, gif_load, imagemagick_load_image):
5427 Don't assume :index value fits in 'int'.
5428 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5429 (imagemagick_load_image): Check that crop parameters fit into
5430 the integer types that MagickCropImage accepts. Don't assume
5431 Vimagemagick_render_type has a nonnegative value. Don't assume
5432 size_t fits in 'long'.
5433 (gs_load): Use printmax_t to print the widest integers possible.
5434 Check for integer overflow when computing image height and width.
5436 2011-08-26 Eli Zaretskii <eliz@gnu.org>
5438 * xdisp.c (redisplay_window): Don't force window start if point
5439 will be invisible in the resulting window. (Bug#9324)
5441 2011-08-25 Eli Zaretskii <eliz@gnu.org>
5443 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5444 the display spec is of the form `(space ...)'.
5445 (handle_display_spec): Return the value returned by
5446 handle_single_display_spec, not just 1 or zero.
5447 (handle_single_display_spec): If the display spec is of the form
5448 `(space ...)', and specifies display in the text area, return 2
5450 (try_cursor_movement): Check for the need to scroll more
5451 accurately, and prefer exact match for point under bidi.
5452 Don't advance `row' beyond the last row of the window.
5454 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5455 into disp_prop; all users changed.
5457 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5458 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5459 for the text covered by the display property.
5461 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
5463 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5464 Change return value to nil.
5465 (Frecord_buffer): Delete unused function.
5467 2011-08-24 Eli Zaretskii <eliz@gnu.org>
5469 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5470 buffers, return left-to-right.
5471 (set_cursor_from_row): Consider candidate row a win if its glyph
5472 represents a newline and point is on that newline. Fixes cursor
5473 positioning on the newline at EOL of R2L text within L2R
5474 paragraph, and vice versa.
5475 (try_cursor_movement): Check continued rows, in addition to
5476 continuation rows. Fixes unwarranted scroll when point enters a
5477 continued line of R2L text within an L2R paragraph, or vice versa.
5478 (cursor_row_p): Consider the case of point being equal to
5479 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5480 from the end of a short line to the beginning of a continued line
5481 of R2L text within L2R paragraph.
5482 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5483 composed characters.
5485 * bidi.c (bidi_check_type): Use xassert.
5486 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5489 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5491 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5494 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
5496 * nsfont.m (ns_otf_to_script): Fix typo.
5498 2011-08-22 Kenichi Handa <handa@m17n.org>
5500 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5501 extra slot even if the purpose is char-code-property-table.
5503 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5505 * xdisp.c (redisplay_window): When computing centering_position,
5506 account for the height of the header line. (Bug#8874)
5508 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5509 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5510 candidate is selected by the mouse, and that candidate has a
5511 composed character under the mouse.
5513 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5514 coordinates reported by pos-visible-in-window-p for a composed
5515 character in column zero.
5517 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5519 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5521 2011-08-22 Eli Zaretskii <eliz@gnu.org>
5523 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5524 consider it a hit if to_charpos is anywhere in the range of the
5525 composed buffer positions.
5527 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
5529 * image.c (gif_load): Don't assume that each subimage has the same
5530 dimensions as the base image. Handle disposal method that is
5531 "undefined" by the gif spec (Bug#9335).
5533 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
5535 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
5536 (Fcondition_case): Document `debug' symbol in error handler.
5538 2011-08-19 Eli Zaretskii <eliz@gnu.org>
5540 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5541 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5542 from an Org mode buffer to a Speedbar frame.
5544 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5545 a composition, take its buffer position from IT->cmp_it.charpos.
5546 Fixes cursor positioning at the beginning of a line that begins
5547 with a composed character.
5549 2011-08-18 Eli Zaretskii <eliz@gnu.org>
5551 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5552 character bidirectional type, use STRONG_L instead. Fixes crashes
5553 in a buffer produced by `describe-categories'.
5555 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5556 members before the level stack, so they would be saved and
5557 restored when copying iterator state. Fixes incorrect reordering
5558 around TABs covered by display properties.
5560 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5562 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
5564 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
5566 * eval.c (internal_condition_case, internal_condition_case_1)
5567 (internal_condition_case_2, internal_condition_case_n):
5568 Remove unnecessary aborts (Bug#9081).
5570 2011-08-17 Eli Zaretskii <eliz@gnu.org>
5572 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5573 has no `load' handler, try opening the file locally. (Bug#9311)
5575 2011-08-16 Ken Brown <kbrown@cornell.edu>
5577 * gmalloc.c: Expand comment.
5579 2011-08-16 Eli Zaretskii <eliz@gnu.org>
5581 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5582 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5584 2011-08-16 Ken Brown <kbrown@cornell.edu>
5586 Fix memory allocation problems in Cygwin build (Bug#9273).
5588 * unexcw.c ( __malloc_initialized): Declare external variable.
5589 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5591 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5593 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5595 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5597 [CYGWIN] (special_realloc): New function.
5598 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5599 requests to realloc storage in the static heap.
5601 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5603 * bidi.c (bidi_initialize): Remove unused local.
5605 2011-08-15 Eli Zaretskii <eliz@gnu.org>
5608 * biditype.h: Remove file.
5609 * makefile.w32-in ($(BLD)/bidi.$(O)):
5610 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
5612 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5614 * chartab.c: Improve commentary for the uniprop_table API.
5616 * bidi.c (bidi_paragraph_init): Support zero value of
5617 bidi_ignore_explicit_marks_for_paragraph_level.
5618 (bidi_initialize): Use uniprop_table instead of including
5619 biditype.h and bidimirror.h.
5621 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5622 coordinates of the iterator when restoring from ppos_it.
5625 2011-08-14 Kenichi Handa <handa@m17n.org>
5627 * process.c (create_process): Call setup_process_coding_systems
5628 after the pid of the process is set to -1 (Bug#8162).
5630 2011-08-14 Eli Zaretskii <eliz@gnu.org>
5632 * xdisp.c (move_it_in_display_line_to): Don't invoke
5633 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5634 ppos_it. Fixes vertical cursor motion when line beginning is
5635 covered by an image. (Bug#9296)
5637 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5639 * nsterm.h (ns_run_ascript): Declare.
5640 (NSAPP_DATA2_RUNASSCRIPT): Define.
5642 * nsfns.m (as_script, as_result, as_status): New static variables.
5643 (ns_run_ascript): New function.
5644 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
5645 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5646 the event loop. Get status from as_status (Bug#7276).
5648 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5649 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5650 the event loop (Bug#7276).
5652 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5654 * gnutls.c (QCgnutls_bootprop_priority)
5655 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5656 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5657 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5658 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5659 (QCgnutls_bootprop_verify_hostname_error)
5660 (QCgnutls_bootprop_callbacks_verify): Rename from
5661 Qgnutls_bootprop_..., all uses changed.
5663 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5666 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5668 * xfaces.c (Qframe_set_background_mode): Now static.
5669 * dispextern.h (Qframe_set_background_mode): Remove decl.
5671 * process.c (Fnetwork_interface_info): Declare local only if needed.
5673 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5675 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5676 (Fnetwork_interface_list): Allocate in increments of bytes instead
5677 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5678 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5680 (struct ifflag_def): notrailers is smart on OSX.
5681 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5682 Get hardware address with getifaddrs if available.
5684 2011-08-12 Eli Zaretskii <eliz@gnu.org>
5686 * xdisp.c (iterate_out_of_display_property): xassert that
5687 IT->position is set to within IT->object's boundaries. Break from
5688 the loop as soon as EOB is reached; avoids infloops in redisplay
5689 when IT->position is set up wrongly due to some bug.
5690 Set IT->current to match the bidi iterator unconditionally.
5691 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5692 entry. Force push_it to save on the stack the current
5693 buffer/string position, to be restored by pop_it. Fix flags in
5694 the iterator structure wrt the object coming from a display
5695 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5696 properties. (Bug#9284)
5698 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
5700 * fontset.c (fontset_get_font_group): Add proper type checks.
5703 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5705 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5706 and LC_VERSION_MIN_MACOSX.
5707 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5708 (dump_it) [LC_FUNCTION_STARTS]: Use it.
5710 2011-08-08 Eli Zaretskii <eliz@gnu.org>
5712 * xdisp.c (forward_to_next_line_start): Allow to use the
5713 no-display-properties-and-no-overlays under bidi display.
5714 Set disp_pos in the bidi iterator to avoid searches for display
5715 properties and overlays.
5717 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
5719 * editfns.c (Fset_time_zone_rule): Document relationship with the
5722 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5723 the font entity extracted from the cache (Bug#8109).
5725 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
5727 * composite.c (autocmp_chars): Don't reset point. That is done by
5728 restore_point_unwind (Bug#5984).
5730 2011-08-07 Juri Linkov <juri@jurta.org>
5732 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5733 to show the arg `TIME' instead of `TIMEVAL'.
5735 2011-08-06 Eli Zaretskii <eliz@gnu.org>
5737 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5738 display property strides EOL and includes a newline, as in
5739 longlines-mode. (Bug#9254)
5740 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5741 word-wrap under bidirectional display. (Bug#9224)
5743 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5744 is non-zero, even if the data buffer is NULL. Fixes a crash in
5745 vertical-motion with longlines-mode. (Bug#9254)
5747 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5749 * bidi.c <bidi_cache_total_alloc>: Now static.
5750 (bidi_initialize): Initialize bidi_cache_total_alloc.
5752 * xdisp.c (display_line): Release buffer allocated for shelved bidi
5755 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5756 amount allocated this far in `bidi_cache_total_alloc'.
5757 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5758 non-zero, only free the data buffer without restoring the cache
5759 contents. All callers changed.
5761 * dispextern.h (bidi_unshelve_cache): Update prototype.
5763 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5764 (move_it_in_display_line, move_it_to)
5765 (move_it_vertically_backward, move_it_by_lines): Replace the call
5766 to xfree to an equivalent call to bidi_unshelve_cache.
5767 (move_it_in_display_line_to): Fix logic of returning
5768 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
5770 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5772 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5773 came from a string character with a `cursor' property. (Bug#9229)
5775 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5777 * Makefile.in (LIB_PTHREAD): New variable.
5778 (LIBES): Add LIB_PTHREAD (Bug#9216).
5780 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5781 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5783 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5785 * regex.c (re_iswctype): Remove some redundant boolean conversions.
5787 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5789 * xterm.c (x_find_topmost_parent): New function.
5790 (x_set_frame_alpha): Find topmost parent window with
5791 x_find_topmost_parent and set the property there also (bug#9181).
5792 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5794 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5796 * callproc.c (Fcall_process): Avoid vfork clobbering
5797 the local vars buffer, coding_systems, current_dir.
5799 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5801 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5803 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5805 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5806 so that it is not optimized away.
5808 * xdisp.c (compute_display_string_pos): Remove unused local.
5810 2011-08-02 Eli Zaretskii <eliz@gnu.org>
5812 Fix slow cursor motion and scrolling in large buffers with
5813 selective display, like Org Mode buffers. (Bug#9218)
5815 * dispextern.h (struct bidi_it): New member disp_prop_p.
5817 * xdisp.c: Remove one-slot cache of display string positions.
5818 (compute_display_string_pos): Accept an additional argument
5819 DISP_PROP_P; callers changed. Scan at most 5K characters forward
5820 for a display string or property. If found, set DISP_PROP_P
5823 * bidi.c (bidi_fetch_char): Accept an additional argument
5824 DISP_PROP_P, and pass it to compute_display_string_pos.
5825 Only handle text covered by a display string if DISP_PROP_P is returned
5826 non-zero. All callers of bidi_fetch_char changed.
5828 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5830 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5832 2010-12-03 Don March <don@ohspite.net>
5834 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5835 last character M-[char] is translated to ESC [char] (bug#7541).
5837 2011-08-02 Kenichi Handa <handa@m17n.org>
5839 * lisp.h (uniprop_table): Extern it.
5841 * chartab.c (uniprop_table): Make it non-static.
5843 2011-08-01 Eli Zaretskii <eliz@gnu.org>
5845 * xdisp.c (forward_to_next_line_start): Accept additional argument
5846 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5848 (reseat_at_next_visible_line_start): Use the bidi iterator state
5849 returned by forward_to_next_line_start to restore the state of
5850 it->bidi_it after backing up to previous newline. (Bug#9212)
5852 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5854 * regex.c (re_comp): Protoize.
5855 (re_exec): Fix return type.
5856 (regexec): Fix type of `ret'. (Bug#9203)
5858 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5860 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5861 This is needed if max-image-size is a floating-point number.
5863 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5865 * print.c (print_object): Print empty symbol as ##.
5867 * lread.c (read1): Read ## as empty symbol.
5869 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5871 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5872 setting frame foreground color (Bug#9175).
5873 (x_set_background_color): Likewise.
5875 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5876 contents (Bug#9176).
5877 (EmacsTooltip -init): Remove bezels and add shadows to
5880 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5881 or scroll bar (Bug#8470).
5883 * nsfont.m (nsfont_open): Remove assignment to voffset and
5884 unnecessary vars hshink, expand, hd, full_height, min_height.
5885 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5887 * nsterm.h (nsfont_info): Remove voffset field.
5889 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5891 Implement strike-through and overline on NextStep (Bug#8863).
5893 * nsfont.m (nsfont_open): Use underline position provided by font,
5894 instead of hard-coded value of 2.
5895 (nsfont_draw): Call ns_draw_text_decoration instead.
5897 * nsterm.h: Add declaration for ns_draw_text_decoration.
5899 * nsterm.m (ns_draw_text_decoration): New function for drawing
5900 underline, overline, and strike-through.
5901 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5902 ns_draw_text_decoration. Change treatment of cursor drawing to
5903 accommodate underlining, etc.
5905 2011-07-28 Eli Zaretskii <eliz@gnu.org>
5907 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5910 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5912 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5913 Without this fix, if a signal arrives just after memory fills up,
5914 'malloc' might be invoked reentrantly.
5916 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5917 In other words, assume that every image size is allowed, on non-X
5918 hosts. This assumption is probably wrong, but it lets Emacs compile.
5920 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5922 * regex.c (re_iswctype): Convert return values to boolean.
5924 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5926 * xdisp.c (compute_display_string_pos): Don't use cached display
5927 string position if the buffer had its restriction changed.
5930 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5932 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5934 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5936 Integer signedness and overflow and related fixes. (Bug#9079)
5938 * bidi.c: Integer size and overflow fixes.
5939 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5940 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5941 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5942 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5943 (bidi_find_other_level_edge):
5944 Use ptrdiff_t instead of EMACS_INT where either will do.
5945 This works better on 32-bit hosts configured --with-wide-int.
5946 (bidi_cache_ensure_space): Check for size-calculation overflow.
5947 Use % rather than repeated addition, for better worst-case speed.
5948 Don't set bidi_cache_size until after xrealloc returns, because it
5950 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
5951 (bidi_cache_ensure_space): Also check that the bidi cache size
5952 does not exceed that of the largest Lisp string or buffer. See Eli
5953 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
5955 * alloc.c (__malloc_size_t): Remove.
5956 All uses replaced by size_t. See Andreas Schwab's note
5957 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5959 * image.c: Improve checking for integer overflow.
5960 (check_image_size): Assume that f is nonnull, since
5961 it is always nonnull in practice. This is one less thing to
5962 worry about when checking for integer overflow later.
5963 (x_check_image_size): New function, which checks for integer
5964 overflow issues inside X.
5965 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5966 This removes the need for a memory_full check.
5967 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5968 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5969 (xbm_read_bitmap_data): Change locals back to 'int', since
5970 their values must fit in 'int'.
5971 (xpm_load_image, png_load, tiff_load):
5972 Invoke x_create_x_image_and_pixmap earlier,
5973 to avoid much needless work if the image is too large.
5974 (tiff_load): Treat overly large images as if
5975 x_create_x_image_and_pixmap failed, not as malloc failures.
5976 (gs_load): Use x_check_image_size.
5978 * gtkutil.c: Omit integer casts.
5979 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5980 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5982 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5984 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5985 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5986 would wrongly return t on a 64-bit host.
5988 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5989 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5990 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5991 and therefore cause GCC to emit a bogus diagnostic in some cases.
5993 * image.c: Integer signedness and overflow and related fixes.
5994 This is not an exhaustive set of fixes, but it's time to
5995 record what I've got.
5996 (lookup_pixel_color, check_image_size): Remove redundant decls.
5997 (check_image_size): Don't assume that arbitrary EMACS_INT values
5998 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5999 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6000 (tiff_load, imagemagick_load_image):
6001 Check for overflow in size calculations.
6002 (x_create_x_image_and_pixmap): Remove unnecessary test for
6003 xmalloc returning NULL; that can't happen.
6004 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6005 (xpm_color_bucket): Use better integer hashing function.
6006 (xpm_cache_color): Don't possibly over-allocate memory.
6007 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6008 (gif_memory_source):
6009 Use ptrdiff_t, not int or size_t, to record sizes.
6010 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6011 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6012 either works, as we prefer signed integers.
6013 (tiff_read_from_memory, tiff_write_from_memory):
6014 Return tsize_t, not size_t, since that's what the TIFF API wants.
6015 (tiff_read_from_memory): Don't fail simply because the read would
6016 go past EOF; instead, return a short read.
6017 (tiff_load): Omit no-longer-needed casts.
6018 (Fimagemagick_types): Don't assume size fits into 'int'.
6020 Improve hashing quality when configured --with-wide-int.
6021 * fns.c (hash_string): New function, taken from sxhash_string.
6022 Do not discard information about ASCII character case; this
6023 discarding is no longer needed.
6024 (sxhash-string): Use it. Change sig to match it. Caller changed.
6025 * lisp.h: Declare it.
6026 * lread.c (hash_string): Remove, since we now use fns.c's version.
6027 The fns.c version returns a wider integer if --with-wide-int is
6028 specified, so this should help the quality of the hashing a bit.
6030 * emacs.c: Integer overflow minor fix.
6031 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6032 Define only if GNU_LINUX.
6033 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6035 * dispnew.c: Integer signedness and overflow fixes.
6036 Remove unnecessary forward decls, that were a maintenance hassle.
6037 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6039 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6040 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6041 (prepare_desired_row, line_draw_cost):
6042 Use int, not unsigned, where either works.
6043 (save_current_matrix, restore_current_matrix):
6044 Use ptrdiff_t, not size_t, where either works.
6045 (init_display): Check for overflow more accurately, and without
6046 relying on undefined behavior.
6048 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6049 Remove, replacing with the new symbols in lisp.h. All uses changed.
6050 * fileio.c (make_temp_name):
6051 * filelock.c (lock_file_1, lock_file):
6052 * xdisp.c (message_dolog):
6053 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6054 Use pMd etc. instead.
6055 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6056 replacing the pWIDE etc. symbols removed from editfns.c.
6058 * keyboard.h (num_input_events): Now uintmax_t.
6059 This is (very slightly) less likely to mess up due to wraparound.
6062 * buffer.c: Integer signedness fixes.
6063 (alloc_buffer_text, enlarge_buffer_text):
6064 Use ptrdiff_t rather than size_t when either will do, as we prefer
6067 * alloc.c: Integer signedness and overflow fixes.
6068 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6069 (__malloc_size_t): Default to size_t, not to int.
6070 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6071 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6072 Prefer ptrdiff_t to size_t when either would do, as we prefer
6074 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6075 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6076 Now const. Initialize with values that are in range even if char
6078 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6079 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6080 These functions do the right thing with sizes > 2**32.
6081 (check_depth): Now ptrdiff_t, not int.
6082 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6083 Adjust to new way of storing sizes. Check for size overflow bugs
6085 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6086 slightly wrong anyway, as it missed one instance of
6087 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6088 (refill_memory_reserve): Omit needless cast to size_t.
6089 (mark_object_loop_halt): Mark as externally visible.
6091 * xselect.c: Integer signedness and overflow fixes.
6092 (Fx_register_dnd_atom, x_handle_dnd_message):
6093 Use ptrdiff_t, not size_t, since we prefer signed.
6094 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6095 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6096 x_dnd_atoms_size and x_dnd_atoms_length.
6098 * doprnt.c: Prefer signed to unsigned when either works.
6100 * doprnt.c (doprnt):
6102 * xdisp.c (vmessage):
6103 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6104 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6105 prefer signed arithmetic to avoid comparison confusion.
6106 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6107 but is a bit tricky.
6109 Assume freestanding C89 headers, string.h, stdlib.h.
6110 * data.c, doprnt.c, floatfns.c, print.c:
6111 Include float.h unconditionally.
6112 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6113 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6114 * regex.c: Likewise for stddef.h, string.h.
6115 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6116 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6117 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6118 (STDC_HEADERS): Remove obsolete defines.
6119 * sysdep.c: Include limits.h unconditionally.
6121 Assume support for memcmp, memcpy, memmove, memset.
6122 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6123 * regex.c (memcmp, memcpy):
6124 Remove; we assume C89 now.
6126 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6127 (__malloc_safe_bcopy): Remove; no longer needed.
6129 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6130 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6131 well either way, and we prefer signed to unsigned.
6133 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6135 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6136 closes the connection while we're reading (bug#9182).
6138 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
6140 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6141 are specified (Bug#9168).
6143 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6145 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6146 Found by GCC static checking and --with-wide-int on a 32-bit host.
6148 2011-07-25 Eli Zaretskii <eliz@gnu.org>
6150 * xdisp.c (compute_display_string_pos): Fix logic of caching
6151 previous display string position. Initialize cached_prev_pos to
6152 -1. Fixes slow-down at the beginning of a buffer.
6154 2011-07-24 Eli Zaretskii <eliz@gnu.org>
6156 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6157 for attrs[LFACE_FONTSET_INDEX].
6159 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6161 * xml.c (parse_region): Remove unused local
6162 that was recently introduced.
6164 2011-07-23 Eli Zaretskii <eliz@gnu.org>
6166 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6167 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6169 * xdisp.c (move_it_in_display_line_to): Record the best matching
6170 position for TO_CHARPOS while scanning the line, and restore it on
6171 exit if none of the characters scanned was an exact match.
6172 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
6173 when exact match is impossible due to invisible text, and the
6174 lines are truncated.
6176 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6178 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6181 2011-07-22 Eli Zaretskii <eliz@gnu.org>
6183 Fix a significant slow-down of cursor motion with C-n, C-p,
6184 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6185 auto-repeat under bidi redisplay in fontified buffers.
6186 * xdisp.c (compute_stop_pos_backwards): New function.
6187 (next_element_from_buffer): Call compute_stop_pos_backwards to
6188 find a suitable prev_stop when we find ourselves before
6190 (reseat): Don't look for prev_stop, as that could mean a very long
6192 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6193 <cached_disp_overlay_modiff>: Cache for last found display string
6195 (compute_display_string_pos): Return the cached position if asked
6196 about the same buffer in the same area of character positions, and
6197 the buffer wasn't changed since the time the display string
6198 position was cached.
6200 2011-07-22 Eli Zaretskii <eliz@gnu.org>
6202 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6203 is an integer, which is important for empty lines. (Bug#9149)
6205 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
6207 * frame.c (Fmodify_frame_parameters): In tty case, update the
6208 default face if necessary (Bug#4238).
6210 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
6212 * editfns.c (Fstring_to_char): No need to explain what a character
6213 is in the docstring (Bug#6576).
6215 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6217 * xml.c (parse_region): Make sure we always return a tree.
6219 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6221 * xml.c (parse_region): If a document contains only comments,
6224 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6226 * xml.c (make_dom): Return comments, too.
6228 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6231 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6232 and the surrounding thread.
6233 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6234 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6235 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6237 * s/openbsd.h (BROKEN_SIGIO): Define.
6238 * unexelf.c (unexec) [__OpenBSD__]:
6239 Don't update the .mdebug section of the Alpha COFF symbol table.
6241 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6243 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6246 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6248 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6249 This fixes some race conditions on the permissions of any newly
6252 * alloc.c (valid_pointer_p): Use pipe, not open.
6253 This fixes some permissions issues when debugging.
6255 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6256 If fchown fails to set both uid and gid, try to set just gid,
6257 as that is sometimes allowed. Adjust the file's mode to eliminate
6258 setuid or setgid bits that are inappropriate if fchown fails.
6260 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6262 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6263 to compare Lisp_Objects.
6264 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6265 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6266 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6268 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6270 * lread.c (read_integer): Unread even EOF character.
6271 (read1): Likewise. Properly record start position of symbol.
6273 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6274 symbol character follows.
6276 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6278 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6279 This works around a problem with the previous change to Fcopy_file.
6280 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6281 and without this change, GCC might complain about discarding
6282 fchown's return value.
6284 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
6286 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6288 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6290 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6292 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6294 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6295 it's used from the C level.
6297 * process.c: Use the same condition for POLL_FOR_INPUT in both
6298 keyboard.c and process.c (bug#1858).
6300 2011-07-09 Lawrence Mitchell <wence@gmx.li>
6302 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6303 (Fgnutls_boot): Use it.
6305 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6307 * doc.c (Fsubstitute_command_keys): Revert last change.
6309 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6311 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6312 quotes the next character, and doesn't affect other longer
6313 sequences (bug#8935).
6315 * lread.c (syms_of_lread): Clarify that is isn't only
6316 `eval-buffer' and `eval-defun' that's affected by
6317 `lexical-binding' (bug#8460).
6319 2011-07-15 Eli Zaretskii <eliz@gnu.org>
6321 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6322 bidi redisplay when a line includes both an image and is truncated.
6324 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6326 Fix minor problems found by static checking.
6327 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6328 (elsz): Now a signed constant, not a size_t var. We prefer signed
6329 types to unsigned, to avoid integer comparison confusion. Without
6330 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6331 "cannot optimize loop, the loop counter may overflow", a symptom
6333 * indent.c (Fvertical_motion): Mark locals as initialized.
6334 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6336 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6338 * search.c (Fre_search_backward): Mention `case-fold-search' in
6339 all the re_search_* functions (bug#8138).
6341 * keyboard.c (Fopen_dribble_file): Document when the file is
6344 2011-07-14 Eli Zaretskii <eliz@gnu.org>
6346 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6349 Support bidi reordering of display and overlay strings.
6350 * xdisp.c (compute_display_string_pos)
6351 (compute_display_string_end): Accept additional argument STRING.
6352 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6353 (reseat_to_string): Initialize bidi_it->string.s and
6354 bidi_it->string.schars.
6355 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
6356 NULL (avoids a crash in bidi_paragraph_init).
6357 Initialize itb.string.lstring.
6358 (init_iterator): Call bidi_init_it only of a valid
6359 buffer position was specified. Initialize paragraph_embedding to
6361 (reseat_to_string): Initialize the bidi iterator.
6362 (display_string): If we need to ignore text properties of
6363 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6364 original value of -1 will not work with bidi.)
6365 (compute_display_string_pos): First arg is now struct
6366 `text_pos *'; all callers changed. Support display properties on
6368 (compute_display_string_end): Support display properties on Lisp
6370 (init_iterator, reseat_1, reseat_to_string): Initialize the
6371 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6372 when iterating on a string not from display properties).
6373 (compute_display_string_pos, compute_display_string_end):
6374 Fix calculation of the object to scan. Fixes an error when using
6376 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
6377 base_level_stop; instead, set base_level_stop to BEGV.
6378 Fixes crashes in vertical-motion.
6379 (next_element_from_buffer): Improve commentary for when
6380 the iterator is before prev_stop.
6381 (init_iterator): Initialize bidi_p from the default value of
6382 bidi-display-reordering, not from buffer-local value. Use the
6383 buffer-local value only if initializing for buffer iteration.
6384 (handle_invisible_prop): Support invisible properties on strings
6385 that are being bidi-reordered.
6386 (set_iterator_to_next): Support bidi reordering of C strings and
6388 (next_element_from_string): Support bidi reordering of Lisp
6390 (handle_stop_backwards): Support Lisp strings as well.
6391 (display_string): Support display of R2L glyph rows.
6392 Use IT_STRING_CHARPOS when displaying from a Lisp string.
6393 (init_iterator): Don't initialize it->bidi_p for strings
6395 (reseat_to_string): Initialize it->bidi_p for strings here.
6396 (next_element_from_string, next_element_from_c_string)
6397 (next_element_from_buffer): Add xassert's for correspondence
6398 between IT's object being iterated and it->bidi_it.string
6400 (face_before_or_after_it_pos): Support bidi iteration.
6401 (next_element_from_c_string): Handle the case of the first string
6402 character that is not the first one in the visual order.
6403 (get_visually_first_element): New function, refactored from common
6404 parts of next_element_from_buffer, next_element_from_string, and
6405 next_element_from_c_string.
6406 (tool_bar_lines_needed, redisplay_tool_bar)
6407 (display_menu_bar): Force left-to-right direction. Add a FIXME
6408 comment for making that be controlled by a user option.
6409 (push_it, pop_it): Save and restore the state of the
6410 bidi iterator. Save and restore the bidi_p flag.
6411 (pop_it): Iterate out of display property for string iteration as
6413 (iterate_out_of_display_property): Support iteration over strings.
6414 (handle_single_display_spec): Set up it->bidi_it for iteration
6415 over a display string, and call bidi_init_it.
6416 (handle_single_display_spec, next_overlay_string)
6417 (get_overlay_strings_1, push_display_prop): Set up the bidi
6418 iterator for displaying display or overlay strings.
6419 (forward_to_next_line_start): Don't use the shortcut if
6421 (back_to_previous_visible_line_start): If handle_display_prop
6422 pushed the iterator stack, restore the internal state of the bidi
6423 iterator by calling bidi_pop_it same number of times.
6424 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6425 and we are bidi-iterating, don't decrement the iterator position;
6426 instead, set the first_elt flag in the bidi iterator, to produce
6428 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6429 (push_display_prop): xassert that we are iterating a buffer.
6430 (push_it, pop_it): Save and restore paragraph_embedding member.
6431 (handle_single_display_spec, next_overlay_string)
6432 (get_overlay_strings_1, reseat_1, reseat_to_string)
6433 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6434 correctly. Don't assume unibyte strings are not bidi-reordered.
6435 (compute_display_string_pos)
6436 (compute_display_string_end): Fix handling the case of C string.
6437 (push_it, pop_it): Save and restore from_disp_prop_p.
6438 (handle_single_display_spec, push_display_prop): Set the
6439 from_disp_prop_p flag.
6440 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6441 (pop_it): Call iterate_out_of_display_property only if we are
6442 popping after iteration over a string that came from a display
6443 property. Fix a typo in popping stretch info. Add an assertion
6444 for verifying that the iterator position is in sync with the bidi
6446 (handle_single_display_spec, get_overlay_strings_1)
6447 (push_display_prop): Fix initialization of paragraph direction for
6448 string when that of the parent object is not yet determined.
6449 (reseat_1): Call bidi_init_it to resync the bidi
6450 iterator with IT's position. (Bug#7616)
6451 (find_row_edges): If ROW->start.pos gives position
6452 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6453 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6454 Reset the from_disp_prop_p flag.
6455 (SAVE_IT, RESTORE_IT): New macros.
6456 (pos_visible_p, face_before_or_after_it_pos)
6457 (back_to_previous_visible_line_start)
6458 (move_it_in_display_line_to, move_it_in_display_line)
6459 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6460 (try_scrolling, redisplay_window, display_line): Use them when
6461 saving a temporary copy of the iterator and restoring it back.
6462 (back_to_previous_visible_line_start, reseat_1)
6463 (init_iterator): Empty the bidi cache "stack".
6464 (move_it_in_display_line_to): If iterator ended up at
6465 EOL, but we never saw any buffer positions smaller than
6466 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6467 motion in bidi-reordered lines.
6468 (move_it_in_display_line_to): Record prev_method and prev_pos
6469 immediately before the call to set_iterator_to_next. Fixes cursor
6470 motion in bidi-reordered lines with stretch glyphs and strings
6471 displayed in margins. (Bug#8133) (Bug#8867)
6472 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6474 (pos_visible_p): Support positions in bidi-reordered lines.
6475 Save and restore bidi cache.
6477 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6478 (bidi_paragraph_info): Delete unused struct.
6479 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6480 (bidi_cache_start): New variable.
6481 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6483 (bidi_cache_fetch_state, bidi_cache_search)
6484 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6485 (bidi_cache_find, bidi_peek_at_next_level)
6486 (bidi_level_of_next_char, bidi_find_other_level_edge)
6487 (bidi_move_to_visually_next): Compare cache index with
6488 bidi_cache_start rather than with zero.
6489 (bidi_fetch_char): Accept new argument STRING; all callers
6490 changed. Support iteration over a string. Support strings with
6491 display properties. Support unibyte strings. Fix the type of
6492 `len' according to what STRING_CHAR_AND_LENGTH expects.
6493 (bidi_paragraph_init, bidi_resolve_explicit_1)
6494 (bidi_resolve_explicit, bidi_resolve_weak)
6495 (bidi_level_of_next_char, bidi_move_to_visually_next):
6496 Support iteration over a string.
6497 (bidi_set_sor_type, bidi_resolve_explicit_1)
6498 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6499 can now be zero (for strings); special values 0 and -1 were
6500 changed to -1 and -2, respectively.
6501 (bidi_char_at_pos): New function.
6502 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6503 Call it instead of FETCH_MULTIBYTE_CHAR.
6504 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6505 initialized to valid values.
6506 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6508 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6509 the test for valid cached positions. Fix the logic for looking up
6510 the sentinel state in the cache. GCPRO the Lisp string we are
6512 (bidi_push_it, bidi_pop_it): New functions.
6513 (bidi_initialize): Initialize the bidi cache start stack pointer.
6514 (bidi_cache_ensure_space): New function, refactored from part of
6515 bidi_cache_iterator_state. Don't assume the required size is just
6516 one BIDI_CACHE_CHUNK away.
6517 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6518 (bidi_count_bytes, bidi_char_at_pos): New functions.
6519 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6520 always valid if bidi_cache_idx is valid.
6521 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6522 is valid if it's going to be used.
6523 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6524 (bidi_cache_fetch_state, bidi_cache_search)
6525 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6526 (bidi_cache_iterator_state, bidi_cache_find)
6527 (bidi_find_other_level_edge, bidi_cache_start_stack):
6528 All variables related to cache indices are now EMACS_INT.
6530 * dispextern.h (struct bidi_string_data): New structure.
6531 (struct bidi_it): New member `string'. Make flag members be 1-bit
6532 fields, and put them last in the struct.
6533 (compute_display_string_pos, compute_display_string_end):
6535 (bidi_push_it, bidi_pop_it): Add prototypes.
6536 (struct iterator_stack_entry): New members bidi_p,
6537 paragraph_embedding, and from_disp_prop_p.
6538 (struct it): Member bidi_p is now a bit field 1 bit wide.
6539 (bidi_shelve_cache, bidi_unshelve_cache):
6542 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6543 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6544 and vector-like objects.
6546 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6547 cache around display iteration.
6549 * window.c (Fwindow_end, window_scroll_pixel_based)
6550 (displayed_window_lines, Frecenter): Save and restore the bidi
6551 cache around display iteration.
6553 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6555 * editfns.c (Fdelete_region): Clarify the use of the named
6556 parameters (bug#6788).
6558 2011-07-14 Martin Rudalics <rudalics@gmx.at>
6560 * indent.c (Fvertical_motion): Set and restore w->pointm when
6561 saving and restoring the window's buffer (Bug#9006).
6563 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6565 * editfns.c (Fstring_to_char): Clarify just what is returned
6566 (bug#6576). Text by Eli Zaretskii.
6568 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
6570 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6572 2011-07-13 Eli Zaretskii <eliz@gnu.org>
6574 * buffer.c (mmap_find): Fix a typo.
6576 2011-07-13 Johan Bockgård <bojohan@gnu.org>
6578 Fix execution of x selection hooks.
6579 * xselect.c (Qx_lost_selection_functions)
6580 (Qx_sent_selection_functions): New vars.
6581 (syms_of_xselect): DEFSYM them.
6582 (x_handle_selection_request): Pass Qx_sent_selection_functions
6583 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6584 (x_handle_selection_clear,x_clear_frame_selections):
6585 Pass Qx_lost_selection_functions rather than
6586 Vx_lost_selection_functions to Frun_hook_with_args.
6588 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6590 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
6591 The old code sometimes used this field without initializing it.
6593 * alloc.c (gc_sweep): Don't read past end of array.
6594 In theory, the old code could also have corrupted Emacs internals,
6595 though it'd be very unlikely.
6597 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6599 * character.c (Fcharacterp): Don't advertise optional ignored
6600 argument. (Bug#4026)
6602 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6604 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6607 * window.c (Fset_window_start): Doc fix (bug#4199).
6608 (Fset_window_hscroll): Ditto.
6610 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6612 Fix minor new problems caught by GCC 4.6.1.
6613 * term.c (init_tty): Remove unused local.
6614 * xsettings.c (store_monospaced_changed): Define this function only
6615 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
6618 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
6620 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6622 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6624 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6625 are the mini-buffer and the echo area (bug#3320).
6627 * term.c (init_tty): Remove support for supdup, c10 and perq
6628 terminals, which are no longer supported (bug#1482).
6630 2011-07-10 Johan Bockgård <bojohan@gnu.org>
6632 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6634 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6636 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6637 for non-popups (Bug#3642).
6639 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6641 * alloc.c (reset_malloc_hooks): Protoize.
6642 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
6643 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6644 * cm.c (losecursor): Likewise.
6645 * data.c (fmod): Likewise.
6646 * dispnew.c (swap_glyphs_in_rows): Likewise.
6647 * emacs.c (memory_warning_signal): Likewise.
6648 * floatfns.c (float_error): Likewise.
6649 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6650 (otf_open, font_otf_capability, generate_otf_features)
6651 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6653 * image.c (pbm_read_file): Likewise.
6654 * indent.c (string_display_width): Likewise.
6655 * intervals.c (check_for_interval, search_for_interval)
6656 (inc_interval_count, count_intervals, root_interval)
6657 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6658 * lread.c (defalias): Likewise.
6659 * ralloc.c (r_alloc_check): Likewise.
6660 * regex.c (set_image_of_range_1, set_image_of_range)
6661 (regex_grow_registers): Likewise.
6662 * sysdep.c (strerror): Likewise.
6663 * termcap.c (valid_filename_p, tprint, main): Likewise.
6664 * tparam.c (main): Likewise.
6665 * unexhp9k800.c (run_time_remap, save_data_space)
6666 (update_file_ptrs, read_header, write_header, calculate_checksum)
6667 (copy_file, copy_rest, display_header): Likewise.
6668 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6670 * xdisp.c (check_it): Likewise.
6671 * xfaces.c (register_color, unregister_color, unregister_colors):
6673 * xfns.c (print_fontset_result): Likewise.
6674 * xrdb.c (member, fatal, main): Likewise.
6676 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6678 Fix minor problems found by static checking (Bug#9031).
6679 * chartab.c (char_table_set_range, map_sub_char_table):
6680 Remove unused locals.
6681 (uniprop_table): Now static.
6682 * composite.c (_work_char): Remove unused static var.
6684 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
6686 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6688 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6690 * gtkutil.c (qttip_cb): Remove code without function.
6692 2011-07-09 Eli Zaretskii <eliz@gnu.org>
6694 * w32.c (pthread_sigmask): New stub.
6696 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
6698 Use pthread_sigmask, not sigprocmask (Bug#9010).
6699 sigprocmask is portable only for single-threaded applications, and
6700 Emacs can be multi-threaded when it uses GTK.
6701 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6703 * callproc.c (Fcall_process):
6704 * process.c (create_process):
6705 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6706 Use pthread_sigmask, not sigprocmask.
6708 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6710 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6711 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6714 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6716 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6717 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6718 (xg_hide_tooltip): Fix comment.
6720 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6721 in registerServicesMenuSendTypes.
6722 (validRequestorForSendType): Don't check ns_return_types.
6724 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6727 2011-07-08 Jason Rumney <jasonr@gnu.org>
6729 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6730 SH_SHOW for hidden windows (Bug#5482).
6732 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6733 frame struct members of non-existent frames (Bug#6284).
6735 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6737 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6738 variable firstTime not needed on OSX >= 10.6.
6739 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6740 >= 10.5. Use setKnobProportion, setDoubleValue.
6742 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6743 (MAC_OS_X_VERSION_10_5): Define if not defined.
6744 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6745 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6746 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6748 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6749 cString and lossyCString on OSX >= 10.4
6751 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
6752 sizeToFit on OSX >= 10.2.
6754 * nsimage.m (allocInitFromFile): Don't use deprecated method
6755 bestRepresentationForDevice on OSX >= 10.6.
6757 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6760 * emacs.c: Declare unexec_init_emacs_zone.
6762 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6764 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6766 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6767 on svcsMenu (Bug#8842).
6769 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6771 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6773 * nsterm.m (QUTF8_STRING): Declare.
6774 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6775 (validRequestorForSendType): Return type is (id).
6776 Change indexOfObjectIdenticalTo to indexOfObject.
6777 Check if we have local selection before returning self (Bug#8842).
6778 (writeSelectionToPasteboard): Put local selection into paste board
6779 if we have a local selection (Bug#8842).
6780 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6782 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6783 (ns_get_local_selection): Declare.
6785 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6787 * keymap.c (describe_map_tree): Don't insert a double newline at
6788 the end of the buffer (bug#1169) and return whether we inserted
6791 * callint.c (Fcall_interactively): Change "reading args" to
6792 "providing args" to try to clarify what it does (bug#1010).
6794 2011-07-07 Kenichi Handa <handa@m17n.org>
6796 * composite.c (composition_compute_stop_pos): Ignore a static
6797 composition starting before CHARPOS (Bug#8915).
6799 * xdisp.c (handle_composition_prop): Likewise.
6801 2011-07-07 Eli Zaretskii <eliz@gnu.org>
6803 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6806 2011-07-07 Kenichi Handa <handa@m17n.org>
6808 * character.h (unicode_category_t): New enum type.
6810 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6811 (Qchar_code_property_table): New variable.
6812 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6813 (UNIPROP_COMPRESSED_FORM_P): New macros.
6814 (char_table_ascii): Uncompress the compressed values.
6815 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6816 Uncompress the compressed values.
6817 (sub_char_table_ref_and_range): Likewise.
6818 (char_table_ref_and_range): Uncompress the compressed values.
6819 (sub_char_table_set): New arg is_uniprop. Callers changed.
6820 Uncompress the compressed values.
6821 (sub_char_table_set_range): Args changed. Callers changed.
6822 (char_table_set_range): Adjuted for the above change.
6823 (map_sub_char_table): Delete args default_val and parent. Add arg
6824 top. Give decoded values to a Lisp function.
6825 (map_char_table): Adjust for the above change. Give decoded
6826 values to a Lisp function. Gcpro more variables.
6827 (uniprop_table_uncompress)
6828 (uniprop_decode_value_run_length): New functions.
6829 (uniprop_decoder, uniprop_decoder_count): New variables.
6830 (uniprop_get_decoder, uniprop_encode_value_character)
6831 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6833 (uniprop_encoder, uniprop_encoder_count): New variables.
6834 (uniprop_get_encoder, uniprop_table)
6835 (Funicode_property_table_internal, Fget_unicode_property_internal)
6836 (Fput_unicode_property_internal): New functions.
6837 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6838 Sunicode_property_table_internal, Sget_unicode_property_internal,
6839 and Sput_unicode_property_internal. Defvar_lisp
6840 char-code-property-alist.
6842 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
6843 Vunicode_category_table.
6845 * font.c (font_range): Adjust for the change of
6846 Vunicode_category_table.
6848 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6850 * m/iris4d.h: Remove file, move contents ...
6851 * s/irix6-5.h: ... here.
6853 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6855 Remove unportable assumption about struct layout (Bug#8884).
6856 * alloc.c (mark_buffer):
6857 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6858 (clone_per_buffer_values): Don't assume that
6859 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6860 This isn't true in general, and it's particularly not true
6861 if Emacs is configured with --with-wide-int.
6862 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6863 New macros, used in the buffer.c change.
6865 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6867 * xsettings.c: Use both GConf and GSettings if both are available.
6868 (store_config_changed_event): Add comment.
6869 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6870 (store_tool_bar_style_changed): New functions.
6871 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
6872 (struct xsettings): Move font inside HAVE_XFT.
6873 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
6874 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
6875 Move inside HAVE_XFT.
6876 (something_changed_gsettingsCB): Rename from something_changedCB.
6877 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6879 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
6880 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
6881 (something_changed_gconfCB): Rename from something_changedCB.
6882 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6883 (parse_settings): Move check for font inside HAVE_XFT.
6884 (read_settings, apply_xft_settings): Add comment.
6885 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6886 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6887 call store_font_name_changed.
6888 (xft_settings_event): Add comment.
6889 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6890 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6891 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6892 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6893 (xsettings_initialize): Call init_gsettings last.
6894 (xsettings_get_system_font, xsettings_get_system_normal_font):
6897 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6899 Random fixes. E.g., (random) never returned negative values.
6900 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6901 subseconds part to the entropy, as that's a bit more random.
6902 Prefer signed to unsigned, since the signedness doesn't matter and
6903 in general we prefer signed. When given a limit, use a
6904 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6905 latter isn't right if USE_2_TAGS_FOR_INTS.
6906 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6907 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6909 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6911 * textprop.c (text_property_stickiness):
6912 Obey Vtext_property_default_nonsticky.
6913 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6914 * w32fns.c (syms_of_w32fns):
6915 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6917 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6919 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6920 This is more efficient than Ffile_directory_p and avoids a minor race.
6922 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6924 * buffer.c (Foverlay_put): Say what the return value is
6927 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6928 is a directory before asking whether to use the file name
6930 (barf_or_query_if_file_exists): Make the "File is a directory"
6931 error be more correct.
6933 * fns.c (Frequire): Remove the mention of the .gz files, since
6934 that's installation-specific, but keep the mention of
6935 `get-load-suffixes'.
6937 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6939 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6940 Report string overflow if the output is too long.
6942 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
6944 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6945 (syms_of_gnutls): Remove duplicate DEFSYM for
6946 Qgnutls_bootprop_verify_hostname_error, an error for
6947 Qgnutls_bootprop_verify_error (which is no longer used).
6949 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6950 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6951 Also (re)move comments that are misplaced or no longer relevant.
6953 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6955 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6957 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
6959 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6960 and background color parameters if they have been changed.
6962 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6964 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6966 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6968 * xsettings.c (SYSTEM_FONT): Define only when used.
6969 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6971 * keymap.c (access_keymap_1): Now static.
6973 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
6975 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6976 leave any prefix arg for the up event (Bug#1586).
6978 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6980 * lread.c (syms_of_lread): Mention single symbols defined by
6981 `defvar' or `defconst' (bug#7154).
6983 * fns.c (Frequire): Mention .el.gz files (bug#7314).
6984 (Frequire): Mention get-load-suffixes.
6986 2011-07-02 Martin Rudalics <rudalics@gmx.at>
6988 * window.h (window): Remove clone_number slot.
6989 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6991 (make_parent_window, make_window, saved_window)
6992 (Fset_window_configuration, save_window_save): Don't deal with
6994 * buffer.c (Qclone_number): Remove declaration.
6995 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6997 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6999 Add multiple inheritance to keymaps.
7000 * keymap.c (Fmake_composed_keymap): New function.
7001 (Fset_keymap_parent): Simplify.
7002 (fix_submap_inheritance): Remove.
7003 (access_keymap_1): New function extracted from access_keymap to handle
7004 embedded parents and handle lists of maps.
7005 (access_keymap): Use it.
7006 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7007 (Fcopy_keymap): Handle embedded parents.
7008 (Fcommand_remapping, define_as_prefix): Simplify.
7009 (Fkey_binding): Simplify.
7010 (syms_of_keymap): Move minibuffer-local-completion-map,
7011 minibuffer-local-filename-completion-map,
7012 minibuffer-local-must-match-map, and
7013 minibuffer-local-filename-must-match-map to Elisp.
7014 (syms_of_keymap): Defsubr make-composed-keymap.
7015 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7016 (parse_menu_item): Trivial simplification.
7018 2011-07-01 Glenn Morris <rgm@gnu.org>
7020 * Makefile.in (SETTINGS_LIBS): Fix typo.
7022 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7024 * coding.c (Fencode_coding_string): Record the last coding system
7025 used, as the function doc string says (bug#8738).
7027 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7029 * xsettings.c (store_monospaced_changed): Take new font as arg and
7030 check for change against current_mono_font.
7031 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7032 (emacs_settings_constructor, emacs_settings_get_property)
7033 (emacs_settings_set_property, emacs_settings_class_init)
7034 (emacs_settings_init, gsettings_obj): Remove.
7035 (something_changedCB): New function for HAVE_GSETTINGS.
7036 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7037 with value as argument.
7038 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7039 g_settings_new (Bug#8967). Do not create gsettings_obj.
7040 Remove calls to g_settings_bind. Connect something_changedCB to
7043 * xgselect.c: Add defined (HAVE_GSETTINGS).
7044 (xgselect_initialize): Ditto.
7046 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7047 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7050 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7052 * eval.c (struct backtrace): Simplify and port the data structure.
7053 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7054 signed bit field, as this assumption is not portable and it makes
7055 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7056 "char debug_on_exit : 1" as this is not portable either; instead,
7057 use the portable "unsigned int debug_on_exit : 1". Remove unused
7058 member evalargs. Remove obsolete comments about cc bombing out.
7060 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7062 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
7063 Let HAVE_GSETTINGS override HAVE_GCONF.
7064 (store_monospaced_changed): New function.
7065 (EMACS_SETTINGS): A new type derived from GObject to handle
7066 GSettings notifications.
7067 (emacs_settings_constructor, emacs_settings_get_property)
7068 (emacs_settings_set_property, emacs_settings_class_init):
7070 (gsettings_client, gsettings_obj): New variables.
7071 (GSETTINGS_SCHEMA): New define.
7072 (something_changedCB): Call store_monospaced_changed.
7073 (init_gsettings): New function.
7074 (xsettings_initialize): Call init_gsettings.
7075 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7078 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
7081 2011-06-29 Martin Rudalics <rudalics@gmx.at>
7083 * window.c (resize_root_window, grow_mini_window)
7084 (shrink_mini_window): Rename Qresize_root_window to
7085 Qwindow_resize_root_window and Qresize_root_window_vertically to
7086 Qwindow_resize_root_window_vertically.
7088 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7090 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7092 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
7094 * makefile.w32-in: Redesign dependencies so they reflect more
7095 clearly which files are directly included by each source file,
7096 and not through other includes.
7098 2011-06-27 Martin Rudalics <rudalics@gmx.at>
7100 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7101 (sort_overlays, overlay_strings): When an overlay's clone number
7102 matches the window's clone number process the overlay even if
7103 the overlay's window property doesn't match the current window.
7105 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7106 (Fwindow_hchild): Rename to Fwindow_left_child.
7107 (Fwindow_next): Rename to Fwindow_next_sibling.
7108 (Fwindow_prev): Rename to Fwindow_prev_sibling.
7109 (resize_window_check): Rename to window_resize_check.
7110 (resize_window_apply): Rename to window_resize_apply.
7111 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7112 (Fdelete_other_windows_internal, resize_frame_windows)
7113 (Fsplit_window_internal, Fdelete_window_internal)
7114 (grow_mini_window, shrink_mini_window)
7115 (Fresize_mini_window_internal): Fix callers accordingly.
7117 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7119 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7120 (emacs_fixed_set_min_size): Remove.
7121 (emacs_fixed_new): Take frame as argument.
7123 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7124 (_EmacsFixedPrivate): Remove minwidth/height.
7125 Add struct frame *f.
7126 (emacs_fixed_init): Initialize priv->f.
7127 (get_parent_class, emacs_fixed_set_min_size): Remove.
7128 (emacs_fixed_new): Set priv->f to argument.
7129 (emacs_fixed_get_preferred_width)
7130 (emacs_fixed_get_preferred_height): Use min_width/height from
7131 frames size_hint to set minimum and natural (Bug#8919).
7132 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7133 and use min_width/height from frames size_hint to set
7134 min_width/height (Bug#8919).
7136 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
7137 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7140 2011-06-26 Eli Zaretskii <eliz@gnu.org>
7142 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7143 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7146 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
7148 * process.c (wait_reading_process_output): Bypass select if
7149 waiting for a cell while ignoring keyboard input, and input is
7150 pending. Suggested by Jan Djärv (Bug#8869).
7152 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7154 Use gnulib's dup2 module instead of rolling our own.
7155 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7157 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7159 * dispnew.c (scrolling_window): Before scrolling, turn off a
7160 mouse-highlight in the window being scrolled.
7162 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
7164 Move DEFSYM to lisp.h and use everywhere.
7166 * character.h (DEFSYM): Move declaration...
7167 * lisp.h (DEFSYM): ...here.
7173 * w32select.c: Don't include character.h.
7175 * alloc.c (syms_of_alloc):
7176 * buffer.c (syms_of_buffer):
7177 * bytecode.c (syms_of_bytecode):
7178 * callint.c (syms_of_callint):
7179 * casefiddle.c (syms_of_casefiddle):
7180 * casetab.c (init_casetab_once):
7181 * category.c (init_category_once, syms_of_category):
7182 * ccl.c (syms_of_ccl):
7183 * cmds.c (syms_of_cmds):
7184 * composite.c (syms_of_composite):
7185 * dbusbind.c (syms_of_dbusbind):
7186 * dired.c (syms_of_dired):
7187 * dispnew.c (syms_of_display):
7188 * doc.c (syms_of_doc):
7189 * editfns.c (syms_of_editfns):
7190 * emacs.c (syms_of_emacs):
7191 * eval.c (syms_of_eval):
7192 * fileio.c (syms_of_fileio):
7193 * fns.c (syms_of_fns):
7194 * frame.c (syms_of_frame):
7195 * fringe.c (syms_of_fringe):
7196 * insdel.c (syms_of_insdel):
7197 * keymap.c (syms_of_keymap):
7198 * lread.c (init_obarray, syms_of_lread):
7199 * macros.c (syms_of_macros):
7200 * msdos.c (syms_of_msdos):
7201 * print.c (syms_of_print):
7202 * process.c (syms_of_process):
7203 * search.c (syms_of_search):
7204 * sound.c (syms_of_sound):
7205 * syntax.c (init_syntax_once, syms_of_syntax):
7206 * terminal.c (syms_of_terminal):
7207 * textprop.c (syms_of_textprop):
7208 * undo.c (syms_of_undo):
7209 * w32.c (globals_of_w32):
7210 * window.c (syms_of_window):
7211 * xdisp.c (syms_of_xdisp):
7212 * xfaces.c (syms_of_xfaces):
7213 * xfns.c (syms_of_xfns):
7214 * xmenu.c (syms_of_xmenu):
7215 * xsettings.c (syms_of_xsettings):
7216 * xterm.c (syms_of_xterm): Use DEFSYM.
7218 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7220 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
7222 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7224 Integer and buffer overflow fixes (Bug#8873).
7226 * print.c (printchar, strout): Check for string overflow.
7227 (PRINTPREPARE, printchar, strout):
7228 Don't set size unless allocation succeeds.
7230 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7231 for sizes. Check for string overflow more accurately.
7232 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7234 * macros.c: Integer and buffer overflow fixes.
7235 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7236 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7237 Use ptrdiff_t, not int, for sizes.
7238 Don't increment bufsize until after realloc succeeds.
7239 Check for size-calculation overflow.
7240 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7242 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7244 * lread.c: Integer overflow fixes.
7245 (read_integer): Radix is now EMACS_INT, not int,
7246 to improve quality of diagnostics for out-of-range radices.
7247 Calculate buffer size correctly for out-of-range radices.
7248 (read1): Check for integer overflow in radices, and in
7249 read-circle numbers.
7250 (read_escape): Avoid int overflow.
7251 (Fload, openp, read_buffer_size, read1)
7252 (substitute_object_recurse, read_vector, read_list, map_obarray):
7253 Use ptrdiff_t, not int, for sizes.
7254 (read1): Use EMACS_INT, not int, for sizes.
7255 Check for size overflow.
7257 * image.c (cache_image): Check for size arithmetic overflow.
7259 * lread.c: Integer overflow issues.
7260 (saved_doc_string_size, saved_doc_string_length)
7261 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7262 Now ptrdiff_t, not int.
7263 (read1): Don't assume doc string length fits in int. Check for
7264 out-of-range doc string lengths.
7265 (read_list): Don't assume file position fits in int.
7266 (read_escape): Check for hex character overflow.
7268 2011-06-22 Leo Liu <sdl.web@gmail.com>
7270 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7271 Move to minibuffer.el.
7273 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7275 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
7276 The following patches are for when GLYPH_DEBUG && !XASSERT.
7277 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7278 * dispnew.c (flush_stdout):
7279 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7280 Mark as externally visible.
7281 * dispnew.c (check_window_matrix_pointers): Now static.
7282 * dispnew.c (window_to_frame_vpos):
7283 * xfns.c (unwind_create_frame):
7284 * xterm.c (x_check_font): Remove unused local.
7285 * scroll.c (CHECK_BOUNDS):
7286 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7287 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7288 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7289 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7290 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7292 (debug_method_add): Use va_list and vsprintf rather than relying
7293 on undefined behavior with wrong number of arguments.
7294 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7295 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7296 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7297 since we're not interested in debugging glyphs with old libraries.
7298 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7299 GCC 4.6.0's static checking.
7301 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7303 Integer overflow and signedness fixes (Bug#8873).
7304 A few related buffer overrun fixes, too.
7306 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7308 * dispextern.h (struct face.stipple):
7309 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7310 (x_bitmap_mask, x_allocate_bitmap_record)
7311 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7312 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7313 (x_create_bitmap_from_xpm_data):
7314 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7315 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7317 * xfaces.c (load_pixmap):
7318 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7319 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7320 (.bitmaps_last, struct x_output.icon_bitmap):
7321 Use ptrdiff_t, not int, for bitmap indexes.
7322 (x_allocate_bitmap_record): Check for size overflow.
7323 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7325 Use ptrdiff_t, not int, for overlay counts.
7326 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7327 * editfns.c (overlays_around, get_pos_property):
7328 * textprop.c (get_char_property_and_overlay):
7329 * xdisp.c (next_overlay_change, note_mouse_highlight):
7330 * xfaces.c (face_at_buffer_position):
7331 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7332 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7333 (Fnext_overlay_change, Fprevious_overlay_change)
7334 (mouse_face_overlay_overlaps, Foverlays_in):
7335 Use ptrdiff_t, not int, for sizes.
7336 (overlays_at, overlays_in): Check for size-calculation overflow.
7338 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7340 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7341 (x_session_initialize): Do not assume string length fits in int.
7343 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7344 This is unlikely, but can occur if DPI is outlandish.
7346 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
7347 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7349 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7350 * xrdb.c (magic_file_p, search_magic_path):
7351 Omit last arg SUFFIX; it was always 0. All callers changed.
7352 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7354 * xfont.c (xfont_match): Avoid need for strlen.
7356 * xfns.c: Don't assume strlen fits in int.
7357 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7359 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7360 not unsigned long, as we prefer signed integers. All callers changed.
7361 Detect integer overflow in repeat count.
7362 (message_dolog): Don't assume print length fits in 39 bytes.
7363 (display_mode_element): Don't assume strlen fits in int.
7365 * termcap.c: Don't assume sizes fit in int and never overflow.
7366 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7367 (gobble_line): Check for size-calculation overflow.
7369 * minibuf.c (Fread_buffer):
7370 * lread.c (intern, intern_c_string):
7371 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7372 Don't assume string length fits in int.
7374 * keyboard.c (parse_tool_bar_item):
7375 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7377 * font.c: Don't assume string length fits in int.
7378 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7379 Use ptrdiff_t, not int.
7380 (font_intern_prop): Don't assume string length fits in int.
7381 Don't assume integer property fits in fixnum.
7382 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
7384 * filelock.c: Fix some buffer overrun and integer overflow issues.
7385 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
7386 Reformulate so as not to need the command string.
7387 Invoke gzip -cd rather than gunzip, as it's more portable.
7388 (lock_info_type, lock_file_1, lock_file):
7389 Don't assume pid_t and time_t fit in unsigned long.
7390 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7391 (current_lock_owner): Prefer signed type for sizes.
7392 Use memcpy, not strncpy, where memcpy is what is really wanted.
7393 Don't assume (via atoi) that time_t and pid_t fit in int.
7394 Check for time_t and/or pid_t out of range, e.g., via a network share.
7395 Don't alloca where an auto var works fine.
7397 * fileio.c: Fix some integer overflow issues.
7398 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7399 Don't assume string length fits in int.
7400 (directory_file_name): Don't assume string length fits in long.
7401 (make_temp_name): Don't assume pid fits in int, or that its print
7402 length is less than 20.
7404 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7406 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7408 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7410 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7411 We prefer signed integers, even for size calculations.
7413 * emacs.c: Don't assume string length fits in 'int'.
7414 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7415 (main): Don't invoke strlen when not needed.
7417 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7418 (XD_DEBUG_MESSAGE): Don't waste a byte.
7420 * callproc.c (getenv_internal_1, getenv_internal)
7422 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7424 * lread.c (invalid_syntax): Omit length argument.
7425 All uses changed. This doesn't fix a bug, but it simplifies the
7426 code away from its former Hollerith-constant appearance, and it's
7427 one less 'int' to worry about when looking at integer-overflow issues.
7428 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
7430 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7431 This didn't break anything, but it didn't help either.
7432 It's confusing to put a bogus integer in a place where the actual
7433 value does not matter.
7434 (LIST_END_P): Remove unused macro and its bogus comment.
7435 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
7437 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7438 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7440 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7441 We prefer signed types, and the value cannot exceed the EMACS_INT
7442 range anyway (because otherwise the length would not be representable).
7443 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7444 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7445 This avoids a GCC warning when WIDE_EMACS_INT.
7447 * indent.c (sane_tab_width): New function.
7448 (current_column, scan_for_column, Findent_to, position_indentation)
7449 (compute_motion): Use it. This is just for clarity.
7450 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
7452 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
7454 * lisp.h (lint_assume): New macro.
7455 * composite.c (composition_gstring_put_cache):
7456 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7458 * editfns.c, insdel.c:
7459 Omit unnecessary forward decls, to simplify future changes.
7461 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7463 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7465 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
7466 Use much-faster test for byte-length change.
7467 Don't assume string byte-length fits in 'int'.
7468 Check that character arg fits in 'int'.
7469 (mapcar1): Declare byte as byte, for clarity.
7471 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7473 * fns.c (concat): Catch string overflow earlier.
7474 Do not rely on integer wraparound.
7476 * dispextern.h (struct it.overlay_strings_charpos)
7477 (struct it.selective): Now EMACS_INT, not int.
7478 * xdisp.c (forward_to_next_line_start)
7479 (back_to_previous_visible_line_start)
7480 (reseat_at_next_visible_line_start, next_element_from_buffer):
7481 Don't arbitrarily truncate the value of 'selective' to int.
7483 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7485 * composite.c: Don't truncate sizes to 'int'.
7486 (composition_gstring_p, composition_reseat_it)
7487 (composition_adjust_point): Use EMACS_INT, not int.
7488 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7489 not EMACS_UINT, for indexes.
7491 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7493 * buffer.c: Include <verify.h>.
7494 (struct sortvec.priority, struct sortstr.priority):
7495 Now EMACS_INT, not int.
7496 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
7497 (struct sortstr.size, record_overlay_string)
7498 (struct sortstrlist.size, struct sortlist.used):
7499 Don't truncate size to int.
7500 (record_overlay_string): Check for size-calculation overflow.
7501 (init_buffer_once): Check at compile-time, not run-time.
7503 2011-06-22 Jim Meyering <meyering@redhat.com>
7505 Don't leak an XBM-image-sized buffer
7506 * image.c (xbm_load): Free the image buffer after using it.
7508 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7511 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7512 that Sun C diagnosed.
7513 * fns.c (secure_hash): Fix pointer signedness issue.
7514 * intervals.c (static_offset_intervals): New function.
7515 (offset_intervals): Use it.
7517 2011-06-21 Leo Liu <sdl.web@gmail.com>
7520 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7523 * fns.c (secure_hash): Rename from crypto_hash_function and change
7524 the first arg to accept symbols.
7525 (Fsecure_hash): New primitive.
7526 (syms_of_fns): New symbols.
7528 2011-06-20 Deniz Dogan <deniz@dogan.se>
7530 * process.c (Fset_process_buffer): Clarify return value in
7533 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
7535 * dispnew.c (add_window_display_history): Use BVAR.
7537 * xdisp.c (debug_method_add): Use BVAR.
7538 (check_window_end, dump_glyph_matrix, dump_glyph)
7539 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7541 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7544 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7545 check till after the cache is created in init_frame_faces.
7547 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7549 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7551 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7553 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7554 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7555 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7557 Improve buffer-overflow checking (Bug#8873).
7558 * fileio.c (Finsert_file_contents):
7559 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7560 Remove the old (too-loose) buffer overflow checks.
7561 They weren't needed, since make_gap checks for buffer overflow.
7562 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7563 The old code merely checked for Emacs fixnum overflow, and relied
7564 on undefined (wraparound) behavior. The new code avoids undefined
7565 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7567 * editfns.c (Finsert_char): Don't dump core with very negative counts.
7568 Tune. Don't use wider integers than needed. Don't use alloca.
7569 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
7571 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7573 * insdel.c, lisp.h (buffer_overflow): New function.
7574 (insert_from_buffer_1, replace_range, replace_range_2):
7575 * insdel.c (make_gap_larger):
7576 * editfns.c (Finsert_char):
7577 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7579 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7581 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7583 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
7585 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7586 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7588 * fileio.c: Don't assume EMACS_INT fits in off_t.
7589 (emacs_lseek): New static function.
7590 (Finsert_file_contents, Fwrite_region): Use it.
7591 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7593 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7595 * fns.c: Don't overflow int when computing a list length.
7596 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7597 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7598 truncation on 64-bit hosts. Check for QUIT every
7599 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7600 faster and is responsive enough.
7601 (Flength): Report an error instead of overflowing an integer.
7602 (Fsafe_length): Return a float if the value is not representable
7603 as a fixnum. This shouldn't happen except in contrived situations.
7604 (Fnthcdr, Fsort): Don't assume list length fits in int.
7605 (Fcopy_sequence): Don't assume vector length fits in int.
7607 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7608 (header_size, word_size): New constants.
7609 (allocate_vectorlike): Don't check size overflow here.
7610 (allocate_vector): Check it here instead, since this is the only
7611 caller of allocate_vectorlike that could cause overflow.
7612 Check that the new vector's length is representable as a fixnum.
7614 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7615 The previous code was bogus. For example, next_almost_prime (32)
7616 returned 39, which is undesirable as it is a multiple of 3; and
7617 next_almost_prime (24) returned 25, which is a multiple of 5 so
7618 why was the code bothering to check for multiples of 7?
7620 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7622 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7624 Variadic C functions now count arguments with ptrdiff_t.
7625 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7626 Back then I didn't know that the Emacs coding style prefers signed int.
7627 Also, in the meantime I found a few more instances where arguments
7628 were being counted with int, which may truncate counts on 64-bit
7629 machines, or EMACS_INT, which may be unnecessarily wide.
7630 * lisp.h (struct Lisp_Subr.function.aMANY)
7631 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7632 Arg counts are now ptrdiff_t, not size_t.
7633 All variadic functions and their callers changed accordingly.
7634 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7635 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7636 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7637 * callint.c (Fcall_interactively): Check arg count for overflow,
7638 to avoid potential buffer overrun. Use signed char, not 'int',
7639 for 'varies' array, so that we needn't bother to check its size
7640 calculation for overflow.
7641 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7642 * eval.c (apply_lambda):
7643 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7644 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7645 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7647 * callint.c (Fcall_interactively): Don't use index var as event count.
7649 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7650 * mem-limits.h (SIZE): Remove; no longer used.
7652 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
7654 Remove unnecessary casts.
7655 * xterm.c (x_term_init):
7656 * xfns.c (x_set_border_pixel):
7657 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7658 These aren't needed now that we assume ANSI C.
7660 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7661 It's more likely to cause problems (due to unsigned overflow)
7664 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7666 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7668 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7670 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7672 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7674 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7676 GLYPH_CODE_FACE returns EMACS_INT, not int.
7677 * dispextern.h (merge_faces):
7678 * xfaces.c (merge_faces):
7679 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7680 Don't assume EMACS_INT fits in int.
7682 * character.h (CHAR_VALID_P): Remove unused parameter.
7683 * fontset.c, lisp.h, xdisp.c: All uses changed.
7685 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7687 * fns.c (concat): Minor tuning based on overflow analysis.
7688 This doesn't fix any bugs. Use int to hold character, instead
7689 of constantly refetching from Emacs object. Use XFASTINT, not
7690 XINT, for value known to be a character. Don't bother comparing
7691 a single byte to 0400, as it's always less.
7693 * floatfns.c (Fexpt):
7694 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7696 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7699 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7701 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7702 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7703 incorrectly succeed when S was a string, because 4294967386 was
7704 truncated before it was used.
7706 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7707 Otherwise, an out-of-range integer could cause undefined behavior
7710 * composite.c: Use int, not EMACS_INT, for characters.
7711 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7712 EMACS_INT, for values that are known to be in character range.
7713 This doesn't fix any bugs but is the usual style inside Emacs and
7714 may generate better code on 32-bit machines.
7716 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7717 This is for reasons similar to the recent CHAR_STRING fix.
7718 * charset.c (Fencode_char): Check that character arg is actually
7719 a character. Pass an int to ENCODE_CHAR.
7720 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7721 wider than 'int', as a compile-time check to prevent future regressions
7724 * character.c (char_string): Remove unnecessary casts.
7726 Make sure a 64-bit char is never passed to CHAR_STRING.
7727 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7728 by silently ignoring the top 32 bits, allowing some values
7729 that were far too large to be valid characters.
7730 * character.h: Include <verify.h>.
7731 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7732 arguments are no wider than unsigned, as a compile-time check
7733 to prevent future regressions in this area.
7735 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
7736 (Fsubst_char_in_region):
7738 * xdisp.c (decode_mode_spec_coding):
7739 Adjust to CHAR_STRING's new requirement.
7740 * editfns.c (Finsert_char, Fsubst_char_in_region):
7741 * fns.c (concat): Check that character args are actually
7742 characters. Without this test, these functions did the wrong
7743 thing with wildly out-of-range values on 64-bit hosts.
7745 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7746 These casts should not be needed on 32-bit hosts, either.
7747 * keyboard.c (read_char):
7748 * lread.c (Fload): Remove casts to unsigned.
7750 * lisp.h (UNSIGNED_CMP): New macro.
7751 This fixes comparison bugs on 64-bit hosts.
7752 (ASCII_CHAR_P): Use it.
7753 * casefiddle.c (casify_object):
7754 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
7755 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7756 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7757 * dispextern.h (FACE_FROM_ID):
7758 * keyboard.c (read_char): Use UNSIGNED_CMP.
7760 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7761 not to EMACS_INT, to avoid GCC warning.
7763 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7765 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7766 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7767 isn't needed on 32-bit machines.
7769 * buffer.c (Fgenerate_new_buffer_name):
7770 Use EMACS_INT for count, not int.
7771 (advance_to_char_boundary): Return EMACS_INT, not int.
7773 * data.c (Qcompiled_function): Now static.
7775 * window.c (window_body_lines): Now static.
7777 * image.c (gif_load): Rename local to avoid shadowing.
7779 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7780 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7781 * alloc.c (make_save_value): Integer argument is now of type
7783 (mark_object): Use ptrdiff_t, not int.
7784 * lisp.h (pD): New macro.
7785 * print.c (print_object): Use it.
7787 * alloc.c: Use EMACS_INT, not int, to count objects.
7788 (total_conses, total_markers, total_symbols, total_vector_size)
7789 (total_free_conses, total_free_markers, total_free_symbols)
7790 (total_free_floats, total_floats, total_free_intervals)
7791 (total_intervals, total_strings, total_free_strings):
7792 Now EMACS_INT, not int. All uses changed.
7793 (Fgarbage_collect): Compute overall total using a double, so that
7794 integer overflow is less likely to be a problem. Check for overflow
7795 when converting back to an integer.
7796 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7797 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7798 These were 'int' variables that could overflow on 64-bit hosts;
7799 they were never used, so remove them instead of repairing them.
7800 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
7801 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7802 Previously, this ceilinged at INT_MAX, but that doesn't work on
7804 (allocate_pseudovector): Don't use EMACS_INT when int would do.
7806 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
7807 (allocate_vectorlike): Check for ptrdiff_t overflow.
7808 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7809 when a (possibly-narrower) signed value would do just as well.
7810 We prefer using signed arithmetic, to avoid comparison confusion.
7812 * alloc.c: Catch some string size overflows that we were missing.
7813 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7814 for convenience in STRING_BYTES_MAX.
7815 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7816 The definition here is exact; the one in lisp.h was approximate.
7817 (allocate_string_data): Check for string overflow. This catches
7818 some instances we weren't catching before. Also, it catches
7819 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7820 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7821 and ptrdiff_t and EMACS_INT are both 64 bits.
7823 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7824 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
7825 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
7827 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7829 * alloc.c (Fmake_string): Check for out-of-range init.
7831 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7833 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7835 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7837 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7838 xg_get_default_scrollbar_width.
7840 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7841 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7842 (style_changed_cb): Call update_theme_scrollbar_width and call
7843 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7844 all frames (Bug#8505).
7845 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7846 Call gtk_window_set_resizable if HAVE_GTK3.
7847 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7848 and height if HAVE_GTK3 (Bug#8505).
7849 (scroll_bar_width_for_theme): New variable.
7850 (update_theme_scrollbar_width): New function.
7851 (xg_get_default_scrollbar_width): Move code to
7852 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7853 (xg_initialize): Call update_theme_scrollbar_width.
7855 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7857 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7859 2011-06-12 Martin Rudalics <rudalics@gmx.at>
7861 * frame.c (make_frame): Call other_buffer_safely instead of
7864 * window.c (temp_output_buffer_show): Call display_buffer with
7865 second argument Vtemp_buffer_show_specifiers and reset latter
7866 immediately after the call.
7867 (Vtemp_buffer_show_specifiers): New variable.
7868 (auto_window_vscroll_p, next_screen_context_lines)
7869 (Vscroll_preserve_screen_position): Remove leading asterisks from
7872 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
7874 Fix minor problems found by GCC 4.6.0 static checking.
7875 * buffer.c (Qclone_number): Remove for now, as it's unused.
7876 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7877 (record_buffer): Remove unused local.
7878 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7879 (set_frame_buffer_list): Remove; unused.
7880 * frame.h (other_visible_frames): Remove decl.
7881 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7882 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7883 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7885 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7886 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7887 Define only if HAVE_GPM.
7888 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7889 (update_hints_inhibit): Remove; never set. All uses removed.
7890 * widgetprv.h (emacsFrameClassRec): Remove decl.
7891 * window.c (delete_deletable_window): Now returns void, since it
7892 wasn't returning anything.
7893 (compare_window_configurations): Remove unused locals.
7894 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7895 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
7896 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7897 the same widths as pointers. This follows up on the 2011-05-06 patch.
7898 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7899 * xterm.h: Likewise.
7900 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7902 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
7904 * makefile.w32-in: Update dependencies.
7905 (LISP_H): Add lib/intprops.h.
7907 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7909 * image.c (gif_load): Add animation frame delay to the metadata.
7910 (syms_of_image): Use DEFSYM. New symbol `delay'.
7912 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7914 * window.c (delete_deletable_window): Re-add.
7915 (Fset_window_configuration): Rewrite to handle dead buffers and
7916 consequently deletable windows.
7917 (window_tree, Fwindow_tree): Remove. Supply functionality in
7919 (compare_window_configurations): Simplify code.
7921 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7923 * image.c (imagemagick_load_image): Fix type mismatch.
7924 (Fimagemagick_types): Likewise.
7926 * window.h (replace_buffer_in_windows): Declare.
7928 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7930 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7931 Qclone_number. Remove external declaration of Qdelete_window.
7932 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7934 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7935 Run Qbuffer_list_update_hook if allowed.
7936 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7937 buffer list implementation.
7938 (other_buffer_safely): New function.
7939 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7940 calls to replace_buffer_in_windows and
7941 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7943 (record_buffer): Inhibit quitting and rewrite using quittable
7944 functions. Run Qbuffer_list_update_hook if allowed.
7945 (Frecord_buffer, Funrecord_buffer): New functions.
7946 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7947 Move switch-to-buffer to window.el.
7948 (bury-buffer): Move to window.el.
7949 (Vbuffer_list_update_hook): New variable.
7951 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7954 * window.h (resize_frame_windows): Move up in code.
7955 (Fwindow_frame): Remove EXFUN.
7956 (replace_buffer_in_all_windows): Remove prototype.
7957 (replace_buffer_in_windows_safely): Add prototype.
7959 * window.c: Declare Qdelete_window static again. Move down
7960 declaration of select_count.
7961 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7962 (Fother_window): Move to window.el.
7963 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7964 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7965 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7967 (replace_buffer_in_windows): Implement by calling
7968 Qreplace_buffer_in_windows.
7969 (replace_buffer_in_all_windows): Remove with some functionality
7970 moved into replace_buffer_in_windows_safely.
7971 (replace_buffer_in_windows_safely): New function.
7972 (select_window_norecord, select_frame_norecord): Move in front
7973 of run_window_configuration_change_hook. Remove now obsolete
7975 (Fset_window_buffer): Rewrite doc-string.
7976 Call Qrecord_window_buffer.
7977 (keys_of_window): Move binding for other-window to window.el.
7979 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7981 * dispextern.h (struct image): Replace data member, whose int_val
7982 and ptr_val fields were not used by anything, with a single
7985 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7986 (gif_clear_image, gif_load, imagemagick_load_image)
7987 (gs_clear_image, gs_load): Callers changed.
7989 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7991 * buffer.h: Include <time.h>, for time_t.
7992 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7994 Fix minor problems found by static checking.
7996 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7998 Make identifiers static if they are not used in other modules.
7999 * data.c (Qcompiled_function, Qframe, Qvector):
8000 * image.c (QimageMagick, Qsvg):
8001 * minibuf.c (Qmetadata):
8002 * window.c (resize_window_check, resize_root_window): Now static.
8003 * window.h (resize_window_check, resize_root_window): Remove decls.
8005 * window.c (window_deletion_count, delete_deletable_window):
8007 (window_body_lines): Now static.
8008 (Fdelete_other_windows_internal): Mark vars as initialized.
8009 Make sure 'resize_failed' is initialized.
8010 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8011 (resize_window_apply): Remove unused local.
8012 * window.h (delete_deletable_window): Remove decl.
8014 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
8015 (imagemagick_load_image): Fix pointer signedness problem by changing
8016 last arg from unsigned char * to char *. All uses changed.
8017 Also, fix a local for similar reasons.
8018 Remove unused locals. Remove locals to avoid shadowing.
8019 (fn_rsvg_handle_free): Remove; unused.
8020 (svg_load, svg_load_image): Fix pointer signedness problem.
8021 (imagemagick_load_image): Don't use garbage pointer image_wand.
8023 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8025 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
8027 * image.c (gif_load): Fix omitted cast error introduced by
8030 2011-06-10 Martin Rudalics <rudalics@gmx.at>
8032 * window.h (resize_proportionally, orig_total_lines)
8033 (orig_top_line): Remove from window structure.
8034 (set_window_height, set_window_width, change_window_heights)
8035 (Fdelete_window): Remove prototypes.
8036 (resize_frame_windows): Remove duplicate declaration.
8038 2011-06-10 Eli Zaretskii <eliz@gnu.org>
8040 * window.h (resize_frame_windows, resize_window_check)
8041 (delete_deletable_window, resize_root_window)
8042 (resize_frame_windows): Declare prototypes.
8044 * window.c (resize_window_apply): Make definition be "static" to
8045 match the prototype.
8047 2011-06-10 Martin Rudalics <rudalics@gmx.at>
8049 * window.c: Remove declarations of Qwindow_size_fixed,
8050 window_min_size_1, window_min_size_2, window_min_size,
8051 size_window, window_fixed_size_p, enlarge_window, delete_window.
8052 Remove static from declaration of Qdelete_window, it's
8053 temporarily needed by Fbury_buffer.
8054 (replace_window): Don't assign orig_top_line and
8056 (Fdelete_window, delete_window): Remove. Window deletion is
8057 handled by window.el.
8058 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8059 Replace Fdelete_window calls with calls to Qdelete_window.
8060 (Fdelete_other_windows): Remove. Deleting other windows is
8061 handled by window.el.
8062 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8063 handled in window.el.
8064 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8065 Window minimum sizes are handled in window.el.
8066 (shrink_windows, size_window, set_window_height)
8067 (set_window_width, change_window_heights, window_height)
8068 (window_width, CURBEG, CURSIZE, enlarge_window)
8069 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8070 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8071 handled in window.el.
8072 (make_dummy_parent): Rename to make_parent_window and give it a
8073 second argument horflag.
8074 (make_window): Don't set resize_proportionally any more.
8075 (Fsplit_window): Remove. Windows are split in window.el.
8076 (save_restore_action, save_restore_orig_size)
8077 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8078 Resize mini windows in window.el.
8079 (grow_mini_window, shrink_mini_window): Implement by calling
8080 Qresize_root_window_vertically, resize_window_check and
8081 resize_window_apply.
8082 (saved_window, Fset_window_configuration, save_window_save):
8083 Do not handle orig_top_line, orig_total_lines, and
8084 resize_proportionally.
8085 (window_min_height, window_min_width): Move to window.el.
8086 (keys_of_window): Move bindings for delete-other-windows,
8087 split-window, delete-window and enlarge-window to window.el.
8089 * buffer.c: Temporarily extern Qdelete_window.
8090 (Fbury_buffer): Temporarily call Qdelete_window instead of
8091 Fdelete_window (Fbury_buffer will move to window.el soon).
8093 * frame.c (set_menu_bar_lines_1): Remove code handling
8094 orig_top_line and orig_total_lines.
8096 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8097 set_window_height but set heights directly.
8098 (change_frame_size_1): Use resize_frame_windows.
8100 * xdisp.c (init_xdisp): Don't use set_window_height but set
8103 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8104 Use resize_frame_windows instead of change_window_heights and run
8105 run_window_configuration_change_hook.
8107 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8108 instead of change_window_heights and run
8109 run_window_configuration_change_hook.
8111 2011-06-09 Martin Rudalics <rudalics@gmx.at>
8113 * window.c (replace_window): Rename second argument REPLACEMENT to
8114 NEW. New third argument SETFLAG. Rewrite.
8115 (delete_window, make_dummy_parent): Call replace_window with
8117 (window_list_1): Move down in code.
8118 (run_window_configuration_change_hook): Move set_buffer part
8119 before select_frame_norecord part in order to unwind correctly.
8120 Rename count1 to count.
8121 (recombine_windows, delete_deletable_window, resize_root_window)
8122 (Fdelete_other_windows_internal)
8123 (Frun_window_configuration_change_hook, make_parent_window)
8124 (resize_window_check, resize_window_apply, Fresize_window_apply)
8125 (resize_frame_windows, Fsplit_window_internal)
8126 (Fdelete_window_internal, Fresize_mini_window_internal):
8128 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8130 2011-06-08 Martin Rudalics <rudalics@gmx.at>
8132 * window.h (window): Add some new members to window structure -
8133 normal_lines, normal_cols, new_total, new_normal, clone_number,
8134 splits, nest, prev_buffers, next_buffers.
8135 (WINDOW_TOTAL_SIZE): Move here from window.c.
8136 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
8138 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8140 (make_dummy_parent): Set new members of windows structure.
8141 (make_window): Move down in code. Handle new members of window
8143 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8144 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8145 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8146 (Fset_window_prev_buffers, Fwindow_next_buffers)
8147 (Fset_window_next_buffers, Fset_window_clone_number):
8149 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8150 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8152 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8153 Argument WINDOW can be now internal window too.
8154 (Fwindow_use_time): Move up in code.
8155 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8157 (Fset_window_configuration, saved_window)
8158 (Fcurrent_window_configuration, save_window_save): Handle new
8159 members of window structure.
8160 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8161 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8162 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8163 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8164 Qget_mru_window, Qresize_root_window,
8165 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8166 Qauto_buffer_name; staticpro them.
8168 2011-06-07 Martin Rudalics <rudalics@gmx.at>
8170 * window.c (Fwindow_total_size, Fwindow_left_column)
8171 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8172 (Fwindow_list_1): New functions.
8173 (window_box_text_cols): Replace with window_body_cols.
8174 (Fwindow_width, Fscroll_left, Fscroll_right):
8175 Use window_body_cols instead of window_box_text_cols.
8176 (delete_window, Fset_window_configuration):
8177 Call delete_all_subwindows with window as argument.
8178 (delete_all_subwindows): Take a window as argument and not a
8180 (window_loop): Remove handling of GET_LRU_WINDOW and
8182 (Fget_lru_window, Fget_largest_window): Move to window.el.
8184 * window.h: Extern window_body_cols instead of
8185 window_box_text_cols. delete_all_subwindows now takes a
8186 Lisp_Object as argument.
8188 * indent.c (compute_motion, Fcompute_motion):
8189 Use window_body_cols instead of window_box_text_cols.
8191 * frame.c (delete_frame): Call delete_all_subwindows with root
8194 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8196 * fns.c (Fputhash): Document return value.
8198 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
8200 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8202 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8204 Cons<->int and similar integer overflow fixes (Bug#8794).
8206 Check for overflow when converting integer to cons and back.
8207 * charset.c (Fdefine_charset_internal, Fdecode_char):
8208 Use cons_to_unsigned to catch overflow.
8209 (Fencode_char): Use INTEGER_TO_CONS.
8210 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8211 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8212 * data.c (long_to_cons, cons_to_long): Remove.
8213 (cons_to_unsigned, cons_to_signed): New functions.
8214 These signal an error for invalid or out-of-range values.
8215 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8216 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8217 * font.c (Ffont_variation_glyphs):
8218 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8219 * lisp.h: Include <intprops.h>.
8220 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8221 (cons_to_signed, cons_to_unsigned): New decls.
8222 (long_to_cons, cons_to_long): Remove decls.
8223 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8224 (Fprimitive_undo): Use CONS_TO_INTEGER.
8225 * xfns.c (Fx_window_property): Likewise.
8226 * xselect.c: Include <limits.h>.
8227 (x_own_selection, selection_data_to_lisp_data):
8228 Use INTEGER_TO_CONS.
8229 (x_handle_selection_request, x_handle_selection_clear)
8230 (x_get_foreign_selection, Fx_disown_selection_internal)
8231 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8232 (lisp_data_to_selection_data): Use cons_to_unsigned.
8233 (x_fill_property_data): Use cons_to_signed.
8234 Report values out of range.
8236 Check for buffer and string overflow more precisely.
8237 * buffer.h (BUF_BYTES_MAX): New macro.
8238 * lisp.h (STRING_BYTES_MAX): New macro.
8239 * alloc.c (Fmake_string):
8240 * character.c (string_escape_byte8):
8241 * coding.c (coding_alloc_by_realloc):
8242 * doprnt.c (doprnt):
8243 * editfns.c (Fformat):
8245 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8246 since they may not be the same number.
8247 * editfns.c (Finsert_char):
8248 * fileio.c (Finsert_file_contents):
8249 Likewise for BUF_BYTES_MAX.
8251 * image.c: Use ptrdiff_t, not int, for sizes.
8252 (slurp_file): Switch from int to ptrdiff_t.
8254 (slurp_file): Check that file size fits in both size_t (for
8255 malloc) and ptrdiff_t (for sanity and safety).
8257 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8258 if b->modtime has its maximal value.
8260 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8262 Don't assume time_t can fit into int.
8263 * buffer.h (struct buffer.modtime): Now time_t, not int.
8264 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8265 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8267 Minor fixes for signed vs unsigned integers.
8268 * character.h (MAYBE_UNIFY_CHAR):
8269 * charset.c (maybe_unify_char):
8270 * keyboard.c (read_char, reorder_modifiers):
8271 XINT -> XFASTINT, since the integer must be nonnegative.
8272 * ftfont.c (ftfont_spec_pattern):
8273 * keymap.c (access_keymap, silly_event_symbol_error):
8274 XUINT -> XFASTINT, since the integer must be nonnegative.
8275 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8276 since it makes no difference and we prefer signed.
8277 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8278 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8281 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8283 * window.h (Fwindow_frame): Declare.
8285 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8287 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8288 (SPARE_MEMORY): Always define.
8289 (LARGE_REQUEST): Remove.
8290 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8292 2011-06-06 Martin Rudalics <rudalics@gmx.at>
8294 * lisp.h: Move EXFUNS for Fframe_root_window,
8295 Fframe_first_window and Fset_frame_selected_window to window.h.
8297 * window.h: Move EXFUNS for Fframe_root_window,
8298 Fframe_first_window and Fset_frame_selected_window here from
8301 * frame.c (Fwindow_frame, Fframe_first_window)
8302 (Fframe_root_window, Fframe_selected_window)
8303 (Fset_frame_selected_window): Move to window.c.
8304 (Factive_minibuffer_window): Move to minibuf.c.
8305 (Fother_visible_frames_p): New function.
8307 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8309 * window.c (decode_window, decode_any_window): Move up in code.
8310 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8311 (inhibit_frame_unsplittable): Remove unused variable.
8312 (Fwindow_buffer): Move up and rewrite doc-string.
8313 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8314 (Fwindow_prev): New functions.
8315 (Fwindow_frame): Move here from frame.c. Accept any window as
8317 (Fframe_root_window, Fframe_first_window)
8318 (Fframe_selected_window): Move here from frame.c. Accept frame
8319 or arbitrary window as argument. Update doc-strings.
8320 (Fminibuffer_window): Move up in code.
8321 (Fwindow_minibuffer_p): Move up in code and simplify.
8322 (Fset_frame_selected_window): Move here from frame.c.
8324 (Fselected_window, select_window, Fselect_window): Move up in
8325 code. Minor doc-string fixes.
8327 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8329 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8330 Do not assume that spare memory exists; that assumption is valid
8331 only if SYSTEM_MALLOC.
8332 (LARGE_REQUEST): New macro, so that the issue of large requests
8333 is separated from the issue of spare memory.
8335 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8337 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8340 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8342 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8345 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8347 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8349 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8351 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8352 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8354 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
8356 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8358 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
8360 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8361 (x_clipboard_manager_save): Add return value.
8362 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8364 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8365 Obey Vx_select_enable_clipboard_manager. Catch errors in
8366 x_clipboard_manager_save (Bug#8779).
8367 (Vx_select_enable_clipboard_manager): New variable.
8368 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
8370 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8372 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8374 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8376 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8377 in the current matrix if keep_current_p is non-zero.
8379 2011-06-04 Eli Zaretskii <eliz@gnu.org>
8381 * bidi.c (bidi_level_of_next_char): Fix last change.
8383 2011-06-03 Eli Zaretskii <eliz@gnu.org>
8385 Support bidi reordering of text covered by display properties.
8387 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8388 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8389 (bidi_cache_search, bidi_cache_iterator_state)
8390 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
8391 (bidi_level_of_next_char, bidi_move_to_visually_next):
8392 Support character positions inside a run of characters covered by a
8394 (bidi_paragraph_init, bidi_resolve_explicit_1)
8395 (bidi_level_of_next_char): Call bidi_fetch_char and
8396 bidi_fetch_char_advance instead of FETCH_CHAR and
8398 (bidi_init_it): Initialize new members.
8399 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8401 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8402 instead of using explicit *_CHAR codes.
8403 (bidi_resolve_explicit, bidi_resolve_weak):
8404 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
8405 bidirectional text is supported only in multibyte buffers.
8406 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8407 it to initialize the frame_window_p member of struct bidi_it.
8408 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8409 (bidi_resolve_explicit, bidi_resolve_weak)
8410 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8411 bidi_it->nchars is non-positive.
8412 (bidi_level_of_next_char): Don't try to lookup the cache for the
8413 next/previous character if nothing is cached there yet, or if we
8414 were just reseat()'ed to a new position.
8416 * xdisp.c (set_cursor_from_row): Set start and stop points
8417 according to the row's direction when priming the loop that looks
8418 for the glyph on which to display cursor.
8419 (single_display_spec_intangible_p): Function deleted.
8420 (display_prop_intangible_p): Reimplement to call
8421 handle_display_spec instead of single_display_spec_intangible_p.
8422 Accept 3 additional arguments needed by handle_display_spec.
8423 This fixes incorrect cursor motion across display property with complex
8424 values: lists, `(when COND...)' forms, etc.
8425 (single_display_spec_string_p): Support property values that are
8426 lists with the argument STRING its top-level element.
8427 (display_prop_string_p): Fix the condition for processing a
8428 property that is a list to be consistent with handle_display_spec.
8429 (handle_display_spec): New function, refactored from the
8430 last portion of handle_display_prop.
8431 (compute_display_string_pos): Accept additional argument
8432 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8433 value of a `display' property is a "replacing spec".
8434 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8435 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8436 the display property, but just return a value indicating whether
8437 the display property will replace the characters it covers.
8438 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8439 frame_window_p members of struct bidi_it.
8440 (compute_display_string_pos, compute_display_string_end):
8442 (push_it): Accept second argument POSITION, where pop_it should
8443 jump to continue iteration.
8444 (reseat_1): Initialize bidi_it.disp_pos.
8446 * keyboard.c (adjust_point_for_property): Adjust the call to
8447 display_prop_intangible_p to its new signature.
8449 * dispextern.h (struct bidi_it): New member frame_window_p.
8450 (bidi_init_it): Update prototypes.
8451 (display_prop_intangible_p): Update prototype.
8452 (compute_display_string_pos, compute_display_string_end):
8454 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8457 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
8459 Malloc failure behavior now depends on size of allocation.
8460 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8461 * lisp.h: Change signatures accordingly.
8462 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8463 All callers changed. (Bug#8762)
8465 * gnutls.c: Use Emacs's memory allocators.
8466 Without this change, the gnutls library would invoke malloc etc.
8467 directly, which causes problems on non-SYNC_INPUT hosts, and which
8468 runs afoul of improving memory_full behavior. (Bug#8761)
8469 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8470 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8471 xfree instead of the default malloc, realloc, free.
8472 (Fgnutls_boot): No need to check for memory allocation failure,
8473 since xmalloc does that for us.
8475 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
8476 * category.c (hash_get_category_set):
8477 * ccl.c (ccl_driver):
8478 * charset.c (Fdefine_charset_internal):
8479 * charset.h (struct charset.hash_index):
8480 * composite.c (get_composition_id, gstring_lookup_cache)
8481 (composition_gstring_put_cache):
8482 * composite.h (struct composition.hash_index):
8483 * dispextern.h (struct image.hash):
8484 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8485 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8486 (hashfn_equal, hashfn_user_defined, make_hash_table)
8487 (maybe_resize_hash_table, hash_lookup, hash_put)
8488 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8489 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8490 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8491 * image.c (make_image, search_image_cache, lookup_image)
8492 (xpm_put_color_table_h):
8493 * lisp.h (struct Lisp_Hash_Table):
8494 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
8495 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
8496 for hashes and hash indexes, instead of 'unsigned' and 'int'.
8497 * alloc.c (allocate_vectorlike):
8498 Check for overflow in vector size calculations.
8499 * ccl.c (ccl_driver):
8500 Check for overflow when converting EMACS_INT to int.
8501 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8502 need to be updated by these changes.
8503 * fns.c (make_hash_table, maybe_resize_hash_table):
8504 Check for integer overflow with large hash tables.
8505 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8506 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8507 (SXHASH_REDUCE): New macro.
8508 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8509 Use it instead of discarding useful hash info with large hash values.
8510 (sxhash_float): New function.
8511 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8512 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
8513 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8514 Rewrite to use FIXNUM_BITS, as this simplifies things.
8515 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8516 Adjust signatures to match updated version of code.
8517 (consing_since_gc): Now EMACS_INT, since a single hash table can
8518 use more than INT_MAX bytes.
8520 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8522 Make it possible to build with GCC-4.6+ -O2 -flto.
8524 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8526 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8528 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8529 Call minibuffer-inactive-mode.
8531 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
8533 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8534 Update dependencies.
8536 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8538 * data.c (init_data): Remove code for UTS, this system is not
8541 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8543 Don't force ./temacs to start in terminal mode.
8545 * frame.c (make_initial_frame): Initialize faces in all cases, not
8546 only when CANNOT_DUMP is defined.
8547 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8549 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8551 * dispnew.c (add_window_display_history): Use const for the string
8552 pointer. Remove declaration, not needed.
8554 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8556 Use 'inline', not 'INLINE'.
8557 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
8558 * alloc.c, fontset.c (INLINE): Remove.
8559 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8560 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8561 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8562 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8563 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8565 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8567 Make it possible to run ./temacs.
8569 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8570 syms_of_callproc does the same thing. Remove test for
8571 "initialized", do it in the caller.
8572 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8574 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8576 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8577 (read_minibuf): Use get_minibuffer.
8578 (syms_of_minibuf): Use DEFSYM.
8579 (Qmetadata): New var.
8580 * data.c (Qbuffer): Don't make it static.
8581 (syms_of_data): Use DEFSYM.
8583 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8585 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8586 (CCL_CODE_MIN): New macro.
8588 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8590 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8592 * eval.c (Qdebug): Now static.
8593 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8594 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8595 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8597 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8599 * image.c: Various fixes to ImageMagick code comments.
8600 (Fimagemagick_types): Doc fix.
8602 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8604 Minor fixes prompted by GCC 4.6.0 warnings.
8606 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8608 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8609 (x_clipboard_manager_save_all): Move extern decl to ...
8610 * xterm.h: ... here, so that it can be checked for consistency.
8612 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8614 * xselect.c (x_clipboard_manager_save_frame)
8615 (x_clipboard_manager_save_all): New functions.
8616 (Fx_clipboard_manager_save): Lisp function deleted.
8618 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8619 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8621 * xterm.h: Update prototype.
8623 2011-05-28 William Xu <william.xwl@gmail.com>
8625 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8628 2011-05-28 Jim Meyering <meyering@redhat.com>
8630 Avoid a sign-extension bug in crypto_hash_function.
8631 * fns.c (to_uchar): Define.
8632 (crypto_hash_function): Use it to convert some newly-signed
8633 variables to unsigned, to avoid sign-extension bugs. For example,
8634 without this change, (md5 "truc") would evaluate to
8635 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8636 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
8637 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
8639 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8641 Integer overflow fixes.
8643 * dbusbind.c: Serial number integer overflow fixes.
8644 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
8645 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8646 to hold a serial number that is too large for a fixnum.
8647 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8648 Check for serial numbers out of range. Decode any serial number
8649 that was so large that it became a float. (Bug#8722)
8651 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8652 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8653 Use XFASTINT rather than XUINT when numbers are nonnegative.
8654 (xd_append_arg, Fdbus_method_return_internal):
8655 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8656 arguments, check that Lisp number is nonnegative, rather than
8657 silently wrapping negative numbers around. (Bug#8722)
8658 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
8661 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8663 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8665 ccl: Add integer overflow checks.
8666 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8667 (IN_INT_RANGE): New macros.
8668 (ccl_driver): Use them to check for integer overflow when
8669 decoding a CCL program. Many of the new checks are whether XINT (x)
8670 fits in int; it doesn't always, on 64-bit hosts. The new version
8671 doesn't catch all possible integer overflows, but it's an
8672 improvement. (Bug#8719)
8674 * alloc.c (make_event_array): Use XINT, not XUINT.
8675 There's no need for unsigned here.
8677 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8678 This follows up to the 2011-05-06 change that substituted uintptr_t
8679 for EMACS_INT. This case wasn't caught back then.
8681 Rework Fformat to avoid integer overflow issues.
8682 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8683 now (part of C89). Include <verify.h>.
8684 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8685 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8686 (Fformat): Avoid the prepass trying to compute sizes; it was only
8687 approximate and thus did not catch overflow reliably. Instead, walk
8688 through the format just once, formatting and computing sizes as we go,
8689 checking for integer overflow at every step, and allocating a larger
8690 buffer as needed. Keep track separately whether the format is
8691 multibyte. Keep only the most-recently calculated precision, rather
8692 than them all. Record whether each argument has been converted to
8693 string. Use EMACS_INT, not int, for byte and char and arg counts.
8694 Support field widths and precisions larger than INT_MAX. Avoid
8695 sprintf's undefined behavior with conversion specifications such as %#d
8696 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8697 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8698 formatting out-of-range floating point numbers with int
8701 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8703 * data.c: Avoid integer truncation in expressions involving floats.
8704 * data.c: Include <intprops.h>.
8705 (arith_driver): When there's an integer overflow in an expression
8706 involving floating point, convert the integers to floating point
8707 so that the resulting value does not suffer from catastrophic
8708 integer truncation. For example, on a 64-bit host (* 4
8709 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8710 Do not rely on undefined behavior after integer overflow.
8712 merge count_size_as_multibyte, parse_str_to_multibyte
8713 * character.c, character.h (count_size_as_multibyte):
8714 Rename from parse_str_to_multibyte; all uses changed.
8715 Check for integer overflow.
8716 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8717 since it's now a duplicate of the other. This is more of
8718 a character than a buffer op, so better that it's in character.c.
8719 * fns.c, print.c: Adjust to above changes.
8721 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8723 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8725 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8727 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8728 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8729 (x_clipboard_manager_save): Now static.
8730 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8732 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8733 (crypto_hash_function): Now static.
8734 Fix pointer signedness problems. Avoid unnecessary initializations.
8736 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
8738 * termhooks.h (Vselection_alist): Make it terminal-local.
8740 * terminal.c (create_terminal): Initialize it.
8742 * xselect.c: Support for clipboard managers.
8743 (Vselection_alist): Move to termhooks.h as terminal-local var.
8744 (LOCAL_SELECTION): New macro.
8745 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8746 (symbol_to_x_atom): Remove gratuitous arg.
8747 (x_handle_selection_request, lisp_data_to_selection_data)
8748 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
8749 (x_own_selection, x_get_local_selection, x_convert_selection):
8750 New arg, specifying work frame. Use terminal-local Vselection_alist.
8751 (some_frame_on_display): Delete unused function.
8752 (Fx_own_selection_internal, Fx_get_selection_internal)
8753 (Fx_disown_selection_internal, Fx_selection_owner_p)
8754 (Fx_selection_exists_p): New optional frame arg.
8755 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8756 (x_handle_selection_clear): Don't treat other terminals with the
8757 same keyboard specially. Use the terminal-local Vselection_alist.
8758 (x_clear_frame_selections): Use Frun_hook_with_args.
8760 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8762 * xterm.h: Add support for those atoms.
8764 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
8766 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8767 (converted_selections, conversion_fail_tag): New global variables.
8768 (x_selection_request_lisp_error): Free the above.
8769 (x_get_local_selection): Remove unnecessary code.
8770 (x_reply_selection_request): Args changed; handle arbitrary array
8771 of converted selections stored in converted_selections.
8772 Separate the XChangeProperty and SelectionNotify steps.
8773 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8774 (x_convert_selection): New function.
8775 (x_handle_selection_event): Simplify.
8776 (x_get_foreign_selection): Don't ignore incoming requests while
8777 waiting for an answer; this will fail when we implement
8778 SAVE_TARGETS, and seems unnecessary anyway.
8779 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8780 (Vx_sent_selection_functions): Doc fix.
8782 2011-05-26 Leo Liu <sdl.web@gmail.com>
8784 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8786 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8788 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8790 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8791 for fringe update if it has periodic bitmap.
8792 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
8793 and fringe_bitmap_periodic_p.
8795 * fringe.c (get_fringe_bitmap_data): New function.
8796 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8797 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8798 row. Mark glyph row for fringe update if periodicity changed.
8800 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8801 for fringe update unless it has periodic bitmap.
8803 2011-05-25 Kenichi Handa <handa@m17n.org>
8805 * xdisp.c (get_next_display_element): Set correct it->face_id for
8806 a static composition.
8808 2011-05-24 Leo Liu <sdl.web@gmail.com>
8811 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8813 * fns.c (crypto_hash_function, Fsha1): New function.
8814 (Fmd5): Use crypto_hash_function.
8815 (syms_of_fns): Add Ssha1.
8817 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8819 * gnutls.c: Remove unused macros.
8820 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8821 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8822 Remove macros that are defined and never used.
8823 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8825 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8827 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8828 (Fx_get_selection_internal): Minor cleanup.
8829 (Fx_own_selection_internal): Rename arguments for consistency with
8832 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8834 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8836 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8838 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8840 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8842 * dispnew.c (scrolling_window): Don't exclude the case that the
8843 last enabled row in the desired matrix touches the bottom boundary.
8845 2011-05-21 Glenn Morris <rgm@gnu.org>
8847 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
8848 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8849 and add some more files.
8851 2011-05-20 Eli Zaretskii <eliz@gnu.org>
8853 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8854 report_file_error introduced by the change from 2011-05-07.
8856 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8858 * systime.h (Time): Define only if emacs is defined.
8859 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8860 where the include path doesn't have X11/X.h by default. See
8861 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8863 2011-05-20 Kenichi Handa <handa@m17n.org>
8865 * composite.c (find_automatic_composition): Fix previous change.
8867 2011-05-20 Glenn Morris <rgm@gnu.org>
8869 * lisp.mk: New file, split from Makefile.in.
8870 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8871 (shortlisp): Remove.
8872 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8874 2011-05-19 Glenn Morris <rgm@gnu.org>
8876 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8877 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8878 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8879 (lisp): Set the order to that of loadup.el.
8880 (shortlisp): Make it a copy of $lisp.
8881 (SOME_MACHINE_LISP): Remove.
8882 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8883 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8885 2011-05-18 Kenichi Handa <handa@m17n.org>
8887 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8888 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8889 (find_automatic_composition): Mostly rewrite for efficiency.
8891 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
8893 * makefile.w32-in: Update dependencies.
8895 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8897 * menu.c: Include limits.h (fixes the MS-Windows build broken by
8898 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8900 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
8902 Fix some integer overflow issues, such as string length overflow.
8904 * insdel.c (count_size_as_multibyte): Check for string overflow.
8906 * character.c (lisp_string_width): Check for string overflow.
8907 Use EMACS_INT, not int, for string indexes and lengths; in
8908 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8909 the resulting string length overflows an EMACS_INT; instead,
8910 report a string overflow if no precision given. When checking for
8911 precision exhaustion, use a check that cannot possibly have
8912 integer overflow. (Bug#8675)
8913 * character.h (lisp_string_width): Adjust to new signature.
8915 * alloc.c (string_overflow): New function.
8916 (Fmake_string): Use it. This doesn't change behavior, but saves
8917 a few bytes and will simplify future changes.
8918 * character.c (string_escape_byte8): Likewise.
8919 * lisp.h (string_overflow): New decl.
8921 Fixups, following up to the user-interface timestamp change.
8922 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8923 for UI timestamps, instead of unsigned long.
8924 * msdos.c (mouse_get_pos): Likewise.
8925 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
8926 * w32gui.h (Time): Define by including "systime.h" rather than by
8927 declaring it ourselves. (Bug#8664)
8929 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8930 * image.c (clear_image_cache): Likewise.
8932 * term.c (term_mouse_position): Don't assume time_t wraparound.
8934 Be more systematic about user-interface timestamps.
8935 Before, the code sometimes used 'Time', sometimes 'unsigned long',
8936 and sometimes 'EMACS_UINT', to represent these timestamps.
8937 This change causes it to use 'Time' uniformly, as that's what X uses.
8938 This makes the code easier to follow, and makes it easier to catch
8939 integer overflow bugs such as Bug#8664.
8940 * frame.c (Fmouse_position, Fmouse_pixel_position):
8941 Use Time, not unsigned long, for user-interface timestamps.
8942 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8943 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8944 * keyboard.h (last_event_timestamp): Likewise.
8945 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8946 * menu.h (xmenu_show): Likewise.
8947 * term.c (term_mouse_position): Likewise.
8948 * termhooks.h (struct input_event.timestamp): Likewise.
8949 (struct terminal.mouse_position_hook): Likewise.
8950 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8951 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8952 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8953 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8955 * menu.h, termhooks.h: Include "systime.h", for Time.
8957 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8958 Don't assume that the difference between two unsigned long values
8959 can fit into an integer. At this point, we know button_down_time
8960 <= event->timestamp, so the difference must be nonnegative, so
8961 there's no need to cast the result if double-click-time is
8962 nonnegative, as it should be; check that it's nonnegative, just in
8963 case. This bug is triggered when events are more than 2**31 ms
8964 apart (about 25 days). (Bug#8664)
8966 * xselect.c (last_event_timestamp): Remove duplicate decl.
8967 (x_own_selection): Remove needless cast to unsigned long.
8969 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8970 that always fit in int. Use a sentinel instead of a counter, to
8971 avoid a temp and to allay GCC's concerns about possible int overflow.
8972 * frame.h (struct frame): Use int for menu_bar_items_used
8973 instead of EMACS_INT, since it always fits in int.
8975 * menu.c (grow_menu_items): Check for int overflow.
8977 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8979 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8980 Before, the code was not consistent. These values cannot exceed
8981 2**31 - 1 so there's no need to make them unsigned.
8982 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8983 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8984 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8986 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8988 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8989 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8990 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8991 presumably because the widths might not match.
8993 * window.c (size_window): Avoid needless test at loop start.
8995 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8997 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8999 2011-05-12 Drew Adams <drew.adams@oracle.com>
9001 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9003 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9005 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9006 `width' to `bar_area_x' and `bar_area_width', respectively.
9007 (x_scroll_run): Take account of fringe background extension.
9009 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9010 Rename local vars `left' and `width' to `bar_area_x' and
9011 `bar_area_width', respectively.
9012 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9013 background extension.
9015 2011-05-10 Jim Meyering <meyering@redhat.com>
9017 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9019 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
9021 * image.c (Finit_image_library): Return t for built-in image types,
9022 like pbm and xbm. (Bug#8640)
9024 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9026 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9028 2011-05-07 Eli Zaretskii <eliz@gnu.org>
9030 * w32console.c (Fset_screen_color): Doc fix.
9031 (Fget_screen_color): New function.
9032 (syms_of_ntterm): Defsubr it.
9034 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9035 unlink the temporary file if Fcall_process didn't create it in the
9037 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9038 child process will be redirected to a file specified with `:file'.
9039 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9040 cue to call_process_cleanup not to close that handle.
9042 2011-05-07 Ben Key <bkey76@gmail.com>
9044 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9045 one of two shell specific rules, either bootstrap-temacs-CMD or
9046 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9047 to the previous implementation of the bootstrap-temacs rule.
9048 The bootstrap-temacs-CMD rule is similar to the previous
9049 implementation of the bootstrap-temacs rule except that it
9050 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9053 These changes, along with some changes to nt/configure.bat,
9054 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9055 earlier fix to add support for --cflags and --ldflags options
9056 that include quotes so that it works whether make uses cmd or
9059 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
9061 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9062 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9064 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9065 a string. Handle both cases.
9066 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9067 (Fdbus_register_method): Use Qinvalid_function.
9069 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
9071 * makefile.w32-in: Update dependencies.
9072 (LISP_H): Add inttypes.h and stdin.h.
9073 (PROCESS_H): Add unistd.h.
9075 2011-05-06 Eli Zaretskii <eliz@gnu.org>
9077 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9078 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9080 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
9082 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9084 * term.c (vfatal): Remove stray call to va_end.
9085 It's not needed and the C Standard doesn't allow it here anyway.
9087 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9088 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9090 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9093 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9095 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9097 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9099 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9101 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9103 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9104 * charset.c (Fdefine_charset_internal): Don't initialize
9105 charset.code_space[15]. The value was garbage, on hosts with
9106 32-bit int (Bug#8600).
9108 * lread.c (read_integer): Be more consistent with string-to-number.
9109 Use string_to_number to do the actual conversion; this avoids
9110 rounding errors and fixes some other screwups. Without this fix,
9111 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9112 (digit_to_number): Move earlier, for benefit of read_integer.
9113 Return -1 if the digit is out of range for the base, -2 if it is
9114 not a digit in any supported base. (Bug#8602)
9116 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9118 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9119 to match comment at start of function. This also removes a
9120 GCC warning about overflow in a 32+64-bit port.
9122 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9124 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9125 Reported by Stefan Monnier in
9126 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
9127 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9128 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
9130 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9131 (EMACS_UINTPTR): Likewise, with uintptr_t.
9133 * lisp.h: Prefer 64-bit EMACS_INT if available.
9134 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9135 on 32-bit hosts that have 64-bit int, so that they can access
9137 However, temporarily disable this change unless the temporary
9138 symbol WIDE_EMACS_INT is defined.
9140 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9142 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9143 This removes an assumption that EMACS_INT and long are the same
9144 width as pointers. The assumption is true for Emacs porting targets
9145 now, but we want to make other targets possible.
9146 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9147 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9148 In the rest of the code, change types of integers that hold casted
9149 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9150 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9151 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9152 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9153 No need to cast type when ORing.
9154 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9155 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9156 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9157 assume EMACS_INT is the same width as char *.
9158 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9159 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9160 Remove no-longer-needed casts.
9161 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9162 (xg_tool_bar_help_callback, xg_make_tool_item):
9163 Use EMACS_INTPTR to hold an integer
9164 that will be cast to void *; this can avoid a GCC warning
9165 if EMACS_INT is not the same width as void *.
9166 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9167 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9168 (current_message_1, set_message_1):
9169 Use a local to convert to proper width without a cast.
9170 * xmenu.c (dialog_selection_callback): Likewise.
9172 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9173 Also, don't assume VALBITS / RAND_BITS is less than 5,
9174 and don't rely on undefined behavior when shifting a 1 left into
9176 * lisp.h (get_random): Change signature to match.
9178 * lread.c (hash_string): Use size_t, not int, for hash computation.
9179 Normally we prefer signed values; but hashing is special, because
9180 it's better to use unsigned division on hash table sizes so that
9181 the remainder is nonnegative. Also, size_t is the natural width
9182 for hashing into memory. The previous code used 'int', which doesn't
9183 retain enough info to hash well into very large tables.
9184 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9186 * dbusbind.c: Don't possibly lose pointer info when converting.
9187 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9188 Use XPNTR rather than XHASH, so that the high-order bits of
9189 the pointer aren't lost when converting through void *.
9191 * eval.c (Fautoload): Don't double-shift a pointer.
9193 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9195 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
9197 * gnutls.c (DEF_GNUTLS_FN):
9198 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9200 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9202 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9205 2011-05-05 Eli Zaretskii <eliz@gnu.org>
9207 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9208 New version that can reserve upto 2GB of heap space.
9210 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
9212 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9214 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9216 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9217 `gnutls_certificate_set_x509_key_file'.
9219 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
9221 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9222 Update dependencies.
9224 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9226 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9227 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9228 Remove unused parameter `fildes'.
9229 * process.c (read_process_output, send_process): Don't pass it.
9231 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9233 Fix previous change: the library cache is defined in w32.c.
9234 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9235 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9237 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9239 Implement dynamic loading of GnuTLS on Windows.
9241 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9242 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9243 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9246 * gnutls.c (Qgnutls_dll): Define.
9247 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9248 (gnutls_*): Declare function pointers.
9249 (init_gnutls_functions): New function to initialize function pointers.
9250 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9251 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9252 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9253 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9254 (emacs_gnutls_write, emacs_gnutls_read)
9255 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9256 (Fgnutls_available_p): New function.
9257 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9258 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9259 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9261 * image.c: Include w32.h.
9262 (Vimage_type_cache): Delete.
9263 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9264 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9265 (w32_delayed_load): Move to w32.c.
9267 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9269 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9270 (w32_delayed_load): Move from image.c. When loading a library, record
9271 its filename in the :loaded-from property of the library id.
9272 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9273 Initialize and staticpro them.
9274 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9276 * process.c: Include lisp.h before w32.h, not after.
9277 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9278 instead of gnutls_record_check_pending.
9280 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9282 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9284 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9285 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9288 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9290 * xterm.c (x_set_frame_alpha): Do not set property on anything
9291 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9293 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
9295 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9297 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
9299 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9300 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9301 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9302 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9303 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9304 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9305 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9306 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9307 (Qgnutls_bootprop_callbacks_verify): Make static.
9309 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9311 * callproc.c: Indentation fixup.
9313 * sysdep.c (wait_for_termination_1): Make static.
9314 (wait_for_termination, interruptible_wait_for_termination):
9315 Move after wait_for_termination_1.
9317 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9319 * sysdep.c (interruptible_wait_for_termination): New function
9320 which is like wait_for_termination, but allows keyboard
9323 * callproc.c (Fcall_process): Add (:file "file") as an option for
9325 (Fcall_process_region): Ditto.
9327 2011-04-30 Eli Zaretskii <eliz@gnu.org>
9329 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9330 rather than `XVECTOR (FOO)->size'.
9332 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9333 inttypes.h, as a gnulib replacement is used if it not available in
9336 2011-04-21 Eli Zaretskii <eliz@gnu.org>
9338 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9339 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9340 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9342 * coding.c (coding_alloc_by_realloc): Error out if destination
9343 will grow beyond MOST_POSITIVE_FIXNUM.
9344 (decode_coding_emacs_mule): Abort if there isn't enough place in
9345 charbuf for the composition carryover bytes. Reserve an extra
9346 space for up to 2 characters produced in a loop.
9347 (decode_coding_iso_2022): Abort if there isn't enough place in
9348 charbuf for the composition carryover bytes.
9350 2011-04-21 Eli Zaretskii <eliz@gnu.org>
9352 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9353 aborting when %lld or %lll format is passed.
9354 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9355 %llo or %llx format is passed. (Bug#8545)
9357 * window.c (window_scroll_line_based): Use a marker instead of
9358 simple variables to record original value of point. (Bug#7952)
9360 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9361 produced by %s or %c overflows available buffer space. (Bug#8545)
9363 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9365 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
9366 (SIZE_MAX): Move defn after all includes, as they might #define it.
9368 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9370 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9372 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9374 * keyboard.c (Qdelayed_warnings_hook): Define.
9375 (command_loop_1): Run `delayed-warnings-hook'
9376 if Vdelayed_warnings_list is non-nil.
9377 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9378 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9380 2011-04-28 Eli Zaretskii <eliz@gnu.org>
9382 * doprnt.c (doprnt): Don't return value smaller than the buffer
9383 size if the message was truncated. (Bug#8545).
9385 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9387 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9388 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9390 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9392 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9394 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
9396 * makefile.w32-in: Update dependencies.
9398 2011-04-27 Eli Zaretskii <eliz@gnu.org>
9400 Improve `doprnt' and its usage. (Bug#8545)
9401 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9402 `format_end'. Remove support for %l as a conversion specifier.
9403 Don't use xrealloc. Improve diagnostics when the %l size modifier
9404 is used. Update the commentary.
9406 * eval.c (verror): Simplify calculation of size_t.
9408 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9411 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9413 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9416 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9418 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9419 This makes this file independent of the recent pseudovector change.
9421 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
9423 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9425 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
9426 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
9427 Remove unused local.
9428 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
9430 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
9431 GCC 4.6.0 optimizes based on type-based alias analysis.
9432 For example, if b is of type struct buffer * and v of type struct
9433 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9434 != &v->size, and therefore "v->size = 1; b->size = 2; return
9435 v->size;" must therefore return 1. This assumption is incorrect
9436 for Emacs, since it type-puns struct Lisp_Vector * with many other
9437 types. To fix this problem, this patch adds a new type struct
9438 vectorlike_header that documents the constraints on layout of vectors
9439 and pseudovectors, and helps optimizing compilers not get fooled
9440 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9441 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
9442 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9444 (XSETPVECTYPE): Rewrite in terms of new macro.
9445 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9446 This is a bit clearer, and further avoids the possibility of
9447 undesirable aliasing.
9448 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
9449 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
9450 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9451 since Lisp_Subr is a special case (no "next" field).
9452 (ASIZE): Now uses header.size rather than size.
9453 All previous uses of XVECTOR (foo)->size replaced to use this macro,
9454 to avoid the hassle of writing XVECTOR (foo)->header.size.
9455 (struct vectorlike_header): New type.
9456 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9457 object, to help avoid aliasing.
9458 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9459 (SUBRP): Likewise, since Lisp_Subr is a special case.
9460 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9461 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9462 (struct Lisp_Hash_Table): Combine first two members into a single
9463 struct vectorlike_header member. All uses of "size" and "next" members
9464 changed to be "header.size" and "header.next".
9465 * buffer.h (struct buffer): Likewise.
9466 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9467 * frame.h (struct frame): Likewise.
9468 * process.h (struct Lisp_Process): Likewise.
9469 * termhooks.h (struct terminal): Likewise.
9470 * window.c (struct save_window_data, struct saved_window): Likewise.
9471 * window.h (struct window): Likewise.
9472 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9473 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9474 * buffer.c (init_buffer_once): Likewise.
9475 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9477 * process.c (Fformat_network_address): Use local var for size,
9480 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9482 Make the Lisp reader and string-to-float more consistent (Bug#8525)
9483 * data.c (atof): Remove decl; no longer used or needed.
9484 (digit_to_number): Move to lread.c.
9485 (Fstring_to_number): Use new string_to_number function, to be
9486 consistent with how the Lisp reader treats infinities and NaNs.
9487 Do not assume that floating-point numbers represent EMACS_INT
9488 without losing information; this is not true on most 64-bit hosts.
9489 Avoid double-rounding errors, by insisting on integers when
9490 parsing non-base-10 numbers, as the documentation specifies.
9491 * lisp.h (string_to_number): New decl, replacing ...
9492 (isfloat_string): Remove.
9493 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
9494 (read1): Do not accept +. and -. as integers; this
9495 appears to have been a coding error. Similarly, do not accept
9496 strings like +-1e0 as floating point numbers. Do not report
9497 overflow for integer overflows unless the base is not 10 which
9498 means we have no simple and reliable way to continue.
9499 Break out the floating-point parsing into a new
9500 function string_to_number, so that Fstring_to_number parses
9501 floating point numbers consistently with the Lisp reader.
9502 (digit_to_number): Move here from data.c. Make it static inline.
9503 (E_CHAR, EXP_INT): Remove, replacing with ...
9504 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9505 (string_to_number): New function, replacing isfloat_string.
9506 This function checks for valid syntax and produces the resulting
9507 Lisp float number too. Rework it so that string-to-number
9508 no longer mishandles examples like "1.0e+". Use strtoumax,
9509 so that overflow for non-base-10 numbers is reported only when
9510 there's no portable and simple way to convert to floating point.
9512 * textprop.c (set_text_properties_1): Rewrite for clarity,
9513 and to avoid GCC warning about integer overflow.
9515 * intervals.h (struct interval): Use EMACS_INT for members
9516 where EMACS_UINT might cause problems. See
9517 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9518 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9519 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9521 (offset_intervals): Tell GCC not to worry about length overflow
9522 when negating a negative length.
9524 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9525 (overrun_check_free): Likewise.
9527 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9528 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9531 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9532 (gnutls_make_error): Rename local to avoid shadowing.
9533 (gnutls_emacs_global_deinit): ifdef out; not used.
9534 (Fgnutls_boot): Use const for pointer to readonly storage.
9535 Comment out unused local. Fix pointer signedness problems.
9537 * lread.c (openp): Don't stuff size_t into an 'int'.
9538 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9539 about possible signed overflow.
9541 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9542 (GDK_KEY_g): Don't define if already defined.
9543 (xg_prepare_tooltip): Avoid pointer signedness problem.
9544 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9546 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9547 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9549 * xfns.c (Fx_window_property): Simplify a bit,
9550 to make a bit faster and to avoid GCC 4.6.0 warning.
9551 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9553 * fns.c (internal_equal): Don't assume size_t fits in int.
9555 * alloc.c (compact_small_strings): Tighten assertion a little.
9557 Replace pEd with more-general pI, and fix some printf arg casts.
9558 * lisp.h (pI): New macro, generalizing old pEd macro to other
9559 conversion specifiers. For example, use "...%"pI"d..." rather
9560 than "...%"pEd"...".
9561 (pEd): Remove. All uses replaced with similar uses of pI.
9562 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
9563 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9564 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9565 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9566 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9567 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9568 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9570 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9571 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9572 * print.c (safe_debug_print, print_object): Likewise.
9573 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9575 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9576 avoiding the 0 flag, which is not portable.
9577 * process.c (Fmake_network_process): Use pI to avoid cast.
9578 * region-cache.c (pp_cache): Likewise.
9579 * xdisp.c (decode_mode_spec): Likewise.
9580 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9581 behavior on 64-bit hosts with printf arg.
9582 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
9583 (x_stop_queuing_selection_requests): Likewise.
9584 (x_get_window_property): Don't truncate byte count to an 'int'
9587 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9588 here, since it parses constructs like leading '-' and spaces,
9589 which are not wanted; and it overflows with large numbers.
9590 Instead, simply match F[0-9]+, which is what is wanted anyway.
9592 * alloc.c: Remove unportable assumptions about struct layout.
9593 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9594 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9595 (allocate_vectorlike, make_pure_vector): Use the new macros,
9596 plus offsetof, to remove unportable assumptions about struct layout.
9597 These assumptions hold on all porting targets that I know of, but
9598 they are not guaranteed, they're easy to remove, and removing them
9599 makes further changes easier.
9601 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9602 This doesn't fix a bug but makes the code clearer.
9603 (string_overrun_cookie): Now const. Use initializers that
9604 don't formally overflow signed char, to avoid warnings.
9605 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9606 can cause Emacs to crash when string overrun checking is enabled.
9607 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9608 multiple of sizeof (EMACS_INT); it need not be, if
9609 alignof(EMACS_INT) < sizeof (EMACS_INT).
9610 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
9612 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
9614 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9616 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9618 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
9619 supposed to be handshaking. (Bug#8556)
9620 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9622 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
9624 * lisp.h (Qdebug): List symbol.
9625 * eval.c (Qdebug): Restore global linkage.
9626 * keyboard.c (debug-on-event): New variable.
9627 (handle_user_signal): Break into debugger when debug-on-event
9628 matches the current signal symbol.
9630 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9632 * alloc.c (check_sblock, check_string_bytes)
9633 (check_string_free_list): Convert to standard C.
9635 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9637 * w32.c (emacs_gnutls_push): Fix typo.
9639 2011-04-25 Eli Zaretskii <eliz@gnu.org>
9641 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9642 "cast to pointer from integer of different size".
9644 Improve doprnt and its use in verror. (Bug#8545)
9645 * doprnt.c (doprnt): Document the set of format control sequences
9646 supported by the function. Use SAFE_ALLOCA instead of always
9649 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9650 is one byte too soon. Don't use xrealloc; instead xfree and
9653 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9655 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9658 * gnutls.c: Renamed global_initialized to
9659 gnutls_global_initialized. Added internals for the
9660 :verify-hostname-error, :verify-error, and :verify-flags
9661 parameters of `gnutls-boot' and documented those parameters in the
9662 docstring. Start callback support.
9663 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9664 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9665 on error. Return error code.
9666 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9667 (emacs_gnutls_read): Likewise.
9668 (Fgnutls_boot): Return handshake error code.
9669 (emacs_gnutls_handle_error): New function.
9670 (wsaerror_to_errno): Likewise.
9672 * w32.h (emacs_gnutls_pull): Add prototype.
9673 (emacs_gnutls_push): Likewise.
9675 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9676 (emacs_gnutls_push): Likewise.
9678 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9680 * process.c (wait_reading_process_output): Check if GnuTLS
9681 buffered some data internally if no FDs are set for TLS
9684 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9685 (LIBS): Link to USER_LIBS.
9686 ($(BLD)/gnutls.$(0)): New target.
9688 2011-04-24 Eli Zaretskii <eliz@gnu.org>
9690 * xdisp.c (handle_single_display_spec): Rename the
9691 display_replaced_before_p argument into display_replaced_p, to
9692 make it consistent with the commentary. Fix typos in the
9695 * textprop.c (syms_of_textprop): Remove dead code.
9696 (copy_text_properties): Delete obsolete commentary about an
9697 interface that was deleted long ago. Fix typos in the description
9700 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9701 to changes in oldXMenu/XMenu.h from 2011-04-16.
9702 <menu_help_message, prev_menu_help_message>: Constify.
9703 (IT_menu_make_room): menu->help_text is now `const char **';
9706 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9707 to changes in oldXMenu/XMenu.h from 2011-04-16.
9708 (struct XMenu): Declare `help_text' `const char **'.
9710 * xfaces.c <Qunspecified>: Make extern again.
9712 * syntax.c: Include sys/types.h before including regex.h, as
9715 * doc.c (get_doc_string): Improve the format passed to `error'.
9717 * doprnt.c (doprnt): Improve commentary.
9719 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9721 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9724 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9725 changes in globals.h immediately force recompilation.
9726 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9727 $(CURDIR)/s/ms-w32.h.
9728 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
9730 * character.c (Fchar_direction): Function deleted.
9731 (syms_of_character): Don't defsubr it.
9732 <char-direction-table>: Deleted.
9734 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9736 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9737 * doprnt.c: Include limits.h.
9738 (SIZE_MAX): New macro.
9739 (doprnt): Return a size_t value. 2nd arg is now size_t.
9740 Many local variables are now size_t instead of int or unsigned.
9741 Improve overflow protection. Support `l' modifier for integer
9742 conversions. Support %l conversion. Don't assume an EMACS_INT
9743 argument for integer conversions and for %c.
9745 * lisp.h (doprnt): Restore prototype.
9747 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9750 * Makefile.in (base_obj): Add back doprnt.o.
9752 * deps.mk (doprnt.o): Add back prerequisites.
9753 (callint.o): Depend on character.h.
9755 * eval.c (internal_lisp_condition_case): Include the handler
9756 representation in the error message.
9757 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9758 when breaking from the loop.
9760 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9762 * callint.c (Fcall_interactively): When displaying error message
9763 about invalid control letter, pass the character's codepoint, not
9764 a pointer to its multibyte form. Improve display of the character
9765 in octal and display also its hex code.
9767 * character.c (char_string): Use %x to display the (unsigned)
9768 codepoint of an invalid character, to avoid displaying a bogus
9771 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9772 `error', not SYMBOL_NAME itself.
9774 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9775 character arguments to `error'.
9777 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9778 to `error' in error message about FINAL_CHAR argument. Make sure
9779 FINAL_CHAR is a character, and use %c when it is passed as
9780 argument to `error'.
9782 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9784 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9786 * w32.c: Include <time.h>.
9787 (sys_localtime): New function.
9789 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
9791 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9793 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
9795 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
9797 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9800 2011-04-19 Eli Zaretskii <eliz@gnu.org>
9802 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9803 gl_state.e_property when gl_state.object is Qt.
9805 * insdel.c (make_gap_larger): Remove limitation of buffer size
9808 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
9810 * xdisp.c (lookup_glyphless_char_display)
9811 (produce_glyphless_glyph): Handle cons cell entry in
9812 glyphless-char-display.
9813 (Vglyphless_char_display): Document it.
9815 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9816 glyphless-char-display.
9818 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
9820 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9822 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9824 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9825 definition for no-X builds.
9827 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
9829 Static checks with GCC 4.6.0 and non-default toolkits.
9831 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9833 * process.c (keyboard_bit_set): Define only if SIGIO.
9834 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9835 (send_process): Repair possible setjmp clobbering.
9837 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9839 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9841 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9843 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9844 Define only if needed.
9846 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9847 by pacifying GCC about it. Maybe it's time to retire it?
9848 * xfaces.c (USG, __TIMEVAL__): Likewise.
9850 * dispextern.h (struct redisplay_interface): Rename param
9852 * termhooks.h (struct terminal): Likewise.
9853 * xterm.c (xembed_send_message): Likewise.
9855 * insdel.c (make_gap_smaller): Define only if
9856 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9858 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9861 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9862 so that we aren't warned about unused symbols.
9864 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9866 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
9868 * xfns.c (x_real_positions): Mark locals as initialized.
9870 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9872 * xterm.c: Fix problems found by static analysis with other toolkits.
9873 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
9874 (x_dispatch_event): Declare static if USE_GTK, and
9875 define if USE_GTK || USE_X_TOOLKIT.
9876 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
9877 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
9878 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9879 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
9881 * xmenu.c (menu_help_callback): Pointer type fixes.
9882 Use const pointers when pointing at readonly data. Avoid pointer
9884 (FALSE): Remove unused macro.
9885 (update_frame_menubar): Remove unused decl.
9887 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9889 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9890 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9891 (single_menu_item): Rename local to avoid shadowing.
9893 * keyboard.c (make_lispy_event): Remove unused local var.
9895 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9896 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9898 * bitmaps: Change bitmaps from unsigned char back to the X11
9899 compatible char. Avoid the old compiler warnings about
9900 out-of-range initializers by using, for example, '\xab' rather
9903 * xgselect.c (xgselect_initialize): Check vs interface
9904 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9906 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9908 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9909 to read-only memory.
9911 * fns.c (vector): Remove; this old hack is no longer needed.
9913 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
9915 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
9917 * xrdb.c (x_load_resources): Omit unused local.
9919 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
9920 (x_window): Rename locals to avoid shadowing.
9921 (USG): Use the kludged USG macro, to pacify gcc.
9923 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
9924 (x_term_init): Remove local to avoid shadowing.
9926 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
9928 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9929 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9931 2011-04-16 Eli Zaretskii <eliz@gnu.org>
9933 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9935 Fix regex.c, syntax.c and friends for buffers > 2GB.
9936 * syntax.h (struct gl_state_s): Declare character position members
9939 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9941 * textprop.c (verify_interval_modification, interval_of):
9942 Declare arguments EMACS_INT.
9944 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9947 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9949 * indent.c (Fvertical_motion): Local variable it_start is now
9952 * regex.c (re_match, re_match_2, re_match_2_internal)
9953 (bcmp_translate, regcomp, regexec, print_double_string)
9954 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9955 (re_compile_pattern, re_exec): Declare arguments and local
9956 variables `size_t' and `ssize_t' and return values `regoff_t', as
9958 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9959 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9960 <compile_stack_type>: `size' and `avail' are now `size_t'.
9962 * regex.h <regoff_t>: Use ssize_t, not int.
9963 (re_search, re_search_2, re_match, re_match_2): Arguments that
9964 specify buffer/string position and length are now ssize_t and
9965 size_t. Return type is regoff_t.
9967 2011-04-16 Ben Key <bkey76@gmail.com>
9969 * nsfont.m: Fixed bugs in ns_get_family and
9970 ns_descriptor_to_entity that were caused by using free to
9971 deallocate memory blocks that were allocated by xmalloc (via
9972 xstrdup). This caused Emacs to crash when compiled with
9973 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9974 --enable-checking=xmallocoverrun). xfree is now used to
9975 deallocate these memory blocks.
9977 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
9979 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9981 emacs_write: Accept and return EMACS_INT for sizes.
9982 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9984 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9985 Accept and return EMACS_INT.
9986 (emacs_gnutls_write): Return the number of bytes written on
9988 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
9989 (emacs_read, emacs_write): Remove check for negative size, as the
9990 Emacs source code has been audited now.
9991 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9992 (emacs_read, emacs_write): Use it.
9993 * process.c (send_process): Adjust to the new signatures of
9994 emacs_write and emacs_gnutls_write. Do not attempt to store
9995 a byte offset into an 'int'; it might overflow.
9996 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
9998 * sound.c: Don't assume sizes fit in 'int'.
9999 (struct sound_device.period_size, alsa_period_size):
10000 Return EMACS_INT, not int.
10001 (struct sound_device.write, vox_write, alsa_write):
10002 Accept EMACS_INT, not int.
10003 (wav_play, au_play): Use EMACS_INT to store sizes and to
10004 record read return values.
10006 2011-04-15 Ben Key <bkey76@gmail.com>
10008 * keyboard.c (Qundefined): Don't declare static since it is used
10010 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10011 static since they are used in nsfont.m.
10013 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10015 * process.c (Qprocessp): Don't declare static.
10016 * lisp.h (Qprocessp): Declare again.
10018 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
10020 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10022 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10024 Improve C-level modularity by making more things 'static'.
10026 Don't publish debugger-only interfaces to other modules.
10027 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10028 (verify_bytepos, count_markers): Move decls to the only modules
10030 * region-cache.h (pp_cache): Likewise.
10031 * window.h (check_all_windows): Likewise.
10032 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10034 * sysdep.c (croak): Now static, if
10035 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10036 * syssignal.h (croak): Declare only if not static.
10038 * alloc.c (refill_memory_reserve): Now static if
10039 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10040 * lisp.h (refill_memory_reserve): Declare only if not static.
10042 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10043 Define only if USE_LUCID.
10045 * xrdb.c (x_customization_string, x_rm_string): Now static.
10047 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10048 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10050 * xdisp.c (draw_row_with_mouse_face): Now static.
10051 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10053 * window.h (check_all_windows): Mark externally visible.
10055 * window.c (window_deletion_count): Now static.
10057 * undo.c: Make symbols static if they're not exported.
10058 (last_undo_buffer, last_boundary_position, pending_boundary):
10061 * textprop.c (interval_insert_behind_hooks): Now static.
10062 (interval_insert_in_front_hooks): Likewise.
10064 * term.c: Make symbols static if they're not exported.
10065 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10066 (max_frame_lines, tty_set_terminal_modes):
10067 (tty_reset_terminal_modes, tty_turn_off_highlight):
10068 (get_tty_terminal): Now static.
10069 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10070 * termhooks.h (term_mouse_moveto): Do not declare if
10071 HAVE_WINDOW_SYSTEM.
10072 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10073 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10075 * sysdep.c: Make symbols static if they're not exported.
10076 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10078 (sigprocmask_set, full_mask): Remove; unused.
10079 (wait_debugging): Mark as visible.
10080 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10081 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10083 * syntax.c (syntax_temp): Define only if !__GNUC__.
10085 * sound.c (current_sound_device, current_sound): Now static.
10087 * search.c (searchbufs, searchbuf_head): Now static.
10089 * scroll.c (scroll_cost): Remove; unused.
10090 * dispextern.h (scroll_cost): Remove decl.
10092 * region-cache.h (pp_cache): Mark as externally visible.
10094 * process.c: Make symbols static if they're not exported.
10095 (process_tick, update_tick, create_process, chan_process):
10096 (Vprocess_alist, proc_buffered_char, datagram_access):
10097 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10098 (deactivate_process): Mark defn as static, as well as decl.
10099 * lisp.h (create_process): Remove decl.
10100 * process.h (chan_process, Vprocess_alist): Remove decls.
10102 * print.c: Make symbols static if they're not exported.
10103 (print_depth, new_backquote_output, being_printed, print_buffer):
10104 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10105 (print_interval, print_number_index, initial_stderr_stream):
10107 * lisp.h (Fprinc): Remove decl.
10108 (debug_output_compilation_hack): Mark as externally visible.
10110 * sysdep.c (croak): Move decl from here to syssignal.h.
10111 * syssignal.h (croak): Put it here, so the API can be checked when
10112 'croak' is called from dissociate_if_controlling_tty.
10114 * minibuf.c: Make symbols static if they're not exported.
10115 (minibuf_save_list, choose_minibuf_frame): Now static.
10116 * lisp.h (choose_minibuf_frame): Remove decl.
10118 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10120 * lread.c: Make symbols static if they're not exported.
10121 (read_objects, initial_obarray, oblookup_last_bucket_number):
10123 (make_symbol): Remove; unused.
10124 * lisp.h (initial_obarray, make_symbol): Remove decls.
10126 * keyboard.c: Make symbols static if they're not exported.
10127 (single_kboard, recent_keys_index, total_keys, recent_keys):
10128 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10129 (this_single_command_key_start, echoing, last_auto_save):
10130 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10131 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10132 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10133 (Vlispy_mouse_stem, double_click_count):
10135 (force_auto_save_soon): Define only if SIGDANGER.
10136 (ignore_mouse_drag_p): Now static if
10137 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10138 (print_help): Remove; unused.
10139 (stop_character, last_timer_event): Mark as externally visible.
10140 * keyboard.h (ignore_mouse_drag_p): Declare only if
10141 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10142 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10143 * lisp.h (echoing): Remove decl.
10144 (force_auto_save_soon): Declare only if SIGDANGER.
10145 * xdisp.c (redisplay_window): Simplify code, to make it more
10146 obvious that ignore_mouse_drag_p is not accessed if !defined
10147 USE_GTK && !defined HAVE_NS.
10149 * intervals.c: Make symbols static if they're not exported.
10150 (merge_properties_sticky, merge_interval_right, delete_interval):
10152 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10154 * insdel.c: Make symbols static if they're not exported.
10155 However, leave prepare_to_modify_buffer alone. It's never
10156 called from outside this function, but that appears to be a bug.
10157 (combine_after_change_list, combine_after_change_buffer):
10158 (adjust_after_replace, signal_before_change): Now static.
10159 (adjust_after_replace_noundo): Remove; unused.
10160 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
10161 (signal_before_change): Remove decls.
10163 * indent.c (val_compute_motion, val_vmotion): Now static.
10165 * image.c: Make symbols static if they're not exported.
10166 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10168 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10169 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10171 * fringe.c (standard_bitmaps): Now static.
10172 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10174 * frame.c: Make symbols static if they're not exported.
10175 (x_report_frame_params, make_terminal_frame): Now static.
10176 (get_frame_param): Now static, unless HAVE_NS.
10177 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10178 (x_get_resource_string): Remove; not used.
10179 * frame.h (make_terminal_frame, x_report_frame_params):
10180 (x_get_resource_string); Remove decls.
10181 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10182 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10184 * font.c, fontset.c: Make symbols static if they're not exported.
10185 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10186 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10187 * font.c (font_close_object): Now static.
10188 * font.h (font_close_object): Remove.
10189 * fontset.c (FONTSET_OBJLIST): Remove.
10190 (free_realized_fontset) #if-0 the body, which does nothing.
10191 (face_suitable_for_char_p): #if-0, as it's never called.
10192 * fontset.h (face_suitable_for_char_p): Remove decl.
10193 * xfaces.c (face_at_string_position):
10194 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
10195 since 0 is always ASCII.
10197 * fns.c (weak_hash_tables): Now static.
10199 * fileio.c: Make symbols static if they're not exported.
10200 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10201 (Vwrite_region_annotation_buffers): Now static.
10203 * eval.c: Make symbols static if they're not exported.
10204 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10205 * lisp.h (backtrace_list): Remove decl.
10207 * emacs.c: Make symbols static if they're not exported.
10208 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10209 (fatal_error_code, fatal_error_signal_hook, standard_args):
10211 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10212 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10213 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10214 * lisp.h (fatal_error_signal_hook): Remove decl.
10215 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10217 * editfns.c: Move a (normally-unused) function to its only use.
10218 * editfns.c, lisp.h (get_operating_system_release): Remove.
10219 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10220 worth the hassle of breaking this out.
10222 * xterm.c: Make symbols static if they're not exported.
10223 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10224 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10225 (x_destroy_window, x_delete_display):
10227 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10228 (x_mouse_leave): Remove; unused.
10229 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10230 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10231 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10233 (x_mouse_leave): Declare only if WINDOWSNT.
10234 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10235 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10238 * ftxfont.c: Make symbols static if they're not exported.
10239 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10241 * font.h (ftxfont_driver): Likewise.
10243 * xfns.c: Make symbols static if they're not exported.
10244 (x_last_font_name, x_display_info_for_name):
10245 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10246 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10247 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10248 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10249 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10250 (last_show_tip_args): Now static.
10251 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10252 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10253 (x_screen_planes): Remove; unused.
10254 * dispextern.h (x_screen_planes): Remove decl.
10256 * dispnew.c: Make symbols static if they're not exported.
10257 * dispextern.h (redraw_garbaged_frames, scrolling):
10258 (increment_row_positions): Remove.
10259 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10260 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10262 (redraw_garbaged_frames): Remove; unused.
10264 * xfaces.c: Make symbols static if they're not exported.
10265 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10267 * xterm.h (defined_color): Remove decls.
10268 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10269 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10270 (menu_face_changed_default, defined_color, free_realized_face):
10271 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10272 (ascii_face_of_lisp_face): Remove; unused.
10274 * xdisp.c: Make symbols static if they're not exported.
10275 * dispextern.h (scratch_glyph_row, window_box_edges):
10276 (glyph_to_pixel_coords, set_cursor_from_row):
10277 (get_next_display_element, set_iterator_to_next):
10278 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10279 (show_mouse_face): Remove decls
10280 * frame.h (message_buf_print): Likewise.
10281 * lisp.h (pop_message, set_message, check_point_in_composition):
10283 * xterm.h (set_vertical_scroll_bar): Likewise.
10284 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10285 (message_buf_print, scratch_glyph_row, displayed_buffer):
10286 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10287 (get_next_display_element, show_mouse_face, window_box_edges):
10288 (frame_to_window_pixel_xy, check_point_in_composition):
10289 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10290 (glyph_to_pixel_coords): Remove; unused.
10292 * dired.c (file_name_completion): Now static.
10294 * dbusbind.c (xd_in_read_queued_messages): Now static.
10296 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10297 * data.c (circular_list_error): Remove.
10299 * commands.h (last_point_position, last_point_position_buffer):
10300 (last_point_position_window): Remove decls.
10301 * keyboard.c: Make these variables static.
10303 * coding.h (coding, code_convert_region, encode_coding_gap):
10305 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10306 (iso_code_class, detect_coding, code_convert_region): Now static.
10307 (encode_coding_gap): Remove; unused.
10309 * chartab.c (chartab_chars, chartab_bits): Now static.
10311 * charset.h (charset_iso_8859_1): Remove decl.
10312 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10315 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10316 * ccl.c (Vccl_program_table): Now static.
10317 (check_ccl_update): Remove; unused.
10319 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10320 * category.h: ... from here.
10321 * category.c (check_category_table, set_category_set): Now static.
10323 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10324 * lisp.h: Remove these decls.
10326 * buffer.c (buffer_count): Remove unused var.
10328 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10329 so that it's not optimized away.
10330 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10331 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10332 exported only to the debugger.
10334 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
10335 * atimer.h (run_all_atimers): Remove; not exported.
10337 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10338 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10339 was inaccessible from Lisp.
10340 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10341 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10343 alloc.c: Import and export fewer symbols, and remove unused items.
10344 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10346 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10347 it's not optimized away by whole-program optimization.
10348 (message_enable_multibyte, free_misc): Remove.
10349 (catchlist, handlerlist, mark_backtrace):
10350 Declare only if BYTE_MARK_STACK.
10351 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10352 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10353 (message_enable_multibyte): Remove decl.
10354 (free_misc, interval_free_list, float_block, float_block_index):
10355 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10356 (cons_free_list, last_marked_index):
10358 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10359 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10360 (mark_backtrace): Define only if BYTE_MARK_STACK.
10361 * xdisp.c (message_enable_multibyte): Now static.
10363 Declare Lisp_Object Q* variables to be 'static' if not exported.
10364 This makes it easier for human readers (and static analyzers)
10365 to see whether these variables are used from other modules.
10366 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10367 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10368 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10369 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10370 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10371 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10372 * xmenu.c, xselect.c:
10373 Declare Q* vars static if they are not used in other modules.
10374 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10375 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10376 Remove decls of unexported vars.
10377 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10379 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10381 Make Emacs functions such as Fatom 'static' by default.
10382 This makes it easier for human readers (and static analyzers)
10383 to see whether these functions can be called from other modules.
10384 DEFUN now defines a static function. To make the function external
10385 so that it can be used in other C modules, use the new macro DEFUE.
10386 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10387 (Finit_image_library):
10388 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10389 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10390 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10391 Remove decls, since these functions are now static.
10392 (Funintern, Fget_internal_run_time): New decls, since these functions
10393 were already external.
10395 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10396 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10397 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10398 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10399 * keyboard.c, keymap.c, lread.c:
10400 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10401 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10402 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10403 Mark functions with DEFUE instead of DEFUN,
10404 if they are used in other modules.
10405 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10406 decls for now-static functions.
10407 * buffer.h (Fdelete_overlay): Remove decl.
10408 * callproc.c (Fgetenv_internal): Mark as internal.
10409 * composite.c (Fremove_list_of_text_properties): Remove decl.
10410 (Fcomposition_get_gstring): New forward static decl.
10411 * composite.h (Fcomposite_get_gstring): Remove decl.
10412 * dired.c (Ffile_attributes): New forward static decl.
10413 * doc.c (Fdocumntation_property): New forward static decl.
10414 * eval.c (Ffetch_bytecode): New forward static decl.
10415 (Funintern): Remove extern decl; now in .h file where it belongs.
10416 * fileio.c (Fmake_symbolic_link): New forward static decl.
10417 * image.c (Finit_image_library): New forward static decl.
10418 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10419 * intervals.h (Fprevious_property_change):
10420 (Fremove_list_of_text_properties): Remove decls.
10421 * keyboard.c (Fthis_command_keys): Remove decl.
10422 (Fcommand_execute): New forward static decl.
10423 * keymap.c (Flookup_key): New forward static decl.
10424 (Fcopy_keymap): Now static.
10425 * keymap.h (Flookup_key): Remove decl.
10426 * process.c (Fget_process): New forward static decl.
10427 (Fprocess_datagram_address): Mark as internal.
10428 * syntax.c (Fsyntax_table_p): New forward static decl.
10429 (skip_chars): Remove duplicate decl.
10430 * textprop.c (Fprevious_property_change): New forward static decl.
10431 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10433 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10434 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10436 * editfns.c (Fformat): Remove unreachable code.
10438 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10440 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10443 2011-04-13 Eli Zaretskii <eliz@gnu.org>
10445 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10446 when at ZV. (Bug#8487)
10448 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10450 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10452 * keyboard.c (parse_tool_bar_item): Likewise.
10453 * sound.c (sound_cleanup, alsa_close): Likewise.
10454 * termcap.c (tgetent): Likewise.
10455 * xfns.c (x_default_font_parameter): Likewise.
10456 * xsettings.c (read_and_apply_settings): Likewise.
10458 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10459 (overrun_check_free): Protoize.
10461 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10463 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10464 since callers should never pass a negative size.
10465 Change the signature to match that of plain 'read' and 'write'; see
10466 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10467 * lisp.h: Update prototypes of emacs_write and emacs_read.
10469 2011-04-11 Eli Zaretskii <eliz@gnu.org>
10471 * xdisp.c (redisplay_window): Don't try to determine the character
10472 position of the scroll margin if the window start point w->startp
10473 is outside the buffer's accessible region. (Bug#8468)
10475 2011-04-10 Eli Zaretskii <eliz@gnu.org>
10477 Fix write-region and its subroutines for buffers > 2GB.
10478 * fileio.c (a_write, e_write): Modify declaration of arguments and
10479 local variables to support buffers larger than 2GB.
10480 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10482 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10483 argument, local variables, and return value.
10485 * lisp.h: Update prototypes of emacs_write and emacs_read.
10487 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10489 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
10491 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10493 Fix more problems found by GCC 4.6.0's static checks.
10495 * xdisp.c (vmessage): Use a better test for character truncation.
10497 * charset.c (load_charset_map): <, not <=, for optimization,
10498 and to avoid potential problems with integer overflow.
10499 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
10500 * casetab.c (set_identity, shuffle): Likewise.
10501 * editfns.c (Fformat): Likewise.
10502 * syntax.c (skip_chars): Likewise.
10504 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10505 This also lets GCC 4.6.0 generate slightly better loop code.
10507 * callint.c (Fcall_interactively): <, not <=, for optimization.
10508 (Fcall_interactively): Count the number of arguments produced,
10509 not the number of arguments given. This is simpler and lets GCC
10510 4.6.0 generate slightly better code.
10512 * ftfont.c: Distingish more carefully between FcChar8 and char.
10513 The previous code passed unsigned char * to a functions like
10514 strlen and xstrcasecmp that expect char *, which does not
10515 conform to the C standard.
10516 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10517 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10518 char * when the C standard requires it.
10520 * keyboard.c (read_char): Remove unused var.
10522 * eval.c: Port to Windows vsnprintf (Bug#8435).
10523 Include <limits.h>.
10524 (SIZE_MAX): Define if the headers do not.
10525 (verror): Do not give up if vsnprintf returns a negative count.
10526 Instead, grow the buffer. This ports to Windows vsnprintf, which
10527 does not conform to C99. Problem reported by Eli Zaretskii.
10528 Also, simplify the allocation scheme, by avoiding the need for
10529 calling realloc, and removing the ALLOCATED variable.
10531 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10533 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10534 But keep the doprint source code for now, as we might revamp it
10535 and use it again (Bug#8435).
10536 * lisp.h (doprnt): Remove.
10537 * Makefile.in (base_obj): Remove doprnt.o.
10538 * deps.mk (doprnt.o): Remove.
10540 error: Print 32- and 64-bit integers portably (Bug#8435).
10541 Without this change, on typical 64-bit hosts error ("...%d...", N)
10542 was used to print both 32- and 64-bit integers N, which relied on
10543 undefined behavior.
10544 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
10545 * lisp.h (error, verror): Mark as printf-like functions.
10546 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10547 Report overflow in size calculations when allocating printf buffer.
10548 Do not truncate output string at its first null byte.
10549 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10550 Truncate the output at a character boundary, since vsnprintf does not
10552 * charset.c (check_iso_charset_parameter): Convert internal
10553 character to string before calling 'error', since %c now has the
10555 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10556 overflow when computing char to be passed to 'error'. Do not
10557 pass Lisp_Object to 'error'; pass the integer instead.
10558 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10559 formatted with plain %d.
10561 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10563 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10565 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10567 * xterm.c (x_catch_errors): Remove duplicate declaration.
10569 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10571 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10573 2011-04-10 Jim Meyering <meyering@redhat.com>
10575 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10576 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10577 return ssize_t not "int", and use size_t as the buffer length.
10578 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10579 * gnutls.h: Update declarations.
10580 * process.c (read_process_output): Use ssize_t, to match.
10581 (send_process): Likewise.
10583 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10585 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10587 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10589 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10590 Use unsigned char, to match FcChar8 type definition.
10592 * xterm.c (handle_one_xevent):
10593 * xmenu.c (create_and_show_popup_menu):
10594 * xselect.c (x_decline_selection_request)
10595 (x_reply_selection_request): Avoid type-punned deref of X events.
10597 2011-04-09 Eli Zaretskii <eliz@gnu.org>
10599 Fix some uses of `int' instead of EMACS_INT.
10600 * search.c (string_match_1, fast_string_match)
10601 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10602 (scan_buffer, find_next_newline_no_quit)
10603 (find_before_next_newline, search_command, Freplace_match)
10604 (Fmatch_data): Make some `int' variables be EMACS_INT.
10606 * xdisp.c (display_count_lines): 3rd argument and return value now
10607 EMACS_INT. All callers changed.
10608 (pint2hrstr): Last argument is now EMACS_INT.
10610 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10611 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10612 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10613 (decode_coding_utf_16, decode_coding_emacs_mule)
10614 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10615 (decode_coding_ccl, decode_coding_charset)
10616 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10617 (decode_coding_iso_2022, decode_coding_emacs_mule)
10618 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10619 <char_offset, last_offset>: Declare EMACS_INT.
10620 (encode_coding_utf_8, encode_coding_utf_16)
10621 (encode_coding_emacs_mule, encode_invocation_designation)
10622 (encode_designation_at_bol, encode_coding_iso_2022)
10623 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10624 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10626 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10627 (encode_invocation_designation): Last argument P_NCHARS is now
10629 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10630 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10632 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10635 * ccl.c (Fccl_execute_on_string): Declare some variables
10638 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
10640 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10642 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10644 * process.c (Fformat_network_address): Doc fix.
10646 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10648 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
10650 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
10652 * keyboard.c (read_char): Call Lisp function help-form-show,
10653 instead of using internal_with_output_to_temp_buffer.
10654 (Qhelp_form_show): New var.
10655 (syms_of_keyboard): Use DEFSYM macro.
10657 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10659 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10661 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
10663 * process.c (Flist_processes): Remove to Lisp.
10664 (list_processes_1): Delete.
10666 2011-04-06 Eli Zaretskii <eliz@gnu.org>
10668 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10670 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10672 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
10674 Fix more problems found by GCC 4.6.0's static checks.
10676 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10678 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10680 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
10682 * xdisp.c (vmessage): Mark as a printf-like function.
10684 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10686 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10688 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10689 printf-like functions.
10690 (tiff_load): Add casts to remove these marks before passing them
10691 to system-supplied API.
10693 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10695 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10696 This avoids several warnings with gcc -Wstrict-overflow.
10697 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10698 directly, rather than having caller test rule sign. This avoids
10699 some unnecessary tests.
10700 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10701 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10702 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
10704 * xfont.c (xfont_text_extents): Remove var that was set but not used.
10705 (xfont_open): Avoid unnecessary tests.
10707 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10709 * composite.h, composite.c (composition_gstring_put_cache):
10710 Use EMACS_INT, not int, for length.
10712 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10713 breaking out part of COMPOSITION_DECODE_RULE.
10714 (COMPOSITION_DECODE_RULE): Use it.
10715 * composite.c (get_composition_id): Remove unused local vars,
10716 by using the new macro.
10718 * textprop.c (set_text_properties_1): Change while to do-while,
10719 since the condition is always true at first.
10721 * intervals.c (graft_intervals_into_buffer): Mark var as used.
10722 (interval_deletion_adjustment): Return unsigned value.
10725 * process.c (list_processes_1, create_pty, read_process_output):
10726 (exec_sentinel): Remove vars that were set but not used.
10727 (create_pty): Remove unnecessary "volatile"s.
10728 (Fnetwork_interface_info): Avoid possibility of int overflow.
10729 (read_process_output): Do adaptive read buffering even if carryover.
10730 (read_process_output): Simplify nbytes computation if buffered.
10732 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10734 * syntax.c (scan_words): Remove var that was set but not used.
10735 (update_syntax_table): Use unsigned instead of int.
10737 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
10738 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
10739 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
10741 * print.c (print_error_message): Avoid int overflow.
10743 * font.c (font_list_entities): Redo for clarity,
10744 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10746 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
10747 (font_score): Avoid potential overflow in diff calculation.
10749 * fns.c (substring_both): Remove var that is set but not used.
10750 (sxhash): Redo loop for clarity and to avoid wraparound warning.
10752 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10754 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10755 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10756 can always succeed if overflow has undefined behavior.
10758 * search.c (boyer_moore, wordify): Remove vars set but not used.
10759 (wordify): Omit three unnecessary tests.
10761 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10762 All callers changed. This avoids the need for an unused var.
10764 * casefiddle.c (casify_region): Remove var that is set but not used.
10766 * dired.c (file_name_completion): Remove var that is set but not used.
10768 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10770 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
10771 (Finsert_file_contents): Remove unnecessary code checking fd.
10773 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10774 Check for integer overflow on size calculations.
10776 * buffer.c (Fprevious_overlay_change): Remove var that is set
10779 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10780 Remove vars that are set but not used.
10781 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
10782 (timer_check_2): Mark vars as initialized.
10784 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10786 * image.c (lookup_image): Remove var that is set but not used.
10787 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
10789 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10790 that are set but not used.
10792 * xfns.c (make_invisible_cursor): Don't return garbage
10793 if XCreateBitmapFromData fails (Bug#8410).
10795 * xselect.c (x_get_local_selection, x_handle_property_notify):
10796 Remove vars that are set but not used.
10798 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
10799 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
10801 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10802 Remove var that is set but not used.
10803 (scroll_bar_windows_size): Now size_t, not int.
10804 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10805 Check for overflow.
10807 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10808 (map_tty_color) [!defined MSDOS]: Likewise.
10810 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10812 * coding.c: Remove vars that are set but not used.
10813 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10814 All callers changed.
10815 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10816 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10817 (decode_coding_charset): Remove vars that are set but not used.
10819 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10820 that is set but not used.
10822 * print.c (print_object): Remove var that is set but not used.
10824 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
10825 The gnulib version avoids calling malloc in the usual case,
10826 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10827 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10828 * filelock.c (current_lock_owner): Likewise.
10829 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10830 * sysdep.c: Include allocator.h, careadlinkat.h.
10831 (emacs_no_realloc_allocator): New static constant.
10832 (emacs_readlink): New function.
10833 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10834 ../lib/careadlinkat.h.
10836 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10838 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10839 first non-nil return value).
10841 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10843 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10844 if not defined (Bug#8403).
10846 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10848 * xdisp.c (display_count_lines): Remove parameter `start',
10849 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10850 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10851 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10852 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10853 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10854 and thereabouts. All callers changed.
10855 (get_per_char_metric): Remove parameter `f', unused since
10856 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10858 2011-04-02 Jim Meyering <meyering@redhat.com>
10860 do not dereference NULL upon failed strdup
10861 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10862 (ns_get_family): Likewise.
10864 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10866 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10868 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10870 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10873 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10875 Add lexical binding.
10877 * window.c (Ftemp_output_buffer_show): New fun.
10878 (Fsave_window_excursion):
10879 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10881 * lread.c (lisp_file_lexically_bound_p): New function.
10882 (Fload): Bind Qlexical_binding.
10883 (readevalloop): Remove `evalfun' arg.
10884 Bind Qinternal_interpreter_environment.
10885 (Feval_buffer): Bind Qlexical_binding.
10886 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10888 (syms_of_lread): Declare `lexical-binding'.
10890 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10892 * keyboard.c (eval_dyn): New fun.
10893 (menu_item_eval_property): Use it.
10895 * image.c (parse_image_spec): Use Ffunctionp.
10897 * fns.c (concat, mapcar1): Accept byte-code-functions.
10899 * eval.c (Fsetq): Handle lexical vars.
10900 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10901 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10902 (FletX, Flet): Obey lexical binding.
10903 (Fcommandp): Handle closures.
10904 (Feval): New `lexical' arg.
10905 (eval_sub): New function extracted from Feval. Use it almost
10906 everywhere where Feval was used. Look up vars in lexical env.
10908 (Ffunctionp): Move from subr.el.
10909 (Ffuncall): Handle closures.
10910 (apply_lambda): Remove `eval_flags'.
10911 (funcall_lambda): Handle closures and new byte-code-functions.
10912 (Fspecial_variable_p): New function.
10913 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10914 but without exporting it to Lisp.
10916 * doc.c (Fdocumentation, store_function_docstring):
10917 * data.c (Finteractive_form): Handle closures.
10919 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10922 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10924 (exec_byte_code): New function extracted from Fbyte_code to handle new
10925 calling convention for byte-code-functions. Add new byte-codes.
10927 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
10929 * alloc.c (Fmake_symbol): Init new `declared_special' field.
10931 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10933 * xdisp.c (redisplay_internal): Fix prototype.
10935 2011-03-31 Eli Zaretskii <eliz@gnu.org>
10937 * xdisp.c (SCROLL_LIMIT): New macro.
10938 (try_scrolling): Use it when setting scroll_limit.
10939 Limit scrolling to 100 screen lines.
10940 (redisplay_window): Even when falling back on "recentering",
10941 position point in the window according to scroll-conservatively,
10942 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10944 (try_scrolling): When point is above the window, allow searching
10945 as far as scroll_max, or one screenful, to compute vertical
10946 distance from PT to the scroll margin position. This prevents
10947 try_scrolling from unnecessarily failing when
10948 scroll-conservatively is set to a value slightly larger than the
10949 window height. Clean up the case of PT below the margin at bottom
10950 of window: scroll_max can no longer be INT_MAX. When aggressive
10951 scrolling is in use, don't let point enter the opposite scroll
10952 margin as result of the scroll.
10953 (syms_of_xdisp) <scroll-conservatively>: Document the
10954 threshold of 100 lines for never-recentering scrolling.
10956 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10958 * dispextern.h (move_it_by_lines):
10959 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10960 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10961 (message_log_check_duplicate): Remove parameters `prev_bol' and
10962 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10963 (redisplay_internal): Remove parameter `preserve_echo_area',
10964 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10966 * indent.c (Fvertical_motion):
10967 * window.c (window_scroll_pixel_based, Frecenter):
10968 Don't pass `need_y_p' to `move_it_by_lines'.
10970 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10972 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10973 steal a few bits to be more compact.
10974 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10975 Remove unneeded casts.
10977 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10979 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10981 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10982 binding" message (bug#7967).
10984 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10986 Fix more problems found by GCC 4.6.0's static checks.
10988 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10989 Remove unused local var.
10991 * editfns.c (Fmessage_box): Remove unused local var.
10993 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10994 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10995 Omit unused local vars.
10996 * window.c (shrink_windows): Omit unused local var.
10997 * menu.c (digest_single_submenu): Omit unused local var.
10998 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10999 Omit unused local var.
11001 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11002 Don't assume string length fits in int.
11003 (keyremap_step, read_key_sequence): Use size_t for sizes.
11004 (read_key_sequence): Don't check last_real_key_start redundantly.
11006 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11007 instead of alloca (Bug#8344).
11009 * eval.c (Fbacktrace): Don't assume nargs fits in int.
11010 (Fbacktrace_frame): Don't assume nframes fits in int.
11012 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11014 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11017 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11019 * cm.c (calccost): Turn while-do into do-while, for clarity.
11021 * keyboard.c (syms_of_keyboard): Use the same style as later
11022 in this function when indexing through an array. This also
11023 works around GCC bug 48267.
11025 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11027 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11029 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11030 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11032 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11033 This avoids undefined behavior on integer overflow, and is a bit
11034 more convenient anyway since it is compared to a size_t variable.
11036 Variadic C functions now count arguments with size_t, not int.
11037 This avoids an unnecessary limitation on 64-bit machines, which
11038 caused (substring ...) to crash on large vectors (Bug#8344).
11039 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11040 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
11041 All variadic functions and their callers changed accordingly.
11042 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11043 * data.c (arith_driver, float_arith_driver): Likewise.
11044 * editfns.c (general_insert_function): Likewise.
11045 * eval.c (struct backtrace.nargs, interactive_p)
11046 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11047 (funcall_lambda, mark_backtrace): Likewise.
11048 * fns.c (concat): Likewise.
11049 * frame.c (x_set_frame_parameters): Likewise.
11050 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11051 0 if not found, not -1. All callers changed.
11053 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11054 (stack_copy_size): Now size_t, not int.
11055 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11057 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
11059 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11060 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11061 All callers changed.
11063 * lisp.h (multibyte_char_to_unibyte):
11064 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11065 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11066 * character.h (CHAR_TO_BYTE8):
11067 * cmds.c (internal_self_insert):
11068 * editfns.c (general_insert_function):
11069 * keymap.c (push_key_description):
11070 * search.c (Freplace_match):
11071 * xdisp.c (message_dolog, set_message_1): All callers changed.
11073 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11075 * keyboard.c (safe_run_hook_funcall): New function.
11076 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11077 don't set the hook to nil, but remove the offending function instead.
11078 (Qcommand_hook_internal): Remove, unused.
11079 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11080 Vcommand_hook_internal.
11082 * eval.c (enum run_hooks_condition): Remove.
11083 (funcall_nil, funcall_not): New functions.
11084 (run_hook_with_args): Call each function through a `funcall' argument.
11085 Remove `cond' argument, now redundant.
11086 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11087 (Frun_hook_with_args_until_failure): Adjust accordingly.
11088 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11090 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
11092 * dispextern.h (string_buffer_position): Remove declaration.
11094 * print.c (strout): Remove parameter `multibyte', unused since
11095 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11097 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11098 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11099 All callers changed.
11101 * w32.c (_wsa_errlist): Use braces for struct initializers.
11103 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11104 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11105 All callers changed.
11106 (string_buffer_position): Likewise. Also, make static (it's never
11107 used outside xdisp.c).
11108 (cursor_row_p): Remove parameter `w', unused since
11109 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11110 (decode_mode_spec): Remove parameter `precision', introduced during
11111 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11112 All callers changed.
11114 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11116 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11118 2011-03-27 Anders Lindgren <andlind@gmail.com>
11120 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11121 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11122 (ns_update_auto_hide_menu_bar): New functions.
11123 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11124 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11125 ns_constrain_all_frames.
11126 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11127 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11129 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11131 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11133 2011-03-27 Glenn Morris <rgm@gnu.org>
11135 * syssignal.h: Replace RETSIGTYPE with void.
11136 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11137 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11138 Replace SIGTYPE with void everywhere.
11139 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11140 * s/template.h (SIGTYPE): Remove commented out definition.
11142 2011-03-26 Eli Zaretskii <eliz@gnu.org>
11144 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11145 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11147 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
11149 * w32.c (read_unc_volume): Use parameter `henum', instead of
11150 global variable `wget_enum_handle'.
11152 * keymap.c (describe_vector): Remove parameters `indices' and
11153 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11154 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11156 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11158 * keyboard.c (timer_check): Remove parameter `do_it_now',
11159 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11160 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11161 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11163 * keyboard.c (read_char):
11164 * w32menu.c (w32_menu_display_help):
11165 * xmenu.c (show_help_event, menu_help_callback):
11166 Adjust calls to `show_help_echo'.
11168 * gtkutil.c (xg_maybe_add_timer):
11169 * keyboard.c (readable_events):
11170 * process.c (wait_reading_process_output):
11171 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11173 * insdel.c (adjust_markers_gap_motion):
11174 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11175 (gap_left, gap_right): Don't call it.
11177 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
11179 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11180 incurred during fontification.
11182 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
11184 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11185 (DEFVAR_PER_BUFFER): Don't pass it.
11187 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11188 (scrolling_window): Don't pass it.
11190 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
11192 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11194 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11196 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11197 of variables specific to SELinux and computation of `encoded_absname'.
11199 * image.c (XPutPixel): Remove unused variable `height'.
11201 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11203 * unexw32.c (get_section_info): Remove unused variable `section'.
11205 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11206 (system_process_attributes): Remove unused variable `sess'.
11207 (sys_read): Remove unused variable `err'.
11209 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11210 (w32_wnd_proc): Remove unused variable `isdead'.
11211 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11212 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11213 (x_create_tip_frame): Remove unused variable `tem'.
11215 * w32inevt.c (w32_console_read_socket):
11216 Remove unused variable `no_events'.
11218 * w32term.c (x_draw_composite_glyph_string_foreground):
11219 Remove unused variable `width'.
11221 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
11223 * w32term.c (x_set_glyph_string_clipping):
11224 Don't pass uninitialized region to CombineRgn.
11226 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
11228 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11229 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11230 (Fx_close_connection): Remove unused variable `i'.
11232 * w32font.c (w32font_draw): Return number of glyphs.
11233 (w32font_open_internal): Remove unused variable `i'.
11234 (w32font_driver): Add missing initializer.
11236 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11237 (fill_in_menu): Remove unused variable `items_added'.
11239 * w32term.c (last_mouse_press_frame): Remove static global variable.
11240 (w32_clip_to_row): Remove unused variable `f'.
11241 (x_delete_terminal): Remove unused variable `i'.
11243 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11244 (NOTHING): Remove unused static global variable.
11245 (uniscribe_check_otf): Remove unused variable `table'.
11246 (uniscribe_font_driver): Add missing initializers.
11248 2011-03-23 Julien Danjou <julien@danjou.info>
11250 * term.c (Fsuspend_tty, Fresume_tty):
11251 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11252 * window.c (temp_output_buffer_show):
11253 * insdel.c (signal_before_change):
11254 * frame.c (Fhandle_switch_frame):
11255 * fileio.c (Fdo_auto_save):
11256 * emacs.c (Fkill_emacs):
11257 * editfns.c (save_excursion_restore):
11258 * cmds.c (internal_self_insert):
11259 * callint.c (Fcall_interactively):
11260 * buffer.c (Fkill_all_local_variables):
11261 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11263 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
11264 unconditionally since it does the check itself.
11266 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
11268 Fix more problems found by GCC 4.5.2's static checks.
11270 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11271 the first time through the loop, since we know p0 < p1 then.
11272 This also avoids a gcc -Wstrict-overflow warning.
11274 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11275 leading to a memory leak, possible in functions like
11276 load_charset_map_from_file that can allocate an unbounded number
11277 of objects (Bug#8318).
11279 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11280 that could (at least in theory) be that large.
11282 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11283 This is less likely to overflow, and avoids undefined behavior if
11284 overflow does occur. All callers changed. Use strtoul to scan
11285 for the unsigned long integer.
11286 (pint2hrstr): Simplify and tune code slightly.
11287 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
11289 * scroll.c (do_scrolling): Work around GCC bug 48228.
11290 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11292 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11293 This also avoids a warning with gcc -Wstrict-overflow.
11294 (validate_x_resource_name): Simplify count usage.
11295 This also avoids a warning with gcc -Wstrict-overflow.
11297 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11300 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
11302 * process.c (Fmake_network_process): Use socklen_t, not int,
11303 where POSIX says socklen_t is required in portable programs.
11304 This fixes a porting bug on hosts like 64-bit HP-UX, where
11305 socklen_t is wider than int (Bug#8277).
11306 (Fmake_network_process, server_accept_connection):
11307 (wait_reading_process_output, read_process_output):
11310 * process.c: Rename or move locals to avoid shadowing.
11311 (list_processes_1, Fmake_network_process):
11312 (read_process_output_error_handler, exec_sentinel_error_handler):
11313 Rename or move locals.
11314 (Fmake_network_process): Define label "retry_connect" only if needed.
11315 (Fnetwork_interface_info): Fix pointer signedness.
11316 (process_send_signal): Add cast to avoid pointer signedness problem.
11317 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
11318 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
11320 Make tparam.h and terminfo.c consistent.
11321 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11322 Include tparam.h instead, since it declares them.
11323 * cm.h (PC): Remove extern decl; tparam.h now does this.
11324 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11325 * terminfo.c: Include tparam.h, to check interfaces.
11326 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11327 (tparam): Adjust signature to match interface in tparam.h;
11328 this removes some undefined behavior. Check that outstring and len
11329 are zero, which they always are with Emacs.
11330 * tparam.h (PC, BC, UP): New extern decls.
11332 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
11333 (xftfont_open): Rename locals to avoid shadowing.
11335 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
11336 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11337 (OTF_TAG_SYM): Omit macro if not needed.
11338 (ftfont_list): Remove unused local.
11339 (get_adstyle_property, ftfont_pattern_entity):
11340 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11341 Rename locals to avoid shadowing.
11343 * xfont.c (xfont_list_family): Mark var as initialized.
11345 * xml.c (make_dom): Now static.
11347 * composite.c (composition_compute_stop_pos): Rename local to
11349 (composition_reseat_it): Remove unused locals.
11350 (find_automatic_composition, composition_adjust_point): Likewise.
11351 (composition_update_it): Mark var as initialized.
11352 (find_automatic_composition): Mark vars as initialized,
11353 with a FIXME (Bug#8290).
11355 character.h: Rename locals to avoid shadowing.
11356 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11357 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11358 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11359 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11360 to avoid shadowing.
11362 * textprop.c (property_change_between_p): Remove; unused.
11364 * intervals.c (interval_start_pos): Now static.
11366 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11368 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11369 Rename locals to avoid shadowing.
11371 * sound.c (wav_play, au_play, Fplay_sound_internal):
11372 Fix pointer signedness.
11373 (alsa_choose_format): Remove unused local var.
11374 (wav_play): Initialize a variable to 0, to prevent undefined
11375 behavior (Bug#8278).
11377 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11379 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11381 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11382 clobbering (Bug#8298).
11383 * sysdep.c (sys_subshell): Likewise.
11384 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
11386 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11387 This should get cleaned up, so that child_setup has the
11388 same signature on all platforms.
11390 * callproc.c (call_process_cleanup): Now static.
11391 (relocate_fd): Rename locals to avoid shadowing.
11393 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
11395 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11396 not to be necessary, and produces flickering.
11398 2011-03-20 Glenn Morris <rgm@gnu.org>
11400 * config.in: Remove file.
11402 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
11404 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11405 are now in src/globals.h.
11406 (syms_of_minibuf): Remove spurious & from previous change.
11408 2011-03-20 Leo Liu <sdl.web@gmail.com>
11410 * minibuf.c (completing-read-function): New variable.
11411 (completing-read-default): Rename from completing-read.
11412 (completing-read): Call completing-read-function.
11414 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
11416 * xfaces.c (Fx_load_color_file):
11417 Read color file from absolute filename (bug#8250).
11419 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
11421 * makefile.w32-in: Update dependencies.
11423 2011-03-17 Eli Zaretskii <eliz@gnu.org>
11425 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11427 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11429 Fix more problems found by GCC 4.5.2's static checks.
11431 * process.c (make_serial_process_unwind, send_process_trap):
11432 (sigchld_handler): Now static.
11434 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11435 That way, the code declares only the vars that it needs.
11436 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11437 * s/cygwin.h (PTY_ITERATION): Likewise.
11438 * s/darwin.h (PTY_ITERATION): Likewise.
11439 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11441 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11442 * process.c (allocate_pty): Don't declare stb unless it's needed.
11444 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
11445 (CONSTANTLIM): Remove; unused.
11446 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11447 Define only if needed.
11449 * unexelf.c (unexec): Name an expression,
11450 to avoid gcc -Wbad-function-cast warning.
11451 Use a different way to cause a compilation error if anyone uses
11452 n rather than nn, a way that does not involve shadowing.
11453 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
11455 * deps.mk (unexalpha.o): Remove; unused.
11457 New file unexec.h, the (simple) interface for unexec (Bug#8267).
11458 * unexec.h: New file.
11459 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11460 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11461 Depend on unexec.h.
11462 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11463 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11464 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
11465 Change as necessary to match prototype in unexec.h.
11467 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11469 (back_comment, skip_chars): Mark vars as initialized.
11471 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11472 Rename locals to avoid shadowing.
11474 * lread.c (read1): Rewrite so as not to use empty "else".
11475 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
11477 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11479 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11480 warning when compiling print.c.
11482 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11483 instead of using an uninitialized var.
11484 (font_sort_entities): Mark var as initialized.
11486 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11488 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11489 pointers to constants.
11490 (font_parse_fcname): Remove unused vars.
11491 (font_delete_unmatched): Now static.
11492 (font_get_spec): Remove; unused.
11493 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11494 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11495 Rename or move locals to avoid shadowing.
11497 * fns.c (require_nesting_list, require_unwind): Now static.
11498 (Ffillarray): Rename locals to avoid shadowing.
11500 * floatfns.c (domain_error2): Define only if needed.
11501 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
11503 * alloc.c (mark_backtrace): Move decl from here ...
11504 * lisp.h: ... to here, so that it can be checked.
11506 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
11507 (Fdefvar): Rewrite so as not to use empty "else".
11508 (lisp_indirect_variable): Name an expression,
11509 to avoid gcc -Wbad-function-cast warning.
11510 (Fdefvar): Rename locals to avoid shadowing.
11512 * callint.c (quotify_arg, quotify_args): Now static.
11513 (Fcall_interactively): Rename locals to avoid shadowing.
11514 Use const pointer when appropriate.
11516 * lisp.h (get_system_name, get_operating_system_release):
11517 Move decls here, to check interfaces.
11518 * process.c (get_operating_system_release): Move decl to lisp.h.
11519 * xrdb.c (get_system_name): Likewise.
11520 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11521 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11522 some of which prompt warnings from gcc -Wbad-function-cast.
11523 (Fformat_time_string, Fencode_time, Finsert_char):
11524 (Ftranslate_region_internal, Fformat):
11525 Rename or remove local vars to avoid shadowing.
11526 (Ftranslate_region_internal): Mark var as initialized.
11528 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11531 * lisp.h (eassert): Check that the argument compiles, even if
11532 ENABLE_CHECKING is not defined.
11534 * data.c (Findirect_variable): Name an expression, to avoid
11535 gcc -Wbad-function-cast warning.
11536 (default_value, arithcompare, arith_driver, arith_error): Now static.
11537 (store_symval_forwarding): Rename local to avoid shadowing.
11538 (Fmake_variable_buffer_local, Fmake_local_variable):
11539 Mark variables as initialized.
11540 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
11542 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
11543 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11544 Rename locals to avoid shadowing.
11545 (mark_stack): Move local variables into the #ifdef region where
11547 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11548 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11550 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11551 (GC_STRING_CHARS): Remove; not used.
11552 (Fmemory_limit): Cast sbrk's returned value to char *.
11554 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11555 avoids undefined behavior in theory.
11557 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11559 Use functions, not macros, for up- and down-casing (Bug#8254).
11560 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11561 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11562 to use the following functions instead of these macros.
11563 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11564 EMACS_INT, since callers assume the returned value fits in int.
11565 (upcase1): Likewise, for UPCASE_TABLE.
11566 (uppercasep, lowercasep, upcase): New static inline functions.
11567 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
11568 the race-condition problem in the old DOWNCASE.
11570 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11571 Rename locals to avoid shadowing.
11572 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
11573 (regex_compile, re_search_2, re_match_2_internal):
11574 Remove unused local vars.
11575 (FREE_VAR): Rewrite so as not to use empty "else",
11576 which gcc can warn about.
11577 (regex_compile, re_match_2_internal): Mark locals as initialized.
11578 (RETALLOC_IF): Define only if needed.
11579 (WORDCHAR_P): Likewise. This one is never needed, but is used
11580 only in a comment talking about a compiler bug, so put inside
11581 the #if 0 of that comment.
11582 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11583 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11586 * search.c (boyer_moore): Rename locals to avoid shadowing.
11587 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11588 (PREV_CHAR_BOUNDARY): Likewise.
11590 * search.c (simple_search): Remove unused var.
11592 * dired.c (compile_pattern): Move decl from here ...
11593 * lisp.h: ... to here, so that it can be checked.
11594 (struct re_registers): New forward decl.
11596 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11598 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11600 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11601 Rename locals to avoid shadowing.
11602 (Fvertical_motion): Mark locals as initialized.
11604 * casefiddle.c (casify_object, casify_region): Now static.
11605 (casify_region): Mark local as initialized.
11607 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11609 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11610 New macros, so that the caller can use some names other than
11611 gcpro1, gcpro2, etc.
11612 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11614 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11615 argument, for consistency with GCPRO2_VAR, etc: it is now the
11616 prefix of the variable, not the variable itself. All uses
11618 * dired.c (directory_files_internal, file_name_completion):
11619 Rename locals to avoid shadowing.
11621 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11622 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11623 dired.c's scmp function, had undefined behavior.
11624 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11625 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11626 * buffer.h: ... to here, because these macros use current_buffer,
11627 and the new implementation with inline functions needs to have
11628 current_buffer in scope now, rather than later when the macros
11630 (downcase, upcase1): New static inline functions.
11631 (DOWNCASE, UPCASE1): Reimplement using these functions.
11632 This avoids undefined behavior in expressions like
11633 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11634 from race conditions in accessing the global variables
11635 case_temp1 and case_temp2.
11636 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11637 * lisp.h (case_temp1, case_temp2): Remove their decls.
11638 * character.h (ASCII_CHAR_P): Move from here ...
11639 * lisp.h: ... to here, so that the inline functions mentioned
11640 above can use them.
11642 * dired.c (directory_files_internal_unwind): Now static.
11644 * fileio.c (file_name_as_directory, directory_file_name):
11645 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11647 (file_name_as_directory): Use const pointers when appropriate.
11648 (Fexpand_file_name): Likewise. In particular, newdir might
11649 point at constant storage, so make it a const pointer.
11650 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
11651 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11653 (Fset_file_times, Finsert_file_contents, auto_save_error):
11654 Rename locals to avoid shadowing.
11656 * minibuf.c (choose_minibuf_frame_1): Now static.
11657 (Ftry_completion, Fall_completions): Rename or remove locals
11658 to avoid shadowing.
11660 * marker.c (bytepos_to_charpos): Remove; unused.
11662 * lisp.h (verify_bytepos, count_markers): New decls,
11663 so that gcc does not warn that these functions aren't declared.
11665 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11666 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
11667 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
11668 (copy_text): Remove unused local var.
11670 * filelock.c (within_one_second): Now static.
11671 (lock_file_1): Rename local to avoid shadowing.
11673 * buffer.c (fix_overlays_before): Mark locals as initialized.
11674 (fix_start_end_in_overlays): Likewise. This function should be
11675 simplified by using pointers-to-pointers, but that's a different
11677 (switch_to_buffer_1): Now static.
11678 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11679 (report_overlay_modification): Rename locals to avoid shadowing.
11681 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
11682 Fix pointer signedness issue.
11683 (sys_subshell): Mark local as volatile if checking for lint,
11684 to suppress a gcc -Wclobbered warning that does not seem to be right.
11685 (MAXPATHLEN): Define only if needed.
11687 * process.c (serial_open, serial_configure): Move decls from here ...
11688 * systty.h: ... to here, so that they can be checked.
11690 * fns.c (get_random, seed_random): Move extern decls from here ...
11691 * lisp.h: ... to here, so that they can be checked.
11693 * sysdep.c (reset_io): Now static.
11694 (wait_for_termination_signal): Remove; unused.
11696 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11697 (copy_keymap_item, append_key, push_text_char_description):
11699 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
11700 (DENSE_TABLE_SIZE): Remove; unused.
11701 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11702 (describe_map_tree):
11703 Rename locals to avoid shadowing.
11705 * keyboard.c: Declare functions static if they are not used elsewhere.
11706 (echo_char, echo_dash, cmd_error, top_level_2):
11707 (poll_for_input, handle_async_input): Now static.
11708 (read_char, kbd_buffer_get_event, make_lispy_position):
11709 (make_lispy_event, make_lispy_movement, apply_modifiers):
11710 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11711 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11712 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
11713 (read_key_sequence, read_char): Mark locals as initialized.
11714 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
11716 * keyboard.h (make_ctrl_char): New decl.
11717 (mark_kboards): Move decl here ...
11718 * alloc.c (mark_kboards): ... from here.
11720 * lisp.h (force_auto_save_soon): New decl.
11722 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
11723 (DEFINE_DUMMY_FUNCTION): New macro.
11724 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11726 (main): Add casts to avoid warnings
11727 if GCC considers string literals to be constants.
11729 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11731 * dbusbind.c: Pointer signedness fixes.
11732 (xd_signature, xd_append_arg, xd_initialize):
11733 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11734 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11735 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11736 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11738 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11739 if GCC considers string literals to be constants.
11740 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
11742 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11744 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11745 (print_preprocess, print_object): New macro to fix last change.
11747 * print.c (print_preprocess): Don't forget font objects.
11749 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
11751 * emacs.c (USAGE3): Doc fixes.
11753 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11755 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11758 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
11760 * lisp.h (VWindow_system, Qfile_name_history):
11761 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11762 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11763 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11765 * w32select.c: Don't #include "keyboard.h".
11766 (run_protected): Add extern declaration for waiting_for_input.
11768 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11769 * w32console.c (detect_input_pending, read_input_pending)
11770 (encode_terminal_code):
11771 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11772 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11773 (w32_system_caret_y, Qfile_name_history):
11774 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11775 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11776 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11777 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11778 * w32proc.c (Qlocal, report_file_error):
11779 * w32term.c (Vwindow_system, updating_frame):
11780 * w32uniscribe.c (initialized, uniscribe_font_driver):
11781 Remove unneeded extern declarations.
11783 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
11785 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
11787 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
11789 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11790 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11791 These macros can no longer be used for assignment.
11793 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11794 Assign struct members directly, instead of using BUF_BEGV etc.
11795 (record_buffer_markers, fetch_buffer_markers): New functions for
11796 recording and fetching special buffer markers.
11797 (set_buffer_internal_1, set_buffer_temp): Use them.
11799 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11801 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11803 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11804 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11806 * xdisp.c (hscroll_window_tree):
11807 (reconsider_clip_changes): Use PT instead of BUF_PT.
11809 2011-03-13 Eli Zaretskii <eliz@gnu.org>
11811 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11812 $(EMACS_ROOT)/lib/intprops.h.
11814 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11816 Fix more problems found by GCC 4.5.2's static checks.
11818 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11819 to unsigned char * to avoid compiler diagnostic.
11820 (xg_free_frame_widgets): Make it clear that a local variable is
11821 needed only if USE_GTK_TOOLTIP.
11822 (gdk_window_get_screen): Make it clear that this macro is needed
11823 only if USE_GTK_TOOLTIP.
11824 (int_gtk_range_get_value): New function, which avoids a diagnostic
11825 from gcc -Wbad-function-cast.
11826 (xg_set_toolkit_scroll_bar_thumb): Use it.
11827 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11828 diagnostic from gcc -Wbad-function-cast.
11829 (get_utf8_string, xg_get_file_with_chooser):
11830 Rename locals to avoid shadowing.
11831 (create_dialog): Move locals to avoid shadowing.
11833 * xgselect.c (xg_select): Remove unused var.
11835 * image.c (four_corners_best): Mark locals as initialized.
11836 (gif_load): Initialize transparent_p to zero (Bug#8238).
11837 Mark another local as initialized.
11838 (my_png_error, my_error_exit): Mark with NO_RETURN.
11840 * image.c (clear_image_cache): Now static.
11841 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
11842 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
11843 (x_edge_detection): Remove unnecessary cast that
11844 gcc -Wbad-function-cast diagnoses.
11845 (gif_load): Fix pointer signedness.
11846 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11847 (jpeg_load, gif_load): Rename locals to avoid shadowing.
11849 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
11851 Improve quality of tests for time stamp overflow.
11852 For example, without this patch (encode-time 0 0 0 1 1
11853 1152921504606846976) returns the obviously-bogus value (-948597
11854 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11855 reports time overflow. See
11856 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
11857 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11858 * editfns.c: Include limits.h and intprops.h.
11859 (TIME_T_MIN, TIME_T_MAX): New macros.
11860 (time_overflow): Move earlier, to before first use.
11861 (hi_time, lo_time): New functions, for an accurate test for
11862 out-of-range times.
11863 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11864 (Fget_internal_run_time): Don't assume time_t fits in int.
11865 (make_time): Use list2 instead of Fcons twice.
11866 (Fdecode_time): More accurate test for out-of-range times.
11867 (check_tm_member): New function.
11868 (Fencode_time): Use it, to test for out-of-range times.
11869 (lisp_time_argument): Don't rely on undefined left-shift and
11870 right-shift behavior when checking for time stamp overflow.
11872 * editfns.c (time_overflow): New function, refactoring common code.
11873 (Fformat_time_string, Fdecode_time, Fencode_time):
11874 (Fcurrent_time_string): Use it.
11876 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11877 * dired.c (make_time): Move to ...
11878 * editfns.c (make_time): ... here.
11879 * systime.h: Note the move.
11881 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11883 * fringe.c (update_window_fringes): Remove unused variables.
11885 * unexmacosx.c (copy_data_segment): Also copy __got section.
11888 2011-03-12 Eli Zaretskii <eliz@gnu.org>
11890 * termcap.c [MSDOS]: Include "msdos.h".
11891 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11892 Constify `char *' arguments and their references according to
11893 prototypes in tparam.h.
11895 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
11897 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11898 Adapt all references accordingly.
11900 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11902 2011-03-11 Tom Tromey <tromey@redhat.com>
11904 * buffer.c (syms_of_buffer): Remove obsolete comment.
11906 2011-03-11 Eli Zaretskii <eliz@gnu.org>
11908 * termhooks.h (encode_terminal_code): Declare prototype.
11910 * msdos.c (encode_terminal_code): Don't declare prototype.
11912 * term.c (encode_terminal_code): Now external again, used by
11913 w32console.c and msdos.c.
11915 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11916 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
11918 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
11920 Fix some minor problems found by GCC 4.5.2's static checks.
11922 * fringe.c (update_window_fringes): Mark locals as initialized
11924 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
11926 * alloc.c (mark_fringe_data): Move decl from here ...
11927 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11928 to check its interface.
11929 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11931 * fontset.c (free_realized_fontset): Now static.
11932 (Fset_fontset_font): Rename local to avoid shadowing.
11933 (fontset_font): Mark local as initialized.
11934 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
11936 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11938 * xselect.c (x_disown_buffer_selections): Remove; not used.
11939 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
11940 (x_own_selection, Fx_disown_selection_internal): Rename locals
11941 to avoid shadowing.
11942 (x_handle_dnd_message): Remove local to avoid shadowing.
11944 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11945 so that the caller can use some name other than gcpro1.
11946 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
11947 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11948 (Fx_backspace_delete_keys_p):
11949 Use them to avoid shadowing, and rename vars to avoid shadowing.
11950 (x_decode_color, x_set_name, x_window): Now static.
11951 (Fx_create_frame): Add braces to silence GCC warning.
11952 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
11953 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11954 Remove unused locals.
11955 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11956 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11957 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11960 * xterm.h (x_mouse_leave): New decl.
11962 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11963 Remove unused functions.
11964 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11965 (x_calc_absolute_position): Now static.
11966 (XTread_socket): Don't define label "out" unless it's used.
11967 Don't declare local "event" unless it's used.
11968 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11969 unless they are used.
11970 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11971 (x_fatal_error_signal): Remove; not used.
11972 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11973 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11974 (x_error_catcher, x_connection_closed, x_error_handler):
11975 (x_error_quitter, xembed_send_message, x_iconify_frame):
11976 (my_log_handler): Rename locals to avoid shadowing.
11977 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
11978 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
11980 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11981 Rename or move locals to avoid shadowing.
11982 (tty_defined_color, merge_face_heights): Now static.
11983 (free_realized_faces_for_fontset): Remove; not used.
11984 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11985 does not deduce is never used uninitialized.
11986 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11987 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
11989 * terminal.c (store_terminal_param): Now static.
11991 * xmenu.c (menu_highlight_callback): Now static.
11992 (set_frame_menubar): Remove unused local.
11993 (xmenu_show): Rename parameter to avoid shadowing.
11994 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11995 since they might point to immutable storage.
11996 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11997 since it's unused otherwise.
11999 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
12000 Add a FIXME, since the code still doesn't look right. (Bug#8215)
12001 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12002 avoids a gcc -Wuninitialized diagnostic.
12003 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
12004 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12005 does not deduce are never used uninitialized.
12007 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12009 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
12010 * window.c (window_loop, size_window):
12011 (run_window_configuration_change_hook, enlarge_window): Likewise.
12013 * window.c (display_buffer): Now static.
12014 (size_window): Mark variables that gcc -Wuninitialized
12015 does not deduce are never used uninitialized.
12016 * window.h (check_all_windows): New decl, to forestall
12017 gcc -Wmissing-prototypes diagnostic.
12018 * dispextern.h (bidi_dump_cached_states): Likewise.
12020 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12022 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
12023 Include <limits.h>.
12024 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12025 and to avoid gcc -Wuninitialized warning.
12026 (load_charset_map): Mark variables that gcc -Wuninitialized
12027 does not deduce are never used uninitialized.
12028 (load_charset): Abort instead of using uninitialized var (Bug#8229).
12030 * coding.c (coding_set_source, coding_set_destination):
12031 Use "else { /* comment */ }" rather than "else /* comment */;"
12032 for clarity, and to avoid gcc -Wempty-body warning.
12033 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12034 a block, when the outer 'i' will do.
12035 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12036 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12037 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12038 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12039 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12040 Rename locals to avoid shadowing.
12041 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
12042 * coding.c (emacs_mule_char, encode_invocation_designation):
12043 Now static, since they're not used elsewhere.
12044 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
12045 (decode_coding_object, encode_coding_object, detect_coding_system):
12046 (decode_coding_emacs_mule): Mark variables that gcc
12047 -Wuninitialized does not deduce are never used uninitialized.
12048 (detect_coding_iso_2022): Initialize a local variable that might
12049 be used uninitialized. Leave a FIXME because it's not clear that
12050 this initialization is needed. (Bug#8211)
12051 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12052 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12053 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12054 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12055 Remove unused macros.
12057 * category.c (hash_get_category_set): Remove unused local var.
12058 (copy_category_table): Now static, since it's not used elsewhere.
12059 * character.c (string_count_byte8): Likewise.
12061 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12062 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12064 * chartab.c (copy_sub_char_table): Now static, since it's not used
12066 (sub_char_table_ref_and_range, char_table_ref_and_range):
12067 Rename locals to avoid shadowing.
12068 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
12070 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
12071 (BIDI_BOB): Remove unused macro.
12073 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12074 deduce are never used uninitialized.
12075 * term.c (encode_terminal_code): Likewise.
12077 * term.c (encode_terminal_code): Now static. Remove unused local.
12079 * tparam.h: New file.
12080 * term.c, tparam.h: Include it.
12081 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12082 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12083 Move these decls to tparam.h, and make them agree with what
12084 is actually in tparam.c. The previous trick of using incompatible
12085 decls in different modules does not conform to the C standard.
12086 All callers of tparam changed to use tparam's actual API.
12087 * tparam.c (tparam1, tparam, tgoto):
12088 Use const pointers where appropriate.
12090 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12091 * cm.h (struct cm): Likewise.
12092 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12093 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12094 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12095 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12096 (turn_on_face, init_tty): Likewise.
12097 * termchar.h (struct tty_display_info): Likewise.
12099 * term.c (term_mouse_position): Rename local to avoid shadowing.
12101 * alloc.c (mark_ttys): Move decl from here ...
12102 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12104 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12106 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12108 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
12110 * search.c (compile_pattern_1): Remove argument regp, unused since
12111 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12112 (compile_pattern): Don't pass it.
12114 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12116 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12117 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12119 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12121 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12123 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12124 gdk_window_get_screen, gdk_window_get_geometry,
12125 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12126 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12127 (xg_get_pixbuf_from_pixmap): New function.
12128 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12129 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12130 Call xg_get_pixbuf_from_pixmap instead of
12131 gdk_pixbuf_get_from_drawable.
12132 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12133 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12134 (xg_check_special_colors): Use GtkStyleContext and its functions
12136 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12137 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12138 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
12139 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12140 Call gtk_widget_get_preferred_size.
12141 (xg_frame_resized): gdk_window_get_geometry only takes 5
12143 (xg_win_to_widget, xg_event_is_for_menubar):
12144 Call gdk_x11_window_lookup_for_display.
12145 (xg_set_widget_bg): New function.
12146 (delete_cb): New function.
12147 (xg_create_frame_widgets): Connect delete-event to delete_cb.
12148 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
12149 (xg_set_background_color): Call xg_set_widget_bg.
12150 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12151 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12152 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12153 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12155 (update_frame_tool_bar): Call gtk_widget_hide.
12156 (xg_initialize): Use GDK_KEY_g.
12158 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12160 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12162 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12163 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12164 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12166 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
12168 * w32xfns.c (select_palette): Check success of RealizePalette against
12169 GDI_ERROR, not zero.
12171 See ChangeLog.11 for earlier changes.
12173 ;; Local Variables:
12177 Copyright (C) 2011-2012 Free Software Foundation, Inc.
12179 This file is part of GNU Emacs.
12181 GNU Emacs is free software: you can redistribute it and/or modify
12182 it under the terms of the GNU General Public License as published by
12183 the Free Software Foundation, either version 3 of the License, or
12184 (at your option) any later version.
12186 GNU Emacs is distributed in the hope that it will be useful,
12187 but WITHOUT ANY WARRANTY; without even the implied warranty of
12188 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12189 GNU General Public License for more details.
12191 You should have received a copy of the GNU General Public License
12192 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.