Remove list-processes C function; misc fixes to last change.
[bpt/emacs.git] / src / ChangeLog
1 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
2
3 * process.c (Flist_processes): Removed to Lisp.
4 (list_processes_1): Deleted.
5
6 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7
8 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
9
10 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11
12 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
13
14 Fix more problems found by GCC 4.6.0's static checks.
15
16 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
17
18 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
19
20 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
21
22 * xdisp.c (vmessage): Mark as a printf-like function.
23
24 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
25
26 * sound.c (sound_warning): Don't crash if arg contains a printf format.
27
28 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
29 printf-like functions.
30 (tiff_load): Add casts to remove these marks before passing them
31 to system-supplied API.
32
33 * eval.c (Fsignal): Remove excess argument to 'fatal'.
34
35 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
36 This avoids several warnings with gcc -Wstrict-overflow.
37 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
38 directly, rather than having caller test rule sign. This avoids
39 some unnecessary tests.
40 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
41 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
42 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
43
44 * xfont.c (xfont_text_extents): Remove var that was set but not used.
45 (xfont_open): Avoid unnecessary tests.
46
47 * composite.c (composition_gstring_put_cache): Use unsigned integer.
48
49 * composite.h, composite.c (composition_gstring_put_cache):
50 Use EMACS_INT, not int, for length.
51
52 * composite.h (COMPOSITION_DECODE_REFS): New macro,
53 breaking out part of COMPOSITION_DECODE_RULE.
54 (COMPOSITION_DECODE_RULE): Use it.
55 * composite.c (get_composition_id): Remove unused local vars,
56 by using the new macro.
57
58 * textprop.c (set_text_properties_1): Change while to do-while,
59 since the condition is always true at first.
60
61 * intervals.c (graft_intervals_into_buffer): Mark var as used.
62 (interval_deletion_adjustment): Return unsigned value.
63 All uses changed.
64
65 * process.c (list_processes_1, create_pty, read_process_output):
66 (exec_sentinel): Remove vars that were set but not used.
67 (create_pty): Remove unnecessary "volatile"s.
68 (Fnetwork_interface_info): Avoid possibility of int overflow.
69 (read_process_output): Do adaptive read buffering even if carryover.
70 (read_process_output): Simplify nbytes computation if buffered.
71
72 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
73
74 * syntax.c (scan_words): Remove var that was set but not used.
75 (update_syntax_table): Use unsigned instead of int.
76
77 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
78 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
79 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
80
81 * print.c (print_error_message): Avoid int overflow.
82
83 * font.c (font_list_entities): Redo for clarity,
84 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
85
86 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
87 (font_score): Avoid potential overflow in diff calculation.
88
89 * fns.c (substring_both): Remove var that is set but not used.
90 (sxhash): Redo loop for clarity and to avoid wraparound warning.
91
92 * eval.c (funcall_lambda): Rename local to avoid shadowing.
93
94 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
95 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
96 can always succeed if overflow has undefined behavior.
97
98 * search.c (boyer_moore, wordify): Remove vars set but not used.
99 (wordify): Omit three unnecessary tests.
100
101 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
102 All callers changed. This avoids the need for an unused var.
103
104 * casefiddle.c (casify_region): Remove var that is set but not used.
105
106 * dired.c (file_name_completion): Remove var that is set but not used.
107
108 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
109
110 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
111 (Finsert_file_contents): Remove unnecessary code checking fd.
112
113 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
114 Check for integer overflow on size calculations.
115
116 * buffer.c (Fprevious_overlay_change): Remove var that is set
117 but not used.
118
119 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
120 Remove vars that are set but not used.
121 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
122 (timer_check_2): Mark vars as initialized.
123
124 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
125
126 * image.c (lookup_image): Remove var that is set but not used.
127 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
128
129 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
130 that are set but not used.
131
132 * xfns.c (make_invisible_cursor): Don't return garbage
133 if XCreateBitmapFromData fails (Bug#8410).
134
135 * xselect.c (x_get_local_selection, x_handle_property_notify):
136 Remove vars that are set but not used.
137
138 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
139 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
140
141 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
142 Remove var that is set but not used.
143 (scroll_bar_windows_size): Now size_t, not int.
144 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
145 Check for overflow.
146
147 * xfaces.c (realize_named_face): Remove vars that are set but not used.
148 (map_tty_color) [!defined MSDOS]: Likewise.
149
150 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
151
152 * coding.c: Remove vars that are set but not used.
153 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
154 All callers changed.
155 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
156 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
157 (decode_coding_charset): Remove vars that are set but not used.
158
159 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
160 that is set but not used.
161
162 * print.c (print_object): Remove var that is set but not used.
163
164 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
165 The gnulib version avoids calling malloc in the usual case,
166 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
167 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
168 * filelock.c (current_lock_owner): Likewise.
169 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
170 * sysdep.c: Include allocator.h, careadlinkat.h.
171 (emacs_no_realloc_allocator): New static constant.
172 (emacs_readlink): New function.
173 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
174 ../lib/careadlinkat.h.
175
176 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
177
178 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
179 first non-nil return value).
180
181 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
182
183 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
184 if not defined (Bug#8403).
185
186 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
187
188 * xdisp.c (display_count_lines): Remove parameter `start',
189 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
190 (get_char_face_and_encoding): Remove parameter `multibyte_p',
191 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
192 (fill_stretch_glyph_string): Remove parameters `row' and `area',
193 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
194 and thereabouts. All callers changed.
195 (get_per_char_metric): Remove parameter `f', unused since
196 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
197
198 2011-04-02 Jim Meyering <meyering@redhat.com>
199
200 do not dereference NULL upon failed strdup
201 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
202 (ns_get_family): Likewise.
203
204 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
205
206 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
207
208 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
209
210 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
211 later (Bug#8403).
212
213 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
214
215 Add lexical binding.
216
217 * window.c (Ftemp_output_buffer_show): New fun.
218 (Fsave_window_excursion):
219 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
220
221 * lread.c (lisp_file_lexically_bound_p): New function.
222 (Fload): Bind Qlexical_binding.
223 (readevalloop): Remove `evalfun' arg.
224 Bind Qinternal_interpreter_environment.
225 (Feval_buffer): Bind Qlexical_binding.
226 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
227 Mark as dynamic.
228 (syms_of_lread): Declare `lexical-binding'.
229
230 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
231
232 * keyboard.c (eval_dyn): New fun.
233 (menu_item_eval_property): Use it.
234
235 * image.c (parse_image_spec): Use Ffunctionp.
236
237 * fns.c (concat, mapcar1): Accept byte-code-functions.
238
239 * eval.c (Fsetq): Handle lexical vars.
240 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
241 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
242 (FletX, Flet): Obey lexical binding.
243 (Fcommandp): Handle closures.
244 (Feval): New `lexical' arg.
245 (eval_sub): New function extracted from Feval. Use it almost
246 everywhere where Feval was used. Look up vars in lexical env.
247 Handle closures.
248 (Ffunctionp): Move from subr.el.
249 (Ffuncall): Handle closures.
250 (apply_lambda): Remove `eval_flags'.
251 (funcall_lambda): Handle closures and new byte-code-functions.
252 (Fspecial_variable_p): New function.
253 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
254 but without exporting it to Lisp.
255
256 * doc.c (Fdocumentation, store_function_docstring):
257 * data.c (Finteractive_form): Handle closures.
258
259 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
260 interactive spec.
261
262 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
263 byte-codes.
264 (exec_byte_code): New function extracted from Fbyte_code to handle new
265 calling convention for byte-code-functions. Add new byte-codes.
266
267 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
268
269 * alloc.c (Fmake_symbol): Init new `declared_special' field.
270
271 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
272
273 * xdisp.c (redisplay_internal): Fix prototype.
274
275 2011-03-31 Eli Zaretskii <eliz@gnu.org>
276
277 * xdisp.c (SCROLL_LIMIT): New macro.
278 (try_scrolling): Use it when setting scroll_limit. Limit
279 scrolling to 100 screen lines.
280 (redisplay_window): Even when falling back on "recentering",
281 position point in the window according to scroll-conservatively,
282 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
283
284 (try_scrolling): When point is above the window, allow searching
285 as far as scroll_max, or one screenful, to compute vertical
286 distance from PT to the scroll margin position. This prevents
287 try_scrolling from unnecessarily failing when
288 scroll-conservatively is set to a value slightly larger than the
289 window height. Clean up the case of PT below the margin at bottom
290 of window: scroll_max can no longer be INT_MAX. When aggressive
291 scrolling is in use, don't let point enter the opposite scroll
292 margin as result of the scroll.
293 (syms_of_xdisp) <scroll-conservatively>: Document the
294 threshold of 100 lines for never-recentering scrolling.
295
296 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
297
298 * dispextern.h (move_it_by_lines):
299 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
300 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
301 (message_log_check_duplicate): Remove parameters `prev_bol' and
302 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
303 (redisplay_internal): Remove parameter `preserve_echo_area',
304 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
305
306 * indent.c (Fvertical_motion):
307 * window.c (window_scroll_pixel_based, Frecenter):
308 Don't pass `need_y_p' to `move_it_by_lines'.
309
310 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
311
312 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
313 steal a few bits to be more compact.
314 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
315 Remove unneeded casts.
316
317 * bytecode.c (Fbyte_code): CAR and CDR can GC.
318
319 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
320
321 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
322 binding" message (bug#7967).
323
324 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
325
326 Fix more problems found by GCC 4.6.0's static checks.
327
328 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
329 Remove unused local var.
330
331 * editfns.c (Fmessage_box): Remove unused local var.
332
333 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
334 (note_mode_line_or_margin_highlight, note_mouse_highlight):
335 Omit unused local vars.
336 * window.c (shrink_windows): Omit unused local var.
337 * menu.c (digest_single_submenu): Omit unused local var.
338 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
339 Omit unused local var.
340
341 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
342 Don't assume string length fits in int.
343 (keyremap_step, read_key_sequence): Use size_t for sizes.
344 (read_key_sequence): Don't check last_real_key_start redundantly.
345
346 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
347 instead of alloca (Bug#8344).
348
349 * eval.c (Fbacktrace): Don't assume nargs fits in int.
350 (Fbacktrace_frame): Don't assume nframes fits in int.
351
352 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
353
354 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
355 concerns.
356
357 * term.c (produce_glyphless_glyph): Remove unnecessary test.
358
359 * cm.c (calccost): Turn while-do into do-while, for clarity.
360
361 * keyboard.c (syms_of_keyboard): Use the same style as later
362 in this function when indexing through an array. This also
363 works around GCC bug 48267.
364
365 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
366
367 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
368
369 * chartab.c (sub_char_table_ref_and_range): Redo for slight
370 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
371
372 * keyboard.c, keyboard.h (num_input_events): Now size_t.
373 This avoids undefined behavior on integer overflow, and is a bit
374 more convenient anyway since it is compared to a size_t variable.
375
376 Variadic C functions now count arguments with size_t, not int.
377 This avoids an unnecessary limitation on 64-bit machines, which
378 caused (substring ...) to crash on large vectors (Bug#8344).
379 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
380 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
381 All variadic functions and their callers changed accordingly.
382 (struct gcpro.nvars): Now size_t, not int. All uses changed.
383 * data.c (arith_driver, float_arith_driver): Likewise.
384 * editfns.c (general_insert_function): Likewise.
385 * eval.c (struct backtrace.nargs, interactive_p)
386 (internal_condition_case_n, run_hook_with_args, apply_lambda)
387 (funcall_lambda, mark_backtrace): Likewise.
388 * fns.c (concat): Likewise.
389 * frame.c (x_set_frame_parameters): Likewise.
390 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
391 0 if not found, not -1. All callers changed.
392
393 * alloc.c (garbage_collect): Don't assume stack size fits in int.
394 (stack_copy_size): Now size_t, not int.
395 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
396
397 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
398
399 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
400 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
401 All callers changed.
402
403 * lisp.h (multibyte_char_to_unibyte):
404 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
405 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
406 * character.h (CHAR_TO_BYTE8):
407 * cmds.c (internal_self_insert):
408 * editfns.c (general_insert_function):
409 * keymap.c (push_key_description):
410 * search.c (Freplace_match):
411 * xdisp.c (message_dolog, set_message_1): All callers changed.
412
413 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
414
415 * keyboard.c (safe_run_hook_funcall): New function.
416 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
417 don't set the hook to nil, but remove the offending function instead.
418 (Qcommand_hook_internal): Remove, unused.
419 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
420 Vcommand_hook_internal.
421
422 * eval.c (enum run_hooks_condition): Remove.
423 (funcall_nil, funcall_not): New functions.
424 (run_hook_with_args): Call each function through a `funcall' argument.
425 Remove `cond' argument, now redundant.
426 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
427 (Frun_hook_with_args_until_failure): Adjust accordingly.
428 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
429
430 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
431
432 * dispextern.h (string_buffer_position): Remove declaration.
433
434 * print.c (strout): Remove parameter `multibyte', unused since
435 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
436
437 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
438 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
439 All callers changed.
440
441 * w32.c (_wsa_errlist): Use braces for struct initializers.
442
443 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
444 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
445 All callers changed.
446 (string_buffer_position): Likewise. Also, make static (it's never
447 used outside xdisp.c).
448 (cursor_row_p): Remove parameter `w', unused since
449 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
450 (decode_mode_spec): Remove parameter `precision', introduced during
451 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
452 All callers changed.
453
454 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
455
456 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
457
458 2011-03-27 Anders Lindgren <andlind@gmail.com>
459
460 * nsterm.m (ns_menu_bar_is_hidden): New variable.
461 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
462 (ns_update_auto_hide_menu_bar): New functions.
463 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
464 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
465 ns_constrain_all_frames.
466 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
467 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
468
469 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
470
471 * nsmenu.m (runDialogAt): Remove argument to timer_check.
472
473 2011-03-27 Glenn Morris <rgm@gnu.org>
474
475 * syssignal.h: Replace RETSIGTYPE with void.
476 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
477 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
478 Replace SIGTYPE with void everywhere.
479 * s/usg5-4-common.h (SIGTYPE): Remove definition.
480 * s/template.h (SIGTYPE): Remove commented out definition.
481
482 2011-03-26 Eli Zaretskii <eliz@gnu.org>
483
484 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
485 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
486
487 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
488
489 * w32.c (read_unc_volume): Use parameter `henum', instead of
490 global variable `wget_enum_handle'.
491
492 * keymap.c (describe_vector): Remove parameters `indices' and
493 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
494 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
495
496 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
497
498 * keyboard.c (timer_check): Remove parameter `do_it_now',
499 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
500 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
501 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
502
503 * keyboard.c (read_char):
504 * w32menu.c (w32_menu_display_help):
505 * xmenu.c (show_help_event, menu_help_callback):
506 Adjust calls to `show_help_echo'.
507
508 * gtkutil.c (xg_maybe_add_timer):
509 * keyboard.c (readable_events):
510 * process.c (wait_reading_process_output):
511 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
512
513 * insdel.c (adjust_markers_gap_motion):
514 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
515 (gap_left, gap_right): Don't call it.
516
517 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
518
519 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
520 incurred during fontification.
521
522 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
523
524 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
525 (DEFVAR_PER_BUFFER): Don't pass it.
526
527 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
528 (scrolling_window): Don't pass it.
529
530 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
531
532 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
533
534 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
535 and `suffix'.
536 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
537 of variables specific to SELinux and computation of `encoded_absname'.
538
539 * image.c (XPutPixel): Remove unused variable `height'.
540
541 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
542
543 * unexw32.c (get_section_info): Remove unused variable `section'.
544
545 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
546 (system_process_attributes): Remove unused variable `sess'.
547 (sys_read): Remove unused variable `err'.
548
549 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
550 (w32_wnd_proc): Remove unused variable `isdead'.
551 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
552 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
553 (x_create_tip_frame): Remove unused variable `tem'.
554
555 * w32inevt.c (w32_console_read_socket):
556 Remove unused variable `no_events'.
557
558 * w32term.c (x_draw_composite_glyph_string_foreground):
559 Remove unused variable `width'.
560
561 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
562
563 * w32term.c (x_set_glyph_string_clipping):
564 Don't pass uninitialized region to CombineRgn.
565
566 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
567
568 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
569 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
570 (Fx_close_connection): Remove unused variable `i'.
571
572 * w32font.c (w32font_draw): Return number of glyphs.
573 (w32font_open_internal): Remove unused variable `i'.
574 (w32font_driver): Add missing initializer.
575
576 * w32menu.c (utf8to16): Remove unused variable `utf16'.
577 (fill_in_menu): Remove unused variable `items_added'.
578
579 * w32term.c (last_mouse_press_frame): Remove static global variable.
580 (w32_clip_to_row): Remove unused variable `f'.
581 (x_delete_terminal): Remove unused variable `i'.
582
583 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
584 (NOTHING): Remove unused static global variable.
585 (uniscribe_check_otf): Remove unused variable `table'.
586 (uniscribe_font_driver): Add missing initializers.
587
588 2011-03-23 Julien Danjou <julien@danjou.info>
589
590 * term.c (Fsuspend_tty, Fresume_tty):
591 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
592 * window.c (temp_output_buffer_show):
593 * insdel.c (signal_before_change):
594 * frame.c (Fhandle_switch_frame):
595 * fileio.c (Fdo_auto_save):
596 * emacs.c (Fkill_emacs):
597 * editfns.c (save_excursion_restore):
598 * cmds.c (internal_self_insert):
599 * callint.c (Fcall_interactively):
600 * buffer.c (Fkill_all_local_variables):
601 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
602 Use Frun_hooks.
603 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
604 unconditionnaly since it does the check itself.
605
606 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
607
608 Fix more problems found by GCC 4.5.2's static checks.
609
610 * coding.c (encode_coding_raw_text): Avoid unnecessary test
611 the first time through the loop, since we know p0 < p1 then.
612 This also avoids a gcc -Wstrict-overflow warning.
613
614 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
615 leading to a memory leak, possible in functions like
616 load_charset_map_from_file that can allocate an unbounded number
617 of objects (Bug#8318).
618
619 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
620 that could (at least in theory) be that large.
621
622 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
623 This is less likely to overflow, and avoids undefined behavior if
624 overflow does occur. All callers changed. Use strtoul to scan
625 for the unsigned long integer.
626 (pint2hrstr): Simplify and tune code slightly.
627 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
628
629 * scroll.c (do_scrolling): Work around GCC bug 48228.
630 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
631
632 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
633 This also avoids a warning with gcc -Wstrict-overflow.
634 (validate_x_resource_name): Simplify count usage.
635 This also avoids a warning with gcc -Wstrict-overflow.
636
637 * fileio.c (Fcopy_file): Report error if fchown or fchmod
638 fail (Bug#8306).
639
640 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
641
642 * process.c (Fmake_network_process): Use socklen_t, not int,
643 where POSIX says socklen_t is required in portable programs.
644 This fixes a porting bug on hosts like 64-bit HP-UX, where
645 socklen_t is wider than int (Bug#8277).
646 (Fmake_network_process, server_accept_connection):
647 (wait_reading_process_output, read_process_output):
648 Likewise.
649
650 * process.c: Rename or move locals to avoid shadowing.
651 (list_processes_1, Fmake_network_process):
652 (read_process_output_error_handler, exec_sentinel_error_handler):
653 Rename or move locals.
654 (Fmake_network_process): Define label "retry_connect" only if needed.
655 (Fnetwork_interface_info): Fix pointer signedness.
656 (process_send_signal): Add cast to avoid pointer signedness problem.
657 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
658 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
659
660 Make tparam.h and terminfo.c consistent.
661 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
662 Include tparam.h instead, since it declares them.
663 * cm.h (PC): Remove extern decl; tparam.h now does this.
664 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
665 * terminfo.c: Include tparam.h, to check interfaces.
666 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
667 (tparam): Adjust signature to match interface in tparam.h;
668 this removes some undefined behavior. Check that outstring and len
669 are zero, which they always are with Emacs.
670 * tparam.h (PC, BC, UP): New extern decls.
671
672 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
673 (xftfont_open): Rename locals to avoid shadowing.
674
675 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
676 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
677 (OTF_TAG_SYM): Omit macro if not needed.
678 (ftfont_list): Remove unused local.
679 (get_adstyle_property, ftfont_pattern_entity):
680 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
681 Rename locals to avoid shadowing.
682
683 * xfont.c (xfont_list_family): Mark var as initialized.
684
685 * xml.c (make_dom): Now static.
686
687 * composite.c (composition_compute_stop_pos): Rename local to
688 avoid shadowing.
689 (composition_reseat_it): Remove unused locals.
690 (find_automatic_composition, composition_adjust_point): Likewise.
691 (composition_update_it): Mark var as initialized.
692 (find_automatic_composition): Mark vars as initialized,
693 with a FIXME (Bug#8290).
694
695 character.h: Rename locals to avoid shadowing.
696 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
697 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
698 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
699 (BUF_DEC_POS): Be more systematic about renaming local temporaries
700 to avoid shadowing.
701
702 * textprop.c (property_change_between_p): Remove; unused.
703
704 * intervals.c (interval_start_pos): Now static.
705
706 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
707
708 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
709 Rename locals to avoid shadowing.
710
711 * sound.c (wav_play, au_play, Fplay_sound_internal):
712 Fix pointer signedness.
713 (alsa_choose_format): Remove unused local var.
714 (wav_play): Initialize a variable to 0, to prevent undefined
715 behavior (Bug#8278).
716
717 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
718
719 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
720
721 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
722 clobbering (Bug#8298).
723 * sysdep.c (sys_subshell): Likewise.
724 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
725
726 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
727 This should get cleaned up, so that child_setup has the
728 same signature on all platforms.
729
730 * callproc.c (call_process_cleanup): Now static.
731 (relocate_fd): Rename locals to avoid shadowing.
732
733 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
734
735 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
736 not to be necessary, and produces flickering.
737
738 2011-03-20 Glenn Morris <rgm@gnu.org>
739
740 * config.in: Remove file.
741
742 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
743
744 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
745 are now in src/globals.h.
746 (syms_of_minibuf): Remove spurious & from previous change.
747
748 2011-03-20 Leo <sdl.web@gmail.com>
749
750 * minibuf.c (completing-read-function): New variable.
751 (completing-read-default): Rename from completing-read.
752 (completing-read): Call completing-read-function.
753
754 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
755
756 * xfaces.c (Fx_load_color_file):
757 Read color file from absolute filename (bug#8250).
758
759 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
760
761 * makefile.w32-in: Update dependencies.
762
763 2011-03-17 Eli Zaretskii <eliz@gnu.org>
764
765 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
766
767 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
768
769 Fix more problems found by GCC 4.5.2's static checks.
770
771 * process.c (make_serial_process_unwind, send_process_trap):
772 (sigchld_handler): Now static.
773
774 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
775 That way, the code declares only the vars that it needs.
776 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
777 * s/cygwin.h (PTY_ITERATION): Likewise.
778 * s/darwin.h (PTY_ITERATION): Likewise.
779 * s/gnu-linux.h (PTY_ITERATION): Likewise.
780
781 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
782 * process.c (allocate_pty): Don't declare stb unless it's needed.
783
784 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
785 (CONSTANTLIM): Remove; unused.
786 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
787 Define only if needed.
788
789 * unexelf.c (unexec): Name an expression,
790 to avoid gcc -Wbad-function-cast warning.
791 Use a different way to cause a compilation error if anyone uses
792 n rather than nn, a way that does not involve shadowing.
793 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
794
795 * deps.mk (unexalpha.o): Remove; unused.
796
797 New file unexec.h, the (simple) interface for unexec (Bug#8267).
798 * unexec.h: New file.
799 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
800 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
801 Depend on unexec.h.
802 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
803 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
804 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
805 Change as necessary to match prototype in unexec.h.
806
807 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
808 shadowing.
809 (back_comment, skip_chars): Mark vars as initialized.
810
811 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
812 Rename locals to avoid shadowing.
813
814 * lread.c (read1): Rewrite so as not to use empty "else".
815 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
816
817 * print.c (Fredirect_debugging_output): Fix pointer signedess.
818
819 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
820 warning when compiling print.c.
821
822 * font.c (font_unparse_fcname): Abort in an "impossible" situation
823 instead of using an uninitialized var.
824 (font_sort_entities): Mark var as initialized.
825
826 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
827
828 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
829 pointers to constants.
830 (font_parse_fcname): Remove unused vars.
831 (font_delete_unmatched): Now static.
832 (font_get_spec): Remove; unused.
833 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
834 (font_update_drivers, Ffont_get_glyphs, font_add_log):
835 Rename or move locals to avoid shadowing.
836
837 * fns.c (require_nesting_list, require_unwind): Now static.
838 (Ffillarray): Rename locals to avoid shadowing.
839
840 * floatfns.c (domain_error2): Define only if needed.
841 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
842
843 * alloc.c (mark_backtrace): Move decl from here ...
844 * lisp.h: ... to here, so that it can be checked.
845
846 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
847 (Fdefvar): Rewrite so as not to use empty "else".
848 (lisp_indirect_variable): Name an expression,
849 to avoid gcc -Wbad-function-cast warning.
850 (Fdefvar): Rename locals to avoid shadowing.
851
852 * callint.c (quotify_arg, quotify_args): Now static.
853 (Fcall_interactively): Rename locals to avoid shadowing.
854 Use const pointer when appropriate.
855
856 * lisp.h (get_system_name, get_operating_system_release):
857 Move decls here, to check interfaces.
858 * process.c (get_operating_system_release): Move decl to lisp.h.
859 * xrdb.c (get_system_name): Likewise.
860 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
861 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
862 some of which prompt warnings from gcc -Wbad-function-cast.
863 (Fformat_time_string, Fencode_time, Finsert_char):
864 (Ftranslate_region_internal, Fformat):
865 Rename or remove local vars to avoid shadowing.
866 (Ftranslate_region_internal): Mark var as initialized.
867
868 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
869 avoid shadowing.
870
871 * lisp.h (eassert): Check that the argument compiles, even if
872 ENABLE_CHECKING is not defined.
873
874 * data.c (Findirect_variable): Name an expression, to avoid
875 gcc -Wbad-function-cast warning.
876 (default_value, arithcompare, arith_driver, arith_error): Now static.
877 (store_symval_forwarding): Rename local to avoid shadowing.
878 (Fmake_variable_buffer_local, Fmake_local_variable):
879 Mark variables as initialized.
880 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
881
882 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
883 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
884 Rename locals to avoid shadowing.
885 (mark_stack): Move local variables into the #ifdef region where
886 they're used.
887 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
888 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
889 needed otherwise.
890 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
891 (GC_STRING_CHARS): Remove; not used.
892 (Fmemory_limit): Cast sbrk's returned value to char *.
893
894 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
895 avoids undefined behavior in theory.
896
897 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
898
899 Use functions, not macros, for up- and down-casing (Bug#8254).
900 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
901 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
902 to use the following functions instead of these macros.
903 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
904 EMACS_INT, since callers assume the returned value fits in int.
905 (upcase1): Likewise, for UPCASE_TABLE.
906 (uppercasep, lowercasep, upcase): New static inline functions.
907 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
908 the race-condition problem in the old DOWNCASE.
909
910 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
911 Rename locals to avoid shadowing.
912 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
913 (regex_compile, re_search_2, re_match_2_internal):
914 Remove unused local vars.
915 (FREE_VAR): Rewrite so as not to use empty "else",
916 which gcc can warn about.
917 (regex_compile, re_match_2_internal): Mark locals as initialized.
918 (RETALLOC_IF): Define only if needed.
919 (WORDCHAR_P): Likewise. This one is never needed, but is used
920 only in a comment talking about a compiler bug, so put inside
921 the #if 0 of that comment.
922 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
923 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
924 Remove; unused.
925
926 * search.c (boyer_moore): Rename locals to avoid shadowing.
927 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
928 (PREV_CHAR_BOUNDARY): Likewise.
929
930 * search.c (simple_search): Remove unused var.
931
932 * dired.c (compile_pattern): Move decl from here ...
933 * lisp.h: ... to here, so that it can be checked.
934 (struct re_registers): New forward decl.
935
936 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
937
938 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
939 All uses changed.
940 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
941 Rename locals to avoid shadowing.
942 (Fvertical_motion): Mark locals as initialized.
943
944 * casefiddle.c (casify_object, casify_region): Now static.
945 (casify_region): Mark local as initialized.
946
947 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
948
949 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
950 New macros, so that the caller can use some names other than
951 gcpro1, gcpro2, etc.
952 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
953 of the new macros.
954 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
955 argument, for consistency with GCPRO2_VAR, etc: it is now the
956 prefix of the variable, not the variable itself. All uses
957 changed.
958 * dired.c (directory_files_internal, file_name_completion):
959 Rename locals to avoid shadowing.
960
961 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
962 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
963 dired.c's scmp function, had undefined behavior.
964 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
965 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
966 * buffer.h: ... to here, because these macros use current_buffer,
967 and the new implementation with inline functions needs to have
968 current_buffer in scope now, rather than later when the macros
969 are used.
970 (downcase, upcase1): New static inline functions.
971 (DOWNCASE, UPCASE1): Reimplement using these functions.
972 This avoids undefined behavior in expressions like
973 DOWNCASE (x) == DOWNCASE (y), which previously suffered
974 from race conditions in accessing the global variables
975 case_temp1 and case_temp2.
976 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
977 * lisp.h (case_temp1, case_temp2): Remove their decls.
978 * character.h (ASCII_CHAR_P): Move from here ...
979 * lisp.h: ... to here, so that the inline functions mentioned
980 above can use them.
981
982 * dired.c (directory_files_internal_unwind): Now static.
983
984 * fileio.c (file_name_as_directory, directory_file_name):
985 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
986 Now static.
987 (file_name_as_directory): Use const pointers when appropriate.
988 (Fexpand_file_name): Likewise. In particular, newdir might
989 point at constant storage, so make it a const pointer.
990 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
991 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
992 signedness issues.
993 (Fset_file_times, Finsert_file_contents, auto_save_error):
994 Rename locals to avoid shadowing.
995
996 * minibuf.c (choose_minibuf_frame_1): Now static.
997 (Ftry_completion, Fall_completions): Rename or remove locals
998 to avoid shadowing.
999
1000 * marker.c (bytepos_to_charpos): Remove; unused.
1001
1002 * lisp.h (verify_bytepos, count_markers): New decls,
1003 so that gcc does not warn that these functions aren't declared.
1004
1005 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1006 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
1007 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
1008 (copy_text): Remove unused local var.
1009
1010 * filelock.c (within_one_second): Now static.
1011 (lock_file_1): Rename local to avoid shadowing.
1012
1013 * buffer.c (fix_overlays_before): Mark locals as initialized.
1014 (fix_start_end_in_overlays): Likewise. This function should be
1015 simplified by using pointers-to-pointers, but that's a different
1016 matter.
1017 (switch_to_buffer_1): Now static.
1018 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1019 (report_overlay_modification): Rename locals to avoid shadowing.
1020
1021 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
1022 Fix pointer signedness issue.
1023 (sys_subshell): Mark local as volatile if checking for lint,
1024 to suppress a gcc -Wclobbered warning that does not seem to be right.
1025 (MAXPATHLEN): Define only if needed.
1026
1027 * process.c (serial_open, serial_configure): Move decls from here ...
1028 * systty.h: ... to here, so that they can be checked.
1029
1030 * fns.c (get_random, seed_random): Move extern decls from here ...
1031 * lisp.h: ... to here, so that they can be checked.
1032
1033 * sysdep.c (reset_io): Now static.
1034 (wait_for_termination_signal): Remove; unused.
1035
1036 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1037 (copy_keymap_item, append_key, push_text_char_description):
1038 Now static.
1039 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
1040 (DENSE_TABLE_SIZE): Remove; unused.
1041 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1042 (describe_map_tree):
1043 Rename locals to avoid shadowing.
1044
1045 * keyboard.c: Declare functions static if they are not used elsewhere.
1046 (echo_char, echo_dash, cmd_error, top_level_2):
1047 (poll_for_input, handle_async_input): Now static.
1048 (read_char, kbd_buffer_get_event, make_lispy_position):
1049 (make_lispy_event, make_lispy_movement, apply_modifiers):
1050 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1051 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1052 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
1053 (read_key_sequence, read_char): Mark locals as initialized.
1054 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
1055
1056 * keyboard.h (make_ctrl_char): New decl.
1057 (mark_kboards): Move decl here ...
1058 * alloc.c (mark_kboards): ... from here.
1059
1060 * lisp.h (force_auto_save_soon): New decl.
1061
1062 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
1063 (DEFINE_DUMMY_FUNCTION): New macro.
1064 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1065 Use it.
1066 (main): Add casts to avoid warnings
1067 if GCC considers string literals to be constants.
1068
1069 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1070
1071 * dbusbind.c: Pointer signedness fixes.
1072 (xd_signature, xd_append_arg, xd_initialize):
1073 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1074 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1075 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1076 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1077
1078 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1079 if GCC considers string literals to be constants.
1080 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
1081
1082 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1083
1084 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1085 (print_preprocess, print_object): New macro to fix last change.
1086
1087 * print.c (print_preprocess): Don't forget font objects.
1088
1089 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
1090
1091 * emacs.c (USAGE3): Doc fixes.
1092
1093 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1094
1095 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1096 structure.
1097
1098 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
1099
1100 * lisp.h (VWindow_system, Qfile_name_history):
1101 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1102 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1103 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1104
1105 * w32select.c: Don't #include "keyboard.h".
1106 (run_protected): Add extern declaration for waiting_for_input.
1107
1108 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1109 * w32console.c (detect_input_pending, read_input_pending)
1110 (encode_terminal_code):
1111 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1112 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1113 (w32_system_caret_y, Qfile_name_history):
1114 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1115 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1116 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1117 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1118 * w32proc.c (Qlocal, report_file_error):
1119 * w32term.c (Vwindow_system, updating_frame):
1120 * w32uniscribe.c (initialized, uniscribe_font_driver):
1121 Remove unneeded extern declarations.
1122
1123 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
1124
1125 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
1126
1127 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
1128
1129 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1130 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1131 These macros can no longer be used for assignment.
1132
1133 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1134 Assign struct members directly, instead of using BUF_BEGV etc.
1135 (record_buffer_markers, fetch_buffer_markers): New functions for
1136 recording and fetching special buffer markers.
1137 (set_buffer_internal_1, set_buffer_temp): Use them.
1138
1139 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1140
1141 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1142
1143 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1144 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1145
1146 * xdisp.c (hscroll_window_tree):
1147 (reconsider_clip_changes): Use PT instead of BUF_PT.
1148
1149 2011-03-13 Eli Zaretskii <eliz@gnu.org>
1150
1151 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1152 $(EMACS_ROOT)/lib/intprops.h.
1153
1154 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1155
1156 Fix more problems found by GCC 4.5.2's static checks.
1157
1158 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1159 to unsigned char * to avoid compiler diagnostic.
1160 (xg_free_frame_widgets): Make it clear that a local variable is
1161 needed only if USE_GTK_TOOLTIP.
1162 (gdk_window_get_screen): Make it clear that this macro is needed
1163 only if USE_GTK_TOOLTIP.
1164 (int_gtk_range_get_value): New function, which avoids a diagnostic
1165 from gcc -Wbad-function-cast.
1166 (xg_set_toolkit_scroll_bar_thumb): Use it.
1167 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1168 diagnostic from gcc -Wbad-function-cast.
1169 (get_utf8_string, xg_get_file_with_chooser):
1170 Rename locals to avoid shadowing.
1171 (create_dialog): Move locals to avoid shadowing.
1172
1173 * xgselect.c (xg_select): Remove unused var.
1174
1175 * image.c (four_corners_best): Mark locals as initialized.
1176 (gif_load): Initialize transparent_p to zero (Bug#8238).
1177 Mark another local as initialized.
1178 (my_png_error, my_error_exit): Mark with NO_RETURN.
1179
1180 * image.c (clear_image_cache): Now static.
1181 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
1182 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
1183 (x_edge_detection): Remove unnecessary cast that
1184 gcc -Wbad-function-cast diagnoses.
1185 (gif_load): Fix pointer signedness.
1186 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1187 (jpeg_load, gif_load): Rename locals to avoid shadowing.
1188
1189 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
1190
1191 Improve quality of tests for time stamp overflow.
1192 For example, without this patch (encode-time 0 0 0 1 1
1193 1152921504606846976) returns the obviously-bogus value (-948597
1194 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1195 reports time overflow. See
1196 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
1197 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1198 * editfns.c: Include limits.h and intprops.h.
1199 (TIME_T_MIN, TIME_T_MAX): New macros.
1200 (time_overflow): Move earlier, to before first use.
1201 (hi_time, lo_time): New functions, for an accurate test for
1202 out-of-range times.
1203 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1204 (Fget_internal_run_time): Don't assume time_t fits in int.
1205 (make_time): Use list2 instead of Fcons twice.
1206 (Fdecode_time): More accurate test for out-of-range times.
1207 (check_tm_member): New function.
1208 (Fencode_time): Use it, to test for out-of-range times.
1209 (lisp_time_argument): Don't rely on undefined left-shift and
1210 right-shift behavior when checking for time stamp overflow.
1211
1212 * editfns.c (time_overflow): New function, refactoring common code.
1213 (Fformat_time_string, Fdecode_time, Fencode_time):
1214 (Fcurrent_time_string): Use it.
1215
1216 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1217 * dired.c (make_time): Move to ...
1218 * editfns.c (make_time): ... here.
1219 * systime.h: Note the move.
1220
1221 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1222
1223 * fringe.c (update_window_fringes): Remove unused variables.
1224
1225 * unexmacosx.c (copy_data_segment): Also copy __got section.
1226 (Bug#8223)
1227
1228 2011-03-12 Eli Zaretskii <eliz@gnu.org>
1229
1230 * termcap.c [MSDOS]: Include "msdos.h".
1231 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1232 Constify `char *' arguments and their references according to
1233 prototypes in tparam.h.
1234
1235 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
1236
1237 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1238 Adapt all references accordingly.
1239
1240 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1241
1242 2011-03-11 Tom Tromey <tromey@redhat.com>
1243
1244 * buffer.c (syms_of_buffer): Remove obsolete comment.
1245
1246 2011-03-11 Eli Zaretskii <eliz@gnu.org>
1247
1248 * termhooks.h (encode_terminal_code): Declare prototype.
1249
1250 * msdos.c (encode_terminal_code): Don't declare prototype.
1251
1252 * term.c (encode_terminal_code): Now external again, used by
1253 w32console.c and msdos.c.
1254
1255 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
1256 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
1257
1258 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
1259
1260 Fix some minor problems found by GCC 4.5.2's static checks.
1261
1262 * fringe.c (update_window_fringes): Mark locals as initialized
1263 (Bug#8227).
1264 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
1265
1266 * alloc.c (mark_fringe_data): Move decl from here ...
1267 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
1268 to check its interface.
1269 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
1270
1271 * fontset.c (free_realized_fontset): Now static.
1272 (Fset_fontset_font): Rename local to avoid shadowing.
1273 (fontset_font): Mark local as initialized.
1274 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
1275
1276 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
1277
1278 * xselect.c (x_disown_buffer_selections): Remove; not used.
1279 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
1280 (x_own_selection, Fx_disown_selection_internal): Rename locals
1281 to avoid shadowing.
1282 (x_handle_dnd_message): Remove local to avoid shadowing.
1283
1284 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
1285 so that the caller can use some name other than gcpro1.
1286 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
1287 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1288 (Fx_backspace_delete_keys_p):
1289 Use them to avoid shadowing, and rename vars to avoid shadowing.
1290 (x_decode_color, x_set_name, x_window): Now static.
1291 (Fx_create_frame): Add braces to silence GCC warning.
1292 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
1293 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
1294 Remove unused locals.
1295 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1296 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
1297 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
1298 macros.
1299
1300 * xterm.h (x_mouse_leave): New decl.
1301
1302 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
1303 Remove unused functions.
1304 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
1305 (x_calc_absolute_position): Now static.
1306 (XTread_socket): Don't define label "out" unless it's used.
1307 Don't declare local "event" unless it's used.
1308 (x_iconify_frame, x_free_frame_resources): Don't declare locals
1309 unless they are used.
1310 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
1311 (x_fatal_error_signal): Remove; not used.
1312 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
1313 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
1314 (x_error_catcher, x_connection_closed, x_error_handler):
1315 (x_error_quitter, xembed_send_message, x_iconify_frame):
1316 (my_log_handler): Rename locals to avoid shadowing.
1317 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
1318 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
1319
1320 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
1321 Rename or move locals to avoid shadowing.
1322 (tty_defined_color, merge_face_heights): Now static.
1323 (free_realized_faces_for_fontset): Remove; not used.
1324 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
1325 does not deduce is never used uninitialized.
1326 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
1327 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
1328
1329 * terminal.c (store_terminal_param): Now static.
1330
1331 * xmenu.c (menu_highlight_callback): Now static.
1332 (set_frame_menubar): Remove unused local.
1333 (xmenu_show): Rename parameter to avoid shadowing.
1334 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
1335 since they might point to immutable storage.
1336 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
1337 since it's unused otherwise.
1338
1339 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
1340 Add a FIXME, since the code still doesn't look right. (Bug#8215)
1341 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
1342 avoids a gcc -Wuninitialized diagnostic.
1343 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
1344 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
1345 does not deduce are never used uninitialized.
1346
1347 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
1348
1349 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
1350 * window.c (window_loop, size_window):
1351 (run_window_configuration_change_hook, enlarge_window): Likewise.
1352
1353 * window.c (display_buffer): Now static.
1354 (size_window): Mark variables that gcc -Wuninitialized
1355 does not deduce are never used uninitialized.
1356 * window.h (check_all_windows): New decl, to forestall
1357 gcc -Wmissing-prototypes diagnostic.
1358 * dispextern.h (bidi_dump_cached_states): Likewise.
1359
1360 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
1361 shadowing.
1362 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
1363 Include <limits.h>.
1364 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
1365 and to avoid gcc -Wuninitialized warning.
1366 (load_charset_map): Mark variables that gcc -Wuninitialized
1367 does not deduce are never used uninitialized.
1368 (load_charset): Abort instead of using uninitialized var (Bug#8229).
1369
1370 * coding.c (coding_set_source, coding_set_destination):
1371 Use "else { /* comment */ }" rather than "else /* comment */;"
1372 for clarity, and to avoid gcc -Wempty-body warning.
1373 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
1374 a block, when the outer 'i' will do.
1375 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
1376 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
1377 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
1378 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
1379 (Fdecode_sjis_char, Fdefine_coding_system_internal):
1380 Rename locals to avoid shadowing.
1381 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
1382 * coding.c (emacs_mule_char, encode_invocation_designation):
1383 Now static, since they're not used elsewhere.
1384 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
1385 (decode_coding_object, encode_coding_object, detect_coding_system):
1386 (decode_coding_emacs_mule): Mark variables that gcc
1387 -Wuninitialized does not deduce are never used uninitialized.
1388 (detect_coding_iso_2022): Initialize a local variable that might
1389 be used uninitialized. Leave a FIXME because it's not clear that
1390 this initialization is needed. (Bug#8211)
1391 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
1392 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
1393 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
1394 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
1395 Remove unused macros.
1396
1397 * category.c (hash_get_category_set): Remove unused local var.
1398 (copy_category_table): Now static, since it's not used elsewhere.
1399 * character.c (string_count_byte8): Likewise.
1400
1401 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
1402 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
1403
1404 * chartab.c (copy_sub_char_table): Now static, since it's not used
1405 elsewhere.
1406 (sub_char_table_ref_and_range, char_table_ref_and_range):
1407 Rename locals to avoid shadowing.
1408 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
1409
1410 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
1411 (BIDI_BOB): Remove unused macro.
1412
1413 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
1414 deduce are never used uninitialized.
1415 * term.c (encode_terminal_code): Likewise.
1416
1417 * term.c (encode_terminal_code): Now static. Remove unused local.
1418
1419 * tparam.h: New file.
1420 * term.c, tparam.h: Include it.
1421 * deps.mk (term.o, tparam.o): Depend on tparam.h.
1422 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
1423 Move these decls to tparam.h, and make them agree with what
1424 is actually in tparam.c. The previous trick of using incompatible
1425 decls in different modules does not conform to the C standard.
1426 All callers of tparam changed to use tparam's actual API.
1427 * tparam.c (tparam1, tparam, tgoto):
1428 Use const pointers where appropriate.
1429
1430 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
1431 * cm.h (struct cm): Likewise.
1432 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
1433 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
1434 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
1435 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
1436 (turn_on_face, init_tty): Likewise.
1437 * termchar.h (struct tty_display_info): Likewise.
1438
1439 * term.c (term_mouse_position): Rename local to avoid shadowing.
1440
1441 * alloc.c (mark_ttys): Move decl from here ...
1442 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
1443
1444 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
1445
1446 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
1447
1448 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
1449
1450 * search.c (compile_pattern_1): Remove argument regp, unused since
1451 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
1452 (compile_pattern): Don't pass it.
1453
1454 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
1455
1456 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
1457 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
1458 for ! HAVE_GTK3.
1459 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
1460
1461 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
1462
1463 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
1464 gdk_window_get_screen, gdk_window_get_geometry,
1465 gdk_x11_window_lookup_for_display and GDK_KEY_g.
1466 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
1467 (xg_get_pixbuf_from_pixmap): New function.
1468 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
1469 to Pixmap, take frame as parameter, remove GdkColormap parameter.
1470 Call xg_get_pixbuf_from_pixmap instead of
1471 gdk_pixbuf_get_from_drawable.
1472 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
1473 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
1474 (xg_check_special_colors): Use GtkStyleContext and its functions
1475 for HAVE_GTK3.
1476 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
1477 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
1478 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
1479 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
1480 Call gtk_widget_get_preferred_size.
1481 (xg_frame_resized): gdk_window_get_geometry only takes 5
1482 parameters.
1483 (xg_win_to_widget, xg_event_is_for_menubar):
1484 Call gdk_x11_window_lookup_for_display.
1485 (xg_set_widget_bg): New function.
1486 (delete_cb): New function.
1487 (xg_create_frame_widgets): connect delete-event to delete_cb.
1488 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
1489 (xg_set_background_color): Call xg_set_widget_bg.
1490 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
1491 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
1492 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
1493 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
1494 if ! HAVE_GTK3.
1495 (update_frame_tool_bar): Call gtk_widget_hide.
1496 (xg_initialize): Use GDK_KEY_g.
1497
1498 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
1499 if ! HAVE_GTK3
1500 (x_session_initialize): Call gdk_x11_set_sm_client_id.
1501
1502 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
1503 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
1504 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
1505
1506 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
1507
1508 * w32xfns.c (select_palette): Check success of RealizePalette against
1509 GDI_ERROR, not zero.
1510
1511 See ChangeLog.11 for earlier changes.
1512
1513 ;; Local Variables:
1514 ;; coding: utf-8
1515 ;; End:
1516
1517 Copyright (C) 2011 Free Software Foundation, Inc.
1518
1519 This file is part of GNU Emacs.
1520
1521 GNU Emacs is free software: you can redistribute it and/or modify
1522 it under the terms of the GNU General Public License as published by
1523 the Free Software Foundation, either version 3 of the License, or
1524 (at your option) any later version.
1525
1526 GNU Emacs is distributed in the hope that it will be useful,
1527 but WITHOUT ANY WARRANTY; without even the implied warranty of
1528 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
1529 GNU General Public License for more details.
1530
1531 You should have received a copy of the GNU General Public License
1532 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.