Merge 2012-04-09 GnuTLS fix from trunk
[bpt/emacs.git] / src / ChangeLog
1 2012-04-10 Teodor Zlatanov <tzz@lifelogs.com>
2
3 * process.c (make_process):
4 * process.h: Add integer `gnutls_handshakes_tried' member to
5 process struct.
6
7 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit. Add
8 convenience `GNUTLS_LOG2i' macro.
9
10 * gnutls.c (gnutls_log_function2i): Convenience log function.
11 (emacs_gnutls_read): Use new log functions,
12 `gnutls_handshakes_tried' process member, and
13 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
14 attempts per process (connection).
15
16 2012-04-09 Eli Zaretskii <eliz@gnu.org>
17
18 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
19 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
20
21 2012-04-09 Jan Djärv <jan.h.d@swipnet.se>
22
23 * nsterm.m (constrainFrameRect): Always constrain when there is only
24 one screen (Bug#10962).
25
26 2012-04-06 Eli Zaretskii <eliz@gnu.org>
27
28 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
29 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
30 about subtle differences between FETCH_CHAR* and STRING_CHAR*
31 macros related to unification of CJK characters. For the details,
32 see the discussion following the message here:
33 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
34
35 2012-04-04 Chong Yidong <cyd@gnu.org>
36
37 * keyboard.c (Vdelayed_warnings_list): Doc fix.
38
39 2012-04-01 Eli Zaretskii <eliz@gnu.org>
40
41 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
42 instead of alloca. (Bug#11138)
43
44 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
45
46 * w32menu.c (is_simple_dialog): Properly check lisp types.
47 (Bug#11141)
48
49 2012-03-31 Eli Zaretskii <eliz@gnu.org>
50
51 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
52 position we get to after a call to move_it_to fails the
53 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
54 only if we wind up in a string from display property. (Bug#11063)
55
56 * window.c (Fdelete_other_windows_internal): Invalidate the row
57 and column information about mouse highlight, so that redisplay
58 restores it after reallocating the glyph matrices. (Bug#7464)
59
60 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
61 string comes from a `display' text property, use the buffer
62 position of that property as if we actually saw that position in
63 the row's glyphs.
64 (move_it_by_lines): Remove the assertion that
65 "it->current_x == 0 && it->hpos == 0" which can be legitimately
66 violated when there's a before-string at the beginning of a line.
67 (Bug#11063)
68
69 2012-03-30 Eli Zaretskii <eliz@gnu.org>
70
71 * xdisp.c (append_space_for_newline): If the default face was
72 remapped, use the remapped face for the appended newline.
73 (extend_face_to_end_of_line): Use the remapped default face for
74 extending the face to the end of the line.
75 (display_line): Call extend_face_to_end_of_line when the default
76 face was remapped. (Bug#11068)
77
78 2012-03-29 Eli Zaretskii <eliz@gnu.org>
79
80 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
81
82 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
83
84 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
85
86 2012-03-27 Glenn Morris <rgm@gnu.org>
87
88 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
89 Doc fixes.
90
91 2012-03-26 Kenichi Handa <handa@m17n.org>
92
93 * dispextern.h (struct glyph): Fix previous change. Change the
94 bit length of glyphless.ch to 25 (Bug#11082).
95
96 2012-03-26 Chong Yidong <cyd@gnu.org>
97
98 * keyboard.c (Vselection_inhibit_update_commands): New variable.
99 (command_loop_1): Use it; inhibit selection update for
100 handle-select-window too (Bug#8996).
101
102 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
103
104 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
105
106 2012-03-25 Kenichi Handa <handa@m17n.org>
107
108 * dispextern.h (struct glyph): Change the bit length of
109 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
110
111 2012-03-24 Eli Zaretskii <eliz@gnu.org>
112
113 * s/ms-w32.h (tzname): Include time.h before redirecting to
114 _tzname. Fixes the MSVC build. (Bug#9960)
115
116 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
117
118 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
119 characters.
120
121 * xterm.c (XTread_socket): Only modify handling_signal if
122 !SYNC_INPUT. (Bug#11080)
123
124 2012-03-23 Eli Zaretskii <eliz@gnu.org>
125
126 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
127 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
128 when fetching a multibyte character consumes more bytes than
129 CHAR_BYTES returns, due to unification of CJK characters in
130 string_char. (Bug#11073)
131
132 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
133
134 * process.c (wait_reading_process_output): Handle pty disconnect
135 by refraining from sending oneself a SIGCHLD (bug#10933).
136
137 2012-03-22 Chong Yidong <cyd@gnu.org>
138
139 * dispextern.h (struct it): New member string_from_prefix_prop_p.
140
141 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
142 Mark string as coming from a prefix property.
143 (handle_face_prop): Use default face for prefix strings (Bug#4281).
144 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
145
146 2012-03-21 Chong Yidong <cyd@gnu.org>
147
148 * xfaces.c (Vface_remapping_alist): Doc fix.
149
150 2012-03-20 Eli Zaretskii <eliz@gnu.org>
151
152 * w32proc.c (Fw32_set_console_codepage)
153 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
154 Doc fixes.
155
156 2012-03-20 Chong Yidong <cyd@gnu.org>
157
158 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
159 to reflect default non-nil value of redisplay-dont-pause.
160
161 2012-03-19 Kenichi Handa <handa@m17n.org>
162
163 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
164 it fit in a valid range (Bug#11003).
165
166 2012-03-18 Eli Zaretskii <eliz@gnu.org>
167
168 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
169 that is not from display property, accept the row as a "cursor
170 row" if one of the string's character has a non-nil `cursor'
171 property. Fixes cursor positioning when there are newlines in
172 overlay strings, e.g. in icomplete.el. (Bug#11035)
173
174 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
175
176 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
177
178 2012-03-12 Chong Yidong <cyd@gnu.org>
179
180 * eval.c (inhibit_lisp_code): Rename from
181 inhibit_window_configuration_change_hook; move from window.c.
182
183 * xfns.c (unwind_create_frame_1, Fx_create_frame):
184 * window.c (run_window_configuration_change_hook)
185 (syms_of_window): Callers changed.
186
187 2012-03-11 Chong Yidong <cyd@gnu.org>
188
189 * keymap.c (Fkey_description): Doc fix (Bug#9700).
190
191 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
192
193 2012-03-10 Chong Yidong <cyd@gnu.org>
194
195 * frame.c (other_visible_frames): Don't assume the selected frame
196 is visible (Bug#10955).
197
198 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
199
200 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
201
202 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
203
204 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
205 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
206 zero (Bug#10954).
207
208 2012-03-03 Glenn Morris <rgm@gnu.org>
209
210 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
211
212 2012-03-02 Eli Zaretskii <eliz@gnu.org>
213
214 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
215 position past the first glyph_row that ends at ZV. (Bug#10902)
216 (redisplay_window, next_element_from_string): Fix typos in
217 comments.
218 (redisplay_window): Pass to move_it_vertically the margin in
219 pixels, not in screen lines.
220
221 2012-03-02 Glenn Morris <rgm@gnu.org>
222
223 * buffer.c (buffer-list-update-hook): Doc fix.
224
225 2012-02-29 Eli Zaretskii <eliz@gnu.org>
226
227 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
228 push_it before setting up the iterator for the first overlay
229 string, even if we have an empty string loaded.
230 (next_overlay_string): If there's an empty string on the iterator
231 stack, pop the stack. (Bug#10903)
232
233 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
234
235 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
236 Suggested by Stefan Monnier in
237 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
238 * alloc.c (widen_to_Lisp_Object): New static function.
239 (mark_memory): Also mark Lisp_Objects by fetching pointer words
240 and widening them to Lisp_Objects. This would work even if
241 USE_LSB_TAG is defined and wide integers are used, which might
242 happen in a future version of Emacs.
243
244 2012-02-25 Chong Yidong <cyd@gnu.org>
245
246 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
247 Doc fix.
248
249 * xselect.c (Fx_selection_exists_p): Doc fix.
250 (x_clipboard_manager_save_all): Print an informative message
251 before saving to clipboard manager.
252
253 2012-02-24 Chong Yidong <cyd@gnu.org>
254
255 * keyboard.c (process_special_events): Handle all X selection
256 requests in kbd_buffer, not just the next one (Bug#8869).
257
258 2012-02-23 Chong Yidong <cyd@gnu.org>
259
260 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
261 call when setting menu-bar-lines and tool-bar-lines parameters.
262 (unwind_create_frame_1): New helper function.
263
264 * window.c (inhibit_window_configuration_change_hook): New var.
265 (run_window_configuration_change_hook): Obey it.
266 (syms_of_window): Initialize it.
267
268 2012-02-22 Chong Yidong <cyd@gnu.org>
269
270 * xterm.c (x_draw_image_relief): Add missing type check for
271 Vtool_bar_button_margin (Bug#10743).
272
273 2012-02-21 Chong Yidong <cyd@gnu.org>
274
275 * fileio.c (Vfile_name_handler_alist): Doc fix.
276
277 * buffer.c (Fget_file_buffer): Protect against invalid file
278 handler return value.
279
280 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
281
282 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
283 when computing $valmask.
284
285 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
286 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
287 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
288 It's useless in that case, and it can cause problems on hosts
289 that allocate halves of EMACS_INT values separately.
290 Reported by Dan Horák. Diagnosed by Andreas Schwab in
291 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
292 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
293 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
294 it avoids undefined behavior on hosts where shifting right by more
295 than the word width has undefined behavior.
296
297 2012-02-19 Chong Yidong <cyd@gnu.org>
298
299 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
300 (Funhandled_file_name_directory, Ffile_name_as_directory)
301 (Fdirectory_file_name, Fexpand_file_name)
302 (Fsubstitute_in_file_name): Protect against invalid file handler
303 return values (Bug#10845).
304
305 2012-02-18 Eli Zaretskii <eliz@gnu.org>
306
307 * .gdbinit (pitx): Fix incorrect references to fields of the
308 iterator stack.
309
310 2012-02-17 Chong Yidong <cyd@gnu.org>
311
312 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
313
314 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
315
316 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
317 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
318
319 2012-02-15 Chong Yidong <cyd@gnu.org>
320
321 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
322 marked as special. Also, starting docstrings with * is obsolete.
323
324 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
325
326 * gnutls.c (emacs_gnutls_write): Fix last change.
327
328 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
329
330 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
331 send_process.
332
333 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
334
335 * keymap.c (Fsingle_key_description): Handle char ranges.
336
337 2012-02-12 Chong Yidong <cyd@gnu.org>
338
339 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
340 as that creates a dangerous corner case.
341
342 * window.c (Fdelete_window_internal): Invalidate the mouse
343 highlight (Bug#9904).
344
345 2012-02-12 Glenn Morris <rgm@gnu.org>
346
347 * xselect.c (Fx_own_selection_internal)
348 (Fx_get_selection_internal, Fx_disown_selection_internal)
349 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
350 * nsselect.m (Fx_own_selection_internal)
351 (Fx_disown_selection_internal, Fx_selection_exists_p)
352 (Fx_selection_owner_p, Fx_get_selection_internal):
353 Sync docs and argument specs with the xselect.c versions.
354
355 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
356
357 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
358
359 2012-02-11 Eli Zaretskii <eliz@gnu.org>
360
361 * w32select.c (Fx_selection_exists_p): Sync doc string and
362 argument list with xselect.c. (Bug#10783)
363
364 * w16select.c (Fx_selection_exists_p): Sync doc string and
365 argument list with xselect.c. (Bug#10783)
366
367 2012-02-10 Glenn Morris <rgm@gnu.org>
368
369 * fns.c (Fsecure_hash): Doc fix.
370
371 2012-02-09 Kenichi Handa <handa@m17n.org>
372
373 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
374
375 2012-02-07 Chong Yidong <cyd@gnu.org>
376
377 * buffer.c (Fbuffer_local_variables)
378 (buffer_lisp_local_variables): Handle unbound vars correctly;
379 don't let Qunbound leak into Lisp.
380
381 2012-02-07 Glenn Morris <rgm@gnu.org>
382
383 * image.c (Fimagemagick_types): Doc fix.
384
385 * image.c (imagemagick-render-type): Change it from a lisp object
386 to an integer. Move the doc here from the lisp manual.
387 Treat all values not equal to 0 the same.
388
389 2012-02-06 Chong Yidong <cyd@gnu.org>
390
391 * doc.c (store_function_docstring): Avoid applying docstring of
392 alias to base function (Bug#2603).
393
394 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
395
396 * .gdbinit (pp1, pv1): Remove redundant defines.
397 (pr): Use pp.
398
399 2012-02-04 Chong Yidong <cyd@gnu.org>
400
401 * nsterm.m: Declare a global (Bug#10694).
402
403 2012-02-04 Eli Zaretskii <eliz@gnu.org>
404
405 * w32.c (get_emacs_configuration_options):
406 Include --enable-checking, if specified, in the return value.
407
408 2012-02-04 Martin Rudalics <rudalics@gmx.at>
409
410 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
411 after rounding frame sizes. (Bug#9723)
412
413 2012-02-04 Eli Zaretskii <eliz@gnu.org>
414
415 * keyboard.c (adjust_point_for_property): Don't position point
416 before BEGV. (Bug#10696)
417
418 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
419
420 Handle overflow when computing char display width (Bug#9496).
421 * character.c (char_width): Return EMACS_INT, not int.
422 (char_width, c_string_width): Check for overflow when
423 computing the width; this is possible now that individual
424 characters can have unbounded width. Problem introduced
425 by merge from Emacs 23 on 2012-01-19.
426
427 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
428
429 * dbusbind.c (Fdbus_register_method): Mention the return value
430 :ignore in the docstring.
431
432 2012-02-02 Glenn Morris <rgm@gnu.org>
433
434 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
435
436 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
437 Unconditionally set to t. (Bug#10673)
438 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
439 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
440 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
441
442 2012-02-02 Kenichi Handa <handa@m17n.org>
443
444 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
445 0, do not call append_composite_glyph.
446
447 2012-02-02 Kenichi Handa <handa@m17n.org>
448
449 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
450 NULL (Bug#6988).
451 (x_produce_glyphs): If the component of a composition is a null
452 string, set it->pixel_width to 1 to avoid zero-width glyph.
453
454 2012-02-01 Eli Zaretskii <eliz@gnu.org>
455
456 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
457 first 2 arguments are identical. This makes inserting large
458 output from a subprocess an order of magnitude faster on
459 MS-Windows, where all sbrk'ed memory is always contiguous.
460
461 2012-01-31 Glenn Morris <rgm@gnu.org>
462
463 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
464 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
465 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
466
467 2012-01-29 Glenn Morris <rgm@gnu.org>
468
469 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
470
471 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
472
473 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
474
475 2012-01-28 Chong Yidong <cyd@gnu.org>
476
477 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
478
479 2012-01-26 Chong Yidong <cyd@gnu.org>
480
481 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
482
483 * search.c (Fsearch_forward, Fsearch_backward): Document negative
484 repeat counts (Bug#10507).
485
486 2012-01-26 Glenn Morris <rgm@gnu.org>
487
488 * lread.c (syms_of_lread): Doc fix.
489
490 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
491
492 * coding.c (encode_designation_at_bol): Change return value to
493 EMACS_INT.
494
495 2012-01-25 Chong Yidong <cyd@gnu.org>
496
497 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
498
499 2012-01-21 Chong Yidong <cyd@gnu.org>
500
501 * floatfns.c (Fcopysign): Make the second argument non-optional,
502 since nil is not allowed anyway.
503
504 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
505
506 * process.c (read_process_output): Use p instead of XPROCESS (proc).
507 (send_process): Likewise.
508
509 2012-01-19 Martin Rudalics <rudalics@gmx.at>
510
511 * window.c (save_window_save, Fcurrent_window_configuration)
512 (Vwindow_persistent_parameters): Do not use Qstate.
513 Rewrite doc-strings.
514
515 2012-01-19 Kenichi Handa <handa@m17n.org>
516
517 * character.c (char_width): New function.
518 (Fchar_width, c_string_width, lisp_string_width):
519 Use char_width (Bug#9496).
520
521 2012-01-16 Martin Rudalics <rudalics@gmx.at>
522
523 * window.c (Vwindow_persistent_parameters): New variable.
524 (Fset_window_configuration, save_window_save): Handle persistent
525 window parameters.
526
527 2012-01-14 Eli Zaretskii <eliz@gnu.org>
528
529 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
530 thrashing the stack of the thread. (Bug#9087)
531
532 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
533
534 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
535
536 2012-01-11 Eli Zaretskii <eliz@gnu.org>
537
538 * xdisp.c (rows_from_pos_range): Handle the case where the
539 highlight ends on a newline. (Bug#10464)
540 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
541 he end column for display of highlight that ends on a newline
542 before a R2L line.
543
544 2012-01-11 Glenn Morris <rgm@gnu.org>
545
546 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
547 from load-path also when installation-directory is nil. (Bug#10208)
548
549 2012-01-10 Glenn Morris <rgm@gnu.org>
550
551 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
552
553 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
554 Update template values to be closer to their typical values these days.
555
556 2012-01-09 Eli Zaretskii <eliz@gnu.org>
557
558 * xdisp.c (rows_from_pos_range): Accept additional argument
559 DISP_STRING, and accept any glyph in a row whose object is that
560 string as eligible for mouse highlight. Fixes mouse highlight of
561 display strings from overlays. (Bug#10464)
562
563 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
564
565 emacs: fix an auto-save permissions race condition (Bug#10400)
566 * fileio.c (auto_saving_dir_umask): New static var.
567 (Fmake_directory_internal): Use it.
568 (do_auto_save_make_dir): Set it, instead of invoking chmod after
569 creating the directory. The old code temporarily assigns
570 too-generous permissions to the directory.
571 (do_auto_save_eh): Clear it.
572 (Fdo_auto_save): Catch all errors, not just file errors, so
573 that the var is always cleared.
574
575 2012-01-07 Eli Zaretskii <eliz@gnu.org>
576
577 * search.c (scan_buffer): Pass character positions to
578 know_region_cache, not byte positions. (Bug#6540)
579
580 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
581
582 * w32.c (sys_rename): Report EXDEV when rename of a directory
583 fails because the target is on another logical disk. (Bug#10284)
584
585 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
586
587 * xterm.c (x_embed_request_focus): New function.
588
589 * xterm.h: Add prototype.
590
591 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
592
593 2012-01-05 Glenn Morris <rgm@gnu.org>
594
595 * emacs.c (emacs_copyright): Update short copyright year to 2012.
596
597 2012-01-01 Eli Zaretskii <eliz@gnu.org>
598
599 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
600 Load gnutls_transport_set_lowat only if GnuTLS version is below
601 2.11.1.
602 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
603 GnuTLS versions below 2.11.1.
604
605 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
606
607 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
608 to the doc string advising against its use for altering the way
609 windows are scrolled.
610
611 2011-12-28 Kenichi Handa <handa@m17n.org>
612
613 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
614 coding-system ASCII compatible only when it does not produce BOM
615 on encoding (Bug#10383).
616
617 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
618
619 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
620 can scroll.
621 (create_and_show_popup_menu): Always use menu_position_func for
622 Gtk3 (Bug#10361).
623
624 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
625
626 * callint.c (Fcall_interactively): Don't truncate prompt string.
627
628 2011-12-23 Eli Zaretskii <eliz@gnu.org>
629
630 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
631 property that ends at ZV, so that the bidi iteration could be
632 resumed from there (after widening). (Bug#10360)
633
634 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
635
636 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
637
638 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
639
640 * nsterm.m (x_free_frame_resources):
641 Release f->output_data.ns->miniimage.
642 (ns_index_color): Fix indentation. Do not retain
643 color_table->colors[i].
644
645 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
646 before returning.
647
648 * nsfns.m (x_set_background_color): Assign return value from
649 ns_index_color to face-background instead of NSColor*.
650 (ns_implicitly_set_icon_type): Fix indentation.
651 Change assignment in for loop to comparison.
652
653 * emacs.c (ns_pool): New variable.
654 (main): Assign ns_pool.
655 (Fkill_emacs): Call ns_release_autorelease_pool.
656
657 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
658 autorelease fdesc, release fdAttrs and tdict.
659 (ns_get_covering_families): Release charset.
660 (ns_findfonts): Release NSFontDescriptor created with new.
661 (ns_uni_to_glyphs): Fix indentation.
662 (setString): Release attrStr before assigning new value.
663
664 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
665
666 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
667 and NS_IMPL_COCOA.
668 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
669 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
670
671 2011-12-18 David Reitter <reitter@cmu.edu>
672
673 * nsterm.m (ns_term_init): Subscribe for notifications
674 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
675 to method trackingNotification in EmacsMenu.
676
677 * nsmenu.m (trackingMenu): New variable.
678 (trackingNotification): New method (from Aquamacs).
679 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
680 from Aquamacs (Bug#7030).
681
682 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
683
684 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
685 (symbol_to_nsstring): Fix indentation.
686 (ns_symbol_to_pb): New function.
687 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
688 (Fns_rotate_cut_buffers_internal): Remove.
689 (Fns_store_selection_internal): Rename from
690 Fns_store_cut_buffer_internal.
691 (ns_get_foreign_selection, Fx_own_selection_internal)
692 (Fx_disown_selection_internal, Fx_selection_exists_p)
693 (Fns_get_selection_internal, Fns_store_selection_internal):
694 Use ns_symbol_to_pb and check if return value is nil.
695 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
696 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
697 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
698 renamed to Sns_store_selection_internal.
699 (ns_handle_selection_request): Move code to Fx_own_selection_internal
700 and remove this function.
701 (ns_handle_selection_clear): Remove, never used.
702 (Fx_own_selection_internal): Move code from ns_handle_selection_request
703 here.
704
705 2011-12-17 Ken Brown <kbrown@cornell.edu>
706
707 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
708 GID is unknown (Bug#10257).
709
710 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
711
712 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
713 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
714 which caused a build failure on GNU/Linux IA-64. This problem was
715 introduced by my 2011-10-07 patch.
716
717 2011-12-15 Juri Linkov <juri@jurta.org>
718
719 * image.c (imagemagick_error): New function. (Bug#10112)
720 (imagemagick_load_image): Comment out `MagickSetResolution' call.
721 Use `imagemagick_error' where ImageMagick functions return
722 `MagickFalse'.
723 (Fimagemagick_types): Add `Fnreverse' to return the list in the
724 proper order.
725
726 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
727
728 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
729 fill background (Bug#8992).
730
731 2011-12-13 Martin Rudalics <rudalics@gmx.at>
732
733 * window.c (Vwindow_combination_resize)
734 (Vwindow_combination_limit): Use t instead of non-nil in
735 doc-strings.
736 (Vrecenter_redisplay): Add first sentence of doc-string on
737 separate line.
738 (Frecenter): Fix doc-string typo.
739
740 2011-12-11 Kenichi Handa <handa@m17n.org>
741
742 * coding.c (Funencodable_char_position): Pay attention to the
743 buffer text relocation (Bug#9389).
744
745 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
746
747 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
748 gtk_init (Bug#10100).
749
750 2011-12-10 Eli Zaretskii <eliz@gnu.org>
751
752 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
753 IT->string is nil. (Bug#10263)
754
755 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
756
757 * nsterm.h (x_free_frame_resources): Declare.
758
759 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
760 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
761
762 * nsterm.h (ns_get_defaults_value): Declare.
763
764 * nsterm.m (ns_default): Call ns_get_defaults_value.
765
766 2011-12-09 Eli Zaretskii <eliz@gnu.org>
767
768 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
769 (Bug#10170)
770
771 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
772
773 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
774 that where the value of an _OBJC_* symbol points to is in the .bss
775 section (Bug#10240).
776
777 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
778
779 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
780 after the loop to call ccl_driver at least once (Bug#8619).
781
782 2011-12-08 Kenichi Handa <handa@m17n.org>
783
784 * ftfont.c (get_adstyle_property): Fix previous change
785 (Bug#10233).
786
787 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
788
789 * w32.c (init_environment): If no_site_lisp, remove site-lisp
790 dirs from the default value of EMACSLOADPATH (bug#10208).
791
792 2011-12-07 Glenn Morris <rgm@gnu.org>
793
794 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
795 installation and source directories as well. (Bug#10208)
796
797 2011-12-06 Chong Yidong <cyd@gnu.org>
798
799 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
800
801 2011-12-06 Glenn Morris <rgm@gnu.org>
802
803 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
804 as an error, not just -1. (Bug#10217)
805
806 2011-12-05 Chong Yidong <cyd@gnu.org>
807
808 * keyboard.c (process_special_events): New function.
809 (swallow_events, Finput_pending_p): Use it (Bug#10195).
810
811 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
812
813 * coding.c (encode_designation_at_bol): Don't use uninitialized
814 local variable (Bug#9318).
815
816 2011-12-05 Kenichi Handa <handa@m17n.org>
817
818 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
819 return Qnil (Bug#8046, Bug#10193).
820
821 2011-12-05 Kenichi Handa <handa@m17n.org>
822
823 * coding.c (encode_designation_at_bol): New args charbuf_end and
824 dst. Return the number of produced bytes. Callers changed.
825 (coding_set_source): Return how many bytes coding->source was
826 relocated.
827 (coding_set_destination): Return how many bytes
828 coding->destination was relocated.
829 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
830 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
831
832 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
833
834 * coding.c (CODING_CHAR_CHARSET_P): New macro.
835 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
836 macro (Bug#9318).
837
838 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
839
840 The following changes are to fix Bug#9318.
841
842 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
843 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
844 (encode_coding_iso_2022, encode_coding_sjis)
845 (encode_coding_big5, encode_coding_charset): Use the above macros.
846
847 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
848
849 * lisp.h (process_quit_flag): Fix external declaration.
850
851 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
852
853 Don't macro-inline non-performance-critical code.
854 * eval.c (process_quit_flag): New function.
855 * lisp.h (QUIT): Use it.
856
857 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
858
859 * nsfns.m (get_geometry_from_preferences): New function.
860 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
861
862 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
863
864 * emacs.c (Qkill_emacs): Define.
865 (syms_of_emacs): Initialize it.
866 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
867 Qquit_flag to `kill-emacs' instead.
868 (quit_throw_to_read_char): Add parameter `from_signal'.
869 All callers changed. Call Fkill_emacs if requested and safe.
870 * lisp.h (QUIT): Call Fkill_emacs if requested.
871
872 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
873
874 * widget.c (update_wm_hints): Return if wmshell is null.
875 (widget_update_wm_size_hints): New function.
876
877 * widget.h (widget_update_wm_size_hints): Declare.
878
879 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
880 widget_update_wm_size_hints (Bug#10104).
881
882 2011-12-03 Eli Zaretskii <eliz@gnu.org>
883
884 * xdisp.c (handle_invisible_prop): If the invisible text ends just
885 before a newline, prepare the bidi iterator for consuming the
886 newline, and keep the current paragraph direction. (Bug#10183)
887 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
888
889 2011-12-02 Juri Linkov <juri@jurta.org>
890
891 * search.c (Fword_search_regexp): New Lisp function created from
892 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
893 (Fword_search_backward, Fword_search_forward)
894 (Fword_search_backward_lax, Fword_search_forward_lax):
895 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
896 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
897
898 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
899
900 * fileio.c (Finsert_file_contents): Move after-change-function call
901 to before the "handled:" label, since all "goto handled" appear in
902 cases where the *-change-functions have already been properly called
903 (bug#10117).
904
905 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
906
907 * keyboard.c (interrupt_signal): Don't call kill-emacs when
908 waiting for input. (Bug#10169)
909
910 2011-11-30 Eli Zaretskii <eliz@gnu.org>
911
912 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
913 verifies glyph row's hash code--we have just reallocated the
914 glyphs, so their contents can be complete garbage. (Bug#10164)
915
916 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
917
918 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
919
920 2011-11-30 Eli Zaretskii <eliz@gnu.org>
921
922 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
923 attributes are tested _before_ calling verify_row_hash, to protect
924 against GCC re-ordering of the tests. (Bug#10164)
925
926 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
927
928 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
929
930 * xterm.c (handle_one_xevent): Only set async_visible and friends
931 if net_wm_state_hidden_seen is non-zero (Bug#10002)
932 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
933 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
934
935 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
936
937 Remove GCPRO-related macros that exist only to avoid shadowing locals.
938 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
939 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
940 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
941 All uses changed to use GCPRO1 etc.
942 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
943 Revert to old implementation (i.e., before 2011-03-11).
944
945 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
946
947 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
948 of scroll runs so as to avoid assigning disabled bogus rows and
949 unnecessary graphics copy operations.
950
951 2011-11-27 Eli Zaretskii <eliz@gnu.org>
952
953 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
954 (snprintf) [_MSC_VER]: Redirect to _snprintf.
955 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
956 (malloc, free, realloc, calloc): Redirect to e_* only when
957 compiling Emacs.
958
959 * lisp.h (GCTYPEBITS): Move before first use.
960 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
961 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
962 this macro definition.
963
964 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
965 _MSC_VER.
966
967 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
968
969 * gtkutil.c (xg_create_frame_widgets):
970 Call gtk_window_set_has_resize_grip (FALSE) if that function is
971 present with Gtk+ 2.0.
972
973 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
974
975 * fileio.c (Finsert_file_contents): Undo previous change; see
976 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
977
978 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
979
980 Rename locals to avoid shadowing.
981 * fileio.c (Finsert_file_contents):
982 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
983 * process.c (wait_reading_process_output):
984 Rename inner 'proc' to 'p' to avoid shadowing.
985 Indent for consistency with usual Emacs style.
986
987 2011-11-25 Eli Zaretskii <eliz@gnu.org>
988
989 * xdisp.c (redisplay_window): If cursor row is not fully visible
990 after recentering, and scroll-conservatively is set to a large
991 number, scroll window by a few more lines to make the cursor fully
992 visible and out of scroll-margin. (Bug#10105)
993 (start_display): Don't move to the next line if the display should
994 start at a newline that is part of a display vector or an overlay
995 string. (Bug#10119)
996
997 2011-11-24 Juri Linkov <juri@jurta.org>
998
999 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1000 after the `MagickPingImage' call. (Bug#10112)
1001
1002 2011-11-23 Chong Yidong <cyd@gnu.org>
1003
1004 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1005
1006 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1007
1008 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1009 making another buffer current. (Bug#10114)
1010
1011 2011-11-23 Glenn Morris <rgm@gnu.org>
1012
1013 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1014
1015 2011-11-23 Chong Yidong <cyd@gnu.org>
1016
1017 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1018 using it (Bug#5984).
1019
1020 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1021
1022 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1023 and header-lines, as they don't have one computed for them.
1024 (Bug#10098)
1025
1026 * .gdbinit (prow): Make displayed values more self-explaining.
1027 Add row's hash code.
1028
1029 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1030
1031 * process.c (wait_reading_process_output): Fix asynchrounous
1032 GnuTLS socket handling on some versions of the GnuTLS library.
1033 (wait_reading_process_output): Add comment and URL.
1034
1035 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1036
1037 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1038
1039 2011-11-21 Chong Yidong <cyd@gnu.org>
1040
1041 * window.c (Fnext_window, Fprevious_window): Doc fix.
1042
1043 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1044
1045 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1046
1047 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1048
1049 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1050
1051 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1052
1053 * window.c (Fset_window_combination_limit): Rename argument
1054 STATUS to LIMIT.
1055 (Vwindow_combination_limit): Remove "status" from doc-string.
1056
1057 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1058
1059 * m/ibms390.h: Remove.
1060 * m/ibms390x.h: Don't include "ibms390.h".
1061
1062 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1063
1064 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1065 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1066
1067 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1068
1069 * casetab.c (Fset_case_table):
1070 * charset.c (Fcharset_after): Fix typos.
1071
1072 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1073
1074 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1075 Otherwise, valgrind does not work on some platforms.
1076 Problem reported by Andreas Schwab in
1077 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1078 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1079 is set, removing the need for VIRT_ADDRESS_VARIES.
1080 (PURE_P): Use a more-efficient implementation that needs just one
1081 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1082 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1083 to 4 (xorl, subq, cmpq, setbe).
1084 * alloc.c (pure): Always extern now, since that's the
1085 VIRT_ADDR_VARIES behavior.
1086 (PURE_POINTER_P): Use a single comparison, not two, for
1087 consistency with the new puresize.h.
1088 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1089 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1090 Remove VIRT_ADDR_VARIES no longer needed.
1091
1092 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1093
1094 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1095 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1096 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1097 behave as if the cursor position were at the window margin.
1098
1099 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1100 and the cursor position is out of bounds, behave as if the cursor
1101 position were at the window margin. (Bug#10075)
1102
1103 2011-11-18 Chong Yidong <cyd@gnu.org>
1104
1105 * window.c (Fwindow_combination_limit): Make first argument
1106 non-optional, since it is meaningless for live windows like the
1107 selected window.
1108
1109 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1110
1111 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1112
1113 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1114
1115 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1116 (graft_intervals_into_buffer): Simplify.
1117
1118 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1119
1120 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1121 hash values of the two rows.
1122 (copy_row_except_pointers): Preserve the used[] arrays and the
1123 hash values of the two rows. (Bug#10035)
1124 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1125
1126 * xdisp.c (row_hash): New function, body extracted from
1127 compute_line_metrics.
1128 (compute_line_metrics): Call row_hash, instead of computing the
1129 hash code inline.
1130
1131 * dispnew.c (verify_row_hash): Call row_hash for computing the
1132 hash code of a row, instead of duplicating code from xdisp.c.
1133
1134 * dispextern.h (row_hash): Add prototype.
1135
1136 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1137
1138 * frame.c (delete_frame): Don't delete the terminal when the last
1139 X frame is closed if emacs is built with GTK toolkit.
1140
1141 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1142
1143 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1144
1145 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1146
1147 * window.c (Vwindow_splits): Rename to
1148 Vwindow_combination_resize. Suggested by Juri Linkov.
1149 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1150 of Vwindow_splits.
1151
1152 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1153
1154 * nsfns.m (Fns_font_name):
1155 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1156
1157 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1158
1159 * window.h (window): Rename slot "nest" to "combination_limit".
1160 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1161 (Fset_window_nest): Rename to Fset_window_combination_limit.
1162 (Vwindow_nest): Rename to Vwindow_combination_limit.
1163 (recombine_windows, make_parent_window, make_window)
1164 (Fsplit_window_internal, saved_window)
1165 (Fset_window_configuration, save_window_save): Rename all
1166 occurrences of window_nest to window_combination_limit.
1167
1168 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1169
1170 * image.c (imagemagick_load_image): Fix typo.
1171
1172 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1173
1174 * xdisp.c (display_line): Move the call to
1175 highlight_trailing_whitespace before the call to
1176 compute_line_metrics, since the latter needs to see the final
1177 faces of all the glyphs to compute ROW's hash value.
1178 Fixes assertion violations in row_equal_p. (Bug#10035)
1179
1180 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1181
1182 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1183 just return (bug#10044).
1184
1185 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1186
1187 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1188 with user-defined heap size. Bump the default size of the temacs
1189 heap to 27MB, to avoid memory warning when running temacs.
1190 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1191
1192 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1193 current_matrix and desired_matrix. (Bug#9990)
1194 (verify_row_hash) [XASSERTS]: New function.
1195 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1196 that the hash value of glyph rows is correct.
1197
1198 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1199
1200 * window.h (window): Remove splits slot.
1201 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1202 (Fdelete_other_windows_internal, make_parent_window)
1203 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1204 (Fset_window_configuration, save_window_save): Don't deal with
1205 split status of windows.
1206 (saved_window): Remove splits slot.
1207 (Vwindow_splits): Rewrite doc-string.
1208
1209 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1210
1211 * xfns.c (unwind_create_frame):
1212 * nsfns.m (unwind_create_frame):
1213 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1214 Vframe_list (Bug#9999).
1215
1216 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1217
1218 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1219
1220 2011-11-11 Kenichi Handa <handa@m17n.org>
1221
1222 * callproc.c (Fcall_process): Set the member dst_multibyte of
1223 process_coding.
1224
1225 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1226
1227 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1228 avoid a crash (bug#9496).
1229
1230 2011-11-09 Chong Yidong <cyd@gnu.org>
1231
1232 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1233 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1234
1235 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1236
1237 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1238
1239 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1240
1241 Avoid some portability problems by eschewing 'extern inline' functions.
1242 The trivial performance wins aren't worth the portability hassles; see
1243 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1244 et seq.
1245 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1246 (window_box_width, window_box_left, window_box_left_offset)
1247 (window_box_right, window_box_right_offset): Undo previous change,
1248 by removing the "extern"s.
1249 * intervals.c (adjust_intervals_for_insertion)
1250 (adjust_intervals_for_deletion): Undo previous change,
1251 making these static again.
1252 (offset_intervals, temp_set_point_both, temp_set_point)
1253 (copy_intervals_to_string): No longer inline.
1254 * xdisp.c (window_text_bottom_y, window_box_width)
1255 (window_box_height, window_box_left_offset)
1256 (window_box_right_offset, window_box_left, window_box_right)
1257 (window_box): No longer inline.
1258
1259 2011-11-08 Chong Yidong <cyd@gnu.org>
1260
1261 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1262 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1263 Signal an error if not a live window.
1264 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1265 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1266
1267 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1268
1269 * lisp.h (syms_of_abbrev): Remove declaration.
1270 Reported by CHENG Gao <chenggao@royau.me>.
1271
1272 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1273
1274 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1275 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1276 of temacs in GUI mode.
1277
1278 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1279
1280 * window.h: Declare delete_all_child_windows instead of
1281 delete_all_subwindows.
1282 * window.c (Fwindow_nest, Fset_window_nest)
1283 (Fset_window_new_total, Fset_window_new_normal)
1284 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1285 (delete_all_subwindows): Rename to delete_all_child_windows.
1286 (Fdelete_other_windows_internal, Fset_window_configuration):
1287 Call delete_all_child_windows instead of delete_all_subwindows.
1288 * frame.c (delete_frame): Call delete_all_child_windows instead
1289 of delete_all_subwindows.
1290
1291 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1292
1293 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1294 This is also needed for porting to any host where GC_MARK_STACK is
1295 not GC_MAKE_GCPROS_NOOPS.
1296 (which_symbols): Use it.
1297
1298 2011-11-07 Kenichi Handa <handa@m17n.org>
1299
1300 * coding.c (coding_set_destination): Check coding->src_pos only
1301 when coding->src_object is a buffer (bug#9910).
1302
1303 * process.c (send_process): Set the member src_multibyte of coding
1304 to 0 (bug#9911) when sending a unibyte text.
1305
1306 * callproc.c (Fcall_process): Set the member src_multibyte of
1307 process_coding to 0 (bug#9912).
1308
1309 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1310
1311 * xmenu.c (cleanup_widget_value_tree): New function.
1312 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1313 calling free_menubar_widget_value_tree directly (Bug#9830).
1314
1315 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1316
1317 Fix some portability problems with 'inline'.
1318 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1319 (window_box_width, window_box_left, window_box_left_offset)
1320 (window_box_right, window_box_right_offset): Declare extern.
1321 Otherwise, these inline functions do not conform to C99 and
1322 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1323 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1324 * intervals.c (adjust_intervals_for_insertion)
1325 (adjust_intervals_for_deletion): Now extern, because otherwise the
1326 extern inline functions 'offset_intervals' couldn't refer to it.
1327 (static_offset_intervals): Remove.
1328 (offset_intervals): Rewrite using the old contents of
1329 static_offset_intervals. The old version didn't conform to C99
1330 because an extern inline function contained a reference to an
1331 identifier with static linkage.
1332
1333 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1334
1335 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1336 GC.
1337
1338 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1339
1340 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1341 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1342 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1343 return Qleft_to_right.
1344
1345 2011-11-06 Chong Yidong <cyd@gnu.org>
1346
1347 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1348 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1349 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1350 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1351 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1352 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1353 (Fwindow_vscroll): Doc fix.
1354 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1355 argument, since it makes no sense to pass a live window and for
1356 consistency with window-child.
1357
1358 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1359
1360 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1361 support MSVC.
1362
1363 2011-11-05 Jason Rumney <jasonr@gnu.org>
1364
1365 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1366 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1367 fonts (Bug#6029).
1368 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1369 bitwise arithmetic preventing use of unicode-sip and non-truetype
1370 opentype fonts.
1371
1372 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1373
1374 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1375 "emacs"-only part.
1376
1377 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1378 initialization code to keep similarity to xfns.c after changes
1379 from 2011-11-05.
1380
1381 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1382
1383 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1384 (unwind_create_frame): New function (Bug#9943).
1385 (Fx_create_frame): Restructure code to be more similar to the one in
1386 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1387 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1388 Move terminal->reference_count++ just before making the frame official
1389 (Bug#9943).
1390
1391 * nsterm.m (x_free_frame_resources): New function.
1392 (x_destroy_window): Move code to x_free_frame_resources.
1393
1394 * xfns.c (unwind_create_frame): Fix comment.
1395 (Fx_create_frame, x_create_tip_frame):
1396 Move terminal->reference_count++ just before making the frame
1397 official. Move initialization of image_cache_refcount and
1398 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1399
1400 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1401
1402 Support MSVC build with newer versions of Visual Studio.
1403 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1404 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1405 nt/gmake.defs.
1406
1407 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1408 which are not supported by MSVC.
1409 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1410 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1411 bitfields.
1412 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1413 types in bitfields.
1414 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1415
1416 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1417
1418 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1419
1420 Support MSVC build with newer versions of Visual Studio.
1421 * w32.c: Don't include w32api.h for MSVC.
1422 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1423
1424 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1425 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1426 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1427 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1428 e_* cousins.
1429 (alloca) [_MSC_VER]: Define to _alloca.
1430
1431 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1432
1433 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1434
1435 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1436
1437 * xdisp.c (note_mouse_highlight): If either of
1438 previous/next-single-property-change returns nil, treat that as
1439 the beginning or the end of the buffer. (Bug#9955)
1440
1441 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1442
1443 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1444 label is not null (Bug#9951).
1445 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1446 may be NULL.
1447
1448 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1449
1450 * window.c (Fwindow_body_size): Mention in the doc string that the
1451 return value is in frame's canonical units. (Bug#9949)
1452
1453 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1454
1455 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1456
1457 * w32fns.c (unwind_create_frame): If needed, free the glyph
1458 matrices of the partially constructed frame. (Bug#9943)
1459 * xfns.c (unwind_create_frame): Likewise.
1460
1461 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1462
1463 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1464 Don't stop backward scan on the continuation glyph, even though
1465 its CHARPOS is positive.
1466 (mouse_face_from_buffer_pos, note_mouse_highlight):
1467 Rename cover_string to disp_string.
1468
1469 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1470
1471 * window.c (temp_output_buffer_show): Don't use
1472 Vtemp_buffer_show_specifiers.
1473 (Vtemp_buffer_show_specifiers): Remove unused variable.
1474
1475 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1476
1477 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1478 past the beginning of the current glyph matrix.
1479
1480 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1481
1482 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1483 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1484 HAVE_GTK3 (Bug#9869).
1485
1486 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1487 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1488
1489 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1490
1491 * xterm.c: Declare x_handle_net_wm_state to return int.
1492 (handle_one_xevent): Check if we are iconified but don't have
1493 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1494 (get_current_wm_state): Return non-zero if not hidden,
1495 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1496 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1497 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1498 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1499
1500 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1501
1502 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1503 so that this new function doesn't get optimized away by a
1504 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1505
1506 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1507
1508 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1509
1510 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1511
1512 Fix the `xbytecode' command.
1513 * .gdbinit (xprintbytestr): New command.
1514 (xwhichsymbols): Rename from `which'; all callers changed.
1515 (xbytecode): Print the byte-code string as well.
1516
1517 2011-10-29 Kim Storm <storm@cua.dk>
1518
1519 * alloc.c (which_symbols): New function.
1520
1521 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1522
1523 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1524 line. (Bug#9903)
1525
1526 2011-10-29 Glenn Morris <rgm@gnu.org>
1527
1528 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1529 Not clear what it was for, and it causes various bugs. (Bug#9839)
1530
1531 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1532
1533 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1534 possible random value that matches one of those tested as
1535 condition to clear the mouse face.
1536
1537 2011-10-28 Chong Yidong <cyd@gnu.org>
1538
1539 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1540
1541 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1542
1543 * window.c (make_window): Initialize phys_cursor_on_p.
1544
1545 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1546
1547 * lisp.h (struct Lisp_Symbol): Update comments.
1548
1549 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1550
1551 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1552
1553 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1554
1555 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1556 <oslsachem@gmail.com> for helping to debug this.
1557
1558 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1559 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1560 (g_b_init_get_glyph_outline_w): New static variables.
1561 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1562 (GetGlyphOutlineW_Proc): New typedefs.
1563 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1564 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1565 New functions.
1566 (w32font_open_internal, compute_metrics):
1567 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1568 instead of calling the "wide" APIs directly.
1569
1570 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1571
1572 * w32.h (syms_of_w32font): Add prototype.
1573
1574 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1575
1576 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1577 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1578 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1579 (Fmove_to_window_line): Doc fix.
1580
1581 2011-10-27 Chong Yidong <cyd@gnu.org>
1582
1583 * process.c (make_process): Set gnutls_state to NULL.
1584
1585 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1586 non-NULL, regardless of GNUTLS_INITSTAGE.
1587 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1588 an error. Set process slots as soon as we allocate them.
1589
1590 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1591
1592 2011-10-27 Chong Yidong <cyd@gnu.org>
1593
1594 * gnutls.c (emacs_gnutls_deinit): New function.
1595 Deallocate credentials structures as well as calling gnutls_deinit.
1596 (Fgnutls_deinit, Fgnutls_boot): Use it.
1597
1598 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1599 (deactivate_process): Call emacs_gnutls_deinit.
1600
1601 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1602
1603 * image.c (x_create_x_image_and_pixmap):
1604 * w32.c (sys_rename, w32_delayed_load):
1605 * w32font.c (fill_in_logfont):
1606 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1607
1608 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1609
1610 * w32fns.c (w32_default_color_map): New function,
1611 extracted from Fw32_default_color_map.
1612 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1613
1614 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1615
1616 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1617
1618 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1619
1620 * keyboard.c (test_undefined): New function (bug#9751).
1621 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1622
1623 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1624
1625 * sysdep.c (init_sys_modes): Fix the check for the controlling
1626 terminal (Bug#6649).
1627
1628 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1629
1630 * dispextern.h (struct bidi_it): New member next_en_type.
1631
1632 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1633 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1634 current character, check also for next_en_type being WEAK_EN.
1635 (bidi_resolve_weak): Don't enter the expensive loop if the current
1636 position is before next_en_pos. Record the bidi type of the first
1637 non-ET, non-BN character we find, in addition to its position.
1638 (bidi_level_of_next_char): Invalidate next_en_type when
1639 next_en_pos is over-stepped.
1640
1641 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1642
1643 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1644 * editfns.c: Rewrite current-time-zone so that it invokes
1645 the equivalent of (format-time-string "%Z") to get the time zone name.
1646 This fixes a bug when the time zone name contains characters that
1647 need converting from the system time locale to Emacs internal format.
1648 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1649 that patch fixed format-time-string to do the conversion, but
1650 I forgot to fix current-time-zone.
1651 (format_time_string): New function, containing most of
1652 what Fformat_time_string used to contain.
1653 (Fformat_time_string): Rewrite in terms of format_time_string.
1654 This doesn't change this function's behavior.
1655 (current-time-zone): Rewrite to use format_time_string.
1656 This fixes the bug reported by Michael Schierl in
1657 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1658 Jason Rumney's 2007-06-07 change worked around this bug, but
1659 didn't fix it.
1660 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1661
1662 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1663
1664 * xdisp.c (start_display): If the character at POS is displayed
1665 via a display vector, reset IT->current.dpvec_index to zero.
1666 (try_window_reusing_current_matrix): If a line ends in a display
1667 vector or the next line starts in a display vector, continue
1668 redrawing the window even though the character position of
1669 start_row was reached.
1670 (Bug#9771, part 2)
1671
1672 2011-10-18 Chong Yidong <cyd@gnu.org>
1673
1674 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1675 with nobreak-char-display too.
1676
1677 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1678
1679 Fix part 3 of bug#9771.
1680 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1681 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1682 non-neutral characters if the current character is a paragraph
1683 separator (a.k.a. Newline). This avoids running the same
1684 expensive loop twice, once when we consume the preceding newline
1685 and the other time when the line actually needs to be displayed.
1686 Avoid the loop when we see neutrals on the base embedding level
1687 following a character whose directionality is the same as the
1688 paragraph's. This avoids running the expensive loop when a line
1689 ends in a long sequence of neutrals, like control characters.
1690 Add assertion against STRONG_AL type. Slightly rearrange code
1691 that determines the type of a neutral given the first non-neutral
1692 that follows it.
1693 (bidi_level_of_next_char): Set next_en_pos to zero when
1694 invalidating its info.
1695
1696 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1697
1698 * xdisp.c (push_display_prop): Determine whether to record string
1699 or buffer position by IT->string, not by IT->method. Allow
1700 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1701 (move_it_vertically_backward): Don't look for character position
1702 immediately after the newline when in a continuation line.
1703 (Bug#9771, part 1)
1704
1705 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1706
1707 * window.c (coordinates_in_window): Rewrite and delabelize
1708 vertical border check. (Bug#5357) (Bug#9618)
1709
1710 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1711
1712 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1713 errors in XSetWindowBorder (bug#9310).
1714
1715 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1716
1717 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1718 avoid crash when xmalloc overrun checking is enabled.
1719
1720 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1721
1722 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1723 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1724 cursor motion with <left> and <right> arrow keys.
1725
1726 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1727 some callers set that themselves.
1728
1729 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1730
1731 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1732 display string and the previous row comes from the same string and
1733 is empty. (Bug#9739) (Bug#9738)
1734
1735 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1736
1737 * doc.c (get_doc_string): Encode file name (bug#9735).
1738
1739 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1740
1741 * bidi.c (bidi_level_of_next_char):
1742 * xdisp.c (get_visually_first_element): Remove old incorrect
1743 comments regarding the Unicode Line Separator character.
1744
1745 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1746
1747 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1748
1749 * alloc.c (Fgc_status): Do not access beyond zombies array
1750 boundary if nzombies > MAX_ZOMBIES.
1751 * alloc.c (dump_zombies): Add missing format specifier.
1752
1753 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1754
1755 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1756 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1757
1758 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1759 Some packages use them to denote characters with modifiers.
1760
1761 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1762
1763 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1764 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1765 matching a pp-number. Rename parameter var to var1.
1766
1767 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1768
1769 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1770
1771 2011-10-08 Glenn Morris <rgm@gnu.org>
1772
1773 * callint.c (Fcall_interactively): Give a more explicit error for the
1774 'c' case with a non-character input. (Bug#8479)
1775
1776 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1777
1778 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1779 lines.
1780 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1781 lines that are hscrolled on the left.
1782
1783 * dispnew.c (buffer_posn_from_coords): Account for a possible
1784 presence of header-line. (Bug#4426)
1785
1786 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1787
1788 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1789 Don't advertise functionality which we discourage or doesn't work.
1790
1791 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1792
1793 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1794 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1795 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1796 this makes Emacs dump core during garbage collection on rare
1797 occasions. sizeof is obviously inferior to offsetof here, so
1798 stick with offsetof.
1799 (GC_POINTER_ALIGNMENT): New macro.
1800 (mark_memory): Omit 3rd (offset) arg; caller changed.
1801 Don't assume EMACS_INT alignment is the same as pointer alignment.
1802
1803 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1804
1805 * keyboard.c (read_key_sequence_remapped): New var.
1806 (read_key_sequence): Compute remapping in the right buffer.
1807 (command_loop_1): Use read_key_sequence's remapping directly.
1808
1809 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1810
1811 * dired.c (file_name_completion): Don't expand file name.
1812 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1813 before checking file name handler.
1814
1815 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1816 they've been requested explicitly (bug#9591).
1817
1818 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1819
1820 * keymap.c (Fsingle_key_description): Use make_specified_string
1821 instead of build_string to build string from push_key_description.
1822 (Bug#5193)
1823
1824 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1825
1826 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1827 This fixes a Y2038 bug on 64-bit hosts.
1828 * buffer.c (reset_buffer):
1829 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1830 (Fclear_buffer_auto_save_failure):
1831 Use 0, not -1, to represent an unset failure time, since time_t
1832 might not be signed.
1833
1834 Remove dependency on glibc malloc internals.
1835 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1836 Move back here from lisp.h, but with their new implementations.
1837 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1838 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1839 * charset.c (charset_table_init): New static var.
1840 (syms_of_charset): Use it instead of xmalloc. This removes a
1841 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1842 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1843 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1844 Move back to alloc.c.
1845 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1846 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1847
1848 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1849
1850 * nsterm.m (windowDidResize): Call x_set_window_size only when
1851 ns_in_resize is true. Otherwise set pixelwidth/height and
1852 call change_frame_size (Bug#9628).
1853
1854 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1855
1856 Port --enable-checking=all to Fedora 14 x86-64.
1857 * charset.c (syms_of_charset): Also account for glibc malloc's
1858 internal overhead when calculating the initial malloc maximum.
1859
1860 Port --enable-checking=all to Fedora 14 x86.
1861 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1862 Move to lisp.h.
1863 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1864 (overrun_check_realloc, overrun_check_free):
1865 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1866 That way, xmalloc returns a properly-aligned pointer even if
1867 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1868 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1869 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1870 into account when calculating the initial malloc maximum.
1871 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1872 Move here from alloc.c, so that charset.c can use it too.
1873 Properly align; the old code wasn't right for common 32-bit hosts
1874 when configured with --enable-checking=all.
1875 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1876 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1877
1878 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1879
1880 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1881 use EDOM.
1882
1883 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1884
1885 * xdisp.c (compute_display_string_end): If there's no display
1886 string at CHARPOS, return -1.
1887
1888 * bidi.c (bidi_fetch_char): When compute_display_string_end
1889 returns a negative value, treat the character as a normal
1890 character not covered by a display string. (Bug#9624)
1891
1892 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1893
1894 * lread.c (Fread_from_string): Fix typo in docstring.
1895
1896 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1897
1898 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1899 newline, reseat the iterator instead of bidi-iterating there one
1900 character at a time. (Bug#9610)
1901 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1902 TO_CHARPOS if the bidi iterator is at base embedding level.
1903
1904 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1905
1906 * lread.c (readevalloop): Use correct code for NBSP.
1907 (read1): Likewise. (Bug#9608)
1908
1909 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1910
1911 * dbusbind.c (Fdbus_register_signal): When service is not
1912 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1913
1914 2011-09-25 Glenn Morris <rgm@gnu.org>
1915
1916 * buffer.c (truncate-lines): Doc fix.
1917
1918 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1919
1920 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1921 (Fset_window_next_buffers): Doc fix.
1922
1923 2011-09-24 Glenn Morris <rgm@gnu.org>
1924
1925 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1926
1927 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1928
1929 Fix minor problems found by static checking.
1930 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1931 * indent.c (Fvertical_motion): Fix == vs = typo.
1932
1933 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1934
1935 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1936 Default value is now t. Doc fix.
1937
1938 * indent.c (Fvertical_motion): Compute and apply the overshoot
1939 logic when moving up, not only when moving down. Fix the
1940 confusing name and values of the it_overshoot_expected variable;
1941 logic changes accordingly. (Bug#9254) (Bug#9549)
1942
1943 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1944 CHARPOS is covered by a display string which includes newlines.
1945 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1946 is covered by a display string with embedded newlines.
1947
1948 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1949
1950 * dbusbind.c (Fdbus_register_signal): Add match rule to
1951 Vdbus_registered_objects_table. (Bug#9581)
1952 (Fdbus_register_method, Vdbus_registered_objects_table):
1953 Fix docstring.
1954
1955 2011-09-24 Jim Meyering <meyering@redhat.com>
1956
1957 do not ignore write error for any output size
1958 The previous change was incomplete.
1959 While it makes emacs --batch detect the vast majority of stdout
1960 write failures, errors were still ignored whenever the output size is
1961 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1962 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1963 && echo FAIL: ignored write error
1964 FAIL: ignored write error
1965 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1966 && echo FAIL: ignored write error
1967 FAIL: ignored write error
1968 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1969
1970 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1971
1972 * emacs.c (Fkill_emacs): In noninteractive mode exit
1973 non-successfully if a write error occurred on stdout. (Bug#9574)
1974
1975 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1976
1977 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1978 the xassert test.
1979
1980 * dispextern.h (struct it): Update the comment documenting what
1981 can it->OBJECT be.
1982
1983 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1984
1985 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1986 a display string, extend search for cursor position to end of row.
1987 (find_row_edges): If the row ends in a newline from a display
1988 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1989 Handle the case of a display string with multiple newlines.
1990 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1991 non-empty line. Fixes confusing cursor motion with arrow keys at
1992 the beginning of a line that starts with whitespace.
1993
1994 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1995
1996 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1997 (bug#9493).
1998
1999 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2000
2001 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2002 boolean (Bug#9154).
2003
2004 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2005
2006 * xdisp.c (display_line): Record maximum and minimum buffer
2007 positions even if no glyphs were produced (e.g., by a zero-width
2008 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2009 buffer positions that will be removed from the glyph row because
2010 they don't fit.
2011 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2012 column is beyond frame width: don't subtract 1 "pixel" when
2013 computing width of the stretch.
2014 (reseat_at_next_visible_line_start): Undo the change made on
2015 2011-09-17 that saved paragraph information and restored it after
2016 the call to `reseat'. (Bug#9545)
2017
2018 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2019
2020 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2021 and turn window cursor on if cleared (Bug#9415).
2022
2023 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2024
2025 * search.c (boyer_moore): Take unibyte characters from pattern
2026 literally. (Bug#9458)
2027
2028 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2029
2030 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2031
2032 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2033
2034 Fix minor problem found by static checking.
2035 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2036 initialized, to pacify gcc -Wuninitialized.
2037
2038 * fileio.c: Report proper errno when syscall falls.
2039 (Finsert_file_contents): Save and restore errno,
2040 so that report_file_error outputs the correct diagnostic.
2041 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2042
2043 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2044
2045 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2046
2047 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2048
2049 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2050 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2051
2052 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2053
2054 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2055 about the current paragraph and restore it after the call to reseat.
2056
2057 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2058 (bidi_find_paragraph_start): Search back for paragraph beginning
2059 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2060 (bidi_move_to_visually_next): Only trigger paragraph-related
2061 computations when the last character is a newline or at EOB, not
2062 just any NEUTRAL_B. (Bug#9470)
2063
2064 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2065 truncated lines if point is covered by a display string. (Bug#9524)
2066
2067 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2068
2069 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2070 (cons_to_x_long): New function.
2071 (lisp_data_to_selection_data): Use it. Correct the test for
2072 short-versus-long data; it was negated. Break out of vector
2073 loop, for efficiency, when a long datum is discovered.
2074
2075 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2076
2077 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2078
2079 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2080
2081 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2082 GCC PR/17406) by declaring this function with external scope.
2083
2084 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2085
2086 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2087 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2088
2089 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2090
2091 * editfns.c (Fformat): Correctly handle text properties on "%%".
2092
2093 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2094
2095 * xterm.c (x_draw_composite_glyph_string_foreground):
2096 * w32term.c (x_draw_composite_glyph_string_foreground):
2097 * term.c (encode_terminal_code):
2098 * composite.c (composition_update_it, get_composition_id):
2099 * xdisp.c (get_next_display_element)
2100 (fill_composite_glyph_string): Add comments about special meaning
2101 of TAB characters in a composition.
2102
2103 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2104
2105 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2106 This occurs when processing a multibyte format.
2107 Problem reported by Wolfgang Jenker.
2108
2109 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2110
2111 * xdisp.c (try_cursor_movement): Only check for exact match if
2112 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2113
2114 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2115
2116 Remove unused external symbols.
2117 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2118 * xdisp.c (calc_pixel_width_or_height): Now static.
2119 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2120 * indent.c (check_display_width):
2121 * w32term.c: Fix comment to match code.
2122 * xterm.c, xterm.h (x_catching_errors): Remove.
2123
2124 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2125
2126 * xselect.c: Use signed conversions more consistently (Bug#9498).
2127 (selection_data_to_lisp_data): Assume incoming selection data are
2128 signed integers, not unsigned. This is to be consistent with
2129 outgoing selection data, which was modified to use signed integers
2130 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2131 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2132 expects long, not unsigned long.
2133
2134 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2135
2136 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2137 computation of loop end. Reported by Johan Bockgård
2138 <bojohan@gnu.org>.
2139
2140 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2141
2142 * frame.c (Fother_visible_frames_p): Function deleted.
2143
2144 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2145
2146 * indent.c (compute_motion): Process display vector front to back
2147 rather than the other way around. (Bug#2496)
2148
2149 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2150
2151 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2152
2153 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2154
2155 * minibuf.c (Fread_from_minibuffer): Doc fix.
2156
2157 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2158
2159 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2160 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2161
2162 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2163
2164 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2165 value for non-existent files.
2166
2167 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2168
2169 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2170 set its "size" to -1. This will set the modtime_size field of
2171 the corresponding buffer to -1, which is what
2172 verify-visited-file-modtime expects for files that do not exist.
2173 (Bug#9139)
2174
2175 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2176
2177 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2178 here ...
2179 * lisp.h: ... from here. push_key_description is no longer
2180 defined in keyboard.c, so its declaration should not be in
2181 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2182 logically belongs with push_key_description.
2183
2184 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2185
2186 * buffer.h: Include <sys/types.h> instead of <time.h>.
2187 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2188 Problem reported by Herbert J. Skuhra.
2189
2190 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2191
2192 * xml.c (parse_region): Make the parsing work for
2193 non-comment-starting XML files again (bug#9144).
2194
2195 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2196
2197 * image.c (gif_load): Fix calculation of bottom and right corner.
2198 (Bug#9468)
2199
2200 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2201
2202 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2203 redisplay in small windows.
2204
2205 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2206
2207 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2208
2209 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2210
2211 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2212 Operate on live windows only.
2213
2214 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2215
2216 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2217
2218 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2219
2220 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2221 only under bidi iteration.
2222
2223 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2224
2225 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2226
2227 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2228
2229 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2230 Without this fix, the command to link temacs failed due to an
2231 undefined symbol __builtin_isnan. This is because
2232 /usr/include/iso/math_c99.h #defines isnan(x) to
2233 __builtin_isnan(x), but the bundled gcc, which identifies itself
2234 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2235 a __builtin_isnan.
2236 * floatfns.c (isnan): #undef, and then #define to a clone of
2237 what's in data.c.
2238 (Fisnan): Always define, since it's always available now.
2239 (syms_of_floatfns): Always define isnan at the Lisp level.
2240
2241 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2242
2243 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2244
2245 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2246
2247 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2248 The previous code assumed that file offsets (off_t values) fit in
2249 EMACS_INT variables, which is not true on typical 32-bit hosts.
2250 The code messed up by falsely reporting buffer overflow in cases
2251 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2252 when "big" contains more than 2**29 bytes, even though this
2253 inserts just one byte and does not overflow the buffer.
2254 (Finsert_file_contents): Store file offsets as off_t
2255 values, not as EMACS_INT values. Check for overflow when
2256 converting between EMACS_INT and off_t. When checking for
2257 buffer overflow or for overlap, take the offsets into account.
2258 Don't use EMACS_INT for small values where int suffices.
2259 When checking for overlap, fix a typo: ZV was used where
2260 ZV_BYTE was intended.
2261 (Fwrite_region): Don't assume off_t fits into 'long'.
2262 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2263
2264 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2265
2266 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2267
2268 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2269
2270 sprintf-related integer and memory overflow issues (Bug#9412).
2271
2272 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2273 (esprintf, exprintf, evxprintf): New functions.
2274 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2275 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2276 (modify_event_symbol): Do not assume that the length of
2277 name_alist_or_stem is safe to alloca and fits in int.
2278 (Fexecute_extended_command): Likewise for function name and binding.
2279 (Frecursion_depth): Wrap around reliably on integer overflow.
2280 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2281 since some callers pass EMACS_INT values.
2282 (Fsingle_key_description): Don't crash if symbol name contains more
2283 than MAX_ALLOCA bytes.
2284 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2285 (get_minibuffer): Arg is now EMACS_INT, not int.
2286 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2287 (esprintf, exprintf, evxprintf): New decls.
2288 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2289
2290 * dbusbind.c (signature_cat): New function.
2291 (xd_signature, Fdbus_register_signal):
2292 Do not overrun buffer; instead, report string overflow.
2293
2294 * dispnew.c (add_window_display_history): Don't overrun buffer.
2295 Truncate instead; this is OK since it's just a log.
2296
2297 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2298 even if the time zone offset is outlandishly large.
2299 Don't mishandle offset == INT_MIN.
2300
2301 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2302 when creating daemon; the previous buffer-overflow check was incorrect.
2303
2304 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2305 which has the guts of the old verror function.
2306
2307 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2308 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2309
2310 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2311 (font_unparse_xlfd): Don't blindly alloca long strings.
2312 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2313 fits in int, when using sprintf. Use single snprintf to count
2314 length of string rather than counting it via multiple sprintfs;
2315 that's simpler and more reliable.
2316 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2317 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2318 sprintf, in case result does not fit in int.
2319
2320 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2321 (fontset_from_font): Print it.
2322
2323 * frame.c (tty_frame_count): Now printmax_t, not int.
2324 (make_terminal_frame, set_term_frame_name): Print it.
2325 (x_report_frame_params): In X, window IDs are unsigned long,
2326 not signed long, so print them as unsigned.
2327 (validate_x_resource_name): Check for implausibly long names,
2328 and don't assume name length fits in 'int'.
2329 (x_get_resource_string): Don't blindly alloca invocation name;
2330 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2331 not fit in int.
2332
2333 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2334 (xg_check_special_colors, xg_set_geometry):
2335 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2336
2337 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2338 Use esprintf, not sprintf, in case result does not fit in int.
2339
2340 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2341 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2342 it as a large positive number.
2343 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2344 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2345
2346 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2347 in case result does not fit in int.
2348
2349 * print.c (float_to_string): Detect width overflow more reliably.
2350 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2351 buffer overrun. Don't assume list length fits in 'int'. Treat
2352 print length of 0 as 0, not as infinity; to be consistent with other
2353 uses of print length in this function. Don't overflow print length
2354 index. Don't assume hash table size fits in 'long', or that
2355 vectorlike size fits in 'unsigned long'.
2356
2357 * process.c (make_process): Use printmax_t, not int, to format
2358 process-name gensyms.
2359
2360 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2361
2362 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2363 to avoid potential buffer overrun.
2364
2365 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2366 if X resource line is longer than 512 bytes.
2367
2368 * xfns.c (x_window): Make sprintf buffer a bit bigger
2369 to avoid potential buffer overrun.
2370
2371 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2372
2373 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2374
2375 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2376
2377 Integer overflow fixes for scrolling, etc.
2378 Without these, Emacs silently mishandles large integers sometimes.
2379 For example, "C-u 4294967297 M-x recenter" was treated as if
2380 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2381
2382 * xdisp.c (try_window_id): Check Emacs fixnum range before
2383 converting to 'int'.
2384
2385 * window.c (window_scroll_line_based, Frecenter):
2386 Check that an Emacs fixnum is in range before assigning it to 'int'.
2387 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2388 values converted from Emacs fixnums.
2389 (Frecenter): Don't wrap around a line count if it is out of 'int'
2390 range; instead, treat it as an extreme value.
2391 (Fset_window_configuration, compare_window_configurations):
2392 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2393
2394 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2395 that can exceed INT_MAX. Check that EMACS_INT value is in range
2396 before assigning it to the (possibly-narrower) index.
2397 (match_limit): Don't assume that a fixnum can fit in 'int'.
2398
2399 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2400 exceed INT_MAX.
2401
2402 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2403 (Fvertical_motion): Don't wrap around LINES values that don't fit
2404 in 'int'. Instead, treat them as extreme values. This is good
2405 enough for windows, which can't have more than INT_MAX lines anyway.
2406
2407 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2408
2409 * Require libxml/parser.h to avoid compilation warning.
2410
2411 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2412
2413 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2414 since this reportedly can destroy thread storage.
2415
2416 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2417
2418 * syntax.c (find_defun_start): Update all cache variables if
2419 exiting early (Bug#9401).
2420
2421 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2422
2423 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2424
2425 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2426 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2427 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2428
2429 * term.c (tty_append_glyph): New function.
2430 (produce_stretch_glyph): Static function and its prototype deleted.
2431
2432 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2433 Add prototypes.
2434
2435 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2436
2437 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2438 when checking :margin (Bug#9390).
2439 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2440 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2441 so that the name doesn't mislead. All uses changed.
2442
2443 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2444
2445 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2446 set_tty_hooks.
2447
2448 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2449
2450 * xdisp.c (move_it_to): Don't bail out early when reaching
2451 position beyond to_charpos, if we are scanning backwards.
2452 (move_it_vertically_backward): When DY == 0, make sure we get to
2453 the first character in the line after the newline.
2454
2455 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2456
2457 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2458 (ccl_driver): Do not generate an out-of-range pointer.
2459 (Fccl_execute_on_string): Remove unnecessary check for
2460 integer overflow, noted by Stefan Monnier in
2461 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2462 Remove a FIXME that didn't need fixing.
2463 Simplify the newly-introduced buffer reallocation code.
2464
2465 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2466
2467 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2468
2469 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2470
2471 Integer and memory overflow issues (Bug#9196).
2472
2473 * doc.c (get_doc_string): Rework so that
2474 get_doc_string_buffer_size is the actual buffer size, rather than
2475 being 1 less than the actual buffer size; this makes xpalloc more
2476 convenient.
2477
2478 * image.c (x_allocate_bitmap_record, cache_image):
2479 * xselect.c (Fx_register_dnd_atom):
2480 Simplify previous changes by using xpalloc.
2481
2482 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2483 since either will do and ptrdiff_t is convenient with xpalloc.
2484
2485 * charset.c (charset_table_size)
2486 (struct charset_sort_data.priority): Now ptrdiff_t.
2487 (charset_compare): Don't overflow if priorities differ greatly.
2488 (Fsort_charsets): Don't assume list length fits in int.
2489 Check for size-calculation overflow when allocating sort data.
2490 (syms_of_charset): Allocate an initial charset table that is
2491 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2492
2493 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2494
2495 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2496 The actual value is always <= INT_MAX, and leaving it unsigned made
2497 overflow checking harder.
2498
2499 * dispextern.h (struct glyph_matrix.rows_allocated)
2500 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2501 with xpalloc. The values are still always <= INT_MAX.
2502
2503 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2504
2505 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2506 (SAFE_NALLOCA): New macro.
2507
2508 * region-cache.c (struct boundary.pos, find_cache_boundary)
2509 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2510 (set_cache_region, invalidate_region_cache)
2511 (revalidate_region_cache, know_region_cache, region_cache_forward)
2512 (region_cache_backward, pp_cache):
2513 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2514 so that ptrdiff_t * can be passed to xpalloc.
2515 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2516 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2517 (pp_cache): Don't assume cache_len fits in int.
2518 * region-cache.h: Adjust extern decls to match.
2519
2520 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2521 EMACS_INT, since either will do, for xpalloc.
2522
2523 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2524 (xnmalloc, xnrealloc, xpalloc): New functions.
2525
2526 * bidi.c (bidi_shelve_header_size): New constant.
2527 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2528 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2529
2530 * bidi.c (bidi_cache_shrink):
2531 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2532 (overlay_strings):
2533 Don't update size of array until after memory allocation succeeds,
2534 because xmalloc/xrealloc may not return.
2535 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2536 now that we have proper integer overflow checking.
2537 (record_overlay_string, overlay_strings): Catch overflows when
2538 calculating size of overlay_str_buf.
2539
2540 * callproc.c (Fcall_process): Check for size overflow when
2541 calculating size of args2.
2542 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2543 Normally we prefer signed values, but sticking with ptrdiff_t would
2544 require adding more-complicated checks.
2545
2546 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2547 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2548 Redo buffer-overflow calculations to avoid integer overflow.
2549 Add a FIXME comment where memory seems to be over-allocated.
2550
2551 * character.c (Fstring): Check for size-calculation overflow.
2552
2553 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2554 unnecessary integer overflow. Check for size overflow.
2555 (encode_coding_object): Don't update size until xmalloc succeeds.
2556
2557 * composite.c (get_composition_id): Check for overflow in glyph
2558 length calculations.
2559
2560 Integer and memory overflow fixes for display code.
2561 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2562 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2563 (scrolling_window): Check for overflow in size calculations.
2564 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2565 Don't assume glyph table len fits in int.
2566 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2567 (row_table_size): Now ptrdiff_t, not int.
2568 (scrolling_window): Avoid overflow in size calculations.
2569 Don't update size until allocation succeeds.
2570 * fns.c (concat): Check for overflow in size calculations.
2571 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2572 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2573 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2574
2575 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2576 (get_doc_string): Check for size calculation overflow.
2577 Don't update size until allocation succeeds.
2578 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2579 EMACS_INT, where ptrdiff_t will do.
2580 (Fsubstitute_command_keys): Check for string overflow.
2581
2582 * editfns.c (set_time_zone_rule): Don't assume environment length
2583 fits in int.
2584 (message_length): Now ptrdiff_t, not int.
2585 (Fmessage_box): Don't update size until allocation succeeds.
2586 Don't assume message length fits in int.
2587 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2588
2589 * emacs.c (main): Do not reallocate argv, since there is a null at
2590 the end that can be overwritten, and this way there's no need to
2591 worry about size-calculation overflow.
2592 (sort_args): Check for size-calculation overflow.
2593
2594 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2595 alloc succeeds.
2596 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2597
2598 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2599 (x_set_scroll_bar_width, x_figure_window_size):
2600 Check for integer overflow.
2601 (x_set_alpha): Do not assume XINT fits in int.
2602
2603 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2604 This is for the members text_lines, text_cols, total_lines, total_cols,
2605 where the system imposes an 'int' limit.
2606
2607 * fringe.c (Fdefine_fringe_bitmap):
2608 Don't update size until alloc works.
2609
2610 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2611 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2612
2613 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2614 Check for size-calculation overflow.
2615 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2616 do, as we prefer signed integers.
2617 (id_to_widget.max_size, id_to_widget.used)
2618 (xg_store_widget_in_map, xg_remove_widget_from_map)
2619 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2620 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2621 Use and return ptrdiff_t, not int.
2622 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2623 * gtkutil.h: Change prototypes to match the above.
2624
2625 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2626 are duplicate now that they've been promoted to lisp.h.
2627 (x_allocate_bitmap_record, x_alloc_image_color)
2628 (make_image_cache, cache_image, xpm_load):
2629 Don't update size until alloc is done.
2630 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2631 (x_detect_edges):
2632 Check for size calculation overflow.
2633 (ct_colors_allocated_max): New constant.
2634 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2635 overflow.
2636
2637 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2638 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2639 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2640 Use ptrdiff_t, not int, to count maps.
2641 (read_char_minibuf_menu_prompt): Check for overflow in size
2642 calculations. Don't update size until allocation succeeds.
2643 Redo calculations to avoid overflow.
2644 * keyboard.h: Change prototypes to match the above.
2645
2646 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2647 to count maps.
2648 (current_minor_maps): Check for size calculation overflow.
2649 * keymap.h: Change prototypes to match the above.
2650
2651 * lread.c (read1, init_obarray): Don't update size until alloc done.
2652
2653 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2654 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2655
2656 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2657 Now ptrdiff_t, not int.
2658 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2659 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2660
2661 * process.c (Fnetwork_interface_list): Check for overflow
2662 in size calculation.
2663
2664 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2665
2666 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2667 overflow. Don't bother calling xmalloc when xrealloc will do.
2668
2669 * search.c (Freplace_match): Check for size calculation overflow.
2670 (Fset_match_data): Don't assume list lengths fit in 'int'.
2671
2672 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2673 for command line length. Do not attempt to address one before the
2674 beginning of an array, as that's not portable.
2675
2676 * term.c (max_frame_lines): Remove; unused.
2677 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2678 not int.
2679 (encode_terminal_code, calculate_costs): Check for size
2680 calculation overflow.
2681 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2682 table lengths and related sizes. Don't update size until alloc
2683 done. Redo calculations to avoid overflow.
2684 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2685
2686 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2687 subtracting pointers.
2688 (gobble_line): Check for overflow more carefully. Don't update size
2689 until alloc done.
2690
2691 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2692 Don't update size until alloc done.
2693 Redo size calculations to avoid overflow.
2694 Check for size calculation overflow.
2695 (main) [DEBUG]: Fix typo in invoking tparam1.
2696
2697 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2698 Use ptrdiff_t, not int, for sizes.
2699 (store_mode_line_noprop_char): Don't update size until alloc done.
2700
2701 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2702 Use ptrdiff_t, not int, for sizes.
2703 (Finternal_make_lisp_face, cache_face):
2704 Check for size calculation overflow.
2705 (cache_face): Treat size calculation overflows as if they were
2706 memory exhaustion (the usual treatment), rather than aborting.
2707
2708 * xfns.c (x_encode_text, x_set_name_internal)
2709 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2710 sizes, since they can exceed INT_MAX in size. Check for size
2711 calculation overflow.
2712
2713 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2714 (xg_select): Check for size calculation overflow.
2715 Don't update size until alloc done.
2716
2717 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2718 as sprintf is limited to int lengths.
2719
2720 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2721 (X_LONG_MIN): New macros.
2722 Use them to make the following changes clearer.
2723 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2724 This change doesn't affect the value now, but it may help remind
2725 future maintainers not to raise the value too much later.
2726 (SELECTION_QUANTUM): Remove, replacing with ...
2727 (selection_quantum): ... new function, which avoids overflow.
2728 All uses changed.
2729 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2730 assumption that selection length fits in 'int'.
2731 (x_reply_selection_request, x_handle_selection_request)
2732 (x_get_window_property, receive_incremental_selection)
2733 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2734 (lisp_data_to_selection_data, clean_local_selection_data):
2735 Use ptrdiff_t, not int, to record length of selection.
2736 (x_reply_selection_request, x_get_window_property)
2737 (receive_incremental_selection, x_property_data_to_lisp):
2738 Redo calculations to avoid overflow.
2739 (x_reply_selection_request): When sending hint, ceiling it at
2740 X_LONG_MAX rather than relying on wraparound overflow to send
2741 something.
2742 (x_get_window_property, receive_incremental_selection)
2743 (lisp_data_to_selection_data, x_property_data_to_lisp):
2744 Check for size-calculation overflow.
2745 (x_get_window_property, receive_incremental_selection)
2746 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2747 Don't store size until memory allocation succeeds.
2748 (x_get_window_property): Plug memory leak on memory exhaustion.
2749 Don't double-block input; malloc is safe here. Don't assume 2**34
2750 - 4 fits in unsigned long. Add an xassert to check
2751 XGetWindowProperty overflow. Be more careful about overflow
2752 calculations, and distinguish size from memory overflow better.
2753 (receive_incremental_selection): When tracing, don't assume
2754 unsigned int is less than INT_MAX.
2755 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2756 harmful) conversions of unsigned short to int.
2757 (lisp_data_to_selection_data): Don't assume that integers
2758 in the range -65535 through -1 fit in an X unsigned short.
2759 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2760 result parameters unless successful. Rely on cons_to_unsigned
2761 to report problems with elements; the old code wasn't right anyway.
2762 (x_check_property_data): Check for int overflow; we cannot use
2763 a wider type due to X limits.
2764 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2765
2766 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2767
2768 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2769 (x_term_init): Check for size calculation overflow.
2770 (x_color_cells): Don't store size until memory allocation succeeds.
2771 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2772 Don't assume alloca size is less than MAX_ALLOCA.
2773 (x_term_init): Don't assume length fits in int (sprintf is limited
2774 to int size).
2775
2776 Use ptrdiff_t for composition IDs.
2777 * character.c (lisp_string_width):
2778 * composite.c (composition_table_size, n_compositions)
2779 (get_composition_id, composition_gstring_from_id):
2780 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2781 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2782 * window.c (Frecenter):
2783 Use ptrdiff_t, not int, for composition IDs.
2784 * composite.c (get_composition_id): Check for integer overflow.
2785 * composite.h: Adjust prototypes to match the above changes.
2786
2787 Use ptrdiff_t for hash table indexes.
2788 * category.c (hash_get_category_set):
2789 * ccl.c (ccl_driver):
2790 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2791 * coding.c (coding_system_charset_list, detect_coding_system):
2792 * coding.h (struct coding_system.id):
2793 * composite.c (get_composition_id, gstring_lookup_cache):
2794 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2795 * image.c (xpm_get_color_table_h):
2796 * lisp.h (hash_lookup, hash_put):
2797 * minibuf.c (Ftest_completion):
2798 Use ptrdiff_t for hash table indexes, not int (which is too
2799 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2800 32-bit --with-wide-int hosts).
2801
2802 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2803 Add a FIXME comment about memory leaks.
2804 (syms_of_charset): Don't assume xmalloc returns.
2805
2806 Don't assume that stated character widths fit in int.
2807 * character.c (Fchar_width, c_string_width, lisp_string_width):
2808 * character.h (CHAR_WIDTH):
2809 * indent.c (MULTIBYTE_BYTES_WIDTH):
2810 Use sanitize_char_width to avoid undefined and/or bad behavior
2811 with outlandish widths.
2812 * character.h (sanitize_tab_width): Rename from sanitize_width,
2813 now that we have two such functions. All uses changed.
2814 (sanitize_char_width): New inline function.
2815
2816 Don't assume that tab-width fits in int.
2817 * character.h (sanitize_width): New inline function.
2818 (SANE_TAB_WIDTH): New macro.
2819 (ASCII_CHAR_WIDTH): Use it.
2820 * indent.c (sane_tab_width): Remove. All uses replaced by
2821 SANE_TAB_WIDTH (current_buffer).
2822 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2823
2824 * fileio.c: Integer overflow issues with file modes.
2825 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2826
2827 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2828 Remove unreachable code.
2829 (read_hex, load_charset_map_from_file): Check for integer overflow.
2830
2831 * xterm.c: Don't go over XClientMessageEvent limit.
2832 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2833 (x_send_scroll_bar_event): Likewise. Check that the size does not
2834 exceed limits imposed by XClientMessageEvent, as well as the usual
2835 ptrdiff_t and size_t limits.
2836
2837 * keyboard.c: Overflow, signedness and related fixes.
2838 (make_lispy_movement): Use same integer type in forward decl
2839 that is used in the definition.
2840 (read_key_sequence, keyremap_step):
2841 Change bufsize argument back to int, undoing my 2011-03-30 change.
2842 We prefer signed types, and int is wide enough here.
2843 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2844 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2845 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2846 length, not size_t. Use ptrdiff_t for index, not int.
2847 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2848 possibility of integer overflow.
2849
2850 Overflow, signedness and related fixes for images.
2851
2852 * dispextern.h (struct it.stack[0].u.image.image_id)
2853 (struct_it.image_id, struct image.id, struct image_cache.size)
2854 (struct image_cache.used, struct image_cache.ref_count):
2855 * gtkutil.c (update_frame_tool_bar):
2856 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2857 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2858 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2859 * nsmenu.m (update_frame_tool_bar):
2860 * xdisp.c (calc_pixel_width_or_height):
2861 * xfns.c (image_cache_refcount):
2862 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2863 on typical 64-bit hosts.
2864
2865 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2866 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2867 Omit unnecessary casts to int.
2868 (parse_image_spec): Check that integers fall into 'int' range
2869 when the callers expect that.
2870 (image_ascent): Redo ascent calculation to avoid int overflow.
2871 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2872 (lookup_image): Remove unnecessary tests.
2873 (xbm_image_p): Locals are now of int, not EMACS_INT,
2874 since parse_image_check makes sure they fit into int.
2875 (png_load, gif_load, svg_load_image):
2876 Prefer int to unsigned where either will do.
2877 (tiff_handler): New function, combining the cores of the
2878 old tiff_error_handler and tiff_warning_handler.
2879 This function is rewritten to use vsnprintf and thereby avoid
2880 stack buffer overflows. It uses only the features of vsnprintf
2881 that are common to both POSIX and native Microsoft.
2882 (tiff_error_handler, tiff_warning_handler): Use it.
2883 (tiff_load, gif_load, imagemagick_load_image):
2884 Don't assume :index value fits in 'int'.
2885 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2886 (imagemagick_load_image): Check that crop parameters fit into
2887 the integer types that MagickCropImage accepts. Don't assume
2888 Vimagemagick_render_type has a nonnegative value. Don't assume
2889 size_t fits in 'long'.
2890 (gs_load): Use printmax_t to print the widest integers possible.
2891 Check for integer overflow when computing image height and width.
2892
2893 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2894
2895 * xdisp.c (redisplay_window): Don't force window start if point
2896 will be invisible in the resulting window. (Bug#9324)
2897
2898 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2899
2900 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2901 the display spec is of the form `(space ...)'.
2902 (handle_display_spec): Return the value returned by
2903 handle_single_display_spec, not just 1 or zero.
2904 (handle_single_display_spec): If the display spec is of the form
2905 `(space ...)', and specifies display in the text area, return 2
2906 rather than 1.
2907 (try_cursor_movement): Check for the need to scroll more
2908 accurately, and prefer exact match for point under bidi.
2909 Don't advance `row' beyond the last row of the window.
2910
2911 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2912 into disp_prop; all users changed.
2913
2914 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2915 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2916 for the text covered by the display property.
2917
2918 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2919
2920 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2921 Change return value to nil.
2922 (Frecord_buffer): Delete unused function.
2923
2924 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2925
2926 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2927 buffers, return left-to-right.
2928 (set_cursor_from_row): Consider candidate row a win if its glyph
2929 represents a newline and point is on that newline. Fixes cursor
2930 positioning on the newline at EOL of R2L text within L2R
2931 paragraph, and vice versa.
2932 (try_cursor_movement): Check continued rows, in addition to
2933 continuation rows. Fixes unwarranted scroll when point enters a
2934 continued line of R2L text within an L2R paragraph, or vice versa.
2935 (cursor_row_p): Consider the case of point being equal to
2936 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2937 from the end of a short line to the beginning of a continued line
2938 of R2L text within L2R paragraph.
2939 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2940 composed characters.
2941
2942 * bidi.c (bidi_check_type): Use xassert.
2943 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2944 members.
2945
2946 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2947
2948 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2949 a character.
2950
2951 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2952
2953 * nsfont.m (ns_otf_to_script): Fix typo.
2954
2955 2011-08-22 Kenichi Handa <handa@m17n.org>
2956
2957 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2958 extra slot even if the purpose is char-code-property-table.
2959
2960 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2961
2962 * xdisp.c (redisplay_window): When computing centering_position,
2963 account for the height of the header line. (Bug#8874)
2964
2965 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2966 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2967 candidate is selected by the mouse, and that candidate has a
2968 composed character under the mouse.
2969
2970 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2971 coordinates reported by pos-visible-in-window-p for a composed
2972 character in column zero.
2973
2974 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2975
2976 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2977
2978 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2979
2980 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2981 consider it a hit if to_charpos is anywhere in the range of the
2982 composed buffer positions.
2983
2984 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2985
2986 * image.c (gif_load): Don't assume that each subimage has the same
2987 dimensions as the base image. Handle disposal method that is
2988 "undefined" by the gif spec (Bug#9335).
2989
2990 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2991
2992 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2993 (Fcondition_case): Document `debug' symbol in error handler.
2994
2995 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2996
2997 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2998 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2999 from an Org mode buffer to a Speedbar frame.
3000
3001 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3002 a composition, take its buffer position from IT->cmp_it.charpos.
3003 Fixes cursor positioning at the beginning of a line that begins
3004 with a composed character.
3005
3006 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3007
3008 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3009 character bidirectional type, use STRONG_L instead. Fixes crashes
3010 in a buffer produced by `describe-categories'.
3011
3012 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3013 members before the level stack, so they would be saved and
3014 restored when copying iterator state. Fixes incorrect reordering
3015 around TABs covered by display properties.
3016
3017 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3018
3019 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3020
3021 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3022
3023 * eval.c (internal_condition_case, internal_condition_case_1)
3024 (internal_condition_case_2, internal_condition_case_n):
3025 Remove unnecessary aborts (Bug#9081).
3026
3027 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3028
3029 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3030 has no `load' handler, try opening the file locally. (Bug#9311)
3031
3032 2011-08-16 Ken Brown <kbrown@cornell.edu>
3033
3034 * gmalloc.c: Expand comment.
3035
3036 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3037
3038 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3039 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3040
3041 2011-08-16 Ken Brown <kbrown@cornell.edu>
3042
3043 Fix memory allocation problems in Cygwin build (Bug#9273).
3044
3045 * unexcw.c ( __malloc_initialized): Declare external variable.
3046 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3047
3048 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3049 New variables.
3050 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3051 dumped emacs.
3052 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3053 in the static heap.
3054 [CYGWIN] (special_realloc): New function.
3055 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3056 requests to realloc storage in the static heap.
3057
3058 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3059
3060 * bidi.c (bidi_initialize): Remove unused local.
3061
3062 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3063
3064 * bidimirror.h:
3065 * biditype.h: Remove file.
3066 * makefile.w32-in ($(BLD)/bidi.$(O)):
3067 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3068
3069 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3070
3071 * chartab.c: Improve commentary for the uniprop_table API.
3072
3073 * bidi.c (bidi_paragraph_init): Support zero value of
3074 bidi_ignore_explicit_marks_for_paragraph_level.
3075 (bidi_initialize): Use uniprop_table instead of including
3076 biditype.h and bidimirror.h.
3077
3078 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3079 coordinates of the iterator when restoring from ppos_it.
3080 (Bug#9296)
3081
3082 2011-08-14 Kenichi Handa <handa@m17n.org>
3083
3084 * process.c (create_process): Call setup_process_coding_systems
3085 after the pid of the process is set to -1 (Bug#8162).
3086
3087 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3088
3089 * xdisp.c (move_it_in_display_line_to): Don't invoke
3090 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3091 ppos_it. Fixes vertical cursor motion when line beginning is
3092 covered by an image. (Bug#9296)
3093
3094 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3095
3096 * nsterm.h (ns_run_ascript): Declare.
3097 (NSAPP_DATA2_RUNASSCRIPT): Define.
3098
3099 * nsfns.m (as_script, as_result, as_status): New static variables.
3100 (ns_run_ascript): New function.
3101 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3102 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3103 the event loop. Get status from as_status (Bug#7276).
3104
3105 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3106 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3107 the event loop (Bug#7276).
3108
3109 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3110
3111 * gnutls.c (QCgnutls_bootprop_priority)
3112 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3113 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3114 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3115 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3116 (QCgnutls_bootprop_verify_hostname_error)
3117 (QCgnutls_bootprop_callbacks_verify): Rename from
3118 Qgnutls_bootprop_..., all uses changed.
3119
3120 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3121 uses changed.
3122
3123 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3124
3125 * xfaces.c (Qframe_set_background_mode): Now static.
3126 * dispextern.h (Qframe_set_background_mode): Remove decl.
3127
3128 * process.c (Fnetwork_interface_info): Declare local only if needed.
3129
3130 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3131
3132 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3133 (Fnetwork_interface_list): Allocate in increments of bytes instead
3134 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3135 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3136 sockaddr.
3137 (struct ifflag_def): notrailers is smart on OSX.
3138 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3139 Get hardware address with getifaddrs if available.
3140
3141 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3142
3143 * xdisp.c (iterate_out_of_display_property): xassert that
3144 IT->position is set to within IT->object's boundaries. Break from
3145 the loop as soon as EOB is reached; avoids infloops in redisplay
3146 when IT->position is set up wrongly due to some bug.
3147 Set IT->current to match the bidi iterator unconditionally.
3148 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3149 entry. Force push_it to save on the stack the current
3150 buffer/string position, to be restored by pop_it. Fix flags in
3151 the iterator structure wrt the object coming from a display
3152 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3153 properties. (Bug#9284)
3154
3155 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3156
3157 * fontset.c (fontset_get_font_group): Add proper type checks.
3158 (Bug#9172)
3159
3160 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3161
3162 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3163 and LC_VERSION_MIN_MACOSX.
3164 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3165 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3166
3167 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3168
3169 * xdisp.c (forward_to_next_line_start): Allow to use the
3170 no-display-properties-and-no-overlays under bidi display.
3171 Set disp_pos in the bidi iterator to avoid searches for display
3172 properties and overlays.
3173
3174 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3175
3176 * editfns.c (Fset_time_zone_rule): Document relationship with the
3177 setenv function.
3178
3179 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3180 the font entity extracted from the cache (Bug#8109).
3181
3182 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3183
3184 * composite.c (autocmp_chars): Don't reset point. That is done by
3185 restore_point_unwind (Bug#5984).
3186
3187 2011-08-07 Juri Linkov <juri@jurta.org>
3188
3189 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3190 to show the arg `TIME' instead of `TIMEVAL'.
3191
3192 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3193
3194 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3195 display property strides EOL and includes a newline, as in
3196 longlines-mode. (Bug#9254)
3197 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3198 word-wrap under bidirectional display. (Bug#9224)
3199
3200 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3201 is non-zero, even if the data buffer is NULL. Fixes a crash in
3202 vertical-motion with longlines-mode. (Bug#9254)
3203
3204 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3205
3206 * bidi.c <bidi_cache_total_alloc>: Now static.
3207 (bidi_initialize): Initialize bidi_cache_total_alloc.
3208
3209 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3210 cache. (Bug#9221)
3211
3212 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3213 amount allocated this far in `bidi_cache_total_alloc'.
3214 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3215 non-zero, only free the data buffer without restoring the cache
3216 contents. All callers changed.
3217
3218 * dispextern.h (bidi_unshelve_cache): Update prototype.
3219
3220 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3221 (move_it_in_display_line, move_it_to)
3222 (move_it_vertically_backward, move_it_by_lines): Replace the call
3223 to xfree to an equivalent call to bidi_unshelve_cache.
3224 (move_it_in_display_line_to): Fix logic of returning
3225 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3226
3227 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3228
3229 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3230 came from a string character with a `cursor' property. (Bug#9229)
3231
3232 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3233
3234 * Makefile.in (LIB_PTHREAD): New variable.
3235 (LIBES): Add LIB_PTHREAD (Bug#9216).
3236
3237 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3238 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3239
3240 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3241
3242 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3243
3244 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3245
3246 * xterm.c (x_find_topmost_parent): New function.
3247 (x_set_frame_alpha): Find topmost parent window with
3248 x_find_topmost_parent and set the property there also (bug#9181).
3249 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3250
3251 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3252
3253 * callproc.c (Fcall_process): Avoid vfork clobbering
3254 the local vars buffer, coding_systems, current_dir.
3255
3256 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3257
3258 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3259
3260 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3261
3262 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3263 so that it is not optimized away.
3264
3265 * xdisp.c (compute_display_string_pos): Remove unused local.
3266
3267 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3268
3269 Fix slow cursor motion and scrolling in large buffers with
3270 selective display, like Org Mode buffers. (Bug#9218)
3271
3272 * dispextern.h (struct bidi_it): New member disp_prop_p.
3273
3274 * xdisp.c: Remove one-slot cache of display string positions.
3275 (compute_display_string_pos): Accept an additional argument
3276 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3277 for a display string or property. If found, set DISP_PROP_P
3278 non-zero.
3279
3280 * bidi.c (bidi_fetch_char): Accept an additional argument
3281 DISP_PROP_P, and pass it to compute_display_string_pos.
3282 Only handle text covered by a display string if DISP_PROP_P is returned
3283 non-zero. All callers of bidi_fetch_char changed.
3284
3285 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3286
3287 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3288
3289 2010-12-03 Don March <don@ohspite.net>
3290
3291 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3292 last character M-[char] is translated to ESC [char] (bug#7541).
3293
3294 2011-08-02 Kenichi Handa <handa@m17n.org>
3295
3296 * lisp.h (uniprop_table): Extern it.
3297
3298 * chartab.c (uniprop_table): Make it non-static.
3299
3300 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3301
3302 * xdisp.c (forward_to_next_line_start): Accept additional argument
3303 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3304 on the newline.
3305 (reseat_at_next_visible_line_start): Use the bidi iterator state
3306 returned by forward_to_next_line_start to restore the state of
3307 it->bidi_it after backing up to previous newline. (Bug#9212)
3308
3309 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3310
3311 * regex.c (re_comp): Protoize.
3312 (re_exec): Fix return type.
3313 (regexec): Fix type of `ret'. (Bug#9203)
3314
3315 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3316
3317 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3318 This is needed if max-image-size is a floating-point number.
3319
3320 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3321
3322 * print.c (print_object): Print empty symbol as ##.
3323
3324 * lread.c (read1): Read ## as empty symbol.
3325
3326 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3327
3328 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3329 setting frame foreground color (Bug#9175).
3330 (x_set_background_color): Likewise.
3331
3332 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3333 contents (Bug#9176).
3334 (EmacsTooltip -init): Remove bezels and add shadows to
3335 tooltip windows.
3336
3337 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3338 or scroll bar (Bug#8470).
3339
3340 * nsfont.m (nsfont_open): Remove assignment to voffset and
3341 unnecessary vars hshink, expand, hd, full_height, min_height.
3342 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3343
3344 * nsterm.h (nsfont_info): Remove voffset field.
3345
3346 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3347
3348 Implement strike-through and overline on NextStep (Bug#8863).
3349
3350 * nsfont.m (nsfont_open): Use underline position provided by font,
3351 instead of hard-coded value of 2.
3352 (nsfont_draw): Call ns_draw_text_decoration instead.
3353
3354 * nsterm.h: Add declaration for ns_draw_text_decoration.
3355
3356 * nsterm.m (ns_draw_text_decoration): New function for drawing
3357 underline, overline, and strike-through.
3358 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3359 ns_draw_text_decoration. Change treatment of cursor drawing to
3360 accommodate underlining, etc.
3361
3362 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3363
3364 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3365 default.
3366
3367 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3368
3369 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3370 Without this fix, if a signal arrives just after memory fills up,
3371 'malloc' might be invoked reentrantly.
3372
3373 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3374 In other words, assume that every image size is allowed, on non-X
3375 hosts. This assumption is probably wrong, but it lets Emacs compile.
3376
3377 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3378
3379 * regex.c (re_iswctype): Convert return values to boolean.
3380
3381 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3382
3383 * xdisp.c (compute_display_string_pos): Don't use cached display
3384 string position if the buffer had its restriction changed.
3385 (Bug#9184)
3386
3387 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3388
3389 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3390
3391 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3392
3393 Integer signedness and overflow and related fixes. (Bug#9079)
3394
3395 * bidi.c: Integer size and overflow fixes.
3396 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3397 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3398 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3399 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3400 (bidi_find_other_level_edge):
3401 Use ptrdiff_t instead of EMACS_INT where either will do.
3402 This works better on 32-bit hosts configured --with-wide-int.
3403 (bidi_cache_ensure_space): Check for size-calculation overflow.
3404 Use % rather than repeated addition, for better worst-case speed.
3405 Don't set bidi_cache_size until after xrealloc returns, because it
3406 might not return.
3407 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3408 (bidi_cache_ensure_space): Also check that the bidi cache size
3409 does not exceed that of the largest Lisp string or buffer. See Eli
3410 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3411
3412 * alloc.c (__malloc_size_t): Remove.
3413 All uses replaced by size_t. See Andreas Schwab's note
3414 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3415
3416 * image.c: Improve checking for integer overflow.
3417 (check_image_size): Assume that f is nonnull, since
3418 it is always nonnull in practice. This is one less thing to
3419 worry about when checking for integer overflow later.
3420 (x_check_image_size): New function, which checks for integer
3421 overflow issues inside X.
3422 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3423 This removes the need for a memory_full check.
3424 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3425 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3426 (xbm_read_bitmap_data): Change locals back to 'int', since
3427 their values must fit in 'int'.
3428 (xpm_load_image, png_load, tiff_load):
3429 Invoke x_create_x_image_and_pixmap earlier,
3430 to avoid much needless work if the image is too large.
3431 (tiff_load): Treat overly large images as if
3432 x_create_x_image_and_pixmap failed, not as malloc failures.
3433 (gs_load): Use x_check_image_size.
3434
3435 * gtkutil.c: Omit integer casts.
3436 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3437 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3438
3439 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3440
3441 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3442 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3443 would wrongly return t on a 64-bit host.
3444
3445 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3446 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3447 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3448 and therefore cause GCC to emit a bogus diagnostic in some cases.
3449
3450 * image.c: Integer signedness and overflow and related fixes.
3451 This is not an exhaustive set of fixes, but it's time to
3452 record what I've got.
3453 (lookup_pixel_color, check_image_size): Remove redundant decls.
3454 (check_image_size): Don't assume that arbitrary EMACS_INT values
3455 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3456 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3457 (tiff_load, imagemagick_load_image):
3458 Check for overflow in size calculations.
3459 (x_create_x_image_and_pixmap): Remove unnecessary test for
3460 xmalloc returning NULL; that can't happen.
3461 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3462 (xpm_color_bucket): Use better integer hashing function.
3463 (xpm_cache_color): Don't possibly over-allocate memory.
3464 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3465 (gif_memory_source):
3466 Use ptrdiff_t, not int or size_t, to record sizes.
3467 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3468 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3469 either works, as we prefer signed integers.
3470 (tiff_read_from_memory, tiff_write_from_memory):
3471 Return tsize_t, not size_t, since that's what the TIFF API wants.
3472 (tiff_read_from_memory): Don't fail simply because the read would
3473 go past EOF; instead, return a short read.
3474 (tiff_load): Omit no-longer-needed casts.
3475 (Fimagemagick_types): Don't assume size fits into 'int'.
3476
3477 Improve hashing quality when configured --with-wide-int.
3478 * fns.c (hash_string): New function, taken from sxhash_string.
3479 Do not discard information about ASCII character case; this
3480 discarding is no longer needed.
3481 (sxhash-string): Use it. Change sig to match it. Caller changed.
3482 * lisp.h: Declare it.
3483 * lread.c (hash_string): Remove, since we now use fns.c's version.
3484 The fns.c version returns a wider integer if --with-wide-int is
3485 specified, so this should help the quality of the hashing a bit.
3486
3487 * emacs.c: Integer overflow minor fix.
3488 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3489 Define only if GNU_LINUX.
3490 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3491
3492 * dispnew.c: Integer signedness and overflow fixes.
3493 Remove unnecessary forward decls, that were a maintenance hassle.
3494 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3495 All uses changed.
3496 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3497 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3498 (prepare_desired_row, line_draw_cost):
3499 Use int, not unsigned, where either works.
3500 (save_current_matrix, restore_current_matrix):
3501 Use ptrdiff_t, not size_t, where either works.
3502 (init_display): Check for overflow more accurately, and without
3503 relying on undefined behavior.
3504
3505 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3506 Remove, replacing with the new symbols in lisp.h. All uses changed.
3507 * fileio.c (make_temp_name):
3508 * filelock.c (lock_file_1, lock_file):
3509 * xdisp.c (message_dolog):
3510 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3511 Use pMd etc. instead.
3512 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3513 replacing the pWIDE etc. symbols removed from editfns.c.
3514
3515 * keyboard.h (num_input_events): Now uintmax_t.
3516 This is (very slightly) less likely to mess up due to wraparound.
3517 All uses changed.
3518
3519 * buffer.c: Integer signedness fixes.
3520 (alloc_buffer_text, enlarge_buffer_text):
3521 Use ptrdiff_t rather than size_t when either will do, as we prefer
3522 signed integers.
3523
3524 * alloc.c: Integer signedness and overflow fixes.
3525 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3526 (__malloc_size_t): Default to size_t, not to int.
3527 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3528 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3529 Prefer ptrdiff_t to size_t when either would do, as we prefer
3530 signed integers.
3531 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3532 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3533 Now const. Initialize with values that are in range even if char
3534 is signed.
3535 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3536 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3537 These functions do the right thing with sizes > 2**32.
3538 (check_depth): Now ptrdiff_t, not int.
3539 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3540 Adjust to new way of storing sizes. Check for size overflow bugs
3541 in rest of code.
3542 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3543 slightly wrong anyway, as it missed one instance of
3544 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3545 (refill_memory_reserve): Omit needless cast to size_t.
3546 (mark_object_loop_halt): Mark as externally visible.
3547
3548 * xselect.c: Integer signedness and overflow fixes.
3549 (Fx_register_dnd_atom, x_handle_dnd_message):
3550 Use ptrdiff_t, not size_t, since we prefer signed.
3551 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3552 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3553 x_dnd_atoms_size and x_dnd_atoms_length.
3554
3555 * doprnt.c: Prefer signed to unsigned when either works.
3556 * eval.c (verror):
3557 * doprnt.c (doprnt):
3558 * lisp.h (doprnt):
3559 * xdisp.c (vmessage):
3560 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3561 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3562 prefer signed arithmetic to avoid comparison confusion.
3563 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3564 but is a bit tricky.
3565
3566 Assume freestanding C89 headers, string.h, stdlib.h.
3567 * data.c, doprnt.c, floatfns.c, print.c:
3568 Include float.h unconditionally.
3569 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3570 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3571 * regex.c: Likewise for stddef.h, string.h.
3572 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3573 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3574 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3575 (STDC_HEADERS): Remove obsolete defines.
3576 * sysdep.c: Include limits.h unconditionally.
3577
3578 Assume support for memcmp, memcpy, memmove, memset.
3579 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3580 * regex.c (memcmp, memcpy):
3581 Remove; we assume C89 now.
3582
3583 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3584 (__malloc_safe_bcopy): Remove; no longer needed.
3585
3586 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3587 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3588 well either way, and we prefer signed to unsigned.
3589
3590 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3591
3592 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3593 closes the connection while we're reading (bug#9182).
3594
3595 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3596
3597 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3598 are specified (Bug#9168).
3599
3600 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3601
3602 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3603 Found by GCC static checking and --with-wide-int on a 32-bit host.
3604
3605 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3606
3607 * xdisp.c (compute_display_string_pos): Fix logic of caching
3608 previous display string position. Initialize cached_prev_pos to
3609 -1. Fixes slow-down at the beginning of a buffer.
3610
3611 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3612
3613 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3614 for attrs[LFACE_FONTSET_INDEX].
3615
3616 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3617
3618 * xml.c (parse_region): Remove unused local
3619 that was recently introduced.
3620
3621 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3622
3623 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3624 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3625
3626 * xdisp.c (move_it_in_display_line_to): Record the best matching
3627 position for TO_CHARPOS while scanning the line, and restore it on
3628 exit if none of the characters scanned was an exact match.
3629 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3630 when exact match is impossible due to invisible text, and the
3631 lines are truncated.
3632
3633 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3634
3635 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3636 for OSX >= 10.7.
3637
3638 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3639
3640 Fix a significant slow-down of cursor motion with C-n, C-p,
3641 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3642 auto-repeat under bidi redisplay in fontified buffers.
3643 * xdisp.c (compute_stop_pos_backwards): New function.
3644 (next_element_from_buffer): Call compute_stop_pos_backwards to
3645 find a suitable prev_stop when we find ourselves before
3646 base_level_stop.
3647 (reseat): Don't look for prev_stop, as that could mean a very long
3648 run.
3649 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3650 <cached_disp_overlay_modiff>: Cache for last found display string
3651 position.
3652 (compute_display_string_pos): Return the cached position if asked
3653 about the same buffer in the same area of character positions, and
3654 the buffer wasn't changed since the time the display string
3655 position was cached.
3656
3657 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3658
3659 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3660 is an integer, which is important for empty lines. (Bug#9149)
3661
3662 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3663
3664 * frame.c (Fmodify_frame_parameters): In tty case, update the
3665 default face if necessary (Bug#4238).
3666
3667 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3668
3669 * editfns.c (Fstring_to_char): No need to explain what a character
3670 is in the docstring (Bug#6576).
3671
3672 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3673
3674 * xml.c (parse_region): Make sure we always return a tree.
3675
3676 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3677
3678 * xml.c (parse_region): If a document contains only comments,
3679 return that, too.
3680
3681 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3682
3683 * xml.c (make_dom): Return comments, too.
3684
3685 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3686
3687 Port to OpenBSD.
3688 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3689 and the surrounding thread.
3690 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3691 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3692 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3693 timer goes off.
3694 * s/openbsd.h (BROKEN_SIGIO): Define.
3695 * unexelf.c (unexec) [__OpenBSD__]:
3696 Don't update the .mdebug section of the Alpha COFF symbol table.
3697
3698 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3699
3700 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3701 (bug#8460).
3702
3703 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3704
3705 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3706 This fixes some race conditions on the permissions of any newly
3707 created file.
3708
3709 * alloc.c (valid_pointer_p): Use pipe, not open.
3710 This fixes some permissions issues when debugging.
3711
3712 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3713 If fchown fails to set both uid and gid, try to set just gid,
3714 as that is sometimes allowed. Adjust the file's mode to eliminate
3715 setuid or setgid bits that are inappropriate if fchown fails.
3716
3717 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3718
3719 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3720 to compare Lisp_Objects.
3721 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3722 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3723 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3724
3725 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3726
3727 * lread.c (read_integer): Unread even EOF character.
3728 (read1): Likewise. Properly record start position of symbol.
3729
3730 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3731 symbol character follows.
3732
3733 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3734
3735 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3736 This works around a problem with the previous change to Fcopy_file.
3737 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3738 and without this change, GCC might complain about discarding
3739 fchown's return value.
3740
3741 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3742
3743 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3744
3745 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3746
3747 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3748
3749 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3750
3751 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3752 it's used from the C level.
3753
3754 * process.c: Use the same condition for POLL_FOR_INPUT in both
3755 keyboard.c and process.c (bug#1858).
3756
3757 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3758
3759 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3760 (Fgnutls_boot): Use it.
3761
3762 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3763
3764 * doc.c (Fsubstitute_command_keys): Revert last change.
3765
3766 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3767
3768 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3769 quotes the next character, and doesn't affect other longer
3770 sequences (bug#8935).
3771
3772 * lread.c (syms_of_lread): Clarify that is isn't only
3773 `eval-buffer' and `eval-defun' that's affected by
3774 `lexical-binding' (bug#8460).
3775
3776 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3777
3778 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3779 bidi redisplay when a line includes both an image and is truncated.
3780
3781 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3782
3783 Fix minor problems found by static checking.
3784 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3785 (elsz): Now a signed constant, not a size_t var. We prefer signed
3786 types to unsigned, to avoid integer comparison confusion. Without
3787 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3788 "cannot optimize loop, the loop counter may overflow", a symptom
3789 of the confusion.
3790 * indent.c (Fvertical_motion): Mark locals as initialized.
3791 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3792
3793 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3794
3795 * search.c (Fre_search_backward): Mention `case-fold-search' in
3796 all the re_search_* functions (bug#8138).
3797
3798 * keyboard.c (Fopen_dribble_file): Document when the file is
3799 closed (bug#8056).
3800
3801 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3802
3803 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3804 bidi_cache_idx.
3805
3806 Support bidi reordering of display and overlay strings.
3807 * xdisp.c (compute_display_string_pos)
3808 (compute_display_string_end): Accept additional argument STRING.
3809 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3810 (reseat_to_string): Initialize bidi_it->string.s and
3811 bidi_it->string.schars.
3812 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3813 NULL (avoids a crash in bidi_paragraph_init).
3814 Initialize itb.string.lstring.
3815 (init_iterator): Call bidi_init_it only of a valid
3816 buffer position was specified. Initialize paragraph_embedding to
3817 L2R.
3818 (reseat_to_string): Initialize the bidi iterator.
3819 (display_string): If we need to ignore text properties of
3820 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3821 original value of -1 will not work with bidi.)
3822 (compute_display_string_pos): First arg is now struct
3823 `text_pos *'; all callers changed. Support display properties on
3824 Lisp strings.
3825 (compute_display_string_end): Support display properties on Lisp
3826 strings.
3827 (init_iterator, reseat_1, reseat_to_string): Initialize the
3828 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3829 when iterating on a string not from display properties).
3830 (compute_display_string_pos, compute_display_string_end):
3831 Fix calculation of the object to scan. Fixes an error when using
3832 arrow keys.
3833 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3834 base_level_stop; instead, set base_level_stop to BEGV.
3835 Fixes crashes in vertical-motion.
3836 (next_element_from_buffer): Improve commentary for when
3837 the iterator is before prev_stop.
3838 (init_iterator): Initialize bidi_p from the default value of
3839 bidi-display-reordering, not from buffer-local value. Use the
3840 buffer-local value only if initializing for buffer iteration.
3841 (handle_invisible_prop): Support invisible properties on strings
3842 that are being bidi-reordered.
3843 (set_iterator_to_next): Support bidi reordering of C strings and
3844 Lisp strings.
3845 (next_element_from_string): Support bidi reordering of Lisp
3846 strings.
3847 (handle_stop_backwards): Support Lisp strings as well.
3848 (display_string): Support display of R2L glyph rows.
3849 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3850 (init_iterator): Don't initialize it->bidi_p for strings
3851 here.
3852 (reseat_to_string): Initialize it->bidi_p for strings here.
3853 (next_element_from_string, next_element_from_c_string)
3854 (next_element_from_buffer): Add xassert's for correspondence
3855 between IT's object being iterated and it->bidi_it.string
3856 structure.
3857 (face_before_or_after_it_pos): Support bidi iteration.
3858 (next_element_from_c_string): Handle the case of the first string
3859 character that is not the first one in the visual order.
3860 (get_visually_first_element): New function, refactored from common
3861 parts of next_element_from_buffer, next_element_from_string, and
3862 next_element_from_c_string.
3863 (tool_bar_lines_needed, redisplay_tool_bar)
3864 (display_menu_bar): Force left-to-right direction. Add a FIXME
3865 comment for making that be controlled by a user option.
3866 (push_it, pop_it): Save and restore the state of the
3867 bidi iterator. Save and restore the bidi_p flag.
3868 (pop_it): Iterate out of display property for string iteration as
3869 well.
3870 (iterate_out_of_display_property): Support iteration over strings.
3871 (handle_single_display_spec): Set up it->bidi_it for iteration
3872 over a display string, and call bidi_init_it.
3873 (handle_single_display_spec, next_overlay_string)
3874 (get_overlay_strings_1, push_display_prop): Set up the bidi
3875 iterator for displaying display or overlay strings.
3876 (forward_to_next_line_start): Don't use the shortcut if
3877 bidi-iterating.
3878 (back_to_previous_visible_line_start): If handle_display_prop
3879 pushed the iterator stack, restore the internal state of the bidi
3880 iterator by calling bidi_pop_it same number of times.
3881 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3882 and we are bidi-iterating, don't decrement the iterator position;
3883 instead, set the first_elt flag in the bidi iterator, to produce
3884 the same effect.
3885 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3886 (push_display_prop): xassert that we are iterating a buffer.
3887 (push_it, pop_it): Save and restore paragraph_embedding member.
3888 (handle_single_display_spec, next_overlay_string)
3889 (get_overlay_strings_1, reseat_1, reseat_to_string)
3890 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3891 correctly. Don't assume unibyte strings are not bidi-reordered.
3892 (compute_display_string_pos)
3893 (compute_display_string_end): Fix handling the case of C string.
3894 (push_it, pop_it): Save and restore from_disp_prop_p.
3895 (handle_single_display_spec, push_display_prop): Set the
3896 from_disp_prop_p flag.
3897 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3898 (pop_it): Call iterate_out_of_display_property only if we are
3899 popping after iteration over a string that came from a display
3900 property. Fix a typo in popping stretch info. Add an assertion
3901 for verifying that the iterator position is in sync with the bidi
3902 iterator.
3903 (handle_single_display_spec, get_overlay_strings_1)
3904 (push_display_prop): Fix initialization of paragraph direction for
3905 string when that of the parent object is not yet determined.
3906 (reseat_1): Call bidi_init_it to resync the bidi
3907 iterator with IT's position. (Bug#7616)
3908 (find_row_edges): If ROW->start.pos gives position
3909 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3910 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3911 Reset the from_disp_prop_p flag.
3912 (SAVE_IT, RESTORE_IT): New macros.
3913 (pos_visible_p, face_before_or_after_it_pos)
3914 (back_to_previous_visible_line_start)
3915 (move_it_in_display_line_to, move_it_in_display_line)
3916 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3917 (try_scrolling, redisplay_window, display_line): Use them when
3918 saving a temporary copy of the iterator and restoring it back.
3919 (back_to_previous_visible_line_start, reseat_1)
3920 (init_iterator): Empty the bidi cache "stack".
3921 (move_it_in_display_line_to): If iterator ended up at
3922 EOL, but we never saw any buffer positions smaller than
3923 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3924 motion in bidi-reordered lines.
3925 (move_it_in_display_line_to): Record prev_method and prev_pos
3926 immediately before the call to set_iterator_to_next. Fixes cursor
3927 motion in bidi-reordered lines with stretch glyphs and strings
3928 displayed in margins. (Bug#8133) (Bug#8867)
3929 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3930 TO_CHARPOS.
3931 (pos_visible_p): Support positions in bidi-reordered lines.
3932 Save and restore bidi cache.
3933
3934 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3935 (bidi_paragraph_info): Delete unused struct.
3936 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3937 (bidi_cache_start): New variable.
3938 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3939 to zero.
3940 (bidi_cache_fetch_state, bidi_cache_search)
3941 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3942 (bidi_cache_find, bidi_peek_at_next_level)
3943 (bidi_level_of_next_char, bidi_find_other_level_edge)
3944 (bidi_move_to_visually_next): Compare cache index with
3945 bidi_cache_start rather than with zero.
3946 (bidi_fetch_char): Accept new argument STRING; all callers
3947 changed. Support iteration over a string. Support strings with
3948 display properties. Support unibyte strings. Fix the type of
3949 `len' according to what STRING_CHAR_AND_LENGTH expects.
3950 (bidi_paragraph_init, bidi_resolve_explicit_1)
3951 (bidi_resolve_explicit, bidi_resolve_weak)
3952 (bidi_level_of_next_char, bidi_move_to_visually_next):
3953 Support iteration over a string.
3954 (bidi_set_sor_type, bidi_resolve_explicit_1)
3955 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3956 can now be zero (for strings); special values 0 and -1 were
3957 changed to -1 and -2, respectively.
3958 (bidi_char_at_pos): New function.
3959 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3960 Call it instead of FETCH_MULTIBYTE_CHAR.
3961 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3962 initialized to valid values.
3963 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3964 values.
3965 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3966 the test for valid cached positions. Fix the logic for looking up
3967 the sentinel state in the cache. GCPRO the Lisp string we are
3968 iterating.
3969 (bidi_push_it, bidi_pop_it): New functions.
3970 (bidi_initialize): Initialize the bidi cache start stack pointer.
3971 (bidi_cache_ensure_space): New function, refactored from part of
3972 bidi_cache_iterator_state. Don't assume the required size is just
3973 one BIDI_CACHE_CHUNK away.
3974 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3975 (bidi_count_bytes, bidi_char_at_pos): New functions.
3976 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3977 always valid if bidi_cache_idx is valid.
3978 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3979 is valid if it's going to be used.
3980 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3981 (bidi_cache_fetch_state, bidi_cache_search)
3982 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3983 (bidi_cache_iterator_state, bidi_cache_find)
3984 (bidi_find_other_level_edge, bidi_cache_start_stack):
3985 All variables related to cache indices are now EMACS_INT.
3986
3987 * dispextern.h (struct bidi_string_data): New structure.
3988 (struct bidi_it): New member `string'. Make flag members be 1-bit
3989 fields, and put them last in the struct.
3990 (compute_display_string_pos, compute_display_string_end):
3991 Update prototypes.
3992 (bidi_push_it, bidi_pop_it): Add prototypes.
3993 (struct iterator_stack_entry): New members bidi_p,
3994 paragraph_embedding, and from_disp_prop_p.
3995 (struct it): Member bidi_p is now a bit field 1 bit wide.
3996 (bidi_shelve_cache, bidi_unshelve_cache):
3997 Declare prototypes.
3998
3999 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4000 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4001 and vector-like objects.
4002
4003 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4004 cache around display iteration.
4005
4006 * window.c (Fwindow_end, window_scroll_pixel_based)
4007 (displayed_window_lines, Frecenter): Save and restore the bidi
4008 cache around display iteration.
4009
4010 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4011
4012 * editfns.c (Fdelete_region): Clarify the use of the named
4013 parameters (bug#6788).
4014
4015 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4016
4017 * indent.c (Fvertical_motion): Set and restore w->pointm when
4018 saving and restoring the window's buffer (Bug#9006).
4019
4020 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4021
4022 * editfns.c (Fstring_to_char): Clarify just what is returned
4023 (bug#6576). Text by Eli Zaretskii.
4024
4025 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4026
4027 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4028
4029 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4030
4031 * buffer.c (mmap_find): Fix a typo.
4032
4033 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4034
4035 Fix execution of x selection hooks.
4036 * xselect.c (Qx_lost_selection_functions)
4037 (Qx_sent_selection_functions): New vars.
4038 (syms_of_xselect): DEFSYM them.
4039 (x_handle_selection_request): Pass Qx_sent_selection_functions
4040 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4041 (x_handle_selection_clear,x_clear_frame_selections):
4042 Pass Qx_lost_selection_functions rather than
4043 Vx_lost_selection_functions to Frun_hook_with_args.
4044
4045 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4046
4047 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4048 The old code sometimes used this field without initializing it.
4049
4050 * alloc.c (gc_sweep): Don't read past end of array.
4051 In theory, the old code could also have corrupted Emacs internals,
4052 though it'd be very unlikely.
4053
4054 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4055
4056 * character.c (Fcharacterp): Don't advertise optional ignored
4057 argument. (Bug#4026)
4058
4059 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4060
4061 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4062 key" (bug#4257).
4063
4064 * window.c (Fset_window_start): Doc fix (bug#4199).
4065 (Fset_window_hscroll): Ditto.
4066
4067 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4068
4069 Fix minor new problems caught by GCC 4.6.1.
4070 * term.c (init_tty): Remove unused local.
4071 * xsettings.c (store_monospaced_changed): Define this function only
4072 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4073 not used otherwise.
4074
4075 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4076
4077 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4078
4079 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4080
4081 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4082 are the mini-buffer and the echo area (bug#3320).
4083
4084 * term.c (init_tty): Remove support for supdup, c10 and perq
4085 terminals, which are no longer supported (bug#1482).
4086
4087 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4088
4089 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4090
4091 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4092
4093 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4094 for non-popups (Bug#3642).
4095
4096 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4097
4098 * alloc.c (reset_malloc_hooks): Protoize.
4099 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4100 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4101 * cm.c (losecursor): Likewise.
4102 * data.c (fmod): Likewise.
4103 * dispnew.c (swap_glyphs_in_rows): Likewise.
4104 * emacs.c (memory_warning_signal): Likewise.
4105 * floatfns.c (float_error): Likewise.
4106 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4107 (otf_open, font_otf_capability, generate_otf_features)
4108 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4109 Likewise.
4110 * image.c (pbm_read_file): Likewise.
4111 * indent.c (string_display_width): Likewise.
4112 * intervals.c (check_for_interval, search_for_interval)
4113 (inc_interval_count, count_intervals, root_interval)
4114 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4115 * lread.c (defalias): Likewise.
4116 * ralloc.c (r_alloc_check): Likewise.
4117 * regex.c (set_image_of_range_1, set_image_of_range)
4118 (regex_grow_registers): Likewise.
4119 * sysdep.c (strerror): Likewise.
4120 * termcap.c (valid_filename_p, tprint, main): Likewise.
4121 * tparam.c (main): Likewise.
4122 * unexhp9k800.c (run_time_remap, save_data_space)
4123 (update_file_ptrs, read_header, write_header, calculate_checksum)
4124 (copy_file, copy_rest, display_header): Likewise.
4125 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4126 Likewise.
4127 * xdisp.c (check_it): Likewise.
4128 * xfaces.c (register_color, unregister_color, unregister_colors):
4129 Likewise.
4130 * xfns.c (print_fontset_result): Likewise.
4131 * xrdb.c (member, fatal, main): Likewise.
4132
4133 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4134
4135 Fix minor problems found by static checking (Bug#9031).
4136 * chartab.c (char_table_set_range, map_sub_char_table):
4137 Remove unused locals.
4138 (uniprop_table): Now static.
4139 * composite.c (_work_char): Remove unused static var.
4140
4141 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4142
4143 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4144
4145 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4146
4147 * gtkutil.c (qttip_cb): Remove code without function.
4148
4149 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4150
4151 * w32.c (pthread_sigmask): New stub.
4152
4153 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4154
4155 Use pthread_sigmask, not sigprocmask (Bug#9010).
4156 sigprocmask is portable only for single-threaded applications, and
4157 Emacs can be multi-threaded when it uses GTK.
4158 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4159 (LIBES): Use it.
4160 * callproc.c (Fcall_process):
4161 * process.c (create_process):
4162 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4163 Use pthread_sigmask, not sigprocmask.
4164
4165 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4166
4167 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4168 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4169 wrong (Bug#8591).
4170
4171 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4172
4173 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4174 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4175 (xg_hide_tooltip): Fix comment.
4176
4177 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4178 in registerServicesMenuSendTypes.
4179 (validRequestorForSendType): Don't check ns_return_types.
4180
4181 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4182 ns_return_type.
4183
4184 2011-07-08 Jason Rumney <jasonr@gnu.org>
4185
4186 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4187 SH_SHOW for hidden windows (Bug#5482).
4188
4189 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4190 frame struct members of non-existent frames (Bug#6284).
4191
4192 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4193
4194 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4195 variable firstTime not needed on OSX >= 10.6.
4196 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4197 >= 10.5. Use setKnobProportion, setDoubleValue.
4198
4199 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4200 (MAC_OS_X_VERSION_10_5): Define if not defined.
4201 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4202 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4203 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4204
4205 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4206 cString and lossyCString on OSX >= 10.4
4207
4208 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4209 sizeToFit on OSX >= 10.2.
4210
4211 * nsimage.m (allocInitFromFile): Don't use deprecated method
4212 bestRepresentationForDevice on OSX >= 10.6.
4213
4214 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4215 to avoid warning.
4216
4217 * emacs.c: Declare unexec_init_emacs_zone.
4218
4219 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4220
4221 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4222
4223 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4224 on svcsMenu (Bug#8842).
4225
4226 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4227 ns_return_types.
4228 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4229
4230 * nsterm.m (QUTF8_STRING): Declare.
4231 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4232 (validRequestorForSendType): Return type is (id).
4233 Change indexOfObjectIdenticalTo to indexOfObject.
4234 Check if we have local selection before returning self (Bug#8842).
4235 (writeSelectionToPasteboard): Put local selection into paste board
4236 if we have a local selection (Bug#8842).
4237 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4238
4239 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4240 (ns_get_local_selection): Declare.
4241
4242 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4243
4244 * keymap.c (describe_map_tree): Don't insert a double newline at
4245 the end of the buffer (bug#1169) and return whether we inserted
4246 something.
4247
4248 * callint.c (Fcall_interactively): Change "reading args" to
4249 "providing args" to try to clarify what it does (bug#1010).
4250
4251 2011-07-07 Kenichi Handa <handa@m17n.org>
4252
4253 * composite.c (composition_compute_stop_pos): Ignore a static
4254 composition starting before CHARPOS (Bug#8915).
4255
4256 * xdisp.c (handle_composition_prop): Likewise.
4257
4258 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4259
4260 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4261 (Bug#9015)
4262
4263 2011-07-07 Kenichi Handa <handa@m17n.org>
4264
4265 * character.h (unicode_category_t): New enum type.
4266
4267 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4268 (Qchar_code_property_table): New variable.
4269 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4270 (UNIPROP_COMPRESSED_FORM_P): New macros.
4271 (char_table_ascii): Uncompress the compressed values.
4272 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4273 Uncompress the compressed values.
4274 (sub_char_table_ref_and_range): Likewise.
4275 (char_table_ref_and_range): Uncompress the compressed values.
4276 (sub_char_table_set): New arg is_uniprop. Callers changed.
4277 Uncompress the compressed values.
4278 (sub_char_table_set_range): Args changed. Callers changed.
4279 (char_table_set_range): Adjuted for the above change.
4280 (map_sub_char_table): Delete args default_val and parent. Add arg
4281 top. Give decoded values to a Lisp function.
4282 (map_char_table): Adjust for the above change. Give decoded
4283 values to a Lisp function. Gcpro more variables.
4284 (uniprop_table_uncompress)
4285 (uniprop_decode_value_run_length): New functions.
4286 (uniprop_decoder, uniprop_decoder_count): New variables.
4287 (uniprop_get_decoder, uniprop_encode_value_character)
4288 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4289 New functions.
4290 (uniprop_encoder, uniprop_encoder_count): New variables.
4291 (uniprop_get_encoder, uniprop_table)
4292 (Funicode_property_table_internal, Fget_unicode_property_internal)
4293 (Fput_unicode_property_internal): New functions.
4294 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4295 Sunicode_property_table_internal, Sget_unicode_property_internal,
4296 and Sput_unicode_property_internal. Defvar_lisp
4297 char-code-property-alist.
4298
4299 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4300 Vunicode_category_table.
4301
4302 * font.c (font_range): Adjust for the change of
4303 Vunicode_category_table.
4304
4305 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4306
4307 * m/iris4d.h: Remove file, move contents ...
4308 * s/irix6-5.h: ... here.
4309
4310 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4311
4312 Remove unportable assumption about struct layout (Bug#8884).
4313 * alloc.c (mark_buffer):
4314 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4315 (clone_per_buffer_values): Don't assume that
4316 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4317 This isn't true in general, and it's particularly not true
4318 if Emacs is configured with --with-wide-int.
4319 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4320 New macros, used in the buffer.c change.
4321
4322 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4323
4324 * xsettings.c: Use both GConf and GSettings if both are available.
4325 (store_config_changed_event): Add comment.
4326 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4327 (store_tool_bar_style_changed): New functions.
4328 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4329 (struct xsettings): Move font inside HAVE_XFT.
4330 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4331 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4332 Move inside HAVE_XFT.
4333 (something_changed_gsettingsCB): Rename from something_changedCB.
4334 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4335 also.
4336 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4337 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4338 (something_changed_gconfCB): Rename from something_changedCB.
4339 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4340 (parse_settings): Move check for font inside HAVE_XFT.
4341 (read_settings, apply_xft_settings): Add comment.
4342 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4343 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4344 call store_font_name_changed.
4345 (xft_settings_event): Add comment.
4346 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4347 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4348 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4349 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4350 (xsettings_initialize): Call init_gsettings last.
4351 (xsettings_get_system_font, xsettings_get_system_normal_font):
4352 Add comment.
4353
4354 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4355
4356 Random fixes. E.g., (random) never returned negative values.
4357 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4358 subseconds part to the entropy, as that's a bit more random.
4359 Prefer signed to unsigned, since the signedness doesn't matter and
4360 in general we prefer signed. When given a limit, use a
4361 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4362 latter isn't right if USE_2_TAGS_FOR_INTS.
4363 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4364 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4365
4366 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4367
4368 * textprop.c (text_property_stickiness):
4369 Obey Vtext_property_default_nonsticky.
4370 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4371 * w32fns.c (syms_of_w32fns):
4372 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4373
4374 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4375
4376 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4377 This is more efficient than Ffile_directory_p and avoids a minor race.
4378
4379 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4380
4381 * buffer.c (Foverlay_put): Say what the return value is
4382 (bug#7835).
4383
4384 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4385 is a directory before asking whether to use the file name
4386 (bug#7564).
4387 (barf_or_query_if_file_exists): Make the "File is a directory"
4388 error be more correct.
4389
4390 * fns.c (Frequire): Remove the mention of the .gz files, since
4391 that's installation-specific, but keep the mention of
4392 `get-load-suffixes'.
4393
4394 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4395
4396 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4397 Report string overflow if the output is too long.
4398
4399 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4400
4401 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4402 (syms_of_gnutls): Remove duplicate DEFSYM for
4403 Qgnutls_bootprop_verify_hostname_error, an error for
4404 Qgnutls_bootprop_verify_error (which is no longer used).
4405
4406 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4407 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4408 Also (re)move comments that are misplaced or no longer relevant.
4409
4410 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4411
4412 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4413
4414 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4415
4416 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4417 and background color parameters if they have been changed.
4418
4419 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4420
4421 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4422
4423 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4424
4425 * xsettings.c (SYSTEM_FONT): Define only when used.
4426 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4427
4428 * keymap.c (access_keymap_1): Now static.
4429
4430 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4431
4432 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4433 leave any prefix arg for the up event (Bug#1586).
4434
4435 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4436
4437 * lread.c (syms_of_lread): Mention single symbols defined by
4438 `defvar' or `defconst' (bug#7154).
4439
4440 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4441 (Frequire): Mention get-load-suffixes.
4442
4443 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4444
4445 * window.h (window): Remove clone_number slot.
4446 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4447 Remove.
4448 (make_parent_window, make_window, saved_window)
4449 (Fset_window_configuration, save_window_save): Don't deal with
4450 clone numbers.
4451 * buffer.c (Qclone_number): Remove declaration.
4452 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4453
4454 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4455
4456 Add multiple inheritance to keymaps.
4457 * keymap.c (Fmake_composed_keymap): New function.
4458 (Fset_keymap_parent): Simplify.
4459 (fix_submap_inheritance): Remove.
4460 (access_keymap_1): New function extracted from access_keymap to handle
4461 embedded parents and handle lists of maps.
4462 (access_keymap): Use it.
4463 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4464 (Fcopy_keymap): Handle embedded parents.
4465 (Fcommand_remapping, define_as_prefix): Simplify.
4466 (Fkey_binding): Simplify.
4467 (syms_of_keymap): Move minibuffer-local-completion-map,
4468 minibuffer-local-filename-completion-map,
4469 minibuffer-local-must-match-map, and
4470 minibuffer-local-filename-must-match-map to Elisp.
4471 (syms_of_keymap): Defsubr make-composed-keymap.
4472 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4473 (parse_menu_item): Trivial simplification.
4474
4475 2011-07-01 Glenn Morris <rgm@gnu.org>
4476
4477 * Makefile.in (SETTINGS_LIBS): Fix typo.
4478
4479 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4480
4481 * coding.c (Fencode_coding_string): Record the last coding system
4482 used, as the function doc string says (bug#8738).
4483
4484 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4485
4486 * xsettings.c (store_monospaced_changed): Take new font as arg and
4487 check for change against current_mono_font.
4488 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4489 (emacs_settings_constructor, emacs_settings_get_property)
4490 (emacs_settings_set_property, emacs_settings_class_init)
4491 (emacs_settings_init, gsettings_obj): Remove.
4492 (something_changedCB): New function for HAVE_GSETTINGS.
4493 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4494 with value as argument.
4495 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4496 g_settings_new (Bug#8967). Do not create gsettings_obj.
4497 Remove calls to g_settings_bind. Connect something_changedCB to
4498 "changed".
4499
4500 * xgselect.c: Add defined (HAVE_GSETTINGS).
4501 (xgselect_initialize): Ditto.
4502
4503 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4504 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4505 xg_select.
4506
4507 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4508
4509 * eval.c (struct backtrace): Simplify and port the data structure.
4510 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4511 signed bit field, as this assumption is not portable and it makes
4512 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4513 "char debug_on_exit : 1" as this is not portable either; instead,
4514 use the portable "unsigned int debug_on_exit : 1". Remove unused
4515 member evalargs. Remove obsolete comments about cc bombing out.
4516
4517 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4518
4519 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4520 Let HAVE_GSETTINGS override HAVE_GCONF.
4521 (store_monospaced_changed): New function.
4522 (EMACS_SETTINGS): A new type derived from GObject to handle
4523 GSettings notifications.
4524 (emacs_settings_constructor, emacs_settings_get_property)
4525 (emacs_settings_set_property, emacs_settings_class_init):
4526 New functions.
4527 (gsettings_client, gsettings_obj): New variables.
4528 (GSETTINGS_SCHEMA): New define.
4529 (something_changedCB): Call store_monospaced_changed.
4530 (init_gsettings): New function.
4531 (xsettings_initialize): Call init_gsettings.
4532 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4533 to NULL.
4534
4535 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4536 GCONF_CFLAGS/LIBS.
4537
4538 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4539
4540 * window.c (resize_root_window, grow_mini_window)
4541 (shrink_mini_window): Rename Qresize_root_window to
4542 Qwindow_resize_root_window and Qresize_root_window_vertically to
4543 Qwindow_resize_root_window_vertically.
4544
4545 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4546
4547 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4548
4549 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4550
4551 * makefile.w32-in: Redesign dependencies so they reflect more
4552 clearly which files are directly included by each source file,
4553 and not through other includes.
4554
4555 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4556
4557 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4558 (sort_overlays, overlay_strings): When an overlay's clone number
4559 matches the window's clone number process the overlay even if
4560 the overlay's window property doesn't match the current window.
4561
4562 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4563 (Fwindow_hchild): Rename to Fwindow_left_child.
4564 (Fwindow_next): Rename to Fwindow_next_sibling.
4565 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4566 (resize_window_check): Rename to window_resize_check.
4567 (resize_window_apply): Rename to window_resize_apply.
4568 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4569 (Fdelete_other_windows_internal, resize_frame_windows)
4570 (Fsplit_window_internal, Fdelete_window_internal)
4571 (grow_mini_window, shrink_mini_window)
4572 (Fresize_mini_window_internal): Fix callers accordingly.
4573
4574 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4575
4576 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4577 (emacs_fixed_set_min_size): Remove.
4578 (emacs_fixed_new): Take frame as argument.
4579
4580 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4581 (_EmacsFixedPrivate): Remove minwidth/height.
4582 Add struct frame *f.
4583 (emacs_fixed_init): Initialize priv->f.
4584 (get_parent_class, emacs_fixed_set_min_size): Remove.
4585 (emacs_fixed_new): Set priv->f to argument.
4586 (emacs_fixed_get_preferred_width)
4587 (emacs_fixed_get_preferred_height): Use min_width/height from
4588 frames size_hint to set minimum and natural (Bug#8919).
4589 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4590 and use min_width/height from frames size_hint to set
4591 min_width/height (Bug#8919).
4592
4593 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4594 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4595 Fix indentation.
4596
4597 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4598
4599 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4600 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4601 called at ZV.
4602
4603 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4604
4605 * process.c (wait_reading_process_output): Bypass select if
4606 waiting for a cell while ignoring keyboard input, and input is
4607 pending. Suggested by Jan Djärv (Bug#8869).
4608
4609 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4610
4611 Use gnulib's dup2 module instead of rolling our own.
4612 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4613
4614 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4615
4616 * dispnew.c (scrolling_window): Before scrolling, turn off a
4617 mouse-highlight in the window being scrolled.
4618
4619 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4620
4621 Move DEFSYM to lisp.h and use everywhere.
4622
4623 * character.h (DEFSYM): Move declaration...
4624 * lisp.h (DEFSYM): ...here.
4625
4626 * gnutls.c:
4627 * minibuf.c:
4628 * w32menu.c:
4629 * w32proc.c:
4630 * w32select.c: Don't include character.h.
4631
4632 * alloc.c (syms_of_alloc):
4633 * buffer.c (syms_of_buffer):
4634 * bytecode.c (syms_of_bytecode):
4635 * callint.c (syms_of_callint):
4636 * casefiddle.c (syms_of_casefiddle):
4637 * casetab.c (init_casetab_once):
4638 * category.c (init_category_once, syms_of_category):
4639 * ccl.c (syms_of_ccl):
4640 * cmds.c (syms_of_cmds):
4641 * composite.c (syms_of_composite):
4642 * dbusbind.c (syms_of_dbusbind):
4643 * dired.c (syms_of_dired):
4644 * dispnew.c (syms_of_display):
4645 * doc.c (syms_of_doc):
4646 * editfns.c (syms_of_editfns):
4647 * emacs.c (syms_of_emacs):
4648 * eval.c (syms_of_eval):
4649 * fileio.c (syms_of_fileio):
4650 * fns.c (syms_of_fns):
4651 * frame.c (syms_of_frame):
4652 * fringe.c (syms_of_fringe):
4653 * insdel.c (syms_of_insdel):
4654 * keymap.c (syms_of_keymap):
4655 * lread.c (init_obarray, syms_of_lread):
4656 * macros.c (syms_of_macros):
4657 * msdos.c (syms_of_msdos):
4658 * print.c (syms_of_print):
4659 * process.c (syms_of_process):
4660 * search.c (syms_of_search):
4661 * sound.c (syms_of_sound):
4662 * syntax.c (init_syntax_once, syms_of_syntax):
4663 * terminal.c (syms_of_terminal):
4664 * textprop.c (syms_of_textprop):
4665 * undo.c (syms_of_undo):
4666 * w32.c (globals_of_w32):
4667 * window.c (syms_of_window):
4668 * xdisp.c (syms_of_xdisp):
4669 * xfaces.c (syms_of_xfaces):
4670 * xfns.c (syms_of_xfns):
4671 * xmenu.c (syms_of_xmenu):
4672 * xsettings.c (syms_of_xsettings):
4673 * xterm.c (syms_of_xterm): Use DEFSYM.
4674
4675 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4676
4677 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4678
4679 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4680
4681 Integer and buffer overflow fixes (Bug#8873).
4682
4683 * print.c (printchar, strout): Check for string overflow.
4684 (PRINTPREPARE, printchar, strout):
4685 Don't set size unless allocation succeeds.
4686
4687 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4688 for sizes. Check for string overflow more accurately.
4689 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4690
4691 * macros.c: Integer and buffer overflow fixes.
4692 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4693 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4694 Use ptrdiff_t, not int, for sizes.
4695 Don't increment bufsize until after realloc succeeds.
4696 Check for size-calculation overflow.
4697 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4698
4699 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4700
4701 * lread.c: Integer overflow fixes.
4702 (read_integer): Radix is now EMACS_INT, not int,
4703 to improve quality of diagnostics for out-of-range radices.
4704 Calculate buffer size correctly for out-of-range radices.
4705 (read1): Check for integer overflow in radices, and in
4706 read-circle numbers.
4707 (read_escape): Avoid int overflow.
4708 (Fload, openp, read_buffer_size, read1)
4709 (substitute_object_recurse, read_vector, read_list, map_obarray):
4710 Use ptrdiff_t, not int, for sizes.
4711 (read1): Use EMACS_INT, not int, for sizes.
4712 Check for size overflow.
4713
4714 * image.c (cache_image): Check for size arithmetic overflow.
4715
4716 * lread.c: Integer overflow issues.
4717 (saved_doc_string_size, saved_doc_string_length)
4718 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4719 Now ptrdiff_t, not int.
4720 (read1): Don't assume doc string length fits in int. Check for
4721 out-of-range doc string lengths.
4722 (read_list): Don't assume file position fits in int.
4723 (read_escape): Check for hex character overflow.
4724
4725 2011-06-22 Leo Liu <sdl.web@gmail.com>
4726
4727 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4728 Move to minibuffer.el.
4729
4730 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4731
4732 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4733 The following patches are for when GLYPH_DEBUG && !XASSERT.
4734 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4735 * dispnew.c (flush_stdout):
4736 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4737 Mark as externally visible.
4738 * dispnew.c (check_window_matrix_pointers): Now static.
4739 * dispnew.c (window_to_frame_vpos):
4740 * xfns.c (unwind_create_frame):
4741 * xterm.c (x_check_font): Remove unused local.
4742 * scroll.c (CHECK_BOUNDS):
4743 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4744 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4745 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4746 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4747 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4748 Now static.
4749 (debug_method_add): Use va_list and vsprintf rather than relying
4750 on undefined behavior with wrong number of arguments.
4751 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4752 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4753 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4754 since we're not interested in debugging glyphs with old libraries.
4755 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4756 GCC 4.6.0's static checking.
4757
4758 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4759
4760 Integer overflow and signedness fixes (Bug#8873).
4761 A few related buffer overrun fixes, too.
4762
4763 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4764
4765 * dispextern.h (struct face.stipple):
4766 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4767 (x_bitmap_mask, x_allocate_bitmap_record)
4768 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4769 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4770 (x_create_bitmap_from_xpm_data):
4771 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4772 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4773 (.bitmaps_last):
4774 * xfaces.c (load_pixmap):
4775 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4776 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4777 (.bitmaps_last, struct x_output.icon_bitmap):
4778 Use ptrdiff_t, not int, for bitmap indexes.
4779 (x_allocate_bitmap_record): Check for size overflow.
4780 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4781
4782 Use ptrdiff_t, not int, for overlay counts.
4783 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4784 * editfns.c (overlays_around, get_pos_property):
4785 * textprop.c (get_char_property_and_overlay):
4786 * xdisp.c (next_overlay_change, note_mouse_highlight):
4787 * xfaces.c (face_at_buffer_position):
4788 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4789 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4790 (Fnext_overlay_change, Fprevious_overlay_change)
4791 (mouse_face_overlay_overlaps, Foverlays_in):
4792 Use ptrdiff_t, not int, for sizes.
4793 (overlays_at, overlays_in): Check for size-calculation overflow.
4794
4795 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4796
4797 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4798 (x_session_initialize): Do not assume string length fits in int.
4799
4800 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4801 This is unlikely, but can occur if DPI is outlandish.
4802
4803 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4804 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4805
4806 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4807 * xrdb.c (magic_file_p, search_magic_path):
4808 Omit last arg SUFFIX; it was always 0. All callers changed.
4809 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4810
4811 * xfont.c (xfont_match): Avoid need for strlen.
4812
4813 * xfns.c: Don't assume strlen fits in int.
4814 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4815
4816 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4817 not unsigned long, as we prefer signed integers. All callers changed.
4818 Detect integer overflow in repeat count.
4819 (message_dolog): Don't assume print length fits in 39 bytes.
4820 (display_mode_element): Don't assume strlen fits in int.
4821
4822 * termcap.c: Don't assume sizes fit in int and never overflow.
4823 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4824 (gobble_line): Check for size-calculation overflow.
4825
4826 * minibuf.c (Fread_buffer):
4827 * lread.c (intern, intern_c_string):
4828 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4829 Don't assume string length fits in int.
4830
4831 * keyboard.c (parse_tool_bar_item):
4832 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4833
4834 * font.c: Don't assume string length fits in int.
4835 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4836 Use ptrdiff_t, not int.
4837 (font_intern_prop): Don't assume string length fits in int.
4838 Don't assume integer property fits in fixnum.
4839 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4840
4841 * filelock.c: Fix some buffer overrun and integer overflow issues.
4842 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4843 Reformulate so as not to need the command string.
4844 Invoke gzip -cd rather than gunzip, as it's more portable.
4845 (lock_info_type, lock_file_1, lock_file):
4846 Don't assume pid_t and time_t fit in unsigned long.
4847 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4848 (current_lock_owner): Prefer signed type for sizes.
4849 Use memcpy, not strncpy, where memcpy is what is really wanted.
4850 Don't assume (via atoi) that time_t and pid_t fit in int.
4851 Check for time_t and/or pid_t out of range, e.g., via a network share.
4852 Don't alloca where an auto var works fine.
4853
4854 * fileio.c: Fix some integer overflow issues.
4855 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4856 Don't assume string length fits in int.
4857 (directory_file_name): Don't assume string length fits in long.
4858 (make_temp_name): Don't assume pid fits in int, or that its print
4859 length is less than 20.
4860
4861 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4862
4863 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4864
4865 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4866
4867 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4868 We prefer signed integers, even for size calculations.
4869
4870 * emacs.c: Don't assume string length fits in 'int'.
4871 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4872 (main): Don't invoke strlen when not needed.
4873
4874 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4875 (XD_DEBUG_MESSAGE): Don't waste a byte.
4876
4877 * callproc.c (getenv_internal_1, getenv_internal)
4878 (Fgetenv_internal):
4879 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4880
4881 * lread.c (invalid_syntax): Omit length argument.
4882 All uses changed. This doesn't fix a bug, but it simplifies the
4883 code away from its former Hollerith-constant appearance, and it's
4884 one less 'int' to worry about when looking at integer-overflow issues.
4885 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4886
4887 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4888 This didn't break anything, but it didn't help either.
4889 It's confusing to put a bogus integer in a place where the actual
4890 value does not matter.
4891 (LIST_END_P): Remove unused macro and its bogus comment.
4892 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4893
4894 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4895 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4896 implementation.
4897 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4898 We prefer signed types, and the value cannot exceed the EMACS_INT
4899 range anyway (because otherwise the length would not be representable).
4900 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4901 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4902 This avoids a GCC warning when WIDE_EMACS_INT.
4903
4904 * indent.c (sane_tab_width): New function.
4905 (current_column, scan_for_column, Findent_to, position_indentation)
4906 (compute_motion): Use it. This is just for clarity.
4907 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4908
4909 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4910
4911 * lisp.h (lint_assume): New macro.
4912 * composite.c (composition_gstring_put_cache):
4913 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4914
4915 * editfns.c, insdel.c:
4916 Omit unnecessary forward decls, to simplify future changes.
4917
4918 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4919
4920 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4921
4922 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4923 Use much-faster test for byte-length change.
4924 Don't assume string byte-length fits in 'int'.
4925 Check that character arg fits in 'int'.
4926 (mapcar1): Declare byte as byte, for clarity.
4927
4928 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4929
4930 * fns.c (concat): Catch string overflow earlier.
4931 Do not rely on integer wraparound.
4932
4933 * dispextern.h (struct it.overlay_strings_charpos)
4934 (struct it.selective): Now EMACS_INT, not int.
4935 * xdisp.c (forward_to_next_line_start)
4936 (back_to_previous_visible_line_start)
4937 (reseat_at_next_visible_line_start, next_element_from_buffer):
4938 Don't arbitrarily truncate the value of 'selective' to int.
4939
4940 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4941
4942 * composite.c: Don't truncate sizes to 'int'.
4943 (composition_gstring_p, composition_reseat_it)
4944 (composition_adjust_point): Use EMACS_INT, not int.
4945 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4946 not EMACS_UINT, for indexes.
4947
4948 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4949
4950 * buffer.c: Include <verify.h>.
4951 (struct sortvec.priority, struct sortstr.priority):
4952 Now EMACS_INT, not int.
4953 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4954 (struct sortstr.size, record_overlay_string)
4955 (struct sortstrlist.size, struct sortlist.used):
4956 Don't truncate size to int.
4957 (record_overlay_string): Check for size-calculation overflow.
4958 (init_buffer_once): Check at compile-time, not run-time.
4959
4960 2011-06-22 Jim Meyering <meyering@redhat.com>
4961
4962 Don't leak an XBM-image-sized buffer
4963 * image.c (xbm_load): Free the image buffer after using it.
4964
4965 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4966
4967 Port to Sun C.
4968 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4969 that Sun C diagnosed.
4970 * fns.c (secure_hash): Fix pointer signedness issue.
4971 * intervals.c (static_offset_intervals): New function.
4972 (offset_intervals): Use it.
4973
4974 2011-06-21 Leo Liu <sdl.web@gmail.com>
4975
4976 * deps.mk (fns.o):
4977 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4978 sha512.h.
4979
4980 * fns.c (secure_hash): Rename from crypto_hash_function and change
4981 the first arg to accept symbols.
4982 (Fsecure_hash): New primitive.
4983 (syms_of_fns): New symbols.
4984
4985 2011-06-20 Deniz Dogan <deniz@dogan.se>
4986
4987 * process.c (Fset_process_buffer): Clarify return value in
4988 docstring.
4989
4990 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4991
4992 * dispnew.c (add_window_display_history): Use BVAR.
4993
4994 * xdisp.c (debug_method_add): Use BVAR.
4995 (check_window_end, dump_glyph_matrix, dump_glyph)
4996 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4997
4998 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4999 Likewise.
5000
5001 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5002 check till after the cache is created in init_frame_faces.
5003
5004 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5005
5006 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5007
5008 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5009
5010 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5011 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5012 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5013
5014 Improve buffer-overflow checking (Bug#8873).
5015 * fileio.c (Finsert_file_contents):
5016 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5017 Remove the old (too-loose) buffer overflow checks.
5018 They weren't needed, since make_gap checks for buffer overflow.
5019 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5020 The old code merely checked for Emacs fixnum overflow, and relied
5021 on undefined (wraparound) behavior. The new code avoids undefined
5022 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5023
5024 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5025 Tune. Don't use wider integers than needed. Don't use alloca.
5026 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5027
5028 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5029
5030 * insdel.c, lisp.h (buffer_overflow): New function.
5031 (insert_from_buffer_1, replace_range, replace_range_2):
5032 * insdel.c (make_gap_larger):
5033 * editfns.c (Finsert_char):
5034 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5035
5036 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5037
5038 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5039
5040 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5041
5042 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5043 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5044
5045 * fileio.c: Don't assume EMACS_INT fits in off_t.
5046 (emacs_lseek): New static function.
5047 (Finsert_file_contents, Fwrite_region): Use it.
5048 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5049
5050 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5051
5052 * fns.c: Don't overflow int when computing a list length.
5053 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5054 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5055 truncation on 64-bit hosts. Check for QUIT every
5056 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5057 faster and is responsive enough.
5058 (Flength): Report an error instead of overflowing an integer.
5059 (Fsafe_length): Return a float if the value is not representable
5060 as a fixnum. This shouldn't happen except in contrived situations.
5061 (Fnthcdr, Fsort): Don't assume list length fits in int.
5062 (Fcopy_sequence): Don't assume vector length fits in int.
5063
5064 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5065 (header_size, word_size): New constants.
5066 (allocate_vectorlike): Don't check size overflow here.
5067 (allocate_vector): Check it here instead, since this is the only
5068 caller of allocate_vectorlike that could cause overflow.
5069 Check that the new vector's length is representable as a fixnum.
5070
5071 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5072 The previous code was bogus. For example, next_almost_prime (32)
5073 returned 39, which is undesirable as it is a multiple of 3; and
5074 next_almost_prime (24) returned 25, which is a multiple of 5 so
5075 why was the code bothering to check for multiples of 7?
5076
5077 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5078
5079 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5080
5081 Variadic C functions now count arguments with ptrdiff_t.
5082 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5083 Back then I didn't know that the Emacs coding style prefers signed int.
5084 Also, in the meantime I found a few more instances where arguments
5085 were being counted with int, which may truncate counts on 64-bit
5086 machines, or EMACS_INT, which may be unnecessarily wide.
5087 * lisp.h (struct Lisp_Subr.function.aMANY)
5088 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5089 Arg counts are now ptrdiff_t, not size_t.
5090 All variadic functions and their callers changed accordingly.
5091 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5092 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5093 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5094 * callint.c (Fcall_interactively): Check arg count for overflow,
5095 to avoid potential buffer overrun. Use signed char, not 'int',
5096 for 'varies' array, so that we needn't bother to check its size
5097 calculation for overflow.
5098 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5099 * eval.c (apply_lambda):
5100 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5101 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5102 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5103
5104 * callint.c (Fcall_interactively): Don't use index var as event count.
5105
5106 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5107 * mem-limits.h (SIZE): Remove; no longer used.
5108
5109 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5110
5111 Remove unnecessary casts.
5112 * xterm.c (x_term_init):
5113 * xfns.c (x_set_border_pixel):
5114 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5115 These aren't needed now that we assume ANSI C.
5116
5117 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5118 It's more likely to cause problems (due to unsigned overflow)
5119 than to cure them.
5120
5121 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5122
5123 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5124
5125 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5126
5127 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5128
5129 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5130
5131 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5132
5133 GLYPH_CODE_FACE returns EMACS_INT, not int.
5134 * dispextern.h (merge_faces):
5135 * xfaces.c (merge_faces):
5136 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5137 Don't assume EMACS_INT fits in int.
5138
5139 * character.h (CHAR_VALID_P): Remove unused parameter.
5140 * fontset.c, lisp.h, xdisp.c: All uses changed.
5141
5142 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5143
5144 * fns.c (concat): Minor tuning based on overflow analysis.
5145 This doesn't fix any bugs. Use int to hold character, instead
5146 of constantly refetching from Emacs object. Use XFASTINT, not
5147 XINT, for value known to be a character. Don't bother comparing
5148 a single byte to 0400, as it's always less.
5149
5150 * floatfns.c (Fexpt):
5151 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5152
5153 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5154 for characters.
5155
5156 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5157
5158 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5159 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5160 incorrectly succeed when S was a string, because 4294967386 was
5161 truncated before it was used.
5162
5163 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5164 Otherwise, an out-of-range integer could cause undefined behavior
5165 on a 64-bit host.
5166
5167 * composite.c: Use int, not EMACS_INT, for characters.
5168 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5169 EMACS_INT, for values that are known to be in character range.
5170 This doesn't fix any bugs but is the usual style inside Emacs and
5171 may generate better code on 32-bit machines.
5172
5173 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5174 This is for reasons similar to the recent CHAR_STRING fix.
5175 * charset.c (Fencode_char): Check that character arg is actually
5176 a character. Pass an int to ENCODE_CHAR.
5177 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5178 wider than 'int', as a compile-time check to prevent future regressions
5179 in this area.
5180
5181 * character.c (char_string): Remove unnecessary casts.
5182
5183 Make sure a 64-bit char is never passed to CHAR_STRING.
5184 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5185 by silently ignoring the top 32 bits, allowing some values
5186 that were far too large to be valid characters.
5187 * character.h: Include <verify.h>.
5188 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5189 arguments are no wider than unsigned, as a compile-time check
5190 to prevent future regressions in this area.
5191 * data.c (Faset):
5192 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5193 (Fsubst_char_in_region):
5194 * fns.c (concat):
5195 * xdisp.c (decode_mode_spec_coding):
5196 Adjust to CHAR_STRING's new requirement.
5197 * editfns.c (Finsert_char, Fsubst_char_in_region):
5198 * fns.c (concat): Check that character args are actually
5199 characters. Without this test, these functions did the wrong
5200 thing with wildly out-of-range values on 64-bit hosts.
5201
5202 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5203 These casts should not be needed on 32-bit hosts, either.
5204 * keyboard.c (read_char):
5205 * lread.c (Fload): Remove casts to unsigned.
5206
5207 * lisp.h (UNSIGNED_CMP): New macro.
5208 This fixes comparison bugs on 64-bit hosts.
5209 (ASCII_CHAR_P): Use it.
5210 * casefiddle.c (casify_object):
5211 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5212 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5213 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5214 * dispextern.h (FACE_FROM_ID):
5215 * keyboard.c (read_char): Use UNSIGNED_CMP.
5216
5217 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5218 not to EMACS_INT, to avoid GCC warning.
5219
5220 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5221
5222 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5223 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5224 isn't needed on 32-bit machines.
5225
5226 * buffer.c (Fgenerate_new_buffer_name):
5227 Use EMACS_INT for count, not int.
5228 (advance_to_char_boundary): Return EMACS_INT, not int.
5229
5230 * data.c (Qcompiled_function): Now static.
5231
5232 * window.c (window_body_lines): Now static.
5233
5234 * image.c (gif_load): Rename local to avoid shadowing.
5235
5236 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5237 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5238 * alloc.c (make_save_value): Integer argument is now of type
5239 ptrdiff_t, not int.
5240 (mark_object): Use ptrdiff_t, not int.
5241 * lisp.h (pD): New macro.
5242 * print.c (print_object): Use it.
5243
5244 * alloc.c: Use EMACS_INT, not int, to count objects.
5245 (total_conses, total_markers, total_symbols, total_vector_size)
5246 (total_free_conses, total_free_markers, total_free_symbols)
5247 (total_free_floats, total_floats, total_free_intervals)
5248 (total_intervals, total_strings, total_free_strings):
5249 Now EMACS_INT, not int. All uses changed.
5250 (Fgarbage_collect): Compute overall total using a double, so that
5251 integer overflow is less likely to be a problem. Check for overflow
5252 when converting back to an integer.
5253 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5254 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5255 These were 'int' variables that could overflow on 64-bit hosts;
5256 they were never used, so remove them instead of repairing them.
5257 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5258 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5259 Previously, this ceilinged at INT_MAX, but that doesn't work on
5260 64-bit machines.
5261 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5262
5263 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5264 (allocate_vectorlike): Check for ptrdiff_t overflow.
5265 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5266 when a (possibly-narrower) signed value would do just as well.
5267 We prefer using signed arithmetic, to avoid comparison confusion.
5268
5269 * alloc.c: Catch some string size overflows that we were missing.
5270 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5271 for convenience in STRING_BYTES_MAX.
5272 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5273 The definition here is exact; the one in lisp.h was approximate.
5274 (allocate_string_data): Check for string overflow. This catches
5275 some instances we weren't catching before. Also, it catches
5276 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5277 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5278 and ptrdiff_t and EMACS_INT are both 64 bits.
5279
5280 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5281 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5282 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5283
5284 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5285
5286 * alloc.c (Fmake_string): Check for out-of-range init.
5287
5288 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5289
5290 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5291
5292 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5293
5294 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5295 xg_get_default_scrollbar_width.
5296
5297 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5298 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5299 (style_changed_cb): Call update_theme_scrollbar_width and call
5300 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5301 all frames (Bug#8505).
5302 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5303 Call gtk_window_set_resizable if HAVE_GTK3.
5304 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5305 and height if HAVE_GTK3 (Bug#8505).
5306 (scroll_bar_width_for_theme): New variable.
5307 (update_theme_scrollbar_width): New function.
5308 (xg_get_default_scrollbar_width): Move code to
5309 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5310 (xg_initialize): Call update_theme_scrollbar_width.
5311
5312 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5313
5314 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5315
5316 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5317
5318 * frame.c (make_frame): Call other_buffer_safely instead of
5319 other_buffer.
5320
5321 * window.c (temp_output_buffer_show): Call display_buffer with
5322 second argument Vtemp_buffer_show_specifiers and reset latter
5323 immediately after the call.
5324 (Vtemp_buffer_show_specifiers): New variable.
5325 (auto_window_vscroll_p, next_screen_context_lines)
5326 (Vscroll_preserve_screen_position): Remove leading asterisks from
5327 doc-strings.
5328
5329 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5330
5331 Fix minor problems found by GCC 4.6.0 static checking.
5332 * buffer.c (Qclone_number): Remove for now, as it's unused.
5333 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5334 (record_buffer): Remove unused local.
5335 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5336 (set_frame_buffer_list): Remove; unused.
5337 * frame.h (other_visible_frames): Remove decl.
5338 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5339 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5340 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5341 if HAVE_GPM.
5342 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5343 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5344 Define only if HAVE_GPM.
5345 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5346 (update_hints_inhibit): Remove; never set. All uses removed.
5347 * widgetprv.h (emacsFrameClassRec): Remove decl.
5348 * window.c (delete_deletable_window): Now returns void, since it
5349 wasn't returning anything.
5350 (compare_window_configurations): Remove unused locals.
5351 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5352 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5353 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5354 the same widths as pointers. This follows up on the 2011-05-06 patch.
5355 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5356 * xterm.h: Likewise.
5357 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5358
5359 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5360
5361 * makefile.w32-in: Update dependencies.
5362 (LISP_H): Add lib/intprops.h.
5363
5364 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5365
5366 * image.c (gif_load): Add animation frame delay to the metadata.
5367 (syms_of_image): Use DEFSYM. New symbol `delay'.
5368
5369 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5370
5371 * window.c (delete_deletable_window): Re-add.
5372 (Fset_window_configuration): Rewrite to handle dead buffers and
5373 consequently deletable windows.
5374 (window_tree, Fwindow_tree): Remove. Supply functionality in
5375 window.el.
5376 (compare_window_configurations): Simplify code.
5377
5378 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5379
5380 * image.c (imagemagick_load_image): Fix type mismatch.
5381 (Fimagemagick_types): Likewise.
5382
5383 * window.h (replace_buffer_in_windows): Declare.
5384
5385 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5386
5387 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5388 Qclone_number. Remove external declaration of Qdelete_window.
5389 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5390 code.
5391 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5392 Run Qbuffer_list_update_hook if allowed.
5393 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5394 buffer list implementation.
5395 (other_buffer_safely): New function.
5396 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5397 calls to replace_buffer_in_windows and
5398 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5399 if allowed.
5400 (record_buffer): Inhibit quitting and rewrite using quittable
5401 functions. Run Qbuffer_list_update_hook if allowed.
5402 (Frecord_buffer, Funrecord_buffer): New functions.
5403 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5404 Move switch-to-buffer to window.el.
5405 (bury-buffer): Move to window.el.
5406 (Vbuffer_list_update_hook): New variable.
5407
5408 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5409 section.
5410
5411 * window.h (resize_frame_windows): Move up in code.
5412 (Fwindow_frame): Remove EXFUN.
5413 (replace_buffer_in_all_windows): Remove prototype.
5414 (replace_buffer_in_windows_safely): Add prototype.
5415
5416 * window.c: Declare Qdelete_window static again. Move down
5417 declaration of select_count.
5418 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5419 (Fother_window): Move to window.el.
5420 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5421 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5422 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5423 window.el.
5424 (replace_buffer_in_windows): Implement by calling
5425 Qreplace_buffer_in_windows.
5426 (replace_buffer_in_all_windows): Remove with some functionality
5427 moved into replace_buffer_in_windows_safely.
5428 (replace_buffer_in_windows_safely): New function.
5429 (select_window_norecord, select_frame_norecord): Move in front
5430 of run_window_configuration_change_hook. Remove now obsolete
5431 declarations.
5432 (Fset_window_buffer): Rewrite doc-string.
5433 Call Qrecord_window_buffer.
5434 (keys_of_window): Move binding for other-window to window.el.
5435
5436 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5437
5438 * dispextern.h (struct image): Replace data member, whose int_val
5439 and ptr_val fields were not used by anything, with a single
5440 lisp_val object.
5441
5442 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5443 (gif_clear_image, gif_load, imagemagick_load_image)
5444 (gs_clear_image, gs_load): Callers changed.
5445
5446 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5447
5448 * buffer.h: Include <time.h>, for time_t.
5449 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5450
5451 Fix minor problems found by static checking.
5452
5453 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5454
5455 Make identifiers static if they are not used in other modules.
5456 * data.c (Qcompiled_function, Qframe, Qvector):
5457 * image.c (QimageMagick, Qsvg):
5458 * minibuf.c (Qmetadata):
5459 * window.c (resize_window_check, resize_root_window): Now static.
5460 * window.h (resize_window_check, resize_root_window): Remove decls.
5461
5462 * window.c (window_deletion_count, delete_deletable_window):
5463 Remove; unused.
5464 (window_body_lines): Now static.
5465 (Fdelete_other_windows_internal): Mark vars as initialized.
5466 Make sure 'resize_failed' is initialized.
5467 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5468 (resize_window_apply): Remove unused local.
5469 * window.h (delete_deletable_window): Remove decl.
5470
5471 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5472 (imagemagick_load_image): Fix pointer signedness problem by changing
5473 last arg from unsigned char * to char *. All uses changed.
5474 Also, fix a local for similar reasons.
5475 Remove unused locals. Remove locals to avoid shadowing.
5476 (fn_rsvg_handle_free): Remove; unused.
5477 (svg_load, svg_load_image): Fix pointer signedness problem.
5478 (imagemagick_load_image): Don't use garbage pointer image_wand.
5479
5480 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5481
5482 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5483
5484 * image.c (gif_load): Fix omitted cast error introduced by
5485 2011-06-06 change.
5486
5487 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5488
5489 * window.h (resize_proportionally, orig_total_lines)
5490 (orig_top_line): Remove from window structure.
5491 (set_window_height, set_window_width, change_window_heights)
5492 (Fdelete_window): Remove prototypes.
5493 (resize_frame_windows): Remove duplicate declaration.
5494
5495 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5496
5497 * window.h (resize_frame_windows, resize_window_check)
5498 (delete_deletable_window, resize_root_window)
5499 (resize_frame_windows): Declare prototypes.
5500
5501 * window.c (resize_window_apply): Make definition be "static" to
5502 match the prototype.
5503
5504 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5505
5506 * window.c: Remove declarations of Qwindow_size_fixed,
5507 window_min_size_1, window_min_size_2, window_min_size,
5508 size_window, window_fixed_size_p, enlarge_window, delete_window.
5509 Remove static from declaration of Qdelete_window, it's
5510 temporarily needed by Fbury_buffer.
5511 (replace_window): Don't assign orig_top_line and
5512 orig_total_lines.
5513 (Fdelete_window, delete_window): Remove. Window deletion is
5514 handled by window.el.
5515 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5516 Replace Fdelete_window calls with calls to Qdelete_window.
5517 (Fdelete_other_windows): Remove. Deleting other windows is
5518 handled by window.el.
5519 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5520 handled in window.el.
5521 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5522 Window minimum sizes are handled in window.el.
5523 (shrink_windows, size_window, set_window_height)
5524 (set_window_width, change_window_heights, window_height)
5525 (window_width, CURBEG, CURSIZE, enlarge_window)
5526 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5527 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5528 handled in window.el.
5529 (make_dummy_parent): Rename to make_parent_window and give it a
5530 second argument horflag.
5531 (make_window): Don't set resize_proportionally any more.
5532 (Fsplit_window): Remove. Windows are split in window.el.
5533 (save_restore_action, save_restore_orig_size)
5534 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5535 Resize mini windows in window.el.
5536 (grow_mini_window, shrink_mini_window): Implement by calling
5537 Qresize_root_window_vertically, resize_window_check and
5538 resize_window_apply.
5539 (saved_window, Fset_window_configuration, save_window_save):
5540 Do not handle orig_top_line, orig_total_lines, and
5541 resize_proportionally.
5542 (window_min_height, window_min_width): Move to window.el.
5543 (keys_of_window): Move bindings for delete-other-windows,
5544 split-window, delete-window and enlarge-window to window.el.
5545
5546 * buffer.c: Temporarily extern Qdelete_window.
5547 (Fbury_buffer): Temporarily call Qdelete_window instead of
5548 Fdelete_window (Fbury_buffer will move to window.el soon).
5549
5550 * frame.c (set_menu_bar_lines_1): Remove code handling
5551 orig_top_line and orig_total_lines.
5552
5553 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5554 set_window_height but set heights directly.
5555 (change_frame_size_1): Use resize_frame_windows.
5556
5557 * xdisp.c (init_xdisp): Don't use set_window_height but set
5558 heights directly.
5559
5560 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5561 Use resize_frame_windows instead of change_window_heights and run
5562 run_window_configuration_change_hook.
5563
5564 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5565 instead of change_window_heights and run
5566 run_window_configuration_change_hook.
5567
5568 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5569
5570 * window.c (replace_window): Rename second argument REPLACEMENT to
5571 NEW. New third argument SETFLAG. Rewrite.
5572 (delete_window, make_dummy_parent): Call replace_window with
5573 third argument 1.
5574 (window_list_1): Move down in code.
5575 (run_window_configuration_change_hook): Move set_buffer part
5576 before select_frame_norecord part in order to unwind correctly.
5577 Rename count1 to count.
5578 (recombine_windows, delete_deletable_window, resize_root_window)
5579 (Fdelete_other_windows_internal)
5580 (Frun_window_configuration_change_hook, make_parent_window)
5581 (resize_window_check, resize_window_apply, Fresize_window_apply)
5582 (resize_frame_windows, Fsplit_window_internal)
5583 (Fdelete_window_internal, Fresize_mini_window_internal):
5584 New functions.
5585 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5586
5587 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5588
5589 * window.h (window): Add some new members to window structure -
5590 normal_lines, normal_cols, new_total, new_normal, clone_number,
5591 splits, nest, prev_buffers, next_buffers.
5592 (WINDOW_TOTAL_SIZE): Move here from window.c.
5593 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5594
5595 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5596 Remove.
5597 (make_dummy_parent): Set new members of windows structure.
5598 (make_window): Move down in code. Handle new members of window
5599 structure.
5600 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5601 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5602 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5603 (Fset_window_prev_buffers, Fwindow_next_buffers)
5604 (Fset_window_next_buffers, Fset_window_clone_number):
5605 New functions.
5606 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5607 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5608 Doc-string fixes.
5609 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5610 Argument WINDOW can be now internal window too.
5611 (Fwindow_use_time): Move up in code.
5612 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5613 Rewrite doc-string.
5614 (Fset_window_configuration, saved_window)
5615 (Fcurrent_window_configuration, save_window_save): Handle new
5616 members of window structure.
5617 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5618 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5619 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5620 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5621 Qget_mru_window, Qresize_root_window,
5622 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5623 Qauto_buffer_name; staticpro them.
5624
5625 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5626
5627 * window.c (Fwindow_total_size, Fwindow_left_column)
5628 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5629 (Fwindow_list_1): New functions.
5630 (window_box_text_cols): Replace with window_body_cols.
5631 (Fwindow_width, Fscroll_left, Fscroll_right):
5632 Use window_body_cols instead of window_box_text_cols.
5633 (delete_window, Fset_window_configuration):
5634 Call delete_all_subwindows with window as argument.
5635 (delete_all_subwindows): Take a window as argument and not a
5636 structure. Rewrite.
5637 (window_loop): Remove handling of GET_LRU_WINDOW and
5638 GET_LARGEST_WINDOW.
5639 (Fget_lru_window, Fget_largest_window): Move to window.el.
5640
5641 * window.h: Extern window_body_cols instead of
5642 window_box_text_cols. delete_all_subwindows now takes a
5643 Lisp_Object as argument.
5644
5645 * indent.c (compute_motion, Fcompute_motion):
5646 Use window_body_cols instead of window_box_text_cols.
5647
5648 * frame.c (delete_frame): Call delete_all_subwindows with root
5649 window as argument.
5650
5651 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5652
5653 * fns.c (Fputhash): Document return value.
5654
5655 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5656
5657 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5658
5659 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5660
5661 Cons<->int and similar integer overflow fixes (Bug#8794).
5662
5663 Check for overflow when converting integer to cons and back.
5664 * charset.c (Fdefine_charset_internal, Fdecode_char):
5665 Use cons_to_unsigned to catch overflow.
5666 (Fencode_char): Use INTEGER_TO_CONS.
5667 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5668 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5669 * data.c (long_to_cons, cons_to_long): Remove.
5670 (cons_to_unsigned, cons_to_signed): New functions.
5671 These signal an error for invalid or out-of-range values.
5672 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5673 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5674 * font.c (Ffont_variation_glyphs):
5675 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5676 * lisp.h: Include <intprops.h>.
5677 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5678 (cons_to_signed, cons_to_unsigned): New decls.
5679 (long_to_cons, cons_to_long): Remove decls.
5680 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5681 (Fprimitive_undo): Use CONS_TO_INTEGER.
5682 * xfns.c (Fx_window_property): Likewise.
5683 * xselect.c: Include <limits.h>.
5684 (x_own_selection, selection_data_to_lisp_data):
5685 Use INTEGER_TO_CONS.
5686 (x_handle_selection_request, x_handle_selection_clear)
5687 (x_get_foreign_selection, Fx_disown_selection_internal)
5688 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5689 (lisp_data_to_selection_data): Use cons_to_unsigned.
5690 (x_fill_property_data): Use cons_to_signed.
5691 Report values out of range.
5692
5693 Check for buffer and string overflow more precisely.
5694 * buffer.h (BUF_BYTES_MAX): New macro.
5695 * lisp.h (STRING_BYTES_MAX): New macro.
5696 * alloc.c (Fmake_string):
5697 * character.c (string_escape_byte8):
5698 * coding.c (coding_alloc_by_realloc):
5699 * doprnt.c (doprnt):
5700 * editfns.c (Fformat):
5701 * eval.c (verror):
5702 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5703 since they may not be the same number.
5704 * editfns.c (Finsert_char):
5705 * fileio.c (Finsert_file_contents):
5706 Likewise for BUF_BYTES_MAX.
5707
5708 * image.c: Use ptrdiff_t, not int, for sizes.
5709 (slurp_file): Switch from int to ptrdiff_t.
5710 All uses changed.
5711 (slurp_file): Check that file size fits in both size_t (for
5712 malloc) and ptrdiff_t (for sanity and safety).
5713
5714 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5715 if b->modtime has its maximal value.
5716
5717 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5718
5719 Don't assume time_t can fit into int.
5720 * buffer.h (struct buffer.modtime): Now time_t, not int.
5721 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5722 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5723
5724 Minor fixes for signed vs unsigned integers.
5725 * character.h (MAYBE_UNIFY_CHAR):
5726 * charset.c (maybe_unify_char):
5727 * keyboard.c (read_char, reorder_modifiers):
5728 XINT -> XFASTINT, since the integer must be nonnegative.
5729 * ftfont.c (ftfont_spec_pattern):
5730 * keymap.c (access_keymap, silly_event_symbol_error):
5731 XUINT -> XFASTINT, since the integer must be nonnegative.
5732 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5733 since it makes no difference and we prefer signed.
5734 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5735 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5736 nonnegative.
5737
5738 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5739
5740 * window.h (Fwindow_frame): Declare.
5741
5742 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5743
5744 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5745 (SPARE_MEMORY): Always define.
5746 (LARGE_REQUEST): Remove.
5747 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5748
5749 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5750
5751 * lisp.h: Move EXFUNS for Fframe_root_window,
5752 Fframe_first_window and Fset_frame_selected_window to window.h.
5753
5754 * window.h: Move EXFUNS for Fframe_root_window,
5755 Fframe_first_window and Fset_frame_selected_window here from
5756 lisp.h.
5757
5758 * frame.c (Fwindow_frame, Fframe_first_window)
5759 (Fframe_root_window, Fframe_selected_window)
5760 (Fset_frame_selected_window): Move to window.c.
5761 (Factive_minibuffer_window): Move to minibuf.c.
5762 (Fother_visible_frames_p): New function.
5763
5764 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5765
5766 * window.c (decode_window, decode_any_window): Move up in code.
5767 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5768 (inhibit_frame_unsplittable): Remove unused variable.
5769 (Fwindow_buffer): Move up and rewrite doc-string.
5770 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5771 (Fwindow_prev): New functions.
5772 (Fwindow_frame): Move here from frame.c. Accept any window as
5773 argument.
5774 (Fframe_root_window, Fframe_first_window)
5775 (Fframe_selected_window): Move here from frame.c. Accept frame
5776 or arbitrary window as argument. Update doc-strings.
5777 (Fminibuffer_window): Move up in code.
5778 (Fwindow_minibuffer_p): Move up in code and simplify.
5779 (Fset_frame_selected_window): Move here from frame.c.
5780 Marginal rewrite.
5781 (Fselected_window, select_window, Fselect_window): Move up in
5782 code. Minor doc-string fixes.
5783
5784 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5785
5786 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5787 Do not assume that spare memory exists; that assumption is valid
5788 only if SYSTEM_MALLOC.
5789 (LARGE_REQUEST): New macro, so that the issue of large requests
5790 is separated from the issue of spare memory.
5791
5792 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5793
5794 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5795 format. (Bug#8806)
5796
5797 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5798
5799 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5800 before statements.
5801
5802 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5803
5804 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5805
5806 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5807
5808 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5809 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5810
5811 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5812
5813 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5814
5815 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5816
5817 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5818 (x_clipboard_manager_save): Add return value.
5819 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5820 New error handlers.
5821 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5822 Obey Vx_select_enable_clipboard_manager. Catch errors in
5823 x_clipboard_manager_save (Bug#8779).
5824 (Vx_select_enable_clipboard_manager): New variable.
5825 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5826
5827 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5828
5829 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5830
5831 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5832
5833 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5834 in the current matrix if keep_current_p is non-zero.
5835
5836 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5837
5838 * bidi.c (bidi_level_of_next_char): Fix last change.
5839
5840 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5841
5842 Support bidi reordering of text covered by display properties.
5843
5844 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5845 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5846 (bidi_cache_search, bidi_cache_iterator_state)
5847 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5848 (bidi_level_of_next_char, bidi_move_to_visually_next):
5849 Support character positions inside a run of characters covered by a
5850 display string.
5851 (bidi_paragraph_init, bidi_resolve_explicit_1)
5852 (bidi_level_of_next_char): Call bidi_fetch_char and
5853 bidi_fetch_char_advance instead of FETCH_CHAR and
5854 FETCH_CHAR_ADVANCE.
5855 (bidi_init_it): Initialize new members.
5856 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5857 definitions.
5858 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5859 instead of using explicit *_CHAR codes.
5860 (bidi_resolve_explicit, bidi_resolve_weak):
5861 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5862 bidirectional text is supported only in multibyte buffers.
5863 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5864 it to initialize the frame_window_p member of struct bidi_it.
5865 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5866 (bidi_resolve_explicit, bidi_resolve_weak)
5867 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5868 bidi_it->nchars is non-positive.
5869 (bidi_level_of_next_char): Don't try to lookup the cache for the
5870 next/previous character if nothing is cached there yet, or if we
5871 were just reseat()'ed to a new position.
5872
5873 * xdisp.c (set_cursor_from_row): Set start and stop points
5874 according to the row's direction when priming the loop that looks
5875 for the glyph on which to display cursor.
5876 (single_display_spec_intangible_p): Function deleted.
5877 (display_prop_intangible_p): Reimplement to call
5878 handle_display_spec instead of single_display_spec_intangible_p.
5879 Accept 3 additional arguments needed by handle_display_spec.
5880 This fixes incorrect cursor motion across display property with complex
5881 values: lists, `(when COND...)' forms, etc.
5882 (single_display_spec_string_p): Support property values that are
5883 lists with the argument STRING its top-level element.
5884 (display_prop_string_p): Fix the condition for processing a
5885 property that is a list to be consistent with handle_display_spec.
5886 (handle_display_spec): New function, refactored from the
5887 last portion of handle_display_prop.
5888 (compute_display_string_pos): Accept additional argument
5889 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5890 value of a `display' property is a "replacing spec".
5891 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5892 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5893 the display property, but just return a value indicating whether
5894 the display property will replace the characters it covers.
5895 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5896 frame_window_p members of struct bidi_it.
5897 (compute_display_string_pos, compute_display_string_end):
5898 New functions.
5899 (push_it): Accept second argument POSITION, where pop_it should
5900 jump to continue iteration.
5901 (reseat_1): Initialize bidi_it.disp_pos.
5902
5903 * keyboard.c (adjust_point_for_property): Adjust the call to
5904 display_prop_intangible_p to its new signature.
5905
5906 * dispextern.h (struct bidi_it): New member frame_window_p.
5907 (bidi_init_it): Update prototypes.
5908 (display_prop_intangible_p): Update prototype.
5909 (compute_display_string_pos, compute_display_string_end):
5910 Declare prototypes.
5911 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5912 EMACS_INT.
5913
5914 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5915
5916 Malloc failure behavior now depends on size of allocation.
5917 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5918 * lisp.h: Change signatures accordingly.
5919 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5920 All callers changed. (Bug#8762)
5921
5922 * gnutls.c: Use Emacs's memory allocators.
5923 Without this change, the gnutls library would invoke malloc etc.
5924 directly, which causes problems on non-SYNC_INPUT hosts, and which
5925 runs afoul of improving memory_full behavior. (Bug#8761)
5926 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5927 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5928 xfree instead of the default malloc, realloc, free.
5929 (Fgnutls_boot): No need to check for memory allocation failure,
5930 since xmalloc does that for us.
5931
5932 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5933 * category.c (hash_get_category_set):
5934 * ccl.c (ccl_driver):
5935 * charset.c (Fdefine_charset_internal):
5936 * charset.h (struct charset.hash_index):
5937 * composite.c (get_composition_id, gstring_lookup_cache)
5938 (composition_gstring_put_cache):
5939 * composite.h (struct composition.hash_index):
5940 * dispextern.h (struct image.hash):
5941 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5942 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5943 (hashfn_equal, hashfn_user_defined, make_hash_table)
5944 (maybe_resize_hash_table, hash_lookup, hash_put)
5945 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5946 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5947 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5948 * image.c (make_image, search_image_cache, lookup_image)
5949 (xpm_put_color_table_h):
5950 * lisp.h (struct Lisp_Hash_Table):
5951 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5952 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5953 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5954 * alloc.c (allocate_vectorlike):
5955 Check for overflow in vector size calculations.
5956 * ccl.c (ccl_driver):
5957 Check for overflow when converting EMACS_INT to int.
5958 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5959 need to be updated by these changes.
5960 * fns.c (make_hash_table, maybe_resize_hash_table):
5961 Check for integer overflow with large hash tables.
5962 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5963 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5964 (SXHASH_REDUCE): New macro.
5965 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5966 Use it instead of discarding useful hash info with large hash values.
5967 (sxhash_float): New function.
5968 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5969 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5970 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5971 Rewrite to use FIXNUM_BITS, as this simplifies things.
5972 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5973 Adjust signatures to match updated version of code.
5974 (consing_since_gc): Now EMACS_INT, since a single hash table can
5975 use more than INT_MAX bytes.
5976
5977 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5978
5979 Make it possible to build with GCC-4.6+ -O2 -flto.
5980
5981 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5982
5983 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5984
5985 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5986 Call minibuffer-inactive-mode.
5987
5988 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5989
5990 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5991 Update dependencies.
5992
5993 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5994
5995 * data.c (init_data): Remove code for UTS, this system is not
5996 supported anymore.
5997
5998 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5999
6000 Don't force ./temacs to start in terminal mode.
6001
6002 * frame.c (make_initial_frame): Initialize faces in all cases, not
6003 only when CANNOT_DUMP is defined.
6004 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6005
6006 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6007
6008 * dispnew.c (add_window_display_history): Use const for the string
6009 pointer. Remove declaration, not needed.
6010
6011 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6012
6013 Use 'inline', not 'INLINE'.
6014 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6015 * alloc.c, fontset.c (INLINE): Remove.
6016 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6017 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6018 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6019 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6020 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6021
6022 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6023
6024 Make it possible to run ./temacs.
6025
6026 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6027 syms_of_callproc does the same thing. Remove test for
6028 "initialized", do it in the caller.
6029 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6030
6031 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6032
6033 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6034 (read_minibuf): Use get_minibuffer.
6035 (syms_of_minibuf): Use DEFSYM.
6036 (Qmetadata): New var.
6037 * data.c (Qbuffer): Don't make it static.
6038 (syms_of_data): Use DEFSYM.
6039
6040 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6041
6042 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6043 (CCL_CODE_MIN): New macro.
6044
6045 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6046
6047 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6048
6049 * eval.c (Qdebug): Now static.
6050 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6051 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6052 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6053
6054 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6055
6056 * image.c: Various fixes to ImageMagick code comments.
6057 (Fimagemagick_types): Doc fix.
6058
6059 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6060
6061 Minor fixes prompted by GCC 4.6.0 warnings.
6062
6063 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6064
6065 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6066 (x_clipboard_manager_save_all): Move extern decl to ...
6067 * xterm.h: ... here, so that it can be checked for consistency.
6068
6069 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6070
6071 * xselect.c (x_clipboard_manager_save_frame)
6072 (x_clipboard_manager_save_all): New functions.
6073 (Fx_clipboard_manager_save): Lisp function deleted.
6074
6075 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6076 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6077
6078 * xterm.h: Update prototype.
6079
6080 2011-05-28 William Xu <william.xwl@gmail.com>
6081
6082 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6083 exiting (Bug#8239).
6084
6085 2011-05-28 Jim Meyering <meyering@redhat.com>
6086
6087 Avoid a sign-extension bug in crypto_hash_function.
6088 * fns.c (to_uchar): Define.
6089 (crypto_hash_function): Use it to convert some newly-signed
6090 variables to unsigned, to avoid sign-extension bugs. For example,
6091 without this change, (md5 "truc") would evaluate to
6092 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6093 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6094 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6095
6096 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6097
6098 Integer overflow fixes.
6099
6100 * dbusbind.c: Serial number integer overflow fixes.
6101 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6102 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6103 to hold a serial number that is too large for a fixnum.
6104 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6105 Check for serial numbers out of range. Decode any serial number
6106 that was so large that it became a float. (Bug#8722)
6107
6108 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6109 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6110 Use XFASTINT rather than XUINT when numbers are nonnegative.
6111 (xd_append_arg, Fdbus_method_return_internal):
6112 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6113 arguments, check that Lisp number is nonnegative, rather than
6114 silently wrapping negative numbers around. (Bug#8722)
6115 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6116 (Bug#8722)
6117
6118 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6119
6120 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6121
6122 ccl: Add integer overflow checks.
6123 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6124 (IN_INT_RANGE): New macros.
6125 (ccl_driver): Use them to check for integer overflow when
6126 decoding a CCL program. Many of the new checks are whether XINT (x)
6127 fits in int; it doesn't always, on 64-bit hosts. The new version
6128 doesn't catch all possible integer overflows, but it's an
6129 improvement. (Bug#8719)
6130
6131 * alloc.c (make_event_array): Use XINT, not XUINT.
6132 There's no need for unsigned here.
6133
6134 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6135 This follows up to the 2011-05-06 change that substituted uintptr_t
6136 for EMACS_INT. This case wasn't caught back then.
6137
6138 Rework Fformat to avoid integer overflow issues.
6139 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6140 now (part of C89). Include <verify.h>.
6141 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6142 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6143 (Fformat): Avoid the prepass trying to compute sizes; it was only
6144 approximate and thus did not catch overflow reliably. Instead, walk
6145 through the format just once, formatting and computing sizes as we go,
6146 checking for integer overflow at every step, and allocating a larger
6147 buffer as needed. Keep track separately whether the format is
6148 multibyte. Keep only the most-recently calculated precision, rather
6149 than them all. Record whether each argument has been converted to
6150 string. Use EMACS_INT, not int, for byte and char and arg counts.
6151 Support field widths and precisions larger than INT_MAX. Avoid
6152 sprintf's undefined behavior with conversion specifications such as %#d
6153 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6154 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6155 formatting out-of-range floating point numbers with int
6156 formats. (Bug#8668)
6157
6158 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6159
6160 * data.c: Avoid integer truncation in expressions involving floats.
6161 * data.c: Include <intprops.h>.
6162 (arith_driver): When there's an integer overflow in an expression
6163 involving floating point, convert the integers to floating point
6164 so that the resulting value does not suffer from catastrophic
6165 integer truncation. For example, on a 64-bit host (* 4
6166 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6167 Do not rely on undefined behavior after integer overflow.
6168
6169 merge count_size_as_multibyte, parse_str_to_multibyte
6170 * character.c, character.h (count_size_as_multibyte):
6171 Rename from parse_str_to_multibyte; all uses changed.
6172 Check for integer overflow.
6173 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6174 since it's now a duplicate of the other. This is more of
6175 a character than a buffer op, so better that it's in character.c.
6176 * fns.c, print.c: Adjust to above changes.
6177
6178 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6179
6180 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6181
6182 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6183
6184 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6185 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6186 (x_clipboard_manager_save): Now static.
6187 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6188
6189 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6190 (crypto_hash_function): Now static.
6191 Fix pointer signedness problems. Avoid unnecessary initializations.
6192
6193 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6194
6195 * termhooks.h (Vselection_alist): Make it terminal-local.
6196
6197 * terminal.c (create_terminal): Initialize it.
6198
6199 * xselect.c: Support for clipboard managers.
6200 (Vselection_alist): Move to termhooks.h as terminal-local var.
6201 (LOCAL_SELECTION): New macro.
6202 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6203 (symbol_to_x_atom): Remove gratuitous arg.
6204 (x_handle_selection_request, lisp_data_to_selection_data)
6205 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6206 (x_own_selection, x_get_local_selection, x_convert_selection):
6207 New arg, specifying work frame. Use terminal-local Vselection_alist.
6208 (some_frame_on_display): Delete unused function.
6209 (Fx_own_selection_internal, Fx_get_selection_internal)
6210 (Fx_disown_selection_internal, Fx_selection_owner_p)
6211 (Fx_selection_exists_p): New optional frame arg.
6212 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6213 (x_handle_selection_clear): Don't treat other terminals with the
6214 same keyboard specially. Use the terminal-local Vselection_alist.
6215 (x_clear_frame_selections): Use Frun_hook_with_args.
6216
6217 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6218
6219 * xterm.h: Add support for those atoms.
6220
6221 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6222
6223 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6224 (converted_selections, conversion_fail_tag): New global variables.
6225 (x_selection_request_lisp_error): Free the above.
6226 (x_get_local_selection): Remove unnecessary code.
6227 (x_reply_selection_request): Args changed; handle arbitrary array
6228 of converted selections stored in converted_selections.
6229 Separate the XChangeProperty and SelectionNotify steps.
6230 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6231 (x_convert_selection): New function.
6232 (x_handle_selection_event): Simplify.
6233 (x_get_foreign_selection): Don't ignore incoming requests while
6234 waiting for an answer; this will fail when we implement
6235 SAVE_TARGETS, and seems unnecessary anyway.
6236 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6237 (Vx_sent_selection_functions): Doc fix.
6238
6239 2011-05-26 Leo Liu <sdl.web@gmail.com>
6240
6241 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6242
6243 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6244
6245 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6246
6247 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6248 for fringe update if it has periodic bitmap.
6249 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6250 and fringe_bitmap_periodic_p.
6251
6252 * fringe.c (get_fringe_bitmap_data): New function.
6253 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6254 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6255 row. Mark glyph row for fringe update if periodicity changed.
6256
6257 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6258 for fringe update unless it has periodic bitmap.
6259
6260 2011-05-25 Kenichi Handa <handa@m17n.org>
6261
6262 * xdisp.c (get_next_display_element): Set correct it->face_id for
6263 a static composition.
6264
6265 2011-05-24 Leo Liu <sdl.web@gmail.com>
6266
6267 * deps.mk (fns.o):
6268 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6269
6270 * fns.c (crypto_hash_function, Fsha1): New function.
6271 (Fmd5): Use crypto_hash_function.
6272 (syms_of_fns): Add Ssha1.
6273
6274 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6275
6276 * gnutls.c: Remove unused macros.
6277 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6278 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6279 Remove macros that are defined and never used.
6280 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6281
6282 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6283
6284 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6285 (Fx_get_selection_internal): Minor cleanup.
6286 (Fx_own_selection_internal): Rename arguments for consistency with
6287 select.el.
6288
6289 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6290
6291 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6292
6293 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6294
6295 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6296
6297 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6298
6299 * dispnew.c (scrolling_window): Don't exclude the case that the
6300 last enabled row in the desired matrix touches the bottom boundary.
6301
6302 2011-05-21 Glenn Morris <rgm@gnu.org>
6303
6304 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6305 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6306 and add some more files.
6307
6308 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6309
6310 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6311 report_file_error introduced by the change from 2011-05-07.
6312
6313 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6314
6315 * systime.h (Time): Define only if emacs is defined.
6316 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6317 where the include path doesn't have X11/X.h by default. See
6318 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6319
6320 2011-05-20 Kenichi Handa <handa@m17n.org>
6321
6322 * composite.c (find_automatic_composition): Fix previous change.
6323
6324 2011-05-20 Glenn Morris <rgm@gnu.org>
6325
6326 * lisp.mk: New file, split from Makefile.in.
6327 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6328 (shortlisp): Remove.
6329 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6330
6331 2011-05-19 Glenn Morris <rgm@gnu.org>
6332
6333 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6334 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6335 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6336 (lisp): Set the order to that of loadup.el.
6337 (shortlisp): Make it a copy of $lisp.
6338 (SOME_MACHINE_LISP): Remove.
6339 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6340 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6341
6342 2011-05-18 Kenichi Handa <handa@m17n.org>
6343
6344 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6345 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6346 (find_automatic_composition): Mostly rewrite for efficiency.
6347
6348 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6349
6350 * makefile.w32-in: Update dependencies.
6351
6352 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6353
6354 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6355 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6356
6357 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6358
6359 Fix some integer overflow issues, such as string length overflow.
6360
6361 * insdel.c (count_size_as_multibyte): Check for string overflow.
6362
6363 * character.c (lisp_string_width): Check for string overflow.
6364 Use EMACS_INT, not int, for string indexes and lengths; in
6365 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6366 the resulting string length overflows an EMACS_INT; instead,
6367 report a string overflow if no precision given. When checking for
6368 precision exhaustion, use a check that cannot possibly have
6369 integer overflow. (Bug#8675)
6370 * character.h (lisp_string_width): Adjust to new signature.
6371
6372 * alloc.c (string_overflow): New function.
6373 (Fmake_string): Use it. This doesn't change behavior, but saves
6374 a few bytes and will simplify future changes.
6375 * character.c (string_escape_byte8): Likewise.
6376 * lisp.h (string_overflow): New decl.
6377
6378 Fixups, following up to the user-interface timestamp change.
6379 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6380 for UI timestamps, instead of unsigned long.
6381 * msdos.c (mouse_get_pos): Likewise.
6382 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6383 * w32gui.h (Time): Define by including "systime.h" rather than by
6384 declaring it ourselves. (Bug#8664)
6385
6386 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6387 * image.c (clear_image_cache): Likewise.
6388
6389 * term.c (term_mouse_position): Don't assume time_t wraparound.
6390
6391 Be more systematic about user-interface timestamps.
6392 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6393 and sometimes 'EMACS_UINT', to represent these timestamps.
6394 This change causes it to use 'Time' uniformly, as that's what X uses.
6395 This makes the code easier to follow, and makes it easier to catch
6396 integer overflow bugs such as Bug#8664.
6397 * frame.c (Fmouse_position, Fmouse_pixel_position):
6398 Use Time, not unsigned long, for user-interface timestamps.
6399 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6400 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6401 * keyboard.h (last_event_timestamp): Likewise.
6402 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6403 * menu.h (xmenu_show): Likewise.
6404 * term.c (term_mouse_position): Likewise.
6405 * termhooks.h (struct input_event.timestamp): Likewise.
6406 (struct terminal.mouse_position_hook): Likewise.
6407 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6408 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6409 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6410 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6411 what it was before.
6412 * menu.h, termhooks.h: Include "systime.h", for Time.
6413
6414 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6415 Don't assume that the difference between two unsigned long values
6416 can fit into an integer. At this point, we know button_down_time
6417 <= event->timestamp, so the difference must be nonnegative, so
6418 there's no need to cast the result if double-click-time is
6419 nonnegative, as it should be; check that it's nonnegative, just in
6420 case. This bug is triggered when events are more than 2**31 ms
6421 apart (about 25 days). (Bug#8664)
6422
6423 * xselect.c (last_event_timestamp): Remove duplicate decl.
6424 (x_own_selection): Remove needless cast to unsigned long.
6425
6426 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6427 that always fit in int. Use a sentinel instead of a counter, to
6428 avoid a temp and to allay GCC's concerns about possible int overflow.
6429 * frame.h (struct frame): Use int for menu_bar_items_used
6430 instead of EMACS_INT, since it always fits in int.
6431
6432 * menu.c (grow_menu_items): Check for int overflow.
6433
6434 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6435
6436 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6437 Before, the code was not consistent. These values cannot exceed
6438 2**31 - 1 so there's no need to make them unsigned.
6439 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6440 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6441 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6442 as modifiers.
6443 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6444
6445 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6446 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6447 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6448 presumably because the widths might not match.
6449
6450 * window.c (size_window): Avoid needless test at loop start.
6451
6452 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6453
6454 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6455
6456 2011-05-12 Drew Adams <drew.adams@oracle.com>
6457
6458 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6459
6460 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6461
6462 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6463 `width' to `bar_area_x' and `bar_area_width', respectively.
6464 (x_scroll_run): Take account of fringe background extension.
6465
6466 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6467 Rename local vars `left' and `width' to `bar_area_x' and
6468 `bar_area_width', respectively.
6469 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6470 background extension.
6471
6472 2011-05-10 Jim Meyering <meyering@redhat.com>
6473
6474 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6475
6476 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6477
6478 * image.c (Finit_image_library): Return t for built-in image types,
6479 like pbm and xbm. (Bug#8640)
6480
6481 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6482
6483 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6484
6485 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6486
6487 * w32console.c (Fset_screen_color): Doc fix.
6488 (Fget_screen_color): New function.
6489 (syms_of_ntterm): Defsubr it.
6490
6491 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6492 unlink the temporary file if Fcall_process didn't create it in the
6493 first place.
6494 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6495 child process will be redirected to a file specified with `:file'.
6496 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6497 cue to call_process_cleanup not to close that handle.
6498
6499 2011-05-07 Ben Key <bkey76@gmail.com>
6500
6501 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6502 one of two shell specific rules, either bootstrap-temacs-CMD or
6503 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6504 to the previous implementation of the bootstrap-temacs rule.
6505 The bootstrap-temacs-CMD rule is similar to the previous
6506 implementation of the bootstrap-temacs rule except that it
6507 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6508 variable.
6509
6510 These changes, along with some changes to nt/configure.bat,
6511 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6512 earlier fix to add support for --cflags and --ldflags options
6513 that include quotes so that it works whether make uses cmd or
6514 sh as the shell.
6515
6516 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6517
6518 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6519 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6520 is a constant.
6521 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6522 a string. Handle both cases.
6523 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6524 (Fdbus_register_method): Use Qinvalid_function.
6525
6526 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6527
6528 * makefile.w32-in: Update dependencies.
6529 (LISP_H): Add inttypes.h and stdin.h.
6530 (PROCESS_H): Add unistd.h.
6531
6532 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6533
6534 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6535 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6536
6537 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6538
6539 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6540
6541 * term.c (vfatal): Remove stray call to va_end.
6542 It's not needed and the C Standard doesn't allow it here anyway.
6543
6544 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6545 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6546
6547 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6548 bytes.
6549
6550 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6551
6552 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6553
6554 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6555
6556 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6557
6558 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6559
6560 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6561 * charset.c (Fdefine_charset_internal): Don't initialize
6562 charset.code_space[15]. The value was garbage, on hosts with
6563 32-bit int (Bug#8600).
6564
6565 * lread.c (read_integer): Be more consistent with string-to-number.
6566 Use string_to_number to do the actual conversion; this avoids
6567 rounding errors and fixes some other screwups. Without this fix,
6568 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6569 (digit_to_number): Move earlier, for benefit of read_integer.
6570 Return -1 if the digit is out of range for the base, -2 if it is
6571 not a digit in any supported base. (Bug#8602)
6572
6573 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6574
6575 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6576 to match comment at start of function. This also removes a
6577 GCC warning about overflow in a 32+64-bit port.
6578
6579 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6580
6581 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6582 Reported by Stefan Monnier in
6583 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6584 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6585 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6586
6587 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6588 (EMACS_UINTPTR): Likewise, with uintptr_t.
6589
6590 * lisp.h: Prefer 64-bit EMACS_INT if available.
6591 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6592 on 32-bit hosts that have 64-bit int, so that they can access
6593 large files.
6594 However, temporarily disable this change unless the temporary
6595 symbol WIDE_EMACS_INT is defined.
6596
6597 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6598
6599 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6600 This removes an assumption that EMACS_INT and long are the same
6601 width as pointers. The assumption is true for Emacs porting targets
6602 now, but we want to make other targets possible.
6603 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6604 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6605 In the rest of the code, change types of integers that hold casted
6606 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6607 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6608 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6609 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6610 No need to cast type when ORing.
6611 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6612 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6613 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6614 assume EMACS_INT is the same width as char *.
6615 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6616 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6617 Remove no-longer-needed casts.
6618 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6619 (xg_tool_bar_help_callback, xg_make_tool_item):
6620 Use EMACS_INTPTR to hold an integer
6621 that will be cast to void *; this can avoid a GCC warning
6622 if EMACS_INT is not the same width as void *.
6623 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6624 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6625 (current_message_1, set_message_1):
6626 Use a local to convert to proper width without a cast.
6627 * xmenu.c (dialog_selection_callback): Likewise.
6628
6629 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6630 Also, don't assume VALBITS / RAND_BITS is less than 5,
6631 and don't rely on undefined behavior when shifting a 1 left into
6632 the sign bit.
6633 * lisp.h (get_random): Change signature to match.
6634
6635 * lread.c (hash_string): Use size_t, not int, for hash computation.
6636 Normally we prefer signed values; but hashing is special, because
6637 it's better to use unsigned division on hash table sizes so that
6638 the remainder is nonnegative. Also, size_t is the natural width
6639 for hashing into memory. The previous code used 'int', which doesn't
6640 retain enough info to hash well into very large tables.
6641 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6642
6643 * dbusbind.c: Don't possibly lose pointer info when converting.
6644 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6645 Use XPNTR rather than XHASH, so that the high-order bits of
6646 the pointer aren't lost when converting through void *.
6647
6648 * eval.c (Fautoload): Don't double-shift a pointer.
6649
6650 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6651
6652 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6653
6654 * gnutls.c (DEF_GNUTLS_FN):
6655 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6656
6657 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6658
6659 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6660 marker. (Bug#8610)
6661
6662 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6663
6664 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6665 New version that can reserve upto 2GB of heap space.
6666
6667 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6668
6669 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6670
6671 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6672
6673 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6674 `gnutls_certificate_set_x509_key_file'.
6675
6676 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6677
6678 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6679 Update dependencies.
6680
6681 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6682
6683 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6684 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6685 Remove unused parameter `fildes'.
6686 * process.c (read_process_output, send_process): Don't pass it.
6687
6688 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6689
6690 Fix previous change: the library cache is defined in w32.c.
6691 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6692 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6693
6694 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6695
6696 Implement dynamic loading of GnuTLS on Windows.
6697
6698 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6699 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6700 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6701 Declare.
6702
6703 * gnutls.c (Qgnutls_dll): Define.
6704 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6705 (gnutls_*): Declare function pointers.
6706 (init_gnutls_functions): New function to initialize function pointers.
6707 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6708 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6709 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6710 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6711 (emacs_gnutls_write, emacs_gnutls_read)
6712 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6713 (Fgnutls_available_p): New function.
6714 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6715 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6716 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6717
6718 * image.c: Include w32.h.
6719 (Vimage_type_cache): Delete.
6720 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6721 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6722 (w32_delayed_load): Move to w32.c.
6723
6724 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6725
6726 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6727 (w32_delayed_load): Move from image.c. When loading a library, record
6728 its filename in the :loaded-from property of the library id.
6729 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6730 Initialize and staticpro them.
6731 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6732
6733 * process.c: Include lisp.h before w32.h, not after.
6734 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6735 instead of gnutls_record_check_pending.
6736
6737 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6738
6739 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6740
6741 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6742 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6743 as passed in.
6744
6745 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6746
6747 * xterm.c (x_set_frame_alpha): Do not set property on anything
6748 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6749
6750 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6751
6752 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6753
6754 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6755
6756 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6757 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6758 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6759 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6760 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6761 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6762 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6763 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6764 (Qgnutls_bootprop_callbacks_verify): Make static.
6765
6766 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6767
6768 * callproc.c: Indentation fixup.
6769
6770 * sysdep.c (wait_for_termination_1): Make static.
6771 (wait_for_termination, interruptible_wait_for_termination):
6772 Move after wait_for_termination_1.
6773
6774 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6775
6776 * sysdep.c (interruptible_wait_for_termination): New function
6777 which is like wait_for_termination, but allows keyboard
6778 interruptions.
6779
6780 * callproc.c (Fcall_process): Add (:file "file") as an option for
6781 the STDOUT buffer.
6782 (Fcall_process_region): Ditto.
6783
6784 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6785
6786 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6787 rather than `XVECTOR (FOO)->size'.
6788
6789 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6790 inttypes.h, as a gnulib replacement is used if it not available in
6791 system headers.
6792
6793 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6794
6795 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6796 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6797 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6798
6799 * coding.c (coding_alloc_by_realloc): Error out if destination
6800 will grow beyond MOST_POSITIVE_FIXNUM.
6801 (decode_coding_emacs_mule): Abort if there isn't enough place in
6802 charbuf for the composition carryover bytes. Reserve an extra
6803 space for up to 2 characters produced in a loop.
6804 (decode_coding_iso_2022): Abort if there isn't enough place in
6805 charbuf for the composition carryover bytes.
6806
6807 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6808
6809 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6810 aborting when %lld or %lll format is passed.
6811 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6812 %llo or %llx format is passed. (Bug#8545)
6813
6814 * window.c (window_scroll_line_based): Use a marker instead of
6815 simple variables to record original value of point. (Bug#7952)
6816
6817 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6818 produced by %s or %c overflows available buffer space. (Bug#8545)
6819
6820 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6821
6822 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6823 (SIZE_MAX): Move defn after all includes, as they might #define it.
6824
6825 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6826
6827 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6828
6829 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6830
6831 * keyboard.c (Qdelayed_warnings_hook): Define.
6832 (command_loop_1): Run `delayed-warnings-hook'
6833 if Vdelayed_warnings_list is non-nil.
6834 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6835 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6836
6837 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6838
6839 * doprnt.c (doprnt): Don't return value smaller than the buffer
6840 size if the message was truncated. (Bug#8545).
6841
6842 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6843
6844 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6845 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6846
6847 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6848
6849 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6850
6851 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6852
6853 * makefile.w32-in: Update dependencies.
6854
6855 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6856
6857 Improve `doprnt' and its usage. (Bug#8545)
6858 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6859 `format_end'. Remove support for %l as a conversion specifier.
6860 Don't use xrealloc. Improve diagnostics when the %l size modifier
6861 is used. Update the commentary.
6862
6863 * eval.c (verror): Simplify calculation of size_t.
6864
6865 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6866 messages.
6867
6868 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6869
6870 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6871 change.
6872
6873 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6874
6875 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6876 This makes this file independent of the recent pseudovector change.
6877
6878 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6879
6880 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6881
6882 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6883 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6884 Remove unused local.
6885 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6886
6887 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6888 GCC 4.6.0 optimizes based on type-based alias analysis.
6889 For example, if b is of type struct buffer * and v of type struct
6890 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6891 != &v->size, and therefore "v->size = 1; b->size = 2; return
6892 v->size;" must therefore return 1. This assumption is incorrect
6893 for Emacs, since it type-puns struct Lisp_Vector * with many other
6894 types. To fix this problem, this patch adds a new type struct
6895 vectorlike_header that documents the constraints on layout of vectors
6896 and pseudovectors, and helps optimizing compilers not get fooled
6897 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6898 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6899 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6900 the size member.
6901 (XSETPVECTYPE): Rewrite in terms of new macro.
6902 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6903 This is a bit clearer, and further avoids the possibility of
6904 undesirable aliasing.
6905 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6906 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6907 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6908 since Lisp_Subr is a special case (no "next" field).
6909 (ASIZE): Now uses header.size rather than size.
6910 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6911 to avoid the hassle of writing XVECTOR (foo)->header.size.
6912 (struct vectorlike_header): New type.
6913 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6914 object, to help avoid aliasing.
6915 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6916 (SUBRP): Likewise, since Lisp_Subr is a special case.
6917 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6918 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6919 (struct Lisp_Hash_Table): Combine first two members into a single
6920 struct vectorlike_header member. All uses of "size" and "next" members
6921 changed to be "header.size" and "header.next".
6922 * buffer.h (struct buffer): Likewise.
6923 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6924 * frame.h (struct frame): Likewise.
6925 * process.h (struct Lisp_Process): Likewise.
6926 * termhooks.h (struct terminal): Likewise.
6927 * window.c (struct save_window_data, struct saved_window): Likewise.
6928 * window.h (struct window): Likewise.
6929 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6930 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6931 * buffer.c (init_buffer_once): Likewise.
6932 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6933 special case.
6934 * process.c (Fformat_network_address): Use local var for size,
6935 for brevity.
6936
6937 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6938
6939 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6940 * data.c (atof): Remove decl; no longer used or needed.
6941 (digit_to_number): Move to lread.c.
6942 (Fstring_to_number): Use new string_to_number function, to be
6943 consistent with how the Lisp reader treats infinities and NaNs.
6944 Do not assume that floating-point numbers represent EMACS_INT
6945 without losing information; this is not true on most 64-bit hosts.
6946 Avoid double-rounding errors, by insisting on integers when
6947 parsing non-base-10 numbers, as the documentation specifies.
6948 * lisp.h (string_to_number): New decl, replacing ...
6949 (isfloat_string): Remove.
6950 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6951 (read1): Do not accept +. and -. as integers; this
6952 appears to have been a coding error. Similarly, do not accept
6953 strings like +-1e0 as floating point numbers. Do not report
6954 overflow for integer overflows unless the base is not 10 which
6955 means we have no simple and reliable way to continue.
6956 Break out the floating-point parsing into a new
6957 function string_to_number, so that Fstring_to_number parses
6958 floating point numbers consistently with the Lisp reader.
6959 (digit_to_number): Move here from data.c. Make it static inline.
6960 (E_CHAR, EXP_INT): Remove, replacing with ...
6961 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6962 (string_to_number): New function, replacing isfloat_string.
6963 This function checks for valid syntax and produces the resulting
6964 Lisp float number too. Rework it so that string-to-number
6965 no longer mishandles examples like "1.0e+". Use strtoumax,
6966 so that overflow for non-base-10 numbers is reported only when
6967 there's no portable and simple way to convert to floating point.
6968
6969 * textprop.c (set_text_properties_1): Rewrite for clarity,
6970 and to avoid GCC warning about integer overflow.
6971
6972 * intervals.h (struct interval): Use EMACS_INT for members
6973 where EMACS_UINT might cause problems. See
6974 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6975 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6976 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6977 All uses changed.
6978 (offset_intervals): Tell GCC not to worry about length overflow
6979 when negating a negative length.
6980
6981 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6982 (overrun_check_free): Likewise.
6983
6984 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6985 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6986 word size.
6987
6988 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6989 (gnutls_make_error): Rename local to avoid shadowing.
6990 (gnutls_emacs_global_deinit): ifdef out; not used.
6991 (Fgnutls_boot): Use const for pointer to readonly storage.
6992 Comment out unused local. Fix pointer signedness problems.
6993
6994 * lread.c (openp): Don't stuff size_t into an 'int'.
6995 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6996 about possible signed overflow.
6997
6998 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6999 (GDK_KEY_g): Don't define if already defined.
7000 (xg_prepare_tooltip): Avoid pointer signedness problem.
7001 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7002
7003 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7004 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7005
7006 * xfns.c (Fx_window_property): Simplify a bit,
7007 to make a bit faster and to avoid GCC 4.6.0 warning.
7008 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7009
7010 * fns.c (internal_equal): Don't assume size_t fits in int.
7011
7012 * alloc.c (compact_small_strings): Tighten assertion a little.
7013
7014 Replace pEd with more-general pI, and fix some printf arg casts.
7015 * lisp.h (pI): New macro, generalizing old pEd macro to other
7016 conversion specifiers. For example, use "...%"pI"d..." rather
7017 than "...%"pEd"...".
7018 (pEd): Remove. All uses replaced with similar uses of pI.
7019 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7020 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7021 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7022 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7023 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7024 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7025 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7026 64-bit hosts.
7027 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7028 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7029 * print.c (safe_debug_print, print_object): Likewise.
7030 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7031 to int.
7032 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7033 avoiding the 0 flag, which is not portable.
7034 * process.c (Fmake_network_process): Use pI to avoid cast.
7035 * region-cache.c (pp_cache): Likewise.
7036 * xdisp.c (decode_mode_spec): Likewise.
7037 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7038 behavior on 64-bit hosts with printf arg.
7039 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7040 (x_stop_queuing_selection_requests): Likewise.
7041 (x_get_window_property): Don't truncate byte count to an 'int'
7042 when tracing.
7043
7044 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7045 here, since it parses constructs like leading '-' and spaces,
7046 which are not wanted; and it overflows with large numbers.
7047 Instead, simply match F[0-9]+, which is what is wanted anyway.
7048
7049 * alloc.c: Remove unportable assumptions about struct layout.
7050 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7051 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7052 (allocate_vectorlike, make_pure_vector): Use the new macros,
7053 plus offsetof, to remove unportable assumptions about struct layout.
7054 These assumptions hold on all porting targets that I know of, but
7055 they are not guaranteed, they're easy to remove, and removing them
7056 makes further changes easier.
7057
7058 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7059 This doesn't fix a bug but makes the code clearer.
7060 (string_overrun_cookie): Now const. Use initializers that
7061 don't formally overflow signed char, to avoid warnings.
7062 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7063 can cause Emacs to crash when string overrun checking is enabled.
7064 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7065 multiple of sizeof (EMACS_INT); it need not be, if
7066 alignof(EMACS_INT) < sizeof (EMACS_INT).
7067 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7068
7069 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7070
7071 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7072
7073 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7074
7075 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7076 supposed to be handshaking. (Bug#8556)
7077 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7078
7079 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7080
7081 * lisp.h (Qdebug): List symbol.
7082 * eval.c (Qdebug): Restore global linkage.
7083 * keyboard.c (debug-on-event): New variable.
7084 (handle_user_signal): Break into debugger when debug-on-event
7085 matches the current signal symbol.
7086
7087 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7088
7089 * alloc.c (check_sblock, check_string_bytes)
7090 (check_string_free_list): Convert to standard C.
7091
7092 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7093
7094 * w32.c (emacs_gnutls_push): Fix typo.
7095
7096 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7097
7098 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7099 "cast to pointer from integer of different size".
7100
7101 Improve doprnt and its use in verror. (Bug#8545)
7102 * doprnt.c (doprnt): Document the set of format control sequences
7103 supported by the function. Use SAFE_ALLOCA instead of always
7104 using `alloca'.
7105
7106 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7107 is one byte too soon. Don't use xrealloc; instead xfree and
7108 xmalloc anew.
7109
7110 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7111
7112 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7113 callbacks stage.
7114
7115 * gnutls.c: Renamed global_initialized to
7116 gnutls_global_initialized. Added internals for the
7117 :verify-hostname-error, :verify-error, and :verify-flags
7118 parameters of `gnutls-boot' and documented those parameters in the
7119 docstring. Start callback support.
7120 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7121 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7122 on error. Return error code.
7123 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7124 (emacs_gnutls_read): Likewise.
7125 (Fgnutls_boot): Return handshake error code.
7126 (emacs_gnutls_handle_error): New function.
7127 (wsaerror_to_errno): Likewise.
7128
7129 * w32.h (emacs_gnutls_pull): Add prototype.
7130 (emacs_gnutls_push): Likewise.
7131
7132 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7133 (emacs_gnutls_push): Likewise.
7134
7135 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7136
7137 * process.c (wait_reading_process_output): Check if GnuTLS
7138 buffered some data internally if no FDs are set for TLS
7139 connections.
7140
7141 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7142 (LIBS): Link to USER_LIBS.
7143 ($(BLD)/gnutls.$(0)): New target.
7144
7145 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7146
7147 * xdisp.c (handle_single_display_spec): Rename the
7148 display_replaced_before_p argument into display_replaced_p, to
7149 make it consistent with the commentary. Fix typos in the
7150 commentary.
7151
7152 * textprop.c (syms_of_textprop): Remove dead code.
7153 (copy_text_properties): Delete obsolete commentary about an
7154 interface that was deleted long ago. Fix typos in the description
7155 of arguments.
7156
7157 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7158 to changes in oldXMenu/XMenu.h from 2011-04-16.
7159 <menu_help_message, prev_menu_help_message>: Constify.
7160 (IT_menu_make_room): menu->help_text is now `const char **';
7161 adjust.
7162
7163 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7164 to changes in oldXMenu/XMenu.h from 2011-04-16.
7165 (struct XMenu): Declare `help_text' `const char **'.
7166
7167 * xfaces.c <Qunspecified>: Make extern again.
7168
7169 * syntax.c: Include sys/types.h before including regex.h, as
7170 required by Posix.
7171
7172 * doc.c (get_doc_string): Improve the format passed to `error'.
7173
7174 * doprnt.c (doprnt): Improve commentary.
7175
7176 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7177
7178 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7179 them with etags.
7180
7181 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7182 changes in globals.h immediately force recompilation.
7183 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7184 $(CURDIR)/s/ms-w32.h.
7185 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7186
7187 * character.c (Fchar_direction): Function deleted.
7188 (syms_of_character): Don't defsubr it.
7189 <char-direction-table>: Deleted.
7190
7191 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7192
7193 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7194 * doprnt.c: Include limits.h.
7195 (SIZE_MAX): New macro.
7196 (doprnt): Return a size_t value. 2nd arg is now size_t.
7197 Many local variables are now size_t instead of int or unsigned.
7198 Improve overflow protection. Support `l' modifier for integer
7199 conversions. Support %l conversion. Don't assume an EMACS_INT
7200 argument for integer conversions and for %c.
7201
7202 * lisp.h (doprnt): Restore prototype.
7203
7204 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7205 $(SRC)/character.h.
7206
7207 * Makefile.in (base_obj): Add back doprnt.o.
7208
7209 * deps.mk (doprnt.o): Add back prerequisites.
7210 (callint.o): Depend on character.h.
7211
7212 * eval.c (internal_lisp_condition_case): Include the handler
7213 representation in the error message.
7214 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7215 when breaking from the loop.
7216
7217 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7218
7219 * callint.c (Fcall_interactively): When displaying error message
7220 about invalid control letter, pass the character's codepoint, not
7221 a pointer to its multibyte form. Improve display of the character
7222 in octal and display also its hex code.
7223
7224 * character.c (char_string): Use %x to display the (unsigned)
7225 codepoint of an invalid character, to avoid displaying a bogus
7226 negative value.
7227
7228 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7229 `error', not SYMBOL_NAME itself.
7230
7231 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7232 character arguments to `error'.
7233
7234 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7235 to `error' in error message about FINAL_CHAR argument. Make sure
7236 FINAL_CHAR is a character, and use %c when it is passed as
7237 argument to `error'.
7238
7239 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7240
7241 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7242
7243 * w32.c: Include <time.h>.
7244 (sys_localtime): New function.
7245
7246 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7247
7248 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7249
7250 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7251
7252 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7253
7254 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7255 zombies (Bug#8467).
7256
7257 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7258
7259 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7260 gl_state.e_property when gl_state.object is Qt.
7261
7262 * insdel.c (make_gap_larger): Remove limitation of buffer size
7263 to <= INT_MAX.
7264
7265 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7266
7267 * xdisp.c (lookup_glyphless_char_display)
7268 (produce_glyphless_glyph): Handle cons cell entry in
7269 glyphless-char-display.
7270 (Vglyphless_char_display): Document it.
7271
7272 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7273 glyphless-char-display.
7274
7275 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7276
7277 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7278
7279 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7280
7281 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7282 definition for no-X builds.
7283
7284 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7285
7286 Static checks with GCC 4.6.0 and non-default toolkits.
7287
7288 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7289
7290 * process.c (keyboard_bit_set): Define only if SIGIO.
7291 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7292 (send_process): Repair possible setjmp clobbering.
7293
7294 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7295
7296 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7297
7298 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7299
7300 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7301 Define only if needed.
7302
7303 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7304 by pacifying GCC about it. Maybe it's time to retire it?
7305 * xfaces.c (USG, __TIMEVAL__): Likewise.
7306
7307 * dispextern.h (struct redisplay_interface): Rename param
7308 to avoid shadowing.
7309 * termhooks.h (struct terminal): Likewise.
7310 * xterm.c (xembed_send_message): Likewise.
7311
7312 * insdel.c (make_gap_smaller): Define only if
7313 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7314
7315 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7316 it.
7317
7318 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7319 so that we aren't warned about unused symbols.
7320
7321 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7322
7323 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7324
7325 * xfns.c (x_real_positions): Mark locals as initialized.
7326
7327 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7328
7329 * xterm.c: Fix problems found by static analysis with other toolkits.
7330 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7331 (x_dispatch_event): Declare static if USE_GTK, and
7332 define if USE_GTK || USE_X_TOOLKIT.
7333 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7334 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7335 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7336 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7337
7338 * xmenu.c (menu_help_callback): Pointer type fixes.
7339 Use const pointers when pointing at readonly data. Avoid pointer
7340 signedness clashes.
7341 (FALSE): Remove unused macro.
7342 (update_frame_menubar): Remove unused decl.
7343
7344 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7345
7346 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7347 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7348 (single_menu_item): Rename local to avoid shadowing.
7349
7350 * keyboard.c (make_lispy_event): Remove unused local var.
7351
7352 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7353 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7354
7355 * bitmaps: Change bitmaps from unsigned char back to the X11
7356 compatible char. Avoid the old compiler warnings about
7357 out-of-range initializers by using, for example, '\xab' rather
7358 than 0xab.
7359
7360 * xgselect.c (xgselect_initialize): Check vs interface
7361 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7362
7363 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7364
7365 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7366 to read-only memory.
7367
7368 * fns.c (vector): Remove; this old hack is no longer needed.
7369
7370 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7371 Remove unused var.
7372 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7373
7374 * xrdb.c (x_load_resources): Omit unused local.
7375
7376 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7377 (x_window): Rename locals to avoid shadowing.
7378 (USG): Use the kludged USG macro, to pacify gcc.
7379
7380 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7381 (x_term_init): Remove local to avoid shadowing.
7382
7383 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7384
7385 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7386 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7387
7388 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7389
7390 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7391
7392 Fix regex.c, syntax.c and friends for buffers > 2GB.
7393 * syntax.h (struct gl_state_s): Declare character position members
7394 EMACS_INT.
7395
7396 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7397
7398 * textprop.c (verify_interval_modification, interval_of):
7399 Declare arguments EMACS_INT.
7400
7401 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7402 EMACS_INT.
7403
7404 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7405
7406 * indent.c (Fvertical_motion): Local variable it_start is now
7407 EMACS_INT.
7408
7409 * regex.c (re_match, re_match_2, re_match_2_internal)
7410 (bcmp_translate, regcomp, regexec, print_double_string)
7411 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7412 (re_compile_pattern, re_exec): Declare arguments and local
7413 variables `size_t' and `ssize_t' and return values `regoff_t', as
7414 appropriate.
7415 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7416 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7417 <compile_stack_type>: `size' and `avail' are now `size_t'.
7418
7419 * regex.h <regoff_t>: Use ssize_t, not int.
7420 (re_search, re_search_2, re_match, re_match_2): Arguments that
7421 specify buffer/string position and length are now ssize_t and
7422 size_t. Return type is regoff_t.
7423
7424 2011-04-16 Ben Key <bkey76@gmail.com>
7425
7426 * nsfont.m: Fixed bugs in ns_get_family and
7427 ns_descriptor_to_entity that were caused by using free to
7428 deallocate memory blocks that were allocated by xmalloc (via
7429 xstrdup). This caused Emacs to crash when compiled with
7430 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7431 --enable-checking=xmallocoverrun). xfree is now used to
7432 deallocate these memory blocks.
7433
7434 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7435
7436 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7437
7438 emacs_write: Accept and return EMACS_INT for sizes.
7439 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7440 et seq.
7441 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7442 Accept and return EMACS_INT.
7443 (emacs_gnutls_write): Return the number of bytes written on
7444 partial writes.
7445 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7446 (emacs_read, emacs_write): Remove check for negative size, as the
7447 Emacs source code has been audited now.
7448 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7449 (emacs_read, emacs_write): Use it.
7450 * process.c (send_process): Adjust to the new signatures of
7451 emacs_write and emacs_gnutls_write. Do not attempt to store
7452 a byte offset into an 'int'; it might overflow.
7453 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7454
7455 * sound.c: Don't assume sizes fit in 'int'.
7456 (struct sound_device.period_size, alsa_period_size):
7457 Return EMACS_INT, not int.
7458 (struct sound_device.write, vox_write, alsa_write):
7459 Accept EMACS_INT, not int.
7460 (wav_play, au_play): Use EMACS_INT to store sizes and to
7461 record read return values.
7462
7463 2011-04-15 Ben Key <bkey76@gmail.com>
7464
7465 * keyboard.c (Qundefined): Don't declare static since it is used
7466 in nsfns.m.
7467 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7468 static since they are used in nsfont.m.
7469
7470 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7471
7472 * process.c (Qprocessp): Don't declare static.
7473 * lisp.h (Qprocessp): Declare again.
7474
7475 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7476
7477 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7478
7479 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7480
7481 Improve C-level modularity by making more things 'static'.
7482
7483 Don't publish debugger-only interfaces to other modules.
7484 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7485 (verify_bytepos, count_markers): Move decls to the only modules
7486 that need them.
7487 * region-cache.h (pp_cache): Likewise.
7488 * window.h (check_all_windows): Likewise.
7489 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7490
7491 * sysdep.c (croak): Now static, if
7492 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7493 * syssignal.h (croak): Declare only if not static.
7494
7495 * alloc.c (refill_memory_reserve): Now static if
7496 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7497 * lisp.h (refill_memory_reserve): Declare only if not static.
7498
7499 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7500 Define only if USE_LUCID.
7501
7502 * xrdb.c (x_customization_string, x_rm_string): Now static.
7503
7504 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7505 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7506
7507 * xdisp.c (draw_row_with_mouse_face): Now static.
7508 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7509
7510 * window.h (check_all_windows): Mark externally visible.
7511
7512 * window.c (window_deletion_count): Now static.
7513
7514 * undo.c: Make symbols static if they're not exported.
7515 (last_undo_buffer, last_boundary_position, pending_boundary):
7516 Now static.
7517
7518 * textprop.c (interval_insert_behind_hooks): Now static.
7519 (interval_insert_in_front_hooks): Likewise.
7520
7521 * term.c: Make symbols static if they're not exported.
7522 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7523 (max_frame_lines, tty_set_terminal_modes):
7524 (tty_reset_terminal_modes, tty_turn_off_highlight):
7525 (get_tty_terminal): Now static.
7526 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7527 * termhooks.h (term_mouse_moveto): Do not declare if
7528 HAVE_WINDOW_SYSTEM.
7529 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7530 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7531
7532 * sysdep.c: Make symbols static if they're not exported.
7533 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7534 Now static.
7535 (sigprocmask_set, full_mask): Remove; unused.
7536 (wait_debugging): Mark as visible.
7537 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7538 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7539
7540 * syntax.c (syntax_temp): Define only if !__GNUC__.
7541
7542 * sound.c (current_sound_device, current_sound): Now static.
7543
7544 * search.c (searchbufs, searchbuf_head): Now static.
7545
7546 * scroll.c (scroll_cost): Remove; unused.
7547 * dispextern.h (scroll_cost): Remove decl.
7548
7549 * region-cache.h (pp_cache): Mark as externally visible.
7550
7551 * process.c: Make symbols static if they're not exported.
7552 (process_tick, update_tick, create_process, chan_process):
7553 (Vprocess_alist, proc_buffered_char, datagram_access):
7554 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7555 (deactivate_process): Mark defn as static, as well as decl.
7556 * lisp.h (create_process): Remove decl.
7557 * process.h (chan_process, Vprocess_alist): Remove decls.
7558
7559 * print.c: Make symbols static if they're not exported.
7560 (print_depth, new_backquote_output, being_printed, print_buffer):
7561 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7562 (print_interval, print_number_index, initial_stderr_stream):
7563 Now static.
7564 * lisp.h (Fprinc): Remove decl.
7565 (debug_output_compilation_hack): Mark as externally visible.
7566
7567 * sysdep.c (croak): Move decl from here to syssignal.h.
7568 * syssignal.h (croak): Put it here, so the API can be checked when
7569 'croak' is called from dissociate_if_controlling_tty.
7570
7571 * minibuf.c: Make symbols static if they're not exported.
7572 (minibuf_save_list, choose_minibuf_frame): Now static.
7573 * lisp.h (choose_minibuf_frame): Remove decl.
7574
7575 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7576
7577 * lread.c: Make symbols static if they're not exported.
7578 (read_objects, initial_obarray, oblookup_last_bucket_number):
7579 Now static.
7580 (make_symbol): Remove; unused.
7581 * lisp.h (initial_obarray, make_symbol): Remove decls.
7582
7583 * keyboard.c: Make symbols static if they're not exported.
7584 (single_kboard, recent_keys_index, total_keys, recent_keys):
7585 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7586 (this_single_command_key_start, echoing, last_auto_save):
7587 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7588 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7589 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7590 (Vlispy_mouse_stem, double_click_count):
7591 Now static.
7592 (force_auto_save_soon): Define only if SIGDANGER.
7593 (ignore_mouse_drag_p): Now static if
7594 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7595 (print_help): Remove; unused.
7596 (stop_character, last_timer_event): Mark as externally visible.
7597 * keyboard.h (ignore_mouse_drag_p): Declare only if
7598 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7599 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7600 * lisp.h (echoing): Remove decl.
7601 (force_auto_save_soon): Declare only if SIGDANGER.
7602 * xdisp.c (redisplay_window): Simplify code, to make it more
7603 obvious that ignore_mouse_drag_p is not accessed if !defined
7604 USE_GTK && !defined HAVE_NS.
7605
7606 * intervals.c: Make symbols static if they're not exported.
7607 (merge_properties_sticky, merge_interval_right, delete_interval):
7608 Now static.
7609 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7610
7611 * insdel.c: Make symbols static if they're not exported.
7612 However, leave prepare_to_modify_buffer alone. It's never
7613 called from outside this function, but that appears to be a bug.
7614 (combine_after_change_list, combine_after_change_buffer):
7615 (adjust_after_replace, signal_before_change): Now static.
7616 (adjust_after_replace_noundo): Remove; unused.
7617 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7618 (signal_before_change): Remove decls.
7619
7620 * indent.c (val_compute_motion, val_vmotion): Now static.
7621
7622 * image.c: Make symbols static if they're not exported.
7623 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7624 if USE_GTK.
7625 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7626 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7627
7628 * fringe.c (standard_bitmaps): Now static.
7629 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7630
7631 * frame.c: Make symbols static if they're not exported.
7632 (x_report_frame_params, make_terminal_frame): Now static.
7633 (get_frame_param): Now static, unless HAVE_NS.
7634 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7635 (x_get_resource_string): Remove; not used.
7636 * frame.h (make_terminal_frame, x_report_frame_params):
7637 (x_get_resource_string); Remove decls.
7638 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7639 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7640
7641 * font.c, fontset.c: Make symbols static if they're not exported.
7642 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7643 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7644 * font.c (font_close_object): Now static.
7645 * font.h (font_close_object): Remove.
7646 * fontset.c (FONTSET_OBJLIST): Remove.
7647 (free_realized_fontset) #if-0 the body, which does nothing.
7648 (face_suitable_for_char_p): #if-0, as it's never called.
7649 * fontset.h (face_suitable_for_char_p): Remove decl.
7650 * xfaces.c (face_at_string_position):
7651 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7652 since 0 is always ASCII.
7653
7654 * fns.c (weak_hash_tables): Now static.
7655
7656 * fileio.c: Make symbols static if they're not exported.
7657 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7658 (Vwrite_region_annotation_buffers): Now static.
7659
7660 * eval.c: Make symbols static if they're not exported.
7661 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7662 * lisp.h (backtrace_list): Remove decl.
7663
7664 * emacs.c: Make symbols static if they're not exported.
7665 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7666 (fatal_error_code, fatal_error_signal_hook, standard_args):
7667 Now static.
7668 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7669 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7670 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7671 * lisp.h (fatal_error_signal_hook): Remove decl.
7672 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7673
7674 * editfns.c: Move a (normally-unused) function to its only use.
7675 * editfns.c, lisp.h (get_operating_system_release): Remove.
7676 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7677 worth the hassle of breaking this out.
7678
7679 * xterm.c: Make symbols static if they're not exported.
7680 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7681 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7682 (x_destroy_window, x_delete_display):
7683 Now static.
7684 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7685 (x_mouse_leave): Remove; unused.
7686 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7687 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7688 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7689 Remove decls.
7690 (x_mouse_leave): Declare only if WINDOWSNT.
7691 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7692 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7693 USE_X_TOOLKIT.
7694
7695 * ftxfont.c: Make symbols static if they're not exported.
7696 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7697 HAVE_FREETYPE.
7698 * font.h (ftxfont_driver): Likewise.
7699
7700 * xfns.c: Make symbols static if they're not exported.
7701 (x_last_font_name, x_display_info_for_name):
7702 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7703 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7704 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7705 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7706 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7707 (last_show_tip_args): Now static.
7708 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7709 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7710 (x_screen_planes): Remove; unused.
7711 * dispextern.h (x_screen_planes): Remove decl.
7712
7713 * dispnew.c: Make symbols static if they're not exported.
7714 * dispextern.h (redraw_garbaged_frames, scrolling):
7715 (increment_row_positions): Remove.
7716 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7717 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7718 Now static.
7719 (redraw_garbaged_frames): Remove; unused.
7720
7721 * xfaces.c: Make symbols static if they're not exported.
7722 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7723 Remove decls.
7724 * xterm.h (defined_color): Remove decls.
7725 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7726 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7727 (menu_face_changed_default, defined_color, free_realized_face):
7728 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7729 (ascii_face_of_lisp_face): Remove; unused.
7730
7731 * xdisp.c: Make symbols static if they're not exported.
7732 * dispextern.h (scratch_glyph_row, window_box_edges):
7733 (glyph_to_pixel_coords, set_cursor_from_row):
7734 (get_next_display_element, set_iterator_to_next):
7735 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7736 (show_mouse_face): Remove decls
7737 * frame.h (message_buf_print): Likewise.
7738 * lisp.h (pop_message, set_message, check_point_in_composition):
7739 Likewise.
7740 * xterm.h (set_vertical_scroll_bar): Likewise.
7741 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7742 (message_buf_print, scratch_glyph_row, displayed_buffer):
7743 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7744 (get_next_display_element, show_mouse_face, window_box_edges):
7745 (frame_to_window_pixel_xy, check_point_in_composition):
7746 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7747 (glyph_to_pixel_coords): Remove; unused.
7748
7749 * dired.c (file_name_completion): Now static.
7750
7751 * dbusbind.c (xd_in_read_queued_messages): Now static.
7752
7753 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7754 * data.c (circular_list_error): Remove.
7755
7756 * commands.h (last_point_position, last_point_position_buffer):
7757 (last_point_position_window): Remove decls.
7758 * keyboard.c: Make these variables static.
7759
7760 * coding.h (coding, code_convert_region, encode_coding_gap):
7761 Remove decls.
7762 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7763 (iso_code_class, detect_coding, code_convert_region): Now static.
7764 (encode_coding_gap): Remove; unused.
7765
7766 * chartab.c (chartab_chars, chartab_bits): Now static.
7767
7768 * charset.h (charset_iso_8859_1): Remove decl.
7769 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7770 Now static.
7771
7772 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7773 * ccl.c (Vccl_program_table): Now static.
7774 (check_ccl_update): Remove; unused.
7775
7776 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7777 * category.h: ... from here.
7778 * category.c (check_category_table, set_category_set): Now static.
7779
7780 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7781 * lisp.h: Remove these decls.
7782
7783 * buffer.c (buffer_count): Remove unused var.
7784
7785 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7786 so that it's not optimized away.
7787 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7788 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7789 exported only to the debugger.
7790
7791 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7792 * atimer.h (run_all_atimers): Remove; not exported.
7793
7794 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7795 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7796 was inaccessible from Lisp.
7797 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7798 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7799
7800 alloc.c: Import and export fewer symbols, and remove unused items.
7801 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7802 is defined.
7803 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7804 it's not optimized away by whole-program optimization.
7805 (message_enable_multibyte, free_misc): Remove.
7806 (catchlist, handlerlist, mark_backtrace):
7807 Declare only if BYTE_MARK_STACK.
7808 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7809 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7810 (message_enable_multibyte): Remove decl.
7811 (free_misc, interval_free_list, float_block, float_block_index):
7812 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7813 (cons_free_list, last_marked_index):
7814 Now static.
7815 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7816 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7817 (mark_backtrace): Define only if BYTE_MARK_STACK.
7818 * xdisp.c (message_enable_multibyte): Now static.
7819
7820 Declare Lisp_Object Q* variables to be 'static' if not exported.
7821 This makes it easier for human readers (and static analyzers)
7822 to see whether these variables are used from other modules.
7823 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7824 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7825 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7826 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7827 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7828 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7829 * xmenu.c, xselect.c:
7830 Declare Q* vars static if they are not used in other modules.
7831 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7832 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7833 Remove decls of unexported vars.
7834 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7835
7836 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7837
7838 Make Emacs functions such as Fatom 'static' by default.
7839 This makes it easier for human readers (and static analyzers)
7840 to see whether these functions can be called from other modules.
7841 DEFUN now defines a static function. To make the function external
7842 so that it can be used in other C modules, use the new macro DEFUE.
7843 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7844 (Finit_image_library):
7845 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7846 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7847 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7848 Remove decls, since these functions are now static.
7849 (Funintern, Fget_internal_run_time): New decls, since these functions
7850 were already external.
7851
7852 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7853 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7854 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7855 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7856 * keyboard.c, keymap.c, lread.c:
7857 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7858 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7859 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7860 Mark functions with DEFUE instead of DEFUN,
7861 if they are used in other modules.
7862 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7863 decls for now-static functions.
7864 * buffer.h (Fdelete_overlay): Remove decl.
7865 * callproc.c (Fgetenv_internal): Mark as internal.
7866 * composite.c (Fremove_list_of_text_properties): Remove decl.
7867 (Fcomposition_get_gstring): New forward static decl.
7868 * composite.h (Fcomposite_get_gstring): Remove decl.
7869 * dired.c (Ffile_attributes): New forward static decl.
7870 * doc.c (Fdocumntation_property): New forward static decl.
7871 * eval.c (Ffetch_bytecode): New forward static decl.
7872 (Funintern): Remove extern decl; now in .h file where it belongs.
7873 * fileio.c (Fmake_symbolic_link): New forward static decl.
7874 * image.c (Finit_image_library): New forward static decl.
7875 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7876 * intervals.h (Fprevious_property_change):
7877 (Fremove_list_of_text_properties): Remove decls.
7878 * keyboard.c (Fthis_command_keys): Remove decl.
7879 (Fcommand_execute): New forward static decl.
7880 * keymap.c (Flookup_key): New forward static decl.
7881 (Fcopy_keymap): Now static.
7882 * keymap.h (Flookup_key): Remove decl.
7883 * process.c (Fget_process): New forward static decl.
7884 (Fprocess_datagram_address): Mark as internal.
7885 * syntax.c (Fsyntax_table_p): New forward static decl.
7886 (skip_chars): Remove duplicate decl.
7887 * textprop.c (Fprevious_property_change): New forward static decl.
7888 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7889 Now internal.
7890 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7891 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7892
7893 * editfns.c (Fformat): Remove unreachable code.
7894
7895 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7896
7897 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7898 change. (Bug#8496)
7899
7900 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7901
7902 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7903 when at ZV. (Bug#8487)
7904
7905 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7906
7907 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7908 (Bug#8437)
7909 * keyboard.c (parse_tool_bar_item): Likewise.
7910 * sound.c (sound_cleanup, alsa_close): Likewise.
7911 * termcap.c (tgetent): Likewise.
7912 * xfns.c (x_default_font_parameter): Likewise.
7913 * xsettings.c (read_and_apply_settings): Likewise.
7914
7915 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7916 (overrun_check_free): Protoize.
7917
7918 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7919
7920 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7921 since callers should never pass a negative size.
7922 Change the signature to match that of plain 'read' and 'write'; see
7923 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7924 * lisp.h: Update prototypes of emacs_write and emacs_read.
7925
7926 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7927
7928 * xdisp.c (redisplay_window): Don't try to determine the character
7929 position of the scroll margin if the window start point w->startp
7930 is outside the buffer's accessible region. (Bug#8468)
7931
7932 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7933
7934 Fix write-region and its subroutines for buffers > 2GB.
7935 * fileio.c (a_write, e_write): Modify declaration of arguments and
7936 local variables to support buffers larger than 2GB.
7937 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7938
7939 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7940 argument, local variables, and return value.
7941
7942 * lisp.h: Update prototypes of emacs_write and emacs_read.
7943
7944 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7945
7946 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7947
7948 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7949
7950 Fix more problems found by GCC 4.6.0's static checks.
7951
7952 * xdisp.c (vmessage): Use a better test for character truncation.
7953
7954 * charset.c (load_charset_map): <, not <=, for optimization,
7955 and to avoid potential problems with integer overflow.
7956 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7957 * casetab.c (set_identity, shuffle): Likewise.
7958 * editfns.c (Fformat): Likewise.
7959 * syntax.c (skip_chars): Likewise.
7960
7961 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7962 This also lets GCC 4.6.0 generate slightly better loop code.
7963
7964 * callint.c (Fcall_interactively): <, not <=, for optimization.
7965 (Fcall_interactively): Count the number of arguments produced,
7966 not the number of arguments given. This is simpler and lets GCC
7967 4.6.0 generate slightly better code.
7968
7969 * ftfont.c: Distingish more carefully between FcChar8 and char.
7970 The previous code passed unsigned char * to a functions like
7971 strlen and xstrcasecmp that expect char *, which does not
7972 conform to the C standard.
7973 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7974 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7975 char * when the C standard requires it.
7976
7977 * keyboard.c (read_char): Remove unused var.
7978
7979 * eval.c: Port to Windows vsnprintf (Bug#8435).
7980 Include <limits.h>.
7981 (SIZE_MAX): Define if the headers do not.
7982 (verror): Do not give up if vsnprintf returns a negative count.
7983 Instead, grow the buffer. This ports to Windows vsnprintf, which
7984 does not conform to C99. Problem reported by Eli Zaretskii.
7985 Also, simplify the allocation scheme, by avoiding the need for
7986 calling realloc, and removing the ALLOCATED variable.
7987
7988 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7989
7990 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7991 But keep the doprint source code for now, as we might revamp it
7992 and use it again (Bug#8435).
7993 * lisp.h (doprnt): Remove.
7994 * Makefile.in (base_obj): Remove doprnt.o.
7995 * deps.mk (doprnt.o): Remove.
7996
7997 error: Print 32- and 64-bit integers portably (Bug#8435).
7998 Without this change, on typical 64-bit hosts error ("...%d...", N)
7999 was used to print both 32- and 64-bit integers N, which relied on
8000 undefined behavior.
8001 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8002 * lisp.h (error, verror): Mark as printf-like functions.
8003 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8004 Report overflow in size calculations when allocating printf buffer.
8005 Do not truncate output string at its first null byte.
8006 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8007 Truncate the output at a character boundary, since vsnprintf does not
8008 do that.
8009 * charset.c (check_iso_charset_parameter): Convert internal
8010 character to string before calling 'error', since %c now has the
8011 printf meaning.
8012 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8013 overflow when computing char to be passed to 'error'. Do not
8014 pass Lisp_Object to 'error'; pass the integer instead.
8015 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8016 formatted with plain %d.
8017
8018 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8019
8020 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8021
8022 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8023
8024 * xterm.c (x_catch_errors): Remove duplicate declaration.
8025
8026 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8027
8028 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8029
8030 2011-04-10 Jim Meyering <meyering@redhat.com>
8031
8032 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8033 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8034 return ssize_t not "int", and use size_t as the buffer length.
8035 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8036 * gnutls.h: Update declarations.
8037 * process.c (read_process_output): Use ssize_t, to match.
8038 (send_process): Likewise.
8039
8040 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8041
8042 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8043
8044 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8045
8046 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8047 Use unsigned char, to match FcChar8 type definition.
8048
8049 * xterm.c (handle_one_xevent):
8050 * xmenu.c (create_and_show_popup_menu):
8051 * xselect.c (x_decline_selection_request)
8052 (x_reply_selection_request): Avoid type-punned deref of X events.
8053
8054 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8055
8056 Fix some uses of `int' instead of EMACS_INT.
8057 * search.c (string_match_1, fast_string_match)
8058 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8059 (scan_buffer, find_next_newline_no_quit)
8060 (find_before_next_newline, search_command, Freplace_match)
8061 (Fmatch_data): Make some `int' variables be EMACS_INT.
8062
8063 * xdisp.c (display_count_lines): 3rd argument and return value now
8064 EMACS_INT. All callers changed.
8065 (pint2hrstr): Last argument is now EMACS_INT.
8066
8067 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8068 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8069 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8070 (decode_coding_utf_16, decode_coding_emacs_mule)
8071 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8072 (decode_coding_ccl, decode_coding_charset)
8073 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8074 (decode_coding_iso_2022, decode_coding_emacs_mule)
8075 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8076 <char_offset, last_offset>: Declare EMACS_INT.
8077 (encode_coding_utf_8, encode_coding_utf_16)
8078 (encode_coding_emacs_mule, encode_invocation_designation)
8079 (encode_designation_at_bol, encode_coding_iso_2022)
8080 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8081 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8082 Declare EMACS_INT.
8083 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8084 (encode_invocation_designation): Last argument P_NCHARS is now
8085 EMACS_INT.
8086 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8087 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8088
8089 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8090 All users changed.
8091
8092 * ccl.c (Fccl_execute_on_string): Declare some variables
8093 EMACS_INT.
8094
8095 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8096
8097 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8098
8099 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8100
8101 * process.c (Fformat_network_address): Doc fix.
8102
8103 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8104
8105 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8106
8107 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8108
8109 * keyboard.c (read_char): Call Lisp function help-form-show,
8110 instead of using internal_with_output_to_temp_buffer.
8111 (Qhelp_form_show): New var.
8112 (syms_of_keyboard): Use DEFSYM macro.
8113
8114 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8115
8116 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8117
8118 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8119
8120 * process.c (Flist_processes): Remove to Lisp.
8121 (list_processes_1): Delete.
8122
8123 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8124
8125 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8126
8127 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8128
8129 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8130
8131 Fix more problems found by GCC 4.6.0's static checks.
8132
8133 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8134
8135 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8136
8137 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8138
8139 * xdisp.c (vmessage): Mark as a printf-like function.
8140
8141 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8142
8143 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8144
8145 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8146 printf-like functions.
8147 (tiff_load): Add casts to remove these marks before passing them
8148 to system-supplied API.
8149
8150 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8151
8152 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8153 This avoids several warnings with gcc -Wstrict-overflow.
8154 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8155 directly, rather than having caller test rule sign. This avoids
8156 some unnecessary tests.
8157 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8158 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8159 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8160
8161 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8162 (xfont_open): Avoid unnecessary tests.
8163
8164 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8165
8166 * composite.h, composite.c (composition_gstring_put_cache):
8167 Use EMACS_INT, not int, for length.
8168
8169 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8170 breaking out part of COMPOSITION_DECODE_RULE.
8171 (COMPOSITION_DECODE_RULE): Use it.
8172 * composite.c (get_composition_id): Remove unused local vars,
8173 by using the new macro.
8174
8175 * textprop.c (set_text_properties_1): Change while to do-while,
8176 since the condition is always true at first.
8177
8178 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8179 (interval_deletion_adjustment): Return unsigned value.
8180 All uses changed.
8181
8182 * process.c (list_processes_1, create_pty, read_process_output):
8183 (exec_sentinel): Remove vars that were set but not used.
8184 (create_pty): Remove unnecessary "volatile"s.
8185 (Fnetwork_interface_info): Avoid possibility of int overflow.
8186 (read_process_output): Do adaptive read buffering even if carryover.
8187 (read_process_output): Simplify nbytes computation if buffered.
8188
8189 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8190
8191 * syntax.c (scan_words): Remove var that was set but not used.
8192 (update_syntax_table): Use unsigned instead of int.
8193
8194 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8195 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8196 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8197
8198 * print.c (print_error_message): Avoid int overflow.
8199
8200 * font.c (font_list_entities): Redo for clarity,
8201 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8202
8203 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8204 (font_score): Avoid potential overflow in diff calculation.
8205
8206 * fns.c (substring_both): Remove var that is set but not used.
8207 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8208
8209 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8210
8211 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8212 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8213 can always succeed if overflow has undefined behavior.
8214
8215 * search.c (boyer_moore, wordify): Remove vars set but not used.
8216 (wordify): Omit three unnecessary tests.
8217
8218 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8219 All callers changed. This avoids the need for an unused var.
8220
8221 * casefiddle.c (casify_region): Remove var that is set but not used.
8222
8223 * dired.c (file_name_completion): Remove var that is set but not used.
8224
8225 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8226
8227 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8228 (Finsert_file_contents): Remove unnecessary code checking fd.
8229
8230 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8231 Check for integer overflow on size calculations.
8232
8233 * buffer.c (Fprevious_overlay_change): Remove var that is set
8234 but not used.
8235
8236 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8237 Remove vars that are set but not used.
8238 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8239 (timer_check_2): Mark vars as initialized.
8240
8241 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8242
8243 * image.c (lookup_image): Remove var that is set but not used.
8244 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8245
8246 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8247 that are set but not used.
8248
8249 * xfns.c (make_invisible_cursor): Don't return garbage
8250 if XCreateBitmapFromData fails (Bug#8410).
8251
8252 * xselect.c (x_get_local_selection, x_handle_property_notify):
8253 Remove vars that are set but not used.
8254
8255 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8256 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8257
8258 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8259 Remove var that is set but not used.
8260 (scroll_bar_windows_size): Now size_t, not int.
8261 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8262 Check for overflow.
8263
8264 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8265 (map_tty_color) [!defined MSDOS]: Likewise.
8266
8267 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8268
8269 * coding.c: Remove vars that are set but not used.
8270 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8271 All callers changed.
8272 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8273 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8274 (decode_coding_charset): Remove vars that are set but not used.
8275
8276 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8277 that is set but not used.
8278
8279 * print.c (print_object): Remove var that is set but not used.
8280
8281 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8282 The gnulib version avoids calling malloc in the usual case,
8283 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8284 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8285 * filelock.c (current_lock_owner): Likewise.
8286 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8287 * sysdep.c: Include allocator.h, careadlinkat.h.
8288 (emacs_no_realloc_allocator): New static constant.
8289 (emacs_readlink): New function.
8290 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8291 ../lib/careadlinkat.h.
8292
8293 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8294
8295 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8296 first non-nil return value).
8297
8298 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8299
8300 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8301 if not defined (Bug#8403).
8302
8303 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8304
8305 * xdisp.c (display_count_lines): Remove parameter `start',
8306 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8307 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8308 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8309 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8310 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8311 and thereabouts. All callers changed.
8312 (get_per_char_metric): Remove parameter `f', unused since
8313 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8314
8315 2011-04-02 Jim Meyering <meyering@redhat.com>
8316
8317 do not dereference NULL upon failed strdup
8318 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8319 (ns_get_family): Likewise.
8320
8321 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8322
8323 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8324
8325 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8326
8327 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8328 later (Bug#8403).
8329
8330 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8331
8332 Add lexical binding.
8333
8334 * window.c (Ftemp_output_buffer_show): New fun.
8335 (Fsave_window_excursion):
8336 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8337
8338 * lread.c (lisp_file_lexically_bound_p): New function.
8339 (Fload): Bind Qlexical_binding.
8340 (readevalloop): Remove `evalfun' arg.
8341 Bind Qinternal_interpreter_environment.
8342 (Feval_buffer): Bind Qlexical_binding.
8343 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8344 Mark as dynamic.
8345 (syms_of_lread): Declare `lexical-binding'.
8346
8347 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8348
8349 * keyboard.c (eval_dyn): New fun.
8350 (menu_item_eval_property): Use it.
8351
8352 * image.c (parse_image_spec): Use Ffunctionp.
8353
8354 * fns.c (concat, mapcar1): Accept byte-code-functions.
8355
8356 * eval.c (Fsetq): Handle lexical vars.
8357 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8358 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8359 (FletX, Flet): Obey lexical binding.
8360 (Fcommandp): Handle closures.
8361 (Feval): New `lexical' arg.
8362 (eval_sub): New function extracted from Feval. Use it almost
8363 everywhere where Feval was used. Look up vars in lexical env.
8364 Handle closures.
8365 (Ffunctionp): Move from subr.el.
8366 (Ffuncall): Handle closures.
8367 (apply_lambda): Remove `eval_flags'.
8368 (funcall_lambda): Handle closures and new byte-code-functions.
8369 (Fspecial_variable_p): New function.
8370 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8371 but without exporting it to Lisp.
8372
8373 * doc.c (Fdocumentation, store_function_docstring):
8374 * data.c (Finteractive_form): Handle closures.
8375
8376 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8377 interactive spec.
8378
8379 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8380 New byte-codes.
8381 (exec_byte_code): New function extracted from Fbyte_code to handle new
8382 calling convention for byte-code-functions. Add new byte-codes.
8383
8384 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8385
8386 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8387
8388 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8389
8390 * xdisp.c (redisplay_internal): Fix prototype.
8391
8392 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8393
8394 * xdisp.c (SCROLL_LIMIT): New macro.
8395 (try_scrolling): Use it when setting scroll_limit.
8396 Limit scrolling to 100 screen lines.
8397 (redisplay_window): Even when falling back on "recentering",
8398 position point in the window according to scroll-conservatively,
8399 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8400
8401 (try_scrolling): When point is above the window, allow searching
8402 as far as scroll_max, or one screenful, to compute vertical
8403 distance from PT to the scroll margin position. This prevents
8404 try_scrolling from unnecessarily failing when
8405 scroll-conservatively is set to a value slightly larger than the
8406 window height. Clean up the case of PT below the margin at bottom
8407 of window: scroll_max can no longer be INT_MAX. When aggressive
8408 scrolling is in use, don't let point enter the opposite scroll
8409 margin as result of the scroll.
8410 (syms_of_xdisp) <scroll-conservatively>: Document the
8411 threshold of 100 lines for never-recentering scrolling.
8412
8413 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8414
8415 * dispextern.h (move_it_by_lines):
8416 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8417 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8418 (message_log_check_duplicate): Remove parameters `prev_bol' and
8419 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8420 (redisplay_internal): Remove parameter `preserve_echo_area',
8421 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8422
8423 * indent.c (Fvertical_motion):
8424 * window.c (window_scroll_pixel_based, Frecenter):
8425 Don't pass `need_y_p' to `move_it_by_lines'.
8426
8427 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8428
8429 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8430 steal a few bits to be more compact.
8431 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8432 Remove unneeded casts.
8433
8434 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8435
8436 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8437
8438 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8439 binding" message (bug#7967).
8440
8441 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8442
8443 Fix more problems found by GCC 4.6.0's static checks.
8444
8445 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8446 Remove unused local var.
8447
8448 * editfns.c (Fmessage_box): Remove unused local var.
8449
8450 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8451 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8452 Omit unused local vars.
8453 * window.c (shrink_windows): Omit unused local var.
8454 * menu.c (digest_single_submenu): Omit unused local var.
8455 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8456 Omit unused local var.
8457
8458 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8459 Don't assume string length fits in int.
8460 (keyremap_step, read_key_sequence): Use size_t for sizes.
8461 (read_key_sequence): Don't check last_real_key_start redundantly.
8462
8463 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8464 instead of alloca (Bug#8344).
8465
8466 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8467 (Fbacktrace_frame): Don't assume nframes fits in int.
8468
8469 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8470
8471 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8472 concerns.
8473
8474 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8475
8476 * cm.c (calccost): Turn while-do into do-while, for clarity.
8477
8478 * keyboard.c (syms_of_keyboard): Use the same style as later
8479 in this function when indexing through an array. This also
8480 works around GCC bug 48267.
8481
8482 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8483
8484 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8485
8486 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8487 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8488
8489 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8490 This avoids undefined behavior on integer overflow, and is a bit
8491 more convenient anyway since it is compared to a size_t variable.
8492
8493 Variadic C functions now count arguments with size_t, not int.
8494 This avoids an unnecessary limitation on 64-bit machines, which
8495 caused (substring ...) to crash on large vectors (Bug#8344).
8496 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8497 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8498 All variadic functions and their callers changed accordingly.
8499 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8500 * data.c (arith_driver, float_arith_driver): Likewise.
8501 * editfns.c (general_insert_function): Likewise.
8502 * eval.c (struct backtrace.nargs, interactive_p)
8503 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8504 (funcall_lambda, mark_backtrace): Likewise.
8505 * fns.c (concat): Likewise.
8506 * frame.c (x_set_frame_parameters): Likewise.
8507 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8508 0 if not found, not -1. All callers changed.
8509
8510 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8511 (stack_copy_size): Now size_t, not int.
8512 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8513
8514 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8515
8516 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8517 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8518 All callers changed.
8519
8520 * lisp.h (multibyte_char_to_unibyte):
8521 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8522 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8523 * character.h (CHAR_TO_BYTE8):
8524 * cmds.c (internal_self_insert):
8525 * editfns.c (general_insert_function):
8526 * keymap.c (push_key_description):
8527 * search.c (Freplace_match):
8528 * xdisp.c (message_dolog, set_message_1): All callers changed.
8529
8530 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8531
8532 * keyboard.c (safe_run_hook_funcall): New function.
8533 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8534 don't set the hook to nil, but remove the offending function instead.
8535 (Qcommand_hook_internal): Remove, unused.
8536 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8537 Vcommand_hook_internal.
8538
8539 * eval.c (enum run_hooks_condition): Remove.
8540 (funcall_nil, funcall_not): New functions.
8541 (run_hook_with_args): Call each function through a `funcall' argument.
8542 Remove `cond' argument, now redundant.
8543 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8544 (Frun_hook_with_args_until_failure): Adjust accordingly.
8545 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8546
8547 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8548
8549 * dispextern.h (string_buffer_position): Remove declaration.
8550
8551 * print.c (strout): Remove parameter `multibyte', unused since
8552 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8553
8554 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8555 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8556 All callers changed.
8557
8558 * w32.c (_wsa_errlist): Use braces for struct initializers.
8559
8560 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8561 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8562 All callers changed.
8563 (string_buffer_position): Likewise. Also, make static (it's never
8564 used outside xdisp.c).
8565 (cursor_row_p): Remove parameter `w', unused since
8566 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8567 (decode_mode_spec): Remove parameter `precision', introduced during
8568 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8569 All callers changed.
8570
8571 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8572
8573 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8574
8575 2011-03-27 Anders Lindgren <andlind@gmail.com>
8576
8577 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8578 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8579 (ns_update_auto_hide_menu_bar): New functions.
8580 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8581 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8582 ns_constrain_all_frames.
8583 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8584 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8585
8586 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8587
8588 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8589
8590 2011-03-27 Glenn Morris <rgm@gnu.org>
8591
8592 * syssignal.h: Replace RETSIGTYPE with void.
8593 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8594 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8595 Replace SIGTYPE with void everywhere.
8596 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8597 * s/template.h (SIGTYPE): Remove commented out definition.
8598
8599 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8600
8601 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8602 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8603
8604 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8605
8606 * w32.c (read_unc_volume): Use parameter `henum', instead of
8607 global variable `wget_enum_handle'.
8608
8609 * keymap.c (describe_vector): Remove parameters `indices' and
8610 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8611 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8612
8613 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8614
8615 * keyboard.c (timer_check): Remove parameter `do_it_now',
8616 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8617 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8618 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8619
8620 * keyboard.c (read_char):
8621 * w32menu.c (w32_menu_display_help):
8622 * xmenu.c (show_help_event, menu_help_callback):
8623 Adjust calls to `show_help_echo'.
8624
8625 * gtkutil.c (xg_maybe_add_timer):
8626 * keyboard.c (readable_events):
8627 * process.c (wait_reading_process_output):
8628 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8629
8630 * insdel.c (adjust_markers_gap_motion):
8631 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8632 (gap_left, gap_right): Don't call it.
8633
8634 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8635
8636 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8637 incurred during fontification.
8638
8639 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8640
8641 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8642 (DEFVAR_PER_BUFFER): Don't pass it.
8643
8644 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8645 (scrolling_window): Don't pass it.
8646
8647 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8648
8649 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8650
8651 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8652 and `suffix'.
8653 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8654 of variables specific to SELinux and computation of `encoded_absname'.
8655
8656 * image.c (XPutPixel): Remove unused variable `height'.
8657
8658 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8659
8660 * unexw32.c (get_section_info): Remove unused variable `section'.
8661
8662 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8663 (system_process_attributes): Remove unused variable `sess'.
8664 (sys_read): Remove unused variable `err'.
8665
8666 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8667 (w32_wnd_proc): Remove unused variable `isdead'.
8668 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8669 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8670 (x_create_tip_frame): Remove unused variable `tem'.
8671
8672 * w32inevt.c (w32_console_read_socket):
8673 Remove unused variable `no_events'.
8674
8675 * w32term.c (x_draw_composite_glyph_string_foreground):
8676 Remove unused variable `width'.
8677
8678 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8679
8680 * w32term.c (x_set_glyph_string_clipping):
8681 Don't pass uninitialized region to CombineRgn.
8682
8683 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8684
8685 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8686 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8687 (Fx_close_connection): Remove unused variable `i'.
8688
8689 * w32font.c (w32font_draw): Return number of glyphs.
8690 (w32font_open_internal): Remove unused variable `i'.
8691 (w32font_driver): Add missing initializer.
8692
8693 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8694 (fill_in_menu): Remove unused variable `items_added'.
8695
8696 * w32term.c (last_mouse_press_frame): Remove static global variable.
8697 (w32_clip_to_row): Remove unused variable `f'.
8698 (x_delete_terminal): Remove unused variable `i'.
8699
8700 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8701 (NOTHING): Remove unused static global variable.
8702 (uniscribe_check_otf): Remove unused variable `table'.
8703 (uniscribe_font_driver): Add missing initializers.
8704
8705 2011-03-23 Julien Danjou <julien@danjou.info>
8706
8707 * term.c (Fsuspend_tty, Fresume_tty):
8708 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8709 * window.c (temp_output_buffer_show):
8710 * insdel.c (signal_before_change):
8711 * frame.c (Fhandle_switch_frame):
8712 * fileio.c (Fdo_auto_save):
8713 * emacs.c (Fkill_emacs):
8714 * editfns.c (save_excursion_restore):
8715 * cmds.c (internal_self_insert):
8716 * callint.c (Fcall_interactively):
8717 * buffer.c (Fkill_all_local_variables):
8718 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8719 Use Frun_hooks.
8720 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8721 unconditionally since it does the check itself.
8722
8723 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8724
8725 Fix more problems found by GCC 4.5.2's static checks.
8726
8727 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8728 the first time through the loop, since we know p0 < p1 then.
8729 This also avoids a gcc -Wstrict-overflow warning.
8730
8731 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8732 leading to a memory leak, possible in functions like
8733 load_charset_map_from_file that can allocate an unbounded number
8734 of objects (Bug#8318).
8735
8736 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8737 that could (at least in theory) be that large.
8738
8739 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8740 This is less likely to overflow, and avoids undefined behavior if
8741 overflow does occur. All callers changed. Use strtoul to scan
8742 for the unsigned long integer.
8743 (pint2hrstr): Simplify and tune code slightly.
8744 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8745
8746 * scroll.c (do_scrolling): Work around GCC bug 48228.
8747 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8748
8749 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8750 This also avoids a warning with gcc -Wstrict-overflow.
8751 (validate_x_resource_name): Simplify count usage.
8752 This also avoids a warning with gcc -Wstrict-overflow.
8753
8754 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8755 fail (Bug#8306).
8756
8757 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8758
8759 * process.c (Fmake_network_process): Use socklen_t, not int,
8760 where POSIX says socklen_t is required in portable programs.
8761 This fixes a porting bug on hosts like 64-bit HP-UX, where
8762 socklen_t is wider than int (Bug#8277).
8763 (Fmake_network_process, server_accept_connection):
8764 (wait_reading_process_output, read_process_output):
8765 Likewise.
8766
8767 * process.c: Rename or move locals to avoid shadowing.
8768 (list_processes_1, Fmake_network_process):
8769 (read_process_output_error_handler, exec_sentinel_error_handler):
8770 Rename or move locals.
8771 (Fmake_network_process): Define label "retry_connect" only if needed.
8772 (Fnetwork_interface_info): Fix pointer signedness.
8773 (process_send_signal): Add cast to avoid pointer signedness problem.
8774 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8775 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8776
8777 Make tparam.h and terminfo.c consistent.
8778 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8779 Include tparam.h instead, since it declares them.
8780 * cm.h (PC): Remove extern decl; tparam.h now does this.
8781 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8782 * terminfo.c: Include tparam.h, to check interfaces.
8783 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8784 (tparam): Adjust signature to match interface in tparam.h;
8785 this removes some undefined behavior. Check that outstring and len
8786 are zero, which they always are with Emacs.
8787 * tparam.h (PC, BC, UP): New extern decls.
8788
8789 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8790 (xftfont_open): Rename locals to avoid shadowing.
8791
8792 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8793 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8794 (OTF_TAG_SYM): Omit macro if not needed.
8795 (ftfont_list): Remove unused local.
8796 (get_adstyle_property, ftfont_pattern_entity):
8797 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8798 Rename locals to avoid shadowing.
8799
8800 * xfont.c (xfont_list_family): Mark var as initialized.
8801
8802 * xml.c (make_dom): Now static.
8803
8804 * composite.c (composition_compute_stop_pos): Rename local to
8805 avoid shadowing.
8806 (composition_reseat_it): Remove unused locals.
8807 (find_automatic_composition, composition_adjust_point): Likewise.
8808 (composition_update_it): Mark var as initialized.
8809 (find_automatic_composition): Mark vars as initialized,
8810 with a FIXME (Bug#8290).
8811
8812 character.h: Rename locals to avoid shadowing.
8813 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8814 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8815 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8816 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8817 to avoid shadowing.
8818
8819 * textprop.c (property_change_between_p): Remove; unused.
8820
8821 * intervals.c (interval_start_pos): Now static.
8822
8823 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8824
8825 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8826 Rename locals to avoid shadowing.
8827
8828 * sound.c (wav_play, au_play, Fplay_sound_internal):
8829 Fix pointer signedness.
8830 (alsa_choose_format): Remove unused local var.
8831 (wav_play): Initialize a variable to 0, to prevent undefined
8832 behavior (Bug#8278).
8833
8834 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8835
8836 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8837
8838 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8839 clobbering (Bug#8298).
8840 * sysdep.c (sys_subshell): Likewise.
8841 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8842
8843 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8844 This should get cleaned up, so that child_setup has the
8845 same signature on all platforms.
8846
8847 * callproc.c (call_process_cleanup): Now static.
8848 (relocate_fd): Rename locals to avoid shadowing.
8849
8850 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8851
8852 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8853 not to be necessary, and produces flickering.
8854
8855 2011-03-20 Glenn Morris <rgm@gnu.org>
8856
8857 * config.in: Remove file.
8858
8859 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8860
8861 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8862 are now in src/globals.h.
8863 (syms_of_minibuf): Remove spurious & from previous change.
8864
8865 2011-03-20 Leo Liu <sdl.web@gmail.com>
8866
8867 * minibuf.c (completing-read-function): New variable.
8868 (completing-read-default): Rename from completing-read.
8869 (completing-read): Call completing-read-function.
8870
8871 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8872
8873 * xfaces.c (Fx_load_color_file):
8874 Read color file from absolute filename (bug#8250).
8875
8876 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8877
8878 * makefile.w32-in: Update dependencies.
8879
8880 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8881
8882 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8883
8884 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8885
8886 Fix more problems found by GCC 4.5.2's static checks.
8887
8888 * process.c (make_serial_process_unwind, send_process_trap):
8889 (sigchld_handler): Now static.
8890
8891 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8892 That way, the code declares only the vars that it needs.
8893 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8894 * s/cygwin.h (PTY_ITERATION): Likewise.
8895 * s/darwin.h (PTY_ITERATION): Likewise.
8896 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8897
8898 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8899 * process.c (allocate_pty): Don't declare stb unless it's needed.
8900
8901 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8902 (CONSTANTLIM): Remove; unused.
8903 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8904 Define only if needed.
8905
8906 * unexelf.c (unexec): Name an expression,
8907 to avoid gcc -Wbad-function-cast warning.
8908 Use a different way to cause a compilation error if anyone uses
8909 n rather than nn, a way that does not involve shadowing.
8910 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8911
8912 * deps.mk (unexalpha.o): Remove; unused.
8913
8914 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8915 * unexec.h: New file.
8916 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8917 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8918 Depend on unexec.h.
8919 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8920 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8921 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8922 Change as necessary to match prototype in unexec.h.
8923
8924 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8925 shadowing.
8926 (back_comment, skip_chars): Mark vars as initialized.
8927
8928 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8929 Rename locals to avoid shadowing.
8930
8931 * lread.c (read1): Rewrite so as not to use empty "else".
8932 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8933
8934 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8935
8936 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8937 warning when compiling print.c.
8938
8939 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8940 instead of using an uninitialized var.
8941 (font_sort_entities): Mark var as initialized.
8942
8943 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8944
8945 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8946 pointers to constants.
8947 (font_parse_fcname): Remove unused vars.
8948 (font_delete_unmatched): Now static.
8949 (font_get_spec): Remove; unused.
8950 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8951 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8952 Rename or move locals to avoid shadowing.
8953
8954 * fns.c (require_nesting_list, require_unwind): Now static.
8955 (Ffillarray): Rename locals to avoid shadowing.
8956
8957 * floatfns.c (domain_error2): Define only if needed.
8958 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8959
8960 * alloc.c (mark_backtrace): Move decl from here ...
8961 * lisp.h: ... to here, so that it can be checked.
8962
8963 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8964 (Fdefvar): Rewrite so as not to use empty "else".
8965 (lisp_indirect_variable): Name an expression,
8966 to avoid gcc -Wbad-function-cast warning.
8967 (Fdefvar): Rename locals to avoid shadowing.
8968
8969 * callint.c (quotify_arg, quotify_args): Now static.
8970 (Fcall_interactively): Rename locals to avoid shadowing.
8971 Use const pointer when appropriate.
8972
8973 * lisp.h (get_system_name, get_operating_system_release):
8974 Move decls here, to check interfaces.
8975 * process.c (get_operating_system_release): Move decl to lisp.h.
8976 * xrdb.c (get_system_name): Likewise.
8977 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8978 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8979 some of which prompt warnings from gcc -Wbad-function-cast.
8980 (Fformat_time_string, Fencode_time, Finsert_char):
8981 (Ftranslate_region_internal, Fformat):
8982 Rename or remove local vars to avoid shadowing.
8983 (Ftranslate_region_internal): Mark var as initialized.
8984
8985 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8986 avoid shadowing.
8987
8988 * lisp.h (eassert): Check that the argument compiles, even if
8989 ENABLE_CHECKING is not defined.
8990
8991 * data.c (Findirect_variable): Name an expression, to avoid
8992 gcc -Wbad-function-cast warning.
8993 (default_value, arithcompare, arith_driver, arith_error): Now static.
8994 (store_symval_forwarding): Rename local to avoid shadowing.
8995 (Fmake_variable_buffer_local, Fmake_local_variable):
8996 Mark variables as initialized.
8997 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8998
8999 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9000 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9001 Rename locals to avoid shadowing.
9002 (mark_stack): Move local variables into the #ifdef region where
9003 they're used.
9004 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9005 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9006 needed otherwise.
9007 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9008 (GC_STRING_CHARS): Remove; not used.
9009 (Fmemory_limit): Cast sbrk's returned value to char *.
9010
9011 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9012 avoids undefined behavior in theory.
9013
9014 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9015
9016 Use functions, not macros, for up- and down-casing (Bug#8254).
9017 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9018 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9019 to use the following functions instead of these macros.
9020 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9021 EMACS_INT, since callers assume the returned value fits in int.
9022 (upcase1): Likewise, for UPCASE_TABLE.
9023 (uppercasep, lowercasep, upcase): New static inline functions.
9024 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9025 the race-condition problem in the old DOWNCASE.
9026
9027 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9028 Rename locals to avoid shadowing.
9029 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9030 (regex_compile, re_search_2, re_match_2_internal):
9031 Remove unused local vars.
9032 (FREE_VAR): Rewrite so as not to use empty "else",
9033 which gcc can warn about.
9034 (regex_compile, re_match_2_internal): Mark locals as initialized.
9035 (RETALLOC_IF): Define only if needed.
9036 (WORDCHAR_P): Likewise. This one is never needed, but is used
9037 only in a comment talking about a compiler bug, so put inside
9038 the #if 0 of that comment.
9039 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9040 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9041 Remove; unused.
9042
9043 * search.c (boyer_moore): Rename locals to avoid shadowing.
9044 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9045 (PREV_CHAR_BOUNDARY): Likewise.
9046
9047 * search.c (simple_search): Remove unused var.
9048
9049 * dired.c (compile_pattern): Move decl from here ...
9050 * lisp.h: ... to here, so that it can be checked.
9051 (struct re_registers): New forward decl.
9052
9053 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9054
9055 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9056 All uses changed.
9057 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9058 Rename locals to avoid shadowing.
9059 (Fvertical_motion): Mark locals as initialized.
9060
9061 * casefiddle.c (casify_object, casify_region): Now static.
9062 (casify_region): Mark local as initialized.
9063
9064 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9065
9066 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9067 New macros, so that the caller can use some names other than
9068 gcpro1, gcpro2, etc.
9069 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9070 of the new macros.
9071 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9072 argument, for consistency with GCPRO2_VAR, etc: it is now the
9073 prefix of the variable, not the variable itself. All uses
9074 changed.
9075 * dired.c (directory_files_internal, file_name_completion):
9076 Rename locals to avoid shadowing.
9077
9078 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9079 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9080 dired.c's scmp function, had undefined behavior.
9081 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9082 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9083 * buffer.h: ... to here, because these macros use current_buffer,
9084 and the new implementation with inline functions needs to have
9085 current_buffer in scope now, rather than later when the macros
9086 are used.
9087 (downcase, upcase1): New static inline functions.
9088 (DOWNCASE, UPCASE1): Reimplement using these functions.
9089 This avoids undefined behavior in expressions like
9090 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9091 from race conditions in accessing the global variables
9092 case_temp1 and case_temp2.
9093 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9094 * lisp.h (case_temp1, case_temp2): Remove their decls.
9095 * character.h (ASCII_CHAR_P): Move from here ...
9096 * lisp.h: ... to here, so that the inline functions mentioned
9097 above can use them.
9098
9099 * dired.c (directory_files_internal_unwind): Now static.
9100
9101 * fileio.c (file_name_as_directory, directory_file_name):
9102 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9103 Now static.
9104 (file_name_as_directory): Use const pointers when appropriate.
9105 (Fexpand_file_name): Likewise. In particular, newdir might
9106 point at constant storage, so make it a const pointer.
9107 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9108 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9109 signedness issues.
9110 (Fset_file_times, Finsert_file_contents, auto_save_error):
9111 Rename locals to avoid shadowing.
9112
9113 * minibuf.c (choose_minibuf_frame_1): Now static.
9114 (Ftry_completion, Fall_completions): Rename or remove locals
9115 to avoid shadowing.
9116
9117 * marker.c (bytepos_to_charpos): Remove; unused.
9118
9119 * lisp.h (verify_bytepos, count_markers): New decls,
9120 so that gcc does not warn that these functions aren't declared.
9121
9122 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9123 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9124 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9125 (copy_text): Remove unused local var.
9126
9127 * filelock.c (within_one_second): Now static.
9128 (lock_file_1): Rename local to avoid shadowing.
9129
9130 * buffer.c (fix_overlays_before): Mark locals as initialized.
9131 (fix_start_end_in_overlays): Likewise. This function should be
9132 simplified by using pointers-to-pointers, but that's a different
9133 matter.
9134 (switch_to_buffer_1): Now static.
9135 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9136 (report_overlay_modification): Rename locals to avoid shadowing.
9137
9138 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9139 Fix pointer signedness issue.
9140 (sys_subshell): Mark local as volatile if checking for lint,
9141 to suppress a gcc -Wclobbered warning that does not seem to be right.
9142 (MAXPATHLEN): Define only if needed.
9143
9144 * process.c (serial_open, serial_configure): Move decls from here ...
9145 * systty.h: ... to here, so that they can be checked.
9146
9147 * fns.c (get_random, seed_random): Move extern decls from here ...
9148 * lisp.h: ... to here, so that they can be checked.
9149
9150 * sysdep.c (reset_io): Now static.
9151 (wait_for_termination_signal): Remove; unused.
9152
9153 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9154 (copy_keymap_item, append_key, push_text_char_description):
9155 Now static.
9156 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9157 (DENSE_TABLE_SIZE): Remove; unused.
9158 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9159 (describe_map_tree):
9160 Rename locals to avoid shadowing.
9161
9162 * keyboard.c: Declare functions static if they are not used elsewhere.
9163 (echo_char, echo_dash, cmd_error, top_level_2):
9164 (poll_for_input, handle_async_input): Now static.
9165 (read_char, kbd_buffer_get_event, make_lispy_position):
9166 (make_lispy_event, make_lispy_movement, apply_modifiers):
9167 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9168 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9169 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9170 (read_key_sequence, read_char): Mark locals as initialized.
9171 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9172
9173 * keyboard.h (make_ctrl_char): New decl.
9174 (mark_kboards): Move decl here ...
9175 * alloc.c (mark_kboards): ... from here.
9176
9177 * lisp.h (force_auto_save_soon): New decl.
9178
9179 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9180 (DEFINE_DUMMY_FUNCTION): New macro.
9181 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9182 Use it.
9183 (main): Add casts to avoid warnings
9184 if GCC considers string literals to be constants.
9185
9186 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9187
9188 * dbusbind.c: Pointer signedness fixes.
9189 (xd_signature, xd_append_arg, xd_initialize):
9190 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9191 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9192 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9193 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9194
9195 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9196 if GCC considers string literals to be constants.
9197 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9198
9199 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9200
9201 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9202 (print_preprocess, print_object): New macro to fix last change.
9203
9204 * print.c (print_preprocess): Don't forget font objects.
9205
9206 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9207
9208 * emacs.c (USAGE3): Doc fixes.
9209
9210 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9211
9212 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9213 structure.
9214
9215 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9216
9217 * lisp.h (VWindow_system, Qfile_name_history):
9218 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9219 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9220 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9221
9222 * w32select.c: Don't #include "keyboard.h".
9223 (run_protected): Add extern declaration for waiting_for_input.
9224
9225 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9226 * w32console.c (detect_input_pending, read_input_pending)
9227 (encode_terminal_code):
9228 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9229 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9230 (w32_system_caret_y, Qfile_name_history):
9231 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9232 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9233 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9234 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9235 * w32proc.c (Qlocal, report_file_error):
9236 * w32term.c (Vwindow_system, updating_frame):
9237 * w32uniscribe.c (initialized, uniscribe_font_driver):
9238 Remove unneeded extern declarations.
9239
9240 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9241
9242 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9243
9244 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9245
9246 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9247 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9248 These macros can no longer be used for assignment.
9249
9250 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9251 Assign struct members directly, instead of using BUF_BEGV etc.
9252 (record_buffer_markers, fetch_buffer_markers): New functions for
9253 recording and fetching special buffer markers.
9254 (set_buffer_internal_1, set_buffer_temp): Use them.
9255
9256 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9257
9258 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9259
9260 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9261 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9262
9263 * xdisp.c (hscroll_window_tree):
9264 (reconsider_clip_changes): Use PT instead of BUF_PT.
9265
9266 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9267
9268 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9269 $(EMACS_ROOT)/lib/intprops.h.
9270
9271 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9272
9273 Fix more problems found by GCC 4.5.2's static checks.
9274
9275 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9276 to unsigned char * to avoid compiler diagnostic.
9277 (xg_free_frame_widgets): Make it clear that a local variable is
9278 needed only if USE_GTK_TOOLTIP.
9279 (gdk_window_get_screen): Make it clear that this macro is needed
9280 only if USE_GTK_TOOLTIP.
9281 (int_gtk_range_get_value): New function, which avoids a diagnostic
9282 from gcc -Wbad-function-cast.
9283 (xg_set_toolkit_scroll_bar_thumb): Use it.
9284 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9285 diagnostic from gcc -Wbad-function-cast.
9286 (get_utf8_string, xg_get_file_with_chooser):
9287 Rename locals to avoid shadowing.
9288 (create_dialog): Move locals to avoid shadowing.
9289
9290 * xgselect.c (xg_select): Remove unused var.
9291
9292 * image.c (four_corners_best): Mark locals as initialized.
9293 (gif_load): Initialize transparent_p to zero (Bug#8238).
9294 Mark another local as initialized.
9295 (my_png_error, my_error_exit): Mark with NO_RETURN.
9296
9297 * image.c (clear_image_cache): Now static.
9298 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9299 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9300 (x_edge_detection): Remove unnecessary cast that
9301 gcc -Wbad-function-cast diagnoses.
9302 (gif_load): Fix pointer signedness.
9303 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9304 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9305
9306 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9307
9308 Improve quality of tests for time stamp overflow.
9309 For example, without this patch (encode-time 0 0 0 1 1
9310 1152921504606846976) returns the obviously-bogus value (-948597
9311 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9312 reports time overflow. See
9313 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9314 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9315 * editfns.c: Include limits.h and intprops.h.
9316 (TIME_T_MIN, TIME_T_MAX): New macros.
9317 (time_overflow): Move earlier, to before first use.
9318 (hi_time, lo_time): New functions, for an accurate test for
9319 out-of-range times.
9320 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9321 (Fget_internal_run_time): Don't assume time_t fits in int.
9322 (make_time): Use list2 instead of Fcons twice.
9323 (Fdecode_time): More accurate test for out-of-range times.
9324 (check_tm_member): New function.
9325 (Fencode_time): Use it, to test for out-of-range times.
9326 (lisp_time_argument): Don't rely on undefined left-shift and
9327 right-shift behavior when checking for time stamp overflow.
9328
9329 * editfns.c (time_overflow): New function, refactoring common code.
9330 (Fformat_time_string, Fdecode_time, Fencode_time):
9331 (Fcurrent_time_string): Use it.
9332
9333 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9334 * dired.c (make_time): Move to ...
9335 * editfns.c (make_time): ... here.
9336 * systime.h: Note the move.
9337
9338 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9339
9340 * fringe.c (update_window_fringes): Remove unused variables.
9341
9342 * unexmacosx.c (copy_data_segment): Also copy __got section.
9343 (Bug#8223)
9344
9345 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9346
9347 * termcap.c [MSDOS]: Include "msdos.h".
9348 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9349 Constify `char *' arguments and their references according to
9350 prototypes in tparam.h.
9351
9352 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9353
9354 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9355 Adapt all references accordingly.
9356
9357 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9358
9359 2011-03-11 Tom Tromey <tromey@redhat.com>
9360
9361 * buffer.c (syms_of_buffer): Remove obsolete comment.
9362
9363 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9364
9365 * termhooks.h (encode_terminal_code): Declare prototype.
9366
9367 * msdos.c (encode_terminal_code): Don't declare prototype.
9368
9369 * term.c (encode_terminal_code): Now external again, used by
9370 w32console.c and msdos.c.
9371
9372 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9373 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9374
9375 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9376
9377 Fix some minor problems found by GCC 4.5.2's static checks.
9378
9379 * fringe.c (update_window_fringes): Mark locals as initialized
9380 (Bug#8227).
9381 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9382
9383 * alloc.c (mark_fringe_data): Move decl from here ...
9384 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9385 to check its interface.
9386 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9387
9388 * fontset.c (free_realized_fontset): Now static.
9389 (Fset_fontset_font): Rename local to avoid shadowing.
9390 (fontset_font): Mark local as initialized.
9391 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9392
9393 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9394
9395 * xselect.c (x_disown_buffer_selections): Remove; not used.
9396 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9397 (x_own_selection, Fx_disown_selection_internal): Rename locals
9398 to avoid shadowing.
9399 (x_handle_dnd_message): Remove local to avoid shadowing.
9400
9401 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9402 so that the caller can use some name other than gcpro1.
9403 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9404 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9405 (Fx_backspace_delete_keys_p):
9406 Use them to avoid shadowing, and rename vars to avoid shadowing.
9407 (x_decode_color, x_set_name, x_window): Now static.
9408 (Fx_create_frame): Add braces to silence GCC warning.
9409 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9410 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9411 Remove unused locals.
9412 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9413 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9414 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9415 macros.
9416
9417 * xterm.h (x_mouse_leave): New decl.
9418
9419 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9420 Remove unused functions.
9421 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9422 (x_calc_absolute_position): Now static.
9423 (XTread_socket): Don't define label "out" unless it's used.
9424 Don't declare local "event" unless it's used.
9425 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9426 unless they are used.
9427 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9428 (x_fatal_error_signal): Remove; not used.
9429 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9430 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9431 (x_error_catcher, x_connection_closed, x_error_handler):
9432 (x_error_quitter, xembed_send_message, x_iconify_frame):
9433 (my_log_handler): Rename locals to avoid shadowing.
9434 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9435 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9436
9437 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9438 Rename or move locals to avoid shadowing.
9439 (tty_defined_color, merge_face_heights): Now static.
9440 (free_realized_faces_for_fontset): Remove; not used.
9441 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9442 does not deduce is never used uninitialized.
9443 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9444 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9445
9446 * terminal.c (store_terminal_param): Now static.
9447
9448 * xmenu.c (menu_highlight_callback): Now static.
9449 (set_frame_menubar): Remove unused local.
9450 (xmenu_show): Rename parameter to avoid shadowing.
9451 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9452 since they might point to immutable storage.
9453 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9454 since it's unused otherwise.
9455
9456 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9457 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9458 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9459 avoids a gcc -Wuninitialized diagnostic.
9460 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9461 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9462 does not deduce are never used uninitialized.
9463
9464 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9465
9466 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9467 * window.c (window_loop, size_window):
9468 (run_window_configuration_change_hook, enlarge_window): Likewise.
9469
9470 * window.c (display_buffer): Now static.
9471 (size_window): Mark variables that gcc -Wuninitialized
9472 does not deduce are never used uninitialized.
9473 * window.h (check_all_windows): New decl, to forestall
9474 gcc -Wmissing-prototypes diagnostic.
9475 * dispextern.h (bidi_dump_cached_states): Likewise.
9476
9477 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9478 shadowing.
9479 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9480 Include <limits.h>.
9481 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9482 and to avoid gcc -Wuninitialized warning.
9483 (load_charset_map): Mark variables that gcc -Wuninitialized
9484 does not deduce are never used uninitialized.
9485 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9486
9487 * coding.c (coding_set_source, coding_set_destination):
9488 Use "else { /* comment */ }" rather than "else /* comment */;"
9489 for clarity, and to avoid gcc -Wempty-body warning.
9490 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9491 a block, when the outer 'i' will do.
9492 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9493 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9494 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9495 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9496 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9497 Rename locals to avoid shadowing.
9498 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9499 * coding.c (emacs_mule_char, encode_invocation_designation):
9500 Now static, since they're not used elsewhere.
9501 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9502 (decode_coding_object, encode_coding_object, detect_coding_system):
9503 (decode_coding_emacs_mule): Mark variables that gcc
9504 -Wuninitialized does not deduce are never used uninitialized.
9505 (detect_coding_iso_2022): Initialize a local variable that might
9506 be used uninitialized. Leave a FIXME because it's not clear that
9507 this initialization is needed. (Bug#8211)
9508 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9509 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9510 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9511 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9512 Remove unused macros.
9513
9514 * category.c (hash_get_category_set): Remove unused local var.
9515 (copy_category_table): Now static, since it's not used elsewhere.
9516 * character.c (string_count_byte8): Likewise.
9517
9518 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9519 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9520
9521 * chartab.c (copy_sub_char_table): Now static, since it's not used
9522 elsewhere.
9523 (sub_char_table_ref_and_range, char_table_ref_and_range):
9524 Rename locals to avoid shadowing.
9525 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9526
9527 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9528 (BIDI_BOB): Remove unused macro.
9529
9530 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9531 deduce are never used uninitialized.
9532 * term.c (encode_terminal_code): Likewise.
9533
9534 * term.c (encode_terminal_code): Now static. Remove unused local.
9535
9536 * tparam.h: New file.
9537 * term.c, tparam.h: Include it.
9538 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9539 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9540 Move these decls to tparam.h, and make them agree with what
9541 is actually in tparam.c. The previous trick of using incompatible
9542 decls in different modules does not conform to the C standard.
9543 All callers of tparam changed to use tparam's actual API.
9544 * tparam.c (tparam1, tparam, tgoto):
9545 Use const pointers where appropriate.
9546
9547 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9548 * cm.h (struct cm): Likewise.
9549 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9550 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9551 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9552 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9553 (turn_on_face, init_tty): Likewise.
9554 * termchar.h (struct tty_display_info): Likewise.
9555
9556 * term.c (term_mouse_position): Rename local to avoid shadowing.
9557
9558 * alloc.c (mark_ttys): Move decl from here ...
9559 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9560
9561 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9562
9563 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9564
9565 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9566
9567 * search.c (compile_pattern_1): Remove argument regp, unused since
9568 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9569 (compile_pattern): Don't pass it.
9570
9571 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9572
9573 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9574 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9575 for ! HAVE_GTK3.
9576 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9577
9578 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9579
9580 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9581 gdk_window_get_screen, gdk_window_get_geometry,
9582 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9583 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9584 (xg_get_pixbuf_from_pixmap): New function.
9585 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9586 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9587 Call xg_get_pixbuf_from_pixmap instead of
9588 gdk_pixbuf_get_from_drawable.
9589 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9590 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9591 (xg_check_special_colors): Use GtkStyleContext and its functions
9592 for HAVE_GTK3.
9593 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9594 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9595 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9596 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9597 Call gtk_widget_get_preferred_size.
9598 (xg_frame_resized): gdk_window_get_geometry only takes 5
9599 parameters.
9600 (xg_win_to_widget, xg_event_is_for_menubar):
9601 Call gdk_x11_window_lookup_for_display.
9602 (xg_set_widget_bg): New function.
9603 (delete_cb): New function.
9604 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9605 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9606 (xg_set_background_color): Call xg_set_widget_bg.
9607 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9608 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9609 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9610 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9611 if ! HAVE_GTK3.
9612 (update_frame_tool_bar): Call gtk_widget_hide.
9613 (xg_initialize): Use GDK_KEY_g.
9614
9615 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9616 if ! HAVE_GTK3
9617 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9618
9619 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9620 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9621 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9622
9623 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9624
9625 * w32xfns.c (select_palette): Check success of RealizePalette against
9626 GDI_ERROR, not zero.
9627
9628 See ChangeLog.11 for earlier changes.
9629
9630 ;; Local Variables:
9631 ;; coding: utf-8
9632 ;; End:
9633
9634 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9635
9636 This file is part of GNU Emacs.
9637
9638 GNU Emacs is free software: you can redistribute it and/or modify
9639 it under the terms of the GNU General Public License as published by
9640 the Free Software Foundation, either version 3 of the License, or
9641 (at your option) any later version.
9642
9643 GNU Emacs is distributed in the hope that it will be useful,
9644 but WITHOUT ANY WARRANTY; without even the implied warranty of
9645 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9646 GNU General Public License for more details.
9647
9648 You should have received a copy of the GNU General Public License
9649 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.