1 2011-06-13 Paul Eggert <eggert@cs.ucla.edu>
3 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5 GLYPH_CODE_FACE returns EMACS_INT, not int.
6 * dispextern.h (merge_faces):
7 * xfaces.c (merge_faces):
8 * xdisp.c (get_next_display_element):
9 (next_element_from_display_vector): Don't assume EMACS_INT fits in int.
11 * character.h (CHAR_VALID_P): Remove unused parameter.
12 * fontset.c, lisp.h, xdisp.c: All uses changed.
14 * editfns.c (Ftranslate_region_internal): Omit redundant test.
16 * fns.c (concat): Minor tuning based on overflow analysis.
17 This doesn't fix any bugs. Use int to hold character, instead
18 of constantly refetching from Emacs object. Use XFASTINT, not
19 XINT, for value known to be a character. Don't bother comparing
20 a single byte to 0400, as it's always less.
23 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
25 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
28 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
30 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
31 Without this fix, on a 64-bit host (aset S 0 4294967386) would
32 incorrectly succeed when S was a string, because 4294967386 was
33 truncated before it was used.
35 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
36 Otherwise, an out-of-range integer could cause undefined behavior
39 * composite.c: Use int, not EMACS_INT, for characters.
40 (fill_gstring_body, composition_compute_stop_pos): Use int, not
41 EMACS_INT, for values that are known to be in character range.
42 This doesn't fix any bugs but is the usual style inside Emacs and
43 may generate better code on 32-bit machines.
45 Make sure a 64-bit char is never passed to ENCODE_CHAR.
46 This is for reasons similar to the recent CHAR_STRING fix.
47 * charset.c (Fencode_char): Check that character arg is actually
48 a character. Pass an int to ENCODE_CHAR.
49 * charset.h (ENCODE_CHAR): Verify that the character argument is no
50 wider than 'int', as a compile-time check to prevent future regressions
53 * character.c (char_string): Remove unnecessary casts.
55 Make sure a 64-bit char is never passed to CHAR_STRING.
56 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
57 by silently ignoring the top 32 bits, allowing some values
58 that were far too large to be valid characters.
59 * character.h: Include <verify.h>.
60 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
61 arguments are no wider than unsigned, as a compile-time check
62 to prevent future regressions in this area.
64 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char):
65 (Fsubst_char_in_region):
67 * xdisp.c (decode_mode_spec_coding):
68 Adjust to CHAR_STRING's new requirement.
69 * editfns.c (Finsert_char, Fsubst_char_in_region):
70 * fns.c (concat): Check that character args are actually
71 characters. Without this test, these functions did the wrong
72 thing with wildly out-of-range values on 64-bit hosts.
74 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
76 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
77 These casts should not be needed on 32-bit hosts, either.
78 * keyboard.c (read_char):
79 * lread.c (Fload): Remove casts to unsigned.
81 * lisp.h (UNSIGNED_CMP): New macro.
82 This fixes comparison bugs on 64-bit hosts.
83 (ASCII_CHAR_P): Use it.
84 * casefiddle.c (casify_object):
85 * character.h (ASCII_BYTE_P, CHAR_VALID_P):
86 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
87 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
88 * dispextern.h (FACE_FROM_ID):
89 * keyboard.c (read_char): Use UNSIGNED_CMP.
91 2011-06-11 Paul Eggert <eggert@cs.ucla.edu>
93 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
94 not to EMACS_INT, to avoid GCC warning.
96 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
98 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
99 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
100 isn't needed on 32-bit machines.
102 * buffer.c (Fgenerate_new_buffer_name): Use EMACS_INT for count, not int.
103 (advance_to_char_boundary): Return EMACS_INT, not int.
105 * data.c (Qcompiled_function): Now static.
107 * window.c (window_body_lines): Now static.
109 * image.c (gif_load): Rename local to avoid shadowing.
111 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
112 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
113 * alloc.c (make_save_value): Integer argument is now of type
115 (mark_object): Use ptrdiff_t, not int.
116 * lisp.h (pD): New macro.
117 * print.c (print_object): Use it.
119 * alloc.c: Use EMACS_INT, not int, to count objects.
120 (total_conses, total_markers, total_symbols, total_vector_size)
121 (total_free_conses, total_free_markers, total_free_symbols)
122 (total_free_floats, total_floats, total_free_intervals, total_intervals)
123 (total_strings, total_free_strings):
124 Now EMACS_INT, not int. All uses changed.
125 (Fgarbage_collect): Compute overall total using a double, so that
126 integer overflow is less likely to be a problem. Check for overflow
127 when converting back to an integer.
128 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
129 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
130 These were 'int' variables that could overflow on 64-bit hosts;
131 they were never used, so remove them instead of repairing them.
132 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
133 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
134 Previously, this ceilinged at INT_MAX, but that doesn't work on
136 (allocate_pseudovector): Don't use EMACS_INT when int would do.
138 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
139 (allocate_vectorlike): Check for ptrdiff_t overflow.
140 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
141 when a (possibly-narrower) signed value would do just as well.
142 We prefer using signed arithmetic, to avoid comparison confusion.
144 * alloc.c: Catch some string size overflows that we were missing.
145 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
146 for convenience in STRING_BYTES_MAX.
147 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
148 The definition here is exact; the one in lisp.h was approximate.
149 (allocate_string_data): Check for string overflow. This catches
150 some instances we weren't catching before. Also, it catches
151 size_t overflow on (unusual) hosts where SIZE_MAX <= min
152 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
153 and ptrdiff_t and EMACS_INT are both 64 bits.
155 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
156 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
157 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
159 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
161 * alloc.c (Fmake_string): Check for out-of-range init.
163 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
165 * dispextern.h (struct image): Replace data member, whose int_val
166 and ptr_val fields were not used by anything, with a single
169 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
170 (gif_clear_image, gif_load, imagemagick_load_image)
171 (gs_clear_image, gs_load): Callers changed.
173 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
175 * buffer.h: Include <time.h>, for time_t.
176 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
178 Fix minor problems found by static checking.
180 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
182 Make identifiers static if they are not used in other modules.
183 * data.c (Qcompiled_function, Qframe, Qvector):
184 * image.c (QimageMagick, Qsvg):
185 * minibuf.c (Qmetadata):
186 * window.c (resize_window_check, resize_root_window): Now static.
187 * window.h (resize_window_check, resize_root_window): Remove decls.
189 * window.c (window_deletion_count, delete_deletable_window):
191 (window_body_lines): Now static.
192 (Fdelete_other_windows_internal): Mark vars as initialized.
193 Make sure 'resize_failed' is initialized.
194 (run_window_configuration_change_hook): Rename local to avoid shadowing.
195 (resize_window_apply): Remove unused local.
196 * window.h (delete_deletable_window): Remove decl.
198 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
199 (imagemagick_load_image): Fix pointer signedness problem by changing
200 last arg from unsigned char * to char *. All uses changed.
201 Also, fix a local for similar reasons.
202 Remove unused locals. Remove locals to avoid shadowing.
203 (fn_rsvg_handle_free): Remove; unused.
204 (svg_load, svg_load_image): Fix pointer signedness problem.
205 (imagemagick_load_image): Don't use garbage pointer image_wand.
207 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
209 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
211 * image.c (gif_load): Fix omitted cast error introduced by
214 2011-06-10 Martin Rudalics <rudalics@gmx.at>
216 * window.h (resize_proportionally, orig_total_lines)
217 (orig_top_line): Remove from window structure.
218 (set_window_height, set_window_width, change_window_heights)
219 (Fdelete_window): Remove prototypes.
220 (resize_frame_windows): Remove duplicate declaration.
222 2011-06-10 Eli Zaretskii <eliz@gnu.org>
224 * window.h (resize_frame_windows, resize_window_check)
225 (delete_deletable_window, resize_root_window)
226 (resize_frame_windows): Declare prototypes.
228 * window.c (resize_window_apply): Make definition be "static" to
231 2011-06-10 Martin Rudalics <rudalics@gmx.at>
233 * window.c: Remove declarations of Qwindow_size_fixed,
234 window_min_size_1, window_min_size_2, window_min_size,
235 size_window, window_fixed_size_p, enlarge_window, delete_window.
236 Remove static from declaration of Qdelete_window, it's
237 temporarily needed by Fbury_buffer.
238 (replace_window): Don't assign orig_top_line and
240 (Fdelete_window, delete_window): Remove. Window deletion is
241 handled by window.el.
242 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
243 Fdelete_window calls with calls to Qdelete_window.
244 (Fdelete_other_windows): Remove. Deleting other windows is
245 handled by window.el.
246 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
247 handled in window.el.
248 (window_min_size_2, window_min_size_1, window_min_size): Remove.
249 Window minimum sizes are handled in window.el.
250 (shrink_windows, size_window, set_window_height)
251 (set_window_width, change_window_heights, window_height)
252 (window_width, CURBEG, CURSIZE, enlarge_window)
253 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
254 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
255 handled in window.el.
256 (make_dummy_parent): Rename to make_parent_window and give it a
257 second argument horflag.
258 (make_window): Don't set resize_proportionally any more.
259 (Fsplit_window): Remove. Windows are split in window.el.
260 (save_restore_action, save_restore_orig_size)
261 (shrink_window_lowest_first, save_restore_orig_size): Remove.
262 Resize mini windows in window.el.
263 (grow_mini_window, shrink_mini_window): Implement by calling
264 Qresize_root_window_vertically, resize_window_check and
266 (saved_window, Fset_window_configuration, save_window_save): Do
267 not handle orig_top_line, orig_total_lines, and
268 resize_proportionally.
269 (window_min_height, window_min_width): Move to window.el.
270 (keys_of_window): Move bindings for delete-other-windows,
271 split-window, delete-window and enlarge-window to window.el.
273 * buffer.c: Temporarily extern Qdelete_window.
274 (Fbury_buffer): Temporarily call Qdelete_window instead of
275 Fdelete_window (Fbury_buffer will move to window.el soon).
277 * frame.c (set_menu_bar_lines_1): Remove code handling
278 orig_top_line and orig_total_lines.
280 * dispnew.c (adjust_frame_glyphs_initially): Don't use
281 set_window_height but set heights directly.
282 (change_frame_size_1): Use resize_frame_windows.
284 * xdisp.c (init_xdisp): Don't use set_window_height but set
287 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
288 resize_frame_windows instead of change_window_heights and run
289 run_window_configuration_change_hook.
291 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
292 instead of change_window_heights and run
293 run_window_configuration_change_hook.
295 2011-06-09 Martin Rudalics <rudalics@gmx.at>
297 * window.c (replace_window): Rename second argument REPLACEMENT to
298 NEW. New third argument SETFLAG. Rewrite.
299 (delete_window, make_dummy_parent): Call replace_window with
301 (window_list_1): Move down in code.
302 (run_window_configuration_change_hook): Move set_buffer part
303 before select_frame_norecord part in order to unwind correctly.
304 Rename count1 to count.
305 (recombine_windows, delete_deletable_window, resize_root_window)
306 (Fdelete_other_windows_internal)
307 (Frun_window_configuration_change_hook, make_parent_window)
308 (resize_window_check, resize_window_apply, Fresize_window_apply)
309 (resize_frame_windows, Fsplit_window_internal)
310 (Fdelete_window_internal, Fresize_mini_window_internal): New
312 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
314 2011-06-08 Martin Rudalics <rudalics@gmx.at>
316 * window.h (window): Add some new members to window structure -
317 normal_lines, normal_cols, new_total, new_normal, clone_number,
318 splits, nest, prev_buffers, next_buffers.
319 (WINDOW_TOTAL_SIZE): Move here from window.c.
320 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
322 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
324 (make_dummy_parent): Set new members of windows structure.
325 (make_window): Move down in code. Handle new members of window
327 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
328 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
329 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
330 (Fset_window_prev_buffers, Fwindow_next_buffers)
331 (Fset_window_next_buffers, Fset_window_clone_number): New
333 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
334 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
336 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
337 Argument WINDOW can be now internal window too.
338 (Fwindow_use_time): Move up in code.
339 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
341 (Fset_window_configuration, saved_window)
342 (Fcurrent_window_configuration, save_window_save): Handle new
343 members of window structure.
344 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
345 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
346 (syms_of_window): New Lisp objects Qrecord_window_buffer,
347 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
348 Qget_mru_window, Qresize_root_window,
349 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
350 Qauto_buffer_name; staticpro them.
352 2011-06-07 Martin Rudalics <rudalics@gmx.at>
354 * window.c (Fwindow_total_size, Fwindow_left_column)
355 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
356 (Fwindow_list_1): New functions.
357 (window_box_text_cols): Replace with window_body_cols.
358 (Fwindow_width, Fscroll_left, Fscroll_right): Use
359 window_body_cols instead of window_box_text_cols.
360 (delete_window, Fset_window_configuration): Call
361 delete_all_subwindows with window as argument.
362 (delete_all_subwindows): Take a window as argument and not a
364 (window_loop): Remove handling of GET_LRU_WINDOW and
366 (Fget_lru_window, Fget_largest_window): Move to window.el.
368 * window.h: Extern window_body_cols instead of
369 window_box_text_cols. delete_all_subwindows now takes a
370 Lisp_Object as argument.
372 * indent.c (compute_motion, Fcompute_motion): Use
373 window_body_cols instead of window_box_text_cols.
375 * frame.c (delete_frame): Call delete_all_subwindows with root
378 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
380 * fns.c (Fputhash): Document return value.
382 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
384 * image.c (gif_load): Implement gif89a spec "no disposal" method.
386 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
388 Cons<->int and similar integer overflow fixes (Bug#8794).
390 Check for overflow when converting integer to cons and back.
391 * charset.c (Fdefine_charset_internal, Fdecode_char):
392 Use cons_to_unsigned to catch overflow.
393 (Fencode_char): Use INTEGER_TO_CONS.
394 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
395 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
396 * data.c (long_to_cons, cons_to_long): Remove.
397 (cons_to_unsigned, cons_to_signed): New functions.
398 These signal an error for invalid or out-of-range values.
399 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
400 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
401 * font.c (Ffont_variation_glyphs):
402 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
403 * lisp.h: Include <intprops.h>.
404 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
405 (cons_to_signed, cons_to_unsigned): New decls.
406 (long_to_cons, cons_to_long): Remove decls.
407 * undo.c (record_first_change): Use INTEGER_TO_CONS.
408 (Fprimitive_undo): Use CONS_TO_INTEGER.
409 * xfns.c (Fx_window_property): Likewise.
410 * xselect.c: Include <limits.h>.
411 (x_own_selection, selection_data_to_lisp_data):
413 (x_handle_selection_request, x_handle_selection_clear)
414 (x_get_foreign_selection, Fx_disown_selection_internal)
415 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
416 (lisp_data_to_selection_data): Use cons_to_unsigned.
417 (x_fill_property_data): Use cons_to_signed.
418 Report values out of range.
420 Check for buffer and string overflow more precisely.
421 * buffer.h (BUF_BYTES_MAX): New macro.
422 * lisp.h (STRING_BYTES_MAX): New macro.
423 * alloc.c (Fmake_string):
424 * character.c (string_escape_byte8):
425 * coding.c (coding_alloc_by_realloc):
427 * editfns.c (Fformat):
429 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
430 since they may not be the same number.
431 * editfns.c (Finsert_char):
432 * fileio.c (Finsert_file_contents):
433 Likewise for BUF_BYTES_MAX.
435 * image.c: Use ptrdiff_t, not int, for sizes.
436 (slurp_file): Switch from int to ptrdiff_t.
438 (slurp_file): Check that file size fits in both size_t (for
439 malloc) and ptrdiff_t (for sanity and safety).
441 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
442 if b->modtime has its maximal value.
444 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
446 Don't assume time_t can fit into int.
447 * buffer.h (struct buffer.modtime): Now time_t, not int.
448 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
449 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
451 Minor fixes for signed vs unsigned integers.
452 * character.h (MAYBE_UNIFY_CHAR):
453 * charset.c (maybe_unify_char):
454 * keyboard.c (read_char, reorder_modifiers):
455 XINT -> XFASTINT, since the integer must be nonnegative.
456 * ftfont.c (ftfont_spec_pattern):
457 * keymap.c (access_keymap, silly_event_symbol_error):
458 XUINT -> XFASTINT, since the integer must be nonnegative.
459 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
460 since it makes no difference and we prefer signed.
461 * keyboard.c (record_char): Use XUINT when all the neighbors do.
462 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
465 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
467 * window.h (Fwindow_frame): Declare.
469 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
471 * alloc.c: Simplify handling of large-request failures (Bug#8800).
472 (SPARE_MEMORY): Always define.
473 (LARGE_REQUEST): Remove.
474 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
476 2011-06-06 Martin Rudalics <rudalics@gmx.at>
478 * lisp.h: Move EXFUNS for Fframe_root_window,
479 Fframe_first_window and Fset_frame_selected_window to window.h.
481 * window.h: Move EXFUNS for Fframe_root_window,
482 Fframe_first_window and Fset_frame_selected_window here from
485 * frame.c (Fwindow_frame, Fframe_first_window)
486 (Fframe_root_window, Fframe_selected_window)
487 (Fset_frame_selected_window): Move to window.c.
488 (Factive_minibuffer_window): Move to minibuf.c.
489 (Fother_visible_frames_p): New function.
491 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
493 * window.c (decode_window, decode_any_window): Move up in code.
494 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
495 (inhibit_frame_unsplittable): Remove unused variable.
496 (Fwindow_buffer): Move up and rewrite doc-string.
497 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
498 (Fwindow_prev): New functions.
499 (Fwindow_frame): Move here from frame.c. Accept any window as
501 (Fframe_root_window, Fframe_first_window)
502 (Fframe_selected_window): Move here from frame.c. Accept frame
503 or arbitrary window as argument. Update doc-strings.
504 (Fminibuffer_window): Move up in code.
505 (Fwindow_minibuffer_p): Move up in code and simplify.
506 (Fset_frame_selected_window): Move here from frame.c.
508 (Fselected_window, select_window, Fselect_window): Move up in
509 code. Minor doc-string fixes.
511 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
513 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
514 Do not assume that spare memory exists; that assumption is valid
515 only if SYSTEM_MALLOC.
516 (LARGE_REQUEST): New macro, so that the issue of large requests
517 is separated from the issue of spare memory.
519 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
521 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
524 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
526 * xfns.c (x_set_scroll_bar_default_width): Move declarations
529 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
531 * gtkutil.c (xg_get_default_scrollbar_width): New function.
533 * gtkutil.h: Declare xg_get_default_scrollbar_width.
535 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
536 min width by calling x_set_scroll_bar_default_width (Bug#8505).
538 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
540 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
542 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
544 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
545 (x_clipboard_manager_save): Add return value.
546 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
548 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
549 Obey Vx_select_enable_clipboard_manager. Catch errors in
550 x_clipboard_manager_save (Bug#8779).
551 (Vx_select_enable_clipboard_manager): New variable.
552 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
554 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
556 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
558 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
560 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
561 in the current matrix if keep_current_p is non-zero.
563 2011-06-04 Eli Zaretskii <eliz@gnu.org>
565 * bidi.c (bidi_level_of_next_char): Fix last change.
567 2011-06-03 Eli Zaretskii <eliz@gnu.org>
569 Support bidi reordering of text covered by display properties.
571 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
572 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
573 (bidi_cache_search, bidi_cache_iterator_state)
574 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
575 (bidi_level_of_next_char, bidi_move_to_visually_next):
576 Support character positions inside a run of characters covered by a
578 (bidi_paragraph_init, bidi_resolve_explicit_1)
579 (bidi_level_of_next_char): Call bidi_fetch_char and
580 bidi_fetch_char_advance instead of FETCH_CHAR and
582 (bidi_init_it): Initialize new members.
583 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
585 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
586 instead of using explicit *_CHAR codes.
587 (bidi_resolve_explicit, bidi_resolve_weak):
588 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
589 bidirectional text is supported only in multibyte buffers.
590 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
591 it to initialize the frame_window_p member of struct bidi_it.
592 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
593 (bidi_resolve_explicit, bidi_resolve_weak)
594 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
595 bidi_it->nchars is non-positive.
596 (bidi_level_of_next_char): Don't try to lookup the cache for the
597 next/previous character if nothing is cached there yet, or if we
598 were just reseat()'ed to a new position.
600 * xdisp.c (set_cursor_from_row): Set start and stop points
601 according to the row's direction when priming the loop that looks
602 for the glyph on which to display cursor.
603 (single_display_spec_intangible_p): Function deleted.
604 (display_prop_intangible_p): Reimplement to call
605 handle_display_spec instead of single_display_spec_intangible_p.
606 Accept 3 additional arguments needed by handle_display_spec.
607 This fixes incorrect cursor motion across display property with complex
608 values: lists, `(when COND...)' forms, etc.
609 (single_display_spec_string_p): Support property values that are
610 lists with the argument STRING its top-level element.
611 (display_prop_string_p): Fix the condition for processing a
612 property that is a list to be consistent with handle_display_spec.
613 (handle_display_spec): New function, refactored from the
614 last portion of handle_display_prop.
615 (compute_display_string_pos): Accept additional argument
616 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
617 value of a `display' property is a "replacing spec".
618 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
619 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
620 the display property, but just return a value indicating whether
621 the display property will replace the characters it covers.
622 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
623 frame_window_p members of struct bidi_it.
624 (compute_display_string_pos, compute_display_string_end):
626 (push_it): Accept second argument POSITION, where pop_it should
627 jump to continue iteration.
628 (reseat_1): Initialize bidi_it.disp_pos.
630 * keyboard.c (adjust_point_for_property): Adjust the call to
631 display_prop_intangible_p to its new signature.
633 * dispextern.h (struct bidi_it): New member frame_window_p.
634 (bidi_init_it): Update prototypes.
635 (display_prop_intangible_p): Update prototype.
636 (compute_display_string_pos, compute_display_string_end):
638 (struct bidi_it): New members nchars and disp_pos. ch_len is now
641 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
643 Malloc failure behavior now depends on size of allocation.
644 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
645 * lisp.h: Change signatures accordingly.
646 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
647 All callers changed. (Bug#8762)
649 * gnutls.c: Use Emacs's memory allocators.
650 Without this change, the gnutls library would invoke malloc etc.
651 directly, which causes problems on non-SYNC_INPUT hosts, and which
652 runs afoul of improving memory_full behavior. (Bug#8761)
653 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
654 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
655 xfree instead of the default malloc, realloc, free.
656 (Fgnutls_boot): No need to check for memory allocation failure,
657 since xmalloc does that for us.
659 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
660 * category.c (hash_get_category_set):
661 * ccl.c (ccl_driver):
662 * charset.c (Fdefine_charset_internal):
663 * charset.h (struct charset.hash_index):
664 * composite.c (get_composition_id, gstring_lookup_cache)
665 (composition_gstring_put_cache):
666 * composite.h (struct composition.hash_index):
667 * dispextern.h (struct image.hash):
668 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
669 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
670 (hashfn_equal, hashfn_user_defined, make_hash_table)
671 (maybe_resize_hash_table, hash_lookup, hash_put)
672 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
673 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
674 (Fsxhash, Fgethash, Fputhash, Fmaphash):
675 * image.c (make_image, search_image_cache, lookup_image)
676 (xpm_put_color_table_h):
677 * lisp.h (struct Lisp_Hash_Table):
678 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
679 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
680 for hashes and hash indexes, instead of 'unsigned' and 'int'.
681 * alloc.c (allocate_vectorlike):
682 Check for overflow in vector size calculations.
683 * ccl.c (ccl_driver):
684 Check for overflow when converting EMACS_INT to int.
685 * fns.c, image.c: Remove unnecessary static decls that would otherwise
686 need to be updated by these changes.
687 * fns.c (make_hash_table, maybe_resize_hash_table):
688 Check for integer overflow with large hash tables.
689 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
690 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
691 (SXHASH_REDUCE): New macro.
692 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
693 Use it instead of discarding useful hash info with large hash values.
694 (sxhash_float): New function.
695 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
696 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
697 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
698 Rewrite to use FIXNUM_BITS, as this simplifies things.
699 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
700 Adjust signatures to match updated version of code.
701 (consing_since_gc): Now EMACS_INT, since a single hash table can
702 use more than INT_MAX bytes.
704 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
706 Make it possible to build with GCC-4.6+ -O2 -flto.
708 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
710 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
712 * minibuf.c (get_minibuffer, read_minibuf_unwind):
713 Call minibuffer-inactive-mode.
715 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
717 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
720 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
722 * data.c (init_data): Remove code for UTS, this system is not
725 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
727 Don't force ./temacs to start in terminal mode.
729 * frame.c (make_initial_frame): Initialize faces in all cases, not
730 only when CANNOT_DUMP is defined.
731 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
733 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
735 * dispnew.c (add_window_display_history): Use const for the string
736 pointer. Remove declaration, not needed.
738 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
740 Use 'inline', not 'INLINE'.
741 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
742 * alloc.c, fontset.c (INLINE): Remove.
743 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
744 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
745 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
746 * gmalloc.c (register_heapinfo): Use inline unconditionally.
747 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
749 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
751 Make it possible to run ./temacs.
753 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
754 syms_of_callproc does the same thing. Remove test for
755 "initialized", do it in the caller.
756 * emacs.c (main): Avoid calling set_initial_environment when dumping.
758 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
760 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
761 (read_minibuf): Use get_minibuffer.
762 (syms_of_minibuf): Use DEFSYM.
763 (Qmetadata): New var.
764 * data.c (Qbuffer): Don't make it static.
765 (syms_of_data): Use DEFSYM.
767 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
769 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
770 (CCL_CODE_MIN): New macro.
772 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
774 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
776 * eval.c (Qdebug): Now static.
777 * lisp.h (Qdebug): Remove decl. This reverts a part of the
778 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
779 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
781 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
783 * image.c: Various fixes to ImageMagick code comments.
784 (Fimagemagick_types): Doc fix.
786 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
788 Minor fixes prompted by GCC 4.6.0 warnings.
790 * xselect.c (converted_selections, conversion_fail_tag): Now static.
792 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
793 (x_clipboard_manager_save_all): Move extern decl to ...
794 * xterm.h: ... here, so that it can be checked for consistency.
796 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
798 * xselect.c (x_clipboard_manager_save_frame)
799 (x_clipboard_manager_save_all): New functions.
800 (Fx_clipboard_manager_save): Lisp function deleted.
802 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
803 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
805 * xterm.h: Update prototype.
807 2011-05-28 William Xu <william.xwl@gmail.com>
809 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
812 2011-05-28 Jim Meyering <meyering@redhat.com>
814 Avoid a sign-extension bug in crypto_hash_function.
815 * fns.c (to_uchar): Define.
816 (crypto_hash_function): Use it to convert some newly-signed
817 variables to unsigned, to avoid sign-extension bugs. For example,
818 without this change, (md5 "truc") would evaluate to
819 45723a2aff78ff4fff7fff1114760e62 rather than the expected
820 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
821 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
823 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
825 Integer overflow fixes.
827 * dbusbind.c: Serial number integer overflow fixes.
828 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
829 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
830 to hold a serial number that is too large for a fixnum.
831 (Fdbus_method_return_internal, Fdbus_method_error_internal):
832 Check for serial numbers out of range. Decode any serial number
833 that was so large that it became a float. (Bug#8722)
835 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
836 (Fdbus_call_method, Fdbus_call_method_asynchronously):
837 Use XFASTINT rather than XUINT when numbers are nonnegative.
838 (xd_append_arg, Fdbus_method_return_internal):
839 (Fdbus_method_error_internal): Likewise. Also, for unsigned
840 arguments, check that Lisp number is nonnegative, rather than
841 silently wrapping negative numbers around. (Bug#8722)
842 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
845 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
847 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
849 ccl: add integer overflow checks
850 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
851 (IN_INT_RANGE): New macros.
852 (ccl_driver): Use them to check for integer overflow when
853 decoding a CCL program. Many of the new checks are whether XINT (x)
854 fits in int; it doesn't always, on 64-bit hosts. The new version
855 doesn't catch all possible integer overflows, but it's an
856 improvement. (Bug#8719)
858 * alloc.c (make_event_array): Use XINT, not XUINT.
859 There's no need for unsigned here.
861 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
862 This follows up to the 2011-05-06 change that substituted uintptr_t
863 for EMACS_INT. This case wasn't caught back then.
865 Rework Fformat to avoid integer overflow issues.
866 * editfns.c: Include <float.h> unconditionally, as it's everywhere
867 now (part of C89). Include <verify.h>.
868 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
869 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
870 (Fformat): Avoid the prepass trying to compute sizes; it was only
871 approximate and thus did not catch overflow reliably. Instead, walk
872 through the format just once, formatting and computing sizes as we go,
873 checking for integer overflow at every step, and allocating a larger
874 buffer as needed. Keep track separately whether the format is
875 multibyte. Keep only the most-recently calculated precision, rather
876 than them all. Record whether each argument has been converted to
877 string. Use EMACS_INT, not int, for byte and char and arg counts.
878 Support field widths and precisions larger than INT_MAX. Avoid
879 sprintf's undefined behavior with conversion specifications such as %#d
880 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
881 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
882 formatting out-of-range floating point numbers with int
885 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
887 * data.c: Avoid integer truncation in expressions involving floats.
888 * data.c: Include <intprops.h>.
889 (arith_driver): When there's an integer overflow in an expression
890 involving floating point, convert the integers to floating point
891 so that the resulting value does not suffer from catastrophic
892 integer truncation. For example, on a 64-bit host (* 4
893 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
894 Do not rely on undefined behavior after integer overflow.
896 merge count_size_as_multibyte, parse_str_to_multibyte
897 * character.c, character.h (count_size_as_multibyte):
898 Rename from parse_str_to_multibyte; all uses changed.
899 Check for integer overflow.
900 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
901 since it's now a duplicate of the other. This is more of
902 a character than a buffer op, so better that it's in character.c.
903 * fns.c, print.c: Adjust to above changes.
905 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
907 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
909 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
911 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
912 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
913 (x_clipboard_manager_save): Now static.
914 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
916 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
917 (crypto_hash_function): Now static.
918 Fix pointer signedness problems. Avoid unnecessary initializations.
920 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
922 * termhooks.h (Vselection_alist): Make it terminal-local.
924 * terminal.c (create_terminal): Initialize it.
926 * xselect.c: Support for clipboard managers.
927 (Vselection_alist): Move to termhooks.h as terminal-local var.
928 (LOCAL_SELECTION): New macro.
929 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
930 (symbol_to_x_atom): Remove gratuitous arg.
931 (x_handle_selection_request, lisp_data_to_selection_data)
932 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
933 (x_own_selection, x_get_local_selection, x_convert_selection):
934 New arg, specifying work frame. Use terminal-local Vselection_alist.
935 (some_frame_on_display): Delete unused function.
936 (Fx_own_selection_internal, Fx_get_selection_internal)
937 (Fx_disown_selection_internal, Fx_selection_owner_p)
938 (Fx_selection_exists_p): New optional frame arg.
939 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
940 (x_handle_selection_clear): Don't treat other terminals with the
941 same keyboard specially. Use the terminal-local Vselection_alist.
942 (x_clear_frame_selections): Use Frun_hook_with_args.
944 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
946 * xterm.h: Add support for those atoms.
948 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
950 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
951 (converted_selections, conversion_fail_tag): New global variables.
952 (x_selection_request_lisp_error): Free the above.
953 (x_get_local_selection): Remove unnecessary code.
954 (x_reply_selection_request): Args changed; handle arbitrary array
955 of converted selections stored in converted_selections.
956 Separate the XChangeProperty and SelectionNotify steps.
957 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
958 (x_convert_selection): New function.
959 (x_handle_selection_event): Simplify.
960 (x_get_foreign_selection): Don't ignore incoming requests while
961 waiting for an answer; this will fail when we implement
962 SAVE_TARGETS, and seems unnecessary anyway.
963 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
964 (Vx_sent_selection_functions): Doc fix.
966 2011-05-26 Leo Liu <sdl.web@gmail.com>
968 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
970 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
972 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
974 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
975 for fringe update if it has periodic bitmap.
976 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
977 and fringe_bitmap_periodic_p.
979 * fringe.c (get_fringe_bitmap_data): New function.
980 (draw_fringe_bitmap_1, update_window_fringes): Use it.
981 (update_window_fringes): Record periodicity of fringe bitmap in glyph
982 row. Mark glyph row for fringe update if periodicity changed.
984 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
985 for fringe update unless it has periodic bitmap.
987 2011-05-25 Kenichi Handa <handa@m17n.org>
989 * xdisp.c (get_next_display_element): Set correct it->face_id for
990 a static composition.
992 2011-05-24 Leo Liu <sdl.web@gmail.com>
995 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
997 * fns.c (crypto_hash_function, Fsha1): New function.
998 (Fmd5): Use crypto_hash_function.
999 (syms_of_fns): Add Ssha1.
1001 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1003 * gnutls.c: Remove unused macros.
1004 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1005 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1006 Remove macros that are defined and never used.
1007 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1009 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1011 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1012 (Fx_get_selection_internal): Minor cleanup.
1013 (Fx_own_selection_internal): Rename arguments for consistency with
1016 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1018 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1020 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1022 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1024 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1026 * dispnew.c (scrolling_window): Don't exclude the case that the
1027 last enabled row in the desired matrix touches the bottom boundary.
1029 2011-05-21 Glenn Morris <rgm@gnu.org>
1031 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
1032 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1033 and add some more files.
1035 2011-05-20 Eli Zaretskii <eliz@gnu.org>
1037 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1038 report_file_error introduced by the change from 2011-05-07.
1040 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1042 * systime.h (Time): Define only if emacs is defined.
1043 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1044 where the include path doesn't have X11/X.h by default. See
1045 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1047 2011-05-20 Kenichi Handa <handa@m17n.org>
1049 * composite.c (find_automatic_composition): Fix previous change.
1051 2011-05-20 Glenn Morris <rgm@gnu.org>
1053 * lisp.mk: New file, split from Makefile.in.
1054 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1055 (shortlisp): Remove.
1056 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1058 2011-05-19 Glenn Morris <rgm@gnu.org>
1060 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1061 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1062 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1063 (lisp): Set the order to that of loadup.el.
1064 (shortlisp): Make it a copy of $lisp.
1065 (SOME_MACHINE_LISP): Remove.
1066 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1067 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1069 2011-05-18 Kenichi Handa <handa@m17n.org>
1071 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1072 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1073 (find_automatic_composition): Mostly rewrite for efficiency.
1075 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
1077 * makefile.w32-in: Update dependencies.
1079 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1081 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1084 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
1086 Fix some integer overflow issues, such as string length overflow.
1088 * insdel.c (count_size_as_multibyte): Check for string overflow.
1090 * character.c (lisp_string_width): Check for string overflow.
1091 Use EMACS_INT, not int, for string indexes and lengths; in
1092 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1093 the resulting string length overflows an EMACS_INT; instead,
1094 report a string overflow if no precision given. When checking for
1095 precision exhaustion, use a check that cannot possibly have
1096 integer overflow. (Bug#8675)
1097 * character.h (lisp_string_width): Adjust to new signature.
1099 * alloc.c (string_overflow): New function.
1100 (Fmake_string): Use it. This doesn't change behavior, but saves
1101 a few bytes and will simplify future changes.
1102 * character.c (string_escape_byte8): Likewise.
1103 * lisp.h (string_overflow): New decl.
1105 Fixups, following up to the user-interface timestamp change.
1106 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1107 for UI timestamps, instead of unsigned long.
1108 * msdos.c (mouse_get_pos): Likewise.
1109 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1110 * w32gui.h (Time): Define by including "systime.h" rather than by
1111 declaring it ourselves. (Bug#8664)
1113 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1114 * image.c (clear_image_cache): Likewise.
1116 * term.c (term_mouse_position): Don't assume time_t wraparound.
1118 Be more systematic about user-interface timestamps.
1119 Before, the code sometimes used 'Time', sometimes 'unsigned long',
1120 and sometimes 'EMACS_UINT', to represent these timestamps.
1121 This change causes it to use 'Time' uniformly, as that's what X uses.
1122 This makes the code easier to follow, and makes it easier to catch
1123 integer overflow bugs such as Bug#8664.
1124 * frame.c (Fmouse_position, Fmouse_pixel_position):
1125 Use Time, not unsigned long, for user-interface timestamps.
1126 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1127 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1128 * keyboard.h (last_event_timestamp): Likewise.
1129 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1130 * menu.h (xmenu_show): Likewise.
1131 * term.c (term_mouse_position): Likewise.
1132 * termhooks.h (struct input_event.timestamp): Likewise.
1133 (struct terminal.mouse_position_hook): Likewise.
1134 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1135 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1136 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1137 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1139 * menu.h, termhooks.h: Include "systime.h", for Time.
1141 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1142 Don't assume that the difference between two unsigned long values
1143 can fit into an integer. At this point, we know button_down_time
1144 <= event->timestamp, so the difference must be nonnegative, so
1145 there's no need to cast the result if double-click-time is
1146 nonnegative, as it should be; check that it's nonnegative, just in
1147 case. This bug is triggered when events are more than 2**31 ms
1148 apart (about 25 days). (Bug#8664)
1150 * xselect.c (last_event_timestamp): Remove duplicate decl.
1151 (x_own_selection): Remove needless cast to unsigned long.
1153 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1154 that always fit in int. Use a sentinel instead of a counter, to
1155 avoid a temp and to allay GCC's concerns about possible int overflow.
1156 * frame.h (struct frame): Use int for menu_bar_items_used
1157 instead of EMACS_INT, since it always fits in int.
1159 * menu.c (grow_menu_items): Check for int overflow.
1161 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1163 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1164 Before, the code was not consistent. These values cannot exceed
1165 2**31 - 1 so there's no need to make them unsigned.
1166 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1167 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1168 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1170 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1172 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1173 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1174 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1175 presumably because the widths might not match.
1177 * window.c (size_window): Avoid needless test at loop start.
1179 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1181 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1183 2011-05-12 Drew Adams <drew.adams@oracle.com>
1185 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1187 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1189 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1190 `width' to `bar_area_x' and `bar_area_width', respectively.
1191 (x_scroll_run): Take account of fringe background extension.
1193 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1194 Rename local vars `left' and `width' to `bar_area_x' and
1195 `bar_area_width', respectively.
1196 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1197 background extension.
1199 2011-05-10 Jim Meyering <meyering@redhat.com>
1201 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1203 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
1205 * image.c (Finit_image_library): Return t for built-in image types,
1206 like pbm and xbm. (Bug#8640)
1208 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1210 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1212 2011-05-07 Eli Zaretskii <eliz@gnu.org>
1214 * w32console.c (Fset_screen_color): Doc fix.
1215 (Fget_screen_color): New function.
1216 (syms_of_ntterm): Defsubr it.
1218 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1219 unlink the temporary file if Fcall_process didn't create it in the
1221 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1222 child process will be redirected to a file specified with `:file'.
1223 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1224 cue to call_process_cleanup not to close that handle.
1226 2011-05-07 Ben Key <bkey76@gmail.com>
1228 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1229 one of two shell specific rules, either bootstrap-temacs-CMD or
1230 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1231 to the previous implementation of the bootstrap-temacs rule.
1232 The bootstrap-temacs-CMD rule is similar to the previous
1233 implementation of the bootstrap-temacs rule except that it
1234 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1237 These changes, along with some changes to nt/configure.bat,
1238 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1239 earlier fix to add support for --cflags and --ldflags options
1240 that include quotes so that it works whether make uses cmd or
1243 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
1245 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1246 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1248 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1249 a string. Handle both cases.
1250 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1251 (Fdbus_register_method): Use Qinvalid_function.
1253 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1255 * makefile.w32-in: Update dependencies.
1256 (LISP_H): Add inttypes.h and stdin.h.
1257 (PROCESS_H): Add unistd.h.
1259 2011-05-06 Eli Zaretskii <eliz@gnu.org>
1261 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1262 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1264 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
1266 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1268 * term.c (vfatal): Remove stray call to va_end.
1269 It's not needed and the C Standard doesn't allow it here anyway.
1271 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1272 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1274 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1277 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1279 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1281 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1283 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1285 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1287 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1288 * charset.c (Fdefine_charset_internal): Don't initialize
1289 charset.code_space[15]. The value was garbage, on hosts with
1290 32-bit int (Bug#8600).
1292 * lread.c (read_integer): Be more consistent with string-to-number.
1293 Use string_to_number to do the actual conversion; this avoids
1294 rounding errors and fixes some other screwups. Without this fix,
1295 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1296 (digit_to_number): Move earlier, for benefit of read_integer.
1297 Return -1 if the digit is out of range for the base, -2 if it is
1298 not a digit in any supported base. (Bug#8602)
1300 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1302 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1303 to match comment at start of function. This also removes a
1304 GCC warning about overflow in a 32+64-bit port.
1306 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1308 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1309 Reported by Stefan Monnier in
1310 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
1311 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1312 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
1314 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1315 (EMACS_UINTPTR): Likewise, with uintptr_t.
1317 * lisp.h: Prefer 64-bit EMACS_INT if available.
1318 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1319 on 32-bit hosts that have 64-bit int, so that they can access
1321 However, temporarily disable this change unless the temporary
1322 symbol WIDE_EMACS_INT is defined.
1324 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1326 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1327 This removes an assumption that EMACS_INT and long are the same
1328 width as pointers. The assumption is true for Emacs porting targets
1329 now, but we want to make other targets possible.
1330 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1331 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1332 In the rest of the code, change types of integers that hold casted
1333 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1334 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1335 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1336 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1337 No need to cast type when ORing.
1338 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1339 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1340 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1341 assume EMACS_INT is the same width as char *.
1342 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1343 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1344 Remove no-longer-needed casts.
1345 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1346 (xg_tool_bar_help_callback, xg_make_tool_item):
1347 Use EMACS_INTPTR to hold an integer
1348 that will be cast to void *; this can avoid a GCC warning
1349 if EMACS_INT is not the same width as void *.
1350 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1351 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1352 (current_message_1, set_message_1):
1353 Use a local to convert to proper width without a cast.
1354 * xmenu.c (dialog_selection_callback): Likewise.
1356 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1357 Also, don't assume VALBITS / RAND_BITS is less than 5,
1358 and don't rely on undefined behavior when shifting a 1 left into
1360 * lisp.h (get_random): Change signature to match.
1362 * lread.c (hash_string): Use size_t, not int, for hash computation.
1363 Normally we prefer signed values; but hashing is special, because
1364 it's better to use unsigned division on hash table sizes so that
1365 the remainder is nonnegative. Also, size_t is the natural width
1366 for hashing into memory. The previous code used 'int', which doesn't
1367 retain enough info to hash well into very large tables.
1368 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1370 * dbusbind.c: Don't possibly lose pointer info when converting.
1371 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1372 Use XPNTR rather than XHASH, so that the high-order bits of
1373 the pointer aren't lost when converting through void *.
1375 * eval.c (Fautoload): Don't double-shift a pointer.
1377 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1379 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1381 * gnutls.c (DEF_GNUTLS_FN):
1382 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1384 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1386 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1389 2011-05-05 Eli Zaretskii <eliz@gnu.org>
1391 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1392 New version that can reserve upto 2GB of heap space.
1394 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
1396 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1398 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1400 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1401 `gnutls_certificate_set_x509_key_file'.
1403 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
1405 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1406 Update dependencies.
1408 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1410 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1411 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1412 Remove unused parameter `fildes'.
1413 * process.c (read_process_output, send_process): Don't pass it.
1415 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1417 Fix previous change: the library cache is defined in w32.c.
1418 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1419 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1421 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1423 Implement dynamic loading of GnuTLS on Windows.
1425 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1426 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1427 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1430 * gnutls.c (Qgnutls_dll): Define.
1431 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1432 (gnutls_*): Declare function pointers.
1433 (init_gnutls_functions): New function to initialize function pointers.
1434 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1435 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1436 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1437 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1438 (emacs_gnutls_write, emacs_gnutls_read)
1439 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1440 (Fgnutls_available_p): New function.
1441 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1442 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1443 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1445 * image.c: Include w32.h.
1446 (Vimage_type_cache): Delete.
1447 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1448 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1449 (w32_delayed_load): Move to w32.c.
1451 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1453 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1454 (w32_delayed_load): Move from image.c. When loading a library, record
1455 its filename in the :loaded-from property of the library id.
1456 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1457 Initialize and staticpro them.
1458 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1460 * process.c: Include lisp.h before w32.h, not after.
1461 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1462 instead of gnutls_record_check_pending.
1464 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1466 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1468 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1469 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1472 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1474 * xterm.c (x_set_frame_alpha): Do not set property on anything
1475 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1477 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1479 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1481 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1483 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1484 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1485 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1486 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1487 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1488 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1489 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1490 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1491 (Qgnutls_bootprop_callbacks_verify): Make static.
1493 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1495 * callproc.c: Indentation fixup.
1497 * sysdep.c (wait_for_termination_1): Make static.
1498 (wait_for_termination, interruptible_wait_for_termination):
1499 Move after wait_for_termination_1.
1501 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1503 * sysdep.c (interruptible_wait_for_termination): New function
1504 which is like wait_for_termination, but allows keyboard
1507 * callproc.c (Fcall_process): Add (:file "file") as an option for
1509 (Fcall_process_region): Ditto.
1511 2011-04-30 Eli Zaretskii <eliz@gnu.org>
1513 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1514 rather than `XVECTOR (FOO)->size'.
1516 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1517 inttypes.h, as a gnulib replacement is used if it not available in
1520 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1522 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1523 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1524 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1526 * coding.c (coding_alloc_by_realloc): Error out if destination
1527 will grow beyond MOST_POSITIVE_FIXNUM.
1528 (decode_coding_emacs_mule): Abort if there isn't enough place in
1529 charbuf for the composition carryover bytes. Reserve an extra
1530 space for up to 2 characters produced in a loop.
1531 (decode_coding_iso_2022): Abort if there isn't enough place in
1532 charbuf for the composition carryover bytes.
1534 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1536 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1537 aborting when %lld or %lll format is passed.
1538 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1539 %llo or %llx format is passed. (Bug#8545)
1541 * window.c (window_scroll_line_based): Use a marker instead of
1542 simple variables to record original value of point. (Bug#7952)
1544 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1545 produced by %s or %c overflows available buffer space. (Bug#8545)
1547 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1549 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1550 (SIZE_MAX): Move defn after all includes, as they might #define it.
1552 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1554 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1556 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1558 * keyboard.c (Qdelayed_warnings_hook): Define.
1559 (command_loop_1): Run `delayed-warnings-hook'
1560 if Vdelayed_warnings_list is non-nil.
1561 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1562 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1564 2011-04-28 Eli Zaretskii <eliz@gnu.org>
1566 * doprnt.c (doprnt): Don't return value smaller than the buffer
1567 size if the message was truncated. (Bug#8545).
1569 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1571 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1572 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1574 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1576 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1578 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
1580 * makefile.w32-in: Update dependencies.
1582 2011-04-27 Eli Zaretskii <eliz@gnu.org>
1584 Improve `doprnt' and its usage. (Bug#8545)
1585 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1586 `format_end'. Remove support for %l as a conversion specifier.
1587 Don't use xrealloc. Improve diagnostics when the %l size modifier
1588 is used. Update the commentary.
1590 * eval.c (verror): Simplify calculation of size_t.
1592 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1595 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1597 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1600 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1602 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1603 This makes this file independent of the recent pseudovector change.
1605 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
1607 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1609 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
1610 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
1611 Remove unused local.
1612 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
1614 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
1615 GCC 4.6.0 optimizes based on type-based alias analysis.
1616 For example, if b is of type struct buffer * and v of type struct
1617 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1618 != &v->size, and therefore "v->size = 1; b->size = 2; return
1619 v->size;" must therefore return 1. This assumption is incorrect
1620 for Emacs, since it type-puns struct Lisp_Vector * with many other
1621 types. To fix this problem, this patch adds a new type struct
1622 vectorlike_header that documents the constraints on layout of vectors
1623 and pseudovectors, and helps optimizing compilers not get fooled
1624 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1625 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
1626 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1628 (XSETPVECTYPE): Rewrite in terms of new macro.
1629 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1630 This is a bit clearer, and further avoids the possibility of
1631 undesirable aliasing.
1632 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
1633 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
1634 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1635 since Lisp_Subr is a special case (no "next" field).
1636 (ASIZE): Now uses header.size rather than size.
1637 All previous uses of XVECTOR (foo)->size replaced to use this macro,
1638 to avoid the hassle of writing XVECTOR (foo)->header.size.
1639 (struct vectorlike_header): New type.
1640 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1641 object, to help avoid aliasing.
1642 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1643 (SUBRP): Likewise, since Lisp_Subr is a special case.
1644 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1645 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1646 (struct Lisp_Hash_Table): Combine first two members into a single
1647 struct vectorlike_header member. All uses of "size" and "next" members
1648 changed to be "header.size" and "header.next".
1649 * buffer.h (struct buffer): Likewise.
1650 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1651 * frame.h (struct frame): Likewise.
1652 * process.h (struct Lisp_Process): Likewise.
1653 * termhooks.h (struct terminal): Likewise.
1654 * window.c (struct save_window_data, struct saved_window): Likewise.
1655 * window.h (struct window): Likewise.
1656 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1657 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1658 * buffer.c (init_buffer_once): Likewise.
1659 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1661 * process.c (Fformat_network_address): Use local var for size,
1664 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1666 Make the Lisp reader and string-to-float more consistent (Bug#8525)
1667 * data.c (atof): Remove decl; no longer used or needed.
1668 (digit_to_number): Move to lread.c.
1669 (Fstring_to_number): Use new string_to_number function, to be
1670 consistent with how the Lisp reader treats infinities and NaNs.
1671 Do not assume that floating-point numbers represent EMACS_INT
1672 without losing information; this is not true on most 64-bit hosts.
1673 Avoid double-rounding errors, by insisting on integers when
1674 parsing non-base-10 numbers, as the documentation specifies.
1675 * lisp.h (string_to_number): New decl, replacing ...
1676 (isfloat_string): Remove.
1677 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
1678 (read1): Do not accept +. and -. as integers; this
1679 appears to have been a coding error. Similarly, do not accept
1680 strings like +-1e0 as floating point numbers. Do not report
1681 overflow for integer overflows unless the base is not 10 which
1682 means we have no simple and reliable way to continue.
1683 Break out the floating-point parsing into a new
1684 function string_to_number, so that Fstring_to_number parses
1685 floating point numbers consistently with the Lisp reader.
1686 (digit_to_number): Move here from data.c. Make it static inline.
1687 (E_CHAR, EXP_INT): Remove, replacing with ...
1688 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1689 (string_to_number): New function, replacing isfloat_string.
1690 This function checks for valid syntax and produces the resulting
1691 Lisp float number too. Rework it so that string-to-number
1692 no longer mishandles examples like "1.0e+". Use strtoumax,
1693 so that overflow for non-base-10 numbers is reported only when
1694 there's no portable and simple way to convert to floating point.
1696 * textprop.c (set_text_properties_1): Rewrite for clarity,
1697 and to avoid GCC warning about integer overflow.
1699 * intervals.h (struct interval): Use EMACS_INT for members
1700 where EMACS_UINT might cause problems. See
1701 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1702 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1703 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1705 (offset_intervals): Tell GCC not to worry about length overflow
1706 when negating a negative length.
1708 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1709 (overrun_check_free): Likewise.
1711 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1712 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1715 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1716 (gnutls_make_error): Rename local to avoid shadowing.
1717 (gnutls_emacs_global_deinit): ifdef out; not used.
1718 (Fgnutls_boot): Use const for pointer to readonly storage.
1719 Comment out unused local. Fix pointer signedness problems.
1721 * lread.c (openp): Don't stuff size_t into an 'int'.
1722 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1723 about possible signed overflow.
1725 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1726 (GDK_KEY_g): Don't define if already defined.
1727 (xg_prepare_tooltip): Avoid pointer signedness problem.
1728 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1730 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1731 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1733 * xfns.c (Fx_window_property): Simplify a bit,
1734 to make a bit faster and to avoid GCC 4.6.0 warning.
1735 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1737 * fns.c (internal_equal): Don't assume size_t fits in int.
1739 * alloc.c (compact_small_strings): Tighten assertion a little.
1741 Replace pEd with more-general pI, and fix some printf arg casts.
1742 * lisp.h (pI): New macro, generalizing old pEd macro to other
1743 conversion specifiers. For example, use "...%"pI"d..." rather
1744 than "...%"pEd"...".
1745 (pEd): Remove. All uses replaced with similar uses of pI.
1746 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1747 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1748 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1749 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1750 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1751 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1752 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1754 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1755 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1756 * print.c (safe_debug_print, print_object): Likewise.
1757 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1759 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1760 avoiding the 0 flag, which is not portable.
1761 * process.c (Fmake_network_process): Use pI to avoid cast.
1762 * region-cache.c (pp_cache): Likewise.
1763 * xdisp.c (decode_mode_spec): Likewise.
1764 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1765 behavior on 64-bit hosts with printf arg.
1766 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
1767 (x_stop_queuing_selection_requests): Likewise.
1768 (x_get_window_property): Don't truncate byte count to an 'int'
1771 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1772 here, since it parses constructs like leading '-' and spaces,
1773 which are not wanted; and it overflows with large numbers.
1774 Instead, simply match F[0-9]+, which is what is wanted anyway.
1776 * alloc.c: Remove unportable assumptions about struct layout.
1777 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1778 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1779 (allocate_vectorlike, make_pure_vector): Use the new macros,
1780 plus offsetof, to remove unportable assumptions about struct layout.
1781 These assumptions hold on all porting targets that I know of, but
1782 they are not guaranteed, they're easy to remove, and removing them
1783 makes further changes easier.
1785 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1786 This doesn't fix a bug but makes the code clearer.
1787 (string_overrun_cookie): Now const. Use initializers that
1788 don't formally overflow signed char, to avoid warnings.
1789 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1790 can cause Emacs to crash when string overrun checking is enabled.
1791 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1792 multiple of sizeof (EMACS_INT); it need not be, if
1793 alignof(EMACS_INT) < sizeof (EMACS_INT).
1794 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
1796 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
1798 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1800 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1802 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
1803 supposed to be handshaking. (Bug#8556)
1804 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1806 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
1808 * lisp.h (Qdebug): List symbol.
1809 * eval.c (Qdebug): Restore global linkage.
1810 * keyboard.c (debug-on-event): New variable.
1811 (handle_user_signal): Break into debugger when debug-on-event
1812 matches the current signal symbol.
1814 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1816 * alloc.c (check_sblock, check_string_bytes)
1817 (check_string_free_list): Convert to standard C.
1819 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1821 * w32.c (emacs_gnutls_push): Fix typo.
1823 2011-04-25 Eli Zaretskii <eliz@gnu.org>
1825 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1826 "cast to pointer from integer of different size".
1828 Improve doprnt and its use in verror. (Bug#8545)
1829 * doprnt.c (doprnt): Document the set of format control sequences
1830 supported by the function. Use SAFE_ALLOCA instead of always
1833 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1834 is one byte too soon. Don't use xrealloc; instead xfree and
1837 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1839 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1842 * gnutls.c: Renamed global_initialized to
1843 gnutls_global_initialized. Added internals for the
1844 :verify-hostname-error, :verify-error, and :verify-flags
1845 parameters of `gnutls-boot' and documented those parameters in the
1846 docstring. Start callback support.
1847 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1848 unless a fatal error occured. Call gnutls_alert_send_appropriate
1849 on error. Return error code.
1850 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1851 (emacs_gnutls_read): Likewise.
1852 (Fgnutls_boot): Return handshake error code.
1853 (emacs_gnutls_handle_error): New function.
1854 (wsaerror_to_errno): Likewise.
1856 * w32.h (emacs_gnutls_pull): Add prototype.
1857 (emacs_gnutls_push): Likewise.
1859 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1860 (emacs_gnutls_push): Likewise.
1862 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1864 * process.c (wait_reading_process_output): Check if GnuTLS
1865 buffered some data internally if no FDs are set for TLS
1868 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1869 (LIBS): Link to USER_LIBS.
1870 ($(BLD)/gnutls.$(0)): New target.
1872 2011-04-24 Eli Zaretskii <eliz@gnu.org>
1874 * xdisp.c (handle_single_display_spec): Rename the
1875 display_replaced_before_p argument into display_replaced_p, to
1876 make it consistent with the commentary. Fix typos in the
1879 * textprop.c (syms_of_textprop): Remove dead code.
1880 (copy_text_properties): Delete obsolete commentary about an
1881 interface that was deleted long ago. Fix typos in the description
1884 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1885 to changes in oldXMenu/XMenu.h from 2011-04-16.
1886 <menu_help_message, prev_menu_help_message>: Constify.
1887 (IT_menu_make_room): menu->help_text is now `const char **';
1890 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1891 to changes in oldXMenu/XMenu.h from 2011-04-16.
1892 (struct XMenu): Declare `help_text' `const char **'.
1894 * xfaces.c <Qunspecified>: Make extern again.
1896 * syntax.c: Include sys/types.h before including regex.h, as
1899 * doc.c (get_doc_string): Improve the format passed to `error'.
1901 * doprnt.c (doprnt): Improve commentary.
1903 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1905 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1908 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1909 changes in globals.h immediately force recompilation.
1910 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1911 $(CURDIR)/s/ms-w32.h.
1912 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
1914 * character.c (Fchar_direction): Function deleted.
1915 (syms_of_character): Don't defsubr it.
1916 <char-direction-table>: Deleted.
1918 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1920 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1921 * doprnt.c: Include limits.h.
1922 (SIZE_MAX): New macro.
1923 (doprnt): Return a size_t value. 2nd arg is now size_t.
1924 Many local variables are now size_t instead of int or unsigned.
1925 Improve overflow protection. Support `l' modifier for integer
1926 conversions. Support %l conversion. Don't assume an EMACS_INT
1927 argument for integer conversions and for %c.
1929 * lisp.h (doprnt): Restore prototype.
1931 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1934 * Makefile.in (base_obj): Add back doprnt.o.
1936 * deps.mk (doprnt.o): Add back prerequisites.
1937 (callint.o): Depend on character.h.
1939 * eval.c (internal_lisp_condition_case): Include the handler
1940 representation in the error message.
1941 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1942 when breaking from the loop.
1944 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1946 * callint.c (Fcall_interactively): When displaying error message
1947 about invalid control letter, pass the character's codepoint, not
1948 a pointer to its multibyte form. Improve display of the character
1949 in octal and display also its hex code.
1951 * character.c (char_string): Use %x to display the (unsigned)
1952 codepoint of an invalid character, to avoid displaying a bogus
1955 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1956 `error', not SYMBOL_NAME itself.
1958 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1959 character arguments to `error'.
1961 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1962 to `error' in error message about FINAL_CHAR argument. Make sure
1963 FINAL_CHAR is a character, and use %c when it is passed as
1964 argument to `error'.
1966 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1968 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1970 * w32.c: Include <time.h>.
1971 (sys_localtime): New function.
1973 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
1975 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1977 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
1979 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
1981 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1984 2011-04-19 Eli Zaretskii <eliz@gnu.org>
1986 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1987 gl_state.e_property when gl_state.object is Qt.
1989 * insdel.c (make_gap_larger): Remove limitation of buffer size
1992 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
1994 * xdisp.c (lookup_glyphless_char_display)
1995 (produce_glyphless_glyph): Handle cons cell entry in
1996 glyphless-char-display.
1997 (Vglyphless_char_display): Document it.
1999 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2000 glyphless-char-display.
2002 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
2004 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2006 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2008 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2009 definition for no-X builds.
2011 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
2013 Static checks with GCC 4.6.0 and non-default toolkits.
2015 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2017 * process.c (keyboard_bit_set): Define only if SIGIO.
2018 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2019 (send_process): Repair possible setjmp clobbering.
2021 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2023 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2025 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2027 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2028 Define only if needed.
2030 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2031 by pacifying GCC about it. Maybe it's time to retire it?
2032 * xfaces.c (USG, __TIMEVAL__): Likewise.
2034 * dispextern.h (struct redisplay_interface): Rename param
2036 * termhooks.h (struct terminal): Likewise.
2037 * xterm.c (xembed_send_message): Likewise.
2039 * insdel.c (make_gap_smaller): Define only if
2040 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2042 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2045 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2046 so that we aren't warned about unused symbols.
2048 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2050 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
2052 * xfns.c (x_real_positions): Mark locals as initialized.
2054 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2056 * xterm.c: Fix problems found by static analysis with other toolkits.
2057 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
2058 (x_dispatch_event): Declare static if USE_GTK, and
2059 define if USE_GTK || USE_X_TOOLKIT.
2060 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
2061 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
2062 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2063 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
2065 * xmenu.c (menu_help_callback): Pointer type fixes.
2066 Use const pointers when pointing at readonly data. Avoid pointer
2068 (FALSE): Remove unused macro.
2069 (update_frame_menubar): Remove unused decl.
2071 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2073 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2074 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2075 (single_menu_item): Rename local to avoid shadowing.
2077 * keyboard.c (make_lispy_event): Remove unused local var.
2079 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2080 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2082 * bitmaps: Change bitmaps from unsigned char back to the X11
2083 compatible char. Avoid the old compiler warnings about
2084 out-of-range initializers by using, for example, '\xab' rather
2087 * xgselect.c (xgselect_initialize): Check vs interface
2088 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2090 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2092 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2093 to read-only memory.
2095 * fns.c (vector): Remove; this old hack is no longer needed.
2097 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
2099 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2101 * xrdb.c (x_load_resources): Omit unused local.
2103 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
2104 (x_window): Rename locals to avoid shadowing.
2105 (USG): Use the kludged USG macro, to pacify gcc.
2107 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
2108 (x_term_init): Remove local to avoid shadowing.
2110 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
2112 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2113 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2115 2011-04-16 Eli Zaretskii <eliz@gnu.org>
2117 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2119 Fix regex.c, syntax.c and friends for buffers > 2GB.
2120 * syntax.h (struct gl_state_s): Declare character position members
2123 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2125 * textprop.c (verify_interval_modification, interval_of):
2126 Declare arguments EMACS_INT.
2128 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2131 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2133 * indent.c (Fvertical_motion): Local variable it_start is now
2136 * regex.c (re_match, re_match_2, re_match_2_internal)
2137 (bcmp_translate, regcomp, regexec, print_double_string)
2138 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2139 (re_compile_pattern, re_exec): Declare arguments and local
2140 variables `size_t' and `ssize_t' and return values `regoff_t', as
2142 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2143 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2144 <compile_stack_type>: `size' and `avail' are now `size_t'.
2146 * regex.h <regoff_t>: Use ssize_t, not int.
2147 (re_search, re_search_2, re_match, re_match_2): Arguments that
2148 specify buffer/string position and length are now ssize_t and
2149 size_t. Return type is regoff_t.
2151 2011-04-16 Ben Key <bkey76@gmail.com>
2153 * nsfont.m: Fixed bugs in ns_get_family and
2154 ns_descriptor_to_entity that were caused by using free to
2155 deallocate memory blocks that were allocated by xmalloc (via
2156 xstrdup). This caused Emacs to crash when compiled with
2157 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2158 --enable-checking=xmallocoverrun). xfree is now used to
2159 deallocate these memory blocks.
2161 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
2163 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2165 emacs_write: Accept and return EMACS_INT for sizes.
2166 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2168 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2169 Accept and return EMACS_INT.
2170 (emacs_gnutls_write): Return the number of bytes written on
2172 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
2173 (emacs_read, emacs_write): Remove check for negative size, as the
2174 Emacs source code has been audited now.
2175 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2176 (emacs_read, emacs_write): Use it.
2177 * process.c (send_process): Adjust to the new signatures of
2178 emacs_write and emacs_gnutls_write. Do not attempt to store
2179 a byte offset into an 'int'; it might overflow.
2180 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
2182 * sound.c: Don't assume sizes fit in 'int'.
2183 (struct sound_device.period_size, alsa_period_size):
2184 Return EMACS_INT, not int.
2185 (struct sound_device.write, vox_write, alsa_write):
2186 Accept EMACS_INT, not int.
2187 (wav_play, au_play): Use EMACS_INT to store sizes and to
2188 record read return values.
2190 2011-04-15 Ben Key <bkey76@gmail.com>
2192 * keyboard.c (Qundefined): Don't declare static since it is used
2194 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2195 static since they are used in nsfont.m.
2197 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2199 * process.c (Qprocessp): Don't declare static.
2200 * lisp.h (Qprocessp): Declare again.
2202 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
2204 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2206 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2208 Improve C-level modularity by making more things 'static'.
2210 Don't publish debugger-only interfaces to other modules.
2211 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2212 (verify_bytepos, count_markers): Move decls to the only modules
2214 * region-cache.h (pp_cache): Likewise.
2215 * window.h (check_all_windows): Likewise.
2216 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2218 * sysdep.c (croak): Now static, if
2219 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2220 * syssignal.h (croak): Declare only if not static.
2222 * alloc.c (refill_memory_reserve): Now static if
2223 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2224 * lisp.h (refill_memory_reserve): Declare only if not static.
2226 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2227 Define only if USE_LUCID.
2229 * xrdb.c (x_customization_string, x_rm_string): Now static.
2231 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2232 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2234 * xdisp.c (draw_row_with_mouse_face): Now static.
2235 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2237 * window.h (check_all_windows): Mark externally visible.
2239 * window.c (window_deletion_count): Now static.
2241 * undo.c: Make symbols static if they're not exported.
2242 (last_undo_buffer, last_boundary_position, pending_boundary):
2245 * textprop.c (interval_insert_behind_hooks): Now static.
2246 (interval_insert_in_front_hooks): Likewise.
2248 * term.c: Make symbols static if they're not exported.
2249 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2250 (max_frame_lines, tty_set_terminal_modes):
2251 (tty_reset_terminal_modes, tty_turn_off_highlight):
2252 (get_tty_terminal): Now static.
2253 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2254 * termhooks.h (term_mouse_moveto): Do not declare if
2256 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2257 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2259 * sysdep.c: Make symbols static if they're not exported.
2260 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2262 (sigprocmask_set, full_mask): Remove; unused.
2263 (wait_debugging): Mark as visible.
2264 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2265 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2267 * syntax.c (syntax_temp): Define only if !__GNUC__.
2269 * sound.c (current_sound_device, current_sound): Now static.
2271 * search.c (searchbufs, searchbuf_head): Now static.
2273 * scroll.c (scroll_cost): Remove; unused.
2274 * dispextern.h (scroll_cost): Remove decl.
2276 * region-cache.h (pp_cache): Mark as externally visible.
2278 * process.c: Make symbols static if they're not exported.
2279 (process_tick, update_tick, create_process, chan_process):
2280 (Vprocess_alist, proc_buffered_char, datagram_access):
2281 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2282 (deactivate_process): Mark defn as static, as well as decl.
2283 * lisp.h (create_process): Remove decl.
2284 * process.h (chan_process, Vprocess_alist): Remove decls.
2286 * print.c: Make symbols static if they're not exported.
2287 (print_depth, new_backquote_output, being_printed, print_buffer):
2288 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2289 (print_interval, print_number_index, initial_stderr_stream):
2291 * lisp.h (Fprinc): Remove decl.
2292 (debug_output_compilation_hack): Mark as externally visible.
2294 * sysdep.c (croak): Move decl from here to syssignal.h.
2295 * syssignal.h (croak): Put it here, so the API can be checked when
2296 'croak' is called from dissociate_if_controlling_tty.
2298 * minibuf.c: Make symbols static if they're not exported.
2299 (minibuf_save_list, choose_minibuf_frame): Now static.
2300 * lisp.h (choose_minibuf_frame): Remove decl.
2302 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2304 * lread.c: Make symbols static if they're not exported.
2305 (read_objects, initial_obarray, oblookup_last_bucket_number):
2307 (make_symbol): Remove; unused.
2308 * lisp.h (initial_obarray, make_symbol): Remove decls.
2310 * keyboard.c: Make symbols static if they're not exported.
2311 (single_kboard, recent_keys_index, total_keys, recent_keys):
2312 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2313 (this_single_command_key_start, echoing, last_auto_save):
2314 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2315 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2316 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2317 (Vlispy_mouse_stem, double_click_count):
2319 (force_auto_save_soon): Define only if SIGDANGER.
2320 (ignore_mouse_drag_p): Now static if
2321 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2322 (print_help): Remove; unused.
2323 (stop_character, last_timer_event): Mark as externally visible.
2324 * keyboard.h (ignore_mouse_drag_p): Declare only if
2325 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2326 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2327 * lisp.h (echoing): Remove decl.
2328 (force_auto_save_soon): Declare only if SIGDANGER.
2329 * xdisp.c (redisplay_window): Simplify code, to make it more
2330 obvious that ignore_mouse_drag_p is not accessed if !defined
2331 USE_GTK && !defined HAVE_NS.
2333 * intervals.c: Make symbols static if they're not exported.
2334 (merge_properties_sticky, merge_interval_right, delete_interval):
2336 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2338 * insdel.c: Make symbols static if they're not exported.
2339 However, leave prepare_to_modify_buffer alone. It's never
2340 called from outside this function, but that appears to be a bug.
2341 (combine_after_change_list, combine_after_change_buffer):
2342 (adjust_after_replace, signal_before_change): Now static.
2343 (adjust_after_replace_noundo): Remove; unused.
2344 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
2345 (signal_before_change): Remove decls.
2347 * indent.c (val_compute_motion, val_vmotion): Now static.
2349 * image.c: Make symbols static if they're not exported.
2350 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2352 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2353 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2355 * fringe.c (standard_bitmaps): Now static.
2356 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2358 * frame.c: Make symbols static if they're not exported.
2359 (x_report_frame_params, make_terminal_frame): Now static.
2360 (get_frame_param): Now static, unless HAVE_NS.
2361 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2362 (x_get_resource_string): Remove; not used.
2363 * frame.h (make_terminal_frame, x_report_frame_params):
2364 (x_get_resource_string); Remove decls.
2365 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2366 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2368 * font.c, fontset.c: Make symbols static if they're not exported.
2369 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2370 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2371 * font.c (font_close_object): Now static.
2372 * font.h (font_close_object): Remove.
2373 * fontset.c (FONTSET_OBJLIST): Remove.
2374 (free_realized_fontset) #if-0 the body, which does nothing.
2375 (face_suitable_for_char_p): #if-0, as it's never called.
2376 * fontset.h (face_suitable_for_char_p): Remove decl.
2377 * xfaces.c (face_at_string_position):
2378 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
2379 since 0 is always ASCII.
2381 * fns.c (weak_hash_tables): Now static.
2383 * fileio.c: Make symbols static if they're not exported.
2384 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2385 (Vwrite_region_annotation_buffers): Now static.
2387 * eval.c: Make symbols static if they're not exported.
2388 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2389 * lisp.h (backtrace_list): Remove decl.
2391 * emacs.c: Make symbols static if they're not exported.
2392 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2393 (fatal_error_code, fatal_error_signal_hook, standard_args):
2395 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2396 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2397 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2398 * lisp.h (fatal_error_signal_hook): Remove decl.
2399 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2401 * editfns.c: Move a (normally-unused) function to its only use.
2402 * editfns.c, lisp.h (get_operating_system_release): Remove.
2403 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2404 worth the hassle of breaking this out.
2406 * xterm.c: Make symbols static if they're not exported.
2407 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2408 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2409 (x_destroy_window, x_delete_display):
2411 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2412 (x_mouse_leave): Remove; unused.
2413 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2414 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2415 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2417 (x_mouse_leave): Declare only if WINDOWSNT.
2418 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2419 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2422 * ftxfont.c: Make symbols static if they're not exported.
2423 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2425 * font.h (ftxfont_driver): Likewise.
2427 * xfns.c: Make symbols static if they're not exported.
2428 (x_last_font_name, x_display_info_for_name):
2429 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2430 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2431 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2432 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2433 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2434 (last_show_tip_args): Now static.
2435 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2436 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2437 (x_screen_planes): Remove; unused.
2438 * dispextern.h (x_screen_planes): Remove decl.
2440 * dispnew.c: Make symbols static if they're not exported.
2441 * dispextern.h (redraw_garbaged_frames, scrolling):
2442 (increment_row_positions): Remove.
2443 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2444 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2446 (redraw_garbaged_frames): Remove; unused.
2448 * xfaces.c: Make symbols static if they're not exported.
2449 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2451 * xterm.h (defined_color): Remove decls.
2452 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2453 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2454 (menu_face_changed_default, defined_color, free_realized_face):
2455 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2456 (ascii_face_of_lisp_face): Remove; unused.
2458 * xdisp.c: Make symbols static if they're not exported.
2459 * dispextern.h (scratch_glyph_row, window_box_edges):
2460 (glyph_to_pixel_coords, set_cursor_from_row):
2461 (get_next_display_element, set_iterator_to_next):
2462 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2463 (show_mouse_face): Remove decls
2464 * frame.h (message_buf_print): Likewise.
2465 * lisp.h (pop_message, set_message, check_point_in_composition):
2467 * xterm.h (set_vertical_scroll_bar): Likewise.
2468 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2469 (message_buf_print, scratch_glyph_row, displayed_buffer):
2470 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2471 (get_next_display_element, show_mouse_face, window_box_edges):
2472 (frame_to_window_pixel_xy, check_point_in_composition):
2473 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2474 (glyph_to_pixel_coords): Remove; unused.
2476 * dired.c (file_name_completion): Now static.
2478 * dbusbind.c (xd_in_read_queued_messages): Now static.
2480 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2481 * data.c (circular_list_error): Remove.
2483 * commands.h (last_point_position, last_point_position_buffer):
2484 (last_point_position_window): Remove decls.
2485 * keyboard.c: Make these variables static.
2487 * coding.h (coding, code_convert_region, encode_coding_gap):
2489 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2490 (iso_code_class, detect_coding, code_convert_region): Now static.
2491 (encode_coding_gap): Remove; unused.
2493 * chartab.c (chartab_chars, chartab_bits): Now static.
2495 * charset.h (charset_iso_8859_1): Remove decl.
2496 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2499 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2500 * ccl.c (Vccl_program_table): Now static.
2501 (check_ccl_update): Remove; unused.
2503 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2504 * category.h: ... from here.
2505 * category.c (check_category_table, set_category_set): Now static.
2507 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2508 * lisp.h: Remove these decls.
2510 * buffer.c (buffer_count): Remove unused var.
2512 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2513 so that it's not optimized away.
2514 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2515 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2516 exported only to the debugger.
2518 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2519 * atimer.h (run_all_atimers): Remove; not exported.
2521 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2522 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2523 was inaccessible from Lisp.
2524 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2525 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2527 alloc.c: Import and export fewer symbols, and remove unused items.
2528 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2530 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2531 it's not optimized away by whole-program optimization.
2532 (message_enable_multibyte, free_misc): Remove.
2533 (catchlist, handlerlist, mark_backtrace):
2534 Declare only if BYTE_MARK_STACK.
2535 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2536 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2537 (message_enable_multibyte): Remove decl.
2538 (free_misc, interval_free_list, float_block, float_block_index):
2539 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2540 (cons_free_list, last_marked_index):
2542 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2543 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2544 (mark_backtrace): Define only if BYTE_MARK_STACK.
2545 * xdisp.c (message_enable_multibyte): Now static.
2547 Declare Lisp_Object Q* variables to be 'static' if not exported.
2548 This makes it easier for human readers (and static analyzers)
2549 to see whether these variables are used from other modules.
2550 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2551 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2552 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2553 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2554 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2555 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2556 * xmenu.c, xselect.c:
2557 Declare Q* vars static if they are not used in other modules.
2558 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2559 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2560 Remove decls of unexported vars.
2561 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2563 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2565 Make Emacs functions such as Fatom 'static' by default.
2566 This makes it easier for human readers (and static analyzers)
2567 to see whether these functions can be called from other modules.
2568 DEFUN now defines a static function. To make the function external
2569 so that it can be used in other C modules, use the new macro DEFUE.
2570 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2571 (Finit_image_library):
2572 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2573 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2574 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2575 Remove decls, since these functions are now static.
2576 (Funintern, Fget_internal_run_time): New decls, since these functions
2577 were already external.
2579 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2580 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2581 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2582 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2583 * keyboard.c, keymap.c, lread.c:
2584 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2585 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2586 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2587 Mark functions with DEFUE instead of DEFUN,
2588 if they are used in other modules.
2589 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2590 decls for now-static functions.
2591 * buffer.h (Fdelete_overlay): Remove decl.
2592 * callproc.c (Fgetenv_internal): Mark as internal.
2593 * composite.c (Fremove_list_of_text_properties): Remove decl.
2594 (Fcomposition_get_gstring): New forward static decl.
2595 * composite.h (Fcomposite_get_gstring): Remove decl.
2596 * dired.c (Ffile_attributes): New forward static decl.
2597 * doc.c (Fdocumntation_property): New forward static decl.
2598 * eval.c (Ffetch_bytecode): New forward static decl.
2599 (Funintern): Remove extern decl; now in .h file where it belongs.
2600 * fileio.c (Fmake_symbolic_link): New forward static decl.
2601 * image.c (Finit_image_library): New forward static decl.
2602 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2603 * intervals.h (Fprevious_property_change):
2604 (Fremove_list_of_text_properties): Remove decls.
2605 * keyboard.c (Fthis_command_keys): Remove decl.
2606 (Fcommand_execute): New forward static decl.
2607 * keymap.c (Flookup_key): New forward static decl.
2608 (Fcopy_keymap): Now static.
2609 * keymap.h (Flookup_key): Remove decl.
2610 * process.c (Fget_process): New forward static decl.
2611 (Fprocess_datagram_address): Mark as internal.
2612 * syntax.c (Fsyntax_table_p): New forward static decl.
2613 (skip_chars): Remove duplicate decl.
2614 * textprop.c (Fprevious_property_change): New forward static decl.
2615 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2617 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2618 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2620 * editfns.c (Fformat): Remove unreachable code.
2622 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2624 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2627 2011-04-13 Eli Zaretskii <eliz@gnu.org>
2629 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2630 when at ZV. (Bug#8487)
2632 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2634 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2636 * keyboard.c (parse_tool_bar_item): Likewise.
2637 * sound.c (sound_cleanup, alsa_close): Likewise.
2638 * termcap.c (tgetent): Likewise.
2639 * xfns.c (x_default_font_parameter): Likewise.
2640 * xsettings.c (read_and_apply_settings): Likewise.
2642 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2643 (overrun_check_free): Protoize.
2645 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2647 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2648 since callers should never pass a negative size.
2649 Change the signature to match that of plain 'read' and 'write'; see
2650 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2651 * lisp.h: Update prototypes of emacs_write and emacs_read.
2653 2011-04-11 Eli Zaretskii <eliz@gnu.org>
2655 * xdisp.c (redisplay_window): Don't try to determine the character
2656 position of the scroll margin if the window start point w->startp
2657 is outside the buffer's accessible region. (Bug#8468)
2659 2011-04-10 Eli Zaretskii <eliz@gnu.org>
2661 Fix write-region and its subroutines for buffers > 2GB.
2662 * fileio.c (a_write, e_write): Modify declaration of arguments and
2663 local variables to support buffers larger than 2GB.
2664 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2666 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2667 argument, local variables, and return value.
2669 * lisp.h: Update prototypes of emacs_write and emacs_read.
2671 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2673 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
2675 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2677 Fix more problems found by GCC 4.6.0's static checks.
2679 * xdisp.c (vmessage): Use a better test for character truncation.
2681 * charset.c (load_charset_map): <, not <=, for optimization,
2682 and to avoid potential problems with integer overflow.
2683 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
2684 * casetab.c (set_identity, shuffle): Likewise.
2685 * editfns.c (Fformat): Likewise.
2686 * syntax.c (skip_chars): Likewise.
2688 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2689 This also lets GCC 4.6.0 generate slightly better loop code.
2691 * callint.c (Fcall_interactively): <, not <=, for optimization.
2692 (Fcall_interactively): Count the number of arguments produced,
2693 not the number of arguments given. This is simpler and lets GCC
2694 4.6.0 generate slightly better code.
2696 * ftfont.c: Distingish more carefully between FcChar8 and char.
2697 The previous code passed unsigned char * to a functions like
2698 strlen and xstrcasecmp that expect char *, which does not
2699 conform to the C standard.
2700 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2701 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2702 char * when the C standard requires it.
2704 * keyboard.c (read_char): Remove unused var.
2706 * eval.c: Port to Windows vsnprintf (Bug#8435).
2708 (SIZE_MAX): Define if the headers do not.
2709 (verror): Do not give up if vsnprintf returns a negative count.
2710 Instead, grow the buffer. This ports to Windows vsnprintf, which
2711 does not conform to C99. Problem reported by Eli Zaretskii.
2712 Also, simplify the allocation scheme, by avoiding the need for
2713 calling realloc, and removing the ALLOCATED variable.
2715 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2717 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2718 But keep the doprint source code for now, as we might revamp it
2719 and use it again (Bug#8435).
2720 * lisp.h (doprnt): Remove.
2721 * Makefile.in (base_obj): Remove doprnt.o.
2722 * deps.mk (doprnt.o): Remove.
2724 error: Print 32- and 64-bit integers portably (Bug#8435).
2725 Without this change, on typical 64-bit hosts error ("...%d...", N)
2726 was used to print both 32- and 64-bit integers N, which relied on
2728 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2730 * lisp.h (error, verror): Mark as printf-like functions.
2731 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2732 Report overflow in size calculations when allocating printf buffer.
2733 Do not truncate output string at its first null byte.
2734 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2735 Truncate the output at a character boundary, since vsnprintf does not
2737 * charset.c (check_iso_charset_parameter): Convert internal
2738 character to string before calling 'error', since %c now has the
2740 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2741 overflow when computing char to be passed to 'error'. Do not
2742 pass Lisp_Object to 'error'; pass the integer instead.
2743 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2744 formatted with plain %d.
2746 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2748 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2750 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2752 * xterm.c (x_catch_errors): Remove duplicate declaration.
2754 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2756 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2758 2011-04-10 Jim Meyering <meyering@redhat.com>
2760 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2761 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2762 return ssize_t not "int", and use size_t as the buffer length.
2763 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2764 * gnutls.h: Update declarations.
2765 * process.c (read_process_output): Use ssize_t, to match.
2766 (send_process): Likewise.
2768 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2770 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2772 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2774 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2775 Use unsigned char, to match FcChar8 type definition.
2777 * xterm.c (handle_one_xevent):
2778 * xmenu.c (create_and_show_popup_menu):
2779 * xselect.c (x_decline_selection_request)
2780 (x_reply_selection_request): Avoid type-punned deref of X events.
2782 2011-04-09 Eli Zaretskii <eliz@gnu.org>
2784 Fix some uses of `int' instead of EMACS_INT.
2785 * search.c (string_match_1, fast_string_match)
2786 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2787 (scan_buffer, find_next_newline_no_quit)
2788 (find_before_next_newline, search_command, Freplace_match)
2789 (Fmatch_data): Make some `int' variables be EMACS_INT.
2791 * xdisp.c (display_count_lines): 3rd argument and return value now
2792 EMACS_INT. All callers changed.
2793 (pint2hrstr): Last argument is now EMACS_INT.
2795 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2796 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2797 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2798 (decode_coding_utf_16, decode_coding_emacs_mule)
2799 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2800 (decode_coding_ccl, decode_coding_charset)
2801 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2802 (decode_coding_iso_2022, decode_coding_emacs_mule)
2803 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2804 <char_offset, last_offset>: Declare EMACS_INT.
2805 (encode_coding_utf_8, encode_coding_utf_16)
2806 (encode_coding_emacs_mule, encode_invocation_designation)
2807 (encode_designation_at_bol, encode_coding_iso_2022)
2808 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2809 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2811 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2812 (encode_invocation_designation): Last argument P_NCHARS is now
2814 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2815 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2817 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2820 * ccl.c (Fccl_execute_on_string): Declare some variables
2823 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
2825 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2827 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2829 * process.c (Fformat_network_address): Doc fix.
2831 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2833 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2835 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
2837 * keyboard.c (read_char): Call Lisp function help-form-show,
2838 instead of using internal_with_output_to_temp_buffer.
2839 (Qhelp_form_show): New var.
2840 (syms_of_keyboard): Use DEFSYM macro.
2842 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2844 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2846 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
2848 * process.c (Flist_processes): Remove to Lisp.
2849 (list_processes_1): Delete.
2851 2011-04-06 Eli Zaretskii <eliz@gnu.org>
2853 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2855 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2857 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
2859 Fix more problems found by GCC 4.6.0's static checks.
2861 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2863 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2865 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
2867 * xdisp.c (vmessage): Mark as a printf-like function.
2869 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2871 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2873 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2874 printf-like functions.
2875 (tiff_load): Add casts to remove these marks before passing them
2876 to system-supplied API.
2878 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2880 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2881 This avoids several warnings with gcc -Wstrict-overflow.
2882 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2883 directly, rather than having caller test rule sign. This avoids
2884 some unnecessary tests.
2885 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2886 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2887 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
2889 * xfont.c (xfont_text_extents): Remove var that was set but not used.
2890 (xfont_open): Avoid unnecessary tests.
2892 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2894 * composite.h, composite.c (composition_gstring_put_cache):
2895 Use EMACS_INT, not int, for length.
2897 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2898 breaking out part of COMPOSITION_DECODE_RULE.
2899 (COMPOSITION_DECODE_RULE): Use it.
2900 * composite.c (get_composition_id): Remove unused local vars,
2901 by using the new macro.
2903 * textprop.c (set_text_properties_1): Change while to do-while,
2904 since the condition is always true at first.
2906 * intervals.c (graft_intervals_into_buffer): Mark var as used.
2907 (interval_deletion_adjustment): Return unsigned value.
2910 * process.c (list_processes_1, create_pty, read_process_output):
2911 (exec_sentinel): Remove vars that were set but not used.
2912 (create_pty): Remove unnecessary "volatile"s.
2913 (Fnetwork_interface_info): Avoid possibility of int overflow.
2914 (read_process_output): Do adaptive read buffering even if carryover.
2915 (read_process_output): Simplify nbytes computation if buffered.
2917 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2919 * syntax.c (scan_words): Remove var that was set but not used.
2920 (update_syntax_table): Use unsigned instead of int.
2922 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
2923 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
2924 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
2926 * print.c (print_error_message): Avoid int overflow.
2928 * font.c (font_list_entities): Redo for clarity,
2929 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2931 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
2932 (font_score): Avoid potential overflow in diff calculation.
2934 * fns.c (substring_both): Remove var that is set but not used.
2935 (sxhash): Redo loop for clarity and to avoid wraparound warning.
2937 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2939 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2940 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2941 can always succeed if overflow has undefined behavior.
2943 * search.c (boyer_moore, wordify): Remove vars set but not used.
2944 (wordify): Omit three unnecessary tests.
2946 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2947 All callers changed. This avoids the need for an unused var.
2949 * casefiddle.c (casify_region): Remove var that is set but not used.
2951 * dired.c (file_name_completion): Remove var that is set but not used.
2953 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2955 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
2956 (Finsert_file_contents): Remove unnecessary code checking fd.
2958 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2959 Check for integer overflow on size calculations.
2961 * buffer.c (Fprevious_overlay_change): Remove var that is set
2964 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2965 Remove vars that are set but not used.
2966 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
2967 (timer_check_2): Mark vars as initialized.
2969 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2971 * image.c (lookup_image): Remove var that is set but not used.
2972 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
2974 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2975 that are set but not used.
2977 * xfns.c (make_invisible_cursor): Don't return garbage
2978 if XCreateBitmapFromData fails (Bug#8410).
2980 * xselect.c (x_get_local_selection, x_handle_property_notify):
2981 Remove vars that are set but not used.
2983 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
2984 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
2986 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2987 Remove var that is set but not used.
2988 (scroll_bar_windows_size): Now size_t, not int.
2989 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2992 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2993 (map_tty_color) [!defined MSDOS]: Likewise.
2995 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2997 * coding.c: Remove vars that are set but not used.
2998 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2999 All callers changed.
3000 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3001 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3002 (decode_coding_charset): Remove vars that are set but not used.
3004 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3005 that is set but not used.
3007 * print.c (print_object): Remove var that is set but not used.
3009 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
3010 The gnulib version avoids calling malloc in the usual case,
3011 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3012 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3013 * filelock.c (current_lock_owner): Likewise.
3014 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3015 * sysdep.c: Include allocator.h, careadlinkat.h.
3016 (emacs_no_realloc_allocator): New static constant.
3017 (emacs_readlink): New function.
3018 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3019 ../lib/careadlinkat.h.
3021 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3023 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3024 first non-nil return value).
3026 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3028 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3029 if not defined (Bug#8403).
3031 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3033 * xdisp.c (display_count_lines): Remove parameter `start',
3034 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3035 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3036 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3037 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3038 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3039 and thereabouts. All callers changed.
3040 (get_per_char_metric): Remove parameter `f', unused since
3041 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3043 2011-04-02 Jim Meyering <meyering@redhat.com>
3045 do not dereference NULL upon failed strdup
3046 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3047 (ns_get_family): Likewise.
3049 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3051 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3053 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3055 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3058 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3060 Add lexical binding.
3062 * window.c (Ftemp_output_buffer_show): New fun.
3063 (Fsave_window_excursion):
3064 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3066 * lread.c (lisp_file_lexically_bound_p): New function.
3067 (Fload): Bind Qlexical_binding.
3068 (readevalloop): Remove `evalfun' arg.
3069 Bind Qinternal_interpreter_environment.
3070 (Feval_buffer): Bind Qlexical_binding.
3071 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3073 (syms_of_lread): Declare `lexical-binding'.
3075 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3077 * keyboard.c (eval_dyn): New fun.
3078 (menu_item_eval_property): Use it.
3080 * image.c (parse_image_spec): Use Ffunctionp.
3082 * fns.c (concat, mapcar1): Accept byte-code-functions.
3084 * eval.c (Fsetq): Handle lexical vars.
3085 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3086 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3087 (FletX, Flet): Obey lexical binding.
3088 (Fcommandp): Handle closures.
3089 (Feval): New `lexical' arg.
3090 (eval_sub): New function extracted from Feval. Use it almost
3091 everywhere where Feval was used. Look up vars in lexical env.
3093 (Ffunctionp): Move from subr.el.
3094 (Ffuncall): Handle closures.
3095 (apply_lambda): Remove `eval_flags'.
3096 (funcall_lambda): Handle closures and new byte-code-functions.
3097 (Fspecial_variable_p): New function.
3098 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3099 but without exporting it to Lisp.
3101 * doc.c (Fdocumentation, store_function_docstring):
3102 * data.c (Finteractive_form): Handle closures.
3104 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3107 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3109 (exec_byte_code): New function extracted from Fbyte_code to handle new
3110 calling convention for byte-code-functions. Add new byte-codes.
3112 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
3114 * alloc.c (Fmake_symbol): Init new `declared_special' field.
3116 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3118 * xdisp.c (redisplay_internal): Fix prototype.
3120 2011-03-31 Eli Zaretskii <eliz@gnu.org>
3122 * xdisp.c (SCROLL_LIMIT): New macro.
3123 (try_scrolling): Use it when setting scroll_limit.
3124 Limit scrolling to 100 screen lines.
3125 (redisplay_window): Even when falling back on "recentering",
3126 position point in the window according to scroll-conservatively,
3127 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3129 (try_scrolling): When point is above the window, allow searching
3130 as far as scroll_max, or one screenful, to compute vertical
3131 distance from PT to the scroll margin position. This prevents
3132 try_scrolling from unnecessarily failing when
3133 scroll-conservatively is set to a value slightly larger than the
3134 window height. Clean up the case of PT below the margin at bottom
3135 of window: scroll_max can no longer be INT_MAX. When aggressive
3136 scrolling is in use, don't let point enter the opposite scroll
3137 margin as result of the scroll.
3138 (syms_of_xdisp) <scroll-conservatively>: Document the
3139 threshold of 100 lines for never-recentering scrolling.
3141 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3143 * dispextern.h (move_it_by_lines):
3144 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3145 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3146 (message_log_check_duplicate): Remove parameters `prev_bol' and
3147 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3148 (redisplay_internal): Remove parameter `preserve_echo_area',
3149 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3151 * indent.c (Fvertical_motion):
3152 * window.c (window_scroll_pixel_based, Frecenter):
3153 Don't pass `need_y_p' to `move_it_by_lines'.
3155 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3157 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3158 steal a few bits to be more compact.
3159 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3160 Remove unneeded casts.
3162 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3164 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3166 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3167 binding" message (bug#7967).
3169 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3171 Fix more problems found by GCC 4.6.0's static checks.
3173 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3174 Remove unused local var.
3176 * editfns.c (Fmessage_box): Remove unused local var.
3178 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3179 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3180 Omit unused local vars.
3181 * window.c (shrink_windows): Omit unused local var.
3182 * menu.c (digest_single_submenu): Omit unused local var.
3183 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3184 Omit unused local var.
3186 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3187 Don't assume string length fits in int.
3188 (keyremap_step, read_key_sequence): Use size_t for sizes.
3189 (read_key_sequence): Don't check last_real_key_start redundantly.
3191 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3192 instead of alloca (Bug#8344).
3194 * eval.c (Fbacktrace): Don't assume nargs fits in int.
3195 (Fbacktrace_frame): Don't assume nframes fits in int.
3197 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3199 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3202 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3204 * cm.c (calccost): Turn while-do into do-while, for clarity.
3206 * keyboard.c (syms_of_keyboard): Use the same style as later
3207 in this function when indexing through an array. This also
3208 works around GCC bug 48267.
3210 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3212 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3214 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3215 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3217 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3218 This avoids undefined behavior on integer overflow, and is a bit
3219 more convenient anyway since it is compared to a size_t variable.
3221 Variadic C functions now count arguments with size_t, not int.
3222 This avoids an unnecessary limitation on 64-bit machines, which
3223 caused (substring ...) to crash on large vectors (Bug#8344).
3224 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3225 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
3226 All variadic functions and their callers changed accordingly.
3227 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3228 * data.c (arith_driver, float_arith_driver): Likewise.
3229 * editfns.c (general_insert_function): Likewise.
3230 * eval.c (struct backtrace.nargs, interactive_p)
3231 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3232 (funcall_lambda, mark_backtrace): Likewise.
3233 * fns.c (concat): Likewise.
3234 * frame.c (x_set_frame_parameters): Likewise.
3235 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3236 0 if not found, not -1. All callers changed.
3238 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3239 (stack_copy_size): Now size_t, not int.
3240 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3242 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3244 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3245 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3246 All callers changed.
3248 * lisp.h (multibyte_char_to_unibyte):
3249 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3250 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3251 * character.h (CHAR_TO_BYTE8):
3252 * cmds.c (internal_self_insert):
3253 * editfns.c (general_insert_function):
3254 * keymap.c (push_key_description):
3255 * search.c (Freplace_match):
3256 * xdisp.c (message_dolog, set_message_1): All callers changed.
3258 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3260 * keyboard.c (safe_run_hook_funcall): New function.
3261 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3262 don't set the hook to nil, but remove the offending function instead.
3263 (Qcommand_hook_internal): Remove, unused.
3264 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3265 Vcommand_hook_internal.
3267 * eval.c (enum run_hooks_condition): Remove.
3268 (funcall_nil, funcall_not): New functions.
3269 (run_hook_with_args): Call each function through a `funcall' argument.
3270 Remove `cond' argument, now redundant.
3271 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3272 (Frun_hook_with_args_until_failure): Adjust accordingly.
3273 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3275 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3277 * dispextern.h (string_buffer_position): Remove declaration.
3279 * print.c (strout): Remove parameter `multibyte', unused since
3280 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3282 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3283 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3284 All callers changed.
3286 * w32.c (_wsa_errlist): Use braces for struct initializers.
3288 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3289 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3290 All callers changed.
3291 (string_buffer_position): Likewise. Also, make static (it's never
3292 used outside xdisp.c).
3293 (cursor_row_p): Remove parameter `w', unused since
3294 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3295 (decode_mode_spec): Remove parameter `precision', introduced during
3296 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3297 All callers changed.
3299 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3301 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3303 2011-03-27 Anders Lindgren <andlind@gmail.com>
3305 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3306 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3307 (ns_update_auto_hide_menu_bar): New functions.
3308 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3309 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3310 ns_constrain_all_frames.
3311 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3312 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3314 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3316 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3318 2011-03-27 Glenn Morris <rgm@gnu.org>
3320 * syssignal.h: Replace RETSIGTYPE with void.
3321 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3322 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3323 Replace SIGTYPE with void everywhere.
3324 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3325 * s/template.h (SIGTYPE): Remove commented out definition.
3327 2011-03-26 Eli Zaretskii <eliz@gnu.org>
3329 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3330 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3332 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
3334 * w32.c (read_unc_volume): Use parameter `henum', instead of
3335 global variable `wget_enum_handle'.
3337 * keymap.c (describe_vector): Remove parameters `indices' and
3338 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3339 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3341 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3343 * keyboard.c (timer_check): Remove parameter `do_it_now',
3344 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3345 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3346 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3348 * keyboard.c (read_char):
3349 * w32menu.c (w32_menu_display_help):
3350 * xmenu.c (show_help_event, menu_help_callback):
3351 Adjust calls to `show_help_echo'.
3353 * gtkutil.c (xg_maybe_add_timer):
3354 * keyboard.c (readable_events):
3355 * process.c (wait_reading_process_output):
3356 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3358 * insdel.c (adjust_markers_gap_motion):
3359 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3360 (gap_left, gap_right): Don't call it.
3362 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
3364 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3365 incurred during fontification.
3367 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3369 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3370 (DEFVAR_PER_BUFFER): Don't pass it.
3372 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3373 (scrolling_window): Don't pass it.
3375 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3377 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3379 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3381 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3382 of variables specific to SELinux and computation of `encoded_absname'.
3384 * image.c (XPutPixel): Remove unused variable `height'.
3386 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3388 * unexw32.c (get_section_info): Remove unused variable `section'.
3390 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3391 (system_process_attributes): Remove unused variable `sess'.
3392 (sys_read): Remove unused variable `err'.
3394 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3395 (w32_wnd_proc): Remove unused variable `isdead'.
3396 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3397 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3398 (x_create_tip_frame): Remove unused variable `tem'.
3400 * w32inevt.c (w32_console_read_socket):
3401 Remove unused variable `no_events'.
3403 * w32term.c (x_draw_composite_glyph_string_foreground):
3404 Remove unused variable `width'.
3406 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
3408 * w32term.c (x_set_glyph_string_clipping):
3409 Don't pass uninitialized region to CombineRgn.
3411 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
3413 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3414 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3415 (Fx_close_connection): Remove unused variable `i'.
3417 * w32font.c (w32font_draw): Return number of glyphs.
3418 (w32font_open_internal): Remove unused variable `i'.
3419 (w32font_driver): Add missing initializer.
3421 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3422 (fill_in_menu): Remove unused variable `items_added'.
3424 * w32term.c (last_mouse_press_frame): Remove static global variable.
3425 (w32_clip_to_row): Remove unused variable `f'.
3426 (x_delete_terminal): Remove unused variable `i'.
3428 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3429 (NOTHING): Remove unused static global variable.
3430 (uniscribe_check_otf): Remove unused variable `table'.
3431 (uniscribe_font_driver): Add missing initializers.
3433 2011-03-23 Julien Danjou <julien@danjou.info>
3435 * term.c (Fsuspend_tty, Fresume_tty):
3436 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3437 * window.c (temp_output_buffer_show):
3438 * insdel.c (signal_before_change):
3439 * frame.c (Fhandle_switch_frame):
3440 * fileio.c (Fdo_auto_save):
3441 * emacs.c (Fkill_emacs):
3442 * editfns.c (save_excursion_restore):
3443 * cmds.c (internal_self_insert):
3444 * callint.c (Fcall_interactively):
3445 * buffer.c (Fkill_all_local_variables):
3446 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3448 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
3449 unconditionnaly since it does the check itself.
3451 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
3453 Fix more problems found by GCC 4.5.2's static checks.
3455 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3456 the first time through the loop, since we know p0 < p1 then.
3457 This also avoids a gcc -Wstrict-overflow warning.
3459 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3460 leading to a memory leak, possible in functions like
3461 load_charset_map_from_file that can allocate an unbounded number
3462 of objects (Bug#8318).
3464 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3465 that could (at least in theory) be that large.
3467 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3468 This is less likely to overflow, and avoids undefined behavior if
3469 overflow does occur. All callers changed. Use strtoul to scan
3470 for the unsigned long integer.
3471 (pint2hrstr): Simplify and tune code slightly.
3472 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
3474 * scroll.c (do_scrolling): Work around GCC bug 48228.
3475 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3477 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3478 This also avoids a warning with gcc -Wstrict-overflow.
3479 (validate_x_resource_name): Simplify count usage.
3480 This also avoids a warning with gcc -Wstrict-overflow.
3482 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3485 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
3487 * process.c (Fmake_network_process): Use socklen_t, not int,
3488 where POSIX says socklen_t is required in portable programs.
3489 This fixes a porting bug on hosts like 64-bit HP-UX, where
3490 socklen_t is wider than int (Bug#8277).
3491 (Fmake_network_process, server_accept_connection):
3492 (wait_reading_process_output, read_process_output):
3495 * process.c: Rename or move locals to avoid shadowing.
3496 (list_processes_1, Fmake_network_process):
3497 (read_process_output_error_handler, exec_sentinel_error_handler):
3498 Rename or move locals.
3499 (Fmake_network_process): Define label "retry_connect" only if needed.
3500 (Fnetwork_interface_info): Fix pointer signedness.
3501 (process_send_signal): Add cast to avoid pointer signedness problem.
3502 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
3503 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
3505 Make tparam.h and terminfo.c consistent.
3506 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3507 Include tparam.h instead, since it declares them.
3508 * cm.h (PC): Remove extern decl; tparam.h now does this.
3509 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3510 * terminfo.c: Include tparam.h, to check interfaces.
3511 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3512 (tparam): Adjust signature to match interface in tparam.h;
3513 this removes some undefined behavior. Check that outstring and len
3514 are zero, which they always are with Emacs.
3515 * tparam.h (PC, BC, UP): New extern decls.
3517 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3518 (xftfont_open): Rename locals to avoid shadowing.
3520 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3521 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3522 (OTF_TAG_SYM): Omit macro if not needed.
3523 (ftfont_list): Remove unused local.
3524 (get_adstyle_property, ftfont_pattern_entity):
3525 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3526 Rename locals to avoid shadowing.
3528 * xfont.c (xfont_list_family): Mark var as initialized.
3530 * xml.c (make_dom): Now static.
3532 * composite.c (composition_compute_stop_pos): Rename local to
3534 (composition_reseat_it): Remove unused locals.
3535 (find_automatic_composition, composition_adjust_point): Likewise.
3536 (composition_update_it): Mark var as initialized.
3537 (find_automatic_composition): Mark vars as initialized,
3538 with a FIXME (Bug#8290).
3540 character.h: Rename locals to avoid shadowing.
3541 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3542 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3543 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3544 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3547 * textprop.c (property_change_between_p): Remove; unused.
3549 * intervals.c (interval_start_pos): Now static.
3551 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3553 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3554 Rename locals to avoid shadowing.
3556 * sound.c (wav_play, au_play, Fplay_sound_internal):
3557 Fix pointer signedness.
3558 (alsa_choose_format): Remove unused local var.
3559 (wav_play): Initialize a variable to 0, to prevent undefined
3560 behavior (Bug#8278).
3562 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3564 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3566 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3567 clobbering (Bug#8298).
3568 * sysdep.c (sys_subshell): Likewise.
3569 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
3571 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3572 This should get cleaned up, so that child_setup has the
3573 same signature on all platforms.
3575 * callproc.c (call_process_cleanup): Now static.
3576 (relocate_fd): Rename locals to avoid shadowing.
3578 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
3580 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3581 not to be necessary, and produces flickering.
3583 2011-03-20 Glenn Morris <rgm@gnu.org>
3585 * config.in: Remove file.
3587 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
3589 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3590 are now in src/globals.h.
3591 (syms_of_minibuf): Remove spurious & from previous change.
3593 2011-03-20 Leo <sdl.web@gmail.com>
3595 * minibuf.c (completing-read-function): New variable.
3596 (completing-read-default): Rename from completing-read.
3597 (completing-read): Call completing-read-function.
3599 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3601 * xfaces.c (Fx_load_color_file):
3602 Read color file from absolute filename (bug#8250).
3604 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3606 * makefile.w32-in: Update dependencies.
3608 2011-03-17 Eli Zaretskii <eliz@gnu.org>
3610 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3612 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3614 Fix more problems found by GCC 4.5.2's static checks.
3616 * process.c (make_serial_process_unwind, send_process_trap):
3617 (sigchld_handler): Now static.
3619 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3620 That way, the code declares only the vars that it needs.
3621 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3622 * s/cygwin.h (PTY_ITERATION): Likewise.
3623 * s/darwin.h (PTY_ITERATION): Likewise.
3624 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3626 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3627 * process.c (allocate_pty): Don't declare stb unless it's needed.
3629 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
3630 (CONSTANTLIM): Remove; unused.
3631 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3632 Define only if needed.
3634 * unexelf.c (unexec): Name an expression,
3635 to avoid gcc -Wbad-function-cast warning.
3636 Use a different way to cause a compilation error if anyone uses
3637 n rather than nn, a way that does not involve shadowing.
3638 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
3640 * deps.mk (unexalpha.o): Remove; unused.
3642 New file unexec.h, the (simple) interface for unexec (Bug#8267).
3643 * unexec.h: New file.
3644 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3645 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3647 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3648 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3649 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
3650 Change as necessary to match prototype in unexec.h.
3652 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3654 (back_comment, skip_chars): Mark vars as initialized.
3656 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3657 Rename locals to avoid shadowing.
3659 * lread.c (read1): Rewrite so as not to use empty "else".
3660 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
3662 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3664 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3665 warning when compiling print.c.
3667 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3668 instead of using an uninitialized var.
3669 (font_sort_entities): Mark var as initialized.
3671 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3673 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3674 pointers to constants.
3675 (font_parse_fcname): Remove unused vars.
3676 (font_delete_unmatched): Now static.
3677 (font_get_spec): Remove; unused.
3678 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3679 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3680 Rename or move locals to avoid shadowing.
3682 * fns.c (require_nesting_list, require_unwind): Now static.
3683 (Ffillarray): Rename locals to avoid shadowing.
3685 * floatfns.c (domain_error2): Define only if needed.
3686 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
3688 * alloc.c (mark_backtrace): Move decl from here ...
3689 * lisp.h: ... to here, so that it can be checked.
3691 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
3692 (Fdefvar): Rewrite so as not to use empty "else".
3693 (lisp_indirect_variable): Name an expression,
3694 to avoid gcc -Wbad-function-cast warning.
3695 (Fdefvar): Rename locals to avoid shadowing.
3697 * callint.c (quotify_arg, quotify_args): Now static.
3698 (Fcall_interactively): Rename locals to avoid shadowing.
3699 Use const pointer when appropriate.
3701 * lisp.h (get_system_name, get_operating_system_release):
3702 Move decls here, to check interfaces.
3703 * process.c (get_operating_system_release): Move decl to lisp.h.
3704 * xrdb.c (get_system_name): Likewise.
3705 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3706 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3707 some of which prompt warnings from gcc -Wbad-function-cast.
3708 (Fformat_time_string, Fencode_time, Finsert_char):
3709 (Ftranslate_region_internal, Fformat):
3710 Rename or remove local vars to avoid shadowing.
3711 (Ftranslate_region_internal): Mark var as initialized.
3713 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3716 * lisp.h (eassert): Check that the argument compiles, even if
3717 ENABLE_CHECKING is not defined.
3719 * data.c (Findirect_variable): Name an expression, to avoid
3720 gcc -Wbad-function-cast warning.
3721 (default_value, arithcompare, arith_driver, arith_error): Now static.
3722 (store_symval_forwarding): Rename local to avoid shadowing.
3723 (Fmake_variable_buffer_local, Fmake_local_variable):
3724 Mark variables as initialized.
3725 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
3727 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
3728 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3729 Rename locals to avoid shadowing.
3730 (mark_stack): Move local variables into the #ifdef region where
3732 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3733 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3735 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3736 (GC_STRING_CHARS): Remove; not used.
3737 (Fmemory_limit): Cast sbrk's returned value to char *.
3739 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3740 avoids undefined behavior in theory.
3742 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3744 Use functions, not macros, for up- and down-casing (Bug#8254).
3745 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3746 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3747 to use the following functions instead of these macros.
3748 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3749 EMACS_INT, since callers assume the returned value fits in int.
3750 (upcase1): Likewise, for UPCASE_TABLE.
3751 (uppercasep, lowercasep, upcase): New static inline functions.
3752 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
3753 the race-condition problem in the old DOWNCASE.
3755 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3756 Rename locals to avoid shadowing.
3757 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
3758 (regex_compile, re_search_2, re_match_2_internal):
3759 Remove unused local vars.
3760 (FREE_VAR): Rewrite so as not to use empty "else",
3761 which gcc can warn about.
3762 (regex_compile, re_match_2_internal): Mark locals as initialized.
3763 (RETALLOC_IF): Define only if needed.
3764 (WORDCHAR_P): Likewise. This one is never needed, but is used
3765 only in a comment talking about a compiler bug, so put inside
3766 the #if 0 of that comment.
3767 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3768 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3771 * search.c (boyer_moore): Rename locals to avoid shadowing.
3772 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3773 (PREV_CHAR_BOUNDARY): Likewise.
3775 * search.c (simple_search): Remove unused var.
3777 * dired.c (compile_pattern): Move decl from here ...
3778 * lisp.h: ... to here, so that it can be checked.
3779 (struct re_registers): New forward decl.
3781 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3783 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3785 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3786 Rename locals to avoid shadowing.
3787 (Fvertical_motion): Mark locals as initialized.
3789 * casefiddle.c (casify_object, casify_region): Now static.
3790 (casify_region): Mark local as initialized.
3792 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3794 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3795 New macros, so that the caller can use some names other than
3796 gcpro1, gcpro2, etc.
3797 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3799 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3800 argument, for consistency with GCPRO2_VAR, etc: it is now the
3801 prefix of the variable, not the variable itself. All uses
3803 * dired.c (directory_files_internal, file_name_completion):
3804 Rename locals to avoid shadowing.
3806 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3807 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3808 dired.c's scmp function, had undefined behavior.
3809 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3810 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3811 * buffer.h: ... to here, because these macros use current_buffer,
3812 and the new implementation with inline functions needs to have
3813 current_buffer in scope now, rather than later when the macros
3815 (downcase, upcase1): New static inline functions.
3816 (DOWNCASE, UPCASE1): Reimplement using these functions.
3817 This avoids undefined behavior in expressions like
3818 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3819 from race conditions in accessing the global variables
3820 case_temp1 and case_temp2.
3821 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3822 * lisp.h (case_temp1, case_temp2): Remove their decls.
3823 * character.h (ASCII_CHAR_P): Move from here ...
3824 * lisp.h: ... to here, so that the inline functions mentioned
3827 * dired.c (directory_files_internal_unwind): Now static.
3829 * fileio.c (file_name_as_directory, directory_file_name):
3830 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3832 (file_name_as_directory): Use const pointers when appropriate.
3833 (Fexpand_file_name): Likewise. In particular, newdir might
3834 point at constant storage, so make it a const pointer.
3835 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
3836 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3838 (Fset_file_times, Finsert_file_contents, auto_save_error):
3839 Rename locals to avoid shadowing.
3841 * minibuf.c (choose_minibuf_frame_1): Now static.
3842 (Ftry_completion, Fall_completions): Rename or remove locals
3845 * marker.c (bytepos_to_charpos): Remove; unused.
3847 * lisp.h (verify_bytepos, count_markers): New decls,
3848 so that gcc does not warn that these functions aren't declared.
3850 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3851 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
3852 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
3853 (copy_text): Remove unused local var.
3855 * filelock.c (within_one_second): Now static.
3856 (lock_file_1): Rename local to avoid shadowing.
3858 * buffer.c (fix_overlays_before): Mark locals as initialized.
3859 (fix_start_end_in_overlays): Likewise. This function should be
3860 simplified by using pointers-to-pointers, but that's a different
3862 (switch_to_buffer_1): Now static.
3863 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3864 (report_overlay_modification): Rename locals to avoid shadowing.
3866 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
3867 Fix pointer signedness issue.
3868 (sys_subshell): Mark local as volatile if checking for lint,
3869 to suppress a gcc -Wclobbered warning that does not seem to be right.
3870 (MAXPATHLEN): Define only if needed.
3872 * process.c (serial_open, serial_configure): Move decls from here ...
3873 * systty.h: ... to here, so that they can be checked.
3875 * fns.c (get_random, seed_random): Move extern decls from here ...
3876 * lisp.h: ... to here, so that they can be checked.
3878 * sysdep.c (reset_io): Now static.
3879 (wait_for_termination_signal): Remove; unused.
3881 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3882 (copy_keymap_item, append_key, push_text_char_description):
3884 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
3885 (DENSE_TABLE_SIZE): Remove; unused.
3886 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3887 (describe_map_tree):
3888 Rename locals to avoid shadowing.
3890 * keyboard.c: Declare functions static if they are not used elsewhere.
3891 (echo_char, echo_dash, cmd_error, top_level_2):
3892 (poll_for_input, handle_async_input): Now static.
3893 (read_char, kbd_buffer_get_event, make_lispy_position):
3894 (make_lispy_event, make_lispy_movement, apply_modifiers):
3895 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3896 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3897 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
3898 (read_key_sequence, read_char): Mark locals as initialized.
3899 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
3901 * keyboard.h (make_ctrl_char): New decl.
3902 (mark_kboards): Move decl here ...
3903 * alloc.c (mark_kboards): ... from here.
3905 * lisp.h (force_auto_save_soon): New decl.
3907 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
3908 (DEFINE_DUMMY_FUNCTION): New macro.
3909 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3911 (main): Add casts to avoid warnings
3912 if GCC considers string literals to be constants.
3914 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3916 * dbusbind.c: Pointer signedness fixes.
3917 (xd_signature, xd_append_arg, xd_initialize):
3918 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3919 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3920 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3921 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3923 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3924 if GCC considers string literals to be constants.
3925 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
3927 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3929 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3930 (print_preprocess, print_object): New macro to fix last change.
3932 * print.c (print_preprocess): Don't forget font objects.
3934 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
3936 * emacs.c (USAGE3): Doc fixes.
3938 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3940 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3943 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
3945 * lisp.h (VWindow_system, Qfile_name_history):
3946 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3947 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3948 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3950 * w32select.c: Don't #include "keyboard.h".
3951 (run_protected): Add extern declaration for waiting_for_input.
3953 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3954 * w32console.c (detect_input_pending, read_input_pending)
3955 (encode_terminal_code):
3956 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3957 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3958 (w32_system_caret_y, Qfile_name_history):
3959 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3960 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3961 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3962 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3963 * w32proc.c (Qlocal, report_file_error):
3964 * w32term.c (Vwindow_system, updating_frame):
3965 * w32uniscribe.c (initialized, uniscribe_font_driver):
3966 Remove unneeded extern declarations.
3968 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
3970 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
3972 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
3974 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3975 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3976 These macros can no longer be used for assignment.
3978 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3979 Assign struct members directly, instead of using BUF_BEGV etc.
3980 (record_buffer_markers, fetch_buffer_markers): New functions for
3981 recording and fetching special buffer markers.
3982 (set_buffer_internal_1, set_buffer_temp): Use them.
3984 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3986 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3988 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3989 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3991 * xdisp.c (hscroll_window_tree):
3992 (reconsider_clip_changes): Use PT instead of BUF_PT.
3994 2011-03-13 Eli Zaretskii <eliz@gnu.org>
3996 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3997 $(EMACS_ROOT)/lib/intprops.h.
3999 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4001 Fix more problems found by GCC 4.5.2's static checks.
4003 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4004 to unsigned char * to avoid compiler diagnostic.
4005 (xg_free_frame_widgets): Make it clear that a local variable is
4006 needed only if USE_GTK_TOOLTIP.
4007 (gdk_window_get_screen): Make it clear that this macro is needed
4008 only if USE_GTK_TOOLTIP.
4009 (int_gtk_range_get_value): New function, which avoids a diagnostic
4010 from gcc -Wbad-function-cast.
4011 (xg_set_toolkit_scroll_bar_thumb): Use it.
4012 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4013 diagnostic from gcc -Wbad-function-cast.
4014 (get_utf8_string, xg_get_file_with_chooser):
4015 Rename locals to avoid shadowing.
4016 (create_dialog): Move locals to avoid shadowing.
4018 * xgselect.c (xg_select): Remove unused var.
4020 * image.c (four_corners_best): Mark locals as initialized.
4021 (gif_load): Initialize transparent_p to zero (Bug#8238).
4022 Mark another local as initialized.
4023 (my_png_error, my_error_exit): Mark with NO_RETURN.
4025 * image.c (clear_image_cache): Now static.
4026 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
4027 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
4028 (x_edge_detection): Remove unnecessary cast that
4029 gcc -Wbad-function-cast diagnoses.
4030 (gif_load): Fix pointer signedness.
4031 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4032 (jpeg_load, gif_load): Rename locals to avoid shadowing.
4034 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
4036 Improve quality of tests for time stamp overflow.
4037 For example, without this patch (encode-time 0 0 0 1 1
4038 1152921504606846976) returns the obviously-bogus value (-948597
4039 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4040 reports time overflow. See
4041 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
4042 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4043 * editfns.c: Include limits.h and intprops.h.
4044 (TIME_T_MIN, TIME_T_MAX): New macros.
4045 (time_overflow): Move earlier, to before first use.
4046 (hi_time, lo_time): New functions, for an accurate test for
4048 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4049 (Fget_internal_run_time): Don't assume time_t fits in int.
4050 (make_time): Use list2 instead of Fcons twice.
4051 (Fdecode_time): More accurate test for out-of-range times.
4052 (check_tm_member): New function.
4053 (Fencode_time): Use it, to test for out-of-range times.
4054 (lisp_time_argument): Don't rely on undefined left-shift and
4055 right-shift behavior when checking for time stamp overflow.
4057 * editfns.c (time_overflow): New function, refactoring common code.
4058 (Fformat_time_string, Fdecode_time, Fencode_time):
4059 (Fcurrent_time_string): Use it.
4061 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4062 * dired.c (make_time): Move to ...
4063 * editfns.c (make_time): ... here.
4064 * systime.h: Note the move.
4066 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4068 * fringe.c (update_window_fringes): Remove unused variables.
4070 * unexmacosx.c (copy_data_segment): Also copy __got section.
4073 2011-03-12 Eli Zaretskii <eliz@gnu.org>
4075 * termcap.c [MSDOS]: Include "msdos.h".
4076 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4077 Constify `char *' arguments and their references according to
4078 prototypes in tparam.h.
4080 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
4082 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4083 Adapt all references accordingly.
4085 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4087 2011-03-11 Tom Tromey <tromey@redhat.com>
4089 * buffer.c (syms_of_buffer): Remove obsolete comment.
4091 2011-03-11 Eli Zaretskii <eliz@gnu.org>
4093 * termhooks.h (encode_terminal_code): Declare prototype.
4095 * msdos.c (encode_terminal_code): Don't declare prototype.
4097 * term.c (encode_terminal_code): Now external again, used by
4098 w32console.c and msdos.c.
4100 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4101 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
4103 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
4105 Fix some minor problems found by GCC 4.5.2's static checks.
4107 * fringe.c (update_window_fringes): Mark locals as initialized
4109 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
4111 * alloc.c (mark_fringe_data): Move decl from here ...
4112 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4113 to check its interface.
4114 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4116 * fontset.c (free_realized_fontset): Now static.
4117 (Fset_fontset_font): Rename local to avoid shadowing.
4118 (fontset_font): Mark local as initialized.
4119 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
4121 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4123 * xselect.c (x_disown_buffer_selections): Remove; not used.
4124 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
4125 (x_own_selection, Fx_disown_selection_internal): Rename locals
4127 (x_handle_dnd_message): Remove local to avoid shadowing.
4129 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4130 so that the caller can use some name other than gcpro1.
4131 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
4132 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4133 (Fx_backspace_delete_keys_p):
4134 Use them to avoid shadowing, and rename vars to avoid shadowing.
4135 (x_decode_color, x_set_name, x_window): Now static.
4136 (Fx_create_frame): Add braces to silence GCC warning.
4137 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
4138 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4139 Remove unused locals.
4140 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4141 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4142 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4145 * xterm.h (x_mouse_leave): New decl.
4147 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4148 Remove unused functions.
4149 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4150 (x_calc_absolute_position): Now static.
4151 (XTread_socket): Don't define label "out" unless it's used.
4152 Don't declare local "event" unless it's used.
4153 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4154 unless they are used.
4155 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4156 (x_fatal_error_signal): Remove; not used.
4157 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4158 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4159 (x_error_catcher, x_connection_closed, x_error_handler):
4160 (x_error_quitter, xembed_send_message, x_iconify_frame):
4161 (my_log_handler): Rename locals to avoid shadowing.
4162 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
4163 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
4165 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4166 Rename or move locals to avoid shadowing.
4167 (tty_defined_color, merge_face_heights): Now static.
4168 (free_realized_faces_for_fontset): Remove; not used.
4169 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4170 does not deduce is never used uninitialized.
4171 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4172 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
4174 * terminal.c (store_terminal_param): Now static.
4176 * xmenu.c (menu_highlight_callback): Now static.
4177 (set_frame_menubar): Remove unused local.
4178 (xmenu_show): Rename parameter to avoid shadowing.
4179 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4180 since they might point to immutable storage.
4181 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4182 since it's unused otherwise.
4184 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
4185 Add a FIXME, since the code still doesn't look right. (Bug#8215)
4186 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4187 avoids a gcc -Wuninitialized diagnostic.
4188 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
4189 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4190 does not deduce are never used uninitialized.
4192 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4194 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4195 * window.c (window_loop, size_window):
4196 (run_window_configuration_change_hook, enlarge_window): Likewise.
4198 * window.c (display_buffer): Now static.
4199 (size_window): Mark variables that gcc -Wuninitialized
4200 does not deduce are never used uninitialized.
4201 * window.h (check_all_windows): New decl, to forestall
4202 gcc -Wmissing-prototypes diagnostic.
4203 * dispextern.h (bidi_dump_cached_states): Likewise.
4205 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4207 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
4209 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4210 and to avoid gcc -Wuninitialized warning.
4211 (load_charset_map): Mark variables that gcc -Wuninitialized
4212 does not deduce are never used uninitialized.
4213 (load_charset): Abort instead of using uninitialized var (Bug#8229).
4215 * coding.c (coding_set_source, coding_set_destination):
4216 Use "else { /* comment */ }" rather than "else /* comment */;"
4217 for clarity, and to avoid gcc -Wempty-body warning.
4218 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4219 a block, when the outer 'i' will do.
4220 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4221 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4222 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4223 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4224 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4225 Rename locals to avoid shadowing.
4226 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
4227 * coding.c (emacs_mule_char, encode_invocation_designation):
4228 Now static, since they're not used elsewhere.
4229 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
4230 (decode_coding_object, encode_coding_object, detect_coding_system):
4231 (decode_coding_emacs_mule): Mark variables that gcc
4232 -Wuninitialized does not deduce are never used uninitialized.
4233 (detect_coding_iso_2022): Initialize a local variable that might
4234 be used uninitialized. Leave a FIXME because it's not clear that
4235 this initialization is needed. (Bug#8211)
4236 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4237 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4238 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4239 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4240 Remove unused macros.
4242 * category.c (hash_get_category_set): Remove unused local var.
4243 (copy_category_table): Now static, since it's not used elsewhere.
4244 * character.c (string_count_byte8): Likewise.
4246 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4247 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4249 * chartab.c (copy_sub_char_table): Now static, since it's not used
4251 (sub_char_table_ref_and_range, char_table_ref_and_range):
4252 Rename locals to avoid shadowing.
4253 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
4255 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
4256 (BIDI_BOB): Remove unused macro.
4258 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4259 deduce are never used uninitialized.
4260 * term.c (encode_terminal_code): Likewise.
4262 * term.c (encode_terminal_code): Now static. Remove unused local.
4264 * tparam.h: New file.
4265 * term.c, tparam.h: Include it.
4266 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4267 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4268 Move these decls to tparam.h, and make them agree with what
4269 is actually in tparam.c. The previous trick of using incompatible
4270 decls in different modules does not conform to the C standard.
4271 All callers of tparam changed to use tparam's actual API.
4272 * tparam.c (tparam1, tparam, tgoto):
4273 Use const pointers where appropriate.
4275 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4276 * cm.h (struct cm): Likewise.
4277 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4278 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4279 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4280 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4281 (turn_on_face, init_tty): Likewise.
4282 * termchar.h (struct tty_display_info): Likewise.
4284 * term.c (term_mouse_position): Rename local to avoid shadowing.
4286 * alloc.c (mark_ttys): Move decl from here ...
4287 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4289 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4291 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4293 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
4295 * search.c (compile_pattern_1): Remove argument regp, unused since
4296 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4297 (compile_pattern): Don't pass it.
4299 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4301 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4302 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4304 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4306 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4308 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4309 gdk_window_get_screen, gdk_window_get_geometry,
4310 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4311 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4312 (xg_get_pixbuf_from_pixmap): New function.
4313 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4314 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4315 Call xg_get_pixbuf_from_pixmap instead of
4316 gdk_pixbuf_get_from_drawable.
4317 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4318 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4319 (xg_check_special_colors): Use GtkStyleContext and its functions
4321 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4322 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4323 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
4324 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4325 Call gtk_widget_get_preferred_size.
4326 (xg_frame_resized): gdk_window_get_geometry only takes 5
4328 (xg_win_to_widget, xg_event_is_for_menubar):
4329 Call gdk_x11_window_lookup_for_display.
4330 (xg_set_widget_bg): New function.
4331 (delete_cb): New function.
4332 (xg_create_frame_widgets): Connect delete-event to delete_cb.
4333 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4334 (xg_set_background_color): Call xg_set_widget_bg.
4335 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4336 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4337 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4338 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4340 (update_frame_tool_bar): Call gtk_widget_hide.
4341 (xg_initialize): Use GDK_KEY_g.
4343 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4345 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4347 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4348 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4349 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4351 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
4353 * w32xfns.c (select_palette): Check success of RealizePalette against
4354 GDI_ERROR, not zero.
4356 See ChangeLog.11 for earlier changes.
4362 Copyright (C) 2011 Free Software Foundation, Inc.
4364 This file is part of GNU Emacs.
4366 GNU Emacs is free software: you can redistribute it and/or modify
4367 it under the terms of the GNU General Public License as published by
4368 the Free Software Foundation, either version 3 of the License, or
4369 (at your option) any later version.
4371 GNU Emacs is distributed in the hope that it will be useful,
4372 but WITHOUT ANY WARRANTY; without even the implied warranty of
4373 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4374 GNU General Public License for more details.
4376 You should have received a copy of the GNU General Public License
4377 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.