Fix bug #11199 with killing a line at EOB that was bidi-reordered.
[bpt/emacs.git] / src / ChangeLog
1 2012-04-09 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
5
6 2012-04-09 Jan Djärv <jan.h.d@swipnet.se>
7
8 * nsterm.m (constrainFrameRect): Always constrain when there is only
9 one screen (Bug#10962).
10
11 2012-04-06 Eli Zaretskii <eliz@gnu.org>
12
13 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
14 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
15 about subtle differences between FETCH_CHAR* and STRING_CHAR*
16 macros related to unification of CJK characters. For the details,
17 see the discussion following the message here:
18 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
19
20 2012-04-04 Chong Yidong <cyd@gnu.org>
21
22 * keyboard.c (Vdelayed_warnings_list): Doc fix.
23
24 2012-04-01 Eli Zaretskii <eliz@gnu.org>
25
26 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
27 instead of alloca. (Bug#11138)
28
29 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
30
31 * w32menu.c (is_simple_dialog): Properly check lisp types.
32 (Bug#11141)
33
34 2012-03-31 Eli Zaretskii <eliz@gnu.org>
35
36 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
37 position we get to after a call to move_it_to fails the
38 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
39 only if we wind up in a string from display property. (Bug#11063)
40
41 * window.c (Fdelete_other_windows_internal): Invalidate the row
42 and column information about mouse highlight, so that redisplay
43 restores it after reallocating the glyph matrices. (Bug#7464)
44
45 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
46 string comes from a `display' text property, use the buffer
47 position of that property as if we actually saw that position in
48 the row's glyphs.
49 (move_it_by_lines): Remove the assertion that
50 "it->current_x == 0 && it->hpos == 0" which can be legitimately
51 violated when there's a before-string at the beginning of a line.
52 (Bug#11063)
53
54 2012-03-30 Eli Zaretskii <eliz@gnu.org>
55
56 * xdisp.c (append_space_for_newline): If the default face was
57 remapped, use the remapped face for the appended newline.
58 (extend_face_to_end_of_line): Use the remapped default face for
59 extending the face to the end of the line.
60 (display_line): Call extend_face_to_end_of_line when the default
61 face was remapped. (Bug#11068)
62
63 2012-03-29 Eli Zaretskii <eliz@gnu.org>
64
65 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
66
67 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
68
69 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
70
71 2012-03-27 Glenn Morris <rgm@gnu.org>
72
73 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
74 Doc fixes.
75
76 2012-03-26 Kenichi Handa <handa@m17n.org>
77
78 * dispextern.h (struct glyph): Fix previous change. Change the
79 bit length of glyphless.ch to 25 (Bug#11082).
80
81 2012-03-26 Chong Yidong <cyd@gnu.org>
82
83 * keyboard.c (Vselection_inhibit_update_commands): New variable.
84 (command_loop_1): Use it; inhibit selection update for
85 handle-select-window too (Bug#8996).
86
87 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
88
89 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
90
91 2012-03-25 Kenichi Handa <handa@m17n.org>
92
93 * dispextern.h (struct glyph): Change the bit length of
94 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
95
96 2012-03-24 Eli Zaretskii <eliz@gnu.org>
97
98 * s/ms-w32.h (tzname): Include time.h before redirecting to
99 _tzname. Fixes the MSVC build. (Bug#9960)
100
101 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
102
103 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
104 characters.
105
106 * xterm.c (XTread_socket): Only modify handling_signal if
107 !SYNC_INPUT. (Bug#11080)
108
109 2012-03-23 Eli Zaretskii <eliz@gnu.org>
110
111 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
112 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
113 when fetching a multibyte character consumes more bytes than
114 CHAR_BYTES returns, due to unification of CJK characters in
115 string_char. (Bug#11073)
116
117 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
118
119 * process.c (wait_reading_process_output): Handle pty disconnect
120 by refraining from sending oneself a SIGCHLD (bug#10933).
121
122 2012-03-22 Chong Yidong <cyd@gnu.org>
123
124 * dispextern.h (struct it): New member string_from_prefix_prop_p.
125
126 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
127 Mark string as coming from a prefix property.
128 (handle_face_prop): Use default face for prefix strings (Bug#4281).
129 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
130
131 2012-03-21 Chong Yidong <cyd@gnu.org>
132
133 * xfaces.c (Vface_remapping_alist): Doc fix.
134
135 2012-03-20 Eli Zaretskii <eliz@gnu.org>
136
137 * w32proc.c (Fw32_set_console_codepage)
138 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
139 Doc fixes.
140
141 2012-03-20 Chong Yidong <cyd@gnu.org>
142
143 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
144 to reflect default non-nil value of redisplay-dont-pause.
145
146 2012-03-19 Kenichi Handa <handa@m17n.org>
147
148 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
149 it fit in a valid range (Bug#11003).
150
151 2012-03-18 Eli Zaretskii <eliz@gnu.org>
152
153 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
154 that is not from display property, accept the row as a "cursor
155 row" if one of the string's character has a non-nil `cursor'
156 property. Fixes cursor positioning when there are newlines in
157 overlay strings, e.g. in icomplete.el. (Bug#11035)
158
159 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
160
161 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
162
163 2012-03-12 Chong Yidong <cyd@gnu.org>
164
165 * eval.c (inhibit_lisp_code): Rename from
166 inhibit_window_configuration_change_hook; move from window.c.
167
168 * xfns.c (unwind_create_frame_1, Fx_create_frame):
169 * window.c (run_window_configuration_change_hook)
170 (syms_of_window): Callers changed.
171
172 2012-03-11 Chong Yidong <cyd@gnu.org>
173
174 * keymap.c (Fkey_description): Doc fix (Bug#9700).
175
176 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
177
178 2012-03-10 Chong Yidong <cyd@gnu.org>
179
180 * frame.c (other_visible_frames): Don't assume the selected frame
181 is visible (Bug#10955).
182
183 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
184
185 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
186
187 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
188
189 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
190 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
191 zero (Bug#10954).
192
193 2012-03-03 Glenn Morris <rgm@gnu.org>
194
195 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
196
197 2012-03-02 Eli Zaretskii <eliz@gnu.org>
198
199 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
200 position past the first glyph_row that ends at ZV. (Bug#10902)
201 (redisplay_window, next_element_from_string): Fix typos in
202 comments.
203 (redisplay_window): Pass to move_it_vertically the margin in
204 pixels, not in screen lines.
205
206 2012-03-02 Glenn Morris <rgm@gnu.org>
207
208 * buffer.c (buffer-list-update-hook): Doc fix.
209
210 2012-02-29 Eli Zaretskii <eliz@gnu.org>
211
212 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
213 push_it before setting up the iterator for the first overlay
214 string, even if we have an empty string loaded.
215 (next_overlay_string): If there's an empty string on the iterator
216 stack, pop the stack. (Bug#10903)
217
218 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
219
220 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
221 Suggested by Stefan Monnier in
222 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
223 * alloc.c (widen_to_Lisp_Object): New static function.
224 (mark_memory): Also mark Lisp_Objects by fetching pointer words
225 and widening them to Lisp_Objects. This would work even if
226 USE_LSB_TAG is defined and wide integers are used, which might
227 happen in a future version of Emacs.
228
229 2012-02-25 Chong Yidong <cyd@gnu.org>
230
231 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
232 Doc fix.
233
234 * xselect.c (Fx_selection_exists_p): Doc fix.
235 (x_clipboard_manager_save_all): Print an informative message
236 before saving to clipboard manager.
237
238 2012-02-24 Chong Yidong <cyd@gnu.org>
239
240 * keyboard.c (process_special_events): Handle all X selection
241 requests in kbd_buffer, not just the next one (Bug#8869).
242
243 2012-02-23 Chong Yidong <cyd@gnu.org>
244
245 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
246 call when setting menu-bar-lines and tool-bar-lines parameters.
247 (unwind_create_frame_1): New helper function.
248
249 * window.c (inhibit_window_configuration_change_hook): New var.
250 (run_window_configuration_change_hook): Obey it.
251 (syms_of_window): Initialize it.
252
253 2012-02-22 Chong Yidong <cyd@gnu.org>
254
255 * xterm.c (x_draw_image_relief): Add missing type check for
256 Vtool_bar_button_margin (Bug#10743).
257
258 2012-02-21 Chong Yidong <cyd@gnu.org>
259
260 * fileio.c (Vfile_name_handler_alist): Doc fix.
261
262 * buffer.c (Fget_file_buffer): Protect against invalid file
263 handler return value.
264
265 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
266
267 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
268 when computing $valmask.
269
270 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
271 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
272 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
273 It's useless in that case, and it can cause problems on hosts
274 that allocate halves of EMACS_INT values separately.
275 Reported by Dan Horák. Diagnosed by Andreas Schwab in
276 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
277 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
278 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
279 it avoids undefined behavior on hosts where shifting right by more
280 than the word width has undefined behavior.
281
282 2012-02-19 Chong Yidong <cyd@gnu.org>
283
284 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
285 (Funhandled_file_name_directory, Ffile_name_as_directory)
286 (Fdirectory_file_name, Fexpand_file_name)
287 (Fsubstitute_in_file_name): Protect against invalid file handler
288 return values (Bug#10845).
289
290 2012-02-18 Eli Zaretskii <eliz@gnu.org>
291
292 * .gdbinit (pitx): Fix incorrect references to fields of the
293 iterator stack.
294
295 2012-02-17 Chong Yidong <cyd@gnu.org>
296
297 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
298
299 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
300
301 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
302 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
303
304 2012-02-15 Chong Yidong <cyd@gnu.org>
305
306 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
307 marked as special. Also, starting docstrings with * is obsolete.
308
309 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
310
311 * gnutls.c (emacs_gnutls_write): Fix last change.
312
313 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
314
315 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
316 send_process.
317
318 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
319
320 * keymap.c (Fsingle_key_description): Handle char ranges.
321
322 2012-02-12 Chong Yidong <cyd@gnu.org>
323
324 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
325 as that creates a dangerous corner case.
326
327 * window.c (Fdelete_window_internal): Invalidate the mouse
328 highlight (Bug#9904).
329
330 2012-02-12 Glenn Morris <rgm@gnu.org>
331
332 * xselect.c (Fx_own_selection_internal)
333 (Fx_get_selection_internal, Fx_disown_selection_internal)
334 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
335 * nsselect.m (Fx_own_selection_internal)
336 (Fx_disown_selection_internal, Fx_selection_exists_p)
337 (Fx_selection_owner_p, Fx_get_selection_internal):
338 Sync docs and argument specs with the xselect.c versions.
339
340 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
341
342 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
343
344 2012-02-11 Eli Zaretskii <eliz@gnu.org>
345
346 * w32select.c (Fx_selection_exists_p): Sync doc string and
347 argument list with xselect.c. (Bug#10783)
348
349 * w16select.c (Fx_selection_exists_p): Sync doc string and
350 argument list with xselect.c. (Bug#10783)
351
352 2012-02-10 Glenn Morris <rgm@gnu.org>
353
354 * fns.c (Fsecure_hash): Doc fix.
355
356 2012-02-09 Kenichi Handa <handa@m17n.org>
357
358 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
359
360 2012-02-07 Chong Yidong <cyd@gnu.org>
361
362 * buffer.c (Fbuffer_local_variables)
363 (buffer_lisp_local_variables): Handle unbound vars correctly;
364 don't let Qunbound leak into Lisp.
365
366 2012-02-07 Glenn Morris <rgm@gnu.org>
367
368 * image.c (Fimagemagick_types): Doc fix.
369
370 * image.c (imagemagick-render-type): Change it from a lisp object
371 to an integer. Move the doc here from the lisp manual.
372 Treat all values not equal to 0 the same.
373
374 2012-02-06 Chong Yidong <cyd@gnu.org>
375
376 * doc.c (store_function_docstring): Avoid applying docstring of
377 alias to base function (Bug#2603).
378
379 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
380
381 * .gdbinit (pp1, pv1): Remove redundant defines.
382 (pr): Use pp.
383
384 2012-02-04 Chong Yidong <cyd@gnu.org>
385
386 * nsterm.m: Declare a global (Bug#10694).
387
388 2012-02-04 Eli Zaretskii <eliz@gnu.org>
389
390 * w32.c (get_emacs_configuration_options):
391 Include --enable-checking, if specified, in the return value.
392
393 2012-02-04 Martin Rudalics <rudalics@gmx.at>
394
395 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
396 after rounding frame sizes. (Bug#9723)
397
398 2012-02-04 Eli Zaretskii <eliz@gnu.org>
399
400 * keyboard.c (adjust_point_for_property): Don't position point
401 before BEGV. (Bug#10696)
402
403 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
404
405 Handle overflow when computing char display width (Bug#9496).
406 * character.c (char_width): Return EMACS_INT, not int.
407 (char_width, c_string_width): Check for overflow when
408 computing the width; this is possible now that individual
409 characters can have unbounded width. Problem introduced
410 by merge from Emacs 23 on 2012-01-19.
411
412 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
413
414 * dbusbind.c (Fdbus_register_method): Mention the return value
415 :ignore in the docstring.
416
417 2012-02-02 Glenn Morris <rgm@gnu.org>
418
419 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
420
421 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
422 Unconditionally set to t. (Bug#10673)
423 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
424 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
425 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
426
427 2012-02-02 Kenichi Handa <handa@m17n.org>
428
429 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
430 0, do not call append_composite_glyph.
431
432 2012-02-02 Kenichi Handa <handa@m17n.org>
433
434 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
435 NULL (Bug#6988).
436 (x_produce_glyphs): If the component of a composition is a null
437 string, set it->pixel_width to 1 to avoid zero-width glyph.
438
439 2012-02-01 Eli Zaretskii <eliz@gnu.org>
440
441 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
442 first 2 arguments are identical. This makes inserting large
443 output from a subprocess an order of magnitude faster on
444 MS-Windows, where all sbrk'ed memory is always contiguous.
445
446 2012-01-31 Glenn Morris <rgm@gnu.org>
447
448 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
449 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
450 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
451
452 2012-01-29 Glenn Morris <rgm@gnu.org>
453
454 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
455
456 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
457
458 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
459
460 2012-01-28 Chong Yidong <cyd@gnu.org>
461
462 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
463
464 2012-01-26 Chong Yidong <cyd@gnu.org>
465
466 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
467
468 * search.c (Fsearch_forward, Fsearch_backward): Document negative
469 repeat counts (Bug#10507).
470
471 2012-01-26 Glenn Morris <rgm@gnu.org>
472
473 * lread.c (syms_of_lread): Doc fix.
474
475 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
476
477 * coding.c (encode_designation_at_bol): Change return value to
478 EMACS_INT.
479
480 2012-01-25 Chong Yidong <cyd@gnu.org>
481
482 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
483
484 2012-01-21 Chong Yidong <cyd@gnu.org>
485
486 * floatfns.c (Fcopysign): Make the second argument non-optional,
487 since nil is not allowed anyway.
488
489 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
490
491 * process.c (read_process_output): Use p instead of XPROCESS (proc).
492 (send_process): Likewise.
493
494 2012-01-19 Martin Rudalics <rudalics@gmx.at>
495
496 * window.c (save_window_save, Fcurrent_window_configuration)
497 (Vwindow_persistent_parameters): Do not use Qstate.
498 Rewrite doc-strings.
499
500 2012-01-19 Kenichi Handa <handa@m17n.org>
501
502 * character.c (char_width): New function.
503 (Fchar_width, c_string_width, lisp_string_width):
504 Use char_width (Bug#9496).
505
506 2012-01-16 Martin Rudalics <rudalics@gmx.at>
507
508 * window.c (Vwindow_persistent_parameters): New variable.
509 (Fset_window_configuration, save_window_save): Handle persistent
510 window parameters.
511
512 2012-01-14 Eli Zaretskii <eliz@gnu.org>
513
514 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
515 thrashing the stack of the thread. (Bug#9087)
516
517 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
518
519 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
520
521 2012-01-11 Eli Zaretskii <eliz@gnu.org>
522
523 * xdisp.c (rows_from_pos_range): Handle the case where the
524 highlight ends on a newline. (Bug#10464)
525 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
526 he end column for display of highlight that ends on a newline
527 before a R2L line.
528
529 2012-01-11 Glenn Morris <rgm@gnu.org>
530
531 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
532 from load-path also when installation-directory is nil. (Bug#10208)
533
534 2012-01-10 Glenn Morris <rgm@gnu.org>
535
536 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
537
538 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
539 Update template values to be closer to their typical values these days.
540
541 2012-01-09 Eli Zaretskii <eliz@gnu.org>
542
543 * xdisp.c (rows_from_pos_range): Accept additional argument
544 DISP_STRING, and accept any glyph in a row whose object is that
545 string as eligible for mouse highlight. Fixes mouse highlight of
546 display strings from overlays. (Bug#10464)
547
548 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
549
550 emacs: fix an auto-save permissions race condition (Bug#10400)
551 * fileio.c (auto_saving_dir_umask): New static var.
552 (Fmake_directory_internal): Use it.
553 (do_auto_save_make_dir): Set it, instead of invoking chmod after
554 creating the directory. The old code temporarily assigns
555 too-generous permissions to the directory.
556 (do_auto_save_eh): Clear it.
557 (Fdo_auto_save): Catch all errors, not just file errors, so
558 that the var is always cleared.
559
560 2012-01-07 Eli Zaretskii <eliz@gnu.org>
561
562 * search.c (scan_buffer): Pass character positions to
563 know_region_cache, not byte positions. (Bug#6540)
564
565 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
566
567 * w32.c (sys_rename): Report EXDEV when rename of a directory
568 fails because the target is on another logical disk. (Bug#10284)
569
570 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
571
572 * xterm.c (x_embed_request_focus): New function.
573
574 * xterm.h: Add prototype.
575
576 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
577
578 2012-01-05 Glenn Morris <rgm@gnu.org>
579
580 * emacs.c (emacs_copyright): Update short copyright year to 2012.
581
582 2012-01-01 Eli Zaretskii <eliz@gnu.org>
583
584 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
585 Load gnutls_transport_set_lowat only if GnuTLS version is below
586 2.11.1.
587 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
588 GnuTLS versions below 2.11.1.
589
590 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
591
592 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
593 to the doc string advising against its use for altering the way
594 windows are scrolled.
595
596 2011-12-28 Kenichi Handa <handa@m17n.org>
597
598 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
599 coding-system ASCII compatible only when it does not produce BOM
600 on encoding (Bug#10383).
601
602 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
603
604 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
605 can scroll.
606 (create_and_show_popup_menu): Always use menu_position_func for
607 Gtk3 (Bug#10361).
608
609 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
610
611 * callint.c (Fcall_interactively): Don't truncate prompt string.
612
613 2011-12-23 Eli Zaretskii <eliz@gnu.org>
614
615 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
616 property that ends at ZV, so that the bidi iteration could be
617 resumed from there (after widening). (Bug#10360)
618
619 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
620
621 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
622
623 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
624
625 * nsterm.m (x_free_frame_resources):
626 Release f->output_data.ns->miniimage.
627 (ns_index_color): Fix indentation. Do not retain
628 color_table->colors[i].
629
630 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
631 before returning.
632
633 * nsfns.m (x_set_background_color): Assign return value from
634 ns_index_color to face-background instead of NSColor*.
635 (ns_implicitly_set_icon_type): Fix indentation.
636 Change assignment in for loop to comparison.
637
638 * emacs.c (ns_pool): New variable.
639 (main): Assign ns_pool.
640 (Fkill_emacs): Call ns_release_autorelease_pool.
641
642 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
643 autorelease fdesc, release fdAttrs and tdict.
644 (ns_get_covering_families): Release charset.
645 (ns_findfonts): Release NSFontDescriptor created with new.
646 (ns_uni_to_glyphs): Fix indentation.
647 (setString): Release attrStr before assigning new value.
648
649 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
650
651 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
652 and NS_IMPL_COCOA.
653 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
654 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
655
656 2011-12-18 David Reitter <reitter@cmu.edu>
657
658 * nsterm.m (ns_term_init): Subscribe for notifications
659 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
660 to method trackingNotification in EmacsMenu.
661
662 * nsmenu.m (trackingMenu): New variable.
663 (trackingNotification): New method (from Aquamacs).
664 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
665 from Aquamacs (Bug#7030).
666
667 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
668
669 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
670 (symbol_to_nsstring): Fix indentation.
671 (ns_symbol_to_pb): New function.
672 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
673 (Fns_rotate_cut_buffers_internal): Remove.
674 (Fns_store_selection_internal): Rename from
675 Fns_store_cut_buffer_internal.
676 (ns_get_foreign_selection, Fx_own_selection_internal)
677 (Fx_disown_selection_internal, Fx_selection_exists_p)
678 (Fns_get_selection_internal, Fns_store_selection_internal):
679 Use ns_symbol_to_pb and check if return value is nil.
680 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
681 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
682 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
683 renamed to Sns_store_selection_internal.
684 (ns_handle_selection_request): Move code to Fx_own_selection_internal
685 and remove this function.
686 (ns_handle_selection_clear): Remove, never used.
687 (Fx_own_selection_internal): Move code from ns_handle_selection_request
688 here.
689
690 2011-12-17 Ken Brown <kbrown@cornell.edu>
691
692 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
693 GID is unknown (Bug#10257).
694
695 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
696
697 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
698 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
699 which caused a build failure on GNU/Linux IA-64. This problem was
700 introduced by my 2011-10-07 patch.
701
702 2011-12-15 Juri Linkov <juri@jurta.org>
703
704 * image.c (imagemagick_error): New function. (Bug#10112)
705 (imagemagick_load_image): Comment out `MagickSetResolution' call.
706 Use `imagemagick_error' where ImageMagick functions return
707 `MagickFalse'.
708 (Fimagemagick_types): Add `Fnreverse' to return the list in the
709 proper order.
710
711 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
712
713 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
714 fill background (Bug#8992).
715
716 2011-12-13 Martin Rudalics <rudalics@gmx.at>
717
718 * window.c (Vwindow_combination_resize)
719 (Vwindow_combination_limit): Use t instead of non-nil in
720 doc-strings.
721 (Vrecenter_redisplay): Add first sentence of doc-string on
722 separate line.
723 (Frecenter): Fix doc-string typo.
724
725 2011-12-11 Kenichi Handa <handa@m17n.org>
726
727 * coding.c (Funencodable_char_position): Pay attention to the
728 buffer text relocation (Bug#9389).
729
730 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
731
732 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
733 gtk_init (Bug#10100).
734
735 2011-12-10 Eli Zaretskii <eliz@gnu.org>
736
737 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
738 IT->string is nil. (Bug#10263)
739
740 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
741
742 * nsterm.h (x_free_frame_resources): Declare.
743
744 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
745 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
746
747 * nsterm.h (ns_get_defaults_value): Declare.
748
749 * nsterm.m (ns_default): Call ns_get_defaults_value.
750
751 2011-12-09 Eli Zaretskii <eliz@gnu.org>
752
753 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
754 (Bug#10170)
755
756 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
757
758 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
759 that where the value of an _OBJC_* symbol points to is in the .bss
760 section (Bug#10240).
761
762 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
763
764 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
765 after the loop to call ccl_driver at least once (Bug#8619).
766
767 2011-12-08 Kenichi Handa <handa@m17n.org>
768
769 * ftfont.c (get_adstyle_property): Fix previous change
770 (Bug#10233).
771
772 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
773
774 * w32.c (init_environment): If no_site_lisp, remove site-lisp
775 dirs from the default value of EMACSLOADPATH (bug#10208).
776
777 2011-12-07 Glenn Morris <rgm@gnu.org>
778
779 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
780 installation and source directories as well. (Bug#10208)
781
782 2011-12-06 Chong Yidong <cyd@gnu.org>
783
784 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
785
786 2011-12-06 Glenn Morris <rgm@gnu.org>
787
788 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
789 as an error, not just -1. (Bug#10217)
790
791 2011-12-05 Chong Yidong <cyd@gnu.org>
792
793 * keyboard.c (process_special_events): New function.
794 (swallow_events, Finput_pending_p): Use it (Bug#10195).
795
796 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
797
798 * coding.c (encode_designation_at_bol): Don't use uninitialized
799 local variable (Bug#9318).
800
801 2011-12-05 Kenichi Handa <handa@m17n.org>
802
803 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
804 return Qnil (Bug#8046, Bug#10193).
805
806 2011-12-05 Kenichi Handa <handa@m17n.org>
807
808 * coding.c (encode_designation_at_bol): New args charbuf_end and
809 dst. Return the number of produced bytes. Callers changed.
810 (coding_set_source): Return how many bytes coding->source was
811 relocated.
812 (coding_set_destination): Return how many bytes
813 coding->destination was relocated.
814 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
815 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
816
817 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
818
819 * coding.c (CODING_CHAR_CHARSET_P): New macro.
820 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
821 macro (Bug#9318).
822
823 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
824
825 The following changes are to fix Bug#9318.
826
827 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
828 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
829 (encode_coding_iso_2022, encode_coding_sjis)
830 (encode_coding_big5, encode_coding_charset): Use the above macros.
831
832 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
833
834 * lisp.h (process_quit_flag): Fix external declaration.
835
836 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
837
838 Don't macro-inline non-performance-critical code.
839 * eval.c (process_quit_flag): New function.
840 * lisp.h (QUIT): Use it.
841
842 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
843
844 * nsfns.m (get_geometry_from_preferences): New function.
845 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
846
847 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
848
849 * emacs.c (Qkill_emacs): Define.
850 (syms_of_emacs): Initialize it.
851 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
852 Qquit_flag to `kill-emacs' instead.
853 (quit_throw_to_read_char): Add parameter `from_signal'.
854 All callers changed. Call Fkill_emacs if requested and safe.
855 * lisp.h (QUIT): Call Fkill_emacs if requested.
856
857 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
858
859 * widget.c (update_wm_hints): Return if wmshell is null.
860 (widget_update_wm_size_hints): New function.
861
862 * widget.h (widget_update_wm_size_hints): Declare.
863
864 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
865 widget_update_wm_size_hints (Bug#10104).
866
867 2011-12-03 Eli Zaretskii <eliz@gnu.org>
868
869 * xdisp.c (handle_invisible_prop): If the invisible text ends just
870 before a newline, prepare the bidi iterator for consuming the
871 newline, and keep the current paragraph direction. (Bug#10183)
872 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
873
874 2011-12-02 Juri Linkov <juri@jurta.org>
875
876 * search.c (Fword_search_regexp): New Lisp function created from
877 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
878 (Fword_search_backward, Fword_search_forward)
879 (Fword_search_backward_lax, Fword_search_forward_lax):
880 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
881 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
882
883 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
884
885 * fileio.c (Finsert_file_contents): Move after-change-function call
886 to before the "handled:" label, since all "goto handled" appear in
887 cases where the *-change-functions have already been properly called
888 (bug#10117).
889
890 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
891
892 * keyboard.c (interrupt_signal): Don't call kill-emacs when
893 waiting for input. (Bug#10169)
894
895 2011-11-30 Eli Zaretskii <eliz@gnu.org>
896
897 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
898 verifies glyph row's hash code--we have just reallocated the
899 glyphs, so their contents can be complete garbage. (Bug#10164)
900
901 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
902
903 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
904
905 2011-11-30 Eli Zaretskii <eliz@gnu.org>
906
907 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
908 attributes are tested _before_ calling verify_row_hash, to protect
909 against GCC re-ordering of the tests. (Bug#10164)
910
911 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
912
913 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
914
915 * xterm.c (handle_one_xevent): Only set async_visible and friends
916 if net_wm_state_hidden_seen is non-zero (Bug#10002)
917 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
918 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
919
920 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
921
922 Remove GCPRO-related macros that exist only to avoid shadowing locals.
923 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
924 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
925 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
926 All uses changed to use GCPRO1 etc.
927 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
928 Revert to old implementation (i.e., before 2011-03-11).
929
930 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
931
932 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
933 of scroll runs so as to avoid assigning disabled bogus rows and
934 unnecessary graphics copy operations.
935
936 2011-11-27 Eli Zaretskii <eliz@gnu.org>
937
938 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
939 (snprintf) [_MSC_VER]: Redirect to _snprintf.
940 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
941 (malloc, free, realloc, calloc): Redirect to e_* only when
942 compiling Emacs.
943
944 * lisp.h (GCTYPEBITS): Move before first use.
945 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
946 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
947 this macro definition.
948
949 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
950 _MSC_VER.
951
952 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
953
954 * gtkutil.c (xg_create_frame_widgets):
955 Call gtk_window_set_has_resize_grip (FALSE) if that function is
956 present with Gtk+ 2.0.
957
958 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
959
960 * fileio.c (Finsert_file_contents): Undo previous change; see
961 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
962
963 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
964
965 Rename locals to avoid shadowing.
966 * fileio.c (Finsert_file_contents):
967 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
968 * process.c (wait_reading_process_output):
969 Rename inner 'proc' to 'p' to avoid shadowing.
970 Indent for consistency with usual Emacs style.
971
972 2011-11-25 Eli Zaretskii <eliz@gnu.org>
973
974 * xdisp.c (redisplay_window): If cursor row is not fully visible
975 after recentering, and scroll-conservatively is set to a large
976 number, scroll window by a few more lines to make the cursor fully
977 visible and out of scroll-margin. (Bug#10105)
978 (start_display): Don't move to the next line if the display should
979 start at a newline that is part of a display vector or an overlay
980 string. (Bug#10119)
981
982 2011-11-24 Juri Linkov <juri@jurta.org>
983
984 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
985 after the `MagickPingImage' call. (Bug#10112)
986
987 2011-11-23 Chong Yidong <cyd@gnu.org>
988
989 * window.c (Fcoordinates_in_window_p): Accept only live windows.
990
991 2011-11-23 Martin Rudalics <rudalics@gmx.at>
992
993 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
994 making another buffer current. (Bug#10114)
995
996 2011-11-23 Glenn Morris <rgm@gnu.org>
997
998 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
999
1000 2011-11-23 Chong Yidong <cyd@gnu.org>
1001
1002 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1003 using it (Bug#5984).
1004
1005 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1006
1007 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1008 and header-lines, as they don't have one computed for them.
1009 (Bug#10098)
1010
1011 * .gdbinit (prow): Make displayed values more self-explaining.
1012 Add row's hash code.
1013
1014 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1015
1016 * process.c (wait_reading_process_output): Fix asynchrounous
1017 GnuTLS socket handling on some versions of the GnuTLS library.
1018 (wait_reading_process_output): Add comment and URL.
1019
1020 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1021
1022 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1023
1024 2011-11-21 Chong Yidong <cyd@gnu.org>
1025
1026 * window.c (Fnext_window, Fprevious_window): Doc fix.
1027
1028 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1029
1030 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1031
1032 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1033
1034 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1035
1036 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1037
1038 * window.c (Fset_window_combination_limit): Rename argument
1039 STATUS to LIMIT.
1040 (Vwindow_combination_limit): Remove "status" from doc-string.
1041
1042 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1043
1044 * m/ibms390.h: Remove.
1045 * m/ibms390x.h: Don't include "ibms390.h".
1046
1047 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1048
1049 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1050 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1051
1052 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1053
1054 * casetab.c (Fset_case_table):
1055 * charset.c (Fcharset_after): Fix typos.
1056
1057 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1058
1059 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1060 Otherwise, valgrind does not work on some platforms.
1061 Problem reported by Andreas Schwab in
1062 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1063 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1064 is set, removing the need for VIRT_ADDRESS_VARIES.
1065 (PURE_P): Use a more-efficient implementation that needs just one
1066 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1067 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1068 to 4 (xorl, subq, cmpq, setbe).
1069 * alloc.c (pure): Always extern now, since that's the
1070 VIRT_ADDR_VARIES behavior.
1071 (PURE_POINTER_P): Use a single comparison, not two, for
1072 consistency with the new puresize.h.
1073 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1074 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1075 Remove VIRT_ADDR_VARIES no longer needed.
1076
1077 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1078
1079 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1080 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1081 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1082 behave as if the cursor position were at the window margin.
1083
1084 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1085 and the cursor position is out of bounds, behave as if the cursor
1086 position were at the window margin. (Bug#10075)
1087
1088 2011-11-18 Chong Yidong <cyd@gnu.org>
1089
1090 * window.c (Fwindow_combination_limit): Make first argument
1091 non-optional, since it is meaningless for live windows like the
1092 selected window.
1093
1094 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1095
1096 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1097
1098 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1099
1100 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1101 (graft_intervals_into_buffer): Simplify.
1102
1103 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1104
1105 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1106 hash values of the two rows.
1107 (copy_row_except_pointers): Preserve the used[] arrays and the
1108 hash values of the two rows. (Bug#10035)
1109 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1110
1111 * xdisp.c (row_hash): New function, body extracted from
1112 compute_line_metrics.
1113 (compute_line_metrics): Call row_hash, instead of computing the
1114 hash code inline.
1115
1116 * dispnew.c (verify_row_hash): Call row_hash for computing the
1117 hash code of a row, instead of duplicating code from xdisp.c.
1118
1119 * dispextern.h (row_hash): Add prototype.
1120
1121 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1122
1123 * frame.c (delete_frame): Don't delete the terminal when the last
1124 X frame is closed if emacs is built with GTK toolkit.
1125
1126 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1127
1128 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1129
1130 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1131
1132 * window.c (Vwindow_splits): Rename to
1133 Vwindow_combination_resize. Suggested by Juri Linkov.
1134 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1135 of Vwindow_splits.
1136
1137 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1138
1139 * nsfns.m (Fns_font_name):
1140 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1141
1142 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1143
1144 * window.h (window): Rename slot "nest" to "combination_limit".
1145 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1146 (Fset_window_nest): Rename to Fset_window_combination_limit.
1147 (Vwindow_nest): Rename to Vwindow_combination_limit.
1148 (recombine_windows, make_parent_window, make_window)
1149 (Fsplit_window_internal, saved_window)
1150 (Fset_window_configuration, save_window_save): Rename all
1151 occurrences of window_nest to window_combination_limit.
1152
1153 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1154
1155 * image.c (imagemagick_load_image): Fix typo.
1156
1157 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1158
1159 * xdisp.c (display_line): Move the call to
1160 highlight_trailing_whitespace before the call to
1161 compute_line_metrics, since the latter needs to see the final
1162 faces of all the glyphs to compute ROW's hash value.
1163 Fixes assertion violations in row_equal_p. (Bug#10035)
1164
1165 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1166
1167 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1168 just return (bug#10044).
1169
1170 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1171
1172 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1173 with user-defined heap size. Bump the default size of the temacs
1174 heap to 27MB, to avoid memory warning when running temacs.
1175 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1176
1177 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1178 current_matrix and desired_matrix. (Bug#9990)
1179 (verify_row_hash) [XASSERTS]: New function.
1180 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1181 that the hash value of glyph rows is correct.
1182
1183 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1184
1185 * window.h (window): Remove splits slot.
1186 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1187 (Fdelete_other_windows_internal, make_parent_window)
1188 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1189 (Fset_window_configuration, save_window_save): Don't deal with
1190 split status of windows.
1191 (saved_window): Remove splits slot.
1192 (Vwindow_splits): Rewrite doc-string.
1193
1194 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1195
1196 * xfns.c (unwind_create_frame):
1197 * nsfns.m (unwind_create_frame):
1198 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1199 Vframe_list (Bug#9999).
1200
1201 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1202
1203 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1204
1205 2011-11-11 Kenichi Handa <handa@m17n.org>
1206
1207 * callproc.c (Fcall_process): Set the member dst_multibyte of
1208 process_coding.
1209
1210 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1211
1212 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1213 avoid a crash (bug#9496).
1214
1215 2011-11-09 Chong Yidong <cyd@gnu.org>
1216
1217 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1218 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1219
1220 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1221
1222 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1223
1224 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1225
1226 Avoid some portability problems by eschewing 'extern inline' functions.
1227 The trivial performance wins aren't worth the portability hassles; see
1228 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1229 et seq.
1230 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1231 (window_box_width, window_box_left, window_box_left_offset)
1232 (window_box_right, window_box_right_offset): Undo previous change,
1233 by removing the "extern"s.
1234 * intervals.c (adjust_intervals_for_insertion)
1235 (adjust_intervals_for_deletion): Undo previous change,
1236 making these static again.
1237 (offset_intervals, temp_set_point_both, temp_set_point)
1238 (copy_intervals_to_string): No longer inline.
1239 * xdisp.c (window_text_bottom_y, window_box_width)
1240 (window_box_height, window_box_left_offset)
1241 (window_box_right_offset, window_box_left, window_box_right)
1242 (window_box): No longer inline.
1243
1244 2011-11-08 Chong Yidong <cyd@gnu.org>
1245
1246 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1247 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1248 Signal an error if not a live window.
1249 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1250 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1251
1252 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1253
1254 * lisp.h (syms_of_abbrev): Remove declaration.
1255 Reported by CHENG Gao <chenggao@royau.me>.
1256
1257 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1258
1259 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1260 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1261 of temacs in GUI mode.
1262
1263 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1264
1265 * window.h: Declare delete_all_child_windows instead of
1266 delete_all_subwindows.
1267 * window.c (Fwindow_nest, Fset_window_nest)
1268 (Fset_window_new_total, Fset_window_new_normal)
1269 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1270 (delete_all_subwindows): Rename to delete_all_child_windows.
1271 (Fdelete_other_windows_internal, Fset_window_configuration):
1272 Call delete_all_child_windows instead of delete_all_subwindows.
1273 * frame.c (delete_frame): Call delete_all_child_windows instead
1274 of delete_all_subwindows.
1275
1276 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1277
1278 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1279 This is also needed for porting to any host where GC_MARK_STACK is
1280 not GC_MAKE_GCPROS_NOOPS.
1281 (which_symbols): Use it.
1282
1283 2011-11-07 Kenichi Handa <handa@m17n.org>
1284
1285 * coding.c (coding_set_destination): Check coding->src_pos only
1286 when coding->src_object is a buffer (bug#9910).
1287
1288 * process.c (send_process): Set the member src_multibyte of coding
1289 to 0 (bug#9911) when sending a unibyte text.
1290
1291 * callproc.c (Fcall_process): Set the member src_multibyte of
1292 process_coding to 0 (bug#9912).
1293
1294 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1295
1296 * xmenu.c (cleanup_widget_value_tree): New function.
1297 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1298 calling free_menubar_widget_value_tree directly (Bug#9830).
1299
1300 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1301
1302 Fix some portability problems with 'inline'.
1303 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1304 (window_box_width, window_box_left, window_box_left_offset)
1305 (window_box_right, window_box_right_offset): Declare extern.
1306 Otherwise, these inline functions do not conform to C99 and
1307 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1308 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1309 * intervals.c (adjust_intervals_for_insertion)
1310 (adjust_intervals_for_deletion): Now extern, because otherwise the
1311 extern inline functions 'offset_intervals' couldn't refer to it.
1312 (static_offset_intervals): Remove.
1313 (offset_intervals): Rewrite using the old contents of
1314 static_offset_intervals. The old version didn't conform to C99
1315 because an extern inline function contained a reference to an
1316 identifier with static linkage.
1317
1318 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1319
1320 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1321 GC.
1322
1323 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1324
1325 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1326 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1327 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1328 return Qleft_to_right.
1329
1330 2011-11-06 Chong Yidong <cyd@gnu.org>
1331
1332 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1333 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1334 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1335 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1336 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1337 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1338 (Fwindow_vscroll): Doc fix.
1339 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1340 argument, since it makes no sense to pass a live window and for
1341 consistency with window-child.
1342
1343 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1344
1345 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1346 support MSVC.
1347
1348 2011-11-05 Jason Rumney <jasonr@gnu.org>
1349
1350 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1351 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1352 fonts (Bug#6029).
1353 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1354 bitwise arithmetic preventing use of unicode-sip and non-truetype
1355 opentype fonts.
1356
1357 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1358
1359 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1360 "emacs"-only part.
1361
1362 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1363 initialization code to keep similarity to xfns.c after changes
1364 from 2011-11-05.
1365
1366 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1367
1368 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1369 (unwind_create_frame): New function (Bug#9943).
1370 (Fx_create_frame): Restructure code to be more similar to the one in
1371 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1372 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1373 Move terminal->reference_count++ just before making the frame official
1374 (Bug#9943).
1375
1376 * nsterm.m (x_free_frame_resources): New function.
1377 (x_destroy_window): Move code to x_free_frame_resources.
1378
1379 * xfns.c (unwind_create_frame): Fix comment.
1380 (Fx_create_frame, x_create_tip_frame):
1381 Move terminal->reference_count++ just before making the frame
1382 official. Move initialization of image_cache_refcount and
1383 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1384
1385 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1386
1387 Support MSVC build with newer versions of Visual Studio.
1388 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1389 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1390 nt/gmake.defs.
1391
1392 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1393 which are not supported by MSVC.
1394 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1395 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1396 bitfields.
1397 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1398 types in bitfields.
1399 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1400
1401 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1402
1403 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1404
1405 Support MSVC build with newer versions of Visual Studio.
1406 * w32.c: Don't include w32api.h for MSVC.
1407 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1408
1409 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1410 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1411 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1412 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1413 e_* cousins.
1414 (alloca) [_MSC_VER]: Define to _alloca.
1415
1416 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1417
1418 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1419
1420 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1421
1422 * xdisp.c (note_mouse_highlight): If either of
1423 previous/next-single-property-change returns nil, treat that as
1424 the beginning or the end of the buffer. (Bug#9955)
1425
1426 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1427
1428 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1429 label is not null (Bug#9951).
1430 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1431 may be NULL.
1432
1433 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1434
1435 * window.c (Fwindow_body_size): Mention in the doc string that the
1436 return value is in frame's canonical units. (Bug#9949)
1437
1438 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1439
1440 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1441
1442 * w32fns.c (unwind_create_frame): If needed, free the glyph
1443 matrices of the partially constructed frame. (Bug#9943)
1444 * xfns.c (unwind_create_frame): Likewise.
1445
1446 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1447
1448 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1449 Don't stop backward scan on the continuation glyph, even though
1450 its CHARPOS is positive.
1451 (mouse_face_from_buffer_pos, note_mouse_highlight):
1452 Rename cover_string to disp_string.
1453
1454 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1455
1456 * window.c (temp_output_buffer_show): Don't use
1457 Vtemp_buffer_show_specifiers.
1458 (Vtemp_buffer_show_specifiers): Remove unused variable.
1459
1460 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1461
1462 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1463 past the beginning of the current glyph matrix.
1464
1465 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1466
1467 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1468 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1469 HAVE_GTK3 (Bug#9869).
1470
1471 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1472 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1473
1474 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1475
1476 * xterm.c: Declare x_handle_net_wm_state to return int.
1477 (handle_one_xevent): Check if we are iconified but don't have
1478 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1479 (get_current_wm_state): Return non-zero if not hidden,
1480 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1481 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1482 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1483 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1484
1485 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1486
1487 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1488 so that this new function doesn't get optimized away by a
1489 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1490
1491 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1492
1493 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1494
1495 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1496
1497 Fix the `xbytecode' command.
1498 * .gdbinit (xprintbytestr): New command.
1499 (xwhichsymbols): Rename from `which'; all callers changed.
1500 (xbytecode): Print the byte-code string as well.
1501
1502 2011-10-29 Kim Storm <storm@cua.dk>
1503
1504 * alloc.c (which_symbols): New function.
1505
1506 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1507
1508 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1509 line. (Bug#9903)
1510
1511 2011-10-29 Glenn Morris <rgm@gnu.org>
1512
1513 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1514 Not clear what it was for, and it causes various bugs. (Bug#9839)
1515
1516 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1517
1518 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1519 possible random value that matches one of those tested as
1520 condition to clear the mouse face.
1521
1522 2011-10-28 Chong Yidong <cyd@gnu.org>
1523
1524 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1525
1526 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1527
1528 * window.c (make_window): Initialize phys_cursor_on_p.
1529
1530 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1531
1532 * lisp.h (struct Lisp_Symbol): Update comments.
1533
1534 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1535
1536 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1537
1538 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1539
1540 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1541 <oslsachem@gmail.com> for helping to debug this.
1542
1543 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1544 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1545 (g_b_init_get_glyph_outline_w): New static variables.
1546 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1547 (GetGlyphOutlineW_Proc): New typedefs.
1548 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1549 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1550 New functions.
1551 (w32font_open_internal, compute_metrics):
1552 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1553 instead of calling the "wide" APIs directly.
1554
1555 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1556
1557 * w32.h (syms_of_w32font): Add prototype.
1558
1559 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1560
1561 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1562 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1563 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1564 (Fmove_to_window_line): Doc fix.
1565
1566 2011-10-27 Chong Yidong <cyd@gnu.org>
1567
1568 * process.c (make_process): Set gnutls_state to NULL.
1569
1570 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1571 non-NULL, regardless of GNUTLS_INITSTAGE.
1572 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1573 an error. Set process slots as soon as we allocate them.
1574
1575 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1576
1577 2011-10-27 Chong Yidong <cyd@gnu.org>
1578
1579 * gnutls.c (emacs_gnutls_deinit): New function.
1580 Deallocate credentials structures as well as calling gnutls_deinit.
1581 (Fgnutls_deinit, Fgnutls_boot): Use it.
1582
1583 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1584 (deactivate_process): Call emacs_gnutls_deinit.
1585
1586 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1587
1588 * image.c (x_create_x_image_and_pixmap):
1589 * w32.c (sys_rename, w32_delayed_load):
1590 * w32font.c (fill_in_logfont):
1591 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1592
1593 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1594
1595 * w32fns.c (w32_default_color_map): New function,
1596 extracted from Fw32_default_color_map.
1597 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1598
1599 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1600
1601 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1602
1603 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1604
1605 * keyboard.c (test_undefined): New function (bug#9751).
1606 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1607
1608 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1609
1610 * sysdep.c (init_sys_modes): Fix the check for the controlling
1611 terminal (Bug#6649).
1612
1613 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1614
1615 * dispextern.h (struct bidi_it): New member next_en_type.
1616
1617 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1618 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1619 current character, check also for next_en_type being WEAK_EN.
1620 (bidi_resolve_weak): Don't enter the expensive loop if the current
1621 position is before next_en_pos. Record the bidi type of the first
1622 non-ET, non-BN character we find, in addition to its position.
1623 (bidi_level_of_next_char): Invalidate next_en_type when
1624 next_en_pos is over-stepped.
1625
1626 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1627
1628 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1629 * editfns.c: Rewrite current-time-zone so that it invokes
1630 the equivalent of (format-time-string "%Z") to get the time zone name.
1631 This fixes a bug when the time zone name contains characters that
1632 need converting from the system time locale to Emacs internal format.
1633 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1634 that patch fixed format-time-string to do the conversion, but
1635 I forgot to fix current-time-zone.
1636 (format_time_string): New function, containing most of
1637 what Fformat_time_string used to contain.
1638 (Fformat_time_string): Rewrite in terms of format_time_string.
1639 This doesn't change this function's behavior.
1640 (current-time-zone): Rewrite to use format_time_string.
1641 This fixes the bug reported by Michael Schierl in
1642 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1643 Jason Rumney's 2007-06-07 change worked around this bug, but
1644 didn't fix it.
1645 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1646
1647 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1648
1649 * xdisp.c (start_display): If the character at POS is displayed
1650 via a display vector, reset IT->current.dpvec_index to zero.
1651 (try_window_reusing_current_matrix): If a line ends in a display
1652 vector or the next line starts in a display vector, continue
1653 redrawing the window even though the character position of
1654 start_row was reached.
1655 (Bug#9771, part 2)
1656
1657 2011-10-18 Chong Yidong <cyd@gnu.org>
1658
1659 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1660 with nobreak-char-display too.
1661
1662 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1663
1664 Fix part 3 of bug#9771.
1665 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1666 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1667 non-neutral characters if the current character is a paragraph
1668 separator (a.k.a. Newline). This avoids running the same
1669 expensive loop twice, once when we consume the preceding newline
1670 and the other time when the line actually needs to be displayed.
1671 Avoid the loop when we see neutrals on the base embedding level
1672 following a character whose directionality is the same as the
1673 paragraph's. This avoids running the expensive loop when a line
1674 ends in a long sequence of neutrals, like control characters.
1675 Add assertion against STRONG_AL type. Slightly rearrange code
1676 that determines the type of a neutral given the first non-neutral
1677 that follows it.
1678 (bidi_level_of_next_char): Set next_en_pos to zero when
1679 invalidating its info.
1680
1681 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1682
1683 * xdisp.c (push_display_prop): Determine whether to record string
1684 or buffer position by IT->string, not by IT->method. Allow
1685 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1686 (move_it_vertically_backward): Don't look for character position
1687 immediately after the newline when in a continuation line.
1688 (Bug#9771, part 1)
1689
1690 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1691
1692 * window.c (coordinates_in_window): Rewrite and delabelize
1693 vertical border check. (Bug#5357) (Bug#9618)
1694
1695 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1696
1697 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1698 errors in XSetWindowBorder (bug#9310).
1699
1700 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1701
1702 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1703 avoid crash when xmalloc overrun checking is enabled.
1704
1705 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1706
1707 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1708 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1709 cursor motion with <left> and <right> arrow keys.
1710
1711 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1712 some callers set that themselves.
1713
1714 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1715
1716 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1717 display string and the previous row comes from the same string and
1718 is empty. (Bug#9739) (Bug#9738)
1719
1720 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1721
1722 * doc.c (get_doc_string): Encode file name (bug#9735).
1723
1724 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1725
1726 * bidi.c (bidi_level_of_next_char):
1727 * xdisp.c (get_visually_first_element): Remove old incorrect
1728 comments regarding the Unicode Line Separator character.
1729
1730 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1731
1732 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1733
1734 * alloc.c (Fgc_status): Do not access beyond zombies array
1735 boundary if nzombies > MAX_ZOMBIES.
1736 * alloc.c (dump_zombies): Add missing format specifier.
1737
1738 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1739
1740 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1741 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1742
1743 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1744 Some packages use them to denote characters with modifiers.
1745
1746 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1747
1748 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1749 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1750 matching a pp-number. Rename parameter var to var1.
1751
1752 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1753
1754 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1755
1756 2011-10-08 Glenn Morris <rgm@gnu.org>
1757
1758 * callint.c (Fcall_interactively): Give a more explicit error for the
1759 'c' case with a non-character input. (Bug#8479)
1760
1761 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1762
1763 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1764 lines.
1765 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1766 lines that are hscrolled on the left.
1767
1768 * dispnew.c (buffer_posn_from_coords): Account for a possible
1769 presence of header-line. (Bug#4426)
1770
1771 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1772
1773 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1774 Don't advertise functionality which we discourage or doesn't work.
1775
1776 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1777
1778 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1779 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1780 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1781 this makes Emacs dump core during garbage collection on rare
1782 occasions. sizeof is obviously inferior to offsetof here, so
1783 stick with offsetof.
1784 (GC_POINTER_ALIGNMENT): New macro.
1785 (mark_memory): Omit 3rd (offset) arg; caller changed.
1786 Don't assume EMACS_INT alignment is the same as pointer alignment.
1787
1788 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1789
1790 * keyboard.c (read_key_sequence_remapped): New var.
1791 (read_key_sequence): Compute remapping in the right buffer.
1792 (command_loop_1): Use read_key_sequence's remapping directly.
1793
1794 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1795
1796 * dired.c (file_name_completion): Don't expand file name.
1797 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1798 before checking file name handler.
1799
1800 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1801 they've been requested explicitly (bug#9591).
1802
1803 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1804
1805 * keymap.c (Fsingle_key_description): Use make_specified_string
1806 instead of build_string to build string from push_key_description.
1807 (Bug#5193)
1808
1809 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1810
1811 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1812 This fixes a Y2038 bug on 64-bit hosts.
1813 * buffer.c (reset_buffer):
1814 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1815 (Fclear_buffer_auto_save_failure):
1816 Use 0, not -1, to represent an unset failure time, since time_t
1817 might not be signed.
1818
1819 Remove dependency on glibc malloc internals.
1820 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1821 Move back here from lisp.h, but with their new implementations.
1822 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1823 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1824 * charset.c (charset_table_init): New static var.
1825 (syms_of_charset): Use it instead of xmalloc. This removes a
1826 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1827 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1828 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1829 Move back to alloc.c.
1830 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1831 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1832
1833 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1834
1835 * nsterm.m (windowDidResize): Call x_set_window_size only when
1836 ns_in_resize is true. Otherwise set pixelwidth/height and
1837 call change_frame_size (Bug#9628).
1838
1839 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1840
1841 Port --enable-checking=all to Fedora 14 x86-64.
1842 * charset.c (syms_of_charset): Also account for glibc malloc's
1843 internal overhead when calculating the initial malloc maximum.
1844
1845 Port --enable-checking=all to Fedora 14 x86.
1846 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1847 Move to lisp.h.
1848 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1849 (overrun_check_realloc, overrun_check_free):
1850 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1851 That way, xmalloc returns a properly-aligned pointer even if
1852 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1853 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1854 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1855 into account when calculating the initial malloc maximum.
1856 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1857 Move here from alloc.c, so that charset.c can use it too.
1858 Properly align; the old code wasn't right for common 32-bit hosts
1859 when configured with --enable-checking=all.
1860 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1861 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1862
1863 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1864
1865 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1866 use EDOM.
1867
1868 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1869
1870 * xdisp.c (compute_display_string_end): If there's no display
1871 string at CHARPOS, return -1.
1872
1873 * bidi.c (bidi_fetch_char): When compute_display_string_end
1874 returns a negative value, treat the character as a normal
1875 character not covered by a display string. (Bug#9624)
1876
1877 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1878
1879 * lread.c (Fread_from_string): Fix typo in docstring.
1880
1881 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1882
1883 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1884 newline, reseat the iterator instead of bidi-iterating there one
1885 character at a time. (Bug#9610)
1886 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1887 TO_CHARPOS if the bidi iterator is at base embedding level.
1888
1889 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1890
1891 * lread.c (readevalloop): Use correct code for NBSP.
1892 (read1): Likewise. (Bug#9608)
1893
1894 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1895
1896 * dbusbind.c (Fdbus_register_signal): When service is not
1897 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1898
1899 2011-09-25 Glenn Morris <rgm@gnu.org>
1900
1901 * buffer.c (truncate-lines): Doc fix.
1902
1903 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1904
1905 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1906 (Fset_window_next_buffers): Doc fix.
1907
1908 2011-09-24 Glenn Morris <rgm@gnu.org>
1909
1910 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1911
1912 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1913
1914 Fix minor problems found by static checking.
1915 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1916 * indent.c (Fvertical_motion): Fix == vs = typo.
1917
1918 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1919
1920 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1921 Default value is now t. Doc fix.
1922
1923 * indent.c (Fvertical_motion): Compute and apply the overshoot
1924 logic when moving up, not only when moving down. Fix the
1925 confusing name and values of the it_overshoot_expected variable;
1926 logic changes accordingly. (Bug#9254) (Bug#9549)
1927
1928 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1929 CHARPOS is covered by a display string which includes newlines.
1930 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1931 is covered by a display string with embedded newlines.
1932
1933 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1934
1935 * dbusbind.c (Fdbus_register_signal): Add match rule to
1936 Vdbus_registered_objects_table. (Bug#9581)
1937 (Fdbus_register_method, Vdbus_registered_objects_table):
1938 Fix docstring.
1939
1940 2011-09-24 Jim Meyering <meyering@redhat.com>
1941
1942 do not ignore write error for any output size
1943 The previous change was incomplete.
1944 While it makes emacs --batch detect the vast majority of stdout
1945 write failures, errors were still ignored whenever the output size is
1946 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1947 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1948 && echo FAIL: ignored write error
1949 FAIL: ignored write error
1950 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1951 && echo FAIL: ignored write error
1952 FAIL: ignored write error
1953 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1954
1955 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1956
1957 * emacs.c (Fkill_emacs): In noninteractive mode exit
1958 non-successfully if a write error occurred on stdout. (Bug#9574)
1959
1960 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1961
1962 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1963 the xassert test.
1964
1965 * dispextern.h (struct it): Update the comment documenting what
1966 can it->OBJECT be.
1967
1968 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1969
1970 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1971 a display string, extend search for cursor position to end of row.
1972 (find_row_edges): If the row ends in a newline from a display
1973 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1974 Handle the case of a display string with multiple newlines.
1975 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1976 non-empty line. Fixes confusing cursor motion with arrow keys at
1977 the beginning of a line that starts with whitespace.
1978
1979 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1980
1981 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1982 (bug#9493).
1983
1984 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1985
1986 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1987 boolean (Bug#9154).
1988
1989 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1990
1991 * xdisp.c (display_line): Record maximum and minimum buffer
1992 positions even if no glyphs were produced (e.g., by a zero-width
1993 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1994 buffer positions that will be removed from the glyph row because
1995 they don't fit.
1996 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1997 column is beyond frame width: don't subtract 1 "pixel" when
1998 computing width of the stretch.
1999 (reseat_at_next_visible_line_start): Undo the change made on
2000 2011-09-17 that saved paragraph information and restored it after
2001 the call to `reseat'. (Bug#9545)
2002
2003 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2004
2005 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2006 and turn window cursor on if cleared (Bug#9415).
2007
2008 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2009
2010 * search.c (boyer_moore): Take unibyte characters from pattern
2011 literally. (Bug#9458)
2012
2013 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2014
2015 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2016
2017 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2018
2019 Fix minor problem found by static checking.
2020 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2021 initialized, to pacify gcc -Wuninitialized.
2022
2023 * fileio.c: Report proper errno when syscall falls.
2024 (Finsert_file_contents): Save and restore errno,
2025 so that report_file_error outputs the correct diagnostic.
2026 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2027
2028 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2029
2030 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2031
2032 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2033
2034 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2035 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2036
2037 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2038
2039 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2040 about the current paragraph and restore it after the call to reseat.
2041
2042 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2043 (bidi_find_paragraph_start): Search back for paragraph beginning
2044 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2045 (bidi_move_to_visually_next): Only trigger paragraph-related
2046 computations when the last character is a newline or at EOB, not
2047 just any NEUTRAL_B. (Bug#9470)
2048
2049 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2050 truncated lines if point is covered by a display string. (Bug#9524)
2051
2052 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2053
2054 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2055 (cons_to_x_long): New function.
2056 (lisp_data_to_selection_data): Use it. Correct the test for
2057 short-versus-long data; it was negated. Break out of vector
2058 loop, for efficiency, when a long datum is discovered.
2059
2060 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2061
2062 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2063
2064 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2065
2066 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2067 GCC PR/17406) by declaring this function with external scope.
2068
2069 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2070
2071 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2072 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2073
2074 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2075
2076 * editfns.c (Fformat): Correctly handle text properties on "%%".
2077
2078 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2079
2080 * xterm.c (x_draw_composite_glyph_string_foreground):
2081 * w32term.c (x_draw_composite_glyph_string_foreground):
2082 * term.c (encode_terminal_code):
2083 * composite.c (composition_update_it, get_composition_id):
2084 * xdisp.c (get_next_display_element)
2085 (fill_composite_glyph_string): Add comments about special meaning
2086 of TAB characters in a composition.
2087
2088 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2089
2090 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2091 This occurs when processing a multibyte format.
2092 Problem reported by Wolfgang Jenker.
2093
2094 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2095
2096 * xdisp.c (try_cursor_movement): Only check for exact match if
2097 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2098
2099 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2100
2101 Remove unused external symbols.
2102 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2103 * xdisp.c (calc_pixel_width_or_height): Now static.
2104 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2105 * indent.c (check_display_width):
2106 * w32term.c: Fix comment to match code.
2107 * xterm.c, xterm.h (x_catching_errors): Remove.
2108
2109 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2110
2111 * xselect.c: Use signed conversions more consistently (Bug#9498).
2112 (selection_data_to_lisp_data): Assume incoming selection data are
2113 signed integers, not unsigned. This is to be consistent with
2114 outgoing selection data, which was modified to use signed integers
2115 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2116 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2117 expects long, not unsigned long.
2118
2119 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2120
2121 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2122 computation of loop end. Reported by Johan Bockgård
2123 <bojohan@gnu.org>.
2124
2125 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2126
2127 * frame.c (Fother_visible_frames_p): Function deleted.
2128
2129 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2130
2131 * indent.c (compute_motion): Process display vector front to back
2132 rather than the other way around. (Bug#2496)
2133
2134 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2135
2136 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2137
2138 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2139
2140 * minibuf.c (Fread_from_minibuffer): Doc fix.
2141
2142 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2143
2144 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2145 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2146
2147 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2148
2149 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2150 value for non-existent files.
2151
2152 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2153
2154 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2155 set its "size" to -1. This will set the modtime_size field of
2156 the corresponding buffer to -1, which is what
2157 verify-visited-file-modtime expects for files that do not exist.
2158 (Bug#9139)
2159
2160 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2161
2162 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2163 here ...
2164 * lisp.h: ... from here. push_key_description is no longer
2165 defined in keyboard.c, so its declaration should not be in
2166 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2167 logically belongs with push_key_description.
2168
2169 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2170
2171 * buffer.h: Include <sys/types.h> instead of <time.h>.
2172 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2173 Problem reported by Herbert J. Skuhra.
2174
2175 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2176
2177 * xml.c (parse_region): Make the parsing work for
2178 non-comment-starting XML files again (bug#9144).
2179
2180 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2181
2182 * image.c (gif_load): Fix calculation of bottom and right corner.
2183 (Bug#9468)
2184
2185 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2186
2187 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2188 redisplay in small windows.
2189
2190 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2191
2192 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2193
2194 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2195
2196 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2197 Operate on live windows only.
2198
2199 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2200
2201 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2202
2203 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2204
2205 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2206 only under bidi iteration.
2207
2208 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2209
2210 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2211
2212 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2213
2214 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2215 Without this fix, the command to link temacs failed due to an
2216 undefined symbol __builtin_isnan. This is because
2217 /usr/include/iso/math_c99.h #defines isnan(x) to
2218 __builtin_isnan(x), but the bundled gcc, which identifies itself
2219 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2220 a __builtin_isnan.
2221 * floatfns.c (isnan): #undef, and then #define to a clone of
2222 what's in data.c.
2223 (Fisnan): Always define, since it's always available now.
2224 (syms_of_floatfns): Always define isnan at the Lisp level.
2225
2226 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2227
2228 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2229
2230 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2231
2232 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2233 The previous code assumed that file offsets (off_t values) fit in
2234 EMACS_INT variables, which is not true on typical 32-bit hosts.
2235 The code messed up by falsely reporting buffer overflow in cases
2236 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2237 when "big" contains more than 2**29 bytes, even though this
2238 inserts just one byte and does not overflow the buffer.
2239 (Finsert_file_contents): Store file offsets as off_t
2240 values, not as EMACS_INT values. Check for overflow when
2241 converting between EMACS_INT and off_t. When checking for
2242 buffer overflow or for overlap, take the offsets into account.
2243 Don't use EMACS_INT for small values where int suffices.
2244 When checking for overlap, fix a typo: ZV was used where
2245 ZV_BYTE was intended.
2246 (Fwrite_region): Don't assume off_t fits into 'long'.
2247 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2248
2249 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2250
2251 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2252
2253 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2254
2255 sprintf-related integer and memory overflow issues (Bug#9412).
2256
2257 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2258 (esprintf, exprintf, evxprintf): New functions.
2259 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2260 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2261 (modify_event_symbol): Do not assume that the length of
2262 name_alist_or_stem is safe to alloca and fits in int.
2263 (Fexecute_extended_command): Likewise for function name and binding.
2264 (Frecursion_depth): Wrap around reliably on integer overflow.
2265 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2266 since some callers pass EMACS_INT values.
2267 (Fsingle_key_description): Don't crash if symbol name contains more
2268 than MAX_ALLOCA bytes.
2269 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2270 (get_minibuffer): Arg is now EMACS_INT, not int.
2271 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2272 (esprintf, exprintf, evxprintf): New decls.
2273 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2274
2275 * dbusbind.c (signature_cat): New function.
2276 (xd_signature, Fdbus_register_signal):
2277 Do not overrun buffer; instead, report string overflow.
2278
2279 * dispnew.c (add_window_display_history): Don't overrun buffer.
2280 Truncate instead; this is OK since it's just a log.
2281
2282 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2283 even if the time zone offset is outlandishly large.
2284 Don't mishandle offset == INT_MIN.
2285
2286 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2287 when creating daemon; the previous buffer-overflow check was incorrect.
2288
2289 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2290 which has the guts of the old verror function.
2291
2292 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2293 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2294
2295 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2296 (font_unparse_xlfd): Don't blindly alloca long strings.
2297 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2298 fits in int, when using sprintf. Use single snprintf to count
2299 length of string rather than counting it via multiple sprintfs;
2300 that's simpler and more reliable.
2301 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2302 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2303 sprintf, in case result does not fit in int.
2304
2305 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2306 (fontset_from_font): Print it.
2307
2308 * frame.c (tty_frame_count): Now printmax_t, not int.
2309 (make_terminal_frame, set_term_frame_name): Print it.
2310 (x_report_frame_params): In X, window IDs are unsigned long,
2311 not signed long, so print them as unsigned.
2312 (validate_x_resource_name): Check for implausibly long names,
2313 and don't assume name length fits in 'int'.
2314 (x_get_resource_string): Don't blindly alloca invocation name;
2315 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2316 not fit in int.
2317
2318 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2319 (xg_check_special_colors, xg_set_geometry):
2320 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2321
2322 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2323 Use esprintf, not sprintf, in case result does not fit in int.
2324
2325 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2326 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2327 it as a large positive number.
2328 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2329 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2330
2331 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2332 in case result does not fit in int.
2333
2334 * print.c (float_to_string): Detect width overflow more reliably.
2335 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2336 buffer overrun. Don't assume list length fits in 'int'. Treat
2337 print length of 0 as 0, not as infinity; to be consistent with other
2338 uses of print length in this function. Don't overflow print length
2339 index. Don't assume hash table size fits in 'long', or that
2340 vectorlike size fits in 'unsigned long'.
2341
2342 * process.c (make_process): Use printmax_t, not int, to format
2343 process-name gensyms.
2344
2345 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2346
2347 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2348 to avoid potential buffer overrun.
2349
2350 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2351 if X resource line is longer than 512 bytes.
2352
2353 * xfns.c (x_window): Make sprintf buffer a bit bigger
2354 to avoid potential buffer overrun.
2355
2356 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2357
2358 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2359
2360 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2361
2362 Integer overflow fixes for scrolling, etc.
2363 Without these, Emacs silently mishandles large integers sometimes.
2364 For example, "C-u 4294967297 M-x recenter" was treated as if
2365 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2366
2367 * xdisp.c (try_window_id): Check Emacs fixnum range before
2368 converting to 'int'.
2369
2370 * window.c (window_scroll_line_based, Frecenter):
2371 Check that an Emacs fixnum is in range before assigning it to 'int'.
2372 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2373 values converted from Emacs fixnums.
2374 (Frecenter): Don't wrap around a line count if it is out of 'int'
2375 range; instead, treat it as an extreme value.
2376 (Fset_window_configuration, compare_window_configurations):
2377 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2378
2379 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2380 that can exceed INT_MAX. Check that EMACS_INT value is in range
2381 before assigning it to the (possibly-narrower) index.
2382 (match_limit): Don't assume that a fixnum can fit in 'int'.
2383
2384 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2385 exceed INT_MAX.
2386
2387 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2388 (Fvertical_motion): Don't wrap around LINES values that don't fit
2389 in 'int'. Instead, treat them as extreme values. This is good
2390 enough for windows, which can't have more than INT_MAX lines anyway.
2391
2392 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2393
2394 * Require libxml/parser.h to avoid compilation warning.
2395
2396 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2397
2398 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2399 since this reportedly can destroy thread storage.
2400
2401 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2402
2403 * syntax.c (find_defun_start): Update all cache variables if
2404 exiting early (Bug#9401).
2405
2406 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2407
2408 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2409
2410 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2411 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2412 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2413
2414 * term.c (tty_append_glyph): New function.
2415 (produce_stretch_glyph): Static function and its prototype deleted.
2416
2417 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2418 Add prototypes.
2419
2420 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2421
2422 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2423 when checking :margin (Bug#9390).
2424 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2425 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2426 so that the name doesn't mislead. All uses changed.
2427
2428 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2429
2430 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2431 set_tty_hooks.
2432
2433 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2434
2435 * xdisp.c (move_it_to): Don't bail out early when reaching
2436 position beyond to_charpos, if we are scanning backwards.
2437 (move_it_vertically_backward): When DY == 0, make sure we get to
2438 the first character in the line after the newline.
2439
2440 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2441
2442 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2443 (ccl_driver): Do not generate an out-of-range pointer.
2444 (Fccl_execute_on_string): Remove unnecessary check for
2445 integer overflow, noted by Stefan Monnier in
2446 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2447 Remove a FIXME that didn't need fixing.
2448 Simplify the newly-introduced buffer reallocation code.
2449
2450 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2451
2452 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2453
2454 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2455
2456 Integer and memory overflow issues (Bug#9196).
2457
2458 * doc.c (get_doc_string): Rework so that
2459 get_doc_string_buffer_size is the actual buffer size, rather than
2460 being 1 less than the actual buffer size; this makes xpalloc more
2461 convenient.
2462
2463 * image.c (x_allocate_bitmap_record, cache_image):
2464 * xselect.c (Fx_register_dnd_atom):
2465 Simplify previous changes by using xpalloc.
2466
2467 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2468 since either will do and ptrdiff_t is convenient with xpalloc.
2469
2470 * charset.c (charset_table_size)
2471 (struct charset_sort_data.priority): Now ptrdiff_t.
2472 (charset_compare): Don't overflow if priorities differ greatly.
2473 (Fsort_charsets): Don't assume list length fits in int.
2474 Check for size-calculation overflow when allocating sort data.
2475 (syms_of_charset): Allocate an initial charset table that is
2476 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2477
2478 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2479
2480 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2481 The actual value is always <= INT_MAX, and leaving it unsigned made
2482 overflow checking harder.
2483
2484 * dispextern.h (struct glyph_matrix.rows_allocated)
2485 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2486 with xpalloc. The values are still always <= INT_MAX.
2487
2488 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2489
2490 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2491 (SAFE_NALLOCA): New macro.
2492
2493 * region-cache.c (struct boundary.pos, find_cache_boundary)
2494 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2495 (set_cache_region, invalidate_region_cache)
2496 (revalidate_region_cache, know_region_cache, region_cache_forward)
2497 (region_cache_backward, pp_cache):
2498 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2499 so that ptrdiff_t * can be passed to xpalloc.
2500 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2501 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2502 (pp_cache): Don't assume cache_len fits in int.
2503 * region-cache.h: Adjust extern decls to match.
2504
2505 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2506 EMACS_INT, since either will do, for xpalloc.
2507
2508 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2509 (xnmalloc, xnrealloc, xpalloc): New functions.
2510
2511 * bidi.c (bidi_shelve_header_size): New constant.
2512 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2513 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2514
2515 * bidi.c (bidi_cache_shrink):
2516 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2517 (overlay_strings):
2518 Don't update size of array until after memory allocation succeeds,
2519 because xmalloc/xrealloc may not return.
2520 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2521 now that we have proper integer overflow checking.
2522 (record_overlay_string, overlay_strings): Catch overflows when
2523 calculating size of overlay_str_buf.
2524
2525 * callproc.c (Fcall_process): Check for size overflow when
2526 calculating size of args2.
2527 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2528 Normally we prefer signed values, but sticking with ptrdiff_t would
2529 require adding more-complicated checks.
2530
2531 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2532 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2533 Redo buffer-overflow calculations to avoid integer overflow.
2534 Add a FIXME comment where memory seems to be over-allocated.
2535
2536 * character.c (Fstring): Check for size-calculation overflow.
2537
2538 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2539 unnecessary integer overflow. Check for size overflow.
2540 (encode_coding_object): Don't update size until xmalloc succeeds.
2541
2542 * composite.c (get_composition_id): Check for overflow in glyph
2543 length calculations.
2544
2545 Integer and memory overflow fixes for display code.
2546 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2547 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2548 (scrolling_window): Check for overflow in size calculations.
2549 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2550 Don't assume glyph table len fits in int.
2551 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2552 (row_table_size): Now ptrdiff_t, not int.
2553 (scrolling_window): Avoid overflow in size calculations.
2554 Don't update size until allocation succeeds.
2555 * fns.c (concat): Check for overflow in size calculations.
2556 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2557 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2558 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2559
2560 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2561 (get_doc_string): Check for size calculation overflow.
2562 Don't update size until allocation succeeds.
2563 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2564 EMACS_INT, where ptrdiff_t will do.
2565 (Fsubstitute_command_keys): Check for string overflow.
2566
2567 * editfns.c (set_time_zone_rule): Don't assume environment length
2568 fits in int.
2569 (message_length): Now ptrdiff_t, not int.
2570 (Fmessage_box): Don't update size until allocation succeeds.
2571 Don't assume message length fits in int.
2572 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2573
2574 * emacs.c (main): Do not reallocate argv, since there is a null at
2575 the end that can be overwritten, and this way there's no need to
2576 worry about size-calculation overflow.
2577 (sort_args): Check for size-calculation overflow.
2578
2579 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2580 alloc succeeds.
2581 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2582
2583 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2584 (x_set_scroll_bar_width, x_figure_window_size):
2585 Check for integer overflow.
2586 (x_set_alpha): Do not assume XINT fits in int.
2587
2588 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2589 This is for the members text_lines, text_cols, total_lines, total_cols,
2590 where the system imposes an 'int' limit.
2591
2592 * fringe.c (Fdefine_fringe_bitmap):
2593 Don't update size until alloc works.
2594
2595 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2596 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2597
2598 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2599 Check for size-calculation overflow.
2600 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2601 do, as we prefer signed integers.
2602 (id_to_widget.max_size, id_to_widget.used)
2603 (xg_store_widget_in_map, xg_remove_widget_from_map)
2604 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2605 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2606 Use and return ptrdiff_t, not int.
2607 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2608 * gtkutil.h: Change prototypes to match the above.
2609
2610 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2611 are duplicate now that they've been promoted to lisp.h.
2612 (x_allocate_bitmap_record, x_alloc_image_color)
2613 (make_image_cache, cache_image, xpm_load):
2614 Don't update size until alloc is done.
2615 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2616 (x_detect_edges):
2617 Check for size calculation overflow.
2618 (ct_colors_allocated_max): New constant.
2619 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2620 overflow.
2621
2622 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2623 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2624 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2625 Use ptrdiff_t, not int, to count maps.
2626 (read_char_minibuf_menu_prompt): Check for overflow in size
2627 calculations. Don't update size until allocation succeeds.
2628 Redo calculations to avoid overflow.
2629 * keyboard.h: Change prototypes to match the above.
2630
2631 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2632 to count maps.
2633 (current_minor_maps): Check for size calculation overflow.
2634 * keymap.h: Change prototypes to match the above.
2635
2636 * lread.c (read1, init_obarray): Don't update size until alloc done.
2637
2638 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2639 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2640
2641 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2642 Now ptrdiff_t, not int.
2643 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2644 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2645
2646 * process.c (Fnetwork_interface_list): Check for overflow
2647 in size calculation.
2648
2649 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2650
2651 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2652 overflow. Don't bother calling xmalloc when xrealloc will do.
2653
2654 * search.c (Freplace_match): Check for size calculation overflow.
2655 (Fset_match_data): Don't assume list lengths fit in 'int'.
2656
2657 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2658 for command line length. Do not attempt to address one before the
2659 beginning of an array, as that's not portable.
2660
2661 * term.c (max_frame_lines): Remove; unused.
2662 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2663 not int.
2664 (encode_terminal_code, calculate_costs): Check for size
2665 calculation overflow.
2666 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2667 table lengths and related sizes. Don't update size until alloc
2668 done. Redo calculations to avoid overflow.
2669 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2670
2671 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2672 subtracting pointers.
2673 (gobble_line): Check for overflow more carefully. Don't update size
2674 until alloc done.
2675
2676 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2677 Don't update size until alloc done.
2678 Redo size calculations to avoid overflow.
2679 Check for size calculation overflow.
2680 (main) [DEBUG]: Fix typo in invoking tparam1.
2681
2682 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2683 Use ptrdiff_t, not int, for sizes.
2684 (store_mode_line_noprop_char): Don't update size until alloc done.
2685
2686 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2687 Use ptrdiff_t, not int, for sizes.
2688 (Finternal_make_lisp_face, cache_face):
2689 Check for size calculation overflow.
2690 (cache_face): Treat size calculation overflows as if they were
2691 memory exhaustion (the usual treatment), rather than aborting.
2692
2693 * xfns.c (x_encode_text, x_set_name_internal)
2694 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2695 sizes, since they can exceed INT_MAX in size. Check for size
2696 calculation overflow.
2697
2698 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2699 (xg_select): Check for size calculation overflow.
2700 Don't update size until alloc done.
2701
2702 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2703 as sprintf is limited to int lengths.
2704
2705 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2706 (X_LONG_MIN): New macros.
2707 Use them to make the following changes clearer.
2708 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2709 This change doesn't affect the value now, but it may help remind
2710 future maintainers not to raise the value too much later.
2711 (SELECTION_QUANTUM): Remove, replacing with ...
2712 (selection_quantum): ... new function, which avoids overflow.
2713 All uses changed.
2714 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2715 assumption that selection length fits in 'int'.
2716 (x_reply_selection_request, x_handle_selection_request)
2717 (x_get_window_property, receive_incremental_selection)
2718 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2719 (lisp_data_to_selection_data, clean_local_selection_data):
2720 Use ptrdiff_t, not int, to record length of selection.
2721 (x_reply_selection_request, x_get_window_property)
2722 (receive_incremental_selection, x_property_data_to_lisp):
2723 Redo calculations to avoid overflow.
2724 (x_reply_selection_request): When sending hint, ceiling it at
2725 X_LONG_MAX rather than relying on wraparound overflow to send
2726 something.
2727 (x_get_window_property, receive_incremental_selection)
2728 (lisp_data_to_selection_data, x_property_data_to_lisp):
2729 Check for size-calculation overflow.
2730 (x_get_window_property, receive_incremental_selection)
2731 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2732 Don't store size until memory allocation succeeds.
2733 (x_get_window_property): Plug memory leak on memory exhaustion.
2734 Don't double-block input; malloc is safe here. Don't assume 2**34
2735 - 4 fits in unsigned long. Add an xassert to check
2736 XGetWindowProperty overflow. Be more careful about overflow
2737 calculations, and distinguish size from memory overflow better.
2738 (receive_incremental_selection): When tracing, don't assume
2739 unsigned int is less than INT_MAX.
2740 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2741 harmful) conversions of unsigned short to int.
2742 (lisp_data_to_selection_data): Don't assume that integers
2743 in the range -65535 through -1 fit in an X unsigned short.
2744 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2745 result parameters unless successful. Rely on cons_to_unsigned
2746 to report problems with elements; the old code wasn't right anyway.
2747 (x_check_property_data): Check for int overflow; we cannot use
2748 a wider type due to X limits.
2749 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2750
2751 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2752
2753 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2754 (x_term_init): Check for size calculation overflow.
2755 (x_color_cells): Don't store size until memory allocation succeeds.
2756 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2757 Don't assume alloca size is less than MAX_ALLOCA.
2758 (x_term_init): Don't assume length fits in int (sprintf is limited
2759 to int size).
2760
2761 Use ptrdiff_t for composition IDs.
2762 * character.c (lisp_string_width):
2763 * composite.c (composition_table_size, n_compositions)
2764 (get_composition_id, composition_gstring_from_id):
2765 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2766 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2767 * window.c (Frecenter):
2768 Use ptrdiff_t, not int, for composition IDs.
2769 * composite.c (get_composition_id): Check for integer overflow.
2770 * composite.h: Adjust prototypes to match the above changes.
2771
2772 Use ptrdiff_t for hash table indexes.
2773 * category.c (hash_get_category_set):
2774 * ccl.c (ccl_driver):
2775 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2776 * coding.c (coding_system_charset_list, detect_coding_system):
2777 * coding.h (struct coding_system.id):
2778 * composite.c (get_composition_id, gstring_lookup_cache):
2779 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2780 * image.c (xpm_get_color_table_h):
2781 * lisp.h (hash_lookup, hash_put):
2782 * minibuf.c (Ftest_completion):
2783 Use ptrdiff_t for hash table indexes, not int (which is too
2784 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2785 32-bit --with-wide-int hosts).
2786
2787 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2788 Add a FIXME comment about memory leaks.
2789 (syms_of_charset): Don't assume xmalloc returns.
2790
2791 Don't assume that stated character widths fit in int.
2792 * character.c (Fchar_width, c_string_width, lisp_string_width):
2793 * character.h (CHAR_WIDTH):
2794 * indent.c (MULTIBYTE_BYTES_WIDTH):
2795 Use sanitize_char_width to avoid undefined and/or bad behavior
2796 with outlandish widths.
2797 * character.h (sanitize_tab_width): Rename from sanitize_width,
2798 now that we have two such functions. All uses changed.
2799 (sanitize_char_width): New inline function.
2800
2801 Don't assume that tab-width fits in int.
2802 * character.h (sanitize_width): New inline function.
2803 (SANE_TAB_WIDTH): New macro.
2804 (ASCII_CHAR_WIDTH): Use it.
2805 * indent.c (sane_tab_width): Remove. All uses replaced by
2806 SANE_TAB_WIDTH (current_buffer).
2807 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2808
2809 * fileio.c: Integer overflow issues with file modes.
2810 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2811
2812 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2813 Remove unreachable code.
2814 (read_hex, load_charset_map_from_file): Check for integer overflow.
2815
2816 * xterm.c: Don't go over XClientMessageEvent limit.
2817 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2818 (x_send_scroll_bar_event): Likewise. Check that the size does not
2819 exceed limits imposed by XClientMessageEvent, as well as the usual
2820 ptrdiff_t and size_t limits.
2821
2822 * keyboard.c: Overflow, signedness and related fixes.
2823 (make_lispy_movement): Use same integer type in forward decl
2824 that is used in the definition.
2825 (read_key_sequence, keyremap_step):
2826 Change bufsize argument back to int, undoing my 2011-03-30 change.
2827 We prefer signed types, and int is wide enough here.
2828 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2829 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2830 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2831 length, not size_t. Use ptrdiff_t for index, not int.
2832 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2833 possibility of integer overflow.
2834
2835 Overflow, signedness and related fixes for images.
2836
2837 * dispextern.h (struct it.stack[0].u.image.image_id)
2838 (struct_it.image_id, struct image.id, struct image_cache.size)
2839 (struct image_cache.used, struct image_cache.ref_count):
2840 * gtkutil.c (update_frame_tool_bar):
2841 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2842 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2843 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2844 * nsmenu.m (update_frame_tool_bar):
2845 * xdisp.c (calc_pixel_width_or_height):
2846 * xfns.c (image_cache_refcount):
2847 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2848 on typical 64-bit hosts.
2849
2850 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2851 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2852 Omit unnecessary casts to int.
2853 (parse_image_spec): Check that integers fall into 'int' range
2854 when the callers expect that.
2855 (image_ascent): Redo ascent calculation to avoid int overflow.
2856 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2857 (lookup_image): Remove unnecessary tests.
2858 (xbm_image_p): Locals are now of int, not EMACS_INT,
2859 since parse_image_check makes sure they fit into int.
2860 (png_load, gif_load, svg_load_image):
2861 Prefer int to unsigned where either will do.
2862 (tiff_handler): New function, combining the cores of the
2863 old tiff_error_handler and tiff_warning_handler.
2864 This function is rewritten to use vsnprintf and thereby avoid
2865 stack buffer overflows. It uses only the features of vsnprintf
2866 that are common to both POSIX and native Microsoft.
2867 (tiff_error_handler, tiff_warning_handler): Use it.
2868 (tiff_load, gif_load, imagemagick_load_image):
2869 Don't assume :index value fits in 'int'.
2870 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2871 (imagemagick_load_image): Check that crop parameters fit into
2872 the integer types that MagickCropImage accepts. Don't assume
2873 Vimagemagick_render_type has a nonnegative value. Don't assume
2874 size_t fits in 'long'.
2875 (gs_load): Use printmax_t to print the widest integers possible.
2876 Check for integer overflow when computing image height and width.
2877
2878 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2879
2880 * xdisp.c (redisplay_window): Don't force window start if point
2881 will be invisible in the resulting window. (Bug#9324)
2882
2883 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2884
2885 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2886 the display spec is of the form `(space ...)'.
2887 (handle_display_spec): Return the value returned by
2888 handle_single_display_spec, not just 1 or zero.
2889 (handle_single_display_spec): If the display spec is of the form
2890 `(space ...)', and specifies display in the text area, return 2
2891 rather than 1.
2892 (try_cursor_movement): Check for the need to scroll more
2893 accurately, and prefer exact match for point under bidi.
2894 Don't advance `row' beyond the last row of the window.
2895
2896 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2897 into disp_prop; all users changed.
2898
2899 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2900 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2901 for the text covered by the display property.
2902
2903 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2904
2905 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2906 Change return value to nil.
2907 (Frecord_buffer): Delete unused function.
2908
2909 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2910
2911 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2912 buffers, return left-to-right.
2913 (set_cursor_from_row): Consider candidate row a win if its glyph
2914 represents a newline and point is on that newline. Fixes cursor
2915 positioning on the newline at EOL of R2L text within L2R
2916 paragraph, and vice versa.
2917 (try_cursor_movement): Check continued rows, in addition to
2918 continuation rows. Fixes unwarranted scroll when point enters a
2919 continued line of R2L text within an L2R paragraph, or vice versa.
2920 (cursor_row_p): Consider the case of point being equal to
2921 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2922 from the end of a short line to the beginning of a continued line
2923 of R2L text within L2R paragraph.
2924 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2925 composed characters.
2926
2927 * bidi.c (bidi_check_type): Use xassert.
2928 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2929 members.
2930
2931 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2932
2933 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2934 a character.
2935
2936 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2937
2938 * nsfont.m (ns_otf_to_script): Fix typo.
2939
2940 2011-08-22 Kenichi Handa <handa@m17n.org>
2941
2942 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2943 extra slot even if the purpose is char-code-property-table.
2944
2945 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2946
2947 * xdisp.c (redisplay_window): When computing centering_position,
2948 account for the height of the header line. (Bug#8874)
2949
2950 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2951 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2952 candidate is selected by the mouse, and that candidate has a
2953 composed character under the mouse.
2954
2955 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2956 coordinates reported by pos-visible-in-window-p for a composed
2957 character in column zero.
2958
2959 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2960
2961 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2962
2963 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2964
2965 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2966 consider it a hit if to_charpos is anywhere in the range of the
2967 composed buffer positions.
2968
2969 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2970
2971 * image.c (gif_load): Don't assume that each subimage has the same
2972 dimensions as the base image. Handle disposal method that is
2973 "undefined" by the gif spec (Bug#9335).
2974
2975 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2976
2977 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2978 (Fcondition_case): Document `debug' symbol in error handler.
2979
2980 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2981
2982 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2983 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2984 from an Org mode buffer to a Speedbar frame.
2985
2986 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2987 a composition, take its buffer position from IT->cmp_it.charpos.
2988 Fixes cursor positioning at the beginning of a line that begins
2989 with a composed character.
2990
2991 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2992
2993 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2994 character bidirectional type, use STRONG_L instead. Fixes crashes
2995 in a buffer produced by `describe-categories'.
2996
2997 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2998 members before the level stack, so they would be saved and
2999 restored when copying iterator state. Fixes incorrect reordering
3000 around TABs covered by display properties.
3001
3002 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3003
3004 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3005
3006 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3007
3008 * eval.c (internal_condition_case, internal_condition_case_1)
3009 (internal_condition_case_2, internal_condition_case_n):
3010 Remove unnecessary aborts (Bug#9081).
3011
3012 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3013
3014 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3015 has no `load' handler, try opening the file locally. (Bug#9311)
3016
3017 2011-08-16 Ken Brown <kbrown@cornell.edu>
3018
3019 * gmalloc.c: Expand comment.
3020
3021 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3022
3023 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3024 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3025
3026 2011-08-16 Ken Brown <kbrown@cornell.edu>
3027
3028 Fix memory allocation problems in Cygwin build (Bug#9273).
3029
3030 * unexcw.c ( __malloc_initialized): Declare external variable.
3031 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3032
3033 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3034 New variables.
3035 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3036 dumped emacs.
3037 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3038 in the static heap.
3039 [CYGWIN] (special_realloc): New function.
3040 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3041 requests to realloc storage in the static heap.
3042
3043 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3044
3045 * bidi.c (bidi_initialize): Remove unused local.
3046
3047 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3048
3049 * bidimirror.h:
3050 * biditype.h: Remove file.
3051 * makefile.w32-in ($(BLD)/bidi.$(O)):
3052 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3053
3054 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3055
3056 * chartab.c: Improve commentary for the uniprop_table API.
3057
3058 * bidi.c (bidi_paragraph_init): Support zero value of
3059 bidi_ignore_explicit_marks_for_paragraph_level.
3060 (bidi_initialize): Use uniprop_table instead of including
3061 biditype.h and bidimirror.h.
3062
3063 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3064 coordinates of the iterator when restoring from ppos_it.
3065 (Bug#9296)
3066
3067 2011-08-14 Kenichi Handa <handa@m17n.org>
3068
3069 * process.c (create_process): Call setup_process_coding_systems
3070 after the pid of the process is set to -1 (Bug#8162).
3071
3072 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3073
3074 * xdisp.c (move_it_in_display_line_to): Don't invoke
3075 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3076 ppos_it. Fixes vertical cursor motion when line beginning is
3077 covered by an image. (Bug#9296)
3078
3079 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3080
3081 * nsterm.h (ns_run_ascript): Declare.
3082 (NSAPP_DATA2_RUNASSCRIPT): Define.
3083
3084 * nsfns.m (as_script, as_result, as_status): New static variables.
3085 (ns_run_ascript): New function.
3086 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3087 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3088 the event loop. Get status from as_status (Bug#7276).
3089
3090 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3091 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3092 the event loop (Bug#7276).
3093
3094 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3095
3096 * gnutls.c (QCgnutls_bootprop_priority)
3097 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3098 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3099 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3100 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3101 (QCgnutls_bootprop_verify_hostname_error)
3102 (QCgnutls_bootprop_callbacks_verify): Rename from
3103 Qgnutls_bootprop_..., all uses changed.
3104
3105 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3106 uses changed.
3107
3108 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3109
3110 * xfaces.c (Qframe_set_background_mode): Now static.
3111 * dispextern.h (Qframe_set_background_mode): Remove decl.
3112
3113 * process.c (Fnetwork_interface_info): Declare local only if needed.
3114
3115 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3116
3117 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3118 (Fnetwork_interface_list): Allocate in increments of bytes instead
3119 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3120 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3121 sockaddr.
3122 (struct ifflag_def): notrailers is smart on OSX.
3123 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3124 Get hardware address with getifaddrs if available.
3125
3126 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3127
3128 * xdisp.c (iterate_out_of_display_property): xassert that
3129 IT->position is set to within IT->object's boundaries. Break from
3130 the loop as soon as EOB is reached; avoids infloops in redisplay
3131 when IT->position is set up wrongly due to some bug.
3132 Set IT->current to match the bidi iterator unconditionally.
3133 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3134 entry. Force push_it to save on the stack the current
3135 buffer/string position, to be restored by pop_it. Fix flags in
3136 the iterator structure wrt the object coming from a display
3137 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3138 properties. (Bug#9284)
3139
3140 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3141
3142 * fontset.c (fontset_get_font_group): Add proper type checks.
3143 (Bug#9172)
3144
3145 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3146
3147 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3148 and LC_VERSION_MIN_MACOSX.
3149 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3150 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3151
3152 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3153
3154 * xdisp.c (forward_to_next_line_start): Allow to use the
3155 no-display-properties-and-no-overlays under bidi display.
3156 Set disp_pos in the bidi iterator to avoid searches for display
3157 properties and overlays.
3158
3159 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3160
3161 * editfns.c (Fset_time_zone_rule): Document relationship with the
3162 setenv function.
3163
3164 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3165 the font entity extracted from the cache (Bug#8109).
3166
3167 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3168
3169 * composite.c (autocmp_chars): Don't reset point. That is done by
3170 restore_point_unwind (Bug#5984).
3171
3172 2011-08-07 Juri Linkov <juri@jurta.org>
3173
3174 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3175 to show the arg `TIME' instead of `TIMEVAL'.
3176
3177 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3178
3179 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3180 display property strides EOL and includes a newline, as in
3181 longlines-mode. (Bug#9254)
3182 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3183 word-wrap under bidirectional display. (Bug#9224)
3184
3185 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3186 is non-zero, even if the data buffer is NULL. Fixes a crash in
3187 vertical-motion with longlines-mode. (Bug#9254)
3188
3189 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3190
3191 * bidi.c <bidi_cache_total_alloc>: Now static.
3192 (bidi_initialize): Initialize bidi_cache_total_alloc.
3193
3194 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3195 cache. (Bug#9221)
3196
3197 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3198 amount allocated this far in `bidi_cache_total_alloc'.
3199 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3200 non-zero, only free the data buffer without restoring the cache
3201 contents. All callers changed.
3202
3203 * dispextern.h (bidi_unshelve_cache): Update prototype.
3204
3205 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3206 (move_it_in_display_line, move_it_to)
3207 (move_it_vertically_backward, move_it_by_lines): Replace the call
3208 to xfree to an equivalent call to bidi_unshelve_cache.
3209 (move_it_in_display_line_to): Fix logic of returning
3210 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3211
3212 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3213
3214 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3215 came from a string character with a `cursor' property. (Bug#9229)
3216
3217 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3218
3219 * Makefile.in (LIB_PTHREAD): New variable.
3220 (LIBES): Add LIB_PTHREAD (Bug#9216).
3221
3222 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3223 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3224
3225 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3226
3227 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3228
3229 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3230
3231 * xterm.c (x_find_topmost_parent): New function.
3232 (x_set_frame_alpha): Find topmost parent window with
3233 x_find_topmost_parent and set the property there also (bug#9181).
3234 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3235
3236 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3237
3238 * callproc.c (Fcall_process): Avoid vfork clobbering
3239 the local vars buffer, coding_systems, current_dir.
3240
3241 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3242
3243 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3244
3245 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3246
3247 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3248 so that it is not optimized away.
3249
3250 * xdisp.c (compute_display_string_pos): Remove unused local.
3251
3252 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3253
3254 Fix slow cursor motion and scrolling in large buffers with
3255 selective display, like Org Mode buffers. (Bug#9218)
3256
3257 * dispextern.h (struct bidi_it): New member disp_prop_p.
3258
3259 * xdisp.c: Remove one-slot cache of display string positions.
3260 (compute_display_string_pos): Accept an additional argument
3261 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3262 for a display string or property. If found, set DISP_PROP_P
3263 non-zero.
3264
3265 * bidi.c (bidi_fetch_char): Accept an additional argument
3266 DISP_PROP_P, and pass it to compute_display_string_pos.
3267 Only handle text covered by a display string if DISP_PROP_P is returned
3268 non-zero. All callers of bidi_fetch_char changed.
3269
3270 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3271
3272 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3273
3274 2010-12-03 Don March <don@ohspite.net>
3275
3276 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3277 last character M-[char] is translated to ESC [char] (bug#7541).
3278
3279 2011-08-02 Kenichi Handa <handa@m17n.org>
3280
3281 * lisp.h (uniprop_table): Extern it.
3282
3283 * chartab.c (uniprop_table): Make it non-static.
3284
3285 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3286
3287 * xdisp.c (forward_to_next_line_start): Accept additional argument
3288 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3289 on the newline.
3290 (reseat_at_next_visible_line_start): Use the bidi iterator state
3291 returned by forward_to_next_line_start to restore the state of
3292 it->bidi_it after backing up to previous newline. (Bug#9212)
3293
3294 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3295
3296 * regex.c (re_comp): Protoize.
3297 (re_exec): Fix return type.
3298 (regexec): Fix type of `ret'. (Bug#9203)
3299
3300 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3301
3302 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3303 This is needed if max-image-size is a floating-point number.
3304
3305 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3306
3307 * print.c (print_object): Print empty symbol as ##.
3308
3309 * lread.c (read1): Read ## as empty symbol.
3310
3311 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3312
3313 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3314 setting frame foreground color (Bug#9175).
3315 (x_set_background_color): Likewise.
3316
3317 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3318 contents (Bug#9176).
3319 (EmacsTooltip -init): Remove bezels and add shadows to
3320 tooltip windows.
3321
3322 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3323 or scroll bar (Bug#8470).
3324
3325 * nsfont.m (nsfont_open): Remove assignment to voffset and
3326 unnecessary vars hshink, expand, hd, full_height, min_height.
3327 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3328
3329 * nsterm.h (nsfont_info): Remove voffset field.
3330
3331 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3332
3333 Implement strike-through and overline on NextStep (Bug#8863).
3334
3335 * nsfont.m (nsfont_open): Use underline position provided by font,
3336 instead of hard-coded value of 2.
3337 (nsfont_draw): Call ns_draw_text_decoration instead.
3338
3339 * nsterm.h: Add declaration for ns_draw_text_decoration.
3340
3341 * nsterm.m (ns_draw_text_decoration): New function for drawing
3342 underline, overline, and strike-through.
3343 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3344 ns_draw_text_decoration. Change treatment of cursor drawing to
3345 accommodate underlining, etc.
3346
3347 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3348
3349 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3350 default.
3351
3352 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3353
3354 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3355 Without this fix, if a signal arrives just after memory fills up,
3356 'malloc' might be invoked reentrantly.
3357
3358 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3359 In other words, assume that every image size is allowed, on non-X
3360 hosts. This assumption is probably wrong, but it lets Emacs compile.
3361
3362 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3363
3364 * regex.c (re_iswctype): Convert return values to boolean.
3365
3366 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3367
3368 * xdisp.c (compute_display_string_pos): Don't use cached display
3369 string position if the buffer had its restriction changed.
3370 (Bug#9184)
3371
3372 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3373
3374 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3375
3376 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3377
3378 Integer signedness and overflow and related fixes. (Bug#9079)
3379
3380 * bidi.c: Integer size and overflow fixes.
3381 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3382 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3383 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3384 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3385 (bidi_find_other_level_edge):
3386 Use ptrdiff_t instead of EMACS_INT where either will do.
3387 This works better on 32-bit hosts configured --with-wide-int.
3388 (bidi_cache_ensure_space): Check for size-calculation overflow.
3389 Use % rather than repeated addition, for better worst-case speed.
3390 Don't set bidi_cache_size until after xrealloc returns, because it
3391 might not return.
3392 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3393 (bidi_cache_ensure_space): Also check that the bidi cache size
3394 does not exceed that of the largest Lisp string or buffer. See Eli
3395 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3396
3397 * alloc.c (__malloc_size_t): Remove.
3398 All uses replaced by size_t. See Andreas Schwab's note
3399 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3400
3401 * image.c: Improve checking for integer overflow.
3402 (check_image_size): Assume that f is nonnull, since
3403 it is always nonnull in practice. This is one less thing to
3404 worry about when checking for integer overflow later.
3405 (x_check_image_size): New function, which checks for integer
3406 overflow issues inside X.
3407 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3408 This removes the need for a memory_full check.
3409 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3410 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3411 (xbm_read_bitmap_data): Change locals back to 'int', since
3412 their values must fit in 'int'.
3413 (xpm_load_image, png_load, tiff_load):
3414 Invoke x_create_x_image_and_pixmap earlier,
3415 to avoid much needless work if the image is too large.
3416 (tiff_load): Treat overly large images as if
3417 x_create_x_image_and_pixmap failed, not as malloc failures.
3418 (gs_load): Use x_check_image_size.
3419
3420 * gtkutil.c: Omit integer casts.
3421 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3422 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3423
3424 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3425
3426 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3427 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3428 would wrongly return t on a 64-bit host.
3429
3430 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3431 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3432 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3433 and therefore cause GCC to emit a bogus diagnostic in some cases.
3434
3435 * image.c: Integer signedness and overflow and related fixes.
3436 This is not an exhaustive set of fixes, but it's time to
3437 record what I've got.
3438 (lookup_pixel_color, check_image_size): Remove redundant decls.
3439 (check_image_size): Don't assume that arbitrary EMACS_INT values
3440 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3441 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3442 (tiff_load, imagemagick_load_image):
3443 Check for overflow in size calculations.
3444 (x_create_x_image_and_pixmap): Remove unnecessary test for
3445 xmalloc returning NULL; that can't happen.
3446 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3447 (xpm_color_bucket): Use better integer hashing function.
3448 (xpm_cache_color): Don't possibly over-allocate memory.
3449 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3450 (gif_memory_source):
3451 Use ptrdiff_t, not int or size_t, to record sizes.
3452 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3453 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3454 either works, as we prefer signed integers.
3455 (tiff_read_from_memory, tiff_write_from_memory):
3456 Return tsize_t, not size_t, since that's what the TIFF API wants.
3457 (tiff_read_from_memory): Don't fail simply because the read would
3458 go past EOF; instead, return a short read.
3459 (tiff_load): Omit no-longer-needed casts.
3460 (Fimagemagick_types): Don't assume size fits into 'int'.
3461
3462 Improve hashing quality when configured --with-wide-int.
3463 * fns.c (hash_string): New function, taken from sxhash_string.
3464 Do not discard information about ASCII character case; this
3465 discarding is no longer needed.
3466 (sxhash-string): Use it. Change sig to match it. Caller changed.
3467 * lisp.h: Declare it.
3468 * lread.c (hash_string): Remove, since we now use fns.c's version.
3469 The fns.c version returns a wider integer if --with-wide-int is
3470 specified, so this should help the quality of the hashing a bit.
3471
3472 * emacs.c: Integer overflow minor fix.
3473 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3474 Define only if GNU_LINUX.
3475 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3476
3477 * dispnew.c: Integer signedness and overflow fixes.
3478 Remove unnecessary forward decls, that were a maintenance hassle.
3479 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3480 All uses changed.
3481 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3482 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3483 (prepare_desired_row, line_draw_cost):
3484 Use int, not unsigned, where either works.
3485 (save_current_matrix, restore_current_matrix):
3486 Use ptrdiff_t, not size_t, where either works.
3487 (init_display): Check for overflow more accurately, and without
3488 relying on undefined behavior.
3489
3490 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3491 Remove, replacing with the new symbols in lisp.h. All uses changed.
3492 * fileio.c (make_temp_name):
3493 * filelock.c (lock_file_1, lock_file):
3494 * xdisp.c (message_dolog):
3495 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3496 Use pMd etc. instead.
3497 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3498 replacing the pWIDE etc. symbols removed from editfns.c.
3499
3500 * keyboard.h (num_input_events): Now uintmax_t.
3501 This is (very slightly) less likely to mess up due to wraparound.
3502 All uses changed.
3503
3504 * buffer.c: Integer signedness fixes.
3505 (alloc_buffer_text, enlarge_buffer_text):
3506 Use ptrdiff_t rather than size_t when either will do, as we prefer
3507 signed integers.
3508
3509 * alloc.c: Integer signedness and overflow fixes.
3510 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3511 (__malloc_size_t): Default to size_t, not to int.
3512 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3513 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3514 Prefer ptrdiff_t to size_t when either would do, as we prefer
3515 signed integers.
3516 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3517 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3518 Now const. Initialize with values that are in range even if char
3519 is signed.
3520 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3521 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3522 These functions do the right thing with sizes > 2**32.
3523 (check_depth): Now ptrdiff_t, not int.
3524 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3525 Adjust to new way of storing sizes. Check for size overflow bugs
3526 in rest of code.
3527 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3528 slightly wrong anyway, as it missed one instance of
3529 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3530 (refill_memory_reserve): Omit needless cast to size_t.
3531 (mark_object_loop_halt): Mark as externally visible.
3532
3533 * xselect.c: Integer signedness and overflow fixes.
3534 (Fx_register_dnd_atom, x_handle_dnd_message):
3535 Use ptrdiff_t, not size_t, since we prefer signed.
3536 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3537 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3538 x_dnd_atoms_size and x_dnd_atoms_length.
3539
3540 * doprnt.c: Prefer signed to unsigned when either works.
3541 * eval.c (verror):
3542 * doprnt.c (doprnt):
3543 * lisp.h (doprnt):
3544 * xdisp.c (vmessage):
3545 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3546 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3547 prefer signed arithmetic to avoid comparison confusion.
3548 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3549 but is a bit tricky.
3550
3551 Assume freestanding C89 headers, string.h, stdlib.h.
3552 * data.c, doprnt.c, floatfns.c, print.c:
3553 Include float.h unconditionally.
3554 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3555 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3556 * regex.c: Likewise for stddef.h, string.h.
3557 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3558 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3559 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3560 (STDC_HEADERS): Remove obsolete defines.
3561 * sysdep.c: Include limits.h unconditionally.
3562
3563 Assume support for memcmp, memcpy, memmove, memset.
3564 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3565 * regex.c (memcmp, memcpy):
3566 Remove; we assume C89 now.
3567
3568 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3569 (__malloc_safe_bcopy): Remove; no longer needed.
3570
3571 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3572 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3573 well either way, and we prefer signed to unsigned.
3574
3575 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3576
3577 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3578 closes the connection while we're reading (bug#9182).
3579
3580 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3581
3582 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3583 are specified (Bug#9168).
3584
3585 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3586
3587 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3588 Found by GCC static checking and --with-wide-int on a 32-bit host.
3589
3590 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3591
3592 * xdisp.c (compute_display_string_pos): Fix logic of caching
3593 previous display string position. Initialize cached_prev_pos to
3594 -1. Fixes slow-down at the beginning of a buffer.
3595
3596 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3597
3598 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3599 for attrs[LFACE_FONTSET_INDEX].
3600
3601 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3602
3603 * xml.c (parse_region): Remove unused local
3604 that was recently introduced.
3605
3606 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3607
3608 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3609 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3610
3611 * xdisp.c (move_it_in_display_line_to): Record the best matching
3612 position for TO_CHARPOS while scanning the line, and restore it on
3613 exit if none of the characters scanned was an exact match.
3614 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3615 when exact match is impossible due to invisible text, and the
3616 lines are truncated.
3617
3618 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3619
3620 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3621 for OSX >= 10.7.
3622
3623 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3624
3625 Fix a significant slow-down of cursor motion with C-n, C-p,
3626 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3627 auto-repeat under bidi redisplay in fontified buffers.
3628 * xdisp.c (compute_stop_pos_backwards): New function.
3629 (next_element_from_buffer): Call compute_stop_pos_backwards to
3630 find a suitable prev_stop when we find ourselves before
3631 base_level_stop.
3632 (reseat): Don't look for prev_stop, as that could mean a very long
3633 run.
3634 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3635 <cached_disp_overlay_modiff>: Cache for last found display string
3636 position.
3637 (compute_display_string_pos): Return the cached position if asked
3638 about the same buffer in the same area of character positions, and
3639 the buffer wasn't changed since the time the display string
3640 position was cached.
3641
3642 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3643
3644 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3645 is an integer, which is important for empty lines. (Bug#9149)
3646
3647 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3648
3649 * frame.c (Fmodify_frame_parameters): In tty case, update the
3650 default face if necessary (Bug#4238).
3651
3652 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3653
3654 * editfns.c (Fstring_to_char): No need to explain what a character
3655 is in the docstring (Bug#6576).
3656
3657 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3658
3659 * xml.c (parse_region): Make sure we always return a tree.
3660
3661 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3662
3663 * xml.c (parse_region): If a document contains only comments,
3664 return that, too.
3665
3666 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3667
3668 * xml.c (make_dom): Return comments, too.
3669
3670 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3671
3672 Port to OpenBSD.
3673 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3674 and the surrounding thread.
3675 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3676 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3677 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3678 timer goes off.
3679 * s/openbsd.h (BROKEN_SIGIO): Define.
3680 * unexelf.c (unexec) [__OpenBSD__]:
3681 Don't update the .mdebug section of the Alpha COFF symbol table.
3682
3683 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3684
3685 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3686 (bug#8460).
3687
3688 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3689
3690 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3691 This fixes some race conditions on the permissions of any newly
3692 created file.
3693
3694 * alloc.c (valid_pointer_p): Use pipe, not open.
3695 This fixes some permissions issues when debugging.
3696
3697 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3698 If fchown fails to set both uid and gid, try to set just gid,
3699 as that is sometimes allowed. Adjust the file's mode to eliminate
3700 setuid or setgid bits that are inappropriate if fchown fails.
3701
3702 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3703
3704 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3705 to compare Lisp_Objects.
3706 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3707 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3708 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3709
3710 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3711
3712 * lread.c (read_integer): Unread even EOF character.
3713 (read1): Likewise. Properly record start position of symbol.
3714
3715 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3716 symbol character follows.
3717
3718 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3719
3720 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3721 This works around a problem with the previous change to Fcopy_file.
3722 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3723 and without this change, GCC might complain about discarding
3724 fchown's return value.
3725
3726 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3727
3728 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3729
3730 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3731
3732 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3733
3734 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3735
3736 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3737 it's used from the C level.
3738
3739 * process.c: Use the same condition for POLL_FOR_INPUT in both
3740 keyboard.c and process.c (bug#1858).
3741
3742 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3743
3744 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3745 (Fgnutls_boot): Use it.
3746
3747 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3748
3749 * doc.c (Fsubstitute_command_keys): Revert last change.
3750
3751 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3752
3753 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3754 quotes the next character, and doesn't affect other longer
3755 sequences (bug#8935).
3756
3757 * lread.c (syms_of_lread): Clarify that is isn't only
3758 `eval-buffer' and `eval-defun' that's affected by
3759 `lexical-binding' (bug#8460).
3760
3761 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3762
3763 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3764 bidi redisplay when a line includes both an image and is truncated.
3765
3766 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3767
3768 Fix minor problems found by static checking.
3769 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3770 (elsz): Now a signed constant, not a size_t var. We prefer signed
3771 types to unsigned, to avoid integer comparison confusion. Without
3772 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3773 "cannot optimize loop, the loop counter may overflow", a symptom
3774 of the confusion.
3775 * indent.c (Fvertical_motion): Mark locals as initialized.
3776 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3777
3778 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3779
3780 * search.c (Fre_search_backward): Mention `case-fold-search' in
3781 all the re_search_* functions (bug#8138).
3782
3783 * keyboard.c (Fopen_dribble_file): Document when the file is
3784 closed (bug#8056).
3785
3786 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3787
3788 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3789 bidi_cache_idx.
3790
3791 Support bidi reordering of display and overlay strings.
3792 * xdisp.c (compute_display_string_pos)
3793 (compute_display_string_end): Accept additional argument STRING.
3794 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3795 (reseat_to_string): Initialize bidi_it->string.s and
3796 bidi_it->string.schars.
3797 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3798 NULL (avoids a crash in bidi_paragraph_init).
3799 Initialize itb.string.lstring.
3800 (init_iterator): Call bidi_init_it only of a valid
3801 buffer position was specified. Initialize paragraph_embedding to
3802 L2R.
3803 (reseat_to_string): Initialize the bidi iterator.
3804 (display_string): If we need to ignore text properties of
3805 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3806 original value of -1 will not work with bidi.)
3807 (compute_display_string_pos): First arg is now struct
3808 `text_pos *'; all callers changed. Support display properties on
3809 Lisp strings.
3810 (compute_display_string_end): Support display properties on Lisp
3811 strings.
3812 (init_iterator, reseat_1, reseat_to_string): Initialize the
3813 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3814 when iterating on a string not from display properties).
3815 (compute_display_string_pos, compute_display_string_end):
3816 Fix calculation of the object to scan. Fixes an error when using
3817 arrow keys.
3818 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3819 base_level_stop; instead, set base_level_stop to BEGV.
3820 Fixes crashes in vertical-motion.
3821 (next_element_from_buffer): Improve commentary for when
3822 the iterator is before prev_stop.
3823 (init_iterator): Initialize bidi_p from the default value of
3824 bidi-display-reordering, not from buffer-local value. Use the
3825 buffer-local value only if initializing for buffer iteration.
3826 (handle_invisible_prop): Support invisible properties on strings
3827 that are being bidi-reordered.
3828 (set_iterator_to_next): Support bidi reordering of C strings and
3829 Lisp strings.
3830 (next_element_from_string): Support bidi reordering of Lisp
3831 strings.
3832 (handle_stop_backwards): Support Lisp strings as well.
3833 (display_string): Support display of R2L glyph rows.
3834 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3835 (init_iterator): Don't initialize it->bidi_p for strings
3836 here.
3837 (reseat_to_string): Initialize it->bidi_p for strings here.
3838 (next_element_from_string, next_element_from_c_string)
3839 (next_element_from_buffer): Add xassert's for correspondence
3840 between IT's object being iterated and it->bidi_it.string
3841 structure.
3842 (face_before_or_after_it_pos): Support bidi iteration.
3843 (next_element_from_c_string): Handle the case of the first string
3844 character that is not the first one in the visual order.
3845 (get_visually_first_element): New function, refactored from common
3846 parts of next_element_from_buffer, next_element_from_string, and
3847 next_element_from_c_string.
3848 (tool_bar_lines_needed, redisplay_tool_bar)
3849 (display_menu_bar): Force left-to-right direction. Add a FIXME
3850 comment for making that be controlled by a user option.
3851 (push_it, pop_it): Save and restore the state of the
3852 bidi iterator. Save and restore the bidi_p flag.
3853 (pop_it): Iterate out of display property for string iteration as
3854 well.
3855 (iterate_out_of_display_property): Support iteration over strings.
3856 (handle_single_display_spec): Set up it->bidi_it for iteration
3857 over a display string, and call bidi_init_it.
3858 (handle_single_display_spec, next_overlay_string)
3859 (get_overlay_strings_1, push_display_prop): Set up the bidi
3860 iterator for displaying display or overlay strings.
3861 (forward_to_next_line_start): Don't use the shortcut if
3862 bidi-iterating.
3863 (back_to_previous_visible_line_start): If handle_display_prop
3864 pushed the iterator stack, restore the internal state of the bidi
3865 iterator by calling bidi_pop_it same number of times.
3866 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3867 and we are bidi-iterating, don't decrement the iterator position;
3868 instead, set the first_elt flag in the bidi iterator, to produce
3869 the same effect.
3870 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3871 (push_display_prop): xassert that we are iterating a buffer.
3872 (push_it, pop_it): Save and restore paragraph_embedding member.
3873 (handle_single_display_spec, next_overlay_string)
3874 (get_overlay_strings_1, reseat_1, reseat_to_string)
3875 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3876 correctly. Don't assume unibyte strings are not bidi-reordered.
3877 (compute_display_string_pos)
3878 (compute_display_string_end): Fix handling the case of C string.
3879 (push_it, pop_it): Save and restore from_disp_prop_p.
3880 (handle_single_display_spec, push_display_prop): Set the
3881 from_disp_prop_p flag.
3882 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3883 (pop_it): Call iterate_out_of_display_property only if we are
3884 popping after iteration over a string that came from a display
3885 property. Fix a typo in popping stretch info. Add an assertion
3886 for verifying that the iterator position is in sync with the bidi
3887 iterator.
3888 (handle_single_display_spec, get_overlay_strings_1)
3889 (push_display_prop): Fix initialization of paragraph direction for
3890 string when that of the parent object is not yet determined.
3891 (reseat_1): Call bidi_init_it to resync the bidi
3892 iterator with IT's position. (Bug#7616)
3893 (find_row_edges): If ROW->start.pos gives position
3894 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3895 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3896 Reset the from_disp_prop_p flag.
3897 (SAVE_IT, RESTORE_IT): New macros.
3898 (pos_visible_p, face_before_or_after_it_pos)
3899 (back_to_previous_visible_line_start)
3900 (move_it_in_display_line_to, move_it_in_display_line)
3901 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3902 (try_scrolling, redisplay_window, display_line): Use them when
3903 saving a temporary copy of the iterator and restoring it back.
3904 (back_to_previous_visible_line_start, reseat_1)
3905 (init_iterator): Empty the bidi cache "stack".
3906 (move_it_in_display_line_to): If iterator ended up at
3907 EOL, but we never saw any buffer positions smaller than
3908 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3909 motion in bidi-reordered lines.
3910 (move_it_in_display_line_to): Record prev_method and prev_pos
3911 immediately before the call to set_iterator_to_next. Fixes cursor
3912 motion in bidi-reordered lines with stretch glyphs and strings
3913 displayed in margins. (Bug#8133) (Bug#8867)
3914 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3915 TO_CHARPOS.
3916 (pos_visible_p): Support positions in bidi-reordered lines.
3917 Save and restore bidi cache.
3918
3919 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3920 (bidi_paragraph_info): Delete unused struct.
3921 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3922 (bidi_cache_start): New variable.
3923 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3924 to zero.
3925 (bidi_cache_fetch_state, bidi_cache_search)
3926 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3927 (bidi_cache_find, bidi_peek_at_next_level)
3928 (bidi_level_of_next_char, bidi_find_other_level_edge)
3929 (bidi_move_to_visually_next): Compare cache index with
3930 bidi_cache_start rather than with zero.
3931 (bidi_fetch_char): Accept new argument STRING; all callers
3932 changed. Support iteration over a string. Support strings with
3933 display properties. Support unibyte strings. Fix the type of
3934 `len' according to what STRING_CHAR_AND_LENGTH expects.
3935 (bidi_paragraph_init, bidi_resolve_explicit_1)
3936 (bidi_resolve_explicit, bidi_resolve_weak)
3937 (bidi_level_of_next_char, bidi_move_to_visually_next):
3938 Support iteration over a string.
3939 (bidi_set_sor_type, bidi_resolve_explicit_1)
3940 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3941 can now be zero (for strings); special values 0 and -1 were
3942 changed to -1 and -2, respectively.
3943 (bidi_char_at_pos): New function.
3944 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3945 Call it instead of FETCH_MULTIBYTE_CHAR.
3946 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3947 initialized to valid values.
3948 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3949 values.
3950 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3951 the test for valid cached positions. Fix the logic for looking up
3952 the sentinel state in the cache. GCPRO the Lisp string we are
3953 iterating.
3954 (bidi_push_it, bidi_pop_it): New functions.
3955 (bidi_initialize): Initialize the bidi cache start stack pointer.
3956 (bidi_cache_ensure_space): New function, refactored from part of
3957 bidi_cache_iterator_state. Don't assume the required size is just
3958 one BIDI_CACHE_CHUNK away.
3959 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3960 (bidi_count_bytes, bidi_char_at_pos): New functions.
3961 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3962 always valid if bidi_cache_idx is valid.
3963 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3964 is valid if it's going to be used.
3965 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3966 (bidi_cache_fetch_state, bidi_cache_search)
3967 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3968 (bidi_cache_iterator_state, bidi_cache_find)
3969 (bidi_find_other_level_edge, bidi_cache_start_stack):
3970 All variables related to cache indices are now EMACS_INT.
3971
3972 * dispextern.h (struct bidi_string_data): New structure.
3973 (struct bidi_it): New member `string'. Make flag members be 1-bit
3974 fields, and put them last in the struct.
3975 (compute_display_string_pos, compute_display_string_end):
3976 Update prototypes.
3977 (bidi_push_it, bidi_pop_it): Add prototypes.
3978 (struct iterator_stack_entry): New members bidi_p,
3979 paragraph_embedding, and from_disp_prop_p.
3980 (struct it): Member bidi_p is now a bit field 1 bit wide.
3981 (bidi_shelve_cache, bidi_unshelve_cache):
3982 Declare prototypes.
3983
3984 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3985 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3986 and vector-like objects.
3987
3988 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3989 cache around display iteration.
3990
3991 * window.c (Fwindow_end, window_scroll_pixel_based)
3992 (displayed_window_lines, Frecenter): Save and restore the bidi
3993 cache around display iteration.
3994
3995 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3996
3997 * editfns.c (Fdelete_region): Clarify the use of the named
3998 parameters (bug#6788).
3999
4000 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4001
4002 * indent.c (Fvertical_motion): Set and restore w->pointm when
4003 saving and restoring the window's buffer (Bug#9006).
4004
4005 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4006
4007 * editfns.c (Fstring_to_char): Clarify just what is returned
4008 (bug#6576). Text by Eli Zaretskii.
4009
4010 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4011
4012 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4013
4014 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4015
4016 * buffer.c (mmap_find): Fix a typo.
4017
4018 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4019
4020 Fix execution of x selection hooks.
4021 * xselect.c (Qx_lost_selection_functions)
4022 (Qx_sent_selection_functions): New vars.
4023 (syms_of_xselect): DEFSYM them.
4024 (x_handle_selection_request): Pass Qx_sent_selection_functions
4025 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4026 (x_handle_selection_clear,x_clear_frame_selections):
4027 Pass Qx_lost_selection_functions rather than
4028 Vx_lost_selection_functions to Frun_hook_with_args.
4029
4030 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4031
4032 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4033 The old code sometimes used this field without initializing it.
4034
4035 * alloc.c (gc_sweep): Don't read past end of array.
4036 In theory, the old code could also have corrupted Emacs internals,
4037 though it'd be very unlikely.
4038
4039 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4040
4041 * character.c (Fcharacterp): Don't advertise optional ignored
4042 argument. (Bug#4026)
4043
4044 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4045
4046 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4047 key" (bug#4257).
4048
4049 * window.c (Fset_window_start): Doc fix (bug#4199).
4050 (Fset_window_hscroll): Ditto.
4051
4052 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4053
4054 Fix minor new problems caught by GCC 4.6.1.
4055 * term.c (init_tty): Remove unused local.
4056 * xsettings.c (store_monospaced_changed): Define this function only
4057 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4058 not used otherwise.
4059
4060 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4061
4062 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4063
4064 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4065
4066 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4067 are the mini-buffer and the echo area (bug#3320).
4068
4069 * term.c (init_tty): Remove support for supdup, c10 and perq
4070 terminals, which are no longer supported (bug#1482).
4071
4072 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4073
4074 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4075
4076 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4077
4078 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4079 for non-popups (Bug#3642).
4080
4081 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4082
4083 * alloc.c (reset_malloc_hooks): Protoize.
4084 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4085 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4086 * cm.c (losecursor): Likewise.
4087 * data.c (fmod): Likewise.
4088 * dispnew.c (swap_glyphs_in_rows): Likewise.
4089 * emacs.c (memory_warning_signal): Likewise.
4090 * floatfns.c (float_error): Likewise.
4091 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4092 (otf_open, font_otf_capability, generate_otf_features)
4093 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4094 Likewise.
4095 * image.c (pbm_read_file): Likewise.
4096 * indent.c (string_display_width): Likewise.
4097 * intervals.c (check_for_interval, search_for_interval)
4098 (inc_interval_count, count_intervals, root_interval)
4099 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4100 * lread.c (defalias): Likewise.
4101 * ralloc.c (r_alloc_check): Likewise.
4102 * regex.c (set_image_of_range_1, set_image_of_range)
4103 (regex_grow_registers): Likewise.
4104 * sysdep.c (strerror): Likewise.
4105 * termcap.c (valid_filename_p, tprint, main): Likewise.
4106 * tparam.c (main): Likewise.
4107 * unexhp9k800.c (run_time_remap, save_data_space)
4108 (update_file_ptrs, read_header, write_header, calculate_checksum)
4109 (copy_file, copy_rest, display_header): Likewise.
4110 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4111 Likewise.
4112 * xdisp.c (check_it): Likewise.
4113 * xfaces.c (register_color, unregister_color, unregister_colors):
4114 Likewise.
4115 * xfns.c (print_fontset_result): Likewise.
4116 * xrdb.c (member, fatal, main): Likewise.
4117
4118 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4119
4120 Fix minor problems found by static checking (Bug#9031).
4121 * chartab.c (char_table_set_range, map_sub_char_table):
4122 Remove unused locals.
4123 (uniprop_table): Now static.
4124 * composite.c (_work_char): Remove unused static var.
4125
4126 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4127
4128 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4129
4130 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4131
4132 * gtkutil.c (qttip_cb): Remove code without function.
4133
4134 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4135
4136 * w32.c (pthread_sigmask): New stub.
4137
4138 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4139
4140 Use pthread_sigmask, not sigprocmask (Bug#9010).
4141 sigprocmask is portable only for single-threaded applications, and
4142 Emacs can be multi-threaded when it uses GTK.
4143 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4144 (LIBES): Use it.
4145 * callproc.c (Fcall_process):
4146 * process.c (create_process):
4147 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4148 Use pthread_sigmask, not sigprocmask.
4149
4150 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4151
4152 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4153 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4154 wrong (Bug#8591).
4155
4156 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4157
4158 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4159 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4160 (xg_hide_tooltip): Fix comment.
4161
4162 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4163 in registerServicesMenuSendTypes.
4164 (validRequestorForSendType): Don't check ns_return_types.
4165
4166 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4167 ns_return_type.
4168
4169 2011-07-08 Jason Rumney <jasonr@gnu.org>
4170
4171 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4172 SH_SHOW for hidden windows (Bug#5482).
4173
4174 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4175 frame struct members of non-existent frames (Bug#6284).
4176
4177 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4178
4179 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4180 variable firstTime not needed on OSX >= 10.6.
4181 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4182 >= 10.5. Use setKnobProportion, setDoubleValue.
4183
4184 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4185 (MAC_OS_X_VERSION_10_5): Define if not defined.
4186 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4187 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4188 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4189
4190 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4191 cString and lossyCString on OSX >= 10.4
4192
4193 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4194 sizeToFit on OSX >= 10.2.
4195
4196 * nsimage.m (allocInitFromFile): Don't use deprecated method
4197 bestRepresentationForDevice on OSX >= 10.6.
4198
4199 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4200 to avoid warning.
4201
4202 * emacs.c: Declare unexec_init_emacs_zone.
4203
4204 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4205
4206 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4207
4208 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4209 on svcsMenu (Bug#8842).
4210
4211 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4212 ns_return_types.
4213 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4214
4215 * nsterm.m (QUTF8_STRING): Declare.
4216 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4217 (validRequestorForSendType): Return type is (id).
4218 Change indexOfObjectIdenticalTo to indexOfObject.
4219 Check if we have local selection before returning self (Bug#8842).
4220 (writeSelectionToPasteboard): Put local selection into paste board
4221 if we have a local selection (Bug#8842).
4222 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4223
4224 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4225 (ns_get_local_selection): Declare.
4226
4227 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4228
4229 * keymap.c (describe_map_tree): Don't insert a double newline at
4230 the end of the buffer (bug#1169) and return whether we inserted
4231 something.
4232
4233 * callint.c (Fcall_interactively): Change "reading args" to
4234 "providing args" to try to clarify what it does (bug#1010).
4235
4236 2011-07-07 Kenichi Handa <handa@m17n.org>
4237
4238 * composite.c (composition_compute_stop_pos): Ignore a static
4239 composition starting before CHARPOS (Bug#8915).
4240
4241 * xdisp.c (handle_composition_prop): Likewise.
4242
4243 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4244
4245 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4246 (Bug#9015)
4247
4248 2011-07-07 Kenichi Handa <handa@m17n.org>
4249
4250 * character.h (unicode_category_t): New enum type.
4251
4252 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4253 (Qchar_code_property_table): New variable.
4254 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4255 (UNIPROP_COMPRESSED_FORM_P): New macros.
4256 (char_table_ascii): Uncompress the compressed values.
4257 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4258 Uncompress the compressed values.
4259 (sub_char_table_ref_and_range): Likewise.
4260 (char_table_ref_and_range): Uncompress the compressed values.
4261 (sub_char_table_set): New arg is_uniprop. Callers changed.
4262 Uncompress the compressed values.
4263 (sub_char_table_set_range): Args changed. Callers changed.
4264 (char_table_set_range): Adjuted for the above change.
4265 (map_sub_char_table): Delete args default_val and parent. Add arg
4266 top. Give decoded values to a Lisp function.
4267 (map_char_table): Adjust for the above change. Give decoded
4268 values to a Lisp function. Gcpro more variables.
4269 (uniprop_table_uncompress)
4270 (uniprop_decode_value_run_length): New functions.
4271 (uniprop_decoder, uniprop_decoder_count): New variables.
4272 (uniprop_get_decoder, uniprop_encode_value_character)
4273 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4274 New functions.
4275 (uniprop_encoder, uniprop_encoder_count): New variables.
4276 (uniprop_get_encoder, uniprop_table)
4277 (Funicode_property_table_internal, Fget_unicode_property_internal)
4278 (Fput_unicode_property_internal): New functions.
4279 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4280 Sunicode_property_table_internal, Sget_unicode_property_internal,
4281 and Sput_unicode_property_internal. Defvar_lisp
4282 char-code-property-alist.
4283
4284 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4285 Vunicode_category_table.
4286
4287 * font.c (font_range): Adjust for the change of
4288 Vunicode_category_table.
4289
4290 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4291
4292 * m/iris4d.h: Remove file, move contents ...
4293 * s/irix6-5.h: ... here.
4294
4295 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4296
4297 Remove unportable assumption about struct layout (Bug#8884).
4298 * alloc.c (mark_buffer):
4299 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4300 (clone_per_buffer_values): Don't assume that
4301 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4302 This isn't true in general, and it's particularly not true
4303 if Emacs is configured with --with-wide-int.
4304 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4305 New macros, used in the buffer.c change.
4306
4307 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4308
4309 * xsettings.c: Use both GConf and GSettings if both are available.
4310 (store_config_changed_event): Add comment.
4311 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4312 (store_tool_bar_style_changed): New functions.
4313 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4314 (struct xsettings): Move font inside HAVE_XFT.
4315 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4316 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4317 Move inside HAVE_XFT.
4318 (something_changed_gsettingsCB): Rename from something_changedCB.
4319 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4320 also.
4321 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4322 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4323 (something_changed_gconfCB): Rename from something_changedCB.
4324 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4325 (parse_settings): Move check for font inside HAVE_XFT.
4326 (read_settings, apply_xft_settings): Add comment.
4327 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4328 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4329 call store_font_name_changed.
4330 (xft_settings_event): Add comment.
4331 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4332 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4333 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4334 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4335 (xsettings_initialize): Call init_gsettings last.
4336 (xsettings_get_system_font, xsettings_get_system_normal_font):
4337 Add comment.
4338
4339 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4340
4341 Random fixes. E.g., (random) never returned negative values.
4342 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4343 subseconds part to the entropy, as that's a bit more random.
4344 Prefer signed to unsigned, since the signedness doesn't matter and
4345 in general we prefer signed. When given a limit, use a
4346 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4347 latter isn't right if USE_2_TAGS_FOR_INTS.
4348 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4349 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4350
4351 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4352
4353 * textprop.c (text_property_stickiness):
4354 Obey Vtext_property_default_nonsticky.
4355 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4356 * w32fns.c (syms_of_w32fns):
4357 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4358
4359 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4360
4361 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4362 This is more efficient than Ffile_directory_p and avoids a minor race.
4363
4364 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4365
4366 * buffer.c (Foverlay_put): Say what the return value is
4367 (bug#7835).
4368
4369 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4370 is a directory before asking whether to use the file name
4371 (bug#7564).
4372 (barf_or_query_if_file_exists): Make the "File is a directory"
4373 error be more correct.
4374
4375 * fns.c (Frequire): Remove the mention of the .gz files, since
4376 that's installation-specific, but keep the mention of
4377 `get-load-suffixes'.
4378
4379 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4380
4381 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4382 Report string overflow if the output is too long.
4383
4384 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4385
4386 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4387 (syms_of_gnutls): Remove duplicate DEFSYM for
4388 Qgnutls_bootprop_verify_hostname_error, an error for
4389 Qgnutls_bootprop_verify_error (which is no longer used).
4390
4391 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4392 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4393 Also (re)move comments that are misplaced or no longer relevant.
4394
4395 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4396
4397 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4398
4399 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4400
4401 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4402 and background color parameters if they have been changed.
4403
4404 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4405
4406 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4407
4408 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4409
4410 * xsettings.c (SYSTEM_FONT): Define only when used.
4411 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4412
4413 * keymap.c (access_keymap_1): Now static.
4414
4415 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4416
4417 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4418 leave any prefix arg for the up event (Bug#1586).
4419
4420 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4421
4422 * lread.c (syms_of_lread): Mention single symbols defined by
4423 `defvar' or `defconst' (bug#7154).
4424
4425 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4426 (Frequire): Mention get-load-suffixes.
4427
4428 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4429
4430 * window.h (window): Remove clone_number slot.
4431 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4432 Remove.
4433 (make_parent_window, make_window, saved_window)
4434 (Fset_window_configuration, save_window_save): Don't deal with
4435 clone numbers.
4436 * buffer.c (Qclone_number): Remove declaration.
4437 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4438
4439 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4440
4441 Add multiple inheritance to keymaps.
4442 * keymap.c (Fmake_composed_keymap): New function.
4443 (Fset_keymap_parent): Simplify.
4444 (fix_submap_inheritance): Remove.
4445 (access_keymap_1): New function extracted from access_keymap to handle
4446 embedded parents and handle lists of maps.
4447 (access_keymap): Use it.
4448 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4449 (Fcopy_keymap): Handle embedded parents.
4450 (Fcommand_remapping, define_as_prefix): Simplify.
4451 (Fkey_binding): Simplify.
4452 (syms_of_keymap): Move minibuffer-local-completion-map,
4453 minibuffer-local-filename-completion-map,
4454 minibuffer-local-must-match-map, and
4455 minibuffer-local-filename-must-match-map to Elisp.
4456 (syms_of_keymap): Defsubr make-composed-keymap.
4457 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4458 (parse_menu_item): Trivial simplification.
4459
4460 2011-07-01 Glenn Morris <rgm@gnu.org>
4461
4462 * Makefile.in (SETTINGS_LIBS): Fix typo.
4463
4464 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4465
4466 * coding.c (Fencode_coding_string): Record the last coding system
4467 used, as the function doc string says (bug#8738).
4468
4469 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4470
4471 * xsettings.c (store_monospaced_changed): Take new font as arg and
4472 check for change against current_mono_font.
4473 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4474 (emacs_settings_constructor, emacs_settings_get_property)
4475 (emacs_settings_set_property, emacs_settings_class_init)
4476 (emacs_settings_init, gsettings_obj): Remove.
4477 (something_changedCB): New function for HAVE_GSETTINGS.
4478 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4479 with value as argument.
4480 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4481 g_settings_new (Bug#8967). Do not create gsettings_obj.
4482 Remove calls to g_settings_bind. Connect something_changedCB to
4483 "changed".
4484
4485 * xgselect.c: Add defined (HAVE_GSETTINGS).
4486 (xgselect_initialize): Ditto.
4487
4488 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4489 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4490 xg_select.
4491
4492 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4493
4494 * eval.c (struct backtrace): Simplify and port the data structure.
4495 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4496 signed bit field, as this assumption is not portable and it makes
4497 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4498 "char debug_on_exit : 1" as this is not portable either; instead,
4499 use the portable "unsigned int debug_on_exit : 1". Remove unused
4500 member evalargs. Remove obsolete comments about cc bombing out.
4501
4502 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4503
4504 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4505 Let HAVE_GSETTINGS override HAVE_GCONF.
4506 (store_monospaced_changed): New function.
4507 (EMACS_SETTINGS): A new type derived from GObject to handle
4508 GSettings notifications.
4509 (emacs_settings_constructor, emacs_settings_get_property)
4510 (emacs_settings_set_property, emacs_settings_class_init):
4511 New functions.
4512 (gsettings_client, gsettings_obj): New variables.
4513 (GSETTINGS_SCHEMA): New define.
4514 (something_changedCB): Call store_monospaced_changed.
4515 (init_gsettings): New function.
4516 (xsettings_initialize): Call init_gsettings.
4517 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4518 to NULL.
4519
4520 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4521 GCONF_CFLAGS/LIBS.
4522
4523 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4524
4525 * window.c (resize_root_window, grow_mini_window)
4526 (shrink_mini_window): Rename Qresize_root_window to
4527 Qwindow_resize_root_window and Qresize_root_window_vertically to
4528 Qwindow_resize_root_window_vertically.
4529
4530 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4531
4532 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4533
4534 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4535
4536 * makefile.w32-in: Redesign dependencies so they reflect more
4537 clearly which files are directly included by each source file,
4538 and not through other includes.
4539
4540 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4541
4542 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4543 (sort_overlays, overlay_strings): When an overlay's clone number
4544 matches the window's clone number process the overlay even if
4545 the overlay's window property doesn't match the current window.
4546
4547 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4548 (Fwindow_hchild): Rename to Fwindow_left_child.
4549 (Fwindow_next): Rename to Fwindow_next_sibling.
4550 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4551 (resize_window_check): Rename to window_resize_check.
4552 (resize_window_apply): Rename to window_resize_apply.
4553 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4554 (Fdelete_other_windows_internal, resize_frame_windows)
4555 (Fsplit_window_internal, Fdelete_window_internal)
4556 (grow_mini_window, shrink_mini_window)
4557 (Fresize_mini_window_internal): Fix callers accordingly.
4558
4559 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4560
4561 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4562 (emacs_fixed_set_min_size): Remove.
4563 (emacs_fixed_new): Take frame as argument.
4564
4565 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4566 (_EmacsFixedPrivate): Remove minwidth/height.
4567 Add struct frame *f.
4568 (emacs_fixed_init): Initialize priv->f.
4569 (get_parent_class, emacs_fixed_set_min_size): Remove.
4570 (emacs_fixed_new): Set priv->f to argument.
4571 (emacs_fixed_get_preferred_width)
4572 (emacs_fixed_get_preferred_height): Use min_width/height from
4573 frames size_hint to set minimum and natural (Bug#8919).
4574 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4575 and use min_width/height from frames size_hint to set
4576 min_width/height (Bug#8919).
4577
4578 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4579 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4580 Fix indentation.
4581
4582 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4583
4584 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4585 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4586 called at ZV.
4587
4588 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4589
4590 * process.c (wait_reading_process_output): Bypass select if
4591 waiting for a cell while ignoring keyboard input, and input is
4592 pending. Suggested by Jan Djärv (Bug#8869).
4593
4594 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4595
4596 Use gnulib's dup2 module instead of rolling our own.
4597 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4598
4599 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4600
4601 * dispnew.c (scrolling_window): Before scrolling, turn off a
4602 mouse-highlight in the window being scrolled.
4603
4604 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4605
4606 Move DEFSYM to lisp.h and use everywhere.
4607
4608 * character.h (DEFSYM): Move declaration...
4609 * lisp.h (DEFSYM): ...here.
4610
4611 * gnutls.c:
4612 * minibuf.c:
4613 * w32menu.c:
4614 * w32proc.c:
4615 * w32select.c: Don't include character.h.
4616
4617 * alloc.c (syms_of_alloc):
4618 * buffer.c (syms_of_buffer):
4619 * bytecode.c (syms_of_bytecode):
4620 * callint.c (syms_of_callint):
4621 * casefiddle.c (syms_of_casefiddle):
4622 * casetab.c (init_casetab_once):
4623 * category.c (init_category_once, syms_of_category):
4624 * ccl.c (syms_of_ccl):
4625 * cmds.c (syms_of_cmds):
4626 * composite.c (syms_of_composite):
4627 * dbusbind.c (syms_of_dbusbind):
4628 * dired.c (syms_of_dired):
4629 * dispnew.c (syms_of_display):
4630 * doc.c (syms_of_doc):
4631 * editfns.c (syms_of_editfns):
4632 * emacs.c (syms_of_emacs):
4633 * eval.c (syms_of_eval):
4634 * fileio.c (syms_of_fileio):
4635 * fns.c (syms_of_fns):
4636 * frame.c (syms_of_frame):
4637 * fringe.c (syms_of_fringe):
4638 * insdel.c (syms_of_insdel):
4639 * keymap.c (syms_of_keymap):
4640 * lread.c (init_obarray, syms_of_lread):
4641 * macros.c (syms_of_macros):
4642 * msdos.c (syms_of_msdos):
4643 * print.c (syms_of_print):
4644 * process.c (syms_of_process):
4645 * search.c (syms_of_search):
4646 * sound.c (syms_of_sound):
4647 * syntax.c (init_syntax_once, syms_of_syntax):
4648 * terminal.c (syms_of_terminal):
4649 * textprop.c (syms_of_textprop):
4650 * undo.c (syms_of_undo):
4651 * w32.c (globals_of_w32):
4652 * window.c (syms_of_window):
4653 * xdisp.c (syms_of_xdisp):
4654 * xfaces.c (syms_of_xfaces):
4655 * xfns.c (syms_of_xfns):
4656 * xmenu.c (syms_of_xmenu):
4657 * xsettings.c (syms_of_xsettings):
4658 * xterm.c (syms_of_xterm): Use DEFSYM.
4659
4660 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4661
4662 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4663
4664 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4665
4666 Integer and buffer overflow fixes (Bug#8873).
4667
4668 * print.c (printchar, strout): Check for string overflow.
4669 (PRINTPREPARE, printchar, strout):
4670 Don't set size unless allocation succeeds.
4671
4672 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4673 for sizes. Check for string overflow more accurately.
4674 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4675
4676 * macros.c: Integer and buffer overflow fixes.
4677 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4678 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4679 Use ptrdiff_t, not int, for sizes.
4680 Don't increment bufsize until after realloc succeeds.
4681 Check for size-calculation overflow.
4682 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4683
4684 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4685
4686 * lread.c: Integer overflow fixes.
4687 (read_integer): Radix is now EMACS_INT, not int,
4688 to improve quality of diagnostics for out-of-range radices.
4689 Calculate buffer size correctly for out-of-range radices.
4690 (read1): Check for integer overflow in radices, and in
4691 read-circle numbers.
4692 (read_escape): Avoid int overflow.
4693 (Fload, openp, read_buffer_size, read1)
4694 (substitute_object_recurse, read_vector, read_list, map_obarray):
4695 Use ptrdiff_t, not int, for sizes.
4696 (read1): Use EMACS_INT, not int, for sizes.
4697 Check for size overflow.
4698
4699 * image.c (cache_image): Check for size arithmetic overflow.
4700
4701 * lread.c: Integer overflow issues.
4702 (saved_doc_string_size, saved_doc_string_length)
4703 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4704 Now ptrdiff_t, not int.
4705 (read1): Don't assume doc string length fits in int. Check for
4706 out-of-range doc string lengths.
4707 (read_list): Don't assume file position fits in int.
4708 (read_escape): Check for hex character overflow.
4709
4710 2011-06-22 Leo Liu <sdl.web@gmail.com>
4711
4712 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4713 Move to minibuffer.el.
4714
4715 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4716
4717 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4718 The following patches are for when GLYPH_DEBUG && !XASSERT.
4719 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4720 * dispnew.c (flush_stdout):
4721 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4722 Mark as externally visible.
4723 * dispnew.c (check_window_matrix_pointers): Now static.
4724 * dispnew.c (window_to_frame_vpos):
4725 * xfns.c (unwind_create_frame):
4726 * xterm.c (x_check_font): Remove unused local.
4727 * scroll.c (CHECK_BOUNDS):
4728 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4729 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4730 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4731 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4732 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4733 Now static.
4734 (debug_method_add): Use va_list and vsprintf rather than relying
4735 on undefined behavior with wrong number of arguments.
4736 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4737 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4738 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4739 since we're not interested in debugging glyphs with old libraries.
4740 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4741 GCC 4.6.0's static checking.
4742
4743 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4744
4745 Integer overflow and signedness fixes (Bug#8873).
4746 A few related buffer overrun fixes, too.
4747
4748 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4749
4750 * dispextern.h (struct face.stipple):
4751 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4752 (x_bitmap_mask, x_allocate_bitmap_record)
4753 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4754 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4755 (x_create_bitmap_from_xpm_data):
4756 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4757 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4758 (.bitmaps_last):
4759 * xfaces.c (load_pixmap):
4760 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4761 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4762 (.bitmaps_last, struct x_output.icon_bitmap):
4763 Use ptrdiff_t, not int, for bitmap indexes.
4764 (x_allocate_bitmap_record): Check for size overflow.
4765 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4766
4767 Use ptrdiff_t, not int, for overlay counts.
4768 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4769 * editfns.c (overlays_around, get_pos_property):
4770 * textprop.c (get_char_property_and_overlay):
4771 * xdisp.c (next_overlay_change, note_mouse_highlight):
4772 * xfaces.c (face_at_buffer_position):
4773 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4774 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4775 (Fnext_overlay_change, Fprevious_overlay_change)
4776 (mouse_face_overlay_overlaps, Foverlays_in):
4777 Use ptrdiff_t, not int, for sizes.
4778 (overlays_at, overlays_in): Check for size-calculation overflow.
4779
4780 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4781
4782 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4783 (x_session_initialize): Do not assume string length fits in int.
4784
4785 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4786 This is unlikely, but can occur if DPI is outlandish.
4787
4788 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4789 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4790
4791 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4792 * xrdb.c (magic_file_p, search_magic_path):
4793 Omit last arg SUFFIX; it was always 0. All callers changed.
4794 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4795
4796 * xfont.c (xfont_match): Avoid need for strlen.
4797
4798 * xfns.c: Don't assume strlen fits in int.
4799 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4800
4801 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4802 not unsigned long, as we prefer signed integers. All callers changed.
4803 Detect integer overflow in repeat count.
4804 (message_dolog): Don't assume print length fits in 39 bytes.
4805 (display_mode_element): Don't assume strlen fits in int.
4806
4807 * termcap.c: Don't assume sizes fit in int and never overflow.
4808 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4809 (gobble_line): Check for size-calculation overflow.
4810
4811 * minibuf.c (Fread_buffer):
4812 * lread.c (intern, intern_c_string):
4813 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4814 Don't assume string length fits in int.
4815
4816 * keyboard.c (parse_tool_bar_item):
4817 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4818
4819 * font.c: Don't assume string length fits in int.
4820 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4821 Use ptrdiff_t, not int.
4822 (font_intern_prop): Don't assume string length fits in int.
4823 Don't assume integer property fits in fixnum.
4824 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4825
4826 * filelock.c: Fix some buffer overrun and integer overflow issues.
4827 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4828 Reformulate so as not to need the command string.
4829 Invoke gzip -cd rather than gunzip, as it's more portable.
4830 (lock_info_type, lock_file_1, lock_file):
4831 Don't assume pid_t and time_t fit in unsigned long.
4832 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4833 (current_lock_owner): Prefer signed type for sizes.
4834 Use memcpy, not strncpy, where memcpy is what is really wanted.
4835 Don't assume (via atoi) that time_t and pid_t fit in int.
4836 Check for time_t and/or pid_t out of range, e.g., via a network share.
4837 Don't alloca where an auto var works fine.
4838
4839 * fileio.c: Fix some integer overflow issues.
4840 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4841 Don't assume string length fits in int.
4842 (directory_file_name): Don't assume string length fits in long.
4843 (make_temp_name): Don't assume pid fits in int, or that its print
4844 length is less than 20.
4845
4846 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4847
4848 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4849
4850 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4851
4852 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4853 We prefer signed integers, even for size calculations.
4854
4855 * emacs.c: Don't assume string length fits in 'int'.
4856 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4857 (main): Don't invoke strlen when not needed.
4858
4859 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4860 (XD_DEBUG_MESSAGE): Don't waste a byte.
4861
4862 * callproc.c (getenv_internal_1, getenv_internal)
4863 (Fgetenv_internal):
4864 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4865
4866 * lread.c (invalid_syntax): Omit length argument.
4867 All uses changed. This doesn't fix a bug, but it simplifies the
4868 code away from its former Hollerith-constant appearance, and it's
4869 one less 'int' to worry about when looking at integer-overflow issues.
4870 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4871
4872 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4873 This didn't break anything, but it didn't help either.
4874 It's confusing to put a bogus integer in a place where the actual
4875 value does not matter.
4876 (LIST_END_P): Remove unused macro and its bogus comment.
4877 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4878
4879 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4880 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4881 implementation.
4882 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4883 We prefer signed types, and the value cannot exceed the EMACS_INT
4884 range anyway (because otherwise the length would not be representable).
4885 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4886 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4887 This avoids a GCC warning when WIDE_EMACS_INT.
4888
4889 * indent.c (sane_tab_width): New function.
4890 (current_column, scan_for_column, Findent_to, position_indentation)
4891 (compute_motion): Use it. This is just for clarity.
4892 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4893
4894 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4895
4896 * lisp.h (lint_assume): New macro.
4897 * composite.c (composition_gstring_put_cache):
4898 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4899
4900 * editfns.c, insdel.c:
4901 Omit unnecessary forward decls, to simplify future changes.
4902
4903 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4904
4905 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4906
4907 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4908 Use much-faster test for byte-length change.
4909 Don't assume string byte-length fits in 'int'.
4910 Check that character arg fits in 'int'.
4911 (mapcar1): Declare byte as byte, for clarity.
4912
4913 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4914
4915 * fns.c (concat): Catch string overflow earlier.
4916 Do not rely on integer wraparound.
4917
4918 * dispextern.h (struct it.overlay_strings_charpos)
4919 (struct it.selective): Now EMACS_INT, not int.
4920 * xdisp.c (forward_to_next_line_start)
4921 (back_to_previous_visible_line_start)
4922 (reseat_at_next_visible_line_start, next_element_from_buffer):
4923 Don't arbitrarily truncate the value of 'selective' to int.
4924
4925 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4926
4927 * composite.c: Don't truncate sizes to 'int'.
4928 (composition_gstring_p, composition_reseat_it)
4929 (composition_adjust_point): Use EMACS_INT, not int.
4930 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4931 not EMACS_UINT, for indexes.
4932
4933 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4934
4935 * buffer.c: Include <verify.h>.
4936 (struct sortvec.priority, struct sortstr.priority):
4937 Now EMACS_INT, not int.
4938 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4939 (struct sortstr.size, record_overlay_string)
4940 (struct sortstrlist.size, struct sortlist.used):
4941 Don't truncate size to int.
4942 (record_overlay_string): Check for size-calculation overflow.
4943 (init_buffer_once): Check at compile-time, not run-time.
4944
4945 2011-06-22 Jim Meyering <meyering@redhat.com>
4946
4947 Don't leak an XBM-image-sized buffer
4948 * image.c (xbm_load): Free the image buffer after using it.
4949
4950 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4951
4952 Port to Sun C.
4953 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4954 that Sun C diagnosed.
4955 * fns.c (secure_hash): Fix pointer signedness issue.
4956 * intervals.c (static_offset_intervals): New function.
4957 (offset_intervals): Use it.
4958
4959 2011-06-21 Leo Liu <sdl.web@gmail.com>
4960
4961 * deps.mk (fns.o):
4962 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4963 sha512.h.
4964
4965 * fns.c (secure_hash): Rename from crypto_hash_function and change
4966 the first arg to accept symbols.
4967 (Fsecure_hash): New primitive.
4968 (syms_of_fns): New symbols.
4969
4970 2011-06-20 Deniz Dogan <deniz@dogan.se>
4971
4972 * process.c (Fset_process_buffer): Clarify return value in
4973 docstring.
4974
4975 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4976
4977 * dispnew.c (add_window_display_history): Use BVAR.
4978
4979 * xdisp.c (debug_method_add): Use BVAR.
4980 (check_window_end, dump_glyph_matrix, dump_glyph)
4981 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4982
4983 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4984 Likewise.
4985
4986 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4987 check till after the cache is created in init_frame_faces.
4988
4989 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4990
4991 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4992
4993 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4994
4995 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4996 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4997 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4998
4999 Improve buffer-overflow checking (Bug#8873).
5000 * fileio.c (Finsert_file_contents):
5001 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5002 Remove the old (too-loose) buffer overflow checks.
5003 They weren't needed, since make_gap checks for buffer overflow.
5004 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5005 The old code merely checked for Emacs fixnum overflow, and relied
5006 on undefined (wraparound) behavior. The new code avoids undefined
5007 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5008
5009 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5010 Tune. Don't use wider integers than needed. Don't use alloca.
5011 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5012
5013 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5014
5015 * insdel.c, lisp.h (buffer_overflow): New function.
5016 (insert_from_buffer_1, replace_range, replace_range_2):
5017 * insdel.c (make_gap_larger):
5018 * editfns.c (Finsert_char):
5019 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5020
5021 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5022
5023 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5024
5025 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5026
5027 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5028 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5029
5030 * fileio.c: Don't assume EMACS_INT fits in off_t.
5031 (emacs_lseek): New static function.
5032 (Finsert_file_contents, Fwrite_region): Use it.
5033 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5034
5035 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5036
5037 * fns.c: Don't overflow int when computing a list length.
5038 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5039 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5040 truncation on 64-bit hosts. Check for QUIT every
5041 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5042 faster and is responsive enough.
5043 (Flength): Report an error instead of overflowing an integer.
5044 (Fsafe_length): Return a float if the value is not representable
5045 as a fixnum. This shouldn't happen except in contrived situations.
5046 (Fnthcdr, Fsort): Don't assume list length fits in int.
5047 (Fcopy_sequence): Don't assume vector length fits in int.
5048
5049 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5050 (header_size, word_size): New constants.
5051 (allocate_vectorlike): Don't check size overflow here.
5052 (allocate_vector): Check it here instead, since this is the only
5053 caller of allocate_vectorlike that could cause overflow.
5054 Check that the new vector's length is representable as a fixnum.
5055
5056 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5057 The previous code was bogus. For example, next_almost_prime (32)
5058 returned 39, which is undesirable as it is a multiple of 3; and
5059 next_almost_prime (24) returned 25, which is a multiple of 5 so
5060 why was the code bothering to check for multiples of 7?
5061
5062 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5063
5064 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5065
5066 Variadic C functions now count arguments with ptrdiff_t.
5067 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5068 Back then I didn't know that the Emacs coding style prefers signed int.
5069 Also, in the meantime I found a few more instances where arguments
5070 were being counted with int, which may truncate counts on 64-bit
5071 machines, or EMACS_INT, which may be unnecessarily wide.
5072 * lisp.h (struct Lisp_Subr.function.aMANY)
5073 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5074 Arg counts are now ptrdiff_t, not size_t.
5075 All variadic functions and their callers changed accordingly.
5076 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5077 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5078 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5079 * callint.c (Fcall_interactively): Check arg count for overflow,
5080 to avoid potential buffer overrun. Use signed char, not 'int',
5081 for 'varies' array, so that we needn't bother to check its size
5082 calculation for overflow.
5083 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5084 * eval.c (apply_lambda):
5085 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5086 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5087 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5088
5089 * callint.c (Fcall_interactively): Don't use index var as event count.
5090
5091 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5092 * mem-limits.h (SIZE): Remove; no longer used.
5093
5094 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5095
5096 Remove unnecessary casts.
5097 * xterm.c (x_term_init):
5098 * xfns.c (x_set_border_pixel):
5099 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5100 These aren't needed now that we assume ANSI C.
5101
5102 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5103 It's more likely to cause problems (due to unsigned overflow)
5104 than to cure them.
5105
5106 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5107
5108 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5109
5110 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5111
5112 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5113
5114 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5115
5116 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5117
5118 GLYPH_CODE_FACE returns EMACS_INT, not int.
5119 * dispextern.h (merge_faces):
5120 * xfaces.c (merge_faces):
5121 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5122 Don't assume EMACS_INT fits in int.
5123
5124 * character.h (CHAR_VALID_P): Remove unused parameter.
5125 * fontset.c, lisp.h, xdisp.c: All uses changed.
5126
5127 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5128
5129 * fns.c (concat): Minor tuning based on overflow analysis.
5130 This doesn't fix any bugs. Use int to hold character, instead
5131 of constantly refetching from Emacs object. Use XFASTINT, not
5132 XINT, for value known to be a character. Don't bother comparing
5133 a single byte to 0400, as it's always less.
5134
5135 * floatfns.c (Fexpt):
5136 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5137
5138 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5139 for characters.
5140
5141 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5142
5143 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5144 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5145 incorrectly succeed when S was a string, because 4294967386 was
5146 truncated before it was used.
5147
5148 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5149 Otherwise, an out-of-range integer could cause undefined behavior
5150 on a 64-bit host.
5151
5152 * composite.c: Use int, not EMACS_INT, for characters.
5153 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5154 EMACS_INT, for values that are known to be in character range.
5155 This doesn't fix any bugs but is the usual style inside Emacs and
5156 may generate better code on 32-bit machines.
5157
5158 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5159 This is for reasons similar to the recent CHAR_STRING fix.
5160 * charset.c (Fencode_char): Check that character arg is actually
5161 a character. Pass an int to ENCODE_CHAR.
5162 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5163 wider than 'int', as a compile-time check to prevent future regressions
5164 in this area.
5165
5166 * character.c (char_string): Remove unnecessary casts.
5167
5168 Make sure a 64-bit char is never passed to CHAR_STRING.
5169 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5170 by silently ignoring the top 32 bits, allowing some values
5171 that were far too large to be valid characters.
5172 * character.h: Include <verify.h>.
5173 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5174 arguments are no wider than unsigned, as a compile-time check
5175 to prevent future regressions in this area.
5176 * data.c (Faset):
5177 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5178 (Fsubst_char_in_region):
5179 * fns.c (concat):
5180 * xdisp.c (decode_mode_spec_coding):
5181 Adjust to CHAR_STRING's new requirement.
5182 * editfns.c (Finsert_char, Fsubst_char_in_region):
5183 * fns.c (concat): Check that character args are actually
5184 characters. Without this test, these functions did the wrong
5185 thing with wildly out-of-range values on 64-bit hosts.
5186
5187 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5188 These casts should not be needed on 32-bit hosts, either.
5189 * keyboard.c (read_char):
5190 * lread.c (Fload): Remove casts to unsigned.
5191
5192 * lisp.h (UNSIGNED_CMP): New macro.
5193 This fixes comparison bugs on 64-bit hosts.
5194 (ASCII_CHAR_P): Use it.
5195 * casefiddle.c (casify_object):
5196 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5197 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5198 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5199 * dispextern.h (FACE_FROM_ID):
5200 * keyboard.c (read_char): Use UNSIGNED_CMP.
5201
5202 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5203 not to EMACS_INT, to avoid GCC warning.
5204
5205 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5206
5207 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5208 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5209 isn't needed on 32-bit machines.
5210
5211 * buffer.c (Fgenerate_new_buffer_name):
5212 Use EMACS_INT for count, not int.
5213 (advance_to_char_boundary): Return EMACS_INT, not int.
5214
5215 * data.c (Qcompiled_function): Now static.
5216
5217 * window.c (window_body_lines): Now static.
5218
5219 * image.c (gif_load): Rename local to avoid shadowing.
5220
5221 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5222 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5223 * alloc.c (make_save_value): Integer argument is now of type
5224 ptrdiff_t, not int.
5225 (mark_object): Use ptrdiff_t, not int.
5226 * lisp.h (pD): New macro.
5227 * print.c (print_object): Use it.
5228
5229 * alloc.c: Use EMACS_INT, not int, to count objects.
5230 (total_conses, total_markers, total_symbols, total_vector_size)
5231 (total_free_conses, total_free_markers, total_free_symbols)
5232 (total_free_floats, total_floats, total_free_intervals)
5233 (total_intervals, total_strings, total_free_strings):
5234 Now EMACS_INT, not int. All uses changed.
5235 (Fgarbage_collect): Compute overall total using a double, so that
5236 integer overflow is less likely to be a problem. Check for overflow
5237 when converting back to an integer.
5238 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5239 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5240 These were 'int' variables that could overflow on 64-bit hosts;
5241 they were never used, so remove them instead of repairing them.
5242 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5243 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5244 Previously, this ceilinged at INT_MAX, but that doesn't work on
5245 64-bit machines.
5246 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5247
5248 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5249 (allocate_vectorlike): Check for ptrdiff_t overflow.
5250 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5251 when a (possibly-narrower) signed value would do just as well.
5252 We prefer using signed arithmetic, to avoid comparison confusion.
5253
5254 * alloc.c: Catch some string size overflows that we were missing.
5255 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5256 for convenience in STRING_BYTES_MAX.
5257 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5258 The definition here is exact; the one in lisp.h was approximate.
5259 (allocate_string_data): Check for string overflow. This catches
5260 some instances we weren't catching before. Also, it catches
5261 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5262 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5263 and ptrdiff_t and EMACS_INT are both 64 bits.
5264
5265 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5266 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5267 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5268
5269 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5270
5271 * alloc.c (Fmake_string): Check for out-of-range init.
5272
5273 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5274
5275 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5276
5277 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5278
5279 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5280 xg_get_default_scrollbar_width.
5281
5282 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5283 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5284 (style_changed_cb): Call update_theme_scrollbar_width and call
5285 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5286 all frames (Bug#8505).
5287 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5288 Call gtk_window_set_resizable if HAVE_GTK3.
5289 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5290 and height if HAVE_GTK3 (Bug#8505).
5291 (scroll_bar_width_for_theme): New variable.
5292 (update_theme_scrollbar_width): New function.
5293 (xg_get_default_scrollbar_width): Move code to
5294 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5295 (xg_initialize): Call update_theme_scrollbar_width.
5296
5297 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5298
5299 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5300
5301 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5302
5303 * frame.c (make_frame): Call other_buffer_safely instead of
5304 other_buffer.
5305
5306 * window.c (temp_output_buffer_show): Call display_buffer with
5307 second argument Vtemp_buffer_show_specifiers and reset latter
5308 immediately after the call.
5309 (Vtemp_buffer_show_specifiers): New variable.
5310 (auto_window_vscroll_p, next_screen_context_lines)
5311 (Vscroll_preserve_screen_position): Remove leading asterisks from
5312 doc-strings.
5313
5314 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5315
5316 Fix minor problems found by GCC 4.6.0 static checking.
5317 * buffer.c (Qclone_number): Remove for now, as it's unused.
5318 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5319 (record_buffer): Remove unused local.
5320 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5321 (set_frame_buffer_list): Remove; unused.
5322 * frame.h (other_visible_frames): Remove decl.
5323 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5324 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5325 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5326 if HAVE_GPM.
5327 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5328 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5329 Define only if HAVE_GPM.
5330 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5331 (update_hints_inhibit): Remove; never set. All uses removed.
5332 * widgetprv.h (emacsFrameClassRec): Remove decl.
5333 * window.c (delete_deletable_window): Now returns void, since it
5334 wasn't returning anything.
5335 (compare_window_configurations): Remove unused locals.
5336 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5337 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5338 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5339 the same widths as pointers. This follows up on the 2011-05-06 patch.
5340 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5341 * xterm.h: Likewise.
5342 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5343
5344 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5345
5346 * makefile.w32-in: Update dependencies.
5347 (LISP_H): Add lib/intprops.h.
5348
5349 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5350
5351 * image.c (gif_load): Add animation frame delay to the metadata.
5352 (syms_of_image): Use DEFSYM. New symbol `delay'.
5353
5354 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5355
5356 * window.c (delete_deletable_window): Re-add.
5357 (Fset_window_configuration): Rewrite to handle dead buffers and
5358 consequently deletable windows.
5359 (window_tree, Fwindow_tree): Remove. Supply functionality in
5360 window.el.
5361 (compare_window_configurations): Simplify code.
5362
5363 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5364
5365 * image.c (imagemagick_load_image): Fix type mismatch.
5366 (Fimagemagick_types): Likewise.
5367
5368 * window.h (replace_buffer_in_windows): Declare.
5369
5370 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5371
5372 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5373 Qclone_number. Remove external declaration of Qdelete_window.
5374 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5375 code.
5376 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5377 Run Qbuffer_list_update_hook if allowed.
5378 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5379 buffer list implementation.
5380 (other_buffer_safely): New function.
5381 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5382 calls to replace_buffer_in_windows and
5383 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5384 if allowed.
5385 (record_buffer): Inhibit quitting and rewrite using quittable
5386 functions. Run Qbuffer_list_update_hook if allowed.
5387 (Frecord_buffer, Funrecord_buffer): New functions.
5388 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5389 Move switch-to-buffer to window.el.
5390 (bury-buffer): Move to window.el.
5391 (Vbuffer_list_update_hook): New variable.
5392
5393 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5394 section.
5395
5396 * window.h (resize_frame_windows): Move up in code.
5397 (Fwindow_frame): Remove EXFUN.
5398 (replace_buffer_in_all_windows): Remove prototype.
5399 (replace_buffer_in_windows_safely): Add prototype.
5400
5401 * window.c: Declare Qdelete_window static again. Move down
5402 declaration of select_count.
5403 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5404 (Fother_window): Move to window.el.
5405 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5406 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5407 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5408 window.el.
5409 (replace_buffer_in_windows): Implement by calling
5410 Qreplace_buffer_in_windows.
5411 (replace_buffer_in_all_windows): Remove with some functionality
5412 moved into replace_buffer_in_windows_safely.
5413 (replace_buffer_in_windows_safely): New function.
5414 (select_window_norecord, select_frame_norecord): Move in front
5415 of run_window_configuration_change_hook. Remove now obsolete
5416 declarations.
5417 (Fset_window_buffer): Rewrite doc-string.
5418 Call Qrecord_window_buffer.
5419 (keys_of_window): Move binding for other-window to window.el.
5420
5421 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5422
5423 * dispextern.h (struct image): Replace data member, whose int_val
5424 and ptr_val fields were not used by anything, with a single
5425 lisp_val object.
5426
5427 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5428 (gif_clear_image, gif_load, imagemagick_load_image)
5429 (gs_clear_image, gs_load): Callers changed.
5430
5431 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5432
5433 * buffer.h: Include <time.h>, for time_t.
5434 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5435
5436 Fix minor problems found by static checking.
5437
5438 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5439
5440 Make identifiers static if they are not used in other modules.
5441 * data.c (Qcompiled_function, Qframe, Qvector):
5442 * image.c (QimageMagick, Qsvg):
5443 * minibuf.c (Qmetadata):
5444 * window.c (resize_window_check, resize_root_window): Now static.
5445 * window.h (resize_window_check, resize_root_window): Remove decls.
5446
5447 * window.c (window_deletion_count, delete_deletable_window):
5448 Remove; unused.
5449 (window_body_lines): Now static.
5450 (Fdelete_other_windows_internal): Mark vars as initialized.
5451 Make sure 'resize_failed' is initialized.
5452 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5453 (resize_window_apply): Remove unused local.
5454 * window.h (delete_deletable_window): Remove decl.
5455
5456 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5457 (imagemagick_load_image): Fix pointer signedness problem by changing
5458 last arg from unsigned char * to char *. All uses changed.
5459 Also, fix a local for similar reasons.
5460 Remove unused locals. Remove locals to avoid shadowing.
5461 (fn_rsvg_handle_free): Remove; unused.
5462 (svg_load, svg_load_image): Fix pointer signedness problem.
5463 (imagemagick_load_image): Don't use garbage pointer image_wand.
5464
5465 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5466
5467 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5468
5469 * image.c (gif_load): Fix omitted cast error introduced by
5470 2011-06-06 change.
5471
5472 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5473
5474 * window.h (resize_proportionally, orig_total_lines)
5475 (orig_top_line): Remove from window structure.
5476 (set_window_height, set_window_width, change_window_heights)
5477 (Fdelete_window): Remove prototypes.
5478 (resize_frame_windows): Remove duplicate declaration.
5479
5480 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5481
5482 * window.h (resize_frame_windows, resize_window_check)
5483 (delete_deletable_window, resize_root_window)
5484 (resize_frame_windows): Declare prototypes.
5485
5486 * window.c (resize_window_apply): Make definition be "static" to
5487 match the prototype.
5488
5489 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5490
5491 * window.c: Remove declarations of Qwindow_size_fixed,
5492 window_min_size_1, window_min_size_2, window_min_size,
5493 size_window, window_fixed_size_p, enlarge_window, delete_window.
5494 Remove static from declaration of Qdelete_window, it's
5495 temporarily needed by Fbury_buffer.
5496 (replace_window): Don't assign orig_top_line and
5497 orig_total_lines.
5498 (Fdelete_window, delete_window): Remove. Window deletion is
5499 handled by window.el.
5500 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5501 Replace Fdelete_window calls with calls to Qdelete_window.
5502 (Fdelete_other_windows): Remove. Deleting other windows is
5503 handled by window.el.
5504 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5505 handled in window.el.
5506 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5507 Window minimum sizes are handled in window.el.
5508 (shrink_windows, size_window, set_window_height)
5509 (set_window_width, change_window_heights, window_height)
5510 (window_width, CURBEG, CURSIZE, enlarge_window)
5511 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5512 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5513 handled in window.el.
5514 (make_dummy_parent): Rename to make_parent_window and give it a
5515 second argument horflag.
5516 (make_window): Don't set resize_proportionally any more.
5517 (Fsplit_window): Remove. Windows are split in window.el.
5518 (save_restore_action, save_restore_orig_size)
5519 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5520 Resize mini windows in window.el.
5521 (grow_mini_window, shrink_mini_window): Implement by calling
5522 Qresize_root_window_vertically, resize_window_check and
5523 resize_window_apply.
5524 (saved_window, Fset_window_configuration, save_window_save):
5525 Do not handle orig_top_line, orig_total_lines, and
5526 resize_proportionally.
5527 (window_min_height, window_min_width): Move to window.el.
5528 (keys_of_window): Move bindings for delete-other-windows,
5529 split-window, delete-window and enlarge-window to window.el.
5530
5531 * buffer.c: Temporarily extern Qdelete_window.
5532 (Fbury_buffer): Temporarily call Qdelete_window instead of
5533 Fdelete_window (Fbury_buffer will move to window.el soon).
5534
5535 * frame.c (set_menu_bar_lines_1): Remove code handling
5536 orig_top_line and orig_total_lines.
5537
5538 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5539 set_window_height but set heights directly.
5540 (change_frame_size_1): Use resize_frame_windows.
5541
5542 * xdisp.c (init_xdisp): Don't use set_window_height but set
5543 heights directly.
5544
5545 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5546 Use resize_frame_windows instead of change_window_heights and run
5547 run_window_configuration_change_hook.
5548
5549 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5550 instead of change_window_heights and run
5551 run_window_configuration_change_hook.
5552
5553 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5554
5555 * window.c (replace_window): Rename second argument REPLACEMENT to
5556 NEW. New third argument SETFLAG. Rewrite.
5557 (delete_window, make_dummy_parent): Call replace_window with
5558 third argument 1.
5559 (window_list_1): Move down in code.
5560 (run_window_configuration_change_hook): Move set_buffer part
5561 before select_frame_norecord part in order to unwind correctly.
5562 Rename count1 to count.
5563 (recombine_windows, delete_deletable_window, resize_root_window)
5564 (Fdelete_other_windows_internal)
5565 (Frun_window_configuration_change_hook, make_parent_window)
5566 (resize_window_check, resize_window_apply, Fresize_window_apply)
5567 (resize_frame_windows, Fsplit_window_internal)
5568 (Fdelete_window_internal, Fresize_mini_window_internal):
5569 New functions.
5570 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5571
5572 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5573
5574 * window.h (window): Add some new members to window structure -
5575 normal_lines, normal_cols, new_total, new_normal, clone_number,
5576 splits, nest, prev_buffers, next_buffers.
5577 (WINDOW_TOTAL_SIZE): Move here from window.c.
5578 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5579
5580 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5581 Remove.
5582 (make_dummy_parent): Set new members of windows structure.
5583 (make_window): Move down in code. Handle new members of window
5584 structure.
5585 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5586 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5587 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5588 (Fset_window_prev_buffers, Fwindow_next_buffers)
5589 (Fset_window_next_buffers, Fset_window_clone_number):
5590 New functions.
5591 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5592 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5593 Doc-string fixes.
5594 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5595 Argument WINDOW can be now internal window too.
5596 (Fwindow_use_time): Move up in code.
5597 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5598 Rewrite doc-string.
5599 (Fset_window_configuration, saved_window)
5600 (Fcurrent_window_configuration, save_window_save): Handle new
5601 members of window structure.
5602 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5603 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5604 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5605 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5606 Qget_mru_window, Qresize_root_window,
5607 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5608 Qauto_buffer_name; staticpro them.
5609
5610 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5611
5612 * window.c (Fwindow_total_size, Fwindow_left_column)
5613 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5614 (Fwindow_list_1): New functions.
5615 (window_box_text_cols): Replace with window_body_cols.
5616 (Fwindow_width, Fscroll_left, Fscroll_right):
5617 Use window_body_cols instead of window_box_text_cols.
5618 (delete_window, Fset_window_configuration):
5619 Call delete_all_subwindows with window as argument.
5620 (delete_all_subwindows): Take a window as argument and not a
5621 structure. Rewrite.
5622 (window_loop): Remove handling of GET_LRU_WINDOW and
5623 GET_LARGEST_WINDOW.
5624 (Fget_lru_window, Fget_largest_window): Move to window.el.
5625
5626 * window.h: Extern window_body_cols instead of
5627 window_box_text_cols. delete_all_subwindows now takes a
5628 Lisp_Object as argument.
5629
5630 * indent.c (compute_motion, Fcompute_motion):
5631 Use window_body_cols instead of window_box_text_cols.
5632
5633 * frame.c (delete_frame): Call delete_all_subwindows with root
5634 window as argument.
5635
5636 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5637
5638 * fns.c (Fputhash): Document return value.
5639
5640 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5641
5642 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5643
5644 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5645
5646 Cons<->int and similar integer overflow fixes (Bug#8794).
5647
5648 Check for overflow when converting integer to cons and back.
5649 * charset.c (Fdefine_charset_internal, Fdecode_char):
5650 Use cons_to_unsigned to catch overflow.
5651 (Fencode_char): Use INTEGER_TO_CONS.
5652 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5653 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5654 * data.c (long_to_cons, cons_to_long): Remove.
5655 (cons_to_unsigned, cons_to_signed): New functions.
5656 These signal an error for invalid or out-of-range values.
5657 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5658 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5659 * font.c (Ffont_variation_glyphs):
5660 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5661 * lisp.h: Include <intprops.h>.
5662 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5663 (cons_to_signed, cons_to_unsigned): New decls.
5664 (long_to_cons, cons_to_long): Remove decls.
5665 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5666 (Fprimitive_undo): Use CONS_TO_INTEGER.
5667 * xfns.c (Fx_window_property): Likewise.
5668 * xselect.c: Include <limits.h>.
5669 (x_own_selection, selection_data_to_lisp_data):
5670 Use INTEGER_TO_CONS.
5671 (x_handle_selection_request, x_handle_selection_clear)
5672 (x_get_foreign_selection, Fx_disown_selection_internal)
5673 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5674 (lisp_data_to_selection_data): Use cons_to_unsigned.
5675 (x_fill_property_data): Use cons_to_signed.
5676 Report values out of range.
5677
5678 Check for buffer and string overflow more precisely.
5679 * buffer.h (BUF_BYTES_MAX): New macro.
5680 * lisp.h (STRING_BYTES_MAX): New macro.
5681 * alloc.c (Fmake_string):
5682 * character.c (string_escape_byte8):
5683 * coding.c (coding_alloc_by_realloc):
5684 * doprnt.c (doprnt):
5685 * editfns.c (Fformat):
5686 * eval.c (verror):
5687 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5688 since they may not be the same number.
5689 * editfns.c (Finsert_char):
5690 * fileio.c (Finsert_file_contents):
5691 Likewise for BUF_BYTES_MAX.
5692
5693 * image.c: Use ptrdiff_t, not int, for sizes.
5694 (slurp_file): Switch from int to ptrdiff_t.
5695 All uses changed.
5696 (slurp_file): Check that file size fits in both size_t (for
5697 malloc) and ptrdiff_t (for sanity and safety).
5698
5699 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5700 if b->modtime has its maximal value.
5701
5702 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5703
5704 Don't assume time_t can fit into int.
5705 * buffer.h (struct buffer.modtime): Now time_t, not int.
5706 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5707 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5708
5709 Minor fixes for signed vs unsigned integers.
5710 * character.h (MAYBE_UNIFY_CHAR):
5711 * charset.c (maybe_unify_char):
5712 * keyboard.c (read_char, reorder_modifiers):
5713 XINT -> XFASTINT, since the integer must be nonnegative.
5714 * ftfont.c (ftfont_spec_pattern):
5715 * keymap.c (access_keymap, silly_event_symbol_error):
5716 XUINT -> XFASTINT, since the integer must be nonnegative.
5717 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5718 since it makes no difference and we prefer signed.
5719 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5720 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5721 nonnegative.
5722
5723 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5724
5725 * window.h (Fwindow_frame): Declare.
5726
5727 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5728
5729 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5730 (SPARE_MEMORY): Always define.
5731 (LARGE_REQUEST): Remove.
5732 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5733
5734 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5735
5736 * lisp.h: Move EXFUNS for Fframe_root_window,
5737 Fframe_first_window and Fset_frame_selected_window to window.h.
5738
5739 * window.h: Move EXFUNS for Fframe_root_window,
5740 Fframe_first_window and Fset_frame_selected_window here from
5741 lisp.h.
5742
5743 * frame.c (Fwindow_frame, Fframe_first_window)
5744 (Fframe_root_window, Fframe_selected_window)
5745 (Fset_frame_selected_window): Move to window.c.
5746 (Factive_minibuffer_window): Move to minibuf.c.
5747 (Fother_visible_frames_p): New function.
5748
5749 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5750
5751 * window.c (decode_window, decode_any_window): Move up in code.
5752 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5753 (inhibit_frame_unsplittable): Remove unused variable.
5754 (Fwindow_buffer): Move up and rewrite doc-string.
5755 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5756 (Fwindow_prev): New functions.
5757 (Fwindow_frame): Move here from frame.c. Accept any window as
5758 argument.
5759 (Fframe_root_window, Fframe_first_window)
5760 (Fframe_selected_window): Move here from frame.c. Accept frame
5761 or arbitrary window as argument. Update doc-strings.
5762 (Fminibuffer_window): Move up in code.
5763 (Fwindow_minibuffer_p): Move up in code and simplify.
5764 (Fset_frame_selected_window): Move here from frame.c.
5765 Marginal rewrite.
5766 (Fselected_window, select_window, Fselect_window): Move up in
5767 code. Minor doc-string fixes.
5768
5769 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5770
5771 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5772 Do not assume that spare memory exists; that assumption is valid
5773 only if SYSTEM_MALLOC.
5774 (LARGE_REQUEST): New macro, so that the issue of large requests
5775 is separated from the issue of spare memory.
5776
5777 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5778
5779 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5780 format. (Bug#8806)
5781
5782 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5783
5784 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5785 before statements.
5786
5787 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5788
5789 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5790
5791 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5792
5793 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5794 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5795
5796 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5797
5798 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5799
5800 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5801
5802 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5803 (x_clipboard_manager_save): Add return value.
5804 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5805 New error handlers.
5806 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5807 Obey Vx_select_enable_clipboard_manager. Catch errors in
5808 x_clipboard_manager_save (Bug#8779).
5809 (Vx_select_enable_clipboard_manager): New variable.
5810 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5811
5812 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5813
5814 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5815
5816 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5817
5818 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5819 in the current matrix if keep_current_p is non-zero.
5820
5821 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5822
5823 * bidi.c (bidi_level_of_next_char): Fix last change.
5824
5825 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5826
5827 Support bidi reordering of text covered by display properties.
5828
5829 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5830 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5831 (bidi_cache_search, bidi_cache_iterator_state)
5832 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5833 (bidi_level_of_next_char, bidi_move_to_visually_next):
5834 Support character positions inside a run of characters covered by a
5835 display string.
5836 (bidi_paragraph_init, bidi_resolve_explicit_1)
5837 (bidi_level_of_next_char): Call bidi_fetch_char and
5838 bidi_fetch_char_advance instead of FETCH_CHAR and
5839 FETCH_CHAR_ADVANCE.
5840 (bidi_init_it): Initialize new members.
5841 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5842 definitions.
5843 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5844 instead of using explicit *_CHAR codes.
5845 (bidi_resolve_explicit, bidi_resolve_weak):
5846 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5847 bidirectional text is supported only in multibyte buffers.
5848 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5849 it to initialize the frame_window_p member of struct bidi_it.
5850 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5851 (bidi_resolve_explicit, bidi_resolve_weak)
5852 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5853 bidi_it->nchars is non-positive.
5854 (bidi_level_of_next_char): Don't try to lookup the cache for the
5855 next/previous character if nothing is cached there yet, or if we
5856 were just reseat()'ed to a new position.
5857
5858 * xdisp.c (set_cursor_from_row): Set start and stop points
5859 according to the row's direction when priming the loop that looks
5860 for the glyph on which to display cursor.
5861 (single_display_spec_intangible_p): Function deleted.
5862 (display_prop_intangible_p): Reimplement to call
5863 handle_display_spec instead of single_display_spec_intangible_p.
5864 Accept 3 additional arguments needed by handle_display_spec.
5865 This fixes incorrect cursor motion across display property with complex
5866 values: lists, `(when COND...)' forms, etc.
5867 (single_display_spec_string_p): Support property values that are
5868 lists with the argument STRING its top-level element.
5869 (display_prop_string_p): Fix the condition for processing a
5870 property that is a list to be consistent with handle_display_spec.
5871 (handle_display_spec): New function, refactored from the
5872 last portion of handle_display_prop.
5873 (compute_display_string_pos): Accept additional argument
5874 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5875 value of a `display' property is a "replacing spec".
5876 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5877 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5878 the display property, but just return a value indicating whether
5879 the display property will replace the characters it covers.
5880 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5881 frame_window_p members of struct bidi_it.
5882 (compute_display_string_pos, compute_display_string_end):
5883 New functions.
5884 (push_it): Accept second argument POSITION, where pop_it should
5885 jump to continue iteration.
5886 (reseat_1): Initialize bidi_it.disp_pos.
5887
5888 * keyboard.c (adjust_point_for_property): Adjust the call to
5889 display_prop_intangible_p to its new signature.
5890
5891 * dispextern.h (struct bidi_it): New member frame_window_p.
5892 (bidi_init_it): Update prototypes.
5893 (display_prop_intangible_p): Update prototype.
5894 (compute_display_string_pos, compute_display_string_end):
5895 Declare prototypes.
5896 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5897 EMACS_INT.
5898
5899 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5900
5901 Malloc failure behavior now depends on size of allocation.
5902 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5903 * lisp.h: Change signatures accordingly.
5904 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5905 All callers changed. (Bug#8762)
5906
5907 * gnutls.c: Use Emacs's memory allocators.
5908 Without this change, the gnutls library would invoke malloc etc.
5909 directly, which causes problems on non-SYNC_INPUT hosts, and which
5910 runs afoul of improving memory_full behavior. (Bug#8761)
5911 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5912 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5913 xfree instead of the default malloc, realloc, free.
5914 (Fgnutls_boot): No need to check for memory allocation failure,
5915 since xmalloc does that for us.
5916
5917 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5918 * category.c (hash_get_category_set):
5919 * ccl.c (ccl_driver):
5920 * charset.c (Fdefine_charset_internal):
5921 * charset.h (struct charset.hash_index):
5922 * composite.c (get_composition_id, gstring_lookup_cache)
5923 (composition_gstring_put_cache):
5924 * composite.h (struct composition.hash_index):
5925 * dispextern.h (struct image.hash):
5926 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5927 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5928 (hashfn_equal, hashfn_user_defined, make_hash_table)
5929 (maybe_resize_hash_table, hash_lookup, hash_put)
5930 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5931 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5932 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5933 * image.c (make_image, search_image_cache, lookup_image)
5934 (xpm_put_color_table_h):
5935 * lisp.h (struct Lisp_Hash_Table):
5936 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5937 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5938 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5939 * alloc.c (allocate_vectorlike):
5940 Check for overflow in vector size calculations.
5941 * ccl.c (ccl_driver):
5942 Check for overflow when converting EMACS_INT to int.
5943 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5944 need to be updated by these changes.
5945 * fns.c (make_hash_table, maybe_resize_hash_table):
5946 Check for integer overflow with large hash tables.
5947 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5948 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5949 (SXHASH_REDUCE): New macro.
5950 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5951 Use it instead of discarding useful hash info with large hash values.
5952 (sxhash_float): New function.
5953 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5954 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5955 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5956 Rewrite to use FIXNUM_BITS, as this simplifies things.
5957 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5958 Adjust signatures to match updated version of code.
5959 (consing_since_gc): Now EMACS_INT, since a single hash table can
5960 use more than INT_MAX bytes.
5961
5962 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5963
5964 Make it possible to build with GCC-4.6+ -O2 -flto.
5965
5966 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5967
5968 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5969
5970 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5971 Call minibuffer-inactive-mode.
5972
5973 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5974
5975 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5976 Update dependencies.
5977
5978 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5979
5980 * data.c (init_data): Remove code for UTS, this system is not
5981 supported anymore.
5982
5983 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5984
5985 Don't force ./temacs to start in terminal mode.
5986
5987 * frame.c (make_initial_frame): Initialize faces in all cases, not
5988 only when CANNOT_DUMP is defined.
5989 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5990
5991 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5992
5993 * dispnew.c (add_window_display_history): Use const for the string
5994 pointer. Remove declaration, not needed.
5995
5996 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5997
5998 Use 'inline', not 'INLINE'.
5999 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6000 * alloc.c, fontset.c (INLINE): Remove.
6001 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6002 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6003 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6004 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6005 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6006
6007 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6008
6009 Make it possible to run ./temacs.
6010
6011 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6012 syms_of_callproc does the same thing. Remove test for
6013 "initialized", do it in the caller.
6014 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6015
6016 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6017
6018 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6019 (read_minibuf): Use get_minibuffer.
6020 (syms_of_minibuf): Use DEFSYM.
6021 (Qmetadata): New var.
6022 * data.c (Qbuffer): Don't make it static.
6023 (syms_of_data): Use DEFSYM.
6024
6025 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6026
6027 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6028 (CCL_CODE_MIN): New macro.
6029
6030 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6031
6032 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6033
6034 * eval.c (Qdebug): Now static.
6035 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6036 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6037 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6038
6039 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6040
6041 * image.c: Various fixes to ImageMagick code comments.
6042 (Fimagemagick_types): Doc fix.
6043
6044 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6045
6046 Minor fixes prompted by GCC 4.6.0 warnings.
6047
6048 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6049
6050 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6051 (x_clipboard_manager_save_all): Move extern decl to ...
6052 * xterm.h: ... here, so that it can be checked for consistency.
6053
6054 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6055
6056 * xselect.c (x_clipboard_manager_save_frame)
6057 (x_clipboard_manager_save_all): New functions.
6058 (Fx_clipboard_manager_save): Lisp function deleted.
6059
6060 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6061 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6062
6063 * xterm.h: Update prototype.
6064
6065 2011-05-28 William Xu <william.xwl@gmail.com>
6066
6067 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6068 exiting (Bug#8239).
6069
6070 2011-05-28 Jim Meyering <meyering@redhat.com>
6071
6072 Avoid a sign-extension bug in crypto_hash_function.
6073 * fns.c (to_uchar): Define.
6074 (crypto_hash_function): Use it to convert some newly-signed
6075 variables to unsigned, to avoid sign-extension bugs. For example,
6076 without this change, (md5 "truc") would evaluate to
6077 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6078 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6079 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6080
6081 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6082
6083 Integer overflow fixes.
6084
6085 * dbusbind.c: Serial number integer overflow fixes.
6086 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6087 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6088 to hold a serial number that is too large for a fixnum.
6089 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6090 Check for serial numbers out of range. Decode any serial number
6091 that was so large that it became a float. (Bug#8722)
6092
6093 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6094 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6095 Use XFASTINT rather than XUINT when numbers are nonnegative.
6096 (xd_append_arg, Fdbus_method_return_internal):
6097 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6098 arguments, check that Lisp number is nonnegative, rather than
6099 silently wrapping negative numbers around. (Bug#8722)
6100 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6101 (Bug#8722)
6102
6103 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6104
6105 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6106
6107 ccl: Add integer overflow checks.
6108 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6109 (IN_INT_RANGE): New macros.
6110 (ccl_driver): Use them to check for integer overflow when
6111 decoding a CCL program. Many of the new checks are whether XINT (x)
6112 fits in int; it doesn't always, on 64-bit hosts. The new version
6113 doesn't catch all possible integer overflows, but it's an
6114 improvement. (Bug#8719)
6115
6116 * alloc.c (make_event_array): Use XINT, not XUINT.
6117 There's no need for unsigned here.
6118
6119 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6120 This follows up to the 2011-05-06 change that substituted uintptr_t
6121 for EMACS_INT. This case wasn't caught back then.
6122
6123 Rework Fformat to avoid integer overflow issues.
6124 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6125 now (part of C89). Include <verify.h>.
6126 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6127 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6128 (Fformat): Avoid the prepass trying to compute sizes; it was only
6129 approximate and thus did not catch overflow reliably. Instead, walk
6130 through the format just once, formatting and computing sizes as we go,
6131 checking for integer overflow at every step, and allocating a larger
6132 buffer as needed. Keep track separately whether the format is
6133 multibyte. Keep only the most-recently calculated precision, rather
6134 than them all. Record whether each argument has been converted to
6135 string. Use EMACS_INT, not int, for byte and char and arg counts.
6136 Support field widths and precisions larger than INT_MAX. Avoid
6137 sprintf's undefined behavior with conversion specifications such as %#d
6138 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6139 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6140 formatting out-of-range floating point numbers with int
6141 formats. (Bug#8668)
6142
6143 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6144
6145 * data.c: Avoid integer truncation in expressions involving floats.
6146 * data.c: Include <intprops.h>.
6147 (arith_driver): When there's an integer overflow in an expression
6148 involving floating point, convert the integers to floating point
6149 so that the resulting value does not suffer from catastrophic
6150 integer truncation. For example, on a 64-bit host (* 4
6151 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6152 Do not rely on undefined behavior after integer overflow.
6153
6154 merge count_size_as_multibyte, parse_str_to_multibyte
6155 * character.c, character.h (count_size_as_multibyte):
6156 Rename from parse_str_to_multibyte; all uses changed.
6157 Check for integer overflow.
6158 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6159 since it's now a duplicate of the other. This is more of
6160 a character than a buffer op, so better that it's in character.c.
6161 * fns.c, print.c: Adjust to above changes.
6162
6163 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6164
6165 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6166
6167 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6168
6169 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6170 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6171 (x_clipboard_manager_save): Now static.
6172 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6173
6174 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6175 (crypto_hash_function): Now static.
6176 Fix pointer signedness problems. Avoid unnecessary initializations.
6177
6178 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6179
6180 * termhooks.h (Vselection_alist): Make it terminal-local.
6181
6182 * terminal.c (create_terminal): Initialize it.
6183
6184 * xselect.c: Support for clipboard managers.
6185 (Vselection_alist): Move to termhooks.h as terminal-local var.
6186 (LOCAL_SELECTION): New macro.
6187 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6188 (symbol_to_x_atom): Remove gratuitous arg.
6189 (x_handle_selection_request, lisp_data_to_selection_data)
6190 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6191 (x_own_selection, x_get_local_selection, x_convert_selection):
6192 New arg, specifying work frame. Use terminal-local Vselection_alist.
6193 (some_frame_on_display): Delete unused function.
6194 (Fx_own_selection_internal, Fx_get_selection_internal)
6195 (Fx_disown_selection_internal, Fx_selection_owner_p)
6196 (Fx_selection_exists_p): New optional frame arg.
6197 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6198 (x_handle_selection_clear): Don't treat other terminals with the
6199 same keyboard specially. Use the terminal-local Vselection_alist.
6200 (x_clear_frame_selections): Use Frun_hook_with_args.
6201
6202 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6203
6204 * xterm.h: Add support for those atoms.
6205
6206 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6207
6208 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6209 (converted_selections, conversion_fail_tag): New global variables.
6210 (x_selection_request_lisp_error): Free the above.
6211 (x_get_local_selection): Remove unnecessary code.
6212 (x_reply_selection_request): Args changed; handle arbitrary array
6213 of converted selections stored in converted_selections.
6214 Separate the XChangeProperty and SelectionNotify steps.
6215 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6216 (x_convert_selection): New function.
6217 (x_handle_selection_event): Simplify.
6218 (x_get_foreign_selection): Don't ignore incoming requests while
6219 waiting for an answer; this will fail when we implement
6220 SAVE_TARGETS, and seems unnecessary anyway.
6221 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6222 (Vx_sent_selection_functions): Doc fix.
6223
6224 2011-05-26 Leo Liu <sdl.web@gmail.com>
6225
6226 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6227
6228 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6229
6230 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6231
6232 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6233 for fringe update if it has periodic bitmap.
6234 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6235 and fringe_bitmap_periodic_p.
6236
6237 * fringe.c (get_fringe_bitmap_data): New function.
6238 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6239 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6240 row. Mark glyph row for fringe update if periodicity changed.
6241
6242 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6243 for fringe update unless it has periodic bitmap.
6244
6245 2011-05-25 Kenichi Handa <handa@m17n.org>
6246
6247 * xdisp.c (get_next_display_element): Set correct it->face_id for
6248 a static composition.
6249
6250 2011-05-24 Leo Liu <sdl.web@gmail.com>
6251
6252 * deps.mk (fns.o):
6253 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6254
6255 * fns.c (crypto_hash_function, Fsha1): New function.
6256 (Fmd5): Use crypto_hash_function.
6257 (syms_of_fns): Add Ssha1.
6258
6259 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6260
6261 * gnutls.c: Remove unused macros.
6262 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6263 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6264 Remove macros that are defined and never used.
6265 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6266
6267 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6268
6269 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6270 (Fx_get_selection_internal): Minor cleanup.
6271 (Fx_own_selection_internal): Rename arguments for consistency with
6272 select.el.
6273
6274 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6275
6276 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6277
6278 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6279
6280 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6281
6282 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6283
6284 * dispnew.c (scrolling_window): Don't exclude the case that the
6285 last enabled row in the desired matrix touches the bottom boundary.
6286
6287 2011-05-21 Glenn Morris <rgm@gnu.org>
6288
6289 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6290 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6291 and add some more files.
6292
6293 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6294
6295 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6296 report_file_error introduced by the change from 2011-05-07.
6297
6298 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6299
6300 * systime.h (Time): Define only if emacs is defined.
6301 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6302 where the include path doesn't have X11/X.h by default. See
6303 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6304
6305 2011-05-20 Kenichi Handa <handa@m17n.org>
6306
6307 * composite.c (find_automatic_composition): Fix previous change.
6308
6309 2011-05-20 Glenn Morris <rgm@gnu.org>
6310
6311 * lisp.mk: New file, split from Makefile.in.
6312 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6313 (shortlisp): Remove.
6314 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6315
6316 2011-05-19 Glenn Morris <rgm@gnu.org>
6317
6318 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6319 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6320 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6321 (lisp): Set the order to that of loadup.el.
6322 (shortlisp): Make it a copy of $lisp.
6323 (SOME_MACHINE_LISP): Remove.
6324 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6325 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6326
6327 2011-05-18 Kenichi Handa <handa@m17n.org>
6328
6329 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6330 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6331 (find_automatic_composition): Mostly rewrite for efficiency.
6332
6333 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6334
6335 * makefile.w32-in: Update dependencies.
6336
6337 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6338
6339 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6340 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6341
6342 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6343
6344 Fix some integer overflow issues, such as string length overflow.
6345
6346 * insdel.c (count_size_as_multibyte): Check for string overflow.
6347
6348 * character.c (lisp_string_width): Check for string overflow.
6349 Use EMACS_INT, not int, for string indexes and lengths; in
6350 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6351 the resulting string length overflows an EMACS_INT; instead,
6352 report a string overflow if no precision given. When checking for
6353 precision exhaustion, use a check that cannot possibly have
6354 integer overflow. (Bug#8675)
6355 * character.h (lisp_string_width): Adjust to new signature.
6356
6357 * alloc.c (string_overflow): New function.
6358 (Fmake_string): Use it. This doesn't change behavior, but saves
6359 a few bytes and will simplify future changes.
6360 * character.c (string_escape_byte8): Likewise.
6361 * lisp.h (string_overflow): New decl.
6362
6363 Fixups, following up to the user-interface timestamp change.
6364 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6365 for UI timestamps, instead of unsigned long.
6366 * msdos.c (mouse_get_pos): Likewise.
6367 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6368 * w32gui.h (Time): Define by including "systime.h" rather than by
6369 declaring it ourselves. (Bug#8664)
6370
6371 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6372 * image.c (clear_image_cache): Likewise.
6373
6374 * term.c (term_mouse_position): Don't assume time_t wraparound.
6375
6376 Be more systematic about user-interface timestamps.
6377 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6378 and sometimes 'EMACS_UINT', to represent these timestamps.
6379 This change causes it to use 'Time' uniformly, as that's what X uses.
6380 This makes the code easier to follow, and makes it easier to catch
6381 integer overflow bugs such as Bug#8664.
6382 * frame.c (Fmouse_position, Fmouse_pixel_position):
6383 Use Time, not unsigned long, for user-interface timestamps.
6384 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6385 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6386 * keyboard.h (last_event_timestamp): Likewise.
6387 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6388 * menu.h (xmenu_show): Likewise.
6389 * term.c (term_mouse_position): Likewise.
6390 * termhooks.h (struct input_event.timestamp): Likewise.
6391 (struct terminal.mouse_position_hook): Likewise.
6392 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6393 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6394 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6395 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6396 what it was before.
6397 * menu.h, termhooks.h: Include "systime.h", for Time.
6398
6399 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6400 Don't assume that the difference between two unsigned long values
6401 can fit into an integer. At this point, we know button_down_time
6402 <= event->timestamp, so the difference must be nonnegative, so
6403 there's no need to cast the result if double-click-time is
6404 nonnegative, as it should be; check that it's nonnegative, just in
6405 case. This bug is triggered when events are more than 2**31 ms
6406 apart (about 25 days). (Bug#8664)
6407
6408 * xselect.c (last_event_timestamp): Remove duplicate decl.
6409 (x_own_selection): Remove needless cast to unsigned long.
6410
6411 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6412 that always fit in int. Use a sentinel instead of a counter, to
6413 avoid a temp and to allay GCC's concerns about possible int overflow.
6414 * frame.h (struct frame): Use int for menu_bar_items_used
6415 instead of EMACS_INT, since it always fits in int.
6416
6417 * menu.c (grow_menu_items): Check for int overflow.
6418
6419 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6420
6421 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6422 Before, the code was not consistent. These values cannot exceed
6423 2**31 - 1 so there's no need to make them unsigned.
6424 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6425 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6426 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6427 as modifiers.
6428 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6429
6430 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6431 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6432 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6433 presumably because the widths might not match.
6434
6435 * window.c (size_window): Avoid needless test at loop start.
6436
6437 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6438
6439 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6440
6441 2011-05-12 Drew Adams <drew.adams@oracle.com>
6442
6443 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6444
6445 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6446
6447 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6448 `width' to `bar_area_x' and `bar_area_width', respectively.
6449 (x_scroll_run): Take account of fringe background extension.
6450
6451 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6452 Rename local vars `left' and `width' to `bar_area_x' and
6453 `bar_area_width', respectively.
6454 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6455 background extension.
6456
6457 2011-05-10 Jim Meyering <meyering@redhat.com>
6458
6459 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6460
6461 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6462
6463 * image.c (Finit_image_library): Return t for built-in image types,
6464 like pbm and xbm. (Bug#8640)
6465
6466 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6467
6468 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6469
6470 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6471
6472 * w32console.c (Fset_screen_color): Doc fix.
6473 (Fget_screen_color): New function.
6474 (syms_of_ntterm): Defsubr it.
6475
6476 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6477 unlink the temporary file if Fcall_process didn't create it in the
6478 first place.
6479 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6480 child process will be redirected to a file specified with `:file'.
6481 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6482 cue to call_process_cleanup not to close that handle.
6483
6484 2011-05-07 Ben Key <bkey76@gmail.com>
6485
6486 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6487 one of two shell specific rules, either bootstrap-temacs-CMD or
6488 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6489 to the previous implementation of the bootstrap-temacs rule.
6490 The bootstrap-temacs-CMD rule is similar to the previous
6491 implementation of the bootstrap-temacs rule except that it
6492 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6493 variable.
6494
6495 These changes, along with some changes to nt/configure.bat,
6496 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6497 earlier fix to add support for --cflags and --ldflags options
6498 that include quotes so that it works whether make uses cmd or
6499 sh as the shell.
6500
6501 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6502
6503 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6504 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6505 is a constant.
6506 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6507 a string. Handle both cases.
6508 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6509 (Fdbus_register_method): Use Qinvalid_function.
6510
6511 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6512
6513 * makefile.w32-in: Update dependencies.
6514 (LISP_H): Add inttypes.h and stdin.h.
6515 (PROCESS_H): Add unistd.h.
6516
6517 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6518
6519 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6520 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6521
6522 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6523
6524 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6525
6526 * term.c (vfatal): Remove stray call to va_end.
6527 It's not needed and the C Standard doesn't allow it here anyway.
6528
6529 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6530 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6531
6532 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6533 bytes.
6534
6535 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6536
6537 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6538
6539 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6540
6541 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6542
6543 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6544
6545 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6546 * charset.c (Fdefine_charset_internal): Don't initialize
6547 charset.code_space[15]. The value was garbage, on hosts with
6548 32-bit int (Bug#8600).
6549
6550 * lread.c (read_integer): Be more consistent with string-to-number.
6551 Use string_to_number to do the actual conversion; this avoids
6552 rounding errors and fixes some other screwups. Without this fix,
6553 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6554 (digit_to_number): Move earlier, for benefit of read_integer.
6555 Return -1 if the digit is out of range for the base, -2 if it is
6556 not a digit in any supported base. (Bug#8602)
6557
6558 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6559
6560 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6561 to match comment at start of function. This also removes a
6562 GCC warning about overflow in a 32+64-bit port.
6563
6564 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6565
6566 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6567 Reported by Stefan Monnier in
6568 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6569 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6570 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6571
6572 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6573 (EMACS_UINTPTR): Likewise, with uintptr_t.
6574
6575 * lisp.h: Prefer 64-bit EMACS_INT if available.
6576 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6577 on 32-bit hosts that have 64-bit int, so that they can access
6578 large files.
6579 However, temporarily disable this change unless the temporary
6580 symbol WIDE_EMACS_INT is defined.
6581
6582 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6583
6584 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6585 This removes an assumption that EMACS_INT and long are the same
6586 width as pointers. The assumption is true for Emacs porting targets
6587 now, but we want to make other targets possible.
6588 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6589 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6590 In the rest of the code, change types of integers that hold casted
6591 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6592 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6593 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6594 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6595 No need to cast type when ORing.
6596 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6597 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6598 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6599 assume EMACS_INT is the same width as char *.
6600 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6601 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6602 Remove no-longer-needed casts.
6603 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6604 (xg_tool_bar_help_callback, xg_make_tool_item):
6605 Use EMACS_INTPTR to hold an integer
6606 that will be cast to void *; this can avoid a GCC warning
6607 if EMACS_INT is not the same width as void *.
6608 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6609 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6610 (current_message_1, set_message_1):
6611 Use a local to convert to proper width without a cast.
6612 * xmenu.c (dialog_selection_callback): Likewise.
6613
6614 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6615 Also, don't assume VALBITS / RAND_BITS is less than 5,
6616 and don't rely on undefined behavior when shifting a 1 left into
6617 the sign bit.
6618 * lisp.h (get_random): Change signature to match.
6619
6620 * lread.c (hash_string): Use size_t, not int, for hash computation.
6621 Normally we prefer signed values; but hashing is special, because
6622 it's better to use unsigned division on hash table sizes so that
6623 the remainder is nonnegative. Also, size_t is the natural width
6624 for hashing into memory. The previous code used 'int', which doesn't
6625 retain enough info to hash well into very large tables.
6626 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6627
6628 * dbusbind.c: Don't possibly lose pointer info when converting.
6629 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6630 Use XPNTR rather than XHASH, so that the high-order bits of
6631 the pointer aren't lost when converting through void *.
6632
6633 * eval.c (Fautoload): Don't double-shift a pointer.
6634
6635 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6636
6637 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6638
6639 * gnutls.c (DEF_GNUTLS_FN):
6640 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6641
6642 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6643
6644 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6645 marker. (Bug#8610)
6646
6647 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6648
6649 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6650 New version that can reserve upto 2GB of heap space.
6651
6652 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6653
6654 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6655
6656 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6657
6658 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6659 `gnutls_certificate_set_x509_key_file'.
6660
6661 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6662
6663 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6664 Update dependencies.
6665
6666 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6667
6668 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6669 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6670 Remove unused parameter `fildes'.
6671 * process.c (read_process_output, send_process): Don't pass it.
6672
6673 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6674
6675 Fix previous change: the library cache is defined in w32.c.
6676 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6677 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6678
6679 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6680
6681 Implement dynamic loading of GnuTLS on Windows.
6682
6683 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6684 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6685 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6686 Declare.
6687
6688 * gnutls.c (Qgnutls_dll): Define.
6689 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6690 (gnutls_*): Declare function pointers.
6691 (init_gnutls_functions): New function to initialize function pointers.
6692 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6693 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6694 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6695 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6696 (emacs_gnutls_write, emacs_gnutls_read)
6697 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6698 (Fgnutls_available_p): New function.
6699 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6700 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6701 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6702
6703 * image.c: Include w32.h.
6704 (Vimage_type_cache): Delete.
6705 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6706 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6707 (w32_delayed_load): Move to w32.c.
6708
6709 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6710
6711 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6712 (w32_delayed_load): Move from image.c. When loading a library, record
6713 its filename in the :loaded-from property of the library id.
6714 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6715 Initialize and staticpro them.
6716 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6717
6718 * process.c: Include lisp.h before w32.h, not after.
6719 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6720 instead of gnutls_record_check_pending.
6721
6722 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6723
6724 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6725
6726 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6727 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6728 as passed in.
6729
6730 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6731
6732 * xterm.c (x_set_frame_alpha): Do not set property on anything
6733 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6734
6735 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6736
6737 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6738
6739 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6740
6741 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6742 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6743 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6744 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6745 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6746 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6747 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6748 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6749 (Qgnutls_bootprop_callbacks_verify): Make static.
6750
6751 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6752
6753 * callproc.c: Indentation fixup.
6754
6755 * sysdep.c (wait_for_termination_1): Make static.
6756 (wait_for_termination, interruptible_wait_for_termination):
6757 Move after wait_for_termination_1.
6758
6759 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6760
6761 * sysdep.c (interruptible_wait_for_termination): New function
6762 which is like wait_for_termination, but allows keyboard
6763 interruptions.
6764
6765 * callproc.c (Fcall_process): Add (:file "file") as an option for
6766 the STDOUT buffer.
6767 (Fcall_process_region): Ditto.
6768
6769 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6770
6771 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6772 rather than `XVECTOR (FOO)->size'.
6773
6774 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6775 inttypes.h, as a gnulib replacement is used if it not available in
6776 system headers.
6777
6778 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6779
6780 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6781 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6782 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6783
6784 * coding.c (coding_alloc_by_realloc): Error out if destination
6785 will grow beyond MOST_POSITIVE_FIXNUM.
6786 (decode_coding_emacs_mule): Abort if there isn't enough place in
6787 charbuf for the composition carryover bytes. Reserve an extra
6788 space for up to 2 characters produced in a loop.
6789 (decode_coding_iso_2022): Abort if there isn't enough place in
6790 charbuf for the composition carryover bytes.
6791
6792 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6793
6794 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6795 aborting when %lld or %lll format is passed.
6796 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6797 %llo or %llx format is passed. (Bug#8545)
6798
6799 * window.c (window_scroll_line_based): Use a marker instead of
6800 simple variables to record original value of point. (Bug#7952)
6801
6802 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6803 produced by %s or %c overflows available buffer space. (Bug#8545)
6804
6805 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6806
6807 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6808 (SIZE_MAX): Move defn after all includes, as they might #define it.
6809
6810 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6811
6812 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6813
6814 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6815
6816 * keyboard.c (Qdelayed_warnings_hook): Define.
6817 (command_loop_1): Run `delayed-warnings-hook'
6818 if Vdelayed_warnings_list is non-nil.
6819 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6820 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6821
6822 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6823
6824 * doprnt.c (doprnt): Don't return value smaller than the buffer
6825 size if the message was truncated. (Bug#8545).
6826
6827 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6828
6829 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6830 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6831
6832 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6833
6834 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6835
6836 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6837
6838 * makefile.w32-in: Update dependencies.
6839
6840 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6841
6842 Improve `doprnt' and its usage. (Bug#8545)
6843 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6844 `format_end'. Remove support for %l as a conversion specifier.
6845 Don't use xrealloc. Improve diagnostics when the %l size modifier
6846 is used. Update the commentary.
6847
6848 * eval.c (verror): Simplify calculation of size_t.
6849
6850 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6851 messages.
6852
6853 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6854
6855 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6856 change.
6857
6858 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6859
6860 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6861 This makes this file independent of the recent pseudovector change.
6862
6863 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6864
6865 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6866
6867 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6868 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6869 Remove unused local.
6870 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6871
6872 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6873 GCC 4.6.0 optimizes based on type-based alias analysis.
6874 For example, if b is of type struct buffer * and v of type struct
6875 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6876 != &v->size, and therefore "v->size = 1; b->size = 2; return
6877 v->size;" must therefore return 1. This assumption is incorrect
6878 for Emacs, since it type-puns struct Lisp_Vector * with many other
6879 types. To fix this problem, this patch adds a new type struct
6880 vectorlike_header that documents the constraints on layout of vectors
6881 and pseudovectors, and helps optimizing compilers not get fooled
6882 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6883 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6884 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6885 the size member.
6886 (XSETPVECTYPE): Rewrite in terms of new macro.
6887 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6888 This is a bit clearer, and further avoids the possibility of
6889 undesirable aliasing.
6890 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6891 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6892 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6893 since Lisp_Subr is a special case (no "next" field).
6894 (ASIZE): Now uses header.size rather than size.
6895 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6896 to avoid the hassle of writing XVECTOR (foo)->header.size.
6897 (struct vectorlike_header): New type.
6898 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6899 object, to help avoid aliasing.
6900 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6901 (SUBRP): Likewise, since Lisp_Subr is a special case.
6902 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6903 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6904 (struct Lisp_Hash_Table): Combine first two members into a single
6905 struct vectorlike_header member. All uses of "size" and "next" members
6906 changed to be "header.size" and "header.next".
6907 * buffer.h (struct buffer): Likewise.
6908 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6909 * frame.h (struct frame): Likewise.
6910 * process.h (struct Lisp_Process): Likewise.
6911 * termhooks.h (struct terminal): Likewise.
6912 * window.c (struct save_window_data, struct saved_window): Likewise.
6913 * window.h (struct window): Likewise.
6914 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6915 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6916 * buffer.c (init_buffer_once): Likewise.
6917 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6918 special case.
6919 * process.c (Fformat_network_address): Use local var for size,
6920 for brevity.
6921
6922 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6923
6924 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6925 * data.c (atof): Remove decl; no longer used or needed.
6926 (digit_to_number): Move to lread.c.
6927 (Fstring_to_number): Use new string_to_number function, to be
6928 consistent with how the Lisp reader treats infinities and NaNs.
6929 Do not assume that floating-point numbers represent EMACS_INT
6930 without losing information; this is not true on most 64-bit hosts.
6931 Avoid double-rounding errors, by insisting on integers when
6932 parsing non-base-10 numbers, as the documentation specifies.
6933 * lisp.h (string_to_number): New decl, replacing ...
6934 (isfloat_string): Remove.
6935 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6936 (read1): Do not accept +. and -. as integers; this
6937 appears to have been a coding error. Similarly, do not accept
6938 strings like +-1e0 as floating point numbers. Do not report
6939 overflow for integer overflows unless the base is not 10 which
6940 means we have no simple and reliable way to continue.
6941 Break out the floating-point parsing into a new
6942 function string_to_number, so that Fstring_to_number parses
6943 floating point numbers consistently with the Lisp reader.
6944 (digit_to_number): Move here from data.c. Make it static inline.
6945 (E_CHAR, EXP_INT): Remove, replacing with ...
6946 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6947 (string_to_number): New function, replacing isfloat_string.
6948 This function checks for valid syntax and produces the resulting
6949 Lisp float number too. Rework it so that string-to-number
6950 no longer mishandles examples like "1.0e+". Use strtoumax,
6951 so that overflow for non-base-10 numbers is reported only when
6952 there's no portable and simple way to convert to floating point.
6953
6954 * textprop.c (set_text_properties_1): Rewrite for clarity,
6955 and to avoid GCC warning about integer overflow.
6956
6957 * intervals.h (struct interval): Use EMACS_INT for members
6958 where EMACS_UINT might cause problems. See
6959 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6960 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6961 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6962 All uses changed.
6963 (offset_intervals): Tell GCC not to worry about length overflow
6964 when negating a negative length.
6965
6966 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6967 (overrun_check_free): Likewise.
6968
6969 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6970 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6971 word size.
6972
6973 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6974 (gnutls_make_error): Rename local to avoid shadowing.
6975 (gnutls_emacs_global_deinit): ifdef out; not used.
6976 (Fgnutls_boot): Use const for pointer to readonly storage.
6977 Comment out unused local. Fix pointer signedness problems.
6978
6979 * lread.c (openp): Don't stuff size_t into an 'int'.
6980 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6981 about possible signed overflow.
6982
6983 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6984 (GDK_KEY_g): Don't define if already defined.
6985 (xg_prepare_tooltip): Avoid pointer signedness problem.
6986 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6987
6988 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6989 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6990
6991 * xfns.c (Fx_window_property): Simplify a bit,
6992 to make a bit faster and to avoid GCC 4.6.0 warning.
6993 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6994
6995 * fns.c (internal_equal): Don't assume size_t fits in int.
6996
6997 * alloc.c (compact_small_strings): Tighten assertion a little.
6998
6999 Replace pEd with more-general pI, and fix some printf arg casts.
7000 * lisp.h (pI): New macro, generalizing old pEd macro to other
7001 conversion specifiers. For example, use "...%"pI"d..." rather
7002 than "...%"pEd"...".
7003 (pEd): Remove. All uses replaced with similar uses of pI.
7004 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7005 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7006 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7007 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7008 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7009 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7010 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7011 64-bit hosts.
7012 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7013 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7014 * print.c (safe_debug_print, print_object): Likewise.
7015 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7016 to int.
7017 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7018 avoiding the 0 flag, which is not portable.
7019 * process.c (Fmake_network_process): Use pI to avoid cast.
7020 * region-cache.c (pp_cache): Likewise.
7021 * xdisp.c (decode_mode_spec): Likewise.
7022 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7023 behavior on 64-bit hosts with printf arg.
7024 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7025 (x_stop_queuing_selection_requests): Likewise.
7026 (x_get_window_property): Don't truncate byte count to an 'int'
7027 when tracing.
7028
7029 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7030 here, since it parses constructs like leading '-' and spaces,
7031 which are not wanted; and it overflows with large numbers.
7032 Instead, simply match F[0-9]+, which is what is wanted anyway.
7033
7034 * alloc.c: Remove unportable assumptions about struct layout.
7035 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7036 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7037 (allocate_vectorlike, make_pure_vector): Use the new macros,
7038 plus offsetof, to remove unportable assumptions about struct layout.
7039 These assumptions hold on all porting targets that I know of, but
7040 they are not guaranteed, they're easy to remove, and removing them
7041 makes further changes easier.
7042
7043 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7044 This doesn't fix a bug but makes the code clearer.
7045 (string_overrun_cookie): Now const. Use initializers that
7046 don't formally overflow signed char, to avoid warnings.
7047 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7048 can cause Emacs to crash when string overrun checking is enabled.
7049 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7050 multiple of sizeof (EMACS_INT); it need not be, if
7051 alignof(EMACS_INT) < sizeof (EMACS_INT).
7052 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7053
7054 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7055
7056 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7057
7058 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7059
7060 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7061 supposed to be handshaking. (Bug#8556)
7062 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7063
7064 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7065
7066 * lisp.h (Qdebug): List symbol.
7067 * eval.c (Qdebug): Restore global linkage.
7068 * keyboard.c (debug-on-event): New variable.
7069 (handle_user_signal): Break into debugger when debug-on-event
7070 matches the current signal symbol.
7071
7072 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7073
7074 * alloc.c (check_sblock, check_string_bytes)
7075 (check_string_free_list): Convert to standard C.
7076
7077 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7078
7079 * w32.c (emacs_gnutls_push): Fix typo.
7080
7081 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7082
7083 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7084 "cast to pointer from integer of different size".
7085
7086 Improve doprnt and its use in verror. (Bug#8545)
7087 * doprnt.c (doprnt): Document the set of format control sequences
7088 supported by the function. Use SAFE_ALLOCA instead of always
7089 using `alloca'.
7090
7091 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7092 is one byte too soon. Don't use xrealloc; instead xfree and
7093 xmalloc anew.
7094
7095 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7096
7097 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7098 callbacks stage.
7099
7100 * gnutls.c: Renamed global_initialized to
7101 gnutls_global_initialized. Added internals for the
7102 :verify-hostname-error, :verify-error, and :verify-flags
7103 parameters of `gnutls-boot' and documented those parameters in the
7104 docstring. Start callback support.
7105 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7106 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7107 on error. Return error code.
7108 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7109 (emacs_gnutls_read): Likewise.
7110 (Fgnutls_boot): Return handshake error code.
7111 (emacs_gnutls_handle_error): New function.
7112 (wsaerror_to_errno): Likewise.
7113
7114 * w32.h (emacs_gnutls_pull): Add prototype.
7115 (emacs_gnutls_push): Likewise.
7116
7117 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7118 (emacs_gnutls_push): Likewise.
7119
7120 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7121
7122 * process.c (wait_reading_process_output): Check if GnuTLS
7123 buffered some data internally if no FDs are set for TLS
7124 connections.
7125
7126 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7127 (LIBS): Link to USER_LIBS.
7128 ($(BLD)/gnutls.$(0)): New target.
7129
7130 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7131
7132 * xdisp.c (handle_single_display_spec): Rename the
7133 display_replaced_before_p argument into display_replaced_p, to
7134 make it consistent with the commentary. Fix typos in the
7135 commentary.
7136
7137 * textprop.c (syms_of_textprop): Remove dead code.
7138 (copy_text_properties): Delete obsolete commentary about an
7139 interface that was deleted long ago. Fix typos in the description
7140 of arguments.
7141
7142 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7143 to changes in oldXMenu/XMenu.h from 2011-04-16.
7144 <menu_help_message, prev_menu_help_message>: Constify.
7145 (IT_menu_make_room): menu->help_text is now `const char **';
7146 adjust.
7147
7148 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7149 to changes in oldXMenu/XMenu.h from 2011-04-16.
7150 (struct XMenu): Declare `help_text' `const char **'.
7151
7152 * xfaces.c <Qunspecified>: Make extern again.
7153
7154 * syntax.c: Include sys/types.h before including regex.h, as
7155 required by Posix.
7156
7157 * doc.c (get_doc_string): Improve the format passed to `error'.
7158
7159 * doprnt.c (doprnt): Improve commentary.
7160
7161 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7162
7163 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7164 them with etags.
7165
7166 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7167 changes in globals.h immediately force recompilation.
7168 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7169 $(CURDIR)/s/ms-w32.h.
7170 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7171
7172 * character.c (Fchar_direction): Function deleted.
7173 (syms_of_character): Don't defsubr it.
7174 <char-direction-table>: Deleted.
7175
7176 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7177
7178 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7179 * doprnt.c: Include limits.h.
7180 (SIZE_MAX): New macro.
7181 (doprnt): Return a size_t value. 2nd arg is now size_t.
7182 Many local variables are now size_t instead of int or unsigned.
7183 Improve overflow protection. Support `l' modifier for integer
7184 conversions. Support %l conversion. Don't assume an EMACS_INT
7185 argument for integer conversions and for %c.
7186
7187 * lisp.h (doprnt): Restore prototype.
7188
7189 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7190 $(SRC)/character.h.
7191
7192 * Makefile.in (base_obj): Add back doprnt.o.
7193
7194 * deps.mk (doprnt.o): Add back prerequisites.
7195 (callint.o): Depend on character.h.
7196
7197 * eval.c (internal_lisp_condition_case): Include the handler
7198 representation in the error message.
7199 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7200 when breaking from the loop.
7201
7202 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7203
7204 * callint.c (Fcall_interactively): When displaying error message
7205 about invalid control letter, pass the character's codepoint, not
7206 a pointer to its multibyte form. Improve display of the character
7207 in octal and display also its hex code.
7208
7209 * character.c (char_string): Use %x to display the (unsigned)
7210 codepoint of an invalid character, to avoid displaying a bogus
7211 negative value.
7212
7213 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7214 `error', not SYMBOL_NAME itself.
7215
7216 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7217 character arguments to `error'.
7218
7219 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7220 to `error' in error message about FINAL_CHAR argument. Make sure
7221 FINAL_CHAR is a character, and use %c when it is passed as
7222 argument to `error'.
7223
7224 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7225
7226 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7227
7228 * w32.c: Include <time.h>.
7229 (sys_localtime): New function.
7230
7231 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7232
7233 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7234
7235 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7236
7237 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7238
7239 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7240 zombies (Bug#8467).
7241
7242 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7243
7244 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7245 gl_state.e_property when gl_state.object is Qt.
7246
7247 * insdel.c (make_gap_larger): Remove limitation of buffer size
7248 to <= INT_MAX.
7249
7250 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7251
7252 * xdisp.c (lookup_glyphless_char_display)
7253 (produce_glyphless_glyph): Handle cons cell entry in
7254 glyphless-char-display.
7255 (Vglyphless_char_display): Document it.
7256
7257 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7258 glyphless-char-display.
7259
7260 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7261
7262 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7263
7264 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7265
7266 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7267 definition for no-X builds.
7268
7269 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7270
7271 Static checks with GCC 4.6.0 and non-default toolkits.
7272
7273 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7274
7275 * process.c (keyboard_bit_set): Define only if SIGIO.
7276 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7277 (send_process): Repair possible setjmp clobbering.
7278
7279 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7280
7281 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7282
7283 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7284
7285 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7286 Define only if needed.
7287
7288 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7289 by pacifying GCC about it. Maybe it's time to retire it?
7290 * xfaces.c (USG, __TIMEVAL__): Likewise.
7291
7292 * dispextern.h (struct redisplay_interface): Rename param
7293 to avoid shadowing.
7294 * termhooks.h (struct terminal): Likewise.
7295 * xterm.c (xembed_send_message): Likewise.
7296
7297 * insdel.c (make_gap_smaller): Define only if
7298 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7299
7300 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7301 it.
7302
7303 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7304 so that we aren't warned about unused symbols.
7305
7306 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7307
7308 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7309
7310 * xfns.c (x_real_positions): Mark locals as initialized.
7311
7312 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7313
7314 * xterm.c: Fix problems found by static analysis with other toolkits.
7315 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7316 (x_dispatch_event): Declare static if USE_GTK, and
7317 define if USE_GTK || USE_X_TOOLKIT.
7318 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7319 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7320 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7321 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7322
7323 * xmenu.c (menu_help_callback): Pointer type fixes.
7324 Use const pointers when pointing at readonly data. Avoid pointer
7325 signedness clashes.
7326 (FALSE): Remove unused macro.
7327 (update_frame_menubar): Remove unused decl.
7328
7329 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7330
7331 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7332 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7333 (single_menu_item): Rename local to avoid shadowing.
7334
7335 * keyboard.c (make_lispy_event): Remove unused local var.
7336
7337 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7338 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7339
7340 * bitmaps: Change bitmaps from unsigned char back to the X11
7341 compatible char. Avoid the old compiler warnings about
7342 out-of-range initializers by using, for example, '\xab' rather
7343 than 0xab.
7344
7345 * xgselect.c (xgselect_initialize): Check vs interface
7346 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7347
7348 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7349
7350 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7351 to read-only memory.
7352
7353 * fns.c (vector): Remove; this old hack is no longer needed.
7354
7355 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7356 Remove unused var.
7357 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7358
7359 * xrdb.c (x_load_resources): Omit unused local.
7360
7361 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7362 (x_window): Rename locals to avoid shadowing.
7363 (USG): Use the kludged USG macro, to pacify gcc.
7364
7365 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7366 (x_term_init): Remove local to avoid shadowing.
7367
7368 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7369
7370 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7371 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7372
7373 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7374
7375 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7376
7377 Fix regex.c, syntax.c and friends for buffers > 2GB.
7378 * syntax.h (struct gl_state_s): Declare character position members
7379 EMACS_INT.
7380
7381 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7382
7383 * textprop.c (verify_interval_modification, interval_of):
7384 Declare arguments EMACS_INT.
7385
7386 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7387 EMACS_INT.
7388
7389 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7390
7391 * indent.c (Fvertical_motion): Local variable it_start is now
7392 EMACS_INT.
7393
7394 * regex.c (re_match, re_match_2, re_match_2_internal)
7395 (bcmp_translate, regcomp, regexec, print_double_string)
7396 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7397 (re_compile_pattern, re_exec): Declare arguments and local
7398 variables `size_t' and `ssize_t' and return values `regoff_t', as
7399 appropriate.
7400 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7401 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7402 <compile_stack_type>: `size' and `avail' are now `size_t'.
7403
7404 * regex.h <regoff_t>: Use ssize_t, not int.
7405 (re_search, re_search_2, re_match, re_match_2): Arguments that
7406 specify buffer/string position and length are now ssize_t and
7407 size_t. Return type is regoff_t.
7408
7409 2011-04-16 Ben Key <bkey76@gmail.com>
7410
7411 * nsfont.m: Fixed bugs in ns_get_family and
7412 ns_descriptor_to_entity that were caused by using free to
7413 deallocate memory blocks that were allocated by xmalloc (via
7414 xstrdup). This caused Emacs to crash when compiled with
7415 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7416 --enable-checking=xmallocoverrun). xfree is now used to
7417 deallocate these memory blocks.
7418
7419 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7420
7421 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7422
7423 emacs_write: Accept and return EMACS_INT for sizes.
7424 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7425 et seq.
7426 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7427 Accept and return EMACS_INT.
7428 (emacs_gnutls_write): Return the number of bytes written on
7429 partial writes.
7430 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7431 (emacs_read, emacs_write): Remove check for negative size, as the
7432 Emacs source code has been audited now.
7433 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7434 (emacs_read, emacs_write): Use it.
7435 * process.c (send_process): Adjust to the new signatures of
7436 emacs_write and emacs_gnutls_write. Do not attempt to store
7437 a byte offset into an 'int'; it might overflow.
7438 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7439
7440 * sound.c: Don't assume sizes fit in 'int'.
7441 (struct sound_device.period_size, alsa_period_size):
7442 Return EMACS_INT, not int.
7443 (struct sound_device.write, vox_write, alsa_write):
7444 Accept EMACS_INT, not int.
7445 (wav_play, au_play): Use EMACS_INT to store sizes and to
7446 record read return values.
7447
7448 2011-04-15 Ben Key <bkey76@gmail.com>
7449
7450 * keyboard.c (Qundefined): Don't declare static since it is used
7451 in nsfns.m.
7452 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7453 static since they are used in nsfont.m.
7454
7455 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7456
7457 * process.c (Qprocessp): Don't declare static.
7458 * lisp.h (Qprocessp): Declare again.
7459
7460 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7461
7462 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7463
7464 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7465
7466 Improve C-level modularity by making more things 'static'.
7467
7468 Don't publish debugger-only interfaces to other modules.
7469 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7470 (verify_bytepos, count_markers): Move decls to the only modules
7471 that need them.
7472 * region-cache.h (pp_cache): Likewise.
7473 * window.h (check_all_windows): Likewise.
7474 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7475
7476 * sysdep.c (croak): Now static, if
7477 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7478 * syssignal.h (croak): Declare only if not static.
7479
7480 * alloc.c (refill_memory_reserve): Now static if
7481 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7482 * lisp.h (refill_memory_reserve): Declare only if not static.
7483
7484 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7485 Define only if USE_LUCID.
7486
7487 * xrdb.c (x_customization_string, x_rm_string): Now static.
7488
7489 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7490 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7491
7492 * xdisp.c (draw_row_with_mouse_face): Now static.
7493 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7494
7495 * window.h (check_all_windows): Mark externally visible.
7496
7497 * window.c (window_deletion_count): Now static.
7498
7499 * undo.c: Make symbols static if they're not exported.
7500 (last_undo_buffer, last_boundary_position, pending_boundary):
7501 Now static.
7502
7503 * textprop.c (interval_insert_behind_hooks): Now static.
7504 (interval_insert_in_front_hooks): Likewise.
7505
7506 * term.c: Make symbols static if they're not exported.
7507 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7508 (max_frame_lines, tty_set_terminal_modes):
7509 (tty_reset_terminal_modes, tty_turn_off_highlight):
7510 (get_tty_terminal): Now static.
7511 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7512 * termhooks.h (term_mouse_moveto): Do not declare if
7513 HAVE_WINDOW_SYSTEM.
7514 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7515 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7516
7517 * sysdep.c: Make symbols static if they're not exported.
7518 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7519 Now static.
7520 (sigprocmask_set, full_mask): Remove; unused.
7521 (wait_debugging): Mark as visible.
7522 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7523 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7524
7525 * syntax.c (syntax_temp): Define only if !__GNUC__.
7526
7527 * sound.c (current_sound_device, current_sound): Now static.
7528
7529 * search.c (searchbufs, searchbuf_head): Now static.
7530
7531 * scroll.c (scroll_cost): Remove; unused.
7532 * dispextern.h (scroll_cost): Remove decl.
7533
7534 * region-cache.h (pp_cache): Mark as externally visible.
7535
7536 * process.c: Make symbols static if they're not exported.
7537 (process_tick, update_tick, create_process, chan_process):
7538 (Vprocess_alist, proc_buffered_char, datagram_access):
7539 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7540 (deactivate_process): Mark defn as static, as well as decl.
7541 * lisp.h (create_process): Remove decl.
7542 * process.h (chan_process, Vprocess_alist): Remove decls.
7543
7544 * print.c: Make symbols static if they're not exported.
7545 (print_depth, new_backquote_output, being_printed, print_buffer):
7546 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7547 (print_interval, print_number_index, initial_stderr_stream):
7548 Now static.
7549 * lisp.h (Fprinc): Remove decl.
7550 (debug_output_compilation_hack): Mark as externally visible.
7551
7552 * sysdep.c (croak): Move decl from here to syssignal.h.
7553 * syssignal.h (croak): Put it here, so the API can be checked when
7554 'croak' is called from dissociate_if_controlling_tty.
7555
7556 * minibuf.c: Make symbols static if they're not exported.
7557 (minibuf_save_list, choose_minibuf_frame): Now static.
7558 * lisp.h (choose_minibuf_frame): Remove decl.
7559
7560 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7561
7562 * lread.c: Make symbols static if they're not exported.
7563 (read_objects, initial_obarray, oblookup_last_bucket_number):
7564 Now static.
7565 (make_symbol): Remove; unused.
7566 * lisp.h (initial_obarray, make_symbol): Remove decls.
7567
7568 * keyboard.c: Make symbols static if they're not exported.
7569 (single_kboard, recent_keys_index, total_keys, recent_keys):
7570 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7571 (this_single_command_key_start, echoing, last_auto_save):
7572 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7573 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7574 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7575 (Vlispy_mouse_stem, double_click_count):
7576 Now static.
7577 (force_auto_save_soon): Define only if SIGDANGER.
7578 (ignore_mouse_drag_p): Now static if
7579 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7580 (print_help): Remove; unused.
7581 (stop_character, last_timer_event): Mark as externally visible.
7582 * keyboard.h (ignore_mouse_drag_p): Declare only if
7583 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7584 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7585 * lisp.h (echoing): Remove decl.
7586 (force_auto_save_soon): Declare only if SIGDANGER.
7587 * xdisp.c (redisplay_window): Simplify code, to make it more
7588 obvious that ignore_mouse_drag_p is not accessed if !defined
7589 USE_GTK && !defined HAVE_NS.
7590
7591 * intervals.c: Make symbols static if they're not exported.
7592 (merge_properties_sticky, merge_interval_right, delete_interval):
7593 Now static.
7594 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7595
7596 * insdel.c: Make symbols static if they're not exported.
7597 However, leave prepare_to_modify_buffer alone. It's never
7598 called from outside this function, but that appears to be a bug.
7599 (combine_after_change_list, combine_after_change_buffer):
7600 (adjust_after_replace, signal_before_change): Now static.
7601 (adjust_after_replace_noundo): Remove; unused.
7602 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7603 (signal_before_change): Remove decls.
7604
7605 * indent.c (val_compute_motion, val_vmotion): Now static.
7606
7607 * image.c: Make symbols static if they're not exported.
7608 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7609 if USE_GTK.
7610 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7611 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7612
7613 * fringe.c (standard_bitmaps): Now static.
7614 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7615
7616 * frame.c: Make symbols static if they're not exported.
7617 (x_report_frame_params, make_terminal_frame): Now static.
7618 (get_frame_param): Now static, unless HAVE_NS.
7619 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7620 (x_get_resource_string): Remove; not used.
7621 * frame.h (make_terminal_frame, x_report_frame_params):
7622 (x_get_resource_string); Remove decls.
7623 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7624 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7625
7626 * font.c, fontset.c: Make symbols static if they're not exported.
7627 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7628 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7629 * font.c (font_close_object): Now static.
7630 * font.h (font_close_object): Remove.
7631 * fontset.c (FONTSET_OBJLIST): Remove.
7632 (free_realized_fontset) #if-0 the body, which does nothing.
7633 (face_suitable_for_char_p): #if-0, as it's never called.
7634 * fontset.h (face_suitable_for_char_p): Remove decl.
7635 * xfaces.c (face_at_string_position):
7636 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7637 since 0 is always ASCII.
7638
7639 * fns.c (weak_hash_tables): Now static.
7640
7641 * fileio.c: Make symbols static if they're not exported.
7642 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7643 (Vwrite_region_annotation_buffers): Now static.
7644
7645 * eval.c: Make symbols static if they're not exported.
7646 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7647 * lisp.h (backtrace_list): Remove decl.
7648
7649 * emacs.c: Make symbols static if they're not exported.
7650 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7651 (fatal_error_code, fatal_error_signal_hook, standard_args):
7652 Now static.
7653 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7654 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7655 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7656 * lisp.h (fatal_error_signal_hook): Remove decl.
7657 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7658
7659 * editfns.c: Move a (normally-unused) function to its only use.
7660 * editfns.c, lisp.h (get_operating_system_release): Remove.
7661 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7662 worth the hassle of breaking this out.
7663
7664 * xterm.c: Make symbols static if they're not exported.
7665 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7666 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7667 (x_destroy_window, x_delete_display):
7668 Now static.
7669 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7670 (x_mouse_leave): Remove; unused.
7671 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7672 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7673 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7674 Remove decls.
7675 (x_mouse_leave): Declare only if WINDOWSNT.
7676 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7677 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7678 USE_X_TOOLKIT.
7679
7680 * ftxfont.c: Make symbols static if they're not exported.
7681 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7682 HAVE_FREETYPE.
7683 * font.h (ftxfont_driver): Likewise.
7684
7685 * xfns.c: Make symbols static if they're not exported.
7686 (x_last_font_name, x_display_info_for_name):
7687 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7688 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7689 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7690 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7691 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7692 (last_show_tip_args): Now static.
7693 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7694 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7695 (x_screen_planes): Remove; unused.
7696 * dispextern.h (x_screen_planes): Remove decl.
7697
7698 * dispnew.c: Make symbols static if they're not exported.
7699 * dispextern.h (redraw_garbaged_frames, scrolling):
7700 (increment_row_positions): Remove.
7701 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7702 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7703 Now static.
7704 (redraw_garbaged_frames): Remove; unused.
7705
7706 * xfaces.c: Make symbols static if they're not exported.
7707 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7708 Remove decls.
7709 * xterm.h (defined_color): Remove decls.
7710 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7711 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7712 (menu_face_changed_default, defined_color, free_realized_face):
7713 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7714 (ascii_face_of_lisp_face): Remove; unused.
7715
7716 * xdisp.c: Make symbols static if they're not exported.
7717 * dispextern.h (scratch_glyph_row, window_box_edges):
7718 (glyph_to_pixel_coords, set_cursor_from_row):
7719 (get_next_display_element, set_iterator_to_next):
7720 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7721 (show_mouse_face): Remove decls
7722 * frame.h (message_buf_print): Likewise.
7723 * lisp.h (pop_message, set_message, check_point_in_composition):
7724 Likewise.
7725 * xterm.h (set_vertical_scroll_bar): Likewise.
7726 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7727 (message_buf_print, scratch_glyph_row, displayed_buffer):
7728 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7729 (get_next_display_element, show_mouse_face, window_box_edges):
7730 (frame_to_window_pixel_xy, check_point_in_composition):
7731 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7732 (glyph_to_pixel_coords): Remove; unused.
7733
7734 * dired.c (file_name_completion): Now static.
7735
7736 * dbusbind.c (xd_in_read_queued_messages): Now static.
7737
7738 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7739 * data.c (circular_list_error): Remove.
7740
7741 * commands.h (last_point_position, last_point_position_buffer):
7742 (last_point_position_window): Remove decls.
7743 * keyboard.c: Make these variables static.
7744
7745 * coding.h (coding, code_convert_region, encode_coding_gap):
7746 Remove decls.
7747 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7748 (iso_code_class, detect_coding, code_convert_region): Now static.
7749 (encode_coding_gap): Remove; unused.
7750
7751 * chartab.c (chartab_chars, chartab_bits): Now static.
7752
7753 * charset.h (charset_iso_8859_1): Remove decl.
7754 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7755 Now static.
7756
7757 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7758 * ccl.c (Vccl_program_table): Now static.
7759 (check_ccl_update): Remove; unused.
7760
7761 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7762 * category.h: ... from here.
7763 * category.c (check_category_table, set_category_set): Now static.
7764
7765 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7766 * lisp.h: Remove these decls.
7767
7768 * buffer.c (buffer_count): Remove unused var.
7769
7770 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7771 so that it's not optimized away.
7772 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7773 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7774 exported only to the debugger.
7775
7776 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7777 * atimer.h (run_all_atimers): Remove; not exported.
7778
7779 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7780 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7781 was inaccessible from Lisp.
7782 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7783 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7784
7785 alloc.c: Import and export fewer symbols, and remove unused items.
7786 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7787 is defined.
7788 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7789 it's not optimized away by whole-program optimization.
7790 (message_enable_multibyte, free_misc): Remove.
7791 (catchlist, handlerlist, mark_backtrace):
7792 Declare only if BYTE_MARK_STACK.
7793 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7794 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7795 (message_enable_multibyte): Remove decl.
7796 (free_misc, interval_free_list, float_block, float_block_index):
7797 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7798 (cons_free_list, last_marked_index):
7799 Now static.
7800 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7801 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7802 (mark_backtrace): Define only if BYTE_MARK_STACK.
7803 * xdisp.c (message_enable_multibyte): Now static.
7804
7805 Declare Lisp_Object Q* variables to be 'static' if not exported.
7806 This makes it easier for human readers (and static analyzers)
7807 to see whether these variables are used from other modules.
7808 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7809 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7810 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7811 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7812 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7813 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7814 * xmenu.c, xselect.c:
7815 Declare Q* vars static if they are not used in other modules.
7816 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7817 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7818 Remove decls of unexported vars.
7819 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7820
7821 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7822
7823 Make Emacs functions such as Fatom 'static' by default.
7824 This makes it easier for human readers (and static analyzers)
7825 to see whether these functions can be called from other modules.
7826 DEFUN now defines a static function. To make the function external
7827 so that it can be used in other C modules, use the new macro DEFUE.
7828 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7829 (Finit_image_library):
7830 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7831 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7832 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7833 Remove decls, since these functions are now static.
7834 (Funintern, Fget_internal_run_time): New decls, since these functions
7835 were already external.
7836
7837 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7838 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7839 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7840 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7841 * keyboard.c, keymap.c, lread.c:
7842 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7843 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7844 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7845 Mark functions with DEFUE instead of DEFUN,
7846 if they are used in other modules.
7847 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7848 decls for now-static functions.
7849 * buffer.h (Fdelete_overlay): Remove decl.
7850 * callproc.c (Fgetenv_internal): Mark as internal.
7851 * composite.c (Fremove_list_of_text_properties): Remove decl.
7852 (Fcomposition_get_gstring): New forward static decl.
7853 * composite.h (Fcomposite_get_gstring): Remove decl.
7854 * dired.c (Ffile_attributes): New forward static decl.
7855 * doc.c (Fdocumntation_property): New forward static decl.
7856 * eval.c (Ffetch_bytecode): New forward static decl.
7857 (Funintern): Remove extern decl; now in .h file where it belongs.
7858 * fileio.c (Fmake_symbolic_link): New forward static decl.
7859 * image.c (Finit_image_library): New forward static decl.
7860 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7861 * intervals.h (Fprevious_property_change):
7862 (Fremove_list_of_text_properties): Remove decls.
7863 * keyboard.c (Fthis_command_keys): Remove decl.
7864 (Fcommand_execute): New forward static decl.
7865 * keymap.c (Flookup_key): New forward static decl.
7866 (Fcopy_keymap): Now static.
7867 * keymap.h (Flookup_key): Remove decl.
7868 * process.c (Fget_process): New forward static decl.
7869 (Fprocess_datagram_address): Mark as internal.
7870 * syntax.c (Fsyntax_table_p): New forward static decl.
7871 (skip_chars): Remove duplicate decl.
7872 * textprop.c (Fprevious_property_change): New forward static decl.
7873 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7874 Now internal.
7875 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7876 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7877
7878 * editfns.c (Fformat): Remove unreachable code.
7879
7880 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7881
7882 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7883 change. (Bug#8496)
7884
7885 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7886
7887 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7888 when at ZV. (Bug#8487)
7889
7890 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7891
7892 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7893 (Bug#8437)
7894 * keyboard.c (parse_tool_bar_item): Likewise.
7895 * sound.c (sound_cleanup, alsa_close): Likewise.
7896 * termcap.c (tgetent): Likewise.
7897 * xfns.c (x_default_font_parameter): Likewise.
7898 * xsettings.c (read_and_apply_settings): Likewise.
7899
7900 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7901 (overrun_check_free): Protoize.
7902
7903 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7904
7905 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7906 since callers should never pass a negative size.
7907 Change the signature to match that of plain 'read' and 'write'; see
7908 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7909 * lisp.h: Update prototypes of emacs_write and emacs_read.
7910
7911 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7912
7913 * xdisp.c (redisplay_window): Don't try to determine the character
7914 position of the scroll margin if the window start point w->startp
7915 is outside the buffer's accessible region. (Bug#8468)
7916
7917 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7918
7919 Fix write-region and its subroutines for buffers > 2GB.
7920 * fileio.c (a_write, e_write): Modify declaration of arguments and
7921 local variables to support buffers larger than 2GB.
7922 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7923
7924 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7925 argument, local variables, and return value.
7926
7927 * lisp.h: Update prototypes of emacs_write and emacs_read.
7928
7929 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7930
7931 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7932
7933 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7934
7935 Fix more problems found by GCC 4.6.0's static checks.
7936
7937 * xdisp.c (vmessage): Use a better test for character truncation.
7938
7939 * charset.c (load_charset_map): <, not <=, for optimization,
7940 and to avoid potential problems with integer overflow.
7941 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7942 * casetab.c (set_identity, shuffle): Likewise.
7943 * editfns.c (Fformat): Likewise.
7944 * syntax.c (skip_chars): Likewise.
7945
7946 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7947 This also lets GCC 4.6.0 generate slightly better loop code.
7948
7949 * callint.c (Fcall_interactively): <, not <=, for optimization.
7950 (Fcall_interactively): Count the number of arguments produced,
7951 not the number of arguments given. This is simpler and lets GCC
7952 4.6.0 generate slightly better code.
7953
7954 * ftfont.c: Distingish more carefully between FcChar8 and char.
7955 The previous code passed unsigned char * to a functions like
7956 strlen and xstrcasecmp that expect char *, which does not
7957 conform to the C standard.
7958 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7959 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7960 char * when the C standard requires it.
7961
7962 * keyboard.c (read_char): Remove unused var.
7963
7964 * eval.c: Port to Windows vsnprintf (Bug#8435).
7965 Include <limits.h>.
7966 (SIZE_MAX): Define if the headers do not.
7967 (verror): Do not give up if vsnprintf returns a negative count.
7968 Instead, grow the buffer. This ports to Windows vsnprintf, which
7969 does not conform to C99. Problem reported by Eli Zaretskii.
7970 Also, simplify the allocation scheme, by avoiding the need for
7971 calling realloc, and removing the ALLOCATED variable.
7972
7973 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7974
7975 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7976 But keep the doprint source code for now, as we might revamp it
7977 and use it again (Bug#8435).
7978 * lisp.h (doprnt): Remove.
7979 * Makefile.in (base_obj): Remove doprnt.o.
7980 * deps.mk (doprnt.o): Remove.
7981
7982 error: Print 32- and 64-bit integers portably (Bug#8435).
7983 Without this change, on typical 64-bit hosts error ("...%d...", N)
7984 was used to print both 32- and 64-bit integers N, which relied on
7985 undefined behavior.
7986 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
7987 * lisp.h (error, verror): Mark as printf-like functions.
7988 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7989 Report overflow in size calculations when allocating printf buffer.
7990 Do not truncate output string at its first null byte.
7991 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7992 Truncate the output at a character boundary, since vsnprintf does not
7993 do that.
7994 * charset.c (check_iso_charset_parameter): Convert internal
7995 character to string before calling 'error', since %c now has the
7996 printf meaning.
7997 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7998 overflow when computing char to be passed to 'error'. Do not
7999 pass Lisp_Object to 'error'; pass the integer instead.
8000 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8001 formatted with plain %d.
8002
8003 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8004
8005 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8006
8007 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8008
8009 * xterm.c (x_catch_errors): Remove duplicate declaration.
8010
8011 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8012
8013 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8014
8015 2011-04-10 Jim Meyering <meyering@redhat.com>
8016
8017 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8018 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8019 return ssize_t not "int", and use size_t as the buffer length.
8020 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8021 * gnutls.h: Update declarations.
8022 * process.c (read_process_output): Use ssize_t, to match.
8023 (send_process): Likewise.
8024
8025 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8026
8027 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8028
8029 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8030
8031 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8032 Use unsigned char, to match FcChar8 type definition.
8033
8034 * xterm.c (handle_one_xevent):
8035 * xmenu.c (create_and_show_popup_menu):
8036 * xselect.c (x_decline_selection_request)
8037 (x_reply_selection_request): Avoid type-punned deref of X events.
8038
8039 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8040
8041 Fix some uses of `int' instead of EMACS_INT.
8042 * search.c (string_match_1, fast_string_match)
8043 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8044 (scan_buffer, find_next_newline_no_quit)
8045 (find_before_next_newline, search_command, Freplace_match)
8046 (Fmatch_data): Make some `int' variables be EMACS_INT.
8047
8048 * xdisp.c (display_count_lines): 3rd argument and return value now
8049 EMACS_INT. All callers changed.
8050 (pint2hrstr): Last argument is now EMACS_INT.
8051
8052 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8053 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8054 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8055 (decode_coding_utf_16, decode_coding_emacs_mule)
8056 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8057 (decode_coding_ccl, decode_coding_charset)
8058 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8059 (decode_coding_iso_2022, decode_coding_emacs_mule)
8060 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8061 <char_offset, last_offset>: Declare EMACS_INT.
8062 (encode_coding_utf_8, encode_coding_utf_16)
8063 (encode_coding_emacs_mule, encode_invocation_designation)
8064 (encode_designation_at_bol, encode_coding_iso_2022)
8065 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8066 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8067 Declare EMACS_INT.
8068 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8069 (encode_invocation_designation): Last argument P_NCHARS is now
8070 EMACS_INT.
8071 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8072 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8073
8074 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8075 All users changed.
8076
8077 * ccl.c (Fccl_execute_on_string): Declare some variables
8078 EMACS_INT.
8079
8080 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8081
8082 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8083
8084 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8085
8086 * process.c (Fformat_network_address): Doc fix.
8087
8088 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8089
8090 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8091
8092 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8093
8094 * keyboard.c (read_char): Call Lisp function help-form-show,
8095 instead of using internal_with_output_to_temp_buffer.
8096 (Qhelp_form_show): New var.
8097 (syms_of_keyboard): Use DEFSYM macro.
8098
8099 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8100
8101 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8102
8103 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8104
8105 * process.c (Flist_processes): Remove to Lisp.
8106 (list_processes_1): Delete.
8107
8108 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8109
8110 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8111
8112 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8113
8114 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8115
8116 Fix more problems found by GCC 4.6.0's static checks.
8117
8118 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8119
8120 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8121
8122 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8123
8124 * xdisp.c (vmessage): Mark as a printf-like function.
8125
8126 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8127
8128 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8129
8130 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8131 printf-like functions.
8132 (tiff_load): Add casts to remove these marks before passing them
8133 to system-supplied API.
8134
8135 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8136
8137 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8138 This avoids several warnings with gcc -Wstrict-overflow.
8139 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8140 directly, rather than having caller test rule sign. This avoids
8141 some unnecessary tests.
8142 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8143 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8144 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8145
8146 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8147 (xfont_open): Avoid unnecessary tests.
8148
8149 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8150
8151 * composite.h, composite.c (composition_gstring_put_cache):
8152 Use EMACS_INT, not int, for length.
8153
8154 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8155 breaking out part of COMPOSITION_DECODE_RULE.
8156 (COMPOSITION_DECODE_RULE): Use it.
8157 * composite.c (get_composition_id): Remove unused local vars,
8158 by using the new macro.
8159
8160 * textprop.c (set_text_properties_1): Change while to do-while,
8161 since the condition is always true at first.
8162
8163 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8164 (interval_deletion_adjustment): Return unsigned value.
8165 All uses changed.
8166
8167 * process.c (list_processes_1, create_pty, read_process_output):
8168 (exec_sentinel): Remove vars that were set but not used.
8169 (create_pty): Remove unnecessary "volatile"s.
8170 (Fnetwork_interface_info): Avoid possibility of int overflow.
8171 (read_process_output): Do adaptive read buffering even if carryover.
8172 (read_process_output): Simplify nbytes computation if buffered.
8173
8174 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8175
8176 * syntax.c (scan_words): Remove var that was set but not used.
8177 (update_syntax_table): Use unsigned instead of int.
8178
8179 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8180 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8181 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8182
8183 * print.c (print_error_message): Avoid int overflow.
8184
8185 * font.c (font_list_entities): Redo for clarity,
8186 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8187
8188 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8189 (font_score): Avoid potential overflow in diff calculation.
8190
8191 * fns.c (substring_both): Remove var that is set but not used.
8192 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8193
8194 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8195
8196 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8197 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8198 can always succeed if overflow has undefined behavior.
8199
8200 * search.c (boyer_moore, wordify): Remove vars set but not used.
8201 (wordify): Omit three unnecessary tests.
8202
8203 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8204 All callers changed. This avoids the need for an unused var.
8205
8206 * casefiddle.c (casify_region): Remove var that is set but not used.
8207
8208 * dired.c (file_name_completion): Remove var that is set but not used.
8209
8210 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8211
8212 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8213 (Finsert_file_contents): Remove unnecessary code checking fd.
8214
8215 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8216 Check for integer overflow on size calculations.
8217
8218 * buffer.c (Fprevious_overlay_change): Remove var that is set
8219 but not used.
8220
8221 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8222 Remove vars that are set but not used.
8223 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8224 (timer_check_2): Mark vars as initialized.
8225
8226 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8227
8228 * image.c (lookup_image): Remove var that is set but not used.
8229 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8230
8231 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8232 that are set but not used.
8233
8234 * xfns.c (make_invisible_cursor): Don't return garbage
8235 if XCreateBitmapFromData fails (Bug#8410).
8236
8237 * xselect.c (x_get_local_selection, x_handle_property_notify):
8238 Remove vars that are set but not used.
8239
8240 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8241 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8242
8243 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8244 Remove var that is set but not used.
8245 (scroll_bar_windows_size): Now size_t, not int.
8246 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8247 Check for overflow.
8248
8249 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8250 (map_tty_color) [!defined MSDOS]: Likewise.
8251
8252 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8253
8254 * coding.c: Remove vars that are set but not used.
8255 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8256 All callers changed.
8257 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8258 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8259 (decode_coding_charset): Remove vars that are set but not used.
8260
8261 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8262 that is set but not used.
8263
8264 * print.c (print_object): Remove var that is set but not used.
8265
8266 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8267 The gnulib version avoids calling malloc in the usual case,
8268 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8269 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8270 * filelock.c (current_lock_owner): Likewise.
8271 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8272 * sysdep.c: Include allocator.h, careadlinkat.h.
8273 (emacs_no_realloc_allocator): New static constant.
8274 (emacs_readlink): New function.
8275 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8276 ../lib/careadlinkat.h.
8277
8278 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8279
8280 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8281 first non-nil return value).
8282
8283 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8284
8285 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8286 if not defined (Bug#8403).
8287
8288 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8289
8290 * xdisp.c (display_count_lines): Remove parameter `start',
8291 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8292 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8293 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8294 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8295 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8296 and thereabouts. All callers changed.
8297 (get_per_char_metric): Remove parameter `f', unused since
8298 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8299
8300 2011-04-02 Jim Meyering <meyering@redhat.com>
8301
8302 do not dereference NULL upon failed strdup
8303 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8304 (ns_get_family): Likewise.
8305
8306 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8307
8308 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8309
8310 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8311
8312 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8313 later (Bug#8403).
8314
8315 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8316
8317 Add lexical binding.
8318
8319 * window.c (Ftemp_output_buffer_show): New fun.
8320 (Fsave_window_excursion):
8321 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8322
8323 * lread.c (lisp_file_lexically_bound_p): New function.
8324 (Fload): Bind Qlexical_binding.
8325 (readevalloop): Remove `evalfun' arg.
8326 Bind Qinternal_interpreter_environment.
8327 (Feval_buffer): Bind Qlexical_binding.
8328 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8329 Mark as dynamic.
8330 (syms_of_lread): Declare `lexical-binding'.
8331
8332 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8333
8334 * keyboard.c (eval_dyn): New fun.
8335 (menu_item_eval_property): Use it.
8336
8337 * image.c (parse_image_spec): Use Ffunctionp.
8338
8339 * fns.c (concat, mapcar1): Accept byte-code-functions.
8340
8341 * eval.c (Fsetq): Handle lexical vars.
8342 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8343 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8344 (FletX, Flet): Obey lexical binding.
8345 (Fcommandp): Handle closures.
8346 (Feval): New `lexical' arg.
8347 (eval_sub): New function extracted from Feval. Use it almost
8348 everywhere where Feval was used. Look up vars in lexical env.
8349 Handle closures.
8350 (Ffunctionp): Move from subr.el.
8351 (Ffuncall): Handle closures.
8352 (apply_lambda): Remove `eval_flags'.
8353 (funcall_lambda): Handle closures and new byte-code-functions.
8354 (Fspecial_variable_p): New function.
8355 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8356 but without exporting it to Lisp.
8357
8358 * doc.c (Fdocumentation, store_function_docstring):
8359 * data.c (Finteractive_form): Handle closures.
8360
8361 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8362 interactive spec.
8363
8364 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8365 New byte-codes.
8366 (exec_byte_code): New function extracted from Fbyte_code to handle new
8367 calling convention for byte-code-functions. Add new byte-codes.
8368
8369 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8370
8371 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8372
8373 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8374
8375 * xdisp.c (redisplay_internal): Fix prototype.
8376
8377 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8378
8379 * xdisp.c (SCROLL_LIMIT): New macro.
8380 (try_scrolling): Use it when setting scroll_limit.
8381 Limit scrolling to 100 screen lines.
8382 (redisplay_window): Even when falling back on "recentering",
8383 position point in the window according to scroll-conservatively,
8384 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8385
8386 (try_scrolling): When point is above the window, allow searching
8387 as far as scroll_max, or one screenful, to compute vertical
8388 distance from PT to the scroll margin position. This prevents
8389 try_scrolling from unnecessarily failing when
8390 scroll-conservatively is set to a value slightly larger than the
8391 window height. Clean up the case of PT below the margin at bottom
8392 of window: scroll_max can no longer be INT_MAX. When aggressive
8393 scrolling is in use, don't let point enter the opposite scroll
8394 margin as result of the scroll.
8395 (syms_of_xdisp) <scroll-conservatively>: Document the
8396 threshold of 100 lines for never-recentering scrolling.
8397
8398 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8399
8400 * dispextern.h (move_it_by_lines):
8401 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8402 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8403 (message_log_check_duplicate): Remove parameters `prev_bol' and
8404 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8405 (redisplay_internal): Remove parameter `preserve_echo_area',
8406 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8407
8408 * indent.c (Fvertical_motion):
8409 * window.c (window_scroll_pixel_based, Frecenter):
8410 Don't pass `need_y_p' to `move_it_by_lines'.
8411
8412 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8413
8414 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8415 steal a few bits to be more compact.
8416 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8417 Remove unneeded casts.
8418
8419 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8420
8421 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8422
8423 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8424 binding" message (bug#7967).
8425
8426 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8427
8428 Fix more problems found by GCC 4.6.0's static checks.
8429
8430 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8431 Remove unused local var.
8432
8433 * editfns.c (Fmessage_box): Remove unused local var.
8434
8435 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8436 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8437 Omit unused local vars.
8438 * window.c (shrink_windows): Omit unused local var.
8439 * menu.c (digest_single_submenu): Omit unused local var.
8440 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8441 Omit unused local var.
8442
8443 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8444 Don't assume string length fits in int.
8445 (keyremap_step, read_key_sequence): Use size_t for sizes.
8446 (read_key_sequence): Don't check last_real_key_start redundantly.
8447
8448 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8449 instead of alloca (Bug#8344).
8450
8451 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8452 (Fbacktrace_frame): Don't assume nframes fits in int.
8453
8454 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8455
8456 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8457 concerns.
8458
8459 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8460
8461 * cm.c (calccost): Turn while-do into do-while, for clarity.
8462
8463 * keyboard.c (syms_of_keyboard): Use the same style as later
8464 in this function when indexing through an array. This also
8465 works around GCC bug 48267.
8466
8467 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8468
8469 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8470
8471 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8472 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8473
8474 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8475 This avoids undefined behavior on integer overflow, and is a bit
8476 more convenient anyway since it is compared to a size_t variable.
8477
8478 Variadic C functions now count arguments with size_t, not int.
8479 This avoids an unnecessary limitation on 64-bit machines, which
8480 caused (substring ...) to crash on large vectors (Bug#8344).
8481 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8482 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8483 All variadic functions and their callers changed accordingly.
8484 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8485 * data.c (arith_driver, float_arith_driver): Likewise.
8486 * editfns.c (general_insert_function): Likewise.
8487 * eval.c (struct backtrace.nargs, interactive_p)
8488 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8489 (funcall_lambda, mark_backtrace): Likewise.
8490 * fns.c (concat): Likewise.
8491 * frame.c (x_set_frame_parameters): Likewise.
8492 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8493 0 if not found, not -1. All callers changed.
8494
8495 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8496 (stack_copy_size): Now size_t, not int.
8497 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8498
8499 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8500
8501 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8502 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8503 All callers changed.
8504
8505 * lisp.h (multibyte_char_to_unibyte):
8506 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8507 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8508 * character.h (CHAR_TO_BYTE8):
8509 * cmds.c (internal_self_insert):
8510 * editfns.c (general_insert_function):
8511 * keymap.c (push_key_description):
8512 * search.c (Freplace_match):
8513 * xdisp.c (message_dolog, set_message_1): All callers changed.
8514
8515 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8516
8517 * keyboard.c (safe_run_hook_funcall): New function.
8518 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8519 don't set the hook to nil, but remove the offending function instead.
8520 (Qcommand_hook_internal): Remove, unused.
8521 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8522 Vcommand_hook_internal.
8523
8524 * eval.c (enum run_hooks_condition): Remove.
8525 (funcall_nil, funcall_not): New functions.
8526 (run_hook_with_args): Call each function through a `funcall' argument.
8527 Remove `cond' argument, now redundant.
8528 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8529 (Frun_hook_with_args_until_failure): Adjust accordingly.
8530 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8531
8532 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8533
8534 * dispextern.h (string_buffer_position): Remove declaration.
8535
8536 * print.c (strout): Remove parameter `multibyte', unused since
8537 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8538
8539 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8540 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8541 All callers changed.
8542
8543 * w32.c (_wsa_errlist): Use braces for struct initializers.
8544
8545 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8546 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8547 All callers changed.
8548 (string_buffer_position): Likewise. Also, make static (it's never
8549 used outside xdisp.c).
8550 (cursor_row_p): Remove parameter `w', unused since
8551 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8552 (decode_mode_spec): Remove parameter `precision', introduced during
8553 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8554 All callers changed.
8555
8556 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8557
8558 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8559
8560 2011-03-27 Anders Lindgren <andlind@gmail.com>
8561
8562 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8563 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8564 (ns_update_auto_hide_menu_bar): New functions.
8565 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8566 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8567 ns_constrain_all_frames.
8568 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8569 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8570
8571 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8572
8573 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8574
8575 2011-03-27 Glenn Morris <rgm@gnu.org>
8576
8577 * syssignal.h: Replace RETSIGTYPE with void.
8578 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8579 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8580 Replace SIGTYPE with void everywhere.
8581 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8582 * s/template.h (SIGTYPE): Remove commented out definition.
8583
8584 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8585
8586 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8587 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8588
8589 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8590
8591 * w32.c (read_unc_volume): Use parameter `henum', instead of
8592 global variable `wget_enum_handle'.
8593
8594 * keymap.c (describe_vector): Remove parameters `indices' and
8595 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8596 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8597
8598 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8599
8600 * keyboard.c (timer_check): Remove parameter `do_it_now',
8601 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8602 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8603 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8604
8605 * keyboard.c (read_char):
8606 * w32menu.c (w32_menu_display_help):
8607 * xmenu.c (show_help_event, menu_help_callback):
8608 Adjust calls to `show_help_echo'.
8609
8610 * gtkutil.c (xg_maybe_add_timer):
8611 * keyboard.c (readable_events):
8612 * process.c (wait_reading_process_output):
8613 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8614
8615 * insdel.c (adjust_markers_gap_motion):
8616 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8617 (gap_left, gap_right): Don't call it.
8618
8619 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8620
8621 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8622 incurred during fontification.
8623
8624 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8625
8626 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8627 (DEFVAR_PER_BUFFER): Don't pass it.
8628
8629 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8630 (scrolling_window): Don't pass it.
8631
8632 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8633
8634 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8635
8636 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8637 and `suffix'.
8638 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8639 of variables specific to SELinux and computation of `encoded_absname'.
8640
8641 * image.c (XPutPixel): Remove unused variable `height'.
8642
8643 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8644
8645 * unexw32.c (get_section_info): Remove unused variable `section'.
8646
8647 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8648 (system_process_attributes): Remove unused variable `sess'.
8649 (sys_read): Remove unused variable `err'.
8650
8651 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8652 (w32_wnd_proc): Remove unused variable `isdead'.
8653 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8654 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8655 (x_create_tip_frame): Remove unused variable `tem'.
8656
8657 * w32inevt.c (w32_console_read_socket):
8658 Remove unused variable `no_events'.
8659
8660 * w32term.c (x_draw_composite_glyph_string_foreground):
8661 Remove unused variable `width'.
8662
8663 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8664
8665 * w32term.c (x_set_glyph_string_clipping):
8666 Don't pass uninitialized region to CombineRgn.
8667
8668 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8669
8670 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8671 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8672 (Fx_close_connection): Remove unused variable `i'.
8673
8674 * w32font.c (w32font_draw): Return number of glyphs.
8675 (w32font_open_internal): Remove unused variable `i'.
8676 (w32font_driver): Add missing initializer.
8677
8678 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8679 (fill_in_menu): Remove unused variable `items_added'.
8680
8681 * w32term.c (last_mouse_press_frame): Remove static global variable.
8682 (w32_clip_to_row): Remove unused variable `f'.
8683 (x_delete_terminal): Remove unused variable `i'.
8684
8685 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8686 (NOTHING): Remove unused static global variable.
8687 (uniscribe_check_otf): Remove unused variable `table'.
8688 (uniscribe_font_driver): Add missing initializers.
8689
8690 2011-03-23 Julien Danjou <julien@danjou.info>
8691
8692 * term.c (Fsuspend_tty, Fresume_tty):
8693 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8694 * window.c (temp_output_buffer_show):
8695 * insdel.c (signal_before_change):
8696 * frame.c (Fhandle_switch_frame):
8697 * fileio.c (Fdo_auto_save):
8698 * emacs.c (Fkill_emacs):
8699 * editfns.c (save_excursion_restore):
8700 * cmds.c (internal_self_insert):
8701 * callint.c (Fcall_interactively):
8702 * buffer.c (Fkill_all_local_variables):
8703 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8704 Use Frun_hooks.
8705 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8706 unconditionally since it does the check itself.
8707
8708 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8709
8710 Fix more problems found by GCC 4.5.2's static checks.
8711
8712 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8713 the first time through the loop, since we know p0 < p1 then.
8714 This also avoids a gcc -Wstrict-overflow warning.
8715
8716 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8717 leading to a memory leak, possible in functions like
8718 load_charset_map_from_file that can allocate an unbounded number
8719 of objects (Bug#8318).
8720
8721 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8722 that could (at least in theory) be that large.
8723
8724 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8725 This is less likely to overflow, and avoids undefined behavior if
8726 overflow does occur. All callers changed. Use strtoul to scan
8727 for the unsigned long integer.
8728 (pint2hrstr): Simplify and tune code slightly.
8729 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8730
8731 * scroll.c (do_scrolling): Work around GCC bug 48228.
8732 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8733
8734 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8735 This also avoids a warning with gcc -Wstrict-overflow.
8736 (validate_x_resource_name): Simplify count usage.
8737 This also avoids a warning with gcc -Wstrict-overflow.
8738
8739 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8740 fail (Bug#8306).
8741
8742 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8743
8744 * process.c (Fmake_network_process): Use socklen_t, not int,
8745 where POSIX says socklen_t is required in portable programs.
8746 This fixes a porting bug on hosts like 64-bit HP-UX, where
8747 socklen_t is wider than int (Bug#8277).
8748 (Fmake_network_process, server_accept_connection):
8749 (wait_reading_process_output, read_process_output):
8750 Likewise.
8751
8752 * process.c: Rename or move locals to avoid shadowing.
8753 (list_processes_1, Fmake_network_process):
8754 (read_process_output_error_handler, exec_sentinel_error_handler):
8755 Rename or move locals.
8756 (Fmake_network_process): Define label "retry_connect" only if needed.
8757 (Fnetwork_interface_info): Fix pointer signedness.
8758 (process_send_signal): Add cast to avoid pointer signedness problem.
8759 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8760 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8761
8762 Make tparam.h and terminfo.c consistent.
8763 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8764 Include tparam.h instead, since it declares them.
8765 * cm.h (PC): Remove extern decl; tparam.h now does this.
8766 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8767 * terminfo.c: Include tparam.h, to check interfaces.
8768 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8769 (tparam): Adjust signature to match interface in tparam.h;
8770 this removes some undefined behavior. Check that outstring and len
8771 are zero, which they always are with Emacs.
8772 * tparam.h (PC, BC, UP): New extern decls.
8773
8774 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8775 (xftfont_open): Rename locals to avoid shadowing.
8776
8777 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8778 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8779 (OTF_TAG_SYM): Omit macro if not needed.
8780 (ftfont_list): Remove unused local.
8781 (get_adstyle_property, ftfont_pattern_entity):
8782 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8783 Rename locals to avoid shadowing.
8784
8785 * xfont.c (xfont_list_family): Mark var as initialized.
8786
8787 * xml.c (make_dom): Now static.
8788
8789 * composite.c (composition_compute_stop_pos): Rename local to
8790 avoid shadowing.
8791 (composition_reseat_it): Remove unused locals.
8792 (find_automatic_composition, composition_adjust_point): Likewise.
8793 (composition_update_it): Mark var as initialized.
8794 (find_automatic_composition): Mark vars as initialized,
8795 with a FIXME (Bug#8290).
8796
8797 character.h: Rename locals to avoid shadowing.
8798 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8799 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8800 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8801 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8802 to avoid shadowing.
8803
8804 * textprop.c (property_change_between_p): Remove; unused.
8805
8806 * intervals.c (interval_start_pos): Now static.
8807
8808 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8809
8810 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8811 Rename locals to avoid shadowing.
8812
8813 * sound.c (wav_play, au_play, Fplay_sound_internal):
8814 Fix pointer signedness.
8815 (alsa_choose_format): Remove unused local var.
8816 (wav_play): Initialize a variable to 0, to prevent undefined
8817 behavior (Bug#8278).
8818
8819 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8820
8821 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8822
8823 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8824 clobbering (Bug#8298).
8825 * sysdep.c (sys_subshell): Likewise.
8826 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8827
8828 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8829 This should get cleaned up, so that child_setup has the
8830 same signature on all platforms.
8831
8832 * callproc.c (call_process_cleanup): Now static.
8833 (relocate_fd): Rename locals to avoid shadowing.
8834
8835 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8836
8837 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8838 not to be necessary, and produces flickering.
8839
8840 2011-03-20 Glenn Morris <rgm@gnu.org>
8841
8842 * config.in: Remove file.
8843
8844 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8845
8846 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8847 are now in src/globals.h.
8848 (syms_of_minibuf): Remove spurious & from previous change.
8849
8850 2011-03-20 Leo Liu <sdl.web@gmail.com>
8851
8852 * minibuf.c (completing-read-function): New variable.
8853 (completing-read-default): Rename from completing-read.
8854 (completing-read): Call completing-read-function.
8855
8856 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8857
8858 * xfaces.c (Fx_load_color_file):
8859 Read color file from absolute filename (bug#8250).
8860
8861 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8862
8863 * makefile.w32-in: Update dependencies.
8864
8865 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8866
8867 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8868
8869 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8870
8871 Fix more problems found by GCC 4.5.2's static checks.
8872
8873 * process.c (make_serial_process_unwind, send_process_trap):
8874 (sigchld_handler): Now static.
8875
8876 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8877 That way, the code declares only the vars that it needs.
8878 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8879 * s/cygwin.h (PTY_ITERATION): Likewise.
8880 * s/darwin.h (PTY_ITERATION): Likewise.
8881 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8882
8883 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8884 * process.c (allocate_pty): Don't declare stb unless it's needed.
8885
8886 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8887 (CONSTANTLIM): Remove; unused.
8888 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8889 Define only if needed.
8890
8891 * unexelf.c (unexec): Name an expression,
8892 to avoid gcc -Wbad-function-cast warning.
8893 Use a different way to cause a compilation error if anyone uses
8894 n rather than nn, a way that does not involve shadowing.
8895 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8896
8897 * deps.mk (unexalpha.o): Remove; unused.
8898
8899 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8900 * unexec.h: New file.
8901 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8902 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8903 Depend on unexec.h.
8904 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8905 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8906 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8907 Change as necessary to match prototype in unexec.h.
8908
8909 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8910 shadowing.
8911 (back_comment, skip_chars): Mark vars as initialized.
8912
8913 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8914 Rename locals to avoid shadowing.
8915
8916 * lread.c (read1): Rewrite so as not to use empty "else".
8917 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8918
8919 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8920
8921 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8922 warning when compiling print.c.
8923
8924 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8925 instead of using an uninitialized var.
8926 (font_sort_entities): Mark var as initialized.
8927
8928 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8929
8930 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8931 pointers to constants.
8932 (font_parse_fcname): Remove unused vars.
8933 (font_delete_unmatched): Now static.
8934 (font_get_spec): Remove; unused.
8935 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8936 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8937 Rename or move locals to avoid shadowing.
8938
8939 * fns.c (require_nesting_list, require_unwind): Now static.
8940 (Ffillarray): Rename locals to avoid shadowing.
8941
8942 * floatfns.c (domain_error2): Define only if needed.
8943 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8944
8945 * alloc.c (mark_backtrace): Move decl from here ...
8946 * lisp.h: ... to here, so that it can be checked.
8947
8948 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8949 (Fdefvar): Rewrite so as not to use empty "else".
8950 (lisp_indirect_variable): Name an expression,
8951 to avoid gcc -Wbad-function-cast warning.
8952 (Fdefvar): Rename locals to avoid shadowing.
8953
8954 * callint.c (quotify_arg, quotify_args): Now static.
8955 (Fcall_interactively): Rename locals to avoid shadowing.
8956 Use const pointer when appropriate.
8957
8958 * lisp.h (get_system_name, get_operating_system_release):
8959 Move decls here, to check interfaces.
8960 * process.c (get_operating_system_release): Move decl to lisp.h.
8961 * xrdb.c (get_system_name): Likewise.
8962 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8963 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8964 some of which prompt warnings from gcc -Wbad-function-cast.
8965 (Fformat_time_string, Fencode_time, Finsert_char):
8966 (Ftranslate_region_internal, Fformat):
8967 Rename or remove local vars to avoid shadowing.
8968 (Ftranslate_region_internal): Mark var as initialized.
8969
8970 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8971 avoid shadowing.
8972
8973 * lisp.h (eassert): Check that the argument compiles, even if
8974 ENABLE_CHECKING is not defined.
8975
8976 * data.c (Findirect_variable): Name an expression, to avoid
8977 gcc -Wbad-function-cast warning.
8978 (default_value, arithcompare, arith_driver, arith_error): Now static.
8979 (store_symval_forwarding): Rename local to avoid shadowing.
8980 (Fmake_variable_buffer_local, Fmake_local_variable):
8981 Mark variables as initialized.
8982 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8983
8984 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8985 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8986 Rename locals to avoid shadowing.
8987 (mark_stack): Move local variables into the #ifdef region where
8988 they're used.
8989 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8990 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8991 needed otherwise.
8992 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8993 (GC_STRING_CHARS): Remove; not used.
8994 (Fmemory_limit): Cast sbrk's returned value to char *.
8995
8996 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8997 avoids undefined behavior in theory.
8998
8999 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9000
9001 Use functions, not macros, for up- and down-casing (Bug#8254).
9002 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9003 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9004 to use the following functions instead of these macros.
9005 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9006 EMACS_INT, since callers assume the returned value fits in int.
9007 (upcase1): Likewise, for UPCASE_TABLE.
9008 (uppercasep, lowercasep, upcase): New static inline functions.
9009 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9010 the race-condition problem in the old DOWNCASE.
9011
9012 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9013 Rename locals to avoid shadowing.
9014 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9015 (regex_compile, re_search_2, re_match_2_internal):
9016 Remove unused local vars.
9017 (FREE_VAR): Rewrite so as not to use empty "else",
9018 which gcc can warn about.
9019 (regex_compile, re_match_2_internal): Mark locals as initialized.
9020 (RETALLOC_IF): Define only if needed.
9021 (WORDCHAR_P): Likewise. This one is never needed, but is used
9022 only in a comment talking about a compiler bug, so put inside
9023 the #if 0 of that comment.
9024 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9025 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9026 Remove; unused.
9027
9028 * search.c (boyer_moore): Rename locals to avoid shadowing.
9029 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9030 (PREV_CHAR_BOUNDARY): Likewise.
9031
9032 * search.c (simple_search): Remove unused var.
9033
9034 * dired.c (compile_pattern): Move decl from here ...
9035 * lisp.h: ... to here, so that it can be checked.
9036 (struct re_registers): New forward decl.
9037
9038 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9039
9040 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9041 All uses changed.
9042 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9043 Rename locals to avoid shadowing.
9044 (Fvertical_motion): Mark locals as initialized.
9045
9046 * casefiddle.c (casify_object, casify_region): Now static.
9047 (casify_region): Mark local as initialized.
9048
9049 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9050
9051 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9052 New macros, so that the caller can use some names other than
9053 gcpro1, gcpro2, etc.
9054 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9055 of the new macros.
9056 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9057 argument, for consistency with GCPRO2_VAR, etc: it is now the
9058 prefix of the variable, not the variable itself. All uses
9059 changed.
9060 * dired.c (directory_files_internal, file_name_completion):
9061 Rename locals to avoid shadowing.
9062
9063 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9064 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9065 dired.c's scmp function, had undefined behavior.
9066 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9067 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9068 * buffer.h: ... to here, because these macros use current_buffer,
9069 and the new implementation with inline functions needs to have
9070 current_buffer in scope now, rather than later when the macros
9071 are used.
9072 (downcase, upcase1): New static inline functions.
9073 (DOWNCASE, UPCASE1): Reimplement using these functions.
9074 This avoids undefined behavior in expressions like
9075 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9076 from race conditions in accessing the global variables
9077 case_temp1 and case_temp2.
9078 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9079 * lisp.h (case_temp1, case_temp2): Remove their decls.
9080 * character.h (ASCII_CHAR_P): Move from here ...
9081 * lisp.h: ... to here, so that the inline functions mentioned
9082 above can use them.
9083
9084 * dired.c (directory_files_internal_unwind): Now static.
9085
9086 * fileio.c (file_name_as_directory, directory_file_name):
9087 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9088 Now static.
9089 (file_name_as_directory): Use const pointers when appropriate.
9090 (Fexpand_file_name): Likewise. In particular, newdir might
9091 point at constant storage, so make it a const pointer.
9092 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9093 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9094 signedness issues.
9095 (Fset_file_times, Finsert_file_contents, auto_save_error):
9096 Rename locals to avoid shadowing.
9097
9098 * minibuf.c (choose_minibuf_frame_1): Now static.
9099 (Ftry_completion, Fall_completions): Rename or remove locals
9100 to avoid shadowing.
9101
9102 * marker.c (bytepos_to_charpos): Remove; unused.
9103
9104 * lisp.h (verify_bytepos, count_markers): New decls,
9105 so that gcc does not warn that these functions aren't declared.
9106
9107 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9108 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9109 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9110 (copy_text): Remove unused local var.
9111
9112 * filelock.c (within_one_second): Now static.
9113 (lock_file_1): Rename local to avoid shadowing.
9114
9115 * buffer.c (fix_overlays_before): Mark locals as initialized.
9116 (fix_start_end_in_overlays): Likewise. This function should be
9117 simplified by using pointers-to-pointers, but that's a different
9118 matter.
9119 (switch_to_buffer_1): Now static.
9120 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9121 (report_overlay_modification): Rename locals to avoid shadowing.
9122
9123 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9124 Fix pointer signedness issue.
9125 (sys_subshell): Mark local as volatile if checking for lint,
9126 to suppress a gcc -Wclobbered warning that does not seem to be right.
9127 (MAXPATHLEN): Define only if needed.
9128
9129 * process.c (serial_open, serial_configure): Move decls from here ...
9130 * systty.h: ... to here, so that they can be checked.
9131
9132 * fns.c (get_random, seed_random): Move extern decls from here ...
9133 * lisp.h: ... to here, so that they can be checked.
9134
9135 * sysdep.c (reset_io): Now static.
9136 (wait_for_termination_signal): Remove; unused.
9137
9138 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9139 (copy_keymap_item, append_key, push_text_char_description):
9140 Now static.
9141 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9142 (DENSE_TABLE_SIZE): Remove; unused.
9143 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9144 (describe_map_tree):
9145 Rename locals to avoid shadowing.
9146
9147 * keyboard.c: Declare functions static if they are not used elsewhere.
9148 (echo_char, echo_dash, cmd_error, top_level_2):
9149 (poll_for_input, handle_async_input): Now static.
9150 (read_char, kbd_buffer_get_event, make_lispy_position):
9151 (make_lispy_event, make_lispy_movement, apply_modifiers):
9152 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9153 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9154 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9155 (read_key_sequence, read_char): Mark locals as initialized.
9156 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9157
9158 * keyboard.h (make_ctrl_char): New decl.
9159 (mark_kboards): Move decl here ...
9160 * alloc.c (mark_kboards): ... from here.
9161
9162 * lisp.h (force_auto_save_soon): New decl.
9163
9164 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9165 (DEFINE_DUMMY_FUNCTION): New macro.
9166 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9167 Use it.
9168 (main): Add casts to avoid warnings
9169 if GCC considers string literals to be constants.
9170
9171 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9172
9173 * dbusbind.c: Pointer signedness fixes.
9174 (xd_signature, xd_append_arg, xd_initialize):
9175 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9176 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9177 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9178 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9179
9180 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9181 if GCC considers string literals to be constants.
9182 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9183
9184 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9185
9186 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9187 (print_preprocess, print_object): New macro to fix last change.
9188
9189 * print.c (print_preprocess): Don't forget font objects.
9190
9191 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9192
9193 * emacs.c (USAGE3): Doc fixes.
9194
9195 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9196
9197 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9198 structure.
9199
9200 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9201
9202 * lisp.h (VWindow_system, Qfile_name_history):
9203 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9204 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9205 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9206
9207 * w32select.c: Don't #include "keyboard.h".
9208 (run_protected): Add extern declaration for waiting_for_input.
9209
9210 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9211 * w32console.c (detect_input_pending, read_input_pending)
9212 (encode_terminal_code):
9213 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9214 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9215 (w32_system_caret_y, Qfile_name_history):
9216 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9217 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9218 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9219 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9220 * w32proc.c (Qlocal, report_file_error):
9221 * w32term.c (Vwindow_system, updating_frame):
9222 * w32uniscribe.c (initialized, uniscribe_font_driver):
9223 Remove unneeded extern declarations.
9224
9225 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9226
9227 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9228
9229 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9230
9231 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9232 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9233 These macros can no longer be used for assignment.
9234
9235 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9236 Assign struct members directly, instead of using BUF_BEGV etc.
9237 (record_buffer_markers, fetch_buffer_markers): New functions for
9238 recording and fetching special buffer markers.
9239 (set_buffer_internal_1, set_buffer_temp): Use them.
9240
9241 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9242
9243 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9244
9245 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9246 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9247
9248 * xdisp.c (hscroll_window_tree):
9249 (reconsider_clip_changes): Use PT instead of BUF_PT.
9250
9251 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9252
9253 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9254 $(EMACS_ROOT)/lib/intprops.h.
9255
9256 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9257
9258 Fix more problems found by GCC 4.5.2's static checks.
9259
9260 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9261 to unsigned char * to avoid compiler diagnostic.
9262 (xg_free_frame_widgets): Make it clear that a local variable is
9263 needed only if USE_GTK_TOOLTIP.
9264 (gdk_window_get_screen): Make it clear that this macro is needed
9265 only if USE_GTK_TOOLTIP.
9266 (int_gtk_range_get_value): New function, which avoids a diagnostic
9267 from gcc -Wbad-function-cast.
9268 (xg_set_toolkit_scroll_bar_thumb): Use it.
9269 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9270 diagnostic from gcc -Wbad-function-cast.
9271 (get_utf8_string, xg_get_file_with_chooser):
9272 Rename locals to avoid shadowing.
9273 (create_dialog): Move locals to avoid shadowing.
9274
9275 * xgselect.c (xg_select): Remove unused var.
9276
9277 * image.c (four_corners_best): Mark locals as initialized.
9278 (gif_load): Initialize transparent_p to zero (Bug#8238).
9279 Mark another local as initialized.
9280 (my_png_error, my_error_exit): Mark with NO_RETURN.
9281
9282 * image.c (clear_image_cache): Now static.
9283 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9284 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9285 (x_edge_detection): Remove unnecessary cast that
9286 gcc -Wbad-function-cast diagnoses.
9287 (gif_load): Fix pointer signedness.
9288 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9289 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9290
9291 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9292
9293 Improve quality of tests for time stamp overflow.
9294 For example, without this patch (encode-time 0 0 0 1 1
9295 1152921504606846976) returns the obviously-bogus value (-948597
9296 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9297 reports time overflow. See
9298 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9299 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9300 * editfns.c: Include limits.h and intprops.h.
9301 (TIME_T_MIN, TIME_T_MAX): New macros.
9302 (time_overflow): Move earlier, to before first use.
9303 (hi_time, lo_time): New functions, for an accurate test for
9304 out-of-range times.
9305 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9306 (Fget_internal_run_time): Don't assume time_t fits in int.
9307 (make_time): Use list2 instead of Fcons twice.
9308 (Fdecode_time): More accurate test for out-of-range times.
9309 (check_tm_member): New function.
9310 (Fencode_time): Use it, to test for out-of-range times.
9311 (lisp_time_argument): Don't rely on undefined left-shift and
9312 right-shift behavior when checking for time stamp overflow.
9313
9314 * editfns.c (time_overflow): New function, refactoring common code.
9315 (Fformat_time_string, Fdecode_time, Fencode_time):
9316 (Fcurrent_time_string): Use it.
9317
9318 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9319 * dired.c (make_time): Move to ...
9320 * editfns.c (make_time): ... here.
9321 * systime.h: Note the move.
9322
9323 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9324
9325 * fringe.c (update_window_fringes): Remove unused variables.
9326
9327 * unexmacosx.c (copy_data_segment): Also copy __got section.
9328 (Bug#8223)
9329
9330 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9331
9332 * termcap.c [MSDOS]: Include "msdos.h".
9333 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9334 Constify `char *' arguments and their references according to
9335 prototypes in tparam.h.
9336
9337 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9338
9339 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9340 Adapt all references accordingly.
9341
9342 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9343
9344 2011-03-11 Tom Tromey <tromey@redhat.com>
9345
9346 * buffer.c (syms_of_buffer): Remove obsolete comment.
9347
9348 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9349
9350 * termhooks.h (encode_terminal_code): Declare prototype.
9351
9352 * msdos.c (encode_terminal_code): Don't declare prototype.
9353
9354 * term.c (encode_terminal_code): Now external again, used by
9355 w32console.c and msdos.c.
9356
9357 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9358 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9359
9360 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9361
9362 Fix some minor problems found by GCC 4.5.2's static checks.
9363
9364 * fringe.c (update_window_fringes): Mark locals as initialized
9365 (Bug#8227).
9366 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9367
9368 * alloc.c (mark_fringe_data): Move decl from here ...
9369 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9370 to check its interface.
9371 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9372
9373 * fontset.c (free_realized_fontset): Now static.
9374 (Fset_fontset_font): Rename local to avoid shadowing.
9375 (fontset_font): Mark local as initialized.
9376 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9377
9378 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9379
9380 * xselect.c (x_disown_buffer_selections): Remove; not used.
9381 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9382 (x_own_selection, Fx_disown_selection_internal): Rename locals
9383 to avoid shadowing.
9384 (x_handle_dnd_message): Remove local to avoid shadowing.
9385
9386 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9387 so that the caller can use some name other than gcpro1.
9388 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9389 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9390 (Fx_backspace_delete_keys_p):
9391 Use them to avoid shadowing, and rename vars to avoid shadowing.
9392 (x_decode_color, x_set_name, x_window): Now static.
9393 (Fx_create_frame): Add braces to silence GCC warning.
9394 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9395 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9396 Remove unused locals.
9397 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9398 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9399 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9400 macros.
9401
9402 * xterm.h (x_mouse_leave): New decl.
9403
9404 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9405 Remove unused functions.
9406 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9407 (x_calc_absolute_position): Now static.
9408 (XTread_socket): Don't define label "out" unless it's used.
9409 Don't declare local "event" unless it's used.
9410 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9411 unless they are used.
9412 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9413 (x_fatal_error_signal): Remove; not used.
9414 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9415 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9416 (x_error_catcher, x_connection_closed, x_error_handler):
9417 (x_error_quitter, xembed_send_message, x_iconify_frame):
9418 (my_log_handler): Rename locals to avoid shadowing.
9419 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9420 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9421
9422 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9423 Rename or move locals to avoid shadowing.
9424 (tty_defined_color, merge_face_heights): Now static.
9425 (free_realized_faces_for_fontset): Remove; not used.
9426 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9427 does not deduce is never used uninitialized.
9428 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9429 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9430
9431 * terminal.c (store_terminal_param): Now static.
9432
9433 * xmenu.c (menu_highlight_callback): Now static.
9434 (set_frame_menubar): Remove unused local.
9435 (xmenu_show): Rename parameter to avoid shadowing.
9436 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9437 since they might point to immutable storage.
9438 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9439 since it's unused otherwise.
9440
9441 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9442 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9443 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9444 avoids a gcc -Wuninitialized diagnostic.
9445 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9446 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9447 does not deduce are never used uninitialized.
9448
9449 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9450
9451 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9452 * window.c (window_loop, size_window):
9453 (run_window_configuration_change_hook, enlarge_window): Likewise.
9454
9455 * window.c (display_buffer): Now static.
9456 (size_window): Mark variables that gcc -Wuninitialized
9457 does not deduce are never used uninitialized.
9458 * window.h (check_all_windows): New decl, to forestall
9459 gcc -Wmissing-prototypes diagnostic.
9460 * dispextern.h (bidi_dump_cached_states): Likewise.
9461
9462 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9463 shadowing.
9464 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9465 Include <limits.h>.
9466 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9467 and to avoid gcc -Wuninitialized warning.
9468 (load_charset_map): Mark variables that gcc -Wuninitialized
9469 does not deduce are never used uninitialized.
9470 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9471
9472 * coding.c (coding_set_source, coding_set_destination):
9473 Use "else { /* comment */ }" rather than "else /* comment */;"
9474 for clarity, and to avoid gcc -Wempty-body warning.
9475 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9476 a block, when the outer 'i' will do.
9477 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9478 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9479 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9480 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9481 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9482 Rename locals to avoid shadowing.
9483 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9484 * coding.c (emacs_mule_char, encode_invocation_designation):
9485 Now static, since they're not used elsewhere.
9486 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9487 (decode_coding_object, encode_coding_object, detect_coding_system):
9488 (decode_coding_emacs_mule): Mark variables that gcc
9489 -Wuninitialized does not deduce are never used uninitialized.
9490 (detect_coding_iso_2022): Initialize a local variable that might
9491 be used uninitialized. Leave a FIXME because it's not clear that
9492 this initialization is needed. (Bug#8211)
9493 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9494 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9495 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9496 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9497 Remove unused macros.
9498
9499 * category.c (hash_get_category_set): Remove unused local var.
9500 (copy_category_table): Now static, since it's not used elsewhere.
9501 * character.c (string_count_byte8): Likewise.
9502
9503 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9504 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9505
9506 * chartab.c (copy_sub_char_table): Now static, since it's not used
9507 elsewhere.
9508 (sub_char_table_ref_and_range, char_table_ref_and_range):
9509 Rename locals to avoid shadowing.
9510 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9511
9512 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9513 (BIDI_BOB): Remove unused macro.
9514
9515 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9516 deduce are never used uninitialized.
9517 * term.c (encode_terminal_code): Likewise.
9518
9519 * term.c (encode_terminal_code): Now static. Remove unused local.
9520
9521 * tparam.h: New file.
9522 * term.c, tparam.h: Include it.
9523 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9524 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9525 Move these decls to tparam.h, and make them agree with what
9526 is actually in tparam.c. The previous trick of using incompatible
9527 decls in different modules does not conform to the C standard.
9528 All callers of tparam changed to use tparam's actual API.
9529 * tparam.c (tparam1, tparam, tgoto):
9530 Use const pointers where appropriate.
9531
9532 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9533 * cm.h (struct cm): Likewise.
9534 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9535 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9536 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9537 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9538 (turn_on_face, init_tty): Likewise.
9539 * termchar.h (struct tty_display_info): Likewise.
9540
9541 * term.c (term_mouse_position): Rename local to avoid shadowing.
9542
9543 * alloc.c (mark_ttys): Move decl from here ...
9544 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9545
9546 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9547
9548 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9549
9550 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9551
9552 * search.c (compile_pattern_1): Remove argument regp, unused since
9553 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9554 (compile_pattern): Don't pass it.
9555
9556 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9557
9558 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9559 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9560 for ! HAVE_GTK3.
9561 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9562
9563 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9564
9565 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9566 gdk_window_get_screen, gdk_window_get_geometry,
9567 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9568 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9569 (xg_get_pixbuf_from_pixmap): New function.
9570 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9571 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9572 Call xg_get_pixbuf_from_pixmap instead of
9573 gdk_pixbuf_get_from_drawable.
9574 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9575 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9576 (xg_check_special_colors): Use GtkStyleContext and its functions
9577 for HAVE_GTK3.
9578 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9579 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9580 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9581 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9582 Call gtk_widget_get_preferred_size.
9583 (xg_frame_resized): gdk_window_get_geometry only takes 5
9584 parameters.
9585 (xg_win_to_widget, xg_event_is_for_menubar):
9586 Call gdk_x11_window_lookup_for_display.
9587 (xg_set_widget_bg): New function.
9588 (delete_cb): New function.
9589 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9590 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9591 (xg_set_background_color): Call xg_set_widget_bg.
9592 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9593 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9594 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9595 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9596 if ! HAVE_GTK3.
9597 (update_frame_tool_bar): Call gtk_widget_hide.
9598 (xg_initialize): Use GDK_KEY_g.
9599
9600 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9601 if ! HAVE_GTK3
9602 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9603
9604 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9605 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9606 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9607
9608 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9609
9610 * w32xfns.c (select_palette): Check success of RealizePalette against
9611 GDI_ERROR, not zero.
9612
9613 See ChangeLog.11 for earlier changes.
9614
9615 ;; Local Variables:
9616 ;; coding: utf-8
9617 ;; End:
9618
9619 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9620
9621 This file is part of GNU Emacs.
9622
9623 GNU Emacs is free software: you can redistribute it and/or modify
9624 it under the terms of the GNU General Public License as published by
9625 the Free Software Foundation, either version 3 of the License, or
9626 (at your option) any later version.
9627
9628 GNU Emacs is distributed in the hope that it will be useful,
9629 but WITHOUT ANY WARRANTY; without even the implied warranty of
9630 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9631 GNU General Public License for more details.
9632
9633 You should have received a copy of the GNU General Public License
9634 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.