1 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
3 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
4 enabled with --enable-checking=[all,glyphs] configure option.
5 Fix GLYPH_DEBUG usage assuming that it may be undefined,
6 adjust comments accordingly.
7 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
8 undefined, adjust comments accordingly.
12 * w32term.c: Likewise.
18 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
20 Generalize run-time debugging checks.
21 * dispextern.h (XASSERTS): Remove.
22 * fontset.c (xassert): Remove.
23 Convert from xassert to eassert.
24 * alloc.c: Convert from xassert to eassert.
26 * dispnew.c: Likewise.
30 * gtkutil.c: Likewise.
32 * keyboard.c: Likewise.
34 * process.c: Likewise.
38 * w32console.c: Likewise.
40 * w32term.c: Likewise.
45 * xselect.c: Likewise.
48 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
50 * fns.c (maybe_resize_hash_table): Output message when growing the
53 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
55 * alloc.c (allocate_string_data): Remove dead code.
56 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
57 avoid GCC warning about unused macro.
59 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
61 * alloc.c (allocate_string): Omit intervals initialization.
62 * alloc.c (make_uninit_multibyte_string): Initialize intervals
63 as in make_pure_string and make_pure_c_string.
65 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
67 * alloc.c (allocate_string): Fix last change.
69 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
71 * alloc.c (allocate_string): Remove two redundant calls
72 to memset, add explicit initialization where appropriate.
74 2012-06-27 Glenn Morris <rgm@gnu.org>
76 * lisp.mk (lisp): Remove paths.elc.
78 2012-06-27 Chong Yidong <cyd@gnu.org>
80 * doc.c (Fsubstitute_command_keys): Fix punctuation.
82 2012-06-26 John Wiegley <johnw@newartisans.com>
84 * unexmacosx.c (copy_data_segment): Add two section names used
85 on Mac OS X Lion: __mod_init_func and __mod_term_func.
87 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
88 when building with Clang.
90 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
92 * eval.c (Fapply): Allow calling it with a single argument.
94 2012-06-26 Eli Zaretskii <eliz@gnu.org>
96 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
97 _stricmp and _strnicmp.
98 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
100 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
102 * alloc.c (allocate_window): Zero out non-Lisp part of newly
104 (allocate_process): Likewise for new process.
105 (allocate_terminal): Change to use offsetof.
106 (allocate_frame): Likewise.
107 * frame.c (make_frame): Omit redundant initialization.
108 * window.c (make_parent_window): Use memset.
109 (make_window): Omit redundant initialization.
110 * process.c (make_process): Omit redundant initialization.
111 * terminal.c (create_terminal): Likewise.
113 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
115 * term.c (delete_tty): Remove redundant call to memset.
117 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
119 * alloc.c: Remove build_string.
120 * lisp.h: Define build_string as static inline. This provides
121 a better opportunity to optimize away calls to strlen when the
122 function is called with compile-time constant argument.
123 * image.c (imagemagick_error): Convert to build_string.
124 * w32proc.c (sys_spawnve): Likewise.
125 * xterm.c (x_term_init): Likewise.
127 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
129 Use sprintf return value instead of invoking strlen on result.
130 In the old days this wasn't portable, since some sprintf
131 implementations returned char *. But they died out years ago and
132 Emacs already assumes sprintf returns int.
133 Similarly for float_to_string.
134 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
135 * ccl.c (ccl_driver):
136 * character.c (string_escape_byte8):
137 * data.c (Fnumber_to_string):
139 * print.c (print_object):
140 * xdisp.c (message_dolog):
141 * xfns.c (syms_of_xfns):
142 Use sprintf or float_to_string result to avoid need to call strlen.
143 * data.c (Fnumber_to_string):
144 Use make_unibyte_string, since the string must be ASCII.
145 * lisp.h, print.c (float_to_string): Now returns int length.
146 * term.c (produce_glyphless_glyph):
147 Use sprintf result rather than recomputing it.
149 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
150 * Makefile.in (ALL_CFLAGS):
151 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
152 * gmalloc.c, regex.c: Include <config.h> unconditionally.
154 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
156 * dispextern.h (xstrcasecmp): Define to library function
157 strcasecmp if available.
158 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
160 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
162 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
163 Avoid comma operator.
164 * menu.c (push_submenu_start, push_submenu_end)
165 (push_left_right_boundary, push_menu_pane): Likewise.
166 * msdos.c (dos_rawgetc): Likewise.
168 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
170 * xfns.c (xic_create_fontsetname): Remove redundant calls
173 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
175 * gtkutil.c (get_utf8_string): Remove redundant assignment.
176 sprintf already null-terminates its output.
178 * xfns.c (x_window): Remove redundant cast.
180 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
182 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
183 `const char *' to `char *' to avoid compiler warning.
185 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
187 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
188 instead of truncating it to 63 (admittedly a generous limit).
190 * process.c: Fix spelling and caps in comments.
192 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
194 * emacs.c (setpgrp): Remove definition, unused.
195 * sysdep.c (setpgrp): Remove definition, not used in this file.
197 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
199 * makefile.w32-in: Update dependencies.
201 2012-06-24 Eli Zaretskii <eliz@gnu.org>
203 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
204 (SYSTIME_H): Add nt/inc/sys/time.h.
206 * systime.h [WINDOWSNT]: Include sys/time.h.
208 * s/ms-w32.h (struct timespec): Definition moved from
209 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
211 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
213 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
214 * buffer.h (buffer_slot_type_mismatch):
215 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
216 * eval.c (unwind_to_catch):
217 * image.c (my_png_error, my_error_exit):
218 * keyboard.c (quit_throw_to_read_char, user_error)
219 (Fexit_recursive_edit, Fabort_recursive_edit):
220 * lisp.h (die, args_out_of_range, args_out_of_range_3)
221 (wrong_type_argument, buffer_overflow, __executable_start)
222 (memory_full, buffer_memory_full, string_overflow, Fthrow)
223 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
224 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
226 (child_setup) [!DOS_NT]:
227 * lread.c (end_of_file_error, invalid_syntax):
228 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
229 * puresize.h (pure_write_error):
230 * search.c (matcher_overflow):
231 * sound.c (sound_perror, alsa_sound_perror):
232 * sysdep.c, syssignal.h (croak):
233 * term.c (maybe_fatal, vfatal):
234 * textprop.c (text_read_only):
235 * undo.c (user_error):
236 * unexmacosx.c (unexec_error):
237 * xterm.c (x_ins_del_lines, x_delete_glyphs):
238 Use _Noreturn rather than NO_RETURN.
239 No need for separate decl merely because of _Noreturn.
240 * sound.c (sound_warning, parse_sound):
241 Remove unnecessary forward decls.
243 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
245 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
246 * lisp.h (WAIT_READING_MAX): New macro.
247 * dispnew.c (Fsleep_for, sit_for):
248 * keyboard.c (kbd_buffer_get_event):
249 * process.c (Faccept_process_output):
250 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
251 This improves on the previous patch, which introduced a bug
252 when time_t is unsigned and as wide as intmax_t.
253 See <http://bugs.gnu.org/9000#51>.
255 2012-06-23 Eli Zaretskii <eliz@gnu.org>
257 * dispnew.c (sit_for, Fsleep_for):
258 * keyboard.c (kbd_buffer_get_event):
259 * process.c (Faccept_process_output): Avoid compiler warnings when
260 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
262 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
264 * makefile.w32-in: Update dependencies.
266 * w32.c (ltime): Add return type and declare static.
267 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
269 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
271 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
272 Privately reported by Herbert J. Skuhra.
273 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
275 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
276 not make_lisp_timeval, when the argument is of type EMACS_TIME.
278 2012-06-23 Eli Zaretskii <eliz@gnu.org>
280 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
281 last argument of make_unibyte_string.
283 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
284 language ID in the event parameters.
286 * w32term.c (w32_read_socket): Put the new keyboard codepage into
287 event.code, not the obscure "character set ID".
289 2012-06-23 Chong Yidong <cyd@gnu.org>
291 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
293 2012-06-23 Eli Zaretskii <eliz@gnu.org>
295 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
296 * w32.c (fdutimens): New function.
298 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
300 * s/ms-w32.h (pselect): Redirect to sys_select.
302 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
304 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
305 in the logic of incrementing and decrementing the value of
306 use_relocatable_buffers.
308 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
310 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
311 Privately reported by Herbert J. Skuhra.
312 [__FreeBSD__]: Remove "*/" typo after "#include".
313 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
314 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
315 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
316 Don't assume EMACS_TIME and struct timeval are the same type.
318 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
320 Support higher-resolution time stamps (Bug#9000).
321 The time stamps are only nanosecond-resolution at the C level,
322 since that's the best that any real-world system supports now.
323 But they are picosecond-resolution at the Lisp level, as that's
324 easy, and leaves room for future OS improvements.
326 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
329 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
330 Don't get current time unless it's needed.
332 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
333 now provides it if it's absent.
334 (start_atimer): Port to higher-res time stamps.
335 Check for time stamp overflow. Don't get current time more
336 often than is needed.
338 * buffer.h (struct buffer): Buffer modtime now has high resolution.
339 Include systime.h, not time.h.
340 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
342 * dired.c: Include stat-time.h.
343 (Ffile-attributes): File times now have higher resolution.
345 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
346 (struct image): Timestamp now has higher resolution.
348 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
349 has at least microseconds now. All uses removed.
350 (update_frame, update_single_window, update_window, update_frame_1)
351 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
353 * editfns.c (time_overflow): Now extern.
354 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
355 (float-time, Fformat_time_string, Fcurrent_time_string)
356 (Fcurrent_time_zone): Accept and generate higher-resolution
358 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
359 (decode_time_components, lisp_seconds_argument): New functions.
360 (make_time): Now static.
361 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
362 Report an error if the time is invalid, rather than having the caller
365 * fileio.c: Include <stat-time.h>
366 (Fcopy_file): Copy higher-resolution time stamps.
367 Prefer to set the time stamp via a file descriptor if that works.
368 (Fset_file_times, Finsert_file_contents, Fwrite_region)
369 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
370 (Fvisited_file_modtime, Fset_visited_file_modtime):
371 Support higher-resolution time stamps.
373 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
375 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
377 * image.c (prepare_image_for_display, clear_image_cache)
378 (lookup_image): Port to higer-resolution time stamps.
380 * keyboard.c (start_polling, bind_polling_period):
381 Check for time stamp overflow.
382 (read_char, kbd_buffer_get_event, timer_start_idle)
383 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
384 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
385 Port to higher-resolution time stamps. Do not assume time_t is signed.
386 (decode_timer): New function. Timers are now vectors of length 9,
387 not 8, to accommodate the picosecond component.
388 (timer_check_2): Use it.
390 * nsterm.m (select_timeout, timeval_subtract): Remove.
391 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
392 as they're a bit more accurate and handle overflow better.
393 (ns_select): Change prototype to be compatible with pselect.
394 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
395 * nsterm.h (ns_select): Adjust prototype.
397 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
398 us-resolution time stamps.
399 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
401 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
403 * lisp.h (time_overflow): New decl.
404 (wait_reading_process_output): First arg is now intmax_t, not int,
405 to accommodate larger waits.
407 * process.h (struct Lisp_Process.read_output_delay):
408 Now counts nanoseconds, not microseconds.
409 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
411 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
412 (wait_reading_process_output):
413 Port to ns-resolution time stamps.
414 (Faccept_process_output, wait_reading_process_output):
415 Check for time stamp overflow. Do not assume time_t is signed.
416 (select_wrapper): Remove; we now use pselect.
417 (Fprocess_attributes): Now generates ns-resolution time stamps.
419 * sysdep.c: Include utimens.h. Don't include utime.h
420 or worry about struct utimbuf; gnulib does that for us now.
421 (gettimeofday): Remove; gnulib provides a substitute.
422 (make_timeval): New function.
423 (set_file_times): Now sets ns-resolution time stamps.
424 New arg FD; all uses changed.
425 (time_from_jiffies, ltime_from_jiffies, get_up_time)
426 (system_process_attributes):
427 Now returns ns-resolution time stamp. All uses changed.
428 Check for time stamp overflow.
430 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
431 provides a substitute now.
433 * systime.h: Include timespec.h rather than sys/time.h and time.h,
434 since it guarantees struct timespec.
435 (EMACS_TIME): Now struct timespec, so that we can support
436 ns-resolution time stamps.
437 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
438 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
439 (EMACS_USECS): Remove.
440 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
441 so multiply the arg by 1000 before storing it.
442 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
444 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
445 Port to ns-resolution time stamps.
446 (EMACS_TIME_NEG_P): Remove; replaced by....
447 (EMACS_TIME_SIGN): New macro.
448 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
449 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
450 (set_file_times, make_time, lisp_time_argument): Adjust signature.
451 (make_timeval, make_lisp_time, decode_time_components): New decls.
452 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
453 that it mishandled time_t overflow. You can't compare by subtracting!
454 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
455 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
457 * term.c: Include <sys/time.h>.
458 (timeval_to_Time): New function, for proper overflow wraparound.
459 (term_mouse_position, term_mouse_click): Use it.
461 * undo.c (record_first_change): Support higher-resolution time stamps
463 (Fprimitive_undo): Use them when restoring time stamps.
465 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
466 (w32_get_internal_run_time):
467 Port to higher-resolution Emacs time stamps.
468 (ltime): Now accepts single 64-bit integer, as that's more convenient
471 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
473 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
474 for compatibility with pselect. Support ns-resolution time stamps.
476 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
478 * xselect.c (wait_for_property_change, x_get_foreign_selection):
479 Check for time stamp overflow, and support ns-resolution time stamps.
481 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
482 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
483 (timeval_subtract): Remove; no longer needed.
484 (XTflash, XTring_bell, x_wait_for_event):
485 Port to ns-resolution time stamps. Don't assume time_t is signed.
487 2012-06-22 Chong Yidong <cyd@gnu.org>
489 * xdisp.c (x_consider_frame_title): Revert last change.
491 2012-06-22 Eli Zaretskii <eliz@gnu.org>
493 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
494 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
495 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
496 staticidx goes up to 1597 out of 1600 = 0x640.)
498 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
500 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
501 Otherwise, the umask might be mistakenly 0 while handling input signals.
503 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
505 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
507 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
509 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
510 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
511 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
512 access to `contents' member of Lisp_Vector objects with AREF and ASET
515 2012-06-19 Chong Yidong <cyd@gnu.org>
517 * frame.c (delete_frame): When selecting a frame on a different
518 text terminal, do not alter the terminal's top-frame.
520 * xdisp.c (format_mode_line_unwind_data): Record the target
521 frame's selected window and its terminal's top-frame.
522 (unwind_format_mode_line): Restore them.
523 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
525 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
526 since tty frames can be explicitly named.
527 (prepare_menu_bars): Likewise.
529 * term.c (Ftty_top_frame): New function.
531 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
533 Port byte-code-meter to modern targets.
534 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
535 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
536 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
537 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
538 (METER_1, METER_2): Simplify.
540 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
542 * data.c (Fdefalias): Return `symbol' (bug#11686).
544 2012-06-18 Martin Rudalics <rudalics@gmx.at>
546 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
547 gets killed during executing of this function (Bug#11665).
548 Try to always return Qt when the buffer has been actually killed.
549 (Vkill_buffer_query_functions): In doc-string say that functions
550 run by this hook should not change the current buffer.
552 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
554 Fix recently-introduced process.c problems found by static checking.
555 * process.c (write_queue_push, write_queue_pop, send_process):
556 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
557 (write_queue_pop): Fix pointer signedness problem.
558 (send_process): Remove unused local.
560 2012-06-17 Chong Yidong <cyd@gnu.org>
562 * xdisp.c (redisplay_internal): No need to redisplay terminal
563 frames that are not on top.
565 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
567 * process.c (make_process): Initialize write_queue.
568 (write_queue_push, write_queue_pop): New functions.
569 (send_process): Use them to maintain correct ordering of process
572 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
574 * lisp.h (eassert): Assume C89 or later.
575 This removes the need for CHECK.
576 (CHECK): Remove. Its comments about always evaluating its
577 argument were confusing, as 'eassert' typically does not evaluate
580 * coding.c (produce_chars): Use ptrdiff_t, not int.
582 * xterm.c (x_draw_underwave): Check for integer overflow.
583 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
585 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
587 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
588 referenced (Bug#11583).
590 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
592 Implement wave-style variant of underlining.
593 * dispextern.h (face_underline_type): New enum.
594 (face): Add field for underline type.
595 * nsterm.m (ns_draw_underwave): New function.
596 (ns_draw_text_decoration): Use it.
597 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
599 (x_draw_glyph_string): Use them.
600 * xfaces.c (Qline, Qwave): New Lisp objects.
601 (check_lface_attrs, merge_face_ref)
602 (Finternal_set_lisp_face_attribute, realize_x_face):
603 Handle wave-style underline face attributes.
604 * xterm.c (x_draw_underwave): New function.
605 (x_draw_glyph_string): Use it.
607 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
609 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
610 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
611 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
612 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
613 ($(BLD)/w32select.$(O)): Update dependencies.
615 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
617 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
618 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
619 * character.c (_fetch_multibyte_char_p): Remove.
620 * alloc.c: Include "character.h" before "buffer.h".
622 * buffer.c: Likewise.
623 * bytecode.c: Likewise.
624 * callint.c: Likewise.
625 * callproc.c: Likewise.
626 * casefiddle.c: Likewise.
627 * casetab.c: Likewise.
628 * category.c: Likewise.
630 * coding.c: Likewise.
631 * composite.c: Likewise.
633 * dispnew.c: Likewise.
635 * dosfns.c: Likewise.
636 * editfns.c: Likewise.
638 * fileio.c: Likewise.
639 * filelock.c: Likewise.
641 * fontset.c: Likewise.
642 * fringe.c: Likewise.
643 * indent.c: Likewise.
644 * insdel.c: Likewise.
645 * intervals.c: Likewise.
646 * keyboard.c: Likewise.
647 * keymap.c: Likewise.
649 * macros.c: Likewise.
650 * marker.c: Likewise.
651 * minibuf.c: Likewise.
653 * nsmenu.m: Likewise.
655 * process.c: Likewise.
657 * region-cache.c: Likewise.
658 * search.c: Likewise.
659 * syntax.c: Likewise.
661 * textprop.c: Likewise.
663 * unexsol.c: Likewise.
664 * w16select.c: Likewise.
665 * w32fns.c: Likewise.
666 * w32menu.c: Likewise.
667 * window.c: Likewise.
672 * xselect.c: Likewise.
674 2012-06-16 Eli Zaretskii <eliz@gnu.org>
676 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
677 If all the glyphs of the glyph row came from strings, and we have no
678 cursor positioning clues, put the cursor on the first glyph of the
680 (handle_face_prop): Use chunk-relative overlay string index when
681 indexing into it->string_overlays array. (Bug#11653)
682 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
683 the rightmost. (Bug#11720)
685 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
687 * category.h (CHAR_HAS_CATEGORY): Define as inline.
688 (CATEGORY_MEMBER): Enforce 1/0 value.
689 * category.c (_temp_category_set): Remove.
691 2012-06-16 Eli Zaretskii <eliz@gnu.org>
693 * window.c (Fdelete_other_windows_internal)
694 (Fdelete_window_internal): Don't access frame's mouse highlight
695 info of the initial frame. (Bug#11677)
697 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
699 * .gdbinit (xgetint): Fix recently-introduced paren typo.
700 Assume USE_2_TAGS_FOR_INTS.
701 (xreload): Adjust $tagmask width to match recent lisp.h change.
703 Simplify lisp.h in minor ways that should not affect code.
704 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
705 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
706 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
707 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
708 (INTTYPEBITS): New macro, for clarity.
709 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
710 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
711 Simplify now that USE_LSB_TAG is always defined.
712 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
713 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
715 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
717 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
719 2012-06-13 Glenn Morris <rgm@gnu.org>
721 * s/bsd-common.h (BSD4_3):
722 * s/usg5-4-common.h (USG5_4): No longer define; unused.
724 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
726 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
729 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
731 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
732 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
733 * alloc.c (widen_to_Lisp_Object): Remove.
734 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
735 * frame.c (delete_frame): Remove outdated comment.
736 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
738 (Fw32_unregister_hot_key): Likewise.
739 (Fw32_toggle_lock_key): Likewise.
740 * w32menu.c (add_menu_item): Likewise.
741 (w32_menu_display_help): Use XIL instead of checking
743 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
744 (init_heap): Likewise.
745 * w32term.c (w32_read_socket): Update comment.
747 2012-06-13 Glenn Morris <rgm@gnu.org>
749 * s/usg5-4-common.h, src/s/unixware.h:
750 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
752 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
754 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
756 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
757 * alloc.c (make_number) [!defined make_number]:
758 Remove, as lisp.h always defines this now.
759 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
760 (roundup_size): Verify that it is a power of 2.
761 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
762 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
763 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
764 -DUSE_LSB_TAG=0, to override the automatically-selected default.
765 USE_LSB_TAG now is always defined to be either 0 or 1.
767 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
768 code works fine either way, and efficiency is not a concern here,
769 as the union type is for debugging, not for production.
770 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
771 Use an inline function on all platforms when using the union type,
772 since this is simpler and 'static inline' can be used portably
774 (LISP_INITIALLY_ZERO): New macro.
775 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
776 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
778 2012-06-12 Glenn Morris <rgm@gnu.org>
780 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
782 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
784 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
785 Move BROKEN_SIGIO to configure.
787 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
788 Move NO_TERMIO to configure.
790 2012-06-12 Chong Yidong <cyd@gnu.org>
792 * image.c (imagemagick_load_image): Use MagickFlattenImage if
793 MagickMergeImageLayers is undefined. Use pixel pusher loop if
794 MagickExportImagePixels is undefined.
796 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
798 * image.c (imagemagick_load_image): Remove unused label.
800 2012-06-11 Glenn Morris <rgm@gnu.org>
802 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
803 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
804 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
805 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
807 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
809 * alloc.c (make_byte_code): New function.
810 (Fmake_byte_code): Use it. Don't purify here.
811 * lread.c (read1): Use it as well to avoid extra allocation.
813 2012-06-11 Chong Yidong <cyd@gnu.org>
815 * image.c (imagemagick_load_image): Implement transparency.
817 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
819 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
820 account for preceding backslashes. (Bug#11663)
822 2012-06-09 Chong Yidong <cyd@gnu.org>
824 * term.c: Support italics in capable terminals (Bug#9652).
825 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
826 (turn_on_face): Output using TS_enter_italic_mode if available.
827 Don't handle unused blinking and alt-charset cases.
828 (turn_off_face): Handle italic case; discard unused tty_blinking_p
829 and tty_alt_charset_p cases.
830 (tty_capable_p, init_tty): Support italics.
832 * termchar.h (struct tty_display_info): Add field for italics.
833 Remove unused blink field.
835 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
838 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
839 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
840 tty_alt_charset_p. Add tty_italic_p.
842 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
844 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
845 dbus_type_is_basic if available.
846 (xd_extract_signed, xd_extract_unsigned): Rename from
847 extract_signed and extract_unsigned, respectively. Adapt callers.
849 2012-06-09 Chong Yidong <cyd@gnu.org>
851 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
853 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
856 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
858 * xdisp.c (vmessage): Treat frame message as multibyte.
859 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
860 would generate the diagnostic "Making \302\247 buffer-local while
863 2012-06-08 Eli Zaretskii <eliz@gnu.org>
865 * dispnew.c (showing_window_margins_p): Undo last change, which
866 was done due to an inadvertent commit.
867 (adjust_frame_glyphs_for_frame_redisplay): Do call
868 showing_window_margins_p.
870 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
872 * eval.c (Fmake_var_non_special): New primitive.
873 (syms_of_eval): Defsubr it.
874 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
876 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
878 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
879 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
881 2012-06-08 Eli Zaretskii <eliz@gnu.org>
883 * alloc.c (allocate_vectorlike): Fix last change.
885 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
887 Block-based vector allocation of small vectors.
888 * lisp.h (struct vectorlike_header): New field `nbytes',
889 adjust comment accordingly.
890 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
891 to denote vector blocks. Adjust users (live_vector_p,
892 mark_maybe_pointer, valid_lisp_object_p) accordingly.
893 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
894 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
895 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
896 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
897 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
898 (roundup_size): New constant.
899 (struct vector_block): New data type.
900 (vector_blocks, vector_free_lists, zero_vector): New variables.
901 (all_vectors): Rename to `large_vectors'.
902 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
903 (sweep_vectors): New functions.
904 (allocate_vectorlike): Return `zero_vector' as the only vector of
905 0 items. Allocate new vector from block if vector size is less than
906 or equal to VBLOCK_BYTES_MAX.
907 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
908 (init_alloc_once): Add call to init_vectors.
910 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
912 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
914 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
916 * doprnt.c (doprnt): Truncate multibyte char correctly.
917 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
918 would mishandle a string argument "Xc" if X was a multibyte
919 character of length 2: it would truncate after X's first byte
920 rather than including all of X.
922 2012-06-06 Chong Yidong <cyd@gnu.org>
924 * buffer.c (word_wrap): Doc fix.
926 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
928 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
930 2012-06-03 Glenn Morris <rgm@gnu.org>
932 * xdisp.c (tool-bar-style): Doc fix.
934 2012-06-03 Ulrich Müller <ulm@gentoo.org>
936 * Makefile.in (PAXCTL): Define.
937 (temacs$(EXEEXT)): Disable memory randomization for the temacs
938 binary via PaX flags if the paxctl utility is available.
939 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
940 Restore PaX flags to their default. (Bug#11398)
942 2012-06-03 Chong Yidong <cyd@gnu.org>
944 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
947 2012-06-03 Chong Yidong <cyd@gnu.org>
949 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
950 (note_mode_line_or_margin_highlight): If there is no help echo,
951 use mode-line-default-help-echo. Handle the case where the mouse
952 position is past the end of the mode line string.
954 * buffer.c (buffer_local_value_1): New function, split from
955 Fbuffer_local_value; can return Qunbound.
956 (Fbuffer_local_value): Use it.
957 (Vmode_line_format): Docstring tweaks.
959 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
961 * sysdep.c (system_process_attributes): Improve comment.
963 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
965 * keyboard.c: Export real-this-command to Elisp.
966 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
967 and DEFVAR it. Update all users.
969 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
971 * minibuf.c (Fassoc_string): Remove duplicate declaration.
973 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
974 Convert pctcpu and pctmem to Lisp float properly.
975 Let the compiler fold better, as 100.0/0x8000 is exact.
977 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
979 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
982 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
984 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
986 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
988 For a 'struct window', replace some Lisp_Object fields to
989 bitfields where appropriate, remove unused fields.
990 * window.h (struct window): Remove unused 'last_mark_x' and
991 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
992 change it's type from Lisp_Object to bitfield.
993 Change type of 'force_start', 'optional_new_start',
994 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
995 fields from Lisp_Object to bitfield. Adjust users accordingly.
997 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
999 Pacify gcc -Wdouble-precision when using Xaw.
1000 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1001 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1002 Use 'float' consistently, rather than 'float' in most places
1003 and 'double' in a couple of places.
1005 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1007 * xdisp.c (handle_stop): Detect whether we have overlay strings
1008 loaded by testing it->current.overlay_string_index to be
1009 non-negative, instead of checking whether n_overlay_strings is
1010 positive. (Bug#11587)
1012 2012-05-31 Chong Yidong <cyd@gnu.org>
1014 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1016 * doc.c (Fsubstitute_command_keys): Doc fix.
1018 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1020 * search.c (search_buffer): Remove calls to
1021 r_alloc_inhibit_buffer_relocation, as it is now called by
1022 maybe_unify_char, which was the cause of relocation of buffer text
1025 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1027 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1028 for the duration of call to load_charset, to avoid problems with
1029 callers of maybe_unify_char that access buffer text through C
1032 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1033 decrement the inhibition flag, instead of just setting or
1036 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1038 Remove obsolete '#define static' cruft.
1039 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1040 This #undef was "temporary" in 2000; it is no longer needed
1041 now that '#define static' has gone away.
1042 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1043 (gray_bitmap_bits): Remove; no longer needed.
1044 All uses replaced with definiens.
1045 * xterm.c: Include "bitmaps/gray.xbm".
1047 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1049 Clean up __executable_start, monstartup when --enable-profiling.
1050 The following changes affect the code only when profiling.
1051 * dispnew.c (__executable_start): Rename from safe_bcopy.
1052 Define only on platforms that need it.
1053 * emacs.c: Include <sys/gmon.h> when profiling.
1054 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1055 (__executable_start): Remove decl, since lisp.h does it now.
1056 (safe_bcopy): Remove decl; no longer has that name.
1057 (main): Coalesce #if into single bit of code, for simplicity.
1058 Cast pointers to uintptr_t, since standard libraries want integers
1060 * lisp.h (__executable_start): New decl.
1062 2012-05-31 Glenn Morris <rgm@gnu.org>
1064 * image.c (Fimagemagick_types): Doc fix.
1066 2012-05-30 Jim Meyering <meyering@redhat.com>
1068 * callproc.c (Fcall_process_region): Include directory component
1069 in mkstemp error message (Bug#11586).
1071 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1073 * alloc.c, lisp.h (make_pure_vector): Now static.
1075 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1077 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1078 Move to byte-run.el.
1079 (Fautoload): Do the hash-doc more carefully.
1080 * data.c (Fdefalias): Purify definition, except for keymaps.
1081 (Qdefun): Move from eval.c.
1082 * lisp.h (Qdefun): Remove.
1083 * lread.c (read1): Tiny simplification.
1085 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
1087 Do not create empty overlays with the evaporate property (Bug#9642).
1088 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1089 Bug#9642, but explicitly check that the buffer the overlay would
1090 be moved to is live and rearrange lines to make sure that errors
1091 will not put the overlay in an inconsistent state.
1092 (Fdelete_overlay): Cosmetics.
1094 2012-05-28 Eli Zaretskii <eliz@gnu.org>
1096 * w32term.c (my_bring_window_to_top): New function.
1097 (x_raise_frame): Use handle returned by DeferWindowPos, which
1098 could be different from the original one.
1099 Call my_bring_window_to_top instead of my_set_foreground_window.
1102 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1103 by calling BringWindowToTop.
1105 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1106 (WM_EMACS_END): Increase by one.
1108 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1110 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1111 This avoids undefined behavior that might cause the eassert
1112 to not catch an out-of-range value.
1114 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
1116 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1117 Update dependencies.
1119 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1121 * bidi.c (bidi_mirror_char): Fix last change.
1123 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1125 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1126 when referring to sectname field in printf format.
1128 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1130 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1131 Only r_alloc_inhibit_buffer_relocation needed to be added;
1132 the others were already declared.
1134 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1135 before checking whether it's out of range. Put the check inside
1137 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1139 2012-05-27 Ken Brown <kbrown@cornell.edu>
1141 * callproc.c (Fcall_process): Restore a line that was accidentally
1142 commented out in the 2011-02-13 change (bug#11547).
1144 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1146 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1147 defined on ralloc.c.
1149 * buffer.c [REL_ALLOC]: Remove prototypes of
1150 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1151 they are now on lisp.h.
1153 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1155 * search.c (search_buffer): Use it to inhibit relocation of buffer
1156 text while re_search_2 is doing its job, because re_search_2 is
1157 passed C pointers to buffer text. (Bug#11519)
1159 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1162 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1163 state after an additional call to move_it_in_display_line_to, keep
1164 the values of it->max_ascent and it->max_descent found for the
1166 (pos_visible_p): Revert the comparison against bottom_y to what it
1167 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1170 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1172 Fix coding-related core dumps with gcc -ftrapv.
1173 The code was computing A - B, where A and B are pointers, and B is
1174 random garbage. This can lead to core dumps on platforms that
1175 have special pointer registers, and it also leads to core dumps on
1176 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1177 A - B only when B is initialized properly.
1178 * coding.c (coding_set_source, coding_set_destination): Return void.
1179 (coding_change_source, coding_change_destinations): New functions,
1180 with the old behaviors of coding_set_source and coding_set_destination.
1181 All callers that need an offset changed to use these new functions.
1183 2012-05-26 Glenn Morris <rgm@gnu.org>
1185 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1187 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1189 Extend mouse support on W32 text-mode console.
1190 * xdisp.c (draw_row_with_mouse_face):
1191 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
1193 * w32console.c: Include window.h.
1194 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1196 (initialize_w32_display): Initialize mouse-highlight data.
1198 * w32inevt.c: Include termchar.h and window.h.
1199 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1200 moves, call note_mouse_highlight. If help_echo changed, call
1201 gen_help_event to produce help-echo message in the echo area.
1202 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1205 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1207 * lread.c (read1): Simplify slightly to avoid an overflow warning
1208 with GCC 4.7.0 on x86-64.
1210 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1212 * bidi.c (bidi_mirror_char): Revert last change: an int is
1213 definitely wide enough here.
1215 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
1217 Fix integer width and related bugs (Bug#9874).
1218 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
1219 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1220 (string_bytes, check_sblock, allocate_string_data):
1221 (compact_small_strings, Fmake_bool_vector, make_string)
1222 (make_unibyte_string, make_multibyte_string)
1223 (make_string_from_bytes, make_specified_string)
1224 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1225 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1227 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1228 (allocate_pseudovector):
1229 Use int, not EMACS_INT, where int is wide enough.
1230 (inhibit_garbage_collection, Fgarbage_collect):
1231 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1232 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1233 int might not be wide enough.
1234 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1235 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1236 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1237 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1238 (bidi_level_of_next_char, bidi_move_to_visually_next):
1239 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1240 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1241 (Fkill_buffer, Fset_buffer_major_mode)
1242 (advance_to_char_boundary, Fbuffer_swap_text)
1243 (Fset_buffer_multibyte, overlays_at, overlays_in)
1244 (overlay_touches_p, struct sortvec, record_overlay_string)
1245 (overlay_strings, recenter_overlay_lists)
1246 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1247 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1248 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1249 (Foverlay_recenter, last_overlay_modification_hooks_used)
1250 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1251 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1252 (validate_region): Omit unnecessary test for b <= e,
1253 since that's guaranteed by the previous test.
1254 (adjust_overlays_for_delete): Avoid pos + length overflow.
1255 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1256 (report_overlay_modification):
1257 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1258 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1259 Omit pointer cast, which isn't needed anyway, and doesn't work
1260 after the EMACS_INT -> ptrdiff_t change.
1261 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
1262 * buffer.h: Adjust decls to match defn changes elsewhere.
1263 (struct buffer_text, struct buffer):
1264 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1265 Use EMACS_INT, not int, where int might not be wide enough.
1266 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1267 not int, to avoid needless 32-bit limit on 64-bit hosts.
1268 (exec_byte_code): Use tighter memory-full test, one that checks
1269 for alloca overflow. Don't compute the address of the object just
1270 before an array, as that's not portable. Use EMACS_INT, not
1271 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
1272 * callint.c (Fcall_interactively):
1273 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1274 * callproc.c (call_process_kill, Fcall_process):
1275 Don't assume pid_t fits into an Emacs fixnum.
1276 (call_process_cleanup, Fcall_process, child_setup):
1277 Don't assume pid_t fits into int.
1278 (call_process_cleanup, Fcall_process, delete_temp_file)
1279 (Fcall_process_region):
1280 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1281 (Fcall_process): Simplify handling of volatile integers.
1282 Use int, not EMACS_INT, where int will do.
1283 * casefiddle.c (casify_object, casify_region, operate_on_word)
1284 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1285 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1286 (casify_object): Avoid integer overflow when overallocating buffer.
1287 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
1288 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
1289 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1290 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1291 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1292 integers are now checked earlier. All uses replaced with XINT.
1294 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1295 For CCL_MapSingle, check that content and value are in int range.
1296 (ccl_driver, Fregister_code_conversion_map):
1297 Check that Vcode_version_map_vector is a vector.
1298 (resolve_symbol_ccl_program): Check that vector header is in range.
1299 Always copy the vector, so that we can check its contents reliably
1300 now rather than having to recheck each instruction as it's being
1301 executed. Check that vector words fit in 'int'.
1302 (ccl_get_compiled_code, Fregister_ccl_program)
1303 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1304 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1305 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1306 contents are in range.
1307 (Fccl_execute_on_string): Check that status is in range.
1308 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1309 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1310 Accept and return EMACS_INT, not int, because callers can pass values
1312 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1313 (multibyte_chars_in_text, parse_str_as_multibyte)
1314 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1315 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1316 (string_escape_byte8, Fget_byte):
1317 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1318 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
1319 avoid mishandling large integers.
1320 * character.h: Adjust decls to match defn changes elsewhere.
1321 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1322 (Ffind_charset_region):
1323 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1324 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1325 (load_charset_map_from_vector, Fdefine_charset_internal):
1326 Don't assume fixnum fits in int.
1327 (load_charset_map_from_vector, Fmap_charset_chars):
1328 Remove now-unnecessary CHECK_NATNUMs.
1329 (Fdefine_charset_internal): Check ranges here, more carefully.
1330 Don't rely on undefined behavior with signed left shift overflow.
1331 Don't assume unsigned int fits into fixnum, or that fixnum fits
1332 into unsigned int. Don't require max_code to be a valid fixnum;
1333 that's not true for gb10830 4-byte on a 32-bit host. Allow
1334 invalid_code to be a cons, for the same reason. Require code_offset
1335 to be a character. Avoid int overflow if max_char is close
1337 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1338 this is intended anyway and avoids some undefined behavior.
1339 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1340 INDEX_TO_CODE_POINT, as that's what it expects.
1341 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
1342 * charset.h (DECODE_CHAR): Return int, not unsigned;
1343 this is what was intended anyway, and it avoids undefined behavior.
1344 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1345 integer-overflow issues.
1346 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1347 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1348 where the argument is EMACS_INT, and this behavior is not intended.
1349 * chartab.c (Fmake_char_table, Fset_char_table_range)
1350 (uniprop_get_decoder, uniprop_get_encoder):
1351 Don't assume fixnum fits in int.
1352 * cmds.c (move_point): New function, that does the gist of
1353 Fforward_char and Fbackward_char, but does so while checking
1354 for integer overflow more accurately.
1355 (Fforward_char, Fbackward_char): Use it.
1356 (Fforward_line, Fend_of_line, internal_self_insert)
1357 (internal_self_insert):
1358 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1359 Fix a FIXME, by checking for integer overflow when calculating
1360 target_clm and actual_clm.
1361 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
1362 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
1363 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1364 (coding_alloc_by_making_gap, alloc_destination)
1365 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1366 (encode_coding_utf_16, detect_coding_emacs_mule)
1367 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1368 (detect_coding_iso_2022, decode_coding_iso_2022)
1369 (encode_invocation_designation, encode_designation_at_bol)
1370 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1371 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1372 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1373 (encode_coding_ccl, encode_coding_raw_text)
1374 (detect_coding_charset, decode_coding_charset)
1375 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1376 (produce_composition, produce_charset, produce_annotation)
1377 (decode_coding, handle_composition_annotation)
1378 (handle_charset_annotation, consume_chars, decode_coding_gap)
1379 (decode_coding_object, encode_coding_object, detect_coding_system)
1380 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1381 (code_convert_region, code_convert_string)
1382 (Fdefine_coding_system_internal)
1383 (coding_set_source, coding_set_destination):
1384 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1385 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1386 (Fdefine_coding_system_internal):
1387 Don't assume fixnums fit in int.
1388 (decode_coding_gap, decode_coding_object, encode_coding_object)
1389 (Fread_coding_system, Fdetect_coding_region)
1390 (Funencodable_char_position, Fcheck_coding_systems_region)
1391 (get_translation, handle_composition_annotation, consume_chars):
1392 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1393 (consume_chars): Rewrite to not calculate an address outside buffer.
1394 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
1395 Don't access memory outside of the args array.
1396 (Fdefine_coding_system_internal): Check for charset-id overflow.
1397 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1398 result of ENCODE_CHAR.
1399 * coding.h: Adjust decls to match defn changes elsewhere.
1400 (struct coding_system):
1401 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1402 * composite.c (get_composition_id, find_composition)
1403 (run_composition_function, update_compositions)
1404 (compose_text, composition_gstring_put_cache)
1405 (composition_gstring_p, composition_gstring_width)
1406 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1407 (composition_compute_stop_pos, composition_reseat_it)
1408 (composition_update_it, struct position_record)
1409 (find_automatic_composition, composition_adjust_point)
1410 (Fcomposition_get_gstring, Ffind_composition_internal):
1411 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1412 (update_compositions):
1413 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1414 * composite.h: Adjust decls to match defn changes elsewhere.
1415 (struct composition):
1416 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1417 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1418 Do not attempt to compute the address of the object just before a
1419 buffer; this is not portable.
1421 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1422 (Faset): Use int, not EMACS_INT, where int is wide enough.
1423 (Fstring_to_number): Don't assume fixnums fit in int.
1424 (Frem): Don't assume arg is nonnegative.
1425 * dbusbind.c (xd_append_arg): Check for integers out of range.
1426 (Fdbus_call_method): Don't overflow the timeout int.
1427 (extract_signed, extract_unsigned): New functions.
1428 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1429 (xd_get_connection_references): Return ptrdiff_t, not int.
1431 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1432 (xd_read_message_1):
1433 Use int, not unsigned, where the dbus API uses int.
1434 (Fdbus_message_internal): Don't overflow mtype.
1435 (syms_of_dbusbind): Allocate right-sized buffer for integers.
1436 * dired.c (directory_files_internal, file_name_completion, scmp)
1437 (file_name_completion_stat):
1438 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1439 (file_name_completion): Don't overflow matchcount.
1440 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1441 * dispextern.h: Adjust decls to match defn changes elsewhere.
1442 (struct text_pos, struct glyph, struct bidi_saved_info)
1443 (struct bidi_string_data, struct bidi_it, struct composition_it)
1445 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1446 (struct display_pos, struct composition_it, struct it):
1447 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1448 * dispnew.c (increment_matrix_positions)
1449 (increment_row_positions, mode_line_string)
1450 (marginal_area_string):
1451 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1452 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
1453 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1454 (duration_to_sec_usec): New function, to check for overflow better.
1455 (Fsleep_for, sit_for): Use it.
1456 * doc.c (get_doc_string, store_function_docstring):
1457 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1458 (get_doc_string, Fsnarf_documentation):
1459 Use int, not EMACS_INT, where int is wide enough.
1461 Use SAFE_ALLOCA, not alloca.
1462 Check for overflow when converting EMACS_INT to off_t.
1463 * doprnt.c (doprnt):
1464 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1465 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1466 Don't assume uid_t fits into fixnum.
1467 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1468 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1469 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1470 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1471 (general_insert_function)
1472 (Finsert_char, make_buffer_string, make_buffer_string_both)
1473 (update_buffer_properties, Fbuffer_substring)
1474 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1475 (Fsubst_char_in_region, check_translation)
1476 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1477 (transpose_markers, Ftranspose_regions):
1478 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1479 (clip_to_bounds): Move to lisp.h as an inline function).
1480 (Fconstrain_to_field): Don't assume integers are nonnegative.
1481 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1482 (Fsubst_char_in_region, Fsave_restriction):
1483 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1484 (Femacs_pid): Don't assume pid_t fits into fixnum.
1485 (lo_time): Use int, not EMACS_INT, when int suffices.
1486 (lisp_time_argument): Check for usec out of range.
1487 (Fencode_time): Don't assume fixnum fits in int.
1488 (Fuser_login_name, Fuser_full_name): Signal an error
1489 if a uid argument is out of range, rather than relying on
1491 (Fformat_time_string): Remove now-unnecessary check.
1492 lisp_time_argument checks for out-of-range usec now.
1493 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
1494 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1495 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1496 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1497 (init_cmdargs, Fdump_emacs):
1498 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1499 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1500 the bottom (typically) 32 bits of the fixnum.
1501 * eval.c (specpdl_size, call_debugger):
1502 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1503 (when_entered_debugger, Fbacktrace_debug):
1504 Don't assume fixnum can fit in int.
1505 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1506 the object just before a buffer; this is not portable.
1507 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1508 (grow_specpdl, unbind_to):
1509 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1510 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1511 (grow_specpdl): Simplify allocation by using xpalloc.
1512 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
1513 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1514 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1515 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1516 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1518 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1519 (Fcopy_file, non_regular_nbytes, read_non_regular)
1520 (Finsert_file_contents):
1521 Use int, not EMACS_INT, where int is wide enough.
1522 (READ_BUF_SIZE): Verify that it fits in int.
1523 (Finsert_file_contents): Check that counts are in proper range,
1524 rather than assuming fixnums fit into ptrdiff_t etc.
1525 Don't assume fixnums fit into int.
1526 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
1527 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1528 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
1529 (string_char_to_byte, string_byte_to_char)
1530 (string_make_multibyte, string_to_multibyte)
1531 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1532 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1533 (substring_both, Fdelete, internal_equal, Ffillarray)
1534 (Fclear_string, mapcar1)
1535 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1536 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1537 (larger_vector, make_hash_table, maybe_resize_hash_table)
1538 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1539 (Fmaphash, secure_hash):
1540 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1541 (concat): Check for string index and length overflow.
1542 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1544 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1545 (larger_vector): New API (vec, incr_min, size_max) replaces old
1546 one (vec, new_size, init). This catches size overflow.
1547 INIT was removed because it was always Qnil.
1548 All callers changed.
1549 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1550 the upper bound on a hash table index size.
1551 (make_hash_table, maybe_resize_hash_table): Use it.
1552 (secure_hash): Computer start_byte and end_byte only after
1553 they're known to be in ptrdiff_t range.
1554 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1555 (Ffont_get_glyphs, Ffont_at):
1556 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1557 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1558 (Flist_fonts, Fopen_font):
1559 Don't assume fixnum can fit in int.
1560 (check_gstring): Don't assume index can fit in int.
1561 (font_match_p): Check that fixnum is a character, not a nonnegative
1562 fixnum, since the later code needs to stuff it into an int.
1563 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1564 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1565 conversion overflow issues.
1566 (Fopen_font): Check for integer out of range.
1567 (Ffont_get_glyphs): Don't assume index can fit in int.
1568 * font.h: Adjust decls to match defn changes elsewhere.
1569 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1571 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1572 printmax_t, where ptrdiff_t is wide enough.
1573 (Finternal_char_font):
1574 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1575 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1576 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1577 (Fset_frame_position, x_set_frame_parameters)
1578 (x_set_line_spacing, x_set_border_width)
1579 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1580 Check that fixnums are in proper range for system types.
1581 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1582 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1583 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1584 Use SAFE_ALLOCA_LISP, not alloca.
1585 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1586 intptr_t is wide enough.
1587 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1588 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1589 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1590 Check for fixnum out of range.
1591 * ftfont.c (ftfont_list): Don't assume index fits in int.
1592 Check that fixnums are in proper range for system types.
1593 (ftfont_shape_by_flt):
1594 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1595 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1596 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1597 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1598 Check that fixnums are in proper range for system types.
1599 * gnutls.h: Adjust decls to match defn changes elsewhere.
1600 * gtkutil.c (xg_dialog_run):
1601 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1602 (update_frame_tool_bar):
1603 Check that fixnums are in proper range for system types.
1604 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
1605 (lookup_image): Check that fixnums are in range for system types.
1606 * indent.c (last_known_column, last_known_column_point):
1607 (current_column_bol_cache):
1608 (skip_invisible, current_column, check_display_width):
1609 (check_display_width, scan_for_column, current_column_1)
1610 (Findent_to, Fcurrent_indentation, position_indentation)
1611 (indented_beyond_p, Fmove_to_column, compute_motion):
1612 (Fcompute_motion, Fvertical_motion):
1613 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1614 (last_known_column_modified): Use EMACS_INT, not int.
1615 (check_display_width):
1617 Check that fixnums and floats are in proper range for system types.
1618 (compute_motion): Don't assume index or fixnum fits in int.
1619 (compute_motion, Fcompute_motion):
1620 Use int, not EMACS_INT, when it is wide enough.
1621 (vmotion): Omit local var start_hpos that is always 0; that way
1622 we don't need to worry about overflow in expressions involving it.
1623 * indent.h: Adjust decls to match defn changes elsewhere.
1625 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1626 Use int, not EMACS_INT, where int is wide enough.
1627 Remove unused members ovstring_chars_done and tab_offset;
1629 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1630 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1631 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1632 (make_gap, copy_text, insert, insert_and_inherit)
1633 (insert_before_markers, insert_before_markers_and_inherit)
1634 (insert_1, count_combining_before, count_combining_after)
1635 (insert_1_both, insert_from_string)
1636 (insert_from_string_before_markers, insert_from_string_1)
1637 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1638 (adjust_after_replace, adjust_after_insert, replace_range)
1639 (replace_range_2, del_range, del_range_1, del_range_byte)
1640 (del_range_both, del_range_2, modify_region)
1641 (prepare_to_modify_buffer, signal_before_change)
1642 (signal_after_change, Fcombine_after_change_execute):
1643 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1644 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1645 (balance_an_interval, split_interval_right, split_interval_left)
1646 (find_interval, next_interval, update_interval)
1647 (adjust_intervals_for_insertion, delete_node, delete_interval)
1648 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1649 (static_offset_intervals, offset_intervals)
1650 (merge_interval_right, merge_interval_left, make_new_interval)
1651 (graft_intervals_into_buffer, temp_set_point_both)
1652 (temp_set_point, set_point, adjust_for_invis_intang)
1653 (set_point_both, move_if_not_intangible, get_property_and_range)
1654 (get_local_map, copy_intervals, copy_intervals_to_string)
1655 (compare_string_intervals, set_intervals_multibyte_1):
1656 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1657 * intervals.h: Adjust decls to match defn changes elsewhere.
1659 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1660 * keyboard.c (this_command_key_count, this_single_command_key_start)
1661 (before_command_key_count, before_command_echo_length, echo_now)
1662 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1663 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1664 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1665 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1666 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1667 (last_non_minibuf_size, last_point_position, echo_truncate)
1668 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1669 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1670 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1671 (stuff_buffered_input):
1672 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1673 (last_auto_save, command_loop_1, read_char):
1674 Use EMACS_INT, not int, to avoid integer overflow.
1675 (record_char): Avoid overflow in total_keys computation.
1676 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1677 * keyboard.h: Adjust decls to match defn changes elsewhere.
1678 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1679 (Fkey_description, Fdescribe_vector, Flookup_key):
1680 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1681 (click_position): New function, to check that positions are in range.
1682 (Fcurrent_active_maps):
1684 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1685 (Faccessible_keymaps, Fkey_description):
1686 (preferred_sequence_p):
1687 Don't assume fixnum can fit into int.
1688 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1689 Check for integer overflow in size calculations.
1690 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1691 avoid mishandling large integers.
1692 * lisp.h: Adjust decls to match defn changes elsewhere.
1693 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1694 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1695 (struct Lisp_Marker):
1696 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1697 (clip_to_bounds): Now an inline function, moved here from editfns.c.
1698 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1699 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1700 All callers changed.
1701 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1702 Assume the arg has valid form, since it always does.
1703 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1704 unsigned integer system type.
1705 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1706 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1707 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1708 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1709 (duration_to_sec_usec): New decl.
1710 * lread.c (read_from_string_index, read_from_string_index_byte)
1711 (read_from_string_limit, readchar, unreadchar, openp)
1712 (read_internal_start, read1, oblookup):
1713 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1714 (Fload, readevalloop, Feval_buffer, Feval_region):
1715 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1716 (openp): Check for out-of-range argument to 'access'.
1717 (read1): Use int, not EMACS_INT, where int is wide enough.
1718 Don't assume fixnum fits into int.
1719 Fix off-by-one error that can read outside a buffer.
1720 (read_filtered_event): Use duration_to_sec_usec
1721 to do proper overflow checking on durations.
1722 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1723 in size calculation.
1724 (Fexecute_kbd_macro):
1725 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1726 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1727 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1728 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1729 (set_marker_both, set_marker_restricted_both, marker_position)
1730 (marker_byte_position, Fbuffer_has_markers_at):
1731 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1732 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
1733 * menu.c (ensure_menu_items): Rename from grow_menu_items.
1734 It now merely ensures that the menu is large enough, without
1735 necessarily growing it, as this avoids some integer overflow issues.
1736 All callers changed.
1737 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1738 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1739 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1740 Use SAFE_ALLOCA_LISP, not alloca.
1741 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1742 to EMACS_INT. Check that fixnums are in proper range for system types.
1743 * minibuf.c (minibuf_prompt_width, string_to_object)
1744 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1745 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1746 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1747 (get_minibuffer, read_minibuf_unwind):
1748 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1749 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1750 this simplifies overflow checking. All callers changed.
1751 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1753 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1754 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1755 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1756 Check that fixnums are in proper range for system types.
1757 (Fx_create_frame, Fx_show_tip):
1758 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1759 * nsfont.m (ns_findfonts, nsfont_list_family):
1760 Don't assume fixnum fits in long.
1761 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1762 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1763 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1765 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
1766 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1767 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1768 (PRINTDECLARE, PRINTPREPARE):
1769 (strout, print_string):
1770 (print, print_preprocess, print_check_string_charset_prop)
1772 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1774 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1775 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1776 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
1777 (printchar, strout): Use xpalloc to catch size calculation overflow.
1778 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
1779 (print_error_message): Use SAFE_ALLOCA, not alloca.
1780 (print_object): Use int, not EMACS_INT, where int is wide enough.
1781 (print_depth, new_backquote_output, print_number_index):
1782 Use ptrdiff_t, not int, where int might not be wide enough.
1783 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1784 (Fset_process_window_size, Fformat_network_address)
1785 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
1787 Check that fixnums are in proper range for system types.
1788 (Fsignal_process): Simplify by avoiding a goto.
1789 Check for process-ids out of pid_t range rather than relying on
1791 (process_tick, update_tick): Use EMACS_INT, not int.
1792 (Fformat_network_address, read_process_output, send_process)
1793 (Fprocess_send_region, status_notify):
1794 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1795 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1796 (wait_reading_process_output, read_process_output, exec_sentinel):
1797 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1798 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1799 (Faccept_process_output): Use duration_to_sec_usec to do proper
1800 overflow checking on durations.
1801 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1802 Don't assume pid_t fits in int.
1803 * process.h (struct Lisp_Process): Members tick and update_tick
1804 are now of type EMACS_INT, not int.
1805 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1806 configured --with-wide-int.
1807 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1808 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1809 * search.c (looking_at_1, string_match_1):
1810 (fast_string_match, fast_c_string_match_ignore_case)
1811 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1812 (scan_newline, find_before_next_newline, search_command)
1813 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1814 (set_search_regs, wordify):
1817 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1818 (string_match_1, search_buffer, set_search_regs):
1820 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1821 (wordify): Check for overflow in size calculation.
1822 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1823 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1824 Check that fixnums are in proper range for system types.
1825 * sound.c (struct sound_device)
1826 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1827 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1828 (Fplay_sound_internal):
1829 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1830 * syntax.c (struct lisp_parse_state, find_start_modiff)
1831 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1832 (Fparse_partial_sexp):
1833 Don't assume fixnums can fit in int.
1834 (struct lisp_parse_state, find_start_pos, find_start_value)
1835 (find_start_value_byte, find_start_begv)
1836 (update_syntax_table, char_quoted, dec_bytepos)
1837 (find_defun_start, prev_char_comend_first, back_comment):
1838 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1839 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1840 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1841 (Finternal_describe_syntax_value): Check that match_lisp is a
1842 character, not an integer, since the code stuffs it into int.
1843 (scan_words, scan_sexps_forward):
1844 Check that fixnums are in proper range for system types.
1846 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1847 (scan_sexps_forward):
1848 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1849 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1850 * syntax.h: Adjust decls to match defn changes elsewhere.
1851 (struct gl_state_s):
1852 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1853 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1854 MOST_POSITIVE_FIXNUM.
1855 * sysdep.c (wait_for_termination_1, wait_for_termination)
1856 (interruptible_wait_for_termination, mkdir):
1857 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1858 (emacs_read, emacs_write):
1859 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1860 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1861 and double all fit in int.
1862 * term.c (set_tty_color_mode):
1863 Check that fixnums are in proper range for system types.
1864 * termhooks.h (struct input_event):
1865 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1866 * textprop.c (validate_interval_range, interval_of)
1867 (Fadd_text_properties, set_text_properties_1)
1868 (Fremove_text_properties, Fremove_list_of_text_properties)
1869 (Ftext_property_any, Ftext_property_not_all)
1870 (copy_text_properties, text_property_list, extend_property_ranges)
1871 (verify_interval_modification):
1872 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1873 (Fnext_single_char_property_change)
1874 (Fprevious_single_char_property_change):
1875 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1876 (copy_text_properties):
1877 Check for integer overflow in index calculation.
1878 * undo.c (last_boundary_position, record_point, record_insert)
1879 (record_delete, record_marker_adjustment, record_change)
1880 (record_property_change):
1881 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1882 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1883 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1884 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1885 (Fx_hide_tip, Fx_file_dialog):
1886 * w32menu.c (set_frame_menubar):
1887 Use ptrdiff_t, not int, for consistency with rest of code.
1888 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1889 (select_window, Fdelete_other_windows_internal)
1890 (window_scroll_pixel_based, window_scroll_line_based)
1891 (Frecenter, Fset_window_configuration):
1892 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1893 (Fset_window_hscroll, run_window_configuration_change_hook)
1894 (set_window_buffer, temp_output_buffer_show, scroll_command)
1895 (Fscroll_other_window, Frecenter):
1896 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1897 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1898 Don't assume fixnum fits in int.
1899 (Fset_window_scroll_bars):
1900 Check that fixnums are in proper range for system types.
1901 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1902 (string_pos, c_string_pos, number_of_chars, init_iterator)
1903 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1904 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1905 (compute_display_string_end, handle_face_prop)
1906 (face_before_or_after_it_pos, handle_invisible_prop)
1907 (handle_display_prop, handle_display_spec, handle_single_display_spec)
1908 (display_prop_intangible_p, string_buffer_position_lim)
1909 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1910 (get_overlay_strings_1, get_overlay_strings)
1911 (iterate_out_of_display_property, forward_to_next_line_start)
1912 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1913 (get_next_display_element, set_iterator_to_next)
1914 (get_visually_first_element, compute_stop_pos_backwards)
1915 (handle_stop_backwards, next_element_from_buffer)
1916 (move_it_in_display_line_to, move_it_in_display_line)
1917 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1918 (add_to_log, message_dolog, message_log_check_duplicate)
1919 (message2, message2_nolog, message3, message3_nolog
1920 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1921 (current_message_1, truncate_echo_area, truncate_message_1)
1922 (set_message, set_message_1, store_mode_line_noprop)
1923 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1924 (text_outside_line_unchanged_p, check_point_in_composition)
1925 (reconsider_clip_changes)
1926 (redisplay_internal, set_cursor_from_row, try_scrolling)
1927 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1928 (redisplay_window, find_last_unchanged_at_beg_row)
1929 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1930 (trailing_whitespace_p, find_row_edges, display_line)
1931 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1932 (display_mode_element, store_mode_line_string)
1933 (pint2str, pint2hrstr, decode_mode_spec)
1934 (display_count_lines, display_string, draw_glyphs)
1935 (x_produce_glyphs, x_insert_glyphs)
1936 (rows_from_pos_range, mouse_face_from_buffer_pos)
1937 (fast_find_string_pos, mouse_face_from_string_pos)
1938 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1939 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1940 (safe_call, init_from_display_pos, handle_fontified_prop)
1941 (handle_single_display_spec, load_overlay_strings)
1942 (with_echo_area_buffer, setup_echo_area_for_printing)
1943 (display_echo_area, echo_area_display)
1944 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1945 (update_tool_bar, hscroll_window_tree, redisplay_internal)
1946 (redisplay_window, dump_glyph_row, display_mode_line)
1947 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
1948 (handle_display_spec, display_prop_string_p):
1949 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1950 (handle_single_display_spec, build_desired_tool_bar_string)
1951 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1952 (get_specified_cursor_type):
1953 Check that fixnums are in proper range for system types.
1954 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1955 (Flookup_image_map):
1956 Don't assume fixnums fit in int.
1957 (compare_overlay_entries):
1958 Avoid mishandling comparisons due to subtraction overflow.
1959 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1960 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1961 (handle_tool_bar_click):
1962 Use int, not unsigned, since we prefer signed and the signedness
1963 doesn't matter here.
1964 (get_next_display_element, next_element_from_display_vector):
1965 Use int, not EMACS_INT, when int is wide enough.
1966 (start_hourglass): Use duration_to_sec_usec to do proper
1967 overflow checking on durations.
1968 * xfaces.c (Fbitmap_spec_p):
1969 Check that fixnums are in proper range for system types.
1970 (compare_fonts_by_sort_order):
1971 Avoid mishandling comparisons due to subtraction overflow.
1972 (Fx_family_fonts, realize_basic_faces):
1973 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1975 Don't assume fixnum fits in int.
1976 Use SAFE_ALLOCA_LISP, not alloca.
1977 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1978 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1979 (face_at_buffer_position, face_for_overlay_string)
1980 (face_at_string_position):
1981 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1982 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1983 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1985 Check that fixnums are in proper range for system types.
1986 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1987 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1988 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1989 (Fx_change_window_property): Don't assume fixnums fit in int.
1990 * xfont.c (xfont_chars_supported):
1991 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1992 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1993 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1994 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1995 * xml.c (parse_region):
1996 * xrdb.c (magic_file_p):
1997 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1998 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1999 (x_get_local_selection, x_reply_selection_request)
2000 (x_handle_selection_request, wait_for_property_change):
2001 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2002 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2003 short is wide enough.
2004 (x_send_client_event): Don't assume fixnum fits in int.
2005 * xterm.c (x_x_to_emacs_modifiers):
2006 Don't assume EMACS_INT overflows nicely into int.
2007 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2009 (handle_one_xevent): NATNUMP can eval its arg twice.
2010 (x_connection_closed):
2011 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2012 * xterm.h: Adjust decls to match defn changes elsewhere.
2013 (struct scroll_bar): Use struct vectorlike_header
2014 rather than rolling our own approximation.
2015 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2017 2012-05-25 Glenn Morris <rgm@gnu.org>
2019 * lisp.mk (lisp): Update for more files being compiled now.
2021 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2023 * lread.c: Remove `read_pure' which makes no difference.
2024 (read_pure): Remove var.
2025 (unreadpure): Remove function.
2026 (readevalloop): Don't call read_list with -1 flag.
2027 (read1, read_vector): Don't test read_pure any more.
2028 (read_list): Simplify.
2030 * fileio.c, character.h: Minor style tweaks.
2032 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2034 * window.h (clip_changed): Remove useless declaration.
2036 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
2038 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2039 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2041 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2044 This directory predates autoconf and is no longer needed nowadays.
2045 Move its few remaining bits of functionality to where they're needed.
2046 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2047 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2048 * m/template.h: Remove.
2049 * Makefile.in (M_FILE): Remove. All uses removed.
2050 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2051 * lisp.h (USE_LSB_TAG):
2052 * mem-limits.h (EXCEEDS_LISP_PTR):
2053 Use VAL_MAX, not VALBITS, in #if.
2054 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2055 (EMACS_UINT): Define unconditionally now.
2056 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2057 (BITS_PER_EMACS_INT): New constants, replacing
2058 what used to be in config.h, but not useful in #if.
2059 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2060 define them any more.
2061 (VAL_MAX): New macro.
2063 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2064 BITS_PER_EMACS_INT, in #if.
2065 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2066 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2067 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2068 * s/ms-w32.h (DATA_START):
2069 Move here from removed file m/intel386.h.
2070 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2071 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2073 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2075 Assume C89 or later.
2076 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2077 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2079 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2080 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2081 * textprop.c, tparam.c (NULL): Remove.
2082 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2083 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2084 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2085 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2086 * xterm.c (input_signal_count): Assume volatile works.
2088 2012-05-21 Ken Brown <kbrown@cornell.edu>
2090 * xgselect.c (xg_select): Fix first argument in call to 'select'
2093 2012-05-20 Ken Brown <kbrown@cornell.edu>
2095 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
2096 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
2098 2012-05-19 Ken Brown <kbrown@cornell.edu>
2100 * xfns.c (x_in_use): Remove `static' qualifier.
2101 * xterm.h (x_in_use): Declare.
2102 * xgselect.c: Include xterm.h.
2103 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2104 and `display_arg' (bug#9754).
2106 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2108 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2110 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2111 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2113 2012-05-18 Eli Zaretskii <eliz@gnu.org>
2115 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2117 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2118 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
2120 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2121 reference to image_cache->refcount.
2122 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2124 2012-05-17 Juri Linkov <juri@jurta.org>
2126 * search.c (Fword_search_regexp, Fword_search_backward)
2127 (Fword_search_forward, Fword_search_backward_lax)
2128 (Fword_search_forward_lax): Move functions to isearch.el
2129 (bug#10145, bug#11381).
2131 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2133 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2135 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2137 * lread.c (init_obarray): Declare Qt and Qnil as special.
2139 2012-05-14 Glenn Morris <rgm@gnu.org>
2141 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
2142 Put "libexec" before "bin", for the sake of init_callproc_1.
2144 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2146 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2148 * unexaix.c: Port to more-recent AIX compilers.
2149 (report_error, report_error_1, make_hdr, copy_sym)
2150 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2151 Make arguments const char *, not char *, to avoid violations of C
2152 standard and to fix some AIX warnings reported by Gilles Pion.
2154 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2156 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2157 already have overlays loaded.
2158 (handle_single_display_spec): Before returning without displaying
2159 fringe bitmap, synchronize the bidi iterator with the main display
2160 iterator, by calling iterate_out_of_display_property.
2161 (iterate_out_of_display_property): Detect buffer iteration by
2162 testing that it->string is a Lisp string.
2163 (get_next_display_element): When the current object is exhausted,
2164 and there's something on it->stack, call set_iterator_to_next to
2165 proceed with what's on the stack, instead of returning zero.
2166 (set_iterator_to_next): If called at the end of a Lisp string,
2167 proceed to consider_string_end without incrementing string
2168 position. Don't increment display vector index past the end of
2169 the display vector. (Bug#11417)
2170 (pos_visible_p): Don't report a position visible when move_it_to
2171 stopped at the last line of window, which happens to be scanned
2172 backwards by the bidi iteration. (Bug#11464)
2174 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2176 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2177 and right-margin display specs even if the spec is invalid or we
2178 are on a TTY, and thus unable to display on the fringes.
2179 That's because the text with the property will not be displayed anyway,
2180 so we need to signal to the caller that this is a "replacing"
2181 display spec. This fixes display when the spec is invalid or we
2184 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2186 * unexaix.c (make_hdr): Fix typo in prototype.
2187 This bug broke the build on AIX. Problem reported by Gilles Pion.
2189 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
2191 * keyboard.c (kbd_buffer_get_event): Read special events also in
2192 batch mode. (Bug#11415)
2194 2012-05-12 Glenn Morris <rgm@gnu.org>
2196 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2198 2012-05-12 Eli Zaretskii <eliz@gnu.org>
2200 * lisp.mk (lisp): Add newcomment.elc.
2202 2012-05-12 Glenn Morris <rgm@gnu.org>
2204 * Makefile.in (MKDIR_P): New, set by configure.
2205 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2207 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2209 Remove unused function hourglass_started.
2210 * dispextern.h (hourglass_started):
2211 * w32fns.c (hourglass_started):
2212 * xdisp.c (hourglass_started): Remove.
2214 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
2216 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2217 Update dependencies.
2219 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2221 * xgselect.c (xg_select): Put maxfds+1 into a var.
2222 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2224 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2226 2012-05-10 Dave Abrahams <dave@boostpro.com>
2228 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2229 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2231 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
2233 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2234 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2235 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2236 Initialize xd_registered_buses.
2238 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2240 Untag more efficiently if USE_LSB_TAG.
2241 This is based on a proposal by YAMAMOTO Mitsuharu in
2242 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2243 For an admittedly artificial (nth 8000 longlist) benchmark on
2244 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2245 Emacs's overall text size by 1%.
2246 * lisp.h (XUNTAG): New macro.
2247 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2248 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2249 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2250 * eval.c (Fautoload):
2251 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2252 * frame.h (XFRAME): Use XUNTAG.
2254 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2255 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2256 Remove unportable assumptions about print widths of types like
2258 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2259 intptr_t when converting between pointer and integer, to avoid GCC
2260 warnings about wrong width.
2262 2012-05-09 Eli Zaretskii <eliz@gnu.org>
2264 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2265 stack for each reader_thread, instead of defaulting to 8MB
2266 determined by the linker. This avoids failures in creating
2267 subprocesses on Windows 7, see the discussion in this thread:
2268 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2270 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2272 Fix up display of the *Minibuf-0* buffer in the mini window.
2273 * keyboard.c (read_char): Don't clear the echo area if there's no
2275 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2276 contents of *Minibuf-0*) if there's no message displayed in its stead.
2278 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
2280 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2283 2012-05-06 Chong Yidong <cyd@gnu.org>
2285 * lisp.mk (lisp): Update.
2287 2012-05-05 Jim Meyering <meyering@redhat.com>
2289 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2291 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2293 * data.c (PUT_ERROR): New macro.
2294 (syms_of_data): Use it. Add new error type `user-error'.
2295 * undo.c (user_error): New function.
2296 (Fprimitive_undo): Use it.
2297 * print.c (print_error_message): Adjust print style for `user-error'.
2298 * keyboard.c (user_error): New function.
2299 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2301 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2303 Do not limit current-time-string to years 1000..9999.
2304 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2305 (Fcurrent_time_string): Support any year that is supported by the
2306 underlying localtime representation. Don't use asctime, as it
2307 has undefined behavior for years outside the range -999..9999.
2309 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2311 Fix race conditions involving setenv, gmtime, localtime, asctime.
2312 Without this fix, interrupts could mess up code that uses these
2313 nonreentrant functions, since setting TZ invalidates existing
2314 tm_zone or tzname values, and since most of these functions return
2315 pointers to static storage.
2316 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2317 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2318 Grow the critical sections to include not just invoking
2319 localtime/gmtime, but also accessing these functions' results
2320 including their tm_zone values if any, and any related TZ setting.
2321 (format_time_string): Last arg is now struct tm *, not struct tm **,
2322 so that the struct tm is saved in the critical section.
2323 All callers changed. Simplify allocation of initial buffer, partly
2324 motivated by the fact that memory allocation needs to be outside
2325 the critical section.
2327 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2329 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2330 with RESET_INTERVAL.
2332 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2333 Remove duplicated buffer name initialization.
2335 2012-05-02 Jim Meyering <jim@meyering.net>
2337 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2339 * xfns.c (x_window): Use xstrdup (Bug#11375).
2341 2012-05-02 Eli Zaretskii <eliz@gnu.org>
2343 * xdisp.c (pos_visible_p): If already at a newline from the
2344 display string before the 'while' loop, don't walk back the glyphs
2345 from it3.glyph_row. Solves assertion violation when the display
2346 string begins with a newline (egg.el). (Bug#11367)
2348 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2350 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2353 2012-05-01 Glenn Morris <rgm@gnu.org>
2355 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2356 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2357 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2358 All were removed before 23.1.
2360 * dispnew.c: Remove HAVE_LIBNCURSES test;
2361 it is always true on relevant platforms.
2363 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2364 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2366 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2368 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2370 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2371 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2374 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2376 Do not avoid creating empty evaporating overlays (Bug#9642).
2377 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2378 That is, do not delete an evaporating overlay if it becomes
2379 empty after its bounds are adjusted to fit within its buffer.
2380 This fix caused other problems, and I'm reverting it until we get
2381 to the bottom of them.
2383 2012-04-27 Chong Yidong <cyd@gnu.org>
2385 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2387 2012-04-27 Eli Zaretskii <eliz@gnu.org>
2389 * xdisp.c (pos_visible_p): If the window start position is beyond
2390 ZV, start the display from buffer beginning. Prevents assertion
2391 violation in init_iterator when the minibuffer window is scrolled
2394 * window.c (window_scroll_pixel_based): Likewise.
2396 2012-04-27 Chong Yidong <cyd@gnu.org>
2398 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2400 2012-04-27 Glenn Morris <rgm@gnu.org>
2402 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2403 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2405 2012-04-27 Eli Zaretskii <eliz@gnu.org>
2407 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2408 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
2410 2012-04-26 Eli Zaretskii <eliz@gnu.org>
2412 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2413 display element, check also the underlying string or buffer
2414 character. (Bug#11341)
2416 * w32menu.c: Include w32heap.h.
2417 (add_menu_item): If the call to AppendMenuW (via
2418 unicode_append_menu) fails, disable Unicode menus only if we are
2419 running on Windows 9X/Me.
2421 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2423 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2424 (xgetint): Add missing shift for LSB tags.
2426 2012-04-24 Martin Rudalics <rudalics@gmx.at>
2428 * keyboard.c (read_char): Don't wipe echo area for select window
2429 events: These might get delayed via `mouse-autoselect-window'
2432 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
2434 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2435 manipulation of :loaded-from data.
2437 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
2439 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2440 now a cons (bug#11311).
2442 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2444 Do not create empty overlays with the evaporate property (Bug#9642).
2445 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2446 if it becomes empty after its bounds are adjusted to fit within
2447 its buffer. Without this fix, in a nonempty buffer (let ((o
2448 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2449 yields an empty overlay that has the evaporate property, which is
2450 not supposed to happen.
2452 Fix minor GTK3 problems found by static checking.
2453 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2454 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2455 (struct _EmacsFixedClass, emacs_fixed_get_type):
2456 Move decls here from emacsgtkfixed.h, since they needn't be public.
2457 (emacs_fixed_get_type): Now static.
2458 (emacs_fixed_class_init): Omit unused local.
2459 (emacs_fixed_child_type): Remove; unused.
2460 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2461 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2462 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2463 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2464 (EMACS_FIXED_GET_CLASS): Remove; unused.
2465 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2467 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2468 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2470 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2472 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
2473 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
2474 (__malloc_size_t, __malloc_ptrdiff_t):
2475 Remove. All uses removed, replaced by the definiens if needed,
2476 since we can assume C89 or better now.
2477 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2478 (protect_malloc_state, align, get_contiguous_space)
2479 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2480 (malloc_atfork_handler_child, malloc_enable_thread)
2481 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2482 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2483 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2484 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2485 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2486 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2487 Define using prototypes, not old style.
2488 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2489 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2490 (align): Don't assume that signed integer overflow wraps around.
2491 Omit unused local var.
2492 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2493 (_free_internal_nolock, memalign, mallochook, reallochook):
2494 Omit no-longer-needed casts.
2495 (valloc): Use getpagesize, not __getpagesize.
2496 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2497 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2499 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2501 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
2503 Move functions from C to Lisp. Make non-blocking method calls
2504 the default. Implement further D-Bus standard interfaces.
2506 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2507 (QCdbus_request_name_allow_replacement)
2508 (QCdbus_request_name_replace_existing)
2509 (QCdbus_request_name_do_not_queue)
2510 (QCdbus_request_name_reply_primary_owner)
2511 (QCdbus_request_name_reply_in_queue)
2512 (QCdbus_request_name_reply_exists)
2513 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2514 (QCdbus_registered_serial, QCdbus_registered_method)
2515 (QCdbus_registered_signal): New Lisp objects.
2516 (XD_DEBUG_MESSAGE): Use sizeof.
2517 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2518 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2519 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2520 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2521 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2522 (xd_signature, xd_append_arg): Allow float for integer types.
2523 (xd_get_connection_references): New function.
2524 (xd_get_connection_address): Rename from xd_initialize.
2525 Return cached address.
2526 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2527 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2529 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
2530 Return number of refcounts.
2531 (Fdbus_get_unique_name): Make stronger parameter check.
2532 (Fdbus_message_internal): New defun.
2533 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2534 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2535 (Fdbus_send_signal, Fdbus_register_service)
2536 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2537 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2538 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2539 (Vdbus_compiled_version, Vdbus_runtime_version)
2540 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2541 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2542 (Vdbus_message_type_signal): New defvars.
2543 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2546 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2548 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2549 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2550 Do not assume ptrdiff_t is the same width as 'int'.
2552 * alloc.c: Handle unusual debugging option combinations.
2553 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2554 since the two debugging options are incompatible.
2555 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2557 (mem_init, mem_insert, mem_insert_fixup):
2558 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2559 (NEED_MEM_INSERT): Remove; no longer needed.
2561 2012-04-22 Leo Liu <sdl.web@gmail.com>
2563 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2565 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2567 * sysdep.c [__FreeBSD__]: Minor cleanups.
2568 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2569 Use Emacs indenting style more consistently. Avoid some casts.
2570 Use 'double' consistently rather than mixing 'float' and 'double'.
2572 2012-04-21 Eduard Wiebe <usenet@pusto.de>
2574 * sysdep.c (list_system_processes, system_process_attributes):
2575 Add implementation for FreeBSD (Bug#5243).
2577 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2579 * lisp.mk (lisp): Update.
2581 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2583 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2584 It is never used otherwise.
2586 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2588 * print.c (print_preprocess): Only check print_depth if print-circle
2590 (print_object): Check for cycles even when print-circle is nil and
2591 print-gensym is t, but only check print_depth if print-circle is nil.
2593 2012-04-20 Chong Yidong <cyd@gnu.org>
2595 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2596 set the status to "failed" and ensure that sentinel is run.
2598 2012-04-20 Glenn Morris <rgm@gnu.org>
2600 * process.c (Fset_process_inherit_coding_system_flag)
2601 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
2602 (Fmake_network_process, Fmake_serial_process): Doc fix.
2604 2012-04-20 Eli Zaretskii <eliz@gnu.org>
2606 * xdisp.c (string_buffer_position_lim): Limit starting position to
2608 (set_cursor_from_row): If called for a mode-line or header-line
2609 row, return zero immediately.
2610 (try_cursor_movement): If inside continuation line, don't back up
2611 farther than the first row after the header line, if any.
2612 Don't consider the header-line row as "partially visible", even if
2613 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2615 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
2617 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2620 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
2621 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
2623 configure: new option --enable-gcc-warnings (Bug#11207)
2624 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2625 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2626 (ALL_CFLAGS): Use new macros rather than old.
2627 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2628 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2629 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2630 -Wunused-result, -Wunused-variable. This should go away once
2631 the Emacs and Gnulib regex code is merged.
2632 (xmalloc, xrealloc): Now static.
2634 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2636 * dired.c (Fsystem_groups): Remove unused local.
2638 2012-04-17 Glenn Morris <rgm@gnu.org>
2640 * dired.c (Fsystem_users): Doc fix.
2642 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2644 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2645 (syms_of_dired): Add them.
2647 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2649 Fix minor alloc.c problems found by static checking.
2650 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2651 New extern decls, to avoid calling undeclared functions.
2652 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2653 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2654 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2655 (NEED_MEM_INSERT): New macro.
2656 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
2657 Remove one incorrect comment and fix another.
2659 Fix minor ralloc.c problems found by static checking.
2660 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2661 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2662 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2663 (r_alloc_sbrk): Now static.
2665 Improve ralloc.c interface checking.
2666 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2667 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2668 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2669 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2670 [REL_ALLOC]: ... to here, to check interface.
2671 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2672 Remove decls. This fixes an "It stinks!".
2674 * alloc.c (which_symbols): Fix alignment issue / type clash.
2676 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2678 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2679 (struct Lisp_Misc_Any): Likewise.
2680 (struct Lisp_Free): Likewise.
2681 * alloc.c (union aligned_Lisp_Symbol): Define.
2682 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2683 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2684 (union aligned_Lisp_Misc): Define.
2685 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2686 aligned_Lisp_Misc instead of union Lisp_Misc.
2687 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
2689 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2691 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2692 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2693 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2694 * s/netbsd.h, s/sol2-6.h:
2695 Remove definition of GC_MARK_STACK, since the default now works.
2696 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2697 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2698 no longer the default.
2699 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2701 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
2703 * lread.c (lisp_file_lexically_bound_p):
2704 Fix hang at ";-*-\n" (bug#11238).
2706 2012-04-14 Eli Zaretskii <eliz@gnu.org>
2708 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2709 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2711 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2713 * nsterm.m (constrainFrameRect): Always constrain when there is only
2714 one screen (Bug#10962).
2716 2012-04-13 Ken Brown <kbrown@cornell.edu>
2718 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2720 2012-04-13 Reuben Thomas <rrt@sc3d.org>
2722 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2724 2012-04-11 Daniel Colascione <dancol@dancol.org>
2726 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2727 against is gone. It's better to use vfork now so that when Cygwin
2728 gains a new, working vfork, we use it automatically (bug#10398).
2730 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2732 * window.c (save_window_save): Obey window-point-insertion-type.
2734 2012-04-11 Glenn Morris <rgm@gnu.org>
2736 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2738 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2740 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2742 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
2744 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2745 (force_quit_count): New var.
2746 (handle_interrupt): Use it.
2748 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
2750 * w32.c (w32_delayed_load): Record the full path of the library
2751 being loaded (bug#10424).
2753 2012-04-09 Glenn Morris <rgm@gnu.org>
2755 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2756 not just in the obarray, before snarfing them. (Bug#11036)
2758 * Makefile.in ($(leimdir)/leim-list.el):
2759 Pass EMACS rather than BUILT_EMACS.
2761 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2763 * process.c (make_process):
2764 * process.h: Add integer `gnutls_handshakes_tried' member to
2767 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2768 Add convenience `GNUTLS_LOG2i' macro.
2770 * gnutls.c (gnutls_log_function2i): Convenience log function.
2771 (emacs_gnutls_read): Use new log functions,
2772 `gnutls_handshakes_tried' process member, and
2773 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2774 attempts per process (connection).
2776 2012-04-09 Chong Yidong <cyd@gnu.org>
2778 * eval.c (Fuser_variable_p, user_variable_p_eh)
2779 (lisp_indirect_variable): Functions deleted.
2780 (Fdefvar): Caller changed.
2782 * callint.c (Finteractive, Fcall_interactively):
2783 * minibuf.c (Fread_variable): Callers changed.
2785 2012-04-09 Eli Zaretskii <eliz@gnu.org>
2787 * xdisp.c (set_cursor_from_row): If the display string appears in
2788 the buffer at position that is closer to point than the position
2789 after the display string, display the cursor on the first glyph of
2790 the display string. Fixes cursor display when a 'display' text
2791 property immediately follows invisible text. (Bug#11094)
2793 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2795 composite.c: use 'double' consistently
2796 * composite.c (get_composition_id): Use 'double' consistently
2797 instead of converting 'float' to 'double' and vice versa; this is
2798 easier to understand and avoids a GCC warning.
2800 2012-04-09 Glenn Morris <rgm@gnu.org>
2802 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2803 preparation for dumping it with emacs. (Bug#4789)
2804 (leimdir): New variable.
2805 ($(leimdir)/leim-list.el): New rule.
2806 (emacs$(EXEEXT)): Depend on leim-list.el.
2808 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2809 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2810 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2812 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2814 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2817 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
2819 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2820 Remove unused local variable.
2822 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2824 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2825 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2826 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2827 objects, as mark_maybe_pointer will catch them otherwise.
2828 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2829 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2831 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2833 Fix typo that broke non-Windows builds.
2834 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2836 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2838 Support building on MS-Windows with libxml2.
2840 * makefile.w32-in (OBJ2): Add xml.$(O).
2841 (GLOBAL_SOURCES): Add xml.c.
2842 ($(BLD)/xml.$(O)): New dependency list.
2844 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2845 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2846 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2847 [!WINDOWSNT]: New macros.
2848 (init_libxml2_functions, libxml2_loaded_p): New functions.
2849 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2850 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2851 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2852 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2854 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2855 Call init_libxml2_functions before calling libxml2 functions.
2856 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2858 * emacs.c: Don't include libxml/parser.h.
2859 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2860 xmlCleanupParser directly.
2862 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2864 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2866 * indent.c (Fvertical_motion): If there is a display string at
2867 point, use it.vpos to compute how many lines to backtrack after
2868 move_it_to point. (Bug#11133)
2870 2012-04-06 Eli Zaretskii <eliz@gnu.org>
2872 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2873 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2874 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2875 macros related to unification of CJK characters. For the details,
2876 see the discussion following the message here:
2877 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2879 2012-04-04 Chong Yidong <cyd@gnu.org>
2881 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2883 2012-04-01 Eli Zaretskii <eliz@gnu.org>
2885 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2886 instead of alloca. (Bug#11138)
2888 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2890 * w32menu.c (is_simple_dialog): Properly check lisp types.
2893 2012-03-31 Eli Zaretskii <eliz@gnu.org>
2895 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2896 position we get to after a call to move_it_to fails the
2897 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2898 only if we wind up in a string from display property. (Bug#11063)
2900 * window.c (Fdelete_other_windows_internal): Invalidate the row
2901 and column information about mouse highlight, so that redisplay
2902 restores it after reallocating the glyph matrices. (Bug#7464)
2904 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2905 string comes from a `display' text property, use the buffer
2906 position of that property as if we actually saw that position in
2908 (move_it_by_lines): Remove the assertion that
2909 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2910 violated when there's a before-string at the beginning of a line.
2913 2012-03-30 Eli Zaretskii <eliz@gnu.org>
2915 * xdisp.c (append_space_for_newline): If the default face was
2916 remapped, use the remapped face for the appended newline.
2917 (extend_face_to_end_of_line): Use the remapped default face for
2918 extending the face to the end of the line.
2919 (display_line): Call extend_face_to_end_of_line when the default
2920 face was remapped. (Bug#11068)
2922 2012-03-29 Eli Zaretskii <eliz@gnu.org>
2924 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2926 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2928 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2930 2012-03-27 Glenn Morris <rgm@gnu.org>
2932 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2935 2012-03-26 Kenichi Handa <handa@m17n.org>
2937 * dispextern.h (struct glyph): Fix previous change. Change the
2938 bit length of glyphless.ch to 25 (Bug#11082).
2940 2012-03-26 Chong Yidong <cyd@gnu.org>
2942 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2943 (command_loop_1): Use it; inhibit selection update for
2944 handle-select-window too (Bug#8996).
2946 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2948 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
2950 2012-03-25 Kenichi Handa <handa@m17n.org>
2952 * dispextern.h (struct glyph): Change the bit length of
2953 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2955 2012-03-24 Eli Zaretskii <eliz@gnu.org>
2957 * s/ms-w32.h (tzname): Include time.h before redirecting to
2958 _tzname. Fixes the MSVC build. (Bug#9960)
2960 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2962 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2965 * xterm.c (XTread_socket): Only modify handling_signal if
2966 !SYNC_INPUT. (Bug#11080)
2968 2012-03-23 Eli Zaretskii <eliz@gnu.org>
2970 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2971 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2972 when fetching a multibyte character consumes more bytes than
2973 CHAR_BYTES returns, due to unification of CJK characters in
2974 string_char. (Bug#11073)
2976 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2978 * process.c (wait_reading_process_output): Handle pty disconnect
2979 by refraining from sending oneself a SIGCHLD (bug#10933).
2981 2012-03-22 Chong Yidong <cyd@gnu.org>
2983 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2985 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
2986 Mark string as coming from a prefix property.
2987 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2988 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2990 2012-03-21 Chong Yidong <cyd@gnu.org>
2992 * xfaces.c (Vface_remapping_alist): Doc fix.
2994 2012-03-20 Eli Zaretskii <eliz@gnu.org>
2996 * w32proc.c (Fw32_set_console_codepage)
2997 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3000 2012-03-20 Chong Yidong <cyd@gnu.org>
3002 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3003 to reflect default non-nil value of redisplay-dont-pause.
3005 2012-03-19 Kenichi Handa <handa@m17n.org>
3007 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3008 it fit in a valid range (Bug#11003).
3010 2012-03-18 Eli Zaretskii <eliz@gnu.org>
3012 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3013 that is not from display property, accept the row as a "cursor
3014 row" if one of the string's character has a non-nil `cursor'
3015 property. Fixes cursor positioning when there are newlines in
3016 overlay strings, e.g. in icomplete.el. (Bug#11035)
3018 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3020 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3022 2012-03-12 Chong Yidong <cyd@gnu.org>
3024 * eval.c (inhibit_lisp_code): Rename from
3025 inhibit_window_configuration_change_hook; move from window.c.
3027 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3028 * window.c (run_window_configuration_change_hook)
3029 (syms_of_window): Callers changed.
3031 2012-03-11 Chong Yidong <cyd@gnu.org>
3033 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3035 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3037 2012-03-10 Chong Yidong <cyd@gnu.org>
3039 * frame.c (other_visible_frames): Don't assume the selected frame
3040 is visible (Bug#10955).
3042 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3044 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3046 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3048 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3049 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3052 2012-03-03 Glenn Morris <rgm@gnu.org>
3054 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
3056 2012-03-02 Eli Zaretskii <eliz@gnu.org>
3058 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3059 position past the first glyph_row that ends at ZV. (Bug#10902)
3060 (redisplay_window, next_element_from_string): Fix typos in
3062 (redisplay_window): Pass to move_it_vertically the margin in
3063 pixels, not in screen lines.
3065 2012-03-02 Glenn Morris <rgm@gnu.org>
3067 * buffer.c (buffer-list-update-hook): Doc fix.
3069 2012-02-29 Eli Zaretskii <eliz@gnu.org>
3071 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3072 push_it before setting up the iterator for the first overlay
3073 string, even if we have an empty string loaded.
3074 (next_overlay_string): If there's an empty string on the iterator
3075 stack, pop the stack. (Bug#10903)
3077 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3079 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3080 Suggested by Stefan Monnier in
3081 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3082 * alloc.c (widen_to_Lisp_Object): New static function.
3083 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3084 and widening them to Lisp_Objects. This would work even if
3085 USE_LSB_TAG is defined and wide integers are used, which might
3086 happen in a future version of Emacs.
3088 2012-02-25 Chong Yidong <cyd@gnu.org>
3090 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3093 * xselect.c (Fx_selection_exists_p): Doc fix.
3094 (x_clipboard_manager_save_all): Print an informative message
3095 before saving to clipboard manager.
3097 2012-02-24 Chong Yidong <cyd@gnu.org>
3099 * keyboard.c (process_special_events): Handle all X selection
3100 requests in kbd_buffer, not just the next one (Bug#8869).
3102 2012-02-23 Chong Yidong <cyd@gnu.org>
3104 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3105 call when setting menu-bar-lines and tool-bar-lines parameters.
3106 (unwind_create_frame_1): New helper function.
3108 * window.c (inhibit_window_configuration_change_hook): New var.
3109 (run_window_configuration_change_hook): Obey it.
3110 (syms_of_window): Initialize it.
3112 2012-02-22 Chong Yidong <cyd@gnu.org>
3114 * xterm.c (x_draw_image_relief): Add missing type check for
3115 Vtool_bar_button_margin (Bug#10743).
3117 2012-02-21 Chong Yidong <cyd@gnu.org>
3119 * fileio.c (Vfile_name_handler_alist): Doc fix.
3121 * buffer.c (Fget_file_buffer): Protect against invalid file
3122 handler return value.
3124 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3126 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3127 when computing $valmask.
3129 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3130 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3131 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3132 It's useless in that case, and it can cause problems on hosts
3133 that allocate halves of EMACS_INT values separately.
3134 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3135 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3136 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3137 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3138 it avoids undefined behavior on hosts where shifting right by more
3139 than the word width has undefined behavior.
3141 2012-02-19 Chong Yidong <cyd@gnu.org>
3143 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3144 (Funhandled_file_name_directory, Ffile_name_as_directory)
3145 (Fdirectory_file_name, Fexpand_file_name)
3146 (Fsubstitute_in_file_name): Protect against invalid file handler
3147 return values (Bug#10845).
3149 2012-02-18 Eli Zaretskii <eliz@gnu.org>
3151 * .gdbinit (pitx): Fix incorrect references to fields of the
3154 2012-02-17 Chong Yidong <cyd@gnu.org>
3156 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3158 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3160 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3161 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3163 2012-02-15 Chong Yidong <cyd@gnu.org>
3165 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3166 marked as special. Also, starting docstrings with * is obsolete.
3168 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3170 * gnutls.c (emacs_gnutls_write): Fix last change.
3172 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3174 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3177 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3179 * keymap.c (Fsingle_key_description): Handle char ranges.
3181 2012-02-12 Chong Yidong <cyd@gnu.org>
3183 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3184 as that creates a dangerous corner case.
3186 * window.c (Fdelete_window_internal): Invalidate the mouse
3187 highlight (Bug#9904).
3189 2012-02-12 Glenn Morris <rgm@gnu.org>
3191 * xselect.c (Fx_own_selection_internal)
3192 (Fx_get_selection_internal, Fx_disown_selection_internal)
3193 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3194 * nsselect.m (Fx_own_selection_internal)
3195 (Fx_disown_selection_internal, Fx_selection_exists_p)
3196 (Fx_selection_owner_p, Fx_get_selection_internal):
3197 Sync docs and argument specs with the xselect.c versions.
3199 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3201 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3203 2012-02-11 Eli Zaretskii <eliz@gnu.org>
3205 * w32select.c (Fx_selection_exists_p): Sync doc string and
3206 argument list with xselect.c. (Bug#10783)
3208 * w16select.c (Fx_selection_exists_p): Sync doc string and
3209 argument list with xselect.c. (Bug#10783)
3211 2012-02-10 Glenn Morris <rgm@gnu.org>
3213 * fns.c (Fsecure_hash): Doc fix.
3215 2012-02-09 Kenichi Handa <handa@m17n.org>
3217 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3219 2012-02-07 Chong Yidong <cyd@gnu.org>
3221 * buffer.c (Fbuffer_local_variables)
3222 (buffer_lisp_local_variables): Handle unbound vars correctly;
3223 don't let Qunbound leak into Lisp.
3225 2012-02-07 Glenn Morris <rgm@gnu.org>
3227 * image.c (Fimagemagick_types): Doc fix.
3229 * image.c (imagemagick-render-type): Change it from a lisp object
3230 to an integer. Move the doc here from the lisp manual.
3231 Treat all values not equal to 0 the same.
3233 2012-02-06 Chong Yidong <cyd@gnu.org>
3235 * doc.c (store_function_docstring): Avoid applying docstring of
3236 alias to base function (Bug#2603).
3238 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3240 * .gdbinit (pp1, pv1): Remove redundant defines.
3243 2012-02-04 Chong Yidong <cyd@gnu.org>
3245 * nsterm.m: Declare a global (Bug#10694).
3247 2012-02-04 Eli Zaretskii <eliz@gnu.org>
3249 * w32.c (get_emacs_configuration_options):
3250 Include --enable-checking, if specified, in the return value.
3252 2012-02-04 Martin Rudalics <rudalics@gmx.at>
3254 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3255 after rounding frame sizes. (Bug#9723)
3257 2012-02-04 Eli Zaretskii <eliz@gnu.org>
3259 * keyboard.c (adjust_point_for_property): Don't position point
3260 before BEGV. (Bug#10696)
3262 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3264 Handle overflow when computing char display width (Bug#9496).
3265 * character.c (char_width): Return EMACS_INT, not int.
3266 (char_width, c_string_width): Check for overflow when
3267 computing the width; this is possible now that individual
3268 characters can have unbounded width. Problem introduced
3269 by merge from Emacs 23 on 2012-01-19.
3271 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
3273 * dbusbind.c (Fdbus_register_method): Mention the return value
3274 :ignore in the docstring.
3276 2012-02-02 Glenn Morris <rgm@gnu.org>
3278 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3280 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3281 Unconditionally set to t. (Bug#10673)
3282 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3283 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3284 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3286 2012-02-02 Kenichi Handa <handa@m17n.org>
3288 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3289 0, do not call append_composite_glyph.
3291 2012-02-02 Kenichi Handa <handa@m17n.org>
3293 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3295 (x_produce_glyphs): If the component of a composition is a null
3296 string, set it->pixel_width to 1 to avoid zero-width glyph.
3298 2012-02-01 Eli Zaretskii <eliz@gnu.org>
3300 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3301 first 2 arguments are identical. This makes inserting large
3302 output from a subprocess an order of magnitude faster on
3303 MS-Windows, where all sbrk'ed memory is always contiguous.
3305 2012-01-31 Glenn Morris <rgm@gnu.org>
3307 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3308 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3309 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3311 2012-01-29 Glenn Morris <rgm@gnu.org>
3313 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3315 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3317 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3319 2012-01-28 Chong Yidong <cyd@gnu.org>
3321 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3323 2012-01-26 Chong Yidong <cyd@gnu.org>
3325 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3327 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3328 repeat counts (Bug#10507).
3330 2012-01-26 Glenn Morris <rgm@gnu.org>
3332 * lread.c (syms_of_lread): Doc fix.
3334 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3336 * coding.c (encode_designation_at_bol): Change return value to
3339 2012-01-25 Chong Yidong <cyd@gnu.org>
3341 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3343 2012-01-21 Chong Yidong <cyd@gnu.org>
3345 * floatfns.c (Fcopysign): Make the second argument non-optional,
3346 since nil is not allowed anyway.
3348 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3350 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3351 (send_process): Likewise.
3353 2012-01-19 Martin Rudalics <rudalics@gmx.at>
3355 * window.c (save_window_save, Fcurrent_window_configuration)
3356 (Vwindow_persistent_parameters): Do not use Qstate.
3357 Rewrite doc-strings.
3359 2012-01-19 Kenichi Handa <handa@m17n.org>
3361 * character.c (char_width): New function.
3362 (Fchar_width, c_string_width, lisp_string_width):
3363 Use char_width (Bug#9496).
3365 2012-01-16 Martin Rudalics <rudalics@gmx.at>
3367 * window.c (Vwindow_persistent_parameters): New variable.
3368 (Fset_window_configuration, save_window_save): Handle persistent
3371 2012-01-14 Eli Zaretskii <eliz@gnu.org>
3373 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3374 thrashing the stack of the thread. (Bug#9087)
3376 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3378 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3380 2012-01-11 Eli Zaretskii <eliz@gnu.org>
3382 * xdisp.c (rows_from_pos_range): Handle the case where the
3383 highlight ends on a newline. (Bug#10464)
3384 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3385 he end column for display of highlight that ends on a newline
3388 2012-01-11 Glenn Morris <rgm@gnu.org>
3390 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3391 from load-path also when installation-directory is nil. (Bug#10208)
3393 2012-01-10 Glenn Morris <rgm@gnu.org>
3395 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3397 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3398 Update template values to be closer to their typical values these days.
3400 2012-01-09 Eli Zaretskii <eliz@gnu.org>
3402 * xdisp.c (rows_from_pos_range): Accept additional argument
3403 DISP_STRING, and accept any glyph in a row whose object is that
3404 string as eligible for mouse highlight. Fixes mouse highlight of
3405 display strings from overlays. (Bug#10464)
3407 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
3409 emacs: fix an auto-save permissions race condition (Bug#10400)
3410 * fileio.c (auto_saving_dir_umask): New static var.
3411 (Fmake_directory_internal): Use it.
3412 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3413 creating the directory. The old code temporarily assigns
3414 too-generous permissions to the directory.
3415 (do_auto_save_eh): Clear it.
3416 (Fdo_auto_save): Catch all errors, not just file errors, so
3417 that the var is always cleared.
3419 2012-01-07 Eli Zaretskii <eliz@gnu.org>
3421 * search.c (scan_buffer): Pass character positions to
3422 know_region_cache, not byte positions. (Bug#6540)
3424 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
3426 * w32.c (sys_rename): Report EXDEV when rename of a directory
3427 fails because the target is on another logical disk. (Bug#10284)
3429 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3431 * xterm.c (x_embed_request_focus): New function.
3433 * xterm.h: Add prototype.
3435 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3437 2012-01-05 Glenn Morris <rgm@gnu.org>
3439 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3441 2012-01-01 Eli Zaretskii <eliz@gnu.org>
3443 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3444 Load gnutls_transport_set_lowat only if GnuTLS version is below
3446 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3447 GnuTLS versions below 2.11.1.
3449 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3451 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3452 to the doc string advising against its use for altering the way
3453 windows are scrolled.
3455 2011-12-28 Kenichi Handa <handa@m17n.org>
3457 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3458 coding-system ASCII compatible only when it does not produce BOM
3459 on encoding (Bug#10383).
3461 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3463 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3465 (create_and_show_popup_menu): Always use menu_position_func for
3468 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3470 * callint.c (Fcall_interactively): Don't truncate prompt string.
3472 2011-12-23 Eli Zaretskii <eliz@gnu.org>
3474 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3475 property that ends at ZV, so that the bidi iteration could be
3476 resumed from there (after widening). (Bug#10360)
3478 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3480 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3482 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3484 * nsterm.m (x_free_frame_resources):
3485 Release f->output_data.ns->miniimage.
3486 (ns_index_color): Fix indentation. Do not retain
3487 color_table->colors[i].
3489 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3492 * nsfns.m (x_set_background_color): Assign return value from
3493 ns_index_color to face-background instead of NSColor*.
3494 (ns_implicitly_set_icon_type): Fix indentation.
3495 Change assignment in for loop to comparison.
3497 * emacs.c (ns_pool): New variable.
3498 (main): Assign ns_pool.
3499 (Fkill_emacs): Call ns_release_autorelease_pool.
3501 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3502 autorelease fdesc, release fdAttrs and tdict.
3503 (ns_get_covering_families): Release charset.
3504 (ns_findfonts): Release NSFontDescriptor created with new.
3505 (ns_uni_to_glyphs): Fix indentation.
3506 (setString): Release attrStr before assigning new value.
3508 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3510 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3512 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3513 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3515 2011-12-18 David Reitter <reitter@cmu.edu>
3517 * nsterm.m (ns_term_init): Subscribe for notifications
3518 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3519 to method trackingNotification in EmacsMenu.
3521 * nsmenu.m (trackingMenu): New variable.
3522 (trackingNotification): New method (from Aquamacs).
3523 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3524 from Aquamacs (Bug#7030).
3526 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3528 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3529 (symbol_to_nsstring): Fix indentation.
3530 (ns_symbol_to_pb): New function.
3531 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3532 (Fns_rotate_cut_buffers_internal): Remove.
3533 (Fns_store_selection_internal): Rename from
3534 Fns_store_cut_buffer_internal.
3535 (ns_get_foreign_selection, Fx_own_selection_internal)
3536 (Fx_disown_selection_internal, Fx_selection_exists_p)
3537 (Fns_get_selection_internal, Fns_store_selection_internal):
3538 Use ns_symbol_to_pb and check if return value is nil.
3539 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3540 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
3541 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3542 renamed to Sns_store_selection_internal.
3543 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3544 and remove this function.
3545 (ns_handle_selection_clear): Remove, never used.
3546 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3549 2011-12-17 Ken Brown <kbrown@cornell.edu>
3551 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3552 GID is unknown (Bug#10257).
3554 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3556 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3557 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3558 which caused a build failure on GNU/Linux IA-64. This problem was
3559 introduced by my 2011-10-07 patch.
3561 2011-12-15 Juri Linkov <juri@jurta.org>
3563 * image.c (imagemagick_error): New function. (Bug#10112)
3564 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3565 Use `imagemagick_error' where ImageMagick functions return
3567 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3570 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3572 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3573 fill background (Bug#8992).
3575 2011-12-13 Martin Rudalics <rudalics@gmx.at>
3577 * window.c (Vwindow_combination_resize)
3578 (Vwindow_combination_limit): Use t instead of non-nil in
3580 (Vrecenter_redisplay): Add first sentence of doc-string on
3582 (Frecenter): Fix doc-string typo.
3584 2011-12-11 Kenichi Handa <handa@m17n.org>
3586 * coding.c (Funencodable_char_position): Pay attention to the
3587 buffer text relocation (Bug#9389).
3589 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3591 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3592 gtk_init (Bug#10100).
3594 2011-12-10 Eli Zaretskii <eliz@gnu.org>
3596 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3597 IT->string is nil. (Bug#10263)
3599 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3601 * nsterm.h (x_free_frame_resources): Declare.
3603 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3604 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3606 * nsterm.h (ns_get_defaults_value): Declare.
3608 * nsterm.m (ns_default): Call ns_get_defaults_value.
3610 2011-12-09 Eli Zaretskii <eliz@gnu.org>
3612 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3615 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3617 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3618 that where the value of an _OBJC_* symbol points to is in the .bss
3619 section (Bug#10240).
3621 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3623 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
3624 after the loop to call ccl_driver at least once (Bug#8619).
3626 2011-12-08 Kenichi Handa <handa@m17n.org>
3628 * ftfont.c (get_adstyle_property): Fix previous change
3631 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
3633 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3634 dirs from the default value of EMACSLOADPATH (bug#10208).
3636 2011-12-07 Glenn Morris <rgm@gnu.org>
3638 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3639 installation and source directories as well. (Bug#10208)
3641 2011-12-06 Chong Yidong <cyd@gnu.org>
3643 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3645 2011-12-06 Glenn Morris <rgm@gnu.org>
3647 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3648 as an error, not just -1. (Bug#10217)
3650 2011-12-05 Chong Yidong <cyd@gnu.org>
3652 * keyboard.c (process_special_events): New function.
3653 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3655 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3657 * coding.c (encode_designation_at_bol): Don't use uninitialized
3658 local variable (Bug#9318).
3660 2011-12-05 Kenichi Handa <handa@m17n.org>
3662 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3663 return Qnil (Bug#8046, Bug#10193).
3665 2011-12-05 Kenichi Handa <handa@m17n.org>
3667 * coding.c (encode_designation_at_bol): New args charbuf_end and
3668 dst. Return the number of produced bytes. Callers changed.
3669 (coding_set_source): Return how many bytes coding->source was
3671 (coding_set_destination): Return how many bytes
3672 coding->destination was relocated.
3673 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
3674 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
3676 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3678 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3679 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3682 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3684 The following changes are to fix Bug#9318.
3686 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
3687 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3688 (encode_coding_iso_2022, encode_coding_sjis)
3689 (encode_coding_big5, encode_coding_charset): Use the above macros.
3691 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
3693 * lisp.h (process_quit_flag): Fix external declaration.
3695 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3697 Don't macro-inline non-performance-critical code.
3698 * eval.c (process_quit_flag): New function.
3699 * lisp.h (QUIT): Use it.
3701 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3703 * nsfns.m (get_geometry_from_preferences): New function.
3704 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3706 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3708 * emacs.c (Qkill_emacs): Define.
3709 (syms_of_emacs): Initialize it.
3710 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3711 Qquit_flag to `kill-emacs' instead.
3712 (quit_throw_to_read_char): Add parameter `from_signal'.
3713 All callers changed. Call Fkill_emacs if requested and safe.
3714 * lisp.h (QUIT): Call Fkill_emacs if requested.
3716 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3718 * widget.c (update_wm_hints): Return if wmshell is null.
3719 (widget_update_wm_size_hints): New function.
3721 * widget.h (widget_update_wm_size_hints): Declare.
3723 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3724 widget_update_wm_size_hints (Bug#10104).
3726 2011-12-03 Eli Zaretskii <eliz@gnu.org>
3728 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3729 before a newline, prepare the bidi iterator for consuming the
3730 newline, and keep the current paragraph direction. (Bug#10183)
3731 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
3733 2011-12-02 Juri Linkov <juri@jurta.org>
3735 * search.c (Fword_search_regexp): New Lisp function created from
3736 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3737 (Fword_search_backward, Fword_search_forward)
3738 (Fword_search_backward_lax, Fword_search_forward_lax):
3739 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3740 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3742 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3744 * fileio.c (Finsert_file_contents): Move after-change-function call
3745 to before the "handled:" label, since all "goto handled" appear in
3746 cases where the *-change-functions have already been properly called
3749 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3751 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3752 waiting for input. (Bug#10169)
3754 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3756 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3757 verifies glyph row's hash code--we have just reallocated the
3758 glyphs, so their contents can be complete garbage. (Bug#10164)
3760 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
3762 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3764 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3766 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3767 attributes are tested _before_ calling verify_row_hash, to protect
3768 against GCC re-ordering of the tests. (Bug#10164)
3770 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3772 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3774 * xterm.c (handle_one_xevent): Only set async_visible and friends
3775 if net_wm_state_hidden_seen is non-zero (Bug#10002)
3776 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
3777 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3779 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3781 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3782 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3783 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3784 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3785 All uses changed to use GCPRO1 etc.
3786 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3787 Revert to old implementation (i.e., before 2011-03-11).
3789 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3791 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3792 of scroll runs so as to avoid assigning disabled bogus rows and
3793 unnecessary graphics copy operations.
3795 2011-11-27 Eli Zaretskii <eliz@gnu.org>
3797 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3798 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3799 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3800 (malloc, free, realloc, calloc): Redirect to e_* only when
3803 * lisp.h (GCTYPEBITS): Move before first use.
3804 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3805 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3806 this macro definition.
3808 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3811 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3813 * gtkutil.c (xg_create_frame_widgets):
3814 Call gtk_window_set_has_resize_grip (FALSE) if that function is
3815 present with Gtk+ 2.0.
3817 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3819 * fileio.c (Finsert_file_contents): Undo previous change; see
3820 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3822 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3824 Rename locals to avoid shadowing.
3825 * fileio.c (Finsert_file_contents):
3826 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3827 * process.c (wait_reading_process_output):
3828 Rename inner 'proc' to 'p' to avoid shadowing.
3829 Indent for consistency with usual Emacs style.
3831 2011-11-25 Eli Zaretskii <eliz@gnu.org>
3833 * xdisp.c (redisplay_window): If cursor row is not fully visible
3834 after recentering, and scroll-conservatively is set to a large
3835 number, scroll window by a few more lines to make the cursor fully
3836 visible and out of scroll-margin. (Bug#10105)
3837 (start_display): Don't move to the next line if the display should
3838 start at a newline that is part of a display vector or an overlay
3841 2011-11-24 Juri Linkov <juri@jurta.org>
3843 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3844 after the `MagickPingImage' call. (Bug#10112)
3846 2011-11-23 Chong Yidong <cyd@gnu.org>
3848 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3850 2011-11-23 Martin Rudalics <rudalics@gmx.at>
3852 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3853 making another buffer current. (Bug#10114)
3855 2011-11-23 Glenn Morris <rgm@gnu.org>
3857 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3859 2011-11-23 Chong Yidong <cyd@gnu.org>
3861 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3862 using it (Bug#5984).
3864 2011-11-22 Eli Zaretskii <eliz@gnu.org>
3866 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3867 and header-lines, as they don't have one computed for them.
3870 * .gdbinit (prow): Make displayed values more self-explaining.
3871 Add row's hash code.
3873 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3875 * process.c (wait_reading_process_output): Fix asynchrounous
3876 GnuTLS socket handling on some versions of the GnuTLS library.
3877 (wait_reading_process_output): Add comment and URL.
3879 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3881 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3883 2011-11-21 Chong Yidong <cyd@gnu.org>
3885 * window.c (Fnext_window, Fprevious_window): Doc fix.
3887 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3889 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3891 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3893 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3895 2011-11-20 Martin Rudalics <rudalics@gmx.at>
3897 * window.c (Fset_window_combination_limit): Rename argument
3899 (Vwindow_combination_limit): Remove "status" from doc-string.
3901 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3903 * m/ibms390.h: Remove.
3904 * m/ibms390x.h: Don't include "ibms390.h".
3906 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3908 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3909 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3911 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3913 * casetab.c (Fset_case_table):
3914 * charset.c (Fcharset_after): Fix typos.
3916 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
3918 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3919 Otherwise, valgrind does not work on some platforms.
3920 Problem reported by Andreas Schwab in
3921 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3922 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3923 is set, removing the need for VIRT_ADDRESS_VARIES.
3924 (PURE_P): Use a more-efficient implementation that needs just one
3925 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3926 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3927 to 4 (xorl, subq, cmpq, setbe).
3928 * alloc.c (pure): Always extern now, since that's the
3929 VIRT_ADDR_VARIES behavior.
3930 (PURE_POINTER_P): Use a single comparison, not two, for
3931 consistency with the new puresize.h.
3932 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3933 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3934 Remove VIRT_ADDR_VARIES no longer needed.
3936 2011-11-19 Eli Zaretskii <eliz@gnu.org>
3938 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3939 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3940 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3941 behave as if the cursor position were at the window margin.
3943 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3944 and the cursor position is out of bounds, behave as if the cursor
3945 position were at the window margin. (Bug#10075)
3947 2011-11-18 Chong Yidong <cyd@gnu.org>
3949 * window.c (Fwindow_combination_limit): Make first argument
3950 non-optional, since it is meaningless for live windows like the
3953 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3955 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3957 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3959 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3960 (graft_intervals_into_buffer): Simplify.
3962 2011-11-18 Eli Zaretskii <eliz@gnu.org>
3964 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3965 hash values of the two rows.
3966 (copy_row_except_pointers): Preserve the used[] arrays and the
3967 hash values of the two rows. (Bug#10035)
3968 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
3970 * xdisp.c (row_hash): New function, body extracted from
3971 compute_line_metrics.
3972 (compute_line_metrics): Call row_hash, instead of computing the
3975 * dispnew.c (verify_row_hash): Call row_hash for computing the
3976 hash code of a row, instead of duplicating code from xdisp.c.
3978 * dispextern.h (row_hash): Add prototype.
3980 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3982 * frame.c (delete_frame): Don't delete the terminal when the last
3983 X frame is closed if emacs is built with GTK toolkit.
3985 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
3987 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3989 2011-11-17 Martin Rudalics <rudalics@gmx.at>
3991 * window.c (Vwindow_splits): Rename to
3992 Vwindow_combination_resize. Suggested by Juri Linkov.
3993 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3996 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
3998 * nsfns.m (Fns_font_name):
3999 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
4001 2011-11-16 Martin Rudalics <rudalics@gmx.at>
4003 * window.h (window): Rename slot "nest" to "combination_limit".
4004 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4005 (Fset_window_nest): Rename to Fset_window_combination_limit.
4006 (Vwindow_nest): Rename to Vwindow_combination_limit.
4007 (recombine_windows, make_parent_window, make_window)
4008 (Fsplit_window_internal, saved_window)
4009 (Fset_window_configuration, save_window_save): Rename all
4010 occurrences of window_nest to window_combination_limit.
4012 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
4014 * image.c (imagemagick_load_image): Fix typo.
4016 2011-11-14 Eli Zaretskii <eliz@gnu.org>
4018 * xdisp.c (display_line): Move the call to
4019 highlight_trailing_whitespace before the call to
4020 compute_line_metrics, since the latter needs to see the final
4021 faces of all the glyphs to compute ROW's hash value.
4022 Fixes assertion violations in row_equal_p. (Bug#10035)
4024 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
4026 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4027 just return (bug#10044).
4029 2011-11-12 Eli Zaretskii <eliz@gnu.org>
4031 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4032 with user-defined heap size. Bump the default size of the temacs
4033 heap to 27MB, to avoid memory warning when running temacs.
4034 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4036 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4037 current_matrix and desired_matrix. (Bug#9990)
4038 (verify_row_hash) [XASSERTS]: New function.
4039 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4040 that the hash value of glyph rows is correct.
4042 2011-11-12 Martin Rudalics <rudalics@gmx.at>
4044 * window.h (window): Remove splits slot.
4045 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4046 (Fdelete_other_windows_internal, make_parent_window)
4047 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4048 (Fset_window_configuration, save_window_save): Don't deal with
4049 split status of windows.
4050 (saved_window): Remove splits slot.
4051 (Vwindow_splits): Rewrite doc-string.
4053 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4055 * xfns.c (unwind_create_frame):
4056 * nsfns.m (unwind_create_frame):
4057 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4058 Vframe_list (Bug#9999).
4060 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4062 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
4064 2011-11-11 Kenichi Handa <handa@m17n.org>
4066 * callproc.c (Fcall_process): Set the member dst_multibyte of
4069 2011-11-11 Johan Bockgård <bojohan@gnu.org>
4071 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4072 avoid a crash (bug#9496).
4074 2011-11-09 Chong Yidong <cyd@gnu.org>
4076 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4077 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4079 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4081 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4083 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4085 Avoid some portability problems by eschewing 'extern inline' functions.
4086 The trivial performance wins aren't worth the portability hassles; see
4087 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4089 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4090 (window_box_width, window_box_left, window_box_left_offset)
4091 (window_box_right, window_box_right_offset): Undo previous change,
4092 by removing the "extern"s.
4093 * intervals.c (adjust_intervals_for_insertion)
4094 (adjust_intervals_for_deletion): Undo previous change,
4095 making these static again.
4096 (offset_intervals, temp_set_point_both, temp_set_point)
4097 (copy_intervals_to_string): No longer inline.
4098 * xdisp.c (window_text_bottom_y, window_box_width)
4099 (window_box_height, window_box_left_offset)
4100 (window_box_right_offset, window_box_left, window_box_right)
4101 (window_box): No longer inline.
4103 2011-11-08 Chong Yidong <cyd@gnu.org>
4105 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
4106 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4107 Signal an error if not a live window.
4108 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4109 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4111 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
4113 * lisp.h (syms_of_abbrev): Remove declaration.
4114 Reported by CHENG Gao <chenggao@royau.me>.
4116 2011-11-07 Eli Zaretskii <eliz@gnu.org>
4118 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4119 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4120 of temacs in GUI mode.
4122 2011-11-07 Martin Rudalics <rudalics@gmx.at>
4124 * window.h: Declare delete_all_child_windows instead of
4125 delete_all_subwindows.
4126 * window.c (Fwindow_nest, Fset_window_nest)
4127 (Fset_window_new_total, Fset_window_new_normal)
4128 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4129 (delete_all_subwindows): Rename to delete_all_child_windows.
4130 (Fdelete_other_windows_internal, Fset_window_configuration):
4131 Call delete_all_child_windows instead of delete_all_subwindows.
4132 * frame.c (delete_frame): Call delete_all_child_windows instead
4133 of delete_all_subwindows.
4135 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4137 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4138 This is also needed for porting to any host where GC_MARK_STACK is
4139 not GC_MAKE_GCPROS_NOOPS.
4140 (which_symbols): Use it.
4142 2011-11-07 Kenichi Handa <handa@m17n.org>
4144 * coding.c (coding_set_destination): Check coding->src_pos only
4145 when coding->src_object is a buffer (bug#9910).
4147 * process.c (send_process): Set the member src_multibyte of coding
4148 to 0 (bug#9911) when sending a unibyte text.
4150 * callproc.c (Fcall_process): Set the member src_multibyte of
4151 process_coding to 0 (bug#9912).
4153 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4155 * xmenu.c (cleanup_widget_value_tree): New function.
4156 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4157 calling free_menubar_widget_value_tree directly (Bug#9830).
4159 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4161 Fix some portability problems with 'inline'.
4162 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4163 (window_box_width, window_box_left, window_box_left_offset)
4164 (window_box_right, window_box_right_offset): Declare extern.
4165 Otherwise, these inline functions do not conform to C99 and
4166 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4167 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4168 * intervals.c (adjust_intervals_for_insertion)
4169 (adjust_intervals_for_deletion): Now extern, because otherwise the
4170 extern inline functions 'offset_intervals' couldn't refer to it.
4171 (static_offset_intervals): Remove.
4172 (offset_intervals): Rewrite using the old contents of
4173 static_offset_intervals. The old version didn't conform to C99
4174 because an extern inline function contained a reference to an
4175 identifier with static linkage.
4177 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4179 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4182 2011-11-06 Eli Zaretskii <eliz@gnu.org>
4184 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4185 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4186 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4187 return Qleft_to_right.
4189 2011-11-06 Chong Yidong <cyd@gnu.org>
4191 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4192 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4193 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4194 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4195 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4196 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4197 (Fwindow_vscroll): Doc fix.
4198 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4199 argument, since it makes no sense to pass a live window and for
4200 consistency with window-child.
4202 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4204 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4207 2011-11-05 Jason Rumney <jasonr@gnu.org>
4209 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4210 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4212 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4213 bitwise arithmetic preventing use of unicode-sip and non-truetype
4216 2011-11-05 Eli Zaretskii <eliz@gnu.org>
4218 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4221 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4222 initialization code to keep similarity to xfns.c after changes
4225 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4227 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4228 (unwind_create_frame): New function (Bug#9943).
4229 (Fx_create_frame): Restructure code to be more similar to the one in
4230 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4231 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4232 Move terminal->reference_count++ just before making the frame official
4235 * nsterm.m (x_free_frame_resources): New function.
4236 (x_destroy_window): Move code to x_free_frame_resources.
4238 * xfns.c (unwind_create_frame): Fix comment.
4239 (Fx_create_frame, x_create_tip_frame):
4240 Move terminal->reference_count++ just before making the frame
4241 official. Move initialization of image_cache_refcount and
4242 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4244 2011-11-05 Eli Zaretskii <eliz@gnu.org>
4246 Support MSVC build with newer versions of Visual Studio.
4247 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4248 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4251 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4252 which are not supported by MSVC.
4253 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4254 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4256 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4258 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4260 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4262 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
4264 Support MSVC build with newer versions of Visual Studio.
4265 * w32.c: Don't include w32api.h for MSVC.
4266 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4268 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4269 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4270 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4271 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4273 (alloca) [_MSC_VER]: Define to _alloca.
4275 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4277 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4279 2011-11-04 Eli Zaretskii <eliz@gnu.org>
4281 * xdisp.c (note_mouse_highlight): If either of
4282 previous/next-single-property-change returns nil, treat that as
4283 the beginning or the end of the buffer. (Bug#9955)
4285 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4287 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
4288 label is not null (Bug#9951).
4289 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4292 2011-11-04 Eli Zaretskii <eliz@gnu.org>
4294 * window.c (Fwindow_body_size): Mention in the doc string that the
4295 return value is in frame's canonical units. (Bug#9949)
4297 2011-11-03 Eli Zaretskii <eliz@gnu.org>
4299 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4301 * w32fns.c (unwind_create_frame): If needed, free the glyph
4302 matrices of the partially constructed frame. (Bug#9943)
4303 * xfns.c (unwind_create_frame): Likewise.
4305 2011-11-01 Eli Zaretskii <eliz@gnu.org>
4307 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4308 Don't stop backward scan on the continuation glyph, even though
4309 its CHARPOS is positive.
4310 (mouse_face_from_buffer_pos, note_mouse_highlight):
4311 Rename cover_string to disp_string.
4313 2011-11-01 Martin Rudalics <rudalics@gmx.at>
4315 * window.c (temp_output_buffer_show): Don't use
4316 Vtemp_buffer_show_specifiers.
4317 (Vtemp_buffer_show_specifiers): Remove unused variable.
4319 2011-10-30 Eli Zaretskii <eliz@gnu.org>
4321 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4322 past the beginning of the current glyph matrix.
4324 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
4326 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4327 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4328 HAVE_GTK3 (Bug#9869).
4330 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4331 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4333 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4335 * xterm.c: Declare x_handle_net_wm_state to return int.
4336 (handle_one_xevent): Check if we are iconified but don't have
4337 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4338 (get_current_wm_state): Return non-zero if not hidden,
4339 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4340 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4341 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4342 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4344 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4346 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4347 so that this new function doesn't get optimized away by a
4348 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4350 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4352 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4354 2011-10-29 Eli Zaretskii <eliz@gnu.org>
4356 Fix the `xbytecode' command.
4357 * .gdbinit (xprintbytestr): New command.
4358 (xwhichsymbols): Rename from `which'; all callers changed.
4359 (xbytecode): Print the byte-code string as well.
4361 2011-10-29 Kim Storm <storm@cua.dk>
4363 * alloc.c (which_symbols): New function.
4365 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4367 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4370 2011-10-29 Glenn Morris <rgm@gnu.org>
4372 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4373 Not clear what it was for, and it causes various bugs. (Bug#9839)
4375 2011-10-28 Eli Zaretskii <eliz@gnu.org>
4377 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4378 possible random value that matches one of those tested as
4379 condition to clear the mouse face.
4381 2011-10-28 Chong Yidong <cyd@gnu.org>
4383 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4385 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4387 * window.c (make_window): Initialize phys_cursor_on_p.
4389 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4391 * lisp.h (struct Lisp_Symbol): Update comments.
4393 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
4395 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4397 2011-10-28 Eli Zaretskii <eliz@gnu.org>
4399 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4400 <oslsachem@gmail.com> for helping to debug this.
4402 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4403 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4404 (g_b_init_get_glyph_outline_w): New static variables.
4405 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4406 (GetGlyphOutlineW_Proc): New typedefs.
4407 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
4408 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4410 (w32font_open_internal, compute_metrics):
4411 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
4412 instead of calling the "wide" APIs directly.
4414 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4416 * w32.h (syms_of_w32font): Add prototype.
4418 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
4420 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4421 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4422 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4423 (Fmove_to_window_line): Doc fix.
4425 2011-10-27 Chong Yidong <cyd@gnu.org>
4427 * process.c (make_process): Set gnutls_state to NULL.
4429 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4430 non-NULL, regardless of GNUTLS_INITSTAGE.
4431 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4432 an error. Set process slots as soon as we allocate them.
4434 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4436 2011-10-27 Chong Yidong <cyd@gnu.org>
4438 * gnutls.c (emacs_gnutls_deinit): New function.
4439 Deallocate credentials structures as well as calling gnutls_deinit.
4440 (Fgnutls_deinit, Fgnutls_boot): Use it.
4442 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4443 (deactivate_process): Call emacs_gnutls_deinit.
4445 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
4447 * image.c (x_create_x_image_and_pixmap):
4448 * w32.c (sys_rename, w32_delayed_load):
4449 * w32font.c (fill_in_logfont):
4450 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4452 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
4454 * w32fns.c (w32_default_color_map): New function,
4455 extracted from Fw32_default_color_map.
4456 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
4458 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4460 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4462 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4464 * keyboard.c (test_undefined): New function (bug#9751).
4465 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4467 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4469 * sysdep.c (init_sys_modes): Fix the check for the controlling
4470 terminal (Bug#6649).
4472 2011-10-20 Eli Zaretskii <eliz@gnu.org>
4474 * dispextern.h (struct bidi_it): New member next_en_type.
4476 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4477 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4478 current character, check also for next_en_type being WEAK_EN.
4479 (bidi_resolve_weak): Don't enter the expensive loop if the current
4480 position is before next_en_pos. Record the bidi type of the first
4481 non-ET, non-BN character we find, in addition to its position.
4482 (bidi_level_of_next_char): Invalidate next_en_type when
4483 next_en_pos is over-stepped.
4485 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4487 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4488 * editfns.c: Rewrite current-time-zone so that it invokes
4489 the equivalent of (format-time-string "%Z") to get the time zone name.
4490 This fixes a bug when the time zone name contains characters that
4491 need converting from the system time locale to Emacs internal format.
4492 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4493 that patch fixed format-time-string to do the conversion, but
4494 I forgot to fix current-time-zone.
4495 (format_time_string): New function, containing most of
4496 what Fformat_time_string used to contain.
4497 (Fformat_time_string): Rewrite in terms of format_time_string.
4498 This doesn't change this function's behavior.
4499 (current-time-zone): Rewrite to use format_time_string.
4500 This fixes the bug reported by Michael Schierl in
4501 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4502 Jason Rumney's 2007-06-07 change worked around this bug, but
4504 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4506 2011-10-19 Eli Zaretskii <eliz@gnu.org>
4508 * xdisp.c (start_display): If the character at POS is displayed
4509 via a display vector, reset IT->current.dpvec_index to zero.
4510 (try_window_reusing_current_matrix): If a line ends in a display
4511 vector or the next line starts in a display vector, continue
4512 redrawing the window even though the character position of
4513 start_row was reached.
4516 2011-10-18 Chong Yidong <cyd@gnu.org>
4518 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4519 with nobreak-char-display too.
4521 2011-10-18 Eli Zaretskii <eliz@gnu.org>
4523 Fix part 3 of bug#9771.
4524 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4525 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4526 non-neutral characters if the current character is a paragraph
4527 separator (a.k.a. Newline). This avoids running the same
4528 expensive loop twice, once when we consume the preceding newline
4529 and the other time when the line actually needs to be displayed.
4530 Avoid the loop when we see neutrals on the base embedding level
4531 following a character whose directionality is the same as the
4532 paragraph's. This avoids running the expensive loop when a line
4533 ends in a long sequence of neutrals, like control characters.
4534 Add assertion against STRONG_AL type. Slightly rearrange code
4535 that determines the type of a neutral given the first non-neutral
4537 (bidi_level_of_next_char): Set next_en_pos to zero when
4538 invalidating its info.
4540 2011-10-17 Eli Zaretskii <eliz@gnu.org>
4542 * xdisp.c (push_display_prop): Determine whether to record string
4543 or buffer position by IT->string, not by IT->method. Allow
4544 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
4545 (move_it_vertically_backward): Don't look for character position
4546 immediately after the newline when in a continuation line.
4549 2011-10-15 Martin Rudalics <rudalics@gmx.at>
4551 * window.c (coordinates_in_window): Rewrite and delabelize
4552 vertical border check. (Bug#5357) (Bug#9618)
4554 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4556 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4557 errors in XSetWindowBorder (bug#9310).
4559 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4561 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4562 avoid crash when xmalloc overrun checking is enabled.
4564 2011-10-13 Eli Zaretskii <eliz@gnu.org>
4566 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4567 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4568 cursor motion with <left> and <right> arrow keys.
4570 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4571 some callers set that themselves.
4573 2011-10-12 Eli Zaretskii <eliz@gnu.org>
4575 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4576 display string and the previous row comes from the same string and
4577 is empty. (Bug#9739) (Bug#9738)
4579 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4581 * doc.c (get_doc_string): Encode file name (bug#9735).
4583 2011-10-12 Eli Zaretskii <eliz@gnu.org>
4585 * bidi.c (bidi_level_of_next_char):
4586 * xdisp.c (get_visually_first_element): Remove old incorrect
4587 comments regarding the Unicode Line Separator character.
4589 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4591 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4593 * alloc.c (Fgc_status): Do not access beyond zombies array
4594 boundary if nzombies > MAX_ZOMBIES.
4595 * alloc.c (dump_zombies): Add missing format specifier.
4597 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4599 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4600 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4602 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4603 Some packages use them to denote characters with modifiers.
4605 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4607 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4608 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4609 matching a pp-number. Rename parameter var to var1.
4611 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4613 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4615 2011-10-08 Glenn Morris <rgm@gnu.org>
4617 * callint.c (Fcall_interactively): Give a more explicit error for the
4618 'c' case with a non-character input. (Bug#8479)
4620 2011-10-08 Eli Zaretskii <eliz@gnu.org>
4622 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4624 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4625 lines that are hscrolled on the left.
4627 * dispnew.c (buffer_posn_from_coords): Account for a possible
4628 presence of header-line. (Bug#4426)
4630 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4632 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4633 Don't advertise functionality which we discourage or doesn't work.
4635 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4637 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4638 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4639 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4640 this makes Emacs dump core during garbage collection on rare
4641 occasions. sizeof is obviously inferior to offsetof here, so
4642 stick with offsetof.
4643 (GC_POINTER_ALIGNMENT): New macro.
4644 (mark_memory): Omit 3rd (offset) arg; caller changed.
4645 Don't assume EMACS_INT alignment is the same as pointer alignment.
4647 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4649 * keyboard.c (read_key_sequence_remapped): New var.
4650 (read_key_sequence): Compute remapping in the right buffer.
4651 (command_loop_1): Use read_key_sequence's remapping directly.
4653 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4655 * dired.c (file_name_completion): Don't expand file name.
4656 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4657 before checking file name handler.
4659 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4660 they've been requested explicitly (bug#9591).
4662 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
4664 * keymap.c (Fsingle_key_description): Use make_specified_string
4665 instead of build_string to build string from push_key_description.
4668 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4670 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4671 This fixes a Y2038 bug on 64-bit hosts.
4672 * buffer.c (reset_buffer):
4673 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4674 (Fclear_buffer_auto_save_failure):
4675 Use 0, not -1, to represent an unset failure time, since time_t
4676 might not be signed.
4678 Remove dependency on glibc malloc internals.
4679 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4680 Move back here from lisp.h, but with their new implementations.
4681 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4682 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4683 * charset.c (charset_table_init): New static var.
4684 (syms_of_charset): Use it instead of xmalloc. This removes a
4685 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4686 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4687 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4688 Move back to alloc.c.
4689 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4690 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4692 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4694 * nsterm.m (windowDidResize): Call x_set_window_size only when
4695 ns_in_resize is true. Otherwise set pixelwidth/height and
4696 call change_frame_size (Bug#9628).
4698 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4700 Port --enable-checking=all to Fedora 14 x86-64.
4701 * charset.c (syms_of_charset): Also account for glibc malloc's
4702 internal overhead when calculating the initial malloc maximum.
4704 Port --enable-checking=all to Fedora 14 x86.
4705 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4707 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4708 (overrun_check_realloc, overrun_check_free):
4709 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4710 That way, xmalloc returns a properly-aligned pointer even if
4711 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4712 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4713 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4714 into account when calculating the initial malloc maximum.
4715 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4716 Move here from alloc.c, so that charset.c can use it too.
4717 Properly align; the old code wasn't right for common 32-bit hosts
4718 when configured with --enable-checking=all.
4719 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4720 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4722 2011-09-29 Eli Zaretskii <eliz@gnu.org>
4724 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
4727 2011-09-28 Eli Zaretskii <eliz@gnu.org>
4729 * xdisp.c (compute_display_string_end): If there's no display
4730 string at CHARPOS, return -1.
4732 * bidi.c (bidi_fetch_char): When compute_display_string_end
4733 returns a negative value, treat the character as a normal
4734 character not covered by a display string. (Bug#9624)
4736 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
4738 * lread.c (Fread_from_string): Fix typo in docstring.
4740 2011-09-27 Eli Zaretskii <eliz@gnu.org>
4742 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4743 newline, reseat the iterator instead of bidi-iterating there one
4744 character at a time. (Bug#9610)
4745 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4746 TO_CHARPOS if the bidi iterator is at base embedding level.
4748 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4750 * lread.c (readevalloop): Use correct code for NBSP.
4751 (read1): Likewise. (Bug#9608)
4753 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
4755 * dbusbind.c (Fdbus_register_signal): When service is not
4756 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4758 2011-09-25 Glenn Morris <rgm@gnu.org>
4760 * buffer.c (truncate-lines): Doc fix.
4762 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
4764 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4765 (Fset_window_next_buffers): Doc fix.
4767 2011-09-24 Glenn Morris <rgm@gnu.org>
4769 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4771 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4773 Fix minor problems found by static checking.
4774 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
4775 * indent.c (Fvertical_motion): Fix == vs = typo.
4777 2011-09-24 Eli Zaretskii <eliz@gnu.org>
4779 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4780 Default value is now t. Doc fix.
4782 * indent.c (Fvertical_motion): Compute and apply the overshoot
4783 logic when moving up, not only when moving down. Fix the
4784 confusing name and values of the it_overshoot_expected variable;
4785 logic changes accordingly. (Bug#9254) (Bug#9549)
4787 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4788 CHARPOS is covered by a display string which includes newlines.
4789 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4790 is covered by a display string with embedded newlines.
4792 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
4794 * dbusbind.c (Fdbus_register_signal): Add match rule to
4795 Vdbus_registered_objects_table. (Bug#9581)
4796 (Fdbus_register_method, Vdbus_registered_objects_table):
4799 2011-09-24 Jim Meyering <meyering@redhat.com>
4801 do not ignore write error for any output size
4802 The previous change was incomplete.
4803 While it makes emacs --batch detect the vast majority of stdout
4804 write failures, errors were still ignored whenever the output size is
4805 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4806 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4807 && echo FAIL: ignored write error
4808 FAIL: ignored write error
4809 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4810 && echo FAIL: ignored write error
4811 FAIL: ignored write error
4812 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4814 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4816 * emacs.c (Fkill_emacs): In noninteractive mode exit
4817 non-successfully if a write error occurred on stdout. (Bug#9574)
4819 2011-09-21 Eli Zaretskii <eliz@gnu.org>
4821 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4824 * dispextern.h (struct it): Update the comment documenting what
4827 2011-09-20 Eli Zaretskii <eliz@gnu.org>
4829 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4830 a display string, extend search for cursor position to end of row.
4831 (find_row_edges): If the row ends in a newline from a display
4832 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4833 Handle the case of a display string with multiple newlines.
4834 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4835 non-empty line. Fixes confusing cursor motion with arrow keys at
4836 the beginning of a line that starts with whitespace.
4838 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4840 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4843 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
4845 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4848 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4850 * xdisp.c (display_line): Record maximum and minimum buffer
4851 positions even if no glyphs were produced (e.g., by a zero-width
4852 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4853 buffer positions that will be removed from the glyph row because
4855 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4856 column is beyond frame width: don't subtract 1 "pixel" when
4857 computing width of the stretch.
4858 (reseat_at_next_visible_line_start): Undo the change made on
4859 2011-09-17 that saved paragraph information and restored it after
4860 the call to `reseat'. (Bug#9545)
4862 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4864 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4865 and turn window cursor on if cleared (Bug#9415).
4867 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
4869 * search.c (boyer_moore): Take unibyte characters from pattern
4870 literally. (Bug#9458)
4872 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4874 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4876 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4878 Fix minor problem found by static checking.
4879 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4880 initialized, to pacify gcc -Wuninitialized.
4882 * fileio.c: Report proper errno when syscall falls.
4883 (Finsert_file_contents): Save and restore errno,
4884 so that report_file_error outputs the correct diagnostic.
4885 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4887 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4889 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4891 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4893 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4894 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4896 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4898 * xdisp.c (reseat_at_next_visible_line_start): Keep information
4899 about the current paragraph and restore it after the call to reseat.
4901 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4902 (bidi_find_paragraph_start): Search back for paragraph beginning
4903 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4904 (bidi_move_to_visually_next): Only trigger paragraph-related
4905 computations when the last character is a newline or at EOB, not
4906 just any NEUTRAL_B. (Bug#9470)
4908 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4909 truncated lines if point is covered by a display string. (Bug#9524)
4911 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4913 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4914 (cons_to_x_long): New function.
4915 (lisp_data_to_selection_data): Use it. Correct the test for
4916 short-versus-long data; it was negated. Break out of vector
4917 loop, for efficiency, when a long datum is discovered.
4919 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4921 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4923 2011-09-16 Eli Zaretskii <eliz@gnu.org>
4925 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4926 GCC PR/17406) by declaring this function with external scope.
4928 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4930 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4931 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4933 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4935 * editfns.c (Fformat): Correctly handle text properties on "%%".
4937 2011-09-15 Eli Zaretskii <eliz@gnu.org>
4939 * xterm.c (x_draw_composite_glyph_string_foreground):
4940 * w32term.c (x_draw_composite_glyph_string_foreground):
4941 * term.c (encode_terminal_code):
4942 * composite.c (composition_update_it, get_composition_id):
4943 * xdisp.c (get_next_display_element)
4944 (fill_composite_glyph_string): Add comments about special meaning
4945 of TAB characters in a composition.
4947 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4949 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4950 This occurs when processing a multibyte format.
4951 Problem reported by Wolfgang Jenker.
4953 2011-09-15 Johan Bockgård <bojohan@gnu.org>
4955 * xdisp.c (try_cursor_movement): Only check for exact match if
4956 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4958 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4960 Remove unused external symbols.
4961 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4962 * xdisp.c (calc_pixel_width_or_height): Now static.
4963 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4964 * indent.c (check_display_width):
4965 * w32term.c: Fix comment to match code.
4966 * xterm.c, xterm.h (x_catching_errors): Remove.
4968 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4970 * xselect.c: Use signed conversions more consistently (Bug#9498).
4971 (selection_data_to_lisp_data): Assume incoming selection data are
4972 signed integers, not unsigned. This is to be consistent with
4973 outgoing selection data, which was modified to use signed integers
4974 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4975 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4976 expects long, not unsigned long.
4978 2011-09-14 Eli Zaretskii <eliz@gnu.org>
4980 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4981 computation of loop end. Reported by Johan Bockgård
4984 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
4986 * frame.c (Fother_visible_frames_p): Function deleted.
4988 2011-09-12 Eli Zaretskii <eliz@gnu.org>
4990 * indent.c (compute_motion): Process display vector front to back
4991 rather than the other way around. (Bug#2496)
4993 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4995 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4997 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
4999 * minibuf.c (Fread_from_minibuffer): Doc fix.
5001 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5003 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5004 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5006 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5008 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5009 value for non-existent files.
5011 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5013 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5014 set its "size" to -1. This will set the modtime_size field of
5015 the corresponding buffer to -1, which is what
5016 verify-visited-file-modtime expects for files that do not exist.
5019 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5021 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5023 * lisp.h: ... from here. push_key_description is no longer
5024 defined in keyboard.c, so its declaration should not be in
5025 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5026 logically belongs with push_key_description.
5028 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5030 * buffer.h: Include <sys/types.h> instead of <time.h>.
5031 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5032 Problem reported by Herbert J. Skuhra.
5034 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5036 * xml.c (parse_region): Make the parsing work for
5037 non-comment-starting XML files again (bug#9144).
5039 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5041 * image.c (gif_load): Fix calculation of bottom and right corner.
5044 2011-09-10 Eli Zaretskii <eliz@gnu.org>
5046 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5047 redisplay in small windows.
5049 2011-09-09 Eli Zaretskii <eliz@gnu.org>
5051 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5053 2011-09-08 Martin Rudalics <rudalics@gmx.at>
5055 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5056 Operate on live windows only.
5058 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
5060 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5062 2011-09-07 Eli Zaretskii <eliz@gnu.org>
5064 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5065 only under bidi iteration.
5067 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5069 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5071 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5073 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5074 Without this fix, the command to link temacs failed due to an
5075 undefined symbol __builtin_isnan. This is because
5076 /usr/include/iso/math_c99.h #defines isnan(x) to
5077 __builtin_isnan(x), but the bundled gcc, which identifies itself
5078 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5080 * floatfns.c (isnan): #undef, and then #define to a clone of
5082 (Fisnan): Always define, since it's always available now.
5083 (syms_of_floatfns): Always define isnan at the Lisp level.
5085 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5087 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5089 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5091 * fileio.c: Fix bugs with large file offsets (Bug#9428).
5092 The previous code assumed that file offsets (off_t values) fit in
5093 EMACS_INT variables, which is not true on typical 32-bit hosts.
5094 The code messed up by falsely reporting buffer overflow in cases
5095 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5096 when "big" contains more than 2**29 bytes, even though this
5097 inserts just one byte and does not overflow the buffer.
5098 (Finsert_file_contents): Store file offsets as off_t
5099 values, not as EMACS_INT values. Check for overflow when
5100 converting between EMACS_INT and off_t. When checking for
5101 buffer overflow or for overlap, take the offsets into account.
5102 Don't use EMACS_INT for small values where int suffices.
5103 When checking for overlap, fix a typo: ZV was used where
5104 ZV_BYTE was intended.
5105 (Fwrite_region): Don't assume off_t fits into 'long'.
5106 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5108 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
5110 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5112 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5114 sprintf-related integer and memory overflow issues (Bug#9412).
5116 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
5117 (esprintf, exprintf, evxprintf): New functions.
5118 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
5119 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
5120 (modify_event_symbol): Do not assume that the length of
5121 name_alist_or_stem is safe to alloca and fits in int.
5122 (Fexecute_extended_command): Likewise for function name and binding.
5123 (Frecursion_depth): Wrap around reliably on integer overflow.
5124 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5125 since some callers pass EMACS_INT values.
5126 (Fsingle_key_description): Don't crash if symbol name contains more
5127 than MAX_ALLOCA bytes.
5128 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5129 (get_minibuffer): Arg is now EMACS_INT, not int.
5130 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
5131 (esprintf, exprintf, evxprintf): New decls.
5132 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5134 * dbusbind.c (signature_cat): New function.
5135 (xd_signature, Fdbus_register_signal):
5136 Do not overrun buffer; instead, report string overflow.
5138 * dispnew.c (add_window_display_history): Don't overrun buffer.
5139 Truncate instead; this is OK since it's just a log.
5141 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5142 even if the time zone offset is outlandishly large.
5143 Don't mishandle offset == INT_MIN.
5145 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5146 when creating daemon; the previous buffer-overflow check was incorrect.
5148 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5149 which has the guts of the old verror function.
5151 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5152 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5154 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5155 (font_unparse_xlfd): Don't blindly alloca long strings.
5156 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
5157 fits in int, when using sprintf. Use single snprintf to count
5158 length of string rather than counting it via multiple sprintfs;
5159 that's simpler and more reliable.
5160 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5161 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5162 sprintf, in case result does not fit in int.
5164 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5165 (fontset_from_font): Print it.
5167 * frame.c (tty_frame_count): Now printmax_t, not int.
5168 (make_terminal_frame, set_term_frame_name): Print it.
5169 (x_report_frame_params): In X, window IDs are unsigned long,
5170 not signed long, so print them as unsigned.
5171 (validate_x_resource_name): Check for implausibly long names,
5172 and don't assume name length fits in 'int'.
5173 (x_get_resource_string): Don't blindly alloca invocation name;
5174 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5177 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5178 (xg_check_special_colors, xg_set_geometry):
5179 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5181 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5182 Use esprintf, not sprintf, in case result does not fit in int.
5184 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5185 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5186 it as a large positive number.
5187 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5188 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5190 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5191 in case result does not fit in int.
5193 * print.c (float_to_string): Detect width overflow more reliably.
5194 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5195 buffer overrun. Don't assume list length fits in 'int'. Treat
5196 print length of 0 as 0, not as infinity; to be consistent with other
5197 uses of print length in this function. Don't overflow print length
5198 index. Don't assume hash table size fits in 'long', or that
5199 vectorlike size fits in 'unsigned long'.
5201 * process.c (make_process): Use printmax_t, not int, to format
5202 process-name gensyms.
5204 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5206 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5207 to avoid potential buffer overrun.
5209 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5210 if X resource line is longer than 512 bytes.
5212 * xfns.c (x_window): Make sprintf buffer a bit bigger
5213 to avoid potential buffer overrun.
5215 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5217 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5219 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5221 Integer overflow fixes for scrolling, etc.
5222 Without these, Emacs silently mishandles large integers sometimes.
5223 For example, "C-u 4294967297 M-x recenter" was treated as if
5224 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5226 * xdisp.c (try_window_id): Check Emacs fixnum range before
5227 converting to 'int'.
5229 * window.c (window_scroll_line_based, Frecenter):
5230 Check that an Emacs fixnum is in range before assigning it to 'int'.
5231 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5232 values converted from Emacs fixnums.
5233 (Frecenter): Don't wrap around a line count if it is out of 'int'
5234 range; instead, treat it as an extreme value.
5235 (Fset_window_configuration, compare_window_configurations):
5236 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5238 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5239 that can exceed INT_MAX. Check that EMACS_INT value is in range
5240 before assigning it to the (possibly-narrower) index.
5241 (match_limit): Don't assume that a fixnum can fit in 'int'.
5243 * print.c (print_object): Use ptrdiff_t, not int, for index that can
5246 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
5247 (Fvertical_motion): Don't wrap around LINES values that don't fit
5248 in 'int'. Instead, treat them as extreme values. This is good
5249 enough for windows, which can't have more than INT_MAX lines anyway.
5251 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5253 * Require libxml/parser.h to avoid compilation warning.
5255 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5257 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5258 since this reportedly can destroy thread storage.
5260 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
5262 * syntax.c (find_defun_start): Update all cache variables if
5263 exiting early (Bug#9401).
5265 2011-08-30 Eli Zaretskii <eliz@gnu.org>
5267 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5269 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5270 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5271 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5273 * term.c (tty_append_glyph): New function.
5274 (produce_stretch_glyph): Static function and its prototype deleted.
5276 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5279 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5281 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5282 when checking :margin (Bug#9390).
5283 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
5284 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
5285 so that the name doesn't mislead. All uses changed.
5287 2011-08-28 Johan Bockgård <bojohan@gnu.org>
5289 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5292 2011-08-27 Eli Zaretskii <eliz@gnu.org>
5294 * xdisp.c (move_it_to): Don't bail out early when reaching
5295 position beyond to_charpos, if we are scanning backwards.
5296 (move_it_vertically_backward): When DY == 0, make sure we get to
5297 the first character in the line after the newline.
5299 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5301 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5302 (ccl_driver): Do not generate an out-of-range pointer.
5303 (Fccl_execute_on_string): Remove unnecessary check for
5304 integer overflow, noted by Stefan Monnier in
5305 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5306 Remove a FIXME that didn't need fixing.
5307 Simplify the newly-introduced buffer reallocation code.
5309 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
5311 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5313 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
5315 Integer and memory overflow issues (Bug#9196).
5317 * doc.c (get_doc_string): Rework so that
5318 get_doc_string_buffer_size is the actual buffer size, rather than
5319 being 1 less than the actual buffer size; this makes xpalloc more
5322 * image.c (x_allocate_bitmap_record, cache_image):
5323 * xselect.c (Fx_register_dnd_atom):
5324 Simplify previous changes by using xpalloc.
5326 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5327 since either will do and ptrdiff_t is convenient with xpalloc.
5329 * charset.c (charset_table_size)
5330 (struct charset_sort_data.priority): Now ptrdiff_t.
5331 (charset_compare): Don't overflow if priorities differ greatly.
5332 (Fsort_charsets): Don't assume list length fits in int.
5333 Check for size-calculation overflow when allocating sort data.
5334 (syms_of_charset): Allocate an initial charset table that is
5335 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5337 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5339 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5340 The actual value is always <= INT_MAX, and leaving it unsigned made
5341 overflow checking harder.
5343 * dispextern.h (struct glyph_matrix.rows_allocated)
5344 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5345 with xpalloc. The values are still always <= INT_MAX.
5347 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5349 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5350 (SAFE_NALLOCA): New macro.
5352 * region-cache.c (struct boundary.pos, find_cache_boundary)
5353 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5354 (set_cache_region, invalidate_region_cache)
5355 (revalidate_region_cache, know_region_cache, region_cache_forward)
5356 (region_cache_backward, pp_cache):
5357 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5358 so that ptrdiff_t * can be passed to xpalloc.
5359 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5360 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5361 (pp_cache): Don't assume cache_len fits in int.
5362 * region-cache.h: Adjust extern decls to match.
5364 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5365 EMACS_INT, since either will do, for xpalloc.
5367 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5368 (xnmalloc, xnrealloc, xpalloc): New functions.
5370 * bidi.c (bidi_shelve_header_size): New constant.
5371 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5372 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5374 * bidi.c (bidi_cache_shrink):
5375 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5377 Don't update size of array until after memory allocation succeeds,
5378 because xmalloc/xrealloc may not return.
5379 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5380 now that we have proper integer overflow checking.
5381 (record_overlay_string, overlay_strings): Catch overflows when
5382 calculating size of overlay_str_buf.
5384 * callproc.c (Fcall_process): Check for size overflow when
5385 calculating size of args2.
5386 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5387 Normally we prefer signed values, but sticking with ptrdiff_t would
5388 require adding more-complicated checks.
5390 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5391 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5392 Redo buffer-overflow calculations to avoid integer overflow.
5393 Add a FIXME comment where memory seems to be over-allocated.
5395 * character.c (Fstring): Check for size-calculation overflow.
5397 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5398 unnecessary integer overflow. Check for size overflow.
5399 (encode_coding_object): Don't update size until xmalloc succeeds.
5401 * composite.c (get_composition_id): Check for overflow in glyph
5402 length calculations.
5404 Integer and memory overflow fixes for display code.
5405 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5406 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5407 (scrolling_window): Check for overflow in size calculations.
5408 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5409 Don't assume glyph table len fits in int.
5410 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5411 (row_table_size): Now ptrdiff_t, not int.
5412 (scrolling_window): Avoid overflow in size calculations.
5413 Don't update size until allocation succeeds.
5414 * fns.c (concat): Check for overflow in size calculations.
5415 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5416 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5417 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5419 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5420 (get_doc_string): Check for size calculation overflow.
5421 Don't update size until allocation succeeds.
5422 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5423 EMACS_INT, where ptrdiff_t will do.
5424 (Fsubstitute_command_keys): Check for string overflow.
5426 * editfns.c (set_time_zone_rule): Don't assume environment length
5428 (message_length): Now ptrdiff_t, not int.
5429 (Fmessage_box): Don't update size until allocation succeeds.
5430 Don't assume message length fits in int.
5431 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5433 * emacs.c (main): Do not reallocate argv, since there is a null at
5434 the end that can be overwritten, and this way there's no need to
5435 worry about size-calculation overflow.
5436 (sort_args): Check for size-calculation overflow.
5438 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5440 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5442 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5443 (x_set_scroll_bar_width, x_figure_window_size):
5444 Check for integer overflow.
5445 (x_set_alpha): Do not assume XINT fits in int.
5447 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5448 This is for the members text_lines, text_cols, total_lines, total_cols,
5449 where the system imposes an 'int' limit.
5451 * fringe.c (Fdefine_fringe_bitmap):
5452 Don't update size until alloc works.
5454 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5455 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5457 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5458 Check for size-calculation overflow.
5459 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5460 do, as we prefer signed integers.
5461 (id_to_widget.max_size, id_to_widget.used)
5462 (xg_store_widget_in_map, xg_remove_widget_from_map)
5463 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5464 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5465 Use and return ptrdiff_t, not int.
5466 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5467 * gtkutil.h: Change prototypes to match the above.
5469 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5470 are duplicate now that they've been promoted to lisp.h.
5471 (x_allocate_bitmap_record, x_alloc_image_color)
5472 (make_image_cache, cache_image, xpm_load):
5473 Don't update size until alloc is done.
5474 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5476 Check for size calculation overflow.
5477 (ct_colors_allocated_max): New constant.
5478 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5481 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5482 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5483 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5484 Use ptrdiff_t, not int, to count maps.
5485 (read_char_minibuf_menu_prompt): Check for overflow in size
5486 calculations. Don't update size until allocation succeeds.
5487 Redo calculations to avoid overflow.
5488 * keyboard.h: Change prototypes to match the above.
5490 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5492 (current_minor_maps): Check for size calculation overflow.
5493 * keymap.h: Change prototypes to match the above.
5495 * lread.c (read1, init_obarray): Don't update size until alloc done.
5497 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5498 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5500 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5501 Now ptrdiff_t, not int.
5502 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5503 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5505 * process.c (Fnetwork_interface_list): Check for overflow
5506 in size calculation.
5508 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5510 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5511 overflow. Don't bother calling xmalloc when xrealloc will do.
5513 * search.c (Freplace_match): Check for size calculation overflow.
5514 (Fset_match_data): Don't assume list lengths fit in 'int'.
5516 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5517 for command line length. Do not attempt to address one before the
5518 beginning of an array, as that's not portable.
5520 * term.c (max_frame_lines): Remove; unused.
5521 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5523 (encode_terminal_code, calculate_costs): Check for size
5524 calculation overflow.
5525 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5526 table lengths and related sizes. Don't update size until alloc
5527 done. Redo calculations to avoid overflow.
5528 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5530 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5531 subtracting pointers.
5532 (gobble_line): Check for overflow more carefully. Don't update size
5535 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5536 Don't update size until alloc done.
5537 Redo size calculations to avoid overflow.
5538 Check for size calculation overflow.
5539 (main) [DEBUG]: Fix typo in invoking tparam1.
5541 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5542 Use ptrdiff_t, not int, for sizes.
5543 (store_mode_line_noprop_char): Don't update size until alloc done.
5545 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5546 Use ptrdiff_t, not int, for sizes.
5547 (Finternal_make_lisp_face, cache_face):
5548 Check for size calculation overflow.
5549 (cache_face): Treat size calculation overflows as if they were
5550 memory exhaustion (the usual treatment), rather than aborting.
5552 * xfns.c (x_encode_text, x_set_name_internal)
5553 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5554 sizes, since they can exceed INT_MAX in size. Check for size
5555 calculation overflow.
5557 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5558 (xg_select): Check for size calculation overflow.
5559 Don't update size until alloc done.
5561 * xrdb.c (get_environ_db): Don't assume path length fits in int,
5562 as sprintf is limited to int lengths.
5564 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5565 (X_LONG_MIN): New macros.
5566 Use them to make the following changes clearer.
5567 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5568 This change doesn't affect the value now, but it may help remind
5569 future maintainers not to raise the value too much later.
5570 (SELECTION_QUANTUM): Remove, replacing with ...
5571 (selection_quantum): ... new function, which avoids overflow.
5573 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5574 assumption that selection length fits in 'int'.
5575 (x_reply_selection_request, x_handle_selection_request)
5576 (x_get_window_property, receive_incremental_selection)
5577 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5578 (lisp_data_to_selection_data, clean_local_selection_data):
5579 Use ptrdiff_t, not int, to record length of selection.
5580 (x_reply_selection_request, x_get_window_property)
5581 (receive_incremental_selection, x_property_data_to_lisp):
5582 Redo calculations to avoid overflow.
5583 (x_reply_selection_request): When sending hint, ceiling it at
5584 X_LONG_MAX rather than relying on wraparound overflow to send
5586 (x_get_window_property, receive_incremental_selection)
5587 (lisp_data_to_selection_data, x_property_data_to_lisp):
5588 Check for size-calculation overflow.
5589 (x_get_window_property, receive_incremental_selection)
5590 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5591 Don't store size until memory allocation succeeds.
5592 (x_get_window_property): Plug memory leak on memory exhaustion.
5593 Don't double-block input; malloc is safe here. Don't assume 2**34
5594 - 4 fits in unsigned long. Add an xassert to check
5595 XGetWindowProperty overflow. Be more careful about overflow
5596 calculations, and distinguish size from memory overflow better.
5597 (receive_incremental_selection): When tracing, don't assume
5598 unsigned int is less than INT_MAX.
5599 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5600 harmful) conversions of unsigned short to int.
5601 (lisp_data_to_selection_data): Don't assume that integers
5602 in the range -65535 through -1 fit in an X unsigned short.
5603 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5604 result parameters unless successful. Rely on cons_to_unsigned
5605 to report problems with elements; the old code wasn't right anyway.
5606 (x_check_property_data): Check for int overflow; we cannot use
5607 a wider type due to X limits.
5608 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5610 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
5612 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5613 (x_term_init): Check for size calculation overflow.
5614 (x_color_cells): Don't store size until memory allocation succeeds.
5615 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
5616 Don't assume alloca size is less than MAX_ALLOCA.
5617 (x_term_init): Don't assume length fits in int (sprintf is limited
5620 Use ptrdiff_t for composition IDs.
5621 * character.c (lisp_string_width):
5622 * composite.c (composition_table_size, n_compositions)
5623 (get_composition_id, composition_gstring_from_id):
5624 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5625 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5626 * window.c (Frecenter):
5627 Use ptrdiff_t, not int, for composition IDs.
5628 * composite.c (get_composition_id): Check for integer overflow.
5629 * composite.h: Adjust prototypes to match the above changes.
5631 Use ptrdiff_t for hash table indexes.
5632 * category.c (hash_get_category_set):
5633 * ccl.c (ccl_driver):
5634 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5635 * coding.c (coding_system_charset_list, detect_coding_system):
5636 * coding.h (struct coding_system.id):
5637 * composite.c (get_composition_id, gstring_lookup_cache):
5638 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5639 * image.c (xpm_get_color_table_h):
5640 * lisp.h (hash_lookup, hash_put):
5641 * minibuf.c (Ftest_completion):
5642 Use ptrdiff_t for hash table indexes, not int (which is too
5643 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5644 32-bit --with-wide-int hosts).
5646 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5647 Add a FIXME comment about memory leaks.
5648 (syms_of_charset): Don't assume xmalloc returns.
5650 Don't assume that stated character widths fit in int.
5651 * character.c (Fchar_width, c_string_width, lisp_string_width):
5652 * character.h (CHAR_WIDTH):
5653 * indent.c (MULTIBYTE_BYTES_WIDTH):
5654 Use sanitize_char_width to avoid undefined and/or bad behavior
5655 with outlandish widths.
5656 * character.h (sanitize_tab_width): Rename from sanitize_width,
5657 now that we have two such functions. All uses changed.
5658 (sanitize_char_width): New inline function.
5660 Don't assume that tab-width fits in int.
5661 * character.h (sanitize_width): New inline function.
5662 (SANE_TAB_WIDTH): New macro.
5663 (ASCII_CHAR_WIDTH): Use it.
5664 * indent.c (sane_tab_width): Remove. All uses replaced by
5665 SANE_TAB_WIDTH (current_buffer).
5666 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5668 * fileio.c: Integer overflow issues with file modes.
5669 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5671 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5672 Remove unreachable code.
5673 (read_hex, load_charset_map_from_file): Check for integer overflow.
5675 * xterm.c: Don't go over XClientMessageEvent limit.
5676 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5677 (x_send_scroll_bar_event): Likewise. Check that the size does not
5678 exceed limits imposed by XClientMessageEvent, as well as the usual
5679 ptrdiff_t and size_t limits.
5681 * keyboard.c: Overflow, signedness and related fixes.
5682 (make_lispy_movement): Use same integer type in forward decl
5683 that is used in the definition.
5684 (read_key_sequence, keyremap_step):
5685 Change bufsize argument back to int, undoing my 2011-03-30 change.
5686 We prefer signed types, and int is wide enough here.
5687 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5688 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5689 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5690 length, not size_t. Use ptrdiff_t for index, not int.
5691 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5692 possibility of integer overflow.
5694 Overflow, signedness and related fixes for images.
5696 * dispextern.h (struct it.stack[0].u.image.image_id)
5697 (struct_it.image_id, struct image.id, struct image_cache.size)
5698 (struct image_cache.used, struct image_cache.ref_count):
5699 * gtkutil.c (update_frame_tool_bar):
5700 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5701 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5702 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5703 * nsmenu.m (update_frame_tool_bar):
5704 * xdisp.c (calc_pixel_width_or_height):
5705 * xfns.c (image_cache_refcount):
5706 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5707 on typical 64-bit hosts.
5709 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5710 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5711 Omit unnecessary casts to int.
5712 (parse_image_spec): Check that integers fall into 'int' range
5713 when the callers expect that.
5714 (image_ascent): Redo ascent calculation to avoid int overflow.
5715 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5716 (lookup_image): Remove unnecessary tests.
5717 (xbm_image_p): Locals are now of int, not EMACS_INT,
5718 since parse_image_check makes sure they fit into int.
5719 (png_load, gif_load, svg_load_image):
5720 Prefer int to unsigned where either will do.
5721 (tiff_handler): New function, combining the cores of the
5722 old tiff_error_handler and tiff_warning_handler.
5723 This function is rewritten to use vsnprintf and thereby avoid
5724 stack buffer overflows. It uses only the features of vsnprintf
5725 that are common to both POSIX and native Microsoft.
5726 (tiff_error_handler, tiff_warning_handler): Use it.
5727 (tiff_load, gif_load, imagemagick_load_image):
5728 Don't assume :index value fits in 'int'.
5729 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5730 (imagemagick_load_image): Check that crop parameters fit into
5731 the integer types that MagickCropImage accepts. Don't assume
5732 Vimagemagick_render_type has a nonnegative value. Don't assume
5733 size_t fits in 'long'.
5734 (gs_load): Use printmax_t to print the widest integers possible.
5735 Check for integer overflow when computing image height and width.
5737 2011-08-26 Eli Zaretskii <eliz@gnu.org>
5739 * xdisp.c (redisplay_window): Don't force window start if point
5740 will be invisible in the resulting window. (Bug#9324)
5742 2011-08-25 Eli Zaretskii <eliz@gnu.org>
5744 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5745 the display spec is of the form `(space ...)'.
5746 (handle_display_spec): Return the value returned by
5747 handle_single_display_spec, not just 1 or zero.
5748 (handle_single_display_spec): If the display spec is of the form
5749 `(space ...)', and specifies display in the text area, return 2
5751 (try_cursor_movement): Check for the need to scroll more
5752 accurately, and prefer exact match for point under bidi.
5753 Don't advance `row' beyond the last row of the window.
5755 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5756 into disp_prop; all users changed.
5758 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5759 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5760 for the text covered by the display property.
5762 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
5764 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5765 Change return value to nil.
5766 (Frecord_buffer): Delete unused function.
5768 2011-08-24 Eli Zaretskii <eliz@gnu.org>
5770 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5771 buffers, return left-to-right.
5772 (set_cursor_from_row): Consider candidate row a win if its glyph
5773 represents a newline and point is on that newline. Fixes cursor
5774 positioning on the newline at EOL of R2L text within L2R
5775 paragraph, and vice versa.
5776 (try_cursor_movement): Check continued rows, in addition to
5777 continuation rows. Fixes unwarranted scroll when point enters a
5778 continued line of R2L text within an L2R paragraph, or vice versa.
5779 (cursor_row_p): Consider the case of point being equal to
5780 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5781 from the end of a short line to the beginning of a continued line
5782 of R2L text within L2R paragraph.
5783 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5784 composed characters.
5786 * bidi.c (bidi_check_type): Use xassert.
5787 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5790 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5792 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5795 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
5797 * nsfont.m (ns_otf_to_script): Fix typo.
5799 2011-08-22 Kenichi Handa <handa@m17n.org>
5801 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5802 extra slot even if the purpose is char-code-property-table.
5804 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5806 * xdisp.c (redisplay_window): When computing centering_position,
5807 account for the height of the header line. (Bug#8874)
5809 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5810 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5811 candidate is selected by the mouse, and that candidate has a
5812 composed character under the mouse.
5814 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5815 coordinates reported by pos-visible-in-window-p for a composed
5816 character in column zero.
5818 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5820 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5822 2011-08-22 Eli Zaretskii <eliz@gnu.org>
5824 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5825 consider it a hit if to_charpos is anywhere in the range of the
5826 composed buffer positions.
5828 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
5830 * image.c (gif_load): Don't assume that each subimage has the same
5831 dimensions as the base image. Handle disposal method that is
5832 "undefined" by the gif spec (Bug#9335).
5834 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
5836 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
5837 (Fcondition_case): Document `debug' symbol in error handler.
5839 2011-08-19 Eli Zaretskii <eliz@gnu.org>
5841 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5842 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5843 from an Org mode buffer to a Speedbar frame.
5845 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5846 a composition, take its buffer position from IT->cmp_it.charpos.
5847 Fixes cursor positioning at the beginning of a line that begins
5848 with a composed character.
5850 2011-08-18 Eli Zaretskii <eliz@gnu.org>
5852 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5853 character bidirectional type, use STRONG_L instead. Fixes crashes
5854 in a buffer produced by `describe-categories'.
5856 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5857 members before the level stack, so they would be saved and
5858 restored when copying iterator state. Fixes incorrect reordering
5859 around TABs covered by display properties.
5861 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5863 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
5865 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
5867 * eval.c (internal_condition_case, internal_condition_case_1)
5868 (internal_condition_case_2, internal_condition_case_n):
5869 Remove unnecessary aborts (Bug#9081).
5871 2011-08-17 Eli Zaretskii <eliz@gnu.org>
5873 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5874 has no `load' handler, try opening the file locally. (Bug#9311)
5876 2011-08-16 Ken Brown <kbrown@cornell.edu>
5878 * gmalloc.c: Expand comment.
5880 2011-08-16 Eli Zaretskii <eliz@gnu.org>
5882 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5883 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5885 2011-08-16 Ken Brown <kbrown@cornell.edu>
5887 Fix memory allocation problems in Cygwin build (Bug#9273).
5889 * unexcw.c ( __malloc_initialized): Declare external variable.
5890 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5892 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5894 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5896 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5898 [CYGWIN] (special_realloc): New function.
5899 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5900 requests to realloc storage in the static heap.
5902 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5904 * bidi.c (bidi_initialize): Remove unused local.
5906 2011-08-15 Eli Zaretskii <eliz@gnu.org>
5909 * biditype.h: Remove file.
5910 * makefile.w32-in ($(BLD)/bidi.$(O)):
5911 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
5913 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5915 * chartab.c: Improve commentary for the uniprop_table API.
5917 * bidi.c (bidi_paragraph_init): Support zero value of
5918 bidi_ignore_explicit_marks_for_paragraph_level.
5919 (bidi_initialize): Use uniprop_table instead of including
5920 biditype.h and bidimirror.h.
5922 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5923 coordinates of the iterator when restoring from ppos_it.
5926 2011-08-14 Kenichi Handa <handa@m17n.org>
5928 * process.c (create_process): Call setup_process_coding_systems
5929 after the pid of the process is set to -1 (Bug#8162).
5931 2011-08-14 Eli Zaretskii <eliz@gnu.org>
5933 * xdisp.c (move_it_in_display_line_to): Don't invoke
5934 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5935 ppos_it. Fixes vertical cursor motion when line beginning is
5936 covered by an image. (Bug#9296)
5938 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5940 * nsterm.h (ns_run_ascript): Declare.
5941 (NSAPP_DATA2_RUNASSCRIPT): Define.
5943 * nsfns.m (as_script, as_result, as_status): New static variables.
5944 (ns_run_ascript): New function.
5945 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
5946 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5947 the event loop. Get status from as_status (Bug#7276).
5949 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5950 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5951 the event loop (Bug#7276).
5953 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5955 * gnutls.c (QCgnutls_bootprop_priority)
5956 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5957 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5958 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5959 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5960 (QCgnutls_bootprop_verify_hostname_error)
5961 (QCgnutls_bootprop_callbacks_verify): Rename from
5962 Qgnutls_bootprop_..., all uses changed.
5964 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5967 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5969 * xfaces.c (Qframe_set_background_mode): Now static.
5970 * dispextern.h (Qframe_set_background_mode): Remove decl.
5972 * process.c (Fnetwork_interface_info): Declare local only if needed.
5974 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5976 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5977 (Fnetwork_interface_list): Allocate in increments of bytes instead
5978 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5979 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5981 (struct ifflag_def): notrailers is smart on OSX.
5982 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5983 Get hardware address with getifaddrs if available.
5985 2011-08-12 Eli Zaretskii <eliz@gnu.org>
5987 * xdisp.c (iterate_out_of_display_property): xassert that
5988 IT->position is set to within IT->object's boundaries. Break from
5989 the loop as soon as EOB is reached; avoids infloops in redisplay
5990 when IT->position is set up wrongly due to some bug.
5991 Set IT->current to match the bidi iterator unconditionally.
5992 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5993 entry. Force push_it to save on the stack the current
5994 buffer/string position, to be restored by pop_it. Fix flags in
5995 the iterator structure wrt the object coming from a display
5996 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5997 properties. (Bug#9284)
5999 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
6001 * fontset.c (fontset_get_font_group): Add proper type checks.
6004 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6006 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6007 and LC_VERSION_MIN_MACOSX.
6008 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6009 (dump_it) [LC_FUNCTION_STARTS]: Use it.
6011 2011-08-08 Eli Zaretskii <eliz@gnu.org>
6013 * xdisp.c (forward_to_next_line_start): Allow to use the
6014 no-display-properties-and-no-overlays under bidi display.
6015 Set disp_pos in the bidi iterator to avoid searches for display
6016 properties and overlays.
6018 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
6020 * editfns.c (Fset_time_zone_rule): Document relationship with the
6023 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6024 the font entity extracted from the cache (Bug#8109).
6026 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
6028 * composite.c (autocmp_chars): Don't reset point. That is done by
6029 restore_point_unwind (Bug#5984).
6031 2011-08-07 Juri Linkov <juri@jurta.org>
6033 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6034 to show the arg `TIME' instead of `TIMEVAL'.
6036 2011-08-06 Eli Zaretskii <eliz@gnu.org>
6038 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6039 display property strides EOL and includes a newline, as in
6040 longlines-mode. (Bug#9254)
6041 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6042 word-wrap under bidirectional display. (Bug#9224)
6044 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6045 is non-zero, even if the data buffer is NULL. Fixes a crash in
6046 vertical-motion with longlines-mode. (Bug#9254)
6048 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6050 * bidi.c <bidi_cache_total_alloc>: Now static.
6051 (bidi_initialize): Initialize bidi_cache_total_alloc.
6053 * xdisp.c (display_line): Release buffer allocated for shelved bidi
6056 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6057 amount allocated this far in `bidi_cache_total_alloc'.
6058 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6059 non-zero, only free the data buffer without restoring the cache
6060 contents. All callers changed.
6062 * dispextern.h (bidi_unshelve_cache): Update prototype.
6064 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6065 (move_it_in_display_line, move_it_to)
6066 (move_it_vertically_backward, move_it_by_lines): Replace the call
6067 to xfree to an equivalent call to bidi_unshelve_cache.
6068 (move_it_in_display_line_to): Fix logic of returning
6069 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
6071 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6073 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6074 came from a string character with a `cursor' property. (Bug#9229)
6076 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6078 * Makefile.in (LIB_PTHREAD): New variable.
6079 (LIBES): Add LIB_PTHREAD (Bug#9216).
6081 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6082 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6084 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6086 * regex.c (re_iswctype): Remove some redundant boolean conversions.
6088 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6090 * xterm.c (x_find_topmost_parent): New function.
6091 (x_set_frame_alpha): Find topmost parent window with
6092 x_find_topmost_parent and set the property there also (bug#9181).
6093 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6095 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6097 * callproc.c (Fcall_process): Avoid vfork clobbering
6098 the local vars buffer, coding_systems, current_dir.
6100 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6102 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6104 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6106 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6107 so that it is not optimized away.
6109 * xdisp.c (compute_display_string_pos): Remove unused local.
6111 2011-08-02 Eli Zaretskii <eliz@gnu.org>
6113 Fix slow cursor motion and scrolling in large buffers with
6114 selective display, like Org Mode buffers. (Bug#9218)
6116 * dispextern.h (struct bidi_it): New member disp_prop_p.
6118 * xdisp.c: Remove one-slot cache of display string positions.
6119 (compute_display_string_pos): Accept an additional argument
6120 DISP_PROP_P; callers changed. Scan at most 5K characters forward
6121 for a display string or property. If found, set DISP_PROP_P
6124 * bidi.c (bidi_fetch_char): Accept an additional argument
6125 DISP_PROP_P, and pass it to compute_display_string_pos.
6126 Only handle text covered by a display string if DISP_PROP_P is returned
6127 non-zero. All callers of bidi_fetch_char changed.
6129 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6131 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6133 2010-12-03 Don March <don@ohspite.net>
6135 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6136 last character M-[char] is translated to ESC [char] (bug#7541).
6138 2011-08-02 Kenichi Handa <handa@m17n.org>
6140 * lisp.h (uniprop_table): Extern it.
6142 * chartab.c (uniprop_table): Make it non-static.
6144 2011-08-01 Eli Zaretskii <eliz@gnu.org>
6146 * xdisp.c (forward_to_next_line_start): Accept additional argument
6147 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6149 (reseat_at_next_visible_line_start): Use the bidi iterator state
6150 returned by forward_to_next_line_start to restore the state of
6151 it->bidi_it after backing up to previous newline. (Bug#9212)
6153 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6155 * regex.c (re_comp): Protoize.
6156 (re_exec): Fix return type.
6157 (regexec): Fix type of `ret'. (Bug#9203)
6159 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6161 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6162 This is needed if max-image-size is a floating-point number.
6164 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6166 * print.c (print_object): Print empty symbol as ##.
6168 * lread.c (read1): Read ## as empty symbol.
6170 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6172 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6173 setting frame foreground color (Bug#9175).
6174 (x_set_background_color): Likewise.
6176 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6177 contents (Bug#9176).
6178 (EmacsTooltip -init): Remove bezels and add shadows to
6181 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6182 or scroll bar (Bug#8470).
6184 * nsfont.m (nsfont_open): Remove assignment to voffset and
6185 unnecessary vars hshink, expand, hd, full_height, min_height.
6186 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6188 * nsterm.h (nsfont_info): Remove voffset field.
6190 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6192 Implement strike-through and overline on NextStep (Bug#8863).
6194 * nsfont.m (nsfont_open): Use underline position provided by font,
6195 instead of hard-coded value of 2.
6196 (nsfont_draw): Call ns_draw_text_decoration instead.
6198 * nsterm.h: Add declaration for ns_draw_text_decoration.
6200 * nsterm.m (ns_draw_text_decoration): New function for drawing
6201 underline, overline, and strike-through.
6202 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6203 ns_draw_text_decoration. Change treatment of cursor drawing to
6204 accommodate underlining, etc.
6206 2011-07-28 Eli Zaretskii <eliz@gnu.org>
6208 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6211 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6213 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6214 Without this fix, if a signal arrives just after memory fills up,
6215 'malloc' might be invoked reentrantly.
6217 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6218 In other words, assume that every image size is allowed, on non-X
6219 hosts. This assumption is probably wrong, but it lets Emacs compile.
6221 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6223 * regex.c (re_iswctype): Convert return values to boolean.
6225 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6227 * xdisp.c (compute_display_string_pos): Don't use cached display
6228 string position if the buffer had its restriction changed.
6231 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6233 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6235 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6237 Integer signedness and overflow and related fixes. (Bug#9079)
6239 * bidi.c: Integer size and overflow fixes.
6240 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6241 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6242 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6243 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6244 (bidi_find_other_level_edge):
6245 Use ptrdiff_t instead of EMACS_INT where either will do.
6246 This works better on 32-bit hosts configured --with-wide-int.
6247 (bidi_cache_ensure_space): Check for size-calculation overflow.
6248 Use % rather than repeated addition, for better worst-case speed.
6249 Don't set bidi_cache_size until after xrealloc returns, because it
6251 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
6252 (bidi_cache_ensure_space): Also check that the bidi cache size
6253 does not exceed that of the largest Lisp string or buffer. See Eli
6254 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
6256 * alloc.c (__malloc_size_t): Remove.
6257 All uses replaced by size_t. See Andreas Schwab's note
6258 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6260 * image.c: Improve checking for integer overflow.
6261 (check_image_size): Assume that f is nonnull, since
6262 it is always nonnull in practice. This is one less thing to
6263 worry about when checking for integer overflow later.
6264 (x_check_image_size): New function, which checks for integer
6265 overflow issues inside X.
6266 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6267 This removes the need for a memory_full check.
6268 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6269 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6270 (xbm_read_bitmap_data): Change locals back to 'int', since
6271 their values must fit in 'int'.
6272 (xpm_load_image, png_load, tiff_load):
6273 Invoke x_create_x_image_and_pixmap earlier,
6274 to avoid much needless work if the image is too large.
6275 (tiff_load): Treat overly large images as if
6276 x_create_x_image_and_pixmap failed, not as malloc failures.
6277 (gs_load): Use x_check_image_size.
6279 * gtkutil.c: Omit integer casts.
6280 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6281 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6283 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6285 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6286 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6287 would wrongly return t on a 64-bit host.
6289 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6290 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6291 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6292 and therefore cause GCC to emit a bogus diagnostic in some cases.
6294 * image.c: Integer signedness and overflow and related fixes.
6295 This is not an exhaustive set of fixes, but it's time to
6296 record what I've got.
6297 (lookup_pixel_color, check_image_size): Remove redundant decls.
6298 (check_image_size): Don't assume that arbitrary EMACS_INT values
6299 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6300 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6301 (tiff_load, imagemagick_load_image):
6302 Check for overflow in size calculations.
6303 (x_create_x_image_and_pixmap): Remove unnecessary test for
6304 xmalloc returning NULL; that can't happen.
6305 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6306 (xpm_color_bucket): Use better integer hashing function.
6307 (xpm_cache_color): Don't possibly over-allocate memory.
6308 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6309 (gif_memory_source):
6310 Use ptrdiff_t, not int or size_t, to record sizes.
6311 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6312 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6313 either works, as we prefer signed integers.
6314 (tiff_read_from_memory, tiff_write_from_memory):
6315 Return tsize_t, not size_t, since that's what the TIFF API wants.
6316 (tiff_read_from_memory): Don't fail simply because the read would
6317 go past EOF; instead, return a short read.
6318 (tiff_load): Omit no-longer-needed casts.
6319 (Fimagemagick_types): Don't assume size fits into 'int'.
6321 Improve hashing quality when configured --with-wide-int.
6322 * fns.c (hash_string): New function, taken from sxhash_string.
6323 Do not discard information about ASCII character case; this
6324 discarding is no longer needed.
6325 (sxhash-string): Use it. Change sig to match it. Caller changed.
6326 * lisp.h: Declare it.
6327 * lread.c (hash_string): Remove, since we now use fns.c's version.
6328 The fns.c version returns a wider integer if --with-wide-int is
6329 specified, so this should help the quality of the hashing a bit.
6331 * emacs.c: Integer overflow minor fix.
6332 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6333 Define only if GNU_LINUX.
6334 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6336 * dispnew.c: Integer signedness and overflow fixes.
6337 Remove unnecessary forward decls, that were a maintenance hassle.
6338 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6340 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6341 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6342 (prepare_desired_row, line_draw_cost):
6343 Use int, not unsigned, where either works.
6344 (save_current_matrix, restore_current_matrix):
6345 Use ptrdiff_t, not size_t, where either works.
6346 (init_display): Check for overflow more accurately, and without
6347 relying on undefined behavior.
6349 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6350 Remove, replacing with the new symbols in lisp.h. All uses changed.
6351 * fileio.c (make_temp_name):
6352 * filelock.c (lock_file_1, lock_file):
6353 * xdisp.c (message_dolog):
6354 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6355 Use pMd etc. instead.
6356 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6357 replacing the pWIDE etc. symbols removed from editfns.c.
6359 * keyboard.h (num_input_events): Now uintmax_t.
6360 This is (very slightly) less likely to mess up due to wraparound.
6363 * buffer.c: Integer signedness fixes.
6364 (alloc_buffer_text, enlarge_buffer_text):
6365 Use ptrdiff_t rather than size_t when either will do, as we prefer
6368 * alloc.c: Integer signedness and overflow fixes.
6369 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6370 (__malloc_size_t): Default to size_t, not to int.
6371 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6372 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6373 Prefer ptrdiff_t to size_t when either would do, as we prefer
6375 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6376 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6377 Now const. Initialize with values that are in range even if char
6379 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6380 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6381 These functions do the right thing with sizes > 2**32.
6382 (check_depth): Now ptrdiff_t, not int.
6383 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6384 Adjust to new way of storing sizes. Check for size overflow bugs
6386 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6387 slightly wrong anyway, as it missed one instance of
6388 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6389 (refill_memory_reserve): Omit needless cast to size_t.
6390 (mark_object_loop_halt): Mark as externally visible.
6392 * xselect.c: Integer signedness and overflow fixes.
6393 (Fx_register_dnd_atom, x_handle_dnd_message):
6394 Use ptrdiff_t, not size_t, since we prefer signed.
6395 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6396 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6397 x_dnd_atoms_size and x_dnd_atoms_length.
6399 * doprnt.c: Prefer signed to unsigned when either works.
6401 * doprnt.c (doprnt):
6403 * xdisp.c (vmessage):
6404 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6405 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6406 prefer signed arithmetic to avoid comparison confusion.
6407 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6408 but is a bit tricky.
6410 Assume freestanding C89 headers, string.h, stdlib.h.
6411 * data.c, doprnt.c, floatfns.c, print.c:
6412 Include float.h unconditionally.
6413 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6414 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6415 * regex.c: Likewise for stddef.h, string.h.
6416 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6417 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6418 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6419 (STDC_HEADERS): Remove obsolete defines.
6420 * sysdep.c: Include limits.h unconditionally.
6422 Assume support for memcmp, memcpy, memmove, memset.
6423 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6424 * regex.c (memcmp, memcpy):
6425 Remove; we assume C89 now.
6427 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6428 (__malloc_safe_bcopy): Remove; no longer needed.
6430 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6431 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6432 well either way, and we prefer signed to unsigned.
6434 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6436 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6437 closes the connection while we're reading (bug#9182).
6439 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
6441 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6442 are specified (Bug#9168).
6444 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6446 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6447 Found by GCC static checking and --with-wide-int on a 32-bit host.
6449 2011-07-25 Eli Zaretskii <eliz@gnu.org>
6451 * xdisp.c (compute_display_string_pos): Fix logic of caching
6452 previous display string position. Initialize cached_prev_pos to
6453 -1. Fixes slow-down at the beginning of a buffer.
6455 2011-07-24 Eli Zaretskii <eliz@gnu.org>
6457 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6458 for attrs[LFACE_FONTSET_INDEX].
6460 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6462 * xml.c (parse_region): Remove unused local
6463 that was recently introduced.
6465 2011-07-23 Eli Zaretskii <eliz@gnu.org>
6467 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6468 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6470 * xdisp.c (move_it_in_display_line_to): Record the best matching
6471 position for TO_CHARPOS while scanning the line, and restore it on
6472 exit if none of the characters scanned was an exact match.
6473 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
6474 when exact match is impossible due to invisible text, and the
6475 lines are truncated.
6477 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6479 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6482 2011-07-22 Eli Zaretskii <eliz@gnu.org>
6484 Fix a significant slow-down of cursor motion with C-n, C-p,
6485 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6486 auto-repeat under bidi redisplay in fontified buffers.
6487 * xdisp.c (compute_stop_pos_backwards): New function.
6488 (next_element_from_buffer): Call compute_stop_pos_backwards to
6489 find a suitable prev_stop when we find ourselves before
6491 (reseat): Don't look for prev_stop, as that could mean a very long
6493 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6494 <cached_disp_overlay_modiff>: Cache for last found display string
6496 (compute_display_string_pos): Return the cached position if asked
6497 about the same buffer in the same area of character positions, and
6498 the buffer wasn't changed since the time the display string
6499 position was cached.
6501 2011-07-22 Eli Zaretskii <eliz@gnu.org>
6503 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6504 is an integer, which is important for empty lines. (Bug#9149)
6506 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
6508 * frame.c (Fmodify_frame_parameters): In tty case, update the
6509 default face if necessary (Bug#4238).
6511 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
6513 * editfns.c (Fstring_to_char): No need to explain what a character
6514 is in the docstring (Bug#6576).
6516 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6518 * xml.c (parse_region): Make sure we always return a tree.
6520 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6522 * xml.c (parse_region): If a document contains only comments,
6525 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6527 * xml.c (make_dom): Return comments, too.
6529 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6532 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6533 and the surrounding thread.
6534 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6535 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6536 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6538 * s/openbsd.h (BROKEN_SIGIO): Define.
6539 * unexelf.c (unexec) [__OpenBSD__]:
6540 Don't update the .mdebug section of the Alpha COFF symbol table.
6542 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6544 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6547 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6549 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6550 This fixes some race conditions on the permissions of any newly
6553 * alloc.c (valid_pointer_p): Use pipe, not open.
6554 This fixes some permissions issues when debugging.
6556 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6557 If fchown fails to set both uid and gid, try to set just gid,
6558 as that is sometimes allowed. Adjust the file's mode to eliminate
6559 setuid or setgid bits that are inappropriate if fchown fails.
6561 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6563 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6564 to compare Lisp_Objects.
6565 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6566 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6567 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6569 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6571 * lread.c (read_integer): Unread even EOF character.
6572 (read1): Likewise. Properly record start position of symbol.
6574 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6575 symbol character follows.
6577 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6579 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6580 This works around a problem with the previous change to Fcopy_file.
6581 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6582 and without this change, GCC might complain about discarding
6583 fchown's return value.
6585 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
6587 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6589 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6591 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6593 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6595 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6596 it's used from the C level.
6598 * process.c: Use the same condition for POLL_FOR_INPUT in both
6599 keyboard.c and process.c (bug#1858).
6601 2011-07-09 Lawrence Mitchell <wence@gmx.li>
6603 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6604 (Fgnutls_boot): Use it.
6606 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6608 * doc.c (Fsubstitute_command_keys): Revert last change.
6610 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6612 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6613 quotes the next character, and doesn't affect other longer
6614 sequences (bug#8935).
6616 * lread.c (syms_of_lread): Clarify that is isn't only
6617 `eval-buffer' and `eval-defun' that's affected by
6618 `lexical-binding' (bug#8460).
6620 2011-07-15 Eli Zaretskii <eliz@gnu.org>
6622 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6623 bidi redisplay when a line includes both an image and is truncated.
6625 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6627 Fix minor problems found by static checking.
6628 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6629 (elsz): Now a signed constant, not a size_t var. We prefer signed
6630 types to unsigned, to avoid integer comparison confusion. Without
6631 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6632 "cannot optimize loop, the loop counter may overflow", a symptom
6634 * indent.c (Fvertical_motion): Mark locals as initialized.
6635 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6637 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6639 * search.c (Fre_search_backward): Mention `case-fold-search' in
6640 all the re_search_* functions (bug#8138).
6642 * keyboard.c (Fopen_dribble_file): Document when the file is
6645 2011-07-14 Eli Zaretskii <eliz@gnu.org>
6647 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6650 Support bidi reordering of display and overlay strings.
6651 * xdisp.c (compute_display_string_pos)
6652 (compute_display_string_end): Accept additional argument STRING.
6653 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6654 (reseat_to_string): Initialize bidi_it->string.s and
6655 bidi_it->string.schars.
6656 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
6657 NULL (avoids a crash in bidi_paragraph_init).
6658 Initialize itb.string.lstring.
6659 (init_iterator): Call bidi_init_it only of a valid
6660 buffer position was specified. Initialize paragraph_embedding to
6662 (reseat_to_string): Initialize the bidi iterator.
6663 (display_string): If we need to ignore text properties of
6664 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6665 original value of -1 will not work with bidi.)
6666 (compute_display_string_pos): First arg is now struct
6667 `text_pos *'; all callers changed. Support display properties on
6669 (compute_display_string_end): Support display properties on Lisp
6671 (init_iterator, reseat_1, reseat_to_string): Initialize the
6672 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6673 when iterating on a string not from display properties).
6674 (compute_display_string_pos, compute_display_string_end):
6675 Fix calculation of the object to scan. Fixes an error when using
6677 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
6678 base_level_stop; instead, set base_level_stop to BEGV.
6679 Fixes crashes in vertical-motion.
6680 (next_element_from_buffer): Improve commentary for when
6681 the iterator is before prev_stop.
6682 (init_iterator): Initialize bidi_p from the default value of
6683 bidi-display-reordering, not from buffer-local value. Use the
6684 buffer-local value only if initializing for buffer iteration.
6685 (handle_invisible_prop): Support invisible properties on strings
6686 that are being bidi-reordered.
6687 (set_iterator_to_next): Support bidi reordering of C strings and
6689 (next_element_from_string): Support bidi reordering of Lisp
6691 (handle_stop_backwards): Support Lisp strings as well.
6692 (display_string): Support display of R2L glyph rows.
6693 Use IT_STRING_CHARPOS when displaying from a Lisp string.
6694 (init_iterator): Don't initialize it->bidi_p for strings
6696 (reseat_to_string): Initialize it->bidi_p for strings here.
6697 (next_element_from_string, next_element_from_c_string)
6698 (next_element_from_buffer): Add xassert's for correspondence
6699 between IT's object being iterated and it->bidi_it.string
6701 (face_before_or_after_it_pos): Support bidi iteration.
6702 (next_element_from_c_string): Handle the case of the first string
6703 character that is not the first one in the visual order.
6704 (get_visually_first_element): New function, refactored from common
6705 parts of next_element_from_buffer, next_element_from_string, and
6706 next_element_from_c_string.
6707 (tool_bar_lines_needed, redisplay_tool_bar)
6708 (display_menu_bar): Force left-to-right direction. Add a FIXME
6709 comment for making that be controlled by a user option.
6710 (push_it, pop_it): Save and restore the state of the
6711 bidi iterator. Save and restore the bidi_p flag.
6712 (pop_it): Iterate out of display property for string iteration as
6714 (iterate_out_of_display_property): Support iteration over strings.
6715 (handle_single_display_spec): Set up it->bidi_it for iteration
6716 over a display string, and call bidi_init_it.
6717 (handle_single_display_spec, next_overlay_string)
6718 (get_overlay_strings_1, push_display_prop): Set up the bidi
6719 iterator for displaying display or overlay strings.
6720 (forward_to_next_line_start): Don't use the shortcut if
6722 (back_to_previous_visible_line_start): If handle_display_prop
6723 pushed the iterator stack, restore the internal state of the bidi
6724 iterator by calling bidi_pop_it same number of times.
6725 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6726 and we are bidi-iterating, don't decrement the iterator position;
6727 instead, set the first_elt flag in the bidi iterator, to produce
6729 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6730 (push_display_prop): xassert that we are iterating a buffer.
6731 (push_it, pop_it): Save and restore paragraph_embedding member.
6732 (handle_single_display_spec, next_overlay_string)
6733 (get_overlay_strings_1, reseat_1, reseat_to_string)
6734 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6735 correctly. Don't assume unibyte strings are not bidi-reordered.
6736 (compute_display_string_pos)
6737 (compute_display_string_end): Fix handling the case of C string.
6738 (push_it, pop_it): Save and restore from_disp_prop_p.
6739 (handle_single_display_spec, push_display_prop): Set the
6740 from_disp_prop_p flag.
6741 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6742 (pop_it): Call iterate_out_of_display_property only if we are
6743 popping after iteration over a string that came from a display
6744 property. Fix a typo in popping stretch info. Add an assertion
6745 for verifying that the iterator position is in sync with the bidi
6747 (handle_single_display_spec, get_overlay_strings_1)
6748 (push_display_prop): Fix initialization of paragraph direction for
6749 string when that of the parent object is not yet determined.
6750 (reseat_1): Call bidi_init_it to resync the bidi
6751 iterator with IT's position. (Bug#7616)
6752 (find_row_edges): If ROW->start.pos gives position
6753 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6754 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6755 Reset the from_disp_prop_p flag.
6756 (SAVE_IT, RESTORE_IT): New macros.
6757 (pos_visible_p, face_before_or_after_it_pos)
6758 (back_to_previous_visible_line_start)
6759 (move_it_in_display_line_to, move_it_in_display_line)
6760 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6761 (try_scrolling, redisplay_window, display_line): Use them when
6762 saving a temporary copy of the iterator and restoring it back.
6763 (back_to_previous_visible_line_start, reseat_1)
6764 (init_iterator): Empty the bidi cache "stack".
6765 (move_it_in_display_line_to): If iterator ended up at
6766 EOL, but we never saw any buffer positions smaller than
6767 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6768 motion in bidi-reordered lines.
6769 (move_it_in_display_line_to): Record prev_method and prev_pos
6770 immediately before the call to set_iterator_to_next. Fixes cursor
6771 motion in bidi-reordered lines with stretch glyphs and strings
6772 displayed in margins. (Bug#8133) (Bug#8867)
6773 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6775 (pos_visible_p): Support positions in bidi-reordered lines.
6776 Save and restore bidi cache.
6778 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6779 (bidi_paragraph_info): Delete unused struct.
6780 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6781 (bidi_cache_start): New variable.
6782 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6784 (bidi_cache_fetch_state, bidi_cache_search)
6785 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6786 (bidi_cache_find, bidi_peek_at_next_level)
6787 (bidi_level_of_next_char, bidi_find_other_level_edge)
6788 (bidi_move_to_visually_next): Compare cache index with
6789 bidi_cache_start rather than with zero.
6790 (bidi_fetch_char): Accept new argument STRING; all callers
6791 changed. Support iteration over a string. Support strings with
6792 display properties. Support unibyte strings. Fix the type of
6793 `len' according to what STRING_CHAR_AND_LENGTH expects.
6794 (bidi_paragraph_init, bidi_resolve_explicit_1)
6795 (bidi_resolve_explicit, bidi_resolve_weak)
6796 (bidi_level_of_next_char, bidi_move_to_visually_next):
6797 Support iteration over a string.
6798 (bidi_set_sor_type, bidi_resolve_explicit_1)
6799 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6800 can now be zero (for strings); special values 0 and -1 were
6801 changed to -1 and -2, respectively.
6802 (bidi_char_at_pos): New function.
6803 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6804 Call it instead of FETCH_MULTIBYTE_CHAR.
6805 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6806 initialized to valid values.
6807 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6809 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6810 the test for valid cached positions. Fix the logic for looking up
6811 the sentinel state in the cache. GCPRO the Lisp string we are
6813 (bidi_push_it, bidi_pop_it): New functions.
6814 (bidi_initialize): Initialize the bidi cache start stack pointer.
6815 (bidi_cache_ensure_space): New function, refactored from part of
6816 bidi_cache_iterator_state. Don't assume the required size is just
6817 one BIDI_CACHE_CHUNK away.
6818 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6819 (bidi_count_bytes, bidi_char_at_pos): New functions.
6820 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6821 always valid if bidi_cache_idx is valid.
6822 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6823 is valid if it's going to be used.
6824 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6825 (bidi_cache_fetch_state, bidi_cache_search)
6826 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6827 (bidi_cache_iterator_state, bidi_cache_find)
6828 (bidi_find_other_level_edge, bidi_cache_start_stack):
6829 All variables related to cache indices are now EMACS_INT.
6831 * dispextern.h (struct bidi_string_data): New structure.
6832 (struct bidi_it): New member `string'. Make flag members be 1-bit
6833 fields, and put them last in the struct.
6834 (compute_display_string_pos, compute_display_string_end):
6836 (bidi_push_it, bidi_pop_it): Add prototypes.
6837 (struct iterator_stack_entry): New members bidi_p,
6838 paragraph_embedding, and from_disp_prop_p.
6839 (struct it): Member bidi_p is now a bit field 1 bit wide.
6840 (bidi_shelve_cache, bidi_unshelve_cache):
6843 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6844 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6845 and vector-like objects.
6847 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6848 cache around display iteration.
6850 * window.c (Fwindow_end, window_scroll_pixel_based)
6851 (displayed_window_lines, Frecenter): Save and restore the bidi
6852 cache around display iteration.
6854 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6856 * editfns.c (Fdelete_region): Clarify the use of the named
6857 parameters (bug#6788).
6859 2011-07-14 Martin Rudalics <rudalics@gmx.at>
6861 * indent.c (Fvertical_motion): Set and restore w->pointm when
6862 saving and restoring the window's buffer (Bug#9006).
6864 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6866 * editfns.c (Fstring_to_char): Clarify just what is returned
6867 (bug#6576). Text by Eli Zaretskii.
6869 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
6871 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6873 2011-07-13 Eli Zaretskii <eliz@gnu.org>
6875 * buffer.c (mmap_find): Fix a typo.
6877 2011-07-13 Johan Bockgård <bojohan@gnu.org>
6879 Fix execution of x selection hooks.
6880 * xselect.c (Qx_lost_selection_functions)
6881 (Qx_sent_selection_functions): New vars.
6882 (syms_of_xselect): DEFSYM them.
6883 (x_handle_selection_request): Pass Qx_sent_selection_functions
6884 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6885 (x_handle_selection_clear,x_clear_frame_selections):
6886 Pass Qx_lost_selection_functions rather than
6887 Vx_lost_selection_functions to Frun_hook_with_args.
6889 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6891 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
6892 The old code sometimes used this field without initializing it.
6894 * alloc.c (gc_sweep): Don't read past end of array.
6895 In theory, the old code could also have corrupted Emacs internals,
6896 though it'd be very unlikely.
6898 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6900 * character.c (Fcharacterp): Don't advertise optional ignored
6901 argument. (Bug#4026)
6903 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6905 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6908 * window.c (Fset_window_start): Doc fix (bug#4199).
6909 (Fset_window_hscroll): Ditto.
6911 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6913 Fix minor new problems caught by GCC 4.6.1.
6914 * term.c (init_tty): Remove unused local.
6915 * xsettings.c (store_monospaced_changed): Define this function only
6916 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
6919 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
6921 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6923 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6925 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6926 are the mini-buffer and the echo area (bug#3320).
6928 * term.c (init_tty): Remove support for supdup, c10 and perq
6929 terminals, which are no longer supported (bug#1482).
6931 2011-07-10 Johan Bockgård <bojohan@gnu.org>
6933 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6935 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6937 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6938 for non-popups (Bug#3642).
6940 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6942 * alloc.c (reset_malloc_hooks): Protoize.
6943 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
6944 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6945 * cm.c (losecursor): Likewise.
6946 * data.c (fmod): Likewise.
6947 * dispnew.c (swap_glyphs_in_rows): Likewise.
6948 * emacs.c (memory_warning_signal): Likewise.
6949 * floatfns.c (float_error): Likewise.
6950 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6951 (otf_open, font_otf_capability, generate_otf_features)
6952 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6954 * image.c (pbm_read_file): Likewise.
6955 * indent.c (string_display_width): Likewise.
6956 * intervals.c (check_for_interval, search_for_interval)
6957 (inc_interval_count, count_intervals, root_interval)
6958 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6959 * lread.c (defalias): Likewise.
6960 * ralloc.c (r_alloc_check): Likewise.
6961 * regex.c (set_image_of_range_1, set_image_of_range)
6962 (regex_grow_registers): Likewise.
6963 * sysdep.c (strerror): Likewise.
6964 * termcap.c (valid_filename_p, tprint, main): Likewise.
6965 * tparam.c (main): Likewise.
6966 * unexhp9k800.c (run_time_remap, save_data_space)
6967 (update_file_ptrs, read_header, write_header, calculate_checksum)
6968 (copy_file, copy_rest, display_header): Likewise.
6969 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6971 * xdisp.c (check_it): Likewise.
6972 * xfaces.c (register_color, unregister_color, unregister_colors):
6974 * xfns.c (print_fontset_result): Likewise.
6975 * xrdb.c (member, fatal, main): Likewise.
6977 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6979 Fix minor problems found by static checking (Bug#9031).
6980 * chartab.c (char_table_set_range, map_sub_char_table):
6981 Remove unused locals.
6982 (uniprop_table): Now static.
6983 * composite.c (_work_char): Remove unused static var.
6985 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
6987 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6989 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6991 * gtkutil.c (qttip_cb): Remove code without function.
6993 2011-07-09 Eli Zaretskii <eliz@gnu.org>
6995 * w32.c (pthread_sigmask): New stub.
6997 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
6999 Use pthread_sigmask, not sigprocmask (Bug#9010).
7000 sigprocmask is portable only for single-threaded applications, and
7001 Emacs can be multi-threaded when it uses GTK.
7002 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7004 * callproc.c (Fcall_process):
7005 * process.c (create_process):
7006 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7007 Use pthread_sigmask, not sigprocmask.
7009 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7011 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7012 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7015 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7017 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7018 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7019 (xg_hide_tooltip): Fix comment.
7021 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7022 in registerServicesMenuSendTypes.
7023 (validRequestorForSendType): Don't check ns_return_types.
7025 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7028 2011-07-08 Jason Rumney <jasonr@gnu.org>
7030 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7031 SH_SHOW for hidden windows (Bug#5482).
7033 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7034 frame struct members of non-existent frames (Bug#6284).
7036 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7038 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7039 variable firstTime not needed on OSX >= 10.6.
7040 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7041 >= 10.5. Use setKnobProportion, setDoubleValue.
7043 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7044 (MAC_OS_X_VERSION_10_5): Define if not defined.
7045 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7046 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7047 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7049 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7050 cString and lossyCString on OSX >= 10.4
7052 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
7053 sizeToFit on OSX >= 10.2.
7055 * nsimage.m (allocInitFromFile): Don't use deprecated method
7056 bestRepresentationForDevice on OSX >= 10.6.
7058 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7061 * emacs.c: Declare unexec_init_emacs_zone.
7063 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7065 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7067 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7068 on svcsMenu (Bug#8842).
7070 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7072 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7074 * nsterm.m (QUTF8_STRING): Declare.
7075 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7076 (validRequestorForSendType): Return type is (id).
7077 Change indexOfObjectIdenticalTo to indexOfObject.
7078 Check if we have local selection before returning self (Bug#8842).
7079 (writeSelectionToPasteboard): Put local selection into paste board
7080 if we have a local selection (Bug#8842).
7081 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7083 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7084 (ns_get_local_selection): Declare.
7086 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7088 * keymap.c (describe_map_tree): Don't insert a double newline at
7089 the end of the buffer (bug#1169) and return whether we inserted
7092 * callint.c (Fcall_interactively): Change "reading args" to
7093 "providing args" to try to clarify what it does (bug#1010).
7095 2011-07-07 Kenichi Handa <handa@m17n.org>
7097 * composite.c (composition_compute_stop_pos): Ignore a static
7098 composition starting before CHARPOS (Bug#8915).
7100 * xdisp.c (handle_composition_prop): Likewise.
7102 2011-07-07 Eli Zaretskii <eliz@gnu.org>
7104 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7107 2011-07-07 Kenichi Handa <handa@m17n.org>
7109 * character.h (unicode_category_t): New enum type.
7111 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7112 (Qchar_code_property_table): New variable.
7113 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7114 (UNIPROP_COMPRESSED_FORM_P): New macros.
7115 (char_table_ascii): Uncompress the compressed values.
7116 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7117 Uncompress the compressed values.
7118 (sub_char_table_ref_and_range): Likewise.
7119 (char_table_ref_and_range): Uncompress the compressed values.
7120 (sub_char_table_set): New arg is_uniprop. Callers changed.
7121 Uncompress the compressed values.
7122 (sub_char_table_set_range): Args changed. Callers changed.
7123 (char_table_set_range): Adjuted for the above change.
7124 (map_sub_char_table): Delete args default_val and parent. Add arg
7125 top. Give decoded values to a Lisp function.
7126 (map_char_table): Adjust for the above change. Give decoded
7127 values to a Lisp function. Gcpro more variables.
7128 (uniprop_table_uncompress)
7129 (uniprop_decode_value_run_length): New functions.
7130 (uniprop_decoder, uniprop_decoder_count): New variables.
7131 (uniprop_get_decoder, uniprop_encode_value_character)
7132 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7134 (uniprop_encoder, uniprop_encoder_count): New variables.
7135 (uniprop_get_encoder, uniprop_table)
7136 (Funicode_property_table_internal, Fget_unicode_property_internal)
7137 (Fput_unicode_property_internal): New functions.
7138 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7139 Sunicode_property_table_internal, Sget_unicode_property_internal,
7140 and Sput_unicode_property_internal. Defvar_lisp
7141 char-code-property-alist.
7143 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
7144 Vunicode_category_table.
7146 * font.c (font_range): Adjust for the change of
7147 Vunicode_category_table.
7149 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7151 * m/iris4d.h: Remove file, move contents ...
7152 * s/irix6-5.h: ... here.
7154 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7156 Remove unportable assumption about struct layout (Bug#8884).
7157 * alloc.c (mark_buffer):
7158 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7159 (clone_per_buffer_values): Don't assume that
7160 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7161 This isn't true in general, and it's particularly not true
7162 if Emacs is configured with --with-wide-int.
7163 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7164 New macros, used in the buffer.c change.
7166 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7168 * xsettings.c: Use both GConf and GSettings if both are available.
7169 (store_config_changed_event): Add comment.
7170 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7171 (store_tool_bar_style_changed): New functions.
7172 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
7173 (struct xsettings): Move font inside HAVE_XFT.
7174 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
7175 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
7176 Move inside HAVE_XFT.
7177 (something_changed_gsettingsCB): Rename from something_changedCB.
7178 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7180 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
7181 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
7182 (something_changed_gconfCB): Rename from something_changedCB.
7183 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7184 (parse_settings): Move check for font inside HAVE_XFT.
7185 (read_settings, apply_xft_settings): Add comment.
7186 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7187 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7188 call store_font_name_changed.
7189 (xft_settings_event): Add comment.
7190 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7191 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7192 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7193 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7194 (xsettings_initialize): Call init_gsettings last.
7195 (xsettings_get_system_font, xsettings_get_system_normal_font):
7198 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7200 Random fixes. E.g., (random) never returned negative values.
7201 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7202 subseconds part to the entropy, as that's a bit more random.
7203 Prefer signed to unsigned, since the signedness doesn't matter and
7204 in general we prefer signed. When given a limit, use a
7205 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7206 latter isn't right if USE_2_TAGS_FOR_INTS.
7207 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7208 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7210 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7212 * textprop.c (text_property_stickiness):
7213 Obey Vtext_property_default_nonsticky.
7214 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7215 * w32fns.c (syms_of_w32fns):
7216 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7218 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7220 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7221 This is more efficient than Ffile_directory_p and avoids a minor race.
7223 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7225 * buffer.c (Foverlay_put): Say what the return value is
7228 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7229 is a directory before asking whether to use the file name
7231 (barf_or_query_if_file_exists): Make the "File is a directory"
7232 error be more correct.
7234 * fns.c (Frequire): Remove the mention of the .gz files, since
7235 that's installation-specific, but keep the mention of
7236 `get-load-suffixes'.
7238 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7240 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7241 Report string overflow if the output is too long.
7243 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
7245 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7246 (syms_of_gnutls): Remove duplicate DEFSYM for
7247 Qgnutls_bootprop_verify_hostname_error, an error for
7248 Qgnutls_bootprop_verify_error (which is no longer used).
7250 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7251 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7252 Also (re)move comments that are misplaced or no longer relevant.
7254 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7256 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7258 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
7260 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7261 and background color parameters if they have been changed.
7263 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7265 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7267 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7269 * xsettings.c (SYSTEM_FONT): Define only when used.
7270 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7272 * keymap.c (access_keymap_1): Now static.
7274 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
7276 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7277 leave any prefix arg for the up event (Bug#1586).
7279 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7281 * lread.c (syms_of_lread): Mention single symbols defined by
7282 `defvar' or `defconst' (bug#7154).
7284 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7285 (Frequire): Mention get-load-suffixes.
7287 2011-07-02 Martin Rudalics <rudalics@gmx.at>
7289 * window.h (window): Remove clone_number slot.
7290 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7292 (make_parent_window, make_window, saved_window)
7293 (Fset_window_configuration, save_window_save): Don't deal with
7295 * buffer.c (Qclone_number): Remove declaration.
7296 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7298 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7300 Add multiple inheritance to keymaps.
7301 * keymap.c (Fmake_composed_keymap): New function.
7302 (Fset_keymap_parent): Simplify.
7303 (fix_submap_inheritance): Remove.
7304 (access_keymap_1): New function extracted from access_keymap to handle
7305 embedded parents and handle lists of maps.
7306 (access_keymap): Use it.
7307 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7308 (Fcopy_keymap): Handle embedded parents.
7309 (Fcommand_remapping, define_as_prefix): Simplify.
7310 (Fkey_binding): Simplify.
7311 (syms_of_keymap): Move minibuffer-local-completion-map,
7312 minibuffer-local-filename-completion-map,
7313 minibuffer-local-must-match-map, and
7314 minibuffer-local-filename-must-match-map to Elisp.
7315 (syms_of_keymap): Defsubr make-composed-keymap.
7316 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7317 (parse_menu_item): Trivial simplification.
7319 2011-07-01 Glenn Morris <rgm@gnu.org>
7321 * Makefile.in (SETTINGS_LIBS): Fix typo.
7323 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7325 * coding.c (Fencode_coding_string): Record the last coding system
7326 used, as the function doc string says (bug#8738).
7328 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7330 * xsettings.c (store_monospaced_changed): Take new font as arg and
7331 check for change against current_mono_font.
7332 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7333 (emacs_settings_constructor, emacs_settings_get_property)
7334 (emacs_settings_set_property, emacs_settings_class_init)
7335 (emacs_settings_init, gsettings_obj): Remove.
7336 (something_changedCB): New function for HAVE_GSETTINGS.
7337 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7338 with value as argument.
7339 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7340 g_settings_new (Bug#8967). Do not create gsettings_obj.
7341 Remove calls to g_settings_bind. Connect something_changedCB to
7344 * xgselect.c: Add defined (HAVE_GSETTINGS).
7345 (xgselect_initialize): Ditto.
7347 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7348 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7351 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7353 * eval.c (struct backtrace): Simplify and port the data structure.
7354 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7355 signed bit field, as this assumption is not portable and it makes
7356 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7357 "char debug_on_exit : 1" as this is not portable either; instead,
7358 use the portable "unsigned int debug_on_exit : 1". Remove unused
7359 member evalargs. Remove obsolete comments about cc bombing out.
7361 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7363 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
7364 Let HAVE_GSETTINGS override HAVE_GCONF.
7365 (store_monospaced_changed): New function.
7366 (EMACS_SETTINGS): A new type derived from GObject to handle
7367 GSettings notifications.
7368 (emacs_settings_constructor, emacs_settings_get_property)
7369 (emacs_settings_set_property, emacs_settings_class_init):
7371 (gsettings_client, gsettings_obj): New variables.
7372 (GSETTINGS_SCHEMA): New define.
7373 (something_changedCB): Call store_monospaced_changed.
7374 (init_gsettings): New function.
7375 (xsettings_initialize): Call init_gsettings.
7376 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7379 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
7382 2011-06-29 Martin Rudalics <rudalics@gmx.at>
7384 * window.c (resize_root_window, grow_mini_window)
7385 (shrink_mini_window): Rename Qresize_root_window to
7386 Qwindow_resize_root_window and Qresize_root_window_vertically to
7387 Qwindow_resize_root_window_vertically.
7389 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7391 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7393 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
7395 * makefile.w32-in: Redesign dependencies so they reflect more
7396 clearly which files are directly included by each source file,
7397 and not through other includes.
7399 2011-06-27 Martin Rudalics <rudalics@gmx.at>
7401 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7402 (sort_overlays, overlay_strings): When an overlay's clone number
7403 matches the window's clone number process the overlay even if
7404 the overlay's window property doesn't match the current window.
7406 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7407 (Fwindow_hchild): Rename to Fwindow_left_child.
7408 (Fwindow_next): Rename to Fwindow_next_sibling.
7409 (Fwindow_prev): Rename to Fwindow_prev_sibling.
7410 (resize_window_check): Rename to window_resize_check.
7411 (resize_window_apply): Rename to window_resize_apply.
7412 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7413 (Fdelete_other_windows_internal, resize_frame_windows)
7414 (Fsplit_window_internal, Fdelete_window_internal)
7415 (grow_mini_window, shrink_mini_window)
7416 (Fresize_mini_window_internal): Fix callers accordingly.
7418 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7420 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7421 (emacs_fixed_set_min_size): Remove.
7422 (emacs_fixed_new): Take frame as argument.
7424 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7425 (_EmacsFixedPrivate): Remove minwidth/height.
7426 Add struct frame *f.
7427 (emacs_fixed_init): Initialize priv->f.
7428 (get_parent_class, emacs_fixed_set_min_size): Remove.
7429 (emacs_fixed_new): Set priv->f to argument.
7430 (emacs_fixed_get_preferred_width)
7431 (emacs_fixed_get_preferred_height): Use min_width/height from
7432 frames size_hint to set minimum and natural (Bug#8919).
7433 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7434 and use min_width/height from frames size_hint to set
7435 min_width/height (Bug#8919).
7437 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
7438 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7441 2011-06-26 Eli Zaretskii <eliz@gnu.org>
7443 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7444 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7447 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
7449 * process.c (wait_reading_process_output): Bypass select if
7450 waiting for a cell while ignoring keyboard input, and input is
7451 pending. Suggested by Jan Djärv (Bug#8869).
7453 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7455 Use gnulib's dup2 module instead of rolling our own.
7456 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7458 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7460 * dispnew.c (scrolling_window): Before scrolling, turn off a
7461 mouse-highlight in the window being scrolled.
7463 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
7465 Move DEFSYM to lisp.h and use everywhere.
7467 * character.h (DEFSYM): Move declaration...
7468 * lisp.h (DEFSYM): ...here.
7474 * w32select.c: Don't include character.h.
7476 * alloc.c (syms_of_alloc):
7477 * buffer.c (syms_of_buffer):
7478 * bytecode.c (syms_of_bytecode):
7479 * callint.c (syms_of_callint):
7480 * casefiddle.c (syms_of_casefiddle):
7481 * casetab.c (init_casetab_once):
7482 * category.c (init_category_once, syms_of_category):
7483 * ccl.c (syms_of_ccl):
7484 * cmds.c (syms_of_cmds):
7485 * composite.c (syms_of_composite):
7486 * dbusbind.c (syms_of_dbusbind):
7487 * dired.c (syms_of_dired):
7488 * dispnew.c (syms_of_display):
7489 * doc.c (syms_of_doc):
7490 * editfns.c (syms_of_editfns):
7491 * emacs.c (syms_of_emacs):
7492 * eval.c (syms_of_eval):
7493 * fileio.c (syms_of_fileio):
7494 * fns.c (syms_of_fns):
7495 * frame.c (syms_of_frame):
7496 * fringe.c (syms_of_fringe):
7497 * insdel.c (syms_of_insdel):
7498 * keymap.c (syms_of_keymap):
7499 * lread.c (init_obarray, syms_of_lread):
7500 * macros.c (syms_of_macros):
7501 * msdos.c (syms_of_msdos):
7502 * print.c (syms_of_print):
7503 * process.c (syms_of_process):
7504 * search.c (syms_of_search):
7505 * sound.c (syms_of_sound):
7506 * syntax.c (init_syntax_once, syms_of_syntax):
7507 * terminal.c (syms_of_terminal):
7508 * textprop.c (syms_of_textprop):
7509 * undo.c (syms_of_undo):
7510 * w32.c (globals_of_w32):
7511 * window.c (syms_of_window):
7512 * xdisp.c (syms_of_xdisp):
7513 * xfaces.c (syms_of_xfaces):
7514 * xfns.c (syms_of_xfns):
7515 * xmenu.c (syms_of_xmenu):
7516 * xsettings.c (syms_of_xsettings):
7517 * xterm.c (syms_of_xterm): Use DEFSYM.
7519 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7521 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
7523 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7525 Integer and buffer overflow fixes (Bug#8873).
7527 * print.c (printchar, strout): Check for string overflow.
7528 (PRINTPREPARE, printchar, strout):
7529 Don't set size unless allocation succeeds.
7531 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7532 for sizes. Check for string overflow more accurately.
7533 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7535 * macros.c: Integer and buffer overflow fixes.
7536 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7537 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7538 Use ptrdiff_t, not int, for sizes.
7539 Don't increment bufsize until after realloc succeeds.
7540 Check for size-calculation overflow.
7541 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7543 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7545 * lread.c: Integer overflow fixes.
7546 (read_integer): Radix is now EMACS_INT, not int,
7547 to improve quality of diagnostics for out-of-range radices.
7548 Calculate buffer size correctly for out-of-range radices.
7549 (read1): Check for integer overflow in radices, and in
7550 read-circle numbers.
7551 (read_escape): Avoid int overflow.
7552 (Fload, openp, read_buffer_size, read1)
7553 (substitute_object_recurse, read_vector, read_list, map_obarray):
7554 Use ptrdiff_t, not int, for sizes.
7555 (read1): Use EMACS_INT, not int, for sizes.
7556 Check for size overflow.
7558 * image.c (cache_image): Check for size arithmetic overflow.
7560 * lread.c: Integer overflow issues.
7561 (saved_doc_string_size, saved_doc_string_length)
7562 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7563 Now ptrdiff_t, not int.
7564 (read1): Don't assume doc string length fits in int. Check for
7565 out-of-range doc string lengths.
7566 (read_list): Don't assume file position fits in int.
7567 (read_escape): Check for hex character overflow.
7569 2011-06-22 Leo Liu <sdl.web@gmail.com>
7571 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7572 Move to minibuffer.el.
7574 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7576 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
7577 The following patches are for when GLYPH_DEBUG && !XASSERT.
7578 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7579 * dispnew.c (flush_stdout):
7580 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7581 Mark as externally visible.
7582 * dispnew.c (check_window_matrix_pointers): Now static.
7583 * dispnew.c (window_to_frame_vpos):
7584 * xfns.c (unwind_create_frame):
7585 * xterm.c (x_check_font): Remove unused local.
7586 * scroll.c (CHECK_BOUNDS):
7587 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7588 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7589 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7590 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7591 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7593 (debug_method_add): Use va_list and vsprintf rather than relying
7594 on undefined behavior with wrong number of arguments.
7595 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7596 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7597 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7598 since we're not interested in debugging glyphs with old libraries.
7599 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7600 GCC 4.6.0's static checking.
7602 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7604 Integer overflow and signedness fixes (Bug#8873).
7605 A few related buffer overrun fixes, too.
7607 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7609 * dispextern.h (struct face.stipple):
7610 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7611 (x_bitmap_mask, x_allocate_bitmap_record)
7612 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7613 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7614 (x_create_bitmap_from_xpm_data):
7615 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7616 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7618 * xfaces.c (load_pixmap):
7619 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7620 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7621 (.bitmaps_last, struct x_output.icon_bitmap):
7622 Use ptrdiff_t, not int, for bitmap indexes.
7623 (x_allocate_bitmap_record): Check for size overflow.
7624 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7626 Use ptrdiff_t, not int, for overlay counts.
7627 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7628 * editfns.c (overlays_around, get_pos_property):
7629 * textprop.c (get_char_property_and_overlay):
7630 * xdisp.c (next_overlay_change, note_mouse_highlight):
7631 * xfaces.c (face_at_buffer_position):
7632 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7633 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7634 (Fnext_overlay_change, Fprevious_overlay_change)
7635 (mouse_face_overlay_overlaps, Foverlays_in):
7636 Use ptrdiff_t, not int, for sizes.
7637 (overlays_at, overlays_in): Check for size-calculation overflow.
7639 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7641 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7642 (x_session_initialize): Do not assume string length fits in int.
7644 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7645 This is unlikely, but can occur if DPI is outlandish.
7647 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
7648 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7650 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7651 * xrdb.c (magic_file_p, search_magic_path):
7652 Omit last arg SUFFIX; it was always 0. All callers changed.
7653 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7655 * xfont.c (xfont_match): Avoid need for strlen.
7657 * xfns.c: Don't assume strlen fits in int.
7658 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7660 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7661 not unsigned long, as we prefer signed integers. All callers changed.
7662 Detect integer overflow in repeat count.
7663 (message_dolog): Don't assume print length fits in 39 bytes.
7664 (display_mode_element): Don't assume strlen fits in int.
7666 * termcap.c: Don't assume sizes fit in int and never overflow.
7667 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7668 (gobble_line): Check for size-calculation overflow.
7670 * minibuf.c (Fread_buffer):
7671 * lread.c (intern, intern_c_string):
7672 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7673 Don't assume string length fits in int.
7675 * keyboard.c (parse_tool_bar_item):
7676 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7678 * font.c: Don't assume string length fits in int.
7679 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7680 Use ptrdiff_t, not int.
7681 (font_intern_prop): Don't assume string length fits in int.
7682 Don't assume integer property fits in fixnum.
7683 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
7685 * filelock.c: Fix some buffer overrun and integer overflow issues.
7686 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
7687 Reformulate so as not to need the command string.
7688 Invoke gzip -cd rather than gunzip, as it's more portable.
7689 (lock_info_type, lock_file_1, lock_file):
7690 Don't assume pid_t and time_t fit in unsigned long.
7691 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7692 (current_lock_owner): Prefer signed type for sizes.
7693 Use memcpy, not strncpy, where memcpy is what is really wanted.
7694 Don't assume (via atoi) that time_t and pid_t fit in int.
7695 Check for time_t and/or pid_t out of range, e.g., via a network share.
7696 Don't alloca where an auto var works fine.
7698 * fileio.c: Fix some integer overflow issues.
7699 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7700 Don't assume string length fits in int.
7701 (directory_file_name): Don't assume string length fits in long.
7702 (make_temp_name): Don't assume pid fits in int, or that its print
7703 length is less than 20.
7705 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7707 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7709 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7711 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7712 We prefer signed integers, even for size calculations.
7714 * emacs.c: Don't assume string length fits in 'int'.
7715 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7716 (main): Don't invoke strlen when not needed.
7718 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7719 (XD_DEBUG_MESSAGE): Don't waste a byte.
7721 * callproc.c (getenv_internal_1, getenv_internal)
7723 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7725 * lread.c (invalid_syntax): Omit length argument.
7726 All uses changed. This doesn't fix a bug, but it simplifies the
7727 code away from its former Hollerith-constant appearance, and it's
7728 one less 'int' to worry about when looking at integer-overflow issues.
7729 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
7731 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7732 This didn't break anything, but it didn't help either.
7733 It's confusing to put a bogus integer in a place where the actual
7734 value does not matter.
7735 (LIST_END_P): Remove unused macro and its bogus comment.
7736 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
7738 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7739 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7741 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7742 We prefer signed types, and the value cannot exceed the EMACS_INT
7743 range anyway (because otherwise the length would not be representable).
7744 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7745 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7746 This avoids a GCC warning when WIDE_EMACS_INT.
7748 * indent.c (sane_tab_width): New function.
7749 (current_column, scan_for_column, Findent_to, position_indentation)
7750 (compute_motion): Use it. This is just for clarity.
7751 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
7753 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
7755 * lisp.h (lint_assume): New macro.
7756 * composite.c (composition_gstring_put_cache):
7757 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7759 * editfns.c, insdel.c:
7760 Omit unnecessary forward decls, to simplify future changes.
7762 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7764 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7766 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
7767 Use much-faster test for byte-length change.
7768 Don't assume string byte-length fits in 'int'.
7769 Check that character arg fits in 'int'.
7770 (mapcar1): Declare byte as byte, for clarity.
7772 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7774 * fns.c (concat): Catch string overflow earlier.
7775 Do not rely on integer wraparound.
7777 * dispextern.h (struct it.overlay_strings_charpos)
7778 (struct it.selective): Now EMACS_INT, not int.
7779 * xdisp.c (forward_to_next_line_start)
7780 (back_to_previous_visible_line_start)
7781 (reseat_at_next_visible_line_start, next_element_from_buffer):
7782 Don't arbitrarily truncate the value of 'selective' to int.
7784 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7786 * composite.c: Don't truncate sizes to 'int'.
7787 (composition_gstring_p, composition_reseat_it)
7788 (composition_adjust_point): Use EMACS_INT, not int.
7789 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7790 not EMACS_UINT, for indexes.
7792 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7794 * buffer.c: Include <verify.h>.
7795 (struct sortvec.priority, struct sortstr.priority):
7796 Now EMACS_INT, not int.
7797 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
7798 (struct sortstr.size, record_overlay_string)
7799 (struct sortstrlist.size, struct sortlist.used):
7800 Don't truncate size to int.
7801 (record_overlay_string): Check for size-calculation overflow.
7802 (init_buffer_once): Check at compile-time, not run-time.
7804 2011-06-22 Jim Meyering <meyering@redhat.com>
7806 Don't leak an XBM-image-sized buffer
7807 * image.c (xbm_load): Free the image buffer after using it.
7809 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7812 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7813 that Sun C diagnosed.
7814 * fns.c (secure_hash): Fix pointer signedness issue.
7815 * intervals.c (static_offset_intervals): New function.
7816 (offset_intervals): Use it.
7818 2011-06-21 Leo Liu <sdl.web@gmail.com>
7821 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7824 * fns.c (secure_hash): Rename from crypto_hash_function and change
7825 the first arg to accept symbols.
7826 (Fsecure_hash): New primitive.
7827 (syms_of_fns): New symbols.
7829 2011-06-20 Deniz Dogan <deniz@dogan.se>
7831 * process.c (Fset_process_buffer): Clarify return value in
7834 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
7836 * dispnew.c (add_window_display_history): Use BVAR.
7838 * xdisp.c (debug_method_add): Use BVAR.
7839 (check_window_end, dump_glyph_matrix, dump_glyph)
7840 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7842 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7845 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7846 check till after the cache is created in init_frame_faces.
7848 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7850 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7852 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7854 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7855 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7856 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7858 Improve buffer-overflow checking (Bug#8873).
7859 * fileio.c (Finsert_file_contents):
7860 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7861 Remove the old (too-loose) buffer overflow checks.
7862 They weren't needed, since make_gap checks for buffer overflow.
7863 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7864 The old code merely checked for Emacs fixnum overflow, and relied
7865 on undefined (wraparound) behavior. The new code avoids undefined
7866 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7868 * editfns.c (Finsert_char): Don't dump core with very negative counts.
7869 Tune. Don't use wider integers than needed. Don't use alloca.
7870 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
7872 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7874 * insdel.c, lisp.h (buffer_overflow): New function.
7875 (insert_from_buffer_1, replace_range, replace_range_2):
7876 * insdel.c (make_gap_larger):
7877 * editfns.c (Finsert_char):
7878 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7880 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7882 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7884 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
7886 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7887 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7889 * fileio.c: Don't assume EMACS_INT fits in off_t.
7890 (emacs_lseek): New static function.
7891 (Finsert_file_contents, Fwrite_region): Use it.
7892 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7894 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7896 * fns.c: Don't overflow int when computing a list length.
7897 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7898 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7899 truncation on 64-bit hosts. Check for QUIT every
7900 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7901 faster and is responsive enough.
7902 (Flength): Report an error instead of overflowing an integer.
7903 (Fsafe_length): Return a float if the value is not representable
7904 as a fixnum. This shouldn't happen except in contrived situations.
7905 (Fnthcdr, Fsort): Don't assume list length fits in int.
7906 (Fcopy_sequence): Don't assume vector length fits in int.
7908 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7909 (header_size, word_size): New constants.
7910 (allocate_vectorlike): Don't check size overflow here.
7911 (allocate_vector): Check it here instead, since this is the only
7912 caller of allocate_vectorlike that could cause overflow.
7913 Check that the new vector's length is representable as a fixnum.
7915 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7916 The previous code was bogus. For example, next_almost_prime (32)
7917 returned 39, which is undesirable as it is a multiple of 3; and
7918 next_almost_prime (24) returned 25, which is a multiple of 5 so
7919 why was the code bothering to check for multiples of 7?
7921 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7923 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7925 Variadic C functions now count arguments with ptrdiff_t.
7926 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7927 Back then I didn't know that the Emacs coding style prefers signed int.
7928 Also, in the meantime I found a few more instances where arguments
7929 were being counted with int, which may truncate counts on 64-bit
7930 machines, or EMACS_INT, which may be unnecessarily wide.
7931 * lisp.h (struct Lisp_Subr.function.aMANY)
7932 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7933 Arg counts are now ptrdiff_t, not size_t.
7934 All variadic functions and their callers changed accordingly.
7935 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7936 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7937 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7938 * callint.c (Fcall_interactively): Check arg count for overflow,
7939 to avoid potential buffer overrun. Use signed char, not 'int',
7940 for 'varies' array, so that we needn't bother to check its size
7941 calculation for overflow.
7942 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7943 * eval.c (apply_lambda):
7944 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7945 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7946 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7948 * callint.c (Fcall_interactively): Don't use index var as event count.
7950 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7951 * mem-limits.h (SIZE): Remove; no longer used.
7953 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
7955 Remove unnecessary casts.
7956 * xterm.c (x_term_init):
7957 * xfns.c (x_set_border_pixel):
7958 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7959 These aren't needed now that we assume ANSI C.
7961 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7962 It's more likely to cause problems (due to unsigned overflow)
7965 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7967 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7969 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7971 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7973 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7975 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7977 GLYPH_CODE_FACE returns EMACS_INT, not int.
7978 * dispextern.h (merge_faces):
7979 * xfaces.c (merge_faces):
7980 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7981 Don't assume EMACS_INT fits in int.
7983 * character.h (CHAR_VALID_P): Remove unused parameter.
7984 * fontset.c, lisp.h, xdisp.c: All uses changed.
7986 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7988 * fns.c (concat): Minor tuning based on overflow analysis.
7989 This doesn't fix any bugs. Use int to hold character, instead
7990 of constantly refetching from Emacs object. Use XFASTINT, not
7991 XINT, for value known to be a character. Don't bother comparing
7992 a single byte to 0400, as it's always less.
7994 * floatfns.c (Fexpt):
7995 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7997 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8000 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8002 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8003 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8004 incorrectly succeed when S was a string, because 4294967386 was
8005 truncated before it was used.
8007 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8008 Otherwise, an out-of-range integer could cause undefined behavior
8011 * composite.c: Use int, not EMACS_INT, for characters.
8012 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8013 EMACS_INT, for values that are known to be in character range.
8014 This doesn't fix any bugs but is the usual style inside Emacs and
8015 may generate better code on 32-bit machines.
8017 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8018 This is for reasons similar to the recent CHAR_STRING fix.
8019 * charset.c (Fencode_char): Check that character arg is actually
8020 a character. Pass an int to ENCODE_CHAR.
8021 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8022 wider than 'int', as a compile-time check to prevent future regressions
8025 * character.c (char_string): Remove unnecessary casts.
8027 Make sure a 64-bit char is never passed to CHAR_STRING.
8028 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8029 by silently ignoring the top 32 bits, allowing some values
8030 that were far too large to be valid characters.
8031 * character.h: Include <verify.h>.
8032 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8033 arguments are no wider than unsigned, as a compile-time check
8034 to prevent future regressions in this area.
8036 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
8037 (Fsubst_char_in_region):
8039 * xdisp.c (decode_mode_spec_coding):
8040 Adjust to CHAR_STRING's new requirement.
8041 * editfns.c (Finsert_char, Fsubst_char_in_region):
8042 * fns.c (concat): Check that character args are actually
8043 characters. Without this test, these functions did the wrong
8044 thing with wildly out-of-range values on 64-bit hosts.
8046 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8047 These casts should not be needed on 32-bit hosts, either.
8048 * keyboard.c (read_char):
8049 * lread.c (Fload): Remove casts to unsigned.
8051 * lisp.h (UNSIGNED_CMP): New macro.
8052 This fixes comparison bugs on 64-bit hosts.
8053 (ASCII_CHAR_P): Use it.
8054 * casefiddle.c (casify_object):
8055 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
8056 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8057 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8058 * dispextern.h (FACE_FROM_ID):
8059 * keyboard.c (read_char): Use UNSIGNED_CMP.
8061 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8062 not to EMACS_INT, to avoid GCC warning.
8064 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8066 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8067 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8068 isn't needed on 32-bit machines.
8070 * buffer.c (Fgenerate_new_buffer_name):
8071 Use EMACS_INT for count, not int.
8072 (advance_to_char_boundary): Return EMACS_INT, not int.
8074 * data.c (Qcompiled_function): Now static.
8076 * window.c (window_body_lines): Now static.
8078 * image.c (gif_load): Rename local to avoid shadowing.
8080 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8081 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8082 * alloc.c (make_save_value): Integer argument is now of type
8084 (mark_object): Use ptrdiff_t, not int.
8085 * lisp.h (pD): New macro.
8086 * print.c (print_object): Use it.
8088 * alloc.c: Use EMACS_INT, not int, to count objects.
8089 (total_conses, total_markers, total_symbols, total_vector_size)
8090 (total_free_conses, total_free_markers, total_free_symbols)
8091 (total_free_floats, total_floats, total_free_intervals)
8092 (total_intervals, total_strings, total_free_strings):
8093 Now EMACS_INT, not int. All uses changed.
8094 (Fgarbage_collect): Compute overall total using a double, so that
8095 integer overflow is less likely to be a problem. Check for overflow
8096 when converting back to an integer.
8097 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8098 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8099 These were 'int' variables that could overflow on 64-bit hosts;
8100 they were never used, so remove them instead of repairing them.
8101 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
8102 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8103 Previously, this ceilinged at INT_MAX, but that doesn't work on
8105 (allocate_pseudovector): Don't use EMACS_INT when int would do.
8107 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
8108 (allocate_vectorlike): Check for ptrdiff_t overflow.
8109 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8110 when a (possibly-narrower) signed value would do just as well.
8111 We prefer using signed arithmetic, to avoid comparison confusion.
8113 * alloc.c: Catch some string size overflows that we were missing.
8114 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8115 for convenience in STRING_BYTES_MAX.
8116 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8117 The definition here is exact; the one in lisp.h was approximate.
8118 (allocate_string_data): Check for string overflow. This catches
8119 some instances we weren't catching before. Also, it catches
8120 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8121 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8122 and ptrdiff_t and EMACS_INT are both 64 bits.
8124 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8125 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
8126 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
8128 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8130 * alloc.c (Fmake_string): Check for out-of-range init.
8132 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8134 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8136 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8138 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8139 xg_get_default_scrollbar_width.
8141 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8142 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8143 (style_changed_cb): Call update_theme_scrollbar_width and call
8144 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8145 all frames (Bug#8505).
8146 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8147 Call gtk_window_set_resizable if HAVE_GTK3.
8148 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8149 and height if HAVE_GTK3 (Bug#8505).
8150 (scroll_bar_width_for_theme): New variable.
8151 (update_theme_scrollbar_width): New function.
8152 (xg_get_default_scrollbar_width): Move code to
8153 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8154 (xg_initialize): Call update_theme_scrollbar_width.
8156 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8158 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8160 2011-06-12 Martin Rudalics <rudalics@gmx.at>
8162 * frame.c (make_frame): Call other_buffer_safely instead of
8165 * window.c (temp_output_buffer_show): Call display_buffer with
8166 second argument Vtemp_buffer_show_specifiers and reset latter
8167 immediately after the call.
8168 (Vtemp_buffer_show_specifiers): New variable.
8169 (auto_window_vscroll_p, next_screen_context_lines)
8170 (Vscroll_preserve_screen_position): Remove leading asterisks from
8173 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
8175 Fix minor problems found by GCC 4.6.0 static checking.
8176 * buffer.c (Qclone_number): Remove for now, as it's unused.
8177 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8178 (record_buffer): Remove unused local.
8179 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8180 (set_frame_buffer_list): Remove; unused.
8181 * frame.h (other_visible_frames): Remove decl.
8182 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8183 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8184 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8186 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8187 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8188 Define only if HAVE_GPM.
8189 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8190 (update_hints_inhibit): Remove; never set. All uses removed.
8191 * widgetprv.h (emacsFrameClassRec): Remove decl.
8192 * window.c (delete_deletable_window): Now returns void, since it
8193 wasn't returning anything.
8194 (compare_window_configurations): Remove unused locals.
8195 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8196 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
8197 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8198 the same widths as pointers. This follows up on the 2011-05-06 patch.
8199 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8200 * xterm.h: Likewise.
8201 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8203 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
8205 * makefile.w32-in: Update dependencies.
8206 (LISP_H): Add lib/intprops.h.
8208 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
8210 * image.c (gif_load): Add animation frame delay to the metadata.
8211 (syms_of_image): Use DEFSYM. New symbol `delay'.
8213 2011-06-11 Martin Rudalics <rudalics@gmx.at>
8215 * window.c (delete_deletable_window): Re-add.
8216 (Fset_window_configuration): Rewrite to handle dead buffers and
8217 consequently deletable windows.
8218 (window_tree, Fwindow_tree): Remove. Supply functionality in
8220 (compare_window_configurations): Simplify code.
8222 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8224 * image.c (imagemagick_load_image): Fix type mismatch.
8225 (Fimagemagick_types): Likewise.
8227 * window.h (replace_buffer_in_windows): Declare.
8229 2011-06-11 Martin Rudalics <rudalics@gmx.at>
8231 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8232 Qclone_number. Remove external declaration of Qdelete_window.
8233 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8235 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8236 Run Qbuffer_list_update_hook if allowed.
8237 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8238 buffer list implementation.
8239 (other_buffer_safely): New function.
8240 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8241 calls to replace_buffer_in_windows and
8242 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8244 (record_buffer): Inhibit quitting and rewrite using quittable
8245 functions. Run Qbuffer_list_update_hook if allowed.
8246 (Frecord_buffer, Funrecord_buffer): New functions.
8247 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8248 Move switch-to-buffer to window.el.
8249 (bury-buffer): Move to window.el.
8250 (Vbuffer_list_update_hook): New variable.
8252 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8255 * window.h (resize_frame_windows): Move up in code.
8256 (Fwindow_frame): Remove EXFUN.
8257 (replace_buffer_in_all_windows): Remove prototype.
8258 (replace_buffer_in_windows_safely): Add prototype.
8260 * window.c: Declare Qdelete_window static again. Move down
8261 declaration of select_count.
8262 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8263 (Fother_window): Move to window.el.
8264 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8265 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8266 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8268 (replace_buffer_in_windows): Implement by calling
8269 Qreplace_buffer_in_windows.
8270 (replace_buffer_in_all_windows): Remove with some functionality
8271 moved into replace_buffer_in_windows_safely.
8272 (replace_buffer_in_windows_safely): New function.
8273 (select_window_norecord, select_frame_norecord): Move in front
8274 of run_window_configuration_change_hook. Remove now obsolete
8276 (Fset_window_buffer): Rewrite doc-string.
8277 Call Qrecord_window_buffer.
8278 (keys_of_window): Move binding for other-window to window.el.
8280 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
8282 * dispextern.h (struct image): Replace data member, whose int_val
8283 and ptr_val fields were not used by anything, with a single
8286 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8287 (gif_clear_image, gif_load, imagemagick_load_image)
8288 (gs_clear_image, gs_load): Callers changed.
8290 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8292 * buffer.h: Include <time.h>, for time_t.
8293 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8295 Fix minor problems found by static checking.
8297 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8299 Make identifiers static if they are not used in other modules.
8300 * data.c (Qcompiled_function, Qframe, Qvector):
8301 * image.c (QimageMagick, Qsvg):
8302 * minibuf.c (Qmetadata):
8303 * window.c (resize_window_check, resize_root_window): Now static.
8304 * window.h (resize_window_check, resize_root_window): Remove decls.
8306 * window.c (window_deletion_count, delete_deletable_window):
8308 (window_body_lines): Now static.
8309 (Fdelete_other_windows_internal): Mark vars as initialized.
8310 Make sure 'resize_failed' is initialized.
8311 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8312 (resize_window_apply): Remove unused local.
8313 * window.h (delete_deletable_window): Remove decl.
8315 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
8316 (imagemagick_load_image): Fix pointer signedness problem by changing
8317 last arg from unsigned char * to char *. All uses changed.
8318 Also, fix a local for similar reasons.
8319 Remove unused locals. Remove locals to avoid shadowing.
8320 (fn_rsvg_handle_free): Remove; unused.
8321 (svg_load, svg_load_image): Fix pointer signedness problem.
8322 (imagemagick_load_image): Don't use garbage pointer image_wand.
8324 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8326 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
8328 * image.c (gif_load): Fix omitted cast error introduced by
8331 2011-06-10 Martin Rudalics <rudalics@gmx.at>
8333 * window.h (resize_proportionally, orig_total_lines)
8334 (orig_top_line): Remove from window structure.
8335 (set_window_height, set_window_width, change_window_heights)
8336 (Fdelete_window): Remove prototypes.
8337 (resize_frame_windows): Remove duplicate declaration.
8339 2011-06-10 Eli Zaretskii <eliz@gnu.org>
8341 * window.h (resize_frame_windows, resize_window_check)
8342 (delete_deletable_window, resize_root_window)
8343 (resize_frame_windows): Declare prototypes.
8345 * window.c (resize_window_apply): Make definition be "static" to
8346 match the prototype.
8348 2011-06-10 Martin Rudalics <rudalics@gmx.at>
8350 * window.c: Remove declarations of Qwindow_size_fixed,
8351 window_min_size_1, window_min_size_2, window_min_size,
8352 size_window, window_fixed_size_p, enlarge_window, delete_window.
8353 Remove static from declaration of Qdelete_window, it's
8354 temporarily needed by Fbury_buffer.
8355 (replace_window): Don't assign orig_top_line and
8357 (Fdelete_window, delete_window): Remove. Window deletion is
8358 handled by window.el.
8359 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8360 Replace Fdelete_window calls with calls to Qdelete_window.
8361 (Fdelete_other_windows): Remove. Deleting other windows is
8362 handled by window.el.
8363 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8364 handled in window.el.
8365 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8366 Window minimum sizes are handled in window.el.
8367 (shrink_windows, size_window, set_window_height)
8368 (set_window_width, change_window_heights, window_height)
8369 (window_width, CURBEG, CURSIZE, enlarge_window)
8370 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8371 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8372 handled in window.el.
8373 (make_dummy_parent): Rename to make_parent_window and give it a
8374 second argument horflag.
8375 (make_window): Don't set resize_proportionally any more.
8376 (Fsplit_window): Remove. Windows are split in window.el.
8377 (save_restore_action, save_restore_orig_size)
8378 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8379 Resize mini windows in window.el.
8380 (grow_mini_window, shrink_mini_window): Implement by calling
8381 Qresize_root_window_vertically, resize_window_check and
8382 resize_window_apply.
8383 (saved_window, Fset_window_configuration, save_window_save):
8384 Do not handle orig_top_line, orig_total_lines, and
8385 resize_proportionally.
8386 (window_min_height, window_min_width): Move to window.el.
8387 (keys_of_window): Move bindings for delete-other-windows,
8388 split-window, delete-window and enlarge-window to window.el.
8390 * buffer.c: Temporarily extern Qdelete_window.
8391 (Fbury_buffer): Temporarily call Qdelete_window instead of
8392 Fdelete_window (Fbury_buffer will move to window.el soon).
8394 * frame.c (set_menu_bar_lines_1): Remove code handling
8395 orig_top_line and orig_total_lines.
8397 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8398 set_window_height but set heights directly.
8399 (change_frame_size_1): Use resize_frame_windows.
8401 * xdisp.c (init_xdisp): Don't use set_window_height but set
8404 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8405 Use resize_frame_windows instead of change_window_heights and run
8406 run_window_configuration_change_hook.
8408 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8409 instead of change_window_heights and run
8410 run_window_configuration_change_hook.
8412 2011-06-09 Martin Rudalics <rudalics@gmx.at>
8414 * window.c (replace_window): Rename second argument REPLACEMENT to
8415 NEW. New third argument SETFLAG. Rewrite.
8416 (delete_window, make_dummy_parent): Call replace_window with
8418 (window_list_1): Move down in code.
8419 (run_window_configuration_change_hook): Move set_buffer part
8420 before select_frame_norecord part in order to unwind correctly.
8421 Rename count1 to count.
8422 (recombine_windows, delete_deletable_window, resize_root_window)
8423 (Fdelete_other_windows_internal)
8424 (Frun_window_configuration_change_hook, make_parent_window)
8425 (resize_window_check, resize_window_apply, Fresize_window_apply)
8426 (resize_frame_windows, Fsplit_window_internal)
8427 (Fdelete_window_internal, Fresize_mini_window_internal):
8429 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8431 2011-06-08 Martin Rudalics <rudalics@gmx.at>
8433 * window.h (window): Add some new members to window structure -
8434 normal_lines, normal_cols, new_total, new_normal, clone_number,
8435 splits, nest, prev_buffers, next_buffers.
8436 (WINDOW_TOTAL_SIZE): Move here from window.c.
8437 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
8439 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8441 (make_dummy_parent): Set new members of windows structure.
8442 (make_window): Move down in code. Handle new members of window
8444 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8445 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8446 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8447 (Fset_window_prev_buffers, Fwindow_next_buffers)
8448 (Fset_window_next_buffers, Fset_window_clone_number):
8450 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8451 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8453 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8454 Argument WINDOW can be now internal window too.
8455 (Fwindow_use_time): Move up in code.
8456 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8458 (Fset_window_configuration, saved_window)
8459 (Fcurrent_window_configuration, save_window_save): Handle new
8460 members of window structure.
8461 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8462 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8463 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8464 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8465 Qget_mru_window, Qresize_root_window,
8466 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8467 Qauto_buffer_name; staticpro them.
8469 2011-06-07 Martin Rudalics <rudalics@gmx.at>
8471 * window.c (Fwindow_total_size, Fwindow_left_column)
8472 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8473 (Fwindow_list_1): New functions.
8474 (window_box_text_cols): Replace with window_body_cols.
8475 (Fwindow_width, Fscroll_left, Fscroll_right):
8476 Use window_body_cols instead of window_box_text_cols.
8477 (delete_window, Fset_window_configuration):
8478 Call delete_all_subwindows with window as argument.
8479 (delete_all_subwindows): Take a window as argument and not a
8481 (window_loop): Remove handling of GET_LRU_WINDOW and
8483 (Fget_lru_window, Fget_largest_window): Move to window.el.
8485 * window.h: Extern window_body_cols instead of
8486 window_box_text_cols. delete_all_subwindows now takes a
8487 Lisp_Object as argument.
8489 * indent.c (compute_motion, Fcompute_motion):
8490 Use window_body_cols instead of window_box_text_cols.
8492 * frame.c (delete_frame): Call delete_all_subwindows with root
8495 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8497 * fns.c (Fputhash): Document return value.
8499 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
8501 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8503 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8505 Cons<->int and similar integer overflow fixes (Bug#8794).
8507 Check for overflow when converting integer to cons and back.
8508 * charset.c (Fdefine_charset_internal, Fdecode_char):
8509 Use cons_to_unsigned to catch overflow.
8510 (Fencode_char): Use INTEGER_TO_CONS.
8511 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8512 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8513 * data.c (long_to_cons, cons_to_long): Remove.
8514 (cons_to_unsigned, cons_to_signed): New functions.
8515 These signal an error for invalid or out-of-range values.
8516 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8517 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8518 * font.c (Ffont_variation_glyphs):
8519 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8520 * lisp.h: Include <intprops.h>.
8521 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8522 (cons_to_signed, cons_to_unsigned): New decls.
8523 (long_to_cons, cons_to_long): Remove decls.
8524 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8525 (Fprimitive_undo): Use CONS_TO_INTEGER.
8526 * xfns.c (Fx_window_property): Likewise.
8527 * xselect.c: Include <limits.h>.
8528 (x_own_selection, selection_data_to_lisp_data):
8529 Use INTEGER_TO_CONS.
8530 (x_handle_selection_request, x_handle_selection_clear)
8531 (x_get_foreign_selection, Fx_disown_selection_internal)
8532 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8533 (lisp_data_to_selection_data): Use cons_to_unsigned.
8534 (x_fill_property_data): Use cons_to_signed.
8535 Report values out of range.
8537 Check for buffer and string overflow more precisely.
8538 * buffer.h (BUF_BYTES_MAX): New macro.
8539 * lisp.h (STRING_BYTES_MAX): New macro.
8540 * alloc.c (Fmake_string):
8541 * character.c (string_escape_byte8):
8542 * coding.c (coding_alloc_by_realloc):
8543 * doprnt.c (doprnt):
8544 * editfns.c (Fformat):
8546 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8547 since they may not be the same number.
8548 * editfns.c (Finsert_char):
8549 * fileio.c (Finsert_file_contents):
8550 Likewise for BUF_BYTES_MAX.
8552 * image.c: Use ptrdiff_t, not int, for sizes.
8553 (slurp_file): Switch from int to ptrdiff_t.
8555 (slurp_file): Check that file size fits in both size_t (for
8556 malloc) and ptrdiff_t (for sanity and safety).
8558 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8559 if b->modtime has its maximal value.
8561 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8563 Don't assume time_t can fit into int.
8564 * buffer.h (struct buffer.modtime): Now time_t, not int.
8565 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8566 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8568 Minor fixes for signed vs unsigned integers.
8569 * character.h (MAYBE_UNIFY_CHAR):
8570 * charset.c (maybe_unify_char):
8571 * keyboard.c (read_char, reorder_modifiers):
8572 XINT -> XFASTINT, since the integer must be nonnegative.
8573 * ftfont.c (ftfont_spec_pattern):
8574 * keymap.c (access_keymap, silly_event_symbol_error):
8575 XUINT -> XFASTINT, since the integer must be nonnegative.
8576 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8577 since it makes no difference and we prefer signed.
8578 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8579 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8582 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8584 * window.h (Fwindow_frame): Declare.
8586 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8588 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8589 (SPARE_MEMORY): Always define.
8590 (LARGE_REQUEST): Remove.
8591 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8593 2011-06-06 Martin Rudalics <rudalics@gmx.at>
8595 * lisp.h: Move EXFUNS for Fframe_root_window,
8596 Fframe_first_window and Fset_frame_selected_window to window.h.
8598 * window.h: Move EXFUNS for Fframe_root_window,
8599 Fframe_first_window and Fset_frame_selected_window here from
8602 * frame.c (Fwindow_frame, Fframe_first_window)
8603 (Fframe_root_window, Fframe_selected_window)
8604 (Fset_frame_selected_window): Move to window.c.
8605 (Factive_minibuffer_window): Move to minibuf.c.
8606 (Fother_visible_frames_p): New function.
8608 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8610 * window.c (decode_window, decode_any_window): Move up in code.
8611 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8612 (inhibit_frame_unsplittable): Remove unused variable.
8613 (Fwindow_buffer): Move up and rewrite doc-string.
8614 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8615 (Fwindow_prev): New functions.
8616 (Fwindow_frame): Move here from frame.c. Accept any window as
8618 (Fframe_root_window, Fframe_first_window)
8619 (Fframe_selected_window): Move here from frame.c. Accept frame
8620 or arbitrary window as argument. Update doc-strings.
8621 (Fminibuffer_window): Move up in code.
8622 (Fwindow_minibuffer_p): Move up in code and simplify.
8623 (Fset_frame_selected_window): Move here from frame.c.
8625 (Fselected_window, select_window, Fselect_window): Move up in
8626 code. Minor doc-string fixes.
8628 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8630 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8631 Do not assume that spare memory exists; that assumption is valid
8632 only if SYSTEM_MALLOC.
8633 (LARGE_REQUEST): New macro, so that the issue of large requests
8634 is separated from the issue of spare memory.
8636 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8638 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8641 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8643 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8646 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8648 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8650 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8652 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8653 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8655 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
8657 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8659 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
8661 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8662 (x_clipboard_manager_save): Add return value.
8663 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8665 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8666 Obey Vx_select_enable_clipboard_manager. Catch errors in
8667 x_clipboard_manager_save (Bug#8779).
8668 (Vx_select_enable_clipboard_manager): New variable.
8669 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
8671 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8673 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8675 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8677 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8678 in the current matrix if keep_current_p is non-zero.
8680 2011-06-04 Eli Zaretskii <eliz@gnu.org>
8682 * bidi.c (bidi_level_of_next_char): Fix last change.
8684 2011-06-03 Eli Zaretskii <eliz@gnu.org>
8686 Support bidi reordering of text covered by display properties.
8688 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8689 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8690 (bidi_cache_search, bidi_cache_iterator_state)
8691 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
8692 (bidi_level_of_next_char, bidi_move_to_visually_next):
8693 Support character positions inside a run of characters covered by a
8695 (bidi_paragraph_init, bidi_resolve_explicit_1)
8696 (bidi_level_of_next_char): Call bidi_fetch_char and
8697 bidi_fetch_char_advance instead of FETCH_CHAR and
8699 (bidi_init_it): Initialize new members.
8700 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8702 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8703 instead of using explicit *_CHAR codes.
8704 (bidi_resolve_explicit, bidi_resolve_weak):
8705 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
8706 bidirectional text is supported only in multibyte buffers.
8707 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8708 it to initialize the frame_window_p member of struct bidi_it.
8709 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8710 (bidi_resolve_explicit, bidi_resolve_weak)
8711 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8712 bidi_it->nchars is non-positive.
8713 (bidi_level_of_next_char): Don't try to lookup the cache for the
8714 next/previous character if nothing is cached there yet, or if we
8715 were just reseat()'ed to a new position.
8717 * xdisp.c (set_cursor_from_row): Set start and stop points
8718 according to the row's direction when priming the loop that looks
8719 for the glyph on which to display cursor.
8720 (single_display_spec_intangible_p): Function deleted.
8721 (display_prop_intangible_p): Reimplement to call
8722 handle_display_spec instead of single_display_spec_intangible_p.
8723 Accept 3 additional arguments needed by handle_display_spec.
8724 This fixes incorrect cursor motion across display property with complex
8725 values: lists, `(when COND...)' forms, etc.
8726 (single_display_spec_string_p): Support property values that are
8727 lists with the argument STRING its top-level element.
8728 (display_prop_string_p): Fix the condition for processing a
8729 property that is a list to be consistent with handle_display_spec.
8730 (handle_display_spec): New function, refactored from the
8731 last portion of handle_display_prop.
8732 (compute_display_string_pos): Accept additional argument
8733 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8734 value of a `display' property is a "replacing spec".
8735 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8736 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8737 the display property, but just return a value indicating whether
8738 the display property will replace the characters it covers.
8739 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8740 frame_window_p members of struct bidi_it.
8741 (compute_display_string_pos, compute_display_string_end):
8743 (push_it): Accept second argument POSITION, where pop_it should
8744 jump to continue iteration.
8745 (reseat_1): Initialize bidi_it.disp_pos.
8747 * keyboard.c (adjust_point_for_property): Adjust the call to
8748 display_prop_intangible_p to its new signature.
8750 * dispextern.h (struct bidi_it): New member frame_window_p.
8751 (bidi_init_it): Update prototypes.
8752 (display_prop_intangible_p): Update prototype.
8753 (compute_display_string_pos, compute_display_string_end):
8755 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8758 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
8760 Malloc failure behavior now depends on size of allocation.
8761 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8762 * lisp.h: Change signatures accordingly.
8763 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8764 All callers changed. (Bug#8762)
8766 * gnutls.c: Use Emacs's memory allocators.
8767 Without this change, the gnutls library would invoke malloc etc.
8768 directly, which causes problems on non-SYNC_INPUT hosts, and which
8769 runs afoul of improving memory_full behavior. (Bug#8761)
8770 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8771 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8772 xfree instead of the default malloc, realloc, free.
8773 (Fgnutls_boot): No need to check for memory allocation failure,
8774 since xmalloc does that for us.
8776 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
8777 * category.c (hash_get_category_set):
8778 * ccl.c (ccl_driver):
8779 * charset.c (Fdefine_charset_internal):
8780 * charset.h (struct charset.hash_index):
8781 * composite.c (get_composition_id, gstring_lookup_cache)
8782 (composition_gstring_put_cache):
8783 * composite.h (struct composition.hash_index):
8784 * dispextern.h (struct image.hash):
8785 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8786 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8787 (hashfn_equal, hashfn_user_defined, make_hash_table)
8788 (maybe_resize_hash_table, hash_lookup, hash_put)
8789 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8790 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8791 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8792 * image.c (make_image, search_image_cache, lookup_image)
8793 (xpm_put_color_table_h):
8794 * lisp.h (struct Lisp_Hash_Table):
8795 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
8796 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
8797 for hashes and hash indexes, instead of 'unsigned' and 'int'.
8798 * alloc.c (allocate_vectorlike):
8799 Check for overflow in vector size calculations.
8800 * ccl.c (ccl_driver):
8801 Check for overflow when converting EMACS_INT to int.
8802 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8803 need to be updated by these changes.
8804 * fns.c (make_hash_table, maybe_resize_hash_table):
8805 Check for integer overflow with large hash tables.
8806 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8807 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8808 (SXHASH_REDUCE): New macro.
8809 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8810 Use it instead of discarding useful hash info with large hash values.
8811 (sxhash_float): New function.
8812 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8813 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
8814 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8815 Rewrite to use FIXNUM_BITS, as this simplifies things.
8816 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8817 Adjust signatures to match updated version of code.
8818 (consing_since_gc): Now EMACS_INT, since a single hash table can
8819 use more than INT_MAX bytes.
8821 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8823 Make it possible to build with GCC-4.6+ -O2 -flto.
8825 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8827 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8829 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8830 Call minibuffer-inactive-mode.
8832 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
8834 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8835 Update dependencies.
8837 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8839 * data.c (init_data): Remove code for UTS, this system is not
8842 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8844 Don't force ./temacs to start in terminal mode.
8846 * frame.c (make_initial_frame): Initialize faces in all cases, not
8847 only when CANNOT_DUMP is defined.
8848 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8850 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8852 * dispnew.c (add_window_display_history): Use const for the string
8853 pointer. Remove declaration, not needed.
8855 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8857 Use 'inline', not 'INLINE'.
8858 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
8859 * alloc.c, fontset.c (INLINE): Remove.
8860 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8861 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8862 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8863 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8864 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8866 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8868 Make it possible to run ./temacs.
8870 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8871 syms_of_callproc does the same thing. Remove test for
8872 "initialized", do it in the caller.
8873 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8875 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8877 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8878 (read_minibuf): Use get_minibuffer.
8879 (syms_of_minibuf): Use DEFSYM.
8880 (Qmetadata): New var.
8881 * data.c (Qbuffer): Don't make it static.
8882 (syms_of_data): Use DEFSYM.
8884 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8886 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8887 (CCL_CODE_MIN): New macro.
8889 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8891 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8893 * eval.c (Qdebug): Now static.
8894 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8895 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8896 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8898 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8900 * image.c: Various fixes to ImageMagick code comments.
8901 (Fimagemagick_types): Doc fix.
8903 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8905 Minor fixes prompted by GCC 4.6.0 warnings.
8907 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8909 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8910 (x_clipboard_manager_save_all): Move extern decl to ...
8911 * xterm.h: ... here, so that it can be checked for consistency.
8913 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8915 * xselect.c (x_clipboard_manager_save_frame)
8916 (x_clipboard_manager_save_all): New functions.
8917 (Fx_clipboard_manager_save): Lisp function deleted.
8919 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8920 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8922 * xterm.h: Update prototype.
8924 2011-05-28 William Xu <william.xwl@gmail.com>
8926 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8929 2011-05-28 Jim Meyering <meyering@redhat.com>
8931 Avoid a sign-extension bug in crypto_hash_function.
8932 * fns.c (to_uchar): Define.
8933 (crypto_hash_function): Use it to convert some newly-signed
8934 variables to unsigned, to avoid sign-extension bugs. For example,
8935 without this change, (md5 "truc") would evaluate to
8936 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8937 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
8938 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
8940 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8942 Integer overflow fixes.
8944 * dbusbind.c: Serial number integer overflow fixes.
8945 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
8946 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8947 to hold a serial number that is too large for a fixnum.
8948 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8949 Check for serial numbers out of range. Decode any serial number
8950 that was so large that it became a float. (Bug#8722)
8952 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8953 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8954 Use XFASTINT rather than XUINT when numbers are nonnegative.
8955 (xd_append_arg, Fdbus_method_return_internal):
8956 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8957 arguments, check that Lisp number is nonnegative, rather than
8958 silently wrapping negative numbers around. (Bug#8722)
8959 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
8962 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8964 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8966 ccl: Add integer overflow checks.
8967 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8968 (IN_INT_RANGE): New macros.
8969 (ccl_driver): Use them to check for integer overflow when
8970 decoding a CCL program. Many of the new checks are whether XINT (x)
8971 fits in int; it doesn't always, on 64-bit hosts. The new version
8972 doesn't catch all possible integer overflows, but it's an
8973 improvement. (Bug#8719)
8975 * alloc.c (make_event_array): Use XINT, not XUINT.
8976 There's no need for unsigned here.
8978 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8979 This follows up to the 2011-05-06 change that substituted uintptr_t
8980 for EMACS_INT. This case wasn't caught back then.
8982 Rework Fformat to avoid integer overflow issues.
8983 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8984 now (part of C89). Include <verify.h>.
8985 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8986 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8987 (Fformat): Avoid the prepass trying to compute sizes; it was only
8988 approximate and thus did not catch overflow reliably. Instead, walk
8989 through the format just once, formatting and computing sizes as we go,
8990 checking for integer overflow at every step, and allocating a larger
8991 buffer as needed. Keep track separately whether the format is
8992 multibyte. Keep only the most-recently calculated precision, rather
8993 than them all. Record whether each argument has been converted to
8994 string. Use EMACS_INT, not int, for byte and char and arg counts.
8995 Support field widths and precisions larger than INT_MAX. Avoid
8996 sprintf's undefined behavior with conversion specifications such as %#d
8997 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8998 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8999 formatting out-of-range floating point numbers with int
9002 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9004 * data.c: Avoid integer truncation in expressions involving floats.
9005 * data.c: Include <intprops.h>.
9006 (arith_driver): When there's an integer overflow in an expression
9007 involving floating point, convert the integers to floating point
9008 so that the resulting value does not suffer from catastrophic
9009 integer truncation. For example, on a 64-bit host (* 4
9010 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9011 Do not rely on undefined behavior after integer overflow.
9013 merge count_size_as_multibyte, parse_str_to_multibyte
9014 * character.c, character.h (count_size_as_multibyte):
9015 Rename from parse_str_to_multibyte; all uses changed.
9016 Check for integer overflow.
9017 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9018 since it's now a duplicate of the other. This is more of
9019 a character than a buffer op, so better that it's in character.c.
9020 * fns.c, print.c: Adjust to above changes.
9022 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9024 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9026 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9028 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9029 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9030 (x_clipboard_manager_save): Now static.
9031 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9033 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9034 (crypto_hash_function): Now static.
9035 Fix pointer signedness problems. Avoid unnecessary initializations.
9037 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
9039 * termhooks.h (Vselection_alist): Make it terminal-local.
9041 * terminal.c (create_terminal): Initialize it.
9043 * xselect.c: Support for clipboard managers.
9044 (Vselection_alist): Move to termhooks.h as terminal-local var.
9045 (LOCAL_SELECTION): New macro.
9046 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9047 (symbol_to_x_atom): Remove gratuitous arg.
9048 (x_handle_selection_request, lisp_data_to_selection_data)
9049 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
9050 (x_own_selection, x_get_local_selection, x_convert_selection):
9051 New arg, specifying work frame. Use terminal-local Vselection_alist.
9052 (some_frame_on_display): Delete unused function.
9053 (Fx_own_selection_internal, Fx_get_selection_internal)
9054 (Fx_disown_selection_internal, Fx_selection_owner_p)
9055 (Fx_selection_exists_p): New optional frame arg.
9056 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9057 (x_handle_selection_clear): Don't treat other terminals with the
9058 same keyboard specially. Use the terminal-local Vselection_alist.
9059 (x_clear_frame_selections): Use Frun_hook_with_args.
9061 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9063 * xterm.h: Add support for those atoms.
9065 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
9067 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9068 (converted_selections, conversion_fail_tag): New global variables.
9069 (x_selection_request_lisp_error): Free the above.
9070 (x_get_local_selection): Remove unnecessary code.
9071 (x_reply_selection_request): Args changed; handle arbitrary array
9072 of converted selections stored in converted_selections.
9073 Separate the XChangeProperty and SelectionNotify steps.
9074 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9075 (x_convert_selection): New function.
9076 (x_handle_selection_event): Simplify.
9077 (x_get_foreign_selection): Don't ignore incoming requests while
9078 waiting for an answer; this will fail when we implement
9079 SAVE_TARGETS, and seems unnecessary anyway.
9080 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9081 (Vx_sent_selection_functions): Doc fix.
9083 2011-05-26 Leo Liu <sdl.web@gmail.com>
9085 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9087 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9089 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9091 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9092 for fringe update if it has periodic bitmap.
9093 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
9094 and fringe_bitmap_periodic_p.
9096 * fringe.c (get_fringe_bitmap_data): New function.
9097 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9098 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9099 row. Mark glyph row for fringe update if periodicity changed.
9101 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9102 for fringe update unless it has periodic bitmap.
9104 2011-05-25 Kenichi Handa <handa@m17n.org>
9106 * xdisp.c (get_next_display_element): Set correct it->face_id for
9107 a static composition.
9109 2011-05-24 Leo Liu <sdl.web@gmail.com>
9112 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9114 * fns.c (crypto_hash_function, Fsha1): New function.
9115 (Fmd5): Use crypto_hash_function.
9116 (syms_of_fns): Add Ssha1.
9118 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9120 * gnutls.c: Remove unused macros.
9121 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9122 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9123 Remove macros that are defined and never used.
9124 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9126 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9128 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9129 (Fx_get_selection_internal): Minor cleanup.
9130 (Fx_own_selection_internal): Rename arguments for consistency with
9133 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9135 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9137 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9139 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9141 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9143 * dispnew.c (scrolling_window): Don't exclude the case that the
9144 last enabled row in the desired matrix touches the bottom boundary.
9146 2011-05-21 Glenn Morris <rgm@gnu.org>
9148 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
9149 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9150 and add some more files.
9152 2011-05-20 Eli Zaretskii <eliz@gnu.org>
9154 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9155 report_file_error introduced by the change from 2011-05-07.
9157 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9159 * systime.h (Time): Define only if emacs is defined.
9160 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9161 where the include path doesn't have X11/X.h by default. See
9162 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9164 2011-05-20 Kenichi Handa <handa@m17n.org>
9166 * composite.c (find_automatic_composition): Fix previous change.
9168 2011-05-20 Glenn Morris <rgm@gnu.org>
9170 * lisp.mk: New file, split from Makefile.in.
9171 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9172 (shortlisp): Remove.
9173 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9175 2011-05-19 Glenn Morris <rgm@gnu.org>
9177 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9178 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9179 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9180 (lisp): Set the order to that of loadup.el.
9181 (shortlisp): Make it a copy of $lisp.
9182 (SOME_MACHINE_LISP): Remove.
9183 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9184 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9186 2011-05-18 Kenichi Handa <handa@m17n.org>
9188 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9189 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9190 (find_automatic_composition): Mostly rewrite for efficiency.
9192 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
9194 * makefile.w32-in: Update dependencies.
9196 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9198 * menu.c: Include limits.h (fixes the MS-Windows build broken by
9199 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
9201 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
9203 Fix some integer overflow issues, such as string length overflow.
9205 * insdel.c (count_size_as_multibyte): Check for string overflow.
9207 * character.c (lisp_string_width): Check for string overflow.
9208 Use EMACS_INT, not int, for string indexes and lengths; in
9209 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9210 the resulting string length overflows an EMACS_INT; instead,
9211 report a string overflow if no precision given. When checking for
9212 precision exhaustion, use a check that cannot possibly have
9213 integer overflow. (Bug#8675)
9214 * character.h (lisp_string_width): Adjust to new signature.
9216 * alloc.c (string_overflow): New function.
9217 (Fmake_string): Use it. This doesn't change behavior, but saves
9218 a few bytes and will simplify future changes.
9219 * character.c (string_escape_byte8): Likewise.
9220 * lisp.h (string_overflow): New decl.
9222 Fixups, following up to the user-interface timestamp change.
9223 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9224 for UI timestamps, instead of unsigned long.
9225 * msdos.c (mouse_get_pos): Likewise.
9226 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
9227 * w32gui.h (Time): Define by including "systime.h" rather than by
9228 declaring it ourselves. (Bug#8664)
9230 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9231 * image.c (clear_image_cache): Likewise.
9233 * term.c (term_mouse_position): Don't assume time_t wraparound.
9235 Be more systematic about user-interface timestamps.
9236 Before, the code sometimes used 'Time', sometimes 'unsigned long',
9237 and sometimes 'EMACS_UINT', to represent these timestamps.
9238 This change causes it to use 'Time' uniformly, as that's what X uses.
9239 This makes the code easier to follow, and makes it easier to catch
9240 integer overflow bugs such as Bug#8664.
9241 * frame.c (Fmouse_position, Fmouse_pixel_position):
9242 Use Time, not unsigned long, for user-interface timestamps.
9243 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9244 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9245 * keyboard.h (last_event_timestamp): Likewise.
9246 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9247 * menu.h (xmenu_show): Likewise.
9248 * term.c (term_mouse_position): Likewise.
9249 * termhooks.h (struct input_event.timestamp): Likewise.
9250 (struct terminal.mouse_position_hook): Likewise.
9251 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9252 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9253 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9254 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9256 * menu.h, termhooks.h: Include "systime.h", for Time.
9258 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9259 Don't assume that the difference between two unsigned long values
9260 can fit into an integer. At this point, we know button_down_time
9261 <= event->timestamp, so the difference must be nonnegative, so
9262 there's no need to cast the result if double-click-time is
9263 nonnegative, as it should be; check that it's nonnegative, just in
9264 case. This bug is triggered when events are more than 2**31 ms
9265 apart (about 25 days). (Bug#8664)
9267 * xselect.c (last_event_timestamp): Remove duplicate decl.
9268 (x_own_selection): Remove needless cast to unsigned long.
9270 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9271 that always fit in int. Use a sentinel instead of a counter, to
9272 avoid a temp and to allay GCC's concerns about possible int overflow.
9273 * frame.h (struct frame): Use int for menu_bar_items_used
9274 instead of EMACS_INT, since it always fits in int.
9276 * menu.c (grow_menu_items): Check for int overflow.
9278 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9280 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9281 Before, the code was not consistent. These values cannot exceed
9282 2**31 - 1 so there's no need to make them unsigned.
9283 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9284 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9285 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9287 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9289 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9290 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9291 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9292 presumably because the widths might not match.
9294 * window.c (size_window): Avoid needless test at loop start.
9296 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9298 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9300 2011-05-12 Drew Adams <drew.adams@oracle.com>
9302 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9304 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9306 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9307 `width' to `bar_area_x' and `bar_area_width', respectively.
9308 (x_scroll_run): Take account of fringe background extension.
9310 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9311 Rename local vars `left' and `width' to `bar_area_x' and
9312 `bar_area_width', respectively.
9313 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9314 background extension.
9316 2011-05-10 Jim Meyering <meyering@redhat.com>
9318 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9320 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
9322 * image.c (Finit_image_library): Return t for built-in image types,
9323 like pbm and xbm. (Bug#8640)
9325 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9327 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9329 2011-05-07 Eli Zaretskii <eliz@gnu.org>
9331 * w32console.c (Fset_screen_color): Doc fix.
9332 (Fget_screen_color): New function.
9333 (syms_of_ntterm): Defsubr it.
9335 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9336 unlink the temporary file if Fcall_process didn't create it in the
9338 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9339 child process will be redirected to a file specified with `:file'.
9340 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9341 cue to call_process_cleanup not to close that handle.
9343 2011-05-07 Ben Key <bkey76@gmail.com>
9345 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9346 one of two shell specific rules, either bootstrap-temacs-CMD or
9347 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9348 to the previous implementation of the bootstrap-temacs rule.
9349 The bootstrap-temacs-CMD rule is similar to the previous
9350 implementation of the bootstrap-temacs rule except that it
9351 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9354 These changes, along with some changes to nt/configure.bat,
9355 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9356 earlier fix to add support for --cflags and --ldflags options
9357 that include quotes so that it works whether make uses cmd or
9360 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
9362 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9363 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9365 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9366 a string. Handle both cases.
9367 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9368 (Fdbus_register_method): Use Qinvalid_function.
9370 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
9372 * makefile.w32-in: Update dependencies.
9373 (LISP_H): Add inttypes.h and stdin.h.
9374 (PROCESS_H): Add unistd.h.
9376 2011-05-06 Eli Zaretskii <eliz@gnu.org>
9378 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9379 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9381 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
9383 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9385 * term.c (vfatal): Remove stray call to va_end.
9386 It's not needed and the C Standard doesn't allow it here anyway.
9388 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9389 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9391 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9394 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9396 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9398 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9400 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9402 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9404 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9405 * charset.c (Fdefine_charset_internal): Don't initialize
9406 charset.code_space[15]. The value was garbage, on hosts with
9407 32-bit int (Bug#8600).
9409 * lread.c (read_integer): Be more consistent with string-to-number.
9410 Use string_to_number to do the actual conversion; this avoids
9411 rounding errors and fixes some other screwups. Without this fix,
9412 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9413 (digit_to_number): Move earlier, for benefit of read_integer.
9414 Return -1 if the digit is out of range for the base, -2 if it is
9415 not a digit in any supported base. (Bug#8602)
9417 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9419 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9420 to match comment at start of function. This also removes a
9421 GCC warning about overflow in a 32+64-bit port.
9423 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9425 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9426 Reported by Stefan Monnier in
9427 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
9428 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9429 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
9431 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9432 (EMACS_UINTPTR): Likewise, with uintptr_t.
9434 * lisp.h: Prefer 64-bit EMACS_INT if available.
9435 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9436 on 32-bit hosts that have 64-bit int, so that they can access
9438 However, temporarily disable this change unless the temporary
9439 symbol WIDE_EMACS_INT is defined.
9441 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9443 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9444 This removes an assumption that EMACS_INT and long are the same
9445 width as pointers. The assumption is true for Emacs porting targets
9446 now, but we want to make other targets possible.
9447 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9448 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9449 In the rest of the code, change types of integers that hold casted
9450 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9451 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9452 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9453 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9454 No need to cast type when ORing.
9455 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9456 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9457 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9458 assume EMACS_INT is the same width as char *.
9459 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9460 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9461 Remove no-longer-needed casts.
9462 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9463 (xg_tool_bar_help_callback, xg_make_tool_item):
9464 Use EMACS_INTPTR to hold an integer
9465 that will be cast to void *; this can avoid a GCC warning
9466 if EMACS_INT is not the same width as void *.
9467 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9468 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9469 (current_message_1, set_message_1):
9470 Use a local to convert to proper width without a cast.
9471 * xmenu.c (dialog_selection_callback): Likewise.
9473 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9474 Also, don't assume VALBITS / RAND_BITS is less than 5,
9475 and don't rely on undefined behavior when shifting a 1 left into
9477 * lisp.h (get_random): Change signature to match.
9479 * lread.c (hash_string): Use size_t, not int, for hash computation.
9480 Normally we prefer signed values; but hashing is special, because
9481 it's better to use unsigned division on hash table sizes so that
9482 the remainder is nonnegative. Also, size_t is the natural width
9483 for hashing into memory. The previous code used 'int', which doesn't
9484 retain enough info to hash well into very large tables.
9485 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9487 * dbusbind.c: Don't possibly lose pointer info when converting.
9488 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9489 Use XPNTR rather than XHASH, so that the high-order bits of
9490 the pointer aren't lost when converting through void *.
9492 * eval.c (Fautoload): Don't double-shift a pointer.
9494 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9496 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
9498 * gnutls.c (DEF_GNUTLS_FN):
9499 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9501 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9503 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9506 2011-05-05 Eli Zaretskii <eliz@gnu.org>
9508 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9509 New version that can reserve upto 2GB of heap space.
9511 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
9513 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9515 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9517 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9518 `gnutls_certificate_set_x509_key_file'.
9520 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
9522 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9523 Update dependencies.
9525 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9527 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9528 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9529 Remove unused parameter `fildes'.
9530 * process.c (read_process_output, send_process): Don't pass it.
9532 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9534 Fix previous change: the library cache is defined in w32.c.
9535 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9536 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9538 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9540 Implement dynamic loading of GnuTLS on Windows.
9542 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9543 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9544 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9547 * gnutls.c (Qgnutls_dll): Define.
9548 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9549 (gnutls_*): Declare function pointers.
9550 (init_gnutls_functions): New function to initialize function pointers.
9551 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9552 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9553 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9554 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9555 (emacs_gnutls_write, emacs_gnutls_read)
9556 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9557 (Fgnutls_available_p): New function.
9558 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9559 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9560 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9562 * image.c: Include w32.h.
9563 (Vimage_type_cache): Delete.
9564 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9565 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9566 (w32_delayed_load): Move to w32.c.
9568 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9570 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9571 (w32_delayed_load): Move from image.c. When loading a library, record
9572 its filename in the :loaded-from property of the library id.
9573 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9574 Initialize and staticpro them.
9575 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9577 * process.c: Include lisp.h before w32.h, not after.
9578 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9579 instead of gnutls_record_check_pending.
9581 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9583 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9585 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9586 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9589 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9591 * xterm.c (x_set_frame_alpha): Do not set property on anything
9592 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9594 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
9596 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9598 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
9600 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9601 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9602 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9603 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9604 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9605 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9606 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9607 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9608 (Qgnutls_bootprop_callbacks_verify): Make static.
9610 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9612 * callproc.c: Indentation fixup.
9614 * sysdep.c (wait_for_termination_1): Make static.
9615 (wait_for_termination, interruptible_wait_for_termination):
9616 Move after wait_for_termination_1.
9618 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9620 * sysdep.c (interruptible_wait_for_termination): New function
9621 which is like wait_for_termination, but allows keyboard
9624 * callproc.c (Fcall_process): Add (:file "file") as an option for
9626 (Fcall_process_region): Ditto.
9628 2011-04-30 Eli Zaretskii <eliz@gnu.org>
9630 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9631 rather than `XVECTOR (FOO)->size'.
9633 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9634 inttypes.h, as a gnulib replacement is used if it not available in
9637 2011-04-21 Eli Zaretskii <eliz@gnu.org>
9639 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9640 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9641 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9643 * coding.c (coding_alloc_by_realloc): Error out if destination
9644 will grow beyond MOST_POSITIVE_FIXNUM.
9645 (decode_coding_emacs_mule): Abort if there isn't enough place in
9646 charbuf for the composition carryover bytes. Reserve an extra
9647 space for up to 2 characters produced in a loop.
9648 (decode_coding_iso_2022): Abort if there isn't enough place in
9649 charbuf for the composition carryover bytes.
9651 2011-04-21 Eli Zaretskii <eliz@gnu.org>
9653 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9654 aborting when %lld or %lll format is passed.
9655 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9656 %llo or %llx format is passed. (Bug#8545)
9658 * window.c (window_scroll_line_based): Use a marker instead of
9659 simple variables to record original value of point. (Bug#7952)
9661 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9662 produced by %s or %c overflows available buffer space. (Bug#8545)
9664 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9666 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
9667 (SIZE_MAX): Move defn after all includes, as they might #define it.
9669 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9671 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9673 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9675 * keyboard.c (Qdelayed_warnings_hook): Define.
9676 (command_loop_1): Run `delayed-warnings-hook'
9677 if Vdelayed_warnings_list is non-nil.
9678 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9679 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9681 2011-04-28 Eli Zaretskii <eliz@gnu.org>
9683 * doprnt.c (doprnt): Don't return value smaller than the buffer
9684 size if the message was truncated. (Bug#8545).
9686 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9688 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9689 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9691 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9693 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9695 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
9697 * makefile.w32-in: Update dependencies.
9699 2011-04-27 Eli Zaretskii <eliz@gnu.org>
9701 Improve `doprnt' and its usage. (Bug#8545)
9702 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9703 `format_end'. Remove support for %l as a conversion specifier.
9704 Don't use xrealloc. Improve diagnostics when the %l size modifier
9705 is used. Update the commentary.
9707 * eval.c (verror): Simplify calculation of size_t.
9709 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9712 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9714 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9717 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9719 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9720 This makes this file independent of the recent pseudovector change.
9722 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
9724 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9726 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
9727 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
9728 Remove unused local.
9729 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
9731 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
9732 GCC 4.6.0 optimizes based on type-based alias analysis.
9733 For example, if b is of type struct buffer * and v of type struct
9734 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9735 != &v->size, and therefore "v->size = 1; b->size = 2; return
9736 v->size;" must therefore return 1. This assumption is incorrect
9737 for Emacs, since it type-puns struct Lisp_Vector * with many other
9738 types. To fix this problem, this patch adds a new type struct
9739 vectorlike_header that documents the constraints on layout of vectors
9740 and pseudovectors, and helps optimizing compilers not get fooled
9741 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9742 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
9743 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9745 (XSETPVECTYPE): Rewrite in terms of new macro.
9746 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9747 This is a bit clearer, and further avoids the possibility of
9748 undesirable aliasing.
9749 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
9750 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
9751 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9752 since Lisp_Subr is a special case (no "next" field).
9753 (ASIZE): Now uses header.size rather than size.
9754 All previous uses of XVECTOR (foo)->size replaced to use this macro,
9755 to avoid the hassle of writing XVECTOR (foo)->header.size.
9756 (struct vectorlike_header): New type.
9757 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9758 object, to help avoid aliasing.
9759 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9760 (SUBRP): Likewise, since Lisp_Subr is a special case.
9761 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9762 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9763 (struct Lisp_Hash_Table): Combine first two members into a single
9764 struct vectorlike_header member. All uses of "size" and "next" members
9765 changed to be "header.size" and "header.next".
9766 * buffer.h (struct buffer): Likewise.
9767 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9768 * frame.h (struct frame): Likewise.
9769 * process.h (struct Lisp_Process): Likewise.
9770 * termhooks.h (struct terminal): Likewise.
9771 * window.c (struct save_window_data, struct saved_window): Likewise.
9772 * window.h (struct window): Likewise.
9773 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9774 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9775 * buffer.c (init_buffer_once): Likewise.
9776 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9778 * process.c (Fformat_network_address): Use local var for size,
9781 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9783 Make the Lisp reader and string-to-float more consistent (Bug#8525)
9784 * data.c (atof): Remove decl; no longer used or needed.
9785 (digit_to_number): Move to lread.c.
9786 (Fstring_to_number): Use new string_to_number function, to be
9787 consistent with how the Lisp reader treats infinities and NaNs.
9788 Do not assume that floating-point numbers represent EMACS_INT
9789 without losing information; this is not true on most 64-bit hosts.
9790 Avoid double-rounding errors, by insisting on integers when
9791 parsing non-base-10 numbers, as the documentation specifies.
9792 * lisp.h (string_to_number): New decl, replacing ...
9793 (isfloat_string): Remove.
9794 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
9795 (read1): Do not accept +. and -. as integers; this
9796 appears to have been a coding error. Similarly, do not accept
9797 strings like +-1e0 as floating point numbers. Do not report
9798 overflow for integer overflows unless the base is not 10 which
9799 means we have no simple and reliable way to continue.
9800 Break out the floating-point parsing into a new
9801 function string_to_number, so that Fstring_to_number parses
9802 floating point numbers consistently with the Lisp reader.
9803 (digit_to_number): Move here from data.c. Make it static inline.
9804 (E_CHAR, EXP_INT): Remove, replacing with ...
9805 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9806 (string_to_number): New function, replacing isfloat_string.
9807 This function checks for valid syntax and produces the resulting
9808 Lisp float number too. Rework it so that string-to-number
9809 no longer mishandles examples like "1.0e+". Use strtoumax,
9810 so that overflow for non-base-10 numbers is reported only when
9811 there's no portable and simple way to convert to floating point.
9813 * textprop.c (set_text_properties_1): Rewrite for clarity,
9814 and to avoid GCC warning about integer overflow.
9816 * intervals.h (struct interval): Use EMACS_INT for members
9817 where EMACS_UINT might cause problems. See
9818 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9819 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9820 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9822 (offset_intervals): Tell GCC not to worry about length overflow
9823 when negating a negative length.
9825 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9826 (overrun_check_free): Likewise.
9828 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9829 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9832 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9833 (gnutls_make_error): Rename local to avoid shadowing.
9834 (gnutls_emacs_global_deinit): ifdef out; not used.
9835 (Fgnutls_boot): Use const for pointer to readonly storage.
9836 Comment out unused local. Fix pointer signedness problems.
9838 * lread.c (openp): Don't stuff size_t into an 'int'.
9839 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9840 about possible signed overflow.
9842 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9843 (GDK_KEY_g): Don't define if already defined.
9844 (xg_prepare_tooltip): Avoid pointer signedness problem.
9845 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9847 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9848 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9850 * xfns.c (Fx_window_property): Simplify a bit,
9851 to make a bit faster and to avoid GCC 4.6.0 warning.
9852 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9854 * fns.c (internal_equal): Don't assume size_t fits in int.
9856 * alloc.c (compact_small_strings): Tighten assertion a little.
9858 Replace pEd with more-general pI, and fix some printf arg casts.
9859 * lisp.h (pI): New macro, generalizing old pEd macro to other
9860 conversion specifiers. For example, use "...%"pI"d..." rather
9861 than "...%"pEd"...".
9862 (pEd): Remove. All uses replaced with similar uses of pI.
9863 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
9864 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9865 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9866 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9867 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9868 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9869 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9871 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9872 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9873 * print.c (safe_debug_print, print_object): Likewise.
9874 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9876 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9877 avoiding the 0 flag, which is not portable.
9878 * process.c (Fmake_network_process): Use pI to avoid cast.
9879 * region-cache.c (pp_cache): Likewise.
9880 * xdisp.c (decode_mode_spec): Likewise.
9881 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9882 behavior on 64-bit hosts with printf arg.
9883 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
9884 (x_stop_queuing_selection_requests): Likewise.
9885 (x_get_window_property): Don't truncate byte count to an 'int'
9888 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9889 here, since it parses constructs like leading '-' and spaces,
9890 which are not wanted; and it overflows with large numbers.
9891 Instead, simply match F[0-9]+, which is what is wanted anyway.
9893 * alloc.c: Remove unportable assumptions about struct layout.
9894 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9895 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9896 (allocate_vectorlike, make_pure_vector): Use the new macros,
9897 plus offsetof, to remove unportable assumptions about struct layout.
9898 These assumptions hold on all porting targets that I know of, but
9899 they are not guaranteed, they're easy to remove, and removing them
9900 makes further changes easier.
9902 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9903 This doesn't fix a bug but makes the code clearer.
9904 (string_overrun_cookie): Now const. Use initializers that
9905 don't formally overflow signed char, to avoid warnings.
9906 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9907 can cause Emacs to crash when string overrun checking is enabled.
9908 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9909 multiple of sizeof (EMACS_INT); it need not be, if
9910 alignof(EMACS_INT) < sizeof (EMACS_INT).
9911 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
9913 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
9915 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9917 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9919 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
9920 supposed to be handshaking. (Bug#8556)
9921 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9923 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
9925 * lisp.h (Qdebug): List symbol.
9926 * eval.c (Qdebug): Restore global linkage.
9927 * keyboard.c (debug-on-event): New variable.
9928 (handle_user_signal): Break into debugger when debug-on-event
9929 matches the current signal symbol.
9931 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9933 * alloc.c (check_sblock, check_string_bytes)
9934 (check_string_free_list): Convert to standard C.
9936 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9938 * w32.c (emacs_gnutls_push): Fix typo.
9940 2011-04-25 Eli Zaretskii <eliz@gnu.org>
9942 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9943 "cast to pointer from integer of different size".
9945 Improve doprnt and its use in verror. (Bug#8545)
9946 * doprnt.c (doprnt): Document the set of format control sequences
9947 supported by the function. Use SAFE_ALLOCA instead of always
9950 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9951 is one byte too soon. Don't use xrealloc; instead xfree and
9954 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9956 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9959 * gnutls.c: Renamed global_initialized to
9960 gnutls_global_initialized. Added internals for the
9961 :verify-hostname-error, :verify-error, and :verify-flags
9962 parameters of `gnutls-boot' and documented those parameters in the
9963 docstring. Start callback support.
9964 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9965 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9966 on error. Return error code.
9967 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9968 (emacs_gnutls_read): Likewise.
9969 (Fgnutls_boot): Return handshake error code.
9970 (emacs_gnutls_handle_error): New function.
9971 (wsaerror_to_errno): Likewise.
9973 * w32.h (emacs_gnutls_pull): Add prototype.
9974 (emacs_gnutls_push): Likewise.
9976 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9977 (emacs_gnutls_push): Likewise.
9979 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9981 * process.c (wait_reading_process_output): Check if GnuTLS
9982 buffered some data internally if no FDs are set for TLS
9985 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9986 (LIBS): Link to USER_LIBS.
9987 ($(BLD)/gnutls.$(0)): New target.
9989 2011-04-24 Eli Zaretskii <eliz@gnu.org>
9991 * xdisp.c (handle_single_display_spec): Rename the
9992 display_replaced_before_p argument into display_replaced_p, to
9993 make it consistent with the commentary. Fix typos in the
9996 * textprop.c (syms_of_textprop): Remove dead code.
9997 (copy_text_properties): Delete obsolete commentary about an
9998 interface that was deleted long ago. Fix typos in the description
10001 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10002 to changes in oldXMenu/XMenu.h from 2011-04-16.
10003 <menu_help_message, prev_menu_help_message>: Constify.
10004 (IT_menu_make_room): menu->help_text is now `const char **';
10007 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10008 to changes in oldXMenu/XMenu.h from 2011-04-16.
10009 (struct XMenu): Declare `help_text' `const char **'.
10011 * xfaces.c <Qunspecified>: Make extern again.
10013 * syntax.c: Include sys/types.h before including regex.h, as
10016 * doc.c (get_doc_string): Improve the format passed to `error'.
10018 * doprnt.c (doprnt): Improve commentary.
10020 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10022 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10025 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10026 changes in globals.h immediately force recompilation.
10027 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10028 $(CURDIR)/s/ms-w32.h.
10029 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
10031 * character.c (Fchar_direction): Function deleted.
10032 (syms_of_character): Don't defsubr it.
10033 <char-direction-table>: Deleted.
10035 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10037 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10038 * doprnt.c: Include limits.h.
10039 (SIZE_MAX): New macro.
10040 (doprnt): Return a size_t value. 2nd arg is now size_t.
10041 Many local variables are now size_t instead of int or unsigned.
10042 Improve overflow protection. Support `l' modifier for integer
10043 conversions. Support %l conversion. Don't assume an EMACS_INT
10044 argument for integer conversions and for %c.
10046 * lisp.h (doprnt): Restore prototype.
10048 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10049 $(SRC)/character.h.
10051 * Makefile.in (base_obj): Add back doprnt.o.
10053 * deps.mk (doprnt.o): Add back prerequisites.
10054 (callint.o): Depend on character.h.
10056 * eval.c (internal_lisp_condition_case): Include the handler
10057 representation in the error message.
10058 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10059 when breaking from the loop.
10061 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10063 * callint.c (Fcall_interactively): When displaying error message
10064 about invalid control letter, pass the character's codepoint, not
10065 a pointer to its multibyte form. Improve display of the character
10066 in octal and display also its hex code.
10068 * character.c (char_string): Use %x to display the (unsigned)
10069 codepoint of an invalid character, to avoid displaying a bogus
10072 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10073 `error', not SYMBOL_NAME itself.
10075 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10076 character arguments to `error'.
10078 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10079 to `error' in error message about FINAL_CHAR argument. Make sure
10080 FINAL_CHAR is a character, and use %c when it is passed as
10081 argument to `error'.
10083 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10085 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10087 * w32.c: Include <time.h>.
10088 (sys_localtime): New function.
10090 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
10092 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10094 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
10096 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
10098 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10099 zombies (Bug#8467).
10101 2011-04-19 Eli Zaretskii <eliz@gnu.org>
10103 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10104 gl_state.e_property when gl_state.object is Qt.
10106 * insdel.c (make_gap_larger): Remove limitation of buffer size
10109 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
10111 * xdisp.c (lookup_glyphless_char_display)
10112 (produce_glyphless_glyph): Handle cons cell entry in
10113 glyphless-char-display.
10114 (Vglyphless_char_display): Document it.
10116 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10117 glyphless-char-display.
10119 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
10121 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10123 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10125 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10126 definition for no-X builds.
10128 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
10130 Static checks with GCC 4.6.0 and non-default toolkits.
10132 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10134 * process.c (keyboard_bit_set): Define only if SIGIO.
10135 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10136 (send_process): Repair possible setjmp clobbering.
10138 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10140 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10142 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10144 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10145 Define only if needed.
10147 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10148 by pacifying GCC about it. Maybe it's time to retire it?
10149 * xfaces.c (USG, __TIMEVAL__): Likewise.
10151 * dispextern.h (struct redisplay_interface): Rename param
10152 to avoid shadowing.
10153 * termhooks.h (struct terminal): Likewise.
10154 * xterm.c (xembed_send_message): Likewise.
10156 * insdel.c (make_gap_smaller): Define only if
10157 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10159 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10162 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10163 so that we aren't warned about unused symbols.
10165 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10167 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
10169 * xfns.c (x_real_positions): Mark locals as initialized.
10171 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10173 * xterm.c: Fix problems found by static analysis with other toolkits.
10174 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
10175 (x_dispatch_event): Declare static if USE_GTK, and
10176 define if USE_GTK || USE_X_TOOLKIT.
10177 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
10178 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
10179 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10180 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
10182 * xmenu.c (menu_help_callback): Pointer type fixes.
10183 Use const pointers when pointing at readonly data. Avoid pointer
10184 signedness clashes.
10185 (FALSE): Remove unused macro.
10186 (update_frame_menubar): Remove unused decl.
10188 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10190 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10191 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10192 (single_menu_item): Rename local to avoid shadowing.
10194 * keyboard.c (make_lispy_event): Remove unused local var.
10196 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10197 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10199 * bitmaps: Change bitmaps from unsigned char back to the X11
10200 compatible char. Avoid the old compiler warnings about
10201 out-of-range initializers by using, for example, '\xab' rather
10204 * xgselect.c (xgselect_initialize): Check vs interface
10205 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10207 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10209 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10210 to read-only memory.
10212 * fns.c (vector): Remove; this old hack is no longer needed.
10214 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
10216 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
10218 * xrdb.c (x_load_resources): Omit unused local.
10220 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
10221 (x_window): Rename locals to avoid shadowing.
10222 (USG): Use the kludged USG macro, to pacify gcc.
10224 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
10225 (x_term_init): Remove local to avoid shadowing.
10227 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
10229 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10230 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10232 2011-04-16 Eli Zaretskii <eliz@gnu.org>
10234 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10236 Fix regex.c, syntax.c and friends for buffers > 2GB.
10237 * syntax.h (struct gl_state_s): Declare character position members
10240 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10242 * textprop.c (verify_interval_modification, interval_of):
10243 Declare arguments EMACS_INT.
10245 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10248 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10250 * indent.c (Fvertical_motion): Local variable it_start is now
10253 * regex.c (re_match, re_match_2, re_match_2_internal)
10254 (bcmp_translate, regcomp, regexec, print_double_string)
10255 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10256 (re_compile_pattern, re_exec): Declare arguments and local
10257 variables `size_t' and `ssize_t' and return values `regoff_t', as
10259 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10260 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10261 <compile_stack_type>: `size' and `avail' are now `size_t'.
10263 * regex.h <regoff_t>: Use ssize_t, not int.
10264 (re_search, re_search_2, re_match, re_match_2): Arguments that
10265 specify buffer/string position and length are now ssize_t and
10266 size_t. Return type is regoff_t.
10268 2011-04-16 Ben Key <bkey76@gmail.com>
10270 * nsfont.m: Fixed bugs in ns_get_family and
10271 ns_descriptor_to_entity that were caused by using free to
10272 deallocate memory blocks that were allocated by xmalloc (via
10273 xstrdup). This caused Emacs to crash when compiled with
10274 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10275 --enable-checking=xmallocoverrun). xfree is now used to
10276 deallocate these memory blocks.
10278 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
10280 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10282 emacs_write: Accept and return EMACS_INT for sizes.
10283 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10285 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10286 Accept and return EMACS_INT.
10287 (emacs_gnutls_write): Return the number of bytes written on
10289 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
10290 (emacs_read, emacs_write): Remove check for negative size, as the
10291 Emacs source code has been audited now.
10292 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10293 (emacs_read, emacs_write): Use it.
10294 * process.c (send_process): Adjust to the new signatures of
10295 emacs_write and emacs_gnutls_write. Do not attempt to store
10296 a byte offset into an 'int'; it might overflow.
10297 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
10299 * sound.c: Don't assume sizes fit in 'int'.
10300 (struct sound_device.period_size, alsa_period_size):
10301 Return EMACS_INT, not int.
10302 (struct sound_device.write, vox_write, alsa_write):
10303 Accept EMACS_INT, not int.
10304 (wav_play, au_play): Use EMACS_INT to store sizes and to
10305 record read return values.
10307 2011-04-15 Ben Key <bkey76@gmail.com>
10309 * keyboard.c (Qundefined): Don't declare static since it is used
10311 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10312 static since they are used in nsfont.m.
10314 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10316 * process.c (Qprocessp): Don't declare static.
10317 * lisp.h (Qprocessp): Declare again.
10319 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
10321 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10323 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10325 Improve C-level modularity by making more things 'static'.
10327 Don't publish debugger-only interfaces to other modules.
10328 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10329 (verify_bytepos, count_markers): Move decls to the only modules
10331 * region-cache.h (pp_cache): Likewise.
10332 * window.h (check_all_windows): Likewise.
10333 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10335 * sysdep.c (croak): Now static, if
10336 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10337 * syssignal.h (croak): Declare only if not static.
10339 * alloc.c (refill_memory_reserve): Now static if
10340 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10341 * lisp.h (refill_memory_reserve): Declare only if not static.
10343 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10344 Define only if USE_LUCID.
10346 * xrdb.c (x_customization_string, x_rm_string): Now static.
10348 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10349 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10351 * xdisp.c (draw_row_with_mouse_face): Now static.
10352 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10354 * window.h (check_all_windows): Mark externally visible.
10356 * window.c (window_deletion_count): Now static.
10358 * undo.c: Make symbols static if they're not exported.
10359 (last_undo_buffer, last_boundary_position, pending_boundary):
10362 * textprop.c (interval_insert_behind_hooks): Now static.
10363 (interval_insert_in_front_hooks): Likewise.
10365 * term.c: Make symbols static if they're not exported.
10366 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10367 (max_frame_lines, tty_set_terminal_modes):
10368 (tty_reset_terminal_modes, tty_turn_off_highlight):
10369 (get_tty_terminal): Now static.
10370 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10371 * termhooks.h (term_mouse_moveto): Do not declare if
10372 HAVE_WINDOW_SYSTEM.
10373 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10374 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10376 * sysdep.c: Make symbols static if they're not exported.
10377 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10379 (sigprocmask_set, full_mask): Remove; unused.
10380 (wait_debugging): Mark as visible.
10381 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10382 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10384 * syntax.c (syntax_temp): Define only if !__GNUC__.
10386 * sound.c (current_sound_device, current_sound): Now static.
10388 * search.c (searchbufs, searchbuf_head): Now static.
10390 * scroll.c (scroll_cost): Remove; unused.
10391 * dispextern.h (scroll_cost): Remove decl.
10393 * region-cache.h (pp_cache): Mark as externally visible.
10395 * process.c: Make symbols static if they're not exported.
10396 (process_tick, update_tick, create_process, chan_process):
10397 (Vprocess_alist, proc_buffered_char, datagram_access):
10398 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10399 (deactivate_process): Mark defn as static, as well as decl.
10400 * lisp.h (create_process): Remove decl.
10401 * process.h (chan_process, Vprocess_alist): Remove decls.
10403 * print.c: Make symbols static if they're not exported.
10404 (print_depth, new_backquote_output, being_printed, print_buffer):
10405 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10406 (print_interval, print_number_index, initial_stderr_stream):
10408 * lisp.h (Fprinc): Remove decl.
10409 (debug_output_compilation_hack): Mark as externally visible.
10411 * sysdep.c (croak): Move decl from here to syssignal.h.
10412 * syssignal.h (croak): Put it here, so the API can be checked when
10413 'croak' is called from dissociate_if_controlling_tty.
10415 * minibuf.c: Make symbols static if they're not exported.
10416 (minibuf_save_list, choose_minibuf_frame): Now static.
10417 * lisp.h (choose_minibuf_frame): Remove decl.
10419 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10421 * lread.c: Make symbols static if they're not exported.
10422 (read_objects, initial_obarray, oblookup_last_bucket_number):
10424 (make_symbol): Remove; unused.
10425 * lisp.h (initial_obarray, make_symbol): Remove decls.
10427 * keyboard.c: Make symbols static if they're not exported.
10428 (single_kboard, recent_keys_index, total_keys, recent_keys):
10429 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10430 (this_single_command_key_start, echoing, last_auto_save):
10431 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10432 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10433 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10434 (Vlispy_mouse_stem, double_click_count):
10436 (force_auto_save_soon): Define only if SIGDANGER.
10437 (ignore_mouse_drag_p): Now static if
10438 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10439 (print_help): Remove; unused.
10440 (stop_character, last_timer_event): Mark as externally visible.
10441 * keyboard.h (ignore_mouse_drag_p): Declare only if
10442 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10443 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10444 * lisp.h (echoing): Remove decl.
10445 (force_auto_save_soon): Declare only if SIGDANGER.
10446 * xdisp.c (redisplay_window): Simplify code, to make it more
10447 obvious that ignore_mouse_drag_p is not accessed if !defined
10448 USE_GTK && !defined HAVE_NS.
10450 * intervals.c: Make symbols static if they're not exported.
10451 (merge_properties_sticky, merge_interval_right, delete_interval):
10453 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10455 * insdel.c: Make symbols static if they're not exported.
10456 However, leave prepare_to_modify_buffer alone. It's never
10457 called from outside this function, but that appears to be a bug.
10458 (combine_after_change_list, combine_after_change_buffer):
10459 (adjust_after_replace, signal_before_change): Now static.
10460 (adjust_after_replace_noundo): Remove; unused.
10461 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
10462 (signal_before_change): Remove decls.
10464 * indent.c (val_compute_motion, val_vmotion): Now static.
10466 * image.c: Make symbols static if they're not exported.
10467 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10469 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10470 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10472 * fringe.c (standard_bitmaps): Now static.
10473 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10475 * frame.c: Make symbols static if they're not exported.
10476 (x_report_frame_params, make_terminal_frame): Now static.
10477 (get_frame_param): Now static, unless HAVE_NS.
10478 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10479 (x_get_resource_string): Remove; not used.
10480 * frame.h (make_terminal_frame, x_report_frame_params):
10481 (x_get_resource_string); Remove decls.
10482 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10483 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10485 * font.c, fontset.c: Make symbols static if they're not exported.
10486 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10487 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10488 * font.c (font_close_object): Now static.
10489 * font.h (font_close_object): Remove.
10490 * fontset.c (FONTSET_OBJLIST): Remove.
10491 (free_realized_fontset) #if-0 the body, which does nothing.
10492 (face_suitable_for_char_p): #if-0, as it's never called.
10493 * fontset.h (face_suitable_for_char_p): Remove decl.
10494 * xfaces.c (face_at_string_position):
10495 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
10496 since 0 is always ASCII.
10498 * fns.c (weak_hash_tables): Now static.
10500 * fileio.c: Make symbols static if they're not exported.
10501 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10502 (Vwrite_region_annotation_buffers): Now static.
10504 * eval.c: Make symbols static if they're not exported.
10505 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10506 * lisp.h (backtrace_list): Remove decl.
10508 * emacs.c: Make symbols static if they're not exported.
10509 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10510 (fatal_error_code, fatal_error_signal_hook, standard_args):
10512 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10513 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10514 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10515 * lisp.h (fatal_error_signal_hook): Remove decl.
10516 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10518 * editfns.c: Move a (normally-unused) function to its only use.
10519 * editfns.c, lisp.h (get_operating_system_release): Remove.
10520 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10521 worth the hassle of breaking this out.
10523 * xterm.c: Make symbols static if they're not exported.
10524 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10525 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10526 (x_destroy_window, x_delete_display):
10528 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10529 (x_mouse_leave): Remove; unused.
10530 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10531 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10532 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10534 (x_mouse_leave): Declare only if WINDOWSNT.
10535 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10536 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10539 * ftxfont.c: Make symbols static if they're not exported.
10540 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10542 * font.h (ftxfont_driver): Likewise.
10544 * xfns.c: Make symbols static if they're not exported.
10545 (x_last_font_name, x_display_info_for_name):
10546 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10547 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10548 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10549 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10550 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10551 (last_show_tip_args): Now static.
10552 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10553 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10554 (x_screen_planes): Remove; unused.
10555 * dispextern.h (x_screen_planes): Remove decl.
10557 * dispnew.c: Make symbols static if they're not exported.
10558 * dispextern.h (redraw_garbaged_frames, scrolling):
10559 (increment_row_positions): Remove.
10560 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10561 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10563 (redraw_garbaged_frames): Remove; unused.
10565 * xfaces.c: Make symbols static if they're not exported.
10566 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10568 * xterm.h (defined_color): Remove decls.
10569 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10570 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10571 (menu_face_changed_default, defined_color, free_realized_face):
10572 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10573 (ascii_face_of_lisp_face): Remove; unused.
10575 * xdisp.c: Make symbols static if they're not exported.
10576 * dispextern.h (scratch_glyph_row, window_box_edges):
10577 (glyph_to_pixel_coords, set_cursor_from_row):
10578 (get_next_display_element, set_iterator_to_next):
10579 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10580 (show_mouse_face): Remove decls
10581 * frame.h (message_buf_print): Likewise.
10582 * lisp.h (pop_message, set_message, check_point_in_composition):
10584 * xterm.h (set_vertical_scroll_bar): Likewise.
10585 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10586 (message_buf_print, scratch_glyph_row, displayed_buffer):
10587 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10588 (get_next_display_element, show_mouse_face, window_box_edges):
10589 (frame_to_window_pixel_xy, check_point_in_composition):
10590 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10591 (glyph_to_pixel_coords): Remove; unused.
10593 * dired.c (file_name_completion): Now static.
10595 * dbusbind.c (xd_in_read_queued_messages): Now static.
10597 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10598 * data.c (circular_list_error): Remove.
10600 * commands.h (last_point_position, last_point_position_buffer):
10601 (last_point_position_window): Remove decls.
10602 * keyboard.c: Make these variables static.
10604 * coding.h (coding, code_convert_region, encode_coding_gap):
10606 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10607 (iso_code_class, detect_coding, code_convert_region): Now static.
10608 (encode_coding_gap): Remove; unused.
10610 * chartab.c (chartab_chars, chartab_bits): Now static.
10612 * charset.h (charset_iso_8859_1): Remove decl.
10613 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10616 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10617 * ccl.c (Vccl_program_table): Now static.
10618 (check_ccl_update): Remove; unused.
10620 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10621 * category.h: ... from here.
10622 * category.c (check_category_table, set_category_set): Now static.
10624 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10625 * lisp.h: Remove these decls.
10627 * buffer.c (buffer_count): Remove unused var.
10629 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10630 so that it's not optimized away.
10631 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10632 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10633 exported only to the debugger.
10635 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
10636 * atimer.h (run_all_atimers): Remove; not exported.
10638 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10639 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10640 was inaccessible from Lisp.
10641 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10642 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10644 alloc.c: Import and export fewer symbols, and remove unused items.
10645 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10647 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10648 it's not optimized away by whole-program optimization.
10649 (message_enable_multibyte, free_misc): Remove.
10650 (catchlist, handlerlist, mark_backtrace):
10651 Declare only if BYTE_MARK_STACK.
10652 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10653 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10654 (message_enable_multibyte): Remove decl.
10655 (free_misc, interval_free_list, float_block, float_block_index):
10656 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10657 (cons_free_list, last_marked_index):
10659 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10660 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10661 (mark_backtrace): Define only if BYTE_MARK_STACK.
10662 * xdisp.c (message_enable_multibyte): Now static.
10664 Declare Lisp_Object Q* variables to be 'static' if not exported.
10665 This makes it easier for human readers (and static analyzers)
10666 to see whether these variables are used from other modules.
10667 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10668 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10669 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10670 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10671 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10672 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10673 * xmenu.c, xselect.c:
10674 Declare Q* vars static if they are not used in other modules.
10675 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10676 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10677 Remove decls of unexported vars.
10678 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10680 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10682 Make Emacs functions such as Fatom 'static' by default.
10683 This makes it easier for human readers (and static analyzers)
10684 to see whether these functions can be called from other modules.
10685 DEFUN now defines a static function. To make the function external
10686 so that it can be used in other C modules, use the new macro DEFUE.
10687 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10688 (Finit_image_library):
10689 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10690 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10691 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10692 Remove decls, since these functions are now static.
10693 (Funintern, Fget_internal_run_time): New decls, since these functions
10694 were already external.
10696 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10697 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10698 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10699 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10700 * keyboard.c, keymap.c, lread.c:
10701 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10702 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10703 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10704 Mark functions with DEFUE instead of DEFUN,
10705 if they are used in other modules.
10706 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10707 decls for now-static functions.
10708 * buffer.h (Fdelete_overlay): Remove decl.
10709 * callproc.c (Fgetenv_internal): Mark as internal.
10710 * composite.c (Fremove_list_of_text_properties): Remove decl.
10711 (Fcomposition_get_gstring): New forward static decl.
10712 * composite.h (Fcomposite_get_gstring): Remove decl.
10713 * dired.c (Ffile_attributes): New forward static decl.
10714 * doc.c (Fdocumntation_property): New forward static decl.
10715 * eval.c (Ffetch_bytecode): New forward static decl.
10716 (Funintern): Remove extern decl; now in .h file where it belongs.
10717 * fileio.c (Fmake_symbolic_link): New forward static decl.
10718 * image.c (Finit_image_library): New forward static decl.
10719 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10720 * intervals.h (Fprevious_property_change):
10721 (Fremove_list_of_text_properties): Remove decls.
10722 * keyboard.c (Fthis_command_keys): Remove decl.
10723 (Fcommand_execute): New forward static decl.
10724 * keymap.c (Flookup_key): New forward static decl.
10725 (Fcopy_keymap): Now static.
10726 * keymap.h (Flookup_key): Remove decl.
10727 * process.c (Fget_process): New forward static decl.
10728 (Fprocess_datagram_address): Mark as internal.
10729 * syntax.c (Fsyntax_table_p): New forward static decl.
10730 (skip_chars): Remove duplicate decl.
10731 * textprop.c (Fprevious_property_change): New forward static decl.
10732 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10734 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10735 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10737 * editfns.c (Fformat): Remove unreachable code.
10739 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10741 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10744 2011-04-13 Eli Zaretskii <eliz@gnu.org>
10746 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10747 when at ZV. (Bug#8487)
10749 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10751 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10753 * keyboard.c (parse_tool_bar_item): Likewise.
10754 * sound.c (sound_cleanup, alsa_close): Likewise.
10755 * termcap.c (tgetent): Likewise.
10756 * xfns.c (x_default_font_parameter): Likewise.
10757 * xsettings.c (read_and_apply_settings): Likewise.
10759 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10760 (overrun_check_free): Protoize.
10762 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10764 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10765 since callers should never pass a negative size.
10766 Change the signature to match that of plain 'read' and 'write'; see
10767 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10768 * lisp.h: Update prototypes of emacs_write and emacs_read.
10770 2011-04-11 Eli Zaretskii <eliz@gnu.org>
10772 * xdisp.c (redisplay_window): Don't try to determine the character
10773 position of the scroll margin if the window start point w->startp
10774 is outside the buffer's accessible region. (Bug#8468)
10776 2011-04-10 Eli Zaretskii <eliz@gnu.org>
10778 Fix write-region and its subroutines for buffers > 2GB.
10779 * fileio.c (a_write, e_write): Modify declaration of arguments and
10780 local variables to support buffers larger than 2GB.
10781 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10783 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10784 argument, local variables, and return value.
10786 * lisp.h: Update prototypes of emacs_write and emacs_read.
10788 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10790 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
10792 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10794 Fix more problems found by GCC 4.6.0's static checks.
10796 * xdisp.c (vmessage): Use a better test for character truncation.
10798 * charset.c (load_charset_map): <, not <=, for optimization,
10799 and to avoid potential problems with integer overflow.
10800 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
10801 * casetab.c (set_identity, shuffle): Likewise.
10802 * editfns.c (Fformat): Likewise.
10803 * syntax.c (skip_chars): Likewise.
10805 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10806 This also lets GCC 4.6.0 generate slightly better loop code.
10808 * callint.c (Fcall_interactively): <, not <=, for optimization.
10809 (Fcall_interactively): Count the number of arguments produced,
10810 not the number of arguments given. This is simpler and lets GCC
10811 4.6.0 generate slightly better code.
10813 * ftfont.c: Distingish more carefully between FcChar8 and char.
10814 The previous code passed unsigned char * to a functions like
10815 strlen and xstrcasecmp that expect char *, which does not
10816 conform to the C standard.
10817 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10818 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10819 char * when the C standard requires it.
10821 * keyboard.c (read_char): Remove unused var.
10823 * eval.c: Port to Windows vsnprintf (Bug#8435).
10824 Include <limits.h>.
10825 (SIZE_MAX): Define if the headers do not.
10826 (verror): Do not give up if vsnprintf returns a negative count.
10827 Instead, grow the buffer. This ports to Windows vsnprintf, which
10828 does not conform to C99. Problem reported by Eli Zaretskii.
10829 Also, simplify the allocation scheme, by avoiding the need for
10830 calling realloc, and removing the ALLOCATED variable.
10832 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10834 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10835 But keep the doprint source code for now, as we might revamp it
10836 and use it again (Bug#8435).
10837 * lisp.h (doprnt): Remove.
10838 * Makefile.in (base_obj): Remove doprnt.o.
10839 * deps.mk (doprnt.o): Remove.
10841 error: Print 32- and 64-bit integers portably (Bug#8435).
10842 Without this change, on typical 64-bit hosts error ("...%d...", N)
10843 was used to print both 32- and 64-bit integers N, which relied on
10844 undefined behavior.
10845 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
10846 * lisp.h (error, verror): Mark as printf-like functions.
10847 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10848 Report overflow in size calculations when allocating printf buffer.
10849 Do not truncate output string at its first null byte.
10850 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10851 Truncate the output at a character boundary, since vsnprintf does not
10853 * charset.c (check_iso_charset_parameter): Convert internal
10854 character to string before calling 'error', since %c now has the
10856 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10857 overflow when computing char to be passed to 'error'. Do not
10858 pass Lisp_Object to 'error'; pass the integer instead.
10859 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10860 formatted with plain %d.
10862 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10864 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10866 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10868 * xterm.c (x_catch_errors): Remove duplicate declaration.
10870 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10872 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10874 2011-04-10 Jim Meyering <meyering@redhat.com>
10876 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10877 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10878 return ssize_t not "int", and use size_t as the buffer length.
10879 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10880 * gnutls.h: Update declarations.
10881 * process.c (read_process_output): Use ssize_t, to match.
10882 (send_process): Likewise.
10884 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10886 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10888 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10890 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10891 Use unsigned char, to match FcChar8 type definition.
10893 * xterm.c (handle_one_xevent):
10894 * xmenu.c (create_and_show_popup_menu):
10895 * xselect.c (x_decline_selection_request)
10896 (x_reply_selection_request): Avoid type-punned deref of X events.
10898 2011-04-09 Eli Zaretskii <eliz@gnu.org>
10900 Fix some uses of `int' instead of EMACS_INT.
10901 * search.c (string_match_1, fast_string_match)
10902 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10903 (scan_buffer, find_next_newline_no_quit)
10904 (find_before_next_newline, search_command, Freplace_match)
10905 (Fmatch_data): Make some `int' variables be EMACS_INT.
10907 * xdisp.c (display_count_lines): 3rd argument and return value now
10908 EMACS_INT. All callers changed.
10909 (pint2hrstr): Last argument is now EMACS_INT.
10911 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10912 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10913 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10914 (decode_coding_utf_16, decode_coding_emacs_mule)
10915 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10916 (decode_coding_ccl, decode_coding_charset)
10917 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10918 (decode_coding_iso_2022, decode_coding_emacs_mule)
10919 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10920 <char_offset, last_offset>: Declare EMACS_INT.
10921 (encode_coding_utf_8, encode_coding_utf_16)
10922 (encode_coding_emacs_mule, encode_invocation_designation)
10923 (encode_designation_at_bol, encode_coding_iso_2022)
10924 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10925 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10927 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10928 (encode_invocation_designation): Last argument P_NCHARS is now
10930 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10931 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10933 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10936 * ccl.c (Fccl_execute_on_string): Declare some variables
10939 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
10941 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10943 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10945 * process.c (Fformat_network_address): Doc fix.
10947 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10949 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
10951 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
10953 * keyboard.c (read_char): Call Lisp function help-form-show,
10954 instead of using internal_with_output_to_temp_buffer.
10955 (Qhelp_form_show): New var.
10956 (syms_of_keyboard): Use DEFSYM macro.
10958 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10960 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10962 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
10964 * process.c (Flist_processes): Remove to Lisp.
10965 (list_processes_1): Delete.
10967 2011-04-06 Eli Zaretskii <eliz@gnu.org>
10969 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10971 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10973 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
10975 Fix more problems found by GCC 4.6.0's static checks.
10977 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10979 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10981 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
10983 * xdisp.c (vmessage): Mark as a printf-like function.
10985 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10987 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10989 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10990 printf-like functions.
10991 (tiff_load): Add casts to remove these marks before passing them
10992 to system-supplied API.
10994 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10996 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10997 This avoids several warnings with gcc -Wstrict-overflow.
10998 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10999 directly, rather than having caller test rule sign. This avoids
11000 some unnecessary tests.
11001 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11002 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11003 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
11005 * xfont.c (xfont_text_extents): Remove var that was set but not used.
11006 (xfont_open): Avoid unnecessary tests.
11008 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11010 * composite.h, composite.c (composition_gstring_put_cache):
11011 Use EMACS_INT, not int, for length.
11013 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11014 breaking out part of COMPOSITION_DECODE_RULE.
11015 (COMPOSITION_DECODE_RULE): Use it.
11016 * composite.c (get_composition_id): Remove unused local vars,
11017 by using the new macro.
11019 * textprop.c (set_text_properties_1): Change while to do-while,
11020 since the condition is always true at first.
11022 * intervals.c (graft_intervals_into_buffer): Mark var as used.
11023 (interval_deletion_adjustment): Return unsigned value.
11026 * process.c (list_processes_1, create_pty, read_process_output):
11027 (exec_sentinel): Remove vars that were set but not used.
11028 (create_pty): Remove unnecessary "volatile"s.
11029 (Fnetwork_interface_info): Avoid possibility of int overflow.
11030 (read_process_output): Do adaptive read buffering even if carryover.
11031 (read_process_output): Simplify nbytes computation if buffered.
11033 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11035 * syntax.c (scan_words): Remove var that was set but not used.
11036 (update_syntax_table): Use unsigned instead of int.
11038 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
11039 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
11040 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
11042 * print.c (print_error_message): Avoid int overflow.
11044 * font.c (font_list_entities): Redo for clarity,
11045 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11047 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
11048 (font_score): Avoid potential overflow in diff calculation.
11050 * fns.c (substring_both): Remove var that is set but not used.
11051 (sxhash): Redo loop for clarity and to avoid wraparound warning.
11053 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11055 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11056 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11057 can always succeed if overflow has undefined behavior.
11059 * search.c (boyer_moore, wordify): Remove vars set but not used.
11060 (wordify): Omit three unnecessary tests.
11062 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11063 All callers changed. This avoids the need for an unused var.
11065 * casefiddle.c (casify_region): Remove var that is set but not used.
11067 * dired.c (file_name_completion): Remove var that is set but not used.
11069 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11071 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
11072 (Finsert_file_contents): Remove unnecessary code checking fd.
11074 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11075 Check for integer overflow on size calculations.
11077 * buffer.c (Fprevious_overlay_change): Remove var that is set
11080 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11081 Remove vars that are set but not used.
11082 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
11083 (timer_check_2): Mark vars as initialized.
11085 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11087 * image.c (lookup_image): Remove var that is set but not used.
11088 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
11090 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11091 that are set but not used.
11093 * xfns.c (make_invisible_cursor): Don't return garbage
11094 if XCreateBitmapFromData fails (Bug#8410).
11096 * xselect.c (x_get_local_selection, x_handle_property_notify):
11097 Remove vars that are set but not used.
11099 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
11100 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
11102 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11103 Remove var that is set but not used.
11104 (scroll_bar_windows_size): Now size_t, not int.
11105 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11106 Check for overflow.
11108 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11109 (map_tty_color) [!defined MSDOS]: Likewise.
11111 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11113 * coding.c: Remove vars that are set but not used.
11114 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11115 All callers changed.
11116 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11117 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11118 (decode_coding_charset): Remove vars that are set but not used.
11120 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11121 that is set but not used.
11123 * print.c (print_object): Remove var that is set but not used.
11125 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
11126 The gnulib version avoids calling malloc in the usual case,
11127 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11128 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11129 * filelock.c (current_lock_owner): Likewise.
11130 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11131 * sysdep.c: Include allocator.h, careadlinkat.h.
11132 (emacs_no_realloc_allocator): New static constant.
11133 (emacs_readlink): New function.
11134 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11135 ../lib/careadlinkat.h.
11137 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11139 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11140 first non-nil return value).
11142 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11144 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11145 if not defined (Bug#8403).
11147 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11149 * xdisp.c (display_count_lines): Remove parameter `start',
11150 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11151 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11152 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11153 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11154 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11155 and thereabouts. All callers changed.
11156 (get_per_char_metric): Remove parameter `f', unused since
11157 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11159 2011-04-02 Jim Meyering <meyering@redhat.com>
11161 do not dereference NULL upon failed strdup
11162 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11163 (ns_get_family): Likewise.
11165 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11167 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11169 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11171 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11174 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11176 Add lexical binding.
11178 * window.c (Ftemp_output_buffer_show): New fun.
11179 (Fsave_window_excursion):
11180 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11182 * lread.c (lisp_file_lexically_bound_p): New function.
11183 (Fload): Bind Qlexical_binding.
11184 (readevalloop): Remove `evalfun' arg.
11185 Bind Qinternal_interpreter_environment.
11186 (Feval_buffer): Bind Qlexical_binding.
11187 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11189 (syms_of_lread): Declare `lexical-binding'.
11191 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11193 * keyboard.c (eval_dyn): New fun.
11194 (menu_item_eval_property): Use it.
11196 * image.c (parse_image_spec): Use Ffunctionp.
11198 * fns.c (concat, mapcar1): Accept byte-code-functions.
11200 * eval.c (Fsetq): Handle lexical vars.
11201 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11202 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11203 (FletX, Flet): Obey lexical binding.
11204 (Fcommandp): Handle closures.
11205 (Feval): New `lexical' arg.
11206 (eval_sub): New function extracted from Feval. Use it almost
11207 everywhere where Feval was used. Look up vars in lexical env.
11209 (Ffunctionp): Move from subr.el.
11210 (Ffuncall): Handle closures.
11211 (apply_lambda): Remove `eval_flags'.
11212 (funcall_lambda): Handle closures and new byte-code-functions.
11213 (Fspecial_variable_p): New function.
11214 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11215 but without exporting it to Lisp.
11217 * doc.c (Fdocumentation, store_function_docstring):
11218 * data.c (Finteractive_form): Handle closures.
11220 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11223 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11225 (exec_byte_code): New function extracted from Fbyte_code to handle new
11226 calling convention for byte-code-functions. Add new byte-codes.
11228 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
11230 * alloc.c (Fmake_symbol): Init new `declared_special' field.
11232 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
11234 * xdisp.c (redisplay_internal): Fix prototype.
11236 2011-03-31 Eli Zaretskii <eliz@gnu.org>
11238 * xdisp.c (SCROLL_LIMIT): New macro.
11239 (try_scrolling): Use it when setting scroll_limit.
11240 Limit scrolling to 100 screen lines.
11241 (redisplay_window): Even when falling back on "recentering",
11242 position point in the window according to scroll-conservatively,
11243 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11245 (try_scrolling): When point is above the window, allow searching
11246 as far as scroll_max, or one screenful, to compute vertical
11247 distance from PT to the scroll margin position. This prevents
11248 try_scrolling from unnecessarily failing when
11249 scroll-conservatively is set to a value slightly larger than the
11250 window height. Clean up the case of PT below the margin at bottom
11251 of window: scroll_max can no longer be INT_MAX. When aggressive
11252 scrolling is in use, don't let point enter the opposite scroll
11253 margin as result of the scroll.
11254 (syms_of_xdisp) <scroll-conservatively>: Document the
11255 threshold of 100 lines for never-recentering scrolling.
11257 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
11259 * dispextern.h (move_it_by_lines):
11260 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11261 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11262 (message_log_check_duplicate): Remove parameters `prev_bol' and
11263 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11264 (redisplay_internal): Remove parameter `preserve_echo_area',
11265 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11267 * indent.c (Fvertical_motion):
11268 * window.c (window_scroll_pixel_based, Frecenter):
11269 Don't pass `need_y_p' to `move_it_by_lines'.
11271 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11273 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11274 steal a few bits to be more compact.
11275 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11276 Remove unneeded casts.
11278 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11280 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11282 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11283 binding" message (bug#7967).
11285 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11287 Fix more problems found by GCC 4.6.0's static checks.
11289 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11290 Remove unused local var.
11292 * editfns.c (Fmessage_box): Remove unused local var.
11294 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11295 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11296 Omit unused local vars.
11297 * window.c (shrink_windows): Omit unused local var.
11298 * menu.c (digest_single_submenu): Omit unused local var.
11299 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11300 Omit unused local var.
11302 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11303 Don't assume string length fits in int.
11304 (keyremap_step, read_key_sequence): Use size_t for sizes.
11305 (read_key_sequence): Don't check last_real_key_start redundantly.
11307 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11308 instead of alloca (Bug#8344).
11310 * eval.c (Fbacktrace): Don't assume nargs fits in int.
11311 (Fbacktrace_frame): Don't assume nframes fits in int.
11313 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11315 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11318 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11320 * cm.c (calccost): Turn while-do into do-while, for clarity.
11322 * keyboard.c (syms_of_keyboard): Use the same style as later
11323 in this function when indexing through an array. This also
11324 works around GCC bug 48267.
11326 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11328 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11330 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11331 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11333 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11334 This avoids undefined behavior on integer overflow, and is a bit
11335 more convenient anyway since it is compared to a size_t variable.
11337 Variadic C functions now count arguments with size_t, not int.
11338 This avoids an unnecessary limitation on 64-bit machines, which
11339 caused (substring ...) to crash on large vectors (Bug#8344).
11340 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11341 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
11342 All variadic functions and their callers changed accordingly.
11343 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11344 * data.c (arith_driver, float_arith_driver): Likewise.
11345 * editfns.c (general_insert_function): Likewise.
11346 * eval.c (struct backtrace.nargs, interactive_p)
11347 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11348 (funcall_lambda, mark_backtrace): Likewise.
11349 * fns.c (concat): Likewise.
11350 * frame.c (x_set_frame_parameters): Likewise.
11351 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11352 0 if not found, not -1. All callers changed.
11354 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11355 (stack_copy_size): Now size_t, not int.
11356 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11358 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
11360 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11361 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11362 All callers changed.
11364 * lisp.h (multibyte_char_to_unibyte):
11365 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11366 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11367 * character.h (CHAR_TO_BYTE8):
11368 * cmds.c (internal_self_insert):
11369 * editfns.c (general_insert_function):
11370 * keymap.c (push_key_description):
11371 * search.c (Freplace_match):
11372 * xdisp.c (message_dolog, set_message_1): All callers changed.
11374 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11376 * keyboard.c (safe_run_hook_funcall): New function.
11377 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11378 don't set the hook to nil, but remove the offending function instead.
11379 (Qcommand_hook_internal): Remove, unused.
11380 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11381 Vcommand_hook_internal.
11383 * eval.c (enum run_hooks_condition): Remove.
11384 (funcall_nil, funcall_not): New functions.
11385 (run_hook_with_args): Call each function through a `funcall' argument.
11386 Remove `cond' argument, now redundant.
11387 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11388 (Frun_hook_with_args_until_failure): Adjust accordingly.
11389 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11391 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
11393 * dispextern.h (string_buffer_position): Remove declaration.
11395 * print.c (strout): Remove parameter `multibyte', unused since
11396 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11398 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11399 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11400 All callers changed.
11402 * w32.c (_wsa_errlist): Use braces for struct initializers.
11404 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11405 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11406 All callers changed.
11407 (string_buffer_position): Likewise. Also, make static (it's never
11408 used outside xdisp.c).
11409 (cursor_row_p): Remove parameter `w', unused since
11410 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11411 (decode_mode_spec): Remove parameter `precision', introduced during
11412 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11413 All callers changed.
11415 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11417 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11419 2011-03-27 Anders Lindgren <andlind@gmail.com>
11421 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11422 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11423 (ns_update_auto_hide_menu_bar): New functions.
11424 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11425 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11426 ns_constrain_all_frames.
11427 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11428 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11430 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11432 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11434 2011-03-27 Glenn Morris <rgm@gnu.org>
11436 * syssignal.h: Replace RETSIGTYPE with void.
11437 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11438 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11439 Replace SIGTYPE with void everywhere.
11440 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11441 * s/template.h (SIGTYPE): Remove commented out definition.
11443 2011-03-26 Eli Zaretskii <eliz@gnu.org>
11445 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11446 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11448 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
11450 * w32.c (read_unc_volume): Use parameter `henum', instead of
11451 global variable `wget_enum_handle'.
11453 * keymap.c (describe_vector): Remove parameters `indices' and
11454 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11455 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11457 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11459 * keyboard.c (timer_check): Remove parameter `do_it_now',
11460 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11461 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11462 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11464 * keyboard.c (read_char):
11465 * w32menu.c (w32_menu_display_help):
11466 * xmenu.c (show_help_event, menu_help_callback):
11467 Adjust calls to `show_help_echo'.
11469 * gtkutil.c (xg_maybe_add_timer):
11470 * keyboard.c (readable_events):
11471 * process.c (wait_reading_process_output):
11472 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11474 * insdel.c (adjust_markers_gap_motion):
11475 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11476 (gap_left, gap_right): Don't call it.
11478 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
11480 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11481 incurred during fontification.
11483 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
11485 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11486 (DEFVAR_PER_BUFFER): Don't pass it.
11488 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11489 (scrolling_window): Don't pass it.
11491 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
11493 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11495 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11497 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11498 of variables specific to SELinux and computation of `encoded_absname'.
11500 * image.c (XPutPixel): Remove unused variable `height'.
11502 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11504 * unexw32.c (get_section_info): Remove unused variable `section'.
11506 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11507 (system_process_attributes): Remove unused variable `sess'.
11508 (sys_read): Remove unused variable `err'.
11510 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11511 (w32_wnd_proc): Remove unused variable `isdead'.
11512 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11513 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11514 (x_create_tip_frame): Remove unused variable `tem'.
11516 * w32inevt.c (w32_console_read_socket):
11517 Remove unused variable `no_events'.
11519 * w32term.c (x_draw_composite_glyph_string_foreground):
11520 Remove unused variable `width'.
11522 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
11524 * w32term.c (x_set_glyph_string_clipping):
11525 Don't pass uninitialized region to CombineRgn.
11527 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
11529 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11530 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11531 (Fx_close_connection): Remove unused variable `i'.
11533 * w32font.c (w32font_draw): Return number of glyphs.
11534 (w32font_open_internal): Remove unused variable `i'.
11535 (w32font_driver): Add missing initializer.
11537 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11538 (fill_in_menu): Remove unused variable `items_added'.
11540 * w32term.c (last_mouse_press_frame): Remove static global variable.
11541 (w32_clip_to_row): Remove unused variable `f'.
11542 (x_delete_terminal): Remove unused variable `i'.
11544 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11545 (NOTHING): Remove unused static global variable.
11546 (uniscribe_check_otf): Remove unused variable `table'.
11547 (uniscribe_font_driver): Add missing initializers.
11549 2011-03-23 Julien Danjou <julien@danjou.info>
11551 * term.c (Fsuspend_tty, Fresume_tty):
11552 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11553 * window.c (temp_output_buffer_show):
11554 * insdel.c (signal_before_change):
11555 * frame.c (Fhandle_switch_frame):
11556 * fileio.c (Fdo_auto_save):
11557 * emacs.c (Fkill_emacs):
11558 * editfns.c (save_excursion_restore):
11559 * cmds.c (internal_self_insert):
11560 * callint.c (Fcall_interactively):
11561 * buffer.c (Fkill_all_local_variables):
11562 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11564 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
11565 unconditionally since it does the check itself.
11567 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
11569 Fix more problems found by GCC 4.5.2's static checks.
11571 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11572 the first time through the loop, since we know p0 < p1 then.
11573 This also avoids a gcc -Wstrict-overflow warning.
11575 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11576 leading to a memory leak, possible in functions like
11577 load_charset_map_from_file that can allocate an unbounded number
11578 of objects (Bug#8318).
11580 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11581 that could (at least in theory) be that large.
11583 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11584 This is less likely to overflow, and avoids undefined behavior if
11585 overflow does occur. All callers changed. Use strtoul to scan
11586 for the unsigned long integer.
11587 (pint2hrstr): Simplify and tune code slightly.
11588 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
11590 * scroll.c (do_scrolling): Work around GCC bug 48228.
11591 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11593 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11594 This also avoids a warning with gcc -Wstrict-overflow.
11595 (validate_x_resource_name): Simplify count usage.
11596 This also avoids a warning with gcc -Wstrict-overflow.
11598 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11601 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
11603 * process.c (Fmake_network_process): Use socklen_t, not int,
11604 where POSIX says socklen_t is required in portable programs.
11605 This fixes a porting bug on hosts like 64-bit HP-UX, where
11606 socklen_t is wider than int (Bug#8277).
11607 (Fmake_network_process, server_accept_connection):
11608 (wait_reading_process_output, read_process_output):
11611 * process.c: Rename or move locals to avoid shadowing.
11612 (list_processes_1, Fmake_network_process):
11613 (read_process_output_error_handler, exec_sentinel_error_handler):
11614 Rename or move locals.
11615 (Fmake_network_process): Define label "retry_connect" only if needed.
11616 (Fnetwork_interface_info): Fix pointer signedness.
11617 (process_send_signal): Add cast to avoid pointer signedness problem.
11618 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
11619 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
11621 Make tparam.h and terminfo.c consistent.
11622 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11623 Include tparam.h instead, since it declares them.
11624 * cm.h (PC): Remove extern decl; tparam.h now does this.
11625 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11626 * terminfo.c: Include tparam.h, to check interfaces.
11627 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11628 (tparam): Adjust signature to match interface in tparam.h;
11629 this removes some undefined behavior. Check that outstring and len
11630 are zero, which they always are with Emacs.
11631 * tparam.h (PC, BC, UP): New extern decls.
11633 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
11634 (xftfont_open): Rename locals to avoid shadowing.
11636 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
11637 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11638 (OTF_TAG_SYM): Omit macro if not needed.
11639 (ftfont_list): Remove unused local.
11640 (get_adstyle_property, ftfont_pattern_entity):
11641 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11642 Rename locals to avoid shadowing.
11644 * xfont.c (xfont_list_family): Mark var as initialized.
11646 * xml.c (make_dom): Now static.
11648 * composite.c (composition_compute_stop_pos): Rename local to
11650 (composition_reseat_it): Remove unused locals.
11651 (find_automatic_composition, composition_adjust_point): Likewise.
11652 (composition_update_it): Mark var as initialized.
11653 (find_automatic_composition): Mark vars as initialized,
11654 with a FIXME (Bug#8290).
11656 character.h: Rename locals to avoid shadowing.
11657 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11658 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11659 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11660 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11661 to avoid shadowing.
11663 * textprop.c (property_change_between_p): Remove; unused.
11665 * intervals.c (interval_start_pos): Now static.
11667 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11669 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11670 Rename locals to avoid shadowing.
11672 * sound.c (wav_play, au_play, Fplay_sound_internal):
11673 Fix pointer signedness.
11674 (alsa_choose_format): Remove unused local var.
11675 (wav_play): Initialize a variable to 0, to prevent undefined
11676 behavior (Bug#8278).
11678 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11680 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11682 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11683 clobbering (Bug#8298).
11684 * sysdep.c (sys_subshell): Likewise.
11685 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
11687 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11688 This should get cleaned up, so that child_setup has the
11689 same signature on all platforms.
11691 * callproc.c (call_process_cleanup): Now static.
11692 (relocate_fd): Rename locals to avoid shadowing.
11694 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
11696 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11697 not to be necessary, and produces flickering.
11699 2011-03-20 Glenn Morris <rgm@gnu.org>
11701 * config.in: Remove file.
11703 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
11705 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11706 are now in src/globals.h.
11707 (syms_of_minibuf): Remove spurious & from previous change.
11709 2011-03-20 Leo Liu <sdl.web@gmail.com>
11711 * minibuf.c (completing-read-function): New variable.
11712 (completing-read-default): Rename from completing-read.
11713 (completing-read): Call completing-read-function.
11715 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
11717 * xfaces.c (Fx_load_color_file):
11718 Read color file from absolute filename (bug#8250).
11720 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
11722 * makefile.w32-in: Update dependencies.
11724 2011-03-17 Eli Zaretskii <eliz@gnu.org>
11726 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11728 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11730 Fix more problems found by GCC 4.5.2's static checks.
11732 * process.c (make_serial_process_unwind, send_process_trap):
11733 (sigchld_handler): Now static.
11735 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11736 That way, the code declares only the vars that it needs.
11737 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11738 * s/cygwin.h (PTY_ITERATION): Likewise.
11739 * s/darwin.h (PTY_ITERATION): Likewise.
11740 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11742 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11743 * process.c (allocate_pty): Don't declare stb unless it's needed.
11745 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
11746 (CONSTANTLIM): Remove; unused.
11747 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11748 Define only if needed.
11750 * unexelf.c (unexec): Name an expression,
11751 to avoid gcc -Wbad-function-cast warning.
11752 Use a different way to cause a compilation error if anyone uses
11753 n rather than nn, a way that does not involve shadowing.
11754 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
11756 * deps.mk (unexalpha.o): Remove; unused.
11758 New file unexec.h, the (simple) interface for unexec (Bug#8267).
11759 * unexec.h: New file.
11760 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11761 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11762 Depend on unexec.h.
11763 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11764 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11765 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
11766 Change as necessary to match prototype in unexec.h.
11768 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11770 (back_comment, skip_chars): Mark vars as initialized.
11772 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11773 Rename locals to avoid shadowing.
11775 * lread.c (read1): Rewrite so as not to use empty "else".
11776 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
11778 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11780 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11781 warning when compiling print.c.
11783 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11784 instead of using an uninitialized var.
11785 (font_sort_entities): Mark var as initialized.
11787 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11789 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11790 pointers to constants.
11791 (font_parse_fcname): Remove unused vars.
11792 (font_delete_unmatched): Now static.
11793 (font_get_spec): Remove; unused.
11794 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11795 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11796 Rename or move locals to avoid shadowing.
11798 * fns.c (require_nesting_list, require_unwind): Now static.
11799 (Ffillarray): Rename locals to avoid shadowing.
11801 * floatfns.c (domain_error2): Define only if needed.
11802 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
11804 * alloc.c (mark_backtrace): Move decl from here ...
11805 * lisp.h: ... to here, so that it can be checked.
11807 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
11808 (Fdefvar): Rewrite so as not to use empty "else".
11809 (lisp_indirect_variable): Name an expression,
11810 to avoid gcc -Wbad-function-cast warning.
11811 (Fdefvar): Rename locals to avoid shadowing.
11813 * callint.c (quotify_arg, quotify_args): Now static.
11814 (Fcall_interactively): Rename locals to avoid shadowing.
11815 Use const pointer when appropriate.
11817 * lisp.h (get_system_name, get_operating_system_release):
11818 Move decls here, to check interfaces.
11819 * process.c (get_operating_system_release): Move decl to lisp.h.
11820 * xrdb.c (get_system_name): Likewise.
11821 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11822 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11823 some of which prompt warnings from gcc -Wbad-function-cast.
11824 (Fformat_time_string, Fencode_time, Finsert_char):
11825 (Ftranslate_region_internal, Fformat):
11826 Rename or remove local vars to avoid shadowing.
11827 (Ftranslate_region_internal): Mark var as initialized.
11829 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11832 * lisp.h (eassert): Check that the argument compiles, even if
11833 ENABLE_CHECKING is not defined.
11835 * data.c (Findirect_variable): Name an expression, to avoid
11836 gcc -Wbad-function-cast warning.
11837 (default_value, arithcompare, arith_driver, arith_error): Now static.
11838 (store_symval_forwarding): Rename local to avoid shadowing.
11839 (Fmake_variable_buffer_local, Fmake_local_variable):
11840 Mark variables as initialized.
11841 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
11843 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
11844 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11845 Rename locals to avoid shadowing.
11846 (mark_stack): Move local variables into the #ifdef region where
11848 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11849 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11851 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11852 (GC_STRING_CHARS): Remove; not used.
11853 (Fmemory_limit): Cast sbrk's returned value to char *.
11855 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11856 avoids undefined behavior in theory.
11858 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11860 Use functions, not macros, for up- and down-casing (Bug#8254).
11861 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11862 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11863 to use the following functions instead of these macros.
11864 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11865 EMACS_INT, since callers assume the returned value fits in int.
11866 (upcase1): Likewise, for UPCASE_TABLE.
11867 (uppercasep, lowercasep, upcase): New static inline functions.
11868 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
11869 the race-condition problem in the old DOWNCASE.
11871 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11872 Rename locals to avoid shadowing.
11873 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
11874 (regex_compile, re_search_2, re_match_2_internal):
11875 Remove unused local vars.
11876 (FREE_VAR): Rewrite so as not to use empty "else",
11877 which gcc can warn about.
11878 (regex_compile, re_match_2_internal): Mark locals as initialized.
11879 (RETALLOC_IF): Define only if needed.
11880 (WORDCHAR_P): Likewise. This one is never needed, but is used
11881 only in a comment talking about a compiler bug, so put inside
11882 the #if 0 of that comment.
11883 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11884 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11887 * search.c (boyer_moore): Rename locals to avoid shadowing.
11888 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11889 (PREV_CHAR_BOUNDARY): Likewise.
11891 * search.c (simple_search): Remove unused var.
11893 * dired.c (compile_pattern): Move decl from here ...
11894 * lisp.h: ... to here, so that it can be checked.
11895 (struct re_registers): New forward decl.
11897 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11899 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11901 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11902 Rename locals to avoid shadowing.
11903 (Fvertical_motion): Mark locals as initialized.
11905 * casefiddle.c (casify_object, casify_region): Now static.
11906 (casify_region): Mark local as initialized.
11908 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11910 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11911 New macros, so that the caller can use some names other than
11912 gcpro1, gcpro2, etc.
11913 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11915 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11916 argument, for consistency with GCPRO2_VAR, etc: it is now the
11917 prefix of the variable, not the variable itself. All uses
11919 * dired.c (directory_files_internal, file_name_completion):
11920 Rename locals to avoid shadowing.
11922 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11923 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11924 dired.c's scmp function, had undefined behavior.
11925 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11926 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11927 * buffer.h: ... to here, because these macros use current_buffer,
11928 and the new implementation with inline functions needs to have
11929 current_buffer in scope now, rather than later when the macros
11931 (downcase, upcase1): New static inline functions.
11932 (DOWNCASE, UPCASE1): Reimplement using these functions.
11933 This avoids undefined behavior in expressions like
11934 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11935 from race conditions in accessing the global variables
11936 case_temp1 and case_temp2.
11937 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11938 * lisp.h (case_temp1, case_temp2): Remove their decls.
11939 * character.h (ASCII_CHAR_P): Move from here ...
11940 * lisp.h: ... to here, so that the inline functions mentioned
11941 above can use them.
11943 * dired.c (directory_files_internal_unwind): Now static.
11945 * fileio.c (file_name_as_directory, directory_file_name):
11946 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11948 (file_name_as_directory): Use const pointers when appropriate.
11949 (Fexpand_file_name): Likewise. In particular, newdir might
11950 point at constant storage, so make it a const pointer.
11951 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
11952 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11954 (Fset_file_times, Finsert_file_contents, auto_save_error):
11955 Rename locals to avoid shadowing.
11957 * minibuf.c (choose_minibuf_frame_1): Now static.
11958 (Ftry_completion, Fall_completions): Rename or remove locals
11959 to avoid shadowing.
11961 * marker.c (bytepos_to_charpos): Remove; unused.
11963 * lisp.h (verify_bytepos, count_markers): New decls,
11964 so that gcc does not warn that these functions aren't declared.
11966 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11967 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
11968 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
11969 (copy_text): Remove unused local var.
11971 * filelock.c (within_one_second): Now static.
11972 (lock_file_1): Rename local to avoid shadowing.
11974 * buffer.c (fix_overlays_before): Mark locals as initialized.
11975 (fix_start_end_in_overlays): Likewise. This function should be
11976 simplified by using pointers-to-pointers, but that's a different
11978 (switch_to_buffer_1): Now static.
11979 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11980 (report_overlay_modification): Rename locals to avoid shadowing.
11982 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
11983 Fix pointer signedness issue.
11984 (sys_subshell): Mark local as volatile if checking for lint,
11985 to suppress a gcc -Wclobbered warning that does not seem to be right.
11986 (MAXPATHLEN): Define only if needed.
11988 * process.c (serial_open, serial_configure): Move decls from here ...
11989 * systty.h: ... to here, so that they can be checked.
11991 * fns.c (get_random, seed_random): Move extern decls from here ...
11992 * lisp.h: ... to here, so that they can be checked.
11994 * sysdep.c (reset_io): Now static.
11995 (wait_for_termination_signal): Remove; unused.
11997 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11998 (copy_keymap_item, append_key, push_text_char_description):
12000 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
12001 (DENSE_TABLE_SIZE): Remove; unused.
12002 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12003 (describe_map_tree):
12004 Rename locals to avoid shadowing.
12006 * keyboard.c: Declare functions static if they are not used elsewhere.
12007 (echo_char, echo_dash, cmd_error, top_level_2):
12008 (poll_for_input, handle_async_input): Now static.
12009 (read_char, kbd_buffer_get_event, make_lispy_position):
12010 (make_lispy_event, make_lispy_movement, apply_modifiers):
12011 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12012 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12013 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
12014 (read_key_sequence, read_char): Mark locals as initialized.
12015 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
12017 * keyboard.h (make_ctrl_char): New decl.
12018 (mark_kboards): Move decl here ...
12019 * alloc.c (mark_kboards): ... from here.
12021 * lisp.h (force_auto_save_soon): New decl.
12023 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
12024 (DEFINE_DUMMY_FUNCTION): New macro.
12025 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12027 (main): Add casts to avoid warnings
12028 if GCC considers string literals to be constants.
12030 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12032 * dbusbind.c: Pointer signedness fixes.
12033 (xd_signature, xd_append_arg, xd_initialize):
12034 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12035 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12036 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12037 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12039 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12040 if GCC considers string literals to be constants.
12041 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
12043 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12045 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12046 (print_preprocess, print_object): New macro to fix last change.
12048 * print.c (print_preprocess): Don't forget font objects.
12050 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
12052 * emacs.c (USAGE3): Doc fixes.
12054 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12056 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12059 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
12061 * lisp.h (VWindow_system, Qfile_name_history):
12062 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12063 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12064 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12066 * w32select.c: Don't #include "keyboard.h".
12067 (run_protected): Add extern declaration for waiting_for_input.
12069 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12070 * w32console.c (detect_input_pending, read_input_pending)
12071 (encode_terminal_code):
12072 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12073 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12074 (w32_system_caret_y, Qfile_name_history):
12075 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12076 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12077 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12078 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12079 * w32proc.c (Qlocal, report_file_error):
12080 * w32term.c (Vwindow_system, updating_frame):
12081 * w32uniscribe.c (initialized, uniscribe_font_driver):
12082 Remove unneeded extern declarations.
12084 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
12086 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
12088 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
12090 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12091 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12092 These macros can no longer be used for assignment.
12094 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12095 Assign struct members directly, instead of using BUF_BEGV etc.
12096 (record_buffer_markers, fetch_buffer_markers): New functions for
12097 recording and fetching special buffer markers.
12098 (set_buffer_internal_1, set_buffer_temp): Use them.
12100 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12102 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12104 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12105 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12107 * xdisp.c (hscroll_window_tree):
12108 (reconsider_clip_changes): Use PT instead of BUF_PT.
12110 2011-03-13 Eli Zaretskii <eliz@gnu.org>
12112 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12113 $(EMACS_ROOT)/lib/intprops.h.
12115 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12117 Fix more problems found by GCC 4.5.2's static checks.
12119 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12120 to unsigned char * to avoid compiler diagnostic.
12121 (xg_free_frame_widgets): Make it clear that a local variable is
12122 needed only if USE_GTK_TOOLTIP.
12123 (gdk_window_get_screen): Make it clear that this macro is needed
12124 only if USE_GTK_TOOLTIP.
12125 (int_gtk_range_get_value): New function, which avoids a diagnostic
12126 from gcc -Wbad-function-cast.
12127 (xg_set_toolkit_scroll_bar_thumb): Use it.
12128 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12129 diagnostic from gcc -Wbad-function-cast.
12130 (get_utf8_string, xg_get_file_with_chooser):
12131 Rename locals to avoid shadowing.
12132 (create_dialog): Move locals to avoid shadowing.
12134 * xgselect.c (xg_select): Remove unused var.
12136 * image.c (four_corners_best): Mark locals as initialized.
12137 (gif_load): Initialize transparent_p to zero (Bug#8238).
12138 Mark another local as initialized.
12139 (my_png_error, my_error_exit): Mark with NO_RETURN.
12141 * image.c (clear_image_cache): Now static.
12142 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
12143 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
12144 (x_edge_detection): Remove unnecessary cast that
12145 gcc -Wbad-function-cast diagnoses.
12146 (gif_load): Fix pointer signedness.
12147 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12148 (jpeg_load, gif_load): Rename locals to avoid shadowing.
12150 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
12152 Improve quality of tests for time stamp overflow.
12153 For example, without this patch (encode-time 0 0 0 1 1
12154 1152921504606846976) returns the obviously-bogus value (-948597
12155 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12156 reports time overflow. See
12157 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
12158 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12159 * editfns.c: Include limits.h and intprops.h.
12160 (TIME_T_MIN, TIME_T_MAX): New macros.
12161 (time_overflow): Move earlier, to before first use.
12162 (hi_time, lo_time): New functions, for an accurate test for
12163 out-of-range times.
12164 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12165 (Fget_internal_run_time): Don't assume time_t fits in int.
12166 (make_time): Use list2 instead of Fcons twice.
12167 (Fdecode_time): More accurate test for out-of-range times.
12168 (check_tm_member): New function.
12169 (Fencode_time): Use it, to test for out-of-range times.
12170 (lisp_time_argument): Don't rely on undefined left-shift and
12171 right-shift behavior when checking for time stamp overflow.
12173 * editfns.c (time_overflow): New function, refactoring common code.
12174 (Fformat_time_string, Fdecode_time, Fencode_time):
12175 (Fcurrent_time_string): Use it.
12177 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12178 * dired.c (make_time): Move to ...
12179 * editfns.c (make_time): ... here.
12180 * systime.h: Note the move.
12182 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12184 * fringe.c (update_window_fringes): Remove unused variables.
12186 * unexmacosx.c (copy_data_segment): Also copy __got section.
12189 2011-03-12 Eli Zaretskii <eliz@gnu.org>
12191 * termcap.c [MSDOS]: Include "msdos.h".
12192 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12193 Constify `char *' arguments and their references according to
12194 prototypes in tparam.h.
12196 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
12198 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12199 Adapt all references accordingly.
12201 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12203 2011-03-11 Tom Tromey <tromey@redhat.com>
12205 * buffer.c (syms_of_buffer): Remove obsolete comment.
12207 2011-03-11 Eli Zaretskii <eliz@gnu.org>
12209 * termhooks.h (encode_terminal_code): Declare prototype.
12211 * msdos.c (encode_terminal_code): Don't declare prototype.
12213 * term.c (encode_terminal_code): Now external again, used by
12214 w32console.c and msdos.c.
12216 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12217 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
12219 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
12221 Fix some minor problems found by GCC 4.5.2's static checks.
12223 * fringe.c (update_window_fringes): Mark locals as initialized
12225 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
12227 * alloc.c (mark_fringe_data): Move decl from here ...
12228 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12229 to check its interface.
12230 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12232 * fontset.c (free_realized_fontset): Now static.
12233 (Fset_fontset_font): Rename local to avoid shadowing.
12234 (fontset_font): Mark local as initialized.
12235 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
12237 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12239 * xselect.c (x_disown_buffer_selections): Remove; not used.
12240 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
12241 (x_own_selection, Fx_disown_selection_internal): Rename locals
12242 to avoid shadowing.
12243 (x_handle_dnd_message): Remove local to avoid shadowing.
12245 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12246 so that the caller can use some name other than gcpro1.
12247 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
12248 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12249 (Fx_backspace_delete_keys_p):
12250 Use them to avoid shadowing, and rename vars to avoid shadowing.
12251 (x_decode_color, x_set_name, x_window): Now static.
12252 (Fx_create_frame): Add braces to silence GCC warning.
12253 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
12254 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12255 Remove unused locals.
12256 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12257 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12258 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12261 * xterm.h (x_mouse_leave): New decl.
12263 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12264 Remove unused functions.
12265 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12266 (x_calc_absolute_position): Now static.
12267 (XTread_socket): Don't define label "out" unless it's used.
12268 Don't declare local "event" unless it's used.
12269 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12270 unless they are used.
12271 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12272 (x_fatal_error_signal): Remove; not used.
12273 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12274 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12275 (x_error_catcher, x_connection_closed, x_error_handler):
12276 (x_error_quitter, xembed_send_message, x_iconify_frame):
12277 (my_log_handler): Rename locals to avoid shadowing.
12278 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
12279 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
12281 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12282 Rename or move locals to avoid shadowing.
12283 (tty_defined_color, merge_face_heights): Now static.
12284 (free_realized_faces_for_fontset): Remove; not used.
12285 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12286 does not deduce is never used uninitialized.
12287 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12288 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
12290 * terminal.c (store_terminal_param): Now static.
12292 * xmenu.c (menu_highlight_callback): Now static.
12293 (set_frame_menubar): Remove unused local.
12294 (xmenu_show): Rename parameter to avoid shadowing.
12295 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12296 since they might point to immutable storage.
12297 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12298 since it's unused otherwise.
12300 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
12301 Add a FIXME, since the code still doesn't look right. (Bug#8215)
12302 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12303 avoids a gcc -Wuninitialized diagnostic.
12304 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
12305 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12306 does not deduce are never used uninitialized.
12308 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12310 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
12311 * window.c (window_loop, size_window):
12312 (run_window_configuration_change_hook, enlarge_window): Likewise.
12314 * window.c (display_buffer): Now static.
12315 (size_window): Mark variables that gcc -Wuninitialized
12316 does not deduce are never used uninitialized.
12317 * window.h (check_all_windows): New decl, to forestall
12318 gcc -Wmissing-prototypes diagnostic.
12319 * dispextern.h (bidi_dump_cached_states): Likewise.
12321 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12323 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
12324 Include <limits.h>.
12325 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12326 and to avoid gcc -Wuninitialized warning.
12327 (load_charset_map): Mark variables that gcc -Wuninitialized
12328 does not deduce are never used uninitialized.
12329 (load_charset): Abort instead of using uninitialized var (Bug#8229).
12331 * coding.c (coding_set_source, coding_set_destination):
12332 Use "else { /* comment */ }" rather than "else /* comment */;"
12333 for clarity, and to avoid gcc -Wempty-body warning.
12334 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12335 a block, when the outer 'i' will do.
12336 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12337 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12338 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12339 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12340 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12341 Rename locals to avoid shadowing.
12342 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
12343 * coding.c (emacs_mule_char, encode_invocation_designation):
12344 Now static, since they're not used elsewhere.
12345 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
12346 (decode_coding_object, encode_coding_object, detect_coding_system):
12347 (decode_coding_emacs_mule): Mark variables that gcc
12348 -Wuninitialized does not deduce are never used uninitialized.
12349 (detect_coding_iso_2022): Initialize a local variable that might
12350 be used uninitialized. Leave a FIXME because it's not clear that
12351 this initialization is needed. (Bug#8211)
12352 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12353 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12354 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12355 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12356 Remove unused macros.
12358 * category.c (hash_get_category_set): Remove unused local var.
12359 (copy_category_table): Now static, since it's not used elsewhere.
12360 * character.c (string_count_byte8): Likewise.
12362 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12363 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12365 * chartab.c (copy_sub_char_table): Now static, since it's not used
12367 (sub_char_table_ref_and_range, char_table_ref_and_range):
12368 Rename locals to avoid shadowing.
12369 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
12371 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
12372 (BIDI_BOB): Remove unused macro.
12374 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12375 deduce are never used uninitialized.
12376 * term.c (encode_terminal_code): Likewise.
12378 * term.c (encode_terminal_code): Now static. Remove unused local.
12380 * tparam.h: New file.
12381 * term.c, tparam.h: Include it.
12382 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12383 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12384 Move these decls to tparam.h, and make them agree with what
12385 is actually in tparam.c. The previous trick of using incompatible
12386 decls in different modules does not conform to the C standard.
12387 All callers of tparam changed to use tparam's actual API.
12388 * tparam.c (tparam1, tparam, tgoto):
12389 Use const pointers where appropriate.
12391 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12392 * cm.h (struct cm): Likewise.
12393 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12394 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12395 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12396 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12397 (turn_on_face, init_tty): Likewise.
12398 * termchar.h (struct tty_display_info): Likewise.
12400 * term.c (term_mouse_position): Rename local to avoid shadowing.
12402 * alloc.c (mark_ttys): Move decl from here ...
12403 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12405 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12407 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12409 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
12411 * search.c (compile_pattern_1): Remove argument regp, unused since
12412 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12413 (compile_pattern): Don't pass it.
12415 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12417 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12418 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12420 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12422 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12424 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12425 gdk_window_get_screen, gdk_window_get_geometry,
12426 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12427 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12428 (xg_get_pixbuf_from_pixmap): New function.
12429 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12430 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12431 Call xg_get_pixbuf_from_pixmap instead of
12432 gdk_pixbuf_get_from_drawable.
12433 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12434 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12435 (xg_check_special_colors): Use GtkStyleContext and its functions
12437 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12438 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12439 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
12440 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12441 Call gtk_widget_get_preferred_size.
12442 (xg_frame_resized): gdk_window_get_geometry only takes 5
12444 (xg_win_to_widget, xg_event_is_for_menubar):
12445 Call gdk_x11_window_lookup_for_display.
12446 (xg_set_widget_bg): New function.
12447 (delete_cb): New function.
12448 (xg_create_frame_widgets): Connect delete-event to delete_cb.
12449 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
12450 (xg_set_background_color): Call xg_set_widget_bg.
12451 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12452 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12453 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12454 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12456 (update_frame_tool_bar): Call gtk_widget_hide.
12457 (xg_initialize): Use GDK_KEY_g.
12459 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12461 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12463 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12464 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12465 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12467 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
12469 * w32xfns.c (select_palette): Check success of RealizePalette against
12470 GDI_ERROR, not zero.
12472 See ChangeLog.11 for earlier changes.
12474 ;; Local Variables:
12478 Copyright (C) 2011-2012 Free Software Foundation, Inc.
12480 This file is part of GNU Emacs.
12482 GNU Emacs is free software: you can redistribute it and/or modify
12483 it under the terms of the GNU General Public License as published by
12484 the Free Software Foundation, either version 3 of the License, or
12485 (at your option) any later version.
12487 GNU Emacs is distributed in the hope that it will be useful,
12488 but WITHOUT ANY WARRANTY; without even the implied warranty of
12489 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12490 GNU General Public License for more details.
12492 You should have received a copy of the GNU General Public License
12493 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.