1 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3 * xfns.c: Make symbols static if they're not exported.
4 (x_last_font_name, x_display_info_for_name):
5 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10 (last_show_tip_args): Now static.
11 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
13 (x_screen_planes): Remove; unused.
14 * dispextern.h (x_screen_planes): Remove decl.
16 * dispnew.c: Make symbols static if they're not exported.
17 * dispextern.h (redraw_garbaged_frames, scrolling):
18 (increment_row_positions): Remove.
19 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
20 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
22 (redraw_garbaged_frames): Remove; unused.
24 * xfaces.c: Make symbols static if they're not exported.
25 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
27 * xterm.h (defined_color): Remove decls.
28 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
29 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
30 (menu_face_changed_default, defined_color, free_realized_face):
31 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
32 (ascii_face_of_lisp_face): Remove; unused.
34 * xdisp.c: Make symbols static if they're not exported.
35 * dispextern.h (scratch_glyph_row, window_box_edges):
36 (glyph_to_pixel_coords, set_cursor_from_row):
37 (get_next_display_element, set_iterator_to_next):
38 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
39 (show_mouse_face): Remove decls
40 * frame.h (message_buf_print): Likewise.
41 * lisp.h (pop_message, set_message, check_point_in_composition):
43 * xterm.h (set_vertical_scroll_bar): Likewise.
44 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
45 (message_buf_print, scratch_glyph_row, displayed_buffer):
46 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
47 (get_next_display_element, show_mouse_face, window_box_edges):
48 (frame_to_window_pixel_xy, check_point_in_composition):
49 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
50 (glyph_to_pixel_coords): Remove; unused.
52 * dired.c (file_name_completion): Now static.
54 * dbusbind.c (xd_in_read_queued_messages): Now static.
56 * lisp.h (circular_list_error, FOREACH): Remove; unused.
57 * data.c (circular_list_error): Remove.
59 2011-04-11 Paul Eggert <eggert@cs.ucla.edu>
61 * commands.h (last_point_position, last_point_position_buffer):
62 (last_point_position_window): Remove decls.
63 * keyboard.c: Make these variables static.
65 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
67 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
68 (iso_code_class, detect_coding, code_convert_region): Now static.
69 (encode_coding_gap): Remove; unused.
71 * chartab.c (chartab_chars, chartab_bits): Now static.
73 * charset.h (charset_iso_8859_1): Remove decl.
74 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
77 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
78 * ccl.c (Vccl_program_table): Now static.
79 (check_ccl_update): Remove; unused.
81 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
82 * category.h: ... from here.
83 * category.c (check_category_table, set_category_set): Now static.
85 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
86 * lisp.h: Remove these decls.
88 * buffer.c (buffer_count): Remove unused var.
90 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
91 so that it's not optimized away.
92 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
93 * dispextern.h (bidi_dump_cached_states): Remove, since it's
94 exported only to the debugger.
96 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
97 * atimer.h (run_all_atimers): Removed; not exported.
99 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
100 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
101 was inaccessible from Lisp.
102 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
103 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
105 alloc.c: Import and export fewer symbols, and remove unused items.
106 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
108 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
109 it's not optimized away by whole-program optimization.
110 (message_enable_multibyte, free_misc): Remove.
111 (catchlist, handlerlist, mark_backtrace):
112 Declare only if BYTE_MARK_STACK.
113 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
114 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
115 (message_enable_multibyte): Remove decl.
116 (free_misc, interval_free_list, float_block, float_block_index):
117 (n_float_blocks, float_free_list, cons_block, cons_block_index):
118 (cons_free_list, last_marked_index):
120 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
121 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
122 (mark_backtrace): Define only if BYTE_MARK_STACK.
123 * xdisp.c (message_enable_multibyte): Now static.
125 Declare Lisp_Object Q* variables to be 'static' if not exproted.
126 This makes it easier for human readers (and static analyzers)
127 to see whether these variables are used from other modules.
128 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
129 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
130 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
131 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
132 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
133 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
134 * xmenu.c, xselect.c:
135 Declare Q* vars static if they are not used in other modules.
136 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
137 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
138 Remove decls of unexported vars.
139 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
141 * lisp.h (DEFINE_FUNC): Make sname 'static'.
143 Make Emacs functions such as Fatom 'static' by default.
144 This makes it easier for human readers (and static analyzers)
145 to see whether these functions can be called from other modules.
146 DEFUN now defines a static function. To make the function external
147 so that it can be used in other C modules, use the new macro DEFUE.
148 * lisp.h (DEFINE_FUNC): New macro, with the old contents of DEFUN.
149 (DEFUN): Rewrite in terms of DEFINE_FUNC. It now generates a
150 static function definition. Use DEFUE if you want an extern one.
151 (DEFUE, INFUN): New macros.
152 (Funibyte_char_to_multibyte, Fsyntax_table_p, Finit_image_library):
153 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
154 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
155 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
156 Remove decls, since these functions are now static.
157 (Funintern, Fget_internal_run_time): New decls, since these functions
158 were already external.
160 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
161 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
162 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
163 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
164 * keyboard.c, keymap.c, lread.c:
165 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
166 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
167 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
168 Mark functions with DEFUE instead of DEFUN,
169 if they are used in other modules.
170 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
171 decls for now-static functions.
172 * buffer.h (Fdelete_overlay): Remove decl.
173 * callproc.c (Fgetenv_internal): Mark as internal.
174 * composite.c (Fremove_list_of_text_properties): Remove decl.
175 (Fcomposition_get_gstring): New forward static decl.
176 * composite.h (Fcomposite_get_gstring): Remove decl.
177 * dired.c (Ffile_attributes): New forward static decl.
178 * doc.c (Fdocumntation_property): New forward static decl.
179 * eval.c (Ffetch_bytecode): New forward static decl.
180 (Funintern): Remove extern decl; now in .h file where it belongs.
181 * fileio.c (Fmake_symbolic_link): New forward static decl.
182 * image.c (Finit_image_library): New forward static decl.
183 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
184 * intervals.h (Fprevious_property_change):
185 (Fremove_list_of_text_properties): Remove decls.
186 * keyboard.c (Fthis_command_keys): Remove decl.
187 (Fcommand_execute): New forward static decl.
188 * keymap.c (Flookup_key): New forward static decl.
189 (Fcopy_keymap): Now static.
190 * keymap.h (Flookup_key): Remove decl.
191 * process.c (Fget_process): New forward static decl.
192 (Fprocess_datagram_address): Mark as internal.
193 * syntax.c (Fsyntax_table_p): New forward static decl.
194 (skip_chars): Remove duplicate decl.
195 * textprop.c (Fprevious_property_change): New forward static decl.
196 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
198 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
199 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
201 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
203 * editfns.c (Fformat): Remove unreachable code.
205 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
207 Fix more problems found by GCC 4.6.0's static checks.
209 * xdisp.c (vmessage): Use a better test for character truncation.
211 * charset.c (load_charset_map): <, not <=, for optimization,
212 and to avoid potential problems with integer overflow.
213 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
214 * casetab.c (set_identity, shuffle): Likewise.
215 * editfns.c (Fformat): Likewise.
216 * syntax.c (skip_chars): Likewise.
218 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
219 This also lets GCC 4.6.0 generate slightly better loop code.
221 * callint.c (Fcall_interactively): <, not <=, for optimization.
222 (Fcall_interactively): Count the number of arguments produced,
223 not the number of arguments given. This is simpler and lets GCC
224 4.6.0 generate slightly better code.
226 * ftfont.c: Distingish more carefully between FcChar8 and char.
227 The previous code passed unsigned char * to a functions like
228 strlen and xstrcasecmp that expect char *, which does not
229 conform to the C standard.
230 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
231 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
232 char * when the C standard requires it.
234 * keyboard.c (read_char): Remove unused var.
236 * eval.c: Port to Windows vsnprintf (Bug#8435).
238 (SIZE_MAX): Define if the headers do not.
239 (verror): Do not give up if vsnprintf returns a negative count.
240 Instead, grow the buffer. This ports to Windows vsnprintf, which
241 does not conform to C99. Problem reported by Eli Zaretskii.
242 Also, simplify the allocation scheme, by avoiding the need for
243 calling realloc, and removing the ALLOCATED variable.
245 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
247 Remove invocations of doprnt, as Emacs now uses vsnprintf.
248 But keep the doprint source code for now, as we might revamp it
249 and use it again (Bug#8435).
250 * lisp.h (doprnt): Remove.
251 * Makefile.in (base_obj): Remove doprnt.o.
252 * deps.mk (doprnt.o): Remove.
254 error: Print 32- and 64-bit integers portably (Bug#8435).
255 Without this change, on typical 64-bit hosts error ("...%d...", N)
256 was used to print both 32- and 64-bit integers N, which relied on
258 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
260 * lisp.h (error, verror): Mark as printf-like functions.
261 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
262 Report overflow in size calculations when allocating printf buffer.
263 Do not truncate output string at its first null byte.
264 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
265 Truncate the output at a character boundary, since vsnprintf does not
267 * charset.c (check_iso_charset_parameter): Convert internal
268 character to string before calling 'error', since %c now has the
270 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
271 overflow when computing char to be passed to 'error'. Do not
272 pass Lisp_Object to 'error'; pass the integer instead.
273 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
274 formatted with plain %d.
276 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
278 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
280 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
282 * xterm.c (x_catch_errors): Remove duplicate declaration.
284 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
286 * xdisp.c, lisp.h (message_nolog): Remove; unused.
288 2011-04-10 Jim Meyering <meyering@redhat.com>
290 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
291 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
292 return ssize_t not "int", and use size_t as the buffer length.
293 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
294 * gnutls.h: Update declarations.
295 * process.c (read_process_output): Use ssize_t, to match.
296 (send_process): Likewise.
298 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
300 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
302 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
304 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
305 unsigned char, to match FcChar8 type definition.
307 * xterm.c (handle_one_xevent):
308 * xmenu.c (create_and_show_popup_menu):
309 * xselect.c (x_decline_selection_request)
310 (x_reply_selection_request): Avoid type-punned deref of X events.
312 2011-04-09 Eli Zaretskii <eliz@emacstest.gnu.org>
314 Fix some uses of `int' instead of EMACS_INT.
315 * search.c (string_match_1, fast_string_match)
316 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
317 (scan_buffer, find_next_newline_no_quit)
318 (find_before_next_newline, search_command, Freplace_match)
319 (Fmatch_data): Make some `int' variables be EMACS_INT.
321 * xdisp.c (display_count_lines): 3rd argument and return value now
322 EMACS_INT. All callers changed.
323 (pint2hrstr): Last argument is now EMACS_INT.
325 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
326 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
327 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
328 (decode_coding_utf_16, decode_coding_emacs_mule)
329 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
330 (decode_coding_ccl, decode_coding_charset)
331 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
332 (decode_coding_iso_2022, decode_coding_emacs_mule)
333 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
334 <char_offset, last_offset>: Declare EMACS_INT.
335 (encode_coding_utf_8, encode_coding_utf_16)
336 (encode_coding_emacs_mule, encode_invocation_designation)
337 (encode_designation_at_bol, encode_coding_iso_2022)
338 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
339 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
341 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
342 (encode_invocation_designation): Last argument P_NCHARS is now
344 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
345 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
347 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
350 * ccl.c (Fccl_execute_on_string): Declare some variables
353 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
355 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
357 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
359 * process.c (Fformat_network_address): Doc fix.
361 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
363 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
365 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
367 * keyboard.c (read_char): Call Lisp function help-form-show,
368 instead of using internal_with_output_to_temp_buffer.
369 (Qhelp_form_show): New var.
370 (syms_of_keyboard): Use DEFSYM macro.
372 * print.c (internal_with_output_to_temp_buffer): Function deleted.
374 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
376 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
378 * process.c (Flist_processes): Removed to Lisp.
379 (list_processes_1): Deleted.
381 2011-04-06 Eli Zaretskii <eliz@gnu.org>
383 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
385 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
387 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
389 Fix more problems found by GCC 4.6.0's static checks.
391 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
393 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
395 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
397 * xdisp.c (vmessage): Mark as a printf-like function.
399 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
401 * sound.c (sound_warning): Don't crash if arg contains a printf format.
403 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
404 printf-like functions.
405 (tiff_load): Add casts to remove these marks before passing them
406 to system-supplied API.
408 * eval.c (Fsignal): Remove excess argument to 'fatal'.
410 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
411 This avoids several warnings with gcc -Wstrict-overflow.
412 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
413 directly, rather than having caller test rule sign. This avoids
414 some unnecessary tests.
415 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
416 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
417 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
419 * xfont.c (xfont_text_extents): Remove var that was set but not used.
420 (xfont_open): Avoid unnecessary tests.
422 * composite.c (composition_gstring_put_cache): Use unsigned integer.
424 * composite.h, composite.c (composition_gstring_put_cache):
425 Use EMACS_INT, not int, for length.
427 * composite.h (COMPOSITION_DECODE_REFS): New macro,
428 breaking out part of COMPOSITION_DECODE_RULE.
429 (COMPOSITION_DECODE_RULE): Use it.
430 * composite.c (get_composition_id): Remove unused local vars,
431 by using the new macro.
433 * textprop.c (set_text_properties_1): Change while to do-while,
434 since the condition is always true at first.
436 * intervals.c (graft_intervals_into_buffer): Mark var as used.
437 (interval_deletion_adjustment): Return unsigned value.
440 * process.c (list_processes_1, create_pty, read_process_output):
441 (exec_sentinel): Remove vars that were set but not used.
442 (create_pty): Remove unnecessary "volatile"s.
443 (Fnetwork_interface_info): Avoid possibility of int overflow.
444 (read_process_output): Do adaptive read buffering even if carryover.
445 (read_process_output): Simplify nbytes computation if buffered.
447 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
449 * syntax.c (scan_words): Remove var that was set but not used.
450 (update_syntax_table): Use unsigned instead of int.
452 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
453 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
454 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
456 * print.c (print_error_message): Avoid int overflow.
458 * font.c (font_list_entities): Redo for clarity,
459 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
461 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
462 (font_score): Avoid potential overflow in diff calculation.
464 * fns.c (substring_both): Remove var that is set but not used.
465 (sxhash): Redo loop for clarity and to avoid wraparound warning.
467 * eval.c (funcall_lambda): Rename local to avoid shadowing.
469 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
470 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
471 can always succeed if overflow has undefined behavior.
473 * search.c (boyer_moore, wordify): Remove vars set but not used.
474 (wordify): Omit three unnecessary tests.
476 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
477 All callers changed. This avoids the need for an unused var.
479 * casefiddle.c (casify_region): Remove var that is set but not used.
481 * dired.c (file_name_completion): Remove var that is set but not used.
483 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
485 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
486 (Finsert_file_contents): Remove unnecessary code checking fd.
488 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
489 Check for integer overflow on size calculations.
491 * buffer.c (Fprevious_overlay_change): Remove var that is set
494 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
495 Remove vars that are set but not used.
496 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
497 (timer_check_2): Mark vars as initialized.
499 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
501 * image.c (lookup_image): Remove var that is set but not used.
502 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
504 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
505 that are set but not used.
507 * xfns.c (make_invisible_cursor): Don't return garbage
508 if XCreateBitmapFromData fails (Bug#8410).
510 * xselect.c (x_get_local_selection, x_handle_property_notify):
511 Remove vars that are set but not used.
513 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
514 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
516 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
517 Remove var that is set but not used.
518 (scroll_bar_windows_size): Now size_t, not int.
519 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
522 * xfaces.c (realize_named_face): Remove vars that are set but not used.
523 (map_tty_color) [!defined MSDOS]: Likewise.
525 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
527 * coding.c: Remove vars that are set but not used.
528 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
530 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
531 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
532 (decode_coding_charset): Remove vars that are set but not used.
534 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
535 that is set but not used.
537 * print.c (print_object): Remove var that is set but not used.
539 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
540 The gnulib version avoids calling malloc in the usual case,
541 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
542 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
543 * filelock.c (current_lock_owner): Likewise.
544 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
545 * sysdep.c: Include allocator.h, careadlinkat.h.
546 (emacs_no_realloc_allocator): New static constant.
547 (emacs_readlink): New function.
548 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
549 ../lib/careadlinkat.h.
551 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
553 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
554 first non-nil return value).
556 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
558 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
559 if not defined (Bug#8403).
561 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
563 * xdisp.c (display_count_lines): Remove parameter `start',
564 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
565 (get_char_face_and_encoding): Remove parameter `multibyte_p',
566 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
567 (fill_stretch_glyph_string): Remove parameters `row' and `area',
568 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
569 and thereabouts. All callers changed.
570 (get_per_char_metric): Remove parameter `f', unused since
571 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
573 2011-04-02 Jim Meyering <meyering@redhat.com>
575 do not dereference NULL upon failed strdup
576 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
577 (ns_get_family): Likewise.
579 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
581 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
583 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
585 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
588 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
592 * window.c (Ftemp_output_buffer_show): New fun.
593 (Fsave_window_excursion):
594 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
596 * lread.c (lisp_file_lexically_bound_p): New function.
597 (Fload): Bind Qlexical_binding.
598 (readevalloop): Remove `evalfun' arg.
599 Bind Qinternal_interpreter_environment.
600 (Feval_buffer): Bind Qlexical_binding.
601 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
603 (syms_of_lread): Declare `lexical-binding'.
605 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
607 * keyboard.c (eval_dyn): New fun.
608 (menu_item_eval_property): Use it.
610 * image.c (parse_image_spec): Use Ffunctionp.
612 * fns.c (concat, mapcar1): Accept byte-code-functions.
614 * eval.c (Fsetq): Handle lexical vars.
615 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
616 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
617 (FletX, Flet): Obey lexical binding.
618 (Fcommandp): Handle closures.
619 (Feval): New `lexical' arg.
620 (eval_sub): New function extracted from Feval. Use it almost
621 everywhere where Feval was used. Look up vars in lexical env.
623 (Ffunctionp): Move from subr.el.
624 (Ffuncall): Handle closures.
625 (apply_lambda): Remove `eval_flags'.
626 (funcall_lambda): Handle closures and new byte-code-functions.
627 (Fspecial_variable_p): New function.
628 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
629 but without exporting it to Lisp.
631 * doc.c (Fdocumentation, store_function_docstring):
632 * data.c (Finteractive_form): Handle closures.
634 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
637 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
639 (exec_byte_code): New function extracted from Fbyte_code to handle new
640 calling convention for byte-code-functions. Add new byte-codes.
642 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
644 * alloc.c (Fmake_symbol): Init new `declared_special' field.
646 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
648 * xdisp.c (redisplay_internal): Fix prototype.
650 2011-03-31 Eli Zaretskii <eliz@gnu.org>
652 * xdisp.c (SCROLL_LIMIT): New macro.
653 (try_scrolling): Use it when setting scroll_limit. Limit
654 scrolling to 100 screen lines.
655 (redisplay_window): Even when falling back on "recentering",
656 position point in the window according to scroll-conservatively,
657 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
659 (try_scrolling): When point is above the window, allow searching
660 as far as scroll_max, or one screenful, to compute vertical
661 distance from PT to the scroll margin position. This prevents
662 try_scrolling from unnecessarily failing when
663 scroll-conservatively is set to a value slightly larger than the
664 window height. Clean up the case of PT below the margin at bottom
665 of window: scroll_max can no longer be INT_MAX. When aggressive
666 scrolling is in use, don't let point enter the opposite scroll
667 margin as result of the scroll.
668 (syms_of_xdisp) <scroll-conservatively>: Document the
669 threshold of 100 lines for never-recentering scrolling.
671 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
673 * dispextern.h (move_it_by_lines):
674 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
675 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
676 (message_log_check_duplicate): Remove parameters `prev_bol' and
677 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
678 (redisplay_internal): Remove parameter `preserve_echo_area',
679 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
681 * indent.c (Fvertical_motion):
682 * window.c (window_scroll_pixel_based, Frecenter):
683 Don't pass `need_y_p' to `move_it_by_lines'.
685 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
687 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
688 steal a few bits to be more compact.
689 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
690 Remove unneeded casts.
692 * bytecode.c (Fbyte_code): CAR and CDR can GC.
694 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
696 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
697 binding" message (bug#7967).
699 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
701 Fix more problems found by GCC 4.6.0's static checks.
703 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
704 Remove unused local var.
706 * editfns.c (Fmessage_box): Remove unused local var.
708 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
709 (note_mode_line_or_margin_highlight, note_mouse_highlight):
710 Omit unused local vars.
711 * window.c (shrink_windows): Omit unused local var.
712 * menu.c (digest_single_submenu): Omit unused local var.
713 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
714 Omit unused local var.
716 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
717 Don't assume string length fits in int.
718 (keyremap_step, read_key_sequence): Use size_t for sizes.
719 (read_key_sequence): Don't check last_real_key_start redundantly.
721 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
722 instead of alloca (Bug#8344).
724 * eval.c (Fbacktrace): Don't assume nargs fits in int.
725 (Fbacktrace_frame): Don't assume nframes fits in int.
727 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
729 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
732 * term.c (produce_glyphless_glyph): Remove unnecessary test.
734 * cm.c (calccost): Turn while-do into do-while, for clarity.
736 * keyboard.c (syms_of_keyboard): Use the same style as later
737 in this function when indexing through an array. This also
738 works around GCC bug 48267.
740 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
742 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
744 * chartab.c (sub_char_table_ref_and_range): Redo for slight
745 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
747 * keyboard.c, keyboard.h (num_input_events): Now size_t.
748 This avoids undefined behavior on integer overflow, and is a bit
749 more convenient anyway since it is compared to a size_t variable.
751 Variadic C functions now count arguments with size_t, not int.
752 This avoids an unnecessary limitation on 64-bit machines, which
753 caused (substring ...) to crash on large vectors (Bug#8344).
754 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
755 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
756 All variadic functions and their callers changed accordingly.
757 (struct gcpro.nvars): Now size_t, not int. All uses changed.
758 * data.c (arith_driver, float_arith_driver): Likewise.
759 * editfns.c (general_insert_function): Likewise.
760 * eval.c (struct backtrace.nargs, interactive_p)
761 (internal_condition_case_n, run_hook_with_args, apply_lambda)
762 (funcall_lambda, mark_backtrace): Likewise.
763 * fns.c (concat): Likewise.
764 * frame.c (x_set_frame_parameters): Likewise.
765 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
766 0 if not found, not -1. All callers changed.
768 * alloc.c (garbage_collect): Don't assume stack size fits in int.
769 (stack_copy_size): Now size_t, not int.
770 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
772 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
774 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
775 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
778 * lisp.h (multibyte_char_to_unibyte):
779 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
780 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
781 * character.h (CHAR_TO_BYTE8):
782 * cmds.c (internal_self_insert):
783 * editfns.c (general_insert_function):
784 * keymap.c (push_key_description):
785 * search.c (Freplace_match):
786 * xdisp.c (message_dolog, set_message_1): All callers changed.
788 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
790 * keyboard.c (safe_run_hook_funcall): New function.
791 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
792 don't set the hook to nil, but remove the offending function instead.
793 (Qcommand_hook_internal): Remove, unused.
794 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
795 Vcommand_hook_internal.
797 * eval.c (enum run_hooks_condition): Remove.
798 (funcall_nil, funcall_not): New functions.
799 (run_hook_with_args): Call each function through a `funcall' argument.
800 Remove `cond' argument, now redundant.
801 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
802 (Frun_hook_with_args_until_failure): Adjust accordingly.
803 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
805 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
807 * dispextern.h (string_buffer_position): Remove declaration.
809 * print.c (strout): Remove parameter `multibyte', unused since
810 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
812 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
813 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
816 * w32.c (_wsa_errlist): Use braces for struct initializers.
818 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
819 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
821 (string_buffer_position): Likewise. Also, make static (it's never
822 used outside xdisp.c).
823 (cursor_row_p): Remove parameter `w', unused since
824 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
825 (decode_mode_spec): Remove parameter `precision', introduced during
826 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
829 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
831 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
833 2011-03-27 Anders Lindgren <andlind@gmail.com>
835 * nsterm.m (ns_menu_bar_is_hidden): New variable.
836 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
837 (ns_update_auto_hide_menu_bar): New functions.
838 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
839 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
840 ns_constrain_all_frames.
841 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
842 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
844 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
846 * nsmenu.m (runDialogAt): Remove argument to timer_check.
848 2011-03-27 Glenn Morris <rgm@gnu.org>
850 * syssignal.h: Replace RETSIGTYPE with void.
851 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
852 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
853 Replace SIGTYPE with void everywhere.
854 * s/usg5-4-common.h (SIGTYPE): Remove definition.
855 * s/template.h (SIGTYPE): Remove commented out definition.
857 2011-03-26 Eli Zaretskii <eliz@gnu.org>
859 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
860 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
862 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
864 * w32.c (read_unc_volume): Use parameter `henum', instead of
865 global variable `wget_enum_handle'.
867 * keymap.c (describe_vector): Remove parameters `indices' and
868 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
869 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
871 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
873 * keyboard.c (timer_check): Remove parameter `do_it_now',
874 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
875 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
876 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
878 * keyboard.c (read_char):
879 * w32menu.c (w32_menu_display_help):
880 * xmenu.c (show_help_event, menu_help_callback):
881 Adjust calls to `show_help_echo'.
883 * gtkutil.c (xg_maybe_add_timer):
884 * keyboard.c (readable_events):
885 * process.c (wait_reading_process_output):
886 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
888 * insdel.c (adjust_markers_gap_motion):
889 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
890 (gap_left, gap_right): Don't call it.
892 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
894 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
895 incurred during fontification.
897 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
899 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
900 (DEFVAR_PER_BUFFER): Don't pass it.
902 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
903 (scrolling_window): Don't pass it.
905 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
907 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
909 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
911 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
912 of variables specific to SELinux and computation of `encoded_absname'.
914 * image.c (XPutPixel): Remove unused variable `height'.
916 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
918 * unexw32.c (get_section_info): Remove unused variable `section'.
920 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
921 (system_process_attributes): Remove unused variable `sess'.
922 (sys_read): Remove unused variable `err'.
924 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
925 (w32_wnd_proc): Remove unused variable `isdead'.
926 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
927 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
928 (x_create_tip_frame): Remove unused variable `tem'.
930 * w32inevt.c (w32_console_read_socket):
931 Remove unused variable `no_events'.
933 * w32term.c (x_draw_composite_glyph_string_foreground):
934 Remove unused variable `width'.
936 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
938 * w32term.c (x_set_glyph_string_clipping):
939 Don't pass uninitialized region to CombineRgn.
941 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
943 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
944 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
945 (Fx_close_connection): Remove unused variable `i'.
947 * w32font.c (w32font_draw): Return number of glyphs.
948 (w32font_open_internal): Remove unused variable `i'.
949 (w32font_driver): Add missing initializer.
951 * w32menu.c (utf8to16): Remove unused variable `utf16'.
952 (fill_in_menu): Remove unused variable `items_added'.
954 * w32term.c (last_mouse_press_frame): Remove static global variable.
955 (w32_clip_to_row): Remove unused variable `f'.
956 (x_delete_terminal): Remove unused variable `i'.
958 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
959 (NOTHING): Remove unused static global variable.
960 (uniscribe_check_otf): Remove unused variable `table'.
961 (uniscribe_font_driver): Add missing initializers.
963 2011-03-23 Julien Danjou <julien@danjou.info>
965 * term.c (Fsuspend_tty, Fresume_tty):
966 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
967 * window.c (temp_output_buffer_show):
968 * insdel.c (signal_before_change):
969 * frame.c (Fhandle_switch_frame):
970 * fileio.c (Fdo_auto_save):
971 * emacs.c (Fkill_emacs):
972 * editfns.c (save_excursion_restore):
973 * cmds.c (internal_self_insert):
974 * callint.c (Fcall_interactively):
975 * buffer.c (Fkill_all_local_variables):
976 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
978 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
979 unconditionnaly since it does the check itself.
981 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
983 Fix more problems found by GCC 4.5.2's static checks.
985 * coding.c (encode_coding_raw_text): Avoid unnecessary test
986 the first time through the loop, since we know p0 < p1 then.
987 This also avoids a gcc -Wstrict-overflow warning.
989 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
990 leading to a memory leak, possible in functions like
991 load_charset_map_from_file that can allocate an unbounded number
992 of objects (Bug#8318).
994 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
995 that could (at least in theory) be that large.
997 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
998 This is less likely to overflow, and avoids undefined behavior if
999 overflow does occur. All callers changed. Use strtoul to scan
1000 for the unsigned long integer.
1001 (pint2hrstr): Simplify and tune code slightly.
1002 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
1004 * scroll.c (do_scrolling): Work around GCC bug 48228.
1005 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1007 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1008 This also avoids a warning with gcc -Wstrict-overflow.
1009 (validate_x_resource_name): Simplify count usage.
1010 This also avoids a warning with gcc -Wstrict-overflow.
1012 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1015 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
1017 * process.c (Fmake_network_process): Use socklen_t, not int,
1018 where POSIX says socklen_t is required in portable programs.
1019 This fixes a porting bug on hosts like 64-bit HP-UX, where
1020 socklen_t is wider than int (Bug#8277).
1021 (Fmake_network_process, server_accept_connection):
1022 (wait_reading_process_output, read_process_output):
1025 * process.c: Rename or move locals to avoid shadowing.
1026 (list_processes_1, Fmake_network_process):
1027 (read_process_output_error_handler, exec_sentinel_error_handler):
1028 Rename or move locals.
1029 (Fmake_network_process): Define label "retry_connect" only if needed.
1030 (Fnetwork_interface_info): Fix pointer signedness.
1031 (process_send_signal): Add cast to avoid pointer signedness problem.
1032 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
1033 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
1035 Make tparam.h and terminfo.c consistent.
1036 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1037 Include tparam.h instead, since it declares them.
1038 * cm.h (PC): Remove extern decl; tparam.h now does this.
1039 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1040 * terminfo.c: Include tparam.h, to check interfaces.
1041 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1042 (tparam): Adjust signature to match interface in tparam.h;
1043 this removes some undefined behavior. Check that outstring and len
1044 are zero, which they always are with Emacs.
1045 * tparam.h (PC, BC, UP): New extern decls.
1047 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
1048 (xftfont_open): Rename locals to avoid shadowing.
1050 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
1051 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1052 (OTF_TAG_SYM): Omit macro if not needed.
1053 (ftfont_list): Remove unused local.
1054 (get_adstyle_property, ftfont_pattern_entity):
1055 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1056 Rename locals to avoid shadowing.
1058 * xfont.c (xfont_list_family): Mark var as initialized.
1060 * xml.c (make_dom): Now static.
1062 * composite.c (composition_compute_stop_pos): Rename local to
1064 (composition_reseat_it): Remove unused locals.
1065 (find_automatic_composition, composition_adjust_point): Likewise.
1066 (composition_update_it): Mark var as initialized.
1067 (find_automatic_composition): Mark vars as initialized,
1068 with a FIXME (Bug#8290).
1070 character.h: Rename locals to avoid shadowing.
1071 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1072 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1073 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1074 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1077 * textprop.c (property_change_between_p): Remove; unused.
1079 * intervals.c (interval_start_pos): Now static.
1081 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1083 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1084 Rename locals to avoid shadowing.
1086 * sound.c (wav_play, au_play, Fplay_sound_internal):
1087 Fix pointer signedness.
1088 (alsa_choose_format): Remove unused local var.
1089 (wav_play): Initialize a variable to 0, to prevent undefined
1090 behavior (Bug#8278).
1092 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1094 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1096 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1097 clobbering (Bug#8298).
1098 * sysdep.c (sys_subshell): Likewise.
1099 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
1101 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1102 This should get cleaned up, so that child_setup has the
1103 same signature on all platforms.
1105 * callproc.c (call_process_cleanup): Now static.
1106 (relocate_fd): Rename locals to avoid shadowing.
1108 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
1110 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1111 not to be necessary, and produces flickering.
1113 2011-03-20 Glenn Morris <rgm@gnu.org>
1115 * config.in: Remove file.
1117 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
1119 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1120 are now in src/globals.h.
1121 (syms_of_minibuf): Remove spurious & from previous change.
1123 2011-03-20 Leo <sdl.web@gmail.com>
1125 * minibuf.c (completing-read-function): New variable.
1126 (completing-read-default): Rename from completing-read.
1127 (completing-read): Call completing-read-function.
1129 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
1131 * xfaces.c (Fx_load_color_file):
1132 Read color file from absolute filename (bug#8250).
1134 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
1136 * makefile.w32-in: Update dependencies.
1138 2011-03-17 Eli Zaretskii <eliz@gnu.org>
1140 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1142 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1144 Fix more problems found by GCC 4.5.2's static checks.
1146 * process.c (make_serial_process_unwind, send_process_trap):
1147 (sigchld_handler): Now static.
1149 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1150 That way, the code declares only the vars that it needs.
1151 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1152 * s/cygwin.h (PTY_ITERATION): Likewise.
1153 * s/darwin.h (PTY_ITERATION): Likewise.
1154 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1156 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1157 * process.c (allocate_pty): Don't declare stb unless it's needed.
1159 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
1160 (CONSTANTLIM): Remove; unused.
1161 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1162 Define only if needed.
1164 * unexelf.c (unexec): Name an expression,
1165 to avoid gcc -Wbad-function-cast warning.
1166 Use a different way to cause a compilation error if anyone uses
1167 n rather than nn, a way that does not involve shadowing.
1168 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
1170 * deps.mk (unexalpha.o): Remove; unused.
1172 New file unexec.h, the (simple) interface for unexec (Bug#8267).
1173 * unexec.h: New file.
1174 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1175 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1177 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1178 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1179 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
1180 Change as necessary to match prototype in unexec.h.
1182 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1184 (back_comment, skip_chars): Mark vars as initialized.
1186 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1187 Rename locals to avoid shadowing.
1189 * lread.c (read1): Rewrite so as not to use empty "else".
1190 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
1192 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1194 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1195 warning when compiling print.c.
1197 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1198 instead of using an uninitialized var.
1199 (font_sort_entities): Mark var as initialized.
1201 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1203 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1204 pointers to constants.
1205 (font_parse_fcname): Remove unused vars.
1206 (font_delete_unmatched): Now static.
1207 (font_get_spec): Remove; unused.
1208 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1209 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1210 Rename or move locals to avoid shadowing.
1212 * fns.c (require_nesting_list, require_unwind): Now static.
1213 (Ffillarray): Rename locals to avoid shadowing.
1215 * floatfns.c (domain_error2): Define only if needed.
1216 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1218 * alloc.c (mark_backtrace): Move decl from here ...
1219 * lisp.h: ... to here, so that it can be checked.
1221 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
1222 (Fdefvar): Rewrite so as not to use empty "else".
1223 (lisp_indirect_variable): Name an expression,
1224 to avoid gcc -Wbad-function-cast warning.
1225 (Fdefvar): Rename locals to avoid shadowing.
1227 * callint.c (quotify_arg, quotify_args): Now static.
1228 (Fcall_interactively): Rename locals to avoid shadowing.
1229 Use const pointer when appropriate.
1231 * lisp.h (get_system_name, get_operating_system_release):
1232 Move decls here, to check interfaces.
1233 * process.c (get_operating_system_release): Move decl to lisp.h.
1234 * xrdb.c (get_system_name): Likewise.
1235 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1236 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1237 some of which prompt warnings from gcc -Wbad-function-cast.
1238 (Fformat_time_string, Fencode_time, Finsert_char):
1239 (Ftranslate_region_internal, Fformat):
1240 Rename or remove local vars to avoid shadowing.
1241 (Ftranslate_region_internal): Mark var as initialized.
1243 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1246 * lisp.h (eassert): Check that the argument compiles, even if
1247 ENABLE_CHECKING is not defined.
1249 * data.c (Findirect_variable): Name an expression, to avoid
1250 gcc -Wbad-function-cast warning.
1251 (default_value, arithcompare, arith_driver, arith_error): Now static.
1252 (store_symval_forwarding): Rename local to avoid shadowing.
1253 (Fmake_variable_buffer_local, Fmake_local_variable):
1254 Mark variables as initialized.
1255 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
1257 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
1258 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1259 Rename locals to avoid shadowing.
1260 (mark_stack): Move local variables into the #ifdef region where
1262 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1263 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1265 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1266 (GC_STRING_CHARS): Remove; not used.
1267 (Fmemory_limit): Cast sbrk's returned value to char *.
1269 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1270 avoids undefined behavior in theory.
1272 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1274 Use functions, not macros, for up- and down-casing (Bug#8254).
1275 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1276 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1277 to use the following functions instead of these macros.
1278 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1279 EMACS_INT, since callers assume the returned value fits in int.
1280 (upcase1): Likewise, for UPCASE_TABLE.
1281 (uppercasep, lowercasep, upcase): New static inline functions.
1282 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
1283 the race-condition problem in the old DOWNCASE.
1285 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1286 Rename locals to avoid shadowing.
1287 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
1288 (regex_compile, re_search_2, re_match_2_internal):
1289 Remove unused local vars.
1290 (FREE_VAR): Rewrite so as not to use empty "else",
1291 which gcc can warn about.
1292 (regex_compile, re_match_2_internal): Mark locals as initialized.
1293 (RETALLOC_IF): Define only if needed.
1294 (WORDCHAR_P): Likewise. This one is never needed, but is used
1295 only in a comment talking about a compiler bug, so put inside
1296 the #if 0 of that comment.
1297 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1298 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1301 * search.c (boyer_moore): Rename locals to avoid shadowing.
1302 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1303 (PREV_CHAR_BOUNDARY): Likewise.
1305 * search.c (simple_search): Remove unused var.
1307 * dired.c (compile_pattern): Move decl from here ...
1308 * lisp.h: ... to here, so that it can be checked.
1309 (struct re_registers): New forward decl.
1311 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1313 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1315 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1316 Rename locals to avoid shadowing.
1317 (Fvertical_motion): Mark locals as initialized.
1319 * casefiddle.c (casify_object, casify_region): Now static.
1320 (casify_region): Mark local as initialized.
1322 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1324 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1325 New macros, so that the caller can use some names other than
1326 gcpro1, gcpro2, etc.
1327 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1329 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1330 argument, for consistency with GCPRO2_VAR, etc: it is now the
1331 prefix of the variable, not the variable itself. All uses
1333 * dired.c (directory_files_internal, file_name_completion):
1334 Rename locals to avoid shadowing.
1336 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1337 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1338 dired.c's scmp function, had undefined behavior.
1339 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1340 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1341 * buffer.h: ... to here, because these macros use current_buffer,
1342 and the new implementation with inline functions needs to have
1343 current_buffer in scope now, rather than later when the macros
1345 (downcase, upcase1): New static inline functions.
1346 (DOWNCASE, UPCASE1): Reimplement using these functions.
1347 This avoids undefined behavior in expressions like
1348 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1349 from race conditions in accessing the global variables
1350 case_temp1 and case_temp2.
1351 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1352 * lisp.h (case_temp1, case_temp2): Remove their decls.
1353 * character.h (ASCII_CHAR_P): Move from here ...
1354 * lisp.h: ... to here, so that the inline functions mentioned
1357 * dired.c (directory_files_internal_unwind): Now static.
1359 * fileio.c (file_name_as_directory, directory_file_name):
1360 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1362 (file_name_as_directory): Use const pointers when appropriate.
1363 (Fexpand_file_name): Likewise. In particular, newdir might
1364 point at constant storage, so make it a const pointer.
1365 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
1366 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1368 (Fset_file_times, Finsert_file_contents, auto_save_error):
1369 Rename locals to avoid shadowing.
1371 * minibuf.c (choose_minibuf_frame_1): Now static.
1372 (Ftry_completion, Fall_completions): Rename or remove locals
1375 * marker.c (bytepos_to_charpos): Remove; unused.
1377 * lisp.h (verify_bytepos, count_markers): New decls,
1378 so that gcc does not warn that these functions aren't declared.
1380 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1381 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
1382 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
1383 (copy_text): Remove unused local var.
1385 * filelock.c (within_one_second): Now static.
1386 (lock_file_1): Rename local to avoid shadowing.
1388 * buffer.c (fix_overlays_before): Mark locals as initialized.
1389 (fix_start_end_in_overlays): Likewise. This function should be
1390 simplified by using pointers-to-pointers, but that's a different
1392 (switch_to_buffer_1): Now static.
1393 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1394 (report_overlay_modification): Rename locals to avoid shadowing.
1396 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
1397 Fix pointer signedness issue.
1398 (sys_subshell): Mark local as volatile if checking for lint,
1399 to suppress a gcc -Wclobbered warning that does not seem to be right.
1400 (MAXPATHLEN): Define only if needed.
1402 * process.c (serial_open, serial_configure): Move decls from here ...
1403 * systty.h: ... to here, so that they can be checked.
1405 * fns.c (get_random, seed_random): Move extern decls from here ...
1406 * lisp.h: ... to here, so that they can be checked.
1408 * sysdep.c (reset_io): Now static.
1409 (wait_for_termination_signal): Remove; unused.
1411 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1412 (copy_keymap_item, append_key, push_text_char_description):
1414 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
1415 (DENSE_TABLE_SIZE): Remove; unused.
1416 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1417 (describe_map_tree):
1418 Rename locals to avoid shadowing.
1420 * keyboard.c: Declare functions static if they are not used elsewhere.
1421 (echo_char, echo_dash, cmd_error, top_level_2):
1422 (poll_for_input, handle_async_input): Now static.
1423 (read_char, kbd_buffer_get_event, make_lispy_position):
1424 (make_lispy_event, make_lispy_movement, apply_modifiers):
1425 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1426 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1427 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
1428 (read_key_sequence, read_char): Mark locals as initialized.
1429 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
1431 * keyboard.h (make_ctrl_char): New decl.
1432 (mark_kboards): Move decl here ...
1433 * alloc.c (mark_kboards): ... from here.
1435 * lisp.h (force_auto_save_soon): New decl.
1437 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
1438 (DEFINE_DUMMY_FUNCTION): New macro.
1439 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1441 (main): Add casts to avoid warnings
1442 if GCC considers string literals to be constants.
1444 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1446 * dbusbind.c: Pointer signedness fixes.
1447 (xd_signature, xd_append_arg, xd_initialize):
1448 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1449 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1450 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1451 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1453 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1454 if GCC considers string literals to be constants.
1455 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
1457 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1459 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1460 (print_preprocess, print_object): New macro to fix last change.
1462 * print.c (print_preprocess): Don't forget font objects.
1464 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
1466 * emacs.c (USAGE3): Doc fixes.
1468 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1470 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1473 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
1475 * lisp.h (VWindow_system, Qfile_name_history):
1476 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1477 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1478 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1480 * w32select.c: Don't #include "keyboard.h".
1481 (run_protected): Add extern declaration for waiting_for_input.
1483 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1484 * w32console.c (detect_input_pending, read_input_pending)
1485 (encode_terminal_code):
1486 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1487 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1488 (w32_system_caret_y, Qfile_name_history):
1489 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1490 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1491 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1492 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1493 * w32proc.c (Qlocal, report_file_error):
1494 * w32term.c (Vwindow_system, updating_frame):
1495 * w32uniscribe.c (initialized, uniscribe_font_driver):
1496 Remove unneeded extern declarations.
1498 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
1500 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
1502 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
1504 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1505 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1506 These macros can no longer be used for assignment.
1508 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1509 Assign struct members directly, instead of using BUF_BEGV etc.
1510 (record_buffer_markers, fetch_buffer_markers): New functions for
1511 recording and fetching special buffer markers.
1512 (set_buffer_internal_1, set_buffer_temp): Use them.
1514 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1516 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1518 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1519 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1521 * xdisp.c (hscroll_window_tree):
1522 (reconsider_clip_changes): Use PT instead of BUF_PT.
1524 2011-03-13 Eli Zaretskii <eliz@gnu.org>
1526 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1527 $(EMACS_ROOT)/lib/intprops.h.
1529 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1531 Fix more problems found by GCC 4.5.2's static checks.
1533 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1534 to unsigned char * to avoid compiler diagnostic.
1535 (xg_free_frame_widgets): Make it clear that a local variable is
1536 needed only if USE_GTK_TOOLTIP.
1537 (gdk_window_get_screen): Make it clear that this macro is needed
1538 only if USE_GTK_TOOLTIP.
1539 (int_gtk_range_get_value): New function, which avoids a diagnostic
1540 from gcc -Wbad-function-cast.
1541 (xg_set_toolkit_scroll_bar_thumb): Use it.
1542 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1543 diagnostic from gcc -Wbad-function-cast.
1544 (get_utf8_string, xg_get_file_with_chooser):
1545 Rename locals to avoid shadowing.
1546 (create_dialog): Move locals to avoid shadowing.
1548 * xgselect.c (xg_select): Remove unused var.
1550 * image.c (four_corners_best): Mark locals as initialized.
1551 (gif_load): Initialize transparent_p to zero (Bug#8238).
1552 Mark another local as initialized.
1553 (my_png_error, my_error_exit): Mark with NO_RETURN.
1555 * image.c (clear_image_cache): Now static.
1556 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
1557 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
1558 (x_edge_detection): Remove unnecessary cast that
1559 gcc -Wbad-function-cast diagnoses.
1560 (gif_load): Fix pointer signedness.
1561 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1562 (jpeg_load, gif_load): Rename locals to avoid shadowing.
1564 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
1566 Improve quality of tests for time stamp overflow.
1567 For example, without this patch (encode-time 0 0 0 1 1
1568 1152921504606846976) returns the obviously-bogus value (-948597
1569 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1570 reports time overflow. See
1571 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
1572 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1573 * editfns.c: Include limits.h and intprops.h.
1574 (TIME_T_MIN, TIME_T_MAX): New macros.
1575 (time_overflow): Move earlier, to before first use.
1576 (hi_time, lo_time): New functions, for an accurate test for
1578 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1579 (Fget_internal_run_time): Don't assume time_t fits in int.
1580 (make_time): Use list2 instead of Fcons twice.
1581 (Fdecode_time): More accurate test for out-of-range times.
1582 (check_tm_member): New function.
1583 (Fencode_time): Use it, to test for out-of-range times.
1584 (lisp_time_argument): Don't rely on undefined left-shift and
1585 right-shift behavior when checking for time stamp overflow.
1587 * editfns.c (time_overflow): New function, refactoring common code.
1588 (Fformat_time_string, Fdecode_time, Fencode_time):
1589 (Fcurrent_time_string): Use it.
1591 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1592 * dired.c (make_time): Move to ...
1593 * editfns.c (make_time): ... here.
1594 * systime.h: Note the move.
1596 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1598 * fringe.c (update_window_fringes): Remove unused variables.
1600 * unexmacosx.c (copy_data_segment): Also copy __got section.
1603 2011-03-12 Eli Zaretskii <eliz@gnu.org>
1605 * termcap.c [MSDOS]: Include "msdos.h".
1606 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1607 Constify `char *' arguments and their references according to
1608 prototypes in tparam.h.
1610 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
1612 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1613 Adapt all references accordingly.
1615 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1617 2011-03-11 Tom Tromey <tromey@redhat.com>
1619 * buffer.c (syms_of_buffer): Remove obsolete comment.
1621 2011-03-11 Eli Zaretskii <eliz@gnu.org>
1623 * termhooks.h (encode_terminal_code): Declare prototype.
1625 * msdos.c (encode_terminal_code): Don't declare prototype.
1627 * term.c (encode_terminal_code): Now external again, used by
1628 w32console.c and msdos.c.
1630 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
1631 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
1633 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
1635 Fix some minor problems found by GCC 4.5.2's static checks.
1637 * fringe.c (update_window_fringes): Mark locals as initialized
1639 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
1641 * alloc.c (mark_fringe_data): Move decl from here ...
1642 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
1643 to check its interface.
1644 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
1646 * fontset.c (free_realized_fontset): Now static.
1647 (Fset_fontset_font): Rename local to avoid shadowing.
1648 (fontset_font): Mark local as initialized.
1649 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
1651 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
1653 * xselect.c (x_disown_buffer_selections): Remove; not used.
1654 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
1655 (x_own_selection, Fx_disown_selection_internal): Rename locals
1657 (x_handle_dnd_message): Remove local to avoid shadowing.
1659 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
1660 so that the caller can use some name other than gcpro1.
1661 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
1662 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1663 (Fx_backspace_delete_keys_p):
1664 Use them to avoid shadowing, and rename vars to avoid shadowing.
1665 (x_decode_color, x_set_name, x_window): Now static.
1666 (Fx_create_frame): Add braces to silence GCC warning.
1667 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
1668 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
1669 Remove unused locals.
1670 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1671 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
1672 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
1675 * xterm.h (x_mouse_leave): New decl.
1677 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
1678 Remove unused functions.
1679 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
1680 (x_calc_absolute_position): Now static.
1681 (XTread_socket): Don't define label "out" unless it's used.
1682 Don't declare local "event" unless it's used.
1683 (x_iconify_frame, x_free_frame_resources): Don't declare locals
1684 unless they are used.
1685 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
1686 (x_fatal_error_signal): Remove; not used.
1687 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
1688 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
1689 (x_error_catcher, x_connection_closed, x_error_handler):
1690 (x_error_quitter, xembed_send_message, x_iconify_frame):
1691 (my_log_handler): Rename locals to avoid shadowing.
1692 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
1693 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
1695 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
1696 Rename or move locals to avoid shadowing.
1697 (tty_defined_color, merge_face_heights): Now static.
1698 (free_realized_faces_for_fontset): Remove; not used.
1699 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
1700 does not deduce is never used uninitialized.
1701 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
1702 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
1704 * terminal.c (store_terminal_param): Now static.
1706 * xmenu.c (menu_highlight_callback): Now static.
1707 (set_frame_menubar): Remove unused local.
1708 (xmenu_show): Rename parameter to avoid shadowing.
1709 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
1710 since they might point to immutable storage.
1711 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
1712 since it's unused otherwise.
1714 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
1715 Add a FIXME, since the code still doesn't look right. (Bug#8215)
1716 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
1717 avoids a gcc -Wuninitialized diagnostic.
1718 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
1719 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
1720 does not deduce are never used uninitialized.
1722 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
1724 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
1725 * window.c (window_loop, size_window):
1726 (run_window_configuration_change_hook, enlarge_window): Likewise.
1728 * window.c (display_buffer): Now static.
1729 (size_window): Mark variables that gcc -Wuninitialized
1730 does not deduce are never used uninitialized.
1731 * window.h (check_all_windows): New decl, to forestall
1732 gcc -Wmissing-prototypes diagnostic.
1733 * dispextern.h (bidi_dump_cached_states): Likewise.
1735 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
1737 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
1739 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
1740 and to avoid gcc -Wuninitialized warning.
1741 (load_charset_map): Mark variables that gcc -Wuninitialized
1742 does not deduce are never used uninitialized.
1743 (load_charset): Abort instead of using uninitialized var (Bug#8229).
1745 * coding.c (coding_set_source, coding_set_destination):
1746 Use "else { /* comment */ }" rather than "else /* comment */;"
1747 for clarity, and to avoid gcc -Wempty-body warning.
1748 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
1749 a block, when the outer 'i' will do.
1750 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
1751 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
1752 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
1753 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
1754 (Fdecode_sjis_char, Fdefine_coding_system_internal):
1755 Rename locals to avoid shadowing.
1756 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
1757 * coding.c (emacs_mule_char, encode_invocation_designation):
1758 Now static, since they're not used elsewhere.
1759 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
1760 (decode_coding_object, encode_coding_object, detect_coding_system):
1761 (decode_coding_emacs_mule): Mark variables that gcc
1762 -Wuninitialized does not deduce are never used uninitialized.
1763 (detect_coding_iso_2022): Initialize a local variable that might
1764 be used uninitialized. Leave a FIXME because it's not clear that
1765 this initialization is needed. (Bug#8211)
1766 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
1767 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
1768 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
1769 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
1770 Remove unused macros.
1772 * category.c (hash_get_category_set): Remove unused local var.
1773 (copy_category_table): Now static, since it's not used elsewhere.
1774 * character.c (string_count_byte8): Likewise.
1776 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
1777 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
1779 * chartab.c (copy_sub_char_table): Now static, since it's not used
1781 (sub_char_table_ref_and_range, char_table_ref_and_range):
1782 Rename locals to avoid shadowing.
1783 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
1785 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
1786 (BIDI_BOB): Remove unused macro.
1788 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
1789 deduce are never used uninitialized.
1790 * term.c (encode_terminal_code): Likewise.
1792 * term.c (encode_terminal_code): Now static. Remove unused local.
1794 * tparam.h: New file.
1795 * term.c, tparam.h: Include it.
1796 * deps.mk (term.o, tparam.o): Depend on tparam.h.
1797 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
1798 Move these decls to tparam.h, and make them agree with what
1799 is actually in tparam.c. The previous trick of using incompatible
1800 decls in different modules does not conform to the C standard.
1801 All callers of tparam changed to use tparam's actual API.
1802 * tparam.c (tparam1, tparam, tgoto):
1803 Use const pointers where appropriate.
1805 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
1806 * cm.h (struct cm): Likewise.
1807 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
1808 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
1809 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
1810 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
1811 (turn_on_face, init_tty): Likewise.
1812 * termchar.h (struct tty_display_info): Likewise.
1814 * term.c (term_mouse_position): Rename local to avoid shadowing.
1816 * alloc.c (mark_ttys): Move decl from here ...
1817 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
1819 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
1821 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
1823 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
1825 * search.c (compile_pattern_1): Remove argument regp, unused since
1826 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
1827 (compile_pattern): Don't pass it.
1829 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
1831 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
1832 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
1834 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
1836 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
1838 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
1839 gdk_window_get_screen, gdk_window_get_geometry,
1840 gdk_x11_window_lookup_for_display and GDK_KEY_g.
1841 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
1842 (xg_get_pixbuf_from_pixmap): New function.
1843 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
1844 to Pixmap, take frame as parameter, remove GdkColormap parameter.
1845 Call xg_get_pixbuf_from_pixmap instead of
1846 gdk_pixbuf_get_from_drawable.
1847 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
1848 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
1849 (xg_check_special_colors): Use GtkStyleContext and its functions
1851 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
1852 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
1853 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
1854 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
1855 Call gtk_widget_get_preferred_size.
1856 (xg_frame_resized): gdk_window_get_geometry only takes 5
1858 (xg_win_to_widget, xg_event_is_for_menubar):
1859 Call gdk_x11_window_lookup_for_display.
1860 (xg_set_widget_bg): New function.
1861 (delete_cb): New function.
1862 (xg_create_frame_widgets): connect delete-event to delete_cb.
1863 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
1864 (xg_set_background_color): Call xg_set_widget_bg.
1865 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
1866 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
1867 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
1868 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
1870 (update_frame_tool_bar): Call gtk_widget_hide.
1871 (xg_initialize): Use GDK_KEY_g.
1873 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
1875 (x_session_initialize): Call gdk_x11_set_sm_client_id.
1877 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
1878 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
1879 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
1881 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
1883 * w32xfns.c (select_palette): Check success of RealizePalette against
1884 GDI_ERROR, not zero.
1886 See ChangeLog.11 for earlier changes.
1892 Copyright (C) 2011 Free Software Foundation, Inc.
1894 This file is part of GNU Emacs.
1896 GNU Emacs is free software: you can redistribute it and/or modify
1897 it under the terms of the GNU General Public License as published by
1898 the Free Software Foundation, either version 3 of the License, or
1899 (at your option) any later version.
1901 GNU Emacs is distributed in the hope that it will be useful,
1902 but WITHOUT ANY WARRANTY; without even the implied warranty of
1903 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
1904 GNU General Public License for more details.
1906 You should have received a copy of the GNU General Public License
1907 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.