1 2012-09-12 Jan Djärv <jan.h.d@swipnet.se>
3 * gtkutil.c (x_wm_set_size_hint): Use 1 col for base_width so it
4 does not become zero (Bug#12234). Backport from trunk.
6 2012-08-24 Chong Yidong <cyd@gnu.org>
8 * Version 24.2 released.
10 2012-08-24 Eli Zaretskii <eliz@gnu.org>
12 * ralloc.c (free_bloc): Don't dereference a 'heap' structure if it
13 is not one of the heaps we manage. (Bug#12242)
15 2012-08-14 Glenn Morris <rgm@gnu.org>
17 * eval.c (Fcalled_interactively_p): Doc fix. (Bug#11747)
19 2012-08-14 Ulrich Mueller <ulm@gentoo.org>
21 * systime.h (EMACS_TIME_CMP): Don't cast time_t values to long
24 2012-08-13 Eli Zaretskii <eliz@gnu.org>
26 * w32menu.c: Include w32heap.h.
27 (add_menu_item): If the call to AppendMenuW (via
28 unicode_append_menu) fails, disable Unicode menus only if we are
29 running on Windows 9X/Me.
31 * makefile.w32-in ($(BLD)/w32menu.$(O)): Depend on w32heap.h.
33 * window.c (Fdelete_other_windows_internal)
34 (Fdelete_window_internal): Don't access frame's mouse highlight
35 info of the initial frame. (Bug#11677)
37 2012-08-12 Jan Djärv <jan.h.d@swipnet.se>
39 * nsterm.m (ns_read_socket): Return early if there is a modal
42 * nsmenu.m (Popdown_data): New struct.
43 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
45 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
46 (initWithContentRect): Make imgView and contentView non-static
47 and autorelease them. Also autorelease img and matrix (Bug#12005).
48 (dealloc): Remove (Bug#12005).
50 * nsterm.m (keyDown:): Interpret flags without left/right bits
51 as the left key (Bug#11670).
53 * nsmenu.m (ns_update_menubar): Add braces to ambigous if-else.
55 2012-08-08 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
57 * unexmacosx.c (copy_data_segment): Copy initialized data in
58 statically linked libraries from input file rather than memory.
60 2012-08-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
62 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
63 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
64 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
66 2012-07-19 Chong Yidong <cyd@gnu.org>
68 * window.c (Fwindow_absolute_pixel_edges)
69 (Fdelete_other_windows_internal): Signal an error if the window is
70 on a dead frame (Bug#11984).
72 2012-07-14 Eli Zaretskii <eliz@gnu.org>
74 Remove FILE_SYSTEM_CASE.
75 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
77 * fileio.c (FILE_SYSTEM_CASE): Don't define.
78 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
79 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
80 call-process-region passes it through expand-file-name.
82 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
84 2012-07-12 Andreas Schwab <schwab@linux-m68k.org>
86 Fix crash when creating indirect buffer (Bug#11917)
87 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
88 Don't handle unbound variables specially if non-zero.
89 (Fbuffer_local_variables): Pass zero.
90 (clone_per_buffer_values): Pass non-zero.
92 2012-06-28 Andreas Schwab <schwab@linux-m68k.org>
94 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
95 to make the loop interruptible.
97 2012-06-26 Andreas Schwab <schwab@linux-m68k.org>
99 * gnutls.c (emacs_gnutls_handshake): Only retry if
100 GNUTLS_E_INTERRUPTED.
102 2012-06-23 Eli Zaretskii <eliz@gnu.org>
104 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
105 in the logic of incrementing and decrementing the value of
106 use_relocatable_buffers.
108 2012-06-21 Glenn Morris <rgm@gnu.org>
110 * charset.c (init_charset): Make lack of etc/charsets fatal.
112 2012-06-11 Jan Djärv <jan.h.d@swipnet.se>
114 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
115 referenced (Bug#11583).
117 2012-06-01 Chong Yidong <cyd@gnu.org>
119 * Version 24.1 released.
121 2012-05-30 Eli Zaretskii <eliz@gnu.org>
123 * xdisp.c (handle_stop): Detect whether we have overlay strings
124 loaded by testing it->current.overlay_string_index to be
125 non-negative, instead of checking whether n_overlay_strings is
126 positive. (Bug#11587)
128 2012-05-30 Chong Yidong <cyd@gnu.org>
130 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
132 * doc.c (Fsubstitute_command_keys): Doc fix.
134 2012-05-29 Eli Zaretskii <eliz@gnu.org>
136 * search.c (search_buffer): Remove calls to
137 r_alloc_inhibit_buffer_relocation, as it is now called by
138 maybe_unify_char, which was the cause of relocation of buffer text
141 2012-05-23 Eli Zaretskii <eliz@gnu.org>
143 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
144 for the duration of call to load_charset, to avoid problems with
145 callers of maybe_unify_char that access buffer text through C
148 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
149 decrement the inhibition flag, instead of just setting or
152 2012-05-24 Ken Brown <kbrown@cornell.edu>
154 * callproc.c (Fcall_process): Restore a line that was accidentally
155 commented out in the 2011-02-13 change (bug#11547).
157 2012-05-23 Eli Zaretskii <eliz@gnu.org>
159 * lisp.h [REL_ALLOC]: Add prototypes for external functions
162 * buffer.c [REL_ALLOC]: Remove prototypes of
163 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
164 they are now on lisp.h.
166 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
168 * search.c (search_buffer): Use it to inhibit relocation of buffer
169 text while re_search_2 is doing its job, because re_search_2 is
170 passed C pointers to buffer text. (Bug#11519)
172 2012-05-21 Eli Zaretskii <eliz@gnu.org>
174 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
177 2012-05-19 Eli Zaretskii <eliz@gnu.org>
179 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
180 state after an additional call to move_it_in_display_line_to, keep
181 the values of it->max_ascent and it->max_descent found for the
183 (pos_visible_p): Revert the comparison against bottom_y to what it
184 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
187 2012-05-15 Eli Zaretskii <eliz@gnu.org>
189 * xdisp.c (pos_visible_p): Fix last change. (Bug#11464)
191 2012-05-13 Eli Zaretskii <eliz@gnu.org>
193 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
194 already have overlays loaded.
195 (handle_single_display_spec): Before returning without displaying
196 fringe bitmap, synchronize the bidi iterator with the main display
197 iterator, by calling iterate_out_of_display_property.
198 (iterate_out_of_display_property): Detect buffer iteration by
199 testing that it->string is a Lisp string.
200 (get_next_display_element): When the current object is exhausted,
201 and there's something on it->stack, call set_iterator_to_next to
202 proceed with what's on the stack, instead of returning zero.
203 (set_iterator_to_next): If called at the end of a Lisp string,
204 proceed to consider_string_end without incrementing string
205 position. Don't increment display vector index past the end of
206 the display vector. (Bug#11417)
207 (pos_visible_p): Don't report a position visible when move_it_to
208 stopped at the last line of window, which happens to be scanned
209 backwards by the bidi iteration. (Bug#11464)
211 2012-05-11 Eli Zaretskii <eliz@gnu.org>
213 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
214 and right-margin display specs even if the spec is invalid or we
215 are on a TTY, and thus unable to display on the fringes. That's
216 because the text with the property will not be displayed anyway,
217 so we need to signal to the caller that this is a "replacing"
218 display spec. This fixes display when the spec is invalid or we
221 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
223 * unexaix.c (make_hdr): Fix typo in prototype.
224 This bug broke the build on AIX. Problem reported by Gilles Pion.
226 2012-05-05 Eli Zaretskii <eliz@gnu.org>
228 * w32proc.c (new_child): Force Windows to reserve only 64KB of
229 stack for each reader_thread, instead of defaulting to 8MB
230 determined by the linker. This avoids failures in creating
231 subprocesses on Windows 7, see the discussion in this thread:
232 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
234 2012-05-02 Jim Meyering <meyering@redhat.com>
236 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
238 2012-04-29 Eli Zaretskii <eliz@gnu.org>
240 * xdisp.c (pos_visible_p): If already at a newline from the
241 display string before the 'while' loop, don't walk back the glyphs
242 from it3.glyph_row. Solves assertion violation when the display
243 string begins with a newline (egg.el). (Bug#11367)
245 2012-04-24 Chong Yidong <cyd@gnu.org>
247 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
249 2012-04-23 Eli Zaretskii <eliz@gnu.org>
251 * xdisp.c (pos_visible_p): If the window start position is beyond
252 ZV, start the display from buffer beginning. Prevents assertion
253 violation in init_iterator when the minibuffer window is scrolled
256 * window.c (window_scroll_pixel_based): Likewise.
258 2012-04-23 Chong Yidong <cyd@gnu.org>
260 * keymap.c (where_is_internal): Doc fix (Bug#10872).
262 2012-04-20 Glenn Morris <rgm@gnu.org>
264 * fileio.c (Fcopy_file, Fset_file_selinux_context):
265 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
267 2012-04-20 Eli Zaretskii <eliz@gnu.org>
269 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers): Don't
270 overrun array limits of glyph row's used[] array. (Bug#11288)
272 2012-04-20 Chong Yidong <cyd@gnu.org>
274 * process.c (wait_reading_process_output): If EIO occurs on a pty,
275 set the status to "failed" and ensure that sentinel is run.
277 2012-04-18 Glenn Morris <rgm@gnu.org>
279 * process.c (Fset_process_inherit_coding_system_flag)
280 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
281 (Fmake_network_process, Fmake_serial_process): Doc fix.
283 2012-04-17 Eli Zaretskii <eliz@gnu.org>
285 * xdisp.c (string_buffer_position_lim): Limit starting position to
287 (set_cursor_from_row): If called for a mode-line or header-line
288 row, return zero immediately.
289 (try_cursor_movement): If inside continuation line, don't back up
290 farther than the first row after the header line, if any. Don't
291 consider the header-line row as "partially visible", even if
292 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
294 2012-04-13 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
296 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n" (bug#11238).
298 2012-04-10 Teodor Zlatanov <tzz@lifelogs.com>
300 * process.c (make_process):
301 * process.h: Add integer `gnutls_handshakes_tried' member to
304 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
305 Add convenience `GNUTLS_LOG2i' macro.
307 * gnutls.c (gnutls_log_function2i): Convenience log function.
308 (emacs_gnutls_read): Use new log functions,
309 `gnutls_handshakes_tried' process member, and
310 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
311 attempts per process (connection).
313 2012-04-09 Eli Zaretskii <eliz@gnu.org>
315 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
316 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
318 2012-04-09 Jan Djärv <jan.h.d@swipnet.se>
320 * nsterm.m (constrainFrameRect): Always constrain when there is only
321 one screen (Bug#10962).
323 2012-04-06 Eli Zaretskii <eliz@gnu.org>
325 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
326 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
327 about subtle differences between FETCH_CHAR* and STRING_CHAR*
328 macros related to unification of CJK characters. For the details,
329 see the discussion following the message here:
330 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
332 2012-04-04 Chong Yidong <cyd@gnu.org>
334 * keyboard.c (Vdelayed_warnings_list): Doc fix.
336 2012-04-01 Eli Zaretskii <eliz@gnu.org>
338 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
339 instead of alloca. (Bug#11138)
341 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
343 * w32menu.c (is_simple_dialog): Properly check lisp types.
346 2012-03-31 Eli Zaretskii <eliz@gnu.org>
348 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
349 position we get to after a call to move_it_to fails the
350 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
351 only if we wind up in a string from display property. (Bug#11063)
353 * window.c (Fdelete_other_windows_internal): Invalidate the row
354 and column information about mouse highlight, so that redisplay
355 restores it after reallocating the glyph matrices. (Bug#7464)
357 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
358 string comes from a `display' text property, use the buffer
359 position of that property as if we actually saw that position in
361 (move_it_by_lines): Remove the assertion that
362 "it->current_x == 0 && it->hpos == 0" which can be legitimately
363 violated when there's a before-string at the beginning of a line.
366 2012-03-30 Eli Zaretskii <eliz@gnu.org>
368 * xdisp.c (append_space_for_newline): If the default face was
369 remapped, use the remapped face for the appended newline.
370 (extend_face_to_end_of_line): Use the remapped default face for
371 extending the face to the end of the line.
372 (display_line): Call extend_face_to_end_of_line when the default
373 face was remapped. (Bug#11068)
375 2012-03-29 Eli Zaretskii <eliz@gnu.org>
377 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
379 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
381 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
383 2012-03-27 Glenn Morris <rgm@gnu.org>
385 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
388 2012-03-26 Kenichi Handa <handa@m17n.org>
390 * dispextern.h (struct glyph): Fix previous change. Change the
391 bit length of glyphless.ch to 25 (Bug#11082).
393 2012-03-26 Chong Yidong <cyd@gnu.org>
395 * keyboard.c (Vselection_inhibit_update_commands): New variable.
396 (command_loop_1): Use it; inhibit selection update for
397 handle-select-window too (Bug#8996).
399 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
401 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
403 2012-03-25 Kenichi Handa <handa@m17n.org>
405 * dispextern.h (struct glyph): Change the bit length of
406 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
408 2012-03-24 Eli Zaretskii <eliz@gnu.org>
410 * s/ms-w32.h (tzname): Include time.h before redirecting to
411 _tzname. Fixes the MSVC build. (Bug#9960)
413 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
415 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
418 * xterm.c (XTread_socket): Only modify handling_signal if
419 !SYNC_INPUT. (Bug#11080)
421 2012-03-23 Eli Zaretskii <eliz@gnu.org>
423 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
424 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
425 when fetching a multibyte character consumes more bytes than
426 CHAR_BYTES returns, due to unification of CJK characters in
427 string_char. (Bug#11073)
429 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
431 * process.c (wait_reading_process_output): Handle pty disconnect
432 by refraining from sending oneself a SIGCHLD (bug#10933).
434 2012-03-22 Chong Yidong <cyd@gnu.org>
436 * dispextern.h (struct it): New member string_from_prefix_prop_p.
438 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
439 Mark string as coming from a prefix property.
440 (handle_face_prop): Use default face for prefix strings (Bug#4281).
441 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
443 2012-03-21 Chong Yidong <cyd@gnu.org>
445 * xfaces.c (Vface_remapping_alist): Doc fix.
447 2012-03-20 Eli Zaretskii <eliz@gnu.org>
449 * w32proc.c (Fw32_set_console_codepage)
450 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
453 2012-03-20 Chong Yidong <cyd@gnu.org>
455 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
456 to reflect default non-nil value of redisplay-dont-pause.
458 2012-03-19 Kenichi Handa <handa@m17n.org>
460 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
461 it fit in a valid range (Bug#11003).
463 2012-03-18 Eli Zaretskii <eliz@gnu.org>
465 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
466 that is not from display property, accept the row as a "cursor
467 row" if one of the string's character has a non-nil `cursor'
468 property. Fixes cursor positioning when there are newlines in
469 overlay strings, e.g. in icomplete.el. (Bug#11035)
471 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
473 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
475 2012-03-12 Chong Yidong <cyd@gnu.org>
477 * eval.c (inhibit_lisp_code): Rename from
478 inhibit_window_configuration_change_hook; move from window.c.
480 * xfns.c (unwind_create_frame_1, Fx_create_frame):
481 * window.c (run_window_configuration_change_hook)
482 (syms_of_window): Callers changed.
484 2012-03-11 Chong Yidong <cyd@gnu.org>
486 * keymap.c (Fkey_description): Doc fix (Bug#9700).
488 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
490 2012-03-10 Chong Yidong <cyd@gnu.org>
492 * frame.c (other_visible_frames): Don't assume the selected frame
493 is visible (Bug#10955).
495 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
497 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
499 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
501 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
502 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
505 2012-03-03 Glenn Morris <rgm@gnu.org>
507 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
509 2012-03-02 Eli Zaretskii <eliz@gnu.org>
511 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
512 position past the first glyph_row that ends at ZV. (Bug#10902)
513 (redisplay_window, next_element_from_string): Fix typos in
515 (redisplay_window): Pass to move_it_vertically the margin in
516 pixels, not in screen lines.
518 2012-03-02 Glenn Morris <rgm@gnu.org>
520 * buffer.c (buffer-list-update-hook): Doc fix.
522 2012-02-29 Eli Zaretskii <eliz@gnu.org>
524 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
525 push_it before setting up the iterator for the first overlay
526 string, even if we have an empty string loaded.
527 (next_overlay_string): If there's an empty string on the iterator
528 stack, pop the stack. (Bug#10903)
530 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
532 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
533 Suggested by Stefan Monnier in
534 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
535 * alloc.c (widen_to_Lisp_Object): New static function.
536 (mark_memory): Also mark Lisp_Objects by fetching pointer words
537 and widening them to Lisp_Objects. This would work even if
538 USE_LSB_TAG is defined and wide integers are used, which might
539 happen in a future version of Emacs.
541 2012-02-25 Chong Yidong <cyd@gnu.org>
543 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
546 * xselect.c (Fx_selection_exists_p): Doc fix.
547 (x_clipboard_manager_save_all): Print an informative message
548 before saving to clipboard manager.
550 2012-02-24 Chong Yidong <cyd@gnu.org>
552 * keyboard.c (process_special_events): Handle all X selection
553 requests in kbd_buffer, not just the next one (Bug#8869).
555 2012-02-23 Chong Yidong <cyd@gnu.org>
557 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
558 call when setting menu-bar-lines and tool-bar-lines parameters.
559 (unwind_create_frame_1): New helper function.
561 * window.c (inhibit_window_configuration_change_hook): New var.
562 (run_window_configuration_change_hook): Obey it.
563 (syms_of_window): Initialize it.
565 2012-02-22 Chong Yidong <cyd@gnu.org>
567 * xterm.c (x_draw_image_relief): Add missing type check for
568 Vtool_bar_button_margin (Bug#10743).
570 2012-02-21 Chong Yidong <cyd@gnu.org>
572 * fileio.c (Vfile_name_handler_alist): Doc fix.
574 * buffer.c (Fget_file_buffer): Protect against invalid file
575 handler return value.
577 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
579 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
580 when computing $valmask.
582 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
583 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
584 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
585 It's useless in that case, and it can cause problems on hosts
586 that allocate halves of EMACS_INT values separately.
587 Reported by Dan Horák. Diagnosed by Andreas Schwab in
588 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
589 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
590 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
591 it avoids undefined behavior on hosts where shifting right by more
592 than the word width has undefined behavior.
594 2012-02-19 Chong Yidong <cyd@gnu.org>
596 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
597 (Funhandled_file_name_directory, Ffile_name_as_directory)
598 (Fdirectory_file_name, Fexpand_file_name)
599 (Fsubstitute_in_file_name): Protect against invalid file handler
600 return values (Bug#10845).
602 2012-02-18 Eli Zaretskii <eliz@gnu.org>
604 * .gdbinit (pitx): Fix incorrect references to fields of the
607 2012-02-17 Chong Yidong <cyd@gnu.org>
609 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
611 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
613 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
614 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
616 2012-02-15 Chong Yidong <cyd@gnu.org>
618 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
619 marked as special. Also, starting docstrings with * is obsolete.
621 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
623 * gnutls.c (emacs_gnutls_write): Fix last change.
625 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
627 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
630 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
632 * keymap.c (Fsingle_key_description): Handle char ranges.
634 2012-02-12 Chong Yidong <cyd@gnu.org>
636 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
637 as that creates a dangerous corner case.
639 * window.c (Fdelete_window_internal): Invalidate the mouse
640 highlight (Bug#9904).
642 2012-02-12 Glenn Morris <rgm@gnu.org>
644 * xselect.c (Fx_own_selection_internal)
645 (Fx_get_selection_internal, Fx_disown_selection_internal)
646 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
647 * nsselect.m (Fx_own_selection_internal)
648 (Fx_disown_selection_internal, Fx_selection_exists_p)
649 (Fx_selection_owner_p, Fx_get_selection_internal):
650 Sync docs and argument specs with the xselect.c versions.
652 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
654 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
656 2012-02-11 Eli Zaretskii <eliz@gnu.org>
658 * w32select.c (Fx_selection_exists_p): Sync doc string and
659 argument list with xselect.c. (Bug#10783)
661 * w16select.c (Fx_selection_exists_p): Sync doc string and
662 argument list with xselect.c. (Bug#10783)
664 2012-02-10 Glenn Morris <rgm@gnu.org>
666 * fns.c (Fsecure_hash): Doc fix.
668 2012-02-09 Kenichi Handa <handa@m17n.org>
670 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
672 2012-02-07 Chong Yidong <cyd@gnu.org>
674 * buffer.c (Fbuffer_local_variables)
675 (buffer_lisp_local_variables): Handle unbound vars correctly;
676 don't let Qunbound leak into Lisp.
678 2012-02-07 Glenn Morris <rgm@gnu.org>
680 * image.c (Fimagemagick_types): Doc fix.
682 * image.c (imagemagick-render-type): Change it from a lisp object
683 to an integer. Move the doc here from the lisp manual.
684 Treat all values not equal to 0 the same.
686 2012-02-06 Chong Yidong <cyd@gnu.org>
688 * doc.c (store_function_docstring): Avoid applying docstring of
689 alias to base function (Bug#2603).
691 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
693 * .gdbinit (pp1, pv1): Remove redundant defines.
696 2012-02-04 Chong Yidong <cyd@gnu.org>
698 * nsterm.m: Declare a global (Bug#10694).
700 2012-02-04 Eli Zaretskii <eliz@gnu.org>
702 * w32.c (get_emacs_configuration_options):
703 Include --enable-checking, if specified, in the return value.
705 2012-02-04 Martin Rudalics <rudalics@gmx.at>
707 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
708 after rounding frame sizes. (Bug#9723)
710 2012-02-04 Eli Zaretskii <eliz@gnu.org>
712 * keyboard.c (adjust_point_for_property): Don't position point
713 before BEGV. (Bug#10696)
715 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
717 Handle overflow when computing char display width (Bug#9496).
718 * character.c (char_width): Return EMACS_INT, not int.
719 (char_width, c_string_width): Check for overflow when
720 computing the width; this is possible now that individual
721 characters can have unbounded width. Problem introduced
722 by merge from Emacs 23 on 2012-01-19.
724 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
726 * dbusbind.c (Fdbus_register_method): Mention the return value
727 :ignore in the docstring.
729 2012-02-02 Glenn Morris <rgm@gnu.org>
731 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
733 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
734 Unconditionally set to t. (Bug#10673)
735 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
736 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
737 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
739 2012-02-02 Kenichi Handa <handa@m17n.org>
741 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
742 0, do not call append_composite_glyph.
744 2012-02-02 Kenichi Handa <handa@m17n.org>
746 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
748 (x_produce_glyphs): If the component of a composition is a null
749 string, set it->pixel_width to 1 to avoid zero-width glyph.
751 2012-02-01 Eli Zaretskii <eliz@gnu.org>
753 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
754 first 2 arguments are identical. This makes inserting large
755 output from a subprocess an order of magnitude faster on
756 MS-Windows, where all sbrk'ed memory is always contiguous.
758 2012-01-31 Glenn Morris <rgm@gnu.org>
760 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
761 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
762 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
764 2012-01-29 Glenn Morris <rgm@gnu.org>
766 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
768 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
770 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
772 2012-01-28 Chong Yidong <cyd@gnu.org>
774 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
776 2012-01-26 Chong Yidong <cyd@gnu.org>
778 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
780 * search.c (Fsearch_forward, Fsearch_backward): Document negative
781 repeat counts (Bug#10507).
783 2012-01-26 Glenn Morris <rgm@gnu.org>
785 * lread.c (syms_of_lread): Doc fix.
787 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
789 * coding.c (encode_designation_at_bol): Change return value to
792 2012-01-25 Chong Yidong <cyd@gnu.org>
794 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
796 2012-01-21 Chong Yidong <cyd@gnu.org>
798 * floatfns.c (Fcopysign): Make the second argument non-optional,
799 since nil is not allowed anyway.
801 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
803 * process.c (read_process_output): Use p instead of XPROCESS (proc).
804 (send_process): Likewise.
806 2012-01-19 Martin Rudalics <rudalics@gmx.at>
808 * window.c (save_window_save, Fcurrent_window_configuration)
809 (Vwindow_persistent_parameters): Do not use Qstate.
812 2012-01-19 Kenichi Handa <handa@m17n.org>
814 * character.c (char_width): New function.
815 (Fchar_width, c_string_width, lisp_string_width):
816 Use char_width (Bug#9496).
818 2012-01-16 Martin Rudalics <rudalics@gmx.at>
820 * window.c (Vwindow_persistent_parameters): New variable.
821 (Fset_window_configuration, save_window_save): Handle persistent
824 2012-01-14 Eli Zaretskii <eliz@gnu.org>
826 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
827 thrashing the stack of the thread. (Bug#9087)
829 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
831 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
833 2012-01-11 Eli Zaretskii <eliz@gnu.org>
835 * xdisp.c (rows_from_pos_range): Handle the case where the
836 highlight ends on a newline. (Bug#10464)
837 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
838 he end column for display of highlight that ends on a newline
841 2012-01-11 Glenn Morris <rgm@gnu.org>
843 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
844 from load-path also when installation-directory is nil. (Bug#10208)
846 2012-01-10 Glenn Morris <rgm@gnu.org>
848 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
850 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
851 Update template values to be closer to their typical values these days.
853 2012-01-09 Eli Zaretskii <eliz@gnu.org>
855 * xdisp.c (rows_from_pos_range): Accept additional argument
856 DISP_STRING, and accept any glyph in a row whose object is that
857 string as eligible for mouse highlight. Fixes mouse highlight of
858 display strings from overlays. (Bug#10464)
860 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
862 emacs: fix an auto-save permissions race condition (Bug#10400)
863 * fileio.c (auto_saving_dir_umask): New static var.
864 (Fmake_directory_internal): Use it.
865 (do_auto_save_make_dir): Set it, instead of invoking chmod after
866 creating the directory. The old code temporarily assigns
867 too-generous permissions to the directory.
868 (do_auto_save_eh): Clear it.
869 (Fdo_auto_save): Catch all errors, not just file errors, so
870 that the var is always cleared.
872 2012-01-07 Eli Zaretskii <eliz@gnu.org>
874 * search.c (scan_buffer): Pass character positions to
875 know_region_cache, not byte positions. (Bug#6540)
877 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
879 * w32.c (sys_rename): Report EXDEV when rename of a directory
880 fails because the target is on another logical disk. (Bug#10284)
882 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
884 * xterm.c (x_embed_request_focus): New function.
886 * xterm.h: Add prototype.
888 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
890 2012-01-05 Glenn Morris <rgm@gnu.org>
892 * emacs.c (emacs_copyright): Update short copyright year to 2012.
894 2012-01-01 Eli Zaretskii <eliz@gnu.org>
896 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
897 Load gnutls_transport_set_lowat only if GnuTLS version is below
899 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
900 GnuTLS versions below 2.11.1.
902 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
904 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
905 to the doc string advising against its use for altering the way
906 windows are scrolled.
908 2011-12-28 Kenichi Handa <handa@m17n.org>
910 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
911 coding-system ASCII compatible only when it does not produce BOM
912 on encoding (Bug#10383).
914 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
916 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
918 (create_and_show_popup_menu): Always use menu_position_func for
921 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
923 * callint.c (Fcall_interactively): Don't truncate prompt string.
925 2011-12-23 Eli Zaretskii <eliz@gnu.org>
927 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
928 property that ends at ZV, so that the bidi iteration could be
929 resumed from there (after widening). (Bug#10360)
931 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
933 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
935 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
937 * nsterm.m (x_free_frame_resources):
938 Release f->output_data.ns->miniimage.
939 (ns_index_color): Fix indentation. Do not retain
940 color_table->colors[i].
942 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
945 * nsfns.m (x_set_background_color): Assign return value from
946 ns_index_color to face-background instead of NSColor*.
947 (ns_implicitly_set_icon_type): Fix indentation.
948 Change assignment in for loop to comparison.
950 * emacs.c (ns_pool): New variable.
951 (main): Assign ns_pool.
952 (Fkill_emacs): Call ns_release_autorelease_pool.
954 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
955 autorelease fdesc, release fdAttrs and tdict.
956 (ns_get_covering_families): Release charset.
957 (ns_findfonts): Release NSFontDescriptor created with new.
958 (ns_uni_to_glyphs): Fix indentation.
959 (setString): Release attrStr before assigning new value.
961 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
963 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
965 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
966 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
968 2011-12-18 David Reitter <reitter@cmu.edu>
970 * nsterm.m (ns_term_init): Subscribe for notifications
971 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
972 to method trackingNotification in EmacsMenu.
974 * nsmenu.m (trackingMenu): New variable.
975 (trackingNotification): New method (from Aquamacs).
976 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
977 from Aquamacs (Bug#7030).
979 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
981 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
982 (symbol_to_nsstring): Fix indentation.
983 (ns_symbol_to_pb): New function.
984 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
985 (Fns_rotate_cut_buffers_internal): Remove.
986 (Fns_store_selection_internal): Rename from
987 Fns_store_cut_buffer_internal.
988 (ns_get_foreign_selection, Fx_own_selection_internal)
989 (Fx_disown_selection_internal, Fx_selection_exists_p)
990 (Fns_get_selection_internal, Fns_store_selection_internal):
991 Use ns_symbol_to_pb and check if return value is nil.
992 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
993 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
994 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
995 renamed to Sns_store_selection_internal.
996 (ns_handle_selection_request): Move code to Fx_own_selection_internal
997 and remove this function.
998 (ns_handle_selection_clear): Remove, never used.
999 (Fx_own_selection_internal): Move code from ns_handle_selection_request
1002 2011-12-17 Ken Brown <kbrown@cornell.edu>
1004 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
1005 GID is unknown (Bug#10257).
1007 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
1009 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1010 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1011 which caused a build failure on GNU/Linux IA-64. This problem was
1012 introduced by my 2011-10-07 patch.
1014 2011-12-15 Juri Linkov <juri@jurta.org>
1016 * image.c (imagemagick_error): New function. (Bug#10112)
1017 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1018 Use `imagemagick_error' where ImageMagick functions return
1020 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1023 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1025 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1026 fill background (Bug#8992).
1028 2011-12-13 Martin Rudalics <rudalics@gmx.at>
1030 * window.c (Vwindow_combination_resize)
1031 (Vwindow_combination_limit): Use t instead of non-nil in
1033 (Vrecenter_redisplay): Add first sentence of doc-string on
1035 (Frecenter): Fix doc-string typo.
1037 2011-12-11 Kenichi Handa <handa@m17n.org>
1039 * coding.c (Funencodable_char_position): Pay attention to the
1040 buffer text relocation (Bug#9389).
1042 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1044 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1045 gtk_init (Bug#10100).
1047 2011-12-10 Eli Zaretskii <eliz@gnu.org>
1049 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1050 IT->string is nil. (Bug#10263)
1052 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1054 * nsterm.h (x_free_frame_resources): Declare.
1056 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1057 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1059 * nsterm.h (ns_get_defaults_value): Declare.
1061 * nsterm.m (ns_default): Call ns_get_defaults_value.
1063 2011-12-09 Eli Zaretskii <eliz@gnu.org>
1065 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1068 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1070 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1071 that where the value of an _OBJC_* symbol points to is in the .bss
1072 section (Bug#10240).
1074 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1076 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
1077 after the loop to call ccl_driver at least once (Bug#8619).
1079 2011-12-08 Kenichi Handa <handa@m17n.org>
1081 * ftfont.c (get_adstyle_property): Fix previous change
1084 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
1086 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1087 dirs from the default value of EMACSLOADPATH (bug#10208).
1089 2011-12-07 Glenn Morris <rgm@gnu.org>
1091 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1092 installation and source directories as well. (Bug#10208)
1094 2011-12-06 Chong Yidong <cyd@gnu.org>
1096 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1098 2011-12-06 Glenn Morris <rgm@gnu.org>
1100 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1101 as an error, not just -1. (Bug#10217)
1103 2011-12-05 Chong Yidong <cyd@gnu.org>
1105 * keyboard.c (process_special_events): New function.
1106 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1108 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1110 * coding.c (encode_designation_at_bol): Don't use uninitialized
1111 local variable (Bug#9318).
1113 2011-12-05 Kenichi Handa <handa@m17n.org>
1115 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1116 return Qnil (Bug#8046, Bug#10193).
1118 2011-12-05 Kenichi Handa <handa@m17n.org>
1120 * coding.c (encode_designation_at_bol): New args charbuf_end and
1121 dst. Return the number of produced bytes. Callers changed.
1122 (coding_set_source): Return how many bytes coding->source was
1124 (coding_set_destination): Return how many bytes
1125 coding->destination was relocated.
1126 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
1127 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
1129 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1131 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1132 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1135 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1137 The following changes are to fix Bug#9318.
1139 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
1140 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1141 (encode_coding_iso_2022, encode_coding_sjis)
1142 (encode_coding_big5, encode_coding_charset): Use the above macros.
1144 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
1146 * lisp.h (process_quit_flag): Fix external declaration.
1148 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1150 Don't macro-inline non-performance-critical code.
1151 * eval.c (process_quit_flag): New function.
1152 * lisp.h (QUIT): Use it.
1154 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1156 * nsfns.m (get_geometry_from_preferences): New function.
1157 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1159 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1161 * emacs.c (Qkill_emacs): Define.
1162 (syms_of_emacs): Initialize it.
1163 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1164 Qquit_flag to `kill-emacs' instead.
1165 (quit_throw_to_read_char): Add parameter `from_signal'.
1166 All callers changed. Call Fkill_emacs if requested and safe.
1167 * lisp.h (QUIT): Call Fkill_emacs if requested.
1169 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1171 * widget.c (update_wm_hints): Return if wmshell is null.
1172 (widget_update_wm_size_hints): New function.
1174 * widget.h (widget_update_wm_size_hints): Declare.
1176 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1177 widget_update_wm_size_hints (Bug#10104).
1179 2011-12-03 Eli Zaretskii <eliz@gnu.org>
1181 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1182 before a newline, prepare the bidi iterator for consuming the
1183 newline, and keep the current paragraph direction. (Bug#10183)
1184 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1186 2011-12-02 Juri Linkov <juri@jurta.org>
1188 * search.c (Fword_search_regexp): New Lisp function created from
1189 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1190 (Fword_search_backward, Fword_search_forward)
1191 (Fword_search_backward_lax, Fword_search_forward_lax):
1192 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1193 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1195 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1197 * fileio.c (Finsert_file_contents): Move after-change-function call
1198 to before the "handled:" label, since all "goto handled" appear in
1199 cases where the *-change-functions have already been properly called
1202 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1204 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1205 waiting for input. (Bug#10169)
1207 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1209 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1210 verifies glyph row's hash code--we have just reallocated the
1211 glyphs, so their contents can be complete garbage. (Bug#10164)
1213 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1215 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1217 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1219 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1220 attributes are tested _before_ calling verify_row_hash, to protect
1221 against GCC re-ordering of the tests. (Bug#10164)
1223 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1225 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1227 * xterm.c (handle_one_xevent): Only set async_visible and friends
1228 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1229 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1230 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1232 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1234 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1235 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1236 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1237 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1238 All uses changed to use GCPRO1 etc.
1239 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1240 Revert to old implementation (i.e., before 2011-03-11).
1242 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1244 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1245 of scroll runs so as to avoid assigning disabled bogus rows and
1246 unnecessary graphics copy operations.
1248 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1250 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1251 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1252 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1253 (malloc, free, realloc, calloc): Redirect to e_* only when
1256 * lisp.h (GCTYPEBITS): Move before first use.
1257 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1258 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1259 this macro definition.
1261 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1264 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1266 * gtkutil.c (xg_create_frame_widgets):
1267 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1268 present with Gtk+ 2.0.
1270 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1272 * fileio.c (Finsert_file_contents): Undo previous change; see
1273 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1275 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1277 Rename locals to avoid shadowing.
1278 * fileio.c (Finsert_file_contents):
1279 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1280 * process.c (wait_reading_process_output):
1281 Rename inner 'proc' to 'p' to avoid shadowing.
1282 Indent for consistency with usual Emacs style.
1284 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1286 * xdisp.c (redisplay_window): If cursor row is not fully visible
1287 after recentering, and scroll-conservatively is set to a large
1288 number, scroll window by a few more lines to make the cursor fully
1289 visible and out of scroll-margin. (Bug#10105)
1290 (start_display): Don't move to the next line if the display should
1291 start at a newline that is part of a display vector or an overlay
1294 2011-11-24 Juri Linkov <juri@jurta.org>
1296 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1297 after the `MagickPingImage' call. (Bug#10112)
1299 2011-11-23 Chong Yidong <cyd@gnu.org>
1301 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1303 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1305 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1306 making another buffer current. (Bug#10114)
1308 2011-11-23 Glenn Morris <rgm@gnu.org>
1310 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1312 2011-11-23 Chong Yidong <cyd@gnu.org>
1314 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1315 using it (Bug#5984).
1317 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1319 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1320 and header-lines, as they don't have one computed for them.
1323 * .gdbinit (prow): Make displayed values more self-explaining.
1324 Add row's hash code.
1326 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1328 * process.c (wait_reading_process_output): Fix asynchrounous
1329 GnuTLS socket handling on some versions of the GnuTLS library.
1330 (wait_reading_process_output): Add comment and URL.
1332 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1334 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1336 2011-11-21 Chong Yidong <cyd@gnu.org>
1338 * window.c (Fnext_window, Fprevious_window): Doc fix.
1340 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1342 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1344 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1346 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1348 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1350 * window.c (Fset_window_combination_limit): Rename argument
1352 (Vwindow_combination_limit): Remove "status" from doc-string.
1354 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1356 * m/ibms390.h: Remove.
1357 * m/ibms390x.h: Don't include "ibms390.h".
1359 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1361 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1362 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1364 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1366 * casetab.c (Fset_case_table):
1367 * charset.c (Fcharset_after): Fix typos.
1369 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1371 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1372 Otherwise, valgrind does not work on some platforms.
1373 Problem reported by Andreas Schwab in
1374 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1375 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1376 is set, removing the need for VIRT_ADDRESS_VARIES.
1377 (PURE_P): Use a more-efficient implementation that needs just one
1378 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1379 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1380 to 4 (xorl, subq, cmpq, setbe).
1381 * alloc.c (pure): Always extern now, since that's the
1382 VIRT_ADDR_VARIES behavior.
1383 (PURE_POINTER_P): Use a single comparison, not two, for
1384 consistency with the new puresize.h.
1385 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1386 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1387 Remove VIRT_ADDR_VARIES no longer needed.
1389 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1391 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1392 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1393 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1394 behave as if the cursor position were at the window margin.
1396 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1397 and the cursor position is out of bounds, behave as if the cursor
1398 position were at the window margin. (Bug#10075)
1400 2011-11-18 Chong Yidong <cyd@gnu.org>
1402 * window.c (Fwindow_combination_limit): Make first argument
1403 non-optional, since it is meaningless for live windows like the
1406 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1408 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1410 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1412 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1413 (graft_intervals_into_buffer): Simplify.
1415 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1417 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1418 hash values of the two rows.
1419 (copy_row_except_pointers): Preserve the used[] arrays and the
1420 hash values of the two rows. (Bug#10035)
1421 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1423 * xdisp.c (row_hash): New function, body extracted from
1424 compute_line_metrics.
1425 (compute_line_metrics): Call row_hash, instead of computing the
1428 * dispnew.c (verify_row_hash): Call row_hash for computing the
1429 hash code of a row, instead of duplicating code from xdisp.c.
1431 * dispextern.h (row_hash): Add prototype.
1433 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1435 * frame.c (delete_frame): Don't delete the terminal when the last
1436 X frame is closed if emacs is built with GTK toolkit.
1438 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1440 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1442 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1444 * window.c (Vwindow_splits): Rename to
1445 Vwindow_combination_resize. Suggested by Juri Linkov.
1446 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1449 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1451 * nsfns.m (Fns_font_name):
1452 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1454 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1456 * window.h (window): Rename slot "nest" to "combination_limit".
1457 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1458 (Fset_window_nest): Rename to Fset_window_combination_limit.
1459 (Vwindow_nest): Rename to Vwindow_combination_limit.
1460 (recombine_windows, make_parent_window, make_window)
1461 (Fsplit_window_internal, saved_window)
1462 (Fset_window_configuration, save_window_save): Rename all
1463 occurrences of window_nest to window_combination_limit.
1465 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1467 * image.c (imagemagick_load_image): Fix typo.
1469 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1471 * xdisp.c (display_line): Move the call to
1472 highlight_trailing_whitespace before the call to
1473 compute_line_metrics, since the latter needs to see the final
1474 faces of all the glyphs to compute ROW's hash value.
1475 Fixes assertion violations in row_equal_p. (Bug#10035)
1477 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1479 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1480 just return (bug#10044).
1482 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1484 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1485 with user-defined heap size. Bump the default size of the temacs
1486 heap to 27MB, to avoid memory warning when running temacs.
1487 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1489 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1490 current_matrix and desired_matrix. (Bug#9990)
1491 (verify_row_hash) [XASSERTS]: New function.
1492 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1493 that the hash value of glyph rows is correct.
1495 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1497 * window.h (window): Remove splits slot.
1498 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1499 (Fdelete_other_windows_internal, make_parent_window)
1500 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1501 (Fset_window_configuration, save_window_save): Don't deal with
1502 split status of windows.
1503 (saved_window): Remove splits slot.
1504 (Vwindow_splits): Rewrite doc-string.
1506 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1508 * xfns.c (unwind_create_frame):
1509 * nsfns.m (unwind_create_frame):
1510 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1511 Vframe_list (Bug#9999).
1513 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1515 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1517 2011-11-11 Kenichi Handa <handa@m17n.org>
1519 * callproc.c (Fcall_process): Set the member dst_multibyte of
1522 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1524 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1525 avoid a crash (bug#9496).
1527 2011-11-09 Chong Yidong <cyd@gnu.org>
1529 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1530 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1532 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1534 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1536 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1538 Avoid some portability problems by eschewing 'extern inline' functions.
1539 The trivial performance wins aren't worth the portability hassles; see
1540 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1542 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1543 (window_box_width, window_box_left, window_box_left_offset)
1544 (window_box_right, window_box_right_offset): Undo previous change,
1545 by removing the "extern"s.
1546 * intervals.c (adjust_intervals_for_insertion)
1547 (adjust_intervals_for_deletion): Undo previous change,
1548 making these static again.
1549 (offset_intervals, temp_set_point_both, temp_set_point)
1550 (copy_intervals_to_string): No longer inline.
1551 * xdisp.c (window_text_bottom_y, window_box_width)
1552 (window_box_height, window_box_left_offset)
1553 (window_box_right_offset, window_box_left, window_box_right)
1554 (window_box): No longer inline.
1556 2011-11-08 Chong Yidong <cyd@gnu.org>
1558 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1559 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1560 Signal an error if not a live window.
1561 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1562 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1564 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1566 * lisp.h (syms_of_abbrev): Remove declaration.
1567 Reported by CHENG Gao <chenggao@royau.me>.
1569 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1571 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1572 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1573 of temacs in GUI mode.
1575 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1577 * window.h: Declare delete_all_child_windows instead of
1578 delete_all_subwindows.
1579 * window.c (Fwindow_nest, Fset_window_nest)
1580 (Fset_window_new_total, Fset_window_new_normal)
1581 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1582 (delete_all_subwindows): Rename to delete_all_child_windows.
1583 (Fdelete_other_windows_internal, Fset_window_configuration):
1584 Call delete_all_child_windows instead of delete_all_subwindows.
1585 * frame.c (delete_frame): Call delete_all_child_windows instead
1586 of delete_all_subwindows.
1588 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1590 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1591 This is also needed for porting to any host where GC_MARK_STACK is
1592 not GC_MAKE_GCPROS_NOOPS.
1593 (which_symbols): Use it.
1595 2011-11-07 Kenichi Handa <handa@m17n.org>
1597 * coding.c (coding_set_destination): Check coding->src_pos only
1598 when coding->src_object is a buffer (bug#9910).
1600 * process.c (send_process): Set the member src_multibyte of coding
1601 to 0 (bug#9911) when sending a unibyte text.
1603 * callproc.c (Fcall_process): Set the member src_multibyte of
1604 process_coding to 0 (bug#9912).
1606 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1608 * xmenu.c (cleanup_widget_value_tree): New function.
1609 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1610 calling free_menubar_widget_value_tree directly (Bug#9830).
1612 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1614 Fix some portability problems with 'inline'.
1615 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1616 (window_box_width, window_box_left, window_box_left_offset)
1617 (window_box_right, window_box_right_offset): Declare extern.
1618 Otherwise, these inline functions do not conform to C99 and
1619 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1620 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1621 * intervals.c (adjust_intervals_for_insertion)
1622 (adjust_intervals_for_deletion): Now extern, because otherwise the
1623 extern inline functions 'offset_intervals' couldn't refer to it.
1624 (static_offset_intervals): Remove.
1625 (offset_intervals): Rewrite using the old contents of
1626 static_offset_intervals. The old version didn't conform to C99
1627 because an extern inline function contained a reference to an
1628 identifier with static linkage.
1630 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1632 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1635 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1637 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1638 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1639 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1640 return Qleft_to_right.
1642 2011-11-06 Chong Yidong <cyd@gnu.org>
1644 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1645 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1646 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1647 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1648 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1649 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1650 (Fwindow_vscroll): Doc fix.
1651 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1652 argument, since it makes no sense to pass a live window and for
1653 consistency with window-child.
1655 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1657 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1660 2011-11-05 Jason Rumney <jasonr@gnu.org>
1662 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1663 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1665 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1666 bitwise arithmetic preventing use of unicode-sip and non-truetype
1669 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1671 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1674 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1675 initialization code to keep similarity to xfns.c after changes
1678 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1680 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1681 (unwind_create_frame): New function (Bug#9943).
1682 (Fx_create_frame): Restructure code to be more similar to the one in
1683 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1684 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1685 Move terminal->reference_count++ just before making the frame official
1688 * nsterm.m (x_free_frame_resources): New function.
1689 (x_destroy_window): Move code to x_free_frame_resources.
1691 * xfns.c (unwind_create_frame): Fix comment.
1692 (Fx_create_frame, x_create_tip_frame):
1693 Move terminal->reference_count++ just before making the frame
1694 official. Move initialization of image_cache_refcount and
1695 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1697 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1699 Support MSVC build with newer versions of Visual Studio.
1700 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1701 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1704 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1705 which are not supported by MSVC.
1706 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1707 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1709 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1711 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1713 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1715 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1717 Support MSVC build with newer versions of Visual Studio.
1718 * w32.c: Don't include w32api.h for MSVC.
1719 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1721 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1722 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1723 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1724 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1726 (alloca) [_MSC_VER]: Define to _alloca.
1728 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1730 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1732 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1734 * xdisp.c (note_mouse_highlight): If either of
1735 previous/next-single-property-change returns nil, treat that as
1736 the beginning or the end of the buffer. (Bug#9955)
1738 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1740 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1741 label is not null (Bug#9951).
1742 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1745 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1747 * window.c (Fwindow_body_size): Mention in the doc string that the
1748 return value is in frame's canonical units. (Bug#9949)
1750 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1752 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1754 * w32fns.c (unwind_create_frame): If needed, free the glyph
1755 matrices of the partially constructed frame. (Bug#9943)
1756 * xfns.c (unwind_create_frame): Likewise.
1758 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1760 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1761 Don't stop backward scan on the continuation glyph, even though
1762 its CHARPOS is positive.
1763 (mouse_face_from_buffer_pos, note_mouse_highlight):
1764 Rename cover_string to disp_string.
1766 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1768 * window.c (temp_output_buffer_show): Don't use
1769 Vtemp_buffer_show_specifiers.
1770 (Vtemp_buffer_show_specifiers): Remove unused variable.
1772 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1774 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1775 past the beginning of the current glyph matrix.
1777 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1779 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1780 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1781 HAVE_GTK3 (Bug#9869).
1783 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1784 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1786 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1788 * xterm.c: Declare x_handle_net_wm_state to return int.
1789 (handle_one_xevent): Check if we are iconified but don't have
1790 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1791 (get_current_wm_state): Return non-zero if not hidden,
1792 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1793 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1794 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1795 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1797 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1799 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1800 so that this new function doesn't get optimized away by a
1801 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1803 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1805 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1807 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1809 Fix the `xbytecode' command.
1810 * .gdbinit (xprintbytestr): New command.
1811 (xwhichsymbols): Rename from `which'; all callers changed.
1812 (xbytecode): Print the byte-code string as well.
1814 2011-10-29 Kim Storm <storm@cua.dk>
1816 * alloc.c (which_symbols): New function.
1818 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1820 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1823 2011-10-29 Glenn Morris <rgm@gnu.org>
1825 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1826 Not clear what it was for, and it causes various bugs. (Bug#9839)
1828 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1830 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1831 possible random value that matches one of those tested as
1832 condition to clear the mouse face.
1834 2011-10-28 Chong Yidong <cyd@gnu.org>
1836 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1838 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1840 * window.c (make_window): Initialize phys_cursor_on_p.
1842 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1844 * lisp.h (struct Lisp_Symbol): Update comments.
1846 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1848 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1850 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1852 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1853 <oslsachem@gmail.com> for helping to debug this.
1855 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1856 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1857 (g_b_init_get_glyph_outline_w): New static variables.
1858 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1859 (GetGlyphOutlineW_Proc): New typedefs.
1860 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1861 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1863 (w32font_open_internal, compute_metrics):
1864 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1865 instead of calling the "wide" APIs directly.
1867 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1869 * w32.h (syms_of_w32font): Add prototype.
1871 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1873 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1874 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1875 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1876 (Fmove_to_window_line): Doc fix.
1878 2011-10-27 Chong Yidong <cyd@gnu.org>
1880 * process.c (make_process): Set gnutls_state to NULL.
1882 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1883 non-NULL, regardless of GNUTLS_INITSTAGE.
1884 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1885 an error. Set process slots as soon as we allocate them.
1887 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1889 2011-10-27 Chong Yidong <cyd@gnu.org>
1891 * gnutls.c (emacs_gnutls_deinit): New function.
1892 Deallocate credentials structures as well as calling gnutls_deinit.
1893 (Fgnutls_deinit, Fgnutls_boot): Use it.
1895 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1896 (deactivate_process): Call emacs_gnutls_deinit.
1898 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1900 * image.c (x_create_x_image_and_pixmap):
1901 * w32.c (sys_rename, w32_delayed_load):
1902 * w32font.c (fill_in_logfont):
1903 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1905 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1907 * w32fns.c (w32_default_color_map): New function,
1908 extracted from Fw32_default_color_map.
1909 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1911 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1913 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1915 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1917 * keyboard.c (test_undefined): New function (bug#9751).
1918 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1920 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1922 * sysdep.c (init_sys_modes): Fix the check for the controlling
1923 terminal (Bug#6649).
1925 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1927 * dispextern.h (struct bidi_it): New member next_en_type.
1929 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1930 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1931 current character, check also for next_en_type being WEAK_EN.
1932 (bidi_resolve_weak): Don't enter the expensive loop if the current
1933 position is before next_en_pos. Record the bidi type of the first
1934 non-ET, non-BN character we find, in addition to its position.
1935 (bidi_level_of_next_char): Invalidate next_en_type when
1936 next_en_pos is over-stepped.
1938 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1940 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1941 * editfns.c: Rewrite current-time-zone so that it invokes
1942 the equivalent of (format-time-string "%Z") to get the time zone name.
1943 This fixes a bug when the time zone name contains characters that
1944 need converting from the system time locale to Emacs internal format.
1945 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1946 that patch fixed format-time-string to do the conversion, but
1947 I forgot to fix current-time-zone.
1948 (format_time_string): New function, containing most of
1949 what Fformat_time_string used to contain.
1950 (Fformat_time_string): Rewrite in terms of format_time_string.
1951 This doesn't change this function's behavior.
1952 (current-time-zone): Rewrite to use format_time_string.
1953 This fixes the bug reported by Michael Schierl in
1954 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1955 Jason Rumney's 2007-06-07 change worked around this bug, but
1957 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1959 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1961 * xdisp.c (start_display): If the character at POS is displayed
1962 via a display vector, reset IT->current.dpvec_index to zero.
1963 (try_window_reusing_current_matrix): If a line ends in a display
1964 vector or the next line starts in a display vector, continue
1965 redrawing the window even though the character position of
1966 start_row was reached.
1969 2011-10-18 Chong Yidong <cyd@gnu.org>
1971 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1972 with nobreak-char-display too.
1974 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1976 Fix part 3 of bug#9771.
1977 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1978 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1979 non-neutral characters if the current character is a paragraph
1980 separator (a.k.a. Newline). This avoids running the same
1981 expensive loop twice, once when we consume the preceding newline
1982 and the other time when the line actually needs to be displayed.
1983 Avoid the loop when we see neutrals on the base embedding level
1984 following a character whose directionality is the same as the
1985 paragraph's. This avoids running the expensive loop when a line
1986 ends in a long sequence of neutrals, like control characters.
1987 Add assertion against STRONG_AL type. Slightly rearrange code
1988 that determines the type of a neutral given the first non-neutral
1990 (bidi_level_of_next_char): Set next_en_pos to zero when
1991 invalidating its info.
1993 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1995 * xdisp.c (push_display_prop): Determine whether to record string
1996 or buffer position by IT->string, not by IT->method. Allow
1997 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1998 (move_it_vertically_backward): Don't look for character position
1999 immediately after the newline when in a continuation line.
2002 2011-10-15 Martin Rudalics <rudalics@gmx.at>
2004 * window.c (coordinates_in_window): Rewrite and delabelize
2005 vertical border check. (Bug#5357) (Bug#9618)
2007 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2009 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2010 errors in XSetWindowBorder (bug#9310).
2012 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2014 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2015 avoid crash when xmalloc overrun checking is enabled.
2017 2011-10-13 Eli Zaretskii <eliz@gnu.org>
2019 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2020 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2021 cursor motion with <left> and <right> arrow keys.
2023 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2024 some callers set that themselves.
2026 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2028 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2029 display string and the previous row comes from the same string and
2030 is empty. (Bug#9739) (Bug#9738)
2032 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2034 * doc.c (get_doc_string): Encode file name (bug#9735).
2036 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2038 * bidi.c (bidi_level_of_next_char):
2039 * xdisp.c (get_visually_first_element): Remove old incorrect
2040 comments regarding the Unicode Line Separator character.
2042 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2044 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2046 * alloc.c (Fgc_status): Do not access beyond zombies array
2047 boundary if nzombies > MAX_ZOMBIES.
2048 * alloc.c (dump_zombies): Add missing format specifier.
2050 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2052 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2053 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2055 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2056 Some packages use them to denote characters with modifiers.
2058 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2060 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2061 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2062 matching a pp-number. Rename parameter var to var1.
2064 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2066 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2068 2011-10-08 Glenn Morris <rgm@gnu.org>
2070 * callint.c (Fcall_interactively): Give a more explicit error for the
2071 'c' case with a non-character input. (Bug#8479)
2073 2011-10-08 Eli Zaretskii <eliz@gnu.org>
2075 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2077 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2078 lines that are hscrolled on the left.
2080 * dispnew.c (buffer_posn_from_coords): Account for a possible
2081 presence of header-line. (Bug#4426)
2083 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2085 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2086 Don't advertise functionality which we discourage or doesn't work.
2088 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2090 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2091 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2092 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2093 this makes Emacs dump core during garbage collection on rare
2094 occasions. sizeof is obviously inferior to offsetof here, so
2095 stick with offsetof.
2096 (GC_POINTER_ALIGNMENT): New macro.
2097 (mark_memory): Omit 3rd (offset) arg; caller changed.
2098 Don't assume EMACS_INT alignment is the same as pointer alignment.
2100 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2102 * keyboard.c (read_key_sequence_remapped): New var.
2103 (read_key_sequence): Compute remapping in the right buffer.
2104 (command_loop_1): Use read_key_sequence's remapping directly.
2106 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2108 * dired.c (file_name_completion): Don't expand file name.
2109 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2110 before checking file name handler.
2112 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2113 they've been requested explicitly (bug#9591).
2115 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
2117 * keymap.c (Fsingle_key_description): Use make_specified_string
2118 instead of build_string to build string from push_key_description.
2121 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2123 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2124 This fixes a Y2038 bug on 64-bit hosts.
2125 * buffer.c (reset_buffer):
2126 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2127 (Fclear_buffer_auto_save_failure):
2128 Use 0, not -1, to represent an unset failure time, since time_t
2129 might not be signed.
2131 Remove dependency on glibc malloc internals.
2132 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2133 Move back here from lisp.h, but with their new implementations.
2134 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2135 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2136 * charset.c (charset_table_init): New static var.
2137 (syms_of_charset): Use it instead of xmalloc. This removes a
2138 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2139 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2140 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2141 Move back to alloc.c.
2142 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2143 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2145 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2147 * nsterm.m (windowDidResize): Call x_set_window_size only when
2148 ns_in_resize is true. Otherwise set pixelwidth/height and
2149 call change_frame_size (Bug#9628).
2151 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2153 Port --enable-checking=all to Fedora 14 x86-64.
2154 * charset.c (syms_of_charset): Also account for glibc malloc's
2155 internal overhead when calculating the initial malloc maximum.
2157 Port --enable-checking=all to Fedora 14 x86.
2158 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2160 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2161 (overrun_check_realloc, overrun_check_free):
2162 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2163 That way, xmalloc returns a properly-aligned pointer even if
2164 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2165 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2166 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2167 into account when calculating the initial malloc maximum.
2168 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2169 Move here from alloc.c, so that charset.c can use it too.
2170 Properly align; the old code wasn't right for common 32-bit hosts
2171 when configured with --enable-checking=all.
2172 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2173 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2175 2011-09-29 Eli Zaretskii <eliz@gnu.org>
2177 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2180 2011-09-28 Eli Zaretskii <eliz@gnu.org>
2182 * xdisp.c (compute_display_string_end): If there's no display
2183 string at CHARPOS, return -1.
2185 * bidi.c (bidi_fetch_char): When compute_display_string_end
2186 returns a negative value, treat the character as a normal
2187 character not covered by a display string. (Bug#9624)
2189 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2191 * lread.c (Fread_from_string): Fix typo in docstring.
2193 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2195 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2196 newline, reseat the iterator instead of bidi-iterating there one
2197 character at a time. (Bug#9610)
2198 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2199 TO_CHARPOS if the bidi iterator is at base embedding level.
2201 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2203 * lread.c (readevalloop): Use correct code for NBSP.
2204 (read1): Likewise. (Bug#9608)
2206 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2208 * dbusbind.c (Fdbus_register_signal): When service is not
2209 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2211 2011-09-25 Glenn Morris <rgm@gnu.org>
2213 * buffer.c (truncate-lines): Doc fix.
2215 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2217 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2218 (Fset_window_next_buffers): Doc fix.
2220 2011-09-24 Glenn Morris <rgm@gnu.org>
2222 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2224 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2226 Fix minor problems found by static checking.
2227 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2228 * indent.c (Fvertical_motion): Fix == vs = typo.
2230 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2232 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2233 Default value is now t. Doc fix.
2235 * indent.c (Fvertical_motion): Compute and apply the overshoot
2236 logic when moving up, not only when moving down. Fix the
2237 confusing name and values of the it_overshoot_expected variable;
2238 logic changes accordingly. (Bug#9254) (Bug#9549)
2240 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2241 CHARPOS is covered by a display string which includes newlines.
2242 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2243 is covered by a display string with embedded newlines.
2245 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2247 * dbusbind.c (Fdbus_register_signal): Add match rule to
2248 Vdbus_registered_objects_table. (Bug#9581)
2249 (Fdbus_register_method, Vdbus_registered_objects_table):
2252 2011-09-24 Jim Meyering <meyering@redhat.com>
2254 do not ignore write error for any output size
2255 The previous change was incomplete.
2256 While it makes emacs --batch detect the vast majority of stdout
2257 write failures, errors were still ignored whenever the output size is
2258 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2259 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2260 && echo FAIL: ignored write error
2261 FAIL: ignored write error
2262 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2263 && echo FAIL: ignored write error
2264 FAIL: ignored write error
2265 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2267 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2269 * emacs.c (Fkill_emacs): In noninteractive mode exit
2270 non-successfully if a write error occurred on stdout. (Bug#9574)
2272 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2274 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2277 * dispextern.h (struct it): Update the comment documenting what
2280 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2282 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2283 a display string, extend search for cursor position to end of row.
2284 (find_row_edges): If the row ends in a newline from a display
2285 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2286 Handle the case of a display string with multiple newlines.
2287 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2288 non-empty line. Fixes confusing cursor motion with arrow keys at
2289 the beginning of a line that starts with whitespace.
2291 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2293 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2296 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2298 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2301 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2303 * xdisp.c (display_line): Record maximum and minimum buffer
2304 positions even if no glyphs were produced (e.g., by a zero-width
2305 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2306 buffer positions that will be removed from the glyph row because
2308 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2309 column is beyond frame width: don't subtract 1 "pixel" when
2310 computing width of the stretch.
2311 (reseat_at_next_visible_line_start): Undo the change made on
2312 2011-09-17 that saved paragraph information and restored it after
2313 the call to `reseat'. (Bug#9545)
2315 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2317 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2318 and turn window cursor on if cleared (Bug#9415).
2320 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2322 * search.c (boyer_moore): Take unibyte characters from pattern
2323 literally. (Bug#9458)
2325 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2327 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2329 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2331 Fix minor problem found by static checking.
2332 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2333 initialized, to pacify gcc -Wuninitialized.
2335 * fileio.c: Report proper errno when syscall falls.
2336 (Finsert_file_contents): Save and restore errno,
2337 so that report_file_error outputs the correct diagnostic.
2338 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2340 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2342 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2344 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2346 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2347 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2349 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2351 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2352 about the current paragraph and restore it after the call to reseat.
2354 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2355 (bidi_find_paragraph_start): Search back for paragraph beginning
2356 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2357 (bidi_move_to_visually_next): Only trigger paragraph-related
2358 computations when the last character is a newline or at EOB, not
2359 just any NEUTRAL_B. (Bug#9470)
2361 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2362 truncated lines if point is covered by a display string. (Bug#9524)
2364 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2366 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2367 (cons_to_x_long): New function.
2368 (lisp_data_to_selection_data): Use it. Correct the test for
2369 short-versus-long data; it was negated. Break out of vector
2370 loop, for efficiency, when a long datum is discovered.
2372 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2374 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2376 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2378 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2379 GCC PR/17406) by declaring this function with external scope.
2381 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2383 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2384 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2386 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2388 * editfns.c (Fformat): Correctly handle text properties on "%%".
2390 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2392 * xterm.c (x_draw_composite_glyph_string_foreground):
2393 * w32term.c (x_draw_composite_glyph_string_foreground):
2394 * term.c (encode_terminal_code):
2395 * composite.c (composition_update_it, get_composition_id):
2396 * xdisp.c (get_next_display_element)
2397 (fill_composite_glyph_string): Add comments about special meaning
2398 of TAB characters in a composition.
2400 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2402 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2403 This occurs when processing a multibyte format.
2404 Problem reported by Wolfgang Jenker.
2406 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2408 * xdisp.c (try_cursor_movement): Only check for exact match if
2409 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2411 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2413 Remove unused external symbols.
2414 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2415 * xdisp.c (calc_pixel_width_or_height): Now static.
2416 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2417 * indent.c (check_display_width):
2418 * w32term.c: Fix comment to match code.
2419 * xterm.c, xterm.h (x_catching_errors): Remove.
2421 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2423 * xselect.c: Use signed conversions more consistently (Bug#9498).
2424 (selection_data_to_lisp_data): Assume incoming selection data are
2425 signed integers, not unsigned. This is to be consistent with
2426 outgoing selection data, which was modified to use signed integers
2427 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2428 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2429 expects long, not unsigned long.
2431 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2433 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2434 computation of loop end. Reported by Johan Bockgård
2437 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2439 * frame.c (Fother_visible_frames_p): Function deleted.
2441 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2443 * indent.c (compute_motion): Process display vector front to back
2444 rather than the other way around. (Bug#2496)
2446 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2448 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2450 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2452 * minibuf.c (Fread_from_minibuffer): Doc fix.
2454 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2456 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2457 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2459 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2461 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2462 value for non-existent files.
2464 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2466 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2467 set its "size" to -1. This will set the modtime_size field of
2468 the corresponding buffer to -1, which is what
2469 verify-visited-file-modtime expects for files that do not exist.
2472 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2474 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2476 * lisp.h: ... from here. push_key_description is no longer
2477 defined in keyboard.c, so its declaration should not be in
2478 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2479 logically belongs with push_key_description.
2481 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2483 * buffer.h: Include <sys/types.h> instead of <time.h>.
2484 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2485 Problem reported by Herbert J. Skuhra.
2487 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2489 * xml.c (parse_region): Make the parsing work for
2490 non-comment-starting XML files again (bug#9144).
2492 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2494 * image.c (gif_load): Fix calculation of bottom and right corner.
2497 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2499 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2500 redisplay in small windows.
2502 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2504 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2506 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2508 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2509 Operate on live windows only.
2511 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2513 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2515 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2517 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2518 only under bidi iteration.
2520 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2522 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2524 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2526 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2527 Without this fix, the command to link temacs failed due to an
2528 undefined symbol __builtin_isnan. This is because
2529 /usr/include/iso/math_c99.h #defines isnan(x) to
2530 __builtin_isnan(x), but the bundled gcc, which identifies itself
2531 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2533 * floatfns.c (isnan): #undef, and then #define to a clone of
2535 (Fisnan): Always define, since it's always available now.
2536 (syms_of_floatfns): Always define isnan at the Lisp level.
2538 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2540 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2542 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2544 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2545 The previous code assumed that file offsets (off_t values) fit in
2546 EMACS_INT variables, which is not true on typical 32-bit hosts.
2547 The code messed up by falsely reporting buffer overflow in cases
2548 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2549 when "big" contains more than 2**29 bytes, even though this
2550 inserts just one byte and does not overflow the buffer.
2551 (Finsert_file_contents): Store file offsets as off_t
2552 values, not as EMACS_INT values. Check for overflow when
2553 converting between EMACS_INT and off_t. When checking for
2554 buffer overflow or for overlap, take the offsets into account.
2555 Don't use EMACS_INT for small values where int suffices.
2556 When checking for overlap, fix a typo: ZV was used where
2557 ZV_BYTE was intended.
2558 (Fwrite_region): Don't assume off_t fits into 'long'.
2559 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2561 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2563 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2565 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2567 sprintf-related integer and memory overflow issues (Bug#9412).
2569 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2570 (esprintf, exprintf, evxprintf): New functions.
2571 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2572 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2573 (modify_event_symbol): Do not assume that the length of
2574 name_alist_or_stem is safe to alloca and fits in int.
2575 (Fexecute_extended_command): Likewise for function name and binding.
2576 (Frecursion_depth): Wrap around reliably on integer overflow.
2577 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2578 since some callers pass EMACS_INT values.
2579 (Fsingle_key_description): Don't crash if symbol name contains more
2580 than MAX_ALLOCA bytes.
2581 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2582 (get_minibuffer): Arg is now EMACS_INT, not int.
2583 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2584 (esprintf, exprintf, evxprintf): New decls.
2585 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2587 * dbusbind.c (signature_cat): New function.
2588 (xd_signature, Fdbus_register_signal):
2589 Do not overrun buffer; instead, report string overflow.
2591 * dispnew.c (add_window_display_history): Don't overrun buffer.
2592 Truncate instead; this is OK since it's just a log.
2594 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2595 even if the time zone offset is outlandishly large.
2596 Don't mishandle offset == INT_MIN.
2598 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2599 when creating daemon; the previous buffer-overflow check was incorrect.
2601 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2602 which has the guts of the old verror function.
2604 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2605 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2607 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2608 (font_unparse_xlfd): Don't blindly alloca long strings.
2609 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2610 fits in int, when using sprintf. Use single snprintf to count
2611 length of string rather than counting it via multiple sprintfs;
2612 that's simpler and more reliable.
2613 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2614 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2615 sprintf, in case result does not fit in int.
2617 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2618 (fontset_from_font): Print it.
2620 * frame.c (tty_frame_count): Now printmax_t, not int.
2621 (make_terminal_frame, set_term_frame_name): Print it.
2622 (x_report_frame_params): In X, window IDs are unsigned long,
2623 not signed long, so print them as unsigned.
2624 (validate_x_resource_name): Check for implausibly long names,
2625 and don't assume name length fits in 'int'.
2626 (x_get_resource_string): Don't blindly alloca invocation name;
2627 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2630 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2631 (xg_check_special_colors, xg_set_geometry):
2632 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2634 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2635 Use esprintf, not sprintf, in case result does not fit in int.
2637 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2638 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2639 it as a large positive number.
2640 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2641 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2643 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2644 in case result does not fit in int.
2646 * print.c (float_to_string): Detect width overflow more reliably.
2647 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2648 buffer overrun. Don't assume list length fits in 'int'. Treat
2649 print length of 0 as 0, not as infinity; to be consistent with other
2650 uses of print length in this function. Don't overflow print length
2651 index. Don't assume hash table size fits in 'long', or that
2652 vectorlike size fits in 'unsigned long'.
2654 * process.c (make_process): Use printmax_t, not int, to format
2655 process-name gensyms.
2657 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2659 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2660 to avoid potential buffer overrun.
2662 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2663 if X resource line is longer than 512 bytes.
2665 * xfns.c (x_window): Make sprintf buffer a bit bigger
2666 to avoid potential buffer overrun.
2668 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2670 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2672 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2674 Integer overflow fixes for scrolling, etc.
2675 Without these, Emacs silently mishandles large integers sometimes.
2676 For example, "C-u 4294967297 M-x recenter" was treated as if
2677 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2679 * xdisp.c (try_window_id): Check Emacs fixnum range before
2680 converting to 'int'.
2682 * window.c (window_scroll_line_based, Frecenter):
2683 Check that an Emacs fixnum is in range before assigning it to 'int'.
2684 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2685 values converted from Emacs fixnums.
2686 (Frecenter): Don't wrap around a line count if it is out of 'int'
2687 range; instead, treat it as an extreme value.
2688 (Fset_window_configuration, compare_window_configurations):
2689 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2691 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2692 that can exceed INT_MAX. Check that EMACS_INT value is in range
2693 before assigning it to the (possibly-narrower) index.
2694 (match_limit): Don't assume that a fixnum can fit in 'int'.
2696 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2699 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2700 (Fvertical_motion): Don't wrap around LINES values that don't fit
2701 in 'int'. Instead, treat them as extreme values. This is good
2702 enough for windows, which can't have more than INT_MAX lines anyway.
2704 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2706 * Require libxml/parser.h to avoid compilation warning.
2708 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2710 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2711 since this reportedly can destroy thread storage.
2713 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2715 * syntax.c (find_defun_start): Update all cache variables if
2716 exiting early (Bug#9401).
2718 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2720 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2722 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2723 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2724 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2726 * term.c (tty_append_glyph): New function.
2727 (produce_stretch_glyph): Static function and its prototype deleted.
2729 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2732 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2734 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2735 when checking :margin (Bug#9390).
2736 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2737 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2738 so that the name doesn't mislead. All uses changed.
2740 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2742 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2745 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2747 * xdisp.c (move_it_to): Don't bail out early when reaching
2748 position beyond to_charpos, if we are scanning backwards.
2749 (move_it_vertically_backward): When DY == 0, make sure we get to
2750 the first character in the line after the newline.
2752 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2754 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2755 (ccl_driver): Do not generate an out-of-range pointer.
2756 (Fccl_execute_on_string): Remove unnecessary check for
2757 integer overflow, noted by Stefan Monnier in
2758 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2759 Remove a FIXME that didn't need fixing.
2760 Simplify the newly-introduced buffer reallocation code.
2762 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2764 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2766 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2768 Integer and memory overflow issues (Bug#9196).
2770 * doc.c (get_doc_string): Rework so that
2771 get_doc_string_buffer_size is the actual buffer size, rather than
2772 being 1 less than the actual buffer size; this makes xpalloc more
2775 * image.c (x_allocate_bitmap_record, cache_image):
2776 * xselect.c (Fx_register_dnd_atom):
2777 Simplify previous changes by using xpalloc.
2779 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2780 since either will do and ptrdiff_t is convenient with xpalloc.
2782 * charset.c (charset_table_size)
2783 (struct charset_sort_data.priority): Now ptrdiff_t.
2784 (charset_compare): Don't overflow if priorities differ greatly.
2785 (Fsort_charsets): Don't assume list length fits in int.
2786 Check for size-calculation overflow when allocating sort data.
2787 (syms_of_charset): Allocate an initial charset table that is
2788 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2790 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2792 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2793 The actual value is always <= INT_MAX, and leaving it unsigned made
2794 overflow checking harder.
2796 * dispextern.h (struct glyph_matrix.rows_allocated)
2797 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2798 with xpalloc. The values are still always <= INT_MAX.
2800 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2802 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2803 (SAFE_NALLOCA): New macro.
2805 * region-cache.c (struct boundary.pos, find_cache_boundary)
2806 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2807 (set_cache_region, invalidate_region_cache)
2808 (revalidate_region_cache, know_region_cache, region_cache_forward)
2809 (region_cache_backward, pp_cache):
2810 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2811 so that ptrdiff_t * can be passed to xpalloc.
2812 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2813 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2814 (pp_cache): Don't assume cache_len fits in int.
2815 * region-cache.h: Adjust extern decls to match.
2817 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2818 EMACS_INT, since either will do, for xpalloc.
2820 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2821 (xnmalloc, xnrealloc, xpalloc): New functions.
2823 * bidi.c (bidi_shelve_header_size): New constant.
2824 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2825 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2827 * bidi.c (bidi_cache_shrink):
2828 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2830 Don't update size of array until after memory allocation succeeds,
2831 because xmalloc/xrealloc may not return.
2832 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2833 now that we have proper integer overflow checking.
2834 (record_overlay_string, overlay_strings): Catch overflows when
2835 calculating size of overlay_str_buf.
2837 * callproc.c (Fcall_process): Check for size overflow when
2838 calculating size of args2.
2839 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2840 Normally we prefer signed values, but sticking with ptrdiff_t would
2841 require adding more-complicated checks.
2843 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2844 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2845 Redo buffer-overflow calculations to avoid integer overflow.
2846 Add a FIXME comment where memory seems to be over-allocated.
2848 * character.c (Fstring): Check for size-calculation overflow.
2850 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2851 unnecessary integer overflow. Check for size overflow.
2852 (encode_coding_object): Don't update size until xmalloc succeeds.
2854 * composite.c (get_composition_id): Check for overflow in glyph
2855 length calculations.
2857 Integer and memory overflow fixes for display code.
2858 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2859 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2860 (scrolling_window): Check for overflow in size calculations.
2861 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2862 Don't assume glyph table len fits in int.
2863 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2864 (row_table_size): Now ptrdiff_t, not int.
2865 (scrolling_window): Avoid overflow in size calculations.
2866 Don't update size until allocation succeeds.
2867 * fns.c (concat): Check for overflow in size calculations.
2868 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2869 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2870 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2872 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2873 (get_doc_string): Check for size calculation overflow.
2874 Don't update size until allocation succeeds.
2875 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2876 EMACS_INT, where ptrdiff_t will do.
2877 (Fsubstitute_command_keys): Check for string overflow.
2879 * editfns.c (set_time_zone_rule): Don't assume environment length
2881 (message_length): Now ptrdiff_t, not int.
2882 (Fmessage_box): Don't update size until allocation succeeds.
2883 Don't assume message length fits in int.
2884 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2886 * emacs.c (main): Do not reallocate argv, since there is a null at
2887 the end that can be overwritten, and this way there's no need to
2888 worry about size-calculation overflow.
2889 (sort_args): Check for size-calculation overflow.
2891 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2893 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2895 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2896 (x_set_scroll_bar_width, x_figure_window_size):
2897 Check for integer overflow.
2898 (x_set_alpha): Do not assume XINT fits in int.
2900 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2901 This is for the members text_lines, text_cols, total_lines, total_cols,
2902 where the system imposes an 'int' limit.
2904 * fringe.c (Fdefine_fringe_bitmap):
2905 Don't update size until alloc works.
2907 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2908 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2910 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2911 Check for size-calculation overflow.
2912 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2913 do, as we prefer signed integers.
2914 (id_to_widget.max_size, id_to_widget.used)
2915 (xg_store_widget_in_map, xg_remove_widget_from_map)
2916 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2917 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2918 Use and return ptrdiff_t, not int.
2919 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2920 * gtkutil.h: Change prototypes to match the above.
2922 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2923 are duplicate now that they've been promoted to lisp.h.
2924 (x_allocate_bitmap_record, x_alloc_image_color)
2925 (make_image_cache, cache_image, xpm_load):
2926 Don't update size until alloc is done.
2927 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2929 Check for size calculation overflow.
2930 (ct_colors_allocated_max): New constant.
2931 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2934 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2935 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2936 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2937 Use ptrdiff_t, not int, to count maps.
2938 (read_char_minibuf_menu_prompt): Check for overflow in size
2939 calculations. Don't update size until allocation succeeds.
2940 Redo calculations to avoid overflow.
2941 * keyboard.h: Change prototypes to match the above.
2943 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2945 (current_minor_maps): Check for size calculation overflow.
2946 * keymap.h: Change prototypes to match the above.
2948 * lread.c (read1, init_obarray): Don't update size until alloc done.
2950 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2951 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2953 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2954 Now ptrdiff_t, not int.
2955 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2956 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2958 * process.c (Fnetwork_interface_list): Check for overflow
2959 in size calculation.
2961 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2963 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2964 overflow. Don't bother calling xmalloc when xrealloc will do.
2966 * search.c (Freplace_match): Check for size calculation overflow.
2967 (Fset_match_data): Don't assume list lengths fit in 'int'.
2969 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2970 for command line length. Do not attempt to address one before the
2971 beginning of an array, as that's not portable.
2973 * term.c (max_frame_lines): Remove; unused.
2974 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2976 (encode_terminal_code, calculate_costs): Check for size
2977 calculation overflow.
2978 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2979 table lengths and related sizes. Don't update size until alloc
2980 done. Redo calculations to avoid overflow.
2981 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2983 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2984 subtracting pointers.
2985 (gobble_line): Check for overflow more carefully. Don't update size
2988 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2989 Don't update size until alloc done.
2990 Redo size calculations to avoid overflow.
2991 Check for size calculation overflow.
2992 (main) [DEBUG]: Fix typo in invoking tparam1.
2994 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2995 Use ptrdiff_t, not int, for sizes.
2996 (store_mode_line_noprop_char): Don't update size until alloc done.
2998 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2999 Use ptrdiff_t, not int, for sizes.
3000 (Finternal_make_lisp_face, cache_face):
3001 Check for size calculation overflow.
3002 (cache_face): Treat size calculation overflows as if they were
3003 memory exhaustion (the usual treatment), rather than aborting.
3005 * xfns.c (x_encode_text, x_set_name_internal)
3006 (Fx_change_window_property): Use ptrdiff_t, not int, to count
3007 sizes, since they can exceed INT_MAX in size. Check for size
3008 calculation overflow.
3010 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3011 (xg_select): Check for size calculation overflow.
3012 Don't update size until alloc done.
3014 * xrdb.c (get_environ_db): Don't assume path length fits in int,
3015 as sprintf is limited to int lengths.
3017 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3018 (X_LONG_MIN): New macros.
3019 Use them to make the following changes clearer.
3020 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3021 This change doesn't affect the value now, but it may help remind
3022 future maintainers not to raise the value too much later.
3023 (SELECTION_QUANTUM): Remove, replacing with ...
3024 (selection_quantum): ... new function, which avoids overflow.
3026 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3027 assumption that selection length fits in 'int'.
3028 (x_reply_selection_request, x_handle_selection_request)
3029 (x_get_window_property, receive_incremental_selection)
3030 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3031 (lisp_data_to_selection_data, clean_local_selection_data):
3032 Use ptrdiff_t, not int, to record length of selection.
3033 (x_reply_selection_request, x_get_window_property)
3034 (receive_incremental_selection, x_property_data_to_lisp):
3035 Redo calculations to avoid overflow.
3036 (x_reply_selection_request): When sending hint, ceiling it at
3037 X_LONG_MAX rather than relying on wraparound overflow to send
3039 (x_get_window_property, receive_incremental_selection)
3040 (lisp_data_to_selection_data, x_property_data_to_lisp):
3041 Check for size-calculation overflow.
3042 (x_get_window_property, receive_incremental_selection)
3043 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3044 Don't store size until memory allocation succeeds.
3045 (x_get_window_property): Plug memory leak on memory exhaustion.
3046 Don't double-block input; malloc is safe here. Don't assume 2**34
3047 - 4 fits in unsigned long. Add an xassert to check
3048 XGetWindowProperty overflow. Be more careful about overflow
3049 calculations, and distinguish size from memory overflow better.
3050 (receive_incremental_selection): When tracing, don't assume
3051 unsigned int is less than INT_MAX.
3052 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3053 harmful) conversions of unsigned short to int.
3054 (lisp_data_to_selection_data): Don't assume that integers
3055 in the range -65535 through -1 fit in an X unsigned short.
3056 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3057 result parameters unless successful. Rely on cons_to_unsigned
3058 to report problems with elements; the old code wasn't right anyway.
3059 (x_check_property_data): Check for int overflow; we cannot use
3060 a wider type due to X limits.
3061 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3063 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
3065 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3066 (x_term_init): Check for size calculation overflow.
3067 (x_color_cells): Don't store size until memory allocation succeeds.
3068 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
3069 Don't assume alloca size is less than MAX_ALLOCA.
3070 (x_term_init): Don't assume length fits in int (sprintf is limited
3073 Use ptrdiff_t for composition IDs.
3074 * character.c (lisp_string_width):
3075 * composite.c (composition_table_size, n_compositions)
3076 (get_composition_id, composition_gstring_from_id):
3077 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3078 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3079 * window.c (Frecenter):
3080 Use ptrdiff_t, not int, for composition IDs.
3081 * composite.c (get_composition_id): Check for integer overflow.
3082 * composite.h: Adjust prototypes to match the above changes.
3084 Use ptrdiff_t for hash table indexes.
3085 * category.c (hash_get_category_set):
3086 * ccl.c (ccl_driver):
3087 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3088 * coding.c (coding_system_charset_list, detect_coding_system):
3089 * coding.h (struct coding_system.id):
3090 * composite.c (get_composition_id, gstring_lookup_cache):
3091 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3092 * image.c (xpm_get_color_table_h):
3093 * lisp.h (hash_lookup, hash_put):
3094 * minibuf.c (Ftest_completion):
3095 Use ptrdiff_t for hash table indexes, not int (which is too
3096 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3097 32-bit --with-wide-int hosts).
3099 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3100 Add a FIXME comment about memory leaks.
3101 (syms_of_charset): Don't assume xmalloc returns.
3103 Don't assume that stated character widths fit in int.
3104 * character.c (Fchar_width, c_string_width, lisp_string_width):
3105 * character.h (CHAR_WIDTH):
3106 * indent.c (MULTIBYTE_BYTES_WIDTH):
3107 Use sanitize_char_width to avoid undefined and/or bad behavior
3108 with outlandish widths.
3109 * character.h (sanitize_tab_width): Rename from sanitize_width,
3110 now that we have two such functions. All uses changed.
3111 (sanitize_char_width): New inline function.
3113 Don't assume that tab-width fits in int.
3114 * character.h (sanitize_width): New inline function.
3115 (SANE_TAB_WIDTH): New macro.
3116 (ASCII_CHAR_WIDTH): Use it.
3117 * indent.c (sane_tab_width): Remove. All uses replaced by
3118 SANE_TAB_WIDTH (current_buffer).
3119 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3121 * fileio.c: Integer overflow issues with file modes.
3122 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3124 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3125 Remove unreachable code.
3126 (read_hex, load_charset_map_from_file): Check for integer overflow.
3128 * xterm.c: Don't go over XClientMessageEvent limit.
3129 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3130 (x_send_scroll_bar_event): Likewise. Check that the size does not
3131 exceed limits imposed by XClientMessageEvent, as well as the usual
3132 ptrdiff_t and size_t limits.
3134 * keyboard.c: Overflow, signedness and related fixes.
3135 (make_lispy_movement): Use same integer type in forward decl
3136 that is used in the definition.
3137 (read_key_sequence, keyremap_step):
3138 Change bufsize argument back to int, undoing my 2011-03-30 change.
3139 We prefer signed types, and int is wide enough here.
3140 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3141 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3142 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3143 length, not size_t. Use ptrdiff_t for index, not int.
3144 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3145 possibility of integer overflow.
3147 Overflow, signedness and related fixes for images.
3149 * dispextern.h (struct it.stack[0].u.image.image_id)
3150 (struct_it.image_id, struct image.id, struct image_cache.size)
3151 (struct image_cache.used, struct image_cache.ref_count):
3152 * gtkutil.c (update_frame_tool_bar):
3153 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3154 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3155 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3156 * nsmenu.m (update_frame_tool_bar):
3157 * xdisp.c (calc_pixel_width_or_height):
3158 * xfns.c (image_cache_refcount):
3159 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3160 on typical 64-bit hosts.
3162 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3163 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3164 Omit unnecessary casts to int.
3165 (parse_image_spec): Check that integers fall into 'int' range
3166 when the callers expect that.
3167 (image_ascent): Redo ascent calculation to avoid int overflow.
3168 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3169 (lookup_image): Remove unnecessary tests.
3170 (xbm_image_p): Locals are now of int, not EMACS_INT,
3171 since parse_image_check makes sure they fit into int.
3172 (png_load, gif_load, svg_load_image):
3173 Prefer int to unsigned where either will do.
3174 (tiff_handler): New function, combining the cores of the
3175 old tiff_error_handler and tiff_warning_handler.
3176 This function is rewritten to use vsnprintf and thereby avoid
3177 stack buffer overflows. It uses only the features of vsnprintf
3178 that are common to both POSIX and native Microsoft.
3179 (tiff_error_handler, tiff_warning_handler): Use it.
3180 (tiff_load, gif_load, imagemagick_load_image):
3181 Don't assume :index value fits in 'int'.
3182 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3183 (imagemagick_load_image): Check that crop parameters fit into
3184 the integer types that MagickCropImage accepts. Don't assume
3185 Vimagemagick_render_type has a nonnegative value. Don't assume
3186 size_t fits in 'long'.
3187 (gs_load): Use printmax_t to print the widest integers possible.
3188 Check for integer overflow when computing image height and width.
3190 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3192 * xdisp.c (redisplay_window): Don't force window start if point
3193 will be invisible in the resulting window. (Bug#9324)
3195 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3197 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3198 the display spec is of the form `(space ...)'.
3199 (handle_display_spec): Return the value returned by
3200 handle_single_display_spec, not just 1 or zero.
3201 (handle_single_display_spec): If the display spec is of the form
3202 `(space ...)', and specifies display in the text area, return 2
3204 (try_cursor_movement): Check for the need to scroll more
3205 accurately, and prefer exact match for point under bidi.
3206 Don't advance `row' beyond the last row of the window.
3208 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3209 into disp_prop; all users changed.
3211 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3212 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3213 for the text covered by the display property.
3215 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3217 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3218 Change return value to nil.
3219 (Frecord_buffer): Delete unused function.
3221 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3223 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3224 buffers, return left-to-right.
3225 (set_cursor_from_row): Consider candidate row a win if its glyph
3226 represents a newline and point is on that newline. Fixes cursor
3227 positioning on the newline at EOL of R2L text within L2R
3228 paragraph, and vice versa.
3229 (try_cursor_movement): Check continued rows, in addition to
3230 continuation rows. Fixes unwarranted scroll when point enters a
3231 continued line of R2L text within an L2R paragraph, or vice versa.
3232 (cursor_row_p): Consider the case of point being equal to
3233 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3234 from the end of a short line to the beginning of a continued line
3235 of R2L text within L2R paragraph.
3236 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3237 composed characters.
3239 * bidi.c (bidi_check_type): Use xassert.
3240 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3243 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3245 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3248 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3250 * nsfont.m (ns_otf_to_script): Fix typo.
3252 2011-08-22 Kenichi Handa <handa@m17n.org>
3254 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3255 extra slot even if the purpose is char-code-property-table.
3257 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3259 * xdisp.c (redisplay_window): When computing centering_position,
3260 account for the height of the header line. (Bug#8874)
3262 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3263 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3264 candidate is selected by the mouse, and that candidate has a
3265 composed character under the mouse.
3267 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3268 coordinates reported by pos-visible-in-window-p for a composed
3269 character in column zero.
3271 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3273 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3275 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3277 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3278 consider it a hit if to_charpos is anywhere in the range of the
3279 composed buffer positions.
3281 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3283 * image.c (gif_load): Don't assume that each subimage has the same
3284 dimensions as the base image. Handle disposal method that is
3285 "undefined" by the gif spec (Bug#9335).
3287 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3289 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3290 (Fcondition_case): Document `debug' symbol in error handler.
3292 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3294 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3295 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3296 from an Org mode buffer to a Speedbar frame.
3298 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3299 a composition, take its buffer position from IT->cmp_it.charpos.
3300 Fixes cursor positioning at the beginning of a line that begins
3301 with a composed character.
3303 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3305 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3306 character bidirectional type, use STRONG_L instead. Fixes crashes
3307 in a buffer produced by `describe-categories'.
3309 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3310 members before the level stack, so they would be saved and
3311 restored when copying iterator state. Fixes incorrect reordering
3312 around TABs covered by display properties.
3314 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3316 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3318 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3320 * eval.c (internal_condition_case, internal_condition_case_1)
3321 (internal_condition_case_2, internal_condition_case_n):
3322 Remove unnecessary aborts (Bug#9081).
3324 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3326 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3327 has no `load' handler, try opening the file locally. (Bug#9311)
3329 2011-08-16 Ken Brown <kbrown@cornell.edu>
3331 * gmalloc.c: Expand comment.
3333 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3335 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3336 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3338 2011-08-16 Ken Brown <kbrown@cornell.edu>
3340 Fix memory allocation problems in Cygwin build (Bug#9273).
3342 * unexcw.c ( __malloc_initialized): Declare external variable.
3343 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3345 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3347 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3349 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3351 [CYGWIN] (special_realloc): New function.
3352 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3353 requests to realloc storage in the static heap.
3355 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3357 * bidi.c (bidi_initialize): Remove unused local.
3359 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3362 * biditype.h: Remove file.
3363 * makefile.w32-in ($(BLD)/bidi.$(O)):
3364 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3366 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3368 * chartab.c: Improve commentary for the uniprop_table API.
3370 * bidi.c (bidi_paragraph_init): Support zero value of
3371 bidi_ignore_explicit_marks_for_paragraph_level.
3372 (bidi_initialize): Use uniprop_table instead of including
3373 biditype.h and bidimirror.h.
3375 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3376 coordinates of the iterator when restoring from ppos_it.
3379 2011-08-14 Kenichi Handa <handa@m17n.org>
3381 * process.c (create_process): Call setup_process_coding_systems
3382 after the pid of the process is set to -1 (Bug#8162).
3384 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3386 * xdisp.c (move_it_in_display_line_to): Don't invoke
3387 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3388 ppos_it. Fixes vertical cursor motion when line beginning is
3389 covered by an image. (Bug#9296)
3391 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3393 * nsterm.h (ns_run_ascript): Declare.
3394 (NSAPP_DATA2_RUNASSCRIPT): Define.
3396 * nsfns.m (as_script, as_result, as_status): New static variables.
3397 (ns_run_ascript): New function.
3398 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3399 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3400 the event loop. Get status from as_status (Bug#7276).
3402 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3403 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3404 the event loop (Bug#7276).
3406 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3408 * gnutls.c (QCgnutls_bootprop_priority)
3409 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3410 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3411 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3412 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3413 (QCgnutls_bootprop_verify_hostname_error)
3414 (QCgnutls_bootprop_callbacks_verify): Rename from
3415 Qgnutls_bootprop_..., all uses changed.
3417 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3420 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3422 * xfaces.c (Qframe_set_background_mode): Now static.
3423 * dispextern.h (Qframe_set_background_mode): Remove decl.
3425 * process.c (Fnetwork_interface_info): Declare local only if needed.
3427 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3429 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3430 (Fnetwork_interface_list): Allocate in increments of bytes instead
3431 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3432 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3434 (struct ifflag_def): notrailers is smart on OSX.
3435 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3436 Get hardware address with getifaddrs if available.
3438 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3440 * xdisp.c (iterate_out_of_display_property): xassert that
3441 IT->position is set to within IT->object's boundaries. Break from
3442 the loop as soon as EOB is reached; avoids infloops in redisplay
3443 when IT->position is set up wrongly due to some bug.
3444 Set IT->current to match the bidi iterator unconditionally.
3445 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3446 entry. Force push_it to save on the stack the current
3447 buffer/string position, to be restored by pop_it. Fix flags in
3448 the iterator structure wrt the object coming from a display
3449 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3450 properties. (Bug#9284)
3452 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3454 * fontset.c (fontset_get_font_group): Add proper type checks.
3457 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3459 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3460 and LC_VERSION_MIN_MACOSX.
3461 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3462 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3464 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3466 * xdisp.c (forward_to_next_line_start): Allow to use the
3467 no-display-properties-and-no-overlays under bidi display.
3468 Set disp_pos in the bidi iterator to avoid searches for display
3469 properties and overlays.
3471 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3473 * editfns.c (Fset_time_zone_rule): Document relationship with the
3476 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3477 the font entity extracted from the cache (Bug#8109).
3479 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3481 * composite.c (autocmp_chars): Don't reset point. That is done by
3482 restore_point_unwind (Bug#5984).
3484 2011-08-07 Juri Linkov <juri@jurta.org>
3486 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3487 to show the arg `TIME' instead of `TIMEVAL'.
3489 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3491 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3492 display property strides EOL and includes a newline, as in
3493 longlines-mode. (Bug#9254)
3494 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3495 word-wrap under bidirectional display. (Bug#9224)
3497 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3498 is non-zero, even if the data buffer is NULL. Fixes a crash in
3499 vertical-motion with longlines-mode. (Bug#9254)
3501 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3503 * bidi.c <bidi_cache_total_alloc>: Now static.
3504 (bidi_initialize): Initialize bidi_cache_total_alloc.
3506 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3509 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3510 amount allocated this far in `bidi_cache_total_alloc'.
3511 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3512 non-zero, only free the data buffer without restoring the cache
3513 contents. All callers changed.
3515 * dispextern.h (bidi_unshelve_cache): Update prototype.
3517 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3518 (move_it_in_display_line, move_it_to)
3519 (move_it_vertically_backward, move_it_by_lines): Replace the call
3520 to xfree to an equivalent call to bidi_unshelve_cache.
3521 (move_it_in_display_line_to): Fix logic of returning
3522 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3524 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3526 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3527 came from a string character with a `cursor' property. (Bug#9229)
3529 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3531 * Makefile.in (LIB_PTHREAD): New variable.
3532 (LIBES): Add LIB_PTHREAD (Bug#9216).
3534 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3535 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3537 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3539 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3541 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3543 * xterm.c (x_find_topmost_parent): New function.
3544 (x_set_frame_alpha): Find topmost parent window with
3545 x_find_topmost_parent and set the property there also (bug#9181).
3546 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3548 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3550 * callproc.c (Fcall_process): Avoid vfork clobbering
3551 the local vars buffer, coding_systems, current_dir.
3553 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3555 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3557 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3559 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3560 so that it is not optimized away.
3562 * xdisp.c (compute_display_string_pos): Remove unused local.
3564 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3566 Fix slow cursor motion and scrolling in large buffers with
3567 selective display, like Org Mode buffers. (Bug#9218)
3569 * dispextern.h (struct bidi_it): New member disp_prop_p.
3571 * xdisp.c: Remove one-slot cache of display string positions.
3572 (compute_display_string_pos): Accept an additional argument
3573 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3574 for a display string or property. If found, set DISP_PROP_P
3577 * bidi.c (bidi_fetch_char): Accept an additional argument
3578 DISP_PROP_P, and pass it to compute_display_string_pos.
3579 Only handle text covered by a display string if DISP_PROP_P is returned
3580 non-zero. All callers of bidi_fetch_char changed.
3582 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3584 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3586 2010-12-03 Don March <don@ohspite.net>
3588 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3589 last character M-[char] is translated to ESC [char] (bug#7541).
3591 2011-08-02 Kenichi Handa <handa@m17n.org>
3593 * lisp.h (uniprop_table): Extern it.
3595 * chartab.c (uniprop_table): Make it non-static.
3597 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3599 * xdisp.c (forward_to_next_line_start): Accept additional argument
3600 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3602 (reseat_at_next_visible_line_start): Use the bidi iterator state
3603 returned by forward_to_next_line_start to restore the state of
3604 it->bidi_it after backing up to previous newline. (Bug#9212)
3606 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3608 * regex.c (re_comp): Protoize.
3609 (re_exec): Fix return type.
3610 (regexec): Fix type of `ret'. (Bug#9203)
3612 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3614 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3615 This is needed if max-image-size is a floating-point number.
3617 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3619 * print.c (print_object): Print empty symbol as ##.
3621 * lread.c (read1): Read ## as empty symbol.
3623 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3625 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3626 setting frame foreground color (Bug#9175).
3627 (x_set_background_color): Likewise.
3629 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3630 contents (Bug#9176).
3631 (EmacsTooltip -init): Remove bezels and add shadows to
3634 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3635 or scroll bar (Bug#8470).
3637 * nsfont.m (nsfont_open): Remove assignment to voffset and
3638 unnecessary vars hshink, expand, hd, full_height, min_height.
3639 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3641 * nsterm.h (nsfont_info): Remove voffset field.
3643 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3645 Implement strike-through and overline on NextStep (Bug#8863).
3647 * nsfont.m (nsfont_open): Use underline position provided by font,
3648 instead of hard-coded value of 2.
3649 (nsfont_draw): Call ns_draw_text_decoration instead.
3651 * nsterm.h: Add declaration for ns_draw_text_decoration.
3653 * nsterm.m (ns_draw_text_decoration): New function for drawing
3654 underline, overline, and strike-through.
3655 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3656 ns_draw_text_decoration. Change treatment of cursor drawing to
3657 accommodate underlining, etc.
3659 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3661 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3664 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3666 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3667 Without this fix, if a signal arrives just after memory fills up,
3668 'malloc' might be invoked reentrantly.
3670 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3671 In other words, assume that every image size is allowed, on non-X
3672 hosts. This assumption is probably wrong, but it lets Emacs compile.
3674 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3676 * regex.c (re_iswctype): Convert return values to boolean.
3678 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3680 * xdisp.c (compute_display_string_pos): Don't use cached display
3681 string position if the buffer had its restriction changed.
3684 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3686 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3688 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3690 Integer signedness and overflow and related fixes. (Bug#9079)
3692 * bidi.c: Integer size and overflow fixes.
3693 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3694 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3695 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3696 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3697 (bidi_find_other_level_edge):
3698 Use ptrdiff_t instead of EMACS_INT where either will do.
3699 This works better on 32-bit hosts configured --with-wide-int.
3700 (bidi_cache_ensure_space): Check for size-calculation overflow.
3701 Use % rather than repeated addition, for better worst-case speed.
3702 Don't set bidi_cache_size until after xrealloc returns, because it
3704 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3705 (bidi_cache_ensure_space): Also check that the bidi cache size
3706 does not exceed that of the largest Lisp string or buffer. See Eli
3707 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3709 * alloc.c (__malloc_size_t): Remove.
3710 All uses replaced by size_t. See Andreas Schwab's note
3711 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3713 * image.c: Improve checking for integer overflow.
3714 (check_image_size): Assume that f is nonnull, since
3715 it is always nonnull in practice. This is one less thing to
3716 worry about when checking for integer overflow later.
3717 (x_check_image_size): New function, which checks for integer
3718 overflow issues inside X.
3719 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3720 This removes the need for a memory_full check.
3721 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3722 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3723 (xbm_read_bitmap_data): Change locals back to 'int', since
3724 their values must fit in 'int'.
3725 (xpm_load_image, png_load, tiff_load):
3726 Invoke x_create_x_image_and_pixmap earlier,
3727 to avoid much needless work if the image is too large.
3728 (tiff_load): Treat overly large images as if
3729 x_create_x_image_and_pixmap failed, not as malloc failures.
3730 (gs_load): Use x_check_image_size.
3732 * gtkutil.c: Omit integer casts.
3733 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3734 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3736 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3738 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3739 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3740 would wrongly return t on a 64-bit host.
3742 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3743 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3744 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3745 and therefore cause GCC to emit a bogus diagnostic in some cases.
3747 * image.c: Integer signedness and overflow and related fixes.
3748 This is not an exhaustive set of fixes, but it's time to
3749 record what I've got.
3750 (lookup_pixel_color, check_image_size): Remove redundant decls.
3751 (check_image_size): Don't assume that arbitrary EMACS_INT values
3752 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3753 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3754 (tiff_load, imagemagick_load_image):
3755 Check for overflow in size calculations.
3756 (x_create_x_image_and_pixmap): Remove unnecessary test for
3757 xmalloc returning NULL; that can't happen.
3758 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3759 (xpm_color_bucket): Use better integer hashing function.
3760 (xpm_cache_color): Don't possibly over-allocate memory.
3761 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3762 (gif_memory_source):
3763 Use ptrdiff_t, not int or size_t, to record sizes.
3764 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3765 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3766 either works, as we prefer signed integers.
3767 (tiff_read_from_memory, tiff_write_from_memory):
3768 Return tsize_t, not size_t, since that's what the TIFF API wants.
3769 (tiff_read_from_memory): Don't fail simply because the read would
3770 go past EOF; instead, return a short read.
3771 (tiff_load): Omit no-longer-needed casts.
3772 (Fimagemagick_types): Don't assume size fits into 'int'.
3774 Improve hashing quality when configured --with-wide-int.
3775 * fns.c (hash_string): New function, taken from sxhash_string.
3776 Do not discard information about ASCII character case; this
3777 discarding is no longer needed.
3778 (sxhash-string): Use it. Change sig to match it. Caller changed.
3779 * lisp.h: Declare it.
3780 * lread.c (hash_string): Remove, since we now use fns.c's version.
3781 The fns.c version returns a wider integer if --with-wide-int is
3782 specified, so this should help the quality of the hashing a bit.
3784 * emacs.c: Integer overflow minor fix.
3785 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3786 Define only if GNU_LINUX.
3787 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3789 * dispnew.c: Integer signedness and overflow fixes.
3790 Remove unnecessary forward decls, that were a maintenance hassle.
3791 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3793 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3794 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3795 (prepare_desired_row, line_draw_cost):
3796 Use int, not unsigned, where either works.
3797 (save_current_matrix, restore_current_matrix):
3798 Use ptrdiff_t, not size_t, where either works.
3799 (init_display): Check for overflow more accurately, and without
3800 relying on undefined behavior.
3802 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3803 Remove, replacing with the new symbols in lisp.h. All uses changed.
3804 * fileio.c (make_temp_name):
3805 * filelock.c (lock_file_1, lock_file):
3806 * xdisp.c (message_dolog):
3807 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3808 Use pMd etc. instead.
3809 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3810 replacing the pWIDE etc. symbols removed from editfns.c.
3812 * keyboard.h (num_input_events): Now uintmax_t.
3813 This is (very slightly) less likely to mess up due to wraparound.
3816 * buffer.c: Integer signedness fixes.
3817 (alloc_buffer_text, enlarge_buffer_text):
3818 Use ptrdiff_t rather than size_t when either will do, as we prefer
3821 * alloc.c: Integer signedness and overflow fixes.
3822 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3823 (__malloc_size_t): Default to size_t, not to int.
3824 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3825 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3826 Prefer ptrdiff_t to size_t when either would do, as we prefer
3828 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3829 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3830 Now const. Initialize with values that are in range even if char
3832 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3833 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3834 These functions do the right thing with sizes > 2**32.
3835 (check_depth): Now ptrdiff_t, not int.
3836 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3837 Adjust to new way of storing sizes. Check for size overflow bugs
3839 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3840 slightly wrong anyway, as it missed one instance of
3841 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3842 (refill_memory_reserve): Omit needless cast to size_t.
3843 (mark_object_loop_halt): Mark as externally visible.
3845 * xselect.c: Integer signedness and overflow fixes.
3846 (Fx_register_dnd_atom, x_handle_dnd_message):
3847 Use ptrdiff_t, not size_t, since we prefer signed.
3848 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3849 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3850 x_dnd_atoms_size and x_dnd_atoms_length.
3852 * doprnt.c: Prefer signed to unsigned when either works.
3854 * doprnt.c (doprnt):
3856 * xdisp.c (vmessage):
3857 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3858 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3859 prefer signed arithmetic to avoid comparison confusion.
3860 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3861 but is a bit tricky.
3863 Assume freestanding C89 headers, string.h, stdlib.h.
3864 * data.c, doprnt.c, floatfns.c, print.c:
3865 Include float.h unconditionally.
3866 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3867 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3868 * regex.c: Likewise for stddef.h, string.h.
3869 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3870 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3871 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3872 (STDC_HEADERS): Remove obsolete defines.
3873 * sysdep.c: Include limits.h unconditionally.
3875 Assume support for memcmp, memcpy, memmove, memset.
3876 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3877 * regex.c (memcmp, memcpy):
3878 Remove; we assume C89 now.
3880 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3881 (__malloc_safe_bcopy): Remove; no longer needed.
3883 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3884 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3885 well either way, and we prefer signed to unsigned.
3887 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3889 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3890 closes the connection while we're reading (bug#9182).
3892 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3894 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3895 are specified (Bug#9168).
3897 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3899 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3900 Found by GCC static checking and --with-wide-int on a 32-bit host.
3902 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3904 * xdisp.c (compute_display_string_pos): Fix logic of caching
3905 previous display string position. Initialize cached_prev_pos to
3906 -1. Fixes slow-down at the beginning of a buffer.
3908 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3910 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3911 for attrs[LFACE_FONTSET_INDEX].
3913 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3915 * xml.c (parse_region): Remove unused local
3916 that was recently introduced.
3918 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3920 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3921 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3923 * xdisp.c (move_it_in_display_line_to): Record the best matching
3924 position for TO_CHARPOS while scanning the line, and restore it on
3925 exit if none of the characters scanned was an exact match.
3926 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3927 when exact match is impossible due to invisible text, and the
3928 lines are truncated.
3930 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3932 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3935 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3937 Fix a significant slow-down of cursor motion with C-n, C-p,
3938 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3939 auto-repeat under bidi redisplay in fontified buffers.
3940 * xdisp.c (compute_stop_pos_backwards): New function.
3941 (next_element_from_buffer): Call compute_stop_pos_backwards to
3942 find a suitable prev_stop when we find ourselves before
3944 (reseat): Don't look for prev_stop, as that could mean a very long
3946 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3947 <cached_disp_overlay_modiff>: Cache for last found display string
3949 (compute_display_string_pos): Return the cached position if asked
3950 about the same buffer in the same area of character positions, and
3951 the buffer wasn't changed since the time the display string
3952 position was cached.
3954 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3956 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3957 is an integer, which is important for empty lines. (Bug#9149)
3959 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3961 * frame.c (Fmodify_frame_parameters): In tty case, update the
3962 default face if necessary (Bug#4238).
3964 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3966 * editfns.c (Fstring_to_char): No need to explain what a character
3967 is in the docstring (Bug#6576).
3969 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3971 * xml.c (parse_region): Make sure we always return a tree.
3973 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3975 * xml.c (parse_region): If a document contains only comments,
3978 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3980 * xml.c (make_dom): Return comments, too.
3982 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3985 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3986 and the surrounding thread.
3987 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3988 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3989 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3991 * s/openbsd.h (BROKEN_SIGIO): Define.
3992 * unexelf.c (unexec) [__OpenBSD__]:
3993 Don't update the .mdebug section of the Alpha COFF symbol table.
3995 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3997 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
4000 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
4002 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4003 This fixes some race conditions on the permissions of any newly
4006 * alloc.c (valid_pointer_p): Use pipe, not open.
4007 This fixes some permissions issues when debugging.
4009 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4010 If fchown fails to set both uid and gid, try to set just gid,
4011 as that is sometimes allowed. Adjust the file's mode to eliminate
4012 setuid or setgid bits that are inappropriate if fchown fails.
4014 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4016 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4017 to compare Lisp_Objects.
4018 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4019 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4020 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4022 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4024 * lread.c (read_integer): Unread even EOF character.
4025 (read1): Likewise. Properly record start position of symbol.
4027 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4028 symbol character follows.
4030 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4032 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4033 This works around a problem with the previous change to Fcopy_file.
4034 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4035 and without this change, GCC might complain about discarding
4036 fchown's return value.
4038 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
4040 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4042 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4044 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4046 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4048 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4049 it's used from the C level.
4051 * process.c: Use the same condition for POLL_FOR_INPUT in both
4052 keyboard.c and process.c (bug#1858).
4054 2011-07-09 Lawrence Mitchell <wence@gmx.li>
4056 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4057 (Fgnutls_boot): Use it.
4059 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4061 * doc.c (Fsubstitute_command_keys): Revert last change.
4063 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4065 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4066 quotes the next character, and doesn't affect other longer
4067 sequences (bug#8935).
4069 * lread.c (syms_of_lread): Clarify that is isn't only
4070 `eval-buffer' and `eval-defun' that's affected by
4071 `lexical-binding' (bug#8460).
4073 2011-07-15 Eli Zaretskii <eliz@gnu.org>
4075 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
4076 bidi redisplay when a line includes both an image and is truncated.
4078 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4080 Fix minor problems found by static checking.
4081 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4082 (elsz): Now a signed constant, not a size_t var. We prefer signed
4083 types to unsigned, to avoid integer comparison confusion. Without
4084 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4085 "cannot optimize loop, the loop counter may overflow", a symptom
4087 * indent.c (Fvertical_motion): Mark locals as initialized.
4088 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4090 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4092 * search.c (Fre_search_backward): Mention `case-fold-search' in
4093 all the re_search_* functions (bug#8138).
4095 * keyboard.c (Fopen_dribble_file): Document when the file is
4098 2011-07-14 Eli Zaretskii <eliz@gnu.org>
4100 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4103 Support bidi reordering of display and overlay strings.
4104 * xdisp.c (compute_display_string_pos)
4105 (compute_display_string_end): Accept additional argument STRING.
4106 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4107 (reseat_to_string): Initialize bidi_it->string.s and
4108 bidi_it->string.schars.
4109 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
4110 NULL (avoids a crash in bidi_paragraph_init).
4111 Initialize itb.string.lstring.
4112 (init_iterator): Call bidi_init_it only of a valid
4113 buffer position was specified. Initialize paragraph_embedding to
4115 (reseat_to_string): Initialize the bidi iterator.
4116 (display_string): If we need to ignore text properties of
4117 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4118 original value of -1 will not work with bidi.)
4119 (compute_display_string_pos): First arg is now struct
4120 `text_pos *'; all callers changed. Support display properties on
4122 (compute_display_string_end): Support display properties on Lisp
4124 (init_iterator, reseat_1, reseat_to_string): Initialize the
4125 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4126 when iterating on a string not from display properties).
4127 (compute_display_string_pos, compute_display_string_end):
4128 Fix calculation of the object to scan. Fixes an error when using
4130 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
4131 base_level_stop; instead, set base_level_stop to BEGV.
4132 Fixes crashes in vertical-motion.
4133 (next_element_from_buffer): Improve commentary for when
4134 the iterator is before prev_stop.
4135 (init_iterator): Initialize bidi_p from the default value of
4136 bidi-display-reordering, not from buffer-local value. Use the
4137 buffer-local value only if initializing for buffer iteration.
4138 (handle_invisible_prop): Support invisible properties on strings
4139 that are being bidi-reordered.
4140 (set_iterator_to_next): Support bidi reordering of C strings and
4142 (next_element_from_string): Support bidi reordering of Lisp
4144 (handle_stop_backwards): Support Lisp strings as well.
4145 (display_string): Support display of R2L glyph rows.
4146 Use IT_STRING_CHARPOS when displaying from a Lisp string.
4147 (init_iterator): Don't initialize it->bidi_p for strings
4149 (reseat_to_string): Initialize it->bidi_p for strings here.
4150 (next_element_from_string, next_element_from_c_string)
4151 (next_element_from_buffer): Add xassert's for correspondence
4152 between IT's object being iterated and it->bidi_it.string
4154 (face_before_or_after_it_pos): Support bidi iteration.
4155 (next_element_from_c_string): Handle the case of the first string
4156 character that is not the first one in the visual order.
4157 (get_visually_first_element): New function, refactored from common
4158 parts of next_element_from_buffer, next_element_from_string, and
4159 next_element_from_c_string.
4160 (tool_bar_lines_needed, redisplay_tool_bar)
4161 (display_menu_bar): Force left-to-right direction. Add a FIXME
4162 comment for making that be controlled by a user option.
4163 (push_it, pop_it): Save and restore the state of the
4164 bidi iterator. Save and restore the bidi_p flag.
4165 (pop_it): Iterate out of display property for string iteration as
4167 (iterate_out_of_display_property): Support iteration over strings.
4168 (handle_single_display_spec): Set up it->bidi_it for iteration
4169 over a display string, and call bidi_init_it.
4170 (handle_single_display_spec, next_overlay_string)
4171 (get_overlay_strings_1, push_display_prop): Set up the bidi
4172 iterator for displaying display or overlay strings.
4173 (forward_to_next_line_start): Don't use the shortcut if
4175 (back_to_previous_visible_line_start): If handle_display_prop
4176 pushed the iterator stack, restore the internal state of the bidi
4177 iterator by calling bidi_pop_it same number of times.
4178 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4179 and we are bidi-iterating, don't decrement the iterator position;
4180 instead, set the first_elt flag in the bidi iterator, to produce
4182 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4183 (push_display_prop): xassert that we are iterating a buffer.
4184 (push_it, pop_it): Save and restore paragraph_embedding member.
4185 (handle_single_display_spec, next_overlay_string)
4186 (get_overlay_strings_1, reseat_1, reseat_to_string)
4187 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4188 correctly. Don't assume unibyte strings are not bidi-reordered.
4189 (compute_display_string_pos)
4190 (compute_display_string_end): Fix handling the case of C string.
4191 (push_it, pop_it): Save and restore from_disp_prop_p.
4192 (handle_single_display_spec, push_display_prop): Set the
4193 from_disp_prop_p flag.
4194 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4195 (pop_it): Call iterate_out_of_display_property only if we are
4196 popping after iteration over a string that came from a display
4197 property. Fix a typo in popping stretch info. Add an assertion
4198 for verifying that the iterator position is in sync with the bidi
4200 (handle_single_display_spec, get_overlay_strings_1)
4201 (push_display_prop): Fix initialization of paragraph direction for
4202 string when that of the parent object is not yet determined.
4203 (reseat_1): Call bidi_init_it to resync the bidi
4204 iterator with IT's position. (Bug#7616)
4205 (find_row_edges): If ROW->start.pos gives position
4206 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4207 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4208 Reset the from_disp_prop_p flag.
4209 (SAVE_IT, RESTORE_IT): New macros.
4210 (pos_visible_p, face_before_or_after_it_pos)
4211 (back_to_previous_visible_line_start)
4212 (move_it_in_display_line_to, move_it_in_display_line)
4213 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4214 (try_scrolling, redisplay_window, display_line): Use them when
4215 saving a temporary copy of the iterator and restoring it back.
4216 (back_to_previous_visible_line_start, reseat_1)
4217 (init_iterator): Empty the bidi cache "stack".
4218 (move_it_in_display_line_to): If iterator ended up at
4219 EOL, but we never saw any buffer positions smaller than
4220 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4221 motion in bidi-reordered lines.
4222 (move_it_in_display_line_to): Record prev_method and prev_pos
4223 immediately before the call to set_iterator_to_next. Fixes cursor
4224 motion in bidi-reordered lines with stretch glyphs and strings
4225 displayed in margins. (Bug#8133) (Bug#8867)
4226 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4228 (pos_visible_p): Support positions in bidi-reordered lines.
4229 Save and restore bidi cache.
4231 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4232 (bidi_paragraph_info): Delete unused struct.
4233 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4234 (bidi_cache_start): New variable.
4235 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4237 (bidi_cache_fetch_state, bidi_cache_search)
4238 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4239 (bidi_cache_find, bidi_peek_at_next_level)
4240 (bidi_level_of_next_char, bidi_find_other_level_edge)
4241 (bidi_move_to_visually_next): Compare cache index with
4242 bidi_cache_start rather than with zero.
4243 (bidi_fetch_char): Accept new argument STRING; all callers
4244 changed. Support iteration over a string. Support strings with
4245 display properties. Support unibyte strings. Fix the type of
4246 `len' according to what STRING_CHAR_AND_LENGTH expects.
4247 (bidi_paragraph_init, bidi_resolve_explicit_1)
4248 (bidi_resolve_explicit, bidi_resolve_weak)
4249 (bidi_level_of_next_char, bidi_move_to_visually_next):
4250 Support iteration over a string.
4251 (bidi_set_sor_type, bidi_resolve_explicit_1)
4252 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4253 can now be zero (for strings); special values 0 and -1 were
4254 changed to -1 and -2, respectively.
4255 (bidi_char_at_pos): New function.
4256 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4257 Call it instead of FETCH_MULTIBYTE_CHAR.
4258 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4259 initialized to valid values.
4260 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4262 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4263 the test for valid cached positions. Fix the logic for looking up
4264 the sentinel state in the cache. GCPRO the Lisp string we are
4266 (bidi_push_it, bidi_pop_it): New functions.
4267 (bidi_initialize): Initialize the bidi cache start stack pointer.
4268 (bidi_cache_ensure_space): New function, refactored from part of
4269 bidi_cache_iterator_state. Don't assume the required size is just
4270 one BIDI_CACHE_CHUNK away.
4271 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4272 (bidi_count_bytes, bidi_char_at_pos): New functions.
4273 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4274 always valid if bidi_cache_idx is valid.
4275 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4276 is valid if it's going to be used.
4277 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4278 (bidi_cache_fetch_state, bidi_cache_search)
4279 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4280 (bidi_cache_iterator_state, bidi_cache_find)
4281 (bidi_find_other_level_edge, bidi_cache_start_stack):
4282 All variables related to cache indices are now EMACS_INT.
4284 * dispextern.h (struct bidi_string_data): New structure.
4285 (struct bidi_it): New member `string'. Make flag members be 1-bit
4286 fields, and put them last in the struct.
4287 (compute_display_string_pos, compute_display_string_end):
4289 (bidi_push_it, bidi_pop_it): Add prototypes.
4290 (struct iterator_stack_entry): New members bidi_p,
4291 paragraph_embedding, and from_disp_prop_p.
4292 (struct it): Member bidi_p is now a bit field 1 bit wide.
4293 (bidi_shelve_cache, bidi_unshelve_cache):
4296 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4297 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4298 and vector-like objects.
4300 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4301 cache around display iteration.
4303 * window.c (Fwindow_end, window_scroll_pixel_based)
4304 (displayed_window_lines, Frecenter): Save and restore the bidi
4305 cache around display iteration.
4307 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4309 * editfns.c (Fdelete_region): Clarify the use of the named
4310 parameters (bug#6788).
4312 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4314 * indent.c (Fvertical_motion): Set and restore w->pointm when
4315 saving and restoring the window's buffer (Bug#9006).
4317 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4319 * editfns.c (Fstring_to_char): Clarify just what is returned
4320 (bug#6576). Text by Eli Zaretskii.
4322 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4324 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4326 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4328 * buffer.c (mmap_find): Fix a typo.
4330 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4332 Fix execution of x selection hooks.
4333 * xselect.c (Qx_lost_selection_functions)
4334 (Qx_sent_selection_functions): New vars.
4335 (syms_of_xselect): DEFSYM them.
4336 (x_handle_selection_request): Pass Qx_sent_selection_functions
4337 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4338 (x_handle_selection_clear,x_clear_frame_selections):
4339 Pass Qx_lost_selection_functions rather than
4340 Vx_lost_selection_functions to Frun_hook_with_args.
4342 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4344 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4345 The old code sometimes used this field without initializing it.
4347 * alloc.c (gc_sweep): Don't read past end of array.
4348 In theory, the old code could also have corrupted Emacs internals,
4349 though it'd be very unlikely.
4351 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4353 * character.c (Fcharacterp): Don't advertise optional ignored
4354 argument. (Bug#4026)
4356 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4358 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4361 * window.c (Fset_window_start): Doc fix (bug#4199).
4362 (Fset_window_hscroll): Ditto.
4364 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4366 Fix minor new problems caught by GCC 4.6.1.
4367 * term.c (init_tty): Remove unused local.
4368 * xsettings.c (store_monospaced_changed): Define this function only
4369 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4372 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4374 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4376 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4378 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4379 are the mini-buffer and the echo area (bug#3320).
4381 * term.c (init_tty): Remove support for supdup, c10 and perq
4382 terminals, which are no longer supported (bug#1482).
4384 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4386 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4388 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4390 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4391 for non-popups (Bug#3642).
4393 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4395 * alloc.c (reset_malloc_hooks): Protoize.
4396 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4397 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4398 * cm.c (losecursor): Likewise.
4399 * data.c (fmod): Likewise.
4400 * dispnew.c (swap_glyphs_in_rows): Likewise.
4401 * emacs.c (memory_warning_signal): Likewise.
4402 * floatfns.c (float_error): Likewise.
4403 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4404 (otf_open, font_otf_capability, generate_otf_features)
4405 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4407 * image.c (pbm_read_file): Likewise.
4408 * indent.c (string_display_width): Likewise.
4409 * intervals.c (check_for_interval, search_for_interval)
4410 (inc_interval_count, count_intervals, root_interval)
4411 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4412 * lread.c (defalias): Likewise.
4413 * ralloc.c (r_alloc_check): Likewise.
4414 * regex.c (set_image_of_range_1, set_image_of_range)
4415 (regex_grow_registers): Likewise.
4416 * sysdep.c (strerror): Likewise.
4417 * termcap.c (valid_filename_p, tprint, main): Likewise.
4418 * tparam.c (main): Likewise.
4419 * unexhp9k800.c (run_time_remap, save_data_space)
4420 (update_file_ptrs, read_header, write_header, calculate_checksum)
4421 (copy_file, copy_rest, display_header): Likewise.
4422 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4424 * xdisp.c (check_it): Likewise.
4425 * xfaces.c (register_color, unregister_color, unregister_colors):
4427 * xfns.c (print_fontset_result): Likewise.
4428 * xrdb.c (member, fatal, main): Likewise.
4430 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4432 Fix minor problems found by static checking (Bug#9031).
4433 * chartab.c (char_table_set_range, map_sub_char_table):
4434 Remove unused locals.
4435 (uniprop_table): Now static.
4436 * composite.c (_work_char): Remove unused static var.
4438 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4440 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4442 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4444 * gtkutil.c (qttip_cb): Remove code without function.
4446 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4448 * w32.c (pthread_sigmask): New stub.
4450 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4452 Use pthread_sigmask, not sigprocmask (Bug#9010).
4453 sigprocmask is portable only for single-threaded applications, and
4454 Emacs can be multi-threaded when it uses GTK.
4455 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4457 * callproc.c (Fcall_process):
4458 * process.c (create_process):
4459 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4460 Use pthread_sigmask, not sigprocmask.
4462 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4464 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4465 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4468 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4470 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4471 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4472 (xg_hide_tooltip): Fix comment.
4474 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4475 in registerServicesMenuSendTypes.
4476 (validRequestorForSendType): Don't check ns_return_types.
4478 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4481 2011-07-08 Jason Rumney <jasonr@gnu.org>
4483 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4484 SH_SHOW for hidden windows (Bug#5482).
4486 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4487 frame struct members of non-existent frames (Bug#6284).
4489 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4491 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4492 variable firstTime not needed on OSX >= 10.6.
4493 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4494 >= 10.5. Use setKnobProportion, setDoubleValue.
4496 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4497 (MAC_OS_X_VERSION_10_5): Define if not defined.
4498 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4499 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4500 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4502 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4503 cString and lossyCString on OSX >= 10.4
4505 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4506 sizeToFit on OSX >= 10.2.
4508 * nsimage.m (allocInitFromFile): Don't use deprecated method
4509 bestRepresentationForDevice on OSX >= 10.6.
4511 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4514 * emacs.c: Declare unexec_init_emacs_zone.
4516 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4518 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4520 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4521 on svcsMenu (Bug#8842).
4523 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4525 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4527 * nsterm.m (QUTF8_STRING): Declare.
4528 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4529 (validRequestorForSendType): Return type is (id).
4530 Change indexOfObjectIdenticalTo to indexOfObject.
4531 Check if we have local selection before returning self (Bug#8842).
4532 (writeSelectionToPasteboard): Put local selection into paste board
4533 if we have a local selection (Bug#8842).
4534 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4536 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4537 (ns_get_local_selection): Declare.
4539 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4541 * keymap.c (describe_map_tree): Don't insert a double newline at
4542 the end of the buffer (bug#1169) and return whether we inserted
4545 * callint.c (Fcall_interactively): Change "reading args" to
4546 "providing args" to try to clarify what it does (bug#1010).
4548 2011-07-07 Kenichi Handa <handa@m17n.org>
4550 * composite.c (composition_compute_stop_pos): Ignore a static
4551 composition starting before CHARPOS (Bug#8915).
4553 * xdisp.c (handle_composition_prop): Likewise.
4555 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4557 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4560 2011-07-07 Kenichi Handa <handa@m17n.org>
4562 * character.h (unicode_category_t): New enum type.
4564 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4565 (Qchar_code_property_table): New variable.
4566 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4567 (UNIPROP_COMPRESSED_FORM_P): New macros.
4568 (char_table_ascii): Uncompress the compressed values.
4569 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4570 Uncompress the compressed values.
4571 (sub_char_table_ref_and_range): Likewise.
4572 (char_table_ref_and_range): Uncompress the compressed values.
4573 (sub_char_table_set): New arg is_uniprop. Callers changed.
4574 Uncompress the compressed values.
4575 (sub_char_table_set_range): Args changed. Callers changed.
4576 (char_table_set_range): Adjuted for the above change.
4577 (map_sub_char_table): Delete args default_val and parent. Add arg
4578 top. Give decoded values to a Lisp function.
4579 (map_char_table): Adjust for the above change. Give decoded
4580 values to a Lisp function. Gcpro more variables.
4581 (uniprop_table_uncompress)
4582 (uniprop_decode_value_run_length): New functions.
4583 (uniprop_decoder, uniprop_decoder_count): New variables.
4584 (uniprop_get_decoder, uniprop_encode_value_character)
4585 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4587 (uniprop_encoder, uniprop_encoder_count): New variables.
4588 (uniprop_get_encoder, uniprop_table)
4589 (Funicode_property_table_internal, Fget_unicode_property_internal)
4590 (Fput_unicode_property_internal): New functions.
4591 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4592 Sunicode_property_table_internal, Sget_unicode_property_internal,
4593 and Sput_unicode_property_internal. Defvar_lisp
4594 char-code-property-alist.
4596 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4597 Vunicode_category_table.
4599 * font.c (font_range): Adjust for the change of
4600 Vunicode_category_table.
4602 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4604 * m/iris4d.h: Remove file, move contents ...
4605 * s/irix6-5.h: ... here.
4607 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4609 Remove unportable assumption about struct layout (Bug#8884).
4610 * alloc.c (mark_buffer):
4611 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4612 (clone_per_buffer_values): Don't assume that
4613 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4614 This isn't true in general, and it's particularly not true
4615 if Emacs is configured with --with-wide-int.
4616 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4617 New macros, used in the buffer.c change.
4619 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4621 * xsettings.c: Use both GConf and GSettings if both are available.
4622 (store_config_changed_event): Add comment.
4623 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4624 (store_tool_bar_style_changed): New functions.
4625 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4626 (struct xsettings): Move font inside HAVE_XFT.
4627 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4628 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4629 Move inside HAVE_XFT.
4630 (something_changed_gsettingsCB): Rename from something_changedCB.
4631 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4633 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4634 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4635 (something_changed_gconfCB): Rename from something_changedCB.
4636 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4637 (parse_settings): Move check for font inside HAVE_XFT.
4638 (read_settings, apply_xft_settings): Add comment.
4639 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4640 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4641 call store_font_name_changed.
4642 (xft_settings_event): Add comment.
4643 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4644 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4645 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4646 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4647 (xsettings_initialize): Call init_gsettings last.
4648 (xsettings_get_system_font, xsettings_get_system_normal_font):
4651 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4653 Random fixes. E.g., (random) never returned negative values.
4654 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4655 subseconds part to the entropy, as that's a bit more random.
4656 Prefer signed to unsigned, since the signedness doesn't matter and
4657 in general we prefer signed. When given a limit, use a
4658 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4659 latter isn't right if USE_2_TAGS_FOR_INTS.
4660 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4661 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4663 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4665 * textprop.c (text_property_stickiness):
4666 Obey Vtext_property_default_nonsticky.
4667 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4668 * w32fns.c (syms_of_w32fns):
4669 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4671 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4673 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4674 This is more efficient than Ffile_directory_p and avoids a minor race.
4676 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4678 * buffer.c (Foverlay_put): Say what the return value is
4681 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4682 is a directory before asking whether to use the file name
4684 (barf_or_query_if_file_exists): Make the "File is a directory"
4685 error be more correct.
4687 * fns.c (Frequire): Remove the mention of the .gz files, since
4688 that's installation-specific, but keep the mention of
4689 `get-load-suffixes'.
4691 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4693 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4694 Report string overflow if the output is too long.
4696 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4698 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4699 (syms_of_gnutls): Remove duplicate DEFSYM for
4700 Qgnutls_bootprop_verify_hostname_error, an error for
4701 Qgnutls_bootprop_verify_error (which is no longer used).
4703 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4704 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4705 Also (re)move comments that are misplaced or no longer relevant.
4707 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4709 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4711 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4713 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4714 and background color parameters if they have been changed.
4716 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4718 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4720 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4722 * xsettings.c (SYSTEM_FONT): Define only when used.
4723 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4725 * keymap.c (access_keymap_1): Now static.
4727 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4729 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4730 leave any prefix arg for the up event (Bug#1586).
4732 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4734 * lread.c (syms_of_lread): Mention single symbols defined by
4735 `defvar' or `defconst' (bug#7154).
4737 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4738 (Frequire): Mention get-load-suffixes.
4740 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4742 * window.h (window): Remove clone_number slot.
4743 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4745 (make_parent_window, make_window, saved_window)
4746 (Fset_window_configuration, save_window_save): Don't deal with
4748 * buffer.c (Qclone_number): Remove declaration.
4749 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4751 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4753 Add multiple inheritance to keymaps.
4754 * keymap.c (Fmake_composed_keymap): New function.
4755 (Fset_keymap_parent): Simplify.
4756 (fix_submap_inheritance): Remove.
4757 (access_keymap_1): New function extracted from access_keymap to handle
4758 embedded parents and handle lists of maps.
4759 (access_keymap): Use it.
4760 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4761 (Fcopy_keymap): Handle embedded parents.
4762 (Fcommand_remapping, define_as_prefix): Simplify.
4763 (Fkey_binding): Simplify.
4764 (syms_of_keymap): Move minibuffer-local-completion-map,
4765 minibuffer-local-filename-completion-map,
4766 minibuffer-local-must-match-map, and
4767 minibuffer-local-filename-must-match-map to Elisp.
4768 (syms_of_keymap): Defsubr make-composed-keymap.
4769 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4770 (parse_menu_item): Trivial simplification.
4772 2011-07-01 Glenn Morris <rgm@gnu.org>
4774 * Makefile.in (SETTINGS_LIBS): Fix typo.
4776 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4778 * coding.c (Fencode_coding_string): Record the last coding system
4779 used, as the function doc string says (bug#8738).
4781 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4783 * xsettings.c (store_monospaced_changed): Take new font as arg and
4784 check for change against current_mono_font.
4785 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4786 (emacs_settings_constructor, emacs_settings_get_property)
4787 (emacs_settings_set_property, emacs_settings_class_init)
4788 (emacs_settings_init, gsettings_obj): Remove.
4789 (something_changedCB): New function for HAVE_GSETTINGS.
4790 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4791 with value as argument.
4792 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4793 g_settings_new (Bug#8967). Do not create gsettings_obj.
4794 Remove calls to g_settings_bind. Connect something_changedCB to
4797 * xgselect.c: Add defined (HAVE_GSETTINGS).
4798 (xgselect_initialize): Ditto.
4800 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4801 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4804 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4806 * eval.c (struct backtrace): Simplify and port the data structure.
4807 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4808 signed bit field, as this assumption is not portable and it makes
4809 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4810 "char debug_on_exit : 1" as this is not portable either; instead,
4811 use the portable "unsigned int debug_on_exit : 1". Remove unused
4812 member evalargs. Remove obsolete comments about cc bombing out.
4814 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4816 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4817 Let HAVE_GSETTINGS override HAVE_GCONF.
4818 (store_monospaced_changed): New function.
4819 (EMACS_SETTINGS): A new type derived from GObject to handle
4820 GSettings notifications.
4821 (emacs_settings_constructor, emacs_settings_get_property)
4822 (emacs_settings_set_property, emacs_settings_class_init):
4824 (gsettings_client, gsettings_obj): New variables.
4825 (GSETTINGS_SCHEMA): New define.
4826 (something_changedCB): Call store_monospaced_changed.
4827 (init_gsettings): New function.
4828 (xsettings_initialize): Call init_gsettings.
4829 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4832 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4835 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4837 * window.c (resize_root_window, grow_mini_window)
4838 (shrink_mini_window): Rename Qresize_root_window to
4839 Qwindow_resize_root_window and Qresize_root_window_vertically to
4840 Qwindow_resize_root_window_vertically.
4842 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4844 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4846 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4848 * makefile.w32-in: Redesign dependencies so they reflect more
4849 clearly which files are directly included by each source file,
4850 and not through other includes.
4852 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4854 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4855 (sort_overlays, overlay_strings): When an overlay's clone number
4856 matches the window's clone number process the overlay even if
4857 the overlay's window property doesn't match the current window.
4859 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4860 (Fwindow_hchild): Rename to Fwindow_left_child.
4861 (Fwindow_next): Rename to Fwindow_next_sibling.
4862 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4863 (resize_window_check): Rename to window_resize_check.
4864 (resize_window_apply): Rename to window_resize_apply.
4865 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4866 (Fdelete_other_windows_internal, resize_frame_windows)
4867 (Fsplit_window_internal, Fdelete_window_internal)
4868 (grow_mini_window, shrink_mini_window)
4869 (Fresize_mini_window_internal): Fix callers accordingly.
4871 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4873 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4874 (emacs_fixed_set_min_size): Remove.
4875 (emacs_fixed_new): Take frame as argument.
4877 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4878 (_EmacsFixedPrivate): Remove minwidth/height.
4879 Add struct frame *f.
4880 (emacs_fixed_init): Initialize priv->f.
4881 (get_parent_class, emacs_fixed_set_min_size): Remove.
4882 (emacs_fixed_new): Set priv->f to argument.
4883 (emacs_fixed_get_preferred_width)
4884 (emacs_fixed_get_preferred_height): Use min_width/height from
4885 frames size_hint to set minimum and natural (Bug#8919).
4886 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4887 and use min_width/height from frames size_hint to set
4888 min_width/height (Bug#8919).
4890 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4891 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4894 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4896 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4897 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4900 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4902 * process.c (wait_reading_process_output): Bypass select if
4903 waiting for a cell while ignoring keyboard input, and input is
4904 pending. Suggested by Jan Djärv (Bug#8869).
4906 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4908 Use gnulib's dup2 module instead of rolling our own.
4909 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4911 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4913 * dispnew.c (scrolling_window): Before scrolling, turn off a
4914 mouse-highlight in the window being scrolled.
4916 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4918 Move DEFSYM to lisp.h and use everywhere.
4920 * character.h (DEFSYM): Move declaration...
4921 * lisp.h (DEFSYM): ...here.
4927 * w32select.c: Don't include character.h.
4929 * alloc.c (syms_of_alloc):
4930 * buffer.c (syms_of_buffer):
4931 * bytecode.c (syms_of_bytecode):
4932 * callint.c (syms_of_callint):
4933 * casefiddle.c (syms_of_casefiddle):
4934 * casetab.c (init_casetab_once):
4935 * category.c (init_category_once, syms_of_category):
4936 * ccl.c (syms_of_ccl):
4937 * cmds.c (syms_of_cmds):
4938 * composite.c (syms_of_composite):
4939 * dbusbind.c (syms_of_dbusbind):
4940 * dired.c (syms_of_dired):
4941 * dispnew.c (syms_of_display):
4942 * doc.c (syms_of_doc):
4943 * editfns.c (syms_of_editfns):
4944 * emacs.c (syms_of_emacs):
4945 * eval.c (syms_of_eval):
4946 * fileio.c (syms_of_fileio):
4947 * fns.c (syms_of_fns):
4948 * frame.c (syms_of_frame):
4949 * fringe.c (syms_of_fringe):
4950 * insdel.c (syms_of_insdel):
4951 * keymap.c (syms_of_keymap):
4952 * lread.c (init_obarray, syms_of_lread):
4953 * macros.c (syms_of_macros):
4954 * msdos.c (syms_of_msdos):
4955 * print.c (syms_of_print):
4956 * process.c (syms_of_process):
4957 * search.c (syms_of_search):
4958 * sound.c (syms_of_sound):
4959 * syntax.c (init_syntax_once, syms_of_syntax):
4960 * terminal.c (syms_of_terminal):
4961 * textprop.c (syms_of_textprop):
4962 * undo.c (syms_of_undo):
4963 * w32.c (globals_of_w32):
4964 * window.c (syms_of_window):
4965 * xdisp.c (syms_of_xdisp):
4966 * xfaces.c (syms_of_xfaces):
4967 * xfns.c (syms_of_xfns):
4968 * xmenu.c (syms_of_xmenu):
4969 * xsettings.c (syms_of_xsettings):
4970 * xterm.c (syms_of_xterm): Use DEFSYM.
4972 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4974 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4976 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4978 Integer and buffer overflow fixes (Bug#8873).
4980 * print.c (printchar, strout): Check for string overflow.
4981 (PRINTPREPARE, printchar, strout):
4982 Don't set size unless allocation succeeds.
4984 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4985 for sizes. Check for string overflow more accurately.
4986 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4988 * macros.c: Integer and buffer overflow fixes.
4989 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4990 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4991 Use ptrdiff_t, not int, for sizes.
4992 Don't increment bufsize until after realloc succeeds.
4993 Check for size-calculation overflow.
4994 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4996 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4998 * lread.c: Integer overflow fixes.
4999 (read_integer): Radix is now EMACS_INT, not int,
5000 to improve quality of diagnostics for out-of-range radices.
5001 Calculate buffer size correctly for out-of-range radices.
5002 (read1): Check for integer overflow in radices, and in
5003 read-circle numbers.
5004 (read_escape): Avoid int overflow.
5005 (Fload, openp, read_buffer_size, read1)
5006 (substitute_object_recurse, read_vector, read_list, map_obarray):
5007 Use ptrdiff_t, not int, for sizes.
5008 (read1): Use EMACS_INT, not int, for sizes.
5009 Check for size overflow.
5011 * image.c (cache_image): Check for size arithmetic overflow.
5013 * lread.c: Integer overflow issues.
5014 (saved_doc_string_size, saved_doc_string_length)
5015 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5016 Now ptrdiff_t, not int.
5017 (read1): Don't assume doc string length fits in int. Check for
5018 out-of-range doc string lengths.
5019 (read_list): Don't assume file position fits in int.
5020 (read_escape): Check for hex character overflow.
5022 2011-06-22 Leo Liu <sdl.web@gmail.com>
5024 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5025 Move to minibuffer.el.
5027 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5029 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
5030 The following patches are for when GLYPH_DEBUG && !XASSERT.
5031 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5032 * dispnew.c (flush_stdout):
5033 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5034 Mark as externally visible.
5035 * dispnew.c (check_window_matrix_pointers): Now static.
5036 * dispnew.c (window_to_frame_vpos):
5037 * xfns.c (unwind_create_frame):
5038 * xterm.c (x_check_font): Remove unused local.
5039 * scroll.c (CHECK_BOUNDS):
5040 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5041 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5042 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5043 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5044 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5046 (debug_method_add): Use va_list and vsprintf rather than relying
5047 on undefined behavior with wrong number of arguments.
5048 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5049 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5050 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5051 since we're not interested in debugging glyphs with old libraries.
5052 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5053 GCC 4.6.0's static checking.
5055 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5057 Integer overflow and signedness fixes (Bug#8873).
5058 A few related buffer overrun fixes, too.
5060 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5062 * dispextern.h (struct face.stipple):
5063 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5064 (x_bitmap_mask, x_allocate_bitmap_record)
5065 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5066 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5067 (x_create_bitmap_from_xpm_data):
5068 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5069 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5071 * xfaces.c (load_pixmap):
5072 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5073 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5074 (.bitmaps_last, struct x_output.icon_bitmap):
5075 Use ptrdiff_t, not int, for bitmap indexes.
5076 (x_allocate_bitmap_record): Check for size overflow.
5077 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5079 Use ptrdiff_t, not int, for overlay counts.
5080 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5081 * editfns.c (overlays_around, get_pos_property):
5082 * textprop.c (get_char_property_and_overlay):
5083 * xdisp.c (next_overlay_change, note_mouse_highlight):
5084 * xfaces.c (face_at_buffer_position):
5085 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5086 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5087 (Fnext_overlay_change, Fprevious_overlay_change)
5088 (mouse_face_overlay_overlaps, Foverlays_in):
5089 Use ptrdiff_t, not int, for sizes.
5090 (overlays_at, overlays_in): Check for size-calculation overflow.
5092 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5094 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5095 (x_session_initialize): Do not assume string length fits in int.
5097 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5098 This is unlikely, but can occur if DPI is outlandish.
5100 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
5101 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5103 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5104 * xrdb.c (magic_file_p, search_magic_path):
5105 Omit last arg SUFFIX; it was always 0. All callers changed.
5106 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5108 * xfont.c (xfont_match): Avoid need for strlen.
5110 * xfns.c: Don't assume strlen fits in int.
5111 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5113 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5114 not unsigned long, as we prefer signed integers. All callers changed.
5115 Detect integer overflow in repeat count.
5116 (message_dolog): Don't assume print length fits in 39 bytes.
5117 (display_mode_element): Don't assume strlen fits in int.
5119 * termcap.c: Don't assume sizes fit in int and never overflow.
5120 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5121 (gobble_line): Check for size-calculation overflow.
5123 * minibuf.c (Fread_buffer):
5124 * lread.c (intern, intern_c_string):
5125 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5126 Don't assume string length fits in int.
5128 * keyboard.c (parse_tool_bar_item):
5129 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5131 * font.c: Don't assume string length fits in int.
5132 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5133 Use ptrdiff_t, not int.
5134 (font_intern_prop): Don't assume string length fits in int.
5135 Don't assume integer property fits in fixnum.
5136 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
5138 * filelock.c: Fix some buffer overrun and integer overflow issues.
5139 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
5140 Reformulate so as not to need the command string.
5141 Invoke gzip -cd rather than gunzip, as it's more portable.
5142 (lock_info_type, lock_file_1, lock_file):
5143 Don't assume pid_t and time_t fit in unsigned long.
5144 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5145 (current_lock_owner): Prefer signed type for sizes.
5146 Use memcpy, not strncpy, where memcpy is what is really wanted.
5147 Don't assume (via atoi) that time_t and pid_t fit in int.
5148 Check for time_t and/or pid_t out of range, e.g., via a network share.
5149 Don't alloca where an auto var works fine.
5151 * fileio.c: Fix some integer overflow issues.
5152 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5153 Don't assume string length fits in int.
5154 (directory_file_name): Don't assume string length fits in long.
5155 (make_temp_name): Don't assume pid fits in int, or that its print
5156 length is less than 20.
5158 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5160 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5162 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5164 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5165 We prefer signed integers, even for size calculations.
5167 * emacs.c: Don't assume string length fits in 'int'.
5168 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5169 (main): Don't invoke strlen when not needed.
5171 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5172 (XD_DEBUG_MESSAGE): Don't waste a byte.
5174 * callproc.c (getenv_internal_1, getenv_internal)
5176 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5178 * lread.c (invalid_syntax): Omit length argument.
5179 All uses changed. This doesn't fix a bug, but it simplifies the
5180 code away from its former Hollerith-constant appearance, and it's
5181 one less 'int' to worry about when looking at integer-overflow issues.
5182 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5184 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5185 This didn't break anything, but it didn't help either.
5186 It's confusing to put a bogus integer in a place where the actual
5187 value does not matter.
5188 (LIST_END_P): Remove unused macro and its bogus comment.
5189 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5191 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5192 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5194 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5195 We prefer signed types, and the value cannot exceed the EMACS_INT
5196 range anyway (because otherwise the length would not be representable).
5197 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5198 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5199 This avoids a GCC warning when WIDE_EMACS_INT.
5201 * indent.c (sane_tab_width): New function.
5202 (current_column, scan_for_column, Findent_to, position_indentation)
5203 (compute_motion): Use it. This is just for clarity.
5204 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5206 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5208 * lisp.h (lint_assume): New macro.
5209 * composite.c (composition_gstring_put_cache):
5210 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5212 * editfns.c, insdel.c:
5213 Omit unnecessary forward decls, to simplify future changes.
5215 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5217 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5219 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5220 Use much-faster test for byte-length change.
5221 Don't assume string byte-length fits in 'int'.
5222 Check that character arg fits in 'int'.
5223 (mapcar1): Declare byte as byte, for clarity.
5225 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5227 * fns.c (concat): Catch string overflow earlier.
5228 Do not rely on integer wraparound.
5230 * dispextern.h (struct it.overlay_strings_charpos)
5231 (struct it.selective): Now EMACS_INT, not int.
5232 * xdisp.c (forward_to_next_line_start)
5233 (back_to_previous_visible_line_start)
5234 (reseat_at_next_visible_line_start, next_element_from_buffer):
5235 Don't arbitrarily truncate the value of 'selective' to int.
5237 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5239 * composite.c: Don't truncate sizes to 'int'.
5240 (composition_gstring_p, composition_reseat_it)
5241 (composition_adjust_point): Use EMACS_INT, not int.
5242 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5243 not EMACS_UINT, for indexes.
5245 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5247 * buffer.c: Include <verify.h>.
5248 (struct sortvec.priority, struct sortstr.priority):
5249 Now EMACS_INT, not int.
5250 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5251 (struct sortstr.size, record_overlay_string)
5252 (struct sortstrlist.size, struct sortlist.used):
5253 Don't truncate size to int.
5254 (record_overlay_string): Check for size-calculation overflow.
5255 (init_buffer_once): Check at compile-time, not run-time.
5257 2011-06-22 Jim Meyering <meyering@redhat.com>
5259 Don't leak an XBM-image-sized buffer
5260 * image.c (xbm_load): Free the image buffer after using it.
5262 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5265 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5266 that Sun C diagnosed.
5267 * fns.c (secure_hash): Fix pointer signedness issue.
5268 * intervals.c (static_offset_intervals): New function.
5269 (offset_intervals): Use it.
5271 2011-06-21 Leo Liu <sdl.web@gmail.com>
5274 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5277 * fns.c (secure_hash): Rename from crypto_hash_function and change
5278 the first arg to accept symbols.
5279 (Fsecure_hash): New primitive.
5280 (syms_of_fns): New symbols.
5282 2011-06-20 Deniz Dogan <deniz@dogan.se>
5284 * process.c (Fset_process_buffer): Clarify return value in
5287 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5289 * dispnew.c (add_window_display_history): Use BVAR.
5291 * xdisp.c (debug_method_add): Use BVAR.
5292 (check_window_end, dump_glyph_matrix, dump_glyph)
5293 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5295 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5298 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5299 check till after the cache is created in init_frame_faces.
5301 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5303 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5305 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5307 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5308 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5309 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5311 Improve buffer-overflow checking (Bug#8873).
5312 * fileio.c (Finsert_file_contents):
5313 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5314 Remove the old (too-loose) buffer overflow checks.
5315 They weren't needed, since make_gap checks for buffer overflow.
5316 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5317 The old code merely checked for Emacs fixnum overflow, and relied
5318 on undefined (wraparound) behavior. The new code avoids undefined
5319 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5321 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5322 Tune. Don't use wider integers than needed. Don't use alloca.
5323 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5325 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5327 * insdel.c, lisp.h (buffer_overflow): New function.
5328 (insert_from_buffer_1, replace_range, replace_range_2):
5329 * insdel.c (make_gap_larger):
5330 * editfns.c (Finsert_char):
5331 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5333 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5335 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5337 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5339 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5340 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5342 * fileio.c: Don't assume EMACS_INT fits in off_t.
5343 (emacs_lseek): New static function.
5344 (Finsert_file_contents, Fwrite_region): Use it.
5345 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5347 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5349 * fns.c: Don't overflow int when computing a list length.
5350 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5351 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5352 truncation on 64-bit hosts. Check for QUIT every
5353 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5354 faster and is responsive enough.
5355 (Flength): Report an error instead of overflowing an integer.
5356 (Fsafe_length): Return a float if the value is not representable
5357 as a fixnum. This shouldn't happen except in contrived situations.
5358 (Fnthcdr, Fsort): Don't assume list length fits in int.
5359 (Fcopy_sequence): Don't assume vector length fits in int.
5361 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5362 (header_size, word_size): New constants.
5363 (allocate_vectorlike): Don't check size overflow here.
5364 (allocate_vector): Check it here instead, since this is the only
5365 caller of allocate_vectorlike that could cause overflow.
5366 Check that the new vector's length is representable as a fixnum.
5368 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5369 The previous code was bogus. For example, next_almost_prime (32)
5370 returned 39, which is undesirable as it is a multiple of 3; and
5371 next_almost_prime (24) returned 25, which is a multiple of 5 so
5372 why was the code bothering to check for multiples of 7?
5374 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5376 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5378 Variadic C functions now count arguments with ptrdiff_t.
5379 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5380 Back then I didn't know that the Emacs coding style prefers signed int.
5381 Also, in the meantime I found a few more instances where arguments
5382 were being counted with int, which may truncate counts on 64-bit
5383 machines, or EMACS_INT, which may be unnecessarily wide.
5384 * lisp.h (struct Lisp_Subr.function.aMANY)
5385 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5386 Arg counts are now ptrdiff_t, not size_t.
5387 All variadic functions and their callers changed accordingly.
5388 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5389 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5390 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5391 * callint.c (Fcall_interactively): Check arg count for overflow,
5392 to avoid potential buffer overrun. Use signed char, not 'int',
5393 for 'varies' array, so that we needn't bother to check its size
5394 calculation for overflow.
5395 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5396 * eval.c (apply_lambda):
5397 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5398 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5399 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5401 * callint.c (Fcall_interactively): Don't use index var as event count.
5403 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5404 * mem-limits.h (SIZE): Remove; no longer used.
5406 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5408 Remove unnecessary casts.
5409 * xterm.c (x_term_init):
5410 * xfns.c (x_set_border_pixel):
5411 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5412 These aren't needed now that we assume ANSI C.
5414 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5415 It's more likely to cause problems (due to unsigned overflow)
5418 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5420 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5422 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5424 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5426 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5428 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5430 GLYPH_CODE_FACE returns EMACS_INT, not int.
5431 * dispextern.h (merge_faces):
5432 * xfaces.c (merge_faces):
5433 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5434 Don't assume EMACS_INT fits in int.
5436 * character.h (CHAR_VALID_P): Remove unused parameter.
5437 * fontset.c, lisp.h, xdisp.c: All uses changed.
5439 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5441 * fns.c (concat): Minor tuning based on overflow analysis.
5442 This doesn't fix any bugs. Use int to hold character, instead
5443 of constantly refetching from Emacs object. Use XFASTINT, not
5444 XINT, for value known to be a character. Don't bother comparing
5445 a single byte to 0400, as it's always less.
5447 * floatfns.c (Fexpt):
5448 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5450 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5453 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5455 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5456 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5457 incorrectly succeed when S was a string, because 4294967386 was
5458 truncated before it was used.
5460 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5461 Otherwise, an out-of-range integer could cause undefined behavior
5464 * composite.c: Use int, not EMACS_INT, for characters.
5465 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5466 EMACS_INT, for values that are known to be in character range.
5467 This doesn't fix any bugs but is the usual style inside Emacs and
5468 may generate better code on 32-bit machines.
5470 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5471 This is for reasons similar to the recent CHAR_STRING fix.
5472 * charset.c (Fencode_char): Check that character arg is actually
5473 a character. Pass an int to ENCODE_CHAR.
5474 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5475 wider than 'int', as a compile-time check to prevent future regressions
5478 * character.c (char_string): Remove unnecessary casts.
5480 Make sure a 64-bit char is never passed to CHAR_STRING.
5481 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5482 by silently ignoring the top 32 bits, allowing some values
5483 that were far too large to be valid characters.
5484 * character.h: Include <verify.h>.
5485 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5486 arguments are no wider than unsigned, as a compile-time check
5487 to prevent future regressions in this area.
5489 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5490 (Fsubst_char_in_region):
5492 * xdisp.c (decode_mode_spec_coding):
5493 Adjust to CHAR_STRING's new requirement.
5494 * editfns.c (Finsert_char, Fsubst_char_in_region):
5495 * fns.c (concat): Check that character args are actually
5496 characters. Without this test, these functions did the wrong
5497 thing with wildly out-of-range values on 64-bit hosts.
5499 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5500 These casts should not be needed on 32-bit hosts, either.
5501 * keyboard.c (read_char):
5502 * lread.c (Fload): Remove casts to unsigned.
5504 * lisp.h (UNSIGNED_CMP): New macro.
5505 This fixes comparison bugs on 64-bit hosts.
5506 (ASCII_CHAR_P): Use it.
5507 * casefiddle.c (casify_object):
5508 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5509 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5510 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5511 * dispextern.h (FACE_FROM_ID):
5512 * keyboard.c (read_char): Use UNSIGNED_CMP.
5514 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5515 not to EMACS_INT, to avoid GCC warning.
5517 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5519 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5520 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5521 isn't needed on 32-bit machines.
5523 * buffer.c (Fgenerate_new_buffer_name):
5524 Use EMACS_INT for count, not int.
5525 (advance_to_char_boundary): Return EMACS_INT, not int.
5527 * data.c (Qcompiled_function): Now static.
5529 * window.c (window_body_lines): Now static.
5531 * image.c (gif_load): Rename local to avoid shadowing.
5533 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5534 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5535 * alloc.c (make_save_value): Integer argument is now of type
5537 (mark_object): Use ptrdiff_t, not int.
5538 * lisp.h (pD): New macro.
5539 * print.c (print_object): Use it.
5541 * alloc.c: Use EMACS_INT, not int, to count objects.
5542 (total_conses, total_markers, total_symbols, total_vector_size)
5543 (total_free_conses, total_free_markers, total_free_symbols)
5544 (total_free_floats, total_floats, total_free_intervals)
5545 (total_intervals, total_strings, total_free_strings):
5546 Now EMACS_INT, not int. All uses changed.
5547 (Fgarbage_collect): Compute overall total using a double, so that
5548 integer overflow is less likely to be a problem. Check for overflow
5549 when converting back to an integer.
5550 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5551 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5552 These were 'int' variables that could overflow on 64-bit hosts;
5553 they were never used, so remove them instead of repairing them.
5554 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5555 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5556 Previously, this ceilinged at INT_MAX, but that doesn't work on
5558 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5560 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5561 (allocate_vectorlike): Check for ptrdiff_t overflow.
5562 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5563 when a (possibly-narrower) signed value would do just as well.
5564 We prefer using signed arithmetic, to avoid comparison confusion.
5566 * alloc.c: Catch some string size overflows that we were missing.
5567 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5568 for convenience in STRING_BYTES_MAX.
5569 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5570 The definition here is exact; the one in lisp.h was approximate.
5571 (allocate_string_data): Check for string overflow. This catches
5572 some instances we weren't catching before. Also, it catches
5573 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5574 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5575 and ptrdiff_t and EMACS_INT are both 64 bits.
5577 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5578 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5579 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5581 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5583 * alloc.c (Fmake_string): Check for out-of-range init.
5585 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5587 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5589 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5591 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5592 xg_get_default_scrollbar_width.
5594 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5595 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5596 (style_changed_cb): Call update_theme_scrollbar_width and call
5597 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5598 all frames (Bug#8505).
5599 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5600 Call gtk_window_set_resizable if HAVE_GTK3.
5601 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5602 and height if HAVE_GTK3 (Bug#8505).
5603 (scroll_bar_width_for_theme): New variable.
5604 (update_theme_scrollbar_width): New function.
5605 (xg_get_default_scrollbar_width): Move code to
5606 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5607 (xg_initialize): Call update_theme_scrollbar_width.
5609 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5611 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5613 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5615 * frame.c (make_frame): Call other_buffer_safely instead of
5618 * window.c (temp_output_buffer_show): Call display_buffer with
5619 second argument Vtemp_buffer_show_specifiers and reset latter
5620 immediately after the call.
5621 (Vtemp_buffer_show_specifiers): New variable.
5622 (auto_window_vscroll_p, next_screen_context_lines)
5623 (Vscroll_preserve_screen_position): Remove leading asterisks from
5626 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5628 Fix minor problems found by GCC 4.6.0 static checking.
5629 * buffer.c (Qclone_number): Remove for now, as it's unused.
5630 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5631 (record_buffer): Remove unused local.
5632 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5633 (set_frame_buffer_list): Remove; unused.
5634 * frame.h (other_visible_frames): Remove decl.
5635 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5636 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5637 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5639 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5640 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5641 Define only if HAVE_GPM.
5642 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5643 (update_hints_inhibit): Remove; never set. All uses removed.
5644 * widgetprv.h (emacsFrameClassRec): Remove decl.
5645 * window.c (delete_deletable_window): Now returns void, since it
5646 wasn't returning anything.
5647 (compare_window_configurations): Remove unused locals.
5648 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5649 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5650 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5651 the same widths as pointers. This follows up on the 2011-05-06 patch.
5652 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5653 * xterm.h: Likewise.
5654 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5656 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5658 * makefile.w32-in: Update dependencies.
5659 (LISP_H): Add lib/intprops.h.
5661 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5663 * image.c (gif_load): Add animation frame delay to the metadata.
5664 (syms_of_image): Use DEFSYM. New symbol `delay'.
5666 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5668 * window.c (delete_deletable_window): Re-add.
5669 (Fset_window_configuration): Rewrite to handle dead buffers and
5670 consequently deletable windows.
5671 (window_tree, Fwindow_tree): Remove. Supply functionality in
5673 (compare_window_configurations): Simplify code.
5675 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5677 * image.c (imagemagick_load_image): Fix type mismatch.
5678 (Fimagemagick_types): Likewise.
5680 * window.h (replace_buffer_in_windows): Declare.
5682 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5684 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5685 Qclone_number. Remove external declaration of Qdelete_window.
5686 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5688 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5689 Run Qbuffer_list_update_hook if allowed.
5690 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5691 buffer list implementation.
5692 (other_buffer_safely): New function.
5693 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5694 calls to replace_buffer_in_windows and
5695 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5697 (record_buffer): Inhibit quitting and rewrite using quittable
5698 functions. Run Qbuffer_list_update_hook if allowed.
5699 (Frecord_buffer, Funrecord_buffer): New functions.
5700 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5701 Move switch-to-buffer to window.el.
5702 (bury-buffer): Move to window.el.
5703 (Vbuffer_list_update_hook): New variable.
5705 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5708 * window.h (resize_frame_windows): Move up in code.
5709 (Fwindow_frame): Remove EXFUN.
5710 (replace_buffer_in_all_windows): Remove prototype.
5711 (replace_buffer_in_windows_safely): Add prototype.
5713 * window.c: Declare Qdelete_window static again. Move down
5714 declaration of select_count.
5715 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5716 (Fother_window): Move to window.el.
5717 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5718 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5719 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5721 (replace_buffer_in_windows): Implement by calling
5722 Qreplace_buffer_in_windows.
5723 (replace_buffer_in_all_windows): Remove with some functionality
5724 moved into replace_buffer_in_windows_safely.
5725 (replace_buffer_in_windows_safely): New function.
5726 (select_window_norecord, select_frame_norecord): Move in front
5727 of run_window_configuration_change_hook. Remove now obsolete
5729 (Fset_window_buffer): Rewrite doc-string.
5730 Call Qrecord_window_buffer.
5731 (keys_of_window): Move binding for other-window to window.el.
5733 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5735 * dispextern.h (struct image): Replace data member, whose int_val
5736 and ptr_val fields were not used by anything, with a single
5739 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5740 (gif_clear_image, gif_load, imagemagick_load_image)
5741 (gs_clear_image, gs_load): Callers changed.
5743 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5745 * buffer.h: Include <time.h>, for time_t.
5746 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5748 Fix minor problems found by static checking.
5750 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5752 Make identifiers static if they are not used in other modules.
5753 * data.c (Qcompiled_function, Qframe, Qvector):
5754 * image.c (QimageMagick, Qsvg):
5755 * minibuf.c (Qmetadata):
5756 * window.c (resize_window_check, resize_root_window): Now static.
5757 * window.h (resize_window_check, resize_root_window): Remove decls.
5759 * window.c (window_deletion_count, delete_deletable_window):
5761 (window_body_lines): Now static.
5762 (Fdelete_other_windows_internal): Mark vars as initialized.
5763 Make sure 'resize_failed' is initialized.
5764 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5765 (resize_window_apply): Remove unused local.
5766 * window.h (delete_deletable_window): Remove decl.
5768 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5769 (imagemagick_load_image): Fix pointer signedness problem by changing
5770 last arg from unsigned char * to char *. All uses changed.
5771 Also, fix a local for similar reasons.
5772 Remove unused locals. Remove locals to avoid shadowing.
5773 (fn_rsvg_handle_free): Remove; unused.
5774 (svg_load, svg_load_image): Fix pointer signedness problem.
5775 (imagemagick_load_image): Don't use garbage pointer image_wand.
5777 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5779 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5781 * image.c (gif_load): Fix omitted cast error introduced by
5784 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5786 * window.h (resize_proportionally, orig_total_lines)
5787 (orig_top_line): Remove from window structure.
5788 (set_window_height, set_window_width, change_window_heights)
5789 (Fdelete_window): Remove prototypes.
5790 (resize_frame_windows): Remove duplicate declaration.
5792 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5794 * window.h (resize_frame_windows, resize_window_check)
5795 (delete_deletable_window, resize_root_window)
5796 (resize_frame_windows): Declare prototypes.
5798 * window.c (resize_window_apply): Make definition be "static" to
5799 match the prototype.
5801 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5803 * window.c: Remove declarations of Qwindow_size_fixed,
5804 window_min_size_1, window_min_size_2, window_min_size,
5805 size_window, window_fixed_size_p, enlarge_window, delete_window.
5806 Remove static from declaration of Qdelete_window, it's
5807 temporarily needed by Fbury_buffer.
5808 (replace_window): Don't assign orig_top_line and
5810 (Fdelete_window, delete_window): Remove. Window deletion is
5811 handled by window.el.
5812 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5813 Replace Fdelete_window calls with calls to Qdelete_window.
5814 (Fdelete_other_windows): Remove. Deleting other windows is
5815 handled by window.el.
5816 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5817 handled in window.el.
5818 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5819 Window minimum sizes are handled in window.el.
5820 (shrink_windows, size_window, set_window_height)
5821 (set_window_width, change_window_heights, window_height)
5822 (window_width, CURBEG, CURSIZE, enlarge_window)
5823 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5824 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5825 handled in window.el.
5826 (make_dummy_parent): Rename to make_parent_window and give it a
5827 second argument horflag.
5828 (make_window): Don't set resize_proportionally any more.
5829 (Fsplit_window): Remove. Windows are split in window.el.
5830 (save_restore_action, save_restore_orig_size)
5831 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5832 Resize mini windows in window.el.
5833 (grow_mini_window, shrink_mini_window): Implement by calling
5834 Qresize_root_window_vertically, resize_window_check and
5835 resize_window_apply.
5836 (saved_window, Fset_window_configuration, save_window_save):
5837 Do not handle orig_top_line, orig_total_lines, and
5838 resize_proportionally.
5839 (window_min_height, window_min_width): Move to window.el.
5840 (keys_of_window): Move bindings for delete-other-windows,
5841 split-window, delete-window and enlarge-window to window.el.
5843 * buffer.c: Temporarily extern Qdelete_window.
5844 (Fbury_buffer): Temporarily call Qdelete_window instead of
5845 Fdelete_window (Fbury_buffer will move to window.el soon).
5847 * frame.c (set_menu_bar_lines_1): Remove code handling
5848 orig_top_line and orig_total_lines.
5850 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5851 set_window_height but set heights directly.
5852 (change_frame_size_1): Use resize_frame_windows.
5854 * xdisp.c (init_xdisp): Don't use set_window_height but set
5857 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5858 Use resize_frame_windows instead of change_window_heights and run
5859 run_window_configuration_change_hook.
5861 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5862 instead of change_window_heights and run
5863 run_window_configuration_change_hook.
5865 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5867 * window.c (replace_window): Rename second argument REPLACEMENT to
5868 NEW. New third argument SETFLAG. Rewrite.
5869 (delete_window, make_dummy_parent): Call replace_window with
5871 (window_list_1): Move down in code.
5872 (run_window_configuration_change_hook): Move set_buffer part
5873 before select_frame_norecord part in order to unwind correctly.
5874 Rename count1 to count.
5875 (recombine_windows, delete_deletable_window, resize_root_window)
5876 (Fdelete_other_windows_internal)
5877 (Frun_window_configuration_change_hook, make_parent_window)
5878 (resize_window_check, resize_window_apply, Fresize_window_apply)
5879 (resize_frame_windows, Fsplit_window_internal)
5880 (Fdelete_window_internal, Fresize_mini_window_internal):
5882 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5884 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5886 * window.h (window): Add some new members to window structure -
5887 normal_lines, normal_cols, new_total, new_normal, clone_number,
5888 splits, nest, prev_buffers, next_buffers.
5889 (WINDOW_TOTAL_SIZE): Move here from window.c.
5890 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5892 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5894 (make_dummy_parent): Set new members of windows structure.
5895 (make_window): Move down in code. Handle new members of window
5897 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5898 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5899 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5900 (Fset_window_prev_buffers, Fwindow_next_buffers)
5901 (Fset_window_next_buffers, Fset_window_clone_number):
5903 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5904 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5906 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5907 Argument WINDOW can be now internal window too.
5908 (Fwindow_use_time): Move up in code.
5909 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5911 (Fset_window_configuration, saved_window)
5912 (Fcurrent_window_configuration, save_window_save): Handle new
5913 members of window structure.
5914 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5915 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5916 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5917 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5918 Qget_mru_window, Qresize_root_window,
5919 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5920 Qauto_buffer_name; staticpro them.
5922 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5924 * window.c (Fwindow_total_size, Fwindow_left_column)
5925 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5926 (Fwindow_list_1): New functions.
5927 (window_box_text_cols): Replace with window_body_cols.
5928 (Fwindow_width, Fscroll_left, Fscroll_right):
5929 Use window_body_cols instead of window_box_text_cols.
5930 (delete_window, Fset_window_configuration):
5931 Call delete_all_subwindows with window as argument.
5932 (delete_all_subwindows): Take a window as argument and not a
5934 (window_loop): Remove handling of GET_LRU_WINDOW and
5936 (Fget_lru_window, Fget_largest_window): Move to window.el.
5938 * window.h: Extern window_body_cols instead of
5939 window_box_text_cols. delete_all_subwindows now takes a
5940 Lisp_Object as argument.
5942 * indent.c (compute_motion, Fcompute_motion):
5943 Use window_body_cols instead of window_box_text_cols.
5945 * frame.c (delete_frame): Call delete_all_subwindows with root
5948 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5950 * fns.c (Fputhash): Document return value.
5952 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5954 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5956 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5958 Cons<->int and similar integer overflow fixes (Bug#8794).
5960 Check for overflow when converting integer to cons and back.
5961 * charset.c (Fdefine_charset_internal, Fdecode_char):
5962 Use cons_to_unsigned to catch overflow.
5963 (Fencode_char): Use INTEGER_TO_CONS.
5964 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5965 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5966 * data.c (long_to_cons, cons_to_long): Remove.
5967 (cons_to_unsigned, cons_to_signed): New functions.
5968 These signal an error for invalid or out-of-range values.
5969 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5970 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5971 * font.c (Ffont_variation_glyphs):
5972 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5973 * lisp.h: Include <intprops.h>.
5974 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5975 (cons_to_signed, cons_to_unsigned): New decls.
5976 (long_to_cons, cons_to_long): Remove decls.
5977 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5978 (Fprimitive_undo): Use CONS_TO_INTEGER.
5979 * xfns.c (Fx_window_property): Likewise.
5980 * xselect.c: Include <limits.h>.
5981 (x_own_selection, selection_data_to_lisp_data):
5982 Use INTEGER_TO_CONS.
5983 (x_handle_selection_request, x_handle_selection_clear)
5984 (x_get_foreign_selection, Fx_disown_selection_internal)
5985 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5986 (lisp_data_to_selection_data): Use cons_to_unsigned.
5987 (x_fill_property_data): Use cons_to_signed.
5988 Report values out of range.
5990 Check for buffer and string overflow more precisely.
5991 * buffer.h (BUF_BYTES_MAX): New macro.
5992 * lisp.h (STRING_BYTES_MAX): New macro.
5993 * alloc.c (Fmake_string):
5994 * character.c (string_escape_byte8):
5995 * coding.c (coding_alloc_by_realloc):
5996 * doprnt.c (doprnt):
5997 * editfns.c (Fformat):
5999 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
6000 since they may not be the same number.
6001 * editfns.c (Finsert_char):
6002 * fileio.c (Finsert_file_contents):
6003 Likewise for BUF_BYTES_MAX.
6005 * image.c: Use ptrdiff_t, not int, for sizes.
6006 (slurp_file): Switch from int to ptrdiff_t.
6008 (slurp_file): Check that file size fits in both size_t (for
6009 malloc) and ptrdiff_t (for sanity and safety).
6011 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6012 if b->modtime has its maximal value.
6014 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6016 Don't assume time_t can fit into int.
6017 * buffer.h (struct buffer.modtime): Now time_t, not int.
6018 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6019 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6021 Minor fixes for signed vs unsigned integers.
6022 * character.h (MAYBE_UNIFY_CHAR):
6023 * charset.c (maybe_unify_char):
6024 * keyboard.c (read_char, reorder_modifiers):
6025 XINT -> XFASTINT, since the integer must be nonnegative.
6026 * ftfont.c (ftfont_spec_pattern):
6027 * keymap.c (access_keymap, silly_event_symbol_error):
6028 XUINT -> XFASTINT, since the integer must be nonnegative.
6029 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6030 since it makes no difference and we prefer signed.
6031 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6032 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6035 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6037 * window.h (Fwindow_frame): Declare.
6039 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6041 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6042 (SPARE_MEMORY): Always define.
6043 (LARGE_REQUEST): Remove.
6044 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6046 2011-06-06 Martin Rudalics <rudalics@gmx.at>
6048 * lisp.h: Move EXFUNS for Fframe_root_window,
6049 Fframe_first_window and Fset_frame_selected_window to window.h.
6051 * window.h: Move EXFUNS for Fframe_root_window,
6052 Fframe_first_window and Fset_frame_selected_window here from
6055 * frame.c (Fwindow_frame, Fframe_first_window)
6056 (Fframe_root_window, Fframe_selected_window)
6057 (Fset_frame_selected_window): Move to window.c.
6058 (Factive_minibuffer_window): Move to minibuf.c.
6059 (Fother_visible_frames_p): New function.
6061 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6063 * window.c (decode_window, decode_any_window): Move up in code.
6064 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6065 (inhibit_frame_unsplittable): Remove unused variable.
6066 (Fwindow_buffer): Move up and rewrite doc-string.
6067 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6068 (Fwindow_prev): New functions.
6069 (Fwindow_frame): Move here from frame.c. Accept any window as
6071 (Fframe_root_window, Fframe_first_window)
6072 (Fframe_selected_window): Move here from frame.c. Accept frame
6073 or arbitrary window as argument. Update doc-strings.
6074 (Fminibuffer_window): Move up in code.
6075 (Fwindow_minibuffer_p): Move up in code and simplify.
6076 (Fset_frame_selected_window): Move here from frame.c.
6078 (Fselected_window, select_window, Fselect_window): Move up in
6079 code. Minor doc-string fixes.
6081 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6083 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6084 Do not assume that spare memory exists; that assumption is valid
6085 only if SYSTEM_MALLOC.
6086 (LARGE_REQUEST): New macro, so that the issue of large requests
6087 is separated from the issue of spare memory.
6089 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6091 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6094 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6096 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6099 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6101 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6103 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6105 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6106 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6108 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
6110 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6112 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
6114 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6115 (x_clipboard_manager_save): Add return value.
6116 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6118 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6119 Obey Vx_select_enable_clipboard_manager. Catch errors in
6120 x_clipboard_manager_save (Bug#8779).
6121 (Vx_select_enable_clipboard_manager): New variable.
6122 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
6124 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
6126 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6128 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6130 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6131 in the current matrix if keep_current_p is non-zero.
6133 2011-06-04 Eli Zaretskii <eliz@gnu.org>
6135 * bidi.c (bidi_level_of_next_char): Fix last change.
6137 2011-06-03 Eli Zaretskii <eliz@gnu.org>
6139 Support bidi reordering of text covered by display properties.
6141 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6142 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6143 (bidi_cache_search, bidi_cache_iterator_state)
6144 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6145 (bidi_level_of_next_char, bidi_move_to_visually_next):
6146 Support character positions inside a run of characters covered by a
6148 (bidi_paragraph_init, bidi_resolve_explicit_1)
6149 (bidi_level_of_next_char): Call bidi_fetch_char and
6150 bidi_fetch_char_advance instead of FETCH_CHAR and
6152 (bidi_init_it): Initialize new members.
6153 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6155 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6156 instead of using explicit *_CHAR codes.
6157 (bidi_resolve_explicit, bidi_resolve_weak):
6158 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
6159 bidirectional text is supported only in multibyte buffers.
6160 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6161 it to initialize the frame_window_p member of struct bidi_it.
6162 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6163 (bidi_resolve_explicit, bidi_resolve_weak)
6164 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6165 bidi_it->nchars is non-positive.
6166 (bidi_level_of_next_char): Don't try to lookup the cache for the
6167 next/previous character if nothing is cached there yet, or if we
6168 were just reseat()'ed to a new position.
6170 * xdisp.c (set_cursor_from_row): Set start and stop points
6171 according to the row's direction when priming the loop that looks
6172 for the glyph on which to display cursor.
6173 (single_display_spec_intangible_p): Function deleted.
6174 (display_prop_intangible_p): Reimplement to call
6175 handle_display_spec instead of single_display_spec_intangible_p.
6176 Accept 3 additional arguments needed by handle_display_spec.
6177 This fixes incorrect cursor motion across display property with complex
6178 values: lists, `(when COND...)' forms, etc.
6179 (single_display_spec_string_p): Support property values that are
6180 lists with the argument STRING its top-level element.
6181 (display_prop_string_p): Fix the condition for processing a
6182 property that is a list to be consistent with handle_display_spec.
6183 (handle_display_spec): New function, refactored from the
6184 last portion of handle_display_prop.
6185 (compute_display_string_pos): Accept additional argument
6186 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6187 value of a `display' property is a "replacing spec".
6188 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6189 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6190 the display property, but just return a value indicating whether
6191 the display property will replace the characters it covers.
6192 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6193 frame_window_p members of struct bidi_it.
6194 (compute_display_string_pos, compute_display_string_end):
6196 (push_it): Accept second argument POSITION, where pop_it should
6197 jump to continue iteration.
6198 (reseat_1): Initialize bidi_it.disp_pos.
6200 * keyboard.c (adjust_point_for_property): Adjust the call to
6201 display_prop_intangible_p to its new signature.
6203 * dispextern.h (struct bidi_it): New member frame_window_p.
6204 (bidi_init_it): Update prototypes.
6205 (display_prop_intangible_p): Update prototype.
6206 (compute_display_string_pos, compute_display_string_end):
6208 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6211 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6213 Malloc failure behavior now depends on size of allocation.
6214 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6215 * lisp.h: Change signatures accordingly.
6216 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6217 All callers changed. (Bug#8762)
6219 * gnutls.c: Use Emacs's memory allocators.
6220 Without this change, the gnutls library would invoke malloc etc.
6221 directly, which causes problems on non-SYNC_INPUT hosts, and which
6222 runs afoul of improving memory_full behavior. (Bug#8761)
6223 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6224 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6225 xfree instead of the default malloc, realloc, free.
6226 (Fgnutls_boot): No need to check for memory allocation failure,
6227 since xmalloc does that for us.
6229 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6230 * category.c (hash_get_category_set):
6231 * ccl.c (ccl_driver):
6232 * charset.c (Fdefine_charset_internal):
6233 * charset.h (struct charset.hash_index):
6234 * composite.c (get_composition_id, gstring_lookup_cache)
6235 (composition_gstring_put_cache):
6236 * composite.h (struct composition.hash_index):
6237 * dispextern.h (struct image.hash):
6238 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6239 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6240 (hashfn_equal, hashfn_user_defined, make_hash_table)
6241 (maybe_resize_hash_table, hash_lookup, hash_put)
6242 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6243 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6244 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6245 * image.c (make_image, search_image_cache, lookup_image)
6246 (xpm_put_color_table_h):
6247 * lisp.h (struct Lisp_Hash_Table):
6248 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6249 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6250 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6251 * alloc.c (allocate_vectorlike):
6252 Check for overflow in vector size calculations.
6253 * ccl.c (ccl_driver):
6254 Check for overflow when converting EMACS_INT to int.
6255 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6256 need to be updated by these changes.
6257 * fns.c (make_hash_table, maybe_resize_hash_table):
6258 Check for integer overflow with large hash tables.
6259 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6260 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6261 (SXHASH_REDUCE): New macro.
6262 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6263 Use it instead of discarding useful hash info with large hash values.
6264 (sxhash_float): New function.
6265 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6266 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6267 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6268 Rewrite to use FIXNUM_BITS, as this simplifies things.
6269 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6270 Adjust signatures to match updated version of code.
6271 (consing_since_gc): Now EMACS_INT, since a single hash table can
6272 use more than INT_MAX bytes.
6274 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6276 Make it possible to build with GCC-4.6+ -O2 -flto.
6278 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6280 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6282 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6283 Call minibuffer-inactive-mode.
6285 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6287 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6288 Update dependencies.
6290 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6292 * data.c (init_data): Remove code for UTS, this system is not
6295 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6297 Don't force ./temacs to start in terminal mode.
6299 * frame.c (make_initial_frame): Initialize faces in all cases, not
6300 only when CANNOT_DUMP is defined.
6301 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6303 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6305 * dispnew.c (add_window_display_history): Use const for the string
6306 pointer. Remove declaration, not needed.
6308 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6310 Use 'inline', not 'INLINE'.
6311 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6312 * alloc.c, fontset.c (INLINE): Remove.
6313 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6314 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6315 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6316 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6317 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6319 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6321 Make it possible to run ./temacs.
6323 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6324 syms_of_callproc does the same thing. Remove test for
6325 "initialized", do it in the caller.
6326 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6328 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6330 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6331 (read_minibuf): Use get_minibuffer.
6332 (syms_of_minibuf): Use DEFSYM.
6333 (Qmetadata): New var.
6334 * data.c (Qbuffer): Don't make it static.
6335 (syms_of_data): Use DEFSYM.
6337 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6339 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6340 (CCL_CODE_MIN): New macro.
6342 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6344 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6346 * eval.c (Qdebug): Now static.
6347 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6348 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6349 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6351 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6353 * image.c: Various fixes to ImageMagick code comments.
6354 (Fimagemagick_types): Doc fix.
6356 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6358 Minor fixes prompted by GCC 4.6.0 warnings.
6360 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6362 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6363 (x_clipboard_manager_save_all): Move extern decl to ...
6364 * xterm.h: ... here, so that it can be checked for consistency.
6366 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6368 * xselect.c (x_clipboard_manager_save_frame)
6369 (x_clipboard_manager_save_all): New functions.
6370 (Fx_clipboard_manager_save): Lisp function deleted.
6372 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6373 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6375 * xterm.h: Update prototype.
6377 2011-05-28 William Xu <william.xwl@gmail.com>
6379 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6382 2011-05-28 Jim Meyering <meyering@redhat.com>
6384 Avoid a sign-extension bug in crypto_hash_function.
6385 * fns.c (to_uchar): Define.
6386 (crypto_hash_function): Use it to convert some newly-signed
6387 variables to unsigned, to avoid sign-extension bugs. For example,
6388 without this change, (md5 "truc") would evaluate to
6389 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6390 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6391 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6393 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6395 Integer overflow fixes.
6397 * dbusbind.c: Serial number integer overflow fixes.
6398 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6399 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6400 to hold a serial number that is too large for a fixnum.
6401 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6402 Check for serial numbers out of range. Decode any serial number
6403 that was so large that it became a float. (Bug#8722)
6405 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6406 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6407 Use XFASTINT rather than XUINT when numbers are nonnegative.
6408 (xd_append_arg, Fdbus_method_return_internal):
6409 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6410 arguments, check that Lisp number is nonnegative, rather than
6411 silently wrapping negative numbers around. (Bug#8722)
6412 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6415 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6417 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6419 ccl: Add integer overflow checks.
6420 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6421 (IN_INT_RANGE): New macros.
6422 (ccl_driver): Use them to check for integer overflow when
6423 decoding a CCL program. Many of the new checks are whether XINT (x)
6424 fits in int; it doesn't always, on 64-bit hosts. The new version
6425 doesn't catch all possible integer overflows, but it's an
6426 improvement. (Bug#8719)
6428 * alloc.c (make_event_array): Use XINT, not XUINT.
6429 There's no need for unsigned here.
6431 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6432 This follows up to the 2011-05-06 change that substituted uintptr_t
6433 for EMACS_INT. This case wasn't caught back then.
6435 Rework Fformat to avoid integer overflow issues.
6436 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6437 now (part of C89). Include <verify.h>.
6438 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6439 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6440 (Fformat): Avoid the prepass trying to compute sizes; it was only
6441 approximate and thus did not catch overflow reliably. Instead, walk
6442 through the format just once, formatting and computing sizes as we go,
6443 checking for integer overflow at every step, and allocating a larger
6444 buffer as needed. Keep track separately whether the format is
6445 multibyte. Keep only the most-recently calculated precision, rather
6446 than them all. Record whether each argument has been converted to
6447 string. Use EMACS_INT, not int, for byte and char and arg counts.
6448 Support field widths and precisions larger than INT_MAX. Avoid
6449 sprintf's undefined behavior with conversion specifications such as %#d
6450 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6451 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6452 formatting out-of-range floating point numbers with int
6455 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6457 * data.c: Avoid integer truncation in expressions involving floats.
6458 * data.c: Include <intprops.h>.
6459 (arith_driver): When there's an integer overflow in an expression
6460 involving floating point, convert the integers to floating point
6461 so that the resulting value does not suffer from catastrophic
6462 integer truncation. For example, on a 64-bit host (* 4
6463 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6464 Do not rely on undefined behavior after integer overflow.
6466 merge count_size_as_multibyte, parse_str_to_multibyte
6467 * character.c, character.h (count_size_as_multibyte):
6468 Rename from parse_str_to_multibyte; all uses changed.
6469 Check for integer overflow.
6470 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6471 since it's now a duplicate of the other. This is more of
6472 a character than a buffer op, so better that it's in character.c.
6473 * fns.c, print.c: Adjust to above changes.
6475 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6477 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6479 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6481 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6482 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6483 (x_clipboard_manager_save): Now static.
6484 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6486 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6487 (crypto_hash_function): Now static.
6488 Fix pointer signedness problems. Avoid unnecessary initializations.
6490 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6492 * termhooks.h (Vselection_alist): Make it terminal-local.
6494 * terminal.c (create_terminal): Initialize it.
6496 * xselect.c: Support for clipboard managers.
6497 (Vselection_alist): Move to termhooks.h as terminal-local var.
6498 (LOCAL_SELECTION): New macro.
6499 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6500 (symbol_to_x_atom): Remove gratuitous arg.
6501 (x_handle_selection_request, lisp_data_to_selection_data)
6502 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6503 (x_own_selection, x_get_local_selection, x_convert_selection):
6504 New arg, specifying work frame. Use terminal-local Vselection_alist.
6505 (some_frame_on_display): Delete unused function.
6506 (Fx_own_selection_internal, Fx_get_selection_internal)
6507 (Fx_disown_selection_internal, Fx_selection_owner_p)
6508 (Fx_selection_exists_p): New optional frame arg.
6509 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6510 (x_handle_selection_clear): Don't treat other terminals with the
6511 same keyboard specially. Use the terminal-local Vselection_alist.
6512 (x_clear_frame_selections): Use Frun_hook_with_args.
6514 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6516 * xterm.h: Add support for those atoms.
6518 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6520 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6521 (converted_selections, conversion_fail_tag): New global variables.
6522 (x_selection_request_lisp_error): Free the above.
6523 (x_get_local_selection): Remove unnecessary code.
6524 (x_reply_selection_request): Args changed; handle arbitrary array
6525 of converted selections stored in converted_selections.
6526 Separate the XChangeProperty and SelectionNotify steps.
6527 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6528 (x_convert_selection): New function.
6529 (x_handle_selection_event): Simplify.
6530 (x_get_foreign_selection): Don't ignore incoming requests while
6531 waiting for an answer; this will fail when we implement
6532 SAVE_TARGETS, and seems unnecessary anyway.
6533 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6534 (Vx_sent_selection_functions): Doc fix.
6536 2011-05-26 Leo Liu <sdl.web@gmail.com>
6538 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6540 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6542 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6544 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6545 for fringe update if it has periodic bitmap.
6546 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6547 and fringe_bitmap_periodic_p.
6549 * fringe.c (get_fringe_bitmap_data): New function.
6550 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6551 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6552 row. Mark glyph row for fringe update if periodicity changed.
6554 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6555 for fringe update unless it has periodic bitmap.
6557 2011-05-25 Kenichi Handa <handa@m17n.org>
6559 * xdisp.c (get_next_display_element): Set correct it->face_id for
6560 a static composition.
6562 2011-05-24 Leo Liu <sdl.web@gmail.com>
6565 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6567 * fns.c (crypto_hash_function, Fsha1): New function.
6568 (Fmd5): Use crypto_hash_function.
6569 (syms_of_fns): Add Ssha1.
6571 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6573 * gnutls.c: Remove unused macros.
6574 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6575 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6576 Remove macros that are defined and never used.
6577 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6579 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6581 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6582 (Fx_get_selection_internal): Minor cleanup.
6583 (Fx_own_selection_internal): Rename arguments for consistency with
6586 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6588 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6590 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6592 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6594 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6596 * dispnew.c (scrolling_window): Don't exclude the case that the
6597 last enabled row in the desired matrix touches the bottom boundary.
6599 2011-05-21 Glenn Morris <rgm@gnu.org>
6601 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6602 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6603 and add some more files.
6605 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6607 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6608 report_file_error introduced by the change from 2011-05-07.
6610 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6612 * systime.h (Time): Define only if emacs is defined.
6613 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6614 where the include path doesn't have X11/X.h by default. See
6615 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6617 2011-05-20 Kenichi Handa <handa@m17n.org>
6619 * composite.c (find_automatic_composition): Fix previous change.
6621 2011-05-20 Glenn Morris <rgm@gnu.org>
6623 * lisp.mk: New file, split from Makefile.in.
6624 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6625 (shortlisp): Remove.
6626 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6628 2011-05-19 Glenn Morris <rgm@gnu.org>
6630 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6631 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6632 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6633 (lisp): Set the order to that of loadup.el.
6634 (shortlisp): Make it a copy of $lisp.
6635 (SOME_MACHINE_LISP): Remove.
6636 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6637 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6639 2011-05-18 Kenichi Handa <handa@m17n.org>
6641 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6642 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6643 (find_automatic_composition): Mostly rewrite for efficiency.
6645 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6647 * makefile.w32-in: Update dependencies.
6649 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6651 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6652 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6654 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6656 Fix some integer overflow issues, such as string length overflow.
6658 * insdel.c (count_size_as_multibyte): Check for string overflow.
6660 * character.c (lisp_string_width): Check for string overflow.
6661 Use EMACS_INT, not int, for string indexes and lengths; in
6662 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6663 the resulting string length overflows an EMACS_INT; instead,
6664 report a string overflow if no precision given. When checking for
6665 precision exhaustion, use a check that cannot possibly have
6666 integer overflow. (Bug#8675)
6667 * character.h (lisp_string_width): Adjust to new signature.
6669 * alloc.c (string_overflow): New function.
6670 (Fmake_string): Use it. This doesn't change behavior, but saves
6671 a few bytes and will simplify future changes.
6672 * character.c (string_escape_byte8): Likewise.
6673 * lisp.h (string_overflow): New decl.
6675 Fixups, following up to the user-interface timestamp change.
6676 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6677 for UI timestamps, instead of unsigned long.
6678 * msdos.c (mouse_get_pos): Likewise.
6679 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6680 * w32gui.h (Time): Define by including "systime.h" rather than by
6681 declaring it ourselves. (Bug#8664)
6683 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6684 * image.c (clear_image_cache): Likewise.
6686 * term.c (term_mouse_position): Don't assume time_t wraparound.
6688 Be more systematic about user-interface timestamps.
6689 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6690 and sometimes 'EMACS_UINT', to represent these timestamps.
6691 This change causes it to use 'Time' uniformly, as that's what X uses.
6692 This makes the code easier to follow, and makes it easier to catch
6693 integer overflow bugs such as Bug#8664.
6694 * frame.c (Fmouse_position, Fmouse_pixel_position):
6695 Use Time, not unsigned long, for user-interface timestamps.
6696 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6697 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6698 * keyboard.h (last_event_timestamp): Likewise.
6699 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6700 * menu.h (xmenu_show): Likewise.
6701 * term.c (term_mouse_position): Likewise.
6702 * termhooks.h (struct input_event.timestamp): Likewise.
6703 (struct terminal.mouse_position_hook): Likewise.
6704 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6705 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6706 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6707 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6709 * menu.h, termhooks.h: Include "systime.h", for Time.
6711 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6712 Don't assume that the difference between two unsigned long values
6713 can fit into an integer. At this point, we know button_down_time
6714 <= event->timestamp, so the difference must be nonnegative, so
6715 there's no need to cast the result if double-click-time is
6716 nonnegative, as it should be; check that it's nonnegative, just in
6717 case. This bug is triggered when events are more than 2**31 ms
6718 apart (about 25 days). (Bug#8664)
6720 * xselect.c (last_event_timestamp): Remove duplicate decl.
6721 (x_own_selection): Remove needless cast to unsigned long.
6723 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6724 that always fit in int. Use a sentinel instead of a counter, to
6725 avoid a temp and to allay GCC's concerns about possible int overflow.
6726 * frame.h (struct frame): Use int for menu_bar_items_used
6727 instead of EMACS_INT, since it always fits in int.
6729 * menu.c (grow_menu_items): Check for int overflow.
6731 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6733 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6734 Before, the code was not consistent. These values cannot exceed
6735 2**31 - 1 so there's no need to make them unsigned.
6736 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6737 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6738 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6740 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6742 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6743 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6744 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6745 presumably because the widths might not match.
6747 * window.c (size_window): Avoid needless test at loop start.
6749 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6751 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6753 2011-05-12 Drew Adams <drew.adams@oracle.com>
6755 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6757 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6759 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6760 `width' to `bar_area_x' and `bar_area_width', respectively.
6761 (x_scroll_run): Take account of fringe background extension.
6763 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6764 Rename local vars `left' and `width' to `bar_area_x' and
6765 `bar_area_width', respectively.
6766 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6767 background extension.
6769 2011-05-10 Jim Meyering <meyering@redhat.com>
6771 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6773 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6775 * image.c (Finit_image_library): Return t for built-in image types,
6776 like pbm and xbm. (Bug#8640)
6778 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6780 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6782 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6784 * w32console.c (Fset_screen_color): Doc fix.
6785 (Fget_screen_color): New function.
6786 (syms_of_ntterm): Defsubr it.
6788 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6789 unlink the temporary file if Fcall_process didn't create it in the
6791 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6792 child process will be redirected to a file specified with `:file'.
6793 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6794 cue to call_process_cleanup not to close that handle.
6796 2011-05-07 Ben Key <bkey76@gmail.com>
6798 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6799 one of two shell specific rules, either bootstrap-temacs-CMD or
6800 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6801 to the previous implementation of the bootstrap-temacs rule.
6802 The bootstrap-temacs-CMD rule is similar to the previous
6803 implementation of the bootstrap-temacs rule except that it
6804 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6807 These changes, along with some changes to nt/configure.bat,
6808 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6809 earlier fix to add support for --cflags and --ldflags options
6810 that include quotes so that it works whether make uses cmd or
6813 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6815 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6816 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6818 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6819 a string. Handle both cases.
6820 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6821 (Fdbus_register_method): Use Qinvalid_function.
6823 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6825 * makefile.w32-in: Update dependencies.
6826 (LISP_H): Add inttypes.h and stdin.h.
6827 (PROCESS_H): Add unistd.h.
6829 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6831 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6832 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6834 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6836 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6838 * term.c (vfatal): Remove stray call to va_end.
6839 It's not needed and the C Standard doesn't allow it here anyway.
6841 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6842 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6844 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6847 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6849 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6851 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6853 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6855 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6857 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6858 * charset.c (Fdefine_charset_internal): Don't initialize
6859 charset.code_space[15]. The value was garbage, on hosts with
6860 32-bit int (Bug#8600).
6862 * lread.c (read_integer): Be more consistent with string-to-number.
6863 Use string_to_number to do the actual conversion; this avoids
6864 rounding errors and fixes some other screwups. Without this fix,
6865 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6866 (digit_to_number): Move earlier, for benefit of read_integer.
6867 Return -1 if the digit is out of range for the base, -2 if it is
6868 not a digit in any supported base. (Bug#8602)
6870 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6872 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6873 to match comment at start of function. This also removes a
6874 GCC warning about overflow in a 32+64-bit port.
6876 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6878 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6879 Reported by Stefan Monnier in
6880 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6881 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6882 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6884 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6885 (EMACS_UINTPTR): Likewise, with uintptr_t.
6887 * lisp.h: Prefer 64-bit EMACS_INT if available.
6888 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6889 on 32-bit hosts that have 64-bit int, so that they can access
6891 However, temporarily disable this change unless the temporary
6892 symbol WIDE_EMACS_INT is defined.
6894 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6896 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6897 This removes an assumption that EMACS_INT and long are the same
6898 width as pointers. The assumption is true for Emacs porting targets
6899 now, but we want to make other targets possible.
6900 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6901 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6902 In the rest of the code, change types of integers that hold casted
6903 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6904 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6905 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6906 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6907 No need to cast type when ORing.
6908 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6909 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6910 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6911 assume EMACS_INT is the same width as char *.
6912 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6913 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6914 Remove no-longer-needed casts.
6915 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6916 (xg_tool_bar_help_callback, xg_make_tool_item):
6917 Use EMACS_INTPTR to hold an integer
6918 that will be cast to void *; this can avoid a GCC warning
6919 if EMACS_INT is not the same width as void *.
6920 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6921 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6922 (current_message_1, set_message_1):
6923 Use a local to convert to proper width without a cast.
6924 * xmenu.c (dialog_selection_callback): Likewise.
6926 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6927 Also, don't assume VALBITS / RAND_BITS is less than 5,
6928 and don't rely on undefined behavior when shifting a 1 left into
6930 * lisp.h (get_random): Change signature to match.
6932 * lread.c (hash_string): Use size_t, not int, for hash computation.
6933 Normally we prefer signed values; but hashing is special, because
6934 it's better to use unsigned division on hash table sizes so that
6935 the remainder is nonnegative. Also, size_t is the natural width
6936 for hashing into memory. The previous code used 'int', which doesn't
6937 retain enough info to hash well into very large tables.
6938 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6940 * dbusbind.c: Don't possibly lose pointer info when converting.
6941 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6942 Use XPNTR rather than XHASH, so that the high-order bits of
6943 the pointer aren't lost when converting through void *.
6945 * eval.c (Fautoload): Don't double-shift a pointer.
6947 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6949 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6951 * gnutls.c (DEF_GNUTLS_FN):
6952 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6954 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6956 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6959 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6961 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6962 New version that can reserve upto 2GB of heap space.
6964 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6966 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6968 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6970 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6971 `gnutls_certificate_set_x509_key_file'.
6973 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6975 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6976 Update dependencies.
6978 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6980 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6981 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6982 Remove unused parameter `fildes'.
6983 * process.c (read_process_output, send_process): Don't pass it.
6985 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6987 Fix previous change: the library cache is defined in w32.c.
6988 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6989 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6991 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6993 Implement dynamic loading of GnuTLS on Windows.
6995 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6996 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6997 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7000 * gnutls.c (Qgnutls_dll): Define.
7001 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
7002 (gnutls_*): Declare function pointers.
7003 (init_gnutls_functions): New function to initialize function pointers.
7004 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
7005 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
7006 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7007 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
7008 (emacs_gnutls_write, emacs_gnutls_read)
7009 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7010 (Fgnutls_available_p): New function.
7011 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7012 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7013 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7015 * image.c: Include w32.h.
7016 (Vimage_type_cache): Delete.
7017 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7018 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7019 (w32_delayed_load): Move to w32.c.
7021 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7023 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7024 (w32_delayed_load): Move from image.c. When loading a library, record
7025 its filename in the :loaded-from property of the library id.
7026 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7027 Initialize and staticpro them.
7028 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7030 * process.c: Include lisp.h before w32.h, not after.
7031 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7032 instead of gnutls_record_check_pending.
7034 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7036 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7038 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7039 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7042 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7044 * xterm.c (x_set_frame_alpha): Do not set property on anything
7045 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7047 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7049 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7051 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7053 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7054 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7055 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7056 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7057 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7058 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7059 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7060 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7061 (Qgnutls_bootprop_callbacks_verify): Make static.
7063 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7065 * callproc.c: Indentation fixup.
7067 * sysdep.c (wait_for_termination_1): Make static.
7068 (wait_for_termination, interruptible_wait_for_termination):
7069 Move after wait_for_termination_1.
7071 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7073 * sysdep.c (interruptible_wait_for_termination): New function
7074 which is like wait_for_termination, but allows keyboard
7077 * callproc.c (Fcall_process): Add (:file "file") as an option for
7079 (Fcall_process_region): Ditto.
7081 2011-04-30 Eli Zaretskii <eliz@gnu.org>
7083 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7084 rather than `XVECTOR (FOO)->size'.
7086 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7087 inttypes.h, as a gnulib replacement is used if it not available in
7090 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7092 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7093 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7094 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7096 * coding.c (coding_alloc_by_realloc): Error out if destination
7097 will grow beyond MOST_POSITIVE_FIXNUM.
7098 (decode_coding_emacs_mule): Abort if there isn't enough place in
7099 charbuf for the composition carryover bytes. Reserve an extra
7100 space for up to 2 characters produced in a loop.
7101 (decode_coding_iso_2022): Abort if there isn't enough place in
7102 charbuf for the composition carryover bytes.
7104 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7106 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7107 aborting when %lld or %lll format is passed.
7108 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7109 %llo or %llx format is passed. (Bug#8545)
7111 * window.c (window_scroll_line_based): Use a marker instead of
7112 simple variables to record original value of point. (Bug#7952)
7114 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7115 produced by %s or %c overflows available buffer space. (Bug#8545)
7117 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7119 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
7120 (SIZE_MAX): Move defn after all includes, as they might #define it.
7122 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7124 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7126 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7128 * keyboard.c (Qdelayed_warnings_hook): Define.
7129 (command_loop_1): Run `delayed-warnings-hook'
7130 if Vdelayed_warnings_list is non-nil.
7131 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7132 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7134 2011-04-28 Eli Zaretskii <eliz@gnu.org>
7136 * doprnt.c (doprnt): Don't return value smaller than the buffer
7137 size if the message was truncated. (Bug#8545).
7139 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7141 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7142 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7144 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7146 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7148 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
7150 * makefile.w32-in: Update dependencies.
7152 2011-04-27 Eli Zaretskii <eliz@gnu.org>
7154 Improve `doprnt' and its usage. (Bug#8545)
7155 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7156 `format_end'. Remove support for %l as a conversion specifier.
7157 Don't use xrealloc. Improve diagnostics when the %l size modifier
7158 is used. Update the commentary.
7160 * eval.c (verror): Simplify calculation of size_t.
7162 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7165 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7167 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7170 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7172 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7173 This makes this file independent of the recent pseudovector change.
7175 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7177 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7179 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7180 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7181 Remove unused local.
7182 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7184 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7185 GCC 4.6.0 optimizes based on type-based alias analysis.
7186 For example, if b is of type struct buffer * and v of type struct
7187 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7188 != &v->size, and therefore "v->size = 1; b->size = 2; return
7189 v->size;" must therefore return 1. This assumption is incorrect
7190 for Emacs, since it type-puns struct Lisp_Vector * with many other
7191 types. To fix this problem, this patch adds a new type struct
7192 vectorlike_header that documents the constraints on layout of vectors
7193 and pseudovectors, and helps optimizing compilers not get fooled
7194 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7195 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7196 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7198 (XSETPVECTYPE): Rewrite in terms of new macro.
7199 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7200 This is a bit clearer, and further avoids the possibility of
7201 undesirable aliasing.
7202 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7203 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7204 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7205 since Lisp_Subr is a special case (no "next" field).
7206 (ASIZE): Now uses header.size rather than size.
7207 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7208 to avoid the hassle of writing XVECTOR (foo)->header.size.
7209 (struct vectorlike_header): New type.
7210 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7211 object, to help avoid aliasing.
7212 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7213 (SUBRP): Likewise, since Lisp_Subr is a special case.
7214 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7215 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7216 (struct Lisp_Hash_Table): Combine first two members into a single
7217 struct vectorlike_header member. All uses of "size" and "next" members
7218 changed to be "header.size" and "header.next".
7219 * buffer.h (struct buffer): Likewise.
7220 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7221 * frame.h (struct frame): Likewise.
7222 * process.h (struct Lisp_Process): Likewise.
7223 * termhooks.h (struct terminal): Likewise.
7224 * window.c (struct save_window_data, struct saved_window): Likewise.
7225 * window.h (struct window): Likewise.
7226 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7227 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7228 * buffer.c (init_buffer_once): Likewise.
7229 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7231 * process.c (Fformat_network_address): Use local var for size,
7234 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7236 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7237 * data.c (atof): Remove decl; no longer used or needed.
7238 (digit_to_number): Move to lread.c.
7239 (Fstring_to_number): Use new string_to_number function, to be
7240 consistent with how the Lisp reader treats infinities and NaNs.
7241 Do not assume that floating-point numbers represent EMACS_INT
7242 without losing information; this is not true on most 64-bit hosts.
7243 Avoid double-rounding errors, by insisting on integers when
7244 parsing non-base-10 numbers, as the documentation specifies.
7245 * lisp.h (string_to_number): New decl, replacing ...
7246 (isfloat_string): Remove.
7247 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7248 (read1): Do not accept +. and -. as integers; this
7249 appears to have been a coding error. Similarly, do not accept
7250 strings like +-1e0 as floating point numbers. Do not report
7251 overflow for integer overflows unless the base is not 10 which
7252 means we have no simple and reliable way to continue.
7253 Break out the floating-point parsing into a new
7254 function string_to_number, so that Fstring_to_number parses
7255 floating point numbers consistently with the Lisp reader.
7256 (digit_to_number): Move here from data.c. Make it static inline.
7257 (E_CHAR, EXP_INT): Remove, replacing with ...
7258 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7259 (string_to_number): New function, replacing isfloat_string.
7260 This function checks for valid syntax and produces the resulting
7261 Lisp float number too. Rework it so that string-to-number
7262 no longer mishandles examples like "1.0e+". Use strtoumax,
7263 so that overflow for non-base-10 numbers is reported only when
7264 there's no portable and simple way to convert to floating point.
7266 * textprop.c (set_text_properties_1): Rewrite for clarity,
7267 and to avoid GCC warning about integer overflow.
7269 * intervals.h (struct interval): Use EMACS_INT for members
7270 where EMACS_UINT might cause problems. See
7271 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7272 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7273 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7275 (offset_intervals): Tell GCC not to worry about length overflow
7276 when negating a negative length.
7278 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7279 (overrun_check_free): Likewise.
7281 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7282 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7285 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7286 (gnutls_make_error): Rename local to avoid shadowing.
7287 (gnutls_emacs_global_deinit): ifdef out; not used.
7288 (Fgnutls_boot): Use const for pointer to readonly storage.
7289 Comment out unused local. Fix pointer signedness problems.
7291 * lread.c (openp): Don't stuff size_t into an 'int'.
7292 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7293 about possible signed overflow.
7295 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7296 (GDK_KEY_g): Don't define if already defined.
7297 (xg_prepare_tooltip): Avoid pointer signedness problem.
7298 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7300 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7301 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7303 * xfns.c (Fx_window_property): Simplify a bit,
7304 to make a bit faster and to avoid GCC 4.6.0 warning.
7305 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7307 * fns.c (internal_equal): Don't assume size_t fits in int.
7309 * alloc.c (compact_small_strings): Tighten assertion a little.
7311 Replace pEd with more-general pI, and fix some printf arg casts.
7312 * lisp.h (pI): New macro, generalizing old pEd macro to other
7313 conversion specifiers. For example, use "...%"pI"d..." rather
7314 than "...%"pEd"...".
7315 (pEd): Remove. All uses replaced with similar uses of pI.
7316 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7317 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7318 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7319 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7320 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7321 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7322 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7324 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7325 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7326 * print.c (safe_debug_print, print_object): Likewise.
7327 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7329 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7330 avoiding the 0 flag, which is not portable.
7331 * process.c (Fmake_network_process): Use pI to avoid cast.
7332 * region-cache.c (pp_cache): Likewise.
7333 * xdisp.c (decode_mode_spec): Likewise.
7334 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7335 behavior on 64-bit hosts with printf arg.
7336 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7337 (x_stop_queuing_selection_requests): Likewise.
7338 (x_get_window_property): Don't truncate byte count to an 'int'
7341 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7342 here, since it parses constructs like leading '-' and spaces,
7343 which are not wanted; and it overflows with large numbers.
7344 Instead, simply match F[0-9]+, which is what is wanted anyway.
7346 * alloc.c: Remove unportable assumptions about struct layout.
7347 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7348 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7349 (allocate_vectorlike, make_pure_vector): Use the new macros,
7350 plus offsetof, to remove unportable assumptions about struct layout.
7351 These assumptions hold on all porting targets that I know of, but
7352 they are not guaranteed, they're easy to remove, and removing them
7353 makes further changes easier.
7355 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7356 This doesn't fix a bug but makes the code clearer.
7357 (string_overrun_cookie): Now const. Use initializers that
7358 don't formally overflow signed char, to avoid warnings.
7359 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7360 can cause Emacs to crash when string overrun checking is enabled.
7361 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7362 multiple of sizeof (EMACS_INT); it need not be, if
7363 alignof(EMACS_INT) < sizeof (EMACS_INT).
7364 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7366 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7368 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7370 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7372 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7373 supposed to be handshaking. (Bug#8556)
7374 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7376 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7378 * lisp.h (Qdebug): List symbol.
7379 * eval.c (Qdebug): Restore global linkage.
7380 * keyboard.c (debug-on-event): New variable.
7381 (handle_user_signal): Break into debugger when debug-on-event
7382 matches the current signal symbol.
7384 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7386 * alloc.c (check_sblock, check_string_bytes)
7387 (check_string_free_list): Convert to standard C.
7389 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7391 * w32.c (emacs_gnutls_push): Fix typo.
7393 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7395 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7396 "cast to pointer from integer of different size".
7398 Improve doprnt and its use in verror. (Bug#8545)
7399 * doprnt.c (doprnt): Document the set of format control sequences
7400 supported by the function. Use SAFE_ALLOCA instead of always
7403 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7404 is one byte too soon. Don't use xrealloc; instead xfree and
7407 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7409 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7412 * gnutls.c: Renamed global_initialized to
7413 gnutls_global_initialized. Added internals for the
7414 :verify-hostname-error, :verify-error, and :verify-flags
7415 parameters of `gnutls-boot' and documented those parameters in the
7416 docstring. Start callback support.
7417 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7418 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7419 on error. Return error code.
7420 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7421 (emacs_gnutls_read): Likewise.
7422 (Fgnutls_boot): Return handshake error code.
7423 (emacs_gnutls_handle_error): New function.
7424 (wsaerror_to_errno): Likewise.
7426 * w32.h (emacs_gnutls_pull): Add prototype.
7427 (emacs_gnutls_push): Likewise.
7429 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7430 (emacs_gnutls_push): Likewise.
7432 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7434 * process.c (wait_reading_process_output): Check if GnuTLS
7435 buffered some data internally if no FDs are set for TLS
7438 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7439 (LIBS): Link to USER_LIBS.
7440 ($(BLD)/gnutls.$(0)): New target.
7442 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7444 * xdisp.c (handle_single_display_spec): Rename the
7445 display_replaced_before_p argument into display_replaced_p, to
7446 make it consistent with the commentary. Fix typos in the
7449 * textprop.c (syms_of_textprop): Remove dead code.
7450 (copy_text_properties): Delete obsolete commentary about an
7451 interface that was deleted long ago. Fix typos in the description
7454 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7455 to changes in oldXMenu/XMenu.h from 2011-04-16.
7456 <menu_help_message, prev_menu_help_message>: Constify.
7457 (IT_menu_make_room): menu->help_text is now `const char **';
7460 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7461 to changes in oldXMenu/XMenu.h from 2011-04-16.
7462 (struct XMenu): Declare `help_text' `const char **'.
7464 * xfaces.c <Qunspecified>: Make extern again.
7466 * syntax.c: Include sys/types.h before including regex.h, as
7469 * doc.c (get_doc_string): Improve the format passed to `error'.
7471 * doprnt.c (doprnt): Improve commentary.
7473 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7475 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7478 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7479 changes in globals.h immediately force recompilation.
7480 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7481 $(CURDIR)/s/ms-w32.h.
7482 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7484 * character.c (Fchar_direction): Function deleted.
7485 (syms_of_character): Don't defsubr it.
7486 <char-direction-table>: Deleted.
7488 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7490 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7491 * doprnt.c: Include limits.h.
7492 (SIZE_MAX): New macro.
7493 (doprnt): Return a size_t value. 2nd arg is now size_t.
7494 Many local variables are now size_t instead of int or unsigned.
7495 Improve overflow protection. Support `l' modifier for integer
7496 conversions. Support %l conversion. Don't assume an EMACS_INT
7497 argument for integer conversions and for %c.
7499 * lisp.h (doprnt): Restore prototype.
7501 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7504 * Makefile.in (base_obj): Add back doprnt.o.
7506 * deps.mk (doprnt.o): Add back prerequisites.
7507 (callint.o): Depend on character.h.
7509 * eval.c (internal_lisp_condition_case): Include the handler
7510 representation in the error message.
7511 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7512 when breaking from the loop.
7514 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7516 * callint.c (Fcall_interactively): When displaying error message
7517 about invalid control letter, pass the character's codepoint, not
7518 a pointer to its multibyte form. Improve display of the character
7519 in octal and display also its hex code.
7521 * character.c (char_string): Use %x to display the (unsigned)
7522 codepoint of an invalid character, to avoid displaying a bogus
7525 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7526 `error', not SYMBOL_NAME itself.
7528 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7529 character arguments to `error'.
7531 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7532 to `error' in error message about FINAL_CHAR argument. Make sure
7533 FINAL_CHAR is a character, and use %c when it is passed as
7534 argument to `error'.
7536 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7538 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7540 * w32.c: Include <time.h>.
7541 (sys_localtime): New function.
7543 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7545 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7547 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7549 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7551 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7554 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7556 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7557 gl_state.e_property when gl_state.object is Qt.
7559 * insdel.c (make_gap_larger): Remove limitation of buffer size
7562 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7564 * xdisp.c (lookup_glyphless_char_display)
7565 (produce_glyphless_glyph): Handle cons cell entry in
7566 glyphless-char-display.
7567 (Vglyphless_char_display): Document it.
7569 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7570 glyphless-char-display.
7572 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7574 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7576 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7578 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7579 definition for no-X builds.
7581 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7583 Static checks with GCC 4.6.0 and non-default toolkits.
7585 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7587 * process.c (keyboard_bit_set): Define only if SIGIO.
7588 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7589 (send_process): Repair possible setjmp clobbering.
7591 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7593 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7595 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7597 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7598 Define only if needed.
7600 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7601 by pacifying GCC about it. Maybe it's time to retire it?
7602 * xfaces.c (USG, __TIMEVAL__): Likewise.
7604 * dispextern.h (struct redisplay_interface): Rename param
7606 * termhooks.h (struct terminal): Likewise.
7607 * xterm.c (xembed_send_message): Likewise.
7609 * insdel.c (make_gap_smaller): Define only if
7610 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7612 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7615 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7616 so that we aren't warned about unused symbols.
7618 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7620 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7622 * xfns.c (x_real_positions): Mark locals as initialized.
7624 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7626 * xterm.c: Fix problems found by static analysis with other toolkits.
7627 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7628 (x_dispatch_event): Declare static if USE_GTK, and
7629 define if USE_GTK || USE_X_TOOLKIT.
7630 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7631 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7632 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7633 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7635 * xmenu.c (menu_help_callback): Pointer type fixes.
7636 Use const pointers when pointing at readonly data. Avoid pointer
7638 (FALSE): Remove unused macro.
7639 (update_frame_menubar): Remove unused decl.
7641 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7643 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7644 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7645 (single_menu_item): Rename local to avoid shadowing.
7647 * keyboard.c (make_lispy_event): Remove unused local var.
7649 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7650 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7652 * bitmaps: Change bitmaps from unsigned char back to the X11
7653 compatible char. Avoid the old compiler warnings about
7654 out-of-range initializers by using, for example, '\xab' rather
7657 * xgselect.c (xgselect_initialize): Check vs interface
7658 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7660 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7662 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7663 to read-only memory.
7665 * fns.c (vector): Remove; this old hack is no longer needed.
7667 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7669 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7671 * xrdb.c (x_load_resources): Omit unused local.
7673 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7674 (x_window): Rename locals to avoid shadowing.
7675 (USG): Use the kludged USG macro, to pacify gcc.
7677 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7678 (x_term_init): Remove local to avoid shadowing.
7680 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7682 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7683 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7685 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7687 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7689 Fix regex.c, syntax.c and friends for buffers > 2GB.
7690 * syntax.h (struct gl_state_s): Declare character position members
7693 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7695 * textprop.c (verify_interval_modification, interval_of):
7696 Declare arguments EMACS_INT.
7698 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7701 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7703 * indent.c (Fvertical_motion): Local variable it_start is now
7706 * regex.c (re_match, re_match_2, re_match_2_internal)
7707 (bcmp_translate, regcomp, regexec, print_double_string)
7708 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7709 (re_compile_pattern, re_exec): Declare arguments and local
7710 variables `size_t' and `ssize_t' and return values `regoff_t', as
7712 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7713 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7714 <compile_stack_type>: `size' and `avail' are now `size_t'.
7716 * regex.h <regoff_t>: Use ssize_t, not int.
7717 (re_search, re_search_2, re_match, re_match_2): Arguments that
7718 specify buffer/string position and length are now ssize_t and
7719 size_t. Return type is regoff_t.
7721 2011-04-16 Ben Key <bkey76@gmail.com>
7723 * nsfont.m: Fixed bugs in ns_get_family and
7724 ns_descriptor_to_entity that were caused by using free to
7725 deallocate memory blocks that were allocated by xmalloc (via
7726 xstrdup). This caused Emacs to crash when compiled with
7727 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7728 --enable-checking=xmallocoverrun). xfree is now used to
7729 deallocate these memory blocks.
7731 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7733 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7735 emacs_write: Accept and return EMACS_INT for sizes.
7736 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7738 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7739 Accept and return EMACS_INT.
7740 (emacs_gnutls_write): Return the number of bytes written on
7742 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7743 (emacs_read, emacs_write): Remove check for negative size, as the
7744 Emacs source code has been audited now.
7745 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7746 (emacs_read, emacs_write): Use it.
7747 * process.c (send_process): Adjust to the new signatures of
7748 emacs_write and emacs_gnutls_write. Do not attempt to store
7749 a byte offset into an 'int'; it might overflow.
7750 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7752 * sound.c: Don't assume sizes fit in 'int'.
7753 (struct sound_device.period_size, alsa_period_size):
7754 Return EMACS_INT, not int.
7755 (struct sound_device.write, vox_write, alsa_write):
7756 Accept EMACS_INT, not int.
7757 (wav_play, au_play): Use EMACS_INT to store sizes and to
7758 record read return values.
7760 2011-04-15 Ben Key <bkey76@gmail.com>
7762 * keyboard.c (Qundefined): Don't declare static since it is used
7764 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7765 static since they are used in nsfont.m.
7767 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7769 * process.c (Qprocessp): Don't declare static.
7770 * lisp.h (Qprocessp): Declare again.
7772 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7774 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7776 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7778 Improve C-level modularity by making more things 'static'.
7780 Don't publish debugger-only interfaces to other modules.
7781 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7782 (verify_bytepos, count_markers): Move decls to the only modules
7784 * region-cache.h (pp_cache): Likewise.
7785 * window.h (check_all_windows): Likewise.
7786 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7788 * sysdep.c (croak): Now static, if
7789 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7790 * syssignal.h (croak): Declare only if not static.
7792 * alloc.c (refill_memory_reserve): Now static if
7793 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7794 * lisp.h (refill_memory_reserve): Declare only if not static.
7796 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7797 Define only if USE_LUCID.
7799 * xrdb.c (x_customization_string, x_rm_string): Now static.
7801 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7802 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7804 * xdisp.c (draw_row_with_mouse_face): Now static.
7805 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7807 * window.h (check_all_windows): Mark externally visible.
7809 * window.c (window_deletion_count): Now static.
7811 * undo.c: Make symbols static if they're not exported.
7812 (last_undo_buffer, last_boundary_position, pending_boundary):
7815 * textprop.c (interval_insert_behind_hooks): Now static.
7816 (interval_insert_in_front_hooks): Likewise.
7818 * term.c: Make symbols static if they're not exported.
7819 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7820 (max_frame_lines, tty_set_terminal_modes):
7821 (tty_reset_terminal_modes, tty_turn_off_highlight):
7822 (get_tty_terminal): Now static.
7823 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7824 * termhooks.h (term_mouse_moveto): Do not declare if
7826 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7827 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7829 * sysdep.c: Make symbols static if they're not exported.
7830 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7832 (sigprocmask_set, full_mask): Remove; unused.
7833 (wait_debugging): Mark as visible.
7834 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7835 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7837 * syntax.c (syntax_temp): Define only if !__GNUC__.
7839 * sound.c (current_sound_device, current_sound): Now static.
7841 * search.c (searchbufs, searchbuf_head): Now static.
7843 * scroll.c (scroll_cost): Remove; unused.
7844 * dispextern.h (scroll_cost): Remove decl.
7846 * region-cache.h (pp_cache): Mark as externally visible.
7848 * process.c: Make symbols static if they're not exported.
7849 (process_tick, update_tick, create_process, chan_process):
7850 (Vprocess_alist, proc_buffered_char, datagram_access):
7851 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7852 (deactivate_process): Mark defn as static, as well as decl.
7853 * lisp.h (create_process): Remove decl.
7854 * process.h (chan_process, Vprocess_alist): Remove decls.
7856 * print.c: Make symbols static if they're not exported.
7857 (print_depth, new_backquote_output, being_printed, print_buffer):
7858 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7859 (print_interval, print_number_index, initial_stderr_stream):
7861 * lisp.h (Fprinc): Remove decl.
7862 (debug_output_compilation_hack): Mark as externally visible.
7864 * sysdep.c (croak): Move decl from here to syssignal.h.
7865 * syssignal.h (croak): Put it here, so the API can be checked when
7866 'croak' is called from dissociate_if_controlling_tty.
7868 * minibuf.c: Make symbols static if they're not exported.
7869 (minibuf_save_list, choose_minibuf_frame): Now static.
7870 * lisp.h (choose_minibuf_frame): Remove decl.
7872 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7874 * lread.c: Make symbols static if they're not exported.
7875 (read_objects, initial_obarray, oblookup_last_bucket_number):
7877 (make_symbol): Remove; unused.
7878 * lisp.h (initial_obarray, make_symbol): Remove decls.
7880 * keyboard.c: Make symbols static if they're not exported.
7881 (single_kboard, recent_keys_index, total_keys, recent_keys):
7882 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7883 (this_single_command_key_start, echoing, last_auto_save):
7884 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7885 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7886 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7887 (Vlispy_mouse_stem, double_click_count):
7889 (force_auto_save_soon): Define only if SIGDANGER.
7890 (ignore_mouse_drag_p): Now static if
7891 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7892 (print_help): Remove; unused.
7893 (stop_character, last_timer_event): Mark as externally visible.
7894 * keyboard.h (ignore_mouse_drag_p): Declare only if
7895 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7896 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7897 * lisp.h (echoing): Remove decl.
7898 (force_auto_save_soon): Declare only if SIGDANGER.
7899 * xdisp.c (redisplay_window): Simplify code, to make it more
7900 obvious that ignore_mouse_drag_p is not accessed if !defined
7901 USE_GTK && !defined HAVE_NS.
7903 * intervals.c: Make symbols static if they're not exported.
7904 (merge_properties_sticky, merge_interval_right, delete_interval):
7906 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7908 * insdel.c: Make symbols static if they're not exported.
7909 However, leave prepare_to_modify_buffer alone. It's never
7910 called from outside this function, but that appears to be a bug.
7911 (combine_after_change_list, combine_after_change_buffer):
7912 (adjust_after_replace, signal_before_change): Now static.
7913 (adjust_after_replace_noundo): Remove; unused.
7914 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7915 (signal_before_change): Remove decls.
7917 * indent.c (val_compute_motion, val_vmotion): Now static.
7919 * image.c: Make symbols static if they're not exported.
7920 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7922 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7923 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7925 * fringe.c (standard_bitmaps): Now static.
7926 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7928 * frame.c: Make symbols static if they're not exported.
7929 (x_report_frame_params, make_terminal_frame): Now static.
7930 (get_frame_param): Now static, unless HAVE_NS.
7931 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7932 (x_get_resource_string): Remove; not used.
7933 * frame.h (make_terminal_frame, x_report_frame_params):
7934 (x_get_resource_string); Remove decls.
7935 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7936 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7938 * font.c, fontset.c: Make symbols static if they're not exported.
7939 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7940 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7941 * font.c (font_close_object): Now static.
7942 * font.h (font_close_object): Remove.
7943 * fontset.c (FONTSET_OBJLIST): Remove.
7944 (free_realized_fontset) #if-0 the body, which does nothing.
7945 (face_suitable_for_char_p): #if-0, as it's never called.
7946 * fontset.h (face_suitable_for_char_p): Remove decl.
7947 * xfaces.c (face_at_string_position):
7948 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7949 since 0 is always ASCII.
7951 * fns.c (weak_hash_tables): Now static.
7953 * fileio.c: Make symbols static if they're not exported.
7954 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7955 (Vwrite_region_annotation_buffers): Now static.
7957 * eval.c: Make symbols static if they're not exported.
7958 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7959 * lisp.h (backtrace_list): Remove decl.
7961 * emacs.c: Make symbols static if they're not exported.
7962 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7963 (fatal_error_code, fatal_error_signal_hook, standard_args):
7965 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7966 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7967 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7968 * lisp.h (fatal_error_signal_hook): Remove decl.
7969 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7971 * editfns.c: Move a (normally-unused) function to its only use.
7972 * editfns.c, lisp.h (get_operating_system_release): Remove.
7973 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7974 worth the hassle of breaking this out.
7976 * xterm.c: Make symbols static if they're not exported.
7977 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7978 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7979 (x_destroy_window, x_delete_display):
7981 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7982 (x_mouse_leave): Remove; unused.
7983 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7984 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7985 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7987 (x_mouse_leave): Declare only if WINDOWSNT.
7988 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7989 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7992 * ftxfont.c: Make symbols static if they're not exported.
7993 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7995 * font.h (ftxfont_driver): Likewise.
7997 * xfns.c: Make symbols static if they're not exported.
7998 (x_last_font_name, x_display_info_for_name):
7999 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
8000 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
8001 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8002 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
8003 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
8004 (last_show_tip_args): Now static.
8005 (xic_defaut_fontset, xic_create_fontsetname): Define only if
8006 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
8007 (x_screen_planes): Remove; unused.
8008 * dispextern.h (x_screen_planes): Remove decl.
8010 * dispnew.c: Make symbols static if they're not exported.
8011 * dispextern.h (redraw_garbaged_frames, scrolling):
8012 (increment_row_positions): Remove.
8013 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8014 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8016 (redraw_garbaged_frames): Remove; unused.
8018 * xfaces.c: Make symbols static if they're not exported.
8019 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8021 * xterm.h (defined_color): Remove decls.
8022 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8023 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8024 (menu_face_changed_default, defined_color, free_realized_face):
8025 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8026 (ascii_face_of_lisp_face): Remove; unused.
8028 * xdisp.c: Make symbols static if they're not exported.
8029 * dispextern.h (scratch_glyph_row, window_box_edges):
8030 (glyph_to_pixel_coords, set_cursor_from_row):
8031 (get_next_display_element, set_iterator_to_next):
8032 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8033 (show_mouse_face): Remove decls
8034 * frame.h (message_buf_print): Likewise.
8035 * lisp.h (pop_message, set_message, check_point_in_composition):
8037 * xterm.h (set_vertical_scroll_bar): Likewise.
8038 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8039 (message_buf_print, scratch_glyph_row, displayed_buffer):
8040 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8041 (get_next_display_element, show_mouse_face, window_box_edges):
8042 (frame_to_window_pixel_xy, check_point_in_composition):
8043 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8044 (glyph_to_pixel_coords): Remove; unused.
8046 * dired.c (file_name_completion): Now static.
8048 * dbusbind.c (xd_in_read_queued_messages): Now static.
8050 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8051 * data.c (circular_list_error): Remove.
8053 * commands.h (last_point_position, last_point_position_buffer):
8054 (last_point_position_window): Remove decls.
8055 * keyboard.c: Make these variables static.
8057 * coding.h (coding, code_convert_region, encode_coding_gap):
8059 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8060 (iso_code_class, detect_coding, code_convert_region): Now static.
8061 (encode_coding_gap): Remove; unused.
8063 * chartab.c (chartab_chars, chartab_bits): Now static.
8065 * charset.h (charset_iso_8859_1): Remove decl.
8066 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8069 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8070 * ccl.c (Vccl_program_table): Now static.
8071 (check_ccl_update): Remove; unused.
8073 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8074 * category.h: ... from here.
8075 * category.c (check_category_table, set_category_set): Now static.
8077 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8078 * lisp.h: Remove these decls.
8080 * buffer.c (buffer_count): Remove unused var.
8082 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8083 so that it's not optimized away.
8084 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8085 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8086 exported only to the debugger.
8088 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
8089 * atimer.h (run_all_atimers): Remove; not exported.
8091 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8092 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8093 was inaccessible from Lisp.
8094 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8095 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8097 alloc.c: Import and export fewer symbols, and remove unused items.
8098 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8100 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8101 it's not optimized away by whole-program optimization.
8102 (message_enable_multibyte, free_misc): Remove.
8103 (catchlist, handlerlist, mark_backtrace):
8104 Declare only if BYTE_MARK_STACK.
8105 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8106 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8107 (message_enable_multibyte): Remove decl.
8108 (free_misc, interval_free_list, float_block, float_block_index):
8109 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8110 (cons_free_list, last_marked_index):
8112 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8113 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8114 (mark_backtrace): Define only if BYTE_MARK_STACK.
8115 * xdisp.c (message_enable_multibyte): Now static.
8117 Declare Lisp_Object Q* variables to be 'static' if not exported.
8118 This makes it easier for human readers (and static analyzers)
8119 to see whether these variables are used from other modules.
8120 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8121 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8122 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8123 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8124 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8125 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8126 * xmenu.c, xselect.c:
8127 Declare Q* vars static if they are not used in other modules.
8128 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8129 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8130 Remove decls of unexported vars.
8131 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8133 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8135 Make Emacs functions such as Fatom 'static' by default.
8136 This makes it easier for human readers (and static analyzers)
8137 to see whether these functions can be called from other modules.
8138 DEFUN now defines a static function. To make the function external
8139 so that it can be used in other C modules, use the new macro DEFUE.
8140 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8141 (Finit_image_library):
8142 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8143 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8144 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8145 Remove decls, since these functions are now static.
8146 (Funintern, Fget_internal_run_time): New decls, since these functions
8147 were already external.
8149 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8150 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8151 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8152 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8153 * keyboard.c, keymap.c, lread.c:
8154 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8155 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8156 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8157 Mark functions with DEFUE instead of DEFUN,
8158 if they are used in other modules.
8159 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8160 decls for now-static functions.
8161 * buffer.h (Fdelete_overlay): Remove decl.
8162 * callproc.c (Fgetenv_internal): Mark as internal.
8163 * composite.c (Fremove_list_of_text_properties): Remove decl.
8164 (Fcomposition_get_gstring): New forward static decl.
8165 * composite.h (Fcomposite_get_gstring): Remove decl.
8166 * dired.c (Ffile_attributes): New forward static decl.
8167 * doc.c (Fdocumntation_property): New forward static decl.
8168 * eval.c (Ffetch_bytecode): New forward static decl.
8169 (Funintern): Remove extern decl; now in .h file where it belongs.
8170 * fileio.c (Fmake_symbolic_link): New forward static decl.
8171 * image.c (Finit_image_library): New forward static decl.
8172 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8173 * intervals.h (Fprevious_property_change):
8174 (Fremove_list_of_text_properties): Remove decls.
8175 * keyboard.c (Fthis_command_keys): Remove decl.
8176 (Fcommand_execute): New forward static decl.
8177 * keymap.c (Flookup_key): New forward static decl.
8178 (Fcopy_keymap): Now static.
8179 * keymap.h (Flookup_key): Remove decl.
8180 * process.c (Fget_process): New forward static decl.
8181 (Fprocess_datagram_address): Mark as internal.
8182 * syntax.c (Fsyntax_table_p): New forward static decl.
8183 (skip_chars): Remove duplicate decl.
8184 * textprop.c (Fprevious_property_change): New forward static decl.
8185 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8187 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8188 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8190 * editfns.c (Fformat): Remove unreachable code.
8192 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8194 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8197 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8199 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8200 when at ZV. (Bug#8487)
8202 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8204 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8206 * keyboard.c (parse_tool_bar_item): Likewise.
8207 * sound.c (sound_cleanup, alsa_close): Likewise.
8208 * termcap.c (tgetent): Likewise.
8209 * xfns.c (x_default_font_parameter): Likewise.
8210 * xsettings.c (read_and_apply_settings): Likewise.
8212 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8213 (overrun_check_free): Protoize.
8215 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8217 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8218 since callers should never pass a negative size.
8219 Change the signature to match that of plain 'read' and 'write'; see
8220 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8221 * lisp.h: Update prototypes of emacs_write and emacs_read.
8223 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8225 * xdisp.c (redisplay_window): Don't try to determine the character
8226 position of the scroll margin if the window start point w->startp
8227 is outside the buffer's accessible region. (Bug#8468)
8229 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8231 Fix write-region and its subroutines for buffers > 2GB.
8232 * fileio.c (a_write, e_write): Modify declaration of arguments and
8233 local variables to support buffers larger than 2GB.
8234 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8236 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8237 argument, local variables, and return value.
8239 * lisp.h: Update prototypes of emacs_write and emacs_read.
8241 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8243 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8245 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8247 Fix more problems found by GCC 4.6.0's static checks.
8249 * xdisp.c (vmessage): Use a better test for character truncation.
8251 * charset.c (load_charset_map): <, not <=, for optimization,
8252 and to avoid potential problems with integer overflow.
8253 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8254 * casetab.c (set_identity, shuffle): Likewise.
8255 * editfns.c (Fformat): Likewise.
8256 * syntax.c (skip_chars): Likewise.
8258 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8259 This also lets GCC 4.6.0 generate slightly better loop code.
8261 * callint.c (Fcall_interactively): <, not <=, for optimization.
8262 (Fcall_interactively): Count the number of arguments produced,
8263 not the number of arguments given. This is simpler and lets GCC
8264 4.6.0 generate slightly better code.
8266 * ftfont.c: Distingish more carefully between FcChar8 and char.
8267 The previous code passed unsigned char * to a functions like
8268 strlen and xstrcasecmp that expect char *, which does not
8269 conform to the C standard.
8270 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8271 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8272 char * when the C standard requires it.
8274 * keyboard.c (read_char): Remove unused var.
8276 * eval.c: Port to Windows vsnprintf (Bug#8435).
8278 (SIZE_MAX): Define if the headers do not.
8279 (verror): Do not give up if vsnprintf returns a negative count.
8280 Instead, grow the buffer. This ports to Windows vsnprintf, which
8281 does not conform to C99. Problem reported by Eli Zaretskii.
8282 Also, simplify the allocation scheme, by avoiding the need for
8283 calling realloc, and removing the ALLOCATED variable.
8285 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8287 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8288 But keep the doprint source code for now, as we might revamp it
8289 and use it again (Bug#8435).
8290 * lisp.h (doprnt): Remove.
8291 * Makefile.in (base_obj): Remove doprnt.o.
8292 * deps.mk (doprnt.o): Remove.
8294 error: Print 32- and 64-bit integers portably (Bug#8435).
8295 Without this change, on typical 64-bit hosts error ("...%d...", N)
8296 was used to print both 32- and 64-bit integers N, which relied on
8298 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8299 * lisp.h (error, verror): Mark as printf-like functions.
8300 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8301 Report overflow in size calculations when allocating printf buffer.
8302 Do not truncate output string at its first null byte.
8303 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8304 Truncate the output at a character boundary, since vsnprintf does not
8306 * charset.c (check_iso_charset_parameter): Convert internal
8307 character to string before calling 'error', since %c now has the
8309 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8310 overflow when computing char to be passed to 'error'. Do not
8311 pass Lisp_Object to 'error'; pass the integer instead.
8312 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8313 formatted with plain %d.
8315 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8317 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8319 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8321 * xterm.c (x_catch_errors): Remove duplicate declaration.
8323 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8325 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8327 2011-04-10 Jim Meyering <meyering@redhat.com>
8329 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8330 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8331 return ssize_t not "int", and use size_t as the buffer length.
8332 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8333 * gnutls.h: Update declarations.
8334 * process.c (read_process_output): Use ssize_t, to match.
8335 (send_process): Likewise.
8337 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8339 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8341 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8343 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8344 Use unsigned char, to match FcChar8 type definition.
8346 * xterm.c (handle_one_xevent):
8347 * xmenu.c (create_and_show_popup_menu):
8348 * xselect.c (x_decline_selection_request)
8349 (x_reply_selection_request): Avoid type-punned deref of X events.
8351 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8353 Fix some uses of `int' instead of EMACS_INT.
8354 * search.c (string_match_1, fast_string_match)
8355 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8356 (scan_buffer, find_next_newline_no_quit)
8357 (find_before_next_newline, search_command, Freplace_match)
8358 (Fmatch_data): Make some `int' variables be EMACS_INT.
8360 * xdisp.c (display_count_lines): 3rd argument and return value now
8361 EMACS_INT. All callers changed.
8362 (pint2hrstr): Last argument is now EMACS_INT.
8364 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8365 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8366 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8367 (decode_coding_utf_16, decode_coding_emacs_mule)
8368 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8369 (decode_coding_ccl, decode_coding_charset)
8370 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8371 (decode_coding_iso_2022, decode_coding_emacs_mule)
8372 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8373 <char_offset, last_offset>: Declare EMACS_INT.
8374 (encode_coding_utf_8, encode_coding_utf_16)
8375 (encode_coding_emacs_mule, encode_invocation_designation)
8376 (encode_designation_at_bol, encode_coding_iso_2022)
8377 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8378 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8380 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8381 (encode_invocation_designation): Last argument P_NCHARS is now
8383 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8384 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8386 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8389 * ccl.c (Fccl_execute_on_string): Declare some variables
8392 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8394 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8396 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8398 * process.c (Fformat_network_address): Doc fix.
8400 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8402 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8404 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8406 * keyboard.c (read_char): Call Lisp function help-form-show,
8407 instead of using internal_with_output_to_temp_buffer.
8408 (Qhelp_form_show): New var.
8409 (syms_of_keyboard): Use DEFSYM macro.
8411 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8413 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8415 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8417 * process.c (Flist_processes): Remove to Lisp.
8418 (list_processes_1): Delete.
8420 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8422 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8424 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8426 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8428 Fix more problems found by GCC 4.6.0's static checks.
8430 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8432 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8434 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8436 * xdisp.c (vmessage): Mark as a printf-like function.
8438 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8440 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8442 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8443 printf-like functions.
8444 (tiff_load): Add casts to remove these marks before passing them
8445 to system-supplied API.
8447 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8449 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8450 This avoids several warnings with gcc -Wstrict-overflow.
8451 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8452 directly, rather than having caller test rule sign. This avoids
8453 some unnecessary tests.
8454 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8455 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8456 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8458 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8459 (xfont_open): Avoid unnecessary tests.
8461 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8463 * composite.h, composite.c (composition_gstring_put_cache):
8464 Use EMACS_INT, not int, for length.
8466 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8467 breaking out part of COMPOSITION_DECODE_RULE.
8468 (COMPOSITION_DECODE_RULE): Use it.
8469 * composite.c (get_composition_id): Remove unused local vars,
8470 by using the new macro.
8472 * textprop.c (set_text_properties_1): Change while to do-while,
8473 since the condition is always true at first.
8475 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8476 (interval_deletion_adjustment): Return unsigned value.
8479 * process.c (list_processes_1, create_pty, read_process_output):
8480 (exec_sentinel): Remove vars that were set but not used.
8481 (create_pty): Remove unnecessary "volatile"s.
8482 (Fnetwork_interface_info): Avoid possibility of int overflow.
8483 (read_process_output): Do adaptive read buffering even if carryover.
8484 (read_process_output): Simplify nbytes computation if buffered.
8486 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8488 * syntax.c (scan_words): Remove var that was set but not used.
8489 (update_syntax_table): Use unsigned instead of int.
8491 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8492 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8493 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8495 * print.c (print_error_message): Avoid int overflow.
8497 * font.c (font_list_entities): Redo for clarity,
8498 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8500 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8501 (font_score): Avoid potential overflow in diff calculation.
8503 * fns.c (substring_both): Remove var that is set but not used.
8504 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8506 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8508 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8509 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8510 can always succeed if overflow has undefined behavior.
8512 * search.c (boyer_moore, wordify): Remove vars set but not used.
8513 (wordify): Omit three unnecessary tests.
8515 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8516 All callers changed. This avoids the need for an unused var.
8518 * casefiddle.c (casify_region): Remove var that is set but not used.
8520 * dired.c (file_name_completion): Remove var that is set but not used.
8522 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8524 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8525 (Finsert_file_contents): Remove unnecessary code checking fd.
8527 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8528 Check for integer overflow on size calculations.
8530 * buffer.c (Fprevious_overlay_change): Remove var that is set
8533 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8534 Remove vars that are set but not used.
8535 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8536 (timer_check_2): Mark vars as initialized.
8538 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8540 * image.c (lookup_image): Remove var that is set but not used.
8541 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8543 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8544 that are set but not used.
8546 * xfns.c (make_invisible_cursor): Don't return garbage
8547 if XCreateBitmapFromData fails (Bug#8410).
8549 * xselect.c (x_get_local_selection, x_handle_property_notify):
8550 Remove vars that are set but not used.
8552 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8553 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8555 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8556 Remove var that is set but not used.
8557 (scroll_bar_windows_size): Now size_t, not int.
8558 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8561 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8562 (map_tty_color) [!defined MSDOS]: Likewise.
8564 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8566 * coding.c: Remove vars that are set but not used.
8567 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8568 All callers changed.
8569 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8570 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8571 (decode_coding_charset): Remove vars that are set but not used.
8573 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8574 that is set but not used.
8576 * print.c (print_object): Remove var that is set but not used.
8578 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8579 The gnulib version avoids calling malloc in the usual case,
8580 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8581 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8582 * filelock.c (current_lock_owner): Likewise.
8583 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8584 * sysdep.c: Include allocator.h, careadlinkat.h.
8585 (emacs_no_realloc_allocator): New static constant.
8586 (emacs_readlink): New function.
8587 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8588 ../lib/careadlinkat.h.
8590 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8592 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8593 first non-nil return value).
8595 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8597 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8598 if not defined (Bug#8403).
8600 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8602 * xdisp.c (display_count_lines): Remove parameter `start',
8603 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8604 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8605 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8606 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8607 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8608 and thereabouts. All callers changed.
8609 (get_per_char_metric): Remove parameter `f', unused since
8610 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8612 2011-04-02 Jim Meyering <meyering@redhat.com>
8614 do not dereference NULL upon failed strdup
8615 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8616 (ns_get_family): Likewise.
8618 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8620 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8622 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8624 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8627 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8629 Add lexical binding.
8631 * window.c (Ftemp_output_buffer_show): New fun.
8632 (Fsave_window_excursion):
8633 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8635 * lread.c (lisp_file_lexically_bound_p): New function.
8636 (Fload): Bind Qlexical_binding.
8637 (readevalloop): Remove `evalfun' arg.
8638 Bind Qinternal_interpreter_environment.
8639 (Feval_buffer): Bind Qlexical_binding.
8640 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8642 (syms_of_lread): Declare `lexical-binding'.
8644 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8646 * keyboard.c (eval_dyn): New fun.
8647 (menu_item_eval_property): Use it.
8649 * image.c (parse_image_spec): Use Ffunctionp.
8651 * fns.c (concat, mapcar1): Accept byte-code-functions.
8653 * eval.c (Fsetq): Handle lexical vars.
8654 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8655 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8656 (FletX, Flet): Obey lexical binding.
8657 (Fcommandp): Handle closures.
8658 (Feval): New `lexical' arg.
8659 (eval_sub): New function extracted from Feval. Use it almost
8660 everywhere where Feval was used. Look up vars in lexical env.
8662 (Ffunctionp): Move from subr.el.
8663 (Ffuncall): Handle closures.
8664 (apply_lambda): Remove `eval_flags'.
8665 (funcall_lambda): Handle closures and new byte-code-functions.
8666 (Fspecial_variable_p): New function.
8667 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8668 but without exporting it to Lisp.
8670 * doc.c (Fdocumentation, store_function_docstring):
8671 * data.c (Finteractive_form): Handle closures.
8673 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8676 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8678 (exec_byte_code): New function extracted from Fbyte_code to handle new
8679 calling convention for byte-code-functions. Add new byte-codes.
8681 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8683 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8685 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8687 * xdisp.c (redisplay_internal): Fix prototype.
8689 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8691 * xdisp.c (SCROLL_LIMIT): New macro.
8692 (try_scrolling): Use it when setting scroll_limit.
8693 Limit scrolling to 100 screen lines.
8694 (redisplay_window): Even when falling back on "recentering",
8695 position point in the window according to scroll-conservatively,
8696 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8698 (try_scrolling): When point is above the window, allow searching
8699 as far as scroll_max, or one screenful, to compute vertical
8700 distance from PT to the scroll margin position. This prevents
8701 try_scrolling from unnecessarily failing when
8702 scroll-conservatively is set to a value slightly larger than the
8703 window height. Clean up the case of PT below the margin at bottom
8704 of window: scroll_max can no longer be INT_MAX. When aggressive
8705 scrolling is in use, don't let point enter the opposite scroll
8706 margin as result of the scroll.
8707 (syms_of_xdisp) <scroll-conservatively>: Document the
8708 threshold of 100 lines for never-recentering scrolling.
8710 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8712 * dispextern.h (move_it_by_lines):
8713 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8714 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8715 (message_log_check_duplicate): Remove parameters `prev_bol' and
8716 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8717 (redisplay_internal): Remove parameter `preserve_echo_area',
8718 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8720 * indent.c (Fvertical_motion):
8721 * window.c (window_scroll_pixel_based, Frecenter):
8722 Don't pass `need_y_p' to `move_it_by_lines'.
8724 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8726 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8727 steal a few bits to be more compact.
8728 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8729 Remove unneeded casts.
8731 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8733 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8735 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8736 binding" message (bug#7967).
8738 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8740 Fix more problems found by GCC 4.6.0's static checks.
8742 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8743 Remove unused local var.
8745 * editfns.c (Fmessage_box): Remove unused local var.
8747 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8748 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8749 Omit unused local vars.
8750 * window.c (shrink_windows): Omit unused local var.
8751 * menu.c (digest_single_submenu): Omit unused local var.
8752 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8753 Omit unused local var.
8755 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8756 Don't assume string length fits in int.
8757 (keyremap_step, read_key_sequence): Use size_t for sizes.
8758 (read_key_sequence): Don't check last_real_key_start redundantly.
8760 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8761 instead of alloca (Bug#8344).
8763 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8764 (Fbacktrace_frame): Don't assume nframes fits in int.
8766 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8768 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8771 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8773 * cm.c (calccost): Turn while-do into do-while, for clarity.
8775 * keyboard.c (syms_of_keyboard): Use the same style as later
8776 in this function when indexing through an array. This also
8777 works around GCC bug 48267.
8779 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8781 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8783 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8784 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8786 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8787 This avoids undefined behavior on integer overflow, and is a bit
8788 more convenient anyway since it is compared to a size_t variable.
8790 Variadic C functions now count arguments with size_t, not int.
8791 This avoids an unnecessary limitation on 64-bit machines, which
8792 caused (substring ...) to crash on large vectors (Bug#8344).
8793 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8794 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8795 All variadic functions and their callers changed accordingly.
8796 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8797 * data.c (arith_driver, float_arith_driver): Likewise.
8798 * editfns.c (general_insert_function): Likewise.
8799 * eval.c (struct backtrace.nargs, interactive_p)
8800 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8801 (funcall_lambda, mark_backtrace): Likewise.
8802 * fns.c (concat): Likewise.
8803 * frame.c (x_set_frame_parameters): Likewise.
8804 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8805 0 if not found, not -1. All callers changed.
8807 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8808 (stack_copy_size): Now size_t, not int.
8809 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8811 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8813 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8814 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8815 All callers changed.
8817 * lisp.h (multibyte_char_to_unibyte):
8818 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8819 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8820 * character.h (CHAR_TO_BYTE8):
8821 * cmds.c (internal_self_insert):
8822 * editfns.c (general_insert_function):
8823 * keymap.c (push_key_description):
8824 * search.c (Freplace_match):
8825 * xdisp.c (message_dolog, set_message_1): All callers changed.
8827 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8829 * keyboard.c (safe_run_hook_funcall): New function.
8830 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8831 don't set the hook to nil, but remove the offending function instead.
8832 (Qcommand_hook_internal): Remove, unused.
8833 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8834 Vcommand_hook_internal.
8836 * eval.c (enum run_hooks_condition): Remove.
8837 (funcall_nil, funcall_not): New functions.
8838 (run_hook_with_args): Call each function through a `funcall' argument.
8839 Remove `cond' argument, now redundant.
8840 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8841 (Frun_hook_with_args_until_failure): Adjust accordingly.
8842 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8844 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8846 * dispextern.h (string_buffer_position): Remove declaration.
8848 * print.c (strout): Remove parameter `multibyte', unused since
8849 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8851 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8852 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8853 All callers changed.
8855 * w32.c (_wsa_errlist): Use braces for struct initializers.
8857 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8858 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8859 All callers changed.
8860 (string_buffer_position): Likewise. Also, make static (it's never
8861 used outside xdisp.c).
8862 (cursor_row_p): Remove parameter `w', unused since
8863 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8864 (decode_mode_spec): Remove parameter `precision', introduced during
8865 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8866 All callers changed.
8868 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8870 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8872 2011-03-27 Anders Lindgren <andlind@gmail.com>
8874 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8875 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8876 (ns_update_auto_hide_menu_bar): New functions.
8877 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8878 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8879 ns_constrain_all_frames.
8880 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8881 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8883 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8885 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8887 2011-03-27 Glenn Morris <rgm@gnu.org>
8889 * syssignal.h: Replace RETSIGTYPE with void.
8890 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8891 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8892 Replace SIGTYPE with void everywhere.
8893 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8894 * s/template.h (SIGTYPE): Remove commented out definition.
8896 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8898 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8899 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8901 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8903 * w32.c (read_unc_volume): Use parameter `henum', instead of
8904 global variable `wget_enum_handle'.
8906 * keymap.c (describe_vector): Remove parameters `indices' and
8907 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8908 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8910 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8912 * keyboard.c (timer_check): Remove parameter `do_it_now',
8913 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8914 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8915 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8917 * keyboard.c (read_char):
8918 * w32menu.c (w32_menu_display_help):
8919 * xmenu.c (show_help_event, menu_help_callback):
8920 Adjust calls to `show_help_echo'.
8922 * gtkutil.c (xg_maybe_add_timer):
8923 * keyboard.c (readable_events):
8924 * process.c (wait_reading_process_output):
8925 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8927 * insdel.c (adjust_markers_gap_motion):
8928 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8929 (gap_left, gap_right): Don't call it.
8931 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8933 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8934 incurred during fontification.
8936 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8938 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8939 (DEFVAR_PER_BUFFER): Don't pass it.
8941 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8942 (scrolling_window): Don't pass it.
8944 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8946 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8948 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8950 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8951 of variables specific to SELinux and computation of `encoded_absname'.
8953 * image.c (XPutPixel): Remove unused variable `height'.
8955 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8957 * unexw32.c (get_section_info): Remove unused variable `section'.
8959 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8960 (system_process_attributes): Remove unused variable `sess'.
8961 (sys_read): Remove unused variable `err'.
8963 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8964 (w32_wnd_proc): Remove unused variable `isdead'.
8965 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8966 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8967 (x_create_tip_frame): Remove unused variable `tem'.
8969 * w32inevt.c (w32_console_read_socket):
8970 Remove unused variable `no_events'.
8972 * w32term.c (x_draw_composite_glyph_string_foreground):
8973 Remove unused variable `width'.
8975 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8977 * w32term.c (x_set_glyph_string_clipping):
8978 Don't pass uninitialized region to CombineRgn.
8980 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8982 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8983 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8984 (Fx_close_connection): Remove unused variable `i'.
8986 * w32font.c (w32font_draw): Return number of glyphs.
8987 (w32font_open_internal): Remove unused variable `i'.
8988 (w32font_driver): Add missing initializer.
8990 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8991 (fill_in_menu): Remove unused variable `items_added'.
8993 * w32term.c (last_mouse_press_frame): Remove static global variable.
8994 (w32_clip_to_row): Remove unused variable `f'.
8995 (x_delete_terminal): Remove unused variable `i'.
8997 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8998 (NOTHING): Remove unused static global variable.
8999 (uniscribe_check_otf): Remove unused variable `table'.
9000 (uniscribe_font_driver): Add missing initializers.
9002 2011-03-23 Julien Danjou <julien@danjou.info>
9004 * term.c (Fsuspend_tty, Fresume_tty):
9005 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
9006 * window.c (temp_output_buffer_show):
9007 * insdel.c (signal_before_change):
9008 * frame.c (Fhandle_switch_frame):
9009 * fileio.c (Fdo_auto_save):
9010 * emacs.c (Fkill_emacs):
9011 * editfns.c (save_excursion_restore):
9012 * cmds.c (internal_self_insert):
9013 * callint.c (Fcall_interactively):
9014 * buffer.c (Fkill_all_local_variables):
9015 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9017 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
9018 unconditionally since it does the check itself.
9020 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
9022 Fix more problems found by GCC 4.5.2's static checks.
9024 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9025 the first time through the loop, since we know p0 < p1 then.
9026 This also avoids a gcc -Wstrict-overflow warning.
9028 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9029 leading to a memory leak, possible in functions like
9030 load_charset_map_from_file that can allocate an unbounded number
9031 of objects (Bug#8318).
9033 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9034 that could (at least in theory) be that large.
9036 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9037 This is less likely to overflow, and avoids undefined behavior if
9038 overflow does occur. All callers changed. Use strtoul to scan
9039 for the unsigned long integer.
9040 (pint2hrstr): Simplify and tune code slightly.
9041 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
9043 * scroll.c (do_scrolling): Work around GCC bug 48228.
9044 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9046 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9047 This also avoids a warning with gcc -Wstrict-overflow.
9048 (validate_x_resource_name): Simplify count usage.
9049 This also avoids a warning with gcc -Wstrict-overflow.
9051 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9054 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
9056 * process.c (Fmake_network_process): Use socklen_t, not int,
9057 where POSIX says socklen_t is required in portable programs.
9058 This fixes a porting bug on hosts like 64-bit HP-UX, where
9059 socklen_t is wider than int (Bug#8277).
9060 (Fmake_network_process, server_accept_connection):
9061 (wait_reading_process_output, read_process_output):
9064 * process.c: Rename or move locals to avoid shadowing.
9065 (list_processes_1, Fmake_network_process):
9066 (read_process_output_error_handler, exec_sentinel_error_handler):
9067 Rename or move locals.
9068 (Fmake_network_process): Define label "retry_connect" only if needed.
9069 (Fnetwork_interface_info): Fix pointer signedness.
9070 (process_send_signal): Add cast to avoid pointer signedness problem.
9071 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
9072 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
9074 Make tparam.h and terminfo.c consistent.
9075 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9076 Include tparam.h instead, since it declares them.
9077 * cm.h (PC): Remove extern decl; tparam.h now does this.
9078 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9079 * terminfo.c: Include tparam.h, to check interfaces.
9080 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9081 (tparam): Adjust signature to match interface in tparam.h;
9082 this removes some undefined behavior. Check that outstring and len
9083 are zero, which they always are with Emacs.
9084 * tparam.h (PC, BC, UP): New extern decls.
9086 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
9087 (xftfont_open): Rename locals to avoid shadowing.
9089 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
9090 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9091 (OTF_TAG_SYM): Omit macro if not needed.
9092 (ftfont_list): Remove unused local.
9093 (get_adstyle_property, ftfont_pattern_entity):
9094 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9095 Rename locals to avoid shadowing.
9097 * xfont.c (xfont_list_family): Mark var as initialized.
9099 * xml.c (make_dom): Now static.
9101 * composite.c (composition_compute_stop_pos): Rename local to
9103 (composition_reseat_it): Remove unused locals.
9104 (find_automatic_composition, composition_adjust_point): Likewise.
9105 (composition_update_it): Mark var as initialized.
9106 (find_automatic_composition): Mark vars as initialized,
9107 with a FIXME (Bug#8290).
9109 character.h: Rename locals to avoid shadowing.
9110 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9111 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9112 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9113 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9116 * textprop.c (property_change_between_p): Remove; unused.
9118 * intervals.c (interval_start_pos): Now static.
9120 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9122 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9123 Rename locals to avoid shadowing.
9125 * sound.c (wav_play, au_play, Fplay_sound_internal):
9126 Fix pointer signedness.
9127 (alsa_choose_format): Remove unused local var.
9128 (wav_play): Initialize a variable to 0, to prevent undefined
9129 behavior (Bug#8278).
9131 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9133 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9135 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9136 clobbering (Bug#8298).
9137 * sysdep.c (sys_subshell): Likewise.
9138 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
9140 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9141 This should get cleaned up, so that child_setup has the
9142 same signature on all platforms.
9144 * callproc.c (call_process_cleanup): Now static.
9145 (relocate_fd): Rename locals to avoid shadowing.
9147 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
9149 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9150 not to be necessary, and produces flickering.
9152 2011-03-20 Glenn Morris <rgm@gnu.org>
9154 * config.in: Remove file.
9156 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
9158 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9159 are now in src/globals.h.
9160 (syms_of_minibuf): Remove spurious & from previous change.
9162 2011-03-20 Leo Liu <sdl.web@gmail.com>
9164 * minibuf.c (completing-read-function): New variable.
9165 (completing-read-default): Rename from completing-read.
9166 (completing-read): Call completing-read-function.
9168 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9170 * xfaces.c (Fx_load_color_file):
9171 Read color file from absolute filename (bug#8250).
9173 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9175 * makefile.w32-in: Update dependencies.
9177 2011-03-17 Eli Zaretskii <eliz@gnu.org>
9179 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9181 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9183 Fix more problems found by GCC 4.5.2's static checks.
9185 * process.c (make_serial_process_unwind, send_process_trap):
9186 (sigchld_handler): Now static.
9188 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9189 That way, the code declares only the vars that it needs.
9190 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9191 * s/cygwin.h (PTY_ITERATION): Likewise.
9192 * s/darwin.h (PTY_ITERATION): Likewise.
9193 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9195 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9196 * process.c (allocate_pty): Don't declare stb unless it's needed.
9198 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9199 (CONSTANTLIM): Remove; unused.
9200 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9201 Define only if needed.
9203 * unexelf.c (unexec): Name an expression,
9204 to avoid gcc -Wbad-function-cast warning.
9205 Use a different way to cause a compilation error if anyone uses
9206 n rather than nn, a way that does not involve shadowing.
9207 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9209 * deps.mk (unexalpha.o): Remove; unused.
9211 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9212 * unexec.h: New file.
9213 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9214 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9216 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9217 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9218 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9219 Change as necessary to match prototype in unexec.h.
9221 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9223 (back_comment, skip_chars): Mark vars as initialized.
9225 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9226 Rename locals to avoid shadowing.
9228 * lread.c (read1): Rewrite so as not to use empty "else".
9229 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9231 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9233 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9234 warning when compiling print.c.
9236 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9237 instead of using an uninitialized var.
9238 (font_sort_entities): Mark var as initialized.
9240 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9242 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9243 pointers to constants.
9244 (font_parse_fcname): Remove unused vars.
9245 (font_delete_unmatched): Now static.
9246 (font_get_spec): Remove; unused.
9247 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9248 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9249 Rename or move locals to avoid shadowing.
9251 * fns.c (require_nesting_list, require_unwind): Now static.
9252 (Ffillarray): Rename locals to avoid shadowing.
9254 * floatfns.c (domain_error2): Define only if needed.
9255 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9257 * alloc.c (mark_backtrace): Move decl from here ...
9258 * lisp.h: ... to here, so that it can be checked.
9260 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9261 (Fdefvar): Rewrite so as not to use empty "else".
9262 (lisp_indirect_variable): Name an expression,
9263 to avoid gcc -Wbad-function-cast warning.
9264 (Fdefvar): Rename locals to avoid shadowing.
9266 * callint.c (quotify_arg, quotify_args): Now static.
9267 (Fcall_interactively): Rename locals to avoid shadowing.
9268 Use const pointer when appropriate.
9270 * lisp.h (get_system_name, get_operating_system_release):
9271 Move decls here, to check interfaces.
9272 * process.c (get_operating_system_release): Move decl to lisp.h.
9273 * xrdb.c (get_system_name): Likewise.
9274 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9275 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9276 some of which prompt warnings from gcc -Wbad-function-cast.
9277 (Fformat_time_string, Fencode_time, Finsert_char):
9278 (Ftranslate_region_internal, Fformat):
9279 Rename or remove local vars to avoid shadowing.
9280 (Ftranslate_region_internal): Mark var as initialized.
9282 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9285 * lisp.h (eassert): Check that the argument compiles, even if
9286 ENABLE_CHECKING is not defined.
9288 * data.c (Findirect_variable): Name an expression, to avoid
9289 gcc -Wbad-function-cast warning.
9290 (default_value, arithcompare, arith_driver, arith_error): Now static.
9291 (store_symval_forwarding): Rename local to avoid shadowing.
9292 (Fmake_variable_buffer_local, Fmake_local_variable):
9293 Mark variables as initialized.
9294 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9296 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9297 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9298 Rename locals to avoid shadowing.
9299 (mark_stack): Move local variables into the #ifdef region where
9301 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9302 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9304 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9305 (GC_STRING_CHARS): Remove; not used.
9306 (Fmemory_limit): Cast sbrk's returned value to char *.
9308 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9309 avoids undefined behavior in theory.
9311 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9313 Use functions, not macros, for up- and down-casing (Bug#8254).
9314 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9315 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9316 to use the following functions instead of these macros.
9317 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9318 EMACS_INT, since callers assume the returned value fits in int.
9319 (upcase1): Likewise, for UPCASE_TABLE.
9320 (uppercasep, lowercasep, upcase): New static inline functions.
9321 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9322 the race-condition problem in the old DOWNCASE.
9324 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9325 Rename locals to avoid shadowing.
9326 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9327 (regex_compile, re_search_2, re_match_2_internal):
9328 Remove unused local vars.
9329 (FREE_VAR): Rewrite so as not to use empty "else",
9330 which gcc can warn about.
9331 (regex_compile, re_match_2_internal): Mark locals as initialized.
9332 (RETALLOC_IF): Define only if needed.
9333 (WORDCHAR_P): Likewise. This one is never needed, but is used
9334 only in a comment talking about a compiler bug, so put inside
9335 the #if 0 of that comment.
9336 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9337 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9340 * search.c (boyer_moore): Rename locals to avoid shadowing.
9341 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9342 (PREV_CHAR_BOUNDARY): Likewise.
9344 * search.c (simple_search): Remove unused var.
9346 * dired.c (compile_pattern): Move decl from here ...
9347 * lisp.h: ... to here, so that it can be checked.
9348 (struct re_registers): New forward decl.
9350 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9352 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9354 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9355 Rename locals to avoid shadowing.
9356 (Fvertical_motion): Mark locals as initialized.
9358 * casefiddle.c (casify_object, casify_region): Now static.
9359 (casify_region): Mark local as initialized.
9361 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9363 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9364 New macros, so that the caller can use some names other than
9365 gcpro1, gcpro2, etc.
9366 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9368 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9369 argument, for consistency with GCPRO2_VAR, etc: it is now the
9370 prefix of the variable, not the variable itself. All uses
9372 * dired.c (directory_files_internal, file_name_completion):
9373 Rename locals to avoid shadowing.
9375 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9376 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9377 dired.c's scmp function, had undefined behavior.
9378 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9379 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9380 * buffer.h: ... to here, because these macros use current_buffer,
9381 and the new implementation with inline functions needs to have
9382 current_buffer in scope now, rather than later when the macros
9384 (downcase, upcase1): New static inline functions.
9385 (DOWNCASE, UPCASE1): Reimplement using these functions.
9386 This avoids undefined behavior in expressions like
9387 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9388 from race conditions in accessing the global variables
9389 case_temp1 and case_temp2.
9390 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9391 * lisp.h (case_temp1, case_temp2): Remove their decls.
9392 * character.h (ASCII_CHAR_P): Move from here ...
9393 * lisp.h: ... to here, so that the inline functions mentioned
9396 * dired.c (directory_files_internal_unwind): Now static.
9398 * fileio.c (file_name_as_directory, directory_file_name):
9399 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9401 (file_name_as_directory): Use const pointers when appropriate.
9402 (Fexpand_file_name): Likewise. In particular, newdir might
9403 point at constant storage, so make it a const pointer.
9404 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9405 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9407 (Fset_file_times, Finsert_file_contents, auto_save_error):
9408 Rename locals to avoid shadowing.
9410 * minibuf.c (choose_minibuf_frame_1): Now static.
9411 (Ftry_completion, Fall_completions): Rename or remove locals
9414 * marker.c (bytepos_to_charpos): Remove; unused.
9416 * lisp.h (verify_bytepos, count_markers): New decls,
9417 so that gcc does not warn that these functions aren't declared.
9419 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9420 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9421 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9422 (copy_text): Remove unused local var.
9424 * filelock.c (within_one_second): Now static.
9425 (lock_file_1): Rename local to avoid shadowing.
9427 * buffer.c (fix_overlays_before): Mark locals as initialized.
9428 (fix_start_end_in_overlays): Likewise. This function should be
9429 simplified by using pointers-to-pointers, but that's a different
9431 (switch_to_buffer_1): Now static.
9432 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9433 (report_overlay_modification): Rename locals to avoid shadowing.
9435 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9436 Fix pointer signedness issue.
9437 (sys_subshell): Mark local as volatile if checking for lint,
9438 to suppress a gcc -Wclobbered warning that does not seem to be right.
9439 (MAXPATHLEN): Define only if needed.
9441 * process.c (serial_open, serial_configure): Move decls from here ...
9442 * systty.h: ... to here, so that they can be checked.
9444 * fns.c (get_random, seed_random): Move extern decls from here ...
9445 * lisp.h: ... to here, so that they can be checked.
9447 * sysdep.c (reset_io): Now static.
9448 (wait_for_termination_signal): Remove; unused.
9450 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9451 (copy_keymap_item, append_key, push_text_char_description):
9453 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9454 (DENSE_TABLE_SIZE): Remove; unused.
9455 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9456 (describe_map_tree):
9457 Rename locals to avoid shadowing.
9459 * keyboard.c: Declare functions static if they are not used elsewhere.
9460 (echo_char, echo_dash, cmd_error, top_level_2):
9461 (poll_for_input, handle_async_input): Now static.
9462 (read_char, kbd_buffer_get_event, make_lispy_position):
9463 (make_lispy_event, make_lispy_movement, apply_modifiers):
9464 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9465 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9466 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9467 (read_key_sequence, read_char): Mark locals as initialized.
9468 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9470 * keyboard.h (make_ctrl_char): New decl.
9471 (mark_kboards): Move decl here ...
9472 * alloc.c (mark_kboards): ... from here.
9474 * lisp.h (force_auto_save_soon): New decl.
9476 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9477 (DEFINE_DUMMY_FUNCTION): New macro.
9478 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9480 (main): Add casts to avoid warnings
9481 if GCC considers string literals to be constants.
9483 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9485 * dbusbind.c: Pointer signedness fixes.
9486 (xd_signature, xd_append_arg, xd_initialize):
9487 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9488 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9489 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9490 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9492 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9493 if GCC considers string literals to be constants.
9494 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9496 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9498 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9499 (print_preprocess, print_object): New macro to fix last change.
9501 * print.c (print_preprocess): Don't forget font objects.
9503 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9505 * emacs.c (USAGE3): Doc fixes.
9507 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9509 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9512 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9514 * lisp.h (VWindow_system, Qfile_name_history):
9515 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9516 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9517 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9519 * w32select.c: Don't #include "keyboard.h".
9520 (run_protected): Add extern declaration for waiting_for_input.
9522 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9523 * w32console.c (detect_input_pending, read_input_pending)
9524 (encode_terminal_code):
9525 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9526 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9527 (w32_system_caret_y, Qfile_name_history):
9528 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9529 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9530 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9531 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9532 * w32proc.c (Qlocal, report_file_error):
9533 * w32term.c (Vwindow_system, updating_frame):
9534 * w32uniscribe.c (initialized, uniscribe_font_driver):
9535 Remove unneeded extern declarations.
9537 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9539 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9541 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9543 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9544 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9545 These macros can no longer be used for assignment.
9547 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9548 Assign struct members directly, instead of using BUF_BEGV etc.
9549 (record_buffer_markers, fetch_buffer_markers): New functions for
9550 recording and fetching special buffer markers.
9551 (set_buffer_internal_1, set_buffer_temp): Use them.
9553 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9555 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9557 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9558 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9560 * xdisp.c (hscroll_window_tree):
9561 (reconsider_clip_changes): Use PT instead of BUF_PT.
9563 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9565 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9566 $(EMACS_ROOT)/lib/intprops.h.
9568 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9570 Fix more problems found by GCC 4.5.2's static checks.
9572 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9573 to unsigned char * to avoid compiler diagnostic.
9574 (xg_free_frame_widgets): Make it clear that a local variable is
9575 needed only if USE_GTK_TOOLTIP.
9576 (gdk_window_get_screen): Make it clear that this macro is needed
9577 only if USE_GTK_TOOLTIP.
9578 (int_gtk_range_get_value): New function, which avoids a diagnostic
9579 from gcc -Wbad-function-cast.
9580 (xg_set_toolkit_scroll_bar_thumb): Use it.
9581 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9582 diagnostic from gcc -Wbad-function-cast.
9583 (get_utf8_string, xg_get_file_with_chooser):
9584 Rename locals to avoid shadowing.
9585 (create_dialog): Move locals to avoid shadowing.
9587 * xgselect.c (xg_select): Remove unused var.
9589 * image.c (four_corners_best): Mark locals as initialized.
9590 (gif_load): Initialize transparent_p to zero (Bug#8238).
9591 Mark another local as initialized.
9592 (my_png_error, my_error_exit): Mark with NO_RETURN.
9594 * image.c (clear_image_cache): Now static.
9595 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9596 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9597 (x_edge_detection): Remove unnecessary cast that
9598 gcc -Wbad-function-cast diagnoses.
9599 (gif_load): Fix pointer signedness.
9600 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9601 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9603 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9605 Improve quality of tests for time stamp overflow.
9606 For example, without this patch (encode-time 0 0 0 1 1
9607 1152921504606846976) returns the obviously-bogus value (-948597
9608 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9609 reports time overflow. See
9610 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9611 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9612 * editfns.c: Include limits.h and intprops.h.
9613 (TIME_T_MIN, TIME_T_MAX): New macros.
9614 (time_overflow): Move earlier, to before first use.
9615 (hi_time, lo_time): New functions, for an accurate test for
9617 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9618 (Fget_internal_run_time): Don't assume time_t fits in int.
9619 (make_time): Use list2 instead of Fcons twice.
9620 (Fdecode_time): More accurate test for out-of-range times.
9621 (check_tm_member): New function.
9622 (Fencode_time): Use it, to test for out-of-range times.
9623 (lisp_time_argument): Don't rely on undefined left-shift and
9624 right-shift behavior when checking for time stamp overflow.
9626 * editfns.c (time_overflow): New function, refactoring common code.
9627 (Fformat_time_string, Fdecode_time, Fencode_time):
9628 (Fcurrent_time_string): Use it.
9630 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9631 * dired.c (make_time): Move to ...
9632 * editfns.c (make_time): ... here.
9633 * systime.h: Note the move.
9635 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9637 * fringe.c (update_window_fringes): Remove unused variables.
9639 * unexmacosx.c (copy_data_segment): Also copy __got section.
9642 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9644 * termcap.c [MSDOS]: Include "msdos.h".
9645 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9646 Constify `char *' arguments and their references according to
9647 prototypes in tparam.h.
9649 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9651 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9652 Adapt all references accordingly.
9654 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9656 2011-03-11 Tom Tromey <tromey@redhat.com>
9658 * buffer.c (syms_of_buffer): Remove obsolete comment.
9660 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9662 * termhooks.h (encode_terminal_code): Declare prototype.
9664 * msdos.c (encode_terminal_code): Don't declare prototype.
9666 * term.c (encode_terminal_code): Now external again, used by
9667 w32console.c and msdos.c.
9669 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9670 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9672 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9674 Fix some minor problems found by GCC 4.5.2's static checks.
9676 * fringe.c (update_window_fringes): Mark locals as initialized
9678 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9680 * alloc.c (mark_fringe_data): Move decl from here ...
9681 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9682 to check its interface.
9683 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9685 * fontset.c (free_realized_fontset): Now static.
9686 (Fset_fontset_font): Rename local to avoid shadowing.
9687 (fontset_font): Mark local as initialized.
9688 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9690 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9692 * xselect.c (x_disown_buffer_selections): Remove; not used.
9693 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9694 (x_own_selection, Fx_disown_selection_internal): Rename locals
9696 (x_handle_dnd_message): Remove local to avoid shadowing.
9698 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9699 so that the caller can use some name other than gcpro1.
9700 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9701 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9702 (Fx_backspace_delete_keys_p):
9703 Use them to avoid shadowing, and rename vars to avoid shadowing.
9704 (x_decode_color, x_set_name, x_window): Now static.
9705 (Fx_create_frame): Add braces to silence GCC warning.
9706 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9707 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9708 Remove unused locals.
9709 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9710 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9711 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9714 * xterm.h (x_mouse_leave): New decl.
9716 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9717 Remove unused functions.
9718 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9719 (x_calc_absolute_position): Now static.
9720 (XTread_socket): Don't define label "out" unless it's used.
9721 Don't declare local "event" unless it's used.
9722 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9723 unless they are used.
9724 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9725 (x_fatal_error_signal): Remove; not used.
9726 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9727 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9728 (x_error_catcher, x_connection_closed, x_error_handler):
9729 (x_error_quitter, xembed_send_message, x_iconify_frame):
9730 (my_log_handler): Rename locals to avoid shadowing.
9731 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9732 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9734 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9735 Rename or move locals to avoid shadowing.
9736 (tty_defined_color, merge_face_heights): Now static.
9737 (free_realized_faces_for_fontset): Remove; not used.
9738 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9739 does not deduce is never used uninitialized.
9740 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9741 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9743 * terminal.c (store_terminal_param): Now static.
9745 * xmenu.c (menu_highlight_callback): Now static.
9746 (set_frame_menubar): Remove unused local.
9747 (xmenu_show): Rename parameter to avoid shadowing.
9748 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9749 since they might point to immutable storage.
9750 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9751 since it's unused otherwise.
9753 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9754 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9755 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9756 avoids a gcc -Wuninitialized diagnostic.
9757 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9758 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9759 does not deduce are never used uninitialized.
9761 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9763 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9764 * window.c (window_loop, size_window):
9765 (run_window_configuration_change_hook, enlarge_window): Likewise.
9767 * window.c (display_buffer): Now static.
9768 (size_window): Mark variables that gcc -Wuninitialized
9769 does not deduce are never used uninitialized.
9770 * window.h (check_all_windows): New decl, to forestall
9771 gcc -Wmissing-prototypes diagnostic.
9772 * dispextern.h (bidi_dump_cached_states): Likewise.
9774 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9776 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9778 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9779 and to avoid gcc -Wuninitialized warning.
9780 (load_charset_map): Mark variables that gcc -Wuninitialized
9781 does not deduce are never used uninitialized.
9782 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9784 * coding.c (coding_set_source, coding_set_destination):
9785 Use "else { /* comment */ }" rather than "else /* comment */;"
9786 for clarity, and to avoid gcc -Wempty-body warning.
9787 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9788 a block, when the outer 'i' will do.
9789 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9790 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9791 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9792 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9793 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9794 Rename locals to avoid shadowing.
9795 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9796 * coding.c (emacs_mule_char, encode_invocation_designation):
9797 Now static, since they're not used elsewhere.
9798 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9799 (decode_coding_object, encode_coding_object, detect_coding_system):
9800 (decode_coding_emacs_mule): Mark variables that gcc
9801 -Wuninitialized does not deduce are never used uninitialized.
9802 (detect_coding_iso_2022): Initialize a local variable that might
9803 be used uninitialized. Leave a FIXME because it's not clear that
9804 this initialization is needed. (Bug#8211)
9805 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9806 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9807 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9808 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9809 Remove unused macros.
9811 * category.c (hash_get_category_set): Remove unused local var.
9812 (copy_category_table): Now static, since it's not used elsewhere.
9813 * character.c (string_count_byte8): Likewise.
9815 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9816 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9818 * chartab.c (copy_sub_char_table): Now static, since it's not used
9820 (sub_char_table_ref_and_range, char_table_ref_and_range):
9821 Rename locals to avoid shadowing.
9822 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9824 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9825 (BIDI_BOB): Remove unused macro.
9827 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9828 deduce are never used uninitialized.
9829 * term.c (encode_terminal_code): Likewise.
9831 * term.c (encode_terminal_code): Now static. Remove unused local.
9833 * tparam.h: New file.
9834 * term.c, tparam.h: Include it.
9835 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9836 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9837 Move these decls to tparam.h, and make them agree with what
9838 is actually in tparam.c. The previous trick of using incompatible
9839 decls in different modules does not conform to the C standard.
9840 All callers of tparam changed to use tparam's actual API.
9841 * tparam.c (tparam1, tparam, tgoto):
9842 Use const pointers where appropriate.
9844 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9845 * cm.h (struct cm): Likewise.
9846 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9847 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9848 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9849 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9850 (turn_on_face, init_tty): Likewise.
9851 * termchar.h (struct tty_display_info): Likewise.
9853 * term.c (term_mouse_position): Rename local to avoid shadowing.
9855 * alloc.c (mark_ttys): Move decl from here ...
9856 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9858 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9860 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9862 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9864 * search.c (compile_pattern_1): Remove argument regp, unused since
9865 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9866 (compile_pattern): Don't pass it.
9868 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9870 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9871 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9873 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9875 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9877 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9878 gdk_window_get_screen, gdk_window_get_geometry,
9879 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9880 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9881 (xg_get_pixbuf_from_pixmap): New function.
9882 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9883 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9884 Call xg_get_pixbuf_from_pixmap instead of
9885 gdk_pixbuf_get_from_drawable.
9886 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9887 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9888 (xg_check_special_colors): Use GtkStyleContext and its functions
9890 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9891 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9892 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9893 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9894 Call gtk_widget_get_preferred_size.
9895 (xg_frame_resized): gdk_window_get_geometry only takes 5
9897 (xg_win_to_widget, xg_event_is_for_menubar):
9898 Call gdk_x11_window_lookup_for_display.
9899 (xg_set_widget_bg): New function.
9900 (delete_cb): New function.
9901 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9902 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9903 (xg_set_background_color): Call xg_set_widget_bg.
9904 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9905 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9906 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9907 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9909 (update_frame_tool_bar): Call gtk_widget_hide.
9910 (xg_initialize): Use GDK_KEY_g.
9912 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9914 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9916 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9917 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9918 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9920 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9922 * w32xfns.c (select_palette): Check success of RealizePalette against
9923 GDI_ERROR, not zero.
9925 See ChangeLog.11 for earlier changes.
9931 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9933 This file is part of GNU Emacs.
9935 GNU Emacs is free software: you can redistribute it and/or modify
9936 it under the terms of the GNU General Public License as published by
9937 the Free Software Foundation, either version 3 of the License, or
9938 (at your option) any later version.
9940 GNU Emacs is distributed in the hope that it will be useful,
9941 but WITHOUT ANY WARRANTY; without even the implied warranty of
9942 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9943 GNU General Public License for more details.
9945 You should have received a copy of the GNU General Public License
9946 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.